Timeline


and

12/30/09:

20:58 Changeset [52677] by eric@webkit.org

2009-12-30 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[Chromium] Delete ResourceRequest::securityInfo
https://bugs.webkit.org/show_bug.cgi?id=26847

  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):

2009-12-30 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[Chromium] Delete ResourceRequest::securityInfo
https://bugs.webkit.org/show_bug.cgi?id=26847

  • platform/network/chromium/ResourceRequest.h:
16:12 Changeset [52676] by ajwong@chromium.org

Not reviewed. Trivial Chromium build fix.

Add static_cast<unsigned>() to fix signed/unsigned comparison warning.

  • src/AutocompletePopupMenuClient.cpp:

(WebKit::AutocompletePopupMenuClient::selectionChanged):

15:54 Changeset [52675] by dglazkov@chromium.org

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Remove unused code from V8DOMWrapper.

  • bindings/v8/V8DOMWrapper.cpp: Removed code that I added but it's no longer used.
  • bindings/v8/V8DOMWrapper.h: Ditto.
15:47 Changeset [52674] by dglazkov@chromium.org

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Generate configuring undetectable collection.
https://bugs.webkit.org/show_bug.cgi?id=33063

Refactoring, covered by existing tests.

  • bindings/scripts/CodeGeneratorV8.pm: Added GenerateImplementationMasqueradeAsUndefined.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Touched to keep IB-based builds happy.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed hand-configuring.
15:08 Changeset [52673] by eric@webkit.org

2009-12-30 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by Dimitri Glazkov.

Autocomplete in Chromium now offers suggestions within the input element as a user
a) types text that produces some autocomplete suggestions, and
b) scrolls through suggested values in the menu
The suggested value is rendered but not exposed through JS unti the
user makes the final selection.

No new tests since this new functionality (autocomplete suggestions)
is intentionally hidden from everything else than renderer.

  • src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::initialize): (WebKit::AutocompletePopupMenuClient::setInitialAutocompleteValue): (WebKit::AutocompletePopupMenuClient::selectionChanged): (WebKit::AutocompletePopupMenuClient::popupDidHide): (WebKit::AutocompletePopupMenuClient::setTextFromItem): (WebKit::AutocompletePopupMenuClient::resetLastFieldValue):
  • src/AutocompletePopupMenuClient.h:

2009-12-30 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by Dimitri Glazkov.

Added ability for PopupMenuClient to signal when
a) selection changed, and
b) weather suggested value should be accepted when popup menu closes

No new tests since this new functionality (autocomplete suggestions)
is intentionally hidden from everything else than renderer.

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::hidePopup): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::clearSelection): (WebCore::PopupListBox::hidePopup):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::menuUnmapped):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
  • platform/qt/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::hidePopup):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::hide):
  • platform/wx/PopupMenuWx.cpp: (WebCore::PopupMenu::OnMenuItemSelected):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::popupDidHide):
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::selectionChanged):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::popupDidHide):
  • rendering/RenderTextControlSingleLine.h: (WebCore::RenderTextControlSingleLine::selectionChanged):
13:59 Changeset [52672] by japhet@chromium.org

2009-12-30 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Auto-generate V8 bindings header declarations for
property accessor getter/setters, and remove a couple of
unnecessarily custom bindings that weren't properly declared
custom anyway.

  • Android.v8bindings.mk: Remove V8NavigatorCustom.cpp.
  • WebCore.gypi: Remove V8NavigatorCustom.cpp.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/custom/V8AttrCustom.cpp:
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • bindings/v8/custom/V8CoordinatesCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8DocumentLocationCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8MessageEventCustom.cpp:
  • bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
  • bindings/v8/custom/V8SVGLengthCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
13:24 Changeset [52671] by eric@webkit.org

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Anders Carlsson.

svg/custom/use-on-symbol-inside-pattern.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=17393

Reenable the test. It isn't failing anymore.

  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.checksum:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • svg/custom/use-on-symbol-inside-pattern.svg: Copied from LayoutTests/svg/custom/use-on-symbol-inside-pattern.svg-disabled.
  • svg/custom/use-on-symbol-inside-pattern.svg-disabled: Removed.
12:05 Changeset [52670] by dglazkov@chromium.org

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Touch DerivedSourcesAllInOne to avoid clobbering IB-based builds.

  • bindings/v8/DerivedSourcesAllInOne.cpp: Added a line-break.
11:28 Changeset [52669] by dglazkov@chromium.org

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Generate configuring of call-as-function callbacks.
https://bugs.webkit.org/show_bug.cgi?id=33061

Refactoring, covered by existing tests.

  • bindings/scripts/CodeGeneratorV8.pm: Added GenerateHeaderCustomCall and

GenerateImplementationCustomCall.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed all hand-configuring of call-as-function

callbacks.

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::V8HTMLAppletElement::callAsFunctionCallback): Added. (WebCore::V8HTMLEmbedElement::callAsFunctionCallback): Added. (WebCore::V8HTMLObjectElement::callAsFunctionCallback): Added.
  • bindings/v8/custom/V8HTMLPlugInElementCustom.h: Removed.
11:26 Changeset [52668] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Introduce wxWebSettings API interface for editing wxWebView / page settings.

https://bugs.webkit.org/show_bug.cgi?id=32956

10:37 Changeset [52667] by eric@webkit.org

2009-12-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

logging.py should be renamed to webkit_logging.py and eventually die
https://bugs.webkit.org/show_bug.cgi?id=33058

Change all imports of "logging" to webkit_logging,
except the ones which came from Google's cpp_lint.py and diff_parser.py
which clearly are assuming python's logging.py.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/buildbot.py:
  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/queries.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/upload.py:
  • Scripts/modules/credentials.py:
  • Scripts/modules/executive.py:
  • Scripts/modules/multicommandtool.py:
  • Scripts/modules/queueengine.py:
  • Scripts/modules/scm.py:
  • Scripts/modules/statusbot.py:
  • Scripts/modules/stepsequence.py:
  • Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
  • Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
10:22 Changeset [52666] by abarth@webkit.org

2009-12-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[v8] Move world-specific state out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=33034

This is the first step towards unifying the V8 implementation of
isolated worlds with the JSC implementation. We need an object to
encapulate all the world-specific bindings state. Previoulsy, we used
V8Proxy for this purpose (along with a million other things), but
there's a one-to-one mapping between V8Proxy objects and Frame objects.

This patch takes the world-specific state and moves it to a new object,
affectionately called V8DOMWindowShell. This object is the moral
equivalent of JSDOMWindowShell but with more data members because life
is more complicated in V8-land.

This patch is almost entirely code motion. Future patches will clean
up this class as we use it to represent window shells in isolated
worlds as well as the main world.

  • WebCore.gypi:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::updateDocument):
  • bindings/v8/V8DOMWindowShell.cpp: Added. (WebCore::handleFatalErrorInV8): (WebCore::reportFatalErrorInV8): (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::isContextInitialized): (WebCore::V8DOMWindowShell::disposeContextHandles): (WebCore::V8DOMWindowShell::destroyGlobal): (WebCore::V8DOMWindowShell::clearForClose): (WebCore::V8DOMWindowShell::clearForNavigation): (WebCore::V8DOMWindowShell::initContextIfNeeded): (WebCore::V8DOMWindowShell::createNewContext): (WebCore::V8DOMWindowShell::installDOMWindow): (WebCore::V8DOMWindowShell::updateDocumentWrapper): (WebCore::V8DOMWindowShell::clearDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::V8DOMWindowShell::clearDocumentWrapperCache): (WebCore::V8DOMWindowShell::setSecurityToken): (WebCore::V8DOMWindowShell::updateDocument): (WebCore::V8DOMWindowShell::updateSecurityOrigin): (WebCore::V8DOMWindowShell::getHiddenObjectPrototype): (WebCore::V8DOMWindowShell::installHiddenObjectPrototype): (WebCore::V8DOMWindowShell::createWrapperFromCacheSlowCase):
  • bindings/v8/V8DOMWindowShell.h: Added. (WebCore::V8DOMWindowShell::context): (WebCore::V8DOMWindowShell::createWrapperFromCache):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructorForContext): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::setContextDebugId):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::windowShell): (WebCore::V8Proxy::extensions):
09:50 Changeset [52665] by eric@webkit.org

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVGResourceClipper needs to invalidate content
https://bugs.webkit.org/show_bug.cgi?id=33054

Added invalidate() to SVGResourceClipper to reset clipData
and drawing area after attribute changes.

This fixes two LayoutTests.

  • svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::invalidate):
  • svg/graphics/SVGResourceClipper.h:

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVGResourceClipper needs to invalidate content
https://bugs.webkit.org/show_bug.cgi?id=33054

Drawing area should change after attribute changes in clipPath or
it's childs.

  • platform/mac/svg/custom/clip-path-child-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-units-changes-expected.txt:
09:42 Changeset [52664] by eric@webkit.org

2009-12-30 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] RenderThemeQt::applyTheme is a misnomer and is suboptimally coded.

https://bugs.webkit.org/show_bug.cgi?id=33035

This patch:

  • renames RenderThemeQt::applyTheme to initializeCommonQStyleOptions,
  • extracts the palette initialization code to a separate function in order to provide for readable pointer checking and moves this code up in the function to allow for future changes to the palette brushes needed for bug 30173,
  • optimizes some of the code in the function for readability, speed and size.
  • fixes some minor style issues

No new tests because code behavior is not changed.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): (WebCore::initPaletteFromPageClientIfExists): (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
  • platform/qt/RenderThemeQt.h:
08:49 Changeset [52663] by dglazkov@chromium.org

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Generate configuring of all indexers.
https://bugs.webkit.org/show_bug.cgi?id=33031

Refactorig, covered by existing tests.

  • bindings/scripts/CodeGeneratorV8.pm: Added generation of indexers for

special cases.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed custom tempalte configuration of

indexers.

  • bindings/v8/custom/V8CustomBinding.h: Added decls for Applet, Embed, and Object

elements (these will be generated, too -- later.)

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::npObjectIndexedGetter): Moved common code to a separate method. (WebCore::npObjectIndexedSetter): Ditto. (WebCore::INDEXED_PROPERTY_GETTER): Added custom handlers for Applet, Embed, and Object all calling the common method. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
08:43 Changeset [52662] by eric@webkit.org

2009-12-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] It should be possible to disable inspector
https://bugs.webkit.org/show_bug.cgi?id=32724

This change fixes the build break. Some QtWebKit interfaces
will not be fully functional (most notable QWebInspector) if
INSPECTOR is disabled.

  • Api/qwebinspector.cpp: (QWebInspector::showEvent): (QWebInspector::closeEvent):
  • Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPagePrivate::getOrCreateInspector): (QWebPagePrivate::inspectorController): (QWebPage::triggerAction): (QWebPage::updatePositionDependentActions):
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow):

2009-12-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] It should be possible to disable inspector
https://bugs.webkit.org/show_bug.cgi?id=32724

This makes the r48430 available for other ports as well.
No new tests, as there is no new functionality.

  • inspector/InjectedScriptHost.idl: Guard the interface with INSPECTOR guard.
  • inspector/InspectorBackend.idl: Ditto.
  • inspector/InspectorFrontendHost.idl: Ditto.
08:13 Changeset [52661] by dglazkov@chromium.org

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Generate configuring of all named property getters/setters/enumerators.
https://bugs.webkit.org/show_bug.cgi?id=32996

Refactoring, covered by existing tests.

  • bindings/scripts/CodeGeneratorV8.pm: Added generation of named property handlers

for special cases (See bug for more info).

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed custom template configuration of named

property handlers.

  • bindings/v8/custom/V8CustomBinding.h: Added decls for Applet, Embed, and Object

elements (these will be generated, too -- later.)

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::npObjectNamedGetter): Moved common code to a separate method. (WebCore::npObjectNamedSetter): Ditto. (WebCore::NAMED_PROPERTY_GETTER): Added custom handlers for Applet, Embed, and Object all calling the common method. (WebCore::NAMED_PROPERTY_SETTER): Ditto.
06:58 Changeset [52660] by eric@webkit.org

2009-12-30 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Fix PluginView::handlePostReadFile().
https://bugs.webkit.org/show_bug.cgi?id=33052

The function should actually rewrite the given file to the buffer.

This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
now along with other passing http/plugins tests.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::handlePostReadFile):

2009-12-30 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Fix PluginView::handlePostReadFile().
https://bugs.webkit.org/show_bug.cgi?id=33052

The function should actually rewrite the given file to the buffer.

This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
now along with other passing http/plugins tests.

  • platform/qt/Skipped:
06:30 Changeset [52659] by eric@webkit.org

2009-12-30 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
https://bugs.webkit.org/show_bug.cgi?id=33051

Moreover, its primary function is to normalize the path in regard of platform
specific directory separators. Therefore, it can simply make use of the
QDir::toNativeSeparators function.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::pathToLocalResource):
06:16 Changeset [52658] by ddkilzer@apple.com

Fix executable bits for r52646

  • Scripts/VCSUtils_unittest.pl: Added property svn:executable.
  • Scripts/test-webkit-perl: Ditto.
06:12 Changeset [52657] by zecke@webkit.org

[Qt] Revert "Implement ImageDecoderQt::clearFrameBufferCache()" from r52516.

https://bugs.webkit.org/show_bug.cgi?id=32121

The implementation appears to either run into an ASSERT
or leak memory at runtime as the m_buffer, m_reader may
already exist. The bug was reopened and we do have a plan now.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::clearFrameBufferCache):

  • platform/graphics/qt/ImageDecoderQt.h:
05:09 Changeset [52656] by kov@webkit.org

2009-12-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skipping isolatedWorld test - we still do not support that.

  • platform/gtk/Skipped:
04:58 Changeset [52655] by hausmann@webkit.org

WebCore: [Qt] Add support for Symbian def files

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-12-30
Reviewed by Simon Hausmann.

  • WebCore.pro:

WebKit/qt: Upstream Symbian def files from Qt 4.6.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-12-30
Reviewed by Simon Hausmann.

These files define the ABI of QtWebKit on Symbian.

  • symbian/bwins/QtWebKitu.def: Added.
  • symbian/eabi/QtWebKitu.def: Added.
04:40 Changeset [52654] by hausmann@webkit.org

Unreviewed Qt/Symbian build fix.

Don't build network state notifier support when building inside of Qt.
Otherwise the Qt build depends on an external module that itself depends
on Qt again.

  • WebCore.pro:
04:34 Changeset [52653] by yurys@chromium.org

2009-12-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Use current isolated world's context for ScriptCallStack.

https://bugs.webkit.org/show_bug.cgi?id=33016

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): (WebCore::ScriptController::currentScriptState): (WebCore::ScriptController::clearWindowShell):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::scriptState):
  • bindings/v8/V8IsolatedWorld.h:
02:46 Changeset [52652] by ossy@webkit.org

Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-30
[Qt] Add expected files for the following new passing tests.

  • platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
  • platform/qt/fast/block/float/in-margin-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/in-margin-expected.txt.
  • platform/qt/fast/text/fake-italic-expected.txt: Added.
  • platform/qt/svg/custom/empty-mask-expected.txt: Added.
  • platform/qt/svg/filters/filter-source-position-expected.txt: Added.
02:20 Changeset [52651] by ossy@webkit.org

[Qt] Expected files updated after r52647.

Reviewed by Dirk Schulze.

  • platform/qt/svg/css/clippath-with-shadow-expected.txt:
  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
01:20 Changeset [52650] by ossy@webkit.org

Rubber-stamped by Simon Hausmann.

[Qt] DataGrid support turned off by r52648. Expected files updated.

  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
  • platform/qt/fast/js/global-constructors-expected.txt: updated.
00:56 Changeset [52649] by krit@webkit.org

2009-12-30 Dirk Schulze <krit@webkit.org>

Unreviewed test result fix.

Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815

Forgot to update this test.

  • platform/mac/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
00:52 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
00:47 Changeset [52648] by hausmann@webkit.org

Turn off DataGrid support by default.

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2009-12-30
Reviewed by Simon Hausmann.

No new tests, as there is no new functionality.

  • WebCore.pro:
00:10 Changeset [52647] by krit@webkit.org

2009-12-29 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815

Add new bounding boxes for strokes, filters, masker and clipper in SVG.
These new bounding boxes help to fix repaintRectInLocalCoordinates.
We calculate the smallest repaint rect considering the new bounding boxes
now, filters get the correct paint area, masker clip the mask image size
to the visible area of the target.

Tests: Many tests need an update. The changes in repaintRectInLocalCoordinates

affect the LayoutTests.

  • rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::strokeBoundingBox):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::toSVGRenderBase):
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::strokeBoundingBox): (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::setPath):
  • rendering/RenderPath.h: (WebCore::RenderPath::markerBoundingBox):
  • rendering/RenderSVGBlock.h: (WebCore::RenderSVGBlock::toSVGRenderBase):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::strokeBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::toSVGRenderBase): (WebCore::RenderSVGImage::strokeBoundingBox):
  • rendering/RenderSVGInline.h: (WebCore::RenderSVGInline::objectBoundingBox): (WebCore::RenderSVGInline::repaintRectInLocalCoordinates):
  • rendering/RenderSVGModelObject.h: (WebCore::RenderSVGModelObject::toSVGRenderBase):
  • rendering/RenderSVGRoot.h: (WebCore::RenderSVGRoot::strokeBoundingBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/RenderSVGText.h: (WebCore::RenderSVGText::toSVGRenderBase):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::~SVGRenderBase): (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
  • rendering/SVGRenderSupport.h: (WebCore::SVGRenderBase::toSVGRenderBase): (WebCore::SVGRenderBase::strokeBoundingBox): (WebCore::SVGRenderBase::markerBoundingBox):
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::toSVGRenderBase): (WebCore::SVGRootInlineBox::objectBoundingBox): (WebCore::SVGRootInlineBox::repaintRectInLocalCoordinates):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterBoundingBox):
  • svg/SVGFilterElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::maskBoundingBox): (WebCore::SVGMaskElement::drawMaskerContent):
  • svg/SVGMaskElement.h:
  • svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::clipperBoundingBox):
  • svg/graphics/SVGResourceClipper.h:
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::filterBoundingBox): (WebCore::shouldProcessFilter): (WebCore::SVGResourceFilter::prepareFilter):
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::maskerBoundingBox): (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/SVGResourceMasker.h:

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmmermann.

Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815

Mainly Filter and Masker tests need new test results.
repaintRectInLocalCoordinates changed to calculate the smallest
repaint area considering the bounding bo of masker, filter and
clipper as well as the stroke and marker boundaries.

  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/css/clippath-with-shadow-expected.txt:
  • platform/mac/svg/custom/clip-path-display-none-child-expected.txt:
  • platform/mac/svg/custom/clip-path-href-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/mac/svg/custom/clip-path-with-transform-expected.txt:
  • platform/mac/svg/custom/empty-merge-expected.txt:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
  • platform/mac/svg/custom/focus-ring-expected.checksum:
  • platform/mac/svg/custom/focus-ring-expected.png:
  • platform/mac/svg/custom/focus-ring-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.txt:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.checksum:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.png:
  • platform/mac/svg/custom/mask-with-all-units-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.txt:
  • platform/mac/svg/custom/recursive-clippath-expected.txt:
  • platform/mac/svg/custom/text-clip-expected.txt:
  • platform/mac/svg/custom/visibility-override-clip-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-2-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feMerge-expected.txt:
  • platform/mac/svg/filters/feOffset-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filter-source-position-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/filters/shadow-on-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt:
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt:
  • svg/custom/use-clipped-transform-expected.txt:

12/29/09:

23:19 Changeset [52646] by eric@webkit.org

2009-12-29 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by David Kilzer.

Fixed a bug in fixChangeLogPatch, made it work correctly in
more circumstances, and added unit tests.

https://bugs.webkit.org/show_bug.cgi?id=32919

  • Scripts/VCSUtils.pm: Rewrote fixChangeLogPatch.


  • Scripts/VCSUtils_unittest.pl: Added. Added 7 unit tests for fixChangeLogPatch.
  • Scripts/test-webkit-perl: Added. Added test harness for unit tests of Perl code.
22:46 Changeset [52645] by eric@webkit.org

2009-12-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split out BugzillaQueries class from Bugzilla
https://bugs.webkit.org/show_bug.cgi?id=33042

  • Scripts/modules/bugzilla.py:
    • Split out BugzillaQueries from Bugzilla.
    • Try to isolate self.bugzilla usage into helper functions whenever possible.
    • Add a bunch of FIXMEs.
    • Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list
  • Scripts/modules/bugzilla_unittest.py:
    • Create a new BugzillaQueriesTest testcase and move logic there.
  • Scripts/modules/buildsteps_unittest.py:
    • Use Bug 75 instead of 1 since bug 1 doesn't actually exist.
  • Scripts/modules/commands/queries.py:
    • Update to use bugzilla.queries
  • Scripts/modules/commands/queues.py:
    • Ditto.
  • Scripts/modules/commands/upload.py:
    • Ditto.
  • Scripts/modules/mock_bugzillatool.py:
    • Add a MockBugzillaQueries.
    • Make patches and bugs global privates.
    • Let _id_to_object_dictionary take a variable argument list instead of an array.
22:29 Changeset [52644] by dbates@webkit.org

2009-12-29 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33041

Speed up the test method test_read_credentials_with_SVN by not actually
creating an SVN repository to test against (by default). Instead, it is
sufficient to create a temporary directory that does not contain a Git
repository.

Also, renamed method test_read_credentials_with_SVN to
test_read_credentials_without_git_repo, to better reflect what it is
testing.

  • Scripts/modules/credentials_unittest.py:
22:04 Changeset [52643] by dbates@webkit.org

2009-12-29 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33039

[bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup
fails to find an entry for bugs.webkit.org.


Under Mac OS X, bugzilla-tool tries to query the keychain and Security
framework (via /usr/sbin/security) for an internet-password entry for
bugs.webkit.org so that it can use it to login to bugs.webkit.org.
However, if no such entry exists then bugzilla-tool dies with an error.

  • Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org.
  • Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found.
21:20 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
21:03 Changeset [52642] by eric@webkit.org

2009-12-29 Eric Seidel <eric@webkit.org>

Rubber-stamped by Adam Barth.

Remove unused BugzillaException.

  • Scripts/modules/bugzilla.py:
20:47 Changeset [52641] by eric@webkit.org

2009-12-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Need a script to assign bugs with r+ patches to committers for landing
https://bugs.webkit.org/show_bug.cgi?id=33009

This is just one more small tool to help in the fight against our
ever-growing list of to-be-committed patches.

  • Scripts/modules/bugzilla.py:
    • Rename assign_to_email to assigned_to_email (typo).
    • Add assigned_to_email() method on Bug.
    • Add reassign_bug method.
    • Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module.
  • Scripts/modules/bugzilla_unittest.py:
    • Update test after assigned_to_email rename.
  • Scripts/modules/commands/commandtest.py:
    • Call bind_to_tool to that self.tool works in Command testing.
  • Scripts/modules/commands/download.py:
    • Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command.
  • Scripts/modules/commands/queries_unittest.py:
    • One of the test patches is now posted by "eric@webkit.org" which is a committer.
    • Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not.
  • Scripts/modules/commands/upload.py:
    • Add new assign-to-committer command.
  • Scripts/modules/commands/upload_unittest.py:
    • Add basic assign-to-committer test.
  • Scripts/modules/committers.py:
    • Add bugzilla_email() accessor.
  • Scripts/modules/committers_unittest.py:
    • Test our assumption that bugzilla_email is the first email.
  • Scripts/modules/mock_bugzillatool.py:
    • Add _id_to_object_dictionary for generating bug_cache from list of bugs.
    • Remove unused fetch_attachments_from_bug.
    • Add fetch_bug support and a bug_cache.
  • Scripts/modules/multicommandtool.py:
    • Move AbstractDeclarativeCommmand here from download.py
20:19 Changeset [52640] by eric@webkit.org

2009-12-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Don't crash if user types a number during PromptForBugOrTitleStep
https://bugs.webkit.org/show_bug.cgi?id=33038

Simple fix with test.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/buildsteps_unittest.py:
20:12 Changeset [52639] by eric@webkit.org

2009-12-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] post-diff requires reading to the end
https://bugs.webkit.org/show_bug.cgi?id=33036

Catch the IOError caused by not reading to the end of the diff. We
don't have a good way to test this currently.

  • Scripts/modules/user.py:
16:48 Changeset [52638] by eric@webkit.org

2009-12-29 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Add a test for window.top and isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=33030

I wrote this test to investigate an issue that turns out is working
properly. No sense wasting a perfectly good test, so we should add it.

  • http/tests/security/isolatedWorld/top-properties-expected.txt: Added.
  • http/tests/security/isolatedWorld/top-properties.html: Added.
15:19 Changeset [52637] by eric@webkit.org

2009-12-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Maciej Stachowiak.

PLATFORM(CAIRO) should be defined by WIN_CAIRO define
https://bugs.webkit.org/show_bug.cgi?id=22250

  • wtf/Platform.h: Define WTF_PLATFORM_CAIRO for GTK port only For the WinCairo port WTF_PLATFORM_CAIRO is already defined in config.h
15:06 Changeset [52636] by eric@webkit.org

2009-12-29 Chang Shu <Chang.Shu@nokia.com>

Reviewed by Adam Barth.

[Qt] Move logic that handles Qt headers before primary headers
so that Qt headers won't be treated as primary headers by mistake.
https://bugs.webkit.org/show_bug.cgi?id=32991

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
14:50 Changeset [52635] by eric@webkit.org

2009-12-29 Andrei Popescu <andreip@google.com>

Reviewed by Adam Barth.

Add Android hook to NetworkStateNotifier class
so that the Java side can notify WebCore when the
network state changes.
https://bugs.webkit.org/show_bug.cgi?id=32871

No new tests required, this is platform code.

  • platform/network/NetworkStateNotifier.h:
  • platform/network/android/NetworkStateNotifierAndroid.cpp: Added. (WebCore::NetworkStateNotifier::networkStateChange):
14:32 Changeset [52634] by ossy@webkit.org

Rubber-stamped by Simon Hausmann.

[Qt] Remove a bunch of now passing tests from skiplist.

  • platform/qt/Skipped:
14:08 Changeset [52633] by eric@webkit.org

2009-12-29 Eric Seidel <eric@webkit.org>

No review, rolling out r52630.
https://bugs.webkit.org/show_bug.cgi?id=33012
http://trac.webkit.org/changeset/52630

This caused 2 layout test failures, and 2 layout test crashes on Leopard bots.

  • platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-marker-creation-expected.txt:
  • platform/mac/svg/custom/marker-changes-expected.checksum:
  • platform/mac/svg/custom/marker-changes-expected.png:
  • platform/mac/svg/custom/marker-changes-expected.txt:
  • platform/mac/svg/custom/marker-child-changes-expected.checksum:
  • platform/mac/svg/custom/marker-child-changes-expected.png:
  • platform/mac/svg/custom/marker-child-changes-expected.txt:
  • platform/mac/svg/custom/marker-default-width-height-expected.txt:
  • platform/mac/svg/custom/marker-overflow-clip-expected.txt:
  • platform/mac/svg/custom/marker-referencePoint-expected.checksum: Removed.
  • platform/mac/svg/custom/marker-referencePoint-expected.png: Removed.
  • platform/mac/svg/custom/marker-referencePoint-expected.txt: Removed.
  • platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.png:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
  • svg/custom/marker-referencePoint.svg: Removed.

2009-12-29 Eric Seidel <eric@webkit.org>

No review, rolling out r52630.
http://trac.webkit.org/changeset/52630

Change caused layout tests failures and crashes.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::setPath): (WebCore::RenderPath::path): (WebCore::RenderPath::paint): (WebCore::): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::drawMarkerWithData): (WebCore::updateMarkerDataForElement): (WebCore::drawStartAndMidMarkers): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::paint):
  • rendering/RenderSVGViewportContainer.h:
  • rendering/SVGMarkerLayoutInfo.cpp: Removed.
  • rendering/SVGMarkerLayoutInfo.h: Removed.
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
  • svg/graphics/SVGResource.cpp: (WebCore::SVGResource::SVGResource): (WebCore::ResourceSet::ResourceSet): (WebCore::clientMap): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::removeClient): (WebCore::SVGResource::addClient):
  • svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::setMarker): (WebCore::SVGResourceMarker::setRef): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::cachedBounds): (WebCore::SVGResourceMarker::externalRepresentation):
  • svg/graphics/SVGResourceMarker.h: (WebCore::SVGResourceMarker::refX): (WebCore::SVGResourceMarker::refY):
13:05 Changeset [52632] by mitz@apple.com

Move the focus ring rect array, width and offset out of GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=33028

Reviewed by Sam Weinig.

  • platform/graphics/GraphicsContext.cpp: Removed initFocusRing(),

clearFocusRing(), focusRingBoundingRect(), addFocusRingRect(),
focusRingWidth(), focusRingOffset(), and focusRingRects().

  • platform/graphics/GraphicsContext.h: Ditto. Added the focus ring rect

vector, width and offset as parameters to drawFocusRing().

  • platform/graphics/GraphicsContextPrivate.h:

(WebCore::GraphicsContextState::GraphicsContextState): Cleaned up style.
(WebCore::GraphicsContextPrivate::GraphicsContextPrivate): Removed
m_focusRingRects, m_focusRingWidth and m_focusRingOffset.

  • platform/graphics/IntRect.cpp:

(WebCore::unionRect): Added this helper function.

  • platform/graphics/IntRect.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawFocusRing):

  • platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::drawFocusRing): Ditto.

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawFocusRing): Ditto.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawFocusRing): Ditto.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawFocusRing): Ditto.

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawFocusRing): Ditto.

  • platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::drawFocusRing): Ditto.

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::drawFocusRing): Ditto.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addFocusRingRects): Updated for new prototype.
Added empty rect checks that were previously done in
GraphicsContext::addFocusRingRect().

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addFocusRingRects): Ditto.

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addFocusRingRects): Ditto.
(WebCore::RenderInline::paintOutline): Collect focus ring rects into a
vector and pass it to drawFocusRing(). Use unionRect() instead of
focusRingBoundingRect().

  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintOutline): Ditto.

  • rendering/RenderObject.h:

(WebCore::RenderObject::addFocusRingRects): Changed to take a
Vector<IntRect> to which the rects are added.

  • rendering/RenderPath.cpp:

(WebCore::RenderPath::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().

  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().

  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().

  • rendering/RenderSVGImage.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().

  • rendering/RenderTextControl.h:
12:51 Changeset [52631] by dumi@chromium.org
  1. Changes the order in which some functions are called to match

the pre-r52536 order. Namely, when a new Database object is
created, DatabaseTracker::addOpenDatabase() is called in the
constructor, before doing anything else related to that database
(like trying to get a file handle to the database
file). Chromium's implementation depends on this ordering.

  1. Changes Database::performOpenAndVerify() to close the open

handle to the database file immediately if the database version
does not match the expected one. The current behavior is to add
the Database object to a DatabaseThread collection and let the
database thread close the handle when it's destroyed.

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=33005

All LayoutTests/storage tests pass in clean WebKit and Chromium
clients.

  • storage/Database.cpp:

(WebCore::Database::openDatabase): Notify DatabaseTracker and
Document that a Database object is about to be destroyed (when a
database file cannot be opened, or its version doesn't match the
expected one).
(WebCore::Database::Database): Notify DatabaseTracker and Document
that a new Database object was created.
(WebCore::Database::performOpenAndVerify): If a database version
does not match the expected one, immediately close the open file
handle to the database file.

12:46 Changeset [52630] by krit@webkit.org

2009-12-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Marker code is buggy: referencePoint translation is off
https://bugs.webkit.org/show_bug.cgi?id=33012

Rewrite marker code, as it was buggy:

  • Correct refX/refY handling (covered by new marker-referencePoint.svg test)
  • Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
  • Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
  • Fix SVGResource assuming that there is only one resource per resource type per element. Markers can have three different resources of the same type (three markers, start/mid/end markers)

Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
Test: svg/custom/marker-referencePoint.svg

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::setPath): (WebCore::RenderPath::paint): (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
  • rendering/RenderPath.h: (WebCore::RenderPath::path):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::markerContentTransformation):
  • rendering/RenderSVGViewportContainer.h:
  • rendering/SVGMarkerLayoutInfo.cpp: Added. (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo): (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo): (WebCore::SVGMarkerLayoutInfo::initialize): (WebCore::updateMarkerDataForElement): (WebCore::recordMarkerData): (WebCore::processStartAndMidMarkers): (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): (WebCore::SVGMarkerLayoutInfo::drawMarkers):
  • rendering/SVGMarkerLayoutInfo.h: Added. (WebCore::MarkerData::): (WebCore::MarkerData::MarkerData): (WebCore::MarkerLayout::MarkerLayout):
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
  • svg/graphics/SVGResource.cpp: (WebCore::resourceSet): (WebCore::SVGResource::SVGResource): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::removeClient): (WebCore::SVGResource::addClient):
  • svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::markerBoundaries): (WebCore::SVGResourceMarker::markerTransformation): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::externalRepresentation):
  • svg/graphics/SVGResourceMarker.h: (WebCore::SVGResourceMarker::setRenderer): (WebCore::SVGResourceMarker::setReferencePoint): (WebCore::SVGResourceMarker::referencePoint):

2009-12-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Marker code is buggy: referencePoint translation is off
https://bugs.webkit.org/show_bug.cgi?id=33012

Update SVG test baseline, after rewriting marker support.

  • platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-marker-creation-expected.txt:
  • platform/mac/svg/custom/marker-changes-expected.checksum:
  • platform/mac/svg/custom/marker-changes-expected.png:
  • platform/mac/svg/custom/marker-changes-expected.txt:
  • platform/mac/svg/custom/marker-child-changes-expected.checksum:
  • platform/mac/svg/custom/marker-child-changes-expected.png:
  • platform/mac/svg/custom/marker-child-changes-expected.txt:
  • platform/mac/svg/custom/marker-default-width-height-expected.txt:
  • platform/mac/svg/custom/marker-overflow-clip-expected.txt:
  • platform/mac/svg/custom/marker-referencePoint-expected.checksum: Added.
  • platform/mac/svg/custom/marker-referencePoint-expected.png: Added.
  • platform/mac/svg/custom/marker-referencePoint-expected.txt: Added.
  • platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.png:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
  • svg/custom/marker-referencePoint.svg: Added.
11:55 Changeset [52629] by eric@webkit.org

2009-12-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix UI nits in the Audits panel.
https://bugs.webkit.org/show_bug.cgi?id=32932

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._selectAllClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI.handleSelectAllClick): (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/AuditResultView.js: (WebInspector.AuditResultView): (WebInspector.AuditRuleResultPane):
  • inspector/front-end/audits.css:
11:33 Changeset [52628] by eric@webkit.org

2009-12-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add the start of a Bug object for bugzilla.py
https://bugs.webkit.org/show_bug.cgi?id=32995

This allowed us to get rid of some duplicated "is_obsolete" checks.

  • Scripts/modules/bugzilla.py:
    • Add a new Bug class, and move patches/unreviewed_patches filtering logic there.
    • Add _fetch_bug_page for possible future mocking. (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.)
    • Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object.
    • Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods.
    • Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list.
  • Scripts/modules/bugzilla_unittest.py:
    • Remove an unneeded unicode string marker.
  • Scripts/modules/buildsteps.py:
    • define all to include just the BuildSteps
  • Scripts/modules/commands/download.py:
    • import * now that we have an all defined.
  • Scripts/modules/commands/upload.py:
    • Use fetch_bug_dictionary instead of fetch_bug.
11:25 Changeset [52627] by eric@webkit.org

2009-12-29 Johnny Ding <jnd@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=32863
Make NodeList support call-as-function

Test: fast/dom/NodeList/nodelist-item-call-as-function.html

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::V8NodeList::callAsFunctionCallback):

2009-12-29 Johnny Ding <jnd@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=32863
Make NodeList support call-as-function.

  • fast/dom/NodeList/nodelist-item-call-as-function-expected.txt: Added.
  • fast/dom/NodeList/nodelist-item-call-as-function.html: Added.
  • fast/dom/NodeList/script-tests: Added.
  • fast/dom/NodeList/script-tests/TEMPLATE.html: Added.
  • fast/dom/NodeList/script-tests/nodelist-item-call-as-function.js: Added.
10:27 Changeset [52626] by dbates@webkit.org

2009-12-29 Daniel Bates <dbates@webkit.org>

Reviewed by Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=32925

Adds an Open File dialog to make it convenient to open a file
to view in the browser.

  • QGVLauncher/main.cpp: (MainWindow::load): Modified to call loadURL. (MainWindow::openFile): Added. (MainWindow::loadURL): Added. (MainWindow::buildUI): Added menu item Open File.

2009-12-29 Daniel Bates <dbates@webkit.org>

Reviewed by Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=32925

Adds an Open File dialog to make it convenient to open a file
to view in the browser.

Currently a person must either specify the path to a file as a
command-line argument or type a file URL. Instead, we should
have a file dialog to allow a person to open a file without
memorizing its path.

  • QtLauncher/main.cpp: (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded()) to urlEdit->setText(qurl.toString()). (MainWindow::openFile): Added. (MainWindow::changeLocation): Moved code to load URL into method MainWindow::loadURL. (MainWindow::loadURL): Added. (MainWindow::setupUI): Added menu item Open File.
09:44 Changeset [52625] by eric@webkit.org

2009-12-29 Robert Hogan <robert@roberthogan.net>

Reviewed by Eric Seidel.

[Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html


Related to https://bugs.webkit.org/show_bug.cgi?id=23806


If an embedded document is loaded within a page and it has an empty
URL, use a blank URL for the load request.


https://bugs.webkit.org/show_bug.cgi?id=33017

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):

2009-12-29 Robert Hogan <robert@roberthogan.net>

Reviewed by Eric Seidel.

[Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html


Related to https://bugs.webkit.org/show_bug.cgi?id=23806


If an embedded document is loaded within a page and it has an empty
URL, use a blank URL for the load request.


https://bugs.webkit.org/show_bug.cgi?id=33017

  • platform/qt/Skipped:
09:18 Changeset [52624] by simon.fraser@apple.com

2009-12-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Typed text in table not correctly redrawn on page with compositing layers
https://bugs.webkit.org/show_bug.cgi?id=32874

Use the same test in RenderTableCell::computeRectForRepaint() that we use elsewhere
to decide when to use layoutState, which is to test for layoutStateEnabled()
and no repaint container.

Not possible to make a repaint test that exercises the problem, so no test.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::computeRectForRepaint):
08:51 Changeset [52623] by eric@webkit.org

2009-12-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Discard port from cookie domain when matching cookies.

WebKit cookies do not hold the port information, so we should match only hostnames.
https://bugs.webkit.org/show_bug.cgi?id=31787

  • inspector/front-end/inspector.js: (WebInspector.updateResource):
07:55 Changeset [52622] by laszlo.1.gombos@nokia.com

2009-12-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Rubber-stamped by Simon Hausmann and Holger Freyther.

[Qt] Remove WebKit/qt/WebKitPart empty directory

The content of the directory has been removed by r34888.

  • WebKitPart: Removed.
07:32 Changeset [52621] by eric@webkit.org

2009-12-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix warnings in MediaPlayerPrivatePhonon.cpp
https://bugs.webkit.org/show_bug.cgi?id=33019

No new tests as there is no new functionality.

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::totalTimeChanged):
06:28 Changeset [52620] by eric@webkit.org

2009-12-29 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Implement HTML5 <aside> element.
https://bugs.webkit.org/show_bug.cgi?id=32943

<aside> should behave the same as <nav>, <section>, and <article>.

Test: fast/html/aside-element.html

  • css/html.css: Add aside as a block element.
  • editing/htmlediting.cpp: (WebCore::validBlockTag): Add asideTag.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for asideTag. (WebCore::blockTagList): Add asideTag.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add asideTag.
  • html/HTMLTagNames.in: Add aside.

2009-12-29 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Implement HTML5 <aside> element.
https://bugs.webkit.org/show_bug.cgi?id=32943

The new test file tests:

  • <p> closing,
  • Residual style, and
  • FormatBlock.
  • fast/html/aside-element-expected.txt: Added.
  • fast/html/aside-element.html: Added.
  • fast/html/script-tests/aside-element.js: Added.
05:52 Changeset [52619] by mjs@apple.com

2009-12-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Alexey Proskuryakov.

plugins/get-url-with-iframe-target.html fails on SnowLeopard (64-bit)
https://bugs.webkit.org/show_bug.cgi?id=32982


This test has been failing on SnowLeopard since it was landed.


The problem is that we never delivered the notification for
NPN_GetURLNotify, in the frame-targeting case, for out-of-process
plugins on Mac.


I implemented support for this based on how in-process Mac plugins
do it.

  • Plugins/Hosted/HostedNetscapePluginStream.h:
  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::reasonForError):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::PluginRequest::create): (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest): (WebKit::NetscapePluginInstanceProxy::destroy): (WebKit::NetscapePluginInstanceProxy::performRequest): (WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason): (WebKit::NetscapePluginInstanceProxy::requestTimerFired): (WebKit::NetscapePluginInstanceProxy::loadRequest):
  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebHostedNetscapePluginView webFrame:didFinishLoadWithError:]):
05:49 QtWebKit edited by rich@kde.org
(diff)
05:21 Changeset [52618] by eric@webkit.org

2009-12-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
https://bugs.webkit.org/show_bug.cgi?id=33003

No new tests as there is no new functionality.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::sendTransitionEvent):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::sendAnimationEvent):
  • rendering/RenderSVGContainer.h: (WebCore::toRenderSVGContainer):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow):
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):
  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
05:07 Changeset [52617] by kov@webkit.org

Minor style fix - reported by the style bot

05:05 Changeset [52616] by kov@webkit.org

2009-12-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

[GTK] Failing media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=33015

Skip test that fails on and off locally, but always on the release
bot, until we figure out what is wrong.

  • platform/gtk/Skipped:
04:58 Changeset [52615] by kov@webkit.org

[GTK] Fails fast/dom/prototype-inheritance-2.html after r52559
https://bugs.webkit.org/show_bug.cgi?id=33014

Skipping test that is failing after r52559 until we figure out why
the constructors are not showing up for us.

  • platform/gtk/Skipped:
04:56 Changeset [52614] by kov@webkit.org

Reviewed by Holger Freyther.

[GTK] fails fast/harness/use-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=33013

Make sure settings are forwarded to child WebViews.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(createWebView):

04:47 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
04:44 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
04:33 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
04:33 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
04:27 QtWebKitReleases edited by hausmann@webkit.org
(diff)
04:18 QtWebKitReleases edited by hausmann@webkit.org
(diff)
04:00 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:44 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:42 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:38 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
00:30 Changeset [52613] by dbates@webkit.org

2009-12-29 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32778

Changes $diffPercentage to be a number to resolve Perl
warning about comparing a string to a number.

  • Scripts/run-webkit-tests:
00:26 Changeset [52612] by eric@webkit.org

2009-12-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] DRT: Frame loader callbacks differ from the Mac port
https://bugs.webkit.org/show_bug.cgi?id=32989

Remove messages from the callbacks that should not dump them to match
the expected results for the http/loading tests.

Unskip some http/loading tests which succeed now.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage): (WebCore::FrameLoaderClientQt::dispatchWillClose): (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):

2009-12-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] DRT: Frame loader callbacks differ from the Mac port
https://bugs.webkit.org/show_bug.cgi?id=32989

Remove messages from the callbacks that should not dump them to match
the expected results for the http/loading tests.

Unskip some http/loading tests which succeed now.

  • platform/qt/Skipped:

2009-12-29 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] DRT: Frame loader callbacks differ from the Mac port
https://bugs.webkit.org/show_bug.cgi?id=32989

Remove messages from the callbacks that should not dump them to match
the expected results for the http/loading tests.

Unskip some http/loading tests which succeed now.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
00:18 Changeset [52611] by eric@webkit.org

2009-12-29 Robert Hogan <robert@roberthogan.net>

Reviewed by Eric Seidel.

[Qt] fix fast/dom/Window/window-onFocus.html


Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
window.onblur was getting dispatched twice from QtWebKit.


https://bugs.webkit.org/show_bug.cgi?id=32990

  • Api/qwebpage.cpp: (QWebPagePrivate::focusOutEvent):

2009-12-29 Robert Hogan <robert@roberthogan.net>

Reviewed by Eric Seidel.

[Qt] fix fast/dom/Window/window-onFocus.html


Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
window.onblur was getting dispatched twice from QtWebKit.


https://bugs.webkit.org/show_bug.cgi?id=32990

  • platform/qt/Skipped:

2009-12-29 Robert Hogan <robert@roberthogan.net>

Reviewed by Eric Seidel.

[Qt] fix fast/dom/Window/window-onFocus.html


Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
window.onblur was getting dispatched twice from QtWebKit.


https://bugs.webkit.org/show_bug.cgi?id=32990

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::switchFocus):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setWindowIsKey): (LayoutTestController::setMainFrameIsFirstResponder):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

12/28/09:

22:49 Changeset [52610] by eric@webkit.org

2009-12-28 Andrei Popescu <andreip@google.com>

Reviewed by Dmitry Titov.

On Android, ResourceHandle instances make use of a pointer to a
ResourceLoaderAndroid pointer. This needs to be stored in order to later cancel
the load, if necessary. Since this pointer is an internal implementation
details of ResourceHandle on Android, it needs to be stored in the
ResourceHandleInternal class. This patch adds this pointer.
https://bugs.webkit.org/show_bug.cgi?id=32873

No new tests needed, this is platform-specific code.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
22:41 Changeset [52609] by eric@webkit.org

2009-12-28 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Maciej Stachowiak.

Remove the macro ENABLE(XHTMLMP) for noscriptAreateErrorCheck in HTMLParser,
since with XHTMLMP enabled, it's not checking create Errors, and then contents inside
<noscript> are always parsed and rendered.
https://bugs.webkit.org/show_bug.cgi?id=32706

Tests: fast/parser/noscript-with-javascript-disabled.html

fast/parser/noscript-with-javascript-enabled.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):

2009-12-28 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Maciej Stachowiak.

Add test cases for <noscript> with both Javascript enabled and disabled
https://bugs.webkit.org/show_bug.cgi?id=32706

  • fast/parser/noscript-with-javascript-disabled-expected.txt: Added.
  • fast/parser/noscript-with-javascript-disabled.html: Added.
  • fast/parser/noscript-with-javascript-enabled-expected.txt: Added.
  • fast/parser/noscript-with-javascript-enabled.html: Added.
22:33 Changeset [52608] by eric@webkit.org

2009-12-28 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Fixed isKeypadEvent behavior for chromium/Mac to correctly report
keyLocation as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
https://bugs.webkit.org/show_bug.cgi?id=28247

Test: fast/events/keydown-numpad-keys.html

  • src/mac/WebInputEventFactory.mm: (WebKit::isKeypadEvent):

2009-12-28 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Fixed isKeypadEvent behavior for Mac to correctly report keyLocation
as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
https://bugs.webkit.org/show_bug.cgi?id=28247

Test: fast/events/keydown-numpad-keys.html

  • platform/mac/KeyEventMac.mm: (WebCore::isKeypadEvent):

2009-12-28 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Added a layout-test that tests if numeric pad arrow key
events are correctly reported with keyLocation as
DOM_KEY_LOCATION_NUMPAD. Currently this test only passes on Mac.
https://bugs.webkit.org/show_bug.cgi?id=28247

  • fast/events/keydown-numpad-keys-expected.txt: Added.
  • fast/events/keydown-numpad-keys.html: Added.
  • fast/events/script-tests/keydown-numpad-keys.js: Added. (recordKeyEvent): (testKeyEventWithLocation):
  • platform/gtk/Skipped: fast/events/keydown-numpad-keys.html added.
  • platform/qt/Skipped: fast/events/keydown-numpad-keys.html added.
  • platform/win/Skipped: fast/events/keydown-numpad-keys.html added.

2009-12-28 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Maciej Stachowiak.

Extended EventSender.keyDown method to take another (3rd) argument
for indicating the keyLocation to make numeric pad key events testable.
Expected values for the argument is one of the KeyLocationCode
specified in DOM Level 3
(http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
https://bugs.webkit.org/show_bug.cgi?id=28247

Test: fast/events/keydown-numpad-keys.html

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController keyDown:withModifiers:withLocation:]):
22:25 Changeset [52607] by eric@webkit.org

2009-12-28 Mike Moretti <webkit9@mordent.com>

Reviewed by Darin Adler.

Fix bug 28245 - problem with inserting a span into a long text block causing a crash because of a null string

Test: fast/dom/insert-span-into-long-text-bug-28245.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):

2009-12-28 Mike Moretti <webkit9@mordent.com>

Reviewed by Darin Adler.

Fix bug 28245 - problem with inserting a span into a long text block causing a crash because of a null string

  • fast/dom/insert-span-into-long-text-bug-28245-expected.txt: Added.
  • fast/dom/insert-span-into-long-text-bug-28245.html: Added.
20:57 QtWebKitContrib edited by dbates@webkit.org
Added subsections "Dependencies" and "Installing dependencies on Ubuntu" … (diff)
19:43 TinOS created by xuchao@vtins.com
19:33 WikiStart edited by xuchao@vtins.com
(diff)
15:46 Changeset [52606] by kov@webkit.org

2009-12-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skip test that is failing since it was checked in, and some tests
that need results.

  • platform/gtk/Skipped:
15:34 Changeset [52605] by kov@webkit.org

2009-12-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Follow Apple's decision to disable HTML DataGrid by default.

  • GNUmakefile.am:
15:32 Changeset [52604] by ariya@webkit.org

2009-12-28 Ariya Hidayat <ariya.hidayat@gmail.com>

Unreviewed, update my email address.

  • Scripts/modules/committers.py:
15:15 Changeset [52603] by kov@webkit.org

2009-12-28 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Ariya Hidayat.

Fix warnings when generating files using gperf. The warnings are
currently harmless, but some changes in the build system may make
them fatal.

[GTK] Build time must be reduced
https://bugs.webkit.org/show_bug.cgi?id=32921

  • GNUmakefile.am:
12:28 Changeset [52602] by eric@webkit.org

2009-12-28 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Delete ThreadPrivate instance after it is finished.
https://bugs.webkit.org/show_bug.cgi?id=32614

  • wtf/qt/ThreadingQt.cpp: (WTF::ThreadMonitor::instance): (WTF::ThreadMonitor::threadFinished): (WTF::createThreadInternal): (WTF::detachThread):
12:05 QtWebKitBackportingFixes edited by norbert.leser@nokia.com
(diff)
11:15 Changeset [52601] by eric@webkit.org

2009-12-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Adam Barth.

[Qt] Fix build break for Qt 4.4
https://bugs.webkit.org/show_bug.cgi?id=30327

No new tests, as there is no new functionality.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): Use intersected() instead of operator &, which was only introduced in Qt version 4.5.
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paintScrollCorner): Pass ColorSpace argument to fillColor() introduced in r50760

2009-12-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Adam Barth.

[Qt] Fix build break for Qt 4.4
https://bugs.webkit.org/show_bug.cgi?id=30327

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto.
  • QtLauncher/main.cpp: (MainWindow::MainWindow): Qt::WA_TranslucentBackground was introduced in Qt version 4.5
09:35 Changeset [52600] by abarth@webkit.org

2009-12-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Add an edit-changelog command
https://bugs.webkit.org/show_bug.cgi?id=32986

This command makes it easier to edit ChangeLogs. It's similar to
prepare-ChangeLog -o, except it works with already existing ChangeLogs.

  • Scripts/modules/commands/upload.py:
  • Scripts/modules/commands/upload_unittest.py:
09:06 Changeset [52599] by eric@webkit.org

2009-12-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Create an ASAD command for uploading a patch
https://bugs.webkit.org/show_bug.cgi?id=32979

The create-review command goes through the whole process of preparing a
code review, including creating a bug, editing the ChangeLogs, and
uploading the patch. It is indeed the All Sing, All Dance upload
command.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/upload.py:
  • Scripts/modules/commands/upload_unittest.py:
  • Scripts/modules/mock_bugzillatool.py:
  • Scripts/modules/user.py:
08:58 Changeset [52598] by eric@webkit.org

2009-12-28 Patrick Gansterer <paroga@paroga.com>

Reviewed by Maciej Stachowiak.

Cleanup of #define JS_EXPORT.

  • API/JSBase.h:

2009-12-28 Patrick Gansterer <paroga@paroga.com>

Reviewed by Maciej Stachowiak.

Use JS_NO_EXPORT for JSBase.h.

  • wxwk-settings.bkl:
08:48 Changeset [52597] by eric@webkit.org

2009-12-28 Estêvão Samuel Procópio <tevaum@gmail.com>

Reviewed by Gustavo Noronha Silva.

Bug 32940: [GTK] Changing the download throttle conditions.
https://bugs.webkit.org/show_bug.cgi?id=32716

The WebKitDownload progress notification was taking long to
update. This fix makes notification happens each 0.7 secs
or when the progress ups in 1%.

  • WebKit/gtk/webkit/webkitdownload.cpp:
05:48 Changeset [52596] by tkent@chromium.org

2009-12-28 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Implement HTML5 <article> element.
https://bugs.webkit.org/show_bug.cgi?id=32942

The new test file tests:

  • <p> closing,
  • Residual style, and
  • FormatBlock.
  • fast/html/article-element-expected.txt: Added.
  • fast/html/article-element.html: Added.
  • fast/html/script-tests/article-element.js: Added.

2009-12-28 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Implement HTML5 <article> element.
https://bugs.webkit.org/show_bug.cgi?id=32936

<article> should behave the same as <nav> and <section>.

Test: fast/html/article-element.html

  • css/html.css: Add article as a block element.
  • editing/htmlediting.cpp: (WebCore::validBlockTag): Add articleTag.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for articleTag. (WebCore::blockTagList): Add articleTag.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add articleTag.
  • html/HTMLTagNames.in: Add article.
00:22 Changeset [52595] by abarth@webkit.org

2009-12-28 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix (with test!).

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/bugzilla_unittest.py:

12/27/09:

23:59 Changeset [52594] by eric@webkit.org

2009-12-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command
https://bugs.webkit.org/show_bug.cgi?id=32980

  • Scripts/modules/bugzilla.py:
    • Add a new _parse_bug_page function and use it in fetch_attachments_from_bug
    • Replace fetch_title_from_bug with a new fetch_bug call instead.
    • Use list comprehensions where possible to reduce code duplication.
  • Scripts/modules/bugzilla_unittest.py:
    • Add a minimal bug parsing test.
    • Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal
  • Scripts/modules/commands/upload.py:
    • Use fetch_bug(bug_id)title? instead of fetch_title_from_bug
23:05 Changeset [52593] by eric@webkit.org

2009-12-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Status bubble shouldn't be transparent for bots that haven't run yet
https://bugs.webkit.org/show_bug.cgi?id=32977

  • QueueStatusServer/templates/statusbubble.html:
22:58 Changeset [52592] by eric@webkit.org

2009-12-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[QueueStatusServer] Run gc cron job less often
https://bugs.webkit.org/show_bug.cgi?id=32958

Now that we've cleaned out the backlog of idle messages, we don't need
to run the gc job every half hour. We could also stop logging the idle
messages, but this seems easier for the time being.

  • QueueStatusServer/cron.yaml:
20:58 Changeset [52591] by mjs@apple.com

Rubber stamped by Adam Barth.

Put media/audio-delete-while-step-button-clicked.html back in the mac skipped list because
I think it's making other media tests fail sporadically.

  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
19:39 Changeset [52590] by eric@webkit.org

2009-12-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] Support upload progress events in XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=32969

Make QNetworkReplyHandler report the upload progress to the client.

Already covered by tests:
http/tests/xmlhttprequest/upload-onload-event.html
http/tests/xmlhttprequest/upload-onloadstart-event.html
http/tests/xmlhttprequest/upload-progress-events.html
http/tests/xmlhttprequest/upload-onprogress-event.html

which have been unskipped.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::uploadProgress): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/QNetworkReplyHandler.h:

2009-12-27 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] Support upload progress events in XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=32969

Make QNetworkReplyHandler report the upload progress to the client.

Already covered by tests:
http/tests/xmlhttprequest/upload-onload-event.html
http/tests/xmlhttprequest/upload-onloadstart-event.html
http/tests/xmlhttprequest/upload-progress-events.html
http/tests/xmlhttprequest/upload-onprogress-event.html

which have been unskipped.

  • platform/qt/Skipped:
19:17 Changeset [52589] by mjs@apple.com

Rubber stamped by Adam Barth.

Add media/audio-delete-while-step-button-clicked.html back to the Tiger skipped list.

  • platform/mac-tiger/Skipped:
18:28 Changeset [52588] by mjs@apple.com

Rubber stamped by Adam Barth.

Removed some tests from the skipped list that are not failing on my system.

  • platform/mac-snowleopard/Skipped:
  • platform/mac/Skipped:
  • platform/mac/fast/forms/menulist-style-color-expected.checksum: Added.
  • platform/mac/fast/forms/menulist-style-color-expected.png: Added.
  • platform/mac/fast/forms/menulist-style-color-expected.txt: Added.
  • platform/mac/plugins/qt-qwidget-plugin-expected.checksum: Added.
  • platform/mac/plugins/qt-qwidget-plugin-expected.png: Added.
  • platform/mac/plugins/qt-qwidget-plugin-expected.txt: Added.
18:01 Changeset [52587] by dbates@webkit.org

2009-12-27 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=32896

Fixes an issue where bugzilla-tool tries to read the username and password from
Git regardless of whether Git is installed. In particular, if Git is not
installed then bugzilla-tool dies (with a trace) when it attempts to query Git
for the authentication credentials to log into bugs.webkit.org.

Moreover, modifies Executive.run_command to catch and pass OSError exceptions to
the specified error handler. For instance, the specified error handler will now
be called when the command does not exist (i.e. OSError errno 2).

  • Scripts/modules/credentials.py: Added check for Git.
  • Scripts/modules/credentials_unittest.py: Added test method test_read_credentials_with_SVN.
  • Scripts/modules/executive.py: Modified method run_command to catch OSError exceptions (i.e [Errno 2] No such file or directory) and call the specified error handler.
  • Scripts/modules/executive_unittest.py: Added.
  • Scripts/run-webkit-unittests: Added import executive_unittest.py.
17:25 Changeset [52586] by mjs@apple.com

Rubber stamped by Cameron Zwarich.

Skip fast/images/size-failure.html on SnowLeopard because it
tickles a CG bug that makes it time out.

  • platform/mac-snowleopard/Skipped:
15:48 Changeset [52585] by mjs@apple.com

2009-12-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

fast/forms/basic-selects.html is failing on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=32960

The recently added fast/forms/basic-selects.html is failing on SnowLeopard; the
result checked in is only valid for Leopard and earlier, because SnowLeopard
slightly changed the disabled text color.


Move the pre-SL result to platform/mac-leopard and generate new
SnowLeopard results in platform/mac.


  • platform/mac-leopard/fast/forms/basic-selects-expected.checksum: Copied from platform/mac/fast/forms/basic-selects-expected.checksum.
  • platform/mac-leopard/fast/forms/basic-selects-expected.png: Copied from platform/mac/fast/forms/basic-selects-expected.png.
  • platform/mac-leopard/fast/forms/basic-selects-expected.txt: Copied from platform/mac/fast/forms/basic-selects-expected.txt.
  • platform/mac/fast/forms/basic-selects-expected.checksum:
  • platform/mac/fast/forms/basic-selects-expected.png:
  • platform/mac/fast/forms/basic-selects-expected.txt:
14:22 Changeset [52584] by krit@webkit.org

2009-12-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG: Stop rendering of objects with empty mask and filter content
https://bugs.webkit.org/show_bug.cgi?id=32968

It's not neccessary to continue rendering of an object and its' childs
if the mask clips the complete content away.
The same for filters, if the filter rendering is discontinued or either
width or height are zero.
We might also stop rendering if repaintRectInLocalCoordinates is empty.
But it needs to be fixed first.

Test: svg/custom/empty-mask.svg

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
  • svg/SVGMaskElement.h:
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/SVGResourceMasker.h:

2009-12-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG: Stop rendering of objects with empty mask and filter content
https://bugs.webkit.org/show_bug.cgi?id=32968

Check if the content is not drawn, if the mask clips the complete
content away.
mask-excessive-malloc needed an update. This patch stops rendering
if there is no content in mask. But it's intention is to test
big masking images.

  • platform/mac/svg/custom/empty-mask-expected.checksum: Added.
  • platform/mac/svg/custom/empty-mask-expected.png: Added.
  • platform/mac/svg/custom/empty-mask-expected.txt: Added.
  • platform/mac/svg/custom/mask-excessive-malloc-expected.checksum:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.png:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
  • svg/custom/empty-mask.svg: Added.
  • svg/custom/mask-excessive-malloc.svg:
11:25 Changeset [52583] by dbates@webkit.org

2009-12-27 Daniel Bates <dbates@webkit.org>

Unreviewed. Added missing file style_unittest.py that wasn't committed
in change set 52541 (http://trac.webkit.org/changeset/52541) as part of
the patch for bug #32592.

  • Scripts/modules/style_unittest.py: Added.
11:12 Changeset [52582] by dbates@webkit.org

2009-12-27 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32964

[bzt] Updated the unit test based on the change made in bug #32951.

The change made in bug #32951 added the command-line argument:
--makeargs="-j8" to the build-webkit command. However, the associated
unit test was not updated.

  • Scripts/modules/webkitport_unittest.py:
10:19 Changeset [52581] by christian@webkit.org

2009-12-27 Christian Dywan <christian@twotoasts.de>

Reviewed by Eric Seidel.

[GTK] Spell Check Suggestions (Do not work)
https://bugs.webkit.org/show_bug.cgi?id=30908

  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): Implement the 'title' member and set the title from the native menu item.
09:08 Changeset [52580] by krit@webkit.org

2009-12-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Mask result wrong, if two different objects call the same mask id
https://bugs.webkit.org/show_bug.cgi?id=32787

At the moment we create one resource per maskId. Some resources (like mask)
create ImageBuffers and depends on the properties of the RenderObject,
thus we can't use it for a second object.
This patch stores multiple mask resources for one maskId and different
RenderObject can use the same maskId.
Clipper, Filter and Patterns also need to store multiple resources later.

Test: svg/custom/mask-on-multiple-objects.svg

  • rendering/RenderPath.cpp: (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeRenderResources):
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::canvasResource):
  • svg/SVGClipPathElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::canvasResource):
  • svg/SVGFilterElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::canvasResource):
  • svg/SVGGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): (WebCore::SVGMaskElement::canvasResource):
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::canvasResource):
  • svg/SVGPatternElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
  • svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
  • svg/graphics/SVGPaintServer.cpp: (WebCore::getPaintServerById): (WebCore::SVGPaintServer::fillPaintServer): (WebCore::SVGPaintServer::strokePaintServer):
  • svg/graphics/SVGPaintServer.h:
  • svg/graphics/SVGResource.cpp: (WebCore::getResourceById):
  • svg/graphics/SVGResource.h:
  • svg/graphics/SVGResourceClipper.cpp: (WebCore::getClipperById):
  • svg/graphics/SVGResourceClipper.h:
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::getFilterById):
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/SVGResourceMarker.cpp: (WebCore::getMarkerById):
  • svg/graphics/SVGResourceMarker.h:
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::getMaskerById):
  • svg/graphics/SVGResourceMasker.h:

2009-12-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Mask result wrong, if two different objects call the same mask id
https://bugs.webkit.org/show_bug.cgi?id=32787

Two rects with different sizes and positions call the same mask id. Both
rects should be masked to two circles, dependent on the properties of the
rects.

  • platform/mac/svg/custom/mask-on-multiple-objects-expected.checksum: Added.
  • platform/mac/svg/custom/mask-on-multiple-objects-expected.png: Added.
  • platform/mac/svg/custom/mask-on-multiple-objects-expected.txt: Added.
  • svg/custom/mask-on-multiple-objects.svg: Added.
06:38 Changeset [52579] by zimmermann@webkit.org

2009-12-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Cleanup RenderPath code, related to markers. Pass around
PaintInfo objects instead of GraphicsContext directly, to
avoid having to recreate a new PaintInfo object in
SVGResourceMarker::draw().

No layout test changes.

05:27 Changeset [52578] by ossy@webkit.org

Rubber-stamped by Simon Hausmann.

[Qt] DRT sideeffect (authentication)
https://bugs.webkit.org/show_bug.cgi?id=32961

  • platform/qt/Skipped: http/tests/xmlhttprequest/failed-auth.html added temorarily (until fix).
05:15 Changeset [52577] by ossy@webkit.org

Rubber-stamped by Simon Hausmann.

Patch by Robert Hogan <robert@roberthogan.net> on 2009-12-27
Remove successful tests from qt skipped list

https://bugs.webkit.org/show_bug.cgi?id=32948

  • platform/qt/Skipped:
02:48 QtBackLog edited by zecke@selfish.org
Add OProfile JIT agent to the list of things to do (diff)
01:42 Changeset [52576] by ossy@webkit.org

Rubber-stamped by Simon Hausmann.

Patch by Robert Hogan <robert@roberthogan.net> on 2009-12-27
Remove duplicate entries from Qt skipped list

https://bugs.webkit.org/show_bug.cgi?id=32947

  • platform/qt/Skipped:
01:11 Changeset [52575] by eric@webkit.org

2009-12-27 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

check-webkit-style should not mark moc files inclusion as errors
https://bugs.webkit.org/show_bug.cgi?id=32669

Add a new header type for moc files, and skip them when checking the order of header files.

  • Scripts/modules/cpp_style.py:
00:55 Changeset [52574] by eric@webkit.org

2009-12-27 Patrick Gansterer <paroga@paroga.com>

Reviewed by Eric Seidel.

WinCE buildfix (added missing header)

  • platform/text/wince/TextBreakIteratorWince.cpp:
00:47 Changeset [52573] by eric@webkit.org

2009-12-27 Patrick Gansterer <paroga@paroga.com>

Reviewed by Eric Seidel.

Buildfix after r50760 and some style fixes.

  • rendering/RenderThemeWince.cpp: (WebCore::RenderThemeWince::paintSearchFieldCancelButton): (WebCore::RenderThemeWince::paintSliderTrack): (WebCore::RenderThemeWince::paintSliderThumb): (WebCore::RenderThemeWince::paintMediaMuteButton): (WebCore::RenderThemeWince::paintMediaPlayButton):
00:39 Changeset [52572] by eric@webkit.org

2009-12-27 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Barth.

WinCE buildfixes (missing headers and unsupported HWND_MESSAGE)

  • platform/wince/MIMETypeRegistryWince.cpp:
  • platform/wince/SearchPopupMenuWince.cpp:
  • platform/wince/SharedTimerWince.cpp: (WebCore::initializeOffScreenTimerWindow):
00:32 Changeset [52571] by eric@webkit.org

2009-12-27 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Barth.

WinCE buildfix (HWND_MESSAGE isn't supported there)

  • wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):
00:24 Changeset [52570] by eric@webkit.org

2009-12-27 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Barth.

Added a file with WinMain function to link agains in WinCE.

  • os-win32/WinMain.cpp: Added. (convertToUtf8): (WinMain):

12/26/09:

23:36 Changeset [52569] by eric@webkit.org

2009-12-26 Eric Seidel <eric@webkit.org>

No review, rolling out r52554.
http://trac.webkit.org/changeset/52554

https://bugs.webkit.org/show_bug.cgi?id=32955
The original change was covered under
https://bugs.webkit.org/show_bug.cgi?id=32913

r52554 was itself a rollout of r52536.
However it caused two layout tests to fail on Leopard:
storage/open-database-while-transaction-in-progress.html
svg/W3C-SVG-1.1/filters-conv-01-f.svg (no clue why?)

So I'm rolling out the rollout in an attempt to get the bots green.
r52554 did not explain why it was rolled out, so I do not know
what might fail for Chromium after this change. I warned the folks
in #chromium that it was coming.

  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
22:50 Changeset [52568] by abarth@webkit.org

2009-12-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make the qt build go fast
https://bugs.webkit.org/show_bug.cgi?id=32951

Make use of multiple cores, if available.

  • Scripts/modules/webkitport.py:
19:35 QtBackLog edited by zecke@selfish.org
(diff)
17:28 Changeset [52567] by mitz@apple.com

Added Radar URLs

17:27 Changeset [52566] by mitz@apple.com

REGRESSION (r47255): Extra Large Amount of Empty Space
https://bugs.webkit.org/show_bug.cgi?id=32690

Reviewed by Sam Weinig.

WebCore:

Test: fast/block/float/clear-to-fit.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::getClearDelta): Only clear floats as needed to
fit the child on the line.

LayoutTests:

  • fast/block/float/clear-to-fit-expected.checksum: Added.
  • fast/block/float/clear-to-fit-expected.png: Added.
  • fast/block/float/clear-to-fit-expected.txt: Added.
  • fast/block/float/clear-to-fit.html: Added.
01:40 Changeset [52565] by ossy@webkit.org

Rubber-stamped by Simon Hausmann.

[Qt] Skipping some flakey tests.
https://bugs.webkit.org/show_bug.cgi?id=32946

  • platform/qt/Skipped:
    • http/tests/cookies/simple-cookies-expired.html added.
    • storage/database-lock-after-reload.html added.
    • storage/empty-statement.html added.
    • storage/execute-sql-args.html added.
    • storage/hash-change-with-xhr.html added.
Note: See TracTimeline for information about the timeline view.