Timeline


and

01/03/10:

23:40 Changeset [52706] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-01-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric Seidel.

Update wtf/Platform.h to document the new system for porting macros.
https://bugs.webkit.org/show_bug.cgi?id=33130

  • wtf/Platform.h:
23:15 Changeset [52705] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-03 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix. Need to import ScriptError.

  • Scripts/webkitpy/buildsteps.py:
23:08 Porting Macros plan edited by mjs@apple.com
(diff)
23:08 Changeset [52704] by abarth@webkit.org
  • 7 edits in trunk/WebKitTools

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make it easier to run submit-patch when previous run cancelled
https://bugs.webkit.org/show_bug.cgi?id=33070

This patch renames create-review to submit-patch (as requested by
Maciej).

This patch makes it easier to run submit-patch after the user has
already cancelled a previous run of submit-patch by detecting when we
already have ChangeLogs and reading the bug number from them (and not
attempting to recreate them). Aside from performance and the extra
edit step, this command should not subsume post-dif.

Also, added a --email command line argument so that the output of
prepare-ChangeLog makes sense when it can't find the user's email
address.

  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/buildsteps.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/user.py:
23:04 Changeset [52703] by eric@webkit.org
  • 38 edits
    2 moves in trunk/WebKitTools

2010-01-03 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename Scripts/modules to Scripts/webkitpy
https://bugs.webkit.org/show_bug.cgi?id=33128

Just search-replace and svn mv commands.

  • Scripts/bugzilla-tool:
  • Scripts/check-webkit-style:
  • Scripts/modules: Removed.
  • Scripts/modules/BeautifulSoup.py: Removed.
  • Scripts/modules/init.py: Removed.
  • Scripts/modules/bugzilla.py: Removed.
  • Scripts/modules/bugzilla_unittest.py: Removed.
  • Scripts/modules/buildbot.py: Removed.
  • Scripts/modules/buildbot_unittest.py: Removed.
  • Scripts/modules/buildsteps.py: Removed.
  • Scripts/modules/buildsteps_unittest.py: Removed.
  • Scripts/modules/changelogs.py: Removed.
  • Scripts/modules/changelogs_unittest.py: Removed.
  • Scripts/modules/commands: Removed.
  • Scripts/modules/commands/init.py: Removed.
  • Scripts/modules/commands/commandtest.py: Removed.
  • Scripts/modules/commands/download.py: Removed.
  • Scripts/modules/commands/download_unittest.py: Removed.
  • Scripts/modules/commands/early_warning_system.py: Removed.
  • Scripts/modules/commands/early_warning_system_unittest.py: Removed.
  • Scripts/modules/commands/queries.py: Removed.
  • Scripts/modules/commands/queries_unittest.py: Removed.
  • Scripts/modules/commands/queues.py: Removed.
  • Scripts/modules/commands/queues_unittest.py: Removed.
  • Scripts/modules/commands/queuestest.py: Removed.
  • Scripts/modules/commands/upload.py: Removed.
  • Scripts/modules/commands/upload_unittest.py: Removed.
  • Scripts/modules/comments.py: Removed.
  • Scripts/modules/committers.py: Removed.
  • Scripts/modules/committers_unittest.py: Removed.
  • Scripts/modules/cpp_style.py: Removed.
  • Scripts/modules/cpp_style_unittest.py: Removed.
  • Scripts/modules/credentials.py: Removed.
  • Scripts/modules/credentials_unittest.py: Removed.
  • Scripts/modules/diff_parser.py: Removed.
  • Scripts/modules/diff_parser_unittest.py: Removed.
  • Scripts/modules/executive.py: Removed.
  • Scripts/modules/executive_unittest.py: Removed.
  • Scripts/modules/grammar.py: Removed.
  • Scripts/modules/mock.py: Removed.
  • Scripts/modules/mock_bugzillatool.py: Removed.
  • Scripts/modules/multicommandtool.py: Removed.
  • Scripts/modules/multicommandtool_unittest.py: Removed.
  • Scripts/modules/outputcapture.py: Removed.
  • Scripts/modules/patchcollection.py: Removed.
  • Scripts/modules/queueengine.py: Removed.
  • Scripts/modules/queueengine_unittest.py: Removed.
  • Scripts/modules/scm.py: Removed.
  • Scripts/modules/scm_unittest.py: Removed.
  • Scripts/modules/statusbot.py: Removed.
  • Scripts/modules/stepsequence.py: Removed.
  • Scripts/modules/style: Removed.
  • Scripts/modules/style.py: Removed.
  • Scripts/modules/style_unittest.py: Removed.
  • Scripts/modules/text_style.py: Removed.
  • Scripts/modules/text_style_unittest.py: Removed.
  • Scripts/modules/user.py: Removed.
  • Scripts/modules/webkit_logging.py: Removed.
  • Scripts/modules/webkit_logging_unittest.py: Removed.
  • Scripts/modules/webkit_mechanize.py: Removed.
  • Scripts/modules/webkitport.py: Removed.
  • Scripts/modules/webkitport_unittest.py: Removed.
  • Scripts/test-webkit-python: Removed.
  • Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
  • Scripts/validate-committer-lists:
  • Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/buildbot_unittest.py:
  • Scripts/webkitpy/buildsteps.py:
  • Scripts/webkitpy/buildsteps_unittest.py:
  • Scripts/webkitpy/commands/commandtest.py:
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/download_unittest.py:
  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/early_warning_system_unittest.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/queries_unittest.py:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/queuestest.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/comments.py:
  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/credentials_unittest.py:
  • Scripts/webkitpy/executive.py:
  • Scripts/webkitpy/executive_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/multicommandtool.py:
  • Scripts/webkitpy/multicommandtool_unittest.py:
  • Scripts/webkitpy/queueengine.py:
  • Scripts/webkitpy/queueengine_unittest.py:
  • Scripts/webkitpy/scm.py:
  • Scripts/webkitpy/scm_unittest.py:
  • Scripts/webkitpy/statusbot.py:
  • Scripts/webkitpy/stepsequence.py:
  • Scripts/webkitpy/webkit_logging_unittest.py:
  • Scripts/webkitpy/webkitport_unittest.py:
22:58 Porting Macros plan edited by mjs@apple.com
(diff)
22:54 Porting Macros plan edited by mjs@apple.com
(diff)
22:50 Porting Macros plan created by mjs@apple.com
22:49 WikiStart edited by mjs@apple.com
(diff)
22:31 Changeset [52702] by eric@webkit.org
  • 3 edits
    1 move
    1 add in trunk/WebKitTools

2010-01-03 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Added script to test both Perl and Python, and renamed
run-webkit-unittests to test-webkit-python.

https://bugs.webkit.org/show_bug.cgi?id=33045

  • Scripts/VCSUtils_unittest.pl:
    • Tweaked so it can be run from outside Scripts directory.
  • Scripts/run-webkit-unittests: Removed.
    • Renamed to test-webkit-python.
  • Scripts/test-webkit-perl:
    • Tweaked so it can be run from outside Scripts directory.
  • Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
  • Scripts/test-webkit-scripts: Added.
    • Runs both test-webkit-perl and test-webkit-python.
19:12 Changeset [52701] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue/bugzilla-tool should build both Debug and Release
https://bugs.webkit.org/show_bug.cgi?id=28450

Add a --build-style command that lets the master process tell the child
process to build both debug and release. Eventually we want to teach
the test step to understand this option too, but that's a patch for
another day.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/webkitport.py:
  • Scripts/modules/webkitport_unittest.py:
18:40 Changeset [52700] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-01-03 Kenneth Russell <kbr@google.com>

Reviewed by Maciej Stachowiak.

Index validation code must always copy client data
https://bugs.webkit.org/show_bug.cgi?id=32748

Client data must always be copied during bufferData and
bufferSubData calls, because otherwise the data the GL uses to
draw may differ from that checked by the index validation code.

  • fast/canvas/webgl/index-validation-copies-indices-expected.txt: Added.
  • fast/canvas/webgl/index-validation-copies-indices.html: Added.

2010-01-03 Kenneth Russell <kbr@google.com>

Reviewed by Maciej Stachowiak.

Index validation code must always copy client data
https://bugs.webkit.org/show_bug.cgi?id=32748

Client data must always be copied during bufferData and
bufferSubData calls, because otherwise the data the GL uses to
draw may differ from that checked by the index validation code.

Test: fast/canvas/webgl/index-validation-copies-indices.html

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::WebGLBuffer): (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData):
  • html/canvas/WebGLBuffer.h:
18:32 Changeset [52699] by eric@webkit.org
  • 6 edits in trunk

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Implement CookieJarChromium::cookiesEnabled
https://bugs.webkit.org/show_bug.cgi?id=33123

Call out to ChromiumBridge to find out if cookies are enabled.

  • platform/chromium/ChromiumBridge.h:
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::cookiesEnabled):

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Implement CookieJarChromium::cookiesEnabled
https://bugs.webkit.org/show_bug.cgi?id=33123

Call out to the webKitClient() to see if cookies are enabled. Also
remove some straggling references to policyURL!

  • public/WebKitClient.h: (WebKit::WebKitClient::setCookies): (WebKit::WebKitClient::cookies): (WebKit::WebKitClient::rawCookies): (WebKit::WebKitClient::cookiesEnabled):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cookiesEnabled):
18:24 Changeset [52698] by eric@webkit.org
  • 11 edits in trunk

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove evaluateInNewContext (it's useless)
https://bugs.webkit.org/show_bug.cgi?id=33068

This function has no clients and makes life complicated. Isolated
worlds won out over NewContext and there's not really any going back
now.

No new tests because this is all minus lines.

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertWindowToV8Object):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove evaluateInNewContext (it's useless)
https://bugs.webkit.org/show_bug.cgi?id=33068

This function has no clients and makes life complicated. Isolated
worlds won out over NewContext and there's not really any going back
now.

  • public/WebFrame.h:
  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
18:17 Changeset [52697] by eric@webkit.org
  • 4 edits in trunk

2010-01-03 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] EventSender: add support for Enter key events
https://bugs.webkit.org/show_bug.cgi?id=33064

Unskip 5 tests that are fixed now.

  • platform/qt/Skipped:

2010-01-03 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] EventSender: add support for Enter key events
https://bugs.webkit.org/show_bug.cgi?id=33064

Unskip 5 tests that are fixed now.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
18:10 Changeset [52696] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Add test for previous typo fix
https://bugs.webkit.org/show_bug.cgi?id=33083

A trivial test for a trivial fix, as requested by Eric.

  • Scripts/modules/bugzilla_unittest.py:
18:03 Changeset [52695] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement mac-ews
https://bugs.webkit.org/show_bug.cgi?id=33072

The mac-ews is slightly different than the other early warning systems
because we can't run Mac OS X inside a VM. For that reason, we only
process patches that were uploaded by committers. This isn't as much
coverage as the other EWS bots, but it's better than nothing.

  • Scripts/modules/commands/early_warning_system.py:
  • Scripts/modules/commands/early_warning_system_unittest.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/queuestest.py:
  • Scripts/modules/mock_bugzillatool.py:
17:55 Changeset [52694] by eric@webkit.org
  • 1 edit
    12 moves
    3 adds in trunk/LayoutTests

2010-01-03 Mario Bensi <mbensi@pleyo.com>

Reviewed by Simon Fraser.

create 3d directory and move tests dependent of 3D Rendering in this
directory.

https://bugs.webkit.org/show_bug.cgi?id=33081

  • animations/3d: Added.
  • animations/3d/change-transform-in-end-event.html: Copied from LayoutTests/animations/change-transform-in-end-event.html.
  • animations/3d/state-at-end-event-transform.html: Copied from LayoutTests/animations/state-at-end-event-transform.html.
  • animations/3d/transform-origin-vs-functions-expected.txt: Copied from LayoutTests/animations/transform-origin-vs-functions-expected.txt.
  • animations/3d/transform-origin-vs-functions.html: Copied from LayoutTests/animations/transform-origin-vs-functions.html.
  • animations/change-transform-in-end-event.html: Removed.
  • animations/state-at-end-event-transform.html: Removed.
  • animations/transform-origin-vs-functions-expected.txt: Removed.
  • animations/transform-origin-vs-functions.html: Removed.
13:48 Changeset [52693] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip test that fails on and off on the release bot.

13:25 Changeset [52692] by ddkilzer@apple.com
  • 6 edits in trunk/WebKitTools

Refactored svn-apply and svn-unapply to use a common "patch"
command method, and added unit tests for this new method.

Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-03
Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=33098

  • Scripts/VCSUtils.pm:
    • Added generateRunPatchCommand().
    • Added runPatchCommand().
    • Added exitStatus() from webkitdirs.pm to address FIXME.
  • Scripts/VCSUtils_unittest.pl:
    • Added 10 unit tests for generateRunPatchCommand().
    • Added 4 unit tests for runPatchCommand().
    • Added callSilently() method.
  • Scripts/svn-apply:
    • Refactored applyPatch().
    • Removed $pathScriptWasRunFrom global variable.
    • Addressed issue where "--force" option was getting added twice.
  • Scripts/svn-unapply:
    • Refactored applyPatch().
    • Removed $pathScriptWasRunFrom global variable.
    • Added support for --force option.
    • Enhanced to return meaningful exit status.
  • Scripts/webkitdirs.pm:
    • Moved exitStatus() implementation to VCSUtils.pm.
11:39 Changeset [52691] by weinig@apple.com
  • 4 edits in trunk/WebCore

Rubber-stamped by Dan Bernstein.

Remove out of date commented out attributes in IDLs. We have implemented onpopstate.

  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.idl:
  • page/DOMWindow.idl:
11:36 Changeset [52690] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebKit/qt

2009-12-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable all HTML5 persistent features for QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=33086

  • QGVLauncher/main.cpp: Call enablePersistentStorage() (main):
09:45 Changeset [52689] by krit@webkit.org
  • 5 edits in trunk/WebCore

2010-01-03 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Mark more filter effect as alphaImage if possible
https://bugs.webkit.org/show_bug.cgi?id=33111

Mark more effects as alphaImage if the previous effect is a
alphaImage. This can reduce the calculation on the next effect
like feGaussianBlur.


Test: This changes don't affect any LayoutTests and can't be tested

somehow, since the changes are 'invisible'.

  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

01/02/10:

11:57 Changeset [52688] by dbates@webkit.org
  • 5 edits
    3 deletes in trunk/LayoutTests

2010-01-02 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33109

Cleans up the XSSAuditor test directory by removing unnecessary test scripts.

The patch for bug #33107 added notifyDone() functionality to the script
echo-intertag.pl. So, we can substitute this script for scripts echo-intertag-and-notify.php,
echo-intertag-post-and-notify.pl, and echo-intertag-post.pl.

  • http/tests/security/xssAuditor/link-opens-new-window.html: Modified to call script echo-intertag.pl.
  • http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Removed.
  • http/tests/security/xssAuditor/script-tag-post-control-char.html: Modified to call script echo-intertag.pl.
  • http/tests/security/xssAuditor/script-tag-post-null-char.html: Modified to call script echo-intertag.pl.
  • http/tests/security/xssAuditor/script-tag-post.html: Modified to call script echo-intertag.pl.
11:54 Changeset [52687] by dbates@webkit.org
  • 4 edits in trunk/LayoutTests

2010-01-02 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33107

Removes the use of window.setTimeout from the XSSAuditor tests:
get-from-iframe.html and post-from-iframe.html by having the
script echo-intertag.pl (called by these tests) call
layoutTestController.notifyDone().

  • http/tests/security/xssAuditor/get-from-iframe.html: Removes call of window.setTimeout.
  • http/tests/security/xssAuditor/post-from-iframe.html: Ditto.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl: If the query argument notifyDone is found, then the script will generate a JavaScript script to call layoutTestController.notifyDone().

01/01/10:

11:40 Changeset [52686] by simon.fraser@apple.com
  • 5 edits
    4 adds in trunk

2010-01-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Scrollbar of overflow:scroll div in compositing layer fails to render
https://bugs.webkit.org/show_bug.cgi?id=32439

When deciding whether a RenderLayer needs backing store, check whether it has
overflow controls that need painting.

Test: compositing/overflow/scrollbar-painting.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hasOverflowControls):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

12/31/09:

20:42 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
Document the new netsim in the perf suite. (diff)
12:03 Changeset [52685] by christian@webkit.org
  • 2 edits in trunk/WebCore

2009-12-31 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546

Only show font menu items in rich text areas in the GTK+ port.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
11:58 Changeset [52684] by christian@webkit.org
  • 2 edits in trunk/WebCore

2009-12-31 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546

Don't show spell checking menu items in text areas in the GTK+ port.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
11:10 QtWebKitBackportingFixes edited by norbert.leser@nokia.com
Added svn rev# for bug 33082 (diff)
11:07 QtWebKitBackportingFixes edited by norbert.leser@nokia.com
(diff)
10:41 Changeset [52683] by mitz@apple.com
  • 4 edits
    4 adds in trunk

<rdar://problem/7503279> REGRESSION (r47440): Incomplete repaint at macworldexpo.com
https://bugs.webkit.org/show_bug.cgi?id=33067

Reviewed by Simon Fraser.

WebCore:

Test: fast/repaint/table-cell-overflow.html

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::hasVisibleOverflow): Added.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows): Set m_hasOverflowingCell if
any cell has visible overflow, like it was before r47440.

LayoutTests:

  • fast/repaint/table-cell-overflow-expected.checksum: Added.
  • fast/repaint/table-cell-overflow-expected.png: Added.
  • fast/repaint/table-cell-overflow-expected.txt: Added.
  • fast/repaint/table-cell-overflow.html: Added.
10:07 Changeset [52682] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Do not include Frame.h under WebCore/html/canvas
https://bugs.webkit.org/show_bug.cgi?id=33082

No new tests, as there is no new functionality.

  • html/canvas/CanvasRenderingContext2D.cpp:
08:45 ApplicationsGtk edited by iwkse@claws-mail.org
(diff)
08:38 Changeset [52681] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement build-and-test
https://bugs.webkit.org/show_bug.cgi?id=33073

Some of the early warning system bots want to use build-and-test so
they can cover LayoutTests in addition to just compilation.

  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/download_unittest.py:
04:49 Changeset [52680] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2009-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Show mac-ews status on QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=33076

Also make error status purple.

  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/statusbubble.html:
00:35 Changeset [52679] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-31 Adam Barth <abarth@webkit.org>

Unreviewed.

[bzt] REGRESSION: Bugzila is a typo
https://bugs.webkit.org/show_bug.cgi?id=33074

Eric should test his code before landing! :)

  • Scripts/modules/bugzilla.py:
00:25 Changeset [52678] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-31 Adam Barth <abarth@webkit.org>

Unreviewed. Fix the unit tests!

  • Scripts/run-webkit-unittests:

12/30/09:

20:58 Changeset [52677] by eric@webkit.org
  • 4 edits in trunk

2009-12-30 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[Chromium] Delete ResourceRequest::securityInfo
https://bugs.webkit.org/show_bug.cgi?id=26847

  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):

2009-12-30 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[Chromium] Delete ResourceRequest::securityInfo
https://bugs.webkit.org/show_bug.cgi?id=26847

  • platform/network/chromium/ResourceRequest.h:
16:12 Changeset [52676] by ajwong@chromium.org
  • 2 edits in trunk/WebKit/chromium

Not reviewed. Trivial Chromium build fix.

Add static_cast<unsigned>() to fix signed/unsigned comparison warning.

  • src/AutocompletePopupMenuClient.cpp:

(WebKit::AutocompletePopupMenuClient::selectionChanged):

15:54 Changeset [52675] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Remove unused code from V8DOMWrapper.

  • bindings/v8/V8DOMWrapper.cpp: Removed code that I added but it's no longer used.
  • bindings/v8/V8DOMWrapper.h: Ditto.
15:47 Changeset [52674] by dglazkov@chromium.org
  • 4 edits in trunk/WebCore

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Generate configuring undetectable collection.
https://bugs.webkit.org/show_bug.cgi?id=33063

Refactoring, covered by existing tests.

  • bindings/scripts/CodeGeneratorV8.pm: Added GenerateImplementationMasqueradeAsUndefined.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Touched to keep IB-based builds happy.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed hand-configuring.
15:08 Changeset [52673] by eric@webkit.org
  • 15 edits in trunk

2009-12-30 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by Dimitri Glazkov.

Autocomplete in Chromium now offers suggestions within the input element as a user
a) types text that produces some autocomplete suggestions, and
b) scrolls through suggested values in the menu
The suggested value is rendered but not exposed through JS unti the
user makes the final selection.

No new tests since this new functionality (autocomplete suggestions)
is intentionally hidden from everything else than renderer.

  • src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::initialize): (WebKit::AutocompletePopupMenuClient::setInitialAutocompleteValue): (WebKit::AutocompletePopupMenuClient::selectionChanged): (WebKit::AutocompletePopupMenuClient::popupDidHide): (WebKit::AutocompletePopupMenuClient::setTextFromItem): (WebKit::AutocompletePopupMenuClient::resetLastFieldValue):
  • src/AutocompletePopupMenuClient.h:

2009-12-30 Zelidrag Hornung <zelidrag@chromium.org>

Reviewed by Dimitri Glazkov.

Added ability for PopupMenuClient to signal when
a) selection changed, and
b) weather suggested value should be accepted when popup menu closes

No new tests since this new functionality (autocomplete suggestions)
is intentionally hidden from everything else than renderer.

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::hidePopup): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::clearSelection): (WebCore::PopupListBox::hidePopup):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::menuUnmapped):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
  • platform/qt/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::hidePopup):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::hide):
  • platform/wx/PopupMenuWx.cpp: (WebCore::PopupMenu::OnMenuItemSelected):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::popupDidHide):
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::selectionChanged):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::popupDidHide):
  • rendering/RenderTextControlSingleLine.h: (WebCore::RenderTextControlSingleLine::selectionChanged):
13:59 Changeset [52672] by japhet@chromium.org
  • 25 edits
    1 delete in trunk/WebCore

2009-12-30 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Auto-generate V8 bindings header declarations for
property accessor getter/setters, and remove a couple of
unnecessarily custom bindings that weren't properly declared
custom anyway.

  • Android.v8bindings.mk: Remove V8NavigatorCustom.cpp.
  • WebCore.gypi: Remove V8NavigatorCustom.cpp.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/custom/V8AttrCustom.cpp:
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • bindings/v8/custom/V8CoordinatesCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8DocumentLocationCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8MessageEventCustom.cpp:
  • bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
  • bindings/v8/custom/V8SVGLengthCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
13:24 Changeset [52671] by eric@webkit.org
  • 4 edits
    1 move in trunk/LayoutTests

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Anders Carlsson.

svg/custom/use-on-symbol-inside-pattern.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=17393

Reenable the test. It isn't failing anymore.

  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.checksum:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • svg/custom/use-on-symbol-inside-pattern.svg: Copied from LayoutTests/svg/custom/use-on-symbol-inside-pattern.svg-disabled.
  • svg/custom/use-on-symbol-inside-pattern.svg-disabled: Removed.
12:05 Changeset [52670] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Touch DerivedSourcesAllInOne to avoid clobbering IB-based builds.

  • bindings/v8/DerivedSourcesAllInOne.cpp: Added a line-break.
11:28 Changeset [52669] by dglazkov@chromium.org
  • 4 edits
    1 delete in trunk/WebCore

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Generate configuring of call-as-function callbacks.
https://bugs.webkit.org/show_bug.cgi?id=33061

Refactoring, covered by existing tests.

  • bindings/scripts/CodeGeneratorV8.pm: Added GenerateHeaderCustomCall and

GenerateImplementationCustomCall.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed all hand-configuring of call-as-function

callbacks.

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::V8HTMLAppletElement::callAsFunctionCallback): Added. (WebCore::V8HTMLEmbedElement::callAsFunctionCallback): Added. (WebCore::V8HTMLObjectElement::callAsFunctionCallback): Added.
  • bindings/v8/custom/V8HTMLPlugInElementCustom.h: Removed.
11:26 Changeset [52668] by kevino@webkit.org
  • 8 edits
    3 adds in trunk

Reviewed by Kevin Ollivier.

Introduce wxWebSettings API interface for editing wxWebView / page settings.

https://bugs.webkit.org/show_bug.cgi?id=32956

10:37 Changeset [52667] by eric@webkit.org
  • 16 edits
    2 moves in trunk/WebKitTools

2009-12-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

logging.py should be renamed to webkit_logging.py and eventually die
https://bugs.webkit.org/show_bug.cgi?id=33058

Change all imports of "logging" to webkit_logging,
except the ones which came from Google's cpp_lint.py and diff_parser.py
which clearly are assuming python's logging.py.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/buildbot.py:
  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/queries.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/upload.py:
  • Scripts/modules/credentials.py:
  • Scripts/modules/executive.py:
  • Scripts/modules/multicommandtool.py:
  • Scripts/modules/queueengine.py:
  • Scripts/modules/scm.py:
  • Scripts/modules/statusbot.py:
  • Scripts/modules/stepsequence.py:
  • Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
  • Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
10:22 Changeset [52666] by abarth@webkit.org
  • 7 edits
    2 adds in trunk/WebCore

2009-12-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[v8] Move world-specific state out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=33034

This is the first step towards unifying the V8 implementation of
isolated worlds with the JSC implementation. We need an object to
encapulate all the world-specific bindings state. Previoulsy, we used
V8Proxy for this purpose (along with a million other things), but
there's a one-to-one mapping between V8Proxy objects and Frame objects.

This patch takes the world-specific state and moves it to a new object,
affectionately called V8DOMWindowShell. This object is the moral
equivalent of JSDOMWindowShell but with more data members because life
is more complicated in V8-land.

This patch is almost entirely code motion. Future patches will clean
up this class as we use it to represent window shells in isolated
worlds as well as the main world.

  • WebCore.gypi:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::updateDocument):
  • bindings/v8/V8DOMWindowShell.cpp: Added. (WebCore::handleFatalErrorInV8): (WebCore::reportFatalErrorInV8): (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::isContextInitialized): (WebCore::V8DOMWindowShell::disposeContextHandles): (WebCore::V8DOMWindowShell::destroyGlobal): (WebCore::V8DOMWindowShell::clearForClose): (WebCore::V8DOMWindowShell::clearForNavigation): (WebCore::V8DOMWindowShell::initContextIfNeeded): (WebCore::V8DOMWindowShell::createNewContext): (WebCore::V8DOMWindowShell::installDOMWindow): (WebCore::V8DOMWindowShell::updateDocumentWrapper): (WebCore::V8DOMWindowShell::clearDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::V8DOMWindowShell::clearDocumentWrapperCache): (WebCore::V8DOMWindowShell::setSecurityToken): (WebCore::V8DOMWindowShell::updateDocument): (WebCore::V8DOMWindowShell::updateSecurityOrigin): (WebCore::V8DOMWindowShell::getHiddenObjectPrototype): (WebCore::V8DOMWindowShell::installHiddenObjectPrototype): (WebCore::V8DOMWindowShell::createWrapperFromCacheSlowCase):
  • bindings/v8/V8DOMWindowShell.h: Added. (WebCore::V8DOMWindowShell::context): (WebCore::V8DOMWindowShell::createWrapperFromCache):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructorForContext): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::V8IsolatedWorld):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::setContextDebugId):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::windowShell): (WebCore::V8Proxy::extensions):
09:50 Changeset [52665] by eric@webkit.org
  • 6 edits in trunk

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVGResourceClipper needs to invalidate content
https://bugs.webkit.org/show_bug.cgi?id=33054

Added invalidate() to SVGResourceClipper to reset clipData
and drawing area after attribute changes.

This fixes two LayoutTests.

  • svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::invalidate):
  • svg/graphics/SVGResourceClipper.h:

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVGResourceClipper needs to invalidate content
https://bugs.webkit.org/show_bug.cgi?id=33054

Drawing area should change after attribute changes in clipPath or
it's childs.

  • platform/mac/svg/custom/clip-path-child-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-units-changes-expected.txt:
09:42 Changeset [52664] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-30 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] RenderThemeQt::applyTheme is a misnomer and is suboptimally coded.

https://bugs.webkit.org/show_bug.cgi?id=33035

This patch:

  • renames RenderThemeQt::applyTheme to initializeCommonQStyleOptions,
  • extracts the palette initialization code to a separate function in order to provide for readable pointer checking and moves this code up in the function to allow for future changes to the palette brushes needed for bug 30173,
  • optimizes some of the code in the function for readability, speed and size.
  • fixes some minor style issues

No new tests because code behavior is not changed.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): (WebCore::initPaletteFromPageClientIfExists): (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
  • platform/qt/RenderThemeQt.h:
08:49 Changeset [52663] by dglazkov@chromium.org
  • 6 edits in trunk/WebCore

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Generate configuring of all indexers.
https://bugs.webkit.org/show_bug.cgi?id=33031

Refactorig, covered by existing tests.

  • bindings/scripts/CodeGeneratorV8.pm: Added generation of indexers for

special cases.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed custom tempalte configuration of

indexers.

  • bindings/v8/custom/V8CustomBinding.h: Added decls for Applet, Embed, and Object

elements (these will be generated, too -- later.)

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::npObjectIndexedGetter): Moved common code to a separate method. (WebCore::npObjectIndexedSetter): Ditto. (WebCore::INDEXED_PROPERTY_GETTER): Added custom handlers for Applet, Embed, and Object all calling the common method. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
08:43 Changeset [52662] by eric@webkit.org
  • 8 edits in trunk

2009-12-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] It should be possible to disable inspector
https://bugs.webkit.org/show_bug.cgi?id=32724

This change fixes the build break. Some QtWebKit interfaces
will not be fully functional (most notable QWebInspector) if
INSPECTOR is disabled.

  • Api/qwebinspector.cpp: (QWebInspector::showEvent): (QWebInspector::closeEvent):
  • Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPagePrivate::getOrCreateInspector): (QWebPagePrivate::inspectorController): (QWebPage::triggerAction): (QWebPage::updatePositionDependentActions):
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow):

2009-12-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] It should be possible to disable inspector
https://bugs.webkit.org/show_bug.cgi?id=32724

This makes the r48430 available for other ports as well.
No new tests, as there is no new functionality.

  • inspector/InjectedScriptHost.idl: Guard the interface with INSPECTOR guard.
  • inspector/InspectorBackend.idl: Ditto.
  • inspector/InspectorFrontendHost.idl: Ditto.
08:13 Changeset [52661] by dglazkov@chromium.org
  • 6 edits in trunk/WebCore

2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

[V8] Generate configuring of all named property getters/setters/enumerators.
https://bugs.webkit.org/show_bug.cgi?id=32996

Refactoring, covered by existing tests.

  • bindings/scripts/CodeGeneratorV8.pm: Added generation of named property handlers

for special cases (See bug for more info).

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): Removed custom template configuration of named

property handlers.

  • bindings/v8/custom/V8CustomBinding.h: Added decls for Applet, Embed, and Object

elements (these will be generated, too -- later.)

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::npObjectNamedGetter): Moved common code to a separate method. (WebCore::npObjectNamedSetter): Ditto. (WebCore::NAMED_PROPERTY_GETTER): Added custom handlers for Applet, Embed, and Object all calling the common method. (WebCore::NAMED_PROPERTY_SETTER): Ditto.
06:58 Changeset [52660] by eric@webkit.org
  • 4 edits in trunk

2009-12-30 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Fix PluginView::handlePostReadFile().
https://bugs.webkit.org/show_bug.cgi?id=33052

The function should actually rewrite the given file to the buffer.

This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
now along with other passing http/plugins tests.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::handlePostReadFile):

2009-12-30 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Fix PluginView::handlePostReadFile().
https://bugs.webkit.org/show_bug.cgi?id=33052

The function should actually rewrite the given file to the buffer.

This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
now along with other passing http/plugins tests.

  • platform/qt/Skipped:
06:30 Changeset [52659] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-30 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
https://bugs.webkit.org/show_bug.cgi?id=33051

Moreover, its primary function is to normalize the path in regard of platform
specific directory separators. Therefore, it can simply make use of the
QDir::toNativeSeparators function.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::pathToLocalResource):
06:16 Changeset [52658] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Fix executable bits for r52646

  • Scripts/VCSUtils_unittest.pl: Added property svn:executable.
  • Scripts/test-webkit-perl: Ditto.
06:12 Changeset [52657] by zecke@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Revert "Implement ImageDecoderQt::clearFrameBufferCache()" from r52516.

https://bugs.webkit.org/show_bug.cgi?id=32121

The implementation appears to either run into an ASSERT
or leak memory at runtime as the m_buffer, m_reader may
already exist. The bug was reopened and we do have a plan now.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::clearFrameBufferCache):

  • platform/graphics/qt/ImageDecoderQt.h:
05:09 Changeset [52656] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-12-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skipping isolatedWorld test - we still do not support that.

  • platform/gtk/Skipped:
04:58 Changeset [52655] by hausmann@webkit.org
  • 3 edits
    5 adds in trunk

WebCore: [Qt] Add support for Symbian def files

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-12-30
Reviewed by Simon Hausmann.

  • WebCore.pro:

WebKit/qt: Upstream Symbian def files from Qt 4.6.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-12-30
Reviewed by Simon Hausmann.

These files define the ABI of QtWebKit on Symbian.

  • symbian/bwins/QtWebKitu.def: Added.
  • symbian/eabi/QtWebKitu.def: Added.
04:40 Changeset [52654] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed Qt/Symbian build fix.

Don't build network state notifier support when building inside of Qt.
Otherwise the Qt build depends on an external module that itself depends
on Qt again.

  • WebCore.pro:
04:34 Changeset [52653] by yurys@chromium.org
  • 7 edits in trunk/WebCore

2009-12-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Use current isolated world's context for ScriptCallStack.

https://bugs.webkit.org/show_bug.cgi?id=33016

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): (WebCore::ScriptController::currentScriptState): (WebCore::ScriptController::clearWindowShell):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::scriptState):
  • bindings/v8/V8IsolatedWorld.h:
02:46 Changeset [52652] by ossy@webkit.org
  • 1 edit
    1 copy
    4 adds in trunk/LayoutTests

Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-30
[Qt] Add expected files for the following new passing tests.

  • platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
  • platform/qt/fast/block/float/in-margin-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/in-margin-expected.txt.
  • platform/qt/fast/text/fake-italic-expected.txt: Added.
  • platform/qt/svg/custom/empty-mask-expected.txt: Added.
  • platform/qt/svg/filters/filter-source-position-expected.txt: Added.
02:20 Changeset [52651] by ossy@webkit.org
  • 12 edits in trunk/LayoutTests

[Qt] Expected files updated after r52647.

Reviewed by Dirk Schulze.

  • platform/qt/svg/css/clippath-with-shadow-expected.txt:
  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
01:20 Changeset [52650] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] DataGrid support turned off by r52648. Expected files updated.

  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
  • platform/qt/fast/js/global-constructors-expected.txt: updated.
00:56 Changeset [52649] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2009-12-30 Dirk Schulze <krit@webkit.org>

Unreviewed test result fix.

Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815

Forgot to update this test.

  • platform/mac/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
00:52 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
00:47 Changeset [52648] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Turn off DataGrid support by default.

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2009-12-30
Reviewed by Simon Hausmann.

No new tests, as there is no new functionality.

  • WebCore.pro:
00:10 Changeset [52647] by krit@webkit.org
  • 82 edits in trunk

2009-12-29 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815

Add new bounding boxes for strokes, filters, masker and clipper in SVG.
These new bounding boxes help to fix repaintRectInLocalCoordinates.
We calculate the smallest repaint rect considering the new bounding boxes
now, filters get the correct paint area, masker clip the mask image size
to the visible area of the target.

Tests: Many tests need an update. The changes in repaintRectInLocalCoordinates

affect the LayoutTests.

  • rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::strokeBoundingBox):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::toSVGRenderBase):
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::strokeBoundingBox): (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::setPath):
  • rendering/RenderPath.h: (WebCore::RenderPath::markerBoundingBox):
  • rendering/RenderSVGBlock.h: (WebCore::RenderSVGBlock::toSVGRenderBase):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::strokeBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::toSVGRenderBase): (WebCore::RenderSVGImage::strokeBoundingBox):
  • rendering/RenderSVGInline.h: (WebCore::RenderSVGInline::objectBoundingBox): (WebCore::RenderSVGInline::repaintRectInLocalCoordinates):
  • rendering/RenderSVGModelObject.h: (WebCore::RenderSVGModelObject::toSVGRenderBase):
  • rendering/RenderSVGRoot.h: (WebCore::RenderSVGRoot::strokeBoundingBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/RenderSVGText.h: (WebCore::RenderSVGText::toSVGRenderBase):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::~SVGRenderBase): (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
  • rendering/SVGRenderSupport.h: (WebCore::SVGRenderBase::toSVGRenderBase): (WebCore::SVGRenderBase::strokeBoundingBox): (WebCore::SVGRenderBase::markerBoundingBox):
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::toSVGRenderBase): (WebCore::SVGRootInlineBox::objectBoundingBox): (WebCore::SVGRootInlineBox::repaintRectInLocalCoordinates):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterBoundingBox):
  • svg/SVGFilterElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::maskBoundingBox): (WebCore::SVGMaskElement::drawMaskerContent):
  • svg/SVGMaskElement.h:
  • svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::clipperBoundingBox):
  • svg/graphics/SVGResourceClipper.h:
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::filterBoundingBox): (WebCore::shouldProcessFilter): (WebCore::SVGResourceFilter::prepareFilter):
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::maskerBoundingBox): (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/SVGResourceMasker.h:

2009-12-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmmermann.

Detailed boundingBoxes in SVG Renderer
https://bugs.webkit.org/show_bug.cgi?id=32815

Mainly Filter and Masker tests need new test results.
repaintRectInLocalCoordinates changed to calculate the smallest
repaint area considering the bounding bo of masker, filter and
clipper as well as the stroke and marker boundaries.

  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/css/clippath-with-shadow-expected.txt:
  • platform/mac/svg/custom/clip-path-display-none-child-expected.txt:
  • platform/mac/svg/custom/clip-path-href-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/mac/svg/custom/clip-path-with-transform-expected.txt:
  • platform/mac/svg/custom/empty-merge-expected.txt:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
  • platform/mac/svg/custom/focus-ring-expected.checksum:
  • platform/mac/svg/custom/focus-ring-expected.png:
  • platform/mac/svg/custom/focus-ring-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.txt:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.checksum:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.png:
  • platform/mac/svg/custom/mask-with-all-units-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.txt:
  • platform/mac/svg/custom/recursive-clippath-expected.txt:
  • platform/mac/svg/custom/text-clip-expected.txt:
  • platform/mac/svg/custom/visibility-override-clip-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-2-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feMerge-expected.txt:
  • platform/mac/svg/filters/feOffset-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filter-source-position-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/filters/shadow-on-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt:
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt:
  • svg/custom/use-clipped-transform-expected.txt:
Note: See TracTimeline for information about the timeline view.