Timeline


and

01/04/10:

23:54 Changeset [52787] by darin@chromium.org

2010-01-04 Darin Fisher <darin@chromium.org>

Fix Chromium build bustage.

  • src/WebAnimationControllerImpl.h:
23:46 Changeset [52786] by cfleizach@apple.com

Add ARIA "Live Region" support
https://bugs.webkit.org/show_bug.cgi?id=33117

Reviewed by Darin Adler.

WebCore:

Tests: platform/mac/accessibility/aria-liveregions-attributes.html

platform/mac/accessibility/aria-liveregions-notifications.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::contentChanged):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isChildOfARIALiveRegion):
(WebCore::AccessibilityObject::supportsARIALiveRegion):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::contentChanged):
(WebCore::AccessibilityObject::ariaLiveRegionStatus):
(WebCore::AccessibilityObject::ariaLiveRegionRelevant):
(WebCore::AccessibilityObject::ariaLiveRegionAtomic):
(WebCore::AccessibilityObject::ariaLiveRegionBusy):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::elementAttributeValue):
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
(WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant):
(WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic):
(WebCore::AccessibilityRenderObject::ariaLiveRegionBusy):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::areChildrenDirty):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/mac/AccessibilityObjectWrapper.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • html/HTMLAttributeNames.in:
  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(indexOfChildCallback):
(boolAttributeValueCallback):
(stringAttributeValueCallback):
(addNotificationListenerCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::addNotificationListener):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::addNotificationListener):

LayoutTests:

  • accessibility/aria-activedescendant-crash.html:
  • platform/mac/accessibility/aria-liveregions-attributes-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregions-attributes.html: Added.
  • platform/mac/accessibility/aria-liveregions-notifications-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregions-notifications.html: Added.
  • platform/mac/accessibility/aria-menu-role-descriptions.html:
  • platform/mac/accessibility/slider-supports-actions.html:
21:33 Changeset [52785] by eric@webkit.org

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool rollout should require a reason
https://bugs.webkit.org/show_bug.cgi?id=30810

  • Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
  • Scripts/webkitpy/changelogs_unittest.py: Test reason support.
  • Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
  • Scripts/webkitpy/commands/download_unittest.py: pass required reason
  • Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert
21:19 Changeset [52784] by abarth@webkit.org

2010-01-04 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Test for https://bugs.webkit.org/show_bug.cgi?id=29820
Adopt a more conservative approach for loading CSS cross-origin.

  • http/tests/security/cross-origin-css.html: Added.
  • http/tests/security/cross-origin-css-expected.txt: Added.
  • http/tests/security/cross-origin-css-in-xml.xml: Added.
  • http/tests/security/cross-origin-css-in-xml-expected.txt: Added.
  • http/tests/security/resources/xorigincss1.css: Added.
  • http/tests/security/resources/xorigincss2.css: Added.
  • http/tests/security/resources/xorigincss1.html: Added.
  • http/tests/security/resources/xorigincss2.html: Added.
  • http/tests/security/resources/xorigincss3.html: Added.
  • http/tests/security/resources/xorigincss4.html: Added.
  • http/tests/security/resources/xorigincss5.html: Added.
  • http/tests/security/resources/xorigincss6.html: Added.

2010-01-04 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Adopt a more conservative approach for loading CSS cross-origin. When
loading CSS cross-origin, it must be start with valid CSS if the MIME
type is broken.

https://bugs.webkit.org/show_bug.cgi?id=29820

Test: http/tests/security/cross-origin-css.html
Test: http/tests/security/cross-origin-css-in-xml.xml

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet): Enforce stricter load requirements for cross-origin loads.
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet): Enforce stricter load requirements for cross-origin loads.
  • css/CSSStyleSheet.h:
  • css/CSSStyleSheet.cpp:
  • css/CSSParser.cpp:
  • css/CSSGrammar.y:
  • css/CSSParser.h: Add ability to tell whether the CSS parse started with a syntactically valid CSS rule.
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText): Add ability to return whether the MIME type was acceptable for CSS. (WebCore::CachedCSSStyleSheet::canUseSheet): If requested, return whether the MIME type was valid or not.
  • dom/ProcessingInstruction.cpp (WebCore::ProcessingInstruction::setCSSStyleSheet): Make use of strict mode explicit and add comment.
20:45 Changeset [52783] by mitz@apple.com

<rdar://problem/6655695> REGRESSION: VoiceOver is not highlighting some web elements correctly
<rdar://problem/7397558> REGRESSION: AXImages inside of AXLink cause AXLink to have wrong bounds

Reviewed by Simon Fraser.

WebCore:

Test: accessibility/dimensions-include-descendants.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect): Use absoluteFocusRingQuads()
for non-text renderers. The focus ring encompasses descendants, which is
what we want for the accessibility indicator.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::absoluteFocusRingQuads): Added.

  • rendering/RenderObject.h:

LayoutTests:

  • accessibility/dimensions-include-descendants-expected.txt: Added.
  • accessibility/dimensions-include-descendants.html: Added.
19:53 Changeset [52782] by ojan@chromium.org

2010-01-04 Ojan Vafai <ojan@ojanmacpro.sfo.corp.google.com>

Reviewed by Dan Bernstein.

Remove unnecessary division by a constant in SimpleFontDataMac.mm.
https://bugs.webkit.org/show_bug.cgi?id=33189

This was added in http://trac.webkit.org/changeset/8104 and seems like
it was just there to match the previously private function which we no
longer use.

No new tests. No change in behavior.

  • platform/graphics/mac/SimpleFontDataMac.mm:
19:40 Changeset [52781] by jhoneycutt@apple.com

MSAA: Accessibility role of <select> elements is wrong

https://bugs.webkit.org/show_bug.cgi?id=33192

Reviewed by Sam Weinig.

WebKit/win:

  • AccessibleBase.cpp:

(MSAARole):
Map WebCore::PopUpButtonRole to MSAA's ROLE_SYSTEM_COMBOBOX.

LayoutTests:

  • platform/win/accessibility/select-element-role-expected.txt: Added.
  • platform/win/accessibility/select-element-role.html: Added.
17:43 Changeset [52780] by kov@webkit.org

Make distcheck build fixes.

17:38 Changeset [52779] by jhoneycutt@apple.com

Qt build fix. Unreviewed.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

17:35 Changeset [52778] by darin@apple.com

Selection-related code needs stricter rules about how it relates to layout
https://bugs.webkit.org/show_bug.cgi?id=32882

Reviewed by Maciej Stachowiak.

Covered by existing tests along with the new assertions.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle): Make sure that m_inStyleRecalc is
already false by the time post-attach callbacks are done so that
layout triggered inside those callbacks can work properly.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::layout): Added code to trigger a
layout when it's needed.
(WebCore::SelectionController::recomputeCaretRect): Removed unneeded
code to do nothing when FrameView is 0. Added an assertion that layout
is not needed at the time the function is called.
(WebCore::SelectionController::invalidateCaretRect): Added code to
trigger a layout when it's needed.
(WebCore::SelectionController::paintCaret): Added an assertion that
layout is not needed at the time the function is called.

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus): Added. Helper function that expresses
the rule for which form control elements should auto-focus.
(WebCore::focusPostAttach): Added. Called post-attach to focus an
element if we discover it should be focused during attach.
(WebCore::HTMLFormControlElement::attach): Refactored code for
which elements need auto-focus into a separate function. Instead
of focusing right away, use the focusPostAttach function to focus
after attach is done. Also added calls to suspendPostAttachCallbacks
and resumePostAttachCallbacks so post-attach callbacks happen late
enough. Before, they could run inside the base attach function.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::attach): Added calls to
suspendPostAttachCallbacks and resumePostAttachCallbacks so
post-attach callbacks happen late enough

  • page/Frame.cpp:

(WebCore::Frame::revealSelection): Added code to trigger a layout
when it's needed.

17:32 Changeset [52777] by barraclough@apple.com

erk, demangle the ChangeLog!

17:24 Changeset [52776] by barraclough@apple.com

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Add string hashing functions to WTF.
Use WTF's string hashing functions from UStringImpl.

Reviewed by Sam Weinig, additional coding by Mark Rowe.

(JSC::UStringImpl::computeHash):

  • wtf/HashFunctions.h:
  • wtf/StringHashFunctions.h: Added.

(WTF::stringHash):

JavaScriptGlue: Add a forwarding header so that StringHashFunctions.h can be found.

Reviewed by Sam Weinig.

  • ForwardingHeaders/wtf/StringHashFunctions.h: Added.

WebCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Use WTF's string hashing functions from StringImpl.

Patch by Mark Rowe <mrowe@apple.com> on 2010-01-04
Reviewed by Sam Weinig.

  • ForwardingHeaders/wtf/StringHashFunctions.h: Added.
  • platform/text/StringHash.h:
  • platform/text/StringImpl.h:

(WebCore::StringImpl::computeHash):

17:21 Changeset [52775] by eric@webkit.org

2010-01-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

Adding WebAnimationController to chromium's WebKit API.

https://bugs.webkit.org/show_bug.cgi?id=32870

  • WebKit.gyp:
  • public/WebAnimationController.h: Added. (WebKit::WebAnimationController::~WebAnimationController):
  • public/WebFrame.h:
  • src/WebAnimationControllerImpl.cpp: Added. (WebKit::WebAnimationControllerImpl::WebAnimationControllerImpl): (WebKit::WebAnimationControllerImpl::pauseAnimationAtTime): (WebKit::WebAnimationControllerImpl::pauseTransitionAtTime): (WebKit::WebAnimationControllerImpl::numberOfActiveAnimations):
  • src/WebAnimationControllerImpl.h: Added. (WebKit::WebAnimationControllerImpl::~WebAnimationControllerImpl):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::animationController): (WebKit::WebFrameImpl::WebFrameImpl):
  • src/WebFrameImpl.h:
17:12 Changeset [52774] by eric@webkit.org

2010-01-04 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher

Adding more DOM API methods. They are needed for the upcoming
translate feature.

  • public/WebElement.h:
  • public/WebNode.h:
  • src/WebElement.cpp: (WebKit::WebElement::tagName): (WebKit::WebElement::setAttribute):
  • src/WebNode.cpp: (WebKit::WebNode::setNodeValue):
17:12 Changeset [52773] by jhoneycutt@apple.com

MSAA: <select> elements should broadcast value change events

https://bugs.webkit.org/show_bug.cgi?id=33088

<rdar://problem/7332364>

Reviewed by Darin Adler.

WebCore:

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::postNotification):
If the post type is async, follow the old code path; otherwise, call
postPlatformNotification().

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):
Added a new accessibility notification, AXMenuListValueChanged. Added
a new parameter to postNotification() to specify whether the post should
be synchronous or asynchronous.

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
If the WebCore notification is AXMenuListValueChanged, broadcast an
EVENT_OBJECT_VALUECHANGE event.

  • dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):
When the selected index of a RenderMenuList is changed, call
RenderMenuList::didSetSelectedIndex().

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
Initialize new member
(WebCore::RenderMenuList::didSetSelectedIndex):
If the selected index has changed, post AXMenuListValueChanged to the
object synchronously.

  • rendering/RenderMenuList.h:

Declare didSetSelectedIndex(), and add a member to hold the last
selected index.

WebKitTools:

  • DumpRenderTree/AccessibilityController.cpp:

(logValueChangeEventsCallback):
Start logging value change events.
(AccessibilityController::getJSClass):
Add a "logValueChangeEvents" to the AccessibilityController's JS class
definition.
(AccessibilityController::resetToConsistentState):
Disable logging of value change events.

  • DumpRenderTree/AccessibilityController.h:

Declare setLogValueChangeEvents(), and add a member variable for the
value change event hook.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::setLogValueChangeEvents):
Stubbed.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::setLogValueChangeEvents):
Stubbed.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize new member var.
(AccessibilityController::~AccessibilityController):
Disable logging of value change events.
(logEventProc):
When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
and its value.
(AccessibilityController::setLogValueChangeEvents):
If disabling logging, unhook the event, and clear the event hook
member var. Otherwise, query for the root element to enable
accessibility, and hook EVENT_OBJECT_VALUECHANGE.

LayoutTests:

  • platform/win/accessibility/select-element-valuechange-event-expected.txt: Added.
  • platform/win/accessibility/select-element-valuechange-event.html: Added.
17:07 Changeset [52772] by darin@apple.com

WebCore: Added missing null check in BarInfo code.

Reviewed by Sam Weinig.

Test: fast/dom/Window/BarInfo-after-frame-removed.html

  • page/BarInfo.cpp:

(WebCore::BarInfo::visible): Added null check. A few other
cleanups.

LayoutTests: Added test for use of BarInfo object after a frame is no longer
associated with a web page.

Reviewed by Sam Weinig.

  • fast/dom/Window/BarInfo-after-frame-removed-expected.txt: Added.
  • fast/dom/Window/BarInfo-after-frame-removed.html: Added.
17:04 Changeset [52771] by eric@webkit.org

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

long_help for submit-patch
https://bugs.webkit.org/show_bug.cgi?id=33184

  • Scripts/webkitpy/commands/upload.py:
16:54 Changeset [52770] by mrowe@apple.com

Rubber-stamped by Jon Honeycutt.

Delete an empty and unused JavaScript file.

  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/InspectorControllerStub.js: Removed.
16:27 Changeset [52769] by kevino@webkit.org

[wx] Build fix, add a couple include dirs to the build.

16:13 Changeset [52768] by mrowe@apple.com

Roll out r52758 as it accidentally the whole build.

15:50 Changeset [52767] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33181
The first letter is not removed properly from inline input hole

  • WebView.cpp: (WebView::onIMEEndComposition): If composition is ended before it was confirmed, cancel it.
15:48 Changeset [52766] by bweinstein@apple.com

Part of a build fix for Windows, this at least gets WTF to build.

15:18 Changeset [52765] by barraclough@apple.com
  • wtf/unicode/Unicode.h:

Reviewed by NOBODY (more speculative build fix).

15:13 Changeset [52764] by abarth@webkit.org

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue can wrongly reject patches if the buildbots are behind
https://bugs.webkit.org/show_bug.cgi?id=30098

Check to make sure we can currently build and test before trying to
land a patch.

  • Scripts/webkitpy/commands/queues.py:
15:05 Changeset [52763] by dimich@chromium.org

Not reviewed, attempt to fix ARM bulid.

  • wtf/Platform.h:
14:49 Changeset [52762] by barraclough@apple.com

Rubber stamped by Geoff Garen.

Add an 'isIdentifier' to UStringImpl, use this where appropriate
(where previously 'identifierTable' was being tested).

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

  • runtime/Identifier.cpp:

(JSC::Identifier::addSlowCase):

  • runtime/Identifier.h:

(JSC::Identifier::add):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::isIdentifier):

14:42 Changeset [52761] by barraclough@apple.com
  • wtf/HashFunctions.h:

Reviewed by NOBODY build fix for DRT, fix incorrect style include.

14:30 Changeset [52760] by barraclough@apple.com

Reviewed by NOBODY Windows build fix.

14:09 Changeset [52759] by mitz@apple.com

Windows build fix

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

14:00 Changeset [52758] by barraclough@apple.com

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Add string hashing functions to WTF.
Use WTF's string hashing functions from UStringImpl.

Reviewed by Sam Weinig.

(JSC::UStringImpl::computeHash):

  • wtf/HashFunctions.h:

(WTF::stringHash):

WebCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Use WTF's string hashing functions from StringImpl.

Reviewed by Sam Weinig.

  • platform/text/StringImpl.h:

(WebCore::StringImpl::computeHash):

13:50 Changeset [52757] by simon.fraser@apple.com

2010-01-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Repaint issues in text input under a scale transform
https://bugs.webkit.org/show_bug.cgi?id=32086

When doing a subtree layout we have to look up the container chain to see if there
are any properties, such as transforms or reflections, that mean that we are unable
to use layoutState.

Test: fast/repaint/subtree-layoutstate-transform.html

  • page/FrameView.cpp: (WebCore::FrameView::layout): Call canUseLayoutStateForSubtree() to determine whether it's OK to use layoutState.
  • rendering/RenderView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::canUseLayoutStateForSubtree): New method that reports whether it's OK to use layoutState when doing a subtree layout from the given root.
13:49 Changeset [52756] by darin@apple.com

WebCore: Reentrancy problem with selection in some edge cases.
https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974

Reviewed by Dan Bernstein.

Test: fast/forms/selection-layout-reentry-strange-case.html

Move the selection display update process done in the
selectionLayoutChanged function into the layout timer
instead of doing it immediately when selection changes occur.

  • dom/Document.cpp:

(WebCore::Document::updateLayout): Changed this to use the
definition of needsLayout from FrameView rather than rolling
its own.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::SelectionController):
Initialize m_needsDisplayUpdate to false.
(WebCore::SelectionController::setSelection): Call
the new setNeedsDisplayUpdate function instead of the old
badly named Frame::selectionLayoutChanged function.
(WebCore::SelectionController::setNeedsDisplayUpdate):
Set m_needsDisplayUpdate. If it is just becoming true, then
call FrameView::scheduleRelayout.

  • editing/SelectionController.h: Added setNeedsDisplayUpdate,

needsDisplayUpdate, and m_needsDisplayUpdate.

  • page/Frame.cpp:

(WebCore::Frame::setCaretVisible): Call setNeedsDisplayUpdate.
(WebCore::Frame::selectionLayoutChanged): Call
setNeedsDisplayUpdate to set it to false, since this is the
function that performs "selection display update". Later I want
to rename this function. Also added a global reentrancy check
since that's the easiest way I could think of to prevent infinite
recursion in the case where recomputeCaretRect ends up triggering
a layout. As a side effect, fixed theoretical problems in
TEXT_CARET builds by improving the ifdef.
(WebCore::Frame::caretBlinkTimerFired): Loosen assertions a
bit. Later we might want to decouple caret rect from caret state
a bit more and add these assertions back.
(WebCore::Frame::selectionBounds): Call Document::updateLayout.
This function is for external clients and they do not currently
do anything to make sure layout is up to date.

  • page/FrameView.cpp:

(WebCore::FrameView::needsLayout): Add a new clause, since
we need a call to layout if needsDisplayUpdate is true.

LayoutTests: Reentrancy problem with selection in some edge cases.
https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974

Reviewed by Dan Bernstein.

  • fast/forms/selection-layout-reentry-strange-case-expected.txt: Added.
  • fast/forms/selection-layout-reentry-strange-case.html: Added.
  • platform/mac/accessibility/frame-with-title-expected.txt: Updated since

the number of layouts is now different.

13:30 Changeset [52755] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33161
Assertion failure in WebView when using Chinese Simplified IME

  • WebView.cpp: (WebView::onIMERequestCharPosition): Changed the assertion into release mode check. We can't make assertions about arguments passed from outside WebKit.
13:27 Changeset [52754] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33157
Implement TextInput logging channel on Windows

  • WebKitLogging.cpp: (WebKitInitializeLoggingChannelsIfNecessary):
  • WebKitLogging.h: Added a TextInput channel in place of unused Network one.
  • WebView.cpp: (WebView::WebViewWndProc): Changed onIMERequest to return result directly. We never forward it to DefWindowProc, so there is no need to return an unused boolean result for "handled". (WebView::onIMEStartComposition): Added logging. (imeCompositionArgumentNames): A helper function for detailed logging in onIMEComposition. (imeNotificationName): A helper function for detailed logging in onIMENotify. (imeRequestName): A helper function for detailed logging in onIMERequest. (WebView::onIMEComposition): Added logging. (WebView::onIMEEndComposition): Ditto. (WebView::onIMEChar): Ditto. (WebView::onIMENotify): Ditto. (WebView::onIMERequestCharPosition): Changed to return result directly. (WebView::onIMERequestReconvertString): Ditto. (WebView::onIMERequest): Changed to return result directly. Added logging. (WebView::onIMESelect): Added logging. (WebView::onIMESetContext): Added logging.
  • WebView.h: onIMERequest functions now return result directly.
13:19 Changeset [52753] by aroben@apple.com

Add a test harness for the Windows WebKit API, and a few tests

We currently only have tests for a handful of bugs regarding WebView
destruction, but more tests can easily be added later. Eventually
we'll run these tests as part of run-webkit-tests.

Fixes <http://webkit.org/b/33167>.

Reviewed by Sam Weinig.

WebKit/win:

  • WebKit.vcproj/WebKit.sln: Added WebKitAPITest.vcproj. It builds just

after DumpRenderTree.vcproj.

WebKitTools:

  • WebKitAPITest/HostWindow.cpp: Added.

(WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
(WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
needed.
(WebKitAPITest::HostWindow::initialize): Create our window.
(WebKitAPITest::HostWindow::clientRect): Return our window's client
rect.
(WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
(WebKitAPITest::HostWindow::wndProc): Just call through to
DefWindowProcW.

  • WebKitAPITest/HostWindow.h: Added.

(WebKitAPITest::HostWindow::window): Simple getter.

  • WebKitAPITest/Test.h: Added. This file defines some macros useful

for writing tests.

  • WebKitAPITest/TestsController.cpp: Added.

(WebKitAPITest::TestsController::TestsController): Initialize our
members.
(WebKitAPITest::TestsController::shared): Return the shared instance.
(WebKitAPITest::TestsController::runAllTests): Run a message pump
until a WM_QUIT message is received, then return whether all tests
succeeded.
(WebKitAPITest::TestsController::addTest): Add the test to m_tests and
start running tests soon.
(WebKitAPITest::TestsController::testFailed): Record the failure and
print a message about it to stdout.
(WebKitAPITest::TestsController::runNextTest): If we don't have any
tests to run, post a WM_QUIT message to stop the message pump.
Otherwise, run the test and print whether it passed, then schedule the
next test.
(WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
to run the next test.
(WebKitAPITest::TestsController::registerWindowClass): Does what it
says.
(WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
fired, call runNextTest(). Pass everything else through to
DefWindowProcW.

  • WebKitAPITest/TestsController.h: Added.
  • WebKitAPITest/WebKitAPITest.vcproj: Added.
  • WebKitAPITest/WebKitAPITestCommon.vsprops: Added.
  • WebKitAPITest/main.cpp: Added.

(main): (Mostly) just calls TestsController::runAllTests.

  • WebKitAPITest/tests/WebViewDestruction.cpp: Added.

(WebKitAPITest::WebKitCreateInstance): Helper function template to
call through to the real WebKitCreateInstance.
(WebKitAPITest::webViewCount): Helper function to call through to
IWebKitStatistics::webViewCount.
(WebKitAPITest::createWebView): Helper function to create a WebView
and put it inside a HostWindow.
(WebKitAPITest::runMessagePump): Helper function to run a message pump
for a specified number of milliseconds, or until a WM_QUIT message is
received.
(WebKitAPITest::CloseWithoutDestroyWindow): Test for
<http://webkit.org/b/32827>.
(WebKitAPITest::MainFrameAfterClose): Test for
<http://webkit.org/b/32868>.
(WebKitAPITest::NoCloseOrDestroyWindow): Test for
<http://webkit.org/b/33162>.

12:28 Changeset [52752] by bfulgham@webkit.org

Correct debug assertion (and possible runtime errors) by
checking validity of bitmap settings used to create
the Windows Cairo contexts.
https://bugs.webkit.org/show_bug.cgi?id=33164.

Reviewed by Adam Roben.

  • platform/graphics/win/GraphicsContextCairoWin.cpp:

(WebCore::createCairoContextWithHDC): Check validity of selected

OBJ_BITMAP retrieved, and only create 32-bit context when
a valid bitmap is provided.

12:12 BuildingQtOnWindows edited by dbates@webkit.org
--makeargs=j4 should be --makeargs=-j4 (note the dash that precedes the … (diff)
11:18 Changeset [52751] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=33158
Refactor JSC API entry/exit to use RAII instead of copy/pasting code.
Make it easier to change set of actions taken when passing across the API boundary.

Reviewed by Sam "Shimmey Shimmey" Weinig.

  • API/APIShims.h: Added.

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):
(JSGarbageCollect):
(JSReportExtraMemoryCost):

  • API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

  • API/JSCallbackObjectFunctions.h:

(JSC::::init):
(JSC::::getOwnPropertySlot):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::hasInstance):
(JSC::::call):
(JSC::::getOwnPropertyNames):
(JSC::::toNumber):
(JSC::::toString):
(JSC::::staticValueGetter):
(JSC::::callbackGetter):

  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:

(JSObjectMake):
(JSObjectMakeFunctionWithCallback):
(JSObjectMakeConstructor):
(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetPrototype):
(JSObjectSetPrototype):
(JSObjectHasProperty):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):
(JSObjectCopyPropertyNames):
(JSPropertyNameArrayRelease):
(JSPropertyNameAccumulatorAddName):

  • API/JSValueRef.cpp:

(JSValueGetType):
(JSValueIsUndefined):
(JSValueIsNull):
(JSValueIsBoolean):
(JSValueIsNumber):
(JSValueIsString):
(JSValueIsObject):
(JSValueIsObjectOfClass):
(JSValueIsEqual):
(JSValueIsStrictEqual):
(JSValueIsInstanceOfConstructor):
(JSValueMakeUndefined):
(JSValueMakeNull):
(JSValueMakeBoolean):
(JSValueMakeNumber):
(JSValueMakeString):
(JSValueToBoolean):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
(JSValueProtect):
(JSValueUnprotect):

11:06 Changeset [52750] by dimich@chromium.org

Not reviewed, revert r52745 and r52746 on behalf of Nikolas Zimmermann, as discussed on IRC.
Patch produced by 'git revert' and then reverting back ChangeLog files.

10:55 Changeset [52749] by mitz@apple.com

Updated copyright string

Reviewed by Ada Chan and Mark Rowe.

JavaScriptCore:

JavaScriptGlue:

  • Info.plist:

WebCore:

  • Info.plist:
  • WebCore.vcproj/QTMovieWin.rc:

WebKit/mac:

  • Info.plist:

WebKit/win:

  • WebKit.vcproj/WebKit.rc:
10:54 Changeset [52748] by cfleizach@apple.com

AX: any DIV with an aria role should not be ignored
https://bugs.webkit.org/show_bug.cgi?id=33090

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-divs-not-ignored.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

  • platform/mac/accessibility/aria-divs-not-ignored-expected.txt: Added.
  • platform/mac/accessibility/aria-divs-not-ignored.html: Added.
10:46 Changeset [52747] by japhet@chromium.org

2010-01-04 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Generate declarations for V8 runtime enablers.

https://bugs.webkit.org/show_bug.cgi?id=33156

  • bindings/scripts/CodeGeneratorV8.pm: Generate runtime enabler declarations.
  • bindings/v8/custom/V8CustomBinding.h: Remove manual declarations of runtime enablers.
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp: Remove closeCallback(), which isn't actually being used.
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
09:46 Changeset [52746] by zimmermann@webkit.org

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Forgot to add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to Chromium build.

  • WebCore.gypi:
09:31 Changeset [52745] by zimmermann@webkit.org

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Marker code is buggy: referencePoint translation is off
https://bugs.webkit.org/show_bug.cgi?id=33012

Rewrite marker code, as it had many issues:

  • Correct refX/refY handling (covered by new marker-referencePoint.svg test)
  • Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
  • Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
  • Fix SVGResource assuming that there is only one resource per resource type per element. Markers can have three different resources of the same type (three markers, start/mid/end markers)

Filed bug 33115 (PathElementAddQuadCurveToPoint not handled for <marker>), which was just a TODO in the code before.

Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
Test: svg/custom/marker-referencePoint.svg

svg/custom/marker-opacity.svg

  • Android.mk: Add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to build.
  • GNUmakefile.am: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/FrameView.cpp: Notify RenderSVGRoot children about viewport size changes, just like it's handled for <body> in HTML. (WebCore::FrameView::layout): This is important, as marker bounding boxes may depend on the current viewport size through relative coordinates used in <svg>.
  • rendering/RenderPath.cpp: (WebCore::RenderPath::markerBoundingBox): Calculates and caches marker boundaries in the layout() phase. (WebCore::RenderPath::repaintRectInLocalCoordinates): Use the cached marker bounding box during paint() time. (WebCore::RenderPath::setPath): Clear marker boundaries upon path changes. (WebCore::RenderPath::paint): Use SVGMarkerLayoutInfo::drawMarkers() instead of the local drawMarkersIfNeeded() function, which is gone now. (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Utilized by markerBoundingBox() to request SVGResourceMarker objects and calculate their boundaries.
  • rendering/RenderPath.h: Store SVGMarkerLayoutInfo objects, and rename m_markerBounds to m_cachedLocalMarkerBBox for consistency. (WebCore::RenderPath::path): Inline this accessor.
  • rendering/RenderSVGContainer.h: Make paint() public (to be used from SVGResourceMarker), all other methods protected (to be used from RenderSVGViewportContainer).
  • rendering/RenderSVGViewportContainer.cpp: Remove useless paint() override, as the comment in the code indicated. (WebCore::RenderSVGViewportContainer::markerBoundaries): Maps the marker contents repaintRectInLocalCoordinates() into the final coordinate system (see code). (WebCore::RenderSVGViewportContainer::markerContentTransformation): Add marker-specific helper method, allowing to make viewportTransform() private again.
  • rendering/RenderSVGViewportContainer.h: Marking viewportTransform() private, it's never meant to be used outside this renderer.
  • rendering/SVGMarkerData.h: Added. Refactored from existing RenderPath code, preserving original copyrights. (WebCore::SVGMarkerData::): Helper struct for SVGMarkerLayoutInfo. (WebCore::SVGMarkerData::origin): Holds the final computed destination of a marker. (WebCore::SVGMarkerData::marker): Holds a pointer to the associated SVGResourceMarker object, which we're aiming to layout. (WebCore::SVGMarkerData::currentAngle): Calculates the current angle for a certain marker type (start/mid/end) based upon the computed inslope/outslope values. (WebCore::SVGMarkerData::updateTypeAndMarker): Helper method. (WebCore::SVGMarkerData::updateOutslope): Ditto. (WebCore::SVGMarkerData::updateMarkerDataForPathElement): Does the actual inslope/outslope calculation. (WebCore::SVGMarkerData::updateInslope): Helper method.
  • rendering/SVGMarkerLayoutInfo.cpp: Added. New approach to build marker layout info, this time correct during layout() time instead of paint() time. (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo): (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo): (WebCore::processStartAndMidMarkers): Static helper method used to visit each path element in order to calculate inslopes/outslopes (-> orientation angles) (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): Build list of MarkerLayout objects, used to query boundaries, and to paint markers during drawMarkers(). (WebCore::SVGMarkerLayoutInfo::drawMarkers): Cheap method walking existing MarkerLayout vector, drawing the individual RenderSVGViewportContainer of the markers. (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker): Helper method.
  • rendering/SVGMarkerLayoutInfo.h: Added. (WebCore::MarkerLayout::MarkerLayout): Helper struct storing a pair of SVGResourceMarker* and a TranformationMatrix. (WebCore::SVGMarkerLayoutInfo::markerData): Public helper methods returning references to private member variables, used from processStartAndMidMarkers. (WebCore::SVGMarkerLayoutInfo::midMarker): Ditto. (WebCore::SVGMarkerLayoutInfo::elementIndex): Ditto.
  • svg/SVGMarkerElement.cpp: Adopt to name change: setRef() -> setReferencePoint(). setMarker() -> setRenderer() (WebCore::SVGMarkerElement::canvasResource): Add ASSERT(renderer()) to clarify that canvasResource() is only meant to used after renderer creation.
  • svg/graphics/SVGResource.cpp: Instead of maintaining a global hashmap between SVGStyledElements and an array of possible SVGResources, use a HashSet of SVGResources

and directly scan the already existing list of clients for a certain SVGResource. This wrong approach has been introduced over two years
ago, making the assumption that there's only one resource type per element. Though markers can provide three resources of the same type
per element (all SVGResourceMarker objects, but in different rules: start/mid/end marker). That information is only available while painting.

(WebCore::resourceSet): Add global static HashSet<SVGResource*>.
(WebCore::SVGResource::SVGResource): Add us to the resourceSet.
(WebCore::SVGResource::~SVGResource): Remove us from resourceSet.
(WebCore::SVGResource::removeClient): Traverse all SVGResource clients and remove the passed SVGStyledElement from the client list (invoked by SVGStyledElement destructor).
(WebCore::SVGResource::addClient): Remove the offending part of the old approach, making the wrong assumption regarding resource types.

  • svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::markerTransformation): Create TransformationMatrix in the local marker content (RenderSVGViewportContainer) coordinate system, to position a marker. (WebCore::SVGResourceMarker::draw): Simplify marker drawing a lot: used the passing TransformationMatrix (cached in SVGMarkerLayoutInfo) to draw the marker content renderer. (WebCore::SVGResourceMarker::externalRepresentation): Adopt to refX/refY -> referencePoint changes.
  • svg/graphics/SVGResourceMarker.h: Store a FloatPoint m_referecePoint instead of two refX/refY float values. (WebCore::SVGResourceMarker::setRenderer): Renamed from setMarker(). (WebCore::SVGResourceMarker::setReferencePoint): Renamed from setRef(). (WebCore::SVGResourceMarker::referencePoint): New accessor replacing refX() / refY().
09:29 Changeset [52744] by aroben@apple.com

2010-01-04 Adam Roben <aroben@apple.com>

No review, rolling out r52741.
http://trac.webkit.org/changeset/52741
https://bugs.webkit.org/show_bug.cgi?id=33056

  • wtf/AlwaysInline.h:
09:20 Changeset [52743] by eric@webkit.org

2010-01-04 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Add cacheFlush support for WinCE
https://bugs.webkit.org/show_bug.cgi?id=33110

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
09:09 Changeset [52742] by zimmermann@webkit.org

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix typo in test name.

  • platform/win/Skipped:
09:06 Changeset [52741] by eric@webkit.org

2010-01-04 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

Implement NO_RETURN for COMPILER(MSVC).
https://bugs.webkit.org/show_bug.cgi?id=33056

  • wtf/AlwaysInline.h:
08:50 Changeset [52740] by zimmermann@webkit.org

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update two win-specific test results, that showed up on the Windows Release/Debug slave.
Skip fast/frames/iframe-onload-remove-self-no-crash.html as it crashes the debug slave, filed bug.

All bots except SnowLeopard Leaks & GTK Linux Debug (32-bit) should turn to green now!

  • platform/win/editing/selection/select-text-overflow-ellipsis-expected.txt:
  • platform/win/fast/forms/basic-selects-expected.txt: Added.
  • platform/win/Skipped:
08:12 Changeset [52739] by vestbo@webkit.org

Add support for Git's "diff.mnemonicprefix" config option to WebKitTools

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=32820

  • Scripts/VCSUtils.pm:
  • Scripts/svn-apply:
  • Scripts/svn-unapply:
  • Scripts/test-webkitperl: Run gitdiff2svndiff test
  • Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
  • Scripts/webkitpy/diff_parser.py:
  • Scripts/webkitpy/diff_parser_unittest.py:
08:01 Changeset [52738] by zimmermann@webkit.org

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Bring back Tiger bot to green: svg/custom/use-on-symbol-inside-pattern.svg exposes a bug on both Tiger & Win.
Reopened bug 17393 and skipping this test for now, as it requires a larger rework of Path::debugString().

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
07:54 Changeset [52737] by zimmermann@webkit.org

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to mark all Gtk bots green again, as discussed with Gustavo Noronha Silva.

  • platform/gtk/Skipped:
07:48 Changeset [52736] by zimmermann@webkit.org

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skipping plugins/get-url-with-iframe-target.html, filed bug 33154, cc'ing the original author.

  • platform/mac-tiger/Skipped:
07:42 Changeset [52735] by zimmermann@webkit.org

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skipping http/tests/navigation/*iframe* on Tiger, just like it has been done for win.

  • platform/mac-tiger/Skipped:
07:37 Changeset [52734] by hausmann@webkit.org

[Qt] Fix standalone package builds.

Reviewed by Tor Arne Vestbø.

.:

  • WebKit.pri: Add logic for detecting standalone builds. Set OUTPUT_DIR to the top-level dir in that case.
  • WebKit.pro: Don't build JSC and DRT for package builds.

WebCore:

  • WebCore.pro: Moved logic for detecting standalone builds to WebKit.pri. Set DESTDIR for package builds.
07:33 Changeset [52733] by eric@webkit.org

2010-01-04 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Laszlo Gombos.

https://bugs.webkit.org/show_bug.cgi?id=29048
[Qt] make RenderStyle.h compile in winscw compiler.

Change compareEqual to a macro in Winscw compiler to get around "illegal operand"
error when compareEqual is defined as template.

The compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=10447

  • rendering/style/RenderStyle.h:
06:59 Changeset [52732] by ddkilzer@apple.com

Divided the Perl unit tests into separate files and put
them in a separate directory, and renamed test-webkit-perl
to test-webkitperl.

Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-04
Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=33124

  • Scripts/VCSUtils.pm:
    • Renamed generateRunPatchCommand() to generatePatchCommand().
  • Scripts/VCSUtils_unittest.pl: Removed.
    • Divided into three files in Scripts/webkitperl/VCSUtils_unittest.
  • Scripts/test-webkit-perl: Removed.
    • Renamed to test-webkitperl.
  • Scripts/test-webkit-scripts:
    • Updated paths to test-webkitpy and test-webkitperl.
  • Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
    • Added paths to new test files.
  • Scripts/webkitperl: Added.
  • Scripts/webkitperl/VCSUtils_unittest: Added.
  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.
05:18 Changeset [52731] by mjs@apple.com

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Simon Hausmann.

Fix some PLATFORM(*_ENDIAN) uses to CPU()
https://bugs.webkit.org/show_bug.cgi?id=33148

  • runtime/JSCell.cpp: (JSC::):
  • runtime/JSValue.h: (JSC::JSValue::):

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Simon Hausmann.

Fix some PLATFORM(*_ENDIAN) uses to CPU()
https://bugs.webkit.org/show_bug.cgi?id=33148

  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::readCurrentPixel):
04:01 Changeset [52730] by mjs@apple.com

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Document CPU() macros in comments.
https://bugs.webkit.org/show_bug.cgi?id=33147

  • wtf/Platform.h:
03:59 Porting Macros plan edited by mjs@apple.com
(diff)
03:38 Changeset [52729] by mjs@apple.com

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Reorganize, document and rename CPU() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33145
ExecutableAllocatorSymbian appears to have buggy ARM version check
https://bugs.webkit.org/show_bug.cgi?id=33138


  • wtf/Platform.h: Rename all macros related to detection of particular CPUs or classes of CPUs to CPU(), reorganize and document them.

All remaining changes are adapting to the renames, plus fixing the
second bug cited above.


  • assembler/ARMAssembler.cpp:
  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.cpp:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
  • assembler/MacroAssemblerX86.h:
  • assembler/MacroAssemblerX86Common.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/X86Assembler.h: (JSC::X86Registers::): (JSC::X86Assembler::): (JSC::X86Assembler::movl_mEAX): (JSC::X86Assembler::movl_EAXm): (JSC::X86Assembler::repatchLoadPtrToLEA): (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
  • jit/ExecutableAllocator.h:
  • jit/ExecutableAllocatorFixedVMPool.cpp:
  • jit/ExecutableAllocatorPosix.cpp:
  • jit/ExecutableAllocatorSymbian.cpp: (JSC::ExecutableAllocator::intializePageSize):
  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITArithmetic.cpp:
  • jit/JITInlineMethods.h: (JSC::JIT::beginUninterruptedSequence): (JSC::JIT::restoreArgumentReferenceForTrampoline): (JSC::JIT::emitCount):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • jit/JITStubs.h:
  • runtime/Collector.cpp: (JSC::currentThreadStackBase): (JSC::getPlatformThreadRegisters): (JSC::otherThreadStackPointer):
  • wrec/WREC.h:
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateReturnFailure):
  • wrec/WRECGenerator.h:
  • wtf/FastMalloc.cpp:
  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
  • wtf/Threading.h:
  • wtf/dtoa.cpp:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
  • yarr/RegexJIT.h:

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Reorganize, document and rename CPU() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33145

  • webkit/webkitwebsettings.cpp: (webkit_get_user_agent):

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Reorganize, document and rename CPU() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33145

  • page/NavigatorBase.cpp:
  • platform/text/AtomicString.cpp: (WebCore::equal):
  • platform/text/StringHash.h: (WebCore::StringHash::equal):
03:37 Changeset [52728] by eric@webkit.org

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make bugzilla-tool rollout include a bug link in the ChangeLog entry
https://bugs.webkit.org/show_bug.cgi?id=33146

One more step towards better rollouts.

  • Scripts/webkitpy/changelogs.py:
  • Scripts/webkitpy/changelogs_unittest.py:
  • Scripts/webkitpy/steps/preparechangelogforrevert.py:
03:04 Changeset [52727] by philn@webkit.org

2009-12-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GTK] G_OBJECT() cast is not necessary for signals connection and properties access
https://bugs.webkit.org/show_bug.cgi?id=32661

Reverted the SENTINEL / NULL crap :) Hopefully the style-bot won't
complain about NULL usage in g_object_{get,set} anymore.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
03:04 Changeset [52726] by eric@webkit.org

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sort the step options
https://bugs.webkit.org/show_bug.cgi?id=33144

  • Scripts/webkitpy/steps/options.py:
02:57 Changeset [52725] by eric@webkit.org

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Need support for longer text in per-command help
https://bugs.webkit.org/show_bug.cgi?id=33143

Add some minimal additional help to land-diff and
pave the way for adding better help to all commands.

  • Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
  • Scripts/webkitpy/multicommandtool.py: support long_help
  • Scripts/webkitpy/multicommandtool_unittest.py: test long_help
02:46 Changeset [52724] by abarth@webkit.org

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add unit test for MarkBugFixed
https://bugs.webkit.org/show_bug.cgi?id=33142

MarkBugFixed is way behind in command technology, but it still needs a
unit test, as the FIXME commands.

Also, remove mark-bug-fixed and create-bug from main help since we have
more modern commands to replace them.

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
02:24 Changeset [52723] by eric@webkit.org

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add missing unit test for CommitMessageForCurrentDiff
https://bugs.webkit.org/show_bug.cgi?id=33141

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
02:05 Changeset [52722] by ossy@webkit.org

Unreviewed trivial fix.

[Qt] r52694 moved a test, but it isn't renamed in the skiplist.

  • platform/qt/Skipped: animations/transform-origin-vs-functions.html renamed.
01:58 Changeset [52721] by eric@webkit.org

2010-01-04 Alex Milowski <alex@milowski.com>

Reviewed by Eric Seidel.

Added expected outputs for pixel tests that were missing.

  • platform/mac/mathml/presentation/sub-expected.checksum: Added.
  • platform/mac/mathml/presentation/sub-expected.png: Added.
  • platform/mac/mathml/presentation/sup-expected.checksum: Added.
  • platform/mac/mathml/presentation/sup-expected.png: Added.
  • platform/mac/mathml/presentation/tables-expected.checksum: Added.
  • platform/mac/mathml/presentation/tables-expected.png: Added.

2010-01-04 Alex Milowski <alex@milowski.com>

Reviewed by Eric Seidel.

Updated license to match recommended header license.

  • mathml/MathMLElement.cpp:
  • mathml/MathMLElement.h:
  • mathml/MathMLInlineContainerElement.cpp:
  • mathml/MathMLInlineContainerElement.h:
  • mathml/MathMLMathElement.cpp:
  • mathml/MathMLMathElement.h:
01:49 Changeset [52720] by abarth@webkit.org

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add missing unit test for CommitMessageForCurrentDiff
https://bugs.webkit.org/show_bug.cgi?id=33141

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
01:48 Changeset [52719] by abarth@webkit.org

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove raw_input from queues in favor of user.prompt
https://bugs.webkit.org/show_bug.cgi?id=33140

This lets up properly mock out the user interaction instead of hacking
around it with the options.

  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queuestest.py:
01:42 Porting Macros plan edited by mjs@apple.com
(diff)
01:42 Changeset [52718] by eric@webkit.org

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool should not require users to install mechanize
https://bugs.webkit.org/show_bug.cgi?id=32635

  • .gitignore: Ignore autoinstall.cache.d directory created by autoinstall.py

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool should not require users to install mechanize
https://bugs.webkit.org/show_bug.cgi?id=32635

Use the nifty "autoinstall" module from Daniel Krech:
http://pypi.python.org/pypi/autoinstall/0.2
http://code.google.com/p/pyautoinstall/
It's available under a WebKit-compatible BSD license.

  • Scripts/webkitpy/init.py:
    • bind "mechanize" to an autoinstall importer which will auto-download mechanize if necessary.
  • Scripts/webkitpy/autoinstall.py: Added.
  • Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
  • Scripts/webkitpy/statusbot.py: ditto.
  • Scripts/webkitpy/webkit_mechanize.py: Removed.
01:33 Changeset [52717] by abarth@webkit.org

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Move AbstractSequencedCommand to a more general location
https://bugs.webkit.org/show_bug.cgi?id=33137

I do what the FIXME tell me to do.

  • Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
01:30 Changeset [52716] by abarth@webkit.org

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename StatusBot to StatusServer
https://bugs.webkit.org/show_bug.cgi?id=33139

It's not a bot. It's a server.

  • Scripts/bugzilla-tool:
  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/queueengine.py:
  • Scripts/webkitpy/statusbot.py: Removed.
01:05 Changeset [52715] by abarth@webkit.org

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] submit-pach should have a -o/--open option to open the bug after submit
https://bugs.webkit.org/show_bug.cgi?id=33136

Python makes this very easy.

  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/steps/options.py:
  • Scripts/webkitpy/steps/postdiff.py:
  • Scripts/webkitpy/user.py:
00:50 Porting Macros plan edited by mjs@apple.com
(diff)
00:47 Changeset [52714] by abarth@webkit.org

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Move steps to a submodule
https://bugs.webkit.org/show_bug.cgi?id=33135

For great victory. This will probably introduce some regressions
because our test coverage isn't perfect, but I've tried to be careful.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/buildsteps.py: Removed.
  • Scripts/webkitpy/buildsteps_unittest.py: Removed.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/steps/init.py: Added.
  • Scripts/webkitpy/steps/abstractstep.py: Added.
  • Scripts/webkitpy/steps/applypatch.py: Added.
  • Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
  • Scripts/webkitpy/steps/build.py: Added.
  • Scripts/webkitpy/steps/checkstyle.py: Added.
  • Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
  • Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
  • Scripts/webkitpy/steps/closebug.py: Added.
  • Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
  • Scripts/webkitpy/steps/closepatch.py: Added.
  • Scripts/webkitpy/steps/commit.py: Added.
  • Scripts/webkitpy/steps/completerollout.py: Added.
  • Scripts/webkitpy/steps/confirmdiff.py: Added.
  • Scripts/webkitpy/steps/createbug.py: Added.
  • Scripts/webkitpy/steps/editchangelog.py: Added.
  • Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
  • Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
  • Scripts/webkitpy/steps/metastep.py: Added.
  • Scripts/webkitpy/steps/obsoletepatches.py: Added.
  • Scripts/webkitpy/steps/options.py: Added.
  • Scripts/webkitpy/steps/postdiff.py: Added.
  • Scripts/webkitpy/steps/preparechangelog.py: Added.
  • Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
  • Scripts/webkitpy/steps/promptforbugortitle.py: Added.
  • Scripts/webkitpy/steps/revertrevision.py: Added.
  • Scripts/webkitpy/steps/runtests.py: Added.
  • Scripts/webkitpy/steps/steps_unittest.py: Added.
  • Scripts/webkitpy/steps/update.py: Added.
  • Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
  • Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
  • Scripts/webkitpy/stepsequence.py:
00:43 Changeset [52713] by dbates@webkit.org

2010-01-04 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33097

Cleans up the File menu to better conform to the File menu in Safari
both in terms of options and keyboard shortcuts. Adds a "Quit" menu
options to close all open windows.

  • QGVLauncher/main.cpp: (MainWindow::buildUI):

2010-01-04 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33097

Cleans up the File menu to better conform to the File menu in Safari
both in terms of options and keyboard shortcuts. Adds a "Quit" menu
options to close all open windows. Also, renames the Tools menu to
Develop.

  • QtLauncher/main.cpp: (MainWindow::setupUI):
00:40 Changeset [52712] by dbates@webkit.org

2010-01-04 Daniel Bates <dbates@webkit.org>

https://bugs.webkit.org/show_bug.cgi?id=33039


Unreviewed fix.

  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/credentials_unittest.py:
00:35 Changeset [52711] by mjs@apple.com

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Clean up COMPILER macros and remove unused ones.
https://bugs.webkit.org/show_bug.cgi?id=33132


Removed values are COMPILER(BORLAND) and COMPILER(CYGWIN) - they were
not used anywhere.

  • wtf/Platform.h:
00:30 Changeset [52710] by eric@webkit.org

2010-01-04 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33039

[bzt] Second attempt to fix an issue where bugzilla-tool dies
when the keychain lookup fails to find an entry for bugs.webkit.org.

  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/credentials_unittest.py:
00:21 Changeset [52709] by krit@webkit.org

2010-01-03 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResources don't invalidate if target object changes attributes
https://bugs.webkit.org/show_bug.cgi?id=33091

It's neccessary to invalidate all resources of an object, if the attributes of this
target change. Otherwise the saved resource data (like ImageBuffers) don't match
to the new object properties.

Test: svg/custom/resource-invalidate-on-target-update.svg

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged): (WebCore::SVGStyledElement::invalidateResources):
  • svg/SVGStyledElement.h:

2010-01-03 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResources don't invalidate if target object changes attributes
https://bugs.webkit.org/show_bug.cgi?id=33091

Check if SVG resources are invalidated, if target object changes
attributes.

  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
  • svg/custom/resource-invalidate-on-target-update.svg: Added.
00:20 Changeset [52708] by dbates@webkit.org

2010-01-04 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33039

[bzt] Second attempt to fix an issue where bugzilla-tool dies
when the keychain lookup fails to find an entry for bugs.webkit.org.

  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/credentials_unittest.py:
00:13 Changeset [52707] by eric@webkit.org

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
https://bugs.webkit.org/show_bug.cgi?id=33131

Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
but for now we just deploy it everywhere and don't try to fix up the few valid uses
of Command.

  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/multicommandtool.py:

01/03/10:

23:40 Changeset [52706] by mjs@apple.com

2010-01-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric Seidel.

Update wtf/Platform.h to document the new system for porting macros.
https://bugs.webkit.org/show_bug.cgi?id=33130

  • wtf/Platform.h:
23:15 Changeset [52705] by abarth@webkit.org

2010-01-03 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix. Need to import ScriptError.

  • Scripts/webkitpy/buildsteps.py:
23:08 Porting Macros plan edited by mjs@apple.com
(diff)
23:08 Changeset [52704] by abarth@webkit.org

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make it easier to run submit-patch when previous run cancelled
https://bugs.webkit.org/show_bug.cgi?id=33070

This patch renames create-review to submit-patch (as requested by
Maciej).

This patch makes it easier to run submit-patch after the user has
already cancelled a previous run of submit-patch by detecting when we
already have ChangeLogs and reading the bug number from them (and not
attempting to recreate them). Aside from performance and the extra
edit step, this command should not subsume post-dif.

Also, added a --email command line argument so that the output of
prepare-ChangeLog makes sense when it can't find the user's email
address.

  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/buildsteps.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/user.py:
23:04 Changeset [52703] by eric@webkit.org

2010-01-03 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename Scripts/modules to Scripts/webkitpy
https://bugs.webkit.org/show_bug.cgi?id=33128

Just search-replace and svn mv commands.

  • Scripts/bugzilla-tool:
  • Scripts/check-webkit-style:
  • Scripts/modules: Removed.
  • Scripts/modules/BeautifulSoup.py: Removed.
  • Scripts/modules/init.py: Removed.
  • Scripts/modules/bugzilla.py: Removed.
  • Scripts/modules/bugzilla_unittest.py: Removed.
  • Scripts/modules/buildbot.py: Removed.
  • Scripts/modules/buildbot_unittest.py: Removed.
  • Scripts/modules/buildsteps.py: Removed.
  • Scripts/modules/buildsteps_unittest.py: Removed.
  • Scripts/modules/changelogs.py: Removed.
  • Scripts/modules/changelogs_unittest.py: Removed.
  • Scripts/modules/commands: Removed.
  • Scripts/modules/commands/init.py: Removed.
  • Scripts/modules/commands/commandtest.py: Removed.
  • Scripts/modules/commands/download.py: Removed.
  • Scripts/modules/commands/download_unittest.py: Removed.
  • Scripts/modules/commands/early_warning_system.py: Removed.
  • Scripts/modules/commands/early_warning_system_unittest.py: Removed.
  • Scripts/modules/commands/queries.py: Removed.
  • Scripts/modules/commands/queries_unittest.py: Removed.
  • Scripts/modules/commands/queues.py: Removed.
  • Scripts/modules/commands/queues_unittest.py: Removed.
  • Scripts/modules/commands/queuestest.py: Removed.
  • Scripts/modules/commands/upload.py: Removed.
  • Scripts/modules/commands/upload_unittest.py: Removed.
  • Scripts/modules/comments.py: Removed.
  • Scripts/modules/committers.py: Removed.
  • Scripts/modules/committers_unittest.py: Removed.
  • Scripts/modules/cpp_style.py: Removed.
  • Scripts/modules/cpp_style_unittest.py: Removed.
  • Scripts/modules/credentials.py: Removed.
  • Scripts/modules/credentials_unittest.py: Removed.
  • Scripts/modules/diff_parser.py: Removed.
  • Scripts/modules/diff_parser_unittest.py: Removed.
  • Scripts/modules/executive.py: Removed.
  • Scripts/modules/executive_unittest.py: Removed.
  • Scripts/modules/grammar.py: Removed.
  • Scripts/modules/mock.py: Removed.
  • Scripts/modules/mock_bugzillatool.py: Removed.
  • Scripts/modules/multicommandtool.py: Removed.
  • Scripts/modules/multicommandtool_unittest.py: Removed.
  • Scripts/modules/outputcapture.py: Removed.
  • Scripts/modules/patchcollection.py: Removed.
  • Scripts/modules/queueengine.py: Removed.
  • Scripts/modules/queueengine_unittest.py: Removed.
  • Scripts/modules/scm.py: Removed.
  • Scripts/modules/scm_unittest.py: Removed.
  • Scripts/modules/statusbot.py: Removed.
  • Scripts/modules/stepsequence.py: Removed.
  • Scripts/modules/style: Removed.
  • Scripts/modules/style.py: Removed.
  • Scripts/modules/style_unittest.py: Removed.
  • Scripts/modules/text_style.py: Removed.
  • Scripts/modules/text_style_unittest.py: Removed.
  • Scripts/modules/user.py: Removed.
  • Scripts/modules/webkit_logging.py: Removed.
  • Scripts/modules/webkit_logging_unittest.py: Removed.
  • Scripts/modules/webkit_mechanize.py: Removed.
  • Scripts/modules/webkitport.py: Removed.
  • Scripts/modules/webkitport_unittest.py: Removed.
  • Scripts/test-webkit-python: Removed.
  • Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
  • Scripts/validate-committer-lists:
  • Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/buildbot_unittest.py:
  • Scripts/webkitpy/buildsteps.py:
  • Scripts/webkitpy/buildsteps_unittest.py:
  • Scripts/webkitpy/commands/commandtest.py:
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/download_unittest.py:
  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/early_warning_system_unittest.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/queries_unittest.py:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/queuestest.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/comments.py:
  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/credentials_unittest.py:
  • Scripts/webkitpy/executive.py:
  • Scripts/webkitpy/executive_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/multicommandtool.py:
  • Scripts/webkitpy/multicommandtool_unittest.py:
  • Scripts/webkitpy/queueengine.py:
  • Scripts/webkitpy/queueengine_unittest.py:
  • Scripts/webkitpy/scm.py:
  • Scripts/webkitpy/scm_unittest.py:
  • Scripts/webkitpy/statusbot.py:
  • Scripts/webkitpy/stepsequence.py:
  • Scripts/webkitpy/webkit_logging_unittest.py:
  • Scripts/webkitpy/webkitport_unittest.py:
22:58 Porting Macros plan edited by mjs@apple.com
(diff)
22:54 Porting Macros plan edited by mjs@apple.com
(diff)
22:50 Porting Macros plan created by mjs@apple.com
22:49 WikiStart edited by mjs@apple.com
(diff)
22:31 Changeset [52702] by eric@webkit.org

2010-01-03 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Added script to test both Perl and Python, and renamed
run-webkit-unittests to test-webkit-python.

https://bugs.webkit.org/show_bug.cgi?id=33045

  • Scripts/VCSUtils_unittest.pl:
    • Tweaked so it can be run from outside Scripts directory.
  • Scripts/run-webkit-unittests: Removed.
    • Renamed to test-webkit-python.
  • Scripts/test-webkit-perl:
    • Tweaked so it can be run from outside Scripts directory.
  • Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
  • Scripts/test-webkit-scripts: Added.
    • Runs both test-webkit-perl and test-webkit-python.
19:12 Changeset [52701] by eric@webkit.org

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue/bugzilla-tool should build both Debug and Release
https://bugs.webkit.org/show_bug.cgi?id=28450

Add a --build-style command that lets the master process tell the child
process to build both debug and release. Eventually we want to teach
the test step to understand this option too, but that's a patch for
another day.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/webkitport.py:
  • Scripts/modules/webkitport_unittest.py:
18:40 Changeset [52700] by eric@webkit.org

2010-01-03 Kenneth Russell <kbr@google.com>

Reviewed by Maciej Stachowiak.

Index validation code must always copy client data
https://bugs.webkit.org/show_bug.cgi?id=32748

Client data must always be copied during bufferData and
bufferSubData calls, because otherwise the data the GL uses to
draw may differ from that checked by the index validation code.

  • fast/canvas/webgl/index-validation-copies-indices-expected.txt: Added.
  • fast/canvas/webgl/index-validation-copies-indices.html: Added.

2010-01-03 Kenneth Russell <kbr@google.com>

Reviewed by Maciej Stachowiak.

Index validation code must always copy client data
https://bugs.webkit.org/show_bug.cgi?id=32748

Client data must always be copied during bufferData and
bufferSubData calls, because otherwise the data the GL uses to
draw may differ from that checked by the index validation code.

Test: fast/canvas/webgl/index-validation-copies-indices.html

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::WebGLBuffer): (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData):
  • html/canvas/WebGLBuffer.h:
18:32 Changeset [52699] by eric@webkit.org

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Implement CookieJarChromium::cookiesEnabled
https://bugs.webkit.org/show_bug.cgi?id=33123

Call out to ChromiumBridge to find out if cookies are enabled.

  • platform/chromium/ChromiumBridge.h:
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::cookiesEnabled):

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Implement CookieJarChromium::cookiesEnabled
https://bugs.webkit.org/show_bug.cgi?id=33123

Call out to the webKitClient() to see if cookies are enabled. Also
remove some straggling references to policyURL!

  • public/WebKitClient.h: (WebKit::WebKitClient::setCookies): (WebKit::WebKitClient::cookies): (WebKit::WebKitClient::rawCookies): (WebKit::WebKitClient::cookiesEnabled):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cookiesEnabled):
18:24 Changeset [52698] by eric@webkit.org

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove evaluateInNewContext (it's useless)
https://bugs.webkit.org/show_bug.cgi?id=33068

This function has no clients and makes life complicated. Isolated
worlds won out over NewContext and there's not really any going back
now.

No new tests because this is all minus lines.

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertWindowToV8Object):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove evaluateInNewContext (it's useless)
https://bugs.webkit.org/show_bug.cgi?id=33068

This function has no clients and makes life complicated. Isolated
worlds won out over NewContext and there's not really any going back
now.

  • public/WebFrame.h:
  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
18:17 Changeset [52697] by eric@webkit.org

2010-01-03 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] EventSender: add support for Enter key events
https://bugs.webkit.org/show_bug.cgi?id=33064

Unskip 5 tests that are fixed now.

  • platform/qt/Skipped:

2010-01-03 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] EventSender: add support for Enter key events
https://bugs.webkit.org/show_bug.cgi?id=33064

Unskip 5 tests that are fixed now.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
18:10 Changeset [52696] by eric@webkit.org

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Add test for previous typo fix
https://bugs.webkit.org/show_bug.cgi?id=33083

A trivial test for a trivial fix, as requested by Eric.

  • Scripts/modules/bugzilla_unittest.py:
18:03 Changeset [52695] by eric@webkit.org

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement mac-ews
https://bugs.webkit.org/show_bug.cgi?id=33072

The mac-ews is slightly different than the other early warning systems
because we can't run Mac OS X inside a VM. For that reason, we only
process patches that were uploaded by committers. This isn't as much
coverage as the other EWS bots, but it's better than nothing.

  • Scripts/modules/commands/early_warning_system.py:
  • Scripts/modules/commands/early_warning_system_unittest.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/queuestest.py:
  • Scripts/modules/mock_bugzillatool.py:
17:55 Changeset [52694] by eric@webkit.org

2010-01-03 Mario Bensi <mbensi@pleyo.com>

Reviewed by Simon Fraser.

create 3d directory and move tests dependent of 3D Rendering in this
directory.

https://bugs.webkit.org/show_bug.cgi?id=33081

  • animations/3d: Added.
  • animations/3d/change-transform-in-end-event.html: Copied from LayoutTests/animations/change-transform-in-end-event.html.
  • animations/3d/state-at-end-event-transform.html: Copied from LayoutTests/animations/state-at-end-event-transform.html.
  • animations/3d/transform-origin-vs-functions-expected.txt: Copied from LayoutTests/animations/transform-origin-vs-functions-expected.txt.
  • animations/3d/transform-origin-vs-functions.html: Copied from LayoutTests/animations/transform-origin-vs-functions.html.
  • animations/change-transform-in-end-event.html: Removed.
  • animations/state-at-end-event-transform.html: Removed.
  • animations/transform-origin-vs-functions-expected.txt: Removed.
  • animations/transform-origin-vs-functions.html: Removed.
13:48 Changeset [52693] by kov@webkit.org

Skip test that fails on and off on the release bot.

13:25 Changeset [52692] by ddkilzer@apple.com

Refactored svn-apply and svn-unapply to use a common "patch"
command method, and added unit tests for this new method.

Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-03
Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=33098

  • Scripts/VCSUtils.pm:
    • Added generateRunPatchCommand().
    • Added runPatchCommand().
    • Added exitStatus() from webkitdirs.pm to address FIXME.
  • Scripts/VCSUtils_unittest.pl:
    • Added 10 unit tests for generateRunPatchCommand().
    • Added 4 unit tests for runPatchCommand().
    • Added callSilently() method.
  • Scripts/svn-apply:
    • Refactored applyPatch().
    • Removed $pathScriptWasRunFrom global variable.
    • Addressed issue where "--force" option was getting added twice.
  • Scripts/svn-unapply:
    • Refactored applyPatch().
    • Removed $pathScriptWasRunFrom global variable.
    • Added support for --force option.
    • Enhanced to return meaningful exit status.
  • Scripts/webkitdirs.pm:
    • Moved exitStatus() implementation to VCSUtils.pm.
11:39 Changeset [52691] by weinig@apple.com

Rubber-stamped by Dan Bernstein.

Remove out of date commented out attributes in IDLs. We have implemented onpopstate.

  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.idl:
  • page/DOMWindow.idl:
11:36 Changeset [52690] by laszlo.1.gombos@nokia.com

2009-12-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable all HTML5 persistent features for QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=33086

  • QGVLauncher/main.cpp: Call enablePersistentStorage() (main):
09:45 Changeset [52689] by krit@webkit.org

2010-01-03 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Mark more filter effect as alphaImage if possible
https://bugs.webkit.org/show_bug.cgi?id=33111

Mark more effects as alphaImage if the previous effect is a
alphaImage. This can reduce the calculation on the next effect
like feGaussianBlur.


Test: This changes don't affect any LayoutTests and can't be tested

somehow, since the changes are 'invisible'.

  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):

01/02/10:

11:57 Changeset [52688] by dbates@webkit.org

2010-01-02 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33109

Cleans up the XSSAuditor test directory by removing unnecessary test scripts.

The patch for bug #33107 added notifyDone() functionality to the script
echo-intertag.pl. So, we can substitute this script for scripts echo-intertag-and-notify.php,
echo-intertag-post-and-notify.pl, and echo-intertag-post.pl.

  • http/tests/security/xssAuditor/link-opens-new-window.html: Modified to call script echo-intertag.pl.
  • http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Removed.
  • http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Removed.
  • http/tests/security/xssAuditor/script-tag-post-control-char.html: Modified to call script echo-intertag.pl.
  • http/tests/security/xssAuditor/script-tag-post-null-char.html: Modified to call script echo-intertag.pl.
  • http/tests/security/xssAuditor/script-tag-post.html: Modified to call script echo-intertag.pl.
11:54 Changeset [52687] by dbates@webkit.org

2010-01-02 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33107

Removes the use of window.setTimeout from the XSSAuditor tests:
get-from-iframe.html and post-from-iframe.html by having the
script echo-intertag.pl (called by these tests) call
layoutTestController.notifyDone().

  • http/tests/security/xssAuditor/get-from-iframe.html: Removes call of window.setTimeout.
  • http/tests/security/xssAuditor/post-from-iframe.html: Ditto.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl: If the query argument notifyDone is found, then the script will generate a JavaScript script to call layoutTestController.notifyDone().

01/01/10:

11:40 Changeset [52686] by simon.fraser@apple.com

2010-01-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Scrollbar of overflow:scroll div in compositing layer fails to render
https://bugs.webkit.org/show_bug.cgi?id=32439

When deciding whether a RenderLayer needs backing store, check whether it has
overflow controls that need painting.

Test: compositing/overflow/scrollbar-painting.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hasOverflowControls):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

12/31/09:

20:42 QtWebKitPerformanceToolBackLog: edited by zecke@selfish.org
Document the new netsim in the perf suite. (diff)
12:03 Changeset [52685] by christian@webkit.org

2009-12-31 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546

Only show font menu items in rich text areas in the GTK+ port.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
11:58 Changeset [52684] by christian@webkit.org

2009-12-31 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546

Don't show spell checking menu items in text areas in the GTK+ port.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
11:10 QtWebKitBackportingFixes edited by norbert.leser@nokia.com
Added svn rev# for bug 33082 (diff)
11:07 QtWebKitBackportingFixes edited by norbert.leser@nokia.com
(diff)
10:41 Changeset [52683] by mitz@apple.com

<rdar://problem/7503279> REGRESSION (r47440): Incomplete repaint at macworldexpo.com
https://bugs.webkit.org/show_bug.cgi?id=33067

Reviewed by Simon Fraser.

WebCore:

Test: fast/repaint/table-cell-overflow.html

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::hasVisibleOverflow): Added.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows): Set m_hasOverflowingCell if
any cell has visible overflow, like it was before r47440.

LayoutTests:

  • fast/repaint/table-cell-overflow-expected.checksum: Added.
  • fast/repaint/table-cell-overflow-expected.png: Added.
  • fast/repaint/table-cell-overflow-expected.txt: Added.
  • fast/repaint/table-cell-overflow.html: Added.
10:07 Changeset [52682] by eric@webkit.org

2009-12-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Do not include Frame.h under WebCore/html/canvas
https://bugs.webkit.org/show_bug.cgi?id=33082

No new tests, as there is no new functionality.

  • html/canvas/CanvasRenderingContext2D.cpp:
08:45 ApplicationsGtk edited by iwkse@claws-mail.org
(diff)
08:38 Changeset [52681] by eric@webkit.org

2009-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement build-and-test
https://bugs.webkit.org/show_bug.cgi?id=33073

Some of the early warning system bots want to use build-and-test so
they can cover LayoutTests in addition to just compilation.

  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/download_unittest.py:
04:49 Changeset [52680] by eric@webkit.org

2009-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Show mac-ews status on QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=33076

Also make error status purple.

  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/statusbubble.html:
00:35 Changeset [52679] by abarth@webkit.org

2009-12-31 Adam Barth <abarth@webkit.org>

Unreviewed.

[bzt] REGRESSION: Bugzila is a typo
https://bugs.webkit.org/show_bug.cgi?id=33074

Eric should test his code before landing! :)

  • Scripts/modules/bugzilla.py:
00:25 Changeset [52678] by abarth@webkit.org

2009-12-31 Adam Barth <abarth@webkit.org>

Unreviewed. Fix the unit tests!

  • Scripts/run-webkit-unittests:
Note: See TracTimeline for information about the timeline view.