Timeline


and

01/07/10:

23:56 Changeset [52976] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Run the http and websocket tests after all other tests.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Darin Adler.

  • Scripts/run-webkit-tests:
23:41 Changeset [52975] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
https://bugs.webkit.org/show_bug.cgi?id=33311

Reviewed by Gavin Barraclough.

Move compileGetDirectOffset function to common part of JSVALUE32

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):

23:08 Changeset [52974] by eric@webkit.org
  • 5 edits in trunk

2010-01-07 Mike Belshe <mbelshe@chromium.org>

Reviewed by Darin Adler.

Fix Spdy casing to match style guide.

https://bugs.webkit.org/show_bug.cgi?id=33326

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::wasFetchedViaSPDY): (WebCore::ResourceResponse::setWasFetchedViaSPDY):

2010-01-07 Mike Belshe <mbelshe@chromium.org>

Reviewed by Darin Adler.

Fix Spdy casing to match style guide.

https://bugs.webkit.org/show_bug.cgi?id=33326

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasFetchedViaSPDY): (WebKit::WebURLResponse::setWasFetchedViaSPDY):
22:54 Changeset [52973] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Maciej Stachowiak.

Allow call sites to determine if ASSERT_* and LOG_* macros are operational
https://bugs.webkit.org/show_bug.cgi?id=33020

  • wtf/Assertions.h: Set ASSERT_MSG_DISABLED, FATAL_DISABLED, ERROR_DISABLED, LOG_DISABLED to 1 if the compiler does not support variadic macros. Refactor for better readibility.
22:16 Changeset [52972] by dbates@webkit.org
  • 14 edits in trunk

2010-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • Configurations/FeatureDefines.xcconfig:

2010-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • features.gypi:

2010-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • Configurations/FeatureDefines.xcconfig:

2010-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • config.h:

2010-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • configure.ac:
21:54 Changeset [52971] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-07 Afonso R. Costa Jr. <afonso.costa@openbossa.org>

Reviewed by Darin Adler.

As the bug https://bugs.webkit.org/show_bug.cgi?id=30034 is fixed,
the zoomOrNot argument is unnecessary.

  • fast/dom/elementFromPoint-relative-to-viewport.html:
21:47 Changeset [52970] by laszlo.1.gombos@nokia.com
  • 3 edits
    1 add in trunk/JavaScriptCore

2010-01-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Gavin Barraclough.

[Symbian] Port ARM traditional JIT Trampolines to RVCT
https://bugs.webkit.org/show_bug.cgi?id=30552

Take the GCC implementation and mechanically convert
it to RVCT syntax.

Use 'bx rX' instead of 'mov pc, rX' when it is available.

Developed in cooperation with Iain Campbell and Gabor Loki.

  • JavaScriptCore.pri: Extra step to generate RVCT stubs. The script generation intentionally executed all the time not just for RVCT targets.
  • create_rvct_stubs: Added. Perl script to expand precompiler macros for RVCT assembler - the template is defined in JITStubs.cpp.
  • jit/JITStubs.cpp: (JSC::ctiTrampoline): (JSC::ctiVMThrowTrampoline): (JSC::ctiOpThrowNotCaught):
21:12 Changeset [52969] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix some test-webkitpy expectations
https://bugs.webkit.org/show_bug.cgi?id=33345

I forgot to change these when I added the CheckStyle step.

  • Scripts/webkitpy/commands/upload_unittest.py:
20:58 Changeset [52968] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
https://bugs.webkit.org/show_bug.cgi?id=33341

Fix this by moving to the root directory before editing ChangeLogs.
There is a related bug with CheckStyle.

  • Scripts/webkitpy/steps/checkstyle.py:
  • Scripts/webkitpy/steps/editchangelog.py:
19:06 Changeset [52967] by slewis@apple.com
  • 6 edits in trunk/WebCore

Rolled out http://trac.webkit.org/changeset/52778 due to rolling
out http://trac.webkit.org/changeset/52756

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • editing/SelectionController.cpp:

(WebCore::SelectionController::layout):
(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::paintCaret):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::attach):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::attach):

  • page/Frame.cpp:

(WebCore::Frame::revealSelection):

18:51 Changeset [52966] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

media/unsupported-tracks.html is failing on Snow Leopard Release bot
https://bugs.webkit.org/show_bug.cgi?id=32339

This is a speculative fix. I do not have a Snow Leopard machine to test on
and I've not seen mention of someone being able to reproduce this locally.

Prevent watchdog timer from firing after a test completes but before
the next one starts, causing the error to appear in the next test.

  • DumpRenderTree/mac/DumpRenderTree.mm: (dump): Stop the watchdog before printing #EOF for the test content. We only need to care about the JavaScript of the test running too long or some hang in WebCore. Any other failures will be covered by the calling script's own watchdog timer.
18:22 Changeset [52965] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue is stuck spinning due to exception
https://bugs.webkit.org/show_bug.cgi?id=33358

  • Scripts/webkitpy/commands/queues.py:
    • Don't try to stringify the exception.
17:56 Changeset [52964] by slewis@apple.com
  • 7 edits
    2 deletes in trunk

Rollout http://trac.webkit.org/changeset/52756 due to a large performance regression.

WebCore:

  • dom/Document.cpp:

(WebCore::Document::updateLayout):

  • editing/SelectionController.cpp:

(WebCore::SelectionController::SelectionController):
(WebCore::SelectionController::setSelection):

  • editing/SelectionController.h:
  • page/Frame.cpp:

(WebCore::Frame::setCaretVisible):
(WebCore::Frame::selectionLayoutChanged):
(WebCore::Frame::caretBlinkTimerFired):
(WebCore::Frame::selectionBounds):

  • page/FrameView.cpp:

(WebCore::FrameView::needsLayout):

LayoutTests:

  • fast/forms/selection-layout-reentry-strange-case-expected.txt: Removed.
  • fast/forms/selection-layout-reentry-strange-case.html: Removed.
16:57 Changeset [52963] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

More build fix.

  • WebKitPrefix.h: Define JS_EXPORTCLASS here, as well (as empty).
16:44 Changeset [52962] by ggaren@apple.com
  • 4 edits in trunk

Fix a crash seen on the buildbots.

Reviewed by Sam Weinig.

JavaScriptCore:

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init): Disable specific function tracking here,
instead of in WebCore, to ensure that the disabling happens before a
specific function can be registered.

WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase): Don't disable specific
function tracking here; it's too late, as some specific functions
may already have been tracked in the base class constructor.

16:43 Changeset [52961] by ap@apple.com
  • 2 edits in trunk/JavaScriptCore

Mac build fix.

16:36 Changeset [52960] by zimmermann@webkit.org
  • 12 edits
    9 adds in trunk

2010-01-07 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGTextElement & friends need to implement svgAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=33284

Implement svgAttributeChanged() for SVGTextElement & SVGTRefElement. As <text> element contain children,
childrenChanged() has to be implemented as well for SVGTextElement.

Simplify SVGTransformable::parseTransformAttribute() code, clearing lists in the beginning
and on error case, after parsing - previously the calling site had to take care of that.

Tests: svg/dynamic-updates/SVGTRefElement-dom-href-attr.html

svg/dynamic-updates/SVGTextElement-dom-transform-attr.html
svg/dynamic-updates/SVGTextElement-svgdom-transform-prop.html

  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::parseMappedAttribute):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::svgAttributeChanged):
  • svg/SVGTRefElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::svgAttributeChanged): (WebCore::SVGTextElement::childrenChanged):
  • svg/SVGTextElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
  • svg/SVGTransformable.h:
16:28 Changeset [52959] by ap@apple.com
  • 2 edits in trunk/JavaScriptGlue

Mac build fix.

  • config.h: Define JS_EXPORTCLASS for JavaScriptGlue.
16:28 Changeset [52958] by bweinstein@apple.com
  • 3 edits
    1 add in trunk/WebCore

Padding in popup menu gets lost with styled <select> in Windows.
Fixes <rdar://7285538>, and <http://webkit.org/b/33235>.

Reviewed by Adele Peterson.

[Win] Support padding-right on selects when webkit-appearance is off. Added a test
case for narrow selects with -webkit-appearance: none, and padding left and right to
show that both types of padding are honored.

  • manual-tests/select-webkit-appearance-off-narrow-select.html: Added.
  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::calculatePositionAndSize): Use clientPaddingRight instead of a hardcoded constant.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::clientPaddingRight): If webkit-appearance is off, use padding-right instead of
the hardcoded constant.

16:24 Changeset [52957] by ap@apple.com
  • 2 edits in trunk/WebKitLibraries

Not reviewed, build fix.

Windows buid fix - disable warning 4251 (class needs to have dll-interface to be used by
clients of another class). WebCore doesn't use all methods of JSString, so
we don't export all classes clients could theoretically access via JSString.

  • win/tools/vsprops/common.vsprops:
16:15 Changeset [52956] by ap@apple.com
  • 18 edits
    3 adds in trunk

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=33057
REGRESSION(r49365): typeof(xhr.responseText) != "string" in Windows

<rdar://problem/7296920> REGRESSION: WebKit fails to start PeaceKeeper benchmark

Test: fast/js/webcore-string-comparison.html

In r49365, some code was moved from JSString.cpp to JSString.h, and as a result, WebCore
got a way to directly instantiate JSStrings over DLL borders. Since vftable for JSString was
not exported, objects created from WebCore got a different vptr, and JavaScriptCore
optimizations that relied on vptr of all JSString objects being equal failed.

  • config.h: Added a JS_EXPORTCLASS macro for exporting classes. It's currently the same as JS_EXPORTDATA, but it clearly needed a new name.
  • runtime/InitializeThreading.cpp: (JSC::initializeThreadingOnce):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::createNonDefault): (JSC::JSGlobalData::create): (JSC::JSGlobalData::sharedInstance):
  • runtime/JSGlobalData.h: Store vptrs just once, no need to repeatedly pick and copy them. This makes it possible to assert vptr correctness in object destructors (which don't have access to JSGlobalData, and even Heap::heap(this) will fail for fake objects created from storeVPtrs()).
  • runtime/JSArray.cpp: (JSC::JSArray::~JSArray): Assert that vptr is what we expect it to be. It's important to assert in destructor, because MSVC changes the vptr after constructor is invoked.
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::~JSByteArray): Ditto.
  • runtime/JSByteArray.h: Ditto.
  • runtime/JSFunction.h: Ditto.
  • runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction): Ditto.
  • runtime/JSCell.h: (JSC::JSCell::setVPtr): Added a method to substitute vptr for another one.
  • runtime/JSString.h: Export JSString class together with its vftable, and tell other libraries tp import it. This is needed on platforms that have a separate JavaScriptCore dynamic library - and on Mac, we already did the export via JavaScriptCore.exp. (JSC::JSString::~JSString): Assert tha vptr is what we expect it to be. (JSC::fixupVPtr): Store a previously saved primary vftable pointer (do nothing if building JavaScriptCore itself). (JSC::jsSingleCharacterString): Call fixupVPtr in case this is call across DLL boundary. (JSC::jsSingleCharacterSubstring): Ditto. (JSC::jsNontrivialString): Ditto. (JSC::jsString): Ditto. (JSC::jsSubstring): Ditto. (JSC::jsOwnedString): Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export the new static JSGlobalData members that are used in WebCore via inline functions.
15:51 Changeset [52955] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Account for scale and current context position (as well as page
position) in the device context world transform passed to
plugins. This is especially important for print surface DPI.
http://bugs.webkit.org/show_bug.cgi?id=32909.

Reviewed by Jon Honeycutt.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintWindowedPluginIntoContext): Revise

world context handling to include scaling and translation
already set for the CTM.

15:44 Changeset [52954] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Don't leak a JSStringRef within _accessibilityNotificationCallback.

Reviewed by Jon Honeycutt.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
when it goes out of scope.

15:33 Changeset [52953] by mjs@apple.com
  • 2 edits in trunk/WebKit/mac

2010-01-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report )
https://bugs.webkit.org/show_bug.cgi?id=33348
<rdar://problem/7310616>


  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): We only want to handle file: URLs for the user stylesheet now, so special-case the DashboardClient's funky user stylesheet URL by mapping it to the equivalent file URL.
14:55 Changeset [52952] by japhet@chromium.org
  • 24 edits in trunk/WebCore

2010-01-07 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Generate V8 bindings header declarations for named and indexed accessors.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:
  • bindings/v8/custom/V8StorageCustom.cpp:
  • bindings/v8/custom/V8StyleSheetListCustom.cpp:
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
14:36 Changeset [52951] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Better build fix: use 'this->structure()', since 'structure' is a
PassRefPtr, and therefore null.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):

14:27 Changeset [52950] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Build fix: avoid a name conflict by using the local 'structure' instead
of the member 'structure()'.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):

14:13 Changeset [52949] by simon.fraser@apple.com
  • 7 edits in trunk/WebCore

2010-01-07 Simon Fraser <simon.fraser@apple.com>

Build fix.

Add RenderEmbeddedObject.h/cpp to all the build systems.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
14:07 Changeset [52948] by ggaren@apple.com
  • 5 edits in trunk

2010-01-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Safari memory usage skyrockets using new Google AdWords interface
https://bugs.webkit.org/show_bug.cgi?id=33343

The memory use was caused by the global object creating too many structures
as it thrashed between different specific functions.

  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::addAnonymousSlotsTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::despecifyAllFunctions):
  • runtime/Structure.h: (JSC::Structure::disableSpecificFunctionTracking): Track a thrash count for specific functions. Disable specific function tracking once the thrash count has been hit.

2010-01-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Safari memory usage skyrockets using new Google AdWords interface
https://bugs.webkit.org/show_bug.cgi?id=33343

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Disabled specific function tracking for the window object, since there's no way to do direct method calls on the window object; they all go through the window shell.
13:57 Changeset [52947] by simon.fraser@apple.com
  • 46 edits
    2 copies in trunk

2010-01-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Kevin Decker, Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33338
Create a renderer for <object> and <embed>

Add RenderEmbeddedObject, which derives from RenderPartObject, and is created for <object> and <embed>.
Instances of RenderPartObject are now only allocated for iframes.

Move object/embed-related code from RenderPartObject to RenderEmbeddedObject.

  • WebCore.xcodeproj/project.pbxproj: Add RenderEmbeddedObject.h/cpp
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::createRenderer): Create a RenderEmbeddedObject. (WebCore::HTMLEmbedElement::updateWidget): Use toRenderEmbeddedObject()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): Make a RenderEmbeddedObject for the plugin-proxy case. (WebCore::HTMLMediaElement::finishParsingChildren): Use toRenderEmbeddedObject() in the plugin-proxy code.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::createRenderer): Make a RenderEmbeddedObject (WebCore::HTMLObjectElement::updateWidget): Use toRenderEmbeddedObject()
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::addWidgetToUpdate): (WebCore::FrameView::removeWidgetToUpdate): (WebCore::FrameView::updateWidgets): Objects in the m_widgetUpdateSet are only ever RenderEmbeddedObjects.
  • rendering/RenderEmbeddedObject.cpp: Added.
  • rendering/RenderEmbeddedObject.h: Added. Most of the code moved from RenderPartObject.
  • rendering/RenderObject.h: (WebCore::RenderObject::isEmbeddedObject): New method.
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Initialize m_hasFallbackContent here, rather than in the derived classes.
  • rendering/RenderPart.h: Comments.
  • rendering/RenderPartObject.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Clean up, code moved to base class, and removed object/embed-specific code. (WebCore::RenderPartObject::layout): Removed object/embed-specific code.
13:47 Changeset [52946] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2010-01-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33338
Create a renderer for <object> and <embed>

First part of this change: renderPartObject->updateWidget() is a no-op for iframe elements,
so we don't need to call it here, and can thus remove the attach() override entirely.

  • html/HTMLIFrameElement.cpp:
  • html/HTMLIFrameElement.h:
13:36 Changeset [52945] by pfeldman@chromium.org
  • 7 edits
    4 adds in trunk/WebCore

2009-01-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Migrate to canvas-based text viewer / editor that scales.

https://bugs.webkit.org/show_bug.cgi?id=33001

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/JavaScriptHighlighterScheme.js: Added. (WebInspector.JavaScriptHighlighterScheme):
  • inspector/front-end/KeyboardShortcut.js:
  • inspector/front-end/TextEditor.js: Added. (WebInspector.TextEditor): (WebInspector.TextSelectionModel): (WebInspector.TextCursor):
  • inspector/front-end/TextEditorHighlighter.js: Added. (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/TextEditorModel.js: Added. (WebInspector.TextRange): (WebInspector.TextRange.prototype.clone): (WebInspector.TextEditorModel):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
13:32 Changeset [52944] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-01-07 Christian Sejersen <christian.webkit@gmail.com>

Reviewed by Darin Adler.

document.title does not replace or remove space characters
https://bugs.webkit.org/show_bug.cgi?id=27032

  • fast/dom/Document/document-title-get-expected.txt: Added.
  • fast/dom/Document/document-title-get.html: Added.
  • fast/dom/Document/script-tests/document-title-get.js: Added.

2010-01-07 Christian Sejersen <christian.webkit@gmail.com>

Reviewed by Darin Adler.

document.title does not replace or remove space characters
https://bugs.webkit.org/show_bug.cgi?id=27032

Test: fast/dom/Document/document-title-get.html

  • dom/Document.cpp: (WebCore::Document::Document): Initialization of m_rawTitle (WebCore::canonicalizedTitle): Moved from DocumentLoader.cpp with minor edits (WebCore::Document::updateTitle): Ensures the title is canonicalized (WebCore::Document::setTitle): Uses m_rawTitle instaed of m_title (WebCore::Document::removeTitle): Uses m_rawTitle instead of m_title
  • dom/Document.h: Added m_rawTitle that stores the passed in title, m_title now stores the canonicalized title
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setTitle): The title passed in is now canonicalized in Document.cpp
12:58 Changeset [52943] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-07 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Allow leading/trailing space for CSS nth-*() and lang().
https://bugs.webkit.org/show_bug.cgi?id=17248

For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.

  • fast/css/css3-space-in-nth-and-lang.html: Added.
  • platform/mac/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.

2010-01-07 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Allow leading/trailing space for CSS nth-*() and lang().
https://bugs.webkit.org/show_bug.cgi?id=17248

For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.

  • css/CSSGrammar.y:
12:26 Changeset [52942] by kdecker@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=33331
(WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins)


  • Plugins/Hosted/NetscapePluginHostManager.h: Modify method signature for instantiatePlugin to include acceleratedCompositingEnabled bool.
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin):
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): Pass accelerated compositing status to NetscapePluginHostManage
12:24 Changeset [52941] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

AX: contentEditable DIVs are not AX accessible
https://bugs.webkit.org/show_bug.cgi?id=33325

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/contenteditable-hidden-div.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::canSetValueAttribute):

LayoutTests:

  • accessibility/contenteditable-hidden-div-expected.txt: Added.
  • accessibility/contenteditable-hidden-div.html: Added.
12:20 Changeset [52940] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Skip LayoutTests/http/tests/media/video-error-abort.html

  • platform/gtk/Skipped:
12:18 Changeset [52939] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed. roll-out r52917, r52932 and r52934.

12:08 Changeset [52938] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-07 Adam Barth <abarth@webkit.org>

Unreviewed. Resolve merge conflict.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
12:00 Changeset [52937] by abarth@webkit.org
  • 12 edits in trunk

2010-01-07 Adam Barth <abarth@webkit.org>

No review, rolling out r52847.
http://trac.webkit.org/changeset/52847
https://bugs.webkit.org/show_bug.cgi?id=33232

Might have caused a perf regression. I'm rolling this out to see if it
heals the perf bot.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::updateDocument):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
  • bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::V8IsolatedContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::currentContext): (WebCore::V8Proxy::setContextDebugId):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::windowShell):
  • bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::adjustedContext):

2010-01-07 Adam Barth <abarth@webkit.org>

No review, rolling out r52847.
http://trac.webkit.org/changeset/52847
https://bugs.webkit.org/show_bug.cgi?id=33232

Might have caused a perf regression.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
11:45 Changeset [52936] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in skiplist by this commit.

  • platform/mac/Skipped:
11:41 Changeset [52935] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Add executable bit to video-throttled-load cgi.

  • http/tests/media/video-throttled-load.cgi: Added property svn:executable.
11:25 Changeset [52934] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed. Fix the Mac bots. Why is there no HTTPD PID file?

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07

  • Scripts/run-webkit-tests:
10:48 Changeset [52933] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • WebCore.xcodeproj/project.pbxproj: Made TypesettingFeatures.h private.
10:33 Changeset [52932] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Store HTTPD PID in a variable to fix warnings if for some reason the pidfile gets deleted before httpd terminates.
This should fix the occasional warnings for uninitialized values on the Mac bots.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Alexey Proskuryakov.

  • Scripts/run-webkit-tests:
10:28 Changeset [52931] by mitz@apple.com
  • 9 edits
    1 add in trunk/WebCore

Added Font::typesettingFeatures() and deployed it

Reviewed by Sam Weinig.

No change in funcitonality

  • WebCore.xcodeproj/project.pbxproj: Added TypesettingFeatures.h.
  • platform/graphics/Font.h:

(WebCore::Font::typesettingFeatures): Added. Determines the typesetting

features from the text redndering mode.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::canUseGlyphCache): Use typesettingFeatures().

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/TypesettingFeatures.h: Added.
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::disableLigatures): Take TypesettingFeatures instead of

TextRenderingMode.

(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):

Use typesettingFeatures().

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

Ditto.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCFStringAttributes): Take

TypesettingFeatures instead of TextRenderingMode.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak): Use TypesettingFeatures().

10:08 Changeset [52930] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-01-07 Dimitri Glazkov <dglazkov@chromium.org>

No review, rolling out r52900.
http://trac.webkit.org/changeset/52900
https://bugs.webkit.org/show_bug.cgi?id=30055

Broke over 30 SVG pixel tests.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
09:45 Changeset [52929] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] The library version number of the first package release is 4.7.0.

  • WebCore.pro:
09:36 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
09:33 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
09:31 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
09:29 Changeset [52928] by hausmann@webkit.org
  • 6 edits in trunk

[Qt] Allow the application to override online/offline network status
https://bugs.webkit.org/show_bug.cgi?id=32684

Patch by Yael Aharon <yael.aharon@nokia.com> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.

WebCore:

Added API to NetworkStateNotifier for forcing network status.

  • platform/network/NetworkStateNotifier.h:
  • platform/network/qt/NetworkStateNotifierPrivate.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:

(WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifierPrivate::onlineStateChanged):
(WebCore::NetworkStateNotifierPrivate::networkAccessPermissionChanged):
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::setNetworkAccessAllowed):

WebKit/qt:

Add a setting so that applications can overide the network status.
Applications that use this setting still need to block network access
through QNAM.

  • Api/qwebsettings.cpp:

(qt_networkAccessAllowed):

09:26 Changeset [52927] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix.

  • platform/gtk/Skipped: missing "l" suffix added to fast/repaint/subtree-layoutstate-transform.html
09:14 Changeset [52926] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

prospective bearer management build fix to get the include path correct

08:52 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
08:52 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
08:38 Changeset [52925] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=33323
Skip new test on Tiger for now.

  • platform/mac-tiger/Skipped:
08:22 Changeset [52924] by ossy@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Enable JIT in debug mode on win32 after r51141 fixed the crashes.

Reviewed by Simon Hausmann.

08:02 Changeset [52923] by eric.carlson@apple.com
  • 4 edits
    2 moves in trunk

2010-01-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=33272
'abort' event still fired as a progress event

rdar://6710625
Test media/video-error-abort.html doesn't work

Test: http/tests/media/video-error-abort.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::scheduleEvent): Incorporate code from enqueueEvent. (WebCore::HTMLMediaElement::loadInternal): Fix 'abort' event firing logic missed in https://bugs.webkit.org/show_bug.cgi?id=30513. Change order of initialization to match spec wording.
  • html/HTMLMediaElement.h: Remove enqueueEvent prototype.

2010-01-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=33272
'abort' event still fired as a progress event

rdar://6710625
Test media/video-error-abort.html doesn't work

  • http/tests/media/video-error-abort-expected.txt: Copied from LayoutTests/media/video-error-abort-expected.txt.
  • http/tests/media/video-error-abort.html: Copied from LayoutTests/media/video-error-abort.html.

Modified to run with slow loading cgi, add test to ensure that 'abort' event is not a
progress event.

  • media/video-error-abort-expected.txt: Removed.
  • media/video-error-abort.html: Removed.
07:48 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
06:37 Changeset [52922] by eric@webkit.org
  • 9 edits in trunk

2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878

Touch event tests changed to match the API and semantics of iPhone and
Android. Each new touch point press dispatches a touchstart event with
the pressed touch point(s) in the changedTouches list, and a release
dispatches a touchend event with the released touch point(s) in
changedTouches. Moved points dispatch a touchmove event, with the moved
points in changedTouches. Old behaviour emitted only one touchstart when
the first point was pressed and one touchend when the last point was
released, and any events in between were touchmoves. New presses or
releases could only be detected by comparing the lists touches and
changedTouches.

  • fast/events/basic-touch-events-expected.txt:
  • fast/events/script-tests/basic-touch-events.js: (singleTouchSequence): (multiTouchSequence):

2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878

Touch events changed to match the API and semantics of iPhone and
Android. Each new touch point press dispatches a touchstart event with
the pressed touch point(s) in the changedTouches list, and a release
dispatches a touchend event with the released touch point(s) in
changedTouches. Moved points dispatch a touchmove event, with the moved
points in changedTouches. Old behaviour emitted only one touchstart when
the first point was pressed and one touchend when the last point was
released, and any events in between were touchmoves. New presses or
releases could only be detected by comparing the lists touches and
changedTouches.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
  • page/EventHandler.h:

2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::touchStart): (EventSender::touchEnd): (EventSender::clearTouchPoints):
  • DumpRenderTree/qt/EventSenderQt.h:
05:43 Changeset [52921] by tkent@chromium.org
  • 105 edits
    3 deletes in trunk

2010-01-07 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Remove COM code generation stuff.
https://bugs.webkit.org/show_bug.cgi?id=32854

Remove the followings:

  • CodeGeenratorCOM.pm, COM code generator,
"#if !defined(LANGUAGE_COM)
!LANGUAGE_COM" in IDL files, and
  • UUID attributes in IDL files.
  • bindings/scripts/CodeGeneratorCOM.pm: Removed.
  • css/CSSCharsetRule.idl:
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSUnknownRule.idl:
  • css/CSSValue.idl:
  • css/CSSValueList.idl:
  • css/Counter.idl:
  • css/MediaList.idl:
  • css/RGBColor.idl:
  • css/Rect.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSKeyframeRule.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/Attr.idl:
  • dom/CDATASection.idl:
  • dom/CharacterData.idl:
  • dom/Comment.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/EntityReference.idl:
  • dom/Event.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeList.idl:
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
  • dom/Text.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl:

2010-01-07 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Remove COM code generation files.
https://bugs.webkit.org/show_bug.cgi?id=32854

  • WebKit.vcproj/DerivedSources.make: Removed.
  • WebKit.vcproj/build-generated-files.sh: Removed.
05:15 Changeset [52920] by vestbo@webkit.org
  • 1 edit in trunk/JavaScriptCore/jit/JIT.cpp

Unreviewed build fix for Qt on Mac OS X

04:16 Changeset [52919] by steveblock@google.com
  • 3 edits in trunk/WebCore

Android requires ability to increase layout delay

04:13 Changeset [52918] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Holger Freyther.

[Mac] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
https://bugs.webkit.org/show_bug.cgi?id=33312

Using of operator += cause compile error on Mac, so it is changed to
"= static_cast<AllocAlignmentInteger*>(old_ptr) + 1".

  • wtf/FastMalloc.cpp: (WTF::TCMallocStats::realloc):
04:12 Changeset [52917] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Reworked r52853 after r52876 rolled it out.
Chomp the pid variable before passing it to kill and read the contents of
the pidfile in a platform independent manner.
First pach of https://bugs.webkit.org/show_bug.cgi?id=33153.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.

  • Scripts/run-webkit-tests:
03:50 Changeset [52916] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Adam Barth.

Created a module that runs the style package unit tests.

https://bugs.webkit.org/show_bug.cgi?id=32973

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/style/unittests.py: Added.
03:44 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:40 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:35 Changeset [52915] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-07 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Some IDL files lack "," separators for extended attributes.
https://bugs.webkit.org/show_bug.cgi?id=33190

To find such mistakes, IDLParser.pm rejects whitespace characters in
extended attribute names.

  • bindings/scripts/IDLParser.pm: parseExtendedAttributes rejects whitespace in a name.
  • css/WebKitCSSTransformValue.idl: Add missing ",".
  • dom/EventTarget.idl: ditto.
03:29 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:26 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:24 Changeset [52914] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] need an API to suspend and resume active Javascript DOM objects.
https://bugs.webkit.org/show_bug.cgi?id=31673

Patch by Yongjun Zhang <yongjun.zhang@nokia.com>, Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2010-01-07
Reviewed by Simon Hausmann.

Add suspend and resume DOM objects private API to QWebFrame.

  • Api/qwebframe.cpp:

(qt_suspendActiveDOMObjects):
(qt_resumeActiveDOMObjects):

02:52 Changeset [52913] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-07 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
WebKitCSSTransformValue.idl correctly.
https://bugs.webkit.org/show_bug.cgi?id=33193

CodeGeneratorV8.pm doesn't handle inheritance very well and it
tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
which does not exist. Because WebKitCSSTransformValue inherits
CSSValueList and CSSValueList already has HadIndexGetter, we don't
need to do anything for WebKitCSSTransformValue about HasIndexGetter.

  • bindings/scripts/CodeGeneratorV8.pm: Reset $hasGetter for WebKitCSSTransformValue.
02:22 Changeset [52912] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Don't print a redundant message when confirming a diff
https://bugs.webkit.org/show_bug.cgi?id=33315

Instead of saying "ERROR: User declined" we should just exit because
the use knows they just declined!

  • Scripts/webkitpy/steps/confirmdiff.py:
02:19 Changeset [52911] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Holger Freyther.

[Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
https://bugs.webkit.org/show_bug.cgi?id=33312

Remove pByte (committed in r42344 from #20422), because pByte doesn't
exist and it is unnecessary.

  • wtf/FastMalloc.cpp: (WTF::TCMallocStats::realloc):
02:12 Changeset [52910] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Check style before uploading a patch
https://bugs.webkit.org/show_bug.cgi?id=33314

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/steps/checkstyle.py:
  • Scripts/webkitpy/steps/options.py:
01:51 Changeset [52909] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add prepare and post to webkit-patch main help
https://bugs.webkit.org/show_bug.cgi?id=33313

  • Scripts/webkitpy/commands/upload.py:
00:57 Changeset [52908] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
https://bugs.webkit.org/show_bug.cgi?id=33290

Add the Chromium builders to our list of core builders and test that our regexps work.
I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.

  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/buildbot_unittest.py:
00:49 Changeset [52907] by abarth@webkit.org
  • 13 edits
    1 move in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool needs a new name
https://bugs.webkit.org/show_bug.cgi?id=28459

Rename bugzilla-tool to webkit-patch. Also, rename some commands to
make more sense with the new name.

  • Scripts/bugzilla-tool: Removed.
  • Scripts/webkit-patch: Added.
  • Scripts/webkit-tools-completion.sh:
  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/download_unittest.py:
  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/queueengine.py:
  • Scripts/webkitpy/steps/completerollout.py:
00:36 Changeset [52906] by eric@webkit.org
  • 3 edits
    6 moves
    1 add in trunk/WebKitTools

2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Moved style-related modules to webkitpy.style sub-package.

https://bugs.webkit.org/show_bug.cgi?id=32971

  • Scripts/check-webkit-style:
    • Updated import statement.
  • Scripts/test-webkitpy:
    • Updated import statements.
  • Scripts/webkitpy/cpp_style.py: Removed.
    • Moved to webkitpy/style.
  • Scripts/webkitpy/cpp_style_unittest.py: Removed.
    • Moved to webkitpy/style.
  • Scripts/webkitpy/style.py: Removed.
    • Moved to webkitpy/style/checker.py.
  • Scripts/webkitpy/style/init.py: Added.
    • Added containing webkitpy directory to package search path.
  • Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
  • Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
    • Updated import statement.
  • Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
  • Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
    • Update import statement.
  • Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
  • Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
  • Scripts/webkitpy/style_unittest.py: Removed.
    • Moved to webkitpy/style/checker_unittest.py.
  • Scripts/webkitpy/text_style.py: Removed.
    • Moved to webkitpy/style.
  • Scripts/webkitpy/text_style_unittest.py: Removed.
    • Moved to webkitpy/style.
00:22 Changeset [52905] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-07 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Do not return strings whose handles are in near death state (that means
they might be GCed) or just empty.
https://bugs.webkit.org/show_bug.cgi?id=31180

  • bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):
00:06 Changeset [52904] by eric@webkit.org
  • 18 edits
    4 adds in trunk

2010-01-06 MORITA Hajime <morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

SVG background color on selected text goes wrong when text has
gradient stroke.
https://bugs.webkit.org/show_bug.cgi?id=33069

Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
and paint background and foreground in separate subphase.

  • svg/text/selection-background-color.xhtml: Added.
  • platform/mac/svg/text/selection-background-color-expected.checksum: Added.
  • platform/mac/svg/text/selection-background-color-expected.png: Added.
  • platform/mac/svg/text/selection-background-color-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.png:
  • platform/mac/svg/batik/text/textDecoration2-expected.checksum:
  • platform/mac/svg/batik/text/textDecoration2-expected.png:
  • platform/mac/svg/text/text-deco-01-b-expected.checksum:
  • platform/mac/svg/text/text-deco-01-b-expected.png:
  • platform/mac/svg/text/text-spacing-01-b-expected.checksum:
  • platform/mac/svg/text/text-spacing-01-b-expected.png:
  • platform/mac/svg/text/text-text-03-b-expected.checksum:
  • platform/mac/svg/text/text-text-03-b-expected.png:
  • platform/mac/svg/text/text-text-08-b-expected.checksum:
  • platform/mac/svg/text/text-text-08-b-expected.png: Re-baselined due to painting algorithm change.

2010-01-06 MORITA Hajime <morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

SVG background color on selected text goes wrong when text has
gradient stroke.
https://bugs.webkit.org/show_bug.cgi?id=33069

Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
and paint background and foreground in separate subphase.

Test: svg/text/selection-background-color.xhtml

  • rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): Added m_setupBackgroundCallback, m_setupForegroundCallback (WebCore::SVGTextChunkWalker::setupBackground): (WebCore::SVGTextChunkWalker::setupForeground): Added.
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintCharacters): pass SVGTextPaintInfo instead of SVGPaintServer
  • rendering/SVGInlineTextBox.h: (WebCore::SVGTextPaintSubphase): (WebCore::SVGTextPaintInfo::SVGTextPaintInfo): Added.
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::walkTextChunks): Invoke setupBackground() and setupForeground() (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupBackgroundCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupForegroundCallback): (WebCore::SVGRootInlineBoxPaintWalker::activePaintServer): Added. (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::SVGRootInlineBox::paint):

01/06/10:

23:07 Changeset [52903] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-01-06 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Return an invalid Qt::ImMicroFocus if queried while the view needs to layout.

https://bugs.webkit.org/show_bug.cgi?id=33204

  • Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
22:12 Changeset [52902] by tkent@chromium.org
  • 7 edits in trunk

2010-01-06 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Eric Seidel.

Remove fast/events/keydown-numpad-key.html from the Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=33250

  • platform/qt/Skipped:

2010-01-06 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Eric Seidel.

Make windowsKeyCodeForKeyEvent() return correct key code for
numeric-pad arrow keys.
https://bugs.webkit.org/show_bug.cgi?id=33250

Test: fast/events/keydown-numpad-keys.html

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):

2010-01-06 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Eric Seidel.

[Qt] Support the 3rd argument of EventSender.keyDown that
has been recently added to report keyLocation
(see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
https://bugs.webkit.org/show_bug.cgi?id=33250

Test: fast/events/keydown-numpad-keys.html

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
  • DumpRenderTree/qt/EventSenderQt.h:
22:00 Changeset [52901] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-06 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add long_help for all common commands.
https://bugs.webkit.org/show_bug.cgi?id=33261

For now these long_helps are pretty basic.
These were all written to just explain the steps
that each command runs. This style long_help could
be made easier by using:
https://bugs.webkit.org/show_bug.cgi?id=33257

  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/queries.py:
21:30 Changeset [52900] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-10-18 Patrick Gansterer <paroga@paroga.com>

Reviewed by Dirk Schulze.

Improve DOM performance in large SVG files.
Check the dirty area before painting a path, which prevents unnecessary
clipping and changes to the GraphicsContext.
https://bugs.webkit.org/show_bug.cgi?id=30055

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
20:45 Changeset [52899] by tkent@chromium.org
  • 3 edits in trunk/WebCore

2010-01-06 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Use a static HashMap for HTMLElement::tagPriority().
https://bugs.webkit.org/show_bug.cgi?id=33269

The prior code compares AtomicStringImpl pointers 18 times at
worst. This change avoids it.

No new tests because this is just a refactoring.

  • html/HTMLElement.cpp: (WebCore::Empty1IntHashTraits): A HashTraits to return 1 as the empty value. (WebCore::initializeTagPriorityMap): Initialization of a static HashMap. (WebCore::HTMLElement::tagPriority): Use the static HashMap created by initializeTagPriorityMap().
  • html/HTMLElement.h: (WebCore::HTMLElement::HTMLElement): Add an assertion about non-null localName().
20:06 Changeset [52898] by eric@webkit.org
  • 5 edits in trunk

2010-01-06 Mike Belshe <mike@belshe.com>

Add a flag to the ResourceResponse for tracking if a request was
fetched via SPDY. This is plumbed through so that we can inform
a webpage via JavaScript if it was fecthed via the experimental
SPDY protocol.

https://bugs.webkit.org/show_bug.cgi?id=33186

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::wasFetchedViaSpdy): (WebCore::ResourceResponse::setWasFetchedViaSpdy):

2010-01-06 Mike Belshe <mike@belshe.com>

Add a flag to the ResourceResponse for tracking if a request was
fetched via SPDY. This is plumbed through so that we can inform
a webpage via JavaScript if it was fecthed via the experimental
SPDY protocol.

https://bugs.webkit.org/show_bug.cgi?id=33186

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasFetchedViaSpdy): (WebKit::WebURLResponse::setWasFetchedViaSpdy):
20:01 Changeset [52897] by tonikitoo@webkit.org
  • 5 edits in trunk

[Qt] Add page zooming support to Qt DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=32898

Patch by Kim Grönholm <kim.gronholm@nomovok.com>,

Diego Gonzalez <diego.gonzalez@openbossa.org> and
Afonso Costa <afonso.costa@openbossa.org> on 2010-01-06

Reviewed by Kenneth Christiansen.

WebKitTools:

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::zoomPageIn):
(EventSender::zoomPageOut):

  • DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

  • platform/qt/Skipped:
19:37 Changeset [52896] by eric@webkit.org
  • 5 edits in trunk

2010-01-06 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Treat.

[Qt] RenderTheme: Missing support for native sliders

https://bugs.webkit.org/show_bug.cgi?id=33122

Implement painting of native slider controls in RenderTheme
and unskip a couple of layout tests that are passing after
this change.

  • platform/qt/Skipped:

2010-01-06 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Treat.

[Qt] RenderTheme: Missing support for native sliders

https://bugs.webkit.org/show_bug.cgi?id=33122

Implement painting of native slider controls in RenderTheme
and unskip a couple of layout tests that are passing after
this change.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintSliderTrack): (WebCore::RenderThemeQt::adjustSliderTrackStyle): (WebCore::RenderThemeQt::paintSliderThumb): (WebCore::RenderThemeQt::adjustSliderThumbStyle): (WebCore::RenderThemeQt::supportsFocus): (WebCore::RenderThemeQt::adjustSliderThumbSize):
  • platform/qt/RenderThemeQt.h:
19:23 Changeset [52895] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-06 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Darin Adler.

Adjust incorrect comments after r40534.

  • bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext):
18:57 Changeset [52894] by ukai@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for chromium.
Add "bool V8WorkerContext::WebSocketEnabled()"

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::WebSocketEnabled):

18:45 Changeset [52893] by ukai@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed build fix.
remove wrong assertion

  • websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):

18:33 Changeset [52892] by ukai@chromium.org
  • 20 edits
    2 copies
    9 adds in trunk

2010-01-06 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin

Add WebSocket feature in Worker
https://bugs.webkit.org/show_bug.cgi?id=32214

  • websocket/tests/workers/resources/simple_wsh.py: Copied from LayoutTests/websocket/tests/simple_wsh.py.
  • websocket/tests/workers/resources/worker-simple.js: Added.
  • websocket/tests/workers/worker-simple-expected.txt: Added.
  • websocket/tests/workers/worker-simple.html: Added.

2010-01-06 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Add WebSocket feature in Worker
https://bugs.webkit.org/show_bug.cgi?id=32214

Introduce ThreadableWebSocketChannel interface and add
WorkerThreadableWebSocketChannel for Worker.
WorkerThreadableWebSocketChannel uses WebSocketChannel in the
main thread, which is managed by Peer and communicated via Bridge.

Test: websocket/tests/workers/worker-simple.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebSocketConstructor.h:
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::webSocket):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
  • bindings/v8/custom/V8WebSocketCustom.cpp: (WebCore::V8Custom::v8WebSocketConstructorCallback):
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • platform/CrossThreadCopier.cpp: (WebCore::::copy):
  • platform/CrossThreadCopier.h: (WebCore::):
  • websockets/ThreadableWebSocketChannel.cpp: Added.
  • websockets/ThreadableWebSocketChannel.h: Added.
  • websockets/ThreadableWebSocketChannelClientWrapper.h: Added.
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect): (WebCore::WebSocket::didReceiveMessage):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.h: (WebCore::WebSocketChannel::refThreadableWebSocketChannel): (WebCore::WebSocketChannel::derefThreadableWebSocketChannel):
  • websockets/WebSocketChannelClient.h:
  • websockets/WebSocketHandshake.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp: Added.
  • websockets/WorkerThreadableWebSocketChannel.h: Added.
  • workers/WorkerContext.idl:
18:20 Changeset [52891] by eric@webkit.org
  • 7 edits in trunk

2010-01-06 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Darin Adler.

Modified EventSource event-stream parser to support a single CR as line ending.
Updated test accordingly.
https://bugs.webkit.org/show_bug.cgi?id=33207

  • http/tests/eventsource/eventsource-parse-event-stream-expected.txt:
  • http/tests/eventsource/eventsource-parse-event-stream.html:
  • http/tests/eventsource/resources/event-stream.php:

2010-01-06 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Darin Adler.

Modified EventSource event-stream parser to support a single CR as line ending.
https://bugs.webkit.org/show_bug.cgi?id=33207

  • page/EventSource.cpp: (WebCore::EventSource::EventSource): (WebCore::EventSource::parseEventStream):
  • page/EventSource.h:
18:05 Changeset [52890] by eric@webkit.org
  • 5 edits in trunk

2010-01-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getInterfaceMaskFromObject): (getPangoLayoutForAtk): (webkit_accessible_text_get_text):
  • accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):

2010-01-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text

  • tests/testatk.c (test_webkit_atk_get_text_at_offset): (test_webkit_atk_get_text_at_offset_forms): (test_webkit_atk_get_text_at_offset_newlines):
18:04 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
17:41 Changeset [52889] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/7488126> With text-rendering: optimizelegibility, sometimes lines run too long
https://bugs.webkit.org/show_bug.cgi?id=32794

Reviewed by Sam Weinig.

WebCore:

Test: platform/mac/fast/text/line-breaking-with-kerning.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak): When kerning is enabled, include
the trailing space when measuring a word, then subtract its width. This
accounts for kerning between the last glyph of the word and the following space.

LayoutTests:

  • platform/mac/fast/text/line-breaking-with-kerning-expected.checksum: Added.
  • platform/mac/fast/text/line-breaking-with-kerning-expected.png: Added.
  • platform/mac/fast/text/line-breaking-with-kerning-expected.txt: Added.
  • platform/mac/fast/text/line-breaking-with-kerning.html: Added.
17:33 Changeset [52888] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-06 Eric Seidel <eric@webkit.org>

No review.

REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33256

I am unable to reproduce this failure locally, so this fix is only speculative.
Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html

  • platform/mac/Skipped:
17:29 Changeset [52887] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Simon Fraser.

Third step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView getVariable:value:]): Add case for WKNVSupportsCompositingCoreAnimationPluginsBool.
17:14 Changeset [52886] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-06 Eric Seidel <eric@webkit.org>

No review, just adding Mike Belshe's new bugzilla email at his request.

  • Scripts/webkitpy/committers.py:
17:01 Changeset [52885] by kdecker@apple.com
  • 9 edits in trunk

Reviewed by Simon Fraser

Second step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

  • Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginLayer]): Added.
  • Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginLayer]): Added. Reviewed by Simon Fraser.

Second step of:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism

  • Plugins/Hosted/WebHostedNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginLayer]): Added.
  • Plugins/WebNetscapePluginView.h: Expose the CALayer of the plugin by adding -pluginLayer method.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginLayer]): Added.
16:50 Changeset [52884] by abarth@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix screwed up ChangeLog about screwing up... Sigh.

16:48 Changeset [52883] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-06 Eric Seidel <eric@webkit.org>

No review.

REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33256

I am unable to reproduce this failure locally, so this fix is only speculative.
Skip the test we believe is causing the log message which bleeds into fast/workers/shared-worker-constructor.html

  • platform/mac/Skipped:
16:47 Changeset [52882] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2010-01-06 Adam Barth <abarth@webkit.org>

No review, rolling out r52877.
http://trac.webkit.org/changeset/52877
https://bugs.webkit.org/show_bug.cgi?id=33243

I screwedd up landing this patch and only partially applied the patch I
was trying to land.

  • bindings/ScriptControllerBase.cpp:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::mainWorldWindowShell): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::clearForClose): (WebCore::ScriptController::destroyWindowShell): (WebCore::ScriptController::updateDocument):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::proxy): (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell): (WebCore::ScriptController::evaluateInWorld):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::initContextIfNeeded):
16:30 Changeset [52881] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-01-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Carlson.

media/video-seeking.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33273

Removed setTimeouts from this test. It kind of looks
like they were intentional, but I don't see how they add
anything to this test (other than race conditions).

  • media/video-seeking-expected.txt:
  • media/video-seeking.html:
16:26 Changeset [52880] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-06 Eric Seidel <eric@webkit.org>

Unreviewed. Rolling back in a change I should not have rolled out.

The original commit http://trac.webkit.org/changeset/52862
was rolled out again in http://trac.webkit.org/changeset/52871
but I now believe that rollout to be in error.
My sincerest apologies for the churn.

Fix the bug in previous commit: we shouldn't finish
decoding if "sizeOnly" is true.
https://bugs.webkit.org/show_bug.cgi?id=33258

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
16:24 Changeset [52879] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-01-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

fast/css/transition-color-unspecified.html and fast/dom/HTMLObjectElement/object-as-frame.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=33270

These both rely on setTimeouts where they should be using events.

  • fast/css/transition-color-unspecified.html:
  • fast/dom/HTMLObjectElement/object-as-frame.html:
16:21 Changeset [52878] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

platform/chromium/fast/dom/interval.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33274

We're seeing the debug bots take >100000 microseconds to stop
and Interval.

  • platform/chromium/fast/dom/interval.html:
16:16 Changeset [52877] by abarth@webkit.org
  • 6 edits in trunk/WebCore

2010-01-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[v8] Let ScriptController have more than one windowShell
https://bugs.webkit.org/show_bug.cgi?id=33243

This patch lets ScriptController have more than one windowShell. We're
currently only using one of them (for the main world), but this patch
lets us use other ones for isolated worlds soon.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScriptInWorld):
  • bindings/js/ScriptController.cpp:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::createWorld): (WebCore::ScriptController::initScript): (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::mainWorldWindowShell): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::clearForClose): (WebCore::ScriptController::destroyWindowShell): (WebCore::ScriptController::updateDocument):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell): (WebCore::ScriptController::globalObject): (WebCore::ScriptController::proxy):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::create): (WebCore::V8DOMWindowShell::V8DOMWindowShell): (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
15:56 Changeset [52876] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-06 Eric Seidel <eric@webkit.org>

Unreviewed. Rolling out r52869 and r52853 due to bot
and local run-webkit-test failures

REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33256

The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153

  • Scripts/run-webkit-tests:
15:20 Changeset [52875] by mrowe@apple.com
  • 5 edits in trunk

Fix the Mac build.

  • WebCore.base.exp: Export symbols WebKit would like to use.
  • plugins/PluginWidget.h:

(WebCore::PluginWidget::PluginWidget): Redeclare a constructor.

15:09 Changeset [52874] by weinig@apple.com
  • 2 edits in trunk/WebKit/mac

Attempt to fix non-Snow Leopard Mac build.

  • WebCoreSupport/WebFrameLoaderClient.mm:
14:25 Changeset [52873] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-06 Eric Seidel <eric@webkit.org>

Unreviewed "build" fix. Just adding missing include.

bugzilla-tool rollout --complete-rollout should make a nicer bug comment
https://bugs.webkit.org/show_bug.cgi?id=29212

  • Scripts/webkitpy/steps/completerollout.py:
14:23 Changeset [52872] by kdecker@apple.com
  • 5 edits
    2 adds in trunk

Reviewed by Eric Carlson.


First step toward:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism


Small refactoring moving the PluginWidget class from WebKit to WebCore.

  • WebCore.xcodeproj/project.pbxproj: Added new source files and a "mac" group; exposes PluginWidget.h as a "Private" role
  • platform/Widget.h: Added isPluginWidget(). (WebCore::Widget::isPluginWidget):
  • plugins/PluginWidget.h: Added. (WebCore::PluginWidget::isPluginWidget): Added as an interim solution until Mac plug-ins inheirt from PluginView.
  • plugins/mac/PluginWidgetMac.mm: Added. (WebCore::PluginWidget::invalidateRect): Added. Extracted from the old WebKit/FrameLoaderClientMac version of PluginWidget

Reviewed by Eric Carlson.

First step toward:
<rdar://problem/6398111> Integrate hardware layers with out-of-process plug-ins layer hosting mechanism


Small refactoring moving the PluginWidget class from WebKit to WebCore.

  • WebCoreSupport/WebFrameLoaderClient.mm: Use the WebCore version of PluginWidget.
14:20 Changeset [52871] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-06 Eric Seidel <eric@webkit.org>

No review, rolling out r52862.
http://trac.webkit.org/changeset/52862
https://bugs.webkit.org/show_bug.cgi?id=33258

Caused svg/W3C-SVG-1.1/linking-a-01-b.svg to crash on the
Leopard Release builder.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
14:14 Changeset [52870] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-06 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool rollout --complete-rollout should make a nicer bug comment
https://bugs.webkit.org/show_bug.cgi?id=29212

  • Scripts/webkitpy/bugzilla.py:
    • Make reopen_bug robust against the bug already being open.
  • Scripts/webkitpy/commands/download.py:
    • Remove dead code from Rollout.
  • Scripts/webkitpy/steps/completerollout.py:
    • Improve the rollout comment.
14:12 Changeset [52869] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu>

Reviewed by Darin Adler.

Set isHttpdOpen to 0 if pidfile does not exist for some reason.
Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.

  • Scripts/run-webkit-tests:
14:04 Changeset [52868] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Revert the part of my last commit touching Base.xcconfig, was not meant to be commited.

  • Configurations/Base.xcconfig:
14:02 WebKit Team edited by treat@kde.org
(diff)
13:37 Changeset [52867] by japhet@chromium.org
  • 12 edits
    1 delete in trunk/WebCore

2010-01-05 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Generate header declarations for V8 binding security checks
and delete V8CustomBinding.cpp

  • Android.v8bindings.mk: Removed V8CustomBinding.cpp.
  • WebCore.gypi: Removed V8CustomBinding.cpp.
  • bindings/scripts/CodeGeneratorV8.pm: Generate security check declarations.
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::getTargetFrame): Moved from V8CustomBinding.cpp. (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::createNewContext): (WebCore::V8DOMWindowShell::setLocation): Moved from V8CustomBinding.cpp.
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::downcastSVGPathSeg): Moved from V8CustomBinding.cpp. (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::getTemplate):
  • bindings/v8/custom/V8CustomBinding.cpp: Removed.
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::locationAccessorSetter): (WebCore::V8DOMWindow::namedSecurityCheck): (WebCore::V8DOMWindow::indexedSecurityCheck):
  • bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorSetter):
  • bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::indexedSecurityCheck): (WebCore::V8History::namedSecurityCheck):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::indexedSecurityCheck): (WebCore::V8Location::namedSecurityCheck):
13:26 Changeset [52866] by zimmermann@webkit.org
  • 42 edits
    15 adds in trunk

2010-01-06 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Marker code is buggy: referencePoint translation is off
https://bugs.webkit.org/show_bug.cgi?id=33012

Rewrite marker code, as it had many issues:

  • Correct refX/refY handling (covered by new marker-referencePoint.svg test)
  • Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
  • Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
  • Fix SVGResource assuming that there is only one resource per resource type per element. Markers can have three different resources of the same type (three markers, start/mid/end markers)

Filed bug 33115 (PathElementAddQuadCurveToPoint not handled for <marker>), which was just a TODO in the code before.

Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
Test: svg/custom/marker-referencePoint.svg

svg/custom/marker-opacity.svg
svg/custom/marker-strokeWidth-changes.svg

  • Android.mk: Add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to build.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/FrameView.cpp: Notify RenderSVGRoot children about viewport size changes, just like it's handled for <body> in HTML. (WebCore::FrameView::layout): This is important, as marker bounding boxes may depend on the current viewport size through relative coordinates used in <svg>.
  • rendering/RenderPath.cpp: (WebCore::RenderPath::markerBoundingBox): Calculates and caches marker boundaries in the layout() phase. (WebCore::RenderPath::repaintRectInLocalCoordinates): Use the cached marker bounding box during paint() time. (WebCore::RenderPath::setPath): Clear marker boundaries upon path changes. (WebCore::RenderPath::paint): Use SVGMarkerLayoutInfo::drawMarkers() instead of the local drawMarkersIfNeeded() function, which is gone now. (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Utilized by markerBoundingBox() to request SVGResourceMarker objects and calculate their boundaries.
  • rendering/RenderPath.h: Store SVGMarkerLayoutInfo objects, and rename m_markerBounds to m_cachedLocalMarkerBBox for consistency. (WebCore::RenderPath::path): Inline this accessor.
  • rendering/RenderSVGContainer.h: Make paint() public (to be used from SVGResourceMarker), all other methods protected (to be used from RenderSVGViewportContainer).
  • rendering/RenderSVGViewportContainer.cpp: Remove useless paint() override, as the comment in the code indicated. (WebCore::RenderSVGViewportContainer::markerBoundaries): Maps the marker contents repaintRectInLocalCoordinates() into the final coordinate system (see code). (WebCore::RenderSVGViewportContainer::markerContentTransformation): Add marker-specific helper method, allowing to make viewportTransform() private again.
  • rendering/RenderSVGViewportContainer.h: Marking viewportTransform() private, it's never meant to be used outside this renderer.
  • rendering/SVGMarkerData.h: Added. Refactored from existing RenderPath code, preserving original copyrights. (WebCore::SVGMarkerData::): Helper struct for SVGMarkerLayoutInfo. (WebCore::SVGMarkerData::origin): Holds the final computed destination of a marker. (WebCore::SVGMarkerData::marker): Holds a pointer to the associated SVGResourceMarker object, which we're aiming to layout. (WebCore::SVGMarkerData::currentAngle): Calculates the current angle for a certain marker type (start/mid/end) based upon the computed inslope/outslope values. (WebCore::SVGMarkerData::updateTypeAndMarker): Helper method. (WebCore::SVGMarkerData::updateOutslope): Ditto. (WebCore::SVGMarkerData::updateMarkerDataForPathElement): Does the actual inslope/outslope calculation. (WebCore::SVGMarkerData::updateInslope): Helper method.
  • rendering/SVGMarkerLayoutInfo.cpp: Added. New approach to build marker layout info, this time correct during layout() time instead of paint() time. (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo): (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo): (WebCore::processStartAndMidMarkers): Static helper method used to visit each path element in order to calculate inslopes/outslopes (-> orientation angles) (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): Build list of MarkerLayout objects, used to query boundaries, and to paint markers during drawMarkers(). (WebCore::SVGMarkerLayoutInfo::drawMarkers): Cheap method walking existing MarkerLayout vector, drawing the individual RenderSVGViewportContainer of the markers. (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker): Helper method.
  • rendering/SVGMarkerLayoutInfo.h: Added. (WebCore::MarkerLayout::MarkerLayout): Helper struct storing a pair of SVGResourceMarker* and a TranformationMatrix. (WebCore::SVGMarkerLayoutInfo::markerData): Public helper methods returning references to private member variables, used from processStartAndMidMarkers. (WebCore::SVGMarkerLayoutInfo::midMarker): Ditto. (WebCore::SVGMarkerLayoutInfo::elementIndex): Ditto.
  • svg/SVGMarkerElement.cpp: Adopt to name change: setRef() -> setReferencePoint(). setMarker() -> setRenderer() (WebCore::SVGMarkerElement::~SVGMarkerElement): Remove obsolete detach() hack, fixed by SVGUseElement changes. (WebCore::SVGMarkerElement::canvasResource): Add ASSERT(renderer()) to clarify that canvasResource() is only meant to used after renderer creation.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::~SVGSVGElement): Remove obsolete detach() hack, fixed by SVGUseElement changes.
  • svg/SVGUseElement.cpp: Rework buildPendingResource() to remove SVGSVGElement/SVGMarkerElement detach() hacks (called manually from destructors), see below. (WebCore::SVGUseElement::buildPendingResource): Always detach() the shadow tree root element, before destructing it - this caused the regression with this patch before.
  • svg/graphics/SVGResource.cpp: Instead of maintaining a global hashmap between SVGStyledElements and an array of possible SVGResources, use a HashSet of SVGResources

and directly scan the already existing list of clients for a certain SVGResource. This wrong approach has been introduced over two years
ago, making the assumption that there's only one resource type per element. Though markers can provide three resources of the same type
per element (all SVGResourceMarker objects, but in different rules: start/mid/end marker). That information is only available while painting.

(WebCore::resourceSet): Add global static HashSet<SVGResource*>.
(WebCore::SVGResource::SVGResource): Add us to the resourceSet.
(WebCore::SVGResource::~SVGResource): Remove us from resourceSet.
(WebCore::SVGResource::removeClient): Traverse all SVGResource clients and remove the passed SVGStyledElement from the client list (invoked by SVGStyledElement destructor).
(WebCore::SVGResource::addClient): Remove the offending part of the old approach, making the wrong assumption regarding resource types.

  • svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::markerTransformation): Create TransformationMatrix in the local marker content (RenderSVGViewportContainer) coordinate system, to position a marker. (WebCore::SVGResourceMarker::draw): Simplify marker drawing a lot: used the passing TransformationMatrix (cached in SVGMarkerLayoutInfo) to draw the marker content renderer. (WebCore::SVGResourceMarker::externalRepresentation): Adopt to refX/refY -> referencePoint changes.
  • svg/graphics/SVGResourceMarker.h: Store a FloatPoint m_referecePoint instead of two refX/refY float values. (WebCore::SVGResourceMarker::setRenderer): Renamed from setMarker(). (WebCore::SVGResourceMarker::setReferencePoint): Renamed from setRef(). (WebCore::SVGResourceMarker::referencePoint): New accessor replacing refX() / refY().
13:10 Changeset [52865] by krit@webkit.org
  • 26 edits in trunk

2010-01-06 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage support
https://bugs.webkit.org/show_bug.cgi?id=31905

This implements the SVG Filter effect feImage with support of fragment urls.
It also includes a bug fix for feComposite. feComposite didn't cover values
bigger than 255 correctly on composite oeprator arithmetic.

Tests: There are already many feImage tests in trunk. They just needed updated

pixel test results.
The feComposite bug is covered by svg/W3C-SVG-1.1/filters-composite-02-b.svg
and depends on feImage.

  • platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGImage.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource): (WebCore::SVGFEImageElement::parseMappedAttribute): (WebCore::SVGFEImageElement::notifyFinished): (WebCore::SVGFEImageElement::build):
  • svg/SVGFEImageElement.h:
  • svg/SVGFEImageElement.idl:
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::transformRect):
  • svg/SVGPreserveAspectRatio.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::FEImage): (WebCore::FEImage::create): (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h:

2010-01-06 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage support
https://bugs.webkit.org/show_bug.cgi?id=31905

The implementation of feImage requires pixel test result updates of the already
available tests.

There is also an update for svg/filters/feComposite.svg, since the patch also
fixed a bug in feComposite.

  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.checksum:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.png:
  • platform/mac/svg/filters/feComposite-expected.checksum:
  • platform/mac/svg/filters/feComposite-expected.png:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:

2010-01-06 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage support
https://bugs.webkit.org/show_bug.cgi?id=31905

Update SVG status page. We support feDisplacementMap and feImage now.

  • projects/svg/status.xml:
12:26 Changeset [52864] by darin@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Added file James Robinson provided to go with his fix for
https://bugs.webkit.org/show_bug.cgi?id=32295

  • platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.
12:24 Changeset [52863] by darin@apple.com
  • 5 edits in trunk/LayoutTests

Some script tests have wrappers that don't match their templates
https://bugs.webkit.org/show_bug.cgi?id=33239

Reviewed by Eric Seidel.

  • fast/dom/StyleSheet/get-stylesheet-byname.html: Updated to use

a standard test wrapper instead of a custom one.

  • fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js:

Changed test to not depend on a non-standard wrapper.

  • fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Updated

results since I changed the test around.

  • platform/mac/editing/selection/script-tests/TEMPLATE.html: Fix

incorrect path in template that broke the test when we called
make-script-test-wrappers.

12:15 Changeset [52862] by yong.li@torchmobile.com
  • 2 edits in trunk/WebCore

2010-01-06 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Fix the bug in previous commit: we shouldn't finish
decoding if "sizeOnly" is true.
https://bugs.webkit.org/show_bug.cgi?id=33258

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::decode):
11:59 Changeset [52861] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Should be last part of Windows Build fix.

11:58 Changeset [52860] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-01-06 Eric Seidel <eric@webkit.org>

No review, rolling out r52855.
http://trac.webkit.org/changeset/52855
https://bugs.webkit.org/show_bug.cgi?id=33222

Caused 6 layout tests to fail on Mac

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h:
11:51 Changeset [52859] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

QT build fix.

  • runtime/Identifier.cpp:

(JSC::createIdentifierTableSpecific):

11:45 Changeset [52858] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix part I.

11:38 Changeset [52857] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

  • runtime/Identifier.cpp:

(JSC::createIdentifierTableSpecificCallback):

11:38 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
11:33 Changeset [52856] by barraclough@apple.com
  • 20 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=33236
Remove m_identifierTable pointer from UString

Reviewed by Sam Weinig.

JavaScriptCore:

Currently every string holds a pointer so that during destruction,
if a string has been used as an identifier, it can remove itself
from the table. By instead accessing the identifierTable via a
thread specific tracking the table associated with the current
globaldata, we can save the memory cost of this pointer.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

  • change the API shims to track the identifierTable of the current JSGlobalData.
  • API/JSContextRef.cpp:

(JSContextGroupCreate):

  • update creation of JSGlobalData for API usage to use new create method.
  • fix shim instanciation bug in JSGlobalContextCreateInGroup.

(JSC::checkSyntax):
(JSC::evaluate):

  • add asserts to check the identifierTable is being tracked correctly.
  • runtime/Identifier.cpp:

(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::Identifier::remove):
(JSC::Identifier::checkSameIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
(JSC::createDefaultDataSpecific):

  • Use currentIdentifierTable() instead of UStringImpl::m_identifierTable.
  • Define methods to access the thread specific identifier tables.
  • runtime/Identifier.h:

(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):

  • Declare methods to access the thread specific identifier tables.
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::createNonDefault):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):

  • creation of JSGlobalData objects, other than for API usage, associate themselves with the current thread.
  • runtime/JSGlobalData.h:
  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::destroy):

  • destroy() method should be using isIdentifier().
  • runtime/UStringImpl.h:

(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::UStringImpl):

  • replace m_identifierTable with a single m_isIdentifier bit.
  • wtf/StringHashFunctions.h:

(WTF::stringHash):

  • change string hash result from 32-bit to 31-bit, to free a bit in UStringImpl for m_isIdentifier.

JavaScriptGlue:

Add API shims similar to those used in the JSC API to track the current identifierTable.

  • JSBase.cpp:

(JSBase::Release):

  • JSUtils.cpp:

(JSObjectKJSValue):
(KJSValueToCFTypeInternal):
(unprotectGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

  • JSUtils.h:
  • JSValueWrapper.cpp:

(JSValueWrapper::JSObjectCopyPropertyNames):
(JSValueWrapper::JSObjectCopyProperty):
(JSValueWrapper::JSObjectSetProperty):
(JSValueWrapper::JSObjectCallFunction):
(JSValueWrapper::JSObjectCopyCFValue):

  • JavaScriptGlue.cpp:

(JSRunCreate):
(JSRunEvaluate):
(JSRunCheckSyntax):
(JSCollect):

  • JavaScriptGlue.xcodeproj/project.pbxproj:
  • UserObjectImp.cpp:

(UserObjectImp::callAsFunction):

10:25 Changeset [52855] by yong.li@torchmobile.com
  • 5 edits in trunk/WebCore

2010-01-06 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Let ReourceLoader deliver segmented data
when loading resource from a SharedBuffer object.
https://bugs.webkit.org/show_bug.cgi?id=33222

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveData):
  • loader/ResourceLoader.h:
03:14 Changeset [52854] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed trivial Qt build fix.

Prefix the phonon includes with phonon/ to avoid conflicts with the S60
audio routing API ( http://wiki.forum.nokia.com/index.php/Audio_Routing_API ).

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
02:02 Changeset [52853] by loki@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-06 Andras Becsi <abecsi@inf.u-szeged.hu>

Reviewed by Darin Adler.

Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
and remove the httpd's pidfile directory if httpd terminated.

  • Scripts/run-webkit-tests:
00:24 Changeset [52852] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-01-06 Darin Fisher <darin@chromium.org>

Fix release build bustage.

  • src/WebKit.cpp: Need to include Logging.h

01/05/10:

23:56 Changeset [52851] by darin@chromium.org
  • 7 edits
    2 adds in trunk/WebKit/chromium

2010-01-05 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Expose more APIs to eliminate WebCore usage in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=33249

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebGlyphCache.h: Added.
  • public/WebKit.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrame::instanceCount): (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl):
  • src/WebFrameImpl.h:
  • src/WebGlyphCache.cpp: Added. (WebKit::WebGlyphCache::pageCount):
  • src/WebKit.cpp: (WebKit::enableLogChannel):
23:31 Changeset [52850] by darin@chromium.org
  • 2 edits in trunk/WebCore

2010-01-05 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

Moving v8::HandleScope up above declaration of v8::Local to fix a
Chromium startup crash.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
22:37 Changeset [52849] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by David Levin.

Refactored check-webkit-style's argument parser to not rely
on global state, and improved its error handling and unit
test coverage.

https://bugs.webkit.org/show_bug.cgi?id=32966

  • Scripts/check-webkit-style:
    • Adjusted to use new argument parser.
  • Scripts/webkitpy/cpp_style.py:
    • Changed _CppStyleState to accept an array of filter rules instead of a comma-delimited string.
    • Eliminated cpp_style._DEFAULT_FILTER_RULES.
    • Eliminated cpp_style._USAGE.
  • Scripts/webkitpy/cpp_style_unittest.py:
    • Updated test_filter() and test_default_filter().
  • Scripts/webkitpy/style.py:
    • Converted style._USAGE to create_usage().
    • Corrected usage instructions by removing 0 as a valid --verbose flag value.
    • Removed use_webkit_styles().
    • Added ProcessorOptions class.
    • Added ArgumentDefaults class.
    • Added ArgumentPrinter class.
    • Removed parse_arguments and added ArgumentParser class.
    • Moved exit_with_usage() and exit_with_categories() into ArgumentParser.
    • Refactored parse_arguments() as ArgumentParser.parse().
    • Improved parser error handling.
  • Scripts/webkitpy/style_unittest.py:
    • Added DefaultArgumentsTest class.
    • Addressed FIXME to check style.WEBKIT_FILTER_RULES against style.STYLE_CATEGORIES.
    • Added ArgumentPrinterTest class.
    • Added ArgumentParserTest class and rewrote parser unit tests.
21:11 Changeset [52848] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Re-enable plug-in halting on Mac after r51953

Reviewed by Mark Rowe.

  • WebCoreSupport/WebPluginHalterClient.mm:

(WebPluginHalterClient::enabled): Test for the correct selector.

19:09 Changeset [52847] by abarth@webkit.org
  • 12 edits in trunk

2010-01-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[v8] Move V8DOMWindowShell to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=33232

This patch moves V8DOMWindow shell to ScriptController, where the
window shells live in JSC land. The next step will be to allow for
more than one window shell per script controller.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::mainWorldWindowShell): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::clearForClose): (WebCore::ScriptController::destroyWindowShell): (WebCore::ScriptController::updateDocument):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::~V8DOMWindowShell):
  • bindings/v8/V8DOMWindowShell.h: (WebCore::V8DOMWindowShell::localHandleForContext):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
  • bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::V8IsolatedContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::currentContext): (WebCore::V8Proxy::setContextDebugId):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::adjustedContext):

2010-01-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[v8] Move V8DOMWindowShell to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=33232

Update FrameLoaderClientImpl.cpp to call clearForClose on
ScriptController instead of on V8Proxy.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
18:57 Changeset [52846] by eric@webkit.org
  • 8 edits
    6 adds in trunk

2010-01-05 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Implement HTML5 <header> and <footer> elements.
https://bugs.webkit.org/show_bug.cgi?id=32943

These test:

  • <p> closing,
  • No nesting restriction,
  • Residual style, and
  • FormatBlock.
  • fast/html/footer-element-expected.txt: Added.
  • fast/html/footer-element.html: Added.
  • fast/html/header-element-expected.txt: Added.
  • fast/html/header-element.html: Added.
  • fast/html/script-tests/footer-element.js: Added.
  • fast/html/script-tests/header-element.js: Added.

2010-01-05 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Implement HTML5 <header> and <footer> elements.
https://bugs.webkit.org/show_bug.cgi?id=32943

<header> and <footer> should behave the same as <nav>, <section>,
<article>, and <aside>. The HTML parser doesn't need to restrict
the nesting of header/footer elements.

Tests: fast/html/footer-element.html

fast/html/header-element.html

  • css/html.css: Add header/footer as block elements.
  • editing/htmlediting.cpp: (WebCore::validBlockTag): Add headerTag and footerTag.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::tagPriority): Returns 5 for headerTag and footerTag. (WebCore::blockTagList): Add headerTag and footerTag.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Rename isHeaderTag() to isHeadingTag() (WebCore::HTMLParser::getNode): Add headerTag and footerTag. (WebCore::HTMLParser::isHeadingTag): Renamed from isHeaderTag().
  • html/HTMLParser.h:
    • Rename isHeaderTag() to isHeadingTag()
    • Remove non-existing popNestedHeaderTag().
  • html/HTMLTagNames.in: Add header and footer.
18:46 Changeset [52845] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-01-05 Rachel Petterson <rlp@google.com>

Reviewed by Adam Barth.

Matches the texImage2D and texSubImage2D functions to their
declarations. Elminates uncessary versions of those functions.
https://bugs.webkit.org/show_bug.cgi?id=31562
Also bug: https://bugs.webkit.org/show_bug.cgi?id=31493

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
18:07 Changeset [52844] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-05 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

CDATA sections are merged into Text nodes when normalize() is used
https://bugs.webkit.org/show_bug.cgi?id=33191

  • fast/dom/Node/normalize-with-cdata-expected.txt: Added.
  • fast/dom/Node/normalize-with-cdata.html: Added.
  • fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
18:06 Changeset [52843] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-05 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

CDATA sections are merged into Text nodes when normalize() is used
https://bugs.webkit.org/show_bug.cgi?id=33191

  • fast/dom/Node/normalize-with-cdata-expected.txt: Added.
  • fast/dom/Node/normalize-with-cdata.html: Added.
  • fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
18:05 Changeset [52842] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-01-05 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

CDATA sections are merged into Text nodes when normalize() is used
https://bugs.webkit.org/show_bug.cgi?id=33191

  • fast/dom/Node/normalize-with-cdata-expected.txt: Added.
  • fast/dom/Node/normalize-with-cdata.html: Added.
  • fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
18:03 Changeset [52841] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-01-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

animations/animation-drt-api-multiple-keyframes.html and animations/animation-drt-api.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=33244

Both these tests have a race condition. They start looking
for the animation start after the node is already rendered.
Instead, set the animation just before looking for the animation
start.

  • animations/animation-drt-api-multiple-keyframes.html:
  • animations/animation-drt-api.html:
17:35 Changeset [52840] by darin@apple.com
  • 3 edits
    3 adds in trunk

CDATA sections are merged into Text nodes when normalize() is used
https://bugs.webkit.org/show_bug.cgi?id=33191

Reviewed by Dan Bernstein.

WebCore:

Test: fast/dom/Node/normalize-with-cdata.html

  • dom/Node.cpp:

(WebCore::Node::normalize): Use nodeType instead of isTextNode.

LayoutTests:

  • fast/dom/Node/normalize-with-cdata-expected.txt: Added.
  • fast/dom/Node/normalize-with-cdata.html: Added.
  • fast/dom/Node/script-tests/normalize-with-cdata.js: Added.
17:13 Changeset [52839] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-01-05 James Robinson <jamesr@google.com>

Reviewed by Eric Seidel.

Typing in Google Wave repaints the whole screen
https://bugs.webkit.org/show_bug.cgi?id=32295

Add a repaint test to make sure that when mutations happen in a grandchild of a block element that has no in-flow children
the entire block element is not unnecessarily repainted.
The bug only shows up when running pixel tests.

  • fast/repaint/block-no-inflow-children.html: Added.
  • platform/mac/fast/repaint/block-no-inflow-children-expected.checksum: Added.
  • platform/mac/fast/repaint/block-no-inflow-children-expected.png: Added.
  • platform/mac/fast/repaint/block-no-inflow-children-expected.txt: Added.

2010-01-05 James Robinson <jamesr@google.com>

Reviewed by Eric Seidel.

Typing in Google Wave repaints the whole screen
https://bugs.webkit.org/show_bug.cgi?id=32295

Marks a RenderBlock without block children for layout and painting when it has no line boxes only if it has inline immediate children.
The existing logic uses the existence of line boxes as a dirty flag to indicate that line boxes need to be regenerated. This heuristic
fails when the RenderBlock does not have any in-flow children at all, causing the RenderBlock to get unnecessarily marked for layout and
painting. This is particularly bad for common scrollbar manipulation tricks like putting one positioned div inside another - this
structure caused the entire outer div's bounds to get scheduled for a paint whenever there was any mutation of any descendant.

Test: LayoutTests/fast/repaint/block-no-inline-children.html (only shows up in pixel tests)

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
16:07 Changeset [52838] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-01-05 James Robinson <jamesr@chromium.org>

Reviewed by David Hyatt.

Cleans up line box clearing when a RenderBlock loses its last child.
https://bugs.webkit.org/show_bug.cgi?id=33228

The 'fullLayout' flag in RenderBlock::layoutInlineChildren() is pretty vague, hopefully this will be easier for the next person to figure out.

No new tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
15:57 Changeset [52837] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

LayoutTests/animations/change-keyframes.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33233

The timing calculation was just off. It was starting the
second animation at 600ms and then checking to be half-way
done with the 1 second animation at 1000ms. Instead, just
modify the animation to run a bit earlier.

  • animations/change-keyframes.html:
15:53 Changeset [52836] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-05 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Provide the "documentURL" property for documents and frame owner elements

This is necessary to determine owner document URLs for nodes (all nodes have
the top-level document set as ownerDocument).
https://bugs.webkit.org/show_bug.cgi?id=33025

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode):
15:51 Changeset [52835] by cmarrin@apple.com
  • 3 edits in trunk/LayoutTests

Fixed a bug in testcase. Passing an empty array to texImage2D
now must be done with 'null' not '0'.

  • fast/canvas/webgl/script-tests/texImageTest.js:
  • fast/canvas/webgl/texImageTest-expected.txt:
15:42 Changeset [52834] by cmarrin@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

New test for texImage2d and texSubImage2d cases
New test for texImage2d using ImageData which tests rendering.
https://bugs.webkit.org/show_bug.cgi?id=31562
Also bug: https://bugs.webkit.org/show_bug.cgi?id=31493

15:22 Changeset [52833] by pkasting@chromium.org
  • 5 edits in trunk/WebCore

Public GIF decoder should stop decoding when allocation fails
https://bugs.webkit.org/show_bug.cgi?id=33231

Reviewed by Adam Barth.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::haveDecodedRow):

  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::output_row):
(GIFImageReader::do_lzw):
(GIFImageReader::read):

  • platform/image-decoders/gif/GIFImageReader.h:
15:13 Changeset [52832] by aroben@apple.com
  • 1 edit in trunk/WebKit/win/ChangeLog

Add missing Radar numbers

15:08 Changeset [52831] by yong.li@torchmobile.com
  • 4 edits in trunk/WebCore

2010-01-05 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Make PNG image decoder work with segmented SharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=33213

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create):
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::isAllDataReceived): (WebCore::ImageDecoder::setData):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): (WebCore::PNGImageReader::setComplete): (WebCore::PNGImageReader::decode): (WebCore::PNGImageDecoder::decode): (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::pngComplete):
15:07 Changeset [52830] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Make IWebView::close and destroying a WebView's HWND optional for WebKit clients

WebView will now take care of these operations itself when its last
reference is released, if they haven't already been done.

IWebView::close now also destroys the WebView's HWND. All WebKit
clients were already performing these operations in succession anyway,
or were attempting to by calling IWebView::close then destroying the
WebView's host window (which actually resulted in the WebView's HWND
leaking, and the crash in the below bug).

Fixes <http://webkit.org/b/32827> Crash when calling IWebView::close,
then releasing the WebView, without calling DestroyWindow

Fixes a few WebViewDestruction tests, too.

Reviewed by Steve Falkenburg.

  • WebView.cpp:

(WebView::~WebView): Don't try to destroy m_viewWindow here. That
should already have happened. Assert that this is the case.
(WebView::close): If m_viewWindow isn't already being destroyed,
destroy it now. Moved the call to revokeDragDrop() here from our
WM_DESTROY handler because it needs to be done before m_viewWindow is
nulled out.
(WebView::WebViewWndProc): Removed call to revokeDragDrop() that
close() now performs.
(WebView::Release): If our last reference is being released, call
close() so that clients don't have to. (It's harmless to call close()
multiple times.) We do this here instead of in the destructor because
close() can cause AddRef() and Release() to be called, and calling
those from within the destructor leads to double-destruction.
(WebView::setHostWindow): Removed an unnecessary (and now harmful)
null-check.
(WebView::revokeDragDrop): Changed an assertion into a run-time check,
since this will now sometimes be called when m_viewWindow hasn't been
created yet. Changed the IsWindow call to a null-check because we
never hold onto a destroyed m_viewWindow.
(WebView::windowAncestryDidChange): If we don't have a view window,
stop tracking changes to our parent's active state.

15:07 Changeset [52829] by aroben@apple.com
  • 4 edits in trunk

Make it safe to call IWebView::close when IWebView::initWithFrame hasn't been called

Part of <http://webkit.org/b/32827> Crash when calling
IWebView::close, then releasing the WebView, without calling
DestroyWindow

Reviewed by Steve Falkenburg.

WebKit/win:

  • WebView.cpp:

(WebView::close): Null-check m_page and m_preferences before using
them. They will be null if initWithFrame was never called.

WebKitTools:

Test that it's safe to call IWebView::close when IWebView::initWithFrame
hasn't been called

  • WebKitAPITest/tests/WebViewDestruction.cpp:

(WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
without ever calling IWebView::initWithFrame and tests that we don't
crash or leak.

15:07 Changeset [52828] by aroben@apple.com
  • 3 edits in trunk/WebKit/win

Add assertions to catch double-destruction of WebViews earlier

I basically copied the m_deletionHasBegun logic from WTF::RefCounted.

Fixes <http://webkit.org/b/33219>.

Reviewed by Darin Adler.

  • WebView.cpp:

(WebView::WebView): Initialize m_deletionHasBegun
(WebView::AddRef): Assert that deletion hasn't already begun.
(WebView::Release): Assert that deletion hasn't already begun, then
record when deletion *does* begin.

  • WebView.h: Added m_deletionHasBegun.
15:06 Changeset [52827] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Remove dead code in WebViewWndProc

Fixes <http://webkit.org/b/33218>.

Reviewed by Darin Adler.

  • WebView.cpp:

(WebView::WebViewWndProc): Removed a redundant isBeingDestroyed check.
We bail out much earlier in this function if isBeingDestroyed is true.

15:06 Changeset [52826] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Add more WebViewDestruction tests

Fixes <http://webkit.org/b/33216>.

Reviewed by Eric Seidel.

  • WebKitAPITest/tests/WebViewDestruction.cpp:

(WebKitAPITest::NoInitWithFrame):
(WebKitAPITest::CloseThenDestroyViewWindow):
(WebKitAPITest::DestroyViewWindowThenClose):
(WebKitAPITest::DestroyHostWindow):
(WebKitAPITest::DestroyHostWindowThenClose):
(WebKitAPITest::CloseThenDestroyHostWindow):
Added these tests that exercise tearing down a WebView in various
ways, all of which we eventually want to have work. Some of them
currently crash or leak.

14:45 Changeset [52825] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-05 Robert Hogan <robert@roberthogan.net>

Reviewed by Eric Seidel.

[Qt] fix DRT link failures on --no-svg builds when only making changes to DRT

If you're working from a --minimal or --no-svg build and make changes to the
DRT, then recompile, the build will fail.

This is because the current behavior at build time is to assume that the
previous Qt build supported SVG and consequently delete libQtWebKit.so.
Unfortunately, just deleting libQtWebKit.so will not cause the library to
re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
results in a link failure on the DRT.

Since re-linking libQtWebKit can take up to ten minutes and should be avoided
in cases where not actually required, remove the assumption that
the previous Qt build supported SVG, and amend the symbol detection to look for
a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.

https://bugs.webkit.org/show_bug.cgi?id=32992

  • Scripts/webkitdirs.pm:
14:30 Changeset [52824] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-12-25 Patrick Gansterer <paroga@paroga.com>

Reviewed by Eric Seidel.

Buildfix for WinCE + style fixes.
https://bugs.webkit.org/show_bug.cgi?id=32939

  • jsc.cpp: (functionPrint): (functionQuit): (parseArguments): (fillBufferWithContentsOfFile):
13:18 Changeset [52823] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-05 Adam Barth <abarth@webkit.org>

Rubber stamped by Dimitri Glazkov.

Fix namespace indent for ScriptController.

  • bindings/v8/ScriptController.h: (WebCore::ScriptController::proxy): (WebCore::ScriptController::windowShell): (WebCore::ScriptController::existingWindowShell): (WebCore::ScriptController::xssAuditor): (WebCore::ScriptController::setProcessingTimerCallback): (WebCore::ScriptController::setPaused): (WebCore::ScriptController::isPaused): (WebCore::ScriptController::sourceURL): (WebCore::ScriptController::evaluateInWorld):
12:48 Changeset [52822] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-05 Patrick Gansterer <paroga@paroga.com>

Reviewed by Eric Seidel.

WinCE buildfix after r52791 (renamed PLATFORM(WINCE) to OS(WINCE)).
https://bugs.webkit.org/show_bug.cgi?id=33205

  • jit/ExecutableAllocator.h:
12:40 Changeset [52821] by cmarrin@apple.com
  • 8 edits in trunk/WebCore

Implement most cases of texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=31562

12:37 Changeset [52820] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Part of <https://bugs.webkit.org/show_bug.cgi?id=32568>.
Web Inspector: Context Menus should be used in more places.

Reviewed by Tim Hatcher.

Add context menus to handle the interaction with breakpoints in the Source Frame. Currently
we use left click to add/disable/remove breakpoints, and left click to edit (for conditional
breakpoints), but this is hard to discover and behaves differently than Xcode.

Change the behavior to be more like Xcode, left click adds a breakpoint if there isn't one, and
removes it if there is one.

On the context menu, if there is no breakpoint there, we have Add Breakpoint, and Add Conditional
Breakpoint. If there is a breakpoint there, we add entries for Edit Breakpoint (edit
the condition), Remove Breakpoint, and Enable/Disable Breakpoint (based on the current state).

  • English.lproj/localizedStrings.js: Added localized context menu entries.
  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._documentContextMenu.addAndEditBreakpoint):
(WebInspector.SourceFrame.prototype._documentContextMenu): Added context menu entries and handlers.
(WebInspector.SourceFrame.prototype._documentMouseDown): Changed left click behavior (Add -> Remove).

12:34 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
12:33 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
12:32 Changeset [52819] by cfleizach@apple.com
  • 9 edits
    2 adds in trunk

AX: need a way to get the progress of a webpage load
https://bugs.webkit.org/show_bug.cgi?id=33221

Reviewed by Eric Seidel.

WebCore:

Test: platform/mac/accessibility/estimated-progress.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::estimatedLoadingProgress):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::estimatedLoadingProgress):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • platform/mac/accessibility/document-attributes-expected.txt:
  • platform/mac/accessibility/estimated-progress-expected.txt: Added.
  • platform/mac/accessibility/estimated-progress.html: Added.
  • platform/mac/accessibility/frame-with-title-expected.txt:
  • platform/mac/accessibility/frame-with-title.html:
12:17 Changeset [52818] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping three new tests.

11:51 Changeset [52817] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by David Kilzer.

Switched to generating list of Perl unit test files dynamically,
instead of explicitly.

https://bugs.webkit.org/show_bug.cgi?id=33200

  • Scripts/test-webkitperl:
11:44 Changeset [52816] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-05 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Reimplement EventSender::leapForward
https://bugs.webkit.org/show_bug.cgi?id=33114

Follow Windows implementation of leapForward. When leapForward is called,
messages are queued and posted after the timeout. A new event loop is created to
handle those messages and the additional messages that are created as a result.

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::EventSender): (EventSender::mouseDown): (EventSender::mouseUp): (EventSender::mouseMoveTo): (EventSender::leapForward): (EventSender::sendOrQueueEvent): (EventSender::replaySavedEvents): (EventSender::eventFilter):
  • DumpRenderTree/qt/EventSenderQt.h:
11:36 Changeset [52815] by eric@webkit.org
  • 6 edits in trunk

2010-01-05 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Drag & drop layout tests fail even when run manually
https://bugs.webkit.org/show_bug.cgi?id=33055

No new tests. Fix 3 layout tests when run manually.
fast/events/drag-and-drop.html
fast/events/drag-and-drop-dataTransfer-types-nocrash.html
fast/events/drag-and-drop-fire-drag-dragover.html
Running these tests in DRT will be fixed in 31332.

  • page/qt/DragControllerQt.cpp: (WebCore::DragController::cleanupAfterSystemDrag): Cleanup the drag operation if it failed to complete, Otherwise, new drag operations will not be possible.

2010-01-05 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Drag & drop layout tests fail even when run manually
https://bugs.webkit.org/show_bug.cgi?id=33055

No new tests. Fix 3 layout tests when run manually.
fast/events/drag-and-drop.html
fast/events/drag-and-drop-dataTransfer-types-nocrash.html
fast/events/drag-and-drop-fire-drag-dragover.html
Running these tests in DRT will be fixed in 31332.

  • Api/qwebpage.cpp: (dropActionToDragOp): (dragOpToDropAction): (QWebPagePrivate::dragEnterEvent): (QWebPagePrivate::dragMoveEvent): (QWebPagePrivate::dropEvent): Accept drag events even if they are not over a drop target. This is to ensure that drag events will continue to be delivered.
  • Api/qwebpage_p.h:
  • WebCoreSupport/DragClientQt.cpp: (WebCore::dragOperationToDropActions): (WebCore::dropActionToDragOperation): (WebCore::DragClientQt::startDrag): Send dragEnd event.
11:28 Changeset [52814] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-05 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Fix obscure queue crash in queueengine
https://bugs.webkit.org/show_bug.cgi?id=33196

Sometimes we get an exception that can't be stringified. For example:

AttributeError: 'ParseError' object has no attribute 'msg'

In these cases, the whole queue dies because we're in the global
exception handler. Instead of dieing here, we should just print a less
informative message to the console. We're already printing the whole
backtrace anyway, so there's not much point to stringifying the
exception anyway.

  • Scripts/webkitpy/queueengine.py:
11:08 Changeset [52813] by kov@webkit.org
  • 4 edits in trunk

Reviewed by Xan Lopez.

Based on idea and original patch by Evan Martin.

Remove libWebCore intermediate library, to improve link time.

[GTK] Build time must be reduced
https://bugs.webkit.org/show_bug.cgi?id=32921

11:06 Changeset [52812] by abarth@webkit.org
  • 8 edits in trunk/WebCore

2010-01-05 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Move allowSetting{Frame}SrcToJavascriptUrl from V8Custom to BindingSecurity and
remove the v8-specific pieces.

https://bugs.webkit.org/show_bug.cgi?id=33182

  • bindings/BindingSecurity.h: (WebCore::::allowSettingFrameSrcToJavascriptUrl): Moved from V8CustomBinding.cpp. (WebCore::::allowSettingSrcToJavascriptURL): Moved from V8CustomBinding.cpp.
  • bindings/v8/custom/V8AttrCustom.cpp: (WebCore::V8Attr::valueAccessorSetter):
  • bindings/v8/custom/V8CustomBinding.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeCallback): (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNSCallback): (WebCore::V8Element::setAttributeNodeNSCallback):
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp: (WebCore::V8HTMLFrameElement::srcAccessorSetter): (WebCore::V8HTMLFrameElement::locationAccessorSetter):
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: (WebCore::V8HTMLIFrameElement::srcAccessorSetter):
11:04 Changeset [52811] by abarth@webkit.org
  • 11 edits
    4 copies
    1 move
    1 add
    1 delete in trunk/WebCore

2010-01-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Separate DOMWrapperWorld from V8IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=33087

This change separate DOMWrapperWorld and IsolatedWorld from
V8IsolatedWorld. I've also renamed V8IsolatedWorld to
V8IsolatedContext in preparation for having more than one context in a
single isolated world.

This patch moves us closer to two goals:
1) Matching the structure of the JSC implementation of isolated worlds.
2) Letting scripts running in isolated contexts see into other iframes

(which requires having more than one context in an isolated world.)

  • WebCore.gypi:
  • bindings/v8/DOMWrapperWorld.cpp: Added. (WebCore::DOMWrapperWorld::DOMWrapperWorld): (WebCore::mainThreadNormalWorld):
  • bindings/v8/DOMWrapperWorld.h: Added. (WebCore::DOMWrapperWorld::create):
  • bindings/v8/IsolatedWorld.cpp: Added. (WebCore::IsolatedWorld::IsolatedWorld): (WebCore::IsolatedWorld::~IsolatedWorld):
  • bindings/v8/IsolatedWorld.h: Added. (WebCore::IsolatedWorld::create): (WebCore::IsolatedWorld::count): (WebCore::IsolatedWorld::domDataStore):
  • bindings/v8/MainThreadDOMData.cpp: (WebCore::MainThreadDOMData::getMainThreadStore):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::currentScriptState):
  • bindings/v8/ScriptState.cpp:
  • bindings/v8/ScriptState.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8IsolatedContext.cpp: Copied from WebCore/bindings/v8/V8IsolatedWorld.cpp. (WebCore::V8IsolatedContext::contextWeakReferenceCallback): (WebCore::V8IsolatedContext::V8IsolatedContext): (WebCore::V8IsolatedContext::destroy): (WebCore::V8IsolatedContext::~V8IsolatedContext): (WebCore::V8IsolatedContext::scriptState):
  • bindings/v8/V8IsolatedContext.h: Copied from WebCore/bindings/v8/V8IsolatedWorld.h. (WebCore::V8IsolatedContext::getEntered): (WebCore::V8IsolatedContext::world):
  • bindings/v8/V8IsolatedWorld.cpp: Removed.
  • bindings/v8/V8IsolatedWorld.h: Removed.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::context):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::WorldContextHandle):
11:03 Changeset [52810] by abarth@webkit.org
  • 5 edits
    1 copy
    6 moves
    3 adds in trunk/WebCore

2010-01-05 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Move createWindow into generic bindings so it can be shared with JSC
https://bugs.webkit.org/show_bug.cgi?id=33201

This patch moves createWindow from V8-specific code into the generic
bindings so that is can be re-used by the JavaScriptCore bindings. I
haven't actually moved the JSC bindings over to using this yet.

Also, I organized the generic bindings a bit more as it's becoming
clearer how things are going to shape up. There are still some
question marks, but hopefully the answers will become clear as we
progress.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/generic/BindingDOMWindow.h: Added. (WebCore::::createWindow):
  • bindings/generic/BindingSecurity.h: Renamed from WebCore/bindings/BindingSecurity.h. (WebCore::BindingSecurity::BindingSecurity): (WebCore::::canAccessWindow): (WebCore::::canAccessFrame): (WebCore::::checkNodeSecurity):
  • bindings/generic/BindingSecurityBase.cpp: Renamed from WebCore/bindings/BindingSecurityBase.cpp. (WebCore::BindingSecurityBase::getDOMWindow): (WebCore::BindingSecurityBase::getFrame): (WebCore::BindingSecurityBase::canAccess):
  • bindings/generic/BindingSecurityBase.h: Renamed from WebCore/bindings/BindingSecurityBase.h.
  • bindings/generic/GenericBinding.h: Renamed from WebCore/bindings/GenericBinding.h. (WebCore::):
  • bindings/v8/V8Binding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::showModalDialogCallback): (WebCore::V8DOMWindow::openCallback):
  • bindings/v8/specialization/V8BindingDOMWindow.h: Added. (WebCore::V8BindingDOMWindow::storeDialogArgs):
  • bindings/v8/specialization/V8BindingState.cpp: Renamed from WebCore/bindings/v8/V8BindingState.cpp. (WebCore::::Only): (WebCore::::getActiveWindow): (WebCore::::immediatelyReportUnsafeAccessTo):
  • bindings/v8/specialization/V8BindingState.h: Renamed from WebCore/bindings/v8/V8BindingState.h. (WebCore::):
11:00 Changeset [52809] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2010-01-05 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32571

Added a test to make sure that ARIA checkboxes correctly handle the aria-checked attribute.

  • accessibility/aria-checkbox-checked-expected.txt: Added.
  • accessibility/aria-checkbox-checked.html: Added.

2010-01-05 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32571

For an object with an aria role of "checkbox" or "radiobutton",
Use the "aria-checked" attribute to determine if it's checked.

Test: accessibility/aria-checkbox-checked.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isChecked):

2010-01-05 Dominic Mazzoni <dmazzoni@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32571

For an object with an aria role of "checkbox" or "radiobutton",
use the "aria-checked" attribute to determine if it's checked.
These changes add an isChecked() method to AccessibilityUIElement
so that we can check for this property from a layout test.

  • DumpRenderTree/AccessibilityUIElement.cpp: (getIsCheckedCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isChecked):
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::isChecked):
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::isChecked):
10:43 Changeset [52808] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

Having a comment for the #endif for a header guard is not required WebKit style.
https://bugs.webkit.org/show_bug.cgi?id=33214

Reviewed by Darin Adler.

  • Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit early when it has all the needed information to continue.
  • Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.
10:40 Changeset [52807] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.18

Tagging 1.1.18.

10:36 Changeset [52806] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-05 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Added compiler error for unsupported platforms.
https://bugs.webkit.org/show_bug.cgi?id=33112

  • jit/JITStubs.cpp:
10:14 Changeset [52805] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Share more code in the WebViewDestruction tests

Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

  • WebKitAPITest/tests/WebViewDestruction.cpp:

(WebKitAPITest::createAndInitializeWebView): Renamed from
createWebView. Now initializes the HostWindow and returns the
WebView's HWND via an out-parameter.
(WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
the CloseWithoutDestroyWindow test.
(WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
CloseWithoutDestroyWindow and changed to use the new functions.
(WebKitAPITest::MainFrameAfterClose): Changed to use the new
functions.
(WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
NoCloseOrDestroyWindow and changed to use the new functions.

10:14 Changeset [52804] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Don't show HostWindows by default

This was making WebKitAPITest very flashy as windows appeared and
disappeared.

Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

  • WebKitAPITest/HostWindow.cpp:

(WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
from the window.

10:14 Changeset [52803] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Don't hang in WebKitAPITest if no messages have been posted

Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

  • WebKitAPITest/tests/WebViewDestruction.cpp:

(WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
to avoid hanging if no messages have been posted.

10:14 Changeset [52802] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Fix WebKitCreateInstance helper

Part of <http://webkit.org/b/33212> Small fixes/improvements to
WebKitAPITest

Reviewed by Sam Weinig.

  • WebKitAPITest/tests/WebViewDestruction.cpp:

(WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
through, instead of taking its address.

09:54 Changeset [52801] by yong.li@torchmobile.com
  • 3 edits in trunk/WebCore

2010-01-05 Yong Li <yoli@rim.com>

Reviewed by Adam Roben.

Fix build warnings blindly
https://bugs.webkit.org/show_bug.cgi?id=33178

  • platform/SharedBuffer.cpp:
  • platform/SharedBuffer.h: (WebCore::SharedBuffer::append):
09:45 Changeset [52800] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::append):

08:24 Changeset [52799] by yong.li@torchmobile.com
  • 4 edits in trunk/WebCore

2010-01-05 Yong Li <yong.li@torchmobile.com>

Reviewed by Darin Adler.

Fix an obvious bug and build errors in previous commit (r52795)
https://bugs.webkit.org/show_bug.cgi?id=33178

  • platform/SharedBuffer.h: (WebCore::SharedBuffer::isEmpty):
  • platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::maybeTransferPlatformData):
08:09 Changeset [52798] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-01-05 Gustavo Noronha Silva <gns@gnome.org>

Updated docs for 1.1.18 release.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
07:53 Changeset [52797] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

Follow r52729 in ARMAssembler.
https://bugs.webkit.org/show_bug.cgi?id=33208

Reviewed by Maciej Stachowiak.

Use WTF_ARM_ARCH_AT_LEAST instead of ARM_ARCH_VERSION

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::encodeComplexImm): Move tmp declaration to ARMv7

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::):
(JSC::ARMAssembler::bkpt):

07:53 Changeset [52796] by xan@webkit.org
  • 4 edits in trunk

2010-01-05 Xan Lopez <xlopez@igalia.com>

Bump for 1.1.18 release.

  • configure.ac:

WebKit/gtk:

2010-01-05 Xan Lopez <xlopez@igalia.com>

Update for 1.1.18 release.

  • NEWS:
07:14 Changeset [52795] by yong.li@torchmobile.com
  • 7 edits in trunk/WebCore

2010-01-04 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Let SharedBuffer use a group of memory segments internally.
It will merge the segments into a flat consecutive buffer only when
necessary.
https://bugs.webkit.org/show_bug.cgi?id=33178

  • platform/SharedBuffer.cpp: (WebCore::allocateSegment): (WebCore::freeSegment): (WebCore::SharedBuffer::SharedBuffer): (WebCore::SharedBuffer::~SharedBuffer): (WebCore::SharedBuffer::adoptVector): (WebCore::SharedBuffer::size): (WebCore::SharedBuffer::data): (WebCore::SharedBuffer::append): (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::copy): (WebCore::SharedBuffer::buffer): (WebCore::SharedBuffer::getSomeData):
  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::maybeTransferPlatformData):
  • platform/haiku/SharedBufferHaiku.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
06:22 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:00 Changeset [52794] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Unreviewed build fix for Gtk+

Don't use comments in Platform.h, at least some of them seem to make the version of GCC
used on the Gtk buildbot unhappy.

  • wtf/Platform.h:
02:28 Changeset [52793] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed trivial Symbian build fix

  • plugins/symbian/PluginViewSymbian.cpp: Add missing HostWindow.h inclusion
01:45 Changeset [52792] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix broken export macros in package builds.

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=33202

Always define QT_MAKEDLL unless we're doing a static
build or we're building inside of Qt. When building
inside of Qt the correct define is pulled from qbase.pri.

  • WebCore.pro:
00:58 Changeset [52791] by mjs@apple.com
  • 147 edits in trunk

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Fisher.

Reorganize, document and rename OS() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33198

  • wtf/Platform.h: Rename, reorganize and document OS() macros.

Adapt to name changes. Also fixed a few incorrect OS checks.

  • API/JSContextRef.cpp:
  • assembler/MacroAssemblerARM.cpp: (JSC::isVFPPresent):
  • assembler/MacroAssemblerX86Common.h:
  • bytecode/SamplingTool.cpp:
  • config.h:
  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::~RegisterFile):
  • interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::grow):
  • jit/ExecutableAllocator.h:
  • jit/ExecutableAllocatorFixedVMPool.cpp:
  • jit/ExecutableAllocatorPosix.cpp:
  • jit/ExecutableAllocatorSymbian.cpp:
  • jit/ExecutableAllocatorWin.cpp:
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITStubs.cpp:
  • jsc.cpp: (main):
  • parser/Grammar.y:
  • profiler/ProfileNode.cpp: (JSC::getCount):
  • runtime/Collector.cpp: (JSC::Heap::Heap): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase): (JSC::getCurrentPlatformThread): (JSC::suspendThread): (JSC::resumeThread): (JSC::getPlatformThreadRegisters): (JSC::otherThreadStackPointer):
  • runtime/Collector.h:
  • runtime/DateConstructor.cpp:
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
  • runtime/InitializeThreading.cpp: (JSC::initializeThreading):
  • runtime/MarkStack.h: (JSC::MarkStack::MarkStackArray::shrinkAllocation):
  • runtime/MarkStackPosix.cpp:
  • runtime/MarkStackSymbian.cpp:
  • runtime/MarkStackWin.cpp:
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncLastIndexOf):
  • runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
  • runtime/UString.cpp: (JSC::UString::from):
  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/CurrentTime.cpp: (WTF::lowResUTCTime):
  • wtf/CurrentTime.h: (WTF::getLocalTime):
  • wtf/DateMath.cpp:
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_ThreadCache::InitModule): (WTF::TCMallocStats::):
  • wtf/FastMalloc.h:
  • wtf/MathExtras.h:
  • wtf/RandomNumber.cpp: (WTF::randomNumber):
  • wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
  • wtf/StringExtras.h:
  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
  • wtf/TCSystemAlloc.cpp:
  • wtf/ThreadSpecific.h: (WTF::::destroy):
  • wtf/Threading.h:
  • wtf/ThreadingPthreads.cpp: (WTF::initializeThreading): (WTF::isMainThread):
  • wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint): (WTF::createThreadInternal):
  • wtf/VMTags.h:
  • wtf/unicode/icu/CollatorICU.cpp: (WTF::Collator::userDefault):
  • wtf/win/MainThreadWin.cpp: (WTF::initializeMainThreadPlatform):

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Fisher.

Reorganize, document and rename OS() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33198

Adapt to name changes.

  • src/ChromiumBridge.cpp:
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::isSelectTrailingWhitespaceEnabled): (WebKit::): (WebKit::EditorClientImpl::handleEditingKeyboardEvent):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionAsText): (WebKit::WebFrameImpl::printPage):
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::mouseContextMenu): (WebKit::WebViewImpl::mouseUp): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::sendContextMenuEvent): (WebKit::WebViewImpl::setScrollbarColors): (WebKit::WebViewImpl::navigationPolicyFromMouseEvent):

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Fisher.

Reorganize, document and rename OS() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33198

Adapt to name changes.

  • webkit/webkitwebsettings.cpp: (webkit_get_user_agent):

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Fisher.

Reorganize, document and rename OS() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33198

Adapt to name changes. Also fixed a few incorrect OS checks.

  • accessibility/AccessibilityObject.h:
  • config.h:
  • dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::platform):
  • loader/CachedFont.cpp:
  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryParser.cpp:
  • page/EventHandler.cpp:
  • page/Frame.cpp: (WebCore::Frame::setUseSecureKeyboardEntry):
  • page/NavigatorBase.cpp: (WebCore::NavigatorBase::platform):
  • page/Page.h:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:
  • page/chromium/DragControllerChromium.cpp: (WebCore::DragController::isCopyKeyDown):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::accessKeyModifiers):
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/FileSystem.h:
  • platform/KeyboardCodes.h:
  • platform/PurgeableBuffer.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
  • platform/chromium/ClipboardUtilitiesChromium.cpp:
  • platform/chromium/ClipboardUtilitiesChromium.h:
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::documentFragment):
  • platform/chromium/PlatformKeyboardEventChromium.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout): (WebCore::PopupMenu::show):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName):
  • platform/graphics/FontCache.h:
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/Path.h:
  • platform/graphics/Pattern.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cg/ColorCG.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):
  • platform/graphics/chromium/FontCustomPlatformData.h:
  • platform/graphics/chromium/FontPlatformData.h:
  • platform/graphics/opentype/OpenTypeUtilities.cpp:
  • platform/graphics/opentype/OpenTypeUtilities.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getWindowsContext):
  • platform/graphics/qt/ImageQt.cpp:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipToImageBuffer):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::save): (PlatformContextSkia::restore):
  • platform/graphics/skia/PlatformContextSkia.h:
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles): (WebCore::Icon::paint):
  • platform/graphics/wx/GraphicsContextWx.cpp:
  • platform/gtk/FileSystemGtk.cpp: (WebCore::filenameToString): (WebCore::filenameFromString): (WebCore::filenameForDisplay):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/network/curl/ResourceHandleManager.cpp:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
  • platform/text/String.cpp: (WebCore::String::format): (WebCore::String::number):
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
  • platform/text/TextStream.cpp:
  • platform/text/TextStream.h:
  • platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::decode):
  • platform/win/PlatformMouseEventWin.cpp: (WebCore::messageToEventType): (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/win/PlatformScreenWin.cpp: (WebCore::deviceInfoForWidget): (WebCore::screenIsMonochrome):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::paint): (WebCore::PopupMenu::registerClass): (WebCore::PopupMenu::PopupMenuWndProc): (WebCore::PopupMenu::wndProc):
  • platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime):
  • platform/wx/FileSystemWx.cpp: (WebCore::unloadModule):
  • plugins/PluginDatabase.cpp:
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::compareFileVersion):
  • plugins/PluginPackage.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::setFrameRect): (WebCore::PluginView::stop): (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addWindowsMediaPlayerPluginDirectory): (WebCore::addMacromediaPluginDirectories):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
  • plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView): (WebCore::PluginView::wndProc): (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paintIntoTransformedContext): (WebCore::PluginView::paintWindowedPluginIntoContext): (WebCore::PluginView::paint): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::platformStart):

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Fisher.

Reorganize, document and rename OS() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33198

Adapt to name changes.


  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/config.h:
00:55 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
00:47 Changeset [52790] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-05 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Minor improvements to test-webkit-scripts, as suggested
by an earlier review.

https://bugs.webkit.org/show_bug.cgi?id=33125

  • Scripts/test-webkit-scripts:
    • Used OptionParser class instead of getopt.getopt().
    • Created main() method for main block.
    • Enclosed functions in a class.
00:07 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
00:06 Changeset [52789] by cfleizach@apple.com
  • 2 edits in trunk/WebKitTools

No review. Fix DRT breakage on Tiger/Leopard.

Add ARIA "Live Region" support
https://bugs.webkit.org/show_bug.cgi?id=33117

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
00:00 Changeset [52788] by darin@chromium.org
  • 8 edits in trunk/WebKit/chromium

2010-01-04 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Expose more DOM methods to support LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=33185

  • public/WebDocument.h: Adds documentElement method.
  • public/WebElement.h: Adds innerText method.
  • public/WebFrame.h: Adds renderTreeAsText and counterValueForElementById methods, and fixes a few whitespace issues.
  • src/WebDocument.cpp: (WebKit::WebDocument::documentElement):
  • src/WebElement.cpp: (WebKit::WebElement::innerText):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearName): (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::counterValueForElementById):
  • src/WebFrameImpl.h:

01/04/10:

23:54 Changeset [52787] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-01-04 Darin Fisher <darin@chromium.org>

Fix Chromium build bustage.

  • src/WebAnimationControllerImpl.h:
23:46 Changeset [52786] by cfleizach@apple.com
  • 23 edits
    4 adds in trunk

Add ARIA "Live Region" support
https://bugs.webkit.org/show_bug.cgi?id=33117

Reviewed by Darin Adler.

WebCore:

Tests: platform/mac/accessibility/aria-liveregions-attributes.html

platform/mac/accessibility/aria-liveregions-notifications.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::contentChanged):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isChildOfARIALiveRegion):
(WebCore::AccessibilityObject::supportsARIALiveRegion):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::contentChanged):
(WebCore::AccessibilityObject::ariaLiveRegionStatus):
(WebCore::AccessibilityObject::ariaLiveRegionRelevant):
(WebCore::AccessibilityObject::ariaLiveRegionAtomic):
(WebCore::AccessibilityObject::ariaLiveRegionBusy):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::elementAttributeValue):
(WebCore::AccessibilityRenderObject::contentChanged):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
(WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant):
(WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic):
(WebCore::AccessibilityRenderObject::ariaLiveRegionBusy):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::areChildrenDirty):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/mac/AccessibilityObjectWrapper.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

  • html/HTMLAttributeNames.in:
  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(indexOfChildCallback):
(boolAttributeValueCallback):
(stringAttributeValueCallback):
(addNotificationListenerCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::addNotificationListener):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::addNotificationListener):

LayoutTests:

  • accessibility/aria-activedescendant-crash.html:
  • platform/mac/accessibility/aria-liveregions-attributes-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregions-attributes.html: Added.
  • platform/mac/accessibility/aria-liveregions-notifications-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregions-notifications.html: Added.
  • platform/mac/accessibility/aria-menu-role-descriptions.html:
  • platform/mac/accessibility/slider-supports-actions.html:
21:33 Changeset [52785] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool rollout should require a reason
https://bugs.webkit.org/show_bug.cgi?id=30810

  • Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
  • Scripts/webkitpy/changelogs_unittest.py: Test reason support.
  • Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
  • Scripts/webkitpy/commands/download_unittest.py: pass required reason
  • Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert
21:19 Changeset [52784] by abarth@webkit.org
  • 12 edits
    12 adds in trunk

2010-01-04 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Test for https://bugs.webkit.org/show_bug.cgi?id=29820
Adopt a more conservative approach for loading CSS cross-origin.

  • http/tests/security/cross-origin-css.html: Added.
  • http/tests/security/cross-origin-css-expected.txt: Added.
  • http/tests/security/cross-origin-css-in-xml.xml: Added.
  • http/tests/security/cross-origin-css-in-xml-expected.txt: Added.
  • http/tests/security/resources/xorigincss1.css: Added.
  • http/tests/security/resources/xorigincss2.css: Added.
  • http/tests/security/resources/xorigincss1.html: Added.
  • http/tests/security/resources/xorigincss2.html: Added.
  • http/tests/security/resources/xorigincss3.html: Added.
  • http/tests/security/resources/xorigincss4.html: Added.
  • http/tests/security/resources/xorigincss5.html: Added.
  • http/tests/security/resources/xorigincss6.html: Added.

2010-01-04 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Adopt a more conservative approach for loading CSS cross-origin. When
loading CSS cross-origin, it must be start with valid CSS if the MIME
type is broken.

https://bugs.webkit.org/show_bug.cgi?id=29820

Test: http/tests/security/cross-origin-css.html
Test: http/tests/security/cross-origin-css-in-xml.xml

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet): Enforce stricter load requirements for cross-origin loads.
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet): Enforce stricter load requirements for cross-origin loads.
  • css/CSSStyleSheet.h:
  • css/CSSStyleSheet.cpp:
  • css/CSSParser.cpp:
  • css/CSSGrammar.y:
  • css/CSSParser.h: Add ability to tell whether the CSS parse started with a syntactically valid CSS rule.
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText): Add ability to return whether the MIME type was acceptable for CSS. (WebCore::CachedCSSStyleSheet::canUseSheet): If requested, return whether the MIME type was valid or not.
  • dom/ProcessingInstruction.cpp (WebCore::ProcessingInstruction::setCSSStyleSheet): Make use of strict mode explicit and add comment.
20:45 Changeset [52783] by mitz@apple.com
  • 5 edits
    2 adds in trunk

<rdar://problem/6655695> REGRESSION: VoiceOver is not highlighting some web elements correctly
<rdar://problem/7397558> REGRESSION: AXImages inside of AXLink cause AXLink to have wrong bounds

Reviewed by Simon Fraser.

WebCore:

Test: accessibility/dimensions-include-descendants.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect): Use absoluteFocusRingQuads()
for non-text renderers. The focus ring encompasses descendants, which is
what we want for the accessibility indicator.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::absoluteFocusRingQuads): Added.

  • rendering/RenderObject.h:

LayoutTests:

  • accessibility/dimensions-include-descendants-expected.txt: Added.
  • accessibility/dimensions-include-descendants.html: Added.
19:53 Changeset [52782] by ojan@chromium.org
  • 2 edits in trunk/WebCore

2010-01-04 Ojan Vafai <ojan@ojanmacpro.sfo.corp.google.com>

Reviewed by Dan Bernstein.

Remove unnecessary division by a constant in SimpleFontDataMac.mm.
https://bugs.webkit.org/show_bug.cgi?id=33189

This was added in http://trac.webkit.org/changeset/8104 and seems like
it was just there to match the previously private function which we no
longer use.

No new tests. No change in behavior.

  • platform/graphics/mac/SimpleFontDataMac.mm:
19:40 Changeset [52781] by jhoneycutt@apple.com
  • 3 edits
    2 adds in trunk

MSAA: Accessibility role of <select> elements is wrong

https://bugs.webkit.org/show_bug.cgi?id=33192

Reviewed by Sam Weinig.

WebKit/win:

  • AccessibleBase.cpp:

(MSAARole):
Map WebCore::PopUpButtonRole to MSAA's ROLE_SYSTEM_COMBOBOX.

LayoutTests:

  • platform/win/accessibility/select-element-role-expected.txt: Added.
  • platform/win/accessibility/select-element-role.html: Added.
17:43 Changeset [52780] by kov@webkit.org
  • 4 edits in trunk

Make distcheck build fixes.

17:38 Changeset [52779] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

Qt build fix. Unreviewed.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

17:35 Changeset [52778] by darin@apple.com
  • 6 edits in trunk/WebCore

Selection-related code needs stricter rules about how it relates to layout
https://bugs.webkit.org/show_bug.cgi?id=32882

Reviewed by Maciej Stachowiak.

Covered by existing tests along with the new assertions.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle): Make sure that m_inStyleRecalc is
already false by the time post-attach callbacks are done so that
layout triggered inside those callbacks can work properly.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::layout): Added code to trigger a
layout when it's needed.
(WebCore::SelectionController::recomputeCaretRect): Removed unneeded
code to do nothing when FrameView is 0. Added an assertion that layout
is not needed at the time the function is called.
(WebCore::SelectionController::invalidateCaretRect): Added code to
trigger a layout when it's needed.
(WebCore::SelectionController::paintCaret): Added an assertion that
layout is not needed at the time the function is called.

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus): Added. Helper function that expresses
the rule for which form control elements should auto-focus.
(WebCore::focusPostAttach): Added. Called post-attach to focus an
element if we discover it should be focused during attach.
(WebCore::HTMLFormControlElement::attach): Refactored code for
which elements need auto-focus into a separate function. Instead
of focusing right away, use the focusPostAttach function to focus
after attach is done. Also added calls to suspendPostAttachCallbacks
and resumePostAttachCallbacks so post-attach callbacks happen late
enough. Before, they could run inside the base attach function.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::attach): Added calls to
suspendPostAttachCallbacks and resumePostAttachCallbacks so
post-attach callbacks happen late enough

  • page/Frame.cpp:

(WebCore::Frame::revealSelection): Added code to trigger a layout
when it's needed.

17:32 Changeset [52777] by barraclough@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

erk, demangle the ChangeLog!

17:24 Changeset [52776] by barraclough@apple.com
  • 13 edits
    3 adds in trunk

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Add string hashing functions to WTF.
Use WTF's string hashing functions from UStringImpl.

Reviewed by Sam Weinig, additional coding by Mark Rowe.

(JSC::UStringImpl::computeHash):

  • wtf/HashFunctions.h:
  • wtf/StringHashFunctions.h: Added.

(WTF::stringHash):

JavaScriptGlue: Add a forwarding header so that StringHashFunctions.h can be found.

Reviewed by Sam Weinig.

  • ForwardingHeaders/wtf/StringHashFunctions.h: Added.

WebCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Use WTF's string hashing functions from StringImpl.

Patch by Mark Rowe <mrowe@apple.com> on 2010-01-04
Reviewed by Sam Weinig.

  • ForwardingHeaders/wtf/StringHashFunctions.h: Added.
  • platform/text/StringHash.h:
  • platform/text/StringImpl.h:

(WebCore::StringImpl::computeHash):

17:21 Changeset [52775] by eric@webkit.org
  • 5 edits
    3 adds in trunk/WebKit/chromium

2010-01-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

Adding WebAnimationController to chromium's WebKit API.

https://bugs.webkit.org/show_bug.cgi?id=32870

  • WebKit.gyp:
  • public/WebAnimationController.h: Added. (WebKit::WebAnimationController::~WebAnimationController):
  • public/WebFrame.h:
  • src/WebAnimationControllerImpl.cpp: Added. (WebKit::WebAnimationControllerImpl::WebAnimationControllerImpl): (WebKit::WebAnimationControllerImpl::pauseAnimationAtTime): (WebKit::WebAnimationControllerImpl::pauseTransitionAtTime): (WebKit::WebAnimationControllerImpl::numberOfActiveAnimations):
  • src/WebAnimationControllerImpl.h: Added. (WebKit::WebAnimationControllerImpl::~WebAnimationControllerImpl):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::animationController): (WebKit::WebFrameImpl::WebFrameImpl):
  • src/WebFrameImpl.h:
17:12 Changeset [52774] by eric@webkit.org
  • 5 edits in trunk/WebKit/chromium

2010-01-04 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher

Adding more DOM API methods. They are needed for the upcoming
translate feature.

  • public/WebElement.h:
  • public/WebNode.h:
  • src/WebElement.cpp: (WebKit::WebElement::tagName): (WebKit::WebElement::setAttribute):
  • src/WebNode.cpp: (WebKit::WebNode::setNodeValue):
17:12 Changeset [52773] by jhoneycutt@apple.com
  • 14 edits
    2 adds in trunk

MSAA: <select> elements should broadcast value change events

https://bugs.webkit.org/show_bug.cgi?id=33088

<rdar://problem/7332364>

Reviewed by Darin Adler.

WebCore:

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::postNotification):
If the post type is async, follow the old code path; otherwise, call
postPlatformNotification().

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::):
Added a new accessibility notification, AXMenuListValueChanged. Added
a new parameter to postNotification() to specify whether the post should
be synchronous or asynchronous.

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
If the WebCore notification is AXMenuListValueChanged, broadcast an
EVENT_OBJECT_VALUECHANGE event.

  • dom/SelectElement.cpp:

(WebCore::SelectElement::setSelectedIndex):
When the selected index of a RenderMenuList is changed, call
RenderMenuList::didSetSelectedIndex().

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
Initialize new member
(WebCore::RenderMenuList::didSetSelectedIndex):
If the selected index has changed, post AXMenuListValueChanged to the
object synchronously.

  • rendering/RenderMenuList.h:

Declare didSetSelectedIndex(), and add a member to hold the last
selected index.

WebKitTools:

  • DumpRenderTree/AccessibilityController.cpp:

(logValueChangeEventsCallback):
Start logging value change events.
(AccessibilityController::getJSClass):
Add a "logValueChangeEvents" to the AccessibilityController's JS class
definition.
(AccessibilityController::resetToConsistentState):
Disable logging of value change events.

  • DumpRenderTree/AccessibilityController.h:

Declare setLogValueChangeEvents(), and add a member variable for the
value change event hook.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::setLogValueChangeEvents):
Stubbed.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::setLogValueChangeEvents):
Stubbed.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize new member var.
(AccessibilityController::~AccessibilityController):
Disable logging of value change events.
(logEventProc):
When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
and its value.
(AccessibilityController::setLogValueChangeEvents):
If disabling logging, unhook the event, and clear the event hook
member var. Otherwise, query for the root element to enable
accessibility, and hook EVENT_OBJECT_VALUECHANGE.

LayoutTests:

  • platform/win/accessibility/select-element-valuechange-event-expected.txt: Added.
  • platform/win/accessibility/select-element-valuechange-event.html: Added.
17:07 Changeset [52772] by darin@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Added missing null check in BarInfo code.

Reviewed by Sam Weinig.

Test: fast/dom/Window/BarInfo-after-frame-removed.html

  • page/BarInfo.cpp:

(WebCore::BarInfo::visible): Added null check. A few other
cleanups.

LayoutTests: Added test for use of BarInfo object after a frame is no longer
associated with a web page.

Reviewed by Sam Weinig.

  • fast/dom/Window/BarInfo-after-frame-removed-expected.txt: Added.
  • fast/dom/Window/BarInfo-after-frame-removed.html: Added.
17:04 Changeset [52771] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

long_help for submit-patch
https://bugs.webkit.org/show_bug.cgi?id=33184

  • Scripts/webkitpy/commands/upload.py:
16:54 Changeset [52770] by mrowe@apple.com
  • 2 edits
    1 delete in trunk/WebCore

Rubber-stamped by Jon Honeycutt.

Delete an empty and unused JavaScript file.

  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/InspectorControllerStub.js: Removed.
16:27 Changeset [52769] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix, add a couple include dirs to the build.

16:13 Changeset [52768] by mrowe@apple.com
  • 9 edits in trunk

Roll out r52758 as it accidentally the whole build.

15:50 Changeset [52767] by ap@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33181
The first letter is not removed properly from inline input hole

  • WebView.cpp: (WebView::onIMEEndComposition): If composition is ended before it was confirmed, cancel it.
15:48 Changeset [52766] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h

Part of a build fix for Windows, this at least gets WTF to build.

15:18 Changeset [52765] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • wtf/unicode/Unicode.h:

Reviewed by NOBODY (more speculative build fix).

15:13 Changeset [52764] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue can wrongly reject patches if the buildbots are behind
https://bugs.webkit.org/show_bug.cgi?id=30098

Check to make sure we can currently build and test before trying to
land a patch.

  • Scripts/webkitpy/commands/queues.py:
15:05 Changeset [52763] by dimich@chromium.org
  • 2 edits in trunk/JavaScriptCore

Not reviewed, attempt to fix ARM bulid.

  • wtf/Platform.h:
14:49 Changeset [52762] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

Rubber stamped by Geoff Garen.

Add an 'isIdentifier' to UStringImpl, use this where appropriate
(where previously 'identifierTable' was being tested).

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

  • runtime/Identifier.cpp:

(JSC::Identifier::addSlowCase):

  • runtime/Identifier.h:

(JSC::Identifier::add):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::isIdentifier):

14:42 Changeset [52761] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • wtf/HashFunctions.h:

Reviewed by NOBODY build fix for DRT, fix incorrect style include.

14:30 Changeset [52760] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY Windows build fix.

14:09 Changeset [52759] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

14:00 Changeset [52758] by barraclough@apple.com
  • 7 edits in trunk

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Add string hashing functions to WTF.
Use WTF's string hashing functions from UStringImpl.

Reviewed by Sam Weinig.

(JSC::UStringImpl::computeHash):

  • wtf/HashFunctions.h:

(WTF::stringHash):

WebCore: https://bugs.webkit.org/show_bug.cgi?id=33163
Use WTF's string hashing functions from StringImpl.

Reviewed by Sam Weinig.

  • platform/text/StringImpl.h:

(WebCore::StringImpl::computeHash):

13:50 Changeset [52757] by simon.fraser@apple.com
  • 5 edits
    4 adds in trunk

2010-01-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Repaint issues in text input under a scale transform
https://bugs.webkit.org/show_bug.cgi?id=32086

When doing a subtree layout we have to look up the container chain to see if there
are any properties, such as transforms or reflections, that mean that we are unable
to use layoutState.

Test: fast/repaint/subtree-layoutstate-transform.html

  • page/FrameView.cpp: (WebCore::FrameView::layout): Call canUseLayoutStateForSubtree() to determine whether it's OK to use layoutState.
  • rendering/RenderView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::canUseLayoutStateForSubtree): New method that reports whether it's OK to use layoutState when doing a subtree layout from the given root.
13:49 Changeset [52756] by darin@apple.com
  • 8 edits
    2 adds in trunk

WebCore: Reentrancy problem with selection in some edge cases.
https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974

Reviewed by Dan Bernstein.

Test: fast/forms/selection-layout-reentry-strange-case.html

Move the selection display update process done in the
selectionLayoutChanged function into the layout timer
instead of doing it immediately when selection changes occur.

  • dom/Document.cpp:

(WebCore::Document::updateLayout): Changed this to use the
definition of needsLayout from FrameView rather than rolling
its own.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::SelectionController):
Initialize m_needsDisplayUpdate to false.
(WebCore::SelectionController::setSelection): Call
the new setNeedsDisplayUpdate function instead of the old
badly named Frame::selectionLayoutChanged function.
(WebCore::SelectionController::setNeedsDisplayUpdate):
Set m_needsDisplayUpdate. If it is just becoming true, then
call FrameView::scheduleRelayout.

  • editing/SelectionController.h: Added setNeedsDisplayUpdate,

needsDisplayUpdate, and m_needsDisplayUpdate.

  • page/Frame.cpp:

(WebCore::Frame::setCaretVisible): Call setNeedsDisplayUpdate.
(WebCore::Frame::selectionLayoutChanged): Call
setNeedsDisplayUpdate to set it to false, since this is the
function that performs "selection display update". Later I want
to rename this function. Also added a global reentrancy check
since that's the easiest way I could think of to prevent infinite
recursion in the case where recomputeCaretRect ends up triggering
a layout. As a side effect, fixed theoretical problems in
TEXT_CARET builds by improving the ifdef.
(WebCore::Frame::caretBlinkTimerFired): Loosen assertions a
bit. Later we might want to decouple caret rect from caret state
a bit more and add these assertions back.
(WebCore::Frame::selectionBounds): Call Document::updateLayout.
This function is for external clients and they do not currently
do anything to make sure layout is up to date.

  • page/FrameView.cpp:

(WebCore::FrameView::needsLayout): Add a new clause, since
we need a call to layout if needsDisplayUpdate is true.

LayoutTests: Reentrancy problem with selection in some edge cases.
https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974

Reviewed by Dan Bernstein.

  • fast/forms/selection-layout-reentry-strange-case-expected.txt: Added.
  • fast/forms/selection-layout-reentry-strange-case.html: Added.
  • platform/mac/accessibility/frame-with-title-expected.txt: Updated since

the number of layouts is now different.

13:30 Changeset [52755] by ap@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33161
Assertion failure in WebView when using Chinese Simplified IME

  • WebView.cpp: (WebView::onIMERequestCharPosition): Changed the assertion into release mode check. We can't make assertions about arguments passed from outside WebKit.
13:27 Changeset [52754] by ap@apple.com
  • 5 edits in trunk/WebKit/win

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33157
Implement TextInput logging channel on Windows

  • WebKitLogging.cpp: (WebKitInitializeLoggingChannelsIfNecessary):
  • WebKitLogging.h: Added a TextInput channel in place of unused Network one.
  • WebView.cpp: (WebView::WebViewWndProc): Changed onIMERequest to return result directly. We never forward it to DefWindowProc, so there is no need to return an unused boolean result for "handled". (WebView::onIMEStartComposition): Added logging. (imeCompositionArgumentNames): A helper function for detailed logging in onIMEComposition. (imeNotificationName): A helper function for detailed logging in onIMENotify. (imeRequestName): A helper function for detailed logging in onIMERequest. (WebView::onIMEComposition): Added logging. (WebView::onIMEEndComposition): Ditto. (WebView::onIMEChar): Ditto. (WebView::onIMENotify): Ditto. (WebView::onIMERequestCharPosition): Changed to return result directly. (WebView::onIMERequestReconvertString): Ditto. (WebView::onIMERequest): Changed to return result directly. Added logging. (WebView::onIMESelect): Added logging. (WebView::onIMESetContext): Added logging.
  • WebView.h: onIMERequest functions now return result directly.
13:19 Changeset [52753] by aroben@apple.com
  • 3 edits
    11 adds in trunk

Add a test harness for the Windows WebKit API, and a few tests

We currently only have tests for a handful of bugs regarding WebView
destruction, but more tests can easily be added later. Eventually
we'll run these tests as part of run-webkit-tests.

Fixes <http://webkit.org/b/33167>.

Reviewed by Sam Weinig.

WebKit/win:

  • WebKit.vcproj/WebKit.sln: Added WebKitAPITest.vcproj. It builds just

after DumpRenderTree.vcproj.

WebKitTools:

  • WebKitAPITest/HostWindow.cpp: Added.

(WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
(WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
needed.
(WebKitAPITest::HostWindow::initialize): Create our window.
(WebKitAPITest::HostWindow::clientRect): Return our window's client
rect.
(WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
(WebKitAPITest::HostWindow::wndProc): Just call through to
DefWindowProcW.

  • WebKitAPITest/HostWindow.h: Added.

(WebKitAPITest::HostWindow::window): Simple getter.

  • WebKitAPITest/Test.h: Added. This file defines some macros useful

for writing tests.

  • WebKitAPITest/TestsController.cpp: Added.

(WebKitAPITest::TestsController::TestsController): Initialize our
members.
(WebKitAPITest::TestsController::shared): Return the shared instance.
(WebKitAPITest::TestsController::runAllTests): Run a message pump
until a WM_QUIT message is received, then return whether all tests
succeeded.
(WebKitAPITest::TestsController::addTest): Add the test to m_tests and
start running tests soon.
(WebKitAPITest::TestsController::testFailed): Record the failure and
print a message about it to stdout.
(WebKitAPITest::TestsController::runNextTest): If we don't have any
tests to run, post a WM_QUIT message to stop the message pump.
Otherwise, run the test and print whether it passed, then schedule the
next test.
(WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
to run the next test.
(WebKitAPITest::TestsController::registerWindowClass): Does what it
says.
(WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
fired, call runNextTest(). Pass everything else through to
DefWindowProcW.

  • WebKitAPITest/TestsController.h: Added.
  • WebKitAPITest/WebKitAPITest.vcproj: Added.
  • WebKitAPITest/WebKitAPITestCommon.vsprops: Added.
  • WebKitAPITest/main.cpp: Added.

(main): (Mostly) just calls TestsController::runAllTests.

  • WebKitAPITest/tests/WebViewDestruction.cpp: Added.

(WebKitAPITest::WebKitCreateInstance): Helper function template to
call through to the real WebKitCreateInstance.
(WebKitAPITest::webViewCount): Helper function to call through to
IWebKitStatistics::webViewCount.
(WebKitAPITest::createWebView): Helper function to create a WebView
and put it inside a HostWindow.
(WebKitAPITest::runMessagePump): Helper function to run a message pump
for a specified number of milliseconds, or until a WM_QUIT message is
received.
(WebKitAPITest::CloseWithoutDestroyWindow): Test for
<http://webkit.org/b/32827>.
(WebKitAPITest::MainFrameAfterClose): Test for
<http://webkit.org/b/32868>.
(WebKitAPITest::NoCloseOrDestroyWindow): Test for
<http://webkit.org/b/33162>.

12:28 Changeset [52752] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Correct debug assertion (and possible runtime errors) by
checking validity of bitmap settings used to create
the Windows Cairo contexts.
https://bugs.webkit.org/show_bug.cgi?id=33164.

Reviewed by Adam Roben.

  • platform/graphics/win/GraphicsContextCairoWin.cpp:

(WebCore::createCairoContextWithHDC): Check validity of selected

OBJ_BITMAP retrieved, and only create 32-bit context when
a valid bitmap is provided.

12:12 BuildingQtOnWindows edited by dbates@webkit.org
--makeargs=j4 should be --makeargs=-j4 (note the dash that precedes the … (diff)
11:18 Changeset [52751] by barraclough@apple.com
  • 9 edits
    1 add in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=33158
Refactor JSC API entry/exit to use RAII instead of copy/pasting code.
Make it easier to change set of actions taken when passing across the API boundary.

Reviewed by Sam "Shimmey Shimmey" Weinig.

  • API/APIShims.h: Added.

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):
(JSGarbageCollect):
(JSReportExtraMemoryCost):

  • API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

  • API/JSCallbackObjectFunctions.h:

(JSC::::init):
(JSC::::getOwnPropertySlot):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::hasInstance):
(JSC::::call):
(JSC::::getOwnPropertyNames):
(JSC::::toNumber):
(JSC::::toString):
(JSC::::staticValueGetter):
(JSC::::callbackGetter):

  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:

(JSObjectMake):
(JSObjectMakeFunctionWithCallback):
(JSObjectMakeConstructor):
(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetPrototype):
(JSObjectSetPrototype):
(JSObjectHasProperty):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):
(JSObjectCopyPropertyNames):
(JSPropertyNameArrayRelease):
(JSPropertyNameAccumulatorAddName):

  • API/JSValueRef.cpp:

(JSValueGetType):
(JSValueIsUndefined):
(JSValueIsNull):
(JSValueIsBoolean):
(JSValueIsNumber):
(JSValueIsString):
(JSValueIsObject):
(JSValueIsObjectOfClass):
(JSValueIsEqual):
(JSValueIsStrictEqual):
(JSValueIsInstanceOfConstructor):
(JSValueMakeUndefined):
(JSValueMakeNull):
(JSValueMakeBoolean):
(JSValueMakeNumber):
(JSValueMakeString):
(JSValueToBoolean):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
(JSValueProtect):
(JSValueUnprotect):

11:06 Changeset [52750] by dimich@chromium.org
  • 39 edits
    11 deletes in trunk

Not reviewed, revert r52745 and r52746 on behalf of Nikolas Zimmermann, as discussed on IRC.
Patch produced by 'git revert' and then reverting back ChangeLog files.

10:55 Changeset [52749] by mitz@apple.com
  • 13 edits in trunk

Updated copyright string

Reviewed by Ada Chan and Mark Rowe.

JavaScriptCore:

JavaScriptGlue:

  • Info.plist:

WebCore:

  • Info.plist:
  • WebCore.vcproj/QTMovieWin.rc:

WebKit/mac:

  • Info.plist:

WebKit/win:

  • WebKit.vcproj/WebKit.rc:
10:54 Changeset [52748] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

AX: any DIV with an aria role should not be ignored
https://bugs.webkit.org/show_bug.cgi?id=33090

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-divs-not-ignored.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests:

  • platform/mac/accessibility/aria-divs-not-ignored-expected.txt: Added.
  • platform/mac/accessibility/aria-divs-not-ignored.html: Added.
10:46 Changeset [52747] by japhet@chromium.org
  • 6 edits in trunk/WebCore

2010-01-04 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Generate declarations for V8 runtime enablers.

https://bugs.webkit.org/show_bug.cgi?id=33156

  • bindings/scripts/CodeGeneratorV8.pm: Generate runtime enabler declarations.
  • bindings/v8/custom/V8CustomBinding.h: Remove manual declarations of runtime enablers.
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp: Remove closeCallback(), which isn't actually being used.
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
09:46 Changeset [52746] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Forgot to add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to Chromium build.

  • WebCore.gypi:
09:31 Changeset [52745] by zimmermann@webkit.org
  • 38 edits
    11 adds in trunk

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Marker code is buggy: referencePoint translation is off
https://bugs.webkit.org/show_bug.cgi?id=33012

Rewrite marker code, as it had many issues:

  • Correct refX/refY handling (covered by new marker-referencePoint.svg test)
  • Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
  • Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
  • Fix SVGResource assuming that there is only one resource per resource type per element. Markers can have three different resources of the same type (three markers, start/mid/end markers)

Filed bug 33115 (PathElementAddQuadCurveToPoint not handled for <marker>), which was just a TODO in the code before.

Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
Test: svg/custom/marker-referencePoint.svg

svg/custom/marker-opacity.svg

  • Android.mk: Add SVGMarkerData.h / SVGMarkerLayoutInfo.(cpp,h) to build.
  • GNUmakefile.am: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/FrameView.cpp: Notify RenderSVGRoot children about viewport size changes, just like it's handled for <body> in HTML. (WebCore::FrameView::layout): This is important, as marker bounding boxes may depend on the current viewport size through relative coordinates used in <svg>.
  • rendering/RenderPath.cpp: (WebCore::RenderPath::markerBoundingBox): Calculates and caches marker boundaries in the layout() phase. (WebCore::RenderPath::repaintRectInLocalCoordinates): Use the cached marker bounding box during paint() time. (WebCore::RenderPath::setPath): Clear marker boundaries upon path changes. (WebCore::RenderPath::paint): Use SVGMarkerLayoutInfo::drawMarkers() instead of the local drawMarkersIfNeeded() function, which is gone now. (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Utilized by markerBoundingBox() to request SVGResourceMarker objects and calculate their boundaries.
  • rendering/RenderPath.h: Store SVGMarkerLayoutInfo objects, and rename m_markerBounds to m_cachedLocalMarkerBBox for consistency. (WebCore::RenderPath::path): Inline this accessor.
  • rendering/RenderSVGContainer.h: Make paint() public (to be used from SVGResourceMarker), all other methods protected (to be used from RenderSVGViewportContainer).
  • rendering/RenderSVGViewportContainer.cpp: Remove useless paint() override, as the comment in the code indicated. (WebCore::RenderSVGViewportContainer::markerBoundaries): Maps the marker contents repaintRectInLocalCoordinates() into the final coordinate system (see code). (WebCore::RenderSVGViewportContainer::markerContentTransformation): Add marker-specific helper method, allowing to make viewportTransform() private again.
  • rendering/RenderSVGViewportContainer.h: Marking viewportTransform() private, it's never meant to be used outside this renderer.
  • rendering/SVGMarkerData.h: Added. Refactored from existing RenderPath code, preserving original copyrights. (WebCore::SVGMarkerData::): Helper struct for SVGMarkerLayoutInfo. (WebCore::SVGMarkerData::origin): Holds the final computed destination of a marker. (WebCore::SVGMarkerData::marker): Holds a pointer to the associated SVGResourceMarker object, which we're aiming to layout. (WebCore::SVGMarkerData::currentAngle): Calculates the current angle for a certain marker type (start/mid/end) based upon the computed inslope/outslope values. (WebCore::SVGMarkerData::updateTypeAndMarker): Helper method. (WebCore::SVGMarkerData::updateOutslope): Ditto. (WebCore::SVGMarkerData::updateMarkerDataForPathElement): Does the actual inslope/outslope calculation. (WebCore::SVGMarkerData::updateInslope): Helper method.
  • rendering/SVGMarkerLayoutInfo.cpp: Added. New approach to build marker layout info, this time correct during layout() time instead of paint() time. (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo): (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo): (WebCore::processStartAndMidMarkers): Static helper method used to visit each path element in order to calculate inslopes/outslopes (-> orientation angles) (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): Build list of MarkerLayout objects, used to query boundaries, and to paint markers during drawMarkers(). (WebCore::SVGMarkerLayoutInfo::drawMarkers): Cheap method walking existing MarkerLayout vector, drawing the individual RenderSVGViewportContainer of the markers. (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker): Helper method.
  • rendering/SVGMarkerLayoutInfo.h: Added. (WebCore::MarkerLayout::MarkerLayout): Helper struct storing a pair of SVGResourceMarker* and a TranformationMatrix. (WebCore::SVGMarkerLayoutInfo::markerData): Public helper methods returning references to private member variables, used from processStartAndMidMarkers. (WebCore::SVGMarkerLayoutInfo::midMarker): Ditto. (WebCore::SVGMarkerLayoutInfo::elementIndex): Ditto.
  • svg/SVGMarkerElement.cpp: Adopt to name change: setRef() -> setReferencePoint(). setMarker() -> setRenderer() (WebCore::SVGMarkerElement::canvasResource): Add ASSERT(renderer()) to clarify that canvasResource() is only meant to used after renderer creation.
  • svg/graphics/SVGResource.cpp: Instead of maintaining a global hashmap between SVGStyledElements and an array of possible SVGResources, use a HashSet of SVGResources

and directly scan the already existing list of clients for a certain SVGResource. This wrong approach has been introduced over two years
ago, making the assumption that there's only one resource type per element. Though markers can provide three resources of the same type
per element (all SVGResourceMarker objects, but in different rules: start/mid/end marker). That information is only available while painting.

(WebCore::resourceSet): Add global static HashSet<SVGResource*>.
(WebCore::SVGResource::SVGResource): Add us to the resourceSet.
(WebCore::SVGResource::~SVGResource): Remove us from resourceSet.
(WebCore::SVGResource::removeClient): Traverse all SVGResource clients and remove the passed SVGStyledElement from the client list (invoked by SVGStyledElement destructor).
(WebCore::SVGResource::addClient): Remove the offending part of the old approach, making the wrong assumption regarding resource types.

  • svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::markerTransformation): Create TransformationMatrix in the local marker content (RenderSVGViewportContainer) coordinate system, to position a marker. (WebCore::SVGResourceMarker::draw): Simplify marker drawing a lot: used the passing TransformationMatrix (cached in SVGMarkerLayoutInfo) to draw the marker content renderer. (WebCore::SVGResourceMarker::externalRepresentation): Adopt to refX/refY -> referencePoint changes.
  • svg/graphics/SVGResourceMarker.h: Store a FloatPoint m_referecePoint instead of two refX/refY float values. (WebCore::SVGResourceMarker::setRenderer): Renamed from setMarker(). (WebCore::SVGResourceMarker::setReferencePoint): Renamed from setRef(). (WebCore::SVGResourceMarker::referencePoint): New accessor replacing refX() / refY().
09:29 Changeset [52744] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-01-04 Adam Roben <aroben@apple.com>

No review, rolling out r52741.
http://trac.webkit.org/changeset/52741
https://bugs.webkit.org/show_bug.cgi?id=33056

  • wtf/AlwaysInline.h:
09:20 Changeset [52743] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-04 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Add cacheFlush support for WinCE
https://bugs.webkit.org/show_bug.cgi?id=33110

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
09:09 Changeset [52742] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix typo in test name.

  • platform/win/Skipped:
09:06 Changeset [52741] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-04 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

Implement NO_RETURN for COMPILER(MSVC).
https://bugs.webkit.org/show_bug.cgi?id=33056

  • wtf/AlwaysInline.h:
08:50 Changeset [52740] by zimmermann@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update two win-specific test results, that showed up on the Windows Release/Debug slave.
Skip fast/frames/iframe-onload-remove-self-no-crash.html as it crashes the debug slave, filed bug.

All bots except SnowLeopard Leaks & GTK Linux Debug (32-bit) should turn to green now!

  • platform/win/editing/selection/select-text-overflow-ellipsis-expected.txt:
  • platform/win/fast/forms/basic-selects-expected.txt: Added.
  • platform/win/Skipped:
08:12 Changeset [52739] by vestbo@webkit.org
  • 7 edits
    1 add in trunk/WebKitTools

Add support for Git's "diff.mnemonicprefix" config option to WebKitTools

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=32820

  • Scripts/VCSUtils.pm:
  • Scripts/svn-apply:
  • Scripts/svn-unapply:
  • Scripts/test-webkitperl: Run gitdiff2svndiff test
  • Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
  • Scripts/webkitpy/diff_parser.py:
  • Scripts/webkitpy/diff_parser_unittest.py:
08:01 Changeset [52738] by zimmermann@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Bring back Tiger bot to green: svg/custom/use-on-symbol-inside-pattern.svg exposes a bug on both Tiger & Win.
Reopened bug 17393 and skipping this test for now, as it requires a larger rework of Path::debugString().

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
07:54 Changeset [52737] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to mark all Gtk bots green again, as discussed with Gustavo Noronha Silva.

  • platform/gtk/Skipped:
07:48 Changeset [52736] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skipping plugins/get-url-with-iframe-target.html, filed bug 33154, cc'ing the original author.

  • platform/mac-tiger/Skipped:
07:42 Changeset [52735] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skipping http/tests/navigation/*iframe* on Tiger, just like it has been done for win.

  • platform/mac-tiger/Skipped:
07:37 Changeset [52734] by hausmann@webkit.org
  • 5 edits in trunk

[Qt] Fix standalone package builds.

Reviewed by Tor Arne Vestbø.

.:

  • WebKit.pri: Add logic for detecting standalone builds. Set OUTPUT_DIR to the top-level dir in that case.
  • WebKit.pro: Don't build JSC and DRT for package builds.

WebCore:

  • WebCore.pro: Moved logic for detecting standalone builds to WebKit.pri. Set DESTDIR for package builds.
07:33 Changeset [52733] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-04 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Laszlo Gombos.

https://bugs.webkit.org/show_bug.cgi?id=29048
[Qt] make RenderStyle.h compile in winscw compiler.

Change compareEqual to a macro in Winscw compiler to get around "illegal operand"
error when compareEqual is defined as template.

The compiler bug is reported at:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=10447

  • rendering/style/RenderStyle.h:
06:59 Changeset [52732] by ddkilzer@apple.com
  • 3 edits
    2 moves
    4 adds in trunk/WebKitTools

Divided the Perl unit tests into separate files and put
them in a separate directory, and renamed test-webkit-perl
to test-webkitperl.

Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-04
Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=33124

  • Scripts/VCSUtils.pm:
    • Renamed generateRunPatchCommand() to generatePatchCommand().
  • Scripts/VCSUtils_unittest.pl: Removed.
    • Divided into three files in Scripts/webkitperl/VCSUtils_unittest.
  • Scripts/test-webkit-perl: Removed.
    • Renamed to test-webkitperl.
  • Scripts/test-webkit-scripts:
    • Updated paths to test-webkitpy and test-webkitperl.
  • Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
    • Added paths to new test files.
  • Scripts/webkitperl: Added.
  • Scripts/webkitperl/VCSUtils_unittest: Added.
  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.
05:18 Changeset [52731] by mjs@apple.com
  • 5 edits in trunk

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Simon Hausmann.

Fix some PLATFORM(*_ENDIAN) uses to CPU()
https://bugs.webkit.org/show_bug.cgi?id=33148

  • runtime/JSCell.cpp: (JSC::):
  • runtime/JSValue.h: (JSC::JSValue::):

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Simon Hausmann.

Fix some PLATFORM(*_ENDIAN) uses to CPU()
https://bugs.webkit.org/show_bug.cgi?id=33148

  • platform/image-decoders/bmp/BMPImageReader.h: (WebCore::BMPImageReader::readUint16): (WebCore::BMPImageReader::readUint32): (WebCore::BMPImageReader::readCurrentPixel):
04:01 Changeset [52730] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Document CPU() macros in comments.
https://bugs.webkit.org/show_bug.cgi?id=33147

  • wtf/Platform.h:
03:59 Porting Macros plan edited by mjs@apple.com
(diff)
03:38 Changeset [52729] by mjs@apple.com
  • 42 edits in trunk

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Reorganize, document and rename CPU() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33145
ExecutableAllocatorSymbian appears to have buggy ARM version check
https://bugs.webkit.org/show_bug.cgi?id=33138


  • wtf/Platform.h: Rename all macros related to detection of particular CPUs or classes of CPUs to CPU(), reorganize and document them.

All remaining changes are adapting to the renames, plus fixing the
second bug cited above.


  • assembler/ARMAssembler.cpp:
  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.cpp:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
  • assembler/MacroAssemblerX86.h:
  • assembler/MacroAssemblerX86Common.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/X86Assembler.h: (JSC::X86Registers::): (JSC::X86Assembler::): (JSC::X86Assembler::movl_mEAX): (JSC::X86Assembler::movl_EAXm): (JSC::X86Assembler::repatchLoadPtrToLEA): (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
  • jit/ExecutableAllocator.h:
  • jit/ExecutableAllocatorFixedVMPool.cpp:
  • jit/ExecutableAllocatorPosix.cpp:
  • jit/ExecutableAllocatorSymbian.cpp: (JSC::ExecutableAllocator::intializePageSize):
  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITArithmetic.cpp:
  • jit/JITInlineMethods.h: (JSC::JIT::beginUninterruptedSequence): (JSC::JIT::restoreArgumentReferenceForTrampoline): (JSC::JIT::emitCount):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • jit/JITStubs.h:
  • runtime/Collector.cpp: (JSC::currentThreadStackBase): (JSC::getPlatformThreadRegisters): (JSC::otherThreadStackPointer):
  • wrec/WREC.h:
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateReturnFailure):
  • wrec/WRECGenerator.h:
  • wtf/FastMalloc.cpp:
  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
  • wtf/Threading.h:
  • wtf/dtoa.cpp:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
  • yarr/RegexJIT.h:

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Reorganize, document and rename CPU() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33145

  • webkit/webkitwebsettings.cpp: (webkit_get_user_agent):

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Reorganize, document and rename CPU() platform macros.
https://bugs.webkit.org/show_bug.cgi?id=33145

  • page/NavigatorBase.cpp:
  • platform/text/AtomicString.cpp: (WebCore::equal):
  • platform/text/StringHash.h: (WebCore::StringHash::equal):
03:37 Changeset [52728] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make bugzilla-tool rollout include a bug link in the ChangeLog entry
https://bugs.webkit.org/show_bug.cgi?id=33146

One more step towards better rollouts.

  • Scripts/webkitpy/changelogs.py:
  • Scripts/webkitpy/changelogs_unittest.py:
  • Scripts/webkitpy/steps/preparechangelogforrevert.py:
03:04 Changeset [52727] by philn@webkit.org
  • 2 edits in trunk/WebCore

2009-12-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GTK] G_OBJECT() cast is not necessary for signals connection and properties access
https://bugs.webkit.org/show_bug.cgi?id=32661

Reverted the SENTINEL / NULL crap :) Hopefully the style-bot won't
complain about NULL usage in g_object_{get,set} anymore.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
03:04 Changeset [52726] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sort the step options
https://bugs.webkit.org/show_bug.cgi?id=33144

  • Scripts/webkitpy/steps/options.py:
02:57 Changeset [52725] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Need support for longer text in per-command help
https://bugs.webkit.org/show_bug.cgi?id=33143

Add some minimal additional help to land-diff and
pave the way for adding better help to all commands.

  • Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
  • Scripts/webkitpy/multicommandtool.py: support long_help
  • Scripts/webkitpy/multicommandtool_unittest.py: test long_help
02:46 Changeset [52724] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add unit test for MarkBugFixed
https://bugs.webkit.org/show_bug.cgi?id=33142

MarkBugFixed is way behind in command technology, but it still needs a
unit test, as the FIXME commands.

Also, remove mark-bug-fixed and create-bug from main help since we have
more modern commands to replace them.

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
02:24 Changeset [52723] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add missing unit test for CommitMessageForCurrentDiff
https://bugs.webkit.org/show_bug.cgi?id=33141

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
02:05 Changeset [52722] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

[Qt] r52694 moved a test, but it isn't renamed in the skiplist.

  • platform/qt/Skipped: animations/transform-origin-vs-functions.html renamed.
01:58 Changeset [52721] by eric@webkit.org
  • 8 edits
    6 adds in trunk

2010-01-04 Alex Milowski <alex@milowski.com>

Reviewed by Eric Seidel.

Added expected outputs for pixel tests that were missing.

  • platform/mac/mathml/presentation/sub-expected.checksum: Added.
  • platform/mac/mathml/presentation/sub-expected.png: Added.
  • platform/mac/mathml/presentation/sup-expected.checksum: Added.
  • platform/mac/mathml/presentation/sup-expected.png: Added.
  • platform/mac/mathml/presentation/tables-expected.checksum: Added.
  • platform/mac/mathml/presentation/tables-expected.png: Added.

2010-01-04 Alex Milowski <alex@milowski.com>

Reviewed by Eric Seidel.

Updated license to match recommended header license.

  • mathml/MathMLElement.cpp:
  • mathml/MathMLElement.h:
  • mathml/MathMLInlineContainerElement.cpp:
  • mathml/MathMLInlineContainerElement.h:
  • mathml/MathMLMathElement.cpp:
  • mathml/MathMLMathElement.h:
01:49 Changeset [52720] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add missing unit test for CommitMessageForCurrentDiff
https://bugs.webkit.org/show_bug.cgi?id=33141

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
01:48 Changeset [52719] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove raw_input from queues in favor of user.prompt
https://bugs.webkit.org/show_bug.cgi?id=33140

This lets up properly mock out the user interaction instead of hacking
around it with the options.

  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queuestest.py:
01:42 Porting Macros plan edited by mjs@apple.com
(diff)
01:42 Changeset [52718] by eric@webkit.org
  • 6 edits
    1 add
    1 delete in trunk

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool should not require users to install mechanize
https://bugs.webkit.org/show_bug.cgi?id=32635

  • .gitignore: Ignore autoinstall.cache.d directory created by autoinstall.py

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool should not require users to install mechanize
https://bugs.webkit.org/show_bug.cgi?id=32635

Use the nifty "autoinstall" module from Daniel Krech:
http://pypi.python.org/pypi/autoinstall/0.2
http://code.google.com/p/pyautoinstall/
It's available under a WebKit-compatible BSD license.

  • Scripts/webkitpy/init.py:
    • bind "mechanize" to an autoinstall importer which will auto-download mechanize if necessary.
  • Scripts/webkitpy/autoinstall.py: Added.
  • Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
  • Scripts/webkitpy/statusbot.py: ditto.
  • Scripts/webkitpy/webkit_mechanize.py: Removed.
01:33 Changeset [52717] by abarth@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Move AbstractSequencedCommand to a more general location
https://bugs.webkit.org/show_bug.cgi?id=33137

I do what the FIXME tell me to do.

  • Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
01:30 Changeset [52716] by abarth@webkit.org
  • 7 edits
    1 move in trunk/WebKitTools

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename StatusBot to StatusServer
https://bugs.webkit.org/show_bug.cgi?id=33139

It's not a bot. It's a server.

  • Scripts/bugzilla-tool:
  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/queueengine.py:
  • Scripts/webkitpy/statusbot.py: Removed.
01:05 Changeset [52715] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] submit-pach should have a -o/--open option to open the bug after submit
https://bugs.webkit.org/show_bug.cgi?id=33136

Python makes this very easy.

  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/steps/options.py:
  • Scripts/webkitpy/steps/postdiff.py:
  • Scripts/webkitpy/user.py:
00:50 Porting Macros plan edited by mjs@apple.com
(diff)
00:47 Changeset [52714] by abarth@webkit.org
  • 5 edits
    23 copies
    1 move
    8 adds
    1 delete in trunk/WebKitTools

2010-01-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Move steps to a submodule
https://bugs.webkit.org/show_bug.cgi?id=33135

For great victory. This will probably introduce some regressions
because our test coverage isn't perfect, but I've tried to be careful.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/buildsteps.py: Removed.
  • Scripts/webkitpy/buildsteps_unittest.py: Removed.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/steps/init.py: Added.
  • Scripts/webkitpy/steps/abstractstep.py: Added.
  • Scripts/webkitpy/steps/applypatch.py: Added.
  • Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
  • Scripts/webkitpy/steps/build.py: Added.
  • Scripts/webkitpy/steps/checkstyle.py: Added.
  • Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
  • Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
  • Scripts/webkitpy/steps/closebug.py: Added.
  • Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
  • Scripts/webkitpy/steps/closepatch.py: Added.
  • Scripts/webkitpy/steps/commit.py: Added.
  • Scripts/webkitpy/steps/completerollout.py: Added.
  • Scripts/webkitpy/steps/confirmdiff.py: Added.
  • Scripts/webkitpy/steps/createbug.py: Added.
  • Scripts/webkitpy/steps/editchangelog.py: Added.
  • Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
  • Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
  • Scripts/webkitpy/steps/metastep.py: Added.
  • Scripts/webkitpy/steps/obsoletepatches.py: Added.
  • Scripts/webkitpy/steps/options.py: Added.
  • Scripts/webkitpy/steps/postdiff.py: Added.
  • Scripts/webkitpy/steps/preparechangelog.py: Added.
  • Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
  • Scripts/webkitpy/steps/promptforbugortitle.py: Added.
  • Scripts/webkitpy/steps/revertrevision.py: Added.
  • Scripts/webkitpy/steps/runtests.py: Added.
  • Scripts/webkitpy/steps/steps_unittest.py: Added.
  • Scripts/webkitpy/steps/update.py: Added.
  • Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
  • Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
  • Scripts/webkitpy/stepsequence.py:
00:43 Changeset [52713] by dbates@webkit.org
  • 4 edits in trunk

2010-01-04 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33097

Cleans up the File menu to better conform to the File menu in Safari
both in terms of options and keyboard shortcuts. Adds a "Quit" menu
options to close all open windows.

  • QGVLauncher/main.cpp: (MainWindow::buildUI):

2010-01-04 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33097

Cleans up the File menu to better conform to the File menu in Safari
both in terms of options and keyboard shortcuts. Adds a "Quit" menu
options to close all open windows. Also, renames the Tools menu to
Develop.

  • QtLauncher/main.cpp: (MainWindow::setupUI):
00:40 Changeset [52712] by dbates@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-04 Daniel Bates <dbates@webkit.org>

https://bugs.webkit.org/show_bug.cgi?id=33039


Unreviewed fix.

  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/credentials_unittest.py:
00:35 Changeset [52711] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-01-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Clean up COMPILER macros and remove unused ones.
https://bugs.webkit.org/show_bug.cgi?id=33132


Removed values are COMPILER(BORLAND) and COMPILER(CYGWIN) - they were
not used anywhere.

  • wtf/Platform.h:
00:30 Changeset [52710] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-04 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33039

[bzt] Second attempt to fix an issue where bugzilla-tool dies
when the keychain lookup fails to find an entry for bugs.webkit.org.

  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/credentials_unittest.py:
00:21 Changeset [52709] by krit@webkit.org
  • 4 edits
    4 adds in trunk

2010-01-03 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResources don't invalidate if target object changes attributes
https://bugs.webkit.org/show_bug.cgi?id=33091

It's neccessary to invalidate all resources of an object, if the attributes of this
target change. Otherwise the saved resource data (like ImageBuffers) don't match
to the new object properties.

Test: svg/custom/resource-invalidate-on-target-update.svg

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged): (WebCore::SVGStyledElement::invalidateResources):
  • svg/SVGStyledElement.h:

2010-01-03 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResources don't invalidate if target object changes attributes
https://bugs.webkit.org/show_bug.cgi?id=33091

Check if SVG resources are invalidated, if target object changes
attributes.

  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
  • svg/custom/resource-invalidate-on-target-update.svg: Added.
00:20 Changeset [52708] by dbates@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-04 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33039

[bzt] Second attempt to fix an issue where bugzilla-tool dies
when the keychain lookup fails to find an entry for bugs.webkit.org.

  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/credentials_unittest.py:
00:13 Changeset [52707] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-01-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
https://bugs.webkit.org/show_bug.cgi?id=33131

Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
but for now we just deploy it everywhere and don't try to fix up the few valid uses
of Command.

  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/multicommandtool.py:

01/03/10:

23:40 Changeset [52706] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-01-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric Seidel.

Update wtf/Platform.h to document the new system for porting macros.
https://bugs.webkit.org/show_bug.cgi?id=33130

  • wtf/Platform.h:
23:15 Changeset [52705] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-03 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix. Need to import ScriptError.

  • Scripts/webkitpy/buildsteps.py:
23:08 Porting Macros plan edited by mjs@apple.com
(diff)
23:08 Changeset [52704] by abarth@webkit.org
  • 7 edits in trunk/WebKitTools

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make it easier to run submit-patch when previous run cancelled
https://bugs.webkit.org/show_bug.cgi?id=33070

This patch renames create-review to submit-patch (as requested by
Maciej).

This patch makes it easier to run submit-patch after the user has
already cancelled a previous run of submit-patch by detecting when we
already have ChangeLogs and reading the bug number from them (and not
attempting to recreate them). Aside from performance and the extra
edit step, this command should not subsume post-dif.

Also, added a --email command line argument so that the output of
prepare-ChangeLog makes sense when it can't find the user's email
address.

  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/buildsteps.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/user.py:
23:04 Changeset [52703] by eric@webkit.org
  • 38 edits
    2 moves in trunk/WebKitTools

2010-01-03 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename Scripts/modules to Scripts/webkitpy
https://bugs.webkit.org/show_bug.cgi?id=33128

Just search-replace and svn mv commands.

  • Scripts/bugzilla-tool:
  • Scripts/check-webkit-style:
  • Scripts/modules: Removed.
  • Scripts/modules/BeautifulSoup.py: Removed.
  • Scripts/modules/init.py: Removed.
  • Scripts/modules/bugzilla.py: Removed.
  • Scripts/modules/bugzilla_unittest.py: Removed.
  • Scripts/modules/buildbot.py: Removed.
  • Scripts/modules/buildbot_unittest.py: Removed.
  • Scripts/modules/buildsteps.py: Removed.
  • Scripts/modules/buildsteps_unittest.py: Removed.
  • Scripts/modules/changelogs.py: Removed.
  • Scripts/modules/changelogs_unittest.py: Removed.
  • Scripts/modules/commands: Removed.
  • Scripts/modules/commands/init.py: Removed.
  • Scripts/modules/commands/commandtest.py: Removed.
  • Scripts/modules/commands/download.py: Removed.
  • Scripts/modules/commands/download_unittest.py: Removed.
  • Scripts/modules/commands/early_warning_system.py: Removed.
  • Scripts/modules/commands/early_warning_system_unittest.py: Removed.
  • Scripts/modules/commands/queries.py: Removed.
  • Scripts/modules/commands/queries_unittest.py: Removed.
  • Scripts/modules/commands/queues.py: Removed.
  • Scripts/modules/commands/queues_unittest.py: Removed.
  • Scripts/modules/commands/queuestest.py: Removed.
  • Scripts/modules/commands/upload.py: Removed.
  • Scripts/modules/commands/upload_unittest.py: Removed.
  • Scripts/modules/comments.py: Removed.
  • Scripts/modules/committers.py: Removed.
  • Scripts/modules/committers_unittest.py: Removed.
  • Scripts/modules/cpp_style.py: Removed.
  • Scripts/modules/cpp_style_unittest.py: Removed.
  • Scripts/modules/credentials.py: Removed.
  • Scripts/modules/credentials_unittest.py: Removed.
  • Scripts/modules/diff_parser.py: Removed.
  • Scripts/modules/diff_parser_unittest.py: Removed.
  • Scripts/modules/executive.py: Removed.
  • Scripts/modules/executive_unittest.py: Removed.
  • Scripts/modules/grammar.py: Removed.
  • Scripts/modules/mock.py: Removed.
  • Scripts/modules/mock_bugzillatool.py: Removed.
  • Scripts/modules/multicommandtool.py: Removed.
  • Scripts/modules/multicommandtool_unittest.py: Removed.
  • Scripts/modules/outputcapture.py: Removed.
  • Scripts/modules/patchcollection.py: Removed.
  • Scripts/modules/queueengine.py: Removed.
  • Scripts/modules/queueengine_unittest.py: Removed.
  • Scripts/modules/scm.py: Removed.
  • Scripts/modules/scm_unittest.py: Removed.
  • Scripts/modules/statusbot.py: Removed.
  • Scripts/modules/stepsequence.py: Removed.
  • Scripts/modules/style: Removed.
  • Scripts/modules/style.py: Removed.
  • Scripts/modules/style_unittest.py: Removed.
  • Scripts/modules/text_style.py: Removed.
  • Scripts/modules/text_style_unittest.py: Removed.
  • Scripts/modules/user.py: Removed.
  • Scripts/modules/webkit_logging.py: Removed.
  • Scripts/modules/webkit_logging_unittest.py: Removed.
  • Scripts/modules/webkit_mechanize.py: Removed.
  • Scripts/modules/webkitport.py: Removed.
  • Scripts/modules/webkitport_unittest.py: Removed.
  • Scripts/test-webkit-python: Removed.
  • Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
  • Scripts/validate-committer-lists:
  • Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/buildbot_unittest.py:
  • Scripts/webkitpy/buildsteps.py:
  • Scripts/webkitpy/buildsteps_unittest.py:
  • Scripts/webkitpy/commands/commandtest.py:
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/download_unittest.py:
  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/early_warning_system_unittest.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/queries_unittest.py:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/queuestest.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/comments.py:
  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/credentials_unittest.py:
  • Scripts/webkitpy/executive.py:
  • Scripts/webkitpy/executive_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/multicommandtool.py:
  • Scripts/webkitpy/multicommandtool_unittest.py:
  • Scripts/webkitpy/queueengine.py:
  • Scripts/webkitpy/queueengine_unittest.py:
  • Scripts/webkitpy/scm.py:
  • Scripts/webkitpy/scm_unittest.py:
  • Scripts/webkitpy/statusbot.py:
  • Scripts/webkitpy/stepsequence.py:
  • Scripts/webkitpy/webkit_logging_unittest.py:
  • Scripts/webkitpy/webkitport_unittest.py:
22:58 Porting Macros plan edited by mjs@apple.com
(diff)
22:54 Porting Macros plan edited by mjs@apple.com
(diff)
22:50 Porting Macros plan created by mjs@apple.com
22:49 WikiStart edited by mjs@apple.com
(diff)
22:31 Changeset [52702] by eric@webkit.org
  • 3 edits
    1 move
    1 add in trunk/WebKitTools

2010-01-03 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Added script to test both Perl and Python, and renamed
run-webkit-unittests to test-webkit-python.

https://bugs.webkit.org/show_bug.cgi?id=33045

  • Scripts/VCSUtils_unittest.pl:
    • Tweaked so it can be run from outside Scripts directory.
  • Scripts/run-webkit-unittests: Removed.
    • Renamed to test-webkit-python.
  • Scripts/test-webkit-perl:
    • Tweaked so it can be run from outside Scripts directory.
  • Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
  • Scripts/test-webkit-scripts: Added.
    • Runs both test-webkit-perl and test-webkit-python.
19:12 Changeset [52701] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue/bugzilla-tool should build both Debug and Release
https://bugs.webkit.org/show_bug.cgi?id=28450

Add a --build-style command that lets the master process tell the child
process to build both debug and release. Eventually we want to teach
the test step to understand this option too, but that's a patch for
another day.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/webkitport.py:
  • Scripts/modules/webkitport_unittest.py:
18:40 Changeset [52700] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-01-03 Kenneth Russell <kbr@google.com>

Reviewed by Maciej Stachowiak.

Index validation code must always copy client data
https://bugs.webkit.org/show_bug.cgi?id=32748

Client data must always be copied during bufferData and
bufferSubData calls, because otherwise the data the GL uses to
draw may differ from that checked by the index validation code.

  • fast/canvas/webgl/index-validation-copies-indices-expected.txt: Added.
  • fast/canvas/webgl/index-validation-copies-indices.html: Added.

2010-01-03 Kenneth Russell <kbr@google.com>

Reviewed by Maciej Stachowiak.

Index validation code must always copy client data
https://bugs.webkit.org/show_bug.cgi?id=32748

Client data must always be copied during bufferData and
bufferSubData calls, because otherwise the data the GL uses to
draw may differ from that checked by the index validation code.

Test: fast/canvas/webgl/index-validation-copies-indices.html

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::WebGLBuffer): (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData):
  • html/canvas/WebGLBuffer.h:
18:32 Changeset [52699] by eric@webkit.org
  • 6 edits in trunk

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Implement CookieJarChromium::cookiesEnabled
https://bugs.webkit.org/show_bug.cgi?id=33123

Call out to ChromiumBridge to find out if cookies are enabled.

  • platform/chromium/ChromiumBridge.h:
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::cookiesEnabled):

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Implement CookieJarChromium::cookiesEnabled
https://bugs.webkit.org/show_bug.cgi?id=33123

Call out to the webKitClient() to see if cookies are enabled. Also
remove some straggling references to policyURL!

  • public/WebKitClient.h: (WebKit::WebKitClient::setCookies): (WebKit::WebKitClient::cookies): (WebKit::WebKitClient::rawCookies): (WebKit::WebKitClient::cookiesEnabled):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cookiesEnabled):
18:24 Changeset [52698] by eric@webkit.org
  • 11 edits in trunk

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove evaluateInNewContext (it's useless)
https://bugs.webkit.org/show_bug.cgi?id=33068

This function has no clients and makes life complicated. Isolated
worlds won out over NewContext and there's not really any going back
now.

No new tests because this is all minus lines.

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertWindowToV8Object):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Remove evaluateInNewContext (it's useless)
https://bugs.webkit.org/show_bug.cgi?id=33068

This function has no clients and makes life complicated. Isolated
worlds won out over NewContext and there's not really any going back
now.

  • public/WebFrame.h:
  • src/FrameLoaderClientImpl.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
18:17 Changeset [52697] by eric@webkit.org
  • 4 edits in trunk

2010-01-03 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] EventSender: add support for Enter key events
https://bugs.webkit.org/show_bug.cgi?id=33064

Unskip 5 tests that are fixed now.

  • platform/qt/Skipped:

2010-01-03 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Eric Seidel.

[Qt] EventSender: add support for Enter key events
https://bugs.webkit.org/show_bug.cgi?id=33064

Unskip 5 tests that are fixed now.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
18:10 Changeset [52696] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Add test for previous typo fix
https://bugs.webkit.org/show_bug.cgi?id=33083

A trivial test for a trivial fix, as requested by Eric.

  • Scripts/modules/bugzilla_unittest.py:
18:03 Changeset [52695] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement mac-ews
https://bugs.webkit.org/show_bug.cgi?id=33072

The mac-ews is slightly different than the other early warning systems
because we can't run Mac OS X inside a VM. For that reason, we only
process patches that were uploaded by committers. This isn't as much
coverage as the other EWS bots, but it's better than nothing.

  • Scripts/modules/commands/early_warning_system.py:
  • Scripts/modules/commands/early_warning_system_unittest.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/queuestest.py:
  • Scripts/modules/mock_bugzillatool.py:
17:55 Changeset [52694] by eric@webkit.org
  • 1 edit
    12 moves
    3 adds in trunk/LayoutTests

2010-01-03 Mario Bensi <mbensi@pleyo.com>

Reviewed by Simon Fraser.

create 3d directory and move tests dependent of 3D Rendering in this
directory.

https://bugs.webkit.org/show_bug.cgi?id=33081

  • animations/3d: Added.
  • animations/3d/change-transform-in-end-event.html: Copied from LayoutTests/animations/change-transform-in-end-event.html.
  • animations/3d/state-at-end-event-transform.html: Copied from LayoutTests/animations/state-at-end-event-transform.html.
  • animations/3d/transform-origin-vs-functions-expected.txt: Copied from LayoutTests/animations/transform-origin-vs-functions-expected.txt.
  • animations/3d/transform-origin-vs-functions.html: Copied from LayoutTests/animations/transform-origin-vs-functions.html.
  • animations/change-transform-in-end-event.html: Removed.
  • animations/state-at-end-event-transform.html: Removed.
  • animations/transform-origin-vs-functions-expected.txt: Removed.
  • animations/transform-origin-vs-functions.html: Removed.
13:48 Changeset [52693] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip test that fails on and off on the release bot.

13:25 Changeset [52692] by ddkilzer@apple.com
  • 6 edits in trunk/WebKitTools

Refactored svn-apply and svn-unapply to use a common "patch"
command method, and added unit tests for this new method.

Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-03
Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=33098

  • Scripts/VCSUtils.pm:
    • Added generateRunPatchCommand().
    • Added runPatchCommand().
    • Added exitStatus() from webkitdirs.pm to address FIXME.
  • Scripts/VCSUtils_unittest.pl:
    • Added 10 unit tests for generateRunPatchCommand().
    • Added 4 unit tests for runPatchCommand().
    • Added callSilently() method.
  • Scripts/svn-apply:
    • Refactored applyPatch().
    • Removed $pathScriptWasRunFrom global variable.
    • Addressed issue where "--force" option was getting added twice.
  • Scripts/svn-unapply:
    • Refactored applyPatch().
    • Removed $pathScriptWasRunFrom global variable.
    • Added support for --force option.
    • Enhanced to return meaningful exit status.
  • Scripts/webkitdirs.pm:
    • Moved exitStatus() implementation to VCSUtils.pm.
11:39 Changeset [52691] by weinig@apple.com
  • 4 edits in trunk/WebCore

Rubber-stamped by Dan Bernstein.

Remove out of date commented out attributes in IDLs. We have implemented onpopstate.

  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.idl:
  • page/DOMWindow.idl:
11:36 Changeset [52690] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebKit/qt

2009-12-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable all HTML5 persistent features for QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=33086

  • QGVLauncher/main.cpp: Call enablePersistentStorage() (main):
09:45 Changeset [52689] by krit@webkit.org
  • 5 edits in trunk/WebCore

2010-01-03 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Mark more filter effect as alphaImage if possible
https://bugs.webkit.org/show_bug.cgi?id=33111

Mark more effects as alphaImage if the previous effect is a
alphaImage. This can reduce the calculation on the next effect
like feGaussianBlur.


Test: This changes don't affect any LayoutTests and can't be tested

somehow, since the changes are 'invisible'.

  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
Note: See TracTimeline for information about the timeline view.