Timeline


and

01/11/10:

23:25 Changeset [53117] by mjs@apple.com
  • 2 edits in trunk/WebKitSite

Not reviewed; updated for truth (and readability).

Fixed some wrong listings and reorganized this page.

  • security/security-group-members.html:
22:46 Changeset [53116] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-11 Kent Tamura <tkent@chromium.org>

Unreviewd. Remove a duplicated line in an expectation file.

  • platform/mac-leopard/fast/text/find-kana-expected.txt:
21:53 Changeset [53115] by darin@apple.com
  • 3 edits in trunk/LayoutTests

Try to get find-kana tests passing on Qt, Leopard, and Tiger.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Expect more failures.
  • platform/qt/fast/text/find-kana-expected.txt: Ditto.
17:48 Changeset [53114] by darin@apple.com
  • 7 edits in trunk

Fix handling of unusual kana sequences in search
https://bugs.webkit.org/show_bug.cgi?id=33506

Reviewed by Dan Bernstein.

WebCore:

  • editing/TextIterator.cpp:

(WebCore::composedVoicedSoundMark): Removed unnnecessary case for a
non-kana-letter character. This function only works for kana letters.
(WebCore::SearchBuffer::isBadMatch): Fixed voiced sound mark code to
properly handle cases where one character has a shorter list of
combining voiced sound marks than the other.

LayoutTests:

  • fast/text/find-kana-expected.txt: Updated.
  • fast/text/script-tests/find-kana.js: Added new tests for sequences

that do not have composed equivalents. This is needed to test the code
that compares voice marks. The old test cases didn't cover the combining
character code path because normalizing to NFC combined all the sequences.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Updated.
  • platform/qt/fast/text/find-kana-expected.txt: Updated.
17:22 Changeset [53113] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Victor Wang <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

Clear m_acceptedIndexOnAbandon flag when user accepts the selected index.

https://bugs.webkit.org/show_bug.cgi?id=33499

TEST: manual-tests/chromium/onchange-reload-popup.html
It should be covered by the above test. The current
test shell does not support sending keyboard events to popup
list so use manual test for it.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::acceptIndex):
16:55 Changeset [53112] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after introduction of JS_NO_EXPORT

16:42 Changeset [53111] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Eric Seidel.

[GTK] Debug bots crashing in plugins/iframe-shims.html
https://bugs.webkit.org/show_bug.cgi?id=33472

Call computeOffsetInContainerNode() instead of
offsetInContainerNode(), since we are not sure this is always
parent-anchored.

plugins/iframe-shims.html no longer ASSERTS

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
16:15 Changeset [53110] by simon.fraser@apple.com
  • 17 edits in trunk

2010-01-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=33455
Allows plugins to participate in accelerated compositing

For plugins using the CoreAnimation rendering mode, host their CALayers in the
accelerated compositing layer tree.

This requires making normal flow RenderLayers for RenderEmbeddedObjects when they represent
a plugin using this mode.

  • WebCore.base.exp: Export Node::setNeedsStyleRecalc() for use by WebKit.
  • WebCore.xcodeproj/project.pbxproj: Re-order files for sorting.
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::requiresLayer): Make a layer if the plugin is using accelerated compositing mode. (WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing): Asks whether the plugin has a layer, via PluginWidget.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer): RenderEmbeddedObjects should be normal flow layers, and self-painting layers.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Parent the plugin's layer in the GraphicsLayer when updating the layer configuration.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingLayer): (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): RenderEmbeddedObjects that allow accelerated compositing trip accelerated compositing mode for the page.
16:09 Changeset [53109] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Fixed an uninitialized PluginView member (m_mode) which wasn't
set when constructed with a null PluginPackage*

https://bugs.webkit.org/show_bug.cgi?id=33468

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
16:02 Changeset [53108] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt

2010-01-11 William Siegrist <wsiegrist@apple.com>

Sync new Disallow rules from build.webkit.org.

15:58 Changeset [53107] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html

2010-01-11 William Siegrist <wsiegrist@apple.com>

Add Console and CQ Bot Status links to build.webkit.org. Sync CSS changes.

15:41 Changeset [53106] by eric@webkit.org
  • 7 edits in trunk

2010-01-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG radialGradient example radial-gradient-with-outstanding-focalPoint.svg fails
https://bugs.webkit.org/show_bug.cgi?id=32201

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:

2010-01-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG radialGradient example radial-gradient-with-outstanding-focalPoint.svg fails
https://bugs.webkit.org/show_bug.cgi?id=32201

This patch moves every focalPoint that lies outside the circle defined by the radial
gradients central point and its radius to stay inside this circle, as demanded by the
SVG 1.1 specification.
We use r * 0.99 as maximum radius for the aforementioned circle, when determining where
the focalPoint is lying, to achieve compatibility with Firefox.

  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
15:35 Changeset [53105] by eric@webkit.org
  • 5 edits
    2 deletes in trunk/WebKitTools

2010-01-11 Eric Seidel <eric@webkit.org>

No review, rolling out r53079.
http://trac.webkit.org/changeset/53079
https://bugs.webkit.org/show_bug.cgi?id=33197

Adam doens't think this actually works, and believe it caused
a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
rolling this out.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
  • Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
15:00 Changeset [53104] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=33493
Log redirect details to Network channel

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Log response code and Location header field value. Also, removed a redundant null check.
14:56 Changeset [53103] by bdakin@apple.com
  • 13 edits
    8 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33491 REGRESSION:
Many SVG -webkit-shadow tests are currently failing (in the pixel
tests)
-and-
<rdar://problem/7501200>

Reviewed by Oliver Hunt.

The real fix here is to call inflateForShadow() on the repaintRect
in prepareToRenderSVGContent(). But in order to do that, I had to
move inflateForShadow() to a different class since functions in
SVGRenderBase cannot call each other. inflateForShadow() now exists
in SVGRenderStyle which I think makes some sense because a similar
function that returns a box shadow's extent exists on RenderStyle.

Now call inflateForShadow() through the SVGRenderStyle.

  • rendering/RenderForeignObject.cpp:

(WebCore::RenderForeignObject::computeRectForRepaint):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::computeRectForRepaint):

  • rendering/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::computeRectForRepaint):

No longer implement inflateForShadow() here.

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent): Call new
inflateForShadow() through the SVGRenderStyle

  • rendering/SVGRenderSupport.h:

Implementation of inflateForShadow() now lives here.

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::getSVGShadowExtent):
(WebCore::SVGRenderStyle::inflateForShadow):

  • rendering/style/SVGRenderStyle.h:

LayoutTests: New tests for https://bugs.webkit.org/show_bug.cgi?id=33491
REGRESSION: Many SVG -webkit-shadow tests are currently failing (in
the pixel tests)
-and-
<rdar://problem/7501200>

Reviewed by Oliver Hunt.

I would like to note that this change fixes some existing layout
tests as well.

  • platform/mac/svg/css/shadow-with-large-radius-expected.checksum: Added.
  • platform/mac/svg/css/shadow-with-large-radius-expected.png: Added.
  • platform/mac/svg/css/shadow-with-large-radius-expected.txt: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.checksum: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.png: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.txt: Added.
  • platform/mac/svg/css/stars-with-shadow-expected.checksum:
  • platform/mac/svg/css/stars-with-shadow-expected.png:
  • svg/css/shadow-with-large-radius.svg: Added.
  • svg/css/shadow-with-negative-offset.svg: Added.
14:52 Changeset [53102] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-11 Eric Seidel <eric@webkit.org>

Rubber-stamped by Csaba Osztrogonac.

Web Inspector: External resource relative URLs cannot be navigated to from the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=33024

  • platform/qt/Skipped: Skip this new test, Qt's DRT doesn't support evaluateInWebInspector()
14:46 Changeset [53101] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=33411

Reviewed by Eric Seidel.

Missing updated test result for gtk.

  • platform/gtk/editing/deleting/5115601-expected.txt:
14:33 Changeset [53100] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-01-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Rewrite relative URLs in the ElementsTreeOutline to make them navigable

Targets for "src" and "href" attribute values in the Elements outline tree
are rewritten to full URLs whenever possible.
https://bugs.webkit.org/show_bug.cgi?id=33024

  • inspector/elements-panel-rewrite-href-expected.txt: Added.
  • inspector/elements-panel-rewrite-href.html: Added.

2010-01-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Rewrite relative URLs in the ElementsTreeOutline to make them navigable

Targets for "src" and "href" attribute values in the Elements outline tree
are rewritten to full URLs whenever possible.
https://bugs.webkit.org/show_bug.cgi?id=33024

Test: inspector/elements-panel-rewrite-href.html

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._rewriteAttrHref): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
  • inspector/front-end/inspector.js:
14:20 Changeset [53099] by oliver@apple.com
  • 2 edits in trunk/SunSpider

2010-01-11 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Sunspider parse-only tests don't run
https://bugs.webkit.org/show_bug.cgi?id=33489

Fix parse-only test list

  • tests/parse-only/LIST:
14:17 Changeset [53098] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

fast/text/international/japanese-kana-letters.html
removed by r53078, so it should be removed from skiplist.

  • platform/qt/Skipped: fast/text/international/japanese-kana-letters.html removed.
13:54 Changeset [53097] by ojan@chromium.org
  • 17 edits in trunk/LayoutTests

2010-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Simon Fraser.

Deflake transitions and animations tests.
https://bugs.webkit.org/show_bug.cgi?id=30029

The transition-end-event tests all had arbitrary timeouts. Give a consistent
timeout to all of them. Give a generous 1 second of buffer to avoid any possibility
of flakiness. If all the transitionEnd events fire before then, the test still
completes without waiting for the timeout.

  • animations/change-keyframes.html: Increase the wiggle room. It's infrequently flaky now, but it is still a tad bit flaky without this extra wiggle room.
  • transitions/repeated-firing-background-color.html: Remove a gratuitous setTimeout.
  • transitions/transition-end-event-all-properties.html:
  • transitions/transition-end-event-attributes.html:
  • transitions/transition-end-event-container.html:
  • transitions/transition-end-event-helpers.js: (runTransitionTest.startTest): (runTransitionTest):
  • transitions/transition-end-event-left.html:
  • transitions/transition-end-event-multiple-01.html:
  • transitions/transition-end-event-multiple-02.html:
  • transitions/transition-end-event-multiple-03.html:
  • transitions/transition-end-event-multiple-04.html:
  • transitions/transition-end-event-nested.html:
  • transitions/transition-end-event-set-none.html:
  • transitions/transition-end-event-transform.html:
  • transitions/transition-end-event-window.html:
  • transitions/zero-duration-with-non-zero-delay-end.html:
13:46 Changeset [53096] by darin@apple.com
  • 1 edit
    2 copies in trunk/LayoutTests

Try to get find-kana and find-russian tests passing on Qt.

  • platform/qt/fast/text/find-kana-expected.txt: Copied from fast/text/find-kana-expected.txt.
  • platform/qt/fast/text/find-russian-expected.txt: Copied from fast/text/find-russian-expected.txt.

Changed to expect failures because text searching does not use
ICU's usearch on this platform, and the non-usearch code is much
less capable.

13:31 Status created by alex@milowski.com
13:23 WebKit Team edited by jpetsovits@rim.com
Add areas of knowledge to my team member information. (diff)
13:04 MathML edited by alex@milowski.com
(diff)
12:35 Changeset [53095] by ap@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=33482
Add a test for Russian text search

  • fast/text/find-russian-expected.txt: Added.
  • fast/text/find-russian.html: Added.
  • fast/text/script-tests/find-russian.js: Added.
12:33 Changeset [53094] by ossy@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Enable JIT and YARR_JIT if (CPU(X86_64) && OS(LINUX) && GCC_VERSION >= 40100)

Reviewed by Ariya Hidayat.

  • wtf/Platform.h:
12:19 Changeset [53093] by darin@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

Try to get find-kana test passing on Tiger and Leopard.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Copied from fast/text/find-kana-expected.txt.

Changed to expect failures due to an older version of ICU on those platforms.

12:14 Changeset [53092] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Updated Windows expected results after r53085.

Reviewed by NOBODY.

  • platform/win/editing/selection/mixed-editability-10-expected.txt:
11:55 Changeset [53091] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-01-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=33481
Uninitialized data members in ArrayStorage


SunSpider reports no change.

  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): Initialize missing data members in the two cases where we don't use fastZeroedMalloc, so it doesn't happen automatically.
11:53 Changeset [53090] by sfalken@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix ChangeLog

11:45 Changeset [53089] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=33480

Improve debugging reliability for WTF on Windows.
Store WTF static library's PDB file into a better location.

11:42 Changeset [53088] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to fix windows builds, by removing the no-longer existant JSSVGPointListCustom.cpp from JSBindingsAllInOne.cpp.

  • bindings/js/JSBindingsAllInOne.cpp:
11:34 Changeset [53087] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.
Remove extraneous entries from def file causing build warning.

11:23 Changeset [53086] by zimmermann@webkit.org
  • 13 edits
    1 move
    7 adds
    1 delete in trunk

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

svg <text> fails to update when setting x/y
https://bugs.webkit.org/show_bug.cgi?id=22384

Introduce JSSVGPODListCustom, refactoring the existing custom code for SVG POD type lists.
(Currently SVGTransformList/SVGPointList was handled correctly, and SVGLengthList/SVGNumberList not)

Remove the need for custom JSSVG*List.cpp implementations, but instead tweak CodeGeneratorJS.pm,
to call into the new JSSVGPODListCustom methods. Fixes dynamic updates of the SVGTextElement
'rotate' & 'x'/'y' SVG DOM properties.

Tests: svg/custom/text-xy-updates-SVGList.xhtml

svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop.html


  • Android.jscbindings.mk: Remove old files from build, add the new header.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSSVGPODListCustom.h: Copied from bindings/js/JSSVGTransformListCustom.cpp. Refactored code to be sharable between all JSSVG*List classes. (WebCore::JSSVGPODListCustom::finishGetter): (WebCore::JSSVGPODListCustom::finishSetter): (WebCore::JSSVGPODListCustom::finishSetterReadOnlyResult): (WebCore::JSSVGPODListCustom::clear): (WebCore::JSSVGPODListCustom::initialize): (WebCore::JSSVGPODListCustom::getItem): (WebCore::JSSVGPODListCustom::insertItemBefore): (WebCore::JSSVGPODListCustom::replaceItem): (WebCore::JSSVGPODListCustom::removeItem): (WebCore::JSSVGPODListCustom::appendItem):
  • bindings/js/JSSVGPointListCustom.cpp: Removed.
  • bindings/js/JSSVGTransformListCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm: Forward any SVGList call on POD list types to the new JSSVGPODListCustom.
  • svg/SVGNumberList.cpp: Make SVGNumberList a SVGPODList, instead of a SVGList, to make dynamic updates work. (WebCore::SVGNumberList::SVGNumberList):
  • svg/SVGNumberList.h:
  • svg/SVGPointList.idl: Remove JSCCustom markers everywhere.
  • svg/SVGTransformList.idl: Ditto.

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

svg <text> fails to update when setting x/y
https://bugs.webkit.org/show_bug.cgi?id=22384

Add simple tests covering SVGLengthList & SVGNumberList updates.

  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.checksum: Added.
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.png: Added.
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
  • svg/custom/text-xy-updates-SVGList.xhtml: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-rotate-prop.js: Added. (executeTest):
10:04 Changeset [53085] by enrica@apple.com
  • 10 edits in trunk

Cannot focus on an empty editable span in a non editable div.
https://bugs.webkit.org/show_bug.cgi?id=33411
<rdar://problem/5982901>

Reviewed by Darin Adler.

WebCore:

We now allow to set the focus inside an empty inline element if it is the only
editable element inside non-editable content.

  • dom/Position.cpp:

(WebCore::Position::isCandidate): Extended to allow positions in inline elements when
at the border between editable and non editable content.
(WebCore::Position::getInlineBoxAndOffset): Modified to be able to calculate the caret
position inside an empty inline.

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs): When merging, we don't always find a break
element, since now an editable inline is a VisiblePosition if it is at editability boundary.

  • editing/VisibleSelection.h: Updated comment on the use of Position member variables

instead of VisiblePosition.

  • page/Frame.cpp:

(WebCore::Frame::selectionLayoutChanged): Changed to avoid multiple calls to upstream and
downstream on the same position.

LayoutTests:

  • editing/deleting/6026335-expected.txt: Updated to reflect the lack of extra break element.
  • editing/selection/mixed-editability-10-expected.txt: Updated to cover the new case.
  • editing/selection/mixed-editability-10.html: Updated to cover the new case.
  • platform/mac/editing/deleting/5115601-expected.txt: Updated to reflect the lack of extra break element.
09:57 Changeset [53084] by kov@webkit.org
  • 5 edits in trunk

Revert 53075 since it caused ASSERTS to be hit.

09:16 Changeset [53083] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-01-06 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Nikolas Zimmermann.

[V8] IsRefPtrType() in CodeGeneratorV8.pm increases maintenance burden.
https://bugs.webkit.org/show_bug.cgi?id=32994

Refactoring, covered by existings tests.

  • bindings/scripts/CodeGeneratorV8.pm: Reversed testing for ref-counted objects,

since there's a much smaller (and more stable) set of non-ref-counted ones.

09:08 Changeset [53082] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=33472
[GTK] Debug bots crashing in plugins/iframe-shims.html

Skip test that fails on bots, but passes locally, so we can
investigate.

09:05 Changeset [53081] by japhet@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-01-08 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Test that document.referrer is properly preserved through a redirect.

https://bugs.webkit.org/show_bug.cgi?id=33407

  • http/tests/navigation/redirect-preserves-referrer-expected.txt: Added.
  • http/tests/navigation/redirect-preserves-referrer.html: Added.
  • http/tests/navigation/resources/redirect-to-referrer-check.pl: Added.
  • http/tests/navigation/resources/referrer.html: Added.
09:02 Changeset [53080] by knorton@google.com
  • 7 edits in trunk/WebCore

2010-01-11 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Fixes the fact that timeline panel results are skewed by the use of DOM mutation events.
https://bugs.webkit.org/show_bug.cgi?id=32846

Instead of using DOM mutation events in InspectorDOMAgent, InspectorController is now called
directly when the DOM is mutated.

  • dom/ContainerNode.cpp: Calls InspectorController directly when child nodes are added/removed. (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: Calls InspectorController directly when attributes are added/removed. (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::didRemoveDOMNode): (WebCore::InspectorController::didModifyDOMAttr):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr):
  • inspector/InspectorDOMAgent.h:
08:50 Changeset [53079] by abarth@webkit.org
  • 5 edits
    1 copy
    1 add in trunk/WebKitTools

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by David Kilzer.

bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
https://bugs.webkit.org/show_bug.cgi?id=33197

We should just search for bug numbers in the ChangeLogs instead of in
the whole diff.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
  • Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
08:30 Changeset [53078] by darin@apple.com
  • 3 edits
    3 adds
    2 deletes in trunk

REGRESSION: Japanese text search ignores small vs. large and voicing mark differences
https://bugs.webkit.org/show_bug.cgi?id=30437
rdar://problem/7214058

Reviewed by Alexey Proskuryakov.

WebCore:

Test: fast/text/find-kana.html

  • editing/TextIterator.cpp:

(WebCore::isKanaLetter): Added.
(WebCore::isSmallKanaLetter): Added.
(WebCore::composedVoicedSoundMark): Added.
(WebCore::isCombiningVoicedSoundMark): Added.
(WebCore::containsKanaLetters): Added.
(WebCore::normalizeCharacters): Added.
(WebCore::SearchBuffer::SearchBuffer): Initialize the data members
m_targetRequiresKanaWorkaround and m_normalizedTarget.
(WebCore::SearchBuffer::isBadMatch): Added. Checks for matches that
ICU's default collation considers correct, but we consider incorrect.
(WebCore::SearchBuffer::search): Added code to call isBadMatch and
move to the next match with usearch_next if the result is true.

LayoutTests:

  • fast/text/international/japanese-kana-letters-expected.txt: Removed.
  • fast/text/international/japanese-kana-letters.html: Removed.
  • fast/text/find-kana-expected.txt: Added.
  • fast/text/find-kana.html: Added.
  • fast/text/script-tests/find-kana.js: Added.

This includes all the tests that were in the old test removed above, with three
differences:

1) Moved out of "international" directory because Mitz wants to phase that

directory out.

2) Added more tests to cover more cases involving things like decomposed

characters and different voice marks.

3) Used script-tests, so results list passing tests as well as failing tests.

We could still test even more, but this should at least cover all the lines of
code in the current bug fix patch.

08:15 Changeset [53077] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Add private API for QWebFrame scrolling, to maintain binary compatibility with Qt 4.6.

Reviewed by Holger Freyther.

This is just a temporary addition until we have introduced #ifdefs to allow
safely removing the private API again.

  • Api/qwebframe.cpp:

(qtwebkit_webframe_scrollRecursively):

07:52 Changeset [53076] by ddkilzer@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Created a unit-tested function to parse the header block of
a Git or SVN diff -- for future refactoring of svn-apply and
svn-unapply.

Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-11
Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=33447

  • Scripts/VCSUtils.pm:
    • Added parseDiffHeader().
    • Removed irrelevant comment from gitdiff2svndiff().
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
    • Added 48 unit tests for parseDiffHeader().
07:51 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
07:15 Changeset [53075] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

[GTK] couple fixes for signal emissions, and property notifications
https://bugs.webkit.org/show_bug.cgi?id=33428

Fix commitedLoad being called where it should not, causing it to
be called one time too many in some cases. We now match Qt's and
Mac's behavior here.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
  • tests/testloading.c: (load_error_status_changed_cb):
05:16 QtWebKitReleases edited by hausmann@webkit.org
(diff)
04:23 Changeset [53074] by ossy@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-11
[Qt] Add expected files for the following passing new tests.
Compared to the mac expected files these only differ in svg dumping style and font metrics.

  • platform/qt/fast/repaint/block-no-inflow-children-expected.txt: Added.
  • platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
  • platform/qt/svg/custom/marker-referencePoint-expected.txt: Added.
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt: Added.
  • platform/qt/svg/text/selection-background-color-expected.txt: Added.
04:12 Changeset [53073] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix.

  • platform/qt/Skipped:
04:03 Changeset [53072] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-11 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text

  • accessibility/gtk/AccessibilityObjectWrapperAtk.h
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored): (webkit_accessible_text_get_caret_offset):
  • editing/gtk/SelectionControllerGtk.cpp: (SelectionController::notifyAccessibilityForSelectionChange)

Adjust the caret offset and object with focus to reflect the
unignored parent of the static text object which contains the
caret. This is necessary because the static text objects are
no longer being exposed to ATs.

03:48 Changeset [53071] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html fails on buildbot
https://bugs.webkit.org/show_bug.cgi?id=33465

  • platform/qt/Skipped: fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html skipped.
03:35 Changeset [53070] by zimmermann@webkit.org
  • 45 edits in trunk/LayoutTests

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Update SVG test baseline, after the SVG text painting changes, a while ago.
The differences are all below <0.1%, and only show up when running with --tolerance 0.

01:44 Changeset [53069] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2010-01-11 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Touchevent coordinates are incorrect after page zoom and page scroll
https://bugs.webkit.org/show_bug.cgi?id=32899

  • fast/events/touch-coords-in-zoom-and-scroll-expected.txt: Added.
  • fast/events/touch-coords-in-zoom-and-scroll.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:

2010-01-11 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Touchevent coordinates are incorrect after page zoom and page scroll
https://bugs.webkit.org/show_bug.cgi?id=32899

Test: fast/events/touch-coords-in-zoom-and-scroll.html

  • dom/Touch.cpp: (WebCore::contentsX): (WebCore::contentsY):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
01:20 Changeset [53068] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-11 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Have "Paste and Match Style" fire the dom paste event.
https://bugs.webkit.org/show_bug.cgi?id=30639

  • editing/execCommand/paste-and-match-style-event.html: Added.

2010-01-11 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Have "Paste and Match Style" fire the dom paste event.
https://bugs.webkit.org/show_bug.cgi?id=30639

Test: editing/execCommand/paste-and-match-style-event.html

  • editing/Editor.cpp: (WebCore::Editor::pasteAsPlainText):

01/10/10:

22:53 Changeset [53067] by oliver@apple.com
  • 2 edits in trunk/WebCore

Rollout renderpath culling as it once again breaks pixel tests.

22:14 Changeset [53066] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-01-10 Adam Barth <abarth@webkit.org>

Rubber stamped by David Kilzer.

bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
https://bugs.webkit.org/show_bug.cgi?id=33197

Fix a typo: Commmand -> Command.

  • Scripts/webkitpy/commands/abstractsequencedcommand.py:
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/multicommandtool.py:
22:09 Changeset [53065] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-10 Daniel Bates <dbates@webkit.org>

Unreviewed, fix typo.


Fixed typo in test LayoutTests/fast/events/frame-programmatic-focus.html.
The word "frame" should be "iframe" in the string "<input> in frame blurred"
based on the context of the test. In particular, the line "<input> in iframe focused"
and the use of an iframe in the test.

  • fast/events/frame-programmatic-focus-expected.txt:
  • fast/events/frame-programmatic-focus.html:
21:36 Changeset [53064] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-10 Daniel Bates <dbates@webkit.org>

Rubber-stamped by Eric Seidel.

Adding XSSAuditor test http/tests/security/xssAuditor/malformed-HTML.html
to the Qt Skipped file as it times out. We need to look into test further.
See bug #33460 for more details.

  • platform/qt/Skipped:
21:11 Changeset [53063] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Let webkit-patch work with options in $EDITOR
https://bugs.webkit.org/show_bug.cgi?id=33414

The $EDITOR evironment variable might have command line options like
bbedit -w. This patch lets us run those $EDITORs.

  • Scripts/webkitpy/user.py:
20:55 Changeset [53062] by eric@webkit.org
  • 10 edits in trunk

2010-01-10 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319

"" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):
  • tests/mozilla/ecma_2/RegExp/properties-001.js: (AddRegExpCases):
  • tests/mozilla/js1_2/regexp/toString.js: Update relevant Mozilla tests (Mozilla has had this behavior since November 2003).

2010-01-10 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319

Add new test cases and adapt existing ones.

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/regexp-compile-expected.txt:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
20:34 Changeset [53061] by darin@apple.com
  • 120 edits in trunk/JavaScriptCore
  • tests/mozilla/ecma/Array/15.4.1.1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.1.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.1-1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.2-1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.2-2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.3.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.3.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.3.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.4.1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.4.js: Added property allow-tabs.
  • tests/mozilla/ecma/LexicalConventions/7.7.4.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.13.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.16.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.18.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.4.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.5.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.7.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.1.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.3.1-3.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.3.1-4.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.3.js: Added property allow-tabs.
  • tests/mozilla/ecma/TypeConversion/9.5-2.js: Added property allow-tabs.
  • tests/mozilla/ecma/jsref.js: Modified property allow-tabs.
  • tests/mozilla/ecma/shell.js: Modified property allow-tabs.
  • tests/mozilla/ecma_2/LexicalConventions/keywords-001.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/RegExp/exec-001.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/String/match-004.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/String/replace-001.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/String/split-002.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/jsref.js: Modified property allow-tabs.
  • tests/mozilla/ecma_2/shell.js: Added property allow-tabs.
  • tests/mozilla/ecma_3/Date/shell.js: Modified property allow-tabs.
  • tests/mozilla/ecma_3/Exceptions/regress-181654.js: Added property allow-tabs.
  • tests/mozilla/ecma_3/RegExp/regress-209067.js: Added property allow-tabs.
  • tests/mozilla/ecma_3/RegExp/regress-85721.js: Added property allow-tabs.
  • tests/mozilla/importList.html: Added property allow-tabs.
  • tests/mozilla/js1_1/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/general1.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/general2.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/slice.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/splice1.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/splice2.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Objects/toString-001.js: Added property allow-tabs.
  • tests/mozilla/js1_2/String/charCodeAt.js: Added property allow-tabs.
  • tests/mozilla/js1_2/String/concat.js: Modified property allow-tabs.
  • tests/mozilla/js1_2/String/match.js: Added property allow-tabs.
  • tests/mozilla/js1_2/String/slice.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/Function_object.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/Number.js: Modified property allow-tabs.
  • tests/mozilla/js1_2/function/String.js: Modified property allow-tabs.
  • tests/mozilla/js1_2/function/nesting.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/regexparg-1.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/regexparg-2-n.js: Added property allow-tabs.
  • tests/mozilla/js1_2/jsref.js: Added property allow-tabs.
  • tests/mozilla/js1_2/operator/equality.js: Added property allow-tabs.
  • tests/mozilla/js1_2/operator/strictEquality.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_dollar_number.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_input.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_input_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastIndex.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastMatch.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastMatch_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastParen.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastParen_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_leftContext.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_leftContext_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_multiline.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_object.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_rightContext.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_rightContext_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/alphanumeric.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/asterisk.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/backslash.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/backspace.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/beginLine.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/character_class.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/compile.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/control_characters.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/digit.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/dot.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/endLine.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/everything.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/exec.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/flags.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/global.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/hexadecimal.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/ignoreCase.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/interval.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/octal.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/parentheses.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/plus.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/question_mark.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/simple_form.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/source.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/special_characters.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/string_replace.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/string_search.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/string_split.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/test.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/toString.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/vertical_bar.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/whitespace.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/word_boundary.js: Added property allow-tabs.
  • tests/mozilla/js1_2/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/break.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/continue.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/do_while.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/switch.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/switch2.js: Added property allow-tabs.
  • tests/mozilla/js1_3/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_4/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_5/Regress/regress-111557.js: Added property allow-tabs.
  • tests/mozilla/js1_5/Regress/regress-216320.js: Added property allow-tabs.
  • tests/mozilla/menuhead.html: Added property allow-tabs.
  • tests/mozilla/mklistpage.pl: Added property allow-tabs.
  • tests/mozilla/runtests.pl: Added property allow-tabs.
20:09 Changeset [53060] by eric@webkit.org
  • 9 edits in trunk

2010-01-10 Robert Hogan <robert@roberthogan.net>

Reviewed by Adam Barth.

[Qt] Add enableXSSAuditor support to QWebSettings and DRT.

https://bugs.webkit.org/show_bug.cgi?id=33419

  • platform/qt/Skipped:

2010-01-10 Robert Hogan <robert@roberthogan.net>

Reviewed by Adam Barth.

[Qt] Add enableXSSAuditor support to QWebSettings and DRT.

https://bugs.webkit.org/show_bug.cgi?id=33419

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-01-10 Robert Hogan <robert@roberthogan.net>

Reviewed by Adam Barth.

[Qt] Add enableXSSAuditor support to QWebSettings and DRT.

https://bugs.webkit.org/show_bug.cgi?id=33419

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
19:47 Changeset [53059] by simon.fraser@apple.com
  • 5 edits in trunk/WebCore

2010-01-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Allows plugins to participate in accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=33455

Part 1: rename setContentsToVideo() on GraphicsLayer to setContentsToMedia()
to make it more general. Rename associated enums and methods similarly.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToMedia):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToMedia): (WebCore::GraphicsLayerCA::commitLayerChanges): (WebCore::GraphicsLayerCA::updateContentsMediaLayer):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
19:41 Changeset [53058] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

http/tests/messaging/cross-domain-message-event-dispatch.html failed on Gtk Linux 64-Bit Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33458

Fix flakey test. If the machine is very slow, then more than 10ms
might have elapsed between registering the timeout and calling
postMessage. We can't be sure which order they will be called in.
Re-ordering the call guarantees the arrival order, even if it reduces
our coverage slightly.

  • http/tests/messaging/cross-domain-message-event-dispatch.html:
18:59 Changeset [53057] by oliver@apple.com
  • 2 edits in trunk/WebCore

Bad DOM performance in large SVG files
https://bugs.webkit.org/show_bug.cgi?id=30055

Reviewed by Nikolas Zimmerman

Cull RenderPaths before passing on to the underlying graphics system.

16:47 Changeset [53056] by abarth@webkit.org
  • 6 edits
    8 adds in trunk

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Add defensive initialization of iframe sandbox flags
https://bugs.webkit.org/show_bug.cgi?id=32368

Test the mutating the allow-same-origin directive in the sandbox
attribute does not affect the current document (but does affect the
next document).

  • http/tests/security/resources/sandboxed-iframe-origin-add-step1.html: Added.
  • http/tests/security/resources/sandboxed-iframe-origin-add-step2.html: Added.
  • http/tests/security/resources/sandboxed-iframe-origin-remove-step1.html: Added.
  • http/tests/security/resources/sandboxed-iframe-origin-remove-step2.html: Added.
  • http/tests/security/sandboxed-iframe-origin-add-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-origin-add.html: Added.
  • http/tests/security/sandboxed-iframe-origin-remove-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-origin-remove.html: Added.

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Add defensive initialization of iframe sandbox flags
https://bugs.webkit.org/show_bug.cgi?id=32368

We now initialize the SecurityOrigin's sandbox state directly duing
construction. This lets us properly set the isUnique bit.

Tests: http/tests/security/sandboxed-iframe-origin-add.html

http/tests/security/sandboxed-iframe-origin-remove.html

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::setSandboxFlags):
  • page/SecurityOrigin.h:
16:38 Changeset [53055] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Nikolas Zimmermann.

http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349

Previously we were using JavaScript URLs to return to the main event
loop, but that is potentially unreliable because there can be only one
scheduled redirect in flight per frame. Let's try using setTimeout
instead. Notice that there isn't a race condition here because the
event loop will always dispatch the actions in the proper order.

  • http/tests/security/xss-DENIED-window-open-javascript-url.html:
14:53 Changeset [53054] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-10 Adam Barth <abarth@webkit.org>

Unreviewed cosmetic change. Remove the status bubble for mac-ews
because we don't have hardware for it at the moment.

  • QueueStatusServer/templates/statusbubble.html:
13:30 Changeset [53053] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-01-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Inspect Element selects the wrong element.
Drive-by fix that focuses dom tree upon settting focuesDOMNode.

https://bugs.webkit.org/show_bug.cgi?id=33449

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/treeoutline.js: (TreeElement.prototype.select):
13:04 QtWebKitJournal edited by hausmann@webkit.org
(diff)
11:15 Changeset [53052] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-01-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce support for flexible line height in the text editor.

https://bugs.webkit.org/show_bug.cgi?id=33431

11:06 Changeset [53051] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-01-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not repaint line numbers while editing within line.

https://bugs.webkit.org/show_bug.cgi?id=33427

02:27 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
00:14 Changeset [53050] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-01-10 Adam Barth <abarth@webkit.org>

Unreviewed whitespace fixes.

  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateSandboxFlags):
  • loader/FrameLoader.h:
00:10 Changeset [53049] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Unify origin sandbox flag with m_noAccess in SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=32372

It turns out the SandboxOrigin bit is slightly different than the
unique origin concept because the sandbox bit is inherited by iframes.
These concepts are separate in the spec, so I think it's ok to keep
them separate in the implementation as well.

No new tests because there is no behavior change.

  • dom/Document.cpp: (WebCore::Document::cookie): (WebCore::Document::setCookie):
  • loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck):
  • page/SecurityOrigin.cpp: (WebCore::schemesWithUniqueOrigins): (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::taintsCanvas): (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::toString): (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage): (WebCore::SecurityOrigin::canAccessCookies): (WebCore::SecurityOrigin::isUnique):

01/09/10:

19:12 Changeset [53048] by dbates@webkit.org
  • 9 edits in trunk

2010-01-09 Daniel Bates <dbates@webkit.org>

No review, rolling out r53044.
http://trac.webkit.org/changeset/53044
https://bugs.webkit.org/show_bug.cgi?id=33419


We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.

  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:

2010-01-09 Daniel Bates <dbates@webkit.org>

No review, rolling out r53044.
http://trac.webkit.org/changeset/53044
https://bugs.webkit.org/show_bug.cgi?id=33419


We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

2010-01-09 Daniel Bates <dbates@webkit.org>

No review, rolling out r53044.
http://trac.webkit.org/changeset/53044
https://bugs.webkit.org/show_bug.cgi?id=33419


We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.

  • platform/qt/Skipped:
18:52 Changeset [53047] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-09 Daniel Bates <dbates@webkit.org>

No review, rolling out r53045.
http://trac.webkit.org/changeset/53045
https://bugs.webkit.org/show_bug.cgi?id=33440

This fix did not resolve the issue. That is, more XSSAuditor tests are
failing on the Qt bot. So, we're going ultimately going to rollout the
change committed in change set 53044 <http://trac.webkit.org/changeset/53044>,
but we need to first rollout the attempted fix committed in change
set 53045.

  • platform/qt/Skipped:
18:36 Changeset [53046] by abarth@webkit.org
  • 28 edits in trunk

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts to reflect what the method actually
means. This is a trivial change, but it involved touching a lot of
call sites.

  • WebCore.PluginHostProcess.exp:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::canExecuteScripts): (WebCore::ScriptController::executeScript):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::bindingRootObject): (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::jsObjectForPluginElement): (WebCore::ScriptController::executeScriptInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::windowScriptObject):
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/js/ScriptState.cpp: (WebCore::scriptStateFromNode):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::evaluateScript):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::controls):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken):
  • inspector/InspectorController.cpp: (WebCore::canPassNodeToJavaScript):
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isProcessingUserGesture): (WebCore::FrameLoader::open): (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds): (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::bindToWindowObject):

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.

  • WebFrame.cpp: (wxWebFrame::RunScript):
18:00 Changeset [53045] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-09 Daniel Bates <dbates@webkit.org>

Rubber-stamped by Adam Barth.

Adds failing XSSAuditor tests to the Qt Skipped file
while we come up with a fix for them. See bug #33440
for more details.

  • platform/qt/Skipped:
16:40 Changeset [53044] by dbates@webkit.org
  • 9 edits in trunk

2010-01-09 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33419

Adds support for the XSSAuditor to the Qt DRT.

  • Api/qwebsettings.cpp: Updated comment to reflect added key XSSAuditorEnabled.
  • Api/qwebsettings.h: Adds settings key XSSAuditorEnabled.

2010-01-09 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33419

Removes the XSSAuditor tests from the Qt Skipped file since
we now can run these tests.

  • platform/qt/Skipped:

2010-01-09 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33419

Adds support for the XSSAuditor to the Qt DRT.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
16:20 Changeset [53043] by abarth@webkit.org
  • 3 edits
    1 copy
    1 add in trunk/WebKitTools

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Retry writes to QueueStatusServer when we get 500 errors
https://bugs.webkit.org/show_bug.cgi?id=33412

This prevents the queues from failing to mark a patch as "pass" or
"fail" when AppEngine throws 500 errors.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/networktransaction.py: Added.
  • Scripts/webkitpy/networktransaction_unittest.py: Added.
  • Scripts/webkitpy/statusserver.py:
  • Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
  • Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
  • Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
16:18 Changeset [53042] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-09 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

Inspector font for errors is ugly on non-OSX platforms
https://bugs.webkit.org/show_bug.cgi?id=33340

  • css/view-source.css: Add a fallback to sans-serif on a CSS selector that previously only listed Lucida Grande.
16:01 Changeset [53041] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers

Reviewed by Eric Seidel.

  • QueueStatusServer/templates/statusbubble.html: Added

-moz-border-radius and -webkit-border-radius to provide rounded
borders in older Firefox and Safari browsers.

14:50 Changeset [53040] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-09 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by David Kilzer.

Modified VCSUtils::gitdiff2svndiff() to accept strings that
end in vertical white space.

https://bugs.webkit.org/show_bug.cgi?id=33415

  • Scripts/VCSUtils.pm:
  • Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
10:45 Changeset [53039] by mitz@apple.com
  • 5 edits
    4 adds in trunk

<rdar://problem/7525778> Font fallback kills SVG kerning
https://bugs.webkit.org/show_bug.cgi?id=33400

Reviewed by Nikolas Zimmermann.

WebCore:

Test: platform/mac/fast/text/sticky-typesetting-features.html

Cache font attributes separately for different typesetting features.

  • platform/graphics/SimpleFontData.h: Replaced single-element caches

with maps.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::disableLigatures): Added an ATSUStyle parameter.
(WebCore::initializeATSUStyle): Look up the ATSUStyle in the map and
initialize if necessary. Return the ATSUStyle.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
Use the ATSUStyle returned from initializeATSUStyle().

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformDestroy): Destroy the ATSUStyles in the
map.
(WebCore::SimpleFontData::getCFStringAttributes): Look up the attributes
dictionary in the map and initialize if necessary.

LayoutTests:

  • platform/mac/fast/text/sticky-typesetting-features-expected.checksum: Added.
  • platform/mac/fast/text/sticky-typesetting-features-expected.png: Added.
  • platform/mac/fast/text/sticky-typesetting-features-expected.txt: Added.
  • platform/mac/fast/text/sticky-typesetting-features.html: Added.

01/08/10:

23:49 Changeset [53038] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Adam Barth <abarth@webkit.org>

Unreviewed. Fix namespace indent for SecurityOrigin.h.

  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::domainWasSetInDOM): (WebCore::SecurityOrigin::protocol): (WebCore::SecurityOrigin::host): (WebCore::SecurityOrigin::domain): (WebCore::SecurityOrigin::port): (WebCore::SecurityOrigin::canLoadLocalResources): (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::isSandboxed): (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage): (WebCore::SecurityOrigin::):
23:40 Changeset [53037] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-01-08 Adam Barth <abarth@webkit.org>

Reviewed by Dmitry Titov.

bindings/v8/DOMData is missing a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=33390

DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
but it does not have a virtual destructor. While this isn't currently causing
any leaks, since there are no instances of ChildThreadDOMData or
MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
compiler generates the following compilation error:

"/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
functions and accessible non-virtual destructor"

We therefore need to add a virtual destructor to DOMData.

  • bindings/v8/DOMData.cpp: (WebCore::DOMData::~DOMData):
  • bindings/v8/DOMData.h:
23:09 Changeset [53036] by dbates@webkit.org
  • 7 edits in trunk

2010-01-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.
Moreover, fixes all "Weird number of spaces at line-start. Are you using a 4-space indent?"
errors reported by check-webkit-style.

No functionality was changed. So, no new tests.

  • wtf/Platform.h:

2010-01-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.

No functionality was changed. So, no new tests.

  • src/GraphicsContext3D.cpp:

2010-01-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.

No functionality was changed. So, no new tests.

  • platform/graphics/SimpleFontData.h:
  • plugins/PluginPackage.cpp:
20:48 Changeset [53035] by simon.fraser@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

2010-01-08 Simon Fraser <simon.fraser@apple.com>

No review.

Remove layout test that was committed by mistake.

  • compositing/webgl/webgl-blending.html: Removed.
20:07 Changeset [53034] by simon.fraser@apple.com
  • 4 edits
    26 adds in trunk

2010-01-08 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

WebGL canvas paints background color twice
https://bugs.webkit.org/show_bug.cgi?id=33361

Clean up some logic around "directly composited" content: some images, video, and WebGL.

We previously set the GraphicsLayer background color to the CSS background color
in some cases where the box has no other decorations. However, the content
layer's bounds do not correspond with the background box in many cases,
and we could end up both painting the background color, and setting it on the layer.

Simplify this logic to never use layer background colors, and thus skip allocating
backing store only when the element has no visible box decorations.

Tests: compositing/images/direct-image-background-color.html

compositing/reflections/simple-composited-reflections.html
compositing/video/video-background-color.html
compositing/webgl/webgl-background-color.html
compositing/webgl/webgl-blending.html

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::is3DCanvas): Utility to determine if a RenderObject is a canvas with WebGL (WebCore::RenderLayerBacking::RenderLayerBacking): Remove m_hasDirectlyCompositedContent. (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): canUseDirectCompositing() is renamed to isDirectlyCompositedImage() and only applies to images now. No longer set layer background color. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Just use hasPaintedContent() as the argument to setDrawsContent(). (WebCore::hasBoxDecorationsOrBackground): Renamed. (WebCore::RenderLayerBacking::hasNonCompositingContent): (WebCore::hasBoxDecorationsOrBackgroundImage): Renamed from hasBoxDecorations(). (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Moved test for hasOverflowControls() into hasNonCompositingContent() and removed the FIXME comment. (WebCore::RenderLayerBacking::containsPaintedContent): New method that decides if the layer (and its non-composited children) has any content that must be painted into backing store. (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Renamed from canUseDirectCompositing() and reduced to only apply to images. (WebCore::RenderLayerBacking::rendererContentChanged): 3D canvas no longer falls under the canUseDirectCompositing() scope.
18:16 Changeset [53033] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

<http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button

Reviewed by Adam Barth.

This button was broken during a previous Bugzilla upgrade after
changes were made to the names of objects exposed on templates.

  • template/en/custom/attachment/reviewform.html.tmpl: Changed

attachid to attachment.id and ispatch to attachment.ispatch.
Also tweaked the format to use 4 table columns instead of 5.

17:57 Changeset [53032] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Eric Seidel.

Don't store RegExp flags string representation
https://bugs.webkit.org/show_bug.cgi?id=33321

It's unused; the string representation is reconstructed from flags.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h:
17:46 Changeset [53031] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

17:45 Changeset [53030] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.22

New tag.

17:39 Changeset [53029] by mrowe@apple.com
  • 8 edits in branches/safari-4-branch

Merge r52141.

17:39 Changeset [53028] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

17:25 Changeset [53027] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Use member initialization syntax instead of assignment for member variables of Document used
for determining minimum layout delay.
https://bugs.webkit.org/show_bug.cgi?id=33316

No new tests, style change only.

  • dom/Document.cpp: Modified. (WebCore::Document::Document): Modified. Use initializer list for m_startTime, m_overMinimumLayoutThreshold and m_extraLayoutDelay.
17:02 Changeset [53026] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-01-08 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Passing array that is too large to set method of WebGLArrays does not throw an exception
https://bugs.webkit.org/show_bug.cgi?id=33352

Added needed range checks to JSC and V8 custom bindings. Expanded
preexisting test suite for WebGLArrays and updated its expected
results. Tested in WebKit and Chromium.

  • fast/canvas/webgl/array-set-out-of-bounds-expected.txt: Added.
  • fast/canvas/webgl/array-set-out-of-bounds.html: Added.
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-01-08 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Passing array that is too large to set method of WebGLArrays does not throw an exception
https://bugs.webkit.org/show_bug.cgi?id=33352

Added needed range checks to JSC and V8 custom bindings. Expanded
preexisting test suite for WebGLArrays and updated its expected
results. Tested in WebKit and Chromium.

Test: fast/canvas/webgl/array-set-out-of-bounds.html

  • bindings/js/JSWebGLArrayHelper.h: (WebCore::setWebGLArrayFromArray):
  • bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::setWebGLArrayFromArray):
17:02 Changeset [53025] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Memory use grows grows possibly unbounded in this JavaScript Array test case
https://bugs.webkit.org/show_bug.cgi?id=31675

This fixes one observed bug in this test case, which is that
arrays don't report extra cost for the sparse value maps.

SunSpider reports a small speedup.

  • runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): Report extra memory cost for the sparse value map.
  • runtime/JSArray.h:
16:46 Changeset [53024] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

http/tests/xmlhttprequest/logout.html failed on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=31412

  • platform/mac-tiger/Skipped: After talking with Alexey, we're just gonna skip the failing test on Tiger.
16:30 Changeset [53023] by ap@apple.com
  • 3 edits
    6 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=32962
HTML tags are wrongfully parsed when setting innerHTML of a SCRIPT element

Also fixed the same for STYLE elements.

Tests: fast/dom/css-innerHTML.html

fast/dom/script-innerHTML-x.xhtml
fast/dom/script-innerHTML.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): Don't parse JS or CSS as HTML, matching Firefox.
16:20 Changeset [53022] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/win

Build fix, no review.

Protect video control logic inside ENABLE(VIDEO).

  • WebView.cpp:

(WebView::enterFullscreenForNode):
(WebView::exitFullscreen):

  • WebView.h:
16:05 Changeset [53021] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Replacing all RANDOMBLOB calls with ZEROBLOB calls in preparation
for denying RANDOMBLOB calls in HTML5 DB transactions.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33396

  • storage/open-database-while-transaction-in-progress.html:
15:59 Changeset [53020] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Included UNCONFIRMED bugs by default in advanced search query

Rubber-stamped by Alexey Proskuryakov.

  • data/params: Prepended 'bug_status=UNCONFIRMED&' to

'defaultquery' parameter.

15:53 Changeset [53019] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33279
fast/websockets/websocket-event-target.html causes any test after it to fail

  • fast/websockets/script-tests/websocket-event-target.js: The test uses an HTTP server URL to create a WebSocket, so an error may be logged to console when detected (this is timing dependent).
  • platform/mac/Skipped: Removed the test from Skipped list.
15:52 Changeset [53018] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

run-javascriptcore-tests needs a --quiet flag
https://bugs.webkit.org/show_bug.cgi?id=33399

Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.

  • Scripts/webkitpy/steps/runtests.py:
15:35 Changeset [53017] by bdakin@apple.com
  • 9 edits
    8 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>

Reviewed by Oliver Hunt.

Inflate the repaintRect for the shadow using its extent.

  • rendering/RenderForeignObject.cpp:

(WebCore::RenderForeignObject::computeRectForRepaint):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::computeRectForRepaint):

  • rendering/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::computeRectForRepaint):

  • rendering/SVGRenderSupport.cpp:

(WebCore::getSVGShadowExtent):
(WebCore::SVGRenderBase::inflateForShadow):

  • rendering/SVGRenderSupport.h:

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>

Reviewed by Oliver Hunt.

  • fast/repaint/moving-shadow-on-container.html: Added.
  • fast/repaint/moving-shadow-on-path.html: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt: Added.
15:27 Changeset [53016] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

FIX: Make patch status appear on reviewform.html.tmpl

  • template/en/custom/attachment/reviewform.html.tmpl: Check

attachment.ispatch (not just ispatch) when deciding whether
to display patch status. Also update layout a bit.

15:22 Changeset [53015] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-08
Reviewed by Alexey Proskuryakov.

To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
the time when Apache and WebSocketServer is locked by tests.
Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
we need to run http and websocket tests after all other tests.
If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
we need to preserve the given order.

  • Scripts/run-webkit-tests:
15:22 Changeset [53014] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Update data/params parameters

  • data/params: Updated 'timezone' to turn off DST. Updated

'usebugaliases' and 'usevotes' to turn them off.

15:01 Changeset [53013] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't post style-queue pass messages to bugs
https://bugs.webkit.org/show_bug.cgi?id=33404

These messages aren't needed any more now that we have the status
bubble reporting pass events passively.

  • Scripts/webkitpy/commands/queues.py:
14:51 Changeset [53012] by ap@apple.com
  • 4 edits in trunk/LayoutTests

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32294
http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg

Changed the test to not have any funky characters. Filed bug 33400 to track the underlying
problem with kerning.

  • http/tests/uri/escaped-entity-expected.txt:
  • http/tests/uri/escaped-entity.html:
  • platform/mac/Skipped:
14:45 Changeset [53011] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Optimize the number of CPUs used for building Qt and Gtk
https://bugs.webkit.org/show_bug.cgi?id=33394

Instead of hardcoding the number 8, we should read the number of CPUs
from the environment.

  • Scripts/webkitpy/executive.py:
  • Scripts/webkitpy/webkitport.py:
  • Scripts/webkitpy/webkitport_unittest.py:
14:31 Changeset [53010] by dglazkov@chromium.org
  • 15 edits in trunk/LayoutTests

2010-01-08 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

New baselines to reflect the smaller repaint areas caused by r52839
https://bugs.webkit.org/show_bug.cgi?id=33271

  • platform/mac/fast/repaint/background-misaligned-expected.checksum:
  • platform/mac/fast/repaint/background-misaligned-expected.png:
  • platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.checksum:
  • platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum:
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
  • platform/mac/fast/repaint/float-new-in-block-expected.checksum:
  • platform/mac/fast/repaint/float-new-in-block-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/mac/fast/repaint/selected-replaced-expected.checksum:
  • platform/mac/fast/repaint/selected-replaced-expected.png:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.checksum:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.png:
14:29 Changeset [53009] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-01-08 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

WebGLArray subclasses do the wrong conversion in indexSetter
https://bugs.webkit.org/show_bug.cgi?id=33350

  • fast/canvas/webgl/array-setters-expected.txt: Added.
  • fast/canvas/webgl/array-setters.html: Added.
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-01-08 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

WebGLArray subclasses do the wrong conversion in indexSetter
https://bugs.webkit.org/show_bug.cgi?id=33350

Test: fast/canvas/webgl/array-setters.html

  • bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::indexSetter):
  • bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::indexSetter):
14:05 Changeset [53008] by yong.li@torchmobile.com
  • 2 edits in trunk/JavaScriptCore

2010-01-08 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Remove unnecessary #include from FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=33393

  • wtf/FastMalloc.cpp:
14:05 Changeset [53007] by eric@webkit.org
  • 4 edits in trunk/BugsSite

2010-01-08 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Show patch status in bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=33368

This patch adds an iframe to the show_bug page and the edit attachment
page that displays whether the attachment passed the various bots.

  • template/en/custom/attachment/edit.html.tmpl:
  • template/en/custom/attachment/list.html.tmpl:
  • template/en/custom/attachment/reviewform.html.tmpl:
13:49 Changeset [53006] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

transitions/cancel-transition.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33398

There's a race between the check() call and the final
setTimeout. Just remove the final setTimeout and put
its contents in the check call itself.

  • transitions/cancel-transition.html:
13:48 Changeset [53005] by eric@webkit.org
  • 8 edits
    2 moves in trunk

2010-01-08 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Delegation client
https://bugs.webkit.org/show_bug.cgi?id=32826

Factory related code removed from QtAbstractWebPopup. Popups are now created
by ChromeClientQt.
Popup content information struct added to class QtAbstractWebPopup.
PopupMenuClient is now hidden from higher layers.
QtAbstractWebPopup now receives content information and font as parameters
of method populate.
QtFallbackWebPopup moved to WebKit/qt/WebCoreSupport.

  • WebCore.pro:
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::getItems): (WebCore::PopupMenu::show):
  • platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::popupDidHide): (WebCore::QtAbstractWebPopup::valueChanged):
  • platform/qt/QtAbstractWebPopup.h: (WebCore::QtAbstractWebPopup::Item::):
  • platform/qt/QtFallbackWebPopup.cpp: Removed.
  • platform/qt/QtFallbackWebPopup.h: Removed.

2010-01-08 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Delegation client
https://bugs.webkit.org/show_bug.cgi?id=32826

Added method createPopup to ChromeClientQt used to create popups.
QtFallbackWebPopup moved from WebCore/platform/qt to
WebKit/qt/WebCoreSupport.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createPopup):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/QtFallbackWebPopup.cpp: Added. (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate): (WebCore::QtFallbackWebPopup::showPopup): (WebCore::QtFallbackWebPopup::hidePopup): (WebCore::QtFallbackWebPopup::activeChanged): (WebCore::QtFallbackWebPopup::setParent):
  • WebCoreSupport/QtFallbackWebPopup.h: Added. (WebCore::QtFallbackWebPopup::hide):
13:31 Changeset [53004] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-08 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Skip invalid blocks in CSS property declarations.
https://bugs.webkit.org/show_bug.cgi?id=31231
https://bugs.webkit.org/show_bug.cgi?id=26619

This patch makes the CSS parser skip property declarations containing invalid blocks.

  • fast/css/parsing-error-recovery-expected.txt: Added.
  • fast/css/parsing-error-recovery.html: Added.

2010-01-08 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Skip invalid blocks in CSS property declarations.
https://bugs.webkit.org/show_bug.cgi?id=31231
https://bugs.webkit.org/show_bug.cgi?id=26619

This patch makes the CSS parser skip property declarations containing invalid blocks.

Test: fast/css/parsing-error-recovery.html

  • css/CSSGrammar.y:
13:11 Changeset [53003] by cmarrin@apple.com
  • 8 edits in trunk/LayoutTests

Fixed media test failures caused by http://trac.webkit.org/changeset/52998.
The media controller on Windows now has a full-screen button, which changes
the layout and therefore the test results. I regenerated them for
Windows.

13:07 Changeset [53002] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

The Windows Release bots were having trouble with the xmlhttprequest tests, so
they were skipped (r50280). They all currently pass on my machine, so unskipping them now.

  • platform/win/Skipped:
12:49 Changeset [53001] by darin@chromium.org
  • 3 edits
    3 adds in trunk/WebKit/chromium

2010-01-08 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Upstream webkit unit tests from the chromium repository
https://bugs.webkit.org/show_bug.cgi?id=33351

This adds one such test (for KURL) and sets up the test framework.

Switch WebKit to build a static library on all platforms. Add a
webkit_unit_tests executable target that runs the unit tests and also
ensures that we don't have any missing symbols (a function that WebKit
as a shared library used to serve).

Changes chromium_src_dir to ../../WebKit/chromium to match how
WebCore.gyp defines that variable.

  • WebKit.gyp:
  • public/WebKitClient.h: (WebKit::WebKitClient::getPluginList): Remove bogus trailing semi-colon. (WebKit::WebKitClient::decrementStatsCounter): Remove bogus trailing semi-colon. (WebKit::WebKitClient::incrementStatsCounter): Remove bogus trailing semi-colon. (WebKit::WebKitClient::traceEventBegin): Remove bogus trailing semi-colon. (WebKit::WebKitClient::traceEventEnd): Remove bogus trailing semi-colon. (WebKit::WebKitClient::histogramCounts): Remove bogus trailing semi-colon.
  • tests: Added.
  • tests/KURLTest.cpp: Added.
  • tests/WebKitTest.h: Added.
12:31 Changeset [53000] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

AX: CSS content not returned correctly in AX
https://bugs.webkit.org/show_bug.cgi?id=33308

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/css-content-attribute.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

  • platform/mac/accessibility/css-content-attribute-expected.txt: Added.
  • platform/mac/accessibility/css-content-attribute.html: Added.
11:58 Changeset [52999] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

transitions/shorthand-border-transitions.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33276

Yet another transitions test that doesn't give consistent
wiggle room. Make all the wiggle rooms account for >=200ms
instead of some that were only giving 100ms wiggle room.

  • transitions/shorthand-border-transitions.html:
11:23 Changeset [52998] by cmarrin@apple.com
  • 17 edits
    2 adds in trunk

Implement full-screen video for Windows
https://bugs.webkit.org/show_bug.cgi?id=31318

10:55 Changeset [52997] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Unreviewed correction.

Accidentally left unnecessary modification to hdcFromContext
in when landing r52995.

  • WebFrame.cpp:

(hdcFromContext): Back out unneeded modification.

10:54 Changeset [52996] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Matt Perry <mpcomplete@chromium.org>

Reviewed by Adam Barth.

Fix a regression that removed a call to
FrameLoaderClient::didDestroyScriptContextForFrame.
https://bugs.webkit.org/show_bug.cgi?id=33347

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::disposeContextHandles):
10:16 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
09:30 Changeset [52995] by bfulgham@webkit.org
  • 5 edits in trunk

WebCore: WebKit plugins are not rendered during printing.
https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintWindowedPluginIntoContext): Tell

cairo printing surface to flush so that blank regions do
not write over the plugin's paint operations.

  • rendering/RenderLayer.cpp: Build fix.

(WebCore::RenderLayer::beginTransparencyLayers): Correct

method signature missing for ColorSpace.

WebKit/win: Use correct cairo surface data type for handling print operations.
https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

  • WebFrame.cpp:

(scaleFactor): Handle 'scale = 0' case.
(WebFrame::spoolPage): Use scaleFactor helper function. Account for

margin size in region passed to header/footer routines.

(WebFrame::spoolPages): Properly clean up Cairo surface.

09:24 Changeset [52994] by cfleizach@apple.com
  • 7 edits in trunk

REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
https://bugs.webkit.org/show_bug.cgi?id=33300

Reviewed by Eric Seidel.

WebCore:

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):

LayoutTests:

  • platform/mac/Skipped:
06:27 Changeset [52993] by ossy@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed trivail fix. Missing bugzilla link added to ChangeLog.(r52976)

06:22 Changeset [52992] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

r52976 revealed this failure by re-ordering tests.

I do not have a Snow Leopard build to test with, so skipping this
and filed bug https://bugs.webkit.org/show_bug.cgi?id=33372

  • platform/mac-snowleopard/Skipped: platform/mac/editing/input/devanagari-ligature.html skipped.
05:26 Changeset [52991] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in this skiplist by this commit.

  • platform/win/Skipped:
05:08 Changeset [52990] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

r52976 revealed this failure by re-ordering tests.
r52980 corrected the expected results file, but Windows still fails,
presumably due to another test still affecting this one.

Reviewed by Eric Seidel.

I do not have a windows build to test with, so skipping this
and filed bug https://bugs.webkit.org/show_bug.cgi?id=33374

  • platform/win/Skipped: svg/W3C-SVG-1.1/filters-conv-01-f.svg skipped.
04:59 Changeset [52989] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Simon Hausmann.

commit-queue should run run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=33376

I also made it run the python and perl unit tests.

  • Scripts/webkitpy/steps/runtests.py:
  • Scripts/webkitpy/webkitport.py:
04:46 Changeset [52988] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Threading problems with some of the tests
https://bugs.webkit.org/show_bug.cgi?id=30814

We are going to skip all the storage tests until we find the issue
with the threading system in the gtk port.

  • platform/gtk/Skipped:
04:09 Changeset [52987] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Eric Seidel <eric@webkit.org>

No review, rolling out r52983.
http://trac.webkit.org/changeset/52983
https://bugs.webkit.org/show_bug.cgi?id=33321

Broke 59 JavaScriptCore tests. I don't think Kent knew about
run-javascriptcore-tests. Sadly neither does the commit-bot,
yet.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h: (JSC::RegExp::flags):
03:54 Changeset [52986] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-01-08 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

[GTK] loading test should use SoupServer instead of actual sites
https://bugs.webkit.org/show_bug.cgi?id=33353

Make all the loading tests use SoupServer, instead of fetching
stuff from the Internet.

  • tests/testloading.c: (server_callback): (get_uri_for_path): (test_loading_status): (test_loading_error): (test_loading_cancelled): (load_wentback_status_changed_cb): (load_error_test): (test_loading_goback): (main):
03:50 Changeset [52985] by pfeldman@chromium.org
  • 6 edits
    2 adds
    1 delete in trunk/WebCore

2010-01-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Regex-based syntax highlighting is slow.

https://bugs.webkit.org/show_bug.cgi?id=33330

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/JavaScriptHighlighterScheme.js: Removed.
  • inspector/front-end/JavaScriptTokenizer.js: Added. (WebInspector.JavaScriptTokenizer): (WebInspector.JavaScriptTokenizer.prototype.set line): (WebInspector.JavaScriptTokenizer.prototype.getCondition): (WebInspector.JavaScriptTokenizer.prototype.setCondition): (WebInspector.JavaScriptTokenizer.prototype._charAt): (WebInspector.JavaScriptTokenizer.prototype.nextToken):
  • inspector/front-end/JavaScriptTokenizer.re2js: Added.
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
03:44 Changeset [52984] by eric@webkit.org
  • 8 edits in trunk

2010-01-08 Eric Seidel <eric@webkit.org>

No review, rolling out r52981.
http://trac.webkit.org/changeset/52981
https://bugs.webkit.org/show_bug.cgi?id=33319

Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

2010-01-08 Eric Seidel <eric@webkit.org>

No review, rolling out r52981.
http://trac.webkit.org/changeset/52981
https://bugs.webkit.org/show_bug.cgi?id=33319

Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/regexp-compile-expected.txt:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
03:32 Changeset [52983] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Don't store RegExp flags string representation
https://bugs.webkit.org/show_bug.cgi?id=33321

It's unused; the string representation is reconstructed from flags.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h:
03:23 Changeset [52982] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Tor Arne Vestbø.

media/unsupported-tracks.html is failing on Snow Leopard Release bot
https://bugs.webkit.org/show_bug.cgi?id=32339

  • platform/mac-snowleopard/Skipped: Add this to join a bunch of other skipped media tests which time out.
03:17 Changeset [52981] by eric@webkit.org
  • 8 edits in trunk

2010-01-08 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319

"" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

2010-01-08 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319

Add new test cases and adapt existing ones.

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
02:22 Changeset [52980] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Simon Hausmann.

http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg
https://bugs.webkit.org/show_bug.cgi?id=32294

  • platform/mac/Skipped: Add http/tests/uri/escaped-entity.html to Skipped list since it affects later tests.
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Check in correct results.
02:12 Changeset [52979] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Seidel <eric@webkit.org>

Reviewed by Darin Fisher.

REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
https://bugs.webkit.org/show_bug.cgi?id=33300

Skipping platform/mac/accessibility/aria-liveregions-notifications.html
to make the bots green until Chris Fleizach can fix the AX Notification system
to correctly unregister logging callbacks.

  • platform/mac/Skipped:
00:51 Changeset [52978] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

RVCT compiler with "-Otime -O3" optimization tries to optimize out
inline new'ed pointers that are passed as arguments.
Proposed patch assigns new'ed pointer explicitly outside function call.

Patch by Norbert Leser <norbert.leser@nokia.com> on 2010-01-08
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33084

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

00:01 Changeset [52977] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

Remove an unnecessary cacheFlush from ARM_TRADITIONAL JIT
https://bugs.webkit.org/show_bug.cgi?id=33203

Reviewed by Gavin Barraclough.

  • assembler/ARMAssembler.cpp: Remove obsolete linkBranch function.

(JSC::ARMAssembler::executableCopy): Inline a clean linkBranch code.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::getLdrImmAddress): Use inline function.
(JSC::ARMAssembler::getLdrImmAddressOnPool): Ditto.
(JSC::ARMAssembler::patchPointerInternal): Remove an unnecessary cacheFlush.
(JSC::ARMAssembler::linkJump): Use patchPointerInternal instead of linkBranch.
(JSC::ARMAssembler::linkCall): Ditto.
(JSC::ARMAssembler::relinkCall): Ditto.

01/07/10:

23:56 Changeset [52976] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Run the http and websocket tests after all other tests.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Darin Adler.

  • Scripts/run-webkit-tests:
23:41 Changeset [52975] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
https://bugs.webkit.org/show_bug.cgi?id=33311

Reviewed by Gavin Barraclough.

Move compileGetDirectOffset function to common part of JSVALUE32

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):

23:08 Changeset [52974] by eric@webkit.org
  • 5 edits in trunk

2010-01-07 Mike Belshe <mbelshe@chromium.org>

Reviewed by Darin Adler.

Fix Spdy casing to match style guide.

https://bugs.webkit.org/show_bug.cgi?id=33326

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::wasFetchedViaSPDY): (WebCore::ResourceResponse::setWasFetchedViaSPDY):

2010-01-07 Mike Belshe <mbelshe@chromium.org>

Reviewed by Darin Adler.

Fix Spdy casing to match style guide.

https://bugs.webkit.org/show_bug.cgi?id=33326

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasFetchedViaSPDY): (WebKit::WebURLResponse::setWasFetchedViaSPDY):
22:54 Changeset [52973] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Maciej Stachowiak.

Allow call sites to determine if ASSERT_* and LOG_* macros are operational
https://bugs.webkit.org/show_bug.cgi?id=33020

  • wtf/Assertions.h: Set ASSERT_MSG_DISABLED, FATAL_DISABLED, ERROR_DISABLED, LOG_DISABLED to 1 if the compiler does not support variadic macros. Refactor for better readibility.
22:16 Changeset [52972] by dbates@webkit.org
  • 14 edits in trunk

2010-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • Configurations/FeatureDefines.xcconfig:

2010-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • features.gypi:

2010-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • Configurations/FeatureDefines.xcconfig:

2010-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • config.h:

2010-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32987

Added ENABLE_XHTMLMP flag. Disabled by default.

  • configure.ac:
21:54 Changeset [52971] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-07 Afonso R. Costa Jr. <afonso.costa@openbossa.org>

Reviewed by Darin Adler.

As the bug https://bugs.webkit.org/show_bug.cgi?id=30034 is fixed,
the zoomOrNot argument is unnecessary.

  • fast/dom/elementFromPoint-relative-to-viewport.html:
21:47 Changeset [52970] by laszlo.1.gombos@nokia.com
  • 3 edits
    1 add in trunk/JavaScriptCore

2010-01-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Gavin Barraclough.

[Symbian] Port ARM traditional JIT Trampolines to RVCT
https://bugs.webkit.org/show_bug.cgi?id=30552

Take the GCC implementation and mechanically convert
it to RVCT syntax.

Use 'bx rX' instead of 'mov pc, rX' when it is available.

Developed in cooperation with Iain Campbell and Gabor Loki.

  • JavaScriptCore.pri: Extra step to generate RVCT stubs. The script generation intentionally executed all the time not just for RVCT targets.
  • create_rvct_stubs: Added. Perl script to expand precompiler macros for RVCT assembler - the template is defined in JITStubs.cpp.
  • jit/JITStubs.cpp: (JSC::ctiTrampoline): (JSC::ctiVMThrowTrampoline): (JSC::ctiOpThrowNotCaught):
21:12 Changeset [52969] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix some test-webkitpy expectations
https://bugs.webkit.org/show_bug.cgi?id=33345

I forgot to change these when I added the CheckStyle step.

  • Scripts/webkitpy/commands/upload_unittest.py:
20:58 Changeset [52968] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
https://bugs.webkit.org/show_bug.cgi?id=33341

Fix this by moving to the root directory before editing ChangeLogs.
There is a related bug with CheckStyle.

  • Scripts/webkitpy/steps/checkstyle.py:
  • Scripts/webkitpy/steps/editchangelog.py:
19:06 Changeset [52967] by slewis@apple.com
  • 6 edits in trunk/WebCore

Rolled out http://trac.webkit.org/changeset/52778 due to rolling
out http://trac.webkit.org/changeset/52756

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • editing/SelectionController.cpp:

(WebCore::SelectionController::layout):
(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::paintCaret):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::attach):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::attach):

  • page/Frame.cpp:

(WebCore::Frame::revealSelection):

18:51 Changeset [52966] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

media/unsupported-tracks.html is failing on Snow Leopard Release bot
https://bugs.webkit.org/show_bug.cgi?id=32339

This is a speculative fix. I do not have a Snow Leopard machine to test on
and I've not seen mention of someone being able to reproduce this locally.

Prevent watchdog timer from firing after a test completes but before
the next one starts, causing the error to appear in the next test.

  • DumpRenderTree/mac/DumpRenderTree.mm: (dump): Stop the watchdog before printing #EOF for the test content. We only need to care about the JavaScript of the test running too long or some hang in WebCore. Any other failures will be covered by the calling script's own watchdog timer.
18:22 Changeset [52965] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue is stuck spinning due to exception
https://bugs.webkit.org/show_bug.cgi?id=33358

  • Scripts/webkitpy/commands/queues.py:
    • Don't try to stringify the exception.
17:56 Changeset [52964] by slewis@apple.com
  • 7 edits
    2 deletes in trunk

Rollout http://trac.webkit.org/changeset/52756 due to a large performance regression.

WebCore:

  • dom/Document.cpp:

(WebCore::Document::updateLayout):

  • editing/SelectionController.cpp:

(WebCore::SelectionController::SelectionController):
(WebCore::SelectionController::setSelection):

  • editing/SelectionController.h:
  • page/Frame.cpp:

(WebCore::Frame::setCaretVisible):
(WebCore::Frame::selectionLayoutChanged):
(WebCore::Frame::caretBlinkTimerFired):
(WebCore::Frame::selectionBounds):

  • page/FrameView.cpp:

(WebCore::FrameView::needsLayout):

LayoutTests:

  • fast/forms/selection-layout-reentry-strange-case-expected.txt: Removed.
  • fast/forms/selection-layout-reentry-strange-case.html: Removed.
16:57 Changeset [52963] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

More build fix.

  • WebKitPrefix.h: Define JS_EXPORTCLASS here, as well (as empty).
16:44 Changeset [52962] by ggaren@apple.com
  • 4 edits in trunk

Fix a crash seen on the buildbots.

Reviewed by Sam Weinig.

JavaScriptCore:

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init): Disable specific function tracking here,
instead of in WebCore, to ensure that the disabling happens before a
specific function can be registered.

WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase): Don't disable specific
function tracking here; it's too late, as some specific functions
may already have been tracked in the base class constructor.

16:43 Changeset [52961] by ap@apple.com
  • 2 edits in trunk/JavaScriptCore

Mac build fix.

16:36 Changeset [52960] by zimmermann@webkit.org
  • 12 edits
    9 adds in trunk

2010-01-07 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGTextElement & friends need to implement svgAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=33284

Implement svgAttributeChanged() for SVGTextElement & SVGTRefElement. As <text> element contain children,
childrenChanged() has to be implemented as well for SVGTextElement.

Simplify SVGTransformable::parseTransformAttribute() code, clearing lists in the beginning
and on error case, after parsing - previously the calling site had to take care of that.

Tests: svg/dynamic-updates/SVGTRefElement-dom-href-attr.html

svg/dynamic-updates/SVGTextElement-dom-transform-attr.html
svg/dynamic-updates/SVGTextElement-svgdom-transform-prop.html

  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::parseMappedAttribute):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::svgAttributeChanged):
  • svg/SVGTRefElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::svgAttributeChanged): (WebCore::SVGTextElement::childrenChanged):
  • svg/SVGTextElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
  • svg/SVGTransformable.h:
16:28 Changeset [52959] by ap@apple.com
  • 2 edits in trunk/JavaScriptGlue

Mac build fix.

  • config.h: Define JS_EXPORTCLASS for JavaScriptGlue.
16:28 Changeset [52958] by bweinstein@apple.com
  • 3 edits
    1 add in trunk/WebCore

Padding in popup menu gets lost with styled <select> in Windows.
Fixes <rdar://7285538>, and <http://webkit.org/b/33235>.

Reviewed by Adele Peterson.

[Win] Support padding-right on selects when webkit-appearance is off. Added a test
case for narrow selects with -webkit-appearance: none, and padding left and right to
show that both types of padding are honored.

  • manual-tests/select-webkit-appearance-off-narrow-select.html: Added.
  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::calculatePositionAndSize): Use clientPaddingRight instead of a hardcoded constant.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::clientPaddingRight): If webkit-appearance is off, use padding-right instead of
the hardcoded constant.

16:24 Changeset [52957] by ap@apple.com
  • 2 edits in trunk/WebKitLibraries

Not reviewed, build fix.

Windows buid fix - disable warning 4251 (class needs to have dll-interface to be used by
clients of another class). WebCore doesn't use all methods of JSString, so
we don't export all classes clients could theoretically access via JSString.

  • win/tools/vsprops/common.vsprops:
16:15 Changeset [52956] by ap@apple.com
  • 18 edits
    3 adds in trunk

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=33057
REGRESSION(r49365): typeof(xhr.responseText) != "string" in Windows

<rdar://problem/7296920> REGRESSION: WebKit fails to start PeaceKeeper benchmark

Test: fast/js/webcore-string-comparison.html

In r49365, some code was moved from JSString.cpp to JSString.h, and as a result, WebCore
got a way to directly instantiate JSStrings over DLL borders. Since vftable for JSString was
not exported, objects created from WebCore got a different vptr, and JavaScriptCore
optimizations that relied on vptr of all JSString objects being equal failed.

  • config.h: Added a JS_EXPORTCLASS macro for exporting classes. It's currently the same as JS_EXPORTDATA, but it clearly needed a new name.
  • runtime/InitializeThreading.cpp: (JSC::initializeThreadingOnce):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::createNonDefault): (JSC::JSGlobalData::create): (JSC::JSGlobalData::sharedInstance):
  • runtime/JSGlobalData.h: Store vptrs just once, no need to repeatedly pick and copy them. This makes it possible to assert vptr correctness in object destructors (which don't have access to JSGlobalData, and even Heap::heap(this) will fail for fake objects created from storeVPtrs()).
  • runtime/JSArray.cpp: (JSC::JSArray::~JSArray): Assert that vptr is what we expect it to be. It's important to assert in destructor, because MSVC changes the vptr after constructor is invoked.
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::~JSByteArray): Ditto.
  • runtime/JSByteArray.h: Ditto.
  • runtime/JSFunction.h: Ditto.
  • runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction): Ditto.
  • runtime/JSCell.h: (JSC::JSCell::setVPtr): Added a method to substitute vptr for another one.
  • runtime/JSString.h: Export JSString class together with its vftable, and tell other libraries tp import it. This is needed on platforms that have a separate JavaScriptCore dynamic library - and on Mac, we already did the export via JavaScriptCore.exp. (JSC::JSString::~JSString): Assert tha vptr is what we expect it to be. (JSC::fixupVPtr): Store a previously saved primary vftable pointer (do nothing if building JavaScriptCore itself). (JSC::jsSingleCharacterString): Call fixupVPtr in case this is call across DLL boundary. (JSC::jsSingleCharacterSubstring): Ditto. (JSC::jsNontrivialString): Ditto. (JSC::jsString): Ditto. (JSC::jsSubstring): Ditto. (JSC::jsOwnedString): Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export the new static JSGlobalData members that are used in WebCore via inline functions.
15:51 Changeset [52955] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Account for scale and current context position (as well as page
position) in the device context world transform passed to
plugins. This is especially important for print surface DPI.
http://bugs.webkit.org/show_bug.cgi?id=32909.

Reviewed by Jon Honeycutt.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintWindowedPluginIntoContext): Revise

world context handling to include scaling and translation
already set for the CTM.

15:44 Changeset [52954] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Don't leak a JSStringRef within _accessibilityNotificationCallback.

Reviewed by Jon Honeycutt.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
when it goes out of scope.

15:33 Changeset [52953] by mjs@apple.com
  • 2 edits in trunk/WebKit/mac

2010-01-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Simon Fraser.

REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report )
https://bugs.webkit.org/show_bug.cgi?id=33348
<rdar://problem/7310616>


  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): We only want to handle file: URLs for the user stylesheet now, so special-case the DashboardClient's funky user stylesheet URL by mapping it to the equivalent file URL.
14:55 Changeset [52952] by japhet@chromium.org
  • 24 edits in trunk/WebCore

2010-01-07 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Generate V8 bindings header declarations for named and indexed accessors.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:
  • bindings/v8/custom/V8StorageCustom.cpp:
  • bindings/v8/custom/V8StyleSheetListCustom.cpp:
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
14:36 Changeset [52951] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Better build fix: use 'this->structure()', since 'structure' is a
PassRefPtr, and therefore null.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):

14:27 Changeset [52950] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Build fix: avoid a name conflict by using the local 'structure' instead
of the member 'structure()'.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase):

14:13 Changeset [52949] by simon.fraser@apple.com
  • 7 edits in trunk/WebCore

2010-01-07 Simon Fraser <simon.fraser@apple.com>

Build fix.

Add RenderEmbeddedObject.h/cpp to all the build systems.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
14:07 Changeset [52948] by ggaren@apple.com
  • 5 edits in trunk

2010-01-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Safari memory usage skyrockets using new Google AdWords interface
https://bugs.webkit.org/show_bug.cgi?id=33343

The memory use was caused by the global object creating too many structures
as it thrashed between different specific functions.

  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::addAnonymousSlotsTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::despecifyAllFunctions):
  • runtime/Structure.h: (JSC::Structure::disableSpecificFunctionTracking): Track a thrash count for specific functions. Disable specific function tracking once the thrash count has been hit.

2010-01-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Safari memory usage skyrockets using new Google AdWords interface
https://bugs.webkit.org/show_bug.cgi?id=33343

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Disabled specific function tracking for the window object, since there's no way to do direct method calls on the window object; they all go through the window shell.
13:57 Changeset [52947] by simon.fraser@apple.com
  • 46 edits
    2 copies in trunk

2010-01-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Kevin Decker, Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33338
Create a renderer for <object> and <embed>

Add RenderEmbeddedObject, which derives from RenderPartObject, and is created for <object> and <embed>.
Instances of RenderPartObject are now only allocated for iframes.

Move object/embed-related code from RenderPartObject to RenderEmbeddedObject.

  • WebCore.xcodeproj/project.pbxproj: Add RenderEmbeddedObject.h/cpp
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::createRenderer): Create a RenderEmbeddedObject. (WebCore::HTMLEmbedElement::updateWidget): Use toRenderEmbeddedObject()
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createRenderer): Make a RenderEmbeddedObject for the plugin-proxy case. (WebCore::HTMLMediaElement::finishParsingChildren): Use toRenderEmbeddedObject() in the plugin-proxy code.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::createRenderer): Make a RenderEmbeddedObject (WebCore::HTMLObjectElement::updateWidget): Use toRenderEmbeddedObject()
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::addWidgetToUpdate): (WebCore::FrameView::removeWidgetToUpdate): (WebCore::FrameView::updateWidgets): Objects in the m_widgetUpdateSet are only ever RenderEmbeddedObjects.
  • rendering/RenderEmbeddedObject.cpp: Added.
  • rendering/RenderEmbeddedObject.h: Added. Most of the code moved from RenderPartObject.
  • rendering/RenderObject.h: (WebCore::RenderObject::isEmbeddedObject): New method.
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Initialize m_hasFallbackContent here, rather than in the derived classes.
  • rendering/RenderPart.h: Comments.
  • rendering/RenderPartObject.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Clean up, code moved to base class, and removed object/embed-specific code. (WebCore::RenderPartObject::layout): Removed object/embed-specific code.
13:47 Changeset [52946] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2010-01-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33338
Create a renderer for <object> and <embed>

First part of this change: renderPartObject->updateWidget() is a no-op for iframe elements,
so we don't need to call it here, and can thus remove the attach() override entirely.

  • html/HTMLIFrameElement.cpp:
  • html/HTMLIFrameElement.h:
13:36 Changeset [52945] by pfeldman@chromium.org
  • 7 edits
    4 adds in trunk/WebCore

2009-01-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Migrate to canvas-based text viewer / editor that scales.

https://bugs.webkit.org/show_bug.cgi?id=33001

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/JavaScriptHighlighterScheme.js: Added. (WebInspector.JavaScriptHighlighterScheme):
  • inspector/front-end/KeyboardShortcut.js:
  • inspector/front-end/TextEditor.js: Added. (WebInspector.TextEditor): (WebInspector.TextSelectionModel): (WebInspector.TextCursor):
  • inspector/front-end/TextEditorHighlighter.js: Added. (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/TextEditorModel.js: Added. (WebInspector.TextRange): (WebInspector.TextRange.prototype.clone): (WebInspector.TextEditorModel):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
13:32 Changeset [52944] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-01-07 Christian Sejersen <christian.webkit@gmail.com>

Reviewed by Darin Adler.

document.title does not replace or remove space characters
https://bugs.webkit.org/show_bug.cgi?id=27032

  • fast/dom/Document/document-title-get-expected.txt: Added.
  • fast/dom/Document/document-title-get.html: Added.
  • fast/dom/Document/script-tests/document-title-get.js: Added.

2010-01-07 Christian Sejersen <christian.webkit@gmail.com>

Reviewed by Darin Adler.

document.title does not replace or remove space characters
https://bugs.webkit.org/show_bug.cgi?id=27032

Test: fast/dom/Document/document-title-get.html

  • dom/Document.cpp: (WebCore::Document::Document): Initialization of m_rawTitle (WebCore::canonicalizedTitle): Moved from DocumentLoader.cpp with minor edits (WebCore::Document::updateTitle): Ensures the title is canonicalized (WebCore::Document::setTitle): Uses m_rawTitle instaed of m_title (WebCore::Document::removeTitle): Uses m_rawTitle instead of m_title
  • dom/Document.h: Added m_rawTitle that stores the passed in title, m_title now stores the canonicalized title
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setTitle): The title passed in is now canonicalized in Document.cpp
12:58 Changeset [52943] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-07 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Allow leading/trailing space for CSS nth-*() and lang().
https://bugs.webkit.org/show_bug.cgi?id=17248

For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.

  • fast/css/css3-space-in-nth-and-lang.html: Added.
  • platform/mac/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.

2010-01-07 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Allow leading/trailing space for CSS nth-*() and lang().
https://bugs.webkit.org/show_bug.cgi?id=17248

For pseudo-classes :nth-*() and :lang(), space must be allowed after '(' and before ')'.
See the bug comments for why we don't allow space at other places.

  • css/CSSGrammar.y:
12:26 Changeset [52942] by kdecker@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=33331
(WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins)


  • Plugins/Hosted/NetscapePluginHostManager.h: Modify method signature for instantiatePlugin to include acceleratedCompositingEnabled bool.
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin):
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): Pass accelerated compositing status to NetscapePluginHostManage
12:24 Changeset [52941] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

AX: contentEditable DIVs are not AX accessible
https://bugs.webkit.org/show_bug.cgi?id=33325

Reviewed by Beth Dakin.

WebCore:

Test: accessibility/contenteditable-hidden-div.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::canSetValueAttribute):

LayoutTests:

  • accessibility/contenteditable-hidden-div-expected.txt: Added.
  • accessibility/contenteditable-hidden-div.html: Added.
12:20 Changeset [52940] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Skip LayoutTests/http/tests/media/video-error-abort.html

  • platform/gtk/Skipped:
12:18 Changeset [52939] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed. roll-out r52917, r52932 and r52934.

12:08 Changeset [52938] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-07 Adam Barth <abarth@webkit.org>

Unreviewed. Resolve merge conflict.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setContextDebugId):
12:00 Changeset [52937] by abarth@webkit.org
  • 12 edits in trunk

2010-01-07 Adam Barth <abarth@webkit.org>

No review, rolling out r52847.
http://trac.webkit.org/changeset/52847
https://bugs.webkit.org/show_bug.cgi?id=33232

Might have caused a perf regression. I'm rolling this out to see if it
heals the perf bot.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::updateSecurityOrigin): (WebCore::ScriptController::evaluateInIsolatedWorld): (WebCore::ScriptController::haveInterpreter): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::updateDocument):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
  • bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::V8IsolatedContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::V8Proxy): (WebCore::V8Proxy::~V8Proxy): (WebCore::V8Proxy::handleOutOfMemory): (WebCore::V8Proxy::evaluateInIsolatedWorld): (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::clearForClose): (WebCore::V8Proxy::clearForNavigation): (WebCore::V8Proxy::context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::currentContext): (WebCore::V8Proxy::setContextDebugId):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::windowShell):
  • bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::adjustedContext):

2010-01-07 Adam Barth <abarth@webkit.org>

No review, rolling out r52847.
http://trac.webkit.org/changeset/52847
https://bugs.webkit.org/show_bug.cgi?id=33232

Might have caused a perf regression.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
11:45 Changeset [52936] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in skiplist by this commit.

  • platform/mac/Skipped:
11:41 Changeset [52935] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Add executable bit to video-throttled-load cgi.

  • http/tests/media/video-throttled-load.cgi: Added property svn:executable.
11:25 Changeset [52934] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed. Fix the Mac bots. Why is there no HTTPD PID file?

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07

  • Scripts/run-webkit-tests:
10:48 Changeset [52933] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • WebCore.xcodeproj/project.pbxproj: Made TypesettingFeatures.h private.
10:33 Changeset [52932] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Store HTTPD PID in a variable to fix warnings if for some reason the pidfile gets deleted before httpd terminates.
This should fix the occasional warnings for uninitialized values on the Mac bots.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Alexey Proskuryakov.

  • Scripts/run-webkit-tests:
10:28 Changeset [52931] by mitz@apple.com
  • 9 edits
    1 add in trunk/WebCore

Added Font::typesettingFeatures() and deployed it

Reviewed by Sam Weinig.

No change in funcitonality

  • WebCore.xcodeproj/project.pbxproj: Added TypesettingFeatures.h.
  • platform/graphics/Font.h:

(WebCore::Font::typesettingFeatures): Added. Determines the typesetting

features from the text redndering mode.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::canUseGlyphCache): Use typesettingFeatures().

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/TypesettingFeatures.h: Added.
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::disableLigatures): Take TypesettingFeatures instead of

TextRenderingMode.

(WebCore::initializeATSUStyle): Ditto.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):

Use typesettingFeatures().

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

Ditto.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::getCFStringAttributes): Take

TypesettingFeatures instead of TextRenderingMode.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak): Use TypesettingFeatures().

10:08 Changeset [52930] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-01-07 Dimitri Glazkov <dglazkov@chromium.org>

No review, rolling out r52900.
http://trac.webkit.org/changeset/52900
https://bugs.webkit.org/show_bug.cgi?id=30055

Broke over 30 SVG pixel tests.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
09:45 Changeset [52929] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] The library version number of the first package release is 4.7.0.

  • WebCore.pro:
09:36 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
09:33 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
09:31 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
09:29 Changeset [52928] by hausmann@webkit.org
  • 6 edits in trunk

[Qt] Allow the application to override online/offline network status
https://bugs.webkit.org/show_bug.cgi?id=32684

Patch by Yael Aharon <yael.aharon@nokia.com> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.

WebCore:

Added API to NetworkStateNotifier for forcing network status.

  • platform/network/NetworkStateNotifier.h:
  • platform/network/qt/NetworkStateNotifierPrivate.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:

(WebCore::NetworkStateNotifierPrivate::NetworkStateNotifierPrivate):
(WebCore::NetworkStateNotifierPrivate::onlineStateChanged):
(WebCore::NetworkStateNotifierPrivate::networkAccessPermissionChanged):
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::setNetworkAccessAllowed):

WebKit/qt:

Add a setting so that applications can overide the network status.
Applications that use this setting still need to block network access
through QNAM.

  • Api/qwebsettings.cpp:

(qt_networkAccessAllowed):

09:26 Changeset [52927] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix.

  • platform/gtk/Skipped: missing "l" suffix added to fast/repaint/subtree-layoutstate-transform.html
09:14 Changeset [52926] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

prospective bearer management build fix to get the include path correct

08:52 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
08:52 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
08:38 Changeset [52925] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=33323
Skip new test on Tiger for now.

  • platform/mac-tiger/Skipped:
08:22 Changeset [52924] by ossy@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Enable JIT in debug mode on win32 after r51141 fixed the crashes.

Reviewed by Simon Hausmann.

08:02 Changeset [52923] by eric.carlson@apple.com
  • 4 edits
    2 moves in trunk

2010-01-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=33272
'abort' event still fired as a progress event

rdar://6710625
Test media/video-error-abort.html doesn't work

Test: http/tests/media/video-error-abort.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::scheduleEvent): Incorporate code from enqueueEvent. (WebCore::HTMLMediaElement::loadInternal): Fix 'abort' event firing logic missed in https://bugs.webkit.org/show_bug.cgi?id=30513. Change order of initialization to match spec wording.
  • html/HTMLMediaElement.h: Remove enqueueEvent prototype.

2010-01-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=33272
'abort' event still fired as a progress event

rdar://6710625
Test media/video-error-abort.html doesn't work

  • http/tests/media/video-error-abort-expected.txt: Copied from LayoutTests/media/video-error-abort-expected.txt.
  • http/tests/media/video-error-abort.html: Copied from LayoutTests/media/video-error-abort.html.

Modified to run with slow loading cgi, add test to ensure that 'abort' event is not a
progress event.

  • media/video-error-abort-expected.txt: Removed.
  • media/video-error-abort.html: Removed.
07:48 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
06:37 Changeset [52922] by eric@webkit.org
  • 9 edits in trunk

2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878

Touch event tests changed to match the API and semantics of iPhone and
Android. Each new touch point press dispatches a touchstart event with
the pressed touch point(s) in the changedTouches list, and a release
dispatches a touchend event with the released touch point(s) in
changedTouches. Moved points dispatch a touchmove event, with the moved
points in changedTouches. Old behaviour emitted only one touchstart when
the first point was pressed and one touchend when the last point was
released, and any events in between were touchmoves. New presses or
releases could only be detected by comparing the lists touches and
changedTouches.

  • fast/events/basic-touch-events-expected.txt:
  • fast/events/script-tests/basic-touch-events.js: (singleTouchSequence): (multiTouchSequence):

2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878

Touch events changed to match the API and semantics of iPhone and
Android. Each new touch point press dispatches a touchstart event with
the pressed touch point(s) in the changedTouches list, and a release
dispatches a touchend event with the released touch point(s) in
changedTouches. Moved points dispatch a touchmove event, with the moved
points in changedTouches. Old behaviour emitted only one touchstart when
the first point was pressed and one touchend when the last point was
released, and any events in between were touchmoves. New presses or
releases could only be detected by comparing the lists touches and
changedTouches.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
  • page/EventHandler.h:

2010-01-07 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Wrong state and TouchLists in TouchEvents
https://bugs.webkit.org/show_bug.cgi?id=32878

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::touchStart): (EventSender::touchEnd): (EventSender::clearTouchPoints):
  • DumpRenderTree/qt/EventSenderQt.h:
05:43 Changeset [52921] by tkent@chromium.org
  • 105 edits
    3 deletes in trunk

2010-01-07 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Remove COM code generation stuff.
https://bugs.webkit.org/show_bug.cgi?id=32854

Remove the followings:

  • CodeGeenratorCOM.pm, COM code generator,
"#if !defined(LANGUAGE_COM)
!LANGUAGE_COM" in IDL files, and
  • UUID attributes in IDL files.
  • bindings/scripts/CodeGeneratorCOM.pm: Removed.
  • css/CSSCharsetRule.idl:
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleRule.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSUnknownRule.idl:
  • css/CSSValue.idl:
  • css/CSSValueList.idl:
  • css/Counter.idl:
  • css/MediaList.idl:
  • css/RGBColor.idl:
  • css/Rect.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSKeyframeRule.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/Attr.idl:
  • dom/CDATASection.idl:
  • dom/CharacterData.idl:
  • dom/Comment.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/EntityReference.idl:
  • dom/Event.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeList.idl:
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
  • dom/Text.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl:

2010-01-07 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Remove COM code generation files.
https://bugs.webkit.org/show_bug.cgi?id=32854

  • WebKit.vcproj/DerivedSources.make: Removed.
  • WebKit.vcproj/build-generated-files.sh: Removed.
05:15 Changeset [52920] by vestbo@webkit.org
  • 1 edit in trunk/JavaScriptCore/jit/JIT.cpp

Unreviewed build fix for Qt on Mac OS X

04:16 Changeset [52919] by steveblock@google.com
  • 3 edits in trunk/WebCore

Android requires ability to increase layout delay

04:13 Changeset [52918] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Holger Freyther.

[Mac] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
https://bugs.webkit.org/show_bug.cgi?id=33312

Using of operator += cause compile error on Mac, so it is changed to
"= static_cast<AllocAlignmentInteger*>(old_ptr) + 1".

  • wtf/FastMalloc.cpp: (WTF::TCMallocStats::realloc):
04:12 Changeset [52917] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Reworked r52853 after r52876 rolled it out.
Chomp the pid variable before passing it to kill and read the contents of
the pidfile in a platform independent manner.
First pach of https://bugs.webkit.org/show_bug.cgi?id=33153.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-07
Reviewed by Kenneth Rohde Christiansen.

  • Scripts/run-webkit-tests:
03:50 Changeset [52916] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Adam Barth.

Created a module that runs the style package unit tests.

https://bugs.webkit.org/show_bug.cgi?id=32973

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/style/unittests.py: Added.
03:44 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:40 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:35 Changeset [52915] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-07 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Some IDL files lack "," separators for extended attributes.
https://bugs.webkit.org/show_bug.cgi?id=33190

To find such mistakes, IDLParser.pm rejects whitespace characters in
extended attribute names.

  • bindings/scripts/IDLParser.pm: parseExtendedAttributes rejects whitespace in a name.
  • css/WebKitCSSTransformValue.idl: Add missing ",".
  • dom/EventTarget.idl: ditto.
03:29 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:26 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:24 Changeset [52914] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] need an API to suspend and resume active Javascript DOM objects.
https://bugs.webkit.org/show_bug.cgi?id=31673

Patch by Yongjun Zhang <yongjun.zhang@nokia.com>, Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2010-01-07
Reviewed by Simon Hausmann.

Add suspend and resume DOM objects private API to QWebFrame.

  • Api/qwebframe.cpp:

(qt_suspendActiveDOMObjects):
(qt_resumeActiveDOMObjects):

02:52 Changeset [52913] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-07 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

Fix an issue that CodeGeneratorV8.pm doesnt handle HasIndexGetter of
WebKitCSSTransformValue.idl correctly.
https://bugs.webkit.org/show_bug.cgi?id=33193

CodeGeneratorV8.pm doesn't handle inheritance very well and it
tried to refer v8WebKitCSSTransformValueIndexedPropertyGetter(),
which does not exist. Because WebKitCSSTransformValue inherits
CSSValueList and CSSValueList already has HadIndexGetter, we don't
need to do anything for WebKitCSSTransformValue about HasIndexGetter.

  • bindings/scripts/CodeGeneratorV8.pm: Reset $hasGetter for WebKitCSSTransformValue.
02:22 Changeset [52912] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Don't print a redundant message when confirming a diff
https://bugs.webkit.org/show_bug.cgi?id=33315

Instead of saying "ERROR: User declined" we should just exit because
the use knows they just declined!

  • Scripts/webkitpy/steps/confirmdiff.py:
02:19 Changeset [52911] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Holger Freyther.

[Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
https://bugs.webkit.org/show_bug.cgi?id=33312

Remove pByte (committed in r42344 from #20422), because pByte doesn't
exist and it is unnecessary.

  • wtf/FastMalloc.cpp: (WTF::TCMallocStats::realloc):
02:12 Changeset [52910] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Check style before uploading a patch
https://bugs.webkit.org/show_bug.cgi?id=33314

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/steps/checkstyle.py:
  • Scripts/webkitpy/steps/options.py:
01:51 Changeset [52909] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add prepare and post to webkit-patch main help
https://bugs.webkit.org/show_bug.cgi?id=33313

  • Scripts/webkitpy/commands/upload.py:
00:57 Changeset [52908] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
https://bugs.webkit.org/show_bug.cgi?id=33290

Add the Chromium builders to our list of core builders and test that our regexps work.
I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.

  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/buildbot_unittest.py:
00:49 Changeset [52907] by abarth@webkit.org
  • 13 edits
    1 move in trunk/WebKitTools

2010-01-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool needs a new name
https://bugs.webkit.org/show_bug.cgi?id=28459

Rename bugzilla-tool to webkit-patch. Also, rename some commands to
make more sense with the new name.

  • Scripts/bugzilla-tool: Removed.
  • Scripts/webkit-patch: Added.
  • Scripts/webkit-tools-completion.sh:
  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/download_unittest.py:
  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/queueengine.py:
  • Scripts/webkitpy/steps/completerollout.py:
00:36 Changeset [52906] by eric@webkit.org
  • 3 edits
    6 moves
    1 add in trunk/WebKitTools

2010-01-07 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Moved style-related modules to webkitpy.style sub-package.

https://bugs.webkit.org/show_bug.cgi?id=32971

  • Scripts/check-webkit-style:
    • Updated import statement.
  • Scripts/test-webkitpy:
    • Updated import statements.
  • Scripts/webkitpy/cpp_style.py: Removed.
    • Moved to webkitpy/style.
  • Scripts/webkitpy/cpp_style_unittest.py: Removed.
    • Moved to webkitpy/style.
  • Scripts/webkitpy/style.py: Removed.
    • Moved to webkitpy/style/checker.py.
  • Scripts/webkitpy/style/init.py: Added.
    • Added containing webkitpy directory to package search path.
  • Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
  • Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
    • Updated import statement.
  • Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
  • Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
    • Update import statement.
  • Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
  • Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
  • Scripts/webkitpy/style_unittest.py: Removed.
    • Moved to webkitpy/style/checker_unittest.py.
  • Scripts/webkitpy/text_style.py: Removed.
    • Moved to webkitpy/style.
  • Scripts/webkitpy/text_style_unittest.py: Removed.
    • Moved to webkitpy/style.
00:22 Changeset [52905] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-07 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Do not return strings whose handles are in near death state (that means
they might be GCed) or just empty.
https://bugs.webkit.org/show_bug.cgi?id=31180

  • bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):
00:06 Changeset [52904] by eric@webkit.org
  • 18 edits
    4 adds in trunk

2010-01-06 MORITA Hajime <morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

SVG background color on selected text goes wrong when text has
gradient stroke.
https://bugs.webkit.org/show_bug.cgi?id=33069

Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
and paint background and foreground in separate subphase.

  • svg/text/selection-background-color.xhtml: Added.
  • platform/mac/svg/text/selection-background-color-expected.checksum: Added.
  • platform/mac/svg/text/selection-background-color-expected.png: Added.
  • platform/mac/svg/text/selection-background-color-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.png:
  • platform/mac/svg/batik/text/textDecoration2-expected.checksum:
  • platform/mac/svg/batik/text/textDecoration2-expected.png:
  • platform/mac/svg/text/text-deco-01-b-expected.checksum:
  • platform/mac/svg/text/text-deco-01-b-expected.png:
  • platform/mac/svg/text/text-spacing-01-b-expected.checksum:
  • platform/mac/svg/text/text-spacing-01-b-expected.png:
  • platform/mac/svg/text/text-text-03-b-expected.checksum:
  • platform/mac/svg/text/text-text-03-b-expected.png:
  • platform/mac/svg/text/text-text-08-b-expected.checksum:
  • platform/mac/svg/text/text-text-08-b-expected.png: Re-baselined due to painting algorithm change.

2010-01-06 MORITA Hajime <morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

SVG background color on selected text goes wrong when text has
gradient stroke.
https://bugs.webkit.org/show_bug.cgi?id=33069

Introduced SVGTextPaintSubphase like as PaintPhase on html painting,
and paint background and foreground in separate subphase.

Test: svg/text/selection-background-color.xhtml

  • rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): Added m_setupBackgroundCallback, m_setupForegroundCallback (WebCore::SVGTextChunkWalker::setupBackground): (WebCore::SVGTextChunkWalker::setupForeground): Added.
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintCharacters): pass SVGTextPaintInfo instead of SVGPaintServer
  • rendering/SVGInlineTextBox.h: (WebCore::SVGTextPaintSubphase): (WebCore::SVGTextPaintInfo::SVGTextPaintInfo): Added.
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::walkTextChunks): Invoke setupBackground() and setupForeground() (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupBackgroundCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupForegroundCallback): (WebCore::SVGRootInlineBoxPaintWalker::activePaintServer): Added. (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupFillCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkSetupStrokeCallback): (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::SVGRootInlineBox::paint):
Note: See TracTimeline for information about the timeline view.