Timeline


and

01/12/10:

22:51 Changeset [53180] by jorlow@chromium.org
  • 8 edits in trunk

2010-01-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492

  • public/WebKitClient.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::getSessionStorageNamespace):
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):

2010-01-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492

  • page/Page.cpp: (WebCore::Page::sessionStorage):
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
  • storage/StorageNamespace.h: (WebCore::StorageNamespace::~StorageNamespace):
22:12 Changeset [53179] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed. Now I can review :)

  • Scripts/webkitpy/committers.py:
21:23 WebKit Team edited by hamaji@chromium.org
(diff)
19:33 Changeset [53178] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/7512726> Flash full-screen does not work correctly with Flash 10.1 beta

Reviewed by Darin Adler.

Explicitly track when the plug-in shows and hides a full-screen window to determine
whether a plug-in is currently full-screen, rather than relying on menu bar visibility.
This ensures that we activate the plug-in host process and client application as
appropriate when the plug-in enters or exits full-screen.

  • Plugins/Hosted/NetscapePluginHostProxy.h:

(WebKit::NetscapePluginHostProxy::isFullScreenWindowShowing):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::setMenuBarVisible):
(WebKit::NetscapePluginHostProxy::didEnterFullScreen):
(WebKit::NetscapePluginHostProxy::didExitFullScreen):
(WebKit::NetscapePluginHostProxy::setFullScreenWindowIsShowing):
(WKPCSetMenuBarVisible):
(WKPCSetFullScreenWindowIsShowing):

  • Plugins/Hosted/WebKitPluginClient.defs:
19:29 Changeset [53177] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Adding a list of whitelisted sqlite functions that users are
allowed to use.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33549

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::authorizerFunction):

  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
(WebCore::DatabaseAuthorizer::addWhitelistedFunctions):
(WebCore::DatabaseAuthorizer::allowFunction):

  • storage/DatabaseAuthorizer.h:
18:48 Changeset [53176] by ukai@chromium.org
  • 2 edits
    1 move in trunk/WebCore

2010-01-12 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Simon Hausmann.

[Qt][WebSocket] SocketStreamHandleSoup.cpp is misnamed
https://bugs.webkit.org/show_bug.cgi?id=33077

  • WebCore.pro:
  • platform/network/qt/SocketStreamHandleQt.cpp: Copied from WebCore/platform/network/qt/SocketStreamHandleSoup.cpp.
  • platform/network/qt/SocketStreamHandleSoup.cpp: Removed.
18:33 Changeset [53175] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/rendering/RenderLayer.cpp

Build Fix.

18:09 Changeset [53174] by ukai@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-01-12 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

Add a test of WebSockets for shared workers
https://bugs.webkit.org/show_bug.cgi?id=33285

  • websocket/tests/workers/resources/worker-simple.js:
  • websocket/tests/workers/shared-worker-simple-expected.txt: Added.
  • websocket/tests/workers/shared-worker-simple.html: Added.
18:08 Changeset [53173] by simon.fraser@apple.com
  • 4 edits
    4 adds in trunk

2010-01-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

position:fixed and transform on same element breaks fixed behavior
https://bugs.webkit.org/show_bug.cgi?id=31283

Fix interactions of transforms and fixed positioning, namely that fixed position
elements with a transformed ancestor are positioned relative to that ancestor,
and an element with both a transform and fixed position respects that positioning.

Test: transforms/2d/transform-fixed-container.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint): Transforms should not unconditionally stop the propagation of the 'fixed' flag to ancestors, but only if the transformed element is not itself fixed.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::convertToLayerCoords): Fix this method to behave correctly for fixed position layers whose container is not the root, but some other (probably transformed) ancestor. In that case, we can fall into the "position: absolute" code path.
18:04 Changeset [53172] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Replacing RANDOMBLOB with ZEROBLOB, as RANDOMBLOB will soon be
disallowed by the authorizer.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33396

  • storage/quota-tracking.html:
17:29 Changeset [53171] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

Fix an assert being triggered by how the Chromium port sets the
replacing flag for error pages. This was caused by r53143.

Covered by existing Chromium UI tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
16:58 Changeset [53170] by eric@webkit.org
  • 48 edits
    3 adds in trunk

2010-01-12 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242

Add an extra argument to getPropertyNames() and getOwnPropertyNames()
(and all reimplementations thereof) that indicates whether non-enumerable
properties should be added.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertyNames):
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::getOwnPropertyNames):
  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertyNames):
  • runtime/Arguments.h:
  • runtime/CommonIdentifiers.h:
  • runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertyNames):
  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::getOwnPropertyNames):
  • runtime/JSByteArray.h:
  • runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertyNames):
  • runtime/JSFunction.h:
  • runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::getOwnPropertyNames):
  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp: (JSC::getClassPropertyNames): (JSC::JSObject::getPropertyNames): (JSC::JSObject::getOwnPropertyNames):
  • runtime/JSObject.h:
  • runtime/JSVariableObject.cpp: (JSC::JSVariableObject::getOwnPropertyNames):
  • runtime/JSVariableObject.h:
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyNames):
  • runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::getOwnPropertyNames):
  • runtime/StringObject.cpp: (JSC::StringObject::getOwnPropertyNames):
  • runtime/StringObject.h:
  • runtime/Structure.cpp: Rename getEnumerablePropertyNames() to getPropertyNames(), which takes an extra argument. (JSC::Structure::getPropertyNames):
  • runtime/Structure.h: (JSC::):

2010-01-12 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242

Add new argument to the reimplementation of getOwnPropertyNames().

  • UserObjectImp.cpp: (UserObjectImp::getOwnPropertyNames):
  • UserObjectImp.h:

2010-01-12 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242

Add tests for Object.getOwnPropertyNames(o), both standard usage and cross origin.

  • fast/js/Object-getOwnPropertyNames-expected.txt: Added.
  • fast/js/Object-getOwnPropertyNames.html: Added.
  • fast/js/script-tests/Object-getOwnPropertyNames.js: Added.
  • http/tests/security/cross-frame-access-enumeration-expected.txt:
  • http/tests/security/cross-frame-access-enumeration.html:

2010-01-12 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242

Add new argument to reimplementations of getPropertyNames()
and getOwnPropertyNames(), and update the JS bindings generator.

Test: fast/js/Object-getOwnPropertyNames.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyNames): (WebCore::JSDOMWindow::getOwnPropertyNames):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::getPropertyNames): (WebCore::JSDOMWindowShell::getOwnPropertyNames):
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getOwnPropertyNames):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getOwnPropertyNames):
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::getPropertyNames): (WebCore::JSQuarantinedObjectWrapper::getOwnPropertyNames):
  • bindings/js/JSQuarantinedObjectWrapper.h:
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getOwnPropertyNames):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertyNames):
  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getPropertyNames): (JSC::RuntimeObjectImp::getOwnPropertyNames):
  • bridge/runtime_object.h:
16:16 Changeset [53169] by bweinstein@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Add correct expected results after r53168 for GTK and Qt.

  • platform/gtk/fast/block: Added.
  • platform/gtk/fast/block/positioning: Added.
  • platform/gtk/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
  • platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
15:39 Changeset [53168] by bweinstein@apple.com
  • 6 edits
    2 adds in trunk

Safari shows an unneeded horizontal scrollbar on many websites.
Fixes <rdar://6321041> and <http://webkit.org/b/33555>.

Reviewed by Dave Hyatt.

WebCore:

If a div has no children, and its height or width are 0, we can ignore
it in our calculation of lowest, rightmost, and leftmost positions. This
calculation was causing horizontal scrollbars to be drawn when they weren't needed.

Test: fast/block/positioning/absolute-positioning-no-scrollbar.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lowestPosition): Added check for no children and width or height 0.
(WebCore::RenderBlock::rightmostPosition): Ditto.
(WebCore::RenderBlock::leftmostPosition): Ditto.

LayoutTests:

Added a test that shows no scrollbar in the case where a div has no children
and either a width or height of 0. Also updated results for a few tests which
this patch causes progressions for.

  • fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
  • fast/block/positioning/absolute-positioning-no-scrollbar.html: Added.
  • fast/block/positioning/fixed-positioning-scrollbar-bug.html:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
15:34 Changeset [53167] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Optimize WebInspector.TimelineGrid.prototype.updateDividers()

DOM element property access and modification are slow and should be done as lazily as possible.
https://bugs.webkit.org/show_bug.cgi?id=33536

  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype._setDividerAndBarLeft):
15:10 Changeset [53166] by bdakin@apple.com
  • 3 edits
    4 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION: -
webkit-svg-shadow with opacity still over-clipped

Reviewed by Sam Weinig.

We need to call inflateForShadow() on the repaintRect before we
clip for opacity or we will over-clip.

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION:
-webkit-svg-shadow with opacity still over-clipped

Reviewed by Sam Weinig.

  • platform/mac/svg/css/shadow-and-opacity-expected.checksum: Added.
  • platform/mac/svg/css/shadow-and-opacity-expected.png: Added.
  • platform/mac/svg/css/shadow-and-opacity-expected.txt: Added.
  • svg/css/shadow-and-opacity.svg: Added.
14:48 Changeset [53165] by sfalken@apple.com
  • 12 edits
    6 adds in trunk

WebCore: Update all-in-one derived sources for Geolocation.

Reviewed by Sam Weinig.

  • DerivedSources.cpp: Add JSCoordinates.cpp, JSGeolocation.cpp, JSGeoposition.cpp, JSPositionError.cpp

WebKit/win: Add Geolocation interfaces in WebKit for Windows.

Reviewed by Adam Roben, Sam Weinig.

  • ForEachCoClass.h: Added WebGeolocationPosition.
  • Interfaces/IWebError.idl:
  • Interfaces/IWebGeolocationPosition.idl: Added.
  • Interfaces/IWebGeolocationProvider.idl: Added.
  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebGeolocationControllerClient.cpp: Added.

(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):

  • WebCoreSupport/WebGeolocationControllerClient.h: Added.
  • WebGeolocationPosition.cpp: Added IWebGeolocationPosition implementation.
  • WebGeolocationPosition.h: Added IWebGeolocationPosition implementation.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPosition.idl, IWebGeolocationProvider.idl,

relocated JavaScriptCoreAPITypes.idl, WebScrollbarTypes.idl

  • WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPosition.h/.cpp, WebGeolocationControllerClient.h/cpp,
  • WebKitClassFactory.cpp: Add WebGeolocationPosition include.
  • WebView.cpp:

(WebView::initWithFrame): Create WebGeolocationControllerClient if Geolocation is enabled.
(WebView::setGeolocationProvider): Added Geolocation-specific method.
(WebView::geolocationProvider): Added Geolocation-specific method.
(WebView::geolocationDidChangePosition): Added Geolocation-specific method.
(WebView::geolocationDidFailWithError): Added Geolocation-specific method.

  • WebView.h: Added setGeolocationProvider, geolocationProvider, geolocationDidChangePosition, geolocationDidFailWithError.
14:12 Changeset [53164] by japhet@chromium.org
  • 31 edits in trunk/WebCore

2010-01-12 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Remove static const ints from V8CustomBinding.h

https://bugs.webkit.org/show_bug.cgi?id=33547

  • bindings/scripts/CodeGeneratorV8.pm: Generate and use custom

internal field indices from lists of custom internal fields.

  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/NPV8Object.h:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: Remove a bunch of now unnecessary

manually calls to setInternalFieldCount().

  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8Index.h:
  • bindings/v8/V8IsolatedContext.cpp:
  • bindings/v8/V8IsolatedContext.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h: Remove the static const ints.
  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
14:07 Changeset [53163] by jhoneycutt@apple.com
  • 3 edits
    2 adds in trunk

MSAA: Accessibility role of <select multiple> elements is wrong

https://bugs.webkit.org/show_bug.cgi?id=33522

Reviewed by Darin Adler.

WebKit/win:

  • AccessibleBase.cpp:

(MSAARole):
Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA
"list" and "list item" roles.

LayoutTests:

  • platform/win/accessibility/multiple-select-element-role-expected.txt: Added.
  • platform/win/accessibility/multiple-select-element-role.html: Added.
13:59 Changeset [53162] by darin@chromium.org
  • 2 edits in trunk/WebCore

2010-01-12 Darin Fisher <darin@chromium.org>

Fixing chromium build bustage.

  • bindings/v8/custom/V8PopStateEventCustom.cpp: Add V8Proxy.h include.
13:28 Changeset [53161] by darin@chromium.org
  • 7 edits
    1 add in trunk/WebCore

2010-01-12 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Add V8 bindings for PopStateEvent.
https://bugs.webkit.org/show_bug.cgi?id=33546


This is covered by existing tests for PopStateEvent.

  • WebCore.gypi:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8PopStateEventCustom.cpp: Added. (WebCore::V8PopStateEvent::initPopStateEventCallback): (WebCore::V8PopStateEvent::stateAccessorGetter):
13:25 Changeset [53160] by knorton@google.com
  • 7 edits in trunk

2010-01-12 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds source length to ParseHTMLRecords in the inspector timeline.
https://bugs.webkit.org/show_bug.cgi?id=33548

Test: inspector/timeline-parse-html.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willWriteHTML):
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createParseHTMLRecord):
  • inspector/TimelineRecordFactory.h:
13:15 Changeset [53159] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=31597

Make ICU's text breakiterator and string search use Chrome's UI
language instead of 'en-US' or the OS UI language.

As long as the webkit layout tests are run in en-US locale, there'd be
no visible change.

  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: (UILanguage): (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
13:05 Changeset [53158] by bdakin@apple.com
  • 5 edits in trunk/LayoutTests

Updated results for these tests which just have rounding errors.

Reviewed by Nikolas Zimmermann.

  • platform/mac/svg/css/composite-shadow-example-expected.checksum:
  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/mask-with-shadow-expected.checksum:
  • platform/mac/svg/css/mask-with-shadow-expected.png:
12:54 Changeset [53157] by bdakin@apple.com
  • 29 edits in trunk

WebCore: Rubber-stamped by Dave Hyatt.

This patch changes the name of -webkit-shadow to -webkit-svg-shadow
to avoid giving a custom property an overly-general name.
<rdar://problem/7534590>

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShadow):

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

LayoutTests: This patch changes the name of -webkit-shadow to -webkit-svg-shadow
to avoid giving a custom property an overly-general name.
<rdar://problem/7534590>

  • fast/repaint/moving-shadow-on-container.html:
  • fast/repaint/moving-shadow-on-path.html:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/arrow-with-shadow.svg:
  • svg/css/circle-in-mask-with-shadow.svg:
  • svg/css/clippath-with-shadow.svg:
  • svg/css/composite-shadow-example.html:
  • svg/css/composite-shadow-with-opacity.html:
  • svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/group-with-shadow.svg:
  • svg/css/mask-with-shadow.svg:
  • svg/css/path-with-shadow.svg:
  • svg/css/shadow-with-large-radius.svg:
  • svg/css/shadow-with-negative-offset.svg:
  • svg/css/stars-with-shadow.html:
  • svg/filters/shadow-on-filter.svg:
  • svg/filters/shadow-on-rect-with-filter.svg:
12:49 Changeset [53156] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

  • WebCore.vcproj/WebCore.vcproj:
12:44 Changeset [53155] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2010-01-12 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Add a null check in case of an event handler with invalid syntax.

Should make fast/js/invalid-syntax--for-function.html not crash in
Chromium's test shell.

  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::callListenerFunction): Check the listener object before using it.
12:34 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
12:32 Changeset [53154] by bfulgham@webkit.org
  • 4 edits in trunk/WebKitTools

Extend WinLauncher example with better printing features.

Reviewed by Darin Adler.

  • WinLauncher/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly

larger margins.

(PrintWebUIDelegate::webViewHeaderHeight): Compute header height based

on text metrics.

(PrintWebUIDelegate::webViewFooterHeight): Compute footer height based

on text metrics.

(PrintWebUIDelegate::drawHeaderInRect): Write useful header, along

with separating line.

(PrintWebUIDelegate::drawFooterInRect):

  • WinLauncher/PrintWebUIDelegate.h: Remove stubs.
  • WinLauncher/WinLauncher.cpp:

(PrintView): Correct loop used to print individual pages.

Previously it started at 0, which is a wild-card to print all
pages at once.

11:59 Changeset [53153] by eric.carlson@apple.com
  • 4 edits in trunk/LayoutTests

2010-01-12 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Add media/video-poster-scale.html to GTK skipped list, it needs platform specific
results (https://bugs.webkit.org/show_bug.cgi?id=33541). Fix test results on
OSX and Windows.

  • media/video-poster-scale-expected.txt:
  • media/video-poster-scale.html:
  • platform/gtk/Skipped:
11:52 Changeset [53152] by pkasting@chromium.org
  • 6 edits
    1 delete in trunk/WebCore

Remove XBM support from the open-source image decoders.
https://bugs.webkit.org/show_bug.cgi?id=27823

Reviewed by Dimitri Glazkov.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

  • platform/image-decoders/xbm: Removed.
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: Removed.
  • platform/image-decoders/xbm/XBMImageDecoder.h: Removed.
11:42 Changeset [53151] by ap@apple.com
  • 14 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33540
Make it possible to build in debug mode with assertions disabled

11:41 Changeset [53150] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2010-01-12 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Update test and results after r53146.

  • http/tests/security/local-video-poster-from-remote-expected.txt:
  • http/tests/security/local-video-poster-from-remote.html:
11:33 Changeset [53149] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-12 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Gustavo Noronha Silva.

[GTK] Failing media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=33015

  • platform/gtk/Skipped: Skipping the test again, we need to kill its last timer.
10:50 Changeset [53148] by yong.li@torchmobile.com
  • 4 edits in trunk

2009-11-23 Yong Li <yoli@rim.com>

Reviewed by Adam Treat.

Make GIF decoder support down-sampling
https://bugs.webkit.org/show_bug.cgi?id=31806

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::upperBoundScaledY): (WebCore::ImageDecoder::lowerBoundScaledY):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::scaledRect): (WebCore::RGBA32Buffer::setScaledRect): (WebCore::ImageDecoder::scaledSize):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::sizeNowAvailable): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::copyOnePixel): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
10:33 Changeset [53147] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

Reviewed by Eric Carlson.

[GTK] Failing media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=33015

Listen on timeupdate event instead of waiting a fixed amount of
time, which is prone to test flackyness.

  • media/audio-mpeg-supported.html:
  • media/video-seek-past-end-playing.html:
  • platform/gtk/Skipped:
10:23 Changeset [53146] by eric.carlson@apple.com
  • 20 edits
    2 adds in trunk

2010-01-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler and Simon Fraser.

rdar://problem/5684062
https://bugs.webkit.org/show_bug.cgi?id=23094
Flash of white when switching from poster image to video playback


https://bugs.webkit.org/show_bug.cgi?id=23140
<video> poster should scale like a video frame

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Only call updatePosterImage from one place
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): m_shouldShowPosterImage -> m_shouldDisplayPoster. (WebCore::HTMLVideoElement::createRenderer): Always create a RenderVideo. (WebCore::HTMLVideoElement::attach): Call updatePosterImage before checking to see if we

should display the poster image. renderer() is never a RenderImage, don't need to check.
m_shouldShowPosterImage -> m_shouldDisplayPoster.

(WebCore::HTMLVideoElement::detach): m_shouldShowPosterImage -> m_shouldDisplayPoster.
(WebCore::HTMLVideoElement::parseMappedAttribute): Cache poster attribute when it is set since

it is checked frequently. m_shouldShowPosterImage -> m_shouldDisplayPoster.

(WebCore::HTMLVideoElement::updatePosterImage): Don't bother looking at the network state,

display the poster as long as the attribute is valid and the media engine says it hasn't
rendered a video frame. m_shouldShowPosterImage -> m_shouldDisplayPoster.

(WebCore::HTMLVideoElement::hasAvailableVideoFrame): New, ask the media engine if a video frame

is available to render.

  • html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::poster): (WebCore::HTMLVideoElement::shouldDisplayPoster):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateRenderer): Call setCachedImage for render video too.
  • manual-tests/video-player.html: Remove bit-rot from manual test so it works again.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::hasAvailableVideoFrame): New, ask the media engine if a video frame

is available to render.

  • platform/graphics/MediaPlayer.h: Prototype for hasAvailableVideoFrame.
  • platform/graphics/MediaPlayerPrivate.h: Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Declare hasAvailableVideoFrame, declare

all bool variables to aid packing.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_videoFrameHasDrawn. Cleanup

floating point initializers to match coding guidelines.

(WebCore::MediaPlayerPrivate::load): Initialize m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivate::hasAvailableVideoFrame): New.
(WebCore::MediaPlayerPrivate::repaint): Set m_videoFrameHasDrawn.

(WebCore::RenderImage::paintReplaced): Split part out into paint method.
(WebCore::RenderImage::paint): New.

  • rendering/RenderImage.h: Declare paint. Make isWidthSpecified and isHeightSpecified protected

instead of private so RenderVideo can use them.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Inherit from RenderImage, not RenderReplaced (WebCore::RenderMedia::destroy): Ditto. (WebCore::RenderMedia::styleDidChange): Ditto. (WebCore::RenderMedia::layout): Ditto. (WebCore::RenderMedia::lowestPosition): Ditto. (WebCore::RenderMedia::rightmostPosition): Ditto. (WebCore::RenderMedia::leftmostPosition): Ditto.
  • rendering/RenderMedia.h: Declare isImage and isRenderImage.
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::intrinsicSizeChanged): New, call RenderVideo::intrinsicSizeChanged

when displaying a poster so it is sized correctly.

(WebCore::RenderVideo::imageChanged): Override so we can cache the image's intrisic size and
use it when we also know the movie's intrinsic size but still need to draw the poster.
(WebCore::RenderVideo::videoBox): Use the poster's intrinsic size when drawing the poster,
use the movie's intrinsic size when drawing frames.
(WebCore::RenderVideo::paintReplaced): Call RenderImage::paint when drawing the poster.
(WebCore::RenderVideo::videoElement): New.
(WebCore::RenderVideo::updatePlayer):

  • rendering/RenderVideo.h: (WebCore::RenderVideo::minimumReplacedHeight): Added.

2010-01-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler and Simon Fraser.

rdar://problem/5684062
https://bugs.webkit.org/show_bug.cgi?id=23094
Flash of white when switching from poster image to video playback


https://bugs.webkit.org/show_bug.cgi?id=23140
<video> poster should scale like a video frame

  • media/video-poster-expected.txt: Remove blank line at beginning of test result present as a side effect of the media element using RenderImage to display the poster.
  • media/video-poster-scale.html: New.
  • media/video-poster-scale-expected.txt: New.
10:11 Changeset [53145] by darin@chromium.org
  • 2 edits in trunk/WebKitTools

2010-01-11 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] "build-webkit --chromium" should run "make all" on Linux
https://bugs.webkit.org/show_bug.cgi?id=33500

  • Scripts/webkitdirs.pm:
10:10 Changeset [53144] by darin@chromium.org
  • 3 edits
    1 add
    1 delete in trunk/WebKit/chromium

2010-01-11 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Re-work webkit_unit_tests so that WebKit is initialized only once
https://bugs.webkit.org/show_bug.cgi?id=33504

  • WebKit.gyp:
  • tests/KURLTest.cpp: (ComponentCase::TEST):
  • tests/RunAllTests.cpp: Added. (main):
  • tests/WebKitTest.h: Removed.
10:10 Changeset [53143] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-01-12 Tony Chang <tony@chromium.org>

Reviewed by Maciej Stachowiak.

Add a test for a Chromium crash when loading multipart/x-mixed-replace
data.

https://bugs.webkit.org/show_bug.cgi?id=31446

  • http/tests/multipart/multipart-wait-before-boundary-expected.txt: Added.
  • http/tests/multipart/multipart-wait-before-boundary.html: Added.
  • http/tests/multipart/resources/multipart-wait-before-boundary.php: Added.

2010-01-12 Tony Chang <tony@chromium.org>

Reviewed by Maciej Stachowiak.

Fix a crash in Chromium when receiving multipart/x-mixed-replace data.
If we stop a multipart load after ResourceLoader::didReceiveResponse
but before ResourceLoader::didReceiveData, we have a NULL document
loader because it has been moved back to the provisional state. New
loads that happen after this will dereference the NULL document
loader.

Work around this by moving the provisional document loader back as
the document loader when the request is stopped.

https://bugs.webkit.org/show_bug.cgi?id=31446

Test: http/tests/multipart/multipart-wait-before-boundary.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
09:15 Changeset [53142] by enrica@apple.com
  • 2 edits in trunk/WebCore

WebKit returns incorrect match count when first string match is on an element with user-select-none style
https://bugs.webkit.org/show_bug.cgi?id=33508
<rdar://problem/7482143>

Reviewed by Darin Adler.

If we use VisiblePosition to calculate the start of the new search range,
we skip all the nodes with user-select-none style, producing an incorrect
match count.

No new tests: there are no API's available to Javascript to verify the
number of matches found.

  • page/Frame.cpp:

(WebCore::Frame::markAllMatchesForText): Changed to use the end of the previous
result range as the start of the new search range.

09:03 Changeset [53141] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Changed ".sidebar" style to allow v-scroll to appear in
"Profiles" panel sidebar.

https://bugs.webkit.org/show_bug.cgi?id=33470

No new tests -- no code changed.

  • inspector/front-end/inspector.css:
06:37 Changeset [53140] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-12 Petri Latvala <petri.latvala@nomovok.com>

Reviewed by Antti Koivisto.

fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html failed on buildbot
https://bugs.webkit.org/show_bug.cgi?id=33465

A touchmove event is not dispatched if none of the touch points actually moved.
Changed the test to use touchstart instead.

  • fast/events/touch/touch-coords-in-zoom-and-scroll.html:
  • platform/qt/Skipped:
05:55 Changeset [53139] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows accelerated compositing build fix after r53110

  • plugins/PluginWidget.h:

(WebCore::PluginWidget::platformLayer): Define platformLayer() for
non-Mac platforms that have accelerated compositing turned on. It
would probably be better to make PluginWidget not be used at all on
non-Mac platforms, but this fix is much simpler.

05:48 Changeset [53138] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

[GTK] couple fixes for signal emissions, and property notifications
https://bugs.webkit.org/show_bug.cgi?id=33428

Fix commitedLoad being called where it should not, causing it to
be called one time too many in some cases. We now match Qt's and
Mac's behavior here.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
  • tests/testloading.c: (load_error_status_changed_cb):
05:05 Changeset [53137] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-12 Eric Seidel <eric@webkit.org>

Reviewed by Gustavo Noronha Silva.

[GTK] Threading problems with some of the tests
https://bugs.webkit.org/show_bug.cgi?id=30814

Skip another test which is hitting the SQLiteDatabase::sqliteHandle() threading ASSERT.

  • platform/gtk/Skipped:
04:59 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
04:45 Changeset [53136] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

Touch event layout tests should be in their own subdirectory, so that they can be easily skipped
https://bugs.webkit.org/show_bug.cgi?id=33526

Reviewed by Simon Hausmann.

Tests moved from fast/events to fast/events/touch by r53125,
relative resource paths should be adjuted to the new location.

  • fast/events/touch/basic-touch-events.html: relative paths fixed.
  • fast/events/touch/touch-coords-in-zoom-and-scroll.html: relative paths fixed.
04:41 Changeset [53135] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-01-12 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Support injection of inspector scripts into the inspected context.

https://bugs.webkit.org/show_bug.cgi?id=33523

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::WeakReferenceCallback): (WebCore::createInjectedScriptHostV8Wrapper): (WebCore::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
04:31 Changeset [53134] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

AssignToCommitter does not need to fetch bugs twice
https://bugs.webkit.org/show_bug.cgi?id=33530

This is a no-brainer patch now that we've added Bug.reviewed_patches

  • Scripts/webkitpy/commands/upload.py:
04:03 Changeset [53133] by eric@webkit.org
  • 22 edits in trunk/WebKitTools

2010-01-12 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla.py should have an Attachment object instead of passing around dictionaries
https://bugs.webkit.org/show_bug.cgi?id=31594

  • Scripts/webkitpy/bugzilla.py:
    • Add a new Attachment class, with accessor methods for all the necessary properties.
    • Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
    • Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
    • Move committer validation logic into its own class.
    • Committer rejection is only used in one place. Make the new Bug reviewed_patches and commit_queued_patches handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle the case where we want to reject patches in bugzilla.
    • Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
    • Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
    • Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
    • Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
  • Scripts/webkitpy/bugzilla_unittest.py:
    • Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
  • Scripts/webkitpy/commands/download.py:
    • Store "bug_id" in state instead of making a fake patch object.
    • Update to use Attachment and Bug objects.
  • Scripts/webkitpy/commands/download_unittest.py:
    • Update expected results now that our testing framework covers more code.
  • Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
  • Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
  • Scripts/webkitpy/commands/queries_unittest.py: ditto.
  • Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
  • Scripts/webkitpy/commands/queuestest.py: ditto.
  • Scripts/webkitpy/commands/upload.py: ditto.
  • Scripts/webkitpy/mock_bugzillatool.py:
    • Now that more logic has moved into Attachment and Bug, we have to actually provide real reviewer emails as well as real reviewer flags.
    • Update mock methods to return Attachment objects.
  • Scripts/webkitpy/scm.py: Update to use Attachment class.
  • Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
  • Scripts/webkitpy/statusserver.py: ditto.
  • Scripts/webkitpy/steps/applypatch.py: ditto.
  • Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
  • Scripts/webkitpy/steps/closebug.py: ditto.
  • Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either statebug_id? or statepatch?.bug_id()
  • Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
  • Scripts/webkitpy/steps/obsoletepatches.py: ditto.
  • Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
03:48 Changeset [53132] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-01-12 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

Form Reset : Press Back Button and Reset , TextareaElemnt is not set to Default Value
https://bugs.webkit.org/show_bug.cgi?id=31539

Added manual test: manual-tests/textarea-reset-default-value.html.

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::restoreFormControlState): set the value, rather than default value of a text area when restoring its state. This allows resetting a form with a textarea to work correctly after its state has been restored.
  • manual-tests/resources/textarea-form-back-on-submit.html: Added.
  • manual-tests/textarea-reset-default-value.html: Added.
03:28 Changeset [53131] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-12 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

[Qt] WebCore::Path allocates QPainterPath unnecessarily on the heap
https://bugs.webkit.org/show_bug.cgi?id=33466

WebCore::Path is a pointer to a PlatformPath. In case of Qt that's a
QPainterPath, which itself is a pointer to the elements (QVector).
That creates unecessary allocations in PathQt.cpp.

Replaced the "PlatformPath* m_path;" with a PlatformPathPtr, which
is a plain QPainterPath.

  • platform/graphics/Path.h: (WebCore::Path::platformPath):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::contains): (WebCore::Path::strokeContains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::strokeBoundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::debugString): (WebCore::Path::apply): (WebCore::Path::transform):
03:21 Changeset [53130] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Unreviewed typo fix. :(

  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
03:21 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:10 Changeset [53129] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Unreviewed. Add "error" to the right part of the message.

  • Scripts/webkitpy/commands/queues.py:
03:06 Changeset [53128] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-12 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

media/video-error-does-not-exist.html failed on Snow Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=33434

Add another media test to the skipped list.
I expect these are all timing out for the same reason.
We just don't know the reason yet.

  • platform/mac-snowleopard/Skipped:
02:42 Changeset [53127] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2010-01-12 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] XSL stylesheets can load documents from a different origin

https://bugs.webkit.org/show_bug.cgi?id=33423

Add two expected results for Qt:
QXmlQuery has a different behaviour with regard to loading failures
comparing to libxslt.

  • platform/qt/http/tests/security/xss-DENIED-xsl-document-expected.txt:
  • platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt:

2010-01-12 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] XSL stylesheets can load documents from a different origin

https://bugs.webkit.org/show_bug.cgi?id=33423

  • xml/XSLTProcessorQt.cpp: (WebCore::XSLTUriResolver::XSLTUriResolver): (WebCore::XSLTUriResolver::resolve): (WebCore::XSLTProcessor::transformToString):
02:17 Changeset [53126] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

EWS should show purple when svn-apply fails
https://bugs.webkit.org/show_bug.cgi?id=33527

  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
02:17 Changeset [53125] by hausmann@webkit.org
  • 5 edits
    4 moves
    1 add in trunk/LayoutTests

Touch event layout tests should be in their own subdirectory, so that they can be easily skipped
https://bugs.webkit.org/show_bug.cgi?id=33526

Reviewed by Adam Barth.

  • fast/events/touch/basic-touch-events-expected.txt: Renamed from LayoutTests/fast/events/basic-touch-events-expected.txt.
  • fast/events/touch/basic-touch-events.html: Renamed from LayoutTests/fast/events/basic-touch-events.html.
  • fast/events/touch/touch-coords-in-zoom-and-scroll-expected.txt: Renamed from LayoutTests/fast/events/touch-coords-in-zoom-and-scroll-expected.txt.
  • fast/events/touch/touch-coords-in-zoom-and-scroll.html: Renamed from LayoutTests/fast/events/touch-coords-in-zoom-and-scroll.html.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
02:09 Changeset [53124] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Gustavo Noronha Silva.

https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text

Tweak/correction: Eliminate a needless variable.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
01:50 Changeset [53123] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove copy/paste code from subclasses of AbstractReviewQueue
https://bugs.webkit.org/show_bug.cgi?id=33525

  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
01:42 Changeset [53122] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add Gustavo and Xan as gtk-ews watchers
https://bugs.webkit.org/show_bug.cgi?id=33519

  • Scripts/webkitpy/commands/early_warning_system.py:
01:41 Changeset [53121] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch shouldn't waste my time for with a component prompt
https://bugs.webkit.org/show_bug.cgi?id=33521

The component field isn't very useful for bugs created with
webkit-patch because they're likely to be resolved quickly. Instead of
always prompting for a component, we should just default to the "New
Bugs" component. If the bug stays around for more than five minutes,
we can assign it a proper component.

  • Scripts/webkitpy/bugzilla.py:
01:40 Changeset [53120] by abarth@webkit.org
  • 5 edits
    1 add in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add experimental "land-safely" command to webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=33518

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/steps/init.py:
  • Scripts/webkitpy/steps/postdiffforcommit.py: Added.
00:18 Changeset [53119] by yurys@chromium.org
  • 6 edits in trunk/WebCore

2010-01-12 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Geoffrey Garen.

Allow creating injected script for the inspected script state. The InjectedScript is
cached on the inspected ExecState global object and will be garbage collected when the
object is collected. Each InjectedScript object is assigned unique id.

https://bugs.webkit.org/show_bug.cgi?id=33469

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: InjectedScript is cached on the global object as a field that is not visible from the inspected code. This InjectedScript should be alive as long as the global object is alive and should be accessible from Web Inspector's native code. (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::createInjectedScript): Creates injected script using the lexical global object of the inspected ScriptState. Reference to the object is stored on the global DOM object. (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::discardInjectedScripts): This method is expected to be called when the the InjectedScript are no longer needed. In particular, this should be called before frame navigation.
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::setInjectedScriptSource): This allows to provide injected script source. The source may be loaded in a platform specific way.
00:16 Changeset [53118] by abarth@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

ecma/Date/15.9.5.12-1.js fails every night at midnight
https://bugs.webkit.org/show_bug.cgi?id=28041

Change the test to use a concrete time instead of "now".

  • tests/mozilla/ecma/Date/15.9.5.10-1.js:
  • tests/mozilla/ecma/Date/15.9.5.12-1.js:

01/11/10:

23:25 Changeset [53117] by mjs@apple.com
  • 2 edits in trunk/WebKitSite

Not reviewed; updated for truth (and readability).

Fixed some wrong listings and reorganized this page.

  • security/security-group-members.html:
22:46 Changeset [53116] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-11 Kent Tamura <tkent@chromium.org>

Unreviewd. Remove a duplicated line in an expectation file.

  • platform/mac-leopard/fast/text/find-kana-expected.txt:
21:53 Changeset [53115] by darin@apple.com
  • 3 edits in trunk/LayoutTests

Try to get find-kana tests passing on Qt, Leopard, and Tiger.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Expect more failures.
  • platform/qt/fast/text/find-kana-expected.txt: Ditto.
17:48 Changeset [53114] by darin@apple.com
  • 7 edits in trunk

Fix handling of unusual kana sequences in search
https://bugs.webkit.org/show_bug.cgi?id=33506

Reviewed by Dan Bernstein.

WebCore:

  • editing/TextIterator.cpp:

(WebCore::composedVoicedSoundMark): Removed unnnecessary case for a
non-kana-letter character. This function only works for kana letters.
(WebCore::SearchBuffer::isBadMatch): Fixed voiced sound mark code to
properly handle cases where one character has a shorter list of
combining voiced sound marks than the other.

LayoutTests:

  • fast/text/find-kana-expected.txt: Updated.
  • fast/text/script-tests/find-kana.js: Added new tests for sequences

that do not have composed equivalents. This is needed to test the code
that compares voice marks. The old test cases didn't cover the combining
character code path because normalizing to NFC combined all the sequences.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Updated.
  • platform/qt/fast/text/find-kana-expected.txt: Updated.
17:22 Changeset [53113] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Victor Wang <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

Clear m_acceptedIndexOnAbandon flag when user accepts the selected index.

https://bugs.webkit.org/show_bug.cgi?id=33499

TEST: manual-tests/chromium/onchange-reload-popup.html
It should be covered by the above test. The current
test shell does not support sending keyboard events to popup
list so use manual test for it.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::acceptIndex):
16:55 Changeset [53112] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after introduction of JS_NO_EXPORT

16:42 Changeset [53111] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Eric Seidel.

[GTK] Debug bots crashing in plugins/iframe-shims.html
https://bugs.webkit.org/show_bug.cgi?id=33472

Call computeOffsetInContainerNode() instead of
offsetInContainerNode(), since we are not sure this is always
parent-anchored.

plugins/iframe-shims.html no longer ASSERTS

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
16:15 Changeset [53110] by simon.fraser@apple.com
  • 17 edits in trunk

2010-01-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=33455
Allows plugins to participate in accelerated compositing

For plugins using the CoreAnimation rendering mode, host their CALayers in the
accelerated compositing layer tree.

This requires making normal flow RenderLayers for RenderEmbeddedObjects when they represent
a plugin using this mode.

  • WebCore.base.exp: Export Node::setNeedsStyleRecalc() for use by WebKit.
  • WebCore.xcodeproj/project.pbxproj: Re-order files for sorting.
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::requiresLayer): Make a layer if the plugin is using accelerated compositing mode. (WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing): Asks whether the plugin has a layer, via PluginWidget.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer): RenderEmbeddedObjects should be normal flow layers, and self-painting layers.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Parent the plugin's layer in the GraphicsLayer when updating the layer configuration.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingLayer): (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): RenderEmbeddedObjects that allow accelerated compositing trip accelerated compositing mode for the page.
16:09 Changeset [53109] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Fixed an uninitialized PluginView member (m_mode) which wasn't
set when constructed with a null PluginPackage*

https://bugs.webkit.org/show_bug.cgi?id=33468

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
16:02 Changeset [53108] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt

2010-01-11 William Siegrist <wsiegrist@apple.com>

Sync new Disallow rules from build.webkit.org.

15:58 Changeset [53107] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html

2010-01-11 William Siegrist <wsiegrist@apple.com>

Add Console and CQ Bot Status links to build.webkit.org. Sync CSS changes.

15:41 Changeset [53106] by eric@webkit.org
  • 7 edits in trunk

2010-01-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG radialGradient example radial-gradient-with-outstanding-focalPoint.svg fails
https://bugs.webkit.org/show_bug.cgi?id=32201

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:

2010-01-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG radialGradient example radial-gradient-with-outstanding-focalPoint.svg fails
https://bugs.webkit.org/show_bug.cgi?id=32201

This patch moves every focalPoint that lies outside the circle defined by the radial
gradients central point and its radius to stay inside this circle, as demanded by the
SVG 1.1 specification.
We use r * 0.99 as maximum radius for the aforementioned circle, when determining where
the focalPoint is lying, to achieve compatibility with Firefox.

  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
15:35 Changeset [53105] by eric@webkit.org
  • 5 edits
    2 deletes in trunk/WebKitTools

2010-01-11 Eric Seidel <eric@webkit.org>

No review, rolling out r53079.
http://trac.webkit.org/changeset/53079
https://bugs.webkit.org/show_bug.cgi?id=33197

Adam doens't think this actually works, and believe it caused
a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
rolling this out.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
  • Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
15:00 Changeset [53104] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=33493
Log redirect details to Network channel

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Log response code and Location header field value. Also, removed a redundant null check.
14:56 Changeset [53103] by bdakin@apple.com
  • 13 edits
    8 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33491 REGRESSION:
Many SVG -webkit-shadow tests are currently failing (in the pixel
tests)
-and-
<rdar://problem/7501200>

Reviewed by Oliver Hunt.

The real fix here is to call inflateForShadow() on the repaintRect
in prepareToRenderSVGContent(). But in order to do that, I had to
move inflateForShadow() to a different class since functions in
SVGRenderBase cannot call each other. inflateForShadow() now exists
in SVGRenderStyle which I think makes some sense because a similar
function that returns a box shadow's extent exists on RenderStyle.

Now call inflateForShadow() through the SVGRenderStyle.

  • rendering/RenderForeignObject.cpp:

(WebCore::RenderForeignObject::computeRectForRepaint):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::computeRectForRepaint):

  • rendering/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::computeRectForRepaint):

No longer implement inflateForShadow() here.

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent): Call new
inflateForShadow() through the SVGRenderStyle

  • rendering/SVGRenderSupport.h:

Implementation of inflateForShadow() now lives here.

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::getSVGShadowExtent):
(WebCore::SVGRenderStyle::inflateForShadow):

  • rendering/style/SVGRenderStyle.h:

LayoutTests: New tests for https://bugs.webkit.org/show_bug.cgi?id=33491
REGRESSION: Many SVG -webkit-shadow tests are currently failing (in
the pixel tests)
-and-
<rdar://problem/7501200>

Reviewed by Oliver Hunt.

I would like to note that this change fixes some existing layout
tests as well.

  • platform/mac/svg/css/shadow-with-large-radius-expected.checksum: Added.
  • platform/mac/svg/css/shadow-with-large-radius-expected.png: Added.
  • platform/mac/svg/css/shadow-with-large-radius-expected.txt: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.checksum: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.png: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.txt: Added.
  • platform/mac/svg/css/stars-with-shadow-expected.checksum:
  • platform/mac/svg/css/stars-with-shadow-expected.png:
  • svg/css/shadow-with-large-radius.svg: Added.
  • svg/css/shadow-with-negative-offset.svg: Added.
14:52 Changeset [53102] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-11 Eric Seidel <eric@webkit.org>

Rubber-stamped by Csaba Osztrogonac.

Web Inspector: External resource relative URLs cannot be navigated to from the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=33024

  • platform/qt/Skipped: Skip this new test, Qt's DRT doesn't support evaluateInWebInspector()
14:46 Changeset [53101] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=33411

Reviewed by Eric Seidel.

Missing updated test result for gtk.

  • platform/gtk/editing/deleting/5115601-expected.txt:
14:33 Changeset [53100] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-01-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Rewrite relative URLs in the ElementsTreeOutline to make them navigable

Targets for "src" and "href" attribute values in the Elements outline tree
are rewritten to full URLs whenever possible.
https://bugs.webkit.org/show_bug.cgi?id=33024

  • inspector/elements-panel-rewrite-href-expected.txt: Added.
  • inspector/elements-panel-rewrite-href.html: Added.

2010-01-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Rewrite relative URLs in the ElementsTreeOutline to make them navigable

Targets for "src" and "href" attribute values in the Elements outline tree
are rewritten to full URLs whenever possible.
https://bugs.webkit.org/show_bug.cgi?id=33024

Test: inspector/elements-panel-rewrite-href.html

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._rewriteAttrHref): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
  • inspector/front-end/inspector.js:
14:20 Changeset [53099] by oliver@apple.com
  • 2 edits in trunk/SunSpider

2010-01-11 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Sunspider parse-only tests don't run
https://bugs.webkit.org/show_bug.cgi?id=33489

Fix parse-only test list

  • tests/parse-only/LIST:
14:17 Changeset [53098] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

fast/text/international/japanese-kana-letters.html
removed by r53078, so it should be removed from skiplist.

  • platform/qt/Skipped: fast/text/international/japanese-kana-letters.html removed.
13:54 Changeset [53097] by ojan@chromium.org
  • 17 edits in trunk/LayoutTests

2010-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Simon Fraser.

Deflake transitions and animations tests.
https://bugs.webkit.org/show_bug.cgi?id=30029

The transition-end-event tests all had arbitrary timeouts. Give a consistent
timeout to all of them. Give a generous 1 second of buffer to avoid any possibility
of flakiness. If all the transitionEnd events fire before then, the test still
completes without waiting for the timeout.

  • animations/change-keyframes.html: Increase the wiggle room. It's infrequently flaky now, but it is still a tad bit flaky without this extra wiggle room.
  • transitions/repeated-firing-background-color.html: Remove a gratuitous setTimeout.
  • transitions/transition-end-event-all-properties.html:
  • transitions/transition-end-event-attributes.html:
  • transitions/transition-end-event-container.html:
  • transitions/transition-end-event-helpers.js: (runTransitionTest.startTest): (runTransitionTest):
  • transitions/transition-end-event-left.html:
  • transitions/transition-end-event-multiple-01.html:
  • transitions/transition-end-event-multiple-02.html:
  • transitions/transition-end-event-multiple-03.html:
  • transitions/transition-end-event-multiple-04.html:
  • transitions/transition-end-event-nested.html:
  • transitions/transition-end-event-set-none.html:
  • transitions/transition-end-event-transform.html:
  • transitions/transition-end-event-window.html:
  • transitions/zero-duration-with-non-zero-delay-end.html:
13:46 Changeset [53096] by darin@apple.com
  • 1 edit
    2 copies in trunk/LayoutTests

Try to get find-kana and find-russian tests passing on Qt.

  • platform/qt/fast/text/find-kana-expected.txt: Copied from fast/text/find-kana-expected.txt.
  • platform/qt/fast/text/find-russian-expected.txt: Copied from fast/text/find-russian-expected.txt.

Changed to expect failures because text searching does not use
ICU's usearch on this platform, and the non-usearch code is much
less capable.

13:31 Status created by alex@milowski.com
13:23 WebKit Team edited by jpetsovits@rim.com
Add areas of knowledge to my team member information. (diff)
13:04 MathML edited by alex@milowski.com
(diff)
12:35 Changeset [53095] by ap@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=33482
Add a test for Russian text search

  • fast/text/find-russian-expected.txt: Added.
  • fast/text/find-russian.html: Added.
  • fast/text/script-tests/find-russian.js: Added.
12:33 Changeset [53094] by ossy@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Enable JIT and YARR_JIT if (CPU(X86_64) && OS(LINUX) && GCC_VERSION >= 40100)

Reviewed by Ariya Hidayat.

  • wtf/Platform.h:
12:19 Changeset [53093] by darin@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

Try to get find-kana test passing on Tiger and Leopard.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Copied from fast/text/find-kana-expected.txt.

Changed to expect failures due to an older version of ICU on those platforms.

12:14 Changeset [53092] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Updated Windows expected results after r53085.

Reviewed by NOBODY.

  • platform/win/editing/selection/mixed-editability-10-expected.txt:
11:55 Changeset [53091] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-01-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=33481
Uninitialized data members in ArrayStorage


SunSpider reports no change.

  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): Initialize missing data members in the two cases where we don't use fastZeroedMalloc, so it doesn't happen automatically.
11:53 Changeset [53090] by sfalken@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix ChangeLog

11:45 Changeset [53089] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=33480

Improve debugging reliability for WTF on Windows.
Store WTF static library's PDB file into a better location.

11:42 Changeset [53088] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to fix windows builds, by removing the no-longer existant JSSVGPointListCustom.cpp from JSBindingsAllInOne.cpp.

  • bindings/js/JSBindingsAllInOne.cpp:
11:34 Changeset [53087] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.
Remove extraneous entries from def file causing build warning.

11:23 Changeset [53086] by zimmermann@webkit.org
  • 13 edits
    1 move
    7 adds
    1 delete in trunk

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

svg <text> fails to update when setting x/y
https://bugs.webkit.org/show_bug.cgi?id=22384

Introduce JSSVGPODListCustom, refactoring the existing custom code for SVG POD type lists.
(Currently SVGTransformList/SVGPointList was handled correctly, and SVGLengthList/SVGNumberList not)

Remove the need for custom JSSVG*List.cpp implementations, but instead tweak CodeGeneratorJS.pm,
to call into the new JSSVGPODListCustom methods. Fixes dynamic updates of the SVGTextElement
'rotate' & 'x'/'y' SVG DOM properties.

Tests: svg/custom/text-xy-updates-SVGList.xhtml

svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop.html


  • Android.jscbindings.mk: Remove old files from build, add the new header.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSSVGPODListCustom.h: Copied from bindings/js/JSSVGTransformListCustom.cpp. Refactored code to be sharable between all JSSVG*List classes. (WebCore::JSSVGPODListCustom::finishGetter): (WebCore::JSSVGPODListCustom::finishSetter): (WebCore::JSSVGPODListCustom::finishSetterReadOnlyResult): (WebCore::JSSVGPODListCustom::clear): (WebCore::JSSVGPODListCustom::initialize): (WebCore::JSSVGPODListCustom::getItem): (WebCore::JSSVGPODListCustom::insertItemBefore): (WebCore::JSSVGPODListCustom::replaceItem): (WebCore::JSSVGPODListCustom::removeItem): (WebCore::JSSVGPODListCustom::appendItem):
  • bindings/js/JSSVGPointListCustom.cpp: Removed.
  • bindings/js/JSSVGTransformListCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm: Forward any SVGList call on POD list types to the new JSSVGPODListCustom.
  • svg/SVGNumberList.cpp: Make SVGNumberList a SVGPODList, instead of a SVGList, to make dynamic updates work. (WebCore::SVGNumberList::SVGNumberList):
  • svg/SVGNumberList.h:
  • svg/SVGPointList.idl: Remove JSCCustom markers everywhere.
  • svg/SVGTransformList.idl: Ditto.

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

svg <text> fails to update when setting x/y
https://bugs.webkit.org/show_bug.cgi?id=22384

Add simple tests covering SVGLengthList & SVGNumberList updates.

  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.checksum: Added.
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.png: Added.
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
  • svg/custom/text-xy-updates-SVGList.xhtml: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-rotate-prop.js: Added. (executeTest):
10:04 Changeset [53085] by enrica@apple.com
  • 10 edits in trunk

Cannot focus on an empty editable span in a non editable div.
https://bugs.webkit.org/show_bug.cgi?id=33411
<rdar://problem/5982901>

Reviewed by Darin Adler.

WebCore:

We now allow to set the focus inside an empty inline element if it is the only
editable element inside non-editable content.

  • dom/Position.cpp:

(WebCore::Position::isCandidate): Extended to allow positions in inline elements when
at the border between editable and non editable content.
(WebCore::Position::getInlineBoxAndOffset): Modified to be able to calculate the caret
position inside an empty inline.

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs): When merging, we don't always find a break
element, since now an editable inline is a VisiblePosition if it is at editability boundary.

  • editing/VisibleSelection.h: Updated comment on the use of Position member variables

instead of VisiblePosition.

  • page/Frame.cpp:

(WebCore::Frame::selectionLayoutChanged): Changed to avoid multiple calls to upstream and
downstream on the same position.

LayoutTests:

  • editing/deleting/6026335-expected.txt: Updated to reflect the lack of extra break element.
  • editing/selection/mixed-editability-10-expected.txt: Updated to cover the new case.
  • editing/selection/mixed-editability-10.html: Updated to cover the new case.
  • platform/mac/editing/deleting/5115601-expected.txt: Updated to reflect the lack of extra break element.
09:57 Changeset [53084] by kov@webkit.org
  • 5 edits in trunk

Revert 53075 since it caused ASSERTS to be hit.

09:16 Changeset [53083] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-01-06 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Nikolas Zimmermann.

[V8] IsRefPtrType() in CodeGeneratorV8.pm increases maintenance burden.
https://bugs.webkit.org/show_bug.cgi?id=32994

Refactoring, covered by existings tests.

  • bindings/scripts/CodeGeneratorV8.pm: Reversed testing for ref-counted objects,

since there's a much smaller (and more stable) set of non-ref-counted ones.

09:08 Changeset [53082] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=33472
[GTK] Debug bots crashing in plugins/iframe-shims.html

Skip test that fails on bots, but passes locally, so we can
investigate.

09:05 Changeset [53081] by japhet@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-01-08 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Test that document.referrer is properly preserved through a redirect.

https://bugs.webkit.org/show_bug.cgi?id=33407

  • http/tests/navigation/redirect-preserves-referrer-expected.txt: Added.
  • http/tests/navigation/redirect-preserves-referrer.html: Added.
  • http/tests/navigation/resources/redirect-to-referrer-check.pl: Added.
  • http/tests/navigation/resources/referrer.html: Added.
09:02 Changeset [53080] by knorton@google.com
  • 7 edits in trunk/WebCore

2010-01-11 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Fixes the fact that timeline panel results are skewed by the use of DOM mutation events.
https://bugs.webkit.org/show_bug.cgi?id=32846

Instead of using DOM mutation events in InspectorDOMAgent, InspectorController is now called
directly when the DOM is mutated.

  • dom/ContainerNode.cpp: Calls InspectorController directly when child nodes are added/removed. (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: Calls InspectorController directly when attributes are added/removed. (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::didRemoveDOMNode): (WebCore::InspectorController::didModifyDOMAttr):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr):
  • inspector/InspectorDOMAgent.h:
08:50 Changeset [53079] by abarth@webkit.org
  • 5 edits
    1 copy
    1 add in trunk/WebKitTools

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by David Kilzer.

bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
https://bugs.webkit.org/show_bug.cgi?id=33197

We should just search for bug numbers in the ChangeLogs instead of in
the whole diff.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
  • Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
08:30 Changeset [53078] by darin@apple.com
  • 3 edits
    3 adds
    2 deletes in trunk

REGRESSION: Japanese text search ignores small vs. large and voicing mark differences
https://bugs.webkit.org/show_bug.cgi?id=30437
rdar://problem/7214058

Reviewed by Alexey Proskuryakov.

WebCore:

Test: fast/text/find-kana.html

  • editing/TextIterator.cpp:

(WebCore::isKanaLetter): Added.
(WebCore::isSmallKanaLetter): Added.
(WebCore::composedVoicedSoundMark): Added.
(WebCore::isCombiningVoicedSoundMark): Added.
(WebCore::containsKanaLetters): Added.
(WebCore::normalizeCharacters): Added.
(WebCore::SearchBuffer::SearchBuffer): Initialize the data members
m_targetRequiresKanaWorkaround and m_normalizedTarget.
(WebCore::SearchBuffer::isBadMatch): Added. Checks for matches that
ICU's default collation considers correct, but we consider incorrect.
(WebCore::SearchBuffer::search): Added code to call isBadMatch and
move to the next match with usearch_next if the result is true.

LayoutTests:

  • fast/text/international/japanese-kana-letters-expected.txt: Removed.
  • fast/text/international/japanese-kana-letters.html: Removed.
  • fast/text/find-kana-expected.txt: Added.
  • fast/text/find-kana.html: Added.
  • fast/text/script-tests/find-kana.js: Added.

This includes all the tests that were in the old test removed above, with three
differences:

1) Moved out of "international" directory because Mitz wants to phase that

directory out.

2) Added more tests to cover more cases involving things like decomposed

characters and different voice marks.

3) Used script-tests, so results list passing tests as well as failing tests.

We could still test even more, but this should at least cover all the lines of
code in the current bug fix patch.

08:15 Changeset [53077] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Add private API for QWebFrame scrolling, to maintain binary compatibility with Qt 4.6.

Reviewed by Holger Freyther.

This is just a temporary addition until we have introduced #ifdefs to allow
safely removing the private API again.

  • Api/qwebframe.cpp:

(qtwebkit_webframe_scrollRecursively):

07:52 Changeset [53076] by ddkilzer@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Created a unit-tested function to parse the header block of
a Git or SVN diff -- for future refactoring of svn-apply and
svn-unapply.

Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-11
Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=33447

  • Scripts/VCSUtils.pm:
    • Added parseDiffHeader().
    • Removed irrelevant comment from gitdiff2svndiff().
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
    • Added 48 unit tests for parseDiffHeader().
07:51 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
07:15 Changeset [53075] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

[GTK] couple fixes for signal emissions, and property notifications
https://bugs.webkit.org/show_bug.cgi?id=33428

Fix commitedLoad being called where it should not, causing it to
be called one time too many in some cases. We now match Qt's and
Mac's behavior here.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
  • tests/testloading.c: (load_error_status_changed_cb):
05:16 QtWebKitReleases edited by hausmann@webkit.org
(diff)
04:23 Changeset [53074] by ossy@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-11
[Qt] Add expected files for the following passing new tests.
Compared to the mac expected files these only differ in svg dumping style and font metrics.

  • platform/qt/fast/repaint/block-no-inflow-children-expected.txt: Added.
  • platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
  • platform/qt/svg/custom/marker-referencePoint-expected.txt: Added.
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt: Added.
  • platform/qt/svg/text/selection-background-color-expected.txt: Added.
04:12 Changeset [53073] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix.

  • platform/qt/Skipped:
04:03 Changeset [53072] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-11 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text

  • accessibility/gtk/AccessibilityObjectWrapperAtk.h
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored): (webkit_accessible_text_get_caret_offset):
  • editing/gtk/SelectionControllerGtk.cpp: (SelectionController::notifyAccessibilityForSelectionChange)

Adjust the caret offset and object with focus to reflect the
unignored parent of the static text object which contains the
caret. This is necessary because the static text objects are
no longer being exposed to ATs.

03:48 Changeset [53071] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html fails on buildbot
https://bugs.webkit.org/show_bug.cgi?id=33465

  • platform/qt/Skipped: fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html skipped.
03:35 Changeset [53070] by zimmermann@webkit.org
  • 45 edits in trunk/LayoutTests

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Update SVG test baseline, after the SVG text painting changes, a while ago.
The differences are all below <0.1%, and only show up when running with --tolerance 0.

01:44 Changeset [53069] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2010-01-11 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Touchevent coordinates are incorrect after page zoom and page scroll
https://bugs.webkit.org/show_bug.cgi?id=32899

  • fast/events/touch-coords-in-zoom-and-scroll-expected.txt: Added.
  • fast/events/touch-coords-in-zoom-and-scroll.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:

2010-01-11 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Touchevent coordinates are incorrect after page zoom and page scroll
https://bugs.webkit.org/show_bug.cgi?id=32899

Test: fast/events/touch-coords-in-zoom-and-scroll.html

  • dom/Touch.cpp: (WebCore::contentsX): (WebCore::contentsY):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
01:20 Changeset [53068] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-11 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Have "Paste and Match Style" fire the dom paste event.
https://bugs.webkit.org/show_bug.cgi?id=30639

  • editing/execCommand/paste-and-match-style-event.html: Added.

2010-01-11 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Have "Paste and Match Style" fire the dom paste event.
https://bugs.webkit.org/show_bug.cgi?id=30639

Test: editing/execCommand/paste-and-match-style-event.html

  • editing/Editor.cpp: (WebCore::Editor::pasteAsPlainText):

01/10/10:

22:53 Changeset [53067] by oliver@apple.com
  • 2 edits in trunk/WebCore

Rollout renderpath culling as it once again breaks pixel tests.

22:14 Changeset [53066] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-01-10 Adam Barth <abarth@webkit.org>

Rubber stamped by David Kilzer.

bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
https://bugs.webkit.org/show_bug.cgi?id=33197

Fix a typo: Commmand -> Command.

  • Scripts/webkitpy/commands/abstractsequencedcommand.py:
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/multicommandtool.py:
22:09 Changeset [53065] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-10 Daniel Bates <dbates@webkit.org>

Unreviewed, fix typo.


Fixed typo in test LayoutTests/fast/events/frame-programmatic-focus.html.
The word "frame" should be "iframe" in the string "<input> in frame blurred"
based on the context of the test. In particular, the line "<input> in iframe focused"
and the use of an iframe in the test.

  • fast/events/frame-programmatic-focus-expected.txt:
  • fast/events/frame-programmatic-focus.html:
21:36 Changeset [53064] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-10 Daniel Bates <dbates@webkit.org>

Rubber-stamped by Eric Seidel.

Adding XSSAuditor test http/tests/security/xssAuditor/malformed-HTML.html
to the Qt Skipped file as it times out. We need to look into test further.
See bug #33460 for more details.

  • platform/qt/Skipped:
21:11 Changeset [53063] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Let webkit-patch work with options in $EDITOR
https://bugs.webkit.org/show_bug.cgi?id=33414

The $EDITOR evironment variable might have command line options like
bbedit -w. This patch lets us run those $EDITORs.

  • Scripts/webkitpy/user.py:
20:55 Changeset [53062] by eric@webkit.org
  • 10 edits in trunk

2010-01-10 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319

"" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):
  • tests/mozilla/ecma_2/RegExp/properties-001.js: (AddRegExpCases):
  • tests/mozilla/js1_2/regexp/toString.js: Update relevant Mozilla tests (Mozilla has had this behavior since November 2003).

2010-01-10 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319

Add new test cases and adapt existing ones.

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/regexp-compile-expected.txt:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
20:34 Changeset [53061] by darin@apple.com
  • 120 edits in trunk/JavaScriptCore
  • tests/mozilla/ecma/Array/15.4.1.1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.1.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.1-1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.2-1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.2-2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.2.3.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.3.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.3.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.4.1.js: Added property allow-tabs.
  • tests/mozilla/ecma/Array/15.4.4.js: Added property allow-tabs.
  • tests/mozilla/ecma/LexicalConventions/7.7.4.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.13.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.16.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.18.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.4.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.5.js: Added property allow-tabs.
  • tests/mozilla/ecma/Math/15.8.2.7.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.1.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.2.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.3.1-3.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.3.1-4.js: Added property allow-tabs.
  • tests/mozilla/ecma/String/15.5.3.js: Added property allow-tabs.
  • tests/mozilla/ecma/TypeConversion/9.5-2.js: Added property allow-tabs.
  • tests/mozilla/ecma/jsref.js: Modified property allow-tabs.
  • tests/mozilla/ecma/shell.js: Modified property allow-tabs.
  • tests/mozilla/ecma_2/LexicalConventions/keywords-001.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/RegExp/exec-001.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/String/match-004.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/String/replace-001.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/String/split-002.js: Added property allow-tabs.
  • tests/mozilla/ecma_2/jsref.js: Modified property allow-tabs.
  • tests/mozilla/ecma_2/shell.js: Added property allow-tabs.
  • tests/mozilla/ecma_3/Date/shell.js: Modified property allow-tabs.
  • tests/mozilla/ecma_3/Exceptions/regress-181654.js: Added property allow-tabs.
  • tests/mozilla/ecma_3/RegExp/regress-209067.js: Added property allow-tabs.
  • tests/mozilla/ecma_3/RegExp/regress-85721.js: Added property allow-tabs.
  • tests/mozilla/importList.html: Added property allow-tabs.
  • tests/mozilla/js1_1/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/general1.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/general2.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/slice.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/splice1.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Array/splice2.js: Added property allow-tabs.
  • tests/mozilla/js1_2/Objects/toString-001.js: Added property allow-tabs.
  • tests/mozilla/js1_2/String/charCodeAt.js: Added property allow-tabs.
  • tests/mozilla/js1_2/String/concat.js: Modified property allow-tabs.
  • tests/mozilla/js1_2/String/match.js: Added property allow-tabs.
  • tests/mozilla/js1_2/String/slice.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/Function_object.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/Number.js: Modified property allow-tabs.
  • tests/mozilla/js1_2/function/String.js: Modified property allow-tabs.
  • tests/mozilla/js1_2/function/nesting.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/regexparg-1.js: Added property allow-tabs.
  • tests/mozilla/js1_2/function/regexparg-2-n.js: Added property allow-tabs.
  • tests/mozilla/js1_2/jsref.js: Added property allow-tabs.
  • tests/mozilla/js1_2/operator/equality.js: Added property allow-tabs.
  • tests/mozilla/js1_2/operator/strictEquality.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_dollar_number.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_input.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_input_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastIndex.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastMatch.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastMatch_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastParen.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_lastParen_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_leftContext.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_leftContext_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_multiline.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_multiline_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_object.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_rightContext.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/RegExp_rightContext_as_array.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/alphanumeric.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/asterisk.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/backslash.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/backspace.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/beginLine.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/character_class.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/compile.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/control_characters.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/digit.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/dot.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/endLine.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/everything.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/exec.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/flags.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/global.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/hexadecimal.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/ignoreCase.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/interval.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/octal.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/parentheses.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/plus.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/question_mark.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/simple_form.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/source.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/special_characters.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/string_replace.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/string_search.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/string_split.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/test.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/toString.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/vertical_bar.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/whitespace.js: Added property allow-tabs.
  • tests/mozilla/js1_2/regexp/word_boundary.js: Added property allow-tabs.
  • tests/mozilla/js1_2/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/break.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/continue.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/do_while.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/switch.js: Added property allow-tabs.
  • tests/mozilla/js1_2/statements/switch2.js: Added property allow-tabs.
  • tests/mozilla/js1_3/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_4/shell.js: Added property allow-tabs.
  • tests/mozilla/js1_5/Regress/regress-111557.js: Added property allow-tabs.
  • tests/mozilla/js1_5/Regress/regress-216320.js: Added property allow-tabs.
  • tests/mozilla/menuhead.html: Added property allow-tabs.
  • tests/mozilla/mklistpage.pl: Added property allow-tabs.
  • tests/mozilla/runtests.pl: Added property allow-tabs.
20:09 Changeset [53060] by eric@webkit.org
  • 9 edits in trunk

2010-01-10 Robert Hogan <robert@roberthogan.net>

Reviewed by Adam Barth.

[Qt] Add enableXSSAuditor support to QWebSettings and DRT.

https://bugs.webkit.org/show_bug.cgi?id=33419

  • platform/qt/Skipped:

2010-01-10 Robert Hogan <robert@roberthogan.net>

Reviewed by Adam Barth.

[Qt] Add enableXSSAuditor support to QWebSettings and DRT.

https://bugs.webkit.org/show_bug.cgi?id=33419

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-01-10 Robert Hogan <robert@roberthogan.net>

Reviewed by Adam Barth.

[Qt] Add enableXSSAuditor support to QWebSettings and DRT.

https://bugs.webkit.org/show_bug.cgi?id=33419

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::createWindow):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
19:47 Changeset [53059] by simon.fraser@apple.com
  • 5 edits in trunk/WebCore

2010-01-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Allows plugins to participate in accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=33455

Part 1: rename setContentsToVideo() on GraphicsLayer to setContentsToMedia()
to make it more general. Rename associated enums and methods similarly.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToMedia):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToMedia): (WebCore::GraphicsLayerCA::commitLayerChanges): (WebCore::GraphicsLayerCA::updateContentsMediaLayer):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
19:41 Changeset [53058] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

http/tests/messaging/cross-domain-message-event-dispatch.html failed on Gtk Linux 64-Bit Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33458

Fix flakey test. If the machine is very slow, then more than 10ms
might have elapsed between registering the timeout and calling
postMessage. We can't be sure which order they will be called in.
Re-ordering the call guarantees the arrival order, even if it reduces
our coverage slightly.

  • http/tests/messaging/cross-domain-message-event-dispatch.html:
18:59 Changeset [53057] by oliver@apple.com
  • 2 edits in trunk/WebCore

Bad DOM performance in large SVG files
https://bugs.webkit.org/show_bug.cgi?id=30055

Reviewed by Nikolas Zimmerman

Cull RenderPaths before passing on to the underlying graphics system.

16:47 Changeset [53056] by abarth@webkit.org
  • 6 edits
    8 adds in trunk

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Add defensive initialization of iframe sandbox flags
https://bugs.webkit.org/show_bug.cgi?id=32368

Test the mutating the allow-same-origin directive in the sandbox
attribute does not affect the current document (but does affect the
next document).

  • http/tests/security/resources/sandboxed-iframe-origin-add-step1.html: Added.
  • http/tests/security/resources/sandboxed-iframe-origin-add-step2.html: Added.
  • http/tests/security/resources/sandboxed-iframe-origin-remove-step1.html: Added.
  • http/tests/security/resources/sandboxed-iframe-origin-remove-step2.html: Added.
  • http/tests/security/sandboxed-iframe-origin-add-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-origin-add.html: Added.
  • http/tests/security/sandboxed-iframe-origin-remove-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-origin-remove.html: Added.

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Add defensive initialization of iframe sandbox flags
https://bugs.webkit.org/show_bug.cgi?id=32368

We now initialize the SecurityOrigin's sandbox state directly duing
construction. This lets us properly set the isUnique bit.

Tests: http/tests/security/sandboxed-iframe-origin-add.html

http/tests/security/sandboxed-iframe-origin-remove.html

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::setSandboxFlags):
  • page/SecurityOrigin.h:
16:38 Changeset [53055] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by Nikolas Zimmermann.

http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349

Previously we were using JavaScript URLs to return to the main event
loop, but that is potentially unreliable because there can be only one
scheduled redirect in flight per frame. Let's try using setTimeout
instead. Notice that there isn't a race condition here because the
event loop will always dispatch the actions in the proper order.

  • http/tests/security/xss-DENIED-window-open-javascript-url.html:
14:53 Changeset [53054] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-10 Adam Barth <abarth@webkit.org>

Unreviewed cosmetic change. Remove the status bubble for mac-ews
because we don't have hardware for it at the moment.

  • QueueStatusServer/templates/statusbubble.html:
13:30 Changeset [53053] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-01-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Inspect Element selects the wrong element.
Drive-by fix that focuses dom tree upon settting focuesDOMNode.

https://bugs.webkit.org/show_bug.cgi?id=33449

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/treeoutline.js: (TreeElement.prototype.select):
13:04 QtWebKitJournal edited by hausmann@webkit.org
(diff)
11:15 Changeset [53052] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-01-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce support for flexible line height in the text editor.

https://bugs.webkit.org/show_bug.cgi?id=33431

11:06 Changeset [53051] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-01-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not repaint line numbers while editing within line.

https://bugs.webkit.org/show_bug.cgi?id=33427

02:27 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
00:14 Changeset [53050] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-01-10 Adam Barth <abarth@webkit.org>

Unreviewed whitespace fixes.

  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateSandboxFlags):
  • loader/FrameLoader.h:
00:10 Changeset [53049] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Unify origin sandbox flag with m_noAccess in SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=32372

It turns out the SandboxOrigin bit is slightly different than the
unique origin concept because the sandbox bit is inherited by iframes.
These concepts are separate in the spec, so I think it's ok to keep
them separate in the implementation as well.

No new tests because there is no behavior change.

  • dom/Document.cpp: (WebCore::Document::cookie): (WebCore::Document::setCookie):
  • loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck):
  • page/SecurityOrigin.cpp: (WebCore::schemesWithUniqueOrigins): (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::taintsCanvas): (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::toString): (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage): (WebCore::SecurityOrigin::canAccessCookies): (WebCore::SecurityOrigin::isUnique):

01/09/10:

19:12 Changeset [53048] by dbates@webkit.org
  • 9 edits in trunk

2010-01-09 Daniel Bates <dbates@webkit.org>

No review, rolling out r53044.
http://trac.webkit.org/changeset/53044
https://bugs.webkit.org/show_bug.cgi?id=33419


We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.

  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:

2010-01-09 Daniel Bates <dbates@webkit.org>

No review, rolling out r53044.
http://trac.webkit.org/changeset/53044
https://bugs.webkit.org/show_bug.cgi?id=33419


We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

2010-01-09 Daniel Bates <dbates@webkit.org>

No review, rolling out r53044.
http://trac.webkit.org/changeset/53044
https://bugs.webkit.org/show_bug.cgi?id=33419


We need to look into this some more because the Qt
bot is failing the XSSAuditor tests. See bug #33419
for more details.

  • platform/qt/Skipped:
18:52 Changeset [53047] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-09 Daniel Bates <dbates@webkit.org>

No review, rolling out r53045.
http://trac.webkit.org/changeset/53045
https://bugs.webkit.org/show_bug.cgi?id=33440

This fix did not resolve the issue. That is, more XSSAuditor tests are
failing on the Qt bot. So, we're going ultimately going to rollout the
change committed in change set 53044 <http://trac.webkit.org/changeset/53044>,
but we need to first rollout the attempted fix committed in change
set 53045.

  • platform/qt/Skipped:
18:36 Changeset [53046] by abarth@webkit.org
  • 28 edits in trunk

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts to reflect what the method actually
means. This is a trivial change, but it involved touching a lot of
call sites.

  • WebCore.PluginHostProcess.exp:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::canExecuteScripts): (WebCore::ScriptController::executeScript):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::bindingRootObject): (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::jsObjectForPluginElement): (WebCore::ScriptController::executeScriptInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::windowScriptObject):
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/js/ScriptState.cpp: (WebCore::scriptStateFromNode):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::retrieve):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::evaluateScript):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::controls):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken):
  • inspector/InspectorController.cpp: (WebCore::canPassNodeToJavaScript):
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isProcessingUserGesture): (WebCore::FrameLoader::open): (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds): (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::bindToWindowObject):

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

ScriptController::isEnabled needs to be renamed
https://bugs.webkit.org/show_bug.cgi?id=32063

Rename ScriptController::isEnabled to
ScriptController::canExecuteScripts.

  • WebFrame.cpp: (wxWebFrame::RunScript):
18:00 Changeset [53045] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-09 Daniel Bates <dbates@webkit.org>

Rubber-stamped by Adam Barth.

Adds failing XSSAuditor tests to the Qt Skipped file
while we come up with a fix for them. See bug #33440
for more details.

  • platform/qt/Skipped:
16:40 Changeset [53044] by dbates@webkit.org
  • 9 edits in trunk

2010-01-09 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33419

Adds support for the XSSAuditor to the Qt DRT.

  • Api/qwebsettings.cpp: Updated comment to reflect added key XSSAuditorEnabled.
  • Api/qwebsettings.h: Adds settings key XSSAuditorEnabled.

2010-01-09 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33419

Removes the XSSAuditor tests from the Qt Skipped file since
we now can run these tests.

  • platform/qt/Skipped:

2010-01-09 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33419

Adds support for the XSSAuditor to the Qt DRT.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
16:20 Changeset [53043] by abarth@webkit.org
  • 3 edits
    1 copy
    1 add in trunk/WebKitTools

2010-01-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Retry writes to QueueStatusServer when we get 500 errors
https://bugs.webkit.org/show_bug.cgi?id=33412

This prevents the queues from failing to mark a patch as "pass" or
"fail" when AppEngine throws 500 errors.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/networktransaction.py: Added.
  • Scripts/webkitpy/networktransaction_unittest.py: Added.
  • Scripts/webkitpy/statusserver.py:
  • Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
  • Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
  • Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
16:18 Changeset [53042] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-09 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

Inspector font for errors is ugly on non-OSX platforms
https://bugs.webkit.org/show_bug.cgi?id=33340

  • css/view-source.css: Add a fallback to sans-serif on a CSS selector that previously only listed Lucida Grande.
16:01 Changeset [53041] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers

Reviewed by Eric Seidel.

  • QueueStatusServer/templates/statusbubble.html: Added

-moz-border-radius and -webkit-border-radius to provide rounded
borders in older Firefox and Safari browsers.

14:50 Changeset [53040] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-09 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by David Kilzer.

Modified VCSUtils::gitdiff2svndiff() to accept strings that
end in vertical white space.

https://bugs.webkit.org/show_bug.cgi?id=33415

  • Scripts/VCSUtils.pm:
  • Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
10:45 Changeset [53039] by mitz@apple.com
  • 5 edits
    4 adds in trunk

<rdar://problem/7525778> Font fallback kills SVG kerning
https://bugs.webkit.org/show_bug.cgi?id=33400

Reviewed by Nikolas Zimmermann.

WebCore:

Test: platform/mac/fast/text/sticky-typesetting-features.html

Cache font attributes separately for different typesetting features.

  • platform/graphics/SimpleFontData.h: Replaced single-element caches

with maps.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::disableLigatures): Added an ATSUStyle parameter.
(WebCore::initializeATSUStyle): Look up the ATSUStyle in the map and
initialize if necessary. Return the ATSUStyle.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):
Use the ATSUStyle returned from initializeATSUStyle().

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformDestroy): Destroy the ATSUStyles in the
map.
(WebCore::SimpleFontData::getCFStringAttributes): Look up the attributes
dictionary in the map and initialize if necessary.

LayoutTests:

  • platform/mac/fast/text/sticky-typesetting-features-expected.checksum: Added.
  • platform/mac/fast/text/sticky-typesetting-features-expected.png: Added.
  • platform/mac/fast/text/sticky-typesetting-features-expected.txt: Added.
  • platform/mac/fast/text/sticky-typesetting-features.html: Added.

01/08/10:

23:49 Changeset [53038] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Adam Barth <abarth@webkit.org>

Unreviewed. Fix namespace indent for SecurityOrigin.h.

  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::domainWasSetInDOM): (WebCore::SecurityOrigin::protocol): (WebCore::SecurityOrigin::host): (WebCore::SecurityOrigin::domain): (WebCore::SecurityOrigin::port): (WebCore::SecurityOrigin::canLoadLocalResources): (WebCore::SecurityOrigin::setSandboxFlags): (WebCore::SecurityOrigin::isSandboxed): (WebCore::SecurityOrigin::canAccessDatabase): (WebCore::SecurityOrigin::canAccessStorage): (WebCore::SecurityOrigin::):
23:40 Changeset [53037] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-01-08 Adam Barth <abarth@webkit.org>

Reviewed by Dmitry Titov.

bindings/v8/DOMData is missing a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=33390

DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
but it does not have a virtual destructor. While this isn't currently causing
any leaks, since there are no instances of ChildThreadDOMData or
MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
compiler generates the following compilation error:

"/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
functions and accessible non-virtual destructor"

We therefore need to add a virtual destructor to DOMData.

  • bindings/v8/DOMData.cpp: (WebCore::DOMData::~DOMData):
  • bindings/v8/DOMData.h:
23:09 Changeset [53036] by dbates@webkit.org
  • 7 edits in trunk

2010-01-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.
Moreover, fixes all "Weird number of spaces at line-start. Are you using a 4-space indent?"
errors reported by check-webkit-style.

No functionality was changed. So, no new tests.

  • wtf/Platform.h:

2010-01-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.

No functionality was changed. So, no new tests.

  • src/GraphicsContext3D.cpp:

2010-01-08 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33417

Cleans up style errors exposed by the patch for bug #33198.

No functionality was changed. So, no new tests.

  • platform/graphics/SimpleFontData.h:
  • plugins/PluginPackage.cpp:
20:48 Changeset [53035] by simon.fraser@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

2010-01-08 Simon Fraser <simon.fraser@apple.com>

No review.

Remove layout test that was committed by mistake.

  • compositing/webgl/webgl-blending.html: Removed.
20:07 Changeset [53034] by simon.fraser@apple.com
  • 4 edits
    26 adds in trunk

2010-01-08 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

WebGL canvas paints background color twice
https://bugs.webkit.org/show_bug.cgi?id=33361

Clean up some logic around "directly composited" content: some images, video, and WebGL.

We previously set the GraphicsLayer background color to the CSS background color
in some cases where the box has no other decorations. However, the content
layer's bounds do not correspond with the background box in many cases,
and we could end up both painting the background color, and setting it on the layer.

Simplify this logic to never use layer background colors, and thus skip allocating
backing store only when the element has no visible box decorations.

Tests: compositing/images/direct-image-background-color.html

compositing/reflections/simple-composited-reflections.html
compositing/video/video-background-color.html
compositing/webgl/webgl-background-color.html
compositing/webgl/webgl-blending.html

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::is3DCanvas): Utility to determine if a RenderObject is a canvas with WebGL (WebCore::RenderLayerBacking::RenderLayerBacking): Remove m_hasDirectlyCompositedContent. (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): canUseDirectCompositing() is renamed to isDirectlyCompositedImage() and only applies to images now. No longer set layer background color. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Just use hasPaintedContent() as the argument to setDrawsContent(). (WebCore::hasBoxDecorationsOrBackground): Renamed. (WebCore::RenderLayerBacking::hasNonCompositingContent): (WebCore::hasBoxDecorationsOrBackgroundImage): Renamed from hasBoxDecorations(). (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Moved test for hasOverflowControls() into hasNonCompositingContent() and removed the FIXME comment. (WebCore::RenderLayerBacking::containsPaintedContent): New method that decides if the layer (and its non-composited children) has any content that must be painted into backing store. (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Renamed from canUseDirectCompositing() and reduced to only apply to images. (WebCore::RenderLayerBacking::rendererContentChanged): 3D canvas no longer falls under the canUseDirectCompositing() scope.
18:16 Changeset [53033] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

<http://webkit.org/b/33410> Fix "View Plain Diff"/"View Formatted Diff" button

Reviewed by Adam Barth.

This button was broken during a previous Bugzilla upgrade after
changes were made to the names of objects exposed on templates.

  • template/en/custom/attachment/reviewform.html.tmpl: Changed

attachid to attachment.id and ispatch to attachment.ispatch.
Also tweaked the format to use 4 table columns instead of 5.

17:57 Changeset [53032] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Eric Seidel.

Don't store RegExp flags string representation
https://bugs.webkit.org/show_bug.cgi?id=33321

It's unused; the string representation is reconstructed from flags.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h:
17:46 Changeset [53031] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

17:45 Changeset [53030] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.22

New tag.

17:39 Changeset [53029] by mrowe@apple.com
  • 8 edits in branches/safari-4-branch

Merge r52141.

17:39 Changeset [53028] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

17:25 Changeset [53027] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Use member initialization syntax instead of assignment for member variables of Document used
for determining minimum layout delay.
https://bugs.webkit.org/show_bug.cgi?id=33316

No new tests, style change only.

  • dom/Document.cpp: Modified. (WebCore::Document::Document): Modified. Use initializer list for m_startTime, m_overMinimumLayoutThreshold and m_extraLayoutDelay.
17:02 Changeset [53026] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-01-08 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Passing array that is too large to set method of WebGLArrays does not throw an exception
https://bugs.webkit.org/show_bug.cgi?id=33352

Added needed range checks to JSC and V8 custom bindings. Expanded
preexisting test suite for WebGLArrays and updated its expected
results. Tested in WebKit and Chromium.

  • fast/canvas/webgl/array-set-out-of-bounds-expected.txt: Added.
  • fast/canvas/webgl/array-set-out-of-bounds.html: Added.
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-01-08 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Passing array that is too large to set method of WebGLArrays does not throw an exception
https://bugs.webkit.org/show_bug.cgi?id=33352

Added needed range checks to JSC and V8 custom bindings. Expanded
preexisting test suite for WebGLArrays and updated its expected
results. Tested in WebKit and Chromium.

Test: fast/canvas/webgl/array-set-out-of-bounds.html

  • bindings/js/JSWebGLArrayHelper.h: (WebCore::setWebGLArrayFromArray):
  • bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::setWebGLArrayFromArray):
17:02 Changeset [53025] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Memory use grows grows possibly unbounded in this JavaScript Array test case
https://bugs.webkit.org/show_bug.cgi?id=31675

This fixes one observed bug in this test case, which is that
arrays don't report extra cost for the sparse value maps.

SunSpider reports a small speedup.

  • runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): Report extra memory cost for the sparse value map.
  • runtime/JSArray.h:
16:46 Changeset [53024] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

http/tests/xmlhttprequest/logout.html failed on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=31412

  • platform/mac-tiger/Skipped: After talking with Alexey, we're just gonna skip the failing test on Tiger.
16:30 Changeset [53023] by ap@apple.com
  • 3 edits
    6 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=32962
HTML tags are wrongfully parsed when setting innerHTML of a SCRIPT element

Also fixed the same for STYLE elements.

Tests: fast/dom/css-innerHTML.html

fast/dom/script-innerHTML-x.xhtml
fast/dom/script-innerHTML.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): Don't parse JS or CSS as HTML, matching Firefox.
16:20 Changeset [53022] by bfulgham@webkit.org
  • 3 edits in trunk/WebKit/win

Build fix, no review.

Protect video control logic inside ENABLE(VIDEO).

  • WebView.cpp:

(WebView::enterFullscreenForNode):
(WebView::exitFullscreen):

  • WebView.h:
16:05 Changeset [53021] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Replacing all RANDOMBLOB calls with ZEROBLOB calls in preparation
for denying RANDOMBLOB calls in HTML5 DB transactions.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33396

  • storage/open-database-while-transaction-in-progress.html:
15:59 Changeset [53020] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Included UNCONFIRMED bugs by default in advanced search query

Rubber-stamped by Alexey Proskuryakov.

  • data/params: Prepended 'bug_status=UNCONFIRMED&' to

'defaultquery' parameter.

15:53 Changeset [53019] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33279
fast/websockets/websocket-event-target.html causes any test after it to fail

  • fast/websockets/script-tests/websocket-event-target.js: The test uses an HTTP server URL to create a WebSocket, so an error may be logged to console when detected (this is timing dependent).
  • platform/mac/Skipped: Removed the test from Skipped list.
15:52 Changeset [53018] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

run-javascriptcore-tests needs a --quiet flag
https://bugs.webkit.org/show_bug.cgi?id=33399

Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.

  • Scripts/webkitpy/steps/runtests.py:
15:35 Changeset [53017] by bdakin@apple.com
  • 9 edits
    8 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>

Reviewed by Oliver Hunt.

Inflate the repaintRect for the shadow using its extent.

  • rendering/RenderForeignObject.cpp:

(WebCore::RenderForeignObject::computeRectForRepaint):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::computeRectForRepaint):

  • rendering/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::computeRectForRepaint):

  • rendering/SVGRenderSupport.cpp:

(WebCore::getSVGShadowExtent):
(WebCore::SVGRenderBase::inflateForShadow):

  • rendering/SVGRenderSupport.h:

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=32757 Repaint bug
with -webkit-shadow on svg shapes
-and-
<rdar://problem/7389149>

Reviewed by Oliver Hunt.

  • fast/repaint/moving-shadow-on-container.html: Added.
  • fast/repaint/moving-shadow-on-path.html: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Added.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt: Added.
15:27 Changeset [53016] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

FIX: Make patch status appear on reviewform.html.tmpl

  • template/en/custom/attachment/reviewform.html.tmpl: Check

attachment.ispatch (not just ispatch) when deciding whether
to display patch status. Also update layout a bit.

15:22 Changeset [53015] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-08
Reviewed by Alexey Proskuryakov.

To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
the time when Apache and WebSocketServer is locked by tests.
Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
we need to run http and websocket tests after all other tests.
If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
we need to preserve the given order.

  • Scripts/run-webkit-tests:
15:22 Changeset [53014] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Update data/params parameters

  • data/params: Updated 'timezone' to turn off DST. Updated

'usebugaliases' and 'usevotes' to turn them off.

15:01 Changeset [53013] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't post style-queue pass messages to bugs
https://bugs.webkit.org/show_bug.cgi?id=33404

These messages aren't needed any more now that we have the status
bubble reporting pass events passively.

  • Scripts/webkitpy/commands/queues.py:
14:51 Changeset [53012] by ap@apple.com
  • 4 edits in trunk/LayoutTests

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32294
http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg

Changed the test to not have any funky characters. Filed bug 33400 to track the underlying
problem with kerning.

  • http/tests/uri/escaped-entity-expected.txt:
  • http/tests/uri/escaped-entity.html:
  • platform/mac/Skipped:
14:45 Changeset [53011] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-01-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Optimize the number of CPUs used for building Qt and Gtk
https://bugs.webkit.org/show_bug.cgi?id=33394

Instead of hardcoding the number 8, we should read the number of CPUs
from the environment.

  • Scripts/webkitpy/executive.py:
  • Scripts/webkitpy/webkitport.py:
  • Scripts/webkitpy/webkitport_unittest.py:
14:31 Changeset [53010] by dglazkov@chromium.org
  • 15 edits in trunk/LayoutTests

2010-01-08 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

New baselines to reflect the smaller repaint areas caused by r52839
https://bugs.webkit.org/show_bug.cgi?id=33271

  • platform/mac/fast/repaint/background-misaligned-expected.checksum:
  • platform/mac/fast/repaint/background-misaligned-expected.png:
  • platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.checksum:
  • platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum:
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
  • platform/mac/fast/repaint/float-new-in-block-expected.checksum:
  • platform/mac/fast/repaint/float-new-in-block-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/mac/fast/repaint/selected-replaced-expected.checksum:
  • platform/mac/fast/repaint/selected-replaced-expected.png:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.checksum:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.png:
14:29 Changeset [53009] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-01-08 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

WebGLArray subclasses do the wrong conversion in indexSetter
https://bugs.webkit.org/show_bug.cgi?id=33350

  • fast/canvas/webgl/array-setters-expected.txt: Added.
  • fast/canvas/webgl/array-setters.html: Added.
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2010-01-08 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

WebGLArray subclasses do the wrong conversion in indexSetter
https://bugs.webkit.org/show_bug.cgi?id=33350

Test: fast/canvas/webgl/array-setters.html

  • bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::indexSetter):
  • bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::indexSetter):
14:05 Changeset [53008] by yong.li@torchmobile.com
  • 2 edits in trunk/JavaScriptCore

2010-01-08 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Remove unnecessary #include from FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=33393

  • wtf/FastMalloc.cpp:
14:05 Changeset [53007] by eric@webkit.org
  • 4 edits in trunk/BugsSite

2010-01-08 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Show patch status in bugs.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=33368

This patch adds an iframe to the show_bug page and the edit attachment
page that displays whether the attachment passed the various bots.

  • template/en/custom/attachment/edit.html.tmpl:
  • template/en/custom/attachment/list.html.tmpl:
  • template/en/custom/attachment/reviewform.html.tmpl:
13:49 Changeset [53006] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

transitions/cancel-transition.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33398

There's a race between the check() call and the final
setTimeout. Just remove the final setTimeout and put
its contents in the check call itself.

  • transitions/cancel-transition.html:
13:48 Changeset [53005] by eric@webkit.org
  • 8 edits
    2 moves in trunk

2010-01-08 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Delegation client
https://bugs.webkit.org/show_bug.cgi?id=32826

Factory related code removed from QtAbstractWebPopup. Popups are now created
by ChromeClientQt.
Popup content information struct added to class QtAbstractWebPopup.
PopupMenuClient is now hidden from higher layers.
QtAbstractWebPopup now receives content information and font as parameters
of method populate.
QtFallbackWebPopup moved to WebKit/qt/WebCoreSupport.

  • WebCore.pro:
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::getItems): (WebCore::PopupMenu::show):
  • platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::popupDidHide): (WebCore::QtAbstractWebPopup::valueChanged):
  • platform/qt/QtAbstractWebPopup.h: (WebCore::QtAbstractWebPopup::Item::):
  • platform/qt/QtFallbackWebPopup.cpp: Removed.
  • platform/qt/QtFallbackWebPopup.h: Removed.

2010-01-08 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Delegation client
https://bugs.webkit.org/show_bug.cgi?id=32826

Added method createPopup to ChromeClientQt used to create popups.
QtFallbackWebPopup moved from WebCore/platform/qt to
WebKit/qt/WebCoreSupport.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createPopup):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/QtFallbackWebPopup.cpp: Added. (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate): (WebCore::QtFallbackWebPopup::showPopup): (WebCore::QtFallbackWebPopup::hidePopup): (WebCore::QtFallbackWebPopup::activeChanged): (WebCore::QtFallbackWebPopup::setParent):
  • WebCoreSupport/QtFallbackWebPopup.h: Added. (WebCore::QtFallbackWebPopup::hide):
13:31 Changeset [53004] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-08 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Skip invalid blocks in CSS property declarations.
https://bugs.webkit.org/show_bug.cgi?id=31231
https://bugs.webkit.org/show_bug.cgi?id=26619

This patch makes the CSS parser skip property declarations containing invalid blocks.

  • fast/css/parsing-error-recovery-expected.txt: Added.
  • fast/css/parsing-error-recovery.html: Added.

2010-01-08 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Skip invalid blocks in CSS property declarations.
https://bugs.webkit.org/show_bug.cgi?id=31231
https://bugs.webkit.org/show_bug.cgi?id=26619

This patch makes the CSS parser skip property declarations containing invalid blocks.

Test: fast/css/parsing-error-recovery.html

  • css/CSSGrammar.y:
13:11 Changeset [53003] by cmarrin@apple.com
  • 8 edits in trunk/LayoutTests

Fixed media test failures caused by http://trac.webkit.org/changeset/52998.
The media controller on Windows now has a full-screen button, which changes
the layout and therefore the test results. I regenerated them for
Windows.

13:07 Changeset [53002] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Roben.

The Windows Release bots were having trouble with the xmlhttprequest tests, so
they were skipped (r50280). They all currently pass on my machine, so unskipping them now.

  • platform/win/Skipped:
12:49 Changeset [53001] by darin@chromium.org
  • 3 edits
    3 adds in trunk/WebKit/chromium

2010-01-08 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Upstream webkit unit tests from the chromium repository
https://bugs.webkit.org/show_bug.cgi?id=33351

This adds one such test (for KURL) and sets up the test framework.

Switch WebKit to build a static library on all platforms. Add a
webkit_unit_tests executable target that runs the unit tests and also
ensures that we don't have any missing symbols (a function that WebKit
as a shared library used to serve).

Changes chromium_src_dir to ../../WebKit/chromium to match how
WebCore.gyp defines that variable.

  • WebKit.gyp:
  • public/WebKitClient.h: (WebKit::WebKitClient::getPluginList): Remove bogus trailing semi-colon. (WebKit::WebKitClient::decrementStatsCounter): Remove bogus trailing semi-colon. (WebKit::WebKitClient::incrementStatsCounter): Remove bogus trailing semi-colon. (WebKit::WebKitClient::traceEventBegin): Remove bogus trailing semi-colon. (WebKit::WebKitClient::traceEventEnd): Remove bogus trailing semi-colon. (WebKit::WebKitClient::histogramCounts): Remove bogus trailing semi-colon.
  • tests: Added.
  • tests/KURLTest.cpp: Added.
  • tests/WebKitTest.h: Added.
12:31 Changeset [53000] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

AX: CSS content not returned correctly in AX
https://bugs.webkit.org/show_bug.cgi?id=33308

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/css-content-attribute.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

  • platform/mac/accessibility/css-content-attribute-expected.txt: Added.
  • platform/mac/accessibility/css-content-attribute.html: Added.
11:58 Changeset [52999] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

transitions/shorthand-border-transitions.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33276

Yet another transitions test that doesn't give consistent
wiggle room. Make all the wiggle rooms account for >=200ms
instead of some that were only giving 100ms wiggle room.

  • transitions/shorthand-border-transitions.html:
11:23 Changeset [52998] by cmarrin@apple.com
  • 17 edits
    2 adds in trunk

Implement full-screen video for Windows
https://bugs.webkit.org/show_bug.cgi?id=31318

10:55 Changeset [52997] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Unreviewed correction.

Accidentally left unnecessary modification to hdcFromContext
in when landing r52995.

  • WebFrame.cpp:

(hdcFromContext): Back out unneeded modification.

10:54 Changeset [52996] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-01-08 Matt Perry <mpcomplete@chromium.org>

Reviewed by Adam Barth.

Fix a regression that removed a call to
FrameLoaderClient::didDestroyScriptContextForFrame.
https://bugs.webkit.org/show_bug.cgi?id=33347

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::disposeContextHandles):
10:16 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
09:30 Changeset [52995] by bfulgham@webkit.org
  • 5 edits in trunk

WebCore: WebKit plugins are not rendered during printing.
https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintWindowedPluginIntoContext): Tell

cairo printing surface to flush so that blank regions do
not write over the plugin's paint operations.

  • rendering/RenderLayer.cpp: Build fix.

(WebCore::RenderLayer::beginTransparencyLayers): Correct

method signature missing for ColorSpace.

WebKit/win: Use correct cairo surface data type for handling print operations.
https://bugs.webkit.org/show_bug.cgi?id=33022.

Reviewed by Adam Roben.

  • WebFrame.cpp:

(scaleFactor): Handle 'scale = 0' case.
(WebFrame::spoolPage): Use scaleFactor helper function. Account for

margin size in region passed to header/footer routines.

(WebFrame::spoolPages): Properly clean up Cairo surface.

09:24 Changeset [52994] by cfleizach@apple.com
  • 7 edits in trunk

REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
https://bugs.webkit.org/show_bug.cgi?id=33300

Reviewed by Eric Seidel.

WebCore:

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
(-[AccessibilityObjectWrapper accessibilityPostedNotification:]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):

LayoutTests:

  • platform/mac/Skipped:
06:27 Changeset [52993] by ossy@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed trivail fix. Missing bugzilla link added to ChangeLog.(r52976)

06:22 Changeset [52992] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

r52976 revealed this failure by re-ordering tests.

I do not have a Snow Leopard build to test with, so skipping this
and filed bug https://bugs.webkit.org/show_bug.cgi?id=33372

  • platform/mac-snowleopard/Skipped: platform/mac/editing/input/devanagari-ligature.html skipped.
05:26 Changeset [52991] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

LayoutTests/media/video-error-abort.html moved to LayoutTests/http/tests/media/video-error-abort.html
by r52923, but wasn't renamed in this skiplist by this commit.

  • platform/win/Skipped:
05:08 Changeset [52990] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

r52976 revealed this failure by re-ordering tests.
r52980 corrected the expected results file, but Windows still fails,
presumably due to another test still affecting this one.

Reviewed by Eric Seidel.

I do not have a windows build to test with, so skipping this
and filed bug https://bugs.webkit.org/show_bug.cgi?id=33374

  • platform/win/Skipped: svg/W3C-SVG-1.1/filters-conv-01-f.svg skipped.
04:59 Changeset [52989] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Simon Hausmann.

commit-queue should run run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=33376

I also made it run the python and perl unit tests.

  • Scripts/webkitpy/steps/runtests.py:
  • Scripts/webkitpy/webkitport.py:
04:46 Changeset [52988] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Threading problems with some of the tests
https://bugs.webkit.org/show_bug.cgi?id=30814

We are going to skip all the storage tests until we find the issue
with the threading system in the gtk port.

  • platform/gtk/Skipped:
04:09 Changeset [52987] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Eric Seidel <eric@webkit.org>

No review, rolling out r52983.
http://trac.webkit.org/changeset/52983
https://bugs.webkit.org/show_bug.cgi?id=33321

Broke 59 JavaScriptCore tests. I don't think Kent knew about
run-javascriptcore-tests. Sadly neither does the commit-bot,
yet.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h: (JSC::RegExp::flags):
03:54 Changeset [52986] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-01-08 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

[GTK] loading test should use SoupServer instead of actual sites
https://bugs.webkit.org/show_bug.cgi?id=33353

Make all the loading tests use SoupServer, instead of fetching
stuff from the Internet.

  • tests/testloading.c: (server_callback): (get_uri_for_path): (test_loading_status): (test_loading_error): (test_loading_cancelled): (load_wentback_status_changed_cb): (load_error_test): (test_loading_goback): (main):
03:50 Changeset [52985] by pfeldman@chromium.org
  • 6 edits
    2 adds
    1 delete in trunk/WebCore

2010-01-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Regex-based syntax highlighting is slow.

https://bugs.webkit.org/show_bug.cgi?id=33330

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/JavaScriptHighlighterScheme.js: Removed.
  • inspector/front-end/JavaScriptTokenizer.js: Added. (WebInspector.JavaScriptTokenizer): (WebInspector.JavaScriptTokenizer.prototype.set line): (WebInspector.JavaScriptTokenizer.prototype.getCondition): (WebInspector.JavaScriptTokenizer.prototype.setCondition): (WebInspector.JavaScriptTokenizer.prototype._charAt): (WebInspector.JavaScriptTokenizer.prototype.nextToken):
  • inspector/front-end/JavaScriptTokenizer.re2js: Added.
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
03:44 Changeset [52984] by eric@webkit.org
  • 8 edits in trunk

2010-01-08 Eric Seidel <eric@webkit.org>

No review, rolling out r52981.
http://trac.webkit.org/changeset/52981
https://bugs.webkit.org/show_bug.cgi?id=33319

Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

2010-01-08 Eric Seidel <eric@webkit.org>

No review, rolling out r52981.
http://trac.webkit.org/changeset/52981
https://bugs.webkit.org/show_bug.cgi?id=33319

Caused two JS tests to start failing:
ecma_2/RegExp/properties-001.js and js1_2/regexp/toString.js

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/regexp-compile-expected.txt:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
03:32 Changeset [52983] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-08 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Don't store RegExp flags string representation
https://bugs.webkit.org/show_bug.cgi?id=33321

It's unused; the string representation is reconstructed from flags.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h:
03:23 Changeset [52982] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Tor Arne Vestbø.

media/unsupported-tracks.html is failing on Snow Leopard Release bot
https://bugs.webkit.org/show_bug.cgi?id=32339

  • platform/mac-snowleopard/Skipped: Add this to join a bunch of other skipped media tests which time out.
03:17 Changeset [52981] by eric@webkit.org
  • 8 edits in trunk

2010-01-08 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319

"" starts a single-line comment, hence "/(?:)/" should be used, according to ECMA.

  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

2010-01-08 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

RegExp.prototype.toString returns "" for empty regular expressions
https://bugs.webkit.org/show_bug.cgi?id=33319

Add new test cases and adapt existing ones.

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/script-tests/regexp-compile.js:
  • fast/regex/non-pattern-characters-expected.txt:
02:22 Changeset [52980] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-08 Eric Seidel <eric@webkit.org>

Reviewed by Simon Hausmann.

http/tests/uri/escaped-entity.html affects the output of svg/W3C-SVG-1.1/filters-conv-01-f.svg
https://bugs.webkit.org/show_bug.cgi?id=32294

  • platform/mac/Skipped: Add http/tests/uri/escaped-entity.html to Skipped list since it affects later tests.
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Check in correct results.
02:12 Changeset [52979] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-07 Eric Seidel <eric@webkit.org>

Reviewed by Darin Fisher.

REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
https://bugs.webkit.org/show_bug.cgi?id=33300

Skipping platform/mac/accessibility/aria-liveregions-notifications.html
to make the bots green until Chris Fleizach can fix the AX Notification system
to correctly unregister logging callbacks.

  • platform/mac/Skipped:
00:51 Changeset [52978] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

RVCT compiler with "-Otime -O3" optimization tries to optimize out
inline new'ed pointers that are passed as arguments.
Proposed patch assigns new'ed pointer explicitly outside function call.

Patch by Norbert Leser <norbert.leser@nokia.com> on 2010-01-08
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33084

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

00:01 Changeset [52977] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

Remove an unnecessary cacheFlush from ARM_TRADITIONAL JIT
https://bugs.webkit.org/show_bug.cgi?id=33203

Reviewed by Gavin Barraclough.

  • assembler/ARMAssembler.cpp: Remove obsolete linkBranch function.

(JSC::ARMAssembler::executableCopy): Inline a clean linkBranch code.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::getLdrImmAddress): Use inline function.
(JSC::ARMAssembler::getLdrImmAddressOnPool): Ditto.
(JSC::ARMAssembler::patchPointerInternal): Remove an unnecessary cacheFlush.
(JSC::ARMAssembler::linkJump): Use patchPointerInternal instead of linkBranch.
(JSC::ARMAssembler::linkCall): Ditto.
(JSC::ARMAssembler::relinkCall): Ditto.

Note: See TracTimeline for information about the timeline view.