Timeline



Jan 15, 2010:

11:38 PM QtWebKitReleases edited by zecke@selfish.org
add some ideas on release engineering (diff)
9:07 PM Changeset in webkit [53357] by simon.fraser@apple.com
  • 13 edits
    72 adds in trunk

2010-01-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein and Adele Peterson.

Support reflections on composited layers
https://bugs.webkit.org/show_bug.cgi?id=31885

Implement reflections (via -webkit-box-reflect:) on compositing layers.

We add to the GraphicsLayer the notion of having a replica, and being a replicated layer.
The replica layer is not parented in the tree, but referenced by another layer.
RenderLayerBacking sets this up when it finds RenderLayers for reflections.

GraphicsLayerCA implements rendering of replica layers by cloning CA layers,
and copying their properties, including animations and contents. Deep reflections
are supported by a hash of clone layers on each GraphicsLayerCA, indexed by
the path down the tree to each replica instance.

When GraphicsLayerCA properties are changed, in most cases the clones must also
be updated.

Tests: compositing/masks/direct-image-mask.html

compositing/reflections/animation-inside-reflection.html
compositing/reflections/compositing-change-inside-reflection.html
compositing/reflections/deeply-nested-reflections.html
compositing/reflections/masked-reflection-on-composited.html
compositing/reflections/nested-reflection-anchor-point.html
compositing/reflections/nested-reflection-animated.html
compositing/reflections/nested-reflection-mask-change.html
compositing/reflections/nested-reflection-on-overflow.html
compositing/reflections/nested-reflection-opacity.html
compositing/reflections/nested-reflection-size-change.html
compositing/reflections/nested-reflection-transformed.html
compositing/reflections/nested-reflection-transition.html
compositing/reflections/nested-reflection.html
compositing/reflections/reflection-opacity.html
compositing/reflections/reflection-ordering.html
compositing/reflections/reflection-positioning.html
compositing/reflections/transform-inside-reflection.html

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::isReplicated): Returns true when this layer has a replicated layer. (WebCore::GraphicsLayer::replicatedLayerPosition): (WebCore::GraphicsLayer::setReplicatedLayerPosition): The position of the replica layer must be special-cased; we cannot just copy the position of the original. (WebCore::GraphicsLayer::didDisplay): Method that indicates that the contents of the layer changed, which gives us a chance to update clone layers. (WebCore::GraphicsLayer::replicaLayer): reference to the replica layer. (WebCore::GraphicsLayer::replicatedLayer): reference to the layer that this (replica) layer is replicating. (WebCore::GraphicsLayer::setReplicatedLayer):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer): (WebCore::GraphicsLayer::setReplicatedByLayer): Hook up a replica with its replicated layer. (WebCore::GraphicsLayer::dumpProperties):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::primaryLayer): Returns a CALayer, since structural layers may not be WebLayers. (WebCore::GraphicsLayerCA::isReplicatedRootClone): Given a cloneID (string representation of the path to a clone down the tree, which is a bitstring of 1 (replica), or 0 (non-replica)), returns true if this ID represents the root of a replica tree. (WebCore::GraphicsLayerCA::primaryLayerClones): Returns a pointer to the hash map of clones of the primary layers.

(WebCore::GraphicsLayerCA::ReplicaState::ReplicaState): Small struct used to track original/clone branching
down the tree during recursion, to build cloneID paths.

(WebCore::GraphicsLayerCA::hasCloneLayers): returns true if this layer has clone layers.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::~GraphicsLayerCA): remove the clone layers. (WebCore::GraphicsLayerCA::setChildren): call noteSublayersChanged() since we may have to update replicas too. (WebCore::GraphicsLayerCA::addChild): ditto (WebCore::GraphicsLayerCA::addChildAtIndex): ditto (WebCore::GraphicsLayerCA::addChildBelow): ditto (WebCore::GraphicsLayerCA::addChildAbove): ditto (WebCore::GraphicsLayerCA::replaceChild): ditto (WebCore::GraphicsLayerCA::removeFromParent): ditto (WebCore::GraphicsLayerCA::setMaskLayer): call propagateLayerChangeToReplicas() (WebCore::GraphicsLayerCA::setReplicatedLayer): note replica changed. (WebCore::GraphicsLayerCA::setReplicatedByLayer): ditto (WebCore::GraphicsLayerCA::moveOrCopyAllAnimationsForProperty): Enhanced to allow moving or copying animations. (WebCore::GraphicsLayerCA::moveOrCopyAnimationsForProperty): Ditto. (WebCore::GraphicsLayerCA::setContentsToImage): call noteSublayersChanged() (WebCore::GraphicsLayerCA::setContentsToVideo): call noteSublayersChanged() (WebCore::GraphicsLayerCA::didDisplay): here is our chance to copy updated contents to clone layers. (WebCore::GraphicsLayerCA::recursiveCommitChanges): (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): pre-order commit, for things that need to be

committed before we recurse on children.

(WebCore::GraphicsLayerCA::commitLayerChangesAfterSublayers): post-order commit, for things that need to be

committed after we recurse on children, like clones.

(WebCore::GraphicsLayerCA::updateLayerNames): New method to match the other 'update' methods.
(WebCore::GraphicsLayerCA::updateSublayerList): Insert replica layers into the hierarchy.
(WebCore::GraphicsLayerCA::updateLayerPosition): update clones.
(WebCore::GraphicsLayerCA::updateLayerSize): ditto
(WebCore::GraphicsLayerCA::updateAnchorPoint): ditto
(WebCore::GraphicsLayerCA::updateTransform): ditto
(WebCore::GraphicsLayerCA::updateChildrenTransform): ditto
(WebCore::GraphicsLayerCA::updateMasksToBounds): ditto
(WebCore::GraphicsLayerCA::updateContentsOpaque): ditto
(WebCore::GraphicsLayerCA::updateBackfaceVisibility): ditto
(WebCore::GraphicsLayerCA::updateStructuralLayer): call ensureStructuralLayer()
(WebCore::moveAnimation): utility to move a CAAnimation from one layer to another.
(WebCore::GraphicsLayerCA::ensureStructuralLayer): refactored code which creates enclosing CALayers for reflection
flattening, or CATransformLayers for preserve-3d.
(WebCore::GraphicsLayerCA::structuralLayerPurpose): indicates why we need a structural layer.
(WebCore::GraphicsLayerCA::updateLayerDrawsContent): update clones
(WebCore::GraphicsLayerCA::updateContentsImage): ditto
(WebCore::GraphicsLayerCA::updateContentsRect): ditto
(WebCore::GraphicsLayerCA::updateMaskLayer): ditto
(WebCore::GraphicsLayerCA::updateReplicatedLayers): This is where we ask for the tree of layers for the replica
and its children, and attach them as sublayers.
(WebCore::GraphicsLayerCA::ReplicaState::cloneID): Build a bitstring from the array of original/clone values; this
string serves to identify clones in the hash map.
(WebCore::GraphicsLayerCA::replicatedLayerRoot): Request the tree of clone layers, set its position and transform,
and return it.
(WebCore::GraphicsLayerCA::setAnimationOnLayer): update clones
(WebCore::GraphicsLayerCA::removeAnimationFromLayer): ditto
(WebCore::GraphicsLayerCA::pauseAnimationOnLayer): ditto
(WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D): udpate sublayers.
(WebCore::GraphicsLayerCA::suspendAnimations): update clones.
(WebCore::GraphicsLayerCA::resumeAnimations): ditto
(WebCore::GraphicsLayerCA::animatedLayerClones): return the hash map for clones of the appropriate layer for the given property.
(WebCore::GraphicsLayerCA::ensureCloneLayers): create and return clones for the CALayers for this layer.
(WebCore::GraphicsLayerCA::removeCloneLayers): clear out the clone layers.
(WebCore::GraphicsLayerCA::positionForCloneRootLayer): the root of a clonal subtree needs its position and transform to be special-cased,
since it doesn't just copy those properties from the original.
(WebCore::GraphicsLayerCA::propagateLayerChangeToReplicas): push the change flags onto the replica.
(WebCore::GraphicsLayerCA::fetchCloneLayers): recurse down sublayers, creating clones of the CALayers along the way, and returning
the root of the clone tree.
(WebCore::copyAnimation): utility to copy an animation from one layer to another. Animations can be shared between layers.
(WebCore::GraphicsLayerCA::cloneLayer): utility to clone a CALayer, copying those properties which GraphicsLayerCA makes use of
(WebCore::GraphicsLayerCA::setOpacityInternal): push opacity changes to clones.
(WebCore::GraphicsLayerCA::updateOpacityOnLayer): ditto
(WebCore::GraphicsLayerCA::noteSublayersChanged): set the ChildrenChanged flag, and proprate changes to the replica, if any.

  • platform/graphics/mac/WebLayer.mm: (-[WebLayer display]): override -display so we know when to update the contents of clone layers
  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer display]): ditto.
  • rendering/RenderLayer.h: (WebCore::RenderLayer::isReflection): New method that returns true if the renderer is a replica.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): initialize m_isReflection (WebCore::RenderLayer::updateReflectionStyle): call setIsReflection
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Put a name on the reflection layer. (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Hook up the GraphicsLayers for the reflection. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Reflection overrides preserve-3d (you have to flatten to reflect). Also hook up updating the reflection layer geometry, and the relica position.

(WebCore::RenderLayerBacking::paintIntoLayer): We no longer paint the reflection in software.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): Hook reflection layers into the compositing logic. (WebCore::RenderLayerCompositor::canAccelerateVideoRendering): No longer have to push video into software if it's reflected. (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Update the bounds of the reflection layer. (WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry): ditto (WebCore::RenderLayerCompositor::requiresCompositingWhenDescendantsAreCompositing): a compositing descendant forces a reflection ancestor to composite now. (WebCore::RenderLayerBacking::containsPaintedContent): Reflection layers don't paint anything. (WebCore::RenderLayerBacking::isDirectlyCompositedImage): No need to fall out of direct compositing mode for masks or reflections any more. (WebCore::RenderLayerBacking::paintIntoLayer): No need to paint the reflection manually now.
  • rendering/RenderObject.h: (WebCore::RenderObject::isReplica):
  • rendering/RenderReplica.h: (WebCore::RenderReplica::isReplica): New method used to determine if a render is a replica.
9:05 PM Changeset in webkit [53356] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-01-15 Doug Muir <dmuir@google.com>

Fix some Layout Test timeouts when run under valgrind.

  • http/tests/history/redirect-js-form-submit-0-seconds.html:
  • http/tests/history/redirect-js-form-submit-2-seconds.html:
  • http/tests/misc/timer-vs-loading.html:
6:14 PM Changeset in webkit [53355] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-01-15 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

CSS2.1 Counters not updated when new elements are inserted in the DOM.
https://bugs.webkit.org/show_bug.cgi?id=32884

  • fast/css/counters/adding-nodes-expected.txt: Added.
  • fast/css/counters/adding-nodes.html: Added.

2010-01-15 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

CSS2.1 Counters not updated when new elements are inserted in the DOM.
https://bugs.webkit.org/show_bug.cgi?id=32884

Test: fast/css/counters/adding-nodes.html

  • rendering/CounterNode.cpp: (WebCore::CounterNode::insertAfter): Modified to handle the addition of nodes with children. Needed when formerly root nodes become descendants of a new node.
  • rendering/RenderCounter.cpp: (WebCore::makeCounterNode): Changed to handle the case when root counter nodes lose their root status as a result of a new root counter node creation. (WebCore::destroyCounterNodeWithoutMapRemoval): Refactored more code into destroyCounterNodeChildren and renamed the function according to its new action. (WebCore::RenderCounter::destroyCounterNodes): Simplified to share more code with the new destroyCounterNode. (WebCore::RenderCounter::destroyCounterNode): Added to allow for selective counterNode destruction. (WebCore::RenderCounter::rendererSubtreeAttached): Added to refresh counter values in response to DOM changes. For renderers with no attached counters the execution time of this function cannot be discerned in comparison with the time needed to add a node or change the style of a node. (WebCore::updateCounters): Helper function for rendererSubtreeAttached. Updates the counters attached to a Renderer in response to the renderer or its ancestors being attached to the renderer tree.
  • rendering/RenderCounter.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): Changed to update counter values if needed.
5:56 PM Changeset in webkit [53354] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix for <rdar://problem/7548432>
Add ALWAYS_INLINE to jsLess for a 1% speedup on llvm-gcc.

Reviewed by Maciej Stachowiak.

  • runtime/Operations.h:

(JSC::jsLess):

5:24 PM Changeset in webkit [53353] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Alexey Proskuryakov.

Move the code adding the child frame to the FrameTree into wxWebFrame constructor
so that it happens before we call init() on the new frame. Fixes asserts checking
frame count consistency.

5:18 PM Changeset in webkit [53352] by darin@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-15 Darin Fisher <darin@chromium.org>

Fix flakey test.

Add a call to clearBackForwardList.

  • fast/history/history-length.html:
5:13 PM Changeset in webkit [53351] by eric@webkit.org
  • 7 edits in trunk

2010-01-15 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Original patch by David Ronis <david.ronis@mcgill.ca>

Upgrade 1.1.17->1.1.18 fails: GTK_WIDGET_TOPLEVEL' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=33486

Deprecated symbols replaced for gtk+ versions over 2.18.

  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenRect):

2010-01-15 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Original patch by David Ronis <david.ronis@mcgill.ca>

Upgrade 1.1.17->1.1.18 fails: GTK_WIDGET_TOPLEVEL' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=33486

Deprecated symbols replaced for gtk+ versions over 2.18.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect):
  • webkit/webkitprivate.cpp: (currentToplevelCallback):
  • webkit/webkitwebframe.cpp: (webkit_web_frame_print_full): (webkit_web_frame_print):
  • webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event):
4:58 PM Changeset in webkit [53350] by darin@chromium.org
  • 2 edits
    1 move in trunk/LayoutTests

2010-01-15 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Disable page cache and add diagnostic output in the failure case.
https://bugs.webkit.org/show_bug.cgi?id=33749

  • fast/history/history-length-expected.txt:
  • fast/history/history-length.html: Copied from fast/history/history-length.html-disabled.
  • fast/history/history-length.html-disabled: Removed.
4:16 PM Changeset in webkit [53349] by oliver@apple.com
  • 2 edits in trunk/WebCore

2010-01-15 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Bad DOM performance in large SVG files
https://bugs.webkit.org/show_bug.cgi?id=30055

Improve the performance of the early culling check by avoiding save/restore
of graphics state in culled case.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
3:21 PM Changeset in webkit [53348] by darin@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2010-01-15 Darin Fisher <darin@chromium.org>

Disable this test temporarily since it is failing on all of the
builders.

  • fast/history/history-length.html: Removed.
  • fast/history/history-length.html-disabled: Copied from fast/history/history-length.html.
2:37 PM Changeset in webkit [53347] by eric@webkit.org
  • 16 edits
    1 delete in trunk

2010-01-15 Eric Seidel <eric@webkit.org>

No review, rolling out r53344.
http://trac.webkit.org/changeset/53344
https://bugs.webkit.org/show_bug.cgi?id=32920

Broke the Chromium Mac builder.

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/SerializedScriptValue.cpp: Removed.
  • bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::toString): (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::postMessageCallback):
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: (WebCore::V8DedicatedWorkerContext::postMessageCallback):
  • bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::pushStateCallback): (WebCore::V8History::replaceStateCallback):
  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::V8MessagePort::postMessageCallback):
  • bindings/v8/custom/V8PopStateEventCustom.cpp: (WebCore::V8PopStateEvent::initPopStateEventCallback): (WebCore::V8PopStateEvent::stateAccessorGetter):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::postMessageCallback):

2010-01-15 Eric Seidel <eric@webkit.org>

No review, rolling out r53344.
http://trac.webkit.org/changeset/53344
https://bugs.webkit.org/show_bug.cgi?id=32920

Broke the Chromium Mac builder.

  • src/PlatformMessagePortChannel.cpp: (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToWorkerObject):
  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postMessageToWorkerContext): (WebKit::WebWorkerClientImpl::postMessageToWorkerObjectTask):
  • src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
2:08 PM Changeset in webkit [53346] by darin@chromium.org
  • 5 edits
    2 adds in trunk

2010-01-15 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

history.length does not return number of elements in history list
https://bugs.webkit.org/show_bug.cgi?id=24472

Test: fast/history/history-length.html

  • page/Page.cpp: (WebCore::Page::getHistoryLength):
1:47 PM Changeset in webkit [53345] by dimich@chromium.org
  • 3 edits in trunk/WebCore

Need to ensure that Document::postTask does not provide the Task with a dangling pointer to destroyed Document
https://bugs.webkit.org/show_bug.cgi?id=31633

Reviewed by Darin Adler.

Don't see a way to add test for it, we don't have a way to reproduce the issue currently.

  • dom/Document.cpp:

(WebCore::DocumentWeakReference::DocumentWeakReference):
(WebCore::DocumentWeakReference::document):
(WebCore::DocumentWeakReference::clear):
(WebCore::Document::Document): Create a weak reference to this Document.
(WebCore::Document::~Document): Clear the weak pointer, preventing further execution of tasks.
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::performTask): Check if the documentWeakReference is cleared by Document destructor - in this case do not run the task.
(WebCore::Document::postTask):

  • dom/Document.h:

(WebCore::DocumentWeakReference::create):

1:28 PM Changeset in webkit [53344] by eric@webkit.org
  • 16 edits
    1 add in trunk

2010-01-15 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by David Levin.

[V8] Support SerializedScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=32920
http://crbug.com/30620

Initial implementation of SerializedScriptValue which is used to
to create a serialized representation of JavaScript objects. This
representation is needed for structured clones and worker messages.

  • WebCore.gypi: Added SerializedScriptValue.cpp.
  • bindings/scripts/CodeGeneratorV8.pm: Removed conversion to string before using SerializedScriptValue.
  • bindings/v8/SerializedScriptValue.cpp: Added. (WebCore::): (WebCore::ZigZag::encode): (WebCore::ZigZag::decode): (WebCore::Writer::Writer): (WebCore::Writer::writeUndefined): (WebCore::Writer::writeNull): (WebCore::Writer::writeTrue): (WebCore::Writer::writeFalse): (WebCore::Writer::writeString): (WebCore::Writer::writeInt32): (WebCore::Writer::writeNumber): (WebCore::Writer::endComposite): (WebCore::Writer::data): (WebCore::Writer::doWriteUint32): (WebCore::Writer::append): (WebCore::Writer::ensureSpace): (WebCore::Writer::fillHole): (WebCore::Writer::charAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::StateBase::~StateBase): (WebCore::Serializer::StateBase::nextState): (WebCore::Serializer::StateBase::setNextState): (WebCore::Serializer::StateBase::composite): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::tag): (WebCore::Serializer::State::State): (WebCore::Serializer::StackCleaner::StackCleaner): (WebCore::Serializer::StackCleaner::~StackCleaner): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::done): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::done): (WebCore::Serializer::ObjectState::advance): (WebCore::Serializer::ObjectState::nextProperty): (WebCore::Serializer::doSerialize): (WebCore::Serializer::push): (WebCore::Serializer::top): (WebCore::Serializer::pop): (WebCore::Serializer::checkComposite): (WebCore::Reader::Reader): (WebCore::Reader::isEof): (WebCore::Reader::read): (WebCore::Reader::readTag): (WebCore::Reader::readString): (WebCore::Reader::readInt32): (WebCore::Reader::readNumber): (WebCore::Reader::doReadUint32): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::deserialize): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::push): (WebCore::Deserializer::pop): (WebCore::Deserializer::stackDepth): (WebCore::Deserializer::element): (WebCore::SerializedScriptValue::SerializedScriptValue): (WebCore::SerializedScriptValue::deserialize):
  • bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::toWireString):

Updated uses of SerializedScriptValue:

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::postMessageCallback):
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: (WebCore::V8DedicatedWorkerContext::postMessageCallback):
  • bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::pushStateCallback): (WebCore::V8History::replaceStateCallback):
  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::V8MessagePort::postMessageCallback):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::postMessageCallback):

2010-01-15 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by David Levin.

[V8] Support SerializedScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=32920
http://crbug.com/30620

Updated uses of SerializedScriptValue:

  • src/PlatformMessagePortChannel.cpp: (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postMessageToWorkerObject):
  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postMessageToWorkerContext): (WebKit::WebWorkerClientImpl::postMessageToWorkerObjectTask):
  • src/WebWorkerImpl.cpp: (WebKit::WebWorkerImpl::postMessageToWorkerContextTask):
1:12 PM WebKit Team edited by Chris Jerdonek
Added myself. (diff)
12:54 PM Changeset in webkit [53343] by oliver@apple.com
  • 3 edits in trunk/WebCore

2010-01-15 Oliver Hunt <oliver@apple.com>

Reviewed by Dirk Schulze.

Bad DOM performance in large SVG files
https://bugs.webkit.org/show_bug.cgi?id=30055

Add an early return when we go to paint a RenderPath that
isn't in the current clip.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw):
12:53 PM Changeset in webkit [53342] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-01-15 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

Make Geolocation::suspend/resume public.
https://bugs.webkit.org/show_bug.cgi?id=33679

These were made private in Bug 32499, but are required by Android to be public.

No new tests, build fix only.

  • page/Geolocation.cpp: Modified (WebCore::Geolocation::suspend): Added back in (WebCore::Geolocation::resume): Added back in
  • page/Geolocation.h: Modified. Make suspend and resume public
12:48 PM Changeset in webkit [53341] by ggaren@apple.com
  • 5 edits
    2 adds in trunk

2010-01-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

REGRESISON: Google maps buttons not working properly
https://bugs.webkit.org/show_bug.cgi?id=31871

REGRESSION(r52948): JavaScript exceptions thrown on Google Maps when
getting directions for a second time
https://bugs.webkit.org/show_bug.cgi?id=33446


SunSpider and v8 report no change.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCacheGetByID): Update our cached offset in case flattening the dictionary changed any of its offsets.
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • runtime/Operations.h: (JSC::normalizePrototypeChain): ditto

2010-01-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

REGRESISON: Google maps buttons not working properly
https://bugs.webkit.org/show_bug.cgi?id=31871

REGRESSION(r52948): JavaScript exceptions thrown on Google Maps when
getting directions for a second time
https://bugs.webkit.org/show_bug.cgi?id=33446


Added a test for these bugs.

  • fast/js/pic/undictionary-expected.txt: Added.
  • fast/js/pic/undictionary.html: Added.
12:36 PM Changeset in webkit [53340] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-15 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by David Kilzer.

Altered parseDiffHeader() to skip unrecognized lines and
other minor clean-ups.

https://bugs.webkit.org/show_bug.cgi?id=33476

  • Scripts/VCSUtils.pm:
    • Changed parseDiffHeader() as follows:
      • Skips over unrecognized lines.
      • Addressed FIXME to remove substitution for "diff" line.
      • Renamed "version" header hash key to "sourceRevision".
      • Eliminated "copiedFromVersion" header hash key.
      • Included "sourceRevision" also for copied files.
      • Checks that copy revision number matches "sourceRevision".
      • No longer returns $foundHeaderEnding.
      • Dies if header ending not found.
      • Diff header dividing line now always added.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Made necessary changes in parseDiffHeader() unit tests.
    • Shortened the file paths in some test cases.
12:26 PM Changeset in webkit [53339] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/index.html

2010-01-15 William Siegrist <wsiegrist@apple.com>

Cleanup buildbot main menu

12:20 PM Changeset in webkit [53338] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-15 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Set pointer cursor when over a breakpoint in the BreakpointsSidebarPane

https://bugs.webkit.org/show_bug.cgi?id=33713

  • inspector/front-end/inspector.css:
12:20 PM Changeset in webkit [53337] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

svg/custom/marker-changes.svg is flaky
https://bugs.webkit.org/show_bug.cgi?id=33728

removing gratuitous setTimeout.

  • svg/custom/marker-changes.svg:
10:56 AM Changeset in webkit [53336] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

transitions/shorthand-border-transitions.html is still flaky on slower bots
https://bugs.webkit.org/show_bug.cgi?id=33721

Increase the tolerance. The test still tests what it was meant to.

  • transitions/shorthand-border-transitions.html:
10:38 AM Changeset in webkit [53335] by Nate Chapin
  • 6 edits in trunk/WebCore

2010-01-15 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Generate more of the custom behaviors that the v8 bindings attach to v8 FunctionTemplates.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Binding.cpp: (WebCore::getToStringName): (WebCore::constructorToString): (WebCore::getToStringTemplate):
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate):
9:46 AM Changeset in webkit [53334] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-01-15 Dimitri Glazkov <Dimitri Glazkov>

No review, rolling out r53331.
http://trac.webkit.org/changeset/53331
https://bugs.webkit.org/show_bug.cgi?id=30055

Broke fast/borders/svg-as-border-image-3.html. Don't give up,
Oliver! You are really, really close.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
9:46 AM Changeset in webkit [53333] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

animations/combo-transform-translate+scale.html failed on Snow Leopard Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33461

Make test half as long. Remove a setTimeout and tweak tolerances to
reduce flakiness.

  • animations/combo-transform-translate+scale.html:
9:13 AM BuildingQtOnSymbian edited by Simon Hausmann
(diff)
9:13 AM BuildingQtOnSymbian edited by Simon Hausmann
(diff)
9:04 AM BuildingQtOnSymbian created by Simon Hausmann
8:46 AM Changeset in webkit [53332] by kov@webkit.org
  • 2 edits in trunk

Rubber-stamped by Xan Lopez.

Bump version to 1.1.19.

  • configure.ac:
8:43 AM QtWebKit edited by Simon Hausmann
(diff)
4:25 AM Changeset in webkit [53331] by oliver@apple.com
  • 2 edits in trunk/WebCore

2010-01-15 Oliver Hunt <oliver@apple.com>

Reviewed by Nikolas Zimmermann.

Bad DOM performance in large SVG files
https://bugs.webkit.org/show_bug.cgi?id=30055

Add an early return when we go to paint a RenderPath that
isn't in the current clip.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
3:59 AM Changeset in webkit [53330] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2010-01-15 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Antti Koivisto.

Use OS(MAC_OS_X) instead of PLATFORM(MAC) when determining navigator.platform

https://bugs.webkit.org/show_bug.cgi?id=33711

  • page/NavigatorBase.cpp:
3:54 AM Changeset in webkit [53329] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-01-14 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Compiler warning: comparisons like 'X<=Y<=Z' do not have their mathematical meaning
https://bugs.webkit.org/show_bug.cgi?id=33575

Patch from Magnus Boman <captain.magnus@gmail.com>

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache): fix compiler warnings.
3:20 AM Changeset in webkit [53328] by pfeldman@chromium.org
  • 9 edits
    1 add in trunk/WebCore

2010-01-14 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Add welcome screen to Profiles pane to provide some instructions for novices.

https://bugs.webkit.org/show_bug.cgi?id=19268

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.get welcomeMessage):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileType.prototype.get welcomeMessage): (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.show): (WebInspector.ProfilesPanel.prototype.registerProfileType): (WebInspector.ProfilesPanel.prototype._addWelcomeMessage.messageButtonClicked): (WebInspector.ProfilesPanel.prototype._addWelcomeMessage): (WebInspector.ProfilesPanel.prototype.showProfile): (WebInspector.ProfilesPanel.prototype.closeVisibleView): (WebInspector.ProfilesPanel.prototype._updateInterface):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WelcomeView.js: Added. (WebInspector.WelcomeView): (WebInspector.WelcomeView.prototype._windowResized): (WebInspector.WelcomeView.prototype.addMessage):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
2:00 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
1:54 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
1:45 AM QtWebKitBackportingFixes edited by Girish Ramakrishnan
(diff)
1:43 AM Changeset in webkit [53327] by Girish Ramakrishnan
  • 2 edits in trunk/WebCore

[Qt/Win] Flash in QGraphicsWebView does not process hover correctly.

Reviewed by Simon Hausmann.

Mouse hover does not work as expected with the flash in some sites.

The problem appears to be that Flash queries NPNVnetscapeWindow on every
mouse hover. I do not how flash uses this value but returning 0 when flash
is in windowless mode solves the problem (When using QGraphicsWebView we
inject wmode opaque, thereby putting the plugin in windowless mode).

https://bugs.webkit.org/show_bug.cgi?id=33591

12:30 AM Changeset in webkit [53326] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-01-15 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for Peer class
https://bugs.webkit.org/show_bug.cgi?id=33670

Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
class Peer - websockets/WebSocketChannelClient.h:38

  • websockets/WorkerThreadableWebSocketChannel.h:
12:23 AM Changeset in webkit [53325] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-01-15 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Oliver Hunt.

[Qt] Allow custom memory allocation control for GraphicsContextPlatformPrivate class
https://bugs.webkit.org/show_bug.cgi?id=33669

Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
class GraphicsContextPlatformPrivate - platform/graphics/qt/GraphicsContextQt.cpp:254

  • platform/graphics/qt/GraphicsContextQt.cpp:
12:20 AM Changeset in webkit [53324] by darin@chromium.org
  • 4 edits
    2 adds in trunk

2010-01-14 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

history.pushState should clear the entire forward history
https://bugs.webkit.org/show_bug.cgi?id=33160

Test: fast/loader/stateobjects/pushstate-clears-forward-history.html

  • history/BackForwardList.cpp: (WebCore::BackForwardList::addItem): (WebCore::BackForwardList::pushStateItem):
  • history/BackForwardList.h:

Jan 14, 2010:

11:48 PM Changeset in webkit [53323] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=33705
UStringImpl::create() should use internal storage

Reviewed by Oliver Hunt.

When creating a UStringImpl copying of a UChar*, we can use an internal buffer,
by calling UStringImpl::tryCreateUninitialized().

Also, remove duplicate of copyChars from JSString, call UStringImpl's version.

Small (max 0.5%) progression on Sunspidey.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::create):

11:31 PM Changeset in webkit [53322] by Csaba Osztrogonác
  • 7 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

REGRESSION: svg/css/circle-in-mask-with-shadow.svg failing pixel tests
https://bugs.webkit.org/show_bug.cgi?id=33498

After http://trac.webkit.org/changeset/53300 Qt expected files should be updated.

  • platform/qt/svg/css/arrow-with-shadow-expected.txt: updated.
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: updated.
  • platform/qt/svg/css/mask-with-shadow-expected.txt: updated.
  • platform/qt/svg/css/path-with-shadow-expected.txt: updated.
  • platform/qt/svg/css/stars-with-shadow-expected.txt: updated.
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt: updated.
10:55 PM Changeset in webkit [53321] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-01-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Oliver Hunt.

[Chromium] Forgot to adopt a ref counted object in StorageNamespaceProxy
https://bugs.webkit.org/show_bug.cgi?id=33704

  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace):
10:43 PM Changeset in webkit [53320] by barraclough@apple.com
  • 20 edits in trunk

JavaScriptCore: Make naming & behaviour of UString[Impl] methods more consistent.
https://bugs.webkit.org/show_bug.cgi?id=33702

Reviewed by Sam Weinig.

UString::create() creates a copy of the UChar* passed, but UStringImpl::create() assumes
that it should assume ownership of the provided buffer (with UString::createNonCopying()
and UStringImpl::createCopying() providing the alternate behaviours). Unify on create()
taking a copy of the provided buffer. For non-copying cases, use the name 'adopt', and
make this method take a Vector<UChar>&. For cases where non-copying construction was being
used, other than from a Vector<UChar>, change the code to allocate the storage along with
the UStringImpl using UStringImpl::createUninitialized(). (The adopt() method also more
closely matches that of WebCore::StringImpl).

Also, UString::createUninitialized() and UStringImpl::createUninitialized() have incompatible
behaviours, in that the UString form sets the provided UChar* to a null or non-null value to
indicate success or failure, but UStringImpl uses the returned PassRefPtr<UStringImpl> to
indicate when allocation has failed (potentially leaving the output Char* uninitialized).
This is also incompatible with WebCore::StringImpl's behaviour, in that
StringImpl::createUninitialized() will CRASH() if unable to allocate. Some uses of
createUninitialized() in JSC are unsafe, since they do not test the result for null.
UStringImpl's indication is preferable, since we may want a successful call to set the result
buffer to 0 (specifically, StringImpl returns 0 for the buffer where createUninitialized()
returns the empty string, which seems reasonable to catch bugs early). UString's method
cannot support UStringImpl's behaviour directly, since it returns an object rather than a
pointer.

  • remove UString::createUninitialized(), replace with calls to UStringImpl::createUninitialized()
  • create a UStringImpl::tryCreateUninitialized() form UStringImpl::createUninitialized(), with current behaviour, make createUninitialized() crash on failure to allocate.
  • make cases in JSC that do not check the result call createUninitialized(), and cases that do check call tryCreateUninitialized().

Rename computedHash() to existingHash(), to bring this in line wih WebCore::StringImpl.

  • API/JSClassRef.cpp:

(OpaqueJSClassContextData::OpaqueJSClassContextData):

(JSC::arrayProtoFuncToString):

  • runtime/Identifier.cpp:

(JSC::CStringTranslator::translate):
(JSC::UCharBufferTranslator::translate):

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):

  • runtime/Lookup.cpp:

(JSC::HashTable::createTable):

  • runtime/Lookup.h:

(JSC::HashTable::entry):

  • runtime/StringBuilder.h:

(JSC::StringBuilder::release):

  • runtime/StringConstructor.cpp:

(JSC::stringFromCharCodeSlowCase):

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):

  • runtime/Structure.cpp:

(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::put):
(JSC::Structure::remove):
(JSC::Structure::insertIntoPropertyMapHashTable):
(JSC::Structure::checkConsistency):

  • runtime/Structure.h:

(JSC::Structure::get):

  • runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTableHash::hash):

  • runtime/UString.cpp:

(JSC::createRep):
(JSC::UString::UString):
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
(JSC::UString::operator=):

  • runtime/UString.h:

(JSC::UString::adopt):
(JSC::IdentifierRepHash::hash):
(JSC::makeString):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::adopt):
(JSC::UStringImpl::create):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):
(JSC::UStringImpl::existingHash):

WebCore: Rubber stamped by Sam Weinig.

Make naming & behaviour of UString[Impl] methods more consistent.
https://bugs.webkit.org/show_bug.cgi?id=33702

WebCore change reflecting UString method name change computedHash() -> existingHash().

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

10:14 PM Changeset in webkit [53319] by Csaba Osztrogonác
  • 2 edits in trunk

[Qt] Defective dependencies caused build failing on QtBuildBot.
https://bugs.webkit.org/show_bug.cgi?id=33693

Reviewed by Eric Seidel.

  • WebKit.pri: CONFIG += depend_includepath added.
9:10 PM Changeset in webkit [53318] by mitz@apple.com
  • 5 edits in trunk/WebCore

<rdar://problem/6020083> -webkit-gradient slows down scrolling when page has horizontal scrollbar
https://bugs.webkit.org/show_bug.cgi?id=19650

Reviewed by Simon Fraser.

  • platform/graphics/GeneratedImage.cpp:

(WebCore::GeneratedImage::drawPattern): Added call to adjustParametersForTiledDrawing(),
letting the generator substitute the parameters with visually-equivalent values that
are more efficient.

  • platform/graphics/Generator.h:

(WebCore::Generator::adjustParametersForTiledDrawing): Added a base class implementation
that does nothing.

  • platform/graphics/Gradient.cpp:

(WebCore::Gradient::adjustParametersForTiledDrawing): Added. If the gradient is a horizontal
or vertical linear gradient, changes to use a 1-pixel tall (or wide) tile.

  • platform/graphics/Gradient.h:
8:56 PM Changeset in webkit [53317] by ukai@chromium.org
  • 5 edits in trunk/WebKitTools

2010-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Update pywebsocket to 0.4.6
https://bugs.webkit.org/show_bug.cgi?id=32299
The newer pywebsocket can handle more simultaneous connections.

  • pywebsocket/mod_pywebsocket/handshake.py:
  • pywebsocket/mod_pywebsocket/standalone.py:
  • pywebsocket/setup.py:
  • pywebsocket/test/test_handshake.py:
8:42 PM Changeset in webkit [53316] by rolandsteiner@chromium.org
  • 49 edits in trunk/LayoutTests

Bug 31865 - Re-do ruby layout tests to use only Latin characters
(https://bugs.webkit.org/show_bug.cgi?id=31865)

Reviewed by David Levin.

New base-lines for the Windows platform.

  • platform/win/fast/ruby/ruby-empty-rt-expected.checksum:
  • platform/win/fast/ruby/ruby-empty-rt-expected.png:
  • platform/win/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/win/fast/ruby/ruby-length-expected.checksum:
  • platform/win/fast/ruby/ruby-length-expected.png:
  • platform/win/fast/ruby/ruby-length-expected.txt:
  • platform/win/fast/ruby/ruby-run-break-expected.checksum:
  • platform/win/fast/ruby/ruby-run-break-expected.png:
  • platform/win/fast/ruby/ruby-run-break-expected.txt:
  • platform/win/fast/ruby/ruby-runs-expected.checksum:
  • platform/win/fast/ruby/ruby-runs-expected.png:
  • platform/win/fast/ruby/ruby-runs-expected.txt:
  • platform/win/fast/ruby/ruby-runs-spans-expected.checksum:
  • platform/win/fast/ruby/ruby-runs-spans-expected.png:
  • platform/win/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/win/fast/ruby/ruby-simple-expected.checksum:
  • platform/win/fast/ruby/ruby-simple-expected.png:
  • platform/win/fast/ruby/ruby-simple-expected.txt:
  • platform/win/fast/ruby/ruby-simple-rp-expected.checksum:
  • platform/win/fast/ruby/ruby-simple-rp-expected.png:
  • platform/win/fast/ruby/ruby-simple-rp-expected.txt:
  • platform/win/fast/ruby/ruby-trailing-expected.checksum:
  • platform/win/fast/ruby/ruby-trailing-expected.png:
  • platform/win/fast/ruby/ruby-trailing-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.checksum:
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.png:
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.checksum:
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.png:
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.checksum:
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.png:
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.checksum:
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.png:
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.png:
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.png:
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.checksum:
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.png:
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.checksum:
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.png:
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt:
8:20 PM Changeset in webkit [53315] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-14 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Laszlo Gombos.

Platform Symbian specific:
Added time-based optimization (-Otime) and increased optimization level to -O3,
conditionally for RVCT compiler (for ARM), for increasing performance
(primarily affecting JavaScript execution).
Default settings are -Ospace and -O2.

No new tests needed because no new funtionality is introduced,
only potential regression on existing tests needs to be evaluated.

  • WebCore.pro:
8:08 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
6:44 PM Changeset in webkit [53314] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-01-14 Marcus Bulach <bulach@chromium.org>

Reviewed by Dimitri Glazkov.

Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier.
https://bugs.webkit.org/show_bug.cgi?id=33648

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):
6:42 PM Changeset in webkit [53313] by jshin@chromium.org
  • 2 edits in trunk/WebCore

2010-01-14 Jungshik Shin <jshin@chromium.org>

Unreviewed, attempted build fix on chromium.

Fix a Chromium build failure due to an unused variable in V8 binding.(part 2)

  • bindings/v8/V8Collection.h: (WebCore::getNamedPropertyOfCollection):
6:35 PM Changeset in webkit [53312] by jshin@chromium.org
  • 2 edits in trunk/WebCore

2010-01-14 Jungshik Shin <jshin@chromium.org>

Unreviewed, attempted build fix on chromium.

Fix a Chromium build failure due to an unused variable in V8 binding.

  • bindings/v8/V8Collection.h: (WebCore::getIndexedPropertyOfCollection):
6:04 PM Changeset in webkit [53311] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, attempted build fix.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::haveDecodedRow):

5:52 PM Changeset in webkit [53310] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

animations/change-keyframes.html failed on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=33370

Increase tolerances. They're still testing the stated goal of the test.

  • animations/change-keyframes.html:
  • transitions/cancel-transition.html:
5:45 PM Changeset in webkit [53309] by pkasting@chromium.org
  • 8 edits in trunk/WebCore

Simplify image decoders by making downsampling functions available at
all times, allowing much duplicated logic to be collapsed.
https://bugs.webkit.org/show_bug.cgi?id=28751

Reviewed by Adam Barth.

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::setData):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::prepareScaleDataIfNecessary):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::ImageDecoder):
(WebCore::ImageDecoder::scaledSize):
(WebCore::ImageDecoder::setMaxNumPixels):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::sizeNowAvailable):
(WebCore::GIFImageDecoder::initFrameBuffer):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::setSize):
(WebCore::JPEGImageDecoder::outputScanlines):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):

5:34 PM Changeset in webkit [53308] by jianli@chromium.org
  • 2 edits in trunk/WebCore

[chromium] Remove obsolete CF related files from gyp build.
https://bugs.webkit.org/show_bug.cgi?id=33002

Reviewed by Eric Seidel.

  • WebCore.gypi:
5:34 PM Changeset in webkit [53307] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip new test that requires new functionality in
DRT (layoutTestController.setWillSendRequestReturnsNull).

5:31 PM Changeset in webkit [53306] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skipping test that fails intermitently - fix for the test being
worked on; see https://bugs.webkit.org/show_bug.cgi?id=33671.

5:30 PM Changeset in webkit [53305] by pkasting@chromium.org
  • 3 edits in trunk/WebCore

Decoding images to scaled output buffers resulted in garbage for
no-alpha PNGs and CMYK JPEGs.
https://bugs.webkit.org/show_bug.cgi?id=33624

Reviewed by Adam Barth.

No layout test since I don't have access to a platform that scales the
output buffers.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::convertCMYKToRGBA):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable):

5:25 PM Changeset in webkit [53304] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Reviewed by Eric Seidel.

[GTK] Crashes cleaning clipboard contents, with page cache enabled
https://bugs.webkit.org/show_bug.cgi?id=32900

Null-check the focus controller to avoid crashing. Could not find
a way to reproduce this consistently, thus no test.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::clearClipboardContentsCallback):
5:24 PM Changeset in webkit [53303] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2010-01-13 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

LayoutTests/animations/play-state.html and LayoutTests/animations/3d/transform-origin-vs-functions.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=33626

Speculative fixes.

  • animations/3d/transform-origin-vs-functions.html: Remove timeout for notifyDone and start measurement at webkitAnimationStart instead of body onload.
  • animations/play-state-expected.txt:
  • animations/play-state.html: Reduce test time in half, but keep the same tolerance level.
5:22 PM Changeset in webkit [53302] by ojan@chromium.org
  • 7 edits in trunk/LayoutTests

2010-01-13 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

A few more flaky transitions/animations tests
https://bugs.webkit.org/show_bug.cgi?id=33642

Attempt to deflake a few more tests. Some of these are second
attempts. The first attempt made it less flaky, but not 100%.
Also, for a couple tests, make them shorter. They seemed
unnecessarily long.

  • animations/change-one-anim-expected.txt:
  • animations/change-one-anim.html:
  • transitions/cancel-transition.html:
  • transitions/mask-transitions.html:
  • transitions/shorthand-border-transitions-expected.txt:
  • transitions/shorthand-border-transitions.html:
5:17 PM Changeset in webkit [53301] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Oliver Hunt.

Fix an assertion that was causing test crashes. Filed a bug
about the weirdness that causes this assertion (inconsistencies
between DragOperationMove and DragOperationGeneric).

  • dom/Clipboard.cpp:

(WebCore::dragOpFromIEOp):
(WebCore::Clipboard::setDestinationOperation):

5:13 PM Changeset in webkit [53300] by bdakin@apple.com
  • 43 edits in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33498 REGRESSION:
svg/css/circle-in-mask-with-shadow.svg failing pixel tests
-and corresponding-
<rdar://problem/7544176>

Reviewed by Sam Weinig.

This change makes repaintRectInLocalCoordinates return a rect that
is -webkit-svg-shadow-aware.

  • rendering/RenderPath.cpp:

(WebCore::RenderPath::repaintRectInLocalCoordinates):

  • rendering/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::repaintRectInLocalCoordinates):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::repaintRectInLocalCoordinates):

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::inflateForShadow):

  • rendering/style/SVGRenderStyle.h:

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=33498 REGRESSION:
svg/css/circle-in-mask-with-shadow.svg failing pixel tests
-and corresponding-
<rdar://problem/7544176>

Reviewed by Sam Weinig.

All of these tests just needed to be updated because of small
rounding differences.

  • platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/mac/svg/css/arrow-with-shadow-expected.png:
  • platform/mac/svg/css/arrow-with-shadow-expected.txt:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/mac/svg/css/clippath-with-shadow-expected.png:
  • platform/mac/svg/css/composite-shadow-example-expected.checksum:
  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/composite-shadow-example-expected.txt:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.checksum:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/mac/svg/css/css-box-min-width-expected.checksum:
  • platform/mac/svg/css/css-box-min-width-expected.png:
  • platform/mac/svg/css/group-with-shadow-expected.txt:
  • platform/mac/svg/css/mask-with-shadow-expected.txt:
  • platform/mac/svg/css/path-with-shadow-expected.png:
  • platform/mac/svg/css/path-with-shadow-expected.txt:
  • platform/mac/svg/css/shadow-and-opacity-expected.txt:
  • platform/mac/svg/css/shadow-with-large-radius-expected.txt:
  • platform/mac/svg/css/shadow-with-negative-offset-expected.txt:
  • platform/mac/svg/css/stars-with-shadow-expected.checksum:
  • platform/mac/svg/css/stars-with-shadow-expected.png:
  • platform/mac/svg/css/stars-with-shadow-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.checksum:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
5:09 PM Changeset in webkit [53299] by sfalken@apple.com
  • 4 edits in branches/safari-4-branch

Versioning.

4:50 PM Changeset in webkit [53298] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2010-01-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
https://bugs.webkit.org/show_bug.cgi?id=33638

  • Scripts/webkitpy/bugzilla.py:
    • Add Bug.id() to match Attachment.id()
    • Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
    • Add back a missing variable to _validate_setter_email found by the new unit tests!
  • Scripts/webkitpy/commands/queries.py:
    • Add FIXMEs about the commands being confusingly named.
  • Scripts/webkitpy/commands/queries_unittest.py:
    • Update results to reflect the newly restructured mock bug cache.
  • Scripts/webkitpy/commands/queues.py:
    • Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
    • Add a FIXME about eventually sorting the patches into some order.
  • Scripts/webkitpy/commands/queues_unittest.py:
    • Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
  • Scripts/webkitpy/commands/upload_unittest.py:
    • Update results to match the newly restructured mock bug cache.
  • Scripts/webkitpy/mock_bugzillatool.py:
    • Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
    • Add a few more attachments and bug dictionaries for use by the tests.
4:08 PM Changeset in webkit [53297] by zimmermann@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Not reviewed. Fix reviewer.

4:06 PM Changeset in webkit [53296] by bweinstein@apple.com
  • 9 edits in trunk

Drag and Drop source/destination code needs cleanup.
<https://bugs.webkit.org/show_bug.cgi?id=33691>.

Reviewed by Adam Roben.

WebCore:

Cleaned up some Drag and Drop code that deals with getting
source and destination operations, and added some ASSERTS to make
sure we don't get in bad states.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::sourceOperation): Make this return the operation itself.
(WebCore::Clipboard::destinationOperation): Ditto.
(WebCore::Clipboard::setSourceOperation): Add an assert to make sure we're valud.
(WebCore::Clipboard::setDestinationOperation): Ditto.

  • dom/Clipboard.h:
  • page/DragController.cpp:

(WebCore::DragController::tryDHTMLDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag):

WebKit/chromium:

Update to new way of calling sourceOperation.

  • src/DragClientImpl.cpp:

(WebKit::DragClientImpl::startDrag):

WebKit/qt:

Update to new way of calling sourceOperation.

  • WebCoreSupport/DragClientQt.cpp:

(WebCore::DragClientQt::startDrag):

3:38 PM Changeset in webkit [53295] by timothy@apple.com
  • 4 edits in trunk/WebCore

Make the Web Inspector's JavaScript debugger work with isolated worlds.
Console evaluation is not performed in the correct world yet, tracked
by bug http://webkit.org/b/33692.

http://webkit.org/b/33690

Reviewed by Adam Roben.

  • bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::restore): Attach the debugger to
any window shell, not just for the debugger world.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::clearWindowShell): Detach the debugger, and
reattach to all window shells, not just for the debugger world.
(WebCore::ScriptController::initScript): Attach the debugger to
any window shell, not just for the debugger world.
(WebCore::ScriptController::attachDebugger): Changed to loop through
all the window shells and call the new overloaded attachDebugger.
(WebCore::ScriptController::attachDebugger): Added. An overload that
takes a window shell to attach the debugger to. Has most of the
logic from the original attachDebugger.

  • bindings/js/ScriptController.h: Added the new attachDebugger.
3:08 PM Changeset in webkit [53294] by kov@webkit.org
  • 5 edits in trunk/WebKit/gtk

Reviewed by Oliver Hunter.

[GTK] couple fixes for signal emissions, and property notifications
https://bugs.webkit.org/show_bug.cgi?id=33428

Do not emit signals and property notifications for error
pages. The notifications are not really useful for anything, you
can get them back by overriding the error pages, and it avoids a
number of hacks.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::dispatchDidReceiveIcon): (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): (WebKit::FrameLoaderClient::dispatchDidCommitLoad): (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout): (WebKit::FrameLoaderClient::dispatchDidFailLoad):
  • WebCoreSupport/FrameLoaderClientGtk.h:
  • tests/testloading.c: (load_error_status_changed_cb): (test_loading_error):
3:07 PM Changeset in webkit [53293] by Adam Roben
  • 2 edits in trunk

Add missing Radar URLs

3:05 PM Changeset in webkit [53292] by Adam Roben
  • 4 edits
    2 adds in trunk

2010-01-14 Adam Roben <Adam Roben>

Add a test that shows onload still fires if a load of a <script src>
is cancelled by the resource load delegate

Tests for <http://webkit.org/b/33687> window.onload never fires if
page contains a <script src=foo> whose load is cancelled by resource
load delegate returning null from willSendRequest

Reviewed by Dave Hyatt.

  • fast/loader/onload-willSendRequest-null-for-script-expected.txt: Added.
  • fast/loader/onload-willSendRequest-null-for-script.html: Added.
  • platform/qt/Skipped: Added the new test since Qt doesn't have layoutTestController.setWillSendRequestReturnsNull.

2010-01-14 Adam Roben <Adam Roben>

Make Cache::requestResource return 0 if the resource's load fails
immediately

Fixes <http://webkit.org/b/33687> window.onload never fires if page
contains a <script src=foo> whose load is cancelled by resource load
delegate returning null from willSendRequest

Test: fast/loader/onload-willSendRequest-null-for-script.html

Reviewed by Dave Hyatt.

  • loader/Cache.cpp: (WebCore::Cache::requestResource): Moved code to handle immediate load failure out of the "cache is disabled" block so that it will run even when the cache is enabled.
2:35 PM Changeset in webkit [53291] by senorblanco@chromium.org
  • 7 edits
    2 adds in trunk

WebCore: Fix for crash with gradient on table cell. Pass the correct
background object down to
RenderBoxModelObject::paintFillLayerExtended(). This also allowed a
rework of the fix to bug 18445 by passing the correct RenderObject
from RenderBox::paintRootBoxDecorations() down to
RenderBoxModelObject::paintFillLayerExtended().
https://bugs.webkit.org/show_bug.cgi?id=28426

Reviewed by mitz@webkit.org.

Covered by new layout test: LayoutTests/fast/gradients/crash-on-tr.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):

  • rendering/RenderBox.h:

Plumb through the correct background RenderObject.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use the passed-in background RenderObject (if present) when painting background images. Remove the previous fix for bug 18445.

  • rendering/RenderBoxModelObject.h:

Plumb through the correct background RenderObject.

  • rendering/RenderTableCell.cpp:

Pass in the correct backgroundObject to paintFillLayers().

(WebCore::RenderTableCell::paintBackgroundsBehindCell):

LayoutTests: New layout test added to exercise fix for bug
http://bugs.webkit.org/show_bug.cgi?id=28426

Reviewed by mitz@webkit.org.

  • fast/gradients/crash-on-tr-expected.txt: Added.
  • fast/gradients/crash-on-tr.html: Added.
2:07 PM Changeset in webkit [53290] by Nate Chapin
  • 15 edits in trunk

2010-01-14 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Standardize the rest of the v8 bindings on toNative() wherever possible.

https://bugs.webkit.org/show_bug.cgi?id=33677

  • bindings/v8/NPV8Object.cpp: (v8ObjectToNPObject): Special case for converting NPObjects, since there aren't genereated bindings for them.
  • bindings/v8/NPV8Object.h:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8Collection.cpp:
  • bindings/v8/V8Collection.h: (WebCore::toNativeCollection): Special case for converting V8Collections, since there aren't genereated bindings for them.
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8SVGPODTypeWrapper.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:
1:21 PM Changeset in webkit [53289] by eric@webkit.org
  • 6 edits
    4 adds in trunk

2010-01-14 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

Chromium Linux: don't stretch checkboxes
https://bugs.webkit.org/show_bug.cgi?id=28631

  • fast/css/non-standard-checkbox-size.html: Added.
  • platform/mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
  • platform/mac/fast/css/non-standard-checkbox-size-expected.png: Added.
  • platform/mac/fast/css/non-standard-checkbox-size-expected.txt: Added.
  • platform/gtk/Skipped: Skipping this new test so I don't break this bot. Just needs new results.
  • platform/qt/Skipped: ditto
  • platform/win/Skipped: ditto

2010-01-14 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

Chromium Linux: don't stretch checkboxes
https://bugs.webkit.org/show_bug.cgi?id=28631

Make the default size for checkboxes/radio buttons also the maximum
size.

Based on patch by Adam Langley.

Test: fast/css/non-standard-checkbox-size.html

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::center): (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::paintRadio):
1:16 PM Changeset in webkit [53288] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Follow up to <https://bugs.webkit.org/show_bug.cgi?id=33635>.

Reviewed by Adam Roben.

Now that dropEffect and effectAllowed are guaranteed to not be
null, change null checks into asserts to make sure we are returning
a proper DragOperation value.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::sourceOperation): Change null check to assert.
(WebCore::Clipboard::destinationOperation): Ditto.

12:47 PM Changeset in webkit [53287] by bweinstein@apple.com
  • 10 edits
    4 adds in trunk

[DnD] effectAllowed and dropEffect can be set to bogus values.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33635>.

Reviewed by Oliver Hunt.

WebCore:

Test to make aure dropEffect and effectAllowed are being set to valid values
when they are being set (list of valid values given by HTML5 specification).

Also, drive by change to initialize dropEffect to none (as described in spec).

Test: fast/events/bogus-dropEffect-effectAllowed.html

  • dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard): Initialize m_dropEffect to "none".
(WebCore::Clipboard::setDropEffect): Check if dropEffect is being set to a valid value.
(WebCore::Clipboard::setEffectAllowed): Check if effectAllowed is being set to a valid value.

LayoutTests:

Added a test to check the handling of setting effectAllowed and
dropEffect to bogus values (that it gets ignored), and updated results
to drag-and-drop because it uses a dummy value.

Also, fixed a few tests that broke when the default dropEffect was set to
none to match the spec.

  • fast/events/bogus-dropEffect-effectAllowed-expected.txt: Added.
  • fast/events/bogus-dropEffect-effectAllowed.html: Added.
  • platform/gtk/fast/events/bogus-dropEffect-effectAllowed-expected.txt: Added.
  • platform/qt/fast/events/bogus-dropEffect-effectAllowed.html: Added.
  • fast/events/drag-and-drop-expected.txt:
  • fast/events/drag-and-drop.html:
  • editing/pasteboard/script-tests/files-during-page-drags.js:
  • editing/pasteboard/get-data-text-plain-drop.html:
  • fast/events/resources/drag-in-frames-right.html:
  • http/tests/local/resources/send-dragged-file.js:
  • http/tests/misc/bubble-drag-events.html:
12:39 PM Changeset in webkit [53286] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add new test from r53277 to the GTK+ Skipped list

  • platform/gtk/Skipped:
12:13 PM Changeset in webkit [53285] by eric@webkit.org
  • 5 edits in trunk

2010-01-14 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Infinite recursion in RuntimeObjectImp::getOwnPropertyNames()
https://bugs.webkit.org/show_bug.cgi?id=33371

Test that Object.keys works on a plugin object.

  • plugins/netscape-enumerate.html:

2010-01-14 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Infinite recursion in RuntimeObjectImp::getOwnPropertyNames()
https://bugs.webkit.org/show_bug.cgi?id=33371

RuntimeObjectImp should not reimplement getPropertyNames();
move the implementation to getOwnPropertyNames().

  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getOwnPropertyNames):
  • bridge/runtime_object.h:
11:57 AM Changeset in webkit [53284] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-14 Kwang Yul Seo <skyul@company100.net>

Reviewed by Alexey Proskuryakov.

Add ENABLE(XSLT) guard to TransformSourceLibxslt.cpp
https://bugs.webkit.org/show_bug.cgi?id=33665

TransformSource is available only when ENABLE(XSLT) guard is true.

  • dom/TransformSourceLibxslt.cpp:
11:52 AM Changeset in webkit [53283] by Adam Roben
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix ChangeLog order from r53277

11:52 AM Changeset in webkit [53282] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add new tests from r53277 to the Qt Skipped list

  • platform/qt/Skipped:
11:47 AM Changeset in webkit [53281] by tonikitoo@webkit.org
  • 6 edits in trunk

[Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33617

Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-01-13
Reviewed by Kenneth Christiansen.

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setUserStyleSheetLocation):
(LayoutTestController::setUserStyleSheetEnabled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

  • platform/qt/Skipped:
11:44 AM Changeset in webkit [53280] by sfalken@apple.com
  • 7 edits in tags/Safari-6531.22.1/WebCore

Merge r53273.

11:38 AM Changeset in webkit [53279] by sfalken@apple.com
  • 7 edits in branches/safari-4-branch/WebCore

Merge r53273.

11:32 AM Changeset in webkit [53278] by sfalken@apple.com
  • 1 copy in tags/Safari-6531.22.1

New tag.

11:29 AM Changeset in webkit [53277] by Adam Roben
  • 9 edits
    6 adds in trunk

Treat all synchronous loads equally in FrameLoader::loadSubframe

Only loads of the empty URL or about:blank were being treated as
synchronous loads. But other loads can be synchronous (e.g., when we
receive a null ResourceRequest from requestFromDelegate or when a
policy decision of "ignore" is made). We now treat those loads the
same way we treated empty URLs and about:blank.

Fixes <rdar://problem/7533333> <http://webkit.org/b/33533>
window.onload never fires if page contains an <iframe> with a bad
scheme or whose load is cancelled by returning null from resource load
delegate's willSendRequest

Tests: fast/loader/onload-bad-scheme-for-frame.html

fast/loader/onload-policy-ignore-for-frame.html
fast/loader/onload-willSendRequest-null-for-frame.html

Reviewed by Brady Eidson.

WebCore:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadSubframe):

  • Detect synchronous loads by checking the subframe's loader's state, rather than by checking its URL
  • Removed unnecessary call to completed(), since checkCompleted() will call completed() if needed (the call to completed() was added first and wasn't removed when the call to checkCompleted() was added in r8316)
  • Added more comments about the strange thing this function does with the subframe's loader

WebKitTools:

Add LayoutTestController API to force
-webView:resource:willSendRequest:: to return null

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController): Initialize new member.
(setWillSendRequestReturnsNullCallback): Call through to
LayoutTestController.
(LayoutTestController::staticFunctions): Added new function.

  • DumpRenderTree/LayoutTestController.h: Added

m_willSendRequestReturnsNull.
(LayoutTestController::willSendRequestReturnsNull):
(LayoutTestController::setWillSendRequestReturnsNull):
Added standard accessors.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::willSendRequest):
Return null if LayoutTestController says to.

LayoutTests:

Add tests that show that onload still fires in various situations with
subframes

  • fast/loader/onload-bad-scheme-for-frame-expected.txt: Added.
  • fast/loader/onload-bad-scheme-for-frame.html: Added.

Tests that onload still fires when a subframe with an unrecognized
scheme is in the page.

  • fast/loader/onload-policy-ignore-for-frame-expected.txt: Added.
  • fast/loader/onload-policy-ignore-for-frame.html: Added.

Tests that onload still fires when the policy delegate says to ignore
the initial load of a subframe.

  • fast/loader/onload-willSendRequest-null-for-frame-expected.txt: Added.
  • fast/loader/onload-willSendRequest-null-for-frame.html: Added.

Tests that onload still fires when the resource load delegate returns
null from willSendRequest for the initial load of a subframe.

  • http/tests/loading/bad-scheme-subframe-expected.txt: Updated result

to show that we now fire onload for the main frame in this case. (This
is essentially the same as onload-bad-scheme-for-frame.html, but it
still seems useful to have that new, more explicit, test.)

11:20 AM Changeset in webkit [53276] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Missing fileSystemPath() method in Qt KURL implementation https://bugs.webkit.org/show_bug.cgi?id=33614

Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-01-14
Reviewed by Kenneth Christiansen.

No new tests.

  • platform/qt/KURLQt.cpp:

(WebCore::KURL::fileSystemPath):

11:10 AM Changeset in webkit [53275] by kevino@webkit.org
  • 4 edits in trunk

wx fixes after XBM removal and recent changes.

11:03 AM Changeset in webkit [53274] by ap@apple.com
  • 8 edits
    2 adds in trunk

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=33652
REGRESSION: Frames stop appearing after browsing for a while

<rdar://problem/7308312> REGRESSION: iBench gets slower after several runs

I do not know how not creating renderers for frames could make iBench slower, but it did.

Test: fast/frames/cached-frame-counter.html

  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): A frame that's cached is moved away from Page, so decrement frame count here. (WebCore::CachedFrame::open): Increase frame count when a frame is restored.
  • history/CachedFrame.h: Remove unneeded forward declarations.
  • history/CachedPage.h: Ditto.
  • history/CachedPage.cpp: (WebCore::CachedPage::restore): Assert that page frame count is zero prior to restoring a page from b/f cache.


  • page/Page.cpp: (WebCore::Page::checkFrameCountConsistency): A debug-only method to check that frame count stored in Page matches the number of frames in frame tree.
  • page/Page.h: (WebCore::Page::decrementFrameCount): Assert that frame count is positive. (WebCore::Page::frameCount): Call checkFrameCountConsistency().
10:56 AM Changeset in webkit [53273] by sfalken@apple.com
  • 7 edits in trunk/WebCore

Windows build fixes.
Add forward declarations and additional includes of windows.h.

  • platform/Cursor.h: Add forward declaration of HCURSOR. Move destructor implementation into cpp.
  • platform/graphics/transforms/TransformationMatrix.h: Add forward declaration of XFORM. Remove windows.h include.
  • platform/graphics/win/TransformationMatrixWin.cpp: Add include of windows.h.
  • platform/win/CursorWin.cpp: Moved destructor of SharedCursor here.

(WebCore::SharedCursor::~SharedCursor): Moved here.

  • platform/win/EventLoopWin.cpp: Add include of windows.h.
  • platform/win/SystemInfo.cpp: Add include of windows.h.
10:47 AM Changeset in webkit [53272] by bweinstein@apple.com
  • 5 edits
    2 deletes in trunk

Roll out r53270 because it broke 5 layout tests.

10:32 AM Changeset in webkit [53271] by Nate Chapin
  • 57 edits in trunk/WebCore

2010-01-14 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Switch the custom V8 bindings to use class toNative() functions.

Refactoring, so no new tests.

  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8AttrCustom.cpp:
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • bindings/v8/custom/V8CoordinatesCustom.cpp:
  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
  • bindings/v8/custom/V8DatabaseCustom.cpp:
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8DocumentLocationCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8GeolocationCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8MessageEventCustom.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8NodeIteratorCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8PopStateEventCustom.cpp:
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionCustom.cpp:
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
  • bindings/v8/custom/V8SVGLengthCustom.cpp:
  • bindings/v8/custom/V8SVGMatrixCustom.cpp:
  • bindings/v8/custom/V8StorageCustom.cpp:
  • bindings/v8/custom/V8StyleSheetListCustom.cpp:
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.h:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
10:23 AM Changeset in webkit [53270] by bweinstein@apple.com
  • 5 edits
    2 adds in trunk

[DnD] effectAllowed and dropEffect can be set to bogus values.
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33635>.

Reviewed by Oliver Hunt.

WebCore:

Test to make aure dropEffect and effectAllowed are being set to valid values
when they are being set (list of valid values given by HTML5 specification).

Also, drive by change to initialize dropEffect to none (as described in spec).

Test: fast/events/bogus-dropEffect-effectAllowed.html

  • dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard): Initialize m_dropEffect to "none".
(WebCore::Clipboard::setDropEffect): Check if dropEffect is being set to a valid value.
(WebCore::Clipboard::setEffectAllowed): Check if effectAllowed is being set to a valid value.

LayoutTests:

Added a test to check the handling of setting effectAllowed and
dropEffect to bogus values (that it gets ignored), and updated results
to drag-and-drop because it uses a dummy value.

  • fast/events/bogus-dropEffect-effectAllowed-expected.txt: Added.
  • fast/events/bogus-dropEffect-effectAllowed.html: Added.
  • fast/events/drag-and-drop-expected.txt:
  • fast/events/drag-and-drop.html:
9:38 AM Changeset in webkit [53269] by eric@webkit.org
  • 4 edits
    1 add in trunk/WebKit/chromium

2010-01-14 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

Introduce WebFileChooserParams to convey parameters for
WebViewClient::runFileChooser(), and add new parameters to it.
https://bugs.webkit.org/show_bug.cgi?id=32473

The new parameters are

  • selected file names
  • "accept" attribute value
  • WebKit.gyp: Add WebFileChooserParams.h
  • public/WebFileChooserParams.h: Added.
  • public/WebViewClient.h: (WebKit::WebViewClient::runFileChooser): Add runFileChooser() with WebFileChooserParams, and mark the old one deprecated.
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runOpenPanel): Call the new runFileChooser() first, then call the old runFileChooser() if the new one failed.
8:09 AM Changeset in webkit [53268] by Adam Roben
  • 2 edits in trunk/LayoutTests

Fix a typo in editing/selection/inactive-selection.html

Fixes <http://webkit.org/b/33676> Exception when opening
editing/selection/inactive-selection.html in a browser

Reviewed by Dan Bernstein.

  • editing/selection/inactive-selection.html: Remove a semicolon that

was making the if (window.layoutTestController) test ineffective.

7:54 AM Changeset in webkit [53267] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

[Qt] Symbian build fixes.

Reviewed by Tor Arne Vestbø.

  • tests/qwebpage/tst_qwebpage.cpp: Include util.h
  • tests/tests.pri: Don't define TESTS_SOURCE_DIR, it doesn't work.
  • tests/util.h: Define TESTS_SOURCE_DIR here, just like it's done in Qt.
6:52 AM Changeset in webkit [53266] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

Add support for partial building on Symbian.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-01-14
Reviewed by Simon Hausmann.

The build happens in the source directory as out of source builds are
not supported by qmake for Symbian.

Also the actual build isn't started but it is left to the developer
to choose the architecture/configuration.

  • Scripts/webkitdirs.pm:
6:44 AM Changeset in webkit [53265] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

Add support for "detecting" Symbian environments by either
looking for the EPOCROOT environment variable or via --symbian
being passed on the commandline.

Reviewed by Kenneth Rohde Christiansen.

  • Scripts/webkitdirs.pm:
6:39 AM CommitterTips edited by Adam Roben
Removed unnecessary brackets (diff)
6:21 AM Changeset in webkit [53264] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2010-01-14 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Add DataObjectGtk, a container for pasteboard and drag-and-drop data.

No new tests, because functionality has not changed.

  • GNUmakefile.am:
  • platform/gtk/DataObjectGtk.cpp: Added. (WebCore::DataObjectGtk::text): (WebCore::DataObjectGtk::markup): (WebCore::DataObjectGtk::setText): (WebCore::DataObjectGtk::setMarkup): (WebCore::DataObjectGtk::files): (WebCore::DataObjectGtk::url): (WebCore::DataObjectGtk::urlLabel): (WebCore::DataObjectGtk::hasURL): (WebCore::DataObjectGtk::clear): (WebCore::DataObjectGtk::forClipboard):
  • platform/gtk/DataObjectGtk.h: Added. (WebCore::DataObjectGtk::create): (WebCore::DataObjectGtk::uriList): (WebCore::DataObjectGtk::image): (WebCore::DataObjectGtk::setRange): (WebCore::DataObjectGtk::setURIList): (WebCore::DataObjectGtk::setImage): (WebCore::DataObjectGtk::setDragContext): (WebCore::DataObjectGtk::hasText): (WebCore::DataObjectGtk::hasMarkup): (WebCore::DataObjectGtk::hasURIList): (WebCore::DataObjectGtk::hasImage): (WebCore::DataObjectGtk::dragContext):

2010-01-14 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Use DataObjectGtk when setting and clearing pasteboard data on
the GDK_SELECTION_PRIMARY clipboard.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::EditorClient):
  • WebCoreSupport/EditorClientGtk.h:
  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::fillSelectionData): (WebKit::targetListForDataObject): (WebKit::getClipboardContentsCallback): (WebKit::clearClipboardContentsCallback): (WebKit::PasteboardHelperGtk::writeClipboardContents):
  • WebCoreSupport/PasteboardHelperGtk.h:
6:07 AM Companies and Organizations that have contributed to WebKit edited by xan@webkit.org
(diff)
6:06 AM Changeset in webkit [53263] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-14 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Scrolling of Timeline Page was broken by fix for bug 33470.
https://bugs.webkit.org/show_bug.cgi?id=33666

  • inspector/front-end/inspector.css:
5:27 AM Companies and Organizations that have contributed to WebKit edited by xan@webkit.org
(diff)
5:19 AM Changeset in webkit [53262] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKitTools

[Qt] Use a different Makefile names for sources generation and compilation.
This prevents Makefile overwriting when running build-webkit twice.

Unreviewed.

  • Scripts/webkitdirs.pm:
5:19 AM Changeset in webkit [53261] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Unreviewed fix of builds with the --no-svg switch.

  • WebCore.pri:
5:18 AM Changeset in webkit [53260] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Unreviewed build fix on Windows.

  • platform/graphics/transforms/TransformationMatrix.h:
4:15 AM Changeset in webkit [53259] by eric@webkit.org
  • 7 edits
    1 add in trunk

2010-01-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable scrolling optimization for pages with embedded widgets

https://bugs.webkit.org/show_bug.cgi?id=33373

Added a basic manual test for scrolling of embedded QWidgets.

  • manual-tests/qt/qtplugin-scrolling.html: Added.
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::setParent):
  • platform/ScrollView.h:
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::invalidateRect):

2010-01-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.

https://bugs.webkit.org/show_bug.cgi?id=33373

  • QtLauncher/main.cpp: (WebPage::createPlugin):
4:11 AM Changeset in webkit [53258] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2010-01-13 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] Failing media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=33015

  • media/video-seek-past-end-playing.html: Removed the last timer of this test.
  • platform/gtk/Skipped: Unskip test above.
4:11 AM Changeset in webkit [53257] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

[Qt] Update Symbian .def symbol export files after private API additions.

Reviewed by Kenneth Rohde Christiansen.

  • symbian/bwins/QtWebKitu.def:
  • symbian/eabi/QtWebKitu.def:
3:56 AM Changeset in webkit [53256] by eric@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-01-14 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Review the tooltip implementation
https://bugs.webkit.org/show_bug.cgi?id=32819

Change the GTK tooltip implementation to avoid the workaround that
we are currently using. Now we use a new private API to set the
text and all the tooltip handling is done in the webview widget.

  • WebCoreSupport/ChromeClientGtk.cpp:
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_set_tooltip_text): Added, new private API. (webkit_web_view_query_tooltip): Added
3:40 AM Changeset in webkit [53255] by Philippe Normand
  • 3 edits in trunk/WebCore

2009-12-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GStreamer] Check return values of gst_element_set_state()
https://bugs.webkit.org/show_bug.cgi?id=30000

Check for state change failure when going from READY/NULL to
PAUSED or PLAYING. Also refactored the common code of play() and
pause() to a new private method of the player.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::changePipelineState): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
3:23 AM Changeset in webkit [53254] by steveblock@google.com
  • 2 edits in trunk

Moves general includes before bindings includes in Android build system.
https://bugs.webkit.org/show_bug.cgi?id=33623

Reviewed by David Levin.

This avoids problems with collisions between WebCore/platform/text/StringBuilder.h
and the new JavaScriptCore/runtime/StringBuilder.h. This change puts
JavaScriptCore/runtime and other bindings includes after the WebCore and other
general includes, so that the WebCore StringBuilder.h is picked up when building
WebCore.

  • Android.mk: Modified.
3:16 AM WikiStart edited by skyul@company100.net
(diff)
2:47 AM Changeset in webkit [53253] by eric@webkit.org
  • 6 edits in trunk

2010-01-14 Eric Seidel <eric@webkit.org>

No review, rolling out r53249.
http://trac.webkit.org/changeset/53249
https://bugs.webkit.org/show_bug.cgi?id=33617

This caused http/tests/security/local-user-CSS-from-
remote.html to fail on the Qt Release Build Bot.

  • platform/qt/Skipped:

2010-01-14 Eric Seidel <eric@webkit.org>

No review, rolling out r53249.
http://trac.webkit.org/changeset/53249
https://bugs.webkit.org/show_bug.cgi?id=33617

This caused http/tests/security/local-user-CSS-from-
remote.html to fail on the Qt Release Build Bot.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
2:39 AM Changeset in webkit [53252] by eric@webkit.org
  • 11 edits
    4 deletes in trunk

2010-01-14 Eric Seidel <eric@webkit.org>

No review, rolling out r53248.
http://trac.webkit.org/changeset/53248
https://bugs.webkit.org/show_bug.cgi?id=32641

Caused 2 tests to crash on various bots:
fast/dom/HTMLSelectElement/listbox-select-reset.html and
fast/forms/listbox-typeahead-scroll.html

  • fast/forms/HTMLOptionElement_selected-expected.txt:
  • fast/forms/HTMLOptionElement_selected.html:
  • fast/forms/HTMLOptionElement_selected2-expected.txt: Removed.
  • fast/forms/HTMLOptionElement_selected2.html: Removed.
  • fast/forms/HTMLOptionElement_selected3-expected.txt: Removed.
  • fast/forms/HTMLOptionElement_selected3.html: Removed.
  • fast/forms/add-remove-option-modification-event-expected.txt:

2010-01-14 Eric Seidel <eric@webkit.org>

No review, rolling out r53248.
http://trac.webkit.org/changeset/53248
https://bugs.webkit.org/show_bug.cgi?id=32641

Caused 2 tests to crash on various bots:
fast/dom/HTMLSelectElement/listbox-select-reset.html and
fast/forms/listbox-typeahead-scroll.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::recalcStyle): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::restoreFormControlState): (WebCore::SelectElement::reset): (WebCore::SelectElement::typeAheadFind):
  • dom/SelectElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected): (WebCore::HTMLOptionElement::insertedIntoTree):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle):
  • html/HTMLSelectElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::recalcStyle):
2:19 AM Changeset in webkit [53251] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-01-14 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Shinichiro Hamaji.

Moved error() from cpp_style.py to checker.py.

https://bugs.webkit.org/show_bug.cgi?id=33620

  • Scripts/check-webkit-style:
    • Addressed FIXME to not set global state.
  • Scripts/webkitpy/style/checker.py:
    • Added argument validation to ProcessorOptions constructor.
    • Added should_report_error() to ProcessorOptions class.
    • Removed set_options().
    • Added StyleChecker class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added unit test class for ProcessorOptions class.
    • Added unit test to check that parse() strips white space.
  • Scripts/webkitpy/style/cpp_style.py:
    • Removed "filter" and "output_format" methods.
    • Removed should_print_error() and error() functions.
    • Removed default parameter value from process_file().
  • Scripts/webkitpy/style/cpp_style_unittest.py:
    • Removed call to cpp_style._should_print_error().
    • Removed test_filter() and test_filter_appending().
  • Scripts/webkitpy/style/text_style.py:
    • Removed default parameter value from process_file().
2:03 AM Changeset in webkit [53250] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-01-14 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

[Android] [Qt] The document.createEvent API does not support touch events.
https://bugs.webkit.org/show_bug.cgi?id=33605

  • fast/events/script-tests/create-touch-event.js: Added. Ensures that document.createEvent("TouchEvent") can create a TouchEvent.
  • fast/events/touch/create-touch-event-expected.txt: Added.
  • fast/events/touch/create-touch-event.html: Added.

2010-01-14 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

[Android] [Qt] The document.createEvent API does not support touch events.
https://bugs.webkit.org/show_bug.cgi?id=33605

Test: fast/events/touch/create-touch-event.html

  • dom/Document.cpp: (WebCore::Document::createEvent): add creation of a TouchEvent when the "TouchEvent" argument is supplied.
1:47 AM Changeset in webkit [53249] by eric@webkit.org
  • 6 edits in trunk

2010-01-14 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33617

  • platform/qt/Skipped:

2010-01-14 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33617

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setUserStyleSheetEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
1:31 AM Changeset in webkit [53248] by eric@webkit.org
  • 11 edits
    4 adds in trunk

2010-01-14 James Robinson <jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

Adds tests for the 'selected' attribute of <option>s
https://bugs.webkit.org/show_bug.cgi?id=32641

HTMLOptionElement_selected2 checks that the selected attribute is up to date immediately after the <select>
parsed. HTMLOptionElement_selected3 does the same, but checks immediately prior to the </select>.

Also changes the expectation for add-remove-option-modification-event to reflect that we now pass.

  • fast/forms/HTMLOptionElement_selected-expected.txt:
  • fast/forms/HTMLOptionElement_selected.html:
  • fast/forms/HTMLOptionElement_selected2-expected.txt: Added.
  • fast/forms/HTMLOptionElement_selected2.html: Added.
  • fast/forms/HTMLOptionElement_selected3-expected.txt: Added.
  • fast/forms/HTMLOptionElement_selected3.html: Added.
  • fast/forms/add-remove-option-modification-event-expected.txt:

2010-01-14 James Robinson <jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

Ensures that the 'selected' attribute of an <option> is correct
https://bugs.webkit.org/show_bug.cgi?id=32641

Adds a check in OptionElement::selected() that checks if list items need to be recalculated and does so if needed,
so the attribute is up to date more often. Also gets rid of most of the recalcStyle() side effects.

Our behavior now matches Firefox 3.5 and IE8 after the </select> is parsed.

Tests: fast/forms/HTMLOptionElement_selected2.html

fast/forms/HTMLOptionElement_selected3.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::setOptionsChangedOnRenderer): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::restoreFormControlState): (WebCore::SelectElement::reset): (WebCore::SelectElement::typeAheadFind):
  • dom/SelectElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected): (WebCore::HTMLOptionElement::insertedIntoTree):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
  • html/HTMLSelectElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::recalcStyle):
1:01 AM Changeset in webkit [53247] by Csaba Osztrogonác
  • 1 edit
    9 adds in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] Add expected files for passing new tests.
Compared to the mac expected files and png files.

  • platform/qt/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt: Added.
  • platform/qt/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
  • platform/qt/svg/custom/marker-opacity-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-content-expected.txt: Added.
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
  • platform/qt/transforms/2d/transform-fixed-container-expected.txt: Added.
12:41 AM Changeset in webkit [53246] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Allow custom memory allocation control for TransparencyLayer class
https://bugs.webkit.org/show_bug.cgi?id=33585

Reviewed by Oliver Hunt.

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

class name - instantiated at: WebCore/'location'
class TransparencyLayer - platform/graphics/qt/GraphicsContextQt.cpp:906

  • platform/graphics/qt/GraphicsContextQt.cpp:
12:34 AM Changeset in webkit [53245] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-01-14 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Oliver Hunt.

[Qt] Allow custom memory allocation control for FontPlatformDataPrivate class
https://bugs.webkit.org/show_bug.cgi?id=

Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
class FontPlatformDataPrivate - platform/graphics/qt/FontPlatformData.h:70

  • platform/graphics/qt/FontPlatformData.h:
12:33 AM Changeset in webkit [53244] by Philippe Normand
  • 3 edits in trunk/WebCore

Reviewed by Xan Lopez.

[GTK] un-needed seeks
https://bugs.webkit.org/show_bug.cgi?id=33532

Avoid un-needed seeks. Don't seek at current playback position and
don't update the rate if it is already set to target value.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setRate):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
12:21 AM Changeset in webkit [53243] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-14 Eric Seidel <eric@webkit.org>

No review. Tiger build fix after http://trac.webkit.org/changeset/53238.

Need to implement WebGLContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=31169

Fix a build break when ENABLE(3D_CANVAS) is disabled.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): UNUSED_PARAM(attrs) when 3D_CANVAS is disabled.

Jan 13, 2010:

11:42 PM Changeset in webkit [53242] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-01-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: use hidden text area for clipboard in order to
workaround windows setData bug.

https://bugs.webkit.org/show_bug.cgi?id=33633

  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._copy):
  • inspector/front-end/inspector.css:
11:35 PM Changeset in webkit [53241] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Mads Ager <ager@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Slow named property lookup on DOMWindow because of missing fast case
https://bugs.webkit.org/show_bug.cgi?id=33584

Add fast case checks to V8 named property getter on DOMWindow
objects. If the property is not in the DOM there is no reason to
search the DOM for all occurrences.

Covered by layout tests.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::namedPropertyGetter):
10:45 PM Changeset in webkit [53240] by barraclough@apple.com
  • 6 edits in trunk/WebCore

<rdar://problem/7403736> REGRESSION (r49963,r49965): 8% Dromaeo Core DOM test regression

Reviewed by Oliver Hunt.

Adding isolated worlds support to the JSC bindings introduced a regression due to
additional map lookups. Add a mechanism to quickly detect that a lookup is for the
'normal' world, and add fast paths to a couple of methods to check the normal world
first.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::Document::getWrapperCache):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::forgetDOMObject):

  • bindings/js/JSDOMBinding.h:

(WebCore::DOMWrapperWorld::isNormal):
(WebCore::WebCoreJSClientData::WebCoreJSClientData):

  • bindings/js/ScriptController.cpp:

(WebCore::IsolatedWorld::IsolatedWorld):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::createWrapperCache):

  • dom/Document.h:
10:37 PM Changeset in webkit [53239] by eric@webkit.org
  • 7 edits in trunk

2010-01-13 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Oliver Hunt.

JSON.stringify and JSON.parse needlessly process properties in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=33053

  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::walk):

2010-01-13 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Oliver Hunt.

JSON.stringify and JSON.parse needlessly process properties in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=33053

Add tests that verify that properties in the prototype chain are ignored.

  • fast/js/JSON-parse-expected.txt:
  • fast/js/JSON-stringify-expected.txt:
  • fast/js/resources/JSON-parse.js:
  • fast/js/resources/JSON-stringify.js:
9:50 PM Changeset in webkit [53238] by eric@webkit.org
  • 25 edits
    1 copy
    6 adds in trunk

2010-01-13 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Need to implement WebGLContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=31169

Added the WebGLContextAttributes class and custom JavaScript
bindings to accept a native object as the second argument to
getContext("experimental-webgl") per the WebGL specification.
Added GraphicsContext3D::Attributes struct to isolate DOM and
graphics layers. Added getContextAttributes() to
WebGLRenderingContext. Added test case ensuring that context
attributes can be passed down and returned. Tested in Safari and
Chromium. The attributes will be hooked up to the creation of the
OpenGL context in bug 33416.

  • fast/canvas/webgl/context-attributes-expected.txt: Added.
  • fast/canvas/webgl/context-attributes.html: Added.
  • fast/canvas/webgl/resources/webgl-test.js: (create3DContext):

2010-01-13 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Need to implement WebGLContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=31169

Added the WebGLContextAttributes class and custom JavaScript
bindings to accept a native object as the second argument to
getContext("experimental-webgl") per the WebGL specification.
Added GraphicsContext3D::Attributes struct to isolate DOM and
graphics layers. Added getContextAttributes() to
WebGLRenderingContext. Added test case ensuring that context
attributes can be passed down and returned. Tested in Safari and
Chromium. The attributes will be hooked up to the creation of the
OpenGL context in bug 33416.

Test: fast/canvas/webgl/context-attributes.html

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/IDLParser.pm:
  • bindings/v8/DOMData.cpp:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext):
  • html/HTMLCanvasElement.h:
  • html/HTMLCanvasElement.idl:
  • html/canvas/CanvasContextAttributes.cpp: Added. (WebCore::CanvasContextAttributes::CanvasContextAttributes): (WebCore::CanvasContextAttributes::~CanvasContextAttributes):
  • html/canvas/CanvasContextAttributes.h: Added.
  • html/canvas/WebGLContextAttributes.cpp: Added. (WebCore::WebGLContextAttributes::create): (WebCore::WebGLContextAttributes::WebGLContextAttributes): (WebCore::WebGLContextAttributes::~WebGLContextAttributes): (WebCore::WebGLContextAttributes::alpha): (WebCore::WebGLContextAttributes::setAlpha): (WebCore::WebGLContextAttributes::depth): (WebCore::WebGLContextAttributes::setDepth): (WebCore::WebGLContextAttributes::stencil): (WebCore::WebGLContextAttributes::setStencil): (WebCore::WebGLContextAttributes::antialias): (WebCore::WebGLContextAttributes::setAntialias): (WebCore::WebGLContextAttributes::premultipliedAlpha): (WebCore::WebGLContextAttributes::setPremultipliedAlpha): (WebCore::WebGLContextAttributes::attributes):
  • html/canvas/WebGLContextAttributes.h: Added.
  • html/canvas/WebGLContextAttributes.idl: Added.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::getContextAttributes):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::getContextAttributes):

2010-01-13 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Need to implement WebGLContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=31169

Added the WebGLContextAttributes class and custom JavaScript
bindings to accept a native object as the second argument to
getContext("experimental-webgl") per the WebGL specification.
Added GraphicsContext3D::Attributes struct to isolate DOM and
graphics layers. Added getContextAttributes() to
WebGLRenderingContext. Added test case ensuring that context
attributes can be passed down and returned. Tested in Safari and
Chromium. The attributes will be hooked up to the creation of the
OpenGL context in bug 33416.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::getContextAttributes):
9:00 PM Changeset in webkit [53237] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-01-13 Simon Fraser <simon.fraser@apple.com>

Fix Windows build.

  • platform/graphics/cg/GraphicsContextCG.cpp:
8:54 PM Changeset in webkit [53236] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2010-01-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Transition followed by animation fails to run the animation sometimes
https://bugs.webkit.org/show_bug.cgi?id=33563

If a transition was closely followed by an animation, it was possible for the cleanup
after the end of the transition to kill the animation.

Fix this by including the keyframes name (or empty string for transitions) in the labels
used to identify CAAnimations on layers.

No test because this was a subtle timing issue that is hard to reproduce in a layout test.

  • platform/graphics/mac/GraphicsLayerCA.h: Some new methods and signature changes.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::animationIdentifier): Pass the keyframes name, since this is included in the identifier string now. (WebCore::moveAllAnimationsForProperty): Pass the keyframes name. (WebCore::GraphicsLayerCA::moveAnimationsForProperty): Try to move both transition- and animation-related CAAnimations, using the list of running animations to get the keyframe names for the latter.

(WebCore::GraphicsLayerCA::ensureStructuralLayer): moveAnimation renamed to moveAnimationsForProperty
and takes the keyframes name.

(WebCore::GraphicsLayerCA::updateLayerAnimations): Pass keyframes name down (or "" for transitions).
(WebCore::GraphicsLayerCA::setAnimationOnLayer): Pass keyframes name down.
(WebCore::GraphicsLayerCA::removeAnimationFromLayer): Pass keyframes name down.
(WebCore::GraphicsLayerCA::pauseAnimationOnLayer): Pass keyframes name down.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Pass keyframes name down.

8:44 PM Changeset in webkit [53235] by simon.fraser@apple.com
  • 3 edits
    6 adds in trunk

2010-01-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Fix shadow drawing to do the correct computations using the base coordinate space
https://bugs.webkit.org/show_bug.cgi?id=33629

Shadows draw using the CGContext base CTM, so we need to convert the shadow offet
and size from user CTM into into base CTM coordinates, via the matix obtained from wkGetUserToBaseCTM().

Test: compositing/shadows/shadow-drawing.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
8:32 PM Changeset in webkit [53234] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update Qt slave result after last SVG commit.

  • platform/qt/svg/css/clippath-with-shadow-expected.txt:
8:09 PM Changeset in webkit [53233] by zimmermann@webkit.org
  • 32 edits in trunk

2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Oliver Hunt.

SVGClipPathElement shouldn't resolve style manually
https://bugs.webkit.org/show_bug.cgi?id=33647

Build renderers for SVGClipPathElement, so we can query the style from the renderer
instead of re-resolving style on every clip path resource invalidation.

  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::createRenderer): (WebCore::SVGClipPathElement::canvasResource):
  • svg/SVGClipPathElement.h: (WebCore::SVGClipPathElement::isValid):
7:47 PM Changeset in webkit [53232] by knorton@google.com
  • 5 edits in trunk/WebCore

2010-01-13 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Web Inspector does not update the DOM tree when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=20162

  • dom/Element.cpp: Moves callbacks to InspectorController directly into setAttribute and removeAttribute and removes the existing call sites. This makes it possible to see attribute modifications. (WebCore::Element::setAttribute): (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent): (WebCore::Element::removeAttribute):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._setAttributesPayload): Clear existing attributes. (WebInspector.DOMAgent.prototype._didApplyDomChange): Updated call site and fixed style. (WebInspector.DOMAgent.prototype._attributesUpdated): Added.
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._attributesUpdated): Added. (WebInspector.ElementsPanel.prototype.updateModifiedNodes): Updated call site.
  • inspector/front-end/ElementsTreeOutline.js: Renamed _updateTitle to updateTitle. (WebInspector.ElementsTreeElement.prototype.onattach): Updated updateTitle call site. (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto. (WebInspector.ElementsTreeElement.prototype._editingCancelled): Ditto.
7:31 PM Changeset in webkit [53231] by zimmermann@webkit.org
  • 2 edits
    18 deletes in trunk/LayoutTests

2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Remove six old tiger specific results, that are equal to the SL baseline now. Update one result, showing a marginal difference between Tiger/SL.
This is a follow-up commit for Dirks strokeBoundingBox() fixes -> should turn Tiger slave green again.

  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.checksum: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.checksum: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.checksum: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.png: Removed.
  • platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Removed.
  • platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.checksum: Removed.
  • platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.png: Removed.
  • platform/mac-tiger/svg/custom/control-points-for-S-and-T-expected.txt: Removed.
  • platform/mac-tiger/svg/text/text-path-01-b-expected.checksum: Removed.
  • platform/mac-tiger/svg/text/text-path-01-b-expected.png: Removed.
  • platform/mac-tiger/svg/text/text-path-01-b-expected.txt: Removed.
7:30 PM Changeset in webkit [53230] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

CounterNode::nextInPreOrderAfterChildren(stayWithin) does not stay within.
https://bugs.webkit.org/show_bug.cgi?id=33625

No new tests because the fix should affect strictly performance.

  • rendering/CounterNode.cpp: (WebCore::CounterNode::nextInPreOrderAfterChildren):
7:05 PM Changeset in webkit [53229] by zimmermann@webkit.org
  • 14 edits
    4 adds in trunk

2010-01-13 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Oliver Hunt.

Window size changes are not propagated down the render tree
https://bugs.webkit.org/show_bug.cgi?id=33643

Test: svg/custom/relative-sized-content.xhtml

  • rendering/RenderSVGContainer.cpp: Fix incorrect markParents=true usage, leading to unnecessary relayouts. (WebCore::RenderSVGContainer::layout): Use new layoutChildren() method. (WebCore::RenderSVGContainer::paint): Fix indention.
  • rendering/RenderSVGHiddenContainer.cpp: Fix incorrect markParents=true usage. (WebCore::RenderSVGHiddenContainer::layout): Use new layoutChildren() helper.
  • rendering/RenderSVGRoot.cpp: Refactor existing code to layout children in SVGRenderSupport::layoutChildren. (WebCore::RenderSVGRoot::layout): Make children relayouting depend on width/height changes, if the outermost svg uses relative viewport sizes.
  • rendering/SVGRenderSupport.cpp: Add central place handling child layout, skips relayouting non-relative sized children as benefit. (WebCore::SVGRenderBase::layoutChildren): This methods contains the actual changes.
  • rendering/SVGRenderSupport.h:
  • svg/SVGGElement.h: Remove dead code.
  • svg/SVGSVGElement.h: Make hasRelativeValues() public to remove the need for friendship declarations.
  • svg/SVGStyledElement.h: Change default return value for hasRelativeValues() to false, as it was intended. (WebCore::SVGStyledElement::hasRelativeValues): Make it public, to be usable from SVGRenderSupport.
  • svg/SVGSymbolElement.h: Remove dead code.
  • svg/SVGUseElement.cpp: Implement hasRelativeValues() - it was simply missing here. (WebCore::SVGUseElement::hasRelativeValues):
  • svg/SVGUseElement.h:
6:57 PM Changeset in webkit [53228] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix CloseBugForLandDiff unittest to actually run
https://bugs.webkit.org/show_bug.cgi?id=33640

  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
6:46 PM Changeset in webkit [53227] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-13 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Enable websocket/tests/workers/worker-simple.html again.

  • platform/mac/Skipped: rm websocket/tests/workers/worker-simple.html
6:23 PM Changeset in webkit [53226] by ukai@chromium.org
  • 2 edits in trunk/WebCore

2010-01-13 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Fix websocket/tests/worker/worker-simple.html crash on Leopard Intel Debug (Tests) builder
https://bugs.webkit.org/show_bug.cgi?id=33581

unref m_workerContext when websocket is disconnected, so that avoid
keeping reference to workerContext longer than worker thread runs.

  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect): (WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion):
5:56 PM Changeset in webkit [53225] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (buildfix).

5:36 PM Changeset in webkit [53224] by ap@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33641
Assertion failure in Lexer.cpp if input stream ends while in string escape

Test: fast/js/end-in-string-escape.html

  • parser/Lexer.cpp: (JSC::Lexer::lex): Bail out quickly on end of stream, not giving the assertion a chance to fire.
5:29 PM Changeset in webkit [53223] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (buildfix).

5:28 PM Changeset in webkit [53222] by simon.fraser@apple.com
  • 6 edits in trunk

2010-01-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

<rdar://problem/7532544>

Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix.

5:20 PM Changeset in webkit [53221] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Rubber stamped by Sam Weinig & Darin Adler.

Three quick fixes to UStringImpl.

  • The destroy() method can be switched back to a normal destructor; since we've switched the way we protect static strings to be using an odd ref-count the destroy() won't abort.
  • The cost() calculation logic was wrong. If you have multiple JSStrings wrapping substrings of a base string, they would each report the full cost of the base string to the heap. Instead we should only be reporting once for the base string.
  • Remove the overloaded new operator calling fastMalloc, replace this with a 'using' to pick up the implementation from the parent class.

(JSC::UStringImpl::~UStringImpl):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::cost):
(JSC::UStringImpl::deref):

5:16 PM Changeset in webkit [53220] by jhoneycutt@apple.com
  • 17 edits
    2 adds in trunk

MSAA: selected, selectable, extended selectable, and multiple
selectable states are not reported

https://bugs.webkit.org/show_bug.cgi?id=33574
<rdar://problem/7536826>

Reviewed by Darin Adler.

WebCore:

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isMultiSelectable):
Use the correct function name - the function name overriden by
and used in AccessiblityRenderObject.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):
Update for function rename.
(webkit_accessible_selection_select_all_selection):
Ditto.

WebKit/chromium:

  • public/WebAccessibilityObject.h:

Update for WebCore::AccessibilityObject function rename.

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::isMultiSelectable):
Ditto.

WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::get_accState):
Remove the call to isMultiSelect(). Call the correctly-named
isMultiSelectable(), and if it returns true, set both the "extended
selectable" and "multiple selectable" states. Check whether the object
is selected or selectable, and report those states.

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getIsSelectableCallback):
Return the result of calling isSelectable().
(getIsMultiSelectableCallback):
Return the result of calling isMultiSelectable().
(AccessibilityUIElement::getJSClass):
Add isSelected and isMultiSelectable properties to the JSClass
definition.

  • DumpRenderTree/AccessibilityUIElement.h:

Declare isSelectable() and isMultiSelectable().

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isSelectable):
Stubbed.
(AccessibilityUIElement::isMultiSelectable):
Stubbed.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isSelectable):
Stubbed.
(AccessibilityUIElement::isMultiSelectable):
Stubbed.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(accessibilityState):
Get the object's state, and return it.
(AccessibilityUIElement::isSelected):
Check the object's selected state.
(AccessibilityUIElement::isSelectable):
Check the object's selectable state.
(AccessibilityUIElement::isMultiSelectable):
Check the object's extended/multiple selectable state.

LayoutTests:

  • accessibility/selection-states-expected.txt: Added.
  • accessibility/selection-states.html: Added.
  • platform/gtk/Skipped:

Add new test to skipped list due to stubbed AccessibilityUIElement
functions.

  • platform/mac/Skipped:

Ditto.

5:14 PM Changeset in webkit [53219] by cmarrin@apple.com
  • 4 edits in trunk/WebKitLibraries

2010-01-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

<rdar://problem/7532544>


Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix. Once more, with feeling. On Windows.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
5:01 PM Changeset in webkit [53218] by darin@apple.com
  • 9 edits in trunk

Move more of the selection and caret painting code from Frame to SelectionController.
https://bugs.webkit.org/show_bug.cgi?id=33619

Reviewed by Dan Bernstein.

WebCore:

Helpful preparation step for a bug fix I am working on.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::SelectionController): Initialize new data members.
Note that m_caretVisible starts as true for the drag caret controller to match the
old behavior for painting.
(WebCore::SelectionController::setSelection): Changed to call selectionLayoutChanged
in its new name and location.
(WebCore::SelectionController::paintCaret): Added checks that were formerly done
at the Frame level. Tweaked formatting and changed to use early return as well.
(WebCore::SelectionController::focusedOrActiveStateChanged): Updated for call
moved into this class.
(WebCore::SelectionController::updateAppearance): Moved the
Frame::selectionLayoutChanged function here. Had to rename it because the word
"layout" is usedfor other purposes in this function.
(WebCore::SelectionController::setCaretVisible): Moved here from Frame.
(WebCore::SelectionController::clearCaretRectIfNeeded): Ditto.
(WebCore::SelectionController::caretBlinkTimerFired): Ditto.

  • editing/SelectionController.h: Added new functions. Moved conditional function

out of class definition for clarity. Removed unneeded == and != operators.
Removed unneeded use of bit fields.

  • page/Frame.cpp: Moved functions to SelectionController.

(WebCore::Frame::Frame): Removed initialization of moved data members.

  • page/Frame.h: Removed things moved to SelectionController as well as unneeded

forward declaration of Timer class template.

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Updated for new location of function.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintCaret): Ditto.

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::inputMethodEvent): Seems possibly wrong to be directly invoking this
setCaretVisible here, but I updated it to call it in its new location.

4:55 PM Changeset in webkit [53217] by abarth@webkit.org
  • 3 edits
    1 copy in trunk/WebKitTools

2010-01-13 Adam Barth <abarth@webkit.org>

Unreviewed. Repeat the below for CloseBugForLandDiff.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/steps/closebugforlanddiff.py:
  • Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
4:49 PM Changeset in webkit [53216] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-13 Adam Barth <abarth@webkit.org>

Unreviewed. Turn the mac-ews status bubbles back on now that this bot
is running again.

  • QueueStatusServer/templates/statusbubble.html:
4:49 PM Changeset in webkit [53215] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
https://bugs.webkit.org/show_bug.cgi?id=33634

Deal with the case of no bug patch object in the state.

  • Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
  • Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
4:20 PM Changeset in webkit [53214] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Cleaning up quota-tracking.html. Removing trailing whitespaces and
fixing the errorFunction() to work correctly with both
transaction() and executeSql().

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33628

  • storage/quota-tracking.html:
4:13 PM Changeset in webkit [53213] by cmarrin@apple.com
  • 3 edits in trunk/WebKitLibraries

2010-01-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

<rdar://problem/7532544>


Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix.


  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
4:08 PM Changeset in webkit [53212] by kbr@google.com
  • 2 edits in trunk/WebKitTools

2010-01-13 Kenneth Russell <kbr@google.com>

Unreviewed; added myself to the committers list.

  • Scripts/webkitpy/committers.py:
4:07 PM Changeset in webkit [53211] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-01-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Fix shadow drawing to do the correct computations using the base coordinate space
https://bugs.webkit.org/show_bug.cgi?id=33629

Step 1: do some renames in setPlatformShadow():

size -> offset
width -> xOffset
height -> yOffset

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
4:05 PM CommitterTips edited by adele@apple.com
(diff)
3:51 PM CommitterTips edited by adele@apple.com
(diff)
3:49 PM CommitterTips edited by eric@webkit.org
Update bugzilla-tool to webkit-patch (diff)
3:38 PM Changeset in webkit [53210] by jorlow@chromium.org
  • 8 edits in trunk

2010-01-13 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492

  • public/WebKitClient.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::createSessionStorageNamespace):
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):

2010-01-13 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492

  • page/Page.cpp: (WebCore::Page::sessionStorage):
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
  • storage/StorageNamespace.h: (WebCore::StorageNamespace::~StorageNamespace):
3:33 PM Changeset in webkit [53209] by simon.fraser@apple.com
  • 5 edits in trunk/WebKitLibraries

2010-01-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

<rdar://problem/7532544>

Expose new method on WebKitSystemInterface, WKGetUserToBaseCTM(), which will
be used for a shadow drawing fix.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
3:31 PM Changeset in webkit [53208] by darin@apple.com
  • 4 edits in trunk/WebKitTools

Ignore compiled Python in more of webkitpy.

  • Scripts/webkitpy/commands: Added property svn:ignore.
  • Scripts/webkitpy/steps: Added property svn:ignore.
  • Scripts/webkitpy/style: Added property svn:ignore.
2:42 PM Changeset in webkit [53207] by krit@webkit.org
  • 29 edits
    4 adds in trunk

2010-01-13 Dirk Schulze <krit@webkit.org>

Reviewed by Beth Dakin.

Repaint bug dragging a star shape with a dash stroke
https://bugs.webkit.org/show_bug.cgi?id=33406

Calculation of repaint rects for RenderPath objects was wrong. We must take the
union of strokeBoundingBox and objectBoundingBox, since the strokeBoundingBox
must not contain the objectBoundingBox. This is mainly visible on dash-arrays for
strokes.

Test: svg/custom/js-repaint-rect-on-path-with-stroke.svg

  • rendering/RenderPath.cpp: (WebCore::RenderPath::strokeBoundingBox):

2010-01-13 Dirk Schulze <krit@webkit.org>

Reviewed by Beth Dakin.

Repaint bug dragging a star shape with a dash stroke
https://bugs.webkit.org/show_bug.cgi?id=33406

Calculation of repaint rects for RenderPath objects was fixed. We take the
union of strokeBoundingBox and objectBoundingBox. Since DRT results depend
on the repaint rect, many results needed an update.
Added a new test, that makes the wrong calculation visible.

  • js-repaint-rect-on-path-with-stroke.svg
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/mac/svg/batik/text/textOnPath-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/verticalText-expected.txt:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/mac/svg/css/composite-shadow-example-expected.txt:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/mac/svg/custom/animate-path-morphing-expected.txt:
  • platform/mac/svg/custom/control-points-for-S-and-T-expected.txt:
  • platform/mac/svg/custom/dasharrayOrigin-expected.txt:
  • platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.checksum: Added.
  • platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
  • platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Added.
  • platform/mac/svg/custom/path-textPath-simulation-expected.txt:
  • platform/mac/svg/text/text-path-01-b-expected.txt:
  • svg/custom/js-repaint-rect-on-path-with-stroke.svg: Added.
2:28 PM Changeset in webkit [53206] by kevino@webkit.org
  • 3 edits in trunk/WebCore

[wx] Build fix. Make the XFORM operator work on wx port.

2:12 PM Changeset in webkit [53205] by pfeldman@chromium.org
  • 8 edits
    1 add in trunk/WebCore

2010-01-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce SourceFrame2 with basic breakpoint / execution line
rendering capabilities.

Contains a drive-by naming fix (lineNumberOffset and lineNumberToOffset were
too close to each other, but were unrelated).

https://bugs.webkit.org/show_bug.cgi?id=33618

2:10 PM Changeset in webkit [53204] by Nate Chapin
  • 6 edits in trunk/WebCore

2010-01-13 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Generate a function in the V8 bindings to convert v8 objects
to native WebCore objects.

  • bindings/scripts/CodeGeneratorV8.pm: Generate and use toNative().
  • bindings/v8/V8Binding.cpp: Remove manually defined conversion helprs. (WebCore::getElementStringAttr): (WebCore::setElementStringAttr):
  • bindings/v8/V8Binding.h: Remove manually defined conversion helprs.
  • bindings/v8/V8SVGPODTypeWrapper.h: Still need a manually defined coversion helper for SVGPODTypes. (WebCore::V8SVGPODTypeWrapper::toNative):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::V8WebGLRenderingContext::getProgramParameterCallback): (WebCore::V8WebGLRenderingContext::getShaderParameterCallback): (WebCore::V8WebGLRenderingContext::getUniformCallback):
1:59 PM Changeset in webkit [53203] by bweinstein@apple.com
  • 5 edits in trunk

WebCore: REGRESSION (r49268): DHTML drag not allowed unless event.dataTransfer.effectAllowed
is set (differs from HTML5).
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33607> and <rdar://7507114>.

Reviewed by Adam Roben.

If no effectAllowed is set in the dragStart operation, we should default to
uninitialized instead of none, so the user doesn't have to manually set the
effectAllowed to enable drag and drop.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard):

LayoutTests: REGRESSION (r49268): DHTML drag not allowed unless event.dataTransfer.effectAllowed
is set (differs from HTML5).
Fixes <https://bugs.webkit.org/show_bug.cgi?id=33607> and <rdar://7507114>.

Reviewed by Adam Roben.

Updated the drag and drop test to test if effectAllowed isn't set, in addition
to its other tests.

  • fast/events/drag-and-drop-expected.txt:
  • fast/events/drag-and-drop.html:
1:35 PM Changeset in webkit [53202] by sfalken@apple.com
  • 8 edits
    3 adds in trunk/WebKit/win

Add additional Geolocation interfaces in WebKit for Windows.

Reviewed by Adam Roben.

  • Interfaces/IWebGeolocationPolicyListener.idl: Added.
  • Interfaces/IWebUIDelegatePrivate.idl: Add decidePolicyForGeolocationRequest to IWebUIDelegatePrivate2.

Append since this version hasn't shipped.

  • Interfaces/WebKit.idl: Add include of IWebGeolocationPolicyListener.idl.
  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::requestGeolocationPermissionForFrame): Call into decidePolicyForGeolocationRequest.

  • WebCoreSupport/WebGeolocationControllerClient.cpp:

(WebGeolocationControllerClient::WebGeolocationControllerClient): Moved *.

  • WebGeolocationPolicyListener.cpp: Added.
  • WebGeolocationPolicyListener.h: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPolicyListener.
  • WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPolicyListener, WebGeolocationPolicyListener.
  • WebView.cpp:

(WebView::setGeolocationProvider): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationProvider): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationDidChangePosition): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationDidFailWithError): Removed extraneous STDMETHODCALLTYPE.

1:27 PM Changeset in webkit [53201] by eric@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

2010-01-13 Dirk Schulze <krit@webkit.org>

Reviewed by Beth Dakin.

This tests don't pass on Leopard but on Snow Leopard with tolereance of 0.
Created Leopard specific pixel test results since they do not fail.

  • platform/mac-leopard/svg/css: Added.
  • platform/mac-leopard/svg/css/composite-shadow-example-expected.checksum: Added.
  • platform/mac-leopard/svg/css/composite-shadow-example-expected.png: Added.
  • platform/mac-leopard/svg/css/group-with-shadow-expected.checksum: Added.
  • platform/mac-leopard/svg/css/group-with-shadow-expected.png: Added.
1:23 PM Changeset in webkit [53200] by hyatt@apple.com
  • 2 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=32495

Reviewed by Dan Bernstein.

font-size:small with background-color causes text to get clipped. Make sure to only paint within the lineTop/lineBottom of
a line for quirky inline flow boxes that didn't contribute to the overall height of the line.

Added fast/backgrounds/quirks-mode-line-boxes-backgrounds.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

1:11 PM Changeset in webkit [53199] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-13 Dirk Schulze <krit@webkit.org>

Reviewed by Beth Dakin.

Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010

This is a follow up. The order of filter and clipping was changes in bug 14010
according to the Spec. Forgot to update this test.

  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.checksum:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
1:09 PM Changeset in webkit [53198] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Refactoring DatabaseAuthorizer to use a CaseFoldingHash function
for the set of whitelisted sqlite functions, and fixing some
indenting issues.

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33612

  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::allowFunction):

  • storage/DatabaseAuthorizer.h:
12:56 PM Changeset in webkit [53197] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-13 Dirk Schulze <krit@webkit.org>

Reviewed by Beth Dakin.

Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738

This is a followup. The way how masks are created changed and caused
some results to update. Forgot to update this one.

  • platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
12:46 PM SVG TODO List - Short notes edited by krit@webkit.org
(diff)
12:40 PM Changeset in webkit [53196] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

RenderObject::nextInPreOrderAfterChildren(RenderObject* stayWithin) does not stay within
https://bugs.webkit.org/show_bug.cgi?id=33600

No new tests as this fix affects mainly performance.
No test has been found yet that could evidence the bug in the layout
of a page, but the fix to bug 32884 exposes this bug on some pages
such as http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/counters-scope-implied-001.htm

  • rendering/RenderObject.cpp: (WebCore::RenderObject::nextInPreOrderAfterChildren):
12:34 PM Changeset in webkit [53195] by kdecker@apple.com
  • 4 edits in trunk/WebKit

https://bugs.webkit.org/show_bug.cgi?id=33610
<rdar://problem/7288546> Silverlight full screen performance problem seen on Snow Leopard.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView _workaroundSilverlightFullScreenBug:]): Added. Work around Silverlight full screen performance issue by maintaining an accelerated GL pixel format. We can safely remove this at some point in the future when both Microsoft releases a genuine fix for 7288546 and enough Silverlight users update to the new Silverlight. For now, we'll distinguish older broken versions of Silverlight by asking the plug-in if it resolved its full screen badness. (-[WebNetscapePluginView _createPlugin]): Call _workaroundSilverlightFullScreenBug:YES if this is Silverlight. (-[WebNetscapePluginView _destroyPlugin]): Call _workaroundSilverlightFullScreenBug:NO if this is Silverlight.

https://bugs.webkit.org/show_bug.cgi?id=33610
<rdar://problem/7288546> Silverlight full screen performance problem seen on Snow Leopard.

  • WebKit.xcodeproj/project.pbxproj: Link the project against OpenGL.
11:18 AM Changeset in webkit [53194] by jorlow@chromium.org
  • 8 edits in trunk

WebCore: No reviewer. More or less a build fix. My 53180 broke some
stuff on the Chromium port so I'm reverting.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-13

  • page/Page.cpp:

(WebCore::Page::sessionStorage):

  • storage/StorageNamespace.cpp:

(WebCore::StorageNamespace::sessionStorageNamespace):

  • storage/StorageNamespace.h:

(WebCore::StorageNamespace::~StorageNamespace):

WebKit/chromium: No reviewer. More or less a build fix. My 53180 broke some
stuff on the Chromium port so I'm reverting.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-13

  • public/WebKitClient.h:
  • public/WebViewClient.h:
  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespace::sessionStorageNamespace):

10:30 AM Changeset in webkit [53193] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Steve Block <steveblock@google.com>

Update appendClassName in jni_runtime.cpp to use WebCore::StringBuilder, rather than JSC::StringBuilder.
https://bugs.webkit.org/show_bug.cgi?id=33586

Avoiding the JSC version of StringBuilder allows this file to be used with both JSC and V8 on Android.

No new tests, refactoring only.

  • bridge/jni/jni_runtime.cpp: Modified. (JavaMethod::signature): Modified. Use WebCore::StringBuilder.
10:14 AM Changeset in webkit [53192] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Timothy Hatcher.

Some objects in the global scope are not completed
https://bugs.webkit.org/show_bug.cgi?id=19119

Use Object.getOwnPropertyNames instead of for-in to provide completions, since
Object.getOwnPropertyNames reports both enumerable and non-enumerable properties.

  • inspector/front-end/InjectedScript.js: (InjectedScript._getPropertyNames): (InjectedScript.getCompletions):
9:03 AM Changeset in webkit [53191] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Ben Murdoch <benm@google.com>

Reviewed by Simon Hausmann.

[Android] [Qt] The JSC ScriptController does not consider Touch Events user gestures.
https://bugs.webkit.org/show_bug.cgi?id=33597

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGestureEvent): Add the touch event types (touchstart, touchmove and touchend) to the set of events that are considered user gestures.
8:49 AM Changeset in webkit [53190] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKitTools

[Qt] Fix build problem related to the pushd command

Reviewed by Simon Hausmann.

  • Scripts/webkitdirs.pm:
8:46 AM Changeset in webkit [53189] by Simon Hausmann
  • 2 edits in trunk/WebCore

Rubber-stamped by Tor Arne Vestbø.

[Qt] REGRESSION(53187) Touchevent related tests fail

https://bugs.webkit.org/show_bug.cgi?id=33602

Pass the ENABLE_TOUCH_EVENTS to the IDL generators.

  • WebCore.pri:
8:31 AM Changeset in webkit [53188] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Timeline panel scrolling speed can be increased.
https://bugs.webkit.org/show_bug.cgi?id=33579

8:06 AM Changeset in webkit [53187] by Simon Hausmann
  • 9 edits
    4 adds in trunk

[Qt] Split the build process in two different .pro files.
This allows qmake to be run once all source files are available.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-01-13
Reviewed by Simon Hausmann.

.:

  • DerivedSources.pro: Added.
  • WebKit.pri:

JavaScriptCore:

  • DerivedSources.pro: Added.
  • JavaScriptCore.pri: Moved source generation to DerivedSources.pro
  • pcre/pcre.pri: Moved source generation to DerivedSources.pro

WebCore:

  • DerivedSources.pro: Added.
  • WebCore.pri: Added. Contains common logic between source generation and compilation.
  • WebCore.pro: Moved source generation to DerivedSources.pro.

WebKitTools:

  • Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
7:55 AM Changeset in webkit [53186] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-01-13 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed tiny typo fix in docstrings.

  • Scripts/webkitpy/style/checker_unittest.py:
7:52 AM Changeset in webkit [53185] by hamaji@chromium.org
  • 5 edits in trunk/WebKitTools

2010-01-13 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Shinichiro Hamaji.

Created a CategoryFilter class to encapsulate the logic of
filter rules.

https://bugs.webkit.org/show_bug.cgi?id=33454

  • Scripts/webkitpy/style/checker.py:
    • Added CategoryFilter class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added CategoryFilter unit tests.
  • Scripts/webkitpy/style/cpp_style.py:
    • Updated filter methods to use CategoryFilter.
  • Scripts/webkitpy/style/cpp_style_unittest.py:
    • Updated references to filters.
7:24 AM Changeset in webkit [53184] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-01-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Scrolling editor to the 20Kth line is not smooth.

https://bugs.webkit.org/show_bug.cgi?id=33587

  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype._highlightChanged): (WebInspector.TextEditor.prototype._paintLinesContinuation):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._highlightInChunks): (WebInspector.TextEditorHighlighter.prototype.updateHighlight): (WebInspector.TextEditorHighlighter.prototype._highlightLines): (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype._setLine): (WebInspector.TextEditorModel.prototype.setAttribute): (WebInspector.TextEditorModel.prototype.getAttribute): (WebInspector.TextEditorModel.prototype.removeAttribute):
5:49 AM Changeset in webkit [53183] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] Fix the build on Windows.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-01-13
Reviewed by Simon Hausmann.

PluginViewWin.cpp requires the conversion operator from TransformationMatrix to XFORM.

  • WebCore.pro: Build TransformationMatrixWin.cpp.
  • platform/graphics/transforms/TransformationMatrix.h: Enable the conversion operator to XFORM.
2:31 AM QtWebKitTableOfFeatures46 edited by Henry Haverinen
(diff)
2:27 AM QtWebKitTableOfFeatures46 created by Henry Haverinen
2:12 AM QtWebKitFeatures46 edited by Henry Haverinen
(diff)
1:23 AM Changeset in webkit [53182] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-13 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Add websocket/tests/workers/worker-simple.html, because it starts
crash after r53174

  • platform/mac/Skipped: Add websocket/tests/workers/worker-simple.html
1:18 AM Changeset in webkit [53181] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt/Symbian] Added missing vendor information to qtwebkit.sis

Patch by Miikka Heikkinen <miikka.heikkinen@digia.com> on 2010-01-13
Reviewed by Simon Hausmann.

This information is necessary to Symbian sign the package.

http://bugreports.qt.nokia.com/browse/QTBUG-7290

  • WebCore.pro:

Jan 12, 2010:

10:51 PM Changeset in webkit [53180] by jorlow@chromium.org
  • 8 edits in trunk

2010-01-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492

  • public/WebKitClient.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::getSessionStorageNamespace):
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):

2010-01-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=33492

  • page/Page.cpp: (WebCore::Page::sessionStorage):
  • storage/StorageNamespace.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
  • storage/StorageNamespace.h: (WebCore::StorageNamespace::~StorageNamespace):
10:12 PM Changeset in webkit [53179] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed. Now I can review :)

  • Scripts/webkitpy/committers.py:
9:23 PM WebKit Team edited by hamaji@chromium.org
(diff)
7:33 PM Changeset in webkit [53178] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/7512726> Flash full-screen does not work correctly with Flash 10.1 beta

Reviewed by Darin Adler.

Explicitly track when the plug-in shows and hides a full-screen window to determine
whether a plug-in is currently full-screen, rather than relying on menu bar visibility.
This ensures that we activate the plug-in host process and client application as
appropriate when the plug-in enters or exits full-screen.

  • Plugins/Hosted/NetscapePluginHostProxy.h:

(WebKit::NetscapePluginHostProxy::isFullScreenWindowShowing):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::setMenuBarVisible):
(WebKit::NetscapePluginHostProxy::didEnterFullScreen):
(WebKit::NetscapePluginHostProxy::didExitFullScreen):
(WebKit::NetscapePluginHostProxy::setFullScreenWindowIsShowing):
(WKPCSetMenuBarVisible):
(WKPCSetFullScreenWindowIsShowing):

  • Plugins/Hosted/WebKitPluginClient.defs:
7:29 PM Changeset in webkit [53177] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Adding a list of whitelisted sqlite functions that users are
allowed to use.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33549

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::authorizerFunction):

  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
(WebCore::DatabaseAuthorizer::addWhitelistedFunctions):
(WebCore::DatabaseAuthorizer::allowFunction):

  • storage/DatabaseAuthorizer.h:
6:48 PM Changeset in webkit [53176] by ukai@chromium.org
  • 2 edits
    1 move in trunk/WebCore

2010-01-12 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Simon Hausmann.

[Qt][WebSocket] SocketStreamHandleSoup.cpp is misnamed
https://bugs.webkit.org/show_bug.cgi?id=33077

  • WebCore.pro:
  • platform/network/qt/SocketStreamHandleQt.cpp: Copied from WebCore/platform/network/qt/SocketStreamHandleSoup.cpp.
  • platform/network/qt/SocketStreamHandleSoup.cpp: Removed.
6:33 PM Changeset in webkit [53175] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/rendering/RenderLayer.cpp

Build Fix.

6:09 PM Changeset in webkit [53174] by ukai@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-01-12 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

Add a test of WebSockets for shared workers
https://bugs.webkit.org/show_bug.cgi?id=33285

  • websocket/tests/workers/resources/worker-simple.js:
  • websocket/tests/workers/shared-worker-simple-expected.txt: Added.
  • websocket/tests/workers/shared-worker-simple.html: Added.
6:08 PM Changeset in webkit [53173] by simon.fraser@apple.com
  • 4 edits
    4 adds in trunk

2010-01-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

position:fixed and transform on same element breaks fixed behavior
https://bugs.webkit.org/show_bug.cgi?id=31283

Fix interactions of transforms and fixed positioning, namely that fixed position
elements with a transformed ancestor are positioned relative to that ancestor,
and an element with both a transform and fixed position respects that positioning.

Test: transforms/2d/transform-fixed-container.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint): Transforms should not unconditionally stop the propagation of the 'fixed' flag to ancestors, but only if the transformed element is not itself fixed.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::convertToLayerCoords): Fix this method to behave correctly for fixed position layers whose container is not the root, but some other (probably transformed) ancestor. In that case, we can fall into the "position: absolute" code path.
6:04 PM Changeset in webkit [53172] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Replacing RANDOMBLOB with ZEROBLOB, as RANDOMBLOB will soon be
disallowed by the authorizer.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=33396

  • storage/quota-tracking.html:
5:29 PM Changeset in webkit [53171] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

Fix an assert being triggered by how the Chromium port sets the
replacing flag for error pages. This was caused by r53143.

Covered by existing Chromium UI tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
4:58 PM Changeset in webkit [53170] by eric@webkit.org
  • 48 edits
    3 adds in trunk

2010-01-12 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242

Add an extra argument to getPropertyNames() and getOwnPropertyNames()
(and all reimplementations thereof) that indicates whether non-enumerable
properties should be added.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertyNames):
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::getOwnPropertyNames):
  • debugger/DebuggerActivation.h:
  • runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertyNames):
  • runtime/Arguments.h:
  • runtime/CommonIdentifiers.h:
  • runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertyNames):
  • runtime/JSArray.h:
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::getOwnPropertyNames):
  • runtime/JSByteArray.h:
  • runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertyNames):
  • runtime/JSFunction.h:
  • runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::getOwnPropertyNames):
  • runtime/JSNotAnObject.h:
  • runtime/JSObject.cpp: (JSC::getClassPropertyNames): (JSC::JSObject::getPropertyNames): (JSC::JSObject::getOwnPropertyNames):
  • runtime/JSObject.h:
  • runtime/JSVariableObject.cpp: (JSC::JSVariableObject::getOwnPropertyNames):
  • runtime/JSVariableObject.h:
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyNames):
  • runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::getOwnPropertyNames):
  • runtime/StringObject.cpp: (JSC::StringObject::getOwnPropertyNames):
  • runtime/StringObject.h:
  • runtime/Structure.cpp: Rename getEnumerablePropertyNames() to getPropertyNames(), which takes an extra argument. (JSC::Structure::getPropertyNames):
  • runtime/Structure.h: (JSC::):

2010-01-12 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242

Add new argument to the reimplementation of getOwnPropertyNames().

  • UserObjectImp.cpp: (UserObjectImp::getOwnPropertyNames):
  • UserObjectImp.h:

2010-01-12 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242

Add tests for Object.getOwnPropertyNames(o), both standard usage and cross origin.

  • fast/js/Object-getOwnPropertyNames-expected.txt: Added.
  • fast/js/Object-getOwnPropertyNames.html: Added.
  • fast/js/script-tests/Object-getOwnPropertyNames.js: Added.
  • http/tests/security/cross-frame-access-enumeration-expected.txt:
  • http/tests/security/cross-frame-access-enumeration.html:

2010-01-12 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

[ES5] Implement Object.getOwnPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=32242

Add new argument to reimplementations of getPropertyNames()
and getOwnPropertyNames(), and update the JS bindings generator.

Test: fast/js/Object-getOwnPropertyNames.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyNames): (WebCore::JSDOMWindow::getOwnPropertyNames):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::getPropertyNames): (WebCore::JSDOMWindowShell::getOwnPropertyNames):
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getOwnPropertyNames):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getOwnPropertyNames):
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::getPropertyNames): (WebCore::JSQuarantinedObjectWrapper::getOwnPropertyNames):
  • bindings/js/JSQuarantinedObjectWrapper.h:
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getOwnPropertyNames):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertyNames):
  • bridge/runtime_array.h:
  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getPropertyNames): (JSC::RuntimeObjectImp::getOwnPropertyNames):
  • bridge/runtime_object.h:
4:16 PM Changeset in webkit [53169] by bweinstein@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Add correct expected results after r53168 for GTK and Qt.

  • platform/gtk/fast/block: Added.
  • platform/gtk/fast/block/positioning: Added.
  • platform/gtk/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
  • platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
3:39 PM Changeset in webkit [53168] by bweinstein@apple.com
  • 6 edits
    2 adds in trunk

Safari shows an unneeded horizontal scrollbar on many websites.
Fixes <rdar://6321041> and <http://webkit.org/b/33555>.

Reviewed by Dave Hyatt.

WebCore:

If a div has no children, and its height or width are 0, we can ignore
it in our calculation of lowest, rightmost, and leftmost positions. This
calculation was causing horizontal scrollbars to be drawn when they weren't needed.

Test: fast/block/positioning/absolute-positioning-no-scrollbar.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lowestPosition): Added check for no children and width or height 0.
(WebCore::RenderBlock::rightmostPosition): Ditto.
(WebCore::RenderBlock::leftmostPosition): Ditto.

LayoutTests:

Added a test that shows no scrollbar in the case where a div has no children
and either a width or height of 0. Also updated results for a few tests which
this patch causes progressions for.

  • fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt: Added.
  • fast/block/positioning/absolute-positioning-no-scrollbar.html: Added.
  • fast/block/positioning/fixed-positioning-scrollbar-bug.html:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
3:34 PM Changeset in webkit [53167] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Optimize WebInspector.TimelineGrid.prototype.updateDividers()

DOM element property access and modification are slow and should be done as lazily as possible.
https://bugs.webkit.org/show_bug.cgi?id=33536

  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.prototype._setDividerAndBarLeft):
3:10 PM Changeset in webkit [53166] by bdakin@apple.com
  • 3 edits
    4 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION: -
webkit-svg-shadow with opacity still over-clipped

Reviewed by Sam Weinig.

We need to call inflateForShadow() on the repaintRect before we
clip for opacity or we will over-clip.

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=33550 REGRESSION:
-webkit-svg-shadow with opacity still over-clipped

Reviewed by Sam Weinig.

  • platform/mac/svg/css/shadow-and-opacity-expected.checksum: Added.
  • platform/mac/svg/css/shadow-and-opacity-expected.png: Added.
  • platform/mac/svg/css/shadow-and-opacity-expected.txt: Added.
  • svg/css/shadow-and-opacity.svg: Added.
2:48 PM Changeset in webkit [53165] by sfalken@apple.com
  • 12 edits
    6 adds in trunk

WebCore: Update all-in-one derived sources for Geolocation.

Reviewed by Sam Weinig.

  • DerivedSources.cpp: Add JSCoordinates.cpp, JSGeolocation.cpp, JSGeoposition.cpp, JSPositionError.cpp

WebKit/win: Add Geolocation interfaces in WebKit for Windows.

Reviewed by Adam Roben, Sam Weinig.

  • ForEachCoClass.h: Added WebGeolocationPosition.
  • Interfaces/IWebError.idl:
  • Interfaces/IWebGeolocationPosition.idl: Added.
  • Interfaces/IWebGeolocationProvider.idl: Added.
  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebGeolocationControllerClient.cpp: Added.

(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):

  • WebCoreSupport/WebGeolocationControllerClient.h: Added.
  • WebGeolocationPosition.cpp: Added IWebGeolocationPosition implementation.
  • WebGeolocationPosition.h: Added IWebGeolocationPosition implementation.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPosition.idl, IWebGeolocationProvider.idl,

relocated JavaScriptCoreAPITypes.idl, WebScrollbarTypes.idl

  • WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPosition.h/.cpp, WebGeolocationControllerClient.h/cpp,
  • WebKitClassFactory.cpp: Add WebGeolocationPosition include.
  • WebView.cpp:

(WebView::initWithFrame): Create WebGeolocationControllerClient if Geolocation is enabled.
(WebView::setGeolocationProvider): Added Geolocation-specific method.
(WebView::geolocationProvider): Added Geolocation-specific method.
(WebView::geolocationDidChangePosition): Added Geolocation-specific method.
(WebView::geolocationDidFailWithError): Added Geolocation-specific method.

  • WebView.h: Added setGeolocationProvider, geolocationProvider, geolocationDidChangePosition, geolocationDidFailWithError.
2:12 PM Changeset in webkit [53164] by Nate Chapin
  • 31 edits in trunk/WebCore

2010-01-12 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Remove static const ints from V8CustomBinding.h

https://bugs.webkit.org/show_bug.cgi?id=33547

  • bindings/scripts/CodeGeneratorV8.pm: Generate and use custom

internal field indices from lists of custom internal fields.

  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/NPV8Object.h:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: Remove a bunch of now unnecessary

manually calls to setInternalFieldCount().

  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8Index.h:
  • bindings/v8/V8IsolatedContext.cpp:
  • bindings/v8/V8IsolatedContext.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h: Remove the static const ints.
  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
2:07 PM Changeset in webkit [53163] by jhoneycutt@apple.com
  • 3 edits
    2 adds in trunk

MSAA: Accessibility role of <select multiple> elements is wrong

https://bugs.webkit.org/show_bug.cgi?id=33522

Reviewed by Darin Adler.

WebKit/win:

  • AccessibleBase.cpp:

(MSAARole):
Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA
"list" and "list item" roles.

LayoutTests:

  • platform/win/accessibility/multiple-select-element-role-expected.txt: Added.
  • platform/win/accessibility/multiple-select-element-role.html: Added.
1:59 PM Changeset in webkit [53162] by darin@chromium.org
  • 2 edits in trunk/WebCore

2010-01-12 Darin Fisher <darin@chromium.org>

Fixing chromium build bustage.

  • bindings/v8/custom/V8PopStateEventCustom.cpp: Add V8Proxy.h include.
1:28 PM Changeset in webkit [53161] by darin@chromium.org
  • 7 edits
    1 add in trunk/WebCore

2010-01-12 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Add V8 bindings for PopStateEvent.
https://bugs.webkit.org/show_bug.cgi?id=33546


This is covered by existing tests for PopStateEvent.

  • WebCore.gypi:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventToV8Object):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8PopStateEventCustom.cpp: Added. (WebCore::V8PopStateEvent::initPopStateEventCallback): (WebCore::V8PopStateEvent::stateAccessorGetter):
1:25 PM Changeset in webkit [53160] by knorton@google.com
  • 7 edits in trunk

2010-01-12 Kelly Norton <knorton@google.com>

Reviewed by Timothy Hatcher.

Adds source length to ParseHTMLRecords in the inspector timeline.
https://bugs.webkit.org/show_bug.cgi?id=33548

Test: inspector/timeline-parse-html.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::willWriteHTML):
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createParseHTMLRecord):
  • inspector/TimelineRecordFactory.h:
1:15 PM Changeset in webkit [53159] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=31597

Make ICU's text breakiterator and string search use Chrome's UI
language instead of 'en-US' or the OS UI language.

As long as the webkit layout tests are run in en-US locale, there'd be
no visible change.

  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: (UILanguage): (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
1:05 PM Changeset in webkit [53158] by bdakin@apple.com
  • 5 edits in trunk/LayoutTests

Updated results for these tests which just have rounding errors.

Reviewed by Nikolas Zimmermann.

  • platform/mac/svg/css/composite-shadow-example-expected.checksum:
  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/mask-with-shadow-expected.checksum:
  • platform/mac/svg/css/mask-with-shadow-expected.png:
12:54 PM Changeset in webkit [53157] by bdakin@apple.com
  • 29 edits in trunk

WebCore: Rubber-stamped by Dave Hyatt.

This patch changes the name of -webkit-shadow to -webkit-svg-shadow
to avoid giving a custom property an overly-general name.
<rdar://problem/7534590>

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShadow):

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applySVGProperty):

LayoutTests: This patch changes the name of -webkit-shadow to -webkit-svg-shadow
to avoid giving a custom property an overly-general name.
<rdar://problem/7534590>

  • fast/repaint/moving-shadow-on-container.html:
  • fast/repaint/moving-shadow-on-path.html:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/arrow-with-shadow.svg:
  • svg/css/circle-in-mask-with-shadow.svg:
  • svg/css/clippath-with-shadow.svg:
  • svg/css/composite-shadow-example.html:
  • svg/css/composite-shadow-with-opacity.html:
  • svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/group-with-shadow.svg:
  • svg/css/mask-with-shadow.svg:
  • svg/css/path-with-shadow.svg:
  • svg/css/shadow-with-large-radius.svg:
  • svg/css/shadow-with-negative-offset.svg:
  • svg/css/stars-with-shadow.html:
  • svg/filters/shadow-on-filter.svg:
  • svg/filters/shadow-on-rect-with-filter.svg:
12:49 PM Changeset in webkit [53156] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

  • WebCore.vcproj/WebCore.vcproj:
12:44 PM Changeset in webkit [53155] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-01-12 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Add a null check in case of an event handler with invalid syntax.

Should make fast/js/invalid-syntax--for-function.html not crash in
Chromium's test shell.

  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::callListenerFunction): Check the listener object before using it.
12:34 PM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:32 PM Changeset in webkit [53154] by bfulgham@webkit.org
  • 4 edits in trunk/WebKitTools

Extend WinLauncher example with better printing features.

Reviewed by Darin Adler.

  • WinLauncher/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly

larger margins.

(PrintWebUIDelegate::webViewHeaderHeight): Compute header height based

on text metrics.

(PrintWebUIDelegate::webViewFooterHeight): Compute footer height based

on text metrics.

(PrintWebUIDelegate::drawHeaderInRect): Write useful header, along

with separating line.

(PrintWebUIDelegate::drawFooterInRect):

  • WinLauncher/PrintWebUIDelegate.h: Remove stubs.
  • WinLauncher/WinLauncher.cpp:

(PrintView): Correct loop used to print individual pages.

Previously it started at 0, which is a wild-card to print all
pages at once.

11:59 AM Changeset in webkit [53153] by eric.carlson@apple.com
  • 4 edits in trunk/LayoutTests

2010-01-12 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Add media/video-poster-scale.html to GTK skipped list, it needs platform specific
results (https://bugs.webkit.org/show_bug.cgi?id=33541). Fix test results on
OSX and Windows.

  • media/video-poster-scale-expected.txt:
  • media/video-poster-scale.html:
  • platform/gtk/Skipped:
11:52 AM Changeset in webkit [53152] by pkasting@chromium.org
  • 6 edits
    1 delete in trunk/WebCore

Remove XBM support from the open-source image decoders.
https://bugs.webkit.org/show_bug.cgi?id=27823

Reviewed by Dimitri Glazkov.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

  • platform/image-decoders/xbm: Removed.
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: Removed.
  • platform/image-decoders/xbm/XBMImageDecoder.h: Removed.
11:42 AM Changeset in webkit [53151] by ap@apple.com
  • 14 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33540
Make it possible to build in debug mode with assertions disabled

11:41 AM Changeset in webkit [53150] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2010-01-12 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Update test and results after r53146.

  • http/tests/security/local-video-poster-from-remote-expected.txt:
  • http/tests/security/local-video-poster-from-remote.html:
11:33 AM Changeset in webkit [53149] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-01-12 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Gustavo Noronha Silva.

[GTK] Failing media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=33015

  • platform/gtk/Skipped: Skipping the test again, we need to kill its last timer.
10:50 AM Changeset in webkit [53148] by yong.li@torchmobile.com
  • 4 edits in trunk

2009-11-23 Yong Li <yoli@rim.com>

Reviewed by Adam Treat.

Make GIF decoder support down-sampling
https://bugs.webkit.org/show_bug.cgi?id=31806

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::upperBoundScaledY): (WebCore::ImageDecoder::lowerBoundScaledY):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::scaledRect): (WebCore::RGBA32Buffer::setScaledRect): (WebCore::ImageDecoder::scaledSize):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::sizeNowAvailable): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::copyOnePixel): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
10:33 AM Changeset in webkit [53147] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Reviewed by Eric Carlson.

[GTK] Failing media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=33015

Listen on timeupdate event instead of waiting a fixed amount of
time, which is prone to test flackyness.

  • media/audio-mpeg-supported.html:
  • media/video-seek-past-end-playing.html:
  • platform/gtk/Skipped:
10:23 AM Changeset in webkit [53146] by eric.carlson@apple.com
  • 20 edits
    2 adds in trunk

2010-01-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler and Simon Fraser.

rdar://problem/5684062
https://bugs.webkit.org/show_bug.cgi?id=23094
Flash of white when switching from poster image to video playback


https://bugs.webkit.org/show_bug.cgi?id=23140
<video> poster should scale like a video frame

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Only call updatePosterImage from one place
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): m_shouldShowPosterImage -> m_shouldDisplayPoster. (WebCore::HTMLVideoElement::createRenderer): Always create a RenderVideo. (WebCore::HTMLVideoElement::attach): Call updatePosterImage before checking to see if we

should display the poster image. renderer() is never a RenderImage, don't need to check.
m_shouldShowPosterImage -> m_shouldDisplayPoster.

(WebCore::HTMLVideoElement::detach): m_shouldShowPosterImage -> m_shouldDisplayPoster.
(WebCore::HTMLVideoElement::parseMappedAttribute): Cache poster attribute when it is set since

it is checked frequently. m_shouldShowPosterImage -> m_shouldDisplayPoster.

(WebCore::HTMLVideoElement::updatePosterImage): Don't bother looking at the network state,

display the poster as long as the attribute is valid and the media engine says it hasn't
rendered a video frame. m_shouldShowPosterImage -> m_shouldDisplayPoster.

(WebCore::HTMLVideoElement::hasAvailableVideoFrame): New, ask the media engine if a video frame

is available to render.

  • html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::poster): (WebCore::HTMLVideoElement::shouldDisplayPoster):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateRenderer): Call setCachedImage for render video too.
  • manual-tests/video-player.html: Remove bit-rot from manual test so it works again.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::hasAvailableVideoFrame): New, ask the media engine if a video frame

is available to render.

  • platform/graphics/MediaPlayer.h: Prototype for hasAvailableVideoFrame.
  • platform/graphics/MediaPlayerPrivate.h: Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Declare hasAvailableVideoFrame, declare

all bool variables to aid packing.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_videoFrameHasDrawn. Cleanup

floating point initializers to match coding guidelines.

(WebCore::MediaPlayerPrivate::load): Initialize m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivate::hasAvailableVideoFrame): New.
(WebCore::MediaPlayerPrivate::repaint): Set m_videoFrameHasDrawn.

(WebCore::RenderImage::paintReplaced): Split part out into paint method.
(WebCore::RenderImage::paint): New.

  • rendering/RenderImage.h: Declare paint. Make isWidthSpecified and isHeightSpecified protected

instead of private so RenderVideo can use them.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Inherit from RenderImage, not RenderReplaced (WebCore::RenderMedia::destroy): Ditto. (WebCore::RenderMedia::styleDidChange): Ditto. (WebCore::RenderMedia::layout): Ditto. (WebCore::RenderMedia::lowestPosition): Ditto. (WebCore::RenderMedia::rightmostPosition): Ditto. (WebCore::RenderMedia::leftmostPosition): Ditto.
  • rendering/RenderMedia.h: Declare isImage and isRenderImage.
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::intrinsicSizeChanged): New, call RenderVideo::intrinsicSizeChanged

when displaying a poster so it is sized correctly.

(WebCore::RenderVideo::imageChanged): Override so we can cache the image's intrisic size and
use it when we also know the movie's intrinsic size but still need to draw the poster.
(WebCore::RenderVideo::videoBox): Use the poster's intrinsic size when drawing the poster,
use the movie's intrinsic size when drawing frames.
(WebCore::RenderVideo::paintReplaced): Call RenderImage::paint when drawing the poster.
(WebCore::RenderVideo::videoElement): New.
(WebCore::RenderVideo::updatePlayer):

  • rendering/RenderVideo.h: (WebCore::RenderVideo::minimumReplacedHeight): Added.

2010-01-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler and Simon Fraser.

rdar://problem/5684062
https://bugs.webkit.org/show_bug.cgi?id=23094
Flash of white when switching from poster image to video playback


https://bugs.webkit.org/show_bug.cgi?id=23140
<video> poster should scale like a video frame

  • media/video-poster-expected.txt: Remove blank line at beginning of test result present as a side effect of the media element using RenderImage to display the poster.
  • media/video-poster-scale.html: New.
  • media/video-poster-scale-expected.txt: New.
10:11 AM Changeset in webkit [53145] by darin@chromium.org
  • 2 edits in trunk/WebKitTools

2010-01-11 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] "build-webkit --chromium" should run "make all" on Linux
https://bugs.webkit.org/show_bug.cgi?id=33500

  • Scripts/webkitdirs.pm:
10:10 AM Changeset in webkit [53144] by darin@chromium.org
  • 3 edits
    1 add
    1 delete in trunk/WebKit/chromium

2010-01-11 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Re-work webkit_unit_tests so that WebKit is initialized only once
https://bugs.webkit.org/show_bug.cgi?id=33504

  • WebKit.gyp:
  • tests/KURLTest.cpp: (ComponentCase::TEST):
  • tests/RunAllTests.cpp: Added. (main):
  • tests/WebKitTest.h: Removed.
10:10 AM Changeset in webkit [53143] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-01-12 Tony Chang <tony@chromium.org>

Reviewed by Maciej Stachowiak.

Add a test for a Chromium crash when loading multipart/x-mixed-replace
data.

https://bugs.webkit.org/show_bug.cgi?id=31446

  • http/tests/multipart/multipart-wait-before-boundary-expected.txt: Added.
  • http/tests/multipart/multipart-wait-before-boundary.html: Added.
  • http/tests/multipart/resources/multipart-wait-before-boundary.php: Added.

2010-01-12 Tony Chang <tony@chromium.org>

Reviewed by Maciej Stachowiak.

Fix a crash in Chromium when receiving multipart/x-mixed-replace data.
If we stop a multipart load after ResourceLoader::didReceiveResponse
but before ResourceLoader::didReceiveData, we have a NULL document
loader because it has been moved back to the provisional state. New
loads that happen after this will dereference the NULL document
loader.

Work around this by moving the provisional document loader back as
the document loader when the request is stopped.

https://bugs.webkit.org/show_bug.cgi?id=31446

Test: http/tests/multipart/multipart-wait-before-boundary.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
9:15 AM Changeset in webkit [53142] by enrica@apple.com
  • 2 edits in trunk/WebCore

WebKit returns incorrect match count when first string match is on an element with user-select-none style
https://bugs.webkit.org/show_bug.cgi?id=33508
<rdar://problem/7482143>

Reviewed by Darin Adler.

If we use VisiblePosition to calculate the start of the new search range,
we skip all the nodes with user-select-none style, producing an incorrect
match count.

No new tests: there are no API's available to Javascript to verify the
number of matches found.

  • page/Frame.cpp:

(WebCore::Frame::markAllMatchesForText): Changed to use the end of the previous
result range as the start of the new search range.

9:03 AM Changeset in webkit [53141] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Changed ".sidebar" style to allow v-scroll to appear in
"Profiles" panel sidebar.

https://bugs.webkit.org/show_bug.cgi?id=33470

No new tests -- no code changed.

  • inspector/front-end/inspector.css:
6:37 AM Changeset in webkit [53140] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-12 Petri Latvala <petri.latvala@nomovok.com>

Reviewed by Antti Koivisto.

fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html failed on buildbot
https://bugs.webkit.org/show_bug.cgi?id=33465

A touchmove event is not dispatched if none of the touch points actually moved.
Changed the test to use touchstart instead.

  • fast/events/touch/touch-coords-in-zoom-and-scroll.html:
  • platform/qt/Skipped:
5:55 AM Changeset in webkit [53139] by Adam Roben
  • 2 edits in trunk/WebCore

Windows accelerated compositing build fix after r53110

  • plugins/PluginWidget.h:

(WebCore::PluginWidget::platformLayer): Define platformLayer() for
non-Mac platforms that have accelerated compositing turned on. It
would probably be better to make PluginWidget not be used at all on
non-Mac platforms, but this fix is much simpler.

5:48 AM Changeset in webkit [53138] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

[GTK] couple fixes for signal emissions, and property notifications
https://bugs.webkit.org/show_bug.cgi?id=33428

Fix commitedLoad being called where it should not, causing it to
be called one time too many in some cases. We now match Qt's and
Mac's behavior here.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
  • tests/testloading.c: (load_error_status_changed_cb):
5:05 AM Changeset in webkit [53137] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-12 Eric Seidel <eric@webkit.org>

Reviewed by Gustavo Noronha Silva.

[GTK] Threading problems with some of the tests
https://bugs.webkit.org/show_bug.cgi?id=30814

Skip another test which is hitting the SQLiteDatabase::sqliteHandle() threading ASSERT.

  • platform/gtk/Skipped:
4:59 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
4:45 AM Changeset in webkit [53136] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Touch event layout tests should be in their own subdirectory, so that they can be easily skipped
https://bugs.webkit.org/show_bug.cgi?id=33526

Reviewed by Simon Hausmann.

Tests moved from fast/events to fast/events/touch by r53125,
relative resource paths should be adjuted to the new location.

  • fast/events/touch/basic-touch-events.html: relative paths fixed.
  • fast/events/touch/touch-coords-in-zoom-and-scroll.html: relative paths fixed.
4:41 AM Changeset in webkit [53135] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-01-12 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Support injection of inspector scripts into the inspected context.

https://bugs.webkit.org/show_bug.cgi?id=33523

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::WeakReferenceCallback): (WebCore::createInjectedScriptHostV8Wrapper): (WebCore::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
4:31 AM Changeset in webkit [53134] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

AssignToCommitter does not need to fetch bugs twice
https://bugs.webkit.org/show_bug.cgi?id=33530

This is a no-brainer patch now that we've added Bug.reviewed_patches

  • Scripts/webkitpy/commands/upload.py:
4:03 AM Changeset in webkit [53133] by eric@webkit.org
  • 22 edits in trunk/WebKitTools

2010-01-12 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla.py should have an Attachment object instead of passing around dictionaries
https://bugs.webkit.org/show_bug.cgi?id=31594

  • Scripts/webkitpy/bugzilla.py:
    • Add a new Attachment class, with accessor methods for all the necessary properties.
    • Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
    • Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
    • Move committer validation logic into its own class.
    • Committer rejection is only used in one place. Make the new Bug reviewed_patches and commit_queued_patches handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle the case where we want to reject patches in bugzilla.
    • Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
    • Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
    • Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
    • Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
  • Scripts/webkitpy/bugzilla_unittest.py:
    • Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
  • Scripts/webkitpy/commands/download.py:
    • Store "bug_id" in state instead of making a fake patch object.
    • Update to use Attachment and Bug objects.
  • Scripts/webkitpy/commands/download_unittest.py:
    • Update expected results now that our testing framework covers more code.
  • Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
  • Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
  • Scripts/webkitpy/commands/queries_unittest.py: ditto.
  • Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
  • Scripts/webkitpy/commands/queuestest.py: ditto.
  • Scripts/webkitpy/commands/upload.py: ditto.
  • Scripts/webkitpy/mock_bugzillatool.py:
    • Now that more logic has moved into Attachment and Bug, we have to actually provide real reviewer emails as well as real reviewer flags.
    • Update mock methods to return Attachment objects.
  • Scripts/webkitpy/scm.py: Update to use Attachment class.
  • Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
  • Scripts/webkitpy/statusserver.py: ditto.
  • Scripts/webkitpy/steps/applypatch.py: ditto.
  • Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
  • Scripts/webkitpy/steps/closebug.py: ditto.
  • Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either statebug_id? or statepatch?.bug_id()
  • Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
  • Scripts/webkitpy/steps/obsoletepatches.py: ditto.
  • Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
3:48 AM Changeset in webkit [53132] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-01-12 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

Form Reset : Press Back Button and Reset , TextareaElemnt is not set to Default Value
https://bugs.webkit.org/show_bug.cgi?id=31539

Added manual test: manual-tests/textarea-reset-default-value.html.

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::restoreFormControlState): set the value, rather than default value of a text area when restoring its state. This allows resetting a form with a textarea to work correctly after its state has been restored.
  • manual-tests/resources/textarea-form-back-on-submit.html: Added.
  • manual-tests/textarea-reset-default-value.html: Added.
3:28 AM Changeset in webkit [53131] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-12 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

[Qt] WebCore::Path allocates QPainterPath unnecessarily on the heap
https://bugs.webkit.org/show_bug.cgi?id=33466

WebCore::Path is a pointer to a PlatformPath. In case of Qt that's a
QPainterPath, which itself is a pointer to the elements (QVector).
That creates unecessary allocations in PathQt.cpp.

Replaced the "PlatformPath* m_path;" with a PlatformPathPtr, which
is a plain QPainterPath.

  • platform/graphics/Path.h: (WebCore::Path::platformPath):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::contains): (WebCore::Path::strokeContains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::strokeBoundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::debugString): (WebCore::Path::apply): (WebCore::Path::transform):
3:21 AM Changeset in webkit [53130] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Unreviewed typo fix. :(

  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
3:21 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:10 AM Changeset in webkit [53129] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Unreviewed. Add "error" to the right part of the message.

  • Scripts/webkitpy/commands/queues.py:
3:06 AM Changeset in webkit [53128] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-12 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

media/video-error-does-not-exist.html failed on Snow Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=33434

Add another media test to the skipped list.
I expect these are all timing out for the same reason.
We just don't know the reason yet.

  • platform/mac-snowleopard/Skipped:
2:42 AM Changeset in webkit [53127] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2010-01-12 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] XSL stylesheets can load documents from a different origin

https://bugs.webkit.org/show_bug.cgi?id=33423

Add two expected results for Qt:
QXmlQuery has a different behaviour with regard to loading failures
comparing to libxslt.

  • platform/qt/http/tests/security/xss-DENIED-xsl-document-expected.txt:
  • platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt:

2010-01-12 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Adam Barth.

[Qt] XSL stylesheets can load documents from a different origin

https://bugs.webkit.org/show_bug.cgi?id=33423

  • xml/XSLTProcessorQt.cpp: (WebCore::XSLTUriResolver::XSLTUriResolver): (WebCore::XSLTUriResolver::resolve): (WebCore::XSLTProcessor::transformToString):
2:17 AM Changeset in webkit [53126] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

EWS should show purple when svn-apply fails
https://bugs.webkit.org/show_bug.cgi?id=33527

  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
2:17 AM Changeset in webkit [53125] by Simon Hausmann
  • 5 edits
    4 moves
    1 add in trunk/LayoutTests

Touch event layout tests should be in their own subdirectory, so that they can be easily skipped
https://bugs.webkit.org/show_bug.cgi?id=33526

Reviewed by Adam Barth.

  • fast/events/touch/basic-touch-events-expected.txt: Renamed from LayoutTests/fast/events/basic-touch-events-expected.txt.
  • fast/events/touch/basic-touch-events.html: Renamed from LayoutTests/fast/events/basic-touch-events.html.
  • fast/events/touch/touch-coords-in-zoom-and-scroll-expected.txt: Renamed from LayoutTests/fast/events/touch-coords-in-zoom-and-scroll-expected.txt.
  • fast/events/touch/touch-coords-in-zoom-and-scroll.html: Renamed from LayoutTests/fast/events/touch-coords-in-zoom-and-scroll.html.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
2:09 AM Changeset in webkit [53124] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Gustavo Noronha Silva.

https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text

Tweak/correction: Eliminate a needless variable.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
1:50 AM Changeset in webkit [53123] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove copy/paste code from subclasses of AbstractReviewQueue
https://bugs.webkit.org/show_bug.cgi?id=33525

  • Scripts/webkitpy/commands/early_warning_system.py:
  • Scripts/webkitpy/commands/queues.py:
1:42 AM Changeset in webkit [53122] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add Gustavo and Xan as gtk-ews watchers
https://bugs.webkit.org/show_bug.cgi?id=33519

  • Scripts/webkitpy/commands/early_warning_system.py:
1:41 AM Changeset in webkit [53121] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch shouldn't waste my time for with a component prompt
https://bugs.webkit.org/show_bug.cgi?id=33521

The component field isn't very useful for bugs created with
webkit-patch because they're likely to be resolved quickly. Instead of
always prompting for a component, we should just default to the "New
Bugs" component. If the bug stays around for more than five minutes,
we can assign it a proper component.

  • Scripts/webkitpy/bugzilla.py:
1:40 AM Changeset in webkit [53120] by abarth@webkit.org
  • 5 edits
    1 add in trunk/WebKitTools

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add experimental "land-safely" command to webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=33518

  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/steps/init.py:
  • Scripts/webkitpy/steps/postdiffforcommit.py: Added.
12:18 AM Changeset in webkit [53119] by yurys@chromium.org
  • 6 edits in trunk/WebCore

2010-01-12 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Geoffrey Garen.

Allow creating injected script for the inspected script state. The InjectedScript is
cached on the inspected ExecState global object and will be garbage collected when the
object is collected. Each InjectedScript object is assigned unique id.

https://bugs.webkit.org/show_bug.cgi?id=33469

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: InjectedScript is cached on the global object as a field that is not visible from the inspected code. This InjectedScript should be alive as long as the global object is alive and should be accessible from Web Inspector's native code. (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::createInjectedScript): Creates injected script using the lexical global object of the inspected ScriptState. Reference to the object is stored on the global DOM object. (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::discardInjectedScripts): This method is expected to be called when the the InjectedScript are no longer needed. In particular, this should be called before frame navigation.
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::setInjectedScriptSource): This allows to provide injected script source. The source may be loaded in a platform specific way.
12:16 AM Changeset in webkit [53118] by abarth@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

ecma/Date/15.9.5.12-1.js fails every night at midnight
https://bugs.webkit.org/show_bug.cgi?id=28041

Change the test to use a concrete time instead of "now".

  • tests/mozilla/ecma/Date/15.9.5.10-1.js:
  • tests/mozilla/ecma/Date/15.9.5.12-1.js:

Jan 11, 2010:

11:25 PM Changeset in webkit [53117] by mjs@apple.com
  • 2 edits in trunk/WebKitSite

Not reviewed; updated for truth (and readability).

Fixed some wrong listings and reorganized this page.

  • security/security-group-members.html:
10:46 PM Changeset in webkit [53116] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-11 Kent Tamura <tkent@chromium.org>

Unreviewd. Remove a duplicated line in an expectation file.

  • platform/mac-leopard/fast/text/find-kana-expected.txt:
9:53 PM Changeset in webkit [53115] by darin@apple.com
  • 3 edits in trunk/LayoutTests

Try to get find-kana tests passing on Qt, Leopard, and Tiger.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Expect more failures.
  • platform/qt/fast/text/find-kana-expected.txt: Ditto.
5:48 PM Changeset in webkit [53114] by darin@apple.com
  • 7 edits in trunk

Fix handling of unusual kana sequences in search
https://bugs.webkit.org/show_bug.cgi?id=33506

Reviewed by Dan Bernstein.

WebCore:

  • editing/TextIterator.cpp:

(WebCore::composedVoicedSoundMark): Removed unnnecessary case for a
non-kana-letter character. This function only works for kana letters.
(WebCore::SearchBuffer::isBadMatch): Fixed voiced sound mark code to
properly handle cases where one character has a shorter list of
combining voiced sound marks than the other.

LayoutTests:

  • fast/text/find-kana-expected.txt: Updated.
  • fast/text/script-tests/find-kana.js: Added new tests for sequences

that do not have composed equivalents. This is needed to test the code
that compares voice marks. The old test cases didn't cover the combining
character code path because normalizing to NFC combined all the sequences.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Updated.
  • platform/qt/fast/text/find-kana-expected.txt: Updated.
5:22 PM Changeset in webkit [53113] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Victor Wang <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

Clear m_acceptedIndexOnAbandon flag when user accepts the selected index.

https://bugs.webkit.org/show_bug.cgi?id=33499

TEST: manual-tests/chromium/onchange-reload-popup.html
It should be covered by the above test. The current
test shell does not support sending keyboard events to popup
list so use manual test for it.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::acceptIndex):
4:55 PM Changeset in webkit [53112] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after introduction of JS_NO_EXPORT

4:42 PM Changeset in webkit [53111] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Eric Seidel.

[GTK] Debug bots crashing in plugins/iframe-shims.html
https://bugs.webkit.org/show_bug.cgi?id=33472

Call computeOffsetInContainerNode() instead of
offsetInContainerNode(), since we are not sure this is always
parent-anchored.

plugins/iframe-shims.html no longer ASSERTS

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
4:15 PM Changeset in webkit [53110] by simon.fraser@apple.com
  • 17 edits in trunk

2010-01-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=33455
Allows plugins to participate in accelerated compositing

For plugins using the CoreAnimation rendering mode, host their CALayers in the
accelerated compositing layer tree.

This requires making normal flow RenderLayers for RenderEmbeddedObjects when they represent
a plugin using this mode.

  • WebCore.base.exp: Export Node::setNeedsStyleRecalc() for use by WebKit.
  • WebCore.xcodeproj/project.pbxproj: Re-order files for sorting.
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::requiresLayer): Make a layer if the plugin is using accelerated compositing mode. (WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing): Asks whether the plugin has a layer, via PluginWidget.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer): RenderEmbeddedObjects should be normal flow layers, and self-painting layers.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Parent the plugin's layer in the GraphicsLayer when updating the layer configuration.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingLayer): (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): RenderEmbeddedObjects that allow accelerated compositing trip accelerated compositing mode for the page.
4:09 PM Changeset in webkit [53109] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Fixed an uninitialized PluginView member (m_mode) which wasn't
set when constructed with a null PluginPackage*

https://bugs.webkit.org/show_bug.cgi?id=33468

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
4:02 PM Changeset in webkit [53108] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt

2010-01-11 William Siegrist <wsiegrist@apple.com>

Sync new Disallow rules from build.webkit.org.

3:58 PM Changeset in webkit [53107] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html

2010-01-11 William Siegrist <wsiegrist@apple.com>

Add Console and CQ Bot Status links to build.webkit.org. Sync CSS changes.

3:41 PM Changeset in webkit [53106] by eric@webkit.org
  • 7 edits in trunk

2010-01-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG radialGradient example radial-gradient-with-outstanding-focalPoint.svg fails
https://bugs.webkit.org/show_bug.cgi?id=32201

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:

2010-01-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG radialGradient example radial-gradient-with-outstanding-focalPoint.svg fails
https://bugs.webkit.org/show_bug.cgi?id=32201

This patch moves every focalPoint that lies outside the circle defined by the radial
gradients central point and its radius to stay inside this circle, as demanded by the
SVG 1.1 specification.
We use r * 0.99 as maximum radius for the aforementioned circle, when determining where
the focalPoint is lying, to achieve compatibility with Firefox.

  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
3:35 PM Changeset in webkit [53105] by eric@webkit.org
  • 5 edits
    2 deletes in trunk/WebKitTools

2010-01-11 Eric Seidel <eric@webkit.org>

No review, rolling out r53079.
http://trac.webkit.org/changeset/53079
https://bugs.webkit.org/show_bug.cgi?id=33197

Adam doens't think this actually works, and believe it caused
a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
rolling this out.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
  • Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
3:00 PM Changeset in webkit [53104] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=33493
Log redirect details to Network channel

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Log response code and Location header field value. Also, removed a redundant null check.
2:56 PM Changeset in webkit [53103] by bdakin@apple.com
  • 13 edits
    8 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33491 REGRESSION:
Many SVG -webkit-shadow tests are currently failing (in the pixel
tests)
-and-
<rdar://problem/7501200>

Reviewed by Oliver Hunt.

The real fix here is to call inflateForShadow() on the repaintRect
in prepareToRenderSVGContent(). But in order to do that, I had to
move inflateForShadow() to a different class since functions in
SVGRenderBase cannot call each other. inflateForShadow() now exists
in SVGRenderStyle which I think makes some sense because a similar
function that returns a box shadow's extent exists on RenderStyle.

Now call inflateForShadow() through the SVGRenderStyle.

  • rendering/RenderForeignObject.cpp:

(WebCore::RenderForeignObject::computeRectForRepaint):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::computeRectForRepaint):

  • rendering/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::computeRectForRepaint):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeRectForRepaint):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::computeRectForRepaint):

No longer implement inflateForShadow() here.

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent): Call new
inflateForShadow() through the SVGRenderStyle

  • rendering/SVGRenderSupport.h:

Implementation of inflateForShadow() now lives here.

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::getSVGShadowExtent):
(WebCore::SVGRenderStyle::inflateForShadow):

  • rendering/style/SVGRenderStyle.h:

LayoutTests: New tests for https://bugs.webkit.org/show_bug.cgi?id=33491
REGRESSION: Many SVG -webkit-shadow tests are currently failing (in
the pixel tests)
-and-
<rdar://problem/7501200>

Reviewed by Oliver Hunt.

I would like to note that this change fixes some existing layout
tests as well.

  • platform/mac/svg/css/shadow-with-large-radius-expected.checksum: Added.
  • platform/mac/svg/css/shadow-with-large-radius-expected.png: Added.
  • platform/mac/svg/css/shadow-with-large-radius-expected.txt: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.checksum: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.png: Added.
  • platform/mac/svg/css/shadow-with-negative-offset-expected.txt: Added.
  • platform/mac/svg/css/stars-with-shadow-expected.checksum:
  • platform/mac/svg/css/stars-with-shadow-expected.png:
  • svg/css/shadow-with-large-radius.svg: Added.
  • svg/css/shadow-with-negative-offset.svg: Added.
2:52 PM Changeset in webkit [53102] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-11 Eric Seidel <eric@webkit.org>

Rubber-stamped by Csaba Osztrogonac.

Web Inspector: External resource relative URLs cannot be navigated to from the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=33024

  • platform/qt/Skipped: Skip this new test, Qt's DRT doesn't support evaluateInWebInspector()
2:46 PM Changeset in webkit [53101] by enrica@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=33411

Reviewed by Eric Seidel.

Missing updated test result for gtk.

  • platform/gtk/editing/deleting/5115601-expected.txt:
2:33 PM Changeset in webkit [53100] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-01-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Rewrite relative URLs in the ElementsTreeOutline to make them navigable

Targets for "src" and "href" attribute values in the Elements outline tree
are rewritten to full URLs whenever possible.
https://bugs.webkit.org/show_bug.cgi?id=33024

  • inspector/elements-panel-rewrite-href-expected.txt: Added.
  • inspector/elements-panel-rewrite-href.html: Added.

2010-01-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Rewrite relative URLs in the ElementsTreeOutline to make them navigable

Targets for "src" and "href" attribute values in the Elements outline tree
are rewritten to full URLs whenever possible.
https://bugs.webkit.org/show_bug.cgi?id=33024

Test: inspector/elements-panel-rewrite-href.html

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._rewriteAttrHref): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
  • inspector/front-end/inspector.js:
2:20 PM Changeset in webkit [53099] by oliver@apple.com
  • 2 edits in trunk/SunSpider

2010-01-11 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Sunspider parse-only tests don't run
https://bugs.webkit.org/show_bug.cgi?id=33489

Fix parse-only test list

  • tests/parse-only/LIST:
2:17 PM Changeset in webkit [53098] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

fast/text/international/japanese-kana-letters.html
removed by r53078, so it should be removed from skiplist.

  • platform/qt/Skipped: fast/text/international/japanese-kana-letters.html removed.
1:54 PM Changeset in webkit [53097] by ojan@chromium.org
  • 17 edits in trunk/LayoutTests

2010-01-11 Ojan Vafai <ojan@chromium.org>

Reviewed by Simon Fraser.

Deflake transitions and animations tests.
https://bugs.webkit.org/show_bug.cgi?id=30029

The transition-end-event tests all had arbitrary timeouts. Give a consistent
timeout to all of them. Give a generous 1 second of buffer to avoid any possibility
of flakiness. If all the transitionEnd events fire before then, the test still
completes without waiting for the timeout.

  • animations/change-keyframes.html: Increase the wiggle room. It's infrequently flaky now, but it is still a tad bit flaky without this extra wiggle room.
  • transitions/repeated-firing-background-color.html: Remove a gratuitous setTimeout.
  • transitions/transition-end-event-all-properties.html:
  • transitions/transition-end-event-attributes.html:
  • transitions/transition-end-event-container.html:
  • transitions/transition-end-event-helpers.js: (runTransitionTest.startTest): (runTransitionTest):
  • transitions/transition-end-event-left.html:
  • transitions/transition-end-event-multiple-01.html:
  • transitions/transition-end-event-multiple-02.html:
  • transitions/transition-end-event-multiple-03.html:
  • transitions/transition-end-event-multiple-04.html:
  • transitions/transition-end-event-nested.html:
  • transitions/transition-end-event-set-none.html:
  • transitions/transition-end-event-transform.html:
  • transitions/transition-end-event-window.html:
  • transitions/zero-duration-with-non-zero-delay-end.html:
1:46 PM Changeset in webkit [53096] by darin@apple.com
  • 1 edit
    2 copies in trunk/LayoutTests

Try to get find-kana and find-russian tests passing on Qt.

  • platform/qt/fast/text/find-kana-expected.txt: Copied from fast/text/find-kana-expected.txt.
  • platform/qt/fast/text/find-russian-expected.txt: Copied from fast/text/find-russian-expected.txt.

Changed to expect failures because text searching does not use
ICU's usearch on this platform, and the non-usearch code is much
less capable.

1:31 PM Status created by alex@milowski.com
1:23 PM WebKit Team edited by jpetsovits@rim.com
Add areas of knowledge to my team member information. (diff)
1:04 PM MathML edited by alex@milowski.com
(diff)
12:35 PM Changeset in webkit [53095] by ap@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=33482
Add a test for Russian text search

  • fast/text/find-russian-expected.txt: Added.
  • fast/text/find-russian.html: Added.
  • fast/text/script-tests/find-russian.js: Added.
12:33 PM Changeset in webkit [53094] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

[Qt] Enable JIT and YARR_JIT if (CPU(X86_64) && OS(LINUX) && GCC_VERSION >= 40100)

Reviewed by Ariya Hidayat.

  • wtf/Platform.h:
12:19 PM Changeset in webkit [53093] by darin@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

Try to get find-kana test passing on Tiger and Leopard.

  • platform/mac-leopard/fast/text/find-kana-expected.txt: Copied from fast/text/find-kana-expected.txt.

Changed to expect failures due to an older version of ICU on those platforms.

12:14 PM Changeset in webkit [53092] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Updated Windows expected results after r53085.

Reviewed by NOBODY.

  • platform/win/editing/selection/mixed-editability-10-expected.txt:
11:55 AM Changeset in webkit [53091] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-01-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=33481
Uninitialized data members in ArrayStorage


SunSpider reports no change.

  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): Initialize missing data members in the two cases where we don't use fastZeroedMalloc, so it doesn't happen automatically.
11:53 AM Changeset in webkit [53090] by sfalken@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix ChangeLog

11:45 AM Changeset in webkit [53089] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=33480

Improve debugging reliability for WTF on Windows.
Store WTF static library's PDB file into a better location.

11:42 AM Changeset in webkit [53088] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to fix windows builds, by removing the no-longer existant JSSVGPointListCustom.cpp from JSBindingsAllInOne.cpp.

  • bindings/js/JSBindingsAllInOne.cpp:
11:34 AM Changeset in webkit [53087] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.
Remove extraneous entries from def file causing build warning.

11:23 AM Changeset in webkit [53086] by zimmermann@webkit.org
  • 13 edits
    1 move
    7 adds
    1 delete in trunk

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

svg <text> fails to update when setting x/y
https://bugs.webkit.org/show_bug.cgi?id=22384

Introduce JSSVGPODListCustom, refactoring the existing custom code for SVG POD type lists.
(Currently SVGTransformList/SVGPointList was handled correctly, and SVGLengthList/SVGNumberList not)

Remove the need for custom JSSVG*List.cpp implementations, but instead tweak CodeGeneratorJS.pm,
to call into the new JSSVGPODListCustom methods. Fixes dynamic updates of the SVGTextElement
'rotate' & 'x'/'y' SVG DOM properties.

Tests: svg/custom/text-xy-updates-SVGList.xhtml

svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop.html


  • Android.jscbindings.mk: Remove old files from build, add the new header.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSSVGPODListCustom.h: Copied from bindings/js/JSSVGTransformListCustom.cpp. Refactored code to be sharable between all JSSVG*List classes. (WebCore::JSSVGPODListCustom::finishGetter): (WebCore::JSSVGPODListCustom::finishSetter): (WebCore::JSSVGPODListCustom::finishSetterReadOnlyResult): (WebCore::JSSVGPODListCustom::clear): (WebCore::JSSVGPODListCustom::initialize): (WebCore::JSSVGPODListCustom::getItem): (WebCore::JSSVGPODListCustom::insertItemBefore): (WebCore::JSSVGPODListCustom::replaceItem): (WebCore::JSSVGPODListCustom::removeItem): (WebCore::JSSVGPODListCustom::appendItem):
  • bindings/js/JSSVGPointListCustom.cpp: Removed.
  • bindings/js/JSSVGTransformListCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm: Forward any SVGList call on POD list types to the new JSSVGPODListCustom.
  • svg/SVGNumberList.cpp: Make SVGNumberList a SVGPODList, instead of a SVGList, to make dynamic updates work. (WebCore::SVGNumberList::SVGNumberList):
  • svg/SVGNumberList.h:
  • svg/SVGPointList.idl: Remove JSCCustom markers everywhere.
  • svg/SVGTransformList.idl: Ditto.

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Roben & Dirk Schulze.

svg <text> fails to update when setting x/y
https://bugs.webkit.org/show_bug.cgi?id=22384

Add simple tests covering SVGLengthList & SVGNumberList updates.

  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.checksum: Added.
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.png: Added.
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
  • svg/custom/text-xy-updates-SVGList.xhtml: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-rotate-prop.js: Added. (executeTest):
10:04 AM Changeset in webkit [53085] by enrica@apple.com
  • 10 edits in trunk

Cannot focus on an empty editable span in a non editable div.
https://bugs.webkit.org/show_bug.cgi?id=33411
<rdar://problem/5982901>

Reviewed by Darin Adler.

WebCore:

We now allow to set the focus inside an empty inline element if it is the only
editable element inside non-editable content.

  • dom/Position.cpp:

(WebCore::Position::isCandidate): Extended to allow positions in inline elements when
at the border between editable and non editable content.
(WebCore::Position::getInlineBoxAndOffset): Modified to be able to calculate the caret
position inside an empty inline.

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs): When merging, we don't always find a break
element, since now an editable inline is a VisiblePosition if it is at editability boundary.

  • editing/VisibleSelection.h: Updated comment on the use of Position member variables

instead of VisiblePosition.

  • page/Frame.cpp:

(WebCore::Frame::selectionLayoutChanged): Changed to avoid multiple calls to upstream and
downstream on the same position.

LayoutTests:

  • editing/deleting/6026335-expected.txt: Updated to reflect the lack of extra break element.
  • editing/selection/mixed-editability-10-expected.txt: Updated to cover the new case.
  • editing/selection/mixed-editability-10.html: Updated to cover the new case.
  • platform/mac/editing/deleting/5115601-expected.txt: Updated to reflect the lack of extra break element.
9:57 AM Changeset in webkit [53084] by kov@webkit.org
  • 5 edits in trunk

Revert 53075 since it caused ASSERTS to be hit.

9:16 AM Changeset in webkit [53083] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-01-06 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Nikolas Zimmermann.

[V8] IsRefPtrType() in CodeGeneratorV8.pm increases maintenance burden.
https://bugs.webkit.org/show_bug.cgi?id=32994

Refactoring, covered by existings tests.

  • bindings/scripts/CodeGeneratorV8.pm: Reversed testing for ref-counted objects,

since there's a much smaller (and more stable) set of non-ref-counted ones.

9:08 AM Changeset in webkit [53082] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=33472
[GTK] Debug bots crashing in plugins/iframe-shims.html

Skip test that fails on bots, but passes locally, so we can
investigate.

9:05 AM Changeset in webkit [53081] by Nate Chapin
  • 1 edit
    4 adds in trunk/LayoutTests

2010-01-08 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Test that document.referrer is properly preserved through a redirect.

https://bugs.webkit.org/show_bug.cgi?id=33407

  • http/tests/navigation/redirect-preserves-referrer-expected.txt: Added.
  • http/tests/navigation/redirect-preserves-referrer.html: Added.
  • http/tests/navigation/resources/redirect-to-referrer-check.pl: Added.
  • http/tests/navigation/resources/referrer.html: Added.
9:02 AM Changeset in webkit [53080] by knorton@google.com
  • 7 edits in trunk/WebCore

2010-01-11 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Fixes the fact that timeline panel results are skewed by the use of DOM mutation events.
https://bugs.webkit.org/show_bug.cgi?id=32846

Instead of using DOM mutation events in InspectorDOMAgent, InspectorController is now called
directly when the DOM is mutated.

  • dom/ContainerNode.cpp: Calls InspectorController directly when child nodes are added/removed. (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: Calls InspectorController directly when attributes are added/removed. (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::didRemoveDOMNode): (WebCore::InspectorController::didModifyDOMAttr):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr):
  • inspector/InspectorDOMAgent.h:
8:50 AM Changeset in webkit [53079] by abarth@webkit.org
  • 5 edits
    1 copy
    1 add in trunk/WebKitTools

2010-01-10 Adam Barth <abarth@webkit.org>

Reviewed by David Kilzer.

bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
https://bugs.webkit.org/show_bug.cgi?id=33197

We should just search for bug numbers in the ChangeLogs instead of in
the whole diff.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
  • Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
8:30 AM Changeset in webkit [53078] by darin@apple.com
  • 3 edits
    3 adds
    2 deletes in trunk

REGRESSION: Japanese text search ignores small vs. large and voicing mark differences
https://bugs.webkit.org/show_bug.cgi?id=30437
rdar://problem/7214058

Reviewed by Alexey Proskuryakov.

WebCore:

Test: fast/text/find-kana.html

  • editing/TextIterator.cpp:

(WebCore::isKanaLetter): Added.
(WebCore::isSmallKanaLetter): Added.
(WebCore::composedVoicedSoundMark): Added.
(WebCore::isCombiningVoicedSoundMark): Added.
(WebCore::containsKanaLetters): Added.
(WebCore::normalizeCharacters): Added.
(WebCore::SearchBuffer::SearchBuffer): Initialize the data members
m_targetRequiresKanaWorkaround and m_normalizedTarget.
(WebCore::SearchBuffer::isBadMatch): Added. Checks for matches that
ICU's default collation considers correct, but we consider incorrect.
(WebCore::SearchBuffer::search): Added code to call isBadMatch and
move to the next match with usearch_next if the result is true.

LayoutTests:

  • fast/text/international/japanese-kana-letters-expected.txt: Removed.
  • fast/text/international/japanese-kana-letters.html: Removed.
  • fast/text/find-kana-expected.txt: Added.
  • fast/text/find-kana.html: Added.
  • fast/text/script-tests/find-kana.js: Added.

This includes all the tests that were in the old test removed above, with three
differences:

1) Moved out of "international" directory because Mitz wants to phase that

directory out.

2) Added more tests to cover more cases involving things like decomposed

characters and different voice marks.

3) Used script-tests, so results list passing tests as well as failing tests.

We could still test even more, but this should at least cover all the lines of
code in the current bug fix patch.

8:15 AM Changeset in webkit [53077] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Add private API for QWebFrame scrolling, to maintain binary compatibility with Qt 4.6.

Reviewed by Holger Freyther.

This is just a temporary addition until we have introduced #ifdefs to allow
safely removing the private API again.

  • Api/qwebframe.cpp:

(qtwebkit_webframe_scrollRecursively):

7:52 AM Changeset in webkit [53076] by ddkilzer@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Created a unit-tested function to parse the header block of
a Git or SVN diff -- for future refactoring of svn-apply and
svn-unapply.

Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-11
Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=33447

  • Scripts/VCSUtils.pm:
    • Added parseDiffHeader().
    • Removed irrelevant comment from gitdiff2svndiff().
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
    • Added 48 unit tests for parseDiffHeader().
7:51 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
7:15 AM Changeset in webkit [53075] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

[GTK] couple fixes for signal emissions, and property notifications
https://bugs.webkit.org/show_bug.cgi?id=33428

Fix commitedLoad being called where it should not, causing it to
be called one time too many in some cases. We now match Qt's and
Mac's behavior here.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading):
  • tests/testloading.c: (load_error_status_changed_cb):
5:16 AM QtWebKitReleases edited by Simon Hausmann
(diff)
4:23 AM Changeset in webkit [53074] by Csaba Osztrogonác
  • 1 edit
    6 adds in trunk/LayoutTests

Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-11
[Qt] Add expected files for the following passing new tests.
Compared to the mac expected files these only differ in svg dumping style and font metrics.

  • platform/qt/fast/repaint/block-no-inflow-children-expected.txt: Added.
  • platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
  • platform/qt/svg/custom/marker-referencePoint-expected.txt: Added.
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt: Added.
  • platform/qt/svg/text/selection-background-color-expected.txt: Added.
4:12 AM Changeset in webkit [53073] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix.

  • platform/qt/Skipped:
4:03 AM Changeset in webkit [53072] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-01-11 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30883
[Gtk] Implement AtkText for HTML elements which contain text

  • accessibility/gtk/AccessibilityObjectWrapperAtk.h
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored): (webkit_accessible_text_get_caret_offset):
  • editing/gtk/SelectionControllerGtk.cpp: (SelectionController::notifyAccessibilityForSelectionChange)

Adjust the caret offset and object with focus to reflect the
unignored parent of the static text object which contains the
caret. This is necessary because the static text objects are
no longer being exposed to ATs.

3:48 AM Changeset in webkit [53071] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html fails on buildbot
https://bugs.webkit.org/show_bug.cgi?id=33465

  • platform/qt/Skipped: fast/events/touch-coords-in-zoom-and-scroll-pretty-diff.html skipped.
3:35 AM Changeset in webkit [53070] by zimmermann@webkit.org
  • 45 edits in trunk/LayoutTests

2010-01-11 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Update SVG test baseline, after the SVG text painting changes, a while ago.
The differences are all below <0.1%, and only show up when running with --tolerance 0.

1:44 AM Changeset in webkit [53069] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2010-01-11 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Touchevent coordinates are incorrect after page zoom and page scroll
https://bugs.webkit.org/show_bug.cgi?id=32899

  • fast/events/touch-coords-in-zoom-and-scroll-expected.txt: Added.
  • fast/events/touch-coords-in-zoom-and-scroll.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:

2010-01-11 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Touchevent coordinates are incorrect after page zoom and page scroll
https://bugs.webkit.org/show_bug.cgi?id=32899

Test: fast/events/touch-coords-in-zoom-and-scroll.html

  • dom/Touch.cpp: (WebCore::contentsX): (WebCore::contentsY):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent):
1:20 AM Changeset in webkit [53068] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-11 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Have "Paste and Match Style" fire the dom paste event.
https://bugs.webkit.org/show_bug.cgi?id=30639

  • editing/execCommand/paste-and-match-style-event.html: Added.

2010-01-11 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

Have "Paste and Match Style" fire the dom paste event.
https://bugs.webkit.org/show_bug.cgi?id=30639

Test: editing/execCommand/paste-and-match-style-event.html

  • editing/Editor.cpp: (WebCore::Editor::pasteAsPlainText):
Note: See TracTimeline for information about the timeline view.