Timeline


and

01/25/10:

23:36 Changeset [53841] by cjerdonek@webkit.org
  • 7 edits in trunk/WebKitTools

2010-01-25 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style by removing the file path
parameter from the style error handler functions.

https://bugs.webkit.org/show_bug.cgi?id=34031

  • Scripts/webkitpy/style/checker.py:
    • Added _default_style_error_handler() to StyleChecker class.
    • Moved handle_style_error() to inside _default_style_error_handler().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Removed file path from calls to error handler.
  • Scripts/webkitpy/style/cpp_style.py:
    • Removed file path from calls to error handler.
  • Scripts/webkitpy/style/cpp_style_unittest.py:
    • Removed file path from calls to error handler.
  • Scripts/webkitpy/style/text_style.py:
    • Removed file path from calls to error handler.
  • Scripts/webkitpy/style/text_style_unittest.py:
    • Removed file path from calls to error handler.
22:23 Changeset [53840] by jorlow@chromium.org
  • 17 edits
    1 copy
    21 adds
    23 deletes in trunk

2010-01-22 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546

Update the storageEvent algorithm to match the change in WebCore.

  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent):

2010-01-22 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546

This meat of the patch I just posted is very simple. It's just making events
asynchronous, not posting them to the frame that generated them, passing a null
for the key when issuing a clear storage event, and making the events
non-cancelable/non-bubbleable...all of which are clearly stated in the spec.

The asynchronous and not posting to the frame that generated them forced me to
re-write all the layout tests that dealt with storage events. There's a lot of
code there, but I tried to be fairly careful to ensure that test coverage did
not shrink in any area.

Tests: storage/domstorage/events/basic-body-attribute.html

storage/domstorage/events/basic-setattribute.html
storage/domstorage/events/basic.html
storage/domstorage/events/case-sensitive.html
storage/domstorage/events/documentURI.html

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::enqueueStorageEvent): (WebCore::Document::storageEventTimerFired):
  • dom/Document.h:
  • storage/StorageEvent.cpp: (WebCore::StorageEvent::StorageEvent):
  • storage/StorageEvent.idl:
  • storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):

2010-01-22 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546

This meat of the patch I just posted is very simple. It's just making events
asynchronous, not posting them to the frame that generated them, passing a null
for the key when issuing a clear storage event, and making the events
non-cancelable/non-bubbleable...all of which are clearly stated in the spec.

The asynchronous and not posting to the frame that generated them forced me to
re-write all the layout tests that dealt with storage events. There's a lot of
code there, but I tried to be fairly careful to ensure that test coverage did
not shrink in any area.

  • storage/domstorage/complex-values-expected.txt:
  • storage/domstorage/documentURI-expected.txt: Removed.
  • storage/domstorage/documentURI.html: Removed.
  • storage/domstorage/events: Added.
  • storage/domstorage/events/basic-body-attribute-expected.txt: Added.
  • storage/domstorage/events/basic-body-attribute.html: Added.
  • storage/domstorage/events/basic-expected.txt: Added.
  • storage/domstorage/events/basic-setattribute-expected.txt: Added.
  • storage/domstorage/events/basic-setattribute.html: Added.
  • storage/domstorage/events/basic.html: Added.
  • storage/domstorage/events/case-sensitive-expected.txt: Added.
  • storage/domstorage/events/case-sensitive.html: Added.
  • storage/domstorage/events/documentURI-expected.txt: Added.
  • storage/domstorage/events/documentURI.html: Added.
  • storage/domstorage/events/resources: Added.
  • storage/domstorage/events/resources/body-event-handler.html: Added.
  • storage/domstorage/events/resources/eventTestHarness.js: Added.
  • storage/domstorage/events/resources/setattribute-event-handler.html: Added.
  • storage/domstorage/events/script-tests: Added.
  • storage/domstorage/events/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
  • storage/domstorage/events/script-tests/basic-body-attribute.js: Added.
  • storage/domstorage/events/script-tests/basic-setattribute.js: Added.
  • storage/domstorage/events/script-tests/basic.js: Added.
  • storage/domstorage/events/script-tests/case-sensitive.js: Added.
  • storage/domstorage/events/script-tests/documentURI.js: Added.
  • storage/domstorage/localstorage/iframe-events-expected.txt: Removed.
  • storage/domstorage/localstorage/iframe-events.html: Removed.
  • storage/domstorage/localstorage/index-get-and-set-expected.txt:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/onstorage-attribute-markup-expected.txt: Removed.
  • storage/domstorage/localstorage/onstorage-attribute-markup.html: Removed.
  • storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt: Removed.
  • storage/domstorage/localstorage/onstorage-attribute-setattribute.html: Removed.
  • storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Removed.
  • storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Removed.
  • storage/domstorage/localstorage/simple-events-expected.txt: Removed.
  • storage/domstorage/localstorage/simple-events.html: Removed.
  • storage/domstorage/script-tests/complex-values.js:
  • storage/domstorage/script-tests/documentURI.js: Removed.
  • storage/domstorage/sessionstorage/iframe-events-expected.txt: Removed.
  • storage/domstorage/sessionstorage/iframe-events.html: Removed.
  • storage/domstorage/sessionstorage/index-get-and-set-expected.txt:
  • storage/domstorage/sessionstorage/index-get-and-set.html:
  • storage/domstorage/sessionstorage/onstorage-attribute-markup-expected.txt: Removed.
  • storage/domstorage/sessionstorage/onstorage-attribute-markup.html: Removed.
  • storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt: Removed.
  • storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html: Removed.
  • storage/domstorage/sessionstorage/onstorage-attribute-setwindow-expected.txt: Removed.
  • storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html: Removed.
  • storage/domstorage/sessionstorage/simple-events-expected.txt: Removed.
  • storage/domstorage/sessionstorage/simple-events.html: Removed.
  • storage/domstorage/window-attributes-exist-expected.txt:
  • storage/domstorage/window-attributes-exist.html:
22:00 Changeset [53839] by mitz@apple.com
  • 6 edits
    3 adds in trunk

<rdar://problem/7573493> Error with line break inside ?&raquo; pair of characters.
https://bugs.webkit.org/show_bug.cgi?id=17475

Reviewed by Darin Adler.

WebCore:

Test: fast/text/line-break-after-question-mark.html

Instead of unconditionally allowing lines to break after a question mark, which was intended
to mimic Internet Explorer, apply the Unicode line breaking behavior after a question mark,
with one exception in the ASCII range to match IE, namely not allowing a line break between
a question mark and a vertical line.

  • rendering/break_lines.cpp:

(WebCore::shouldBreakAfter): Added a next character parameter. Changed to consult a table
for the question mark case in order to keep it fast and not require a text break iterator in
the ASCII case.
(WebCore::nextBreakablePosition): Pass the next character to shouldBreakAfter.

LayoutTests:

  • fast/text/line-break-after-question-mark-expected.txt: Added.
  • fast/text/line-break-after-question-mark.html: Added.
  • fast/text/script-tests/line-break-after-question-mark.js: Added.

():

  • platform/mac/tables/mozilla/bugs/bug6674-expected.checksum: Updated.
  • platform/mac/tables/mozilla/bugs/bug6674-expected.png: Updated.
  • platform/mac/tables/mozilla/bugs/bug6674-expected.txt: Updated.
21:57 Changeset [53838] by pkasting@chromium.org
  • 92 edits in trunk

WebCore: Mac scrollbar thumbs were drawn with the wrong size.
https://bugs.webkit.org/show_bug.cgi?id=34049

Reviewed by Dan Bernstein.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

LayoutTests: Rebaseline pixel tests affected by changes in scrollbar thumb size.
https://bugs.webkit.org/show_bug.cgi?id=34049

Reviewed by Dan Bernstein.

  • platform/mac/compositing/overflow/overflow-scroll-expected.checksum:
  • platform/mac/compositing/overflow/overflow-scroll-expected.png:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/002-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/mac/fast/clip/014-expected.checksum:
  • platform/mac/fast/clip/014-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.checksum:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
  • platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
  • platform/mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac/fast/inline-block/tricky-baseline-expected.checksum:
  • platform/mac/fast/inline-block/tricky-baseline-expected.png:
  • platform/mac/fast/layers/scroll-rect-to-visible-expected.checksum:
  • platform/mac/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/mac/fast/overflow/002-expected.checksum:
  • platform/mac/fast/overflow/002-expected.png:
  • platform/mac/fast/overflow/003-expected.checksum:
  • platform/mac/fast/overflow/003-expected.png:
  • platform/mac/fast/overflow/005-expected.checksum:
  • platform/mac/fast/overflow/005-expected.png:
  • platform/mac/fast/overflow/007-expected.checksum:
  • platform/mac/fast/overflow/007-expected.png:
  • platform/mac/fast/overflow/008-expected.checksum:
  • platform/mac/fast/overflow/008-expected.png:
  • platform/mac/fast/overflow/childFocusRingClip-expected.checksum:
  • platform/mac/fast/overflow/childFocusRingClip-expected.png:
  • platform/mac/fast/overflow/float-in-relpositioned-expected.checksum:
  • platform/mac/fast/overflow/float-in-relpositioned-expected.png:
  • platform/mac/fast/overflow/image-selection-highlight-expected.checksum:
  • platform/mac/fast/overflow/image-selection-highlight-expected.png:
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum:
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png:
  • platform/mac/fast/overflow/overflow-rtl-expected.checksum:
  • platform/mac/fast/overflow/overflow-rtl-expected.png:
  • platform/mac/fast/overflow/overflow-stacking-expected.checksum:
  • platform/mac/fast/overflow/overflow-stacking-expected.png:
  • platform/mac/fast/overflow/overflow-text-hit-testing-expected.checksum:
  • platform/mac/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum:
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.checksum:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/mac/fast/overflow/scrollbar-position-update-expected.checksum:
  • platform/mac/fast/overflow/scrollbar-position-update-expected.png:
  • platform/mac/fast/overflow/table-overflow-float-expected.checksum:
  • platform/mac/fast/overflow/table-overflow-float-expected.png:
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum:
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum:
  • platform/mac/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/mac/fast/table/edge-offsets-expected.checksum:
  • platform/mac/fast/table/edge-offsets-expected.png:
  • platform/mac/scrollbars/key-window-not-first-responder-expected.checksum:
  • platform/mac/scrollbars/key-window-not-first-responder-expected.png:
  • platform/mac/svg/custom/invisible-text-after-scrolling-expected.checksum:
  • platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/mac/tables/mozilla/bugs/bug149275-1-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
21:38 WebKit Team edited by jorlow@chromium.org
(diff)
21:15 Changeset [53837] by jorlow@chromium.org
  • 2 edits in trunk/WebKitTools

Adding myself as reviewer. No review necessary.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-25

  • Scripts/webkitpy/committers.py:
18:17 Changeset [53836] by andersca@apple.com
  • 8 edits in trunk/WebKit/mac

Featureless build fixes.

  • Misc/WebCache.mm:

(+[WebCache empty]):

  • WebCoreSupport/WebApplicationCache.mm:
  • WebCoreSupport/WebChromeClient.h:
  • WebView/WebDataSource.mm:

(-[WebDataSource _transferApplicationCache:]):

  • WebView/WebFrame.mm:

(-[WebFrame _cacheabilityDictionary]):

  • WebView/WebView.mm:

(WebKitInitializeApplicationCachePathIfNecessary):
(-[WebView _close]):

  • WebView/WebViewData.mm:

(-[WebViewPrivate dealloc]):
(-[WebViewPrivate finalize]):

18:07 Changeset [53835] by enrica@apple.com
  • 7 edits
    3 adds in trunk

WebCore: Cleanup unwanted tags after pasting.
https://bugs.webkit.org/show_bug.cgi?id=34148

Reviewed by Darin Adler.

Test: editing/pasteboard/paste-noscript-xhtml.xhtml

  • dom/Element.cpp:

(WebCore::Element::setAttributeNS):

  • dom/Element.h:
  • dom/XMLTokenizer.h:
  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::handleElementNamespaces):
(WebCore::handleElementAttributes):
(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::endElementNs):
(WebCore::parseXMLDocumentFragment):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::createContextualFragment):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=34148

Reviewed by Darin Adler.

  • editing/pasteboard/paste-noscript-xhtml-expected.txt: Added.
  • editing/pasteboard/paste-noscript-xhtml.xhtml: Added.
  • editing/resources/htmlcontent.html: Added.
17:24 Changeset [53834] by sfalken@apple.com
  • 9 edits in trunk

2010-01-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Simon Fraser.

A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145

  • WebCoreSupport/WebGeolocationControllerClient.cpp: (WebGeolocationControllerClient::geolocationDestroyed): Added.
  • WebCoreSupport/WebGeolocationControllerClient.h:

2010-01-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Simon Fraser.

A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145

  • WebCoreSupport/WebGeolocationControllerClient.h:
  • WebCoreSupport/WebGeolocationControllerClient.mm: (WebGeolocationControllerClient::geolocationDestroyed):

2010-01-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Simon Fraser.

A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145

  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
  • page/GeolocationControllerClient.h:
17:07 Changeset [53833] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r52527.

17:03 Changeset [53832] by mrowe@apple.com
  • 1 edit in branches/safari-4-branch/WebCore/plugins/PluginView.cpp

Merge r53581.

17:02 Changeset [53831] by mrowe@apple.com
  • 1 edit in branches/safari-4-branch/WebCore/ChangeLog

Merge r53581.

16:44 Changeset [53830] by mrowe@apple.com
  • 5 edits
    1 add in branches/safari-4-branch

Merge r46792.

16:36 Changeset [53829] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r50698.

16:33 Changeset [53828] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r52073.

16:28 Changeset [53827] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r48810.

16:09 Changeset [53826] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r51877.

16:06 Changeset [53825] by mrowe@apple.com
  • 5 edits in branches/safari-4-branch/WebKit/mac

Merge r53520.

16:00 Changeset [53824] by mrowe@apple.com
  • 4 edits in branches/safari-4-branch/WebKit

Merge r53195.

15:55 Changeset [53823] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-4-branch

Merge r51727.

15:53 Changeset [53822] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/JavaScriptCore

Merge r53089.

15:53 Changeset [53821] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebCore

Merge r51881.

15:52 Changeset [53820] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-25 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Improve portability of select-item-background-clip.html
https://bugs.webkit.org/show_bug.cgi?id=34072

  • fast/forms/select-item-background-clip.html: Calculate the pixel height at runtime.
15:49 Changeset [53819] by mrowe@apple.com
  • 2 edits in branches/safari-4-branch/WebKit/mac

Merge r51616.

15:47 Changeset [53818] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-4-branch/WebCore

Merge r51205.

15:26 Changeset [53817] by mrowe@apple.com
  • 13 edits in branches/safari-4-branch

Merge r52749.

15:20 Changeset [53816] by dglazkov@chromium.org
  • 7 edits in trunk/LayoutTests

2010-01-25 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, trivial baseline updates.

-webkit-gradient slows down scrolling when page has horizontal scrollbar
https://bugs.webkit.org/show_bug.cgi?id=19650

Update pixel baselines. They changed slightly after http://trac.webkit.org/changeset/53318/
landed.

  • platform/mac/fast/gradients/border-image-gradient-expected.checksum:
  • platform/mac/fast/gradients/border-image-gradient-expected.png:
  • platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum:
  • platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/mac/fast/gradients/simple-gradients-expected.checksum:
  • platform/mac/fast/gradients/simple-gradients-expected.png:
15:12 Changeset [53815] by dimich@chromium.org
  • 2 edits in trunk/JavaScriptCore

Fix Chromium Linux tests: the pthread functions on Linux produce segfault if they receive 0 thread handle.
After r53714, we can have 0 thread handles passed to pthread_join and pthread_detach if corresponding threads
were already terminated and their threadMap entries cleared.
Add a 0 check.

Reviewed by David Levin.

  • wtf/ThreadingPthreads.cpp:

(WTF::waitForThreadCompletion):
(WTF::detachThread):

15:07 Changeset [53814] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

Fixed bug in positioning of scroll layer within the
parent root layer.
https://bugs.webkit.org/show_bug.cgi?id=33847

13:55 WebKit Team edited by michelangelo@webkit.org
(diff)
13:47 WebKit Team edited by michelangelo@webkit.org
(diff)
12:54 WebKit Team edited by bfulgham@webkit.org
Added some (unsubstantiated) claims about what I know. (diff)
12:37 Changeset [53813] by ap@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=34076
An image remains accessible via form.property syntax after being removed from document.

Fix crashing regression tests (tables/mozilla/bugs/bug4527.html et al.)

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree): Remove incorrect assertions added in the previous patch - it's mot true that m_for is always a parent; table parsing can reparent the image element, but m_form still needs to be set.
12:07 Changeset [53812] by ap@apple.com
  • 4 edits
    4 adds in trunk

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=34076
An image remains accessible via form.property syntax after being removed from document.

Tests: fast/forms/removed-image-as-property.html

fast/forms/reparented-image-as-property.html

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): This is called during GC - not a good time to make observable changes to DOM. (WebCore::HTMLImageElement::insertedIntoTree): This is the right place to do any work that depends on connectedness to some ancestor. We still allow for m_form to be set via constructor, which happens during parsing. (WebCore::HTMLImageElement::removedFromTree): Ditto.
  • html/HTMLImageElement.h: Added removedFromTree/insertedIntoTree, moved removedFromDocument and insertedIntoDocument to private section, as they shouldn't be called directly.
12:03 Changeset [53811] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-01-25 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=34073

Fixes misspelled words in comments.

  • accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper detach]): (AXAttributeStringSetElement):
  • bindings/js/JSDOMBinding.cpp: (WebCore::completeURL):
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
  • bindings/js/JSSVGPODTypeWrapper.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bridge/NP_jsobject.cpp: (_NPN_SetException):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
  • bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::detach):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • dom/Element.h:
  • dom/MessagePortChannel.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
  • dom/Node.cpp: (WebCore::Node::isFocusable): (WebCore::Node::shadowAncestorNode):
  • dom/Node.h:
  • dom/Position.cpp: (WebCore::Position::upstream):
  • dom/Position.h:
  • dom/Range.cpp: (WebCore::Range::processContents):
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::reconcileTextDecorationProperties): (WebCore::StyleChange::extractTextStyles): (WebCore::prepareEditingStyleToApplyAt):
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd):
  • editing/Editor.cpp: (WebCore::Editor::learnSpelling):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
  • loader/Cache.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable):
  • loader/CachedResource.h:
  • loader/CachedResourceHandle.h:
  • loader/DocumentLoader.h:
  • loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel):
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
  • notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::):
  • page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations):
  • platform/LinkHash.cpp: (WebCore::cleanPath):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::calculateDrawingMode):
  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition):
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::ensureStructuralLayer):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
  • platform/text/TextEncodingDetectorICU.cpp: (WebCore::detectTextEncoding):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::stateChanged):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildTextChunks):
  • rendering/TransformState.cpp: (WebCore::TransformState::flattenWithTransform):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::suggestedValue):
11:34 WebKit Team edited by darin@chromium.org
(diff)
11:32 WebKit Team edited by darin@chromium.org
(diff)
11:26 Changeset [53810] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-25 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Add new inspector test added in r53807 to skip
list on qt platform.

  • platform/qt/Skipped:
11:20 Changeset [53809] by dbates@webkit.org
  • 62 edits in trunk/WebCore

2010-01-25 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=34073

Fixes misspelled words in comments.

  • accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper detach]): (AXAttributeStringSetElement):
  • bindings/js/JSDOMBinding.cpp: (WebCore::completeURL):
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
  • bindings/js/JSSVGPODTypeWrapper.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bridge/NP_jsobject.cpp: (_NPN_SetException):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
  • bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::detach):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • dom/Element.h:
  • dom/MessagePortChannel.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
  • dom/Node.cpp: (WebCore::Node::isFocusable): (WebCore::Node::shadowAncestorNode):
  • dom/Node.h:
  • dom/Position.cpp: (WebCore::Position::upstream):
  • dom/Position.h:
  • dom/Range.cpp: (WebCore::Range::processContents):
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::reconcileTextDecorationProperties): (WebCore::StyleChange::extractTextStyles): (WebCore::prepareEditingStyleToApplyAt):
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd):
  • editing/Editor.cpp: (WebCore::Editor::learnSpelling):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
  • loader/Cache.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable):
  • loader/CachedResource.h:
  • loader/CachedResourceHandle.h:
  • loader/DocumentLoader.h:
  • loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel):
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
  • notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::):
  • page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations):
  • platform/LinkHash.cpp: (WebCore::cleanPath):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::calculateDrawingMode):
  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition):
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::ensureStructuralLayer):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
  • platform/text/TextEncodingDetectorICU.cpp: (WebCore::detectTextEncoding):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::stateChanged):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildTextChunks):
  • rendering/TransformState.cpp: (WebCore::TransformState::flattenWithTransform):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::suggestedValue):
10:58 Changeset [53808] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Suggested by Darin Adler.

Fixed a spelling error, tightened up some grammar.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):

10:57 Changeset [53807] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Test that Web Inspector doesn't change methods declared by the inspected
page.
https://bugs.webkit.org/show_bug.cgi?id=34089

  • inspector/inspected-objects-not-overriden-expected.txt: Added.
  • inspector/inspected-objects-not-overriden.html: Added.

2010-01-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Instead of adding inspector methods to the inspected global objects
use private implementation visible from inspector code only.
https://bugs.webkit.org/show_bug.cgi?id=34089

Test: inspector/inspected-objects-not-overriden.html

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
08:37 QtWebKitBackportingFixes edited by benjamin.poulain@nokia.com
(diff)
08:06 Changeset [53806] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2010-01-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: don't show headers/content tabs in scripts view.

https://bugs.webkit.org/show_bug.cgi?id=34083

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.set headersVisible): (WebInspector.ResourceView.prototype._selectContentTab): (WebInspector.ResourceView.prototype._innerSelectContentTab):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype.showResource):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/inspector.css:
07:37 Changeset [53805] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-25 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

[Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
https://bugs.webkit.org/show_bug.cgi?id=34086

  • platform/gtk/Skipped: Skipping the test, requires investigation on the failure.
07:24 Changeset [53804] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-25 Simon Hausmann <hausmann@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Reduce the size of the library when compiling for Maemo5
https://bugs.webkit.org/show_bug.cgi?id=34050

Exclude the Web Inspector's qrc file in the Maemo5 build, just
like we do for the Symbian build. Saves about ~900k.

  • WebCore.pro:
07:08 Changeset [53803] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-01-25 Simon Hausmann <hausmann@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] In the StyledPainter determine the style from the Render and Scrollbar theme instead of from the paint device
https://bugs.webkit.org/show_bug.cgi?id=34054

Getting the style from the painter's paint device is a hack that breaks when
the paint device's style is different than the style that is used when
calculating the metries earlier when there is no painter available.

This change moves us closer to always using the same style.

  • platform/qt/RenderThemeQt.cpp: (WebCore::StylePainter::StylePainter): (WebCore::StylePainter::init): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): (WebCore::RenderThemeQt::paintSliderTrack): (WebCore::RenderThemeQt::paintMediaMuteButton): (WebCore::RenderThemeQt::paintMediaPlayButton): (WebCore::RenderThemeQt::paintMediaSliderTrack): (WebCore::RenderThemeQt::paintMediaSliderThumb):
  • platform/qt/RenderThemeQt.h:
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint): (WebCore::ScrollbarThemeQt::hitTest): (WebCore::ScrollbarThemeQt::shouldCenterOnThumb): (WebCore::ScrollbarThemeQt::scrollbarThickness): (WebCore::ScrollbarThemeQt::thumbLength): (WebCore::ScrollbarThemeQt::trackPosition): (WebCore::ScrollbarThemeQt::trackLength): (WebCore::ScrollbarThemeQt::paintScrollCorner): (WebCore::ScrollbarThemeQt::style):
  • platform/qt/ScrollbarThemeQt.h:
06:42 Changeset [53802] by eric@webkit.org
  • 6 edits in trunk

2010-01-25 Simon Hausmann <hausmann@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
https://bugs.webkit.org/show_bug.cgi?id=34053

  • platform/qt/QWebPageClient.h: Add function to return the style.
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::qStyle): Determine the style from the page client instead of the page's view.

2010-01-25 Simon Hausmann <hausmann@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
https://bugs.webkit.org/show_bug.cgi?id=34053

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::style): Implement QWebPageClient::style() and return the graphics widget's style.
  • Api/qwebpage.cpp: (QWebPageWidgetClient::style): Implement QWebPageClient::style() and return the widget's style.
06:20 Changeset [53801] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Clean up code to determine palette from page client in RenderThemeQt
https://bugs.webkit.org/show_bug.cgi?id=34052

Patch by Simon Hausmann <hausmann@webkit.org> on 2010-01-25
Reviewed by Kenneth Christiansen.

Use the RenderTheme's associated page instead of going through the
render tree and the document.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):

  • platform/qt/RenderThemeQt.h:
05:56 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:53 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:18 Changeset [53800] by hausmann@webkit.org
  • 2 edits in trunk

[Qt] Fix the build on Maemo5.

Reviewed by Laszlo Gombos.

https://bugs.webkit.org/show_bug.cgi?id=34051

  • WebKit.pri: Disable the use of uitools, just like it's done for Symbian.
05:14 Changeset [53799] by eric@webkit.org
  • 3 edits
    1 add in trunk

2010-01-25 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

[Qt] Phone backup support for QtWebkit for Symbian devices.
https://bugs.webkit.org/show_bug.cgi?id=34077

  • WebCore.pro:

2010-01-25 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

[Qt] Phone backup support for QtWebkit for Symbian devices.
https://bugs.webkit.org/show_bug.cgi?id=34077

  • symbian/backup_registration.xml: Added.
05:13 Changeset [53798] by yurys@chromium.org
  • 2 edits
    3 copies
    2 adds in trunk/LayoutTests

2010-01-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Update inspector test expectations. Line number and source
name are present only in Chromium when console message is
logged before document load is completed.

https://bugs.webkit.org/show_bug.cgi?id=34078

  • platform/chromium/inspector/console-log-before-inspector-open-expected.txt: Added.
  • platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
  • platform/mac/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
  • platform/win/inspector/console-log-before-inspector-open-expected.txt: Renamed from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
04:57 QtWebKitBackportingFixes edited by koshuin@gmail.com
(diff)
04:37 Changeset [53797] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-01-25 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Antti Koivisto.

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

  • page/FrameView.cpp: (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::registerFixedPositionedObject): (WebCore::FrameView::unregisterFixedPositionedObject): (WebCore::FrameView::scrollContentsFastPath):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
  • platform/ScrollView.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::destroy):
04:20 WebKit Team edited by cjerdonek@webkit.org
Fixed mangled special character and added missing quote. (diff)
04:16 WebKit Team edited by cjerdonek@webkit.org
Added introduction and key. (diff)
03:43 WebKit Team edited by cjerdonek@webkit.org
Restored page outline. (diff)
03:18 Changeset [53796] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-25 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

Improved prepare-ChangeLog so that it preserves the relative
indentation of a git commit message.

https://bugs.webkit.org/show_bug.cgi?id=34058

  • Scripts/prepare-ChangeLog:
    • Also adjusted the script so that it does not add white space characters to empty lines.
02:58 Changeset [53795] by pfeldman@chromium.org
  • 9 edits
    1 add in trunk/WebCore

2010-01-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add support for addMessage/clearMessages to SourceFrame2.

https://bugs.webkit.org/show_bug.cgi?id=33904

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/SourceFrame2.js: (WebInspector.SourceFrame2): (WebInspector.SourceFrame2.prototype.addMessage): (WebInspector.SourceFrame2.prototype.clearMessages): (WebInspector.SourceFrame2.prototype._incrementMessageRepeatCount): (WebInspector.SourceFrame2.prototype._addExistingMessagesToSource): (WebInspector.SourceFrame2.prototype._addMessageToSource): (WebInspector.SourceFrame2.prototype.resize):
  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._lineHeight): (WebInspector.TextEditor.prototype._highlightChanged): (WebInspector.TextEditor.prototype.packAndRepaintAll): (WebInspector.TextEditor.prototype._updateSize): (WebInspector.TextEditor.prototype._repaintAll): (WebInspector.TextEditor.prototype._paint): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._mouseOut): (WebInspector.TextEditor.prototype._updateDivDecorations): (WebInspector.TextEditor.prototype._positionDivDecoration): (WebInspector.TextEditor.prototype._paintSelection): (WebInspector.TextEditor.prototype._replaceSelectionWith):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/textEditor.css: Added.
02:37 Changeset [53794] by pfeldman@chromium.org
  • 9 edits in trunk/WebCore

2010-01-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Replace split pane with tabbed pane in resource
contents view.

https://bugs.webkit.org/show_bug.cgi?id=32453

01:43 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
00:45 WebKit Team edited by hausmann@webkit.org
(diff)
00:02 WebKit Team edited by krit@webkit.org
(diff)

01/24/10:

23:04 Changeset [53793] by rolandsteiner@chromium.org
  • 17 edits in trunk/LayoutTests

build fix: rubber-stamped by Eric Seidel.

Fix expected baselines for ruby layout tests on Windows.

  • platform/win/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/win/fast/ruby/ruby-length-expected.txt:
  • platform/win/fast/ruby/ruby-run-break-expected.txt:
  • platform/win/fast/ruby/ruby-runs-expected.txt:
  • platform/win/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/win/fast/ruby/ruby-simple-expected.txt:
  • platform/win/fast/ruby/ruby-simple-rp-expected.txt:
  • platform/win/fast/ruby/ruby-trailing-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt:
22:21 Changeset [53792] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

2010-01-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Media element duration changes to zero after playing in reverse
https://bugs.webkit.org/show_bug.cgi?id=34041

Test: media/video-reverse-play-duration.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::didEnd): QTKit's ended notification fires at time zero when playing in reverse, so don't reset duration in that case.

2010-01-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Media element duration changes to zero after playing in reverse
https://bugs.webkit.org/show_bug.cgi?id=34041

  • media/video-reverse-play-duration-expected.txt: Added.
  • media/video-reverse-play-duration.html: Added.
22:05 WebKit Team edited by abarth@webkit.org
(diff)
22:00 WebKit Team edited by abarth@webkit.org
(diff)
21:55 WebKit Team edited by abarth@webkit.org
(diff)
21:50 Changeset [53791] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

Bug 28420 - Re-enable ruby Windows layout tests
(https://bugs.webkit.org/show_bug.cgi?id=28420, patch 5b)

Reviewed by Maciej Stachowiak.

After creating new Latin-character-only layout tests for ruby
(https://bugs.webkit.org/show_bug.cgi?id=31865) and resolving the issue
that caused layout tests to fail then due to the addition of the ruby
layout tests (cf. https://bugs.webkit.org/show_bug.cgi?id=31200, problem
not actually caused by ruby), the ruby layout tests should als be
un-skipped for the Windows platform.

  • platform/win/Skipped:
21:50 WebKit Team edited by abarth@webkit.org
(diff)
21:43 WebKit Team edited by abarth@webkit.org
(diff)
21:31 WebKit Team edited by abarth@webkit.org
(diff)
21:25 WebKit Team edited by abarth@webkit.org
(diff)
21:17 WebKit Team edited by abarth@webkit.org
(diff)
20:11 Changeset [53790] by mjs@apple.com
  • 3 edits
    2 adds in trunk

2010-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Content with heavily nested residual style is so slow, it seems like a hang
https://bugs.webkit.org/show_bug.cgi?id=34059
<rdar://problem/7292906>


Test cast: fast/parser/residual-style-hang.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Limit the number of iterations of the main loop to 5.


The reason this limit is necessary is that otherwise, N misnested open tags followed
by N misnested close tags will cause O(N2) of work due to cloning and attaching subtrees;
at a fixed limit, the cost is at worst O(N).


The code that was in the loop originally ran exactly once - the loop was added in
r21472 to fix <https://bugs.webkit.org/show_bug.cgi?id=13603>. I have verified that
with the iteration limit, the bug is still fixed, both with the original test case
and with the layout tests tht were added.

2010-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Content with heavily nested residual style is so slow, it seems like a hang
https://bugs.webkit.org/show_bug.cgi?id=34059
<rdar://problem/7292906>

Test case for the above bug fix.

  • fast/parser/residual-style-hang-expected.txt: Added.
  • fast/parser/residual-style-hang.html: Added.
19:53 Changeset [53789] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Maciej Stachowiak.

Refactor JITStubs.cpp so that DEFINE_STUB_FUNCTION is only used once for each function
https://bugs.webkit.org/show_bug.cgi?id=33866

Place the guard USE(JSVALUE32_64) inside the body of the DEFINE_STUB_FUNCTION
macro for those functions that are always present.

  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
19:26 Changeset [53788] by eric@webkit.org
  • 2 edits
    2 adds
    3 deletes in trunk/LayoutTests

2010-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Improve portability of listbox-selection-2.html
https://bugs.webkit.org/show_bug.cgi?id=33994

  • Convert to dumpAsText().
  • Determine the height of an item at runtime
  • fast/forms/listbox-selection-2-expected.txt: Added.
  • fast/forms/listbox-selection-2.html:
  • fast/forms/script-tests/listbox-selection-2.js
  • platform/mac/fast/forms/listbox-selection-2-expected.checksum: Removed.
  • platform/mac/fast/forms/listbox-selection-2-expected.png: Removed.
  • platform/mac/fast/forms/listbox-selection-2-expected.txt: Removed.
18:15 Changeset [53787] by tkent@chromium.org
  • 7 edits in trunk

2010-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::valueAsDate setter support for type=week.
https://bugs.webkit.org/show_bug.cgi?id=33986

Add setter tests to input-valueasdate-datetime.js, and update the
expectation.

  • fast/forms/input-valueasdate-week-expected.txt:
  • fast/forms/script-tests/input-valueasdate-week.js:

2010-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::valueAsDate setter support for type=week.
https://bugs.webkit.org/show_bug.cgi?id=33986

Introduce ISODateTime::setMillisecondsSinceEpochForWeek() and add
Week type support to ISODateTime::toString().

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Avoid default:. (WebCore::HTMLInputElement::setValueAsDate): Add WEEK type handling and avoid default:.
  • html/ISODateTime.cpp: (WebCore::offsetTo1stWeekStart): (WebCore::ISODateTime::setMillisecondsSinceEpochForWeek): (WebCore::ISODateTime::millisecondsSinceEpoch): (WebCore::ISODateTime::toString): Add Week type support and avoid default:.
  • html/ISODateTime.h:
16:41 WebKit Team edited by ddkilzer@webkit.org
(diff)
16:15 WebKit Team edited by michelangelo@webkit.org
(diff)
14:54 Changeset [53786] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-24 Eric Carlson <eric.carlson@apple.com>

No review, build fix.

Only log the first 'timeupdate' event from audio-delete-while-slider-thumb-clicked.html
as the number fired can vary according to how long it takes to run the test.

  • media/audio-delete-while-slider-thumb-clicked.html:
14:54 Changeset [53785] by oliver@apple.com
  • 6 edits in trunk/WebCore

2010-01-24 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Object Serialization assumes deserialization will always occur in the context of a webpage
https://bugs.webkit.org/show_bug.cgi?id=34056
rdar://7573833

Added ClassInfo to JSDOMGlobalObject and make the window and worker class info
inherit from it. With this in place we're able to determine whether a given
global object is a DOMGlobalObject, and then use that information to avoid
attempting to deserialize types that require the presence of the DOM.

No test as all global objects in webkit inherit from JSDOMGlobalObject.

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::classInfo):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::):
  • bindings/js/JSWorkerContextBase.cpp: (WebCore::):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::DeserializingTreeWalker::DeserializingTreeWalker): (WebCore::DeserializingTreeWalker::convertIfTerminal):
14:30 Changeset [53784] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-01-24 Eric Seidel <eric@webkit.org>

No review.

Middle clicking the primary scroll bars on Chromium Linux triggers a paste event
https://bugs.webkit.org/show_bug.cgi?id=33062

  • platform/gtk/Skipped:
    • This new test fails on Gtk for unknown reasons.
    • Skipping for now to make the bots green, until a Gtk person can look.
14:15 Changeset [53783] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-24 Eric Seidel <eric@webkit.org>

No review, rolling out r53763.
http://trac.webkit.org/changeset/53763
https://bugs.webkit.org/show_bug.cgi?id=33895

Broke 20+ tests on Windows.

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
14:05 WebKit Team edited by jpetsovits@rim.com
(diff)
13:05 Changeset [53782] by cjerdonek@webkit.org
  • 3 edits in trunk/WebKitSite

Added to contributing code page a pointer to the preferred
license text. Also added information about copyright lines.

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=34017

  • coding/contributing.html:
  • css/main.css:
    • Added CSS class for books.
11:42 Changeset [53781] by simon.fraser@apple.com
  • 4 edits in trunk/LayoutTests

2010-01-24 Simon Fraser <simon.fraser@apple.com>

No review.

Fix incorrect layout test that I checked in earlier.

  • platform/mac/compositing/reflections/load-video-in-reflection-expected.checksum:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.txt:
10:22 Changeset [53780] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

2010-01-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=34047
<rdar://problem/7573699>
Media element "endedPlayback" logic doesn't match spec

Test: media/video-timeupdate-reverse-play.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::ended): The 'ended' attribute should only be true when playback rate is positive. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Always schedule a 'timeupdate' event when the media engine signals a time discontinuity, scheduleTimeupdateEvent will only queue an event if one hasn't already been posted for the current movie time. (WebCore::HTMLMediaElement::endedPlayback): Update to match the spec logic.

2010-01-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=34047
<rdar://problem/7573699>
Media element "endedPlayback" logic doesn't match spec

  • media/video-timeupdate-reverse-play-expected.txt: Added.
  • media/video-timeupdate-reverse-play.html: Added.
09:47 Changeset [53779] by simon.fraser@apple.com
  • 4 edits
    4 adds in trunk

2010-01-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Video that loads inside reflection doesn't get reflected
https://bugs.webkit.org/show_bug.cgi?id=34046

ensureCloneLayers() made an incorrect assumption that if a clone of the primaryLayer
exists already, then the structural layer and content layer can just be returned.
However, this doesn't account for the situation where a content layer may have
been create after the clone tree was last updated.

Fix by always creating the structural and clone layers on demand.

Test: compositing/reflections/load-video-in-reflection.html

  • platform/graphics/mac/GraphicsLayerCA.h: Added utility method, findOrMakeClone().
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::findOrMakeClone): Utility that efficiently finds or creates a layer in a LayerMap. (WebCore::GraphicsLayerCA::ensureCloneLayers): Always look for or clone the structural and content layers, rather than relying on whether there's a primary layer clone already.
04:25 Changeset [53778] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

Rubber stamped by Eric Seidel.

More pep8 compliance.

  • Scripts/webkitpy/mock_bugzillatool.py:
04:16 Changeset [53777] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

Rubber stamped by Eric Seidel.

More pep8 compliance.

  • Scripts/webkitpy/executive.py:
  • Scripts/webkitpy/grammar.py:
03:57 Changeset [53776] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

Rubber stamped by Eric Seidel.

More pep8 compliance.

  • Scripts/webkitpy/comments.py:
  • Scripts/webkitpy/committers.py:
  • Scripts/webkitpy/credentials.py:
03:48 Changeset [53775] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

Rubber stamped by Eric Seidel.

Make changelogs.py pass pep8.

  • Scripts/webkitpy/changelogs.py:

01/23/10:

23:44 Changeset [53774] by oliver@apple.com
  • 6 edits in trunk

2010-01-23 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Implement support for FileList cloning in postMessage
https://bugs.webkit.org/show_bug.cgi?id=34048

Add test for passing a FileList through postMessage, and
correct testing already present to test what it was meant
to be.

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:

2010-01-23 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Implement support for FileList cloning in postMessage
https://bugs.webkit.org/show_bug.cgi?id=34048

Support passing FileList through postMessage APIs. Basically
mechanical task in line with other terminals in the object
graph.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedFileList::create): (WebCore::SerializedFileList::length): (WebCore::SerializedFileList::item): (WebCore::SerializedFileList::SerializedFileList): (WebCore::SerializedScriptValueData::SerializedScriptValueData): (WebCore::SharedSerializedData::asFileList): (WebCore::SerializingTreeWalker::convertIfTerminal): (WebCore::DeserializingTreeWalker::convertIfTerminal): (WebCore::TeardownTreeWalker::convertIfTerminal):

Rearrange these functions to not use 'default:' handling
so that the compiler will actually tell us when we're
not handling cases.

  • bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValueData::): (WebCore::SerializedScriptValueData::asFileList):
17:50 Changeset [53773] by mitz@apple.com
  • 3 edits
    1 delete in trunk

<rdar://problem/7569820> svg/custom/text-zoom.xhtml fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=34006

Reviewed by Maciej Stachowiak.

WebKit/win:

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey
with a default value of true.

LayoutTests:

  • platform/win/svg/custom/text-zoom-expected.txt: Removed.
13:53 Changeset [53772] by kenneth@webkit.org
  • 3 edits in trunk/WebKitTools

[Qt] Unreviewed build fix

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/webinspector.h:
13:40 Changeset [53771] by kenneth@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

Rubberstamped by Simon Hausmann.

[Qt] Move the WebInspector class to it's own header file.

  • QtLauncher/main.cpp:
  • QtLauncher/webinspector.h: Added.

(WebInspector::WebInspector):
(WebInspector::showEvent):
(WebInspector::hideEvent):

08:54 Changeset [53770] by eric@webkit.org
  • 6 edits in trunk

2010-01-23 Robert Hogan <robert@roberthogan.net>

Reviewed by Kenneth Rohde Christiansen.

Qt DRT: respect window.close() and window.closed()

Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().

This fixes the following tests:

plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html

https://bugs.webkit.org/show_bug.cgi?id=32953

  • platform/qt/Skipped:

2010-01-23 Robert Hogan <robert@roberthogan.net>

Reviewed by Kenneth Rohde Christiansen.

Qt DRT: respect window.close() and window.closed()

Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().

This fixes the following tests:

plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html

https://bugs.webkit.org/show_bug.cgi?id=32953

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::createWindow): (WebCore::DumpRenderTree::windowCloseRequested):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::maybeDump):
08:37 Changeset [53769] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-01-23 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix positioning of ComboBox popup in QGraphicsWebView.

Wrap the popup in a QGraphicsProxyWidget, so that the popup
transforms with the item.

https://bugs.webkit.org/show_bug.cgi?id=33887

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show):
  • WebCoreSupport/QtFallbackWebPopup.h:
08:08 Changeset [53768] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2010-01-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Carlson.

Race condition in video setup can force videos into software mode
https://bugs.webkit.org/show_bug.cgi?id=34034

We used to call setUpVideoRendering() unconditionally from
acceleratedRenderingStateChanged(); this could happen before the movie had any
data, and thus force the movie into software rendering mode.

Fix by returning early from setUpVideoRendering() if isReadyForRendering() returns false,
which also allows us to remove some other checks for being ready to render.

Timing dependent, hard to make a test for.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToMedia): Optimize to do an early return if passing in the same layer that is already being used.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setUpVideoRendering): Return without doing anything if not ready to render. (WebCore::MediaPlayerPrivate::updateStates): No need to call isReadyForRendering() any more, since setUpVideoRendering() does that. (WebCore::MediaPlayerPrivate::setVisible): No need to check the ready state; this is equivalent to the check inside of setUpVideoRendering().
03:43 Changeset [53767] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-01-23 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Add new inspector test added in r53766 to skipi
list on qt platform.

  • platform/qt/Skipped:
02:13 Changeset [53766] by yurys@chromium.org
  • 44 edits
    2 adds in trunk

2010-01-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=32554

Test: inspector/console-log-before-inspector-open.html

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::databaseForId): (WebCore::JSInjectedScriptHost::currentCallFrame): (WebCore::JSInjectedScriptHost::nodeForId): (WebCore::JSInjectedScriptHost::pushNodePathToFrontend): (WebCore::JSInjectedScriptHost::selectDatabase): (WebCore::JSInjectedScriptHost::selectDOMStorage):
  • bindings/js/ScriptCallStack.h: (WebCore::ScriptCallStack::globalState):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptObject.h: (WebCore::ScriptObject::scriptState):
  • bindings/js/ScriptValue.cpp:
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::globalState):
  • bindings/v8/ScriptObject.h: (WebCore::ScriptObject::scriptState):
  • bindings/v8/ScriptValue.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setInjectedScriptSource): (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::releaseWrapperObjectGroup):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::pausedScript):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages): (WebInspector.ConsoleView.prototype.doEvalInWindow):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parseRule):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged.InjectedScriptAccess.get addInspectedNode): (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.setDocument): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
  • inspector/front-end/EventListenersSidebarPane.js: ():
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess): (InjectedScriptAccess.getDefault): (get InjectedScriptAccess): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane): (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback):
  • inspector/front-end/ObjectPropertiesSection.js:
  • inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.pausedScript): (WebInspector.addConsoleMessage): (WebInspector.log.logMessage): (WebInspector.log):

2010-01-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.

Test that web inspector doesn't crash when opening if there are messages in
the console. Refactor test case due to InjectedScriptAccess changes.

https://bugs.webkit.org/show_bug.cgi?id=32554

  • inspector/console-log-before-inspector-open-expected.txt: Added.
  • inspector/console-log-before-inspector-open.html: Added.
  • inspector/styles-iframe.html:
01:51 Changeset [53765] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Added a user default for specifying a fallback frameworks path in case
the bundle does not contain frameworks for the current Mac OS X version.

Reviewed by Mark Rowe.

  • WebKitLauncher/main.m:

(fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
keyed by the FallbackSystemVersions user default and returns it.
(main): If a frameworks directory for the current system version is not found,
try the fallback.

01/22/10:

23:11 Changeset [53764] by eric@webkit.org
  • 16 edits
    4 copies
    1 add in trunk

2010-01-22 Alex Milowski <alex@milowski.com>

Reviewed by David Hyatt.

Updated tests due to stylesheet changes.

  • platform/mac/mathml/presentation/sub-expected.checksum:
  • platform/mac/mathml/presentation/sub-expected.png:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.checksum:
  • platform/mac/mathml/presentation/sup-expected.png:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:

2010-01-22 Alex Milowski <alex@milowski.com>

Reviewed by David Hyatt.

Added support for RenderMathMLBlock base object and isRenderMathMLBlock()
method on RenderObject.

Added support for text elements and updated tag and attribute names

Also, updated the stylesheet added files to the project

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • css/mathml.css:
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/MathMLTextElement.cpp: Added. (WebCore::MathMLTextElement::MathMLTextElement): (WebCore::MathMLTextElement::create): (WebCore::MathMLTextElement::createRenderer):
  • mathml/MathMLTextElement.h: Added.
  • mathml/RenderMathMLBlock.cpp: Added. (WebCore::RenderMathMLBlock::RenderMathMLBlock): (WebCore::RenderMathMLBlock::styleDidChange): (WebCore::RenderMathMLBlock::isChildAllowed): (WebCore::RenderMathMLBlock::makeBlockStyle): (WebCore::RenderMathMLBlock::nonOperatorHeight): (WebCore::RenderMathMLBlock::stretchToHeight):
  • mathml/RenderMathMLBlock.h: Added. (WebCore::RenderMathMLBlock::isRenderMathMLBlock): (WebCore::RenderMathMLBlock::isRenderMathMLOperator): (WebCore::RenderMathMLBlock::isRenderMathMLRow): (WebCore::RenderMathMLBlock::isRenderMathMLMath): (WebCore::RenderMathMLBlock::hasBase): (WebCore::toRenderMathMLBlock):
  • mathml/mathattrs.in: Added.
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderMathMLBlock):
22:51 Changeset [53763] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Make run-webkit-tests work under Cygwin for the Qt port

setPathForRunningWebKitApp() is implemented for the Qt port
by using qmake to query for the location of the Qt libraries.

This requires the original environment (%ENV) to be untouched,
so launchWithCurrentEnv() was refactored to launchWithEnv(),
and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
instead. This has the added benefit of getting rid of the temp
variables used for storing the current env.

openDumpTool() is also refactored a bit into platform-spesific,
port-spesific, and generic environment variables.

Checks for undef was added a few places to fix Perl concat
warnings when run-webkit-tests is aborted.

https://bugs.webkit.org/show_bug.cgi?id=33895

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
22:35 Changeset [53762] by eric@webkit.org
  • 6 edits in trunk/LayoutTests

2010-01-22 Garret Kelly <gdk@chromium.org>

Reviewed by David Levin.

Fixing svg/custom/stroke-width-click.svg to not cause the double-click
handler to fire on certain platforms (chromium, for one). Chromium,
Leopard, and GTK all agree on the calculated extents of the shape, so I'm
disabling this test on mac-tiger and re-enabling it on mac-leopard and
updating the expected file to reflect the current state of the test.
https://bugs.webkit.org/show_bug.cgi?id=33865

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • svg/custom/stroke-width-click-expected.txt:
  • svg/custom/stroke-width-click.svg:
22:19 Changeset [53761] by eric@webkit.org
  • 11 edits
    4 adds in trunk

2010-01-22 James Robinson <jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

Adds tests for the 'selected' attribute of <option>s
https://bugs.webkit.org/show_bug.cgi?id=32641

HTMLOptionElement_selected2 checks that the selected attribute is up to date immediately after the <select>
parsed. HTMLOptionElement_selected3 does the same, but checks immediately prior to the </select>.

Also changes the expectation for add-remove-option-modification-event to reflect that we now pass.

  • fast/forms/HTMLOptionElement_selected-expected.txt:
  • fast/forms/HTMLOptionElement_selected.html:
  • fast/forms/HTMLOptionElement_selected2-expected.txt: Added.
  • fast/forms/HTMLOptionElement_selected2.html: Added.
  • fast/forms/HTMLOptionElement_selected3-expected.txt: Added.
  • fast/forms/HTMLOptionElement_selected3.html: Added.
  • fast/forms/add-remove-option-modification-event-expected.txt:

2010-01-22 James Robinson <jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

Ensures that the 'selected' attribute of an <option> is correct
https://bugs.webkit.org/show_bug.cgi?id=32641

Adds a check in OptionElement::selected() that checks if list items need to be recalculated and does so if needed,
so the attribute is up to date more often. Also gets rid of most of the recalcStyle() side effects.

Our behavior now matches Firefox 3.5 and IE8 after the </select> is parsed.

Tests: fast/forms/HTMLOptionElement_selected2.html

fast/forms/HTMLOptionElement_selected3.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::setOptionsChangedOnRenderer): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::restoreFormControlState): (WebCore::SelectElement::reset): (WebCore::SelectElement::typeAheadFind):
  • dom/SelectElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected): (WebCore::HTMLOptionElement::insertedIntoTree):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
  • html/HTMLSelectElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::recalcStyle):
21:43 Changeset [53760] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-22 Chris Rogers <crogers@google.com>

Reviewed by Eric Seidel.

Need to handle WebGLUnsignedByteArray as method argument for V8 binding
https://bugs.webkit.org/show_bug.cgi?id=33929

V8 code generator does not have associated tests

  • bindings/scripts/CodeGeneratorV8.pm:
21:27 Changeset [53759] by eric@webkit.org
  • 7 edits in trunk

2010-01-22 Elliot Glaysher <erg@chromium.org>

Reviewed by David Levin.

Chromium: theme selection colors to match gtk theme
Add functions to RenderThemeChromiumLinux to change the selection color
according to the current GTK+ theme.

Since the change is to the Chromium WebKit API layer, testing is done
in Chromium's test shell (see Chromium side of this patch:
http://codereview.chromium.org/554004)

https://bugs.webkit.org/show_bug.cgi?id=33921

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumLinux::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumLinux::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumLinux::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumLinux::setSelectionColors):
  • rendering/RenderThemeChromiumLinux.h: Adds static members.

2010-01-22 Elliot Glaysher <erg@chromium.org>

Reviewed by David Levin.

Chromium: theme selection colors to match gtk theme
Add functions to RenderThemeChromiumLinux to change the selection color
according to the current GTK+ theme.

Since the change is to the Chromium WebKit API layer, testing is done
in Chromium's test shell (see Chromium side of this patch:
http://codereview.chromium.org/554004)

https://bugs.webkit.org/show_bug.cgi?id=33921

  • public/WebView.h: Adds interface to change the selection colors
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setSelectionColors): Implements new interface.
  • src/WebViewImpl.h:
21:11 Changeset [53758] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-22 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by David Levin.

A new test to check that middle clicking on the primary scroll bars
does not trigger a paste event.
https://bugs.webkit.org/show_bug.cgi?id=33062

  • scrollbars/scrollbar-middleclick-nopaste-expected.txt: Added.
  • scrollbars/scrollbar-middleclick-nopaste.html: Added.

2010-01-22 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by David Levin.

Middle clicking the main scroll bars should not trigger a paste event
in Linux chromium.
https://bugs.webkit.org/show_bug.cgi?id=33062

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseUp):
21:09 UsingGitWithWebKit edited by cjerdonek@webkit.org
Added note about "commit-log-editor" and dcommit. (diff)
20:59 UsingGitWithWebKit edited by cjerdonek@webkit.org
Added note about squashing commits, if necessary, before dcommit. (diff)
20:42 Changeset [53757] by kevino@webkit.org
  • 17 edits in trunk

Reviewed by Kevin Ollivier.

[wx] Remove the Bakefile build system, which is no longer being used.

https://bugs.webkit.org/show_bug.cgi?id=34022

20:33 Changeset [53756] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Build fix after r53718.

20:18 Changeset [53755] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Update platform-specific test results following r53722

20:06 Changeset [53754] by kov@webkit.org
  • 3 edits
    2 adds in trunk

LayoutTests

2010-01-22 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Simon Fraser.

Checking in platform-specific results for test that is failing
because of an additional single pixel in size - the test passes,
when testing manually.

  • platform/gtk/svg/custom/text-zoom-expected.txt: Added.

WebKitTools

2010-01-22 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Simon Fraser.

Reset zoom level to 1.0 when resetting view state. This is causing
many tests to fail after svg/custom/text-zoom.xhtml changes the
zoom level.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
20:00 Changeset [53753] by sfalken@apple.com
  • 3 edits in trunk/LayoutTests

Roll out r53752 to fix bots.

19:46 Changeset [53752] by sfalken@apple.com
  • 3 edits in trunk/LayoutTests

Rubber-stamped by Cameron Zwarich.

Re-enable Geolocation tests on Mac.

  • platform/mac/Skipped:
  • platform/win/Skipped:
19:06 Changeset [53751] by sfalken@apple.com
  • 1 edit in trunk/WebCore/platform/GeolocationService.cpp

Mac build fix.

18:53 Changeset [53750] by sfalken@apple.com
  • 1 edit in trunk/WebCore/platform/mac/GeolocationServiceMac.mm

Build fix. Don't include CoreLocation-based Geolocation if CLIENT_BASED_GEOLOCATION is set.

18:34 Changeset [53749] by sfalken@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Build fix. Touch exp file to force it to rebuild via DerivedSources.make.

18:18 WikiStart edited by cjerdonek@webkit.org
Alphabetized Documentation pages to find them more easily (diff)
18:16 Changeset [53748] by pkasting@chromium.org
  • 1 edit
    1 delete in trunk/WebCore

Remove unnecessary copy of zlib.
https://bugs.webkit.org/show_bug.cgi?id=34028

Reviewed by Darin Adler.

  • platform/image-decoders/zlib: Removed.
  • platform/image-decoders/zlib/adler32.c: Removed.
  • platform/image-decoders/zlib/compress.c: Removed.
  • platform/image-decoders/zlib/crc32.c: Removed.
  • platform/image-decoders/zlib/crc32.h: Removed.
  • platform/image-decoders/zlib/deflate.c: Removed.
  • platform/image-decoders/zlib/deflate.h: Removed.
  • platform/image-decoders/zlib/gzio.c: Removed.
  • platform/image-decoders/zlib/infback.c: Removed.
  • platform/image-decoders/zlib/inffast.c: Removed.
  • platform/image-decoders/zlib/inffast.h: Removed.
  • platform/image-decoders/zlib/inffixed.h: Removed.
  • platform/image-decoders/zlib/inflate.c: Removed.
  • platform/image-decoders/zlib/inflate.h: Removed.
  • platform/image-decoders/zlib/inftrees.c: Removed.
  • platform/image-decoders/zlib/inftrees.h: Removed.
  • platform/image-decoders/zlib/mozzconf.h: Removed.
  • platform/image-decoders/zlib/trees.c: Removed.
  • platform/image-decoders/zlib/trees.h: Removed.
  • platform/image-decoders/zlib/uncompr.c: Removed.
  • platform/image-decoders/zlib/zconf.h: Removed.
  • platform/image-decoders/zlib/zlib.h: Removed.
  • platform/image-decoders/zlib/zutil.c: Removed.
  • platform/image-decoders/zlib/zutil.h: Removed.
18:07 Changeset [53747] by ajwong@chromium.org
  • 4 edits in trunk/WebKit/chromium

Not reviewed. backout.

Backout r53705. Causes ui_tests to timeout, and browser_tests to fail with
TestConnectToBadPort and WindowOpenInvalidExtension.

17:58 Changeset [53746] by sfalken@apple.com
  • 12 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=34025
Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.

Reviewed by Darin Adler.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

WebKitTools:

  • Scripts/build-webkit:
17:52 Changeset [53745] by simon.fraser@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-01-22 Simon Fraser <simon.fraser@apple.com>

No review.

Commit missing test result.

  • fast/dom/Window/webkitConvertPointUpdateLayout-expected.txt: Added.
17:51 Changeset [53744] by dimich@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Fix tests, unreviewed. Adding expectations file missing from r53739

  • fast/dom/Window/webkitConvertPointUpdateLayout-expected.txt: Added.
17:33 Changeset [53743] by sfalken@apple.com
  • 2 edits in trunk/LayoutTests

Build fix. Add missing comma.

  • fast/dom/Window/window-properties.html:
17:17 Changeset [53742] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2010-01-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r53110): Find My iPhone message dialog is offset from original position once it gets focus
https://bugs.webkit.org/show_bug.cgi?id=33821

Fix an issue with the geometry of fixed position, composited layers inside other
composited layers. If we called convertToLayerCoords() on a fixed layer with an ancestor
layer which is not the root, then we assumed that the fixed layer had a positioning root.
However, this is not always the case, since the fixed layer may have a compositing ancestor
which is not a fixed container.

Test: compositing/geometry/fixed-in-composited.html

  • rendering/RenderLayer.cpp: (WebCore::isFixedPositionedContainer): Utility function to test whether a layer acts as a fixed position container.

(WebCore::RenderLayer::convertToLayerCoords): When called on a fixed position layer
for an ancestor layer that is not the root, compute the correct offsets by looking for
the fixed position container, and computing offsets relative to that. If the ancestorLayer
is the fixed position container, fall through to the existing code that is shared
with absolutely positioned layers.

17:14 Changeset [53741] by sfalken@apple.com
  • 3 edits in trunk/LayoutTests

Skip fast/dom/Window/window-properties-geolocation.html
until https://bugs.webkit.org/show_bug.cgi?id=34025 is landed.

  • platform/mac/Skipped:
  • platform/win/Skipped:
17:07 Changeset [53740] by sfalken@apple.com
  • 7 edits
    1 copy
    1 add
    1 delete in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=34024
Layout tests don't easily allow Geolocation to be on in only a subset of platforms

Reviewed by Darin Adler.

  • fast/dom/Window/window-properties-geolocation-expected.txt: Added.
  • fast/dom/Window/window-properties-geolocation.html: Copied from fast/dom/Window/window-properties.html.

Moved Geolocation property testing here.

  • fast/dom/Window/window-properties.html: Exclude Geolocation from testing. Moved to window-properties-geolocation.html.
  • fast/dom/navigator-detached-no-crash.html: Exclude Geolocation from output.
  • fast/dom/script-tests/prototype-inheritance-2.js: Exclude Geolocation.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Removed Geolocation properties from expected results.
  • platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Removed. Gtk results now match baseline.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Removed Geolocation properties from expected results.
  • platform/qt/Skipped: Skip Geolocation tests. Not yet available in Qt.
16:46 Changeset [53739] by simon.fraser@apple.com
  • 3 edits
    1 add in trunk

2010-01-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

webkitConvertPointFromNodeToPage doesn't take into account most recent transform style
https://bugs.webkit.org/show_bug.cgi?id=34023

Be sure to call updateLayoutIgnorePendingStylesheets() before doing point mapping,
to apply any style changes since the last layout.

Test: fast/dom/Window/webkitConvertPointUpdateLayout.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitConvertPointFromNodeToPage): Call updateLayoutIgnorePendingStylesheets(). (WebCore::DOMWindow::webkitConvertPointFromPageToNode): Ditto.
16:46 Changeset [53738] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, fixes one issue with window-property-descriptors test.

  • fast/dom/Window/script-tests/window-property-descriptors.js: Don't dump the property that only appears in debug build, it will fail tests in debug.
16:43 Changeset [53737] by mjs@apple.com
  • 4 edits in trunk/WebCore

2010-01-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Roben.

Use stale cache data when going back and forward but not using WebCore’s page cache
https://bugs.webkit.org/show_bug.cgi?id=33993
<rdar://problem/7383392>

No tests since this is a performance change.

  • loader/CachePolicy.h: (WebCore::): Add CachePolicyAllowStale.
  • loader/DocLoader.cpp: (WebCore::DocLoader::checkForReload): Never reload in the case of CachePolicyAllowStale.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::subresourceCachePolicy): Return CachePolicyAllowStale if the main resource is being loaded to allow stale data. (WebCore::FrameLoader::addExtraFieldsToRequest): Use ReturnCacheDataElseLoad on back/forward loads - needed when going back of forward to a page with frames.
16:31 Changeset [53736] by knorton@google.com
  • 2 edits in trunk/WebCore

2010-01-22 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Web Inspector: JavaScript Error in DOMAgent.js:375 (_attributesUpdated)
https://bugs.webkit.org/show_bug.cgi?id=33915

Errors were caused by the fact that Element::attributes calls Element::setAttribute to
synchronized the styleAttr. The fix is to simply check the synchronizing style attribute
flag.

  • dom/Element.cpp: (WebCore::Element::setAttribute): Checked for case where styleAttr is being synchronized.
16:27 Changeset [53735] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-22 Adam Barth <abarth@webkit.org>

Unreviewed. Arg. Someone renamed limit to output_limit on me.

  • Scripts/webkitpy/commands/queues.py:
16:21 Changeset [53734] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-22 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

Make init.py and buildbot.py pass pep8 style checker.

  • Scripts/webkitpy/init.py:
  • Scripts/webkitpy/buildbot.py:
16:12 Changeset [53733] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-21 Joe Mason <jmason@rim.com>

Reviewed by Adam Barth.

webkit-patch should retry on invalid password
https://bugs.webkit.org/show_bug.cgi?id=33955

Ask for bugs.webkit.org authentication in a loop.

  • Scripts/webkitpy/bugzilla.py:
16:10 Changeset [53732] by jianli@chromium.org
  • 5 edits in trunk/LayoutTests

No review. Updated Qt layout tests due to r53722.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
16:06 Changeset [53731] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-22 Adam Barth <abarth@webkit.org>

Unreviewed. Don't call seek on a NoneType.

  • Scripts/webkitpy/statusserver.py:
15:58 Changeset [53730] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-22 Petri Latvala <petri.latvala@nomovok.com>

Reviewed by David Levin.

check-webkit-style breaks on files with unknown types
https://bugs.webkit.org/show_bug.cgi?id=34001

For files with type FileType.NONE, dispatch_processor returns None.

  • Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
15:58 Changeset [53729] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make bugzilla.py and webkitport.py conform to pep8
https://bugs.webkit.org/show_bug.cgi?id=34015

This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
style as enforced by pep8.py. I wasn't able to get rid of all the
errors because I'm not sure how to wrap some lines properly. Also,
there are a few deprication errors that I couldn't resolve easily.
However, this is a massive improvement in compliance.

  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/webkitport.py:
15:57 Changeset [53728] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-22 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Limit length of EWS results to 5MB
https://bugs.webkit.org/show_bug.cgi?id=34016

Hopefully this will fix the bug where the results link doesn't appear.
Our current theory is that the results blob is too big and the server
is rejecting the request with a 500 error. That causes us to re-try
the post, but when we re-try the StringIO buffer has its seek pointer
at the end.

  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/statusserver.py:
15:54 Changeset [53727] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

No review. Build fix.
Updated the newly added test to count the change from r53722.

  • fast/dom/Window/window-property-descriptors-expected.txt:
15:50 Changeset [53726] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Platform dependent expected files added for tests introduced in r53656,
because these tests pass. Compared to png files.

Reviewed by Nikolas Zimmermann.

  • platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt: Added.
15:49 Changeset [53725] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-01-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update r53711 for GraphicsLayer method rename.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::createLayerForMovie): Rename from change setContentsToVideo.
15:41 Changeset [53724] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, test fix.

Update a layout test for change in page scroll size.
https://bugs.webkit.org/show_bug.cgi?id=32595

  • fast/events/scrollbar-double-click-expected.txt:
15:36 Changeset [53723] by zimmermann@webkit.org
  • 5 edits in trunk/LayoutTests

2010-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix comment in the a SVG <use> testcase, it should say "green rectangles" instead of "blue rectangles", as noticed by Csaba Osztrogonac.

  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.checksum:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml:
15:03 Changeset [53722] by jianli@chromium.org
  • 7 edits in trunk

WebCore: Add BlobConstructor to DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=33982

Reviewed by Darin Adler.

  • page/DOMWindow.idl:

LayoutTests: Updated the affected tests due to adding BlobConstructor to DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=33982

Reviewed by Darin Adler.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
15:03 Changeset [53721] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

[WebFrame loadRequest:] does not null check the WebCore::Frame
<rdar://problem/7416286> and https://bugs.webkit.org/show_bug.cgi?id=34021

Reviewed by Adele Peterson.

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]): Null check the WebCore::Frame as it can disappear

out of underneath a WebFrame.

14:59 Changeset [53720] by jianli@chromium.org
  • 3 edits in trunk/LayoutTests

Add test for new attributes introduced in File and Blob interfaces.
https://bugs.webkit.org/show_bug.cgi?id=33980

Reviewed by Darin Adler.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js:
14:18 Changeset [53719] by bweinstein@apple.com
  • 2 edits
    1 add in trunk/WebCore

Rubber-stamped by Adam Roben.

Commit files that were supposed to be part of r53696, but weren't
landed.

  • English.lproj/localizedStrings.js:
  • manual-tests/debugger-caught-uncaught-exceptions.html: Added.
14:17 Changeset [53718] by pkasting@chromium.org
  • 8 edits in trunk

When scrolling by page, hold back 1/8th of the visible size instead of
40 px.
https://bugs.webkit.org/show_bug.cgi?id=32595

Reviewed by David Hyatt.

WebCore:

  • editing/EditorCommand.cpp:

(WebCore::verticalScrollDistance):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/Scrollbar.h:
  • platform/wx/ScrollViewWx.cpp:

(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):

WebKit/mac:

  • WebView/WebFrameView.mm:

(-[WebFrameView _verticalPageScrollDistance]):
(-[WebFrameView initWithFrame:]):
(-[WebFrameView _horizontalPageScrollDistance]):

14:13 Changeset [53717] by dimich@chromium.org
  • 2 edits in trunk/JavaScriptCore

Not reviewed, attempted Snow Leopard build fix.

  • wtf/ThreadingPthreads.cpp: Add a forward declaration of a function which is not 'static'.
14:05 Changeset [53716] by pkasting@chromium.org
  • 18 edits in trunk

Not reviewed, backout.

Back out r52673, which caused several regressions.
https://bugs.webkit.org/show_bug.cgi?id=32533

WebCore:

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupContainer::hidePopup):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::hidePopup):

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenu::menuUnmapped):

  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenu::show):

  • platform/qt/QtAbstractWebPopup.cpp:

(WebCore::QtAbstractWebPopup::popupDidHide):

  • platform/qt/QtAbstractWebPopup.h:
  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::hide):

  • platform/wx/PopupMenuWx.cpp:

(WebCore::PopupMenu::OnMenuItemSelected):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::popupDidHide):

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::popupDidHide):

  • rendering/RenderTextControlSingleLine.h:

WebKit/chromium:

  • src/AutocompletePopupMenuClient.cpp:

(WebKit::AutocompletePopupMenuClient::initialize):
(WebKit::AutocompletePopupMenuClient::popupDidHide):
(WebKit::AutocompletePopupMenuClient::setTextFromItem):

  • src/AutocompletePopupMenuClient.h:

WebKit/qt:

  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopupCombo::hidePopup):

14:04 Changeset [53715] by cjerdonek@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

33791: Proposed patch 1 (amended with preferred license)

14:00 Changeset [53714] by dimich@chromium.org
  • 16 edits
    2 adds in trunk

Fix the leak of ThreadIdentifiers in threadMap across threads.
https://bugs.webkit.org/show_bug.cgi?id=32689

Reviewed by Maciej Stachowiak.

JavaScriptCore:

Test is added to DumpRenderTree.mm.

  • Android.mk: Added file ThreadIdentifierDataPthreads.(h|cpp) to build.
  • Android.v8.wtf.mk: Ditto.
  • GNUmakefile.am: Ditto.
  • JavaScriptCore.gyp/JavaScriptCore.gyp: Ditto.
  • JavaScriptCore.gypi: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • wtf/ThreadIdentifierDataPthreads.cpp: Added. Contains custom implementation of thread-specific data that uses custom destructor.

(WTF::ThreadIdentifierData::~ThreadIdentifierData): Removes the ThreadIdentifier from the threadMap.
(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::destruct): Custom thread-specific destructor. Resets the value for the key again to cause second invoke.
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce): Need to use pthread_once since initialization may come on any thread(s).

  • wtf/ThreadIdentifierDataPthreads.h: Added.

(WTF::ThreadIdentifierData::ThreadIdentifierData):

  • wtf/Threading.cpp:

(WTF::threadEntryPoint): Move initializeCurrentThreadInternal to after the lock to make

sure it is invoked when ThreadIdentifier is already established.

  • wtf/Threading.h: Rename setThreadNameInternal -> initializeCurrentThreadInternal since it does more then only set the name now.
  • wtf/ThreadingNone.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.

  • wtf/ThreadingWin.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.
(WTF::initializeThreading): Ditto.

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.

  • wtf/ThreadingPthreads.cpp:

(WTF::establishIdentifierForPthreadHandle):
(WTF::clearPthreadHandleForIdentifier): Make it not 'static' so the ~ThreadIdentifierData() in another file can call it.
(WTF::initializeCurrentThreadInternal): Set the thread-specific data. The ThreadIdentifier is already established by creating thread.
(WTF::waitForThreadCompletion): Remove call to clearPthreadHandleForIdentifier(threadID) since it is now done in ~ThreadIdentifierData().
(WTF::detachThread): Ditto.
(WTF::currentThread): Use the thread-specific data to get the ThreadIdentifier. It's many times faster then Mutex-protected iteration through the map.

Also, set the thread-specific data if called first time on the thread.

WebKitTools:

Add a new test to verify the ThreadIdentifiers are not reused across threads.
The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
waiting for the previous thread to terminate before starting the next.
The treads use WTF::currentThread() in their thread function. Without a fix, this
causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
The test practically does not affect the DRT run time because the threads end immediately.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(runThread): Test thread function.
(testThreadIdentifierMap):
(dumpRenderTree):

13:52 Changeset [53713] by mitz@apple.com
  • 6 edits in trunk/WebCore

Rubber-stamped by Darin Adler.

Revert r53693 because it broke scrolling of pages with fixed elements on
Mac OS X.

  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):

  • platform/ScrollView.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::destroy):

12:59 Changeset [53712] by ap@apple.com
  • 9 edits
    3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=34008
Assertion failure in KURL::setProtocol when running DOM Fuzzer

Test: fast/dom/Window/invalid-protocol.html

  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setProtocol): Raise an exception if KURL::setProtocol fails.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setProtocol): Move argument tweaking logic into KURL. This way, the ':' trick applies to both JSLocation and HTMLAnchorElement, matching IE (but not Firefox). IE behavior is more permissive, and even more logical in my opinion.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): Assert that setting protocol succeeded.
  • platform/KURL.cpp: (WebCore::KURL::setProtocol): Remove everything past ':', if present. Return false if the protocol to set is not valid. (WebCore::isValidProtocol): Made this work correctly for empty strings.
  • platform/KURL.h: isValidProtocol() is now static in KURL.cpp, it's only used in setProtocol().
  • platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): Always return true. This should hopefully prevent Chromium build breakage, alhough tests will likely fail. (WebCore::isValidProtocol): Removed, as this isn't used at the moment.
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::httpURLForAuthenticationAndCookies): Assert that setting protocol succeeded.
12:40 Changeset [53711] by eric.carlson@apple.com
  • 5 edits in trunk/WebCore

2010-01-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

<rdar://problem/7373568>
https://bugs.webkit.org/show_bug.cgi?id=34007
Implement hardware acceleration of video compositing on Windows

Internally we still have QuickTime render to a bitmap, but frames are then composited
with the page using an accelerated renderer.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_newFrameAvailable. (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): Call tearDownVideoRendering. (WebCore::MediaPlayerPrivate::cancelLoad): Call tearDownVideoRendering. (WebCore::MediaPlayerPrivate::updateStates): Call setUpVideoRendering once the movie

is ready to draw.

(WebCore::MediaPlayerPrivate::isReadyForRendering): New, utility function returns true

only when movie is ready to render.

(WebCore::MediaPlayerPrivate::setSize): Remember the size as we need it when rendering

in accelerated mode.

(WebCore::MediaPlayerPrivate::setVisible): Call setUpVideoRendering when made visible.
(WebCore::MediaPlayerPrivate::paint): Do nothing when rendering to a layer. Move frame

rate drawing code to paintCompleted.

(WebCore::MediaPlayerPrivate::paintCompleted): New, clear m_newFrameAvailable and, when

built with DRAW_FRAME_RATE, draw framerate.

(WebCore::MediaPlayerPrivate::movieNewImageAvailable): Set m_newFrameAvailable, trigger

repaint differently when drawing to a layer.

(WebCore::MediaPlayerPrivate::currentRenderingMode): New, return the current rendering mode.
(WebCore::MediaPlayerPrivate::preferredRenderingMode): New, return preferred rendering mode

(render to a layer whenever possible).

(WebCore::MediaPlayerPrivate::setUpVideoRendering): New, tear down current rendering mode

and set up new mode when necessary.

(WebCore::MediaPlayerPrivate::tearDownVideoRendering): New, noop unless rendering to a layer.
(WebCore::MediaPlayerPrivate::hasSetUpVideoRendering): New.
(WebCore::MediaPlayerPrivate::paintContents): New, callback from compositing layer when it

is time to draw the current frame.

(WebCore::MediaPlayerPrivate::createLayerForMovie): New, allocate a layer for the movie.
(WebCore::MediaPlayerPrivate::destroyLayerForMovie): New, delete movie layer.
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): New, return true unless the

movie is not ready to render.

(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): New, deal with change in

accelerated rendering state.

(WebCore::MediaPlayerPrivate::notifySyncRequired): New, callback from compositing layer

when it wants to schedule a redraw.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: (WebCore::MediaPlayerPrivate::notifyAnimationStarted): (WebCore::MediaPlayerPrivate::showDebugBorders): (WebCore::MediaPlayerPrivate::showRepaintCounter):
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::getCurrentFrameInfo):

New, return information about the offscreen render buffer.

(QTMovieWin::initializeQuickTime):

  • platform/graphics/win/QTMovieWin.h:
12:33 Changeset [53710] by jorlow@chromium.org
  • 12 edits in trunk

2010-01-21 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

The Chromium WebKit API needs to expose storage event related data
https://bugs.webkit.org/show_bug.cgi?id=33985

setItem and removeItem on WebStorageArea need to expose what the previous
value was for the key being modified. Clear needs to return whether it
actually cleared anything.

  • public/WebStorageArea.h: (WebKit::WebStorageArea::setItem): (WebKit::WebStorageArea::removeItem): (WebKit::WebStorageArea::clear):
  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::StorageAreaProxy): (WebCore::StorageAreaProxy::setItem): (WebCore::StorageAreaProxy::removeItem): (WebCore::StorageAreaProxy::clear): (WebCore::StorageAreaProxy::storageEvent):
  • src/StorageAreaProxy.h:
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespaceProxy::StorageNamespaceProxy): (WebCore::StorageNamespaceProxy::copy): (WebCore::StorageNamespaceProxy::storageArea):
  • src/StorageNamespaceProxy.h:
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem): (WebKit::WebStorageAreaImpl::removeItem): (WebKit::WebStorageAreaImpl::clear):
  • src/WebStorageAreaImpl.h:

2010-01-21 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

The Chromium WebKit API needs to expose storage event related data
https://bugs.webkit.org/show_bug.cgi?id=33985

This change is not visible to layoutTests/web pages.

  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::setItem): return the old value (WebCore::StorageAreaImpl::removeItem): return the old value (WebCore::StorageAreaImpl::clear): return whether there was anything to clear
  • storage/StorageAreaImpl.h:
12:06 Changeset [53709] by adele@apple.com
  • 3 edits
    2 adds in trunk

An element that doesn't validate and an invalid element shouldn't share style
https://bugs.webkit.org/show_bug.cgi?id=34010

Reviewed by Dan Bernstein.

Test: fast/css/pseudo-invalid-novalidate-001.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Separate the check for willValidate from the check for isValidFormControlElement.
  • html/HTMLFormControlElement.h: The validity method doesn't need to be virtual.
11:49 Changeset [53708] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Crash in fast/dom/Window/window-properties if Geolocation enabled
https://bugs.webkit.org/show_bug.cgi?id=34013

Reviewed by Dan Bernstein.

Add null check to fix Geolocation crash in fast/dom/Window/window-properties.

  • page/Geolocation.cpp:

(WebCore::createGeoposition):

11:13 Changeset [53707] by enrica@apple.com
  • 3 edits in trunk/LayoutTests

Fix for the failing test on qt buildbot.
This tests had been added as part of the patch for https://bugs.webkit.org/show_bug.cgi?id=33970

Reviewed by Adele Peterson.

  • editing/pasteboard/paste-noscript-svg-expected.txt:
  • editing/resources/svgcontent.xhtml:
11:09 Changeset [53706] by eric@webkit.org
  • 2 edits
    5 adds in trunk

2010-01-22 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Object.getOwnPropertyDescriptor(window) returns descriptors for properties in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=33948

Even though prototype properties are proxied by JSDOMWindow::getOwnPropertySlot(),
that proxying should not be performed by JSDOMWindow::getOwnPropertyDescriptor().

This makes getOwnPropertyDescriptor() consistent with getOwnPropertyNames().

Test: fast/dom/Window/window-property-descriptors.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
10:44 Changeset [53705] by darin@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-01-21 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[Chromium] spurious WebViewClient::didStopLoading if changing
location.hash while a subframe is still loading

https://bugs.webkit.org/show_bug.cgi?id=33884

This is a refinement of http://trac.webkit.org/changeset/51548

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClientImpl::postProgressStartedNotification): (WebKit::FrameLoaderClientImpl::postProgressFinishedNotification):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::didStartLoading): (WebKit::WebViewImpl::didStopLoading):
  • src/WebViewImpl.h:
10:31 Changeset [53704] by aroben@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Check in expected failure results for text-zoom.xhtml on Windows

Fixing this test is covered by <http://webkit.org/b/34006>.

Rubber-stamped by Dan Bernstein.

  • platform/win/svg/custom/text-zoom-expected.txt: Added.
09:01 Changeset [53703] by girish@forwardbias.in
  • 6 edits in trunk

[Qt] Save the QWebPageClient instead of the ownerWidget in QtAbstractWebPopup

Reviewed by Simon Hausmann.

The QWebPageClient is required for the QtFallbackWebPopup. QtFallbackWebPopup will
need it to create a QGraphicsProxyWidget (in a future commit) for the
QGraphicsWebView's web popup.

08:11 Changeset [53702] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/misc/slow-loading-mask.html timed out.
https://bugs.webkit.org/show_bug.cgi?id=34004

  • platform/qt/Skipped: http/tests/misc/slow-loading-mask.html skipped.
06:28 Changeset [53701] by hamaji@chromium.org
  • 1 edit
    10 moves
    3 adds
    24 deletes in trunk/LayoutTests

2010-01-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

incorrect results for css2.1 layout tests that use setTimeout in body onload event
https://bugs.webkit.org/show_bug.cgi?id=17557

  • css2.1/README.txt: Added.
  • css2.1/t1204-increment-00-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-00-c-o.html.
  • css2.1/t1204-increment-01-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-01-c-o.html.
  • css2.1/t1204-increment-02-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-02-c-o.html.
  • css2.1/t1204-reset-00-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-00-c-o.html.
  • css2.1/t1204-reset-01-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-01-c-o.html.
  • css2.1/t1204-reset-02-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-02-c-o.html.
  • fast/css/counters/counter-increment-000-expected.txt: Renamed from LayoutTests/fast/css/counters/t1204-increment-00-c-o-expected.txt.
  • fast/css/counters/counter-increment-000.html: Renamed from LayoutTests/fast/css/counters/t1204-increment-00-c-o.html.
  • fast/css/counters/counter-increment-001-expected.txt: Renamed from LayoutTests/fast/css/counters/t1204-increment-01-c-o-expected.txt.
  • fast/css/counters/counter-increment-001.html: Renamed from LayoutTests/fast/css/counters/t1204-increment-01-c-o.html.
  • fast/css/counters/counter-reset-001-expected.txt: Added.
  • fast/css/counters/counter-reset-001.html: Added.
  • platform/mac/css2.1/t1204-increment-00-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-increment-00-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-increment-00-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-increment-01-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-increment-01-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-increment-01-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-increment-02-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-increment-02-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-increment-02-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-reset-00-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-reset-00-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-reset-00-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-reset-01-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-reset-01-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-reset-01-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-reset-02-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-reset-02-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-reset-02-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-increment-00-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-increment-01-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-increment-02-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-reset-00-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-reset-01-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-reset-02-c-o-expected.txt: Removed.
06:13 Changeset [53700] by hamaji@chromium.org
  • 2 edits in trunk/BugsSite

2010-01-22 Janusz Lewandowski <lew21@xtreeme.org>

Reviewed by Maciej Stachowiak.

run-webkit-tests fails on Ruby 1.9
https://bugs.webkit.org/show_bug.cgi?id=33554
inject does not work with strings any more, so BugsSite/PrettyPatch/PrettyPatch.rb prints lots of errors.

  • PrettyPatch/PrettyPatch.rb:
05:42 Changeset [53699] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed Qt "build" fix.

  • WebCore.pro: Fix warning about missing header file that isn't present anymore.
05:34 Changeset [53698] by girish@forwardbias.in
  • 2 edits in trunk/WebKit/qt

QState::polished() was renamed to QState::propertiesAssigned() when
Qt 4.6.0 was released.

Reviewed by Kenneth Rohde Christiansen.

04:56 Changeset [53697] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip test introduced in r53684 because of missing eventSender.textZoomIn()

  • platform/qt/Skipped: svg/custom/text-zoom.xhtml skipped.
04:52 Changeset [53696] by yurys@chromium.org
  • 10 edits in trunk/WebCore

2010-01-22 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Web Inspector: Caught exceptions still pause the debugger.
<https://bugs.webkit.org/show_bug.cgi?id=28622>.

Turn the pauseOnExceptions variable from a bool to an int, because we now have
3 states, in an enum: DontPauseOnExceptions, PauseOnAllExceptions, and
PauseOnUncaughtExceptions. The status button for pausing on exceptions is now
a tri-state button, which cycles from Don't pause (no background) to Pause on All
(blue background) to Pause on Uncaught (purple background).

Also added the ability for a status button to have more than 2 states, and added
style rules for a CSS three state button.

Added a manual test, manual-tests/debugger-caught-uncaught-exceptions.html, that
generates caught and uncaught exceptions.

  • English.lproj/localizedStrings.js: Added updated Action / Click to Action text.
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::pauseOnExceptions): Changed from a bool to an int. (WebCore::InspectorBackend::setPauseOnExceptions): Ditto.
  • inspector/InspectorBackend.h: Ditto.
  • inspector/InspectorBackend.idl: Ditto.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::JavaScriptDebugServer): Changed from bool to PauseOnExceptionsState. (WebCore::JavaScriptDebugServer::setPauseOnExceptions): Ditto. (WebCore::JavaScriptDebugServer::exception): Updated logic to see if we are breaking

on uncaught exceptions, and check if we have a handler.

  • inspector/JavaScriptDebugServer.h: (WebCore::JavaScriptDebugServer::): Changed from bool to PauseOnExceptionsState. (WebCore::JavaScriptDebugServer::pauseOnExceptions): Ditto.
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptionsState): Changed from returning false to returning 0 (stub function).
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): Updated to new text/new cycling of variables. (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): Updated to new text/new cycling of variables.
  • inspector/front-end/StatusBarButton.js: (WebInspector.StatusBarButton): Added the option for a different number of states. (WebInspector.StatusBarButton.prototype.set toggled): Added rules to toggle on/off with multiple states.
  • inspector/front-end/inspector.css: Added rules for toggled-1 and toggled-2.
  • manual-tests/debugger-caught-uncaught-exceptions.html: Added.
04:30 Changeset [53695] by eric@webkit.org
  • 4 edits
    2 adds in trunk/WebCore

2010-01-22 Ben Murdoch <benm@google.com>

Reviewed by Eric Seidel.

[Android] Android platform specific PlatformTouchEvent and PlatformTouchPoint implementations are not upstream.
https://bugs.webkit.org/show_bug.cgi?id=33719

Add the Android specific files and update the Android makefile.

No new tests as this is all Android-specific code.

  • Android.mk: Add Touch event related files to the makefile.
  • platform/PlatformTouchEvent.h: Add Android constructor.
  • platform/PlatformTouchPoint.h: Ditto.
  • platform/android/PlatformTouchEventAndroid.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent): Android implementation.
  • platform/android/PlatformTouchPointAndroid.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint): Android implementation.
04:23 QtWebKitBackportingFixes edited by girish@forwardbias.in
(diff)
04:04 Changeset [53694] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

[Qt] css1_forward_compatible_parsing.html moved from css2.1 to fast/css by r53664.

  • platform/qt/Skipped: path fixed.
04:01 Changeset [53693] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-01-22 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

The RenderObjects with fixed position register to the view
to be taken into account while scrolling.
The scrolling code update specifically those elements after blitting the pixels.

  • page/FrameView.cpp: (WebCore::FrameView::registerFixedPositionedObject): (WebCore::FrameView::unregisterFixedPositionedObject): (WebCore::FrameView::scrollContentsFastPath):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
  • platform/ScrollView.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::destroy):
03:57 Changeset [53692] by ukai@chromium.org
  • 1 edit
    2 copies
    1 move
    6 adds
    2 deletes in trunk/LayoutTests

2010-01-22 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Maciej Stachowiak.

Split websocket/tests/bad-sub-protocol.html
https://bugs.webkit.org/show_bug.cgi?id=33646

  • websocket/tests/bad-sub-protocol-control-chars-expected.txt: Added.
  • websocket/tests/bad-sub-protocol-control-chars.html: Added.
  • websocket/tests/bad-sub-protocol-empty-expected.txt: Added.
  • websocket/tests/bad-sub-protocol-empty.html: Added.
  • websocket/tests/bad-sub-protocol-expected.txt: Removed.
  • websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Added.
  • websocket/tests/bad-sub-protocol-non-ascii.html: Added.
  • websocket/tests/bad-sub-protocol.html: Removed.
  • websocket/tests/script-tests/bad-sub-protocol-control-chars.js: Added.
  • websocket/tests/script-tests/bad-sub-protocol-empty.js: Added.
  • websocket/tests/script-tests/bad-sub-protocol-non-ascii.js: Added.
  • websocket/tests/script-tests/bad-sub-protocol.js: Removed.
02:48 Changeset [53691] by eric@webkit.org
  • 4 edits
    2 adds
    3 deletes in trunk

2010-01-22 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Improve portability of listbox-deselect-scroll.html
https://bugs.webkit.org/show_bug.cgi?id=33989

  • Convert the test to dumpAsTest
  • Use eventSender.mouseDown(0, addSelectionKey?)
  • Avoid hard-coded line-heights.
  • fast/forms/listbox-deselect-scroll-expected.txt: Added.
  • fast/forms/listbox-deselect-scroll.html:
  • fast/forms/script-tests/listbox-deselect-scroll.js: Added.
  • platform/mac/fast/forms/listbox-deselect-scroll-expected.checksum: Removed.
  • platform/mac/fast/forms/listbox-deselect-scroll-expected.png: Removed.
  • platform/mac/fast/forms/listbox-deselect-scroll-expected.txt: Removed.

2010-01-22 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Fix a bug that mouseDown:withModifiers: is never called.
https://bugs.webkit.org/show_bug.cgi?id=33989

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]):
02:26 Changeset [53690] by eric@webkit.org
  • 6 edits
    2 adds in trunk/WebCore

2010-01-22 Anton Muhin <antonm@chromium.org>

Reviewed by Eric Seidel.

Adding ScriptWrappable into WebCore.
This allows to associate custom information when Node
gets wrapped into JavaScript wrapper.

[v8, dom] Add a pointer field to C++ Node class
https://bugs.webkit.org/show_bug.cgi?id=32430

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptWrappable.h: Added. (WebCore::ScriptWrappable::ScriptWrappable):
  • bindings/v8/ScriptWrappable.h: Added. (WebCore::ScriptWrappable::ScriptWrappable): (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper):
  • dom/Node.h:
01:42 Changeset [53689] by yurys@chromium.org
  • 2 edits in trunk/WebCore

emikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Add stub implementation of dispatchOnInjectedScript method so that
Chromium source can compile against it and the main fix for the bug
28622 can be landed without breaking Chromium build.

https://bugs.webkit.org/show_bug.cgi?id=28622

  • inspector/InspectorBackend.h: (WebCore::InspectorBackend::dispatchOnInjectedScript):
01:19 Changeset [53688] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Dmitry Titov.

ENABLE(DATABASE) guard is missing in ScriptExecutionContext::~ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=33990

Add missing ENABLE(DATABASE) guard.

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
01:17 Changeset [53687] by kenneth@webkit.org
  • 3 edits
    2 adds in trunk/WebKitTools

[Qt] Separate out the WebPage class into it's own
cpp/header files. Also, removed the assumption that
the view is a QWebView, in preparation of a merger
of the two Qt WebKit launchers.

Rubberstamped by Antti Koivisto.

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/main.cpp:

(WebView::mousePressEvent):

  • QtLauncher/webpage.cpp: Added.

(WebPage::supportsExtension):
(WebPage::extension):
(WebPage::acceptNavigationRequest):
(WebPage::openUrlInDefaultBrowser):

  • QtLauncher/webpage.h: Added.

(WebPage::WebPage):

00:42 Changeset [53686] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-01-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

  • bindings/scripts/generate-bindings.pl:
00:42 Changeset [53685] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-01-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Rename FEATURE_DEFINES_JAVASCRIPT to FEATURE_DEFINES and remove
the hardcoded LANGUAGE_JAVASCRIPT=1, in preparation for its use by
the GObject DOM bindings.

  • GNUmakefile.am:
00:20 Changeset [53684] by mitz@apple.com
  • 4 edits
    4 adds in trunk

<rdar://problem/7568696> Zoom applied to embedded SVG incorrectly
https://bugs.webkit.org/show_bug.cgi?id=33988

Reviewed by Darin Adler.

WebCore:

Test: svg/custom/text-zoom.xhtml

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement): Initialize m_scale.
(WebCore::SVGSVGElement::currentScale): If this is the document element,
return the frame’s zoom factor. Otherwise, return m_scale.
(WebCore::SVGSVGElement::setCurrentScale): If this is the document element,
set the frame’s zoom factor. Otherwise, set m_scale and mark for layout.

  • svg/SVGSVGElement.h: Added m_scale member.

LayoutTests:

  • svg/custom/text-zoom-expected.checksum: Added.
  • svg/custom/text-zoom-expected.png: Added.
  • svg/custom/text-zoom-expected.txt: Added.
  • svg/custom/text-zoom.xhtml: Added.

01/21/10:

23:48 Changeset [53683] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-01-21 Adam Barth <abarth@webkit.org>

Unreviewed. Added a blank line requested by the great an powerful
fishd.

  • public/WebFrameClient.h:
23:36 Changeset [53682] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-01-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Alexey Proskuryakov.

Add ThreadSpecific for ENABLE(SINGLE_THREADED)
https://bugs.webkit.org/show_bug.cgi?id=33878

Implement ThreadSpecific with a simple getter/setter
when ENABLE(SINGLE_THREADED) is true.

Due to the change in https://bugs.webkit.org/show_bug.cgi?id=33236,
an implementation of ThreadSpecific must be available to build WebKit.
This causes a build failure for platforms without a proper
ThreadSpecific implementation.

  • wtf/ThreadSpecific.h: (WTF::::ThreadSpecific): (WTF::::~ThreadSpecific): (WTF::::get): (WTF::::set): (WTF::::destroy):
23:11 Changeset [53681] by eric@webkit.org
  • 7 edits in trunk

2010-01-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[chromium] Add allowPlugins callback to allow per-site enabling of plugins
https://bugs.webkit.org/show_bug.cgi?id=33974

Add a callback into the FrameLoaderClient to let the embedder enable or
disable plugins on a per-site basis.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowPlugins):

2010-01-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[chromium] Add allowPlugins callback to allow per-site enabling of plugins
https://bugs.webkit.org/show_bug.cgi?id=33974

Forward the new allowPlugins callback to WebKitClient so that it can
make the policy decision.

  • public/WebFrameClient.h: (WebKit::WebFrameClient::allowPlugins):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowJavaScript): (WebKit::FrameLoaderClientImpl::allowPlugins):
  • src/FrameLoaderClientImpl.h:
22:58 CommitterTips edited by cjerdonek@webkit.org
Fixed manual numbering from previous change. (diff)
22:53 CommitterTips edited by cjerdonek@webkit.org
Corrected information about username/password prompting. (diff)
22:53 Changeset [53680] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-21 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25501
Remove empty font tags when applying a style to a content editable
region.

  • editing/execCommand/change-font.html: Added.
  • editing/execCommand/change-font-expected.txt: Added.

2010-01-21 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25501
Remove empty font tags when applying a style to a content editable
region.

Test: editing/execCommand/change-font.html

  • editing/ApplyStyleCommand.cpp: (WebCore::isEmptyFontTag):
22:37 Changeset [53679] by cjerdonek@webkit.org
  • 2 edits
    3 adds in trunk/WebKitSite

Added screenshots and clearer instructions on how to submit
a patch for review.

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=32542

Also added that a bug report should be selected or created
prior to submitting a patch.

  • coding/contributing.html:
  • coding/images: Added.
  • coding/images/contribute_add_attachment.png: Added.
  • coding/images/contribute_mark_review.png: Added.
22:21 Changeset [53678] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-01-21 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Bumps the refcount when WebNode::toElement/toConstElement are called.
https://bugs.webkit.org/show_bug.cgi?id=33977

Ensures that when a wrapper around a WebNode is create via the
toElement() or toConstElement() calls that the refcount on the WebNode
is increased, by forcing a call to WebNode::assign(). This is needed
so that the following code:
{

WebNode n = someNode();
WebElement e = n.toElement<WebElement>();

}
does not decrease the overall refcount on the Node that someNode()
returns.

This caused crashes in the 'Save page as..' feature.

  • public/WebNode.h: (WebKit::WebNode::toElement): (WebKit::WebNode::toConstElement):
22:05 Changeset [53677] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-01-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Maciej Stachowiak.

Add fastStrDup to FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=33937

The new string returned by fastStrDup is obtained with fastMalloc,
and can be freed with fastFree. This makes the memory management
more consistent because we don't need to keep strdup allocated pointers
and free them with free(). Instead we can use fastFree everywhere.

  • wtf/FastMalloc.cpp: (WTF::fastStrDup):
  • wtf/FastMalloc.h:
22:01 Changeset [53676] by ukai@chromium.org
  • 1 edit
    3 copies
    1 delete in trunk/LayoutTests

2010-01-21 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

Move fast/websockets into websocket/tests
https://bugs.webkit.org/show_bug.cgi?id=32258

  • fast/websockets: Removed.
  • websocket/tests/script-tests/websocket-event-target.js: Copied from LayoutTests/fast/websockets/script-tests/websocket-event-target.js.
  • websocket/tests/websocket-event-target-expected.txt: Copied from LayoutTests/fast/websockets/websocket-event-target-expected.txt.
  • websocket/tests/websocket-event-target.html: Copied from LayoutTests/fast/websockets/websocket-event-target.html.
21:39 Changeset [53675] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2010-01-21 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Refactored to move file name and file-reading related code
from cpp_style.py and text_style.py to checker.py.

https://bugs.webkit.org/show_bug.cgi?id=33775

  • Scripts/check-webkit-style:
    • Updates caused by changes to checker.py.
  • Scripts/webkitpy/style/checker.py:
    • Added SKIPPED_FILES_WITH_WARNING list.
    • Added SKIPPED_FILES_WITHOUT_WARNING list.
    • Added FileType class.
    • Added ProcessorDispatcher class.
    • In StyleChecker class:
      • Renamed process_patch() to check_patch().
      • Renamed process_file() to check_file().
      • Added _process_file().
      • Related refactoring.
      • Addressed check_patch() FIXME to share code with process_file().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added ProcessorDispatcherSkipTest class.
    • Added ProcessorDispatcherDispatchTest class.
    • Added StyleCheckerCheckFileTest class.
  • Scripts/webkitpy/style/cpp_style.py:
    • Renamed process_file_data() to _process_lines.
    • Removed process_file() (moved logic to checker.py).
    • Removed can_handle() (moved logic to checker.py).
    • Added CppProcessor class.
    • Removed is_exempt() (moved logic to checker.py).
    • Added process_file_data() back as a wrapper function.
  • Scripts/webkitpy/style/cpp_style_unittest.py:
    • Removed test_can_handle().
    • Removed test_is_exempt().
    • Added CppProcessorTest class.
  • Scripts/webkitpy/style/text_style.py:
    • Added TextProcessor class.
    • Removed process_file().
    • Removed can_handle().
  • Scripts/webkitpy/style/text_style_unittest.py:
    • Removed test_can_handle().
    • Added TextProcessorTest class.
21:27 WikiStart edited by cjerdonek@webkit.org
Retitled committer tips section to make it easier to see (diff)
21:23 Changeset [53674] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-21 Joe Mason <jmason@rim.com>

Reviewed by Darin Adler.

Promote pow argument to double to resolve ambiguous overload (compile fix for RVCT 4.0)
https://bugs.webkit.org/show_bug.cgi?id=33952

  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::gamma):
21:11 CommitterTips edited by cjerdonek@webkit.org
Added first draft of "Walking you through your first commit" (diff)
21:06 Changeset [53673] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-01-21 Andrei Popescu <andreip@google.com>

Reviewed by David Levin.

[Android] bindings/v8/ScriptController.cpp needs to include
PlatformBridge.h instead of ChromiumBridge.h so that it can
be used on both Chromium and Android.
https://bugs.webkit.org/show_bug.cgi?id=33673

Add "static NPObject* pluginScriptableObject(Widget*);" method
to PlatformBridge.h
Include PlatformBridge.h from ScriptController.cpp.

No new tests, just platform code.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::createScriptInstanceForWidget):
  • platform/android/PlatformBridge.h:
20:22 Changeset [53672] by beidson@apple.com
  • 10 edits in trunk

history.back() for same-document history traversals isn't synchronous as the specification states.
<rdar://problem/7535011> and https://bugs.webkit.org/show_bug.cgi?id=33538

Reviewed by Maciej Stachowiak.

JavaScriptCore:

  • wtf/Platform.h: Add a "HISTORY_ALWAYS_ASYNC" enable and turn it on for Chromium.

WebCore:

In resolving https://bugs.webkit.org/show_bug.cgi?id=25570, all history.back()/forward()/go() navigations
were made asynchronous. That doesn't agree with the HTML5 spec and might have been overreaching for fixing
that particular bug. In working with the new history state APIs I noticed some things that should've been
possible were not possible because of this change.

The change in loading behavior is well covered via modifications to previous tests.

  • loader/RedirectScheduler.cpp:

(WebCore::RedirectScheduler::scheduleHistoryNavigation): Determine beforehand if the traversal is

a same-document navigation. If it is, perform the load directly instead of scheduling it.

LayoutTests:

The change in loading behavior is well covered via modifications to these previous tests:

  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange-expected.txt:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
  • fast/loader/stateobjects/state-api-on-detached-frame-crash-expected.txt:
  • fast/loader/stateobjects/state-api-on-detached-frame-crash.html:
20:21 Changeset [53671] by eric@webkit.org
  • 6 edits
    1 add in trunk/WebKit/chromium

2010-01-21 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

Adds WebKit::WebDataSource::applicationCacheHost() to the API.
https://bugs.webkit.org/show_bug.cgi?id=33880

  • WebKit.gyp:
  • public/WebDataSource.h:
  • src/ApplicationCacheHost.cpp:
  • src/ApplicationCacheHostInternal.h: Copied from WebKit/chromium/src/ApplicationCacheHost.cpp. (WebCore::ApplicationCacheHostInternal::notifyEventListener): (WebCore::ApplicationCacheHostInternal::toWebApplicationCacheHost):
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::applicationCacheHost):
  • src/WebDataSourceImpl.h:
20:04 Changeset [53670] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-01-21 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Tor Arne Vestbø.

[Qt] Don't allow Phonon's invisible video widget to keep the app running.
https://bugs.webkit.org/show_bug.cgi?id=33842

The change made in r38223 should not be limited to Qt < 4.5 only.

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
19:29 Changeset [53669] by tkent@chromium.org
  • 7 edits in trunk

2010-01-21 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::valueAsDate setter support for type=datetime.
https://bugs.webkit.org/show_bug.cgi?id=33939

Add setter tests to input-valueasdate-datetime.js, and update the
expectation.

Note: the expectation file contains some FAIL lines. They are
intentional because they test a unimplemented feature.

  • fast/forms/input-valueasdate-datetime-expected.txt:
  • fast/forms/script-tests/input-valueasdate-datetime.js:

2010-01-21 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::valueAsDate setter support for type=datetime.
https://bugs.webkit.org/show_bug.cgi?id=33939

Introduce ISODateTime::setMillisecondsSinceEpochForDateTime() and add
DateTime type support to ISODateTime::toString().

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueAsDate):
  • html/ISODateTime.cpp: (WebCore::ISODateTime::setMillisecondsSinceEpochForDate): Set Invalid to m_type. (WebCore::ISODateTime::setMillisecondsSinceEpochForDateTime): (WebCore::ISODateTime::setMillisecondsSinceEpochForMonth): Set Invalid to m_type. (WebCore::ISODateTime::setMillisecondsSinceMidnight): Set Invalid to m_type. (WebCore::ISODateTime::toString): Support DateTime type. This always produces UTC representation.
  • html/ISODateTime.h:
19:25 Changeset [53668] by ggaren@apple.com
  • 2 edits in trunk/WebCore

2010-01-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed <rdar://problem/7562574> ASSERT in WebCore::removeWrapper() at the
end of run-webkit-tests


This was an ASSERT-only bug, introduced by isolated worlds, which
created the novelty of a wrapper that might outlive its wrapper cache.


When a wrapper outlived its wrapper cache, both the wrapper's destructor
and the wrapper cache's destructor would claim to have uncached the wrapper,
causing an ASSERT to fire.


The solution is to distinguish between operations that logically add and
remove cache entries, and operations that delete whole caches. We track
when a cache entry is logically added, and when it's logically removed,
independent of whether the actual cache still exists.

  • bindings/js/JSDOMBinding.cpp: (WebCore::willCacheWrapper): (WebCore::didUncacheWrapper): New names for these functions to help explain what they track.

(WebCore::DOMWrapperWorld::~DOMWrapperWorld): Don't claim to uncache
all the wrappers in the world; we're deleting the cache, not managing its
entries.

(WebCore::cacheDOMObjectWrapper):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::forgetAllDOMNodesForDocument):
(WebCore::forgetWorldOfDOMNodesForDocument):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument): Updated for renames.

18:48 QtWebKitGraphics edited by noam.rosenthal@nokia.com
(diff)
18:35 Changeset [53667] by cjerdonek@webkit.org
  • 3 edits
    2 adds in trunk/WebKitTools

Create a unit-tested subroutine to parse patch files created
by svn-create-patch.

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=33475

  • Scripts/VCSUtils.pm:
    • Added parseDiff().
    • Added parsePatch().
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
    • Added unit tests for parseDiff().
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Total number of tests now computed dynamically.
  • Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
    • Added unit tests for parsePatch().
18:23 Changeset [53666] by zimmermann@webkit.org
  • 17 edits
    1 add
    1 delete in trunk/WebCore

2010-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Sam Weinig.

SVG JS bindings "context" pointer needs to move onto binding impls
https://bugs.webkit.org/show_bug.cgi?id=27243

Rewrite SVG DOM JSC bindings to use a global DOMObject <-> SVGElement context map, similar to V8's approach.
This allows us to remove DOMObjectWithSVGContext and make all SVG JS objects use DOMObjectWithGlobalPointer.
We're fitting again in JS_CELL_SIZE, and there's no need to special case SVG anymore.

Not adding a new test, as we have yet to identify how to test that we're passing around correct global objects.
For now this is just a code cleanup which lets me continue making progress in that area of the code.

  • GNUmakefile.am: Add new DOMObjectWithSVGContext.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/DOMObjectWithSVGContext.h: Removed.
  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException): Add comment, that passing 0 context is intentional.
  • bindings/js/JSDOMBinding.h: (WebCore::createDOMObjectWrapper): Add to JSSVGContextCache, when creating wrappers. (WebCore::getDOMObjectWrapper): Add assertion guarding the JSSVGContextCache is in-sync with the passed context.
  • bindings/js/JSSVGContextCache.h: Added. Maps DOMObjects to SVGElements - just like V8 approachs to this problem. (WebCore::JSSVGContextCache::wrapperMap): (WebCore::JSSVGContextCache::addWrapper): (WebCore::JSSVGContextCache::forgetWrapper): (WebCore::JSSVGContextCache::propagateSVGDOMChange): (WebCore::JSSVGContextCache::svgContextForDOMObject):
  • bindings/js/JSSVGLengthCustom.cpp: Retrieve context from cache, instead of taking it from the JS* class. (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/js/JSSVGMatrixCustom.cpp Ditto.: (WebCore::JSSVGMatrix::multiply): (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::rotateFromVector):
  • bindings/js/JSSVGPODListCustom.h: Ditto. (WebCore::JSSVGPODListCustom::finishGetter): (WebCore::JSSVGPODListCustom::finishSetter): (WebCore::JSSVGPODListCustom::finishSetterReadOnlyResult): (WebCore::JSSVGPODListCustom::clear): (WebCore::JSSVGPODListCustom::initialize):
  • bindings/js/JSSVGPODTypeWrapper.h: Ditto. (WebCore::JSSVGDynamicPODTypeWrapper::commitChange): (WebCore::JSSVGStaticPODTypeWrapper::commitChange): (WebCore::JSSVGStaticPODTypeWrapperWithPODTypeParent::commitChange): (WebCore::JSSVGStaticPODTypeWrapperWithParent::commitChange): (WebCore::JSSVGPODTypeWrapperCreatorForList::create): (WebCore::JSSVGPODTypeWrapperCreatorForList::commitChange):
  • bindings/js/JSSVGPathSegCustom.cpp: Ditto. (WebCore::toJS):
  • bindings/js/JSSVGPathSegListCustom.cpp: Ditto. (WebCore::JSSVGPathSegList::clear): (WebCore::JSSVGPathSegList::initialize): (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem): (WebCore::JSSVGPathSegList::appendItem):
  • bindings/scripts/CodeGeneratorJS.pm:
  • svg/SVGAngle.h: Remove unneeded associatedAttributeName() method.
  • svg/SVGPreserveAspectRatio.h: Ditto.
  • svg/SVGTransform.h: Ditto.
18:07 Changeset [53665] by kevino@webkit.org
  • 4 edits in trunk

wx build fixes, add a missing header and add a new dir to the build system.

17:40 Changeset [53664] by hamaji@chromium.org
  • 1 edit
    12 moves in trunk/LayoutTests

2010-01-21 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

3 tests for CSS are misplaced
https://bugs.webkit.org/show_bug.cgi?id=33942

  • css2.1/atrule_longest_match-expected.txt: Removed.
  • css2.1/atrule_longest_match.html: Removed.
  • css2.1/bogus-color-span.html: Removed.
  • css2.1/css1_forward_compatible_parsing.html: Removed.
  • fast/css/atrule_longest_match-expected.txt: Copied from LayoutTests/css2.1/atrule_longest_match-expected.txt.
  • fast/css/atrule_longest_match.html: Copied from LayoutTests/css2.1/atrule_longest_match.html.
  • fast/css/bogus-color-span.html: Copied from LayoutTests/css2.1/bogus-color-span.html.
  • fast/css/css1_forward_compatible_parsing.html: Copied from LayoutTests/css2.1/css1_forward_compatible_parsing.html.
  • platform/mac/css2.1/bogus-color-span-expected.checksum: Removed.
  • platform/mac/css2.1/bogus-color-span-expected.png: Removed.
  • platform/mac/css2.1/bogus-color-span-expected.txt: Removed.
  • platform/mac/css2.1/css1_forward_compatible_parsing-expected.checksum: Removed.
  • platform/mac/css2.1/css1_forward_compatible_parsing-expected.png: Removed.
  • platform/mac/css2.1/css1_forward_compatible_parsing-expected.txt: Removed.
  • platform/mac/fast/css/bogus-color-span-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/bogus-color-span-expected.checksum.
  • platform/mac/fast/css/bogus-color-span-expected.png: Copied from LayoutTests/platform/mac/css2.1/bogus-color-span-expected.png.
  • platform/mac/fast/css/bogus-color-span-expected.txt: Copied from LayoutTests/platform/mac/css2.1/bogus-color-span-expected.txt.
  • platform/mac/fast/css/css1_forward_compatible_parsing-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/css1_forward_compatible_parsing-expected.checksum.
  • platform/mac/fast/css/css1_forward_compatible_parsing-expected.png: Copied from LayoutTests/platform/mac/css2.1/css1_forward_compatible_parsing-expected.png.
  • platform/mac/fast/css/css1_forward_compatible_parsing-expected.txt: Copied from LayoutTests/platform/mac/css2.1/css1_forward_compatible_parsing-expected.txt.
  • platform/qt/css2.1/bogus-color-span-expected.txt: Removed.
  • platform/qt/css2.1/css1_forward_compatible_parsing-expected.txt: Removed.
  • platform/qt/fast/css/bogus-color-span-expected.txt: Copied from LayoutTests/platform/qt/css2.1/bogus-color-span-expected.txt.
  • platform/qt/fast/css/css1_forward_compatible_parsing-expected.txt: Copied from LayoutTests/platform/qt/css2.1/css1_forward_compatible_parsing-expected.txt.
17:28 Changeset [53663] by simon.fraser@apple.com
  • 5 edits
    6 adds in trunk

2010-01-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

-webkit-mask-box-image draws a box while loading
https://bugs.webkit.org/show_bug.cgi?id=33979
<rdar://problem/7378662>

Don't render masked elements until the mask images are fully loaded.

Test: http/tests/misc/slow-loading-mask.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages): Check that all mask images (both the single mask-box-image, and the possibly multiple mask-image) are fully loaded before allowing the masked content to render. If they are not fully loaded, use a fully transparent transparency layer.
  • rendering/style/FillLayer.h:
  • rendering/style/FillLayer.cpp: (WebCore::FillLayer::imagesAreLoaded): New utility function that returns true if the image in every FillLayer is loaded.
17:20 Changeset [53662] by bdakin@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Eric Seidel.

Skipping this until issues mentioned in https://bugs.webkit.org/show_bug.cgi?id=33923 are resolved.

  • platform/mac/Skipped:
17:07 Changeset [53661] by abarth@webkit.org
  • 5 edits
    1 copy in trunk/WebKitTools

2010-01-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make the EWS transactional
https://bugs.webkit.org/show_bug.cgi?id=33978

Now if the EWS gets interrupted in the middle of processing a patch,
the bots will re-process the patch.

  • Scripts/test-webkitpy:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/patchcollection.py:
  • Scripts/webkitpy/patchcollection_unittest.py: Added.
16:48 Changeset [53660] by darin@apple.com
  • 2 edits in trunk/WebCore

REGRESSION (r52795): New message created in response to mailto: URL has random character in message body
rdar://problem/7565902

Reviewed by Mark Rowe.

This regression affects the Mac OS X Mail application.
I was not able to find a simple way to create a regression test.

  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::SharedBuffer): Initialize m_size to 0 as in the other constructors.

16:40 Changeset [53659] by enrica@apple.com
  • 6 edits
    5 adds in trunk

Script tags are copied and pasted, making cross-domain attacks possible.
https://bugs.webkit.org/show_bug.cgi?id=33970

Reviewed by Darin Adler.

WebCore:

Tests: editing/pasteboard/paste-noscript-svg.html

editing/pasteboard/paste-visible-script.html

We remove the content and the attributes of every script tag before
pasting into the destination.

  • dom/Element.cpp:

(WebCore::Element::setAttributeMap): Now we are removing xlink:href
if it contains javascript protocol.

  • html/HTMLParser.cpp:

(WebCore::HTMLParser::parseToken): We strip all the script tag attributes
we are parsing to create a fragment to paste.

  • html/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::HTMLTokenizer):
(WebCore::HTMLTokenizer::scriptHandler): Removes the script text after it was parsed.

  • html/HTMLTokenizer.h:

LayoutTests:

  • editing/pasteboard/paste-noscript-svg-expected.txt: Added.
  • editing/pasteboard/paste-noscript-svg.html: Added.
  • editing/pasteboard/paste-visible-script-expected.txt: Added.
  • editing/pasteboard/paste-visible-script.html: Added.
  • editing/resources/svgcontent.xhtml: Added.
16:34 Changeset [53658] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-01-21 Adam Barth <abarth@webkit.org>

Unreviewed. Add missing "ago" for style in the status bubble.

  • QueueStatusServer/templates/statusbubble.html:
16:06 Changeset [53657] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-01-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Always create a prototype for automatically managed classes.


This fixes some errors where prototype chains were not correctly hooked
up, and also ensures that API classes work correctly with features like
instanceof.

  • API/JSClassRef.cpp: (OpaqueJSClass::create): Cleaned up some of this code. Also changed it to always create a prototype class.
  • API/tests/testapi.c: (Derived2_class): (main): Fixed a null value crash in the exception checking code.
  • API/tests/testapi.js: Added some tests for the case where a prototype chain would not be hooked up correctly.
15:22 Changeset [53656] by zimmermann@webkit.org
  • 9 edits
    8 adds in trunk

2010-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

<use> with % lengths does not update on window resize
https://bugs.webkit.org/show_bug.cgi?id=14639

appendChild broken for symbol-use
https://bugs.webkit.org/show_bug.cgi?id=24802

Test: svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml

svg/custom/svg/custom/relative-sized-use-on-symbol.xhtml

Fix reaction on window size changes for relative sized elements within <symbol> elements.
Don't evaluate SVGUseElement width/height attributes in order to propagate them to the shadow tree,
instead just propagate the attribute values itself so "100%" remains "100%" instead of being evaluated
to an absolute pixel value in the parent <svg> user-space.

Needs another fix in SVGStyledElement::childrenChanged(), which is a regression from my last <use>
patch, that hasn't been detected, as the use-dynamic-append.svg testcase was broken.

The combination of all the last <use> patches finally fixes the peepo.co.uk website, which was broken by several bugs for years.

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::childrenChanged): Need to mark shadow trees needing recalcs, even when parsing.
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged): Don't reclone for width/height attribute changes, just propagate them down the render tree (WebCore::updateContainerSize): Added helper function, updating the width/height attributes in the shadow tree. (WebCore::SVGUseElement::updateContainerSizes): (WebCore::SVGUseElement::buildShadowAndInstanceTree): Update container width/height after shadow tree creation, instead of doing it inbetween. (WebCore::SVGUseElement::buildShadowTree): Don't alter width/height attributes here anymore. (WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto. (WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto.
  • svg/SVGUseElement.h:
15:19 Changeset [53655] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=33972
Assertion failure in FrameLoader::checkLoadComplete()

I couldn't make a test for this, after trying rather hard. I'm not too worried, because such
a test has to depend on details of current implementation so intimately that it would become
ineffective very quickly anyway.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders): Stop the check timer, we don't need it after aborting load.
15:06 Changeset [53654] by bweinstein@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Added platform specific (incorrect) results for plugins/mouse-events* for Windows,
and removed mouse-events from the Windows Skipped list. The landing of correct results
for these tests is being tracked by <http://webkit.org/b/33973>.

  • platform/win/Skipped: Removed plugins/mouse-events from the Skipped List.
  • platform/win/plugins: Added.
  • platform/win/plugins/mouse-events-expected.txt: Added.
  • platform/win/plugins/mouse-events-fixedpos-expected.txt: Added.
15:04 Changeset [53653] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-21 Simon Fraser <simon.fraser@apple.com>

No review

Skip plugins/mouse-events-fixedpos.html on gtk, since it requires a special test plugin.

  • platform/gtk/Skipped:
14:53 Changeset [53652] by ossy@webkit.org
  • 2 edits in trunk/WebCore

Buildfix for r53646.

Reviewed by Dave Hyatt.

  • bindings/js/SerializedScriptValue.cpp: path of JSLock.h fixed.
14:40 QtWebKitGraphics created by noam.rosenthal@nokia.com
14:31 Changeset [53651] by ossy@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed buildfix after r53644.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::scroll): missing HAVE(ACCESSIBILITY) guard added.

14:24 Changeset [53650] by darin@chromium.org
  • 2 edits in trunk/WebCore

2010-01-21 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

Unnecessary call to HistoryItem::targetItem in HistoryController::pushState
https://bugs.webkit.org/show_bug.cgi?id=33969

  • loader/HistoryController.cpp: (WebCore::HistoryController::pushState): Remove unnecessary code.
14:17 Changeset [53649] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed, Chromium build fix. Add AccessibilityScrollbar.h and .cpp to WebCore.gypi

  • WebCore.gypi:
14:10 Changeset [53648] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

[chromium] Unreviewed build fix.

Fix possible use of initialized variable warning in release mode.

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::ZigZag::Deserializer::doDeserialize):

14:02 Changeset [53647] by ossy@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Unreviewed buildfix after r53644.

  • WebCore.pro: accessibility/AccessibilityScrollbar.cpp and accessibility/AccessibilityScrollbar.h added.
13:57 Changeset [53646] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Make sure to do a JSLock before deserialization of script values, since they can heap allocate.

Reviewed by Oliver Hunt.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValueData::deserialize):

13:54 Changeset [53645] by bweinstein@apple.com
  • 1 edit in trunk/WebCore/accessibility/AccessibilityAllInOne.cpp

Build fix, add new file to AccessibilityAllInOne

13:31 Changeset [53644] by bdakin@apple.com
  • 9 edits
    4 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=33923 REGRESSION
(Safari 4): AXValueChanged no longer sent for text area scrollbars
-and corresponding-
<rdar://problem/6942686>

Reviewed by Oliver Hunt.

New class AccessibilityScrollbar inherits directly from
AccessibilityObject.

  • accessibility/AccessibilityScrollbar.cpp: Added.

(WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::create):
(WebCore::AccessibilityScrollbar::valueForRange):

  • accessibility/AccessibilityScrollbar.h: Added.

(WebCore::AccessibilityScrollbar::setScrollbar):
(WebCore::AccessibilityScrollbar::roleValue):
(WebCore::AccessibilityScrollbar::accessibilityIsIgnored):
(WebCore::AccessibilityScrollbar::size):
(WebCore::AccessibilityScrollbar::elementRect):
(WebCore::AccessibilityScrollbar::parentObject):

AXObjectCache::getOrCreate() now has a case for ScrollBarRole,
which will create a new AccessibilityScrollbar. I also added a new
version of postNotification() that does not require a renderer. The
old postNotification() calls the new one.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::postNotification):

  • accessibility/AXObjectCache.h:

When AX is enabled, getOrCreate an AccessibilityScrollbar and send
a notification.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::scroll):

Fix project files.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=33923 REGRESSION
(Safari 4): AXValueChanged no longer sent for text area scrollbars
-and corresponding-
<rdar://problem/6942686>

Reviewed by Oliver Hunt.

  • platform/mac/accessibility/change-notification-on-scroll-expected.txt: Added.
  • platform/mac/accessibility/change-notification-on-scroll.html: Added.
13:08 Changeset [53643] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

2010-01-21 Simon Fraser <simon.fraser@apple.com>

No review

Skip plugins/mouse-events-fixedpos.html on Qt, since it requires a special test plugin.

  • platform/qt/Skipped:
13:04 Changeset [53642] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Force JSC to create a prototype chain for API classes with a
parent class but no static functions.

Reviewed by Geoff Garen.

13:02 Changeset [53641] by dimich@chromium.org
  • 5 edits in trunk

Add changes missing from r53595, without which Chromium has no database.

Patch by Eric Uhrhane <ericu@chromium.org> on 2010-01-21
Reviewed by Dmitry Titov.

https://bugs.webkit.org/show_bug.cgi?id=33966

No new tests - fixes database layout tests in Chromium.

WebCore:

  • bindings/v8/RuntimeEnabledFeatures.cpp:
  • bindings/v8/RuntimeEnabledFeatures.h:

WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):

13:01 Changeset [53640] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-01-21 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

[Chromium] Implement texSubImage2D taking WebGLArray
https://bugs.webkit.org/show_bug.cgi?id=33932

  • fast/canvas/webgl/tex-sub-image-2d-expected.txt: Added.
  • fast/canvas/webgl/tex-sub-image-2d.html: Added.

2010-01-21 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

[Chromium] Implement texSubImage2D taking WebGLArray
https://bugs.webkit.org/show_bug.cgi?id=33932

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texSubImage2D):
12:56 Changeset [53639] by jpetsovits@rim.com
  • 7 edits in trunk/WebCore

2010-01-21 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Adam Treat.

Don't call vgGetError()/eglGetError() repeatedly
https://bugs.webkit.org/show_bug.cgi?id=33959

For vgGetError(), I missed the part of the spec where
it says that calling that function clears the error
and subsequent calls will return VG_NO_ERROR again.

For eglGetError(), the specification doesn't mention
that kind of behavior, and interpretations seem to
differ between EGL implementations (even within
Khronos: the OpenVG reference implementation doesn't
reset the error code - and even mentions the difference
to vgGetError() in a comment - whereas the online
OpenGL ES API document explicitly specifies clearing
the error code).

It thus makes sense not to call either of the two
error functions more than once for checking a single
EGL/OpenVG call. This patch adapts assertions to
accommodate for this behavior, and also needs to
change surface creation methods as they previously
relied on multiple calls of eglGetError().

  • platform/graphics/openvg/EGLDisplayOpenVG.cpp: (WebCore::EGLDisplayOpenVG::sharedPlatformSurface): (WebCore::EGLDisplayOpenVG::createPbufferSurface):
  • platform/graphics/openvg/EGLDisplayOpenVG.h:
  • platform/graphics/openvg/EGLUtils.h:
  • platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::SurfaceOpenVG):
  • platform/graphics/openvg/SurfaceOpenVG.h:
  • platform/graphics/openvg/VGUtils.h:
12:46 Changeset [53638] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-01-21 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

Object.getOwnPropertyDescriptor always returns undefined for JS API objects
https://bugs.webkit.org/show_bug.cgi?id=33946

Ideally the getOwnPropertyDescriptor() reimplementation should return an
access descriptor that wraps the property getter and setter callbacks, but
that approach is much more involved than returning a value descriptor.
Keep it simple for now.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertyDescriptor):
  • API/tests/testapi.js:
12:19 Changeset [53637] by simon.fraser@apple.com
  • 7 edits
    2 adds in trunk

2010-01-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Hit testing on composited plugins is broken
https://bugs.webkit.org/show_bug.cgi?id=33927
<rdar://problem/7559069>

RenderWidget::paint()'s strategy of moving widgets at paint time, using tx and ty, was flawed
because tx,ty are not always root-relative, especially when painting into compositing layers.
This would move widgets to the wrong location, which caused hit testing issues.

Widgets are usually positioned by layout. The one time this was not true was scrolling fixed-position
elements, so we now reposition widgets after scrolling too.

There was a related problem, which was that widgets expect the graphics context to be set up for
root-relative painting. To fix this, adjust the CTM and the paintRect when the widget's frameRect
is in a different coordinate system to the painting offset.

Test: plugins/mouse-events-fixedpos.html

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged): Update widget positions, to handle widgets in fixed position elements, but only if we're not already inside of layout.
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::translate): Add a translate() convenience method that takes a FloatSize.
  • platform/graphics/IntSize.h: (WebCore::IntSize::isZero): Add a convenience method for testing for a zero size.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Adjust a comment.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Detect when the widget's frame is in a different coordinate system to painting, and adjust the CTM and paintRect in that case.
11:54 Changeset [53636] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-01-21 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
https://bugs.webkit.org/show_bug.cgi?id=33356

White list unix_hacker_style names in WebKit/gtk/webkit because these
are used in the GTK+ API.

  • Scripts/webkitpy/style/cpp_style.py:
  • Scripts/webkitpy/style/cpp_style_unittest.py:
11:38 Changeset [53635] by eric@webkit.org
  • 7 edits in trunk

2010-01-21 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=33945

  • platform/qt/Skipped:

2010-01-21 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=33945

  • Api/qwebsecurityorigin.cpp: (qt_drt_setDomainRelaxationForbiddenForURLScheme):

2010-01-21 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=33945

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
11:36 Changeset [53634] by steveblock@google.com
  • 4 edits in trunk/WebCore

[Android] bindings/v8/NPV8Object.cpp does not compile on Android
https://bugs.webkit.org/show_bug.cgi?id=33608

Patch by Andrei Popescu <andreip@google.com> on 2010-01-21
Reviewed by David Levin.

Use the standard WebKit header in bridge/npruntime.h.
Include PlatformBridge.h instead of ChroimiumBridge.h.
Add popupsAllowed() method to PlatformBridge.h on Android.
Add ARRAYSIZE_UNSAFE to PlatformBridge.h on Android.

No new tests, fixing the build.

  • bindings/v8/NPV8Object.cpp:

(_NPN_Evaluate):

  • bindings/v8/NPV8Object.h:
  • platform/android/PlatformBridge.h:
11:01 Changeset [53633] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-01-21 Andrei Popescu <andreip@google.com>

Reviewed by David Levin.

Add PlatformBridge.h header and a typedef to give ChromiumBridge a new name: PlatformBridge.
https://bugs.webkit.org/show_bug.cgi?id=33917

No new tests needed, this is just to allow other methods to call ChromiumBridge
using the new 'PlatformBridge' name.

  • platform/chromium/PlatformBridge.h: Added.
10:39 Changeset [53632] by ossy@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Unreviewed buildfix after r53625.

Cleanup MediaPlayer and MediaPlayerPrivateInterface to remove dead methods
https://bugs.webkit.org/show_bug.cgi?id=30106

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintMediaSliderTrack):

10:36 WebKit Team edited by ariya@webkit.org
I am no longer with Qt (diff)
10:24 Changeset [53631] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

2010-01-21 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Eric Carlson.

Start the test when the video element loads, which is less prone
to occasional cases where document.load is fired after video.load.

  • media/video-source-error-no-candidate.html:
  • media/video-source-error-no-candidate-expected.txt:
10:07 Changeset [53630] by steveblock@google.com
  • 3 edits in trunk/WebCore

[Android] bindings/v8/V8DOMWrapper.h[cpp] are missing guards for XPATH and XSLT features
https://bugs.webkit.org/show_bug.cgi?id=33944

Patch by Andrei Popescu <andreip@google.com> on 2010-01-21
Reviewed by David Levin.

Inside V8DOMWrapper.h[cpp], the code for XPATH and XSLT features is not guarded
by the appropriate #if ENABLE(feature) macros. Add the missing guards.
V8DOMWrapper.cpp includes ChromiumBridge.h for no reason. Remove the include.

No new tests needed, functionality not changed.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getTemplate):

  • bindings/v8/V8DOMWrapper.h:
09:46 Changeset [53629] by eric.carlson@apple.com
  • 4 edits
    2 adds in trunk

2010-01-21 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Intermittent crash when media element is adopted by another document
https://bugs.webkit.org/show_bug.cgi?id=33919
rdar://problem/7557527


Test: media/adopt-node-crash.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willMoveToNewOwnerDocument): Unregister for document callbacks. (WebCore::HTMLMediaElement::didMoveToNewOwnerDocument): Register for document callbacks.
  • html/HTMLMediaElement.h:

2010-01-21 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Intermittent crash when media element is adopted by another document
https://bugs.webkit.org/show_bug.cgi?id=33919
rdar://problem/7557527

This test does not always crash the un-patched version of WebKit because
the crash is so timing-dependant.

  • media/adopt-node-crash-expected.txt: Added.
  • media/adopt-node-crash.html: Added.
09:21 Changeset [53628] by aroben@apple.com
  • 2 edits in trunk/WebCore

More Windows build fixing

  • WebCore.vcproj/WebCore.vcproj: Copy bridge/jsc in the post-build

event of all configurations, not just Debug.

08:05 Changeset [53627] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix incorrect dependency to QtXmlPatterns in generated include/QtWebKit/QtWebKit header

Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2010-01-21
Reviewed by Simon Hausmann.

The generated file includes QtXmlPatterns/QtXmlPatterns, which is neither used/required by
the public QtWebKit API nor will it be available if Qt is configured with -no-xmlpatterns.

  • WebCore.pro: Trick syncqt to believe that xmlpatterns is not a dependency, so that it's not

included in the generated file. It'll still be used and linked to with this trick.

07:42 Changeset [53626] by steveblock@google.com
  • 2 edits in trunk/WebCore

Unreviewed build fix.

Copy BridgeJSC.h to generated headers on Windows

No new tests, build fix only.

  • WebCore.vcproj/WebCore.vcproj:
07:01 Changeset [53625] by eric.carlson@apple.com
  • 13 edits in trunk/WebCore

2010-01-21 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Cleanup MediaPlayer and MediaPlayerPrivateInterface to remove dead methods
https://bugs.webkit.org/show_bug.cgi?id=30106

No new tests, only dead code was removed.

  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::doSeek):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/wince/MediaPlayerPrivateWince.h:
06:54 Changeset [53624] by hausmann@webkit.org
  • 1 edit in trunk/WebCore/WebCore.pro

Oops, refix previous submit (patch conflict not resolved correctly)

06:52 Changeset [53623] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Simplify the qmake code for freezing QtWebKit on Symbian.

Patch by Iain Campbell <iain.campbell@accenture.com> on 2010-01-21
Reviewed by Simon Hausmann.

  • WebCore.pro:
05:49 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:42 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:08 Changeset [53622] by steveblock@google.com
  • 2 edits in trunk/WebCore

Unreviewed speculative build fix for Windows.

Adds missing include path for JSCBridge.h on Windows, added in http://trac.webkit.org/changeset/53620

No new tests, build fix only.

  • WebCore.vcproj/WebCoreCommon.vsprops:
04:30 Changeset [53621] by steveblock@google.com
  • 5 edits in trunk/WebCore

Unreviewed build fix.

Adds missing include path for JSCBridge.h, added in http://trac.webkit.org/changeset/53620

No new tests, build fix only.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
03:52 Changeset [53620] by steveblock@google.com
  • 7 edits
    1 copy
    1 move
    1 add in trunk/WebCore

Move bridge interfaces Field, Class, Instance and Array from Bridge to BridgeJSC
https://bugs.webkit.org/show_bug.cgi?id=33589

Reviewed by David Levin.

These interfaces use JSC-specific types, so are moved out of Bridge.h to allow the file to
be used with both JSC and V8.

No new tests, refactoring only.

  • Android.jscbindings.mk: Modified. Removed Bridge.cpp and added BridgeJSC.cpp
  • GNUmakefile.am: Modified. Removed Bridge.cpp and added BridgeJSC.[cpp|h]
  • WebCore.pro: Modified. Removed Bridge.cpp and added BridgeJSC.[cpp|h]
  • WebCore.xcodeproj/project.pbxproj: Modified. Removed Bridge.cpp and added BridgeJSC.[cpp|h]
  • WebCoreSources.bkl: Modified. Removed Bridge.cpp and added BridgeJSC.cpp
  • bridge/Bridge.cpp: Removed.
  • bridge/Bridge.h: Modfied. Moved Field, Class, Instance and Array interfaces to BridgeJSC.h
  • bridge/jsc: Added.
  • bridge/jsc/BridgeJSC.cpp: Copied from WebCore/bridge/Bridge.cpp.
  • bridge/jsc/BridgeJSC.h: Copied from WebCore/bridge/Bridge.h.
02:25 Changeset [53619] by steveblock@google.com
  • 3 edits in trunk/WebCore

Fixes style in WebCore/bridge/jni/JNIBridge
https://bugs.webkit.org/show_bug.cgi?id=33914

Reviewed by David Levin.

No new tests, style fixes only.

  • bridge/jni/JNIBridge.cpp:
  • bridge/jni/JNIBridge.h:
01:49 Changeset [53618] by hausmann@webkit.org
  • 15 edits
    2 adds in trunk

[Qt] Implement GraphicsLayer for accelerated layer compositing
https://bugs.webkit.org/show_bug.cgi?id=33514

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2010-01-21
Reviewed by Antti Koivisto.

.:

  • WebKit.pri: Addded compile flags to enable accelerated compositing

on versions higher than 4.5

WebCore:

No new tests: tests in LayoutTests/compositing are now relevant for
QtWebkit!

  • WebCore.pro: added accelerated-compositing related files
  • platform/graphics/GraphicsLayer.h: define Qt-specific implementation of GraphicsLayer
  • platform/graphics/qt/GraphicsLayerQt.cpp: Added.

(WebCore::GraphicsLayerQtImpl::): Implementation of GraphicsLayer with
a QGraphicsItem
(WebCore::GraphicsLayerQtImpl::ContentData::ContentData): save
pixmap/color info for directly composited content
(WebCore::GraphicsLayerQtImpl::State::State): save info for syncing
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): ctor
(WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl): dtor
(WebCore::GraphicsLayerQtImpl::setBaseTransform): set Qt
transformation in the way WebCore wants it
(WebCore::GraphicsLayerQtImpl::opaqueArea): calculate opaque area
based on info we have
(WebCore::GraphicsLayerQtImpl::boundingRect): reimp QGraphicsItem
(WebCore::GraphicsLayerQtImpl::paint): reimp QGraphicsItem
(WebCore::GraphicsLayerQtImpl::drawContents): draw HTML/Pixmap/Color
(WebCore::GraphicsLayerQtImpl::notifyChange): let WebCore know
something has changed
(WebCore::GraphicsLayerQtImpl::flushChanges): Make the changes appear
on screen by setting them to QGraphicsItems
(WebCore::GraphicsLayerQtImpl::notifyAnimationStarted): let WebCore
know the QAnimation started
(WebCore::GraphicsLayerQt::GraphicsLayerQt): ctor
(WebCore::GraphicsLayerQt::~GraphicsLayerQt): dtor
(WebCore::GraphicsLayer::create): hook for WebCore to know we're
implementing compositing
(WebCore::GraphicsLayer::compositingCoordinatesOrientation): hook for
WebCore to know we use a top-down system
(WebCore::GraphicsLayerQt::setNeedsDisplay): update the display
(WebCore::GraphicsLayerQt::setNeedsDisplayInRect): udpate part of the
display
(WebCore::GraphicsLayerQt::setName): reimp
(WebCore::GraphicsLayerQt::setParent): reimp
(WebCore::GraphicsLayerQt::setChildren): reimp
(WebCore::GraphicsLayerQt::addChild): reimp
(WebCore::GraphicsLayerQt::addChildAtIndex): reimp
(WebCore::GraphicsLayerQt::addChildAbove): reimp
(WebCore::GraphicsLayerQt::addChildBelow): reimp
(WebCore::GraphicsLayerQt::replaceChild): reimp
(WebCore::GraphicsLayerQt::removeFromParent): reimp
(WebCore::GraphicsLayerQt::setMaskLayer): reimp
(WebCore::GraphicsLayerQt::setPosition): reimp
(WebCore::GraphicsLayerQt::setAnchorPoint): reimp
(WebCore::GraphicsLayerQt::setSize): reimp
(WebCore::GraphicsLayerQt::setTransform): reimp
(WebCore::GraphicsLayerQt::setChildrenTransform): reimp
(WebCore::GraphicsLayerQt::setPreserves3D): reimp
(WebCore::GraphicsLayerQt::setMasksToBounds): reimp
(WebCore::GraphicsLayerQt::setDrawsContent): reimp
(WebCore::GraphicsLayerQt::setBackgroundColor): reimp
(WebCore::GraphicsLayerQt::clearBackgroundColor): reimp
(WebCore::GraphicsLayerQt::setContentsOpaque): reimp
(WebCore::GraphicsLayerQt::setBackfaceVisibility): reimp
(WebCore::GraphicsLayerQt::setOpacity): reimp
(WebCore::GraphicsLayerQt::setContentsRect): reimp
(WebCore::GraphicsLayerQt::setContentsToImage): reimp
(WebCore::GraphicsLayerQt::setContentsBackgroundColor): reimp
(WebCore::GraphicsLayerQt::setGeometryOrientation): reimp
(WebCore::GraphicsLayerQt::setContentsOrientation): reimp
(WebCore::GraphicsLayerQt::distributeOpacity): reimp
(WebCore::GraphicsLayerQt::accumulatedOpacity): reimp
(WebCore::GraphicsLayerQt::syncCompositingState): reimp
(WebCore::GraphicsLayerQt::nativeLayer): reimp (QGraphicsItem*)
(WebCore::GraphicsLayerQt::platformLayer): reimp (QGraphicsItem*)
(WebCore::solveEpsilon): copy from AnimationBase.cpp
(WebCore::solveCubicBezierFunction): copy from AniamtionBase.cpp
(WebCore::applyTimingFunction): use WebCore's timing and not Qt's
(WebCore::webkitAnimationToQtAnimationValue): safely figure out
animation values
(WebCore::AnimationQtBase::AnimationQtBase): base class for Qt-based
Webcore-initiated animations
(WebCore::AnimationQtBase::updateState): notify when an animation
starts
(WebCore::AnimationQtBase::duration): reimp QAbstractAnimation
(WebCore::AnimationQt:::AnimationQtBase):
(WebCore::AnimationQt::updateCurrentTime): realize keyframes from
progress
(WebCore::TransformAnimationQt::TransformAnimationQt): ctor
(WebCore::TransformAnimationQt::~TransformAnimationQt): dtor
(WebCore::TransformAnimationQt::applyFrame): set the actual QTransform
based on WebCore TransformOperations
(WebCore::TransformAnimationQt::updateState): change cache mode
(WebCore::OpacityAnimationQt::OpacityAnimationQt):
(WebCore::OpacityAnimationQt::applyFrame): change item's opacity
(WebCore::OpacityAnimationQt::updateState):
(WebCore::GraphicsLayerQt::addAnimation): convert WebCore Animation to
Qt Animation
(WebCore::GraphicsLayerQt::removeAnimationsForProperty):
(WebCore::GraphicsLayerQt::removeAnimationsForKeyframes):
(WebCore::GraphicsLayerQt::pauseAnimation):
(WebCore::GraphicsLayerQt::suspendAnimations):
(WebCore::GraphicsLayerQt::resumeAnimations):

  • platform/graphics/qt/GraphicsLayerQt.h: Added.
  • platform/qt/QWebPageClient.h: virtual functions for QGraphicsWebView

compositing
(QWebPageClient::setRootGraphicsLayer): let QGraphicsWebView know that
compositing has started/ended
(QWebPageClient::markForSync): let QGraphicsWebView know the
compositing layers need to sync, either soon or with the next update

WebKit/qt:

Here we have the QGraphicsWebView support for accelerated compositing

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewOverlay::q): access to container object
(QGraphicsWebViewOverlay::boundingRect): overlay has same rect as the
webview
(QGraphicsWebViewOverlay::paint): paint everything but the contents
(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): some vars needed
for accelerated compositing
(QGraphicsWebViewPrivate::):
(QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate):
(QGraphicsWebViewPrivate::setRootGraphicsLayer): make sure we have a
scrollbar overlay, and that the new graphics layer is parented by the
web-view
(QGraphicsWebViewPrivate::markForSync): flush changes at earliest
convenience or during the next draw

(QGraphicsWebViewPrivate::updateCompositingScrollPosition): sync the
position of the compositing layer with the scroll position
(QGraphicsWebViewPrivate::syncLayers): flush changes now
(QGraphicsWebViewPrivate::scroll): make sure we also move the
compositing layer
(QGraphicsWebViewPrivate::update): also update the overlay if needed
(QGraphicsWebView::QGraphicsWebView): initialize overlay with 0
(QGraphicsWebView::paint): paint only contents if we have an overlay,
sync the compositing layers now if needed
(QGraphicsWebView::setPage): also clean up the compositing
(QGraphicsWebView::updateGeometry): also update overlay geo
(QGraphicsWebView::setGeometry): also update overlay geo

  • Api/qgraphicswebview.h: reimp compositing stuff from QWebPageClient
  • Api/qwebsettings.cpp: init new settings flag for compositing as

false
(QWebSettingsPrivate::apply): apply new settings flag for compositing
(QWebSettings::QWebSettings):

  • Api/qwebsettings.h: new settings flag for compositing
  • Api/qwebview.cpp:

(QWebView::setPage): qwebview doesn't support compositing: always false

  • QGVLauncher/main.cpp:

(WebView::WebView): some more cmdline arguments + compositing
(MainWindow::init): some more cmdline arguments
(main): ditto

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::attachRootGraphicsLayer): reimp for
accel-compositing
(WebCore::ChromeClientQt::setNeedsOneShotDrawingSynchronization):
reimp for accel compositing
(WebCore::ChromeClientQt::scheduleCompositingLayerSync): reimp for
accel compositing

  • WebCoreSupport/ChromeClientQt.h: reimps for accel compositing
01:43 Changeset [53617] by philn@webkit.org
  • 3 edits in trunk/WebCore

2010-01-13 Philippe Normand <pnormand@igalia.com>

Reviewed by Oliver Hunt.

[GTK] handle media redirections
https://bugs.webkit.org/show_bug.cgi?id=33539

Media redirections support.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::mediaLocationChanged): (WebCore::MediaPlayerPrivate::loadNextLocation):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: (WebCore::MediaPlayerPrivate::pipelineReset):
01:27 Changeset [53616] by hausmann@webkit.org
  • 6 edits in trunk

No review, rolling out 53615 as it causes two
crashes on the bot.

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::createWindow):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::maybeDump):

LayoutTests:

  • platform/qt/Skipped:
01:12 Changeset [53615] by eric@webkit.org
  • 6 edits in trunk

2010-01-21 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Qt DRT: respect window.close() and window.closed()

Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().

This fixes the following tests:

plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html

https://bugs.webkit.org/show_bug.cgi?id=32953

  • platform/qt/Skipped:

2010-01-21 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Qt DRT: respect window.close() and window.closed()

Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().

This fixes the following tests:

plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html

https://bugs.webkit.org/show_bug.cgi?id=32953

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::createWindow): (WebCore::DumpRenderTree::windowCloseRequested):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::maybeDump):
01:02 Changeset [53614] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2010-01-21
Reviewed by Simon Hausmann.

Remove qWait() of the test when possible.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::loadFinished):
(tst_QWebPage::database):
(tst_QWebPage::testEnablePersistentStorage):
(tst_QWebPage::errorPageExtension):
(tst_QWebPage::screenshot):

00:42 Changeset [53613] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Prospective build fix for the Qt build.

Fix compilation against Qt without WebKit support by not including QtWebKit/QWebView
but widget.h instead and instantiating QWebView through a typedef, to ensure we're using
our locally built WebKit.

  • tests/hybridPixmap/widget.h:
  • tests/hybridPixmap/widget.ui:
00:37 Changeset [53612] by philn@webkit.org
  • 4 edits in trunk/LayoutTests

2010-01-20 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[Gtk] media/video-currentTime-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33897

Refactored the test to use the "seeked" event.

  • media/video-currentTime-set-expected.txt:
  • media/video-currentTime-set.html:
  • platform/gtk/Skipped:
00:25 Changeset [53611] by hausmann@webkit.org
  • 5 edits
    10 adds in trunk

WebCore: [Qt] Adding QPixmap/QImage support for the Qt hybrid layer

Allows accesing QPixmap and QImage based arguments from Qt signals,
slots and properties
This is done by an intermediate object that can be turned into
web-based objects by calling either toHTMLImageElement() or
toDataURL()

https://bugs.webkit.org/show_bug.cgi?id=32461

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2010-01-21
Reviewed by Simon Hausmann.

Tests are in WebKit/qt/tests/hybridPixmap

  • WebCore.pro:
  • bridge/qt/qt_pixmapruntime.cpp: Added.

(JSC::Bindings::QtPixmapWidthField::name): "width"
(JSC::Bindings::QtPixmapWidthField::valueFromInstance): width of
pixmap
(JSC::Bindings::QtPixmapWidthField::setValueToInstance): nothing
(JSC::Bindings::QtPixmapHeightField::name): "height"
(JSC::Bindings::QtPixmapHeightField::valueFromInstance): height of
pixmap
(JSC::Bindings::QtPixmapHeightField::setValueToInstance): nothing
(JSC::Bindings::QtPixmapRuntimeMethod::numParameters): 0
(JSC::Bindings::QtPixmapCreateElementMethod::name): toHTMLImageElement
(JSC::Bindings::QtPixmapCreateElementMethod::invoke): creates an HTML
element from the QPixmap
(JSC::Bindings::QtPixmapToDataUrlMethod::name): "toDataURL"
(JSC::Bindings::QtPixmapToDataUrlMethod::invoke): encodes the image to
a base64 data url
(JSC::Bindings::QtPixmapToStringMethod::name): "toString"
(JSC::Bindings::QtPixmapToStringMethod::invoke): [Qt Native Pixmap
w,h]

(JSC::Bindings::QtPixmapRuntimeObjectImp::createStructure):
runtime-object broilerplate
(JSC::Bindings::QtPixmapRuntimeObjectImp::classInfo): ditto
(JSC::Bindings::QtPixmapRuntimeObjectImp::QtPixmapRuntimeObjectImp):
ditto
(JSC::Bindings::): ditto
(JSC::Bindings::QtPixmapClass::QtPixmapClass): class for the
intermediate pixmap-holder
(JSC::Bindings::QtPixmapInstance::getClass): ditto
(JSC::Bindings::QtPixmapInstance::invokeMethod): ditto
(JSC::Bindings::QtPixmapClass::methodsNamed): toHTMLImageElement,
toDataURL
(JSC::Bindings::QtPixmapClass::fieldNamed): width, height
(JSC::Bindings::QtPixmapInstance::getPropertyNames):

toHTMLImageElement, toDataURL, width, height

(JSC::Bindings::QtPixmapInstance::defaultValue): nothing
(JSC::Bindings::QtPixmapInstance::valueOf): toString
(JSC::Bindings::data): holds a QVariant of type QImage/QPixmap
(JSC::Bindings::QtPixmapInstance::width): width of the image/pixmap
(JSC::Bindings::QtPixmapInstance::height): height of the image/pixmap
(JSC::Bindings::QtPixmapInstance::toPixmap): converts to a QPixmap
(JSC::Bindings::QtPixmapInstance::toImage): converts to a QImage
(JSC::Bindings::QtPixmapInstance::variantFromObject): makes sure this
is the right type of object, and creates a QVariant
(JSC::Bindings::QtPixmapInstance::createRuntimeObject): creates a new
intermediate pixmap holder from a QVariant
(JSC::Bindings::QtPixmapInstance::canHandle): returns true if a
QPixmap/QImage is required

  • bridge/qt/qt_pixmapruntime.h: Added.
  • bridge/qt/qt_runtime.cpp: hooks for the bridge

(JSC::Bindings::convertValueToQVariant): handle QPixmap/QImage if the
object is the intermediate pixmap holder or an HTMLImageElement
(JSC::Bindings::convertQVariantToValue): creates the intermediate
object from a QVariant of type QImage/QPixmap

WebKit/qt: [Qt] Adding QPixmap/QImage support for the Qt hybrid layer
https://bugs.webkit.org/show_bug.cgi?id=32461

Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2010-01-21
Reviewed by Simon Hausmann.

  • tests/hybridPixmap: Added.
  • tests/hybridPixmap/hybridPixmap.pro: Added.
  • tests/hybridPixmap/resources.qrc: Added.
  • tests/hybridPixmap/test.html: Added.
  • tests/hybridPixmap/tst_hybridPixmap.cpp: Added.

(tst_hybridPixmap::tst_hybridPixmap): tests most of the use cases for
hybrid pixmap/image manipulation
(tst_hybridPixmap::init): QTestLib initialization
(tst_hybridPixmap::cleanup): QTestLib cleanup
(tst_hybridPixmap::hybridPixmap): run the html file

  • tests/hybridPixmap/widget.cpp: Added.

(Widget::Widget):
(Widget::refreshJS):
(Widget::start):
(Widget::completeTest):
(Widget::setPixmap):
(Widget::pixmap):
(Widget::setImage):
(Widget::image):
(Widget::~Widget):
(Widget::changeEvent):
(Widget::compare):
(Widget::imageSlot):
(Widget::pixmapSlot):
(Widget::randomSlot):

  • tests/hybridPixmap/widget.h: Added.
  • tests/hybridPixmap/widget.ui: Added.
  • tests/tests.pro:
00:10 Changeset [53610] by eric@webkit.org
  • 9 edits in trunk

2010-01-21 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Custom select popups.
https://bugs.webkit.org/show_bug.cgi?id=33418

Optimization of the WebCore support to combobox popup delegate.

  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show):
  • platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::QtAbstractWebPopup): (WebCore::QtAbstractWebPopup::itemType):
  • platform/qt/QtAbstractWebPopup.h: (WebCore::QtAbstractWebPopup::): (WebCore::QtAbstractWebPopup::itemText): (WebCore::QtAbstractWebPopup::itemToolTip): (WebCore::QtAbstractWebPopup::itemIsEnabled): (WebCore::QtAbstractWebPopup::itemCount): (WebCore::QtAbstractWebPopup::view): (WebCore::QtAbstractWebPopup::geometry): (WebCore::QtAbstractWebPopup::currentIndex): (WebCore::QtAbstractWebPopup::font):

2010-01-21 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Custom select popups.
https://bugs.webkit.org/show_bug.cgi?id=33418

Adjusting QtFallbackWebPopupCombo to the changes in WebCore layer.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::QtFallbackWebPopupCombo): (WebCore::QtFallbackWebPopupCombo::showPopup): (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::hide): (WebCore::QtFallbackWebPopup::populate):
  • WebCoreSupport/QtFallbackWebPopup.h:
Note: See TracTimeline for information about the timeline view.