Timeline


and

01/26/10:

23:54 Changeset [53907] by dbates@webkit.org

2010-01-26 Daniel Bates <dbates@webkit.org>

Unreviewed. Made a minor typo when I added the test case fast/css/button-height.html
to the GTK Skipped file. In changeset 53900, I added test "fast/css/button-height.htm"
to the GTK Skipped file instead of "fast/css/button-height.html". See bug #33936
for more details.

  • platform/gtk/Skipped:
23:53 Changeset [53906] by ossy@webkit.org

[Qt] Failing tests after r53895 skipped.
https://bugs.webkit.org/show_bug.cgi?id=34167

  • platform/qt/Skipped:
    • http/tests/history/redirect-301.pl
    • http/tests/history/redirect-302.pl
    • http/tests/history/redirect-303.pl
    • http/tests/history/redirect-307.pl
23:46 Changeset [53905] by ossy@webkit.org

Unreviewed trivial fix.

  • platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: updated after r53873.
23:02 Changeset [53904] by ap@apple.com

More Windows build fixing.

  • win/tools/vsprops/common.vsprops: Disable warning C4180 (qualifier applied to function type has no meaning; ignored). This is a known bug - MSVC tries to compile a wrong specialization sometimes - but it's not instantiated, so it's harmless.
22:39 Changeset [53903] by ap@apple.com

More Windows build fixing.

  • wtf/HashTraits.h: _msize takes void*, remove const qualifier from type.
22:22 Changeset [53902] by ap@apple.com

Windows build fix.

  • wtf/HashTraits.h: Include malloc.h for _msize().
22:19 Changeset [53901] by ap@apple.com

Build fix.

  • wtf/HashTable.h: (WTF::HashTable::checkTableConsistencyExceptSize): Remove const from a static (empty) version of this function.
22:07 Changeset [53900] by dbates@webkit.org

2010-01-26 Daniel Bates <dbates@webkit.org>

Unreviewed. Updated expected failing results for table-percent-height.html
to reflect one pixel difference between the results generated by the Qt bot
and my machine. Added failing test fast/css/button-height.html to GTK Skipped
file as we need to look into this. See bug #33936 for more details.

  • platform/gtk/Skipped: Added failing test fast/css/button-height.html.
  • platform/qt/fast/replaced/table-percent-height-expected.txt: Updated result.
21:57 Changeset [53899] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=34150
WebKit needs a mechanism to catch stale HashMap entries

It is very difficult to catch stale pointers that are HashMap keys - since a pointer's hash
is just its value, it is very unlikely that any observable problem is reproducible.

This extends hash table consistency checks to check that pointers are referencing allocated
memory blocks, and makes it possible to invoke the checks explicitly (it is not feasible
to enable CHECK_HASHTABLE_CONSISTENCY by default, because that affects performance too much).

  • wtf/HashMap.h: (WTF::::checkConsistency): Call through to HashTable implementation. We can add similar calls to HashSet and HashCountedSet, but I haven't seen hard to debug problems with those yet.
  • wtf/HashSet.h: (WTF::::remove): The version of checkTableConsistency that's guarded by CHECK_HASHTABLE_CONSISTENCY is now called internalCheckTableConsistency().
  • wtf/HashTable.h: (WTF::HashTable::internalCheckTableConsistency): (WTF::HashTable::internalCheckTableConsistencyExceptSize): (WTF::HashTable::checkTableConsistencyExceptSize): Expose checkTableConsistency() even if CHECK_HASHTABLE_CONSISTENCY is off. (WTF::::add): Updated for checkTableConsistency renaming. (WTF::::addPassingHashCode): Ditto. (WTF::::removeAndInvalidate): Ditto. (WTF::::remove): Ditto. (WTF::::rehash): Ditto. (WTF::::checkTableConsistency): The assertion for !shouldExpand() was not correct - this function returns true for tables with m_table == 0. (WTF::::checkTableConsistencyExceptSize): Call checkValueConsistency for key. Potentially, we could do the same for values.
  • wtf/HashTraits.h: (WTF::GenericHashTraits::checkValueConsistency): An empty function that can be overridden to add checks. Currently, the only override is for pointer hashes.
  • wtf/RefPtrHashMap.h: (WTF::::remove): Updated for checkTableConsistency renaming.
21:54 Changeset [53898] by eric@webkit.org

2010-01-26 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

Add KeyboardTest to WebKit API tests
https://bugs.webkit.org/show_bug.cgi?id=34178

  • WebKit.gyp:
  • tests/KeyboardTest.cpp: Added.
21:29 Changeset [53897] by dbates@webkit.org

2010-01-26 Daniel Bates <dbates@webkit.org>

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29564

[Qt] Fixes an issue where the height of <button>- and
<input type="button">- elements are fixed to the height of the
button label font plus padding. That is, the CSS height property
is being ignored.

Instead, we should honor the user-specified height, if appropriate
for the platform and context. Notice, the Mac ports do not honor the
height for <input type="button"> elements unless a border and/or
background is also specified.

Test: fast/css/button-height.html

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle):

2010-01-26 Daniel Bates <dbates@webkit.org>

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=29564

Tests that the user-specified height for <button>- and <input type="button">-
elements are honored, if appropriate for the platform and context.

  • fast/css/button-height-expected.txt: Added.
  • fast/css/button-height.html: Added.
  • fast/replaced/table-percent-height-expected.txt: Added notice about failing tests in Windows ports.
  • fast/replaced/table-percent-height.html: Ditto.
  • platform/qt/fast/replaced/table-percent-height-expected.txt: Added.
21:26 Changeset [53896] by dbates@webkit.org

2010-01-26 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=34070

Moves the try/catch for OSError exceptions in Executive.run_command
to Credentials.read_credentials() so that the unit test
webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
assert that Executive.run_command throws an OSError exception.

  • Scripts/webkitpy/credentials.py:
  • Scripts/webkitpy/executive.py: Moved try/catch for OSError to method Credentials.read_credentials().
  • Scripts/webkitpy/executive_unittest.py: Removed tests that no longer apply: test_run_command_with_bad_command_check_return_code and test_run_command_with_bad_command_check_calls_error_handler. Added new test to assert that run_command throws OSError exceptions.
21:21 Changeset [53895] by eric@webkit.org

2010-01-26 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT WebHistory support
https://bugs.webkit.org/show_bug.cgi?id=34167

  • platform/qt/Skipped:

2010-01-26 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT WebHistory support
https://bugs.webkit.org/show_bug.cgi?id=34167

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::webHistoryItemCount): (LayoutTestController::keepWebHistory):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
21:04 Changeset [53894] by eric@webkit.org

2010-01-26 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Enable the Audits panel via a shortcut (Cmd/Ctrl+Alt+A)
https://bugs.webkit.org/show_bug.cgi?id=34158

  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
20:45 Changeset [53893] by tkent@chromium.org

2010-01-26 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::valueAsNumber support except type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=32696

input-valueasnumber-datetime-expected.txt and
input-valueasnumber-time-expected.txt have FAIL lines because they
test unimplemented features.

  • fast/forms/input-valueasnumber-date-expected.txt: Added.
  • fast/forms/input-valueasnumber-date.html: Added.
  • fast/forms/input-valueasnumber-datetime-expected.txt: Added.
  • fast/forms/input-valueasnumber-datetime.html: Added.
  • fast/forms/input-valueasnumber-month-expected.txt: Added.
  • fast/forms/input-valueasnumber-month.html: Added.
  • fast/forms/input-valueasnumber-number-expected.txt: Added.
  • fast/forms/input-valueasnumber-number.html: Added.
  • fast/forms/input-valueasnumber-range-expected.txt: Added.
  • fast/forms/input-valueasnumber-range.html: Added.
  • fast/forms/input-valueasnumber-time-expected.txt: Added.
  • fast/forms/input-valueasnumber-time.html: Added.
  • fast/forms/input-valueasnumber-unsupported-expected.txt: Added.
  • fast/forms/input-valueasnumber-unsupported.html: Added.
  • fast/forms/input-valueasnumber-week-expected.txt: Added.
  • fast/forms/input-valueasnumber-week.html: Added.
  • fast/forms/script-tests/input-valueasnumber-date.js: Added.
  • fast/forms/script-tests/input-valueasnumber-datetime.js: Added.
  • fast/forms/script-tests/input-valueasnumber-month.js: Added.
  • fast/forms/script-tests/input-valueasnumber-number.js: Added.
  • fast/forms/script-tests/input-valueasnumber-range.js: Added.
  • fast/forms/script-tests/input-valueasnumber-time.js: Added.
  • fast/forms/script-tests/input-valueasnumber-unsupported.js: Added.
  • fast/forms/script-tests/input-valueasnumber-week.js: Added.

2010-01-26 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::valueAsNumber support except type=datetime-local.
https://bugs.webkit.org/show_bug.cgi?id=32696

Tests: fast/forms/input-valueasnumber-date.html

fast/forms/input-valueasnumber-datetime.html
fast/forms/input-valueasnumber-month.html
fast/forms/input-valueasnumber-number.html
fast/forms/input-valueasnumber-range.html
fast/forms/input-valueasnumber-time.html
fast/forms/input-valueasnumber-unsupported.html
fast/forms/input-valueasnumber-week.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsNumber): According to the specification, we should return NaN for invalid values. (WebCore::HTMLInputElement::setValueAsNumber): According to the specification, throws NOT_SUPPORTED_ERR for Infinitiy or NaN, and throws INVALID_STATE_ERR for unsupported types. (WebCore::HTMLInputElement::formStringToDouble): According to the step 14 of Real Number in the specification, we should round -0 to 0.
  • html/HTMLInputElement.h: Declare valueAsNumber() and setValueAsNumber().
  • html/HTMLInputElement.idl: Add valueAsNumber.
20:44 WebKit Team edited by laszlo.1.gombos@nokia.com
add my nick (diff)
20:41 Changeset [53892] by hyatt@apple.com

Make sure there is a lock on serialize in SerializedScriptValueData, since type errors can be created when
exceptions are thrown.

Reviewed by Oliver Hunt.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValueData::serialize):

20:20 Changeset [53891] by eric@webkit.org

2010-01-26 Lyon Chen <liachen@rim.com>

Reviewed by Maciej Stachowiak.

Opcode.h use const void* for Opcode cause error #1211 for RVCT compiler
https://bugs.webkit.org/show_bug.cgi?id=33902

  • bytecode/Opcode.h:
20:17 Changeset [53890] by tkent@chromium.org

2010-01-26 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Add Date type support for Objective-C binding.
https://bugs.webkit.org/show_bug.cgi?id=32810

The Date type in IDLs is mapped to NSTimeInterval in Objective-C.

  • bindings/objc/DOMInternal.h: Add kit() and core() for NSTimeInterval.
  • bindings/scripts/CodeGenerator.pm: Make Date a primitive type.
  • bindings/scripts/CodeGeneratorJS.pm: Move some code for the CodeGeenrator.pm change.
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm: Move some code for the CodeGeenrator.pm change.
  • html/HTMLInputElement.idl: Remove Objective-C exclusion for valueAsDate.
20:09 Changeset [53889] by tkent@chromium.org

2010-01-26 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[Win] Add modifiers parameter support to Windows DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=34068

Remove listbox-deselect-scroll.html and listbox-selectio-2.html
from Skipped. We improved their portability and Windows DRT now
havs modifiers parameter of eventSender.mouseDown() and
eventSender.mouseUp().

  • platform/win/Skipped:

2010-01-26 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[Win] Add modifiers parameter support to Windows DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=34068

Add support for functional name modifiers; "addSelectionKey" and
"rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
and eventSender.mouseUp().
This change is similar to r53498 for Mac.

  • DumpRenderTree/win/EventSender.cpp: (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM. (mouseDownCallback): Call buidlModifiersFlags(). (mouseUpCallback): ditto. (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
19:58 Changeset [53888] by cjerdonek@webkit.org

No review: fixing broken autoinstall.py

19:04 Changeset [53887] by cjerdonek@webkit.org

2010-01-26 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Eric Seidel.

The Python autoinstall cache directory now only gets created
in the directory containing autoinstall.py.

https://bugs.webkit.org/show_bug.cgi?id=33365

  • Scripts/webkitpy/autoinstall.py:
    • Also added a README file to the cache directory saying where it came from.
18:56 Changeset [53886] by dimich@chromium.org

Not reviewed, attempt to fix Tiger build.

  • rendering/RenderTreeAsText.cpp:

(WebCore::write): Use UNUSED_PARAM macros to prevent compiler warning on targets without accelerated compositing.

18:54 Changeset [53885] by rolandsteiner@chromium.org

Incorrect boolean expression in isMailBlockquote() (WebCore/htmlediting.cpp)
https://bugs.webkit.org/show_bug.cgi?id=34156

Reviewed by Darin Adler.

No new tests (minor code change).

  • editing/htmlediting.cpp:

(WebCore::isMailBlockquote):

18:25 Changeset [53884] by pkasting@chromium.org

Handle broken images more correctly in the open-source image decoders.
https://bugs.webkit.org/show_bug.cgi?id=33747

Reviewed by David Levin.

No tests since Safari doesn't use these decoders and there's already a
broken-image test in the tree.

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::createFrameAtIndex): No need to check isSizeAvailable() since size() is now always safe.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::size): Don't assert that the bitmap is valid; we don't need a complete successful decode to be able to give info about the size.

  • platform/image-decoders/qt/RGBA32BufferQt.cpp:

(WebCore::RGBA32Buffer::setSize): Don't set the frame to complete on failure, since it's not complete, but empty, and callers can better handle empty frames.

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::RGBA32Buffer::setSize): Don't set the frame to complete on failure, since it's not complete, but empty, and callers can better handle empty frames.

18:23 Changeset [53883] by zimmermann@webkit.org

2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Synchronize Qt/Gtk build systems with Mac/Win, should fix Qt compilation. Gtk results still pending.

  • GNUmakefile.am:
  • WebCore.pro:
18:14 Changeset [53882] by cjerdonek@webkit.org

2010-01-26 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Eric Seidel.

Moved the check-webkit-style processors into a new
webkitpy/style/processors directory.

https://bugs.webkit.org/show_bug.cgi?id=34060

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/style/cpp_style.py: Removed.
  • Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
  • Scripts/webkitpy/style/processors: Added.
  • Scripts/webkitpy/style/processors/init.py: Added.
  • Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
  • Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
  • Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
  • Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
  • Scripts/webkitpy/style/text_style.py: Removed.
  • Scripts/webkitpy/style/text_style_unittest.py: Removed.
  • Scripts/webkitpy/style/unittests.py:
18:02 Changeset [53881] by zimmermann@webkit.org

2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to fix V8 - change SetterMethod function signatures, just like it has been done for JSSVGPODTypeWrapper.

  • bindings/v8/V8SVGPODTypeWrapper.h:
17:53 Changeset [53880] by zimmermann@webkit.org

2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewd. Revert Base.xcconfig changes, was not meant to be committed.

  • Configurations/Base.xcconfig:
17:51 Changeset [53879] by zimmermann@webkit.org

2010-01-26 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Oliver Hunt.

SVG consumes way too much memory to store animated properties in the DOM
https://bugs.webkit.org/show_bug.cgi?id=34188

Shrink WebCore library size to 75% (measured in debug builds) and reduce SVG memory usage to <25%.
Adding Oliver testcase as manual-tests/svg-node-count-vs-scroll.xhtml, which creates an arbitary number of
rects (50.000 <rect> elements added to the DOM by default) - memory usage down to 111M from 503M (RPRVT).
The SVG DOM side is almost fine, still some optimizations possible, that will be implemented soon - next
target is the SVG render tree, there are plenty of possibilities to reduce memory usage there.

Redesign the way we store animated properties in the individual SVG*Element files. Short story: In order
to support SVG DOM through the bindings (e.g. JS) we need to associate SVGAnimatedProperty objects with
the SVGElement object that created it - we used to store this pointer directly in the SVGAnimatedProperty.
This means, every SVGAnimatedProperty stored in a SVGRectElement, stored a pointer to the SVGRectElement, resulting
in excessive memory usage. This is now properly implemented, without wasting tons of memory. Unfortunately this
requires touching all SVG*Element files.

Detailed list of changes:

  • Remove template bloat by not specializing class templates for each attributeName/tagName combination. Instead SVGAnimatedProperty is a non-specialized template class now, only depending on the AnimatedType (ie. SVGLength for SVGAnimatedLength) -> This heavily reduces the generated code, thus shrinking WebCore size. I hope we can build windows again without SVGAllInOne.cpp
  • Remove "exportStrings" / "exportString" handling from make_names.pl - SVG defined string literals for each QualifiedName, in order to use template specialization based on "const char*" parameters. All that bloat is gone, so there's no need for it anymore.
  • Redesign SVGAnimatedProperty so it does not need any back-pointers to the SVGElement that created it
  • Don't actually store the XML DOM attribute name associated with a SVG DOM property in SVGAnimatedProperty, move the associatedAttributeName() function inside the macro declaration and just return the passed macro parameter DOMAttribute there, storing is inefficient and useless.
  • Remove SynchronizablePropertyController, which was living in SVGElement as member variable, keeping a HashMap<AttributeName, SVGAnimatedProperty>. It was needed before to lookup a SVGAnimatedProperty for a XML DOM attribute, in order to synchronize SVG <-> XML dom properties/attributes. Instead just add a "synchronizeProperty(const QualifiedName&)" method to all SVG*Element classes. As each SVG*Element class knows about its animated properties it can just ask them to synchronize themselves - no need for any dynamic lookups anymore.
  • Remove SynchronizableTypeWrapper which added more complexity for the sake of SVG <-> XML DOM synchronization, all replaced by synchronizeProperty.
  • Pass around any POD objects as const references, instead of copying them for no reason.
  • Clean up SVGAnimatedProperty, splitting up into SVGAnimatedProperty/PropertySynchronizer/PropertyTraits.
  • Remove baseValue/setBaseValue code from SVGDocumentExtensions, not needed anymore.

... and tons of changes to all SVG*Element classes, adapting to the new way of handling animated properties.

  • GNUmakefile.am: Remove Synchronizable* from build, add new SVGAnimatedPropertySynchronizer/Traits files
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSSVGPODTypeWrapper.h: Change synchronization callback signatures, as we pass around const-references now.
  • dom/Element.cpp: Let updateAnimatedSVGAttribute take a QualifiedName instead of pure Strings. (WebCore::Element::getAttribute): (WebCore::Element::hasAttributes):
  • dom/Element.h: (WebCore::Element::updateAnimatedSVGAttribute): (WebCore::Element::attributes):
  • dom/make_names.pl: Remove SVG specific "exportString" / "exportStrings" functionality, see above.
  • html/HTMLAttributeNames.in: Remove "exportString" tag from "className" attribute.
  • manual-tests/svg-node-count-vs-scroll.xhtml: Added. Can be used to verify memory consumption with a lot of DOM objects.
  • mathml/mathattrs.in: MathML doesn't need "exportStrings" - remove it.
  • mathml/mathtags.in: Ditto.
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::SVGAElement): (WebCore::SVGAElement::synchronizeProperty):
  • svg/SVGAElement.h:
  • svg/SVGAllInOne.cpp: Remove SynchronizablePropertyController.cpp
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::SVGAltGlyphElement): (WebCore::SVGAltGlyphElement::synchronizeProperty):
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
  • svg/SVGAnimatedProperty.h: Rewritten, see above for details. (WebCore::SVGAnimatedPropertyTearOff::create): (WebCore::SVGAnimatedPropertyTearOff::setBaseVal): (WebCore::SVGAnimatedPropertyTearOff::setAnimVal): (WebCore::SVGAnimatedPropertyTearOff::baseVal): (WebCore::SVGAnimatedPropertyTearOff::animVal): (WebCore::SVGAnimatedPropertyTearOff::associatedAttributeName): (WebCore::SVGAnimatedPropertyTearOff::SVGAnimatedPropertyTearOff): (WebCore::SVGAnimatedPropertyTearOff::~SVGAnimatedPropertyTearOff): (WebCore::SVGAnimatedProperty::~SVGAnimatedProperty): (WebCore::SVGAnimatedProperty::SVGAnimatedProperty): (WebCore::SVGAnimatedProperty::value): (WebCore::SVGAnimatedProperty::baseValue): (WebCore::SVGAnimatedProperty::setValue): (WebCore::SVGAnimatedProperty::setBaseValue): (WebCore::SVGAnimatedProperty::shouldSynchronize): (WebCore::SVGAnimatedProperty::setShouldSynchronize):
  • svg/SVGAnimatedPropertySynchronizer.h: Added. (WebCore::):
  • svg/SVGAnimatedPropertyTraits.h: Added. (WebCore::):
  • svg/SVGAnimatedTemplate.h: Move SVGAnimatedPropertyTraits into its own file. (WebCore::SVGAnimatedTemplate::forgetWrapper): (WebCore::lookupOrCreateWrapper):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::synchronizeProperty):
  • svg/SVGAnimationElement.h:
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::SVGCircleElement): (WebCore::SVGCircleElement::synchronizeProperty):
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::synchronizeProperty):
  • svg/SVGClipPathElement.h:
  • svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::synchronizeProperty):
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::SVGCursorElement): (WebCore::SVGCursorElement::synchronizeProperty):
  • svg/SVGCursorElement.h:
  • svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::SVGDefsElement): (WebCore::SVGDefsElement::synchronizeProperty):
  • svg/SVGDefsElement.h:
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp: Adapt to synchronization changes: use synchronizeProperty() call, instead of SynchronizablePropertyController. (WebCore::SVGElement::updateAnimatedSVGAttribute):
  • svg/SVGElement.h: Don't store SynchronizablePropertyController anymore, it's gone. (WebCore::SVGElement::synchronizeProperty): (WebCore::SVGElement::setSynchronizedSVGAttributes):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::SVGEllipseElement): (WebCore::SVGEllipseElement::synchronizeProperty):
  • svg/SVGEllipseElement.h:
  • svg/SVGExternalResourcesRequired.cpp:
  • svg/SVGExternalResourcesRequired.h:
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::synchronizeProperty):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::synchronizeProperty):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement): (WebCore::SVGFEComponentTransferElement::synchronizeProperty):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::SVGFECompositeElement): (WebCore::SVGFECompositeElement::parseMappedAttribute): (WebCore::SVGFECompositeElement::synchronizeProperty):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::synchronizeProperty):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (WebCore::SVGFEDisplacementMapElement::synchronizeProperty):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (WebCore::SVGFEGaussianBlurElement::synchronizeProperty):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::SVGFEImageElement): (WebCore::SVGFEImageElement::synchronizeProperty):
  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::SVGFELightElement): (WebCore::SVGFELightElement::synchronizeProperty):
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::SVGFEMergeNodeElement): (WebCore::SVGFEMergeNodeElement::synchronizeProperty):
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement): (WebCore::SVGFEMorphologyElement::synchronizeProperty):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::SVGFEOffsetElement): (WebCore::SVGFEOffsetElement::synchronizeProperty):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement): (WebCore::SVGFESpecularLightingElement::synchronizeProperty):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement): (WebCore::SVGFETileElement::synchronizeProperty):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement): (WebCore::SVGFETurbulenceElement::synchronizeProperty):
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::synchronizeProperty):
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes): (WebCore::SVGFilterPrimitiveStandardAttributes::synchronizeProperty):
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFitToViewBox.cpp:
  • svg/SVGFitToViewBox.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement): (WebCore::SVGFontElement::synchronizeProperty):
  • svg/SVGFontElement.h:
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::SVGForeignObjectElement): (WebCore::SVGForeignObjectElement::synchronizeProperty):
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::SVGGElement): (WebCore::SVGGElement::synchronizeProperty):
  • svg/SVGGElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::synchronizeProperty):
  • svg/SVGGradientElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::SVGImageElement): (WebCore::SVGImageElement::synchronizeProperty):
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::SVGLineElement): (WebCore::SVGLineElement::synchronizeProperty):
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::SVGLinearGradientElement): (WebCore::SVGLinearGradientElement::synchronizeProperty):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGList.h: Adapt to const-reference changes. (WebCore::SVGPODListItem::setValue):
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::SVGMPathElement): (WebCore::SVGMPathElement::synchronizeProperty):
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::synchronizeProperty):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::synchronizeProperty):
  • svg/SVGMaskElement.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::synchronizeProperty):
  • svg/SVGPathElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::synchronizeProperty):
  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::SVGPolyElement): (WebCore::SVGPolyElement::svgAttributeChanged): (WebCore::SVGPolyElement::synchronizeProperty):
  • svg/SVGPolyElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::SVGRadialGradientElement): (WebCore::SVGRadialGradientElement::synchronizeProperty):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::SVGRectElement): (WebCore::SVGRectElement::synchronizeProperty):
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::synchronizeProperty):
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement): (WebCore::SVGScriptElement::synchronizeProperty):
  • svg/SVGScriptElement.h:
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement): (WebCore::SVGStopElement::synchronizeProperty):
  • svg/SVGStopElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::SVGStyledElement::parseMappedAttribute): (WebCore::SVGStyledElement::synchronizeProperty):
  • svg/SVGStyledElement.h:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement): (WebCore::SVGStyledTransformableElement::synchronizeProperty):
  • svg/SVGStyledTransformableElement.h:
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::SVGSwitchElement): (WebCore::SVGSwitchElement::synchronizeProperty):
  • svg/SVGSwitchElement.h:
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::SVGSymbolElement): (WebCore::SVGSymbolElement::synchronizeProperty):
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::SVGTRefElement): (WebCore::SVGTRefElement::synchronizeProperty):
  • svg/SVGTRefElement.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement): (WebCore::SVGTextContentElement::synchronizeProperty):
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement): (WebCore::SVGTextElement::synchronizeProperty):
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::SVGTextPathElement): (WebCore::SVGTextPathElement::synchronizeProperty):
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::synchronizeProperty):
  • svg/SVGTextPositioningElement.h:
  • svg/SVGURIReference.cpp:
  • svg/SVGURIReference.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::synchronizeProperty):
  • svg/SVGUseElement.h:
  • svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement): (WebCore::SVGViewElement::synchronizeProperty):
  • svg/SVGViewElement.h:
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::SVGViewSpec):
  • svg/SVGViewSpec.h: (WebCore::SVGViewSpec::contextElement):
  • svg/SynchronizablePropertyController.cpp: Removed.
  • svg/SynchronizablePropertyController.h: Removed.
  • svg/SynchronizableTypeWrapper.h: Removed.
  • svg/svgattrs.in: Remove "exportStrings" tag.
  • svg/svgtags.in: Ditto.
  • svg/xlinkattrs.in:
17:35 Changeset [53878] by adele@apple.com

WebCore: Fix for <rdar://problem/7169464> REGRESSION (r47444): PLT is 1% slower due to implementation of :valid and :invalid CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=34029

Reviewed by Darin Adler.

If we never hit the valid or invalid selectors for a particular document,
then we'll skip the validity checks when deciding about style sharing.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:

(WebCore::Document::considerValidity):
(WebCore::Document::setConsiderValidity):

LayoutTests: Test for <rdar://problem/7169464> REGRESSION (r47444): PLT is 1% slower due to implementation of :valid and :invalid CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=34029

Reviewed by Darin Adler.

  • fast/css/pseudo-valid-dynamic-expected.txt: Added.
  • fast/css/pseudo-valid-dynamic.html: Added.
17:31 Changeset [53877] by jorlow@chromium.org

Revert 53797 as it seems to be causing crashes.
https://bugs.webkit.org/show_bug.cgi?id=34153

Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-26
Reviewed by Simon Fraser.

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::useSlowRepaintsIfNotOverlapped):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):

  • platform/ScrollView.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::destroy):

17:20 Changeset [53876] by dimich@chromium.org

DumpRenderTree silently crashes at the end of the run because geolocationControllerClient pointer is 0.
https://bugs.webkit.org/show_bug.cgi?id=34191

Reviewed by Steve Falkenburg.

  • page/GeolocationController.cpp:

(WebCore::GeolocationController::~GeolocationController): Add check for m_client being 0.
(WebCore::GeolocationController::addObserver): Ditto.
(WebCore::GeolocationController::removeObserver): Ditto.
(WebCore::GeolocationController::lastPosition): Ditto.

17:09 Changeset [53875] by ukai@chromium.org

2010-01-26 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix url used in websocket-event-target.html
https://bugs.webkit.org/show_bug.cgi?id=34066

  • websocket/tests/script-tests/websocket-event-target.js:
17:08 Changeset [53874] by simon.fraser@apple.com

2010-01-26 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson.

Enhance externalRepresentation() to make it more useful for layer debugging
https://bugs.webkit.org/show_bug.cgi?id=34143

Enhance externalRepresentation() to output additional information about layers when certain flags are passed.
The new flags allow you to show all layers (not just those that would paint), to the structure of the z-order
and normal flow lists, and to show which layers are composited.

  • WebCore.base.exp: The signature of externalRepresentation() changed.
  • platform/text/TextStream.h: Add operator<<(void*)
  • platform/text/TextStream.cpp: Implement operator<<(void*)
  • rendering/RenderLayer.h:
  • rendering/RenderLayer.cpp: (showLayerTree): New method outside the WebCore namespace, for ease of calling from gdb.
  • rendering/RenderTreeAsText.h: New behavior flags for externalRepresentation().
  • rendering/RenderTreeAsText.cpp: (WebCore::write): Output compositing information if requested. Also clean up some -1/1 magic numbers with an enum. (WebCore::writeLayers): If requested, show layer nesting via the z-order and normal flow lists. (WebCore::externalRepresentation): New arguments
17:00 Changeset [53873] by enrica@apple.com

Fixing for failing test on qt.
https://bugs.webkit.org/show_bug.cgi?id=34148

Reviewed by Jon Honeycutt.

Changed url in anchor tag to avoid the additional trailing slash.

  • editing/pasteboard/paste-noscript-xhtml-expected.txt:
  • editing/resources/htmlcontent.html:
16:36 Changeset [53872] by mitz@apple.com

Fixed an off-by-one error.

Reviewed by Simon Fraser.

  • rendering/break_lines.cpp:

(WebCore::shouldBreakAfter):

16:22 Changeset [53871] by dimich@chromium.org

Avoid reloading iframe on re-parenting between documents.
https://bugs.webkit.org/show_bug.cgi?id=32848

Reviewed by David Levin.

WebCore:

Achieved by setting a flag on iframe element when it is a target of document.adoptNode(node) operation.
The flag prevents unload/load cycle and is reset once element is attached to a new document.
If iframe is adopted but not actually inserted into the tree, it gets unloaded by async timer
once JS yields, to avoid having active content in non-attached iframe.

Test: fast/frames/iframe-reparenting.html

  • dom/Document.cpp:

(WebCore::Document::adoptNode): If the adopted node is iframe, set a remainsAliveOnRemovalFromTree on it.

  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
(WebCore::HTMLFrameElementBase::attach): Skip actual loading of the frame if it has remainsAliveOnRemovalFromTree flag. Reset the flag.
(WebCore::HTMLFrameElementBase::willRemove): Skip unloading the frame if it has remainsAliveOnRemovalFromTree flag set.
(WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree): Set the flag, start the async timer to check if the frame was actually attached.
(WebCore::HTMLFrameElementBase::checkAttachedTimerFired):

  • html/HTMLFrameOwnerElement.h:

(WebCore::HTMLFrameOwnerElement::willRemove): Move from private to protected, since it is conditionally called in HTMLFrameElementBase::willRemove now.

LayoutTests:

  • fast/frames/iframe-reparenting-expected.txt: Added.
  • fast/frames/iframe-reparenting.html: Added.
  • fast/frames/resources/iframe-reparenting-frame1.html: Added.
  • fast/frames/resources/iframe-reparenting-frame2.html: Added.
  • fast/frames/resources/iframe-reparenting-iframe-content.html: Added.
16:09 Changeset [53870] by kevino@webkit.org

[wx] Build fix, make sure stub function returns a value.

14:59 Changeset [53869] by aroben@apple.com

2010-01-26 Adam Roben <aroben@apple.com>

No review, rolling out r53861.
http://trac.webkit.org/changeset/53861
https://bugs.webkit.org/show_bug.cgi?id=33224

Caused 2 regression tests to fail.

  • fast/loader/stateobjects/document-destroyed-navigate-back-expected.txt:
  • fast/loader/stateobjects/document-destroyed-navigate-back.html:

2010-01-26 Adam Roben <aroben@apple.com>

No review, rolling out r53861.
http://trac.webkit.org/changeset/53861
https://bugs.webkit.org/show_bug.cgi?id=33224

Caused 2 regression tests to fail.

  • dom/Document.cpp: (WebCore::Document::detach): (WebCore::Document::registerHistoryItem): (WebCore::Document::unregisterHistoryItem):
  • dom/Document.h:
  • history/BackForwardList.cpp: (WebCore::BackForwardList::pushStateItem):
  • history/BackForwardListChromium.cpp: (WebCore::BackForwardList::pushStateItem):
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::setStateObject): (WebCore::HistoryItem::setDocument): (WebCore::HistoryItem::documentDetached):
  • history/HistoryItem.h: (WebCore::HistoryItem::document):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateWithinDocument): (WebCore::FrameLoader::loadItem):
  • loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState):
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
  • page/History.cpp: (WebCore::History::stateObjectAdded):
  • page/Page.cpp: (WebCore::Page::goToItem):
14:48 Changeset [53868] by mitz@apple.com

<rdar://problem/7576663> Crash caused by anonymous list item
https://bugs.webkit.org/show_bug.cgi?id=34183

Reviewed by Beth Dakin.

WebCore:

Test: fast/lists/anonymous-items.html

enclosingList() and previousListItem() were DOM-based, but in order to work with anonymous
list items, they need to work with rthe render tree.

  • rendering/RenderListItem.cpp:

(WebCore::isList): Factored out.
(WebCore::enclosingList): Added this variant that takes a RenderObject.
(WebCore::previousListItem): Changed to travers the render tree.
(WebCore::RenderListItem::calcValue): Use the RenderObject version of enclosingList()
(WebCore::RenderListItem::setExplicitValue): Added an assertion.
(WebCore::RenderListItem::clearExplicitValue): Ditto.

LayoutTests:

  • fast/lists/anonymous-items.html: Added.
  • platform/mac/fast/lists/anonymous-items-expected.checksum: Added.
  • platform/mac/fast/lists/anonymous-items-expected.png: Added.
  • platform/mac/fast/lists/anonymous-items-expected.txt: Added.
14:45 Changeset [53867] by bweinstein@apple.com

Crash in WebKit!WebCore::RenderMenuList::itemStyle
https://bugs.webkit.org/show_bug.cgi?id=34182
<rdar://7087757>

Reviewed by Jon Honeycutt.

Added bounds checks in RenderMenuList to make sure we are
not making an out of bounds check in a vector once an option
element has been deleted. If we are out of bounds, we fall back to
a default value and return early, and in the case of itemStyle, we use a
previous option's style, if it is available.

  • manual-tests/select-delete-item.html: Added.
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemText): If out of bounds check, return early.
(WebCore::RenderMenuList::itemToolTip): Ditto.
(WebCore::RenderMenuList::itemIsEnabled): Ditto.
(WebCore::RenderMenuList::itemStyle): If out of bounds check, try using the 0th index

option style, then fall back to the select's style if that option doesn't exist.

(WebCore::RenderMenuList::itemBackgroundColor): If out of bounds check, return early.
(WebCore::RenderMenuList::itemIsSeparator): Ditto.
(WebCore::RenderMenuList::itemIsLabel): Ditto.
(WebCore::RenderMenuList::itemIsSelected): Ditto.

14:20 Changeset [53866] by barraclough@apple.com

Whoops, fixerate ChangeLog.

14:00 Changeset [53865] by barraclough@apple.com

<<<<<<< .mine

13:14 Changeset [53864] by sfalken@apple.com

2010-01-26 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver Hunt.

Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175

2010-01-26 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver Hunt.

Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175

  • WebKit.vcproj/WebKit.vcproj:

2010-01-26 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver Hunt.

Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:

2010-01-26 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver Hunt.

Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
12:20 Changeset [53863] by cfleizach@apple.com

Another attempt to get this test to pass for GTK.

Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513

  • fast/events/tab-imagemap-expected.txt:
  • fast/events/tab-imagemap.html:
12:02 Changeset [53862] by kenneth@webkit.org

[Qt] Separating out the UrlLoader from the QtLauncher in it's
own implementation and header file.

Reviewed by Ariya Hidayat.

  • QtLauncher/main.cpp:

(main):

  • QtLauncher/urlloader.cpp: Added.

(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::init):
(UrlLoader::getUrl):

  • QtLauncher/urlloader.h: Added.
11:30 Changeset [53861] by darin@chromium.org

2010-01-25 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

Chains of history items representing same-document navigation need to
always remember that association

https://bugs.webkit.org/show_bug.cgi?id=33224

Replace HistoryItem's Document pointer with a DocumentSequenceNumber.
During session history traversal, if the current HistoryItem and the
target HistoryItem have the same DocumentSequenceNumber, then it means
that the current Document should remain.

NOTE: To support Chromium's serialization of HistoryItems, I generate
DocumentSequenceNumbers that are unique across application launches.
DocumentSequenceNumbers are generated using a counter initialized with
the time of day.

Test: fast/loader/stateobjects/document-destroyed-navigate-back.html

  • dom/Document.cpp: (WebCore::Document::detach):
  • dom/Document.h:
  • history/BackForwardList.cpp: (WebCore::BackForwardList::pushStateItem):
  • history/BackForwardListChromium.cpp: (WebCore::BackForwardList::pushStateItem):
  • history/HistoryItem.cpp: (WebCore::generateDocumentSequenceNumber): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::setStateObject):
  • history/HistoryItem.h: (WebCore::HistoryItem::setDocumentSequenceNumber): (WebCore::HistoryItem::documentSequenceNumber):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateWithinDocument): (WebCore::FrameLoader::loadItem):
  • loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState):
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleHistoryNavigation):
  • page/History.cpp: (WebCore::History::stateObjectAdded):
  • page/Page.cpp: (WebCore::Page::goToItem):
11:22 Changeset [53860] by oliver@apple.com

2010-01-26 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Using JavaScriptCore API with a webkit vended context can result in slow script dialog
https://bugs.webkit.org/show_bug.cgi?id=34172

Make the APIShim correctly increment and decrement the timeout
entry counter.

  • API/APIShims.h: (JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock): (JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock): (JSC::APICallbackShim::APICallbackShim): (JSC::APICallbackShim::~APICallbackShim):
11:00 Changeset [53859] by cfleizach@apple.com

One more attempt to get GTK version to pass.

Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513

  • fast/events/tab-imagemap-expected.txt:
  • fast/events/tab-imagemap.html:
10:51 Changeset [53858] by cfleizach@apple.com

Unreviewed.

Attempt to make this test pass on GTK.

Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513

  • fast/events/tab-imagemap.html:
10:06 Changeset [53857] by cfleizach@apple.com

Add ability for image maps to be focused via tabbing
https://bugs.webkit.org/show_bug.cgi?id=17513

Reviewed by Darin Adler.

WebCore:

Test: fast/events/tab-imagemap.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedImageMapUIElement):
(WebCore::AXObjectCache::focusedUIElementForPage):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityImageMapLink.h:

(WebCore::AccessibilityImageMapLink::areaElement):
(WebCore::AccessibilityImageMapLink::mapElement):
(WebCore::AccessibilityImageMapLink::isImageMapLink):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isImageMapLink):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::getPath):
(WebCore::HTMLAreaElement::getRect):
(WebCore::HTMLAreaElement::imageElement):
(WebCore::HTMLAreaElement::isKeyboardFocusable):
(WebCore::HTMLAreaElement::isFocusable):
(WebCore::HTMLAreaElement::dispatchBlurEvent):
(WebCore::HTMLAreaElement::updateFocusAppearance):
(WebCore::HTMLAreaElement::supportsFocus):

  • html/HTMLAreaElement.h:
  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):

  • html/HTMLMapElement.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawFocusRing):

  • platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::drawFocusRing):

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::drawFocusRingToContext):
(WebCore::GraphicsContext::drawFocusRing):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawFocusRing):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawFocusRing):

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawFocusRing):

  • platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::drawFocusRing):

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::drawFocusRing):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paint):
(WebCore::RenderImage::paintFocusRings):
(WebCore::RenderImage::imageMap):

  • rendering/RenderImage.h:
  • rendering/RenderReplaced.h:

LayoutTests:

  • fast/events/resources/tabindex-focus-blur-all.js:

(test):
(testProgrammaticFocus):

  • fast/events/tab-imagemap-expected.txt: Added.
  • fast/events/tab-imagemap.html: Added.
  • fast/events/tabindex-focus-blur-all-expected.txt:
08:39 Changeset [53856] by pfeldman@chromium.org

2010-01-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add support for breakpoints, messages and search into the SourceFrame2.

https://bugs.webkit.org/show_bug.cgi?id=34165

08:33 Changeset [53855] by pfeldman@chromium.org

2010-01-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hather.

Web Inspector: add methods for getting resource content from within frontend.

https://bugs.webkit.org/show_bug.cgi?id=34163

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getResourceContent):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetResourceContent):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.getResourceContent):
  • inspector/front-end/InspectorFrontendHostStub.js:
07:18 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
07:09 Changeset [53854] by hausmann@webkit.org

[Qt] Fix compilation of QtScript with non-gcc compilers

Variable length stack arrays are a gcc extension. Use QVarLengthArray
as a more portable solution that still tries to allocate on the stack
first.

  • qt/api/qscriptvalue_p.h:

(QScriptValuePrivate::call):

06:13 Changeset [53853] by hausmann@webkit.org

[Qt] Fix the build on platforms without JIT support.

Reviewed by Tor Arne Vestbø.

The JIT support should be determined at compile-time via wtf/Platform.h

  • qt/api/QtScript.pro:
06:02 Changeset [53852] by pfeldman@chromium.org

2010-01-26 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: added null check into the timeline agent getter.

  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::retrieve):
05:39 Changeset [53851] by eric@webkit.org

2010-01-26 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Show comboboxes on Maemo 5
https://bugs.webkit.org/show_bug.cgi?id=34088

Don't try to show the combobox by simulating a mouse event from QCursor::pos() to
get the combobox position right. The position on Maemo 5 is independent from the mouse
and there's no QCursor::pos().

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show):
05:00 Changeset [53850] by eric@webkit.org

2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

First steps of the QtScript API.

Two new classes were created; QScriptEngine and QScriptValue.
The first should encapsulate a javascript context and the second a script
value.

This API is still in development, so it isn't compiled by default.
To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
build-webkit.

https://bugs.webkit.org/show_bug.cgi?id=32565

  • WebKit.pro:

2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

First steps of the QtScript API.

Two new classes were created; QScriptEngine and QScriptValue.
The first should encapsulate a javascript context and the second a script
value.

This API is still in development, so it isn't compiled by default.
To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
build-webkit.

https://bugs.webkit.org/show_bug.cgi?id=32565

  • qt/api/QtScript.pro: Added.
  • qt/api/qscriptconverter_p.h: Added. (QScriptConverter::toString):
  • qt/api/qscriptengine.cpp: Added. (QScriptEngine::QScriptEngine): (QScriptEngine::~QScriptEngine): (QScriptEngine::evaluate): (QScriptEngine::collectGarbage):
  • qt/api/qscriptengine.h: Added.
  • qt/api/qscriptengine_p.cpp: Added. (QScriptEnginePrivate::QScriptEnginePrivate): (QScriptEnginePrivate::~QScriptEnginePrivate): (QScriptEnginePrivate::evaluate):
  • qt/api/qscriptengine_p.h: Added. (QScriptEnginePrivate::get): (QScriptEnginePrivate::collectGarbage): (QScriptEnginePrivate::makeJSValue): (QScriptEnginePrivate::context):
  • qt/api/qscriptvalue.cpp: Added. (QScriptValue::QScriptValue): (QScriptValue::~QScriptValue): (QScriptValue::isValid): (QScriptValue::isBool): (QScriptValue::isBoolean): (QScriptValue::isNumber): (QScriptValue::isNull): (QScriptValue::isString): (QScriptValue::isUndefined): (QScriptValue::isError): (QScriptValue::isObject): (QScriptValue::isFunction): (QScriptValue::toString): (QScriptValue::toNumber): (QScriptValue::toBool): (QScriptValue::toBoolean): (QScriptValue::toInteger): (QScriptValue::toInt32): (QScriptValue::toUInt32): (QScriptValue::toUInt16): (QScriptValue::call): (QScriptValue::engine): (QScriptValue::operator=): (QScriptValue::equals): (QScriptValue::strictlyEquals):
  • qt/api/qscriptvalue.h: Added. (QScriptValue::):
  • qt/api/qscriptvalue_p.h: Added. (QScriptValuePrivate::): (QScriptValuePrivate::get): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isValid): (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::isError): (QScriptValuePrivate::isObject): (QScriptValuePrivate::isFunction): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toInteger): (QScriptValuePrivate::toInt32): (QScriptValuePrivate::toUInt32): (QScriptValuePrivate::toUInt16): (QScriptValuePrivate::equals): (QScriptValuePrivate::strictlyEquals): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::call): (QScriptValuePrivate::engine): (QScriptValuePrivate::context): (QScriptValuePrivate::value): (QScriptValuePrivate::object): (QScriptValuePrivate::inherits): (QScriptValuePrivate::isJSBased): (QScriptValuePrivate::isNumberBased): (QScriptValuePrivate::isStringBased):
  • qt/api/qtscriptglobal.h: Added.
  • qt/tests/qscriptengine/qscriptengine.pro: Added.
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: Added. (tst_QScriptEngine::tst_QScriptEngine): (tst_QScriptEngine::~tst_QScriptEngine): (tst_QScriptEngine::init): (tst_QScriptEngine::cleanup): (tst_QScriptEngine::collectGarbage): (tst_QScriptEngine::evaluate):
  • qt/tests/qscriptvalue/qscriptvalue.pro: Added.
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp: Added. (tst_QScriptValue::tst_QScriptValue): (tst_QScriptValue::~tst_QScriptValue): (tst_QScriptValue::init): (tst_QScriptValue::cleanup): (tst_QScriptValue::ctor): (tst_QScriptValue::toString_data): (tst_QScriptValue::toString): (tst_QScriptValue::copyConstructor_data): (tst_QScriptValue::copyConstructor): (tst_QScriptValue::assignOperator_data): (tst_QScriptValue::assignOperator): (tst_QScriptValue::dataSharing): (tst_QScriptValue::constructors_data): (tst_QScriptValue::constructors): (tst_QScriptValue::call):
  • qt/tests/tests.pri: Added.
  • qt/tests/tests.pro: Added.

2010-01-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

First steps of the QtScript API.

Two new classes were created; QScriptEngine and QScriptValue.
The first should encapsulate a javascript context and the second a script
value.

This API is still in development, so it isn't compiled by default.
To trigger compilation, pass --qmakearg="CONFIG+=build-qtscript" to
build-webkit.

https://bugs.webkit.org/show_bug.cgi?id=32565

  • docs/qtwebkit.qdocconf:
04:05 Changeset [53849] by eric@webkit.org

2010-01-26 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Moves JSC-specific classes from bridge/jni/JNIBridge to bridge/jni/jsc/JNIBridgeJSC
https://bugs.webkit.org/show_bug.cgi?id=33958

This allows bridge/jni/JNIBridge to be used with both JSC and V8.
A later change will add the V8 equivalent of these JSC-specific classes.

No new tests, refactoring only.

  • Android.jscbindings.mk: Modified. Added JNIBridgeJSC.cpp
  • GNUmakefile.am: Modified. Added JNIBridgeJSC.h
  • WebCore.xcodeproj/project.pbxproj: Modified. Added JNIBridgeJSC.[cpp|h]
  • bridge/jni/JNIBridge.cpp: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.cpp (appendClassName): Modfied. Guard calls to JSLock (JavaMethod::signature): Modfied. Guard calls to JSLock
  • bridge/jni/JNIBridge.h: Modified. Moved JavaField and JavaArray to JNIBridgeJSC.h
  • bridge/jni/jsc/JNIBridgeJSC.cpp: Copied from WebCore/bridge/jni/JNIBridge.cpp.
  • bridge/jni/jsc/JNIBridgeJSC.h: Copied from WebCore/bridge/jni/JNIBridge.h.
  • bridge/jni/jsc/JNIUtilityPrivate.cpp: Modified. Include JNIBridgeJSC.h
  • bridge/jni/jsc/JavaClassJSC.h: Modified. Include JNIBridgeJSC.h
  • bridge/jni/jsc/JavaInstanceJSC.cpp: Modified. Include JNIBridgeJSC.h
03:06 Changeset [53848] by jocelyn.turcotte@nokia.com

Unreviewed build fix.

[Qt] Fix Windows build when sqlite is not available.

  • WebCore.pri:
  • WebCore.pro:
02:44 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
02:40 Changeset [53847] by hausmann@webkit.org

WebCore: [Qt] JavaScript prompt is currently broken.
https://bugs.webkit.org/show_bug.cgi?id=30914

Patch by Holger Hans Peter Freyther <zecke@selfish.org> on 2010-01-26
Reviewed by Simon Hausmann.

Remove the manual test case in favor of an automated
test case in WebKit/qt/tests/qwebpage.

  • manual-tests/qt/java-script-prompt.html: Removed.

WebKit/qt: [Qt] JavaScript prompt is currently broken
https://bugs.webkit.org/show_bug.cgi?id=30914

Patch by Holger Hans Peter Freyther <zecke@selfish.org> on 2010-01-26
Reviewed by Simon Hausmann.

In r52152 a patch was landed to convert a null QString
to an empty WebCore::String in case the prompt was accepted
but the default implementation returned the null QString.

The patch tried to avoid assign to result twice and
was not checking the QString if it is null but the default
value. This lead to always returning an empty string on
successful prompts. Fix it by checking the variable 'x'
for isNull.

The manual test case used didn't cover the case of non
empty input, replace it with an automatic test case that
should cover all cases.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::runJavaScriptPrompt): Fix the bug.

  • tests/qwebpage/tst_qwebpage.cpp: Add automatic test case

(JSPromptPage::JSPromptPage):
(JSPromptPage::javaScriptPrompt):
(tst_QWebPage::testJSPrompt):

02:18 Changeset [53846] by pfeldman@chromium.org

2010-01-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement HTML and CSS highlighters.

https://bugs.webkit.org/show_bug.cgi?id=34144

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/JavaScriptTokenizer.js: Removed.
  • inspector/front-end/JavaScriptTokenizer.re2js: Removed.
  • inspector/front-end/SourceCSSTokenizer.js: Added. (WebInspector.SourceCSSTokenizer): (WebInspector.SourceCSSTokenizer.prototype._stringToken): (WebInspector.SourceCSSTokenizer.prototype._isPropertyValue): (WebInspector.SourceCSSTokenizer.prototype.nextToken):
  • inspector/front-end/SourceCSSTokenizer.re2js: Added.
  • inspector/front-end/SourceHTMLTokenizer.js: Added. (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js: Added.
  • inspector/front-end/SourceJavaScriptTokenizer.js: Added. (WebInspector.SourceJavaScriptTokenizer): (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
  • inspector/front-end/SourceJavaScriptTokenizer.re2js: Added.
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype._highlightLines): (WebInspector.TextEditorHighlighter.Tokenizer): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set line): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.set condition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.get condition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.hasCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.getLexCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype.setLexCondition): (WebInspector.TextEditorHighlighter.Tokenizer.prototype._charAt):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
02:04 Changeset [53845] by hausmann@webkit.org

REGRESSION(r53835): Fix editing/pasteboard/paste-noscript-xhtml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=34157

Reviewed by Holger Freyther.

WebCore:

Pass the FragmentScriptingPermission correctly through to the DOM
and disallow scripting elements in parseEndElement(), similar to
the libxml tokenizer change in r53835.

  • dom/XMLTokenizerQt.cpp:

(WebCore::handleElementNamespaces):
(WebCore::handleElementAttributes):
(WebCore::XMLTokenizer::parseStartElement):
(WebCore::XMLTokenizer::parseEndElement):

LayoutTests:

Add Qt specific result for this test that differs from the cross-platform
result in only one character: In htmlcontent.html the href attribute value
is http://www.cnn.com, which somehow becomes http://www.cnn.com/ in the cross
platform result. With the Qt xml parser that attribute is somehow preserved
and so our result does not have the trailing slash.

  • platform/qt/editing/pasteboard/paste-noscript-xhtml-expected.txt: Added.
01:42 Changeset [53844] by tkent@chromium.org

2010-01-26 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

Convert textarea-rows-cols.html to dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=34074

  • fast/forms/script-tests/textarea-rows-cols.js: Added.
  • fast/forms/textarea-rows-cols-expected.txt: Added.
  • fast/forms/textarea-rows-cols.html:
  • platform/mac/fast/forms/textarea-rows-cols-expected.checksum: Removed.
  • platform/mac/fast/forms/textarea-rows-cols-expected.png: Removed.
  • platform/mac/fast/forms/textarea-rows-cols-expected.txt: Removed.
  • platform/qt/fast/forms/textarea-rows-cols-expected.txt: Removed.
  • platform/win/fast/forms/textarea-rows-cols-expected.txt: Removed.
01:40 Changeset [53843] by eric@webkit.org

2010-01-26 Garret Kelly <gdk@chromium.org>

Reviewed by Eric Seidel.

Add missing declaration for the feMorphology SVG element.
https://bugs.webkit.org/show_bug.cgi?id=34151

  • bindings/v8/V8DOMWrapper.cpp:
00:30 Changeset [53842] by zoltan@webkit.org

Unreviewed build fix.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-01-26
[Qt] Build fix after API changes in r53835.

No new tests needed.

  • dom/XMLTokenizerQt.cpp:

(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::parseXMLDocumentFragment):

01/25/10:

23:36 Changeset [53841] by cjerdonek@webkit.org

2010-01-25 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style by removing the file path
parameter from the style error handler functions.

https://bugs.webkit.org/show_bug.cgi?id=34031

  • Scripts/webkitpy/style/checker.py:
    • Added _default_style_error_handler() to StyleChecker class.
    • Moved handle_style_error() to inside _default_style_error_handler().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Removed file path from calls to error handler.
  • Scripts/webkitpy/style/cpp_style.py:
    • Removed file path from calls to error handler.
  • Scripts/webkitpy/style/cpp_style_unittest.py:
    • Removed file path from calls to error handler.
  • Scripts/webkitpy/style/text_style.py:
    • Removed file path from calls to error handler.
  • Scripts/webkitpy/style/text_style_unittest.py:
    • Removed file path from calls to error handler.
22:23 Changeset [53840] by jorlow@chromium.org

2010-01-22 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546

Update the storageEvent algorithm to match the change in WebCore.

  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent):

2010-01-22 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546

This meat of the patch I just posted is very simple. It's just making events
asynchronous, not posting them to the frame that generated them, passing a null
for the key when issuing a clear storage event, and making the events
non-cancelable/non-bubbleable...all of which are clearly stated in the spec.

The asynchronous and not posting to the frame that generated them forced me to
re-write all the layout tests that dealt with storage events. There's a lot of
code there, but I tried to be fairly careful to ensure that test coverage did
not shrink in any area.

Tests: storage/domstorage/events/basic-body-attribute.html

storage/domstorage/events/basic-setattribute.html
storage/domstorage/events/basic.html
storage/domstorage/events/case-sensitive.html
storage/domstorage/events/documentURI.html

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::enqueueStorageEvent): (WebCore::Document::storageEventTimerFired):
  • dom/Document.h:
  • storage/StorageEvent.cpp: (WebCore::StorageEvent::StorageEvent):
  • storage/StorageEvent.idl:
  • storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):

2010-01-22 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Make storage events match the spec.
https://bugs.webkit.org/show_bug.cgi?id=30546

This meat of the patch I just posted is very simple. It's just making events
asynchronous, not posting them to the frame that generated them, passing a null
for the key when issuing a clear storage event, and making the events
non-cancelable/non-bubbleable...all of which are clearly stated in the spec.

The asynchronous and not posting to the frame that generated them forced me to
re-write all the layout tests that dealt with storage events. There's a lot of
code there, but I tried to be fairly careful to ensure that test coverage did
not shrink in any area.

  • storage/domstorage/complex-values-expected.txt:
  • storage/domstorage/documentURI-expected.txt: Removed.
  • storage/domstorage/documentURI.html: Removed.
  • storage/domstorage/events: Added.
  • storage/domstorage/events/basic-body-attribute-expected.txt: Added.
  • storage/domstorage/events/basic-body-attribute.html: Added.
  • storage/domstorage/events/basic-expected.txt: Added.
  • storage/domstorage/events/basic-setattribute-expected.txt: Added.
  • storage/domstorage/events/basic-setattribute.html: Added.
  • storage/domstorage/events/basic.html: Added.
  • storage/domstorage/events/case-sensitive-expected.txt: Added.
  • storage/domstorage/events/case-sensitive.html: Added.
  • storage/domstorage/events/documentURI-expected.txt: Added.
  • storage/domstorage/events/documentURI.html: Added.
  • storage/domstorage/events/resources: Added.
  • storage/domstorage/events/resources/body-event-handler.html: Added.
  • storage/domstorage/events/resources/eventTestHarness.js: Added.
  • storage/domstorage/events/resources/setattribute-event-handler.html: Added.
  • storage/domstorage/events/script-tests: Added.
  • storage/domstorage/events/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
  • storage/domstorage/events/script-tests/basic-body-attribute.js: Added.
  • storage/domstorage/events/script-tests/basic-setattribute.js: Added.
  • storage/domstorage/events/script-tests/basic.js: Added.
  • storage/domstorage/events/script-tests/case-sensitive.js: Added.
  • storage/domstorage/events/script-tests/documentURI.js: Added.
  • storage/domstorage/localstorage/iframe-events-expected.txt: Removed.
  • storage/domstorage/localstorage/iframe-events.html: Removed.
  • storage/domstorage/localstorage/index-get-and-set-expected.txt:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/onstorage-attribute-markup-expected.txt: Removed.
  • storage/domstorage/localstorage/onstorage-attribute-markup.html: Removed.
  • storage/domstorage/localstorage/onstorage-attribute-setattribute-expected.txt: Removed.
  • storage/domstorage/localstorage/onstorage-attribute-setattribute.html: Removed.
  • storage/domstorage/localstorage/onstorage-attribute-setwindow-expected.txt: Removed.
  • storage/domstorage/localstorage/onstorage-attribute-setwindow.html: Removed.
  • storage/domstorage/localstorage/simple-events-expected.txt: Removed.
  • storage/domstorage/localstorage/simple-events.html: Removed.
  • storage/domstorage/script-tests/complex-values.js:
  • storage/domstorage/script-tests/documentURI.js: Removed.
  • storage/domstorage/sessionstorage/iframe-events-expected.txt: Removed.
  • storage/domstorage/sessionstorage/iframe-events.html: Removed.
  • storage/domstorage/sessionstorage/index-get-and-set-expected.txt:
  • storage/domstorage/sessionstorage/index-get-and-set.html:
  • storage/domstorage/sessionstorage/onstorage-attribute-markup-expected.txt: Removed.
  • storage/domstorage/sessionstorage/onstorage-attribute-markup.html: Removed.
  • storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt: Removed.
  • storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html: Removed.
  • storage/domstorage/sessionstorage/onstorage-attribute-setwindow-expected.txt: Removed.
  • storage/domstorage/sessionstorage/onstorage-attribute-setwindow.html: Removed.
  • storage/domstorage/sessionstorage/simple-events-expected.txt: Removed.
  • storage/domstorage/sessionstorage/simple-events.html: Removed.
  • storage/domstorage/window-attributes-exist-expected.txt:
  • storage/domstorage/window-attributes-exist.html:
22:00 Changeset [53839] by mitz@apple.com

<rdar://problem/7573493> Error with line break inside ?&raquo; pair of characters.
https://bugs.webkit.org/show_bug.cgi?id=17475

Reviewed by Darin Adler.

WebCore:

Test: fast/text/line-break-after-question-mark.html

Instead of unconditionally allowing lines to break after a question mark, which was intended
to mimic Internet Explorer, apply the Unicode line breaking behavior after a question mark,
with one exception in the ASCII range to match IE, namely not allowing a line break between
a question mark and a vertical line.

  • rendering/break_lines.cpp:

(WebCore::shouldBreakAfter): Added a next character parameter. Changed to consult a table
for the question mark case in order to keep it fast and not require a text break iterator in
the ASCII case.
(WebCore::nextBreakablePosition): Pass the next character to shouldBreakAfter.

LayoutTests:

  • fast/text/line-break-after-question-mark-expected.txt: Added.
  • fast/text/line-break-after-question-mark.html: Added.
  • fast/text/script-tests/line-break-after-question-mark.js: Added.

():

  • platform/mac/tables/mozilla/bugs/bug6674-expected.checksum: Updated.
  • platform/mac/tables/mozilla/bugs/bug6674-expected.png: Updated.
  • platform/mac/tables/mozilla/bugs/bug6674-expected.txt: Updated.
21:57 Changeset [53838] by pkasting@chromium.org

WebCore: Mac scrollbar thumbs were drawn with the wrong size.
https://bugs.webkit.org/show_bug.cgi?id=34049

Reviewed by Dan Bernstein.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

LayoutTests: Rebaseline pixel tests affected by changes in scrollbar thumb size.
https://bugs.webkit.org/show_bug.cgi?id=34049

Reviewed by Dan Bernstein.

  • platform/mac/compositing/overflow/overflow-scroll-expected.checksum:
  • platform/mac/compositing/overflow/overflow-scroll-expected.png:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
  • platform/mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/002-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/mac/fast/clip/014-expected.checksum:
  • platform/mac/fast/clip/014-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.checksum:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
  • platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
  • platform/mac/fast/forms/textarea-scroll-height-expected.png:
  • platform/mac/fast/inline-block/tricky-baseline-expected.checksum:
  • platform/mac/fast/inline-block/tricky-baseline-expected.png:
  • platform/mac/fast/layers/scroll-rect-to-visible-expected.checksum:
  • platform/mac/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/mac/fast/overflow/002-expected.checksum:
  • platform/mac/fast/overflow/002-expected.png:
  • platform/mac/fast/overflow/003-expected.checksum:
  • platform/mac/fast/overflow/003-expected.png:
  • platform/mac/fast/overflow/005-expected.checksum:
  • platform/mac/fast/overflow/005-expected.png:
  • platform/mac/fast/overflow/007-expected.checksum:
  • platform/mac/fast/overflow/007-expected.png:
  • platform/mac/fast/overflow/008-expected.checksum:
  • platform/mac/fast/overflow/008-expected.png:
  • platform/mac/fast/overflow/childFocusRingClip-expected.checksum:
  • platform/mac/fast/overflow/childFocusRingClip-expected.png:
  • platform/mac/fast/overflow/float-in-relpositioned-expected.checksum:
  • platform/mac/fast/overflow/float-in-relpositioned-expected.png:
  • platform/mac/fast/overflow/image-selection-highlight-expected.checksum:
  • platform/mac/fast/overflow/image-selection-highlight-expected.png:
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum:
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png:
  • platform/mac/fast/overflow/overflow-rtl-expected.checksum:
  • platform/mac/fast/overflow/overflow-rtl-expected.png:
  • platform/mac/fast/overflow/overflow-stacking-expected.checksum:
  • platform/mac/fast/overflow/overflow-stacking-expected.png:
  • platform/mac/fast/overflow/overflow-text-hit-testing-expected.checksum:
  • platform/mac/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum:
  • platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.checksum:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/mac/fast/overflow/scrollbar-position-update-expected.checksum:
  • platform/mac/fast/overflow/scrollbar-position-update-expected.png:
  • platform/mac/fast/overflow/table-overflow-float-expected.checksum:
  • platform/mac/fast/overflow/table-overflow-float-expected.png:
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum:
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/mac/fast/repaint/layout-state-only-positioned-expected.checksum:
  • platform/mac/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/mac/fast/table/edge-offsets-expected.checksum:
  • platform/mac/fast/table/edge-offsets-expected.png:
  • platform/mac/scrollbars/key-window-not-first-responder-expected.checksum:
  • platform/mac/scrollbars/key-window-not-first-responder-expected.png:
  • platform/mac/svg/custom/invisible-text-after-scrolling-expected.checksum:
  • platform/mac/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/mac/tables/mozilla/bugs/bug149275-1-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug149275-1-expected.png:
21:38 WebKit Team edited by jorlow@chromium.org
(diff)
21:15 Changeset [53837] by jorlow@chromium.org

Adding myself as reviewer. No review necessary.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2010-01-25

  • Scripts/webkitpy/committers.py:
18:17 Changeset [53836] by andersca@apple.com

Featureless build fixes.

  • Misc/WebCache.mm:

(+[WebCache empty]):

  • WebCoreSupport/WebApplicationCache.mm:
  • WebCoreSupport/WebChromeClient.h:
  • WebView/WebDataSource.mm:

(-[WebDataSource _transferApplicationCache:]):

  • WebView/WebFrame.mm:

(-[WebFrame _cacheabilityDictionary]):

  • WebView/WebView.mm:

(WebKitInitializeApplicationCachePathIfNecessary):
(-[WebView _close]):

  • WebView/WebViewData.mm:

(-[WebViewPrivate dealloc]):
(-[WebViewPrivate finalize]):

18:07 Changeset [53835] by enrica@apple.com

WebCore: Cleanup unwanted tags after pasting.
https://bugs.webkit.org/show_bug.cgi?id=34148

Reviewed by Darin Adler.

Test: editing/pasteboard/paste-noscript-xhtml.xhtml

  • dom/Element.cpp:

(WebCore::Element::setAttributeNS):

  • dom/Element.h:
  • dom/XMLTokenizer.h:
  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::handleElementNamespaces):
(WebCore::handleElementAttributes):
(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::endElementNs):
(WebCore::parseXMLDocumentFragment):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::createContextualFragment):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=34148

Reviewed by Darin Adler.

  • editing/pasteboard/paste-noscript-xhtml-expected.txt: Added.
  • editing/pasteboard/paste-noscript-xhtml.xhtml: Added.
  • editing/resources/htmlcontent.html: Added.
17:24 Changeset [53834] by sfalken@apple.com

2010-01-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Simon Fraser.

A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145

  • WebCoreSupport/WebGeolocationControllerClient.cpp: (WebGeolocationControllerClient::geolocationDestroyed): Added.
  • WebCoreSupport/WebGeolocationControllerClient.h:

2010-01-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Simon Fraser.

A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145

  • WebCoreSupport/WebGeolocationControllerClient.h:
  • WebCoreSupport/WebGeolocationControllerClient.mm: (WebGeolocationControllerClient::geolocationDestroyed):

2010-01-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Simon Fraser.

A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145

  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):
  • page/GeolocationControllerClient.h:
17:07 Changeset [53833] by mrowe@apple.com

Merge r52527.

17:03 Changeset [53832] by mrowe@apple.com

Merge r53581.

17:02 Changeset [53831] by mrowe@apple.com

Merge r53581.

16:44 Changeset [53830] by mrowe@apple.com

Merge r46792.

16:36 Changeset [53829] by mrowe@apple.com

Merge r50698.

16:33 Changeset [53828] by mrowe@apple.com

Merge r52073.

16:28 Changeset [53827] by mrowe@apple.com

Merge r48810.

16:09 Changeset [53826] by mrowe@apple.com

Merge r51877.

16:06 Changeset [53825] by mrowe@apple.com

Merge r53520.

16:00 Changeset [53824] by mrowe@apple.com

Merge r53195.

15:55 Changeset [53823] by mrowe@apple.com

Merge r51727.

15:53 Changeset [53822] by mrowe@apple.com

Merge r53089.

15:53 Changeset [53821] by mrowe@apple.com

Merge r51881.

15:52 Changeset [53820] by eric@webkit.org

2010-01-25 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Improve portability of select-item-background-clip.html
https://bugs.webkit.org/show_bug.cgi?id=34072

  • fast/forms/select-item-background-clip.html: Calculate the pixel height at runtime.
15:49 Changeset [53819] by mrowe@apple.com

Merge r51616.

15:47 Changeset [53818] by mrowe@apple.com

Merge r51205.

15:26 Changeset [53817] by mrowe@apple.com

Merge r52749.

15:20 Changeset [53816] by dglazkov@chromium.org

2010-01-25 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, trivial baseline updates.

-webkit-gradient slows down scrolling when page has horizontal scrollbar
https://bugs.webkit.org/show_bug.cgi?id=19650

Update pixel baselines. They changed slightly after http://trac.webkit.org/changeset/53318/
landed.

  • platform/mac/fast/gradients/border-image-gradient-expected.checksum:
  • platform/mac/fast/gradients/border-image-gradient-expected.png:
  • platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum:
  • platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
  • platform/mac/fast/gradients/simple-gradients-expected.checksum:
  • platform/mac/fast/gradients/simple-gradients-expected.png:
15:12 Changeset [53815] by dimich@chromium.org

Fix Chromium Linux tests: the pthread functions on Linux produce segfault if they receive 0 thread handle.
After r53714, we can have 0 thread handles passed to pthread_join and pthread_detach if corresponding threads
were already terminated and their threadMap entries cleared.
Add a 0 check.

Reviewed by David Levin.

  • wtf/ThreadingPthreads.cpp:

(WTF::waitForThreadCompletion):
(WTF::detachThread):

15:07 Changeset [53814] by cmarrin@apple.com

Fixed bug in positioning of scroll layer within the
parent root layer.
https://bugs.webkit.org/show_bug.cgi?id=33847

13:55 WebKit Team edited by michelangelo@webkit.org
(diff)
13:47 WebKit Team edited by michelangelo@webkit.org
(diff)
12:54 WebKit Team edited by bfulgham@webkit.org
Added some (unsubstantiated) claims about what I know. (diff)
12:37 Changeset [53813] by ap@apple.com

Rubber-stamped by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=34076
An image remains accessible via form.property syntax after being removed from document.

Fix crashing regression tests (tables/mozilla/bugs/bug4527.html et al.)

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree): Remove incorrect assertions added in the previous patch - it's mot true that m_for is always a parent; table parsing can reparent the image element, but m_form still needs to be set.
12:07 Changeset [53812] by ap@apple.com

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=34076
An image remains accessible via form.property syntax after being removed from document.

Tests: fast/forms/removed-image-as-property.html

fast/forms/reparented-image-as-property.html

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): This is called during GC - not a good time to make observable changes to DOM. (WebCore::HTMLImageElement::insertedIntoTree): This is the right place to do any work that depends on connectedness to some ancestor. We still allow for m_form to be set via constructor, which happens during parsing. (WebCore::HTMLImageElement::removedFromTree): Ditto.
  • html/HTMLImageElement.h: Added removedFromTree/insertedIntoTree, moved removedFromDocument and insertedIntoDocument to private section, as they shouldn't be called directly.
12:03 Changeset [53811] by eric@webkit.org

2010-01-25 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=34073

Fixes misspelled words in comments.

  • accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper detach]): (AXAttributeStringSetElement):
  • bindings/js/JSDOMBinding.cpp: (WebCore::completeURL):
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
  • bindings/js/JSSVGPODTypeWrapper.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bridge/NP_jsobject.cpp: (_NPN_SetException):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
  • bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::detach):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • dom/Element.h:
  • dom/MessagePortChannel.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
  • dom/Node.cpp: (WebCore::Node::isFocusable): (WebCore::Node::shadowAncestorNode):
  • dom/Node.h:
  • dom/Position.cpp: (WebCore::Position::upstream):
  • dom/Position.h:
  • dom/Range.cpp: (WebCore::Range::processContents):
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::reconcileTextDecorationProperties): (WebCore::StyleChange::extractTextStyles): (WebCore::prepareEditingStyleToApplyAt):
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd):
  • editing/Editor.cpp: (WebCore::Editor::learnSpelling):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
  • loader/Cache.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable):
  • loader/CachedResource.h:
  • loader/CachedResourceHandle.h:
  • loader/DocumentLoader.h:
  • loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel):
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
  • notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::):
  • page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations):
  • platform/LinkHash.cpp: (WebCore::cleanPath):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::calculateDrawingMode):
  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition):
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::ensureStructuralLayer):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
  • platform/text/TextEncodingDetectorICU.cpp: (WebCore::detectTextEncoding):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::stateChanged):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildTextChunks):
  • rendering/TransformState.cpp: (WebCore::TransformState::flattenWithTransform):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::suggestedValue):
11:34 WebKit Team edited by darin@chromium.org
(diff)
11:32 WebKit Team edited by darin@chromium.org
(diff)
11:26 Changeset [53810] by yurys@chromium.org

2010-01-25 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Add new inspector test added in r53807 to skip
list on qt platform.

  • platform/qt/Skipped:
11:20 Changeset [53809] by dbates@webkit.org

2010-01-25 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=34073

Fixes misspelled words in comments.

  • accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper detach]): (AXAttributeStringSetElement):
  • bindings/js/JSDOMBinding.cpp: (WebCore::completeURL):
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
  • bindings/js/JSSVGPODTypeWrapper.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bridge/NP_jsobject.cpp: (_NPN_SetException):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
  • bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::sortMatchedRules): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::detach):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • dom/Element.h:
  • dom/MessagePortChannel.h:
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
  • dom/Node.cpp: (WebCore::Node::isFocusable): (WebCore::Node::shadowAncestorNode):
  • dom/Node.h:
  • dom/Position.cpp: (WebCore::Position::upstream):
  • dom/Position.h:
  • dom/Range.cpp: (WebCore::Range::processContents):
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::reconcileTextDecorationProperties): (WebCore::StyleChange::extractTextStyles): (WebCore::prepareEditingStyleToApplyAt):
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd):
  • editing/Editor.cpp: (WebCore::Editor::learnSpelling):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._format):
  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
  • loader/Cache.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable):
  • loader/CachedResource.h:
  • loader/CachedResourceHandle.h:
  • loader/DocumentLoader.h:
  • loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didCancel):
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::spaceNeeded):
  • notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::):
  • page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations):
  • platform/LinkHash.cpp: (WebCore::cleanPath):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::calculateDrawingMode):
  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition):
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::ensureStructuralLayer):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivate::hasAvailableVideoFrame):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL):
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
  • platform/text/TextEncodingDetectorICU.cpp: (WebCore::detectTextEncoding):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::stateChanged):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::mapLocalToContainer):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildTextChunks):
  • rendering/TransformState.cpp: (WebCore::TransformState::flattenWithTransform):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::dispatchBlurEvent): (WebCore::WMLInputElement::suggestedValue):
10:58 Changeset [53808] by ggaren@apple.com

Suggested by Darin Adler.

Fixed a spelling error, tightened up some grammar.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):

10:57 Changeset [53807] by eric@webkit.org

2010-01-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Test that Web Inspector doesn't change methods declared by the inspected
page.
https://bugs.webkit.org/show_bug.cgi?id=34089

  • inspector/inspected-objects-not-overriden-expected.txt: Added.
  • inspector/inspected-objects-not-overriden.html: Added.

2010-01-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

Instead of adding inspector methods to the inspected global objects
use private implementation visible from inspector code only.
https://bugs.webkit.org/show_bug.cgi?id=34089

Test: inspector/inspected-objects-not-overriden.html

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
08:37 QtWebKitBackportingFixes edited by benjamin.poulain@nokia.com
(diff)
08:06 Changeset [53806] by pfeldman@chromium.org

2010-01-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: don't show headers/content tabs in scripts view.

https://bugs.webkit.org/show_bug.cgi?id=34083

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.set headersVisible): (WebInspector.ResourceView.prototype._selectContentTab): (WebInspector.ResourceView.prototype._innerSelectContentTab):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype.showResource):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/inspector.css:
07:37 Changeset [53805] by philn@webkit.org

2010-01-25 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

[Gtk] media/video-reverse-play-duration.html fails on and off on Gtk buildbots
https://bugs.webkit.org/show_bug.cgi?id=34086

  • platform/gtk/Skipped: Skipping the test, requires investigation on the failure.
07:24 Changeset [53804] by eric@webkit.org

2010-01-25 Simon Hausmann <hausmann@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Reduce the size of the library when compiling for Maemo5
https://bugs.webkit.org/show_bug.cgi?id=34050

Exclude the Web Inspector's qrc file in the Maemo5 build, just
like we do for the Symbian build. Saves about ~900k.

  • WebCore.pro:
07:08 Changeset [53803] by eric@webkit.org

2010-01-25 Simon Hausmann <hausmann@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] In the StyledPainter determine the style from the Render and Scrollbar theme instead of from the paint device
https://bugs.webkit.org/show_bug.cgi?id=34054

Getting the style from the painter's paint device is a hack that breaks when
the paint device's style is different than the style that is used when
calculating the metries earlier when there is no painter available.

This change moves us closer to always using the same style.

  • platform/qt/RenderThemeQt.cpp: (WebCore::StylePainter::StylePainter): (WebCore::StylePainter::init): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): (WebCore::RenderThemeQt::paintSliderTrack): (WebCore::RenderThemeQt::paintMediaMuteButton): (WebCore::RenderThemeQt::paintMediaPlayButton): (WebCore::RenderThemeQt::paintMediaSliderTrack): (WebCore::RenderThemeQt::paintMediaSliderThumb):
  • platform/qt/RenderThemeQt.h:
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint): (WebCore::ScrollbarThemeQt::hitTest): (WebCore::ScrollbarThemeQt::shouldCenterOnThumb): (WebCore::ScrollbarThemeQt::scrollbarThickness): (WebCore::ScrollbarThemeQt::thumbLength): (WebCore::ScrollbarThemeQt::trackPosition): (WebCore::ScrollbarThemeQt::trackLength): (WebCore::ScrollbarThemeQt::paintScrollCorner): (WebCore::ScrollbarThemeQt::style):
  • platform/qt/ScrollbarThemeQt.h:
06:42 Changeset [53802] by eric@webkit.org

2010-01-25 Simon Hausmann <hausmann@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
https://bugs.webkit.org/show_bug.cgi?id=34053

  • platform/qt/QWebPageClient.h: Add function to return the style.
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::qStyle): Determine the style from the page client instead of the page's view.

2010-01-25 Simon Hausmann <hausmann@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] In RenderThemeQt determine the QStyle from the page client instead of the page's view
https://bugs.webkit.org/show_bug.cgi?id=34053

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::style): Implement QWebPageClient::style() and return the graphics widget's style.
  • Api/qwebpage.cpp: (QWebPageWidgetClient::style): Implement QWebPageClient::style() and return the widget's style.
06:20 Changeset [53801] by hausmann@webkit.org

[Qt] Clean up code to determine palette from page client in RenderThemeQt
https://bugs.webkit.org/show_bug.cgi?id=34052

Patch by Simon Hausmann <hausmann@webkit.org> on 2010-01-25
Reviewed by Kenneth Christiansen.

Use the RenderTheme's associated page instead of going through the
render tree and the document.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):

  • platform/qt/RenderThemeQt.h:
05:56 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:53 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:18 Changeset [53800] by hausmann@webkit.org

[Qt] Fix the build on Maemo5.

Reviewed by Laszlo Gombos.

https://bugs.webkit.org/show_bug.cgi?id=34051

  • WebKit.pri: Disable the use of uitools, just like it's done for Symbian.
05:14 Changeset [53799] by eric@webkit.org

2010-01-25 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

[Qt] Phone backup support for QtWebkit for Symbian devices.
https://bugs.webkit.org/show_bug.cgi?id=34077

  • WebCore.pro:

2010-01-25 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

[Qt] Phone backup support for QtWebkit for Symbian devices.
https://bugs.webkit.org/show_bug.cgi?id=34077

  • symbian/backup_registration.xml: Added.
05:13 Changeset [53798] by yurys@chromium.org

2010-01-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Update inspector test expectations. Line number and source
name are present only in Chromium when console message is
logged before document load is completed.

https://bugs.webkit.org/show_bug.cgi?id=34078

  • platform/chromium/inspector/console-log-before-inspector-open-expected.txt: Added.
  • platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
  • platform/mac/inspector/console-log-before-inspector-open-expected.txt: Copied from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
  • platform/win/inspector/console-log-before-inspector-open-expected.txt: Renamed from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
04:57 QtWebKitBackportingFixes edited by koshuin@gmail.com
(diff)
04:37 Changeset [53797] by eric@webkit.org

2010-01-25 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Antti Koivisto.

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

  • page/FrameView.cpp: (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::registerFixedPositionedObject): (WebCore::FrameView::unregisterFixedPositionedObject): (WebCore::FrameView::scrollContentsFastPath):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
  • platform/ScrollView.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::destroy):
04:20 WebKit Team edited by cjerdonek@webkit.org
Fixed mangled special character and added missing quote. (diff)
04:16 WebKit Team edited by cjerdonek@webkit.org
Added introduction and key. (diff)
03:43 WebKit Team edited by cjerdonek@webkit.org
Restored page outline. (diff)
03:18 Changeset [53796] by eric@webkit.org

2010-01-25 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

Improved prepare-ChangeLog so that it preserves the relative
indentation of a git commit message.

https://bugs.webkit.org/show_bug.cgi?id=34058

  • Scripts/prepare-ChangeLog:
    • Also adjusted the script so that it does not add white space characters to empty lines.
02:58 Changeset [53795] by pfeldman@chromium.org

2010-01-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add support for addMessage/clearMessages to SourceFrame2.

https://bugs.webkit.org/show_bug.cgi?id=33904

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/SourceFrame2.js: (WebInspector.SourceFrame2): (WebInspector.SourceFrame2.prototype.addMessage): (WebInspector.SourceFrame2.prototype.clearMessages): (WebInspector.SourceFrame2.prototype._incrementMessageRepeatCount): (WebInspector.SourceFrame2.prototype._addExistingMessagesToSource): (WebInspector.SourceFrame2.prototype._addMessageToSource): (WebInspector.SourceFrame2.prototype.resize):
  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._lineHeight): (WebInspector.TextEditor.prototype._highlightChanged): (WebInspector.TextEditor.prototype.packAndRepaintAll): (WebInspector.TextEditor.prototype._updateSize): (WebInspector.TextEditor.prototype._repaintAll): (WebInspector.TextEditor.prototype._paint): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._mouseOut): (WebInspector.TextEditor.prototype._updateDivDecorations): (WebInspector.TextEditor.prototype._positionDivDecoration): (WebInspector.TextEditor.prototype._paintSelection): (WebInspector.TextEditor.prototype._replaceSelectionWith):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/textEditor.css: Added.
02:37 Changeset [53794] by pfeldman@chromium.org

2010-01-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Replace split pane with tabbed pane in resource
contents view.

https://bugs.webkit.org/show_bug.cgi?id=32453

01:43 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
00:45 WebKit Team edited by hausmann@webkit.org
(diff)
00:02 WebKit Team edited by krit@webkit.org
(diff)

01/24/10:

23:04 Changeset [53793] by rolandsteiner@chromium.org

build fix: rubber-stamped by Eric Seidel.

Fix expected baselines for ruby layout tests on Windows.

  • platform/win/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/win/fast/ruby/ruby-length-expected.txt:
  • platform/win/fast/ruby/ruby-run-break-expected.txt:
  • platform/win/fast/ruby/ruby-runs-expected.txt:
  • platform/win/fast/ruby/ruby-runs-spans-expected.txt:
  • platform/win/fast/ruby/ruby-simple-expected.txt:
  • platform/win/fast/ruby/ruby-simple-rp-expected.txt:
  • platform/win/fast/ruby/ruby-trailing-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt:
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt:
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt:
22:21 Changeset [53792] by eric.carlson@apple.com

2010-01-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Media element duration changes to zero after playing in reverse
https://bugs.webkit.org/show_bug.cgi?id=34041

Test: media/video-reverse-play-duration.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::didEnd): QTKit's ended notification fires at time zero when playing in reverse, so don't reset duration in that case.

2010-01-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Media element duration changes to zero after playing in reverse
https://bugs.webkit.org/show_bug.cgi?id=34041

  • media/video-reverse-play-duration-expected.txt: Added.
  • media/video-reverse-play-duration.html: Added.
22:05 WebKit Team edited by abarth@webkit.org
(diff)
22:00 WebKit Team edited by abarth@webkit.org
(diff)
21:55 WebKit Team edited by abarth@webkit.org
(diff)
21:50 Changeset [53791] by rolandsteiner@chromium.org

Bug 28420 - Re-enable ruby Windows layout tests
(https://bugs.webkit.org/show_bug.cgi?id=28420, patch 5b)

Reviewed by Maciej Stachowiak.

After creating new Latin-character-only layout tests for ruby
(https://bugs.webkit.org/show_bug.cgi?id=31865) and resolving the issue
that caused layout tests to fail then due to the addition of the ruby
layout tests (cf. https://bugs.webkit.org/show_bug.cgi?id=31200, problem
not actually caused by ruby), the ruby layout tests should als be
un-skipped for the Windows platform.

  • platform/win/Skipped:
21:50 WebKit Team edited by abarth@webkit.org
(diff)
21:43 WebKit Team edited by abarth@webkit.org
(diff)
21:31 WebKit Team edited by abarth@webkit.org
(diff)
21:25 WebKit Team edited by abarth@webkit.org
(diff)
21:17 WebKit Team edited by abarth@webkit.org
(diff)
20:11 Changeset [53790] by mjs@apple.com

2010-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Content with heavily nested residual style is so slow, it seems like a hang
https://bugs.webkit.org/show_bug.cgi?id=34059
<rdar://problem/7292906>


Test cast: fast/parser/residual-style-hang.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Limit the number of iterations of the main loop to 5.


The reason this limit is necessary is that otherwise, N misnested open tags followed
by N misnested close tags will cause O(N2) of work due to cloning and attaching subtrees;
at a fixed limit, the cost is at worst O(N).


The code that was in the loop originally ran exactly once - the loop was added in
r21472 to fix <https://bugs.webkit.org/show_bug.cgi?id=13603>. I have verified that
with the iteration limit, the bug is still fixed, both with the original test case
and with the layout tests tht were added.

2010-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Content with heavily nested residual style is so slow, it seems like a hang
https://bugs.webkit.org/show_bug.cgi?id=34059
<rdar://problem/7292906>

Test case for the above bug fix.

  • fast/parser/residual-style-hang-expected.txt: Added.
  • fast/parser/residual-style-hang.html: Added.
19:53 Changeset [53789] by eric@webkit.org

2010-01-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Maciej Stachowiak.

Refactor JITStubs.cpp so that DEFINE_STUB_FUNCTION is only used once for each function
https://bugs.webkit.org/show_bug.cgi?id=33866

Place the guard USE(JSVALUE32_64) inside the body of the DEFINE_STUB_FUNCTION
macro for those functions that are always present.

  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
19:26 Changeset [53788] by eric@webkit.org

2010-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Improve portability of listbox-selection-2.html
https://bugs.webkit.org/show_bug.cgi?id=33994

  • Convert to dumpAsText().
  • Determine the height of an item at runtime
  • fast/forms/listbox-selection-2-expected.txt: Added.
  • fast/forms/listbox-selection-2.html:
  • fast/forms/script-tests/listbox-selection-2.js
  • platform/mac/fast/forms/listbox-selection-2-expected.checksum: Removed.
  • platform/mac/fast/forms/listbox-selection-2-expected.png: Removed.
  • platform/mac/fast/forms/listbox-selection-2-expected.txt: Removed.
18:15 Changeset [53787] by tkent@chromium.org

2010-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::valueAsDate setter support for type=week.
https://bugs.webkit.org/show_bug.cgi?id=33986

Add setter tests to input-valueasdate-datetime.js, and update the
expectation.

  • fast/forms/input-valueasdate-week-expected.txt:
  • fast/forms/script-tests/input-valueasdate-week.js:

2010-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

HTMLInputElement::valueAsDate setter support for type=week.
https://bugs.webkit.org/show_bug.cgi?id=33986

Introduce ISODateTime::setMillisecondsSinceEpochForWeek() and add
Week type support to ISODateTime::toString().

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Avoid default:. (WebCore::HTMLInputElement::setValueAsDate): Add WEEK type handling and avoid default:.
  • html/ISODateTime.cpp: (WebCore::offsetTo1stWeekStart): (WebCore::ISODateTime::setMillisecondsSinceEpochForWeek): (WebCore::ISODateTime::millisecondsSinceEpoch): (WebCore::ISODateTime::toString): Add Week type support and avoid default:.
  • html/ISODateTime.h:
16:41 WebKit Team edited by ddkilzer@webkit.org
(diff)
16:15 WebKit Team edited by michelangelo@webkit.org
(diff)
14:54 Changeset [53786] by eric.carlson@apple.com

2010-01-24 Eric Carlson <eric.carlson@apple.com>

No review, build fix.

Only log the first 'timeupdate' event from audio-delete-while-slider-thumb-clicked.html
as the number fired can vary according to how long it takes to run the test.

  • media/audio-delete-while-slider-thumb-clicked.html:
14:54 Changeset [53785] by oliver@apple.com

2010-01-24 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Object Serialization assumes deserialization will always occur in the context of a webpage
https://bugs.webkit.org/show_bug.cgi?id=34056
rdar://7573833

Added ClassInfo to JSDOMGlobalObject and make the window and worker class info
inherit from it. With this in place we're able to determine whether a given
global object is a DOMGlobalObject, and then use that information to avoid
attempting to deserialize types that require the presence of the DOM.

No test as all global objects in webkit inherit from JSDOMGlobalObject.

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::classInfo):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::):
  • bindings/js/JSWorkerContextBase.cpp: (WebCore::):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::DeserializingTreeWalker::DeserializingTreeWalker): (WebCore::DeserializingTreeWalker::convertIfTerminal):
14:30 Changeset [53784] by eric@webkit.org

2010-01-24 Eric Seidel <eric@webkit.org>

No review.

Middle clicking the primary scroll bars on Chromium Linux triggers a paste event
https://bugs.webkit.org/show_bug.cgi?id=33062

  • platform/gtk/Skipped:
    • This new test fails on Gtk for unknown reasons.
    • Skipping for now to make the bots green, until a Gtk person can look.
14:15 Changeset [53783] by eric@webkit.org

2010-01-24 Eric Seidel <eric@webkit.org>

No review, rolling out r53763.
http://trac.webkit.org/changeset/53763
https://bugs.webkit.org/show_bug.cgi?id=33895

Broke 20+ tests on Windows.

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
14:05 WebKit Team edited by jpetsovits@rim.com
(diff)
13:05 Changeset [53782] by cjerdonek@webkit.org

Added to contributing code page a pointer to the preferred
license text. Also added information about copyright lines.

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=34017

  • coding/contributing.html:
  • css/main.css:
    • Added CSS class for books.
11:42 Changeset [53781] by simon.fraser@apple.com

2010-01-24 Simon Fraser <simon.fraser@apple.com>

No review.

Fix incorrect layout test that I checked in earlier.

  • platform/mac/compositing/reflections/load-video-in-reflection-expected.checksum:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.txt:
10:22 Changeset [53780] by eric.carlson@apple.com

2010-01-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=34047
<rdar://problem/7573699>
Media element "endedPlayback" logic doesn't match spec

Test: media/video-timeupdate-reverse-play.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::ended): The 'ended' attribute should only be true when playback rate is positive. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Always schedule a 'timeupdate' event when the media engine signals a time discontinuity, scheduleTimeupdateEvent will only queue an event if one hasn't already been posted for the current movie time. (WebCore::HTMLMediaElement::endedPlayback): Update to match the spec logic.

2010-01-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=34047
<rdar://problem/7573699>
Media element "endedPlayback" logic doesn't match spec

  • media/video-timeupdate-reverse-play-expected.txt: Added.
  • media/video-timeupdate-reverse-play.html: Added.
09:47 Changeset [53779] by simon.fraser@apple.com

2010-01-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Video that loads inside reflection doesn't get reflected
https://bugs.webkit.org/show_bug.cgi?id=34046

ensureCloneLayers() made an incorrect assumption that if a clone of the primaryLayer
exists already, then the structural layer and content layer can just be returned.
However, this doesn't account for the situation where a content layer may have
been create after the clone tree was last updated.

Fix by always creating the structural and clone layers on demand.

Test: compositing/reflections/load-video-in-reflection.html

  • platform/graphics/mac/GraphicsLayerCA.h: Added utility method, findOrMakeClone().
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::findOrMakeClone): Utility that efficiently finds or creates a layer in a LayerMap. (WebCore::GraphicsLayerCA::ensureCloneLayers): Always look for or clone the structural and content layers, rather than relying on whether there's a primary layer clone already.
04:25 Changeset [53778] by abarth@webkit.org

Rubber stamped by Eric Seidel.

More pep8 compliance.

  • Scripts/webkitpy/mock_bugzillatool.py:
04:16 Changeset [53777] by abarth@webkit.org

Rubber stamped by Eric Seidel.

More pep8 compliance.

  • Scripts/webkitpy/executive.py:
  • Scripts/webkitpy/grammar.py:
03:57 Changeset [53776] by abarth@webkit.org

Rubber stamped by Eric Seidel.

More pep8 compliance.

  • Scripts/webkitpy/comments.py:
  • Scripts/webkitpy/committers.py:
  • Scripts/webkitpy/credentials.py:
03:48 Changeset [53775] by abarth@webkit.org

Rubber stamped by Eric Seidel.

Make changelogs.py pass pep8.

  • Scripts/webkitpy/changelogs.py:

01/23/10:

23:44 Changeset [53774] by oliver@apple.com

2010-01-23 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Implement support for FileList cloning in postMessage
https://bugs.webkit.org/show_bug.cgi?id=34048

Add test for passing a FileList through postMessage, and
correct testing already present to test what it was meant
to be.

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:

2010-01-23 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Implement support for FileList cloning in postMessage
https://bugs.webkit.org/show_bug.cgi?id=34048

Support passing FileList through postMessage APIs. Basically
mechanical task in line with other terminals in the object
graph.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedFileList::create): (WebCore::SerializedFileList::length): (WebCore::SerializedFileList::item): (WebCore::SerializedFileList::SerializedFileList): (WebCore::SerializedScriptValueData::SerializedScriptValueData): (WebCore::SharedSerializedData::asFileList): (WebCore::SerializingTreeWalker::convertIfTerminal): (WebCore::DeserializingTreeWalker::convertIfTerminal): (WebCore::TeardownTreeWalker::convertIfTerminal):

Rearrange these functions to not use 'default:' handling
so that the compiler will actually tell us when we're
not handling cases.

  • bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValueData::): (WebCore::SerializedScriptValueData::asFileList):
17:50 Changeset [53773] by mitz@apple.com

<rdar://problem/7569820> svg/custom/text-zoom.xhtml fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=34006

Reviewed by Maciej Stachowiak.

WebKit/win:

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey
with a default value of true.

LayoutTests:

  • platform/win/svg/custom/text-zoom-expected.txt: Removed.
13:53 Changeset [53772] by kenneth@webkit.org

[Qt] Unreviewed build fix

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/webinspector.h:
13:40 Changeset [53771] by kenneth@webkit.org

Rubberstamped by Simon Hausmann.

[Qt] Move the WebInspector class to it's own header file.

  • QtLauncher/main.cpp:
  • QtLauncher/webinspector.h: Added.

(WebInspector::WebInspector):
(WebInspector::showEvent):
(WebInspector::hideEvent):

08:54 Changeset [53770] by eric@webkit.org

2010-01-23 Robert Hogan <robert@roberthogan.net>

Reviewed by Kenneth Rohde Christiansen.

Qt DRT: respect window.close() and window.closed()

Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().

This fixes the following tests:

plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html

https://bugs.webkit.org/show_bug.cgi?id=32953

  • platform/qt/Skipped:

2010-01-23 Robert Hogan <robert@roberthogan.net>

Reviewed by Kenneth Rohde Christiansen.

Qt DRT: respect window.close() and window.closed()

Qt DRT needs to maintain a correct count of open windows
for windowCount(). It also needs to delete windows that
have been closed by window.close().

This fixes the following tests:

plugins/destroy-during-npp-new.html
fast/dom/Document/early-document-access.html
fast/dom/Window/window-early-properties.html
fast/events/open-window-from-another-frame.html
fast/events/popup-blocking-click-in-iframe.html

https://bugs.webkit.org/show_bug.cgi?id=32953

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::createWindow): (WebCore::DumpRenderTree::windowCloseRequested):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::maybeDump):
08:37 Changeset [53769] by eric@webkit.org

2010-01-23 Girish Ramakrishnan <girish@forwardbias.in>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix positioning of ComboBox popup in QGraphicsWebView.

Wrap the popup in a QGraphicsProxyWidget, so that the popup
transforms with the item.

https://bugs.webkit.org/show_bug.cgi?id=33887

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show):
  • WebCoreSupport/QtFallbackWebPopup.h:
08:08 Changeset [53768] by simon.fraser@apple.com

2010-01-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Carlson.

Race condition in video setup can force videos into software mode
https://bugs.webkit.org/show_bug.cgi?id=34034

We used to call setUpVideoRendering() unconditionally from
acceleratedRenderingStateChanged(); this could happen before the movie had any
data, and thus force the movie into software rendering mode.

Fix by returning early from setUpVideoRendering() if isReadyForRendering() returns false,
which also allows us to remove some other checks for being ready to render.

Timing dependent, hard to make a test for.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToMedia): Optimize to do an early return if passing in the same layer that is already being used.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setUpVideoRendering): Return without doing anything if not ready to render. (WebCore::MediaPlayerPrivate::updateStates): No need to call isReadyForRendering() any more, since setUpVideoRendering() does that. (WebCore::MediaPlayerPrivate::setVisible): No need to check the ready state; this is equivalent to the check inside of setUpVideoRendering().
03:43 Changeset [53767] by yurys@chromium.org

2010-01-23 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Add new inspector test added in r53766 to skipi
list on qt platform.

  • platform/qt/Skipped:
02:13 Changeset [53766] by yurys@chromium.org

2010-01-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=32554

Test: inspector/console-log-before-inspector-open.html

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::databaseForId): (WebCore::JSInjectedScriptHost::currentCallFrame): (WebCore::JSInjectedScriptHost::nodeForId): (WebCore::JSInjectedScriptHost::pushNodePathToFrontend): (WebCore::JSInjectedScriptHost::selectDatabase): (WebCore::JSInjectedScriptHost::selectDOMStorage):
  • bindings/js/ScriptCallStack.h: (WebCore::ScriptCallStack::globalState):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptObject.h: (WebCore::ScriptObject::scriptState):
  • bindings/js/ScriptValue.cpp:
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::globalState):
  • bindings/v8/ScriptObject.h: (WebCore::ScriptObject::scriptState):
  • bindings/v8/ScriptValue.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setInjectedScriptSource): (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::releaseWrapperObjectGroup):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::pausedScript):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages): (WebInspector.ConsoleView.prototype.doEvalInWindow):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parseRule):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged.InjectedScriptAccess.get addInspectedNode): (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.setDocument): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
  • inspector/front-end/EventListenersSidebarPane.js: ():
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess): (InjectedScriptAccess.getDefault): (get InjectedScriptAccess): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane): (WebInspector.MetricsSidebarPane.prototype.update.inlineStyleCallback):
  • inspector/front-end/ObjectPropertiesSection.js:
  • inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.pausedScript): (WebInspector.addConsoleMessage): (WebInspector.log.logMessage): (WebInspector.log):

2010-01-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Inject inspector script directly into the inspected context. All the
communication between the script and the frontend is serialized into
JSON strings. It allows to get rid of object quarantines in Web Inspector.

Test that web inspector doesn't crash when opening if there are messages in
the console. Refactor test case due to InjectedScriptAccess changes.

https://bugs.webkit.org/show_bug.cgi?id=32554

  • inspector/console-log-before-inspector-open-expected.txt: Added.
  • inspector/console-log-before-inspector-open.html: Added.
  • inspector/styles-iframe.html:
01:51 Changeset [53765] by mitz@apple.com

Added a user default for specifying a fallback frameworks path in case
the bundle does not contain frameworks for the current Mac OS X version.

Reviewed by Mark Rowe.

  • WebKitLauncher/main.m:

(fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
keyed by the FallbackSystemVersions user default and returns it.
(main): If a frameworks directory for the current system version is not found,
try the fallback.

01/22/10:

23:11 Changeset [53764] by eric@webkit.org

2010-01-22 Alex Milowski <alex@milowski.com>

Reviewed by David Hyatt.

Updated tests due to stylesheet changes.

  • platform/mac/mathml/presentation/sub-expected.checksum:
  • platform/mac/mathml/presentation/sub-expected.png:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.checksum:
  • platform/mac/mathml/presentation/sup-expected.png:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:

2010-01-22 Alex Milowski <alex@milowski.com>

Reviewed by David Hyatt.

Added support for RenderMathMLBlock base object and isRenderMathMLBlock()
method on RenderObject.

Added support for text elements and updated tag and attribute names

Also, updated the stylesheet added files to the project

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • css/mathml.css:
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/MathMLTextElement.cpp: Added. (WebCore::MathMLTextElement::MathMLTextElement): (WebCore::MathMLTextElement::create): (WebCore::MathMLTextElement::createRenderer):
  • mathml/MathMLTextElement.h: Added.
  • mathml/RenderMathMLBlock.cpp: Added. (WebCore::RenderMathMLBlock::RenderMathMLBlock): (WebCore::RenderMathMLBlock::styleDidChange): (WebCore::RenderMathMLBlock::isChildAllowed): (WebCore::RenderMathMLBlock::makeBlockStyle): (WebCore::RenderMathMLBlock::nonOperatorHeight): (WebCore::RenderMathMLBlock::stretchToHeight):
  • mathml/RenderMathMLBlock.h: Added. (WebCore::RenderMathMLBlock::isRenderMathMLBlock): (WebCore::RenderMathMLBlock::isRenderMathMLOperator): (WebCore::RenderMathMLBlock::isRenderMathMLRow): (WebCore::RenderMathMLBlock::isRenderMathMLMath): (WebCore::RenderMathMLBlock::hasBase): (WebCore::toRenderMathMLBlock):
  • mathml/mathattrs.in: Added.
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderMathMLBlock):
22:51 Changeset [53763] by eric@webkit.org

2010-01-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

Make run-webkit-tests work under Cygwin for the Qt port

setPathForRunningWebKitApp() is implemented for the Qt port
by using qmake to query for the location of the Qt libraries.

This requires the original environment (%ENV) to be untouched,
so launchWithCurrentEnv() was refactored to launchWithEnv(),
and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
instead. This has the added benefit of getting rid of the temp
variables used for storing the current env.

openDumpTool() is also refactored a bit into platform-spesific,
port-spesific, and generic environment variables.

Checks for undef was added a few places to fix Perl concat
warnings when run-webkit-tests is aborted.

https://bugs.webkit.org/show_bug.cgi?id=33895

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
22:35 Changeset [53762] by eric@webkit.org

2010-01-22 Garret Kelly <gdk@chromium.org>

Reviewed by David Levin.

Fixing svg/custom/stroke-width-click.svg to not cause the double-click
handler to fire on certain platforms (chromium, for one). Chromium,
Leopard, and GTK all agree on the calculated extents of the shape, so I'm
disabling this test on mac-tiger and re-enabling it on mac-leopard and
updating the expected file to reflect the current state of the test.
https://bugs.webkit.org/show_bug.cgi?id=33865

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • svg/custom/stroke-width-click-expected.txt:
  • svg/custom/stroke-width-click.svg:
22:19 Changeset [53761] by eric@webkit.org

2010-01-22 James Robinson <jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

Adds tests for the 'selected' attribute of <option>s
https://bugs.webkit.org/show_bug.cgi?id=32641

HTMLOptionElement_selected2 checks that the selected attribute is up to date immediately after the <select>
parsed. HTMLOptionElement_selected3 does the same, but checks immediately prior to the </select>.

Also changes the expectation for add-remove-option-modification-event to reflect that we now pass.

  • fast/forms/HTMLOptionElement_selected-expected.txt:
  • fast/forms/HTMLOptionElement_selected.html:
  • fast/forms/HTMLOptionElement_selected2-expected.txt: Added.
  • fast/forms/HTMLOptionElement_selected2.html: Added.
  • fast/forms/HTMLOptionElement_selected3-expected.txt: Added.
  • fast/forms/HTMLOptionElement_selected3.html: Added.
  • fast/forms/add-remove-option-modification-event-expected.txt:

2010-01-22 James Robinson <jamesr@chromium.org>

Reviewed by Alexey Proskuryakov.

Ensures that the 'selected' attribute of an <option> is correct
https://bugs.webkit.org/show_bug.cgi?id=32641

Adds a check in OptionElement::selected() that checks if list items need to be recalculated and does so if needed,
so the attribute is up to date more often. Also gets rid of most of the recalcStyle() side effects.

Our behavior now matches Firefox 3.5 and IE8 after the </select> is parsed.

Tests: fast/forms/HTMLOptionElement_selected2.html

fast/forms/HTMLOptionElement_selected3.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::setOptionsChangedOnRenderer): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::restoreFormControlState): (WebCore::SelectElement::reset): (WebCore::SelectElement::typeAheadFind):
  • dom/SelectElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected): (WebCore::HTMLOptionElement::insertedIntoTree):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
  • html/HTMLSelectElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::recalcStyle):
21:43 Changeset [53760] by eric@webkit.org

2010-01-22 Chris Rogers <crogers@google.com>

Reviewed by Eric Seidel.

Need to handle WebGLUnsignedByteArray as method argument for V8 binding
https://bugs.webkit.org/show_bug.cgi?id=33929

V8 code generator does not have associated tests

  • bindings/scripts/CodeGeneratorV8.pm:
21:27 Changeset [53759] by eric@webkit.org

2010-01-22 Elliot Glaysher <erg@chromium.org>

Reviewed by David Levin.

Chromium: theme selection colors to match gtk theme
Add functions to RenderThemeChromiumLinux to change the selection color
according to the current GTK+ theme.

Since the change is to the Chromium WebKit API layer, testing is done
in Chromium's test shell (see Chromium side of this patch:
http://codereview.chromium.org/554004)

https://bugs.webkit.org/show_bug.cgi?id=33921

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumLinux::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumLinux::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumLinux::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeChromiumLinux::setSelectionColors):
  • rendering/RenderThemeChromiumLinux.h: Adds static members.

2010-01-22 Elliot Glaysher <erg@chromium.org>

Reviewed by David Levin.

Chromium: theme selection colors to match gtk theme
Add functions to RenderThemeChromiumLinux to change the selection color
according to the current GTK+ theme.

Since the change is to the Chromium WebKit API layer, testing is done
in Chromium's test shell (see Chromium side of this patch:
http://codereview.chromium.org/554004)

https://bugs.webkit.org/show_bug.cgi?id=33921

  • public/WebView.h: Adds interface to change the selection colors
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setSelectionColors): Implements new interface.
  • src/WebViewImpl.h:
21:11 Changeset [53758] by eric@webkit.org

2010-01-22 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by David Levin.

A new test to check that middle clicking on the primary scroll bars
does not trigger a paste event.
https://bugs.webkit.org/show_bug.cgi?id=33062

  • scrollbars/scrollbar-middleclick-nopaste-expected.txt: Added.
  • scrollbars/scrollbar-middleclick-nopaste.html: Added.

2010-01-22 Steve VanDeBogart <vandebo@chromium.org>

Reviewed by David Levin.

Middle clicking the main scroll bars should not trigger a paste event
in Linux chromium.
https://bugs.webkit.org/show_bug.cgi?id=33062

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseUp):
21:09 UsingGitWithWebKit edited by cjerdonek@webkit.org
Added note about "commit-log-editor" and dcommit. (diff)
20:59 UsingGitWithWebKit edited by cjerdonek@webkit.org
Added note about squashing commits, if necessary, before dcommit. (diff)
20:42 Changeset [53757] by kevino@webkit.org

Reviewed by Kevin Ollivier.

[wx] Remove the Bakefile build system, which is no longer being used.

https://bugs.webkit.org/show_bug.cgi?id=34022

20:33 Changeset [53756] by kevino@webkit.org

Build fix after r53718.

20:18 Changeset [53755] by kov@webkit.org

Update platform-specific test results following r53722

20:06 Changeset [53754] by kov@webkit.org

LayoutTests

2010-01-22 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Simon Fraser.

Checking in platform-specific results for test that is failing
because of an additional single pixel in size - the test passes,
when testing manually.

  • platform/gtk/svg/custom/text-zoom-expected.txt: Added.

WebKitTools

2010-01-22 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Simon Fraser.

Reset zoom level to 1.0 when resetting view state. This is causing
many tests to fail after svg/custom/text-zoom.xhtml changes the
zoom level.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
20:00 Changeset [53753] by sfalken@apple.com

Roll out r53752 to fix bots.

19:46 Changeset [53752] by sfalken@apple.com

Rubber-stamped by Cameron Zwarich.

Re-enable Geolocation tests on Mac.

  • platform/mac/Skipped:
  • platform/win/Skipped:
19:06 Changeset [53751] by sfalken@apple.com

Mac build fix.

18:53 Changeset [53750] by sfalken@apple.com

Build fix. Don't include CoreLocation-based Geolocation if CLIENT_BASED_GEOLOCATION is set.

18:34 Changeset [53749] by sfalken@apple.com

Build fix. Touch exp file to force it to rebuild via DerivedSources.make.

18:18 WikiStart edited by cjerdonek@webkit.org
Alphabetized Documentation pages to find them more easily (diff)
18:16 Changeset [53748] by pkasting@chromium.org

Remove unnecessary copy of zlib.
https://bugs.webkit.org/show_bug.cgi?id=34028

Reviewed by Darin Adler.

  • platform/image-decoders/zlib: Removed.
  • platform/image-decoders/zlib/adler32.c: Removed.
  • platform/image-decoders/zlib/compress.c: Removed.
  • platform/image-decoders/zlib/crc32.c: Removed.
  • platform/image-decoders/zlib/crc32.h: Removed.
  • platform/image-decoders/zlib/deflate.c: Removed.
  • platform/image-decoders/zlib/deflate.h: Removed.
  • platform/image-decoders/zlib/gzio.c: Removed.
  • platform/image-decoders/zlib/infback.c: Removed.
  • platform/image-decoders/zlib/inffast.c: Removed.
  • platform/image-decoders/zlib/inffast.h: Removed.
  • platform/image-decoders/zlib/inffixed.h: Removed.
  • platform/image-decoders/zlib/inflate.c: Removed.
  • platform/image-decoders/zlib/inflate.h: Removed.
  • platform/image-decoders/zlib/inftrees.c: Removed.
  • platform/image-decoders/zlib/inftrees.h: Removed.
  • platform/image-decoders/zlib/mozzconf.h: Removed.
  • platform/image-decoders/zlib/trees.c: Removed.
  • platform/image-decoders/zlib/trees.h: Removed.
  • platform/image-decoders/zlib/uncompr.c: Removed.
  • platform/image-decoders/zlib/zconf.h: Removed.
  • platform/image-decoders/zlib/zlib.h: Removed.
  • platform/image-decoders/zlib/zutil.c: Removed.
  • platform/image-decoders/zlib/zutil.h: Removed.
18:07 Changeset [53747] by ajwong@chromium.org

Not reviewed. backout.

Backout r53705. Causes ui_tests to timeout, and browser_tests to fail with
TestConnectToBadPort and WindowOpenInvalidExtension.

17:58 Changeset [53746] by sfalken@apple.com

https://bugs.webkit.org/show_bug.cgi?id=34025
Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.

Reviewed by Darin Adler.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

WebKitTools:

  • Scripts/build-webkit:
17:52 Changeset [53745] by simon.fraser@apple.com

2010-01-22 Simon Fraser <simon.fraser@apple.com>

No review.

Commit missing test result.

  • fast/dom/Window/webkitConvertPointUpdateLayout-expected.txt: Added.
17:51 Changeset [53744] by dimich@chromium.org

Fix tests, unreviewed. Adding expectations file missing from r53739

  • fast/dom/Window/webkitConvertPointUpdateLayout-expected.txt: Added.
17:33 Changeset [53743] by sfalken@apple.com

Build fix. Add missing comma.

  • fast/dom/Window/window-properties.html:
17:17 Changeset [53742] by simon.fraser@apple.com

2010-01-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r53110): Find My iPhone message dialog is offset from original position once it gets focus
https://bugs.webkit.org/show_bug.cgi?id=33821

Fix an issue with the geometry of fixed position, composited layers inside other
composited layers. If we called convertToLayerCoords() on a fixed layer with an ancestor
layer which is not the root, then we assumed that the fixed layer had a positioning root.
However, this is not always the case, since the fixed layer may have a compositing ancestor
which is not a fixed container.

Test: compositing/geometry/fixed-in-composited.html

  • rendering/RenderLayer.cpp: (WebCore::isFixedPositionedContainer): Utility function to test whether a layer acts as a fixed position container.

(WebCore::RenderLayer::convertToLayerCoords): When called on a fixed position layer
for an ancestor layer that is not the root, compute the correct offsets by looking for
the fixed position container, and computing offsets relative to that. If the ancestorLayer
is the fixed position container, fall through to the existing code that is shared
with absolutely positioned layers.

17:14 Changeset [53741] by sfalken@apple.com

Skip fast/dom/Window/window-properties-geolocation.html
until https://bugs.webkit.org/show_bug.cgi?id=34025 is landed.

  • platform/mac/Skipped:
  • platform/win/Skipped:
17:07 Changeset [53740] by sfalken@apple.com

https://bugs.webkit.org/show_bug.cgi?id=34024
Layout tests don't easily allow Geolocation to be on in only a subset of platforms

Reviewed by Darin Adler.

  • fast/dom/Window/window-properties-geolocation-expected.txt: Added.
  • fast/dom/Window/window-properties-geolocation.html: Copied from fast/dom/Window/window-properties.html.

Moved Geolocation property testing here.

  • fast/dom/Window/window-properties.html: Exclude Geolocation from testing. Moved to window-properties-geolocation.html.
  • fast/dom/navigator-detached-no-crash.html: Exclude Geolocation from output.
  • fast/dom/script-tests/prototype-inheritance-2.js: Exclude Geolocation.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Removed Geolocation properties from expected results.
  • platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Removed. Gtk results now match baseline.
  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Removed Geolocation properties from expected results.
  • platform/qt/Skipped: Skip Geolocation tests. Not yet available in Qt.
16:46 Changeset [53739] by simon.fraser@apple.com

2010-01-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

webkitConvertPointFromNodeToPage doesn't take into account most recent transform style
https://bugs.webkit.org/show_bug.cgi?id=34023

Be sure to call updateLayoutIgnorePendingStylesheets() before doing point mapping,
to apply any style changes since the last layout.

Test: fast/dom/Window/webkitConvertPointUpdateLayout.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitConvertPointFromNodeToPage): Call updateLayoutIgnorePendingStylesheets(). (WebCore::DOMWindow::webkitConvertPointFromPageToNode): Ditto.
16:46 Changeset [53738] by dimich@chromium.org

Not reviewed, fixes one issue with window-property-descriptors test.

  • fast/dom/Window/script-tests/window-property-descriptors.js: Don't dump the property that only appears in debug build, it will fail tests in debug.
16:43 Changeset [53737] by mjs@apple.com

2010-01-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Roben.

Use stale cache data when going back and forward but not using WebCore’s page cache
https://bugs.webkit.org/show_bug.cgi?id=33993
<rdar://problem/7383392>

No tests since this is a performance change.

  • loader/CachePolicy.h: (WebCore::): Add CachePolicyAllowStale.
  • loader/DocLoader.cpp: (WebCore::DocLoader::checkForReload): Never reload in the case of CachePolicyAllowStale.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::subresourceCachePolicy): Return CachePolicyAllowStale if the main resource is being loaded to allow stale data. (WebCore::FrameLoader::addExtraFieldsToRequest): Use ReturnCacheDataElseLoad on back/forward loads - needed when going back of forward to a page with frames.
16:31 Changeset [53736] by knorton@google.com

2010-01-22 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Web Inspector: JavaScript Error in DOMAgent.js:375 (_attributesUpdated)
https://bugs.webkit.org/show_bug.cgi?id=33915

Errors were caused by the fact that Element::attributes calls Element::setAttribute to
synchronized the styleAttr. The fix is to simply check the synchronizing style attribute
flag.

  • dom/Element.cpp: (WebCore::Element::setAttribute): Checked for case where styleAttr is being synchronized.
16:27 Changeset [53735] by abarth@webkit.org

2010-01-22 Adam Barth <abarth@webkit.org>

Unreviewed. Arg. Someone renamed limit to output_limit on me.

  • Scripts/webkitpy/commands/queues.py:
16:21 Changeset [53734] by abarth@webkit.org

2010-01-22 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

Make init.py and buildbot.py pass pep8 style checker.

  • Scripts/webkitpy/init.py:
  • Scripts/webkitpy/buildbot.py:
16:12 Changeset [53733] by abarth@webkit.org

2010-01-21 Joe Mason <jmason@rim.com>

Reviewed by Adam Barth.

webkit-patch should retry on invalid password
https://bugs.webkit.org/show_bug.cgi?id=33955

Ask for bugs.webkit.org authentication in a loop.

  • Scripts/webkitpy/bugzilla.py:
16:10 Changeset [53732] by jianli@chromium.org

No review. Updated Qt layout tests due to r53722.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
16:06 Changeset [53731] by abarth@webkit.org

2010-01-22 Adam Barth <abarth@webkit.org>

Unreviewed. Don't call seek on a NoneType.

  • Scripts/webkitpy/statusserver.py:
15:58 Changeset [53730] by abarth@webkit.org

2010-01-22 Petri Latvala <petri.latvala@nomovok.com>

Reviewed by David Levin.

check-webkit-style breaks on files with unknown types
https://bugs.webkit.org/show_bug.cgi?id=34001

For files with type FileType.NONE, dispatch_processor returns None.

  • Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
15:58 Changeset [53729] by abarth@webkit.org

2010-01-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make bugzilla.py and webkitport.py conform to pep8
https://bugs.webkit.org/show_bug.cgi?id=34015

This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
style as enforced by pep8.py. I wasn't able to get rid of all the
errors because I'm not sure how to wrap some lines properly. Also,
there are a few deprication errors that I couldn't resolve easily.
However, this is a massive improvement in compliance.

  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/webkitport.py:
15:57 Changeset [53728] by abarth@webkit.org

2010-01-22 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Limit length of EWS results to 5MB
https://bugs.webkit.org/show_bug.cgi?id=34016

Hopefully this will fix the bug where the results link doesn't appear.
Our current theory is that the results blob is too big and the server
is rejecting the request with a 500 error. That causes us to re-try
the post, but when we re-try the StringIO buffer has its seek pointer
at the end.

  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/statusserver.py:
15:54 Changeset [53727] by jianli@chromium.org

No review. Build fix.
Updated the newly added test to count the change from r53722.

  • fast/dom/Window/window-property-descriptors-expected.txt:
15:50 Changeset [53726] by ossy@webkit.org

[Qt] Platform dependent expected files added for tests introduced in r53656,
because these tests pass. Compared to png files.

Reviewed by Nikolas Zimmermann.

  • platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt: Added.
15:49 Changeset [53725] by eric.carlson@apple.com

2010-01-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update r53711 for GraphicsLayer method rename.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::createLayerForMovie): Rename from change setContentsToVideo.
15:41 Changeset [53724] by pkasting@chromium.org

Not reviewed, test fix.

Update a layout test for change in page scroll size.
https://bugs.webkit.org/show_bug.cgi?id=32595

  • fast/events/scrollbar-double-click-expected.txt:
15:36 Changeset [53723] by zimmermann@webkit.org

2010-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix comment in the a SVG <use> testcase, it should say "green rectangles" instead of "blue rectangles", as noticed by Csaba Osztrogonac.

  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.checksum:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • svg/custom/relative-sized-shadow-tree-content-with-symbol.xhtml:
15:03 Changeset [53722] by jianli@chromium.org

WebCore: Add BlobConstructor to DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=33982

Reviewed by Darin Adler.

  • page/DOMWindow.idl:

LayoutTests: Updated the affected tests due to adding BlobConstructor to DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=33982

Reviewed by Darin Adler.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
15:03 Changeset [53721] by beidson@apple.com

[WebFrame loadRequest:] does not null check the WebCore::Frame
<rdar://problem/7416286> and https://bugs.webkit.org/show_bug.cgi?id=34021

Reviewed by Adele Peterson.

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]): Null check the WebCore::Frame as it can disappear

out of underneath a WebFrame.

14:59 Changeset [53720] by jianli@chromium.org

Add test for new attributes introduced in File and Blob interfaces.
https://bugs.webkit.org/show_bug.cgi?id=33980

Reviewed by Darin Adler.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js:
14:18 Changeset [53719] by bweinstein@apple.com

Rubber-stamped by Adam Roben.

Commit files that were supposed to be part of r53696, but weren't
landed.

  • English.lproj/localizedStrings.js:
  • manual-tests/debugger-caught-uncaught-exceptions.html: Added.
14:17 Changeset [53718] by pkasting@chromium.org

When scrolling by page, hold back 1/8th of the visible size instead of
40 px.
https://bugs.webkit.org/show_bug.cgi?id=32595

Reviewed by David Hyatt.

WebCore:

  • editing/EditorCommand.cpp:

(WebCore::verticalScrollDistance):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/Scrollbar.h:
  • platform/wx/ScrollViewWx.cpp:

(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):

WebKit/mac:

  • WebView/WebFrameView.mm:

(-[WebFrameView _verticalPageScrollDistance]):
(-[WebFrameView initWithFrame:]):
(-[WebFrameView _horizontalPageScrollDistance]):

14:13 Changeset [53717] by dimich@chromium.org

Not reviewed, attempted Snow Leopard build fix.

  • wtf/ThreadingPthreads.cpp: Add a forward declaration of a function which is not 'static'.
14:05 Changeset [53716] by pkasting@chromium.org

Not reviewed, backout.

Back out r52673, which caused several regressions.
https://bugs.webkit.org/show_bug.cgi?id=32533

WebCore:

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupContainer::hidePopup):
(WebCore::PopupListBox::handleKeyEvent):
(WebCore::PopupListBox::abandon):
(WebCore::PopupListBox::acceptIndex):
(WebCore::PopupListBox::selectIndex):
(WebCore::PopupListBox::clearSelection):
(WebCore::PopupListBox::hidePopup):

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenu::menuUnmapped):

  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenu::show):

  • platform/qt/QtAbstractWebPopup.cpp:

(WebCore::QtAbstractWebPopup::popupDidHide):

  • platform/qt/QtAbstractWebPopup.h:
  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::hide):

  • platform/wx/PopupMenuWx.cpp:

(WebCore::PopupMenu::OnMenuItemSelected):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::popupDidHide):

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::popupDidHide):

  • rendering/RenderTextControlSingleLine.h:

WebKit/chromium:

  • src/AutocompletePopupMenuClient.cpp:

(WebKit::AutocompletePopupMenuClient::initialize):
(WebKit::AutocompletePopupMenuClient::popupDidHide):
(WebKit::AutocompletePopupMenuClient::setTextFromItem):

  • src/AutocompletePopupMenuClient.h:

WebKit/qt:

  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopupCombo::hidePopup):

14:04 Changeset [53715] by cjerdonek@webkit.org

33791: Proposed patch 1 (amended with preferred license)

14:00 Changeset [53714] by dimich@chromium.org

Fix the leak of ThreadIdentifiers in threadMap across threads.
https://bugs.webkit.org/show_bug.cgi?id=32689

Reviewed by Maciej Stachowiak.

JavaScriptCore:

Test is added to DumpRenderTree.mm.

  • Android.mk: Added file ThreadIdentifierDataPthreads.(h|cpp) to build.
  • Android.v8.wtf.mk: Ditto.
  • GNUmakefile.am: Ditto.
  • JavaScriptCore.gyp/JavaScriptCore.gyp: Ditto.
  • JavaScriptCore.gypi: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • wtf/ThreadIdentifierDataPthreads.cpp: Added. Contains custom implementation of thread-specific data that uses custom destructor.

(WTF::ThreadIdentifierData::~ThreadIdentifierData): Removes the ThreadIdentifier from the threadMap.
(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::destruct): Custom thread-specific destructor. Resets the value for the key again to cause second invoke.
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce): Need to use pthread_once since initialization may come on any thread(s).

  • wtf/ThreadIdentifierDataPthreads.h: Added.

(WTF::ThreadIdentifierData::ThreadIdentifierData):

  • wtf/Threading.cpp:

(WTF::threadEntryPoint): Move initializeCurrentThreadInternal to after the lock to make

sure it is invoked when ThreadIdentifier is already established.

  • wtf/Threading.h: Rename setThreadNameInternal -> initializeCurrentThreadInternal since it does more then only set the name now.
  • wtf/ThreadingNone.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.

  • wtf/ThreadingWin.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.
(WTF::initializeThreading): Ditto.

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeCurrentThreadInternal): Ditto.

  • wtf/ThreadingPthreads.cpp:

(WTF::establishIdentifierForPthreadHandle):
(WTF::clearPthreadHandleForIdentifier): Make it not 'static' so the ~ThreadIdentifierData() in another file can call it.
(WTF::initializeCurrentThreadInternal): Set the thread-specific data. The ThreadIdentifier is already established by creating thread.
(WTF::waitForThreadCompletion): Remove call to clearPthreadHandleForIdentifier(threadID) since it is now done in ~ThreadIdentifierData().
(WTF::detachThread): Ditto.
(WTF::currentThread): Use the thread-specific data to get the ThreadIdentifier. It's many times faster then Mutex-protected iteration through the map.

Also, set the thread-specific data if called first time on the thread.

WebKitTools:

Add a new test to verify the ThreadIdentifiers are not reused across threads.
The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
waiting for the previous thread to terminate before starting the next.
The treads use WTF::currentThread() in their thread function. Without a fix, this
causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
The test practically does not affect the DRT run time because the threads end immediately.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(runThread): Test thread function.
(testThreadIdentifierMap):
(dumpRenderTree):

13:52 Changeset [53713] by mitz@apple.com

Rubber-stamped by Darin Adler.

Revert r53693 because it broke scrolling of pages with fixed elements on
Mac OS X.

  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):

  • platform/ScrollView.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::destroy):

12:59 Changeset [53712] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=34008
Assertion failure in KURL::setProtocol when running DOM Fuzzer

Test: fast/dom/Window/invalid-protocol.html

  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setProtocol): Raise an exception if KURL::setProtocol fails.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setProtocol): Move argument tweaking logic into KURL. This way, the ':' trick applies to both JSLocation and HTMLAnchorElement, matching IE (but not Firefox). IE behavior is more permissive, and even more logical in my opinion.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): Assert that setting protocol succeeded.
  • platform/KURL.cpp: (WebCore::KURL::setProtocol): Remove everything past ':', if present. Return false if the protocol to set is not valid. (WebCore::isValidProtocol): Made this work correctly for empty strings.
  • platform/KURL.h: isValidProtocol() is now static in KURL.cpp, it's only used in setProtocol().
  • platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): Always return true. This should hopefully prevent Chromium build breakage, alhough tests will likely fail. (WebCore::isValidProtocol): Removed, as this isn't used at the moment.
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::httpURLForAuthenticationAndCookies): Assert that setting protocol succeeded.
12:40 Changeset [53711] by eric.carlson@apple.com

2010-01-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

<rdar://problem/7373568>
https://bugs.webkit.org/show_bug.cgi?id=34007
Implement hardware acceleration of video compositing on Windows

Internally we still have QuickTime render to a bitmap, but frames are then composited
with the page using an accelerated renderer.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_newFrameAvailable. (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): Call tearDownVideoRendering. (WebCore::MediaPlayerPrivate::cancelLoad): Call tearDownVideoRendering. (WebCore::MediaPlayerPrivate::updateStates): Call setUpVideoRendering once the movie

is ready to draw.

(WebCore::MediaPlayerPrivate::isReadyForRendering): New, utility function returns true

only when movie is ready to render.

(WebCore::MediaPlayerPrivate::setSize): Remember the size as we need it when rendering

in accelerated mode.

(WebCore::MediaPlayerPrivate::setVisible): Call setUpVideoRendering when made visible.
(WebCore::MediaPlayerPrivate::paint): Do nothing when rendering to a layer. Move frame

rate drawing code to paintCompleted.

(WebCore::MediaPlayerPrivate::paintCompleted): New, clear m_newFrameAvailable and, when

built with DRAW_FRAME_RATE, draw framerate.

(WebCore::MediaPlayerPrivate::movieNewImageAvailable): Set m_newFrameAvailable, trigger

repaint differently when drawing to a layer.

(WebCore::MediaPlayerPrivate::currentRenderingMode): New, return the current rendering mode.
(WebCore::MediaPlayerPrivate::preferredRenderingMode): New, return preferred rendering mode

(render to a layer whenever possible).

(WebCore::MediaPlayerPrivate::setUpVideoRendering): New, tear down current rendering mode

and set up new mode when necessary.

(WebCore::MediaPlayerPrivate::tearDownVideoRendering): New, noop unless rendering to a layer.
(WebCore::MediaPlayerPrivate::hasSetUpVideoRendering): New.
(WebCore::MediaPlayerPrivate::paintContents): New, callback from compositing layer when it

is time to draw the current frame.

(WebCore::MediaPlayerPrivate::createLayerForMovie): New, allocate a layer for the movie.
(WebCore::MediaPlayerPrivate::destroyLayerForMovie): New, delete movie layer.
(WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): New, return true unless the

movie is not ready to render.

(WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): New, deal with change in

accelerated rendering state.

(WebCore::MediaPlayerPrivate::notifySyncRequired): New, callback from compositing layer

when it wants to schedule a redraw.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: (WebCore::MediaPlayerPrivate::notifyAnimationStarted): (WebCore::MediaPlayerPrivate::showDebugBorders): (WebCore::MediaPlayerPrivate::showRepaintCounter):
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::getCurrentFrameInfo):

New, return information about the offscreen render buffer.

(QTMovieWin::initializeQuickTime):

  • platform/graphics/win/QTMovieWin.h:
12:33 Changeset [53710] by jorlow@chromium.org

2010-01-21 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

The Chromium WebKit API needs to expose storage event related data
https://bugs.webkit.org/show_bug.cgi?id=33985

setItem and removeItem on WebStorageArea need to expose what the previous
value was for the key being modified. Clear needs to return whether it
actually cleared anything.

  • public/WebStorageArea.h: (WebKit::WebStorageArea::setItem): (WebKit::WebStorageArea::removeItem): (WebKit::WebStorageArea::clear):
  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::StorageAreaProxy): (WebCore::StorageAreaProxy::setItem): (WebCore::StorageAreaProxy::removeItem): (WebCore::StorageAreaProxy::clear): (WebCore::StorageAreaProxy::storageEvent):
  • src/StorageAreaProxy.h:
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::localStorageNamespace): (WebCore::StorageNamespace::sessionStorageNamespace): (WebCore::StorageNamespaceProxy::StorageNamespaceProxy): (WebCore::StorageNamespaceProxy::copy): (WebCore::StorageNamespaceProxy::storageArea):
  • src/StorageNamespaceProxy.h:
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem): (WebKit::WebStorageAreaImpl::removeItem): (WebKit::WebStorageAreaImpl::clear):
  • src/WebStorageAreaImpl.h:

2010-01-21 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

The Chromium WebKit API needs to expose storage event related data
https://bugs.webkit.org/show_bug.cgi?id=33985

This change is not visible to layoutTests/web pages.

  • storage/StorageArea.h:
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::setItem): return the old value (WebCore::StorageAreaImpl::removeItem): return the old value (WebCore::StorageAreaImpl::clear): return whether there was anything to clear
  • storage/StorageAreaImpl.h:
12:06 Changeset [53709] by adele@apple.com

An element that doesn't validate and an invalid element shouldn't share style
https://bugs.webkit.org/show_bug.cgi?id=34010

Reviewed by Dan Bernstein.

Test: fast/css/pseudo-invalid-novalidate-001.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Separate the check for willValidate from the check for isValidFormControlElement.
  • html/HTMLFormControlElement.h: The validity method doesn't need to be virtual.
11:49 Changeset [53708] by sfalken@apple.com

Crash in fast/dom/Window/window-properties if Geolocation enabled
https://bugs.webkit.org/show_bug.cgi?id=34013

Reviewed by Dan Bernstein.

Add null check to fix Geolocation crash in fast/dom/Window/window-properties.

  • page/Geolocation.cpp:

(WebCore::createGeoposition):

11:13 Changeset [53707] by enrica@apple.com

Fix for the failing test on qt buildbot.
This tests had been added as part of the patch for https://bugs.webkit.org/show_bug.cgi?id=33970

Reviewed by Adele Peterson.

  • editing/pasteboard/paste-noscript-svg-expected.txt:
  • editing/resources/svgcontent.xhtml:
11:09 Changeset [53706] by eric@webkit.org

2010-01-22 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Object.getOwnPropertyDescriptor(window) returns descriptors for properties in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=33948

Even though prototype properties are proxied by JSDOMWindow::getOwnPropertySlot(),
that proxying should not be performed by JSDOMWindow::getOwnPropertyDescriptor().

This makes getOwnPropertyDescriptor() consistent with getOwnPropertyNames().

Test: fast/dom/Window/window-property-descriptors.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
10:44 Changeset [53705] by darin@chromium.org

2010-01-21 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[Chromium] spurious WebViewClient::didStopLoading if changing
location.hash while a subframe is still loading

https://bugs.webkit.org/show_bug.cgi?id=33884

This is a refinement of http://trac.webkit.org/changeset/51548

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClientImpl::postProgressStartedNotification): (WebKit::FrameLoaderClientImpl::postProgressFinishedNotification):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::didStartLoading): (WebKit::WebViewImpl::didStopLoading):
  • src/WebViewImpl.h:
10:31 Changeset [53704] by aroben@apple.com

Check in expected failure results for text-zoom.xhtml on Windows

Fixing this test is covered by <http://webkit.org/b/34006>.

Rubber-stamped by Dan Bernstein.

  • platform/win/svg/custom/text-zoom-expected.txt: Added.
09:01 Changeset [53703] by girish@forwardbias.in

[Qt] Save the QWebPageClient instead of the ownerWidget in QtAbstractWebPopup

Reviewed by Simon Hausmann.

The QWebPageClient is required for the QtFallbackWebPopup. QtFallbackWebPopup will
need it to create a QGraphicsProxyWidget (in a future commit) for the
QGraphicsWebView's web popup.

08:11 Changeset [53702] by ossy@webkit.org

[Qt] http/tests/misc/slow-loading-mask.html timed out.
https://bugs.webkit.org/show_bug.cgi?id=34004

  • platform/qt/Skipped: http/tests/misc/slow-loading-mask.html skipped.
06:28 Changeset [53701] by hamaji@chromium.org

2010-01-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

incorrect results for css2.1 layout tests that use setTimeout in body onload event
https://bugs.webkit.org/show_bug.cgi?id=17557

  • css2.1/README.txt: Added.
  • css2.1/t1204-increment-00-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-00-c-o.html.
  • css2.1/t1204-increment-01-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-01-c-o.html.
  • css2.1/t1204-increment-02-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-increment-02-c-o.html.
  • css2.1/t1204-reset-00-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-00-c-o.html.
  • css2.1/t1204-reset-01-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-01-c-o.html.
  • css2.1/t1204-reset-02-c-o.html-disabled: Renamed from LayoutTests/css2.1/t1204-reset-02-c-o.html.
  • fast/css/counters/counter-increment-000-expected.txt: Renamed from LayoutTests/fast/css/counters/t1204-increment-00-c-o-expected.txt.
  • fast/css/counters/counter-increment-000.html: Renamed from LayoutTests/fast/css/counters/t1204-increment-00-c-o.html.
  • fast/css/counters/counter-increment-001-expected.txt: Renamed from LayoutTests/fast/css/counters/t1204-increment-01-c-o-expected.txt.
  • fast/css/counters/counter-increment-001.html: Renamed from LayoutTests/fast/css/counters/t1204-increment-01-c-o.html.
  • fast/css/counters/counter-reset-001-expected.txt: Added.
  • fast/css/counters/counter-reset-001.html: Added.
  • platform/mac/css2.1/t1204-increment-00-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-increment-00-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-increment-00-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-increment-01-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-increment-01-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-increment-01-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-increment-02-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-increment-02-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-increment-02-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-reset-00-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-reset-00-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-reset-00-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-reset-01-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-reset-01-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-reset-01-c-o-expected.txt: Removed.
  • platform/mac/css2.1/t1204-reset-02-c-o-expected.checksum: Removed.
  • platform/mac/css2.1/t1204-reset-02-c-o-expected.png: Removed.
  • platform/mac/css2.1/t1204-reset-02-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-increment-00-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-increment-01-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-increment-02-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-reset-00-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-reset-01-c-o-expected.txt: Removed.
  • platform/qt/css2.1/t1204-reset-02-c-o-expected.txt: Removed.
06:13 Changeset [53700] by hamaji@chromium.org

2010-01-22 Janusz Lewandowski <lew21@xtreeme.org>

Reviewed by Maciej Stachowiak.

run-webkit-tests fails on Ruby 1.9
https://bugs.webkit.org/show_bug.cgi?id=33554
inject does not work with strings any more, so BugsSite/PrettyPatch/PrettyPatch.rb prints lots of errors.

  • PrettyPatch/PrettyPatch.rb:
05:42 Changeset [53699] by hausmann@webkit.org

Unreviewed Qt "build" fix.

  • WebCore.pro: Fix warning about missing header file that isn't present anymore.
05:34 Changeset [53698] by girish@forwardbias.in

QState::polished() was renamed to QState::propertiesAssigned() when
Qt 4.6.0 was released.

Reviewed by Kenneth Rohde Christiansen.

04:56 Changeset [53697] by ossy@webkit.org

[Qt] Skip test introduced in r53684 because of missing eventSender.textZoomIn()

  • platform/qt/Skipped: svg/custom/text-zoom.xhtml skipped.
04:52 Changeset [53696] by yurys@chromium.org

2010-01-22 Brian Weinstein <bweinstein@apple.com>

Reviewed by Timothy Hatcher.

Web Inspector: Caught exceptions still pause the debugger.
<https://bugs.webkit.org/show_bug.cgi?id=28622>.

Turn the pauseOnExceptions variable from a bool to an int, because we now have
3 states, in an enum: DontPauseOnExceptions, PauseOnAllExceptions, and
PauseOnUncaughtExceptions. The status button for pausing on exceptions is now
a tri-state button, which cycles from Don't pause (no background) to Pause on All
(blue background) to Pause on Uncaught (purple background).

Also added the ability for a status button to have more than 2 states, and added
style rules for a CSS three state button.

Added a manual test, manual-tests/debugger-caught-uncaught-exceptions.html, that
generates caught and uncaught exceptions.

  • English.lproj/localizedStrings.js: Added updated Action / Click to Action text.
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::pauseOnExceptions): Changed from a bool to an int. (WebCore::InspectorBackend::setPauseOnExceptions): Ditto.
  • inspector/InspectorBackend.h: Ditto.
  • inspector/InspectorBackend.idl: Ditto.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::JavaScriptDebugServer): Changed from bool to PauseOnExceptionsState. (WebCore::JavaScriptDebugServer::setPauseOnExceptions): Ditto. (WebCore::JavaScriptDebugServer::exception): Updated logic to see if we are breaking

on uncaught exceptions, and check if we have a handler.

  • inspector/JavaScriptDebugServer.h: (WebCore::JavaScriptDebugServer::): Changed from bool to PauseOnExceptionsState. (WebCore::JavaScriptDebugServer::pauseOnExceptions): Ditto.
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptionsState): Changed from returning false to returning 0 (stub function).
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): Updated to new text/new cycling of variables. (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): Updated to new text/new cycling of variables.
  • inspector/front-end/StatusBarButton.js: (WebInspector.StatusBarButton): Added the option for a different number of states. (WebInspector.StatusBarButton.prototype.set toggled): Added rules to toggle on/off with multiple states.
  • inspector/front-end/inspector.css: Added rules for toggled-1 and toggled-2.
  • manual-tests/debugger-caught-uncaught-exceptions.html: Added.
04:30 Changeset [53695] by eric@webkit.org

2010-01-22 Ben Murdoch <benm@google.com>

Reviewed by Eric Seidel.

[Android] Android platform specific PlatformTouchEvent and PlatformTouchPoint implementations are not upstream.
https://bugs.webkit.org/show_bug.cgi?id=33719

Add the Android specific files and update the Android makefile.

No new tests as this is all Android-specific code.

  • Android.mk: Add Touch event related files to the makefile.
  • platform/PlatformTouchEvent.h: Add Android constructor.
  • platform/PlatformTouchPoint.h: Ditto.
  • platform/android/PlatformTouchEventAndroid.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent): Android implementation.
  • platform/android/PlatformTouchPointAndroid.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint): Android implementation.
04:23 QtWebKitBackportingFixes edited by girish@forwardbias.in
(diff)
04:04 Changeset [53694] by ossy@webkit.org

Unreviewed trivial fix.

[Qt] css1_forward_compatible_parsing.html moved from css2.1 to fast/css by r53664.

  • platform/qt/Skipped: path fixed.
04:01 Changeset [53693] by eric@webkit.org

2010-01-22 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

The RenderObjects with fixed position register to the view
to be taken into account while scrolling.
The scrolling code update specifically those elements after blitting the pixels.

  • page/FrameView.cpp: (WebCore::FrameView::registerFixedPositionedObject): (WebCore::FrameView::unregisterFixedPositionedObject): (WebCore::FrameView::scrollContentsFastPath):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
  • platform/ScrollView.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::destroy):
03:57 Changeset [53692] by ukai@chromium.org

2010-01-22 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Maciej Stachowiak.

Split websocket/tests/bad-sub-protocol.html
https://bugs.webkit.org/show_bug.cgi?id=33646

  • websocket/tests/bad-sub-protocol-control-chars-expected.txt: Added.
  • websocket/tests/bad-sub-protocol-control-chars.html: Added.
  • websocket/tests/bad-sub-protocol-empty-expected.txt: Added.
  • websocket/tests/bad-sub-protocol-empty.html: Added.
  • websocket/tests/bad-sub-protocol-expected.txt: Removed.
  • websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Added.
  • websocket/tests/bad-sub-protocol-non-ascii.html: Added.
  • websocket/tests/bad-sub-protocol.html: Removed.
  • websocket/tests/script-tests/bad-sub-protocol-control-chars.js: Added.
  • websocket/tests/script-tests/bad-sub-protocol-empty.js: Added.
  • websocket/tests/script-tests/bad-sub-protocol-non-ascii.js: Added.
  • websocket/tests/script-tests/bad-sub-protocol.js: Removed.
02:48 Changeset [53691] by eric@webkit.org

2010-01-22 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Improve portability of listbox-deselect-scroll.html
https://bugs.webkit.org/show_bug.cgi?id=33989

  • Convert the test to dumpAsTest
  • Use eventSender.mouseDown(0, addSelectionKey?)
  • Avoid hard-coded line-heights.
  • fast/forms/listbox-deselect-scroll-expected.txt: Added.
  • fast/forms/listbox-deselect-scroll.html:
  • fast/forms/script-tests/listbox-deselect-scroll.js: Added.
  • platform/mac/fast/forms/listbox-deselect-scroll-expected.checksum: Removed.
  • platform/mac/fast/forms/listbox-deselect-scroll-expected.png: Removed.
  • platform/mac/fast/forms/listbox-deselect-scroll-expected.txt: Removed.

2010-01-22 Kent Tamura <tkent@chromium.org>

Reviewed by Maciej Stachowiak.

Fix a bug that mouseDown:withModifiers: is never called.
https://bugs.webkit.org/show_bug.cgi?id=33989

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]):
02:26 Changeset [53690] by eric@webkit.org

2010-01-22 Anton Muhin <antonm@chromium.org>

Reviewed by Eric Seidel.

Adding ScriptWrappable into WebCore.
This allows to associate custom information when Node
gets wrapped into JavaScript wrapper.

[v8, dom] Add a pointer field to C++ Node class
https://bugs.webkit.org/show_bug.cgi?id=32430

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptWrappable.h: Added. (WebCore::ScriptWrappable::ScriptWrappable):
  • bindings/v8/ScriptWrappable.h: Added. (WebCore::ScriptWrappable::ScriptWrappable): (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper):
  • dom/Node.h:
01:42 Changeset [53689] by yurys@chromium.org

emikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Add stub implementation of dispatchOnInjectedScript method so that
Chromium source can compile against it and the main fix for the bug
28622 can be landed without breaking Chromium build.

https://bugs.webkit.org/show_bug.cgi?id=28622

  • inspector/InspectorBackend.h: (WebCore::InspectorBackend::dispatchOnInjectedScript):
01:19 Changeset [53688] by eric@webkit.org

2010-01-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Dmitry Titov.

ENABLE(DATABASE) guard is missing in ScriptExecutionContext::~ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=33990

Add missing ENABLE(DATABASE) guard.

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
01:17 Changeset [53687] by kenneth@webkit.org

[Qt] Separate out the WebPage class into it's own
cpp/header files. Also, removed the assumption that
the view is a QWebView, in preparation of a merger
of the two Qt WebKit launchers.

Rubberstamped by Antti Koivisto.

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/main.cpp:

(WebView::mousePressEvent):

  • QtLauncher/webpage.cpp: Added.

(WebPage::supportsExtension):
(WebPage::extension):
(WebPage::acceptNavigationRequest):
(WebPage::openUrlInDefaultBrowser):

  • QtLauncher/webpage.h: Added.

(WebPage::WebPage):

00:42 Changeset [53686] by xan@webkit.org

2010-01-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

  • bindings/scripts/generate-bindings.pl:
00:42 Changeset [53685] by xan@webkit.org

2010-01-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Rename FEATURE_DEFINES_JAVASCRIPT to FEATURE_DEFINES and remove
the hardcoded LANGUAGE_JAVASCRIPT=1, in preparation for its use by
the GObject DOM bindings.

  • GNUmakefile.am:
00:20 Changeset [53684] by mitz@apple.com

<rdar://problem/7568696> Zoom applied to embedded SVG incorrectly
https://bugs.webkit.org/show_bug.cgi?id=33988

Reviewed by Darin Adler.

WebCore:

Test: svg/custom/text-zoom.xhtml

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement): Initialize m_scale.
(WebCore::SVGSVGElement::currentScale): If this is the document element,
return the frame’s zoom factor. Otherwise, return m_scale.
(WebCore::SVGSVGElement::setCurrentScale): If this is the document element,
set the frame’s zoom factor. Otherwise, set m_scale and mark for layout.

  • svg/SVGSVGElement.h: Added m_scale member.

LayoutTests:

  • svg/custom/text-zoom-expected.checksum: Added.
  • svg/custom/text-zoom-expected.png: Added.
  • svg/custom/text-zoom-expected.txt: Added.
  • svg/custom/text-zoom.xhtml: Added.
Note: See TracTimeline for information about the timeline view.