Timeline


and

02/02/10:

22:56 Changeset [54274] by tkent@chromium.org

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that changes for some constraint attributes doesn't
update validation CSS selectors.
https://bugs.webkit.org/show_bug.cgi?id=31716

Add tests for maxLength changes and step changes.

  • fast/forms/input-live-pseudo-selectors-expected.txt:
  • fast/forms/resources/input-live-pseudo-selectors.js:
  • fast/forms/resources/textarea-live-pseudo-selectors.js:
  • fast/forms/textarea-live-pseudo-selectors-expected.txt:

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that changes for some constraint attributes doesn't
update validation CSS selectors.
https://bugs.webkit.org/show_bug.cgi?id=31716

  • Rename HTMLFormControlElement::updateValidity() to setNeedsValidityCheck()
  • Introduce HTMLFormControlElement::setNeedsWillValidate()
  • Introduce HTMLFormControlElement::m_hasName to make willValidate() work in parseMappedAttribute().
  • We need to call setNeedsValidityCheck() when HTMLInputElement::step or HTMLTextAreaElement::maxLength is changed.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::insertedIntoTree): (WebCore::HTMLFormControlElement::removedFromTree): (WebCore::HTMLFormControlElement::formDestroyed): (WebCore::HTMLFormControlElement::willValidate): Avoids function calls. (WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): (WebCore::HTMLFormControlElement::setNeedsValidityCheck):
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::disabled): Move the code from .cpp.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::setValue):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
21:57 Changeset [54273] by rolandsteiner@chromium.org

Bug 34198 - Ruby text should not inherit line-height
(https://bugs.webkit.org/show_bug.cgi?id=34198)

Reviewed by Adele Peterson.

Resetting line-height to 'normal' in the default UA style sheet.
Adding layout-test to check for this.

WebCore:

Test: fast/ruby/ruby-line-height.html

  • css/html.css:

LayoutTests:

  • fast/ruby/script-tests: Added.
  • fast/ruby/script-tests/ruby-line-height.js: Added.
  • fast/ruby/ruby-line-height-expected.txt: Added.
  • fast/ruby/ruby-line-height.html: Added.
21:22 Changeset [54272] by eric@webkit.org

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483

Add tests for datetime, datetime-local, month, time and week, and
merge existing tests into one test file.

  • fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-date.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-number.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-range.html: Removed.
  • fast/forms/ValidityState-rangeOverflow.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-date.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow.html: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.

2010-02-02 James Robinson <jamesr@chromium.org>

Reviewed by Dmitry Titov.

Add a null check for image, which might be NULL if tileSize is empty
https://bugs.webkit.org/show_bug.cgi?id=34510

Test: fast/gradients/crash-on-1px-border.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
20:21 Changeset [54271] by tkent@chromium.org

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483

Add tests for datetime, datetime-local, month, time and week, and
merge existing tests into one test file.

  • fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-date.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-number.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-range.html: Removed.
  • fast/forms/ValidityState-rangeOverflow.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-date.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow.html: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483

Tests: fast/forms/ValidityState-rangeOverflow.html

fast/forms/ValidityState-rangeUnderflow.html

  • html/HTMLInputElement.cpp: Defines the hard limits for the types as double values. (WebCore::HTMLInputElement::rangeUnderflow): Supports the types. (WebCore::HTMLInputElement::rangeOverflow): Supports the types. (WebCore::HTMLInputElement::minimum): Supports the types. (WebCore::HTMLInputElement::maximum): Supports the types.
20:20 Changeset [54270] by hamaji@chromium.org

2010-02-02 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Implement WebFrameImpl::pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34471

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageNumberForElementById):
  • src/WebFrameImpl.h:
20:00 Changeset [54269] by kevino@webkit.org

[wx] Build fix after introduction of pageNumberForElementById.

19:42 Changeset [54268] by mrowe@apple.com

Roll out r54252.

The method it deleted is in fact used, and its deletion resulted in plug-ins that use accelerated compositing not being drawn.

17:36 Changeset [54267] by ukai@chromium.org

2010-02-02 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket wrapper can be collected even if events are pending
https://bugs.webkit.org/show_bug.cgi?id=34014

  • websocket/tests/websocket-pending-activity-expected.txt: Added.
  • websocket/tests/websocket-pending-activity.html: Added.

2010-02-02 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket set pending activity to avoid unexpected GC.
https://bugs.webkit.org/show_bug.cgi?id=34014

Test: websocket/tests/websocket-pending-activity.html

  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect): set pending activity until it receives didClose. (WebCore::WebSocket::contextDestroyed): check socket is already closed. (WebCore::WebSocket::stop): close the connection and unset pending activity when it stops. (WebCore::WebSocket::didClose): unset pending activity.
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData): protect this while it processes received data.
17:21 Changeset [54266] by kov@webkit.org

2010-02-02 Gustavo Noronha Silva <gns@gnome.org>

No review, rolling out r54261.
http://trac.webkit.org/changeset/54261
https://bugs.webkit.org/show_bug.cgi?id=34435

Causes crashes on release builds

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
  • platform/gtk/GOwnPtrGtk.cpp: Removed.
  • platform/gtk/GOwnPtrGtk.h: Removed.
17:13 Changeset [54265] by oliver@apple.com

2010-02-02 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Crash in CollectorBitmap::get at nbcolympics.com
https://bugs.webkit.org/show_bug.cgi?id=34504

This was caused by the use of m_offset to determine the offset of
a new property into the property storage. This patch corrects
the effected cases by incorporating the anonymous slot count. It
also removes the duplicate copy of anonymous slot count from the
property table as keeping this up to date merely increased the
chance of a mismatch. Finally I've added a large number of
assertions in an attempt to prevent such a bug from happening
again.

With the new assertions in place the existing anonymous slot tests
all fail without the m_offset fixes.

  • runtime/PropertyMapHashTable.h:
  • runtime/Structure.cpp: (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::removePropertyTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::removePropertyWithoutTransition): (JSC::Structure::copyPropertyTable): (JSC::Structure::get): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable): (JSC::Structure::rehashPropertyMapHashTable): (JSC::Structure::checkConsistency):
17:12 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
16:54 Changeset [54264] by levin@chromium.org

2010-02-02 David Levin <levin@chromium.org>

No review, rolling out r54245.
http://trac.webkit.org/changeset/54245
https://bugs.webkit.org/show_bug.cgi?id=34492

This patch seems to have broken thousands of chromium tests on
Windows (and since it was for chromium, I'm rolling it out).

  • dom/Element.cpp: (WebCore::Element::baseURI):
16:25 Changeset [54263] by sfalken@apple.com

2010-02-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503

2010-02-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503

  • win/tools/scripts/auto-version.sh:

2010-02-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503

  • WebKit.vcproj/WebKit.rc:

2010-02-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503

  • WebCore.vcproj/QTMovieWin.rc:
16:05 Changeset [54262] by dglazkov@chromium.org

2010-02-02 Dimitri Glazkov <dglazkov@chromium.org>

No review, rolling out r54257.
http://trac.webkit.org/changeset/54257
https://bugs.webkit.org/show_bug.cgi?id=34491

[Chromium] broke thousands of Win tests and a few of Linux tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::applyAntiAliasedClipPaths):
  • platform/graphics/skia/PlatformContextSkia.h:
16:03 Changeset [54261] by eric@webkit.org

2010-02-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] libsoup critical warning in media player http cookies injection code
https://bugs.webkit.org/show_bug.cgi?id=34435

Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent not Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
  • platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::SoupURI): (WTF::GstElement):
  • platform/gtk/GOwnPtrGtk.h: Added.
15:37 Changeset [54260] by kov@webkit.org

2010-02-02 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Bump version, and adjust library versioning for 1.1.20.

  • configure.ac:

WebKit/gtk

2010-02-02 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Changes in 1.1.20, and documentation control files update.

  • NEWS:
  • docs/webkitgtk-docs.sgml:
15:23 Changeset [54259] by japhet@chromium.org

2010-02-02 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.


https://bugs.webkit.org/show_bug.cgi?id=32563

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptObject.cpp:
  • bindings/v8/V8AbstractEventListener.cpp:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8NodeFilterCondition.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8CustomPositionCallback.cpp:
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8DocumentLocationCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8MessageEventCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NodeIteratorCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGMatrixCustom.cpp:
  • bindings/v8/custom/V8StyleSheetListCustom.cpp:
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
15:16 Changeset [54258] by snej@chromium.org

Clarified coding guidelines on wiki to allow indentation of _nested_ namespaces.
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=32137

15:06 Changeset [54257] by eric@webkit.org

2010-02-02 Garret Kelly <gdk@chromium.org>

Reviewed by David Levin.

When using the Skia graphics context, the beginTransparencyLayer call
currently creates a new layer, but does not keep the current
compositing mode for use when merging the created layer back onto the
rest of the context. This patch fixes that.
https://bugs.webkit.org/show_bug.cgi?id=34491

fast/backgrounds/svg-as-mask.html is affected by this change in Chromium,
but not fixed. This is the first of a series of patches to fix it.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::beginTransparencyLayer):
  • platform/graphics/skia/PlatformContextSkia.h:
14:50 Changeset [54256] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument
https://bugs.webkit.org/show_bug.cgi?id=34409

Platform guards for localtime_r are not needed because we already have
WTF::getLocalTime which does the same thing.

  • loader/FTPDirectoryDocument.cpp: (WebCore::processFileDateString):
  • loader/FTPDirectoryParser.cpp: (WebCore::gmtimeQt):
14:34 Changeset [54255] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add dummy main thread functions
https://bugs.webkit.org/show_bug.cgi?id=33569

Add dummy initializeMainThreadPlatform and
scheduleDispatchFunctionsOnMainThread.

  • wtf/brew/MainThreadBrew.cpp: Added. (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread):
14:29 Changeset [54254] by eric@webkit.org

2010-02-02 Eric Seidel <eric@webkit.org>

Reviewed by Gustavo Noronha Silva.

http/tests/incremental/split-hex-entities.pl timed out on Gtk Linux 32-bit Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33445

  • platform/gtk/Skipped: Skip this test to keep the bots green until someone with Gtk knowledge can examine why it intermittently times out.
14:18 Changeset [54253] by eric@webkit.org

2010-02-02 Hayato Ito <hayato@chromium.org>

Reviewed by Darin Adler.

Move misplaced JS files to the proper location.

https://bugs.webkit.org/show_bug.cgi?id=34256

  • fast/events/script-tests/basic-touch-events.js: Removed.
  • fast/events/script-tests/create-touch-event.js: Removed.
  • fast/events/script-tests/send-oncancel-event.js: Removed.
  • fast/events/touch/basic-touch-events.html:
  • fast/events/touch/create-touch-event.html:
  • fast/events/touch/script-tests: Added.
  • fast/events/touch/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/events/script-tests/TEMPLATE.html.
  • fast/events/touch/script-tests/basic-touch-events.js: Copied from LayoutTests/fast/events/script-tests/basic-touch-events.js.
  • fast/events/touch/script-tests/create-touch-event.js: Copied from LayoutTests/fast/events/script-tests/create-touch-event.js.
  • fast/events/touch/script-tests/send-oncancel-event.js: Copied from LayoutTests/fast/events/script-tests/send-oncancel-event.js.
  • fast/events/touch/send-oncancel-event.html:
14:00 Changeset [54252] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=34502
Unused method pluginLayer in Netscape plug-in views

  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: Removed the method.
13:23 Changeset [54251] by mrowe@apple.com

Merge r54242.

13:09 Changeset [54250] by aroben@apple.com

Copy WebCore's bindings generation scripts to the PrivateHeaders directory on Mac

This will allow other projects to use these scripts.

Fixes <http://webkit.org/b/34498>.

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj: Added the bindings generation

scripst to the Copy Headers phase, and marked them as Private.

12:55 Changeset [54249] by aroben@apple.com

Copy WebCore's bindings generation scripts to a more sensible location

Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

Instead of copying to obj/WebKit/DOMInterfaces, copy to obj/WebCore/scripts.

12:54 Changeset [54248] by aroben@apple.com

Rename the scripts used to copy WebCore's bindings generation scripts

Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/MigrateScripts: Renamed from WebCore/WebCore.vcproj/MigrateIDLAndScripts.
  • WebCore.vcproj/migrate-scripts.sh: Renamed from WebCore/WebCore.vcproj/migrate-idls.sh.
  • WebCore.vcproj/WebCoreGenerated.vcproj: Updated for renames.
12:54 Changeset [54247] by aroben@apple.com

Stop copying IDL files into $(WebKitOutputDir)

No one uses these anymore (as of r52921).

Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/MigrateIDLAndScripts: Don't copy the IDL files

anymore. Keep copying the scripts, though, since other projects
(outside of the WebKit repository) do use those.

12:54 Changeset [54246] by aroben@apple.com

Stop copying WebCore's IDL files from SRCROOT to OBJROOT

WebKit doesn't use these anymore (as of r52921).

Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebKit.vcproj/WebKit.make:
12:04 Changeset [54245] by eric@webkit.org

2010-02-02 Bryan Yeung <bryeung@bryeung-chrome.(none)>

Reviewed by Darin Adler.

Avoid using an invalidated KURL object in baseURI.

https://bugs.webkit.org/show_bug.cgi?id=34492

This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg

  • dom/Element.cpp: (WebCore::Element::baseURI):
11:47 Changeset [54244] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Add using WTF::getLocalTime to CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=34493

  • wtf/CurrentTime.h:
10:16 Changeset [54243] by chang.shu@nokia.com

Add myself to list of committers.

10:00 Changeset [54242] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=34076
<rdar://problem/7594601> Crash in mangleme in WebCore::Element::getAttribute

Test: fast/forms/misplaced-img-form-registration.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerImgElement): Assert that the same image isn't added to vector again. (WebCore::HTMLFormElement::removeImgElement): Similarly, assert that we're removing something that's actually registered.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): If parser fails to insert the image element, then there will be no removed from tree notification either, need to unregister right away.
09:19 Changeset [54241] by kenneth@webkit.org

Do not use a proxy widget for the QComboBox on Maemo 5, as it
is not working properly and it is not needed at all, as the
comboboxes comes up in their full width on the screen and
do not depend on view.

Reviewed by Ariya Hidayat.

  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopup::show):

09:08 Changeset [54240] by apavlov@chromium.org

2010-02-02 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Eliminate some of the platform flavor-specific stylesheet selectors

Extract OS version into WebInspector.platformFlavor
https://bugs.webkit.org/show_bug.cgi?id=34469

  • inspector/front-end/InspectorBackendStub.js:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.platform):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.pendingDispatches.0.URLRegExp.i.get platform): (WebInspector.get platformFlavor): (WebInspector._detectPlatformFlavor): (WebInspector.loaded): (WebInspector.toolbarDragStart): (WebInspector.isMac):
08:35 Changeset [54239] by mrobinson@webkit.org

2010-02-02 Martin Robinson <mrobinson@webkit.org>

Unreviewed build fix.

The WinCairo build requires this script to be executable.

  • win/tools/scripts/feature-defines.sh: Added property svn:executable.
07:48 Changeset [54238] by aroben@apple.com

Stop skipping some tests that were failing due to buggy versions of CFNetwork

Rubber-stamped by Eric Carlson.

  • platform/win/Skipped:
07:45 Changeset [54237] by eric@webkit.org

2010-02-02 Steve Block <steveblock@google.com>

Reviewed by Ariya Hidayat.

Adds utility functions for converting between JavaInstance and NPAPI types
https://bugs.webkit.org/show_bug.cgi?id=34468

This is required by Android for injecting objects into V8 JavaScript.

No new tests, added utility functions only.

  • Android.v8bindings.mk: Modified. Added JavaNPObjectV8.cpp
  • bridge/jni/v8/JavaNPObjectV8.cpp: Added. (JSC::Bindings::AllocJavaNPObject): (JSC::Bindings::FreeJavaNPObject): (JSC::Bindings::): (JSC::Bindings::JavaInstanceToNPObject): (JSC::Bindings::ExtractJavaInstance): (JSC::Bindings::JavaNPObjectHasMethod): (JSC::Bindings::JavaNPObjectInvoke): (JSC::Bindings::JavaNPObjectHasProperty): (JSC::Bindings::JavaNPObjectGetProperty):
  • bridge/jni/v8/JavaNPObjectV8.h: Added.
07:42 QtWebKitJSCapp edited by siddharth.mathur@nokia.com
(diff)
07:35 QtWebKitJSCapp created by siddharth.mathur@nokia.com
07:35 Changeset [54236] by jberlin@webkit.org

2010-02-02 Jessie Berlin <jberlin@webkit.org>

Rubber Stamped by Holger Freyther.

[Qt] Fix style issue identified in bug:
https://bugs.webkit.org/show_bug.cgi?id=34329

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::InspectorClientWebPage): Fix indentation.
07:31 QtWebKit edited by siddharth.mathur@nokia.com
added new page for jsc.exe (diff)
07:29 Changeset [54235] by eric@webkit.org

2010-02-02 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Symbian plugins include a wrong header file for QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34475

  • plugins/symbian/PluginViewSymbian.cpp:
07:28 Changeset [54234] by cjerdonek@webkit.org

2010-02-02 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Moved filter-related check-webkit-style code into a separate
filter module.

https://bugs.webkit.org/show_bug.cgi?id=34408

This is preparatory refactoring for Bug 33684, which will allow
file and folder-specific filter rules.

  • Scripts/webkitpy/style/checker.py:
    • Removed CategoryFilter class (moved to filter.py).
  • Scripts/webkitpy/style/checker_unittest.py:
    • Removed CategoryFilter unit tests (moved to filter_unittest.py).
  • Scripts/webkitpy/style/filter.py: Added.
    • Added CategoryFilter class (moved from checker.py).
  • Scripts/webkitpy/style/filter_unittest.py: Added.
    • Added CategoryFilter unit tests (moved from checker_unittest.py).
  • Scripts/webkitpy/style/unittests.py:
    • Added reference to filter_unittest.py.
07:25 Changeset [54233] by jberlin@webkit.org

2010-02-01 Jessie Berlin <jberlin@webkit.org>

Reviewed by Holger Freyther.

[Qt] Enable inspecting the Web Inspector in QtLauncher

https://bugs.webkit.org/show_bug.cgi?id=34329

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::InspectorClientWebPage): Allow the DeveloperExtrasEnabled setting to default to true for the page containing the Web Inspector.
06:22 Changeset [54232] by yurys@chromium.org

2010-02-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Upstream DevTools code.

https://bugs.webkit.org/show_bug.cgi?id=34326

  • WebKit.gyp:
  • src/APUAgentDelegate.h: Added.
  • src/BoundObject.cpp: Added. (WebKit::BoundObject::BoundObject): (WebKit::BoundObject::~BoundObject): (WebKit::BoundObject::addProtoFunction): (WebKit::BoundObject::build):
  • src/BoundObject.h: Added.
  • src/DebuggerAgent.h: Added.
  • src/DebuggerAgentImpl.cpp: Added. (WebKit::DebuggerAgentImpl::DebuggerAgentImpl): (WebKit::DebuggerAgentImpl::~DebuggerAgentImpl): (WebKit::DebuggerAgentImpl::getContextId): (WebKit::DebuggerAgentImpl::debuggerOutput): (WebKit::DebuggerAgentImpl::createUtilityContext): (WebKit::DebuggerAgentImpl::executeUtilityFunction): (WebKit::DebuggerAgentImpl::executeVoidJavaScript): (WebKit::DebuggerAgentImpl::page):
  • src/DebuggerAgentImpl.h: Added. (WebKit::DebuggerAgentImpl::setAutoContinueOnException): (WebKit::DebuggerAgentImpl::autoContinueOnException): (WebKit::DebuggerAgentImpl::webdevtoolsAgent): (WebKit::DebuggerAgentImpl::webView):
  • src/DebuggerAgentManager.cpp: Added. (WebKit::DebuggerAgentManager::debugHostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::onV8DebugMessage): (WebKit::DebuggerAgentManager::pauseScript): (WebKit::DebuggerAgentManager::executeDebuggerCommand): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler): (WebKit::DebuggerAgentManager::setHostId): (WebKit::DebuggerAgentManager::onWebViewClosed): (WebKit::DebuggerAgentManager::onNavigate): (WebKit::DebuggerAgentManager::sendCommandToV8): (WebKit::DebuggerAgentManager::sendContinueCommandToV8): (WebKit::DebuggerAgentManager::findAgentForCurrentV8Context): (WebKit::DebuggerAgentManager::debuggerAgentForHostId):
  • src/DebuggerAgentManager.h: Added. (WebKit::DebuggerAgentManager::UtilityContextScope::UtilityContextScope): (WebKit::DebuggerAgentManager::UtilityContextScope::~UtilityContextScope):
  • src/DevToolsRPC.h: Added. (WebKit::): (WebKit::DevToolsRPC::Delegate::Delegate): (WebKit::DevToolsRPC::Delegate::~Delegate): (WebKit::DevToolsRPC::DevToolsRPC): (WebKit::DevToolsRPC::~DevToolsRPC): (WebKit::DevToolsRPC::sendRpcMessage):
  • src/DevToolsRPCJS.h: Added.
  • src/ProfilerAgent.h: Added.
  • src/ProfilerAgentImpl.cpp: Added. (WebKit::ProfilerAgentImpl::getActiveProfilerModules): (WebKit::ProfilerAgentImpl::getLogLines):
  • src/ProfilerAgentImpl.h: Added. (WebKit::ProfilerAgentImpl::ProfilerAgentImpl): (WebKit::ProfilerAgentImpl::~ProfilerAgentImpl):
  • src/ToolsAgent.h: Added.
  • src/WebDevToolsAgentImpl.cpp: Added. (WebKit::): (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::disposeUtilityContext): (WebKit::WebDevToolsAgentImpl::unhideResourcesPanelIfNecessary): (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::didNavigate): (WebKit::WebDevToolsAgentImpl::didCommitProvisionalLoad): (WebKit::WebDevToolsAgentImpl::didClearWindowObject): (WebKit::WebDevToolsAgentImpl::forceRepaint): (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController): (WebKit::WebDevToolsAgentImpl::dispatchOnInjectedScript): (WebKit::WebDevToolsAgentImpl::executeVoidJavaScript): (WebKit::WebDevToolsAgentImpl::dispatchMessageFromFrontend): (WebKit::WebDevToolsAgentImpl::inspectElementAt): (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled): (WebKit::WebDevToolsAgentImpl::sendRpcMessage): (WebKit::WebDevToolsAgentImpl::compileUtilityScripts): (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost): (WebKit::WebDevToolsAgentImpl::createInspectorBackendV8Wrapper): (WebKit::WebDevToolsAgentImpl::resetInspectorFrontendProxy): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::jsDispatchOnClient): (WebKit::WebDevToolsAgentImpl::jsDispatchToApu): (WebKit::WebDevToolsAgentImpl::jsEvaluateOnSelf): (WebKit::WebDevToolsAgentImpl::jsOnRuntimeFeatureStateChanged): (WebKit::WebDevToolsAgentImpl::inspectorController): (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest): (WebKit::WebDevToolsAgentImpl::willSendRequest): (WebKit::WebDevToolsAgentImpl::didReceiveData): (WebKit::WebDevToolsAgentImpl::didReceiveResponse): (WebKit::WebDevToolsAgentImpl::didFinishLoading): (WebKit::WebDevToolsAgentImpl::didFailLoading): (WebKit::WebDevToolsAgentImpl::evaluateInWebInspector): (WebKit::WebDevToolsAgentImpl::setTimelineProfilingEnabled): (WebKit::WebDevToolsAgent::create): (WebKit::WebDevToolsAgent::executeDebuggerCommand): (WebKit::WebDevToolsAgent::debuggerPauseScript): (WebKit::WebDevToolsAgent::setMessageLoopDispatchHandler): (WebKit::WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread):
  • src/WebDevToolsAgentImpl.h: Added. (WebKit::WebDevToolsAgentImpl::hostId):
  • src/WebDevToolsFrontendImpl.cpp: Added. (WebKit::ToV8String): (WebKit::WebDevToolsFrontend::create): (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::dispatchMessageFromAgent): (WebKit::WebDevToolsFrontendImpl::executeScript): (WebKit::WebDevToolsFrontendImpl::dispatchOnWebInspector): (WebKit::WebDevToolsFrontendImpl::sendRpcMessage): (WebKit::WebDevToolsFrontendImpl::contextMenuItemSelected): (WebKit::WebDevToolsFrontendImpl::contextMenuCleared): (WebKit::WebDevToolsFrontendImpl::jsLoaded): (WebKit::WebDevToolsFrontendImpl::jsPlatform): (WebKit::WebDevToolsFrontendImpl::jsPort): (WebKit::WebDevToolsFrontendImpl::jsCopyText): (WebKit::WebDevToolsFrontendImpl::jsActivateWindow): (WebKit::WebDevToolsFrontendImpl::jsCloseWindow): (WebKit::WebDevToolsFrontendImpl::jsDockWindow): (WebKit::WebDevToolsFrontendImpl::jsUndockWindow): (WebKit::WebDevToolsFrontendImpl::jsLocalizedStringsURL): (WebKit::WebDevToolsFrontendImpl::jsHiddenPanels): (WebKit::WebDevToolsFrontendImpl::jsDebuggerCommand): (WebKit::WebDevToolsFrontendImpl::jsSetting): (WebKit::WebDevToolsFrontendImpl::jsSetSetting): (WebKit::WebDevToolsFrontendImpl::jsDebuggerPauseScript): (WebKit::WebDevToolsFrontendImpl::jsWindowUnloading): (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
  • src/WebDevToolsFrontendImpl.h: Added. (WebKit::WebDevToolsFrontendImpl::MenuProvider::create): (WebKit::WebDevToolsFrontendImpl::MenuProvider::~MenuProvider): (WebKit::WebDevToolsFrontendImpl::MenuProvider::disconnect): (WebKit::WebDevToolsFrontendImpl::MenuProvider::populateContextMenu): (WebKit::WebDevToolsFrontendImpl::MenuProvider::contextMenuItemSelected): (WebKit::WebDevToolsFrontendImpl::MenuProvider::contextMenuCleared): (WebKit::WebDevToolsFrontendImpl::MenuProvider::MenuProvider):
06:20 Nightly Builds edited by aroben@apple.com
(diff)
05:59 Changeset [54231] by pfeldman@chromium.org

2010-02-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: URLs are not syntax-higlighted as links in source view.

This change enables linkifier in the NativeTextViewer. It adds
"linkify" and "a_node" parse states into the highlighter in order
to detect links and distinguish between resource and external ones.
Contains drive-by fix for the webkit-html-* styles and moves them to the
common location.

https://bugs.webkit.org/show_bug.cgi?id=34364

  • inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer): (WebInspector.NativeTextViewer.prototype._createSpan): (WebInspector.NativeTextViewer.prototype._createLink): (WebInspector.NativeTextViewer.prototype._rewriteHref):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspectorSyntaxHighlight.css:
05:32 Changeset [54230] by eric@webkit.org

2010-02-02 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha Silva.

[GTK] When selection changes selections in other WebView are not collapsed
https://bugs.webkit.org/show_bug.cgi?id=34043

Collapse the selection of a WebView even when the new selection owner is
a new WebView.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::clearClipboardContentsCallback): Only clear the DataObject we are setting is not the same as the one referenced in this callback. Use the same behavior for collapsing the selection. (WebKit::PasteboardHelperGtk::writeClipboardContents): Instead of recording a boolean record the actual data used while writing to the clipboard.
05:16 Changeset [54229] by eric@webkit.org

2010-02-02 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Install libraries and headers in package builds
https://bugs.webkit.org/show_bug.cgi?id=34325

Add the QtWebKit libraries to the installable items, except on
Symbian where the libraries are always linked in their final
destination.

Also include the headers generated by syncqt in the installation.

  • WebCore.pro:
04:59 Changeset [54228] by eric@webkit.org

2010-02-02 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Display HTML tags verbatim in JS alert/confirm/prompt boxes

https://bugs.webkit.org/show_bug.cgi?id=34429

  • Api/qwebpage.cpp: (QWebPage::javaScriptAlert): (QWebPage::javaScriptConfirm): (QWebPage::javaScriptPrompt):
04:43 Changeset [54227] by eric@webkit.org

2010-02-02 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Dmitry Titov.

[V8] Raising an exception while setting timeout/interval from a detached frame
https://bugs.webkit.org/show_bug.cgi?id=34453
This fixes the issue/failing test mentioned in Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=32671

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
04:27 Changeset [54226] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port Screen
https://bugs.webkit.org/show_bug.cgi?id=34299

Get the screen size and depth from the main display bitmap.

  • platform/brew/ScreenBrew.cpp: Added. (WebCore::getDisplayInfo): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
04:10 Changeset [54225] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port LocalizedStrings
https://bugs.webkit.org/show_bug.cgi?id=34257

Port LocalizedStrings to BREWMP.

  • platform/brew/LocalizedStringsBrew.cpp: Added. (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::unknownFileSizeText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::imageTitle): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::AXButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXMenuListPopupActionVerb): (WebCore::AXMenuListActionVerb): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText): (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
03:56 Changeset [54224] by ossy@webkit.org

[Qt] fast/frames/set-unloaded-frame-location.html timed out on Qt Linux Release Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33303

fast/frames/sandboxed-iframe-navigation-windowopen.html made fast/frames/set-unloaded-frame-location.html
time out, but now it works correctly, so we can unskip the test.

  • platform/qt/Skipped: fast/frames/sandboxed-iframe-navigation-windowopen.html unskipped.
03:54 Changeset [54223] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port systemBeep
https://bugs.webkit.org/show_bug.cgi?id=33601

Implement systemBeep with IShell_Beep.

  • platform/brew/SoundBrew.cpp: Added. (WebCore::systemBeep):
03:38 Changeset [54222] by eric@webkit.org

2010-02-02 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable a way to measure FPS in QGVLauncher
run QGVLauncher with --show-fps to see ongoing fps measurements
This is not meant as accurate FPS, but rather as a way to find
improvements/regressions
https://bugs.webkit.org/show_bug.cgi?id=34450

  • QGVLauncher/main.cpp: (MainView::MainView): initialize FPS values (MainView::paintEvent): count a painted frame here (MainView::printFps): we print the fps with qDebug every 5 seconds.
03:07 Changeset [54221] by hamaji@chromium.org

2010-02-02 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

[Win] Utilize PrintContext to share the printing code with other ports
https://bugs.webkit.org/show_bug.cgi?id=34312

No new tests as this is just a small refactoring.

02:54 Changeset [54220] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add HAVE_XXX definitions
https://bugs.webkit.org/show_bug.cgi?id=34414

Add HAVE_ERRNO_H=1

  • wtf/Platform.h:
02:32 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
02:27 Changeset [54219] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add conversions between IntPoint and AEEPoint
https://bugs.webkit.org/show_bug.cgi?id=34194

Make it easy to convert between IntPoint and AEEPoint.

  • platform/graphics/IntPoint.h:
  • platform/graphics/brew/IntPointBrew.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator AEEPoint):
01:58 Changeset [54218] by steveblock@google.com

Adds virtual destructors for AbstractWeakReferenceMap and AbstractWeakReferenceMap::Visitor
https://bugs.webkit.org/show_bug.cgi?id=34434

Reviewed by Adam Barth.

No new tests, build fix only.

  • bindings/v8/V8DOMMap.h: Modified.

(WebCore::AbstractWeakReferenceMap::~AbstractWeakReferenceMap): Added.
(WebCore::AbstractWeakReferenceMap::Visitor::~Visitor): Added.

01:53 WebKit Team edited by alex@webkit.org
Committer since last week (diff)
01:46 Changeset [54217] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Don't define HAVE_TM_GMTOFF, HAVE_TM_ZONE and HAVE_TIMEGM
https://bugs.webkit.org/show_bug.cgi?id=34388

BREWMP does not have these features.

  • wtf/Platform.h:
01:18 Changeset [54216] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Define WTF_PLATFORM_BREWMP=1 when BUILDING_BREWMP is defined
https://bugs.webkit.org/show_bug.cgi?id=34386

Define WTF_PLATFORM_BREWMP=1 so that PLATFORM(BREWMP) guard can be used.

  • wtf/Platform.h:
00:52 Changeset [54215] by eric@webkit.org

2010-02-02 Avi Drissman <avi@chromium.org>

Reviewed by Eric Seidel.

Sync up Chromium Mac render theme to Mac render theme
https://bugs.webkit.org/show_bug.cgi?id=34340

Covered by existing layout tests.

  • platform/chromium/ThemeChromiumMac.mm: (WebCore::updateStates): (WebCore::checkbox): (WebCore::paintCheckbox): (WebCore::radio): (WebCore::paintRadio): (WebCore::listButtonSizes): (WebCore::setupButtonCell): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeChromiumMac::controlSize): (WebCore::ThemeChromiumMac::minimumControlSize): (WebCore::ThemeChromiumMac::controlBorder): (WebCore::ThemeChromiumMac::paint):
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]): (WebCore::convertNSColorToColor): (WebCore::RenderThemeChromiumMac::systemColor): (WebCore::RenderThemeChromiumMac::isControlStyled): (WebCore::RenderThemeChromiumMac::adjustRepaintRect): (WebCore::RenderThemeChromiumMac::convertToPaintingRect): (WebCore::RenderThemeChromiumMac::paintCapsLockIndicator): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintMenuListButton): (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): (WebCore::RenderThemeChromiumMac::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumMac::paintSliderTrack): (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintSearchField): (WebCore::RenderThemeChromiumMac::setSearchFieldSize): (WebCore::RenderThemeChromiumMac::adjustSearchFieldStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::RenderThemeChromiumMac::popupButton): (WebCore::RenderThemeChromiumMac::sliderThumbHorizontal): (WebCore::RenderThemeChromiumMac::sliderThumbVertical):
00:52 Changeset [54214] by jorlow@chromium.org

2010-02-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add WebSecurityOrigin::createFromString factory
https://bugs.webkit.org/show_bug.cgi?id=34460

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::createFromString):
00:35 Changeset [54213] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port Logging
https://bugs.webkit.org/show_bug.cgi?id=34300

Log calls to notImplemented() by default.

  • platform/brew/LoggingBrew.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary):
00:25 Changeset [54212] by tkent@chromium.org

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Should not select a word on right-click.
https://bugs.webkit.org/show_bug.cgi?id=33364

For non-Mac platforms, do not select a word around the caret when
a context menu is opening. This behavior is not common in non-Mac
platforms, and it prevents pasting with a context menu.

In order that the spell checker works without the selection, we
introduce WebFrame::selectWordAroundCaret(). We can replace a word
around the caret with selectWordAroundCaret() + replaceSelection().

  • public/WebFrame.h: Add pure selectWordAroundCaret() declaration.
  • src/ContextMenuClientImpl.cpp: (WebKit::selectMisspelledWord): Move word-selection code to WebFrameImpl::selectWordAroundPosition(), and clear the selection on non-Mac.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundPosition): (WebKit::WebFrameImpl::selectWordAroundCaret):
  • src/WebFrameImpl.h: Add selectWordAroundCaret() declaration.
00:19 Changeset [54211] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port FileChooser
https://bugs.webkit.org/show_bug.cgi?id=34261

Port FileChooser to BREWMP.

  • platform/brew/FileChooserBrew.cpp: Added. (WebCore::FileChooser::basenameForWidth):

02/01/10:

23:56 Changeset [54210] by zoltan@webkit.org

2010-02-01 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for IconDatabaseClient class
https://bugs.webkit.org/show_bug.cgi?id=33252

Inherits the following struct from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
class IconDatabaseClient - loader/icon/IconDatabase.cpp:89

  • loader/icon/IconDatabaseClient.h:
23:51 Changeset [54209] by bweinstein@apple.com

Check in new expected results for a test that has been failing on Windows
since it was originally landed. This appears to be a font issue, but commenting
on bug <https://bugs.webkit.org/show_bug.cgi?id=34234> to make sure.

  • platform/win/fast/text/international/hebrew-vowels-expected.txt: Added.
23:46 Changeset [54208] by eric@webkit.org

2010-02-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port MIMETypeRegistry
https://bugs.webkit.org/show_bug.cgi?id=34220

Port MIMETypeRegistry with an extension map as other ports do.

  • platform/brew: Added.
  • platform/brew/MIMETypeRegistryBrew.cpp: Added. (WebCore::): (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
22:53 Changeset [54207] by dimich@chromium.org

Revert r54194 that fails new test on Qt and Chromium.
https://bugs.webkit.org/show_bug.cgi?id=34382

22:41 Changeset [54206] by cjerdonek@webkit.org

Addressed FIXME in check-webkit-style so that the carriage-return
check will work for patches.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34260

Also added support for limiting the number of errors reported
per category, per file.

  • Scripts/webkitpy/style/checker.py:
    • Added new "whitespace/carriage_return" category from common.py.
    • Added MAX_REPORTS_PER_CATEGORY dictionary.
    • Added max_reports_per_category attribute to ProcessorOptions class.
    • Refactored StyleChecker._process_file().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated ProcessorOptionsTest tests.
    • Added test to check MAX_REPORTS_PER_CATEGORY.
  • Scripts/webkitpy/style/error_handlers.py:
    • Added support for suppressing the display of errors after reaching a per-category maximum (from max_reports_per_category).
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Added test for suppressing error display.
  • Scripts/webkitpy/style/processors/common.py: Added.
    • Moved carriage-return check to new file.
  • Scripts/webkitpy/style/processors/common_unittest.py: Added.
    • Added unit tests for carriage-return check.
  • Scripts/webkitpy/style/unittests.py:
    • Added reference to common_unittest.py.
22:28 Changeset [54205] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • printing/page-break-always-expected.txt: Added.
  • printing/page-break-always.html: Added.
  • printing/pageNumerForElementById-expected.txt: Added.
  • printing/pageNumerForElementById.html: Added.
  • printing/script-tests/TEMPLATE.html: Added.
  • printing/script-tests/page-break-always.js: Added. (createParagraph):
  • printing/script-tests/pageNumerForElementById.js: Added. (createParagraph):

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840

Test: printing/page-break-always.html

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/PrintContext.cpp: (WebCore::PrintContext::pageRect): Added a getter function. (WebCore::PrintContext::computePageRects): Move its logic into computePageRectsWithPageSize. (WebCore::PrintContext::computePageRectsWithPageSize): Factored out from computePageRects for pageNumberForElement. (WebCore::enclosingBoxModelObject): Added for pageNumberForElement. (WebCore::PrintContext::pageNumberForElement): Added for testing.
  • page/PrintContext.h:

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame pageNumberForElement:element:pageWidth:]):

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840

  • DumpRenderTree/LayoutTestController.cpp: (pageNumberForElementByIdCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageNumberForElementById):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageNumberForElementById):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageNumberForElementById):
22:19 Changeset [54204] by eric@webkit.org

2010-02-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add conversions between IntSize and AEESize
https://bugs.webkit.org/show_bug.cgi?id=34197

Make it easy to convert between IntSize and AEESize.

  • platform/graphics/IntSize.h:
  • platform/graphics/brew/IntSizeBrew.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator AEESize):
21:36 Changeset [54203] by eric@webkit.org

2010-02-01 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

Fix for Pattern transformations in Chromium/Skia. This required
reworking Pattern a bit to be more like the Gradient implementation.
In particular, it now holds an m_pattern reference to the
platform-specific implementation, and passes along changes to the
m_patternSpaceTransformation, in the same way that Gradient does for
m_gradientSpaceTransformation. This is necessary since Skia creates the
platform-specific pattern (SkShader) once, rather than recreating it
on each draw.
For platforms other than Skia, m_pattern is unused, they will
continue to use the static createPlatformPattern(), and the new
notification functions are stubbed out. Other platforms can switch to
the new implementation if they so choose.

https://bugs.webkit.org/show_bug.cgi?id=24534

Covered by svg/custom/pattern-y-offset.svg,
svg/custom/pattern-cycle-detection.svg, and many more.

  • platform/graphics/Pattern.cpp: (WebCore::Pattern::Pattern): Initializer for m_pattern. (WebCore::Pattern::~Pattern): call platformDestroy(). (WebCore::Pattern::setPatternSpaceTransform): Pass along the transform via setPlatformPatternSpaceTransform(). (WebCore::Pattern::platformDestroy): (WebCore::Pattern::setPlatformPatternSpaceTransform): Stub implementations for non-skia platforms.
  • platform/graphics/Pattern.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): Call platformPattern() instead of static version. Since Pattern now owns its SkShader, no need to unref here.
  • platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformDestroy): Unref the SkShader on destroy. (WebCore::Pattern::platformPattern): Create the platform pattern (SkShader) once, and cache it. (WebCore::Pattern::setPlatformPatternSpaceTransform): Set the shader's local matrix from the m_patternSpaceTransformation.
21:13 Changeset [54202] by dbates@webkit.org

2010-02-01 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27312

Implements support for full page blocking via the X-XSS-Protection header.

Tests: http/tests/security/xssAuditor/full-block-base-href.html

http/tests/security/xssAuditor/full-block-get-from-iframe.html
http/tests/security/xssAuditor/full-block-iframe-javascript-url.html
http/tests/security/xssAuditor/full-block-iframe-no-inherit.php
http/tests/security/xssAuditor/full-block-javascript-link.html
http/tests/security/xssAuditor/full-block-link-onclick.html
http/tests/security/xssAuditor/full-block-object-tag.html
http/tests/security/xssAuditor/full-block-post-from-iframe.html
http/tests/security/xssAuditor/full-block-script-tag-with-source.html
http/tests/security/xssAuditor/full-block-script-tag.html
http/tests/security/xssAuditor/malformed-xss-protection-header.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::shouldFullPageBlockForXSSProtectionHeader): Added. (WebCore::XSSAuditor::findInRequest): Modified to call method XSSAuditor::shouldFullPageBlockForXSSProtectionHeader.
  • page/XSSAuditor.h: Defined method shouldFullPageBlockForXSSProtectionHeader and fixed misspelled words in large comment block.

2010-02-01 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27312

Tests that the header "X-XSS-Protection: full-block" leads to a full page block
when an XSS attack is detected.

  • http/tests/security/xssAuditor/full-block-base-href-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-base-href.html: Added.
  • http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-get-from-iframe.html: Added.
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url.html: Added.
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit.php: Added.
  • http/tests/security/xssAuditor/full-block-javascript-link-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-javascript-link.html: Added.
  • http/tests/security/xssAuditor/full-block-link-onclick-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-link-onclick.html: Added.
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-object-tag.html: Added.
  • http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-post-from-iframe.html: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-with-source.html: Added.
  • http/tests/security/xssAuditor/full-block-script-tag.html: Added.
  • http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt: Added.
  • http/tests/security/xssAuditor/malformed-xss-protection-header.html: Added.
  • http/tests/security/xssAuditor/resources/echo-head-base-href.pl: Modified to optionally enable full page blocking.
  • http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Ditto.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl: Ditto.
  • http/tests/security/xssAuditor/resources/utilities.js: (checkIfFrameLocationMatchesURLAndCallDone): Added. (sendRequestFromIFrame): Modified to optionally call callback function when done.
21:10 Changeset [54201] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dmitry Titov.

Convert textarea-rows-cols.html to dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=34074

Remove checks for the size of scrollbar as scrollbar doesn't
appear on Windows.

  • fast/forms/script-tests/textarea-rows-cols.js:
  • fast/forms/textarea-rows-cols-expected.txt:
21:01 Changeset [54200] by eric@webkit.org

2010-02-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port SharedTimer with IShell_SetTimerEx.
https://bugs.webkit.org/show_bug.cgi?id=33599

As fireTime passed in setSharedTimerFireTime is the absolute time,
we must calcalute the interval by subtracting currentTime() from
fireTime and pass the result to ISHELL_SetTimerEx.

  • platform/brew/SharedTimerBrew.cpp: Added. (WebCore::invokeCallback): (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
20:56 Changeset [54199] by tkent@chromium.org

2010-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Date.UTC() should apply TimeClip operation.
https://bugs.webkit.org/show_bug.cgi?id=34461

ECMAScript 5 15.9.4.3:

9 Return TimeClip(MakeDate(MakeDay(yr, m, dt), MakeTime(h, min, s, milli))).

  • runtime/DateConstructor.cpp: (JSC::dateUTC): Calls WTF::timeClip().

2010-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Date.UTC() should apply TimeClip operation.
https://bugs.webkit.org/show_bug.cgi?id=34461

Add tests for corner cases of Date.UTC().

  • fast/js/date-utc-timeclip-expected.txt: Added.
  • fast/js/date-utc-timeclip.html: Added.
  • fast/js/script-tests/date-utc-timeclip.js: Added.
20:48 Changeset [54198] by tkent@chromium.org

2010-02-01 Kent Tamura <tkent@chromium.org>

Unreviewed. Add two more test cases which I forgot to add in r54197.
https://bugs.webkit.org/show_bug.cgi?id=34462

  • fast/js/math-expected.txt:
  • fast/js/script-tests/math.js:
20:42 Changeset [54197] by tkent@chromium.org

2010-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that Math.round() retunrs incorrect results for huge integers
https://bugs.webkit.org/show_bug.cgi?id=34462

  • runtime/MathObject.cpp: (JSC::mathProtoFuncRound): Avoid "arg + 0.5".

2010-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that Math.round() retunrs incorrect results for huge integers
https://bugs.webkit.org/show_bug.cgi?id=34462

  • fast/js/math-expected.txt:
  • fast/js/script-tests/math.js: Add test cases for Math.round() for huge numbers.
20:13 Changeset [54196] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

[Chromium] Unreviewed attempt to fix the chromium build.

Corresponding change: http://trac.webkit.org/changeset/54182

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/ScriptController.h:
19:19 Changeset [54195] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed attempt to fix the broken build.

This was introduced in http://trac.webkit.org/changeset/54182

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::performMediaPlayerAction):
19:14 Changeset [54194] by dimich@chromium.org

When a live iframe element is moved between pages, it still depends on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382

Reviewed by David Levin.

WebCore:

Test: fast/frames/iframe-reparenting-new-page.html

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::setName):
Move the code setting the frame name into a separate function.

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::updateLiveFrame):
Update frame tree, reset page in the contentFrame and re-set the name.

(WebCore::HTMLFrameElementBase::insertedIntoDocument):

  • html/HTMLFrameElementBase.h:
  • page/Frame.cpp:

(WebCore::Frame::setPage):

  • page/Frame.h: Add setPage method. It is only currently used when iframe is

moved between pages (so the ASSERT(m_ownerElement).

LayoutTests:

  • fast/frames/iframe-reparenting-new-page-expected.txt: Added.
  • fast/frames/iframe-reparenting-new-page.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-1.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-2.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-iframe.html: Added.
19:06 Changeset [54193] by beidson@apple.com

WebCore: Add common IRC ports to port blocking.
<rdar://problem/7593895> and https://bugs.webkit.org/show_bug.cgi?id=34451

Reviewed by Tim Hatcher.

  • platform/KURL.cpp:

(WebCore::portAllowed):

LayoutTests: Add common IRC ports to port blocking.
<rdar://problem/7593895> and https://bugs.webkit.org/show_bug.cgi?id=34451

  • platform/mac-tiger/security/block-test-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • security/block-test.html:

Reviewed by Tim Hatcher.

18:45 Changeset [54192] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed fix for an invalid function call.

check-webkit-style: Remove filename parameter from all functions where no longer used
https://bugs.webkit.org/show_bug.cgi?id=34249

  • Scripts/webkitpy/style/checker.py:
18:43 Changeset [54191] by jorlow@chromium.org

2010-01-27 Matt Perry <mpcomplete@chromium.org>

Reviewed by Eric Seidel.

Add support for addUserScript to chromium port.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::addUserScript): (WebKit::WebViewImpl::removeAllUserContent):
  • src/WebViewImpl.h:
18:42 Changeset [54190] by jorlow@chromium.org

2010-01-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

[V8] Add compile time guards for IndexedDB custom functions
https://bugs.webkit.org/show_bug.cgi?id=34368

  • bindings/v8/custom/V8IDBRequestCustom.cpp:
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
18:07 QtWebKitGraphics edited by noam.rosenthal@nokia.com
(diff)
18:06 cssAnimTestSuite.html attached to QtWebKitGraphics by noam.rosenthal@nokia.com
Comprehensive test suite for CSS animations
18:04 CssAnimationTestSuite edited by noam.rosenthal@nokia.com
(diff)
18:02 cssAnimTestSuite.html attached to CssAnimationTestSuite by noam.rosenthal@nokia.com
18:01 CssAnimationTestSuite created by noam.rosenthal@nokia.com
17:48 Changeset [54189] by mrowe@apple.com

Merge r53116.

17:48 Changeset [54188] by mrowe@apple.com

Merge r53115.

17:48 Changeset [54187] by mrowe@apple.com

Merge r53114.

17:48 Changeset [54186] by mrowe@apple.com

Merge r53096.

17:47 Changeset [54185] by mrowe@apple.com

Merge r53093.

17:47 Changeset [54184] by mrowe@apple.com

Merge r53078.

17:33 Changeset [54183] by eric@webkit.org

2010-02-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port WTF's currentTime
https://bugs.webkit.org/show_bug.cgi?id=33567

Combine GETUTCSECONDS and GETTIMEMS to calculate the number
of milliseconds since 1970/01/01 00:00:00 UTC.

  • wtf/CurrentTime.cpp: (WTF::currentTime):
17:20 Changeset [54182] by barraclough@apple.com

Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds

WebCore:

Reviewed by Sam Weinig + Oliver Hunt.

Change HTMLMediaElement methods that require checking whether the event is a user gesture to
be passed a boolean. This may be passed from the JSC bindings (where we have an exec state),
or read from the event. Add a Flag to the IDL to mark this information is required.

  • WebCore.Video.exp:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::processingUserGesture):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::domWindowAllowPopUp):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::processingUserGesture):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::anyPageIsProcessingUserGesture):

  • bindings/js/ScriptController.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Event.cpp:

(WebCore::Event::isUserEvent):

  • dom/Event.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removedFromDocument):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::documentDidBecomeActive):
(WebCore::HTMLMediaElement::webkitEnterFullScreen):

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::isProcessingUserGesture):

  • loader/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::allowPopUp):

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlSeekButtonElement::defaultEventHandler):

WebKit/mac:

Reviewed by Sam Weinig + Oliver Hunt.

Pass processeing user gensture flag to media play/pause methods.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController setPlaying:]):

WebKit/win:

Reviewed by Sam Weinig + Oliver Hunt.

Pass processeing user gensture flag to media play/pause methods.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::play):
(FullscreenVideoController::pause):

LayoutTests:

Reviewed by Sam Weinig.

  • http/tests/security/isolatedWorld/resources/userGestureEvents-second-window.html: Added.
  • http/tests/security/isolatedWorld/userGestureEvents-expected.txt: Added.
  • http/tests/security/isolatedWorld/userGestureEvents.html: Added.
17:17 Changeset [54181] by mrowe@apple.com

Merge r51976 and the parts of r50704 that it depended on.

17:16 Changeset [54180] by eric@webkit.org

2010-02-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Use the fallback style on Maemo 5

https://bugs.webkit.org/show_bug.cgi?id=34376

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::fallbackStyle): (WebCore::RenderThemeQt::qStyle): (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
  • platform/qt/RenderThemeQt.h:
17:00 Changeset [54179] by eric@webkit.org

2010-02-01 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Nate Chapin.

[V8] Making V8 generated classes' GetTemplate() function public
https://bugs.webkit.org/show_bug.cgi?id=34026

  • bindings/scripts/CodeGeneratorV8.pm: Generated code need not depend on V8CustomBinding.h, made GetTemplate() signature public.
16:56 Changeset [54178] by mitz@apple.com

<rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()

Reviewed by Anders Carlsson.

The crash was caused by having two streams with a streamID of 1.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
correctly increments m_currentURLRequestID to account for the manual stream.
(WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
null it out instead of trying to remove it from the map. Added an assertion.
(WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.

16:42 Changeset [54177] by mrowe@apple.com

Merge r51704.

16:39 Changeset [54176] by eric@webkit.org

2010-02-01 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

[Qt] WinCE buildfix after r52729 and fix for Q_BIG_ENDIAN typo.
https://bugs.webkit.org/show_bug.cgi?id=34378

  • wtf/Platform.h:
16:35 Changeset [54175] by steveblock@google.com

Adds V8-specific JNI bridge classes
https://bugs.webkit.org/show_bug.cgi?id=34166

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JNIBridgeJSC.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JNIBridge.cpp and JNIBridgeV8.cpp
  • bridge/Bridge.h: Modified. Added missing include for Noncopyable.h
  • bridge/jni/v8/JNIBridgeV8.cpp: Added.

(JavaField::JavaField):

  • bridge/jni/v8/JNIBridgeV8.h: Added.

(JSC::Bindings::JavaField::name):
(JSC::Bindings::JavaField::type):
(JSC::Bindings::JavaField::getJNIType):

16:34 Changeset [54174] by mrowe@apple.com

Merge r51962.

16:34 Changeset [54173] by mrowe@apple.com

Merge r50110.

16:34 Changeset [54172] by mrowe@apple.com

Merge r50017.

16:25 Changeset [54171] by steveblock@google.com

Adds V8-specific JNI utility functions.
https://bugs.webkit.org/show_bug.cgi?id=33901

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JNIUtilityPrivate.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Add JNIUtilityPrivate.cpp
  • bridge/jni/v8/JNIUtilityPrivate.cpp: Added.

(JSC::Bindings::convertNPVariantToJValue):
(JSC::Bindings::convertJValueToNPVariant):

  • bridge/jni/v8/JNIUtilityPrivate.h: Added.
16:23 Changeset [54170] by mrowe@apple.com

Merge r52784.

16:15 Changeset [54169] by steveblock@google.com

Adds V8 version of JavaClass
https://bugs.webkit.org/show_bug.cgi?id=33898

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JavaClassJSC

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JavaClassV8.cpp
  • bridge/jni/v8/JavaClassV8.cpp: Added.

(JavaClass::JavaClass):
(JavaClass::~JavaClass):
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):

  • bridge/jni/v8/JavaClassV8.h: Added.
16:09 Changeset [54168] by mrowe@apple.com

Merge r51645.

16:09 Changeset [54167] by mrowe@apple.com

Merge r50310.

16:08 Changeset [54166] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

REGRESSION: editing/selection/doubleclick-beside-cr-span.html times out on Windows
https://bugs.webkit.org/show_bug.cgi?id=34069

Make the sleep time shorter as this test timed out on Windows bot.

  • editing/selection/doubleclick-beside-cr-span.html:
16:03 Changeset [54165] by steveblock@google.com

Adds V8 version of JavaInstance
https://bugs.webkit.org/show_bug.cgi?id=33951

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JavaInstanceJSC.
Also fixes a typo in a comment in JavaInstanceJSC.cpp.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JavaInstanceV8.cpp
  • bridge/jni/jsc/JavaInstanceJSC.cpp: Modified.

(JavaInstance::invokeMethod): Modified. Fixed comment

  • bridge/jni/v8/JavaInstanceV8.cpp: Added.

(JavaInstance::JavaInstance):
(JavaInstance::~JavaInstance):
(JavaInstance::getClass):
(JavaInstance::invokeMethod):
(JObjectWrapper::JObjectWrapper):
(JObjectWrapper::~JObjectWrapper):

  • bridge/jni/v8/JavaInstanceV8.h: Added.

(JSC::Bindings::JObjectWrapper::instance):
(JSC::Bindings::JObjectWrapper::setInstance):
(JSC::Bindings::JObjectWrapper::ref):
(JSC::Bindings::JObjectWrapper::deref):
(JSC::Bindings::JavaInstance::javaInstance):
(JSC::Bindings::JavaInstance::begin):
(JSC::Bindings::JavaInstance::end):
(JSC::Bindings::JavaInstance::virtualBegin):
(JSC::Bindings::JavaInstance::virtualEnd):

15:43 Changeset [54164] by mrowe@apple.com

Merge r47726.

15:38 Changeset [54163] by mrowe@apple.com

Merge r51659.

15:32 Changeset [54162] by dumi@chromium.org

Making sure that all in-progress transactions are rolled back on
the database thread before they're destroyed. Otherwise,
SQLiteTransaction's destructor will try to do a rollback and that
would cause an assertion failure, if the object is not destroyed
on the DB thread.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=34152

  • platform/sql/SQLiteTransaction.cpp:

(WebCore::SQLiteTransaction::stop):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):

  • storage/SQLTransaction.h:
  • storage/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::shutdown):

15:32 Changeset [54161] by mrowe@apple.com

Merge r53813.

15:32 Changeset [54160] by mrowe@apple.com

Merge r53812.

15:26 Changeset [54159] by mrowe@apple.com

Merge r50466.

15:25 Changeset [54158] by mrowe@apple.com

Merge r50470.

15:25 Changeset [54157] by mrowe@apple.com

Merge r50435.

15:23 Changeset [54156] by weinig@apple.com

Fix EXPERIMENTAL_SINGLE_VIEW_MODE build.

Reviewed by Beth Dakin.

  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::currentNSEvent):
(WebCore::EventHandler::currentKeyboardEvent):
(WebCore::EventHandler::mouseDown):
(WebCore::EventHandler::mouseDragged):
(WebCore::EventHandler::mouseUp):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):

15:19 Changeset [54155] by eric@webkit.org

2010-02-01 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT Provide global flag ability
https://bugs.webkit.org/show_bug.cgi?id=34418

Add the globalFlag property to the Qt LayoutTestController to allow
cross-domain indications.

  • platform/qt/Skipped:

2010-02-01 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT Provide global flag ability
https://bugs.webkit.org/show_bug.cgi?id=34418

Add the globalFlag property to the Qt LayoutTestController to allow
cross-domain indications.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::globalFlag): (LayoutTestController::setGlobalFlag):
15:11 Changeset [54154] by mrowe@apple.com

Merge r50083.

14:39 Changeset [54153] by japhet@chromium.org

2010-02-01 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium build fix.

Failed to properly add new files for http://trac.webkit.org/changeset/54150.

  • bindings/v8/custom/V8BarInfoCustom.cpp: Added.
  • bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8CSSValueCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
  • bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
  • bindings/v8/custom/V8SVGElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
  • bindings/v8/custom/V8ScreenCustom.cpp: Added.
  • bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
14:29 Changeset [54152] by mpcomplete@chromium.org

Add support for addUserScript to chromium port.

14:20 Changeset [54151] by eric.carlson@apple.com

2010-02-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=34448
<rdar://problem/7598130>

RenderVideo::intrinsicSizeChanged infinite recursion

  • rendering/RenderImage.h: (WebCore::RenderImage::intrinsicSizeChanged): Make protected instead of private so it can

be called by RenderVideo.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::intrinsicSizeChanged): Call RenderMedia::intrinsicSizeChanged, not

RenderVideo::intrinsicSizeChanged.

(WebCore::RenderVideo::imageChanged): Call RenderMedia::imageChanged instead of

RenderImage::imageChanged.

14:12 Changeset [54150] by japhet@chromium.org

2010-02-01 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Generate toV8() converter for most WebCore->V8 conversions,
and defined custom converters in their respective V8<class>Custom.cpp.

Old converters in V8DOMWrapper will be deleted in a later patch.

https://bugs.webkit.org/show_bug.cgi?id=32563

  • Android.v8bindings.mk:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8BarInfoCustom.cpp: Added.
  • bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8CSSValueCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8ConsoleCustom.cpp:
  • bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NavigatorCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
  • bindings/v8/custom/V8SVGElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
  • bindings/v8/custom/V8ScreenCustom.cpp: Added.
  • bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
  • dom/make_names.pl: Add options to generate wrapper factory for V8 bindings.
14:06 Changeset [54149] by bweinstein@apple.com

Rubber-stamped by Oliver Hunt.

Check in (failing) expected results for fast/dom/Window/window-postmessage-clone-frames.
This fails because of <rdar://problem/5230396> eventSender.beginDragWithFiles is unimplemented.

  • platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
14:03 WebKit Team edited by hamaji@chromium.org
minor fix for quotations (diff)
14:02 Changeset [54148] by eric@webkit.org

2010-02-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: lazy-load textual resources to avoid UI hangup
https://bugs.webkit.org/show_bug.cgi?id=34332

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.contentTabSelected):
13:53 Changeset [54147] by eric.carlson@apple.com

2010-02-01 Eric Carlson <eric.carlson@apple.com>

No review, build fix.

https://bugs.webkit.org/show_bug.cgi?id=34447
http/tests/media/video-referer.html fails on Windows

  • platform/win/Skipped:
13:35 Changeset [54146] by ossy@webkit.org

[Qt] Unreviewed trivial fix.
Platform dependent expected file updated after r54143.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
13:21 Changeset [54145] by beidson@apple.com

Crash in Safari opening new tabs to "same page"
<rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444

Reviewed by Adele Peterson.

WebCore:

Test: fast/loader/crash-copying-backforwardlist.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadItem): Null check currentItem().

  • page/Page.cpp:

(WebCore::Page::goToItem): Ditto.

WebKitTools:

Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(setNewWindowsCopyBackForwardListCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::newWindowsCopyBackForwardList):
(LayoutTestController::setNewWindowsCopyBackForwardList):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:createWebViewWithRequest:]):

LayoutTests:

  • fast/loader/crash-copying-backforwardlist-expected.txt: Added.
  • fast/loader/crash-copying-backforwardlist.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
13:09 Changeset [54144] by kevino@webkit.org

Reviewed by Kevin Ollivier.

[wx] Remove unused file that doesn't seem to belong to the port.

https://bugs.webkit.org/show_bug.cgi?id=34445

12:48 Changeset [54143] by eric.carlson@apple.com

2010-02-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Fullscreen API should be on HTMLVideoElement
https://bugs.webkit.org/show_bug.cgi?id=34438


Move fullscreen DOM APIs from HTMLMediaElement to HTMLVideoElement.

  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::paint): Removed outdated FIXME. (WebCore::HTMLVideoElement::paintCurrentFrameInContext): Ditto. (WebCore::HTMLVideoElement::webkitEnterFullScreen): Moved from HTMLMediaElement. (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto. (WebCore::HTMLVideoElement::webkitSupportsFullscreen): Ditto. (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:

2010-02-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Fullscreen API should be on HTMLVideoElement
https://bugs.webkit.org/show_bug.cgi?id=34438

Update fullscreen tests now that <audio> doesn't have fullscreen API.

  • fast/dom/Window/window-properties-expected.txt:
  • media/media-fullscreen-inline-expected.txt:
  • media/media-fullscreen-not-in-document-expected.txt:
  • media/media-fullscreen.js: (buttonClickHandler): (canplaythrough):
12:05 Changeset [54142] by carol.szabo@nokia.com

2010-02-01 Carol Szabo <carol.szabo@nokia.com>

Unreviewed.

Add myself to list of committers.

  • Scripts/webkitpy/committers.py:
12:04 Changeset [54141] by oliver@apple.com

2010-02-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Structure not accounting for anonymous slots when computing property storage size
https://bugs.webkit.org/show_bug.cgi?id=34441

Previously any Structure with anonymous storage would have a property map, so we
were only including anonymous slot size if there was a property map. Given this
is no longer the case we should always include the anonymous slot count in the
property storage size.

  • runtime/Structure.h: (JSC::Structure::propertyStorageSize):
10:59 Changeset [54140] by japhet@chromium.org

2010-02-01 Nate Chapin <japhet@chromium.org>

Rubber-stamped by David Levin.

Add myself to reviewer list.

  • Scripts/webkitpy/committers.py:
10:44 Changeset [54139] by pfeldman@chromium.org

2010-02-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Syntax highlighting in source view of
Resources pane stops half-way.

There were two problems here: (1) styles for html highlighter were not
added into the css file (they used to be injected manually in the
SourceFrame before). (2) 'Tag' needed to be lexer's state, not parser's.
Otherwise unbalanced quotes in the text nodes were matching too match
into the string tokens.

https://bugs.webkit.org/show_bug.cgi?id=34359

  • inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer.prototype._createLineDivs): (WebInspector.NativeTextViewer.prototype._lineHeight): (WebInspector.NativeTextViewer.prototype.initFontMetrics):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype.initFontMetrics): (WebInspector.TextEditor.prototype._registerShortcuts):
  • inspector/front-end/inspectorSyntaxHighlight.css:
10:40 WebKit Team edited by japhet@chromium.org
(diff)
10:35 Changeset [54138] by benm@google.com

ScriptCallFrame's do not get line numbers/source id's if the caller is unkown.
https://bugs.webkit.org/show_bug.cgi?id=34335

Reviewed by Darin Adler.

WebCore:

  • bindings/js/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed.

LayoutTests:

Update layout tests that did not have source and line number information for their console messages, as this information is now available to the ScriptCallFrame and thus can be passed to the inspector, for example.

  • fast/js/console-non-string-values-expected.txt: Add console line number/source.
  • userscripts/script-not-run-for-fragments-expected.txt: ditto.
  • userscripts/script-run-at-start-expected.txt: ditto.
  • platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed as platform workarounds no longer necessary.
  • platform/mac/inspector/console-log-before-inspector-open-expected.txt: ditto.
  • platform/win/inspector/console-log-before-inspector-open-expected.txt: ditto.
10:07 Changeset [54137] by krit@webkit.org

2010-02-01 Dirk Schulze <krit@webkit.org>

Reviewed by Simon Fraser.

Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750

These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.

No new tests. The new AffineTransformation code is tested by fast/canvas.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
  • platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
  • platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform):
  • platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix):
  • platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend): (WebCore::AffineTransform::toTransformationMatrix):
  • platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix):
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform):
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix):
08:22 Changeset [54136] by philn@webkit.org

2010-01-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] set playbin mute property depending on volume value
https://bugs.webkit.org/show_bug.cgi?id=31586

New API in MediaPlayer for mute control. 3 new methods are
introduced:

  • bool supportsMuting() const;
  • bool muted() const;
  • void setMuted(bool);

Platform MediaPlayer implementations can support it easily if the
underlying sound daemon/API supports muting (eg. not only setting
volume to 0) like PulseAudio for instance on Linux. At the moment
the only player supporting this new API is the
MediaPlayerPrivateGStreamer.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): (WebCore::HTMLMediaElement::mediaPlayerMuteChanged):
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::supportsMuting): (WebCore::NullMediaPlayerPrivate::setMuted): (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::muted): (WebCore::MediaPlayer::supportsMuting): (WebCore::MediaPlayer::setMuted): (WebCore::MediaPlayer::volumeChanged): (WebCore::MediaPlayer::muteChanged):
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerMuteChanged):
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsMuting): (WebCore::MediaPlayerPrivateInterface::setMuted):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::notifyMuteIdleCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedCallback): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::supportsMuting): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::muteChangedCallback): (WebCore::MediaPlayerPrivate::muteChanged): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

2010-01-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] set playbin mute property depending on volume value
https://bugs.webkit.org/show_bug.cgi?id=31586

New API in MediaPlayer for mute control

  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::volumeChanged): (WebKit::WebMediaPlayerClientImpl::muteChanged):
  • src/WebMediaPlayerClientImpl.h:
07:30 Changeset [54135] by ossy@webkit.org

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Platform dependent expected file added for test introduced in r53868,
because this test passes. Compared to png file and Mac expected file.

  • platform/qt/fast/lists/anonymous-items-expected.txt: Added.
07:03 Changeset [54134] by hausmann@webkit.org

[Qt] Build without SSL support is broken

Patch by Henry Haverinen <henry.haverinen@nokia.com> on 2010-02-01
Reviewed by Simon Hausmann.

Added missing #ifdefs for OpenSSL support and one null-pointer
check for the socket.

https://bugs.webkit.org/show_bug.cgi?id=34416

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:

(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::send):

06:05 Changeset [54133] by pfeldman@chromium.org

2010-02-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Fix rest of the NativeTextViewer (line numbers,
conditional breakpoints, selection).

05:58 QtWebKitBackportingFixes edited by andreas.kling@nokia.com
(diff)
05:54 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:11 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
04:43 QtWebKitBackportingFixes edited by kenneth@webkit.org
(diff)
02:50 Changeset [54132] by steveblock@google.com

Adds implementation of JavaString for V8.
https://bugs.webkit.org/show_bug.cgi?id=33953

Reviewed by Ariya Hidayat.

No new tests, build fix only.

  • bridge/jni/JNIBridge.h: Modified. Include JavaStringV8.h for V8
  • bridge/jni/v8: Added.
  • bridge/jni/v8/JavaStringV8.h: Added.

(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):

02:05 Changeset [54131] by oliver@apple.com

2010-02-01 Oliver Hunt <oliver@apple.com>

Windows build fix, update exports file (again)

01:56 Changeset [54130] by oliver@apple.com

2010-02-01 Oliver Hunt <oliver@apple.com>

Windows build fix, update exports file

01:43 Changeset [54129] by oliver@apple.com

2010-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321

Remove secondary Structure constructor, and make Structure store a copy
of the number of anonymous slots directly so saving an immediate allocation
of a property map for all structures with anonymous storage, which also
avoids the leaked property map on new property transition in the original
version of this patch.

We need to propagate the the anonymous slot count otherwise we can end up
with a structure recording incorrect information about the available and
needed space for property storage, or alternatively incorrectly reusing
some slots.

  • JavaScriptCore.exp:
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::copyPropertyTable): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable):
  • runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::hasAnonymousSlots): (JSC::Structure::anonymousSlotCount):

2010-02-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321

Add test case for modifying DOM objects with anonymous storage.

  • fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added.
  • fast/dom/Window/anonymous-slot-with-changes.html: Added.
01:27 Changeset [54128] by eric@webkit.org

2010-02-01 Alex Milowski <alex@milowski.com>

Reviewed by Darin Adler.

Added compile time debug support for mathml layout (block boundary & baseline)

  • mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::stretchToHeight): (WebCore::RenderMathMLBlock::paint):
  • mathml/RenderMathMLBlock.h:
00:50 Changeset [54127] by philn@webkit.org

2010-02-01 Philippe Normand <pnormand@igalia.com>

Rubber stamped by Xan Lopez.

Fixed compilation warning about unsigned vs signed comparison.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint):

01/31/10:

23:29 Applications using WebKit edited by wevah@derailer.org
Paparazzi! is a Universal Binary. Also dropped the "www." from its URL. (diff)
23:05 Changeset [54126] by cjerdonek@webkit.org

2010-01-31 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Moved style error handler code to their own classes, and
related refactoring. Increased unit test code coverage of
style error handling.

https://bugs.webkit.org/show_bug.cgi?id=34379

  • Scripts/check-webkit-style:
    • Minor change: added error_count variable.
  • Scripts/webkitpy/style/checker.py:
    • Renamed ProcessorOptions.should_report_error() to is_reportable().
    • In the StyleChecker class--
      • Removed _default_style_error_handler().
      • Added _increment_error_count().
      • Refactored to use DefaultStyleErrorHandler and PatchStyleErrorHandler constructors.
  • Scripts/webkitpy/style/checker_unittest.py:
    • In the StyleStyleCheckerTest class--
      • Removed write_sample_error().
      • Removed test_default_style_error_handler().
  • Scripts/webkitpy/style/error_handlers.py: Added.
    • Added DefaultStyleErrorHandler class.
    • Added PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/error_handlers_unittest.py: Added.
    • Added unit tests for DefaultStyleErrorHandler and PatchStyleErrorHandler.
  • Scripts/webkitpy/style/unittests.py:
    • Added error_handlers unit tests.
22:21 Changeset [54125] by tkent@chromium.org

2010-01-31 Kent Tamura <tkent@chromium.org>

Unreviewed. Revert r54112 and r54124 because of Windows build error.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/cairo/TransformationMatrixCairo.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/cg/TransformationMatrixCG.cpp:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp:
  • platform/graphics/haiku/PathHaiku.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/PathQt.cpp:
  • platform/graphics/qt/TransformationMatrixQt.cpp:
  • platform/graphics/skia/GraphicsContextSkia.cpp:
  • platform/graphics/skia/PathSkia.cpp:
  • platform/graphics/skia/TransformationMatrixSkia.cpp:
  • platform/graphics/transforms/AffineTransform.cpp: Removed.
  • platform/graphics/transforms/AffineTransform.h: Removed.
  • platform/graphics/wince/GraphicsContextWince.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
  • platform/graphics/wx/PathWx.cpp:
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::TransformationMatrix::operator wxGraphicsMatrix):
21:04 Changeset [54124] by tkent@chromium.org

Unreviewd. Windows build fix.

20:23 Changeset [54123] by eric@webkit.org

2010-01-31 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Buildfix for WinCE + style fixes (TLS_OUT_OF_INDEXES is not defined).
https://bugs.webkit.org/show_bug.cgi?id=34380

  • wtf/ThreadSpecific.h:
18:37 Changeset [54122] by eric@webkit.org

2010-01-31 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Limit the scope of packing alignment to avoid MSVC C4103 warning.
https://bugs.webkit.org/show_bug.cgi?id=34390

Use pack(push, 16) and pack(pop) to limit the scope of packing
alignment change.

  • bindings/js/JSSVGPODTypeWrapper.h:
18:33 Changeset [54121] by tkent@chromium.org

2010-01-31 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

[Windows] Fix a bug of round() with huge integral numbers
https://bugs.webkit.org/show_bug.cgi?id=34297

Fix a bug that round() for huge integral numbers returns incorrect
results. For example, round(8639999913600001) returns
8639999913600002 without this change though the double type can
represent 8639999913600001 precisely.

Math.round() of JavaScript has a similar problem. But this change
doesn't fix it because Math.round() doesn't use round() of
MathExtra.h.

  • wtf/MathExtras.h: (round): Avoid to do "num + 0.5" or "num - 0.5". (roundf): Fixed similarly. (llround): Calls round(). (llroundf): Calls roundf(). (lround): Calls round(). (lroundf): Calls roundf().

2010-01-31 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

[Win] Fix a bug of round() with huge integral numbers
https://bugs.webkit.org/show_bug.cgi?id=34297

Add a test case to call round(8639999913600001).

  • fast/forms/input-valueasnumber-datetime-expected.txt:
  • fast/forms/script-tests/input-valueasnumber-datetime.js:
17:56 Changeset [54120] by tkent@chromium.org

2010-01-31 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix valueAsNumber calculation for type=month.
https://bugs.webkit.org/show_bug.cgi?id=34304

valueAsNumber calculation for type=month which was checked in as
r53893 was the number of milliseconds since UNIX epoch, and it was
wrong. The correct way is the number months since UNIX epoch.

  • fast/forms/input-valueasnumber-month-expected.txt:
  • fast/forms/script-tests/input-valueasnumber-month.js:

2010-01-31 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix valueAsNumber calculation for type=month.
https://bugs.webkit.org/show_bug.cgi?id=34304

valueAsNumber calculation for type=month which was checked in as
r53893 was the number of milliseconds since UNIX epoch, and it was
wrong. The correct way is the number months since UNIX epoch.

  • html/DateComponents.cpp: (WebCore::DateComponents::setMonthsSinceEpoch): (WebCore::DateComponents::monthsSinceEpoch):
  • html/DateComponents.h: Declare setMonthsSinceEpoch() and monthsSinceEpoch().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): Switch to monthsSinceEpoch() for type=MONTH. (WebCore::HTMLInputElement::valueAsDate): Add code with millisecondsSinceEpoch() for MONTH because parseToDouble() changed its behavior. (WebCore::HTMLInputElement::setValueAsNumber): Use setMonthsSinceEpoch() for MONTH.
17:43 Changeset [54119] by tkent@chromium.org

2010-01-31 Kent Tamura <tkent@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Fix a bug that a selected word is not recognized as a
spell-check source.
https://bugs.webkit.org/show_bug.cgi?id=33660

  • src/ContextMenuClientImpl.cpp: (WebKit::isASingleWord): Use wordBreakIterator(), and correctly check the return value of textBreakNext().
17:42 Changeset [54118] by mitz@apple.com

Web Inspector: REGRESSION: Numbers in bubbles are vertically off-center
https://bugs.webkit.org/show_bug.cgi?id=34398

Reviewed by Timothy Hatcher.

  • inspector/front-end/inspector.css: Specify line-height: normal for

".console-message .bubble" and ".sidebar-tree-item .status .bubble".

16:54 Changeset [54117] by ojan@chromium.org

2010-01-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

Implement CSSOM Range.getClientRects for collapsed selections
https://bugs.webkit.org/show_bug.cgi?id=34239

Adds two cases to getClientRects test.

  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:

2010-01-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

Implement CSSOM Range.getClientRects for collapsed selections
https://bugs.webkit.org/show_bug.cgi?id=34239

When getting the quads for a range on a text node, allow returning
zero width quads. This leaves the case of collapsed selections inside
elements still not fixed, but no worse.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect):
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteQuadsForRange):
15:59 Changeset [54116] by mrowe@apple.com

Roll r54095 out again without making a mess of the ChangeLog.

15:59 Changeset [54115] by mrowe@apple.com

Revert r54114 since it made a mess of the ChangeLog.

15:43 Changeset [54114] by eric.carlson@apple.com

2010-01-31 Eric Carlson <eric.carlson@apple.com>

Revert r54095 because it caused many media tests to fail.

  • platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::GraphicsLayerCACF::setContentsToVideo): (WebCore::GraphicsLayerCACF::updateContentsVideo):
  • platform/graphics/win/GraphicsLayerCACF.h: (WebCore::GraphicsLayerCACF::):
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::task): (QTMovieWinPrivate::setSize):
15:01 Changeset [54113] by oliver@apple.com

2010-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Simon Fraser.

Animated scaling of background-image is too slow
https://bugs.webkit.org/show_bug.cgi?id=33808

Update checksum.

  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:

2010-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Simon Fraser.

Animated scaling of background-image is too slow
https://bugs.webkit.org/show_bug.cgi?id=33808

Implement a version of the RenderImage animated scaling optimisation
for background images. Due to the possibility of arbitrary transforms
being applied to containing elements we explicitly check the current
CTM of the context for scaling or rotation.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::~RenderBoxModelScaleData): (WebCore::RenderBoxModelScaleData::hiqhQualityRepaintTimer): (WebCore::RenderBoxModelScaleData::size): (WebCore::RenderBoxModelScaleData::setSize): (WebCore::RenderBoxModelScaleData::lastPaintTime): (WebCore::RenderBoxModelScaleData::setLastPaintTime): (WebCore::RenderBoxModelScaleData::useLowQualityScale): (WebCore::RenderBoxModelScaleData::transform): (WebCore::RenderBoxModelScaleData::setTransform): (WebCore::RenderBoxModelScaleData::setUseLowQualityScale): (WebCore::RenderBoxModelScaleObserver::boxModelObjectDestroyed): (WebCore::RenderBoxModelScaleObserver::highQualityRepaintTimerFired): (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality): (WebCore::RenderBoxModelObject::highQualityRepaintTimerFired): (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
13:04 Changeset [54112] by krit@webkit.org

2010-01-31 Dirk Schulze <krit@webkit.org>

Reviewed by Simon Fraser.

Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750

These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.

No new tests. The new AffineTransformation code is tested by fast/canvas.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
  • platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
  • platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform):
  • platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix):
  • platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend):
  • platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform):
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix):
09:55 Changeset [54111] by eric@webkit.org

2010-01-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [REGRESSION] Breakpoint source line is not displayed
in the breakpoint manager.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addBreakpointToSource):
08:36 Changeset [54110] by pfeldman@chromium.org

2010-01-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Introduce NativeTextViewer.

This change handles rendering highlighted text, using browser's
selection/drag/drop/click logic. Breakpoint decorations and
program counter is working.

Todo: line numbers are painted 'under' the text when scrolling
horizontally, search is not yet implemented.

https://bugs.webkit.org/show_bug.cgi?id=34391

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DivBasedTextViewer.js: Added. (WebInspector.DivBasedTextViewer): (WebInspector.DivBasedTextViewer.prototype._textChanged): (WebInspector.DivBasedTextViewer.prototype._createLineDivs): (WebInspector.DivBasedTextViewer.prototype._updatePreferredSize): (WebInspector.DivBasedTextViewer.prototype._scroll): (WebInspector.DivBasedTextViewer.prototype._registerMouseListeners): (WebInspector.DivBasedTextViewer.prototype._registerKeyboardListeners): (WebInspector.DivBasedTextViewer.prototype._registerClipboardListeners): (WebInspector.DivBasedTextViewer.prototype._paintSelection): (WebInspector.DivBasedTextViewer.prototype._positionDivDecoration): (WebInspector.DivBasedTextViewer.prototype._mouseDown): (WebInspector.DivBasedTextViewer.prototype._contextMenu): (WebInspector.DivBasedTextViewer.prototype._caretForMouseEvent): (WebInspector.DivBasedTextViewer.prototype._paintLine): (WebInspector.DivBasedTextViewer.prototype._createSpan):
  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.clearMessages): (WebInspector.SourceFrame.prototype.sizeToFitContentHeight): (WebInspector.SourceFrame.prototype._createEditorIfNeeded): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype.resize):
  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype.setDivDecoration): (WebInspector.TextEditor.prototype._registerMouseListeners): (WebInspector.TextEditor.prototype._registerKeyboardListeners): (WebInspector.TextEditor.prototype._registerClipboardListeners): (WebInspector.TextEditor.prototype.reveal): (WebInspector.TextEditor.prototype._textChanged): (WebInspector.TextEditor.prototype.revalidateDecorationsAndPaint): (WebInspector.TextEditor.prototype._updatePreferredSize): (WebInspector.TextEditor.prototype.resize): (WebInspector.TextEditor.prototype._paintLinesContinuation): (WebInspector.TextEditor.prototype._paintLine): (WebInspector.TextEditor.prototype._contextMenu): (WebInspector.TextEditor.prototype._caretForMouseEvent): (WebInspector.TextEditor.prototype._changeFont):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/textEditor.css:
07:42 Changeset [54109] by eric@webkit.org

2010-01-31 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Eric Seidel.

[Qt] Enable FAST_MOBILE_SCROLLING on Qt embedded platforms
https://bugs.webkit.org/show_bug.cgi?id=34168

Enable FAST_MOBILE_SCROLLING for Qt on Maemo 5, Linux embedded
and Symbian

  • WebCore.pro:

01/30/10:

23:38 Changeset [54108] by yurys@chromium.org

2010-01-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Make ScriptState destructor protected since all non-empty
ScriptStates are managed by GC. Remove obsolete constructor.

https://bugs.webkit.org/show_bug.cgi?id=34266

  • bindings/v8/ScriptState.cpp:
  • bindings/v8/ScriptState.h:
22:01 Changeset [54107] by simon.fraser@apple.com

2010-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Use CGGradient on Leopard and later, since it's faster than CGShading
https://bugs.webkit.org/show_bug.cgi?id=34384

Use CGGradient on Leopard and later, rather than CGShading, for
performance.

  • platform/graphics/Gradient.h:
  • platform/graphics/Gradient.cpp: (WebCore::Gradient::sortStopsIfNecessary): Utility method to sort stops. Did not call this from getColor() to avoid overhead of a function call.
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformDestroy): Use CGGradientRelease() post-Tiger. (WebCore::Gradient::platformGradient): Create and return a CGGradientRef post-Tiger. (WebCore::Gradient::fill): Call new paint() method. (WebCore::Gradient::paint): New convenence method that avoids testing isRadial() in a bunch of other places.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): Call the gradient's paint() method. (WebCore::GraphicsContext::strokePath): Ditto (WebCore::GraphicsContext::fillRect): Ditto (WebCore::GraphicsContext::strokeRect): Ditto
19:21 Changeset [54106] by simon.fraser@apple.com

2010-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson.

Do color animations on premultiplied colors
https://bugs.webkit.org/show_bug.cgi?id=34383

Convert colors to premultiplied alpha before interpolating them,
then convert the result back to non-premultiplied. This gives better
results when animating from transparent colors.

Test: transitions/color-transition-premultiplied.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
16:37 Changeset [54105] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Add a way to get the parse mode to wxWebKit API.

https://bugs.webkit.org/show_bug.cgi?id=34341

13:42 Changeset [54104] by kov@webkit.org

2010-01-30 Gustavo Noronha Silva <gns@gnome.org>

Build fixes needed for make distcheck.

  • GNUmakefile.am:

01/29/10:

21:37 Changeset [54103] by mrowe@apple.com

Stop copying an IDL file in to the framework wrapper.

  • WebCore.xcodeproj/project.pbxproj:
21:35 Changeset [54102] by mrowe@apple.com

Sort Xcode projects.

JavaScriptCore:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:
21:32 Changeset [54101] by mrowe@apple.com

Roll over a few oversized ChangeLogs.

21:30 Changeset [54100] by mrowe@apple.com

Roll out r54073 as it introduced many thousands of leaks.

21:21 Changeset [54099] by mrowe@apple.com

Fix run-leaks with newer versions of the leaks tool.

Rubber-stamped by Stephanie Lewis.

  • Scripts/run-leaks:
21:00 Changeset [54098] by mrowe@apple.com

Keep the Windows feature defines in sync with FeatureDefines.xcconfig.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
20:51 Changeset [54097] by mrowe@apple.com

Fix the Mac build.

Disable ENABLE_INDEXED_DATABASE since it is "completely non-functional".

As the comment in FeatureDefines.xcconfig notes, the list of feature defines
needs to be kept in sync across the various files. The default values also
need to be kept in sync between these files and build-webkit.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
19:04 Changeset [54096] by sfalken@apple.com

2010-01-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Timeout for client-based Geolocation shouldn't start until user gives consent
https://bugs.webkit.org/show_bug.cgi?id=34352

  • page/Geolocation.cpp: (WebCore::Geolocation::startRequest): Don't start timer if we're blocked on user consent. (WebCore::Geolocation::setIsAllowed): Start timer after user gives consent.
18:17 Changeset [54095] by cmarrin@apple.com

Fixed changed virtual function in GraphicsLayerCACF and call order issues
https://bugs.webkit.org/show_bug.cgi?id=34348


The correct virtual function in GraphicsLayerCACF is now being
called. We also fixed an issue in QTMovieWin where the size
of the movie was not being set correctly because the call order
was changed.

17:25 Changeset [54094] by dpranke@chromium.org

2010-01-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

Top-level test drivers for running the Chromium port of run-webkit-tests
and being able to rebaseline test results from the test bots. The
files in the Scripts directory are simply wrappers around the files
in webkitpy/layout_tests for convenience.


https://bugs.webkit.org/show_bug.cgi?id=31498

  • Scripts/rebaseline-chromium-webkit-tests: Added.
  • Scripts/run-chromium-webkit-tests: Added.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
17:17 Changeset [54093] by dpranke@chromium.org

2010-01-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

Add in the second block of python code for the Chromium port
of run-webkit-tests. These files execute different diffs to classify
the various types of failures from a test.

  • Scripts/webkitpy/layout_tests/test_types: Added.
  • Scripts/webkitpy/layout_tests/test_types/init.py: Added.
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
17:12 Changeset [54092] by mrowe@apple.com

Versioning.

17:06 Changeset [54091] by dpranke@chromium.org

2010-01-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

Check in the first part of the Chromium Python port of the
run-webkit-tests test driver. The files under
layout_tests/layout_layout constitute most of the implementation;
they can be roughly divided into code that parses the
"test_expectations.txt" file that describes how we expect tests to
pass or fail, platform-specific hooks for the different Chromium
ports (in platform_utils*), code for parsing the output of the
tests and generating results files and HTML and JSON for the
dashboards, auxiliary scripts for starting and stopping HTTP and
Web Socket servers, and then one of the actual driver files
(test_shell_thread). Code for actually parsing test output for
failures and the top-level driver scripts will follow shortly.

https://bugs.webkit.org/show_bug.cgi?id=31498

  • Scripts/webkitpy/layout_tests: Added.
  • Scripts/webkitpy/layout_tests/layout_package: Added.
  • Scripts/webkitpy/layout_tests/layout_package/init.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
    • scripts to start and stop apache. Note that the apache file generates a conf file dynamically, and we should switch to using the same static conf file that the regular run-webkit-tests uses, and we can also use the same httpd2.pem file.
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
    • scripts to generate the JSON layout test dashboard and the flakiness dashboard
  • Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
    • default configuration for LigHTTPd (used on Windows)
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
    • utility class that implements progress bars on the console to be displayed while the tests are running
  • Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
    • various routines for manipulating paths and URIs
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
    • platform-specific aspects of the drivers (binary names, paths, process control, etc.)
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
    • code for parsing the 'test_expectations.txt' file to determine which tests are expected to fail (and how) on which platforms
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
    • code for handling different kinds of failures (generating output in the results, etc.)
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
    • code to gather the lists of tests
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
    • code to actually execute tests via TestShell and process the output
  • Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
    • scripts to start and stop the pywebsocket server
16:59 Changeset [54090] by bweinstein@apple.com

Roll out r54088 because the functions were already in
IWebPreferencesPrivate, so they should stay there.

16:48 Changeset [54089] by jpetsovits@rim.com

2010-01-29 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Nikolas Zimmermann.

[OpenVG] Implement more graphics primitives
https://bugs.webkit.org/show_bug.cgi?id=34339

Adds lines, arcs, ellipses, polygons and rounded
rectangles to PainterOpenVG and GraphicsContext.

Rounded rects support by Eli Fidler <efidler@rim.com>.

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::drawRect): (WebCore::PainterOpenVG::drawRoundedRect): (WebCore::PainterOpenVG::drawLine): (WebCore::PainterOpenVG::drawArc): (WebCore::PainterOpenVG::drawEllipse): (WebCore::PainterOpenVG::drawPolygon):
  • platform/graphics/openvg/PainterOpenVG.h:
16:48 Changeset [54088] by bweinstein@apple.com

Rubber-stamped by Adam Roben.

Move customDragCursorEnabled preference functions from
IWebPreferences to IWebPreferencesPrivate.

  • Interfaces/IWebPreferences.idl: Moved customDragFunctions from here...
  • Interfaces/IWebPreferencesPrivate.idl: To here.
  • Interfaces/WebKit.idl: Touched to make sure we rebuild.
16:34 Changeset [54087] by dpranke@chromium.org

2010-01-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Check in a copy of the simplejson library; it will be used by
the Chromium port of run-webkit-tests.


https://bugs.webkit.org/show_bug.cgi?id=31498

  • simplejson: Added.
  • simplejson/LICENSE.txt: Added.
  • simplejson/README.txt: Added.
  • simplejson/init.py: Added.
  • simplejson/_speedups.c: Added. (ascii_escape_char): (ascii_escape_unicode): (ascii_escape_str): (py_encode_basestring_ascii): (init_speedups):
  • simplejson/decoder.py: Added.
  • simplejson/encoder.py: Added.
  • simplejson/jsonfilter.py: Added.
  • simplejson/scanner.py: Added.
16:27 Changeset [54086] by dpranke@chromium.org

2010-01-29 Dirk Pranke <dpranke@chromium.org>

No review

Add myself to the committers list

  • Scripts/webkitpy/committers.py:
16:18 Changeset [54085] by jorlow@chromium.org

2010-01-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

A first step towards the Indexed Database API
https://bugs.webkit.org/show_bug.cgi?id=34342

Add runtime enable support for Indexed Database API.

  • features.gypi:
  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableIndexedDatabase): (WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):

2010-01-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

A first step towards the Indexed Database API
https://bugs.webkit.org/show_bug.cgi?id=34342

Flesh out the first part of Indexed Database API.
Currently only compiles with v8 + chromium for now.
Completely non-functional, but it seems best to do
this in chunks.

No tests because nothing works yet.

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/RuntimeEnabledFeatures.cpp:
  • bindings/v8/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setIndexedDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::indexedDatabaseEnabled):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::IndexedDBEnabled):
  • bindings/v8/custom/V8IDBRequestCustom.cpp: Added. (WebCore::V8IDBRequest::resultAccessorGetter):
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: Added. (WebCore::V8IndexedDatabaseRequest::openCallback):
  • dom/EventNames.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::indexedDB):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/IDBDatabaseError.h: Added. (WebCore::IDBDatabaseError::create): (WebCore::IDBDatabaseError::~IDBDatabaseError): (WebCore::IDBDatabaseError::code): (WebCore::IDBDatabaseError::setCode): (WebCore::IDBDatabaseError::message): (WebCore::IDBDatabaseError::setMessage): (WebCore::IDBDatabaseError::IDBDatabaseError):
  • storage/IDBDatabaseError.idl: Added.
  • storage/IDBDatabaseException.h: Added. (WebCore::IDBDatabaseException::create): (WebCore::IDBDatabaseException::~IDBDatabaseException): (WebCore::IDBDatabaseException::code): (WebCore::IDBDatabaseException::setCode): (WebCore::IDBDatabaseException::message): (WebCore::IDBDatabaseException::setMessage): (WebCore::IDBDatabaseException::IDBDatabaseException):
  • storage/IDBDatabaseException.idl: Added.
  • storage/IDBRequest.cpp: Added. (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::eventTargetData): (WebCore::IDBRequest::ensureEventTargetData):
  • storage/IDBRequest.h: Added. (WebCore::IDBRequest::create): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::error): (WebCore::IDBRequest::result): (WebCore::IDBRequest::scriptExecutionContext): (WebCore::IDBRequest::toIDBRequest): (WebCore::IDBRequest::refEventTarget): (WebCore::IDBRequest::derefEventTarget):
  • storage/IDBRequest.idl: Added.
  • storage/IndexedDatabaseRequest.cpp: Added. (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::~IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h: Added. (WebCore::IndexedDatabaseRequest::create): (WebCore::IndexedDatabaseRequest::request):
  • storage/IndexedDatabaseRequest.idl: Added.

2010-01-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

A first step towards the Indexed Database API
https://bugs.webkit.org/show_bug.cgi?id=34342

Add Indexed Database API

  • configure.ac:

2010-01-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

A first step towards the Indexed Database API
https://bugs.webkit.org/show_bug.cgi?id=34342

Add indexed database API.

  • Scripts/build-webkit:
16:00 Changeset [54084] by abecsi@webkit.org

Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
This fixes a regression introduced in r53559.

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=34336

  • Scripts/webkitperl/httpd.pm:
16:00 Changeset [54083] by bweinstein@apple.com

WebCore: Drag and Drop: Windows uses "stop" sign as cursor when dragging
https://bugs.webkit.org/show_bug.cgi?id=34305
<rdar://problem/7589672>

Reviewed by Adam Roben.

Add a FIXME for the code that needs to be changed to support full
custom cursors.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag):

WebKit/win: Drag and Drop: Windows uses "stop" sign as cursor when dragging
https://bugs.webkit.org/show_bug.cgi?id=34305
<rdar://problem/7589672>

Reviewed by Adam Roben.

Add a preference in WebKit (that defaults to false), for whether or not
we should show the custom cursors during drag and drop. However, this is
currently only used on Windows, and only used to hide the "drop not allowed"
icon inside the WebView is the preference is set to true.

This will be off by default, so no change in behavior.

  • Interfaces/IWebPreferencesPrivate.idl: Added new functions.
  • Interfaces/WebKit.idl: Touched to force Interfaces build.
  • WebDropSource.cpp:

(WebDropSource::GiveFeedback): Implementation of conditional showing cursor

logic.

  • WebPreferenceKeysPrivate.h: Added new preference key.
  • WebPreferences.cpp: Added new functions.

(WebPreferences::setCustomDragCursorsEnabled):
(WebPreferences::customDragCursorsEnabled):

  • WebPreferences.h: Added new functions.
15:39 Changeset [54082] by victorw@chromium.org
14:26 Changeset [54081] by ap@apple.com

Reviewed by Dan Bernstein.

<rdar://problem/7441982> REGRESSION (TOT): Adobe CS4: Installer alerts are displayed as
blank windows

We probably shouldn't be deferring loads below modal dialogs and alerts, because that's not
what being modal means. But making such a change for general Web content would require fixes
in other parts of code, which I'm not ready to implement right now, so making it application
specific.

WebCore:

  • page/Page.cpp: (WebCore::Page::setDefersLoading): Do nothing if load deferring is not enabled in page settings.
  • WebCore.base.exp:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setLoadDeferringEnabled):
  • page/Settings.h: (WebCore::Settings::loadDeferringEnabled): Add the ability for client to disable page deferring (still enabled by default).
  • platform/mac/RuntimeApplicationChecks.h:
  • platform/mac/RuntimeApplicationChecks.mm: (WebCore::applicationIsAdobeInstaller): Added a bundle ID test for Adobe installer.

WebKit/mac:

  • WebView/WebView.mm: (shouldEnableLoadDeferring): Load deferring is enabled unless the application is Adobe Installer. (-[WebView _preferencesChangedNotification:]): Call setLoadDeferringEnabled().
14:16 Changeset [54080] by sfalken@apple.com

Build fix.

  • page/Geolocation.cpp:

(WebCore::Geolocation::startUpdating):

14:08 Changeset [54079] by sfalken@apple.com

2010-01-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Client-based Geolocation starts updating before getting consent from the user
https://bugs.webkit.org/show_bug.cgi?id=34343

  • page/Geolocation.cpp: (WebCore::Geolocation::startRequest): Pass notifier instead of options to startUpdating. (WebCore::Geolocation::setIsAllowed): Add the observer or notify of error for deferred startUpdating. (WebCore::Geolocation::startUpdating): Pass notifier instead of options, since we may need to call it if we fail to get user consent. Defer adding the observer if we don't yet have user consent, since this could kick off server-based wifi Geolocation requests.
  • page/Geolocation.h:
13:55 Changeset [54078] by jhoneycutt@apple.com

MSAA: Crash when posting a notification for a detached object

https://bugs.webkit.org/show_bug.cgi?id=34309
<rdar://problem/7409759>

Reviewed by Darin Adler.

WebCore:

Test: platform/win/accessibility/detached-object-notification-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(AccessibilityRenderObject::document):
Null check m_renderer. This is the bug fix; the other changes in the
patch are for the test.

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification):
Map AXValueChanged to EVENT_OBJECT_VALUECHANGED, so we'll post a
notification when AXValueChanged is posted. Receiving an event of this
type tells us that the test passed.

WebKit/win:

  • AccessibleBase.cpp:

(AccessibleBase::QueryService):
If an unrecognized service ID is passed, return early. Otherwise, return
the result of QueryInterface.
(AccessibleBase::QueryInterface):
Add static_casts. Check for new UUIDs.
(AccessibleBase::isSameObject):
Query the object for AccessibleBase. Return whether the pointers or the
wrapped objects match.

  • AccessibleBase.h:

Give the class a UUID so we can query for it in isSameObject(). Inherit
from IAccessibleComparable; inherit from IServiceProvider so clients can
use QueryService to query for a custom interface.

  • Interfaces/AccessibleComparable.idl: Added. Declares a function that

can be called to compare to accessible objects.

  • Interfaces/WebKit.idl:

Include the new IDL.

  • WebKit.vcproj/Interfaces.vcproj:

Add the new IDL to the project.

WebKitTools:

  • DumpRenderTree/AccessibilityController.h:

Declare new functions. Add new members to store the event hook and the
mapping of accessibility elements to their JS callbacks.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::notificationReceived):
Stubbed.
(AccessibilityController::addNotificationListener):
Stubbed.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::notificationReceived):
Stubbed.
(AccessibilityController::addNotificationListener):
Stubbed.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
Initialize the event hook.
(AccessibilityController::~AccessibilityController):
Remove the event hook. Unprotect all of the JS functions that are stored
in the map.
(logEventProc):
Clean-up a variable.
(stringEvent):
Return a string description of the MSAA event code.
(notificationListenerProc):
Get the accessible object from the event, and query it for IAccessible.
Call the AccessibilityController's notificationReceived().
(comparableObject):
Use QueryService to obtain the IAccessibleComparable for the
IServiceProvider.
(AccessibilityController::notificationReceived):
Iterate the map of objects that have registered for notification
callbacks. Query each for IServiceProvider, then use comparableObject()
to get an IAccessibleComparable. If we find an object matching the
notified object, call its callback, passing the event that was received.
(AccessibilityController::addNotificationListener):
If we have not created the event hook, create it. Protect the JS
callback function object, and add the object and its callback to our
map.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::addNotificationListener):
Call through to the AccessibilityController's addNotificationListener().

  • DumpRenderTree/win/DumpRenderTreeWin.h:

Add an extern declaration for the shared FrameLoadDelegate extern, so we
can access it from AccessibilityController.

  • DumpRenderTree/win/FrameLoadDelegate.h:

(FrameLoadDelegate::accessibilityController):
Return the AccessibilityController.

LayoutTests:

  • platform/win/accessibility/detached-object-notification-crash-expected.txt: Added.
  • platform/win/accessibility/detached-object-notification-crash.html: Added.
13:32 Changeset [54077] by kenneth@webkit.org

Rubberstamped by Simon Hausmann.

[Qt] Separate implementation from class definition.

  • QtLauncher/main.cpp:

(LauncherWindow::webView):
(LauncherWindow::LauncherWindow):
(LauncherWindow::~LauncherWindow):
(LauncherWindow::keyPressEvent):
(LauncherWindow::grabZoomKeys):
(LauncherWindow::sendTouchEvent):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::loadFinished):
(LauncherWindow::showLinkHover):
(LauncherWindow::zoomIn):
(LauncherWindow::zoomOut):
(LauncherWindow::resetZoom):
(LauncherWindow::toggleZoomTextOnly):
(LauncherWindow::print):
(LauncherWindow::screenshot):
(LauncherWindow::setEditable):
(LauncherWindow::dumpHtml):
(LauncherWindow::selectElements):
(LauncherWindow::setTouchMocking):
(LauncherWindow::newWindow):
(LauncherWindow::setupUI):

13:12 Changeset [54076] by eric@webkit.org

2010-01-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

prepare-ChangeLog outputs useless messages for a nonexistent bug ID
https://bugs.webkit.org/show_bug.cgi?id=34313

  • Scripts/prepare-ChangeLog:
12:21 Changeset [54075] by darin@chromium.org

2010-01-29 Darin Fisher <darin@chromium.org>

Okayed by Oliver Hunt.

Rollout r53949, r53951 and r54013 due to a Chromium regression that it
causes. Somehow this code change is triggering an endless repaint loop.

https://bugs.webkit.org/show_bug.cgi?id=33808

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderBoxModelObject.h:
11:47 Changeset [54074] by kenneth@webkit.org

[Qt] On Maemo5, a click/touch in the location bar (when unfocused)
should result in all text selected.

Reviewed by Ariya Hidayat.

  • QtLauncher/locationedit.cpp:

(LocationEdit::focusInEvent):

  • QtLauncher/locationedit.h:
11:46 Changeset [54073] by oliver@apple.com

2010-01-29 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321

Remove the unsafe two argument Structure::create method, and correct
the uses of it to propagate the anonymous slot count.

  • runtime/JSObject.h: (JSC::JSObject::setStructure):
  • runtime/Structure.cpp: (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition):
  • runtime/Structure.h:

2010-01-29 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321

Add a test for modification of a type with anonymous slots.

  • fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added.
  • fast/dom/Window/anonymous-slot-with-changes.html: Added.

2010-01-29 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321

Make code generator add assertions for anonymous slot count.

Test: fast/dom/Window/anonymous-slot-with-changes.html

  • bindings/scripts/CodeGeneratorJS.pm:
11:46 Changeset [54072] by kenneth@webkit.org

[Qt] Show progress reaching 100% for loads.

Reviewed by Ariya Hidayat.

  • QtLauncher/locationedit.cpp:

(LocationEdit::LocationEdit):
(LocationEdit::setProgress):
(LocationEdit::reset):
(LocationEdit::paintEvent):

  • QtLauncher/locationedit.h:
10:32 Changeset [54071] by eric@webkit.org

2010-01-29 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Add gdb helper methods for Ranges like we have for VisibleSelections.
https://bugs.webkit.org/show_bug.cgi?id=34308

No new tests, these are only for debugging.

  • dom/Position.cpp: (WebCore::Position::showTreeForThis):
  • dom/Range.cpp: (showTree):
  • dom/Range.h:
10:13 Changeset [54070] by eric@webkit.org

2010-01-29 Drew Wilson <atwilson@chromium.org>

Reviewed by Adam Barth.

V8 implementation of MessageEvent.initMessageEvent() does not set source correctly.
https://bugs.webkit.org/show_bug.cgi?id=34292

Test: fast/events/init-events.html will pass in Chrome now.

  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback): Now properly extracts the reference to the DOMWindow object from the passed-in window parameter.
09:56 Changeset [54069] by eric@webkit.org

2010-01-29 Ben Murdoch <benm@google.com>

Reviewed by Dimitri Glazkov.

[Android] Android needs functionality in the ChromeClient to be informed when touch events are and are not needed by the webpage.
https://bugs.webkit.org/show_bug.cgi?id=34215

Add a function on the ChromeClient that WebCore can use to inform the platform when it needs touch events. This way the platform can optimise by not forwarding the events if they are not required.

No new tests as the only implementation is specific to Android.

  • dom/Document.cpp: (WebCore::Document::detach): Check if this is the top level document and if so, stop forwarding touch events. (WebCore::Document::addListenerTypeIfNeeded): Inform the ChromeClient it should start forwarding touch events and guard touch event code properly.
  • history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): If the document uses touch events, inform the ChromeClient to start forwarding them. (WebCore::CachedFrame::CachedFrame): If the document uses touch events, inform the ChromeClient to stop forwarding them, as the document is being put into the page cache.
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::needTouchEvents): Add an empty implementation.
  • page/ChromeClient.h: Add the needTouchEvents() function.

2010-01-29 Ben Murdoch <benm@google.com>

Reviewed by Dimitri Glazkov.

[Android] Android needs functionality in the ChromeClient to be informed when touch events are and are not needed by the webpage.
https://bugs.webkit.org/show_bug.cgi?id=34215

Add needTouchEvents() to the ChromeClient which is called when the page decides it needs or no longer needs to be informed of touch events.

  • WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::needTouchEvents): Add an empty implementation.
09:38 Changeset [54068] by eric@webkit.org

2010-01-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix toolbar gradient to match the window's titlebar on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=34320

  • inspector/front-end/inspector.css:
09:22 Changeset [54067] by eric@webkit.org

2010-01-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix MacOS X version detection

MacOS X version can have 2 or 3 segments.
https://bugs.webkit.org/show_bug.cgi?id=34322

  • inspector/front-end/inspector.js: (WebInspector._detectPlatform):
09:06 Changeset [54066] by eric@webkit.org

2010-01-29 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable the QtLauncher statusbar on Maemo

https://bugs.webkit.org/show_bug.cgi?id=34330

  • QtLauncher/main.cpp: (LauncherWindow::showLinkHover): (LauncherWindow::selectElements):
08:49 Changeset [54065] by eric@webkit.org

2010-01-29 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Display page loading progress inside the QtLauncher location bar

https://bugs.webkit.org/show_bug.cgi?id=34210

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/locationedit.cpp: Added. (LocationEdit::LocationEdit): (LocationEdit::setProgress): (LocationEdit::paintEvent):
  • QtLauncher/locationedit.h: Added.
  • QtLauncher/mainwindow.cpp: (MainWindow::buildUI):
  • QtLauncher/mainwindow.h:
08:25 Changeset [54064] by kenneth@webkit.org

Disable auto-uppercase and predictive text on Maemo5, just like the
build-in MicroB Browser.

Reviewed by Simon Hausmann

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

07:43 Changeset [54063] by jpetsovits@rim.com

2010-01-29 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Nikolas Zimmermann.

[OpenVG] Implement a basic GraphicsContext on top of a new PainterOpenVG class
https://bugs.webkit.org/show_bug.cgi?id=33405

PainterOpenVG provides painter state management that works
on a single (EGL) context, and apart from painter state
implements a single drawing operation (for now), drawRect().

It is a generic painter class that cooperates with
SurfaceOpenVG to enable robust surface/context switching
(given that EGL doesn't notify us if somebody switches
the surface/context behind our backs), and provides
painting operations close to OpenVG's way of working
that GraphicsContext, Path, Image, Font and other WebKit
platform classes can use to draw on.

Initial code for state management and OpenVG scissoring by
Eli Fidler <efidler@rim.com>. VGRect/VGMatrix and the bulk
of the transformations code by Adam Treat <atreat@rim.com>.
Preliminary drawFocusRing() implementation by Yong Li <yoli@rim.com>.

  • platform/graphics/FloatRect.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: Added. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineDash): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformShouldAntialias): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::imageInterpolationQuality):
  • platform/graphics/openvg/PainterOpenVG.cpp: Added. (WebCore::isNonRotatedAffineTransformation): (WebCore::toVGCapStyle): (WebCore::toVGJoinStyle): (WebCore::toVGFillRule): (WebCore::colorToVGColor): (WebCore::setVGSolidColor): (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::copyPaintState): (WebCore::PlatformPainterState::applyState): (WebCore::PlatformPainterState::applyBlending): (WebCore::PlatformPainterState::applyTransformationMatrix): (WebCore::PlatformPainterState::applyScissorRect): (WebCore::PlatformPainterState::applyStrokeStyle): (WebCore::PlatformPainterState::strokeDisabled): (WebCore::PlatformPainterState::fillDisabled): (WebCore::PainterOpenVG::PainterOpenVG): (WebCore::PainterOpenVG::~PainterOpenVG): (WebCore::PainterOpenVG::begin): (WebCore::PainterOpenVG::end): (WebCore::PainterOpenVG::destroyPainterStates): (WebCore::PainterOpenVG::applyState): (WebCore::PainterOpenVG::blitToSurface): (WebCore::PainterOpenVG::transformationMatrix): (WebCore::PainterOpenVG::concatTransformationMatrix): (WebCore::PainterOpenVG::setTransformationMatrix): (WebCore::PainterOpenVG::compositeOperation): (WebCore::PainterOpenVG::setCompositeOperation): (WebCore::PainterOpenVG::opacity): (WebCore::PainterOpenVG::setOpacity): (WebCore::PainterOpenVG::strokeThickness): (WebCore::PainterOpenVG::setStrokeThickness): (WebCore::PainterOpenVG::strokeStyle): (WebCore::PainterOpenVG::setStrokeStyle): (WebCore::PainterOpenVG::setLineDash): (WebCore::PainterOpenVG::setLineCap): (WebCore::PainterOpenVG::setLineJoin): (WebCore::PainterOpenVG::setMiterLimit): (WebCore::PainterOpenVG::strokeColor): (WebCore::PainterOpenVG::setStrokeColor): (WebCore::PainterOpenVG::fillColor): (WebCore::PainterOpenVG::setFillColor): (WebCore::PainterOpenVG::antialiasingEnabled): (WebCore::PainterOpenVG::setAntialiasingEnabled): (WebCore::PainterOpenVG::scale): (WebCore::PainterOpenVG::rotate): (WebCore::PainterOpenVG::translate): (WebCore::PainterOpenVG::intersectScissorRect): (WebCore::PainterOpenVG::intersectClipRect): (WebCore::PainterOpenVG::drawRect): (WebCore::PainterOpenVG::save): (WebCore::PainterOpenVG::restore):
  • platform/graphics/openvg/PainterOpenVG.h: Added. (WebCore::PainterOpenVG::): (WebCore::PainterOpenVG::surface):
  • platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::SurfaceOpenVG): (WebCore::SurfaceOpenVG::~SurfaceOpenVG): (WebCore::SurfaceOpenVG::makeCurrent): (WebCore::SurfaceOpenVG::makeCompatibleCurrent): (WebCore::SurfaceOpenVG::setActivePainter): (WebCore::SurfaceOpenVG::activePainter):
  • platform/graphics/openvg/SurfaceOpenVG.h: (WebCore::SurfaceOpenVG::):
  • platform/graphics/openvg/VGUtils.cpp: Added. (WebCore::VGMatrix::VGMatrix): (WebCore::VGMatrix::operator TransformationMatrix): (WebCore::TransformationMatrix::operator VGMatrix): (WebCore::VGRect::VGRect): (WebCore::VGRect::operator FloatRect): (WebCore::FloatRect::operator VGRect):
  • platform/graphics/openvg/VGUtils.h: (WebCore::VGMatrix::toVGfloat): (WebCore::VGRect::toVGfloat):
  • platform/graphics/transforms/TransformationMatrix.h:
07:42 Changeset [54062] by philn@webkit.org

2010-01-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, build fix.

http/tests/media/video-referer.html fails on mac
https://bugs.webkit.org/show_bug.cgi?id=34331

Skipping the failing test. Requires further investigation.

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
07:04 Changeset [54061] by philn@webkit.org

2010-01-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Vimeo HTML5 player doesn't work
https://bugs.webkit.org/show_bug.cgi?id=34327

Send Referer when requesting media over HTTP.

Test: http/tests/media/video-referer.html

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):

2010-01-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Vimeo HTML5 player doesn't work
https://bugs.webkit.org/show_bug.cgi?id=34327

Test for HTTP Referer checking when playing remote media.

  • http/tests/media/resources/setCookieAndReferer.cgi: Added.
  • http/tests/media/resources/video-referer-check-referer.php: Added.
  • http/tests/media/video-referer-expected.txt: Added.
  • http/tests/media/video-referer.html: Added.
06:33 Changeset [54060] by hausmann@webkit.org

[Qt] Speed up the WebCore::String -> QString conversion

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-01-29
Reviewed by Simon Hausmann.

Use QString(const QChar *, int len) constructor instead of QString::fromUtf16 to
avoid BOM checks and byteswapping.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fieldNamed):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

06:10 Changeset [54059] by pfeldman@chromium.org

2010-01-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Source view displays text using wrong fonts
https://bugs.webkit.org/show_bug.cgi?id=34269

  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor): (WebInspector.TextEditor.prototype._initFont):
  • inspector/front-end/inspector.js:
06:01 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
06:00 Changeset [54058] by eric@webkit.org

2010-01-29 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add support for Maemo zoom keys in QtLauncher

https://bugs.webkit.org/show_bug.cgi?id=34160

  • QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::~LauncherWindow): (LauncherWindow::keyPressEvent): (LauncherWindow::grabZoomKeys):
05:48 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:46 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:41 Changeset [54057] by yurys@chromium.org

2010-01-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Add API methods for loading inspector utility scripts.

https://bugs.webkit.org/show_bug.cgi?id=34326

  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::injectedScriptSource): (WebKit::WebDevToolsAgentClient::injectedScriptDispatcherSource):
05:36 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:32 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:29 Changeset [54056] by eric@webkit.org

2010-01-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Apple trailers don't play anymore
https://bugs.webkit.org/show_bug.cgi?id=34316

Fake QuickTime when accessing movie trailers.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
05:02 Changeset [54055] by abecsi@webkit.org

Unreviewed.

[Qt] Remove disabled tests from Skiplist. The tests were disabled in r53701.

  • platform/qt/Skipped: -css2.1/t1204-increment-00-c-o.html -css2.1/t1204-increment-01-c-o.html -css2.1/t1204-increment-02-c-o.html -css2.1/t1204-reset-00-c-o.html -css2.1/t1204-reset-01-c-o.html -css2.1/t1204-reset-02-c-o.html
04:17 Changeset [54054] by eric@webkit.org

2010-01-29 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement the display() method of the layout test controller
https://bugs.webkit.org/show_bug.cgi?id=34258

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::showPage): (WebCore::DumpRenderTree::hidePage):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::display):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
03:04 Changeset [54053] by pfeldman@chromium.org

2010-01-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: migrate to tokenizer-based highlighting in the Elements panel.

https://bugs.webkit.org/show_bug.cgi?id=34273

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CSSSourceSyntaxHighlighter.js: Removed.
  • inspector/front-end/DOMSyntaxHighlighter.js: Added. (WebInspector.DOMSyntaxHighlighter): (WebInspector.DOMSyntaxHighlighter.prototype.createSpan): (WebInspector.DOMSyntaxHighlighter.prototype.syntaxHighlightNode):
  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: Removed.
  • inspector/front-end/SourceCSSTokenizer.js: (WebInspector.SourceCSSTokenizer): (WebInspector.SourceCSSTokenizer.prototype.nextToken):
  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceJavaScriptTokenizer.js: (WebInspector.SourceJavaScriptTokenizer): (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/SourceSyntaxHighlighter.js: Removed.
  • inspector/front-end/SourceTokenizer.js: Added. (WebInspector.SourceTokenizer): (WebInspector.SourceTokenizer.prototype.set line): (WebInspector.SourceTokenizer.prototype.set condition): (WebInspector.SourceTokenizer.prototype.get condition): (WebInspector.SourceTokenizer.prototype.hasCondition): (WebInspector.SourceTokenizer.prototype.getLexCondition): (WebInspector.SourceTokenizer.prototype.setLexCondition): (WebInspector.SourceTokenizer.prototype._charAt): (WebInspector.SourceTokenizer.Registry): (WebInspector.SourceTokenizer.Registry.getInstance): (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set mimeType):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html: LayoutTests:
  • inspector/syntax-highlight-css-expected.txt:
  • inspector/syntax-highlight-css.html:
  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight-javascript.html:
  • inspector/syntax-highlight.js: (frontend_dumpSyntaxHighlight):
03:02 QtWebKitBackportingFixes edited by andreas.kling@nokia.com
(diff)
02:38 Changeset [54052] by pfeldman@chromium.org

2010-01-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: No need to render background sources
when performing search.

https://bugs.webkit.org/show_bug.cgi?id=34263

01:41 Changeset [54051] by yurys@chromium.org

2010-01-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Remove ScriptState::frame which is only used for reporting exceptions
in some cases in a way that diverges from the regular exception reporting in
v8 bindings.

Cache ScriptState directly on v8::Context instead of providing
implementations specific for isolated worlds and ScriptController.

https://bugs.webkit.org/show_bug.cgi?id=34266

  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptState.cpp: (WebCore::mainWorldScriptState):
  • bindings/js/ScriptState.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): (WebCore::ScriptController::clearWindowShell):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success):
  • bindings/v8/ScriptScope.h:
  • bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::forContext): (WebCore::ScriptState::current): (WebCore::ScriptState::weakReferenceCallback): (WebCore::mainWorldScriptState): (WebCore::scriptStateFromPage):
  • bindings/v8/ScriptState.h: (WebCore::ScriptState::ScriptState): (WebCore::EmptyScriptState::EmptyScriptState): (WebCore::EmptyScriptState::~EmptyScriptState):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/V8IsolatedContext.cpp:
  • bindings/v8/V8IsolatedContext.h:
  • bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId):
01:23 Changeset [54050] by hausmann@webkit.org

Rubber-stamped by Maciej Stachowiak.

Fix the ARM build.

  • runtime/JSNumberCell.h:

(JSC::JSNumberCell::createStructure): Call the right Structure::create overload.

00:43 Changeset [54049] by darin@chromium.org

2010-01-29 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

Add FrameLoaderClient::allowImages method to allow the client to
overrule image loading policy on a per frame basis.

https://bugs.webkit.org/show_bug.cgi?id=34225

For completeness, this patch also adds Settings::areImagesEnabled.
This is different from loadsImagesAutomatically as is explained in
Settings.h.

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestImage):
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::allowImages):
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::writeRawData):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setImagesEnabled):
  • page/Settings.h: (WebCore::Settings::areImagesEnabled):
Note: See TracTimeline for information about the timeline view.