Timeline


and

02/05/10:

22:32 Changeset [54463] by ap@apple.com

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=34670
TestNetscapePlugin should work with Firefox

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if browser doesn't tell what it supports.
22:17 Changeset [54462] by mjs@apple.com

JavaScriptCore: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Configurations/FeatureDefines.xcconfig:

WebCore: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Scripts/build-webkit:
21:37 Changeset [54461] by hamaji@chromium.org

2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Gustavo Noronha Silva.

[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572

  • platform/gtk/Skipped:

2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Gustavo Noronha Silva.

[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_page_number_for_element_by_id):

2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Gustavo Noronha Silva.

[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageNumberForElementById):
20:25 Changeset [54460] by ggaren@apple.com

Added an ASSERT to catch an implausible but theoretically possible leak.

Reviewed by Dan Bernstein.

In theory, if malloc allocated a UChar buffer directly after a StringImpl,
the StringImpl might incorrecly assume that the UChar buffer was inline,
and fail to delete it.

This ASSERT is somewhat academic, since we don't use the same allocator
in debug builds, but oh well.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::createUninitialized):

  • platform/text/StringImpl.h: Separated the inline buffer StringImpl

constructor from the out-of-line buffer StringImpl constructor. Made
the former ASSERT that its buffer was indeed inline, and the latter ASSERT
that its buffer was indeed not inline.

18:50 Changeset [54459] by ggaren@apple.com

Removed these special Windows expected results because they represented
incorrect behavior, fixed by a recent patch of mine.

Reviewed by Beth Dakin.

  • platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Removed.
18:44 Changeset [54458] by eric@webkit.org

2010-02-05 James Hawkins <jhawkins@chromium.org>

Reviewed by David Levin.

[Chromium] Rename autocomplete* to suggestions* to prepare for the
refactoring of AutocompletePopupMenuClient.

https://bugs.webkit.org/show_bug.cgi?id=34664

  • public/WebView.h:
  • src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::popupDidHide):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::doAutofill):
  • src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutofillSuggestions): (WebKit::WebViewImpl::hideAutofillPopup): (WebKit::WebViewImpl::hideSuggestionsPopup): (WebKit::WebViewImpl::refreshSuggestionsPopup):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::suggestionsPopupDidHide):
18:28 Changeset [54457] by eric@webkit.org

2010-02-05 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Define SYSTEM_MALLOC 1
https://bugs.webkit.org/show_bug.cgi?id=34640

Make BREWMP use system malloc because FastMalloc is not ported.

  • wtf/Platform.h:
17:30 Changeset [54456] by eric.carlson@apple.com

2010-02-05 Eric Carlson <eric.carlson@apple.com>

Unreviewed revert of r54454, until I can generate new results

  • media/video-loop-expected.txt:
  • media/video-loop.html:
17:10 Changeset [54455] by cmarrin@apple.com

Fixed changed virtual function in GraphicsLayerCACF and call order issues
https://bugs.webkit.org/show_bug.cgi?id=34348


The correct virtual function in GraphicsLayerCACF is now being
called. We also fixed an issue in QTMovieWin where the size
of the movie was not being set correctly because the call order
was changed.


I also changed the order of a couple of calls in QTMovieWin to account
for changed calling order from the logic above.

16:49 Changeset [54454] by eric.carlson@apple.com

2010-02-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=33671
[GTK] media/video-loop.html fails intermittently on Gtk Bots

Rewrite test to make it less timing dependent.

  • media/video-loop-expected.txt:
  • media/video-loop.html:
16:41 Changeset [54453] by mrowe@apple.com

Move aside another old branch.

16:41 Changeset [54452] by dpranke@chromium.org

2010-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Add a simple test implementation and the WebKit Mac implementation
for the layout_tests/port package. Also add a simple test driver of
that interface.

https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/webkitpy/layout_tests/driver_test.py: Added.
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/mac.py: Added.
  • Scripts/webkitpy/layout_tests/port/test.py: Added.
16:40 Changeset [54451] by mrowe@apple.com

Move aside some old branches.

16:29 Changeset [54450] by mrowe@apple.com

New branch.

16:01 Changeset [54449] by dpranke@chromium.org

2010-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

Refactor the port package into an object-oriented style and merge
path_utils into it. We add a 'base' and a 'chromium' object to the
port package; this will allow us to easily add new ports (like
WebKit Mac).

https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/run-chromium-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/base.py: Added.
  • Scripts/webkitpy/layout_tests/port/chromium.py: Added.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
15:11 Changeset [54448] by eric@webkit.org

2010-02-05 James Hawkins <jhawkins@chromium.org>

Reviewed by David Levin.

[Chromium] Remove an unused forward declaration in WebKitClient.h.

https://bugs.webkit.org/show_bug.cgi?id=34622

  • public/WebKitClient.h:
14:53 Changeset [54447] by kdecker@apple.com

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=34661
<rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
  • Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView. (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
14:40 Changeset [54446] by enrica@apple.com

Horizontal scrollbar works in reverse at milliondollarcu.be
<rdar://problem/7556121>
https://bugs.webkit.org/show_bug.cgi?id=33848

Reviewed by Simon Fraser.

Added a manual test.

  • manual-tests/win: Added.
  • manual-tests/win/horizontal-scroll-composited.html: Added.
  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):

14:24 Changeset [54445] by ossy@webkit.org

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662

  • platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix.
14:04 Changeset [54444] by ossy@webkit.org

Rubber-stamped by Kenneth Rohde Christiansen.

Update expected results after r54441 to make buildbot happy.

  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated.
13:58 Changeset [54443] by eric@webkit.org

2010-02-05 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

Implement WebInputElement::isActivatedSubmit().

https://bugs.webkit.org/show_bug.cgi?id=34623

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::isActivatedSubmit):
13:37 Changeset [54442] by eric@webkit.org

2010-02-05 Ryan Leavengood <leavengood@gmail.com>

Reviewed by David Levin.

Implementation of GlyphPage::fill() for Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=34527

Covered by existing tests.

  • platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp
13:21 Changeset [54441] by kenneth@webkit.org

Unreviewed, missed in earlier commit.

Add expected frame flattening results for Qt.

  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
12:47 Changeset [54440] by kenneth@webkit.org

Implement flattening of framesets
https://bugs.webkit.org/show_bug.cgi?id=32717

Reviewed by Dave Hyatt.

WebCore:

The following patch, builds ontop of Antti Koivisto's frameset
flattening code from the iPhone source, which itself is based on
the old Nokia Series 60 source.

Layout tests have been added to test the functionality and the original
code which has then been fixed to make these pass, as well as support
frameset grids.

Tests: fast/frames/flattening/frameset-flattening-advanced.html

fast/frames/flattening/frameset-flattening-grid.html
fast/frames/flattening/frameset-flattening-simple.html
fast/frames/flattening/frameset-flattening-subframe-resize.html
fast/frames/flattening/frameset-flattening-subframesets.html

  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setFrameSetFlatteningEnabled):

  • page/Settings.h:

(WebCore::Settings::frameSetFlatteningEnabled):

  • rendering/RenderFrame.cpp:

(WebCore::RenderFrame::layoutWithFlattening):

  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::flattenFrameSet):
(WebCore::RenderFrameSet::userResize):

  • rendering/RenderFrameSet.h:

WebKit/qt:

Privately export the setFrameSetFlatteningEnabled setting for
use with the Qt DRT.

  • Api/qwebpage.cpp:

(qt_drt_setFrameSetFlatteningEnabled):
(QWebPagePrivate::core):

  • Api/qwebpage_p.h:

WebKitTools:

Add support for testing frame flattening with the Qt DRT

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setFrameSetFlatteningEnabled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Frameset flattening layout test, plus expected result for Qt.

  • fast/frames/flattening/frameset-flattening-advanced.html: Added.
  • fast/frames/flattening/frameset-flattening-grid.html: Added.
  • fast/frames/flattening/frameset-flattening-simple.html: Added.
  • fast/frames/flattening/frameset-flattening-subframe-resize.html: Added.
  • fast/frames/flattening/frameset-flattening-subframesets.html: Added.
  • fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
12:44 Changeset [54439] by cjerdonek@webkit.org

Provided a way in check-webkit-style to specify filter rules
on a per file or folder basis, via a configuration variable.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=33684

  • Scripts/webkitpy/style/checker.py:
    • Added _PATH_RULES_SPECIFIER configuration variable.
    • In ProcessorOptions class--
      • Changed the CategoryFilter attribute to FilterConfiguration.
      • Added path parameter to is_reportable().
    • Renamed ArgumentDefaults filter_rules attribute to base_filter_rules.
    • Updated ArgumentPrinter class.
    • Added filter rule validation to ArgumentParser (instead of in CategoryFilter constructor).
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated unit tests as necessary.
    • Added unit tests for PATH_RULES_SPECIFIER.
  • Scripts/webkitpy/style/error_handlers.py:
    • Updated DefaultStyleErrorHandler to use file path when calling is_reportable().
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated unit tests as necessary.
  • Scripts/webkitpy/style/filter.py:
    • Marked CategoryFilter internal with an underscore.
    • Removed argument validation from CategoryFilter.
    • Added FilterConfiguration class.
  • Scripts/webkitpy/style/filter_unittest.py:
    • Updated CategoryFilterTest class.
    • Added FilterConfigurationTest unit tests.
  • Scripts/webkitpy/style/processors/cpp.py:
    • Removed _is_test_filename() code.
    • Removed hard-coded path checks from check_include_line().
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
    • Removed three unit tests related to exempted files.
11:50 Changeset [54438] by simon.fraser@apple.com

2010-02-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Changing display type of parent of input on focus causes input field to not receive key events
https://bugs.webkit.org/show_bug.cgi?id=34620
<rdar://problem/7584572>

When layout affects a text input, the RenderTextControl gets destroyed and
recreated, which in turn makes a new innerTextElement. However, if the text field was
focused, the VisibleSelection is left pointing to the old innerTextElement, so text
input no longer works.

The fix is to call updateFocusAppearanceSoon() when attaching the input element,
which will update the selection if necessary.

Test: fast/forms/restore-selection-after-layout.html

  • dom/Document.h: Add a paramter to updateFocusAppearanceSoon() and a member variable, m_updateFocusAppearanceRestoresSelection, to store its value until the timer fires.
  • dom/Document.cpp: (WebCore::Document::Document): Initialize m_updateFocusAppearanceRestoresSelection (WebCore::Document::updateFocusAppearanceSoon): New restorePreviousSelection parameter. (WebCore::Document::updateFocusAppearanceTimerFired): Pass m_updateFocusAppearanceRestoresSelection down.
  • dom/Element.cpp: (WebCore::Element::attach): Call updateFocusAppearanceSoon() with false.
  • dom/Element.h: The updateFocusAppearanceSoonAfterAttach() was undefined.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach): Call document()->updateFocusAppearanceSoon() with true.
11:46 Changeset [54437] by kenneth@webkit.org

[Qt] Apply the command line options as settings to the graphics system.

Reviewed by Ariya Hidayat.

  • QtLauncher/main.cpp:

(LauncherWindow::LauncherWindow):
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):

  • QtLauncher/webview.h:

(WebViewGraphicsBased::setItemCacheMode):

11:30 Changeset [54436] by pfeldman@chromium.org

2010-02-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: simplify cookies view, introduce DataGrid::autoSizeColumns.

https://bugs.webkit.org/show_bug.cgi?id=34646

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.show): (WebInspector.CookieItemsView.prototype._update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): (WebInspector.CookieItemsView.prototype._createDataGrid): (WebInspector.CookieItemsView.prototype._populateDataGrid.expiresCompare): (WebInspector.CookieItemsView.prototype._populateDataGrid): (WebInspector.CookieItemsView.prototype._createSimpleDataGrid): (WebInspector.CookieItemsView.prototype._populateSimpleDataGrid): (WebInspector.CookieItemsView.prototype._deleteCookieCallback): (WebInspector.CookieItemsView.prototype._refreshButtonClicked):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries): (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.autoSizeColumns):
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult):
11:22 Changeset [54435] by pfeldman@chromium.org

2010-02-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: group cookies by frame, show total
cookies size, allow sorting cookie table.

https://bugs.webkit.org/show_bug.cgi?id=34617

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::deleteCookie):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._cookiesForDomain): (WebInspector.CookieItemsView.prototype.dataGridForCookies): (WebInspector.CookieItemsView.prototype._createNodes): (WebInspector.CookieItemsView.prototype._sortData.localeCompare): (WebInspector.CookieItemsView.prototype._sortData.numberCompare): (WebInspector.CookieItemsView.prototype._sortData.expiresCompare): (WebInspector.CookieItemsView.prototype._sortData):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect): (WebInspector.CookieSidebarTreeElement.prototype.get subtitle): (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
11:08 Changeset [54434] by eric@webkit.org

2010-02-05 Maxime Simone <simon.maxime@gmail.com>

Reviewed by David Levin.

More robust conversion from BString to String for Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=34527

Covered by existing tests.

  • platform/text/haiku/StringHaiku.cpp: Fixed include order, Improved coversion from BString.
10:44 Changeset [54433] by mrowe@apple.com

Merge r54430.

10:43 Changeset [54432] by mrowe@apple.com

Versioning.

10:41 Changeset [54431] by mrowe@apple.com

New tag.

10:35 Changeset [54430] by sfalken@apple.com

Windows build fix.

Reviewed by Adam Roben.

  • WebCore.vcproj/WebCore.make:
10:08 Changeset [54429] by ossy@webkit.org

Rubber-stamped by Kenneth Rohde Christiansen.
Reviewed by Dirk Schulze.

[Qt] Modifying SVG path dumping to equal to other ports
https://bugs.webkit.org/show_bug.cgi?id=33784

WebCore:

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::debugString): Path dumping style is aproached to Mac.

LayoutTests:

Expected files updated.

  • platform/qt/svg/css/arrow-with-shadow-expected.txt:
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/qt/svg/css/clippath-with-shadow-expected.txt:
  • platform/qt/svg/css/mask-with-shadow-expected.txt:
  • platform/qt/svg/css/path-with-shadow-expected.txt:
  • platform/qt/svg/css/stars-with-shadow-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/qt/svg/custom/marker-opacity-expected.txt:
  • platform/qt/svg/custom/marker-referencePoint-expected.txt:
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
  • platform/qt/svg/custom/mask-with-default-value-expected.txt:
  • platform/qt/svg/custom/relative-sized-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/transformedMaskFails-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
09:46 Changeset [54428] by ggaren@apple.com

2010-02-05 Kwang Yul Seo <skyul@company100.net>

Reviewed by Alexey Proskuryakov.

Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569

With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.


However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.

If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.

  • wtf/FastMalloc.cpp: (WTF::fastMalloc): (WTF::fastCalloc):

2010-02-05 Sebastian Dröge <sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34317

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::doGstInit):
  • platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gtk/WebKitWebSourceGStreamer.h: Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure. This makes sure that referer, cookies, authentication information and all kinds of other context are passed to GStreamer for websites like Vimeo or YouTube.
09:24 Changeset [54427] by kov@webkit.org

2010-02-05 Sebastian Dröge <sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34317

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::doGstInit):
  • platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gtk/WebKitWebSourceGStreamer.h: Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure. This makes sure that referer, cookies, authentication information and all kinds of other context are passed to GStreamer for websites like Vimeo or YouTube.
08:41 Changeset [54426] by vestbo@webkit.org

[Qt] Fix build on Windows

Reviewed by Kenneth Rohde Christiansen.

DerivedSources for our API headers failed on Windows,
due to Windows not accepting ; as a command separator,
not needing quotes for echo, and needing < and > escaped.

We now detect Windows and set these quote markers and
escape markers accordingly, as well as use && for separating
individual commands.

  • Api/DerivedSources.pro:
08:28 Changeset [54425] by japhet@chromium.org

2010-02-05 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Clean up code for getting a v8::FunctionTemplate.


https://bugs.webkit.org/show_bug.cgi?id=34606

  • bindings/scripts/CodeGeneratorV8.pm: Making GetTemplate() public
  • bindings/v8/V8Binding.cpp: (WebCore::configureTemplate):
  • bindings/v8/V8DOMWrapper.cpp: Remove getTemplate(), use V8ClassIndex::getTemplate() instead. (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::lookupDOMWrapper):
  • bindings/v8/V8Index.cpp: Remove duplicate caching of FunctionTemplates. (WebCore::V8ClassIndex::getTemplate):
  • bindings/v8/V8Index.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::toV8):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback): (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.h:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): (WebCore::V8HTMLImageElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLImageElementConstructor.h:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback): (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScriptHostV8Wrapper):
08:01 Changeset [54424] by ossy@webkit.org

Rubber-stamped by Tor Arne Vestbø.

[Qt] fast/css/dashboard-regions-attr-crash.html skipped,
because ENABLE_DASHBOARD_SUPPORT=0 is the default option.

  • platform/qt/Skipped:
07:09 Changeset [54423] by eric@webkit.org

2010-02-05 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Add .gitattributes file to tell git about files with Windows linefeeds
https://bugs.webkit.org/show_bug.cgi?id=34645

On Windows git defaults to "true" for core.autocrlf, meaning all text
files in the working directory are converted from CRLF to LF on checkin
time. Some files present in the repository have been checked in with
CRLF linefeeds and git should not try to convert them. The added
.gitattributes file tells git to not do any CRLF conversion.

  • .gitattributes: Added.
06:10 Changeset [54422] by hausmann@webkit.org

[Qt] Build break in QtWebkit on Symbian
https://bugs.webkit.org/show_bug.cgi?id=34597

Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2010-02-05
Reviewed by Ariya Hidayat.

  • plugins/PluginView.h:
06:08 Changeset [54421] by yurys@chromium.org

2010-02-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

  • Use SerializedScriptValue for passing data between injected script and inspector frontend.
  • Remove custom JSON implementation from the instpector utility script.
  • Make sure that only objects created in the same ScriptState can be values of ScriptObject/Array properties and arguments to ScriptFunctionCall. We don't want ScriptObjects to leak between contexts.
  • Use ScriptState of the 'this' object in ScriptFunctionCall instead of passing it as additional parameter.

https://bugs.webkit.org/show_bug.cgi?id=33592

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript):
  • bindings/js/ScriptArray.cpp: (WebCore::ScriptArray::set):
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument):
  • bindings/js/ScriptFunctionCall.h:
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::ScriptValue::deserialize):
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptArray.cpp: (WebCore::ScriptArray::set):
  • bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument):
  • bindings/v8/ScriptFunctionCall.h:
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/v8/ScriptState.h:
  • bindings/v8/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::deserialize):
  • bindings/v8/ScriptValue.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapForConsole): (WebCore::InjectedScript::releaseWrapperObjectGroup):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::didPause): (WebCore::InspectorController::didEvaluateForTestInFrontend):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::newScriptArray): (WebCore::InspectorFrontend::newScriptObject): (WebCore::InspectorFrontend::populateFrontendSettings): (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount): (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::didGetResourceContent): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::addRecordToTimeline): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::setDocument): (WebCore::InspectorFrontend::setDetachedRoot): (WebCore::InspectorFrontend::setChildNodes): (WebCore::InspectorFrontend::childNodeCountUpdated): (WebCore::InspectorFrontend::childNodeInserted): (WebCore::InspectorFrontend::childNodeRemoved): (WebCore::InspectorFrontend::attributesUpdated): (WebCore::InspectorFrontend::didRemoveNode): (WebCore::InspectorFrontend::didGetChildNodes): (WebCore::InspectorFrontend::didApplyDomChange): (WebCore::InspectorFrontend::didGetEventListenersForNode): (WebCore::InspectorFrontend::didGetCookies): (WebCore::InspectorFrontend::didDispatchOnInjectedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::didGetDatabaseTableNames): (WebCore::InspectorFrontend::addDOMStorage): (WebCore::InspectorFrontend::selectDOMStorage): (WebCore::InspectorFrontend::didGetDOMStorageEntries): (WebCore::InspectorFrontend::didSetDOMStorageItem): (WebCore::InspectorFrontend::didRemoveDOMStorageItem): (WebCore::InspectorFrontend::updateDOMStorage): (WebCore::InspectorFrontend::addNodesToSearchResult): (WebCore::InspectorFrontend::contextMenuItemSelected): (WebCore::InspectorFrontend::evaluateForTestInFrontend): (WebCore::InspectorFrontend::callSimpleFunction):
  • inspector/InspectorFrontend.h: (WebCore::InspectorFrontend::scriptState):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName.myCallback): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.addConsoleMessage):

2010-02-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Remove unused inmport of ScriptFunctionCall.h

https://bugs.webkit.org/show_bug.cgi?id=33592

  • Api/qwebelement.cpp:
06:00 WebKit Team edited by krit@webkit.org
(diff)
05:23 Changeset [54420] by vestbo@webkit.org

[Qt] Generate convenience headers (QWebView, etc) using qmake

Reviewed by Simon Hausmann.

In Qt this is done using syncqt, but we use a pro-file instead
that generates makefile-rules for each of the extra headers.

These extra headers are installed alongside the normal headers.

WebCore:

  • WebCore.pro: Use headers.pri based on DerivedSources instead

of the one previously checked in in the source tree.

WebKit/qt:

  • Api/DerivedSources.pro: Added. List of headers + pro file magic
  • Api/headers.pri: Removed, list of headers is now in the above file

WebKitTools:

  • Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
04:27 Changeset [54419] by zoltan@webkit.org

Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569

Patch by Kwang Yul Seo <skyul@company100.net> on 2010-02-05
Reviewed by Alexey Proskuryakov.

With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.

However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.

If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.

  • wtf/FastMalloc.cpp:

(WTF::fastMalloc):
(WTF::fastCalloc):

04:20 Changeset [54418] by abecsi@webkit.org

2010-02-05 Andras Becsi <abecsi@webkit.org>

Unreviewed typo fix.

Fix wrong whitespace alignment introduced in r54342.

04:05 Changeset [54417] by eric@webkit.org

2010-02-05 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Enable JAVASCRIPT_DEBUGGER in chromium port.

https://bugs.webkit.org/show_bug.cgi?id=34638

  • page/Console.cpp:
  • page/Console.h:
  • page/Console.idl:

2010-02-05 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Enable JAVASCRIPT_DEBUGGER in chromium port.

https://bugs.webkit.org/show_bug.cgi?id=34638

  • features.gypi:
03:45 Changeset [54416] by kenneth@webkit.org

Rubberstamped by Oliver Hunt.

[Qt] Make it possible to choose whether the launcher should
use the traditional QWidget based QWebView or the newer
QGraphics based QGraphicsWebView on a QGraphicsView.

  • QtLauncher/main.cpp:

(LauncherWindow::LauncherWindow):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::print):
(LauncherWindow::screenshot):
(LauncherWindow::setEditable):
(LauncherWindow::setupUI):
(main):

  • QtLauncher/webview.cpp:

(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::resizeEvent):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::contextMenuEvent):

  • QtLauncher/webview.h:

(WebViewTraditional::WebViewTraditional):
(GraphicsWebView::GraphicsWebView):
(WebViewGraphicsBased::setPage):

02:50 Changeset [54415] by eric@webkit.org

2010-02-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Tab width for javascript source is 8, should be 4

https://bugs.webkit.org/show_bug.cgi?id=31248

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.set replaceTabsWithSpaces): (WebInspector.TextEditorModel.prototype._innerSetText): (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded):
01:37 Changeset [54414] by ukai@chromium.org

2010-02-05 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

send() should return false, after frame that opened a WebSokcet is detached
https://bugs.webkit.org/show_bug.cgi?id=34630

  • websocket/tests/send-after-close-on-unload-expected.txt: Added.
  • websocket/tests/send-after-close-on-unload.html: Added.
01:23 Changeset [54413] by tony@chromium.org

2010-02-05 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24872
Add a test to make sure copying from a list and pasting into a list
keeps the list at the same indention level rather than nesting.

  • editing/pasteboard/paste-list-002-expected.txt: Added.
  • editing/pasteboard/paste-list-002.html: Added.

2010-02-05 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24872
When pasting a list into another list should not indent another level.
If the cursor is at the beginning of the line, it should insert the
list items before the current list item. If the cursor is at the end
of the line, it should insert the list items after the current list item.

This matches Firefox and IE and makes the common activity of reordering a list
work as expected.

This also adds a small helper method (isListItem) to htmlediting.h.

Test: editing/pasteboard/paste-list-002.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertAsListItems):
  • editing/ReplaceSelectionCommand.h:
  • editing/htmlediting.cpp: (WebCore::isListItem): (WebCore::appendedSublist):
  • editing/htmlediting.h:

02/04/10:

23:45 Changeset [54412] by vestbo@webkit.org

[Qt] Make 'make -f Makefile.DerivedSources qmake' work

Reviewed by Lars Knoll.

Previously this target ended up generating a file named
Makefile.DerivedSources.DerivedSources, and so on.

  • DerivedSources.pro:
23:34 Changeset [54411] by mrowe@apple.com

Rubber-stamped by Dan Bernstein.

Fix the ability to #include <WebKit/DOMFile.h>.

  • MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.
23:18 Changeset [54410] by eric@webkit.org

2010-02-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin
https://bugs.webkit.org/show_bug.cgi?id=34509

Resubmit: The previous commit (r54333) was rolled back.

  • WebKit.gyp:
  • tests/TransparencyWinTest.cpp: Added. (WebCore::RECTToFloatRect): (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::operator<<): (WebCore::TEST):
  • tests/UniscribeHelperTest.cpp: Added. (WebCore::UniscribeTest::UniscribeTest): (WebCore::UniscribeTest::MakeFont): (WebCore::UniscribeTest::SetUp): (WebCore::UniscribeTest::TearDown): (TEST_F):
22:22 Changeset [54409] by mrowe@apple.com

Merge r54405.

22:22 Changeset [54408] by mrowe@apple.com

Versioning.

22:20 Changeset [54407] by mrowe@apple.com

New tag.

22:15 Changeset [54406] by ukai@chromium.org

2010-02-04 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

should not crash when document opened websocket is unloaded
https://bugs.webkit.org/show_bug.cgi?id=34562

  • websocket/tests/close-on-unload-and-force-gc-expected.txt: Added.
  • websocket/tests/close-on-unload-and-force-gc.html: Added.
  • websocket/tests/close-on-unload-reference-in-parent-expected.txt: Added.
  • websocket/tests/close-on-unload-reference-in-parent.html: Added.
  • websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Added.
22:13 Changeset [54405] by mrowe@apple.com

Build fix. Remove a symbol corresponding to an inline function from the linker export
file to prevent a weak external failure.

Reviewed by Timothy Hatcher.

JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj: Accommodate rename of script.

JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj: Accommodate rename of script.

WebCore:

  • WebCore.base.exp: Remove symbol.
  • WebCore.xcodeproj/project.pbxproj: Accommodate rename of script.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Accommodate rename of script.

WebKitTools:

  • Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.

Teach the script how to detect weak external symbols so that these errors can be caught immediately
in the future.

21:59 Changeset [54404] by ukai@chromium.org

2010-02-04 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

websocket/tests/close-on-unload.html failed on Mac Tiger
https://bugs.webkit.org/show_bug.cgi?id=34563

  • platform/mac-tiger/Skipped: remove websocket/tests/close-on-unload*.html
  • websocket/tests/close-on-unload_wsh.py: use dict instead of set.
21:33 Changeset [54403] by dbates@webkit.org

2010-02-04 Daniel Bates <dbates@webkit.org>

[Qt] Unreviewed, build fix for Qt bot.

  • runtime/JSStringBuilder.h: Changed #include <X.h> notation #include "X.h".
19:53 Changeset [54402] by ggaren@apple.com

Build fix: export a header.

19:47 Changeset [54401] by ggaren@apple.com

Build fix: Added a forwarding header.

  • ForwardingHeaders/runtime/WeakGCPtr.h: Added.
19:39 Changeset [54400] by ggaren@apple.com

WebCore: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>

Reviewed by Alexey Proskuryakov and Darin Adler.

There were two bugs here:

  1. A stale wrapper would invalidate a node's event listeners, even if

the node had a fresh wrapper keeping it alive.

The fix for this is for an event listener to keep a WeakGCPtr back-pointer
to the wrapper it expects to mark it. The wrapper destructor checks this
back-pointer, and only invalidates the event listener in the case of a match.

  1. Conversely, a stale wrapper would not invalidate a node's event

listeners soon enough, if its destructor didn't have a chance to run
before an event fired on the node. (This can only happen in cases where
we've made some other error and failed to mark a wrapper that was circuitously
observable in the DOM. But we know we have edge case bugs like this, and
we don't want them to be crashes.)

The fix for this is to check the wrapper back-pointer before firing the
event listener. As long as the the wrapper back-pointer is not null,
it's safe to fire the listener.

  • ForwardingHeaders/runtime/WeakGCPtr.h: Added. Appease build gods.
  • bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::markChildren):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::initializeJSFunction):
(WebCore::JSEventListener::invalidateJSFunction):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::create):
(WebCore::JSEventListener::isolatedWorld):
(WebCore::JSEventListener::wrapper):
(WebCore::JSEventListener::setWrapper):
(WebCore::JSEventListener::jsFunction):
(WebCore::createJSAttributeEventListener): Implemented the back-pointer
described above. Refactored the jsFunction() accessor to return 0 if
the wrapper back-pointer is 0.

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSLazyEventListener.h:

(WebCore::JSLazyEventListener::create):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::markChildren):
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.

  • bindings/js/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.
(WebCore::getEventListenerHandlerBody): Updated for the fact that jsFunction()
is no longer a virtual accessor on the EventHandler base class.

  • bindings/scripts/CodeGeneratorJS.pm: Updated for the fact that jsFunction()

is no longer a virtual accessor on the EventHandler base class. Added a "JS"
to invalidateEventListeners and markEventListeners to clarify that these
actions are for JS event listeners only. Added a wrapper parameter to
invalidateEventListeners for the back-pointer check explained above.

  • dom/EventListener.h:

(WebCore::EventListener::invalidateJSFunction): ditto

  • dom/EventTarget.h:

(WebCore::EventTarget::markJSEventListeners):
(WebCore::EventTarget::invalidateJSEventListeners): ditto

LayoutTests: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>

Reviewed by Alexey Proskuryakov and Darin Adler.

  • fast/events/bogus-event-listener-invalidation-expected.txt: Added.
  • fast/events/bogus-event-listener-invalidation.html: Added.
19:06 Changeset [54399] by mrowe@apple.com

Versioning.

19:05 Changeset [54398] by mrowe@apple.com

Versioning.

19:03 Changeset [54397] by mrowe@apple.com

Versioning.

18:56 Changeset [54396] by mrowe@apple.com

Create tag Safari-533

18:38 Changeset [54395] by eric@webkit.org

2010-02-04 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25002
When inserting a new paragraph, avoid nesting empty divs. When
pasting near the end of a paragraph, this prevents each paste
command for getting nested one level deeper.

Three paste tests have been rebaselined since this causes the pasted
content to be outside the last div instead of inside. E.g.,
<div>foo<div>bar</div>[pasted content]</div> is now
<div>foo<div>bar</div></div><div>[pasted content]</div>

The new test verifies this behavior.

  • editing/inserting/paragraph-outside-nested-divs-expected.txt: Added.
  • editing/inserting/paragraph-outside-nested-divs.html: Added.
  • platform/mac/editing/pasteboard/paste-text-012-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-013-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-017-expected.txt:

2010-02-04 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25002
When inserting a new paragraph, avoid nesting empty divs. When
pasting near the end of a paragraph, this prevents each paste
command for getting nested one level deeper.

Test: editing/inserting/paragraph-outside-nested-divs.html

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::highestVisuallyEquivalentDiv): (WebCore::InsertParagraphSeparatorCommand::doApply):
18:31 Changeset [54394] by barraclough@apple.com

Add a JSStringBuilder class (similar-to, and derived-from StringBuilder) to
construct JSStrings, throwing a JS exception should we run out of memory whilst
allocating storage for the string.

Reviewed by Oliver Hunt.

Similarly, add jsMakeNontrivialString methods to use in cases where previously
we were calling makeString & passing the result to jsNontrivialString. Again,
these new methods throw if we hit an out of memory condition.

Move throwOutOfMemoryError into ExceptionHelpers, to make it more widely available.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):

  • runtime/DateConstructor.cpp:

(JSC::callDate):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToGMTString):

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

  • runtime/ExceptionHelpers.cpp:

(JSC::throwOutOfMemoryError):

  • runtime/ExceptionHelpers.h:
  • runtime/JSStringBuilder.h: Added.

(JSC::JSStringBuilder::releaseJSString):
(JSC::jsMakeNontrivialString):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToPrecision):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • runtime/Operations.cpp:
  • runtime/Operations.h:
  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

  • runtime/StringBuilder.h:

(JSC::StringBuilder::append):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):

18:09 Changeset [54393] by dumi@chromium.org

WebCore: 1. Fix a bug in SQLiteTransaction: do not assume that COMMIT always
succeeds.

  1. Jump straight to the transaction error callback when a

statement fails in a way that makes sqlite automatically rollback
the transaction.

  1. Fix the code that handles the "quota reached" failure, as it is

one of the failures that lead to an automatic transaction
rollback.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=34280

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::isAutoCommitOn):

  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteTransaction.cpp:

(WebCore::SQLiteTransaction::begin):
(WebCore::SQLiteTransaction::commit):
(WebCore::SQLiteTransaction::rollback):
(WebCore::SQLiteTransaction::transactionWasRolledBackBySqlite):

  • platform/sql/SQLiteTransaction.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):

LayoutTests: 1. Enhance quota-tracking.html: if sqlite automatically rolls back
a transaction because of a statement failure, make sure the rest
of the statements in the transaction are not executed.

  1. Fix the expectations for quota-tracking.html. Sqlite cannot

recover from reaching a DB's max size.

Reviewed by Eric Seidel.

  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:
17:50 Changeset [54392] by pkasting@chromium.org

Not reviewed, rollback.

Rollback r54387, it doesn't fix builds and Chromium doesn't want this behavior.

  • platform/chromium/ScrollbarThemeChromiumMac.h:
17:41 Changeset [54391] by sfalken@apple.com

Windows build fix.

  • wtf/MathExtras.h:
17:35 Changeset [54390] by mrowe@apple.com

Versioning.

17:33 Changeset [54389] by mrowe@apple.com

New tag.

17:01 Changeset [54388] by darin@apple.com

2010-02-04 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Make MathExtras.h compatible with <cmath>
https://bugs.webkit.org/show_bug.cgi?id=34618

  • wtf/MathExtras.h: Include <cmath> instead of <math.h>. Use "using" as we do elsewhere in WTF for the four functions from <cmath> we want to use without the prefix. Later we could consider making the std explicit at call sites instead.
16:52 Changeset [54387] by senorblanco@chromium.org

2010-02-04 Stephen White <senorblanco@chromium.org>

Unreviewed, build fix.

Fix for Chromium/Mac after palindromic scrollbar change (54345).

Covered by many layout tests.

  • platform/chromium/ScrollbarThemeChromiumMac.h: (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
16:35 Changeset [54386] by eric@webkit.org

2010-02-04 Clemmitt Sigler <cmsigler@gmail.com>

Reviewed by David Levin.

WebKitGTK doesn't build GtkLauncher when --enable-mathml is specified.
Updated WebCore/GNUmakefile.am to include needed files in build.

https://bugs.webkit.org/show_bug.cgi?id=34387

No new tests.

  • GNUmakefile.am:
16:29 Changeset [54385] by mrowe@apple.com

Versioning.

16:23 Changeset [54384] by mrowe@apple.com

New tag.

16:19 Changeset [54383] by eric@webkit.org

2010-02-04 Stephan Aßmus <superstippi@gmx.de>

Reviewed by David Levin.

Misc coding style fixes in Haiku port code.
https://bugs.webkit.org/show_bug.cgi?id=34527

No tests needed.

  • platform/haiku/ContextMenuItemHaiku.cpp: Trailing white space, NULL -> 0
  • platform/haiku/DragImageHaiku.cpp: Trailing white space.
  • platform/haiku/FileChooserHaiku.cpp: Sorted headers.
  • platform/haiku/LocalizedStringsHaiku.cpp: Needed to include NotImplemented.h
16:11 Changeset [54382] by mrowe@apple.com

Merge r54376.

15:50 Changeset [54381] by ossy@webkit.org

Unreviewed typo fix for r54379.

  • platform/qt/Skipped:
15:43 Changeset [54380] by eric@webkit.org

2010-02-04 Drew Wilson <atwilson@chromium.org>

Reviewed by David Levin.

WorkerContext.close() does not work in the chromium port
https://bugs.webkit.org/show_bug.cgi?id=34551

Test: Adding new downstream test.

  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::workerContextClosedTask): Now shuts down the worker thread when WorkerContext::close() is invoked.
15:36 Changeset [54379] by ossy@webkit.org

editing/pasteboard/drop-inputtext-acquires-style.html
introduced in r54368 skipped because of missing DnD support.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
15:33 Changeset [54378] by christian@webkit.org

2010-02-04 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

[GTK] Add and cleanup return values of signals in view and frame
https://bugs.webkit.org/show_bug.cgi?id=33484

Add missing and cleanup return values of web frame and web view signals.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
  • webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
15:30 Changeset [54377] by enrica@apple.com

Fixed crash on QT introduced with the fix for
https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Csaba Osztrogonac.

The test has been added with the original patch.

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::writePlainText): Added missing allocation of m_writeData.

15:29 Changeset [54376] by alice.liu@apple.com

https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
codes for most elements that arent listbox or menupopup related"
<rdar://problem/7436861>

Reviewed by Jon Honeycutt.

  • AccessibleBase.cpp:

(AccessibleBase::accSelect):

  • Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that aren't beneath listboxes or menupopups. This was too restrictive since any element can be selectable.
  • Correct the misinterpretation of MSDN's stipulation of situations involving adding, removing, and extending selection on single-select elements
14:51 Changeset [54375] by christian@webkit.org

2010-02-04 Christian Dywan <christian@twotasts.de>

Reviewed by Xan Lopez.

Require either libsoup 2.28.2 or 2.29.90.

  • configure.ac:

2010-02-04 Christian Dywan <christian@twotoasts.de>

Reviewed by Xan Lopez.

Conditionalize third party cookie policy for libsoup 2.29.90.

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
  • platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
14:50 Changeset [54374] by christian@webkit.org

2010-02-04 Christian Dywan <christian@twotoasts.de>

Rubber-stamped by Gustavo Noronha Silva.

Add ENABLE(VIDEO) guards around freeOwnedGPtr<GstElement> implementation.

  • platform/gtk/GOwnPtrGtk.cpp:
14:35 Changeset [54373] by ap@apple.com

Correct a mistake in ChangeLog entry.

14:12 Changeset [54372] by ap@apple.com

Reviewed by Darin Adler.

Assertion failure in CheckedRadioButtons::removeButton when using jQuery 1.4.1
https://bugs.webkit.org/show_bug.cgi?id=34520

Test: fast/dom/HTMLInputElement/cloned-input-checked-state.html

  • dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Copy non-attribute properties before attributes. Otherwise, copying "checked" property would make the cloned node checked, unchecking original (they share a name, and are thus in the same radio group). We do want the original to be unchecked, but we also want to know its original state in HTMLInputElement::copyNonAttributeProperties().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties): Use setChecked instead of plain assignment to prevent m_checked getting out of sync with checkedRadioButtons. Also, copy field related to default checked state, so that m_checked won't be overridden when copying attributes.
14:12 Changeset [54371] by kevino@webkit.org

[wx] Build fix after addition of Clipboard::writePlainText method.

14:10 Changeset [54370] by bfulgham@webkit.org

Properly handle margin settings when printing Plugins in WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=34613

Reviewed by Adam Roben.

  • WebFrame.cpp:

(WebFrame::spoolPage): Adjust the GraphicsContext passed to the

paintContents method so that the World Transform is properly
positioned to account for margin settings at the time that
PluginViewWin.cpp processes the drawing operations.

14:07 Changeset [54369] by mrowe@apple.com

Update auto-version.sh to better handle major version numbers with fewer than three digits,
and the case when WEBKITLIBRARIESDIR is not set.

Reviewed by Steve Falkenburg.

  • win/tools/scripts/auto-version.sh:
13:50 Changeset [54368] by enrica@apple.com

REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info.
<rdar://problem/7595685>
https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Oliver Hunt.

WebCore:

Test: editing/pasteboard/drop-inputtext-acquires-style.html

The dragging code did not distinguish the case of dragging the content of an input control
as a special case. The markup placed in the pasteboard included the style information.
I've modified the Clipboard class interface adding a new method writePlainText to match the
behavior of the copy and cut commands and modified the drag code to detect the special case.
I've modified all the platform specific implementations of the Clipboard class.

  • dom/Clipboard.h: Added writePlainText pure virtual function.
  • editing/Editor.cpp:

(WebCore::Editor::cut): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
(WebCore::Editor::copy): Renamed nodeIsTextFormControl to isNodeInTextFormControl.

  • editing/htmlediting.cpp:

(WebCore::isNodeInTextFormControl): Added, after removing the implementation with the old name
in Editor.cpp

  • editing/htmlediting.h:
  • page/DragController.cpp:

(WebCore::DragController::startDrag):

  • platform/Pasteboard.h:
  • platform/android/ClipboardAndroid.cpp:

(WebCore::ClipboardAndroid::writePlainText): Added.

  • platform/android/ClipboardAndroid.h:
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::writePlainText): Added.

  • platform/chromium/ClipboardChromium.h:
  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::writePlainText): Added.

  • platform/gtk/ClipboardGtk.h:
  • platform/haiku/ClipboardHaiku.cpp:

(WebCore::ClipboardHaiku::writePlainText): Added.

  • platform/haiku/ClipboardHaiku.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writePlainText): Added.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writePlainText): Added helper function.

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::writePlainText): Added.

  • platform/qt/ClipboardQt.h:
  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writePlainText): Added.

  • platform/win/ClipboardWin.h:

LayoutTests:

  • editing/pasteboard/drop-inputtext-acquires-style-expected.txt: Added.
  • editing/pasteboard/drop-inputtext-acquires-style.html: Added.
13:45 Changeset [54367] by sullivan@apple.com

https://bugs.webkit.org/show_bug.cgi?id=34611
WebLocalizedString() could use an assertion that it is being called on the main thread

Reviewed by Tim Hatcher.

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Updated for renamed file (WebLocalizableStrings.m -> WebLocalizableStrings.mm)

WebKit/mac:

  • Misc/WebLocalizableStrings.m: Removed.
  • Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.

Renamed to use .mm extension so it can include a C++ header.
(WebLocalizedString):
Added an assertion that this is being called on the main thread.

13:19 Changeset [54366] by eric@webkit.org

2010-02-04 Steve Block <steveblock@google.com>

Reviewed by Nate Chapin.

Fix bug in V8 convertNPVariantToJValue when converting float and double types
https://bugs.webkit.org/show_bug.cgi?id=34593

No new tests, build fix only.

  • bridge/jni/v8/JNIUtilityPrivate.cpp: Modified. (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.
13:11 Changeset [54365] by kov@webkit.org

Tagging 1.1.20.

12:16 Changeset [54364] by darin@chromium.org

2010-02-04 Chris Guillory <chris.guillory@google.com>

Reviewed by Darin Fisher.

[Chromium] Notify ChromeClientChromium of AccessibilityObject state
change notifications.


https://bugs.webkit.org/show_bug.cgi?id=34464

  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::toChromeClientChromium): (WebCore::AXObjectCache::postPlatformNotification):
  • page/chromium/ChromeClientChromium.h:
12:10 Changeset [54363] by eric@webkit.org

2010-02-04 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Fisher.

Update comments to better document the possible values of the
writing direction menu state variables.

  • public/WebContextMenuData.h:
12:09 Changeset [54362] by loki@webkit.org

Use an easily appendable structure for trampolines instead of pointer parameters.
https://bugs.webkit.org/show_bug.cgi?id=34424

Patch by Tamas Szirbucz <szirbucz@inf.u-szeged.hu> on 2010-02-04
Reviewed by Gavin Barraclough.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • jit/JIT.h:

(JSC::JIT::compileCTIMachineTrampolines):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITStubs.cpp:

(JSC::JITThunks::JITThunks):

  • jit/JITStubs.h:

(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITThunks::ctiVirtualCallLink):
(JSC::JITThunks::ctiVirtualCall):
(JSC::JITThunks::ctiNativeCallThunk):

12:05 Changeset [54361] by senorblanco@chromium.org

2010-02-04 Stephen White <senorblanco@chromium.org>

Unreviewed, build fix for Chromium.

Revert r54341 ("[v8] Remove clear method from DOM object maps"),
since it causes the worker tests to fail on Chromium.

  • bindings/v8/DOMData.h: (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/DOMDataStore.h: (WebCore::ChunkedTable::clear): (WebCore::ChunkedTable::clearEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
  • bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThreadHelper): (WebCore::removeAllDOMObjectsInCurrentThread):
  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::clear):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
11:39 Changeset [54360] by kevino@webkit.org

Build fix after changes in r54345.

11:29 Changeset [54359] by eric@webkit.org

2010-02-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crashes when an invalid hostname is pre-fetched
https://bugs.webkit.org/show_bug.cgi?id=34602

  • http/tests/misc/dns-prefetch-control-expected.txt:
  • http/tests/misc/dns-prefetch-control.html: Add broken hostname test case.

2010-02-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crashes when an invalid hostname is pre-fetched
https://bugs.webkit.org/show_bug.cgi?id=34602

  • platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS): NULL-check the SoupURI that is created from the hostname; that will happen for invalid hostnames.
11:10 Changeset [54358] by bweinstein@apple.com

Rubber-stamped by Dan Bernstein.

Add Windows expected results to the new scrollbar test because Windows was trying
to compare to platform/mac first instead of cross-platform.

  • platform/win/fast/events/scrollbar-double-click-expected.txt: Added.
10:52 Changeset [54357] by kenneth@webkit.org

Rubberstamped by Oliver Hunt.

[Qt] QtLauncher cleanup.

Refactor option handling out in utility functions and make the
arguments more Qt compatible.

  • QtLauncher/main.cpp:

(requiresGraphicsView):
(LauncherApplication::handleUserOptions):

  • QtLauncher/utils.cpp:

(takeOptionValue):
(formatKeys):
(enumToKeys):
(appQuit):

  • QtLauncher/utils.h:
10:42 Changeset [54356] by bfulgham@webkit.org

Properly handle margin settings in WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=34545

Reviewed by Adam Roben.

  • WebFrame.cpp:

(scaleFactor): Require the margin information as an input

parameter, and use them when computing the scaling factor.

(WebFrame::drawHeader): Pass margin size to scaleFactor.
(WebFrame::drawFooter): Pass margin size to scaleFactor.
(WebFrame::spoolPage):

  1. Pass margin size to scaleFactor.
  2. Recognize that the return value of printerMarginRect is already in device units, and therefore scale it so that the Cairo drawing is correct.
  3. Remove scaling call for margins in GDI code, as it is already in scaled units.
10:35 Changeset [54355] by eric@webkit.org

2010-02-04 José Millán Soto <jmillan@igalia.com>

Reviewed by Xan Lopez.

[Gtk] webkitgtk crashed when Orca open
https://bugs.webkit.org/show_bug.cgi?id=34463

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForObject): Checking if render objects are texts before calling toRenderText
10:21 Changeset [54354] by sfalken@apple.com

Merge r54348.

10:18 Changeset [54353] by sfalken@apple.com

Versioning.

10:09 Changeset [54352] by xan@webkit.org

2010-02-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump minimum libsoup requirement to 2.29.90

  • configure.ac:

WebCore:

2010-02-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Set first party URI in all SoupMessages. This allows libsoup to
implement a "no third party cookies" policy in case it wants
to. Also start a non-JSC-specific, gtk-specific GOwnPtr module and
use it for SoupURI.

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
10:06 Changeset [54351] by pfeldman@chromium.org

2010-02-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: group cookies by domains, not frame's domains.

https://bugs.webkit.org/show_bug.cgi?id=34599

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._cookiesForDomain):
  • inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addCookieDomain):
10:03 Changeset [54350] by sfalken@apple.com

New tag.

10:01 Changeset [54349] by japhet@chromium.org

2010-02-04 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Delete V8CustomBinding.h and all references to V8Custom

https://bugs.webkit.org/show_bug.cgi?id=32638

  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8AttrCustom.cpp:
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • bindings/v8/custom/V8CoordinatesCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h: Removed.
  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
  • bindings/v8/custom/V8DatabaseCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventSourceConstructor.cpp:
  • bindings/v8/custom/V8EventSourceCustom.cpp:
  • bindings/v8/custom/V8GeolocationCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback): (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): (WebCore::V8HTMLImageElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback): (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8NodeFilterCustom.cpp:
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionCustom.cpp:
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
  • bindings/v8/custom/V8SVGLengthCustom.cpp:
  • bindings/v8/custom/V8SharedWorkerCustom.cpp:
  • bindings/v8/custom/V8StorageCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.h:
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebKitPointConstructor.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
09:56 Changeset [54348] by sfalken@apple.com

Windows build fix for projects not defining WebKitLibrariesDir.

09:43 Changeset [54347] by ariya@webkit.org

2010-02-04 Ariya Hidayat <ariya.hidayat@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Unnecessary QBrush construction for doing a solid fill
https://bugs.webkit.org/show_bug.cgi?id=34559

Use the similar trick like r37421, i.e. use the special brush for
solid color to avoid creating QBrush again and again.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformFillColor):
09:41 Changeset [54346] by mitz@apple.com

REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371

Reviewed by Simon Fraser.

  • platform/mac/fast/events/scrollbar-double-click-expected.txt: Added.
09:35 Changeset [54345] by mitz@apple.com

REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371

Reviewed by Simon Fraser.

WebCore:

Allow ScrollbarTheme to cap the overlap between pages, and set a cap of
40 in ScrollbarThemeMac.

  • WebCore.base.exp: Export Scrollbar::maxOverlapBetweenPages().
  • editing/EditorCommand.cpp:

(WebCore::verticalScrollDistance): Use Scrollbar methods instead of
constants, and cap the scroll distance if needed.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::wheelEvent): Ditto.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::maxOverlapBetweenPages): Added. Returns the
value from the native scrollbar theme.

  • platform/Scrollbar.h: Replaced scroll amount constants with static methods.

(WebCore::Scrollbar::pixelsPerLineStep): Replaces cScrollbarPixelsPerLineStep.
(WebCore::Scrollbar::minFractionToStepWhenPaging): Replaces cFractionToStepWhenPaging.

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::maxOverlapBetweenPages): A base implementation
that returns the largest int.

  • platform/gtk/WheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.

  • platform/haiku/PlatformWheelEventHaiku.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.

  • platform/mac/ScrollbarThemeMac.h:

(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): An override
that returns 40.

  • platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
Scrollbar::pixelsPerLineStep() instead of cScrollbarPixelsPerLineStep.

  • platform/wx/MouseWheelEventWx.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.

  • platform/wx/ScrollViewWx.cpp:

(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): Use Scrollbar
methods instead of constants, and cap the scroll distance if needed.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Ditto.

WebKit/mac:

  • WebView/WebFrameView.mm:

(-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
constants, and cap the scroll distance.
(-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
cScrollbarPixelsPerLineStep.
(-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
constants, and cap the scroll distance.

WebKit/wx:

  • WebView.cpp:

(wxWebView::OnKeyEvents): Use Scrollbar method instead of constant.

08:56 Changeset [54344] by eric@webkit.org

2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.

https://bugs.webkit.org/show_bug.cgi?id=34062

This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs (WebCore::OpacityAnimationQt::updateState): style change

2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
of QTimer::singleShot, and moved syncLayers() from paint() to update()
https://bugs.webkit.org/show_bug.cgi?id=34062

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update): Moved the sync operation to update (QGraphicsWebView::paint): Moved the sync operation to update
08:39 Changeset [54343] by pfeldman@chromium.org

2010-02-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Cookies for resources are not shown in storage panel.

https://bugs.webkit.org/show_bug.cgi?id=34594

  • inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource):
  • inspector/InspectorResource.h: (WebCore::InspectorResource::requestURL):
06:52 Changeset [54342] by abecsi@webkit.org

2010-02-04 Andras Becsi <abecsi@inf.u-szeged.hu>

Reviewed by Tor Arne Vestbø.

Implement a locking and scheduling mechanism for http testing sessions to be able
to run multiple instances of run-webkit-tests parallel on the same machine.
If a test session wants to run http tests and this feature is enabled, the pending
sessions create lockfiles with sequential lock numbers. These locks are used to schedule
the running test sessions in first come first served order. An exclusive lock ensures
that the lock numbers are sequential to avoid deadlocks and starvation.
Because the buildbot master specifies the flags used by slaves we need an environment
variable too to be able to use the feature per-slave.
Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
flag enables this feature, otherwise this patch has no effect on the testing whatsoever.

https://bugs.webkit.org/show_bug.cgi?id=33153

04:57 Changeset [54341] by eric@webkit.org

2010-02-04 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Remove clear method from DOM object maps
https://bugs.webkit.org/show_bug.cgi?id=34530

No new tests. Should be covered by existent testing infrastructure.

  • bindings/v8/DOMData.h:
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMMap.h:
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
03:15 Changeset [54340] by eric@webkit.org

2010-02-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Increase test coverage for the QScriptValue.

https://bugs.webkit.org/show_bug.cgi?id=34533

  • qt/tests/qscriptvalue/qscriptvalue.pro:
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::tst_QScriptValue): (tst_QScriptValue::~tst_QScriptValue): (tst_QScriptValue::dataHelper): (tst_QScriptValue::newRow): (tst_QScriptValue::testHelper): (tst_QScriptValue::ctor):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h: Added.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Added. (tst_QScriptValue::initScriptValues): (tst_QScriptValue::isValid_initData): (tst_QScriptValue::isValid_makeData): (tst_QScriptValue::isValid_test): (tst_QScriptValue::isBool_initData): (tst_QScriptValue::isBool_makeData): (tst_QScriptValue::isBool_test): (tst_QScriptValue::isBoolean_initData): (tst_QScriptValue::isBoolean_makeData): (tst_QScriptValue::isBoolean_test): (tst_QScriptValue::isFunction_initData): (tst_QScriptValue::isFunction_makeData): (tst_QScriptValue::isFunction_test): (tst_QScriptValue::isNull_initData): (tst_QScriptValue::isNull_makeData): (tst_QScriptValue::isNull_test): (tst_QScriptValue::isString_initData): (tst_QScriptValue::isString_makeData): (tst_QScriptValue::isString_test): (tst_QScriptValue::isUndefined_initData): (tst_QScriptValue::isUndefined_makeData): (tst_QScriptValue::isUndefined_test): (tst_QScriptValue::isObject_initData): (tst_QScriptValue::isObject_makeData): (tst_QScriptValue::isObject_test):
02:55 Changeset [54339] by vestbo@webkit.org

Make run-webkit-tests work under Cygwin for the Qt port

Reviewed by Simon Hausmann.

setPathForRunningWebKitApp() is implemented for the Qt port
by using qmake to query for the location of the Qt libraries.

This requires the original environment (%ENV) to be untouched,
so launchWithCurrentEnv() was refactored to launchWithEnv(),
and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
instead. This has the added benefit of getting rid of the temp
variables used for storing the current env.

openDumpTool() is also refactored a bit into platform-spesific,
port-spesific, and generic environment variables.

Checks for undef was added a few places to fix Perl concat
warnings when run-webkit-tests is aborted.

https://bugs.webkit.org/show_bug.cgi?id=33895

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
02:50 Changeset [54338] by ossy@webkit.org

[Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot
https://bugs.webkit.org/show_bug.cgi?id=34281

  • platform/qt/Skipped: fast/workers/shared-worker-frame-lifecycle.html skipped until fix.
02:50 Changeset [54337] by zecke@webkit.org

[Gtk] Check if the renderer() exists in textForObject.

This is fixing a crash in the textForObject method. It can
happen when inspecting AtkObjects in the accerciser, then
navigating to a new page and still inspecting the old tree.

In this case the AccessibilityObjectWrapperAtk was still
valid but the included renderer() was returning 0. Add a
check for the accObject->renderer() before trying to use
the result.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(textForObject):

02:20 Changeset [54336] by yuzo@google.com

2010-02-04 Yuzo Fujishima <yuzo@google.com>

Unreviewed.

Add Yuzo to the committers list.

  • Scripts/webkitpy/committers.py:
02:06 Changeset [54335] by yurys@chromium.org

2010-02-04 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert 54333 which broke Chromium build.

  • WebKit.gyp:
  • tests/TransparencyWinTest.cpp: Removed.
  • tests/UniscribeHelperTest.cpp: Removed.
01:38 Changeset [54334] by yurys@chromium.org

2010-02-04 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Provide strongly typed C++ interface for inspector's injected script.

https://bugs.webkit.org/show_bug.cgi?id=33616

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.cpp: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapAndStringifyForConsole): (WebCore::InjectedScript::releaseWrapperObjectGroup):
  • inspector/InjectedScript.h: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::~InjectedScript): (WebCore::InjectedScript::hasNoValue):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
01:16 Changeset [54333] by eric@webkit.org

2010-02-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin.
https://bugs.webkit.org/show_bug.cgi?id=34509

  • WebKit.gyp:
  • tests/TransparencyWinTest.cpp: Added. (WebCore::RECTToFloatRect): (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::operator<<): (WebCore::TEST):
  • tests/UniscribeHelperTest.cpp: Added. (WebCore::UniscribeTest::UniscribeTest): (WebCore::UniscribeTest::MakeFont): (WebCore::UniscribeTest::SetUp): (WebCore::UniscribeTest::TearDown): (WebCore::TEST_F):
01:11 Changeset [54332] by philn@webkit.org

2010-02-04 Philippe Normand <pnormand@igalia.com>

Rubber stamped by Xan Lopez.

Missing include, build fix after landing of patch from the bug 34435.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
00:41 Changeset [54331] by eric@webkit.org

2010-02-04 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by David Levin.

[Chromium] WebKit side of "Writing direction" context menu on OS X.
https://bugs.webkit.org/show_bug.cgi?id=34524

  • public/WebContextMenuData.h: (WebKit::WebContextMenuData::):
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
00:32 Changeset [54330] by philn@webkit.org

2010-02-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] libsoup critical warning in media player http cookies injection code
https://bugs.webkit.org/show_bug.cgi?id=34435

Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent nor Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
  • platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::SoupURI): (WTF::GstElement):
  • platform/gtk/GOwnPtrGtk.h: Added.
00:25 Changeset [54329] by eric@webkit.org

2010-02-04 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Put JSC-specific debugger & profiler code under "USE(JSC)" defines.
The plan is to enable "JAVASCRIPT_DEBUGGER" in Chromium and then
make this code engine-agnostic.

https://bugs.webkit.org/show_bug.cgi?id=34531

  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/JavaScriptCallFrame.cpp:
  • inspector/JavaScriptCallFrame.h:
  • inspector/JavaScriptDebugListener.h:
  • inspector/JavaScriptDebugServer.cpp:
  • inspector/JavaScriptDebugServer.h:
  • inspector/JavaScriptProfile.cpp:
  • inspector/JavaScriptProfile.h:
  • inspector/JavaScriptProfileNode.cpp:
  • inspector/JavaScriptProfileNode.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
  • page/Page.cpp: (WebCore::Page::Page):

02/03/10:

23:54 Changeset [54328] by dpranke@chromium.org

2010-02-03 Dirk Pranke <dpranke@chromium.org>

Rubber-stamped by Eric Seidel.

Change "the Chromium name" to "the name of Google Inc." in the licenses

https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/path_utils.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
23:51 Changeset [54327] by dpranke@chromium.org

2010-02-03 Dirk Pranke <dpranke@chromium.org>

Rubber-stamped by Eric Siedel.

Rename files as part of refactoring the layout_tests package. All
the platform_utils* module, the path_utils.py module, and
the http server and web socket server modules are moved into a new
port/ package.

https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/init.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
  • Scripts/webkitpy/layout_tests/port/http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server.py.
  • Scripts/webkitpy/layout_tests/port/http_server_base.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
  • Scripts/webkitpy/layout_tests/port/httpd2.pem: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
  • Scripts/webkitpy/layout_tests/port/lighttpd.conf: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
  • Scripts/webkitpy/layout_tests/port/path_utils.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
23:48 Changeset [54326] by eric@webkit.org

2010-02-03 Nicholas Young <nicholas.young@nokia.com>

Reviewed by Eric Carlson.

Defer formatting of times displayed on media controls to the current theme.
https://bugs.webkit.org/show_bug.cgi?id=34405

No new tests needed. Refactoring Only.

  • rendering/MediaControlElements.cpp: Removed formatTime() (WebCore::MediaControlTimeDisplayElement::setCurrentValue): No longer sets inner text
  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateTimeDisplay): Asks the theme to format the time display elements
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::formatMediaControlsTime): new virtual method (WebCore::RenderTheme::formatMediaControlsCurrentTime): new virtual method (WebCore::RenderTheme::formatMediaControlsRemainingTime): new virtual method
  • rendering/RenderTheme.h:
23:30 Changeset [54325] by ukai@chromium.org

Unreviewed fix.

websocket/tests/close-on-unload.html and
close-on-navigate-new-location.html will fail on mac tiger,
because python on the platform doesn't support set(), which is
used in websocket handler for these tests.

  • platform/mac-tiger/Skipped: skip websocket/tests/close-on-unload.html and websocket/tests/close-on-navigate-new-location.html
23:26 Changeset [54324] by ukai@chromium.org

2010-02-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

navigating a frame to new location closes websocket in the frame
https://bugs.webkit.org/show_bug.cgi?id=34557

  • websocket/tests/close-on-navigate-new-location-expected.txt: Added.
  • websocket/tests/close-on-navigate-new-location.html: Added.
21:52 Changeset [54323] by sfalken@apple.com

Windows Debug_All build fix.

  • platform/graphics/win/WKCACFLayer.cpp:
19:57 Changeset [54322] by mrowe@apple.com

Remove an unnecessary backup file.

19:28 Changeset [54321] by beidson@apple.com

REGRESSION (r51644): WebCore/manual-tests/linkjump-1.html fails
<rdar://problem/7595694> and https://bugs.webkit.org/show_bug.cgi?id=34550

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: fast/loader/document-with-fragment-url-1.html

fast/loader/document-with-fragment-url-2.html
fast/loader/document-with-fragment-url-3.html
fast/loader/document-with-fragment-url-4.html

  • platform/KURL.cpp:

(WebCore::KURL::init): When resolving new URL from an empty reference relative to an absolute URL,

any fragment identifier from the absolute URL should be removed from the resulting resolution.

LayoutTests:

  • fast/loader/document-with-fragment-url-1-expected.txt: Added.
  • fast/loader/document-with-fragment-url-1.html: Added.
  • fast/loader/document-with-fragment-url-2-expected.txt: Added.
  • fast/loader/document-with-fragment-url-2.html: Added.
  • fast/loader/document-with-fragment-url-3-expected.txt: Added.
  • fast/loader/document-with-fragment-url-3.html: Added.
  • fast/loader/document-with-fragment-url-4-expected.txt: Added.
  • fast/loader/document-with-fragment-url-4.html: Added.
  • fast/loader/resources/document-with-fragment-url-test.html: Added.
18:49 Changeset [54320] by eric@webkit.org

2010-02-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined
https://bugs.webkit.org/show_bug.cgi?id=34514

PLATFORM(BREWMP_SIMULATOR) guard is needed to make distinction between BREWMP
and BREWMP simulator.

  • wtf/Platform.h:
18:24 Changeset [54319] by ukai@chromium.org

2010-02-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket should close the connection when unloading the document
https://bugs.webkit.org/show_bug.cgi?id=33248

  • websocket/tests/close-on-unload-expected.txt: Added.
  • websocket/tests/close-on-unload.html: Added.
  • websocket/tests/close-on-unload_wsh.py: Added.
  • websocket/tests/resources/close-on-unload-iframe.html: Added.
18:23 Changeset [54318] by eric@webkit.org

2010-02-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port TextBreakIteratorInternalICU
https://bugs.webkit.org/show_bug.cgi?id=34515

Port TextBreakIteratorInternalICU.

  • platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Added. (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
17:52 Changeset [54317] by adele@apple.com

WebCore: Fix for <rdar://problem/7594212>
https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319

Reviewed by Simon Fraser.

Test: fast/css/counters/counter-before-selector-crash.html

  • rendering/RenderCounter.cpp: (WebCore::updateCounters): nil check.

LayoutTests: Test for: <rdar://problem/7594212>
https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319

Reviewed by Simon Fraser.

  • fast/css/counters/counter-before-selector-crash-expected.txt: Added.
  • fast/css/counters/counter-before-selector-crash.html: Added.
17:32 Changeset [54316] by adele@apple.com

Initialize the variable in the last checkin to false. I didn't realize DRT relies on this being false.
So ports that want visited link tracking need to set that flag.

Reviewed by Brady Eidson.

  • page/PageGroup.cpp:
17:09 Changeset [54315] by mrowe@apple.com

Merge r54311.

17:07 Changeset [54314] by ossy@webkit.org

Rubber-stamped by Eric Seidel.

Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399

  • Scripts/run-iexploder-tests:
  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
  • Scripts/webkitperl/httpd.pm: Added.
16:50 Changeset [54313] by adele@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=34547
static shouldTrackVisitedLinks is not initialized

Reviewed by Brady Eidson.

For ports that don't call into WebKit to initialize this,
we should initialize to true so they get the visited link behavior by default.

  • page/PageGroup.cpp:
16:32 Changeset [54312] by ossy@webkit.org

Rubber-stamped by Eric Seidel.

Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots

  • Scripts/run-iexploder-tests:
  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
  • Scripts/webkitperl/httpd.pm: Removed.
16:26 Changeset [54311] by mitz@apple.com

<rdar://problem/7577604> Drag and Drop: background elements are bleeding through
https://bugs.webkit.org/show_bug.cgi?id=34546

Reviewed by Simon Fraser.

  • manual-tests/drag-image-table-part-decorations.html: Added.
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
paint within the current painting root.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

16:19 Changeset [54310] by mrowe@apple.com

Build fix.

15:47 Changeset [54309] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Add wxWebKitWindowFeatures and have createWindow send a notification for
clients to handle.

https://bugs.webkit.org/show_bug.cgi?id=34542

15:31 Changeset [54308] by mrowe@apple.com

Merge r54083.

15:31 Changeset [54307] by ossy@webkit.org

Rubber-stamped by Ariya Hidayat.

Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399

WebKitTools:

  • DumpRenderTree/win/EventSender.cpp:

(buildModifierFlags):
(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):

LayoutTests:

  • platform/win/Skipped:
15:06 Changeset [54306] by japhet@chromium.org

2010-02-03 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium mac build fix.

[V8] Remove unused V8Proxy* variable from generated wrapping code.

  • bindings/scripts/CodeGeneratorV8.pm:
14:33 Changeset [54305] by japhet@chromium.org

2010-02-03 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.


https://bugs.webkit.org/show_bug.cgi?id=32563

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptObject.cpp:
  • bindings/v8/V8AbstractEventListener.cpp:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8NodeFilterCondition.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/WorkerContextExecutionProxy.h
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8CustomPositionCallback.cpp:
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8DocumentLocationCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8MessageEventCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NodeIteratorCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGMatrixCustom.cpp:
  • bindings/v8/custom/V8StyleSheetListCustom.cpp:
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
14:32 Changeset [54304] by eric@webkit.org

2010-02-03 Eric Seidel <eric@webkit.org>

No review, just fixing copyrights.

Concerns were expressed about "The Chromium Authors" being
a valid legal entity for copyright assignment in the WebKit repository,
so this change removes all "The Chromium Authors".

I looked at the svn logs in src.chromium.org and failed to find any
non-google contributions to these files, so they are all now
marked as copyright "Google Inc" as all Google contributers assign
copyright to "Google Inc" as part of their employment agreement.

  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/run-chromium-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/layout_package/http_server.py:
  • Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
14:26 Changeset [54303] by mrowe@apple.com

Merge r48879.

14:26 Changeset [54302] by mrowe@apple.com

Merge r48374.

14:26 Changeset [54301] by mrowe@apple.com

Merge r48364.

14:26 Changeset [54300] by mrowe@apple.com

Merge r48363.

14:23 Changeset [54299] by weinig@apple.com

Fix drawing buttons in viewless WebKit.

Reviewed by Anders Carlsson.

  • platform/mac/ThemeMac.mm:

(WebCore::paintButton): If there is no view, make sure to flip the
context so that the button is drawn correctly.

14:00 Changeset [54298] by yael.aharon@nokia.com

[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
https://bugs.webkit.org/show_bug.cgi?id=34425

Reviewed by Kenneth Rohde Christiansen.

Reverting r54279, it was a misunderstanding.

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:
13:44 Changeset [54297] by kenneth@webkit.org

[Qt] QtLauncher, refactor argument handling in preparation of merge
with QGVLauncher

Reviewed by Ariya Hidayat.

  • QtLauncher/main.cpp:

(LauncherApplication::urls):
(LauncherApplication::isRobotized):
(LauncherApplication::applyDefaultSettings):
(LauncherApplication::LauncherApplication):
(LauncherApplication::formatKeys):
(LauncherApplication::enumToKeys):
(fail):
(LauncherApplication::handleUserOptions):
(main):

13:43 Changeset [54296] by eric@webkit.org

2010-02-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Remove COMPILE_ASSERT conflict with the underlying PLATFORM
https://bugs.webkit.org/show_bug.cgi?id=34190

COMPILE_ASSERT conflicts with the underlying PLATFORM because it is defined
both in WTF's Assertions.h and BREWMP's AEEClassIDs.h. Include AEEClassIDs.h
in Assertions.h and undef COMPILE_ASSERT to avoid redefining COMPILE_ASSERT.

  • wtf/Assertions.h:
13:19 Changeset [54295] by ossy@webkit.org

Rubber-stamped by Ariya Hidayat.

Rolling out r53889, because it might caused flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399

WebKitTools:

  • DumpRenderTree/win/EventSender.cpp:

(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):

LayoutTests:

  • platform/win/Skipped:
13:17 Changeset [54294] by eric@webkit.org

2010-02-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed.
https://bugs.webkit.org/show_bug.cgi?id=34518

Add OwnPtrBrew to release IFile, IFileMgr and IBitmap instances.

  • wtf/brew/OwnPtrBrew.cpp: Added. (WTF::IFileMgr): (WTF::IFile): (WTF::IBitmap): (WTF::freeOwnedPtrBrew):
  • wtf/brew/OwnPtrBrew.h: Added. (WTF::OwnPtrBrew::OwnPtrBrew): (WTF::OwnPtrBrew::~OwnPtrBrew): (WTF::OwnPtrBrew::get): (WTF::OwnPtrBrew::release): (WTF::OwnPtrBrew::outPtr): (WTF::OwnPtrBrew::set): (WTF::OwnPtrBrew::clear): (WTF::OwnPtrBrew::operator*): (WTF::OwnPtrBrew::operator->): (WTF::OwnPtrBrew::operator!): (WTF::OwnPtrBrew::operator UnspecifiedBoolType): (WTF::OwnPtrBrew::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr):
12:58 Changeset [54293] by bweinstein@apple.com

Scroll does not work with IBM Thinkpad.
<https://bugs.webkit.org/show_bug.cgi?id=14227>
<rdar://7142545>

Reviewed by Steve Falkenburg.

When initializing the WebView, add two scrollbar Windows inside of
our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events.
(similar to what Firefox did in: <https://bugzilla.mozilla.org/show_bug.cgi?id=507222>.

Only do this if the user has installed some kind of Trackpoint driver, using an algorithm
like <https://bugzilla.mozilla.org/show_bug.cgi?id=514927>.

Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll
the WebView.

  • WebView.cpp:

(WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down

by lines or pages.

(WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right

by lines or pages.

(WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL.
(WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create

vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages.

(WebView::shouldInitializeTrackPointHack): Check if there is a registry key for

the some kind of IBM Trackpoint driver.

  • WebView.h:
12:14 Changeset [54292] by eric@webkit.org

2010-02-03 Drew Wilson <atwilson@chromium.org>

Reviewed by Alexey Proskuryakov.

SharedWorkerScriptLoader should not be an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=34513

Test: Existing tests suffice (fixes test downstream in Chrome).

  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to no longer derive from ActiveDOMObject (handles its own refcounting). (WebCore::SharedWorkerScriptLoader::load): Now increments own refcount when a load is pending. (WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to decrement refcount when load is complete.
  • workers/WorkerScriptLoaderClient.h: Documentation change about reliability of notifyFinished() when used from worker context.

2010-02-03 Drew Wilson <atwilson@chromium.org>

Reviewed by Alexey Proskuryakov.

SharedWorkerScriptLoader should not be an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=34513

  • src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed SharedWorkerScriptLoader to manage its own lifecycle without using ActiveDOMObject. (WebCore::SharedWorkerScriptLoader::parentContext): (WebCore::pendingLoaders): Now we manually track pending loads so we can shut them down when the parent context shuts down. (WebCore::SharedWorkerScriptLoader::contextDetached): Shuts down/frees any pending worker loads. (WebCore::SharedWorkerScriptLoader::~SharedWorkerScriptLoader): Marks the SharedWorker object as not having pending activity if there was a load active (handles case where load was pending when parent document exits). (WebCore::SharedWorkerScriptLoader::load): (WebCore::SharedWorkerRepository::documentDetached): Now calls SharedWorkerScriptLoader::contextDetached() to shutdown any pending worker loads.
11:57 Changeset [54291] by eric@webkit.org

2010-02-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Inspector renders blank scripts on reloading the webpage.

https://bugs.webkit.org/show_bug.cgi?id=34537

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
11:41 Changeset [54290] by eric@webkit.org

2010-02-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Export WTF::fastStrDup symbol
https://bugs.webkit.org/show_bug.cgi?id=34526

11:39 Changeset [54289] by ossy@webkit.org

[Qt] Fix pixel tests support.
https://bugs.webkit.org/show_bug.cgi?id=27813

Reviewed by Ariya Hidayat.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):

  • Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.

(WebCore::DumpRenderTree::dump): Fixed and renamed variables.

11:02 Changeset [54288] by mitz@apple.com

Fixed a bug where WKSetNSURLConnectionDefersCallbacks(true) did not defer callbacks during modal dialogs.

Reviewed by Anders Carlsson.

  • libWebKitSystemInterfaceLeopard.a:
10:52 Changeset [54287] by kevino@webkit.org

Reviewed by Kevin Ollivier.

[wx] Enable JIT compilation for wx.

https://bugs.webkit.org/show_bug.cgi?id=34536

10:26 Changeset [54286] by yurys@chromium.org

2010-02-03 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert r54285 which failed to compile on Linux GTK.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.cpp: Removed.
  • inspector/InjectedScript.h: Removed.
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
10:11 Changeset [54285] by yurys@chromium.org

2010-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Provide strongly typed C++ interface for inspector's injected script.

https://bugs.webkit.org/show_bug.cgi?id=33616

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.cpp: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapAndStringify): (WebCore::InjectedScript::releaseWrapperObjectGroup):
  • inspector/InjectedScript.h: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::~InjectedScript): (WebCore::InjectedScript::hasNoValue):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
10:02 Changeset [54284] by abecsi@webkit.org

Unreviewed build fix.

[Qt] Roll-out r54281 because it broke the build on the Qt Release bot.

09:48 Changeset [54283] by eric@webkit.org

2010-02-03 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

[Chromium] Return a consistent set of platforms from WebDevToolsFrontendImpl
https://bugs.webkit.org/show_bug.cgi?id=34523

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::jsPlatform):
08:09 Changeset [54282] by levin@chromium.org

2010-02-02 Bryan Yeung <bryeung@google.com>

Reviewed by Darin Adler.

Avoid using an invalidated KURL object in baseURI.

https://bugs.webkit.org/show_bug.cgi?id=34492

This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg

This is a re-application of this patch since it was mistakenly identified as
the cause of a big chromium test regression and rolled out in r54264.

  • dom/Element.cpp: (WebCore::Element::baseURI):
08:01 Changeset [54281] by eric@webkit.org

2010-02-03 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.

https://bugs.webkit.org/show_bug.cgi?id=34062

This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs (WebCore::OpacityAnimationQt::updateState): style change

2010-02-03 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
of QTimer::singleShot, and moved syncLayers() from paint() to update()
https://bugs.webkit.org/show_bug.cgi?id=34062

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update): Moved the sync operation to update (QGraphicsWebView::paint): Moved the sync operation to update
07:37 Changeset [54280] by levin@chromium.org

WebCore: [Chromium] Make setCaretBlinkInterval static.
https://bugs.webkit.org/show_bug.cgi?id=31704

Patch by Joel Stanley <joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.

This is so it can be called from the newly exposed Chromium API setter
method.

  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:

WebKit/chromium: [Chromium] Add API method for setting caret blink frequency.
https://bugs.webkit.org/show_bug.cgi?id=31704

Patch by Joel Stanley <joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.

This enables the RenderThemeChromiumLinux::setCaretBlinkInterval method
to be called Chromium's API. The API is linux-only as it is currently
the only port to implement RenderTheme::setCaretBlinkInterval.

  • WebKit.gyp: Add WebRenderTheme.{h,cpp}
  • public/linux/WebRenderTheme.h: Added.
  • src/linux/WebRenderTheme.cpp: Added.

(WebKit::setCaretBlinkInterval): Exposed API

05:42 Changeset [54279] by yael.aharon@nokia.com

[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
https://bugs.webkit.org/show_bug.cgi?id=34425

Reviewed by Kenneth Rohde Christiansen.

Buffer the sent data in SocketStreamHandlePrivate instead of relying on
the network layer to do it. This is more robust and more consistent with how
Qt's HTTP stack works.
Close the socket in SocketStreamHandlePrivate::close() regardless of its state.

No new tests, since no new functionality is introduced.

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:
05:02 Changeset [54278] by hamaji@chromium.org

2010-02-03 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed revert of r54259 as it seems to break chromium's unit tests.
The tests pass with r54257 but fail with r54260.
As r54258 and r54260 don't touch code, I'm reverting this change.

[V8] Generate toV8 conversion helpers, a la JSC bindings.
https://bugs.webkit.org/show_bug.cgi?id=32563

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
  • bindings/v8/V8Collection.h: (WebCore::getV8Object): (WebCore::toNativeCollection): (WebCore::getNamedPropertyOfCollection): (WebCore::collectionNamedPropertyGetter): (WebCore::getIndexedPropertyOfCollection): (WebCore::collectionIndexedPropertyGetter): (WebCore::nodeCollectionIndexedPropertyEnumerator): (WebCore::collectionIndexedPropertyEnumerator): (WebCore::collectionStringOrNullIndexedPropertyGetter): (WebCore::collectionStringIndexedPropertyGetter): (WebCore::setCollectionIndexedGetter): (WebCore::setCollectionNamedGetter): (WebCore::setCollectionStringOrNullIndexedGetter): (WebCore::setCollectionStringIndexedGetter):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::downcastSVGPathSeg): (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toV8Object): (WebCore::V8CanvasRenderingContext2D::createPatternCallback):
  • bindings/v8/custom/V8CustomPositionCallback.cpp: (WebCore::V8CustomPositionCallback::handleEvent):
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp: (WebCore::V8CustomPositionErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp: (WebCore::V8CustomSQLStatementCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: (WebCore::V8CustomSQLTransactionCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openCallback): (WebCore::V8DOMWindow::indexedPropertyGetter): (WebCore::V8DOMWindow::namedPropertyGetter):
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::evaluateCallback): (WebCore::V8Document::getCSSCanvasContextCallback): (WebCore::V8Document::implementationAccessorGetter):
  • bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorGetter):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNodeNSCallback):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::V8Event::dataTransferAccessorGetter): (WebCore::V8Event::clipboardDataAccessorGetter):
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLAllCollection::callAsFunctionCallback):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::V8Custom::v8HTMLAudioElementConstructorCallback):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLCollection::callAsFunctionCallback):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorGetter):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::V8HTMLFormElement::indexedPropertyGetter): (WebCore::V8HTMLFormElement::namedPropertyGetter):
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: (WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::V8Custom::v8HTMLImageElementConstructorCallback):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::V8HTMLSelectElement::namedPropertyGetter): (WebCore::V8HTMLSelectElement::indexedPropertyGetter):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScript): (WebCore::V8InjectedScriptHost::nodeForIdCallback): (WebCore::V8InjectedScriptHost::databaseForIdCallback):
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::portsAccessorGetter):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::indexedPropertyGetter): (WebCore::V8NamedNodeMap::namedPropertyGetter):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::V8NodeList::namedPropertyGetter): (WebCore::V8NodeList::callAsFunctionCallback):
  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::V8SVGMatrix::multiplyCallback): (WebCore::V8SVGMatrix::inverseCallback): (WebCore::V8SVGMatrix::rotateFromVectorCallback):
  • bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::V8StyleSheetList::namedPropertyGetter):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8Object):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::V8XSLTProcessor::transformToFragmentCallback): (WebCore::V8XSLTProcessor::transformToDocumentCallback):
02:54 Changeset [54277] by eric@webkit.org

2010-02-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Start unforking debugger and profiler code.

Remove custom implementation of Console.
Add 'ScriptProfiler' and 'ScriptProfile' types.
Start migration to engine-neutral types in InspectorController.

https://bugs.webkit.org/show_bug.cgi?id=34481

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/ScriptProfile.h: Added.
  • bindings/js/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
  • bindings/js/ScriptProfiler.h: Added.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptProfile.h: Added. (WebCore::ScriptProfile::create): (WebCore::ScriptProfile::~ScriptProfile): (WebCore::ScriptProfile::title): (WebCore::ScriptProfile::uid): (WebCore::ScriptProfile::ScriptProfile):
  • bindings/v8/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
  • bindings/v8/ScriptProfiler.h: Added.
  • bindings/v8/custom/V8ConsoleCustom.cpp: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::endGroup): (WebCore::InspectorController::show): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::createProfileHeader): (WebCore::InspectorController::getCurrentUserInitiatedProfileName): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::specialPanelForJSName):
  • inspector/InspectorController.h: (WebCore::InspectorController::searchingForNodeInPage):
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
  • page/Console.h: (WebCore::): (WebCore::Console::create): (WebCore::Console::profiles):
  • page/Console.idl:
02:13 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
01:50 Changeset [54276] by mnaganov@chromium.org

Add myself to commiters.py

00:11 Changeset [54275] by ossy@webkit.org

Rubber-stamped by Adam Barth.

http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349

  • platform/win/Skipped: http/tests/security/xss-DENIED-window-open-javascript-url.html skipped.

02/02/10:

22:56 Changeset [54274] by tkent@chromium.org

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that changes for some constraint attributes doesn't
update validation CSS selectors.
https://bugs.webkit.org/show_bug.cgi?id=31716

Add tests for maxLength changes and step changes.

  • fast/forms/input-live-pseudo-selectors-expected.txt:
  • fast/forms/resources/input-live-pseudo-selectors.js:
  • fast/forms/resources/textarea-live-pseudo-selectors.js:
  • fast/forms/textarea-live-pseudo-selectors-expected.txt:

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that changes for some constraint attributes doesn't
update validation CSS selectors.
https://bugs.webkit.org/show_bug.cgi?id=31716

  • Rename HTMLFormControlElement::updateValidity() to setNeedsValidityCheck()
  • Introduce HTMLFormControlElement::setNeedsWillValidate()
  • Introduce HTMLFormControlElement::m_hasName to make willValidate() work in parseMappedAttribute().
  • We need to call setNeedsValidityCheck() when HTMLInputElement::step or HTMLTextAreaElement::maxLength is changed.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::insertedIntoTree): (WebCore::HTMLFormControlElement::removedFromTree): (WebCore::HTMLFormControlElement::formDestroyed): (WebCore::HTMLFormControlElement::willValidate): Avoids function calls. (WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): (WebCore::HTMLFormControlElement::setNeedsValidityCheck):
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::disabled): Move the code from .cpp.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setValueFromRenderer): (WebCore::HTMLInputElement::setFileListFromRenderer):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::setValue):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
21:57 Changeset [54273] by rolandsteiner@chromium.org

Bug 34198 - Ruby text should not inherit line-height
(https://bugs.webkit.org/show_bug.cgi?id=34198)

Reviewed by Adele Peterson.

Resetting line-height to 'normal' in the default UA style sheet.
Adding layout-test to check for this.

WebCore:

Test: fast/ruby/ruby-line-height.html

  • css/html.css:

LayoutTests:

  • fast/ruby/script-tests: Added.
  • fast/ruby/script-tests/ruby-line-height.js: Added.
  • fast/ruby/ruby-line-height-expected.txt: Added.
  • fast/ruby/ruby-line-height.html: Added.
21:22 Changeset [54272] by eric@webkit.org

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483

Add tests for datetime, datetime-local, month, time and week, and
merge existing tests into one test file.

  • fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-date.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-number.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-range.html: Removed.
  • fast/forms/ValidityState-rangeOverflow.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-date.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow.html: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.

2010-02-02 James Robinson <jamesr@chromium.org>

Reviewed by Dmitry Titov.

Add a null check for image, which might be NULL if tileSize is empty
https://bugs.webkit.org/show_bug.cgi?id=34510

Test: fast/gradients/crash-on-1px-border.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
20:21 Changeset [54271] by tkent@chromium.org

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483

Add tests for datetime, datetime-local, month, time and week, and
merge existing tests into one test file.

  • fast/forms/ValidityState-rangeOverflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-date.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-number.html: Removed.
  • fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeOverflow-range.html: Removed.
  • fast/forms/ValidityState-rangeOverflow.html: Added.
  • fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-date.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-expected.txt: Added.
  • fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
  • fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
  • fast/forms/ValidityState-rangeUnderflow.html: Added.
  • fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeOverflow.js: Added.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js: Added.

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

rangeOverflow/rangeUnderflow support for type=datetime, datetime-local,
month, time and week
https://bugs.webkit.org/show_bug.cgi?id=34483

Tests: fast/forms/ValidityState-rangeOverflow.html

fast/forms/ValidityState-rangeUnderflow.html

  • html/HTMLInputElement.cpp: Defines the hard limits for the types as double values. (WebCore::HTMLInputElement::rangeUnderflow): Supports the types. (WebCore::HTMLInputElement::rangeOverflow): Supports the types. (WebCore::HTMLInputElement::minimum): Supports the types. (WebCore::HTMLInputElement::maximum): Supports the types.
20:20 Changeset [54270] by hamaji@chromium.org

2010-02-02 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Implement WebFrameImpl::pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34471

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageNumberForElementById):
  • src/WebFrameImpl.h:
20:00 Changeset [54269] by kevino@webkit.org

[wx] Build fix after introduction of pageNumberForElementById.

19:42 Changeset [54268] by mrowe@apple.com

Roll out r54252.

The method it deleted is in fact used, and its deletion resulted in plug-ins that use accelerated compositing not being drawn.

17:36 Changeset [54267] by ukai@chromium.org

2010-02-02 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket wrapper can be collected even if events are pending
https://bugs.webkit.org/show_bug.cgi?id=34014

  • websocket/tests/websocket-pending-activity-expected.txt: Added.
  • websocket/tests/websocket-pending-activity.html: Added.

2010-02-02 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket set pending activity to avoid unexpected GC.
https://bugs.webkit.org/show_bug.cgi?id=34014

Test: websocket/tests/websocket-pending-activity.html

  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect): set pending activity until it receives didClose. (WebCore::WebSocket::contextDestroyed): check socket is already closed. (WebCore::WebSocket::stop): close the connection and unset pending activity when it stops. (WebCore::WebSocket::didClose): unset pending activity.
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData): protect this while it processes received data.
17:21 Changeset [54266] by kov@webkit.org

2010-02-02 Gustavo Noronha Silva <gns@gnome.org>

No review, rolling out r54261.
http://trac.webkit.org/changeset/54261
https://bugs.webkit.org/show_bug.cgi?id=34435

Causes crashes on release builds

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
  • platform/gtk/GOwnPtrGtk.cpp: Removed.
  • platform/gtk/GOwnPtrGtk.h: Removed.
17:13 Changeset [54265] by oliver@apple.com

2010-02-02 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Crash in CollectorBitmap::get at nbcolympics.com
https://bugs.webkit.org/show_bug.cgi?id=34504

This was caused by the use of m_offset to determine the offset of
a new property into the property storage. This patch corrects
the effected cases by incorporating the anonymous slot count. It
also removes the duplicate copy of anonymous slot count from the
property table as keeping this up to date merely increased the
chance of a mismatch. Finally I've added a large number of
assertions in an attempt to prevent such a bug from happening
again.

With the new assertions in place the existing anonymous slot tests
all fail without the m_offset fixes.

  • runtime/PropertyMapHashTable.h:
  • runtime/Structure.cpp: (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::removePropertyTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::removePropertyWithoutTransition): (JSC::Structure::copyPropertyTable): (JSC::Structure::get): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable): (JSC::Structure::rehashPropertyMapHashTable): (JSC::Structure::checkConsistency):
17:12 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
16:54 Changeset [54264] by levin@chromium.org

2010-02-02 David Levin <levin@chromium.org>

No review, rolling out r54245.
http://trac.webkit.org/changeset/54245
https://bugs.webkit.org/show_bug.cgi?id=34492

This patch seems to have broken thousands of chromium tests on
Windows (and since it was for chromium, I'm rolling it out).

  • dom/Element.cpp: (WebCore::Element::baseURI):
16:25 Changeset [54263] by sfalken@apple.com

2010-02-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503

2010-02-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503

  • win/tools/scripts/auto-version.sh:

2010-02-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503

  • WebKit.vcproj/WebKit.rc:

2010-02-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503

  • WebCore.vcproj/QTMovieWin.rc:
16:05 Changeset [54262] by dglazkov@chromium.org

2010-02-02 Dimitri Glazkov <dglazkov@chromium.org>

No review, rolling out r54257.
http://trac.webkit.org/changeset/54257
https://bugs.webkit.org/show_bug.cgi?id=34491

[Chromium] broke thousands of Win tests and a few of Linux tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::applyAntiAliasedClipPaths):
  • platform/graphics/skia/PlatformContextSkia.h:
16:03 Changeset [54261] by eric@webkit.org

2010-02-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] libsoup critical warning in media player http cookies injection code
https://bugs.webkit.org/show_bug.cgi?id=34435

Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent not Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
  • platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::SoupURI): (WTF::GstElement):
  • platform/gtk/GOwnPtrGtk.h: Added.
15:37 Changeset [54260] by kov@webkit.org

2010-02-02 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Bump version, and adjust library versioning for 1.1.20.

  • configure.ac:

WebKit/gtk

2010-02-02 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Changes in 1.1.20, and documentation control files update.

  • NEWS:
  • docs/webkitgtk-docs.sgml:
15:23 Changeset [54259] by japhet@chromium.org

2010-02-02 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.


https://bugs.webkit.org/show_bug.cgi?id=32563

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptObject.cpp:
  • bindings/v8/V8AbstractEventListener.cpp:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8NodeFilterCondition.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8CustomPositionCallback.cpp:
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8DocumentLocationCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8MessageEventCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NodeIteratorCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGMatrixCustom.cpp:
  • bindings/v8/custom/V8StyleSheetListCustom.cpp:
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
15:16 Changeset [54258] by snej@chromium.org

Clarified coding guidelines on wiki to allow indentation of _nested_ namespaces.
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=32137

15:06 Changeset [54257] by eric@webkit.org

2010-02-02 Garret Kelly <gdk@chromium.org>

Reviewed by David Levin.

When using the Skia graphics context, the beginTransparencyLayer call
currently creates a new layer, but does not keep the current
compositing mode for use when merging the created layer back onto the
rest of the context. This patch fixes that.
https://bugs.webkit.org/show_bug.cgi?id=34491

fast/backgrounds/svg-as-mask.html is affected by this change in Chromium,
but not fixed. This is the first of a series of patches to fix it.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::beginTransparencyLayer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::beginTransparencyLayer):
  • platform/graphics/skia/PlatformContextSkia.h:
14:50 Changeset [54256] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

Use WTF::getLocalTime instead of localtime_r in FTPDirectoryDocument
https://bugs.webkit.org/show_bug.cgi?id=34409

Platform guards for localtime_r are not needed because we already have
WTF::getLocalTime which does the same thing.

  • loader/FTPDirectoryDocument.cpp: (WebCore::processFileDateString):
  • loader/FTPDirectoryParser.cpp: (WebCore::gmtimeQt):
14:34 Changeset [54255] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add dummy main thread functions
https://bugs.webkit.org/show_bug.cgi?id=33569

Add dummy initializeMainThreadPlatform and
scheduleDispatchFunctionsOnMainThread.

  • wtf/brew/MainThreadBrew.cpp: Added. (WTF::initializeMainThreadPlatform): (WTF::scheduleDispatchFunctionsOnMainThread):
14:29 Changeset [54254] by eric@webkit.org

2010-02-02 Eric Seidel <eric@webkit.org>

Reviewed by Gustavo Noronha Silva.

http/tests/incremental/split-hex-entities.pl timed out on Gtk Linux 32-bit Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33445

  • platform/gtk/Skipped: Skip this test to keep the bots green until someone with Gtk knowledge can examine why it intermittently times out.
14:18 Changeset [54253] by eric@webkit.org

2010-02-02 Hayato Ito <hayato@chromium.org>

Reviewed by Darin Adler.

Move misplaced JS files to the proper location.

https://bugs.webkit.org/show_bug.cgi?id=34256

  • fast/events/script-tests/basic-touch-events.js: Removed.
  • fast/events/script-tests/create-touch-event.js: Removed.
  • fast/events/script-tests/send-oncancel-event.js: Removed.
  • fast/events/touch/basic-touch-events.html:
  • fast/events/touch/create-touch-event.html:
  • fast/events/touch/script-tests: Added.
  • fast/events/touch/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/events/script-tests/TEMPLATE.html.
  • fast/events/touch/script-tests/basic-touch-events.js: Copied from LayoutTests/fast/events/script-tests/basic-touch-events.js.
  • fast/events/touch/script-tests/create-touch-event.js: Copied from LayoutTests/fast/events/script-tests/create-touch-event.js.
  • fast/events/touch/script-tests/send-oncancel-event.js: Copied from LayoutTests/fast/events/script-tests/send-oncancel-event.js.
  • fast/events/touch/send-oncancel-event.html:
14:00 Changeset [54252] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=34502
Unused method pluginLayer in Netscape plug-in views

  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: Removed the method.
13:23 Changeset [54251] by mrowe@apple.com

Merge r54242.

13:09 Changeset [54250] by aroben@apple.com

Copy WebCore's bindings generation scripts to the PrivateHeaders directory on Mac

This will allow other projects to use these scripts.

Fixes <http://webkit.org/b/34498>.

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj: Added the bindings generation

scripst to the Copy Headers phase, and marked them as Private.

12:55 Changeset [54249] by aroben@apple.com

Copy WebCore's bindings generation scripts to a more sensible location

Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

Instead of copying to obj/WebKit/DOMInterfaces, copy to obj/WebCore/scripts.

12:54 Changeset [54248] by aroben@apple.com

Rename the scripts used to copy WebCore's bindings generation scripts

Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/MigrateScripts: Renamed from WebCore/WebCore.vcproj/MigrateIDLAndScripts.
  • WebCore.vcproj/migrate-scripts.sh: Renamed from WebCore/WebCore.vcproj/migrate-idls.sh.
  • WebCore.vcproj/WebCoreGenerated.vcproj: Updated for renames.
12:54 Changeset [54247] by aroben@apple.com

Stop copying IDL files into $(WebKitOutputDir)

No one uses these anymore (as of r52921).

Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/MigrateIDLAndScripts: Don't copy the IDL files

anymore. Keep copying the scripts, though, since other projects
(outside of the WebKit repository) do use those.

12:54 Changeset [54246] by aroben@apple.com

Stop copying WebCore's IDL files from SRCROOT to OBJROOT

WebKit doesn't use these anymore (as of r52921).

Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>

Reviewed by Steve Falkenburg.

  • WebKit.vcproj/WebKit.make:
12:04 Changeset [54245] by eric@webkit.org

2010-02-02 Bryan Yeung <bryeung@bryeung-chrome.(none)>

Reviewed by Darin Adler.

Avoid using an invalidated KURL object in baseURI.

https://bugs.webkit.org/show_bug.cgi?id=34492

This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg

  • dom/Element.cpp: (WebCore::Element::baseURI):
11:47 Changeset [54244] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Add using WTF::getLocalTime to CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=34493

  • wtf/CurrentTime.h:
10:16 Changeset [54243] by chang.shu@nokia.com

Add myself to list of committers.

10:00 Changeset [54242] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=34076
<rdar://problem/7594601> Crash in mangleme in WebCore::Element::getAttribute

Test: fast/forms/misplaced-img-form-registration.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerImgElement): Assert that the same image isn't added to vector again. (WebCore::HTMLFormElement::removeImgElement): Similarly, assert that we're removing something that's actually registered.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::~HTMLImageElement): If parser fails to insert the image element, then there will be no removed from tree notification either, need to unregister right away.
09:19 Changeset [54241] by kenneth@webkit.org

Do not use a proxy widget for the QComboBox on Maemo 5, as it
is not working properly and it is not needed at all, as the
comboboxes comes up in their full width on the screen and
do not depend on view.

Reviewed by Ariya Hidayat.

  • WebCoreSupport/QtFallbackWebPopup.cpp:

(WebCore::QtFallbackWebPopup::show):

09:08 Changeset [54240] by apavlov@chromium.org

2010-02-02 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Eliminate some of the platform flavor-specific stylesheet selectors

Extract OS version into WebInspector.platformFlavor
https://bugs.webkit.org/show_bug.cgi?id=34469

  • inspector/front-end/InspectorBackendStub.js:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.platform):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.pendingDispatches.0.URLRegExp.i.get platform): (WebInspector.get platformFlavor): (WebInspector._detectPlatformFlavor): (WebInspector.loaded): (WebInspector.toolbarDragStart): (WebInspector.isMac):
08:35 Changeset [54239] by mrobinson@webkit.org

2010-02-02 Martin Robinson <mrobinson@webkit.org>

Unreviewed build fix.

The WinCairo build requires this script to be executable.

  • win/tools/scripts/feature-defines.sh: Added property svn:executable.
07:48 Changeset [54238] by aroben@apple.com

Stop skipping some tests that were failing due to buggy versions of CFNetwork

Rubber-stamped by Eric Carlson.

  • platform/win/Skipped:
07:45 Changeset [54237] by eric@webkit.org

2010-02-02 Steve Block <steveblock@google.com>

Reviewed by Ariya Hidayat.

Adds utility functions for converting between JavaInstance and NPAPI types
https://bugs.webkit.org/show_bug.cgi?id=34468

This is required by Android for injecting objects into V8 JavaScript.

No new tests, added utility functions only.

  • Android.v8bindings.mk: Modified. Added JavaNPObjectV8.cpp
  • bridge/jni/v8/JavaNPObjectV8.cpp: Added. (JSC::Bindings::AllocJavaNPObject): (JSC::Bindings::FreeJavaNPObject): (JSC::Bindings::): (JSC::Bindings::JavaInstanceToNPObject): (JSC::Bindings::ExtractJavaInstance): (JSC::Bindings::JavaNPObjectHasMethod): (JSC::Bindings::JavaNPObjectInvoke): (JSC::Bindings::JavaNPObjectHasProperty): (JSC::Bindings::JavaNPObjectGetProperty):
  • bridge/jni/v8/JavaNPObjectV8.h: Added.
07:42 QtWebKitJSCapp edited by siddharth.mathur@nokia.com
(diff)
07:35 QtWebKitJSCapp created by siddharth.mathur@nokia.com
07:35 Changeset [54236] by jberlin@webkit.org

2010-02-02 Jessie Berlin <jberlin@webkit.org>

Rubber Stamped by Holger Freyther.

[Qt] Fix style issue identified in bug:
https://bugs.webkit.org/show_bug.cgi?id=34329

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::InspectorClientWebPage): Fix indentation.
07:31 QtWebKit edited by siddharth.mathur@nokia.com
added new page for jsc.exe (diff)
07:29 Changeset [54235] by eric@webkit.org

2010-02-02 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Symbian plugins include a wrong header file for QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34475

  • plugins/symbian/PluginViewSymbian.cpp:
07:28 Changeset [54234] by cjerdonek@webkit.org

2010-02-02 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Moved filter-related check-webkit-style code into a separate
filter module.

https://bugs.webkit.org/show_bug.cgi?id=34408

This is preparatory refactoring for Bug 33684, which will allow
file and folder-specific filter rules.

  • Scripts/webkitpy/style/checker.py:
    • Removed CategoryFilter class (moved to filter.py).
  • Scripts/webkitpy/style/checker_unittest.py:
    • Removed CategoryFilter unit tests (moved to filter_unittest.py).
  • Scripts/webkitpy/style/filter.py: Added.
    • Added CategoryFilter class (moved from checker.py).
  • Scripts/webkitpy/style/filter_unittest.py: Added.
    • Added CategoryFilter unit tests (moved from checker_unittest.py).
  • Scripts/webkitpy/style/unittests.py:
    • Added reference to filter_unittest.py.
07:25 Changeset [54233] by jberlin@webkit.org

2010-02-01 Jessie Berlin <jberlin@webkit.org>

Reviewed by Holger Freyther.

[Qt] Enable inspecting the Web Inspector in QtLauncher

https://bugs.webkit.org/show_bug.cgi?id=34329

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::InspectorClientWebPage): Allow the DeveloperExtrasEnabled setting to default to true for the page containing the Web Inspector.
06:22 Changeset [54232] by yurys@chromium.org

2010-02-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Upstream DevTools code.

https://bugs.webkit.org/show_bug.cgi?id=34326

  • WebKit.gyp:
  • src/APUAgentDelegate.h: Added.
  • src/BoundObject.cpp: Added. (WebKit::BoundObject::BoundObject): (WebKit::BoundObject::~BoundObject): (WebKit::BoundObject::addProtoFunction): (WebKit::BoundObject::build):
  • src/BoundObject.h: Added.
  • src/DebuggerAgent.h: Added.
  • src/DebuggerAgentImpl.cpp: Added. (WebKit::DebuggerAgentImpl::DebuggerAgentImpl): (WebKit::DebuggerAgentImpl::~DebuggerAgentImpl): (WebKit::DebuggerAgentImpl::getContextId): (WebKit::DebuggerAgentImpl::debuggerOutput): (WebKit::DebuggerAgentImpl::createUtilityContext): (WebKit::DebuggerAgentImpl::executeUtilityFunction): (WebKit::DebuggerAgentImpl::executeVoidJavaScript): (WebKit::DebuggerAgentImpl::page):
  • src/DebuggerAgentImpl.h: Added. (WebKit::DebuggerAgentImpl::setAutoContinueOnException): (WebKit::DebuggerAgentImpl::autoContinueOnException): (WebKit::DebuggerAgentImpl::webdevtoolsAgent): (WebKit::DebuggerAgentImpl::webView):
  • src/DebuggerAgentManager.cpp: Added. (WebKit::DebuggerAgentManager::debugHostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::onV8DebugMessage): (WebKit::DebuggerAgentManager::pauseScript): (WebKit::DebuggerAgentManager::executeDebuggerCommand): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler): (WebKit::DebuggerAgentManager::setHostId): (WebKit::DebuggerAgentManager::onWebViewClosed): (WebKit::DebuggerAgentManager::onNavigate): (WebKit::DebuggerAgentManager::sendCommandToV8): (WebKit::DebuggerAgentManager::sendContinueCommandToV8): (WebKit::DebuggerAgentManager::findAgentForCurrentV8Context): (WebKit::DebuggerAgentManager::debuggerAgentForHostId):
  • src/DebuggerAgentManager.h: Added. (WebKit::DebuggerAgentManager::UtilityContextScope::UtilityContextScope): (WebKit::DebuggerAgentManager::UtilityContextScope::~UtilityContextScope):
  • src/DevToolsRPC.h: Added. (WebKit::): (WebKit::DevToolsRPC::Delegate::Delegate): (WebKit::DevToolsRPC::Delegate::~Delegate): (WebKit::DevToolsRPC::DevToolsRPC): (WebKit::DevToolsRPC::~DevToolsRPC): (WebKit::DevToolsRPC::sendRpcMessage):
  • src/DevToolsRPCJS.h: Added.
  • src/ProfilerAgent.h: Added.
  • src/ProfilerAgentImpl.cpp: Added. (WebKit::ProfilerAgentImpl::getActiveProfilerModules): (WebKit::ProfilerAgentImpl::getLogLines):
  • src/ProfilerAgentImpl.h: Added. (WebKit::ProfilerAgentImpl::ProfilerAgentImpl): (WebKit::ProfilerAgentImpl::~ProfilerAgentImpl):
  • src/ToolsAgent.h: Added.
  • src/WebDevToolsAgentImpl.cpp: Added. (WebKit::): (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::disposeUtilityContext): (WebKit::WebDevToolsAgentImpl::unhideResourcesPanelIfNecessary): (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::didNavigate): (WebKit::WebDevToolsAgentImpl::didCommitProvisionalLoad): (WebKit::WebDevToolsAgentImpl::didClearWindowObject): (WebKit::WebDevToolsAgentImpl::forceRepaint): (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController): (WebKit::WebDevToolsAgentImpl::dispatchOnInjectedScript): (WebKit::WebDevToolsAgentImpl::executeVoidJavaScript): (WebKit::WebDevToolsAgentImpl::dispatchMessageFromFrontend): (WebKit::WebDevToolsAgentImpl::inspectElementAt): (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled): (WebKit::WebDevToolsAgentImpl::sendRpcMessage): (WebKit::WebDevToolsAgentImpl::compileUtilityScripts): (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost): (WebKit::WebDevToolsAgentImpl::createInspectorBackendV8Wrapper): (WebKit::WebDevToolsAgentImpl::resetInspectorFrontendProxy): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::jsDispatchOnClient): (WebKit::WebDevToolsAgentImpl::jsDispatchToApu): (WebKit::WebDevToolsAgentImpl::jsEvaluateOnSelf): (WebKit::WebDevToolsAgentImpl::jsOnRuntimeFeatureStateChanged): (WebKit::WebDevToolsAgentImpl::inspectorController): (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest): (WebKit::WebDevToolsAgentImpl::willSendRequest): (WebKit::WebDevToolsAgentImpl::didReceiveData): (WebKit::WebDevToolsAgentImpl::didReceiveResponse): (WebKit::WebDevToolsAgentImpl::didFinishLoading): (WebKit::WebDevToolsAgentImpl::didFailLoading): (WebKit::WebDevToolsAgentImpl::evaluateInWebInspector): (WebKit::WebDevToolsAgentImpl::setTimelineProfilingEnabled): (WebKit::WebDevToolsAgent::create): (WebKit::WebDevToolsAgent::executeDebuggerCommand): (WebKit::WebDevToolsAgent::debuggerPauseScript): (WebKit::WebDevToolsAgent::setMessageLoopDispatchHandler): (WebKit::WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread):
  • src/WebDevToolsAgentImpl.h: Added. (WebKit::WebDevToolsAgentImpl::hostId):
  • src/WebDevToolsFrontendImpl.cpp: Added. (WebKit::ToV8String): (WebKit::WebDevToolsFrontend::create): (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::dispatchMessageFromAgent): (WebKit::WebDevToolsFrontendImpl::executeScript): (WebKit::WebDevToolsFrontendImpl::dispatchOnWebInspector): (WebKit::WebDevToolsFrontendImpl::sendRpcMessage): (WebKit::WebDevToolsFrontendImpl::contextMenuItemSelected): (WebKit::WebDevToolsFrontendImpl::contextMenuCleared): (WebKit::WebDevToolsFrontendImpl::jsLoaded): (WebKit::WebDevToolsFrontendImpl::jsPlatform): (WebKit::WebDevToolsFrontendImpl::jsPort): (WebKit::WebDevToolsFrontendImpl::jsCopyText): (WebKit::WebDevToolsFrontendImpl::jsActivateWindow): (WebKit::WebDevToolsFrontendImpl::jsCloseWindow): (WebKit::WebDevToolsFrontendImpl::jsDockWindow): (WebKit::WebDevToolsFrontendImpl::jsUndockWindow): (WebKit::WebDevToolsFrontendImpl::jsLocalizedStringsURL): (WebKit::WebDevToolsFrontendImpl::jsHiddenPanels): (WebKit::WebDevToolsFrontendImpl::jsDebuggerCommand): (WebKit::WebDevToolsFrontendImpl::jsSetting): (WebKit::WebDevToolsFrontendImpl::jsSetSetting): (WebKit::WebDevToolsFrontendImpl::jsDebuggerPauseScript): (WebKit::WebDevToolsFrontendImpl::jsWindowUnloading): (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
  • src/WebDevToolsFrontendImpl.h: Added. (WebKit::WebDevToolsFrontendImpl::MenuProvider::create): (WebKit::WebDevToolsFrontendImpl::MenuProvider::~MenuProvider): (WebKit::WebDevToolsFrontendImpl::MenuProvider::disconnect): (WebKit::WebDevToolsFrontendImpl::MenuProvider::populateContextMenu): (WebKit::WebDevToolsFrontendImpl::MenuProvider::contextMenuItemSelected): (WebKit::WebDevToolsFrontendImpl::MenuProvider::contextMenuCleared): (WebKit::WebDevToolsFrontendImpl::MenuProvider::MenuProvider):
06:20 Nightly Builds edited by aroben@apple.com
(diff)
05:59 Changeset [54231] by pfeldman@chromium.org

2010-02-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: URLs are not syntax-higlighted as links in source view.

This change enables linkifier in the NativeTextViewer. It adds
"linkify" and "a_node" parse states into the highlighter in order
to detect links and distinguish between resource and external ones.
Contains drive-by fix for the webkit-html-* styles and moves them to the
common location.

https://bugs.webkit.org/show_bug.cgi?id=34364

  • inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer): (WebInspector.NativeTextViewer.prototype._createSpan): (WebInspector.NativeTextViewer.prototype._createLink): (WebInspector.NativeTextViewer.prototype._rewriteHref):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.setContent): (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute): (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue): (WebInspector.SourceHTMLTokenizer.prototype._stringToken): (WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspectorSyntaxHighlight.css:
05:32 Changeset [54230] by eric@webkit.org

2010-02-02 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha Silva.

[GTK] When selection changes selections in other WebView are not collapsed
https://bugs.webkit.org/show_bug.cgi?id=34043

Collapse the selection of a WebView even when the new selection owner is
a new WebView.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::clearClipboardContentsCallback): Only clear the DataObject we are setting is not the same as the one referenced in this callback. Use the same behavior for collapsing the selection. (WebKit::PasteboardHelperGtk::writeClipboardContents): Instead of recording a boolean record the actual data used while writing to the clipboard.
05:16 Changeset [54229] by eric@webkit.org

2010-02-02 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Install libraries and headers in package builds
https://bugs.webkit.org/show_bug.cgi?id=34325

Add the QtWebKit libraries to the installable items, except on
Symbian where the libraries are always linked in their final
destination.

Also include the headers generated by syncqt in the installation.

  • WebCore.pro:
04:59 Changeset [54228] by eric@webkit.org

2010-02-02 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Display HTML tags verbatim in JS alert/confirm/prompt boxes

https://bugs.webkit.org/show_bug.cgi?id=34429

  • Api/qwebpage.cpp: (QWebPage::javaScriptAlert): (QWebPage::javaScriptConfirm): (QWebPage::javaScriptPrompt):
04:43 Changeset [54227] by eric@webkit.org

2010-02-02 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Dmitry Titov.

[V8] Raising an exception while setting timeout/interval from a detached frame
https://bugs.webkit.org/show_bug.cgi?id=34453
This fixes the issue/failing test mentioned in Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=32671

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):
04:27 Changeset [54226] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port Screen
https://bugs.webkit.org/show_bug.cgi?id=34299

Get the screen size and depth from the main display bitmap.

  • platform/brew/ScreenBrew.cpp: Added. (WebCore::getDisplayInfo): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
04:10 Changeset [54225] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port LocalizedStrings
https://bugs.webkit.org/show_bug.cgi?id=34257

Port LocalizedStrings to BREWMP.

  • platform/brew/LocalizedStringsBrew.cpp: Added. (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::unknownFileSizeText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::imageTitle): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::AXButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXMenuListPopupActionVerb): (WebCore::AXMenuListActionVerb): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText): (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
03:56 Changeset [54224] by ossy@webkit.org

[Qt] fast/frames/set-unloaded-frame-location.html timed out on Qt Linux Release Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33303

fast/frames/sandboxed-iframe-navigation-windowopen.html made fast/frames/set-unloaded-frame-location.html
time out, but now it works correctly, so we can unskip the test.

  • platform/qt/Skipped: fast/frames/sandboxed-iframe-navigation-windowopen.html unskipped.
03:54 Changeset [54223] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port systemBeep
https://bugs.webkit.org/show_bug.cgi?id=33601

Implement systemBeep with IShell_Beep.

  • platform/brew/SoundBrew.cpp: Added. (WebCore::systemBeep):
03:38 Changeset [54222] by eric@webkit.org

2010-02-02 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable a way to measure FPS in QGVLauncher
run QGVLauncher with --show-fps to see ongoing fps measurements
This is not meant as accurate FPS, but rather as a way to find
improvements/regressions
https://bugs.webkit.org/show_bug.cgi?id=34450

  • QGVLauncher/main.cpp: (MainView::MainView): initialize FPS values (MainView::paintEvent): count a painted frame here (MainView::printFps): we print the fps with qDebug every 5 seconds.
03:07 Changeset [54221] by hamaji@chromium.org

2010-02-02 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

[Win] Utilize PrintContext to share the printing code with other ports
https://bugs.webkit.org/show_bug.cgi?id=34312

No new tests as this is just a small refactoring.

02:54 Changeset [54220] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add HAVE_XXX definitions
https://bugs.webkit.org/show_bug.cgi?id=34414

Add HAVE_ERRNO_H=1

  • wtf/Platform.h:
02:32 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
02:27 Changeset [54219] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add conversions between IntPoint and AEEPoint
https://bugs.webkit.org/show_bug.cgi?id=34194

Make it easy to convert between IntPoint and AEEPoint.

  • platform/graphics/IntPoint.h:
  • platform/graphics/brew/IntPointBrew.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator AEEPoint):
01:58 Changeset [54218] by steveblock@google.com

Adds virtual destructors for AbstractWeakReferenceMap and AbstractWeakReferenceMap::Visitor
https://bugs.webkit.org/show_bug.cgi?id=34434

Reviewed by Adam Barth.

No new tests, build fix only.

  • bindings/v8/V8DOMMap.h: Modified.

(WebCore::AbstractWeakReferenceMap::~AbstractWeakReferenceMap): Added.
(WebCore::AbstractWeakReferenceMap::Visitor::~Visitor): Added.

01:53 WebKit Team edited by alex@webkit.org
Committer since last week (diff)
01:46 Changeset [54217] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Don't define HAVE_TM_GMTOFF, HAVE_TM_ZONE and HAVE_TIMEGM
https://bugs.webkit.org/show_bug.cgi?id=34388

BREWMP does not have these features.

  • wtf/Platform.h:
01:18 Changeset [54216] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Define WTF_PLATFORM_BREWMP=1 when BUILDING_BREWMP is defined
https://bugs.webkit.org/show_bug.cgi?id=34386

Define WTF_PLATFORM_BREWMP=1 so that PLATFORM(BREWMP) guard can be used.

  • wtf/Platform.h:
00:52 Changeset [54215] by eric@webkit.org

2010-02-02 Avi Drissman <avi@chromium.org>

Reviewed by Eric Seidel.

Sync up Chromium Mac render theme to Mac render theme
https://bugs.webkit.org/show_bug.cgi?id=34340

Covered by existing layout tests.

  • platform/chromium/ThemeChromiumMac.mm: (WebCore::updateStates): (WebCore::checkbox): (WebCore::paintCheckbox): (WebCore::radio): (WebCore::paintRadio): (WebCore::listButtonSizes): (WebCore::setupButtonCell): (WebCore::button): (WebCore::paintButton): (WebCore::ThemeChromiumMac::controlSize): (WebCore::ThemeChromiumMac::minimumControlSize): (WebCore::ThemeChromiumMac::controlBorder): (WebCore::ThemeChromiumMac::paint):
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]): (WebCore::convertNSColorToColor): (WebCore::RenderThemeChromiumMac::systemColor): (WebCore::RenderThemeChromiumMac::isControlStyled): (WebCore::RenderThemeChromiumMac::adjustRepaintRect): (WebCore::RenderThemeChromiumMac::convertToPaintingRect): (WebCore::RenderThemeChromiumMac::paintCapsLockIndicator): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintMenuListButton): (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): (WebCore::RenderThemeChromiumMac::adjustMenuListButtonStyle): (WebCore::RenderThemeChromiumMac::paintSliderTrack): (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintSearchField): (WebCore::RenderThemeChromiumMac::setSearchFieldSize): (WebCore::RenderThemeChromiumMac::adjustSearchFieldStyle): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize): (WebCore::RenderThemeChromiumMac::popupButton): (WebCore::RenderThemeChromiumMac::sliderThumbHorizontal): (WebCore::RenderThemeChromiumMac::sliderThumbVertical):
00:52 Changeset [54214] by jorlow@chromium.org

2010-02-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add WebSecurityOrigin::createFromString factory
https://bugs.webkit.org/show_bug.cgi?id=34460

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::createFromString):
00:35 Changeset [54213] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port Logging
https://bugs.webkit.org/show_bug.cgi?id=34300

Log calls to notImplemented() by default.

  • platform/brew/LoggingBrew.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary):
00:25 Changeset [54212] by tkent@chromium.org

2010-02-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Should not select a word on right-click.
https://bugs.webkit.org/show_bug.cgi?id=33364

For non-Mac platforms, do not select a word around the caret when
a context menu is opening. This behavior is not common in non-Mac
platforms, and it prevents pasting with a context menu.

In order that the spell checker works without the selection, we
introduce WebFrame::selectWordAroundCaret(). We can replace a word
around the caret with selectWordAroundCaret() + replaceSelection().

  • public/WebFrame.h: Add pure selectWordAroundCaret() declaration.
  • src/ContextMenuClientImpl.cpp: (WebKit::selectMisspelledWord): Move word-selection code to WebFrameImpl::selectWordAroundPosition(), and clear the selection on non-Mac.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundPosition): (WebKit::WebFrameImpl::selectWordAroundCaret):
  • src/WebFrameImpl.h: Add selectWordAroundCaret() declaration.
00:19 Changeset [54211] by eric@webkit.org

2010-02-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port FileChooser
https://bugs.webkit.org/show_bug.cgi?id=34261

Port FileChooser to BREWMP.

  • platform/brew/FileChooserBrew.cpp: Added. (WebCore::FileChooser::basenameForWidth):

02/01/10:

23:56 Changeset [54210] by zoltan@webkit.org

2010-02-01 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for IconDatabaseClient class
https://bugs.webkit.org/show_bug.cgi?id=33252

Inherits the following struct from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
class IconDatabaseClient - loader/icon/IconDatabase.cpp:89

  • loader/icon/IconDatabaseClient.h:
23:51 Changeset [54209] by bweinstein@apple.com

Check in new expected results for a test that has been failing on Windows
since it was originally landed. This appears to be a font issue, but commenting
on bug <https://bugs.webkit.org/show_bug.cgi?id=34234> to make sure.

  • platform/win/fast/text/international/hebrew-vowels-expected.txt: Added.
23:46 Changeset [54208] by eric@webkit.org

2010-02-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port MIMETypeRegistry
https://bugs.webkit.org/show_bug.cgi?id=34220

Port MIMETypeRegistry with an extension map as other ports do.

  • platform/brew: Added.
  • platform/brew/MIMETypeRegistryBrew.cpp: Added. (WebCore::): (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
22:53 Changeset [54207] by dimich@chromium.org

Revert r54194 that fails new test on Qt and Chromium.
https://bugs.webkit.org/show_bug.cgi?id=34382

22:41 Changeset [54206] by cjerdonek@webkit.org

Addressed FIXME in check-webkit-style so that the carriage-return
check will work for patches.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34260

Also added support for limiting the number of errors reported
per category, per file.

  • Scripts/webkitpy/style/checker.py:
    • Added new "whitespace/carriage_return" category from common.py.
    • Added MAX_REPORTS_PER_CATEGORY dictionary.
    • Added max_reports_per_category attribute to ProcessorOptions class.
    • Refactored StyleChecker._process_file().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated ProcessorOptionsTest tests.
    • Added test to check MAX_REPORTS_PER_CATEGORY.
  • Scripts/webkitpy/style/error_handlers.py:
    • Added support for suppressing the display of errors after reaching a per-category maximum (from max_reports_per_category).
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Added test for suppressing error display.
  • Scripts/webkitpy/style/processors/common.py: Added.
    • Moved carriage-return check to new file.
  • Scripts/webkitpy/style/processors/common_unittest.py: Added.
    • Added unit tests for carriage-return check.
  • Scripts/webkitpy/style/unittests.py:
    • Added reference to common_unittest.py.
22:28 Changeset [54205] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • printing/page-break-always-expected.txt: Added.
  • printing/page-break-always.html: Added.
  • printing/pageNumerForElementById-expected.txt: Added.
  • printing/pageNumerForElementById.html: Added.
  • printing/script-tests/TEMPLATE.html: Added.
  • printing/script-tests/page-break-always.js: Added. (createParagraph):
  • printing/script-tests/pageNumerForElementById.js: Added. (createParagraph):

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840

Test: printing/page-break-always.html

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/PrintContext.cpp: (WebCore::PrintContext::pageRect): Added a getter function. (WebCore::PrintContext::computePageRects): Move its logic into computePageRectsWithPageSize. (WebCore::PrintContext::computePageRectsWithPageSize): Factored out from computePageRects for pageNumberForElement. (WebCore::enclosingBoxModelObject): Added for pageNumberForElement. (WebCore::PrintContext::pageNumberForElement): Added for testing.
  • page/PrintContext.h:

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame pageNumberForElement:element:pageWidth:]):

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Provide a way to get page number with layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=33840

  • DumpRenderTree/LayoutTestController.cpp: (pageNumberForElementByIdCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageNumberForElementById):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageNumberForElementById):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageNumberForElementById):
22:19 Changeset [54204] by eric@webkit.org

2010-02-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add conversions between IntSize and AEESize
https://bugs.webkit.org/show_bug.cgi?id=34197

Make it easy to convert between IntSize and AEESize.

  • platform/graphics/IntSize.h:
  • platform/graphics/brew/IntSizeBrew.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator AEESize):
21:36 Changeset [54203] by eric@webkit.org

2010-02-01 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

Fix for Pattern transformations in Chromium/Skia. This required
reworking Pattern a bit to be more like the Gradient implementation.
In particular, it now holds an m_pattern reference to the
platform-specific implementation, and passes along changes to the
m_patternSpaceTransformation, in the same way that Gradient does for
m_gradientSpaceTransformation. This is necessary since Skia creates the
platform-specific pattern (SkShader) once, rather than recreating it
on each draw.
For platforms other than Skia, m_pattern is unused, they will
continue to use the static createPlatformPattern(), and the new
notification functions are stubbed out. Other platforms can switch to
the new implementation if they so choose.

https://bugs.webkit.org/show_bug.cgi?id=24534

Covered by svg/custom/pattern-y-offset.svg,
svg/custom/pattern-cycle-detection.svg, and many more.

  • platform/graphics/Pattern.cpp: (WebCore::Pattern::Pattern): Initializer for m_pattern. (WebCore::Pattern::~Pattern): call platformDestroy(). (WebCore::Pattern::setPatternSpaceTransform): Pass along the transform via setPlatformPatternSpaceTransform(). (WebCore::Pattern::platformDestroy): (WebCore::Pattern::setPlatformPatternSpaceTransform): Stub implementations for non-skia platforms.
  • platform/graphics/Pattern.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformFillPattern): (WebCore::GraphicsContext::setPlatformStrokePattern): Call platformPattern() instead of static version. Since Pattern now owns its SkShader, no need to unref here.
  • platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::platformDestroy): Unref the SkShader on destroy. (WebCore::Pattern::platformPattern): Create the platform pattern (SkShader) once, and cache it. (WebCore::Pattern::setPlatformPatternSpaceTransform): Set the shader's local matrix from the m_patternSpaceTransformation.
21:13 Changeset [54202] by dbates@webkit.org

2010-02-01 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27312

Implements support for full page blocking via the X-XSS-Protection header.

Tests: http/tests/security/xssAuditor/full-block-base-href.html

http/tests/security/xssAuditor/full-block-get-from-iframe.html
http/tests/security/xssAuditor/full-block-iframe-javascript-url.html
http/tests/security/xssAuditor/full-block-iframe-no-inherit.php
http/tests/security/xssAuditor/full-block-javascript-link.html
http/tests/security/xssAuditor/full-block-link-onclick.html
http/tests/security/xssAuditor/full-block-object-tag.html
http/tests/security/xssAuditor/full-block-post-from-iframe.html
http/tests/security/xssAuditor/full-block-script-tag-with-source.html
http/tests/security/xssAuditor/full-block-script-tag.html
http/tests/security/xssAuditor/malformed-xss-protection-header.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::shouldFullPageBlockForXSSProtectionHeader): Added. (WebCore::XSSAuditor::findInRequest): Modified to call method XSSAuditor::shouldFullPageBlockForXSSProtectionHeader.
  • page/XSSAuditor.h: Defined method shouldFullPageBlockForXSSProtectionHeader and fixed misspelled words in large comment block.

2010-02-01 Daniel Bates <dbates@webkit.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27312

Tests that the header "X-XSS-Protection: full-block" leads to a full page block
when an XSS attack is detected.

  • http/tests/security/xssAuditor/full-block-base-href-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-base-href.html: Added.
  • http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-get-from-iframe.html: Added.
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url.html: Added.
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit.php: Added.
  • http/tests/security/xssAuditor/full-block-javascript-link-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-javascript-link.html: Added.
  • http/tests/security/xssAuditor/full-block-link-onclick-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-link-onclick.html: Added.
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-object-tag.html: Added.
  • http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-post-from-iframe.html: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-with-source.html: Added.
  • http/tests/security/xssAuditor/full-block-script-tag.html: Added.
  • http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt: Added.
  • http/tests/security/xssAuditor/malformed-xss-protection-header.html: Added.
  • http/tests/security/xssAuditor/resources/echo-head-base-href.pl: Modified to optionally enable full page blocking.
  • http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Ditto.
  • http/tests/security/xssAuditor/resources/echo-intertag.pl: Ditto.
  • http/tests/security/xssAuditor/resources/utilities.js: (checkIfFrameLocationMatchesURLAndCallDone): Added. (sendRequestFromIFrame): Modified to optionally call callback function when done.
21:10 Changeset [54201] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dmitry Titov.

Convert textarea-rows-cols.html to dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=34074

Remove checks for the size of scrollbar as scrollbar doesn't
appear on Windows.

  • fast/forms/script-tests/textarea-rows-cols.js:
  • fast/forms/textarea-rows-cols-expected.txt:
21:01 Changeset [54200] by eric@webkit.org

2010-02-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port SharedTimer with IShell_SetTimerEx.
https://bugs.webkit.org/show_bug.cgi?id=33599

As fireTime passed in setSharedTimerFireTime is the absolute time,
we must calcalute the interval by subtracting currentTime() from
fireTime and pass the result to ISHELL_SetTimerEx.

  • platform/brew/SharedTimerBrew.cpp: Added. (WebCore::invokeCallback): (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
20:56 Changeset [54199] by tkent@chromium.org

2010-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Date.UTC() should apply TimeClip operation.
https://bugs.webkit.org/show_bug.cgi?id=34461

ECMAScript 5 15.9.4.3:

9 Return TimeClip(MakeDate(MakeDay(yr, m, dt), MakeTime(h, min, s, milli))).

  • runtime/DateConstructor.cpp: (JSC::dateUTC): Calls WTF::timeClip().

2010-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Date.UTC() should apply TimeClip operation.
https://bugs.webkit.org/show_bug.cgi?id=34461

Add tests for corner cases of Date.UTC().

  • fast/js/date-utc-timeclip-expected.txt: Added.
  • fast/js/date-utc-timeclip.html: Added.
  • fast/js/script-tests/date-utc-timeclip.js: Added.
20:48 Changeset [54198] by tkent@chromium.org

2010-02-01 Kent Tamura <tkent@chromium.org>

Unreviewed. Add two more test cases which I forgot to add in r54197.
https://bugs.webkit.org/show_bug.cgi?id=34462

  • fast/js/math-expected.txt:
  • fast/js/script-tests/math.js:
20:42 Changeset [54197] by tkent@chromium.org

2010-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that Math.round() retunrs incorrect results for huge integers
https://bugs.webkit.org/show_bug.cgi?id=34462

  • runtime/MathObject.cpp: (JSC::mathProtoFuncRound): Avoid "arg + 0.5".

2010-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that Math.round() retunrs incorrect results for huge integers
https://bugs.webkit.org/show_bug.cgi?id=34462

  • fast/js/math-expected.txt:
  • fast/js/script-tests/math.js: Add test cases for Math.round() for huge numbers.
20:13 Changeset [54196] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

[Chromium] Unreviewed attempt to fix the chromium build.

Corresponding change: http://trac.webkit.org/changeset/54182

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/ScriptController.h:
19:19 Changeset [54195] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed attempt to fix the broken build.

This was introduced in http://trac.webkit.org/changeset/54182

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::performMediaPlayerAction):
19:14 Changeset [54194] by dimich@chromium.org

When a live iframe element is moved between pages, it still depends on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382

Reviewed by David Levin.

WebCore:

Test: fast/frames/iframe-reparenting-new-page.html

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::setName):
Move the code setting the frame name into a separate function.

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::updateLiveFrame):
Update frame tree, reset page in the contentFrame and re-set the name.

(WebCore::HTMLFrameElementBase::insertedIntoDocument):

  • html/HTMLFrameElementBase.h:
  • page/Frame.cpp:

(WebCore::Frame::setPage):

  • page/Frame.h: Add setPage method. It is only currently used when iframe is

moved between pages (so the ASSERT(m_ownerElement).

LayoutTests:

  • fast/frames/iframe-reparenting-new-page-expected.txt: Added.
  • fast/frames/iframe-reparenting-new-page.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-1.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-2.html: Added.
  • fast/frames/resources/iframe-reparenting-new-page-iframe.html: Added.
19:06 Changeset [54193] by beidson@apple.com

WebCore: Add common IRC ports to port blocking.
<rdar://problem/7593895> and https://bugs.webkit.org/show_bug.cgi?id=34451

Reviewed by Tim Hatcher.

  • platform/KURL.cpp:

(WebCore::portAllowed):

LayoutTests: Add common IRC ports to port blocking.
<rdar://problem/7593895> and https://bugs.webkit.org/show_bug.cgi?id=34451

  • platform/mac-tiger/security/block-test-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • security/block-test.html:

Reviewed by Tim Hatcher.

18:45 Changeset [54192] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed fix for an invalid function call.

check-webkit-style: Remove filename parameter from all functions where no longer used
https://bugs.webkit.org/show_bug.cgi?id=34249

  • Scripts/webkitpy/style/checker.py:
18:43 Changeset [54191] by jorlow@chromium.org

2010-01-27 Matt Perry <mpcomplete@chromium.org>

Reviewed by Eric Seidel.

Add support for addUserScript to chromium port.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::addUserScript): (WebKit::WebViewImpl::removeAllUserContent):
  • src/WebViewImpl.h:
18:42 Changeset [54190] by jorlow@chromium.org

2010-01-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

[V8] Add compile time guards for IndexedDB custom functions
https://bugs.webkit.org/show_bug.cgi?id=34368

  • bindings/v8/custom/V8IDBRequestCustom.cpp:
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
18:07 QtWebKitGraphics edited by noam.rosenthal@nokia.com
(diff)
18:06 cssAnimTestSuite.html attached to QtWebKitGraphics by noam.rosenthal@nokia.com
Comprehensive test suite for CSS animations
18:04 CssAnimationTestSuite edited by noam.rosenthal@nokia.com
(diff)
18:02 cssAnimTestSuite.html attached to CssAnimationTestSuite by noam.rosenthal@nokia.com
18:01 CssAnimationTestSuite created by noam.rosenthal@nokia.com
17:48 Changeset [54189] by mrowe@apple.com

Merge r53116.

17:48 Changeset [54188] by mrowe@apple.com

Merge r53115.

17:48 Changeset [54187] by mrowe@apple.com

Merge r53114.

17:48 Changeset [54186] by mrowe@apple.com

Merge r53096.

17:47 Changeset [54185] by mrowe@apple.com

Merge r53093.

17:47 Changeset [54184] by mrowe@apple.com

Merge r53078.

17:33 Changeset [54183] by eric@webkit.org

2010-02-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port WTF's currentTime
https://bugs.webkit.org/show_bug.cgi?id=33567

Combine GETUTCSECONDS and GETTIMEMS to calculate the number
of milliseconds since 1970/01/01 00:00:00 UTC.

  • wtf/CurrentTime.cpp: (WTF::currentTime):
17:20 Changeset [54182] by barraclough@apple.com

Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds

WebCore:

Reviewed by Sam Weinig + Oliver Hunt.

Change HTMLMediaElement methods that require checking whether the event is a user gesture to
be passed a boolean. This may be passed from the JSC bindings (where we have an exec state),
or read from the event. Add a Flag to the IDL to mark this information is required.

  • WebCore.Video.exp:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::processingUserGesture):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::domWindowAllowPopUp):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::processingUserGesture):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::anyPageIsProcessingUserGesture):

  • bindings/js/ScriptController.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Event.cpp:

(WebCore::Event::isUserEvent):

  • dom/Event.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removedFromDocument):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::documentDidBecomeActive):
(WebCore::HTMLMediaElement::webkitEnterFullScreen):

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::isProcessingUserGesture):

  • loader/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::allowPopUp):

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlSeekButtonElement::defaultEventHandler):

WebKit/mac:

Reviewed by Sam Weinig + Oliver Hunt.

Pass processeing user gensture flag to media play/pause methods.

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController setPlaying:]):

WebKit/win:

Reviewed by Sam Weinig + Oliver Hunt.

Pass processeing user gensture flag to media play/pause methods.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::play):
(FullscreenVideoController::pause):

LayoutTests:

Reviewed by Sam Weinig.

  • http/tests/security/isolatedWorld/resources/userGestureEvents-second-window.html: Added.
  • http/tests/security/isolatedWorld/userGestureEvents-expected.txt: Added.
  • http/tests/security/isolatedWorld/userGestureEvents.html: Added.
17:17 Changeset [54181] by mrowe@apple.com

Merge r51976 and the parts of r50704 that it depended on.

17:16 Changeset [54180] by eric@webkit.org

2010-02-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Use the fallback style on Maemo 5

https://bugs.webkit.org/show_bug.cgi?id=34376

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::fallbackStyle): (WebCore::RenderThemeQt::qStyle): (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
  • platform/qt/RenderThemeQt.h:
17:00 Changeset [54179] by eric@webkit.org

2010-02-01 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Nate Chapin.

[V8] Making V8 generated classes' GetTemplate() function public
https://bugs.webkit.org/show_bug.cgi?id=34026

  • bindings/scripts/CodeGeneratorV8.pm: Generated code need not depend on V8CustomBinding.h, made GetTemplate() signature public.
16:56 Changeset [54178] by mitz@apple.com

<rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()

Reviewed by Anders Carlsson.

The crash was caused by having two streams with a streamID of 1.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
correctly increments m_currentURLRequestID to account for the manual stream.
(WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
null it out instead of trying to remove it from the map. Added an assertion.
(WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.

16:42 Changeset [54177] by mrowe@apple.com

Merge r51704.

16:39 Changeset [54176] by eric@webkit.org

2010-02-01 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

[Qt] WinCE buildfix after r52729 and fix for Q_BIG_ENDIAN typo.
https://bugs.webkit.org/show_bug.cgi?id=34378

  • wtf/Platform.h:
16:35 Changeset [54175] by steveblock@google.com

Adds V8-specific JNI bridge classes
https://bugs.webkit.org/show_bug.cgi?id=34166

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JNIBridgeJSC.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JNIBridge.cpp and JNIBridgeV8.cpp
  • bridge/Bridge.h: Modified. Added missing include for Noncopyable.h
  • bridge/jni/v8/JNIBridgeV8.cpp: Added.

(JavaField::JavaField):

  • bridge/jni/v8/JNIBridgeV8.h: Added.

(JSC::Bindings::JavaField::name):
(JSC::Bindings::JavaField::type):
(JSC::Bindings::JavaField::getJNIType):

16:34 Changeset [54174] by mrowe@apple.com

Merge r51962.

16:34 Changeset [54173] by mrowe@apple.com

Merge r50110.

16:34 Changeset [54172] by mrowe@apple.com

Merge r50017.

16:25 Changeset [54171] by steveblock@google.com

Adds V8-specific JNI utility functions.
https://bugs.webkit.org/show_bug.cgi?id=33901

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JNIUtilityPrivate.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Add JNIUtilityPrivate.cpp
  • bridge/jni/v8/JNIUtilityPrivate.cpp: Added.

(JSC::Bindings::convertNPVariantToJValue):
(JSC::Bindings::convertJValueToNPVariant):

  • bridge/jni/v8/JNIUtilityPrivate.h: Added.
16:23 Changeset [54170] by mrowe@apple.com

Merge r52784.

16:15 Changeset [54169] by steveblock@google.com

Adds V8 version of JavaClass
https://bugs.webkit.org/show_bug.cgi?id=33898

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JavaClassJSC

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JavaClassV8.cpp
  • bridge/jni/v8/JavaClassV8.cpp: Added.

(JavaClass::JavaClass):
(JavaClass::~JavaClass):
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):

  • bridge/jni/v8/JavaClassV8.h: Added.
16:09 Changeset [54168] by mrowe@apple.com

Merge r51645.

16:09 Changeset [54167] by mrowe@apple.com

Merge r50310.

16:08 Changeset [54166] by hamaji@chromium.org

2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

REGRESSION: editing/selection/doubleclick-beside-cr-span.html times out on Windows
https://bugs.webkit.org/show_bug.cgi?id=34069

Make the sleep time shorter as this test timed out on Windows bot.

  • editing/selection/doubleclick-beside-cr-span.html:
16:03 Changeset [54165] by steveblock@google.com

Adds V8 version of JavaInstance
https://bugs.webkit.org/show_bug.cgi?id=33951

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JavaInstanceJSC.
Also fixes a typo in a comment in JavaInstanceJSC.cpp.

No new tests, build fix only.

  • Android.v8bindings.mk: Modified. Added JavaInstanceV8.cpp
  • bridge/jni/jsc/JavaInstanceJSC.cpp: Modified.

(JavaInstance::invokeMethod): Modified. Fixed comment

  • bridge/jni/v8/JavaInstanceV8.cpp: Added.

(JavaInstance::JavaInstance):
(JavaInstance::~JavaInstance):
(JavaInstance::getClass):
(JavaInstance::invokeMethod):
(JObjectWrapper::JObjectWrapper):
(JObjectWrapper::~JObjectWrapper):

  • bridge/jni/v8/JavaInstanceV8.h: Added.

(JSC::Bindings::JObjectWrapper::instance):
(JSC::Bindings::JObjectWrapper::setInstance):
(JSC::Bindings::JObjectWrapper::ref):
(JSC::Bindings::JObjectWrapper::deref):
(JSC::Bindings::JavaInstance::javaInstance):
(JSC::Bindings::JavaInstance::begin):
(JSC::Bindings::JavaInstance::end):
(JSC::Bindings::JavaInstance::virtualBegin):
(JSC::Bindings::JavaInstance::virtualEnd):

15:43 Changeset [54164] by mrowe@apple.com

Merge r47726.

15:38 Changeset [54163] by mrowe@apple.com

Merge r51659.

15:32 Changeset [54162] by dumi@chromium.org

Making sure that all in-progress transactions are rolled back on
the database thread before they're destroyed. Otherwise,
SQLiteTransaction's destructor will try to do a rollback and that
would cause an assertion failure, if the object is not destroyed
on the DB thread.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=34152

  • platform/sql/SQLiteTransaction.cpp:

(WebCore::SQLiteTransaction::stop):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):

  • storage/SQLTransaction.h:
  • storage/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::shutdown):

15:32 Changeset [54161] by mrowe@apple.com

Merge r53813.

15:32 Changeset [54160] by mrowe@apple.com

Merge r53812.

15:26 Changeset [54159] by mrowe@apple.com

Merge r50466.

15:25 Changeset [54158] by mrowe@apple.com

Merge r50470.

15:25 Changeset [54157] by mrowe@apple.com

Merge r50435.

15:23 Changeset [54156] by weinig@apple.com

Fix EXPERIMENTAL_SINGLE_VIEW_MODE build.

Reviewed by Beth Dakin.

  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::currentNSEvent):
(WebCore::EventHandler::currentKeyboardEvent):
(WebCore::EventHandler::mouseDown):
(WebCore::EventHandler::mouseDragged):
(WebCore::EventHandler::mouseUp):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):

15:19 Changeset [54155] by eric@webkit.org

2010-02-01 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT Provide global flag ability
https://bugs.webkit.org/show_bug.cgi?id=34418

Add the globalFlag property to the Qt LayoutTestController to allow
cross-domain indications.

  • platform/qt/Skipped:

2010-02-01 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT Provide global flag ability
https://bugs.webkit.org/show_bug.cgi?id=34418

Add the globalFlag property to the Qt LayoutTestController to allow
cross-domain indications.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::globalFlag): (LayoutTestController::setGlobalFlag):
15:11 Changeset [54154] by mrowe@apple.com

Merge r50083.

14:39 Changeset [54153] by japhet@chromium.org

2010-02-01 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium build fix.

Failed to properly add new files for http://trac.webkit.org/changeset/54150.

  • bindings/v8/custom/V8BarInfoCustom.cpp: Added.
  • bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8CSSValueCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
  • bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
  • bindings/v8/custom/V8SVGElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
  • bindings/v8/custom/V8ScreenCustom.cpp: Added.
  • bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
14:29 Changeset [54152] by mpcomplete@chromium.org

Add support for addUserScript to chromium port.

14:20 Changeset [54151] by eric.carlson@apple.com

2010-02-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=34448
<rdar://problem/7598130>

RenderVideo::intrinsicSizeChanged infinite recursion

  • rendering/RenderImage.h: (WebCore::RenderImage::intrinsicSizeChanged): Make protected instead of private so it can

be called by RenderVideo.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::intrinsicSizeChanged): Call RenderMedia::intrinsicSizeChanged, not

RenderVideo::intrinsicSizeChanged.

(WebCore::RenderVideo::imageChanged): Call RenderMedia::imageChanged instead of

RenderImage::imageChanged.

14:12 Changeset [54150] by japhet@chromium.org

2010-02-01 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Generate toV8() converter for most WebCore->V8 conversions,
and defined custom converters in their respective V8<class>Custom.cpp.

Old converters in V8DOMWrapper will be deleted in a later patch.

https://bugs.webkit.org/show_bug.cgi?id=32563

  • Android.v8bindings.mk:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/custom/V8BarInfoCustom.cpp: Added.
  • bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8CSSValueCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8ConsoleCustom.cpp:
  • bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NavigatorCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
  • bindings/v8/custom/V8SVGElementCustom.cpp: Added.
  • bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
  • bindings/v8/custom/V8ScreenCustom.cpp: Added.
  • bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
  • dom/make_names.pl: Add options to generate wrapper factory for V8 bindings.
14:06 Changeset [54149] by bweinstein@apple.com

Rubber-stamped by Oliver Hunt.

Check in (failing) expected results for fast/dom/Window/window-postmessage-clone-frames.
This fails because of <rdar://problem/5230396> eventSender.beginDragWithFiles is unimplemented.

  • platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
14:03 WebKit Team edited by hamaji@chromium.org
minor fix for quotations (diff)
14:02 Changeset [54148] by eric@webkit.org

2010-02-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: lazy-load textual resources to avoid UI hangup
https://bugs.webkit.org/show_bug.cgi?id=34332

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.contentTabSelected):
13:53 Changeset [54147] by eric.carlson@apple.com

2010-02-01 Eric Carlson <eric.carlson@apple.com>

No review, build fix.

https://bugs.webkit.org/show_bug.cgi?id=34447
http/tests/media/video-referer.html fails on Windows

  • platform/win/Skipped:
13:35 Changeset [54146] by ossy@webkit.org

[Qt] Unreviewed trivial fix.
Platform dependent expected file updated after r54143.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
13:21 Changeset [54145] by beidson@apple.com

Crash in Safari opening new tabs to "same page"
<rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444

Reviewed by Adele Peterson.

WebCore:

Test: fast/loader/crash-copying-backforwardlist.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadItem): Null check currentItem().

  • page/Page.cpp:

(WebCore::Page::goToItem): Ditto.

WebKitTools:

Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(setNewWindowsCopyBackForwardListCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::newWindowsCopyBackForwardList):
(LayoutTestController::setNewWindowsCopyBackForwardList):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:createWebViewWithRequest:]):

LayoutTests:

  • fast/loader/crash-copying-backforwardlist-expected.txt: Added.
  • fast/loader/crash-copying-backforwardlist.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
13:09 Changeset [54144] by kevino@webkit.org

Reviewed by Kevin Ollivier.

[wx] Remove unused file that doesn't seem to belong to the port.

https://bugs.webkit.org/show_bug.cgi?id=34445

12:48 Changeset [54143] by eric.carlson@apple.com

2010-02-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Fullscreen API should be on HTMLVideoElement
https://bugs.webkit.org/show_bug.cgi?id=34438


Move fullscreen DOM APIs from HTMLMediaElement to HTMLVideoElement.

  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::paint): Removed outdated FIXME. (WebCore::HTMLVideoElement::paintCurrentFrameInContext): Ditto. (WebCore::HTMLVideoElement::webkitEnterFullScreen): Moved from HTMLMediaElement. (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto. (WebCore::HTMLVideoElement::webkitSupportsFullscreen): Ditto. (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:

2010-02-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Fullscreen API should be on HTMLVideoElement
https://bugs.webkit.org/show_bug.cgi?id=34438

Update fullscreen tests now that <audio> doesn't have fullscreen API.

  • fast/dom/Window/window-properties-expected.txt:
  • media/media-fullscreen-inline-expected.txt:
  • media/media-fullscreen-not-in-document-expected.txt:
  • media/media-fullscreen.js: (buttonClickHandler): (canplaythrough):
12:05 Changeset [54142] by carol.szabo@nokia.com

2010-02-01 Carol Szabo <carol.szabo@nokia.com>

Unreviewed.

Add myself to list of committers.

  • Scripts/webkitpy/committers.py:
12:04 Changeset [54141] by oliver@apple.com

2010-02-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Structure not accounting for anonymous slots when computing property storage size
https://bugs.webkit.org/show_bug.cgi?id=34441

Previously any Structure with anonymous storage would have a property map, so we
were only including anonymous slot size if there was a property map. Given this
is no longer the case we should always include the anonymous slot count in the
property storage size.

  • runtime/Structure.h: (JSC::Structure::propertyStorageSize):
10:59 Changeset [54140] by japhet@chromium.org

2010-02-01 Nate Chapin <japhet@chromium.org>

Rubber-stamped by David Levin.

Add myself to reviewer list.

  • Scripts/webkitpy/committers.py:
10:44 Changeset [54139] by pfeldman@chromium.org

2010-02-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Syntax highlighting in source view of
Resources pane stops half-way.

There were two problems here: (1) styles for html highlighter were not
added into the css file (they used to be injected manually in the
SourceFrame before). (2) 'Tag' needed to be lexer's state, not parser's.
Otherwise unbalanced quotes in the text nodes were matching too match
into the string tokens.

https://bugs.webkit.org/show_bug.cgi?id=34359

  • inspector/front-end/NativeTextViewer.js: (WebInspector.NativeTextViewer.prototype._createLineDivs): (WebInspector.NativeTextViewer.prototype._lineHeight): (WebInspector.NativeTextViewer.prototype.initFontMetrics):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
  • inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype.initFontMetrics): (WebInspector.TextEditor.prototype._registerShortcuts):
  • inspector/front-end/inspectorSyntaxHighlight.css:
10:40 WebKit Team edited by japhet@chromium.org
(diff)
10:35 Changeset [54138] by benm@google.com

ScriptCallFrame's do not get line numbers/source id's if the caller is unkown.
https://bugs.webkit.org/show_bug.cgi?id=34335

Reviewed by Darin Adler.

WebCore:

  • bindings/js/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed.

LayoutTests:

Update layout tests that did not have source and line number information for their console messages, as this information is now available to the ScriptCallFrame and thus can be passed to the inspector, for example.

  • fast/js/console-non-string-values-expected.txt: Add console line number/source.
  • userscripts/script-not-run-for-fragments-expected.txt: ditto.
  • userscripts/script-run-at-start-expected.txt: ditto.
  • platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed as platform workarounds no longer necessary.
  • platform/mac/inspector/console-log-before-inspector-open-expected.txt: ditto.
  • platform/win/inspector/console-log-before-inspector-open-expected.txt: ditto.
10:07 Changeset [54137] by krit@webkit.org

2010-02-01 Dirk Schulze <krit@webkit.org>

Reviewed by Simon Fraser.

Add back an AffineTransform class for use by SVG
https://bugs.webkit.org/show_bug.cgi?id=33750

These are the first steps on reimplementing AffineTransform. Unlike
the old affine code, this one is platform independent like TransformationMatrix.
AffineTransform has the benefit, that it stores just 6 doubles instead of
16 in TransformationMatrix. The calculations of transformations are not that
complex and can improve the memory usage and speed of SVG.
AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
least for the moment).
HTML Canvas is the first that makes use of the new AffineTransform. Next patches
will introduce the affine code to SVG.

No new tests. The new AffineTransformation code is tested by fast/canvas.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::willDraw):
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::transform):
  • platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::AffineTransform::operator cairo_matrix_t):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
  • platform/graphics/cg/TransformationMatrixCG.cpp: (WebCore::AffineTransform::operator CGAffineTransform):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::transform):
  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::AffineTransform::operator QTransform):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::transform):
  • platform/graphics/skia/TransformationMatrixSkia.cpp: (WebCore::AffineTransform::operator SkMatrix):
  • platform/graphics/transforms/AffineTransform.cpp: Added. (WebCore::affineTransformDecompose): (WebCore::affineTransformCompose): (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::det): (WebCore::AffineTransform::isInvertible): (WebCore::AffineTransform::inverse): (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::multLeft): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::scaleNonUniform): (WebCore::AffineTransform::rotateFromVector): (WebCore::AffineTransform::flipX): (WebCore::AffineTransform::flipY): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::skew): (WebCore::AffineTransform::skewX): (WebCore::AffineTransform::skewY): (WebCore::makeMapBetweenRects): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapPoint): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::blend): (WebCore::AffineTransform::toTransformationMatrix):
  • platform/graphics/transforms/AffineTransform.h: Added. (WebCore::AffineTransform::a): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::b): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::c): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::d): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::e): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::f): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator!=): (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*): (WebCore::AffineTransform::setMatrix):
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::getAffineCTM):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::getAffineCTM): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::transform):
  • platform/graphics/wx/TransformationMatrixWx.cpp: (WebCore::AffineTransform::operator wxGraphicsMatrix):
08:22 Changeset [54136] by philn@webkit.org

2010-01-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] set playbin mute property depending on volume value
https://bugs.webkit.org/show_bug.cgi?id=31586

New API in MediaPlayer for mute control. 3 new methods are
introduced:

  • bool supportsMuting() const;
  • bool muted() const;
  • void setMuted(bool);

Platform MediaPlayer implementations can support it easily if the
underlying sound daemon/API supports muting (eg. not only setting
volume to 0) like PulseAudio for instance on Linux. At the moment
the only player supporting this new API is the
MediaPlayerPrivateGStreamer.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): (WebCore::HTMLMediaElement::mediaPlayerMuteChanged):
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::supportsMuting): (WebCore::NullMediaPlayerPrivate::setMuted): (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::muted): (WebCore::MediaPlayer::supportsMuting): (WebCore::MediaPlayer::setMuted): (WebCore::MediaPlayer::volumeChanged): (WebCore::MediaPlayer::muteChanged):
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerMuteChanged):
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsMuting): (WebCore::MediaPlayerPrivateInterface::setMuted):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::notifyMuteIdleCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedCallback): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::supportsMuting): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::muteChangedCallback): (WebCore::MediaPlayerPrivate::muteChanged): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

2010-01-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] set playbin mute property depending on volume value
https://bugs.webkit.org/show_bug.cgi?id=31586

New API in MediaPlayer for mute control

  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::volumeChanged): (WebKit::WebMediaPlayerClientImpl::muteChanged):
  • src/WebMediaPlayerClientImpl.h:
07:30 Changeset [54135] by ossy@webkit.org

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Platform dependent expected file added for test introduced in r53868,
because this test passes. Compared to png file and Mac expected file.

  • platform/qt/fast/lists/anonymous-items-expected.txt: Added.
07:03 Changeset [54134] by hausmann@webkit.org

[Qt] Build without SSL support is broken

Patch by Henry Haverinen <henry.haverinen@nokia.com> on 2010-02-01
Reviewed by Simon Hausmann.

Added missing #ifdefs for OpenSSL support and one null-pointer
check for the socket.

https://bugs.webkit.org/show_bug.cgi?id=34416

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:

(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::send):

06:05 Changeset [54133] by pfeldman@chromium.org

2010-02-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Fix rest of the NativeTextViewer (line numbers,
conditional breakpoints, selection).

05:58 QtWebKitBackportingFixes edited by andreas.kling@nokia.com
(diff)
05:54 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:11 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
04:43 QtWebKitBackportingFixes edited by kenneth@webkit.org
(diff)
02:50 Changeset [54132] by steveblock@google.com

Adds implementation of JavaString for V8.
https://bugs.webkit.org/show_bug.cgi?id=33953

Reviewed by Ariya Hidayat.

No new tests, build fix only.

  • bridge/jni/JNIBridge.h: Modified. Include JavaStringV8.h for V8
  • bridge/jni/v8: Added.
  • bridge/jni/v8/JavaStringV8.h: Added.

(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):

02:05 Changeset [54131] by oliver@apple.com

2010-02-01 Oliver Hunt <oliver@apple.com>

Windows build fix, update exports file (again)

01:56 Changeset [54130] by oliver@apple.com

2010-02-01 Oliver Hunt <oliver@apple.com>

Windows build fix, update exports file

01:43 Changeset [54129] by oliver@apple.com

2010-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321

Remove secondary Structure constructor, and make Structure store a copy
of the number of anonymous slots directly so saving an immediate allocation
of a property map for all structures with anonymous storage, which also
avoids the leaked property map on new property transition in the original
version of this patch.

We need to propagate the the anonymous slot count otherwise we can end up
with a structure recording incorrect information about the available and
needed space for property storage, or alternatively incorrectly reusing
some slots.

  • JavaScriptCore.exp:
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransition): (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::copyPropertyTable): (JSC::Structure::put): (JSC::Structure::remove): (JSC::Structure::insertIntoPropertyMapHashTable): (JSC::Structure::createPropertyMapHashTable):
  • runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::hasAnonymousSlots): (JSC::Structure::anonymousSlotCount):

2010-02-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC is failing to propagate anonymous slot count on some transitions
https://bugs.webkit.org/show_bug.cgi?id=34321

Add test case for modifying DOM objects with anonymous storage.

  • fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added.
  • fast/dom/Window/anonymous-slot-with-changes.html: Added.
01:27 Changeset [54128] by eric@webkit.org

2010-02-01 Alex Milowski <alex@milowski.com>

Reviewed by Darin Adler.

Added compile time debug support for mathml layout (block boundary & baseline)

  • mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::stretchToHeight): (WebCore::RenderMathMLBlock::paint):
  • mathml/RenderMathMLBlock.h:
00:50 Changeset [54127] by philn@webkit.org

2010-02-01 Philippe Normand <pnormand@igalia.com>

Rubber stamped by Xan Lopez.

Fixed compilation warning about unsigned vs signed comparison.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint):
Note: See TracTimeline for information about the timeline view.