Timeline


and

02/07/10:

16:42 Changeset [54475] by tony@chromium.org

2010-02-07 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Fix 2 pixel test baselines that are incorrect but passing
the fuzzy image diff.

editing/deleting/5390681.html should show a cursor, but doesn't.
In r42549, whitespace collapsing was changed but
editing/pasteboard/5387578.html's result wasn't updated to
reflect the collapsed whitespace.
https://bugs.webkit.org/show_bug.cgi?id=34632

  • platform/mac/editing/deleting/5390681-2-expected.checksum:
  • platform/mac/editing/deleting/5390681-2-expected.png:
  • platform/mac/editing/pasteboard/5387578-expected.checksum:
  • platform/mac/editing/pasteboard/5387578-expected.png:
14:26 Changeset [54474] by dbates@webkit.org

2010-02-07 Daniel Bates <dbates@webkit.org>

Unreviewed, fix Tiger layout test failure.

https://bugs.webkit.org/show_bug.cgi?id=34402

Adds expected layout test results for Tiger build.

  • platform/mac-tiger/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
13:43 Changeset [54473] by dbates@webkit.org

2010-02-07 Daniel Bates <dbates@webkit.org>

Unreviewed, fix layout test bots.

https://bugs.webkit.org/show_bug.cgi?id=34402

Adds expected layout test results for Leopard, Windows, and Qt ports.

  • platform/mac-leopard/fast/lists: Added.
  • platform/mac-leopard/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
  • platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
  • platform/win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
13:08 Changeset [54472] by dbates@webkit.org

2010-02-07 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=34402

Implements all of the numeric CSS3 list-style-types as per
section 4.3 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#numeric>.

Test: fast/lists/w3-css3-list-styles-numeric.html

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSValueKeywords.in:
  • inspector/front-end/SourceCSSTokenizer.re2js:
  • platform/text/CharacterNames.h: Added constant hyphenMinus.
  • rendering/RenderListMarker.cpp: (WebCore::): Defined enum SequenceType. (WebCore::toAlphabeticOrNumeric): Added. (WebCore::toAlphabetic): Modified to call WebCore::toAlphabeticOrNumeric. (WebCore::toNumeric): Added. (WebCore::listMarkerSuffix): (WebCore::listMarkerText): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/style/RenderStyle.h: (WebCore::):
  • rendering/style/RenderStyleConstants.h: Added numeric list style types and fixed indent level for the enum values. (WebCore::):

2010-02-07 Daniel Bates <dbates@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=34402

Tests that all of the numeric CSS3 list-style-types are supported.

  • fast/lists/w3-css3-list-styles-numeric.html: Added.
  • platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
12:47 Changeset [54471] by eric@webkit.org

2010-02-07 Ismail Donmez <ismail@namtrac.org>

Reviewed by Darin Adler.

Include wtf/StringExtras.h for strdup definition, which
is needed for WinCE.

  • bridge/IdentifierRep.h:
04:52 Changeset [54470] by eric@webkit.org

2010-02-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Fragment-held Elements Not Shown in Inspector.

https://bugs.webkit.org/show_bug.cgi?id=34680

  • inspector/console-dirxml-expected.txt:
  • inspector/console-dirxml.html:

2010-02-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Fragment-held Elements Not Shown in Inspector.

https://bugs.webkit.org/show_bug.cgi?id=34680

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
04:35 Changeset [54469] by eric@webkit.org

2010-02-07 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

[chromium] Change chromium interface to handle DownloadURL format.
https://bugs.webkit.org/show_bug.cgi?id=34655

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clear): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::ChromiumDataObject):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::setData):

2010-02-07 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

[chromium] Change chromium interface to handle DownloadURL format.
https://bugs.webkit.org/show_bug.cgi?id=34655

  • public/WebDragData.h:
  • src/WebDragData.cpp: (WebKit::WebDragData::downloadMetadata): (WebKit::WebDragData::setDownloadMetadata):
03:42 Changeset [54468] by ossy@webkit.org

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662

Missing file added from the original bug: https://bugs.webkit.org/show_bug.cgi?id=32717

  • fast/frames/flattening/resources: Added.
  • fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
  • platform/qt/Skipped: frameset-flattening-subframe-resize.html unskipped.
03:28 Changeset [54467] by mrowe@apple.com

Move aside some old tags.

02/06/10:

12:18 Changeset [54466] by dglazkov@chromium.org

2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>

No review, rolling out r54364.
http://trac.webkit.org/changeset/54364
https://bugs.webkit.org/show_bug.cgi?id=34464

Introduced asserts in layout tests, needs more testing
locally.

  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
  • page/chromium/ChromeClientChromium.h:

2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>

No review, rolling out r54364.
http://trac.webkit.org/changeset/54364
https://bugs.webkit.org/show_bug.cgi?id=34464

Introduced asserts in layout tests, needs more testing
locally.

  • public/WebViewClient.h:
  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:
11:02 Changeset [54465] by dglazkov@chromium.org

2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Using inlines and function-level statics don't mix, according to gcc.
https://bugs.webkit.org/show_bug.cgi?id=34663

De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines.

It appears that the initialization check, generated by gcc doesn't account
for a possibility that the function may be inlined, resulting in lazy
initialization failure for more than one inlined instance of the function.

No behavior change, so no new tests.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::deviceRGBColorSpaceRef):
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
00:55 Changeset [54464] by barraclough@apple.com

Change UStringImpl::create to CRASH if the string cannot be allocated,
rather than returning a null string (which will behave like a zero-length
string if used).

Reviewed by Geoff Garen.

Also move createRep function from UString to become new overloaded
UStringImpl::create methods. In doing so, bring their behaviour closer to
being in line with WebCore::StringImpl, in removing the behaviour that they
can be used to produce null UStrings (ASSERT the char* provided is non-null).
This behaviour of converting null C-strings to null UStrings is inefficient
(cmompared to just using UString::null()), incompatible with WebCore::StringImpl's
behaviour, and may generate unexpected behaviour, since in many cases a null
UString can be used like an empty string.

With these changes UStringImpl need not have a concept of null impls, we can
start transitioning this to become an implementation detail of UString, that
internally it chooses to use a null-object rather than an actually zero impl
pointer.

(JSC::Debugger::recompileAllJSFunctions):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::calculatedFunctionName):

  • parser/Parser.cpp:

(JSC::Parser::parse):

  • profiler/Profile.cpp:

(JSC::Profile::Profile):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::stopProfiling):

  • runtime/Error.cpp:

(JSC::Error::create):
(JSC::throwError):

  • runtime/ExceptionHelpers.cpp:

(JSC::createError):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/UString.cpp:

(JSC::initializeUString):
(JSC::UString::UString):
(JSC::UString::operator=):

  • runtime/UString.h:

(JSC::UString::isNull):
(JSC::UString::null):
(JSC::UString::rep):
(JSC::UString::UString):

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:

02/05/10:

22:32 Changeset [54463] by ap@apple.com

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=34670
TestNetscapePlugin should work with Firefox

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if browser doesn't tell what it supports.
22:17 Changeset [54462] by mjs@apple.com

JavaScriptCore: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Configurations/FeatureDefines.xcconfig:

WebCore: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools: <rdar://problem/7485972> Disable SVG filters on branch
<rdar://problem/7555331> Disable WebGL on branch

Reviewed by Mark Rowe.

  • Scripts/build-webkit:
21:37 Changeset [54461] by hamaji@chromium.org

2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Gustavo Noronha Silva.

[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572

  • platform/gtk/Skipped:

2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Gustavo Noronha Silva.

[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_page_number_for_element_by_id):

2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Gustavo Noronha Silva.

[Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageNumberForElementById):
20:25 Changeset [54460] by ggaren@apple.com

Added an ASSERT to catch an implausible but theoretically possible leak.

Reviewed by Dan Bernstein.

In theory, if malloc allocated a UChar buffer directly after a StringImpl,
the StringImpl might incorrecly assume that the UChar buffer was inline,
and fail to delete it.

This ASSERT is somewhat academic, since we don't use the same allocator
in debug builds, but oh well.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::createUninitialized):

  • platform/text/StringImpl.h: Separated the inline buffer StringImpl

constructor from the out-of-line buffer StringImpl constructor. Made
the former ASSERT that its buffer was indeed inline, and the latter ASSERT
that its buffer was indeed not inline.

18:50 Changeset [54459] by ggaren@apple.com

Removed these special Windows expected results because they represented
incorrect behavior, fixed by a recent patch of mine.

Reviewed by Beth Dakin.

  • platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Removed.
18:44 Changeset [54458] by eric@webkit.org

2010-02-05 James Hawkins <jhawkins@chromium.org>

Reviewed by David Levin.

[Chromium] Rename autocomplete* to suggestions* to prepare for the
refactoring of AutocompletePopupMenuClient.

https://bugs.webkit.org/show_bug.cgi?id=34664

  • public/WebView.h:
  • src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::popupDidHide):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::doAutofill):
  • src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutofillSuggestions): (WebKit::WebViewImpl::hideAutofillPopup): (WebKit::WebViewImpl::hideSuggestionsPopup): (WebKit::WebViewImpl::refreshSuggestionsPopup):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::suggestionsPopupDidHide):
18:28 Changeset [54457] by eric@webkit.org

2010-02-05 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Define SYSTEM_MALLOC 1
https://bugs.webkit.org/show_bug.cgi?id=34640

Make BREWMP use system malloc because FastMalloc is not ported.

  • wtf/Platform.h:
17:30 Changeset [54456] by eric.carlson@apple.com

2010-02-05 Eric Carlson <eric.carlson@apple.com>

Unreviewed revert of r54454, until I can generate new results

  • media/video-loop-expected.txt:
  • media/video-loop.html:
17:10 Changeset [54455] by cmarrin@apple.com

Fixed changed virtual function in GraphicsLayerCACF and call order issues
https://bugs.webkit.org/show_bug.cgi?id=34348


The correct virtual function in GraphicsLayerCACF is now being
called. We also fixed an issue in QTMovieWin where the size
of the movie was not being set correctly because the call order
was changed.


I also changed the order of a couple of calls in QTMovieWin to account
for changed calling order from the logic above.

16:49 Changeset [54454] by eric.carlson@apple.com

2010-02-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=33671
[GTK] media/video-loop.html fails intermittently on Gtk Bots

Rewrite test to make it less timing dependent.

  • media/video-loop-expected.txt:
  • media/video-loop.html:
16:41 Changeset [54453] by mrowe@apple.com

Move aside another old branch.

16:41 Changeset [54452] by dpranke@chromium.org

2010-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Add a simple test implementation and the WebKit Mac implementation
for the layout_tests/port package. Also add a simple test driver of
that interface.

https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/webkitpy/layout_tests/driver_test.py: Added.
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/mac.py: Added.
  • Scripts/webkitpy/layout_tests/port/test.py: Added.
16:40 Changeset [54451] by mrowe@apple.com

Move aside some old branches.

16:29 Changeset [54450] by mrowe@apple.com

New branch.

16:01 Changeset [54449] by dpranke@chromium.org

2010-02-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

Refactor the port package into an object-oriented style and merge
path_utils into it. We add a 'base' and a 'chromium' object to the
port package; this will allow us to easily add new ports (like
WebKit Mac).

https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/run-chromium-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/base.py: Added.
  • Scripts/webkitpy/layout_tests/port/chromium.py: Added.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
15:11 Changeset [54448] by eric@webkit.org

2010-02-05 James Hawkins <jhawkins@chromium.org>

Reviewed by David Levin.

[Chromium] Remove an unused forward declaration in WebKitClient.h.

https://bugs.webkit.org/show_bug.cgi?id=34622

  • public/WebKitClient.h:
14:53 Changeset [54447] by kdecker@apple.com

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=34661
<rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
  • Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView. (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
14:40 Changeset [54446] by enrica@apple.com

Horizontal scrollbar works in reverse at milliondollarcu.be
<rdar://problem/7556121>
https://bugs.webkit.org/show_bug.cgi?id=33848

Reviewed by Simon Fraser.

Added a manual test.

  • manual-tests/win: Added.
  • manual-tests/win/horizontal-scroll-composited.html: Added.
  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):

14:24 Changeset [54445] by ossy@webkit.org

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662

  • platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix.
14:04 Changeset [54444] by ossy@webkit.org

Rubber-stamped by Kenneth Rohde Christiansen.

Update expected results after r54441 to make buildbot happy.

  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated.
13:58 Changeset [54443] by eric@webkit.org

2010-02-05 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

Implement WebInputElement::isActivatedSubmit().

https://bugs.webkit.org/show_bug.cgi?id=34623

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::isActivatedSubmit):
13:37 Changeset [54442] by eric@webkit.org

2010-02-05 Ryan Leavengood <leavengood@gmail.com>

Reviewed by David Levin.

Implementation of GlyphPage::fill() for Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=34527

Covered by existing tests.

  • platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp
13:21 Changeset [54441] by kenneth@webkit.org

Unreviewed, missed in earlier commit.

Add expected frame flattening results for Qt.

  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
12:47 Changeset [54440] by kenneth@webkit.org

Implement flattening of framesets
https://bugs.webkit.org/show_bug.cgi?id=32717

Reviewed by Dave Hyatt.

WebCore:

The following patch, builds ontop of Antti Koivisto's frameset
flattening code from the iPhone source, which itself is based on
the old Nokia Series 60 source.

Layout tests have been added to test the functionality and the original
code which has then been fixed to make these pass, as well as support
frameset grids.

Tests: fast/frames/flattening/frameset-flattening-advanced.html

fast/frames/flattening/frameset-flattening-grid.html
fast/frames/flattening/frameset-flattening-simple.html
fast/frames/flattening/frameset-flattening-subframe-resize.html
fast/frames/flattening/frameset-flattening-subframesets.html

  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setFrameSetFlatteningEnabled):

  • page/Settings.h:

(WebCore::Settings::frameSetFlatteningEnabled):

  • rendering/RenderFrame.cpp:

(WebCore::RenderFrame::layoutWithFlattening):

  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::flattenFrameSet):
(WebCore::RenderFrameSet::userResize):

  • rendering/RenderFrameSet.h:

WebKit/qt:

Privately export the setFrameSetFlatteningEnabled setting for
use with the Qt DRT.

  • Api/qwebpage.cpp:

(qt_drt_setFrameSetFlatteningEnabled):
(QWebPagePrivate::core):

  • Api/qwebpage_p.h:

WebKitTools:

Add support for testing frame flattening with the Qt DRT

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setFrameSetFlatteningEnabled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Frameset flattening layout test, plus expected result for Qt.

  • fast/frames/flattening/frameset-flattening-advanced.html: Added.
  • fast/frames/flattening/frameset-flattening-grid.html: Added.
  • fast/frames/flattening/frameset-flattening-simple.html: Added.
  • fast/frames/flattening/frameset-flattening-subframe-resize.html: Added.
  • fast/frames/flattening/frameset-flattening-subframesets.html: Added.
  • fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
  • platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
12:44 Changeset [54439] by cjerdonek@webkit.org

Provided a way in check-webkit-style to specify filter rules
on a per file or folder basis, via a configuration variable.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=33684

  • Scripts/webkitpy/style/checker.py:
    • Added _PATH_RULES_SPECIFIER configuration variable.
    • In ProcessorOptions class--
      • Changed the CategoryFilter attribute to FilterConfiguration.
      • Added path parameter to is_reportable().
    • Renamed ArgumentDefaults filter_rules attribute to base_filter_rules.
    • Updated ArgumentPrinter class.
    • Added filter rule validation to ArgumentParser (instead of in CategoryFilter constructor).
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated unit tests as necessary.
    • Added unit tests for PATH_RULES_SPECIFIER.
  • Scripts/webkitpy/style/error_handlers.py:
    • Updated DefaultStyleErrorHandler to use file path when calling is_reportable().
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated unit tests as necessary.
  • Scripts/webkitpy/style/filter.py:
    • Marked CategoryFilter internal with an underscore.
    • Removed argument validation from CategoryFilter.
    • Added FilterConfiguration class.
  • Scripts/webkitpy/style/filter_unittest.py:
    • Updated CategoryFilterTest class.
    • Added FilterConfigurationTest unit tests.
  • Scripts/webkitpy/style/processors/cpp.py:
    • Removed _is_test_filename() code.
    • Removed hard-coded path checks from check_include_line().
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
    • Removed three unit tests related to exempted files.
11:50 Changeset [54438] by simon.fraser@apple.com

2010-02-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Changing display type of parent of input on focus causes input field to not receive key events
https://bugs.webkit.org/show_bug.cgi?id=34620
<rdar://problem/7584572>

When layout affects a text input, the RenderTextControl gets destroyed and
recreated, which in turn makes a new innerTextElement. However, if the text field was
focused, the VisibleSelection is left pointing to the old innerTextElement, so text
input no longer works.

The fix is to call updateFocusAppearanceSoon() when attaching the input element,
which will update the selection if necessary.

Test: fast/forms/restore-selection-after-layout.html

  • dom/Document.h: Add a paramter to updateFocusAppearanceSoon() and a member variable, m_updateFocusAppearanceRestoresSelection, to store its value until the timer fires.
  • dom/Document.cpp: (WebCore::Document::Document): Initialize m_updateFocusAppearanceRestoresSelection (WebCore::Document::updateFocusAppearanceSoon): New restorePreviousSelection parameter. (WebCore::Document::updateFocusAppearanceTimerFired): Pass m_updateFocusAppearanceRestoresSelection down.
  • dom/Element.cpp: (WebCore::Element::attach): Call updateFocusAppearanceSoon() with false.
  • dom/Element.h: The updateFocusAppearanceSoonAfterAttach() was undefined.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach): Call document()->updateFocusAppearanceSoon() with true.
11:46 Changeset [54437] by kenneth@webkit.org

[Qt] Apply the command line options as settings to the graphics system.

Reviewed by Ariya Hidayat.

  • QtLauncher/main.cpp:

(LauncherWindow::LauncherWindow):
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):

  • QtLauncher/webview.h:

(WebViewGraphicsBased::setItemCacheMode):

11:30 Changeset [54436] by pfeldman@chromium.org

2010-02-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: simplify cookies view, introduce DataGrid::autoSizeColumns.

https://bugs.webkit.org/show_bug.cgi?id=34646

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.show): (WebInspector.CookieItemsView.prototype._update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain): (WebInspector.CookieItemsView.prototype._createDataGrid): (WebInspector.CookieItemsView.prototype._populateDataGrid.expiresCompare): (WebInspector.CookieItemsView.prototype._populateDataGrid): (WebInspector.CookieItemsView.prototype._createSimpleDataGrid): (WebInspector.CookieItemsView.prototype._populateSimpleDataGrid): (WebInspector.CookieItemsView.prototype._deleteCookieCallback): (WebInspector.CookieItemsView.prototype._refreshButtonClicked):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries): (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.autoSizeColumns):
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.dataGridForResult):
11:22 Changeset [54435] by pfeldman@chromium.org

2010-02-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: group cookies by frame, show total
cookies size, allow sorting cookie table.

https://bugs.webkit.org/show_bug.cgi?id=34617

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::deleteCookie):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._cookiesForDomain): (WebInspector.CookieItemsView.prototype.dataGridForCookies): (WebInspector.CookieItemsView.prototype._createNodes): (WebInspector.CookieItemsView.prototype._sortData.localeCompare): (WebInspector.CookieItemsView.prototype._sortData.numberCompare): (WebInspector.CookieItemsView.prototype._sortData.expiresCompare): (WebInspector.CookieItemsView.prototype._sortData):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.showCookies): (WebInspector.CookieSidebarTreeElement): (WebInspector.CookieSidebarTreeElement.prototype.onselect): (WebInspector.CookieSidebarTreeElement.prototype.get subtitle): (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
11:08 Changeset [54434] by eric@webkit.org

2010-02-05 Maxime Simone <simon.maxime@gmail.com>

Reviewed by David Levin.

More robust conversion from BString to String for Haiku port.
https://bugs.webkit.org/show_bug.cgi?id=34527

Covered by existing tests.

  • platform/text/haiku/StringHaiku.cpp: Fixed include order, Improved coversion from BString.
10:44 Changeset [54433] by mrowe@apple.com

Merge r54430.

10:43 Changeset [54432] by mrowe@apple.com

Versioning.

10:41 Changeset [54431] by mrowe@apple.com

New tag.

10:35 Changeset [54430] by sfalken@apple.com

Windows build fix.

Reviewed by Adam Roben.

  • WebCore.vcproj/WebCore.make:
10:08 Changeset [54429] by ossy@webkit.org

Rubber-stamped by Kenneth Rohde Christiansen.
Reviewed by Dirk Schulze.

[Qt] Modifying SVG path dumping to equal to other ports
https://bugs.webkit.org/show_bug.cgi?id=33784

WebCore:

  • platform/graphics/qt/PathQt.cpp:

(WebCore::Path::debugString): Path dumping style is aproached to Mac.

LayoutTests:

Expected files updated.

  • platform/qt/svg/css/arrow-with-shadow-expected.txt:
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/qt/svg/css/clippath-with-shadow-expected.txt:
  • platform/qt/svg/css/mask-with-shadow-expected.txt:
  • platform/qt/svg/css/path-with-shadow-expected.txt:
  • platform/qt/svg/css/stars-with-shadow-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/qt/svg/custom/marker-opacity-expected.txt:
  • platform/qt/svg/custom/marker-referencePoint-expected.txt:
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
  • platform/qt/svg/custom/mask-with-default-value-expected.txt:
  • platform/qt/svg/custom/relative-sized-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/transformedMaskFails-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
09:46 Changeset [54428] by ggaren@apple.com

2010-02-05 Kwang Yul Seo <skyul@company100.net>

Reviewed by Alexey Proskuryakov.

Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569

With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.


However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.

If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.

  • wtf/FastMalloc.cpp: (WTF::fastMalloc): (WTF::fastCalloc):

2010-02-05 Sebastian Dröge <sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34317

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::doGstInit):
  • platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gtk/WebKitWebSourceGStreamer.h: Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure. This makes sure that referer, cookies, authentication information and all kinds of other context are passed to GStreamer for websites like Vimeo or YouTube.
09:24 Changeset [54427] by kov@webkit.org

2010-02-05 Sebastian Dröge <sebastian.droege@collabora.co.uk>

Reviewed by Gustavo Noronha.

Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34317

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::doGstInit):
  • platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gtk/WebKitWebSourceGStreamer.h: Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure. This makes sure that referer, cookies, authentication information and all kinds of other context are passed to GStreamer for websites like Vimeo or YouTube.
08:41 Changeset [54426] by vestbo@webkit.org

[Qt] Fix build on Windows

Reviewed by Kenneth Rohde Christiansen.

DerivedSources for our API headers failed on Windows,
due to Windows not accepting ; as a command separator,
not needing quotes for echo, and needing < and > escaped.

We now detect Windows and set these quote markers and
escape markers accordingly, as well as use && for separating
individual commands.

  • Api/DerivedSources.pro:
08:28 Changeset [54425] by japhet@chromium.org

2010-02-05 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Clean up code for getting a v8::FunctionTemplate.


https://bugs.webkit.org/show_bug.cgi?id=34606

  • bindings/scripts/CodeGeneratorV8.pm: Making GetTemplate() public
  • bindings/v8/V8Binding.cpp: (WebCore::configureTemplate):
  • bindings/v8/V8DOMWrapper.cpp: Remove getTemplate(), use V8ClassIndex::getTemplate() instead. (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::lookupDOMWrapper):
  • bindings/v8/V8Index.cpp: Remove duplicate caching of FunctionTemplates. (WebCore::V8ClassIndex::getTemplate):
  • bindings/v8/V8Index.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::toV8):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback): (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.h:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): (WebCore::V8HTMLImageElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLImageElementConstructor.h:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback): (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScriptHostV8Wrapper):
08:01 Changeset [54424] by ossy@webkit.org

Rubber-stamped by Tor Arne Vestbø.

[Qt] fast/css/dashboard-regions-attr-crash.html skipped,
because ENABLE_DASHBOARD_SUPPORT=0 is the default option.

  • platform/qt/Skipped:
07:09 Changeset [54423] by eric@webkit.org

2010-02-05 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Add .gitattributes file to tell git about files with Windows linefeeds
https://bugs.webkit.org/show_bug.cgi?id=34645

On Windows git defaults to "true" for core.autocrlf, meaning all text
files in the working directory are converted from CRLF to LF on checkin
time. Some files present in the repository have been checked in with
CRLF linefeeds and git should not try to convert them. The added
.gitattributes file tells git to not do any CRLF conversion.

  • .gitattributes: Added.
06:10 Changeset [54422] by hausmann@webkit.org

[Qt] Build break in QtWebkit on Symbian
https://bugs.webkit.org/show_bug.cgi?id=34597

Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2010-02-05
Reviewed by Ariya Hidayat.

  • plugins/PluginView.h:
06:08 Changeset [54421] by yurys@chromium.org

2010-02-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

  • Use SerializedScriptValue for passing data between injected script and inspector frontend.
  • Remove custom JSON implementation from the instpector utility script.
  • Make sure that only objects created in the same ScriptState can be values of ScriptObject/Array properties and arguments to ScriptFunctionCall. We don't want ScriptObjects to leak between contexts.
  • Use ScriptState of the 'this' object in ScriptFunctionCall instead of passing it as additional parameter.

https://bugs.webkit.org/show_bug.cgi?id=33592

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript):
  • bindings/js/ScriptArray.cpp: (WebCore::ScriptArray::set):
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument):
  • bindings/js/ScriptFunctionCall.h:
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::ScriptValue::deserialize):
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptArray.cpp: (WebCore::ScriptArray::set):
  • bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::ScriptFunctionCall): (WebCore::ScriptFunctionCall::appendArgument):
  • bindings/v8/ScriptFunctionCall.h:
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptObject::set):
  • bindings/v8/ScriptState.h:
  • bindings/v8/ScriptValue.cpp: (WebCore::ScriptValue::serialize): (WebCore::deserialize):
  • bindings/v8/ScriptValue.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapForConsole): (WebCore::InjectedScript::releaseWrapperObjectGroup):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::didPause): (WebCore::InspectorController::didEvaluateForTestInFrontend):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::newScriptArray): (WebCore::InspectorFrontend::newScriptObject): (WebCore::InspectorFrontend::populateFrontendSettings): (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount): (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::didGetResourceContent): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::addRecordToTimeline): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfileHeader): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::didGetProfileHeaders): (WebCore::InspectorFrontend::didGetProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::setDocument): (WebCore::InspectorFrontend::setDetachedRoot): (WebCore::InspectorFrontend::setChildNodes): (WebCore::InspectorFrontend::childNodeCountUpdated): (WebCore::InspectorFrontend::childNodeInserted): (WebCore::InspectorFrontend::childNodeRemoved): (WebCore::InspectorFrontend::attributesUpdated): (WebCore::InspectorFrontend::didRemoveNode): (WebCore::InspectorFrontend::didGetChildNodes): (WebCore::InspectorFrontend::didApplyDomChange): (WebCore::InspectorFrontend::didGetEventListenersForNode): (WebCore::InspectorFrontend::didGetCookies): (WebCore::InspectorFrontend::didDispatchOnInjectedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::didGetDatabaseTableNames): (WebCore::InspectorFrontend::addDOMStorage): (WebCore::InspectorFrontend::selectDOMStorage): (WebCore::InspectorFrontend::didGetDOMStorageEntries): (WebCore::InspectorFrontend::didSetDOMStorageItem): (WebCore::InspectorFrontend::didRemoveDOMStorageItem): (WebCore::InspectorFrontend::updateDOMStorage): (WebCore::InspectorFrontend::addNodesToSearchResult): (WebCore::InspectorFrontend::contextMenuItemSelected): (WebCore::InspectorFrontend::evaluateForTestInFrontend): (WebCore::InspectorFrontend::callSimpleFunction):
  • inspector/InspectorFrontend.h: (WebCore::InspectorFrontend::scriptState):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName.myCallback): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.addConsoleMessage):

2010-02-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Remove unused inmport of ScriptFunctionCall.h

https://bugs.webkit.org/show_bug.cgi?id=33592

  • Api/qwebelement.cpp:
06:00 WebKit Team edited by krit@webkit.org
(diff)
05:23 Changeset [54420] by vestbo@webkit.org

[Qt] Generate convenience headers (QWebView, etc) using qmake

Reviewed by Simon Hausmann.

In Qt this is done using syncqt, but we use a pro-file instead
that generates makefile-rules for each of the extra headers.

These extra headers are installed alongside the normal headers.

WebCore:

  • WebCore.pro: Use headers.pri based on DerivedSources instead

of the one previously checked in in the source tree.

WebKit/qt:

  • Api/DerivedSources.pro: Added. List of headers + pro file magic
  • Api/headers.pri: Removed, list of headers is now in the above file

WebKitTools:

  • Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
04:27 Changeset [54419] by zoltan@webkit.org

Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569

Patch by Kwang Yul Seo <skyul@company100.net> on 2010-02-05
Reviewed by Alexey Proskuryakov.

With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.

However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.

If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.

  • wtf/FastMalloc.cpp:

(WTF::fastMalloc):
(WTF::fastCalloc):

04:20 Changeset [54418] by abecsi@webkit.org

2010-02-05 Andras Becsi <abecsi@webkit.org>

Unreviewed typo fix.

Fix wrong whitespace alignment introduced in r54342.

04:05 Changeset [54417] by eric@webkit.org

2010-02-05 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Enable JAVASCRIPT_DEBUGGER in chromium port.

https://bugs.webkit.org/show_bug.cgi?id=34638

  • page/Console.cpp:
  • page/Console.h:
  • page/Console.idl:

2010-02-05 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Enable JAVASCRIPT_DEBUGGER in chromium port.

https://bugs.webkit.org/show_bug.cgi?id=34638

  • features.gypi:
03:45 Changeset [54416] by kenneth@webkit.org

Rubberstamped by Oliver Hunt.

[Qt] Make it possible to choose whether the launcher should
use the traditional QWidget based QWebView or the newer
QGraphics based QGraphicsWebView on a QGraphicsView.

  • QtLauncher/main.cpp:

(LauncherWindow::LauncherWindow):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::print):
(LauncherWindow::screenshot):
(LauncherWindow::setEditable):
(LauncherWindow::setupUI):
(main):

  • QtLauncher/webview.cpp:

(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::resizeEvent):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::contextMenuEvent):

  • QtLauncher/webview.h:

(WebViewTraditional::WebViewTraditional):
(GraphicsWebView::GraphicsWebView):
(WebViewGraphicsBased::setPage):

02:50 Changeset [54415] by eric@webkit.org

2010-02-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Tab width for javascript source is 8, should be 4

https://bugs.webkit.org/show_bug.cgi?id=31248

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.set replaceTabsWithSpaces): (WebInspector.TextEditorModel.prototype._innerSetText): (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded):
01:37 Changeset [54414] by ukai@chromium.org

2010-02-05 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

send() should return false, after frame that opened a WebSokcet is detached
https://bugs.webkit.org/show_bug.cgi?id=34630

  • websocket/tests/send-after-close-on-unload-expected.txt: Added.
  • websocket/tests/send-after-close-on-unload.html: Added.
01:23 Changeset [54413] by tony@chromium.org

2010-02-05 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24872
Add a test to make sure copying from a list and pasting into a list
keeps the list at the same indention level rather than nesting.

  • editing/pasteboard/paste-list-002-expected.txt: Added.
  • editing/pasteboard/paste-list-002.html: Added.

2010-02-05 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24872
When pasting a list into another list should not indent another level.
If the cursor is at the beginning of the line, it should insert the
list items before the current list item. If the cursor is at the end
of the line, it should insert the list items after the current list item.

This matches Firefox and IE and makes the common activity of reordering a list
work as expected.

This also adds a small helper method (isListItem) to htmlediting.h.

Test: editing/pasteboard/paste-list-002.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertAsListItems):
  • editing/ReplaceSelectionCommand.h:
  • editing/htmlediting.cpp: (WebCore::isListItem): (WebCore::appendedSublist):
  • editing/htmlediting.h:

02/04/10:

23:45 Changeset [54412] by vestbo@webkit.org

[Qt] Make 'make -f Makefile.DerivedSources qmake' work

Reviewed by Lars Knoll.

Previously this target ended up generating a file named
Makefile.DerivedSources.DerivedSources, and so on.

  • DerivedSources.pro:
23:34 Changeset [54411] by mrowe@apple.com

Rubber-stamped by Dan Bernstein.

Fix the ability to #include <WebKit/DOMFile.h>.

  • MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.
23:18 Changeset [54410] by eric@webkit.org

2010-02-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin
https://bugs.webkit.org/show_bug.cgi?id=34509

Resubmit: The previous commit (r54333) was rolled back.

  • WebKit.gyp:
  • tests/TransparencyWinTest.cpp: Added. (WebCore::RECTToFloatRect): (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::operator<<): (WebCore::TEST):
  • tests/UniscribeHelperTest.cpp: Added. (WebCore::UniscribeTest::UniscribeTest): (WebCore::UniscribeTest::MakeFont): (WebCore::UniscribeTest::SetUp): (WebCore::UniscribeTest::TearDown): (TEST_F):
22:22 Changeset [54409] by mrowe@apple.com

Merge r54405.

22:22 Changeset [54408] by mrowe@apple.com

Versioning.

22:20 Changeset [54407] by mrowe@apple.com

New tag.

22:15 Changeset [54406] by ukai@chromium.org

2010-02-04 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

should not crash when document opened websocket is unloaded
https://bugs.webkit.org/show_bug.cgi?id=34562

  • websocket/tests/close-on-unload-and-force-gc-expected.txt: Added.
  • websocket/tests/close-on-unload-and-force-gc.html: Added.
  • websocket/tests/close-on-unload-reference-in-parent-expected.txt: Added.
  • websocket/tests/close-on-unload-reference-in-parent.html: Added.
  • websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Added.
22:13 Changeset [54405] by mrowe@apple.com

Build fix. Remove a symbol corresponding to an inline function from the linker export
file to prevent a weak external failure.

Reviewed by Timothy Hatcher.

JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj: Accommodate rename of script.

JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj: Accommodate rename of script.

WebCore:

  • WebCore.base.exp: Remove symbol.
  • WebCore.xcodeproj/project.pbxproj: Accommodate rename of script.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Accommodate rename of script.

WebKitTools:

  • Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.

Teach the script how to detect weak external symbols so that these errors can be caught immediately
in the future.

21:59 Changeset [54404] by ukai@chromium.org

2010-02-04 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

websocket/tests/close-on-unload.html failed on Mac Tiger
https://bugs.webkit.org/show_bug.cgi?id=34563

  • platform/mac-tiger/Skipped: remove websocket/tests/close-on-unload*.html
  • websocket/tests/close-on-unload_wsh.py: use dict instead of set.
21:33 Changeset [54403] by dbates@webkit.org

2010-02-04 Daniel Bates <dbates@webkit.org>

[Qt] Unreviewed, build fix for Qt bot.

  • runtime/JSStringBuilder.h: Changed #include <X.h> notation #include "X.h".
19:53 Changeset [54402] by ggaren@apple.com

Build fix: export a header.

19:47 Changeset [54401] by ggaren@apple.com

Build fix: Added a forwarding header.

  • ForwardingHeaders/runtime/WeakGCPtr.h: Added.
19:39 Changeset [54400] by ggaren@apple.com

WebCore: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>

Reviewed by Alexey Proskuryakov and Darin Adler.

There were two bugs here:

  1. A stale wrapper would invalidate a node's event listeners, even if

the node had a fresh wrapper keeping it alive.

The fix for this is for an event listener to keep a WeakGCPtr back-pointer
to the wrapper it expects to mark it. The wrapper destructor checks this
back-pointer, and only invalidates the event listener in the case of a match.

  1. Conversely, a stale wrapper would not invalidate a node's event

listeners soon enough, if its destructor didn't have a chance to run
before an event fired on the node. (This can only happen in cases where
we've made some other error and failed to mark a wrapper that was circuitously
observable in the DOM. But we know we have edge case bugs like this, and
we don't want them to be crashes.)

The fix for this is to check the wrapper back-pointer before firing the
event listener. As long as the the wrapper back-pointer is not null,
it's safe to fire the listener.

  • ForwardingHeaders/runtime/WeakGCPtr.h: Added. Appease build gods.
  • bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::markChildren):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::initializeJSFunction):
(WebCore::JSEventListener::invalidateJSFunction):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::create):
(WebCore::JSEventListener::isolatedWorld):
(WebCore::JSEventListener::wrapper):
(WebCore::JSEventListener::setWrapper):
(WebCore::JSEventListener::jsFunction):
(WebCore::createJSAttributeEventListener): Implemented the back-pointer
described above. Refactored the jsFunction() accessor to return 0 if
the wrapper back-pointer is 0.

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSLazyEventListener.h:

(WebCore::JSLazyEventListener::create):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::markChildren):
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.

  • bindings/js/ScriptEventListener.cpp:

(WebCore::createAttributeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.
(WebCore::getEventListenerHandlerBody): Updated for the fact that jsFunction()
is no longer a virtual accessor on the EventHandler base class.

  • bindings/scripts/CodeGeneratorJS.pm: Updated for the fact that jsFunction()

is no longer a virtual accessor on the EventHandler base class. Added a "JS"
to invalidateEventListeners and markEventListeners to clarify that these
actions are for JS event listeners only. Added a wrapper parameter to
invalidateEventListeners for the back-pointer check explained above.

  • dom/EventListener.h:

(WebCore::EventListener::invalidateJSFunction): ditto

  • dom/EventTarget.h:

(WebCore::EventTarget::markJSEventListeners):
(WebCore::EventTarget::invalidateJSEventListeners): ditto

LayoutTests: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>

Reviewed by Alexey Proskuryakov and Darin Adler.

  • fast/events/bogus-event-listener-invalidation-expected.txt: Added.
  • fast/events/bogus-event-listener-invalidation.html: Added.
19:06 Changeset [54399] by mrowe@apple.com

Versioning.

19:05 Changeset [54398] by mrowe@apple.com

Versioning.

19:03 Changeset [54397] by mrowe@apple.com

Versioning.

18:56 Changeset [54396] by mrowe@apple.com

Create tag Safari-533

18:38 Changeset [54395] by eric@webkit.org

2010-02-04 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25002
When inserting a new paragraph, avoid nesting empty divs. When
pasting near the end of a paragraph, this prevents each paste
command for getting nested one level deeper.

Three paste tests have been rebaselined since this causes the pasted
content to be outside the last div instead of inside. E.g.,
<div>foo<div>bar</div>[pasted content]</div> is now
<div>foo<div>bar</div></div><div>[pasted content]</div>

The new test verifies this behavior.

  • editing/inserting/paragraph-outside-nested-divs-expected.txt: Added.
  • editing/inserting/paragraph-outside-nested-divs.html: Added.
  • platform/mac/editing/pasteboard/paste-text-012-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-013-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-017-expected.txt:

2010-02-04 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25002
When inserting a new paragraph, avoid nesting empty divs. When
pasting near the end of a paragraph, this prevents each paste
command for getting nested one level deeper.

Test: editing/inserting/paragraph-outside-nested-divs.html

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::highestVisuallyEquivalentDiv): (WebCore::InsertParagraphSeparatorCommand::doApply):
18:31 Changeset [54394] by barraclough@apple.com

Add a JSStringBuilder class (similar-to, and derived-from StringBuilder) to
construct JSStrings, throwing a JS exception should we run out of memory whilst
allocating storage for the string.

Reviewed by Oliver Hunt.

Similarly, add jsMakeNontrivialString methods to use in cases where previously
we were calling makeString & passing the result to jsNontrivialString. Again,
these new methods throw if we hit an out of memory condition.

Move throwOutOfMemoryError into ExceptionHelpers, to make it more widely available.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):

  • runtime/DateConstructor.cpp:

(JSC::callDate):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToGMTString):

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

  • runtime/ExceptionHelpers.cpp:

(JSC::throwOutOfMemoryError):

  • runtime/ExceptionHelpers.h:
  • runtime/JSStringBuilder.h: Added.

(JSC::JSStringBuilder::releaseJSString):
(JSC::jsMakeNontrivialString):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToPrecision):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • runtime/Operations.cpp:
  • runtime/Operations.h:
  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncToString):

  • runtime/StringBuilder.h:

(JSC::StringBuilder::append):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):

18:09 Changeset [54393] by dumi@chromium.org

WebCore: 1. Fix a bug in SQLiteTransaction: do not assume that COMMIT always
succeeds.

  1. Jump straight to the transaction error callback when a

statement fails in a way that makes sqlite automatically rollback
the transaction.

  1. Fix the code that handles the "quota reached" failure, as it is

one of the failures that lead to an automatic transaction
rollback.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=34280

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::isAutoCommitOn):

  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteTransaction.cpp:

(WebCore::SQLiteTransaction::begin):
(WebCore::SQLiteTransaction::commit):
(WebCore::SQLiteTransaction::rollback):
(WebCore::SQLiteTransaction::transactionWasRolledBackBySqlite):

  • platform/sql/SQLiteTransaction.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):

LayoutTests: 1. Enhance quota-tracking.html: if sqlite automatically rolls back
a transaction because of a statement failure, make sure the rest
of the statements in the transaction are not executed.

  1. Fix the expectations for quota-tracking.html. Sqlite cannot

recover from reaching a DB's max size.

Reviewed by Eric Seidel.

  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:
17:50 Changeset [54392] by pkasting@chromium.org

Not reviewed, rollback.

Rollback r54387, it doesn't fix builds and Chromium doesn't want this behavior.

  • platform/chromium/ScrollbarThemeChromiumMac.h:
17:41 Changeset [54391] by sfalken@apple.com

Windows build fix.

  • wtf/MathExtras.h:
17:35 Changeset [54390] by mrowe@apple.com

Versioning.

17:33 Changeset [54389] by mrowe@apple.com

New tag.

17:01 Changeset [54388] by darin@apple.com

2010-02-04 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Make MathExtras.h compatible with <cmath>
https://bugs.webkit.org/show_bug.cgi?id=34618

  • wtf/MathExtras.h: Include <cmath> instead of <math.h>. Use "using" as we do elsewhere in WTF for the four functions from <cmath> we want to use without the prefix. Later we could consider making the std explicit at call sites instead.
16:52 Changeset [54387] by senorblanco@chromium.org

2010-02-04 Stephen White <senorblanco@chromium.org>

Unreviewed, build fix.

Fix for Chromium/Mac after palindromic scrollbar change (54345).

Covered by many layout tests.

  • platform/chromium/ScrollbarThemeChromiumMac.h: (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
16:35 Changeset [54386] by eric@webkit.org

2010-02-04 Clemmitt Sigler <cmsigler@gmail.com>

Reviewed by David Levin.

WebKitGTK doesn't build GtkLauncher when --enable-mathml is specified.
Updated WebCore/GNUmakefile.am to include needed files in build.

https://bugs.webkit.org/show_bug.cgi?id=34387

No new tests.

  • GNUmakefile.am:
16:29 Changeset [54385] by mrowe@apple.com

Versioning.

16:23 Changeset [54384] by mrowe@apple.com

New tag.

16:19 Changeset [54383] by eric@webkit.org

2010-02-04 Stephan Aßmus <superstippi@gmx.de>

Reviewed by David Levin.

Misc coding style fixes in Haiku port code.
https://bugs.webkit.org/show_bug.cgi?id=34527

No tests needed.

  • platform/haiku/ContextMenuItemHaiku.cpp: Trailing white space, NULL -> 0
  • platform/haiku/DragImageHaiku.cpp: Trailing white space.
  • platform/haiku/FileChooserHaiku.cpp: Sorted headers.
  • platform/haiku/LocalizedStringsHaiku.cpp: Needed to include NotImplemented.h
16:11 Changeset [54382] by mrowe@apple.com

Merge r54376.

15:50 Changeset [54381] by ossy@webkit.org

Unreviewed typo fix for r54379.

  • platform/qt/Skipped:
15:43 Changeset [54380] by eric@webkit.org

2010-02-04 Drew Wilson <atwilson@chromium.org>

Reviewed by David Levin.

WorkerContext.close() does not work in the chromium port
https://bugs.webkit.org/show_bug.cgi?id=34551

Test: Adding new downstream test.

  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::workerContextClosedTask): Now shuts down the worker thread when WorkerContext::close() is invoked.
15:36 Changeset [54379] by ossy@webkit.org

editing/pasteboard/drop-inputtext-acquires-style.html
introduced in r54368 skipped because of missing DnD support.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
15:33 Changeset [54378] by christian@webkit.org

2010-02-04 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

[GTK] Add and cleanup return values of signals in view and frame
https://bugs.webkit.org/show_bug.cgi?id=33484

Add missing and cleanup return values of web frame and web view signals.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
  • webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
15:30 Changeset [54377] by enrica@apple.com

Fixed crash on QT introduced with the fix for
https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Csaba Osztrogonac.

The test has been added with the original patch.

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::writePlainText): Added missing allocation of m_writeData.

15:29 Changeset [54376] by alice.liu@apple.com

https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
codes for most elements that arent listbox or menupopup related"
<rdar://problem/7436861>

Reviewed by Jon Honeycutt.

  • AccessibleBase.cpp:

(AccessibleBase::accSelect):

  • Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that aren't beneath listboxes or menupopups. This was too restrictive since any element can be selectable.
  • Correct the misinterpretation of MSDN's stipulation of situations involving adding, removing, and extending selection on single-select elements
14:51 Changeset [54375] by christian@webkit.org

2010-02-04 Christian Dywan <christian@twotasts.de>

Reviewed by Xan Lopez.

Require either libsoup 2.28.2 or 2.29.90.

  • configure.ac:

2010-02-04 Christian Dywan <christian@twotoasts.de>

Reviewed by Xan Lopez.

Conditionalize third party cookie policy for libsoup 2.29.90.

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
  • platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
14:50 Changeset [54374] by christian@webkit.org

2010-02-04 Christian Dywan <christian@twotoasts.de>

Rubber-stamped by Gustavo Noronha Silva.

Add ENABLE(VIDEO) guards around freeOwnedGPtr<GstElement> implementation.

  • platform/gtk/GOwnPtrGtk.cpp:
14:35 Changeset [54373] by ap@apple.com

Correct a mistake in ChangeLog entry.

14:12 Changeset [54372] by ap@apple.com

Reviewed by Darin Adler.

Assertion failure in CheckedRadioButtons::removeButton when using jQuery 1.4.1
https://bugs.webkit.org/show_bug.cgi?id=34520

Test: fast/dom/HTMLInputElement/cloned-input-checked-state.html

  • dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Copy non-attribute properties before attributes. Otherwise, copying "checked" property would make the cloned node checked, unchecking original (they share a name, and are thus in the same radio group). We do want the original to be unchecked, but we also want to know its original state in HTMLInputElement::copyNonAttributeProperties().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties): Use setChecked instead of plain assignment to prevent m_checked getting out of sync with checkedRadioButtons. Also, copy field related to default checked state, so that m_checked won't be overridden when copying attributes.
14:12 Changeset [54371] by kevino@webkit.org

[wx] Build fix after addition of Clipboard::writePlainText method.

14:10 Changeset [54370] by bfulgham@webkit.org

Properly handle margin settings when printing Plugins in WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=34613

Reviewed by Adam Roben.

  • WebFrame.cpp:

(WebFrame::spoolPage): Adjust the GraphicsContext passed to the

paintContents method so that the World Transform is properly
positioned to account for margin settings at the time that
PluginViewWin.cpp processes the drawing operations.

14:07 Changeset [54369] by mrowe@apple.com

Update auto-version.sh to better handle major version numbers with fewer than three digits,
and the case when WEBKITLIBRARIESDIR is not set.

Reviewed by Steve Falkenburg.

  • win/tools/scripts/auto-version.sh:
13:50 Changeset [54368] by enrica@apple.com

REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info.
<rdar://problem/7595685>
https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Oliver Hunt.

WebCore:

Test: editing/pasteboard/drop-inputtext-acquires-style.html

The dragging code did not distinguish the case of dragging the content of an input control
as a special case. The markup placed in the pasteboard included the style information.
I've modified the Clipboard class interface adding a new method writePlainText to match the
behavior of the copy and cut commands and modified the drag code to detect the special case.
I've modified all the platform specific implementations of the Clipboard class.

  • dom/Clipboard.h: Added writePlainText pure virtual function.
  • editing/Editor.cpp:

(WebCore::Editor::cut): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
(WebCore::Editor::copy): Renamed nodeIsTextFormControl to isNodeInTextFormControl.

  • editing/htmlediting.cpp:

(WebCore::isNodeInTextFormControl): Added, after removing the implementation with the old name
in Editor.cpp

  • editing/htmlediting.h:
  • page/DragController.cpp:

(WebCore::DragController::startDrag):

  • platform/Pasteboard.h:
  • platform/android/ClipboardAndroid.cpp:

(WebCore::ClipboardAndroid::writePlainText): Added.

  • platform/android/ClipboardAndroid.h:
  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::writePlainText): Added.

  • platform/chromium/ClipboardChromium.h:
  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::writePlainText): Added.

  • platform/gtk/ClipboardGtk.h:
  • platform/haiku/ClipboardHaiku.cpp:

(WebCore::ClipboardHaiku::writePlainText): Added.

  • platform/haiku/ClipboardHaiku.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writePlainText): Added.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writePlainText): Added helper function.

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::writePlainText): Added.

  • platform/qt/ClipboardQt.h:
  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writePlainText): Added.

  • platform/win/ClipboardWin.h:

LayoutTests:

  • editing/pasteboard/drop-inputtext-acquires-style-expected.txt: Added.
  • editing/pasteboard/drop-inputtext-acquires-style.html: Added.
13:45 Changeset [54367] by sullivan@apple.com

https://bugs.webkit.org/show_bug.cgi?id=34611
WebLocalizedString() could use an assertion that it is being called on the main thread

Reviewed by Tim Hatcher.

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Updated for renamed file (WebLocalizableStrings.m -> WebLocalizableStrings.mm)

WebKit/mac:

  • Misc/WebLocalizableStrings.m: Removed.
  • Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.

Renamed to use .mm extension so it can include a C++ header.
(WebLocalizedString):
Added an assertion that this is being called on the main thread.

13:19 Changeset [54366] by eric@webkit.org

2010-02-04 Steve Block <steveblock@google.com>

Reviewed by Nate Chapin.

Fix bug in V8 convertNPVariantToJValue when converting float and double types
https://bugs.webkit.org/show_bug.cgi?id=34593

No new tests, build fix only.

  • bridge/jni/v8/JNIUtilityPrivate.cpp: Modified. (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.
13:11 Changeset [54365] by kov@webkit.org

Tagging 1.1.20.

12:16 Changeset [54364] by darin@chromium.org

2010-02-04 Chris Guillory <chris.guillory@google.com>

Reviewed by Darin Fisher.

[Chromium] Notify ChromeClientChromium of AccessibilityObject state
change notifications.


https://bugs.webkit.org/show_bug.cgi?id=34464

  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::toChromeClientChromium): (WebCore::AXObjectCache::postPlatformNotification):
  • page/chromium/ChromeClientChromium.h:
12:10 Changeset [54363] by eric@webkit.org

2010-02-04 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Fisher.

Update comments to better document the possible values of the
writing direction menu state variables.

  • public/WebContextMenuData.h:
12:09 Changeset [54362] by loki@webkit.org

Use an easily appendable structure for trampolines instead of pointer parameters.
https://bugs.webkit.org/show_bug.cgi?id=34424

Patch by Tamas Szirbucz <szirbucz@inf.u-szeged.hu> on 2010-02-04
Reviewed by Gavin Barraclough.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • jit/JIT.h:

(JSC::JIT::compileCTIMachineTrampolines):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITStubs.cpp:

(JSC::JITThunks::JITThunks):

  • jit/JITStubs.h:

(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITThunks::ctiVirtualCallLink):
(JSC::JITThunks::ctiVirtualCall):
(JSC::JITThunks::ctiNativeCallThunk):

12:05 Changeset [54361] by senorblanco@chromium.org

2010-02-04 Stephen White <senorblanco@chromium.org>

Unreviewed, build fix for Chromium.

Revert r54341 ("[v8] Remove clear method from DOM object maps"),
since it causes the worker tests to fail on Chromium.

  • bindings/v8/DOMData.h: (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/DOMDataStore.h: (WebCore::ChunkedTable::clear): (WebCore::ChunkedTable::clearEntries): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::clear): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
  • bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThreadHelper): (WebCore::removeAllDOMObjectsInCurrentThread):
  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::clear):
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
11:39 Changeset [54360] by kevino@webkit.org

Build fix after changes in r54345.

11:29 Changeset [54359] by eric@webkit.org

2010-02-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crashes when an invalid hostname is pre-fetched
https://bugs.webkit.org/show_bug.cgi?id=34602

  • http/tests/misc/dns-prefetch-control-expected.txt:
  • http/tests/misc/dns-prefetch-control.html: Add broken hostname test case.

2010-02-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crashes when an invalid hostname is pre-fetched
https://bugs.webkit.org/show_bug.cgi?id=34602

  • platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS): NULL-check the SoupURI that is created from the hostname; that will happen for invalid hostnames.
11:10 Changeset [54358] by bweinstein@apple.com

Rubber-stamped by Dan Bernstein.

Add Windows expected results to the new scrollbar test because Windows was trying
to compare to platform/mac first instead of cross-platform.

  • platform/win/fast/events/scrollbar-double-click-expected.txt: Added.
10:52 Changeset [54357] by kenneth@webkit.org

Rubberstamped by Oliver Hunt.

[Qt] QtLauncher cleanup.

Refactor option handling out in utility functions and make the
arguments more Qt compatible.

  • QtLauncher/main.cpp:

(requiresGraphicsView):
(LauncherApplication::handleUserOptions):

  • QtLauncher/utils.cpp:

(takeOptionValue):
(formatKeys):
(enumToKeys):
(appQuit):

  • QtLauncher/utils.h:
10:42 Changeset [54356] by bfulgham@webkit.org

Properly handle margin settings in WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=34545

Reviewed by Adam Roben.

  • WebFrame.cpp:

(scaleFactor): Require the margin information as an input

parameter, and use them when computing the scaling factor.

(WebFrame::drawHeader): Pass margin size to scaleFactor.
(WebFrame::drawFooter): Pass margin size to scaleFactor.
(WebFrame::spoolPage):

  1. Pass margin size to scaleFactor.
  2. Recognize that the return value of printerMarginRect is already in device units, and therefore scale it so that the Cairo drawing is correct.
  3. Remove scaling call for margins in GDI code, as it is already in scaled units.
10:35 Changeset [54355] by eric@webkit.org

2010-02-04 José Millán Soto <jmillan@igalia.com>

Reviewed by Xan Lopez.

[Gtk] webkitgtk crashed when Orca open
https://bugs.webkit.org/show_bug.cgi?id=34463

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForObject): Checking if render objects are texts before calling toRenderText
10:21 Changeset [54354] by sfalken@apple.com

Merge r54348.

10:18 Changeset [54353] by sfalken@apple.com

Versioning.

10:09 Changeset [54352] by xan@webkit.org

2010-02-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump minimum libsoup requirement to 2.29.90

  • configure.ac:

WebCore:

2010-02-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Set first party URI in all SoupMessages. This allows libsoup to
implement a "no third party cookies" policy in case it wants
to. Also start a non-JSC-specific, gtk-specific GOwnPtr module and
use it for SoupURI.

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
10:06 Changeset [54351] by pfeldman@chromium.org

2010-02-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: group cookies by domains, not frame's domains.

https://bugs.webkit.org/show_bug.cgi?id=34599

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._cookiesForDomain):
  • inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addCookieDomain):
10:03 Changeset [54350] by sfalken@apple.com

New tag.

10:01 Changeset [54349] by japhet@chromium.org

2010-02-04 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Delete V8CustomBinding.h and all references to V8Custom

https://bugs.webkit.org/show_bug.cgi?id=32638

  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/custom/V8AbstractWorkerCustom.cpp:
  • bindings/v8/custom/V8AttrCustom.cpp:
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • bindings/v8/custom/V8CoordinatesCustom.cpp:
  • bindings/v8/custom/V8CustomBinding.h: Removed.
  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
  • bindings/v8/custom/V8DatabaseCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventSourceConstructor.cpp:
  • bindings/v8/custom/V8EventSourceCustom.cpp:
  • bindings/v8/custom/V8GeolocationCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback): (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDataGridElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback): (WebCore::V8HTMLImageElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback): (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8MessagePortCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8NodeFilterCustom.cpp:
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionCustom.cpp:
  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
  • bindings/v8/custom/V8SVGLengthCustom.cpp:
  • bindings/v8/custom/V8SharedWorkerCustom.cpp:
  • bindings/v8/custom/V8StorageCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.h:
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebKitPointConstructor.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
09:56 Changeset [54348] by sfalken@apple.com

Windows build fix for projects not defining WebKitLibrariesDir.

09:43 Changeset [54347] by ariya@webkit.org

2010-02-04 Ariya Hidayat <ariya.hidayat@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Unnecessary QBrush construction for doing a solid fill
https://bugs.webkit.org/show_bug.cgi?id=34559

Use the similar trick like r37421, i.e. use the special brush for
solid color to avoid creating QBrush again and again.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformFillColor):
09:41 Changeset [54346] by mitz@apple.com

REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371

Reviewed by Simon Fraser.

  • platform/mac/fast/events/scrollbar-double-click-expected.txt: Added.
09:35 Changeset [54345] by mitz@apple.com

REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371

Reviewed by Simon Fraser.

WebCore:

Allow ScrollbarTheme to cap the overlap between pages, and set a cap of
40 in ScrollbarThemeMac.

  • WebCore.base.exp: Export Scrollbar::maxOverlapBetweenPages().
  • editing/EditorCommand.cpp:

(WebCore::verticalScrollDistance): Use Scrollbar methods instead of
constants, and cap the scroll distance if needed.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::wheelEvent): Ditto.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::maxOverlapBetweenPages): Added. Returns the
value from the native scrollbar theme.

  • platform/Scrollbar.h: Replaced scroll amount constants with static methods.

(WebCore::Scrollbar::pixelsPerLineStep): Replaces cScrollbarPixelsPerLineStep.
(WebCore::Scrollbar::minFractionToStepWhenPaging): Replaces cFractionToStepWhenPaging.

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::maxOverlapBetweenPages): A base implementation
that returns the largest int.

  • platform/gtk/WheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.

  • platform/haiku/PlatformWheelEventHaiku.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.

  • platform/mac/ScrollbarThemeMac.h:

(WebCore::ScrollbarThemeMac::maxOverlapBetweenPages): An override
that returns 40.

  • platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use
Scrollbar::pixelsPerLineStep() instead of cScrollbarPixelsPerLineStep.

  • platform/wx/MouseWheelEventWx.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Use Scrollbar methods instead of
constants.

  • platform/wx/ScrollViewWx.cpp:

(WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): Use Scrollbar
methods instead of constants, and cap the scroll distance if needed.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Ditto.

WebKit/mac:

  • WebView/WebFrameView.mm:

(-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
constants, and cap the scroll distance.
(-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
cScrollbarPixelsPerLineStep.
(-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
constants, and cap the scroll distance.

WebKit/wx:

  • WebView.cpp:

(wxWebView::OnKeyEvents): Use Scrollbar method instead of constant.

08:56 Changeset [54344] by eric@webkit.org

2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.

https://bugs.webkit.org/show_bug.cgi?id=34062

This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs (WebCore::OpacityAnimationQt::updateState): style change

2010-02-04 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
of QTimer::singleShot, and moved syncLayers() from paint() to update()
https://bugs.webkit.org/show_bug.cgi?id=34062

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update): Moved the sync operation to update (QGraphicsWebView::paint): Moved the sync operation to update
08:39 Changeset [54343] by pfeldman@chromium.org

2010-02-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Cookies for resources are not shown in storage panel.

https://bugs.webkit.org/show_bug.cgi?id=34594

  • inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::cachedResource):
  • inspector/InspectorResource.h: (WebCore::InspectorResource::requestURL):
06:52 Changeset [54342] by abecsi@webkit.org

2010-02-04 Andras Becsi <abecsi@inf.u-szeged.hu>

Reviewed by Tor Arne Vestbø.

Implement a locking and scheduling mechanism for http testing sessions to be able
to run multiple instances of run-webkit-tests parallel on the same machine.
If a test session wants to run http tests and this feature is enabled, the pending
sessions create lockfiles with sequential lock numbers. These locks are used to schedule
the running test sessions in first come first served order. An exclusive lock ensures
that the lock numbers are sequential to avoid deadlocks and starvation.
Because the buildbot master specifies the flags used by slaves we need an environment
variable too to be able to use the feature per-slave.
Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
flag enables this feature, otherwise this patch has no effect on the testing whatsoever.

https://bugs.webkit.org/show_bug.cgi?id=33153

04:57 Changeset [54341] by eric@webkit.org

2010-02-04 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Remove clear method from DOM object maps
https://bugs.webkit.org/show_bug.cgi?id=34530

No new tests. Should be covered by existent testing infrastructure.

  • bindings/v8/DOMData.h:
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMMap.h:
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::~WorkerScriptController):
03:15 Changeset [54340] by eric@webkit.org

2010-02-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Increase test coverage for the QScriptValue.

https://bugs.webkit.org/show_bug.cgi?id=34533

  • qt/tests/qscriptvalue/qscriptvalue.pro:
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::tst_QScriptValue): (tst_QScriptValue::~tst_QScriptValue): (tst_QScriptValue::dataHelper): (tst_QScriptValue::newRow): (tst_QScriptValue::testHelper): (tst_QScriptValue::ctor):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h: Added.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Added. (tst_QScriptValue::initScriptValues): (tst_QScriptValue::isValid_initData): (tst_QScriptValue::isValid_makeData): (tst_QScriptValue::isValid_test): (tst_QScriptValue::isBool_initData): (tst_QScriptValue::isBool_makeData): (tst_QScriptValue::isBool_test): (tst_QScriptValue::isBoolean_initData): (tst_QScriptValue::isBoolean_makeData): (tst_QScriptValue::isBoolean_test): (tst_QScriptValue::isFunction_initData): (tst_QScriptValue::isFunction_makeData): (tst_QScriptValue::isFunction_test): (tst_QScriptValue::isNull_initData): (tst_QScriptValue::isNull_makeData): (tst_QScriptValue::isNull_test): (tst_QScriptValue::isString_initData): (tst_QScriptValue::isString_makeData): (tst_QScriptValue::isString_test): (tst_QScriptValue::isUndefined_initData): (tst_QScriptValue::isUndefined_makeData): (tst_QScriptValue::isUndefined_test): (tst_QScriptValue::isObject_initData): (tst_QScriptValue::isObject_makeData): (tst_QScriptValue::isObject_test):
02:55 Changeset [54339] by vestbo@webkit.org

Make run-webkit-tests work under Cygwin for the Qt port

Reviewed by Simon Hausmann.

setPathForRunningWebKitApp() is implemented for the Qt port
by using qmake to query for the location of the Qt libraries.

This requires the original environment (%ENV) to be untouched,
so launchWithCurrentEnv() was refactored to launchWithEnv(),
and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
instead. This has the added benefit of getting rid of the temp
variables used for storing the current env.

openDumpTool() is also refactored a bit into platform-spesific,
port-spesific, and generic environment variables.

Checks for undef was added a few places to fix Perl concat
warnings when run-webkit-tests is aborted.

https://bugs.webkit.org/show_bug.cgi?id=33895

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
02:50 Changeset [54338] by ossy@webkit.org

[Qt] fast/workers/shared-worker-frame-lifecycle.html failed on Qt Bot
https://bugs.webkit.org/show_bug.cgi?id=34281

  • platform/qt/Skipped: fast/workers/shared-worker-frame-lifecycle.html skipped until fix.
02:50 Changeset [54337] by zecke@webkit.org

[Gtk] Check if the renderer() exists in textForObject.

This is fixing a crash in the textForObject method. It can
happen when inspecting AtkObjects in the accerciser, then
navigating to a new page and still inspecting the old tree.

In this case the AccessibilityObjectWrapperAtk was still
valid but the included renderer() was returning 0. Add a
check for the accObject->renderer() before trying to use
the result.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(textForObject):

02:20 Changeset [54336] by yuzo@google.com

2010-02-04 Yuzo Fujishima <yuzo@google.com>

Unreviewed.

Add Yuzo to the committers list.

  • Scripts/webkitpy/committers.py:
02:06 Changeset [54335] by yurys@chromium.org

2010-02-04 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert 54333 which broke Chromium build.

  • WebKit.gyp:
  • tests/TransparencyWinTest.cpp: Removed.
  • tests/UniscribeHelperTest.cpp: Removed.
01:38 Changeset [54334] by yurys@chromium.org

2010-02-04 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Provide strongly typed C++ interface for inspector's injected script.

https://bugs.webkit.org/show_bug.cgi?id=33616

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.cpp: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapAndStringifyForConsole): (WebCore::InjectedScript::releaseWrapperObjectGroup):
  • inspector/InjectedScript.h: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::~InjectedScript): (WebCore::InjectedScript::hasNoValue):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
01:16 Changeset [54333] by eric@webkit.org

2010-02-04 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin.
https://bugs.webkit.org/show_bug.cgi?id=34509

  • WebKit.gyp:
  • tests/TransparencyWinTest.cpp: Added. (WebCore::RECTToFloatRect): (WebCore::drawNativeRect): (WebCore::getPixelAt): (WebCore::clearTopLayerAlphaChannel): (WebCore::clearTopLayerAlphaPixel): (WebCore::operator<<): (WebCore::TEST):
  • tests/UniscribeHelperTest.cpp: Added. (WebCore::UniscribeTest::UniscribeTest): (WebCore::UniscribeTest::MakeFont): (WebCore::UniscribeTest::SetUp): (WebCore::UniscribeTest::TearDown): (WebCore::TEST_F):
01:11 Changeset [54332] by philn@webkit.org

2010-02-04 Philippe Normand <pnormand@igalia.com>

Rubber stamped by Xan Lopez.

Missing include, build fix after landing of patch from the bug 34435.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
00:41 Changeset [54331] by eric@webkit.org

2010-02-04 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by David Levin.

[Chromium] WebKit side of "Writing direction" context menu on OS X.
https://bugs.webkit.org/show_bug.cgi?id=34524

  • public/WebContextMenuData.h: (WebKit::WebContextMenuData::):
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
00:32 Changeset [54330] by philn@webkit.org

2010-02-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] libsoup critical warning in media player http cookies injection code
https://bugs.webkit.org/show_bug.cgi?id=34435

Fixed the critical warning and refactored the
User-Agent/Referer/cookies injection code, in that order. Previous
order (cookies first) was wrong because if cookies injection could
not be done neither the User-Agent nor Referer were injected. Also
started a non-JSC-specific, gtk-specific GOwnPtr module.

  • GNUmakefile.am:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateSourceChangedCallback):
  • platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::SoupURI): (WTF::GstElement):
  • platform/gtk/GOwnPtrGtk.h: Added.
00:25 Changeset [54329] by eric@webkit.org

2010-02-04 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Put JSC-specific debugger & profiler code under "USE(JSC)" defines.
The plan is to enable "JAVASCRIPT_DEBUGGER" in Chromium and then
make this code engine-agnostic.

https://bugs.webkit.org/show_bug.cgi?id=34531

  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/JavaScriptCallFrame.cpp:
  • inspector/JavaScriptCallFrame.h:
  • inspector/JavaScriptDebugListener.h:
  • inspector/JavaScriptDebugServer.cpp:
  • inspector/JavaScriptDebugServer.h:
  • inspector/JavaScriptProfile.cpp:
  • inspector/JavaScriptProfile.h:
  • inspector/JavaScriptProfileNode.cpp:
  • inspector/JavaScriptProfileNode.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
  • page/Page.cpp: (WebCore::Page::Page):

02/03/10:

23:54 Changeset [54328] by dpranke@chromium.org

2010-02-03 Dirk Pranke <dpranke@chromium.org>

Rubber-stamped by Eric Seidel.

Change "the Chromium name" to "the name of Google Inc." in the licenses

https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/path_utils.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
23:51 Changeset [54327] by dpranke@chromium.org

2010-02-03 Dirk Pranke <dpranke@chromium.org>

Rubber-stamped by Eric Siedel.

Rename files as part of refactoring the layout_tests package. All
the platform_utils* module, the path_utils.py module, and
the http server and web socket server modules are moved into a new
port/ package.

https://bugs.webkit.org/show_bug.cgi?id=34511

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/init.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
  • Scripts/webkitpy/layout_tests/port/http_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server.py.
  • Scripts/webkitpy/layout_tests/port/http_server_base.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
  • Scripts/webkitpy/layout_tests/port/httpd2.pem: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
  • Scripts/webkitpy/layout_tests/port/lighttpd.conf: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
  • Scripts/webkitpy/layout_tests/port/path_utils.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
23:48 Changeset [54326] by eric@webkit.org

2010-02-03 Nicholas Young <nicholas.young@nokia.com>

Reviewed by Eric Carlson.

Defer formatting of times displayed on media controls to the current theme.
https://bugs.webkit.org/show_bug.cgi?id=34405

No new tests needed. Refactoring Only.

  • rendering/MediaControlElements.cpp: Removed formatTime() (WebCore::MediaControlTimeDisplayElement::setCurrentValue): No longer sets inner text
  • rendering/MediaControlElements.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateTimeDisplay): Asks the theme to format the time display elements
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::formatMediaControlsTime): new virtual method (WebCore::RenderTheme::formatMediaControlsCurrentTime): new virtual method (WebCore::RenderTheme::formatMediaControlsRemainingTime): new virtual method
  • rendering/RenderTheme.h:
23:30 Changeset [54325] by ukai@chromium.org

Unreviewed fix.

websocket/tests/close-on-unload.html and
close-on-navigate-new-location.html will fail on mac tiger,
because python on the platform doesn't support set(), which is
used in websocket handler for these tests.

  • platform/mac-tiger/Skipped: skip websocket/tests/close-on-unload.html and websocket/tests/close-on-navigate-new-location.html
23:26 Changeset [54324] by ukai@chromium.org

2010-02-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

navigating a frame to new location closes websocket in the frame
https://bugs.webkit.org/show_bug.cgi?id=34557

  • websocket/tests/close-on-navigate-new-location-expected.txt: Added.
  • websocket/tests/close-on-navigate-new-location.html: Added.
21:52 Changeset [54323] by sfalken@apple.com

Windows Debug_All build fix.

  • platform/graphics/win/WKCACFLayer.cpp:
19:57 Changeset [54322] by mrowe@apple.com

Remove an unnecessary backup file.

19:28 Changeset [54321] by beidson@apple.com

REGRESSION (r51644): WebCore/manual-tests/linkjump-1.html fails
<rdar://problem/7595694> and https://bugs.webkit.org/show_bug.cgi?id=34550

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: fast/loader/document-with-fragment-url-1.html

fast/loader/document-with-fragment-url-2.html
fast/loader/document-with-fragment-url-3.html
fast/loader/document-with-fragment-url-4.html

  • platform/KURL.cpp:

(WebCore::KURL::init): When resolving new URL from an empty reference relative to an absolute URL,

any fragment identifier from the absolute URL should be removed from the resulting resolution.

LayoutTests:

  • fast/loader/document-with-fragment-url-1-expected.txt: Added.
  • fast/loader/document-with-fragment-url-1.html: Added.
  • fast/loader/document-with-fragment-url-2-expected.txt: Added.
  • fast/loader/document-with-fragment-url-2.html: Added.
  • fast/loader/document-with-fragment-url-3-expected.txt: Added.
  • fast/loader/document-with-fragment-url-3.html: Added.
  • fast/loader/document-with-fragment-url-4-expected.txt: Added.
  • fast/loader/document-with-fragment-url-4.html: Added.
  • fast/loader/resources/document-with-fragment-url-test.html: Added.
18:49 Changeset [54320] by eric@webkit.org

2010-02-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Define WTF_PLATFORM_BREWMP_SIMULATOR when AEE_SIMULATOR is defined
https://bugs.webkit.org/show_bug.cgi?id=34514

PLATFORM(BREWMP_SIMULATOR) guard is needed to make distinction between BREWMP
and BREWMP simulator.

  • wtf/Platform.h:
18:24 Changeset [54319] by ukai@chromium.org

2010-02-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket should close the connection when unloading the document
https://bugs.webkit.org/show_bug.cgi?id=33248

  • websocket/tests/close-on-unload-expected.txt: Added.
  • websocket/tests/close-on-unload.html: Added.
  • websocket/tests/close-on-unload_wsh.py: Added.
  • websocket/tests/resources/close-on-unload-iframe.html: Added.
18:23 Changeset [54318] by eric@webkit.org

2010-02-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Port TextBreakIteratorInternalICU
https://bugs.webkit.org/show_bug.cgi?id=34515

Port TextBreakIteratorInternalICU.

  • platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Added. (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
17:52 Changeset [54317] by adele@apple.com

WebCore: Fix for <rdar://problem/7594212>
https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319

Reviewed by Simon Fraser.

Test: fast/css/counters/counter-before-selector-crash.html

  • rendering/RenderCounter.cpp: (WebCore::updateCounters): nil check.

LayoutTests: Test for: <rdar://problem/7594212>
https://bugs.webkit.org/show_bug.cgi?id=34549 - CSS counters crash at http://www.w3.org/TR/css3-content/
CrashTracer: [USER] 20 crashes in Safari at com.apple.WebCore: WebCore::CounterNode::insertAfter + 319

Reviewed by Simon Fraser.

  • fast/css/counters/counter-before-selector-crash-expected.txt: Added.
  • fast/css/counters/counter-before-selector-crash.html: Added.
17:32 Changeset [54316] by adele@apple.com

Initialize the variable in the last checkin to false. I didn't realize DRT relies on this being false.
So ports that want visited link tracking need to set that flag.

Reviewed by Brady Eidson.

  • page/PageGroup.cpp:
17:09 Changeset [54315] by mrowe@apple.com

Merge r54311.

17:07 Changeset [54314] by ossy@webkit.org

Rubber-stamped by Eric Seidel.

Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399

  • Scripts/run-iexploder-tests:
  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
  • Scripts/webkitperl/httpd.pm: Added.
16:50 Changeset [54313] by adele@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=34547
static shouldTrackVisitedLinks is not initialized

Reviewed by Brady Eidson.

For ports that don't call into WebKit to initialize this,
we should initialize to true so they get the visited link behavior by default.

  • page/PageGroup.cpp:
16:32 Changeset [54312] by ossy@webkit.org

Rubber-stamped by Eric Seidel.

Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots

  • Scripts/run-iexploder-tests:
  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
  • Scripts/webkitperl/httpd.pm: Removed.
16:26 Changeset [54311] by mitz@apple.com

<rdar://problem/7577604> Drag and Drop: background elements are bleeding through
https://bugs.webkit.org/show_bug.cgi?id=34546

Reviewed by Simon Fraser.

  • manual-tests/drag-image-table-part-decorations.html: Added.
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations): Bail out if this object shouldn’t
paint within the current painting root.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell): Ditto.
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

16:19 Changeset [54310] by mrowe@apple.com

Build fix.

15:47 Changeset [54309] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Add wxWebKitWindowFeatures and have createWindow send a notification for
clients to handle.

https://bugs.webkit.org/show_bug.cgi?id=34542

15:31 Changeset [54308] by mrowe@apple.com

Merge r54083.

15:31 Changeset [54307] by ossy@webkit.org

Rubber-stamped by Ariya Hidayat.

Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399

WebKitTools:

  • DumpRenderTree/win/EventSender.cpp:

(buildModifierFlags):
(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):

LayoutTests:

  • platform/win/Skipped:
15:06 Changeset [54306] by japhet@chromium.org

2010-02-03 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium mac build fix.

[V8] Remove unused V8Proxy* variable from generated wrapping code.

  • bindings/scripts/CodeGeneratorV8.pm:
14:33 Changeset [54305] by japhet@chromium.org

2010-02-03 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Use toV8() to wrap in the custom bindings, and remove
the old wrapping code from V8DOMWrapper.


https://bugs.webkit.org/show_bug.cgi?id=32563

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptObject.cpp:
  • bindings/v8/V8AbstractEventListener.cpp:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8NodeFilterCondition.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/WorkerContextExecutionProxy.h
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8CustomPositionCallback.cpp:
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8DocumentLocationCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8EventCustom.cpp:
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8MessageEventCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NodeIteratorCustom.cpp:
  • bindings/v8/custom/V8NodeListCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
  • bindings/v8/custom/V8SVGMatrixCustom.cpp:
  • bindings/v8/custom/V8StyleSheetListCustom.cpp:
  • bindings/v8/custom/V8TreeWalkerCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
14:32 Changeset [54304] by eric@webkit.org

2010-02-03 Eric Seidel <eric@webkit.org>

No review, just fixing copyrights.

Concerns were expressed about "The Chromium Authors" being
a valid legal entity for copyright assignment in the WebKit repository,
so this change removes all "The Chromium Authors".

I looked at the svn logs in src.chromium.org and failed to find any
non-google contributions to these files, so they are all now
marked as copyright "Google Inc" as all Google contributers assign
copyright to "Google Inc" as part of their employment agreement.

  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/run-chromium-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/layout_package/http_server.py:
  • Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
  • Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
14:26 Changeset [54303] by mrowe@apple.com

Merge r48879.

14:26 Changeset [54302] by mrowe@apple.com

Merge r48374.

14:26 Changeset [54301] by mrowe@apple.com

Merge r48364.

14:26 Changeset [54300] by mrowe@apple.com

Merge r48363.

14:23 Changeset [54299] by weinig@apple.com

Fix drawing buttons in viewless WebKit.

Reviewed by Anders Carlsson.

  • platform/mac/ThemeMac.mm:

(WebCore::paintButton): If there is no view, make sure to flip the
context so that the button is drawn correctly.

14:00 Changeset [54298] by yael.aharon@nokia.com

[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
https://bugs.webkit.org/show_bug.cgi?id=34425

Reviewed by Kenneth Rohde Christiansen.

Reverting r54279, it was a misunderstanding.

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:
13:44 Changeset [54297] by kenneth@webkit.org

[Qt] QtLauncher, refactor argument handling in preparation of merge
with QGVLauncher

Reviewed by Ariya Hidayat.

  • QtLauncher/main.cpp:

(LauncherApplication::urls):
(LauncherApplication::isRobotized):
(LauncherApplication::applyDefaultSettings):
(LauncherApplication::LauncherApplication):
(LauncherApplication::formatKeys):
(LauncherApplication::enumToKeys):
(fail):
(LauncherApplication::handleUserOptions):
(main):

13:43 Changeset [54296] by eric@webkit.org

2010-02-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Remove COMPILE_ASSERT conflict with the underlying PLATFORM
https://bugs.webkit.org/show_bug.cgi?id=34190

COMPILE_ASSERT conflicts with the underlying PLATFORM because it is defined
both in WTF's Assertions.h and BREWMP's AEEClassIDs.h. Include AEEClassIDs.h
in Assertions.h and undef COMPILE_ASSERT to avoid redefining COMPILE_ASSERT.

  • wtf/Assertions.h:
13:19 Changeset [54295] by ossy@webkit.org

Rubber-stamped by Ariya Hidayat.

Rolling out r53889, because it might caused flakeyness on the Windows Test bots
https://bugs.webkit.org/show_bug.cgi?id=34399

WebKitTools:

  • DumpRenderTree/win/EventSender.cpp:

(mouseDownCallback):
(mouseUpCallback):
(keyDownCallback):

LayoutTests:

  • platform/win/Skipped:
13:17 Changeset [54294] by eric@webkit.org

2010-02-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Implement OwnPtrBrew to make sure BREW instances are freed.
https://bugs.webkit.org/show_bug.cgi?id=34518

Add OwnPtrBrew to release IFile, IFileMgr and IBitmap instances.

  • wtf/brew/OwnPtrBrew.cpp: Added. (WTF::IFileMgr): (WTF::IFile): (WTF::IBitmap): (WTF::freeOwnedPtrBrew):
  • wtf/brew/OwnPtrBrew.h: Added. (WTF::OwnPtrBrew::OwnPtrBrew): (WTF::OwnPtrBrew::~OwnPtrBrew): (WTF::OwnPtrBrew::get): (WTF::OwnPtrBrew::release): (WTF::OwnPtrBrew::outPtr): (WTF::OwnPtrBrew::set): (WTF::OwnPtrBrew::clear): (WTF::OwnPtrBrew::operator*): (WTF::OwnPtrBrew::operator->): (WTF::OwnPtrBrew::operator!): (WTF::OwnPtrBrew::operator UnspecifiedBoolType): (WTF::OwnPtrBrew::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr):
12:58 Changeset [54293] by bweinstein@apple.com

Scroll does not work with IBM Thinkpad.
<https://bugs.webkit.org/show_bug.cgi?id=14227>
<rdar://7142545>

Reviewed by Steve Falkenburg.

When initializing the WebView, add two scrollbar Windows inside of
our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events.
(similar to what Firefox did in: <https://bugzilla.mozilla.org/show_bug.cgi?id=507222>.

Only do this if the user has installed some kind of Trackpoint driver, using an algorithm
like <https://bugzilla.mozilla.org/show_bug.cgi?id=514927>.

Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll
the WebView.

  • WebView.cpp:

(WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down

by lines or pages.

(WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right

by lines or pages.

(WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL.
(WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create

vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages.

(WebView::shouldInitializeTrackPointHack): Check if there is a registry key for

the some kind of IBM Trackpoint driver.

  • WebView.h:
12:14 Changeset [54292] by eric@webkit.org

2010-02-03 Drew Wilson <atwilson@chromium.org>

Reviewed by Alexey Proskuryakov.

SharedWorkerScriptLoader should not be an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=34513

Test: Existing tests suffice (fixes test downstream in Chrome).

  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to no longer derive from ActiveDOMObject (handles its own refcounting). (WebCore::SharedWorkerScriptLoader::load): Now increments own refcount when a load is pending. (WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to decrement refcount when load is complete.
  • workers/WorkerScriptLoaderClient.h: Documentation change about reliability of notifyFinished() when used from worker context.

2010-02-03 Drew Wilson <atwilson@chromium.org>

Reviewed by Alexey Proskuryakov.

SharedWorkerScriptLoader should not be an ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=34513

  • src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed SharedWorkerScriptLoader to manage its own lifecycle without using ActiveDOMObject. (WebCore::SharedWorkerScriptLoader::parentContext): (WebCore::pendingLoaders): Now we manually track pending loads so we can shut them down when the parent context shuts down. (WebCore::SharedWorkerScriptLoader::contextDetached): Shuts down/frees any pending worker loads. (WebCore::SharedWorkerScriptLoader::~SharedWorkerScriptLoader): Marks the SharedWorker object as not having pending activity if there was a load active (handles case where load was pending when parent document exits). (WebCore::SharedWorkerScriptLoader::load): (WebCore::SharedWorkerRepository::documentDetached): Now calls SharedWorkerScriptLoader::contextDetached() to shutdown any pending worker loads.
11:57 Changeset [54291] by eric@webkit.org

2010-02-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Inspector renders blank scripts on reloading the webpage.

https://bugs.webkit.org/show_bug.cgi?id=34537

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
11:41 Changeset [54290] by eric@webkit.org

2010-02-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Export WTF::fastStrDup symbol
https://bugs.webkit.org/show_bug.cgi?id=34526

11:39 Changeset [54289] by ossy@webkit.org

[Qt] Fix pixel tests support.
https://bugs.webkit.org/show_bug.cgi?id=27813

Reviewed by Ariya Hidayat.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):

  • Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.

(WebCore::DumpRenderTree::dump): Fixed and renamed variables.

11:02 Changeset [54288] by mitz@apple.com

Fixed a bug where WKSetNSURLConnectionDefersCallbacks(true) did not defer callbacks during modal dialogs.

Reviewed by Anders Carlsson.

  • libWebKitSystemInterfaceLeopard.a:
10:52 Changeset [54287] by kevino@webkit.org

Reviewed by Kevin Ollivier.

[wx] Enable JIT compilation for wx.

https://bugs.webkit.org/show_bug.cgi?id=34536

10:26 Changeset [54286] by yurys@chromium.org

2010-02-03 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert r54285 which failed to compile on Linux GTK.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.cpp: Removed.
  • inspector/InjectedScript.h: Removed.
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
10:11 Changeset [54285] by yurys@chromium.org

2010-02-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Provide strongly typed C++ interface for inspector's injected script.

https://bugs.webkit.org/show_bug.cgi?id=33616

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/InjectedScript.cpp: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::dispatch): (WebCore::InjectedScript::callFrames): (WebCore::InjectedScript::wrapAndStringify): (WebCore::InjectedScript::releaseWrapperObjectGroup):
  • inspector/InjectedScript.h: Added. (WebCore::InjectedScript::InjectedScript): (WebCore::InjectedScript::~InjectedScript): (WebCore::InjectedScript::hasNoValue):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForId): (WebCore::InjectedScriptHost::releaseWrapperObjectGroup):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::didPause): (WebCore::InspectorController::injectedScriptForNodeId):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontendScriptState):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
10:02 Changeset [54284] by abecsi@webkit.org

Unreviewed build fix.

[Qt] Roll-out r54281 because it broke the build on the Qt Release bot.

09:48 Changeset [54283] by eric@webkit.org

2010-02-03 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

[Chromium] Return a consistent set of platforms from WebDevToolsFrontendImpl
https://bugs.webkit.org/show_bug.cgi?id=34523

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::jsPlatform):
08:09 Changeset [54282] by levin@chromium.org

2010-02-02 Bryan Yeung <bryeung@google.com>

Reviewed by Darin Adler.

Avoid using an invalidated KURL object in baseURI.

https://bugs.webkit.org/show_bug.cgi?id=34492

This change fixes baseURI for Chromium (where the KURL implementation
does not allow invalid KURLs to carry relative paths). This is
regression tested by
LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg

This is a re-application of this patch since it was mistakenly identified as
the cause of a big chromium test regression and rolled out in r54264.

  • dom/Element.cpp: (WebCore::Element::baseURI):
08:01 Changeset [54281] by eric@webkit.org

2010-02-03 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Tuning and optimizations to GraphicsLayerQt. Reduce unnecessary
recaching, remove QTimer::singleShot and QPixmap::scaled, more
accurate strategy of handling transform operation blends. Rotating a
bordered-table, for example, now runs at 50FPS instead of 40FPS on Maemo5.

https://bugs.webkit.org/show_bug.cgi?id=34062

This is tested by https://bugs.webkit.org/show_bug.cgi?id=34450, fps measurements.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): Fine-tune caching (WebCore::TransformAnimationQt::TransformAnimationQt): transform bugs (WebCore::OpacityAnimationQt::updateState): style change

2010-02-03 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Tuning and optimizations to GraphicsLayerQt. Mainly reduced usage
of QTimer::singleShot, and moved syncLayers() from paint() to update()
https://bugs.webkit.org/show_bug.cgi?id=34062

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update): Moved the sync operation to update (QGraphicsWebView::paint): Moved the sync operation to update
07:37 Changeset [54280] by levin@chromium.org

WebCore: [Chromium] Make setCaretBlinkInterval static.
https://bugs.webkit.org/show_bug.cgi?id=31704

Patch by Joel Stanley <joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.

This is so it can be called from the newly exposed Chromium API setter
method.

  • rendering/RenderThemeChromiumLinux.cpp:
  • rendering/RenderThemeChromiumLinux.h:

WebKit/chromium: [Chromium] Add API method for setting caret blink frequency.
https://bugs.webkit.org/show_bug.cgi?id=31704

Patch by Joel Stanley <joel@jms.id.au> on 2010-02-02
Reviewed by David Levin.

This enables the RenderThemeChromiumLinux::setCaretBlinkInterval method
to be called Chromium's API. The API is linux-only as it is currently
the only port to implement RenderTheme::setCaretBlinkInterval.

  • WebKit.gyp: Add WebRenderTheme.{h,cpp}
  • public/linux/WebRenderTheme.h: Added.
  • src/linux/WebRenderTheme.cpp: Added.

(WebKit::setCaretBlinkInterval): Exposed API

05:42 Changeset [54279] by yael.aharon@nokia.com

[Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
https://bugs.webkit.org/show_bug.cgi?id=34425

Reviewed by Kenneth Rohde Christiansen.

Buffer the sent data in SocketStreamHandlePrivate instead of relying on
the network layer to do it. This is more robust and more consistent with how
Qt's HTTP stack works.
Close the socket in SocketStreamHandlePrivate::close() regardless of its state.

No new tests, since no new functionality is introduced.

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp:
05:02 Changeset [54278] by hamaji@chromium.org

2010-02-03 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed revert of r54259 as it seems to break chromium's unit tests.
The tests pass with r54257 but fail with r54260.
As r54258 and r54260 don't touch code, I'm reverting this change.

[V8] Generate toV8 conversion helpers, a la JSC bindings.
https://bugs.webkit.org/show_bug.cgi?id=32563

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
  • bindings/v8/V8Collection.h: (WebCore::getV8Object): (WebCore::toNativeCollection): (WebCore::getNamedPropertyOfCollection): (WebCore::collectionNamedPropertyGetter): (WebCore::getIndexedPropertyOfCollection): (WebCore::collectionIndexedPropertyGetter): (WebCore::nodeCollectionIndexedPropertyEnumerator): (WebCore::collectionIndexedPropertyEnumerator): (WebCore::collectionStringOrNullIndexedPropertyGetter): (WebCore::collectionStringIndexedPropertyGetter): (WebCore::setCollectionIndexedGetter): (WebCore::setCollectionNamedGetter): (WebCore::setCollectionStringOrNullIndexedGetter): (WebCore::setCollectionStringIndexedGetter):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::downcastSVGPathSeg): (WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object): (WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object): (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object): (WebCore::V8DOMWrapper::isDOMEventWrapper): (WebCore::V8DOMWrapper::htmlElementType): (WebCore::V8DOMWrapper::svgElementType): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::): (WebCore::V8DOMWrapper::convertDocumentToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::convertDOMImplementationToV8Object): (WebCore::V8DOMWrapper::convertStyleSheetToV8Object): (WebCore::V8DOMWrapper::convertCSSValueToV8Object): (WebCore::V8DOMWrapper::convertCSSRuleToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object): (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertToV8Object): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertNewNodeToV8Object): (WebCore::V8DOMWrapper::convertEventToV8Object): (WebCore::V8DOMWrapper::convertEventListenerToV8Object): (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException):
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toV8Object): (WebCore::V8CanvasRenderingContext2D::createPatternCallback):
  • bindings/v8/custom/V8CustomPositionCallback.cpp: (WebCore::V8CustomPositionCallback::handleEvent):
  • bindings/v8/custom/V8CustomPositionErrorCallback.cpp: (WebCore::V8CustomPositionErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp: (WebCore::V8CustomSQLStatementCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: (WebCore::V8CustomSQLTransactionCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openCallback): (WebCore::V8DOMWindow::indexedPropertyGetter): (WebCore::V8DOMWindow::namedPropertyGetter):
  • bindings/v8/custom/V8DataGridColumnListCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::evaluateCallback): (WebCore::V8Document::getCSSCanvasContextCallback): (WebCore::V8Document::implementationAccessorGetter):
  • bindings/v8/custom/V8DocumentLocationCustom.cpp: (WebCore::V8Document::locationAccessorGetter):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::V8Element::setAttributeNodeCallback): (WebCore::V8Element::setAttributeNodeNSCallback):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::V8Event::dataTransferAccessorGetter): (WebCore::V8Event::clipboardDataAccessorGetter):
  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLAllCollection::callAsFunctionCallback):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::V8Custom::v8HTMLAudioElementConstructorCallback):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::getItem): (WebCore::V8HTMLCollection::callAsFunctionCallback):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorGetter):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::V8HTMLFormElement::indexedPropertyGetter): (WebCore::V8HTMLFormElement::namedPropertyGetter):
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: (WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::V8Custom::v8HTMLImageElementConstructorCallback):
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp: (WebCore::V8HTMLSelectElement::namedPropertyGetter): (WebCore::V8HTMLSelectElement::indexedPropertyGetter):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::createInjectedScript): (WebCore::V8InjectedScriptHost::nodeForIdCallback): (WebCore::V8InjectedScriptHost::databaseForIdCallback):
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::portsAccessorGetter):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::indexedPropertyGetter): (WebCore::V8NamedNodeMap::namedPropertyGetter):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8NodeListCustom.cpp: (WebCore::V8NodeList::namedPropertyGetter): (WebCore::V8NodeList::callAsFunctionCallback):
  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: (WebCore::V8SVGMatrix::multiplyCallback): (WebCore::V8SVGMatrix::inverseCallback): (WebCore::V8SVGMatrix::rotateFromVectorCallback):
  • bindings/v8/custom/V8StyleSheetListCustom.cpp: (WebCore::V8StyleSheetList::namedPropertyGetter):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8Object):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object):
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp: (WebCore::V8XSLTProcessor::transformToFragmentCallback): (WebCore::V8XSLTProcessor::transformToDocumentCallback):
02:54 Changeset [54277] by eric@webkit.org

2010-02-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Start unforking debugger and profiler code.

Remove custom implementation of Console.
Add 'ScriptProfiler' and 'ScriptProfile' types.
Start migration to engine-neutral types in InspectorController.

https://bugs.webkit.org/show_bug.cgi?id=34481

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/ScriptProfile.h: Added.
  • bindings/js/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
  • bindings/js/ScriptProfiler.h: Added.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptProfile.h: Added. (WebCore::ScriptProfile::create): (WebCore::ScriptProfile::~ScriptProfile): (WebCore::ScriptProfile::title): (WebCore::ScriptProfile::uid): (WebCore::ScriptProfile::ScriptProfile):
  • bindings/v8/ScriptProfiler.cpp: Added. (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
  • bindings/v8/ScriptProfiler.h: Added.
  • bindings/v8/custom/V8ConsoleCustom.cpp: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::endGroup): (WebCore::InspectorController::show): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::addStartProfilingMessageToConsole): (WebCore::InspectorController::createProfileHeader): (WebCore::InspectorController::getCurrentUserInitiatedProfileName): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::specialPanelForJSName):
  • inspector/InspectorController.h: (WebCore::InspectorController::searchingForNodeInPage):
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
  • page/Console.h: (WebCore::): (WebCore::Console::create): (WebCore::Console::profiles):
  • page/Console.idl:
02:13 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
01:50 Changeset [54276] by mnaganov@chromium.org

Add myself to commiters.py

00:11 Changeset [54275] by ossy@webkit.org

Rubber-stamped by Adam Barth.

http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349

  • platform/win/Skipped: http/tests/security/xss-DENIED-window-open-javascript-url.html skipped.
Note: See TracTimeline for information about the timeline view.