Timeline


and

02/16/10:

23:56 Changeset [54875] by bweinstein@apple.com

Touch WebKit.idl to fix the build

23:38 Changeset [54874] by cjerdonek@webkit.org

Some minor check-webkit-style code clean-ups. This revision
contains no new functionality.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34932

  • Scripts/check-webkit-style:
    • Replaced the call to webkit_argument_defaults() with a default parameter in the ArgumentParser constructor.
  • Scripts/webkitpy/style/checker.py:
    • Removed the WEBKIT prefix from the default global variables.
    • Prefixed several of the global variables with an underscore to reflect that they are used internally.
    • Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES.
    • Addressed a FIXME by changing the _PATH_RULES_SPECIFIER configuration from list-tuple pairs to list-list pairs.
    • Renamed style_categories() to _all_categories().
    • Renamed webkit_argument_defaults() to _check_webkit_style_defaults().
    • Renamed the ArgumentDefaults class to DefaultCommandOptionValues.
    • In the ArgumentParser class--
      • Renamed the doc_print attribute to stderr_write.
      • Other minor updates.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the import statements and unit test classes as necessary.
    • Added assertions to test _PATH_RULES_SPECIFIER more fully.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated the unit test classes as necessary.
    • Changed StyleErrorHandlerTestBase to store a list of error messages rather than just the last one.
  • Scripts/webkitpy/style/filter.py:
    • Altered FilterConfiguration._path_rules_from_path() to convert the path_rules list to a tuple.
  • Scripts/webkitpy/style/filter_unittest.py:
    • Updated the unit tests to reflect the change from tuples to lists in the _PATH_RULES_SPECIFIER configuration variable.
23:32 Changeset [54873] by eric@webkit.org

2010-02-16 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add a new setting which gives the option of assigning every file:///
to its own unique domain.

https://bugs.webkit.org/show_bug.cgi?id=34778

Test: Pending in forthcoming separate change due to non-trivial
dependencies.

  • dom/Document.cpp: (WebCore::Document::initSecurityContext): Place file:/// URI documents into their own unique domains if the new setting requires it.
  • page/Settings.h:
  • page/Settings.cpp: (WebCore::Settings::setAllowFileAccessFromFileURLs): Simple setter.
  • page/SecurityOrigin.h:
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::makeUnique): Add simple ability to force an origin to be considered unique.
23:12 Changeset [54872] by eric@webkit.org

2010-02-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: drosera/demo.js not syntax highlighted correctly.

https://bugs.webkit.org/show_bug.cgi?id=35008

  • inspector/front-end/SourceTokenizer.js: (WebInspector.SourceTokenizer.Registry): (WebInspector.SourceTokenizer.Registry.prototype.getTokenizer):
22:56 Changeset [54871] by eric@webkit.org

2010-02-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: prefer smooth scrolling to instant highlight.

https://bugs.webkit.org/show_bug.cgi?id=34978

21:57 Changeset [54870] by mrowe@apple.com

Fix a handful of other leaks seen on the buildbot.

Patch by Gavin Barraclough <barraclough@apple.com> on 2010-02-16
Reviewed by Mark Rowe.

  • runtime/UStringImpl.h:

(JSC::UStringOrRopeImpl::deref): Delegate through to the subclass version of deref to ensure that
the correct cleanup takes place. This function previously featured some code that attempted to
skip deletion of static UStringImpl's. Closer inspection revealed that it was in fact equivalent
to "if (false)", meaning that UStringImpl's which had their final deref performed via this function
were leaked.

21:26 Changeset [54869] by bweinstein@apple.com

Forgot a .get() because this is an OwnPtr

20:55 Changeset [54868] by bweinstein@apple.com

Try using m_qtVideoLayer instead of platformLayer() to fix the build

20:21 Changeset [54867] by bweinstein@apple.com

Build fix when Accelerated Compositing is on

20:06 Changeset [54866] by mrowe@apple.com

Fix a handful of leaks seen on the buildbot.

Reviewed by Gavin Barraclough.

  • runtime/UStringImpl.h:

(JSC::UStringOrRopeImpl::deref): Call URopeImpl::destructNonRecursive rather than delete
to ensure that the rope's fibers are also destroyed.

19:54 Changeset [54865] by eric@webkit.org

2010-02-16 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Nikolas Zimmermann.

SVG not rendered as background-image from data URI
https://bugs.webkit.org/show_bug.cgi?id=33630

  • platform/mac/svg/css/background-image-svg-expected.checksum: Added.
  • platform/mac/svg/css/background-image-svg-expected.png: Added.
  • platform/qt/svg/css/background-image-svg-expected.checksum: Added.
  • platform/qt/svg/css/background-image-svg-expected.png: Added.
  • svg/css/background-image-svg.html: Added.
  • svg/css/background-image-svg-expected.txt: Added.

2010-02-16 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Nikolas Zimmermann.

SVG not rendered as background-image from data URI
https://bugs.webkit.org/show_bug.cgi?id=33630

When the background image is an SVG image, and it is smaller than the area
it is supposed to fill, we were using renderSubTreeToImage to draw it.
That call was not going through all the drawing phases, and so the SVG itself
would not be drawn.

Test: svg/css/background-image-svg.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
19:37 Changeset [54864] by eric@webkit.org

2010-02-16 Bryan Yeung <bryeung@chromium.org>

Reviewed by Nikolas Zimmermann.

Remove the bounds on stroke width and miter for the skia platform.
https://bugs.webkit.org/show_bug.cgi?id=34954

Test: svg/custom/stroke-width-large.svg

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
19:27 Changeset [54863] by zimmermann@webkit.org

2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Correct typo in test name in Skipped list. Should turn SL slave green again.

  • platform/mac-snowleopard/Skipped:
19:25 Changeset [54862] by bweinstein@apple.com

Add a missing semicolon

19:21 Changeset [54861] by eric@webkit.org

2010-02-16 James Hawkins <jhawkins@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Remove calls to releaseRef when passing PassRefPtrs to base
classes. releaseRef releases the original pointer without decreasing
the reference count, and the base class constructor increases the
reference count, leading to a leak.

https://bugs.webkit.org/show_bug.cgi?id=35000

  • src/WebDocument.cpp: (WebKit::WebDocument::WebDocument):
  • src/WebElement.cpp: (WebKit::WebElement::WebElement):
  • src/WebFormElement.cpp: (WebKit::WebFormElement::WebFormElement):
  • src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement):
19:10 Changeset [54860] by zimmermann@webkit.org

2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to fix win slave. Skip same tests failing on SL, add bug references to skipped list.

  • platform/mac-snowleopard/Skipped:
  • platform/win/Skipped:
19:05 Changeset [54859] by eric@webkit.org

2010-02-16 Bryan Yeung <bryeung@chromium.org>

Reviewed by Nikolas Zimmermann.

Add a new layout test for large stroke widths in SVG.
This regression tests a bug in the Skia platform where the width was
limited to 512.

https://bugs.webkit.org/show_bug.cgi?id=34954

  • platform/mac/svg/custom/stroke-width-large-expected.checksum: Added.
  • platform/mac/svg/custom/stroke-width-large-expected.png: Added.
  • platform/mac/svg/custom/stroke-width-large-expected.txt: Added.
  • svg/custom/stroke-width-large.svg: Added.

2010-02-16 Bryan Yeung <bryeung@chromium.org>

Reviewed by Nikolas Zimmermann.

Remove the bounds on stroke width and miter for the skia platform.
https://bugs.webkit.org/show_bug.cgi?id=34954

Test: svg/custom/stroke-width-large.svg

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintForStroking):
18:49 Changeset [54858] by eric@webkit.org

2010-02-16 MORITA Hajime <morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

REGRESSION: SVG text disappaears after double click
https://bugs.webkit.org/show_bug.cgi?id=34880

  • platform/mac/svg/text/selection-doubleclick-expected.checksum: Added.
  • platform/mac/svg/text/selection-doubleclick-expected.png: Added.
  • platform/mac/svg/text/selection-doubleclick-expected.txt: Added.
  • platform/mac/svg/text/selection-tripleclick-expected.checksum: Added.
  • platform/mac/svg/text/selection-tripleclick-expected.png: Added.
  • platform/mac/svg/text/selection-tripleclick-expected.txt: Added.
  • svg/text/selection-doubleclick.svg: Added.
  • svg/text/selection-tripleclick.svg: Added.

2010-02-16 MORITA Hajime <morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

REGRESSION: SVG text disappaears after double click
https://bugs.webkit.org/show_bug.cgi?id=34880

Tests: svg/text/selection-doubleclick.svg

svg/text/selection-tripleclick.svg

  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::mayHaveSelection): Use InlineTextBox::selectionStartEnd() instead of RenderObject::selectionStartEnd() because latter may span multiple comparing startPos and endPos is irrelevant in some cases. former selectionStartEnd() is for single line and comparing startPos and endPos will make sense.
18:29 Changeset [54857] by ariya@webkit.org

2010-02-16 Ariya Hidayat <ariya.hidayat@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Allow scrolling to an anchor programmatically.
https://bugs.webkit.org/show_bug.cgi?id=29856

  • Api/qwebframe.cpp: (QWebFrame::scrollToAnchor): New API function.
  • Api/qwebframe.h:
  • tests/qwebframe/tst_qwebframe.cpp: New tests for scrollToAnchor().
18:25 Changeset [54856] by jberlin@webkit.org

Inspector should display Array lengths in the property lists.
https://bugs.webkit.org/show_bug.cgi?id=20695

Reviewed by Timothy Hatcher.

  • inspector/front-end/InjectedScript.js:

(injectedScriptConstructor):
For objects of type 'array' (which includes Arrays, NodeLists, and HTMLCollections), make the length of the object available via propertyLength on the proxy object.

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):
For properties that have propertyLength defined, append it to the displayed description.

18:16 Changeset [54855] by eric@webkit.org

2010-02-16 Yusuke Sato <yusukes@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
https://bugs.webkit.org/show_bug.cgi?id=34735

  • fast/css/font-face-opentype.html: Added.
  • fast/css/resources/Ahem.otf: Added. Ahem font which has CFF glyphs, converted from Ahem.ttf by FontForge (http://fontforge.sourceforge.net/).
  • platform/mac/fast/css/font-face-opentype-expected.checksum: Added.
  • platform/mac/fast/css/font-face-opentype-expected.png: Added.
  • platform/mac/fast/css/font-face-opentype-expected.txt: Added.

2010-02-16 Yusuke Sato <yusukes@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] OpenType font with CFF glyphs is not handled correctly on Windows XP
https://bugs.webkit.org/show_bug.cgi?id=34735

Use 0xFFFF as invalidGlyph when fontData is a OpenType font with CFF glyphs.

Test: fast/css/font-face-opentype.html

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
18:11 Changeset [54854] by ariya@webkit.org

2010-02-16 Ariya Hidayat <ariya.hidayat@gmail.com>

Reviewed by Laszlo Gombos.

Fix building with Qt < 4.6.
https://bugs.webkit.org/show_bug.cgi?id=34885

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
17:51 Changeset [54853] by dumi@chromium.org

Change quota-tracking.html to open databases only as they're
needed. Otherwise, open databases end up using more space from
this origin than the test expects.

Reviewed by Simon Fraser.

  • storage/quota-tracking.html:
17:42 Changeset [54852] by simon.fraser@apple.com

2010-02-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Nikolas Zimmermann.

Make this test more robust to slow-loading media.

  • media/video-load-networkState.html:
17:33 Changeset [54851] by darin@apple.com
  • page/MediaCanStartListener.h: Fixed license.
17:26 Changeset [54850] by zimmermann@webkit.org

2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Simon Fraser.

Skip svg/zoom/(page|text)/zoom-coords-viewattr-01-b.svg on SnowLeopard.
svg/W3C-SVG-1.1/coords-viewattr* fail on SL and are already Skipped, seems related to entity parsing, not SVG.

  • platform/mac-snowleopard/Skipped:
17:23 Changeset [54849] by darin@apple.com

2010-02-16 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Generalize delayed plug-in start for background tabs for use for other media
https://bugs.webkit.org/show_bug.cgi?id=34981

  • WebView.cpp: (WebView::setCanStartPlugins): Change to call setCanStartMedia. In a later patch we can change the of the public function in the IDL file too, but for now this should be enough.

2010-02-16 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Generalize delayed plug-in start for background tabs for use for other media
https://bugs.webkit.org/show_bug.cgi?id=34981

  • WebView/WebHTMLView.mm: (-[WebHTMLView viewWillMoveToWindow:]): Added comment. (-[WebHTMLView viewDidMoveToWindow]): Ditto.
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Call setCanStartMedia right away so that if this view is not in a window, it will not start any media. (-[WebView viewWillMoveToWindow:]): Call setCanStartMedia(false) when moving to a window of nil. (-[WebView viewDidMoveToWindow]): Call setCanStartMedia(true) when moved to a window that is non-nil.

2010-02-16 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Generalize delayed plug-in start for background tabs for use for other media
https://bugs.webkit.org/show_bug.cgi?id=34981

Also did some simple cleanup of HTMLMediaElement to get ready to make it
a client of the same mechanism.

  • WebCore.base.exp: Added Page::setCanStartMedia and resorted.
  • WebCore.xcodeproj/project.pbxproj: Added MediaCanStartListener.h.
  • html/HTMLAudioElement.h: Added an implementation of isVideo since that is now a pure virtual function in HTMLMediaElement. Also made tagPriority private.
  • html/HTMLMediaElement.h: Made it clearer that HTMLMediaElement is an abstract base class by making its constructor protected and making the isVideo function a pure virtual function.
  • page/Page.cpp: (WebCore::Page::Page): Updated for name change from m_canStartPlugins to m_canStartMedia. (WebCore::Page::addMediaCanStartListener): Renamed and added an assertion. (WebCore::Page::removeUnstartedMedia): Ditto. (WebCore::Page::setCanStartMedia): Renamed plugin to media and moved the code here from PageWin.cpp. The main change from the one in PageWin.cpp is that this function calls mediaCanStart rather than explicitly calling a combination of start and dispatchDidFailToStartPlugin on a PluginView.
  • page/Page.h: Re-sorted forward class declarations. Renamed the plugin starting functions to media starting names and changed types from PluginView to MediaCanStartListener.
  • page/MediaCanStartListener.h: Added.
  • page/win/PageWin.cpp: Moved setCanStartPlugins to the platform-independent Page.cpp file so it can be used for more than just Windows plug-ins.
  • plugins/PluginView.cpp: Sorted includes. (WebCore::PluginView::startOrAddToUnstartedList): Use addMediaCanStartListener. (WebCore::PluginView::mediaCanStart): Added. Called when the page decides that media can start. Contains the code that used to be in Page::setCanStartPlugins. (WebCore::PluginView::removeFromUnstartedListIfNecessary): Use removeMediaCanStartListener.
  • plugins/PluginView.h: Adopted MediaCanStartListener.
16:50 Changeset [54848] by simon.fraser@apple.com

2010-02-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=34999
Compositing layers inside overflow:scroll divs are not always updated on scrolling

When RenderLayer::scrollToOffset() updates compositing layer positions, it needs
to start updating at its stacking context rather than just its compositing ancestor.
The stacking context is guaranteed to contain all descendants of the overflow
layer, including those that are not direct descendants of the overflow layer in stacking
(and therefore compositing) order.

Test: compositing/overflow/scroll-ancestor-update.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
16:25 Changeset [54847] by barraclough@apple.com

Disable warnings preventing use of anonymous structs/onions -
don't take all my fun toys away, these are useful & awesome!

Reviewed by NOBODY (Build fix).

  • win/tools/vsprops/common.vsprops:
16:09 Changeset [54846] by zimmermann@webkit.org

2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Add missing .checksum file in platform/mac/svg/zoom/page. All parts of the original patch for bug 14004 have been landed.

  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.
16:08 Changeset [54845] by mitz@apple.com

Allow FloatRect::center() to return fractional coordinates. It was
mistakenly converting to integers.

Reviewed by Simon Fraser.

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::center):

16:05 Changeset [54844] by zimmermann@webkit.org

2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by David Hyatt.

SVG units don't stay consistently sized on zoom
https://bugs.webkit.org/show_bug.cgi?id=14004

  • platform/mac/svg/zoom: Added.
  • platform/mac/svg/zoom/page: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/mac/svg/zoom/text: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
  • svg/zoom: Added.
  • svg/zoom/NOTE: Added.
  • svg/zoom/page: Added.
  • svg/zoom/page/absolute-sized-document-no-scrollbars.svg: Added.
  • svg/zoom/page/absolute-sized-document-scrollbars.svg: Added.
  • svg/zoom/page/relative-sized-document-scrollbars.svg: Added.
  • svg/zoom/page/zoom-coords-viewattr-01-b.svg: Added.
  • svg/zoom/page/zoom-foreignObject.svg: Added.
  • svg/zoom/page/zoom-hixie-mixed-008.xml: Added.
  • svg/zoom/page/zoom-hixie-mixed-009.xml: Added.
  • svg/zoom/page/zoom-hixie-rendering-model-004.xhtml: Added.
  • svg/zoom/page/zoom-svg-float-border-padding.xml: Added.
  • svg/zoom/resources: Added.
  • svg/zoom/resources/testPageZoom.js: Added.
  • svg/zoom/resources/testTextZoom.js: Added.
  • svg/zoom/text: Added.
  • svg/zoom/text/absolute-sized-document-no-scrollbars.svg: Added.
  • svg/zoom/text/absolute-sized-document-scrollbars.svg: Added.
  • svg/zoom/text/relative-sized-document-scrollbars.svg: Added.
  • svg/zoom/text/zoom-coords-viewattr-01-b.svg: Added.
  • svg/zoom/text/zoom-foreignObject.svg: Added.
  • svg/zoom/text/zoom-hixie-mixed-008.xml: Added.
  • svg/zoom/text/zoom-hixie-mixed-009.xml: Added.
  • svg/zoom/text/zoom-hixie-rendering-model-004.xhtml: Added.
  • svg/zoom/text/zoom-svg-float-border-padding.xml: Added.
16:01 Changeset [54843] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=34964
Leaks tool reports false memory leaks due to Rope implementation.

Reviewed by Oliver Hunt.

JavaScriptCore:

A rope is a recursive data structure where each node in the rope holds a set of
pointers, each of which may reference either a string (in UStringImpl form) or
another rope node. A low bit in each pointer is used to distinguish between
rope & string elements, in a fashion similar to the recently-removed
PtrAndFlags class (see https://bugs.webkit.org/show_bug.cgi?id=33731 ). Again,
this causes a problem for Leaks – refactor to remove the magic pointer
mangling.

Move Rope out from JSString.h and rename to URopeImpl, to match UStringImpl.
Give UStringImpl and URopeImpl a common parent class, UStringOrRopeImpl.
Repurpose an otherwise invalid permutation to flags (static & should report
memory cost) to identify ropes.

This allows us to change the rope's fibers to interrogate the object rather
than storing a bool within the low bits of the pointer (or in some cases the
use of a common parent class removes the need to determine the type at all -
there is a common interface to ref or get the length of either ropes or strings).

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::keyForCharacterSwitch):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

  • runtime/Identifier.cpp:

(JSC::Identifier::equal):
(JSC::Identifier::addSlowCase):

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):

  • runtime/JSString.h:

(JSC::):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::~JSString):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::JSStringFinalizerStruct::JSStringFinalizerStruct):
(JSC::RopeBuilder::JSStringFinalizerStruct::):

  • runtime/UString.cpp:

(JSC::UString::toStrictUInt32):
(JSC::equal):

  • runtime/UString.h:

(JSC::UString::isEmpty):
(JSC::UString::size):

  • runtime/UStringImpl.cpp:

(JSC::URopeImpl::derefFibersNonRecursive):
(JSC::URopeImpl::destructNonRecursive):

  • runtime/UStringImpl.h:

(JSC::UStringOrRopeImpl::isRope):
(JSC::UStringOrRopeImpl::length):
(JSC::UStringOrRopeImpl::ref):
(JSC::UStringOrRopeImpl::):
(JSC::UStringOrRopeImpl::operator new):
(JSC::UStringOrRopeImpl::UStringOrRopeImpl):
(JSC::UStringImpl::adopt):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):
(JSC::UStringImpl::data):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::):
(JSC::URopeImpl::tryCreateUninitialized):
(JSC::URopeImpl::initializeFiber):
(JSC::URopeImpl::fiberCount):
(JSC::URopeImpl::fibers):
(JSC::URopeImpl::deref):
(JSC::URopeImpl::URopeImpl):
(JSC::URopeImpl::hasOneRef):
(JSC::UStringOrRopeImpl::deref):

WebCore:

Renamed cUStringImpl::size() to UStringImpl::size()UStringImpl::length()
(matches WebCore::StringImpl).

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::length):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

15:55 Changeset [54842] by ossy@webkit.org

[Qt] REGRESSION(r54811) fast/canvas/drawImage-with-negative-source-destination.html fails
https://bugs.webkit.org/show_bug.cgi?id=35005

  • platform/qt/Skipped:
    • fast/canvas/drawImage-with-negative-source-destination.html skipped until fix.
    • inspector/timeline-paint.html skipped because it is flakey.
15:49 Changeset [54841] by jhoneycutt@apple.com

<rdar://problem/7288853> Message about missing plugin does not specify
the type or download link for download

Reviewed by Mark Rowe.

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::findPlugin):
Only update the mimeType out param if we find a plug-in for the file
extension.

15:41 Changeset [54840] by simon.fraser@apple.com

2010-02-16 Simon Fraser <simon.fraser@apple.com>

Build fix for Tiger.

Add #if USE(ACCELERATED_COMPOSITING) around the call to mediaPlayerRenderingModeChanged().

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::setUpVideoRendering):
15:03 Changeset [54839] by ossy@webkit.org

Buildfix for r54826.

Reviewed by Eric Carlson.

HTMLMediaElement class defined by HTMLMediaElement.h in #if ENABLE(VIDEO) block,
it should be in #if ENABLE(VIDEO) block in rendering/RenderLayerBacking.cpp too.

  • rendering/RenderLayerBacking.cpp: Missing #if ENABLE(VIDEO) guard added.

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

15:02 Changeset [54838] by mrowe@apple.com

Roll out the rest of r54833 as it includes more unrelated changes.

15:00 Changeset [54837] by mrowe@apple.com

Let's not check garbage in to common build scripts and hose the world now eh guys?

  • Scripts/webkitdirs.pm:
14:56 Changeset [54836] by jparent@chromium.org

Unreviewed: Chromium build fix.

http://trac.webkit.org/changeset/54823 introduced an unused variable. Remove it.

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

14:53 Changeset [54835] by mrowe@apple.com

Bug 34974: Leak of ScheduledAction during layout tests
<https://bugs.webkit.org/show_bug.cgi?id=34974>

Reviewed by Alexey Proskuryakov.

ScheduledAction::create was returning a raw pointer which was threaded down through to an OwnPtr in DOMTimer.
If any of the code paths in between hit an error case and returned early the raw pointer would be leaked. We
can avoid this by passing it as a PassOwnPtr. This will ensure that the ScheduledAction is cleaned up should
an error case be hit.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setTimeout): Store the newly-created ScheduledAction in an OwnPtr and then hand it off
as the function argument.
(WebCore::JSDOMWindow::setInterval): Ditto.

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::setTimeout): Ditto.
(WebCore::JSWorkerContext::setInterval): Ditto.

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create): Return a PassOwnPtr.

  • bindings/js/ScheduledAction.h:
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer): Update argument type.
(WebCore::DOMTimer::install): Ditto.

  • page/DOMTimer.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::setTimeout): Ditto.
(WebCore::DOMWindow::setInterval): Ditto.

  • page/DOMWindow.h:
14:51 Changeset [54834] by zimmermann@webkit.org

2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by David Hyatt.

SVG units don't stay consistently sized on zoom
https://bugs.webkit.org/show_bug.cgi?id=14004

Large step towards making WebKit an usable SVG viewer.

Make zooming into SVG documents work as expected, in both standalone and XHTML/SVG compound documents.
SVG applies a global scale to the document, whereas CSS zooms all individual length units (on full-page-zoom).
Scaling has to be avoided for all SVG specific CSS properties (already works) and for some selected CSS
properties shared between CSS & SVG that explicitely need a different treatment in the context of SVG.
To name a few: font-size, letter-spacing, etc. should stay invariant under zoom in SVG document fragments.

Some new rules regarding zooming:

  • "Zoom text only" should never affect SVG documents, neither text nor content should zoom. This option doesn't make much sense for SVG, so it's wise to avoid side-effects and disable it. In compound documents the SVG would stay as-is and only text of surrounding XHTML content would zoom.
  • "Full page zoom" is the only zoom mode affecting SVG. (Panning only works in standalone documents.)

Cover all mentioned cases above by a new set of layout tests.

Tests: svg/zoom/page/absolute-sized-document-no-scrollbars.svg

svg/zoom/page/absolute-sized-document-scrollbars.svg
svg/zoom/page/relative-sized-document-scrollbars.svg
svg/zoom/page/zoom-coords-viewattr-01-b.svg
svg/zoom/page/zoom-foreignObject.svg
svg/zoom/page/zoom-hixie-mixed-008.xml
svg/zoom/page/zoom-hixie-mixed-009.xml
svg/zoom/page/zoom-hixie-rendering-model-004.xhtml
svg/zoom/page/zoom-svg-float-border-padding.xml
svg/zoom/text/absolute-sized-document-no-scrollbars.svg
svg/zoom/text/absolute-sized-document-scrollbars.svg
svg/zoom/text/relative-sized-document-scrollbars.svg
svg/zoom/text/zoom-coords-viewattr-01-b.svg
svg/zoom/text/zoom-foreignObject.svg
svg/zoom/text/zoom-hixie-mixed-008.xml
svg/zoom/text/zoom-hixie-mixed-009.xml
svg/zoom/text/zoom-hixie-rendering-model-004.xhtml
svg/zoom/text/zoom-svg-float-border-padding.xml

  • css/CSSStyleSelector.cpp: Blacklist certain properties not to be zoomed for SVG elements. (WebCore::CSSStyleSelector::styleForDocument): Don't zoom font-sizes. (WebCore::CSSStyleSelector::applyProperty): Ditto (+ letter/word-spacing). (WebCore::CSSStyleSelector::setFontSize): Ditto. (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): Never apply text zoom to SVG.
  • css/CSSStyleSelector.h:
  • css/SVGCSSStyleSelector.cpp: -webkit-shadow + SVG was incorrectly respecting zoom factor. (WebCore::CSSStyleSelector::applySVGProperty):
  • page/Frame.cpp: (WebCore::Frame::shouldApplyTextZoom): Remove SVG special cases. (WebCore::Frame::shouldApplyPageZoom): Ditto. (WebCore::Frame::setZoomFactor): Don't force setZoomsTextOnly() - SVG now uses FPZ as well.
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcReplacedWidth): CSSPropertyWidth is explicitely not scaled by CSSStyleSelector, fix that for outermost <svg> elements. (WebCore::RenderSVGRoot::calcReplacedHeight): Ditto for CSSPropertyHeight. (WebCore::RenderSVGRoot::layout): Simplify & cleanup code, take advantage of new calcWidth/Height functionality, no need to scale anything here. (WebCore::RenderSVGRoot::paint): Use parentOriginToBorderBox() instead of duplicating code. (WebCore::RenderSVGRoot::calcViewport): Simplify code. (WebCore::RenderSVGRoot::localToBorderBoxTransform): Calculate viewBoxToViewTransformation() against unscaled width()/height() values.
  • rendering/RenderSVGRoot.h:
  • svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport): Cleanup & document function.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): Return pageZoomFactor(), not just the zoomFactor() - as we want to ignore text-only zoom. (WebCore::SVGSVGElement::setCurrentScale): Pass isTextOnly=false to setZoomFactor().
14:46 Changeset [54833] by zimmermann@webkit.org

2010-02-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by David Hyatt.

SVG units don't stay consistently sized on zoom
https://bugs.webkit.org/show_bug.cgi?id=14004

  • platform/mac/svg/zoom: Added.
  • platform/mac/svg/zoom/page: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/mac/svg/zoom/text: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Added.
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
  • svg/zoom: Added.
  • svg/zoom/NOTE: Added.
  • svg/zoom/page: Added.
  • svg/zoom/page/absolute-sized-document-no-scrollbars.svg: Added.
  • svg/zoom/page/absolute-sized-document-scrollbars.svg: Added.
  • svg/zoom/page/relative-sized-document-scrollbars.svg: Added.
  • svg/zoom/page/zoom-coords-viewattr-01-b.svg: Added.
  • svg/zoom/page/zoom-foreignObject.svg: Added.
  • svg/zoom/page/zoom-hixie-mixed-008.xml: Added.
  • svg/zoom/page/zoom-hixie-mixed-009.xml: Added.
  • svg/zoom/page/zoom-hixie-rendering-model-004.xhtml: Added.
  • svg/zoom/page/zoom-svg-float-border-padding.xml: Added.
  • svg/zoom/resources: Added.
  • svg/zoom/resources/testPageZoom.js: Added.
  • svg/zoom/resources/testTextZoom.js: Added.
  • svg/zoom/text: Added.
  • svg/zoom/text/absolute-sized-document-no-scrollbars.svg: Added.
  • svg/zoom/text/absolute-sized-document-scrollbars.svg: Added.
  • svg/zoom/text/relative-sized-document-scrollbars.svg: Added.
  • svg/zoom/text/zoom-coords-viewattr-01-b.svg: Added.
  • svg/zoom/text/zoom-foreignObject.svg: Added.
  • svg/zoom/text/zoom-hixie-mixed-008.xml: Added.
  • svg/zoom/text/zoom-hixie-mixed-009.xml: Added.
  • svg/zoom/text/zoom-hixie-rendering-model-004.xhtml: Added.
  • svg/zoom/text/zoom-svg-float-border-padding.xml: Added.
14:44 Changeset [54832] by eric.carlson@apple.com

2010-02-16 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=34988
WebHTMLView.mm has two -willRemoveSubview: methods

  • WebView/WebHTMLView.mm: (-[WebHTMLView willRemoveSubview:]): Consolidate the two copies of this method.
14:30 Changeset [54831] by jparent@chromium.org

Unreviewed: Chromium build fix.

https://bugs.webkit.org/show_bug.cgi?id=34998

Move include of JavaScriptProfile.h behind if (USE_JSC).

  • inspector/InspectorController.cpp:
14:21 Changeset [54830] by eric@webkit.org

2010-02-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

re-factor Skipped list parsing code into multiple functions and unit test it
https://bugs.webkit.org/show_bug.cgi?id=34986

  • Scripts/test-webkitpy: Add new unit test.
  • Scripts/webkitpy/layout_tests/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
  • Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing.
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added.
14:16 Changeset [54829] by ap@apple.com

Reviewed by Geoffrey Garen and Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=34989
<rdar://problem/7417965> Cursor disappears on scroll bars that are over plugin content

This fixes event dispatch for both Cocoa and Carbon event models (mouseEntered/mouseExited
in the former case, and adjustCursor in the latter).

  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView handleMouseEntered:]): (-[WebHostedNetscapePluginView handleMouseExited:]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView handleMouseEntered:]): (-[WebBaseNetscapePluginView handleMouseExited:]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): (-[WebNetscapePluginView handleMouseExited:]): AppKit cannot reliably dispatch events for overlapping views. We are now asking WebCore to notify plug-in views of mouse entered/exited as part of DOM event dispatch.
  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): Besides mouse moved, dispatch plugin mouse entered/exit events in HTMLPlugInElement default event handler. Other mouse events are passed down by EventHandler.
14:04 Changeset [54828] by simon.fraser@apple.com

2010-02-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Carlson.

With hardware acceleration turned off, video frames never display if poster
image is specified
https://bugs.webkit.org/show_bug.cgi?id=34965

HTMLVideoElement's m_shouldDisplayPosterImage was never updated after
the movie supplied its first video frame, so the poster would continue to show.

Fixed by calling updatePosterImage() from mediaPlayerRepaint(), which is called
each time a new frame is available. updatePosterImage() is cheap.

Also made updatePosterImage() virtual on HTMLMediaElement to avoid a number of
ugly casts.

Test: manual-tests/media-elements/video-replaces-poster.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::noneSupported): Call updatePosterImage() without video check. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::setReadyState): Ditto. (WebCore::HTMLMediaElement::mediaPlayerRepaint): Call udpatePosterImage().
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::updatePosterImage): Make this an empty virtual method on the base class.
  • html/HTMLVideoElement.h: Override updatePosterImage().
13:55 Changeset [54827] by simon.fraser@apple.com

2010-02-16 Simon Fraser <simon.fraser@apple.com>

Build fix for platforms without ACCELERATED_COMPOSITING defined.

mediaPlayerRenderingModeChanged() is only available when ACCELERATED_COMPOSITING is defined.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setUpVideoRendering):
13:46 Changeset [54826] by simon.fraser@apple.com

2010-02-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Carlson.

Autoplaying video with poster doesn't reliably show up
https://bugs.webkit.org/show_bug.cgi?id=34966

A timing issue with compositing updates when replacing the poster image
with the video could cause the video to not display.

Fix by making video layer hook up more similar to WebGL etc, by having the
video kick off a recalcStyle() via a SyntheticStyleChange. This requires
vending a PlaformLayer* from the media player, up through the element.

Test: media/video-replaces-poster.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerRenderingModeChanged): Use setNeedsStyleRecalc() to kick off a compositing update.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::platformLayer): Export the media engine's layer.
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::platformLayer): Method to vend the media layer. (WebCore::MediaPlayer::platformLayer):
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRenderingModeChanged): New client callback to indicate that the rendering mode changed. The element uses this to kick off a recalcStyle.
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::platformLayer): Method to vend the media layer.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Ditto
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieLayer): No longer parent the layer directly via setContentsToMedia(). (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged): Ditto. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Tell the client that the rendering mode changed. (WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Call setContentsToMedia() here.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: Add platformLayer().
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::platformLayer): Method to vend the media layer. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Call mediaPlayerRenderingModeChanged() (WebCore::MediaPlayerPrivate::createLayerForMovie): Don't parent the layer ourselves any more.
  • rendering/RenderVideo.h: videoGraphicsLayer() is no longer needed.
  • rendering/RenderVideo.cpp: Ditto.
13:06 Changeset [54825] by kov@webkit.org

2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Refreshed all localization-related files, so that they are
up-to-date with the code.

  • de.po: Updated.
  • en_GB.po: Updated.
  • es.po: Updated.
  • it.po: Updated.
  • lt.po: Updated.
  • nl.po: Updated.
  • pt_BR.po: Updated.
  • ru.po: Updated.
  • sr.po: Updated.
  • sr@latin.po: Updated.
  • sv.po: Updated.
  • vi.po: Updated.
  • webkit.pot: Updated.
  • zh_CN.po: Updated.
13:06 Changeset [54824] by kov@webkit.org

2010-02-16 Gil Osher <gilosher@gmail.com>

Reviewed by Gustavo Noronha.

Localization of WebKitGTK+ in Hebrew.

  • he.po: Added.
12:50 Changeset [54823] by pkasting@chromium.org

Code cleanup in ImageDecoders; no functional change.
https://bugs.webkit.org/show_bug.cgi?id=28751

Reviewed by Adam Barth.

  • Make code mostly comply with the style guide (switch indenting, use of "!" vs. "== 0", don't unnecessarily wrap lines, etc.)
  • Eliminate m_allDataReceived in ICO/BMP decoders since it's in the base ImageDecoder class
  • Remove some useless or wrong comments, add others
  • Wrap comments at 80 columns (most already were) for consistency/readability
  • Avoid casts by using correct variable types
  • Consistent naming of decode() function/args
  • Shorter code in some places
  • Make declaration and definition order match
  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::forceLoadEverything):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::setSize):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::RGBA32Buffer::):
(WebCore::ImageDecoder::ImageDecoder):

  • platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::BMPImageDecoder):
(WebCore::BMPImageDecoder::setData):
(WebCore::BMPImageDecoder::isSizeAvailable):
(WebCore::BMPImageDecoder::frameBufferAtIndex):
(WebCore::BMPImageDecoder::decode):
(WebCore::BMPImageDecoder::decodeHelper):
(WebCore::BMPImageDecoder::processFileHeader):

  • platform/image-decoders/bmp/BMPImageDecoder.h:

(WebCore::BMPImageDecoder::readUint32):

  • platform/image-decoders/bmp/BMPImageReader.cpp:

(WebCore::BMPImageReader::BMPImageReader):
(WebCore::BMPImageReader::decodeBMP):
(WebCore::BMPImageReader::readInfoHeaderSize):
(WebCore::BMPImageReader::processInfoHeader):
(WebCore::BMPImageReader::readInfoHeader):
(WebCore::BMPImageReader::isInfoHeaderValid):
(WebCore::BMPImageReader::processBitmasks):
(WebCore::BMPImageReader::processColorTable):
(WebCore::BMPImageReader::processRLEData):
(WebCore::BMPImageReader::processNonRLEData):

  • platform/image-decoders/bmp/BMPImageReader.h:

(WebCore::BMPImageReader::readUint32):
(WebCore::BMPImageReader::pastEndOfImage):
(WebCore::BMPImageReader::readCurrentPixel):
(WebCore::BMPImageReader::getComponent):
(WebCore::BMPImageReader::getAlpha):
(WebCore::BMPImageReader::setI):
(WebCore::BMPImageReader::setRGBA):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::isSizeAvailable):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::sizeNowAvailable):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/image-decoders/gif/GIFImageDecoder.h:

(WebCore::GIFImageDecoder::):
(WebCore::GIFImageDecoder::filenameExtension):

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::do_lzw):
(GIFImageReader::read):

  • platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::~GIFImageReader):

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::ICOImageDecoder):
(WebCore::ICOImageDecoder::~ICOImageDecoder):
(WebCore::ICOImageDecoder::setData):
(WebCore::ICOImageDecoder::isSizeAvailable):
(WebCore::ICOImageDecoder::frameSizeAtIndex):
(WebCore::ICOImageDecoder::frameCount):
(WebCore::ICOImageDecoder::frameBufferAtIndex):
(WebCore::ICOImageDecoder::compareEntries):
(WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex):
(WebCore::ICOImageDecoder::decode):
(WebCore::ICOImageDecoder::decodeDirectory):
(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectoryEntries):
(WebCore::ICOImageDecoder::readDirectoryEntry):

  • platform/image-decoders/ico/ICOImageDecoder.h:

(WebCore::ICOImageDecoder::readUint16):
(WebCore::ICOImageDecoder::readUint32):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::skipBytes):
(WebCore::JPEGImageReader::decode):
(WebCore::error_exit):
(WebCore::fill_input_buffer):
(WebCore::term_source):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::setSize):
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
(WebCore::JPEGImageDecoder::jpegComplete):
(WebCore::JPEGImageDecoder::decode):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:

(WebCore::JPEGImageDecoder::filenameExtension):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::decodingFailed):
(WebCore::decodingWarning):
(WebCore::headerAvailable):
(WebCore::rowAvailable):
(WebCore::pngComplete):
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageReader::createInterlaceBuffer):
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):

  • platform/image-decoders/png/PNGImageDecoder.h:

(WebCore::PNGImageDecoder::filenameExtension):

  • platform/image-decoders/qt/RGBA32BufferQt.cpp:

(WebCore::RGBA32Buffer::setDecodedImage):

06:44 Changeset [54822] by kov@webkit.org

2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Check if the handle has a SoupMessage before trying to use
it. This will be the case in non-HTTP(S) URLs.

  • webkit/webkitdownload.cpp: (webkit_download_new_with_handle): (webkit_download_start):
05:32 Changeset [54821] by ossy@webkit.org

[Qt] Unreviewed buildfix.

  • WebCore.pro: Missing backslash added.
05:17 Changeset [54820] by mnaganov@chromium.org

2010-02-16 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Move JSC-specific wrappers for Profile and ProfileNode to bindings/js.

https://bugs.webkit.org/show_bug.cgi?id=34848

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JavaScriptProfile.cpp: Added. (WebCore::profileCache): (WebCore::getTitleCallback): (WebCore::getHeadCallback): (WebCore::getUniqueIdCallback): (WebCore::focus): (WebCore::exclude): (WebCore::restoreAll): (WebCore::finalize): (WebCore::ProfileClass): (WebCore::toJS):
  • bindings/js/JavaScriptProfile.h: Added.
  • bindings/js/JavaScriptProfileNode.cpp: Added. (WebCore::profileNodeCache): (WebCore::getFunctionName): (WebCore::getURL): (WebCore::getLineNumber): (WebCore::getTotalTime): (WebCore::getSelfTime): (WebCore::getNumberOfCalls): (WebCore::getChildren): (WebCore::getVisible): (WebCore::getCallUID): (WebCore::finalize): (WebCore::ProfileNodeClass): (WebCore::toJS):
  • bindings/js/JavaScriptProfileNode.h: Added.
  • inspector/JavaScriptProfile.cpp: Removed.
  • inspector/JavaScriptProfile.h: Removed.
  • inspector/JavaScriptProfileNode.cpp: Removed.
  • inspector/JavaScriptProfileNode.h: Removed.
05:11 Changeset [54819] by apavlov@chromium.org

2010-02-16 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Elements Panel: Limit the number of initially loaded element children
https://bugs.webkit.org/show_bug.cgi?id=34421

Test: inspector/elements-panel-limited-children.html

WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._insertChild):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.createTreeElementFor): (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.get expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.set expandedChildrenLimit): (WebInspector.ElementsTreeElement.prototype.get expandedChildCount): (WebInspector.ElementsTreeElement.prototype.showChild): (WebInspector.ElementsTreeElement.prototype.insertChildElement): (WebInspector.ElementsTreeElement.prototype.moveChild): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange): (WebInspector.ElementsTreeElement.prototype.handleLoadAllChildren): ():
  • inspector/front-end/inspector.css:

LayoutTests:

  • inspector/elements-panel-limited-children-expected.txt: Added.
  • inspector/elements-panel-limited-children.html: Added.
04:54 Changeset [54818] by xan@webkit.org

2010-02-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump version to 1.1.22 so we can depend on it in applications.

  • configure.ac:

WebKit/gtk:

2010-02-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add a new WebKitWebSettings setting, 'auto-resize-window', set to
FALSE by default, that when enabled will apply any resizes or
moves done by a page through various DOM methods (moveTo,
resizeTo, moveBy, resizeBy).

  • WebCoreSupport/ChromeClientGtk.cpp:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):

WebKitTools:

2010-02-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Enable 'auto-resize-window' in our DRT.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
03:18 Changeset [54817] by benm@google.com

Refactor and split up basic-touch-events test
https://bugs.webkit.org/show_bug.cgi?id=34476

Reviewed by Simon Hausmann.

Split the basic-touch-events test into two separate tests, one for single and another for multi touch. Also refactor the tests to run in an asynchronous manner.

  • fast/events/touch/basic-multi-touch-events.html: Copied from LayoutTests/fast/events/touch/basic-touch-events.html. Tests the same multi touch tests cases from the old basic-touch-events test.
  • fast/events/touch/basic-multi-touch-events-expected.txt: Added.
  • fast/events/touch/script-tests/basic-multi-touch-events.js: Added.
  • fast/events/touch/basic-single-touch-events.html: Copied from LayoutTests/fast/events/touch/basic-touch-events.html. Tests the same single touch tests cases from the old basic-touch-events test.
  • fast/events/touch/script-tests/basic-single-touch-events.js: Added.
  • fast/events/touch/basic-single-touch-events-expected.txt: Added.
  • fast/events/touch/basic-touch-events.html: Removed.
  • fast/events/touch/script-tests/basic-touch-events.js: Removed.
  • fast/events/touch/basic-touch-events-expected.txt: Removed.
03:14 Changeset [54816] by hausmann@webkit.org

Unreviewed Symbian build fix.

Updated the def file with two new exports used by QtLauncher.

  • symbian/eabi/QtWebKitu.def:
03:10 Changeset [54815] by eric@webkit.org

2010-02-16 Ismail Donmez <ismail@namtrac.org>

Reviewed by Pavel Feldman.

Fix compilation with inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=32724

  • rendering/RenderLayerBacking.cpp: (WebCore::inspectorTimelineAgent):

2010-02-16 Ismail Donmez <ismail@namtrac.org>

Reviewed by Pavel Feldman.

Fix compilation with inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=32724

  • Api/qwebpage.cpp: (qt_drt_webinspector_executeScript): (qt_drt_webinspector_close): (qt_drt_webinspector_show): (qt_drt_setTimelineProfilingEnabled):
02:27 Changeset [54814] by hausmann@webkit.org

[Qt] Fix include paths for forwarding headers in standalone builds.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-02-16
Reviewed by Simon Hausman.

  • Api/DerivedSources.pro: Use relative paths for package builds and added some

documentation.

02:25 Changeset [54813] by pfeldman@chromium.org

2010-02-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: turn off line wrapping in source view.

https://bugs.webkit.org/show_bug.cgi?id=34935

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.markAndRevealRange): (WebInspector.TextViewer.prototype._paintLine):
  • inspector/front-end/textViewer.css:
  • inspector/front-end/utilities.js:
02:08 Changeset [54812] by pfeldman@chromium.org

2010-02-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: let search iterate over views in Resources
and keep the view in Scripts.

https://bugs.webkit.org/show_bug.cgi?id=34968

  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.jumpToNextSearchResult): (WebInspector.Panel.prototype.jumpToPreviousSearchResult): (WebInspector.Panel.prototype.showSourceLineForURL): (WebInspector.Panel.prototype.searchIteratesOverViews):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get _resources): (WebInspector.ResourcesPanel.prototype.searchIteratesOverViews):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.showingLastSearchResult):
  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown): (WebInspector.focusSearchField):
01:17 Changeset [54811] by eric@webkit.org

2010-02-16 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] canvas clipping is buggy
https://bugs.webkit.org/show_bug.cgi?id=32405

Apparently the bug was in GraphicsContext::roundToDevicePixels, we
didn't take unto accounts rotation, so the device pixels were rounded
incorrectly. The new formula is a 1:1 copy from GraphicsContextCG so
it should be rather safe

Test: http://glimr.rubyforge.org/cake/canvas.html#Polaroids now looks right

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Copy the formula from GraphicsContextCG
00:48 Changeset [54810] by yurys@chromium.org

2010-02-16 Yury Semikhatsky <yurys@chromium.org>

Not Reviewed, build fix.

  • platform/graphics/FloatRect.h: (WebCore::FloatRect::center): make conversion from float to int explicit so that compiler doesn't complain about that.

02/15/10:

23:42 Changeset [54809] by eric@webkit.org

2010-02-15 Gabor Loki <loki@webkit.org>

Reviewed by Gavin Barraclough.

Fix the SP at ctiOpThrowNotCaught on Thumb2 (JSVALUE32)
https://bugs.webkit.org/show_bug.cgi?id=34939

  • jit/JITStubs.cpp:
22:17 Changeset [54808] by mrobinson@webkit.org

2010-02-15 Martin Robinson <mrobinson@webkit.org>

Reviewed by Darin Adler.

check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin
https://bugs.webkit.org/show_bug.cgi?id=34834

  • Scripts/webkitpy/style/processors/cpp.py:
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
20:19 Changeset [54807] by mitz@apple.com

WebCore: <rdar://problem/7645609> [webView selectionRect] API is broken for multicolumn layout

Reviewed by Simon Fraser.

Refine the fix for https://bugs.webkit.org/show_bug.cgi?id=34923 by using the center of
a quad’s bounding box, rather than its top left, as the reference point passed to
offsetFromContainer(). This ensures that if a sliver off the top of the selection rect is in
one column, but most of it is on another column, the single rect we return will be for the
second column.

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::center): Added.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::localToContainerQuad): Use the center instead of the top left.

LayoutTests: Add test case for <rdar://problem/7645609> [webView selectionRect] API is broken for multicolumn layout

Reviewed by Simon Fraser.

  • fast/multicol/client-rects-expected.checksum:
  • fast/multicol/client-rects-expected.png:
  • fast/multicol/client-rects-expected.txt:
  • fast/multicol/client-rects.html:
18:36 Changeset [54806] by eric@webkit.org

2010-02-15 MORITA Hajime <morrita@gmail.com>

Reviewed by Nikolas Zimmermann.

SVG text refactor: reduce paint specific callbacks on SVGTextChunkWalker

https://bugs.webkit.org/show_bug.cgi?id=34831

No new tests, no change of functionality.

  • rendering/SVGCharacterLayoutInfo.h: (WebCore::SVGTextChunkWalker::SVGTextChunkWalker): Removed setupBackground(), setupFill(), setupFillSelection(), setupStroke(), setupStrokeSelection(), setupForeground() and associated member variables.
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::setupBackground): renamed from chunkSetupBackgroundCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupFill): renamed from chunkSetupFillCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection): renamed from chunkSetupFillSelectionCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupStroke): renamed from chunkSetupStrokeCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection): renamed from chunkSetupStrokeSelectionCallback. (WebCore::SVGRootInlineBoxPaintWalker::setupForeground): renamed from chunkSetupForegroundCallback. (WebCore::SVGRootInlineBoxPaintWalker::paintChunk): renamed from chunkPortionCallback. (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): extracted from walkTextChunks. (WebCore::SVGRootInlineBox::paint): follow SVGTextChunkWalker change. (WebCore::SVGRootInlineBox::walkTextChunks): moved paint some specific code to SVGRootInlineBoxPaintWalker::chunkPortionCallback().
17:54 Changeset [54805] by barraclough@apple.com

Reviewed by NOBODY (Build Fix!).

17:32 Changeset [54804] by barraclough@apple.com

Some general Rope related refactoring.

Reviewed by Oliver Hunt.

Rename Rope::m_ropeLength to m_fiberCount, to be more descriptive.
Rename Rope::m_stringLength to simply m_length (since this is the
more conventional name for the length of a string). Move append
behaviour out into a new RopeBuilder class, so that Rope no longer
needs any knowledge of the JSString or UString implementation.

Make Rope no longer be nested within JSString.
(Rope now no-longer need reside within JSString.h, but leaving
the change of moving this out to a different header as a separate
change from these renames).

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • runtime/JSString.cpp:

(JSC::Rope::destructNonRecursive):
(JSC::Rope::~Rope):
(JSC::JSString::resolveRope):
(JSC::JSString::toBoolean):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::Rope::Fiber::Fiber):
(JSC::Rope::Fiber::deref):
(JSC::Rope::Fiber::ref):
(JSC::Rope::Fiber::refAndGetLength):
(JSC::Rope::Fiber::isRope):
(JSC::Rope::Fiber::rope):
(JSC::Rope::Fiber::isString):
(JSC::Rope::Fiber::string):
(JSC::Rope::Fiber::nonFiber):
(JSC::Rope::tryCreateUninitialized):
(JSC::Rope::append):
(JSC::Rope::fiberCount):
(JSC::Rope::length):
(JSC::Rope::fibers):
(JSC::Rope::Rope):
(JSC::Rope::operator new):
(JSC::):
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::~JSString):
(JSC::RopeBuilder::length):
(JSC::RopeBuilder::canGetIndex):
(JSC::RopeBuilder::appendStringInConstruct):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::isRope):
(JSC::RopeBuilder::fiberCount):
(JSC::JSString::getStringPropertySlot):

  • runtime/Operations.h:

(JSC::jsString):

16:25 Changeset [54803] by jorlow@chromium.org

[Chromium] Fix StorageNamespaceProxy::copy() for test shell
https://bugs.webkit.org/show_bug.cgi?id=34949

Reviewed by Darin Fisher.

Chromium passes back NULL when you call WebStorageNamespace::proxy()
but TestShell returns a valid object. Both need to work via
the WebStorageNamespace.

  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespaceProxy::copy):

16:19 Changeset [54802] by mitz@apple.com

Try to fix the Chromium build.

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::convertToPaintingRect):

15:44 Changeset [54801] by barraclough@apple.com

Add missing cast for !YARR (PPC) builds.

Reviewed by NOBODY (Build fix).

  • runtime/RegExp.cpp:

(JSC::RegExp::match):

14:58 Changeset [54800] by bweinstein@apple.com

Add newline to end of Windows skipped list

14:57 Changeset [54799] by bweinstein@apple.com

Rubber-stamped by Dan Bernstein.

Skipped glyph-reordering on Windows since it has failed since it was landed. Left a comment
in <https://bugs.webkit.org/show_bug.cgi?id=34865> to track the failure.

  • platform/win/Skipped:
14:37 Changeset [54798] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=33731
Many false leaks in release builds due to PtrAndFlags

Reviewed by Darin Adler.

JavaScriptCore:

StructureTransitionTable was effectively a smart pointer type,
one machine word in size and wholly contained as a member of
of Structure. It either pointed to an actual table, or could
be used to describe a single transtion entry without use of a
table.

This, however, worked by using a PtrAndFlags, which is not
compatible with the leaks tool. Since there is no clear way to
obtain another bit for 'free' here, and since there are bits
available up in Structure, merge this functionality back up into
Structure. Having this in a separate class was quite clean
from an enacapsulation perspective, but this solution doesn't
seem to bad - all table access is now intermediated through the
Structure::structureTransitionTableFoo methods, keeping the
optimization fairly well contained.

This was the last use of PtrAndFlags, so removing the file too.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.h:
  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::hasTransition):

  • runtime/Structure.h:

(JSC::Structure::):
(JSC::Structure::structureTransitionTableContains):
(JSC::Structure::structureTransitionTableGet):
(JSC::Structure::structureTransitionTableHasTransition):
(JSC::Structure::structureTransitionTableRemove):
(JSC::Structure::structureTransitionTableAdd):
(JSC::Structure::structureTransitionTable):
(JSC::Structure::setStructureTransitionTable):
(JSC::Structure::singleTransition):
(JSC::Structure::setSingleTransition):

  • runtime/StructureTransitionTable.h:
  • wtf/PtrAndFlags.h: Removed.

WebCore:

PtrAndFlags has now been removed; remove forwarding header.

  • ForwardingHeaders/wtf/PtrAndFlags.h: Removed.
14:21 Changeset [54797] by ap@apple.com

Skip more plugin tests on Snow Leopard buildbot, as they need updated closed source components.

  • platform/mac-snowleopard/Skipped: Skip netscape-dom-access.html and netscape-browser-object-identity.html.
13:48 Changeset [54796] by aroben@apple.com

Add IWebFramePrivate::visibleContentRect

Fixes <http://webkit.org/b/34956> Add API to get a WebFrame's visible
content rect

Reviewed by Jon Honeycutt.

  • Interfaces/IWebFramePrivate.idl: Added visibleContentRect.
  • Interfaces/WebKit.idl: Touched to force a build.
  • WebFrame.cpp:

(WebFrame::visibleContentRect):

  • WebFrame.h:

Added. Calls through to FrameView::visibleContentRect.

13:43 Changeset [54795] by barraclough@apple.com

Rubber Stamped by Geoff Garen.

Bug 34948 - tryMakeString should fail on error in length calculation

Ooops! - "bool overflow" argument should have been "bool& overflow".

  • runtime/UString.h:

(JSC::sumWithOverflow):
(JSC::tryMakeString):

13:41 Changeset [54794] by barraclough@apple.com

Some symbol names have changed, remove, will readd if required.

Reviewed by NOBODY (Build Fix (pt 2!)).

13:37 Changeset [54793] by ossy@webkit.org

[Qt] fast/multicol/client-rects.html fails in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=34959

  • platform/qt/Skipped: fast/multicol/client-rects.html skipped until fix.
13:24 Changeset [54792] by barraclough@apple.com

Some symbol names have changed, remove, will readd if required.

Reviewed by NOBODY (Build Fix (pt 1?)).

13:18 Changeset [54791] by ap@apple.com

More build fixing (for what is actually a 64-bit failure, as 32-bit apparently includes
headers that aren't included in 64-bit).

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::contains): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): Move inline functions to .cpp; also made the class Noncopyable.
13:09 Changeset [54790] by ggaren@apple.com

Removed some mistaken code added in http://trac.webkit.org/changeset/53860.

Reviewed by Oliver Hunt.

  • API/APIShims.h:

(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim): No need to start/stop the
timeout checker when calling out from the API to the client; we want to
monitor the VM for timeouts, not the client. This mistake was harmless /
undetectable, since it's totally redundant with the APIEntryShim, which
also starts / stops the timeout checker.

13:03 Changeset [54789] by barraclough@apple.com

Bug 34952 - String lengths in UString should be unsigned.
This matches WebCore::StringImpl, and better unifies behaviour throughout JSC.

Reviewed by Geoff Garen.

JavaScriptCore:

  • JavaScriptCore.exp:
  • bytecode/EvalCodeCache.h:
  • runtime/Identifier.cpp:

(JSC::Identifier::equal):

  • runtime/Identifier.h:
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEscape):

  • runtime/JSONObject.cpp:

(JSC::gap):
(JSC::Stringifier::indent):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):

  • runtime/RegExp.cpp:

(JSC::RegExp::match):

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncSplit):
(JSC::trimString):

  • runtime/UString.cpp:

(JSC::UString::UString):
(JSC::UString::from):
(JSC::UString::getCString):
(JSC::UString::ascii):
(JSC::UString::operator[]):
(JSC::UString::toStrictUInt32):
(JSC::UString::find):
(JSC::UString::rfind):
(JSC::UString::substr):
(JSC::operator<):
(JSC::operator>):
(JSC::compare):
(JSC::equal):
(JSC::UString::UTF8String):

  • runtime/UString.h:

(JSC::UString::size):
(JSC::operator==):

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::create):
(JSC::UStringImpl::size):
(JSC::UStringImpl::computeHash):
(JSC::UStringImpl::UStringImpl):

WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::atob):
(WebCore::JSDOMWindow::btoa):

12:59 Changeset [54788] by barraclough@apple.com

Bug 34948 - tryMakeString should fail on error in length calculation

Reviewed by Geoff Garen.

The sum of the length of substrings could overflow.

  • runtime/UString.h:

(JSC::sumWithOverflow):
(JSC::tryMakeString):

12:42 Changeset [54787] by ap@apple.com

Mac release build fix attempt.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::~LocalObjectMap): Implement destructor in .cpp file, where necessary headers are already included.
12:35 Changeset [54786] by kov@webkit.org

2010-02-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Crashes when going back to a page that has data: URIs, with page cache enabled
https://bugs.webkit.org/show_bug.cgi?id=34944

Set the URL in the newly created response, when parsing data:
URIs.

Test: fast/harness/page-cache-crash-on-data-urls.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
12:32 Changeset [54785] by ggaren@apple.com

Fixed <rdar://problem/7628524> Crash beneath JSGlobalContextRelease when
typing in Google search field with GuardMalloc/full page heap enabled

Reviewed by Oliver Hunt.

  • API/JSContextRef.cpp: Don't use APIEntryShim, since that requires

a JSGlobalData, which this function destroys. Do use setCurrentIdentifierTable
and JSLock instead, since those are the two features of APIEntryShim we
require.

11:48 Changeset [54784] by mitz@apple.com

<rdar://problem/7647300> Incorrect client rects for blocks the span multiple columns and their descendants
https://bugs.webkit.org/show_bug.cgi?id=34923

Reviewed by Simon Fraser.

WebCore:

Test: fast/multicol/client-rects.html

In column layout, a different transform applies to different points in
the block and its descendants, depending on their y coordinate within the
block. offsetFromContainer() used to return the offset that applied to
the origin. With this change, it returns the offset that applies to a
given reference point. When mapping a quad from local to absolute
coordinates, the top left of the quad’s bounding box is used as that
reference point.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::layout): Pass the caret’s origin as the
reference point to offsetFromContainer().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForColumns): Adds the offset between the
given point and its image under the column paint-time transform to the
given offset. Used by offsetFromContainer() where it had previously used
adjustRectForColumns(), which takes a rect and operates less efficiently.

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer): Pass the transformed point as
the reference point to offsetFromContainer().
(WebCore::RenderBox::mapAbsoluteToLocalPoint): Pass a point to
offsetFromContainer().
(WebCore::RenderBox::offsetFromContainer): Use adjustForColumns() instead
of adjustRectForColumns(), and use the reference point to get the right
adjustment for the point of interest, instead of the origin, in case this
box spans multiple columns.

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer): Ditto. Actually apply the
column offset to the computation, which previously this function didn’t
do.
(WebCore::RenderInline::mapLocalToContainer): Pass the transformed point
as the reference point to offsetFromContainer().
(WebCore::RenderInline::mapAbsoluteToLocalPoint): Pass a point to
offsetFromContainer().

  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::mapLocalToContainer): Apply column adjustment,
based on the reference point, to the transform if needed.
(WebCore::RenderObject::localToContainerQuad): Initialize the
TransformState with the top left corner of the quad’s bounding box. It
is later used as the reference point when deciding on which column to
base the calculations.
(WebCore::RenderObject::offsetFromContainer): Adjust for columns.
(WebCore::RenderObject::offsetFromAncestorContainer): Pass the origin
as the reference point to offsetFromContainer().

  • rendering/RenderObject.h:

(WebCore::RenderObject::adjustForColumns): Added.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::offsetFromContainer): Pass the reference
point through.

  • rendering/RenderTableCell.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRectsForRange): Map (the origin of) each
rect to absolute coordinates individually.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::convertToPaintingRect): Pass a point to
offsetFromContainer().

LayoutTests:

  • fast/multicol/client-rects-expected.checksum: Added.
  • fast/multicol/client-rects-expected.png: Added.
  • fast/multicol/client-rects-expected.txt: Added.
  • fast/multicol/client-rects.html: Added.
11:16 Changeset [54783] by ap@apple.com

Reviewed by Kevin Decker.

<rdar://problem/7130641> Browser objects identity is not preserved by Safari

Test: plugins/netscape-browser-object-identity.html

  • bridge/runtime_root.h: (JSC::Bindings::RootObject::addInvalidationCallback): RootObject can now call out during invalidation, making it possible for other code to know when this happens.
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::InvalidationCallback::~InvalidationCallback): Empty destructor, in cpp file since it's virtual. (JSC::Bindings::RootObject::invalidate): Invoke invalidation callbacks.
  • bridge/NP_jsobject.cpp: (ObjectMap): Keep a JSObject->NPObject map for each RootObject. It somewhat cleaner to keep it outside RootObject, because (1) it is agnostic of what kinds of objects can wrap JSObject, and (2) out of process NPAPI implementation also keeps its corresponding map separately, due to supporting per-instance granularity (as opposed to per-RootObject here). (jsDeallocate): Remove the corresponding map entry. (_NPN_CreateScriptObject): Try to fetch existing object from the map, incrementing refcount.
10:35 Changeset [54782] by philn@webkit.org

2010-02-15 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Gustavo Noronha Silva.

Removed redefine of LOG_VERBOSE. This should not have commited in
the first place.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
10:04 Changeset [54781] by eric@webkit.org

2010-02-15 Patrick Gansterer <paroga@paroga.com>

Reviewed by Laszlo Gombos.

Added additional parameter to create_rvct_stubs
for setting the offset of thunkReturnAddress.
https://bugs.webkit.org/show_bug.cgi?id=34657

  • create_rvct_stubs:
  • jit/JITStubs.cpp:
09:48 Changeset [54780] by pfeldman@chromium.org

2010-02-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: incorrect syntax highlighting as HTML in a script tag.
We were preserving initial lexer state upon entering other tags while in <script>
but were not doing it for <script tag itself. As a result, nested script
tags were failing to highlight.

https://bugs.webkit.org/show_bug.cgi?id=34934

  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
09:46 Changeset [54779] by eric@webkit.org

2010-02-15 Emilio Pozuelo Monfort <pochu27@gmail.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Fails to build on GNU/Hurd because of PATH_MAX usage
https://bugs.webkit.org/show_bug.cgi?id=34920

Use dynamic allocation instead of fixed PATH_MAX size buffers to
fix the build on GNU/Hurd, where PATH_MAX is undefined.

  • tests/testmimehandling.c: (main):
  • tests/testwebview.c: (main):
09:31 Changeset [54778] by beidson@apple.com

Add a progress-indicator logging channel to WebCore, and convert the old WebKit Logging
messages over to WebCore-style.

Reviewed by Dan Bernstein.

No new tests. (Logging changes only)

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::progressCompleted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):

  • platform/Logging.cpp:

(WebCore::):
(WebCore::getChannelFromName):

  • platform/Logging.h:
09:10 Changeset [54777] by mnaganov@chromium.org

Revert 54776

Move JSC-specific wrappers for Profile and ProfileNode to bindings/js.
https://bugs.webkit.org/show_bug.cgi?id=34848

08:59 Changeset [54776] by mnaganov@chromium.org

2010-02-15 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Move JSC-specific wrappers for Profile and ProfileNode to bindings/js.

https://bugs.webkit.org/show_bug.cgi?id=34848

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JavaScriptProfile.cpp: Added. (WebCore::profileCache): (WebCore::getTitleCallback): (WebCore::getHeadCallback): (WebCore::getUniqueIdCallback): (WebCore::focus): (WebCore::exclude): (WebCore::restoreAll): (WebCore::finalize): (WebCore::ProfileClass): (WebCore::toJS):
  • bindings/js/JavaScriptProfile.h: Added.
  • bindings/js/JavaScriptProfileNode.cpp: Added. (WebCore::profileNodeCache): (WebCore::getFunctionName): (WebCore::getURL): (WebCore::getLineNumber): (WebCore::getTotalTime): (WebCore::getSelfTime): (WebCore::getNumberOfCalls): (WebCore::getChildren): (WebCore::getVisible): (WebCore::getCallUID): (WebCore::finalize): (WebCore::ProfileNodeClass): (WebCore::toJS):
  • bindings/js/JavaScriptProfileNode.h: Added.
  • inspector/JavaScriptProfile.cpp: Removed.
  • inspector/JavaScriptProfile.h: Removed.
  • inspector/JavaScriptProfileNode.cpp: Removed.
  • inspector/JavaScriptProfileNode.h: Removed.
07:36 Changeset [54775] by eric@webkit.org

2010-02-15 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

[Qt] QtWebkit bridge: enable passing a QWebElement to a signal/slot/property
https://bugs.webkit.org/show_bug.cgi?id=34901

When a signal/slot/property is of type QWebElement, it can seamlessly
connect with JS objects that hold a WebCore element.

New tests, see WebKit/qt/ChangeLog

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtWebElementRuntime::create): A proxy to QWebElement constructor (JSC::Bindings::QtWebElementRuntime::get): A proxy to QWebElement::element (JSC::Bindings::convertValueToQVariant): handle QWebElement (JSC::Bindings::convertQVariantToValue): handle QWebElement

2010-02-15 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

[Qt] QtWebkit bridge: enable passing a QWebElement to a signal/slot/property
Add Q_DECLARE_METATYPE to QWebElement, add relevant tests to
tst_qwebframe
https://bugs.webkit.org/show_bug.cgi?id=34901

  • Api/qwebelement.h: declare metatype
  • tests/qwebframe/tst_qwebframe.cpp: (MyQObject::webElementProperty): new test for QWebElement (MyQObject::setWebElementProperty): new test for QWebElement (MyQObject::myOverloadedSlot): new test for QWebElement
05:56 Changeset [54774] by pfeldman@chromium.org

2010-02-15 Pavel Feldman <pfeldman@chromium.org>

Not reviewed, Chromium tests fix (force conversion of property names to
strings in Web Inspector's injected script).

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
04:52 QtWebKitTableOfFeatures46 edited by henry.haverinen@nokia.com
(diff)
04:46 HackingGtk edited by joel@jms.id.au
(diff)
04:08 Changeset [54773] by eric@webkit.org

2010-02-15 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Fix QScriptValue::toIntXX methods.

More ECMA Script compliance.

[Qt] QScriptValue::toIntXX returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34847

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toInteger): (QScriptValuePrivate::toInt32): (QScriptValuePrivate::toUInt32): (QScriptValuePrivate::toUInt16):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::toInteger_initData): (tst_QScriptValue::toInteger_makeData): (tst_QScriptValue::toInteger_test): (tst_QScriptValue::toInt32_initData): (tst_QScriptValue::toInt32_makeData): (tst_QScriptValue::toInt32_test): (tst_QScriptValue::toUInt32_initData): (tst_QScriptValue::toUInt32_makeData): (tst_QScriptValue::toUInt32_test): (tst_QScriptValue::toUInt16_initData): (tst_QScriptValue::toUInt16_makeData): (tst_QScriptValue::toUInt16_test):
03:11 QtWebKitTableOfFeatures46 edited by henry.haverinen@nokia.com
(diff)
02:56 Changeset [54772] by eric@webkit.org

2010-02-15 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

[Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().

Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.

https://bugs.webkit.org/show_bug.cgi?id=33096

This allows the following tests to pass:

inspector/console-format-collections.html
inspector/styles-iframe.html
inspector/syntax-highlight-css.html
inspector/syntax-highlight-javascript.html
inspector/timeline-enum-stability.html
inspector/timeline-layout.html
inspector/timeline-mark-timeline.html
inspector/timeline-paint.html
inspector/timeline-parse-html.html
inspector/timeline-recalculate-styles.html
inspector/timeline-script-tag-1.html
inspector/timeline-script-tag-2.html
inspector/timeline-trivial.html
inspector/cookie-resource-match.html
inspector/elements-img-tooltip.html
inspector/elements-panel-selection-on-refresh.html
inspector/inspected-objects-not-overriden.html
inspector/timeline-event-dispatch.html
inspector/timeline-network-resource.html
inspector/elements-panel-rewrite-href.html
inspector/console-dir.html
inspector/console-dirxml.html
inspector/console-format.html
inspector/console-tests.html
inspector/elements-panel-structure.html
inspector/evaluate-in-frontend.html
inspector/console-clear.html

  • platform/qt/Skipped:

2010-02-15 Robert Hogan <robert@roberthogan.net>, Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Simon Hausmann.

[Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().

Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.

https://bugs.webkit.org/show_bug.cgi?id=33096

This allows the following tests to pass:

inspector/console-format-collections.html
inspector/styles-iframe.html
inspector/syntax-highlight-css.html
inspector/syntax-highlight-javascript.html
inspector/timeline-enum-stability.html
inspector/timeline-layout.html
inspector/timeline-mark-timeline.html
inspector/timeline-paint.html
inspector/timeline-parse-html.html
inspector/timeline-recalculate-styles.html
inspector/timeline-script-tag-1.html
inspector/timeline-script-tag-2.html
inspector/timeline-trivial.html
inspector/cookie-resource-match.html
inspector/elements-img-tooltip.html
inspector/elements-panel-selection-on-refresh.html
inspector/inspected-objects-not-overriden.html
inspector/timeline-event-dispatch.html
inspector/timeline-network-resource.html
inspector/elements-panel-rewrite-href.html
inspector/console-dir.html
inspector/console-dirxml.html
inspector/console-format.html
inspector/console-tests.html
inspector/elements-panel-structure.html
inspector/evaluate-in-frontend.html
inspector/console-clear.html

  • Api/qwebpage.cpp: (qt_drt_webinspector_executeScript): (qt_drt_webinspector_close): (qt_drt_webinspector_show): (qt_drt_setTimelineProfilingEnabled):
  • WebCoreSupport/InspectorClientQt.cpp: (InspectorClientQt::createPage)

2010-02-15 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

[Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().

Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.

https://bugs.webkit.org/show_bug.cgi?id=33096

This allows the following tests to pass:

inspector/console-format-collections.html
inspector/styles-iframe.html
inspector/syntax-highlight-css.html
inspector/syntax-highlight-javascript.html
inspector/timeline-enum-stability.html
inspector/timeline-layout.html
inspector/timeline-mark-timeline.html
inspector/timeline-paint.html
inspector/timeline-parse-html.html
inspector/timeline-recalculate-styles.html
inspector/timeline-script-tag-1.html
inspector/timeline-script-tag-2.html
inspector/timeline-trivial.html
inspector/cookie-resource-match.html
inspector/elements-img-tooltip.html
inspector/elements-panel-selection-on-refresh.html
inspector/inspected-objects-not-overriden.html
inspector/timeline-event-dispatch.html
inspector/timeline-network-resource.html
inspector/elements-panel-rewrite-href.html
inspector/console-dir.html
inspector/console-dirxml.html
inspector/console-format.html
inspector/console-tests.html
inspector/elements-panel-structure.html
inspector/evaluate-in-frontend.html
inspector/console-clear.html

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::isWebInspectorTest): (WebCore::DumpRenderTree::open):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::display):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::closeWebInspector): (LayoutTestController::showWebInspector): (LayoutTestController::evaluateInWebInspector): (LayoutTestController::setTimelineProfilingEnabled): (LayoutTestController::display):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
02:51 Changeset [54771] by pfeldman@chromium.org

2010-02-15 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: touch InspectorController in order to kick win bot tests
with new injected script contents.

  • inspector/InspectorController.cpp:
02:44 QtWebKitTableOfFeatures46 edited by henry.haverinen@nokia.com
(diff)
02:34 Changeset [54770] by pfeldman@chromium.org

2010-02-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: highlight actual search match in elements panel.

https://bugs.webkit.org/show_bug.cgi?id=34251

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult): (WebInspector.ElementsPanel.prototype.jumpToNextSearchResult): (WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult): (WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult): (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
  • inspector/front-end/InjectedScript.js:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.findSearchMatches):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
  • inspector/front-end/textViewer.css:
  • inspector/front-end/utilities.js:
02:22 QtWebKitTableOfFeatures46 edited by henry.haverinen@nokia.com
(diff)
02:20 Changeset [54769] by pfeldman@chromium.org

2010-02-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: XPathResult objects are not expanded in console.

https://bugs.webkit.org/show_bug.cgi?id=34926

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection.prototype.updateProperties): (WebInspector.ObjectPropertiesSection.CompareProperties): (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/Section.js: (WebInspector.Section):
  • inspector/front-end/inspector.css:

Tests:

  • inspector/console-dir-expected.txt:
  • inspector/console-dir.html:
02:20 QtWebKitTableOfFeatures46 edited by henry.haverinen@nokia.com
(diff)
02:14 QtWebKitTableOfFeatures46 edited by henry.haverinen@nokia.com
(diff)
02:07 QtWebKitTableOfFeatures46 edited by henry.haverinen@nokia.com
(diff)
01:51 Changeset [54768] by philn@webkit.org

2010-02-15 Philippe Normand <pnormand@igalia.com>

media/video-display-aspect-ratio.html fails
https://bugs.webkit.org/show_bug.cgi?id=34933

Skipped the new test that fails.

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/win/Skipped:
01:28 Changeset [54767] by antti@apple.com

2010-02-12 Antti Koivisto <koivisto@iki.fi>

Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.


https://bugs.webkit.org/show_bug.cgi?id=34885
Add a QGraphicsWebView mode that makes it automatically resize itself to the size of the content.

This is useful for cases where the client wants to implement page panning and zooming by manipulating
the graphics item.


Add a option to QGVLauncher to test this mode.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::updateResizesToContentsForPage): (QGraphicsWebViewPrivate::_q_contentsSizeChanged): (QGraphicsWebView::setPage): (QGraphicsWebView::setResizesToContents): (QGraphicsWebView::resizesToContents):
  • Api/qgraphicswebview.h:
  • QGVLauncher/main.cpp: (WebView::WebView): (MainView::MainView): (MainView::setMainWidget): (MainView::resizeEvent): (main):
00:48 Changeset [54766] by philn@webkit.org

2010-02-10 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] wrong video aspect ratio
https://bugs.webkit.org/show_bug.cgi?id=34790

Fixed natural size calculation regarding pixel aspect ratio and
display aspect ratio.

Test: media/video-display-aspect-ratio.html

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::greatestCommonDivisor): (WebCore::MediaPlayerPrivate::naturalSize):

2010-02-12 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] wrong video aspect ratio
https://bugs.webkit.org/show_bug.cgi?id=34790

Test checking the size of a 4:3 video with a 16:9 pixel aspect
ratio.

  • media/content/test-par-16-9.mp4: Added.
  • media/video-display-aspect-ratio-expected.txt: Added.
  • media/video-display-aspect-ratio.html: Added.

02/14/10:

22:31 Changeset [54765] by eric@webkit.org

2010-02-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Adam Barth.

Implement NEVER_INLINE and NO_RETURN for RVCT
https://bugs.webkit.org/show_bug.cgi?id=34740

  • wtf/AlwaysInline.h:
22:05 Changeset [54764] by eric@webkit.org

2010-02-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

HTML5 iframe sandbox bypass of window.top.location navigation via <form target="_top">
https://bugs.webkit.org/show_bug.cgi?id=33277

Add a test that _top is covered by @sandbox.

  • http/tests/security/resources/fail.html: Added.
  • http/tests/security/resources/sandboxed-iframe-form-top.html: Added.
  • http/tests/security/sandboxed-iframe-form-top-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-form-top.html: Added.

2010-02-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

HTML5 iframe sandbox bypass of window.top.location navigation via <form target="_top">
https://bugs.webkit.org/show_bug.cgi?id=33277

submitForm wasn't respecting shouldAllowNavigation. Instead of calling
the wrapper function, we need to call shouldAllowNavigation because we
need to handle the "frame not found" case differently than the
"navigation denied" case.

Test: http/tests/security/sandboxed-iframe-form-top.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
21:47 Changeset [54763] by eric@webkit.org

2010-02-14 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add support for the showDebugBorders setting to Chromium.

https://bugs.webkit.org/show_bug.cgi?id=34906

  • public/WebSettings.h: Add declaration for setShowDebugBorders
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setShowDebugBorders): Add method implementation
  • src/WebSettingsImpl.h: Added declaration for setShowDebugBorders
21:31 Changeset [54762] by eric@webkit.org

2010-02-14 Diego Escalante Urrelo <descalante@igalia.com>

Reviewed by Gustavo Noronha Silva.

[gtk] WebKitDownload's currentSize property is guint, should be guint64
https://bugs.webkit.org/show_bug.cgi?id=34829

Actually use a guint64 for current-size property in WebKitDownload, we
were using a guint which is likely the cause for wrong sizes for files
over 4 Gb.

  • webkit/webkitdownload.cpp:
21:14 Changeset [54761] by eric@webkit.org

2010-02-14 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Adam Barth.

[Qt] The original test case failed on Qt because its real output
"A B C DE F" did not match the expected "A B C D E F". The input
field between D and E failed to generate the space in the dumped
text as it normally would if it was broken into a new line.
This DRT issue can be addressed in a seperate bug if necessary
but shrinking the size of font so as to fit all fields into one
line is an immediate fix to pass the test case.
https://bugs.webkit.org/show_bug.cgi?id=33093

  • fast/html/text-field-input-types.html:
  • platform/qt/Skipped:
20:58 Changeset [54760] by eric@webkit.org

2010-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Update rebaseline-chromium-webkit-tests to work with the new code
structure (port objects instead of path_utils and platform_utils).

Added a path_to_test_expectations_file() to the Port interface.

Fixed a bug in the chromium_* platform implementations where the
'target' option was assumed to be set.

  • Scripts/rebaseline-chromium-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
20:42 Changeset [54759] by eric@webkit.org

2010-02-14 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

webkit-build-directory misuses terms
https://bugs.webkit.org/show_bug.cgi?id=34822

  • Scripts/webkit-build-directory:
    • Add --top-level and --configuration options and make using one of them required.
  • Scripts/webkitpy/layout_tests/port/mac.py:
    • Use --top-level instead of --base.
20:08 Changeset [54758] by tkent@chromium.org

2010-02-14 Kent Tamura <tkent@chromium.org>

No review. Touch RenderRuny*.cpp to fix Chromium/Windows build bot.

  • rendering/RenderRuby.cpp: Add a comment for #endf.
  • rendering/RenderRubyBase.cpp: Add a comment for #endf.
  • rendering/RenderRubyRun.cpp: Add a comment for #endf.
  • rendering/RenderRubyText.cpp: Add a comment for #endf.
08:22 Changeset [54757] by laszlo.1.gombos@nokia.com

2010-02-14 Chang Shu <Chang.Shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable appcache feature.
https://bugs.webkit.org/show_bug.cgi?id=34713

Re-land r54543 without the change in DumpRenderTree/qt/main.cpp.
Persistent storage for AppCache is already initialized in
DumpRenderTreeQt.cpp.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage):

2010-02-14 Chang Shu <Chang.Shu@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable http/tests/appcache but skip the failed cases.
https://bugs.webkit.org/show_bug.cgi?id=34713

  • platform/qt/Skipped:
01:17 Changeset [54756] by pfeldman@chromium.org

2010-02-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: cache created row, span and text elements
in TextView to improve scroller performance on debug build.

https://bugs.webkit.org/show_bug.cgi?id=34921

02/13/10:

22:22 UsingGitWithWebKit edited by cjerdonek@webkit.org
Added tip on how to determine the path to git. (diff)
21:13 WikiStart edited by cjerdonek@webkit.org
Made "Debugging WebKit with XCode" link directly to webkit.org. (diff)
13:44 ImprovingLifeOnWindows edited by jberlin@webkit.org
Setting WebKitOutputDir and WebKitLibrariesDir landed in r51932 (diff)
13:41 BuildingOnWindows edited by jberlin@webkit.org
Adding information about not being able to find SafariTheme.dll because … (diff)
13:06 Changeset [54755] by bweinstein@apple.com

Build fix for Windows, initialize success to false.

11:52 Changeset [54754] by tkent@chromium.org

2010-02-13 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Refactor parsing/serialization functions in HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=34852

  • Rename formStringToDouble() to parseToDoubleForNumberType()
  • Rename formStringToDateComponents() to parseToDateComponents()
  • Rename formStringFromDouble() to serializeForNumberType()
  • Add serializeForDateTimeTypes() The code is moved from setValueAsDate() and setDateValue().
  • Add serialize()

parseToDouble() is the top-level function to parse a
type-dependent string and return a double
value. parseToDoubleForNumber() and parseToDateComponents()
functions are helper functions for it. serialize() is the
top-level function to serialize a double value to a type-dependent
string, and serializeForNumberType() and
serializeForDateTimeTypes() are helper functions for it.

No tests because of no functional changes.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::getAllowedValueStep): (WebCore::HTMLInputElement::parseToDouble): (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::setValueAsDate): (WebCore::HTMLInputElement::setValueAsNumber): (WebCore::HTMLInputElement::serializeForDateTimeTypes): (WebCore::HTMLInputElement::serialize): (WebCore::HTMLInputElement::serializeForNumberType): (WebCore::HTMLInputElement::parseToDoubleForNumberType): (WebCore::HTMLInputElement::parseToDateComponents):
  • html/HTMLInputElement.h:
  • html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch):
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::valueFromElement): (WebCore::RenderSlider::updateFromElement): (WebCore::RenderSlider::setValueForPosition):
07:39 Changeset [54753] by ossy@webkit.org

[Qt] Skip new test that fails. See https://webkit.org/b/34918.

  • platform/qt/Skipped: fast/text/glyph-reordering.html skipped.
06:04 Changeset [54752] by kov@webkit.org

2010-02-13 Gustavo Noronha Silva <gns@gnome.org>

Skip new test that fails. See https://webkit.org/b/34918.

  • platform/gtk/Skipped:

02/12/10:

23:53 Changeset [54751] by chang.shu@nokia.com
21:14 Changeset [54750] by ojan@chromium.org

2010-02-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Dan Bernstein.

text-control-intrinsic-widths.html failing on tiger bot
https://bugs.webkit.org/show_bug.cgi?id=34917

Final cleanup for http://trac.webkit.org/changeset/54748.
Some MS fonts don't come with a default install of Tiger, but do
come with a default Leopard/SnowLeopard install. As a result we naturally
get different metrics a page uses these fonts.

  • platform/mac-tiger/fast/forms/text-control-intrinsic-widths-expected.txt: Added.
20:43 Changeset [54749] by ojan@chromium.org

2010-02-12 Ojan Vafai <ojan@chromium.org>

Reviewed by Maciej Stachowiak.

Four textcontrol tests fail after http://trac.webkit.org/changeset/54748
https://bugs.webkit.org/show_bug.cgi?id=34916

-Put the baseline for text-control-intrinsic-widths in the right place!
-I missed perspective-non-layer.html because we don't run it on Leopard.
-Accidentally deleted drag-text-delay-expected.txt and text-control-intrinsic-widths-expected.txt
instead of updating their results.

  • platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Removed.
  • platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
  • platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
  • platform/win/editing/selection/drag-text-delay-expected.txt: Added.
  • platform/win/fast/forms/text-control-intrinsic-widths-expected.txt: Added.
19:20 Changeset [54748] by ojan@chromium.org

2010-01-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Improve text control instrinsic widths.
https://bugs.webkit.org/show_bug.cgi?id=25566
https://bugs.webkit.org/show_bug.cgi?id=25581
https://bugs.webkit.org/show_bug.cgi?id=25958

Excluding list of updated results as the list is so long.

2010-01-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Dan Bernstein.

Improve text control intrinsic widths.
https://bugs.webkit.org/show_bug.cgi?id=25566
https://bugs.webkit.org/show_bug.cgi?id=25581
https://bugs.webkit.org/show_bug.cgi?id=25958

For Mac fonts that have invalid avgCharWidth entries in the OS/2 table,
fallback to the Safari 4- behavior of using the width of a zero. For other
fonts, make Mac match Windows (and thus IE) metrics.

Lucida Grande is hard-coded to match MS Shell Dlg for inputs and
Courier New for textareas in order to match Safari Win, Firefox and, in
some cases IE (IE uses different default fonts depending on encoding).

The only case where we still don't match Windows is if no font-size is
set. The default font-size for form controls on the Mac is smaller and
thus text-control widths will be slightly smaller.

No new tests. Covered by existing tests.

  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformCharWidthInit):
  • rendering/RenderTextControl.cpp: (WebCore::): (WebCore::RenderTextControl::hasValidAvgCharWidth): (WebCore::RenderTextControl::getAvgCharWidth): (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::scaleEmToUnits):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::getAvgCharWidth):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::getAvgCharWidth): (WebCore::RenderTextControlSingleLine::preferredContentWidth):
  • rendering/RenderTextControlSingleLine.h:
19:09 Changeset [54747] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from JIT data stuctures.

Reviewed by Oliver Hunt.

These break the OS X Leaks tool. Free up a bit in CallLinkInfo, and invalid
permutation of pointer states in MethodCallLinkInfo to represent the removed bits.

  • bytecode/CodeBlock.h:

(JSC::CallLinkInfo::seenOnce):
(JSC::CallLinkInfo::setSeen):
(JSC::MethodCallLinkInfo::MethodCallLinkInfo):
(JSC::MethodCallLinkInfo::seenOnce):
(JSC::MethodCallLinkInfo::setSeen):

  • jit/JIT.cpp:

(JSC::JIT::unlinkCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::patchMethodCallProto):

  • runtime/UString.h:
19:01 Changeset [54746] by ariya@webkit.org

2010-02-11 Ariya Hidayat <ariya.hidayat@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unnecessary QBrush construction for doing a solid color stroke
https://bugs.webkit.org/show_bug.cgi?id=34874

Use the similar trick like in r54347, i.e. use the special brush for
solid color to avoid expensive QBrush constructor.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformStrokeColor):
17:46 Changeset [54745] by darin@apple.com

Ignore compiled Python in more of webkitpy.

  • Scripts/webkitpy/style/processors: Added property svn:ignore.
17:18 Changeset [54744] by mjs@apple.com

.: Merged from trunk:

2010-02-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.

Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698

  • configure.ac:

JavaScriptCore: Merged from trunk:

2010-02-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.

Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698

  • Configurations/FeatureDefines.xcconfig:

WebCore: Merged from trunk:

2010-02-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.

Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • html/HTMLTagNames.in: Make the ruby-related tag names conditional.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject): ifdef the code that would create ruby elements.

  • rendering/RenderObject.h: ditto above
  • rendering/RenderRuby.cpp: ifdef this whole file
  • rendering/RenderRuby.h: ditto
  • rendering/RenderRubyBase.cpp: ditto
  • rendering/RenderRubyBase.h: ditto
  • rendering/RenderRubyRun.cpp: ditto
  • rendering/RenderRubyRun.h: ditto
  • rendering/RenderRubyText.cpp: ditto
  • rendering/RenderRubyText.h: ditto

WebKit/mac: Merged from trunk:

2010-02-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.

Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries: Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698

Reviewed by Cameron Zwarich.

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools: Merged from trunk:

2010-02-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.

Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
https://bugs.webkit.org/show_bug.cgi?id=34698

  • Scripts/build-webkit:
15:57 Changeset [54743] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=33731
Many false leaks in release builds due to PtrAndFlags

Reviewed by Darin Adler.

Remove UntypedPtrAndBitfield (similar to PtrAndFlags) in UStringImpl,
and steal bits from the refCount instead.

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::~UStringImpl):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::cost):
(JSC::UStringImpl::isIdentifier):
(JSC::UStringImpl::setIsIdentifier):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):
(JSC::UStringImpl::):

15:29 Changeset [54742] by darin@chromium.org

2010-02-11 Darin Fisher <darin@chromium.org>

Reviewed by Jeremy Orlow.

Introduce WebCookieJar, and provide for a frame specific cookie jar.

https://bugs.webkit.org/show_bug.cgi?id=34878

  • WebKit.gyp:
  • public/WebCookieJar.h: Added.
  • public/WebFrameClient.h: (WebKit::WebFrameClient::cookieJar):
  • public/WebKitClient.h: (WebKit::WebKitClient::cookieJar): (WebKit::WebKitClient::setCookies): (WebKit::WebKitClient::cookies): (WebKit::WebKitClient::rawCookies): (WebKit::WebKitClient::deleteCookie): (WebKit::WebKitClient::cookiesEnabled):
  • src/ChromiumBridge.cpp: (WebCore::getCookieJar): (WebCore::ChromiumBridge::setCookies): (WebCore::ChromiumBridge::cookies): (WebCore::ChromiumBridge::rawCookies): (WebCore::ChromiumBridge::deleteCookie): (WebCore::ChromiumBridge::cookiesEnabled):
15:21 Changeset [54741] by eric@webkit.org

2010-02-12 Eric Seidel <eric@webkit.org>

No review, rolling out r54694.
http://trac.webkit.org/changeset/54694
https://bugs.webkit.org/show_bug.cgi?id=34633

This appears to have caused crashes on the Leopard bot. See
bug 34898.

  • websocket/tests/bufferedAmount-after-close-expected.txt: Removed.
  • websocket/tests/bufferedAmount-after-close.html: Removed.
  • websocket/tests/script-tests/bufferedAmount-after-close.js: Removed.

2010-02-12 Eric Seidel <eric@webkit.org>

No review, rolling out r54694.
http://trac.webkit.org/changeset/54694
https://bugs.webkit.org/show_bug.cgi?id=34633

This appears to have caused crashes on the Leopard bot. See
bug 34898.

  • websockets/ThreadableWebSocketChannelClientWrapper.h: (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
  • websockets/WebSocket.cpp: (WebCore::WebSocket::WebSocket): (WebCore::WebSocket::send): (WebCore::WebSocket::close): (WebCore::WebSocket::bufferedAmount): (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::didClose):
  • websockets/WebSocketChannel.h:
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didClose):
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::workerContextDidClose): (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
  • websockets/WorkerThreadableWebSocketChannel.h:
14:42 Changeset [54740] by barraclough@apple.com

Workers' EventListeners should be removed before JSGlobalData is destroyed
https://bugs.webkit.org/show_bug.cgi?id=34903

Reviewed by Sam Weinig.

(Patch co-developed with Alexey Proskuryakov).

Since http://trac.webkit.org/changeset/54460 the EventListeners registered by a
worker thread are not removed until after the thread's JSGlobalData has been
destroyed. This is slightly worrisome since the JSEventListener contains
JSObject*s, which will be dangling once the heap is destroyed. The
JSEventListeners may also reference the worker thread's normal world, which
again it makes no sense to keep around after the JSGlobalData is freed.

Remove all event listeners immediately prior to tearing down the JSGlobalData.

https://bugs.webkit.org/show_bug.cgi?id=34728 addressed the symptoms of this
problem, and it is probably cleaner to make the client data's normal world no
longer be a member (since it is a ref-counted object), however they should be
no requirement to 'detatch' – it makes no sense for anyone to be referencing
the world after the JSGlobalData has gone away (the world's purpose is to hold
wrapper objects in the JSGlobalData's heap). Keep the restructuring that makes
the normal world no longer be a member, but remove the detach mechanism this
patch added & replace with stronger ASSERTs.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld):

  • bindings/js/JSDOMBinding.h:

(WebCore::WebCoreJSClientData::~WebCoreJSClientData):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownStartTask::performTask):

14:27 Changeset [54739] by mrowe@apple.com

Versioning.

14:27 Changeset [54738] by eric@webkit.org

2010-02-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by David Levin.

Chromium: provide theme overrides for Chromium devtools on Mac.

https://bugs.webkit.org/show_bug.cgi?id=34856

  • src/js/devTools.css:
14:26 Changeset [54737] by mrowe@apple.com

New tag.

14:22 Changeset [54736] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=33731
Remove uses of PtrAndFlags from WebCore::StringImpl.

Reviewed by Sam Weinig.

These break the OS X Leaks tool. Use a bits stolen from the refCount to hold the
'InTable' and 'HasTerminatingNullCharacter' flags, along with the string type
(fixes a leak where the string data is allocated at the address (this + 1), and is
misinterpreted as being an internal buffer).

  • WebCore.base.exp:
  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::~StringImpl):
(WebCore::StringImpl::create):
(WebCore::StringImpl::createWithTerminatingNullCharacter):
(WebCore::StringImpl::crossThreadString):
(WebCore::StringImpl::sharedBuffer):

  • platform/text/StringImpl.h:

(WebCore::StringImpl::):
(WebCore::StringImpl::hasTerminatingNullCharacter):
(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
(WebCore::StringImpl::ref):
(WebCore::StringImpl::deref):
(WebCore::StringImpl::hasOneRef):
(WebCore::StringImpl::operator new):
(WebCore::StringImpl::bufferOwnership):

  • storage/OriginUsageRecord.cpp:

(WebCore::OriginUsageRecord::addDatabase):
(WebCore::OriginUsageRecord::markDatabase):

14:18 Changeset [54735] by zimmermann@webkit.org

2010-02-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Repaint bug on Text selection in foreignObject
https://bugs.webkit.org/show_bug.cgi?id=16939

Tests: svg/overflow/overflow-on-foreignObject.svg

svg/text/foreignObject-text-clipping-bug.xml

Selecting text contained in <foreignObject> leads to artefacts. Same for zooming/panning.
RenderForeignObject contained old legacy code returning FloatRect() for repaintRectInLocalCoordinates,
which is obviously wrong. Fixing that leads to even more problems, as the underlying RenderBlock
did not reflect the x/y translation set on the <foreignObject>. This is problematic, as laying out
positioned objects in the XHTML subtree depends on proper size/location values of the frameRect.

Correctly clip on overflow="hidden". overflow="scroll" & friends are not yet supported, see lengthy
comment in RenderSVGBlock why we either need RenderLayer for RenderForeignObject or need to rework
overflow handling to avoid RenderLayer.

SVGForeignObjectElement uses a hacky custom solution to synchronize CSS width/height properties with
the SVG width/height attributes. Remove all of that code and just implement calcWidth/calcHeight in
RenderForeignObject, grabbing the right values from SVGForeignObjectElement::width/height upon layout.

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint): Clip properly to the actual bounds of the foreignObject, respecting that x/y translation is handled by RenderBlock now. (WebCore::RenderForeignObject::clippedOverflowRectForRepaint): Added missing function, forward to SVGRenderBase just like all other SVG renderers. (WebCore::RenderForeignObject::computeRectForRepaint): Remove manual implementation, forward to SVGRenderBase. (WebCore::RenderForeignObject::localToParentTransform): Respect x/y translation here _after_ applying localTransform(). (WebCore::RenderForeignObject::calcWidth): Override RenderBlock::calcWidth to grab width() from SVGForeignObjectElement. (WebCore::RenderForeignObject::calcHeight): Override RenderBlock::calcHeight to grab height() from SVGForeignObjectElement. (WebCore::RenderForeignObject::layout): Calculate viewport once and cache it. Push x/y location down to RenderBlock - analogous to RenderSVGText. (WebCore::RenderForeignObject::nodeAtFloatPoint): Adapt to x/y translation changes (map through localTransform, not localToParentTransform). Respect overflow clipping. (WebCore::RenderForeignObject::mapLocalToContainer): Set useTransforms=true, to avoid assertions when selecting text in foreign objects.
  • rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::objectBoundingBox): Return cached m_viewport. (WebCore::RenderForeignObject::strokeBoundingBox): Ditto. (WebCore::RenderForeignObject::repaintRectInLocalCoordinates): Ditto.
  • rendering/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::setStyle): Cleanup code, move setHasOverflowClip() overrides in updateBoxModelInfoFromStyle where it belongs. (WebCore::RenderSVGBlock::updateBoxModelInfoFromStyle): Added to force setting setHasOverflowClip(false).
  • rendering/RenderSVGBlock.h:
  • svg/SVGForeignObjectElement.cpp: Kill a lot of custom code - it was just plain wrong to utilize CSS to push width/height information down to RenderBlock. (WebCore::SVGForeignObjectElement::svgAttributeChanged):
13:30 Changeset [54734] by bweinstein@apple.com

onmouseout fired when moving over tooltip on Windows
https://bugs.webkit.org/show_bug.cgi?id=16794
<rdar://5762038>.

Reviewed by Adam Roben.

Add WS_EX_TRANSPARENT to out tooltip HWND so it isn't subject to hit testing, and when
you mouse over the tooltip, it doesn't send a mouseout to the web content.

  • WebView.cpp:

(WebView::initializeToolTipWindow): Add WS_EX_TRANSPARENT.

13:02 Changeset [54733] by darin@apple.com

Removed unneeded custom implementation of isDescendantOf.

Reviewed by Sam Weinig.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView shouldClipOutPlugin]): Use the
-[NSView isDescendantOf:] method instead of our own method
named superviewsHaveSuperviews.

13:00 Changeset [54732] by ggaren@apple.com

Removed an unnecessary data dependency from my last patch.

Reviewed by Darin Adler.

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::markChildren): Since isAnyStringMarked being false
is a condition of entering the loop, we can just use '=' instead of '|='.

12:29 Changeset [54731] by jorlow@chromium.org

2010-02-12 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add a blockedByPolicy output to WebStorageArea::setItem.
https://bugs.webkit.org/show_bug.cgi?id=34897

  • public/WebStorageArea.h: (WebKit::WebStorageArea::setItem):
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem):
11:43 Changeset [54730] by mitz@apple.com

<rdar://problem/7615234> REGRESSION (r48586): Loading an HTML page causes
PDFKit to be loaded

Reviewed by Darin Adler.

  • WebView/WebPDFDocumentExtras.h: Removed the category declaration and

addWebPDFDocumentExtras(). Declare allScriptsInPDFDocument().

  • WebView/WebPDFDocumentExtras.mm:

(allScriptsInPDFDocument): Changed the -_web_allScripts method into this function.

  • WebView/WebPDFRepresentation.mm: Removed +initialize.

(-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use
allScriptsInPDFDocument() instead of -_web_allScripts.

11:20 Changeset [54729] by mitz@apple.com

<rdar://problem/7609268> REGRESSION (r50301): Problem selecting text in a Devanagari website
https://bugs.webkit.org/show_bug.cgi?id=34865

Reviewed by Simon Fraser.

WebCore:

Test: fast/text/glyph-reordering.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic): Added. Sets m_isMonotonic
and populates m_glyphEndOffsets with the end offsets of each glyph’s corresponding character range.
(WebCore::ComplexTextController::advance): For non-monotonic runs, use endOffsetAt() to get
glyphs’ end offsets.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Check for monotonicity and call
setIsNonMonotonic() if needed.

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::ComplexTextRun::lastIndexAt): Added this getter.
(WebCore::ComplexTextController::ComplexTextRun::isMonotonic): Ditto.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_isMonotonic.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.

LayoutTests:

  • fast/text/glyph-reordering-expected.txt: Added.
  • fast/text/glyph-reordering.html: Added.
10:45 Changeset [54728] by ukai@chromium.org

Unreviewed trivial fix.
Set Content-Type header, required for chromium test_shell.

09:05 Changeset [54727] by ap@apple.com

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=34866
Leopard Debug Bot crashed on fast/forms/old-names.html

  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): Removed a misplaced checkConsistency() call. We are not looking at cache content at this point, and caches will be reset on next access.
08:05 Changeset [54726] by jorlow@chromium.org

2010-02-11 Jeremy Orlow <jorlow@chromium.org>

Reviewed by David Levin.

[Chromium] Add ENABLE_RUBY to the feature defines gypi
https://bugs.webkit.org/show_bug.cgi?id=34841

  • features.gypi:
07:38 Changeset [54725] by eric@webkit.org

2010-02-12 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Chromium: Web Inspector on an element in a page where JS is blocked crashes the renderer

https://bugs.webkit.org/show_bug.cgi?id=34890

  • src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::createUtilityContext):
06:29 Changeset [54724] by vestbo@webkit.org

Additional refptr/passrefptr workarounds for WINSCW compiler

https://bugs.webkit.org/show_bug.cgi?id=28054

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12

Reviewed by Tor Arne Vestbø.

  • wtf/PassRefPtr.h:

(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):

  • wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::::operator):

06:22 Changeset [54723] by eric@webkit.org

2010-02-12 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Qt DRT now dump the frame loader callbacks when LayoutTestController()
method is called.

LayoutTests:

http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/security/mixedContent/insecure-plugin-in-iframe.html
http/tests/security/mixedContent/insecure-script-in-iframe.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html

[Qt] Make possible Qt DRT dump frame load callbacks
https://bugs.webkit.org/show_bug.cgi?id=34702

  • platform/qt/Skipped:

2010-02-12 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Qt DRT now dump the frame loader callbacks when LayoutTestController()
method is called.

LayoutTests:

http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/security/mixedContent/insecure-plugin-in-iframe.html
http/tests/security/mixedContent/insecure-script-in-iframe.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html

[Qt] Make possible Qt DRT dump frame load callbacks
https://bugs.webkit.org/show_bug.cgi?id=34702

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didDisplayInsecureContent): (WebCore::FrameLoaderClientQt::didRunInsecureContent):

2010-02-12 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Qt DRT now dump the frame loader callbacks when LayoutTestController()
method is called.

LayoutTests:

http/tests/security/mixedContent/data-url-script-in-iframe.html
http/tests/security/mixedContent/empty-url-plugin-in-frame.html
http/tests/security/mixedContent/insecure-css-in-iframe.html
http/tests/security/mixedContent/insecure-iframe-in-iframe.html
http/tests/security/mixedContent/insecure-image-in-iframe.html
http/tests/security/mixedContent/insecure-plugin-in-iframe.html
http/tests/security/mixedContent/insecure-script-in-iframe.html
http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html

[Qt] Make possible Qt DRT dump frame load callbacks
https://bugs.webkit.org/show_bug.cgi?id=34702

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpFrameLoadCallbacks):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
05:48 Changeset [54722] by hausmann@webkit.org

Don't import the cmath functions from std:: for WINSCW.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12
Reviewed by Simon Hausmann.

  • wtf/MathExtras.h:
05:33 Changeset [54721] by hausmann@webkit.org

Make QtLauncher somewhat useable on S60.

Reviewed by Antti Koivisto.

Show the window fullscreen to make scrollbars appear, resize
the toolbar buttons to 16x16 to give more screen space to
web content and moved the location lineedit into a separate
line.

  • QtLauncher/main.cpp:

(LauncherWindow::LauncherWindow):

  • QtLauncher/mainwindow.cpp:

(MainWindow::buildUI):

05:16 Changeset [54720] by pfeldman@chromium.org

2010-02-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: restore highlighting animation, bring back
keyboard navigation, beautify search results.

https://bugs.webkit.org/show_bug.cgi?id=34853

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.highlightLine):
  • inspector/front-end/textViewer.css:
04:55 Changeset [54719] by eric@webkit.org

2010-02-12 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717

Add expected results of the FrameSet Flattening tests.

  • platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
  • platform/mac/Skipped:

2010-02-12 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717

Add FrameSet Flattening support to Mac DRT.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setFrameSetFlatteningEnabled):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setXSSAuditorEnabled):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setFrameSetFlatteningEnabled):
  • DumpRenderTree/LayoutTestController.cpp: (setFrameSetFlatteningEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setFrameSetFlatteningEnabled):
03:03 Changeset [54718] by eric@webkit.org

2010-02-12 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] handle to the document can only own Objects, not Values
https://bugs.webkit.org/show_bug.cgi?id=34854

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::toV8):
02:20 Changeset [54717] by eric@webkit.org

2010-02-12 Kwang Yul Seo <skyul@company100.net>

Reviewed by Adam Barth.

Typedef both JSChar and UChar to wchar_t in RVCT.
https://bugs.webkit.org/show_bug.cgi?id=34560

Define both JSChar and UChar to wchar_t as the size
of wchar_t is 2 bytes in RVCT.

  • API/JSStringRef.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
02:13 Changeset [54716] by hausmann@webkit.org

.: Removed WMLInputElement.* from .gitattributes as the file is
now CRLF clean.

Reviewed by Holger Freyther.

  • .gitattributes:

WebCore: Replaced stray CRLF with LF.

Reviewed by Holger Freyther.

  • wml/WMLInputElement.cpp:

(WebCore::WMLInputElement::suggestedValue):

  • wml/WMLInputElement.h:
02:02 Changeset [54715] by jocelyn.turcotte@nokia.com

[Qt] Make qtlauncher and qgvlauncher use the generated headers
path to make sure they are correctly generated.

Reviewed by Tor Arne Vestbo.

.:

  • WebKit.pri:

WebCore:

  • WebCore.pro:

WebKit\qt:

  • tests/tests.pri:
02:01 Changeset [54714] by jocelyn.turcotte@nokia.com

[Qt] Ensure relative paths in generated .pri files to ensure that
a source package with pre-generated derived sources can be compiled.

  • Re-add a separate headers.pri file for WEBKIT_API_HEADERS
  • Rename the generated headers.pri to classheaders.pri to avoid

confusion with the one generated by synqt since they don't have the
same content.

  • Remove private headers list variable from classheaders.pri
  • Use $$PWD in classheaders.pri
  • Remove classheaders.pri from the installed files

Reviewed by Tor Arne Vestbo.

WebCore:

  • WebCore.pro:

WebKit\qt:

  • Api/DerivedSources.pro:
02:01 Changeset [54713] by jocelyn.turcotte@nokia.com

[Qt] Manually add support for the install target on Symbian.

This is required to copy the headers over the ones in Qt.

Reviewed by Tor Arne Vestbo.

.:

  • WebKit.pro:

WebCore:

  • WebCore.pro:
02:00 Changeset [54712] by jocelyn.turcotte@nokia.com

[Qt] Minor fixes on QtWebKit headers generation.

  • Adds QtWebKit to the generated headers destination path
  • Improve compatibility with MinGW

Reviewed by Tor Arne Vestbo.

WebCore:

No new tests. (OOPS!)

  • WebCore.pro:

WebKit\qt:

  • Api/DerivedSources.pro:
01:59 Changeset [54711] by jocelyn.turcotte@nokia.com

[Qt] Fix standalone build with MinGW.

Reviewed by nobody, build fix.

  • tests/qwebelement/tst_qwebelement.cpp:
  • tests/tests.pri:
01:47 Changeset [54710] by eric@webkit.org

2010-02-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Fix typos in driver_test.py

https://bugs.webkit.org/show_bug.cgi?id=34810

  • Scripts/webkitpy/layout_tests/driver_test.py:
01:39 Changeset [54709] by ossy@webkit.org

[Qt] perl websocket test(s) time out
https://bugs.webkit.org/show_bug.cgi?id=34882

  • platform/qt/Skipped: websocket/tests/cookies/httponly-cookie.pl skipped until fix.
01:14 QtWebKitTableOfFeatures46 edited by henry.haverinen@nokia.com
(diff)
00:59 Changeset [54708] by eric@webkit.org

2010-02-12 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make it possible to toggle the use of QGraphicsView in QtLauncher at run-time
https://bugs.webkit.org/show_bug.cgi?id=34844

  • QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::initializeView): (LauncherWindow::setupUI):
  • QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased):
00:00 Changeset [54707] by ukai@chromium.org

2010-02-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket ignores HttpOnly cookies, but should use in Handshake.
https://bugs.webkit.org/show_bug.cgi?id=34289

  • websocket/tests/cookies/echo-cookie_wsh.py: Added.
  • websocket/tests/cookies/httponly-cookie-expected.txt: Added.
  • websocket/tests/cookies/httponly-cookie.pl: Added.

2010-02-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket ignores HttpOnly cookies, but should use in Handshake.
https://bugs.webkit.org/show_bug.cgi?id=34289

Test: websocket/tests/cookies/httponly-cookie.pl

  • platform/CookieJar.h: add cookieRequestHeaderFieldValue()
  • platform/chromium/ChromiumBridge.h:
  • platform/haiku/CookieJarHaiku.cpp: (WebCore::cookieRequestHeaderFieldValue):
  • platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue):
  • platform/network/android/CookieJarAndroid.cpp: (WebCore::cookieRequestHeaderFieldValue):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::cookieRequestHeaderFieldValue):
  • platform/network/curl/CookieJarCurl.cpp: (WebCore::cookieRequestHeaderFieldValue):
  • platform/network/soup/CookieJarSoup.cpp: (WebCore::cookieRequestHeaderFieldValue):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::cookieRequestHeaderFieldValue):
  • platform/network/win/CookieJarWin.cpp: (WebCore::cookieRequestHeaderFieldValue):
  • platform/qt/CookieJarQt.cpp: (WebCore::cookieRequestHeaderFieldValue):
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::clientHandshakeMessage): use cookieRequestHeaderFieldValue() instead of cookies() to include HttpOnly cookies.

2010-02-11 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket ignores HttpOnly cookies, but should use in Handshake.
https://bugs.webkit.org/show_bug.cgi?id=34289

Update pywebsocket to 0.4.8, which supports cgi directories.
run-webkit-tests and run-webkit-websocketserver will run
pywebsocket, specifying /websocket/test/cookies as cgi directory.

  • Scripts/run-webkit-tests:
  • Scripts/run-webkit-websocketserver:
  • pywebsocket/mod_pywebsocket/standalone.py:
  • pywebsocket/setup.py:
Note: See TracTimeline for information about the timeline view.