Timeline


and

02/22/10:

23:53 Changeset [55123] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-02-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

Add more checking for missing binaries and packages to check_sys_deps()

https://bugs.webkit.org/show_bug.cgi?id=35062

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
23:37 Changeset [55122] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-22 Stephan Aßmus <superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Implemented PopupMenu support.
https://bugs.webkit.org/show_bug.cgi?id=35078

Covered by existing tests.

The implementation is currently very simple: Added a PopupMenuHaiku
class that derives from a native BPopUpMenu. It attaches a BHandler
derivative to the BApplication (WebCore main thread) which receives
the item invokation and menu hidden events and informs the PopupMenuClient
accordingly.

  • platform/PopupMenu.h:

Changed type of m_menu for Haiku.

  • platform/haiku/PopupMenuHaiku.cpp: (WebCore::PopupMenuHandler::PopupMenuHandler): (WebCore::PopupMenuHandler::MessageReceived): (WebCore::PopupMenuHaiku::PopupMenuHaiku): (WebCore::PopupMenuHaiku::~PopupMenuHaiku): (WebCore::PopupMenuHaiku::show): (WebCore::PopupMenuHaiku::hide): (WebCore::PopupMenuHaiku::Hide): (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu):

Removed bogus code.

(WebCore::PopupMenu::show):

Implemented using new PopupMenuHaiku class.

(WebCore::PopupMenu::hide):

Implemented using new PopupMenuHaiku class.

(WebCore::PopupMenu::updateFromElement):

Implemented.

(WebCore::PopupMenu::itemWritingDirectionIsNatural):

Implemented according to Gtk port.

22:28 Changeset [55121] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2010-02-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

[Gtk] check-webkit-style: GTK style should be allowed in WebKitTools/DumpRenderTree/gtk
https://bugs.webkit.org/show_bug.cgi?id=35229

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
21:03 Changeset [55120] by jchaffraix@webkit.org
  • 8 edits in trunk/JavaScriptCore

Remove auto_ptr usage in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=35221

Reviewed by Darin Adler.

  • parser/Nodes.h: Removed now unneeded adopt method.
  • parser/Parser.cpp: Removed <memory> include as it is not required anymore.
  • wtf/OwnPtr.h: Removed the constructor from auto_ptr.
  • wtf/VectorTraits.h: Removed a template specialization for auto_ptr.
  • wtf/unicode/Collator.h: Made userDefault return a PassOwnPtr.
  • wtf/unicode/CollatorDefault.cpp:

(WTF::Collator::userDefault): Changed the method to match the next signature.

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault): Ditto.

20:50 Changeset [55119] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-02-22 James Robinson <jamesr@chromium.org>

Unreviewed. Adding myself to committers list.

  • Scripts/webkitpy/committers.py:
20:29 Changeset [55118] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2010-02-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Remove DRT hack that turns off hardware acceleration with older QuickTimes
https://bugs.webkit.org/show_bug.cgi?id=35275

Now that WebKit does a version check to avoid a QuickTime-related
crash (r55100), DumpRenderTree does not need to.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
17:55 Changeset [55117] by eric@webkit.org
  • 5 edits in trunk

2010-02-22 Huahui Wu <hwu@google.com>

Reviewed by Eric Seidel.

Add code that enables SquirrelFish Extreme (a.k.a JSCX, JSC JIT)
in Android. It's disabled by default, but is enabled when the
enveronment variable ENABLE_JSC_JIT is set to true.
https://bugs.webkit.org/show_bug.cgi?id=34855

  • Android.mk:

2010-02-22 Huahui Wu <hwu@google.com>

Reviewed by Eric Seidel.

Add code that enables SquirrelFish Extreme (a.k.a JSCX, JSC JIT)
in Android. It's disabled by default, but is enabled when the
enveronment variable ENABLE_JSC_JIT is set to true.
https://bugs.webkit.org/show_bug.cgi?id=34855

  • Android.mk:
  • wtf/Platform.h:
17:29 Changeset [55116] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-22 Stephan Aßmus <superstippi@gmx.de>

Reviewed by Eric Seidel.

Fix various issues in PlatformMouseEventHaiku.
https://bugs.webkit.org/show_bug.cgi?id=34685

Covered by existing tests.

Mapping Haiku button constants (bit field) to WebCore buttons was broken.
Extracting event time was broken (supposed to be in seconds).
Wrong coordinate was being extracted, needs to be content local.
Added extracting modifier key flags.

  • platform/haiku/PlatformMouseEventHaiku.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
17:12 Changeset [55115] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-22 Stephan Aßmus <superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Implement creating and filling platform gradients.
https://bugs.webkit.org/show_bug.cgi?id=34683

Covered by existing tests.

  • platform/graphics/Gradient.h:

Typedef PlatformGradient to BGradient

  • platform/graphics/haiku/GradientHaiku.cpp: (WebCore::Gradient::platformDestroy):

Delete the cached BGradient object.

(WebCore::Gradient::platformGradient):

Create a BGradient object according to the type of Gradient.
Return the cached object.

(WebCore::Gradient::fill):

use BView API to fill with the platform gradient.

17:01 Changeset [55114] by tony@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-02-22 Chris Evans <cevans@chromium.org>

Reviewed by Darin Adler.

Add test for https://bugs.webkit.org/show_bug.cgi?id=32842
It has been fixed on trunk for a while, but we want to make sure we
do not regress.

  • fast/text/find-layout-crash.html: Added.
  • fast/text/find-layout-crash-expected.txt: Added.
16:55 Changeset [55113] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-22 Stephan Aßmus <superstippi@gmx.de>

Reviewed by Eric Seidel.

Build fix for debug builds of GlyphPageTreeNode.cpp
https://bugs.webkit.org/show_bug.cgi?id=34528

Covered by existing tests.

  • platform/graphics/GlyphPageTreeNode.cpp:

include <stdio.h> since printf() is used if NDEBUG is not defined.

16:45 Changeset [55112] by sfalken@apple.com
  • 6 edits in trunk/WebKit/win

WebKit on Windows should pick up system setting changes without requiring explicit API calls
https://bugs.webkit.org/show_bug.cgi?id=35269

Reviewed by Darin Adler.

  • WebKit.vcproj/WebKit.def: Removed WebKitSystemParameterChanged.
  • WebKit.vcproj/WebKit_debug.def: Removed WebKitSystemParameterChanged.
  • WebKitGraphics.cpp: Removed WebKitSystemParameterChanged.
  • WebKitGraphics.h: Removed WebKitSystemParameterChanged.
  • WebView.cpp:

(systemParameterChanged): Call through to wkSystemFontSmoothingChanged for font changes.
(WebView::windowReceivedMessage): Pick up WM_SETTINGCHANGE from windowReceivedMessage.

16:12 Changeset [55111] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2010-02-22 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium build fix.

Add special case in CodeGeneratorV8.pm for named getters for html plugin-related elements.

CodeGeneratorV8.pm was relying on HasOverridingNameGetter to hint
that a custom named getter was needed. That hint was removed in
http://trac.webkit.org/changeset/55104.

  • bindings/scripts/CodeGeneratorV8.pm:
15:28 Changeset [55110] by ossy@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Rubber-stamped by Alexey Proskuryakov.

[Qt] fast/encoding/invalid-UTF-8-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=35263

Qt Linux Release buildbot got the platform independent result for
fast/encoding/invalid-UTF-8-2.html instead of Qt specific one.

Qt specific expected file is removed to make buildbot green,
but it needs more investigation.

  • platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt: Removed.
15:27 Changeset [55109] by ap@apple.com
  • 21 edits in trunk

Rubber-stamped by Geoff Garen.

Rename RuntimeObjectImp to RuntimeObject.

15:23 Changeset [55108] by pkasting@chromium.org
  • 3 edits
    3 adds in trunk

Avoid recursion when trying to get the size of a PNG; it's unnecessary
and in the worst case can lead to heap corruption.
https://bugs.webkit.org/show_bug.cgi?id=35167

Reviewed by Eric Seidel.

WebCore:

Test: fast/images/bad-png.html

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::decode):

LayoutTests:

  • fast/images/bad-png-expected.txt: Added.
  • fast/images/bad-png.html: Added.
  • fast/images/resources/bad-png.png: Added.
15:20 BuildingOnWindows edited by aroben@apple.com
(diff)
15:10 Changeset [55107] by beidson@apple.com
  • 8 edits in trunk

Disable WebView docking to views that are too small.
<rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254

Reviewed by Tim Hatcher.

WebCore:

  • WebCore.base.exp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::canAttachWindow): Provide a utility for WebKits to make a showWindow()

decision based on if attachment would be allowed or not.

(WebCore::InspectorController::attachWindow): Don't attach if the view is too small to attach to.

  • inspector/InspectorController.h:

WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController showWindow:]): No matter the preference, don't open the inspector

window attached if WebCore says it shouldn't be attached.

WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector

window attached if WebCore says it shouldn't be attached.

14:32 Changeset [55106] by ap@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • WebCore.base.exp: Export Instance::newRuntimeObject, it's virtual!
14:25 Changeset [55105] by ap@apple.com
  • 2 edits in trunk/WebCore

Undo a small part of the previous commit.

  • bridge/runtime_method.cpp: (JSC::callRuntimeMethod): Let's keep the instance local variable as RefPtr for safety.
14:21 Changeset [55104] by ap@apple.com
  • 12 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=35260
Eliminate apple_runtime_object

No change in functionality, so no tests.

  • WebCore.base.exp: Don't export Instance::newRuntimeObject, WebKit doesn't need it.
  • bindings/js/JSHTMLAppletElementCustom.cpp:
  • bindings/js/JSHTMLEmbedElementCustom.cpp:
  • bindings/js/JSHTMLObjectElementCustom.cpp:
  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLObjectElement.idl: These objects no longer need overriding name getters, as they no longer intercept the apple_runtime_object property.
  • bindings/js/JSPluginElementFunctions.cpp: (WebCore::pluginInstance): This is no longer static. It was used for callPlugin() in this file, and now it's also used elsewhere when calling plug-in methods. (WebCore::runtimeObjectGetter): Removed. This function was only used by the intercepting name getters.
  • bindings/js/JSPluginElementFunctions.h: Export pluginInstance().
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  • bridge/runtime_method.cpp: (JSC::callRuntimeMethod): Take plug-in element's instance directly, without relying on fake attribute lookup. One change resulting from this is that RuntimeObjectImp may not be created in some cases - this code only needs an instance, but the old code had to pass the instance wrapped into RuntimeObjectImp.
14:17 Changeset [55103] by ap@apple.com
  • 5 edits
    3 adds in trunk/LayoutTests

2010-02-22 Robert Hogan <robert@roberthogan.net>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=32937
LayoutTests/fast/encoding/invalid-UTF-8.html fails on Qt.

The test was verifying two things: first, that U+FFFD is rendered by the browser, and second,
that ill-formed UTF-8 sequences are turned into U+FFFD. Some aspects of the latter are not
precisely defined by the Unicode specification, so different platforms may legitimately
have different results.

Split the test into two: one to test the rendering of invalid UTF-8 sequences, and the other
to protect against regressions in each platform's decoding behaviour.

  • fast/encoding/invalid-UTF-8-2-expected.txt: Added.
  • fast/encoding/invalid-UTF-8-2.html: Added.
  • fast/encoding/invalid-UTF-8.html:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.png:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
  • platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt:
13:07 Changeset [55102] by cfleizach@apple.com
  • 3 edits in trunk/LayoutTests

Bug 35186 - AX: AXFocused is not writable like it should be on nodes
https://bugs.webkit.org/show_bug.cgi?id=35186

Fixing layout test failure.

12:59 Changeset [55101] by sullivan@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=35256
HTMLSelectElement::setSelectedIndexByUser() can trigger unnecessary JS when there is no change to the selected index

Reviewed by Tim Hatcher.

No new tests because this code path is not used for JS-initiated changes.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setSelectedIndexByUser):
Bail out if the to-be-selected index matches the already-selected index.

12:51 Changeset [55100] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2010-02-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by John Sullivan.

<rdar://problem/7285392>
On Leopard, we have to disable hardware acceleration if we detect that the
installed Core Video framework has bug <rdar://problem/7228836>.

  • WebView/WebView.mm: (coreVideoHas7228836Fix): (-[WebView _preferencesChangedNotification:]):
12:18 Changeset [55099] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.22

Tagging 1.1.22.

12:05 Changeset [55098] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Reproducible crash in WebCore::nextLinePosition on Tweeteorites.com
<rdar://problem/7615758>
https://bugs.webkit.org/show_bug.cgi?id=35060

Reviewed by Dan Bernstein.

WebCore:

Test: editing/selection/extend-byline-withfloat.html

  • editing/visible_units.cpp:

(WebCore::previousLinePosition): Skip elements with zero height.
(WebCore::nextLinePosition): Skip elements with zero height.

LayoutTests:

  • editing/selection/extend-byline-withfloat-expected.txt: Added.
  • editing/selection/extend-byline-withfloat.html: Added.
12:03 Changeset [55097] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2010-02-22 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium build fix.

  • bindings/scripts/CodeGeneratorV8.pm: Compile break due to bad patch merge.
11:53 Changeset [55096] by japhet@chromium.org
  • 27 edits
    5 deletes in trunk/WebCore

2010-02-22 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Streamline V8 event listener code. Merge all the variants of
V8DOMWrapper::getEventListner() into a single version and generate
addEventListener() and removeEventListener() bindings for all objects
except DOMWindow.

https://bugs.webkit.org/show_bug.cgi?id=35245

11:29 Changeset [55095] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

AX: AXFocused is not writable like it should be on nodes
https://bugs.webkit.org/show_bug.cgi?id=35186

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/element-focus.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::canSetFocusAttribute):

LayoutTests:

  • platform/mac/accessibility/element-focus-expected.txt: Added.
  • platform/mac/accessibility/element-focus.html: Added.
11:24 Changeset [55094] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed Symbian build fix.

[Qt] Updated the def file with new exports to enable
building DumpRenderTree.

  • symbian/eabi/QtWebKitu.def:
11:12 Changeset [55093] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

JSStringBuilder should not CRASH if allocation fails, it should throw a JSException.

Reviewed by Oliver Hunt.

  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::build):

  • runtime/StringBuilder.h:

(JSC::StringBuilder::build):

  • wtf/Vector.h:

(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::::tryExpandCapacity):
(WTF::::tryReserveCapacity):
(WTF::::tryAppend):

11:07 Changeset [55092] by xan@webkit.org
  • 4 edits in trunk

2010-02-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump library versioning for 1.1.22 release.

  • configure.ac:

WebKit/gtk:

2010-02-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for release.

  • NEWS:
11:02 Changeset [55091] by eric@webkit.org
  • 2 edits
    1 add in trunk/JavaScriptCore

2010-02-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Map FastMalloc to BREW memory allocator
https://bugs.webkit.org/show_bug.cgi?id=33570

Use MALLOC macro instead of the standard malloc function.
Although RVCT provides malloc, we can't use it in BREW
because the loader does not initialize the base address properly.

  • wtf/FastMalloc.cpp:
  • wtf/brew/SystemMallocBrew.h: Added. (mallocBrew): (callocBrew): (freeBrew): (reallocBrew):
10:48 Changeset [55090] by simon.fraser@apple.com
  • 11 edits in trunk/WebCore

2010-02-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein, Darin Adler.

Remove addScrolledContentOffset/subtractScrolledContentOffset
https://bugs.webkit.org/show_bug.cgi?id=35225

Remove RenderLayer's addScrolledContentOffset() and subtractScrolledContentOffset()
methods, and instead use the existing scrolledContentOffset(), and use
IntSize and IntPoint instead of lots of x, y variables.

Added new IntPoint toPoint(const IntSize&) method as a convenience to convert a size to a point,
which is needed in a few places.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): Use the new toPoint() convenience.
  • platform/graphics/IntPoint.h: (WebCore::toPoint): New convenience method to convert an IntSize to an IntPoint.
  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::selectionGapRectsForRepaint): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::offsetForContents):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::clippedOverflowRectForRepaint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::size):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::computeRectForRepaint):
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint):
10:36 Changeset [55089] by agl@chromium.org
  • 12 edits
    3 copies in trunk

2009-02-22 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

fontconfig on Linux can change the render preferences on a per strike
basis (a strike a combination of face and size). Because of this, we
need to query fontconfig each time a new FontPlatformData is created
for a new size.

This patch adds support for querying this via ChromiumBridge.

https://bugs.webkit.org/show_bug.cgi?id=33065

  • platform/chromium/ChromiumBridge.h: add getRenderStyleForStrike
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setupPaint): (WebCore::FontPlatformData::queryStyle): add code to query fontconfig via ChromiumBridge
  • platform/graphics/chromium/FontPlatformDataLinux.h:
10:11 Changeset [55088] by kov@webkit.org
  • 4 edits in trunk

Build fix for make distcheck.

09:25 Changeset [55087] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix compiler warning "suggest parentheses around"
https://bugs.webkit.org/show_bug.cgi?id=35197

No new tests as there is no new functionality.

  • wml/WMLVariables.cpp: (WebCore::substituteVariableReferences):
09:01 Changeset [55086] by kov@webkit.org
  • 8 edits in trunk

WebCore

2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093

Store message flags in WebCore objects, and set them on the
SoupMessage, when creating one from them.

No behaviour change.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
  • platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::soupMessageFlags): (WebCore::ResourceRequest::setSoupMessageFlags):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
  • platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::soupMessageFlags): (WebCore::ResourceResponse::setSoupMessageFlags):
  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::toSoupMessage): (WebCore::ResourceResponse::updateFromSoupMessage):

WebKit/gtk

2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093

Update the flags that are stored in the request, when the response
is received.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
08:40 Changeset [55085] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] Build the DRT in debug on Mac OS X

Reviewed by Kenneth Rohde Christiansen.

  • DumpRenderTree/qt/DumpRenderTree.pro:
08:17 Changeset [55084] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-22 Steve Block <steveblock@google.com>

Reviewed by Nate Chapin.

Shared worker types used in globalObjectPrototypeIsDOMWindow are not properly guarded
https://bugs.webkit.org/show_bug.cgi?id=35238

No new tests, build fix only.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::globalObjectPrototypeIsDOMWindow):
07:16 Changeset [55083] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/JavaScriptCore

2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed build fix.

[Qt] Build fix for RVCT.

Fix after r55024. The "-i" option is for perl not for the
script.

  • DerivedSources.pro:
07:12 Changeset [55082] by eric@webkit.org
  • 6 edits in trunk

2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add support for layout tests on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31589

  • WebKit.pro:

2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add support for layout tests on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31589

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  • DumpRenderTree/qt/main.cpp: (main):
06:26 Changeset [55081] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-22 Steve Block <steveblock@google.com>

Reviewed by Simon Fraser.

Simplifies calculation of the transform in RenderLayer::paintLayer
https://bugs.webkit.org/show_bug.cgi?id=35101

No new tests, optimization only.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
06:21 Changeset [55080] by vestbo@webkit.org
  • 2 edits in trunk/BugsSite

2010-02-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Maciej Stachowiak.

Don't reset the assignee back to default on component change

https://bugs.webkit.org/show_bug.cgi?id=35236

There's a risk of reseting a valid assignee for example when
triaging a bug. All components in WebKit have the default
assignee set to webkit-unassigned@webkit.org so this should
not cause problems for people relying on this functionality.

  • template/en/custom/bug/edit.html.tmpl:
05:42 Changeset [55079] by vestbo@webkit.org
  • 6 edits
    2 adds in trunk/WebCore

[Qt] Switching from Phonon to QtMultimedia Backend for Qt 4.7

Patch by Nicholas Young <nicholas.young@nokia.com> on 2010-02-22
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=34631

No new tests. This patch only affects multimedia backend.

  • WebCore.pro: Build depends on Qt version.
  • css/mediaControlsQt.css: Updated media controls.
  • platform/graphics/MediaPlayer.cpp: Different backend included depending on Qt version.
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: Added new QtMultimedia Backend.

(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::supportsMuting):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::mediaStatusChanged):
(WebCore::MediaPlayerPrivate::handleError):
(WebCore::MediaPlayerPrivate::stateChanged):
(WebCore::MediaPlayerPrivate::nativeSizeChanged):
(WebCore::MediaPlayerPrivate::queuedSeekTimeout):
(WebCore::MediaPlayerPrivate::seekTimeout):
(WebCore::MediaPlayerPrivate::positionChanged):
(WebCore::MediaPlayerPrivate::durationChanged):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::mutedChanged):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::repaint):

  • platform/graphics/qt/MediaPlayerPrivateQt.h: Added new QtMultimedia Backend.

(WebCore::MediaPlayerPrivate::isAvailable):
(WebCore::MediaPlayerPrivate::supportsFullscreen):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::mediaControlsBaselineOpacity): New method.
(WebCore::RenderThemeQt::paintMediaBackground): Background depends on baseline opacity.
(WebCore::RenderThemeQt::paintMediaMuteButton): Changed styling.
(WebCore::RenderThemeQt::paintMediaCurrentTime): Added current time display.
(WebCore::RenderThemeQt::formatMediaControlsCurrentTime): Added time formatting.
(WebCore::RenderThemeQt::formatMediaControlsRemainingTime): Added time formatting.
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack): Volume slider added.
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb): Volume slider added.
(WebCore::RenderThemeQt::paintMediaSliderTrack): Updated for QtMultimedia.
(WebCore::RenderThemeQt::paintMediaSliderThumb): Dropped an unnecessary check.
(WebCore::RenderThemeQt::adjustSliderThumbSize): Handle a missing case.

  • platform/qt/RenderThemeQt.h: Reimplemented a few more methods.
05:02 Changeset [55078] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-02-22 Alexander Pavlov <apavlov@chromium.org>

Not reviewed: mac build fix

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer):
04:14 Changeset [55077] by apavlov@chromium.org
  • 15 edits
    2 adds in trunk

2010-02-22 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: there should be a way to "deactivate" or "skip" all breakpoints while debugging.
https://bugs.webkit.org/show_bug.cgi?id=33217

WebCore:

  • English.lproj/localizedStrings.js:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::setBreakpointsActivated):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::setBreakpointsActivated):
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::activateBreakpoints): (WebCore::InspectorBackend::deactivateBreakpoints):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png: Added.
  • inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png: Added.
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.activateBreakpoints): (.WebInspector.InspectorBackendStub.prototype.deactivateBreakpoints):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get breakpointsActivated): (WebInspector.ScriptsPanel.prototype.addBreakpoint): (WebInspector.ScriptsPanel.prototype._stepOutClicked): (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
  • inspector/front-end/inspector.css:
  • inspector/front-end/textViewer.css:

WebKit/chromium:

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent): (devtools.DebuggerAgent.prototype.setBreakpointsActivated): (devtools.DebuggerAgent.prototype.handleBreakEvent_): (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl.prototype.activateBreakpoints): (devtools.InspectorBackendImpl.prototype.deactivateBreakpoints):
03:18 Changeset [55076] by mrowe@apple.com
  • 2 edits in trunk/WebCore

REGRESSION (r55039): Animation starts from near end when loaded over slow network
<http://webkit.org/b/35222> / <rdar://problem/7673523>

Rubber-stamped by Sam Weinig and Maciej Stachowiak.

Roll out r55039 (related to <http://webkit.org/b/35115>) as it causes animated GIFs
to skip intermediate frames when loading over a slower network.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startAnimation):

02:31 Changeset [55075] by mjs@apple.com
  • 12 edits
    1 delete in trunk/WebCore

Not reviewed, build fix.

Revert the previous change.

01:28 Changeset [55074] by mjs@apple.com
  • 12 edits
    1 add in trunk/WebCore

2010-02-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

Cache JavaScript wrappers inline in DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=35226
<rdar://problem/7664202>

8.8% speedup on Dromaeo DOM Core tests.
3.3% speedup on Hixie DOM Core tests.


  • bindings/js/JSDOMBinding.cpp: (WebCore::forgetDOMNode): Clear wrapper pointer. (WebCore::cacheDOMNodeWrapper): Cache inline too if caching for normal world.
  • bindings/js/JSDOMBinding.h: (WebCore::DOMObjectWrapperMapFor):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Remove unneeded argument from getCachedDOMNodeWrapper.
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline): Renamed version of original createWrapper. (WebCore::createWrapper): Call createWrapperInline. Out-of-line version. (WebCore::toJSNewlyCreated): Call createWrapperInline instead of createWrapper.
  • bindings/js/JSNodeCustom.h: Added. (WebCore::getCachedDOMNodeWrapper): Moved here so it can be inlined. (WebCore::toJS): Moved here so it can be inlined.
  • bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): Implement this in the obvious way for JavaScriptCore. (WebCore::ScriptWrappable::wrapper): (WebCore::ScriptWrappable::setWrapper): (WebCore::ScriptWrappable::clearWrapper):
  • bindings/scripts/CodeGeneratorJS.pm: Include CustomHeader heaaders in the header, not just the impl file, so they can add inlining.
  • dom/Node.idl: Add CustomHeader directive.


Add new files to build.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
01:13 Changeset [55073] by pfeldman@chromium.org
  • 9 edits
    1 add in trunk/WebCore

2010-02-22 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: windows build fix.

00:08 Changeset [55072] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Part 2 of Windows build fix.

02/21/10:

23:59 Changeset [55071] by pfeldman@chromium.org
  • 34 edits
    1 move
    2 deletes in trunk

2010-02-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: stop on inline breakpoints on reload.

  • ScriptBreakpoint struct has been introduced and reused in InspectorController and debug server.
  • JavaScriptDebugServer was moved to bindings/js and renamed to ScriptDebugServer There were no changes to semantics, only some mechanical changes:
    • addBreakpoint and updateBreakpoint were merged into setBreakpoint
    • ScriptDebugServer now operates ScriptBreakpoint instances instead of BreakpointInfo.
    • It no longer allocates maps and breakpoint info in heap - all done on stack.
    • JavaScriptDebugListener is now ScriptDebugServer::Listener
    • Listener methods no longer have ExecState (was unused).
    • addListener/removeListener pair wuth no page argument removed (was unused).
  • InspectorController now binds sourceID to url and maintains a map of 'sticky' breakpoints. Whenever script is loaded and there is a sticky breakpoint url matching, breakpoint is being 'restored' synchronously in debug server and pushed to frontend. Front-end no longer stores map of sticky breakpoints.
    • setBreakpoint/removeBreakpoint/didParseSource trio handle this logic.
  • A bunch of if(USE_JSC/V8/other) forks removed.
  • InspectorFrontend now operates primitive types only, got rid of USE_JSC as well.

https://bugs.webkit.org/show_bug.cgi?id=28799

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame): (WebCore::JSInjectedScriptHost::isActivation):
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::shared): (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::~ScriptDebugServer): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::pageCreated): (WebCore::ScriptDebugServer::hasListenersInterestedInPage): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::pauseProgram): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrame): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::dispatchFailedToParseSource): (WebCore::toPage): (WebCore::ScriptDebugServer::detach): (WebCore::ScriptDebugServer::sourceParsed): (WebCore::ScriptDebugServer::dispatchFunctionToListeners): (WebCore::ScriptDebugServer::setJavaScriptPaused): (WebCore::ScriptDebugServer::pauseIfNeeded): (WebCore::ScriptDebugServer::callEvent): (WebCore::ScriptDebugServer::atStatement): (WebCore::ScriptDebugServer::returnEvent): (WebCore::ScriptDebugServer::exception): (WebCore::ScriptDebugServer::willExecuteProgram): (WebCore::ScriptDebugServer::didExecuteProgram): (WebCore::ScriptDebugServer::didReachBreakpoint): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon): (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::didAddListener): (WebCore::ScriptDebugServer::didRemoveListener): (WebCore::ScriptDebugServer::didRemoveLastListener):
  • bindings/js/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Listener::~Listener): (WebCore::ScriptDebugServer::): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::hasListeners): (WebCore::ScriptDebugServer::hasGlobalListeners):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::shared):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::Listener::~Listener): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::pauseProgram): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon): (WebCore::ScriptDebugServer::recompileAllJSFunctions): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::pageCreated): (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::~ScriptDebugServer):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setBreakpoint): (WebCore::InspectorBackend::removeBreakpoint): (WebCore::InspectorBackend::pauseInDebugger): (WebCore::InspectorBackend::stepOverStatementInDebugger): (WebCore::InspectorBackend::stepIntoStatementInDebugger): (WebCore::InspectorBackend::stepOutOfFunctionInDebugger): (WebCore::InspectorBackend::pauseOnExceptionsState): (WebCore::InspectorBackend::setPauseOnExceptionsState):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/ScriptBreakpoint.h: Added. (WebCore::InspectorBreakpoint::InspectorBreakpoint):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::addProfile): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::resumeDebugger): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::failedToParseSource): (WebCore::InspectorController::didPause):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::restoredBreakpoint): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::resumedScript):
  • inspector/InspectorFrontend.h:
  • inspector/JavaScriptDebugListener.h: Removed.
  • inspector/JavaScriptDebugServer.cpp: Removed.
  • inspector/JavaScriptDebugServer.h: Removed.
  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set condition):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.sourceFrameForResource):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.addScript): (WebInspector.ScriptsPanel.prototype.addBreakpoint): (WebInspector.ScriptsPanel.prototype.removeBreakpoint): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/inspector.js: (WebInspector.restoredBreakpoint):
  • page/Page.cpp: (WebCore::Page::Page):
  • platform/android/TemporaryLinkStubs.cpp:
23:56 Changeset [55070] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Part 1 of Windows build fix.

22:50 Changeset [55069] by barraclough@apple.com
  • 7 edits in trunk

JavaScriptCore: Make UString::m_data be const, and make the UChar owned/ref-counted by CrossThreadRefCounted be const too.

Reviewed by Oliver Hunt.

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::~UStringImpl):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::create):
(JSC::UStringImpl::data):
(JSC::UStringImpl::UStringImpl):

  • wtf/OwnFastMallocPtr.h:

(WTF::OwnFastMallocPtr::~OwnFastMallocPtr):

WebCore: Make the UChar owned/ref-counted by StringImpl::CrossThreadRefCounted be const.

Reviewed by Oliver Hunt.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::sharedBuffer):

  • platform/text/StringImpl.h:
22:12 Changeset [55068] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-21 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

HashMapTranslatorAdapter::translate() needs to set the mapped value.

HTTPHeaderMap::add(const char*, const String&) does not work
https://bugs.webkit.org/show_bug.cgi?id=35227

  • wtf/HashMap.h: (WTF::HashMapTranslatorAdapter::translate):
20:12 Changeset [55067] by yuzo@google.com
  • 4 edits
    3 adds in trunk

2010-02-07 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

When page-break-{after,before} is set to always, force page breaks even for overflow-specified elements.
RenderBlock::inRootBlockContext() was introduced by Changeset 5611. Although it is a reasonable criteria for choosing an optional page break location, it is not for a mandatory page break as specified by http://dev.w3.org/csswg/css3-page/#forced-pg-brk. The method is removed because it is not used anywhere else.
Note: this patch makes page break work for overflow-specified elements. For tables and floated elements, more work is needed.
https://bugs.webkit.org/show_bug.cgi?id=9526

  • printing/page-break-always-for-overflow-expected.txt: Added.
  • printing/page-break-always-for-overflow.html: Added.
  • printing/script-tests/page-break-always-for-overflow.js: Added.

2010-02-07 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

When page-break-{after,before} is set to always, force page breaks even for overflow-specified elements.
RenderBlock::inRootBlockContext() was introduced by Changeset 5611. Although it is a reasonable criteria for choosing an optional page break location, it is not for a mandatory page break as specified by http://dev.w3.org/csswg/css3-page/#forced-pg-brk. The method is removed because it is not used anywhere else.
Note: this patch makes page break work for overflow-specified elements. For tables and floated elements, more work is needed.
https://bugs.webkit.org/show_bug.cgi?id=9526

Test: printing/page-break-always-for-overflow.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
  • rendering/RenderBlock.h:
15:40 Changeset [55066] by jchaffraix@webkit.org
  • 19 edits in trunk/WebCore

Remove auto_ptr usage in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=35157

Reviewed by Eric Seidel.

The changes consists of:

  • Changing auto_ptr arguments or return types to PassOwnPtr.
  • Replacing local auto_ptr by OwnPtr.
  • Removing now unneeded <memory> inclusion.
  • css/CSSParser.cpp:

(WebCore::CSSParser::addProperty):

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
(WebCore::workerContextDidReceiveResponse):
(WebCore::workerContextDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::workerContextDidReceiveAuthenticationCancellation):

  • loader/WorkerThreadableLoader.h:
  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::create):

  • loader/icon/IconLoader.h:
  • platform/ContextMenu.cpp:

(WebCore::separatorItem):

  • platform/CrossThreadCopier.h:

(WebCore::):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::adopt):

  • platform/network/HTTPHeaderMap.h:
  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):

  • platform/network/ResourceRequestBase.h:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::copyData):

  • platform/network/ResourceResponseBase.h:
  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removePendingResource):

  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::insertedIntoDocument):

  • workers/GenericWorkerTask.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::create):

13:47 Changeset [55065] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2010-02-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22215
Avoid calling absoluteClippedOverflowRect() so many times

RenderLayer::updateLayerPositions() computes the clipped overflow rect
and the outline bounds for repaint, and then calls repaintAfterLayoutIfNeeded()
which can compute the same rects all over again. Avoid this by passing
these two rects into repaintAfterLayoutIfNeeded() if known. This measurably
reduces the time spent in updateLayerPositions() for some content.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/RenderObject.h:
13:19 Changeset [55064] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

False warnings about needing layout in
-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
https://bugs.webkit.org/show_bug.cgi?id=35218

Reviewed by Darin Adler.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
Suppress the warning and the forced layout if the view is not being drawn
in this display operation.

12:20 Changeset [55063] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=35215
<rdar://problem/7673157>


The plugInViewWithArguments: API passes a dictionary of plugin arguments. One of the parameters
is WebPlugInBaseURLKey, which is a key that represents the base URL of the document containing
the plug-in's view. Instead of sending the base URL, code in WebFrameLoaderClient::createPlugin
would incorrectly pass the source URL of the plug-in resource.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): When building the plug-in arguments dictionary, pass the real base URL for the WebPlugInBaseURLKey key.
03:32 Changeset [55062] by mjs@apple.com
  • 3 edits
    17 adds in trunk

2010-02-20 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Adam Barth.

Add sunspider-0.9.1 to the site in preparation for announcing it.
https://bugs.webkit.org/show_bug.cgi?id=35206

  • perf/sunspider-0.9.1: Added.
  • perf/sunspider-0.9.1/json2.js: Added.
  • perf/sunspider-0.9.1/sunspider-0.9: Added.
  • perf/sunspider-0.9.1/sunspider-0.9.1: Added.
  • perf/sunspider-0.9.1/sunspider-0.9.1/driver.html: Added.
  • perf/sunspider-0.9.1/sunspider-0.9.1/results.html: Added.
  • perf/sunspider-0.9.1/sunspider-0.9.1/sunspider-test-contents.js: Added.
  • perf/sunspider-0.9.1/sunspider-0.9.1/sunspider-test-prefix.js: Added.
  • perf/sunspider-0.9.1/sunspider-0.9/driver.html: Added.
  • perf/sunspider-0.9.1/sunspider-0.9/results.html: Added.
  • perf/sunspider-0.9.1/sunspider-0.9/sunspider-test-contents.js: Added.
  • perf/sunspider-0.9.1/sunspider-0.9/sunspider-test-prefix.js: Added.
  • perf/sunspider-0.9.1/sunspider-analyze-results.js: Added.
  • perf/sunspider-0.9.1/sunspider-compare-results.js: Added.
  • perf/sunspider-0.9.1/sunspider.css: Added.
  • perf/sunspider-0.9.1/sunspider.html: Added.
  • perf/sunspider-0.9.1/versions.html: Added.

2010-02-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Add sunspider-0.9.1 to the site in preparation for announcing it.
https://bugs.webkit.org/show_bug.cgi?id=35206

  • hosted/sunspider.css: Remove tabs, which I noticed where present while copying to the WebKitSite directory.

02/20/10:

22:44 Changeset [55061] by mjs@apple.com
  • 13 edits in branches/safari-532-branch

<rdar://problem/7540432> Disable sandboxed iframes for branch

Reviewed by Dan Bernstein.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.pri:

WebKit/chromium:

  • features.gypi:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools:

  • Scripts/build-webkit:
22:20 Changeset [55060] by mjs@apple.com
  • 17 edits in branches/safari-532-branch

.: Merged from trunk:

2010-02-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • configure.ac:

JavaScriptCore: Merged from trunk:

2010-02-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • Configurations/FeatureDefines.xcconfig:

WebCore: Merged from trunk:

2010-02-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

I made ENABLE(SANDBOX) only control the sandbox attribute itself;
I did not ifdef the infrastructure to make sandboxing
switchable. This is because the likely concerns about sandboxing
are not stability of the infrastructure code, but rather the fact
that the security model exposed to authors is still evolving.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseMappedAttribute):

WebKit/chromium: Merged from trunk:

2010-02-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • features.gypi:

WebKit/mac: Merged from trunk:

2010-02-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries: Merged from trunk:

2010-02-20 Maciej Stachowiak <mjs@apple.

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools: Merged from trunk:

2010-02-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • Scripts/build-webkit: Handle new flag.
22:01 Changeset [55059] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=35202
<rdar://problem/4856597> Calling Java method which accepts Object always passes a null argument

  • bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Add cases for other JS types.
21:22 Changeset [55058] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Fix compiler warning "suggest parentheses around"
https://bugs.webkit.org/show_bug.cgi?id=35197

No new tests as there is no new functionality.

  • html/DateComponents.cpp: (WebCore::beforeGregorianStartDate):
  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::findPlugin):
12:44 Changeset [55057] by cjerdonek@webkit.org
  • 2 edits
    1 move in trunk/WebKitTools

Moved simplejson into webkitpy/thirdparty directory.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35196

  • Scripts/run-chromium-webkit-tests:
    • Added webkitpy/thirdparty to the script's search path.
  • Scripts/webkitpy/thirdparty/simplejson: Copied from WebKitTools/simplejson.
    • Copied simplejson directory.
  • simplejson: Removed.
  • simplejson/LICENSE.txt: Removed.
  • simplejson/README.txt: Removed.
  • simplejson/init.py: Removed.
  • simplejson/_speedups.c: Removed.
  • simplejson/decoder.py: Removed.
  • simplejson/encoder.py: Removed.
  • simplejson/jsonfilter.py: Removed.
  • simplejson/scanner.py: Removed.
12:24 Changeset [55056] by laszlo.1.gombos@nokia.com
  • 4 edits in trunk

2010-02-20 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] ENABLE_3D_RENDERING should be optional
https://bugs.webkit.org/show_bug.cgi?id=35100

  • WebKit.pri: ENABLE_3D_RENDERING moved to a proper feature test

2010-02-20 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] ENABLE_3D_RENDERING should be optional
https://bugs.webkit.org/show_bug.cgi?id=35100

No new tests: this is a build fix.

  • WebCore.pri: ENABLE_3D_RENDERING is now a proper feature test
11:36 Changeset [55055] by cjerdonek@webkit.org
  • 6 edits
    1 move in trunk/WebKitTools

2010-02-20 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

Moved BeautifulSoup to webkitpy/thirdparty directory.

https://bugs.webkit.org/show_bug.cgi?id=35195

  • Scripts/webkitpy/BeautifulSoup.py: Removed.
    • Moved to webkitpy/thirdparty.
  • Scripts/webkitpy/bugzilla.py:
    • Updated import statement.
  • Scripts/webkitpy/bugzilla_unittest.py:
    • Updated import statement.
  • Scripts/webkitpy/buildbot.py:
    • Updated import statement.
  • Scripts/webkitpy/buildbot_unittest.py:
    • Updated import statement.
  • Scripts/webkitpy/statusserver.py:
    • Updated import statement.
  • Scripts/webkitpy/thirdparty/BeautifulSoup.py: Copied from WebKitTools/Scripts/webkitpy/BeautifulSoup.py.
10:22 Changeset [55054] by ap@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=23742
Applet methods can not return arrays to JS

  • bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaArray::JavaArray): Don't accidentally zero out m_rootObject (that's how PassRefPtr works). Without m_rootObject, we crash quickly.
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Do handle returned arrays. Also, added an ifdef around code that's only needed on Tiger, and removed a comment saying it can be removed when "new" plugin ships. I doubt that anyone can remember what "new" could refer to back then.
09:42 Changeset [55053] by cjerdonek@webkit.org
  • 2 edits
    1 move
    2 adds in trunk/WebKitTools

2010-02-20 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

Created a directory for third-party Python code, and moved
autoinstall.py into it.

https://bugs.webkit.org/show_bug.cgi?id=34540

  • Scripts/webkitpy/init.py:
    • Updated "import autoinstall" statement.
  • Scripts/webkitpy/autoinstall.py: Removed.
    • Moved to thirdparty/autoinstall.py.
  • Scripts/webkitpy/thirdparty: Added.
  • Scripts/webkitpy/thirdparty/init.py: Added.
  • Scripts/webkitpy/thirdparty/autoinstall.py: Copied from WebKitTools/Scripts/webkitpy/autoinstall.py.
07:40 Changeset [55052] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's visibleView logic.

https://bugs.webkit.org/show_bug.cgi?id=35192

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.viewRecreated):
07:23 Changeset [55051] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: need to highlight the evaluated expression used for popovers.

https://bugs.webkit.org/show_bug.cgi?id=35126

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseMove): (WebInspector.SourceFrame.prototype._hidePopup): (WebInspector.SourceFrame.prototype._mouseHover): (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup):
  • inspector/front-end/inspector.css:
06:29 Changeset [55050] by kov@webkit.org
  • 8 edits in trunk

Roll out 55047, since it causes regressions in layout and API tests.

06:29 Changeset [55049] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed, obvious fix for the python failure in our new buildbot step:

http://build.webkit.org/builders/GTK Linux 32-bit Release/builds/9075/steps/API tests/logs/err.text

06:13 Changeset [55048] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-02-20 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed. Trivial fix - unnecessary variable got added by
mistake.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
04:35 Changeset [55047] by kov@webkit.org
  • 8 edits in trunk

WebCore

2010-02-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093

Store message flags in WebCore objects, and set them on the
SoupMessage, when creating one from them.

No behaviour change.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
  • platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::soupMessageFlags): (WebCore::ResourceRequest::setSoupMessageFlags):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
  • platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::soupMessageFlags): (WebCore::ResourceResponse::setSoupMessageFlags):
  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::toSoupMessage): (WebCore::ResourceResponse::updateFromSoupMessage):

WebKit/gtk

2010-02-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093

Update the flags that are stored in the request, when the response
is received.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
04:25 Changeset [55046] by kov@webkit.org
  • 3 edits in trunk/WebCore

2010-02-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[Soup] loses information related to message flags when converting from/to Resource{Request,Response}
https://bugs.webkit.org/show_bug.cgi?id=35093

Refactor updating of ResourceResponse objects from soup message
objects, to avoid code duplication.

No behaviour change.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):
01:33 Changeset [55045] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=35190
Don't use system malloc in Java bindings

  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Switched to WTF::Vector.
00:24 Changeset [55044] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=9761
LiveConnect string conversion fails for java.lang.Object

Can't test Java in DRT (I wonder why).

  • bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Added the necessary conversion. Also, removed CONVERT_NULL_TO_EMPTY_STRING dead code.

02/19/10:

19:06 Changeset [55043] by mjs@apple.com
  • 17 edits in trunk

2010-02-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • Configurations/FeatureDefines.xcconfig:

2010-02-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • win/tools/vsprops/FeatureDefines.vsprops:

2010-02-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • features.gypi:

2010-02-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • Configurations/FeatureDefines.xcconfig:

2010-02-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

I made ENABLE(SANDBOX) only control the sandbox attribute itself;
I did not ifdef the infrastructure to make sandboxing
switchable. This is because the likely concerns about sandboxing
are not stability of the infrastructure code, but rather the fact
that the security model exposed to authors is still evolving.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::parseMappedAttribute):

2010-02-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • configure.ac:

2010-02-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
https://bugs.webkit.org/show_bug.cgi?id=35147

  • Scripts/build-webkit: Handle new flag.
18:08 Changeset [55042] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-02-19 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Shinichiro Hamaji.

[style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/
https://bugs.webkit.org/show_bug.cgi?id=35091

White list unix_hacker_style names in WebKit/efl/ewk because these
are used in the EFL API.

  • Scripts/webkitpy/style/checker.py:
    • Filter out readability/naming on WebKit/efl/ewk.
17:23 Changeset [55041] by ap@apple.com
  • 7 edits in trunk

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=35132
<rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132)

WebCore:

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Don't set mouse pointer when above a plug-in or applet to prevent flicker.

WebKit:

  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::mouseMoved): Send adjustCursor events on every mouse move. This matches Firefox, and is actually required for plug-ins to manipulate cursor wihout resorting to techniques such as fast firing timers.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): Some plug-ins handle mouse cursor internally, but those that don't just need to get an arrow cursor (matching Firefox). This means that e.g. a plugin inside <A> won't get a finger mouse pointer.
  • Plugins/WebHostedNetscapePluginView.mm: (-[WebNetscapePluginView handleMouseEntered:]): (-[WebNetscapePluginView handleMouseExited:]): Implement this behavior here, too. Also, out of process code didn't reset mouse pointer on mouse exit, which it needed to do.
  • WebView/WebHTMLView.mm: (needsCursorRectsSupportAtPoint): (setCursor): (resetCursorRects): Make sure that the same workaround we have for Web content also applies to Netscape plug-ins, as AppKit would reset the mouse pointer to arrow if given a chance. (+[WebHTMLViewPrivate initialize]): Renamed setCursorIMP on Leopard and higher to prevent confusion - the method we override is completely different. (-[WebHTMLView hitTest:]): Added a FIXME about a likely bug.
16:51 Changeset [55040] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-19 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

fast/forms/search-event-delay.html failed on Snow Leopard Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33543

  • platform/mac-snowleopard/Skipped:
    • This test prints times and expects 0.1s precision even on Debug bots. That can't work. Skipping the test to make the bots green until this can be made non-flakey or until we have a layout test system which allows "failure" expectations.
16:45 Changeset [55039] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Fix regression in calculating an animated image's start time.
https://bugs.webkit.org/show_bug.cgi?id=35115

Reviewed by Adam Barth.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startAnimation):

16:44 Changeset [55038] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-19 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

editing/pasteboard/4641033.html timed out on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=33310

  • platform/mac-tiger/Skipped:
16:41 Changeset [55037] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-02-19 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Call WebViewClient::didAcceptAutoFillSuggestion when the
user selects a suggestion from the AutoFill suggestions popup.

https://bugs.webkit.org/show_bug.cgi?id=35174

  • public/WebViewClient.h: (WebKit::WebViewClient::didAcceptAutoFillSuggestion):
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::valueChanged):
  • src/AutoFillPopupMenuClient.h:
15:44 Changeset [55036] by ap@apple.com
  • 13 edits in trunk/WebCore

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=35178
LiveConnect code uses hand-rolled fprintf logging

Changed to use LOG, LOG_ERROR and ASSERT.

  • platform/Logging.cpp: (WebCore::getChannelFromName):
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
  • platform/win/LoggingWin.cpp: (WebCore::InitializeLoggingChannelsIfNecessary): TextConversion channel was (almost) unused, renamed to LiveConnect.
  • platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerEncodingNames): The only use of this channel was in platform specific code, commandeered it for cross-platform needs.
  • bridge/jni/JNIBridge.cpp:
  • bridge/jni/JNIUtility.cpp: (JSC::Bindings::getJavaVM): (JSC::Bindings::getJNIEnv): (JSC::Bindings::getJNIField):
  • bridge/jni/JNIUtility.h: (JSC::Bindings::callJNIMethodV): (JSC::Bindings::callJNIStaticMethod):
  • bridge/jni/jni_jsobject.mm: (completedJavaScriptAccess): (dispatchToJavaScriptThread): (performJavaScriptAccess): (JavaJSObject::invoke): (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember): (JavaJSObject::getSlot): (JavaJSObject::setSlot): (JavaJSObject::toString): (JavaJSObject::createNative):
  • bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bridge/jni/jsc/JavaClassJSC.cpp: (JavaClass::JavaClass):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper): (JObjectWrapper::~JObjectWrapper):
15:36 Changeset [55035] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

JSString::getIndex() calls value() to resolve the string value (is a rope)
to a UString, then passes the result to jsSingleCharacterSubstring without
checking for an exception. In case of out-of-memory the returned UString
is null(), which may result in an out-of-buounds substring being created.
This is bad.

Reviewed by Oliver Hunt.

Simple fix is to be able to get an index from a rope without resolving to
UString. This may be a useful optimization in some test cases.

The same bug exists in some other methods is JSString, these can be fixed
by changing them to call getIndex().

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):

  • runtime/UStringImpl.cpp:

(JSC::singleCharacterSubstring):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::singleCharacterSubstring):

15:07 Changeset [55034] by eric@webkit.org
  • 5 edits
    1 move in trunk/WebKitTools

2010-02-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split out "prepare-rollout" from "rollout" and make --complete-rollout default
https://bugs.webkit.org/show_bug.cgi?id=33745

  • Scripts/webkitpy/commands/download.py:
    • Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout
    • Add PrepareRollout
  • Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests.
  • Scripts/webkitpy/steps/init.py: include ReopenBugAfterRollout step.
  • Scripts/webkitpy/steps/completerollout.py: Removed.
  • Scripts/webkitpy/steps/options.py: remove complete_rollout
  • Scripts/webkitpy/steps/reopenbugafterrollout.py: Added.
15:06 Changeset [55033] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-02-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

RenderSVGResourceMasker causes an Assert on Wind builds during DRT
https://bugs.webkit.org/show_bug.cgi?id=35182

We remove the Assert for now and return earlier, if the HashMap of the Masker
does not contain the RenderObject. The RenderObject is an identifiert to get
a already calculated mask.
A race condition during parsing can cause the invalidation call, before the mask
got calculated (only during DRT on Win build bots).
The real bug will be fixed with: https://bugs.webkit.org/show_bug.cgi?id=35181

  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClient):
14:50 Changeset [55032] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-02-19 James Hawkins <jhawkins@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Use the m_suggestionsPopupClient pointer to refer to the
popup client, as the Autocomplete popup might not be the current
popup.

https://bugs.webkit.org/show_bug.cgi?id=35172

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::refreshSuggestionsPopup):
14:34 Changeset [55031] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-02-19 James Hawkins <jhawkins@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to
onAutocompleteSuggestionAccepted to better match the purpose of the
function.

https://bugs.webkit.org/show_bug.cgi?id=35171

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted):
  • src/EditorClientImpl.h:
  • src/SuggestionsPopupMenuClient.cpp: (WebKit::SuggestionsPopupMenuClient::valueChanged):
14:10 Changeset [55030] by simon.fraser@apple.com
  • 5 edits in trunk/WebKit/mac

2010-02-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article

Followup to avoid capturing compositing layers twice in snapshots. Add private
methods to WebView to specify whether drawing the WebView into an image will
include flattened compositing layers (the default behavior) or not.

  • WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]): Consult the WebView flag to see if we want flattening.
  • WebView/WebViewPrivate.h: New methods.
  • WebView/WebView.mm: Ditto. (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]):
  • WebView/WebViewData.h: New member variable.
13:44 Changeset [55029] by pkasting@chromium.org
  • 11 edits in trunk

WebCore: Make Pasteboard::writeImage() safe against NULL cachedImages, and clean
up some code.
https://bugs.webkit.org/show_bug.cgi?id=35136

Reviewed by Darin Fisher.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateRenderer): Shorten some code.

  • page/DragController.cpp:

(WebCore::getImage): Shorten some code.

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage): NULL-check cachedImage().

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeImage): NULL-check cachedImage().

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeImage): NULL-check cachedImage().

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeImage): NULL-check cachedImage().

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeImage): NULL-check cachedImage().

WebKit/chromium: Add an isImageBlocked bool to the WebContextMenuData struct.
https://bugs.webkit.org/show_bug.cgi?id=35136

Reviewed by Darin Fisher.

This lets us properly enable/disable the "Copy Image" context menu entry
(and, in the future, maybe add a "Load Image" function).

  • public/WebContextMenuData.h:
  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

13:30 Changeset [55028] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Rubberstamped by Noam Rosenthal, who wrote the original code.

Make mouse wheel scrolling work when using the GraphicsLayer.

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):

13:08 Changeset [55027] by oliver@apple.com
  • 7 edits
    1 add in trunk/JavaScriptCore

2010-02-19 Oliver Hunt <oliver@apple.com>

RS = Gavin Barraclough.

Split the 32/64 version of JITPropertyAccess into a separate file.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp: Added. (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::emit_op_get_by_pname): (JSC::JIT::emitSlow_op_get_by_pname):
12:30 Changeset [55026] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json

2010-02-19 William Siegrist <wsiegrist@apple.com>

Add GTK Linux 64-bit Release bot. Rename GTK Linux Release to GTK Linux 32-bit Release.

11:47 Changeset [55025] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-02-19 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Need a final integration between QtLauncher and QGVLauncher
https://bugs.webkit.org/show_bug.cgi?id=35161

Add animated flip support to QtLauncher when running on QGraphicsView mode.

  • QtLauncher/main.cpp: (LauncherWindow::initializeView): (LauncherWindow::setupUI):
  • QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::animatedFlip): (WebViewGraphicsBased::animatedYFlip):
  • QtLauncher/webview.h: (WebViewGraphicsBased::setYRotation): (WebViewGraphicsBased::yRotation):
11:30 Changeset [55024] by eric@webkit.org
  • 2 edits
    1 move in trunk/JavaScriptCore

2010-02-19 Patrick Gansterer <paroga@paroga.com>

Reviewed by Laszlo Gombos.

Added additional parameter to create_rvct_stubs
for setting the regularexpression prefix.
Renamed it because it now works for other platforms too.
https://bugs.webkit.org/show_bug.cgi?id=34951

  • DerivedSources.pro:
  • create_jit_stubs: Copied from JavaScriptCore/create_rvct_stubs.
  • create_rvct_stubs: Removed.
11:22 Changeset [55023] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2010-02-19 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix Worker crash regression in r54972

https://bugs.webkit.org/show_bug.cgi?id=35166

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object): Properly unwrap global objects when inside a WorkerContext.
11:09 Changeset [55022] by steveblock@google.com
  • 3 edits in trunk/WebCore

Not reviewed. Reverts r55020 which causes crashes in Chromium LayoutTests

10:59 Changeset [55021] by ap@apple.com
  • 5 edits in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=35165
plugins/set-status.html fails on Windows bot

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::status):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView status:]): Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as empty ones to chrome.
09:13 Changeset [55020] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-19 Steve Block <steveblock@google.com>

Reviewed by David Levin.

Sets default values of V8 runtime enabler flags to match behavior with JSC
https://bugs.webkit.org/show_bug.cgi?id=35095

No new tests, modifies a Chromium feature only.

  • bindings/generic/RuntimeEnabledFeatures.cpp: Modified. Sets appcache and geolocation flag defaults to 'on'
  • storage/Database.cpp: Modified. Sets database flag default to 'on'.
09:13 Changeset [55019] by abecsi@webkit.org
  • 5 edits
    20 adds in trunk

[Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
for passing new tests and unskip the passing ones from the Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=35159

Reviewed by Kenneth Rohde Christiansen.

WebKitTools:

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::textZoomIn):
(EventSender::textZoomOut):

  • DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

  • platform/qt/Skipped: unskip passing tests
  • platform/qt/svg/custom/text-zoom-expected.txt: Added.
  • platform/qt/svg/zoom: Added.
  • platform/qt/svg/zoom/page: Added.
  • platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/qt/svg/zoom/text: Added.
  • platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
08:57 Changeset [55018] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-02-19 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Fixes GeolocationServiceBridgeImpl::stopUpdating (it can be called multiple times).

  • src/GeolocationServiceBridgeChromium.cpp: (WebKit::GeolocationServiceBridgeImpl::stopUpdating):
08:50 Changeset [55017] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-19 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Gustavo Noronha Silva.

[GTK] fast/forms/restore-selection-after-layout.html fails on 32bits Debug build
https://bugs.webkit.org/show_bug.cgi?id=35158

  • platform/gtk/Skipped: Skip failing test
07:16 Changeset [55016] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2010-02-19 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Elements panel: Correctly show empty elements' ending tags
for XML and HTML documents.
https://bugs.webkit.org/show_bug.cgi?id=26315

  • inspector/console-dirxml-expected.txt:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-expected.txt:
  • inspector/elements-panel-limited-children-expected.txt:
  • inspector/elements-panel-structure-expected.txt: Re-baselined due to closing tags and ellipses between opening and closing tags
  • inspector/elements-panel-xhtml-structure-expected.txt: Added.
  • inspector/elements-panel-xhtml-structure.xhtml: Added.

2010-02-19 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Elements panel: Correctly show empty elements' ending tags
for XML and HTML documents.
https://bugs.webkit.org/show_bug.cgi?id=26315

Test: inspector/elements-panel-xhtml-structure.xhtml

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode): (WebInspector.ElementsTreeOutline.prototype.get isXMLMimeType): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired): (WebInspector.ElementsTreeElement.prototype.onexpand): (WebInspector.ElementsTreeElement.prototype.oncollapse): (WebInspector.ElementsTreeElement.prototype.updateTitle.callback): (WebInspector.ElementsTreeElement.prototype.updateTitle): (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
06:52 Changeset [55015] by abecsi@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed Changelog typo fix.

r5993 should be r54993.

06:45 Changeset [55014] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] plugins/set-status.html introduced in r5993 fails skipping it until fix.
https://bugs.webkit.org/show_bug.cgi?id=35144

  • platform/qt/Skipped:
06:34 Changeset [55013] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-02-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=35004

DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up
and enables all HTML5 persistent data. All the other calls for setting the
persistent path or enabling the persistent feature are redundant.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): No need to enable AppCache again.
  • DumpRenderTree/qt/main.cpp: (main): No need to setup and enable HTML5 LocalStorage again.
05:13 Changeset [55012] by eric@webkit.org
  • 5 edits in trunk

2010-02-19 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Send the context menu event from contextClick() of EventSender
and do not show context menu in DRT.

LayoutTests:

fast/events/contextmenu-scrolled-page-with-frame.html

[Qt] DRT: Send context menu event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35131

  • platform/qt/Skipped:

2010-02-19 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Send the context menu event from contextClick() of EventSender
and do not show context menu in DRT.

LayoutTests:

fast/events/contextmenu-scrolled-page-with-frame.html

[Qt] DRT: Send context menu event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35131

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick):
05:01 Changeset [55011] by pfeldman@chromium.org
  • 5 edits in trunk

2010-02-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium build fix: reverting r54997 and r54998.
This is a two-sided change that should be coordinated.

  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::protocolAccessorSetter):
  • platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): (WebCore::KURL::isHierarchical):
04:41 Changeset [55010] by ossy@webkit.org
  • 2 edits
    2 copies in trunk/LayoutTests

[Qt] editing tests fails after r54980
https://bugs.webkit.org/show_bug.cgi?id=35145

Reviewed by Kenneth Rohde Christiansen.

After r54980 two tests fail, skip them until fix.
Another two tests pass, they have same results as Win port.

  • platform/qt/Skipped:
    • editing/selection/extend-selection.html skipped.
    • editing/selection/extend-after-mouse-selection.html skipped.
  • platform/qt/editing/selection/click-in-margins-inside-editable-div-expected.txt: Copied from LayoutTests/platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt.
  • platform/qt/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Copied from LayoutTests/platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt.
04:40 Changeset [55009] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-02-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium tests fix: update devtools code to match new
web inspector object proxy format.

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.formatCallFrame_): (devtools.DebuggerAgent.formatObjectProxy_):
04:06 Changeset [55008] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-19 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

[GTK] plugins/set-status.html fails
https://bugs.webkit.org/show_bug.cgi?id=35144

  • platform/gtk/Skipped: Skip failing test.
01:18 Changeset [55007] by philn@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-02-19 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

Adding a GTK layout test result for a new test
added in r54980.

  • platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt: Added.
01:18 Changeset [55006] by philn@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-02-19 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

Adding a GTK layout test result for a new test
added in r54982.

  • platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
00:30 Changeset [55005] by philn@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-02-17 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GTK] RTP/RTSP streams playback support
https://bugs.webkit.org/show_bug.cgi?id=33662

Added live pipelines support in updateStates().

  • manual-tests/video-rtsp.html: Added.
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::updateStates):

02/18/10:

23:49 Changeset [55004] by mjs@apple.com
  • 10 edits in branches/safari-532-branch

mark-radar-fixed
<rdar://problem/7540469> Disable ruby support for the branch

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools:

  • Scripts/build-webkit:
23:32 Changeset [55003] by ossy@webkit.org
  • 6 edits in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] Update platform specific expected files after r54991.

  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: updated.
  • platform/qt/svg/css/mask-with-shadow-expected.txt: updated.
  • platform/qt/svg/custom/empty-mask-expected.txt: updated.
  • platform/qt/svg/custom/mask-with-default-value-expected.txt: updated.
  • platform/qt/svg/custom/transformedMaskFails-expected.txt: updated.
22:23 Changeset [55002] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

2010-02-18 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Improve interpreter getter performance
https://bugs.webkit.org/show_bug.cgi?id=35138

Improve the performance of getter dispatch by making it possible
for the interpreter to cache the GetterSetter object lookup.

To do this we simply need to make PropertySlot aware of getters
as a potentially cacheable property, and record the base and this
objects for a getter access. This allows us to use more-or-less
identical code to that used by the normal get_by_id caching, with
the dispatch being the only actual difference.

I'm holding off of implementing this in the JIT until I do some
cleanup to try and making coding in the JIT not be as horrible
as it is currently.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • runtime/JSObject.cpp: (JSC::JSObject::fillGetterPropertySlot):
  • runtime/PropertySlot.cpp: (JSC::PropertySlot::functionGetter):
  • runtime/PropertySlot.h: (JSC::PropertySlot::isGetter): (JSC::PropertySlot::isCacheable): (JSC::PropertySlot::isCacheableValue): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot): (JSC::PropertySlot::clearOffset): (JSC::PropertySlot::thisValue):
21:17 Changeset [55001] by eric@webkit.org
  • 5 edits
    2 adds in trunk/WebKitTools

2010-02-18 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Moved parsing-related code to a separate file. Also increased
the unit test coverage in some affected areas.

https://bugs.webkit.org/show_bug.cgi?id=34675

This revision contains no new functionality.

  • Scripts/check-webkit-style:
    • Adjusted to call check_webkit_style_parser().
  • Scripts/webkitpy/style/checker.py:
    • Added check_webkit_style_parser() to pass checker.py configuration settings to optparser.py.
    • Moved _create_usage() and the CommandOptionValues, DefaultCommandOptionValues, ArgumentPrinter, and ArgumentParser classes to optparser.py.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Moved the ProcessorOptionsTest, ArgumentPrinterTest, and ArgumentParserTest classes to optparser.py.
    • Added the CheckWebKitStyleFunctionTest class to check the check_webkit_style_configuration() and check_webkit_style_parser() code paths.
  • Scripts/webkitpy/style/optparser.py: Added.
    • From checker.py, added _create_usage() and the CommandOptionValues, DefaultCommandOptionValues, ArgumentPrinter, and ArgumentParser classes.
    • In the ArgumentParser constructor--
      • Added all_categories as a required parameter.
      • Removed the default value from the default_options parameter.
  • Scripts/webkitpy/style/optparser_unittest.py: Added.
    • From checker_unittest.py, added the ProcessorOptionsTest, ArgumentPrinterTest, and ArgumentParserTest classes.
    • Added the CreateUsageTest class to test _create_usage().
  • Scripts/webkitpy/style/unittests.py:
    • Added optparser_unittest import.
21:14 Changeset [55000] by mjs@apple.com
  • 2 edits in branches/safari-532-branch/WebKitLibraries
  • Add change I missed in the last commit.


  • win/tools/vsprops/FeatureDefines.vsprops:
21:00 Changeset [54999] by eric@webkit.org
  • 14 edits
    3 adds in trunk

2010-02-18 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Adler.

Normalize custom ctors for Image, Option, Audio
https://bugs.webkit.org/show_bug.cgi?id=34782

  • fast/js/custom-constructors-expected.txt: Added.
  • fast/js/custom-constructors.html: Added.
  • fast/js/script-tests/custom-constructors.js: Added.

2010-02-18 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Adler.

Normalize custom ctors for Image, Option, Audio
https://bugs.webkit.org/show_bug.cgi?id=34782

Test: fast/js/custom-constructors.html

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): (WebCore::constructAudio):
  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::v8HTMLAudioElementConstructorCallback):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::v8HTMLImageElementConstructorCallback):
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::v8HTMLOptionElementConstructorCallback):
  • html/HTMLAudioElement.cpp: (WebCore::HTMLAudioElement::HTMLAudioElement): (WebCore::HTMLAudioElement::createForJSConstructor):
  • html/HTMLAudioElement.h:
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::createForJSConstructor): (WebCore::HTMLImageElement::mapToEntry): (WebCore::HTMLImageElement::createRenderer): (WebCore::HTMLImageElement::attach): (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height): (WebCore::HTMLImageElement::naturalHeight):
  • html/HTMLImageElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::createForJSConstructor): (WebCore::HTMLOptionElement::ownerSelectElement): (WebCore::HTMLOptionElement::nonRendererRenderStyle): (WebCore::HTMLOptionElement::disabled): (WebCore::HTMLOptionElement::insertedIntoTree):
  • html/HTMLOptionElement.h:
20:29 Changeset [54998] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-02-12 Kent Tamura <tkent@chromium.org>

Unreviewed. Fix Chromium build.

  • DEPS: Bump Google URL revision to 123.
18:06 Changeset [54997] by brettw@chromium.org
  • 3 edits in trunk/WebCore

2010-02-12 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth.

Update the Google-URL version of KURL and the V8 bindings to the new
behavior of KURL.IsStandard.

https://bugs.webkit.org/show_bug.cgi?id=34859

This is covered by fast/dom/Window/invalid-protocol.html

  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::protocolAccessorSetter):
  • platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): (WebCore::KURL::isHierarchical):
17:21 Changeset [54996] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=35134
<rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testSetStatus): (pluginInvoke): Added a setStatus() method.
16:47 Changeset [54995] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-02-18 Simon Fraser <simon.fraser@apple.com>

No Review.

Remove a couple of extraneous spaces that got added to the project file
by hand-ending.

  • WebCore.xcodeproj/project.pbxproj:
16:44 Changeset [54994] by simon.fraser@apple.com
  • 8 edits in trunk

2010-02-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article

Add logic to determine when painting via the software rendering path will give an equivalent
result to the accelerated compositing presentation. This tests for the presence of 3D transforms
via the existing RenderLayerCompositor::has3DContent() method.

  • WebCore.base.exp: Export FrameView's isSoftwareRenderable(), paintBehavior() and setPaintBehavior().
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::isSoftwareRenderable): New method. (WebCore::FrameView::paintBehavior): Make this non-inline so that we can reliably export it.
16:37 Changeset [54993] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=35134
<rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)

Test: plugins/set-status.html

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::status): (WebKit::NetscapePluginInstanceProxy::loadURL): Added null checks for CFStringCreateWithCString arguments.
16:19 Changeset [54992] by mitz@apple.com
  • 5 edits
    2 adds in trunk

<rdar://problem/7658811> Multiple style recalcs due to getComputedStyle() on “display: none;” element
when there are pending style sheets

Reviewed by John Sullivan.

WebCore:

Test: fast/css/getComputedStyle/pending-stylesheet.html

When querying a property of a computed style declaration for a non-rendered element,
CSSStyleSelector::styleForElement() was called, and if there were pending style sheet, it
would behave as if the lack of renderer is due to FOUC suppression, and set a flag on
the document causing it to recalculate style. On the next computed style property access,
style would be recalculated for the document, but then the flag would get set again if the
element did not have a renderer.

  • dom/Document.cpp:

(WebCore::Document::styleForElementIgnoringPendingStylesheets): Added. Temporarily sets
m_ignorePendingStylesheets around the call to CSSStyleSelector::styleForElement().

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::computedStyle): Use Document::styleForElementIgnoringPendingStylesheets().

LayoutTests:

  • fast/css/getComputedStyle/pending-stylesheet-expected.txt: Added.
  • fast/css/getComputedStyle/pending-stylesheet.html: Added.
15:12 Changeset [54991] by krit@webkit.org
  • 52 edits
    3 adds
    2 deletes in trunk

2010-02-18 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Move SVGResources to Renderers, starting with Masker
https://bugs.webkit.org/show_bug.cgi?id=35020

We have rendering specific code in WebCore/svg/graphics. The goal is to move
this code into suitable Renderers. This helps us to clean up the code and makes
maintenance easier. It also makes it possible to remove rendering specific code
from SVG*Elements into this renderers. So the Renderer contains everything that
is needed to use the resource.
RenderSVGResource will be the base class for all new resource render classes like
RenderSVGResourceMasker, RenderSVGResourceClipper and the other resources.

This patch starts moving SVGResourceMasker to RenderSVGResourceMasker.
Another benefit is the much more useful result in DRT on using masker.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::toRenderSVGResource): Conversion to RenderSVGResource base class.
  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGResource): Check if renderer is a resource.
  • rendering/RenderPath.cpp:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::destroy): Renderer gets destroyed, unregister it from it's resources.
  • rendering/RenderSVGImage.h: Some code clean up according to the webkit style. (WebCore::RenderSVGImage::toSVGRenderBase): (WebCore::RenderSVGImage::renderName): (WebCore::RenderSVGImage::isSVGImage): (WebCore::RenderSVGImage::localToParentTransform): (WebCore::RenderSVGImage::strokeBoundingBox): (WebCore::RenderSVGImage::requiresLayer): (WebCore::RenderSVGImage::localTransform):
  • rendering/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::objectBoundingBox): Needed for SVGRenderTreeAsText
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::destroy): Renderer gets destroyed, unregister it from it's resources.
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGResource.h: Added. (WebCore::): Base class for all Resource renderers like masker, clipper and others. (WebCore::RenderSVGResource::RenderSVGResource): (WebCore::RenderSVGResource::cast): (WebCore::RenderSVGResource::toRenderSVGResource): (WebCore::RenderSVGResource::isSVGResource): (WebCore::RenderSVGResource::drawsContents): (WebCore::getRenderSVGResourceById):
  • rendering/RenderSVGResourceMasker.cpp: Added. (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker): (WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker): (WebCore::RenderSVGResourceMasker::invalidateClients): Status of masker changed, remove all clients. (WebCore::RenderSVGResourceMasker::invalidateClient): Status of an object changed, remove pending client. (WebCore::RenderSVGResourceMasker::applyResource): Apply masker to object. (WebCore::RenderSVGResourceMasker::resourceBoundingBox): boundingBox of the resource, depending on the object. (WebCore::RenderSVGResourceMasker::createMaskImage): Creates the mask image, the context gets clipped with.
  • rendering/RenderSVGResourceMasker.h: Added. (WebCore::MaskerData::MaskerData): (WebCore::RenderSVGResourceMasker::renderName): (WebCore::RenderSVGResourceMasker::maskUnits): Unit of mask for DRT. (WebCore::RenderSVGResourceMasker::maskContentUnits): Unit of childs from mask for DRT. (WebCore::RenderSVGResourceMasker::resourceType):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::destroy): Renderer gets destroyed, unregister it from it's resources.
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::destroy): dito.
  • rendering/RenderSVGText.h:
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer): (WebCore::SVGRenderBase::deregisterFromResources): Unregister object from all it's resources after status changed.
  • rendering/SVGRenderSupport.h: (WebCore::SVGRenderBase::toSVGRenderBase): (WebCore::SVGRenderBase::strokeBoundingBox): (WebCore::SVGRenderBase::markerBoundingBox):
  • rendering/SVGRenderTreeAsText.cpp: Update TreeAsText to dump maskers correctly. (WebCore::operator<<): (WebCore::writeSVGResource): (WebCore::writeSVGContainer): (WebCore::writeSVGText): (WebCore::writeSVGInlineText): (WebCore::writeSVGImage): (WebCore::write): (WebCore::writeResourcesToObject):
  • rendering/SVGRenderTreeAsText.h:
  • svg/SVGMaskElement.cpp: Update Masker to use the new renderer. (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): (WebCore::SVGMaskElement::maskBoundingBox): (WebCore::SVGMaskElement::createRenderer):
  • svg/SVGMaskElement.h:
  • svg/SVGStyledElement.cpp: We need to tell the renderer to unregister object, after the status changed. (WebCore::SVGStyledElement::invalidateResources): (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
  • svg/SVGUnitTypes.h: Conversion of integer to SVGUnitType. (WebCore::toUnitType):
  • svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isMarker):
  • svg/graphics/SVGResourceMasker.cpp: Removed.
  • svg/graphics/SVGResourceMasker.h: Removed.

2010-02-18 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Move SVGResources to Renderers, starting with Masker
https://bugs.webkit.org/show_bug.cgi?id=35020

With the move from SVGResourceMasker to RenderSVGResourceMasker, I changed
the way DRT dumps resources. DRT is now able to dump multi-access
of resources.
Also the size of a Mask resource (depending of the object) and the access of
the resource (togeter with the resource name) is pointed out as an insertion
under the object.

  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/mac/svg/css/mask-with-shadow-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
  • platform/mac/svg/custom/js-late-mask-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-mask-creation-expected.txt:
  • platform/mac/svg/custom/mask-changes-expected.txt:
  • platform/mac/svg/custom/mask-child-changes-expected.txt:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
  • platform/mac/svg/custom/mask-inside-defs-expected.txt:
  • platform/mac/svg/custom/mask-invalidation-expected.txt:
  • platform/mac/svg/custom/mask-on-multiple-objects-expected.txt:
  • platform/mac/svg/custom/mask-with-all-units-expected.txt:
  • platform/mac/svg/custom/mask-with-default-value-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/visibility-override-mask-expected.txt:
  • platform/mac/svg/filters/filter-clip-expected.txt:
  • svg/custom/transformedMaskFails-expected.txt:
14:51 Changeset [54990] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Allow creating/dropping virtual tables when the module is FTS2.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=34867

  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::createVTable):
(WebCore::DatabaseAuthorizer::dropVTable):

14:40 Changeset [54989] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed, Chromium build fix.

r54963 had a typo in the WebCore.gypi change.
https://bugs.webkit.org/show_bug.cgi?id=35003

  • WebCore.gypi:
14:15 Changeset [54988] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed a portion of:
<rdar://problem/7165917> | https://bugs.webkit.org/show_bug.cgi?id=28676
Safari 4 does not release memory back to the operating system fast enough (28676)

Reviewed by Oliver Hunt.

This patch fixes a surprisingly common edge case in which the page heap
would have only one free span, but that span would be larger than the
minimum free size, so we would decide not to free it, even though it
could be as large as 100MB or more!

SunSpider reports no change on Mac or Windows.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::scavenge): Call shouldContinueScavenging() instead
of doing the math ourselves. Don't keep a local value for pagesDecommitted
because that lets free_committed_pages_ be wrong temporarily. Instead,
update free_committed_pages_ as we go. ASSERT that we aren't releasing
a span that has already been released, because we think this is impossible.
Finally, don't be afraid to release all free memory in the page heap when
scavenging. We only scavenge after 5 seconds of the application's working
set not growing, and we keep both thread caches and a central cache on
top of the page heap, so the extra free pages in the page heap were just
overkill.

14:08 Changeset [54987] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-18 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Simon Fraser.

Changing forward declaration of TimingFunction in GraphicsLayer.h from
class to struct to match its actual definition in TimingFunction.h

https://bugs.webkit.org/show_bug.cgi?id=35069

  • platform/graphics/GraphicsLayer.h:

Change forward declaration from: class TimingFunction to:
struct TimingFunction

13:50 Changeset [54986] by eric@webkit.org
  • 4 edits in trunk

2010-02-18 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Minor improvement to hybrid QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34507
Instead of having toHTMLImageElement which creates a new element,
assignToHTMLImageElement would set an existing HTML <img/> element to
contain the native QPixmap/QImge.
Also made some style fixes.

Additions to existing tests: see WebKit/qt/tests

  • bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapWidthField::valueFromInstance): style (JSC::Bindings::QtPixmapHeightField::valueFromInstance): style (JSC::Bindings::QtPixmapAssignToElementMethod::name): assignTo (JSC::Bindings::QtPixmapAssignToElementMethod::invoke): new function (JSC::Bindings::QtPixmapAssignToElementMethod::numParameters): 1 (JSC::Bindings::QtPixmapToDataUrlMethod::invoke): style (JSC::Bindings::QtPixmapToStringMethod::invoke): style (JSC::Bindings::QtPixmapInstance::invokeMethod): style (JSC::Bindings::QtPixmapClass::methodsNamed): new func, removed old (JSC::Bindings::QtPixmapInstance::getPropertyNames): ditto (JSC::Bindings::QtPixmapInstance::defaultValue): style (JSC::Bindings::QtPixmapInstance::valueOf): style (JSC::Bindings::QtPixmapInstance::toPixmap): style (JSC::Bindings::QtPixmapInstance::variantFromObject): style

2010-02-18 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Minor improvement to hybrid QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34507

  • tests/hybridPixmap/test.html: use assignToHTMLImageElement on an existing element instead of toHTMLImageElement which creates a new one
13:15 Changeset [54985] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-18 Gustavo Noronha Silva <gns@gnome.org>

[Qt][GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
https://bugs.webkit.org/show_bug.cgi?id=35086

Skip both new tests that fail. It may be a DRT problem, and the
file path that is reported in the error message also seems to
require tweaking.

  • platform/gtk/Skipped:
13:07 Changeset [54984] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed, bustage fix.

An extraneous line in r54839 broke GIF animation.

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::read):

13:03 Changeset [54983] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-18 Gustavo Noronha Silva <gns@gnome.org>

[GTK] Fails fast/multicol/client-rects.html
https://bugs.webkit.org/show_bug.cgi?id=35127

Skip test that fails in GTK+ - trying to get bot green again.

  • platform/gtk/Skipped:
12:55 Changeset [54982] by mitz@apple.com
  • 3 edits
    1 copy
    3 adds in trunk

<rdar://problem/7650652> REGRESSION: Selection painting issue in bug review textbox
https://bugs.webkit.org/show_bug.cgi?id=34946

Reviewed by Simon Fraser.

WebCore:

Test: fast/repaint/selection-gap-overflow-scroll-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintSelection): localToContainerQuad() adjusts for
overflow scroll, but RenderLayer::addBlockSelectionGapsBounds() takes
non-scrolled coordinates, so account for that.

LayoutTests:

  • fast/repaint/selection-gap-overflow-scroll-2.html: Copied from LayoutTests/fast/repaint/selection-gap-overflow-scroll.html.
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum: Added.
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
12:52 Changeset [54981] by dumi@chromium.org
  • 10 edits in trunk

WebCore: Change the V8 and JSC SQLStatementErrorCallback to interpret
'undefined' return values as 'true', as required by the spec.

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=35048

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallbackHelper):
(WebCore::invokeCallback):
(WebCore::invokeCallbackTreatUndefinedAsTrue):

  • bindings/v8/custom/V8CustomVoidCallback.h:

LayoutTests: 'undefined' return values from statement error callbacks are not
treated as 'true'. Fix the tests that did not use this
assumption.

Reviewed by NOBODY Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=35048

  • storage/database-lock-after-reload.html:
  • storage/private-browsing-readonly.html:
  • storage/statement-error-callback.html:
  • storage/statement-error-callback-expected.txt:
11:38 Changeset [54980] by ojan@chromium.org
  • 12 edits
    4 adds in trunk

2010-02-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

keyboard selection sometimes moves the wrong end of the selection for Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=35066

The changes to js-test-selection-shared.js are just to make the selection editing tests
easier to debug in the future.

The mac results for extend-after-mouse-selection.html contain a "FAIL" line. This is
a case where WebKit doesn't match TextEdit.

  • editing/editing.js: (execMoveSelectionForwardByLineBoundaryCommand): (moveSelectionForwardByLineBoundaryCommand): (execExtendSelectionForwardByLineBoundaryCommand): (extendSelectionForwardByLineBoundaryCommand): (execExtendSelectionBackwardByLineBoundaryCommand): (extendSelectionBackwardByLineBoundaryCommand): (execMoveSelectionBackwardByLineBoundaryCommand): (moveSelectionBackwardByLineBoundaryCommand):
  • editing/selection/extend-after-mouse-selection.html: Added.
  • editing/selection/move-begin-end-expected.txt:
  • editing/selection/move-begin-end.html:
  • editing/selection/resources/js-test-selection-shared.js: (objectAsString): (assertSelectionAt):
  • platform/mac/editing/selection/click-in-margins-inside-editable-div-expected.txt:
  • platform/mac/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
  • platform/mac/editing/selection/extend-after-mouse-selection-expected.txt: Added.
  • platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt:
  • platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
  • platform/win/editing/selection/extend-after-mouse-selection-expected.txt: Added.
  • platform/win/editing/selection/extend-selection-expected.txt: Added.

2010-02-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

keyboard selection sometimes moves the wrong end of the selection for Win/Linux
https://bugs.webkit.org/show_bug.cgi?id=35066

On Windows/Linux keyboard based selections should always move the same
end of the seleciton. On Mac, lineboundary and documentboundary changes
move different ends of the selection depending on which direction your
extending.

Test: editing/selection/extend-after-mouse-selection.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::positionForPlatform): (WebCore::SelectionController::startForPlatform): (WebCore::SelectionController::endForPlatform): (WebCore::SelectionController::modifyExtendingRight): (WebCore::SelectionController::modifyExtendingForward): (WebCore::SelectionController::modifyMovingForward): (WebCore::SelectionController::modifyExtendingBackward): (WebCore::SelectionController::modifyMovingBackward):
  • editing/SelectionController.h:
11:36 Changeset [54979] by timothy@apple.com
  • 3 edits in trunk/WebCore

Add "with" to the list of keywords to syntax highlight.

http://webkit.org/b/35123

Reviewed by Pavel Feldman.

  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer): Add "width" to _keywords.

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:

(WebInspector.SourceJavaScriptTokenizer): Ditto.

11:35 Changeset [54978] by pkasting@chromium.org
  • 7 edits in trunk/WebCore

Rework PNG-in-ICO decoding to copy the decoded framebuffer into the ICO
decoder, making the logic less crazy and more like the other decoders.
https://bugs.webkit.org/show_bug.cgi?id=28751

Reviewed by Adam Barth.

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::RGBA32Buffer::operator=):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::RGBA32Buffer::RGBA32Buffer):

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::frameBufferAtIndex):
(WebCore::ICOImageDecoder::decodeAtIndex):

  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/qt/RGBA32BufferQt.cpp:

(WebCore::RGBA32Buffer::operator=):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::RGBA32Buffer::operator=):

11:19 CommitQueue edited by eric@webkit.org
(diff)
11:19 CommitQueue edited by eric@webkit.org
(diff)
11:14 CommitQueue edited by eric@webkit.org
(diff)
11:13 CommitQueue edited by eric@webkit.org
(diff)
11:11 CommitQueue edited by eric@webkit.org
(diff)
11:10 CommitQueue edited by eric@webkit.org
(diff)
11:08 Changeset [54977] by japhet@chromium.org
  • 3 edits in trunk/LayoutTests

2010-02-18 Nate Chapin <japhet@chromium.org>

Unreviewed, build fix.

Provide good expected results for fast/dom/Window/window-event-override-no-crash.html.

11:05 Changeset [54976] by sfalken@apple.com
  • 1 edit in trunk/WebKitLibraries/win/lib/WebKitSystemInterface_debug.lib

Windows build fix.

10:59 Changeset [54975] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-18 Gustavo Noronha Silva <gns@gnome.org>

[GTK][Qt] Fails glyph reordering test fast/text/glyph-reordering.html
https://bugs.webkit.org/show_bug.cgi?id=34918

Unskipping that now passes, after r54912.

  • platform/gtk/Skipped:
10:53 Changeset [54974] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-02-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: multiple popovers on screen at the same time.

https://bugs.webkit.org/show_bug.cgi?id=35105

  • inspector/front-end/Popover.js: (WebInspector.Popover.prototype.show): (WebInspector.Popover.prototype.hide):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup):
10:45 Changeset [54973] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-02-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Expand Object.proto properly.

https://bugs.webkit.org/show_bug.cgi?id=35113

  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback):
  • inspector/front-end/inspector.js: (WebInspector.log.logMessage): (WebInspector.log):
10:40 Changeset [54972] by japhet@chromium.org
  • 4 edits in trunk/WebCore

2010-02-18 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

[V8] Merge the DOMWindow and WorkerContext object wrapping code paths,
and use a faster method of disambiguating between the types of contexts.

https://bugs.webkit.org/show_bug.cgi?id=35009

  • bindings/scripts/CodeGeneratorV8.pm: Remove logic determining whether we need to

handle the WorkerContext case.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::globalObjectPrototypeIsDOMWindow): (WebCore::V8DOMWrapper::instantiateV8Object): Merge instantiateV8Object paths.
  • bindings/v8/V8DOMWrapper.h:
10:25 Changeset [54971] by xan@webkit.org
  • 3 edits in trunk/WebCore

2010-02-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Remove some duplication between PluginView and Widget methods, and
move the setSelfVisible calls to the parent class.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::show): (WebCore::Widget::hide):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide):
09:51 Changeset [54970] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2010-02-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

<rdar://problem/7655195> Switch Leopard back to using CGShading to avoid CGGradient leaks

Define USE_CG_SHADING on for Tiger and Leopard, and use it to toggle the methods
used for Core Graphics gradient drawing.

  • platform/graphics/Gradient.h:
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformDestroy): (WebCore::Gradient::paint):
09:36 Changeset [54969] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-02-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: on-hover evaluation renders nodes and arrays as strings.

https://bugs.webkit.org/show_bug.cgi?id=35103

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
09:32 Changeset [54968] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-02-18 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Don't truncate long lines when evaluating expressions on a breakpoint.

https://bugs.webkit.org/show_bug.cgi?id=35102

  • src/js/DebuggerAgent.js:
09:31 Changeset [54967] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-02-18 A S Alam <amanpreet.alam@gmail.com>

Punjabi translation.

  • pa.po: Added.
09:13 Changeset [54966] by beidson@apple.com
  • 13 edits
    2 adds in trunk

Particularly constructed WebFrames can try to access a null HistoryItem
<rdar://problem/7638892> and https://bugs.webkit.org/show_bug.cgi?id=35063

Reviewed by Sam Weinig.

WebCore:

Test: fast/loader/api-test-new-window-data-load-base-url.html

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateBackForwardListForFragmentScroll): We have a known case where a fragment scroll

might take place with a null m_currentItem. updateBackForwardListClippedAtTarget() will either move m_currentItem
to m_previousItem then create a new m_currentItem... or it will do nothing. So we either have both an m_currentItem
and m_previousItem, or we have neither. In the case where we have no m_previousItem, return early.

WebKitTools:

Add the specific ability to test this API pattern.

For now only on Mac, perhaps on the main Windows port later, probably not relevant for other ports.

  • DumpRenderTree/LayoutTestController.cpp:

(apiTestNewWindowDataLoadBaseURLCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(-[APITestDelegate initWithCompletionCondition:]):
(-[APITestDelegate webView:didFailLoadWithError:forFrame:]):
(-[APITestDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
(-[APITestDelegate webView:didFinishLoadForFrame:]):
(LayoutTestController::apiTestNewWindowDataLoadBaseURL): Create a WebView, do a loadData: in its

mainFrame, and synchronously wait for main load completion.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::apiTestNewWindowDataLoadBaseURL):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::apiTestNewWindowDataLoadBaseURL):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::apiTestNewWindowDataLoadBaseURL):

LayoutTests:

  • fast/loader/api-test-new-window-data-load-base-url-expected.txt: Added.
  • fast/loader/api-test-new-window-data-load-base-url.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
09:08 Changeset [54965] by japhet@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-02-18 Nate Chapin <japhet@chromium.org>

Reviewed by Eric Seidel.

Actually submitting test for https://bugs.webkit.org/show_bug.cgi?id=34899 this time.

  • fast/dom/Window/window-event-override-no-crash-expected.txt: Added.
  • fast/dom/Window/window-event-override-no-crash.html: Added.
09:04 Changeset [54964] by japhet@chromium.org
  • 5 edits in trunk

2010-02-18 Nate Chapin <japhet@chromium.org>

Reviewed by Eric Seidel.

[V8] Correctly handle the case where the event field on the
global object is a v8::Object, but not a DOM wrapper.

https://bugs.webkit.org/show_bug.cgi?id=34899

Test: fast/dom/Window/window-event-override-no-crash.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::isValidDOMObject): (WebCore::V8DOMWrapper::isWrapperOfType):
  • bindings/v8/V8DOMWrapper.h:
08:56 Changeset [54963] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-02-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed, Qt build fix.

  • inspector/front-end/WebKit.qrc:
08:12 Changeset [54962] by pfeldman@chromium.org
  • 11 edits
    13 adds
    1 delete in trunk/WebCore

2010-02-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement evaluate-on-hover for scripts panel.

https://bugs.webkit.org/show_bug.cgi?id=35003


  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Images/gearButtonGlyph.png: Added.
  • inspector/front-end/Images/popoverArrows.png: Added.
  • inspector/front-end/Images/popoverBackground.png: Added.
  • inspector/front-end/Images/thumbActiveHoriz.png: Added.
  • inspector/front-end/Images/thumbActiveVert.png: Added.
  • inspector/front-end/Images/thumbHoriz.png: Added.
  • inspector/front-end/Images/thumbHoverHoriz.png: Added.
  • inspector/front-end/Images/thumbHoverVert.png: Added.
  • inspector/front-end/Images/thumbVert.png: Added.
  • inspector/front-end/Images/trackHoriz.png: Added.
  • inspector/front-end/Images/trackVert.png: Added.
  • inspector/front-end/Popup.js: (WebInspector.Popup): (WebInspector.Popup.prototype.show): (WebInspector.Popup.prototype.hide): (WebInspector.Popup.prototype._positionElement):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype._scroll): (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._mouseUp): (WebInspector.SourceFrame.prototype._mouseMove): (WebInspector.SourceFrame.prototype._mouseOut): (WebInspector.SourceFrame.prototype._resetHoverTimer): (WebInspector.SourceFrame.prototype._hidePopup): (WebInspector.SourceFrame.prototype._mouseHover): (WebInspector.SourceFrame.prototype._showPopup.showTextPopup): (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup): (WebInspector.SourceFrame.prototype._showPopup.evaluateCallback): (WebInspector.SourceFrame.prototype._showPopup): (WebInspector.HoverPropertiesSection): (WebInspector.HoverPropertiesSection.prototype.update):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype._lex):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspectorSyntaxHighlight.css:
  • inspector/front-end/popover.css: Added.
08:03 Changeset [54961] by abecsi@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Skip the following tests because of missing eventSender.textZoomIn():

svg/zoom/text/absolute-sized-document-no-scrollbars.svg
svg/zoom/text/absolute-sized-document-scrollbars.svg
svg/zoom/text/relative-sized-document-scrollbars.svg
svg/zoom/text/zoom-foreignObject.svg
svg/zoom/text/zoom-hixie-mixed-008.xml
svg/zoom/text/zoom-hixie-mixed-009.xml
svg/zoom/text/zoom-hixie-rendering-model-004.xhtml
svg/zoom/text/zoom-svg-float-border-padding.xml

  • platform/qt/Skipped:
07:55 UsingGitWithWebKit edited by vestbo@webkit.org
(diff)
07:54 UsingGitWithWebKit edited by vestbo@webkit.org
(diff)
07:51 Changeset [54960] by vestbo@webkit.org
  • 4 edits in trunk

Teach resolve-ChangeLogs to act as a merge-driver for Git

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=28721

To enable automatic merging of ChangeLog files, use the following command:

git config merge.changelog.driver "resolve-ChangeLogs --merge-driver %O %A %B"

The driver always works in "downstream" merge mode, meaning
it will always put the user's changelog entries on top.

  • Scripts/resolve-ChangeLogs:
  • .gitattributes: Add instruction to use merge-driver for ChangeLogs
06:27 Changeset [54959] by eric@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-02-18 Diego Escalante Urrelo <descalante@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] WebKitDownload documentation is incomplete
https://bugs.webkit.org/show_bug.cgi?id=35018

Concretely the error signal was undocumented. Also two relevant enums
were not included.

  • docs/webkitgtk-sections.txt:
  • docs/webkitgtk.types:
  • webkit/webkitdownload.cpp: (webkit_download_class_init):
06:22 Changeset [54958] by benm@google.com
  • 2 edits in trunk/WebCore

2010-02-18 Ben Murdoch <benm@google.com>

Reviewed by Jeremy Orlow.

[v8] Complete upstreaming of V8 Touch Event bindings
https://bugs.webkit.org/show_bug.cgi?id=35094

No new tests required.

  • bindings/v8/V8Index.cpp: Add generated touch event headers.
06:12 Changeset [54957] by steveblock@google.com
  • 3 edits in trunk/WebCore

2010-02-18 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Updates Android V8 build to use DerivedSourcesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=35083

No new tests, build fix only.

  • Android.derived.v8bindings.mk:
  • Android.v8bindings.mk:
05:32 Changeset [54956] by kov@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-12-05 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Eric Seidel.

Enable running of GTK+ API tests.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-gtk-tests: Added.
05:27 Changeset [54955] by kov@webkit.org
  • 4 edits in trunk

2010-02-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

fast/frames/iframe-reparenting.html crashing on GTK Debug bots
https://bugs.webkit.org/show_bug.cgi?id=35081

Check that the client is alive after every call to it, since any
of them could cause the load to be cancelled, and the client to go
away.

This is much better than protecting a specific subclass of
ResourceHandleClient (ResourceLoader), which makes us fail when
any other client is used.

Test: fast/frames/iframe-reparenting.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
04:00 Changeset [54954] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
https://bugs.webkit.org/show_bug.cgi?id=35086

fast/xmlhttprequest/xmlhttprequest-no-file-access.html cause
this fail indirectly, but both of them pass in separated DRT.

  • platform/qt/Skipped: fast/xmlhttprequest/xmlhttprequest-no-file-access.html

skipped until fix to make buildbot happy.

03:46 Changeset [54953] by philn@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-02-18 Philippe Normand <pnormand@igalia.com>

Not reviewed, adding a GTK layout test result for a new test
added in r54926.

  • platform/gtk/fast/css/first-letter-first-line-hover-expected.txt: Added.
03:37 Changeset [54952] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-18 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

plugins/iframe-shims.html crashing on GTK Debug bots
https://bugs.webkit.org/show_bug.cgi?id=35085

  • platform/gtk/Skipped: Skip crashing tests.
02:29 Changeset [54951] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-18 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

fast/frames/iframe-reparenting.html crashing on GTK Debug bots
https://bugs.webkit.org/show_bug.cgi?id=35081

  • platform/gtk/Skipped: Skip crashing test.
02:21 Changeset [54950] by benm@google.com
  • 9 edits in trunk/WebCore

[v8] [Android] V8 bindings for touch events are missing.
https://bugs.webkit.org/show_bug.cgi?id=33795

Reviewed by Nate Chapin.

No new tests as this just enables touch events in V8. Existing touch tests suffice.

  • WebCore.gypi: Add Touch idl files.
  • bindings/scripts/CodeGeneratorV8.pm: Add TouchList to typeCanFailConversion map.
  • bindings/v8/DOMObjectsInclude.h: Add touch headers.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Add touch generated bindings.
  • bindings/v8/V8Index.h: Add touch DOM object types.
  • bindings/v8/custom/V8EventCustom.cpp: Add conversion of event to touch event.
  • Android.derived.jscbindings.mk: Add the touch derived sources to the makefile.
  • Android.derived.v8bindings.mk: Add the touch derived sources to the makefile.
02:07 Changeset [54949] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-18 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

fast/css/font-face-opentype.html crashing on GTK bots
https://bugs.webkit.org/show_bug.cgi?id=35080

  • platform/gtk/Skipped: Skip crashing test.
01:27 Changeset [54948] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-02-18 Jay Campan <jcampan@google.com>

Reviewed by Adam Barth.

Exposing the title in WebDocument.

https://bugs.webkit.org/show_bug.cgi?id=35058

  • public/WebDocument.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::title):
01:17 Changeset [54947] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-02-18 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

debug-safari doesn't pass --debug option to gdb-safari on MacOSX
https://bugs.webkit.org/show_bug.cgi?id=34411

  • Scripts/webkitdirs.pm:
01:10 Changeset [54946] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-18 William Chan <willchan@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35071
Disable loader limiting of requests per host for the chromium port.

No tests because we're only changing a constant.

  • platform/network/chromium/ResourceRequest.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
00:54 Changeset [54945] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-02-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
https://bugs.webkit.org/show_bug.cgi?id=35053

  • Scripts/webkitpy/layout_tests/port/base.py: Add script_path() function for finding scripts.
  • Scripts/webkitpy/layout_tests/port/chromium.py: Remove unused argument.
  • Scripts/webkitpy/layout_tests/port/mac.py:
    • Make sure that calling webkit-build-directory works even if Scripts/ is not in the user's path.
    • Call build-dumprendertree (and make sure it succeeds) before running the tests.
00:38 Changeset [54944] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-02-18 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add the promised test for the unique file:// origins support.
See https://bugs.webkit.org/show_bug.cgi?id=34778 for more details.

  • fast/xmlhttprequest/xmlhttprequest-no-file-access.html: Added.
  • fast/xmlhttprequest/resources/xmlhttprequest-no-file-access-real.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt: Added.
00:36 Changeset [54943] by sfalken@apple.com
  • 9 edits in trunk

WebKit on Windows needs a mechanism to listen for WM_SETTINGCHANGED messages
https://bugs.webkit.org/show_bug.cgi?id=35076

Reviewed by Dan Bernstein.

WebKit/win:

  • WebKit.vcproj/WebKit.def: Added WebKitSystemParameterChanged.
  • WebKit.vcproj/WebKit_debug.def: Added WebKitSystemParameterChanged.
  • WebKitGraphics.cpp:

(WebKitSystemParameterChanged): Call through to wkSystemFontSmoothingChanged for font smoothing changes.

  • WebKitGraphics.h: Added WebKitSystemParameterChanged.

WebKitLibraries:

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib: Updated to add wkSystemFontSmoothingChanged.
  • win/lib/WebKitSystemInterface_debug.lib: Updated to add wkSystemFontSmoothingChanged.
00:17 Changeset [54942] by hamaji@chromium.org
  • 6 edits in trunk/WebKitTools

2010-02-16 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style's ProcessorOptions class into two
classes. This revision contains no new functionality.

https://bugs.webkit.org/show_bug.cgi?id=34674

Divided the ProcessorOptions class into a CommandOptionValues
class (the result of parsing the command-line options) and
a StyleCheckerConfiguration class (which configures the main
StyleChecker).

  • Scripts/check-webkit-style:
    • Updated main() to convert the parsed command option values to a StyleCheckConfiguration instance prior to constructing a StyleChecker.
  • Scripts/webkitpy/style/checker.py:
    • Added check_webkit_style_configuration() to convert a CommandOptionValues instance into a StyleCheckerConfiguration instance.
    • Renamed the ProcessorOptions class to CommandOptionValues.
    • In the CommandOptionValues class--
      • Replaced the filter_configuration attribute with the simpler filter_rules attribute.
      • Removed the max_reports_per_error attribute.
      • Moved the is_reportable() method to the new StyleCheckerConfiguration class.
    • Removed the base_filter_rules attribute from the DefaultCommandOptionValues class.
    • In the ArgumentParser class--
      • Added base_filter_rules to the constructor.
      • Changed the parse() method to return a CommandOptionValues instance instead of a ProcessorOptions instance.
    • Created a StyleCheckerConfiguration class.
      • Added the data attributes max_reports_per_category, stderr_write, and verbosity.
      • Added is_reportable() (moved from the ProcessorOptions class) and write_style_error() (moved from the DefaultStyleErrorHandler class).
    • In the StyleChecker class--
      • Replaced the ProcessorOptions options attribute with the StyleCheckerConfiguration _configuration attribute.
      • Removed the _stderr_write attribute.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the existing unit test classes as necessary.
    • Added a StyleCheckerConfigurationTest class.
  • Scripts/webkitpy/style/error_handlers.py:
    • Updated the DefaultStyleErrorHandler class to accept a StyleCheckerConfiguration instance instead of a ProcessorOptions instance and an stderr_write method.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated the unit test classes as necessary.
  • Scripts/webkitpy/style/filter.py:
    • Addressed the FIXME in the FilterConfiguration class to change the user_rules attribute to _user_rules (since it is now accessed only internally).
  • Scripts/webkitpy/style/filter_unittest.py:
    • Updated to reflect the change from user_rules to _user_rules.
00:17 Changeset [54941] by tony@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-02-18 Tony Chang <tony@chromium.org>

Not reviewed, adding a QT layout test result for a new test
added in r54932.

  • platform/qt/editing/pasteboard/page-zoom-expected.txt: Copied from LayoutTests/platform/gtk/editing/pasteboard/page-zoom-expected.txt.
00:06 Changeset [54940] by xan@webkit.org
  • 8 edits in trunk/WebCore

2010-02-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Eric Seidel.

[Linux] Webkit incompatible with Java plugins
https://bugs.webkit.org/show_bug.cgi?id=24912

The NP Version supported by WebKit is at the moment hardcoded in
PluginPackage.cpp (to 24), but not all backends actually implement
the methods needed to claim this. Introduce a new method to be
implemented by each backend where the maximum supported version
can be specified, and set the GTK+ port NPVersion to 19. This
fixes an instantaneous crasher in the Sun Java NPAPI plugin.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
  • plugins/PluginPackage.h:
  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/mac/PluginPackageMac.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/symbian/PluginPackageSymbian.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::NPVersion):
00:04 Changeset [54939] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] editing/pasteboard/page-zoom.html fails
https://bugs.webkit.org/show_bug.cgi?id=35077

  • platform/qt/Skipped: editing/pasteboard/page-zoom.html skipped until fix.
Note: See TracTimeline for information about the timeline view.