Timeline


and

03/02/10:

23:43 Changeset [55452] by eric@webkit.org
  • 11 edits in trunk

2010-03-02 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.

No new tests; tested by existing storage tests.

https://bugs.webkit.org/show_bug.cgi?id=35310

  • WebCore.base.exp: Export Database::setIsAvailable
  • WebCore.xcodeproj/project.pbxproj: Export needed headers as Private
  • page/DOMWindow.cpp: Read isAvailable, not Settings::isDatabaseEnabled (WebCore::DOMWindow::openDatabase):
  • page/Settings.cpp: Add a call to Database::setIsAvailable. (WebCore::Settings::setDatabasesEnabled):

2010-03-02 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.

No new tests; tested by existing storage tests.

https://bugs.webkit.org/show_bug.cgi?id=35310

  • webkit/webkitwebview.cpp: Add calls to Database::setIsAvailable (DNDContentsRequest::webkit_web_view_update_settings): (DNDContentsRequest::webkit_web_view_settings_notify):

2010-03-02 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.

No new tests; tested by existing storage tests.

https://bugs.webkit.org/show_bug.cgi?id=35310

  • WebView/WebView.mm: Added a call to Database::setIsAvailable. (-[WebView _preferencesChangedNotification:]):

2010-03-02 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Move database enable bit fully out of settings
This is stage one of a three-stage commit [webkit, then chromium, then
webkit again]. In this change I'm adding calls to
Database::setIsAvailable inside Settings::setDatabaseEnabled and
anywhere else that called it, and switching webkit fully over to using
that flag [added in a previous checkin]. Phase two will remove
Chromium's use of Settings for the Database, and phase three will remove
the Setting for the Database enable entirely, leaving only
Database::isAvailable/setIsAvailable.

No new tests; tested by existing storage tests.

https://bugs.webkit.org/show_bug.cgi?id=35310

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): Add a call to Database::setIsAvailable
23:22 Changeset [55451] by tony@chromium.org
  • 5 edits in trunk

2010-03-02 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

add a flag to WebURLResponse so we can identify multipart content
https://bugs.webkit.org/show_bug.cgi?id=35628

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::isMultipartPayload): (WebCore::ResourceResponse::setIsMultipartPayload):

2010-03-02 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

add a flag to WebURLResponse so we can identify multipart content
https://bugs.webkit.org/show_bug.cgi?id=35628

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::isMultipartPayload): (WebKit::WebURLResponse::setIsMultipartPayload):
22:46 Changeset [55450] by tony@chromium.org
  • 3 edits
    2 deletes in trunk

2010-03-02 Tony Chang <tony@chromium.org>

Not reviewed, test fix.

Revert r55447 because the new layout test is crashing consistently
on Leopard Intel Debug (tests).
https://bugs.webkit.org/show_bug.cgi?id=35261

  • svg/custom/tiling-regular-hexagonal-crash-expected.txt: Removed.
  • svg/custom/tiling-regular-hexagonal-crash.svg: Removed.

2010-03-02 Tony Chang <tony@chromium.org>

Not reviewed, test fix.

Revert r55447 because the new layout test is crashing consistently
on Leopard Intel Debug (tests).
https://bugs.webkit.org/show_bug.cgi?id=35261

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::create):
19:16 Changeset [55449] by eric@webkit.org
  • 14 edits in trunk

2010-03-02 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Google Analytics triggers "blocked plugin" UI
https://bugs.webkit.org/show_bug.cgi?id=35565

Just like for running script, we need to distinguish between querying
whether plug-ins are enabled and actually blocking a page from
instantiating a plugin. We need to issue different callbacks to the
FrameLoaderClient so that the client can inform us that plug-ins are
disabled in some cases without showing the "plug-in blocked" UI.

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::allowPlugins):
  • loader/FrameLoader.h: (WebCore::):
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::didNotAllowPlugins):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):
  • page/Page.cpp: (WebCore::Page::pluginData):
  • plugins/MimeType.cpp: (WebCore::MimeType::enabledPlugin):

2010-03-02 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Google Analytics triggers "blocked plugin" UI
https://bugs.webkit.org/show_bug.cgi?id=35565

Plumb didNotAllowPlugins to the client.

  • public/WebFrameClient.h: (WebKit::WebFrameClient::didNotAllowPlugins):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
  • src/FrameLoaderClientImpl.h:
18:53 Changeset [55448] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-02 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Support the HTTP OPTIONS verb (needed for preflight requests)

https://bugs.webkit.org/show_bug.cgi?id=34647

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):
18:37 Changeset [55447] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-02 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs with Skia

This test passes if it doesn't crash.

  • svg/custom/tiling-regular-hexagonal-crash-expected.txt: Added.
  • svg/custom/tiling-regular-hexagonal-crash.svg: Added.

2010-03-02 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs

This fixes the crash, but the SVG still doesn't render properly.

Test: svg/custom/tiling-regular-hexagonal-crash.svg

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::create): don't return 0 when the copy fails; instead return a blank bitmap. The caller doesn't check for 0 before dereferencing.
18:20 Changeset [55446] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-02 Arno Renevier <arno@renevier.net>

Reviewed by Gustavo Noronha Silva.

[Gtk] use geoclue providers with don't provide update
https://bugs.webkit.org/show_bug.cgi?id=35191

No new tests, behaviour depends on system.

  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::startUpdating):
17:43 Changeset [55445] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-02 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Adler.

Remove unnecessary check.
https://bugs.webkit.org/show_bug.cgi?id=35513

  • platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):
17:27 Changeset [55444] by eric@webkit.org
  • 16 edits
    2 adds in trunk

2010-03-02 Arno Renevier <arno@renevier.net>

Reviewed by Gustavo Noronha Silva.

[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210

  • GNUmakefile.am:

2010-03-02 Arno Renevier <arno@renevier.net>

Reviewed by Gustavo Noronha Silva.

[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210

  • platform/gtk/Skipped:

2010-03-02 Arno Renevier <arno@renevier.net>

Reviewed by Gustavo Noronha Silva.

[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:
  • docs/webkitgtk-sections.txt:
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitgeolocationpolicydecision.cpp: Added. (webkit_geolocation_policy_decision_class_init): (webkit_geolocation_policy_decision_init): (webkit_geolocation_policy_decision_new): (webkit_geolocation_policy_allow): (webkit_geolocation_policy_deny):
  • webkit/webkitgeolocationpolicydecision.h: Added.
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
  • webkitmarshal.list:

2010-03-02 Arno Renevier <arno@renevier.net>

Reviewed by Gustavo Noronha Silva.

[Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=35210

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (geolocationPolicyDecisionRequested): (createWebView):
16:59 Changeset [55443] by darin@chromium.org
  • 2 edits in trunk/WebCore

2010-03-02 Darin Fisher <darin@chromium.org>

Fix chromium build bustage.

  • page/Page.cpp: (WebCore::Page::privateBrowsingStateChanged): PluginView methods may not be called in the Chromium port.
16:48 Changeset [55442] by bdakin@apple.com
  • 5 edits in trunk

WebCore: Fix for <rdar://problem/7485289> WebKit crashes on systems that
don't support CoreAnimation

Reviewed by Darin Adler and Adam Roben.

WKCACFLayerRenderer::acceleratedCompositingAvailable() now creates
a dummy HWND so that it can step through the whole setHostWindow()
and createRenderer() process. createRenderer() also calls a new
function, hardwareCapabilitiesIndicateCoreAnimationSupport() which
can only be called once we have a d3dDevice.

setHostWindow() and createRenderer() now both return bools that
indicate whether or not they have succeeded.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::hardwareCapabilitiesIndicateCoreAnimationSupport):
(WebCore::CoreAnimationTesterWindowWndProc):
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
(WebCore::WKCACFLayerRenderer::shared):
(WebCore::WKCACFLayerRenderer::createRenderer):

  • platform/graphics/win/WKCACFLayerRenderer.h:

(WebCore::WKCACFLayerRenderer::setHostWindow):

WebKit/win: Tiny WebKit portion of fix for <rdar://problem/7485289> WebKit
crashes on systems that don't support CoreAnimation

Reviewed by Darin Adler and Adam Roben.

setHostWindow() no longer calls createRenderer(), so now that has
to be called manually.

  • WebView.cpp:

(WebView::setAcceleratedCompositing):

16:43 Changeset [55441] by mrowe@apple.com
  • 3 edits in trunk/WebCore

ScriptDebugServer shouldn't care that Mac does not use PluginView for plug-ins.

Rubber-stamped by Jon Honeycutt.

  • bindings/js/ScriptDebugServer.cpp:
  • plugins/PluginViewNone.cpp:

(WebCore::PluginView::setJavaScriptPaused): Add an empty implementation of setJavaScriptPaused.

16:36 Changeset [55440] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Clean up the build fix r55437 by adding an empty implementation of privateBrowsingStateChanged in PluginViewNone.cpp

Rubber-stamped by Jon Honeycutt.

  • page/Page.cpp:
  • plugins/PluginViewNone.cpp:

(WebCore::PluginView::privateBrowsingStateChanged):

16:16 Changeset [55439] by dpranke@chromium.org
  • 1 edit
    1 delete in trunk/WebKitTools

2010-03-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by David Levin.

Revert r55339 - the Chromium codebase downstream had a temporary
need for WebKitTools/pywebsocket to still exist after Chris Jerdonek
had moved it (scripts still referenced the old location). Those
scripts have been updated to the new location, so it should be safe
to delete this now.

https://bugs.webkit.org/show_bug.cgi?id=35614

  • pywebsocket/mod_pywebsocket/standalone.py: Removed.
16:09 Changeset [55438] by andersca@apple.com
  • 2 edits in trunk/WebKitExamplePlugins

NPWindow is now null in the Cocoa event model.

Reviewed by Kevin Decker.

  • NetscapeInputMethodPlugin/main.m:

(handleDraw):
(NPP_HandleEvent):

15:39 Changeset [55437] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the Mac build.

  • page/Page.cpp:

(WebCore::Page::privateBrowsingStateChanged): Mac doesn't use WebCore's PluginView class
for plug-ins, so provide an empty implementation of privateBrowsingStateChanged for Mac.

15:33 Changeset [55436] by mrowe@apple.com
  • 8 edits
    2 adds in trunk

WebCore: Add the capability to create and dispatch a WheelEvent in JavaScript.
Ensure the event's default handler is triggered in the same way as it is
during a PlatformWheelEvent.

Patch by Andy Estes <aestes@apple.com> on 2010-03-02
Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=35566

Test: fast/events/wheelevent-in-scrolling-div.html

  • dom/Node.cpp: Ensure that the default behavior (scrolling) occurs for

wheel events originating both from the platform and from
JavaScript/ObjC.
(WebCore::Node::dispatchWheelEvent): Instantiate new WheelEvent with
the graunularity of the PlatformWheelEvent.
(WebCore::Node::defaultEventHandler): Add support for mousewheel events.

  • dom/WheelEvent.cpp: Add three new member variables: m_deltaX, m_deltaY

and m_granularity. m_deltaX and m_deltaY differ from m_wheelDeltaX and
m_wheelDeltaY, which are the number of wheel ticks multiplied by 120 for
IE compatibility.
(WebCore::WheelEvent::WheelEvent): Initialize new member variables.
(WebCore::WheelEvent::initWheelEvent): Same.
(WebCore::WheelEvent::initWebKitWheelEvent): Same.

  • dom/WheelEvent.h: See WheelEvent.cpp.

(WebCore::WheelEvent::): Add Granularity enum (Pixel, Line, Page).
(WebCore::WheelEvent::create): Add new arguments.
(WebCore::WheelEvent::deltaX): Amount of scroll in x direction.
(WebCore::WheelEvent::deltaY): Amount of scroll in y direction.
(WebCore::WheelEvent::granularity): Units of deltaX and deltaY.

  • dom/WheelEvent.idl: Add initWebKitWheelEvent() to JavaScript. This is

the same as the initWheelEvent ObjC method. As the DOM Level 3 Events
specification is still a working draft and subject to change, prefix
'WebKit' to the method signature to indicate experimental support.

  • page/EventHandler.cpp: Move the scroll handling from

handleWheelEvent() to defaultWheelEventHandler(), which is executed on
both PlatformWheelEvents and JavaScript WheelEvents.
(WebCore::scrollNode): Renamed from scrollAndAcceptEvent(). Remove
the PlatformWheelEvent from the argument list and instead return a
boolean indicating if the scroll event was accepted.
(WebCore::EventHandler::handleWheelEvent): Move scrolling code from here
(WebCore::EventHandler::defaultWheelEventHandler): ...to here.

  • page/EventHandler.h: Add function signature.

LayoutTests: Add a test for the patch to https://bugs.webkit.org/show_bug.cgi?id=35566.
These can be run manually or from DRT.

Patch by Andy Estes <aestes@apple.com> on 2010-03-02
Reviewed by Maciej Stachowiak.

  • fast/events/wheelevent-in-scrolling-div-expected.txt: Added.
  • fast/events/wheelevent-in-scrolling-div.html: Added.
15:32 Changeset [55435] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

new-run-webkit-tests on chromium-linux tests to see if
layout_test_helper exists, but we don't use layout_test_helper on
linux. The test derefences a None object, and we crash. This fixes
that.

https://bugs.webkit.org/show_bug.cgi?id=35602

  • Scripts/webkitpy/layout_tests/port/chromium.py:

2010-03-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

r55388 (bug 35553) worked around a bug in Python's subprocess.Popen()
that was causing DRT to hang on exit in new-run-webkit-tests.
Unfortunately, that workaround doesn't work on chromium-win
(and the script fails completely). The good news is that the check
isn't actually necessary, and so this change makes it conditional.

https://bugs.webkit.org/show_bug.cgi?id=35601

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:29 Changeset [55434] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

r55388 (bug 35553) worked around a bug in Python's subprocess.Popen()
that was causing DRT to hang on exit in new-run-webkit-tests.
Unfortunately, that workaround doesn't work on chromium-win
(and the script fails completely). The good news is that the check
isn't actually necessary, and so this change makes it conditional.

https://bugs.webkit.org/show_bug.cgi?id=35601

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:13 Changeset [55433] by mrowe@apple.com
  • 11 edits in trunk

Bug 35576: WebKit should tell plug-in instances when private browsing state changes
<http://webkit.org/b/35576>

Reviewed by Darin Adler.

WebCore:

Notify plug-in instances when the private browsing state changes to match the behavior of the
Mac plug-in code.

  • page/Page.cpp:

(WebCore::Page::privateBrowsingStateChanged): Walk the frame tree and notify each PluginView that
the private browsing state has changed.

  • page/Page.h:
  • page/Settings.cpp:

(WebCore::Settings::setPrivateBrowsingEnabled): Notify the page that the private browsing state
has changed.

  • plugins/PluginView.cpp:

(WebCore::PluginView::privateBrowsingStateChanged): Notify the plug-in instance of the new private
browsing state.

  • plugins/PluginView.h:

WebKitTools:

TestNetscapePlugin is another bit of plug-in code where copy-paste was heavily used
when porting. Update the Windows and UNIX implementations of NPP_New and NPP_SetValue
to provide the expected behavior related to NPNVprivateModeBool. Hopefully this code
duplication can be cleaned up in the future.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:

(webkit_test_plugin_new_instance):
(webkit_test_plugin_set_value):

  • DumpRenderTree/win/TestNetscapePlugin/main.cpp:

(NPP_New):
(NPP_SetValue):

LayoutTests:

  • platform/win/Skipped: Remove plugins/private-browsing-mode.html now that it passes.
15:13 Changeset [55432] by mrowe@apple.com
  • 11 edits in trunk

Bug 30348: Implement private mode for plug-ins on Windows
<http://webkit.org/b/30348> / <rdar://problem/7562261>

Reviewed by Oliver Hunt.

WebCore:

Rework PluginView::getValue and PluginView::getValueStatic to remove the amount of code that
was duplicated across platforms. getValue and getValueStatic now call in to platform-specific
variants that indicate whether they handled the query. If the query is not handled by the
platform-specific variants then the cross-platform handler has a chance to handle it.

  • plugins/PluginView.cpp:

(WebCore::PluginView::getValueStatic): Give the platform-specific variant a chance to handle the
variable lookup. If it does not handle it, return an error.
(WebCore::PluginView::getValue): Give the platform-specific variant and platform-specific static
variant a chance to handle the variable lookup. If they do not handle it, apply the cross-platform
handler. At the moment the cross-platform code handles NPNVWindowNPObject, NPNVPluginElementNPObject,
and NPNVprivateModeBool as they have an identical implementation across ports.

  • plugins/PluginView.h:
  • plugins/PluginViewNone.cpp:

(WebCore::PluginView::platformGetValue): PluginViewNone does not handle any lookups.
(WebCore::PluginView::platformGetValueStatic): Ditto.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
platform-independent implementation.

  • plugins/mac/PluginViewMac.cpp:

(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue): Fix a bug noticed while updating this code.
The Qt implementation of the handler for NPNVToolkit was relying on case fall-through
to have some values handled by the static handler. When NPNVprivateModeBool was added
it was placed before the default case, interferring with this fall-through. It now
explicitly indicates in this situation that it was not handled.

  • plugins/symbian/PluginViewSymbian.cpp:

(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):

LayoutTests:

  • platform/win/Skipped: Remove plugins/private-browsing-mode-2.html now that it passes.
14:27 Changeset [55431] by andersca@apple.com
  • 3 edits in trunk/WebCore

Make the default constructor available to all platforms.

Reviewed by Sam Weinig.

  • platform/PlatformKeyboardEvent.h:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/mac/KeyEventMac.mm:
14:24 Changeset [55430] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=35600
shouldBe() fails when comparing an array to null.

  • fast/js/resources/js-test-pre.js: (areArraysEqual): This function is expected to be called with weird arguments, as it's used with array-like objects like WebGLByteArray. Made it resilient against exceptions raised when dealing with those.
14:21 Changeset [55429] by eric@webkit.org
  • 8 edits in trunk

2010-03-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by David Levin.

Revert database thread changes that are no longer required
https://bugs.webkit.org/show_bug.cgi?id=35519

Jochen Eisinger created 55214 and 55247 to track which database
owns which thread. Dmitry suggested that this could also
be done via TLS, though. After exploring the options, Jochen
chose to go the TLS route, so these patches are no longer needed.

  • wtf/Threading.h:
  • wtf/ThreadingNone.cpp: (WTF::isMainThread):
  • wtf/ThreadingPthreads.cpp: (WTF::identifierByPthreadHandle): (WTF::establishIdentifierForPthreadHandle): (WTF::pthreadHandleForIdentifier): (WTF::createThreadInternal): (WTF::currentThread):
  • wtf/ThreadingWin.cpp: (WTF::threadMap): (WTF::storeThreadHandleByIdentifier): (WTF::threadHandleForIdentifier): (WTF::createThreadInternal):

2010-03-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by David Levin.

Revert database thread changes that are no longer required
https://bugs.webkit.org/show_bug.cgi?id=35519

Jochen Eisinger created 55214 and 55247 to track which database
owns which thread. Dmitry suggested that this could also
be done via TLS, though. After exploring the options, Jochen
chose to go the TLS route, so these patches are no longer needed.

  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::databaseThread):
  • storage/DatabaseThread.h: (WebCore::DatabaseThread::getThreadID):
13:46 Changeset [55428] by beidson@apple.com
  • 5 edits in trunk

Followup for REGRESSION(r51097) - Unable to log in to statefarm.com
<rdar://problem/7672667> and https://bugs.webkit.org/show_bug.cgi?id=35556

Reviewed by Sam Weinig.

WebCore:

  • dom/ScriptElement.cpp:

(WebCore::ScriptElementData::shouldExecuteAsJavaScript): To more perfectly match Gecko's rule,

strip whitespace from the attribute values before comparing to window/onload/onload().

LayoutTests:

  • fast/loader/for-window-event-onload-scripts-expected.txt:
  • fast/loader/for-window-event-onload-scripts.html:
13:39 Changeset [55427] by eric@webkit.org
  • 6 edits in trunk/JavaScriptCore

2010-03-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Fix QScriptValue::toString().

More ECMA Script compliance, especially for values as NaN, Inifinite
and really big/small numbers.

[Qt] QScriptValue::toString() returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=34850

  • qt/api/qscriptconverter_p.h: (QScriptConverter::toString):
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toString):
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp:
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::toString_initData): (tst_QScriptValue::toString_makeData): (tst_QScriptValue::toString_test):
13:20 Changeset [55426] by eric@webkit.org
  • 7 edits
    1 copy
    5 adds in trunk/JavaScriptCore

2010-03-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Introduce a new class; QScriptString.

The QScriptString class should act as a handle to "interned"
strings in a QScriptEngine.

[Qt] QtScript should provide QScriptString
https://bugs.webkit.org/show_bug.cgi?id=34843

  • qt/api/QtScript.pro:
  • qt/api/qscriptengine.cpp: (QScriptEngine::toStringHandle):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.h: (QScriptEnginePrivate::toStringHandle):
  • qt/api/qscriptstring.cpp: Added. (QScriptString::QScriptString): (QScriptString::~QScriptString): (QScriptString::operator=): (QScriptString::isValid): (QScriptString::operator==): (QScriptString::operator!=): (QScriptString::toArrayIndex): (QScriptString::toString): (QScriptString::operator QString): (qHash):
  • qt/api/qscriptstring.h: Added.
  • qt/api/qscriptstring_p.h: Added. (QScriptStringPrivate::QScriptStringPrivate): (QScriptStringPrivate::~QScriptStringPrivate): (QScriptStringPrivate::get): (QScriptStringPrivate::isValid): (QScriptStringPrivate::operator==): (QScriptStringPrivate::operator!=): (QScriptStringPrivate::toArrayIndex): (QScriptStringPrivate::toString): (QScriptStringPrivate::id):
  • qt/tests/qscriptstring/qscriptstring.pro: Added.
  • qt/tests/qscriptstring/tst_qscriptstring.cpp: Added. (tst_QScriptString::tst_QScriptString): (tst_QScriptString::~tst_QScriptString): (tst_QScriptString::test): (tst_QScriptString::hash): (tst_QScriptString::toArrayIndex_data): (tst_QScriptString::toArrayIndex):
  • qt/tests/tests.pro:
13:15 Changeset [55425] by cfleizach@apple.com
  • 13 edits
    2 adds in trunk

aria-label isn't respected on option elements
https://bugs.webkit.org/show_bug.cgi?id=35400

Reviewed by Beth Dakin.

WebCore:

When aria-label is used on an <option> element, it can take three forms.
An option in a multi-select list, a popup button and the menu that is displayed
from the popup button. This patches the three requisite locations so that if
aria-label is used, the correct accessibility text is returned.

Test: platform/mac/accessibility/option-with-arialabel.html

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::stringValue):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::getAttribute):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getAttribute):
(WebCore::AccessibilityRenderObject::stringValue):

  • platform/PopupMenuClient.h:
  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenu::populate):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemAccessibilityText):

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.h:

(WebCore::RenderTextControlSingleLine::itemAccessibilityText):

WebKit/chromium:

  • src/SuggestionsPopupMenuClient.h:

(WebKit::SuggestionsPopupMenuClient::itemAccessibilityText):

LayoutTests:

  • platform/mac/accessibility/option-with-arialabel-expected.txt: Added.
  • platform/mac/accessibility/option-with-arialabel.html: Added.
13:11 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
13:08 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
title size adjustment (diff)
13:04 QtWebKit edited by jocelyn.turcotte@nokia.com
link to the QtWebKitBugs page instead (diff)
13:01 QtWebKitContrib edited by jocelyn.turcotte@nokia.com
Move bugs information to QtWebKitBugs (diff)
13:01 QtWebKitBugs created by jocelyn.turcotte@nokia.com
12:48 Changeset [55424] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-03-02 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] V8 should be notified of context disposals
https://bugs.webkit.org/show_bug.cgi?id=35526

Notify V8 of context disposals to allow it to clean up memory from those
contexts when idle. When disposing a context, start a timer that will
give V8 an idle notification after a while to force cleanup. Use a timer
to avoid performing an idle notification in the middle of navigation where
we know we are not idle.

  • WebCore.gypi:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::disposeContextHandles):
  • bindings/v8/V8GCForContextDispose.cpp: Added. (WebCore::V8GCForContextDispose::V8GCForContextDispose): (WebCore::V8GCForContextDispose::notifyContextDisposed): (WebCore::V8GCForContextDispose::notifyIdleSooner): (WebCore::V8GCForContextDispose::instance): (WebCore::V8GCForContextDispose::pseudoIdleTimerFired):
  • bindings/v8/V8GCForContextDispose.h: Added.
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::WindowSetTimeoutImpl):

2010-03-02 Mads Ager <ager@chromium.org>

Reviewed by Adam Barth.

[V8] V8 should be notified of context disposals
https://bugs.webkit.org/show_bug.cgi?id=35526

Update V8 DEPS in order to get V8 API changes needed for context
disposal notifications.

  • DEPS:
12:31 Changeset [55423] by eric@webkit.org
  • 5 edits
    18 deletes in trunk/LayoutTests

2010-03-02 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

Merge ValidityState-stepMismatch-{number,range,unsupported}.html and
input-step-{number,range,unsupported}.html to other tests
https://bugs.webkit.org/show_bug.cgi?id=35435

  • Merge ValidityState-stepMismatch-{number,range,unsupported}.html to ValidityState-stepMismatch.html
  • Merge input-step--{number,range,unsupported}.html to input-step.html
  • fast/forms/ValidityState-stepMismatch-expected.txt:
  • fast/forms/ValidityState-stepMismatch-number-expected.txt: Removed.
  • fast/forms/ValidityState-stepMismatch-number.html: Removed.
  • fast/forms/ValidityState-stepMismatch-range-expected.txt: Removed.
  • fast/forms/ValidityState-stepMismatch-range.html: Removed.
  • fast/forms/ValidityState-stepMismatch-unsupported-expected.txt: Removed.
  • fast/forms/ValidityState-stepMismatch-unsupported.html: Removed.
  • fast/forms/input-step-number-expected.txt: Removed.
  • fast/forms/input-step-number.html: Removed.
  • fast/forms/input-step-range-expected.txt: Removed.
  • fast/forms/input-step-range.html: Removed.
  • fast/forms/input-step-unsupported-expected.txt: Removed.
  • fast/forms/input-step-unsupported.html: Removed.
  • fast/forms/input-stepup-stepdown-expected.txt:
  • fast/forms/script-tests/ValidityState-stepMismatch-number.js: Removed.
  • fast/forms/script-tests/ValidityState-stepMismatch-range.js: Removed.
  • fast/forms/script-tests/ValidityState-stepMismatch-unsupported.js: Removed.
  • fast/forms/script-tests/ValidityState-stepMismatch.js:
  • fast/forms/script-tests/input-step-number.js: Removed.
  • fast/forms/script-tests/input-step-range.js: Removed.
  • fast/forms/script-tests/input-step-unsupported.js: Removed.
  • fast/forms/script-tests/input-stepup-stepdown.js:
12:18 Changeset [55422] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-03-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: adding missing image files to WebKit.qrc and gypi.

  • WebCore.gypi:
  • inspector/front-end/WebKit.qrc:
12:15 Changeset [55421] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-02 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: Video element with 3d transform crashes when AC is enabled.
https://bugs.webkit.org/show_bug.cgi?id=35516

No new tests.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQt::setContentsToMedia):
11:50 Changeset [55420] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-02 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Xan Lopez.

Use unsigned instead of uint which does not exist on windows
https://bugs.webkit.org/show_bug.cgi?id=35546

  • platform/graphics/gtk/ImageGtk.cpp: (WebCore::getCairoSurfacePixel): (WebCore::getGdkPixbufPixel):
11:33 Changeset [55419] by eric@webkit.org
  • 7 edits in trunk

2010-03-02 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add EnabledAtRuntime attribute to WebGLArray constructors
https://bugs.webkit.org/show_bug.cgi?id=35558

New functionality verified manually in Chromium; not possible to
write layout test. Ran WebGL tests in WebKit as well.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebGLEnabled): (WebCore::RuntimeEnabledFeatures::webGLRenderingContextEnabled): (WebCore::RuntimeEnabledFeatures::webGLArrayBufferEnabled): (WebCore::RuntimeEnabledFeatures::webGLByteArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLUnsignedByteArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLShortArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLUnsignedShortArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLIntArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLUnsignedIntArrayEnabled): (WebCore::RuntimeEnabledFeatures::webGLFloatArrayEnabled):
  • page/DOMWindow.idl:

2010-03-02 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add EnabledAtRuntime attribute to WebGLArray constructors
https://bugs.webkit.org/show_bug.cgi?id=35558

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebGL): (WebKit::WebRuntimeFeatures::isWebGLEnabled):
11:12 Changeset [55418] by dimich@chromium.org
  • 2 edits in trunk

Ignore compiled Java test cases in .gitignore.
https://bugs.webkit.org/show_bug.cgi?id=35559

Reviewed by Alexey Proskuryakov.

  • .gitignore:
11:10 Changeset [55417] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2010-03-02 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fail gracefully if NPN_GetProperty tries to retrieve a property that doesn't exist.

https://bugs.webkit.org/show_bug.cgi?id=35588

Required for passing LayoutTests/plugins/netscape-plugin-property-access-exception.html on Chromium.

  • bindings/v8/NPV8Object.cpp: (_NPN_GetProperty): If the result is empty, don't try to convert it to an NPVariant and return false.
10:59 Changeset [55416] by jianli@chromium.org
  • 2 edits in trunk/WebCore

[V8] DOMCoreException should be visible as DOMException
https://bugs.webkit.org/show_bug.cgi?id=35552

Reviewed by Nate Chapin.

Fix V8 code generator to use the correct visible name.

  • bindings/scripts/CodeGeneratorV8.pm:
10:34 Changeset [55415] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

Test plugin still has issues with releasing objects, and variants
https://bugs.webkit.org/show_bug.cgi?id=35587

Fix the conditions for releasing the variants after calling
invoke, and avoid having a number of objects leak.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testDocumentOpen): (testWindowOpen):
10:33 Changeset [55414] by beidson@apple.com
  • 9 edits
    2 adds in trunk

REGRESSION(r51097) - Unable to log in to statefarm.com
<rdar://problem/7672667> and https://bugs.webkit.org/show_bug.cgi?id=35556

Reviewed by Sam Weinig.

WebCore:

Test: fast/loader/for-window-event-onload-scripts.html

Match Gecko's rules for executing "for/event" scripts:

-If there's only a 'for' attribute, execute it.
-If there's only an 'event' attribute, execute it.
-If there's a 'for=window' and 'event=onload', execute it.
-If there's a 'for=window' and 'event=onload()', execute it.
-If there's any other combination of both 'for' and 'event', don't execute it.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElementData::shouldExecuteAsJavaScript):

  • dom/ScriptElement.h:
  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::eventAttributeValue):

  • html/HTMLScriptElement.h:
  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::eventAttributeValue):

  • svg/SVGScriptElement.h:

Add the event attribute name:

  • html/HTMLAttributeNames.in:

LayoutTests:

  • fast/loader/for-window-event-onload-scripts-expected.txt: Added.
  • fast/loader/for-window-event-onload-scripts.html: Added.
10:19 Changeset [55413] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-02 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement WebNode::equals and add inline operators for ==
and !=.

https://bugs.webkit.org/show_bug.cgi?id=35543

  • public/WebNode.h: (WebKit::operator==): (WebKit::operator!=):
  • src/WebNode.cpp: (WebKit::WebNode::equals):
09:52 Changeset [55412] by simon.fraser@apple.com
  • 2 edits
    1 add in trunk/WebCore

2010-03-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=35555
QuickTime plugin content can spill outside the <object> tag

Set -masksToBounds on the layer that is handed to us by plug-ins, to ensure that sublayers
of that layer don't spill outside the <object> contents rect.

Manual test because it relies on QuickTime, and pixel results depend on movie loading timing.

  • manual-tests/plugins/object-clipping.html: Added.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setupContentsLayer):
09:25 Changeset [55411] by cjerdonek@webkit.org
  • 4 edits in trunk/WebKitTools

Refactored the StyleChecker class's file-processing method
_process_file(). This will make it easier to add new
file-processing capabilities to check-webkit-style.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35490

  • Scripts/webkitpy/style/checker.py:
    • Added a _read_lines() method to the StyleChecker class that extracts the lines from a file.
    • Replaced part of _process_file() with a call to the new _read_lines() method.
    • Replaced another part of _process_file() with a call to the new CarriageReturnProcessor.process() method.
  • Scripts/webkitpy/style/processors/common.py:
    • Replaced the check_no_carriage_return() function with a new CarriageReturnProcessor class.
  • Scripts/webkitpy/style/processors/common_unittest.py:
    • Renamed the CarriageReturnTest class to CarriageReturnProcessorTest and updated it as necessary.
09:25 Changeset [55410] by cfleizach@apple.com
  • 3 edits in trunk/LayoutTests

Fixing layout test problems. No review.

AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514

AXTable tests crash on Leopard/Tiger because tables don't exist. This test needs to be skipped
on those playtforms.

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
09:11 QtWebKit edited by vestbo@webkit.org
(diff)
08:48 Changeset [55409] by cjerdonek@webkit.org
  • 5 edits
    2 adds in trunk/WebKitTools

2010-03-02 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Started using the logging module in check-webkit-style.
This provides more options for debugging and a more flexible,
uniform way to report messages to the end-user.

https://bugs.webkit.org/show_bug.cgi?id=35484

Also included classes in a central location to facilitate
the unit testing of logging code (setUp and tearDown of unit
test logging configurations, etc).

  • Scripts/check-webkit-style:
    • Added a call to configure_logging() in the beginning of main().
    • Replaced two calls to sys.stderr.write() with appropriate logging calls.
  • Scripts/webkitpy/init/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
  • Scripts/webkitpy/init/logtesting.py: Added.
    • Added a UnitTestLogStream class to capture log output during unit tests.
    • Added a UnitTestLog class that provides convenience methods for unit-testing logging code.
  • Scripts/webkitpy/style/checker.py:
    • Added a configure_logging() method.
    • Added a _LevelLoggingFilter class to filter out log messages above a certain logging level.
    • Removed the _stderr_write() method from the StyleChecker class and replaced its use with appropriate logging calls.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added a ConfigureLoggingTest class to unit test the configure_logging() method.
    • Updated the StyleCheckerCheckFileTest class as necessary.
  • Scripts/webkitpy/style_references.py:
    • Added references to logtesting.UnitTestLog and logtesting.UnitTestLogStream.
08:22 Changeset [55408] by aroben@apple.com
  • 10 edits in trunk

Expose SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI

Fixes <http://webkit.org/b/35580> <rdar://problem/7706407>

Reviewed by Tim Hatcher.

WebCore:

Export SecurityOrigin::registerURLSchemeAsSecure

  • WebCore.base.exp: Added symbol, sorted file.

WebKit/mac:

Add -[WebView _registerURLSchemeAsSecure:]

  • WebView/WebView.mm:

(+[WebView _registerURLSchemeAsSecure:]):

  • WebView/WebViewPrivate.h:

Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.

WebKit/win:

Add IWebViewPrivate::registerURLSchemeAsSecure

  • Interfaces/WebKit.idl: Touched to force a build.
  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(WebView::registerURLSchemeAsSecure):

  • WebView.h:

Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.

08:15 QtWebKit edited by vestbo@webkit.org
(diff)
08:14 QtWebKit edited by vestbo@webkit.org
(diff)
08:10 QtWebKitContrib edited by vestbo@webkit.org
(diff)
08:09 QtWebKitContrib edited by vestbo@webkit.org
(diff)
06:52 QtWebKitContrib edited by vestbo@webkit.org
(diff)
06:50 QtWebKitContrib edited by vestbo@webkit.org
(diff)
06:44 QtWebKitContrib edited by vestbo@webkit.org
(diff)
06:37 Changeset [55407] by pfeldman@chromium.org
  • 4 edits
    5 adds in trunk/WebCore

2010-03-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: render breakpoints as border images instead of canvas.

https://bugs.webkit.org/show_bug.cgi?id=35535

  • inspector/front-end/Images/breakpointBorder.png: Added.
  • inspector/front-end/Images/breakpointConditionalBorder.png: Added.
  • inspector/front-end/Images/breakpointConditionalCounterBorder.png: Added.
  • inspector/front-end/Images/breakpointCounterBorder.png: Added.
  • inspector/front-end/Images/programCounterBorder.png: Added.
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._updateExecutionLine): (WebInspector.SourceFrame.prototype._addBreakpointToSource): (WebInspector.SourceFrame.prototype.resize):
  • inspector/front-end/TextViewer.js: (WebInspector.TextChunk):
  • inspector/front-end/textViewer.css:
06:09 CommitterTips edited by cjerdonek@webkit.org
Added section about unreviewed commits. (diff)
06:06 CommitterTips edited by cjerdonek@webkit.org
Added section about rolling out. (diff)
02:16 Changeset [55406] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Special case Font::floatWidthForComplexText for single space

https://bugs.webkit.org/show_bug.cgi?id=33876

For a single space we can go through the QFontMetric::width routine
instead of converting the WebCore::String to a QString and then
going through the QTextLine.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText):

01:59 Changeset [55405] by zecke@webkit.org
  • 4 edits in trunk

[Gtk] Support private browsing mode in plugins.

https://bugs.webkit.org/show_bug.cgi?id=35500

Integrate the PluginViewQt.cpp changes from
r55358 into Gtk+ and unskip the test.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::getValue):

  • platform/gtk/Skipped:
01:12 Changeset [55404] by oliver@apple.com
  • 3 edits in trunk/WebCore

2010-03-02 Oliver Hunt <oliver@apple.com>

Reviewed by NOBODY (Build fix).

Update Qt bridge to new named getter signature

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
  • bridge/qt/qt_runtime.h:
01:01 PythonGuidelines created by cjerdonek@webkit.org
Created Python page.
00:32 Changeset [55403] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-03-02 Oliver Hunt <oliver@apple.com>

Reviewed by NOBODY (Build fix).

Export function on windows.

00:31 WikiStart edited by cjerdonek@webkit.org
Added link to Python Guidelines page. (diff)
00:30 Changeset [55402] by philn@webkit.org
  • 2 edits
    8 moves
    1 add in trunk/WebCore

2010-03-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Move gstreamer-related source files to platform/graphics/gstreamer
https://bugs.webkit.org/show_bug.cgi?id=35518

Moved GStreamer-related files to platform/graphics/gstreamer so
other ports could benefit from this media player implementation.

  • GNUmakefile.am:
  • platform/graphics/gstreamer/DataSourceGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/DataSourceGStreamer.cpp. (_do_init): (webkit_data_src_base_init): (webkit_data_src_class_init): (webkit_data_src_reset): (webkit_data_src_init): (webkit_data_src_finalize): (webkit_data_src_change_state): (webkit_data_src_uri_get_type): (webkit_data_src_uri_get_protocols): (webkit_data_src_uri_get_uri): (webkit_data_src_uri_set_uri): (webkit_data_src_uri_handler_init):
  • platform/graphics/gstreamer/DataSourceGStreamer.h: Renamed from WebCore/platform/graphics/gtk/DataSourceGStreamer.h.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp. (WebCore::greatestCommonDivisor): (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::notifyVolumeIdleCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::notifyMuteIdleCallback): (WebCore::bufferingTimeoutCallback): (WebCore::playbackPosition): (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivate::create): (WebCore::MediaPlayerPrivate::registerMediaEngine): (WebCore::doGstInit): (WebCore::MediaPlayerPrivate::isAvailable): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::changePipelineState): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivate::cancelSeek): (WebCore::MediaPlayerPrivate::endPointTimerFired): (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::volumeChangedCallback): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::networkState): (WebCore::MediaPlayerPrivate::readyState): (WebCore::MediaPlayerPrivate::buffered): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::queryBufferingStats): (WebCore::MediaPlayerPrivate::maxTimeSeekable): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytes): (WebCore::MediaPlayerPrivate::cancelLoad): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::mediaLocationChanged): (WebCore::MediaPlayerPrivate::loadNextLocation): (WebCore::MediaPlayerPrivate::loadStateChanged): (WebCore::MediaPlayerPrivate::sizeChanged): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::durationChanged): (WebCore::MediaPlayerPrivate::supportsMuting): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::muteChangedCallback): (WebCore::MediaPlayerPrivate::muteChanged): (WebCore::MediaPlayerPrivate::loadingFailed): (WebCore::MediaPlayerPrivate::setSize): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::repaint): (WebCore::MediaPlayerPrivate::paint): (WebCore::mimeTypeCache): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType): (WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivate::supportsFullscreen): (WebCore::MediaPlayerPrivate::setAutobuffer): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Renamed from WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.h. (WebCore::MediaPlayerPrivate::pipelineReset):
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/VideoSinkGStreamer.cpp. (webkit_video_sink_base_init): (webkit_video_sink_init): (webkit_video_sink_timeout_func): (webkit_video_sink_render): (webkit_video_sink_dispose): (unlock_buffer_mutex): (webkit_video_sink_unlock): (webkit_video_sink_unlock_stop): (webkit_video_sink_stop): (webkit_video_sink_start): (marshal_VOIDMINIOBJECT): (webkit_video_sink_class_init): (webkit_video_sink_new):
  • platform/graphics/gstreamer/VideoSinkGStreamer.h: Renamed from WebCore/platform/graphics/gtk/VideoSinkGStreamer.h.
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Renamed from WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.cpp. (doInit): (webkit_web_src_base_init): (webkit_web_src_class_init): (webkit_web_src_init): (webKitWebSrcFinalize): (webKitWebSrcSetProperty): (webKitWebSrcGetProperty): (webKitWebSrcStop): (webKitWebSrcStart): (webKitWebSrcChangeState): (webKitWebSrcUriGetType): (webKitWebSrcGetProtocols): (webKitWebSrcGetUri): (webKitWebSrcSetUri): (webKitWebSrcUriHandlerInit): (webKitWebSrcNeedDataMainCb): (webKitWebSrcNeedDataCb): (webKitWebSrcEnoughDataMainCb): (webKitWebSrcEnoughDataCb): (webKitWebSrcSeekMainCb): (webKitWebSrcSeekDataCb): (webKitWebSrcSetFrame): (StreamingClient::StreamingClient): (StreamingClient::~StreamingClient): (StreamingClient::willSendRequest): (StreamingClient::didReceiveResponse): (StreamingClient::didReceiveData): (StreamingClient::didFinishLoading): (StreamingClient::didFail): (StreamingClient::wasBlocked): (StreamingClient::cannotShowURL):
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.h: Renamed from WebCore/platform/graphics/gtk/WebKitWebSourceGStreamer.h.
00:20 Changeset [55401] by oliver@apple.com
  • 45 edits in trunk

2010-03-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Refactor named getter function signature to be in line with indexing getter signature
https://bugs.webkit.org/show_bug.cgi?id=35563

This removes the PropertySlot argument from getter functions, and makes them directly
pass the slot base. This makes the semantics for the functions match that of the
indexing getters.

On the down side, this means that we can no longer simply use a proxy function for
JS getters, so we now add another marker value to indicate that a getter is present
and branch accordingly.

Against all rationality sunspider reports this as a perf win, but i suspect it's just noise.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (JSC::::staticValueGetter): (JSC::::staticFunctionGetter): (JSC::::callbackGetter):
  • JavaScriptCore.exp:
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h:
  • runtime/JSFunction.cpp: (JSC::JSFunction::argumentsGetter): (JSC::JSFunction::callerGetter): (JSC::JSFunction::lengthGetter):
  • runtime/JSFunction.h:
  • runtime/NumberConstructor.cpp: (JSC::numberConstructorNaNValue): (JSC::numberConstructorNegInfinity): (JSC::numberConstructorPosInfinity): (JSC::numberConstructorMaxValue): (JSC::numberConstructorMinValue):
  • runtime/PropertySlot.cpp: (JSC::PropertySlot::functionGetter):
  • runtime/PropertySlot.h: (JSC::PropertySlot::getValue): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot):
  • runtime/RegExpConstructor.cpp: (JSC::regExpConstructorDollar1): (JSC::regExpConstructorDollar2): (JSC::regExpConstructorDollar3): (JSC::regExpConstructorDollar4): (JSC::regExpConstructorDollar5): (JSC::regExpConstructorDollar6): (JSC::regExpConstructorDollar7): (JSC::regExpConstructorDollar8): (JSC::regExpConstructorDollar9): (JSC::regExpConstructorInput): (JSC::regExpConstructorMultiline): (JSC::regExpConstructorLastMatch): (JSC::regExpConstructorLastParen): (JSC::regExpConstructorLeftContext): (JSC::regExpConstructorRightContext):
  • runtime/RegExpObject.cpp: (JSC::regExpObjectGlobal): (JSC::regExpObjectIgnoreCase): (JSC::regExpObjectMultiline): (JSC::regExpObjectSource): (JSC::regExpObjectLastIndex):

2010-03-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Refactor named getter function signature to be in line with indexing getter signature
https://bugs.webkit.org/show_bug.cgi?id=35563

Fix method signature and update code as appropriate

  • UserObjectImp.cpp: (UserObjectImp::userObjectGetter):
  • UserObjectImp.h:

2010-03-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Refactor named getter function signature to be in line with indexing getter signature
https://bugs.webkit.org/show_bug.cgi?id=35563

Fix up WebCore to use the new named getter function signature, update the
codegenerator to the new calling convention, and fix the custom bindings.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter):
  • bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter): (WebCore::childFrameGetter): (WebCore::namedItemGetter):
  • bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::nameGetter):
  • bindings/js/JSHTMLAllCollectionCustom.cpp: (WebCore::JSHTMLAllCollection::nameGetter):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::JSHTMLCollection::nameGetter):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter):
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter):
  • bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
  • bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
  • bindings/js/JSMimeTypeArrayCustom.cpp: (WebCore::JSMimeTypeArray::nameGetter):
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::nameGetter):
  • bindings/js/JSNodeListCustom.cpp: (WebCore::JSNodeList::nameGetter):
  • bindings/js/JSPluginArrayCustom.cpp: (WebCore::JSPluginArray::nameGetter):
  • bindings/js/JSPluginCustom.cpp: (WebCore::JSPlugin::nameGetter):
  • bindings/js/JSPluginElementFunctions.cpp: (WebCore::runtimeObjectPropertyGetter):
  • bindings/js/JSPluginElementFunctions.h:
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::nameGetter):
  • bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetList::nameGetter):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/runtime_array.cpp: (JSC::RuntimeArray::lengthGetter):
  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp: (JSC::RuntimeMethod::lengthGetter):
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::fallbackObjectGetter): (JSC::Bindings::RuntimeObject::fieldGetter): (JSC::Bindings::RuntimeObject::methodGetter):
  • bridge/runtime_object.h:
00:10 Changeset [55400] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with one new export, to fix
QtLauncher linkage.

  • symbian/eabi/QtWebKitu.def:

03/01/10:

20:14 Changeset [55399] by jhoneycutt@apple.com
  • 4 edits in trunk/WebKit/win

Remove Windows line endings from some files.

Rubber-stamped by Alice Liu.

  • Interfaces/IWebEmbeddedView.idl:
  • WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::create):
(EmbeddedWidget::~EmbeddedWidget):
(EmbeddedWidget::createWindow):
(EmbeddedWidget::invalidateRect):
(EmbeddedWidget::setFrameRect):
(EmbeddedWidget::frameRectsChanged):
(EmbeddedWidget::setFocus):
(EmbeddedWidget::show):
(EmbeddedWidget::hide):
(EmbeddedWidget::windowClipRect):
(EmbeddedWidget::setParent):
(EmbeddedWidget::attachToWindow):
(EmbeddedWidget::detachFromWindow):
(EmbeddedWidget::didReceiveResponse):
(EmbeddedWidget::didReceiveData):
(EmbeddedWidget::didFinishLoading):
(EmbeddedWidget::didFail):

  • WebCoreSupport/EmbeddedWidget.h:

(EmbeddedWidget::EmbeddedWidget):

20:14 Changeset [55398] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

Some WebKit DOMNode API is unimplemented.
https://bugs.webkit.org/show_bug.cgi?id=35554

Reviewed by Alice Liu.

  • DOMCoreClasses.cpp:

(DOMNode::nextSibling):
Create a DOMNode to wrap m_node's next sibling, and assign it to the
out param 'result'.
(DOMNode::insertBefore):
Query for the DOMNode for newChild, and return early if we fail. Query
refChild for DOMNode. Call insertBefore(), passing the newChild's
WebCore node and refChild's WebCore node (if refChild is non-null). If
we successfully insert the child, fill the result out param with
newChild, ref it, and return S_OK. Otherwise, return E_FAIL.
(DOMNode::removeChild):
Query oldChild for DOMNode. If we fail, return E_FAIL. Call
removeChild(), passing the node's WebCore node. If this fails, return
E_FAIL. Otherwise, fill the result out param with oldChild, ref it, and
return S_OK.

20:08 Changeset [55397] by oliver@apple.com
  • 7 edits in trunk

2010-03-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

PropertySlot::getValue(ExecState, unsigned) unnecessarily converts index to an Identifier
https://bugs.webkit.org/show_bug.cgi?id=35561

Fix this by defining a separate property getter function for index getters. This allows
us to pass an unsigned number without the conversion to an Identifier. We then update
setCustomIndex to take this new getter type.

  • runtime/PropertySlot.h: (JSC::PropertySlot::getValue): (JSC::PropertySlot::setCustom): (JSC::PropertySlot::setCustomIndex):

2010-03-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

PropertySlot::getValue(ExecState, unsigned) unnecessarily converts index to an Identifier
https://bugs.webkit.org/show_bug.cgi?id=35561

Update bindings generation and the few manual indexing getters we have to use
the new PropertySlot API.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::indexGetter):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/runtime_array.cpp: (JSC::RuntimeArray::indexGetter):
  • bridge/runtime_array.h:
18:24 Changeset [55396] by ap@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26520
Accessing a DOM node from a parent window in a child iframe moves the prototype to the child
iframe and resets it in the parent window

Adding a test for a bug that no longer occurs in ToT.

  • fast/dom/cross-frame-node-prototype-expected.txt: Added.
  • fast/dom/cross-frame-node-prototype.html: Added.
  • fast/dom/resources/cross-frame-node-prototype-iframe.html: Added.
17:58 Changeset [55395] by cfleizach@apple.com
  • 2 edits in trunk/WebKitTools

Fixing broken DRT on Leopard/Tiger. Second try.

AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
17:50 Changeset [55394] by cfleizach@apple.com
  • 2 edits in trunk/WebKitTools

Fixing broken DRT on Leopard/Tiger.

AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
17:40 Changeset [55393] by kov@webkit.org
  • 3 edits in trunk/LayoutTests

2010-03-01 Gustavo Noronha Silva <gns@gnome.org>

Rebaseline the two editing tests we stopped skipping - we failed
to take the new caret position result into account while
unskipping these.

  • platform/gtk/editing/selection/5109817-expected.txt:
  • platform/gtk/editing/selection/5354455-2-expected.txt:
17:35 Changeset [55392] by kov@webkit.org
  • 4 edits in trunk

WebKitTools

2010-03-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Seidel.

[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425

Check invoke's return code before releasing the variant, since
there's a chance it won't be properly initialized, leading to
memory corruption, in some cases.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testCallback): (testEnumerate): (testDocumentOpen): (testWindowOpen): (handleCallback):

LayoutTests

2010-03-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Seidel.

[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425

Unskip the tests that failed as a consequence of the memory
corruption.

  • platform/gtk/Skipped:
17:29 Changeset [55391] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by nobody. Build bustage :(

Fix stupid typo that I committed even after David Levin pointed
it out to me :(

https://bugs.webkit.org/show_bug.cgi?id=35553

  • Scripts/webkitpy/layout_tests/port/mac.py:
17:19 Changeset [55390] by cfleizach@apple.com
  • 13 edits
    2 adds in trunk

AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=35514

Reviewed by Darin Adler.

WebCore:

When a table's DOM is changed and an AX Table is not asked first for its children,
it would return wrong information. A table needs to make sure children are up to date in
all methods that can be called from the outside.

Test: platform/mac/accessibility/stale-table-rows.html

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::cellForColumnAndRow):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::clearChildren):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::clearChildren):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::children):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::needsToUpdateChildren):
(WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::clearChildren):
(WebCore::AccessibilityTable::columns):
(WebCore::AccessibilityTable::rows):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cells):
(WebCore::AccessibilityTable::columnCount):
(WebCore::AccessibilityTable::rowCount):
(WebCore::AccessibilityTable::cellForColumnAndRow):

WebKitTools:

Add rowCount, columnCount for tables.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(rowCountCallback):
(columnCountCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):

LayoutTests:

  • platform/mac/accessibility/stale-table-rows-expected.txt: Added.
  • platform/mac/accessibility/stale-table-rows.html: Added.
17:12 Changeset [55389] by eric@webkit.org
  • 4 edits in trunk

2010-03-01 José Millán Soto <jmillan@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Right click does not activate text entry
https://bugs.webkit.org/show_bug.cgi?id=29177

Stop skipping some tests which where failing because of right click
not being correct handled.

  • platform/gtk/Skipped:

2010-03-01 José Millán Soto <jmillan@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Right click does not activate text entry
https://bugs.webkit.org/show_bug.cgi?id=29177

Makes the frame handle the mouse click event before sending the
context menu event.

  • webkit/webkitwebview.cpp: (PopupMenuPositionFunc): Function created to make the popup menu appear in the correct position, especially when invoked from the keyboard. (webkit_web_view_forward_context_menu_event): Mouse click event is sent to frame before creating context menu, PopupMenuPositionFunc used to determine the position where the menu should appear. (webkit_web_view_popup_menu_handler): Improved focused node position detection. Event button set to right button.
17:07 Changeset [55388] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-03-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Work around a bug in Python's subprocess.Popen() that keeps us from
cleaning up DumpRenderTree / test_shell properly when we finish the
tests in new-run-webkit-tests.

https://bugs.webkit.org/show_bug.cgi?id=35553

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
16:56 Changeset [55387] by eric@webkit.org
  • 26 edits
    1 add in trunk

2010-03-01 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Adam Barth.

Convert the zoom mode (page vs. text-only) into a proper enum.
https://bugs.webkit.org/show_bug.cgi?id=35347

  • GNUmakefile.am:
  • WebCore.base.exp: Substituted symbols ZN7WebCore5Frame13setZoomFactorEfNS_8ZoomModeE and ZN7WebCore8Settings11setZoomModeENS_8ZoomModeE for ZN7WebCore5Frame13setZoomFactorEfb and ZN7WebCore8Settings16setZoomsTextOnlyEb, respectively.
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Frame.cpp: (WebCore::Frame::zoomMode): (WebCore::Frame::shouldApplyTextZoom): (WebCore::Frame::shouldApplyPageZoom): (WebCore::Frame::setZoomFactor):
  • page/Frame.h:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setZoomMode):
  • page/Settings.h: (WebCore::Settings::zoomMode):
  • page/ZoomMode.h: Added. (WebCore::):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale):

2010-03-01 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Adam Barth.

Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setZoomLevel):

2010-03-01 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Adam Barth.

Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347

  • webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_apply_zoom_level):

2010-03-01 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Adam Barth.

Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347

  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): (-[WebView _setZoomMultiplier:isTextOnly:]): (-[WebView _realZoomMultiplierIsTextOnly]):

2010-03-01 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Adam Barth.

Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347

  • Api/qwebframe.cpp: (QWebFrame::setTextSizeMultiplier): (QWebFrame::setZoomFactor):
  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):

2010-03-01 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Adam Barth.

Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347

  • WebFrame.cpp: (WebFrame::setTextSizeMultiplier):
  • WebView.cpp: (WebView::setZoomMultiplier): (WebView::zoomMultiplier): (WebView::canMakeTextLarger): (WebView::makeTextLarger): (WebView::canMakeTextSmaller): (WebView::makeTextSmaller): (WebView::notifyPreferencesChanged):

2010-03-01 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Adam Barth.

Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347

  • WebFrame.cpp: (wxWebFrame::IncreaseTextSize): (wxWebFrame::DecreaseTextSize): (wxWebFrame::ResetTextSize):
16:22 Changeset [55386] by eric@webkit.org
  • 9 edits
    1 copy
    5 adds in trunk

2010-03-01 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added test for basic msubsup support.

  • mathml/presentation/subsup.xhtml: Added.
  • platform/mac/mathml/presentation/subsup-expected.checksum: Added.
  • platform/mac/mathml/presentation/subsup-expected.png: Added.
  • platform/mac/mathml/presentation/subsup-expected.txt: Added.

2010-03-01 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added support for the msubsup element that also handles the msup and msub elements.

Test: mathml/presentation/subsup.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/RenderMathMLSubSup.cpp: Added. (WebCore::RenderMathMLSubSup::RenderMathMLSubSup): (WebCore::RenderMathMLSubSup::addChild): (WebCore::RenderMathMLSubSup::stretchToHeight): (WebCore::RenderMathMLSubSup::nonOperatorHeight): (WebCore::RenderMathMLSubSup::layout): (WebCore::RenderMathMLSubSup::baselinePosition):
  • mathml/RenderMathMLSubSup.h: Added. (WebCore::RenderMathMLSubSup::hasBase): (WebCore::RenderMathMLSubSup::):
16:18 Changeset [55385] by jhoneycutt@apple.com
  • 4 edits in trunk/WebKit/win

<rdar://problem/7703368> IWebUIDelegatePrivate::embeddedViewWithArguments
is passed wrong arguments

Reviewed by Adam Roben.

  • Interfaces/IWebUIDelegatePrivate.idl:

Update copyright strings. Added a new key for the plug-in source URL.

  • Interfaces/WebKit.idl:

Update copyright strings.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::createPlugin):
Pass the URL of the plug-in as the source URL. Pass the document's
base URI for the base URL.

16:05 Changeset [55384] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-01 Arno Renevier <arno@renevier.net>

Reviewed by Xan Lopez.

webkit-build could pass unknown arguments to autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=35454

  • Scripts/build-webkit:
15:49 Changeset [55383] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: use dejavu sans mono 11px on linux.

https://bugs.webkit.org/show_bug.cgi?id=35527

  • inspector/front-end/inspector.css:
15:17 Changeset [55382] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-01 Dirk Pranke <dpranke@chromium.org>

Rubber-stamped by Dimitri Glazkov.

Fix breakage from r55372.

https://bugs.webkit.org/show_bug.cgi?id=35549

  • Scripts/webkitpy/layout_tests/port/chromium.py:
14:51 Changeset [55381] by eric@webkit.org
  • 11 edits in trunk

2010-03-01 Thatcher Ulrich <tulrich@google.com>

Reviewed by Darin Fisher.

Fix chromium iframe shims. Add another test case to the
iframes-shims test. After r53637, the plugin widget doesn't get
moved every paint. This used to hide the bug that if an iframe
gets added, the plugin's cutout rectangles don't get updated until
a layout happens.
https://bugs.webkit.org/show_bug.cgi?id=35184

  • plugins/iframe-shims.html: test case that adds an iframe shim dynamically

2010-03-01 Thatcher Ulrich <tulrich@google.com>

Reviewed by Darin Fisher.

Fix chromium iframe shims. Add another test case to the
iframes-shims test. After r53637, the plugin widget doesn't get
moved every paint. This used to hide the bug that if an iframe
gets added, the plugin's cutout rectangles don't get updated until
a layout happens.
https://bugs.webkit.org/show_bug.cgi?id=35184

  • platform/Widget.h: (WebCore::Widget::widgetPositionsUpdated): new virtual method

widgetPositionsUpdated() to notify widgets when other widgets on
the page have been repositioned.

  • rendering/RenderView.cpp: (WebCore::RenderView::updateWidgetPositions): call widgetPositionsUpdated() on the widgets
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::widgetPositionsUpdated): call widgetPositionsUpdated() on the widget
  • rendering/RenderWidget.h:

2010-03-01 Thatcher Ulrich <tulrich@google.com>

Reviewed by Darin Fisher.

Fix chromium iframe shims. Add another test case to the
iframes-shims test. After r53637, the plugin widget doesn't get
moved every paint. This used to hide the bug that if an iframe
gets added, the plugin's cutout rectangles don't get updated until
a layout happens.
https://bugs.webkit.org/show_bug.cgi?id=35184

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::widgetPositionsUpdated): do reportGeometry() to ensure that

the plugin is aware of the positions of cutouts on the page (for iframe shim behavior).

  • src/WebPluginContainerImpl.h:
14:27 Changeset [55380] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

EWS can hang for five hours when compile output is too big
https://bugs.webkit.org/show_bug.cgi?id=35545

  • Scripts/webkitpy/commands/queues.py: Limit uploads to 1MB instead of 5MB. AppEngine seems to not like 5MB uploads. I'm not sure what the limit is. Let's try 1MB for a while and see how it goes.
  • Scripts/webkitpy/networktransaction.py: Tune the default parameters to our exponential backoff. I'm not sure why I picked five hours as the retry limit. That seems way too large.
14:14 Changeset [55379] by barraclough@apple.com
  • 5 edits in trunk

Bug 35537 - put_by_id does will incorrectly cache writes where a specific value exists,

where at the point of caching the same value is being written.

Reviewed by Oliver Hunt.

JavaScriptCore:

When performing a put_by_id that is replacing a property already present on the object,
there are three interesting cases regarding the state of the specific value:

(1) No specific value set - nothing to do, leave the structure in it's current state,

can cache.

(2) A specific value was set, the new put is not of a specified value (i.e. function),

or is of a different specific value - in these cases we need to perform a despecifying
transition to clear the specific value in the structure, but having done so this is a
normal property so as such we can again cache normally.

(3) A specific value was set, and we are overwriting with the same value - in these cases

leave the structure unchanged, but since a specific value is set we cannot cache this
put (we would need the JIT to dynamically check the value being written matched).

Unfortunately, the current behaviour does not match this. the checks for a specific value
being present & the value matching are combined in such a way that in case (2), above we
will unnecessarily prevent the transition being cached, but in case (3) we will incorrectly
fail to prevent caching.

The bug exposes itself if multiple puts of the same specific value are performed to a
property, and erroneously the put is allowed to be cached by the JIT. Method checks may be
generated caching calls of this structure. Subsequent puts performed from JIT code may
write different values without triggering a despecify transition, and as such cached method
checks will continue to pass, despite the value having changed.

  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):

LayoutTests:

Add test case.

  • fast/js/method-check-expected.txt:
  • fast/js/script-tests/method-check.js:

(addOne):
(addOneHundred):
(totalizer.makeCall):

14:07 Changeset [55378] by eric@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-03-01 Kalle Vahlman <zuh@iki.fi>

Reviewed by Gustavo Noronha Silva.

Queue a resize when either of the content dimensions change
https://bugs.webkit.org/show_bug.cgi?id=35489

The check for size changes only queued a resize if both of the content
dimensions change, leaving the widget size out-of-sync if eg. only the
width changes.

  • WebCoreSupport/ChromeClientGtk.cpp:
13:51 Changeset [55377] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-01 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Holger Freyther.

Dist some mathml related files

  • GNUmakefile.am:
13:20 Changeset [55376] by kbr@google.com
  • 43 edits
    2 adds in trunk

2010-03-01 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Integer overflow in WebGL arrays
https://bugs.webkit.org/show_bug.cgi?id=35241

Test: fast/canvas/webgl/webgl-array-invalid-ranges.html

  • bindings/js/JSWebGLArrayBufferConstructor.cpp: (WebCore::constructCanvasArrayBuffer):
  • bindings/js/JSWebGLArrayBufferConstructor.h: (WebCore::construct):
  • bindings/js/JSWebGLArrayHelper.h: (WebCore::setWebGLArrayFromArray):
  • bindings/js/JSWebGLByteArrayConstructor.cpp: (WebCore::constructCanvasByteArray):
  • bindings/js/JSWebGLFloatArrayConstructor.cpp: (WebCore::constructCanvasFloatArray):
  • bindings/js/JSWebGLIntArrayConstructor.cpp: (WebCore::constructCanvasIntArray):
  • bindings/js/JSWebGLShortArrayConstructor.cpp: (WebCore::constructCanvasShortArray):
  • bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp: (WebCore::constructCanvasUnsignedByteArray):
  • bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp: (WebCore::constructCanvasUnsignedIntArray):
  • bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp: (WebCore::constructCanvasUnsignedShortArray):
  • bindings/v8/V8Binding.cpp: (WebCore::toUInt32):
  • bindings/v8/V8Binding.h: (WebCore::toUInt32):
  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: (WebCore::V8WebGLArrayBuffer::constructorCallback):
  • bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::constructWebGLArray): (WebCore::getWebGLArrayElement): (WebCore::setWebGLArrayFromArray): (WebCore::setWebGLArray):
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp: (WebCore::V8WebGLByteArray::constructorCallback):
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: (WebCore::V8WebGLFloatArray::constructorCallback):
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp: (WebCore::V8WebGLIntArray::constructorCallback):
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp: (WebCore::V8WebGLShortArray::constructorCallback):
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: (WebCore::V8WebGLUnsignedByteArray::constructorCallback):
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: (WebCore::V8WebGLUnsignedIntArray::constructorCallback):
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: (WebCore::V8WebGLUnsignedShortArray::constructorCallback):
  • html/canvas/WebGLArray.cpp: (WebCore::WebGLArray::setImpl):
  • html/canvas/WebGLArray.h: (WebCore::WebGLArray::verifySubRange): (WebCore::WebGLArray::clampOffsetAndNumElements):
  • html/canvas/WebGLArrayBuffer.cpp: (WebCore::WebGLArrayBuffer::create): (WebCore::WebGLArrayBuffer::WebGLArrayBuffer): (WebCore::WebGLArrayBuffer::tryAllocate):
  • html/canvas/WebGLArrayBuffer.h:
  • html/canvas/WebGLByteArray.cpp: (WebCore::WebGLByteArray::create): (WebCore::WebGLByteArray::WebGLByteArray): (WebCore::WebGLByteArray::slice):
  • html/canvas/WebGLByteArray.h:
  • html/canvas/WebGLFloatArray.cpp: (WebCore::WebGLFloatArray::create): (WebCore::WebGLFloatArray::WebGLFloatArray): (WebCore::WebGLFloatArray::slice):
  • html/canvas/WebGLFloatArray.h:
  • html/canvas/WebGLIntArray.cpp: (WebCore::WebGLIntArray::create): (WebCore::WebGLIntArray::WebGLIntArray): (WebCore::WebGLIntArray::slice):
  • html/canvas/WebGLIntArray.h:
  • html/canvas/WebGLShortArray.cpp: (WebCore::WebGLShortArray::create): (WebCore::WebGLShortArray::WebGLShortArray): (WebCore::WebGLShortArray::slice):
  • html/canvas/WebGLShortArray.h:
  • html/canvas/WebGLUnsignedByteArray.cpp: (WebCore::WebGLUnsignedByteArray::create): (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray): (WebCore::WebGLUnsignedByteArray::slice):
  • html/canvas/WebGLUnsignedByteArray.h:
  • html/canvas/WebGLUnsignedIntArray.cpp: (WebCore::WebGLUnsignedIntArray::create): (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray): (WebCore::WebGLUnsignedIntArray::slice):
  • html/canvas/WebGLUnsignedIntArray.h:
  • html/canvas/WebGLUnsignedShortArray.cpp: (WebCore::WebGLUnsignedShortArray::create): (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray): (WebCore::WebGLUnsignedShortArray::slice):
  • html/canvas/WebGLUnsignedShortArray.h:

2010-03-01 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Integer overflow in WebGL arrays
https://bugs.webkit.org/show_bug.cgi?id=35241

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt: Added.
  • fast/canvas/webgl/webgl-array-invalid-ranges.html: Added.
13:10 Changeset [55375] by beidson@apple.com
  • 14 edits
    2 adds in trunk

REGRESSION: Telling a WebView to go to its current WebHistoryItem is broken.
<rdar://problem/7699371> and https://bugs.webkit.org/show_bug.cgi?id=35532

Reviewed by Sam Weinig.

WebCore:

Test: fast/loader/api-test-go-to-current-back-forward-item.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadItem): If the current item is the same as the target item, don't

consider this to be a same document navigation.

  • page/Page.cpp:

(WebCore::Page::goToItem): Hard code the "going to the same item as the current item" relationship

as a precondition for stopping all loaders, as that will be a new document load.

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp:

(apiTestGoToCurrentBackForwardItemCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::apiTestGoToCurrentBackForwardItem):

Stubs for now:

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::apiTestGoToCurrentBackForwardItem):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::apiTestGoToCurrentBackForwardItem):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::apiTestGoToCurrentBackForwardItem):

LayoutTests:

  • fast/loader/api-test-go-to-current-back-forward-item-expected.txt: Added.
  • fast/loader/api-test-go-to-current-back-forward-item.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
13:04 Changeset [55374] by robert@webkit.org
  • 2 edits in trunk/WebCore

2010-03-01 Robert Hogan <robert@webkit.org>

Reviewed by nobody, build fix.

Fix --minimal build. Add ENABLE(DATABASE) as compile time condition
for building file GeolocationPositionCache.cpp.

  • page/GeolocationPositionCache.cpp:
12:41 Changeset [55373] by dpranke@chromium.org
  • 12 edits in trunk/WebKitTools

2010-03-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by David Levin.

General cleanup of error handling in new-run-webkit-tests.

Add Port.check_build() call that is separate from Port.check_sys_deps()
(and add a --nocheck-build flag to skip). This breaks a circular
dependency where you would start the layout test helper before
checking sys deps, but checking sys deps was the thing that told
you if your binaries where there.

Also, made Port.check_sys_deps(), start_helper() and stop_helper()
optional by providing default implementations in the base class
rather than requiring ports to implement the routines regardless
of whether or not they were needed.

Lastly, tweak a bunch of log messages to be cleaner, including
changing messages in thirdparty/autoinstall.py to be silent at
the default log level.

http://bugs.webkit.org/show_bug.cgi?id=35416

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/passing.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/thirdparty/autoinstall.py
11:36 Changeset [55372] by dpranke@chromium.org
  • 5 edits in trunk/WebKitTools

2010-03-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by David Levin.

new-chromium-webkit-tests --platform=mac-leopard diffs are backwards
https://bugs.webkit.org/show_bug.cgi?id=35265

Some parts of the code passed arguments as
"actual, expected" and some passed as "expected, actual".
As you might imagine, this lead to great confusion and wrongness.
Standardize on "expected, actual" as that's the order which is
passed to the underlying diff tool.

Based on a patch by Eric Siedel <eric@webkit.org>.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py
11:01 UsingGitWithWebKit edited by robert@webkit.org
(diff)
09:41 Changeset [55371] by jpetsovits@rim.com
  • 6 edits
    4 adds in trunk/WebCore

2010-03-01 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Implement support for paths
https://bugs.webkit.org/show_bug.cgi?id=34366

Adds an implementation of the Path class -
*almost* complete, but not quite because OpenVG
does not provide access to the points in a VGPath
unless one keeps track of all the points by
themselves, which we decided not to do.

Also hooked up to PainterOpenVG and GraphicsContext.

Further introduced is SharedResourceOpenVG, which is
intended as base class for paths and other OpenVG
resources (images, fonts) that WebKit creates as
long-lived objects. We are at a slight disadvantage
here as WebKit doesn't have the concept of resources
belonging to a specific (hardware graphics) context,
which is the reason why EGLDisplayOpenVG had to
provide a current display singleton; this class is
what actually requires that functionality.

Path::addArcTo() uses code by Yong Li <yoli@rim.com>.

  • platform/graphics/Path.cpp:
  • platform/graphics/Path.h:
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::PainterOpenVG): (WebCore::PainterOpenVG::~PainterOpenVG): (WebCore::PainterOpenVG::transformPath): (WebCore::PainterOpenVG::beginPath): (WebCore::PainterOpenVG::addPath): (WebCore::PainterOpenVG::currentPath): (WebCore::PainterOpenVG::drawPath):
  • platform/graphics/openvg/PainterOpenVG.h:
  • platform/graphics/openvg/PathOpenVG.cpp: Added. (WebCore::PlatformPathOpenVG::PlatformPathOpenVG): (WebCore::PlatformPathOpenVG::operator=): (WebCore::PlatformPathOpenVG::~PlatformPathOpenVG): (WebCore::PlatformPathOpenVG::clear): (WebCore::PlatformPathOpenVG::createPath): (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::contains): (WebCore::Path::strokeContains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::strokeBoundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::Path::isEmpty): (WebCore::Path::hasCurrentPoint): (WebCore::Path::debugString): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::length): (WebCore::Path::pointAtLength): (WebCore::Path::normalAngleAtLength):
  • platform/graphics/openvg/PlatformPathOpenVG.h: Added. (WebCore::PlatformPathOpenVG::vgPath):
  • platform/graphics/openvg/SharedResourceOpenVG.cpp: Added. (WebCore::SharedResourceOpenVG::makeSharedContextCurrent): (WebCore::SharedResourceOpenVG::makeCompatibleContextCurrent):
  • platform/graphics/openvg/SharedResourceOpenVG.h: Added.
08:18 Changeset [55370] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed, bring English.lproj/locallizedStrings.js back to binary (UTF) mode.

  • English.lproj/localizedStrings.js:
07:51 Changeset [55369] by jpetsovits@rim.com
  • 7 edits in trunk/WebCore

2010-03-01 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Nikolas Zimmermann.

[OpenVG] Convert from TransformationMatrix to AffineTransform.
https://bugs.webkit.org/show_bug.cgi?id=35445

Dirk Schulze previously introduced AffineTransform as
replacement for most TransformationMatrix occurrences
in GraphicsContext & Co., but did not update the OpenVG
graphics backend as there's no publicly available way
to build it. This commit now takes care of that.

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::concatCTM):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::isNonRotatedAffineTransformation): (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::applyState): (WebCore::PlatformPainterState::applyTransformation): (WebCore::PainterOpenVG::transformation): (WebCore::PainterOpenVG::concatTransformation): (WebCore::PainterOpenVG::setTransformation): (WebCore::PainterOpenVG::scale): (WebCore::PainterOpenVG::rotate): (WebCore::PainterOpenVG::translate): (WebCore::PainterOpenVG::intersectClipRect):
  • platform/graphics/openvg/PainterOpenVG.h:
  • platform/graphics/openvg/VGUtils.cpp: (WebCore::VGMatrix::VGMatrix): (WebCore::VGMatrix::operator AffineTransform): (WebCore::VGMatrix::operator TransformationMatrix): (WebCore::AffineTransform::operator VGMatrix):
  • platform/graphics/openvg/VGUtils.h:
  • platform/graphics/transforms/AffineTransform.h:
07:34 Changeset [55368] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix segfault when drawing NPAPI plugins on Mac

Reviewed by Simon Hausmann.

Don't try to get a contexctRef for a null-pixmap. If the pixmap
size is 0,0 the private pixmap data has not yet been initialized.

07:34 Changeset [55367] by vestbo@webkit.org
  • 5 edits in trunk

Fix the Qt build on Mac OS X/Cocoa 64-bit

Add missing implementation file to resolve JSC symbols.

Use the proper event/drawing-model guards instead of global 64-bit
guard for the NPAPI plugin implementation (view and package).

06:34 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
06:06 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
06:00 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
05:58 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
05:48 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
05:46 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
05:42 QtWebKitTableOfFeatures46 edited by henry.haverinen@nokia.com
(diff)
05:41 QtWebKitTableOfFeatures20 created by henry.haverinen@nokia.com
05:41 QtWebKitFeatures20 edited by henry.haverinen@nokia.com
(diff)
05:40 QtWebKitFeatures20 created by henry.haverinen@nokia.com
05:38 QtWebKit edited by henry.haverinen@nokia.com
(diff)
04:54 Changeset [55366] by kenneth@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog entries not showing the reviewer due to the ChangeLogs
having been made manually without the (OOPS!!!) part.

Rubberstamped by Gustavo Noronha

02:17 Changeset [55365] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-02-27 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: callerScriptName and callerScriptLine should be obfuscated for timeline tests.
https://bugs.webkit.org/show_bug.cgi?id=35478

  • ../../LayoutTests/inspector/timeline-test.js:
02:12 Changeset [55364] by pfeldman@chromium.org
  • 6 edits in trunk

2010-02-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: disable breakpoint upon Shift-click.

https://bugs.webkit.org/show_bug.cgi?id=35477

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._mouseMove):
  • inspector/front-end/textViewer.css: Chromium: remove DevTools part that has been upstreamed.
  • src/js/DevTools.js:
02:07 Changeset [55363] by cjerdonek@webkit.org
  • 6 edits
    1 add
    2 deletes in trunk/WebKitTools

Unreviewed.

Rolling out: http://trac.webkit.org/changeset/55348

https://bugs.webkit.org/show_bug.cgi?id=35163

Rolling out since the changes to autoinstall do not work
with Python 2.4. In particular, ZipFile.extractall() was
added in Python 2.6.

  • Scripts/webkitpy/init.py:
  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/init/init.py: Removed.
  • Scripts/webkitpy/init/autoinstall.py: Removed.
  • Scripts/webkitpy/networktransaction.py:
  • Scripts/webkitpy/networktransaction_unittest.py:
  • Scripts/webkitpy/statusserver.py:
  • Scripts/webkitpy/thirdparty/autoinstall.py: Added.
01:44 Changeset [55362] by cjerdonek@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Fixing up ChangeLog after: http://trac.webkit.org/changeset/55361

Restoring deleted ChangeLog entry, and added new ChangeLog entry
for r55361.

01:19 Changeset [55361] by cjerdonek@webkit.org
  • 5 edits
    3 deletes in trunk/WebKitTools

Unreviewed. Rolling out r55350: http://trac.webkit.org/changeset/55350

https://bugs.webkit.org/show_bug.cgi?id=33639

Need to roll out because this patch (pep8) depends on the newly rewritten
autoinstall.py (r55348), which is breaking for people with Python 2.4:

https://bugs.webkit.org/show_bug.cgi?id=35163#c21

That also needs to be rolled out and will be rolled out next.

02/28/10:

21:14 Changeset [55360] by cjerdonek@webkit.org
  • 3 edits in trunk/WebKitTools

Exempted WebKitTools/Scripts/webkitpy/thirdparty from all
style checks except for the whitespace/carriage_return check
and the pep8 tab and trailing white space checks.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35497

  • Scripts/webkitpy/style/checker.py:
    • Adjusted the _PATH_RULES_SPECIFIER configuration as necessary.
    • Added enough pep8 categories to _all_categories() for the unit tests to pass.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the test_path_rules_specifier() unit test.
12:04 Changeset [55359] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=35496
<rdar://problem/7663444> Opening newsweek.com and youtube.com has become very slow in debug builds

  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getIDRules): (WebCore::CSSRuleSet::getClassRules): (WebCore::CSSRuleSet::getTagRules): Removed consistency checks, as they affect performance too much in this case.
04:57 Changeset [55358] by robert@webkit.org
  • 7 edits
    2 adds in trunk

[Qt] Support private browsing mode in plugins

Add support for NPNVprivateModeBool property in plugins.

See also: https://developer.mozilla.org/En/Supporting_private_browsing_in_plugins

The NPNVprivateModeBool property is supported as scriptable property privateBrowsingEnabled
in the test WebKit plugin. The Mac platform also supports a cachedPrivateBrowsingEnabled
property implemented in the test plugin. This allows the Layout test plugins/private-browsing-mode.html
to retrieve the previous value of NPNVprivateModeBool in the test plugin. Due to the platform-specific
overhead required to support this bespoke property it is not implemented as part of this patch, instead
a new test, plugins/private-browsing-mode-2.html, is added to ensure that setting and resetting privateBrowsingEnabled works as expected.

http://bugs.webkit.org/show_bug.cgi?id=33180

02/27/10:

23:09 Changeset [55357] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-02-27 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector shouldn't show a white color box for "-webkit-line-break: after-white-space"
https://bugs.webkit.org/show_bug.cgi?id=33478

  • inspector/front-end/StylesSidebarPane.js:
14:45 Changeset [55356] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-27 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Unskip test that we seem to pass now.

  • platform/gtk/Skipped:
14:26 Changeset [55355] by xan@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-02-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add platform results for plugin test and unskip it. The filename
of our test plugin is not the same than the one expected in the
default result file.

  • platform/gtk/Skipped:
  • platform/gtk/plugins/plugin-javascript-access-expected.txt: Added.
12:46 ApplicationsGtk edited by peterbloomfield@bellsouth.net
(diff)
12:16 ApplicationsGtk edited by peterbloomfield@bellsouth.net
info about the WebKit option in the Balsa email client (diff)
09:47 Changeset [55354] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip new test introduced in r55353 because of missing drag&drop support.

  • platform/qt/Skipped: fast/css/user-drag-none.html skipped.
04:39 Changeset [55353] by mitz@apple.com
  • 5 edits
    2 adds in trunk

<rdar://problem/7696607> Links do not respect -webkit-user-drag: none
https://bugs.webkit.org/show_bug.cgi?id=35475

Reviewed by Maciej Stachowiak.

WebCore:

Test: fast/css/user-drag-none.html

  • page/DragController.cpp:

(WebCore::DragController::mayStartDragAtEventLocation): Added a node
parameter. The image drag check is done against the node, rather than
than against the hit test result. This prevents a non-draggable image
with an auto-draggable ancestor from being dragged alone. The link drag
check now ignores links that are -webkit-user-drag: none.

  • page/DragController.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::shouldDragAutoNode): Pass the current node
to mayStartDragAtEventLocation().

LayoutTests:

  • fast/css/user-drag-none-expected.txt: Added.
  • fast/css/user-drag-none.html: Added.
02:48 Changeset [55352] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-02-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: REGRESSION: hangs when scrolling in Resource pane.

https://bugs.webkit.org/show_bug.cgi?id=35216

  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.highlight): (WebInspector.TextEditorHighlighter.prototype._highlightInChunks): (WebInspector.TextEditorHighlighter.prototype._highlightLines):
00:57 Changeset [55351] by xan@webkit.org
  • 4 edits in trunk

WebCore:

2010-02-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Abort XEmbed plugin initialization if our parent is not anchored
in a widget hierarchy. This can happen when the browser window is
destroyed while the plugin is being loaded, and will lead to a
crash.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart):

LayoutTests:

2010-02-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

We now pass this test, unskip.

  • platform/gtk/Skipped:
00:24 Changeset [55350] by cjerdonek@webkit.org
  • 5 edits
    3 adds in trunk/WebKitTools

Added Python style checking to check-webkit-style using
the third-party pep8 module (via autoinstall).

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=33639

  • Scripts/webkitpy/style/checker.py:
    • Added PYTHON to FileType.
    • Updated ProcessorDispatcher to return a PythonProcessor for *.py files.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the ProcessorDispatcher unit tests for *.py files.
  • Scripts/webkitpy/style/processors/python.py: Added.
    • Added PythonProcessor class.
  • Scripts/webkitpy/style/processors/python_unittest.py: Added.
    • Added PythonProcessor unit tests.
  • Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
    • Added a sample Python file to test the PythonProcessor.process() code path (since pep8 accepts a file path).
  • Scripts/webkitpy/style/unittests.py:
    • Updated the style unit test file to import python_unittest.py.
  • Scripts/webkitpy/style_references.py:
    • Adjusted style references to import pep8.
00:10 Changeset [55349] by eric@webkit.org
  • 4 edits in trunk/WebKit/mac

2010-02-27 Jing Jin <jjin@apple.com>

Reviewed by Timothy Hatcher.

Move implementation of Bug 35449 into WebFramePrivate.

  • WebView/WebFrame.h:
  • WebView/WebFrame.mm: (-[WebFrame setAllowScrollersToOverlapContent:]): (-[WebFrame setAlwaysHideHorizontalScroller:]): (-[WebFrame setAlwaysHideVerticalScroller:]):
  • WebView/WebFramePrivate.h:
00:04 Changeset [55348] by cjerdonek@webkit.org
  • 6 edits
    3 adds
    1 delete in trunk/WebKitTools

Rewrote autoinstall.py to support unzipping *.zip files after
download, unzipping and extracting *.tar.gz files after download,
and copying installed files to a destination directory.

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=35163

These changes will allow us to autoinstall pep8.py from the web
and to put our third-party autoinstalled code in an explicit
directory like webkitpy/thirdparty/autoinstalled. They should
also speed up imports from autoinstalled *.zip packages slightly
since *.pyc files cannot be generated when importing from
zipped packages.

  • Scripts/webkitpy/init.py:
    • Updated the autoinstall lines to use the new autoinstall methods.
    • Added pep8.py to the list of auto-installed packages.
  • Scripts/webkitpy/bugzilla.py:
    • Updated mechanize import path.
  • Scripts/webkitpy/init/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
  • Scripts/webkitpy/init/autoinstall.py: Added.
    • Added AutoInstaller class.
    • Added sample testing usage to main.
  • Scripts/webkitpy/networktransaction.py:
    • Updated mechanize import path.
  • Scripts/webkitpy/networktransaction_unittest.py:
    • Updated mechanize import path.
  • Scripts/webkitpy/statusserver.py:
    • Updated mechanize import path.
  • Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
    • Replaced with rewritten autoinstall in init/autoinstall.py.

02/26/10:

23:01 Changeset [55347] by pfeldman@chromium.org
  • 13 edits in trunk

2010-02-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: reload inspected page on Cmd+R / Ctrl+R / F5 key event in inspector.
Drive-by fix for couple of minor front-end problems.

https://bugs.webkit.org/show_bug.cgi?id=35434

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::reloadPage):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.reloadPage):
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.copyText): (.WebInspector.InspectorFrontendHostStub.prototype.canAttachWindow):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._paintLine):
  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown): (WebInspector.toggleAttach):

WebKit/chromium

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsCanAttachWindow):
  • src/WebDevToolsFrontendImpl.h:
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl): (devtools.InspectorBackendImpl.prototype.toggleNodeSearch):
22:22 Changeset [55346] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-02-26 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Verify that the Nodes being enumerated are HTML elements.

https://bugs.webkit.org/show_bug.cgi?id=35463

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
22:06 Changeset [55345] by eric@webkit.org
  • 1 edit
    5 adds in trunk/WebCore

2010-02-26 Leandro Pereira <leandro@profusion.mobi>

Reviewed by NOBODY.

Add EFL port files to platform/efl.
http://webkit.org/b/35087

  • platform/efl/ScrollbarEfl.cpp: Added.
  • platform/efl/EventLoopEfl.cpp: Added.
  • platform/efl/PlatformKeyboardEventEfl.cpp: Added.
  • platform/efl/DragImageEfl.cpp: Added.
  • platform/efl/PlatformMouseEventEfl.cpp: Added.
21:49 Changeset [55344] by eric@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

2010-02-26 Leandro Pereira <leandro@profusion.mobi>

Reviewed by NOBODY.

Add EFL port files to platform/efl.
http://webkit.org/b/35087

  • platform/efl/CursorEfl.cpp: Added.
  • platform/efl/LocalizedStringsEfl.cpp: Added.
  • platform/efl/SearchPopupMenuEfl.cpp: Added.
21:32 Changeset [55343] by eric@webkit.org
  • 1 edit
    5 adds in trunk/WebCore

2010-02-26 Leandro Pereira <leandro@profusion.mobi>

Reviewed by NOBODY.

Add EFL port files to page/efl.
http://webkit.org/b/35087

  • WebCore/page/efl/DragControllerEfl.cpp: Added.
  • WebCore/page/efl/FrameEfl.cpp: Added.
  • WebCore/page/efl/AccessibilityObjectEfl.cpp: Added.
  • WebCore/page/efl/EventHandlerEfl.cpp: Added.
21:16 Changeset [55342] by eric@webkit.org
  • 1 edit
    6 adds in trunk/WebCore

2010-02-26 Leandro Pereira <leandro@profusion.mobi>

Reviewed by NOBODY.

Add EFL port files to platform/efl.
http://webkit.org/b/35087

  • WebCore/platform/efl/LoggingEfl.cpp: Added.
  • WebCore/platform/efl/ScrollbarThemeEfl.cpp: Added.
  • WebCore/platform/efl/TemporaryLinkStubs.cpp: Added.
  • WebCore/platform/efl/ScrollViewEfl.cpp: Added.
  • WebCore/platform/efl/SharedBufferEfl.cpp: Added.
  • WebCore/platform/efl/DragDataEfl.cpp: Added.
20:59 Changeset [55341] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-02-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Change the default port for new-run-webkit-tests when running on
a Mac from 'chromium-mac' to 'mac'. Add a '--chromium' switch to
pick up the default platform-specific version of chromium instead.

https://bugs.webkit.org/show_bug.cgi?id=35462

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
20:42 Changeset [55340] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-02-26 Leandro Pereira <leandro@profusion.mobi>

Reviewed by NOBODY.

Add EFL port files to platform/efl.
http://webkit.org/b/35087

  • WebCore/platform/efl/RenderThemeEfl.cpp: Added.
19:53 Changeset [55339] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

010-02-26 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix

third time's the charm getting this path right?

  • pywebsocket/mod_pywebsocket/standalone.py:
19:53 Changeset [55338] by eric@webkit.org
  • 1 edit
    5 adds in trunk/WebCore

2010-02-26 Leandro Pereira <leandro@profusion.mobi>

Reviewed by NOBODY.

Add EFL port files to platform/efl.
http://webkit.org/b/35087

  • WebCore/platform/efl/PlatformWheelEventEfl.cpp: Added.
  • WebCore/platform/efl/FileChooserEfl.cpp: Added.
  • WebCore/platform/efl/ContextMenuEfl.cpp: Added.
  • WebCore/platform/efl/PlatformScreenEfl.cpp: Added.
  • WebCore/platform/efl/WidgetEfl.cpp: Added.
19:42 Changeset [55337] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, build fix.

  • pywebsocket/mod_pywebsocket/standalone.py:
19:27 Changeset [55336] by dumi@chromium.org
  • 1 edit
    1 move
    1 add in trunk/WebKitTools

Moving the script to the right location.

Reviewed by NOBODY (OOPS!).

  • pywebsocket/mod_pywebsocket: Added.
  • pywebsocket/mod_pywebsocket/standalone.py: Copied from WebKitTools/pywebsocket/standalone.py.
  • pywebsocket/standalone.py: Removed.
19:20 Changeset [55335] by eric@webkit.org
  • 7 edits in trunk

2010-02-26 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Expose an API for ports to add schemes to the mixed content whitelist
https://bugs.webkit.org/show_bug.cgi?id=35438

Add a notion of a "secure" scheme that doesn't trigger mixed content
warnings. Let folks register new secure schemes in the same way they
can register "local" schemes.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent):
  • page/SecurityOrigin.cpp: (WebCore::secureSchemes): (WebCore::SecurityOrigin::registerURLSchemeAsSecure): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsSecure):
  • page/SecurityOrigin.h:

2010-02-26 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Expose an API for ports to add schemes to the mixed content whitelist
https://bugs.webkit.org/show_bug.cgi?id=35438

Expose registerURLSchemeAsSecure via the WebKit API.

  • public/WebSecurityPolicy.h:
  • src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::registerURLSchemeAsSecure):
18:59 Changeset [55334] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-26 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayerQt: artifacts and wrong transformOrigin
This was due to wrong way of applying cache-mode and transformation
on a graphics-item with HTML. Cache-mode should be updated
when the content type updates, even if it was the same cache-mode

https://bugs.webkit.org/show_bug.cgi?id=35382

Test URL attached to the bug now works correctly.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::computeTransform): (WebCore::GraphicsLayerQtImpl::flushChanges):
18:51 Changeset [55333] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, fixing the license.

  • pywebsocket/standalone.py:
18:43 Changeset [55332] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-26 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Qt/Mac: Revert null timer removal (r51105)
https://bugs.webkit.org/show_bug.cgi?id=35396

r51105 removed the null timer event of the carbon event model. This however
breaks the flash of many sites.

Applying patch suggested by Girish Ramakrishnan in bug comment #1.

  • plugins/PluginView.h:
  • plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::platformStart): (WebCore::PluginView::handleMouseEvent): (WebCore::PluginView::nullEventTimerFired): (WebCore::PluginView::mousePosForPlugin):
18:25 Changeset [55331] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-26 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compile error with 3d-canvas
Replaced a direct gl call with a getProcAddress call
https://bugs.webkit.org/show_bug.cgi?id=35448

No new tests.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::blendColor):
18:08 Changeset [55330] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-02-26 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kenneth Rohde Christiansen.

[BREWMP] Port EventHandler
https://bugs.webkit.org/show_bug.cgi?id=34796

Add platform-specific code required to implement EventHandler.

  • page/brew/EventHandlerBrew.cpp: Added. (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::accessKeyModifiers):
17:51 Changeset [55329] by dumi@chromium.org
  • 1 edit
    2 adds in trunk/WebKitTools

Adding pywebsocket/standalone.py back to fix the Chromium webkit
canaries. Once all layout tests pass, we can get in the patch that
moves this directorty to WebKitTools/Scripts, update all Chromium
scripts, and revert this patch.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35464

  • pywebsocket: Added.
  • pywebsocket/standalone.py: Added.
17:51 Changeset [55328] by eric@webkit.org
  • 1 edit
    8 adds in trunk/WebCore

2010-02-26 Leandro Pereira <leandro@profusion.mobi>

Reviewed by NOBODY.

Add EFL port files to platform/efl.
http://webkit.org/b/35087

  • WebCore/platform/efl/ClipboardEfl.cpp: Added.
  • WebCore/platform/efl/PopupMenuEfl.cpp: Added.
  • WebCore/platform/efl/SharedTimerEfl.cpp: Added.
  • WebCore/platform/efl/RenderThemeEfl.h: Added.
  • WebCore/platform/efl/Language.cpp: Added.
  • WebCore/platform/efl/CookieJarEfl.cpp: Added.
  • WebCore/platform/efl/MIMETypeRegistryEfl.cpp: Added.
17:34 Changeset [55327] by eric@webkit.org
  • 2 edits in trunk

2010-02-26 Arno Renevier <arno@renevier.net>

Reviewed by Gustavo Noronha Silva.

[Gtk] ignore WebKit/gtk/docs/GNUmakefile.in in .gitignore
https://bugs.webkit.org/show_bug.cgi?id=35424

  • .gitignore:
17:17 Changeset [55326] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-26 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Nate Chapin

To fire each event handler registered on an SVG node once per
event, Chromium needs an implementation of wasCreatedFromMarkup
added to V8LazyEventListener.h that matches the one in
WebKit/WebCore/bindings/js/JSLazyEventListener.h.

This patch adds such a matching implementation of wasCreatedFromMarkup
to V8LazyEventListener.h.

https://bugs.webkit.org/show_bug.cgi?id=35325

  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::wasCreatedFromMarkup):
17:00 Changeset [55325] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-26 Arno Renevier <arno@renevier.net>

Reviewed by Gustavo Noronha Silva.

[Gtk] use geoclue_position_get_position_async to get geolocation position.
https://bugs.webkit.org/show_bug.cgi?id=35355

No new tests, behaviour depends on system.

  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::startUpdating): (WebCore::GeolocationServiceGtk::get_position):
  • platform/gtk/GeolocationServiceGtk.h:
16:44 Changeset [55324] by mthole@apple.com
  • 6 edits in trunk/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=35449
Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content.

Patch by Jing Jin <jjin@apple.com> on 2010-02-26
Reviewed by Timothy Hatcher.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]): Allows scrollbars to
overlap with the document and re-layouts the document.
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]): Hides the horizontal scrollbar.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]): Hides the vertical scrollbar.
(-[WebDynamicScrollBarsView contentViewFrame]): Calculates the appropriate frame based
on allowScrollersToOverlapContent.
(-[WebDynamicScrollBarsView tile]): If allowScrollersToOverlapContent is YES, set the
contentView's frame so it overlaps with the scrollbar.
(-[WebDynamicScrollBarsView updateScrollers]): Take into account hideHorizontalScroller
and hideVerticalScroller.
(-[WebDynamicScrollBarsView reflectScrolledClipView:]): set drawsBackground to NO when
scrollbars are overlapping with content, so we don't get trails during scrollbar draw updates.

  • WebView/WebDynamicScrollBarsViewInternal.h:
  • WebView/WebFrame.h:
  • WebView/WebFrame.mm:

(-[WebFrame setAllowScrollersToOverlapContent:]): Hook for [WebDynamicScrollBarsView setAllowScrollersToOverlapContent:]
(-[WebFrame setAlwaysHideHorizontalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]
(-[WebFrame setAlwaysHideVerticalScroller:]): Hook for [WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]

16:32 Changeset [55323] by yaar@chromium.org
  • 2 edits in trunk/WebCore

2010-02-26 Yaar Schnitman <yaar@chromium.org>

Chromium Win build fix.

  • WebCore.gyp/WebCore.gyp: Added missing file to action input.
16:19 Changeset [55322] by barraclough@apple.com
  • 12 edits
    1 delete in trunk/JavaScriptCore

Rubber Stamped by Geoff Garen.

Remove wrec. All builds should have switched to yarr by now.

(JSC::RegExp::match):

  • runtime/RegExp.h:
  • wrec: Removed.
  • wrec/CharacterClass.cpp: Removed.
  • wrec/CharacterClass.h: Removed.
  • wrec/CharacterClassConstructor.cpp: Removed.
  • wrec/CharacterClassConstructor.h: Removed.
  • wrec/Escapes.h: Removed.
  • wrec/Quantifier.h: Removed.
  • wrec/WREC.cpp: Removed.
  • wrec/WREC.h: Removed.
  • wrec/WRECFunctors.cpp: Removed.
  • wrec/WRECFunctors.h: Removed.
  • wrec/WRECGenerator.cpp: Removed.
  • wrec/WRECGenerator.h: Removed.
  • wrec/WRECParser.cpp: Removed.
  • wrec/WRECParser.h: Removed.
  • wscript:
15:47 Changeset [55321] by brettw@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-02-26 Brett Wilson <brettw@chromium.org>

Fix chromium build. This test's expectation became obsolete with
recent changes to KURL which my previous change brings Chromium's
port in compliance with.

  • tests/KURLTest.cpp: (ComponentCase::TEST):
15:26 Changeset [55320] by yaar@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-02-26 Yaar Schnitman <yaar@chromium.org>

Chromium build fix.

  • features.gypi: Added missing new variable enable_svg.
15:18 Changeset [55319] by brettw@chromium.org
  • 3 edits in trunk/WebCore

2010-02-12 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth.

Update the Google-URL version of KURL and the V8 bindings to the new
behavior of KURL.IsStandard.

https://bugs.webkit.org/show_bug.cgi?id=34859

This is covered by fast/dom/Window/invalid-protocol.html

  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::protocolAccessorSetter):
  • platform/KURLGoogle.cpp: (WebCore::KURL::setProtocol): (WebCore::KURL::isHierarchical):
15:13 Changeset [55318] by yaar@chromium.org
  • 4 edits
    1 add in trunk

2010-02-25 Yaar Schnitman <yaar@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Auto-generate and split DerivedSourcesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=33048

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/action_derivedsourcesallinone.py: Added.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Removed.
14:53 Changeset [55317] by barraclough@apple.com
  • 2 edits in trunk/WebCore
  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapInstance::invokeMethod):

Reviewed by NOBODY (Build fix following r55312).

14:39 Changeset [55316] by kov@webkit.org
  • 8 edits in trunk

WebKit/gtk

2009-12-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170

Add new signal to report when the document load is finished for a
frame.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFinishDocumentLoad):
  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):

WebKitTools

2010-02-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170

Fix reporting of unload handlers, so that it is emitted where
needed, not after it.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadFinished): (webViewDocumentLoadFinished): (createWebView):

LayoutTests

2010-02-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Needs proper reporting of frame loader callbacks, in DRT
https://bugs.webkit.org/show_bug.cgi?id=32170

Unskip tests that now pass.

  • LayoutTests/platform/gtk/http/tests/loading/redirect-with-no-location-crash-expected.txt: rebaselined.
  • platform/gtk/Skipped:
14:30 Changeset [55315] by ap@apple.com
  • 4 edits
    2 adds in trunk

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=35450
Crash when a Java array property accessor raises an exception

Test: java/inaccessible-class.html. Adding with a FAIL result, because this doesn't raise
an exception in Firefox. I don't know what the formally correct behavior is, but it's good
to avoid crashing.

  • bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): Check if the result is null before interpreting it as an object or array.
14:27 Changeset [55314] by krit@webkit.org
  • 3 edits in trunk/WebCore

2010-02-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Extend AffineTransform to mapQuad
https://bugs.webkit.org/show_bug.cgi?id=35444

This makes mapQuad available for AffineTransform. So that platforms
can make use of it after the switch from TransformationMatrix to
AffineTransform in GraphicsContext.

  • platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::mapRect): mapRect already did the calculation for mapQuad but gave back the

boundingBox of the resulting FloatQuad.

(WebCore::AffineTransform::mapQuad):

  • platform/graphics/transforms/AffineTransform.h:
14:26 Changeset [55313] by beidson@apple.com
  • 2 edits in trunk/WebCore

Arrow keys do not scroll source view in Resources pane or Scripts pane.
<rdar://problem/7594367> and https://bugs.webkit.org/show_bug.cgi?id=34356

Reviewed by Pavel Feldman.

Handle vertical scrolling in the Text Viewer:

  • inspector/front-end/TextViewer.js:

(WebInspector.TextViewer): Listen for the keydown event.
(WebInspector.TextViewer.prototype._handleKeyDown): If the event has no modifiers and refers

to an arrow key, scroll. The horizontal values were ripped from the default "pixels per scroll line"
value in ScrollBar.h.

14:21 Changeset [55312] by barraclough@apple.com
  • 24 edits
    1 add in trunk

Bug 35401 - Fix handling of errors in handling calls over bridge,
where base object bridge-type does not match method bridge-type.

Reviewed by Alexey Proskuryakov.

The code assumes users will only attempt to invoke a Java method
on a Java base object, etc.
Add language specific subclasses of RuntimeMethod, and pass the
RuntimeMethod into invokeMethod, so we can typecheck before
casting. Throw an exception on type mismatch.

WebCore:

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):new class to distinguish this type of RuntimeMethod.
(JSC::Bindings::CInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(JSC::Bindings::CInstance::invokeMethod): dynamically check the type of the RuntimeMethod.

  • bridge/c/c_instance.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaRuntimeMethod::JavaRuntimeMethod): new class to distinguish this type of RuntimeMethod.
(JavaInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(JavaInstance::invokeMethod): dynamically check the type of the RuntimeMethod.

  • bridge/jni/jsc/JavaInstanceJSC.h:
  • bridge/jsc/BridgeJSC.h:
  • bridge/objc/objc_instance.h:
  • bridge/objc/objc_instance.mm:

(ObjcRuntimeMethod::ObjcRuntimeMethod): new class to distinguish this type of RuntimeMethod.
(ObjcInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(ObjcInstance::invokeMethod): dynamically check the type of the RuntimeMethod.
(ObjcInstance::invokeObjcMethod): new method, takes an ObjcMethod* as an argument so that we don't need to dynamically determine the type.

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::callObjCFallbackObject): use new invokeObjcMethod method.

  • bridge/runtime_method.cpp:

(JSC::callRuntimeMethod): pass RuntimeMethod as argument to invokeMethod, rather than its MethodList.

  • bridge/runtime_object.cpp:

(JSC::RuntimeObject::methodGetter): use new getMethod method.

WebKit/mac:

  • Plugins/Hosted/ProxyInstance.h:
  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::PluginRuntimeMethod::PluginRuntimeMethod): new class to distinguish this type of RuntimeMethod.
(WebKit::ProxyInstance::getMethod): create an appropriate sublclass of RuntimeMethod.
(WebKit::ProxyInstance::invokeMethod): dynamically check the type of the RuntimeMethod.

LayoutTests:

  • java/java-and-plugins.html: Add tests for passing mismatched this objects to methdods.
14:17 Changeset [55311] by oliver@apple.com
  • 5 edits in trunk

2010-02-26 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff Garen.

Make the lookup table generator include an explicit cast to expected
type of the function. We do this because otherwise the blind intptr_t
cast that is subsequently applied allows incorrectly typed functions
to be inserted into the table, where they will only fail at runtime.
This change makes such errors produce a compile time failure.

14:07 Changeset [55310] by eric@webkit.org
  • 4 edits
    1 copy
    13 adds in trunk

2010-02-26 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Basic tests for munder, munderover, and mover elements.

  • mathml/presentation/over.xhtml: Added.
  • mathml/presentation/under.xhtml: Added.
  • mathml/presentation/underover.xhtml: Added.
  • platform/mac/mathml/presentation/over-expected.checksum: Added.
  • platform/mac/mathml/presentation/over-expected.png: Added.
  • platform/mac/mathml/presentation/over-expected.txt: Added.
  • platform/mac/mathml/presentation/under-expected.checksum: Added.
  • platform/mac/mathml/presentation/under-expected.png: Added.
  • platform/mac/mathml/presentation/under-expected.txt: Added.
  • platform/mac/mathml/presentation/underover-expected.checksum: Added.
  • platform/mac/mathml/presentation/underover-expected.png: Added.
  • platform/mac/mathml/presentation/underover-expected.txt: Added.

2010-02-26 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added basic support for the munder, munderover, and mover elements.

Tests: mathml/presentation/over.xhtml

mathml/presentation/under.xhtml
mathml/presentation/underover.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/RenderMathMLUnderOver.cpp: Added. (WebCore::RenderMathMLUnderOver::RenderMathMLUnderOver): (WebCore::RenderMathMLUnderOver::addChild): (WebCore::getOffsetHeight): (WebCore::RenderMathMLUnderOver::stretchToHeight): (WebCore::RenderMathMLUnderOver::layout): (WebCore::RenderMathMLUnderOver::baselinePosition): (WebCore::RenderMathMLUnderOver::nonOperatorHeight):
  • mathml/RenderMathMLUnderOver.h: Added. (WebCore::RenderMathMLUnderOver::hasBase): (WebCore::RenderMathMLUnderOver::):
13:48 Changeset [55309] by tonikitoo@webkit.org
  • 3 edits in trunk

[Gtk] Make DRT EventSender::keyDown to consider 'hardware_keycode' field when synthesizing an event.
https://bugs.webkit.org/show_bug.cgi?id=35432

Patch by Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Gustavo Noronha.

When a directional key-press event (arrow keys, End, Home, PageUp,
PageDown, etc) is synthesized by DRT's EventSender and it targets
an editor (e.g. <input type=text>, <textare>, etc), event is processed
by WebCore::EventHandler. On the other hand, if event target is not
an editor, event is bubbled up to Gtk+ for processing. In such cases,
if 'hardware_keycode' is not provided at event synthesize time
its processing fails (at some point in gtk_bindings_activate_event),
and no scroll action is performed.

Unskip fast/events/node-event-anchor-lock.html

  • DumpRenderTree/win/EventSender.cpp:

(keyDownCallback):

  • platform/gtk/Skipped:
13:43 Changeset [55308] by senorblanco@chromium.org
  • 2 edits in trunk/WebCore

2010-02-24 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Adler.

This CL implements a simple ad-hoc parser for CSS rgb() values.
If it fails, it returns false and the normal lex/yacc parser will
be invoked.


https://bugs.webkit.org/show_bug.cgi?id=35362

Covered by fast/canvas/canvas-bg.html, fast/canvas/canvas-bg-zoom.html,
and many more.

  • css/CSSParser.cpp: (WebCore::parseInt): (WebCore::CSSParser::parseColor):
13:40 Changeset [55307] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-02-26 Darin Fisher <darin@chromium.org>

Fix mac warning (that gets treated as an error in the chromium build).

  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cookiesEnabled):
13:33 Changeset [55306] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=35419
3D canvas did not update when WTF_USE_ACCELERATED_COMPOSITING
was enabled but not from run-time settings. Added run-time
check that compositing is enabled.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::markContextChanged):
13:24 Changeset [55305] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-02-26 Antonio Gomes <tonikitoo@webkit.org>

Complementary commit of r55300. Missing "notify::" to signal name.

  • tests/testwebview.c: (test_webkit_web_view_grab_focus):
13:16 Changeset [55304] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>

Reviewed by Kenneth Rohde Christiansen.

Compilation failed because functions glSampleCoverage, glBlendEquation
and glActiveTexture were not available.
https://bugs.webkit.org/show_bug.cgi?id=35423

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::sampleCoverage):
12:59 Changeset [55303] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-26 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=35380
Fixed compilation error when WTF_USE_ACCELERATED_COMPOSITING=0

  • css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval):
12:42 Changeset [55302] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-26 Nicholas Young <nicholas.young@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Incorrect painting after a size changed.
https://bugs.webkit.org/show_bug.cgi?id=35412

No new tests. Bug fix in backend.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::paint): Provide the source rectangle, rather than inferring it.
12:41 Changeset [55301] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rebaseline of platform-specific results for test.

SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421

  • platform/gtk/svg/custom/use-on-clip-path-with-transformation-expected.txt:
12:32 Changeset [55300] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/gtk

[GTK] Make webkit_web_view_grab_focus to active focus controller.
https://bugs.webkit.org/show_bug.cgi?id=35402

Reviewed by Xan Lopez.
Patch by Antonio Gomes <tonikitoo@webkit.org>

When programatically setting focus to an element in an inner document,
calling "hasFocus()" from this document returns FALSE, because
document's FocusController is not activated. It does not happen
if |document| is the main document.

Making webkit_web_view_grab_focus to actually activate the FocusController,
fixes the issue.

  • tests/testwebview.c:

(server_callback):
(test_webkit_web_view_grab_focus):

  • webkit/webkitwebview.cpp:

(webkit_web_view_grab_focus):

12:24 Changeset [55299] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-02-26 Nicholas Young <nicholas.young@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Incorrect handling of MIME types in Media Player
https://bugs.webkit.org/show_bug.cgi?id=35413

No new tests. Bug fix in backend.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::supportsType): Corrected logic.
12:20 Changeset [55298] by alex@webkit.org
  • 2 edits in trunk/WebKit/gtk

Unreviewed.

Reverted last patch (r55295), it causes problems with the frames.

  • WebCoreSupport/ChromeClientGtk.cpp:
12:08 Changeset [55297] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-02-26 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=35418
[Gtk] Every table, including layout tables, should be exposed as a table

This patch exposes layout tables as tables. (Addressing the problematic table
hierarchy remains to be done.)

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::determineAccessibilityRole):
11:50 Changeset [55296] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-02-26 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Simon Hausmann.

[Qt] Symbian specific getCPUTime implemetation
https://bugs.webkit.org/show_bug.cgi?id=34742

Default implementation doesn't work on Symbian devices.
This change adds a proper implementation by
asking thread execution time from the current thread.

  • runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
10:54 Changeset [55295] by alex@webkit.org
  • 2 edits in trunk/WebKit/gtk

[GTK] Some region checks in scroll are not required
https://bugs.webkit.org/show_bug.cgi?id=35142

Reviewed by Xan Lopez.

Removes some of the operations checking the moved and invalidated
regions when scrolling, it is done already in
gdk_window_move_region.

  • WebCoreSupport/ChromeClientGtk.cpp:
10:51 Changeset [55294] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

Rubber-stamped by Adele Peterson.

Update Security Group Members list.

  • security/security-group-members.html:
10:47 Changeset [55293] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-26 Dirk Schulze <krit@webkit.org>

Unreviewed LayoutTest fix.

SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421

This corrects a result of a new clip test for SVG.

  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt:
10:37 Changeset [55292] by dglazkov@chromium.org
  • 2 edits in trunk/WebKitTools

2010-02-26 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Levin.

new-webkit-run-tests: Extraneous parenthesis in websocket_server.py
https://bugs.webkit.org/show_bug.cgi?id=35436

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed extra paren.
10:13 Changeset [55291] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

[Qt] Update platform specific expected file after r55289.

  • platform/qt/svg/css/clippath-with-shadow-expected.txt:
10:09 Changeset [55290] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-02-26 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

XSSAuditor is super super super slow
https://bugs.webkit.org/show_bug.cgi?id=35373

In this patch, we separate the decoding cache for the page's URL and
form data. Previously, we used the same cache for both, which caused
us miss the cache every time when the page had form data (because the
cache only stored one entry). When the form data is large, we were
wasting a lot of time canonicalizing.

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h:
10:02 Changeset [55289] by krit@webkit.org
  • 43 edits
    2 adds
    2 deletes in trunk

2010-02-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421

Move SVGResourceClipper to RenderSVGResourceClipper. This follows the changes
of Masker and helps to clean up the SVG code. Code snippets from SVGClipPathElement
and SVGResourceClipper got combined in RenderSVGResourceClipper. DRT results are
more readable for clipPath's now. It's possible to see the unit type of clipper, as
well as it's childs instead of just one path.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderSVGResource.h: (WebCore::):
  • rendering/RenderSVGResourceClipper.cpp: Added. (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::invalidateClients): (WebCore::RenderSVGResourceClipper::invalidateClient): (WebCore::RenderSVGResourceClipper::applyResource): (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h: Added. (WebCore::RenderSVGResourceClipper::renderName): (WebCore::RenderSVGResourceClipper::resourceType): (WebCore::RenderSVGResourceClipper::clipPathUnits):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::deregisterFromResources):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources):
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::svgAttributeChanged): (WebCore::SVGClipPathElement::childrenChanged): (WebCore::SVGClipPathElement::createRenderer):
  • svg/SVGClipPathElement.h: (WebCore::SVGClipPathElement::isValid):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
  • svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isMarker):
  • svg/graphics/SVGResourceClipper.cpp: Removed.
  • svg/graphics/SVGResourceClipper.h: Removed.

2010-02-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceClipper needs to be moved to RenderSVGResourceClipper
https://bugs.webkit.org/show_bug.cgi?id=35421

Update results after the move of SVGResourceClipper. Results are better
readable and more sensible now.

  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/css/clippath-with-shadow-expected.txt:
  • platform/mac/svg/custom/clip-path-child-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-display-none-child-expected.txt:
  • platform/mac/svg/custom/clip-path-href-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/mac/svg/custom/clip-path-units-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-with-transform-expected.txt:
  • platform/mac/svg/custom/empty-clip-path-expected.txt:
  • platform/mac/svg/custom/focus-ring-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.txt:
  • platform/mac/svg/custom/recursive-clippath-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/text-clip-expected.txt:
  • platform/mac/svg/custom/visibility-override-clip-expected.txt:
  • platform/mac/svg/filters/filter-clip-expected.txt:
  • svg/custom/use-clipped-transform-expected.txt:
08:53 Changeset [55288] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-02-26 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Simon Hausmann.

Fix documentation of QWebSettings::setUserStyleSheetUrl method

The base 64 data in the exemple shows a not valid code.

REGRESSION: QWebSettings::setUserStyleSheetUrl is not working with a data URL (Base64)
https://bugs.webkit.org/show_bug.cgi?id=34802

  • Api/qwebsettings.cpp:
08:52 Changeset [55287] by benm@google.com
  • 6 edits in trunk

The element that a touchevent is dispatched to isn't always right
https://bugs.webkit.org/show_bug.cgi?id=35431

Reviewed by Kenneth Rohde Christiansen.

WebCore:

The element that touch events are dispatched on is not always the
correct one, as the cached m_touchEventTarget member is only updated
when the first element of the PlatformTouchEvent touch list is in the
TouchPressed state.

This patch changes this behavior to dispatch the event to the target
of the touch that caused the event to be generated and eliminates the
m_touchEventTarget in favour of using the touch target hashmap. It also
simplifies the way in which the touchTargets list is generated as we
no longer have m_touchEventTarget (which was used previously to build
the list). The new behavior matches the observed behavior of the
iPhone and Android.

  • page/EventHandler.cpp:

(WebCore::assembleTargetTouches): Added. new function to build the

targetTouches list. Filters a list of touches (passed) about
another given touch.

(WebCore::EventHandler::handleTouchEvent): Remove the

m_touchEventTarget member, and simplify the generation of the
TouchLists that are bundled with the TouchEVent object. Dispatch
the event to the target of the touch that caused the event to be
fired.

  • page/EventHandler.h: Remove m_touchEventTarget.

LayoutTests:

  • fast/events/touch/basic-single-touch-events-expected.txt: Updated

the targetTouches list expections.

  • fast/events/touch/script-tests/basic-single-touch-events.js: ditto.

(verifyTouch):

08:51 Changeset [55286] by cjerdonek@webkit.org
  • 4 edits
    1 move
    1 add in trunk/WebKitTools

Moved pywebsocket into the webkitpy/thirdparty directory and added
an associated README.webkit file to the pywebsocket directory.
This makes pywebsocket more consistent with the other third-party
Python code in our repository.

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=35198

  • Scripts/run-webkit-tests:
    • Updated paths to pywebsocket.
  • Scripts/run-webkit-websocketserver:
    • Updated paths to pywebsocket.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
    • Updated paths to pywebsocket.
  • Scripts/webkitpy/thirdparty/pywebsocket: Copied from WebKitTools/pywebsocket.
  • Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added.
    • Added a file containing information about the contents of the pywebsocket directory. This will make it easier to understand where the third-party code came from and what local changes have been made.
  • pywebsocket: Removed.
  • pywebsocket/COPYING: Removed.
  • pywebsocket/MANIFEST.in: Removed.
  • pywebsocket/README: Removed.
  • pywebsocket/example: Removed.
  • pywebsocket/example/echo_client.py: Removed.
  • pywebsocket/example/echo_wsh.py: Removed.
  • pywebsocket/mod_pywebsocket: Removed.
  • pywebsocket/mod_pywebsocket/init.py: Removed.
  • pywebsocket/mod_pywebsocket/dispatch.py: Removed.
  • pywebsocket/mod_pywebsocket/handshake.py: Removed.
  • pywebsocket/mod_pywebsocket/headerparserhandler.py: Removed.
  • pywebsocket/mod_pywebsocket/memorizingfile.py: Removed.
  • pywebsocket/mod_pywebsocket/msgutil.py: Removed.
  • pywebsocket/mod_pywebsocket/standalone.py: Removed.
  • pywebsocket/mod_pywebsocket/util.py: Removed.
  • pywebsocket/setup.py: Removed.
  • pywebsocket/test: Removed.
  • pywebsocket/test/config.py: Removed.
  • pywebsocket/test/mock.py: Removed.
  • pywebsocket/test/run_all.py: Removed.
  • pywebsocket/test/test_dispatch.py: Removed.
  • pywebsocket/test/test_handshake.py: Removed.
  • pywebsocket/test/test_memorizingfile.py: Removed.
  • pywebsocket/test/test_mock.py: Removed.
  • pywebsocket/test/test_msgutil.py: Removed.
  • pywebsocket/test/test_util.py: Removed.
  • pywebsocket/test/testdata: Removed.
  • pywebsocket/test/testdata/handlers: Removed.
  • pywebsocket/test/testdata/handlers/blank_wsh.py: Removed.
  • pywebsocket/test/testdata/handlers/origin_check_wsh.py: Removed.
  • pywebsocket/test/testdata/handlers/sub: Removed.
  • pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Removed.
  • pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Removed.
  • pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Removed.
  • pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Removed.
  • pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Removed.
  • pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Removed.
08:36 Changeset [55285] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-02-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Fisher.

Fix the handling of updates to #hash fragments to check for differences
post-canonicalization rather than comparing pre- to post-. Chromium
had a bug where we would set the #hash on an about:blank URL and generate
an onload event because we thought the URL (not just the fragment) was
changing.

http://bugs.webkit.org/show_bug.cgi?id=35180

  • fast/loader/about-blank-hash-change-expected.txt: Added.
  • fast/loader/about-blank-hash-change.html: Added.

2010-02-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Fisher.

Fix the handling of updates to #hash fragments to check for differences
post-canonicalization rather than comparing pre- to post-. Chromium
had a bug where we would set the #hash on an about:blank URL and generate
an onload event because we thought the URL (not just the fragment) was
changing.

http://bugs.webkit.org/show_bug.cgi?id=35180

Test: fast/loader/about-blank-hash-change.html

  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::hashAccessorSetter):
08:19 Changeset [55284] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-02-26 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Eric Seidel.

Changed the diff_parser module to log to a module-specific
logging.logger rather than the root logger.

https://bugs.webkit.org/show_bug.cgi?id=35391

  • Scripts/webkitpy/diff_parser.py:
07:48 Changeset [55283] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-02-26 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

texImage2D and texSubImage2D taking ImageData ignore flipY and premultiplyAlpha
https://bugs.webkit.org/show_bug.cgi?id=34459

  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html: Added.

2010-02-26 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

texImage2D and texSubImage2D taking ImageData ignore flipY and premultiplyAlpha
https://bugs.webkit.org/show_bug.cgi?id=34459

Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2D): Apply flipY and premultiplyAlpha to the texture data. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): Extract data from ImageData, applying flipY and premultiplyAlpha.
  • platform/graphics/GraphicsContext3D.h: Add function extractImageData declaration.
07:30 Changeset [55282] by eric@webkit.org
  • 11 edits in trunk

2010-02-26 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

Set viewport to canvas size upon context creation
https://bugs.webkit.org/show_bug.cgi?id=35057

  • fast/canvas/webgl/bug-32888.html: Remove the gl.viewport call since it's done when WebGLRenderingContext is created.
  • fast/canvas/webgl/gl-get-calls-expected.txt: The read-back viewport size should match the canvas size instead of (0, 0, 0, 0).
  • fast/canvas/webgl/gl-get-calls.html: Remove the gl.viewport call since it's done when WebGLRenderingContext is created.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html: Ditto.
  • fast/canvas/webgl/tex-sub-image-2d.html: Ditto.
  • fast/canvas/webgl/texImage2DImageDataTest.html: Ditto.
  • fast/canvas/webgl/triangle.html: Ditto.
  • fast/canvas/webgl/viewport-unchanged-upon-resize.html: Ditto.

2010-02-26 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

Set viewport to canvas size upon context creation
https://bugs.webkit.org/show_bug.cgi?id=35057

Covered by existing tests, in particular fast/canvas/webgl/gl-get-calls.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Set the viewport size to match the canvas size.
06:56 Changeset [55281] by ossy@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] fast/multicol/client-rects.html fails in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=34959

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/fast: Added.
  • platform/qt/fast/multicol: Added.
  • platform/qt/fast/multicol/client-rects-expected.txt: Platform specific expected file added.
  • platform/qt/Skipped: fast/multicol/client-rects.html unskipped.
06:49 Changeset [55280] by ossy@webkit.org
  • 6 edits in trunk

[Qt] LayoutTestController.numberOfPages() should have default parameters
https://bugs.webkit.org/show_bug.cgi?id=35428

Reviewed by Kenneth Rohde Christiansen.

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: maxViewWidth and maxViewHeight moved to

LayoutTestController to converge to platform independent implementation.
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: Initialization of maxViewWidth and maxViewHeight added.
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
    • Default parameters for LayoutTestController.numberOfPages() added.
    • maxViewWidth and maxViewHeight members added.

LayoutTests:

  • platform/qt/Skipped: printing/css2.1 tests unskipped.
04:07 Changeset [55279] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-26 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425

  • platform/gtk/Skipped: Skipping another crasher related to bug 35425.
04:04 Changeset [55278] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-02-26 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: touch InspectorController to force front-end deployment.

  • inspector/InspectorController.cpp:
03:26 Changeset [55277] by pfeldman@chromium.org
  • 20 edits in trunk

2010-02-26 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: While the current timeline view in DevTools provides a great overview of
things happening, we should make it easier to locate the cause of an event,
e.g., link to JS where relevant.
Caller info support for all kind of Timeline events and new Function Call event will be added.
JSC can be patched the same way as it will be done for V8.

https://bugs.webkit.org/show_bug.cgi?id=33995

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
  • bindings/js/ScriptCallStack.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willCallFunction): (WebCore::InspectorTimelineAgent::didCallFunction): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::instanceCount):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord): (WebCore::TimelineRecordFactory::createFunctionCallData):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/Popover.js: (WebInspector.Popover.prototype.hideWhenClicked): (WebInspector.Popover.prototype._positionElement):
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._formatRecord): (WebInspector.TimelinePanel.prototype._getRecordDetails): (WebInspector.TimelinePanel.prototype.reset): (WebInspector.TimelinePanel.prototype._closeRecordDetails): (WebInspector.TimelinePanel.prototype._onScroll): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelineRecordListRow.prototype._createCell): (WebInspector.TimelineRecordListRow.prototype._createRow): (WebInspector.TimelineRecordListRow.prototype._createLinkRow): (WebInspector.TimelineRecordListRow.prototype._generateBubbleContent): (WebInspector.TimelineRecordListRow.prototype._onClick):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.js: (WebInspector.linkifyResourceAsNode):
03:04 Changeset [55276] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-02-26 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed. Skip failing tests.

Refine LayoutTests/printing/css2.1 with numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35334

  • platform/qt/Skipped:
02:40 Changeset [55275] by hamaji@chromium.org
  • 19 edits
    1 copy
    1 add in trunk/LayoutTests

2010-02-26 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Refine LayoutTests/printing/css2.1 with numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=35334

Small refinements were done in paged-media-test-utils.js.

Note that WebKit doesn't pass page-break-after-003 for now.

  • printing/css2.1/README.txt:
  • printing/css2.1/page-break-after-000-expected.txt:
  • printing/css2.1/page-break-after-000.html:
  • printing/css2.1/page-break-after-001-expected.txt:
  • printing/css2.1/page-break-after-001.html:
  • printing/css2.1/page-break-after-002-expected.txt:
  • printing/css2.1/page-break-after-002.html:
  • printing/css2.1/page-break-after-003-expected.txt: Added.
  • printing/css2.1/page-break-after-003.html: Added.
  • printing/css2.1/page-break-after-004-expected.txt:
  • printing/css2.1/page-break-after-004.html:
  • printing/css2.1/page-break-before-000-expected.txt:
  • printing/css2.1/page-break-before-000.html:
  • printing/css2.1/page-break-before-001-expected.txt:
  • printing/css2.1/page-break-before-001.html:
  • printing/css2.1/page-break-before-002-expected.txt:
  • printing/css2.1/page-break-before-002.html:
  • printing/css2.1/page-break-inside-000-expected.txt:
  • printing/css2.1/page-break-inside-000.html:
  • printing/resources/paged-media-test-utils.js: (appendResult): (pageNumberForElementShouldBe): (numberOfPagesShouldBe): (runPrintingTest):
02:05 Changeset [55274] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-02-26 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

[GTK] plugins/setProperty.html fails on 64bit Release
https://bugs.webkit.org/show_bug.cgi?id=35425

  • platform/gtk/Skipped: Skipping crasher.
01:56 Changeset [55273] by eric@webkit.org
  • 7 edits in trunk

2010-02-26 Jamey Hicks <jamey.hicks@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl()

Enables the use of alternate Web Inspector frontends by changing
the location of the frontend.

This is required so that the Web Inspector may be run from an
external process or an external tool such as Eclipse or Aptana may
be used instead of the in-process Web Inspector UI.

https://bugs.webkit.org/show_bug.cgi?id=35340

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings): (QWebSettings::setInspectorUrl): (QWebSettings::inspectorUrl):
  • Api/qwebsettings.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::createPage):

2010-02-26 Jamey Hicks <jamey.hicks@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl()

Enables the use of alternate Web Inspector frontends by changing
the location of the frontend. The location is specified by providing

-inspector-url url

as an argument to QtLauncher.

This is required so that the Web Inspector may be run from an
external process or an external tool such as Eclipse or Aptana may
be used instead of the in-process Web Inspector UI.

https://bugs.webkit.org/show_bug.cgi?id=35340

  • QtLauncher/main.cpp: (LauncherWindow::init): (LauncherApplication::handleUserOptions):
01:28 BuildingQtOnSymbian edited by jocelyn.turcotte@nokia.com
(diff)
01:08 Changeset [55272] by philn@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-02-26 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

Adding two GTK layout test results for a new tests
added in r55259 and r55260.

  • platform/gtk/svg/custom/use-on-clip-path-with-transformation-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt.
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt: Added.
00:39 Changeset [55271] by ossy@webkit.org
  • 20 edits
    6 adds
    2 deletes in trunk

Unreviewed. Roll-out r55263 because it broke fast/forms/textarea-type-spaces-pretty-diff.html.
https://bugs.webkit.org/show_bug.cgi?id=30946

WebCore:

  • editing/CompositeEditCommand.cpp:

(WebCore::isWhitespace):
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::input):

  • editing/InsertTextCommand.h:
  • editing/htmlediting.cpp:
  • editing/htmlediting.h:

LayoutTests:

  • editing/execCommand/5142012-3-expected.txt:
  • editing/inserting/rebalance-whitespace-1-expected.txt: Removed.
  • editing/inserting/rebalance-whitespace-1.html: Removed.
  • editing/pasteboard/5521237-expected.txt:
  • platform/mac/editing/execCommand/5482023-expected.checksum:
  • platform/mac/editing/execCommand/5482023-expected.png: Added.
  • platform/mac/editing/execCommand/5482023-expected.txt:
  • platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
  • platform/mac/editing/execCommand/remove-formatting-2-expected.png: Added.
  • platform/mac/editing/execCommand/remove-formatting-expected.checksum:
  • platform/mac/editing/execCommand/remove-formatting-expected.png: Added.
  • platform/mac/editing/execCommand/remove-formatting-expected.txt:
  • platform/mac/editing/inserting/editable-html-element-expected.checksum:
  • platform/mac/editing/inserting/editable-html-element-expected.png: Added.
  • platform/mac/editing/inserting/editable-html-element-expected.txt:
  • platform/mac/editing/pasteboard/4989774-expected.checksum:
  • platform/mac/editing/pasteboard/4989774-expected.png: Added.
  • platform/mac/editing/pasteboard/4989774-expected.txt:
  • platform/mac/editing/selection/4983858-expected.checksum:
  • platform/mac/editing/selection/4983858-expected.png: Added.
  • platform/mac/editing/selection/4983858-expected.txt:
Note: See TracTimeline for information about the timeline view.