Timeline


and

03/07/10:

22:55 Changeset [55656] by hamaji@chromium.org

2010-03-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style: false positive for empty loop
https://bugs.webkit.org/show_bug.cgi?id=35717

  • Scripts/webkitpy/style/processors/cpp.py:
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
21:02 Changeset [55655] by tkent@chromium.org

2010-03-07 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add AccessibilityController and AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=35774

Add AccessibilityController and AccessibilityUIElement classes,
which are going to be used by DumpRenderTree Chromium port. These
files are based on:

  • src/webkit/tools/test_shell/accessibility_controller.{cc,h} and
  • src/webkit/tools/test_shell/accessibility_ui_element.{cc,h} of Chromium rev.40492.
  • DumpRenderTree/chromium/AccessibilityController.cpp: Added.
  • DumpRenderTree/chromium/AccessibilityController.h: Added.
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp: Added.
  • DumpRenderTree/chromium/AccessibilityUIElement.h: Added.
19:56 Changeset [55654] by levin@chromium.org

Chromium Linux build fix.

  • platform/graphics/chromium/FontPlatformDataLinux.h: Add "class String" since a debug

only method returns a String.

19:06 Changeset [55653] by mrowe@apple.com

Chromium build fix.

WebCore:

  • platform/chromium/ClipboardChromium.cpp: Include Image.h since we're using WebCore::Image.

WebKit/chromium:

  • src/ChromiumBridge.cpp: Include SharedBuffer.h since WebCore::SharedBuffer is being used.
19:02 Changeset [55652] by mrowe@apple.com

Windows build fix.

  • WebKitPrefix.h: Include CoreFoundation/CoreFoundation.h from the Windows prefix header

since some WebCore headers rely on the types declared within being available via the prefix
header.

18:57 Changeset [55651] by mrowe@apple.com

Gtk build fix.

  • platform/network/soup/ResourceHandleSoup.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
18:51 Changeset [55650] by mrowe@apple.com

Gtk build fix.

  • platform/graphics/gtk/ImageGtk.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
18:38 Changeset [55649] by mrowe@apple.com

Fix builds where USE_CG_SHADING is set.

  • platform/graphics/cg/GradientCG.cpp: Include wtf/RetainPtr.h since WTF::RetainPtr is used when USE_CG_SHADING is set.
18:33 Changeset [55648] by mrowe@apple.com

Windows build fix. Add some required includes.

  • platform/graphics/win/ImageCGWin.cpp:
  • platform/network/cf/ResourceHandleCFNet.cpp:
  • platform/win/ClipboardWin.cpp:
18:29 Changeset [55647] by mrowe@apple.com

Gtk build fix.

  • platform/graphics/GraphicsContext.h: Include wtf/PassOwnPtr.h since some platforms use WTF::PassOwnPtr in this header.
18:27 Changeset [55646] by mrowe@apple.com

Qt build fix.

  • platform/network/qt/ResourceHandleQt.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
18:23 Changeset [55645] by mrowe@apple.com

Chromium build fix.

  • src/ResourceHandle.cpp: Include SharedBuffer.h since WebCore::SharedBuffer is being used.
18:18 Changeset [55644] by mrowe@apple.com

Gtk build fix.

  • platform/gtk/ClipboardGtk.cpp: Include Imageh since we're using WebCore::Image.
18:17 Changeset [55643] by mrowe@apple.com

Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.

Rubber-stamped by Cameron Zwarich.

WebCore:

  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedFont.cpp:
  • loader/CachedImage.cpp:
  • loader/CachedResource.cpp:
  • loader/CachedResource.h:
  • loader/CachedScript.cpp:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/icon/IconFetcher.cpp:
  • loader/loader.cpp:
  • page/Page.cpp:
  • platform/graphics/Image.cpp:
  • platform/graphics/Image.h:
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  • platform/graphics/cg/PDFDocumentImage.cpp:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/mac/ImageMac.mm:

WebKit/mac:

  • Misc/WebIconDatabase.mm:
18:05 Changeset [55642] by mrowe@apple.com

Chromium build fix.

  • platform/chromium/ChromiumDataObject.h: Include SharedBuffer.h since the inline constructor of this

class means that the pointed-to type of the RefPtr member must be available.

18:05 Changeset [55641] by mrowe@apple.com

Qt build fix.

  • platform/network/qt/DnsPrefetchHelper.cpp: Include PlatformString.h since we're using WebCore::String.
17:53 Changeset [55640] by tkent@chromium.org

2010-03-07 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Fix a bug that validity.valueMissing for a radio button with required
in a form element always returns true.
https://bugs.webkit.org/show_bug.cgi?id=35472

Add tests for radio buttons in a form element, and merge an existing
radio button test to ValidityState-valueMissing-radio.html.

  • fast/forms/ValidityState-valueMissing-007-expected.txt: Removed.
  • fast/forms/ValidityState-valueMissing-007.html: Removed.
  • fast/forms/ValidityState-valueMissing-radio-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-radio.html: Added.
  • fast/forms/script-tests/ValidityState-valueMissing-radio.js: Added.

2010-03-07 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Fix a bug that validity.valueMissing for a radio button with required
in a form element always returns true.
https://bugs.webkit.org/show_bug.cgi?id=35472

Test: fast/forms/ValidityState-valueMissing-radio.html

  • html/HTMLInputElement.cpp: (WebCore::checkedRadioButtons): Move the location to be used by valueMissing(). (WebCore::HTMLInputElement::valueMissing): Use checkedRadioButtons() instead of document()->checkedRadioButtons().
17:52 Changeset [55639] by mrowe@apple.com

Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.

Rubber-stamped by Cameron Zwarich.

WebCore:

  • bindings/objc/DOM.mm:
  • loader/CachedImage.h:
  • loader/EmptyClients.h:
  • platform/graphics/GlyphPageTreeNode.cpp:
  • platform/text/CString.h:
  • platform/text/String.cpp:
  • platform/text/mac/TextCodecMac.cpp:
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/filters/SVGFEImage.h:

WebKit/mac:

  • Misc/WebNSPasteboardExtras.mm:
17:52 Changeset [55638] by mrowe@apple.com

Completely remove two files that were deleted in r55635 from the Xcode project.

  • WebCore.xcodeproj/project.pbxproj:
17:26 Changeset [55637] by weinig@apple.com

Remove inconsistent "Too few arguments" handling for window.atob() and window.btoa()
https://bugs.webkit.org/show_bug.cgi?id=35848

Reviewed by Dan Bernstein.

WebCore:

  • Take the opportunity to fully autogenerate window.atob() and window.btoa().
  • bindings/js/JSDOMWindowCustom.cpp:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::btoa):
(WebCore::DOMWindow::atob):

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/Window/atob-btoa-expected.txt:
  • fast/dom/Window/atob-btoa.html:
17:02 PythonGuidelines edited by cjerdonek@webkit.org
Minor updates. Added a FIXME to include upgrade instructions. (diff)
10:15 Changeset [55636] by mitz@apple.com

<rdar://problem/7722008> Column breaking ignores floats
https://bugs.webkit.org/show_bug.cgi?id=35837

Reviewed by Simon Fraser.

WebCore:

Test: fast/multicol/float-truncation.html

Introduce an earlier column-break if otherwise a float that could fit
inside a single column will be split between columns.

It is still possible for floats to be needlessly broken if initially
they fit in the column, but normal flow truncation then shortens the
column.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::visibleTopOfHighestFloatExtendingBelow): Added.
Returns the visible top of the highest descendant float that visibly
extends below the given y offset, ignoring floats that are taller than
the given maximum height.
(WebCore::RenderBlock::layoutColumns): If the initial column height
would cause a float to be split, truncate above the float.

  • rendering/RenderBlock.h:

LayoutTests:

  • fast/multicol/float-truncation-expected.txt: Added.
  • fast/multicol/float-truncation.html: Added.
08:59 Changeset [55635] by dimich@chromium.org

Not reviewed. Revert of r55593 which caused a regression of worker-cloneports.html.

REGRESSION(55593?): fast/workers/worker-cloneport.html is timing out on Leopard
https://bugs.webkit.org/show_bug.cgi?id=35819

WebCore:

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDatabaseCallback.cpp: Removed.
  • bindings/js/JSDatabaseCallback.h: Removed.
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
  • bindings/v8/custom/V8DatabaseCallback.h: Removed.
  • dom/Document.cpp:

(WebCore::Document::postTask):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):

  • storage/Database.h:
  • storage/DatabaseCallback.h: Removed.
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):

  • workers/WorkerContext.h:

LayoutTests:

  • fast/frames/resources/sandboxed-iframe-storage-allowed.html:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-storage-expected.txt:
  • storage/open-database-creation-callback-expected.txt: Removed.
  • storage/open-database-creation-callback-isolated-world-expected.txt: Removed.
  • storage/open-database-creation-callback-isolated-world.html: Removed.
  • storage/open-database-creation-callback.html: Removed.
  • platform/qt/Skipped:
  • platform/mac-leopard/Skipped: Enable the temporarily disabled test back.
00:16 Changeset [55634] by eric@webkit.org

2010-03-07 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Small performance fix in the QScriptConverter::toString().

The QByteArray was replaced by the QVarLengthArray which doesn't
have to allocate any memory on heap.

[Qt] QScriptConverter::toString() should use QVarLengthArray instead of QByteArray
https://bugs.webkit.org/show_bug.cgi?id=35577

  • qt/api/qscriptconverter_p.h: (QScriptConverter::toString):

03/06/10:

21:44 Changeset [55633] by mrowe@apple.com

Remove unnecessary includes of wtf/Platform.h. This is already pulled in by config.h.

Rubber-stamped by Sam Weinig.

JavaScriptCore:

Remove unnecessary includes of wtf/Platform.h. This is already pulled in by config.h.

  • API/APICast.h:
  • API/JSCallbackFunction.cpp:
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:
  • API/JSValueRef.cpp:
  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
  • assembler/AbstractMacroAssembler.h:
  • assembler/AssemblerBuffer.h:
  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/CodeLocation.h:
  • assembler/LinkBuffer.h:
  • assembler/MIPSAssembler.h:
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARMv7.h:
  • assembler/MacroAssemblerCodeRef.h:
  • assembler/MacroAssemblerMIPS.h:
  • assembler/MacroAssemblerX86.h:
  • assembler/MacroAssemblerX86Common.h:
  • assembler/MacroAssemblerX86_64.h:
  • assembler/RepatchBuffer.h:
  • assembler/X86Assembler.h:
  • jit/JIT.h:
  • jit/JITCode.h:
  • jit/JITInlineMethods.h:
  • jit/JITStubs.h:
  • os-win32/stdint.h:
  • runtime/JSAPIValueWrapper.h:
  • runtime/JSImmediate.h:
  • wtf/ASCIICType.h:
  • wtf/StdLibExtras.h:
  • wtf/VMTags.h:
  • yarr/RegexCompiler.h:
  • yarr/RegexInterpreter.h:
  • yarr/RegexJIT.h:
  • yarr/RegexParser.h:
  • yarr/RegexPattern.h:

WebCore:

Remove unnecessary includes of wtf/Platform.h. This is already pulled in by config.h.

  • accessibility/AccessibilityObject.h:
  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizerLibxml2.cpp:
  • dom/XMLTokenizerQt.cpp:
  • editing/TextAffinity.h:
  • loader/FrameLoaderClient.h:
  • page/FocusController.cpp:
  • page/FrameTree.cpp:
  • page/Geolocation.h:
  • page/PositionCallback.h:
  • page/PositionErrorCallback.h:
  • platform/Cursor.h:
  • platform/FileSystem.h:
  • platform/FloatConversion.h:
  • platform/KeyboardCodes.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformTouchPoint.h:
  • platform/SuddenTermination.h:
  • platform/Widget.h:
  • platform/graphics/Color.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/openvg/PainterOpenVG.h:
  • platform/graphics/openvg/SurfaceOpenVG.h:
  • platform/network/ResourceHandleClient.h:
  • platform/text/Base64.cpp:
  • rendering/style/SVGRenderStyle.h:
  • xml/XSLTProcessor.cpp:
  • xml/XSLTProcessorLibxslt.cpp:
  • xml/XSLTProcessorQt.cpp:

WebKit/qt:

Remove unnecessary includes of wtf/Platform.h. This is already pulled in by the prefix header.

  • WebCoreSupport/EditCommandQt.cpp:
19:31 Changeset [55632] by weinig@apple.com

Move debug only JS wrapper-set tracking code into its own file.
https://bugs.webkit.org/show_bug.cgi?id=35839

Reviewed by Dan Bernstein.

  • GNUmakefile.am: Added new files.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSDOMBinding.cpp:

(WebCore::cacheDOMObjectWrapper):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::cacheDOMNodeWrapper):
(WebCore::takeWrappers):
(WebCore::updateDOMNodeDocument):
Updated for new signature for willCacheWrapper and didUncacheWrapper.

  • bindings/js/JSDOMWrapper.cpp: Added.

(WebCore::DOMObject::~DOMObject):
(WebCore::DOMObject::defineOwnProperty):
Moved from JSDOMBinding.cpp.

  • bindings/js/JSDebugWrapperSet.cpp: Added.

(WebCore::JSDebugWrapperSet::shared):
(WebCore::JSDebugWrapperSet::JSDebugWrapperSet):

  • bindings/js/JSDebugWrapperSet.h: Added.

(WebCore::JSDebugWrapperSet::add):
(WebCore::JSDebugWrapperSet::remove):
(WebCore::JSDebugWrapperSet::contains):
(WebCore::JSDebugWrapperSet::willCacheWrapper):
(WebCore::JSDebugWrapperSet::didUncacheWrapper):
Moved from JSDOMBinding.cpp.

16:38 Changeset [55631] by weinig@apple.com

Rubber-stamped by Dan Bernstein.

Move DOMObjectHashTableMap, DOMWrapperWorld and WebCoreJSClientData into
their own files.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/DOMObjectHashTableMap.cpp: Copied from bindings/js/JSDOMBinding.cpp.
  • bindings/js/DOMObjectHashTableMap.h: Copied from bindings/js/JSDOMBinding.h.

(WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
(WebCore::DOMObjectHashTableMap::get):

  • bindings/js/DOMWrapperWorld.cpp: Copied from bindings/js/JSDOMBinding.cpp.

(WebCore::forgetWorldOfDOMNodesForDocument):

  • bindings/js/DOMWrapperWorld.h: Copied from bindings/js/JSDOMBinding.h.

(WebCore::DOMWrapperWorld::create):
(WebCore::DOMWrapperWorld::rememberDocument):
(WebCore::DOMWrapperWorld::forgetDocument):
(WebCore::DOMWrapperWorld::isNormal):
(WebCore::debuggerWorld):
(WebCore::pluginWorld):
(WebCore::currentWorld):
(WebCore::Document::getWrapperCache):

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/WebCoreJSClientData.h: Copied from bindings/js/JSDOMBinding.h.

(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::~WebCoreJSClientData):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::getAllWorlds):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):

  • bindings/js/WorkerScriptController.cpp:
15:01 Changeset [55630] by mitz@apple.com

Rubber-stamped by Sam Weinig.

Remove an unused method.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): Changed comment.
(WebCore::RenderBlock::floatRect): Removed.

  • rendering/RenderBlock.h: Removed floatRect().
13:45 Changeset [55629] by pfeldman@chromium.org

2010-03-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Chromium: Restore devtools window activate upon node search complete.

https://bugs.webkit.org/show_bug.cgi?id=35832

  • src/js/DevTools.js:
13:42 Changeset [55628] by pfeldman@chromium.org

2010-03-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make timeline overview bars transparent to mouse events.

https://bugs.webkit.org/show_bug.cgi?id=35832

  • inspector/front-end/inspector.css:
10:14 Changeset [55627] by pfeldman@chromium.org

2010-03-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Jeremy Orlow.

Web Inspector: switching to/from Timeline Panel moves scroller.
(Also added couple of record details items as I was fixing it).

https://bugs.webkit.org/show_bug.cgi?id=35829

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get defaultFocusedElement): (WebInspector.TimelinePanel.prototype.show): (WebInspector.TimelinePanel.prototype._refreshRecords):
07:30 Changeset [55626] by eric@webkit.org

2010-03-06 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[Chromium] Embedder initiated loads should not always stop existing loads
https://bugs.webkit.org/show_bug.cgi?id=33862

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::reload): (WebKit::WebFrameImpl::loadRequest): (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::loadData):
07:13 Changeset [55625] by eric@webkit.org

2010-03-06 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[Chromium] spurious WebViewClient::didStopLoading if changing
location.hash while a subframe is still loading

https://bugs.webkit.org/show_bug.cgi?id=33884

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage): Call isLoadingInAPISense, which checks subframes.
06:57 Changeset [55624] by eric@webkit.org

2010-03-06 Patrick Gansterer <paroga@paroga.com>

Reviewed by Eric Seidel.

Removed unnecessary WinCE file.
The same functionality is provided by platform/win/SystemTimeWin.cpp.
https://bugs.webkit.org/show_bug.cgi?id=35799

  • platform/wince/SystemTimeWince.cpp: Removed.
06:40 Changeset [55623] by eric@webkit.org

2010-03-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

  • platform/gtk/accessibility/table-hierarchy.html: Added.
  • platform/gtk/accessibility/table-hierarchy-expected.txt: Added.

2010-03-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

This completes the fixing of the Atk table hierarchy which was started
in bug #35418.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::determineAccessibilityRole):
06:23 Changeset [55622] by eric@webkit.org

2010-03-06 Arno Renevier <arno@renevier.net>

Reviewed by Eric Seidel.

[Gtk] GEOLOCATION_POLICY_DECISION_CANCELLED unused
https://bugs.webkit.org/show_bug.cgi?id=35803

  • webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
05:57 Changeset [55621] by eric@webkit.org

2010-03-06 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Share OwnPtr.
https://bugs.webkit.org/show_bug.cgi?id=35776

Share OwnPtr implementation with BREW MP and remove OwnPtrBrew.

  • wtf/OwnPtrBrew.cpp: Added. (WTF::deleteOwnedPtr):
  • wtf/OwnPtrCommon.h:
  • wtf/brew/OwnPtrBrew.cpp: Removed.
  • wtf/brew/OwnPtrBrew.h: Removed.
05:20 Changeset [55620] by eric@webkit.org

2010-03-06 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active

https://bugs.webkit.org/show_bug.cgi?id=34936

Added a layout test that verifies a plugin can receive keyboard events.
Unfortunately, this test works only on Mac.

  • platform/gtk/Skipped: Skipped the new test because of the lack of eventSender.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: Skipped the new test because NPP_HandleEvent() is not implemented.
  • plugins/keyboard-events-expected.txt: Added.
  • plugins/keyboard-events.html: Added.

2010-03-06 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active

https://bugs.webkit.org/show_bug.cgi?id=34936

This change is a WebKit-side change for this issue. It dispatches
Char events to plug-ins so plug-ins can receive non-ASCII characters
as well as ASCII characters.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent):

2010-03-06 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Typing into Flash with wmode = opaque|transparent and
non-latin language active outputs as if US keyboard layout active

https://bugs.webkit.org/show_bug.cgi?id=34936

To test keyboard events on the test plugin, this change implements
NPCocoaEventKeyDown and NPCocoaEventKeyUp handlers so the plugin
can write log messages.

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (handleEventCocoa): Implemented the event handlers for NPCocoaKeyDown and NPCocoaEventKeyUp.
05:03 Changeset [55619] by eric@webkit.org

2010-03-06 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

Moved implementations of window.btoa() and window.atob() from
JSDOMWindow to DOMWindow, and make V8DOMWindow use DOMWindow
functions instead of having a separate implementation. As a side effect, the
error message has changed from "Cannot decode base64" to one that
indicates DOM Exception, which is compatible to Firefox.

Refactoring: window.btoa() and window.atob() should be implemented on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=35723

  • fast/dom/Window/atob-btoa-expected.txt: Rebaselined expectation due to change of error message.

2010-03-06 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

Moved implementations of window.btoa() and window.atob() from
JSDOMWindow to DOMWindow, and make V8DOMWindow use DOMWindow
functions instead of having a separate implementation. As a side effect, the
error message has changed from "Cannot decode base64" to one that
indicates DOM Exception, which is compatible to Firefox.

Refactoring: window.btoa() and window.atob() should be implemented on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=35723

No new test. No new functionality.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): Moved conversion code to DOMWindow and invoke it. Argument checking remains here.
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::atobCallback): (WebCore::V8DOMWindow::btoaCallback): Remove conversion code and call DOMWindow APIs. Although argument checking remains here.
  • page/DOMWindow.cpp: (WebCore::hasMultibyteCharacters): (WebCore::DOMWindow::btoa): (WebCore::DOMWindow::atob):
  • page/DOMWindow.h: Moved Conversion code from JSDOMWindow, modifing to fit JSC independent.
04:43 Changeset [55618] by eric@webkit.org

2010-03-06 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Darin Fisher.

Create WebKit API for WebCore::ImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=35415

  • WebKit.gyp:
  • public/WebImageDecoder.h: Added.
  • src/WebImageDecoder.cpp: Added.
04:26 Changeset [55617] by eric@webkit.org

2010-03-06 Yuta Kitamura <yutak@chromium.org>

Reviewed by Eric Seidel.

Fix decoration position in search input field.

This patch fixes rendering of input field of "search" type, whose decoration
(loupe icon and close button) was wrongly positioned when the input field was
contained in a block with -webkit-transform property.

Chromium bug: http://crbug.com/20439

[Chromium] Decoration of "search" input field is wrongly rendered
https://bugs.webkit.org/show_bug.cgi?id=30245

No new tests, since this patch fixes an existing test
(fast/forms/search-transformed.html) in Chromium layout tests.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::convertToPaintingRect): Added. This method does almost the same thing as RenderThemeMac::convertToPaintingRect. (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): The position of the icon should not depend on its absolute position. (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): Ditto. (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): Ditto.
  • rendering/RenderThemeChromiumSkia.h: Added new method.
03:50 Changeset [55616] by eric@webkit.org

2010-03-06 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Added expected results and removed the test from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=35806

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.checksum: Added.
  • platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.png: Added.
  • platform/qt/fast/canvas/canvasDrawingIntoSelf-expected.txt: Added.
03:31 Changeset [55615] by eric@webkit.org

2010-03-06 Patrick Gansterer <paroga@paroga.com>

Reviewed by Eric Seidel.

Implemented JIT_OPTIMIZE_NATIVE_CALL for WinCE
https://bugs.webkit.org/show_bug.cgi?id=33426

  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
03:00 Changeset [55614] by pfeldman@chromium.org

2010-03-06 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: in Timeline panel, click followed with mouse move resets popover.

https://bugs.webkit.org/show_bug.cgi?id=35827

  • inspector/front-end/Popover.js: (WebInspector.PopoverHelper.prototype._mouseDown): (WebInspector.PopoverHelper.prototype._mouseMove): (WebInspector.PopoverHelper.prototype._handleMouseAction):

03/05/10:

23:28 Changeset [55613] by eric@webkit.org

2010-03-05 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33247
Backwards cursor movement incorrect when previous block ends with <br>.

If the cursor is trying to move into a node that has a height of 0,
skip over it.

  • editing/execCommand/move-selection-back-line-expected.txt: Added.
  • editing/execCommand/move-selection-back-line.html: Added.

2010-03-05 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33247
Backwards cursor movement incorrect when previous block ends with <br>.

If the cursor is trying to move into a node that has a height of 0,
skip over it.

Test: editing/execCommand/move-selection-back-line.html

  • editing/visible_units.cpp: (WebCore::previousLinePosition):
23:11 Changeset [55612] by eric@webkit.org

2010-03-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Eric Seidel.

Enable resource loading callback while loading worker scripts
https://bugs.webkit.org/show_bug.cgi?id=35744

  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously):
22:45 Changeset [55611] by eric@webkit.org

2010-03-05 Chris Fleizach <cfleizach@apple.com>

Reviewed by Eric Seidel.

WAI-ARIA live region doesn't appear when <div> only has a <div> child
https://bugs.webkit.org/show_bug.cgi?id=35751

  • platform/mac/accessibility/div-containing-div-with-aria-expected.txt: Added.
  • platform/mac/accessibility/div-containing-div-with-aria.html: Added.

2010-03-05 Chris Fleizach <cfleizach@apple.com>

Reviewed by Eric Seidel.

WAI-ARIA live region doesn't appear when <div> only has a <div> child
https://bugs.webkit.org/show_bug.cgi?id=35751

Elements should not be ignored if they carry ARIA attributes in them.

Test: platform/mac/accessibility/div-containing-div-with-aria.html

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::supportsARIAAttributes):
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::supportsARIADropping): (WebCore::AccessibilityObject::supportsARIADragging):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::supportsARIADropping): (WebCore::AccessibilityRenderObject::supportsARIADragging): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  • accessibility/AccessibilityRenderObject.h:
19:48 Changeset [55610] by eric@webkit.org

2010-03-05 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Eric Seidel.

Fix Print option on QtLauncher by calling print directly from QWebFrame.

[Qt] QtLauncher Print option is not working on QGraphicsView mode
https://bugs.webkit.org/show_bug.cgi?id=35769

  • QtLauncher/main.cpp: (LauncherWindow::print):
19:16 Changeset [55609] by dimich@chromium.org

Add a manual test for crash in DOMWindow::clearTimeout when DOMWindow is not connected to Frame
https://bugs.webkit.org/show_bug.cgi?id=32353

Reviewed by Oliver Hunt.

  • manual-tests/clearTimeout-crash-bug29832.html: Added.
19:04 Changeset [55608] by dimich@chromium.org

[v8] Remove wrong assert in GC callback.
https://bugs.webkit.org/show_bug.cgi?id=35757

Reviewed by David Levin.

WebCore:

Test: fast/workers/wrapper-map-gc.html

  • bindings/v8/DOMData.h:

(WebCore::DOMData::handleWeakObject): remove ASSERT(isMainThread()), move another assert up to verify we are on the right thread.

LayoutTests:

  • fast/workers/resources/wrapper-map-gc.js: Added.
  • fast/workers/wrapper-map-gc.html: Added.
  • fast/workers/wrapper-map-gc-expected.txt: Added.
18:52 Changeset [55607] by eric@webkit.org

2010-03-05 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added tests for row and operator stretching.
Updated over, underover, and subsup due to row/operators in use.

  • mathml/presentation/mo.xhtml: Added.
  • mathml/presentation/row.xhtml: Added.
  • platform/mac/mathml/presentation/mo-expected.checksum: Added.
  • platform/mac/mathml/presentation/mo-expected.png: Added.
  • platform/mac/mathml/presentation/mo-expected.txt: Added.
  • platform/mac/mathml/presentation/over-expected.checksum:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum: Added.
  • platform/mac/mathml/presentation/row-expected.png: Added.
  • platform/mac/mathml/presentation/row-expected.txt: Added.
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:

2010-03-05 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added support for row layout with stretchy operators and
adjusted the over spacing for over and underover accordingly.

Tests: mathml/presentation/mo.xhtml

mathml/presentation/row.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • mathml/MathMLInlineContainerElement.cpp:
  • mathml/MathMLTextElement.cpp:
  • mathml/RenderMathMLMath.cpp: Added.
  • mathml/RenderMathMLMath.h: Added.
  • mathml/RenderMathMLOperator.cpp: Added.
  • mathml/RenderMathMLOperator.h: Added.
  • mathml/RenderMathMLRow.cpp: Added.
  • mathml/RenderMathMLRow.h: Added.
  • mathml/RenderMathMLUnderOver.cpp:
  • mathml/mathtags.in:
18:34 Changeset [55606] by eric@webkit.org

2010-03-05 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Take out code hack that flips the result of NPP_HandleEvent. This needs to move to
the NPAPI code so that Pepper plugins don't hit it.
https://bugs.webkit.org/show_bug.cgi?id=35779

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
18:27 Changeset [55605] by dino@apple.com

2010-03-05 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=35772
Animation fill modes should be supported in the shorthand property

Add CSSPropertyWebkitAnimationFillMode to the list of properties
evaluated in the -webkit-animation shorthand.

Test: animations/animation-shorthand.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationShorthand):
17:09 Changeset [55604] by eric@webkit.org

2010-03-05 Eric Seidel <eric@webkit.org>

No review. Skipping recently regressed test to unblock the commit-queue (20 patches waiting).

REGRESSION(55593?): fast/workers/worker-cloneport.html is timing out on Leopard
https://bugs.webkit.org/show_bug.cgi?id=35819

  • platform/mac-leopard/Skipped:
16:52 Changeset [55603] by cjerdonek@webkit.org

Changed the logging code for new-run-webkit-tests to use
module-specific loggers rather than the root logger. This is
a standard practice that allows logging specific to a package
to be configured independently of other modules.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=35194

Added a line of the form "_log = logging.getLogger(<module>)"
to each module below, where <module> is the fully-qualified
name of the module, and updated the log lines to use the new
_log logger.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
16:38 Changeset [55602] by dpranke@chromium.org

2010-03-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

Split the command-line invocation of the Chromium/python LigHTTPd
server implementation out into its own top level script to make it
a more "public" interface and to resolve some awkward layering
issues. This script will be called directly by other test scripts in
the Chromium tree.

At some point this script should be made to work with Apache-based
implementations and on other ports. I have filed
https://bugs.webkit.org/show_bug.cgi?id=35820 for this.

Also fix a bug in port/factory where options.chromium could be
dereferenced even if it wasn't set, raising an exception.

https://bugs.webkit.org/show_bug.cgi?id=35812

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/new-run-webkit-httpd: Added
16:21 Changeset [55601] by dino@apple.com

2010-03-05 Dean Jackson <dino@apple.com>

Reviewed by NOBODY (OOPS!).

https://bugs.webkit.org/show_bug.cgi?id=35815
Animation Fill Modes fail on Windows

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSStyleSelector.cpp:
  • platform/graphics/mac/GraphicsLayerCA.mm:
    • use new enum value
  • platform/animation/Animation.h:
    • change bitfield type
  • rendering/style/RenderStyleConstants.h:
    • add new enum for fill mode
15:44 Changeset [55600] by oliver@apple.com

2010-03-05 Oliver Hunt <oliver@apple.com>

Reviewed by NOBODY (build fix).

Add enw exports to windows

15:29 Changeset [55599] by oliver@apple.com

2010-03-05 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

JSC should cache int to Identifier conversion as it does for ordinary strings
https://bugs.webkit.org/show_bug.cgi?id=35814

Make the NumericStrings cache cache unsigned ints in addition to signed.
We keep them separate from the int cache as it both simplifies code, and
also because the unsigned path is exclusive to property access and therefore
seems to have different usage patterns.

The primary trigger for the unsigned to Identifier propertyName conversion
is the construction of array-like objects out of normal objects. Given these
tend to be relative small numbers, and the array-like behaviour lends itself
to sequential values this patch also adds a non-colliding cache for all small
numbers.

  • JavaScriptCore.exp:
  • runtime/Identifier.cpp: (JSC::Identifier::from):
  • runtime/Identifier.h:
  • runtime/NumericStrings.h: (JSC::NumericStrings::add): (JSC::NumericStrings::lookup): (JSC::NumericStrings::lookupSmallString):
15:26 Changeset [55598] by ossy@webkit.org

Unreviewed buildfix after r55593. (To fix Qt --minimal build.)

  • bindings/js/JSDOMWindowCustom.cpp: Missing #if ENABLE(DATABASE) guard added.
14:55 Changeset [55597] by simon.fraser@apple.com

2010-03-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com
https://bugs.webkit.org/show_bug.cgi?id=34065
<rdar://problem/7573509>

Fix one instance of this assertion (not necessarily the one seen on hulu.com).

If the layer that clippingRoot() is being called on is itself compositing,
then it acts as the clipping root. Without this, calls to RenderLayer::childrenClipRect()
and RenderLayer::selfClipRect() via FrameView::windowClipRectForLayer(), for plug-ins,
caused the caching of an incorrect clip rects root.

Test: compositing/geometry/object-clip-rects-assertion.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::clippingRoot):
14:53 Changeset [55596] by dino@apple.com

2010-03-05 Dean Jackson <dino@apple.com>

No review.

Disabling animations/fill-mode-transform.html on Leopard
due to https://bugs.webkit.org/show_bug.cgi?id=35714

  • platform/mac-leopard/Skipped:
14:46 Changeset [55595] by simon.fraser@apple.com

2010-03-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Child clipping compositing layers don't show the blue debug color
https://bugs.webkit.org/show_bug.cgi?id=35807

Set a layer owner on the GraphicsLayers created for clipping children,
so that they can get to the debug settings that give them the blue color.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateClippingLayers):
14:43 Changeset [55594] by simon.fraser@apple.com

2010-03-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

MobileMe movie page is missing playback controls
https://bugs.webkit.org/show_bug.cgi?id=35805
<rdar://problem/7653169>

On pages with video or plug-ins, we run overlap tests to determine which layers
need to be composited. There was an ordering dependency bug in
RenderLayerCompositor::computeCompositingRequirements() that caused us to fail
to detect that a layer needed to be composited, resulting in page content
not being visible.

Specifically, layer->setHasCompositingDescendant() can change the answer
to needsToBeComposited(), when a layer has to clip compositing descendants.
So if we change setHasCompositingDescendant(), then we need to re-test
clipsCompositingDescendants() and add the layer to the overlap map if so.

Test: compositing/overflow/overflow-compositing-descendant.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
14:17 Changeset [55593] by dumi@chromium.org

WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().

Reviewed by Adam Barth.

Test: storage/open-database-creation-callback.html

https://bugs.webkit.org/show_bug.cgi?id=34726

  • Android.jscbindings.mk
  • Android.v8bindings.mk
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCallback.cpp: Added.

(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):

  • bindings/js/JSDatabaseCallback.h: Added.

(WebCore::JSDatabaseCallback::create):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • bindings/v8/custom/V8DatabaseCallback.cpp: Added.

(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):

  • bindings/v8/custom/V8DatabaseCallback.h: Added.

(WebCore::V8DatabaseCallback::create):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/Database.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):

  • storage/Database.h:

(WebCore::Database::isNew):

  • storage/DatabaseCallback.h: Added.

(WebCore::DatabaseCallback::~DatabaseCallback):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):

  • workers/WorkerContext.h:

LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.

Reviewed by Adam Barth.

Also, fixing fast/frames/sandboxed-iframe-storage.html: calling
openDatabase() without at least 4 parameters should always fail,
because the database name, version, description and estimated size
are not optional according to the spec.

https://bugs.webkit.org/show_bug.cgi?id=34726

  • fast/frames/resources/sandboxed-iframe-storage-allowed.html:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-storage-expected.txt:
  • platform/qt/Skipped:
  • storage/open-database-creation-callback-expected.txt: Added.
  • storage/open-database-creation-callback.html: Added.
  • storage/open-database-creation-callback-isolated-world-expected.txt: Added.
  • storage/open-database-creation-callback-isolated-world.html: Added.
13:04 Changeset [55592] by cmarrin@apple.com

Fixed crash due to infinite recursion when viewing composited video on Windows
https://bugs.webkit.org/show_bug.cgi?id=35798

10:33 Changeset [55591] by bweinstein@apple.com

Update getComputedStyle results on Windows.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
10:26 Changeset [55590] by dglazkov@chromium.org

2010-03-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Levin.

[Chromium] Missing commas in WebCore.gypi file make building Geo unpossible.
https://bugs.webkit.org/show_bug.cgi?id=35797

No new tests, this is a latent compile break.

  • WebCore.gypi:
10:12 Changeset [55589] by eric.carlson@apple.com

2010-03-05 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Use a movie that will hopefully fail to open less often on a headless
SnowLeopard bot.

  • media/video-preload-expected.txt:
  • media/video-preload.html: Use test.mp4 instead of silence.mpg.
09:39 QtWebKitBugs edited by vestbo@webkit.org
(diff)
09:32 Changeset [55588] by eric.carlson@apple.com

2010-03-05 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

media/video-preload.html fails on GTK, skip it.

  • platform/gtk/Skipped:
09:13 Changeset [55587] by eric.carlson@apple.com

2010-03-04 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/7718442> Implement 'preload=none'
https://bugs.webkit.org/show_bug.cgi?id=35789

Don't load any media data when preload is 'none'.

Test: media/video-preload.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadResource): Don't call player's setPreload method

when autoplay is set.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setPreload): Set m_preload so we have the correct value when

the media engine is created.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_preload. (WebCore::MediaPlayerPrivate::resumeLoad): New, kick off postponed a load. (WebCore::MediaPlayerPrivate::load): Do nothing if preload is 'none' (WebCore::MediaPlayerPrivate::loadInternal): New, complete loading. (WebCore::MediaPlayerPrivate::prepareToPlay): New, resume a postponed load as someone

has called play().

(WebCore::MediaPlayerPrivate::setPreload): New, set m_preload.

2010-03-04 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/7718442> Implement 'preload=none'
https://bugs.webkit.org/show_bug.cgi?id=35789

Functional test of the 'proload' attribute.

  • media/video-preload-expected.txt: Added.
  • media/video-preload.html: Added.
  • platform/win/Skipped: Skip on Windows for now.
08:53 Changeset [55586] by japhet@chromium.org

2010-03-04 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Give CodeGeneratorV8.pm a much-needed spring cleaning.

https://bugs.webkit.org/show_bug.cgi?id=35697

  • bindings/scripts/CodeGeneratorV8.pm: Remove unused code, fix style issues, make less hard-coded.
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::addEventListenerCallback): (WebCore::V8DOMWindow::removeEventListenerCallback):
08:16 Changeset [55585] by tonikitoo@webkit.org

[Gtk] Implement setSpatialNavigationEnabled in DRT.
https://bugs.webkit.org/show_bug.cgi?id=35705

Reviewed by Holger Freyther
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebKitTools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

LayoutTests:

  • platform/gtk/Skipped:
08:13 Changeset [55584] by pfeldman@chromium.org

2010-03-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Roll back r55522 since it regreses performance
according to chromium's page cycler.

https://bugs.webkit.org/show_bug.cgi?id=35568

08:07 Changeset [55583] by tonikitoo@webkit.org

[Gtk] Add 'enable-spatial-navigation' setting for Spatial Navigation on/off.
https://bugs.webkit.org/show_bug.cgi?id=35701

Reviewed by Gustavo Noronha.
Patch by Antonio Gomes <tonikitoo@webkit.org>

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
(webkit_web_settings_copy):

  • webkit/webkitwebview.cpp:

(DNDContentsRequest::webkit_web_view_update_settings):
(DNDContentsRequest::webkit_web_view_settings_notify):

08:04 Changeset [55582] by tonikitoo@webkit.org

Add toggle on/off stub methods for Spatial Navigation in win, gtk and mac LayoutTestController class implementations.
https://bugs.webkit.org/show_bug.cgi?id=35699

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

  • DumpRenderTree/LayoutTestController.cpp:

(setSpatialNavigationEnabledCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setSpatialNavigationEnabled):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

08:01 Changeset [55581] by tonikitoo@webkit.org

[Qt] Add toggle on/off mechanism for Spatial Navigation in QtLauncher.

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

  • QtLauncher/main.cpp:

(LauncherWindow::toggleSpatialNavigation):
(LauncherWindow::setupUI):

07:58 Changeset [55580] by tonikitoo@webkit.org

[Qt] Add setSpatialNavigationEnabled method DRT
https://bugs.webkit.org/show_bug.cgi?id=33715

Reviewed by Simon Hausmann.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Added setSpatialNavigationEnabled support to Qt DRT.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):
(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

Unskipped fast/events/spatial-navigation/

07:49 Changeset [55579] by tonikitoo@webkit.org

[Qt] QWebSettings attribute for toggle Spatial Navigation on/off
https://bugs.webkit.org/show_bug.cgi?id=33714 (Qt API part)

Reviewed by Simon Hausmann.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Added 'SpatialNavigationEnabled' attribute to QWebSettings.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

  • Api/qwebsettings.h:
07:48 Changeset [55578] by tonikitoo@webkit.org

Extend keyboard navigation to allow directional navigation (LayoutTests - part II)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This patch adds two LayoutTest to ensure the basic table traversal correctness of
Spatial Navigation (SNav) algorithm: focusable elements in a <table> should be accessible.

  • fast/events/spatial-navigation/snav-table-traversal.html: Added. Makes sure all elements in a <table> are accessible via Spatial Navigation.
  • fast/events/spatial-navigation/snav-tiny-table-traversal.html: Added. Tests the similar table traversal scenario as above, but in this case the elements in the <table> are styled with 'font-size: small'. That way this test also validades that overlapping rects of elements too closed from each other are correctly handled.
07:46 Changeset [55577] by tonikitoo@webkit.org

Extend keyboard navigation to allow directional navigation (LayoutTests - part I)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This patch adds support for auto testing the Spatial Navigation feature by:

1) Creating the directory where the tests are going to live in, named

fast/events/spatial-navigation/.

2) Skipping this directory by Mac, Qt, Gtk and Win.
3) Adding a JS file drives the test execution by processing, for each test,

a given set of arrow key actions and verify if the right expected Element
got the focus after each event processed. This file is
fast/events/spatial-navigation/resources/spatial-navigation-utils.js

  • LayoutTests/fast/events/spatial-navigation/snav-vertical-superprecedence.html: Added.
07:42 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:31 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:31 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:30 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:28 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:27 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:23 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:23 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:22 QtWebKitJournal edited by hausmann@webkit.org
(diff)
07:17 QtWebKit edited by hausmann@webkit.org
(diff)
07:11 QtWebKitBugs edited by vestbo@webkit.org
(diff)
06:06 QtWebKit edited by hausmann@webkit.org
(diff)
06:06 QtWebKit edited by hausmann@webkit.org
(diff)
04:58 Changeset [55576] by dino@apple.com

2010-03-05 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser and Chris Marrin.

Bug 26869: Add fill modes for CSS Animations
https://bugs.webkit.org/show_bug.cgi?id=26869

Tests: animations/fill-mode-removed.html

animations/fill-mode-transform.html
animations/fill-mode.html

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSParser.cpp:
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/CSSValueKeywords.in:
    • parse, assign and retrieve the value of the new -webkit-animation-fill-mode property
  • page/animation/AnimationBase.cpp:
  • page/animation/AnimationBase.h:
    • new state in animation engine for a finished animation that is "filling" forwards in time. This allows the engine to keep the animation around and not revert to the old style.
    • update the timer code to indicate it doesn't need to keep animating if it is filling
    • now that animations can extend beyond their elapsed time, make sure progress works correctly with iteration counts
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate):
    • ensure correct style value is returned at the right time by checking for fill mode

(WebCore::KeyframeAnimation::onAnimationEnd):

  • continue to send the end event, but only remove the animation if it isn't filling forwards
  • platform/animation/Animation.cpp:
  • platform/animation/Animation.h:
    • new fill mode member property
  • platform/animation/AnimationList.cpp:
    • ensure the fill mode is propagated to a list of style valus
  • platform/graphics/mac/GraphicsLayerCA.mm:
    • make hardware layers use Core Animation's fill mode
02:09 Changeset [55575] by pfeldman@chromium.org

2010-03-05 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Do not show link helper in popovers and/or for external resources.

https://bugs.webkit.org/show_bug.cgi?id=35785

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.hide):
  • inspector/front-end/inspector.js: (WebInspector.documentMouseOver): (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.addMainEventListeners):
01:51 Changeset [55574] by ukai@chromium.org

2010-03-05 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket test to transfer null character
https://bugs.webkit.org/show_bug.cgi?id=35715

  • websocket/tests/null-character-expected.txt: Added.
  • websocket/tests/null-character.html: Added.
  • websocket/tests/script-tests/null-character.js: Added.
01:35 Changeset [55573] by ukai@chromium.org

2010-03-05 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket onmessageerror event handler
https://bugs.webkit.org/show_bug.cgi?id=35570

  • websocket/tests/error-detect-expected.txt: Added.
  • websocket/tests/error-detect.html: Added.
  • websocket/tests/script-tests/error-detect.js: Added.
  • websocket/tests/unknown-frame-type_wsh.py: Added.

2010-03-05 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket onmessageerror event handler
https://bugs.webkit.org/show_bug.cgi?id=35570

Test: websocket/tests/error-detect.html

  • websockets/WebSocket.cpp: (WebCore::WebSocketChannel::didConnect): assert scriptExecutionContext. (WebCore::WebSocketChannel::didReceiveMessage): assert scriptExecutionContext. (WebCore::WebSocket::didReceiveMessageError): (WebCore::WebSocket::didClose): assert scriptExecutionContext.
  • websockets/WebSocket.h:
  • websockets/WebSocket.idl: Add onerror event listener
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData): call didReceiveMessageError if unknown frame tye is detected, or frame length overflowed.
  • websockets/WebSocketChannelClient.h: (WebCore::WebSocketChannelClient::didReceiveMessageError):

03/04/10:

22:09 Changeset [55572] by eric@webkit.org

2010-03-04 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Changing private members from PlatformTouchEvent and PlatformTouchPoint
to be protected, so that Chromium's PlatformTouchEventBuilder and
PlatformTouchPointBuilder can access them. Exercised by the
fast/events/touch tests.
https://bugs.webkit.org/show_bug.cgi?id=35760

  • platform/PlatformTouchEvent.h: (WebCore::PlatformTouchEvent::~PlatformTouchEvent):
  • platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::~PlatformTouchPoint):

2010-03-04 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Adding PlatformTouchEventBuilder and PlatformTouchPointBuilder for
converting Chromium WebTouchEvent and WebTouchPoint types to
corresponding WebCore types.
https://bugs.webkit.org/show_bug.cgi?id=35760

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState): (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder): (WebKit::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
  • src/WebInputEventConversion.h:
21:52 Changeset [55571] by eric@webkit.org

2010-03-04 John Gregg <johnnyg@google.com>

Reviewed by Darin Fisher.

[chromium] WebDocument:applicationID() crashes on <meta> tag with no http-equiv attribute
https://bugs.webkit.org/show_bug.cgi?id=35771

  • src/WebDocument.cpp: (WebKit::WebDocument::applicationID): check for presence of http-equiv attribute before lower()ing it.
21:50 Changeset [55570] by ukai@chromium.org

WebSocket crash bug when reloading the page while the WebSocket is busy
https://bugs.webkit.org/show_bug.cgi?id=35732

Reviewed by Alexey Proskuryakov.

WebCore:

  • websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::disconnect): clear m_context from WebSocketChannel and WebSocketHandshake.
(WebCore::WebSocketChannel::didOpen): check m_context
(WebCore::WebSocketChannel::didClose): clear m_context
(WebCore::WebSocketChannel::didReceiveData): check m_context, and check m_client early before appending to buffer

  • websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clearScriptExecutionContext): Added.

  • websockets/WebSocketHandshake.h:

LayoutTests:

  • websocket/tests/reload-crash-expected.txt: Added.
  • websocket/tests/reload-crash.html: Added.
  • websocket/tests/resoures/reload-crash-iframe.html: Added.
21:35 Changeset [55569] by eric@webkit.org

2010-03-04 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

Refactoring: XMLHTTPRequest.open() should have all overloaded implementations
https://bugs.webkit.org/show_bug.cgi?id=35630

  • http/tests/xmlhttprequest/open-async-overload-expected.txt: Added.
  • http/tests/xmlhttprequest/open-async-overload.html: Added.

2010-03-04 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

Refactoring: XMLHTTPRequest.open() should have all overloaded implementations
https://bugs.webkit.org/show_bug.cgi?id=35630

Test: http/tests/xmlhttprequest/open-async-overload.html

  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::openCallback):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open):
  • xml/XMLHttpRequest.h:
21:18 Changeset [55568] by eric@webkit.org

2010-03-04 James Robinson <jamesr@google.com>

Reviewed by Eric Seidel.

Styles do not have to be synchronously rematched after every event dispatch

https://bugs.webkit.org/show_bug.cgi?id=32580

  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
21:01 Changeset [55567] by eric@webkit.org

2010-03-04 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

maemo spelled as mameo in WebCore.pro
https://bugs.webkit.org/show_bug.cgi?id=35765

Spelling corrected.

  • WebCore.pro:
20:34 Changeset [55566] by tony@chromium.org

2010-03-04 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=18819
Pressing option+page{down,up} should move the cursor and scroll in
content editable areas. On other platforms, pressing page{down,up}
should move the cursor and scroll in content editable areas.

  • editing/input/option-page-up-down-expected.txt: Added.
  • editing/input/option-page-up-down.html: Added.

2010-03-04 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=18819
Pressing option+page{down,up} should move the cursor and scroll in
content editable areas. On other platforms, pressing page{down,up}
should move the cursor and scroll in content editable areas.

Test: editing/input/option-page-up-down.html

  • editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
19:42 Changeset [55565] by mrowe@apple.com

Find the framework relative to TARGET_BUILD_DIR as that has a more obvious value during production builds.

Rubber-stamped by Alice Liu.

  • Scripts/check-for-webkit-framework-include-consistency:
17:33 Changeset [55564] by oliver@apple.com

2010-03-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716

Add new opcodes for handling cached lookup of static value getters.
More or less the same as with JS getters, all that changes is that
instead of calling through a JSFunction we always know that we have
a C function to call.

For the patching routines in the JIT we now need to pass a few
new parameters to allow us to pass enough information to the stub
function to allow us to call the C function correctly. Logically
this shouldn't actually be necessary as all of these functions ignore
the identifier, but removing the ident parameter would require
somewhat involved changes to the way we implement getOwnPropertySlot,
etc.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):
  • bytecode/Instruction.h: (JSC::Instruction::Instruction): (JSC::Instruction::):
  • bytecode/Opcode.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::):
  • runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
  • runtime/Lookup.h: (JSC::getStaticPropertySlot): (JSC::getStaticValueSlot):
  • runtime/PropertySlot.h: (JSC::PropertySlot::): (JSC::PropertySlot::PropertySlot): (JSC::PropertySlot::cachedPropertyType): (JSC::PropertySlot::isCacheable): (JSC::PropertySlot::isCacheableValue): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setCacheableCustom): (JSC::PropertySlot::setGetterSlot): (JSC::PropertySlot::setCacheableGetterSlot): (JSC::PropertySlot::clearOffset): (JSC::PropertySlot::customGetter):

2010-03-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716

Add tests to ensure nothing horrifying happens to static property
getters if they're in a path where we end up caching lookups.

  • fast/js/pic/cached-named-property-getter-expected.txt: Added.
  • fast/js/pic/cached-named-property-getter.html: Added.

2010-03-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Allow static property getters to interact with JSCs caching
https://bugs.webkit.org/show_bug.cgi?id=35716

Update the obviously safe getters to allow caching

Test: fast/js/pic/cached-named-property-getter.html

  • bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertySlot):
  • bridge/runtime_method.cpp: (JSC::RuntimeMethod::getOwnPropertySlot):
16:50 Changeset [55563] by tkent@chromium.org

2010-03-04 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add CppVariant and CppBoundClass
https://bugs.webkit.org/show_bug.cgi?id=35634

Add CppVariant and CppBoundClass classes, which are going to be
used by DumpRenderTree Chromium port. These files are based on:

  • src/webkit/glue/cpp_variant.{cc,h} and
  • src/webkit/glue/cpp_bound_class.{cc,h} of Chromium rev.40492.
  • DumpRenderTree/chromium/CppBoundClass.cpp: Added.
  • DumpRenderTree/chromium/CppBoundClass.h: Added.
  • DumpRenderTree/chromium/CppVariant.cpp: Added.
  • DumpRenderTree/chromium/CppVariant.h: Added.
16:29 Changeset [55562] by mrowe@apple.com

Build fix for older versions of Ruby.

  • Scripts/check-for-webkit-framework-include-consistency:
16:23 Changeset [55561] by mrowe@apple.com

Add a script to verify that WebKit framework headers are internally consistent.

Reviewed by Sam Weinig.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Run the script during the build and fail with

an error should the consistency check fail.

WebKitTools:

This script detects the following problematic situations:

  • An exported WebKit header that includes a header from WebCore.
  • An exported WebKit header that includes a header that does not exist in the WebKit framework.
  • A public WebKit header that includes a private WebKit header.
  • Scripts/check-for-webkit-framework-include-consistency: Added.
16:23 Changeset [55560] by mrowe@apple.com

<rdar://problem/7717249> DOMSVG.h includes a non-existent DOMSVGFEMorphologyElement.h

Reviewed by Sam Weinig.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Copy DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h

in to the framework wrapper.

WebKit/mac:

  • MigrateHeaders.make: Migrate DOMSVGFEMorphologyElement.h and DOMSVGFEMorphologyElementInternal.h.
16:23 Changeset [55559] by mrowe@apple.com

Use a framework-style include to pull in WebInspector.h for consistency
with other parts of WebKit.

Reviewed by Sam Weinig.

  • WebInspector/WebInspectorPrivate.h:
15:34 Changeset [55558] by dumi@chromium.org

Making sure that the correct path is set before invoking
DumpRenderTree on cygwin.

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=35768

  • Scripts/run-webkit-tests:
15:29 Changeset [55557] by jamesr@google.com

2010-03-04 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Handles setting HTMLSelectElement.length with mutation handlers present
https://bugs.webkit.org/show_bug.cgi?id=33983

When setting an HTMLSelectElement's length attribute, option elements have to be added or removed to the select
as appropriate. This is a little tricky with mutation events since they might add, remove, or reorder elements
while option elements are being added or deleted.

Tests: fast/forms/select-set-length-optgroup.html

fast/forms/select-set-length-with-mutation-remove.html
fast/forms/select-set-length-with-mutation-reorder.html
fast/forms/select-set-length-with-mutation-reparent.html
fast/forms/select-set-length-with-mutation.html
fast/forms/select-set-length.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setLength):

2010-03-04 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Tests for setting an select's options.length attribute.
https://bugs.webkit.org/show_bug.cgi?id=33983

  • fast/forms/script-tests/select-set-length-optgroup.js: Added.
  • fast/forms/script-tests/select-set-length-with-mutation-remove.js: Added. (gc): (onRemove):
  • fast/forms/script-tests/select-set-length-with-mutation-reorder.js: Added. (onRemove):
  • fast/forms/script-tests/select-set-length-with-mutation-reparent.js: Added. (onRemove):
  • fast/forms/script-tests/select-set-length-with-mutation.js: Added. (sel):
  • fast/forms/script-tests/select-set-length.js: Added.
  • fast/forms/select-set-length-expected.txt: Added.
  • fast/forms/select-set-length-optgroup-expected.txt: Added.
  • fast/forms/select-set-length-optgroup.html: Added.
  • fast/forms/select-set-length-with-mutation-expected.txt: Added.
  • fast/forms/select-set-length-with-mutation-remove-expected.txt: Added.
  • fast/forms/select-set-length-with-mutation-remove.html: Added.
  • fast/forms/select-set-length-with-mutation-reorder-expected.txt: Added.
  • fast/forms/select-set-length-with-mutation-reorder.html: Added.
  • fast/forms/select-set-length-with-mutation-reparent-expected.txt: Added.
  • fast/forms/select-set-length-with-mutation-reparent.html: Added.
  • fast/forms/select-set-length-with-mutation.html: Added.
  • fast/forms/select-set-length.html: Added.
15:21 Changeset [55556] by ossy@webkit.org

[Qt] Unreviewed buildfix after r55542 on Windows.

  • WebCore.pro:
    • plugins/win/PluginDatabaseWin.cpp removed.
    • platform/win/WebCoreInstanceHandle.cpp added.
  • platform/win/WebCoreInstanceHandle.cpp: Remove explicit qualification in namespace declaration to make gcc happy.
15:01 Changeset [55555] by japhet@chromium.org

2010-03-04 Nate Chapin <japhet@chromium.org>

Reviewed by Kenneth Rohde Christiansen.

Fix the case where we do a same document navigation, scroll,
then repeat the same document navigation. Currently, the second
navigation does nothing.

https://bugs.webkit.org/show_bug.cgi?id=35547

Test: fast/loader/repeat-same-document-navigation.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): Call scrollToFragment() whether or not the hash changed.
14:44 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
14:31 Changeset [55554] by simon.fraser@apple.com

2010-03-04 Simon Fraser <simon.fraser@apple.com>

Build fix.

const long long cMaxDistance = numeric_limits<long long>::max() created global
initializers at the call sites, so replace with an inline function.

  • page/FocusController.cpp: (WebCore::updateFocusCandidateIfCloser):
  • page/SpatialNavigation.cpp: (WebCore::distanceInDirection):
  • page/SpatialNavigation.h: (WebCore::maxDistance): (WebCore::FocusCandidate::FocusCandidate):
14:29 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
Repeat reporting link. Fill out the crashes part (diff)
14:15 Changeset [55553] by simon.fraser@apple.com

2010-03-04 Simon Fraser <simon.fraser@apple.com>

Build fix: add exceptions to the check-for-global-initializers script
for FocusController and SpatialNavigation, and improve the script
to actually print out the globals found.

  • Scripts/check-for-global-initializers:
13:52 Changeset [55552] by tonikitoo@webkit.org

Unreviewed attempt to fix Windows build.

  • page/SpatialNavigation.cpp:

(WebCore::spatialDistance):

13:40 Changeset [55551] by dpranke@chromium.org

2010-03-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Fix dangling reference to "port" instead of "self._port_obj" that
was preventing the http_server from starting on Windows.

  • Scripts/webkitpy/layout_tests/port/http_server.py:
13:35 Changeset [55550] by simon.fraser@apple.com

2010-03-04 Simon Fraser <simon.fraser@apple.com>

Build fix.

Delcare updateFocusCandidateIfCloser static to avoid warning.

  • page/FocusController.cpp: (WebCore::updateFocusCandidateIfCloser):
13:11 Changeset [55549] by darin@chromium.org

2010-03-04 Darin Fisher <darin@chromium.org>

Reviewed by Dmitry Titov.

[chromium] make history.{push,replace}State enabled at runtime
https://bugs.webkit.org/show_bug.cgi?id=35753

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setPushStateEnabled): (WebCore::RuntimeEnabledFeatures::pushStateEnabled): (WebCore::RuntimeEnabledFeatures::replaceStateEnabled):
  • page/History.idl:
13:09 Changeset [55548] by tonikitoo@webkit.org

Unreviewed attempt to (again) fix Mac build.

  • page/SpatialNavigation.cpp:

(WebCore::spatialDistance):

13:03 Changeset [55547] by mitz@apple.com

Fix typos

13:02 Changeset [55546] by mitz@apple.com

WebCore: Based on a pacth from Nick Jong.

Reviewed by Simon Fraser.

Improve selection in multi-column blocks when hitting points above or
below a column rect.

Test: fast/multicol/hit-test-above-or-below.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPointToColumnContents): If the point lies
within the horizontal range for a column, constrain it to the column (if
it is above) or the next column (if it is below).

LayoutTests: Added test for hit-testing points above or below the column rect.

Reviewed by Simon Fraser.

  • fast/multicol/hit-test-above-or-below-expected.txt: Added.
  • fast/multicol/hit-test-above-or-below.html: Added.
12:57 Changeset [55545] by tonikitoo@webkit.org

Attempt to fix Mac build.

Reviewed by Simon Frase.

  • page/SpatialNavigation.cpp:
12:20 Changeset [55544] by tonikitoo@webkit.org

Add SpatialNavigation header and cpp to Mac XCode project file

Reviewed by Kenneth Christiansen.
Patch by Jesus Palencia <jesus.palencia@openbossa.org>

  • WebCore.xcodeproj/project.pbxproj:
12:19 Changeset [55543] by tonikitoo@webkit.org

Extend keyboard navigation to allow directional navigation
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Simon Fraser, Eric Seidel and Darin Adler.
Patch by Antonio Gomes <tonikitoo@webkit.org>
Based on the initial work of Marco Barisione <marco.barisione@collabora.co.uk>

This patch implements the core logic of the 'Spatial Navigation' feature [1].
It improves the accessibility support of WebCore by extending the basic keyboard
navigation currently available (based on Tab forward and backward) with the
addition of a two-dimensional directional navigation by using Left, Right, Up and
Down arrow keys to move to the "nearest" element in the corresponding direction.

Highlights:

  • Feature is turned off by default in Settings. Port specific APIs need to be added for toggling it on/off.
  • Only elements viewed in the current viewport can have focus move to it. If the "nearest" is not in viewport dimensions, then a scroll-in-direction action is performed.
  • The layout tests added run on Qt's DRT only for now (skipped for Mac, Win and Gtk).

Known issues (to be covered in follow-up bugs):

  • Add port specific hooks to each DRT to enable/disable Spatial Navigation.
  • Support for spatial navigation through form elements (<input>, <select>, etc) is be added.
  • Make navigation keys customizable. It currently works with arrows keys only (up, down, right and left).
  • Make it support modifiers (Alt, Ctrl and Shift).

[1] http://en.wikipedia.org/wiki/Spatial_navigation

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::focusDirectionForKey):
(WebCore::EventHandler::defaultArrowEventHandler):

  • page/EventHandler.h:
  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocus):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::advanceFocusDirectionally):
(WebCore::updateFocusCandidateIfCloser):
(WebCore::FocusController::findFocusableNodeInDirection):
(WebCore::FocusController::deepFindFocusableNodeInDirection):

  • page/FocusController.h:
  • page/FocusDirection.h:

(WebCore::):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setSpatialNavigationEnabled):

  • page/Settings.h:

(WebCore::Settings::isSpatialNavigationEnabled):

  • page/SpatialNavigation.cpp: Added.

(WebCore::distanceInDirection):
(WebCore::renderRectRelativeToRootDocument):
(WebCore::alignmentForRects):
(WebCore::isHorizontalMove):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsPartiallyAligned):
(WebCore::spatialDistance):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::isInRootDocument):
(WebCore::deflateIfOverlapped):

  • page/SpatialNavigation.h: Added.

(WebCore::):
(WebCore::FocusCandidate::FocusCandidate):

12:08 Changeset [55542] by bdakin@apple.com

WebCore: This fixes the layering violation I committed yesterday by moving
Page::instanceHandle into its own file just in the WebCore
namespace.

Reviewed by Anders Carlsson.

Added WebCoreInstanceHandle.h + .cpp and removed PageWin.cpp

  • WebCore.vcproj/WebCore.vcproj:
  • page/win/PageWin.cpp: Removed.

Remove all instance handle code from Page.

  • page/Page.h:

New files.

  • platform/win/WebCoreInstanceHandle.cpp: Added.
  • platform/win/WebCoreInstanceHandle.h: Added.

(WebCore::setInstanceHandle):
(WebCore::instanceHandle):

Switch to WebCore::instanceHandle() instead of
Page::instanceHandle() and include the new header.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::Pasteboard):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenu::show):
(WebCore::PopupMenu::registerClass):

  • platform/win/SharedTimerWin.cpp:

(WebCore::initializeOffScreenTimerWindow):

  • plugins/win/PluginViewWin.cpp:

(WebCore::registerPluginView):
(WebCore::PluginView::platformStart):

WebKit/win: WebCore::Page::setInstanceHandle() is now just
WebCore::setInstanceHandle()

Reviewed by Anders Carlsson.

  • WebKitDLL.cpp:

(DllMain):

11:30 Changeset [55541] by eric@webkit.org

2010-03-04 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Simon Hausmann.

Make Qt DumpRenderTree EventSender able to send double click events

LayoutTests:

fast/events/dblclick-addEventListener.html

[Qt] DRT: Send double click event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35255

  • platform/qt/Skipped:

2010-03-04 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Simon Hausmann.

Make Qt DumpRenderTree EventSender able to send double click events

LayoutTests:

fast/events/dblclick-addEventListener.html

[Qt] DRT: Send double click event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=35255

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::EventSender): (EventSender::mouseDown):
  • DumpRenderTree/qt/EventSenderQt.h: (EventSender::resetClickCount):
11:15 Changeset [55540] by tonikitoo@webkit.org

[Gtk] Unreviewed build fix.
Patch by Antonio Gomes <tonikitoo@webkit.org>

'glib_file_name' renamed to 'gligFileName'.

  • platform/graphics/gtk/ImageGtk.cpp:

(WebCore::Image::loadPlatformResource):

11:12 Changeset [55539] by eric@webkit.org

2010-03-04 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] qwebelement.h does not include QtCore headers correctly
https://bugs.webkit.org/show_bug.cgi?id=35748

The header files of QtCore must be included as QtCore/foo.h.

See also http://bugreports.qt.nokia.com/browse/QTBUG-8661

  • Api/qwebelement.h:
11:03 Changeset [55538] by pfeldman@chromium.org

2010-03-04 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium tests fix.

  • src/js/Tests.js:
10:56 Changeset [55537] by pfeldman@chromium.org

2010-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Remove two last synchronous calls from front-end to InspectorBackend.

https://bugs.webkit.org/show_bug.cgi?id=35720

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::enableSearchingForNode): (WebCore::InspectorBackend::disableSearchingForNode): (WebCore::InspectorBackend::setPauseOnExceptionsState):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorContorller::setSearchingForNode): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::searchingForNodeWasEnabled): (WebCore::InspectorFrontend::searchingForNodeWasDisabled): (WebCore::InspectorFrontend::updatePauseOnExceptionsState):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.get statusBarItems): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.searchingForNodeWasEnabled): (WebInspector.ElementsPanel.prototype.searchingForNodeWasDisabled): (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.enableSearchingForNode): (.WebInspector.InspectorBackendStub.prototype.disableSearchingForNode): (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptionsState):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get statusBarItems): (WebInspector.ScriptsPanel.prototype.updatePauseOnExceptionsState): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
  • inspector/front-end/inspector.js: (WebInspector.searchingForNodeWasEnabled): (WebInspector.searchingForNodeWasDisabled): (WebInspector.updatePauseOnExceptionsState): WebKit/chromium:
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
10:48 Changeset [55536] by pfeldman@chromium.org

2010-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Clicking on an error should take me to the error

https://bugs.webkit.org/show_bug.cgi?id=34860

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype.selectContentTab):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource):
10:46 Changeset [55535] by pfeldman@chromium.org

2010-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Remove sync access to resourceTrackingEnabled.

https://bugs.webkit.org/show_bug.cgi?id=35693

  • inspector/InspectorBackend.cpp:
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources): (WebInspector.AuditsPanel.prototype.show):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking): (.WebInspector.InspectorBackendStub.prototype.enableDebugger): (.WebInspector.InspectorBackendStub.prototype.disableDebugger): (.WebInspector.InspectorBackendStub.prototype.enableProfiler): (.WebInspector.InspectorBackendStub.prototype.disableProfiler):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.get resourceTrackingEnabled): (WebInspector.ResourcesPanel.prototype.get visibleView): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasEnabled): (WebInspector.ResourcesPanel.prototype.resourceTrackingWasDisabled): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype._enableResourceTracking): (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
10:43 Changeset [55534] by jam@chromium.org

Update test expectations from my recent checkin

10:43 Changeset [55533] by chang.shu@nokia.com

Committed by Chang Shu: commit manually for bug 35687.

10:17 Changeset [55532] by eric@webkit.org

2010-03-04 Antoine Quint <ml@graougraou.com>

Reviewed by Darin Adler.

DOM insertion mutation events should dispatch after a node is attached to the render tree
https://bugs.webkit.org/show_bug.cgi?id=35590

  • fast/events/domnodeinsertedintodocument-dispatched-post-rendering-expected.txt: Added.
  • fast/events/domnodeinsertedintodocument-dispatched-post-rendering.html: Added.

2010-03-04 Antoine Quint <ml@graougraou.com>

Reviewed by Darin Adler.

DOM insertion mutation events should dispatch after a node is attached to the render tree
https://bugs.webkit.org/show_bug.cgi?id=35590

Test: fast/events/domnodeinsertedintodocument-dispatched-post-rendering.html

Split off the internal-to-WebCore node insertion notification code from the DOM mutation
event dispatching, originally in dispatchChildInsertionEvents(), to a new static function
called notifyChildInserted(). This allows us to dispatch the mutation events at a later
time upon insertion of a child into to the tree, specifically _after_ attachment to the render
tree.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildInsertionEvents):
10:00 Changeset [55531] by eric@webkit.org

2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Holger Freyther.

Make paths relocatable on runtime on Windows
https://bugs.webkit.org/show_bug.cgi?id=32711

  • platform/graphics/gtk/ImageGtk.cpp: (get_webkit_datadir): (WebCore::Image::loadPlatformResource):
09:35 Changeset [55530] by pfeldman@chromium.org

2010-03-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Popup for Timeline panel will work in a tooltip mode

https://bugs.webkit.org/show_bug.cgi?id=35680

09:25 Changeset [55529] by beidson@apple.com

REGRESSION (31281): -[WebArchive initWithCoder:] leaks
<rdar://problem/7702420> and https://bugs.webkit.org/show_bug.cgi?id=35534

Reviewed by Geoff Garen.

  • WebView/WebArchive.mm:

(-[WebArchive initWithCoder:]): Don't retain objects we don't own.

09:18 Changeset [55528] by laszlo.1.gombos@nokia.com

2010-03-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed build fix.

Build fix after r55464.

No new tests, no new functionality.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
08:14 Changeset [55527] by ossy@webkit.org

Unreviewed.

[Qt] storage/open-database-creation-callback-isolated-world.html was removed
from tree by r55488, so it should be removed from Qt Skipped list too.

  • platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html removed.
07:41 Changeset [55526] by eric@webkit.org

2010-03-04 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to platform/graphics/efl.
http://webkit.org/b/35539

  • platform/graphics/efl/FloatRectEfl.cpp: Added.
  • platform/graphics/efl/FontEfl.cpp: Added.
  • platform/graphics/efl/IconEfl.cpp: Added.
  • platform/graphics/efl/ImageEfl.cpp: Added.
  • platform/graphics/efl/IntPointEfl.cpp: Added.
  • platform/graphics/efl/IntRectEfl.cpp: Added.
07:25 Changeset [55525] by eric@webkit.org

2010-03-04 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to platform/text/efl.
http://webkit.org/b/35740

  • platform/text/efl/TextBreakIteratorInternalICUEfl.cpp: Added.
07:03 Changeset [55524] by eric@webkit.org

2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=35726
Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID

Removing orphaned #if USE.

  • GNUmakefile.am:

2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=35726
Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID

Removing orphaned #if USE.

  • platform/ThreadGlobalData.h:
06:24 Changeset [55523] by jorlow@chromium.org

Trottle sync requests sent to the LocalStorage background thread
https://bugs.webkit.org/show_bug.cgi?id=34943

Reviewed by Darin Fisher.

Currently, once a second LocalStorage takes all keys/values which have
been changed and sends them to a background thread to sync. The problem
is that this background thread can get overwhelmed and stop being
responsive. This means that if any other page tries to start using
LocalStorage (and thus initiates the initial import) that'll block on
all the previous syncs completing.

To mitigate this, I'm adding code so that we never schedule another
sync task when another is still running. In order to keep the sync
tasks from growing exponentially when they do take longer than the
storage sync interval, I've also added a basic rate limiter. No effort
is made to ensure fairness/ordering of what gets synced nor is there
any way for this rate to be changed because most normal uses of
LocalStorage really shouldn't be hitting these types of limits anyway.

The only behavioral change that's observible in JavaScript is time based
and thus it's not practical to make new tests that aren't racy. The
existing layout tests cover LocalStorage pretty well, though.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::scheduleFinalSync):
(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::performSync):

  • storage/StorageAreaSync.h:
06:00 Changeset [55522] by pfeldman@chromium.org

2010-03-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Added support for worker instrumentation in inspector
(display list of active workers, allow debugging of workers
by injecting fake JS implementation)

https://bugs.webkit.org/show_bug.cgi?id=35568

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
  • dom/Document.cpp: (WebCore::Document::inspectorController):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::inspectorController):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectScript): (WebCore::InjectedScriptHost::nextWorkerId): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::willDestroyWorker):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::willDestroyWorker):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCreateWorker): (WebCore::InspectorFrontend::willDestroyWorker):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorWorkerResource.h: Added. (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::url): (WebCore::InspectorWorkerResource::isSharedWorker): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
  • inspector/front-end/Checkbox.js: Added. (WebInspector.Checkbox.callbackWrapper): (WebInspector.Checkbox): (WebInspector.Checkbox.prototype.checked):
  • inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._handleException): (InjectedFakeWorker.FakeWorker.prototype._importScripts): (InjectedFakeWorker.FakeWorker.prototype._loadScript): (InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WorkersSidebarPane.js: Added. (WebInspector.WorkersSidebarPane): (WebInspector.WorkersSidebarPane.prototype.addWorker): (WebInspector.WorkersSidebarPane.prototype.removeWorker): (WebInspector.WorkersSidebarPane.prototype.setInstrumentation): (WebInspector.WorkersSidebarPane.prototype.reset): (WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument): (WebInspector.Worker): (WebInspector.didCreateWorker): (WebInspector.willDestroyWorker):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker): (WebCore::AbstractWorker::contextDestroyed):
  • workers/AbstractWorker.h: (WebCore::AbstractWorker::id):
  • workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
  • workers/Worker.cpp: (WebCore::Worker::Worker):
05:58 Changeset [55521] by hamaji@chromium.org

2010-03-04 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed. Remove a non-ASCII character introduced in the following bug.

put_by_id does will incorrectly cache writes where a specific value exists, where at the point of caching the same value is being written.
https://bugs.webkit.org/show_bug.cgi?id=35537

  • runtime/JSObject.h: (JSC::JSObject::putDirectInternal):
05:39 Changeset [55520] by jocelyn.turcotte@nokia.com

[Qt] Make the OUTPUT_DIR variable in qmake projects independent of build-webkit's logic.

Reviewed by Tor Arne Vestbø.

This also allows shadow builds relying only on qmake to work properly.

.:

  • WebKit.pri:

JavaScriptCore:

  • jsc.pro:
  • qt/api/QtScript.pro:
  • qt/tests/qscriptengine/qscriptengine.pro:
  • qt/tests/qscriptvalue/qscriptvalue.pro:
  • qt/tests/tests.pri:

WebCore:

  • WebCore.pro:

WebKit\qt:

  • tests/benchmarks/loading/loading.pro:
  • tests/benchmarks/painting/painting.pro:
  • tests/hybridPixmap/hybridPixmap.pro:
  • tests/qgraphicswebview/qgraphicswebview.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebinspector/qwebinspector.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebplugindatabase/qwebplugindatabase.pro:

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/ImageDiff.pro:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • QtLauncher/QtLauncher.pro:
05:17 QtWebKitBugs edited by hausmann@webkit.org
(diff)
04:46 Changeset [55519] by ossy@webkit.org

Enable to use built-product-archive on Qt platform.

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-03-04
Reviewed by Kenneth Rohde Christiansen.

  • BuildSlaveSupport/built-product-archive:
04:29 Changeset [55518] by zecke@webkit.org

[Qt] Avoid calling QFont::detach too often from FontQt

https://bugs.webkit.org/show_bug.cgi?id=35569

The letter- and wordspacing is inside the WebCore::Font class,
our QFont is located in the WebCore::FontPlatformData. Everytime
we need to use a QFont inside WebCore::Font we are calling the
font method which gets the QFont from the WebCore::FontPlatformData
and is applying the letter- and wordspacing. Internally this
will attempt to detach the QFont...

Avoid calling setLetterSpacing and setWordSpacing on QFont if
the WebCore::Font has the default applied.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::font):

04:21 Changeset [55517] by apavlov@chromium.org

2010-03-04 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Nothing happens on navigation to resource via a link if resource tracking is disabled
https://bugs.webkit.org/show_bug.cgi?id=35574

03:04 Changeset [55516] by abecsi@webkit.org

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] DRT is failing on new test introduced in r55499
Skipping it until fix.
https://bugs.webkit.org/show_bug.cgi?id=35729

  • platform/qt/Skipped: fast/events/zoom-dblclick.html skipped
02:45 Changeset [55515] by vestbo@webkit.org

[Qt] Fix generation of forwaring headers

Reviewed by Kenneth Rohde Christiansen.

The dependencies were a bit wrong, so we ended up not generating
forwarding headers for qwebkitversion.h and qwebkitglobal.h

The forwardning headers are now the only targets depending on the
real headers. All other targets either depend on the generated
class headers, or the forwarding headers.

  • Api/DerivedSources.pro:
01:41 Changeset [55514] by eric@webkit.org

2010-03-04 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Oliver Hunt.

Update existing test to check that getUniformLocation() returns
null if the uniform requested is not found.
https://bugs.webkit.org/show_bug.cgi?id=34669

  • fast/canvas/webgl/script-tests/uniform-location.js:
  • fast/canvas/webgl/uniform-location-expected.txt:

2010-03-04 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Oliver Hunt.

getUniformLocation() now returns null if uniform requested
is not found.
https://bugs.webkit.org/show_bug.cgi?id=34669

Test:LayoutTests/fast/canvas/webgl/uniform-location.html
(added missing test)

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniformLocation):
01:24 Changeset [55513] by eric@webkit.org

2010-03-04 John Abd-El-Malek <jam@chromium.org>

Reviewed by Adam Barth.

Fix incorrect setup of DateExtension.
https://bugs.webkit.org/show_bug.cgi?id=35710

  • fast/dom/Window/resources/slow_unload_handler1.html:

2010-03-04 John Abd-El-Malek <jam@chromium.org>

Reviewed by Adam Barth.

Fix incorrect setup of DateExtension.
https://bugs.webkit.org/show_bug.cgi?id=35710

  • bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep):
01:13 Changeset [55512] by darin@chromium.org

2010-03-04 Darin Fisher <darin@chromium.org>

Reviewed by Pavel Feldman.

Fix failing DevToolsSanityTest.TestResourceContentLength
https://bugs.webkit.org/show_bug.cgi?id=35725

http://trac.webkit.org/changeset/55466 missed one more spot
where contentLength needed to be renamed resourceSize.

  • src/js/Tests.js:
00:57 Changeset [55511] by oliver@apple.com

2010-03-04 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=35603
SVG incorrectly allows nested <use> elements in a <use> shadow tree

Simplify the handling of invalid or missing use-targets by cloning them
to empty <g> elements rather than just allowing the <use> element to
be copied into the shadow tree, as this violates a number of assumptions
in the shadow tree handling code.

Tests: svg/custom/use-nested-disallowed-target.svg

svg/custom/use-nested-missing-target-added.svg
svg/custom/use-nested-missing-target-removed.svg
svg/custom/use-nested-missing-target.svg
svg/custom/use-nested-notarget.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource): (WebCore::SVGUseElement::buildShadowAndInstanceTree): (WebCore::SVGUseElement::expandUseElementsInShadowTree):

2010-03-04 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=35603
SVG incorrectly allows nested <use> elements in a <use> shadow tree

Add test cases for various combinations of <use> and targets that aren't present.

  • platform/mac/svg/custom/use-empty-reference-expected.txt: Added.
  • svg/custom/use-nested-disallowed-target-expected.txt: Added.
  • svg/custom/use-nested-disallowed-target.svg: Added.
  • svg/custom/use-nested-missing-target-added-expected.txt: Added.
  • svg/custom/use-nested-missing-target-added.svg: Added.
  • svg/custom/use-nested-missing-target-expected.txt: Added.
  • svg/custom/use-nested-missing-target-removed-expected.txt: Added.
  • svg/custom/use-nested-missing-target-removed.svg: Added.
  • svg/custom/use-nested-missing-target.svg: Added.
  • svg/custom/use-nested-notarget-expected.txt: Added.
  • svg/custom/use-nested-notarget.svg: Added.
00:51 Changeset [55510] by eric@webkit.org

2010-03-04 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Move Cairo-related font code from platform/graphics/gtk to
platform/graphics/cairo, so other ports may use them.
http://webkit.org/b/35539

  • GNUmakefile.am:
  • platform/graphics/cairo/FontCacheCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontCacheGtk.cpp.
  • platform/graphics/cairo/FontCustomPlatformData.cpp: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.cpp.
  • platform/graphics/cairo/FontCustomPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.h.
  • platform/graphics/cairo/FontPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontPlatformData.h.
  • platform/graphics/cairo/FontPlatformDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp.
  • platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: Copied from WebCore/platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp.
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/SimpleFontDataGtk.cpp.
  • platform/graphics/gtk/FontCacheGtk.cpp: Removed.
  • platform/graphics/gtk/FontCustomPlatformData.cpp: Removed.
  • platform/graphics/gtk/FontCustomPlatformData.h: Removed.
  • platform/graphics/gtk/FontPlatformData.h: Removed.
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: Removed.
  • platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp: Removed.
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: Removed.
00:34 Changeset [55509] by eric@webkit.org

2010-03-04 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs with Skia

This test passes if it doesn't crash.

  • platform/mac/Skipped: Skip the test on Mac, where it crashes.
  • svg/custom/tiling-regular-hexagonal-crash-expected.txt: Added.
  • svg/custom/tiling-regular-hexagonal-crash.svg: Added.

2010-03-04 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=35261
[skia] crash when attempting to render certain SVGs

This fixes the crash, but the SVG still doesn't render properly.

Test: svg/custom/tiling-regular-hexagonal-crash.svg

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::create): don't return 0 when the copy fails; instead return a blank bitmap. The caller doesn't check for 0 before dereferencing.
00:03 Changeset [55508] by tony@chromium.org

2010-03-04 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Initialize m_isMultipartPayload in other ResourceResponse ctor.
In r55451 (bug 35628) I added an extra bool, but only initialized
it in one constructor.
https://bugs.webkit.org/show_bug.cgi?id=35719

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
00:01 Changeset [55507] by eric@webkit.org

2010-03-03 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Adding touch event type and point type. Tested against the try bots.
https://bugs.webkit.org/show_bug.cgi?id=35691

  • public/WebInputEvent.h: (WebKit::WebInputEvent::): (WebKit::WebInputEvent::isTouchEventType): (WebKit::WebTouchEvent::WebTouchEvent):
  • public/WebTouchPoint.h: Added. (WebKit::WebTouchPoint::WebTouchPoint): (WebKit::WebTouchPoint::):

03/03/10:

23:18 Changeset [55506] by bweinstein@apple.com

Touch WebKit.idl to force a rebuild of Interfaces

22:10 Changeset [55505] by ukai@chromium.org

2010-03-03 Yuta Kitamura <yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

Add a new class that stores information about Web Socket handshake request.

Instances of this class contain the necessary information to send a Web Socket
handshake request. In the future, this class will provide request information
to the Web Inspector.

WebSocketHandshake needs to provide request information
https://bugs.webkit.org/show_bug.cgi?id=34784

No new tests, since the current tests will suffice (LayoutTests/websocket/*).

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/WebSocketChannel.cpp:
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::clientHandshakeMessage): (WebCore::WebSocketHandshake::clientHandshakeRequest):
  • websockets/WebSocketHandshake.h:
  • websockets/WebSocketHandshakeRequest.cpp: Added. (WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest): (WebCore::WebSocketHandshakeRequest::~WebSocketHandshakeRequest): (WebCore::WebSocketHandshakeRequest::addExtraHeaderField): (WebCore::WebSocketHandshakeRequest::headerFields): (WebCore::WebSocketHandshakeRequest::host):
  • websockets/WebSocketHandshakeRequest.h: Added.
21:19 Changeset [55504] by eric@webkit.org

2010-03-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Build fix after r55452.

No new tests, this is a build fix.

  • page/Settings.cpp: (WebCore::Settings::setDatabasesEnabled):
21:17 Changeset [55503] by alice.liu@apple.com

Add a way to get an iframe's content frame

Reviewed by Jon Honeycutt.

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):
Added case for DOMHTMLIFrameElement

  • DOMHTMLClasses.cpp:

Adding the few DOMHTMLIFrameElement functions definitions that have
distinct implementations (all others just call parent implementation)
(DOMHTMLIFrameElement::QueryInterface):
(DOMHTMLIFrameElement::contentFrame):

  • DOMHTMLClasses.h:

Most of these function declarations have definitions that just call the parent implementation
(DOMHTMLIFrameElement::DOMHTMLIFrameElement):
(DOMHTMLIFrameElement::AddRef):
(DOMHTMLIFrameElement::Release):
(DOMHTMLIFrameElement::throwException):
(DOMHTMLIFrameElement::callWebScriptMethod):
(DOMHTMLIFrameElement::evaluateWebScript):
(DOMHTMLIFrameElement::removeWebScriptKey):
(DOMHTMLIFrameElement::stringRepresentation):
(DOMHTMLIFrameElement::webScriptValueAtIndex):
(DOMHTMLIFrameElement::setWebScriptValueAtIndex):
(DOMHTMLIFrameElement::setException):
(DOMHTMLIFrameElement::nodeName):
(DOMHTMLIFrameElement::nodeValue):
(DOMHTMLIFrameElement::setNodeValue):
(DOMHTMLIFrameElement::nodeType):
(DOMHTMLIFrameElement::parentNode):
(DOMHTMLIFrameElement::childNodes):
(DOMHTMLIFrameElement::firstChild):
(DOMHTMLIFrameElement::lastChild):
(DOMHTMLIFrameElement::previousSibling):
(DOMHTMLIFrameElement::nextSibling):
(DOMHTMLIFrameElement::attributes):
(DOMHTMLIFrameElement::ownerDocument):
(DOMHTMLIFrameElement::insertBefore):
(DOMHTMLIFrameElement::replaceChild):
(DOMHTMLIFrameElement::removeChild):
(DOMHTMLIFrameElement::appendChild):
(DOMHTMLIFrameElement::hasChildNodes):
(DOMHTMLIFrameElement::cloneNode):
(DOMHTMLIFrameElement::normalize):
(DOMHTMLIFrameElement::isSupported):
(DOMHTMLIFrameElement::namespaceURI):
(DOMHTMLIFrameElement::prefix):
(DOMHTMLIFrameElement::setPrefix):
(DOMHTMLIFrameElement::localName):
(DOMHTMLIFrameElement::hasAttributes):
(DOMHTMLIFrameElement::isSameNode):
(DOMHTMLIFrameElement::isEqualNode):
(DOMHTMLIFrameElement::textContent):
(DOMHTMLIFrameElement::setTextContent):
(DOMHTMLIFrameElement::tagName):
(DOMHTMLIFrameElement::getAttribute):
(DOMHTMLIFrameElement::setAttribute):
(DOMHTMLIFrameElement::removeAttribute):
(DOMHTMLIFrameElement::getAttributeNode):
(DOMHTMLIFrameElement::setAttributeNode):
(DOMHTMLIFrameElement::removeAttributeNode):
(DOMHTMLIFrameElement::getElementsByTagName):
(DOMHTMLIFrameElement::getAttributeNS):
(DOMHTMLIFrameElement::setAttributeNS):
(DOMHTMLIFrameElement::removeAttributeNS):
(DOMHTMLIFrameElement::getAttributeNodeNS):
(DOMHTMLIFrameElement::setAttributeNodeNS):
(DOMHTMLIFrameElement::getElementsByTagNameNS):
(DOMHTMLIFrameElement::hasAttribute):
(DOMHTMLIFrameElement::hasAttributeNS):
(DOMHTMLIFrameElement::focus):
(DOMHTMLIFrameElement::blur):
(DOMHTMLIFrameElement::idName):
(DOMHTMLIFrameElement::setIdName):
(DOMHTMLIFrameElement::title):
(DOMHTMLIFrameElement::setTitle):
(DOMHTMLIFrameElement::lang):
(DOMHTMLIFrameElement::setLang):
(DOMHTMLIFrameElement::dir):
(DOMHTMLIFrameElement::setDir):
(DOMHTMLIFrameElement::className):
(DOMHTMLIFrameElement::setClassName):
(DOMHTMLIFrameElement::innerHTML):
(DOMHTMLIFrameElement::setInnerHTML):
(DOMHTMLIFrameElement::innerText):
(DOMHTMLIFrameElement::setInnerText):

  • Interfaces/DOMHTML.idl:

Added IDOMHTMLIFrameElement interface

21:02 Changeset [55502] by eric@webkit.org

2010-03-03 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

QScriptValue::isObject fix.

Fix broken internal state evaluation from JSValue to JSNative / JSObject.
New function was introduced which should take care about promoting
JSValue state inside QScriptValuePrivate. It should be used instead of a
direct JSC C API call.

The bug exposed a weakness in autotest suite, as the QScriptValuePrivate
is based on state machine with lazy state evaluation, there is a possibility
that serial sequencial calls to the same public const function could return
different results. The patch fix the issue.

[Qt] Sometimes QScriptValue::isObject returns an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=35387

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::isError): (QScriptValuePrivate::isObject): (QScriptValuePrivate::isFunction): (QScriptValuePrivate::call): (QScriptValuePrivate::refineJSValue):
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: (tst_QScriptValue::initScriptValues): (tst_QScriptValue::isValid_makeData): (tst_QScriptValue::isValid_test): (tst_QScriptValue::isBool_makeData): (tst_QScriptValue::isBool_test): (tst_QScriptValue::isBoolean_makeData): (tst_QScriptValue::isBoolean_test): (tst_QScriptValue::isNumber_makeData): (tst_QScriptValue::isNumber_test): (tst_QScriptValue::isFunction_test): (tst_QScriptValue::isNull_makeData): (tst_QScriptValue::isNull_test): (tst_QScriptValue::isString_makeData): (tst_QScriptValue::isString_test): (tst_QScriptValue::isUndefined_makeData): (tst_QScriptValue::isUndefined_test): (tst_QScriptValue::isObject_makeData): (tst_QScriptValue::isObject_test): (tst_QScriptValue::toString_makeData): (tst_QScriptValue::toString_test): (tst_QScriptValue::toNumber_makeData): (tst_QScriptValue::toNumber_test): (tst_QScriptValue::toBool_makeData): (tst_QScriptValue::toBool_test): (tst_QScriptValue::toBoolean_makeData): (tst_QScriptValue::toBoolean_test): (tst_QScriptValue::toInteger_makeData): (tst_QScriptValue::toInteger_test): (tst_QScriptValue::toInt32_makeData): (tst_QScriptValue::toInt32_test): (tst_QScriptValue::toUInt32_makeData): (tst_QScriptValue::toUInt32_test): (tst_QScriptValue::toUInt16_makeData): (tst_QScriptValue::toUInt16_test):
20:45 Changeset [55501] by eric@webkit.org

2010-03-03 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent

LayoutTests:

fast/events/key-events-in-input-text.html
fast/events/special-key-events-in-input-text.html

[Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=35694

  • platform/qt/Skipped:

2010-03-03 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent

LayoutTests:

fast/events/key-events-in-input-text.html
fast/events/special-key-events-in-input-text.html

[Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=35694

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode):
19:57 Changeset [55500] by eric@webkit.org

2010-03-03 Chao-ying Fu <fu@mips.com>

Reviewed by Gavin Barraclough.

MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144

The following changes enable MIPS YARR and YARR_JIT.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MIPSAssembler.h: Added. (JSC::MIPSRegisters::): (JSC::MIPSAssembler::MIPSAssembler): (JSC::MIPSAssembler::): (JSC::MIPSAssembler::JmpSrc::JmpSrc): (JSC::MIPSAssembler::JmpDst::JmpDst): (JSC::MIPSAssembler::JmpDst::isUsed): (JSC::MIPSAssembler::JmpDst::used): (JSC::MIPSAssembler::emitInst): (JSC::MIPSAssembler::nop): (JSC::MIPSAssembler::loadDelayNop): (JSC::MIPSAssembler::copDelayNop): (JSC::MIPSAssembler::move): (JSC::MIPSAssembler::li): (JSC::MIPSAssembler::lui): (JSC::MIPSAssembler::addiu): (JSC::MIPSAssembler::addu): (JSC::MIPSAssembler::subu): (JSC::MIPSAssembler::mult): (JSC::MIPSAssembler::mfhi): (JSC::MIPSAssembler::mflo): (JSC::MIPSAssembler::mul): (JSC::MIPSAssembler::andInsn): (JSC::MIPSAssembler::andi): (JSC::MIPSAssembler::nor): (JSC::MIPSAssembler::orInsn): (JSC::MIPSAssembler::ori): (JSC::MIPSAssembler::xorInsn): (JSC::MIPSAssembler::xori): (JSC::MIPSAssembler::slt): (JSC::MIPSAssembler::sltu): (JSC::MIPSAssembler::sltiu): (JSC::MIPSAssembler::sll): (JSC::MIPSAssembler::sllv): (JSC::MIPSAssembler::sra): (JSC::MIPSAssembler::srav): (JSC::MIPSAssembler::lw): (JSC::MIPSAssembler::lwl): (JSC::MIPSAssembler::lwr): (JSC::MIPSAssembler::lhu): (JSC::MIPSAssembler::sw): (JSC::MIPSAssembler::jr): (JSC::MIPSAssembler::jalr): (JSC::MIPSAssembler::jal): (JSC::MIPSAssembler::bkpt): (JSC::MIPSAssembler::bgez): (JSC::MIPSAssembler::bltz): (JSC::MIPSAssembler::beq): (JSC::MIPSAssembler::bne): (JSC::MIPSAssembler::bc1t): (JSC::MIPSAssembler::bc1f): (JSC::MIPSAssembler::newJmpSrc): (JSC::MIPSAssembler::appendJump): (JSC::MIPSAssembler::addd): (JSC::MIPSAssembler::subd): (JSC::MIPSAssembler::muld): (JSC::MIPSAssembler::lwc1): (JSC::MIPSAssembler::ldc1): (JSC::MIPSAssembler::swc1): (JSC::MIPSAssembler::sdc1): (JSC::MIPSAssembler::mtc1): (JSC::MIPSAssembler::mfc1): (JSC::MIPSAssembler::truncwd): (JSC::MIPSAssembler::cvtdw): (JSC::MIPSAssembler::ceqd): (JSC::MIPSAssembler::cngtd): (JSC::MIPSAssembler::cnged): (JSC::MIPSAssembler::cltd): (JSC::MIPSAssembler::cled): (JSC::MIPSAssembler::cueqd): (JSC::MIPSAssembler::coled): (JSC::MIPSAssembler::coltd): (JSC::MIPSAssembler::culed): (JSC::MIPSAssembler::cultd): (JSC::MIPSAssembler::label): (JSC::MIPSAssembler::align): (JSC::MIPSAssembler::getRelocatedAddress): (JSC::MIPSAssembler::getDifferenceBetweenLabels): (JSC::MIPSAssembler::size): (JSC::MIPSAssembler::executableCopy): (JSC::MIPSAssembler::getCallReturnOffset): (JSC::MIPSAssembler::linkJump): (JSC::MIPSAssembler::linkCall): (JSC::MIPSAssembler::linkPointer): (JSC::MIPSAssembler::relinkJump): (JSC::MIPSAssembler::relinkCall): (JSC::MIPSAssembler::repatchInt32): (JSC::MIPSAssembler::repatchPointer): (JSC::MIPSAssembler::repatchLoadPtrToLEA): (JSC::MIPSAssembler::relocateJumps): (JSC::MIPSAssembler::linkWithOffset): (JSC::MIPSAssembler::linkCallInternal):
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerMIPS.h: Added. (JSC::MacroAssemblerMIPS::MacroAssemblerMIPS): (JSC::MacroAssemblerMIPS::): (JSC::MacroAssemblerMIPS::add32): (JSC::MacroAssemblerMIPS::and32): (JSC::MacroAssemblerMIPS::lshift32): (JSC::MacroAssemblerMIPS::mul32): (JSC::MacroAssemblerMIPS::not32): (JSC::MacroAssemblerMIPS::or32): (JSC::MacroAssemblerMIPS::rshift32): (JSC::MacroAssemblerMIPS::sub32): (JSC::MacroAssemblerMIPS::xor32): (JSC::MacroAssemblerMIPS::load32): (JSC::MacroAssemblerMIPS::load32WithUnalignedHalfWords): (JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::loadPtrWithPatchToLEA): (JSC::MacroAssemblerMIPS::loadPtrWithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::load16): (JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch): (JSC::MacroAssemblerMIPS::store32): (JSC::MacroAssemblerMIPS::supportsFloatingPoint): (JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate): (JSC::MacroAssemblerMIPS::pop): (JSC::MacroAssemblerMIPS::push): (JSC::MacroAssemblerMIPS::move): (JSC::MacroAssemblerMIPS::swap): (JSC::MacroAssemblerMIPS::signExtend32ToPtr): (JSC::MacroAssemblerMIPS::zeroExtend32ToPtr): (JSC::MacroAssemblerMIPS::branch32): (JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerMIPS::branch16): (JSC::MacroAssemblerMIPS::branchTest32): (JSC::MacroAssemblerMIPS::jump): (JSC::MacroAssemblerMIPS::branchAdd32): (JSC::MacroAssemblerMIPS::branchMul32): (JSC::MacroAssemblerMIPS::branchSub32): (JSC::MacroAssemblerMIPS::breakpoint): (JSC::MacroAssemblerMIPS::nearCall): (JSC::MacroAssemblerMIPS::call): (JSC::MacroAssemblerMIPS::ret): (JSC::MacroAssemblerMIPS::set32): (JSC::MacroAssemblerMIPS::setTest32): (JSC::MacroAssemblerMIPS::moveWithPatch): (JSC::MacroAssemblerMIPS::branchPtrWithPatch): (JSC::MacroAssemblerMIPS::storePtrWithPatch): (JSC::MacroAssemblerMIPS::tailRecursiveCall): (JSC::MacroAssemblerMIPS::makeTailRecursiveCall): (JSC::MacroAssemblerMIPS::loadDouble): (JSC::MacroAssemblerMIPS::storeDouble): (JSC::MacroAssemblerMIPS::addDouble): (JSC::MacroAssemblerMIPS::subDouble): (JSC::MacroAssemblerMIPS::mulDouble): (JSC::MacroAssemblerMIPS::convertInt32ToDouble): (JSC::MacroAssemblerMIPS::insertRelaxationWords): (JSC::MacroAssemblerMIPS::branchTrue): (JSC::MacroAssemblerMIPS::branchFalse): (JSC::MacroAssemblerMIPS::branchEqual): (JSC::MacroAssemblerMIPS::branchNotEqual): (JSC::MacroAssemblerMIPS::branchDouble): (JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32): (JSC::MacroAssemblerMIPS::linkCall): (JSC::MacroAssemblerMIPS::repatchCall):
  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
  • wtf/Platform.h:
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn):
19:31 Changeset [55499] by eric@webkit.org

2010-03-03 Chad Faragher <wyck@chromium.org>

Reviewed by Darin Adler.

Changed the double-click framework code to pass adjusted page
coordinates for zoomed pages. Added a new test to expose
mistreatment of mouse click coordinates during a double-click.

https://bugs.webkit.org/show_bug.cgi?id=35690

  • fast/events/zoom-dblclick-expected.txt: Added.
  • fast/events/zoom-dblclick.html: Added.

2010-03-03 Chad Faragher <wyck@chromium.org>

Reviewed by Darin Adler.
Changed the double-click framework code to pass adjusted page
coordinates for zoomed pages. Added a new test to expose
mistreatment of mouse click coordinates during a double-click.

https://bugs.webkit.org/show_bug.cgi?id=35690

Test: fast/events/zoom-dblclick.html

  • dom/Node.cpp: (WebCore::Node::dispatchMouseEvent):
19:13 Changeset [55498] by eric@webkit.org

2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Simon Hausmann.

Add a missing 'm_' to class variables names.

[Qt] QtLauncher is not respecting class variable names
https://bugs.webkit.org/show_bug.cgi?id=35542

  • QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::init): (LauncherWindow::sendTouchEvent): (LauncherWindow::eventFilter): (LauncherWindow::zoomIn): (LauncherWindow::zoomOut): (LauncherWindow::resetZoom): (LauncherWindow::setEditable): (LauncherWindow::setTouchMocking): (LauncherWindow::initializeView): (LauncherWindow::createChrome):
19:00 Changeset [55497] by sfalken@apple.com

Remove extraneous ChangeLog entries.

18:56 Changeset [55496] by sfalken@apple.com

Merged r55495.

18:52 Changeset [55495] by sfalken@apple.com

Windows build fix.

18:42 Changeset [55494] by sfalken@apple.com

Merge r55492.

18:35 Changeset [55493] by sfalken@apple.com

New tag.

18:33 Changeset [55492] by sfalken@apple.com

Windows build fix.

17:23 Changeset [55491] by levin@chromium.org

No review, rolling out r55474.

The patch broke fast/frames/sandboxed-iframe-storage.html

Last one (I hope).

  • WebCore.xcodeproj/project.pbxproj:
17:20 Changeset [55490] by dumi@chromium.org

Making database-lock-after-reload.html a bit more robust and
cleaning up some style issues.

Reviewed by Dimitri Glazkov.

  • storage/database-lock-after-reload.html:
  • storage/resources/database-lock-after-reload-2.html:
17:14 Changeset [55489] by ap@apple.com

Rubber-stamped by Mark Rowe.

Exclude leaks in Java that build bot complains about.

  • Scripts/run-webkit-tests:
17:09 Changeset [55488] by levin@chromium.org

No review, rolling out r55474.

The patch broke fast/frames/sandboxed-iframe-storage.html

Unfortunately, (the webkit-patch rollout and) I missed these in r55485.

WebCore:

  • bindings/js/JSDatabaseCallback.cpp: Removed.
  • bindings/js/JSDatabaseCallback.h: Removed.
  • bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
  • bindings/v8/custom/V8DatabaseCallback.h: Removed.
  • storage/DatabaseCallback.h: Removed.

LayoutTests:

  • storage/open-database-creation-callback-expected.txt: Removed.
  • storage/open-database-creation-callback-isolated-world-expected.txt: Removed.
  • storage/open-database-creation-callback-isolated-world.html: Removed.
  • storage/open-database-creation-callback.html: Removed.
17:01 Changeset [55487] by dumi@chromium.org

Fix a bug that could lead to a crash. Some parts of
SQLTransaction::checkAndHandleClosedDatabase() should only be run
when that method is invoked on the DB thread.

Reviewed by Dimitri Glazkov.

We cannot test this fix with a test, because the crash happens
only when all of the following conditions are met:

  1. A database is closing.
  2. A transaction on that database is in progress.
  3. The transaction is in a state where a statement/transaction

success/error callback needs to be invoked (so there's a task for
this transaction pending on the main thread).

  1. The DB thread finished processing all its tasks and called

SQLTransactionCoordinator::shutdown() before the main thread go to
that task.

The closest thing we have to a test is running
LayoutTests/storage/database-lock-after-reload.html 1000 times in
a row. Without the patch, the probability of a crash happening in
one of the runs is very high. With the patch, the test should
reliably run 1000 times in a row without a single crash.

https://bugs.webkit.org/show_bug.cgi?id=35624

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::checkAndHandleClosedDatabase):

16:47 Changeset [55486] by darin@chromium.org

2010-03-03 Darin Fisher <darin@chromium.org>

Reviewed by Mark Rowe.

Page should not care about Chromium plug-in implementation details
https://bugs.webkit.org/show_bug.cgi?id=35623

  • WebCore.gypi: Compile PluginViewNone.cpp
  • page/Page.cpp: (WebCore::Page::privateBrowsingStateChanged): Remove conditional compilation for PLATFORM(CHROMIUM).
16:38 Changeset [55485] by levin@chromium.org

2010-03-03 David Levin <levin@chromium.org>

No review, rolling out r55474.
http://trac.webkit.org/changeset/55480

The patch broke fast/frames/sandboxed-iframe-storage.html

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • dom/Document.cpp: (WebCore::Document::postTask):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::openDatabase):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify):
  • storage/Database.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::openDatabase):
  • workers/WorkerContext.h:
16:36 Changeset [55484] by levin@chromium.org

2010-03-03 David Levin <levin@chromium.org>

No review, rolling out r55480.
http://trac.webkit.org/changeset/55480

The patch broke fast/frames/sandboxed-iframe-storage.html

  • storage/Database.cpp:
  • storage/Database.h:
16:22 Changeset [55483] by mrowe@apple.com

Add virtual memory tags for TCMalloc and WebCore's purgeable buffers.

Reviewed by Geoff Garen.

JavaScriptCore:

  • wtf/TCSystemAlloc.cpp:

(TryMmap): Use the VM tag.

  • wtf/VMTags.h: Make use of VM_MEMORY_TCMALLOC and VM_MEMORY_WEBCORE_PURGEABLE_BUFFERS.

WebCore:

  • platform/mac/PurgeableBufferMac.cpp:

(WebCore::PurgeableBuffer::create): Use the VM tag.

16:20 Changeset [55482] by ap@apple.com

Not reviewed.

Try better to fix Java tests on Tiger bot.

  • platform/mac-tiger/Skipped:
  • platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Removed. This test gets different resultson each run when it fails, so it needs to be disabled on Tiger.
  • platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added a newline I didn't get when copying actual results from buildbot.
16:05 Changeset [55481] by cmarrin@apple.com

Additional change to separate Accelerated Compositing test from 3D Rendering test
https://bugs.webkit.org/show_bug.cgi?id=35610

15:03 Changeset [55480] by dumi@chromium.org

Move #include "DatabaseCallback.h" from Database.h to
Database.cpp.

Reviewed by nobody, build fix.

  • storage/Database.cpp:
  • storage/Database.h:
14:55 Changeset [55479] by ossy@webkit.org

[Qt] Skip new test introduced in r55474, because of
missing layoutTestController.evaluateScriptInIsolatedWorld()

  • platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html skipped.
14:24 Changeset [55478] by darin@apple.com

Fixed Mac build.

  • WebCore.xcodeproj/project.pbxproj: Marked a couple of headers "private" so they can

be used in the WebKit project.

14:22 Changeset [55477] by ap@apple.com

Rubber-stamped by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=35700
Some of the newly added Java tests fail randomly on buildbot

  • fast/js/resources/js-test-post-async.js: Added a version that calls notifyDone(). I first wanted to add a notifyDone() call to js-test-post.js, but it turns out that multiple tests dump results after "TEST COMPLETE", and we need to get bots back to green fast.
  • java/lc3: (Many files). Don't load two scripts dynamically, WebKit has issues with order of execution in this case.
14:06 Changeset [55476] by sfalken@apple.com

Rubber stamped by Adam Roben.

Fix bogus xcopy that was polluting source tree at build time.

14:05 Changeset [55475] by ap@apple.com

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=35044
Crash in XML tokenizer reloading zoom-coords-viewattr-01-b.svg

I'm often getting a crash even when opening the test for the first time in Safari, but it
doesn't seem to crash in DumpRenderTree. Still, I can't think of a stronger way to test for
this condition, so no new regression test.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end): Be prepared that parsing remaining input will pause parsing.
13:48 Changeset [55474] by dumi@chromium.org

WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().

Reviewed by Adam Barth.

Test: storage/open-database-creation-callback.html

https://bugs.webkit.org/show_bug.cgi?id=34726

  • Android.jscbindings.mk
  • Android.v8bindings.mk
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCallback.cpp: Added.

(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):

  • bindings/js/JSDatabaseCallback.h: Added.

(WebCore::JSDatabaseCallback::create):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • bindings/v8/custom/V8DatabaseCallback.cpp: Added.

(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):

  • bindings/v8/custom/V8DatabaseCallback.h: Added.

(WebCore::V8DatabaseCallback::create):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/Database.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):

  • storage/Database.h:

(WebCore::Database::isNew):

  • storage/DatabaseCallback.h: Added.

(WebCore::DatabaseCallback::~DatabaseCallback):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):

  • workers/WorkerContext.h:

LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=34726

  • storage/open-database-creation-callback-expected.txt: Added.
  • storage/open-database-creation-callback.html: Added.
  • storage/open-database-creation-callback-isolated-world-expected.txt: Added.
  • storage/open-database-creation-callback-isolated-world.html: Added.
13:33 Changeset [55473] by cmarrin@apple.com

Useless change to kick the Windows build into recompiling the idl files

13:25 Changeset [55472] by bweinstein@apple.com

Touch WebKit.idl to force a rebuild

12:45 Changeset [55471] by ap@apple.com

Not reviewed.

Two newly added Java tests fail on Tiger build bot.

Just land actual results as expected. I don't even know which behavior is more correct.

  • platform/mac-tiger/java: Added.
  • platform/mac-tiger/java/lc3: Added.
  • platform/mac-tiger/java/lc3/JavaArray: Added.
  • platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Added.
  • platform/mac-tiger/java/lc3/JavaObject: Added.
  • platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added.
11:34 Changeset [55470] by ap@apple.com

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=35692
<rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView

  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): Retain the challenge, just like it's done for sheet.
11:15 Changeset [55469] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=35617
Import Mozilla LiveConnect 3 test suite

  • java/lc3/sources: Added (many files). Sources for Mozilla test applet.
  • java/jstests.jar: Added in compiled form, since it's unlikely that we'll ever need to modify the above sources.
  • java/lc3.java: Added. (lc3): This is a small wrapper around jstests.jar. The latter only adds some classes, but WebKit needs an actual applet to call into Java. (lc3.createQAObject): Instantiate a class defined in jstests.jar by name. (lc3.stringToByteArray): A helper to make a byte array out of string. Tests originally relied on window.java package interface to do this, but it's not available in WebKit. We need more functions like this to work around other uses of window.java, but this is one I wrote for now.
  • java/Makefile: Link test applets to Mozilla's jstests.jar. This is not needed for tests other than ones imported here, but it's also harmless, and I don't know how to write good makefiles.
  • java/lc3: Added (many files). Tests were heavily reworked to run to completion, but PASS/FAIL results should not be generally relied upon. All html wrappers are identical.
11:05 Changeset [55468] by eric.carlson@apple.com

2010-03-03 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Update expected results for fast/js/custom-constructors-expected.txt

10:51 Changeset [55467] by cmarrin@apple.com

Enable LayoutTests/compositing for Windows when compositing is available
https://bugs.webkit.org/show_bug.cgi?id=35610

10:20 Changeset [55466] by apavlov@chromium.org

2010-03-03 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: resources panel only shows uncompressed resource size.
https://bugs.webkit.org/show_bug.cgi?id=35403

  • English.lproj/localizedStrings.js:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.refresh):
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
  • inspector/front-end/ImageView.js: (WebInspector.ImageView):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get resourceSize): (WebInspector.Resource.prototype.set resourceSize): (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.CompareBySize): (WebInspector.Resource.CompareByTransferSize):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphPercentages): (WebInspector.ResourceTransferSizeCalculator.prototype._value): (WebInspector.ResourceTransferSizeCalculator.prototype._networkBytes): (WebInspector.ResourceSidebarTreeElement.CompareByDescendingTransferSize): (WebInspector.ResourceGraph.prototype.refreshLabelPositions): (WebInspector.ResourceGraph.prototype.refresh):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
09:42 Changeset [55465] by mitz@apple.com

Build fix.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren):

09:24 Changeset [55464] by pfeldman@chromium.org

2010-03-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Get rid of synchronous debuggerEnabled, profilerEnabled calls.

https://bugs.webkit.org/show_bug.cgi?id=32331

  • inspector/InspectorBackend.cpp:
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._enableProfiling): (WebInspector.ProfilesPanel.prototype._toggleProfiling):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowSourceLine): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
09:19 Changeset [55463] by eric.carlson@apple.com

2010-03-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
https://bugs.webkit.org/show_bug.cgi?id=35385
rdar://problem/7689602

Tests: media/audio-constructor-preload.html

media/video-dom-preload.html

  • html/HTMLAttributeNames.in: Remove autobuffer, add preload
  • html/HTMLAudioElement.cpp: (WebCore::HTMLAudioElement::createForJSConstructor): set preload to 'auto' instead of

autobuffer to true.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_preload. (WebCore::HTMLMediaElement::parseMappedAttribute): Deal with 'preload' attribute. (WebCore::HTMLMediaElement::loadResource): Call setPreload() on the newly created MediaPlayer,

before calling load() so it can pass the setting through to the media engine.

(WebCore::HTMLMediaElement::preload): New.
(WebCore::HTMLMediaElement::setPreload): Ditto

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_preload. (WebCore::MediaPlayer::load): Pass m_preload to newly created media engine. (WebCore::MediaPlayer::preload): New, return m_preload. (WebCore::MediaPlayer::setPreload): New, set m_preload.
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::):
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPreload):
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::setPreload): Renamed from setAutoplay, fix logic for preload.
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

2010-03-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
https://bugs.webkit.org/show_bug.cgi?id=35385
rdar://problem/7689602

  • media/audio-constructor-autobuffer-expected.txt: Removed.
  • media/audio-constructor-autobuffer.html: Removed.
  • media/audio-constructor-preload-expected.txt: Added.
  • media/audio-constructor-preload.html: Added.
  • media/video-dom-autobuffer-expected.txt: Removed.
  • media/video-dom-autobuffer.html: Removed.
  • media/video-dom-preload-expected.txt: Added.
  • media/video-dom-preload.html: Added.
07:21 QtWebKitBugs edited by hausmann@webkit.org
(diff)
07:02 Changeset [55462] by mitz@apple.com

<rdar://problem/7682756> Assertion failure when replacing the contents of a <select>

Reviewed by Sam Weinig.

WebCore:

Test: fast/dom/remove-children-notification-order.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChildren): Changed to call childrenChanged()
before calling removedFromDocument() on each removed child, which matches
the order removeChild() does things, and avoids the assertion. This required
temporarily storing the removed children in a vector.
Also added comments about other discrepancies between this function and
removeChild().

LayoutTests:

  • fast/dom/remove-children-notification-order-expected.txt: Added.
  • fast/dom/remove-children-notification-order.html: Added.
06:48 Changeset [55461] by abarth@webkit.org

2010-03-03 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Document cookieURL and firstPartyForCookies
https://bugs.webkit.org/show_bug.cgi?id=35613

Some folks asked what the cookieURL and the firstPartyForCookies were
on IRC. This patch documents these properties in the code so folks
don't have to ask on IRC anymore.

  • dom/Document.h:
06:42 Changeset [55460] by eric@webkit.org

2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Simon Hausmann.

Refactor QtLauncher so it respects command line arguments
and inherits settings when you clone or create a new window.

Implemented with help of Kenneth Rohde Christiansen.

[Qt] QtLauncher must be refactored to fix command line arguments usage
https://bugs.webkit.org/show_bug.cgi?id=35536

  • QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::init): (LauncherWindow::isGraphicsBased): (applySetting): (LauncherWindow::applyPrefs): (LauncherWindow::initializeView): (LauncherWindow::newWindow): (LauncherWindow::cloneWindow): (LauncherWindow::createChrome): (main):
  • QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
  • QtLauncher/webview.h: (WebViewGraphicsBased::itemCacheMode): (WebViewGraphicsBased::frameRateMeasurementEnabled):
06:40 Google Summer of Code 2010 edited by aroben@apple.com
(diff)
06:00 Google Summer of Code 2010 edited by alex@milowski.com
(diff)
05:30 Changeset [55459] by eric@webkit.org

2010-03-03 Arno Renevier <arno@renevier.net>

Reviewed by Gustavo Noronha Silva.

[Gtk]: assertion triggered when geolocation getCurrentPosition without an option argument.
https://bugs.webkit.org/show_bug.cgi?id=35666

  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::startUpdating):
05:17 Changeset [55458] by kov@webkit.org

2010-03-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

[GTK] build slaves need working geoclue service
https://bugs.webkit.org/show_bug.cgi?id=35674

Skip tests we're not really able to run for the time being.

  • platform/gtk/Skipped:
04:44 Changeset [55457] by eric@webkit.org

2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Xan Lopez.

Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640

  • GNUmakefile.am: On Windows with GCC, presence of declspec(dllexport) on some symbols disables the autoexport/autoimport feature for all others. Using regex here assures that all symbols that need to be exported in the dll are actually exported.

2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Xan Lopez.

Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640

  • GNUmakefile.am: dist two new files concerning mathml support.

2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Xan Lopez.

Miscellaneous little fixes for the windows build of webkit-gtk
https://bugs.webkit.org/show_bug.cgi?id=35640

  • webkit/webkitdownload.cpp: Windows headers define ERROR which breaks the build. Undef ERROR if it is defined.
04:09 Changeset [55456] by xan@webkit.org

2010-03-03 Xan Lopez <xlopez@igalia.com>

Unreviewed distcheck fix.

Add new file to the build.

  • GNUmakefile.am:
04:02 Changeset [55455] by antti@apple.com

Make IntPoint usable as a hash key

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=35586

  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/IntPointHash.h: Added.

(WTF::IntPointHash::hash):
(WTF::IntPointHash::equal):
(WTF::):

00:24 Changeset [55454] by philn@webkit.org

2010-03-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, build fix after r55452.

  • webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_settings_notify): added missing braces.
00:07 Changeset [55453] by eric@webkit.org

2010-03-02 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Oliver Hunt.

Allow building smoothly on win32 and win64 using GCC
https://bugs.webkit.org/show_bug.cgi?id=35607

  • jit/JITStubs.h:
  • runtime/Collector.cpp: (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase):
Note: See TracTimeline for information about the timeline view.