Timeline


and

03/11/10:

23:24 Changeset [55891] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-11 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable network state notifier when compiling against Qt 4.7
https://bugs.webkit.org/show_bug.cgi?id=35983

  • WebCore.pri:
  • platform/network/qt/NetworkStateNotifierPrivate.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:
23:07 Changeset [55890] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-03-11 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Adam Treat.

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

The frame view take into acount the list of fixed object when scrolling
the view. If the number of object is lower than a certain threshold, the pixel
are blitted, and the invalidated area updated.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject): (WebCore::FrameView::scrollContentsFastPath):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
  • platform/ScrollView.h:
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
22:46 Changeset [55889] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-11 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888

Use TARGETING_TIGER rather than BUILDING_ON_TIGER to determine the tags.

  • wtf/VMTags.h:
22:11 Changeset [55888] by eric@webkit.org
  • 12 edits in trunk

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission):
  • notifications/NotificationPresenter.h:

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

  • public/WebNotificationPresenter.h:
  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
  • src/NotificationPresenterImpl.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::applicationID):

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
21:41 Changeset [55887] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-11 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

The JSNative state was renamed to JSPrimitive. The new name better
coresponds to the ECMAScript standard.

Enum QScriptValuePrivate::States was renamed to State to obey Qt
coding style rules ("States" name suggests that a state could
mixed together with an other state using bitwise logic operators.

[Qt] QScriptValuePrivate::States has naming issues
https://bugs.webkit.org/show_bug.cgi?id=35968

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::refinedJSValue):
21:24 Changeset [55886] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-03-11 Shu Chang <Chang.Shu@nokia.com>

Reviewed by David Levin.

[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=35969

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-resize-reset-expected.txt:
20:39 Changeset [55885] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Add export.

Reviewed by NOBODY (Windows build fix).

20:36 Changeset [55884] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-11 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Fix typo in websocket_server.py

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
20:07 Changeset [55883] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Add export.

Reviewed by NOBODY (Windows build fix).

19:51 Changeset [55882] by dimich@chromium.org
  • 9 edits in trunk/WebCore

[v8] Remove obsolete code for delayed dereferencing of DOM objects for single-heap, multithread v8 usage.
https://bugs.webkit.org/show_bug.cgi?id=36043

Reviewed by David Levin.

No new tests, no changes in functionality.

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::DOMData):

  • bindings/v8/DOMData.h:

(WebCore::DOMData::handleWeakObject):

  • bindings/v8/DOMDataStore.cpp:
  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::domObjectMap):
(WebCore::DOMDataStore::activeDomObjectMap):
(WebCore::DOMDataStore::domSvgElementInstanceMap):
(WebCore::DOMDataStore::domSvgObjectWithContextMap):

  • bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp:

(WebCore::removeAllDOMObjectsInCurrentThread):

19:25 Changeset [55881] by barraclough@apple.com
  • 4 edits in trunk

Rubber stamped by Oliver Hunt.

Remove nonsense comments used in development & commited in error.

JavaScriptCore:

  • runtime/UStringImpl.h:

WebCore:

  • platform/text/StringImpl.h:
19:22 Changeset [55880] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-11 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Adler.

Fixing minor typo in the commit queue status page.
https://bugs.webkit.org/show_bug.cgi?id=35979

  • Scripts/webkitpy/commands/queues.py:
19:20 Changeset [55879] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove export.

Reviewed by NOBODY (Windows build fix).

19:14 Changeset [55878] by barraclough@apple.com
  • 8 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=36041
Remove unnecessary differences in common code between WebCore::StringImpl & JSC::UStringImpl

Reviewed by Oliver Hunt.

Much of the code in WebCore::StringImpl and JSC::UStringImpl is now very similar,
but has trivial and unnecessary formatting differences, such as the exact wording
of comments, missing ASSERTs, functions implemented in the .h vs .cpp etc.

JavaScriptCore:

  • runtime/Identifier.cpp:

(JSC::Identifier::add): UStringImpl::empty() now automatically hashes, uas per WebCore strings.
(JSC::Identifier::addSlowCase): UStringImpl::empty() now automatically hashes, uas per WebCore strings.

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::~UStringImpl): Only call bufferOwnership() once, add missing ASSERTs.
(JSC::UStringImpl::createUninitialized): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::create): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::sharedBuffer): Rewritten to more closely match WebCore implementation, remove need for separate baseSharedBuffer() method.

  • runtime/UStringImpl.h:

(JSC::UStringImpl::UStringImpl): Automatically hash static strings, ASSERT m_data & m_length are non-null/non-zero in non-static strings.
(JSC::UStringImpl::setHash): Add missing ASSERT.
(JSC::UStringImpl::create): Moved to .cpp / added missing check for empty string creation.
(JSC::UStringImpl::adopt): Vector.size() returns size_t, not unsigned.
(JSC::UStringImpl::cost): Renamed m_bufferSubstring -> m_substringBuffer
(JSC::UStringImpl::hash): Reordered in file.
(JSC::UStringImpl::existingHash): Reordered in file.
(JSC::UStringImpl::computeHash): Reordered in file, renamed parameter.
(JSC::UStringImpl::checkConsistency): rewrote ASSERT.
(JSC::UStringImpl::bufferOwnership): Return type should be BufferOwnership.
(JSC::UStringImpl::): Moved friends to head of class.

WebCore:

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::empty): Reordered in file, made empty()->characters() return a non-null value to match JSC.
(WebCore::StringImpl::createUninitialized): Added overflow check.
(WebCore::StringImpl::create): Reordered in file.
(WebCore::StringImpl::sharedBuffer): Reordered in file.

  • platform/text/StringImpl.h:

(WebCore::StringImpl::): Remove ThreadGlobalData as friend, move SharableUChar & SharedUChar to WebCore namespace.
(WebCore::StringImpl::StringImpl): Made static constructor method (used to create empty string) take arguments, to match JSC & prevent accidental use.
(WebCore::StringImpl::setHash): Added missing ASSERT.
(WebCore::StringImpl::adopt): Make adpot work with Vectors with a non-zero inline capacity.
(WebCore::StringImpl::characters): Mark as const to match JSC.
(WebCore::StringImpl::hash): Use !m_hash instead of m_hash == 0.
(WebCore::StringImpl::computeHash): Remove redundant 'inline'.

19:04 Changeset [55877] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-11 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Fix the screen coordinate conversion of Chromium Mac mouse events for
multiple-moniter setups. Also changes the global coordinate values
to be computed from the event, rather than the instantaneous mouse
location, and reduces code duplication for location conversion.

Dual-sided patch with http://codereview.chromium.org/751002

https://bugs.webkit.org/show_bug.cgi?id=35950

  • src/mac/WebInputEventFactory.mm: (WebKit::setWebEventLocationFromEventInView): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
18:47 Changeset [55876] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-03-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Applying h1 format to text node after HR tag fails to include first letter of text node.
https://bugs.webkit.org/show_bug.cgi?id=30148

This patch adds a test case to the above bug, which has been fixed by
http://trac.webkit.org/changeset/55705.

  • editing/style/heading-text-after-hr-expected.txt: Added.
  • editing/style/heading-text-after-hr.html: Added.
18:37 Changeset [55875] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-11 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Fix for WebSocket layout test runner on chromium/win port.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: register_cygwin and set CYGWIN_PATH
18:20 Changeset [55874] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35917

  • efl/WebCoreSupport/InspectorClientEfl.h: Added.
  • efl/WebCoreSupport/InspectorClientEfl.cpp: Added.
18:15 Changeset [55873] by jianli@chromium.org
  • 4 edits
    3 adds in trunk/LayoutTests

Add more test cases for Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=36038

Reviewed by Dmitry Titov.

  • http/tests/local/resources/abe.png: Copied from LayoutTests/editing/resources/abe.png.
  • http/tests/local/resources/empty.txt: Copied from LayoutTests/http/tests/appcache/resources/empty.txt.
  • http/tests/local/resources/send-sliced-dragged-file.js:
  • http/tests/local/send-sliced-dragged-file-expected.txt:
  • http/tests/resources/post-and-verify.cgi: Added.
  • http/tests/resources/write-temp-file.php:
18:03 Changeset [55872] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35914

  • efl/WebCoreSupport/DragClientEfl.h: Added.
  • efl/WebCoreSupport/DragClientEfl.cpp: Added.
17:53 Changeset [55871] by mrowe@apple.com
  • 10 edits in trunk

<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version

Reviewed by David Kilzer.

Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.

JavaScriptCore:

  • Configurations/Base.xcconfig:

JavaScriptGlue:

  • Configurations/Base.xcconfig:

WebCore:

  • Configurations/Base.xcconfig:

WebKit/mac:

  • Configurations/Base.xcconfig:

WebKitTools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
17:37 Changeset [55870] by eric@webkit.org
  • 4 edits
    4 adds in trunk

2010-03-11 Jungshik Shin <jshin@chromium.org>

[Chromium]: Plane 2 characters are rendered "blank"

(not even empty boxes) on Windows even when there are fonts to
cover them.

https://bugs.webkit.org/show_bug.cgi?id=35605

Test:LayoutTests/fast/text/international/plane2.html

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::LookupAltName): Add two ExtB fonts to the array (namePairs) that are used for Plane 2 character rendering. (WebCore::FontCache::getFontDataForCharacters): Add two more fonts to the fallback font list
  • platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::getFallbackFamily): Fix the fallback font lookup to cover Plane 2 (CJK ExtB).
17:20 Changeset [55869] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to platform/efl.
http://webkit.org/b/35889

  • platform/efl/SystemTimeEfl.cpp: Added.
16:50 Changeset [55868] by victorw@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-11 Victor Wang <victorw@chromium.org>

Reviewed by dglazkov@chromium.org.

rebaseline_chromium_webkit_tests can generate new baselines for
all platforms so it needs to know two ports in order to work correctly:
the port that the script is running on and the port that it generates
new baselines for. Update rebaselining tool to handle both port correctly.

https://bugs.webkit.org/show_bug.cgi?id=36032

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
16:44 Changeset [55867] by mrowe@apple.com
  • 26 edits in trunk

<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version

Reviewed by Tim Hatcher.

Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the
current Mac OS X version unless otherwise specified.

Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.

Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
may not be usable when targetting a different Mac OS X version.

Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.

JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/Version.xcconfig:

JavaScriptGlue:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebCore.xcconfig:

WebKit/mac:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:

WebKitTools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • DumpRenderTree/mac/DumpRenderTree.mm: Wrap the include of mach-o/getsect.h in 'extern "C"' as some versions of the

header in older SDKs do not do this inside the header.

16:40 Changeset [55866] by darin@chromium.org
  • 14 edits in trunk/WebKit/chromium

2010-03-10 Darin Fisher <darin@chromium.org>

Reviewed by Jeremy Orlow.

Use WebPrivatePtr for WebNode
https://bugs.webkit.org/show_bug.cgi?id=36005

  • public/WebElement.h:
  • public/WebFormElement.h:
  • public/WebInputElement.h:
  • public/WebLabelElement.h:
  • public/WebNode.h: (WebKit::WebNode::WebNode): (WebKit::WebNode::isNull): (WebKit::WebNode::unwrap): (WebKit::WebNode::constUnwrap):
  • public/WebPrivatePtr.h: (WebKit::WebPrivatePtr::assign):
  • src/WebDocument.cpp: (WebKit::WebDocument::WebDocument): (WebKit::WebDocument::operator=): (WebKit::WebDocument::operator PassRefPtr<Document>):
  • src/WebElement.cpp: (WebKit::WebElement::hasTagName): (WebKit::WebElement::WebElement): (WebKit::WebElement::operator=): (WebKit::WebElement::operator PassRefPtr<Element>):
  • src/WebFormElement.cpp: (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::operator PassRefPtr<HTMLFormElement>):
  • src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::operator PassRefPtr<HTMLInputElement>):
  • src/WebLabelElement.cpp: (WebKit::WebLabelElement::correspondingControl): (WebKit::WebLabelElement::operator=): (WebKit::WebLabelElement::operator PassRefPtr<HTMLLabelElement>):
  • src/WebNode.cpp: (WebKit::WebNode::reset): (WebKit::WebNode::assign): (WebKit::WebNode::equals): (WebKit::WebNode::parentNode): (WebKit::WebNode::createMarkup): (WebKit::WebNode::addEventListener): (WebKit::WebNode::removeEventListener): (WebKit::WebNode::simulateClick): (WebKit::WebNode::WebNode): (WebKit::WebNode::operator=): (WebKit::WebNode::operator PassRefPtr<Node>):
16:27 Changeset [55865] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Added the test that time out on Tiger bot to mac-tiger/Skipped.

  • platform/mac-tiger/Skipped:
16:09 Changeset [55864] by andersca@apple.com
  • 27 edits in trunk

Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.

Reviewed by David Hyatt.

WebCore:

  • loader/EmptyClients.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:

WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:

WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:
  • WebCoreSupport/ChromeClientHaiku.h:

WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:

WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:
16:03 Changeset [55863] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2010-03-11 Simon Fraser <simon.fraser@apple.com>

No review.

Need to turn on WebGL explicitly for these tests for Leopard.

  • compositing/webgl/webgl-background-color.html:
  • compositing/webgl/webgl-reflection.html:
16:03 Changeset [55862] by japhet@chromium.org
  • 9 edits
    1 delete in trunk/WebCore

2010-03-11 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Remove DOMObjectsInclude.h and update headers accordingly.

https://bugs.webkit.org/show_bug.cgi?id=36036

  • WebCore.gypi:
  • bindings/v8/DOMData.h:
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/DOMObjectsInclude.h: Removed.
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8Proxy.cpp:
16:02 Changeset [55861] by ap@apple.com
  • 7 edits
    2 adds in trunk

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=35965
<rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in

Test: plugins/round-trip-npobject.html

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Corrected the check - there is now a separate ProxyRuntimeObject class for proxy pbjects. (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Check if m_instanceProxy is still non-zero. The plug-in could have crashed while we were waiting for response. (WebKit::ProxyInstance::setFieldValue): Ditto.
15:57 Changeset [55860] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

Remove duplicate entries revealed after sorting.

  • WebCore.xcodeproj/project.pbxproj:
15:35 Changeset [55859] by simon.fraser@apple.com
  • 6 edits in trunk

2010-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

Sort the project files, also fixing some bogus spaces in the WebCore project.

15:14 Changeset [55858] by dimich@chromium.org
  • 6 edits in trunk/LayoutTests

Make appcache layouttests top-frame-*.html more robust for async checking event
https://bugs.webkit.org/show_bug.cgi?id=32047

Reviewed by Alexey Proskuryakov.

Modified the tests to watch for all termination conditions, eliminating the hardcoded
assumed order of the events from separate async event sources.
Also added check for "noupdate" event.

  • http/tests/appcache/top-frame-2.html: Modified to be consistent with the other 2 tests.
  • http/tests/appcache/top-frame-3-expected.txt:
  • http/tests/appcache/top-frame-3.html: Used logic similar to top-frame-2.html to avoid assumption of the events order.
  • http/tests/appcache/top-frame-4-expected.txt:
  • http/tests/appcache/top-frame-4.html: Ditto.
15:13 Changeset [55857] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2010-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=35905
REGRESSION(55699?): media/video-no-autoplay.html times out on Leopard Commit Bot

Make sure we reset the WebGL preference, so that WebGL doesn't get left
on after being enabled via layoutTestController.overridePreference(),
which in turn causes accelerated compositing to be enabled on Leopard
when we don't want it to be.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
14:42 Changeset [55856] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2010-03-11 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Fix style issues and improve comments from
http://trac.webkit.org/changeset/55853.

https://bugs.webkit.org/show_bug.cgi?id=36029

  • platform/animation/TimingFunction.h: (WebCore::TimingFunction::TimingFunction):
14:24 Changeset [55855] by cfleizach@apple.com
  • 16 edits in trunk/WebCore

accessibilityIsIgnoredBase() needs to respect when platform says include
https://bugs.webkit.org/show_bug.cgi?id=36025

Reviewed by Beth Dakin.

Changed accessibilityIsIgnoredBase() to return a policy instead of a yes/no
answer. This allows the platform to make a yes decision on an element.

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::accessibilityIsIgnored):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::accessibilityIsIgnored):

  • accessibility/AccessibilityObject.h:

(WebCore::):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::accessibilityIsIgnored):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::accessibilityIsIgnored):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::accessibilityIsIgnored):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::accessibilityIsIgnored):

  • accessibility/chromium/AccessibilityObjectChromium.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/qt/AccessibilityObjectQt.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/win/AccessibilityObjectWin.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/wx/AccessibilityObjectWx.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

13:39 Changeset [55854] by kbr@google.com
  • 3 edits in trunk/WebCore

2010-03-11 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Fix build breakage with ENABLE_3D_CANVAS=0
https://bugs.webkit.org/show_bug.cgi?id=35995

No new tests; verified in Chromium that WebGL is disabled in
ENABLE_3D_CANVAS=0 builds.

  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
12:24 Changeset [55853] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2010-03-11 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium mac build fix.

Add an explicit copy constructor to TimingFunction.
http://trac.webkit.org/changeset/55835 trigged an inlining
bug in gcc that the copy constructor resolves.

  • platform/animation/TimingFunction.h: (WebCore::TimingFunction::TimingFunction):
12:18 Changeset [55852] by mrobinson@webkit.org
  • 3 edits
    1 add
    4 deletes in trunk/LayoutTests

2010-03-11 Martin Robinson <mrobinson@webkit.org>

Reviewed by Adam Barth

Convert editing/selection/5136696.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=34306

  • editing/selection/5136696-expected.txt: Added.
  • editing/selection/5136696.html: Use dumpAsText now.
  • platform/gtk/Skipped: Unskip this test in GTK+ now that it has expected result.
  • platform/mac/editing/selection/5136696-expected.checksum: Removed.
  • platform/mac/editing/selection/5136696-expected.png: Removed.
  • platform/mac/editing/selection/5136696-expected.txt: Removed.
  • platform/qt/editing/selection/5136696-expected.txt: Removed.
  • platform/win/editing/selection/5136696-expected.txt: Removed.
12:01 Changeset [55851] by aroben@apple.com
  • 2 edits in trunk

Teach git about ObjC files

Fixes <http://webkit.org/b/36015>.

Reviewed by Tim Hatcher.

  • .gitattributes: Set the diff attribute for .m and .mm files, and .h

files in Mac-specific directories. This can be used to generate
more-readable diffs of ObjC files.

11:56 Changeset [55850] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-03-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

rebaseline_chromium_webkit_tests doesn't handle other plaforms
correctly (e.g., if you run on the Mac platform and try to
rebaseline the WIN results, the result gets written into
platform/mac instead of platform/chromium-win). Also, this script
doesn't work on non-Chromium ports, so we need to fix that at some
point.

https://bugs.webkit.org/show_bug.cgi?id=35982

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
11:28 Changeset [55849] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

Fixing GTK. No review.

support lang attribute on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=36021

We don't need to cast to AccessibilityRenderObject to get language().

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_document_get_locale):

11:19 Changeset [55848] by cfleizach@apple.com
  • 8 edits
    2 adds in trunk

support lang attribute on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=36021

Reviewed by Darin Adler.

WebCore:

Allow non AccessibilityRenderObject classes to access the lang
attribute by moving the useful code into AccessibilityObject.

Test: platform/mac/accessibility/option-with-lang.html

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::language):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::language):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::language):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • platform/mac/accessibility/option-with-lang-expected.txt: Added.
  • platform/mac/accessibility/option-with-lang.html: Added.
10:48 Changeset [55847] by tonikitoo@webkit.org
  • 4 edits in trunk

[Qt] Access key modifier should be Ctrl+Alt for Darwin derived OS and Alt for the others
https://bugs.webkit.org/show_bug.cgi?id=35993

Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-11
Reviewed by Simon Hausmann.

WebCore:

  • page/qt/EventHandlerQt.cpp:

(WebCore::EventHandler::accessKeyModifiers):

LayoutTests:

  • platform/qt/Skipped:
10:38 Changeset [55846] by brettw@chromium.org
  • 3 edits in trunk

010-03-08 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth.

Remove the deprecated argument to url_util::IsStandard in preparation
for deleting that version of the function. Pull the latest googleurl
with the new version for the Chromium builder.

  • platform/KURLGoogle.cpp: (WebCore::KURL::isHierarchical):
09:02 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
09:00 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
running on HW issues (diff)
08:03 Changeset [55845] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Make it possible to do builds with separate debug info in packages

Reviewed by Tor Arne Vestbø.

  • WebCore.pro:
08:03 Changeset [55844] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Avoid double-buffering with Qt image decoders

Reviewed by Tor Arne Vestbø.

Pass QIODevice::Unbuffered when opening the QBuffer that
wraps the image data, to hint to Qt that no extra buffering
is needed.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):

07:25 Changeset [55843] by benm@google.com
  • 4 edits in trunk/WebCore

[Android] The platform touch events on Android are missing support
for key modifiers.
https://bugs.webkit.org/show_bug.cgi?id=35521

Reviewed by Jeremy Orlow.

Add support in PlatformToucHEventAndroid for the platform supplying
key modifiers with touch events.

Fixes Android so it now passes basic-single-touch-events.html.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent): Fix two compiler warnings.

  • platform/PlatformTouchEvent.h:

(WebCore::PlatformTouchEvent::PlatformTouchEvent): Add support for

key modifiers on Android.

  • platform/android/PlatformTouchEventAndroid.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent): ditto.

06:40 Changeset [55842] by cfleizach@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Wrong files were placed in skipped lists.

  • platform/gtk/Skipped:
03:38 Changeset [55841] by steveblock@google.com
  • 5 edits
    3 adds in trunk

2010-03-10 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Implements Geolocation maximumAge property
https://bugs.webkit.org/show_bug.cgi?id=30676

Test: fast/dom/Geolocation/maximum-age.html

  • WebCore.xcodeproj/project.pbxproj: Modified. Adds GeolocationPositionCache.h to Private headers
  • page/Geolocation.cpp: Modified. (WebCore::Geolocation::GeoNotifier::setUseCachedPosition): Added. (WebCore::Geolocation::GeoNotifier::runSuccessCallback): Added. (WebCore::Geolocation::GeoNotifier::timerFired): Modified. Added logic to handle using a cached position (WebCore::Geolocation::Watchers::contains): Added. Required to determine if a notifier is a watch request (WebCore::Geolocation::startRequest): Modified. Added logic to check for a cached position (WebCore::Geolocation::requestUsesCachedPosition): Added. Callback to Geolocation object when notifier uses a cached position (WebCore::Geolocation::makeCachedPositionCallbacks): Added. (WebCore::Geolocation::haveSuitableCachedPosition): Added. (WebCore::Geolocation::setIsAllowed): Modified. (WebCore::Geolocation::positionChanged): Modified. Make callbacks using cached position where appropriate (WebCore::Geolocation::geolocationServiceErrorOccurred): Modified. Make callbacks using cached position where appropriate
  • page/Geolocation.h: Modified.

2010-03-10 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Implements Geolocation maximumAge property
https://bugs.webkit.org/show_bug.cgi?id=30676

  • fast/dom/Geolocation/resources/maximum-age.js: Added. Checks that a cached position is used only when it should be.
  • fast/dom/Geolocation/maximum-age.html: Added. HTML wraper for above test.
  • fast/dom/Geolocation/maximum-age-expected.txt: Added. Expected result for above test.
02:57 Changeset [55840] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-11 Philippe Normand <pnormand@igalia.com>

Unreviewed.

Unskip the fixed test that was (accidently?) re-skipped in r54205.

  • platform/gtk/Skipped:
02:25 Changeset [55839] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] storage/open-database-creation-callback-isolated-world.html was introduced in r55823,
but layoutTestController.evaluateScriptInIsolatedWorld() is unimplemented now.

  • platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html skipped.
02:16 Changeset [55838] by ossy@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed buildfix after r55823. (To fix Qt --minimal build.)
I have déjà vu, I'm sure that I did it before. (r55598)

  • bindings/js/JSDOMWindowCustom.cpp: Missing #if ENABLE(DATABASE) guard added.
01:43 Changeset [55837] by ossy@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Unreviewed buildfix after r55833.

Rename all instances of data() to characters()

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fieldNamed):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

01:29 Changeset [55836] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-03-11 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

Allow custom memory allocation control for RenderLayerBacking class
https://bugs.webkit.org/show_bug.cgi?id=35857

Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
RenderLayerBacking - rendering/RenderLayer.cpp:3047

  • rendering/RenderLayerBacking.h:
00:41 Changeset [55835] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2010-03-11 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

Allow custom memory allocation control for TimingFunction struct
https://bugs.webkit.org/show_bug.cgi?id=35855

Inherits the following struct from FastAllocBase because it is
instantiated by 'new':

class name - instantiated at: WebCore/'location'
TimingFuction - platform/graphics/GraphicsLayer.h:89

  • platform/animation/TimingFunction.h:

03/10/10:

23:53 Changeset [55834] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

Buildfix for Thumb-2 after r55684. Add branch8 and branchTest8 functions.
https://bugs.webkit.org/show_bug.cgi?id=35892

Reviewed by Gavin Barraclough.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::ldrb):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load8):
(JSC::MacroAssemblerARMv7::branch8):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::setTest8):

23:19 Changeset [55833] by barraclough@apple.com
  • 15 edits in trunk

Rubber stamped by Oliver Hunt.

Rename JSC::UStringImpl::data() to characters(), to match WebCore::StringImpl.

JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClassContextData::OpaqueJSClassContextData):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::keyForCharacterSwitch):

  • bytecompiler/NodesCodegen.cpp:

(JSC::processClauseList):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

  • runtime/Identifier.cpp:

(JSC::Identifier::equal):
(JSC::Identifier::addSlowCase):

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):

  • runtime/UString.cpp:

(JSC::UString::toStrictUInt32):
(JSC::equal):

  • runtime/UString.h:

(JSC::UString::data):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::characters):
(JSC::UStringImpl::hash):
(JSC::UStringImpl::setHash):

WebCore:

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::uchars):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

23:07 Changeset [55832] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Fix for r55825, threadsafeCopy no longer needs to special-case for
empty strings (in fact, doing so results in leaks).

Reviewed by Mark Rowe.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::threadsafeCopy):

21:30 Changeset [55831] by cfleizach@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Wrong files were placed in skipped lists.

  • platform/gtk/Skipped:
  • platform/win/Skipped:
21:06 Changeset [55830] by cfleizach@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Skip this test since it uses tables and lists, which are not
supported on Tiger/Leopard.

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
20:09 Changeset [55829] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-10 Daniel Bates <dbates@rim.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=35840

Updates the subroutine builtDylibPathForName() so that it adds the "d" suffix to
the QtWebKit library name on Windows. This change makes run-launcher work again
under Windows. Moreover, this change corresponds to the change made in change-
set 53924 <http://trac.webkit.org/changeset/53924>.

  • Scripts/webkitdirs.pm:
20:05 Changeset [55828] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Windows build fix - add an missing symbol to be exported

19:23 Changeset [55827] by chang.shu@nokia.com
  • 6 edits in trunk

2010-03-10 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

While calculating alpha channel, convert the floating point value to
an integer in [0, 256) with equal distribution.
https://bugs.webkit.org/show_bug.cgi?id=22150

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColorParameters):

2010-03-10 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

While calculating alpha channel, convert the floating point value to
an integer in [0, 256) with equal distribution.
Updated test results based on this new behavior.
https://bugs.webkit.org/show_bug.cgi?id=22150

  • fast/canvas/canvas-alphaImageData-behavior-expected.txt:
  • fast/canvas/canvas-alphaImageData-behavior.js:
  • platform/qt/Skipped:
18:38 Changeset [55826] by abarth@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-03-10 Adam Barth <abarth@webkit.org>

Unreviewed.

http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349

Remove another test that has the same problem. We need to find a way
to relaibly test what happens when you mix JavaScript URLs and
window.open.

  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char-expected.txt: Removed.
  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html: Removed.
18:36 Changeset [55825] by barraclough@apple.com
  • 13 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=35991
Would be faster to not use a thread specific to implement StringImpl::empty()

Reviewed by Darin Adler, Geoffrey Garen, Maciej Stachowiak.

JavaScriptCore:

Change JSC::UStringImpl's implementation of empty() match to match StringImpl's new implementation
(use a static defined within the empty() method), and change the interface to match too (return
a pointer not a reference).

~0% performance impact (possible minor progression from moving empty() from .h to .cpp).

(JSC::Identifier::add):
(JSC::Identifier::addSlowCase):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/UString.cpp:

(JSC::initializeUString):
(JSC::UString::UString):

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::empty):
(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::adopt):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):

WebCore:

Copy JavaScriptCore in making 'static' strings threadsafe, make the empty string a static,
shared by all threads.

~2% progression on Dromaeo DOM core & JS lib tests.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::eventNames):

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::empty):

  • platform/text/StringImpl.h:

(WebCore::StringImpl::deref):
(WebCore::StringImpl::hasOneRef):

18:19 Changeset [55824] by simon.fraser@apple.com
  • 5 edits in trunk/WebKit/mac

2010-03-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=35975
<rdar://problem/7739922> Flash 10.1b crashes when generating snapshots

Do a version check before sending a drawRect event to a Flash plugin,
since 10.1.d51 has a bug that crashes when called this way.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView supportsSnapshotting]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView drawRect:]):
18:18 Changeset [55823] by dumi@chromium.org
  • 21 edits
    9 adds in trunk

WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().

Reviewed by Adam Barth.

Tests: storage/open-database-creation-callback.html

storage/open-database-creation-callback-isolated-world.html

https://bugs.webkit.org/show_bug.cgi?id=34726

  • Android.jscbindings.mk
  • Android.v8bindings.mk
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCallback.cpp: Added.

(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):

  • bindings/js/JSDatabaseCallback.h: Added.

(WebCore::JSDatabaseCallback::create):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • bindings/v8/custom/V8DatabaseCallback.cpp: Added.

(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):

  • bindings/v8/custom/V8DatabaseCallback.h: Added.

(WebCore::V8DatabaseCallback::create):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/Database.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):

  • storage/Database.h:

(WebCore::Database::isNew):

  • storage/DatabaseCallback.h: Added.

(WebCore::DatabaseCallback::~DatabaseCallback):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):

  • workers/WorkerContext.h:

LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.

Reviewed by Adam Barth.

Also, fixing fast/frames/sandboxed-iframe-storage.html: calling
openDatabase() without at least 4 parameters should always fail,
because the database name, version, description and estimated size
are not optional according to the spec.

https://bugs.webkit.org/show_bug.cgi?id=34726

  • fast/frames/resources/sandboxed-iframe-storage-allowed.html:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-storage-expected.txt:
  • platform/qt/Skipped:
  • storage/open-database-creation-callback-expected.txt: Added.
  • storage/open-database-creation-callback.html: Added.
  • storage/open-database-creation-callback-isolated-world-expected.txt: Added.
  • storage/open-database-creation-callback-isolated-world.html: Added.
18:07 Changeset [55822] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-10 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Make Chrome consistently handle leading format characters in URLs

https://bugs.webkit.org/show_bug.cgi?id=35948

  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char-expected.txt: Added.
  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html: Added.

2010-03-10 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Make Chrome consistently handle leading format characters in URLs

https://bugs.webkit.org/show_bug.cgi?id=35948

Test: http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html

  • platform/KURLGoogle.cpp:
17:19 Changeset [55821] by jianli@chromium.org
  • 14 edits
    2 adds in trunk/WebCore

Implementing DOMFormData class.
https://bugs.webkit.org/show_bug.cgi?id=35707

Reviewed by Dmitry Titov.

This patch only addresses the implementation of DOMFormData class and
moves the FormData construction logic from HTMLFormElement::createFormData
to FormData::create() so that it can be used by both HTMLFormElement
and XMLHttpRequest.

The DOMFormData IDL interface will be exposed in another patch and the
test will be added then.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/DOMFormData.cpp: Added.
  • html/DOMFormData.h: Added.
  • html/FormDataList.h:

(WebCore::FormDataList::encoding):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::createFormData):
(WebCore::HTMLFormElement::submit):

  • html/HTMLFormElement.h:
  • platform/network/FormData.cpp:

(WebCore::FormData::create):
(WebCore::FormData::createMultiPart):
(WebCore::FormData::appendDOMFormData):

  • platform/network/FormData.h:

(WebCore::FormData::boundary):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

  • xml/XMLHttpRequest.h:
16:59 Changeset [55820] by darin@chromium.org
  • 4 edits
    3 adds in trunk/WebKit/chromium

2010-03-10 Darin Fisher <darin@chromium.org>

Reviewed by Jeremy Orlow.

Add API wrapper for WebCore::SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=35988

WebSerializedScriptValue is a wrapper around SerializedScriptValue.

WebPrivatePtr is used to simplify wrapping reference counted WebCore
types. This class is used to cleanup WebHistoryItem, and will be used
to clean up other classes in the WebKit API in a follow-up patch.

  • WebKit.gyp:
  • public/WebHistoryItem.h:
  • public/WebPrivatePtr.h: Added.
  • public/WebSerializedScriptValue.h: Added.
  • src/WebHistoryItem.cpp:
  • src/WebSerializedScriptValue.cpp: Added.
16:43 Changeset [55819] by cfleizach@apple.com
  • 3 edits in trunk/LayoutTests

Skipping test on GTK and WIN. No Review.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Thought this test might pass on the other platforms, but no.

  • platform/gtk/Skipped:
  • platform/win/Skipped:
16:36 Changeset [55818] by cfleizach@apple.com
  • 18 edits
    2 adds in trunk

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Reviewed by Beth Dakin.

WebCore:

Elements that are subclassers of AXRenderObject have not been respecting
aria-hidden and other cases that would make them ignored. This applies
to tables, rows, cells, select boxes, sliders, and lists. Select boxes
also need to make sure their option elements respect aria-hidden as well.

Test: accessibility/aria-hidden-with-elements.html

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::accessibilityIsIgnored):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::addChildren):
(WebCore::AccessibilityListBox::accessibilityIsIgnored):
(WebCore::AccessibilityListBox::doAccessibilityHitTest):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::accessibilityIsIgnored):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredCommon):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::accessibilityIsIgnored):

  • accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::roleValue):
(WebCore::AccessibilitySliderThumb::roleValue):
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::accessibilityIsIgnored):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::accessibilityIsIgnored):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::accessibilityIsIgnored):

  • accessibility/AccessibilityTableColumn.h:

(WebCore::AccessibilityTableColumn::roleValue):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):

  • accessibility/AccessibilityTableHeaderContainer.h:
  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::accessibilityIsIgnored):

LayoutTests:

  • accessibility/aria-hidden-with-elements-expected.txt: Added.
  • accessibility/aria-hidden-with-elements.html: Added.
16:14 Changeset [55817] by dimich@chromium.org
  • 2 edits in trunk/JavaScriptCore

Not reviewed, fixing Snow Leopard build.

  • wtf/mac/MainThreadMac.mm: Forgot 'static' for a new local function.

(WTF::postTimer):

16:08 Changeset [55816] by dimich@chromium.org
  • 7 edits in trunk

Make Document::postTask to use a single queue of tasks, to fire them in order
https://bugs.webkit.org/show_bug.cgi?id=35943

Reviewed by Darin Adler.

JavaScriptCore:

The patch uses CFRunLoopTimer to schedule execution of tasks instead of performSelectorOnMainThread which apparently can starve other event sources.
The timer is used when the schedule request is coming on the main thread itself. This happens when the task is posted on the main thread or
when too many tasks are posted and the queue does 'stop and re-schedule' to make sure run loop has a chance to execute other events.

  • wtf/mac/MainThreadMac.mm:

(WTF::timerFired):
(WTF::postTimer):
(WTF::scheduleDispatchFunctionsOnMainThread): Use timer posted to the current RunLoop if scheduling the task execution while on the main thread.

WebCore:

Test: existing worker-cloneport.html which was broken by initial patch in http://trac.webkit.org/changeset/55593.
Additional test which indirectly verifies the order of execution will come as part of https://bugs.webkit.org/show_bug.cgi?id=34726

  • dom/Document.cpp:

(WebCore::Document::postTask): Always use the same task queue, independent of what thread is posting the task.

LayoutTests:

Updated the test since the order of events coming from independent task sources has changed.
This is a behavior change, but is consistent with the spec (which specifically says these events may be fired
in any order) and the last version of FF (3.5.8) which was completing the test successfully.

  • http/tests/appcache/top-frame-2-expected.txt:
  • http/tests/appcache/top-frame-2.html:
15:40 Changeset [55815] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: added new symbol.

15:28 Changeset [55814] by darin@chromium.org
  • 10 edits in trunk

2010-03-10 Sanjeev Radhakrishnan <sanjeevr@chromium.org>

Reviewed by Darin Fisher.

Allow a plugin to participate in the browser's print workflow.
https://bugs.webkit.org/show_bug.cgi?id=35550

  • loader/PluginDocument.cpp:
  • loader/PluginDocument.h:
15:27 Changeset [55813] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: removed old symbol.

15:19 Changeset [55812] by eric@webkit.org
  • 1 edit
    4 adds in trunk/WebKit

2010-03-10 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35913

  • efl/WebCoreSupport/ChromeClientEfl.cpp: Added.
  • efl/WebCoreSupport/ChromeClientEfl.h: Added.
15:11 Changeset [55811] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

Refactored fastCheckConsistency to match some review comments:

  • renamed fastCheckConsistency to fastMallocSize, and changed ValueCheck to ASSERT that a pointer's fastMallocSize is not 0.
  • implemented a version of fastMallocSize for tcmalloc.


Reviewed by Alexey Proskuryakov, Darin Adler, and Sam Weinig.

Also moved some pre-existing code around to avoid a problem related to
mismatched #define/#undef of malloc/free in this source file.

(WTF::fastMallocSize): Renamed. Fixed indentation.

(WTF::TCMalloc_PageHeap::scavenge): Removed an incorrect ASSERT that
got in the way of testing the tcmalloc implementation. (More information
on why this ASSERT is incorrect is in <rdar://problem/7165917>.)

(WTF::TCMallocStats::fastMallocSize): Implemented for tcmalloc.

  • wtf/FastMalloc.h: Updated for rename.
  • wtf/ValueCheck.h:

(WTF::): Moved the ASSERT that used to be in fastCheckConsistency here.

15:00 Changeset [55810] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-10 John Abd-El-Malek <jam@chromium.org>

Reviewed by Nate Chapin.

[chromium]: Fix regression in mouse capture on Mac/Linux
https://bugs.webkit.org/show_bug.cgi?id=35987

  • src/WebViewImpl.cpp:
14:44 Changeset [55809] by eric@webkit.org
  • 2 edits in trunk/WebKit/win

2010-03-10 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

The build fix for my patch on bug #35763 wasn't quite right--it removed
the call entirely, instead of replacing it with the new API. This adds
the call to Database::setIsAvailable.

https://bugs.webkit.org/show_bug.cgi?id=35763

14:26 Changeset [55808] by eric@webkit.org
  • 5 edits in trunk/WebKit/chromium

2010-03-10 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

[chromium] add functionality to activate the focused node in a WebView
https://bugs.webkit.org/show_bug.cgi?id=35407

  • public/WebDocument.h:
  • public/WebNode.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::focusedNode): Added
  • src/WebNode.cpp: (WebKit::WebNode::simulateClick): Added
14:19 Changeset [55807] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Roll out the prepare-ChangeLog part of r55870

This change wasn't needed (prepare-ChangeLog calls svn-create-patch
when it's asked to print out diffs for the user) and was screwing up
its ability to find changed function names.

  • Scripts/prepare-ChangeLog:

(diffCommand): Change the options we pass to svn-diff back to their
pre-r55870 form.

14:09 Changeset [55806] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-10 Ilya Tikhonovsky <loislo@loislo-macbookpro.local>

Reviewed by Pavel Feldman.

Sidebar resize element height was adjusted.
Display name for Function Call details was adjusted.

https://bugs.webkit.org/show_bug.cgi?id=35939

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
13:59 Changeset [55805] by jam@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-03-10 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=35952
Propagate mouse wheel events to Pepper plugins.

  • src/WebInputEventConversion.cpp: (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
  • src/WebInputEventConversion.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleEvent): (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleWheelEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
  • src/WebPluginContainerImpl.h:
13:58 Changeset [55804] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-10 Antonio Gomes <tonikitoo@webkit.org>

The test was introduced in r55796, it has been failing in Gtk bots since then.

Filed bug https://bugs.webkit.org/show_bug.cgi?id=35984.

  • platform/gtk/Skipped: fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html skipped until fix.
13:55 Changeset [55803] by robert@webkit.org
  • 9 edits in trunk

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html

https://bugs.webkit.org/show_bug.cgi?id=35593

  • platform/qt/Skipped:

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html

https://bugs.webkit.org/show_bug.cgi?id=35593

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference): (LayoutTestController::setCaretBrowsingEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html
Fix typo (superfluous space) in QWebSettings docs.

https://bugs.webkit.org/show_bug.cgi?id=35593

  • Api/qwebpage.cpp: (qt_drt_enableCaretBrowsing):
  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): fix typo in docs
13:52 Changeset [55802] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-10 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Fix https://bugs.webkig.org/show_bug.cgi?id=35207
When XHTMLMP is enabled, all xhtml documents fail to render for webkit portings wich use libxml2 tokenizer.

No new tests as all the xhtml test cases in LayoutTests/dom/xhtml fails without this fix when XHTMLMP is enabled.

  • dom/Document.cpp: (WebCore::Document::isXHTMLMPDocument):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::internalSubset): (WebCore::externalSubsetHandler):
13:34 Changeset [55801] by beidson@apple.com
  • 5 edits
    1 add in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=35977

Reviewed by Sam Weinig.

Turns out the previous attempt to clear/reset cookies wasn't working because of the way
the URLs for the .js and its .cgi were being resolved.

So this is a better way to make the cookies consistent both before and after these tests.

If this fails to make cookie-related tests reliable, then we might have to bite the bullet
and give DRT itself the ability to forcibly remove cookies via API methods.

This would be bulletproof and could be automatic if a test declares itself "cookie sensitive"
but we'd lose the ability to reliably run these tests in the browser. :(

  • http/tests/cookies/resources/resetCookies.js: Added.
  • http/tests/cookies/resources/third-party-cookie-relaxing-iframe.html:
  • http/tests/cookies/third-party-cookie-relaxing.html:
  • http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html:
  • http/tests/plugins/third-party-cookie-accept-policy.html:
13:34 Changeset [55800] by eric@webkit.org
  • 6 edits in trunk

2010-03-10 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Adding all of the touch-related sources into Chromium's WebCore build.
https://bugs.webkit.org/show_bug.cgi?id=35874

Patch tested against the try bots, but the feature is exercised in the
fast/events/touch tests.

  • WebCore.gypi:

2010-03-10 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Add support for converting WebTouchEvents to PlatformTouchEvents and
routing them into the EventHandler for the frame in which they
originate.
https://bugs.webkit.org/show_bug.cgi?id=35874

  • src/ChromeClientImpl.h: (WebKit::ChromeClientImpl::needTouchEvents):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::touchEvent): Handle incoming WebTouchEvents, converting them to PlatformTouchEvents and sending them to the EventHandler. (WebKit::WebViewImpl::handleInputEvent): Now routes WebTouchEvents to the touchEvent handler.
  • src/WebViewImpl.h:
12:37 Changeset [55799] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-03-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: now that audits panel is added, add it to the
enums (for storing last active, etc.).

https://bugs.webkit.org/show_bug.cgi?id=35980

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::specialPanelForJSName):
  • inspector/InspectorController.h: (WebCore::InspectorController::):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):
  • inspector/front-end/inspector.js: (WebInspector.showAuditsPanel):
12:34 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
12:33 Changeset [55798] by japhet@chromium.org
  • 49 edits
    1 delete in trunk

2010-03-10 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Instead of describing the type of a wrapped v8 object
with an enum value, use a pointer to struct with more complete
information.

https://bugs.webkit.org/show_bug.cgi?id=35941

Refactoring only, so new tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMData.cpp:
  • bindings/v8/DOMData.h:
  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8Helpers.cpp:
  • bindings/v8/V8Helpers.h:
  • bindings/v8/V8Index.cpp: Removed.
  • bindings/v8/V8Index.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.h:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.h:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8SharedWorkerCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.h:
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
  • bindings/v8/custom/V8WebKitPointConstructor.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
12:18 Changeset [55797] by tonikitoo@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

Extend keyboard navigation to allow directional navigation (Manual tests)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Adds a manual tests for the Spatial Navigation feature comprasing varios
Html focusable elements (e.g. <a>, <table>, <iframe>) and much of the logic
provided by the feature.

  • manual-tests/spatial-navigation/links.html: Added.
  • manual-tests/spatial-navigation/spatial-navigation-test-cases.html: Added.
12:13 Changeset [55796] by tonikitoo@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

Extend keyboard navigation to allow directional navigation (LayoutTests - part V)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This patch adds three LayoutTests that ensure the correctness of Spatial Navigation algorithm
in the following iframe related traversals:

1) All focusable elements in a <iframe> should be accessible.
2) Focusable elements in an <iframe> should be accessible even when

current focused element is in another <iframe> in the same page.

  • fast/events/spatial-navigation/snav-iframe-no-focusable-content.html: Added.
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html: Added.
  • fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html: Added.
12:10 Changeset [55795] by tonikitoo@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Extend keyboard navigation to allow directional navigation (LayoutTests - part IV)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This patch adds a LayoutTest that ensures that:

1) There is no unit overflow in the Spatial Navigation algorithm while

calculating the best node candidate to move focus to. To test that this
page positions some elements 10000000 pixels far from each other (distance
that can considered large enough for most of the Web Pages on the
Internet).

2) A best focusable candidate only gets focused if it is visible in the

current Viewport. Scroll-in-direction is performed otherwise.

  • fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html: Added.
12:08 Changeset [55794] by tonikitoo@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Extend keyboard navigation to allow directional navigation (LayoutTests - part III)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This patch adds two LayoutTests to ensure the correctness of the "Fully aligned"
precedence logic implemented by Spatial Navigation algorithm, either vertically or
horizontally: targets whose middle falls between the top and bottom of the current
focused element are preferably to move focus to, even if it is not the shortest distance.

  • fast/events/spatial-navigation/snav-fully-aligned-vertically.html: Added.
  • fast/events/spatial-navigation/snav-fully-aligned-horizontally.html: Added.
12:06 Changeset [55793] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-03-10 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to platform/efl.
http://webkit.org/b/35890

  • platform/efl/ScrollbarEfl.h: Added.
  • platform/efl/ScrollbarThemeEfl.h: Added.
11:47 Changeset [55792] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-10 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Fixing build warning caused by using 0 instead of NULL as the sentiel
in a varargs call.
https://bugs.webkit.org/show_bug.cgi?id=35898

  • src/gtk/WebInputEventFactory.cpp:
11:26 Changeset [55791] by robert@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Holger Freyther.

QtLauncher: Fix typo in conditional statement in

WebViewGraphicsBased::setFrameRateMeasurementEnabled.

'=' should be '=='!

https://bugs.webkit.org/show_bug.cgi?id=35877

  • QtLauncher/webview.cpp: (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
11:17 Changeset [55790] by pfeldman@chromium.org
  • 5 edits
    1 add in trunk/WebCore

2010-03-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Audits panel needs an icon.
Landing icon attached by Timothy. Enabling panel!

https://bugs.webkit.org/show_bug.cgi?id=35945

  • WebCore.gypi:
  • inspector/front-end/Images/auditsIcon.png: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
10:59 Changeset [55789] by kov@webkit.org
  • 3 edits in trunk/WebCore

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Roll-out r55657, as Xan noticed a bad degradation in playing
youtube HTML5 videos with it, that is fixed with it
reverted. Looks like we'll need to work a bit more on this.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedTimerFired): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::muteChangedTimerFired): (WebCore::MediaPlayerPrivate::muteChanged):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
10:41 Changeset [55788] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Fix ready state when buffering under PLAYING. We should not go
back to HaveNothing in that case.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::updateStates):
10:38 Changeset [55787] by adachan@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=35976

Retrieve any dwItemData that's set on the context menu item in contextMenuItemByIdOrPosition().

  • platform/win/ContextMenuWin.cpp:
10:31 Changeset [55786] by cjerdonek@webkit.org
  • 5 edits in trunk/WebKitTools

Refactored and cleaned up the code for unit-testing logging.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35845

  • Scripts/webkitpy/init/logtesting.py:
    • Added more information to the module docstring.
    • Added an assertMessages() method to the UnitTestLogStream class. This simplifies the calling code.
    • Renamed the UnitTestLog class to LogTesting, and reformulated it as follows:
      • Moved the logging configuration code from the init method to a new static setUp() method.
      • Documented the init method to be private.
      • Improved the code so that the root logger does not have its logging level changed. Instead we set the handler's level. This makes the unit testing more unintrusive.
      • Updated the assertMessages() method to call the UnitTestLogStream class's assertMessages() method.
      • More fully documented the class.
  • Scripts/webkitpy/style/checker.py:
    • Added a logger parameter to the configure_logging() method. This allows us to prevent test messages from being sent to the root logger during unit testing, which may be rendering to the screen, etc.
    • Simplified the code by removing the _LevelLoggingFilter class.
    • Replaced the _LevelLoggingFilter class with a one-line lambda expression in configure_logging().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Changed relative imports to absolute to comply more with PEP8.
    • In the ConfigureLoggingTest class:
      • Changed the setUp() method to prevent test messages from being propagated to the root logger.
      • Changed the _log() method to a data attribute.
      • Updated to accommodate changes to logtesting.py.
  • Scripts/webkitpy/style_references.py:
    • Updated an import statement.
09:36 WikiStart edited by evan@chromium.org
add a gdb section (diff)
09:35 Changeset [55785] by evan@chromium.org
  • 1 edit
    2 adds in trunk/WebKitTools

2010-03-10 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Python code for GDB 7 to support native printing of some WebCore types.

  • gdb/webcore.py: Added.
09:06 Changeset [55784] by jorlow@chromium.org
  • 8 edits
    8 adds in trunk

2010-03-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Add IndexedDatabase class and hook it up.
https://bugs.webkit.org/show_bug.cgi?id=35927

This change is mostly just adding the plumbing necessary for
the IndexedDatabaseRequest and IndexedDatabaseSync (not written
yet).

This code is non-functional, so no tests (yet).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • storage/IndexedDatabase.cpp: Added. (WebCore::IndexedDatabase::get):
  • storage/IndexedDatabase.h: Added. (WebCore::IndexedDatabase::~IndexedDatabase):
  • storage/IndexedDatabaseImpl.cpp: Added. (WebCore::IndexedDatabaseImpl::get): (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h: Added.
  • storage/chromium/IndexedDatabase.cpp: Added. (WebCore::IndexedDatabase::get):
  • WebKit.gyp:
  • public/WebIndexedDatabase.h: Added. (WebKit::WebIndexedDatabase::~WebIndexedDatabase):
  • public/WebKitClient.h: (WebKit::WebKitClient::getIndexedDatabase):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::getIndexedDatabase):
  • src/IndexedDatabaseProxy.cpp: Added. (WebCore::IndexedDatabaseProxy::create): (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::~IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::open):
  • src/IndexedDatabaseProxy.h: Added.
08:56 Changeset [55783] by dglazkov@chromium.org
  • 3 edits
    2 adds in trunk

Add one more parent check during node removal.
https://bugs.webkit.org/show_bug.cgi?id=35818

Reviewed by Sam Weinig.

WebCore:

Test: fast/dom/Node/mutation-blur.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild): Added check.

LayoutTests:

  • fast/dom/Node/mutation-blur-expected.txt: Added.
  • fast/dom/Node/mutation-blur.html: Added.
08:50 Changeset [55782] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] fast/multicol/hit-test-above-or-below.html fails
https://bugs.webkit.org/show_bug.cgi?id=35973

The test was introduced in r55546, it has been failing since then.

  • platform/qt/Skipped: fast/multicol/hit-test-above-or-below.html skipped until fix.
08:34 Changeset [55781] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-10 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: added missing quote to localized strings.

  • English.lproj/localizedStrings.js:
07:47 Changeset [55780] by aroben@apple.com
  • 3 edits in trunk/WebKitTools

Make svn-create-patch and prepare-ChangeLog show better section headings for ObjC files

This makes the text at the end of each "@@" line in a diff actually
show the ObjC method or interface that contains the change, rather
than whatever the most-recently-defined C function was.

Fixes <http://webkit.org/b/35970>.

Reviewed by John Sullivan.

  • Scripts/svn-create-patch: Pass -F'[-+@]' to diff so that it will

treat any lines starting with -, +, or @ as section heading lines.
This works well for ObjC files, and shouldn't affect other types of
files.

  • Scripts/prepare-ChangeLog: Changed the options passed to diff to

match those used in svn-create-patch.

07:38 Changeset [55779] by jorlow@chromium.org
  • 1 edit
    3 adds in trunk/WebCore

Commit files that were supposed to go in with the last checkin.

07:34 Changeset [55778] by jorlow@chromium.org
  • 7 edits in trunk/WebCore

Baby steps towards IndexedDB: Start implementing callbacks.
https://bugs.webkit.org/show_bug.cgi?id=35911

Reviewed by Dimitry Glazkov.

This patch adds some infastructure for IndexedDB callbacks in V8.
It also adds a stub of IDBDatabaseRequest. In the near future,
I'll gut the event based implementation code, flesh out IDBReqest
further, and start plumbing IndexedDatabaseRequest.

Code is not testible because it doesn't work (yet).

  • WebCore.gypi:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CustomIDBCallback.h: Added.

(WebCore::V8CustomIDBCallback::create):
(WebCore::V8CustomIDBCallback::~V8CustomIDBCallback):
(WebCore::V8CustomIDBCallback::handleEvent):
(WebCore::V8CustomIDBCallback::V8CustomIDBCallback):

  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:

(WebCore::V8IndexedDatabaseRequest::openCallback):

  • storage/IDBDatabaseRequest.h: Added.

(WebCore::IDBDatabaseRequest::request):

  • storage/IDBDatabaseRequest.idl: Added.
  • storage/IndexedDatabaseRequest.idl:
07:17 Changeset [55777] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-03-10 Priit Laes <plaes@plaes.org>

Reviewed by Gustavo Noronha.

Estonian translation.

  • et.po: Added.
05:23 Changeset [55776] by sullivan@apple.com
  • 4 edits in trunk/WebKit

<rdar://problem/7735387> input type other than text won't work with autofill
<https://bugs.webkit.org/show_bug.cgi?id=35963>

Reviewed by Tim Hatcher.

WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation elementDoesAutoComplete:]):
Return true for any text field that's not a password, rather than only
for TEXT type.

WebKit/win:

  • WebFrame.cpp:

(WebFrame::elementDoesAutoComplete):
Return true for any text field that's not a password, rather than only
for TEXT type.

04:44 BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
(diff)
04:10 Changeset [55775] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

Link QtLauncher against the WebKit library using a relative rpath.

Reviewed by Tor Arne Vestbø.

This makes the launcher and the lib relocatable.

  • QtLauncher/QtLauncher.pro:
02:46 Changeset [55774] by zecke@webkit.org
  • 2 edits
    3 adds in trunk/WebCore

[Qt] Non animated gifs are animated in QtWebKit

https://bugs.webkit.org/show_bug.cgi?id=35955

Properly map Qt animated and non-animated values to WebCore's
understanding of animated and non-animated images. Currently
we can not map anything to the cAnimationLoopNone value.

  • manual-tests/qt/qt-anim.gif: Added.
  • manual-tests/qt/qt-gif-test.html: Added.
  • manual-tests/qt/qt-noanim.gif: Added.
  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::repetitionCount):

02:44 Changeset [55773] by zecke@webkit.org
  • 3 edits
    2 adds in trunk

[CAIRO] DoS on iexploder test with high text stroke width.

https://bugs.webkit.org/show_bug.cgi?id=33759

Specifying a big text stroke width can make WebKitGTK+ spend
a very long time in the cairo library for stroking the path of
the text. The best way to prevent this from happening right now
is to not stroke paths with a certain width. Samuel proposed to
not stroke with a width that is twice the width of the text. The
reason to use twice the text width is that even one stroke of
any charachter to be drawn would cover the full width.

Test: fast/text/text-stroke-width-cairo-dos.html

WebCore:

  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::drawGlyphs):

Add a test case with the -webkit-text-stroke-width attribute
set to a high value to illustrate the issue.

  • fast/text/text-stroke-width-cairo-dos-expected.txt: Added.
  • fast/text/text-stroke-width-cairo-dos.html: Added.
01:41 Changeset [55772] by zecke@webkit.org
  • 4 edits in trunk/WebKitTools

[iExploder] Add new CSS Properties and HTML Attributes

The update-iexploder-cssproperties script was used to update
the various input files. The autobuffer HTML Attribute was removed
from WebKit and I manually added it back to the htmlattrs.in like
we have done it for other attributes in the past.

01:22 Changeset [55771] by pfeldman@chromium.org
  • 28 edits
    1 copy
    2 adds in trunk

2010-03-10 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: display list of active workers & support debugging
with fake workers.
https://bugs.webkit.org/show_bug.cgi?id=35568

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
  • dom/Document.cpp: (WebCore::Document::inspectorController):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::inspectorController):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectScript): (WebCore::InjectedScriptHost::nextWorkerId): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::willDestroyWorker):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::willDestroyWorker):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCreateWorker): (WebCore::InspectorFrontend::willDestroyWorker):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorWorkerResource.h: Added. (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::url): (WebCore::InspectorWorkerResource::isSharedWorker): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
  • inspector/front-end/Checkbox.js: Added. (WebInspector.Checkbox.callbackWrapper): (WebInspector.Checkbox): (WebInspector.Checkbox.prototype.checked):
  • inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._handleException): (InjectedFakeWorker.FakeWorker.prototype._importScripts): (InjectedFakeWorker.FakeWorker.prototype._loadScript): (InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.showInheritedToggleFunction): (WebInspector.StylePropertiesSection):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WorkersSidebarPane.js: Added. (WebInspector.WorkersSidebarPane): (WebInspector.WorkersSidebarPane.prototype.addWorker): (WebInspector.WorkersSidebarPane.prototype.removeWorker): (WebInspector.WorkersSidebarPane.prototype.setInstrumentation): (WebInspector.WorkersSidebarPane.prototype.reset): (WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument): (WebInspector.Worker): (WebInspector.didCreateWorker): (WebInspector.willDestroyWorker):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker): (WebCore::AbstractWorker::contextDestroyed):
  • workers/AbstractWorker.h: (WebCore::AbstractWorker::id):
  • workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
  • workers/Worker.cpp: (WebCore::Worker::Worker):

WebKit/chromium:

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
01:02 Changeset [55770] by zoltan@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-03-10 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Eric Seidel.

Make global new/delete operators configurable for all ports and disable it
for the wx port for now.

  • wtf/FastMalloc.h:
  • wtf/Platform.h:
00:41 Changeset [55769] by tony@chromium.org
  • 1 edit
    1 add in trunk/WebKit/chromium

2010-03-10 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=35956
Create a grd file upstream for resources that chromium uses
that are pulled directly from the upstream repository.

  • WebKit.grd: Added.
00:06 Changeset [55768] by philn@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-03-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] testkeyevents doesn't stop if input event injection fails
https://bugs.webkit.org/show_bug.cgi?id=35922

  • tests/testkeyevents.c: (load_status_cb): Added a safeguard to exit from the test if the input event injection failed.

03/09/10:

22:32 Changeset [55767] by rolandsteiner@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed build fix. Fix variable name change that somehow didn't
make it into the patch.

22:23 Changeset [55766] by rolandsteiner@chromium.org
  • 12 edits
    3 adds in trunk

Bug 28293 - [Chromium] event.datatransfer.getdata("text/uri-list") is treated the same as getdata("URL")
https://bugs.webkit.org/show_bug.cgi?id=28293

Reviewed by David Levin.

WebCore:

Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
correctly for event.dataTransfer.getData/setData. Currently both are treated
as synonyms, but for "URL", getData is supposed to only return the first valid URL
contained within the data for "text/uri-list" (see HTML5 spec).

Tests: editing/pasteboard/dataTransfer-setData-getData.html

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):

  • platform/chromium/ChromiumDataObject.h:

(WebCore::ChromiumDataObject::clearURL):
(WebCore::ChromiumDataObject::hasValidURL):
(WebCore::ChromiumDataObject::getURL):
(WebCore::ChromiumDataObject::setURL):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::):
(WebCore::clipboardTypeFromMIMEType):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):
(WebCore::DragData::canSmartReplace):

WebKit/chromium:

Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
correctly for event.dataTransfer.getData/setData. Currently both are treated
as synonyms, but for "URL", getData is supposed to only return the first valid URL
contained within the data for "text/uri-list" (see HTML5 spec).

Tests: editing/pasteboard/dataTransfer-setData-getData.html

  • src/WebDragData.cpp:

(WebKit::WebDragData::url):
(WebKit::WebDragData::setURL):

LayoutTests:

Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
correctly for event.dataTransfer.getData/setData. Currently both are treated
as synonyms, but for "URL", getData is supposed to only return the first valid URL
contained within the data for "text/uri-list" (see HTML5 spec).

Layout test checks various combinations in a drag-n-drop operation.
Skipping on all other platforms since they don't implement this correctly, either.

  • editing/pasteboard/dataTransfer-setData-getData.html: Added.
  • editing/pasteboard/script-tests/dataTransfer-setData-getData.js: Added.

(dragTarget):
(moveMouseToCenterOfElement):
(dragOntoDragTarget):
(doDrop):
(test):
(runTest):

  • platform/mac/Skipped:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
22:17 Changeset [55765] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: REGRESSION: Tall image resources are cropped over the bottom.

https://bugs.webkit.org/show_bug.cgi?id=34720

  • inspector/front-end/inspector.css:
22:13 Changeset [55764] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: REGRESSION: Pressing up/down arrow key to change numeric
value in CSS property takes focus away.

https://bugs.webkit.org/show_bug.cgi?id=34697

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
21:46 Changeset [55763] by ukai@chromium.org
  • 3 edits in trunk/WebKitTools

2010-03-09 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Obvious fix for --cgi-paths of pywebsocket.

  • Scripts/run-webkit-websocketserver:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
21:32 Changeset [55762] by tony@chromium.org
  • 10 edits
    4 adds in trunk

2010-03-09 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=21840
https://bugs.webkit.org/show_bug.cgi?id=23993

Fix an editing bug where replacing a selection would result in the
new text ending up inside nodes that were not visibly included in the
selection. Instead, move our destination position out of nodes that
were not visibly included.

Two new tests to verify the new behavior. Because we're now inserting
outside of some formatting nodes, some span tags are no longer necessary
for undoing formatting caused by these formatting nodes.

  • editing/deleting/backspace-avoid-preceding-style-expected.txt: Added.
  • editing/deleting/backspace-avoid-preceding-style.html: Added.
  • editing/inserting/replace-at-visible-boundary-expected.txt: Added.
  • editing/inserting/replace-at-visible-boundary.html: Added.
  • platform/mac/editing/deleting/delete-3857753-fix-expected.txt:
  • platform/mac/editing/inserting/insert-div-026-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • platform/mac/editing/style/font-family-with-space-expected.txt:
  • platform/mac/editing/style/smoosh-styles-001-expected.txt:
  • platform/mac/editing/style/style-boundary-005-expected.txt:

2010-03-09 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=21840
https://bugs.webkit.org/show_bug.cgi?id=23993

Fix an editing bug where replacing a selection would result in the
new text ending up inside nodes that were not visibly included in the
selection. Instead, move our destination position out of nodes that
were not visibly included.

Tests: editing/deleting/backspace-avoid-preceding-style.html

editing/inserting/replace-at-visible-boundary.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::positionAvoidingPrecedingNodes): (WebCore::ReplaceSelectionCommand::doApply):
20:53 Changeset [55761] by beidson@apple.com
  • 9 edits in trunk

REGRESSION: WebInspector docking busted on Windows
<rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953

Reviewed by Tim Hatcher.

WebCore:

First off, a bit of settings-key related cleanup. If they're shared over multiple files, these
things should be properly declared Strings, not random loose char*'s.

Along with that change, we move the "inspectorStartsAttachedSettingName" from WebKit down to the
InspectorController in WebCore.

Finally, when the controller is ready to show the WebInspector window, it can use this newly
exposed settings key to call "setWindowVisible" directly instead of relying on "showWindow" to do
it indirectly.

  • WebCore.base.exp:
  • inspector/InspectorBackend.cpp:

(WebCore::InspectorBackend::saveFrontendSettings):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::frontendSettingsSettingName):
(WebCore::InspectorController::inspectorStartsAttachedSettingName):
(WebCore::InspectorController::scriptObjectReady): Using the new inspectorStartsAttachedSettingName

key and some "can I attach this?" logic, call setWindowVisible directly to display the inspector
window.

(WebCore::InspectorController::populateScriptObjects):

  • inspector/InspectorController.h:

WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController showWindow:]): Use the InspectorController:: copy of the should attach settings key.
(-[WebInspectorWindowController attach]): Ditto.
(-[WebInspectorWindowController detach]): Ditto.

WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::attachWindow): Use the InspectorController:: copy of the should attach settings key.
(WebInspectorClient::detachWindow): Ditto.
(WebInspectorClient::showWindowWithoutNotifications): Ditto.

20:05 Changeset [55760] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=35951
<rdar://problem/7327060> Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80

  • bridge/objc/objc_instance.mm: (createInstanceWrapperCache): Fix Tiger code path, too.
18:45 Changeset [55759] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.23

Tagging 1.1.23.

17:44 Changeset [55758] by jam@chromium.org
  • 4 edits in trunk/WebKit/chromium

Reviewed by Darin Fisher.

Need to send mouse events to plugin when it has mouse capture
https://bugs.webkit.org/show_bug.cgi?id=35900

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isMouseEventType):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::mouseDown):
(WebKit::WebViewImpl::mouseUp):
(WebKit::WebViewImpl::handleInputEvent):

  • src/WebViewImpl.h:
17:29 Changeset [55757] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=35951
<rdar://problem/7327060> Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80

  • bridge/objc/objc_instance.mm: (createInstanceWrapperCache): It's not correct to use object personality for keys, because the key can be a mutable object, so its hash can change over its lifetime.
16:49 Changeset [55756] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] http/tests/plugins/third-party-cookie-accept-policy.html was introduced in r55738,
but layoutTestController.setAlwaysAcceptCookies() is missing.

  • platform/qt/Skipped: http/tests/plugins/third-party-cookie-accept-policy.html skipped.
16:45 Changeset [55755] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

16:43 Changeset [55754] by mrowe@apple.com
  • 1 copy in tags/Safari-533.2

New tag.

16:17 Changeset [55753] by ojan@chromium.org
  • 3 edits in trunk/WebCore

2010-03-09 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

Fix review comment accidentally overlooked in bug 35713
https://bugs.webkit.org/show_bug.cgi?id=35947

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
  • editing/DeleteSelectionCommand.h:
15:41 Changeset [55752] by ojan@chromium.org
  • 5 edits
    4 adds in trunk

2010-03-03 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

undo after smartdelete should select the deleted space
https://bugs.webkit.org/show_bug.cgi?id=35713

  • editing/undo/undo-smart-delete-reversed-selection-expected.txt: Added.
  • editing/undo/undo-smart-delete-reversed-selection.html: Added.
  • editing/undo/undo-smart-delete-word-expected.txt: Added.
  • editing/undo/undo-smart-delete-word.html: Added.

2010-03-03 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

undo after smartdelete should select the deleted space
https://bugs.webkit.org/show_bug.cgi?id=35713

TextEdit behavior is to select the deleted space after a smartdelete.

Tests: editing/undo/undo-smart-delete-reversed-selection.html

editing/undo/undo-smart-delete-word.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete): (WebCore::DeleteSelectionCommand::initializePositionData):
  • editing/DeleteSelectionCommand.h:
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::setWithoutValidation): This assert looks bogus to me. undo-smart-delete-reversed-selection.html hits it but not as a result of the other changes in this patch. The granularity when deleting after making a wordgranularity selection is wordgranularity, not charactergranularity.
15:32 Changeset [55751] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

This caused a performance regression, by breaking the code
generator's logic to calculate the skip level for resolving
variables (traced by rdar:7683350) Reverting for now.

Reviewed by NOBODY (reverting r54510).

  • parser/Grammar.y:
  • parser/NodeConstructors.h:

(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

  • runtime/CommonIdentifiers.h:
  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

15:07 Changeset [55750] by ggaren@apple.com
  • 5 edits in trunk

JavaScriptCore: Changed FastMalloc statistics reporting to be a bit clearer. We now
report:

  • Reserved VM Bytes: the VM that has been mapped into the process.
  • Committed VM Bytes: the subset of Reserved VM Bytes actually in use.
  • Free List Bytes: the subset of Committed VM Bytes in a free list.

Reviewed by Darin Adler.

  • wtf/FastMalloc.cpp:

(WTF::fastMallocStatistics):
(WTF::TCMallocStats::fastMallocStatistics): Updated to report the statistics
above. Standardized use of "ifdef WTF_CHANGES". Added a SpinLockHolder
around all statistics gathering, since it reads from the page heap.

  • wtf/FastMalloc.h: Updated to report the statistics above.

WebKit/mac: Updated for FastMalloc reporting changes.

Reviewed by Darin Adler.

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics memoryStatistics]):

14:40 Changeset [55749] by jwieczorek@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-09 Jakub Wieczorek <jwieczorek@webkit.org>

Unreviewed.

Adding myself to committers.py.

  • Scripts/webkitpy/committers.py:
14:37 Changeset [55748] by darin@chromium.org
  • 3 edits
    2 adds in trunk

2010-03-09 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Fisher.

Accept and bailout NULL widgets in ChromiumBridge
https://bugs.webkit.org/show_bug.cgi?id=35796

  • src/ChromiumBridge.cpp: (WebCore::toChromeClientImpl):
14:24 Changeset [55747] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Rubber stamped by Adam Roben.

Load debug version of graphics library in Windows Debug_All builds.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):

14:13 Google Summer of Code 2010 edited by jorlow@chromium.org
(diff)
14:02 CommitterTips edited by jwieczorek@webkit.org
Fix a few typos. (diff)
14:00 Changeset [55746] by sullivan@apple.com
  • 4 edits in trunk/WebKit

Fixed localized string key collision. update-webkit-localized-strings now
runs without errors.

Reviewed by Adam Roben.

WebKit:

  • English.lproj/Localizable.strings:

Regenerated.

WebKit/win:

  • WebCoreLocalizedStrings.cpp:

(WebCore::AXMenuListPopupActionVerb):
Used LPCTSTR_UI_STRING_KEY for the 2nd use of "press".

13:49 Changeset [55745] by sullivan@apple.com
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt:

Brought this file up to date. update-webkit-localizable-strings still lists
one key collision, but that's a separate issue.

13:29 Changeset [55744] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-09 Gustavo Noronha Silva <gns@gnome.org>

[GTK] Fails http/tests/plugins/third-party-cookie-accept-policy.html
https://bugs.webkit.org/show_bug.cgi?id=35942

Unreviewed. Skip test that fails, while we look for the
problem. This is likely a bug in soup.

  • platform/gtk/Skipped:
13:25 Changeset [55743] by kov@webkit.org
  • 4 edits in trunk

Unreviewed. Versioning, and documentation control files update for 1.1.23.

13:25 Changeset [55742] by beidson@apple.com
  • 4 edits in trunk/LayoutTests

Fix my layouttest failures by resetting cookies before and after these new tests.
https://bugs.webkit.org/show_bug.cgi?id=26391

Reviewed by Alexey Proskuryakov.

  • http/tests/cookies/third-party-cookie-relaxing.html:
  • http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html:
  • http/tests/plugins/third-party-cookie-accept-policy.html:
13:23 Changeset [55741] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-09 Dirk Pranke <dpranke@chromium.org>

Reviewed by Nate Chapin.

Fix --clobber-old-results in new-run-webkit-tests.

https://bugs.webkit.org/show_bug.cgi?id=35778

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12:58 Changeset [55740] by aroben@apple.com
  • 2 edits in trunk/WebKitSite

Add a link to the Contributors Meeting registration form in the sidebar

Rubber-stamped in advance by Adele Peterson.

  • nav.inc: Added a link underneath "Trac".
11:56 Changeset [55739] by adele@apple.com
  • 2 edits in trunk/WebKitTools

Add the ability to dispatch scroll wheel events in DRT. This was
necessary in order to write a test for
https://bugs.webkit.org/show_bug.cgi?id=34700.

Patch by Andy Estes <aestes@apple.com> on 2010-03-09
Reviewed by Adele Peterson.

  • DumpRenderTree/mac/EventSendingController.mm: Add support for two

new methods to EventSender: mouseScrollBy(x, y) and
continuousMouseScrollBy(x, y). The API to generate scroll events on
the mac was added in 10.5, so these methods are NOOPs on Tiger.
(+[EventSendingController isSelectorExcludedFromWebScript:]):
Regiester mouseScrollByX:andY: and continuousMouseScrollByX:andY:
(+[EventSendingController webScriptNameForSelector:]): Map JavaScript
method names to ObjC selectors.
(-[EventSendingController mouseScrollByX:andY:continuously:]): Generate
a scroll wheel event using CGEventCreateScrollWheelEvent() and dispatch
it to WebKit.
(-[EventSendingController continuousMouseScrollByX:andY:]): Generate a
continuous scrolling event by x and y pixels.
(-[EventSendingController mouseScrollByX:andY:]): Generate a notchy
scrolling event by x and y lines.

11:52 Changeset [55738] by beidson@apple.com
  • 4 edits
    3 adds in trunk

Plug-ins don't always respect the cookie accept policy.
<rdar://problem/7338359> and https://bugs.webkit.org/show_bug.cgi?id=26391

Reviewed by Darin Adler.

WebCore:

The problem is that the various plug-in implementations call into a ResourceLoader
directly instead of filtering the request through FrameLoader. This bypassed the step
of adding extra fields to the requests, such as the firstPartyForCookies URL.

Since plug-in code is currently so strewn about and very platform specific, I
think reworking it needs to be a task for domain experts. I don't know the implications
of adding *all* the extra fields to plug-in requests, for example.

There's no harm in this targeted fix for the hole in our cookie accept policy until
plug-ins can more fundamentally change.

Test: http/tests/plugins/third-party-cookie-accept-policy.html

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::load): Don't load a resource without first giving the request

a firstPartyForCookies URL.

LayoutTests:

  • http/tests/cookies/resources/cookie-utility.php:
  • http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html: Added.
  • http/tests/plugins/third-party-cookie-accept-policy.html: Added.
11:32 Changeset [55737] by adele@apple.com
  • 7 edits
    2 adds in trunk

WebCore: Check for null renderer in scrollNode().
https://bugs.webkit.org/show_bug.cgi?id=34700

Patch by Andy Estes <aestes@apple.com> on 2010-03-09
Reviewed by Adele Peterson.

Test: fast/events/remove-child-onscroll.html

  • page/EventHandler.cpp:

(WebCore::scrollNode): Return early if node->renderer() == 0

LayoutTests: Create a test for https://bugs.webkit.org/show_bug.cgi?id=34700. This
test required implementing scroll wheel event dispatch in DRT and
currently only works on OS X 10.5+. Skip this test on other platforms
for the time being.

Patch by Andy Estes <aestes@apple.com> on 2010-03-09
Reviewed by Adele Peterson.

  • fast/events/remove-child-onscroll-expected.txt: Added.
  • fast/events/remove-child-onscroll.html: Added.
  • platform/gtk/Skipped: Skip remove-child-onscroll.html
  • platform/mac-tiger/Skipped: Skip remove-child-onscroll.html
  • platform/qt/Skipped: Skip remove-child-onscroll.html
  • platform/win/Skipped: Skip remove-child-onscroll.html
11:20 QtWebKitContrib edited by jocelyn.turcotte@nokia.com
(diff)
11:18 QtWebKitContrib edited by jocelyn.turcotte@nokia.com
(diff)
11:12 Changeset [55736] by kov@webkit.org
  • 4 edits in trunk

Unreviewed distcheck fix

11:11 Changeset [55735] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-09 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Adler.

Fix send-oncancel-event. It uses js-test-post, not
js-test-post-function.
https://bugs.webkit.org/show_bug.cgi?id=35880

  • fast/events/touch/script-tests/send-oncancel-event.js: (touchcancelHandler):
10:45 Changeset [55734] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix (only exposed by make distcheck). The

SharedWorkers files are not built, they need to be distributed.

  • GNUmakefile.am:
10:43 Changeset [55733] by kov@webkit.org
  • 3 edits in trunk/WebCore

2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Dirk Schulze.

[GStreamer] Buffering logic is not correct, and does not work very well
https://bugs.webkit.org/show_bug.cgi?id=35706

Fix buffering to match GStreamer expectancies regarding the
pipeline state, so that videos which really need buffering to play
correctly also work, while maintaining the convenience of
on-disk-buffering. This required a bit of shuffling of state
change handling.

No behaviour change expected.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::updateStates):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
10:35 Changeset [55732] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Dirk Schulze.

[GStreamer] Buffering logic is not correct, and does not work very well
https://bugs.webkit.org/show_bug.cgi?id=35706

Do not call pause(), but set the GStreamer state directly. This is
just a GStreamer implementation detail, and this will avoid having
side effects in case we change the pause implementation in the
future.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::load):
10:25 Changeset [55731] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

2010-03-09 Simon Fraser <simon.fraser@apple.com>

Skip media/video-source-error.html on SnowLeopard, beacuse it fails sporadically.
This is covered by https://bugs.webkit.org/show_bug.cgi?id=32270.

  • platform/mac-snowleopard/Skipped:
10:11 Changeset [55730] by cfleizach@apple.com
  • 2 edits in trunk/WebKitTools

DRT build fix for Tiger. No review.

AX: hit testing a list box doesn't work anymore
https://bugs.webkit.org/show_bug.cgi?id=35893

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::elementAtPoint):

09:42 Changeset [55729] by cfleizach@apple.com
  • 9 edits
    2 adds in trunk

AX: hit testing a list box doesn't work anymore
https://bugs.webkit.org/show_bug.cgi?id=35893

Reviewed by Darin Adler.

WebCore:

Since <option> elements don't have renderers, their hit testing needs
to be handled with a special case.

Test: platform/mac/accessibility/listbox-hit-test.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaIsHidden):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):

WebKitTools:

  • DumpRenderTree/AccessibilityController.cpp:

(getElementAtPointCallback):
(AccessibilityController::getJSClass):

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::elementAtPoint):

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::elementAtPoint):

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::elementAtPoint):

LayoutTests:

  • platform/mac/accessibility/listbox-hit-test-expected.txt: Added.
  • platform/mac/accessibility/listbox-hit-test.html: Added.
09:37 Changeset [55728] by pfeldman@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-03-09 Pavel Feldman <pfeldman@chromium.org>

r55727 was landed with wrong commit messages. Should have been:

Reviewed by Timothy Hatcher.

Web Inspector: Refactor Audits panel presentation layer.
This change removes unnecessary complexity:

  • Audit scores were not used
  • Audit rule parameters are passed as rule constructor arguments
  • View management aligned with the rest of the front-end
  • Single TreeOutline is used for category results (no need to create sections for those)
  • Rules code beautified and simplified where possible
  • Some UI improvements applied (see attached screenshot)

https://bugs.webkit.org/show_bug.cgi?id=35860

09:34 Changeset [55727] by pfeldman@chromium.org
  • 8 edits in trunk/WebCore

2010-03-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.


When enable resource tracking state changes use the same method as
location.reload for reloading inspected page.

https://bugs.webkit.org/show_bug.cgi?id=35923

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::reloadPage):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking):
09:22 Changeset [55726] by yurys@chromium.org
  • 7 edits in trunk

2010-03-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.


When enable resource tracking state changes use the same method as
location.reload for reloading inspected page.

https://bugs.webkit.org/show_bug.cgi?id=35923

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::reloadPage):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking):

2010-03-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Use clean global object for devtools utility context instead of
trying to simulate inspected context.


https://bugs.webkit.org/show_bug.cgi?id=35923

  • src/DebuggerAgentImpl.cpp:
  • src/DebuggerAgentImpl.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::resetInspectorFrontendProxy):
08:24 Changeset [55725] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: highlight text node containers while searching for node.

https://bugs.webkit.org/show_bug.cgi?id=35912

  • inspector/InspectorController.cpp: (WebCore::InspectorController::mouseDidMoveOverElement):
07:51 QtWebKitRelease20 edited by jocelyn.turcotte@nokia.com
(diff)
07:47 Changeset [55724] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] editing/execCommand/move-selection-back-line.html fails in DRT.
https://bugs.webkit.org/show_bug.cgi?id=35921

  • platform/qt/Skipped: editing/execCommand/move-selection-back-line.html skipped until fix.
07:46 QtWebKitRelease20Deployment created by jocelyn.turcotte@nokia.com
07:39 QtWebKitBugs edited by hausmann@webkit.org
(diff)
06:46 Changeset [55723] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-03-09 Peteris Krisjanis <pecisk@gmail.com>

Reviewed by Gustavo Noronha.

Latvian translation.

  • lv.po: Added.
06:42 Changeset [55722] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-03-09 Duy Nguyen <pclouds@gmail.com>

Reviewed by Gustavo Noronha.

Vietnamese translation update.

  • vi.po:
06:36 Changeset [55721] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-03-09 Rimas Kudelis <rq@akl.lt>

Reviewed by Gustavo Noronha.

Lithuanian translation update.

  • lt.po:
03:23 Changeset [55720] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

[Qt] perl websocket test(s) time out
https://bugs.webkit.org/show_bug.cgi?id=34879
It was fixed by r55719, so we can unskip websocket/tests/cookies/httponly-cookie.pl.

storage/open-database-creation-callback-isolated-world.html removed
from Skipped list, because it was removed from tree by r55635.

  • platform/qt/Skipped:
    • websocket/tests/cookies/httponly-cookie.pl unskipped.
    • storage/open-database-creation-callback-isolated-world.html unskipped.
03:20 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
Add the all triaged bugs list (diff)
02:40 Changeset [55719] by ukai@chromium.org
  • 11 edits
    3 copies
    3 adds
    1 delete in trunk

2010-03-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

pywebsocket should support html and cgi in the same directory.
https://bugs.webkit.org/show_bug.cgi?id=34879

  • websocket/tests/cookies: Removed.
  • websocket/tests/cookies/echo-cookie_wsh.py: Removed.
  • websocket/tests/cookies/httponly-cookie-expected.txt: Removed.
  • websocket/tests/cookies/httponly-cookie.pl: Removed.
  • websocket/tests/echo-cookie_wsh.py: Copied from LayoutTests/websocket/tests/cookies/echo-cookie_wsh.py.
  • websocket/tests/httponly-cookie-expected.txt: Copied from LayoutTests/websocket/tests/cookies/httponly-cookie-expected.txt.
  • websocket/tests/httponly-cookie.pl: Copied from LayoutTests/websocket/tests/cookies/httponly-cookie.pl.

2010-03-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

pywebsocket should support html and cgi in the same directory.
https://bugs.webkit.org/show_bug.cgi?id=34879

Import pywebsocket 0.4.9.2
Specify --server-host 127.0.0.1, so that it only binds listening socket
to 127.0.0.1 to prevent access from non-localhost.
Change --cgi-paths from /websocket/tests/cookies to /websocket/tests,
because pywebsocket 0.4.9.2 supports html and cgi in the same directory
and only executable (httponly-cookies.pl) will be handled as cgi
script.

  • Scripts/run-webkit-tests:
  • Scripts/run-webkit-websocketserver:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/README.webkit:
  • Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/setup.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added.
01:36 Changeset [55718] by loki@webkit.org
  • 4 edits in trunk/JavaScriptCore

Rubber-stamped by Maciej Stachowiak.

Buildfix for ARM after r55684. Add branch8 and branchTest8 functions.
https://bugs.webkit.org/show_bug.cgi?id=35892

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::dataTransfer32):

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branchTest8):

01:01 Changeset [55717] by philn@webkit.org
  • 3 edits in trunk/WebCore

2010-03-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] player code cleanups
https://bugs.webkit.org/show_bug.cgi?id=35868

Cleaned up the private instance variables of the player.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::mediaLocationChanged):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
01:01 Changeset [55716] by philn@webkit.org
  • 7 edits
    2 copies
    2 moves in trunk/WebCore

2010-03-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] player code cleanups
https://bugs.webkit.org/show_bug.cgi?id=35868

Splitted GOwnPtrGtk.{cpp,h} to GOwnPtr{Soup,GStreamer}.{cpp,h}.

  • GNUmakefile.am:
  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Added. (WTF::GstElement):
  • platform/graphics/gstreamer/GOwnPtrGStreamer.h: Added.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/gtk/GOwnPtrGtk.cpp: Removed.
  • platform/gtk/GOwnPtrGtk.h: Removed.
  • platform/network/soup/CookieJarSoup.cpp:
  • platform/network/soup/DNSSoup.cpp:
  • platform/network/soup/GOwnPtrSoup.cpp: Added. (WTF::SoupURI):
  • platform/network/soup/GOwnPtrSoup.h: Added.
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/soup/ResourceRequestSoup.cpp:
00:30 Changeset [55715] by cjerdonek@webkit.org
  • 3 edits in trunk/WebKitTools

Simplified check-webkit-style's argument parsing code by removing
support for the vestigial "extra flag values" parameter.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34677

The "extra flag values" parameter was needed before WebKit
forked check-webkit-style from Google. It was used to pass
through the option parser those command-line flags that WebKit
required but that Google's parser did not support (the --git-commit
flag in particular).

We can remove the parameter now because it is no longer

needed and unnecessarily clutters the argument-parsing code.

  • Scripts/webkitpy/style/optparser.py:
    • Removed the extra_flag_values parameter from the CommandOptionValues class's constructor.
    • Removed the extra_flags parameter from the ArgumentParser class's parse() method.
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Removed from the unit tests all references to the extra_flag_values variable.
00:23 Changeset [55714] by hamaji@chromium.org
  • 3 edits in trunk/WebCore

2010-03-09 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Should remove paddings of Win/Linux chromium's buttons
https://bugs.webkit.org/show_bug.cgi?id=35629

No new tests, but we may need to rebaseline bunch of expectation
images in chromium's tree.

  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumSkia.h:

03/08/10:

22:52 Changeset [55713] by tkent@chromium.org
  • 1 edit
    2 adds in trunk/WebKitTools

2010-03-08 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add EventSender
https://bugs.webkit.org/show_bug.cgi?id=35859

Add EventSender classes, which are going to be used by
DumpRenderTree Chromium port. These files are based on:

  • src/webkit/tools/test_shell/event_sending_controller.cc
  • src/webkit/tools/test_shell/event_sending_controller.h of Chromium rev.40492.
  • DumpRenderTree/chromium/EventSender.cpp: Added.
  • DumpRenderTree/chromium/EventSender.h: Added.
22:39 Changeset [55712] by tkent@chromium.org
  • 1 edit
    4 adds in trunk/WebKitTools

2010-03-08 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add PlainTextController and TextInputController
https://bugs.webkit.org/show_bug.cgi?id=35852

Add PlainTextController and TextInputController classes, which are going
to be used by DumpRenderTree Chromium port. These files are based on:

  • src/webkit/tools/test_shell/plain_text_controller.{cc,h} and
  • src/webkit/tools/test_shell/text_input_controller.{cc,h} of Chromium rev.40492.
  • DumpRenderTree/chromium/PlainTextController.cpp: Added.
  • DumpRenderTree/chromium/PlainTextController.h: Added.
  • DumpRenderTree/chromium/TextInputController.cpp: Added.
  • DumpRenderTree/chromium/TextInputController.h: Added.
22:29 Changeset [55711] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed. Fix a wrong bug number.

22:24 Changeset [55710] by tkent@chromium.org
  • 7 edits
    3 adds in trunk

2010-03-08 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

Implement HTML5 <hgroup> element.
https://bugs.webkit.org/show_bug.cgi?id=32943

The new test file tests:

  • <p> closing,
  • Residual style, and
  • FormatBlock.
  • fast/html/hgroup-element-expected.txt: Added.
  • fast/html/hgroup-element.html: Added.
  • fast/html/script-tests/hgroup-element.js: Added.

2010-03-08 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

Implement HTML5 <hgroup> element.
https://bugs.webkit.org/show_bug.cgi?id=33369

<hgroup> should behave the same as <nav>, <section>, <article>, and <aside>.
<hgroup> has no specific parsing rules.

Test: fast/html/hgroup-element.html

  • css/html.css: Add hgroup as a block element.
  • editing/htmlediting.cpp: (WebCore::validBlockTag): Add hgroupTag.
  • html/HTMLElement.cpp: (WebCore::createTagPriorityMap): Returns 5 for hgroupTag. (WebCore::blockTagList): Add hgroupTag.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add hgroupTag.
  • html/HTMLTagNames.in: Add hgroup.
21:34 Changeset [55709] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, Chromium build fix.

Reverting r55689.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
21:15 Changeset [55708] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: 'P' is not a type. Luckily, 'void' is.

  • wtf/FastMalloc.cpp:

(WTF::fastCheckConsistency):

21:10 Changeset [55707] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: export a new symbol.

20:57 Changeset [55706] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

Switching malloc implementations requires a world rebuild
https://bugs.webkit.org/show_bug.cgi?id=35899

Reviewed by Maciej Stachowiak.

  • wtf/FastMalloc.cpp:

(WTF::fastCheckConsistency):
(WTF::TCMallocStats::fastCheckConsistency):

  • wtf/FastMalloc.h:
  • wtf/ValueCheck.h:

(WTF::): Moved pointer checking into a helper function in FastMalloc.cpp,
so you can switch malloc implementations without rebuilding the world.

20:32 Changeset [55705] by tony@chromium.org
  • 4 edits
    2 adds in trunk

2010-03-08 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=32131
Work around a crash when inserting an ordered list. This was caused
by incorrect logic when trying to restore a range from a location.
We compute the offset using TextIterator, but were sometimes using
VisiblePosition::next() to iterate instead.

  • editing/execCommand/insert-ordered-list-expected.txt: Added.
  • editing/execCommand/insert-ordered-list.html: Added.

2010-03-08 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=32131
Crash when inserting an ordered list.

Test: editing/execCommand/insert-ordered-list.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
20:21 Changeset [55704] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-08 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Adam Barth.

Fix webkit-patch post and land to work well with security bug
https://bugs.webkit.org/show_bug.cgi?id=35733

Bugzilla requires authentication to access security bug page,
so call authenticate() if it failed to fetch bug page.

  • Scripts/webkitpy/bugzilla.py:
17:47 Changeset [55703] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2010-03-08 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

Move the new method to the end of the MIG definitions file, to avoid breaking
compatibility between WebKit and older versions of WebKitPluginHost.

  • Plugins/Hosted/WebKitPluginHost.defs:
17:33 Changeset [55702] by simon.fraser@apple.com
  • 8 edits in trunk/WebKit/mac

2010-03-08 Simon Fraser <simon.fraser@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/7714340> Need to grab image snapshot of Core Animation plugins

Allow plug-ins using the Core Animation drawing model to be captured when doing a flattening paint,
by sending them a drawRect event as if they were software-painting.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::snapshot): New snapshot() method that calls over to the plugin host, and then draws the image that comes back.
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]): If we don't have a software renderer, but we're doing a flattening paint, then call the snapshot method.
  • Plugins/Hosted/WebKitPluginHost.defs: Added snapshot method.
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView inFlatteningPaint]): New utility method that asks the FrameView whether the current paint behavior is flattening.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView drawRect:]): If the plug-in is using CA but this is a flattening paint, go ahead and send a drawRect event to the plug-in.
17:14 Changeset [55701] by darin@apple.com
  • 3 edits
    1 add in trunk

WebCore: Added a test for crash when you quit inside an unload handler.
rdar://problem/6958347

Reviewed by Dan Bernstein.

  • manual-tests/quit-inside-unload.html: Added.

WebKit/mac: Fix crash when you quit inside an unload handler.
rdar://problem/6958347

Reviewed by Dan Bernstein.

Test: manual-tests/quit-inside-unload.html

  • WebView/WebView.mm:

(-[WebView _closeWithFastTeardown]): Removed code to set
_private->closed since _close now does this earlier, before
calling this method.
(-[WebView _close]): Moved code to set _private->closed to the
top of this method.
(-[WebView setHostWindow:]): Rewrote the code that forbade
setting the host window after closing so that it only forbids
non-nil host windows. That way, the code to clear away the host
window can run safely after setting _private->closed, yet client
code cannot set a new host window after closing.

17:08 Changeset [55700] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

Roll out a file I checked in by accident.

  • WebView/WebView.mm: Back to previous version.
17:06 Changeset [55699] by darin@apple.com
  • 4 edits
    2 adds in trunk

2010-03-08 Darin Adler <darin@apple.com>

Reviewed by Jon Honeycutt.

Don't auto-play <audio> and <video> elements loaded in background tabs
https://bugs.webkit.org/show_bug.cgi?id=35886
rdar://problem/7117745

  • manual-tests/video-in-non-frontmost-tab.html: Added.
  • manual-tests/resources/video-tab.html: Added.
  • html/HTMLMediaElement.h: Added MediaCanStartListener as a base class, and added the mediaCanStart function as well as a boolean, m_isWaitingUntilMediaCanStart.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_isWaitingUntilMediaCanStart. (WebCore::HTMLMediaElement::~HTMLMediaElement): Call removeMediaCanStartListener if m_isWaitingUntilMediaCanStart is true. (WebCore::HTMLMediaElement::loadInternal): Set m_isWaitingUntilMediaCanStart and call addMediaCanStartListener if canStartMedia is false. (WebCore::HTMLMediaElement::mediaCanStart): Clear m_isWaitingUntilMediaCanStart and call loadInternal.
17:00 Changeset [55698] by cmarrin@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac-leopard/Skipped

Fixed path in mac-leopard Skipped file. Was animation, now animations

16:56 Changeset [55697] by cmarrin@apple.com
  • 2 edits in trunk

This turns back on HW comp on Leopard (which I turned off in http://trac.webkit.org/changeset/55696) if you have WebGL turned on. I've added the failing tests to the Skipped file instead

16:39 Changeset [55696] by cmarrin@apple.com
  • 1 edit in trunk/WebKit/mac/WebView/WebView.mm

Backed out the half of http://trac.webkit.org/changeset/55690 that turned on HW accel for Leopard which was causing LayoutTests to fail

16:38 Changeset [55695] by ap@apple.com
  • 2 edits in trunk/WebKit/chromium

Chromium build fix.

Updated for the removal of "mightDownloadFromHandle".

16:35 Changeset [55694] by ossy@webkit.org
  • 2 edits in trunk/WebKit/gtk

[GTK] Unreviewed buildfix after r55688.

  • webkit/webkitdownload.cpp:

(webkit_download_start):

16:30 Changeset [55693] by ossy@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Unreviewed buildfix after r55688.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

16:26 Changeset [55692] by ossy@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Unreviewed buildfix after r55688.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::):

16:19 Changeset [55691] by ossy@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Unreviewed buildfix after r55688.

  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

16:11 Changeset [55690] by cmarrin@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac-leopard/Skipped

Added animation/fill-mode-transform.html to Skipped list for Leopard until https://bugs.webkit.org/show_bug.cgi?id=35714 is fixed

15:56 Changeset [55689] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitry Glazkov.

Fix --clobber-old-results in new-run-webkit-tests.

https://bugs.webkit.org/show_bug.cgi?id=35778

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15:52 Changeset [55688] by ap@apple.com
  • 8 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=35879
Eliminate m_mightDownloadFromHandle

It was only used on Mac, and unnecessarily complicated the code.

No change in behavior, thus no test.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):
15:44 Changeset [55687] by pkasting@chromium.org
  • 10 edits in trunk/WebCore

Clean up usage of m_failed in open-source image decoders, part 1.
https://bugs.webkit.org/show_bug.cgi?id=35411

Reviewed by Adam Barth.

Makes setFailed() virtual so subclasses can override it (none do yet) to
do automatic cleanup on failure; makes it return a bool for easy
tailcalling; makes failed() the only way to access m_failed so
subclasses are assured setFailed() won't be bypassed. Plus one or two
other tiny cleanup bits.

Overriding setFailed() is coming in a subsequent patch because it can be
hairy and needs close review.

No functional change, so no tests.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::internalDecodeSize):
(WebCore::ImageDecoderQt::internalReadImage):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
(WebCore::ImageDecoderQt::forceLoadEverything):
(WebCore::ImageDecoderQt::clearPointers):

  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::ImageDecoder):
(WebCore::ImageDecoder::setData):
(WebCore::ImageDecoder::setSize):
(WebCore::ImageDecoder::setFailed):
(WebCore::ImageDecoder::failed):

  • platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::isSizeAvailable):
(WebCore::BMPImageDecoder::frameBufferAtIndex):
(WebCore::BMPImageDecoder::processFileHeader):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::isSizeAvailable):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::processDirectory):
(WebCore::ICOImageDecoder::processDirectoryEntries):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::isSizeAvailable):
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
(WebCore::JPEGImageDecoder::outputScanlines):
(WebCore::JPEGImageDecoder::decode):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::decodingFailed):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::setData):
(WebCore::PNGImageDecoder::isSizeAvailable):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::decode):

  • platform/image-decoders/png/PNGImageDecoder.h:
15:14 Changeset [55686] by dglazkov@chromium.org
  • 7 edits
    2 adds in trunk

[Chromium] Reset multiple form submission protection on mouse events.
https://bugs.webkit.org/show_bug.cgi?id=35128

Reviewed by Darin Fisher.

WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::mouseDown):

LayoutTests:

  • fast/forms/multiple-form-submission-protection-mouse-expected.txt: Copied from LayoutTests/editing/execCommand/copy-without-selection-expected.txt.
  • fast/forms/multiple-form-submission-protection-mouse.html: Added.
14:54 Changeset [55685] by cmarrin@apple.com
  • 4 edits in trunk

When WebGL is enabled, enable hardware compositing bypassing check for CoreVideo bug fix
https://bugs.webkit.org/show_bug.cgi?id=35759

14:54 PythonGuidelines edited by cjerdonek@webkit.org
Added preliminary instructions on how to install new versions of Python on … (diff)
14:45 Changeset [55684] by oliver@apple.com
  • 6 edits in trunk/JavaScriptCore

2010-03-07 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

TypeInfo is unnecessarily large
https://bugs.webkit.org/show_bug.cgi?id=35850

Reduce the size of the type and flags members to a single
byte each, reducing the size of Structure by 8 bytes.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::branch8): (JSC::MacroAssemblerX86Common::branchTest8): (JSC::MacroAssemblerX86Common::setTest8): Add single byte branches, and correct setTest8 to do a single byte read from memory, and actually store the result
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::cmpb_im): (JSC::X86Assembler::testb_im):
  • jit/JITCall.cpp: (JSC::JIT::emit_op_construct_verify):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
  • runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::type):
14:38 Changeset [55683] by darin@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-03-08 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

Quick fix for a chromium unit test failures around r55675 (repaint refactoring).
This change restores the tests for empty rects that were deleted.

https://bugs.webkit.org/show_bug.cgi?id=35878

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::invalidateContentsAndWindow):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::invalidateContentsAndWindow):
14:16 Changeset [55682] by darin@apple.com
  • 5 edits in trunk/WebCore

2010-03-08 Darin Adler <darin@apple.com>

Reviewed by Jon Honeycutt.

https://bugs.webkit.org/show_bug.cgi?id=35876

Fix minor style issues in HTMLMediaElement and classes derived from it.
Made many public members private and protected.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::screenRect): Got rid of a stray "const" and retstructured the function to use early return and get rid of a local.
  • html/HTMLMediaElement.h: Made lots of members private and some protected. Also use private inheritance instead of public. Removed some unneeded includes.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): Use player() instead of m_player; HTMLMediaElement data members are now private, not protected. (WebCore::HTMLVideoElement::supportsFullscreen): Ditto. (WebCore::HTMLVideoElement::videoWidth): Ditto. (WebCore::HTMLVideoElement::videoHeight): Ditto. (WebCore::HTMLVideoElement::hasAvailableVideoFrame): Ditto. (WebCore::HTMLVideoElement::webkitEnterFullScreen): Use isFullscreen() instead of m_isFullscreen; same reason. (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto. (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.
  • html/HTMLVideoElement.h: Removed an unneeded include. Made many public functions private. Got rid of unused paint function, which was replaced with paintCurrentFrameInContext a while back.
14:07 Changeset [55681] by jam@chromium.org
  • 1 edit in trunk/WebKit/chromium/public/WebPluginContainer.h

take out temporary define

13:06 Changeset [55680] by eric@webkit.org
  • 10 edits in trunk

2010-03-08 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

  • platform/gtk/accessibility/table-hierarchy.html:
  • platform/gtk/accessibility/table-hierarchy-expected.txt:

2010-03-08 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

Gives platforms the ability to exclude parts of an AccessibilityTable
from the accessible hierarchy.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::determineAccessibilityRole):
  • accessibility/AccessibilityTable.cpp: (AccessibilityTable::addChildren):
  • accessibility/AccessibilityTableColumn.h: (accessibilityIsIgnored):
  • accessibility/AccessibilityTableHeaderContainer.h: (accessibilityIsIgnored):
  • accessibility/AccessibilityTableRow.cpp: (accessibilityIsIgnored):
12:31 Changeset [55679] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

Reverting 55035, this caused a regression.
(https://bugs.webkit.org/show_bug.cgi?id=35843)

Reviewed by NOBODY (reverting regression).

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::JSString::getStringPropertySlot):

  • runtime/UStringImpl.cpp:
  • runtime/UStringImpl.h:
12:22 Changeset [55678] by beidson@apple.com
  • 2 edits in trunk/WebKitTools

Followup to https://bugs.webkit.org/show_bug.cgi?id=35532

Reviewed by NOBODY (but suggested by Steve Falkenburg and fixing a boneheaded mistake on my part last week)

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::apiTestGoToCurrentBackForwardItem): Can't pass in a null BOOL to WebKit APIs.

12:21 Changeset [55677] by treat@webkit.org
  • 2 edits in trunk/WebKit/win

Unreviewed build fix for Windows.

Patch by Adam Treat <atreat@rim.com> on 2010-03-08

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::invalidateContents):

12:03 Changeset [55676] by jianli@chromium.org
  • 3 edits in trunk/WebCore

No review. Fix build break on Tiger intel release.

  • html/Blob.cpp:
  • html/Blob.h:
11:43 Changeset [55675] by treat@webkit.org
  • 33 edits in trunk

WebCore: Refactor the HostWindow methods for repaint, scroll, invalidate and blit
of backingstore and window by eliminating the three bools that currently
exist as params of the repaint method.
https://bugs.webkit.org/show_bug.cgi?id=34214

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

I've added extra methods to provide the hosts with more semantic
information of what is being requested thus eliminating the need for
these bools.

No tests as this change should not introduce any behavior changes in any
of the ports.

https://bugs.webkit.org/show_bug.cgi?id=34214

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::invalidateContents):
(WebCore::EmptyChromeClient::invalidateWindow):
(WebCore::EmptyChromeClient::invalidateContentsAndWindow):
(WebCore::EmptyChromeClient::invalidateContentsForSlowScroll):

  • page/Chrome.cpp:

(WebCore::Chrome::invalidateContents):
(WebCore::Chrome::invalidateWindow):
(WebCore::Chrome::invalidateContentsAndWindow):
(WebCore::Chrome::invalidateContentsForSlowScroll):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):

  • platform/HostWindow.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::wheelEvent):

WebKit/chromium: Adapt the chromium port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::invalidateContents):
(WebKit::ChromeClientImpl::invalidateWindow):
(WebKit::ChromeClientImpl::invalidateContentsAndWindow):
(WebKit::ChromeClient::invalidateContentsForSlowScroll):

  • src/ChromeClientImpl.h:

WebKit/gtk: Adapt the gtk port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/haiku: Adapt the haiku port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::invalidateContents):
(WebCore::ChromeClientHaiku::invalidateWindow):
(WebCore::ChromeClientHaiku::invalidateContentsAndWindow):
(WebCore::ChromeClient::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientHaiku.h:

WebKit/mac: Adapt the mac port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::invalidateContents):
(WebChromeClient::invalidateWindow):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::invalidateContentsForSlowScroll):

WebKit/qt: Adapt the qt port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::invalidateContents):
(WebCore::ChromeClientQt::invalidateWindow):
(WebCore::ChromeClientQt::invalidateContentsAndWindow):
(WebCore::ChromeClientQt::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientQt.h:

WebKit/win: Adapt the win port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::invalidateContents):
(WebChromeClient::invalidateWindow):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::invalidateContentsForSlowScroll):

  • WebCoreSupport/WebChromeClient.h:

WebKit/wx: Adapt the wx port to the refactoring of repaint methods.

Patch by Adam Treat <atreat@rim.com> on 2010-03-02
Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=34214

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::invalidateContents):
(WebCore::ChromeClientWx::invalidateWindow):
(WebCore::ChromeClientWx::invalidateContentsForSlowScroll):
(WebCore::ChromeClientWx::invalidateContentsAndWindow):

  • WebKitSupport/ChromeClientWx.h:
11:40 Changeset [55674] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-08 Adam Barth <abarth@webkit.org>

Reviewed by Nate Chapin.

[V8] Block popups from inline script
https://bugs.webkit.org/show_bug.cgi?id=35474

Test that we block popups generated from <script>window.open(...)</script>.

  • http/tests/security/popup-blocked-from-window-open-expected.txt: Added.
  • http/tests/security/popup-blocked-from-window-open.html: Added.

2010-03-08 Adam Barth <abarth@webkit.org>

Reviewed by Nate Chapin.

[V8] Block popups from inline script
https://bugs.webkit.org/show_bug.cgi?id=35474

Apparently, we're supposed to look at the sourceURL to figure out
whether we're running a script tag or a hyperlink. This logic is
copied from the JSC version.

Test: http/tests/security/popup-blocked-from-window-open.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::evaluate):
11:22 Changeset [55673] by eric@webkit.org
  • 10 edits
    2 adds in trunk

2010-03-08 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Adler.

Added a new USE definition for secure text mode on the Mac.
https://bugs.webkit.org/show_bug.cgi?id=31265

  • wtf/Platform.h:

2010-03-08 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Adler.

Move the details of secure text mode into WebCore/platform.
Move the higher-level logic for secure text mode from Frame
to SelectionController.

https://bugs.webkit.org/show_bug.cgi?id=31265

No new tests: no functional changes.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::setUseSecureKeyboardEntryWhenActive):
  • editing/SelectionController.cpp: (WebCore::SelectionController::focusedOrActiveStateChanged): (WebCore::SelectionController::updateSecureKeyboardEntryIfActive): (WebCore::SelectionController::setUseSecureKeyboardEntry):
  • editing/SelectionController.h:
  • page/Frame.cpp: (WebCore::Frame::setDocument):
  • page/Frame.h:
  • platform/SecureTextInput.cpp: Added. (WebCore::enableSecureTextInput): (WebCore::disableSecureTextInput):
  • platform/SecureTextInput.h: Added. (WebCore::enableSecureTextInput): (WebCore::disableSecureTextInput):
10:49 Changeset [55672] by beidson@apple.com
  • 6 edits
    4 adds in trunk

Relax the 3rd party cookie policy in cases where it won't add a new tracking vector.
<rdar://problem/7163012> and https://bugs.webkit.org/show_bug.cgi?id=35824

Reviewed by Anders Carlsson.

WebCore:

Test: http/tests/cookies/third-party-cookie-relaxing.html

If the 3rd-party domain in question already has a cookie set, allow changes
by setting the first party url of the request to be the url of the request itself:

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::makeFinalRequest):

Ditto:

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

I've filed <rdar://problem/7728508> to track changing the policy in our networking layer.

LayoutTests:

  • http/tests/cookies/resources/cookie-utility.php: Added.
  • http/tests/cookies/resources/third-party-cookie-relaxing-iframe.html: Added.
  • http/tests/cookies/third-party-cookie-relaxing-expected.txt: Added.
  • http/tests/cookies/third-party-cookie-relaxing.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
10:32 Changeset [55671] by cjerdonek@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Fixed incorrect import statement in validate-committer-lists:
webkitpy.BeautifulSoup -> webkitpy.thirdparty.BeautifulSoup.

  • Scripts/validate-committer-lists:
10:13 Changeset [55670] by jianli@chromium.org
  • 33 edits
    2 copies
    4 adds in trunk

.: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define.

  • configure.ac:

JavaScriptCore: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define.
Also fix a problem that JSValue.toInteger is not exposed on Windows.

  • Configurations/FeatureDefines.xcconfig:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

WebCore: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

The following semantic is adopted per the discussions on public-webapps:
1) File.slice() does a synchronous IO to capture the current size and

modification time and cache them in the resulting Blob.

2) Subsequent Blob operations, like Blob.slice and Blob.size simply

use the cached values.

3) When the underlying file data are accessed, like in XHR.send(), the

UA will check the cached modification time against the current
modification time to determine if the file has been changed or not.
An error or exception will be thrown if needed.

Also add ENABLE_BLOB_SLICE feature define.

Test: http/tests/local/send-sliced-dragged-file.html

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:
  • html/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::size):
(WebCore::Blob::slice):

  • html/Blob.h:

(WebCore::Blob::start):
(WebCore::Blob::length):
(WebCore::Blob::modificationTime):

  • html/Blob.idl:
  • platform/network/FormData.cpp:

(WebCore::FormData::deepCopy):
(WebCore::FormData::appendFile):
(WebCore::FormData::appendFileRange):

  • platform/network/FormData.h:

(WebCore::FormDataElement::FormDataElement):
(WebCore::operator==):

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::advanceCurrentStream):
(WebCore::openNextStream):
(WebCore::formCreate):
(WebCore::formOpen):
(WebCore::formRead):
(WebCore::setHTTPBody):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

WebKit/chromium: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define.

  • features.gypi:

WebKit/mac: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define.

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

WebKitTools: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add ENABLE_BLOB_SLICE feature define and flag for build-webkit. It is
currently only turned on for Mac.

  • Scripts/build-webkit:

LayoutTests: Blob.slice support.
https://bugs.webkit.org/show_bug.cgi?id=32993

Reviewed by Dmitry Titov.

Add a new layout test to test slicing and sending a file. In addition,
two new scripts are introduced to create and touch the temp file.

Move some code from send-dragged-file.js to a new file
setup-file-input-element-for-drag.js so that it can be used by both
send-dragged-file.js and send-sliced-dragged-file.js to setup the input
element for the file dragging.

Since the Blob.slice is only enabled for Mac, we disable the new test
for all other platforms.

  • fast/dom/Window/window-properties.html:
  • http/tests/local/resources/file-for-drag-to-send.txt:
  • http/tests/local/resources/send-dragged-file.js:
  • http/tests/local/resources/send-sliced-dragged-file.js: Added.
  • http/tests/local/resources/setup-file-input-element-for-drag.js: Added.
  • http/tests/local/send-dragged-file.html:
  • http/tests/local/send-sliced-dragged-file-expected.txt: Added.
  • http/tests/local/send-sliced-dragged-file.html: Added.
  • http/tests/resources/touch-temp-file.php: Added.
  • http/tests/resources/write-temp-file.php: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
09:54 Changeset [55669] by dbates@webkit.org
  • 4 edits
    4 adds in trunk

2010-03-08 Daniel Bates <dbates@rim.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=34819

Fixes an issue where we repaint the caret rectangle even if the associated
selection is not in a content editable element. This is extraneous since the
caret is only visible when the selection is in a content editable element.
Hence, we should only repaint the caret rectangle when the associated selection
is in a content editable element.

Note, we always paint the caret when caret browsing is enabled.

Test: fast/repaint/no-caret-repaint-in-non-content-editable-element.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::recomputeCaretRect): Modified to call method SelectionController::shouldRepaintCaret. (WebCore::SelectionController::shouldRepaintCaret): Added. (WebCore::SelectionController::invalidateCaretRect): Modified to call method SelectionController::shouldRepaintCaret.
  • editing/SelectionController.h:

2010-03-08 Daniel Bates <dbates@rim.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=34819

Tests that we do not repaint the caret rectangle when the associated selection is
not in a content editable element.

  • fast/repaint/no-caret-repaint-in-non-content-editable-element.html: Added.
  • platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
  • platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
  • platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
09:36 Changeset [55668] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2010-03-08 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

YouTube HTML5 video never starts playing on Windows
https://bugs.webkit.org/show_bug.cgi?id=33954

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::rfc2616DateStringFromTime): New, create an rfc 2616 formatted string for an absolute time value. (WebCore::addCookieParam): New, add a cookie param and value to a string builder. (WebCore::MediaPlayerPrivate::setUpCookiesForQuickTime): Copy cookies for the movie to

be loaded from CFNetwork into WinINet so they are available when QuickTime tries to
download the movie.

(WebCore::MediaPlayerPrivate::load): Call setupCookiesForQuickTime.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
09:26 Changeset [55667] by dbates@webkit.org
  • 2 edits in trunk/WebKit/win

2010-03-08 Daniel Bates <dbates@rim.com>

Unreviewed, build fix.

Attempt to fix the Windows builds by applying the corresponding change
made in bug #35763 <https://bugs.webkit.org/show_bug.cgi?id=35763>.

08:41 Changeset [55666] by eric@webkit.org
  • 14 edits in trunk

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

  • WebCore.base.exp:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

  • webkit/webkitwebview.cpp: Remove the calls into Settings. (DNDContentsRequest::webkit_web_view_update_settings): (DNDContentsRequest::webkit_web_view_settings_notify):

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

  • WebView/WebView.mm: Remove the call into Settings. (-[WebView _preferencesChangedNotification:]):

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): Remove the call into Settings.
07:57 Changeset [55665] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-08 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Binary incompatibility between Qt 4.6's WebKit and trunk in QWebSettings
https://bugs.webkit.org/show_bug.cgi?id=35858

Moved the enum value added in r54873 to the end of the enum, to preserve
binary compatibility. DnsPrefetchEnabled was in the last release and needs
to remain after LocalContentCanAccessRemoteUrls.

  • Api/qwebsettings.h:
07:41 Changeset [55664] by eric@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-03-08 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Holger Freyther.

[Qt] Added expected results and remove the test from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=35810

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.
  • platform/qt/fast/canvas/canvas-incremental-repaint-2-expected.txt: Added.
07:07 Changeset [55663] by kov@webkit.org
  • 4 edits in trunk

2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

No review, rolling out r55662.
http://trac.webkit.org/changeset/55662
https://bugs.webkit.org/show_bug.cgi?id=35863

Need to be coordinated with bots setup

  • http/conf/apache2-debian-httpd.conf:

2010-03-08 Gustavo Noronha Silva <gns@gnome.org>

No review, rolling out r55662.
http://trac.webkit.org/changeset/55662
https://bugs.webkit.org/show_bug.cgi?id=35863

Need to be coordinated with bots setup

  • Scripts/run-webkit-tests:
06:23 Changeset [55662] by kov@webkit.org
  • 4 edits in trunk

LayoutTests

2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] Tests fail when running with ipv6 addresses available, on Debian systems
https://bugs.webkit.org/show_bug.cgi?id=35863

Also listen for SSL requests on the ipv6 address.

  • http/conf/apache2-debian-httpd.conf:

WebKitTools

2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] Tests fail when running with ipv6 addresses available, on Debian systems
https://bugs.webkit.org/show_bug.cgi?id=35863

If running on a Debian-based system, also listen on the ipv6 address.

  • Scripts/run-webkit-tests:
06:08 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
05:21 Changeset [55661] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

[GTK] DRT needs to support synthesizing double clicks
https://bugs.webkit.org/show_bug.cgi?id=35862

Skip test that needs a new feature in DRT.

  • platform/gtk/Skipped:
05:16 Changeset [55660] by kov@webkit.org
  • 3 edits in trunk/LayoutTests

2010-03-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Rebaseline two tests that had their expected results
changed.

  • platform/gtk/inspector/timeline-network-resource-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
04:19 Changeset [55659] by jorlow@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-03-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Pass the WebFrame into WebStorageArea::setItem so we can figure out the routing ID
https://bugs.webkit.org/show_bug.cgi?id=35758

This is necessary since setItem is sometimes blocked and the embedder might need
to display some piece of UI associated with such an event.

  • public/WebStorageArea.h: (WebKit::WebStorageArea::setItem):
  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::setItem):
  • src/WebStorageAreaImpl.cpp: (WebKit::WebStorageAreaImpl::setItem):
  • src/WebStorageAreaImpl.h:
03:39 QtWebKitBugs edited by vestbo@webkit.org
(diff)
03:23 QtWebKitBugs edited by vestbo@webkit.org
(diff)
03:19 QtWebKitBugs edited by vestbo@webkit.org
(diff)
03:17 QtWebKitBugs edited by vestbo@webkit.org
(diff)
02:07 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
02:06 QtWebKitRelease20 created by hausmann@webkit.org
02:06 QtWebKit edited by hausmann@webkit.org
(diff)
02:04 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
01:57 QtWebKit edited by hausmann@webkit.org
(diff)
00:16 Changeset [55658] by zecke@webkit.org
  • 2 edits in trunk/WebKitTools

[iexploder] Automatically update htmltags.in and htmlattrs.in too

https://bugs.webkit.org/show_bug.cgi?id=33755

Change the update-iexploder-cssproperites script to update
the htmlattrs.in and htmltags.in of WebKitTools/iExploder/htdocs
automatically as well.

Change the reading and writing code to work with parameters
and extend the method that is parsing the .in files to handle
the HTMLTagNames.in and the HTMLAttributeNames.in files.

Remove custom code to determine the revision of files with a
utility of VCUtils.pm to determine the revision of the directory
these files are located in. This will also work with git checkout.

  • Scripts/update-iexploder-cssproperties:
00:13 Changeset [55657] by philn@webkit.org
  • 3 edits in trunk/WebCore

2010-03-04 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] replace g_idle_add / g_timeout_add calls with Timers in the gstreamer player
https://bugs.webkit.org/show_bug.cgi?id=35735

Replaced g_idle_add calls with Timers immediately started once
only. The g_timeout_add was replaced by a periodic Timer.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedTimerFired): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::muteChangedTimerFired): (WebCore::MediaPlayerPrivate::muteChanged):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

03/07/10:

22:55 Changeset [55656] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2010-03-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style: false positive for empty loop
https://bugs.webkit.org/show_bug.cgi?id=35717

  • Scripts/webkitpy/style/processors/cpp.py:
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
21:02 Changeset [55655] by tkent@chromium.org
  • 1 edit
    4 adds in trunk/WebKitTools

2010-03-07 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add AccessibilityController and AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=35774

Add AccessibilityController and AccessibilityUIElement classes,
which are going to be used by DumpRenderTree Chromium port. These
files are based on:

  • src/webkit/tools/test_shell/accessibility_controller.{cc,h} and
  • src/webkit/tools/test_shell/accessibility_ui_element.{cc,h} of Chromium rev.40492.
  • DumpRenderTree/chromium/AccessibilityController.cpp: Added.
  • DumpRenderTree/chromium/AccessibilityController.h: Added.
  • DumpRenderTree/chromium/AccessibilityUIElement.cpp: Added.
  • DumpRenderTree/chromium/AccessibilityUIElement.h: Added.
19:56 Changeset [55654] by levin@chromium.org
  • 2 edits in trunk/WebCore

Chromium Linux build fix.

  • platform/graphics/chromium/FontPlatformDataLinux.h: Add "class String" since a debug

only method returns a String.

19:06 Changeset [55653] by mrowe@apple.com
  • 4 edits in trunk

Chromium build fix.

WebCore:

  • platform/chromium/ClipboardChromium.cpp: Include Image.h since we're using WebCore::Image.

WebKit/chromium:

  • src/ChromiumBridge.cpp: Include SharedBuffer.h since WebCore::SharedBuffer is being used.
19:02 Changeset [55652] by mrowe@apple.com
  • 2 edits in trunk/WebKit/win

Windows build fix.

  • WebKitPrefix.h: Include CoreFoundation/CoreFoundation.h from the Windows prefix header

since some WebCore headers rely on the types declared within being available via the prefix
header.

18:57 Changeset [55651] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Gtk build fix.

  • platform/network/soup/ResourceHandleSoup.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
18:51 Changeset [55650] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Gtk build fix.

  • platform/graphics/gtk/ImageGtk.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
18:38 Changeset [55649] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix builds where USE_CG_SHADING is set.

  • platform/graphics/cg/GradientCG.cpp: Include wtf/RetainPtr.h since WTF::RetainPtr is used when USE_CG_SHADING is set.
18:33 Changeset [55648] by mrowe@apple.com
  • 4 edits in trunk/WebCore

Windows build fix. Add some required includes.

  • platform/graphics/win/ImageCGWin.cpp:
  • platform/network/cf/ResourceHandleCFNet.cpp:
  • platform/win/ClipboardWin.cpp:
18:29 Changeset [55647] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Gtk build fix.

  • platform/graphics/GraphicsContext.h: Include wtf/PassOwnPtr.h since some platforms use WTF::PassOwnPtr in this header.
18:27 Changeset [55646] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Qt build fix.

  • platform/network/qt/ResourceHandleQt.cpp: Include SharedBuffer.h since we're using WebCore::SharedBuffer.
18:23 Changeset [55645] by mrowe@apple.com
  • 2 edits in trunk/WebKit/chromium

Chromium build fix.

  • src/ResourceHandle.cpp: Include SharedBuffer.h since WebCore::SharedBuffer is being used.
18:18 Changeset [55644] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Gtk build fix.

  • platform/gtk/ClipboardGtk.cpp: Include Imageh since we're using WebCore::Image.
18:17 Changeset [55643] by mrowe@apple.com
  • 19 edits in trunk

Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.

Rubber-stamped by Cameron Zwarich.

WebCore:

  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedFont.cpp:
  • loader/CachedImage.cpp:
  • loader/CachedResource.cpp:
  • loader/CachedResource.h:
  • loader/CachedScript.cpp:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/icon/IconFetcher.cpp:
  • loader/loader.cpp:
  • page/Page.cpp:
  • platform/graphics/Image.cpp:
  • platform/graphics/Image.h:
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  • platform/graphics/cg/PDFDocumentImage.cpp:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/mac/ImageMac.mm:

WebKit/mac:

  • Misc/WebIconDatabase.mm:
18:05 Changeset [55642] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Chromium build fix.

  • platform/chromium/ChromiumDataObject.h: Include SharedBuffer.h since the inline constructor of this

class means that the pointed-to type of the RefPtr member must be available.

18:05 Changeset [55641] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Qt build fix.

  • platform/network/qt/DnsPrefetchHelper.cpp: Include PlatformString.h since we're using WebCore::String.
17:53 Changeset [55640] by tkent@chromium.org
  • 3 edits
    3 adds
    2 deletes in trunk

2010-03-07 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Fix a bug that validity.valueMissing for a radio button with required
in a form element always returns true.
https://bugs.webkit.org/show_bug.cgi?id=35472

Add tests for radio buttons in a form element, and merge an existing
radio button test to ValidityState-valueMissing-radio.html.

  • fast/forms/ValidityState-valueMissing-007-expected.txt: Removed.
  • fast/forms/ValidityState-valueMissing-007.html: Removed.
  • fast/forms/ValidityState-valueMissing-radio-expected.txt: Added.
  • fast/forms/ValidityState-valueMissing-radio.html: Added.
  • fast/forms/script-tests/ValidityState-valueMissing-radio.js: Added.

2010-03-07 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Fix a bug that validity.valueMissing for a radio button with required
in a form element always returns true.
https://bugs.webkit.org/show_bug.cgi?id=35472

Test: fast/forms/ValidityState-valueMissing-radio.html

  • html/HTMLInputElement.cpp: (WebCore::checkedRadioButtons): Move the location to be used by valueMissing(). (WebCore::HTMLInputElement::valueMissing): Use checkedRadioButtons() instead of document()->checkedRadioButtons().
17:52 Changeset [55639] by mrowe@apple.com
  • 12 edits in trunk

Remove unnecessary includes from header files, adding them to the handful of implementation files that need them.

Rubber-stamped by Cameron Zwarich.

WebCore:

  • bindings/objc/DOM.mm:
  • loader/CachedImage.h:
  • loader/EmptyClients.h:
  • platform/graphics/GlyphPageTreeNode.cpp:
  • platform/text/CString.h:
  • platform/text/String.cpp:
  • platform/text/mac/TextCodecMac.cpp:
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/filters/SVGFEImage.h:

WebKit/mac:

  • Misc/WebNSPasteboardExtras.mm:
17:52 Changeset [55638] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Completely remove two files that were deleted in r55635 from the Xcode project.

  • WebCore.xcodeproj/project.pbxproj:
17:26 Changeset [55637] by weinig@apple.com
  • 7 edits in trunk

Remove inconsistent "Too few arguments" handling for window.atob() and window.btoa()
https://bugs.webkit.org/show_bug.cgi?id=35848

Reviewed by Dan Bernstein.

WebCore:

  • Take the opportunity to fully autogenerate window.atob() and window.btoa().
  • bindings/js/JSDOMWindowCustom.cpp:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::btoa):
(WebCore::DOMWindow::atob):

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/Window/atob-btoa-expected.txt:
  • fast/dom/Window/atob-btoa.html:
17:02 PythonGuidelines edited by cjerdonek@webkit.org
Minor updates. Added a FIXME to include upgrade instructions. (diff)
10:15 Changeset [55636] by mitz@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/7722008> Column breaking ignores floats
https://bugs.webkit.org/show_bug.cgi?id=35837

Reviewed by Simon Fraser.

WebCore:

Test: fast/multicol/float-truncation.html

Introduce an earlier column-break if otherwise a float that could fit
inside a single column will be split between columns.

It is still possible for floats to be needlessly broken if initially
they fit in the column, but normal flow truncation then shortens the
column.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::visibleTopOfHighestFloatExtendingBelow): Added.
Returns the visible top of the highest descendant float that visibly
extends below the given y offset, ignoring floats that are taller than
the given maximum height.
(WebCore::RenderBlock::layoutColumns): If the initial column height
would cause a float to be split, truncate above the float.

  • rendering/RenderBlock.h:

LayoutTests:

  • fast/multicol/float-truncation-expected.txt: Added.
  • fast/multicol/float-truncation.html: Added.
08:59 Changeset [55635] by dimich@chromium.org
  • 24 edits
    9 deletes in trunk

Not reviewed. Revert of r55593 which caused a regression of worker-cloneports.html.

REGRESSION(55593?): fast/workers/worker-cloneport.html is timing out on Leopard
https://bugs.webkit.org/show_bug.cgi?id=35819

WebCore:

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDatabaseCallback.cpp: Removed.
  • bindings/js/JSDatabaseCallback.h: Removed.
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
  • bindings/v8/custom/V8DatabaseCallback.h: Removed.
  • dom/Document.cpp:

(WebCore::Document::postTask):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):

  • storage/Database.h:
  • storage/DatabaseCallback.h: Removed.
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):

  • workers/WorkerContext.h:

LayoutTests:

  • fast/frames/resources/sandboxed-iframe-storage-allowed.html:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-storage-expected.txt:
  • storage/open-database-creation-callback-expected.txt: Removed.
  • storage/open-database-creation-callback-isolated-world-expected.txt: Removed.
  • storage/open-database-creation-callback-isolated-world.html: Removed.
  • storage/open-database-creation-callback.html: Removed.
  • platform/qt/Skipped:
  • platform/mac-leopard/Skipped: Enable the temporarily disabled test back.
00:16 Changeset [55634] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-07 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Small performance fix in the QScriptConverter::toString().

The QByteArray was replaced by the QVarLengthArray which doesn't
have to allocate any memory on heap.

[Qt] QScriptConverter::toString() should use QVarLengthArray instead of QByteArray
https://bugs.webkit.org/show_bug.cgi?id=35577

  • qt/api/qscriptconverter_p.h: (QScriptConverter::toString):
Note: See TracTimeline for information about the timeline view.