Timeline


and

03/13/10:

16:23 Changeset [55972] by cjerdonek@webkit.org

The webkit-patch script now displays a warning if run using
a version of Python less than 2.5. This will help users
understand why webkit-patch is erroring out if they are
using Python 2.4, for example.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31533

  • Scripts/webkit-patch:
    • Moved most of the file contents to webkitpy/patch/patcher.py so the Python version can be checked before interpreting any code that can cause the script to error out.
    • Added a configure_logging() method to enable any version warnings to show up.
    • Added a main() method with calls to configure_logging(), check_version(), and the main webkit patch method.
  • Scripts/webkitpy/patch/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
    • This file is required to make a folder a package.
  • Scripts/webkitpy/patch/patcher.py: Added.
    • Moved code from Scripts/webkit-patch.
15:48 Changeset [55971] by cjerdonek@webkit.org

Changed test-webkitpy so that messages logged as a side-effect
of unit-testing code do not get displayed to the screen. These
messages clutter up the unit test results if not filtered out.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35835

  • Scripts/test-webkitpy:
    • Adjusted the configure_logging() method to filter out any log messages from webkitpy.
    • Also added an INFO message stating that most console logging is getting suppressed.
  • Scripts/webkitpy/init/versioning.py:
    • Added a log parameter to the check_version() method.
  • Scripts/webkitpy/init/versioning_unittest.py:
    • Qualified a call to check_version() with the parameter names.
14:36 Changeset [55970] by cjerdonek@webkit.org

The test-webkitpy script now warns the user if the script is
being run using a Python version different from the minimum
version the webkitpy package was meant to support.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35788

Warning developers if their Python version is too low will help
them understand why test-webkitpy is failing. Secondly, warning
developers if their Python version is higher than the minimum will
help them understand that their changes may not be okay for the
minimum supported version, even if test-webkitpy is passing.

  • Scripts/test-webkitpy:
    • Moved the "from ..._unittest import *" lines to the new file Scripts/webkitpy/unittests.py. This will allow the version-check warning to be displayed even if an error occurs while interpreting (i.e. importing) the unit test code.
    • Added configure_logging() to configur logging for test-webkitpy.
    • Added an init() method to configure logging and check the current Python version.
  • Scripts/webkitpy/init/unittests.py: Added.
    • Added a file to import all unit test modules in the webkitpy.init package.
  • Scripts/webkitpy/init/versioning.py: Added.
    • Added a _MINIMUM_SUPPORTED_PYTHON_VERSION variable and set it equal to 2.5.
    • Added a compare_version() method to compare the current Python version against a target version.
    • Added a check_version() method to check the current Python version against the current minimum supported version, and to log a warning message if the check fails.
  • Scripts/webkitpy/init/versioning_unittest.py: Added.
    • Added unit tests for the functions in versioning.py.
  • Scripts/webkitpy/style/unittests.py:
    • Fixed/updated a code comment.
  • Scripts/webkitpy/unittests.py: Added.
    • Moved the "from ..._unittest import *" lines from test-webkitpy.
14:10 Changeset [55969] by cjerdonek@webkit.org

Moved all code in webkitpy/init.py to another location.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35828

Keeping webkitpy/init.py free of non-trivial code allows
calling code to import initialization code from webkitpy
before any errors or log messages occur due to code in
init.py. Such initialization code can include things like
version checking code and logging configuration code. This
also lets us move the autoinstall initialization code to a
location where it only executes if it is needed -- something
we have done in this patch.

  • Scripts/webkitpy/init.py:
    • Moved all executable code to the following location: webkitpy/thirdparty/autoinstalled/init.py
    • Added a code comment to keep this file free of non-trivial code.
  • Scripts/webkitpy/bugzilla.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/networktransaction.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/networktransaction_unittest.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/statusserver.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/thirdparty/autoinstalled/init.py: Added.
    • Copied the code from webkitpy/init.py and updated it as necessary.
13:28 Changeset [55968] by cjerdonek@webkit.org

Moved webkitpy/mock.py into webkitpy/thirdparty since it is
third-party code.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35499

Updated the import statement in all of the below except where noted.

  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/commands/commandtest.py:
  • Scripts/webkitpy/commands/download_unittest.py:
  • Scripts/webkitpy/commands/early_warning_system_unittest.py:
  • Scripts/webkitpy/commands/queries_unittest.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/queuestest.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/commands_references.py: Added.
    • Added a file containing an absolute import of Mock so that the imports in the commands folder can import from this file (similar to style_references.py). This helps limit the number of affected files in future refactorings.
  • Scripts/webkitpy/credentials_unittest.py:
  • Scripts/webkitpy/mock.py: Removed.
    • Moved to Scripts/webkitpy/thirdparty.
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/patchcollection_unittest.py:
  • Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/steps/steps_unittest.py:
  • Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
  • Scripts/webkitpy/steps_references.py: Added.
    • Added a file containing an absolute import of Mock so that the imports in the steps folder can import from this file (similar to style_references.py). This helps limit the number of affected files in future refactorings.
  • Scripts/webkitpy/thirdparty/mock.py: Copied from WebKitTools/Scripts/webkitpy/mock.py.
    • Also eliminated trailing white space and carriage returns.
11:28 Changeset [55967] by eric@webkit.org

2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC
https://bugs.webkit.org/show_bug.cgi?id=36034

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::OpacityAnimationQt::applyFrame):
10:54 Changeset [55966] by eric@webkit.org

2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: Opacity transitions end with begin value
https://bugs.webkit.org/show_bug.cgi?id=36019

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQt::updateCurrentTime):
10:35 Changeset [55965] by eric@webkit.org

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35925

  • efl/ewk/ewk_history.cpp: Added.
  • efl/ewk/ewk_history.h: Added.
10:17 Changeset [55964] by eric@webkit.org

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35928

  • efl/ewk/ewk_main.cpp: Added.
  • efl/ewk/ewk_main.h: Added.
10:12 Changeset [55963] by ossy@webkit.org

[Qt] Enable accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=35866

Unreviewed. Roll-out r55955, because it broke 3 tests:

  • animations/fill-mode-transform.html
  • animations/play-state.html
  • animations/simultaneous-start-left.html
  • Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

07:25 QtWebKitJournal edited by hausmann@webkit.org
(diff)
05:43 Changeset [55962] by krit@webkit.org

2010-03-13 Dirk Schulze <krit@webkit.org>

No review, rolling out r55927.
http://trac.webkit.org/changeset/55927
https://bugs.webkit.org/show_bug.cgi?id=35793

Breaks Gtk build bots.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::setPreload):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
02:59 Changeset [55961] by robert@webkit.org

2010-03-12 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

Amend incorrect typo patch for QtLauncher.

https://bugs.webkit.org/show_bug.cgi?id=35877

  • QtLauncher/webview.cpp: (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
02:44 Changeset [55960] by eric@webkit.org

2010-03-13 Victor Wang <victorw@chromium.org>

Add appengine app to host and serve webkit layout test results.

The app allows you post test result files (json) and serve them up.
Chromium flakiness dashboard will first use this app to host results.json
and expectations.json, but the files hosted by this app are not limited
to chromium results or json files. It can be used to host other files if needed.

https://bugs.webkit.org/show_bug.cgi?id=35944

  • TestResultServer: Added.
  • TestResultServer/app.yaml: Added.
  • TestResultServer/handlers: Added.
  • TestResultServer/handlers/init.py: Added.
  • TestResultServer/handlers/menu.py: Added.
  • TestResultServer/handlers/testfilehandler.py: Added.
  • TestResultServer/index.yaml: Added.
  • TestResultServer/main.py: Added.
  • TestResultServer/model: Added.
  • TestResultServer/model/init.py: Added.
  • TestResultServer/model/testfile.py: Added.
  • TestResultServer/stylesheets: Added.
  • TestResultServer/stylesheets/form.css: Added.
  • TestResultServer/stylesheets/menu.css: Added.
  • TestResultServer/stylesheets/testfile.css: Added.
  • TestResultServer/templates: Added.
  • TestResultServer/templates/menu.html: Added.
  • TestResultServer/templates/showfilelist.html: Added.
  • TestResultServer/templates/uploadform.html: Added.
02:28 Changeset [55959] by eric@webkit.org

2010-03-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Levin.

new-run-webkit-tests fails with --debug option.
https://bugs.webkit.org/show_bug.cgi?id=36067

  • Scripts/webkitpy/layout_tests/port/mac.py:
02:11 Changeset [55958] by eric@webkit.org

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35924

  • efl/ewk/ewk_frame.cpp: Added.
  • efl/ewk/ewk_frame.h: Added.
01:54 Changeset [55957] by eric@webkit.org

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35936

  • efl/ewk/ewk_view_single.c: Added.
01:38 Changeset [55956] by eric@webkit.org

2010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add "Show FPS" menu option to QtLauncher.

[Qt] QtLauncher need a menu option to show/hide FPS
https://bugs.webkit.org/show_bug.cgi?id=35794

  • QtLauncher/main.cpp: (LauncherWindow::showFPS): (LauncherWindow::createChrome):
01:21 Changeset [55955] by eric@webkit.org

2010-03-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=35866

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
01:04 Changeset [55954] by eric@webkit.org

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35929

  • efl/ewk/ewk_util.cpp: Added.
  • efl/ewk/ewk_util.h: Added.
00:47 Changeset [55953] by eric@webkit.org

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35934

  • efl/ewk/EWebKit.h: Added.
  • efl/ewk/ewk_eapi.h: Added.
  • efl/ewk/ewk_logging.h: Added.
  • efl/ewk/ewk_private.h: Added.
00:31 Changeset [55952] by eric@webkit.org

2010-03-13 Eric Roman <eroman@chromium.org>

Reviewed by Adam Barth.

Add a firstPartyForCookies() property to WebDocument.
https://bugs.webkit.org/show_bug.cgi?id=35592

  • public/WebDocument.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::firstPartyForCookies):
00:14 Changeset [55951] by eric@webkit.org

2010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add a "Toggle FullScreen" option to QtLauncher Menu.

[Qt] QtLauncher needs an option to toggle FullScreen Mode
https://bugs.webkit.org/show_bug.cgi?id=35755

  • QtLauncher/main.cpp: (LauncherWindow::init): (LauncherWindow::eventFilter): (LauncherWindow::initializeView): (LauncherWindow::toggleFullScreenMode): (LauncherWindow::createChrome):

03/12/10:

23:57 Changeset [55950] by eric@webkit.org

2010-03-12 Shu Chang <chang.shu@nokia.com>

Reviewed by David Levin.

[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=36057

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-size-change-after-layout-expected.png: Added.
  • platform/qt/fast/canvas/canvas-size-change-after-layout-expected.txt:
23:07 Changeset [55949] by krit@webkit.org

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyphs - transform path not context
https://bugs.webkit.org/show_bug.cgi?id=36070

SVGFont should transform the path of a glyph, not the context. Modifying
the context causes wrong gradient transformations. This bug doesn't
influence CG because we generally fill or stroke texts with a mask image.
All other platforms provide a direct way to make the drawings.

  • svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyphs - transform path not context
https://bugs.webkit.org/show_bug.cgi?id=36070

Some tests don't look pixel perfect after the SVGFont changes (difference of 0.1%).
They just need an update.
Tests for the changes on other platforms than CG are

  • svg/batik/text/textEffect.svg
  • svg/batik/text/textEffect3.svg
  • svg/W3C-SVG-1.1/pservers-grad-08-b.svg
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/text/selection-doubleclick-expected.png:
  • platform/mac/svg/text/selection-tripleclick-expected.png:
18:10 Changeset [55948] by barraclough@apple.com

Reviewed by NOBODY (build fix).

17:56 Changeset [55947] by enrica@apple.com

Fixed broken build on Windows.
Added contditional compilation for accelerated compositing.

  • WebView.cpp:

(WebView::deleteBackingStore):
(WebView::addToDirtyRegion):
(WebView::updateBackingStore):

17:39 Changeset [55946] by bdakin@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
API naming is inconsistent
-and corresponding-
<rdar://problem/7729165>

Reviewed by Simon Fraser.

WebCore:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen." webkitEnterFullScreen and
webkitExitFullScreen have been maintained for now for backwards
compatibility.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitEnterFullscreen):
(WebCore::HTMLVideoElement::webkitExitFullscreen):

  • html/HTMLVideoElement.h:

(WebCore::HTMLVideoElement::webkitEnterFullScreen):
(WebCore::HTMLVideoElement::webkitExitFullScreen):

  • html/HTMLVideoElement.idl:
  • platform/graphics/mac/MediaPlayerProxy.h:

WebKit/mac:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."

  • Plugins/Hosted/NetscapePluginHostProxy.h:

(WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::didEnterFullscreen):
(WebKit::NetscapePluginHostProxy::didExitFullscreen):
(WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
(WKPCSetFullscreenWindowIsShowing):

  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
(-[WebNetscapePluginView _createPlugin]):
(-[WebNetscapePluginView _destroyPlugin]):

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController windowDidLoad]):

WebKit/win:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."

  • FullscreenVideoController.cpp:

(FullscreenVideoController::onMouseDown):
(FullscreenVideoController::onMouseMove):
(FullscreenVideoController::onMouseUp):

  • FullscreenVideoController.h:

(FullscreenVideoController::fullscreenToHUDCoordinates):

17:02 Changeset [55945] by jamesr@google.com

2010-03-12 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

Add virtual destructor to DOMWrapperWorld
https://bugs.webkit.org/show_bug.cgi?id=36077

DOMWrapperWorld is RefCounted<DOMWrapperWorld>. IsolatedWorld
inherits from DOMWrapperWorld and has member variables
with destructors, so DOMWrapperWorld needs to have a declared virtual
d'tor to ensure that its derived class's destructors are called.

No new tests, no change in behavior

  • bindings/v8/DOMWrapperWorld.h: (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
16:46 Changeset [55944] by barraclough@apple.com

Reviewed by NOBODY (build fix).

15:49 Changeset [55943] by barraclough@apple.com

Bug 36075 - Clean up screwyness re static string impls & Identifiers.

Reviewed by Oliver Hunt.

JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass): Classname may be null/empty, and these are an identifer. This is okay, since the null/empty strings are shared across all threads.

(JSC::Identifier::add): No need to explicitly hash null reps, this is done in the ststic UStringImpl constructor.
(JSC::Identifier::addSlowCase): UStringImpl::empty() handled & checkCurrentIdentifierTable now called in the header.
(JSC::Identifier::checkCurrentIdentifierTable): Replaces checkSameIdentifierTable (this no longer checked the rep since the identifierTable pointer was removed from UString::Rep long ago).

  • runtime/Identifier.h:

(JSC::Identifier::add): Replace call to checkSameIdentifierTable with call to checkCurrentIdentifierTable at head of function.

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::~UStringImpl): Remove call to checkConsistency - this function no longer checks anything interesting.

  • runtime/UStringImpl.h:

(JSC::UStringOrRopeImpl::UStringOrRopeImpl): Set s_refCountFlagIsIdentifier in static constructor.
(JSC::UStringImpl::UStringImpl): remove calls to checkConsistency (see above), add new ASSERT to substring constructor.
(JSC::UStringImpl::setHash): ASSERT not static (static strings set the hash in their constructor, should not reach this code path).
(JSC::UStringImpl::create): Add missing ASSERT.
(JSC::UStringImpl::setIsIdentifier): ASSERT !isStatic() (static strings hash set in constructor).

WebCore:

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl): Add ASSERT
(WebCore::StringImpl::sharedBuffer): Add ASSERT

  • platform/text/StringImpl.h:

(WebCore::StringImpl::setHash): Add ASSERT
(WebCore::StringImpl::isStatic): added.

15:17 Changeset [55942] by bdakin@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
video HUD stays on top when switching to another window (e.g. via
Alt-Tab)
-and corresponding-
<rdar://problem/7547574>

Reviewed by Adam Roben.

The HUD was always on top because it had the WS_EX_TOPMOST style.
So I removed the style and made m_videoWindow the owner of
m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
is the focused window.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
(FullscreenVideoController::createHUDWindow):

15:11 Changeset [55941] by enrica@apple.com

Content of 3D tests appears at the bottom right corner sometimes.
<rdar://problem/7556244>
<https://bugs.webkit.org/show_bug.cgi?id=36027>

Reviewed by Simon Fraser.

WebCore:

There were two problems to solve here:

  • the incorrect anchoring of the rootChildLayer that was causing the composited content to be positioned incorrectly
  • the failure to paint the non composited content into the backing store when animating composited content.


The first problem has been solved by leaving the original anchor point for the
rootChildLayer and splitting the tasks of clipping and scrolling using two separate layers.
The second problem has been solved leveraging the knowledge that WebView has of the dirty region
of the backing store to pass this information to the layer renderer. This allows the renderer to force
a paint into the backing store before moving to the compositing.

Tests: compositing/geometry/horizontal-scroll-composited.html

compositing/geometry/vertical-scroll-composited.html

  • manual-tests/win/horizontal-scroll-composited.html: Removed. This is now a layout test.
  • manual-tests/win/milliondollar.html: Added.
  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Added initialization of dirty flag.
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::updateScrollFrame): Updated to resize and position the clip and scroll layers.
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
(WebCore::WKCACFLayerRenderer::createRenderer): Added new layer hierarchy.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Remove clip layer on destroy.
(WebCore::WKCACFLayerRenderer::resize):
(WebCore::WKCACFLayerRenderer::paint): Forcing paint massage to trigger paint into the backing store.

  • platform/graphics/win/WKCACFLayerRenderer.h:

(WebCore::WKCACFLayerRenderer::setBackingStoreDirty): Added.

WebKit/win:

See detailed comments in WebCore/ChangeLog.

  • WebView.cpp:

(WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
(WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
backing store dirty region.
(WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
(WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
(WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
We are passing width and height of the view content together with the offset for the scrolling.
It was confusing to pass it all as a rectangle, when it is not a rectangle.

LayoutTests:

  • compositing/geometry/horizontal-scroll-composited.html: Added.
  • compositing/geometry/vertical-scroll-composited.html: Added.
  • compositing/resources/apple.jpg: Added.
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
  • platform/mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
  • platform/mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/mac/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
14:58 Changeset [55940] by dpranke@chromium.org

2010-03-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Fix typo in websocket_server (path_from_base instead of
path_from_chromium_base).

https://bugs.webkit.org/show_bug.cgi?id=36074

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
14:49 Changeset [55939] by robert@webkit.org

2010-03-12 Robert Hogan <robert@webkit.org>

Not reviewed, build fix.

Revert http://trac.webkit.org/projects/webkit/changeset/55374 which broke
the !ENABLE(DATABASE) build on all platforms when attempting to fix the
--minimal build on Qt.

Support for SQLite now seems to be non-negotiable for the Qt build but making
it mandatory requires review, so re-break --minimal Qt build for now.

Qt build issue now tracked at https://bugs.webkit.org/show_bug.cgi?id=36073

  • page/GeolocationPositionCache.cpp:
14:43 Changeset [55938] by dpranke@chromium.org

2010-03-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests --new-baseline doesn't work at all.

It attempts to call a method that isn't defined. To fix it, I
removed the unnecessary and unnecessarily confusing 'platform'
argument to the test_type constructor and use the Port object that
is passed in instead, since we are only ever generating a baseline
from the port that is currently executing.

https://bugs.webkit.org/show_bug.cgi?id=36046

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
14:42 Changeset [55937] by dpranke@chromium.org

2010-03-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Fix new-run-webkit-tests --run-singly

This script option is currently broken - the script attempts to
dereference methods and variables that don't exist, which causes
the Chromium Linux valgrind bot to be quite unhappy. This has been
broken since r54449 when I renamed Port.start_test_driver to
Port.start_driver.

https://bugs.webkit.org/show_bug.cgi?id=36042

  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
14:31 Changeset [55936] by krit@webkit.org

2010-03-12 Dirk Schulze <krit@webkit.org>

Unreviewed LayoutTest update.

Result was not updated with r55930.

  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
13:23 Changeset [55935] by mitz@apple.com

<rdar://problem/7709115> REGRESSION: toolbar is missing at http://www.glom.org/
https://bugs.webkit.org/show_bug.cgi?id=35507

Reviewed by Alexey Proskuryakov.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::setCSSStyleSheet): Extend the change made in
<http://trac.webkit.org/changeset/48818> to detect the two variants of
KHTMLFixes.css in @import rules as well as in <link> elements.

13:16 Changeset [55934] by barraclough@apple.com

Bug 36052 - [Qt] REGRESSION(55878) 63 test cases crash

Reviewed by Geoff Garen.

r55878 changed UStringImpl::empty()->characters() to be non-null,
so TextBreakIteratorQt.cpp now should check the length of strings
(previously was assuming all strings with a non-null data pointer
had a length of at least 1).

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::wordBreakIterator):
(WebCore::characterBreakIterator):
(WebCore::lineBreakIterator):
(WebCore::sentenceBreakIterator):

13:15 Changeset [55933] by abarth@webkit.org

2010-03-12 Garret Kelly <gdk@chromium.org>

Unreiviewed.

Fix Chromium Mac build. Last patch did not apply properly.
(Garret assures me this patch will actually work.)

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
12:48 Changeset [55932] by abarth@webkit.org

2010-03-12 Garret Kelly <gdk@chromium.org>

Unreviewed.

Fix Chromium Mac build. This time, with actual fixing goodness.

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
12:47 Changeset [55931] by beidson@apple.com

Expose WebPDFView's underlying PDFDocument.

Patch by Andy Estes <aestes@apple.com> on 2010-03-12
Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=36045

  • WebView/WebDocumentPrivate.h: Create a new protocol called

WebDocumentPDF.

  • WebView/WebPDFView.h: Have WebPDFView implement said protocol.
  • WebView/WebPDFView.mm:

(-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
PDFDocument by implementing -(PDFDocument*)PDFDocument from
WebDocumentPDF.

12:43 Changeset [55930] by krit@webkit.org

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG fallback color doesn't work for bogus gradients.
https://bugs.webkit.org/show_bug.cgi?id=35479

Use a given fallback color on ignored gradients if present. Gradients
must be ignored, if one dimension of the objects boundingBox is zero.

Test: svg/custom/gradient-with-1d-boundingbox.svg

  • svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::strokePaintServer):
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG fallback color doesn't work for bogus gradients.
https://bugs.webkit.org/show_bug.cgi?id=35479

We now use a fallback color on ignored gradients for one dimensional objects,
either a given fallback color or black as default.
This causes a change of one LayoutTest, because it was done manually in the
gradient PaintServer, without respecting a given fallback color.

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
  • svg/custom/gradient-with-1d-boundingbox.svg: Added.
12:36 Changeset [55929] by abarth@webkit.org

2010-03-12 Garret Kelly <gdk@chromium.org>

Unreviewed.

Fix Chromium Mac build.

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
12:29 Changeset [55928] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=36069

Reviewed by Dan Bernstein.

Eliminate InlineRunBox.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::prevLineBox):
(WebCore::InlineFlowBox::nextLineBox):
(WebCore::InlineFlowBox::setNextLineBox):
(WebCore::InlineFlowBox::setPreviousLineBox):

  • rendering/InlineRunBox.h: Removed.
  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::InlineTextBox):
(WebCore::InlineTextBox::prevTextBox):
(WebCore::InlineTextBox::nextTextBox):
(WebCore::InlineTextBox::setNextTextBox):
(WebCore::InlineTextBox::setPreviousTextBox):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::destroy):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::localBoundingBox):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::deleteLineBoxTree):
(WebCore::RenderLineBoxList::extractLineBox):
(WebCore::RenderLineBoxList::attachLineBox):
(WebCore::RenderLineBoxList::removeLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxes):
(WebCore::RenderLineBoxList::dirtyLineBoxes):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
(WebCore::RenderLineBoxList::checkConsistency):

  • rendering/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::absoluteRects):
(WebCore::RenderSVGInline::absoluteQuads):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::absoluteRects):
(WebCore::RenderSVGText::absoluteQuads):
(WebCore::RenderSVGText::objectBoundingBox):

  • rendering/RenderText.cpp:

(WebCore::RenderText::extractTextBox):
(WebCore::RenderText::attachTextBox):
(WebCore::RenderText::removeTextBox):
(WebCore::RenderText::createInlineTextBox):
(WebCore::RenderText::positionLineBox):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):

12:11 Changeset [55927] by kov@webkit.org

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

media/video-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=35793

Only effectively load, and start buffering when playing, or when
the preload attribute is set.

Test: media/video-preload.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::commitLoad): (WebCore::MediaPlayerPrivate::prepareToPlay): (WebCore::MediaPlayerPrivate::setPreload):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
12:06 Changeset [55926] by dimich@chromium.org

Not reviewed, build fix.

Reverts 55920 and 55921. Landing for Jian Li.

WebCore:

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMFormDataCustom.cpp: Removed.
  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8DOMFormDataCustom.cpp: Removed.
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

  • html/DOMFormData.idl: Removed.
  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/resources/send-form-data.js: Removed.
  • http/tests/local/send-form-data-expected.txt: Removed.
  • http/tests/local/send-form-data.html: Removed.
  • http/tests/xmlhttprequest/resources/multipart-post-echo.php: Removed.
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/Skipped:
12:03 Changeset [55925] by kov@webkit.org

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Fix critical being printed to stderr on every test. This is
because the jar is only being created when soup hits the HTTP
path. We should reconsider the time of its creation.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
11:57 Changeset [55924] by tonikitoo@webkit.org

Make the timeout in 'snav-unit-overflow-and-scroll-in-direction.html' 10x shorter (from 500ms to 50ms)

Rubber-stamped by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

  • fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
11:45 Changeset [55923] by jpetsovits@rim.com

2010-03-12 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Add support for drawing text to PainterOpenVG
https://bugs.webkit.org/show_bug.cgi?id=35581

Doesn't come with any actual font classes, as OpenVG
by itself doesn't provide any access to platform fonts
but just the means to draw glyphs that have been loaded
manually before.

  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::copyPaintState): (WebCore::PainterOpenVG::textDrawingMode): (WebCore::PainterOpenVG::setTextDrawingMode): (WebCore::PainterOpenVG::drawText):
  • platform/graphics/openvg/PainterOpenVG.h:
11:25 Changeset [55922] by jpetsovits@rim.com

2010-03-12 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Use masks to implement non-rectilinear clipping
https://bugs.webkit.org/show_bug.cgi?id=35544

Requires some additional context switching logic to
make sure the right context is current when dealing
with the mask, because we don't store it by ourselves.

Initial version of this code was written by
Eli Fidler <efidler@rim.com>, I did a couple of
bug fixes and efficiency improvements since then.

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::addInnerRoundedRectClip):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::~PlatformPainterState): (WebCore::PlatformPainterState::maskingEnabled): (WebCore::PlatformPainterState::applyState): (WebCore::PlatformPainterState::saveMaskIfNecessary): (WebCore::PainterOpenVG::intersectClipRect): (WebCore::PainterOpenVG::clipPath): (WebCore::PainterOpenVG::save):
  • platform/graphics/openvg/PainterOpenVG.h: (WebCore::PainterOpenVG::):
  • platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::makeCurrent): (WebCore::SurfaceOpenVG::makeCompatibleCurrent):
  • platform/graphics/openvg/SurfaceOpenVG.h: (WebCore::SurfaceOpenVG::):
11:17 Changeset [55921] by jianli@chromium.org

[v8] Add V8 bindings for DOMFormData.
https://bugs.webkit.org/show_bug.cgi?id=36026

Reviewed by Nate Chapin.

Test: http/tests/local/send-form-data.html

  • WebCore.gypi:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.

(WebCore::V8DOMFormData::appendCallback):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

11:17 Changeset [55920] by jianli@chromium.org

WebCore: Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata

Test: http/tests/local/send-form-data.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMFormDataCustom.cpp: Added.
  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/DOMFormData.idl: Added.
  • page/DOMWindow.idl:

LayoutTests: Add DOMFormData.idl to expose FormData interface
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

Add a layout test to test sending FormData via XMLHttpRequest. Also
changed all test results that are affected by exposing FormData.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/resources/send-form-data.js: Added.
  • http/tests/local/send-form-data-expected.txt: Added.
  • http/tests/local/send-form-data.html: Added.
  • http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/Skipped:
11:11 Changeset [55919] by jpetsovits@rim.com

2010-03-12 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Add a SurfaceOpenVG constructor for EGL client buffer surfaces
https://bugs.webkit.org/show_bug.cgi?id=35538

SurfaceOpenVG can now not only encapsulate pbuffer
and window surfaces but also VGImage-based ones.

  • platform/graphics/openvg/EGLDisplayOpenVG.cpp: (WebCore::EGLDisplayOpenVG::createPbufferFromClientBuffer):
  • platform/graphics/openvg/EGLDisplayOpenVG.h:
  • platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::SurfaceOpenVG):
  • platform/graphics/openvg/SurfaceOpenVG.h:
11:06 Changeset [55918] by aroben@apple.com

Teach prepare-ChangeLog to find modified selectors in CSS files

Reviewed by Tim Hatcher.

Fixes <http://webkit.org/b/36064> prepare-ChangeLog should extract
modified selectors from CSS files

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges): Call get_selector_line_ranges_for_css for
.css files.
(get_selector_line_ranges_for_css): Added. Finds selectors and their
line ranges and returns them.

11:03 Changeset [55917] by eric@webkit.org

2010-03-12 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

HTMLMediaElement crash when it is used after resource loading is canceled.
https://bugs.webkit.org/show_bug.cgi?id=35992

Adding a test to access the duration property of a video element after
resource loading was canceled.

  • http/tests/media/video-cancel-load-expected.txt: Added.
  • http/tests/media/video-cancel-load.html: Added.

2010-03-12 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Fix a crash when resource loading of media element is canceled.
https://bugs.webkit.org/show_bug.cgi?id=35992

Use of HTMLMediaElement::duration() after resource loading was canceled
will cause a crash. This is because HTMLMediaElement::m_player is used
when NULL.
Test: http/tests/media/video-cancel-load.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::duration): Avoid calling to m_player when it is null. (WebCore::HTMLMediaElement::userCancelledLoad): Set m_readyState to HAVE_NOTHING.
10:45 Changeset [55916] by eric@webkit.org

2010-03-12 Garret Kelly <gdk@chromium.org>

Reviewed by Eric Seidel.

Enable touch events in Chromium features gypi file.
https://bugs.webkit.org/show_bug.cgi?id=35994

  • features.gypi:
10:36 Changeset [55915] by kov@webkit.org

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Kenneth Rohde Christiansen.

Misc documentation fixes. Fixes (almost) all warnings emitted by
the documentation build process. Only the broken references to JSC
objects remain.

  • webkit/webkitsecurityorigin.cpp:
  • webkit/webkitwebbackforwardlist.cpp:
  • webkit/webkitwebdatasource.cpp:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebhistoryitem.cpp:
  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_class_init):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
  • webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
10:28 Changeset [55914] by mitz@apple.com

<rdar://problem/7725534> CSSPrimitiveValue::parserValue() returns deleted memory
https://bugs.webkit.org/show_bug.cgi?id=20069

Reviewed by Darin Adler.

No test added, since with the CSS variables feature disabled, the pointer
to the freed memory is never dereferenced.

  • css/CSSPrimitiveValue.cpp:

(WebCore::valueOrPropertyName): Changed to return a const AtomicString& from
a static table.
(WebCore::CSSPrimitiveValue::parserValue): Updated for the above change.

10:18 Changeset [55913] by ojan@chromium.org

2010-03-05 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

Tests for smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314

Fixes the tests to make selections using the mouse in order
to force smart-delete. It also adds/modifies tests to have them correctly
identify cases where we are smart-deleting, but shouldn't be.

Fixing to smart-delete only on mouse-based selections will be a followup patch.

  • editing/deleting/5390681-2.html:
  • editing/deleting/non-smart-delete.html: Added.
  • editing/deleting/smart-delete-001.html:
  • editing/deleting/smart-delete-002.html:
  • editing/deleting/smart-delete-003.html:
  • editing/deleting/smart-delete-004.html:
  • editing/editing.js: (doubleClick): (doubleClickAtSelectionStart):
  • editing/pasteboard/4944770-2.html:
  • editing/pasteboard/drag-drop-modifies-page.html:
  • editing/pasteboard/smart-drag-drop.html: Added.
  • editing/pasteboard/smart-paste-001.html:
  • editing/pasteboard/smart-paste-002.html:
  • editing/pasteboard/smart-paste-003.html:
  • editing/pasteboard/smart-paste-004.html:
  • editing/pasteboard/smart-paste-005.html:
  • editing/pasteboard/smart-paste-007.html:
  • editing/pasteboard/smart-paste-008.html:
  • editing/selection/delete-word-granularity-text-control-expected.txt: Added.
  • editing/selection/delete-word-granularity-text-control.html: Added.
  • editing/selection/script-tests/delete-word-granularity-text-control.js: Added.
  • editing/style/style-boundary-005.html:
  • platform/mac/editing/deleting/non-smart-delete-expected.checksum: Added.
  • platform/mac/editing/deleting/non-smart-delete-expected.png: Added.
  • platform/mac/editing/deleting/non-smart-delete-expected.txt: Added.
  • platform/mac/editing/deleting/smart-delete-001-expected.txt:
  • platform/mac/editing/deleting/smart-delete-002-expected.txt:
  • platform/mac/editing/deleting/smart-delete-003-expected.txt:
  • platform/mac/editing/deleting/smart-delete-004-expected.txt:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.checksum:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/mac/editing/pasteboard/smart-drag-drop-expected.checksum: Added.
  • platform/mac/editing/pasteboard/smart-drag-drop-expected.png: Added.
  • platform/mac/editing/pasteboard/smart-drag-drop-expected.txt: Added.
  • platform/mac/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/mac/editing/style/style-boundary-005-expected.checksum:
  • platform/mac/editing/style/style-boundary-005-expected.png:
  • platform/mac/editing/style/style-boundary-005-expected.txt:
10:14 Changeset [55912] by darin@chromium.org

2010-03-12 Darin Fisher <darin@chromium.org>

Fix Chromium build bustage.

Wrap usage of WebPrivatePtr from WebNode.h in a #if
WEBKIT_IMPLEMENTATION guard.

  • public/WebNode.h:
10:03 Changeset [55911] by mitz@apple.com

Build fix.

  • platform/chromium/PlatformKeyboardEventChromium.cpp:
09:54 Changeset [55910] by ap@apple.com

Fixing an embarrassing typo in ChangeLog.

09:06 Changeset [55909] by mitz@apple.com

<rdar://problem/7694674> Hover states not updated when overflow section scrolls under stationary mouse pointer
https://bugs.webkit.org/show_bug.cgi?id=35949

Reviewed by Darin Adler.

WebCore:

Test: fast/events/overflow-scroll-fake-mouse-move.html

Soon after an overflow section scrolls under the mouse pointer, dispatch
a fake mouse move event. This is similar to how frame scrolling is handled
in WebKit, and has the effect of updating hover state, dispatching DOM mouse
events, and updating the tool tip.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Initialize m_fakeMouseMoveEventTimer.
(WebCore::EventHandler::~EventHandler): Assert that the timer is not active.
(WebCore::EventHandler::clear): Stop the timer.
(WebCore::EventHandler::handleMousePressEvent): Cancel pending fake mouse
move events.
(WebCore::EventHandler::handleMouseMoveEvent): Ditto.
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad): If the mouse
is in the passed-in quad, ensure that a fake mouse move event is scheduled
to fire soon.
(WebCore::EventHandler::cancelFakeMouseMoveEvent): Does what the name says.
(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Constructs a
PlatformMouseEvent with the current mouse location, modifier key state and
time stamp and calls mouseMoved().

  • page/EventHandler.h:
  • platform/PlatformKeyboardEvent.h: Declared getCurrentModifierState().
  • platform/android/KeyEventAndroid.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

  • platform/brew/PlatformKeyboardEventBrew.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • platform/chromium/PlatformKeyboardEventChromium.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

  • platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

  • platform/gtk/KeyEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • platform/haiku/PlatformKeyboardEventHaiku.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

  • platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • platform/qt/PlatformKeyboardEventQt.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

  • platform/win/KeyEventWin.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

  • platform/wx/KeyboardEventWx.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset): Call
EventHandler::dispatchFakeMouseMoveEventSoonInQuad(). Moved things around
a little to avoid computing the repaint rect twice.

LayoutTests:

  • fast/events/overflow-scroll-fake-mouse-move-expected.txt: Added.
  • fast/events/overflow-scroll-fake-mouse-move.html: Added.
  • fast/events/touch/basic-multi-touch-events.html:
  • fast/events/touch/basic-single-touch-events.html:
09:03 Changeset [55908] by eric@webkit.org

2010-03-12 Nicolas Weber <thakis@chromium.org>

Reviewed by David Levin.

[Chromium] Cmd-clicking submit buttons should submit in new tab
https://bugs.webkit.org/show_bug.cgi?id=36023

Take modifiers into account when clicking form buttons. E.g.
cmd-clicking a submit button will submit in a new background tab,
cmd-shift-clicking in a new foreground tab, shift-clicking in a new
window. (On windows/linux, it's ctrl instead of cmd.)

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):
08:56 Changeset [55907] by ossy@webkit.org

2010-03-12 Csaba Osztrogonác <ossy@webkit.org>

[Qt] css1/box_properties/acid_test.html failed in release mode (32 bit).
But it passes in debug mode (32 and 64 bit) and in release mode (64 bit).

https://bugs.webkit.org/show_bug.cgi?id=33834

  • platform/qt/Skipped: css1/box_properties/acid_test.html skipped again.
08:36 Changeset [55906] by eric@webkit.org

2010-03-12 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix memory leak in WebImageDecoder API
https://bugs.webkit.org/show_bug.cgi?id=35946

  • src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::setData): (WebKit::WebImageDecoder::getFrameAtIndex):
08:15 Changeset [55905] by kov@webkit.org

Build fix (for EWS). Make sure the new code builds on older soup.

Thanks to Dan Winship.

08:05 Changeset [55904] by kov@webkit.org

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

[GTK] DRT does not handle cookie policy setting
https://bugs.webkit.org/show_bug.cgi?id=36056

Implement cookie accept policy setting for GTK+'s LayoutTestController.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies):

LayoutTests

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

[GTK] DRT does not handle cookie policy setting
https://bugs.webkit.org/show_bug.cgi?id=36056

Fix tests to request that the cookie acceptance policy always allows cookies.

  • http/tests/media/video-cookie.html:
  • http/tests/media/video-referer.html:
08:02 Changeset [55903] by eric@webkit.org

2010-03-12 Adam Langley <agl@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium]: update Linux layout test scripts for RedHat like systems.

(Tested on Fedora 12.)

https://bugs.webkit.org/show_bug.cgi?id=35867

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
07:53 Changeset [55902] by ossy@webkit.org

[Qt] Now css1/box_properties/acid_test.html passes, so we can unskip it.
original bug: https://bugs.webkit.org/show_bug.cgi?id=33834

  • platform/qt/Skipped: css1/box_properties/acid_test.html unskipped.
07:45 Changeset [55901] by eric@webkit.org

2010-03-12 Andy Estes <aestes@apple.com>

Reviewed by Brady Eidson.

Remove an unused method.

https://bugs.webkit.org/show_bug.cgi?id=35940

  • Plugins/WebPluginController.mm: removed - (void)showURL:(NSURL *) inFrame:(NSString *)
07:28 Changeset [55900] by eric@webkit.org

2010-03-12 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by David Levin.

Two functions tryConsumeCharacter() and tryConsumeCharacterClass() are
removed from yarr/RegexInterpreter.cpp because they are never called.

  • yarr/RegexInterpreter.cpp:
07:16 Changeset [55899] by ossy@webkit.org

[Qt] DRT failing on test introduced in r55499
https://bugs.webkit.org/show_bug.cgi?id=35729

Now fast/events/zoom-dblclick.html passes, so we can unskip it.

  • platform/qt/Skipped: fast/events/zoom-dblclick.html unskipped.
07:12 Changeset [55898] by aroben@apple.com

Make svn-create-patch's diffs of ObjC header files more readable

Fixes <http://webkit.org/b/36055>.

Reviewed by John Sullivan.

  • Scripts/svn-create-patch:

(diffOptionsForFile): Added. Returns the options that should be passed
to diff for the given file. All the options are the same for all
files, except for the option to specify which lines should be used as
hunk headers.
(generateDiff): Use diffOptionsForFile to get the options to pass to
diff.
(hunkHeaderLineRegExForFile): Added. Returns the regular expression
that should be used by diff to identify lines that should be included
after the "@@" in the hunk header lines of the diff. For ObjC[++]
source files, we use any lines starting with -, +, or
@implementation/@interface/@protocol. For ObjC[++] header files (which
we assume to be any .h files in a mac/ or objc/ directory), we use any
lines starting with @implementation/@interface/@protocol.

07:10 Changeset [55897] by eric@webkit.org

2010-03-12 Scott Byer <scottbyer@chromium.org>

Reviewed by David Levin.

Popup font size needs to be exposed to clients.
https://bugs.webkit.org/show_bug.cgi?id=35990

Add function to expose the popup menu font size, add a field to
WebPopupMenuInfo that receives that information to convey that to
the web view client's createPopupMenu() call.

  • WebCore/platform/chromium/PopupMenuChromium.cpp:
  • WebCore/platform/chromium/PopupMenuChromium.h:
  • WebKit/chromium/public/WebPopupMenuInfo.h:
  • WebKit/chromium/src/ChromeClientImpl.cpp:
06:53 Changeset [55896] by eric@webkit.org

2010-03-12 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Webkit doesn't build with workers on and database off
https://bugs.webkit.org/show_bug.cgi?id=35997

Added missing ENABLE(DATABASE) guards.

  • workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownStartTask::performTask):
06:25 Changeset [55895] by kov@webkit.org

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

[GTK] Fails fast/dom/Geolocation/maximum-age.htm
https://bugs.webkit.org/show_bug.cgi?id=36053

Skip new failing test.

  • platform/gtk/Skipped:
06:25 Changeset [55894] by kov@webkit.org

2010-03-12 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha.

Make the defaultCookieJar use a no-third-party policy. Most
applications set their own cookie jar, but DumpRenderTree doesn't,
so it was failing the new third-party-cookie test.

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar):

LayoutTests

2010-03-12 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha.

Revert previous; the test passes now.

  • platform/gtk/Skipped:
06:06 Changeset [55893] by eric@webkit.org

2010-03-12 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Test for referrer information being stripped when the header is removed in willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=35920

  • http/tests/security/no-referrer-expected.txt: Added.
  • http/tests/security/no-referrer.html: Added.
  • http/tests/security/resources/no-referrer-frame.php: Added.
  • http/tests/security/resources/no-referrer.php: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-03-12 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Introduce setWillSendRequestClearHeader to LayoutTestController to selectively remove headers in willSendRequest. Used in http/tests/security/no-referrer.html
https://bugs.webkit.org/show_bug.cgi?id=35920

  • DumpRenderTree/LayoutTestController.cpp: (setWillSendRequestClearHeaderCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::willSendRequestClearHeaders): (LayoutTestController::setWillSendRequestClearHeader):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest):
05:44 Changeset [55892] by zimmermann@webkit.org

2010-03-12 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Update two tests, whose pixel hash fail with --tolerance 0. No visible differences.

  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.checksum:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.png:

03/11/10:

23:24 Changeset [55891] by eric@webkit.org

2010-03-11 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable network state notifier when compiling against Qt 4.7
https://bugs.webkit.org/show_bug.cgi?id=35983

  • WebCore.pri:
  • platform/network/qt/NetworkStateNotifierPrivate.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:
23:07 Changeset [55890] by eric@webkit.org

2010-03-11 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Adam Treat.

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

The frame view take into acount the list of fixed object when scrolling
the view. If the number of object is lower than a certain threshold, the pixel
are blitted, and the invalidated area updated.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject): (WebCore::FrameView::scrollContentsFastPath):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
  • platform/ScrollView.h:
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
22:46 Changeset [55889] by eric@webkit.org

2010-03-11 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888

Use TARGETING_TIGER rather than BUILDING_ON_TIGER to determine the tags.

  • wtf/VMTags.h:
22:11 Changeset [55888] by eric@webkit.org

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission):
  • notifications/NotificationPresenter.h:

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

  • public/WebNotificationPresenter.h:
  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
  • src/NotificationPresenterImpl.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::applicationID):

2010-03-11 Aaron Boodman <aa@chromium.org>

Kill WebDocument::applicationID() (part 1).

Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
21:41 Changeset [55887] by eric@webkit.org

2010-03-11 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

The JSNative state was renamed to JSPrimitive. The new name better
coresponds to the ECMAScript standard.

Enum QScriptValuePrivate::States was renamed to State to obey Qt
coding style rules ("States" name suggests that a state could
mixed together with an other state using bitwise logic operators.

[Qt] QScriptValuePrivate::States has naming issues
https://bugs.webkit.org/show_bug.cgi?id=35968

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isBool): (QScriptValuePrivate::isNumber): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isString): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::refinedJSValue):
21:24 Changeset [55886] by eric@webkit.org

2010-03-11 Shu Chang <Chang.Shu@nokia.com>

Reviewed by David Levin.

[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=35969

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-resize-reset-expected.txt:
20:39 Changeset [55885] by barraclough@apple.com

Add export.

Reviewed by NOBODY (Windows build fix).

20:36 Changeset [55884] by ukai@chromium.org

2010-03-11 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Fix typo in websocket_server.py

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
20:07 Changeset [55883] by barraclough@apple.com

Add export.

Reviewed by NOBODY (Windows build fix).

19:51 Changeset [55882] by dimich@chromium.org

[v8] Remove obsolete code for delayed dereferencing of DOM objects for single-heap, multithread v8 usage.
https://bugs.webkit.org/show_bug.cgi?id=36043

Reviewed by David Levin.

No new tests, no changes in functionality.

  • bindings/v8/DOMData.cpp:

(WebCore::DOMData::DOMData):

  • bindings/v8/DOMData.h:

(WebCore::DOMData::handleWeakObject):

  • bindings/v8/DOMDataStore.cpp:
  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::domObjectMap):
(WebCore::DOMDataStore::activeDomObjectMap):
(WebCore::DOMDataStore::domSvgElementInstanceMap):
(WebCore::DOMDataStore::domSvgObjectWithContextMap):

  • bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp:

(WebCore::removeAllDOMObjectsInCurrentThread):

19:25 Changeset [55881] by barraclough@apple.com

Rubber stamped by Oliver Hunt.

Remove nonsense comments used in development & commited in error.

JavaScriptCore:

  • runtime/UStringImpl.h:

WebCore:

  • platform/text/StringImpl.h:
19:22 Changeset [55880] by eric@webkit.org

2010-03-11 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Adler.

Fixing minor typo in the commit queue status page.
https://bugs.webkit.org/show_bug.cgi?id=35979

  • Scripts/webkitpy/commands/queues.py:
19:20 Changeset [55879] by barraclough@apple.com

Remove export.

Reviewed by NOBODY (Windows build fix).

19:14 Changeset [55878] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=36041
Remove unnecessary differences in common code between WebCore::StringImpl & JSC::UStringImpl

Reviewed by Oliver Hunt.

Much of the code in WebCore::StringImpl and JSC::UStringImpl is now very similar,
but has trivial and unnecessary formatting differences, such as the exact wording
of comments, missing ASSERTs, functions implemented in the .h vs .cpp etc.

JavaScriptCore:

  • runtime/Identifier.cpp:

(JSC::Identifier::add): UStringImpl::empty() now automatically hashes, uas per WebCore strings.
(JSC::Identifier::addSlowCase): UStringImpl::empty() now automatically hashes, uas per WebCore strings.

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::~UStringImpl): Only call bufferOwnership() once, add missing ASSERTs.
(JSC::UStringImpl::createUninitialized): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::create): Move from .h, not commonly called, no need to inline.
(JSC::UStringImpl::sharedBuffer): Rewritten to more closely match WebCore implementation, remove need for separate baseSharedBuffer() method.

  • runtime/UStringImpl.h:

(JSC::UStringImpl::UStringImpl): Automatically hash static strings, ASSERT m_data & m_length are non-null/non-zero in non-static strings.
(JSC::UStringImpl::setHash): Add missing ASSERT.
(JSC::UStringImpl::create): Moved to .cpp / added missing check for empty string creation.
(JSC::UStringImpl::adopt): Vector.size() returns size_t, not unsigned.
(JSC::UStringImpl::cost): Renamed m_bufferSubstring -> m_substringBuffer
(JSC::UStringImpl::hash): Reordered in file.
(JSC::UStringImpl::existingHash): Reordered in file.
(JSC::UStringImpl::computeHash): Reordered in file, renamed parameter.
(JSC::UStringImpl::checkConsistency): rewrote ASSERT.
(JSC::UStringImpl::bufferOwnership): Return type should be BufferOwnership.
(JSC::UStringImpl::): Moved friends to head of class.

WebCore:

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::empty): Reordered in file, made empty()->characters() return a non-null value to match JSC.
(WebCore::StringImpl::createUninitialized): Added overflow check.
(WebCore::StringImpl::create): Reordered in file.
(WebCore::StringImpl::sharedBuffer): Reordered in file.

  • platform/text/StringImpl.h:

(WebCore::StringImpl::): Remove ThreadGlobalData as friend, move SharableUChar & SharedUChar to WebCore namespace.
(WebCore::StringImpl::StringImpl): Made static constructor method (used to create empty string) take arguments, to match JSC & prevent accidental use.
(WebCore::StringImpl::setHash): Added missing ASSERT.
(WebCore::StringImpl::adopt): Make adpot work with Vectors with a non-zero inline capacity.
(WebCore::StringImpl::characters): Mark as const to match JSC.
(WebCore::StringImpl::hash): Use !m_hash instead of m_hash == 0.
(WebCore::StringImpl::computeHash): Remove redundant 'inline'.

19:04 Changeset [55877] by eric@webkit.org

2010-03-11 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Fix the screen coordinate conversion of Chromium Mac mouse events for
multiple-moniter setups. Also changes the global coordinate values
to be computed from the event, rather than the instantaneous mouse
location, and reduces code duplication for location conversion.

Dual-sided patch with http://codereview.chromium.org/751002

https://bugs.webkit.org/show_bug.cgi?id=35950

  • src/mac/WebInputEventFactory.mm: (WebKit::setWebEventLocationFromEventInView): (WebKit::WebInputEventFactory::mouseEvent): (WebKit::WebInputEventFactory::mouseWheelEvent):
18:47 Changeset [55876] by eric@webkit.org

2010-03-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Applying h1 format to text node after HR tag fails to include first letter of text node.
https://bugs.webkit.org/show_bug.cgi?id=30148

This patch adds a test case to the above bug, which has been fixed by
http://trac.webkit.org/changeset/55705.

  • editing/style/heading-text-after-hr-expected.txt: Added.
  • editing/style/heading-text-after-hr.html: Added.
18:37 Changeset [55875] by ukai@chromium.org

2010-03-11 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Fix for WebSocket layout test runner on chromium/win port.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: register_cygwin and set CYGWIN_PATH
18:20 Changeset [55874] by eric@webkit.org

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35917

  • efl/WebCoreSupport/InspectorClientEfl.h: Added.
  • efl/WebCoreSupport/InspectorClientEfl.cpp: Added.
18:15 Changeset [55873] by jianli@chromium.org

Add more test cases for Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=36038

Reviewed by Dmitry Titov.

  • http/tests/local/resources/abe.png: Copied from LayoutTests/editing/resources/abe.png.
  • http/tests/local/resources/empty.txt: Copied from LayoutTests/http/tests/appcache/resources/empty.txt.
  • http/tests/local/resources/send-sliced-dragged-file.js:
  • http/tests/local/send-sliced-dragged-file-expected.txt:
  • http/tests/resources/post-and-verify.cgi: Added.
  • http/tests/resources/write-temp-file.php:
18:03 Changeset [55872] by eric@webkit.org

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35914

  • efl/WebCoreSupport/DragClientEfl.h: Added.
  • efl/WebCoreSupport/DragClientEfl.cpp: Added.
17:53 Changeset [55871] by mrowe@apple.com

<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version

Reviewed by David Kilzer.

Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.

JavaScriptCore:

  • Configurations/Base.xcconfig:

JavaScriptGlue:

  • Configurations/Base.xcconfig:

WebCore:

  • Configurations/Base.xcconfig:

WebKit/mac:

  • Configurations/Base.xcconfig:

WebKitTools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
17:37 Changeset [55870] by eric@webkit.org

2010-03-11 Jungshik Shin <jshin@chromium.org>

[Chromium]: Plane 2 characters are rendered "blank"

(not even empty boxes) on Windows even when there are fonts to
cover them.

https://bugs.webkit.org/show_bug.cgi?id=35605

Test:LayoutTests/fast/text/international/plane2.html

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::LookupAltName): Add two ExtB fonts to the array (namePairs) that are used for Plane 2 character rendering. (WebCore::FontCache::getFontDataForCharacters): Add two more fonts to the fallback font list
  • platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::getFallbackFamily): Fix the fallback font lookup to cover Plane 2 (CJK ExtB).
17:20 Changeset [55869] by eric@webkit.org

2010-03-11 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to platform/efl.
http://webkit.org/b/35889

  • platform/efl/SystemTimeEfl.cpp: Added.
16:50 Changeset [55868] by victorw@chromium.org

2010-03-11 Victor Wang <victorw@chromium.org>

Reviewed by dglazkov@chromium.org.

rebaseline_chromium_webkit_tests can generate new baselines for
all platforms so it needs to know two ports in order to work correctly:
the port that the script is running on and the port that it generates
new baselines for. Update rebaselining tool to handle both port correctly.

https://bugs.webkit.org/show_bug.cgi?id=36032

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
16:44 Changeset [55867] by mrowe@apple.com

<rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version

Reviewed by Tim Hatcher.

Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted. It defaults to the
current Mac OS X version unless otherwise specified.

Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.

Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
may not be usable when targetting a different Mac OS X version.

Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.

JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/Version.xcconfig:

JavaScriptGlue:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebCore.xcconfig:

WebKit/mac:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:

WebKitTools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • DumpRenderTree/mac/DumpRenderTree.mm: Wrap the include of mach-o/getsect.h in 'extern "C"' as some versions of the

header in older SDKs do not do this inside the header.

16:40 Changeset [55866] by darin@chromium.org

2010-03-10 Darin Fisher <darin@chromium.org>

Reviewed by Jeremy Orlow.

Use WebPrivatePtr for WebNode
https://bugs.webkit.org/show_bug.cgi?id=36005

  • public/WebElement.h:
  • public/WebFormElement.h:
  • public/WebInputElement.h:
  • public/WebLabelElement.h:
  • public/WebNode.h: (WebKit::WebNode::WebNode): (WebKit::WebNode::isNull): (WebKit::WebNode::unwrap): (WebKit::WebNode::constUnwrap):
  • public/WebPrivatePtr.h: (WebKit::WebPrivatePtr::assign):
  • src/WebDocument.cpp: (WebKit::WebDocument::WebDocument): (WebKit::WebDocument::operator=): (WebKit::WebDocument::operator PassRefPtr<Document>):
  • src/WebElement.cpp: (WebKit::WebElement::hasTagName): (WebKit::WebElement::WebElement): (WebKit::WebElement::operator=): (WebKit::WebElement::operator PassRefPtr<Element>):
  • src/WebFormElement.cpp: (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::operator PassRefPtr<HTMLFormElement>):
  • src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::operator PassRefPtr<HTMLInputElement>):
  • src/WebLabelElement.cpp: (WebKit::WebLabelElement::correspondingControl): (WebKit::WebLabelElement::operator=): (WebKit::WebLabelElement::operator PassRefPtr<HTMLLabelElement>):
  • src/WebNode.cpp: (WebKit::WebNode::reset): (WebKit::WebNode::assign): (WebKit::WebNode::equals): (WebKit::WebNode::parentNode): (WebKit::WebNode::createMarkup): (WebKit::WebNode::addEventListener): (WebKit::WebNode::removeEventListener): (WebKit::WebNode::simulateClick): (WebKit::WebNode::WebNode): (WebKit::WebNode::operator=): (WebKit::WebNode::operator PassRefPtr<Node>):
16:27 Changeset [55865] by jianli@chromium.org

Unreviewed. Added the test that time out on Tiger bot to mac-tiger/Skipped.

  • platform/mac-tiger/Skipped:
16:09 Changeset [55864] by andersca@apple.com

Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.

Reviewed by David Hyatt.

WebCore:

  • loader/EmptyClients.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:

WebKit/chromium:

  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:

WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.cpp:
  • WebCoreSupport/ChromeClientHaiku.h:

WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:
  • WebCoreSupport/WebChromeClient.h:

WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:
  • WebKitSupport/ChromeClientWx.h:
16:03 Changeset [55863] by simon.fraser@apple.com

2010-03-11 Simon Fraser <simon.fraser@apple.com>

No review.

Need to turn on WebGL explicitly for these tests for Leopard.

  • compositing/webgl/webgl-background-color.html:
  • compositing/webgl/webgl-reflection.html:
16:03 Changeset [55862] by japhet@chromium.org

2010-03-11 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Remove DOMObjectsInclude.h and update headers accordingly.

https://bugs.webkit.org/show_bug.cgi?id=36036

  • WebCore.gypi:
  • bindings/v8/DOMData.h:
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/DOMObjectsInclude.h: Removed.
  • bindings/v8/V8DOMMap.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8Proxy.cpp:
16:02 Changeset [55861] by ap@apple.com

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=35965
<rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in

Test: plugins/round-trip-npobject.html

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::retainLocalObject): Corrected the check - there is now a separate ProxyRuntimeObject class for proxy pbjects. (WebKit::NetscapePluginInstanceProxy::releaseLocalObject): Ditto.
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Check if m_instanceProxy is still non-zero. The plug-in could have crashed while we were waiting for response. (WebKit::ProxyInstance::setFieldValue): Ditto.
15:57 Changeset [55860] by simon.fraser@apple.com

2010-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

Remove duplicate entries revealed after sorting.

  • WebCore.xcodeproj/project.pbxproj:
15:35 Changeset [55859] by simon.fraser@apple.com

2010-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

Sort the project files, also fixing some bogus spaces in the WebCore project.

15:14 Changeset [55858] by dimich@chromium.org

Make appcache layouttests top-frame-*.html more robust for async checking event
https://bugs.webkit.org/show_bug.cgi?id=32047

Reviewed by Alexey Proskuryakov.

Modified the tests to watch for all termination conditions, eliminating the hardcoded
assumed order of the events from separate async event sources.
Also added check for "noupdate" event.

  • http/tests/appcache/top-frame-2.html: Modified to be consistent with the other 2 tests.
  • http/tests/appcache/top-frame-3-expected.txt:
  • http/tests/appcache/top-frame-3.html: Used logic similar to top-frame-2.html to avoid assumption of the events order.
  • http/tests/appcache/top-frame-4-expected.txt:
  • http/tests/appcache/top-frame-4.html: Ditto.
15:13 Changeset [55857] by simon.fraser@apple.com

2010-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=35905
REGRESSION(55699?): media/video-no-autoplay.html times out on Leopard Commit Bot

Make sure we reset the WebGL preference, so that WebGL doesn't get left
on after being enabled via layoutTestController.overridePreference(),
which in turn causes accelerated compositing to be enabled on Leopard
when we don't want it to be.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
14:42 Changeset [55856] by japhet@chromium.org

2010-03-11 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

Fix style issues and improve comments from
http://trac.webkit.org/changeset/55853.

https://bugs.webkit.org/show_bug.cgi?id=36029

  • platform/animation/TimingFunction.h: (WebCore::TimingFunction::TimingFunction):
14:24 Changeset [55855] by cfleizach@apple.com

accessibilityIsIgnoredBase() needs to respect when platform says include
https://bugs.webkit.org/show_bug.cgi?id=36025

Reviewed by Beth Dakin.

Changed accessibilityIsIgnoredBase() to return a policy instead of a yes/no
answer. This allows the platform to make a yes decision on an element.

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::accessibilityIsIgnored):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::accessibilityIsIgnored):

  • accessibility/AccessibilityObject.h:

(WebCore::):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::accessibilityIsIgnored):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::accessibilityIsIgnored):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::accessibilityIsIgnored):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::accessibilityIsIgnored):

  • accessibility/chromium/AccessibilityObjectChromium.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/qt/AccessibilityObjectQt.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/win/AccessibilityObjectWin.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/wx/AccessibilityObjectWx.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

13:39 Changeset [55854] by kbr@google.com

2010-03-11 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Fix build breakage with ENABLE_3D_CANVAS=0
https://bugs.webkit.org/show_bug.cgi?id=35995

No new tests; verified in Chromium that WebGL is disabled in
ENABLE_3D_CANVAS=0 builds.

  • bindings/v8/custom/V8DocumentCustom.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
12:24 Changeset [55853] by japhet@chromium.org

2010-03-11 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium mac build fix.

Add an explicit copy constructor to TimingFunction.
http://trac.webkit.org/changeset/55835 trigged an inlining
bug in gcc that the copy constructor resolves.

  • platform/animation/TimingFunction.h: (WebCore::TimingFunction::TimingFunction):
12:18 Changeset [55852] by mrobinson@webkit.org

2010-03-11 Martin Robinson <mrobinson@webkit.org>

Reviewed by Adam Barth

Convert editing/selection/5136696.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=34306

  • editing/selection/5136696-expected.txt: Added.
  • editing/selection/5136696.html: Use dumpAsText now.
  • platform/gtk/Skipped: Unskip this test in GTK+ now that it has expected result.
  • platform/mac/editing/selection/5136696-expected.checksum: Removed.
  • platform/mac/editing/selection/5136696-expected.png: Removed.
  • platform/mac/editing/selection/5136696-expected.txt: Removed.
  • platform/qt/editing/selection/5136696-expected.txt: Removed.
  • platform/win/editing/selection/5136696-expected.txt: Removed.
12:01 Changeset [55851] by aroben@apple.com

Teach git about ObjC files

Fixes <http://webkit.org/b/36015>.

Reviewed by Tim Hatcher.

  • .gitattributes: Set the diff attribute for .m and .mm files, and .h

files in Mac-specific directories. This can be used to generate
more-readable diffs of ObjC files.

11:56 Changeset [55850] by dpranke@chromium.org

2010-03-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

rebaseline_chromium_webkit_tests doesn't handle other plaforms
correctly (e.g., if you run on the Mac platform and try to
rebaseline the WIN results, the result gets written into
platform/mac instead of platform/chromium-win). Also, this script
doesn't work on non-Chromium ports, so we need to fix that at some
point.

https://bugs.webkit.org/show_bug.cgi?id=35982

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
11:28 Changeset [55849] by cfleizach@apple.com

Fixing GTK. No review.

support lang attribute on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=36021

We don't need to cast to AccessibilityRenderObject to get language().

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(webkit_accessible_document_get_locale):

11:19 Changeset [55848] by cfleizach@apple.com

support lang attribute on <option> elements
https://bugs.webkit.org/show_bug.cgi?id=36021

Reviewed by Darin Adler.

WebCore:

Allow non AccessibilityRenderObject classes to access the lang
attribute by moving the useful code into AccessibilityObject.

Test: platform/mac/accessibility/option-with-lang.html

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::language):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::language):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::language):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • platform/mac/accessibility/option-with-lang-expected.txt: Added.
  • platform/mac/accessibility/option-with-lang.html: Added.
10:48 Changeset [55847] by tonikitoo@webkit.org

[Qt] Access key modifier should be Ctrl+Alt for Darwin derived OS and Alt for the others
https://bugs.webkit.org/show_bug.cgi?id=35993

Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-11
Reviewed by Simon Hausmann.

WebCore:

  • page/qt/EventHandlerQt.cpp:

(WebCore::EventHandler::accessKeyModifiers):

LayoutTests:

  • platform/qt/Skipped:
10:38 Changeset [55846] by brettw@chromium.org

010-03-08 Brett Wilson <brettw@chromium.org>

Reviewed by Adam Barth.

Remove the deprecated argument to url_util::IsStandard in preparation
for deleting that version of the function. Pull the latest googleurl
with the new version for the Chromium builder.

  • platform/KURLGoogle.cpp: (WebCore::KURL::isHierarchical):
09:02 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
09:00 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
running on HW issues (diff)
08:03 Changeset [55845] by hausmann@webkit.org

[Qt] Make it possible to do builds with separate debug info in packages

Reviewed by Tor Arne Vestbø.

  • WebCore.pro:
08:03 Changeset [55844] by hausmann@webkit.org

[Qt] Avoid double-buffering with Qt image decoders

Reviewed by Tor Arne Vestbø.

Pass QIODevice::Unbuffered when opening the QBuffer that
wraps the image data, to hint to Qt that no extra buffering
is needed.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::setData):

07:25 Changeset [55843] by benm@google.com

[Android] The platform touch events on Android are missing support
for key modifiers.
https://bugs.webkit.org/show_bug.cgi?id=35521

Reviewed by Jeremy Orlow.

Add support in PlatformToucHEventAndroid for the platform supplying
key modifiers with touch events.

Fixes Android so it now passes basic-single-touch-events.html.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent): Fix two compiler warnings.

  • platform/PlatformTouchEvent.h:

(WebCore::PlatformTouchEvent::PlatformTouchEvent): Add support for

key modifiers on Android.

  • platform/android/PlatformTouchEventAndroid.cpp:

(WebCore::PlatformTouchEvent::PlatformTouchEvent): ditto.

06:40 Changeset [55842] by cfleizach@apple.com

Unreviewed.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Wrong files were placed in skipped lists.

  • platform/gtk/Skipped:
03:38 Changeset [55841] by steveblock@google.com

2010-03-10 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Implements Geolocation maximumAge property
https://bugs.webkit.org/show_bug.cgi?id=30676

Test: fast/dom/Geolocation/maximum-age.html

  • WebCore.xcodeproj/project.pbxproj: Modified. Adds GeolocationPositionCache.h to Private headers
  • page/Geolocation.cpp: Modified. (WebCore::Geolocation::GeoNotifier::setUseCachedPosition): Added. (WebCore::Geolocation::GeoNotifier::runSuccessCallback): Added. (WebCore::Geolocation::GeoNotifier::timerFired): Modified. Added logic to handle using a cached position (WebCore::Geolocation::Watchers::contains): Added. Required to determine if a notifier is a watch request (WebCore::Geolocation::startRequest): Modified. Added logic to check for a cached position (WebCore::Geolocation::requestUsesCachedPosition): Added. Callback to Geolocation object when notifier uses a cached position (WebCore::Geolocation::makeCachedPositionCallbacks): Added. (WebCore::Geolocation::haveSuitableCachedPosition): Added. (WebCore::Geolocation::setIsAllowed): Modified. (WebCore::Geolocation::positionChanged): Modified. Make callbacks using cached position where appropriate (WebCore::Geolocation::geolocationServiceErrorOccurred): Modified. Make callbacks using cached position where appropriate
  • page/Geolocation.h: Modified.

2010-03-10 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Implements Geolocation maximumAge property
https://bugs.webkit.org/show_bug.cgi?id=30676

  • fast/dom/Geolocation/resources/maximum-age.js: Added. Checks that a cached position is used only when it should be.
  • fast/dom/Geolocation/maximum-age.html: Added. HTML wraper for above test.
  • fast/dom/Geolocation/maximum-age-expected.txt: Added. Expected result for above test.
02:57 Changeset [55840] by philn@webkit.org

2010-03-11 Philippe Normand <pnormand@igalia.com>

Unreviewed.

Unskip the fixed test that was (accidently?) re-skipped in r54205.

  • platform/gtk/Skipped:
02:25 Changeset [55839] by ossy@webkit.org

[Qt] storage/open-database-creation-callback-isolated-world.html was introduced in r55823,
but layoutTestController.evaluateScriptInIsolatedWorld() is unimplemented now.

  • platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html skipped.
02:16 Changeset [55838] by ossy@webkit.org

Unreviewed buildfix after r55823. (To fix Qt --minimal build.)
I have déjà vu, I'm sure that I did it before. (r55598)

  • bindings/js/JSDOMWindowCustom.cpp: Missing #if ENABLE(DATABASE) guard added.
01:43 Changeset [55837] by ossy@webkit.org

[Qt] Unreviewed buildfix after r55833.

Rename all instances of data() to characters()

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fieldNamed):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

01:29 Changeset [55836] by zoltan@webkit.org

2010-03-11 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

Allow custom memory allocation control for RenderLayerBacking class
https://bugs.webkit.org/show_bug.cgi?id=35857

Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'
RenderLayerBacking - rendering/RenderLayer.cpp:3047

  • rendering/RenderLayerBacking.h:
00:41 Changeset [55835] by zoltan@webkit.org

2010-03-11 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Simon Hausmann.

Allow custom memory allocation control for TimingFunction struct
https://bugs.webkit.org/show_bug.cgi?id=35855

Inherits the following struct from FastAllocBase because it is
instantiated by 'new':

class name - instantiated at: WebCore/'location'
TimingFuction - platform/graphics/GraphicsLayer.h:89

  • platform/animation/TimingFunction.h:

03/10/10:

23:53 Changeset [55834] by loki@webkit.org

Buildfix for Thumb-2 after r55684. Add branch8 and branchTest8 functions.
https://bugs.webkit.org/show_bug.cgi?id=35892

Reviewed by Gavin Barraclough.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::ldrb):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load8):
(JSC::MacroAssemblerARMv7::branch8):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::setTest8):

23:19 Changeset [55833] by barraclough@apple.com

Rubber stamped by Oliver Hunt.

Rename JSC::UStringImpl::data() to characters(), to match WebCore::StringImpl.

JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClassContextData::OpaqueJSClassContextData):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::keyForCharacterSwitch):

  • bytecompiler/NodesCodegen.cpp:

(JSC::processClauseList):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):

  • runtime/Identifier.cpp:

(JSC::Identifier::equal):
(JSC::Identifier::addSlowCase):

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):

  • runtime/UString.cpp:

(JSC::UString::toStrictUInt32):
(JSC::equal):

  • runtime/UString.h:

(JSC::UString::data):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::characters):
(JSC::UStringImpl::hash):
(JSC::UStringImpl::setHash):

WebCore:

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::uchars):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

23:07 Changeset [55832] by barraclough@apple.com

Fix for r55825, threadsafeCopy no longer needs to special-case for
empty strings (in fact, doing so results in leaks).

Reviewed by Mark Rowe.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::threadsafeCopy):

21:30 Changeset [55831] by cfleizach@apple.com

Unreviewed.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Wrong files were placed in skipped lists.

  • platform/gtk/Skipped:
  • platform/win/Skipped:
21:06 Changeset [55830] by cfleizach@apple.com

Unreviewed.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Skip this test since it uses tables and lists, which are not
supported on Tiger/Leopard.

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
20:09 Changeset [55829] by dbates@webkit.org

2010-03-10 Daniel Bates <dbates@rim.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=35840

Updates the subroutine builtDylibPathForName() so that it adds the "d" suffix to
the QtWebKit library name on Windows. This change makes run-launcher work again
under Windows. Moreover, this change corresponds to the change made in change-
set 53924 <http://trac.webkit.org/changeset/53924>.

  • Scripts/webkitdirs.pm:
20:05 Changeset [55828] by bweinstein@apple.com

Windows build fix - add an missing symbol to be exported

19:23 Changeset [55827] by chang.shu@nokia.com

2010-03-10 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

While calculating alpha channel, convert the floating point value to
an integer in [0, 256) with equal distribution.
https://bugs.webkit.org/show_bug.cgi?id=22150

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColorParameters):

2010-03-10 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

While calculating alpha channel, convert the floating point value to
an integer in [0, 256) with equal distribution.
Updated test results based on this new behavior.
https://bugs.webkit.org/show_bug.cgi?id=22150

  • fast/canvas/canvas-alphaImageData-behavior-expected.txt:
  • fast/canvas/canvas-alphaImageData-behavior.js:
  • platform/qt/Skipped:
18:38 Changeset [55826] by abarth@webkit.org

2010-03-10 Adam Barth <abarth@webkit.org>

Unreviewed.

http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot
https://bugs.webkit.org/show_bug.cgi?id=33349

Remove another test that has the same problem. We need to find a way
to relaibly test what happens when you mix JavaScript URLs and
window.open.

  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char-expected.txt: Removed.
  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html: Removed.
18:36 Changeset [55825] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=35991
Would be faster to not use a thread specific to implement StringImpl::empty()

Reviewed by Darin Adler, Geoffrey Garen, Maciej Stachowiak.

JavaScriptCore:

Change JSC::UStringImpl's implementation of empty() match to match StringImpl's new implementation
(use a static defined within the empty() method), and change the interface to match too (return
a pointer not a reference).

~0% performance impact (possible minor progression from moving empty() from .h to .cpp).

(JSC::Identifier::add):
(JSC::Identifier::addSlowCase):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/UString.cpp:

(JSC::initializeUString):
(JSC::UString::UString):

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::empty):
(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::adopt):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::tryCreateUninitialized):

WebCore:

Copy JavaScriptCore in making 'static' strings threadsafe, make the empty string a static,
shared by all threads.

~2% progression on Dromaeo DOM core & JS lib tests.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::eventNames):

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::empty):

  • platform/text/StringImpl.h:

(WebCore::StringImpl::deref):
(WebCore::StringImpl::hasOneRef):

18:19 Changeset [55824] by simon.fraser@apple.com

2010-03-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=35975
<rdar://problem/7739922> Flash 10.1b crashes when generating snapshots

Do a version check before sending a drawRect event to a Flash plugin,
since 10.1.d51 has a bug that crashes when called this way.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView supportsSnapshotting]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView drawRect:]):
18:18 Changeset [55823] by dumi@chromium.org

WebCore: Adding support for the optional creation callback that could be
passed to openDatabase().

Reviewed by Adam Barth.

Tests: storage/open-database-creation-callback.html

storage/open-database-creation-callback-isolated-world.html

https://bugs.webkit.org/show_bug.cgi?id=34726

  • Android.jscbindings.mk
  • Android.v8bindings.mk
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCallback.cpp: Added.

(WebCore::JSDatabaseCallback::JSDatabaseCallback):
(WebCore::JSDatabaseCallback::~JSDatabaseCallback):
(WebCore::JSDatabaseCallback::handleEvent):

  • bindings/js/JSDatabaseCallback.h: Added.

(WebCore::JSDatabaseCallback::create):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • bindings/v8/custom/V8DatabaseCallback.cpp: Added.

(WebCore::V8DatabaseCallback::V8DatabaseCallback):
(WebCore::V8DatabaseCallback::~V8DatabaseCallback):
(WebCore::V8DatabaseCallback::handleEvent):

  • bindings/v8/custom/V8DatabaseCallback.h: Added.

(WebCore::V8DatabaseCallback::create):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • storage/Database.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::performCreationCallback):

  • storage/Database.h:

(WebCore::Database::isNew):

  • storage/DatabaseCallback.h: Added.

(WebCore::DatabaseCallback::~DatabaseCallback):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):

  • workers/WorkerContext.h:

LayoutTests: Adding a test to test the creation callback passed to
openDatabase() and another one to make sure it is executed in the
correct world.

Reviewed by Adam Barth.

Also, fixing fast/frames/sandboxed-iframe-storage.html: calling
openDatabase() without at least 4 parameters should always fail,
because the database name, version, description and estimated size
are not optional according to the spec.

https://bugs.webkit.org/show_bug.cgi?id=34726

  • fast/frames/resources/sandboxed-iframe-storage-allowed.html:
  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-storage-expected.txt:
  • platform/qt/Skipped:
  • storage/open-database-creation-callback-expected.txt: Added.
  • storage/open-database-creation-callback.html: Added.
  • storage/open-database-creation-callback-isolated-world-expected.txt: Added.
  • storage/open-database-creation-callback-isolated-world.html: Added.
18:07 Changeset [55822] by abarth@webkit.org

2010-03-10 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Make Chrome consistently handle leading format characters in URLs

https://bugs.webkit.org/show_bug.cgi?id=35948

  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char-expected.txt: Added.
  • http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html: Added.

2010-03-10 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Make Chrome consistently handle leading format characters in URLs

https://bugs.webkit.org/show_bug.cgi?id=35948

Test: http/tests/security/xss-DENIED-window-open-javascript-url-leading-format-char.html

  • platform/KURLGoogle.cpp:
17:19 Changeset [55821] by jianli@chromium.org

Implementing DOMFormData class.
https://bugs.webkit.org/show_bug.cgi?id=35707

Reviewed by Dmitry Titov.

This patch only addresses the implementation of DOMFormData class and
moves the FormData construction logic from HTMLFormElement::createFormData
to FormData::create() so that it can be used by both HTMLFormElement
and XMLHttpRequest.

The DOMFormData IDL interface will be exposed in another patch and the
test will be added then.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/DOMFormData.cpp: Added.
  • html/DOMFormData.h: Added.
  • html/FormDataList.h:

(WebCore::FormDataList::encoding):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::createFormData):
(WebCore::HTMLFormElement::submit):

  • html/HTMLFormElement.h:
  • platform/network/FormData.cpp:

(WebCore::FormData::create):
(WebCore::FormData::createMultiPart):
(WebCore::FormData::appendDOMFormData):

  • platform/network/FormData.h:

(WebCore::FormData::boundary):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

  • xml/XMLHttpRequest.h:
16:59 Changeset [55820] by darin@chromium.org

2010-03-10 Darin Fisher <darin@chromium.org>

Reviewed by Jeremy Orlow.

Add API wrapper for WebCore::SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=35988

WebSerializedScriptValue is a wrapper around SerializedScriptValue.

WebPrivatePtr is used to simplify wrapping reference counted WebCore
types. This class is used to cleanup WebHistoryItem, and will be used
to clean up other classes in the WebKit API in a follow-up patch.

  • WebKit.gyp:
  • public/WebHistoryItem.h:
  • public/WebPrivatePtr.h: Added.
  • public/WebSerializedScriptValue.h: Added.
  • src/WebHistoryItem.cpp:
  • src/WebSerializedScriptValue.cpp: Added.
16:43 Changeset [55819] by cfleizach@apple.com

Skipping test on GTK and WIN. No Review.

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Thought this test might pass on the other platforms, but no.

  • platform/gtk/Skipped:
  • platform/win/Skipped:
16:36 Changeset [55818] by cfleizach@apple.com

VoiceOver can navigate to hidden content in widget (WAI-ARIA)
https://bugs.webkit.org/show_bug.cgi?id=35986

Reviewed by Beth Dakin.

WebCore:

Elements that are subclassers of AXRenderObject have not been respecting
aria-hidden and other cases that would make them ignored. This applies
to tables, rows, cells, select boxes, sliders, and lists. Select boxes
also need to make sure their option elements respect aria-hidden as well.

Test: accessibility/aria-hidden-with-elements.html

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::accessibilityIsIgnored):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::addChildren):
(WebCore::AccessibilityListBox::accessibilityIsIgnored):
(WebCore::AccessibilityListBox::doAccessibilityHitTest):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::accessibilityIsIgnored):

  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredCommon):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::accessibilityIsIgnored):

  • accessibility/AccessibilitySlider.h:

(WebCore::AccessibilitySlider::roleValue):
(WebCore::AccessibilitySliderThumb::roleValue):
(WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::accessibilityIsIgnored):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::accessibilityIsIgnored):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::accessibilityIsIgnored):

  • accessibility/AccessibilityTableColumn.h:

(WebCore::AccessibilityTableColumn::roleValue):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):

  • accessibility/AccessibilityTableHeaderContainer.h:
  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::accessibilityIsIgnored):

LayoutTests:

  • accessibility/aria-hidden-with-elements-expected.txt: Added.
  • accessibility/aria-hidden-with-elements.html: Added.
16:14 Changeset [55817] by dimich@chromium.org

Not reviewed, fixing Snow Leopard build.

  • wtf/mac/MainThreadMac.mm: Forgot 'static' for a new local function.

(WTF::postTimer):

16:08 Changeset [55816] by dimich@chromium.org

Make Document::postTask to use a single queue of tasks, to fire them in order
https://bugs.webkit.org/show_bug.cgi?id=35943

Reviewed by Darin Adler.

JavaScriptCore:

The patch uses CFRunLoopTimer to schedule execution of tasks instead of performSelectorOnMainThread which apparently can starve other event sources.
The timer is used when the schedule request is coming on the main thread itself. This happens when the task is posted on the main thread or
when too many tasks are posted and the queue does 'stop and re-schedule' to make sure run loop has a chance to execute other events.

  • wtf/mac/MainThreadMac.mm:

(WTF::timerFired):
(WTF::postTimer):
(WTF::scheduleDispatchFunctionsOnMainThread): Use timer posted to the current RunLoop if scheduling the task execution while on the main thread.

WebCore:

Test: existing worker-cloneport.html which was broken by initial patch in http://trac.webkit.org/changeset/55593.
Additional test which indirectly verifies the order of execution will come as part of https://bugs.webkit.org/show_bug.cgi?id=34726

  • dom/Document.cpp:

(WebCore::Document::postTask): Always use the same task queue, independent of what thread is posting the task.

LayoutTests:

Updated the test since the order of events coming from independent task sources has changed.
This is a behavior change, but is consistent with the spec (which specifically says these events may be fired
in any order) and the last version of FF (3.5.8) which was completing the test successfully.

  • http/tests/appcache/top-frame-2-expected.txt:
  • http/tests/appcache/top-frame-2.html:
15:40 Changeset [55815] by ggaren@apple.com

Windows build fix: added new symbol.

15:28 Changeset [55814] by darin@chromium.org

2010-03-10 Sanjeev Radhakrishnan <sanjeevr@chromium.org>

Reviewed by Darin Fisher.

Allow a plugin to participate in the browser's print workflow.
https://bugs.webkit.org/show_bug.cgi?id=35550

  • loader/PluginDocument.cpp:
  • loader/PluginDocument.h:
15:27 Changeset [55813] by ggaren@apple.com

Windows build fix: removed old symbol.

15:19 Changeset [55812] by eric@webkit.org

2010-03-10 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35913

  • efl/WebCoreSupport/ChromeClientEfl.cpp: Added.
  • efl/WebCoreSupport/ChromeClientEfl.h: Added.
15:11 Changeset [55811] by ggaren@apple.com

Refactored fastCheckConsistency to match some review comments:

  • renamed fastCheckConsistency to fastMallocSize, and changed ValueCheck to ASSERT that a pointer's fastMallocSize is not 0.
  • implemented a version of fastMallocSize for tcmalloc.


Reviewed by Alexey Proskuryakov, Darin Adler, and Sam Weinig.

Also moved some pre-existing code around to avoid a problem related to
mismatched #define/#undef of malloc/free in this source file.

(WTF::fastMallocSize): Renamed. Fixed indentation.

(WTF::TCMalloc_PageHeap::scavenge): Removed an incorrect ASSERT that
got in the way of testing the tcmalloc implementation. (More information
on why this ASSERT is incorrect is in <rdar://problem/7165917>.)

(WTF::TCMallocStats::fastMallocSize): Implemented for tcmalloc.

  • wtf/FastMalloc.h: Updated for rename.
  • wtf/ValueCheck.h:

(WTF::): Moved the ASSERT that used to be in fastCheckConsistency here.

15:00 Changeset [55810] by jam@chromium.org

2010-03-10 John Abd-El-Malek <jam@chromium.org>

Reviewed by Nate Chapin.

[chromium]: Fix regression in mouse capture on Mac/Linux
https://bugs.webkit.org/show_bug.cgi?id=35987

  • src/WebViewImpl.cpp:
14:44 Changeset [55809] by eric@webkit.org

2010-03-10 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

The build fix for my patch on bug #35763 wasn't quite right--it removed
the call entirely, instead of replacing it with the new API. This adds
the call to Database::setIsAvailable.

https://bugs.webkit.org/show_bug.cgi?id=35763

14:26 Changeset [55808] by eric@webkit.org

2010-03-10 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

[chromium] add functionality to activate the focused node in a WebView
https://bugs.webkit.org/show_bug.cgi?id=35407

  • public/WebDocument.h:
  • public/WebNode.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::focusedNode): Added
  • src/WebNode.cpp: (WebKit::WebNode::simulateClick): Added
14:19 Changeset [55807] by aroben@apple.com

Roll out the prepare-ChangeLog part of r55870

This change wasn't needed (prepare-ChangeLog calls svn-create-patch
when it's asked to print out diffs for the user) and was screwing up
its ability to find changed function names.

  • Scripts/prepare-ChangeLog:

(diffCommand): Change the options we pass to svn-diff back to their
pre-r55870 form.

14:09 Changeset [55806] by eric@webkit.org

2010-03-10 Ilya Tikhonovsky <loislo@loislo-macbookpro.local>

Reviewed by Pavel Feldman.

Sidebar resize element height was adjusted.
Display name for Function Call details was adjusted.

https://bugs.webkit.org/show_bug.cgi?id=35939

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
13:59 Changeset [55805] by jam@chromium.org

2010-03-10 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=35952
Propagate mouse wheel events to Pepper plugins.

  • src/WebInputEventConversion.cpp: (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
  • src/WebInputEventConversion.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleEvent): (WebKit::WebPluginContainerImpl::handleMouseEvent): (WebKit::WebPluginContainerImpl::handleWheelEvent): (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
  • src/WebPluginContainerImpl.h:
13:58 Changeset [55804] by tonikitoo@webkit.org

2010-03-10 Antonio Gomes <tonikitoo@webkit.org>

The test was introduced in r55796, it has been failing in Gtk bots since then.

Filed bug https://bugs.webkit.org/show_bug.cgi?id=35984.

  • platform/gtk/Skipped: fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html skipped until fix.
13:55 Changeset [55803] by robert@webkit.org

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html

https://bugs.webkit.org/show_bug.cgi?id=35593

  • platform/qt/Skipped:

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html

https://bugs.webkit.org/show_bug.cgi?id=35593

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference): (LayoutTestController::setCaretBrowsingEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html
Fix typo (superfluous space) in QWebSettings docs.

https://bugs.webkit.org/show_bug.cgi?id=35593

  • Api/qwebpage.cpp: (qt_drt_enableCaretBrowsing):
  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): fix typo in docs
13:52 Changeset [55802] by eric@webkit.org

2010-03-10 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Fix https://bugs.webkig.org/show_bug.cgi?id=35207
When XHTMLMP is enabled, all xhtml documents fail to render for webkit portings wich use libxml2 tokenizer.

No new tests as all the xhtml test cases in LayoutTests/dom/xhtml fails without this fix when XHTMLMP is enabled.

  • dom/Document.cpp: (WebCore::Document::isXHTMLMPDocument):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::internalSubset): (WebCore::externalSubsetHandler):
13:34 Changeset [55801] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=35977

Reviewed by Sam Weinig.

Turns out the previous attempt to clear/reset cookies wasn't working because of the way
the URLs for the .js and its .cgi were being resolved.

So this is a better way to make the cookies consistent both before and after these tests.

If this fails to make cookie-related tests reliable, then we might have to bite the bullet
and give DRT itself the ability to forcibly remove cookies via API methods.

This would be bulletproof and could be automatic if a test declares itself "cookie sensitive"
but we'd lose the ability to reliably run these tests in the browser. :(

  • http/tests/cookies/resources/resetCookies.js: Added.
  • http/tests/cookies/resources/third-party-cookie-relaxing-iframe.html:
  • http/tests/cookies/third-party-cookie-relaxing.html:
  • http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html:
  • http/tests/plugins/third-party-cookie-accept-policy.html:
13:34 Changeset [55800] by eric@webkit.org

2010-03-10 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Adding all of the touch-related sources into Chromium's WebCore build.
https://bugs.webkit.org/show_bug.cgi?id=35874

Patch tested against the try bots, but the feature is exercised in the
fast/events/touch tests.

  • WebCore.gypi:

2010-03-10 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Add support for converting WebTouchEvents to PlatformTouchEvents and
routing them into the EventHandler for the frame in which they
originate.
https://bugs.webkit.org/show_bug.cgi?id=35874

  • src/ChromeClientImpl.h: (WebKit::ChromeClientImpl::needTouchEvents):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::touchEvent): Handle incoming WebTouchEvents, converting them to PlatformTouchEvents and sending them to the EventHandler. (WebKit::WebViewImpl::handleInputEvent): Now routes WebTouchEvents to the touchEvent handler.
  • src/WebViewImpl.h:
12:37 Changeset [55799] by pfeldman@chromium.org

2010-03-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: now that audits panel is added, add it to the
enums (for storing last active, etc.).

https://bugs.webkit.org/show_bug.cgi?id=35980

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::specialPanelForJSName):
  • inspector/InspectorController.h: (WebCore::InspectorController::):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):
  • inspector/front-end/inspector.js: (WebInspector.showAuditsPanel):
12:34 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
12:33 Changeset [55798] by japhet@chromium.org

2010-03-10 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Instead of describing the type of a wrapped v8 object
with an enum value, use a pointer to struct with more complete
information.

https://bugs.webkit.org/show_bug.cgi?id=35941

Refactoring only, so new tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMData.cpp:
  • bindings/v8/DOMData.h:
  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8Helpers.cpp:
  • bindings/v8/V8Helpers.h:
  • bindings/v8/V8Index.cpp: Removed.
  • bindings/v8/V8Index.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.h:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.h:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp:
  • bindings/v8/custom/V8SharedWorkerCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.h:
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
  • bindings/v8/custom/V8WebKitPointConstructor.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • bindings/v8/custom/V8WorkerCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:
12:18 Changeset [55797] by tonikitoo@webkit.org

Extend keyboard navigation to allow directional navigation (Manual tests)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Adds a manual tests for the Spatial Navigation feature comprasing varios
Html focusable elements (e.g. <a>, <table>, <iframe>) and much of the logic
provided by the feature.

  • manual-tests/spatial-navigation/links.html: Added.
  • manual-tests/spatial-navigation/spatial-navigation-test-cases.html: Added.
12:13 Changeset [55796] by tonikitoo@webkit.org

Extend keyboard navigation to allow directional navigation (LayoutTests - part V)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This patch adds three LayoutTests that ensure the correctness of Spatial Navigation algorithm
in the following iframe related traversals:

1) All focusable elements in a <iframe> should be accessible.
2) Focusable elements in an <iframe> should be accessible even when

current focused element is in another <iframe> in the same page.

  • fast/events/spatial-navigation/snav-iframe-no-focusable-content.html: Added.
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html: Added.
  • fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html: Added.
12:10 Changeset [55795] by tonikitoo@webkit.org

Extend keyboard navigation to allow directional navigation (LayoutTests - part IV)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This patch adds a LayoutTest that ensures that:

1) There is no unit overflow in the Spatial Navigation algorithm while

calculating the best node candidate to move focus to. To test that this
page positions some elements 10000000 pixels far from each other (distance
that can considered large enough for most of the Web Pages on the
Internet).

2) A best focusable candidate only gets focused if it is visible in the

current Viewport. Scroll-in-direction is performed otherwise.

  • fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html: Added.
12:08 Changeset [55794] by tonikitoo@webkit.org

Extend keyboard navigation to allow directional navigation (LayoutTests - part III)
https://bugs.webkit.org/show_bug.cgi?id=18662

Reviewed by Dave Hyatt.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This patch adds two LayoutTests to ensure the correctness of the "Fully aligned"
precedence logic implemented by Spatial Navigation algorithm, either vertically or
horizontally: targets whose middle falls between the top and bottom of the current
focused element are preferably to move focus to, even if it is not the shortest distance.

  • fast/events/spatial-navigation/snav-fully-aligned-vertically.html: Added.
  • fast/events/spatial-navigation/snav-fully-aligned-horizontally.html: Added.
12:06 Changeset [55793] by eric@webkit.org

2010-03-10 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to platform/efl.
http://webkit.org/b/35890

  • platform/efl/ScrollbarEfl.h: Added.
  • platform/efl/ScrollbarThemeEfl.h: Added.
11:47 Changeset [55792] by eric@webkit.org

2010-03-10 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Fixing build warning caused by using 0 instead of NULL as the sentiel
in a varargs call.
https://bugs.webkit.org/show_bug.cgi?id=35898

  • src/gtk/WebInputEventFactory.cpp:
11:26 Changeset [55791] by robert@webkit.org

2010-03-10 Robert Hogan <robert@webkit.org>

Reviewed by Holger Freyther.

QtLauncher: Fix typo in conditional statement in

WebViewGraphicsBased::setFrameRateMeasurementEnabled.

'=' should be '=='!

https://bugs.webkit.org/show_bug.cgi?id=35877

  • QtLauncher/webview.cpp: (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
11:17 Changeset [55790] by pfeldman@chromium.org

2010-03-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Audits panel needs an icon.
Landing icon attached by Timothy. Enabling panel!

https://bugs.webkit.org/show_bug.cgi?id=35945

  • WebCore.gypi:
  • inspector/front-end/Images/auditsIcon.png: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
10:59 Changeset [55789] by kov@webkit.org

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Roll-out r55657, as Xan noticed a bad degradation in playing
youtube HTML5 videos with it, that is fixed with it
reverted. Looks like we'll need to work a bit more on this.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedTimerFired): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::muteChangedTimerFired): (WebCore::MediaPlayerPrivate::muteChanged):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
10:41 Changeset [55788] by kov@webkit.org

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Fix ready state when buffering under PLAYING. We should not go
back to HaveNothing in that case.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::updateStates):
10:38 Changeset [55787] by adachan@apple.com

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=35976

Retrieve any dwItemData that's set on the context menu item in contextMenuItemByIdOrPosition().

  • platform/win/ContextMenuWin.cpp:
10:31 Changeset [55786] by cjerdonek@webkit.org

Refactored and cleaned up the code for unit-testing logging.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35845

  • Scripts/webkitpy/init/logtesting.py:
    • Added more information to the module docstring.
    • Added an assertMessages() method to the UnitTestLogStream class. This simplifies the calling code.
    • Renamed the UnitTestLog class to LogTesting, and reformulated it as follows:
      • Moved the logging configuration code from the init method to a new static setUp() method.
      • Documented the init method to be private.
      • Improved the code so that the root logger does not have its logging level changed. Instead we set the handler's level. This makes the unit testing more unintrusive.
      • Updated the assertMessages() method to call the UnitTestLogStream class's assertMessages() method.
      • More fully documented the class.
  • Scripts/webkitpy/style/checker.py:
    • Added a logger parameter to the configure_logging() method. This allows us to prevent test messages from being sent to the root logger during unit testing, which may be rendering to the screen, etc.
    • Simplified the code by removing the _LevelLoggingFilter class.
    • Replaced the _LevelLoggingFilter class with a one-line lambda expression in configure_logging().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Changed relative imports to absolute to comply more with PEP8.
    • In the ConfigureLoggingTest class:
      • Changed the setUp() method to prevent test messages from being propagated to the root logger.
      • Changed the _log() method to a data attribute.
      • Updated to accommodate changes to logtesting.py.
  • Scripts/webkitpy/style_references.py:
    • Updated an import statement.
09:36 WikiStart edited by evan@chromium.org
add a gdb section (diff)
09:35 Changeset [55785] by evan@chromium.org

2010-03-10 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

Python code for GDB 7 to support native printing of some WebCore types.

  • gdb/webcore.py: Added.
09:06 Changeset [55784] by jorlow@chromium.org

2010-03-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Add IndexedDatabase class and hook it up.
https://bugs.webkit.org/show_bug.cgi?id=35927

This change is mostly just adding the plumbing necessary for
the IndexedDatabaseRequest and IndexedDatabaseSync (not written
yet).

This code is non-functional, so no tests (yet).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • storage/IndexedDatabase.cpp: Added. (WebCore::IndexedDatabase::get):
  • storage/IndexedDatabase.h: Added. (WebCore::IndexedDatabase::~IndexedDatabase):
  • storage/IndexedDatabaseImpl.cpp: Added. (WebCore::IndexedDatabaseImpl::get): (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h: Added.
  • storage/chromium/IndexedDatabase.cpp: Added. (WebCore::IndexedDatabase::get):
  • WebKit.gyp:
  • public/WebIndexedDatabase.h: Added. (WebKit::WebIndexedDatabase::~WebIndexedDatabase):
  • public/WebKitClient.h: (WebKit::WebKitClient::getIndexedDatabase):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::getIndexedDatabase):
  • src/IndexedDatabaseProxy.cpp: Added. (WebCore::IndexedDatabaseProxy::create): (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::~IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::open):
  • src/IndexedDatabaseProxy.h: Added.
08:56 Changeset [55783] by dglazkov@chromium.org

Add one more parent check during node removal.
https://bugs.webkit.org/show_bug.cgi?id=35818

Reviewed by Sam Weinig.

WebCore:

Test: fast/dom/Node/mutation-blur.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild): Added check.

LayoutTests:

  • fast/dom/Node/mutation-blur-expected.txt: Added.
  • fast/dom/Node/mutation-blur.html: Added.
08:50 Changeset [55782] by ossy@webkit.org

[Qt] fast/multicol/hit-test-above-or-below.html fails
https://bugs.webkit.org/show_bug.cgi?id=35973

The test was introduced in r55546, it has been failing since then.

  • platform/qt/Skipped: fast/multicol/hit-test-above-or-below.html skipped until fix.
08:34 Changeset [55781] by pfeldman@chromium.org

2010-03-10 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: added missing quote to localized strings.

  • English.lproj/localizedStrings.js:
07:47 Changeset [55780] by aroben@apple.com

Make svn-create-patch and prepare-ChangeLog show better section headings for ObjC files

This makes the text at the end of each "@@" line in a diff actually
show the ObjC method or interface that contains the change, rather
than whatever the most-recently-defined C function was.

Fixes <http://webkit.org/b/35970>.

Reviewed by John Sullivan.

  • Scripts/svn-create-patch: Pass -F'[-+@]' to diff so that it will

treat any lines starting with -, +, or @ as section heading lines.
This works well for ObjC files, and shouldn't affect other types of
files.

  • Scripts/prepare-ChangeLog: Changed the options passed to diff to

match those used in svn-create-patch.

07:38 Changeset [55779] by jorlow@chromium.org

Commit files that were supposed to go in with the last checkin.

07:34 Changeset [55778] by jorlow@chromium.org

Baby steps towards IndexedDB: Start implementing callbacks.
https://bugs.webkit.org/show_bug.cgi?id=35911

Reviewed by Dimitry Glazkov.

This patch adds some infastructure for IndexedDB callbacks in V8.
It also adds a stub of IDBDatabaseRequest. In the near future,
I'll gut the event based implementation code, flesh out IDBReqest
further, and start plumbing IndexedDatabaseRequest.

Code is not testible because it doesn't work (yet).

  • WebCore.gypi:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CustomIDBCallback.h: Added.

(WebCore::V8CustomIDBCallback::create):
(WebCore::V8CustomIDBCallback::~V8CustomIDBCallback):
(WebCore::V8CustomIDBCallback::handleEvent):
(WebCore::V8CustomIDBCallback::V8CustomIDBCallback):

  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:

(WebCore::V8IndexedDatabaseRequest::openCallback):

  • storage/IDBDatabaseRequest.h: Added.

(WebCore::IDBDatabaseRequest::request):

  • storage/IDBDatabaseRequest.idl: Added.
  • storage/IndexedDatabaseRequest.idl:
07:17 Changeset [55777] by kov@webkit.org

2010-03-10 Priit Laes <plaes@plaes.org>

Reviewed by Gustavo Noronha.

Estonian translation.

  • et.po: Added.
05:23 Changeset [55776] by sullivan@apple.com

<rdar://problem/7735387> input type other than text won't work with autofill
<https://bugs.webkit.org/show_bug.cgi?id=35963>

Reviewed by Tim Hatcher.

WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation elementDoesAutoComplete:]):
Return true for any text field that's not a password, rather than only
for TEXT type.

WebKit/win:

  • WebFrame.cpp:

(WebFrame::elementDoesAutoComplete):
Return true for any text field that's not a password, rather than only
for TEXT type.

04:44 BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
(diff)
04:10 Changeset [55775] by hausmann@webkit.org

Link QtLauncher against the WebKit library using a relative rpath.

Reviewed by Tor Arne Vestbø.

This makes the launcher and the lib relocatable.

  • QtLauncher/QtLauncher.pro:
02:46 Changeset [55774] by zecke@webkit.org

[Qt] Non animated gifs are animated in QtWebKit

https://bugs.webkit.org/show_bug.cgi?id=35955

Properly map Qt animated and non-animated values to WebCore's
understanding of animated and non-animated images. Currently
we can not map anything to the cAnimationLoopNone value.

  • manual-tests/qt/qt-anim.gif: Added.
  • manual-tests/qt/qt-gif-test.html: Added.
  • manual-tests/qt/qt-noanim.gif: Added.
  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::repetitionCount):

02:44 Changeset [55773] by zecke@webkit.org

[CAIRO] DoS on iexploder test with high text stroke width.

https://bugs.webkit.org/show_bug.cgi?id=33759

Specifying a big text stroke width can make WebKitGTK+ spend
a very long time in the cairo library for stroking the path of
the text. The best way to prevent this from happening right now
is to not stroke paths with a certain width. Samuel proposed to
not stroke with a width that is twice the width of the text. The
reason to use twice the text width is that even one stroke of
any charachter to be drawn would cover the full width.

Test: fast/text/text-stroke-width-cairo-dos.html

WebCore:

  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::drawGlyphs):

Add a test case with the -webkit-text-stroke-width attribute
set to a high value to illustrate the issue.

  • fast/text/text-stroke-width-cairo-dos-expected.txt: Added.
  • fast/text/text-stroke-width-cairo-dos.html: Added.
01:41 Changeset [55772] by zecke@webkit.org

[iExploder] Add new CSS Properties and HTML Attributes

The update-iexploder-cssproperties script was used to update
the various input files. The autobuffer HTML Attribute was removed
from WebKit and I manually added it back to the htmlattrs.in like
we have done it for other attributes in the past.

01:22 Changeset [55771] by pfeldman@chromium.org

2010-03-10 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: display list of active workers & support debugging
with fake workers.
https://bugs.webkit.org/show_bug.cgi?id=35568

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::InjectedScriptHost::injectedScriptFor):
  • dom/Document.cpp: (WebCore::Document::inspectorController):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::inspectorController):
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::injectScript): (WebCore::InjectedScriptHost::nextWorkerId): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::willDestroyWorker):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::willDestroyWorker):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didCreateWorker): (WebCore::InspectorFrontend::willDestroyWorker):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorWorkerResource.h: Added. (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::url): (WebCore::InspectorWorkerResource::isSharedWorker): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
  • inspector/front-end/Checkbox.js: Added. (WebInspector.Checkbox.callbackWrapper): (WebInspector.Checkbox): (WebInspector.Checkbox.prototype.checked):
  • inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._handleException): (InjectedFakeWorker.FakeWorker.prototype._importScripts): (InjectedFakeWorker.FakeWorker.prototype._loadScript): (InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.showInheritedToggleFunction): (WebInspector.StylePropertiesSection):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WorkersSidebarPane.js: Added. (WebInspector.WorkersSidebarPane): (WebInspector.WorkersSidebarPane.prototype.addWorker): (WebInspector.WorkersSidebarPane.prototype.removeWorker): (WebInspector.WorkersSidebarPane.prototype.setInstrumentation): (WebInspector.WorkersSidebarPane.prototype.reset): (WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument): (WebInspector.Worker): (WebInspector.didCreateWorker): (WebInspector.willDestroyWorker):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::~AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker): (WebCore::AbstractWorker::contextDestroyed):
  • workers/AbstractWorker.h: (WebCore::AbstractWorker::id):
  • workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
  • workers/Worker.cpp: (WebCore::Worker::Worker):

WebKit/chromium:

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
01:02 Changeset [55770] by zoltan@webkit.org

2010-03-10 Kevin Ollivier <kevino@theolliviers.com>

Reviewed by Eric Seidel.

Make global new/delete operators configurable for all ports and disable it
for the wx port for now.

  • wtf/FastMalloc.h:
  • wtf/Platform.h:
00:41 Changeset [55769] by tony@chromium.org

2010-03-10 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=35956
Create a grd file upstream for resources that chromium uses
that are pulled directly from the upstream repository.

  • WebKit.grd: Added.
00:06 Changeset [55768] by philn@webkit.org

2010-03-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] testkeyevents doesn't stop if input event injection fails
https://bugs.webkit.org/show_bug.cgi?id=35922

  • tests/testkeyevents.c: (load_status_cb): Added a safeguard to exit from the test if the input event injection failed.

03/09/10:

22:32 Changeset [55767] by rolandsteiner@chromium.org

Unreviewed build fix. Fix variable name change that somehow didn't
make it into the patch.

22:23 Changeset [55766] by rolandsteiner@chromium.org

Bug 28293 - [Chromium] event.datatransfer.getdata("text/uri-list") is treated the same as getdata("URL")
https://bugs.webkit.org/show_bug.cgi?id=28293

Reviewed by David Levin.

WebCore:

Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
correctly for event.dataTransfer.getData/setData. Currently both are treated
as synonyms, but for "URL", getData is supposed to only return the first valid URL
contained within the data for "text/uri-list" (see HTML5 spec).

Tests: editing/pasteboard/dataTransfer-setData-getData.html

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::clear):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::hasData):
(WebCore::ChromiumDataObject::ChromiumDataObject):

  • platform/chromium/ChromiumDataObject.h:

(WebCore::ChromiumDataObject::clearURL):
(WebCore::ChromiumDataObject::hasValidURL):
(WebCore::ChromiumDataObject::getURL):
(WebCore::ChromiumDataObject::setURL):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::):
(WebCore::clipboardTypeFromMIMEType):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):
(WebCore::DragData::canSmartReplace):

WebKit/chromium:

Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
correctly for event.dataTransfer.getData/setData. Currently both are treated
as synonyms, but for "URL", getData is supposed to only return the first valid URL
contained within the data for "text/uri-list" (see HTML5 spec).

Tests: editing/pasteboard/dataTransfer-setData-getData.html

  • src/WebDragData.cpp:

(WebKit::WebDragData::url):
(WebKit::WebDragData::setURL):

LayoutTests:

Change ChromiumDataObject such that it treats types "URL" and "text/uri-list"
correctly for event.dataTransfer.getData/setData. Currently both are treated
as synonyms, but for "URL", getData is supposed to only return the first valid URL
contained within the data for "text/uri-list" (see HTML5 spec).

Layout test checks various combinations in a drag-n-drop operation.
Skipping on all other platforms since they don't implement this correctly, either.

  • editing/pasteboard/dataTransfer-setData-getData.html: Added.
  • editing/pasteboard/script-tests/dataTransfer-setData-getData.js: Added.

(dragTarget):
(moveMouseToCenterOfElement):
(dragOntoDragTarget):
(doDrop):
(test):
(runTest):

  • platform/mac/Skipped:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
22:17 Changeset [55765] by pfeldman@chromium.org

2010-03-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: REGRESSION: Tall image resources are cropped over the bottom.

https://bugs.webkit.org/show_bug.cgi?id=34720

  • inspector/front-end/inspector.css:
22:13 Changeset [55764] by pfeldman@chromium.org

2010-03-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: REGRESSION: Pressing up/down arrow key to change numeric
value in CSS property takes focus away.

https://bugs.webkit.org/show_bug.cgi?id=34697

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
21:46 Changeset [55763] by ukai@chromium.org

2010-03-09 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed.

Obvious fix for --cgi-paths of pywebsocket.

  • Scripts/run-webkit-websocketserver:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
21:32 Changeset [55762] by tony@chromium.org

2010-03-09 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=21840
https://bugs.webkit.org/show_bug.cgi?id=23993

Fix an editing bug where replacing a selection would result in the
new text ending up inside nodes that were not visibly included in the
selection. Instead, move our destination position out of nodes that
were not visibly included.

Two new tests to verify the new behavior. Because we're now inserting
outside of some formatting nodes, some span tags are no longer necessary
for undoing formatting caused by these formatting nodes.

  • editing/deleting/backspace-avoid-preceding-style-expected.txt: Added.
  • editing/deleting/backspace-avoid-preceding-style.html: Added.
  • editing/inserting/replace-at-visible-boundary-expected.txt: Added.
  • editing/inserting/replace-at-visible-boundary.html: Added.
  • platform/mac/editing/deleting/delete-3857753-fix-expected.txt:
  • platform/mac/editing/inserting/insert-div-026-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • platform/mac/editing/style/font-family-with-space-expected.txt:
  • platform/mac/editing/style/smoosh-styles-001-expected.txt:
  • platform/mac/editing/style/style-boundary-005-expected.txt:

2010-03-09 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=21840
https://bugs.webkit.org/show_bug.cgi?id=23993

Fix an editing bug where replacing a selection would result in the
new text ending up inside nodes that were not visibly included in the
selection. Instead, move our destination position out of nodes that
were not visibly included.

Tests: editing/deleting/backspace-avoid-preceding-style.html

editing/inserting/replace-at-visible-boundary.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::positionAvoidingPrecedingNodes): (WebCore::ReplaceSelectionCommand::doApply):
20:53 Changeset [55761] by beidson@apple.com

REGRESSION: WebInspector docking busted on Windows
<rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953

Reviewed by Tim Hatcher.

WebCore:

First off, a bit of settings-key related cleanup. If they're shared over multiple files, these
things should be properly declared Strings, not random loose char*'s.

Along with that change, we move the "inspectorStartsAttachedSettingName" from WebKit down to the
InspectorController in WebCore.

Finally, when the controller is ready to show the WebInspector window, it can use this newly
exposed settings key to call "setWindowVisible" directly instead of relying on "showWindow" to do
it indirectly.

  • WebCore.base.exp:
  • inspector/InspectorBackend.cpp:

(WebCore::InspectorBackend::saveFrontendSettings):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::frontendSettingsSettingName):
(WebCore::InspectorController::inspectorStartsAttachedSettingName):
(WebCore::InspectorController::scriptObjectReady): Using the new inspectorStartsAttachedSettingName

key and some "can I attach this?" logic, call setWindowVisible directly to display the inspector
window.

(WebCore::InspectorController::populateScriptObjects):

  • inspector/InspectorController.h:

WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController showWindow:]): Use the InspectorController:: copy of the should attach settings key.
(-[WebInspectorWindowController attach]): Ditto.
(-[WebInspectorWindowController detach]): Ditto.

WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::attachWindow): Use the InspectorController:: copy of the should attach settings key.
(WebInspectorClient::detachWindow): Ditto.
(WebInspectorClient::showWindowWithoutNotifications): Ditto.

20:05 Changeset [55760] by ap@apple.com

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=35951
<rdar://problem/7327060> Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80

  • bridge/objc/objc_instance.mm: (createInstanceWrapperCache): Fix Tiger code path, too.
18:45 Changeset [55759] by kov@webkit.org

Tagging 1.1.23.

17:44 Changeset [55758] by jam@chromium.org

Reviewed by Darin Fisher.

Need to send mouse events to plugin when it has mouse capture
https://bugs.webkit.org/show_bug.cgi?id=35900

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isMouseEventType):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::mouseDown):
(WebKit::WebViewImpl::mouseUp):
(WebKit::WebViewImpl::handleInputEvent):

  • src/WebViewImpl.h:
17:29 Changeset [55757] by ap@apple.com

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=35951
<rdar://problem/7327060> Frequent crashes in Dashcode at JSC::Bindings::ObjcInstance::~ObjcInstance + 80

  • bridge/objc/objc_instance.mm: (createInstanceWrapperCache): It's not correct to use object personality for keys, because the key can be a mutable object, so its hash can change over its lifetime.
16:49 Changeset [55756] by ossy@webkit.org

[Qt] http/tests/plugins/third-party-cookie-accept-policy.html was introduced in r55738,
but layoutTestController.setAlwaysAcceptCookies() is missing.

  • platform/qt/Skipped: http/tests/plugins/third-party-cookie-accept-policy.html skipped.
16:45 Changeset [55755] by mrowe@apple.com

Versioning.

16:43 Changeset [55754] by mrowe@apple.com

New tag.

16:17 Changeset [55753] by ojan@chromium.org

2010-03-09 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

Fix review comment accidentally overlooked in bug 35713
https://bugs.webkit.org/show_bug.cgi?id=35947

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):
  • editing/DeleteSelectionCommand.h:
15:41 Changeset [55752] by ojan@chromium.org

2010-03-03 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

undo after smartdelete should select the deleted space
https://bugs.webkit.org/show_bug.cgi?id=35713

  • editing/undo/undo-smart-delete-reversed-selection-expected.txt: Added.
  • editing/undo/undo-smart-delete-reversed-selection.html: Added.
  • editing/undo/undo-smart-delete-word-expected.txt: Added.
  • editing/undo/undo-smart-delete-word.html: Added.

2010-03-03 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

undo after smartdelete should select the deleted space
https://bugs.webkit.org/show_bug.cgi?id=35713

TextEdit behavior is to select the deleted space after a smartdelete.

Tests: editing/undo/undo-smart-delete-reversed-selection.html

editing/undo/undo-smart-delete-word.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete): (WebCore::DeleteSelectionCommand::initializePositionData):
  • editing/DeleteSelectionCommand.h:
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::setWithoutValidation): This assert looks bogus to me. undo-smart-delete-reversed-selection.html hits it but not as a result of the other changes in this patch. The granularity when deleting after making a wordgranularity selection is wordgranularity, not charactergranularity.
15:32 Changeset [55751] by barraclough@apple.com

This caused a performance regression, by breaking the code
generator's logic to calculate the skip level for resolving
variables (traced by rdar:7683350) Reverting for now.

Reviewed by NOBODY (reverting r54510).

  • parser/Grammar.y:
  • parser/NodeConstructors.h:

(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

  • runtime/CommonIdentifiers.h:
  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::FunctionPrototype):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

15:07 Changeset [55750] by ggaren@apple.com

JavaScriptCore: Changed FastMalloc statistics reporting to be a bit clearer. We now
report:

  • Reserved VM Bytes: the VM that has been mapped into the process.
  • Committed VM Bytes: the subset of Reserved VM Bytes actually in use.
  • Free List Bytes: the subset of Committed VM Bytes in a free list.

Reviewed by Darin Adler.

  • wtf/FastMalloc.cpp:

(WTF::fastMallocStatistics):
(WTF::TCMallocStats::fastMallocStatistics): Updated to report the statistics
above. Standardized use of "ifdef WTF_CHANGES". Added a SpinLockHolder
around all statistics gathering, since it reads from the page heap.

  • wtf/FastMalloc.h: Updated to report the statistics above.

WebKit/mac: Updated for FastMalloc reporting changes.

Reviewed by Darin Adler.

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics memoryStatistics]):

14:40 Changeset [55749] by jwieczorek@webkit.org

2010-03-09 Jakub Wieczorek <jwieczorek@webkit.org>

Unreviewed.

Adding myself to committers.py.

  • Scripts/webkitpy/committers.py:
14:37 Changeset [55748] by darin@chromium.org

2010-03-09 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Fisher.

Accept and bailout NULL widgets in ChromiumBridge
https://bugs.webkit.org/show_bug.cgi?id=35796

  • src/ChromiumBridge.cpp: (WebCore::toChromeClientImpl):
14:24 Changeset [55747] by sfalken@apple.com

Rubber stamped by Adam Roben.

Load debug version of graphics library in Windows Debug_All builds.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):

14:13 Google Summer of Code 2010 edited by jorlow@chromium.org
(diff)
14:02 CommitterTips edited by jwieczorek@webkit.org
Fix a few typos. (diff)
14:00 Changeset [55746] by sullivan@apple.com

Fixed localized string key collision. update-webkit-localized-strings now
runs without errors.

Reviewed by Adam Roben.

WebKit:

  • English.lproj/Localizable.strings:

Regenerated.

WebKit/win:

  • WebCoreLocalizedStrings.cpp:

(WebCore::AXMenuListPopupActionVerb):
Used LPCTSTR_UI_STRING_KEY for the 2nd use of "press".

13:49 Changeset [55745] by sullivan@apple.com
  • StringsNotToBeLocalized.txt:

Brought this file up to date. update-webkit-localizable-strings still lists
one key collision, but that's a separate issue.

13:29 Changeset [55744] by kov@webkit.org

2010-03-09 Gustavo Noronha Silva <gns@gnome.org>

[GTK] Fails http/tests/plugins/third-party-cookie-accept-policy.html
https://bugs.webkit.org/show_bug.cgi?id=35942

Unreviewed. Skip test that fails, while we look for the
problem. This is likely a bug in soup.

  • platform/gtk/Skipped:
13:25 Changeset [55743] by kov@webkit.org

Unreviewed. Versioning, and documentation control files update for 1.1.23.

13:25 Changeset [55742] by beidson@apple.com

Fix my layouttest failures by resetting cookies before and after these new tests.
https://bugs.webkit.org/show_bug.cgi?id=26391

Reviewed by Alexey Proskuryakov.

  • http/tests/cookies/third-party-cookie-relaxing.html:
  • http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html:
  • http/tests/plugins/third-party-cookie-accept-policy.html:
13:23 Changeset [55741] by dpranke@chromium.org

2010-03-09 Dirk Pranke <dpranke@chromium.org>

Reviewed by Nate Chapin.

Fix --clobber-old-results in new-run-webkit-tests.

https://bugs.webkit.org/show_bug.cgi?id=35778

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12:58 Changeset [55740] by aroben@apple.com

Add a link to the Contributors Meeting registration form in the sidebar

Rubber-stamped in advance by Adele Peterson.

  • nav.inc: Added a link underneath "Trac".
11:56 Changeset [55739] by adele@apple.com

Add the ability to dispatch scroll wheel events in DRT. This was
necessary in order to write a test for
https://bugs.webkit.org/show_bug.cgi?id=34700.

Patch by Andy Estes <aestes@apple.com> on 2010-03-09
Reviewed by Adele Peterson.

  • DumpRenderTree/mac/EventSendingController.mm: Add support for two

new methods to EventSender: mouseScrollBy(x, y) and
continuousMouseScrollBy(x, y). The API to generate scroll events on
the mac was added in 10.5, so these methods are NOOPs on Tiger.
(+[EventSendingController isSelectorExcludedFromWebScript:]):
Regiester mouseScrollByX:andY: and continuousMouseScrollByX:andY:
(+[EventSendingController webScriptNameForSelector:]): Map JavaScript
method names to ObjC selectors.
(-[EventSendingController mouseScrollByX:andY:continuously:]): Generate
a scroll wheel event using CGEventCreateScrollWheelEvent() and dispatch
it to WebKit.
(-[EventSendingController continuousMouseScrollByX:andY:]): Generate a
continuous scrolling event by x and y pixels.
(-[EventSendingController mouseScrollByX:andY:]): Generate a notchy
scrolling event by x and y lines.

11:52 Changeset [55738] by beidson@apple.com

Plug-ins don't always respect the cookie accept policy.
<rdar://problem/7338359> and https://bugs.webkit.org/show_bug.cgi?id=26391

Reviewed by Darin Adler.

WebCore:

The problem is that the various plug-in implementations call into a ResourceLoader
directly instead of filtering the request through FrameLoader. This bypassed the step
of adding extra fields to the requests, such as the firstPartyForCookies URL.

Since plug-in code is currently so strewn about and very platform specific, I
think reworking it needs to be a task for domain experts. I don't know the implications
of adding *all* the extra fields to plug-in requests, for example.

There's no harm in this targeted fix for the hole in our cookie accept policy until
plug-ins can more fundamentally change.

Test: http/tests/plugins/third-party-cookie-accept-policy.html

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::load): Don't load a resource without first giving the request

a firstPartyForCookies URL.

LayoutTests:

  • http/tests/cookies/resources/cookie-utility.php:
  • http/tests/plugins/resources/third-party-cookie-accept-policy-iframe.html: Added.
  • http/tests/plugins/third-party-cookie-accept-policy.html: Added.
11:32 Changeset [55737] by adele@apple.com

WebCore: Check for null renderer in scrollNode().
https://bugs.webkit.org/show_bug.cgi?id=34700

Patch by Andy Estes <aestes@apple.com> on 2010-03-09
Reviewed by Adele Peterson.

Test: fast/events/remove-child-onscroll.html

  • page/EventHandler.cpp:

(WebCore::scrollNode): Return early if node->renderer() == 0

LayoutTests: Create a test for https://bugs.webkit.org/show_bug.cgi?id=34700. This
test required implementing scroll wheel event dispatch in DRT and
currently only works on OS X 10.5+. Skip this test on other platforms
for the time being.

Patch by Andy Estes <aestes@apple.com> on 2010-03-09
Reviewed by Adele Peterson.

  • fast/events/remove-child-onscroll-expected.txt: Added.
  • fast/events/remove-child-onscroll.html: Added.
  • platform/gtk/Skipped: Skip remove-child-onscroll.html
  • platform/mac-tiger/Skipped: Skip remove-child-onscroll.html
  • platform/qt/Skipped: Skip remove-child-onscroll.html
  • platform/win/Skipped: Skip remove-child-onscroll.html
11:20 QtWebKitContrib edited by jocelyn.turcotte@nokia.com
(diff)
11:18 QtWebKitContrib edited by jocelyn.turcotte@nokia.com
(diff)
11:12 Changeset [55736] by kov@webkit.org

Unreviewed distcheck fix

11:11 Changeset [55735] by eric@webkit.org

2010-03-09 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Adler.

Fix send-oncancel-event. It uses js-test-post, not
js-test-post-function.
https://bugs.webkit.org/show_bug.cgi?id=35880

  • fast/events/touch/script-tests/send-oncancel-event.js: (touchcancelHandler):
10:45 Changeset [55734] by kov@webkit.org

2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix (only exposed by make distcheck). The

SharedWorkers files are not built, they need to be distributed.

  • GNUmakefile.am:
10:43 Changeset [55733] by kov@webkit.org

2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Dirk Schulze.

[GStreamer] Buffering logic is not correct, and does not work very well
https://bugs.webkit.org/show_bug.cgi?id=35706

Fix buffering to match GStreamer expectancies regarding the
pipeline state, so that videos which really need buffering to play
correctly also work, while maintaining the convenience of
on-disk-buffering. This required a bit of shuffling of state
change handling.

No behaviour change expected.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::updateStates):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
10:35 Changeset [55732] by kov@webkit.org

2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Dirk Schulze.

[GStreamer] Buffering logic is not correct, and does not work very well
https://bugs.webkit.org/show_bug.cgi?id=35706

Do not call pause(), but set the GStreamer state directly. This is
just a GStreamer implementation detail, and this will avoid having
side effects in case we change the pause implementation in the
future.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::load):
10:25 Changeset [55731] by simon.fraser@apple.com

2010-03-09 Simon Fraser <simon.fraser@apple.com>

Skip media/video-source-error.html on SnowLeopard, beacuse it fails sporadically.
This is covered by https://bugs.webkit.org/show_bug.cgi?id=32270.

  • platform/mac-snowleopard/Skipped:
10:11 Changeset [55730] by cfleizach@apple.com

DRT build fix for Tiger. No review.

AX: hit testing a list box doesn't work anymore
https://bugs.webkit.org/show_bug.cgi?id=35893

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::elementAtPoint):

09:42 Changeset [55729] by cfleizach@apple.com

AX: hit testing a list box doesn't work anymore
https://bugs.webkit.org/show_bug.cgi?id=35893

Reviewed by Darin Adler.

WebCore:

Since <option> elements don't have renderers, their hit testing needs
to be handled with a special case.

Test: platform/mac/accessibility/listbox-hit-test.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaIsHidden):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):

WebKitTools:

  • DumpRenderTree/AccessibilityController.cpp:

(getElementAtPointCallback):
(AccessibilityController::getJSClass):

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::elementAtPoint):

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::elementAtPoint):

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::elementAtPoint):

LayoutTests:

  • platform/mac/accessibility/listbox-hit-test-expected.txt: Added.
  • platform/mac/accessibility/listbox-hit-test.html: Added.
09:37 Changeset [55728] by pfeldman@chromium.org

2010-03-09 Pavel Feldman <pfeldman@chromium.org>

r55727 was landed with wrong commit messages. Should have been:

Reviewed by Timothy Hatcher.

Web Inspector: Refactor Audits panel presentation layer.
This change removes unnecessary complexity:

  • Audit scores were not used
  • Audit rule parameters are passed as rule constructor arguments
  • View management aligned with the rest of the front-end
  • Single TreeOutline is used for category results (no need to create sections for those)
  • Rules code beautified and simplified where possible
  • Some UI improvements applied (see attached screenshot)

https://bugs.webkit.org/show_bug.cgi?id=35860

09:34 Changeset [55727] by pfeldman@chromium.org

2010-03-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.


When enable resource tracking state changes use the same method as
location.reload for reloading inspected page.

https://bugs.webkit.org/show_bug.cgi?id=35923

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::reloadPage):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking):
09:22 Changeset [55726] by yurys@chromium.org

2010-03-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.


When enable resource tracking state changes use the same method as
location.reload for reloading inspected page.

https://bugs.webkit.org/show_bug.cgi?id=35923

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::reloadPage):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking):

2010-03-09 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Use clean global object for devtools utility context instead of
trying to simulate inspected context.


https://bugs.webkit.org/show_bug.cgi?id=35923

  • src/DebuggerAgentImpl.cpp:
  • src/DebuggerAgentImpl.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::resetInspectorFrontendProxy):
08:24 Changeset [55725] by pfeldman@chromium.org

2010-03-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: highlight text node containers while searching for node.

https://bugs.webkit.org/show_bug.cgi?id=35912

  • inspector/InspectorController.cpp: (WebCore::InspectorController::mouseDidMoveOverElement):
07:51 QtWebKitRelease20 edited by jocelyn.turcotte@nokia.com
(diff)
07:47 Changeset [55724] by ossy@webkit.org

[Qt] editing/execCommand/move-selection-back-line.html fails in DRT.
https://bugs.webkit.org/show_bug.cgi?id=35921

  • platform/qt/Skipped: editing/execCommand/move-selection-back-line.html skipped until fix.
07:46 QtWebKitRelease20Deployment created by jocelyn.turcotte@nokia.com
07:39 QtWebKitBugs edited by hausmann@webkit.org
(diff)
06:46 Changeset [55723] by kov@webkit.org

2010-03-09 Peteris Krisjanis <pecisk@gmail.com>

Reviewed by Gustavo Noronha.

Latvian translation.

  • lv.po: Added.
06:42 Changeset [55722] by kov@webkit.org

2010-03-09 Duy Nguyen <pclouds@gmail.com>

Reviewed by Gustavo Noronha.

Vietnamese translation update.

  • vi.po:
06:36 Changeset [55721] by kov@webkit.org

2010-03-09 Rimas Kudelis <rq@akl.lt>

Reviewed by Gustavo Noronha.

Lithuanian translation update.

  • lt.po:
03:23 Changeset [55720] by ossy@webkit.org

Unreviewed trivial fix.

[Qt] perl websocket test(s) time out
https://bugs.webkit.org/show_bug.cgi?id=34879
It was fixed by r55719, so we can unskip websocket/tests/cookies/httponly-cookie.pl.

storage/open-database-creation-callback-isolated-world.html removed
from Skipped list, because it was removed from tree by r55635.

  • platform/qt/Skipped:
    • websocket/tests/cookies/httponly-cookie.pl unskipped.
    • storage/open-database-creation-callback-isolated-world.html unskipped.
03:20 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
Add the all triaged bugs list (diff)
02:40 Changeset [55719] by ukai@chromium.org

2010-03-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

pywebsocket should support html and cgi in the same directory.
https://bugs.webkit.org/show_bug.cgi?id=34879

  • websocket/tests/cookies: Removed.
  • websocket/tests/cookies/echo-cookie_wsh.py: Removed.
  • websocket/tests/cookies/httponly-cookie-expected.txt: Removed.
  • websocket/tests/cookies/httponly-cookie.pl: Removed.
  • websocket/tests/echo-cookie_wsh.py: Copied from LayoutTests/websocket/tests/cookies/echo-cookie_wsh.py.
  • websocket/tests/httponly-cookie-expected.txt: Copied from LayoutTests/websocket/tests/cookies/httponly-cookie-expected.txt.
  • websocket/tests/httponly-cookie.pl: Copied from LayoutTests/websocket/tests/cookies/httponly-cookie.pl.

2010-03-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

pywebsocket should support html and cgi in the same directory.
https://bugs.webkit.org/show_bug.cgi?id=34879

Import pywebsocket 0.4.9.2
Specify --server-host 127.0.0.1, so that it only binds listening socket
to 127.0.0.1 to prevent access from non-localhost.
Change --cgi-paths from /websocket/tests/cookies to /websocket/tests,
because pywebsocket 0.4.9.2 supports html and cgi in the same directory
and only executable (httponly-cookies.pl) will be handled as cgi
script.

  • Scripts/run-webkit-tests:
  • Scripts/run-webkit-websocketserver:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/README.webkit:
  • Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/setup.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added.
01:36 Changeset [55718] by loki@webkit.org

Rubber-stamped by Maciej Stachowiak.

Buildfix for ARM after r55684. Add branch8 and branchTest8 functions.
https://bugs.webkit.org/show_bug.cgi?id=35892

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::dataTransfer32):

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branchTest8):

01:01 Changeset [55717] by philn@webkit.org

2010-03-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] player code cleanups
https://bugs.webkit.org/show_bug.cgi?id=35868

Cleaned up the private instance variables of the player.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::mediaLocationChanged):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
01:01 Changeset [55716] by philn@webkit.org

2010-03-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] player code cleanups
https://bugs.webkit.org/show_bug.cgi?id=35868

Splitted GOwnPtrGtk.{cpp,h} to GOwnPtr{Soup,GStreamer}.{cpp,h}.

  • GNUmakefile.am:
  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Added. (WTF::GstElement):
  • platform/graphics/gstreamer/GOwnPtrGStreamer.h: Added.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/gtk/GOwnPtrGtk.cpp: Removed.
  • platform/gtk/GOwnPtrGtk.h: Removed.
  • platform/network/soup/CookieJarSoup.cpp:
  • platform/network/soup/DNSSoup.cpp:
  • platform/network/soup/GOwnPtrSoup.cpp: Added. (WTF::SoupURI):
  • platform/network/soup/GOwnPtrSoup.h: Added.
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/soup/ResourceRequestSoup.cpp:
00:30 Changeset [55715] by cjerdonek@webkit.org

Simplified check-webkit-style's argument parsing code by removing
support for the vestigial "extra flag values" parameter.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34677

The "extra flag values" parameter was needed before WebKit
forked check-webkit-style from Google. It was used to pass
through the option parser those command-line flags that WebKit
required but that Google's parser did not support (the --git-commit
flag in particular).

We can remove the parameter now because it is no longer

needed and unnecessarily clutters the argument-parsing code.

  • Scripts/webkitpy/style/optparser.py:
    • Removed the extra_flag_values parameter from the CommandOptionValues class's constructor.
    • Removed the extra_flags parameter from the ArgumentParser class's parse() method.
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Removed from the unit tests all references to the extra_flag_values variable.
00:23 Changeset [55714] by hamaji@chromium.org

2010-03-09 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Should remove paddings of Win/Linux chromium's buttons
https://bugs.webkit.org/show_bug.cgi?id=35629

No new tests, but we may need to rebaseline bunch of expectation
images in chromium's tree.

  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumSkia.h:
Note: See TracTimeline for information about the timeline view.