Timeline


and

03/16/10:

23:50 Changeset [56099] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-16 Adam Barth <abarth@webkit.org>

No review, rolling out r56044.
http://trac.webkit.org/changeset/56044
https://bugs.webkit.org/show_bug.cgi?id=36048

This patch broke Windows Debug (Tests)

  • Scripts/webkitdirs.pm:
20:35 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
18:53 Changeset [56098] by jhawkins@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-16 James Hawkins <jhawkins@chromium.org>

Reviewed by David Levin.

[Chromium] Size the WebVector of forms after determining how many
forms are valid and will be returned.

https://bugs.webkit.org/show_bug.cgi?id=36204

No new tests, as this is only triggered by Chromium's use of the
WebFormElement API.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
18:05 Changeset [56097] by jam@chromium.org
  • 4 edits in trunk/LayoutTests/platform

update skipped test locations since I moved my test before commit

17:31 Changeset [56096] by jam@chromium.org
  • 13 edits
    3 adds in trunk

2010-03-16 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Give keyboard focus to PluginDocuments by default
https://bugs.webkit.org/show_bug.cgi?id=36147

Test: http/tests/plugins/plugin-document-has-focus.html

  • loader/PluginDocument.cpp: (WebCore::PluginDocument::pluginNode):
  • loader/PluginDocument.h:
  • page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument):

2010-03-16 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Give keyboard focus to PluginDocuments by default
https://bugs.webkit.org/show_bug.cgi?id=36147

  • http/tests/plugins/plugin-document-has-focus-expected.txt: Added.
  • http/tests/plugins/plugin-document-has-focus.html: Added.
  • http/tests/plugins/resources/plugin-document-has-focus.pl: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-03-16 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Give keyboard focus to PluginDocuments by default
https://bugs.webkit.org/show_bug.cgi?id=36147

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_SetWindow): (handleEventCarbon): (handleEventCocoa):
17:23 Changeset [56095] by mitz@apple.com
  • 3 edits in trunk/WebKitLibraries

Fix incorrect glyph advances when using the Core Graphics (non-GDI) glyph look.

Reviewed by Sam Weinig.

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
17:10 Changeset [56094] by cfleizach@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION (r53857): Crash when tabbing to <map>
https://bugs.webkit.org/show_bug.cgi?id=36017

Reviewed by Darin Adler.

WebCore:

Test: fast/events/imagemap-norender-crash.html

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):

LayoutTests:

Also fix the path to js-test-post.js in tab-imagemap.html.

  • fast/events/imagemap-norender-crash-expected.txt: Added.
  • fast/events/imagemap-norender-crash.html: Added.
  • fast/events/tab-imagemap-expected.txt:
  • fast/events/tab-imagemap.html:
16:39 Changeset [56093] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-03-16 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

Temporarily disable WebGL layout tests failing due to multisampling
https://bugs.webkit.org/show_bug.cgi?id=36200

  • platform/mac/Skipped:
16:14 Changeset [56092] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 36083 - REGRESSION (r55772-r55834): Crash in JavaScriptCore RegExp code on PowerPC

Reviewed by Oliver Hunt, Darin Adler.

The problem is a bug in our port of PCRE - that a read may take place from the first character in an
empty string. For the time being, revert to using a valid pointer in the data segment rather than
an invalid non-null pointer into the zero-page for the empty string's data pointer. A better fix for
this will be to remove PCRE.

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::empty):

16:05 Changeset [56091] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix run-webkit-httpd on Windows.

Reviewed by Mark Rowe.

  • Scripts/webkitperl/httpd.pm:
15:33 Changeset [56090] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Tiger build fix.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Added more type casts to shut down warnings.
15:30 Changeset [56089] by ojan@chromium.org
  • 7 edits in trunk/LayoutTests

2010-03-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Alexey Proskuryakov.

fix webkit win test failures for smart delete
https://bugs.webkit.org/show_bug.cgi?id=36141

Works around https://bugs.webkit.org/show_bug.cgi?id=36140.

  • editing/deleting/smart-delete-004.html:
  • editing/pasteboard/smart-paste-002.html:
  • editing/pasteboard/smart-paste-005.html:
  • editing/pasteboard/smart-paste-007.html:
  • platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
15:26 Changeset [56088] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

Build fix. No Review.

Correct missing includes in cURL network backend introduced
by recent changes in WebKit.

  • platform/network/curl/ResourceHandleCurl.cpp: Add missing includes for SharedBuffer and PassRefPtr.

(WebCore::ResourceHandle::loadResourceSynchronously): Correct

constructor signature for ResourceHandle to match @r55688.

  • platform/network/curl/ResourceHandleManager.cpp: Add missing include for RetainPtr.
15:18 ImprovingLifeOnWindows edited by dbates@webkit.org
Support for detecting the presence of the Windows Platform SDK was … (diff)
15:10 QtWebKitGraphics edited by noam.rosenthal@nokia.com
(diff)
14:26 Changeset [56087] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.90

Tagging 1.1.90.

14:26 Changeset [56086] by ap@apple.com
  • 4 edits in trunk/WebKitTools

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36184
YouTube video resizing doesn't work with OOP plug-ins

Added a resizeTo() method, which calls resizePlugin() in JS with the same arguments,
and a lastSetWindowArguments property, which returns a string describing the last NPWindow
passed to NPN_SetWindow.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): (testResizeTo): (pluginInvoke):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_SetWindow):
14:07 Changeset [56085] by darin@apple.com
  • 12 edits in trunk/JavaScriptCore

Rolled out r56081 since it broke the Windows build.

13:58 Changeset [56084] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-03-16 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Build breakage from 33416
https://bugs.webkit.org/show_bug.cgi?id=36189

No new tests. Built release Chromium.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::reshape):
13:49 Changeset [56083] by xan@webkit.org
  • 2 edits in trunk

2010-03-16 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Update library version for 1.1.90 release.

  • configure.ac:
13:46 Changeset [56082] by xan@webkit.org
  • 4 edits in trunk

2010-03-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump version for 1.1.90 release.

  • configure.ac:

WebKit/gtk:

2010-03-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.1.90 release.

  • NEWS:
13:46 Changeset [56081] by darin@apple.com
  • 12 edits in trunk/JavaScriptCore

Added arrayLength function and used it instead of hand-written code.

Reviewed by Sam Weinig.

Removed PtrAndFlags.h. The file was removed long ago.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Use arrayLength.

  • runtime/Collector.h:

(JSC::CollectorBitmap::count): Remove WTF:: prefix from use
of bitCount. In WTF we inject things into the global namespace
and this is no exception.

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate): Use arrayLength.

  • runtime/JSFunction.h:

(JSC::JSFunction::nativeFunction): Remove WTF:: prefix as above.
(JSC::JSFunction::scopeChain): Ditto.
(JSC::JSFunction::setScopeChain): Ditto.
(JSC::JSFunction::setNativeFunction): Ditto.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset): Use arrayLength.

  • runtime/JSImmediate.h:

(JSC::reinterpretDoubleToIntptr): Remove WTF:: prefix as above.
(JSC::reinterpretIntptrToDouble): Ditto.

  • runtime/JSONObject.cpp:

(JSC::Stringifier::appendQuotedString): Use arrayLength.
(JSC::Stringifier::toJSON): Ditto.
(JSC::Stringifier::appendStringifiedValue): Ditto.

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::SmallStrings): Ditto.

  • runtime/UString.cpp:

(JSC::UString::from): Use arrayLength.

  • wtf/StdLibExtras.h:

(WTF::bitwise_cast): Marked this inline!
(WTF::arrayLength): Added function template (actually written by Sam).
Added using declarations for public things in WTF namespace defined
in this file.

13:44 Changeset [56080] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Fix one too many empty lines in documentation of
window-obejct-cleared signal, which caused the documentation to be
rendered funny. Thanks to Martin Robinson for noticing.

  • webkit/webkitwebview.cpp:
13:40 Changeset [56079] by ap@apple.com
  • 5 edits
    3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36184
YouTube video resizing doesn't work with OOP plug-ins

Test: plugins/resize-from-plugin.html

We were calling _WKPHResizePluginInstance synchronously or asynchronously, depending on
whether the size has changed. But sync and async messages are not necessarily delivered in
order - plug-in host listens only to the former while waiting for a response to a message it
sent (a call to invoke() in this case).

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::resize):
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]):
13:31 Changeset [56078] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Add missing symbol to GeoLocation documentation
section.

  • docs/webkitgtk-sections.txt:
12:35 Changeset [56077] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-03-16 Matej Urbančič <mateju@svn.gnome.org>

Reviewed by Gustavo Noronha.

Slovenian translation.

  • sl.po: Added.
12:14 Changeset [56076] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-03-16 António Lima <amrlima@gmail.com>

Reviewed by Gustavo Noronha.

Translation for pt (Portuguese)
https://bugs.webkit.org/show_bug.cgi?id=36148

  • pt.po: Added.
11:56 Changeset [56075] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-16 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35916

  • efl/WebCoreSupport/ContextMenuClientEfl.cpp: Added.
  • efl/WebCoreSupport/ContextMenuClientEfl.h: Added.
11:53 Changeset [56074] by kbr@google.com
  • 14 edits
    2 adds in trunk

2010-03-16 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

  • src/GraphicsContext3D.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Windows.

2010-03-16 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Fix an index bug.
  • platform/graphics/GraphicsContext3D.h: Add members/functions for multisampling/stencil buffer purpose.
  • platform/graphics/mac/Canvas3DLayer.h: Add GraphicsContext3D as a member of Canvas3DLayer.
  • platform/graphics/mac/Canvas3DLayer.mm: Add multisampling support.
  • platform/graphics/mac/GraphicsContext3DMac.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Mac.
  • platform/graphics/mac/GraphicsLayerCA.mm: Adjust to modified Canvas3DLayer init call.

2010-03-16 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Added.
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Added.
  • fast/canvas/webgl/context-attributes-expected.txt: WebGL context attributes behavior changed with this fix.
  • fast/canvas/webgl/context-attributes.html: Ditto.
  • fast/canvas/webgl/gl-get-calls-expected.txt: Stencil buffer is enabled, thus Stencil Bits is no longer 0.
  • fast/canvas/webgl/gl-get-calls.html: Ditto.
11:18 Changeset [56073] by eric@webkit.org
  • 7 edits in trunk

2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

Added layout tests to get the number of rows and columns.

https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables

  • platform/gtk/accessibility/table-hierarchy.html:
  • platform/gtk/accessibility/table-hierarchy-expected.txt:

2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables

Causes "layout tables" to be exposed as AccessibilityTables for Gtk.

  • accessibility/AccessibilityTable.cpp: (AccessibilityTable::isTableExposableThroughAccessibility):

2010-03-16 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=35504
[Gtk] Evaluate and fix AtkTable for layout tables

Implements rowCount and columnCount for Gtk in DRT.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::rowCount): (AccessibilityUIElement::columnCount):
10:41 Changeset [56072] by mrobinson@webkit.org
  • 5 edits in trunk/WebKit/gtk

2010-03-16 Martin Robinson <mrobinson@webkit.org>

Reviewed by Xan Lopez.

can't input korean into lower all input box except adress input box in webkit gtk launcher
https://bugs.webkit.org/show_bug.cgi?id=32290

Make the GTK+ EditorClient properly handle different types of input module
behavior such as commit and preedit signals that happen outside of key event
filtering and multiple times in a row. Filter keyup events as well as keydown
events and call gtk_im_context_focus_{in/out} when the WebView focus changes.

Added tests for this behavior to the GTK+ unit tests.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): Handle this signal properly when it happens outside of key event filtering. (WebKit::imContextPreeditChanged): Immediately update the preedit state and do not reject empty preedits, so that cancellation works properly. (WebKit::EditorClient::updatePendingComposition): Add this method, which handles the situation where a commit signal happens when there is still a pending commit. (WebKit::EditorClient::shouldBeginEditing): Clear pending composition state before editing starts. (WebKit::EditorClient::shouldEndEditing): Clear pending composition state before editing ends. (WebKit::EditorClient::handleKeyboardEvent): No longer special case preedits which happen during key event filtering. When confirming a pending composition use insertText instead of confirmComposition. (WebKit::EditorClient::handleInputMethodKeydown):
  • WebCoreSupport/EditorClientGtk.h: Make pendingComposition a member, so that multiple WebViews do not share state. (WebKit::EditorClient::webView): Added. (WebKit::EditorClient::treatContextCommitAsKeyEvent): Added. (WebKit::EditorClient::clearPendingComposition): Added.
  • tests/testkeyevents.c: (test_keypress_events_load_status_cb): (map_event_cb): (setup_keyevent_test): (test_keypress_events): (element_text_equal_to): (test_ime_load_status_cb): (test_ime): (main):
  • webkit/webkitwebview.cpp: (webkit_web_view_key_release_event): (webkit_web_view_focus_in_event):
10:33 Changeset [56071] by kov@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed. Build fix for distcheck.

10:26 Changeset [56070] by darin@chromium.org
  • 9 edits in trunk

2010-03-15 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36152
[chromium] Add support for history.pushState and history.replaceState

This is covered by the existing tests in fast/loader/stateobjects

09:58 Changeset [56069] by aroben@apple.com
  • 2 edits in trunk/WebCore

Fix linker warnings when building WebCore on Windows

Rubber-stamped by Steve Falkenburg.

  • WebCore.vcproj/WebCore.vcproj: Exclude JSDOMFormData.cpp from the

build, since it's already included in DerivedSources.cpp. Also let VS
sort this file as it saw fit.

09:53 QtWebKitGraphics edited by noam.rosenthal@nokia.com
(diff)
09:49 Changeset [56068] by antti@apple.com
  • 6 edits in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=36121
[Qt] Make WebKit scrollbars work with tiling

Reviewed by Simon Hausmann.

Translate coordinates correctly.

  • page/Frame.cpp:

(WebCore::Frame::tiledBackingStorePaintEnd):

WebKit/qt: https://bugs.webkit.org/show_bug.cgi?id=36121
[Qt] Make WebKit scrollbars work with tiling

Reviewed by Simon Hausmann.

  • Use the scrollbar overlay (implemented for accelerated compositing) when in tiled mode.
  • Make overlay compile unconditionally, enable on demand. This removes bunch of unneeded ifdefs.
  • Update the scroll position to the backing store as needed.
  • Renamed some methods.
  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::):
(QGraphicsWebViewPrivate::createOrDeleteOverlay):
(QGraphicsWebViewPrivate::setRootGraphicsLayer):
(QGraphicsWebViewPrivate::updateCompositingScrollPosition):
(QGraphicsWebViewPrivate::scroll):
(QGraphicsWebViewPrivate::update):
(QGraphicsWebViewPrivate::graphicsItemVisibleRect):
(QGraphicsWebView::paint):
(QGraphicsWebView::setPage):
(QGraphicsWebView::updateGeometry):
(QGraphicsWebView::setGeometry):

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderFromTiledBackingStore):

  • Api/qwebframe_p.h:
09:21 Changeset [56067] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-16 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: inspector http test fix that migrates it to the new inspector api.

  • http/tests/inspector/inspect-iframe-from-different-domain.html:
09:19 Changeset [56066] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-16 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

Remove extra <new> include and add guards to operator new/delete definitions
https://bugs.webkit.org/show_bug.cgi?id=35967

Remove extra <new> header include from FastAlloc.cpp since it is included in
FastAlloc.h. Add ENABLE(GLOBAL_FASTMALLOC_NEW) macro guard to operator
new/delete/new []/delete [] definitions.

  • wtf/FastMalloc.cpp:
09:18 Changeset [56065] by jwieczorek@webkit.org
  • 2 edits in trunk/WebCore

2010-03-16 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Eric Seidel.

[Qt] MediaPlayerPrivate: Initialize m_mediaPlayerControl to 0 to
avoid crashes when no media services can be found.

https://bugs.webkit.org/show_bug.cgi?id=36142

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
09:09 Changeset [56064] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-03-16 Adam Barth <abarth@webkit.org>

Unreviewed.

noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092

Add missing "!" in plugin code. Should fix plugins/embed-inside-object
on Gtk and Qt.

  • plugins/PluginView.cpp: (WebCore::PluginView::load):
09:00 Changeset [56063] by japhet@chromium.org
  • 2 edits
    1 delete in trunk/WebCore

2010-03-16 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Delete DerivedSourcesAllInOne.cpp.

https://bugs.webkit.org/show_bug.cgi?id=33048

  • Android.v8bindings.mk:
  • bindings/v8/DerivedSourcesAllInOne.cpp: Removed.
08:39 Changeset [56062] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

Roll out r55889, as it breaks the Qt port on Leopard

2010-03-11 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888

Use TARGETING_TIGER rather than BUILDING_ON_TIGER to determine the tags.

07:35 Changeset [56061] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Revert r56006 as it caused functional issues. We will work on a
testcase, and rework the fix, and land when we have this a bit
more testable.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaPlayButton):
07:19 Changeset [56060] by robert@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-15 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Fix crash in QWebView::setPage()

tst_qwebpage was crashing on setPage(0)

https://bugs.webkit.org/show_bug.cgi?id=36137

  • Api/qwebview.cpp: (QWebView::setPage):
06:58 Changeset [56059] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2010-03-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Errors when inspecting styles of non-renderable elements in XHTML.

https://bugs.webkit.org/show_bug.cgi?id=35025

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype._addAttribute): (WebInspector.DOMWindow.prototype.Object):
  • inspector/front-end/MetricsSidebarPane.js:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.callback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._update):
06:37 Changeset [56058] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed.

Fix Chromium Mac build: remove unused code.

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):
06:32 Changeset [56057] by tonikitoo@webkit.org
  • 6 edits in trunk

Spatial Navigation: Add a scrollIntoView call when focusing an element.
https://bugs.webkit.org/show_bug.cgi?id=36020

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

When focusing an element in Spatial Navigation logic, it is desired to make
this element visible in the current viewport. For that to happen, there
could be a call to Element's scrollIntoView method at focusing time. However
for visual aspects, it is preferable to scroll to an inflated rect of |element|
in order to consider the focus outline width.
As Element's scrollIntoView method does not provide this flexibility, patch adds
a custom scrollIntoView method to SpatialNavigation.h .

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

  • page/SpatialNavigation.cpp:

(WebCore::scrollIntoView):

  • page/SpatialNavigation.h:

LayoutTests:

  • platform/gtk/Skipped: Unskip snav-iframe-with-offscreen-element.html
05:10 Changeset [56056] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

[GStreamer] media/video-played-collapse.html
https://bugs.webkit.org/show_bug.cgi?id=36165

Skip apparently unreliable test. It used to fail locally and pass
on the bots, but the situation is inversed now. We need to
investigate this properly.

  • platform/gtk/Skipped:
04:57 Changeset [56055] by kov@webkit.org
  • 3 edits in trunk/WebCore

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Seidel.

[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372

Normalize timeout priorities through the GStreamer media player as
a whole. This should help avoid that any of them is starved.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::muteChanged):
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp: (webkit_video_sink_render):
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcNeedDataCb): (webKitWebSrcEnoughDataCb): (webKitWebSrcSeekDataCb):
04:45 Changeset [56054] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Seidel.

[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372

Use default priority also for parsing data: URIs.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startData):
04:44 Changeset [56053] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Seidel.

[GTK] Position queries are lagging
https://bugs.webkit.org/show_bug.cgi?id=34372

Normalize SharedTimers priorities to always be
G_PRIORITY_DEFAULT. As it is currently, timers that should happen
immediately (0 miliseconds delay) end up delayed by a lot of time
due to glib starving lower priority sources.

  • platform/gtk/SharedTimerGtk.cpp: (WebCore::setSharedTimerFireTime):
04:44 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
Make the new bug link easier to spot on the page (diff)
04:36 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
04:35 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
04:11 Changeset [56052] by xan@webkit.org
  • 4 edits in trunk

2010-03-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add support for Fast Mobile Scrolling in the build system.

  • configure.ac:

WebCore:

2010-03-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Add support for Fast Mobile Scrolling in the build system.

  • GNUmakefile.am:
03:59 Changeset [56051] by yurys@chromium.org
  • 62 edits
    2 copies
    1 add in trunk

2010-03-11 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

  • GNUmakefile.am:
  • WebCore.Inspector.exp:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::windowVisible): (WebCore::InspectorController::frontendReady): (WebCore::InspectorController::willCloseFrontend): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::setInspectorFrontendClient): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::setFrontend): (WebCore::InspectorController::show): (WebCore::InspectorController::close): (WebCore::InspectorController::releaseDOMAgent): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::enableDebugger):
  • inspector/InspectorController.h: (WebCore::InspectorController::hasInspectorFrontendClient):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::~InspectorFrontend): (WebCore::InspectorFrontend::addConsoleMessage): (WebCore::InspectorFrontend::bringToFront): (WebCore::InspectorFrontend::inspectedURLChanged):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendClient.h: Added. (WebCore::InspectorFrontendClient::~InspectorFrontendClient):
  • inspector/InspectorFrontendClientLocal.cpp: Added. (WebCore::FrontendMenuProvider::create): (WebCore::FrontendMenuProvider::disconnect): (WebCore::FrontendMenuProvider::FrontendMenuProvider): (WebCore::FrontendMenuProvider::~FrontendMenuProvider): (WebCore::FrontendMenuProvider::populateContextMenu): (WebCore::FrontendMenuProvider::contextMenuItemSelected): (WebCore::FrontendMenuProvider::contextMenuCleared): (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::windowObjectCleared): (WebCore::InspectorFrontendClientLocal::frontendLoaded): (WebCore::InspectorFrontendClientLocal::canAttachWindow): (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::moveWindowBy): (WebCore::InspectorFrontendClientLocal::showContextMenu): (WebCore::InspectorFrontendClientLocal::setAttachedWindow): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowHeight):
  • inspector/InspectorFrontendClientLocal.h: Added.
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::loaded): (WebCore::InspectorFrontendHost::attach): (WebCore::InspectorFrontendHost::detach): (WebCore::InspectorFrontendHost::closeWindow): (WebCore::InspectorFrontendHost::bringToFront): (WebCore::InspectorFrontendHost::inspectedURLChanged): (WebCore::InspectorFrontendHost::canAttachWindow): (WebCore::InspectorFrontendHost::setAttachedWindowHeight): (WebCore::InspectorFrontendHost::moveWindowBy): (WebCore::InspectorFrontendHost::showContextMenu):
  • inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::create):
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.bringToFront): (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.close): (WebInspector.bringToFront): (WebInspector.inspectedURLChanged):
  • loader/EmptyClients.h: (WebCore::EmptyInspectorClient::openInspectorFrontend):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::~Page):
  • page/Page.h:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::addInspectElementItem):

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::inspectorDestroyed): (WebInspectorClient::openInspectorFrontend): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::frontendLoaded): (WebInspectorFrontendClient::localizedStringsURL): (WebInspectorFrontendClient::hiddenPanels): (WebInspectorFrontendClient::bringToFront): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::setAttachedWindowHeight): (WebInspectorFrontendClient::inspectedURLChanged): (WebInspectorFrontendClient::updateWindowTitle): (-[WebInspectorWindowController dealloc]): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController close]): (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]): (-[WebInspectorWindowController attached]): (-[WebInspectorWindowController setFrontendClient:]): (-[WebInspectorWindowController destroyInspectorView]): (-[WebNodeHighlighter initWithInspectedWebView:]): (-[WebNodeHighlighter dealloc]): (-[WebNodeHighlighter highlightNode:]): (-[WebNodeHighlighter hideHighlight]): (-[WebNodeHighlighter didAttachWebNodeHighlight:]): (-[WebNodeHighlighter willDetachWebNodeHighlight:]):
  • WebInspector/WebInspector.mm: (-attach:): (-detach:):

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::WebInspectorClient): (WebInspectorClient::~WebInspectorClient): (WebInspectorClient::openInspectorFrontend): (WebInspectorClient::highlight): (WebInspectorClient::hideHighlight): (WebInspectorClient::updateHighlight): (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::~WebInspectorFrontendClient): (WebInspectorFrontendClient::frontendLoaded): (WebInspectorFrontendClient::localizedStringsURL): (WebInspectorFrontendClient::hiddenPanels): (WebInspectorFrontendClient::bringToFront): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::setAttachedWindowHeight): (WebInspectorFrontendClient::inspectedURLChanged): (WebInspectorFrontendClient::closeWindowWithoutNotifications): (WebInspectorFrontendClient::showWindowWithoutNotifications): (WebInspectorFrontendClient::destroyInspectorView): (WebInspectorFrontendClient::updateWindowTitle): (WebInspectorFrontendClient::onGetMinMaxInfo): (WebInspectorFrontendClient::onSize): (WebInspectorFrontendClient::onClose): (WebInspectorFrontendClient::onSetFocus): (WebInspectorFrontendClient::onWebViewWindowPosChanging): (WebInspectorWndProc): (WebInspectorFrontendClient::windowReceivedMessage):
  • WebCoreSupport/WebInspectorClient.h: (WebInspectorClient::frontendClosing):
  • WebInspector.cpp: (WebInspector::attach): (WebInspector::detach):

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

  • Api/qwebinspector.cpp: (QWebInspector::hideEvent): (QWebInspector::closeEvent):
  • Api/qwebinspector.h:
  • Api/qwebpage.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt): (WebCore::InspectorFrontendClientQt::frontendLoaded): (WebCore::InspectorFrontendClientQt::localizedStringsURL): (WebCore::InspectorFrontendClientQt::hiddenPanels): (WebCore::InspectorFrontendClientQt::bringToFront): (WebCore::InspectorFrontendClientQt::closeWindow): (WebCore::InspectorFrontendClientQt::attachWindow): (WebCore::InspectorFrontendClientQt::detachWindow): (WebCore::InspectorFrontendClientQt::setAttachedWindowHeight): (WebCore::InspectorFrontendClientQt::inspectedURLChanged): (WebCore::InspectorFrontendClientQt::updateWindowTitle):
  • WebCoreSupport/InspectorClientQt.h:

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::notifyWebViewDestroyed): (WebKit::InspectorClient::InspectorClient): (WebKit::InspectorClient::inspectorDestroyed): (WebKit::InspectorClient::openInspectorFrontend): (WebKit::InspectorClient::highlight): (WebKit::InspectorClient::hideHighlight): (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting): (WebKit::InspectorFrontendClient::InspectorFrontendClient): (WebKit::InspectorFrontendClient::~InspectorFrontendClient): (WebKit::InspectorFrontendClient::destroyInspectorWindow): (WebKit::InspectorFrontendClient::localizedStringsURL): (WebKit::InspectorFrontendClient::hiddenPanels): (WebKit::InspectorFrontendClient::bringToFront): (WebKit::InspectorFrontendClient::closeWindow): (WebKit::InspectorFrontendClient::attachWindow): (WebKit::InspectorFrontendClient::detachWindow): (WebKit::InspectorFrontendClient::setAttachedWindowHeight): (WebKit::InspectorFrontendClient::inspectedURLChanged):
  • WebCoreSupport/InspectorClientGtk.h:

2010-03-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.

Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036

  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::openInspectorFrontend):
  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::didCommitProvisionalLoad): (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy): (WebKit::WebDevToolsAgentImpl::setInspectorFrontendProxyToInspectorController):
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsBringToFront): (WebKit::WebDevToolsFrontendImpl::jsInspectedURLChanged):
  • src/WebDevToolsFrontendImpl.h:
  • src/js/InjectDispatch.js: (close):
03:17 Changeset [56050] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-16 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium tests fix.

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
02:32 Changeset [56049] by pfeldman@chromium.org
  • 19 edits in trunk

2010-03-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: migrate to native styles inspector in
order to inspect styles from foreighn domains.

https://bugs.webkit.org/show_bug.cgi?id=36117

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getStyles): (WebCore::InspectorBackend::getInlineStyle): (WebCore::InspectorBackend::getComputedStyle): (WebCore::InspectorBackend::applyStyleText): (WebCore::InspectorBackend::setStyleText): (WebCore::InspectorBackend::setStyleProperty): (WebCore::InspectorBackend::toggleStyleEnabled): (WebCore::InspectorBackend::setRuleSelector): (WebCore::InspectorBackend::addRule):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getInlineStyle): (WebCore::InspectorDOMAgent::getComputedStyle): (WebCore::InspectorDOMAgent::getMatchedCSSRules): (WebCore::InspectorDOMAgent::getAttributeStyles): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::bindStyle): (WebCore::InspectorDOMAgent::bindRule): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForRule): (WebCore::InspectorDOMAgent::uniqueStyleProperties): (WebCore::InspectorDOMAgent::longhandProperties): (WebCore::InspectorDOMAgent::shorthandPriority): (WebCore::InspectorDOMAgent::ruleAffectsNode): (WebCore::InspectorDOMAgent::toArray):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetEventListenersForNode): (WebCore::InspectorFrontend::didGetStyles): (WebCore::InspectorFrontend::didGetComputedStyle): (WebCore::InspectorFrontend::didGetInlineStyle): (WebCore::InspectorFrontend::didApplyStyleText): (WebCore::InspectorFrontend::didSetStyleText): (WebCore::InspectorFrontend::didSetStyleProperty): (WebCore::InspectorFrontend::didToggleStyleEnabled): (WebCore::InspectorFrontend::didSetRuleSelector): (WebCore::InspectorFrontend::didAddRule):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):
  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/InjectedScript.js:
  • inspector/front-end/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.callback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.callback): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
01:53 Changeset [56048] by hausmann@webkit.org
  • 2 edits in trunk

Add WebKitTools/TestResultServer/index.yaml to gitattributes to ignore for crlf conversion.

  • .gitattributes:
00:39 Changeset [56047] by hamaji@chromium.org
  • 4 edits in trunk/WebCore

2010-03-16 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

RenderText::m_text should be a String, not RefPtr<StringImpl>
https://bugs.webkit.org/show_bug.cgi?id=36010

Refactoring only, so no new tests.

  • platform/text/PlatformString.h: (WebCore::String::makeLower): (WebCore::String::makeUpper): (WebCore::String::makeSecure): (WebCore::String::makeCapitalized): (WebCore::String::containsOnlyASCII):
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::containsOnlyWhitespace): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::setText): (WebCore::RenderText::previousOffset): (WebCore::RenderText::previousOffsetForBackwardDeletion): (WebCore::RenderText::nextOffset):
  • rendering/RenderText.h: (WebCore::RenderText::text): (WebCore::RenderText::characters): (WebCore::RenderText::textLength):
00:27 Changeset [56046] by eric@webkit.org
  • 8 edits
    2 adds in trunk

2010-03-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092

Test that the noscript element renders when @sandbox disables
JavaScript.

  • fast/frames/sandboxed-iframe-noscript-expected.txt: Added.
  • fast/frames/sandboxed-iframe-noscript.html: Added.

2010-03-16 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noscript tag should render when @sandbox disables JavaScript
https://bugs.webkit.org/show_bug.cgi?id=36092

Instead of talking to Settings directly to figure out if JavaScript is
enabled in a frame, we need to talk to the ScriptController. The
ScriptController is better at answering that question because it knows
about @sandbox.

Test: fast/frames/sandboxed-iframe-noscript.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createRenderer):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsNeeded):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::isInline):
  • plugins/PluginView.cpp: (WebCore::PluginView::load):
00:11 Changeset [56045] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-15 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add "what-broke" command for debugging when the tree broke
https://bugs.webkit.org/show_bug.cgi?id=36157

This is another step towards automated sheriffing of the webkit tree.
With this logic our scripts are able to determine what revision broke the
tree. Buildbot should do this for us, but unfortunately buildbot doesn't
expose this kind of aggregate information.

  • Scripts/webkitpy/buildbot.py:
    • Add new Builder and Build classes (which will eventually replace the custom dictionaries previously used).
    • Split out more network logic into _fetch methods which will eventually be their own class for mocking.
    • Use XMLRPC to communicate with the buildbot master instead of scraping build pages.
  • Scripts/webkitpy/buildbot_unittest.py:
    • Test the newly added buildbot classes.
  • Scripts/webkitpy/commands/queries.py:
    • Add an experimental what-broke command.
00:08 Changeset [56044] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-15 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=36048

Detect if the Windows Platform SDK is missing when building with
Visual C++ Express Edition and inform the user to download it.

  • Scripts/webkitdirs.pm:

03/15/10:

23:42 Changeset [56043] by eric@webkit.org
  • 6 edits in trunk

2010-03-15 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

Notification object should expose absolute URL of icon
https://bugs.webkit.org/show_bug.cgi?id=35800

Covered by existing tests.

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/Notification.h: (WebCore::Notification::iconURL):

2010-03-15 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

Notification object should expose absolute URL of icon
https://bugs.webkit.org/show_bug.cgi?id=35800

  • public/WebNotification.h:
  • src/WebNotification.cpp: (WebKit::WebNotification::iconURL):
23:25 Changeset [56042] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-03-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to platform/efl.
http://webkit.org/b/35887

  • platform/efl/ClipboardEfl.cpp: Added.
  • platform/efl/PasteboardEfl.cpp: Added.
22:56 Changeset [56041] by tkent@chromium.org
  • 4 edits
    6 adds in trunk

2010-03-15 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Don't submit disabled menu options.
https://bugs.webkit.org/show_bug.cgi?id=35056

  • fast/forms/menulist-disabled-selected-option-expected.txt: Added.
  • fast/forms/menulist-disabled-selected-option.html: Added.
  • fast/forms/menulist-submit-without-selection-expected.txt: Added.
  • fast/forms/menulist-submit-without-selection.html: Added.
  • fast/forms/script-tests/menulist-disabled-selected-option.js: Added.
  • fast/forms/script-tests/menulist-submit-without-selection.js: Added.

2010-03-15 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

Don't submit disabled menu options.
https://bugs.webkit.org/show_bug.cgi?id=35056

Test: fast/forms/menulist-disabled-selected-option.html

  • dom/OptionElement.h:
  • dom/SelectElement.cpp: (WebCore::SelectElement::appendFormData): If a selected option is disabled, skip it. Remove code for non-selected menulist because of compatibility with other browsers.
22:55 Changeset [56040] by abarth@webkit.org
  • 7 edits in trunk/WebKitTools

2010-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Let commit-queue land rollout patches even when the tree is red
https://bugs.webkit.org/show_bug.cgi?id=36155

Now the commit-queue will land patches whose name begins with "ROLLOUT "
even if the tree is red. The patches still go through the usual build
and test process, but they can be landed while the tree is on fire.

  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/queuestest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
22:50 Changeset [56039] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-03-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to platform/efl.
http://webkit.org/b/35884

  • platform/efl/FileSystemEfl.cpp: Added.
22:33 Changeset [56038] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-03-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Holger Freyther.

Add EFL port files to platform/efl.
http://webkit.org/b/35882

  • platform/efl/ContextMenuItemEfl.cpp: Added.
22:32 Changeset [56037] by mjs@apple.com
  • 2 edits in trunk/WebKitSite

Tweak canvas perf demo.

  • demos/canvas-perf/canvas.html:
22:15 Changeset [56036] by eric@webkit.org
  • 4 edits in trunk

2010-03-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=35502
[Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText

Simple change to stop tables from implementing AtkText.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (getInterfaceMaskFromObject):

2010-03-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=35502
[Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText

New test to be sure we do not accidentally implement AtkText for tables

  • tests/testatk.c (testWebkitAtkGetTextInTable): (main):
21:58 Changeset [56035] by eric@webkit.org
  • 6 edits in trunk

2010-03-15 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Adam Barth.

According to the updated specification, a data field should always
result in a newline character being appended to the data buffer
regardless if the data buffer contains any data or not. However, upon
event dispatch, the last newline will be removed. This differs from an
older version of the specification where a newline character was
appended before the data value only if the buffer already contained
data. As a result, EventSource now supports receiving events with empty
data or newline characters only. Updated test accordingly.
https://bugs.webkit.org/show_bug.cgi?id=33210

  • http/tests/eventsource/eventsource-parse-event-stream-expected.txt:
  • http/tests/eventsource/eventsource-parse-event-stream.html:
  • http/tests/eventsource/resources/event-stream.php:

2010-03-15 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Adam Barth.

According to the updated specification, a data field should always
result in a newline character being appended to the data buffer
regardless if the data buffer contains any data or not. However, upon
event dispatch, the last newline will be removed. This differs from an
older version of the specification where a newline character was
appended before the data value only if the buffer already contained
data. As a result, EventSource now supports receiving events with empty
data or newline characters only.
https://bugs.webkit.org/show_bug.cgi?id=33210

  • page/EventSource.cpp: (WebCore::EventSource::parseEventStreamLine):
21:43 Changeset [56034] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add webkit-patch post-rollout to upload rollouts to bugs.webkit.org for easy committing
https://bugs.webkit.org/show_bug.cgi?id=36154

This new command is a mashup of prepare-rollout and post. This command
will be used by an experimental bot to post rollouts of patches that
break things to bugs.webkit.org where they can be landed with the
greatest of ease.

  • Scripts/webkitpy/commands/download.py:
  • Scripts/webkitpy/commands/download_unittest.py:
  • Scripts/webkitpy/steps/init.py:
  • Scripts/webkitpy/steps/postdiffforrevert.py: Added.
21:41 Changeset [56033] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-15 Valters Svabe <vsvabe@gmail.com>

Reviewed by Darin Adler.

:after selector displays in wrong place with nested div
https://bugs.webkit.org/show_bug.cgi?id=32288

  • fast/css-generated-content/block-after-expected.txt: Added.
  • fast/css-generated-content/block-after.html: Added.

2010-03-15 Valters Svabe <vsvabe@gmail.com>

Reviewed by Darin Adler.

:after selector displays in wrong place with nested div
https://bugs.webkit.org/show_bug.cgi?id=32288

Make sure we don't append things after :after-generated content, if
it's inside an anonymous block.

Test: fast/css-generated-content/block-after.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChild):
21:15 Changeset [56032] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch rollout should error out on conflicts
https://bugs.webkit.org/show_bug.cgi?id=36151

Instead of blindingly plowing ahead, we now throw an exception if there
are conflicts after applying a reverse diff.

  • Scripts/webkitpy/scm.py:
21:07 Changeset [56031] by eric@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2010-03-15 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add a function to create a BREW instance without local variable declarations.
https://bugs.webkit.org/show_bug.cgi?id=34705

Add a template function to create a BREW instance in one line.

  • wtf/brew/ShellBrew.h: Added. (WTF::createInstance):
20:27 Changeset [56030] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-15 Darin Fisher <darin@chromium.org>

Fix build bustage. We also need to pull down "third_party/tcmalloc"

  • DEPS:
19:36 Changeset [56029] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Not reviewed.

Removed a now-incorrect comment I forgot to remove in my last check-in.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::scavenge):

19:21 Changeset [56028] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed a portion of:
<rdar://problem/7165917> | https://bugs.webkit.org/show_bug.cgi?id=28676
Safari 4 does not release memory back to the operating system fast enough (28676)

Reviewed by Sam Weinig.

Every few seconds, release a percentage of the minimum unused page count
during that time period.

SunSpider reports no change, command-line or in-browser, Mac or Windows.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::init):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMalloc_PageHeap::initializeScavenger): Renamed shouldContinueScavenging
to shouldScavenge, since scavenging is no longer something that we interrupt.

(WTF::TCMalloc_PageHeap::scavenge): The new scavenging algorithm. Fixes
a bug where the old code would release only one item from each size class
per scavenge, potentially leaving large numbers of large-sized objects
unreleased for a long time.

(WTF::TCMalloc_PageHeap::shouldScavenge):
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::GrowHeap):
(WTF::TCMalloc_PageHeap::scavengerThread):
(WTF::TCMalloc_PageHeap::periodicScavenge): Updated to track the minimum
value of free_committed_pages_ during a given scavenge period.

17:06 Changeset [56027] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-15 Darin Fisher <darin@chromium.org>

Fix build bustage. We also need to pull down "gfx"

  • DEPS:
16:54 Changeset [56026] by cfleizach@apple.com
  • 4 edits in trunk

WebKitTools: Unreviewed layout test fix.

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

GTK needs to implement press for this test to work.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::press):

LayoutTests: Unreviewed.

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

GTK needs to implement press in DRT before this test can work.

  • platform/gtk/Skipped:
16:28 Changeset [56025] by cfleizach@apple.com
  • 4 edits in trunk

Unreviewed layout test fix.

WebKitTools:

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

Windows needs to implement press in DRT.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::press):

LayoutTests:

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

This test must be skipped until https://bugs.webkit.org/show_bug.cgi?id=36145 is done.

  • platform/win/Skipped:
16:28 Changeset [56024] by darin@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-03-15 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=36131
Update include paths for chromium Rect, Point, and Size types.

Update DEPS to pull latest chromium code that reflects the
new location of these headers.

  • DEPS:
  • public/WebPoint.h:
  • public/WebRect.h:
  • public/WebSize.h:
16:20 Changeset [56023] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-03-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Eric Seidel.

Add EFL port files to platform/efl.
http://webkit.org/b/35885

  • platform/efl/KURLEfl.cpp: Added.
16:06 Changeset [56022] by cfleizach@apple.com
  • 3 edits in trunk/WebKitTools

Unreviewed. Fix break of layout tests on win and gtk.

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

Attempting to implement press action for windows and gtk.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::press):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::press):

15:59 Changeset [56021] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=35843
Re-land reverted fix to JSString::getIndex()

Reviewed by Sam Weinig.

Calling getIndex() on a JSString in rope form may result in a JSException being thrown
if there is insuficient memory so value(exec) returns UString() with length zero,
which will be passed to jsSingleCharacterSubstring.
Add a slow case function to trap the error & return a safe null value, until the
exception is handled.

  • runtime/JSString.cpp:

(JSC::JSString::getIndexSlowCase):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):

15:38 Changeset [56020] by cfleizach@apple.com
  • 6 edits in trunk/WebKitTools

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

Reviewed by Beth Dakin.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(pressCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::press):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::press):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::press):

15:07 Changeset [56019] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

VO not able to perform a VO-spacebar on facebook links
https://bugs.webkit.org/show_bug.cgi?id=36132

Reviewed by Beth Dakin.

WebCore:

When a label element is used as a click event handler, and it doesn't have any
corresponding control, it should handle the action itself.

Test: accessibility/label-element-press.html

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::accessKeyAction):

LayoutTests:

  • accessibility/label-element-press-expected.txt: Added.
  • accessibility/label-element-press.html: Added.
14:56 Changeset [56018] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2010-03-15 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 36135 - GCController::garbageCollectNow() crashes when called from garbage collection
<https://bugs.webkit.org/show_bug.cgi?id=36135>
<rdar://problem/7752552>

  • bindings/js/GCController.cpp:

(WebCore::GCController::garbageCollectNow): Fail silently if garbage collection is
active rather than hitting the CRASH() reentrancy guard.

14:47 Changeset [56017] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-03-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Drop out of compositing mode when no elements need to composite
https://bugs.webkit.org/show_bug.cgi?id=36134

When no more elements on the page need to be composited, drop out of compositing
mode altogether, including removing the layer-backed view that hosts the layers.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): If the list of child layers to attach at the root is empty, we have no composited layers, and can drop out of compositing mode by calling willMoveOffscreen().

(WebCore::RenderLayerCompositor::computeCompositingRequirements): In several places,
use willBeComposited rather than calling needsToBeComposited(), because it avoids
recomputing state that we know already (but assert that we're getting it right).
When we're assessing the root layer in post-order, see if we have any child layers that
are compositing, and also whether the root itself needs to composite. If neither are
true, then we can drop out of compositing mode.

(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Move the
"inCompositingMode() && layer->isRootLayer()" test out of requiresCompositingLayer()
and into needsToBeComposited() so that we can call requiresCompositingLayer() separately
on the root layer above.

14:33 Changeset [56016] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-03-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to platform/efl.
http://webkit.org/b/35888

  • platform/efl/SoundEfl.cpp: Added.
14:21 Changeset [56015] by kenneth@webkit.org
  • 2 edits in trunk/JavaScriptCore

Add a long long version of abs() for MSVC.

Reviewed by Adam Roben.

  • wtf/MathExtras.h:

(abs):

14:02 Changeset [56014] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Add a new build slave to replace the existing SnowLeopard Leaks build slave which
appears to be suffering a slow and painful death at the hands of its graphics hardware.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
14:01 Changeset [56013] by simon.fraser@apple.com
  • 19 edits
    2 adds in trunk/LayoutTests

2010-03-15 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Dan Bernstein.

Update some pixel results for composting tests; some were incorrect, and others had minor
pixel differences.

  • platform/mac/compositing/color-matching/image-color-matching-expected.checksum:
  • platform/mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/mac/compositing/direct-image-compositing-expected.checksum:
  • platform/mac/compositing/direct-image-compositing-expected.png:
  • platform/mac/compositing/overflow/overflow-scroll-expected.checksum:
  • platform/mac/compositing/overflow/overflow-scroll-expected.png:
  • platform/mac/compositing/reflections/animation-inside-reflection-expected.checksum:
  • platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.checksum:
  • platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-animated-expected.checksum:
  • platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
  • platform/mac/compositing/reflections/nested-reflection-transition-expected.checksum:
  • platform/mac/compositing/reflections/nested-reflection-transition-expected.png:
  • platform/mac/compositing/reflections/reflection-on-composited-expected.checksum:
  • platform/mac/compositing/reflections/reflection-on-composited-expected.png:
  • platform/mac/compositing/repaint/become-overlay-composited-layer-expected.checksum: Added.
  • platform/mac/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
  • platform/mac/compositing/repaint/layer-repaint-rects-expected.checksum:
  • platform/mac/compositing/repaint/layer-repaint-rects-expected.png:
13:31 Changeset [56012] by enrica@apple.com
  • 18 edits
    4 adds in trunk

WebCore: For continuous scrolling devices on the Mac (trackpads and Mighty/Magic
Mice), set the number of wheel ticks equal to the atomic increment of
the device: a pixel. This ensures that any scrolling action will
generate at least one wheel tick, regardless of the speed/length of
the gesture.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>

Tests: fast/events/continuous-platform-wheelevent-in-scrolling-div.html

fast/events/platform-wheelevent-in-scrolling-div.html

  • platform/mac/WebCoreSystemInterface.h: Modify method signature.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Call into
WebKitSystemInterface to determine both wheelTicksX/Y and deltaX/Y.
WKSI will query the event system for number of wheel ticks and
pixels/lines scrolled based on the device type.

WebKit/mac: Updated call to WKGetWheelEventDeltas() to match new method signature.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView scrollWheel:]):

WebKitLibraries: Added two new output arguments to WKGetWheelEventDeltas() to return
the number of scroll wheel ticks in the x and y directions.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601.
<rdar://problem/7453254>

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

LayoutTests: These tests verify that scrollwheel events (both continuous and
non-continuous) generate the expected pixel deltas in scrollable
regions, and also generate DOM mousewheel events with expected
wheelDelta values.

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=29601
<rdar://problem/7453254>

  • fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Added.
  • fast/events/continuous-platform-wheelevent-in-scrolling-div.html: Added.
  • fast/events/platform-wheelevent-in-scrolling-div-expected.txt: Added.
  • fast/events/platform-wheelevent-in-scrolling-div.html: Added.
  • fast/events/wheelevent-in-scrolling-div-expected.txt: Rebased

expected results due to change in test output formatting.

  • fast/events/wheelevent-in-scrolling-div.html: Modified to use common

js logging and assertion functions.

  • platform/gtk/Skipped: DRT support needed by tests not yet implemented

in GTK port. See https://bugs.webkit.org/show_bug.cgi?id=36003.

  • platform/mac-tiger/Skipped: DRT support needed by tests not possible

to implement in Tiger.

  • platform/qt/Skipped: DRT support for tests not yet implemented in Qt

port. See https://bugs.webkit.org/show_bug.cgi?id=36004.

  • platform/win/Skipped: DRT support for tests not yet implemented in

Windows port. See https://bugs.webkit.org/show_bug.cgi?id=36002.

13:30 Changeset [56011] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-15 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
https://bugs.webkit.org/show_bug.cgi?id=36012

  • public/GeolocationServiceBridgeChromium.h:
  • src/GeolocationServiceBridgeChromium.cpp: (WebKit::GeolocationServiceBridgeImpl::startUpdating):
13:18 Changeset [56010] by philn@webkit.org
  • 3 edits in trunk/WebCore

2010-03-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] duration query optimizations
https://bugs.webkit.org/show_bug.cgi?id=36116

Don't reattempt duration queries that previously failed and cache
media duration only if it's known.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::durationChanged):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
13:11 Changeset [56009] by philn@webkit.org
  • 3 edits in trunk/WebCore

2010-03-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] updateStates called for all elements posting a state-change
https://bugs.webkit.org/show_bug.cgi?id=36115

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): Update player state only for state-change messages coming from playbin2 directly.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: (WebCore::MediaPlayerPrivate::pipeline): public accessor for the playbin element.
13:10 Changeset [56008] by sullivan@apple.com
  • 5 edits in trunk/WebKit/mac

-[WebFrame setAlwaysHideHorizontal/VerticalScroller:] prevents keyboard scrolling
<https://bugs.webkit.org/show_bug.cgi?id=36125>

Reviewed by Adam Roben.

  • WebView/WebDynamicScrollBarsView.h:

Added instance variables horizontalScrollingAllowedButScrollerHidden and
verticalScrollingAllowedButScrollerHidden. Renamed instance variables
hideHorizontal/VerticalScroller to alwaysHideHorizontal/VerticalScroller for clarity.
Declared methods -horizontalScrollingAllowed and -verticalScrollingAllowed.
Added comments.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
Updated for instance variable renaming.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
Ditto.
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
New method, returns YES if the scroller is showing or the only reason that the scroller
is not showing is that setAlwaysHideHorizontalScrolling has been called.
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
New method, returns YES if the scroller is showing or the only reason that the scroller
is not showing is that setAlwaysHideVerticalScrolling has been called.
(-[WebDynamicScrollBarsView updateScrollers]):
Updated for instance variable renamings. Now updates horizontalScrollingAllowedButScrollerHidden
and verticalScrollingAllowedButScrollerHidden. Now takes the always-hidden state into account
in the early-return code path, to avoid taking it into account twice in the regular code path.

  • WebView/WebFrameView.mm:

(-[WebFrameView _scrollToBeginningOfDocument]):
Use _isScrollable instead of _hasScrollBars.
(-[WebFrameView _scrollToEndOfDocument]):
Ditto.
(-[WebFrameView scrollToBeginningOfDocument:]):
Use _largestScrollableChild instead of _largestChildWithScrollBars.
(-[WebFrameView scrollToEndOfDocument:]):
Ditto.
(-[WebFrameView _pageVertically:]):
Use _isScrollable and _largestScrollableChild instead of _hasScrollBars
and _largestChildWithScrollBars.
(-[WebFrameView _pageHorizontally:]):
Ditto.
(-[WebFrameView _scrollLineVertically:]):
Ditto.
(-[WebFrameView _scrollLineHorizontally:]):
Ditto.
(-[WebFrameView keyDown:]):
Use _largestScrollableChild instead of _largestChildWithScrollBars.
(-[WebFrameView _isScrollable]):
New method, calls -[WebDynamicScrollBarsView horizontalScrollingAllowed] and
-[WebDynamicScrollBarsView verticalScrollingAllowed]
(-[WebFrameView _largestScrollableChild]):
New method, like _largestChildWithScrollBars but uses _isScrollable.
(-[WebFrameView _hasScrollBars]):
Added a comment that this is no longer used by Safari, and can thus probably be
deleted once we no longer want to support it for nightly build compatibility with
old versions of Safari.
(-[WebFrameView _largestChildWithScrollBars]):
Ditto.

  • WebView/WebFrameViewPrivate.h:

Declared -_isScrollable and -_largestScrollableChild. Added comments to
_hasScrollBars and _largestChildWithScrollBars saying that they are no longer
used by Safari, and can thus probably be deleted once we no longer want to
support them for nightly build compatibility with old versions of Safari.

13:08 Changeset [56007] by pkasting@chromium.org
  • 10 edits in trunk/WebCore

Clean up more bits of the open-source image decoders. In addition to
simplifying things somewhat, this makes all the decoders the same in
terms of how they construct "image reader" subclasses and init scale
data.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36040

No functional change, so no tests.

  • platform/image-decoders/ImageDecoder.h: Reorder a few declarations to try and group/order members slightly better.

(WebCore::ImageDecoder::ImageDecoder):

  • platform/image-decoders/gif/GIFImageDecoder.cpp: Move reader construction into decode(). Prep scale data in setSize(). Remove useless comment.

(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::setSize):
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::decode):

  • platform/image-decoders/gif/GIFImageDecoder.h: Prep scale data in setSize().
  • platform/image-decoders/gif/GIFImageReader.cpp: Prep scale data in setSize().

(GIFImageReader::read):

  • platform/image-decoders/ico/ICOImageDecoder.cpp: Shorten code.

(WebCore::ICOImageDecoder::setSize):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Fix style. Move reader construction into decode().

(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::skipBytes):
(WebCore::JPEGImageDecoder::decode):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h: Move reader construction into decode().

(WebCore::JPEGImageDecoder::filenameExtension):

  • platform/image-decoders/png/PNGImageDecoder.cpp: Move reader construction into decode(). Track completion on decoder, not reader. Prep scale data in setSize(). Remove useless comment.

(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::setSize):
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::pngComplete):
(WebCore::PNGImageDecoder::decode):

  • platform/image-decoders/png/PNGImageDecoder.h: Move reader construction into decode(). Track completion on decoder, not reader. Prep scale data in setSize().

(WebCore::PNGImageDecoder::filenameExtension):
(WebCore::PNGImageDecoder::isComplete):

13:00 Changeset [56006] by philn@webkit.org
  • 2 edits in trunk/WebCore

2010-03-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] video playback position query flood when mouse over the video element
https://bugs.webkit.org/show_bug.cgi?id=35333

Don't trigger a position query only to know which play/pause
button to display.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMediaPlayButton):
12:57 Changeset [56005] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-15 Dirk Pranke <dpranke@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix a minor case where we'd deference a null pointer if we tried
to run new-run-webkit-tests on an unsupported platform (e.g.
Cygwin's python version).

https://bugs.webkit.org/show_bug.cgi?id=36076

  • Scripts/webkitpy/layout_tests/port/factory.py:
10:27 Changeset [56004] by jianli@chromium.org
  • 5 edits
    1 add in trunk/WebCore

[v8] Add V8 bindings for DOMFormData.
https://bugs.webkit.org/show_bug.cgi?id=36026

Reviewed by Nate Chapin.

Test: http/tests/local/send-form-data.html

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

10:27 Changeset [56003] by jianli@chromium.org
  • 29 edits
    6 adds in trunk

WebCore: Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata

Test: http/tests/local/send-form-data.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMFormDataCustom.cpp: Added.
  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/DOMFormData.idl: Added.
  • page/DOMWindow.idl:

LayoutTests: Add DOMFormData.idl to expose FormData interface
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

Add a layout test to test sending FormData via XMLHttpRequest. Also
changed all test results that are affected by exposing FormData.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/resources/send-form-data.js: Added.
  • http/tests/local/send-form-data-expected.txt: Added.
  • http/tests/local/send-form-data.html: Added.
  • http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/Skipped:
10:14 Changeset [56002] by eric@webkit.org
  • 14 edits in trunk

2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32369

Revised test of storage/databases in sandboxed iframes.

Verify that SECURITY_ERR is raised on access to
window.localStorage or window.openDatabase(). Also verify that
window.sessionStorage is now allowed in sandboxed iframes.

WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:

  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html: expect exceptions, not null
  • fast/frames/sandboxed-iframe-storage-expected.txt: expect exceptions, not null

2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32369

Revise iframe sandbox behavior to match the updated HTML5 spec.

  • Enables window.sessionStorage in sandboxed iframes.
  • Raises SECURITY_ERR exceptions when window.localStorage or window.openDatabase() is blocked by iframe sandboxing.

Note: window.sessionStorage does not raise exceptions.

WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:

http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
http://dev.w3.org/html5/webdatabase/ (section 4.1)
http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html

  • inspector/InspectorController.cpp: (WebCore::InspectorController::selectDOMStorage): exception handling
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::handleEvent): exception handling
  • page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): re-enabled in iframe sandbox (WebCore::DOMWindow::localStorage): raise exception rather than return null (WebCore::DOMWindow::openDatabase): raise exception rather than return null
  • page/DOMWindow.h: added exceptions to interface
  • page/DOMWindow.idl: added exceptions to interface
  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessLocalStorage): renamed function to reflect its purpose
  • storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch): exception handling

2010-03-15 Patrik Persson <patrik.j.persson@ericsson.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32369

Revise iframe sandbox behavior to match the updated HTML5 spec.

  • Enables window.sessionStorage in sandboxed iframes.
  • Raises SECURITY_ERR exceptions when window.localStorage or window.openDatabase() is blocked by iframe sandboxing.

Note: window.sessionStorage does not raise exceptions.

WebKit would previously return null references in these cases. The
new behavior is in accordance with HTML5:

http://dev.w3.org/html5/webstorage/ (sections 4.2 and 4.3)
http://dev.w3.org/html5/webdatabase/ (section 4.1)
http://www.mail-archive.com/whatwg@lists.whatwg.org/msg19786.html

  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent): exception handling
  • src/StorageEventDispatcherImpl.cpp: (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent): exception handling
09:41 Changeset [56001] by darin@apple.com
  • 3 edits in trunk/WebKitTools

Tell Subversion about more directories that expect to have .pyc files.

  • Scripts/webkitpy/layout_tests: Added property svn:ignore.
  • Scripts/webkitpy/layout_tests/port: Added property svn:ignore.
09:33 Changeset [56000] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-15 Gabor Loki <loki@webkit.org>

Reviewed by Gavin Barraclough.

Combine ctiTrampolines on ARM and Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=36014

  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
09:22 Changeset [55999] by apavlov@chromium.org
  • 9 edits
    1 add in trunk/WebCore

2010-03-15 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement a progress indicator in the Audits panel
when resources are reloading
https://bugs.webkit.org/show_bug.cgi?id=35971

  • English.lproj/localizedStrings.js:
  • GNUmakefile.am:
  • WebCore.gypi:
  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState): (WebInspector.AuditLauncherView.prototype.get totalResources): (WebInspector.AuditLauncherView.prototype.set totalResources): (WebInspector.AuditLauncherView.prototype.get loadedResources): (WebInspector.AuditLauncherView.prototype.set loadedResources): (WebInspector.AuditLauncherView.prototype._resetResourceCount): (WebInspector.AuditLauncherView.prototype.resourceStarted): (WebInspector.AuditLauncherView.prototype.resourceFinished): (WebInspector.AuditLauncherView.prototype.reset): (WebInspector.AuditLauncherView.prototype._setAuditRunning): (WebInspector.AuditLauncherView.prototype._launchButtonClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI): (WebInspector.AuditLauncherView.prototype._updateResourceProgress): (WebInspector.AuditLauncherView.prototype._updateButton):
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype.resourceStarted): (WebInspector.AuditsPanel.prototype.resourceFinished): (WebInspector.AuditsPanel.prototype.reset):
  • inspector/front-end/Images/spinner.gif: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/audits.css: (.audit-launcher-view .resource-progress > img):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
08:55 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
08:54 Changeset [55998] by eric@webkit.org
  • 4 edits in trunk

2010-03-15 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

option-pageup/down should move cursor on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=36108

Remove waitUntilDone/notifyDone from the layout test, it's not needed
and causes timeouts on failure.

  • editing/input/option-page-up-down.html:

2010-03-15 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

option-pageup/down should move cursor on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=36108

  • src/EditorClientImpl.cpp: (WebKit::):
08:40 Changeset [55997] by sullivan@apple.com
  • 5 edits in trunk/WebKit/mac

Method name and parameter name mistakes from recent SPI addition
<https://bugs.webkit.org/show_bug.cgi?id=36119>

Reviewed by Dan Bernstein.

  • WebView/WebDynamicScrollBarsView.h:

Renamed instance variable and method name from "setAllowXXX" to "setAllowsXXX".

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
Updated for renamed instance variable and method.
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
Changed parameter name from shouldBeVisible to shouldBeHidden.
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
Ditto.
(-[WebDynamicScrollBarsView contentViewFrame]):
Updated for renamed instance variable.
(-[WebDynamicScrollBarsView tile]):
Ditto.
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
Ditto.

  • WebView/WebFrame.mm:

(-[WebFrame setAllowsScrollersToOverlapContent:]):
Renamed method from setAllowXXX, and updated for same change in WebDynamicScrollBarsView.

  • WebView/WebFramePrivate.h:

Renamed method name from "setAllowXXX" to "setAllowsXXX".

08:34 Changeset [55996] by philn@webkit.org
  • 3 edits in trunk/WebCore

2010-03-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] replace g_idle_add / g_timeout_add calls with Timers in the gstreamer player
https://bugs.webkit.org/show_bug.cgi?id=35735

Replaced g_idle_add calls with Timers immediately started once
only. The g_timeout_add was replaced by a periodic Timer.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::volumeChangedTimerFired): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::processBufferingStats): (WebCore::MediaPlayerPrivate::fillTimerFired): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::muteChangedTimerFired): (WebCore::MediaPlayerPrivate::muteChanged):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
08:20 Changeset [55995] by kov@webkit.org
  • 5 edits in trunk

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

media/video-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=35793

Only effectively load, and start buffering when playing, or when
the preload attribute is set.

Test: media/video-preload.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::commitLoad): (WebCore::MediaPlayerPrivate::prepareToPlay): (WebCore::MediaPlayerPrivate::setPreload):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
07:46 Changeset [55994] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-03-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

[Qt] Build fix if TILED_BACKING_STORE is disabled.

  • Api/qwebframe.cpp: (QWebFramePrivate::renderContentsLayerAbsoluteCoords):
07:34 Changeset [55993] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-03-15 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Holger Freyther.

[Qt] Change and add expected results after the fix and also remove the test from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=36060

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.checksum: Added.
  • platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.png: Added.
  • platform/qt/fast/canvas/fillrect-gradient-zero-stops-expected.txt:

2010-03-15 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Holger Freyther.

[Qt] The behavior of QGradient with no stops is defined differently from HTML5 spec,
where the latter requires the gradient to be transparent black. Explicitly added a
transparent black color stop to match the HTML5 behavior.
https://bugs.webkit.org/show_bug.cgi?id=36060

  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
07:13 Changeset [55992] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Some minor code clean ups in SpatialNavigation.cpp

Rubber-stamped by Holger Freyther.
Patch by Antonio Gomes <tonikitoo@webkit.org>

  • page/SpatialNavigation.cpp:

(WebCore::distanceInDirection):
(WebCore::deflateIfOverlapped):

06:02 Changeset [55991] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Position of GraphBar elements is calculating more carefully
and they fully visible at the bottom of Timeline panel.


http://bugs.webkit.org/show_bug.cgi?id=35966

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelineRecordGraphRow.prototype.update):
02:10 Changeset [55990] by eric@webkit.org
  • 6 edits in trunk

2010-03-15 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

Selection.modify extends too far with 'lineboundary'.
https://bugs.webkit.org/show_bug.cgi?id=33413

  • editing/selection/extend-selection-expected.txt:
  • platform/win/editing/selection/extend-selection-expected.txt: Updated result to correct expectation that described the wrong behaviour for the selection expansion with 'lineboundary' granularity.

2010-03-15 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

Selection.modify extends too far with 'lineboundary'.
https://bugs.webkit.org/show_bug.cgi?id=33413

Selection.modify() with 'lineboundary' granularity implies just
"Go to the end of the line", unlike selection expansion with
other type of granularities. This change handled LineGranularity
as special case, to look-up end of line with UPSTREAM affinity.
Doing this prevents look-up algorithm to go next line.

Test: editing/selection/extend-selection-expected.txt

  • dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): Handled an edge case for node look-up with UPSTREAM.
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): Added UPSTREAM tweak for the case for LineGranularity.
01:34 Changeset [55989] by philn@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-03-09 Philippe Normand <pnormand@igalia.com>

Reviewed by Holger Freyther.

[GTK] GTK_WIDGET_IS_SENSITIVE is deprecated in GTK+ 2.20
https://bugs.webkit.org/show_bug.cgi?id=35909

  • webkit/webkitwebview.cpp: GTK_WIDGET_IS_SENSITIVE has been deprecated in gtk 2.20. Use gtk_widget_is_sensitive when available.
01:33 Changeset [55988] by yuzo@google.com
  • 6 edits
    5 adds in trunk

2010-03-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Always call PrintContext.end() from PrintContext::pageNumberForElement().

Without this change, WebKit remains in printing mode after determining the page number if the specified element is found.

https://bugs.webkit.org/show_bug.cgi?id=36049

  • platform/gtk/Skipped:
  • platform/mac/printing/return-from-printing-mode-expected.checksum: Added.
  • platform/mac/printing/return-from-printing-mode-expected.png: Added.
  • platform/mac/printing/return-from-printing-mode-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • printing/return-from-printing-mode.html: Added.

2010-03-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Always call PrintContext.end() from PrintContext::pageNumberForElement().

Without this change, WebKit remains in printing mode after determining the page number if the specified element is found.

https://bugs.webkit.org/show_bug.cgi?id=36049

Test: printing/return-from-printing-mode.html

  • page/PrintContext.cpp: (WebCore::PrintContext::pageNumberForElement):
01:19 Changeset [55987] by philn@webkit.org
  • 2 edits in trunk/WebCore

2010-03-11 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] progressTimer never stopped after EOS
https://bugs.webkit.org/show_bug.cgi?id=36007

Mark the pipeline as paused only if playback hasn't ended
yet. When didEnd() is triggered, the pipeline is paused (but
paused() still returns false) and a timeupdate event is fired,
those 2 conditions allow the HTMLMediaElement to stop the
progressTimer (in updatePlayerState, via mediaPlayerTimeChanged).

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::updateStates):
00:28 Changeset [55986] by eric@webkit.org
  • 1 edit
    5 adds in trunk/WebKitTools

2010-03-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Operational scripts from running the EWS
https://bugs.webkit.org/show_bug.cgi?id=36097

These are the scripts I use to manage the EWS on EC2. If someone other
than me wants to run the EWS, these scripts might be helpful.

  • EWSTools/boot.sh: Added.
  • EWSTools/create-webkit-git: Added.
  • EWSTools/screen-config: Added.
  • EWSTools/start-queue.sh: Added.
00:04 Changeset [55985] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2010-03-14 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Remove unneeded dependency on non-string identifier for an NSTableColumn
https://bugs.webkit.org/show_bug.cgi?id=36106

  • WebView/WebTextCompletionController.mm: (-[WebTextCompletionController _buildUI]): Use init instead of initWithIdentifier: because the table has only one column and that column does not need an identifier.

03/14/10:

23:19 Changeset [55984] by mjs@apple.com
  • 1 edit
    3 adds in trunk/WebKitSite

Added canvas perf demo for whatwg.

  • demos/canvas-perf: Added.
  • demos/canvas-perf/canvas.html: Added.
  • demos/canvas-perf/kraken.jpg: Added.
23:16 Changeset [55983] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-14 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix the webkit-patch bots. Turns out they need the path of the main
script to run properly.

  • Scripts/webkit-patch:
  • Scripts/webkitpy/patch/patcher.py:
22:58 Changeset [55982] by darin@apple.com
  • 5 edits in trunk/WebKitTools

Tell Subversion about more directories that expect to have .pyc files.

  • Scripts/webkitpy/init: Added property svn:ignore.
  • Scripts/webkitpy/patch: Added property svn:ignore.
  • Scripts/webkitpy/thirdparty: Added property svn:ignore.
  • Scripts/webkitpy/thirdparty/autoinstalled: Added property svn:ignore.
18:28 Changeset [55981] by eric@webkit.org
  • 5 edits in trunk

2010-03-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Simon Hausmann.

[Qt] [Symbian] Added block for ENABLE_SYMBIAN_DIALOG_PROVIDERS
on Symbian platform.
https://bugs.webkit.org/show_bug.cgi?id=35919

  • WebCore.pro:

2010-03-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Simon Hausmann.

[Qt] [Symbian] Use Symbian native dialog providers for combo pupups.
https://bugs.webkit.org/show_bug.cgi?id=35919

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): (WebCore::ResetAndDestroy): (WebCore::QtFallbackWebPopup::showS60BrowserDialog):
  • WebCoreSupport/QtFallbackWebPopup.h:
18:00 Changeset [55980] by yael.aharon@nokia.com
  • 28 edits
    16 adds in trunk

Support for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=35937

Reviewed by Darin Adler.

WebCore:

Added support for HTMLProgressElement.
This implementation is enabled only for Qt, because only RenderThemeQt
was modified to actually draw the progress element.
The labels attribute of the progress element will be implemented in a
separate patch.

Tests: fast/dom/HTMLProgressElement/progress-element.html

fast/dom/HTMLProgressElement/set-progress-properties.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::extractPseudoType):

  • css/CSSValueKeywords.in:
  • css/html.css:
  • html/HTMLElement.cpp:

(WebCore::inlineTagList):

  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLProgressElement.cpp: Added.
  • html/HTMLProgressElement.h: Added.
  • html/HTMLProgressElement.idl: Added.
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:
  • platform/ThemeTypes.h:
  • platform/qt/RenderThemeQt.cpp:
  • platform/qt/RenderThemeQt.h:
  • rendering/RenderObject.h:
  • rendering/RenderProgress.cpp: Added.
  • rendering/RenderProgress.h: Added.
  • rendering/RenderTheme.cpp:
  • rendering/RenderTheme.h:

LayoutTests:

  • fast/dom/HTMLProgressElement: Added.
  • fast/dom/HTMLProgressElement/progress-element.html: Added.
  • fast/dom/HTMLProgressElement/script-tests: Added.
  • fast/dom/HTMLProgressElement/script-tests/TEMPLATE.html: Added.
  • fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js: Added.
  • fast/dom/HTMLProgressElement/set-progress-properties.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/fast/dom/HTMLProgressElement: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/qt/fast/dom/HTMLProgressElement/set-progress-properties-expected.txt: Added.
17:53 Changeset [55979] by antti@apple.com
  • 5 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store

Reviewed by Simon Hausmann.

QtLauncher support and build flag in build-webkit.

  • QtLauncher/main.cpp:

(LauncherWindow::applyPrefs):
(LauncherWindow::toggleTiledBackingStore):
(LauncherWindow::toggleResizesToContents):
(LauncherWindow::createChrome):
(LauncherApplication::handleUserOptions):

  • QtLauncher/webview.cpp:

(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::setResizesToContents):
(WebViewGraphicsBased::resizeEvent):

  • QtLauncher/webview.h:
  • Scripts/build-webkit:
17:51 Changeset [55978] by antti@apple.com
  • 6 edits in trunk/WebKit/qt

https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store

Reviewed by Simon Hausmann.

Implements a basic tiled backing store mechanism. Tiles are created and
deleted on demand. The page content is cached to the tiles. Tile content
is kept in sync with the document. Since the backing store covers area
larger than the currently visible viewport, the document can be scrolled
quickly without having to enter rendering tree painting.

The tile management code is platform independent. This patch has simple QPixmap
based tile implementation for Qt.

The feature is behind ENABLE_TILED_BACKING_STORE flag.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::visibleRect):
(QGraphicsWebView::paint):

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderContentsLayerAbsoluteCoords):

  • Api/qwebframe.h:
  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

  • Api/qwebsettings.h:
17:01 Changeset [55977] by oliver@apple.com
  • 7 edits in trunk

2010-03-14 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION(r53287): drop event is not fired if dataTransfer.dropEffect is not explicitly set
https://bugs.webkit.org/show_bug.cgi?id=36095

Correct this test to cover the somewhat bizarre "correct" handling
of undefined dropEffect

  • fast/events/drag-and-drop-expected.txt:
  • fast/events/drag-and-drop.html:

2010-03-14 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION(r53287): drop event is not fired if dataTransfer.dropEffect is not explicitly set
https://bugs.webkit.org/show_bug.cgi?id=36095

The issue here is that while dropEffect is meant to be initialized
to "none", the behaviour of the drag is differs between dragEffect
not being set and dragEffect being explicitly set to "none"

This patch corrects this behaviour by making Clipboard distinguish
between the initial "none" value of dropEffect and an explicit "none".
This alone is insufficient for correct behaviour, we also need to
resurrect the removed defaultOperationForDrag function, but we now
use the function only when dragEffect is uninitialized. There are a
few tweaks to the behaviour of the defaultOperationForDrag as well
to ensure exactly the same set of outcomes for all cases that we
may hit it.

  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): (WebCore::dragOpFromIEOp): (WebCore::Clipboard::destinationOperation):
  • dom/Clipboard.h: (WebCore::Clipboard::dropEffect): (WebCore::Clipboard::dropEffectIsUninitialized):
  • page/DragController.cpp: (WebCore::defaultOperationForDrag): (WebCore::DragController::tryDHTMLDrag):
16:40 Changeset [55976] by antti@apple.com
  • 8 edits
    5 adds in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=35146
Support tiled backing store

Reviewed by Simon Hausmann.

Implements a basic tiled backing store mechanism. Tiles are created and
deleted on demand. The page content is cached to the tiles. Tile content
is kept in sync with the document. Since the backing store covers area
larger than the currently visible viewport, the document can be scrolled
quickly without having to enter rendering tree painting.

The tile management code is platform independent. This patch has simple QPixmap
based tile implementation for Qt.

The feature is behind ENABLE_TILED_BACKING_STORE flag.

  • WebCore.pri:
  • WebCore.pro:
  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::setTiledBackingStoreEnabled):
(WebCore::Frame::tiledBackingStorePaintBegin):
(WebCore::Frame::tiledBackingStorePaint):
(WebCore::Frame::tiledBackingStorePaintEnd):
(WebCore::Frame::tiledBackingStoreContentsRect):

  • page/Frame.h:

(WebCore::Frame::tiledBackingStore):

  • page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::doDeferredRepaints):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setTiledBackingStoreEnabled):

  • page/Settings.h:

(WebCore::Settings::tiledBackingStoreEnabled):

  • platform/graphics/Tile.h: Added.

(WebCore::Tile::create):
(WebCore::Tile::coordinate):
(WebCore::Tile::rect):

  • platform/graphics/TiledBackingStore.cpp: Added.

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::~TiledBackingStore):
(WebCore::TiledBackingStore::invalidate):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::paint):
(WebCore::TiledBackingStore::viewportChanged):
(WebCore::TiledBackingStore::setContentsScale):
(WebCore::TiledBackingStore::tileDistance):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::dropOverhangingTiles):
(WebCore::TiledBackingStore::dropTilesOutsideRect):
(WebCore::TiledBackingStore::tileAt):
(WebCore::TiledBackingStore::setTile):
(WebCore::TiledBackingStore::removeTile):
(WebCore::TiledBackingStore::mapToContents):
(WebCore::TiledBackingStore::mapFromContents):
(WebCore::TiledBackingStore::contentsRect):
(WebCore::TiledBackingStore::tileRectForCoordinate):
(WebCore::TiledBackingStore::tileCoordinateForPoint):
(WebCore::TiledBackingStore::startTileBufferUpdateTimer):
(WebCore::TiledBackingStore::tileBufferUpdateTimerFired):
(WebCore::TiledBackingStore::startTileCreationTimer):
(WebCore::TiledBackingStore::tileCreationTimerFired):
(WebCore::TiledBackingStore::setContentsFrozen):

  • platform/graphics/TiledBackingStore.h: Added.

(WebCore::TiledBackingStore::contentsScale):
(WebCore::TiledBackingStore::contentsFrozen):

  • platform/graphics/TiledBackingStoreClient.h: Added.
  • platform/graphics/qt/TileQt.cpp: Added.

(WebCore::checkeredPixmap):
(WebCore::Tile::Tile):
(WebCore::Tile::~Tile):
(WebCore::Tile::isDirty):
(WebCore::Tile::isReadyToPaint):
(WebCore::Tile::invalidate):
(WebCore::Tile::updateBackBuffer):
(WebCore::Tile::swapBackBufferToFront):
(WebCore::Tile::paint):
(WebCore::Tile::paintCheckerPattern):

14:44 Changeset [55975] by mitz@apple.com
  • 16 edits
    2 deletes in trunk

WebCore: WebCore part of removing support for legacy versions of Core Graphics

Reviewed by Darin Adler.

  • WebCore.vcproj/WebCore.vcproj: Removed FontDatabase.{cpp,h}
  • platform/graphics/win/FontCGWin.cpp:

(WebCore::Font::drawGlyphs): Removed call to wkCanCreateCGFontWithLOGFONT(),
as it is now always true.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::createFontPlatformData): Ditto.

  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Updated for
the removal of m_cgFont.
(WebCore::FontCustomPlatformData::fontPlatformData): Removed call to
wkCanCreateCGFontWithLOGFONT(), as it is now always true.
(WebCore::createFontCustomPlatformData): Ditto. Also updated for change to
the FontCustomPlatformData constructor.

  • platform/graphics/win/FontCustomPlatformData.h: Removed m_cgFont member.

(WebCore::FontCustomPlatformData::FontCustomPlatformData): Removed cgFont
parameter.

  • platform/graphics/win/FontDatabase.cpp: Removed.
  • platform/graphics/win/FontDatabase.h: Removed.
  • platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::platformDataInit): Removed call to
wkCanCreateCGFontWithLOGFONT(), as it is now always true.

  • platform/win/TemporaryLinkStubs.cpp:

(WebCore::populateFontDatabase): Removed stub.

WebKit/win: WebKit part of removing support for legacy versions of Core Graphics

Reviewed by Darin Adler.

  • WebKitClassFactory.cpp:

(WebKitClassFactory::WebKitClassFactory): Removed call to populateFontDatabase().

  • WebKitGraphics.cpp:

(makeFont): Ditto.

  • WebTextRenderer.cpp:

(WebTextRenderer::registerPrivateFont): Removed call to wkAddFontsAtPath().

WebKitLibraries: WebKitSystemInterface part of removing support for legacy versions of Core Graphics

Reviewed by Darin Adler.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h: Removed

wkCanCreateCGFontWithLOGFONT(), wkSetFontPlatformInfo(), wkAddFontsInDirectory(),
wkAddFontsAtPath(), wkAddFontsFromRegistry(), wkAddFontsFromPlist(), and
wkCreateFontsPlist().

  • win/lib/WebKitSystemInterface.lib: Updated.
  • win/lib/WebKitSystemInterface_debug.lib: Updated.
08:43 Changeset [55974] by jberlin@webkit.org
  • 2 edits in trunk/WebCore

"event.ctrlKey" is always false when dragging an element with "ctrl" key down
https://bugs.webkit.org/show_bug.cgi?id=17113

Reviewed by Sam Weinig.

No new tests.

  • page/DragController.cpp:

(WebCore::createMouseEvent):
Use the current state of the shift, ctrl, alt, and meta keys when creating the drag mouse event.

05:58 Changeset [55973] by tonikitoo@webkit.org
  • 3 edits in trunk/WebCore

2010-03-13 Antonio Gomes <tonikitoo@webkit.org>

Not reviewed identation fix.

  • manual-tests/spatial-navigation/spatial-navigation-test-cases.html:
01:51 QtWebKitJournal edited by hausmann@webkit.org
(diff)

03/13/10:

16:23 Changeset [55972] by cjerdonek@webkit.org
  • 2 edits
    1 copy
    2 adds in trunk/WebKitTools

The webkit-patch script now displays a warning if run using
a version of Python less than 2.5. This will help users
understand why webkit-patch is erroring out if they are
using Python 2.4, for example.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31533

  • Scripts/webkit-patch:
    • Moved most of the file contents to webkitpy/patch/patcher.py so the Python version can be checked before interpreting any code that can cause the script to error out.
    • Added a configure_logging() method to enable any version warnings to show up.
    • Added a main() method with calls to configure_logging(), check_version(), and the main webkit patch method.
  • Scripts/webkitpy/patch/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
    • This file is required to make a folder a package.
  • Scripts/webkitpy/patch/patcher.py: Added.
    • Moved code from Scripts/webkit-patch.
15:48 Changeset [55971] by cjerdonek@webkit.org
  • 4 edits in trunk/WebKitTools

Changed test-webkitpy so that messages logged as a side-effect
of unit-testing code do not get displayed to the screen. These
messages clutter up the unit test results if not filtered out.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35835

  • Scripts/test-webkitpy:
    • Adjusted the configure_logging() method to filter out any log messages from webkitpy.
    • Also added an INFO message stating that most console logging is getting suppressed.
  • Scripts/webkitpy/init/versioning.py:
    • Added a log parameter to the check_version() method.
  • Scripts/webkitpy/init/versioning_unittest.py:
    • Qualified a call to check_version() with the parameter names.
14:36 Changeset [55970] by cjerdonek@webkit.org
  • 3 edits
    1 copy
    3 adds in trunk/WebKitTools

The test-webkitpy script now warns the user if the script is
being run using a Python version different from the minimum
version the webkitpy package was meant to support.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35788

Warning developers if their Python version is too low will help
them understand why test-webkitpy is failing. Secondly, warning
developers if their Python version is higher than the minimum will
help them understand that their changes may not be okay for the
minimum supported version, even if test-webkitpy is passing.

  • Scripts/test-webkitpy:
    • Moved the "from ..._unittest import *" lines to the new file Scripts/webkitpy/unittests.py. This will allow the version-check warning to be displayed even if an error occurs while interpreting (i.e. importing) the unit test code.
    • Added configure_logging() to configur logging for test-webkitpy.
    • Added an init() method to configure logging and check the current Python version.
  • Scripts/webkitpy/init/unittests.py: Added.
    • Added a file to import all unit test modules in the webkitpy.init package.
  • Scripts/webkitpy/init/versioning.py: Added.
    • Added a _MINIMUM_SUPPORTED_PYTHON_VERSION variable and set it equal to 2.5.
    • Added a compare_version() method to compare the current Python version against a target version.
    • Added a check_version() method to check the current Python version against the current minimum supported version, and to log a warning message if the check fails.
  • Scripts/webkitpy/init/versioning_unittest.py: Added.
    • Added unit tests for the functions in versioning.py.
  • Scripts/webkitpy/style/unittests.py:
    • Fixed/updated a code comment.
  • Scripts/webkitpy/unittests.py: Added.
    • Moved the "from ..._unittest import *" lines from test-webkitpy.
14:10 Changeset [55969] by cjerdonek@webkit.org
  • 6 edits
    1 copy
    1 add in trunk/WebKitTools

Moved all code in webkitpy/init.py to another location.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35828

Keeping webkitpy/init.py free of non-trivial code allows
calling code to import initialization code from webkitpy
before any errors or log messages occur due to code in
init.py. Such initialization code can include things like
version checking code and logging configuration code. This
also lets us move the autoinstall initialization code to a
location where it only executes if it is needed -- something
we have done in this patch.

  • Scripts/webkitpy/init.py:
    • Moved all executable code to the following location: webkitpy/thirdparty/autoinstalled/init.py
    • Added a code comment to keep this file free of non-trivial code.
  • Scripts/webkitpy/bugzilla.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/networktransaction.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/networktransaction_unittest.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/statusserver.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/thirdparty/autoinstalled/init.py: Added.
    • Copied the code from webkitpy/init.py and updated it as necessary.
13:28 Changeset [55968] by cjerdonek@webkit.org
  • 16 edits
    1 move
    2 adds in trunk/WebKitTools

Moved webkitpy/mock.py into webkitpy/thirdparty since it is
third-party code.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35499

Updated the import statement in all of the below except where noted.

  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/commands/commandtest.py:
  • Scripts/webkitpy/commands/download_unittest.py:
  • Scripts/webkitpy/commands/early_warning_system_unittest.py:
  • Scripts/webkitpy/commands/queries_unittest.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/queuestest.py:
  • Scripts/webkitpy/commands/upload.py:
  • Scripts/webkitpy/commands/upload_unittest.py:
  • Scripts/webkitpy/commands_references.py: Added.
    • Added a file containing an absolute import of Mock so that the imports in the commands folder can import from this file (similar to style_references.py). This helps limit the number of affected files in future refactorings.
  • Scripts/webkitpy/credentials_unittest.py:
  • Scripts/webkitpy/mock.py: Removed.
    • Moved to Scripts/webkitpy/thirdparty.
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/patchcollection_unittest.py:
  • Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/steps/steps_unittest.py:
  • Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
  • Scripts/webkitpy/steps_references.py: Added.
    • Added a file containing an absolute import of Mock so that the imports in the steps folder can import from this file (similar to style_references.py). This helps limit the number of affected files in future refactorings.
  • Scripts/webkitpy/thirdparty/mock.py: Copied from WebKitTools/Scripts/webkitpy/mock.py.
    • Also eliminated trailing white space and carriage returns.
11:28 Changeset [55967] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC
https://bugs.webkit.org/show_bug.cgi?id=36034

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::OpacityAnimationQt::applyFrame):
10:54 Changeset [55966] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: Opacity transitions end with begin value
https://bugs.webkit.org/show_bug.cgi?id=36019

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQt::updateCurrentTime):
10:35 Changeset [55965] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35925

  • efl/ewk/ewk_history.cpp: Added.
  • efl/ewk/ewk_history.h: Added.
10:17 Changeset [55964] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35928

  • efl/ewk/ewk_main.cpp: Added.
  • efl/ewk/ewk_main.h: Added.
10:12 Changeset [55963] by ossy@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Enable accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=35866

Unreviewed. Roll-out r55955, because it broke 3 tests:

  • animations/fill-mode-transform.html
  • animations/play-state.html
  • animations/simultaneous-start-left.html
  • Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

07:25 QtWebKitJournal edited by hausmann@webkit.org
(diff)
05:43 Changeset [55962] by krit@webkit.org
  • 3 edits in trunk/WebCore

2010-03-13 Dirk Schulze <krit@webkit.org>

No review, rolling out r55927.
http://trac.webkit.org/changeset/55927
https://bugs.webkit.org/show_bug.cgi?id=35793

Breaks Gtk build bots.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::setPreload):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
02:59 Changeset [55961] by robert@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-12 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

Amend incorrect typo patch for QtLauncher.

https://bugs.webkit.org/show_bug.cgi?id=35877

  • QtLauncher/webview.cpp: (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
02:44 Changeset [55960] by eric@webkit.org
  • 1 edit
    19 adds in trunk/WebKitTools

2010-03-13 Victor Wang <victorw@chromium.org>

Add appengine app to host and serve webkit layout test results.

The app allows you post test result files (json) and serve them up.
Chromium flakiness dashboard will first use this app to host results.json
and expectations.json, but the files hosted by this app are not limited
to chromium results or json files. It can be used to host other files if needed.

https://bugs.webkit.org/show_bug.cgi?id=35944

  • TestResultServer: Added.
  • TestResultServer/app.yaml: Added.
  • TestResultServer/handlers: Added.
  • TestResultServer/handlers/init.py: Added.
  • TestResultServer/handlers/menu.py: Added.
  • TestResultServer/handlers/testfilehandler.py: Added.
  • TestResultServer/index.yaml: Added.
  • TestResultServer/main.py: Added.
  • TestResultServer/model: Added.
  • TestResultServer/model/init.py: Added.
  • TestResultServer/model/testfile.py: Added.
  • TestResultServer/stylesheets: Added.
  • TestResultServer/stylesheets/form.css: Added.
  • TestResultServer/stylesheets/menu.css: Added.
  • TestResultServer/stylesheets/testfile.css: Added.
  • TestResultServer/templates: Added.
  • TestResultServer/templates/menu.html: Added.
  • TestResultServer/templates/showfilelist.html: Added.
  • TestResultServer/templates/uploadform.html: Added.
02:28 Changeset [55959] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Levin.

new-run-webkit-tests fails with --debug option.
https://bugs.webkit.org/show_bug.cgi?id=36067

  • Scripts/webkitpy/layout_tests/port/mac.py:
02:11 Changeset [55958] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35924

  • efl/ewk/ewk_frame.cpp: Added.
  • efl/ewk/ewk_frame.h: Added.
01:54 Changeset [55957] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKit

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35936

  • efl/ewk/ewk_view_single.c: Added.
01:38 Changeset [55956] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add "Show FPS" menu option to QtLauncher.

[Qt] QtLauncher need a menu option to show/hide FPS
https://bugs.webkit.org/show_bug.cgi?id=35794

  • QtLauncher/main.cpp: (LauncherWindow::showFPS): (LauncherWindow::createChrome):
01:21 Changeset [55955] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-13 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=35866

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings):
01:04 Changeset [55954] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35929

  • efl/ewk/ewk_util.cpp: Added.
  • efl/ewk/ewk_util.h: Added.
00:47 Changeset [55953] by eric@webkit.org
  • 1 edit
    5 adds in trunk/WebKit

2010-03-13 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35934

  • efl/ewk/EWebKit.h: Added.
  • efl/ewk/ewk_eapi.h: Added.
  • efl/ewk/ewk_logging.h: Added.
  • efl/ewk/ewk_private.h: Added.
00:31 Changeset [55952] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-13 Eric Roman <eroman@chromium.org>

Reviewed by Adam Barth.

Add a firstPartyForCookies() property to WebDocument.
https://bugs.webkit.org/show_bug.cgi?id=35592

  • public/WebDocument.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::firstPartyForCookies):
00:14 Changeset [55951] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-13 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add a "Toggle FullScreen" option to QtLauncher Menu.

[Qt] QtLauncher needs an option to toggle FullScreen Mode
https://bugs.webkit.org/show_bug.cgi?id=35755

  • QtLauncher/main.cpp: (LauncherWindow::init): (LauncherWindow::eventFilter): (LauncherWindow::initializeView): (LauncherWindow::toggleFullScreenMode): (LauncherWindow::createChrome):

03/12/10:

23:57 Changeset [55950] by eric@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2010-03-12 Shu Chang <chang.shu@nokia.com>

Reviewed by David Levin.

[Qt] Rebaseline the test and remove it from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=36057

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-size-change-after-layout-expected.png: Added.
  • platform/qt/fast/canvas/canvas-size-change-after-layout-expected.txt:
23:07 Changeset [55949] by krit@webkit.org
  • 19 edits in trunk

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyphs - transform path not context
https://bugs.webkit.org/show_bug.cgi?id=36070

SVGFont should transform the path of a glyph, not the context. Modifying
the context causes wrong gradient transformations. This bug doesn't
influence CG because we generally fill or stroke texts with a mask image.
All other platforms provide a direct way to make the drawings.

  • svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyphs - transform path not context
https://bugs.webkit.org/show_bug.cgi?id=36070

Some tests don't look pixel perfect after the SVGFont changes (difference of 0.1%).
They just need an update.
Tests for the changes on other platforms than CG are

  • svg/batik/text/textEffect.svg
  • svg/batik/text/textEffect3.svg
  • svg/W3C-SVG-1.1/pservers-grad-08-b.svg
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/text/selection-doubleclick-expected.png:
  • platform/mac/svg/text/selection-tripleclick-expected.png:
18:10 Changeset [55948] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (build fix).

17:56 Changeset [55947] by enrica@apple.com
  • 2 edits in trunk/WebKit/win

Fixed broken build on Windows.
Added contditional compilation for accelerated compositing.

  • WebView.cpp:

(WebView::deleteBackingStore):
(WebView::addToDirtyRegion):
(WebView::updateBackingStore):

17:39 Changeset [55946] by bdakin@apple.com
  • 14 edits in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
API naming is inconsistent
-and corresponding-
<rdar://problem/7729165>

Reviewed by Simon Fraser.

WebCore:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen." webkitEnterFullScreen and
webkitExitFullScreen have been maintained for now for backwards
compatibility.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitEnterFullscreen):
(WebCore::HTMLVideoElement::webkitExitFullscreen):

  • html/HTMLVideoElement.h:

(WebCore::HTMLVideoElement::webkitEnterFullScreen):
(WebCore::HTMLVideoElement::webkitExitFullScreen):

  • html/HTMLVideoElement.idl:
  • platform/graphics/mac/MediaPlayerProxy.h:

WebKit/mac:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."

  • Plugins/Hosted/NetscapePluginHostProxy.h:

(WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::didEnterFullscreen):
(WebKit::NetscapePluginHostProxy::didExitFullscreen):
(WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
(WKPCSetFullscreenWindowIsShowing):

  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
(-[WebNetscapePluginView _createPlugin]):
(-[WebNetscapePluginView _destroyPlugin]):

  • WebView/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController windowDidLoad]):

WebKit/win:

This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."

  • FullscreenVideoController.cpp:

(FullscreenVideoController::onMouseDown):
(FullscreenVideoController::onMouseMove):
(FullscreenVideoController::onMouseUp):

  • FullscreenVideoController.h:

(FullscreenVideoController::fullscreenToHUDCoordinates):

17:02 Changeset [55945] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-03-12 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

Add virtual destructor to DOMWrapperWorld
https://bugs.webkit.org/show_bug.cgi?id=36077

DOMWrapperWorld is RefCounted<DOMWrapperWorld>. IsolatedWorld
inherits from DOMWrapperWorld and has member variables
with destructors, so DOMWrapperWorld needs to have a declared virtual
d'tor to ensure that its derived class's destructors are called.

No new tests, no change in behavior

  • bindings/v8/DOMWrapperWorld.h: (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
16:46 Changeset [55944] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (build fix).

15:49 Changeset [55943] by barraclough@apple.com
  • 10 edits in trunk

Bug 36075 - Clean up screwyness re static string impls & Identifiers.

Reviewed by Oliver Hunt.

JavaScriptCore:

  • API/JSClassRef.cpp:

(OpaqueJSClass::~OpaqueJSClass): Classname may be null/empty, and these are an identifer. This is okay, since the null/empty strings are shared across all threads.

(JSC::Identifier::add): No need to explicitly hash null reps, this is done in the ststic UStringImpl constructor.
(JSC::Identifier::addSlowCase): UStringImpl::empty() handled & checkCurrentIdentifierTable now called in the header.
(JSC::Identifier::checkCurrentIdentifierTable): Replaces checkSameIdentifierTable (this no longer checked the rep since the identifierTable pointer was removed from UString::Rep long ago).

  • runtime/Identifier.h:

(JSC::Identifier::add): Replace call to checkSameIdentifierTable with call to checkCurrentIdentifierTable at head of function.

  • runtime/UStringImpl.cpp:

(JSC::UStringImpl::~UStringImpl): Remove call to checkConsistency - this function no longer checks anything interesting.

  • runtime/UStringImpl.h:

(JSC::UStringOrRopeImpl::UStringOrRopeImpl): Set s_refCountFlagIsIdentifier in static constructor.
(JSC::UStringImpl::UStringImpl): remove calls to checkConsistency (see above), add new ASSERT to substring constructor.
(JSC::UStringImpl::setHash): ASSERT not static (static strings set the hash in their constructor, should not reach this code path).
(JSC::UStringImpl::create): Add missing ASSERT.
(JSC::UStringImpl::setIsIdentifier): ASSERT !isStatic() (static strings hash set in constructor).

WebCore:

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl): Add ASSERT
(WebCore::StringImpl::sharedBuffer): Add ASSERT

  • platform/text/StringImpl.h:

(WebCore::StringImpl::setHash): Add ASSERT
(WebCore::StringImpl::isStatic): added.

15:17 Changeset [55942] by bdakin@apple.com
  • 2 edits in trunk/WebKit/win

Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
video HUD stays on top when switching to another window (e.g. via
Alt-Tab)
-and corresponding-
<rdar://problem/7547574>

Reviewed by Adam Roben.

The HUD was always on top because it had the WS_EX_TOPMOST style.
So I removed the style and made m_videoWindow the owner of
m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
is the focused window.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
(FullscreenVideoController::createHUDWindow):

15:11 Changeset [55941] by enrica@apple.com
  • 6 edits
    10 adds
    1 delete in trunk

Content of 3D tests appears at the bottom right corner sometimes.
<rdar://problem/7556244>
<https://bugs.webkit.org/show_bug.cgi?id=36027>

Reviewed by Simon Fraser.

WebCore:

There were two problems to solve here:

  • the incorrect anchoring of the rootChildLayer that was causing the composited content to be positioned incorrectly
  • the failure to paint the non composited content into the backing store when animating composited content.


The first problem has been solved by leaving the original anchor point for the
rootChildLayer and splitting the tasks of clipping and scrolling using two separate layers.
The second problem has been solved leveraging the knowledge that WebView has of the dirty region
of the backing store to pass this information to the layer renderer. This allows the renderer to force
a paint into the backing store before moving to the compositing.

Tests: compositing/geometry/horizontal-scroll-composited.html

compositing/geometry/vertical-scroll-composited.html

  • manual-tests/win/horizontal-scroll-composited.html: Removed. This is now a layout test.
  • manual-tests/win/milliondollar.html: Added.
  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Added initialization of dirty flag.
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::updateScrollFrame): Updated to resize and position the clip and scroll layers.
(WebCore::WKCACFLayerRenderer::setRootChildLayer):
(WebCore::WKCACFLayerRenderer::createRenderer): Added new layer hierarchy.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Remove clip layer on destroy.
(WebCore::WKCACFLayerRenderer::resize):
(WebCore::WKCACFLayerRenderer::paint): Forcing paint massage to trigger paint into the backing store.

  • platform/graphics/win/WKCACFLayerRenderer.h:

(WebCore::WKCACFLayerRenderer::setBackingStoreDirty): Added.

WebKit/win:

See detailed comments in WebCore/ChangeLog.

  • WebView.cpp:

(WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
(WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
backing store dirty region.
(WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
(WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
(WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
We are passing width and height of the view content together with the offset for the scrolling.
It was confusing to pass it all as a rectangle, when it is not a rectangle.

LayoutTests:

  • compositing/geometry/horizontal-scroll-composited.html: Added.
  • compositing/geometry/vertical-scroll-composited.html: Added.
  • compositing/resources/apple.jpg: Added.
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
  • platform/mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
  • platform/mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/mac/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
14:58 Changeset [55940] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Fix typo in websocket_server (path_from_base instead of
path_from_chromium_base).

https://bugs.webkit.org/show_bug.cgi?id=36074

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
14:49 Changeset [55939] by robert@webkit.org
  • 2 edits in trunk/WebCore

2010-03-12 Robert Hogan <robert@webkit.org>

Not reviewed, build fix.

Revert http://trac.webkit.org/projects/webkit/changeset/55374 which broke
the !ENABLE(DATABASE) build on all platforms when attempting to fix the
--minimal build on Qt.

Support for SQLite now seems to be non-negotiable for the Qt build but making
it mandatory requires review, so re-break --minimal Qt build for now.

Qt build issue now tracked at https://bugs.webkit.org/show_bug.cgi?id=36073

  • page/GeolocationPositionCache.cpp:
14:43 Changeset [55938] by dpranke@chromium.org
  • 5 edits in trunk/WebKitTools

2010-03-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests --new-baseline doesn't work at all.

It attempts to call a method that isn't defined. To fix it, I
removed the unnecessary and unnecessarily confusing 'platform'
argument to the test_type constructor and use the Port object that
is passed in instead, since we are only ever generating a baseline
from the port that is currently executing.

https://bugs.webkit.org/show_bug.cgi?id=36046

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
14:42 Changeset [55937] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Fix new-run-webkit-tests --run-singly

This script option is currently broken - the script attempts to
dereference methods and variables that don't exist, which causes
the Chromium Linux valgrind bot to be quite unhappy. This has been
broken since r54449 when I renamed Port.start_test_driver to
Port.start_driver.

https://bugs.webkit.org/show_bug.cgi?id=36042

  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
14:31 Changeset [55936] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-12 Dirk Schulze <krit@webkit.org>

Unreviewed LayoutTest update.

Result was not updated with r55930.

  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
13:23 Changeset [55935] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7709115> REGRESSION: toolbar is missing at http://www.glom.org/
https://bugs.webkit.org/show_bug.cgi?id=35507

Reviewed by Alexey Proskuryakov.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::setCSSStyleSheet): Extend the change made in
<http://trac.webkit.org/changeset/48818> to detect the two variants of
KHTMLFixes.css in @import rules as well as in <link> elements.

13:16 Changeset [55934] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Bug 36052 - [Qt] REGRESSION(55878) 63 test cases crash

Reviewed by Geoff Garen.

r55878 changed UStringImpl::empty()->characters() to be non-null,
so TextBreakIteratorQt.cpp now should check the length of strings
(previously was assuming all strings with a non-null data pointer
had a length of at least 1).

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::wordBreakIterator):
(WebCore::characterBreakIterator):
(WebCore::lineBreakIterator):
(WebCore::sentenceBreakIterator):

13:15 Changeset [55933] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <gdk@chromium.org>

Unreiviewed.

Fix Chromium Mac build. Last patch did not apply properly.
(Garret assures me this patch will actually work.)

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
12:48 Changeset [55932] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <gdk@chromium.org>

Unreviewed.

Fix Chromium Mac build. This time, with actual fixing goodness.

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
12:47 Changeset [55931] by beidson@apple.com
  • 4 edits in trunk/WebKit/mac

Expose WebPDFView's underlying PDFDocument.

Patch by Andy Estes <aestes@apple.com> on 2010-03-12
Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=36045

  • WebView/WebDocumentPrivate.h: Create a new protocol called

WebDocumentPDF.

  • WebView/WebPDFView.h: Have WebPDFView implement said protocol.
  • WebView/WebPDFView.mm:

(-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
PDFDocument by implementing -(PDFDocument*)PDFDocument from
WebDocumentPDF.

12:43 Changeset [55930] by krit@webkit.org
  • 5 edits
    4 adds in trunk

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG fallback color doesn't work for bogus gradients.
https://bugs.webkit.org/show_bug.cgi?id=35479

Use a given fallback color on ignored gradients if present. Gradients
must be ignored, if one dimension of the objects boundingBox is zero.

Test: svg/custom/gradient-with-1d-boundingbox.svg

  • svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::strokePaintServer):
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):

2010-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG fallback color doesn't work for bogus gradients.
https://bugs.webkit.org/show_bug.cgi?id=35479

We now use a fallback color on ignored gradients for one dimensional objects,
either a given fallback color or black as default.
This causes a change of one LayoutTest, because it was done manually in the
gradient PaintServer, without respecting a given fallback color.

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
  • svg/custom/gradient-with-1d-boundingbox.svg: Added.
12:36 Changeset [55929] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <gdk@chromium.org>

Unreviewed.

Fix Chromium Mac build.

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchEventType): (WebKit::toPlatformTouchPointState):
12:29 Changeset [55928] by hyatt@apple.com
  • 16 edits
    1 delete in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36069

Reviewed by Dan Bernstein.

Eliminate InlineRunBox.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::adjustPosition):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::prevLineBox):
(WebCore::InlineFlowBox::nextLineBox):
(WebCore::InlineFlowBox::setNextLineBox):
(WebCore::InlineFlowBox::setPreviousLineBox):

  • rendering/InlineRunBox.h: Removed.
  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::InlineTextBox):
(WebCore::InlineTextBox::prevTextBox):
(WebCore::InlineTextBox::nextTextBox):
(WebCore::InlineTextBox::setNextTextBox):
(WebCore::InlineTextBox::setPreviousTextBox):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::destroy):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::addFocusRingRects):
(WebCore::RenderInline::paintOutline):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::localBoundingBox):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::deleteLineBoxTree):
(WebCore::RenderLineBoxList::extractLineBox):
(WebCore::RenderLineBoxList::attachLineBox):
(WebCore::RenderLineBoxList::removeLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxes):
(WebCore::RenderLineBoxList::dirtyLineBoxes):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
(WebCore::RenderLineBoxList::checkConsistency):

  • rendering/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::absoluteRects):
(WebCore::RenderSVGInline::absoluteQuads):

  • rendering/RenderSVGText.cpp:

(WebCore::RenderSVGText::absoluteRects):
(WebCore::RenderSVGText::absoluteQuads):
(WebCore::RenderSVGText::objectBoundingBox):

  • rendering/RenderText.cpp:

(WebCore::RenderText::extractTextBox):
(WebCore::RenderText::attachTextBox):
(WebCore::RenderText::removeTextBox):
(WebCore::RenderText::createInlineTextBox):
(WebCore::RenderText::positionLineBox):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::nextRootBox):
(WebCore::RootInlineBox::prevRootBox):

12:11 Changeset [55927] by kov@webkit.org
  • 3 edits in trunk/WebCore

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

media/video-preload.html fails
https://bugs.webkit.org/show_bug.cgi?id=35793

Only effectively load, and start buffering when playing, or when
the preload attribute is set.

Test: media/video-preload.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::commitLoad): (WebCore::MediaPlayerPrivate::prepareToPlay): (WebCore::MediaPlayerPrivate::setPreload):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
12:06 Changeset [55926] by dimich@chromium.org
  • 30 edits
    7 deletes in trunk

Not reviewed, build fix.

Reverts 55920 and 55921. Landing for Jian Li.

WebCore:

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMFormDataCustom.cpp: Removed.
  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8DOMFormDataCustom.cpp: Removed.
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

  • html/DOMFormData.idl: Removed.
  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/resources/send-form-data.js: Removed.
  • http/tests/local/send-form-data-expected.txt: Removed.
  • http/tests/local/send-form-data.html: Removed.
  • http/tests/xmlhttprequest/resources/multipart-post-echo.php: Removed.
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/Skipped:
12:03 Changeset [55925] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Fix critical being printed to stderr on every test. This is
because the jar is only being created when soup hits the HTTP
path. We should reconsider the time of its creation.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
11:57 Changeset [55924] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

Make the timeout in 'snav-unit-overflow-and-scroll-in-direction.html' 10x shorter (from 500ms to 50ms)

Rubber-stamped by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

  • fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
11:45 Changeset [55923] by jpetsovits@rim.com
  • 3 edits in trunk/WebCore

2010-03-12 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Add support for drawing text to PainterOpenVG
https://bugs.webkit.org/show_bug.cgi?id=35581

Doesn't come with any actual font classes, as OpenVG
by itself doesn't provide any access to platform fonts
but just the means to draw glyphs that have been loaded
manually before.

  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::copyPaintState): (WebCore::PainterOpenVG::textDrawingMode): (WebCore::PainterOpenVG::setTextDrawingMode): (WebCore::PainterOpenVG::drawText):
  • platform/graphics/openvg/PainterOpenVG.h:
11:25 Changeset [55922] by jpetsovits@rim.com
  • 6 edits in trunk/WebCore

2010-03-12 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Use masks to implement non-rectilinear clipping
https://bugs.webkit.org/show_bug.cgi?id=35544

Requires some additional context switching logic to
make sure the right context is current when dealing
with the mask, because we don't store it by ourselves.

Initial version of this code was written by
Eli Fidler <efidler@rim.com>, I did a couple of
bug fixes and efficiency improvements since then.

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::addInnerRoundedRectClip):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PlatformPainterState::PlatformPainterState): (WebCore::PlatformPainterState::~PlatformPainterState): (WebCore::PlatformPainterState::maskingEnabled): (WebCore::PlatformPainterState::applyState): (WebCore::PlatformPainterState::saveMaskIfNecessary): (WebCore::PainterOpenVG::intersectClipRect): (WebCore::PainterOpenVG::clipPath): (WebCore::PainterOpenVG::save):
  • platform/graphics/openvg/PainterOpenVG.h: (WebCore::PainterOpenVG::):
  • platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::makeCurrent): (WebCore::SurfaceOpenVG::makeCompatibleCurrent):
  • platform/graphics/openvg/SurfaceOpenVG.h: (WebCore::SurfaceOpenVG::):
11:17 Changeset [55921] by jianli@chromium.org
  • 4 edits
    1 add in trunk/WebCore

[v8] Add V8 bindings for DOMFormData.
https://bugs.webkit.org/show_bug.cgi?id=36026

Reviewed by Nate Chapin.

Test: http/tests/local/send-form-data.html

  • WebCore.gypi:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.

(WebCore::V8DOMFormData::appendCallback):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

11:17 Changeset [55920] by jianli@chromium.org
  • 27 edits
    6 adds in trunk

WebCore: Add DOMFormData.idl to expose FormData interface.
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

The implementation is based on XMLHttpRequest 2 spec:
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata

Test: http/tests/local/send-form-data.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMFormDataCustom.cpp: Added.
  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/DOMFormData.idl: Added.
  • page/DOMWindow.idl:

LayoutTests: Add DOMFormData.idl to expose FormData interface
https://bugs.webkit.org/show_bug.cgi?id=36024

Reviewed by Sam Weinig.

Add a layout test to test sending FormData via XMLHttpRequest. Also
changed all test results that are affected by exposing FormData.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/resources/send-form-data.js: Added.
  • http/tests/local/send-form-data-expected.txt: Added.
  • http/tests/local/send-form-data.html: Added.
  • http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/Skipped:
11:11 Changeset [55919] by jpetsovits@rim.com
  • 5 edits in trunk/WebCore

2010-03-12 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Add a SurfaceOpenVG constructor for EGL client buffer surfaces
https://bugs.webkit.org/show_bug.cgi?id=35538

SurfaceOpenVG can now not only encapsulate pbuffer
and window surfaces but also VGImage-based ones.

  • platform/graphics/openvg/EGLDisplayOpenVG.cpp: (WebCore::EGLDisplayOpenVG::createPbufferFromClientBuffer):
  • platform/graphics/openvg/EGLDisplayOpenVG.h:
  • platform/graphics/openvg/SurfaceOpenVG.cpp: (WebCore::SurfaceOpenVG::SurfaceOpenVG):
  • platform/graphics/openvg/SurfaceOpenVG.h:
11:06 Changeset [55918] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Teach prepare-ChangeLog to find modified selectors in CSS files

Reviewed by Tim Hatcher.

Fixes <http://webkit.org/b/36064> prepare-ChangeLog should extract
modified selectors from CSS files

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges): Call get_selector_line_ranges_for_css for
.css files.
(get_selector_line_ranges_for_css): Added. Finds selectors and their
line ranges and returns them.

11:03 Changeset [55917] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-12 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

HTMLMediaElement crash when it is used after resource loading is canceled.
https://bugs.webkit.org/show_bug.cgi?id=35992

Adding a test to access the duration property of a video element after
resource loading was canceled.

  • http/tests/media/video-cancel-load-expected.txt: Added.
  • http/tests/media/video-cancel-load.html: Added.

2010-03-12 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Carlson.

Fix a crash when resource loading of media element is canceled.
https://bugs.webkit.org/show_bug.cgi?id=35992

Use of HTMLMediaElement::duration() after resource loading was canceled
will cause a crash. This is because HTMLMediaElement::m_player is used
when NULL.
Test: http/tests/media/video-cancel-load.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::duration): Avoid calling to m_player when it is null. (WebCore::HTMLMediaElement::userCancelledLoad): Set m_readyState to HAVE_NOTHING.
10:45 Changeset [55916] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Garret Kelly <gdk@chromium.org>

Reviewed by Eric Seidel.

Enable touch events in Chromium features gypi file.
https://bugs.webkit.org/show_bug.cgi?id=35994

  • features.gypi:
10:36 Changeset [55915] by kov@webkit.org
  • 9 edits in trunk/WebKit/gtk

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Kenneth Rohde Christiansen.

Misc documentation fixes. Fixes (almost) all warnings emitted by
the documentation build process. Only the broken references to JSC
objects remain.

  • webkit/webkitsecurityorigin.cpp:
  • webkit/webkitwebbackforwardlist.cpp:
  • webkit/webkitwebdatasource.cpp:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebhistoryitem.cpp:
  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_class_init):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
  • webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_class_init):
10:28 Changeset [55914] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7725534> CSSPrimitiveValue::parserValue() returns deleted memory
https://bugs.webkit.org/show_bug.cgi?id=20069

Reviewed by Darin Adler.

No test added, since with the CSS variables feature disabled, the pointer
to the freed memory is never dereferenced.

  • css/CSSPrimitiveValue.cpp:

(WebCore::valueOrPropertyName): Changed to return a const AtomicString& from
a static table.
(WebCore::CSSPrimitiveValue::parserValue): Updated for the above change.

10:18 Changeset [55913] by ojan@chromium.org
  • 38 edits
    4 copies
    7 adds in trunk/LayoutTests

2010-03-05 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

Tests for smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314

Fixes the tests to make selections using the mouse in order
to force smart-delete. It also adds/modifies tests to have them correctly
identify cases where we are smart-deleting, but shouldn't be.

Fixing to smart-delete only on mouse-based selections will be a followup patch.

  • editing/deleting/5390681-2.html:
  • editing/deleting/non-smart-delete.html: Added.
  • editing/deleting/smart-delete-001.html:
  • editing/deleting/smart-delete-002.html:
  • editing/deleting/smart-delete-003.html:
  • editing/deleting/smart-delete-004.html:
  • editing/editing.js: (doubleClick): (doubleClickAtSelectionStart):
  • editing/pasteboard/4944770-2.html:
  • editing/pasteboard/drag-drop-modifies-page.html:
  • editing/pasteboard/smart-drag-drop.html: Added.
  • editing/pasteboard/smart-paste-001.html:
  • editing/pasteboard/smart-paste-002.html:
  • editing/pasteboard/smart-paste-003.html:
  • editing/pasteboard/smart-paste-004.html:
  • editing/pasteboard/smart-paste-005.html:
  • editing/pasteboard/smart-paste-007.html:
  • editing/pasteboard/smart-paste-008.html:
  • editing/selection/delete-word-granularity-text-control-expected.txt: Added.
  • editing/selection/delete-word-granularity-text-control.html: Added.
  • editing/selection/script-tests/delete-word-granularity-text-control.js: Added.
  • editing/style/style-boundary-005.html:
  • platform/mac/editing/deleting/non-smart-delete-expected.checksum: Added.
  • platform/mac/editing/deleting/non-smart-delete-expected.png: Added.
  • platform/mac/editing/deleting/non-smart-delete-expected.txt: Added.
  • platform/mac/editing/deleting/smart-delete-001-expected.txt:
  • platform/mac/editing/deleting/smart-delete-002-expected.txt:
  • platform/mac/editing/deleting/smart-delete-003-expected.txt:
  • platform/mac/editing/deleting/smart-delete-004-expected.txt:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.checksum:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/mac/editing/pasteboard/smart-drag-drop-expected.checksum: Added.
  • platform/mac/editing/pasteboard/smart-drag-drop-expected.png: Added.
  • platform/mac/editing/pasteboard/smart-drag-drop-expected.txt: Added.
  • platform/mac/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/mac/editing/style/style-boundary-005-expected.checksum:
  • platform/mac/editing/style/style-boundary-005-expected.png:
  • platform/mac/editing/style/style-boundary-005-expected.txt:
10:14 Changeset [55912] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Darin Fisher <darin@chromium.org>

Fix Chromium build bustage.

Wrap usage of WebPrivatePtr from WebNode.h in a #if
WEBKIT_IMPLEMENTATION guard.

  • public/WebNode.h:
10:03 Changeset [55911] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • platform/chromium/PlatformKeyboardEventChromium.cpp:
09:54 Changeset [55910] by ap@apple.com
  • 1 edit in trunk/WebKitTools/ChangeLog

Fixing an embarrassing typo in ChangeLog.

09:06 Changeset [55909] by mitz@apple.com
  • 16 edits
    2 adds in trunk

<rdar://problem/7694674> Hover states not updated when overflow section scrolls under stationary mouse pointer
https://bugs.webkit.org/show_bug.cgi?id=35949

Reviewed by Darin Adler.

WebCore:

Test: fast/events/overflow-scroll-fake-mouse-move.html

Soon after an overflow section scrolls under the mouse pointer, dispatch
a fake mouse move event. This is similar to how frame scrolling is handled
in WebKit, and has the effect of updating hover state, dispatching DOM mouse
events, and updating the tool tip.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Initialize m_fakeMouseMoveEventTimer.
(WebCore::EventHandler::~EventHandler): Assert that the timer is not active.
(WebCore::EventHandler::clear): Stop the timer.
(WebCore::EventHandler::handleMousePressEvent): Cancel pending fake mouse
move events.
(WebCore::EventHandler::handleMouseMoveEvent): Ditto.
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad): If the mouse
is in the passed-in quad, ensure that a fake mouse move event is scheduled
to fire soon.
(WebCore::EventHandler::cancelFakeMouseMoveEvent): Does what the name says.
(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Constructs a
PlatformMouseEvent with the current mouse location, modifier key state and
time stamp and calls mouseMoved().

  • page/EventHandler.h:
  • platform/PlatformKeyboardEvent.h: Declared getCurrentModifierState().
  • platform/android/KeyEventAndroid.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

  • platform/brew/PlatformKeyboardEventBrew.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • platform/chromium/PlatformKeyboardEventChromium.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

  • platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

  • platform/gtk/KeyEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • platform/haiku/PlatformKeyboardEventHaiku.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

  • platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • platform/qt/PlatformKeyboardEventQt.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.

  • platform/win/KeyEventWin.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.

  • platform/wx/KeyboardEventWx.cpp:

(WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset): Call
EventHandler::dispatchFakeMouseMoveEventSoonInQuad(). Moved things around
a little to avoid computing the repaint rect twice.

LayoutTests:

  • fast/events/overflow-scroll-fake-mouse-move-expected.txt: Added.
  • fast/events/overflow-scroll-fake-mouse-move.html: Added.
  • fast/events/touch/basic-multi-touch-events.html:
  • fast/events/touch/basic-single-touch-events.html:
09:03 Changeset [55908] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Nicolas Weber <thakis@chromium.org>

Reviewed by David Levin.

[Chromium] Cmd-clicking submit buttons should submit in new tab
https://bugs.webkit.org/show_bug.cgi?id=36023

Take modifiers into account when clicking form buttons. E.g.
cmd-clicking a submit button will submit in a new background tab,
cmd-shift-clicking in a new foreground tab, shift-clicking in a new
window. (On windows/linux, it's ctrl instead of cmd.)

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):
08:56 Changeset [55907] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-12 Csaba Osztrogonác <ossy@webkit.org>

[Qt] css1/box_properties/acid_test.html failed in release mode (32 bit).
But it passes in debug mode (32 and 64 bit) and in release mode (64 bit).

https://bugs.webkit.org/show_bug.cgi?id=33834

  • platform/qt/Skipped: css1/box_properties/acid_test.html skipped again.
08:36 Changeset [55906] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-12 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix memory leak in WebImageDecoder API
https://bugs.webkit.org/show_bug.cgi?id=35946

  • src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::setData): (WebKit::WebImageDecoder::getFrameAtIndex):
08:15 Changeset [55905] by kov@webkit.org
  • 3 edits in trunk/WebKitTools

Build fix (for EWS). Make sure the new code builds on older soup.

Thanks to Dan Winship.

08:05 Changeset [55904] by kov@webkit.org
  • 6 edits in trunk

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

[GTK] DRT does not handle cookie policy setting
https://bugs.webkit.org/show_bug.cgi?id=36056

Implement cookie accept policy setting for GTK+'s LayoutTestController.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies):

LayoutTests

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Eric Carlson.

[GTK] DRT does not handle cookie policy setting
https://bugs.webkit.org/show_bug.cgi?id=36056

Fix tests to request that the cookie acceptance policy always allows cookies.

  • http/tests/media/video-cookie.html:
  • http/tests/media/video-referer.html:
08:02 Changeset [55903] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-12 Adam Langley <agl@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium]: update Linux layout test scripts for RedHat like systems.

(Tested on Fedora 12.)

https://bugs.webkit.org/show_bug.cgi?id=35867

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
07:53 Changeset [55902] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Now css1/box_properties/acid_test.html passes, so we can unskip it.
original bug: https://bugs.webkit.org/show_bug.cgi?id=33834

  • platform/qt/Skipped: css1/box_properties/acid_test.html unskipped.
07:45 Changeset [55901] by eric@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-03-12 Andy Estes <aestes@apple.com>

Reviewed by Brady Eidson.

Remove an unused method.

https://bugs.webkit.org/show_bug.cgi?id=35940

  • Plugins/WebPluginController.mm: removed - (void)showURL:(NSURL *) inFrame:(NSString *)
07:28 Changeset [55900] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-12 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by David Levin.

Two functions tryConsumeCharacter() and tryConsumeCharacterClass() are
removed from yarr/RegexInterpreter.cpp because they are never called.

  • yarr/RegexInterpreter.cpp:
07:16 Changeset [55899] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] DRT failing on test introduced in r55499
https://bugs.webkit.org/show_bug.cgi?id=35729

Now fast/events/zoom-dblclick.html passes, so we can unskip it.

  • platform/qt/Skipped: fast/events/zoom-dblclick.html unskipped.
07:12 Changeset [55898] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Make svn-create-patch's diffs of ObjC header files more readable

Fixes <http://webkit.org/b/36055>.

Reviewed by John Sullivan.

  • Scripts/svn-create-patch:

(diffOptionsForFile): Added. Returns the options that should be passed
to diff for the given file. All the options are the same for all
files, except for the option to specify which lines should be used as
hunk headers.
(generateDiff): Use diffOptionsForFile to get the options to pass to
diff.
(hunkHeaderLineRegExForFile): Added. Returns the regular expression
that should be used by diff to identify lines that should be included
after the "@@" in the hunk header lines of the diff. For ObjC[++]
source files, we use any lines starting with -, +, or
@implementation/@interface/@protocol. For ObjC[++] header files (which
we assume to be any .h files in a mac/ or objc/ directory), we use any
lines starting with @implementation/@interface/@protocol.

07:10 Changeset [55897] by eric@webkit.org
  • 5 edits in trunk

2010-03-12 Scott Byer <scottbyer@chromium.org>

Reviewed by David Levin.

Popup font size needs to be exposed to clients.
https://bugs.webkit.org/show_bug.cgi?id=35990

Add function to expose the popup menu font size, add a field to
WebPopupMenuInfo that receives that information to convey that to
the web view client's createPopupMenu() call.

  • WebCore/platform/chromium/PopupMenuChromium.cpp:
  • WebCore/platform/chromium/PopupMenuChromium.h:
  • WebKit/chromium/public/WebPopupMenuInfo.h:
  • WebKit/chromium/src/ChromeClientImpl.cpp:
06:53 Changeset [55896] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-12 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Webkit doesn't build with workers on and database off
https://bugs.webkit.org/show_bug.cgi?id=35997

Added missing ENABLE(DATABASE) guards.

  • workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownStartTask::performTask):
06:25 Changeset [55895] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

[GTK] Fails fast/dom/Geolocation/maximum-age.htm
https://bugs.webkit.org/show_bug.cgi?id=36053

Skip new failing test.

  • platform/gtk/Skipped:
06:25 Changeset [55894] by kov@webkit.org
  • 4 edits in trunk

2010-03-12 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha.

Make the defaultCookieJar use a no-third-party policy. Most
applications set their own cookie jar, but DumpRenderTree doesn't,
so it was failing the new third-party-cookie test.

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar):

LayoutTests

2010-03-12 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha.

Revert previous; the test passes now.

  • platform/gtk/Skipped:
06:06 Changeset [55893] by eric@webkit.org
  • 8 edits
    4 adds in trunk

2010-03-12 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Test for referrer information being stripped when the header is removed in willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=35920

  • http/tests/security/no-referrer-expected.txt: Added.
  • http/tests/security/no-referrer.html: Added.
  • http/tests/security/resources/no-referrer-frame.php: Added.
  • http/tests/security/resources/no-referrer.php: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-03-12 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Introduce setWillSendRequestClearHeader to LayoutTestController to selectively remove headers in willSendRequest. Used in http/tests/security/no-referrer.html
https://bugs.webkit.org/show_bug.cgi?id=35920

  • DumpRenderTree/LayoutTestController.cpp: (setWillSendRequestClearHeaderCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::willSendRequestClearHeaders): (LayoutTestController::setWillSendRequestClearHeader):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::willSendRequest):
05:44 Changeset [55892] by zimmermann@webkit.org
  • 5 edits in trunk/LayoutTests

2010-03-12 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Update two tests, whose pixel hash fail with --tolerance 0. No visible differences.

  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.checksum:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.png:

03/11/10:

23:24 Changeset [55891] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-11 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable network state notifier when compiling against Qt 4.7
https://bugs.webkit.org/show_bug.cgi?id=35983

  • WebCore.pri:
  • platform/network/qt/NetworkStateNotifierPrivate.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:
23:07 Changeset [55890] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-03-11 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Adam Treat.

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

The frame view take into acount the list of fixed object when scrolling
the view. If the number of object is lower than a certain threshold, the pixel
are blitted, and the invalidated area updated.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject): (WebCore::FrameView::scrollContentsFastPath):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::scrollContentsFastPath):
  • platform/ScrollView.h:
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
Note: See TracTimeline for information about the timeline view.