Timeline


and

03/22/10:

23:48 Changeset [56382] by eric@webkit.org

2010-03-22 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

Qt] Fix arc function in canvas
https://bugs.webkit.org/show_bug.cgi?id=36296

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/arc360-expected.checksum: Added.
  • platform/qt/fast/canvas/arc360-expected.png: Added.
  • platform/qt/fast/canvas/arc360-expected.txt: Added.

2010-03-22 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix arc function in canvas
https://bugs.webkit.org/show_bug.cgi?id=36296

Based on HTLM5 spec (4.8.10.1.8 Complex shapes), arc function should draw a line to previous point, not only the arc.

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
23:30 Changeset [56381] by eric@webkit.org

2010-03-22 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add GraphicsContext3D abstraction to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36262

Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
GraphicsContext3D implementation to use it. All of the OpenGL calls have
been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
WebGraphicsContext3D implementation. GraphicsContext3D is still
responsible for the transfer of rendered output from the
WebGraphicsContext3D to the HTMLCanvasElement.

The GraphicsContext3DInternal class, which is a data member of
GraphicsContext3D for the Chromium port, remains. It is possible to
eliminate this class and thereby one level of delegation, but this is
being deferred.

The needed entry point for a Chrome implementation of
WebGraphicsContext3D has been added to WebKitClient, but it is not being
called yet by GraphicsContext3D. It will be once this patch lands and
Chromium is rolled forward to support this entry point.

This is a large patch, but the transformation is almost entirely
mechanical and there is no change in functionality. Nearly all of
GraphicsContext3D and GraphicsContext3DInternal has been moved to
WebGraphicsContext3DDefaultImpl. The only area where the splitting of
logic is less than mechanical is GraphicsContext3D::beginPaint() and its
callees.

Ran all WebGL layout tests and demos from Khronos site in Chromium
on Mac and Windows.

  • WebKit.gyp:
  • public/WebGraphicsContext3D.h: Added. (WebKit::WebGraphicsContext3D::Attributes::Attributes): (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
  • public/WebKitClient.h: (WebKit::WebKitClient::createGraphicsContext3D):
  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::endPaint): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::readPixels): (WebCore::GraphicsContext3DInternal::shaderSource): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
  • src/WebGraphicsContext3D.cpp: Added. (WebKit::WebGraphicsContext3D::createDefault):
  • src/WebGraphicsContext3DDefaultImpl.cpp: Added. (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection): (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState): (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::width): (WebKit::WebGraphicsContext3DDefaultImpl::height): (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes): (WebKit::createTextureObject): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture): (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::drawElements): (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::getError): (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::getString): (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createProgram): (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createTexture): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram): (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture): (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
  • src/WebGraphicsContext3DDefaultImpl.h: Added. (WebKit::WebGraphicsContext3DDefaultImpl::): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):
23:08 Changeset [56380] by ukai@chromium.org

2010-03-19 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36339
This LayoutTest tests for webkit ability to process long invalid headers generated by misbehaving websockets servers.

  • websocket/tests/long-invalid-header-expected.txt: Added.
  • websocket/tests/long-invalid-header.html: Added.
  • websocket/tests/long-invalid-header_wsh.py: Added.
  • websocket/tests/script-tests/long-invalid-header.js: Added.

2010-03-19 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36339
Off-by-one memory corruption fix for long invalid websockets upgrade header

Test: websocket/tests/long-invalid-header.html

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):
22:51 Changeset [56379] by eric@webkit.org

2010-03-22 David Kilzer <ddkilzer@apple.com>

Remove http/tests/cookies/simple-cookies-expired.html from skip list after CFNetwork issue is resolved
<http://webkit.org/b/25861>
<rdar://problem/6901322>

Reviewed by Darin Adler.

  • platform/win/Skipped: Removed:
  • http/tests/cookies/simple-cookies-expired.html
22:32 Changeset [56378] by eric@webkit.org

2010-03-22 Eric Seidel <eric@webkit.org>

Rubber-stamped by Brady Eidson.

fast/loader/cancel-load-during-port-block-timer.html fails on Tiger bot
https://bugs.webkit.org/show_bug.cgi?id=36425

This test bleeds into the next test and causes failures. Unsure of the
cause. Brady suggests we disable it for now (to match the other disabled) api test.

  • fast/loader/api-test-go-to-current-back-forward-item.html-disabled: Renamed from LayoutTests/fast/loader/api-test-go-to-current-back-forward-item.html.
22:03 Changeset [56377] by ukai@chromium.org

2010-03-22 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed build fix for Chromim Mac at r56376

Fix initializer order of PopupContainer.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer):
20:01 Changeset [56376] by eric@webkit.org

2010-03-22 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062

  • page/chromium/ChromeClientChromium.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::~PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupMenu::show):
  • platform/chromium/PopupMenuChromium.h: (WebCore::PopupContainer::): (WebCore::PopupContainer::popupType):

2010-03-22 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062

  • public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::popupClosed):
  • src/ChromeClientImpl.h:
  • src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::hideSelectPopup): (WebKit::WebViewImpl::popupOpened): (WebKit::WebViewImpl::popupClosed): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
  • src/WebViewImpl.h:
19:21 Changeset [56375] by dimich@chromium.org

[v8] Crash if the worker is terminated before its initial script is executed.
https://bugs.webkit.org/show_bug.cgi?id=36336

Reviewed by Nate Chapin.

WebCore:

Test: fast/workers/termination-early.html

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Check for 0 context. When terminated, the v8 heap initialization returns 0.
(WebCore::WorkerContextExecutionProxy::evaluate): Don't execute script if initialization failed.

  • bindings/v8/WorkerContextExecutionProxy.h:

LayoutTests:

  • fast/workers/termination-early-expected.txt: Added.
  • fast/workers/termination-early.html: Added.
19:11 Changeset [56374] by eric@webkit.org

2010-03-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Support creation of fake workers before document is loaded by deferring
attaching of fake workers iframe until document is loaded and buffering all
messages addressed to worker.
https://bugs.webkit.org/show_bug.cgi?id=36445

  • inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype._buildWorker): (InjectedFakeWorker.FakeWorker.prototype._attachWorkerFrameToDocument): (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded):
18:31 Changeset [56373] by eric@webkit.org

2010-03-22 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix qdoc warnings
https://bugs.webkit.org/show_bug.cgi?id=36447

  • Api/qgraphicswebview.cpp: Add missing ().
  • Api/qwebframe.cpp: Remove reference to non-existent parameter "url".
  • Api/qwebsettings.cpp: Document parameter "location".
18:13 Changeset [56372] by eric@webkit.org

2010-03-22 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Adam Barth.

Make build_webkit_command() pass MAKEFLAGS environment variable to make.
https://bugs.webkit.org/show_bug.cgi?id=36440

  • Scripts/webkitpy/webkitport.py:
  • Scripts/webkitpy/webkitport_unittest.py:
17:28 Changeset [56371] by mjs@apple.com

(Not reviewed.)

Add another example.

  • demos/accessible-ascii-art/butterfly-figure.html: Added.
17:28 Changeset [56370] by eric@webkit.org

2010-03-22 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] More efficient aligned memory allocation for JSC Collector
https://bugs.webkit.org/show_bug.cgi?id=34350

  • runtime/Collector.cpp: Reduced port-specific code and added private data member (JSC::Heap::Heap): (JSC::Heap::~Heap): (JSC::Heap::destroy): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr):
  • runtime/Collector.h: Added private data member
  • wtf/symbian: Added.
  • wtf/symbian/BlockAllocatorSymbian.cpp: Added. (WTF::AlignedBlockAllocator::AlignedBlockAllocator): Helper class to allocate aligned blocks more efficiently as required by Collector (WTF::AlignedBlockAllocator::alloc): (WTF::AlignedBlockAllocator::free): (WTF::AlignedBlockAllocator::destroy): (WTF::AlignedBlockAllocator::~AlignedBlockAllocator):
  • wtf/symbian/BlockAllocatorSymbian.h: Added.
16:51 Changeset [56369] by ossy@webkit.org

Unreviewed, skip new failing test.

fast/loader/stateobjects/replacestate-in-iframe.html caused infinite loop.
https://bugs.webkit.org/show_bug.cgi?id=36467

  • platform/gtk/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.
  • platform/qt/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.
16:43 Changeset [56368] by mjs@apple.com

(Not reviewed.)

Add example of accessible ASCII art for HTML WG.

  • demos/accessible-ascii-art: Added.
  • demos/accessible-ascii-art/butterfly.html: Added.
16:14 Changeset [56367] by japhet@chromium.org

2010-03-22 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium test fixes.

  • platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum:
  • platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
  • platform/chromium-mac/svg/filters/feColorMatrix-values-expected.checksum: Added.
  • platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/chromium-mac/svg/filters/feColorMatrix-values-expected.txt: Added.
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum: Added.
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt: Added.
16:04 Changeset [56366] by dpranke@chromium.org

2010-03-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Change baseline_path() to point to the upstream locations for the
Chromium ports. Also change the reabselining scripts to use the
correct functions to get the baseline directories, and fix the
script's sys.path to pull in simplejson correctly.

https://bugs.webkit.org/show_bug.cgi?id=36417

  • Scripts/rebaseline-chromium-webkit-tests:
    • fix sys.path to pick up simplejson properly
  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • change baseline_path() to use webkit_baseline_path()
    • error out correctly if we can't find the chromium base dir
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • call baseline_path(), not chromium_baseline_path()
15:57 Changeset [56365] by darin@chromium.org

2010-03-22 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

HistoryController::replaceState() should modify m_currentItem
instead of the current HistoryItem of the BackForwardList.

https://bugs.webkit.org/show_bug.cgi?id=36435

Test: fast/loader/stateobjects/replacestate-in-iframe.html

  • loader/HistoryController.cpp: (WebCore::HistoryController::replaceState):
15:54 Changeset [56364] by hausmann@webkit.org

Oops, fix spurious angle brackets around name in patch I landed manually

15:31 Changeset [56363] by joepeck@webkit.org

2010-03-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283> and <rdar://problem/7707318>

Part 3 of 3: Shared code between iphone and mac. The shared code was
refactored to be usable by both platforms without platform specific
typing, meaning no NSEvent versus WebEvent special cases.

Shared code usable by either mac or iphone platforms.

  • platform/cocoa/KeyEventCocoa.h:
  • platform/cocoa/KeyEventCocoa.mm: (WebCore::keyIdentifierForCharCode): (WebCore::windowsKeyCodeForKeyCode): (WebCore::windowsKeyCodeForCharCode):

Make use of the shared code. Keep anything platform specific in the
original file before calling the shared code.

  • platform/iphone/KeyEventIPhone.mm: (WebCore::keyIdentifierForKeyEvent):
  • platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent):
15:17 Rebaseline edited by dglazkov@chromium.org
(diff)
15:15 Rebaseline edited by dglazkov@chromium.org
Added title. (diff)
15:09 Rebaseline edited by dglazkov@chromium.org
Clean up rebaseline doc. (diff)
15:05 Changeset [56362] by kdecker@apple.com

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=36328

  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::updateWidget): Don't update the widget if we're showing the missing plug-in indicator. (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::paintReplaced): Ditto.
  • rendering/RenderEmbeddedObject.h: Ditto. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): Ditto. (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): Ditto.
  • Plugins/WebNetscapePluginView.mm:
  • Plugins/WebNullPluginView.h: Removed.
  • Plugins/WebNullPluginView.mm: Removed.
  • Resources/nullplugin.tiff: Removed.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.
14:56 Changeset [56361] by joepeck@webkit.org

2010-03-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>

Part 2 of 3: No changes other than moving code around.
Copied KeyEvent function from platform/mac to a platform/cocoa shared directory.

  • WebCore.xcodeproj/project.pbxproj: Added cocoa group and new files.
  • platform/cocoa/KeyEventCocoa.h: Added.
  • platform/cocoa/KeyEventCocoa.mm: Copied from WebCore/platform/mac/KeyEventMac.mm. (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent): Include the shared code.
  • platform/mac/KeyEventMac.mm:
14:24 Changeset [56360] by joepeck@webkit.org

2010-03-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Part 1 of 3: Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>

  • WebCore.xcodeproj/project.pbxproj: Added iphone group and new files.
  • platform/iphone: Added.
  • platform/iphone/KeyEventCodesIPhone.h: Added.
  • platform/iphone/KeyEventIPhone.mm: Added. Ensure PLATFORM(IPHONE)
  • platform/mac/KeyEventMac.mm: Ensure PLATFORM(MAC)
14:14 Changeset [56359] by kenneth@webkit.org

Unreviewed.

Skip editing test that fails

  • platform/qt/Skipped:
14:08 Changeset [56358] by krit@webkit.org

2010-03-22 Dirk Schulze <krit@webkit.org>

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

SVG Test has text in it. This caused a wrong DRT result on Mac.
The other result was created on Windows.

  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
13:38 Changeset [56357] by kdecker@apple.com

Attempt to fix the Leopard build.

  • rendering/RenderEmbeddedObject.cpp: Add ".f" to contants.
13:28 Changeset [56356] by krit@webkit.org

2010-03-22 Dirk Schulze <krit@webkit.org>

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Add missing expected result.

  • platform/mac/svg/filters/feColorMatrix-values-expected.txt: Added.
13:24 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
12:46 Changeset [56355] by krit@webkit.org

2010-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.

Tests: svg/filters/feColorMatrix-invalid-value.svg

svg/filters/feColorMatrix-values.svg

  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):

2010-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.

  • platform/win/svg/filters: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.checksum: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.txt: Added.
  • svg/filters/feColorMatrix-invalid-value-expected.txt: Added.
  • svg/filters/feColorMatrix-invalid-value.svg: Added.
  • svg/filters/feColorMatrix-values.svg: Added.
12:37 Changeset [56354] by philn@webkit.org

2010-03-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] Use ImageBuffer API to do painting
https://bugs.webkit.org/show_bug.cgi?id=35783

New ImageGStreamer class abstracting the conversion of GStreamer
buffers to cairo surfaces. Using this makes the painting code of
the player more generic.

  • GNUmakefile.am:
  • platform/graphics/gstreamer/ImageGStreamer.h: Added. (WebCore::ImageGStreamer::image):
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Added. (ImageGStreamer::createImage): (ImageGStreamer::ImageGStreamer): (ImageGStreamer::~ImageGStreamer):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
12:36 Changeset [56353] by bdakin@apple.com

Fix for <rdar://problem/7766437> With Web Inspector opened, a crash
occurs at Webcore:getMatchedCSSRules() when navigating to a
previous page

Reviewed by Darin Adler.

defaultView() can legitimately by null (as it is in this case), so
it must be null-checked.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getStyles):
(WebCore::InspectorDOMAgent::getComputedStyle):
(WebCore::InspectorDOMAgent::getMatchedCSSRules):

12:30 Changeset [56352] by kdecker@apple.com

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=36328


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin): Call setShowsMissingPluginIndicator(true) in cases that fail to generate a widget.
  • rendering/RenderEmbeddedObject.cpp: Added new missing plug-in related static constants (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Initialize newly boolean to false. (WebCore::RenderEmbeddedObject::paint): Added. (WebCore::RenderEmbeddedObject::paintReplaced): Added. Draws a subtle rounded rectangle containing the text "Missing Plug-in".
  • rendering/RenderEmbeddedObject.h: Added the following two methods below. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
  • rendering/RenderWidget.h: Moved paint(PaintInfo&, int, int) from private to protected.
11:45 Changeset [56351] by ap@apple.com

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=36455
Make WebKit more resistant against plug-in crashes

No tests, because crashing on build bots isn't good, even if it's only helper processes
that crash.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::waitForReply): Protect "this", because this function needs it after waiting for reply. Some callers used to do this, but not all, and we really shouldn't depend on callers here.
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::wheelEvent): Don't protect the plug-in instance proxy, because this function doesn't use it after waiting for reply. (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Ditto.
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Added an m_instanceProxy null check for another code path.
11:44 Changeset [56350] by japhet@chromium.org

2010-03-22 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium expectations tweak.

Add fast/dom/error-to-string-stack-overflow.html to expected
failures due to http://trac.webkit.org/changeset/56329.

  • platform/chromium/test_expectations.txt:
11:40 Changeset [56349] by jwieczorek@webkit.org

2010-03-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Phonon media backend: expose supported MIME types to WebCore

https://bugs.webkit.org/show_bug.cgi?id=33453

List all skipped media tests individually and unskip two fixed by the patch.

  • platform/qt/Skipped:

2010-03-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Phonon media backend: expose supported MIME types to WebCore

https://bugs.webkit.org/show_bug.cgi?id=33453

MediaPlayerPrivate should expose the MIME types that are supported
by the underlying backend in Phonon.

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::supportedTypesCache): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h:
11:33 Changeset [56348] by ggaren@apple.com

JavaScriptCore: Fixed <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)

Reviewed by Sam Weinig.

Two ways to fix the same bug:

  1. Check for overflow when negating, since negating the largest negative

int causes overflow.

  1. Constant-fold even when negating a negative, since, like they say in

high school, "math works."

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchNeg32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchNeg32): Added a branching version
of the negate operator.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate): Use the branching version of the negate
operator to check for overflow.

(JSC::JIT::emitSlow_op_negate): Link the check for overflow to a slow case.
(We could emit inline code for this, since we know what the result would
be, but that's probably just a waste of generated code.)

  • parser/Grammar.y: Constant fold even when negating a negative.

LayoutTests: Added a test for <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)

Reviewed by Sam Weinig.

  • fast/js/negate-overflow-expected.txt: Added.
  • fast/js/negate-overflow.html: Added.
11:18 Changeset [56347] by apavlov@chromium.org

2010-03-22 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: AuditRules still use getMatchedCSSRules as a part of the img-related audit.
https://bugs.webkit.org/show_bug.cgi?id=36424

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
11:17 Changeset [56346] by darin@chromium.org

2010-03-22 Darin Fisher <darin@chromium.org>

Reviewed by Nate Chapin.

[chromium] Renderer crashes when navigating to a reference fragment in
a frame that has no current HistoryItem.

https://bugs.webkit.org/show_bug.cgi?id=36443

Test: fast/loader/crash-replacing-location-before-load.html

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
10:51 Changeset [56345] by darin@apple.com

2010-03-22 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

TextBreakIteratorICU.cpp is incompatible with new UBreakIterator type in ICU 4.4
https://bugs.webkit.org/show_bug.cgi?id=36381

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Use reinterpret_cast instead of static_cast or relying on conversion to void*. (WebCore::textBreakFirst): Ditto. (WebCore::textBreakLast): Ditto. (WebCore::textBreakNext): Ditto. (WebCore::textBreakPrevious): Ditto. (WebCore::textBreakPreceding): Ditto. (WebCore::textBreakFollowing): Ditto. (WebCore::textBreakCurrent): Ditto. (WebCore::isTextBreak): Ditto. (WebCore::setUpIteratorWithRules): Ditto.
10:48 Changeset [56344] by eric.carlson@apple.com

2010-03-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

Typo in GPL license text
https://bugs.webkit.org/show_bug.cgi?id=36442

Fix typo - "aint with this library" -> "along with this library".

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/IDLParser.pm:
  • bindings/scripts/IDLStructure.pm:
  • bindings/scripts/generate-bindings.pl:
10:42 Changeset [56343] by jwieczorek@webkit.org

2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373

Instead, keep one instance per RenderTheme around.

  • platform/qt/RenderThemeQt.cpp: (WebCore::findFrameLineWidth):

2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373

Add a simple benchmark covering this area.

  • tests/benchmarks/painting/tst_painting.cpp: (tst_Painting::textAreas):
10:39 Changeset [56342] by ddkilzer@apple.com

<http://webkit.org/b/36431> Clean up 'int' use in UString.cpp after r54789

Reviewed by Darin Adler.

  • runtime/UString.cpp:

(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
(JSC::UString::find): Changed static_cast<int>() to
static_cast<unsigned>() now that this method returns unsigned.
(JSC::UString::rfind): Ditto.

  • runtime/UString.h:

(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.

10:38 Changeset [56341] by eric@webkit.org

2010-03-22 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Multiselect Popup - adjusting QtAbstractWebPopup
https://bugs.webkit.org/show_bug.cgi?id=36186

QtAbstractWebPopup must provide new methods to be used by its descendants that
wish to handle <select multiple> elements.

  • platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::selectItem): (WebCore::QtAbstractWebPopup::multiple):
  • platform/qt/QtAbstractWebPopup.h:
10:20 Changeset [56340] by eric@webkit.org

2010-03-22 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Basic tests of mfrac (fractions)

  • mathml/presentation/fractions.xhtml: Added.
  • mathml/presentation/fractions-vertical-alignment.xhtml: Added
  • platform/mac/mathml/presentation/fractions-expected.checksum: Added.
  • platform/mac/mathml/presentation/fractions-expected.png: Added.
  • platform/mac/mathml/presentation/fractions-expected.txt: Added.
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum: Added.
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.

2010-03-22 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added basic support for mfrac (fractions)

Test: mathml/presentation/fractions.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/RenderMathMLFraction.cpp: Added. (WebCore::RenderMathMLFraction::RenderMathMLFraction): (WebCore::RenderMathMLFraction::updateFromElement): (WebCore::RenderMathMLFraction::addChild):
  • mathml/RenderMathMLFraction.h: Added.
09:47 Changeset [56339] by darin@apple.com

WebKit: * StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit/win: * WebCoreLocalizedStrings.cpp:
(WebCore::missingPluginText): Fixed localization helper text to match the same
string from Mac WebKit.

09:46 Rebaseline created by dglazkov@chromium.org
Ported rebaseline tool documentation from Chromium wiki
09:45 Changeset [56338] by ap@apple.com

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=36400
Add a test for r15750 (Flash crashes after it replaces itself via a document.write())

  • plugins/destroy-plugin-from-callback-expected.txt: Added.
  • plugins/destroy-plugin-from-callback.html: Added.
09:29 Changeset [56337] by kdecker@apple.com

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=36328

  • page/mac/WebCoreViewFactory.h: Added -missingPluginText method
  • platform/LocalizedStrings.h: Added missingPluginText()
  • platform/gtk/LocalizedStringsGtk.cpp: Likewise.
  • platform/mac/LocalizedStringsMac.mm: Same here.
  • platform/qt/Localizations.cpp: Ditto.
  • English.lproj/Localizable.strings: Added "Missing Plug-in" string.
  • src/LocalizedStrings.cpp: (WebCore::missingPluginText): Added
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory missingPluginText]): Added.
09:24 Changeset [56336] by eric@webkit.org

2010-03-22 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

Refactored the cpu_count() code in executive.py.

https://bugs.webkit.org/show_bug.cgi?id=36437

  • Scripts/webkitpy/executive.py:
    • Moved the import of the multiprocessing module to the top of the file rather than importing from within a function.
08:24 Changeset [56335] by tonikitoo@webkit.org

Revert "2010-03-18 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>"

This reverts commit d76f355a659be5b3384f9c26bc6ad64f3256c9fb.

Conflicts:

WebKitTools/ChangeLog

08:09 Changeset [56334] by eric@webkit.org

2010-03-22 Yi Shen <shenyi2006@gmail.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=35933
[Qt] [Symbian] Can not backward select (highlight) text using virtual keyboard
Make sure the selection start index is smaller than the selection end index.

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
07:37 Changeset [56333] by eric@webkit.org

2010-03-22 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add support for syntax checking in the QtScript API.

New class was created; the QScriptSyntaxCheckResult which main
responsibility is to provide results of the ECMA Script code
syntax check. The class is not fully functional as the JSC C API
doesn't expose an error column number, but it is a good start point
for a future development.

[Qt] QtScript functionality should be extended by syntax checking.
https://bugs.webkit.org/show_bug.cgi?id=36123

  • qt/api/QtScript.pro:
  • qt/api/qscriptengine.cpp: (QScriptEngine::checkSyntax):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::checkSyntax):
  • qt/api/qscriptengine_p.h:
  • qt/api/qscriptsyntaxcheckresult.cpp: Added. (QScriptSyntaxCheckResult::QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::~QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::operator=): (QScriptSyntaxCheckResult::state): (QScriptSyntaxCheckResult::errorLineNumber): (QScriptSyntaxCheckResult::errorColumnNumber): (QScriptSyntaxCheckResult::errorMessage):
  • qt/api/qscriptsyntaxcheckresult.h: Added.
  • qt/api/qscriptsyntaxcheckresult_p.cpp: Added. (QScriptSyntaxCheckResultPrivate::~QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::errorMessage): (QScriptSyntaxCheckResultPrivate::errorLineNumber):
  • qt/api/qscriptsyntaxcheckresult_p.h: Added. (QScriptSyntaxCheckResultPrivate::get): (QScriptSyntaxCheckResultPrivate::QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::state): (QScriptSyntaxCheckResultPrivate::errorColumnNumber):
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::checkSyntax_data): (tst_QScriptEngine::checkSyntax):
06:26 Changeset [56332] by yurys@chromium.org

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Fix inspected Page crash in destructor when Web Inspector is open.

https://bugs.webkit.org/show_bug.cgi?id=36441

  • src/js/InjectDispatch.js: (inspectedPageDestroyed): Added stub for missing method.
05:49 Changeset [56331] by cjerdonek@webkit.org

Created a function for getting a module-specific logging.logger
based on the file value of the module.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35821

This function allows us to get the module-specific logger for
a module without having to hard-code the fully-qualified name
of the module in the module itself. The code can be the same
in every case: "_log = logutils.get_logger(file)".

  • Scripts/webkitpy/init/logutils.py: Added.
    • Added a module with a get_logger() function to return a module-specific logger based on the module's file variable.
  • Scripts/webkitpy/init/logutils_unittest.py: Added.
    • Added unit tests for logutils.py.
  • Scripts/webkitpy/init/unittests.py:
    • Added logutils_unittest to the list of imports.
04:43 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
04:07 Changeset [56330] by eric@webkit.org

2010-03-22 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Added methods to WebSecurityOrigin for invoking
SecurityOrigin::canAccess and SecurityOrigin::Create
https://bugs.webkit.org/show_bug.cgi?id=36356

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::create): (WebKit::WebSecurityOrigin::canAccess):
02:46 Changeset [56329] by yurys@chromium.org

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Handle worker exceptions in V8MessageHandler like it's done in regular documents. This way all worker exceptions will be logged in the console not only those which happen in event listeners.

https://bugs.webkit.org/show_bug.cgi?id=31171

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): Removed explicit call to reportException.
  • bindings/v8/V8Utilities.cpp: reportException function was removed since it's not used. (WebCore::getScriptExecutionContext):
  • bindings/v8/V8Utilities.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::v8MessageHandler): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Setup message handler when first worker context is created.

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that uncaught exception thrown from setTimeout callback in a Worker is reported to the worker object.

https://bugs.webkit.org/show_bug.cgi?id=31171

  • fast/workers/resources/worker-exception-in-timeout-callback.js: Added.
  • fast/workers/worker-script-error-expected.txt:
  • fast/workers/worker-script-error.html:
02:43 Changeset [56328] by eric@webkit.org

2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386

  • platform/qt/Skipped: unskip the test as it now passes.

2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386

Fix the regression by implementing a null printer for Qt DRT.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::NullPrinter::NullPaintEngine::begin): (WebCore::NullPrinter::NullPaintEngine::end): (WebCore::NullPrinter::NullPaintEngine::type): (WebCore::NullPrinter::NullPaintEngine::drawPixmap): (WebCore::NullPrinter::NullPaintEngine::updateState): (WebCore::NullPrinter::paintEngine): (WebCore::DumpRenderTree::dryRunPrint):
02:24 Changeset [56327] by eric@webkit.org

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to page/EventHandler.cpp.
http://webkit.org/b/36306

  • page/EventHandler.cpp:
02:06 Changeset [56326] by eric@webkit.org

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/DragImage.h and
platform/DragData.h.
http://webkit.org/b/36310

  • platform/DragImage.h:
  • platform/DragData.h:
01:45 Changeset [56325] by eric@webkit.org

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/FileSystem.h.
http://webkit.org/b/36313

  • platform/FileSystem.h:
01:26 Changeset [56324] by eric@webkit.org

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/Cursor.h.
http://webkit.org/b/36319

  • platform/Cursor.h:
01:05 Changeset [56323] by eric@webkit.org

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/NotImplemented.h.
http://webkit.org/b/36320

  • platform/NotImplemented.h:

03/21/10:

16:21 Changeset [56322] by eric@webkit.org

2010-03-21 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Fixed updating the VKB display when inputting into QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=36292

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_updateMicroFocus): (QGraphicsWebView::setPage):
  • Api/qgraphicswebview.h:
15:52 Changeset [56321] by eric@webkit.org

2010-03-21 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: matrix interpolations in transform-animations don't behave correctly
https://bugs.webkit.org/show_bug.cgi?id=35520

The case where the list of source and target transform operations are
not the same but have the same size needs to be special-cased in
GraphicsLayerQt, as well as the case where the source or target
operation list is empty. The URLs listed here render correctly after
applying the patch.

Tests: https://bug-35520-attachments.webkit.org/attachment.cgi?id=49890

https://bug-35520-attachments.webkit.org/attachment.cgi?id=49889

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::TransformAnimationQt::applyFrame):
15:30 Changeset [56320] by eric@webkit.org

2010-03-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

New class; QScriptProgram.

The class should be used to evaluate the same script multiple times
more efficiently.

[Qt] QtScript should have QScriptProgram class
https://bugs.webkit.org/show_bug.cgi?id=36008

  • qt/api/QtScript.pro:
  • qt/api/qscriptengine.cpp: (QScriptEngine::evaluate):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::evaluate):
  • qt/api/qscriptengine_p.h: (QScriptEnginePrivate::evaluate):
  • qt/api/qscriptprogram.cpp: Added. (QScriptProgram::QScriptProgram): (QScriptProgram::~QScriptProgram): (QScriptProgram::operator=): (QScriptProgram::isNull): (QScriptProgram::sourceCode): (QScriptProgram::fileName): (QScriptProgram::firstLineNumber): (QScriptProgram::operator==): (QScriptProgram::operator!=):
  • qt/api/qscriptprogram.h: Added.
  • qt/api/qscriptprogram_p.h: Added. (QScriptProgramPrivate::get): (QScriptProgramPrivate::QScriptProgramPrivate): (QScriptProgramPrivate::~QScriptProgramPrivate): (QScriptProgramPrivate::isNull): (QScriptProgramPrivate::sourceCode): (QScriptProgramPrivate::fileName): (QScriptProgramPrivate::firstLineNumber): (QScriptProgramPrivate::operator==): (QScriptProgramPrivate::operator!=): (QScriptProgramPrivate::program): (QScriptProgramPrivate::file): (QScriptProgramPrivate::line):
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::evaluateProgram):
15:19 Changeset [56319] by ddkilzer@apple.com

<http://webkit.org/b/14858> <col> width ignored when not tied to a single cell

Patch by Dmitry Gorbik <socket.h@gmail.com> on 2010-03-21
Reviewed by David Kilzer.

Fixed width calculation for cells with span when <col> is defined.

WebCore:

Test: fast/table/col-width-span-expand.html

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColWidth): Added the calculation of cell width
in case of <col> defined and span > 1.

LayoutTests:

  • fast/table/col-width-span-expand-expected.txt: Added.
  • fast/table/col-width-span-expand.html: Added.
13:08 Changeset [56318] by ddkilzer@apple.com

Blind attempt #2 to fix the Windows build after r56314

  • API/tests/testapi.c: Include JSObjectRefPrivate.h for the new

methods instead of declaring them locally (and non-extern).

Backed out previous change.

12:56 Changeset [56317] by ddkilzer@apple.com

Blind attempt to fix the Windows build after r56314

Try to fix the following errors on the Windows buildbot:

Linking...
testapi.obj : error LNK2001: unresolved external symbol "bool cdecl JSObjectSetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *,struct OpaqueJSValue const *)" (?JSObjectSetPrivateProperty@@YA_NPBUOpaqueJSContext@@PAUOpaqueJSValue@@PAUOpaqueJSString@@PBU2@@Z)
testapi.obj : error LNK2001: unresolved external symbol "struct OpaqueJSValue const *
cdecl JSObjectGetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *)" (?JSObjectGetPrivateProperty@@YAPBUOpaqueJSValue@@PBUOpaqueJSContext@@PAU1@PAUOpaqueJSString@@@Z)
C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\bin\testapi.exe : fatal error LNK1120: 2 unresolved externals

missing symbols to be exported.

12:09 Changeset [56316] by mrobinson@webkit.org

2010-03-20 Martin Robinson <mrobinson@webkit.org>

Reviewed by Xan Lopez

[GTK] eventSender.zoomPageOut() bug?
https://bugs.webkit.org/show_bug.cgi?id=30575

Unskip some tests that were failing because of the bug in DRT.

  • platform/gtk/Skipped:

2010-03-20 Martin Robinson <mrobinson@webkit.org>

Reviewed by Xan Lopez.

[GTK] eventSender.zoomPageOut() bug?
https://bugs.webkit.org/show_bug.cgi?id=30575

Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using.

  • DumpRenderTree/gtk/EventSender.cpp: (zoomIn): Added. (zoomOut): Added. (textZoomInCallback): Use zoomIn helper function. (textZoomOutCallback): Use zoomOut helper function. (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor. (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor.
05:22 QtWebKitPlugins edited by yael.aharon@nokia.com
(diff)
01:35 Changeset [56315] by oliver@apple.com

Documentation fix for previous patch.

Reviewed by Maciej Stachowiak.

  • API/JSObjectRefPrivate.h:
00:40 Changeset [56314] by oliver@apple.com

2010-03-20 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC needs an API to allow custom objects to have aprivate GC-accessible properties
https://bugs.webkit.org/show_bug.cgi?id=36420

Add new API methods to support "private" properties on custom
objects.

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::JSCallbackObjectData): (JSC::JSCallbackObjectData::~JSCallbackObjectData): (JSC::JSCallbackObjectData::getPrivateProperty): (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::deletePrivateProperty): (JSC::JSCallbackObjectData::markChildren): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::deletePrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::getPrivateProperty): (JSC::JSCallbackObject::setPrivateProperty): (JSC::JSCallbackObject::deletePrivateProperty): (JSC::JSCallbackObject::markChildren):
  • API/JSObjectRef.cpp: (JSObjectGetPrivateProperty): (JSObjectSetPrivateProperty): (JSObjectDeletePrivateProperty):
  • API/JSObjectRefPrivate.h: Added.
  • API/tests/testapi.c: (main):
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:

03/20/10:

19:45 Changeset [56313] by kevino@webkit.org

[wx] Build fix after recent database API change.

17:39 Changeset [56312] by eric@webkit.org

2010-03-20 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

Renamed UnitTestLogStream to TestLogStream in webkitpy.

https://bugs.webkit.org/show_bug.cgi?id=36099

TestLogStream is more concise and more consistent with the name of
the module (logtesting rather than logunittesting) and its main
class (LogTesting rather than LogUnitTesting).

  • Scripts/webkitpy/init/logtesting.py:
    • Renamings.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Renamings.
  • Scripts/webkitpy/style_references.py:
    • Renamings.
15:20 Changeset [56311] by tonikitoo@webkit.org

Spatial Navigation: Code simplification in FocusController.cpp and SpatialNavigation.cpp (part I)
https://bugs.webkit.org/show_bug.cgi?id=36168

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Make use of isNull and document methods introduced in FocusCandidate class by patch in bug 36167.
No functionalty change.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

  • page/SpatialNavigation.cpp:

(WebCore::distanceInDirection):

14:00 Changeset [56310] by dpranke@chromium.org

2010-03-20 Dirk Pranke <dpranke@chromium.org>

Unreviewed change.

Fix typo in Changelog.

  • WebKitTools/ChangeLog:
13:05 Changeset [56309] by kevino@webkit.org

[wx] Build fixes after recent changes.

12:21 Changeset [56308] by dglazkov@chromium.org

Unreviewed, expectations tweak.

Remove expectations for chromium-mac editing/style/apply-through-end-of-document.html as it
now matches platform/mac.

  • platform/chromium-mac/editing/style/apply-through-end-of-document-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Adjusted expectations.
12:10 Changeset [56307] by dglazkov@chromium.org

Unreviewed, tool fix.

Remove vestiges of downstream directory names to unbreak rebaselining tool.

  • Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo.
10:21 Changeset [56306] by dglazkov@chromium.org

2010-03-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Re-enable the downstream test_expectations overrides file that was
disabled in bug 36396 / r56287.

https://bugs.chromium.org/show_bug.cgi?id=36401

  • Scripts/webkitpy/layout_tests/port/chromium.py:
10:14 Changeset [56305] by dglazkov@chromium.org

Unreviewed, expectations tweak.

Mark editing/style/apply-through-end-of-document.html as failing

  • platform/chromium/test_expectations.txt:
09:56 Changeset [56304] by dglazkov@chromium.org

Unreviewed, expectations tweak.

Marked svg/filters/filterRes.svg as failing after
http://trac.webkit.org/changeset/56288/

  • platform/chromium/test_expectations.txt: Added expectations for svg/filters/filterRes.svg.
09:31 Changeset [56303] by dglazkov@chromium.org

2010-03-20 Dimitri Glazkov <dglazkov@chromium.org>

No review, rolling out r56294.
http://trac.webkit.org/changeset/56294
https://bugs.webkit.org/show_bug.cgi?id=36262

Broke compile on Chromium canaries.

  • WebKit.gyp:
  • public/WebGraphicsContext3D.h: Removed.
  • public/WebKitClient.h:
  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::): (WebCore::GraphicsContext3DInternal::GLConnection::chooseFBConfig): (WebCore::GraphicsContext3DInternal::GLConnection::createNewContext): (WebCore::GraphicsContext3DInternal::GLConnection::createPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::destroyPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::makeCurrent): (WebCore::GraphicsContext3DInternal::GLConnection::destroyContext): (WebCore::GraphicsContext3DInternal::GLConnection::getCurrentContext): (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::create): (WebCore::GraphicsContext3DInternal::GLConnection::~GLConnection): (WebCore::GraphicsContext3DInternal::VertexAttribPointerState::VertexAttribPointerState): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::createTextureObject): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::flipVertically): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::activeTexture): (WebCore::GraphicsContext3DInternal::bindBuffer): (WebCore::GraphicsContext3DInternal::bindFramebuffer): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferDataImpl): (WebCore::GraphicsContext3DInternal::disableVertexAttribArray): (WebCore::GraphicsContext3DInternal::enableVertexAttribArray): (WebCore::GraphicsContext3DInternal::getError): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::vertexAttribPointer): (WebCore::GraphicsContext3DInternal::viewportImpl): (WebCore::GraphicsContext3DInternal::synthesizeGLError): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::endPaint): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getContextAttributes): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::synthesizeGLError): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport):
  • src/WebGraphicsContext3D.cpp: Removed.
  • src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
  • src/WebGraphicsContext3DDefaultImpl.h: Removed.
02:07 Changeset [56302] by mjs@apple.com

2010-03-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

WebKit blog should be valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=36410

  • blog/wp-content/themes/webkit/comments-popup.php:
  • blog/wp-content/themes/webkit/footer.php:
  • blog/wp-content/themes/webkit/header.php:
02:04 Changeset [56301] by joepeck@webkit.org

2010-03-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Assertion failure in media/video-controls-with-mutation-event-handler.html
https://bugs.webkit.org/show_bug.cgi?id=36376

Test: media/video-controls-with-mutation-event-handler.html

Break early (when not attached) in the defaultEventHandler before the
slider is completely set up.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler): (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):
01:12 Changeset [56300] by mjs@apple.com

2010-03-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

Fix a bunch of HTML5 validation errors on various pages.
https://bugs.webkit.org/show_bug.cgi?id=36409

  • building/build.html:
  • building/checkout.html:
  • building/debug.html:
  • building/run.html:
  • building/tools.html:
  • coding/coding-style.html:
  • coding/contributing.html:
  • coding/major-objects.html:
  • css/main.css: (.asciiart):
  • demos/index.html:
  • header.inc:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/goals.html:
  • projects/index.html:
  • projects/mathml/index.html:
  • quality/bugpriorities.html:
  • quality/bugwriting.html:
  • quality/crashlogs.html:
  • quality/lifecycle.html:
  • quality/testing.html:
  • quality/testwriting.html:
00:24 Changeset [56299] by mjs@apple.com

2010-03-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

webkit.org should use the HTML5 doctype
https://bugs.webkit.org/show_bug.cgi?id=36407

  • header.inc:
  • misc/drosera/index.html:
  • perf/slickspeed/system/index.php:
  • perf/slickspeed/system/template.php:
  • specs/index.html:

03/19/10:

23:42 Changeset [56298] by mjs@apple.com

2010-03-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

http://webkit.org/ has an HTML5 validation error
https://bugs.webkit.org/show_bug.cgi?id=36406

  • nav.inc:
22:29 Changeset [56297] by hamaji@chromium.org

2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c)
https://bugs.webkit.org/show_bug.cgi?id=34641

  • fast/css/first-letter-block-form-controls-crash-expected.txt: Added.
  • fast/css/first-letter-block-form-controls-crash.html: Added.

2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c)
https://bugs.webkit.org/show_bug.cgi?id=34641

Don't dig into buttons and menu lists when finding which element
should be modified by :first-letter pseudo class. Even before
this change, we didn't dig into inline buttons and menu lists as
they are replaced so this issue wasn't found long time.

Test: fast/css/first-letter-block-form-controls-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
21:29 Changeset [56296] by mrowe@apple.com

Land a test result that should have been added along with the test in r56286.

  • transitions/transition-end-event-destroy-iframe-expected.txt: Copied from LayoutTests/transitions/transition-end-event-destroy-renderer-expected.txt.
20:55 Changeset [56295] by eric@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Change XSSAuditor block syntax
https://bugs.webkit.org/show_bug.cgi?id=34436

Update tests to account for the new blocking syntax. Added test for
disabling the XSS filter.

  • http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header.html:
  • http/tests/security/xssAuditor/no-protection-script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/no-protection-script-tag.html: Added.
  • http/tests/security/xssAuditor/resources/echo-head-base-href.pl:
  • http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl:
  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt: Added.
  • http/tests/security/xssAuditor/xss-protection-parsing-01.html: Added.

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Change XSSAuditor block syntax
https://bugs.webkit.org/show_bug.cgi?id=34436

Update our blocking syntax to something more reasonable. Also,
implemented a way for a web site to disable the filter.

Tests: http/tests/security/xssAuditor/no-protection-script-tag.html

http/tests/security/xssAuditor/xss-protection-parsing-01.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::xssProtection): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h:
  • platform/network/HTTPParsers.cpp: (WebCore::skipToken): (WebCore::parseXSSProtectionHeader):
  • platform/network/HTTPParsers.h: (WebCore::):
20:35 Changeset [56294] by eric@webkit.org

2010-03-19 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add GraphicsContext3D abstraction to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36262

Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
GraphicsContext3D implementation to use it. All of the OpenGL calls have
been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
WebGraphicsContext3D implementation. GraphicsContext3D is still
responsible for the transfer of rendered output from the
WebGraphicsContext3D to the HTMLCanvasElement.

The GraphicsContext3DInternal class, which is a data member of
GraphicsContext3D for the Chromium port, remains. It is possible to
eliminate this class and thereby one level of delegation, but this is
being deferred.

The needed entry point for a Chrome implementation of
WebGraphicsContext3D has been added to WebKitClient, but it is not being
called yet by GraphicsContext3D. It will be once this patch lands and
Chromium is rolled forward to support this entry point.

This is a large patch, but the transformation is almost entirely
mechanical and there is no change in functionality. Nearly all of
GraphicsContext3D and GraphicsContext3DInternal has been moved to
WebGraphicsContext3DDefaultImpl. The only area where the splitting of
logic is less than mechanical is GraphicsContext3D::beginPaint() and its
callees.

Ran all WebGL layout tests and demos from Khronos site in Chromium.

  • WebKit.gyp:
  • public/WebGraphicsContext3D.h: Added. (WebKit::WebGraphicsContext3D::Attributes::Attributes): (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
  • public/WebKitClient.h: (WebKit::WebKitClient::createGraphicsContext3D):
  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::endPaint): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::readPixels): (WebCore::GraphicsContext3DInternal::shaderSource): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
  • src/WebGraphicsContext3D.cpp: Added. (WebKit::WebGraphicsContext3D::createDefault):
  • src/WebGraphicsContext3DDefaultImpl.cpp: Added. (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection): (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState): (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::width): (WebKit::WebGraphicsContext3DDefaultImpl::height): (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes): (WebKit::createTextureObject): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture): (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::drawElements): (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::getError): (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::getString): (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createProgram): (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createTexture): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram): (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture): (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
  • src/WebGraphicsContext3DDefaultImpl.h: Added. (WebKit::WebGraphicsContext3DDefaultImpl::): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):
20:03 Changeset [56293] by eric@webkit.org

2010-03-19 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dmitry Titov.

Refactor DatabaseTracker.cpp for thread safety
https://bugs.webkit.org/show_bug.cgi?id=34991

This enables calling into DatabaseTracker from multiple context threads,
as will happen once Workers can access the Database. It required a fair
amount of reshuffling of locks. I ended up splitting the public
interface [calls that take locks and call private functions] from the
implementations [calls that assert that locks are already held] in order
to avoid lock conflicts. I also had to make sure we weren't sharing
Strings or SecurityOrigins across threads.

No new tests.

Allow access to database handles from multiple threads IFF SQLite is new enough and the user requests it.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::disableThreadingChecks):
  • platform/sql/SQLiteDatabase.h: (WebCore::SQLiteDatabase::sqlite3Handle): (WebCore::SQLiteDatabase::disableThreadingChecks):

Remove an asynchronous call from Database::close back to the execution thread, so that cleanup can be more deterministic.

  • storage/Database.cpp: (WebCore::Database::markAsDeletedAndClose): (WebCore::Database::close):
  • storage/Database.h: (WebCore::Database::):
  • storage/DatabaseDetails.h: (WebCore::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::thread):
  • storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::doPerformTask):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread):

Any Strings that get stored in DatabaseTracker, and any Strings returned from DatabaseTracker, are now threadsafeCopies.
Public functions now take all needed locks, then generally call only private functions [there are a few exceptions: deletion functions and origins()].
Private functions no longer take locks.
m_quotaMapGuard becomes m_databaseGuard, and now protects m_database, m_quotaMap, m_proposedDatabases, m_databaseDirectoryPath, m_originsBeingDeleted, m_beingCreated, and m_beingDeleted.
m_proposedDatabases replaces m_proposedDatabase, to account for reentrancy.

  • storage/DatabaseTracker.h:
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originQuotaManagerNoLock): (WebCore::DatabaseTracker::originQuotaManager): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::setDatabaseDirectoryPath): (WebCore::DatabaseTracker::databaseDirectoryPath): (WebCore::DatabaseTracker::trackerDatabasePath): (WebCore::DatabaseTracker::openTrackerDatabase): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOriginNoLock): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::hasEntryForDatabase): (WebCore::DatabaseTracker::originPath): (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOriginNoLock): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::detailsForNameAndOrigin): (WebCore::DatabaseTracker::setDatabaseDetails): (WebCore::DatabaseTracker::usageForDatabase): (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::usageForOriginNoLock): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOriginNoLock): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile): (WebCore::DatabaseTracker::setClient): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): (WebCore::DatabaseTracker::notifyDatabasesChanged):

These functions keep track of in-progress deletions and creations, so that we can make sure nobody every deletes a database file while a live database is using it.
(WebCore::DatabaseTracker::canCreateDatabase):
(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::creatingDatabase):
(WebCore::DatabaseTracker::canDeleteDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::doneDeletingDatabase):
(WebCore::DatabaseTracker::deletingDatabase):
(WebCore::DatabaseTracker::canDeleteOrigin):
(WebCore::DatabaseTracker::deletingOrigin):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::doneDeletingOrigin):

Any SecurityOrigins stored in OriginQuotaManager are now threadsafeCopies of inputs. There's a new tryLock() function in addition to the existing lock().

  • storage/OriginQuotaManager.cpp: (WebCore::OriginQuotaManager::tryLock): (WebCore::OriginQuotaManager::trackOrigin):
  • storage/OriginQuotaManager.h:
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::databaseIdentifier): Removed DEFINE_STATIC_LOCAL wrapper on a local variable; it appears to have been a small optimization, but it's not thread-safe.
19:35 Changeset [56292] by eric@webkit.org

2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

Multiselect popups - rendering
https://bugs.webkit.org/show_bug.cgi?id=36006

The objective of this patch is to create a compile time flag that can be used
to force all <select> elements to be rendered as menu lists.

Theme stylesheet mechanism has been used to change the appearance of the elements.

Class QtStyleOptionWebComboBox has been introduced to provide to QStyle objects
the needed information to render <select multiple> comboboxes.

  • WebCore.pri:
  • WebCore.pro:
  • css/themeQtNoListboxes.css: Added. (select[size][multiple]):
  • dom/SelectElement.h: (WebCore::SelectElementData::usesMenuList):
  • platform/qt/QtStyleOptionWebComboBox.h: Added. (WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox): (WebCore::QtStyleOptionWebComboBox::multiple): (WebCore::QtStyleOptionWebComboBox::checkMultiple):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton):
  • platform/qt/RenderThemeQt.h:
18:58 Changeset [56291] by eric@webkit.org

2010-03-19 Zhenyao Mo <zmo@google.com>

Reviewed by Oliver Hunt.

Update WebGLArray.slice() to new spec
https://bugs.webkit.org/show_bug.cgi?id-35612

  • fast/canvas/webgl/array-unit-tests-expected.txt: Changed tests to reflect the new slice parameters; add new test cases for default inputs for slice.
  • fast/canvas/webgl/array-unit-tests.html: Ditto.
  • fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt: Changed tests to reflect the new slice parameters.
  • fast/canvas/webgl/webgl-array-invalid-ranges.html: Ditto.

2010-03-19 Zhenyao Mo <zmo@google.com>

Reviewed by Oliver Hunt.

Update WebGLArray.slice() to new spec
https://bugs.webkit.org/show_bug.cgi?id-35612

  • bindings/js/JSWebGLArrayCustom.cpp: Adding support for default inputs. (WebCore::JSWebGLArray::slice):
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Ditto. (WebCore::V8WebGLArray::sliceCallback):
  • html/canvas/WebGLArray.cpp: Map start/end to offset/length. (WebCore::WebGLArray::calculateOffsetAndLength):
  • html/canvas/WebGLArray.h: Modified slice parameters.
  • html/canvas/WebGLArray.idl: Define custom binding for slice().
  • html/canvas/WebGLByteArray.cpp: Modified slice parameters. (WebCore::WebGLByteArray::slice):
  • html/canvas/WebGLByteArray.h: Ditto.
  • html/canvas/WebGLFloatArray.cpp: Ditto. (WebCore::WebGLFloatArray::slice):
  • html/canvas/WebGLFloatArray.h: Ditto.
  • html/canvas/WebGLIntArray.cpp: Ditto. (WebCore::WebGLIntArray::slice):
  • html/canvas/WebGLIntArray.h: Ditto.
  • html/canvas/WebGLShortArray.cpp: Ditto. (WebCore::WebGLShortArray::slice):
  • html/canvas/WebGLShortArray.h: Ditto.
  • html/canvas/WebGLUnsignedByteArray.cpp: Ditto. (WebCore::WebGLUnsignedByteArray::slice):
  • html/canvas/WebGLUnsignedByteArray.h: Ditto.
  • html/canvas/WebGLUnsignedIntArray.cpp: Ditto. (WebCore::WebGLUnsignedIntArray::slice):
  • html/canvas/WebGLUnsignedIntArray.h: Ditto.
  • html/canvas/WebGLUnsignedShortArray.cpp: Ditto. (WebCore::WebGLUnsignedShortArray::slice):
  • html/canvas/WebGLUnsignedShortArray.h: Ditto.
18:39 Changeset [56290] by eric@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Freeze sandbox attributes on creation
https://bugs.webkit.org/show_bug.cgi?id=34184

Test that allow-forms is frozen on document creation.

  • fast/frames/resources/sandboxed-iframe-form-dynamic-allowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-form-dynamic-disallowed.html: Added.
  • fast/frames/sandboxed-iframe-forms-dynamic-expected.txt: Added.
  • fast/frames/sandboxed-iframe-forms-dynamic.html: Added.
18:20 Changeset [56289] by eric@webkit.org

2010-03-19 Yong Li <yong.li@torchmobile.com> and Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Ensure the segments inside SharedBuffer are merged before constructing
a CFData with it.

https://bugs.webkit.org/show_bug.cgi?id=50843

  • manual-tests/WebKitSite.webarchive: Added.
  • manual-tests/webarchive-test.html: Added.
  • platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::createCFData):
17:45 Changeset [56288] by oliver@apple.com

2010-03-19 Justin Schuh <jschuh@chromium.org>

Reviewed by Oliver Hunt.

Security: ReadAV@NULL for negative feMorphology filter radius
https://bugs.webkit.org/show_bug.cgi?id=34566

Prevents building the filter if either radius is negative.
Catches negative radii resulting from conversions.

Test: svg/filters/feMorphology-invalid-radius.svg

  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
17:41 Changeset [56287] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Disable the downstream override expectations temporarily to allow
us to test that we've upstreamed everything correctly. Also, stop
looking at the downstream baselines at all (now you will only be
able to update baselines upstream). In theory this should work, but
if we need to we can always add the downstream dirs back in.

https://bugs.webkit.org/show_bug.cgi?id=36396

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
17:28 Changeset [56286] by cmarrin@apple.com

Fixed a crash with AnimationController getting deleted out from under itself.


It's possible for the Frame that owns an AnimationController to get deleted
in the EndTransitionEvent (or other animation events) to get deleted in the
event handler. Normally this case is protected against by preventing the Frame
from getting deleted until the end of the runloop. But native uses of the
WebView can subvert this protection. So I added a protector to the
animation event dispatcher to protect it in those cases.

17:08 Changeset [56285] by eric@webkit.org

2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

Multiselect Popup - PopupMenuClient extension
https://bugs.webkit.org/show_bug.cgi?id=36178

PopupMenuClient class is the interface used by combobox popup implementations.
It needs to be extended to handle <select multiple> needs.

A new interface named ListPopupMenuClient that inherits from PopupMenuClient was created.
The use of this new class instead of adding methods to PopupMenuClient avoids changes
in other non related implementations of PopupMenuClient.

RenderMenuList has changed to inherit ListPopupMenuClient instead of PopupMenuClient
and to have the new methods implemented.

  • platform/PopupMenuClient.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listBoxSelectItem): (WebCore::RenderMenuList::multiple):
  • rendering/RenderMenuList.h:
16:42 Changeset [56284] by simon.fraser@apple.com

2010-03-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=36387
REGRESSION: Can "uncheck" radio buttons by clicking on them

My change in r56174 caused radio buttons and checkboxes to go down the same code path by virtue
of allowsIndeterminate(), but this broke save/restore behavior on radio buttons.

Fix by saving and restoring both the intermediate and checked state for radio buttons
and checkboxes, as well as the "current radio button" state.

Test: fast/forms/radio-checkbox-restore-indeterminate.html

  • html/HTMLInputElement.cpp: (WebCore::EventHandlingState::EventHandlingState): New struct to hold state between preDispatchEventHandler() and postDispatchEventHandler(). (WebCore::HTMLInputElement::preDispatchEventHandler): Store intermedate and checked state and the current radio button. (WebCore::HTMLInputElement::postDispatchEventHandler): Restore state as appropriate.
  • html/HTMLInputElement.h: Add a comment to clarify how 'intermediate' interacts with 'checked', according to the spec.
16:38 Changeset [56283] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

fix typo in chromium test expectations overrides routine
https://bugs.webkit.org/show_bug.cgi?id=36397

  • Scripts/webkitpy/layout_tests/port/chromium.py:
16:09 Changeset [56282] by darin@chromium.org

2010-03-19 Darin Fisher <darin@chromium.org>

Temporarily suppress fast/loader/frame-src-change-added-to-history.html
for Tiger to make the bot green.

https://bugs.webkit.org/show_bug.cgi?id=36382

  • platform/mac-tiger/Skipped:
16:06 Changeset [56281] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed change.

Add in missing test_expectations.txt file that didn't actually
make it into the commit.

https://bugs.webkit.org/show_bug.cgi?id=36326

  • LayoutTests/platform/chromium/test_expectations.txt
16:05 Changeset [56280] by eric@webkit.org

2010-03-19 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: caret moves past prompt in javascript console
https://bugs.webkit.org/show_bug.cgi?id=26602

Having noticed any Element children besides a leading <br> (which are empty
text nodes), WebCore editing facility thinks it should delete the <br>,
thus clearing away the text prompt contents.

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.clearAutoComplete): (WebInspector.TextPrompt.prototype._completionsReady):
  • inspector/front-end/utilities.js: (Element.prototype.pruneEmptyTextNodes):
16:02 Changeset [56279] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Flip the Chromium ports to look first for the test expectations
in LayoutTests/platform/chromium and only afterwards look in the
Chromium repo downstream for overrides.

https://bugs.webkit.org/show_bug.cgi?id=36326

  • WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:
  • LayoutTests/platform/chromium/test_expectations.txt
15:52 Changeset [56278] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.
Land remaining chromium-linux LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

15:43 Changeset [56277] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/fast/{block,css,forms,text} LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-linux/fast/block : Added.
  • platform/chromium-linux/fast/css : Added.
  • platform/chromium-linux/fast/forms : Added.
  • platform/chromium-linux/fast/text : Added.
15:35 Changeset [56276] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/editing LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-linux/editing : Added.
15:33 Changeset [56275] by jhawkins@chromium.org

2010-03-19 James Hawkins <jhawkins@chromium.org>

Unreviewed.

Add myself to the committers list.

  • Scripts/webkitpy/committers.py:
15:29 Changeset [56274] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/tables LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-linux/tables : Added.
15:18 Changeset [56273] by dpranke@chromium.org

010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/svg LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-linux/svg : Added.
15:09 Changeset [56272] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/css* LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-linux/css* : Added.
15:00 Changeset [56271] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land remaining chromium-win/* LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/* : Added.
14:50 Changeset [56270] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-win/css* LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/css* : Added.
14:38 Changeset [56269] by ossy@webkit.org

[Qt] Back-forward list dumping is incorrect
https://bugs.webkit.org/show_bug.cgi?id=36392

  • platform/qt/Skipped: fast/loader/frame-src-change-added-to-history.html skipped until fix.
14:34 Changeset [56268] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-win/fast/[l-z]* LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/fast/[l-z]* : Added.
14:24 Changeset [56267] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-win/fast/{a,c,d,e,f,g,h,i,j}* LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/fast/{a,c,d,e,f,g,h,i,j}* : Added.
14:14 Changeset [56266] by xan@webkit.org

2010-03-19 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

r56188 removed lastPosition from the Geolocation code, but the the
geolocation window properties wasn't updated to reflect this. It's
only failing on the GTK+ port, since the other ports have it on
their Skipped list.

  • fast/dom/Window/window-properties-geolocation-expected.txt:
14:11 Changeset [56265] by ossy@webkit.org

[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386

  • platform/qt/Skipped: fast/media/print-restores-previous-mediatype.html skipped until fix.
14:04 Changeset [56264] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the first part of chromium-win/fast LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/fast: Added.
14:01 Changeset [56263] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix SheriffBot exception lock when we can't retrieve the first build
from buildbot. (I'll ask Eric to review this change after the fact,
but he's at lunch and I want to get the bot unlocked.)

  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/buildbot_unittest.py:
13:48 QtWebKitJournal edited by hausmann@webkit.org
(diff)
13:21 Changeset [56262] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36380
websocket/tests/frame-lengths.html times out on Tiger bot

https://bugs.webkit.org/show_bug.cgi?id=35041
websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot

Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary -
sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid
timing out than to detect it early.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::waitUntilDone):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • Scripts/run-webkit-tests:
13:20 Changeset [56261] by xan@webkit.org

2010-03-19 Xan Lopez <xlopez@igalia.com>

Unreviewed, land new expected result for test.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
13:15 Changeset [56260] by laszlo.1.gombos@nokia.com

2010-03-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

Buildfix for Qt v4.5.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewOverlay::q):

2010-03-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

Buildfix for Qt v4.5.

  • QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::applyZoom):
13:10 Changeset [56259] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win/tables LayoutTest baselines (file list
ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/tables: Added.
13:09 Changeset [56258] by dglazkov@chromium.org

Unreviewed, build fix.

Rename enqueueStorageEvent to enqueueEvent to match changes in
http://trac.webkit.org/changeset/56249.

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::storageEvent): Renamed.

13:05 Changeset [56257] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Operational tweaks to SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=36385

These changes aren't pretty, but they're helpful to make SheriffBot
work operationally. I plan to iterate in these areas, but I wanted to
get this patch landed so I could be running the bot against TOT.

  • Scripts/webkitpy/commands/sheriffbot.py:
  • Scripts/webkitpy/irc/ircbot.py:
  • Scripts/webkitpy/thirdparty/autoinstalled/init.py:
13:01 Changeset [56256] by aroben@apple.com

Windows clean build fix after r56192

  • WebCore.vcproj/WebCore.vcproj: Copy headers from

platform/graphics/cg to $WebKitOutputDir as part of the post-build
event so that WebKit can use them. (The only one we currently require
is FontPlatformData.h.)

  • platform/graphics/win/FontPlatformDataCGWin.cpp: Touched to force a

build.

12:56 Changeset [56255] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win/svg LayoutTest baselines (file list
ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/svg: Added.
12:54 Changeset [56254] by beidson@apple.com

Rubberstamped by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=35594

  • fast/loader/api-test-new-window-data-load-base-url.html: Removed.
  • fast/loader/api-test-new-window-data-load-base-url.html-disabled: Copied from fast/loader/api-test-new-window-data-load-base-url.html.
12:41 Changeset [56253] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win-vista LayoutTest baselines (file list
ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win-vista: Added.
12:40 Changeset [56252] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win-xp LayoutTest baselines (file list ommitted due to
length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win-xp: Added.
12:38 Changeset [56251] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-mac LayoutTest baselines (file list ommitted due to
length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-mac: Added.
11:37 Changeset [56250] by joepeck@webkit.org

2010-03-19 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Assertion failure in media/video-controls-with-mutation-event-handler.html
https://bugs.webkit.org/show_bug.cgi?id=36376

Fix crashing test. Underlying the media element's volume slider is a
range input, which sanitizes values before expected on the media control.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):
11:25 Changeset [56249] by beidson@apple.com

3 of the new HTML5 loading events need to be asynchronous.

Reviewed by Darin Adler.

Laying the groundwork for:
https://bugs.webkit.org/show_bug.cgi?id=36201
https://bugs.webkit.org/show_bug.cgi?id=36202
https://bugs.webkit.org/show_bug.cgi?id=36334
https://bugs.webkit.org/show_bug.cgi?id=36335

Document already had an asynchronous event delivery mechanism for storage events, so
we can repurpose that for all async events.

No new tests. (No change in behavior)

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::implicitClose): Use Document::schedule* for the related events.
(WebCore::Document::enqueueEvent): Renamed from enqueueStorageEvent
(WebCore::Document::pendingEventTimerFired): Renamed from "storageEventTimerFired"
(WebCore::Document::statePopped): Use Document::schedulePopstateEvent
(WebCore::Document::enqueuePageshowEvent): All Pageshow events are piped through here.

This will be made asynchronous in a separate patch.

(WebCore::Document::enqueueHashchangeEvent): All Hashchange events are piped through here.

This will be made asynchronous in a separate patch.

(WebCore::Document::enqueuePopstateEvent): All Popstate events are piped through here.

This will be made asynchronous in a separate patch.

  • dom/Document.h:

(WebCore::):

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Use Document::enqueuePageshowEvent

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument): Use Document::enqueueHashchangeEvent

  • storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatch): Use Document::enqueueEvent

11:23 Changeset [56248] by eric@webkit.org

2010-03-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Help sheriff-bot avoid warning about flaky tests (and add more unit testing)
https://bugs.webkit.org/show_bug.cgi?id=36354

  • Scripts/webkitpy/buildbot.py:
    • Make Build creation easier to Mock and test
  • Scripts/webkitpy/buildbot_unittest.py:
    • Test finding green to red transitions and suspect revisions
  • Scripts/webkitpy/commands/queries.py:
    • Make what-broke note when builders have only failed once.
11:19 Changeset [56247] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36337
Log an error when an OOP plug-in sends an unknown object id

Making these LOG_ERROR and not ASSERTs, because I don't want early returns to look
temporary or redundant.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::getProperty): (WebKit::NetscapePluginInstanceProxy::setProperty): (WebKit::NetscapePluginInstanceProxy::removeProperty): (WebKit::NetscapePluginInstanceProxy::hasProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::enumerate):
11:16 Changeset [56246] by kdecker@apple.com

Reviewed by Darin Adler and Brady Eidson.

First step toward:
https://bugs.webkit.org/show_bug.cgi?id=36328

This is the first step torward eliminating the WebKit WebNullPluginView class. The responsibility for this will soon
be in platform-independent code in WebCore. The plan is to change RenderEmbeddedObject and give it the capability of
drawing the missing plug-in text.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): Renamed the renderer parameter to requestEmbeddedObject and made it a RenderEmbeddedObject. (WebCore::FrameLoader::loadPlugin): Likewise.
  • loader/FrameLoader.h: Updated loadPlugin() and requestObject() method signatures accordingly.
11:01 Changeset [56245] by dpranke@chromium.org

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Fix the rebaselining tool, which was broken by r36324 when I
added the concept of overridding expectations.

https://bugs.webkit.org/show_bug.cgi?id=36374

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
10:30 Changeset [56244] by darin@chromium.org

2010-03-19 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] querying the current history item during a back/forward
navigation should not clobber the scroll offset, etc.
https://bugs.webkit.org/show_bug.cgi?id=36347

We should only allow the current history item to be modified if we are
no longer loading or if the load is a new navigation (i.e., not a
back/forward/reload variant).

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::currentHistoryItem):
09:41 Changeset [56243] by eric@webkit.org

2010-03-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Disable TILED_BACKING_STORE if Qt version is earlier than Qt4.6
https://bugs.webkit.org/show_bug.cgi?id=36348

Backing store implementation for QtWebKit requires at least Qt
version 4.6.

No new tests as there is no new functionality.

  • WebCore.pri:
09:16 Changeset [56242] by joepeck@webkit.org

2010-03-19 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259

Setting value attribute on an <input type=range> to an out-of-range value fires oninput
https://bugs.webkit.org/show_bug.cgi?id=16990

Part 2 of 2: When setting the range element's value, overflows and underflows
are automatically sanitized to valid values. Moved the general case
sanitization code out of the Renderer into HTMLInputElement::sanitizeValue.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::value): when getting a default value on reset() ensure the defaultValue is provided (WebCore::HTMLInputElement::sanitizeValue): clamp the value within the max/min/step range constraints
  • html/StepRange.cpp: (WebCore::StepRange::StepRange): allow const element in the constructor (WebCore::StepRange::clampValue): clamp from a String value
  • html/StepRange.h: (WebCore::StepRange::defaultValue): easy calculation of the default value for max/min/step range constraints
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): no longer handle the general case sanitization in the renderer

2010-03-19 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259

Setting value attribute on an <input type=range> to an out-of-range value fires oninput
https://bugs.webkit.org/show_bug.cgi?id=16990

When setting the range element's value, overflows and underflows are
automatically sanitized to valid values. Fixed the behavior and removed
tests that were testing for improper behavior.

  • fast/forms/ValidityState-rangeOverflow-expected.txt:
  • fast/forms/ValidityState-rangeUnderflow-expected.txt:
  • fast/forms/input-stepup-stepdown-expected.txt:
  • fast/forms/script-tests/ValidityState-rangeOverflow.js:
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js:
  • fast/forms/script-tests/input-stepup-stepdown.js:
  • fast/forms/script-tests/validationMessage.js:
  • fast/forms/validationMessage-expected.txt:

Added test verifying that bug 16990 was fixed as well.

  • fast/forms/range-input-dynamic-oninput-expected.txt: Added.
  • fast/forms/range-input-dynamic-oninput.html Added.

Improved test because handling of this case changed.

  • fast/forms/range-reset-expected.txt:
  • fast/forms/range-reset.html:
09:16 Changeset [56241] by joepeck@webkit.org

2010-03-19 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259

Part 1 of 2: Refactoring the SliderRange struct out of RenderSlider
into a more appropriate place. Changed the named to StepRange. Changed
from a struct to a class.

Added new files to the build.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Renamed and moved class SliderRange to StepRange.

  • html/StepRange.cpp: Added. (WebCore::StepRange::StepRange): (WebCore::StepRange::clampValue): (WebCore::StepRange::valueFromElement): (WebCore::sliderPosition):
  • html/StepRange.h: Added. (WebCore::StepRange::proportionFromValue): (WebCore::StepRange::valueFromProportion):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): updated to use StepRange (WebCore::RenderSlider::setValueForPosition): updated to use StepRange
08:34 QtWebKitJournal edited by hausmann@webkit.org
(diff)
08:33 Changeset [56240] by darin@chromium.org

2010-03-19 Darin Fisher <darin@chromium.org>

Fix expected results for fast/loader/frame-src-change-added-to-history.html

  • fast/loader/frame-src-change-added-to-history-expected.txt:
08:27 Changeset [56239] by hausmann@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=36366
Repaint loop when painting using scaled CTMs with different translations

Patch by Antti Koivisto <koivisto@iki.fi> on 2010-03-19
Reviewed by Simon Hausmann.

The code in RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality
tests if the scaling has changed from the previous value by comparing the
transformations. The test fails if the scale is the same but the translation
changes. This can lead to infinite repaint loop if the document is painted
in pieces using different translations (for example for tiling).

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):

08:06 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
08:03 Changeset [56238] by hamaji@chromium.org

2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Need a layout test for finding yensign from documents with Japanese encodings
https://bugs.webkit.org/show_bug.cgi?id=36288

  • editing/selection/find-yensign-and-backslash-expected.txt: Added.
  • editing/selection/find-yensign-and-backslash.html: Added.
  • platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt: Added.
  • platform/qt/editing/selection/find-yensign-and-backslash-expected.txt: Added.
  • platform/win/editing/selection/find-yensign-and-backslash-expected.txt: Added.
07:10 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:35 Changeset [56237] by pfeldman@chromium.org

2010-03-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: editing shorthands does not always work.

https://bugs.webkit.org/show_bug.cgi?id=36362

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::shorthandValue):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.css: (.section .properties li.disabled .enabled-button):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.editingCommitted):
06:10 Changeset [56236] by vestbo@webkit.org

[Qt] Don't replace clip when drawing complex text

Reviewed by Simon Hausmann.

  • platform/graphics/qt/FontQt.cpp:
03:05 Changeset [56235] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Misc bug fixes to make the SheriffBot actually work
https://bugs.webkit.org/show_bug.cgi?id=36355

With these changes, I can actually run the sheriff-bot from start to
finish.

  • Scripts/webkitpy/irc/ircproxy.py:
  • Scripts/webkitpy/patch/patcher.py:
  • Scripts/webkitpy/statusserver.py:
02:51 Changeset [56234] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Actually import the sheriff-bot command so we can run it. Also, move
the bot to #webkit-test so it doesn't cause a ruckus while we test it.

  • Scripts/webkitpy/patch/patcher.py:
  • Scripts/webkitpy/irc/ircbot.py:
02:44 Changeset [56233] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Second cut at SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=36353

This patch should contain a complete SheriffBot that's capable of
saying reasonable things on IRC. I had to refactor the use of
CommitInfo to make the SheriffBot testable, but I did the minimum
necessary. We should grow webkitcheckout over time to contain the
knowledge of ChangeLogs from scm.

  • Scripts/webkitpy/commands/sheriffbot.py:
  • Scripts/webkitpy/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/patch/patcher.py:
  • Scripts/webkitpy/webkitcheckout.py: Added.
01:44 Changeset [56232] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix Hyatt's IRC nickname.

  • Scripts/webkitpy/committers.py:
01:42 Changeset [56231] by eric@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Add IRC nicknames for the non-reviewer committers.

  • Scripts/webkitpy/committers.py:
01:10 Changeset [56230] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Add IRC nicknames for the non-reviewer committers.

  • Scripts/webkitpy/committers.py:
00:59 Changeset [56229] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

More reviewer IRC nicknames.

  • Scripts/webkitpy/committers.py:
00:53 Changeset [56228] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Add a bunch of IRC nicknames for reviewers.

  • Scripts/webkitpy/committers.py:
00:47 Changeset [56227] by zoltan@webkit.org

2010-03-19 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Oliver Hunt.

Added USE_SYSTEM_MALLOC flag to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=21272

Add system-alloc flag to build-webkit. It makes easy to switch
between system allocator and TCmalloc.

  • Scripts/build-webkit:
00:44 Changeset [56226] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix.

Of course, I caused a regression in the file that isn't tested. :(

  • Scripts/webkitpy/statusserver.py:
00:37 Changeset [56225] by eric@webkit.org

2010-03-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Simplify BuildBot core builder code for easier re-use
https://bugs.webkit.org/show_bug.cgi?id=36350

I simply couldn't see anything through all this Yak-hair.

  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/commands/queries.py:
00:33 Changeset [56224] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

committers.py should know IRC nicknames
https://bugs.webkit.org/show_bug.cgi?id=36349

I'll add the actual nicknames in another patch.

  • Scripts/webkitpy/committers.py:
  • Scripts/webkitpy/committers_unittest.py:
00:31 Changeset [56223] by darin@chromium.org

2010-03-18 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

If a frame is already in the document, then setting its "src" attribute
should add the resultant navigation to history.

https://bugs.webkit.org/show_bug.cgi?id=9166

This behavior is specified in section 4.8.2 of the HTML5 spec.

Test: fast/loader/frame-src-change-added-to-history.html

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::setLocation):
  • html/HTMLFrameElementBase.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame):
  • loader/FrameLoader.h:
00:20 Changeset [56222] by hausmann@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=36318

Patch by Anders Bakken <Anders Bakken <agbakken@gmail.com>> on 2010-03-18
Reviewed by Simon Hausmann.

QtLauncher runs as a GuiClient by default in Qt Embedded which will
make it try to connect to an existing GuiServer. This patch makes it
run like a stand-alone app.

  • QtLauncher/main.cpp:

(LauncherApplication::LauncherApplication):

00:18 Changeset [56221] by ossy@webkit.org

Unreviewed.

[Qt] Platform specific expected file updated after r56195

  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
00:15 Changeset [56220] by abarth@webkit.org

2010-03-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use
https://bugs.webkit.org/show_bug.cgi?id=36345

  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/commands/queries.py:
00:04 Changeset [56219] by abarth@webkit.org

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Adam Barth.

Actually pass the IRC password to the IRC object
https://bugs.webkit.org/show_bug.cgi?id=36346

I wanted to do this before, but both patches were in flight. This
patch finally closes the loop and makes the IRCProxy system complete.

  • Scripts/webkitpy/patch/patcher.py:

03/18/10:

23:58 Changeset [56218] by abarth@webkit.org

2010-03-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a StatusServer front end to the SVNRevision table on QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=36344

No test because Browser was too hard to mock. :( I couldn't figure
out how to make Mock be a dictionary as well as an object.

  • Scripts/webkitpy/statusserver.py:
23:46 Changeset [56217] by eric@webkit.org

2010-03-18 Philip Chimento <philip.chimento@gmail.com>

Reviewed by Oliver Hunt.

Setting the GObject WebKitWebView property 'window-features' to NULL
causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=36144

  • tests/testwebview.c: Add unit test for this bug.
  • webkit/webkitwebview.cpp: Don't allow the 'window-features' property to be set to NULL.
  • webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_equal): Don't examine the members of either web_window_features argument if either is NULL, just return that they are not equal. Additionally, if they are the same object, return that they are equal.
23:46 Changeset [56216] by eric@webkit.org

2010-03-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split out CommitInfo class and add unit tests
https://bugs.webkit.org/show_bug.cgi?id=36343

Move more logic out of "what-broke" into a shared CommitInfo
class so that it can be used by other commands and unit tested.

  • Scripts/webkitpy/commands/queries.py:
  • Scripts/webkitpy/commitinfo.py: Added.
  • Scripts/webkitpy/commitinfo_unittest.py: Added.
  • Scripts/webkitpy/unittests.py:
23:29 Changeset [56215] by eric@webkit.org

2010-03-18 Tom Callaway <tcallawa@redhat.com>

Reviewed by Darin Adler.

Bug 35429: Fix compile on SPARC64
https://bugs.webkit.org/show_bug.cgi?id=35429

  • wtf/Platform.h: Set WTF_USE_JSVALUE64 for SPARC64
23:24 Changeset [56214] by oliver@apple.com

WebCore: Fix a minor crash with mismatched array sizes in SVG animation
elements.

Patch by Chris Evans <cevans@chromium.org> on 2010-03-18
Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=35606

Test: svg/animations/keypoints-mismatch.svg

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::startedActiveInterval):
Globally apply validations relevant to all animation types.

LayoutTests: Add test for minor SVG animation crashers.
See https://bugs.webkit.org/show_bug.cgi?id=35606

Patch by Chris Evans <cevans@chromium.org> on 2010-03-18
Reviewed by Nikolas Zimmermann.

  • svg/animations/keypoints-mismatch.svg: Added.
  • svg/animations/keypoints-mismatch-expected.txt: Added.
23:03 Changeset [56213] by eric@webkit.org

2010-03-18 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

add new results for failing win/linux test after http://trac.webkit.org/changeset/56175
https://bugs.webkit.org/show_bug.cgi?id=36329

Missed this test in r56175 since it does a drag on win/linux, but not a mac.
The new results correctly do the smart-drag behavior of doing a smart-delete
on drag regardless of whether the selection granularity is word granularity.

  • platform/win/editing/selection/drag-text-delay-expected.checksum: Added.
  • platform/win/editing/selection/drag-text-delay-expected.png: Added.
  • platform/win/editing/selection/drag-text-delay-expected.txt:
22:46 Changeset [56212] by eric@webkit.org

2010-03-18 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Adam Barth.

Implement software composited graphics layers in Chromium using the Skia library.
https://bugs.webkit.org/show_bug.cgi?id=35557
This is an initial step in the implementation. Layer compositing is functioning
but not optimized in any way. Subsesquent check-ins will be necessary to fine tune
it.

Test: No new exposed functionality so no new tests.

  • WebCore.gypi: Added new source files to the chromium build
  • platform/graphics/GraphicsLayer.h: Added necessary typedef's and forward declarations for Chromium.
  • platform/graphics/skia/GraphicsLayerSkia.cpp: Added.
  • platform/graphics/skia/GraphicsLayerSkia.h: Added. Declaration and implementation of the platform-specific GraphicsLayer class.
  • platform/graphics/skia/LayerRendererSkia.cpp: Added.
  • platform/graphics/skia/LayerRendererSkia.h: Added. Declaration and implementation of the Skia-based software compositor.
  • platform/graphics/skia/LayerSkia.cpp: Added.
  • platform/graphics/skia/LayerSkia.h: Added. Declaration and implementation of a compositable layer that uses a Skia canvas for backing store.

2010-03-18 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Adam Barth.

Adding support for the ACCELERATED_COMPOSITING render path to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=35557
Currently compositing of layers is performed via s/w compositor which relies on Skia. This is an initial check-in
and it's only been tested on Windows. Compiling the code requires seting "use_accelerated_compositing=1"
to GYP_DEFINES. The update of layer contents and compositing is fairly inefficient but this will be fixed in
subsequent check-ins.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::attachRootGraphicsLayer): (WebKit::ChromeClientImpl::scheduleCompositingLayerSync):
  • src/ChromeClientImpl.h: (WebKit::ChromeClientImpl::setNeedsOneShotDrawingSynchronization): Added methods required by the RenderLayerCompositor
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::paintWithContext): (WebKit::WebFrameImpl::paint):
  • src/WebFrameImpl.h: Split WebFrameImpl::paint() into two methods to make it possible to call the paint routine with an existing GraphicsContext, which is necessary for painting the root layer into its own backing surface.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::paint): Modified method to handle the accelerated compositing path. Now, when doing accelerated compositing, paint() results in repainting the contents of the root layer and then doing a composite operation. (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::setAcceleratedCompositing): (WebKit::WebViewImpl::updateRootLayerContents): (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::isAcceleratedCompositing):
22:32 Changeset [56211] by laszlo.1.gombos@nokia.com

2010-03-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix LayoutTests/http/tests/appcache/max-size.html
https://bugs.webkit.org/show_bug.cgi?id=36207

  • platform/qt/Skipped:

2010-03-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix LayoutTests/http/tests/appcache/max-size.html
https://bugs.webkit.org/show_bug.cgi?id=36207

Implement setAppCacheMaximumSize() for Qt.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setAppCacheMaximumSize):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
22:13 Changeset [56210] by abarth@webkit.org

2010-03-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

QueueStatusServer should be able to log broken bots
https://bugs.webkit.org/show_bug.cgi?id=36341

We need to add a new table to the QueueStatusServer to store persistent
information for the SheriffBot. The new table will keep track of which
bots each SVN revision broke.

  • QueueStatusServer/handlers/init.py:
  • QueueStatusServer/handlers/svnrevision.py: Added.
  • QueueStatusServer/handlers/updatebase.py: Added.
  • QueueStatusServer/handlers/updatestatus.py:
  • QueueStatusServer/handlers/updatesvnrevision.py: Added.
  • QueueStatusServer/index.yaml:
  • QueueStatusServer/main.py:
  • QueueStatusServer/model/init.py:
  • QueueStatusServer/model/svnrevision.py: Added.
  • QueueStatusServer/templates/updatesvnrevision.html: Added.
22:11 Changeset [56209] by eric@webkit.org

2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Darin Adler.

Add a new test for testing whether the media type is restores
properly after printing a page (changing media type to 'print').

Add expected result and skip the test for platform that do not
implement setMediaType().

  • fast/media/print-restores-previous-mediatype-expected.txt: Added.
  • fast/media/print-restores-previous-mediatype.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:

2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Darin Adler.

Make setPrinting() with printing=false, restore the previous
media type in use.

Test: fast/media/print-restores-previous-mediatype.html

  • page/Frame.cpp: (WebCore::Frame::setPrinting):
  • page/FrameView.cpp: (WebCore::FrameView::adjustMediaTypeForPrinting):
  • page/FrameView.h:

2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Darin Adler.

Make it possible for the Qt DRT to set the media type from
the LayoutTestController.

  • Api/qwebframe.cpp: (qt_drt_setMediaType):

2010-03-18 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Darin Adler.

Add a new method to the Qt LayoutTestController for
changing media type and make the DRT support dry-run printing.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::dryRunPrint):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMediaType):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
21:51 Changeset [56208] by eric@webkit.org

2010-03-18 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

[Qt] New API scrollRecursively has several problems.
https://bugs.webkit.org/show_bug.cgi?id=35873

Remove scrollRecursively from the Qt 4.7 API
Update the internal API to accept a hit test position
for nested scrolling

  • Api/qwebframe.cpp: (webframe_scrollOverflow): (qtwebkit_webframe_scrollRecursively):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h:
  • tests/qwebframe/tst_qwebframe.cpp:
20:58 Changeset [56207] by mrowe@apple.com

Update test results after r56182. "background-color: rgba(0, 0, 0, 0)" is now reported as "background-color: transparent".

Rubber-stamped by Samuel Weinig.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
18:33 Changeset [56206] by ddkilzer@apple.com

<http://webkit.org/b/36338> Remove unused RenderReplaced::adjustOverflowForBoxShadowAndReflect() declaration

Rubber-stamped by Darin Adler.

This declaration should have been removed in r47440.

  • rendering/RenderReplaced.h:

(WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Removed.

18:05 Changeset [56205] by jianli@chromium.org

Dragging a PDF image triggers assertion in DragController::startDrag()
https://bugs.webkit.org/show_bug.cgi?id=36247

Reviewed by Dmitry Titov.

WebCore:

Test: fast/images/drag-pdf-as-image.html

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::filenameExtension):

  • platform/graphics/cg/PDFDocumentImage.h:

LayoutTests:

  • fast/images/drag-pdf-as-image-expected.txt: Added.
  • fast/images/drag-pdf-as-image.html: Added.
17:21 Changeset [56204] by simon.fraser@apple.com

2010-03-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Avoid taking a reference to a String owned by a temporary AtomicString.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::RareData::parseNth):
17:17 Changeset [56203] by hyatt@apple.com

Land new expected results.

16:23 Changeset [56202] by mitz@apple.com

Add missing file from r56186.

  • fast/dynamic/float-remove-above-line-2-expected.txt: Added.
16:03 Changeset [56201] by jianli@chromium.org

Chromium interface change to support Blob.slice.
https://bugs.webkit.org/show_bug.cgi?id=35318

Reviewed by Darin Fisher.

  • features.gypi:
  • public/WebHTTPBody.h:
  • public/WebKitClient.h:

(WebKit::WebKitClient::getFileModificationTime):

  • src/ChromiumBridge.cpp:

(WebCore::ChromiumBridge::getFileModificationTime):

  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFile):
(WebKit::WebHTTPBody::appendFileRange):

16:00 Changeset [56200] by cmarrin@apple.com

Fixed parenting issues with HW layers on Windows
https://bugs.webkit.org/show_bug.cgi?id=32449

15:45 Changeset [56199] by dpranke@chromium.org

2010-03-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Add upstream LayoutTests/platform/chromium* directories to the
baseline search path for new-run-webkit-tests in preparation for
upstreaming all of the Chromium baselines. Note that this does
not actually create the directories themselves, but that's okay.

https://bugs.webkit.org/show_bug.cgi?id=36324

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
15:42 Changeset [56198] by ap@apple.com

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=36327
Test that a plug-in can override Node methods of its element

  • plugins/override-node-method-expected.txt: Added.
  • plugins/override-node-method.html: Added.
15:42 Changeset [56197] by dglazkov@chromium.org

Unreviewed, build fix.

[Chromium] Change the order of mac/ and cg/ include dirs to fix compile break
due to http://trac.webkit.org/changeset/56192,

  • WebCore.gyp/WebCore.gyp: Changed the order.
14:51 Changeset [56196] by simon.fraser@apple.com

2010-03-18 Simon Fraser <simon.fraser@apple.com>

No review.

Fix brace style after r56170.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
14:39 Changeset [56195] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=36325

Reviewed by Oliver Hunt.

Add support for stopImmediatePropagation from DOM Level 3 Events.

Added fast/events/stop-immediate-propagation.html.

  • dom/Event.cpp:

(WebCore::Event::Event):

  • dom/Event.h:

(WebCore::Event::timeStamp):
(WebCore::Event::stopPropagation):
(WebCore::Event::stopImmediatePropagation):
(WebCore::Event::propagationStopped):
(WebCore::Event::immediatePropagationStopped):

  • dom/Event.idl:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):

14:26 Changeset [56194] by dglazkov@chromium.org

Unreviewed, build fix.

Return frame accessor back to Geolocation, it's used in GeolocationServiceChromium.
The accessor was removed in http://trac.webkit.org/changeset/56188.

  • page/Geolocation.h:

(WebCore::Geolocation::frame): Added back.

14:21 Changeset [56193] by dpranke@chromium.org

2010-03-17 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Add the concept of an "overrides" file for expectations so that we
can store test_expectations both upstream and downstream for a port
that runs both in webkit.org and in a separate repository (like
Chromium). Also add some unit tests for the expectations module.

https://bugs.webkit.org/show_bug.cgi?id=36249

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: Added.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:20 Changeset [56192] by bfulgham@webkit.org

Help reduce build problems due to font declarations.
https://bugs.webkit.org/show_bug.cgi?id=36190

Reviewed by Adam Roben.

Functions unchanged, no new tests.

  • WebCore.vcproj/WebCore.vcproj: Add new file, and show movement of FontPlatformData.h to cg/ directory.
  • platform/graphics/cairo/FontPlatformData.h: Merge in WinCairo-specific declarations. Correct constructor declaration to use type float for font size.

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::useGDI):
(WebCore::FontPlatformData::fontFace):
(WebCore::FontPlatformData::setSize):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::isHashTableDeletedValue):

  • platform/graphics/cairo/FontPlatformDataCairo.cpp:

(WebCore::FontPlatformData::FontPlatformData): Correct

constructor to accept type float for font size.

  • platform/graphics/cg/FontPlatformData.h: Copied from WebCore/platform/graphics/win/FontPlatformData.h.

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::cgFont):
(WebCore::FontPlatformData::operator==):

  • platform/graphics/win/FontPlatformData.h: Removed.
  • platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::operator==): Move implementation

here (previously in header) to match other cairo-based ports.

  • platform/graphics/win/RefCountedHFONT.h: Added. This was extracted from win/FontPlatformData.h, and is now shared by the cg/FontPlatformData.h and cairo/FontPlatformData.h

(WebCore::RefCountedHFONT::create):
(WebCore::RefCountedHFONT::createDeleted):
(WebCore::RefCountedHFONT::~RefCountedHFONT):
(WebCore::RefCountedHFONT::hfont):
(WebCore::RefCountedHFONT::hash):
(WebCore::RefCountedHFONT::RefCountedHFONT):

14:14 Changeset [56191] by simon.fraser@apple.com

2010-03-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=36274
CSS3 :nth-child selector 'odd' keyword case sensitivity test fails

The tests for "odd", "even" etc. for nth-child selectors should be case insensitive.

Test: fast/css/nth-child-odd-case-insensitive.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::RareData::parseNth):
14:10 Changeset [56190] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=36265

Reviewed by Oliver Hunt.

Add support for event.defaultPrevented from DOM level 3.

Added fast/events/defaultprevented.html

  • dom/Event.idl:
13:51 Changeset [56189] by oliver@apple.com

2010-03-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Add API to directly expose JSON parsing
https://bugs.webkit.org/show_bug.cgi?id=34887

Add API to expose JSON parsing directly, and add tests to testapi

  • API/JSValueRef.cpp: (JSValueMakeFromJSONString): (JSValueCreateJSONString):
  • API/tests/testapi.c: (main):
  • JavaScriptCore.exp:
  • runtime/JSONObject.cpp: (JSC::JSONStringify):
  • runtime/JSONObject.h:
13:42 Changeset [56188] by darin@apple.com

Remove Geolocation.lastPosition, no longer in the spec.
https://bugs.webkit.org/show_bug.cgi?id=36255
rdar://problem/7746357

Reviewed by Kenneth Rohde Christiansen.

  • WebCore.base.exp: Updated since Geolocation's destructor is now non-virtual.
  • page/Geolocation.cpp:

(WebCore::Geolocation::lastPosition): Add an assertion; it's only legal to
call this if access to the location is allowed.

  • page/Geolocation.h: Removed unneeded includes. Made destructor non-virtual,

although it will still be virtual if any of the base classes have a virtual
destructor. Made lastPosition, isAllowed, and isDenied functions private.
Removed unused suspend, resume, setShouldClearCache, shouldClearCache,
and frame functions.

  • page/Geolocation.idl: Removed lastPosition read-only attribute. No longer in

the Geolocation specification.

13:37 Changeset [56187] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=36275

Reviewed by Simon Fraser.

Make sure :not does not allow pseudo-elements inside it. (Hooray for another pointless
restriction on :not.)

Added fast/css/invalid-not-with-pseudo-element.html

  • css/CSSGrammar.y:
  • css/CSSSelector.h:

(WebCore::CSSSelector::matchesPseudoElement):

13:33 Changeset [56186] by mitz@apple.com

WebCore: <rdar://problem/7761400> Rework the fix for
https://bugs.webkit.org/show_bug.cgi?id=18722

Reviewed by Darin Adler.

Test: fast/dynamic/float-remove-above-line-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeFloatingObject): Treat 0- and less-than-0-height floats
as having a height of 1 so that they intersect with the line they originate on.
(WebCore::RenderBlock::clearFloats): Use numeric_limits.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren): Removed the intersection checks here,
so that a float is always included in the float list of the line it originates on, even
if it does not intersect that line. This ensures that every float is accounted for, which
is necessary during incremental layout when adding floats from clean lines.

LayoutTests: Additional test for <rdar://problem/7761400>

Reviewed by Darin Adler.

  • fast/dynamic/float-remove-above-line-2.html: Copied from LayoutTests/fast/dynamic/float-remove-above-line.html.
  • fast/dynamic/float-remove-above-line-expected.txt: Updated.
  • fast/dynamic/float-remove-above-line.html: Fixed inconsequential typo in end tag.
13:29 Changeset [56185] by hyatt@apple.com

Add expected results.

13:19 Changeset [56184] by hausmann@webkit.org

2010-03-18 Antti Koivisto <koivisto@iki.fi>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=36102
[Qt] Scaling control API for tiled backing store

Commit the new scale synchronously after unfreeze to avoid ugliness.

  • platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::TiledBackingStore): (WebCore::TiledBackingStore::setContentsScale): (WebCore::TiledBackingStore::commitScaleChange): (WebCore::TiledBackingStore::setContentsFrozen):
  • platform/graphics/TiledBackingStore.h:

2010-03-18 Antti Koivisto <koivisto@iki.fi>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=36102
[Qt] Scaling control API for tiled backing store

The scale is set by passing the QGraphicsWebView scale to the backing store. The
only new API is the tiledBackingStoreFrozen property which allows disabling
all updates (for example during zoom animation).

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_scaleChanged): (QGraphicsWebViewPrivate::updateTiledBackingStoreScale): (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::isTiledBackingStoreFrozen): (QGraphicsWebView::setTiledBackingStoreFrozen):
  • Api/qgraphicswebview.h:
  • Api/qwebframe.cpp:
  • Api/qwebframe_p.h:
13:18 QtWebKitRelease20 edited by hausmann@webkit.org
(diff)
13:07 Changeset [56183] by eric@webkit.org

2010-03-18 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add an overlay QGraphicsTextItem to QtLauncher so we can display FPS info
on the launcher and not on the terminal anymore.

[Qt] QtLauncher's FPS info should be displayed on an overlay text item
https://bugs.webkit.org/show_bug.cgi?id=36244

  • QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::setFrameRateMeasurementEnabled): (WebViewGraphicsBased::updateFrameRate):
  • QtLauncher/webview.h:
12:50 Changeset [56182] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=36281

Reviewed by Simon Fraser.

Make sure an exception is raised if an @import rule is inserted in the wrong place.

Also make sure (so that this particular test case passes) that rgba(0, 0, 0, 0) is dumped
as transparent by getComputedStyle, since it most commonly occurs in background-color and
that default makes more sense than dumping rgba values.

Added fast/css/invalid-import-insertion.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::createColor):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::insertRule):

12:49 Changeset [56181] by eric@webkit.org

2010-03-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

First cut at SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=36253

This patch contains a first attempt at writing a sheriff bot.
Currently, we're missing the logic that actually finds the SVN revision
numbers to complain about, but once we have that, we'll have the rest
of the infrustructure to ping IRC and to file bugs.

There's a lot to fill in for the SheriffBot, but this patch give us the
framework in which to do it.

This patch required a bit of refactoring of AbstractQueue because
SheriffBot is the first bot that doesn't process patches (it processes
SVN revisions). Accordingly, I've factored out AbstractPatchQueue to
hold the parts of AbstractQueue that are specific to dealing with
patches. Some of the choices here might not be obvious yet, but we can
tweak them as our needs become clearer.

  • Scripts/webkitpy/commands/queues.py:
  • Scripts/webkitpy/commands/queues_unittest.py:
  • Scripts/webkitpy/commands/sheriffbot.py: Added.
  • Scripts/webkitpy/commands/sheriffbot_unittest.py: Added.
  • Scripts/webkitpy/mock_bugzillatool.py:

Added a MockIRC object to the mock tool.

  • Scripts/webkitpy/multicommandtool.py:

Added a finalize method so the tool can disconnect from IRC
cleanly instead of just droping the socket.

  • Scripts/webkitpy/multicommandtool_unittest.py:
  • Scripts/webkitpy/patch/patcher.py:

Added support for talking to IRC.

  • Scripts/webkitpy/unittests.py:

We should add a commands/unittests.py file at some point to make
the commands module more self-contained.

12:32 Changeset [56180] by eric@webkit.org

2010-03-18 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Multiselect Popup - Listbox click simulation
https://bugs.webkit.org/show_bug.cgi?id=36177

Listbox popups will need to notify the corresponding select elements that a
selection change happened. The current HTMLSelectElement interface does not
allow multiple selections.

The new method listBoxSelectItem will be used for that. I have refactored part
of the mouse handling code in bug 36124 and I am now reusing it here for
<select multiple> popups. All the other cases will handled as they were before to be
sure that no side effects will show up.

  • dom/SelectElement.cpp: (WebCore::SelectElement::updateListBoxSelection): (WebCore::SelectElement::listBoxOnChange):
  • dom/SelectElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxPopupClick):
  • html/HTMLSelectElement.h:
12:14 Changeset [56179] by eric@webkit.org

2010-03-18 Antti Koivisto <koivisto@iki.fi>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=36102
[Qt] Scaling control API for tiled backing store

Add animated smooth zooming to Qt launcher when in tiled mode.

  • QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::zoomAnimationFinished): (LauncherWindow::applyZoom): (LauncherWindow::zoomIn): (LauncherWindow::zoomOut):
  • QtLauncher/webview.h: (WebViewGraphicsBased::graphicsWebView):
11:56 Changeset [56178] by eric@webkit.org

2010-03-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Support using IRC accounts with a password
https://bugs.webkit.org/show_bug.cgi?id=36287

Add a global option to specify an IRC password so we can use the
sheriffbot account (which needs a password).

  • Scripts/webkitpy/irc/ircbot.py:
  • Scripts/webkitpy/irc/ircproxy.py:
  • Scripts/webkitpy/patch/patcher.py:
11:37 Changeset [56177] by ap@apple.com

Not reviewed.

https://bugs.webkit.org/show_bug.cgi?id=36210
plugins/resize-from-plugin.html fails on some platforms

Landing new results for Qt and Gtk, taken from buildbot.

Gtk results are a pass, although the difference in clip rect may indicate some issue to look into.
Qt results are a failure.

  • platform/gtk/plugins/resize-from-plugin-expected.txt: Copied from LayoutTests/plugins/resize-from-plugin-expected.txt.
  • platform/qt/plugins/resize-from-plugin-expected.txt: Copied from LayoutTests/plugins/resize-from-plugin-expected.txt.
11:33 Changeset [56176] by eric@webkit.org

2010-03-18 Eric Seidel <eric@webkit.org>

Just fixing missing parenthesis typo, no review.

  • Scripts/webkitpy/commands/queries.py: '%' has higher precedence than 'or', use parentheses.
11:23 Changeset [56175] by ojan@chromium.org

2010-03-12 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314

  • editing/deleting/non-smart-delete.html:
  • editing/pasteboard/drag-drop-modifies-page.html:
  • editing/pasteboard/page-zoom-expected.txt: Space is removed because we used to incorrectly smartpaste here. New behavior matches NSTextView.
  • editing/style/apply-through-end-of-document-expected.txt: The change here is that selectall + smartpaste doesn't put a BR, but selectall + normal-paste does. Not sure if that's a bug or not, but it's not a side effect of this change.
  • editing/style/style-boundary-005.html:
  • platform/mac/editing/deleting/non-smart-delete-expected.checksum:
  • platform/mac/editing/deleting/non-smart-delete-expected.png:
  • platform/mac/editing/deleting/non-smart-delete-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/execCommand/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.checksum:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
  • platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/mac/editing/selection/expanding-selections-expected.txt:
  • platform/mac/editing/selection/expanding-selections2-expected.txt:
  • platform/mac/editing/selection/triple-click-in-pre-expected.txt: The above three results change because granularity is no longer part of the seleciton, so changes in granularity don't fire selection change notifications.
  • platform/mac/editing/style/style-boundary-005-expected.checksum:
  • platform/mac/editing/style/style-boundary-005-expected.png:
  • platform/mac/editing/style/style-boundary-005-expected.txt:

2010-03-12 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314

  1. Consolidate all notions of selection-granularity into SelectionController.
  2. Now only mouse-based selections store a selection-granularity. This matches NSTextView.

New tests were added in http://trac.webkit.org/changeset/55913.

  • WebCore.base.exp:
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::MoveSelectionCommand): (WebCore::MoveSelectionCommand::doApply):
  • editing/MoveSelectionCommand.h: (WebCore::MoveSelectionCommand::create):
  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::modify): (WebCore::SelectionController::clear):
  • editing/SelectionController.h: (WebCore::SelectionController::setSelection): (WebCore::SelectionController::granularity):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::VisibleSelection): (WebCore::VisibleSelection::expandUsingGranularity): (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): (WebCore::VisibleSelection::validate):
  • editing/VisibleSelection.h: (WebCore::operator==):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::extend):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDrag):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::selectionGranularity):
  • page/Frame.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionRange):

2010-03-12 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

smartdelete should only occur after double-click
https://bugs.webkit.org/show_bug.cgi?id=35314

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundPosition):
11:22 Changeset [56174] by simon.fraser@apple.com

2010-03-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=36273
CSS3 :indeterminate and input type=radio test fails

The :indeterminate pseudo-class should apply to both radio buttons and checkboxes.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setIndeterminate): Use allowsIndeterminate() to determine if the input supports the indeterminate state. (WebCore::HTMLInputElement::preDispatchEventHandler): Use allowsIndeterminate() to determine whether to handle the indeterminate state. (WebCore::HTMLInputElement::postDispatchEventHandler): Ditto.
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::allowsIndeterminate): New utility method, returns true for radio buttons and checkboxes.
11:11 Changeset [56173] by dglazkov@chromium.org

Unreviewed, build fix.

[V8] Turn npObjectTypeInfo into a function, make everyone happy.

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo): Added new function.
(npCreateV8ScriptObject):

  • bindings/v8/NPV8Object.h: Turned npObjectTypeInfo into function.
  • bindings/v8/V8NPObject.cpp: Replaced references to function
11:06 Changeset [56172] by ap@apple.com

Reviewed by Adam Roben and Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=36210
plugins/resize-from-plugin.html fails on some platforms

WebKitTools:

Turns out that most platforms don't use "cross-platform" main.cpp. Copied code added for
the test to their versions of the file.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_set_window):
  • DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_SetWindow):

LayoutTests:

  • platform/win/plugins/resize-from-plugin-expected.txt: Copied from LayoutTests/plugins/resize-from-plugin-expected.txt. Windows results are different, probably because windowed plug-ins just get the whole window as clip rect.
  • platform/gtk/Skipped:
  • platform/qt/Skipped: Unskipped the tests to see how they work with TestNetscapePlugin fixes from this patch.
11:03 Changeset [56171] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=36283

Reviewed by Simon Fraser.

The wrong constants were being used for the code that attempted to compact the background-repeat shorthand to
a single value.

Added fast/backgrounds/background-repeat-computed-style.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::fillRepeatToCSSValue):

10:57 Changeset [56170] by simon.fraser@apple.com

2010-03-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=36271
CSS3 :enabled on an input type=hidden element fails

The CSS3 selectors spec now makes it clear that hidden inputs should respect
the :enabled and :disabled pseudo-classes.

Test: fast/forms/hidden-input-enabled.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Remove checks for hidden inputs.
10:13 Changeset [56169] by enrica@apple.com

WebCore: Intro text at Star Wars demo is clipped.
<rdar://problem/7560979>
https://bugs.webkit.org/show_bug.cgi?id=33909

Reviewed by Simon Fraser.

Test: compositing/repaint/layer-repaint.html

We are flipping the coordinates for drawing, therefore
we must flip them also when we invalidate the rectangles.

  • platform/graphics/win/GraphicsLayerCACF.cpp:

(WebCore::WebLayer::setNeedsDisplay):

LayoutTests: Intro text at Star Wars demo is clipped.
<rdar://problem/7560979>
https://bugs.webkit.org/show_bug.cgi?id=33909

Reviewed by Simon Fraser.

We are flipping the coordinates for drawing, therefore
we must flip them also when we invalidate the rectangles.

  • compositing/repaint/layer-repaint.html: Added.
  • platform/mac/compositing/repaint/layer-repaint-expected.checksum: Added.
  • platform/mac/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/mac/compositing/repaint/layer-repaint-expected.txt: Added.
09:59 Changeset [56168] by japhet@chromium.org

2010-03-18 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium build fix.

Missed a #include in V8Collection.h.

  • bindings/v8/V8Collection.h:
09:50 Changeset [56167] by hyatt@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=36284.

Reviewed by Simon Fraser.

Make sure the CSS parser properly rejects negative border widths.

Added fast/borders/negative-border-width.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

09:38 Changeset [56166] by japhet@chromium.org

2010-03-18 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Remove V8Index.h and all references to V8ClassIndex.


https://bugs.webkit.org/show_bug.cgi?id=33477

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/NPV8Object.cpp:
  • bindings/v8/NPV8Object.h:
  • bindings/v8/V8Collection.h:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8Helpers.cpp:
  • bindings/v8/V8Index.h: Removed.
  • bindings/v8/V8IsolatedContext.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • bindings/v8/V8SVGPODTypeWrapper.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WrapperTypeInfo.h: Move WrapperTypeInfo struct into its own file from V8Index.h.
  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8EventSourceConstructor.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLAudioElementConstructor.h:
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLImageElementConstructor.h:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h:
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8WebGLArrayCustom.h:
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
  • bindings/v8/custom/V8WebKitPointConstructor.cpp:
09:20 Changeset [56165] by yurys@chromium.org

2010-03-18 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Preserve console history between debugging sessions.

https://bugs.webkit.org/show_bug.cgi?id=36223

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._settingsLoaded): (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult): (WebInspector.ConsoleView.prototype._enterKeyPressed):
  • inspector/front-end/Settings.js: (WebInspector.Settings.prototype._load):
09:12 Changeset [56164] by mitz@apple.com

Added reviewer name for r56155

08:58 Changeset [56163] by eric@webkit.org

2010-03-18 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: Pausing and resuming of animations don't work as expected
https://bugs.webkit.org/show_bug.cgi?id=36219

The play-state layout test now works, and can be removed from the skip list.

  • platform/qt/Skipped: animations/play-state.html is removed from the skipped list

2010-03-18 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: Pausing and resuming of animations don't work as expected
https://bugs.webkit.org/show_bug.cgi?id=36219

addAnimation and pauseAnimation were handling animation state changes in
the wrong way.
Apparently WebCore calls addAnimation for resuming, so we have to make
sure to resume an existing animation if that happens. Also, timeOffset
is now used for synchronization of the Qt animation clock with the
WebCore clock, as opposed to using it as a delay timer.
Both those fixes were necessary to get the layout test to work.

LayoutTests/animations/play-state.html now passed on Qt.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQtBase::AnimationQtBase): (WebCore::TransformAnimationQt::updateState): (WebCore::GraphicsLayerQt::addAnimation): (WebCore::GraphicsLayerQt::pauseAnimation):
08:41 Changeset [56162] by eric@webkit.org

2010-03-18 Adam Langley <agl@chromium.org>

Reviewed by David Levin.

[chromium] Fix inverted logic in per-strike renderer patch.

I screwed up in r55089 and got one of the conditions backwards. Thanks
to Roman Tsisyk for pointing it out.

https://bugs.webkit.org/show_bug.cgi?id=35495

  • platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html: Added.

2010-03-18 Adam Langley <agl@chromium.org>

Reviewed by David Levin.

[chromium] Fix inverted logic in per-strike renderer patch.

I screwed up in r55089 and got one of the conditions backwards. Thanks
to Roman Tsisyk for pointing it out.

https://bugs.webkit.org/show_bug.cgi?id=35495

Test: platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle):
08:23 Changeset [56161] by pfeldman@chromium.org

2010-03-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Show inherited styles for a selected DOM element

https://bugs.webkit.org/show_bug.cgi?id=28039

  • English.lproj/localizedStrings.js:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties):
  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._containsInherited): (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.isPropertyInherited): (WebInspector.StylePropertiesSection.prototype.onpopulate):
07:59 Changeset [56160] by eric@webkit.org

2010-03-18 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add support to run-launcher to open the EFL example browser.
http://webkit.org/b/36181

  • Scripts/webkitdirs.pm:
  • Scripts/run-launcher:
07:49 Changeset [56159] by tonikitoo@webkit.org

Spatial Navigation: Add isNull and document convenience methods to FocusCandidate
https://bugs.webkit.org/show_bug.cgi?id=36167

Reviewed by Gustavo Noronha.
Patch by Antonio Gomes <tonikitoo@webkit.org>

It turns out that Spatial Navigation related code (in FocusController.cpp for
instance) can be simplified and look better if FocusCandidate class offer some
convinience method. This patch introduces a couple of them (isNull and a Document
getter).

A followup refactoring patch will be making use of these helper methods.

  • page/SpatialNavigation.h:

(WebCore::FocusCandidate::FocusCandidate): Added a "Node*" parameter
to FocusCandidate's constructor.
(WebCore::FocusCandidate::isNull): In the Spatial Navigation logic, a NULL
FocusCandidate object is one that does not hold a valid reference to a "Node*".
(WebCore::FocusCandidate::document): This method returns a pointer for the FocusCandidate
node's document, if |node| is a valid pointer.

07:42 Changeset [56158] by eric@webkit.org

2010-03-18 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] [Performance] GraphicsLayerQt updates the scene too often
https://bugs.webkit.org/show_bug.cgi?id=36158

This fix makes sure that flushChanges is only called when necessary,
by calling the notifySync function asynchronously, which makes sure flushChanges() is called
after the WebCore compositor has made all its changes.

This has shown a visual improvement on several test-cases.

  • Makefile:
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::): (WebCore::GraphicsLayerQtImpl::notifySyncRequired): (WebCore::GraphicsLayerQtImpl::notifyChange): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setMaskLayer): (WebCore::GraphicsLayerQt::setPosition): (WebCore::GraphicsLayerQt::setAnchorPoint): (WebCore::GraphicsLayerQt::setSize): (WebCore::GraphicsLayerQt::setTransform): (WebCore::GraphicsLayerQt::setChildrenTransform): (WebCore::GraphicsLayerQt::setPreserves3D): (WebCore::GraphicsLayerQt::setMasksToBounds): (WebCore::GraphicsLayerQt::setDrawsContent): (WebCore::GraphicsLayerQt::setBackgroundColor): (WebCore::GraphicsLayerQt::clearBackgroundColor): (WebCore::GraphicsLayerQt::setContentsOpaque): (WebCore::GraphicsLayerQt::setBackfaceVisibility): (WebCore::GraphicsLayerQt::setOpacity): (WebCore::GraphicsLayerQt::setContentsRect):
06:31 Changeset [56157] by eric@webkit.org

2010-03-18 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] Failing tests http/tests/misc/image-blocked-src-change.html
& http/tests/misc/image-blocked-src-no-change.html
https://bugs.webkit.org/show_bug.cgi?id=36227

Removed tests from the list of Skipped:
http/tests/misc/image-blocked-src-no-change.html
http/tests/misc/image-blocked-src-change.html
http/tests/security/local-CSS-from-remote.html
http/tests/security/local-video-poster-from-remote.html
http/tests/security/frame-loading-via-document-write.html
http/tests/security/local-iFrame-from-remote.html
http/tests/security/local-video-src-from-remote.html
http/tests/security/local-image-from-remote.html
http/tests/security/local-JavaScript-from-remote.html

  • platform/gtk/Skipped:

2010-03-18 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] Failing tests http/tests/misc/image-blocked-src-change.html
& http/tests/misc/image-blocked-src-no-change.html
https://bugs.webkit.org/show_bug.cgi?id=36227

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewConsoleMessage): print only the file name instead of the whole URI when printing messages with local URI's
05:47 Changeset [56156] by eric@webkit.org

2010-03-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach what-broke how to look up reviewer and author Committer objects by name
https://bugs.webkit.org/show_bug.cgi?id=36264

  • Scripts/webkitpy/commands/queries.py:
    • Add committer_by_name lookups for both reviewer and author
    • Improve printing in the cases where lookups fail.
  • Scripts/webkitpy/committers.py:
    • Add committer_by_name
  • Scripts/webkitpy/committers_unittest.py:
    • Test committer_by_name
05:30 Changeset [56155] by eric@webkit.org

2010-03-18 Stephen White <senorblanco@chromium.org>

Parsing of rgb() colors in HTML canvas is still fairly slow.
findNamedColor() was showing up as hot, so this patch attempts to
avoid calling it by putting the rgb() check ahead of the named
colors. It also removes a call to Color::Color() from
CanvasStyle, which was doing a redundant check for the hex
color and named colors, which CSSParser already does. Finally, it
changes the ad-hoc parser to check for negative values, and clamps them
at zero. This avoids the lex/yacc path for rgb() colors with
negative color components.

https://bugs.webkit.org/show_bug.cgi?id=36199

Covered by fast/canvas/set-colors.html.

  • css/CSSParser.cpp: (WebCore::parseInt): (WebCore::CSSParser::parseColor):
  • html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::applyFillColor):
05:13 Changeset [56154] by eric@webkit.org

2010-03-18 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=36220

[Qt] Unskip the tests that pass after the fix for bug 36139.
http/tests/appcache/foreign-iframe-main.html
http/tests/appcache/manifest-with-empty-file.html
http/tests/appcache/resource-redirect.html

  • platform/qt/Skipped:
04:56 Changeset [56153] by eric@webkit.org

2010-03-18 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/ewk.
http://webkit.org/b/35931

  • efl/ewk/ewk_settings.cpp: Added.
  • efl/ewk/ewk_settings.h: Added.
01:55 Changeset [56152] by ddkilzer@apple.com

<http://webkit.org/b/36246> Node::removeAllEventListenersSlowCase is declared but not used

Reviewed by Sam Weinig.

  • dom/Node.h:

(WebCore::Node::removeAllEventListenersSlowCase): Removed
declaration. Implementation was removed in r48701.

Note: See TracTimeline for information about the timeline view.