Timeline


and

03/23/10:

22:55 Changeset [56434] by tkent@chromium.org
  • 1 edit
    3 adds in trunk/WebKitTools

2010-03-23 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add TestNavigationController and TestWebWorker
https://bugs.webkit.org/show_bug.cgi?id=36489

Add TestNavigationController and TestWebWorker classes, which are
going to be used by DumpRenderTree Chromium port. These files are
based on:

  • src/webkit/tools/test_shell/test_navigation_controller.{cc,h}
  • src/webkit/tools/test_shell/test_web_worker.h of Chromium rev.40492.

TestNavigationController has non-style changes.

  • Change ContentState type: binary string -> WebHistoryItem
  • Remove TestShell dependency by introducing NavigationHost interface.
  • DumpRenderTree/chromium/TestNavigationController.cpp: Added.
  • DumpRenderTree/chromium/TestNavigationController.h: Added.
  • DumpRenderTree/chromium/TestWebWorker.h: Added.
21:27 Changeset [56433] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Skip plugins/destroy-plugin-from-callback.html, which has been failing on SL bots since it
was added in r56338.

  • platform/mac-snowleopard/Skipped:
20:17 Changeset [56432] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSplice): Some versions of GCC emit a warning about the implicit 64- to 32-bit truncation
that takes place here. An explicit cast is sufficient to silence it.

17:31 Changeset [56431] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reverted accidental change from r56429.

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::getCustomMenuFromDefaultItems):

17:29 Changeset [56430] by mitz@apple.com
  • 2 edits in trunk/WebCore

Fixed typos.

  • manual-tests/plugin-visible-rect-change.html:
17:27 Changeset [56429] by mitz@apple.com
  • 12 edits
    1 add in trunk

WebCore: WebCore part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.

Reviewed by John Sullivan.

  • manual-tests/plugin-visible-rect-change.html: Added.
  • platform/mac/WidgetMac.mm:

(WebCore::WidgetPrivate::WidgetPrivate): Added previousVisibleRect.
(WebCore::Widget::setFrameRect): If the visible rect changed but the
frame rect did not, send a -visibleRectDidChange message to the view,
if it responds to it.
(WebCore::Widget::releasePlatformWidget): Reset previousVisibleRect.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry): Track changes to the clip rect
imposed by the enclosing layer. Call Widget::setFrameRect when it changes,
even if the frame rect did not.

  • rendering/RenderWidget.h:

(WebCore::RenderWidget::windowClipRect): Added this accessor.

WebKit/mac: WebKit part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.

Reviewed by John Sullivan.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView visibleRectDidChange]): Added. Calls
WKSyncSurfaceToView().

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView _windowClipRect]): Changed to use Widget::windowClipRect().
(-[WebBaseNetscapePluginView visibleRectDidChange]): Added. Invokes -renewGState.

WebKitLibraries: WebKitSystemInterface part of
<rdar://problem/7197736> Plug-in clip rect does not update when overflow
clip changes
https://bugs.webkit.org/show_bug.cgi?id=36479.

Reviewed by John Sullivan.

  • WebKitSystemInterface.h: Added WKSyncSurfaceToView().
  • libWebKitSystemInterfaceSnowLeopard.a: Updated
17:06 Changeset [56428] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2010-03-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Assertion ASSERTION FAILED: rootLayer == m_clipRectsRoot at hulu.com
https://bugs.webkit.org/show_bug.cgi?id=34065

Fix another cause of assertions related to the clip rects root. Embeds
with zero size caused the overlap testing to fail, yet we require them to work
for correct compositing, so when the composited bounds is empty, use a 1x1 rect
for overlap testing.

Test: compositing/geometry/empty-embed-rects.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::addToOverlapMap): (WebCore::RenderLayerCompositor::computeCompositingRequirements):
16:31 Changeset [56427] by ap@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): Fixed a typo - length doesn't need to be converted with toInteger().
16:28 Changeset [56426] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-03-23 Kenneth Russell <kbr@google.com>

Unreviewed build fix.

Add #include <stdio.h> to fix Chromium Linux build.

  • src/WebGraphicsContext3DDefaultImpl.cpp:
16:12 Changeset [56425] by ap@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=36511
<rdar://problem/7753498> Safari freezes when using SPUTNIK JavaScript conformance check

Test: fast/js/sputnik-S15.4.4.12_A3_T3.html

  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): We were incorrectly computing the start offset, and iterated over (almost) all integers. Note that this can be fixed without using doubles, but the code would be much more complicated, and there is no important reason to stick to integers here.
15:57 Changeset [56424] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-23 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

QGraphicsWebView crash when calling setView on the QWebPage...
https://bugs.webkit.org/show_bug.cgi?id=36436

Checking for pageClient existance before showing popups.

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show):
15:40 Changeset [56423] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-23 Anders Bakken <anders.bakken@nokia.com>, Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Check if q->scene() is available before actually using it
on QGraphicsWebViewPrivate.

QGraphicsWebView crash
https://bugs.webkit.org/show_bug.cgi?id=32670

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::screenNumber): (QGraphicsWebViewPrivate::ownerWidget):
15:27 Changeset [56422] by levin@chromium.org
  • 3 edits
    2 adds in trunk

[chromium] XMLHttpRequest.send sends 'undefined' string when passed undefined value.
https://bugs.webkit.org/show_bug.cgi?id=36506

Reviewed by Nate Chapin.

WebCore:

Test: http/tests/xmlhttprequest/send-undefined-and-null.html

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType): Unrelated style fix: fixed the casing of the method.
(WebCore::V8XMLHttpRequest::sendCallback): Added check for null/undefined to do the send.
This mirrors what is done in the JSC bindings. Previously, sending 'null' worked because
the last case, which did "toWebCoreStringWithNullCheck", resulted in sending an empty
request body.

LayoutTests:

Added a test to verify that sending either undefined and null both result in an empty request body.

  • http/tests/xmlhttprequest/send-undefined-and-null-expected.txt: Added.
  • http/tests/xmlhttprequest/send-undefined-and-null.html: Added.
15:24 Changeset [56421] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-03-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add support for revision -> build lookup in buildbot.py and layout test result parsing
https://bugs.webkit.org/show_bug.cgi?id=36474

  • Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code.
  • Scripts/webkitpy/buildbot.py:
    • Add support for looking up builds by revision number.
    • Add support for fetching and parsing results.html files from buildbot.
    • build_for_revision has an allow_failed_lookups option to work around the fact that our buildbot's xmlrpc calls return failure on old revision numbers.
    • Add parsing support for twisted directory listings.
  • Scripts/webkitpy/buildbot_unittest.py:
    • Unit test all the new code.
  • Scripts/webkitpy/commands/queries.py:
    • Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup)
15:07 Changeset [56420] by dglazkov@chromium.org
  • 3 edits
    3 adds in trunk

WebCore: Fix hard-to-see crash due to incorrect libxml API usage.

Patch by Chris Evans <cevans@chromium.org> on 2010-03-23
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36000

Test: fast/text/bad-encoding.html

  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::doEnd): Avoid operations on a closed context.

LayoutTests: Add test for crash due to calling into libxml in invalid state. Note
that it is unlikely that this will actually crash for you in the test
environment because it is highly intermittent. However, adding test in
order to exercise the code path and prevent related regression.
See https://bugs.webkit.org/show_bug.cgi?id=36000

Patch by Chris Evans <cevans@chromium.org> on 2010-03-23
Reviewed by Darin Adler.

  • fast/text/bad-encoding.html: Added.
  • fast/text/bad-encoding-expected.txt: Added.
  • fast/text/resources/bad-encoding.xml: Added.
14:47 Changeset [56419] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-23 Daniel Bates <dbates@rim.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=36048

Detect if the Windows Platform SDK is missing when building with
Visual C++ Express Edition and inform the user to download it.

  • Scripts/webkitdirs.pm:
14:38 Changeset [56418] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-23 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium test expectations update.

Mark fast/dom/error-to-string-stack-overflow.html as failing on
all Chromium platforms, and http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html
as failing on Windows.

  • platform/chromium/test_expectations.txt:
14:33 Changeset [56417] by darin@apple.com
  • 3 edits in trunk/WebKitTools

Tell Subversion about more directories that expect to have .pyc files.

  • Scripts/webkitpy: Modified property svn:ignore.
  • Scripts/webkitpy/irc: Added property svn:ignore.
14:24 Changeset [56416] by japhet@chromium.org
  • 10 edits in trunk

2010-03-23 Nate Chapin <japhet@chromium.org>

Unreviewed, revert r56376.

This revision introduced a crash in a couple of layout tests
on Chromium Linux.

  • page/chromium/ChromeClientChromium.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupMenu::show):
  • platform/chromium/PopupMenuChromium.h: (WebCore::PopupItem::): (WebCore::PopupItem::PopupItem): (WebCore::PopupContainerSettings::): (WebCore::PopupContainer::listBox):
14:15 Changeset [56415] by eric@webkit.org
  • 5 edits in trunk/WebKit/chromium

2010-03-23 Sergey Ulanov <sergeyu@chromium.org>

Reviewed by Dmitry Titov.

Changes needed to implement Show/Hide Controls command for <video> in
chrome: (1) added Controls action in WebMediaPlayerAction that toggles
controls for media player, (2) added MediaHasVideo in
WebContextMenuData so that controls can be made toggleable only for
video player but not for audio.
https://bugs.webkit.org/show_bug.cgi?id=36460

  • public/WebContextMenuData.h: (WebKit::WebContextMenuData::):
  • public/WebMediaPlayerAction.h: (WebKit::WebMediaPlayerAction::):
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::performMediaPlayerAction):
13:52 Changeset [56414] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=36272, make sure nth-child can work when the portion with "n" is omitted.

Reviewed by Simon Fraser and Darin Adler.

Added fast/css/nth-child-implied-step.html

  • css/CSSGrammar.y:
  • css/tokenizer.flex:
13:51 Changeset [56413] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-23 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36149

Import the GNU readline interface to modify the behavior
of raw_input so as to provide line editing support. In
particular this will prevent "delete" characters from
appearing in the returned value for function raw_input.

  • Scripts/webkitpy/user.py:
13:48 Changeset [56412] by darin@apple.com
  • 10 edits in trunk/WebCore

2010-03-23 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Reduce and straighten internal use of DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=36501

  • WebCore.xcodeproj/project.pbxproj: Xcode decided to re-sort this file.
  • dom/Clipboard.cpp: Removed unneeded include of DOMImplementation.h.
  • dom/DOMImplementation.cpp: Removed unneeded createDocument and createHTMLDocument functions. These should be done directly instead of involving the DOMImplementation class.
  • dom/DOMImplementation.h: Ditto.
  • dom/DocumentType.cpp: Removed unneeded include of DOMImplementation.h.
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer): Don't allocate a DOMImplementation object just to use a class member function.
  • loader/CachedFont.cpp: Removed unneeded include of DOMImplementation.h.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Use Document::create to create a new document instead of involving DOMImplementation.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Ditto. And in the case where we do need to call DOMImplementation to interpret the MIME type, don't allocate a DOMImplementation object just to use a class member function.
13:06 Changeset [56411] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-23 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - all <select> elements should be rendered as menu lists.
https://bugs.webkit.org/show_bug.cgi?id=36367

Enabling NO_LISTBOX_RENDERING in WebCore.pri for Maemo5.

  • WebCore.pri:
12:39 Changeset [56410] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

When uncaught exception happens reveal Scripts panel only if reporting uncaught exceptions is on.

https://bugs.webkit.org/show_bug.cgi?id=36498

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
12:37 Changeset [56409] by joepeck@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Revert accidental ChangeLog commit r56407.

12:23 Changeset [56408] by joepeck@webkit.org
  • 3 edits in trunk/WebCore

2010-03-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870

  • platform/iphone/KeyEventCodesIPhone.h: Improper comment for #endif.
  • platform/iphone/KeyEventIPhone.mm: Fixed headers.
12:23 Changeset [56407] by joepeck@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=36328

  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::updateWidget): Don't update the widget if we're showing the missing plug-in indicator. (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::paintReplaced): Ditto.
  • rendering/RenderEmbeddedObject.h: Ditto. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): Ditto. (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): Ditto.
  • Plugins/WebNetscapePluginView.mm:
  • Plugins/WebNullPluginView.h: Removed.
  • Plugins/WebNullPluginView.mm: Removed.
  • Resources/nullplugin.tiff: Removed.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.
12:22 Changeset [56406] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-23 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: TimelinePanel stays in the recording state after reopening WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=36503

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::detach):
11:51 Changeset [56405] by hyatt@apple.com
  • 2 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=36277, make sure nth-child supports the positive unary prefix (+) as well as the negative
one (-).

Reviewed by Jeremy Orlow.

Added fast/css/nth-child-unary-prefix.html

  • css/tokenizer.flex:
11:49 Changeset [56404] by eric@webkit.org
  • 15 edits in trunk/WebCore

2010-03-23 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Dmitry Titov.

Change notification sent to inspector frontend on workers creation / destruction
to be posted asynchronously to avoid JS reenterability problems. Also, renamed
willDestroyWorker to didDestroyWorker to reflect that it gets called later and got
rid of explicit IDs for workers (use addresses instead).
https://bugs.webkit.org/show_bug.cgi?id=36213

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::didDestroyWorker):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorController.cpp: (WebCore::PostWorkerNotificationToFrontendTask::create): (WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorController::postWorkerNotificationToFrontend): (WebCore::InspectorController::didCreateWorker): (WebCore::InspectorController::didDestroyWorker):
  • inspector/InspectorController.h: (WebCore::InspectorController::):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didDestroyWorker):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorWorkerResource.h: (WebCore::InspectorWorkerResource::create): (WebCore::InspectorWorkerResource::id): (WebCore::InspectorWorkerResource::InspectorWorkerResource):
  • inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker.prototype.terminate):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.didDestroyWorker):
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::AbstractWorker): (WebCore::AbstractWorker::onDestroyWorker):
  • workers/AbstractWorker.h: (WebCore::AbstractWorker::asID):
  • workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
  • workers/Worker.cpp: (WebCore::Worker::Worker):
11:30 Changeset [56403] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-23 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Fix compilation on Itanium in 32-bit mode
https://bugs.webkit.org/show_bug.cgi?id=36494

  • wtf/Platform.h: Introduce CPU(IA64_32). Don't define WTF_USE_JSVALUE64 if the CPU is in 32-bit mode.
10:53 Changeset [56402] by hyatt@apple.com
  • 15 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=36266, support DOM Level 3 focusin/focusout events. Add support for
IE onfocusin/onfocusout extensions to HTML. The old DOM level 2 names (DOMFocusIn/DOMFocusOut are still supported).

Reviewed by Sam Weinig.

Added fast/events/focusinout.html

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

  • dom/Event.cpp:

(WebCore::Event::aliasedType):
(WebCore::Event::hasAliasedType):

  • dom/Event.h:
  • dom/EventNames.h:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):

  • dom/EventTarget.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchUIEvent):

  • html/HTMLAttributeNames.in:
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::parseMappedAttribute):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::parseMappedAttribute):

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseMappedAttribute):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseMappedAttribute):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::parseMappedAttribute):

10:36 QtWebKit edited by kenneth@webkit.org
(diff)
10:30 QtWebKitBackportingFixes edited by siddharth.mathur@nokia.com
Moved r56370 to Incoming list (diff)
10:10 Changeset [56401] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-23 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

WebCore::SelectionController::setSelection NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31545

  • svg/dom/frame-related-api-during-load-expected.txt: Added.
  • svg/dom/frame-related-api-during-load.html: Added.

2010-03-23 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

WebCore::SelectionController::setSelection NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31545

Added missing NULL-check that other APIs have.

Test: svg/dom/frame-related-api-during-load.html

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::deselectAll):
10:09 Changeset [56400] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Interpreter fix for <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)

Reviewed by Mark Rowe.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Only take the fast negate path if
a bit other than bit 31 is set. If none of bits 0-30 are set, then the
value we're negating can only be 0 or -2147483648, and neither can be
negated in int space.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate): Updated the JIT implementation to match
the interpreter, since it's slightly simpler.

09:52 Changeset [56399] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-23 David Leong <david.leong@nokia.com>

Reviewed by Laszlo Gombos.

Build fix for Symbian Def file.

  • symbian/eabi/QtWebKitu.def:
09:44 QtWebKitBackportingFixes edited by siddharth.mathur@nokia.com
added JSC collector memory improvement #34350 (diff)
09:34 Changeset [56398] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Simon Hausmann.

Qt] LayoutTests/fast/canvas/fillrect_gradient.html failed
https://bugs.webkit.org/show_bug.cgi?id=36444

Enable LayoutTests/fast/canvas/fillrect_gradient.html

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/fillrect_gradient-expected.checksum: Added.
  • platform/qt/fast/canvas/fillrect_gradient-expected.png: Added.
  • platform/qt/fast/canvas/fillrect_gradient-expected.txt:

2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Simon Hausmann.

[Qt] LayoutTests/fast/canvas/fillrect_gradient.html failed
https://bugs.webkit.org/show_bug.cgi?id=36444

Handle duplicated or unsorted colorStop at platformDestory

  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
08:47 Changeset [56397] by jchaffraix@webkit.org
  • 3 edits in trunk/WebCore

Unreviewed build fix.

Try to make the window buildbot happy.

  • xml/XMLHttpRequestProgressEventThrottle.cpp:
  • xml/XMLHttpRequestProgressEventThrottle.h: Move initialization of the

static const in the cpp file.

08:42 Changeset [56396] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make gear menu appear on styles panel at all times.

https://bugs.webkit.org/show_bug.cgi?id=36490

  • inspector/front-end/inspector.css:
08:39 Changeset [56395] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-03-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: render nodes in inherited style bars as links.

https://bugs.webkit.org/show_bug.cgi?id=36486

  • English.lproj/localizedStrings.js:
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked): (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update.else.insertInheritedNodeSeparator): (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._selectNode):
  • inspector/front-end/inspector.js:
08:33 Changeset [56394] by jchaffraix@webkit.org
  • 10 edits
    5 adds in trunk

[XHR] onProgress event needs to be dispatched according to what the specification states
https://bugs.webkit.org/show_bug.cgi?id=18654

Reviewed by Alexey Proskuryakov.

WebCore:

Test: http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added XMLHttpRequestProgressEventThrottle to the build systems.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest): Created the throttle.
(WebCore::XMLHttpRequest::callReadyStateChangeListener): The 'readyState' event are
dispatched using the XMLHttpRequestProgressEventThrottle now. For the DONE state, we
need to flush any pending progress event as we do not want it to be dispatched after
the DONE readyState event.
(WebCore::XMLHttpRequest::createRequest): Made this event use the
XMLHttpRequestProgressEventThrottle for event dispatching.
(WebCore::XMLHttpRequest::abort): Ditto.
(WebCore::XMLHttpRequest::networkError): Ditto.
(WebCore::XMLHttpRequest::abortError): Ditto.
(WebCore::XMLHttpRequest::didReceiveData): Ditto. Also fixed a potential warning.
(WebCore::XMLHttpRequest::suspend):
(WebCore::XMLHttpRequest::resume): Implemented the logic for suspend / resume.

  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestProgressEventThrottle.cpp: Added.

(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::~XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): Implemented the bulk
of the event throttling here: we use a timer to do so, as long as the timer is active it means
that events are coming faster than the throttling time and we coalesce them.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchEvent): Generic method to dispatch an event.
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): Called when we want to dispatch
any pending events and stopping any further dispatching.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchPausedEvent): Used to dispatch the event
that was queued due to the object being suspended.
(WebCore::XMLHttpRequestProgressEventThrottle::fired): Used to dispatch any coalesced event.
(WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch): Used to check if we have
an event to dispatch.
(WebCore::XMLHttpRequestProgressEventThrottle::suspend): Marked the object as suspended.
(WebCore::XMLHttpRequestProgressEventThrottle::resume): Dispatched the event that was queued.

  • xml/XMLHttpRequestProgressEventThrottle.h: Added.

(WebCore::):
(WebCore::XMLHttpRequestProgressEventThrottle::suspended):

LayoutTests:

Add a test to check that progress events are really throttled.

  • http/tests/xmlhttprequest/resources/download-with-delay.php: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html: Added.
08:14 Changeset [56393] by pfeldman@chromium.org
  • 4 edits
    2 adds in trunk

2010-03-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Element inspector search funtion: Error dispatching: performSearch.

https://bugs.webkit.org/show_bug.cgi?id=36488

Test: inspector/elements-panel-search.html

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.): (injectedScriptConstructor):
07:57 Changeset [56392] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk

2010-03-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, fix the reviwer for r56391.

  • WebCore/ChangeLog
  • LayoutTests/ChangeLog
07:37 Changeset [56391] by laszlo.1.gombos@nokia.com
  • 6 edits
    2 adds in trunk

2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/canvas/patternfill-repeat.html failed.
https://bugs.webkit.org/show_bug.cgi?id=34477

Change Pattern to expose the repeatX and repeatY
at GraphicsContextQt to apply repeatX and repeatY

  • platform/graphics/Pattern.h: (WebCore::Pattern::repeatX): (WebCore::Pattern::repeatY):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::rotate):

2010-03-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/canvas/patternfill-repeat.html failed.
https://bugs.webkit.org/show_bug.cgi?id=34477

Enable LayoutTests/fast/canvas/patternfill-repeat.html.

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/patternfill-repeat-expected.checksum: Added.
  • platform/qt/fast/canvas/patternfill-repeat-expected.png: Added.
  • platform/qt/fast/canvas/patternfill-repeat-expected.txt:
07:19 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
minor (diff)
07:05 Changeset [56390] by eric@webkit.org
  • 35 edits in trunk

2010-03-23 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Updated test results from removal of use of STIX fonts.

  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/over-expected.checksum:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.checksum:
  • platform/mac/mathml/presentation/sub-expected.png:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.checksum:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.checksum:
  • platform/mac/mathml/presentation/sup-expected.png:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:
  • platform/mac/mathml/presentation/under-expected.checksum:
  • platform/mac/mathml/presentation/under-expected.png:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:

2010-03-23 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Removed the use of beta STIX fonts.

  • css/mathml.css:
06:34 Changeset [56389] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] websocket/tests/long-invalid-header.html fails
https://bugs.webkit.org/show_bug.cgi?id=36492

  • platform/qt/Skipped: websocket/tests/long-invalid-header.html skipped until fix.
06:23 Changeset [56388] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-23 Gustavo Noronha Silva <gns@gnome.org>

[GTK] Failing fast/css/zoom-body-scroll.html - sizes are off by one after zooming out
https://bugs.webkit.org/show_bug.cgi?id=36491

Skipping test that fails on 32 bits bots.

  • platform/gtk/Skipped:
06:23 Changeset [56387] by kov@webkit.org
  • 11 edits
    1 add in trunk

WebCore

2010-03-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] Does not build with latest GTK+ development release
https://bugs.webkit.org/show_bug.cgi?id=36398

Fix building with newest GTK+ versions.

  • GNUmakefile.am:
  • platform/gtk/GtkPluginWidget.cpp: (WebCore::GtkPluginWidget::invalidateRect): (WebCore::GtkPluginWidget::paint):
  • platform/gtk/GtkVersioning.h: Added.
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::paint):
  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_set_position): (gtk_xtbin_unrealize):

WebKit/gtk

2010-03-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

[GTK] Does not build with latest GTK+ development release
https://bugs.webkit.org/show_bug.cgi?id=36398

Fix building with newest GTK+ versions.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::setWindowRect): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::contentsSizeChanged):
  • webkit/webkitprivate.cpp: (currentToplevelCallback):
  • webkit/webkitwebframe.cpp: (webkit_web_frame_print_full): (webkit_web_frame_print):
  • webkit/webkitwebview.cpp: (webkit_web_view_grab_focus): (webkit_web_view_focus_in_event): (webkit_web_view_script_dialog):
05:52 Changeset [56386] by eric@webkit.org
  • 16 edits in trunk

2010-03-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389

No new tests as there is no new functionality.

  • WebCore.pri:
  • WebCore.pro:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::willLoadFromCache):
  • platform/qt/CookieJarQt.cpp: (WebCore::setCookies): (WebCore::cookies):
  • platform/qt/KURLQt.cpp: (WebCore::KURL::operator QUrl):
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paintScrollCorner):
  • plugins/mac/PluginViewMac.cpp:

2010-03-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389

  • Api/qwebelement.cpp: (QWebElement::classes):
  • Api/qwebpage.cpp: (QWebPagePrivate::editorActionForKeyEvent): (QWebPage::userAgentForUrl):
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
  • tests/tests.pro:

2010-03-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt v4.4
https://bugs.webkit.org/show_bug.cgi?id=36389

  • DumpRenderTree/qt/main.cpp: (main):
  • QtLauncher/mainwindow.cpp: (MainWindow::MainWindow):
04:07 Changeset [56385] by tkent@chromium.org
  • 8 edits in trunk/WebCore

2010-03-23 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

Add checks if setNeedsWillValidateCheck() and
setNeedsValidityCheck() are called correctly.
https://bugs.webkit.org/show_bug.cgi?id=34924

Introduce HTMLFormControlElement::m_willValidate and
m_isValid. They are the caches of willValidate() and
isValidFormControlElement(). setNeedsWillValidateCheck() updates
m_willValidate and setNeedsValidityCheck() updates m_isValid.

willValidate() and isValidFormControlElement() have assertions to
check m_willvalidate or m_isValid has the correct state. If
setNeedsWillValidateCheck() or setNeedsValidityCheck() is needed
to be called and is not called, these assertions fail.

  • html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::recalcWillValidate):
  • html/HTMLFieldSetElement.h: (WebCore::HTMLFieldSetElement::recalcWillValidate):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseMappedAttribute): (WebCore::HTMLFormControlElement::recalcWillValidate): (WebCore::HTMLFormControlElement::willValidate): (WebCore::HTMLFormControlElement::setNeedsWillValidateCheck): (WebCore::HTMLFormControlElement::validationMessage): (WebCore::HTMLFormControlElement::isValidFormControlElement): (WebCore::HTMLFormControlElement::setNeedsValidityCheck):
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::recalcWillValidate):
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setNonDirtyValue):
01:18 Changeset [56384] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, remove flaky tag in websocket tests.

flakiness in websocket tests (http://crbug.com/38397) introducted at
Chromium r41818 has been fixed at r42320.

  • platform/chromium/test_expectations.txt: remove BUG38397
00:07 Changeset [56383] by pfeldman@chromium.org
  • 11 edits
    2 adds in trunk

2010-03-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dave Hyatt.

Web Inspector: display CSS selector source line in the styles sidebar pane.

https://bugs.webkit.org/show_bug.cgi?id=36414

This change adds a sourceLine field into the CSSStyleRule that is populated
from within the parser. CSSParser is now keeping track of the line numbers
and last selector line number that is being used while creating CSSStyleRules.

Test: inspector/styles-source-lines.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::lex): (WebCore::CSSParser::countLines): (WebCore::CSSParser::createStyleRule):
  • css/CSSParser.h: (WebCore::CSSParser::updateLastSelectorLine):
  • css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule):
  • css/CSSStyleRule.h: (WebCore::CSSStyleRule::create): (WebCore::CSSStyleRule::sourceLine):
  • css/tokenizer.flex:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForRule):
  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration.parseRule):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):

03/22/10:

23:48 Changeset [56382] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2010-03-22 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

Qt] Fix arc function in canvas
https://bugs.webkit.org/show_bug.cgi?id=36296

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/arc360-expected.checksum: Added.
  • platform/qt/fast/canvas/arc360-expected.png: Added.
  • platform/qt/fast/canvas/arc360-expected.txt: Added.

2010-03-22 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix arc function in canvas
https://bugs.webkit.org/show_bug.cgi?id=36296

Based on HTLM5 spec (4.8.10.1.8 Complex shapes), arc function should draw a line to previous point, not only the arc.

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
23:30 Changeset [56381] by eric@webkit.org
  • 4 edits
    4 adds in trunk/WebKit/chromium

2010-03-22 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add GraphicsContext3D abstraction to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36262

Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
GraphicsContext3D implementation to use it. All of the OpenGL calls have
been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
WebGraphicsContext3D implementation. GraphicsContext3D is still
responsible for the transfer of rendered output from the
WebGraphicsContext3D to the HTMLCanvasElement.

The GraphicsContext3DInternal class, which is a data member of
GraphicsContext3D for the Chromium port, remains. It is possible to
eliminate this class and thereby one level of delegation, but this is
being deferred.

The needed entry point for a Chrome implementation of
WebGraphicsContext3D has been added to WebKitClient, but it is not being
called yet by GraphicsContext3D. It will be once this patch lands and
Chromium is rolled forward to support this entry point.

This is a large patch, but the transformation is almost entirely
mechanical and there is no change in functionality. Nearly all of
GraphicsContext3D and GraphicsContext3DInternal has been moved to
WebGraphicsContext3DDefaultImpl. The only area where the splitting of
logic is less than mechanical is GraphicsContext3D::beginPaint() and its
callees.

Ran all WebGL layout tests and demos from Khronos site in Chromium
on Mac and Windows.

  • WebKit.gyp:
  • public/WebGraphicsContext3D.h: Added. (WebKit::WebGraphicsContext3D::Attributes::Attributes): (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
  • public/WebKitClient.h: (WebKit::WebKitClient::createGraphicsContext3D):
  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::endPaint): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::readPixels): (WebCore::GraphicsContext3DInternal::shaderSource): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
  • src/WebGraphicsContext3D.cpp: Added. (WebKit::WebGraphicsContext3D::createDefault):
  • src/WebGraphicsContext3DDefaultImpl.cpp: Added. (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection): (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState): (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::width): (WebKit::WebGraphicsContext3DDefaultImpl::height): (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes): (WebKit::createTextureObject): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture): (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::drawElements): (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::getError): (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::getString): (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createProgram): (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createTexture): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram): (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture): (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
  • src/WebGraphicsContext3DDefaultImpl.h: Added. (WebKit::WebGraphicsContext3DDefaultImpl::): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):
23:08 Changeset [56380] by ukai@chromium.org
  • 3 edits
    4 adds in trunk

2010-03-19 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36339
This LayoutTest tests for webkit ability to process long invalid headers generated by misbehaving websockets servers.

  • websocket/tests/long-invalid-header-expected.txt: Added.
  • websocket/tests/long-invalid-header.html: Added.
  • websocket/tests/long-invalid-header_wsh.py: Added.
  • websocket/tests/script-tests/long-invalid-header.js: Added.

2010-03-19 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36339
Off-by-one memory corruption fix for long invalid websockets upgrade header

Test: websocket/tests/long-invalid-header.html

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):
22:51 Changeset [56379] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-22 David Kilzer <ddkilzer@apple.com>

Remove http/tests/cookies/simple-cookies-expired.html from skip list after CFNetwork issue is resolved
<http://webkit.org/b/25861>
<rdar://problem/6901322>

Reviewed by Darin Adler.

  • platform/win/Skipped: Removed:
  • http/tests/cookies/simple-cookies-expired.html
22:32 Changeset [56378] by eric@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

2010-03-22 Eric Seidel <eric@webkit.org>

Rubber-stamped by Brady Eidson.

fast/loader/cancel-load-during-port-block-timer.html fails on Tiger bot
https://bugs.webkit.org/show_bug.cgi?id=36425

This test bleeds into the next test and causes failures. Unsure of the
cause. Brady suggests we disable it for now (to match the other disabled) api test.

  • fast/loader/api-test-go-to-current-back-forward-item.html-disabled: Renamed from LayoutTests/fast/loader/api-test-go-to-current-back-forward-item.html.
22:03 Changeset [56377] by ukai@chromium.org
  • 2 edits in trunk/WebCore

2010-03-22 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed build fix for Chromim Mac at r56376

Fix initializer order of PopupContainer.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer):
20:01 Changeset [56376] by eric@webkit.org
  • 10 edits in trunk

2010-03-22 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062

  • page/chromium/ChromeClientChromium.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::~PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupContainer::hidePopup): (WebCore::PopupMenu::show):
  • platform/chromium/PopupMenuChromium.h: (WebCore::PopupContainer::): (WebCore::PopupContainer::popupType):

2010-03-22 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

Making Chromium select popups not steal activation from the browser.
Select popups are now like autocomplete popups, shown in non-activated
windows.
https://bugs.webkit.org/show_bug.cgi?id=36062

  • public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened): (WebKit::ChromeClientImpl::popupClosed):
  • src/ChromeClientImpl.h:
  • src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::hideSelectPopup): (WebKit::WebViewImpl::popupOpened): (WebKit::WebViewImpl::popupClosed): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions):
  • src/WebViewImpl.h:
19:21 Changeset [56375] by dimich@chromium.org
  • 4 edits
    2 adds in trunk

[v8] Crash if the worker is terminated before its initial script is executed.
https://bugs.webkit.org/show_bug.cgi?id=36336

Reviewed by Nate Chapin.

WebCore:

Test: fast/workers/termination-early.html

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Check for 0 context. When terminated, the v8 heap initialization returns 0.
(WebCore::WorkerContextExecutionProxy::evaluate): Don't execute script if initialization failed.

  • bindings/v8/WorkerContextExecutionProxy.h:

LayoutTests:

  • fast/workers/termination-early-expected.txt: Added.
  • fast/workers/termination-early.html: Added.
19:11 Changeset [56374] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Support creation of fake workers before document is loaded by deferring
attaching of fake workers iframe until document is loaded and buffering all
messages addressed to worker.
https://bugs.webkit.org/show_bug.cgi?id=36445

  • inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype._buildWorker): (InjectedFakeWorker.FakeWorker.prototype._attachWorkerFrameToDocument): (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded):
18:31 Changeset [56373] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-03-22 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix qdoc warnings
https://bugs.webkit.org/show_bug.cgi?id=36447

  • Api/qgraphicswebview.cpp: Add missing ().
  • Api/qwebframe.cpp: Remove reference to non-existent parameter "url".
  • Api/qwebsettings.cpp: Document parameter "location".
18:13 Changeset [56372] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-22 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Adam Barth.

Make build_webkit_command() pass MAKEFLAGS environment variable to make.
https://bugs.webkit.org/show_bug.cgi?id=36440

  • Scripts/webkitpy/webkitport.py:
  • Scripts/webkitpy/webkitport_unittest.py:
17:28 Changeset [56371] by mjs@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

(Not reviewed.)

Add another example.

  • demos/accessible-ascii-art/butterfly-figure.html: Added.
17:28 Changeset [56370] by eric@webkit.org
  • 4 edits
    3 adds in trunk/JavaScriptCore

2010-03-22 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] More efficient aligned memory allocation for JSC Collector
https://bugs.webkit.org/show_bug.cgi?id=34350

  • runtime/Collector.cpp: Reduced port-specific code and added private data member (JSC::Heap::Heap): (JSC::Heap::~Heap): (JSC::Heap::destroy): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr):
  • runtime/Collector.h: Added private data member
  • wtf/symbian: Added.
  • wtf/symbian/BlockAllocatorSymbian.cpp: Added. (WTF::AlignedBlockAllocator::AlignedBlockAllocator): Helper class to allocate aligned blocks more efficiently as required by Collector (WTF::AlignedBlockAllocator::alloc): (WTF::AlignedBlockAllocator::free): (WTF::AlignedBlockAllocator::destroy): (WTF::AlignedBlockAllocator::~AlignedBlockAllocator):
  • wtf/symbian/BlockAllocatorSymbian.h: Added.
16:51 Changeset [56369] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, skip new failing test.

fast/loader/stateobjects/replacestate-in-iframe.html caused infinite loop.
https://bugs.webkit.org/show_bug.cgi?id=36467

  • platform/gtk/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.
  • platform/qt/Skipped: fast/loader/stateobjects/replacestate-in-iframe.html skipped until fix.
16:43 Changeset [56368] by mjs@apple.com
  • 1 edit
    2 adds in trunk/WebKitSite

(Not reviewed.)

Add example of accessible ASCII art for HTML WG.

  • demos/accessible-ascii-art: Added.
  • demos/accessible-ascii-art/butterfly.html: Added.
16:14 Changeset [56367] by japhet@chromium.org
  • 5 edits
    6 adds in trunk/LayoutTests

2010-03-22 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium test fixes.

  • platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum:
  • platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
  • platform/chromium-mac/svg/filters/feColorMatrix-values-expected.checksum: Added.
  • platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/chromium-mac/svg/filters/feColorMatrix-values-expected.txt: Added.
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum: Added.
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt: Added.
16:04 Changeset [56366] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-03-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Change baseline_path() to point to the upstream locations for the
Chromium ports. Also change the reabselining scripts to use the
correct functions to get the baseline directories, and fix the
script's sys.path to pull in simplejson correctly.

https://bugs.webkit.org/show_bug.cgi?id=36417

  • Scripts/rebaseline-chromium-webkit-tests:
    • fix sys.path to pick up simplejson properly
  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • change baseline_path() to use webkit_baseline_path()
    • error out correctly if we can't find the chromium base dir
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • call baseline_path(), not chromium_baseline_path()
15:57 Changeset [56365] by darin@chromium.org
  • 3 edits
    2 adds in trunk

2010-03-22 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

HistoryController::replaceState() should modify m_currentItem
instead of the current HistoryItem of the BackForwardList.

https://bugs.webkit.org/show_bug.cgi?id=36435

Test: fast/loader/stateobjects/replacestate-in-iframe.html

  • loader/HistoryController.cpp: (WebCore::HistoryController::replaceState):
15:54 Changeset [56364] by hausmann@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

Oops, fix spurious angle brackets around name in patch I landed manually

15:31 Changeset [56363] by joepeck@webkit.org
  • 5 edits in trunk/WebCore

2010-03-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283> and <rdar://problem/7707318>

Part 3 of 3: Shared code between iphone and mac. The shared code was
refactored to be usable by both platforms without platform specific
typing, meaning no NSEvent versus WebEvent special cases.

Shared code usable by either mac or iphone platforms.

  • platform/cocoa/KeyEventCocoa.h:
  • platform/cocoa/KeyEventCocoa.mm: (WebCore::keyIdentifierForCharCode): (WebCore::windowsKeyCodeForKeyCode): (WebCore::windowsKeyCodeForCharCode):

Make use of the shared code. Keep anything platform specific in the
original file before calling the shared code.

  • platform/iphone/KeyEventIPhone.mm: (WebCore::keyIdentifierForKeyEvent):
  • platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent):
15:17 Rebaseline edited by dglazkov@chromium.org
(diff)
15:15 Rebaseline edited by dglazkov@chromium.org
Added title. (diff)
15:09 Rebaseline edited by dglazkov@chromium.org
Clean up rebaseline doc. (diff)
15:05 Changeset [56362] by kdecker@apple.com
  • 8 edits
    3 deletes in trunk

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=36328

  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::updateWidget): Don't update the widget if we're showing the missing plug-in indicator. (WebCore::RenderEmbeddedObject::paint):Fix a find/repalce mistake from my earlier patch. Rename m_setShowsMissingPluginIndicator -> m_showsMissingPluginIndicator. (WebCore::RenderEmbeddedObject::paintReplaced): Ditto.
  • rendering/RenderEmbeddedObject.h: Ditto. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): Ditto. (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator): Ditto.
  • Plugins/WebNetscapePluginView.mm:
  • Plugins/WebNullPluginView.h: Removed.
  • Plugins/WebNullPluginView.mm: Removed.
  • Resources/nullplugin.tiff: Removed.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Invoke the resource load delegate if the plug-in failed to load.
14:56 Changeset [56361] by joepeck@webkit.org
  • 3 edits
    1 copy
    2 adds in trunk/WebCore

2010-03-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Upstream Part of the iPhone Platform sharing code with the Mac Platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>

Part 2 of 3: No changes other than moving code around.
Copied KeyEvent function from platform/mac to a platform/cocoa shared directory.

  • WebCore.xcodeproj/project.pbxproj: Added cocoa group and new files.
  • platform/cocoa/KeyEventCocoa.h: Added.
  • platform/cocoa/KeyEventCocoa.mm: Copied from WebCore/platform/mac/KeyEventMac.mm. (WebCore::keyIdentifierForKeyEvent): (WebCore::windowsKeyCodeForKeyEvent): Include the shared code.
  • platform/mac/KeyEventMac.mm:
14:24 Changeset [56360] by joepeck@webkit.org
  • 3 edits
    3 adds in trunk/WebCore

2010-03-22 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Part 1 of 3: Upstream iPhone KeyEvent platform code and share with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=35870
<rdar://problem/7707283>

  • WebCore.xcodeproj/project.pbxproj: Added iphone group and new files.
  • platform/iphone: Added.
  • platform/iphone/KeyEventCodesIPhone.h: Added.
  • platform/iphone/KeyEventIPhone.mm: Added. Ensure PLATFORM(IPHONE)
  • platform/mac/KeyEventMac.mm: Ensure PLATFORM(MAC)
14:14 Changeset [56359] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip editing test that fails

  • platform/qt/Skipped:
14:08 Changeset [56358] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-22 Dirk Schulze <krit@webkit.org>

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

SVG Test has text in it. This caused a wrong DRT result on Mac.
The other result was created on Windows.

  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
13:38 Changeset [56357] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix the Leopard build.

  • rendering/RenderEmbeddedObject.cpp: Add ".f" to contants.
13:28 Changeset [56356] by krit@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-03-22 Dirk Schulze <krit@webkit.org>

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Add missing expected result.

  • platform/mac/svg/filters/feColorMatrix-values-expected.txt: Added.
13:24 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
12:46 Changeset [56355] by krit@webkit.org
  • 3 edits
    7 adds in trunk

2010-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.

Tests: svg/filters/feColorMatrix-invalid-value.svg

svg/filters/feColorMatrix-values.svg

  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):

2010-03-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

Prevents an invalid read when a valid values attribute is not
supplied for an feColorMatrix SVG filter. Also fixes general
handling of missing or invalid values attribute.

  • platform/win/svg/filters: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.checksum: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.txt: Added.
  • svg/filters/feColorMatrix-invalid-value-expected.txt: Added.
  • svg/filters/feColorMatrix-invalid-value.svg: Added.
  • svg/filters/feColorMatrix-values.svg: Added.
12:37 Changeset [56354] by philn@webkit.org
  • 4 edits
    2 adds in trunk/WebCore

2010-03-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] Use ImageBuffer API to do painting
https://bugs.webkit.org/show_bug.cgi?id=35783

New ImageGStreamer class abstracting the conversion of GStreamer
buffers to cairo surfaces. Using this makes the painting code of
the player more generic.

  • GNUmakefile.am:
  • platform/graphics/gstreamer/ImageGStreamer.h: Added. (WebCore::ImageGStreamer::image):
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Added. (ImageGStreamer::createImage): (ImageGStreamer::ImageGStreamer): (ImageGStreamer::~ImageGStreamer):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::paint):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
12:36 Changeset [56353] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/7766437> With Web Inspector opened, a crash
occurs at Webcore:getMatchedCSSRules() when navigating to a
previous page

Reviewed by Darin Adler.

defaultView() can legitimately by null (as it is in this case), so
it must be null-checked.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getStyles):
(WebCore::InspectorDOMAgent::getComputedStyle):
(WebCore::InspectorDOMAgent::getMatchedCSSRules):

12:30 Changeset [56352] by kdecker@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=36328


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin): Call setShowsMissingPluginIndicator(true) in cases that fail to generate a widget.
  • rendering/RenderEmbeddedObject.cpp: Added new missing plug-in related static constants (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Initialize newly boolean to false. (WebCore::RenderEmbeddedObject::paint): Added. (WebCore::RenderEmbeddedObject::paintReplaced): Added. Draws a subtle rounded rectangle containing the text "Missing Plug-in".
  • rendering/RenderEmbeddedObject.h: Added the following two methods below. (WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator): (WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
  • rendering/RenderWidget.h: Moved paint(PaintInfo&, int, int) from private to protected.
11:45 Changeset [56351] by ap@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=36455
Make WebKit more resistant against plug-in crashes

No tests, because crashing on build bots isn't good, even if it's only helper processes
that crash.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::waitForReply): Protect "this", because this function needs it after waiting for reply. Some callers used to do this, but not all, and we really shouldn't depend on callers here.
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::wheelEvent): Don't protect the plug-in instance proxy, because this function doesn't use it after waiting for reply. (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Ditto.
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): Added an m_instanceProxy null check for another code path.
11:44 Changeset [56350] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-22 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium expectations tweak.

Add fast/dom/error-to-string-stack-overflow.html to expected
failures due to http://trac.webkit.org/changeset/56329.

  • platform/chromium/test_expectations.txt:
11:40 Changeset [56349] by jwieczorek@webkit.org
  • 5 edits in trunk

2010-03-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Phonon media backend: expose supported MIME types to WebCore

https://bugs.webkit.org/show_bug.cgi?id=33453

List all skipped media tests individually and unskip two fixed by the patch.

  • platform/qt/Skipped:

2010-03-22 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Phonon media backend: expose supported MIME types to WebCore

https://bugs.webkit.org/show_bug.cgi?id=33453

MediaPlayerPrivate should expose the MIME types that are supported
by the underlying backend in Phonon.

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::supportedTypesCache): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::supportsType):
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h:
11:33 Changeset [56348] by ggaren@apple.com
  • 6 edits
    2 adds in trunk

JavaScriptCore: Fixed <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)

Reviewed by Sam Weinig.

Two ways to fix the same bug:

  1. Check for overflow when negating, since negating the largest negative

int causes overflow.

  1. Constant-fold even when negating a negative, since, like they say in

high school, "math works."

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchNeg32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchNeg32): Added a branching version
of the negate operator.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate): Use the branching version of the negate
operator to check for overflow.

(JSC::JIT::emitSlow_op_negate): Link the check for overflow to a slow case.
(We could emit inline code for this, since we know what the result would
be, but that's probably just a waste of generated code.)

  • parser/Grammar.y: Constant fold even when negating a negative.

LayoutTests: Added a test for <rdar://problem/7728196> REGRESSION (r46701): -(-2147483648)
evaluates to -2147483648 on 32 bit (35842)

Reviewed by Sam Weinig.

  • fast/js/negate-overflow-expected.txt: Added.
  • fast/js/negate-overflow.html: Added.
11:18 Changeset [56347] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-03-22 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: AuditRules still use getMatchedCSSRules as a part of the img-related audit.
https://bugs.webkit.org/show_bug.cgi?id=36424

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.pushImageNodes):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
11:17 Changeset [56346] by darin@chromium.org
  • 3 edits
    2 adds in trunk

2010-03-22 Darin Fisher <darin@chromium.org>

Reviewed by Nate Chapin.

[chromium] Renderer crashes when navigating to a reference fragment in
a frame that has no current HistoryItem.

https://bugs.webkit.org/show_bug.cgi?id=36443

Test: fast/loader/crash-replacing-location-before-load.html

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
10:51 Changeset [56345] by darin@apple.com
  • 2 edits in trunk/WebCore

2010-03-22 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

TextBreakIteratorICU.cpp is incompatible with new UBreakIterator type in ICU 4.4
https://bugs.webkit.org/show_bug.cgi?id=36381

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Use reinterpret_cast instead of static_cast or relying on conversion to void*. (WebCore::textBreakFirst): Ditto. (WebCore::textBreakLast): Ditto. (WebCore::textBreakNext): Ditto. (WebCore::textBreakPrevious): Ditto. (WebCore::textBreakPreceding): Ditto. (WebCore::textBreakFollowing): Ditto. (WebCore::textBreakCurrent): Ditto. (WebCore::isTextBreak): Ditto. (WebCore::setUpIteratorWithRules): Ditto.
10:48 Changeset [56344] by eric.carlson@apple.com
  • 8 edits in trunk/WebCore

2010-03-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

Typo in GPL license text
https://bugs.webkit.org/show_bug.cgi?id=36442

Fix typo - "aint with this library" -> "along with this library".

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/IDLParser.pm:
  • bindings/scripts/IDLStructure.pm:
  • bindings/scripts/generate-bindings.pl:
10:42 Changeset [56343] by jwieczorek@webkit.org
  • 5 edits in trunk

2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373

Instead, keep one instance per RenderTheme around.

  • platform/qt/RenderThemeQt.cpp: (WebCore::findFrameLineWidth):

2010-03-22 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Don't construct a QLineEdit every time when painting a text field
https://bugs.webkit.org/show_bug.cgi?id=36373

Add a simple benchmark covering this area.

  • tests/benchmarks/painting/tst_painting.cpp: (tst_Painting::textAreas):
10:39 Changeset [56342] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

<http://webkit.org/b/36431> Clean up 'int' use in UString.cpp after r54789

Reviewed by Darin Adler.

  • runtime/UString.cpp:

(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
(JSC::UString::find): Changed static_cast<int>() to
static_cast<unsigned>() now that this method returns unsigned.
(JSC::UString::rfind): Ditto.

  • runtime/UString.h:

(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.

10:38 Changeset [56341] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-22 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Multiselect Popup - adjusting QtAbstractWebPopup
https://bugs.webkit.org/show_bug.cgi?id=36186

QtAbstractWebPopup must provide new methods to be used by its descendants that
wish to handle <select multiple> elements.

  • platform/qt/QtAbstractWebPopup.cpp: (WebCore::QtAbstractWebPopup::selectItem): (WebCore::QtAbstractWebPopup::multiple):
  • platform/qt/QtAbstractWebPopup.h:
10:20 Changeset [56340] by eric@webkit.org
  • 4 edits
    10 adds in trunk

2010-03-22 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Basic tests of mfrac (fractions)

  • mathml/presentation/fractions.xhtml: Added.
  • mathml/presentation/fractions-vertical-alignment.xhtml: Added
  • platform/mac/mathml/presentation/fractions-expected.checksum: Added.
  • platform/mac/mathml/presentation/fractions-expected.png: Added.
  • platform/mac/mathml/presentation/fractions-expected.txt: Added.
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum: Added.
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.

2010-03-22 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added basic support for mfrac (fractions)

Test: mathml/presentation/fractions.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/RenderMathMLFraction.cpp: Added. (WebCore::RenderMathMLFraction::RenderMathMLFraction): (WebCore::RenderMathMLFraction::updateFromElement): (WebCore::RenderMathMLFraction::addChild):
  • mathml/RenderMathMLFraction.h: Added.
09:47 Changeset [56339] by darin@apple.com
  • 4 edits in trunk/WebKit

WebKit: * StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit/win: * WebCoreLocalizedStrings.cpp:
(WebCore::missingPluginText): Fixed localization helper text to match the same
string from Mac WebKit.

09:46 Rebaseline created by dglazkov@chromium.org
Ported rebaseline tool documentation from Chromium wiki
09:45 Changeset [56338] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=36400
Add a test for r15750 (Flash crashes after it replaces itself via a document.write())

  • plugins/destroy-plugin-from-callback-expected.txt: Added.
  • plugins/destroy-plugin-from-callback.html: Added.
09:29 Changeset [56337] by kdecker@apple.com
  • 14 edits in trunk

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=36328

  • page/mac/WebCoreViewFactory.h: Added -missingPluginText method
  • platform/LocalizedStrings.h: Added missingPluginText()
  • platform/gtk/LocalizedStringsGtk.cpp: Likewise.
  • platform/mac/LocalizedStringsMac.mm: Same here.
  • platform/qt/Localizations.cpp: Ditto.
  • English.lproj/Localizable.strings: Added "Missing Plug-in" string.
  • src/LocalizedStrings.cpp: (WebCore::missingPluginText): Added
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory missingPluginText]): Added.
09:24 Changeset [56336] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-22 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

Refactored the cpu_count() code in executive.py.

https://bugs.webkit.org/show_bug.cgi?id=36437

  • Scripts/webkitpy/executive.py:
    • Moved the import of the multiprocessing module to the top of the file rather than importing from within a function.
08:24 Changeset [56335] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

Revert "2010-03-18 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>"

This reverts commit d76f355a659be5b3384f9c26bc6ad64f3256c9fb.

Conflicts:

WebKitTools/ChangeLog

08:09 Changeset [56334] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-03-22 Yi Shen <shenyi2006@gmail.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=35933
[Qt] [Symbian] Can not backward select (highlight) text using virtual keyboard
Make sure the selection start index is smaller than the selection end index.

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
07:37 Changeset [56333] by eric@webkit.org
  • 7 edits
    3 adds in trunk/JavaScriptCore

2010-03-22 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add support for syntax checking in the QtScript API.

New class was created; the QScriptSyntaxCheckResult which main
responsibility is to provide results of the ECMA Script code
syntax check. The class is not fully functional as the JSC C API
doesn't expose an error column number, but it is a good start point
for a future development.

[Qt] QtScript functionality should be extended by syntax checking.
https://bugs.webkit.org/show_bug.cgi?id=36123

  • qt/api/QtScript.pro:
  • qt/api/qscriptengine.cpp: (QScriptEngine::checkSyntax):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::checkSyntax):
  • qt/api/qscriptengine_p.h:
  • qt/api/qscriptsyntaxcheckresult.cpp: Added. (QScriptSyntaxCheckResult::QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::~QScriptSyntaxCheckResult): (QScriptSyntaxCheckResult::operator=): (QScriptSyntaxCheckResult::state): (QScriptSyntaxCheckResult::errorLineNumber): (QScriptSyntaxCheckResult::errorColumnNumber): (QScriptSyntaxCheckResult::errorMessage):
  • qt/api/qscriptsyntaxcheckresult.h: Added.
  • qt/api/qscriptsyntaxcheckresult_p.cpp: Added. (QScriptSyntaxCheckResultPrivate::~QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::errorMessage): (QScriptSyntaxCheckResultPrivate::errorLineNumber):
  • qt/api/qscriptsyntaxcheckresult_p.h: Added. (QScriptSyntaxCheckResultPrivate::get): (QScriptSyntaxCheckResultPrivate::QScriptSyntaxCheckResultPrivate): (QScriptSyntaxCheckResultPrivate::state): (QScriptSyntaxCheckResultPrivate::errorColumnNumber):
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::checkSyntax_data): (tst_QScriptEngine::checkSyntax):
06:26 Changeset [56332] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Fix inspected Page crash in destructor when Web Inspector is open.

https://bugs.webkit.org/show_bug.cgi?id=36441

  • src/js/InjectDispatch.js: (inspectedPageDestroyed): Added stub for missing method.
05:49 Changeset [56331] by cjerdonek@webkit.org
  • 2 edits
    1 copy
    1 add in trunk/WebKitTools

Created a function for getting a module-specific logging.logger
based on the file value of the module.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35821

This function allows us to get the module-specific logger for
a module without having to hard-code the fully-qualified name
of the module in the module itself. The code can be the same
in every case: "_log = logutils.get_logger(file)".

  • Scripts/webkitpy/init/logutils.py: Added.
    • Added a module with a get_logger() function to return a module-specific logger based on the module's file variable.
  • Scripts/webkitpy/init/logutils_unittest.py: Added.
    • Added unit tests for logutils.py.
  • Scripts/webkitpy/init/unittests.py:
    • Added logutils_unittest to the list of imports.
04:43 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
04:07 Changeset [56330] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-22 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Added methods to WebSecurityOrigin for invoking
SecurityOrigin::canAccess and SecurityOrigin::Create
https://bugs.webkit.org/show_bug.cgi?id=36356

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::create): (WebKit::WebSecurityOrigin::canAccess):
02:46 Changeset [56329] by yurys@chromium.org
  • 8 edits
    1 add in trunk

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Handle worker exceptions in V8MessageHandler like it's done in regular documents. This way all worker exceptions will be logged in the console not only those which happen in event listeners.

https://bugs.webkit.org/show_bug.cgi?id=31171

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): Removed explicit call to reportException.
  • bindings/v8/V8Utilities.cpp: reportException function was removed since it's not used. (WebCore::getScriptExecutionContext):
  • bindings/v8/V8Utilities.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::v8MessageHandler): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): Setup message handler when first worker context is created.

2010-03-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that uncaught exception thrown from setTimeout callback in a Worker is reported to the worker object.

https://bugs.webkit.org/show_bug.cgi?id=31171

  • fast/workers/resources/worker-exception-in-timeout-callback.js: Added.
  • fast/workers/worker-script-error-expected.txt:
  • fast/workers/worker-script-error.html:
02:43 Changeset [56328] by eric@webkit.org
  • 4 edits in trunk

2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386

  • platform/qt/Skipped: unskip the test as it now passes.

2010-03-22 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386

Fix the regression by implementing a null printer for Qt DRT.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::NullPrinter::NullPaintEngine::begin): (WebCore::NullPrinter::NullPaintEngine::end): (WebCore::NullPrinter::NullPaintEngine::type): (WebCore::NullPrinter::NullPaintEngine::drawPixmap): (WebCore::NullPrinter::NullPaintEngine::updateState): (WebCore::NullPrinter::paintEngine): (WebCore::DumpRenderTree::dryRunPrint):
02:24 Changeset [56327] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to page/EventHandler.cpp.
http://webkit.org/b/36306

  • page/EventHandler.cpp:
02:06 Changeset [56326] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/DragImage.h and
platform/DragData.h.
http://webkit.org/b/36310

  • platform/DragImage.h:
  • platform/DragData.h:
01:45 Changeset [56325] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/FileSystem.h.
http://webkit.org/b/36313

  • platform/FileSystem.h:
01:26 Changeset [56324] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/Cursor.h.
http://webkit.org/b/36319

  • platform/Cursor.h:
01:05 Changeset [56323] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Simon Hausmann.

Add EFL-specific code to platform/NotImplemented.h.
http://webkit.org/b/36320

  • platform/NotImplemented.h:

03/21/10:

16:21 Changeset [56322] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-03-21 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Fixed updating the VKB display when inputting into QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=36292

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_updateMicroFocus): (QGraphicsWebView::setPage):
  • Api/qgraphicswebview.h:
15:52 Changeset [56321] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-21 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: matrix interpolations in transform-animations don't behave correctly
https://bugs.webkit.org/show_bug.cgi?id=35520

The case where the list of source and target transform operations are
not the same but have the same size needs to be special-cased in
GraphicsLayerQt, as well as the case where the source or target
operation list is empty. The URLs listed here render correctly after
applying the patch.

Tests: https://bug-35520-attachments.webkit.org/attachment.cgi?id=49890

https://bug-35520-attachments.webkit.org/attachment.cgi?id=49889

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::TransformAnimationQt::applyFrame):
15:30 Changeset [56320] by eric@webkit.org
  • 7 edits
    1 copy
    2 adds in trunk/JavaScriptCore

2010-03-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

New class; QScriptProgram.

The class should be used to evaluate the same script multiple times
more efficiently.

[Qt] QtScript should have QScriptProgram class
https://bugs.webkit.org/show_bug.cgi?id=36008

  • qt/api/QtScript.pro:
  • qt/api/qscriptengine.cpp: (QScriptEngine::evaluate):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::evaluate):
  • qt/api/qscriptengine_p.h: (QScriptEnginePrivate::evaluate):
  • qt/api/qscriptprogram.cpp: Added. (QScriptProgram::QScriptProgram): (QScriptProgram::~QScriptProgram): (QScriptProgram::operator=): (QScriptProgram::isNull): (QScriptProgram::sourceCode): (QScriptProgram::fileName): (QScriptProgram::firstLineNumber): (QScriptProgram::operator==): (QScriptProgram::operator!=):
  • qt/api/qscriptprogram.h: Added.
  • qt/api/qscriptprogram_p.h: Added. (QScriptProgramPrivate::get): (QScriptProgramPrivate::QScriptProgramPrivate): (QScriptProgramPrivate::~QScriptProgramPrivate): (QScriptProgramPrivate::isNull): (QScriptProgramPrivate::sourceCode): (QScriptProgramPrivate::fileName): (QScriptProgramPrivate::firstLineNumber): (QScriptProgramPrivate::operator==): (QScriptProgramPrivate::operator!=): (QScriptProgramPrivate::program): (QScriptProgramPrivate::file): (QScriptProgramPrivate::line):
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::evaluateProgram):
15:19 Changeset [56319] by ddkilzer@apple.com
  • 5 edits
    2 adds in trunk

<http://webkit.org/b/14858> <col> width ignored when not tied to a single cell

Patch by Dmitry Gorbik <socket.h@gmail.com> on 2010-03-21
Reviewed by David Kilzer.

Fixed width calculation for cells with span when <col> is defined.

WebCore:

Test: fast/table/col-width-span-expand.html

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColWidth): Added the calculation of cell width
in case of <col> defined and span > 1.

LayoutTests:

  • fast/table/col-width-span-expand-expected.txt: Added.
  • fast/table/col-width-span-expand.html: Added.
13:08 Changeset [56318] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

Blind attempt #2 to fix the Windows build after r56314

  • API/tests/testapi.c: Include JSObjectRefPrivate.h for the new

methods instead of declaring them locally (and non-extern).

Backed out previous change.

12:56 Changeset [56317] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

Blind attempt to fix the Windows build after r56314

Try to fix the following errors on the Windows buildbot:

Linking...
testapi.obj : error LNK2001: unresolved external symbol "bool cdecl JSObjectSetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *,struct OpaqueJSValue const *)" (?JSObjectSetPrivateProperty@@YA_NPBUOpaqueJSContext@@PAUOpaqueJSValue@@PAUOpaqueJSString@@PBU2@@Z)
testapi.obj : error LNK2001: unresolved external symbol "struct OpaqueJSValue const *
cdecl JSObjectGetPrivateProperty(struct OpaqueJSContext const *,struct OpaqueJSValue *,struct OpaqueJSString *)" (?JSObjectGetPrivateProperty@@YAPBUOpaqueJSValue@@PBUOpaqueJSContext@@PAU1@PAUOpaqueJSString@@@Z)
C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\bin\testapi.exe : fatal error LNK1120: 2 unresolved externals

missing symbols to be exported.

12:09 Changeset [56316] by mrobinson@webkit.org
  • 4 edits in trunk

2010-03-20 Martin Robinson <mrobinson@webkit.org>

Reviewed by Xan Lopez

[GTK] eventSender.zoomPageOut() bug?
https://bugs.webkit.org/show_bug.cgi?id=30575

Unskip some tests that were failing because of the bug in DRT.

  • platform/gtk/Skipped:

2010-03-20 Martin Robinson <mrobinson@webkit.org>

Reviewed by Xan Lopez.

[GTK] eventSender.zoomPageOut() bug?
https://bugs.webkit.org/show_bug.cgi?id=30575

Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using.

  • DumpRenderTree/gtk/EventSender.cpp: (zoomIn): Added. (zoomOut): Added. (textZoomInCallback): Use zoomIn helper function. (textZoomOutCallback): Use zoomOut helper function. (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor. (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor.
05:22 QtWebKitPlugins edited by yael.aharon@nokia.com
(diff)
01:35 Changeset [56315] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Documentation fix for previous patch.

Reviewed by Maciej Stachowiak.

  • API/JSObjectRefPrivate.h:
00:40 Changeset [56314] by oliver@apple.com
  • 6 edits
    1 add in trunk/JavaScriptCore

2010-03-20 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

JSC needs an API to allow custom objects to have aprivate GC-accessible properties
https://bugs.webkit.org/show_bug.cgi?id=36420

Add new API methods to support "private" properties on custom
objects.

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::JSCallbackObjectData): (JSC::JSCallbackObjectData::~JSCallbackObjectData): (JSC::JSCallbackObjectData::getPrivateProperty): (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::deletePrivateProperty): (JSC::JSCallbackObjectData::markChildren): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::deletePrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::getPrivateProperty): (JSC::JSCallbackObject::setPrivateProperty): (JSC::JSCallbackObject::deletePrivateProperty): (JSC::JSCallbackObject::markChildren):
  • API/JSObjectRef.cpp: (JSObjectGetPrivateProperty): (JSObjectSetPrivateProperty): (JSObjectDeletePrivateProperty):
  • API/JSObjectRefPrivate.h: Added.
  • API/tests/testapi.c: (main):
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:

03/20/10:

19:45 Changeset [56313] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after recent database API change.

17:39 Changeset [56312] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-20 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

Renamed UnitTestLogStream to TestLogStream in webkitpy.

https://bugs.webkit.org/show_bug.cgi?id=36099

TestLogStream is more concise and more consistent with the name of
the module (logtesting rather than logunittesting) and its main
class (LogTesting rather than LogUnitTesting).

  • Scripts/webkitpy/init/logtesting.py:
    • Renamings.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Renamings.
  • Scripts/webkitpy/style_references.py:
    • Renamings.
15:20 Changeset [56311] by tonikitoo@webkit.org
  • 3 edits in trunk/WebCore

Spatial Navigation: Code simplification in FocusController.cpp and SpatialNavigation.cpp (part I)
https://bugs.webkit.org/show_bug.cgi?id=36168

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Make use of isNull and document methods introduced in FocusCandidate class by patch in bug 36167.
No functionalty change.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

  • page/SpatialNavigation.cpp:

(WebCore::distanceInDirection):

14:00 Changeset [56310] by dpranke@chromium.org
  • 1 edit in trunk/WebKitTools/ChangeLog

2010-03-20 Dirk Pranke <dpranke@chromium.org>

Unreviewed change.

Fix typo in Changelog.

  • WebKitTools/ChangeLog:
13:05 Changeset [56309] by kevino@webkit.org
  • 15 edits in trunk

[wx] Build fixes after recent changes.

12:21 Changeset [56308] by dglazkov@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed, expectations tweak.

Remove expectations for chromium-mac editing/style/apply-through-end-of-document.html as it
now matches platform/mac.

  • platform/chromium-mac/editing/style/apply-through-end-of-document-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Adjusted expectations.
12:10 Changeset [56307] by dglazkov@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, tool fix.

Remove vestiges of downstream directory names to unbreak rebaselining tool.

  • Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo.
10:21 Changeset [56306] by dglazkov@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Re-enable the downstream test_expectations overrides file that was
disabled in bug 36396 / r56287.

https://bugs.chromium.org/show_bug.cgi?id=36401

  • Scripts/webkitpy/layout_tests/port/chromium.py:
10:14 Changeset [56305] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations tweak.

Mark editing/style/apply-through-end-of-document.html as failing

  • platform/chromium/test_expectations.txt:
09:56 Changeset [56304] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations tweak.

Marked svg/filters/filterRes.svg as failing after
http://trac.webkit.org/changeset/56288/

  • platform/chromium/test_expectations.txt: Added expectations for svg/filters/filterRes.svg.
09:31 Changeset [56303] by dglazkov@chromium.org
  • 4 edits
    4 deletes in trunk/WebKit/chromium

2010-03-20 Dimitri Glazkov <dglazkov@chromium.org>

No review, rolling out r56294.
http://trac.webkit.org/changeset/56294
https://bugs.webkit.org/show_bug.cgi?id=36262

Broke compile on Chromium canaries.

  • WebKit.gyp:
  • public/WebGraphicsContext3D.h: Removed.
  • public/WebKitClient.h:
  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::): (WebCore::GraphicsContext3DInternal::GLConnection::chooseFBConfig): (WebCore::GraphicsContext3DInternal::GLConnection::createNewContext): (WebCore::GraphicsContext3DInternal::GLConnection::createPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::destroyPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::makeCurrent): (WebCore::GraphicsContext3DInternal::GLConnection::destroyContext): (WebCore::GraphicsContext3DInternal::GLConnection::getCurrentContext): (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::create): (WebCore::GraphicsContext3DInternal::GLConnection::~GLConnection): (WebCore::GraphicsContext3DInternal::VertexAttribPointerState::VertexAttribPointerState): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::createTextureObject): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::flipVertically): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::activeTexture): (WebCore::GraphicsContext3DInternal::bindBuffer): (WebCore::GraphicsContext3DInternal::bindFramebuffer): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferDataImpl): (WebCore::GraphicsContext3DInternal::disableVertexAttribArray): (WebCore::GraphicsContext3DInternal::enableVertexAttribArray): (WebCore::GraphicsContext3DInternal::getError): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::vertexAttribPointer): (WebCore::GraphicsContext3DInternal::viewportImpl): (WebCore::GraphicsContext3DInternal::synthesizeGLError): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::endPaint): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getContextAttributes): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::synthesizeGLError): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport):
  • src/WebGraphicsContext3D.cpp: Removed.
  • src/WebGraphicsContext3DDefaultImpl.cpp: Removed.
  • src/WebGraphicsContext3DDefaultImpl.h: Removed.
02:07 Changeset [56302] by mjs@apple.com
  • 4 edits in trunk/WebKitSite

2010-03-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

WebKit blog should be valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=36410

  • blog/wp-content/themes/webkit/comments-popup.php:
  • blog/wp-content/themes/webkit/footer.php:
  • blog/wp-content/themes/webkit/header.php:
02:04 Changeset [56301] by joepeck@webkit.org
  • 3 edits in trunk/WebCore

2010-03-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Assertion failure in media/video-controls-with-mutation-event-handler.html
https://bugs.webkit.org/show_bug.cgi?id=36376

Test: media/video-controls-with-mutation-event-handler.html

Break early (when not attached) in the defaultEventHandler before the
slider is completely set up.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler): (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):
01:12 Changeset [56300] by mjs@apple.com
  • 24 edits in trunk/WebKitSite

2010-03-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

Fix a bunch of HTML5 validation errors on various pages.
https://bugs.webkit.org/show_bug.cgi?id=36409

  • building/build.html:
  • building/checkout.html:
  • building/debug.html:
  • building/run.html:
  • building/tools.html:
  • coding/coding-style.html:
  • coding/contributing.html:
  • coding/major-objects.html:
  • css/main.css: (.asciiart):
  • demos/index.html:
  • header.inc:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/goals.html:
  • projects/index.html:
  • projects/mathml/index.html:
  • quality/bugpriorities.html:
  • quality/bugwriting.html:
  • quality/crashlogs.html:
  • quality/lifecycle.html:
  • quality/testing.html:
  • quality/testwriting.html:
00:24 Changeset [56299] by mjs@apple.com
  • 6 edits in trunk/WebKitSite

2010-03-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

webkit.org should use the HTML5 doctype
https://bugs.webkit.org/show_bug.cgi?id=36407

  • header.inc:
  • misc/drosera/index.html:
  • perf/slickspeed/system/index.php:
  • perf/slickspeed/system/template.php:
  • specs/index.html:

03/19/10:

23:42 Changeset [56298] by mjs@apple.com
  • 2 edits in trunk/WebKitSite

2010-03-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

http://webkit.org/ has an HTML5 validation error
https://bugs.webkit.org/show_bug.cgi?id=36406

  • nav.inc:
22:29 Changeset [56297] by hamaji@chromium.org
  • 3 edits
    2 adds in trunk

2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c)
https://bugs.webkit.org/show_bug.cgi?id=34641

  • fast/css/first-letter-block-form-controls-crash-expected.txt: Added.
  • fast/css/first-letter-block-form-controls-crash.html: Added.

2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Dan Bernstein.

WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c)
https://bugs.webkit.org/show_bug.cgi?id=34641

Don't dig into buttons and menu lists when finding which element
should be modified by :first-letter pseudo class. Even before
this change, we didn't dig into inline buttons and menu lists as
they are replaced so this issue wasn't found long time.

Test: fast/css/first-letter-block-form-controls-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
21:29 Changeset [56296] by mrowe@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Land a test result that should have been added along with the test in r56286.

  • transitions/transition-end-event-destroy-iframe-expected.txt: Copied from LayoutTests/transitions/transition-end-event-destroy-renderer-expected.txt.
20:55 Changeset [56295] by eric@webkit.org
  • 11 edits
    2 copies
    2 adds in trunk

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Change XSSAuditor block syntax
https://bugs.webkit.org/show_bug.cgi?id=34436

Update tests to account for the new blocking syntax. Added test for
disabling the XSS filter.

  • http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header.html:
  • http/tests/security/xssAuditor/no-protection-script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/no-protection-script-tag.html: Added.
  • http/tests/security/xssAuditor/resources/echo-head-base-href.pl:
  • http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl:
  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt: Added.
  • http/tests/security/xssAuditor/xss-protection-parsing-01.html: Added.

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Change XSSAuditor block syntax
https://bugs.webkit.org/show_bug.cgi?id=34436

Update our blocking syntax to something more reasonable. Also,
implemented a way for a web site to disable the filter.

Tests: http/tests/security/xssAuditor/no-protection-script-tag.html

http/tests/security/xssAuditor/xss-protection-parsing-01.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::xssProtection): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h:
  • platform/network/HTTPParsers.cpp: (WebCore::skipToken): (WebCore::parseXSSProtectionHeader):
  • platform/network/HTTPParsers.h: (WebCore::):
20:35 Changeset [56294] by eric@webkit.org
  • 4 edits
    4 adds in trunk/WebKit/chromium

2010-03-19 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add GraphicsContext3D abstraction to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36262

Added WebGraphicsContext3D to the WebKit API and refactored Chromium's
GraphicsContext3D implementation to use it. All of the OpenGL calls have
been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the
WebGraphicsContext3D implementation. GraphicsContext3D is still
responsible for the transfer of rendered output from the
WebGraphicsContext3D to the HTMLCanvasElement.

The GraphicsContext3DInternal class, which is a data member of
GraphicsContext3D for the Chromium port, remains. It is possible to
eliminate this class and thereby one level of delegation, but this is
being deferred.

The needed entry point for a Chrome implementation of
WebGraphicsContext3D has been added to WebKitClient, but it is not being
called yet by GraphicsContext3D. It will be once this patch lands and
Chromium is rolled forward to support this entry point.

This is a large patch, but the transformation is almost entirely
mechanical and there is no change in functionality. Nearly all of
GraphicsContext3D and GraphicsContext3DInternal has been moved to
WebGraphicsContext3DDefaultImpl. The only area where the splitting of
logic is less than mechanical is GraphicsContext3D::beginPaint() and its
callees.

Ran all WebGL layout tests and demos from Khronos site in Chromium.

  • WebKit.gyp:
  • public/WebGraphicsContext3D.h: Added. (WebKit::WebGraphicsContext3D::Attributes::Attributes): (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D):
  • public/WebKitClient.h: (WebKit::WebKitClient::createGraphicsContext3D):
  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::endPaint): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::readPixels): (WebCore::GraphicsContext3DInternal::shaderSource): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):
  • src/WebGraphicsContext3D.cpp: Added. (WebKit::WebGraphicsContext3D::createDefault):
  • src/WebGraphicsContext3DDefaultImpl.cpp: Added. (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection): (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState): (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::width): (WebKit::WebGraphicsContext3DDefaultImpl::height): (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes): (WebKit::createTextureObject): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture): (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::drawElements): (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::getError): (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::getString): (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createProgram): (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createTexture): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram): (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture): (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError):
  • src/WebGraphicsContext3DDefaultImpl.h: Added. (WebKit::WebGraphicsContext3DDefaultImpl::): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection):
20:03 Changeset [56293] by eric@webkit.org
  • 13 edits in trunk/WebCore

2010-03-19 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dmitry Titov.

Refactor DatabaseTracker.cpp for thread safety
https://bugs.webkit.org/show_bug.cgi?id=34991

This enables calling into DatabaseTracker from multiple context threads,
as will happen once Workers can access the Database. It required a fair
amount of reshuffling of locks. I ended up splitting the public
interface [calls that take locks and call private functions] from the
implementations [calls that assert that locks are already held] in order
to avoid lock conflicts. I also had to make sure we weren't sharing
Strings or SecurityOrigins across threads.

No new tests.

Allow access to database handles from multiple threads IFF SQLite is new enough and the user requests it.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::disableThreadingChecks):
  • platform/sql/SQLiteDatabase.h: (WebCore::SQLiteDatabase::sqlite3Handle): (WebCore::SQLiteDatabase::disableThreadingChecks):

Remove an asynchronous call from Database::close back to the execution thread, so that cleanup can be more deterministic.

  • storage/Database.cpp: (WebCore::Database::markAsDeletedAndClose): (WebCore::Database::close):
  • storage/Database.h: (WebCore::Database::):
  • storage/DatabaseDetails.h: (WebCore::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::thread):
  • storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::doPerformTask):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread):

Any Strings that get stored in DatabaseTracker, and any Strings returned from DatabaseTracker, are now threadsafeCopies.
Public functions now take all needed locks, then generally call only private functions [there are a few exceptions: deletion functions and origins()].
Private functions no longer take locks.
m_quotaMapGuard becomes m_databaseGuard, and now protects m_database, m_quotaMap, m_proposedDatabases, m_databaseDirectoryPath, m_originsBeingDeleted, m_beingCreated, and m_beingDeleted.
m_proposedDatabases replaces m_proposedDatabase, to account for reentrancy.

  • storage/DatabaseTracker.h:
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originQuotaManagerNoLock): (WebCore::DatabaseTracker::originQuotaManager): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::setDatabaseDirectoryPath): (WebCore::DatabaseTracker::databaseDirectoryPath): (WebCore::DatabaseTracker::trackerDatabasePath): (WebCore::DatabaseTracker::openTrackerDatabase): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOriginNoLock): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::hasEntryForDatabase): (WebCore::DatabaseTracker::originPath): (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOriginNoLock): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::detailsForNameAndOrigin): (WebCore::DatabaseTracker::setDatabaseDetails): (WebCore::DatabaseTracker::usageForDatabase): (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::usageForOriginNoLock): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOriginNoLock): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile): (WebCore::DatabaseTracker::setClient): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): (WebCore::DatabaseTracker::notifyDatabasesChanged):

These functions keep track of in-progress deletions and creations, so that we can make sure nobody every deletes a database file while a live database is using it.
(WebCore::DatabaseTracker::canCreateDatabase):
(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::creatingDatabase):
(WebCore::DatabaseTracker::canDeleteDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::doneDeletingDatabase):
(WebCore::DatabaseTracker::deletingDatabase):
(WebCore::DatabaseTracker::canDeleteOrigin):
(WebCore::DatabaseTracker::deletingOrigin):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::doneDeletingOrigin):

Any SecurityOrigins stored in OriginQuotaManager are now threadsafeCopies of inputs. There's a new tryLock() function in addition to the existing lock().

  • storage/OriginQuotaManager.cpp: (WebCore::OriginQuotaManager::tryLock): (WebCore::OriginQuotaManager::trackOrigin):
  • storage/OriginQuotaManager.h:
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::databaseIdentifier): Removed DEFINE_STATIC_LOCAL wrapper on a local variable; it appears to have been a small optimization, but it's not thread-safe.
19:35 Changeset [56292] by eric@webkit.org
  • 6 edits
    2 adds in trunk/WebCore

2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

Multiselect popups - rendering
https://bugs.webkit.org/show_bug.cgi?id=36006

The objective of this patch is to create a compile time flag that can be used
to force all <select> elements to be rendered as menu lists.

Theme stylesheet mechanism has been used to change the appearance of the elements.

Class QtStyleOptionWebComboBox has been introduced to provide to QStyle objects
the needed information to render <select multiple> comboboxes.

  • WebCore.pri:
  • WebCore.pro:
  • css/themeQtNoListboxes.css: Added. (select[size][multiple]):
  • dom/SelectElement.h: (WebCore::SelectElementData::usesMenuList):
  • platform/qt/QtStyleOptionWebComboBox.h: Added. (WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox): (WebCore::QtStyleOptionWebComboBox::multiple): (WebCore::QtStyleOptionWebComboBox::checkMultiple):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton):
  • platform/qt/RenderThemeQt.h:
18:58 Changeset [56291] by eric@webkit.org
  • 25 edits in trunk

2010-03-19 Zhenyao Mo <zmo@google.com>

Reviewed by Oliver Hunt.

Update WebGLArray.slice() to new spec
https://bugs.webkit.org/show_bug.cgi?id-35612

  • fast/canvas/webgl/array-unit-tests-expected.txt: Changed tests to reflect the new slice parameters; add new test cases for default inputs for slice.
  • fast/canvas/webgl/array-unit-tests.html: Ditto.
  • fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt: Changed tests to reflect the new slice parameters.
  • fast/canvas/webgl/webgl-array-invalid-ranges.html: Ditto.

2010-03-19 Zhenyao Mo <zmo@google.com>

Reviewed by Oliver Hunt.

Update WebGLArray.slice() to new spec
https://bugs.webkit.org/show_bug.cgi?id-35612

  • bindings/js/JSWebGLArrayCustom.cpp: Adding support for default inputs. (WebCore::JSWebGLArray::slice):
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Ditto. (WebCore::V8WebGLArray::sliceCallback):
  • html/canvas/WebGLArray.cpp: Map start/end to offset/length. (WebCore::WebGLArray::calculateOffsetAndLength):
  • html/canvas/WebGLArray.h: Modified slice parameters.
  • html/canvas/WebGLArray.idl: Define custom binding for slice().
  • html/canvas/WebGLByteArray.cpp: Modified slice parameters. (WebCore::WebGLByteArray::slice):
  • html/canvas/WebGLByteArray.h: Ditto.
  • html/canvas/WebGLFloatArray.cpp: Ditto. (WebCore::WebGLFloatArray::slice):
  • html/canvas/WebGLFloatArray.h: Ditto.
  • html/canvas/WebGLIntArray.cpp: Ditto. (WebCore::WebGLIntArray::slice):
  • html/canvas/WebGLIntArray.h: Ditto.
  • html/canvas/WebGLShortArray.cpp: Ditto. (WebCore::WebGLShortArray::slice):
  • html/canvas/WebGLShortArray.h: Ditto.
  • html/canvas/WebGLUnsignedByteArray.cpp: Ditto. (WebCore::WebGLUnsignedByteArray::slice):
  • html/canvas/WebGLUnsignedByteArray.h: Ditto.
  • html/canvas/WebGLUnsignedIntArray.cpp: Ditto. (WebCore::WebGLUnsignedIntArray::slice):
  • html/canvas/WebGLUnsignedIntArray.h: Ditto.
  • html/canvas/WebGLUnsignedShortArray.cpp: Ditto. (WebCore::WebGLUnsignedShortArray::slice):
  • html/canvas/WebGLUnsignedShortArray.h: Ditto.
18:39 Changeset [56290] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Freeze sandbox attributes on creation
https://bugs.webkit.org/show_bug.cgi?id=34184

Test that allow-forms is frozen on document creation.

  • fast/frames/resources/sandboxed-iframe-form-dynamic-allowed.html: Added.
  • fast/frames/resources/sandboxed-iframe-form-dynamic-disallowed.html: Added.
  • fast/frames/sandboxed-iframe-forms-dynamic-expected.txt: Added.
  • fast/frames/sandboxed-iframe-forms-dynamic.html: Added.
18:20 Changeset [56289] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-03-19 Yong Li <yong.li@torchmobile.com> and Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Ensure the segments inside SharedBuffer are merged before constructing
a CFData with it.

https://bugs.webkit.org/show_bug.cgi?id=50843

  • manual-tests/WebKitSite.webarchive: Added.
  • manual-tests/webarchive-test.html: Added.
  • platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::createCFData):
17:45 Changeset [56288] by oliver@apple.com
  • 4 edits
    2 adds in trunk

2010-03-19 Justin Schuh <jschuh@chromium.org>

Reviewed by Oliver Hunt.

Security: ReadAV@NULL for negative feMorphology filter radius
https://bugs.webkit.org/show_bug.cgi?id=34566

Prevents building the filter if either radius is negative.
Catches negative radii resulting from conversions.

Test: svg/filters/feMorphology-invalid-radius.svg

  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
17:41 Changeset [56287] by dpranke@chromium.org
  • 5 edits in trunk/WebKitTools

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Disable the downstream override expectations temporarily to allow
us to test that we've upstreamed everything correctly. Also, stop
looking at the downstream baselines at all (now you will only be
able to update baselines upstream). In theory this should work, but
if we need to we can always add the downstream dirs back in.

https://bugs.webkit.org/show_bug.cgi?id=36396

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
17:28 Changeset [56286] by cmarrin@apple.com
  • 3 edits
    2 adds in trunk

Fixed a crash with AnimationController getting deleted out from under itself.


It's possible for the Frame that owns an AnimationController to get deleted
in the EndTransitionEvent (or other animation events) to get deleted in the
event handler. Normally this case is protected against by preventing the Frame
from getting deleted until the end of the runloop. But native uses of the
WebView can subvert this protection. So I added a protector to the
animation event dispatcher to protect it in those cases.

17:08 Changeset [56285] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

Multiselect Popup - PopupMenuClient extension
https://bugs.webkit.org/show_bug.cgi?id=36178

PopupMenuClient class is the interface used by combobox popup implementations.
It needs to be extended to handle <select multiple> needs.

A new interface named ListPopupMenuClient that inherits from PopupMenuClient was created.
The use of this new class instead of adding methods to PopupMenuClient avoids changes
in other non related implementations of PopupMenuClient.

RenderMenuList has changed to inherit ListPopupMenuClient instead of PopupMenuClient
and to have the new methods implemented.

  • platform/PopupMenuClient.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listBoxSelectItem): (WebCore::RenderMenuList::multiple):
  • rendering/RenderMenuList.h:
16:42 Changeset [56284] by simon.fraser@apple.com
  • 4 edits
    2 adds in trunk

2010-03-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=36387
REGRESSION: Can "uncheck" radio buttons by clicking on them

My change in r56174 caused radio buttons and checkboxes to go down the same code path by virtue
of allowsIndeterminate(), but this broke save/restore behavior on radio buttons.

Fix by saving and restoring both the intermediate and checked state for radio buttons
and checkboxes, as well as the "current radio button" state.

Test: fast/forms/radio-checkbox-restore-indeterminate.html

  • html/HTMLInputElement.cpp: (WebCore::EventHandlingState::EventHandlingState): New struct to hold state between preDispatchEventHandler() and postDispatchEventHandler(). (WebCore::HTMLInputElement::preDispatchEventHandler): Store intermedate and checked state and the current radio button. (WebCore::HTMLInputElement::postDispatchEventHandler): Restore state as appropriate.
  • html/HTMLInputElement.h: Add a comment to clarify how 'intermediate' interacts with 'checked', according to the spec.
16:38 Changeset [56283] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

fix typo in chromium test expectations overrides routine
https://bugs.webkit.org/show_bug.cgi?id=36397

  • Scripts/webkitpy/layout_tests/port/chromium.py:
16:09 Changeset [56282] by darin@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-19 Darin Fisher <darin@chromium.org>

Temporarily suppress fast/loader/frame-src-change-added-to-history.html
for Tiger to make the bot green.

https://bugs.webkit.org/show_bug.cgi?id=36382

  • platform/mac-tiger/Skipped:
16:06 Changeset [56281] by dpranke@chromium.org
  • 1 add in trunk/LayoutTests/platform/chromium/test_expectations.txt

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed change.

Add in missing test_expectations.txt file that didn't actually
make it into the commit.

https://bugs.webkit.org/show_bug.cgi?id=36326

  • LayoutTests/platform/chromium/test_expectations.txt
16:05 Changeset [56280] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-19 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: caret moves past prompt in javascript console
https://bugs.webkit.org/show_bug.cgi?id=26602

Having noticed any Element children besides a leading <br> (which are empty
text nodes), WebCore editing facility thinks it should delete the <br>,
thus clearing away the text prompt contents.

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.clearAutoComplete): (WebInspector.TextPrompt.prototype._completionsReady):
  • inspector/front-end/utilities.js: (Element.prototype.pruneEmptyTextNodes):
16:02 Changeset [56279] by dpranke@chromium.org
  • 3 edits in trunk

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Flip the Chromium ports to look first for the test expectations
in LayoutTests/platform/chromium and only afterwards look in the
Chromium repo downstream for overrides.

https://bugs.webkit.org/show_bug.cgi?id=36326

  • WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:
  • LayoutTests/platform/chromium/test_expectations.txt
15:52 Changeset [56278] by dpranke@chromium.org
  • 1 edit
    2371 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.
Land remaining chromium-linux LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

15:43 Changeset [56277] by dpranke@chromium.org
  • 1 edit
    1491 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/fast/{block,css,forms,text} LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-linux/fast/block : Added.
  • platform/chromium-linux/fast/css : Added.
  • platform/chromium-linux/fast/forms : Added.
  • platform/chromium-linux/fast/text : Added.
15:35 Changeset [56276] by dpranke@chromium.org
  • 1 edit
    1453 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/editing LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-linux/editing : Added.
15:33 Changeset [56275] by jhawkins@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-19 James Hawkins <jhawkins@chromium.org>

Unreviewed.

Add myself to the committers list.

  • Scripts/webkitpy/committers.py:
15:29 Changeset [56274] by dpranke@chromium.org
  • 1 edit
    1893 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/tables LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-linux/tables : Added.
15:18 Changeset [56273] by dpranke@chromium.org
  • 1 edit
    1251 adds in trunk/LayoutTests

010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/svg LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-linux/svg : Added.
15:09 Changeset [56272] by dpranke@chromium.org
  • 1 edit
    1244 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-linux/css* LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-linux/css* : Added.
15:00 Changeset [56271] by dpranke@chromium.org
  • 1 edit
    2661 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land remaining chromium-win/* LayoutTest baselines
(file list omitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/* : Added.
14:50 Changeset [56270] by dpranke@chromium.org
  • 1 edit
    1811 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-win/css* LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/css* : Added.
14:38 Changeset [56269] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Back-forward list dumping is incorrect
https://bugs.webkit.org/show_bug.cgi?id=36392

  • platform/qt/Skipped: fast/loader/frame-src-change-added-to-history.html skipped until fix.
14:34 Changeset [56268] by dpranke@chromium.org
  • 1 edit
    2436 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-win/fast/[l-z]* LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/fast/[l-z]* : Added.
14:24 Changeset [56267] by dpranke@chromium.org
  • 1 edit
    2380 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land chromium-win/fast/{a,c,d,e,f,g,h,i,j}* LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/fast/{a,c,d,e,f,g,h,i,j}* : Added.
14:14 Changeset [56266] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-19 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

r56188 removed lastPosition from the Geolocation code, but the the
geolocation window properties wasn't updated to reflect this. It's
only failing on the GTK+ port, since the other ports have it on
their Skipped list.

  • fast/dom/Window/window-properties-geolocation-expected.txt:
14:11 Changeset [56265] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
https://bugs.webkit.org/show_bug.cgi?id=36386

  • platform/qt/Skipped: fast/media/print-restores-previous-mediatype.html skipped until fix.
14:04 Changeset [56264] by dpranke@chromium.org
  • 1 edit
    1216 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the first part of chromium-win/fast LayoutTest baselines
(file list ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/fast: Added.
14:01 Changeset [56263] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix SheriffBot exception lock when we can't retrieve the first build
from buildbot. (I'll ask Eric to review this change after the fact,
but he's at lunch and I want to get the bot unlocked.)

  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/buildbot_unittest.py:
13:48 QtWebKitJournal edited by hausmann@webkit.org
(diff)
13:21 Changeset [56262] by ap@apple.com
  • 6 edits in trunk/WebKitTools

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36380
websocket/tests/frame-lengths.html times out on Tiger bot

https://bugs.webkit.org/show_bug.cgi?id=35041
websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot

Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary -
sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid
timing out than to detect it early.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::waitUntilDone):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • Scripts/run-webkit-tests:
13:20 Changeset [56261] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-19 Xan Lopez <xlopez@igalia.com>

Unreviewed, land new expected result for test.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
13:15 Changeset [56260] by laszlo.1.gombos@nokia.com
  • 4 edits in trunk

2010-03-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

Buildfix for Qt v4.5.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewOverlay::q):

2010-03-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed.

Buildfix for Qt v4.5.

  • QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::applyZoom):
13:10 Changeset [56259] by dpranke@chromium.org
  • 1 edit
    2855 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win/tables LayoutTest baselines (file list
ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/tables: Added.
13:09 Changeset [56258] by dglazkov@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed, build fix.

Rename enqueueStorageEvent to enqueueEvent to match changes in
http://trac.webkit.org/changeset/56249.

  • src/StorageAreaProxy.cpp:

(WebCore::StorageAreaProxy::storageEvent): Renamed.

13:05 Changeset [56257] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Operational tweaks to SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=36385

These changes aren't pretty, but they're helpful to make SheriffBot
work operationally. I plan to iterate in these areas, but I wanted to
get this patch landed so I could be running the bot against TOT.

  • Scripts/webkitpy/commands/sheriffbot.py:
  • Scripts/webkitpy/irc/ircbot.py:
  • Scripts/webkitpy/thirdparty/autoinstalled/init.py:
13:01 Changeset [56256] by aroben@apple.com
  • 3 edits in trunk/WebCore

Windows clean build fix after r56192

  • WebCore.vcproj/WebCore.vcproj: Copy headers from

platform/graphics/cg to $WebKitOutputDir as part of the post-build
event so that WebKit can use them. (The only one we currently require
is FontPlatformData.h.)

  • platform/graphics/win/FontPlatformDataCGWin.cpp: Touched to force a

build.

12:56 Changeset [56255] by dpranke@chromium.org
  • 2149 adds in trunk/LayoutTests/platform/chromium-win

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win/svg LayoutTest baselines (file list
ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win/svg: Added.
12:54 Changeset [56254] by beidson@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Rubberstamped by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=35594

  • fast/loader/api-test-new-window-data-load-base-url.html: Removed.
  • fast/loader/api-test-new-window-data-load-base-url.html-disabled: Copied from fast/loader/api-test-new-window-data-load-base-url.html.
12:41 Changeset [56253] by dpranke@chromium.org
  • 1 edit
    103 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win-vista LayoutTest baselines (file list
ommitted due to length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win-vista: Added.
12:40 Changeset [56252] by dpranke@chromium.org
  • 1 edit
    141 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-win-xp LayoutTest baselines (file list ommitted due to
length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-win-xp: Added.
12:38 Changeset [56251] by dpranke@chromium.org
  • 1 edit
    831 adds in trunk/LayoutTests

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Land the chromium-mac LayoutTest baselines (file list ommitted due to
length).

https://bugs.webkit.org/show_bug.cgi?id=28397

  • platform/chromium-mac: Added.
11:37 Changeset [56250] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-03-19 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Assertion failure in media/video-controls-with-mutation-event-handler.html
https://bugs.webkit.org/show_bug.cgi?id=36376

Fix crashing test. Underlying the media element's volume slider is a
range input, which sanitizes values before expected on the media control.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider):
11:25 Changeset [56249] by beidson@apple.com
  • 6 edits in trunk/WebCore

3 of the new HTML5 loading events need to be asynchronous.

Reviewed by Darin Adler.

Laying the groundwork for:
https://bugs.webkit.org/show_bug.cgi?id=36201
https://bugs.webkit.org/show_bug.cgi?id=36202
https://bugs.webkit.org/show_bug.cgi?id=36334
https://bugs.webkit.org/show_bug.cgi?id=36335

Document already had an asynchronous event delivery mechanism for storage events, so
we can repurpose that for all async events.

No new tests. (No change in behavior)

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::implicitClose): Use Document::schedule* for the related events.
(WebCore::Document::enqueueEvent): Renamed from enqueueStorageEvent
(WebCore::Document::pendingEventTimerFired): Renamed from "storageEventTimerFired"
(WebCore::Document::statePopped): Use Document::schedulePopstateEvent
(WebCore::Document::enqueuePageshowEvent): All Pageshow events are piped through here.

This will be made asynchronous in a separate patch.

(WebCore::Document::enqueueHashchangeEvent): All Hashchange events are piped through here.

This will be made asynchronous in a separate patch.

(WebCore::Document::enqueuePopstateEvent): All Popstate events are piped through here.

This will be made asynchronous in a separate patch.

  • dom/Document.h:

(WebCore::):

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Use Document::enqueuePageshowEvent

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument): Use Document::enqueueHashchangeEvent

  • storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatch): Use Document::enqueueEvent

11:23 Changeset [56248] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Help sheriff-bot avoid warning about flaky tests (and add more unit testing)
https://bugs.webkit.org/show_bug.cgi?id=36354

  • Scripts/webkitpy/buildbot.py:
    • Make Build creation easier to Mock and test
  • Scripts/webkitpy/buildbot_unittest.py:
    • Test finding green to red transitions and suspect revisions
  • Scripts/webkitpy/commands/queries.py:
    • Make what-broke note when builders have only failed once.
11:19 Changeset [56247] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36337
Log an error when an OOP plug-in sends an unknown object id

Making these LOG_ERROR and not ASSERTs, because I don't want early returns to look
temporary or redundant.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::getProperty): (WebKit::NetscapePluginInstanceProxy::setProperty): (WebKit::NetscapePluginInstanceProxy::removeProperty): (WebKit::NetscapePluginInstanceProxy::hasProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::enumerate):
11:16 Changeset [56246] by kdecker@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler and Brady Eidson.

First step toward:
https://bugs.webkit.org/show_bug.cgi?id=36328

This is the first step torward eliminating the WebKit WebNullPluginView class. The responsibility for this will soon
be in platform-independent code in WebCore. The plan is to change RenderEmbeddedObject and give it the capability of
drawing the missing plug-in text.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): Renamed the renderer parameter to requestEmbeddedObject and made it a RenderEmbeddedObject. (WebCore::FrameLoader::loadPlugin): Likewise.
  • loader/FrameLoader.h: Updated loadPlugin() and requestObject() method signatures accordingly.
11:01 Changeset [56245] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Fix the rebaselining tool, which was broken by r36324 when I
added the concept of overridding expectations.

https://bugs.webkit.org/show_bug.cgi?id=36374

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
10:30 Changeset [56244] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-19 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] querying the current history item during a back/forward
navigation should not clobber the scroll offset, etc.
https://bugs.webkit.org/show_bug.cgi?id=36347

We should only allow the current history item to be modified if we are
no longer loading or if the load is a new navigation (i.e., not a
back/forward/reload variant).

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::currentHistoryItem):
09:41 Changeset [56243] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Disable TILED_BACKING_STORE if Qt version is earlier than Qt4.6
https://bugs.webkit.org/show_bug.cgi?id=36348

Backing store implementation for QtWebKit requires at least Qt
version 4.6.

No new tests as there is no new functionality.

  • WebCore.pri:
09:16 Changeset [56242] by joepeck@webkit.org
  • 16 edits
    2 adds in trunk

2010-03-19 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259

Setting value attribute on an <input type=range> to an out-of-range value fires oninput
https://bugs.webkit.org/show_bug.cgi?id=16990

Part 2 of 2: When setting the range element's value, overflows and underflows
are automatically sanitized to valid values. Moved the general case
sanitization code out of the Renderer into HTMLInputElement::sanitizeValue.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::value): when getting a default value on reset() ensure the defaultValue is provided (WebCore::HTMLInputElement::sanitizeValue): clamp the value within the max/min/step range constraints
  • html/StepRange.cpp: (WebCore::StepRange::StepRange): allow const element in the constructor (WebCore::StepRange::clampValue): clamp from a String value
  • html/StepRange.h: (WebCore::StepRange::defaultValue): easy calculation of the default value for max/min/step range constraints
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): no longer handle the general case sanitization in the renderer

2010-03-19 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259

Setting value attribute on an <input type=range> to an out-of-range value fires oninput
https://bugs.webkit.org/show_bug.cgi?id=16990

When setting the range element's value, overflows and underflows are
automatically sanitized to valid values. Fixed the behavior and removed
tests that were testing for improper behavior.

  • fast/forms/ValidityState-rangeOverflow-expected.txt:
  • fast/forms/ValidityState-rangeUnderflow-expected.txt:
  • fast/forms/input-stepup-stepdown-expected.txt:
  • fast/forms/script-tests/ValidityState-rangeOverflow.js:
  • fast/forms/script-tests/ValidityState-rangeUnderflow.js:
  • fast/forms/script-tests/input-stepup-stepdown.js:
  • fast/forms/script-tests/validationMessage.js:
  • fast/forms/validationMessage-expected.txt:

Added test verifying that bug 16990 was fixed as well.

  • fast/forms/range-input-dynamic-oninput-expected.txt: Added.
  • fast/forms/range-input-dynamic-oninput.html Added.

Improved test because handling of this case changed.

  • fast/forms/range-reset-expected.txt:
  • fast/forms/range-reset.html:
09:16 Changeset [56241] by joepeck@webkit.org
  • 7 edits
    2 adds in trunk/WebCore

2010-03-19 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

<input type=range> does not validate correctly without a renderer and the tests are incorrect
https://bugs.webkit.org/show_bug.cgi?id=36259

Part 1 of 2: Refactoring the SliderRange struct out of RenderSlider
into a more appropriate place. Changed the named to StepRange. Changed
from a struct to a class.

Added new files to the build.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Renamed and moved class SliderRange to StepRange.

  • html/StepRange.cpp: Added. (WebCore::StepRange::StepRange): (WebCore::StepRange::clampValue): (WebCore::StepRange::valueFromElement): (WebCore::sliderPosition):
  • html/StepRange.h: Added. (WebCore::StepRange::proportionFromValue): (WebCore::StepRange::valueFromProportion):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): updated to use StepRange (WebCore::RenderSlider::setValueForPosition): updated to use StepRange
08:34 QtWebKitJournal edited by hausmann@webkit.org
(diff)
08:33 Changeset [56240] by darin@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-19 Darin Fisher <darin@chromium.org>

Fix expected results for fast/loader/frame-src-change-added-to-history.html

  • fast/loader/frame-src-change-added-to-history-expected.txt:
08:27 Changeset [56239] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36366
Repaint loop when painting using scaled CTMs with different translations

Patch by Antti Koivisto <koivisto@iki.fi> on 2010-03-19
Reviewed by Simon Hausmann.

The code in RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality
tests if the scaling has changed from the previous value by comparing the
transformations. The test fails if the scale is the same but the translation
changes. This can lead to infinite repaint loop if the document is painted
in pieces using different translations (for example for tiling).

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):

08:06 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
08:03 Changeset [56238] by hamaji@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2010-03-19 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Need a layout test for finding yensign from documents with Japanese encodings
https://bugs.webkit.org/show_bug.cgi?id=36288

  • editing/selection/find-yensign-and-backslash-expected.txt: Added.
  • editing/selection/find-yensign-and-backslash.html: Added.
  • platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt: Added.
  • platform/qt/editing/selection/find-yensign-and-backslash-expected.txt: Added.
  • platform/win/editing/selection/find-yensign-and-backslash-expected.txt: Added.
07:10 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:35 Changeset [56237] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2010-03-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: editing shorthands does not always work.

https://bugs.webkit.org/show_bug.cgi?id=36362

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::shorthandValue):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.css: (.section .properties li.disabled .enabled-button):
  • inspector/front-end/inspector.js: (WebInspector.startEditing.editingCommitted):
06:10 Changeset [56236] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Don't replace clip when drawing complex text

Reviewed by Simon Hausmann.

  • platform/graphics/qt/FontQt.cpp:
03:05 Changeset [56235] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Misc bug fixes to make the SheriffBot actually work
https://bugs.webkit.org/show_bug.cgi?id=36355

With these changes, I can actually run the sheriff-bot from start to
finish.

  • Scripts/webkitpy/irc/ircproxy.py:
  • Scripts/webkitpy/patch/patcher.py:
  • Scripts/webkitpy/statusserver.py:
02:51 Changeset [56234] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Actually import the sheriff-bot command so we can run it. Also, move
the bot to #webkit-test so it doesn't cause a ruckus while we test it.

  • Scripts/webkitpy/patch/patcher.py:
  • Scripts/webkitpy/irc/ircbot.py:
02:44 Changeset [56233] by abarth@webkit.org
  • 5 edits
    1 copy in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Second cut at SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=36353

This patch should contain a complete SheriffBot that's capable of
saying reasonable things on IRC. I had to refactor the use of
CommitInfo to make the SheriffBot testable, but I did the minimum
necessary. We should grow webkitcheckout over time to contain the
knowledge of ChangeLogs from scm.

  • Scripts/webkitpy/commands/sheriffbot.py:
  • Scripts/webkitpy/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/patch/patcher.py:
  • Scripts/webkitpy/webkitcheckout.py: Added.
01:44 Changeset [56232] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix Hyatt's IRC nickname.

  • Scripts/webkitpy/committers.py:
01:42 Changeset [56231] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Add IRC nicknames for the non-reviewer committers.

  • Scripts/webkitpy/committers.py:
01:10 Changeset [56230] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Add IRC nicknames for the non-reviewer committers.

  • Scripts/webkitpy/committers.py:
00:59 Changeset [56229] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

More reviewer IRC nicknames.

  • Scripts/webkitpy/committers.py:
00:53 Changeset [56228] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed.

Add a bunch of IRC nicknames for reviewers.

  • Scripts/webkitpy/committers.py:
00:47 Changeset [56227] by zoltan@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-19 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Oliver Hunt.

Added USE_SYSTEM_MALLOC flag to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=21272

Add system-alloc flag to build-webkit. It makes easy to switch
between system allocator and TCmalloc.

  • Scripts/build-webkit:
00:44 Changeset [56226] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Unreviewed "build" fix.

Of course, I caused a regression in the file that isn't tested. :(

  • Scripts/webkitpy/statusserver.py:
00:37 Changeset [56225] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Simplify BuildBot core builder code for easier re-use
https://bugs.webkit.org/show_bug.cgi?id=36350

I simply couldn't see anything through all this Yak-hair.

  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/commands/queries.py:
00:33 Changeset [56224] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

committers.py should know IRC nicknames
https://bugs.webkit.org/show_bug.cgi?id=36349

I'll add the actual nicknames in another patch.

  • Scripts/webkitpy/committers.py:
  • Scripts/webkitpy/committers_unittest.py:
00:31 Changeset [56223] by darin@chromium.org
  • 6 edits
    2 adds in trunk

2010-03-18 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

If a frame is already in the document, then setting its "src" attribute
should add the resultant navigation to history.

https://bugs.webkit.org/show_bug.cgi?id=9166

This behavior is specified in section 4.8.2 of the HTML5 spec.

Test: fast/loader/frame-src-change-added-to-history.html

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::setLocation):
  • html/HTMLFrameElementBase.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame):
  • loader/FrameLoader.h:
00:20 Changeset [56222] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=36318

Patch by Anders Bakken <Anders Bakken <agbakken@gmail.com>> on 2010-03-18
Reviewed by Simon Hausmann.

QtLauncher runs as a GuiClient by default in Qt Embedded which will
make it try to connect to an existing GuiServer. This patch makes it
run like a stand-alone app.

  • QtLauncher/main.cpp:

(LauncherApplication::LauncherApplication):

00:18 Changeset [56221] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Platform specific expected file updated after r56195

  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
00:15 Changeset [56220] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use
https://bugs.webkit.org/show_bug.cgi?id=36345

  • Scripts/webkitpy/buildbot.py:
  • Scripts/webkitpy/commands/queries.py:
00:04 Changeset [56219] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-19 Adam Barth <abarth@webkit.org>

Reviewed by Adam Barth.

Actually pass the IRC password to the IRC object
https://bugs.webkit.org/show_bug.cgi?id=36346

I wanted to do this before, but both patches were in flight. This
patch finally closes the loop and makes the IRCProxy system complete.

  • Scripts/webkitpy/patch/patcher.py:
Note: See TracTimeline for information about the timeline view.