Timeline


and

03/29/10:

23:52 Changeset [56767] by alice.liu@apple.com
  • 2 edits in trunk/JavaScriptCore

add JSObjectRefPrivate.h

Reviewed by NOBODY (build fix).

23:46 BuildingQtOnLinux edited by fboudra@gmail.com
Fix typo (diff)
23:44 Changeset [56766] by levin@chromium.org
  • 11 edits
    9 adds in trunk/LayoutTests

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Shinichiro Hamaji.

Various rebaselines due to changes in layout or new tests. The revision that caused
each change is by the change.

  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Added. Due to r56655.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Added. Ditto.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1296-expected.txt.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Added. Ditto.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Added. Ditto.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1430-expected.txt.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Added. Due to r56740.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Added. Ditto.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Added. Ditto.
  • platform/chromium-win/svg/custom/marker-overflow-clip-expected.txt: Due to r56693.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum: Due to r56655.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Ditto.
  • platform/chromium/test_expectations.txt: Added a few failures with follow up bugs.
23:42 BuildingQtOnLinux edited by fboudra@gmail.com
Add missing build dependencies (diff)
23:16 Changeset [56765] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Unreviewed, build fix only.

  • Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import.
23:15 Changeset [56764] by hamaji@chromium.org
  • 7 edits
    4 adds in trunk

2010-03-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Hyatt.

No vertical scrollbar after the CSS class change
https://bugs.webkit.org/show_bug.cgi?id=36461

  • fast/repaint/overflow-scroll-body-appear.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-03-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Hyatt.

No vertical scrollbar after the CSS class change
https://bugs.webkit.org/show_bug.cgi?id=36461

Don't suppress scrollbar change for non-first layouts.
In the first layout, the scrollbar change will happen in later
adjustViewSize() call, but in other layouts, adjustViewSize() may
not be called when the size of contents doesn't change.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
23:08 Changeset [56763] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-29 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Remove '_flymake' suffix from base part of file name so that
check-webkit-style uses a correct header guard name when it is called from Emacs's flymake.

https://bugs.webkit.org/show_bug.cgi?id=36573

  • Scripts/webkitpy/style/processors/cpp.py:
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
22:41 Changeset [56762] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Eric Seidel.

Get the following test-webkitpy unit test working again:
scm_unittest.SVNTest.test_svn_apply().

https://bugs.webkit.org/show_bug.cgi?id=36696

  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Add leading spaces to the empty lines of the ChangeLog strings.
    • Manually set the _reviewer attribute on the Attachment object to get the tests to pass.
22:09 Changeset [56761] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2010-03-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adele Peterson.

Default value of accelerated compositing should be false for Windows
https://bugs.webkit.org/show_bug.cgi?id=36805

  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
21:04 Changeset [56760] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Martin Robinson <mrobinson@webkit.org>

Reviewed by Holger Freyther.

[GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=36390

Suppress debugging messages sent to the GLib logger during DRT runs.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (logHandler): Added. (main): Use logHandler as the default GLib log message handler.
19:59 Changeset [56759] by eric@webkit.org
  • 9 edits in trunk/JavaScriptCore

2010-03-29 Chao-ying Fu <fu@mips.com>

Reviewed by Oliver Hunt.

MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144

The following changes enable MIPS JIT.

  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::lbu): (JSC::MIPSAssembler::linkWithOffset):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::load8): (JSC::MacroAssemblerMIPS::branch8): (JSC::MacroAssemblerMIPS::branchTest8): (JSC::MacroAssemblerMIPS::setTest8): (JSC::MacroAssemblerMIPS::setTest32):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::preserveReturnAddressAfterCall): (JSC::JIT::restoreReturnAddressBeforeReturn):
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):
  • wtf/Platform.h:
19:44 Changeset [56758] by levin@chromium.org
  • 49 edits in trunk/LayoutTests

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Dimitri Glazkov.

r56655 changed how tables layout which causes a lot of pixels tests for
tables to need rebaselines.

r56693 did some svg changes.

  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
  • platform/chromium-win/svg/custom/invalid-css-expected.txt: Due to r56693.
  • platform/chromium-win/svg/custom/marker-default-width-height-expected.txt: Ditto.
  • platform/chromium-win/svg/custom/shapes-supporting-markers-expected.txt: Ditto.
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
  • platform/chromium/test_expectations.txt: Two newly added tests are timing out (covered by http://crbug.com/35387).
19:32 Changeset [56757] by eric@webkit.org
  • 6 edits in trunk

2010-03-29 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

  • fast/xmlhttprequest/xmlhttprequest-no-file-access.html: Check that an isolated file:// origin can access about:blank iframes that it created itself.

2010-03-29 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Don't use unique domains for file:// separation: it breaks local
databases, and access to your own same-origin iframes. Instead, use
path-based access checks.

https://bugs.webkit.org/show_bug.cgi?id=36692

Test: fast/xmlhttprequest/xmlhttprequest-no-file-access.html

  • dom/Document.cpp: (WebCore::Document::initSecurityContext): renamed API.
  • page/SecurityOrigin.h:
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): Initialize new flag. Take note of file:// path. Copy new fields in copy constructor. (WebCore::SecurityOrigin::canAccess): Take into account path-based origin separation for file:// (WebCore::SecurityOrigin::enforceFilePathSeparation): New method to enable file:// path origin separation. (WebCore::SecurityOrigin::toString): Return a null domain for an isolated file origin. (WebCore::SecurityOrigin::isSameSchemeHostPort): Take into account path-based origin separation for file:// (WebCore::SecurityOrigin::passesFileCheck): Abstraction of common logic for file:// access checks.
18:38 Changeset [56756] by eric@webkit.org
  • 11 edits in trunk

2010-03-29 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission):
  • notifications/NotificationPresenter.h:

2010-03-29 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

  • public/WebNotificationPresenter.h: (WebKit::WebNotificationPresenter::checkPermission):
  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
  • src/NotificationPresenterImpl.h:

2010-03-29 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
18:15 Changeset [56755] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot should comment on bugs when builders break
https://bugs.webkit.org/show_bug.cgi?id=36786

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • Add a new _post_blame_comment_to_bug and all it from process_work_item
    • Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands.
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Test the new _post_blame_comment_to_bug call
18:07 Changeset [56754] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot fails to get information about certain builds
https://bugs.webkit.org/show_bug.cgi?id=36768

This seems to be caused by:
http://buildbot.net/trac/ticket/753
I have no work-around, but for now at least we're logging
the error better. I also added allow_none to our ServerProxy
creation in case that fixes things for other versions of python.

  • Scripts/webkitpy/common/net/buildbot.py:
17:34 Changeset [56753] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-29 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

Add sign in/out link to TestResults appengine

Add a link to main menu for sign in/out to this appengine.
People signed in with admin privilege could perform
actions that are only allowed to admins like deleting files.

https://bugs.webkit.org/show_bug.cgi?id=36767

  • TestResultServer/handlers/menu.py:
  • TestResultServer/stylesheets/menu.css: (.sign):
  • TestResultServer/templates/menu.html:
17:16 Changeset [56752] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-29 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Multiselect - Adding method itemIsSelected() to QtAbstractWebPopup
https://bugs.webkit.org/show_bug.cgi?id=36769

Adding method itemIsSelected() to QtAbstractWebPopup.

  • platform/qt/QtAbstractWebPopup.h: (WebCore::QtAbstractWebPopup::itemIsSelected):
16:58 Changeset [56751] by levin@chromium.org
  • 8 edits
    6 moves
    53 adds in trunk/LayoutTests

Rubber-stamped by Dmitry Titov.

[Chromium] pixel layout test fixes.

r56655 caused runin test which needed separate results for each platform.
r56673 caused computed-style-expected.
r56655 cause the fast/table changes (and we need linux specific results).
r56644 caused clip-path-referencing-use2-expected.
r56693 caused painting-marker-01-f-expected.

  • platform/chromium-linux/fast/runin/generated2-expected.checksum: Added.
  • platform/chromium-linux/fast/runin/generated2-expected.png: Added.
  • platform/chromium-linux/fast/runin/generated2-expected.txt: Added.
  • platform/chromium-linux/fast/runin/generated3-expected.checksum: Added.
  • platform/chromium-linux/fast/runin/generated3-expected.png: Added.
  • platform/chromium-linux/fast/runin/generated3-expected.txt: Added.
  • platform/chromium-linux/fast/runin/generated4-expected.checksum: Added.
  • platform/chromium-linux/fast/runin/generated4-expected.png: Added.
  • platform/chromium-linux/fast/runin/generated4-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-span-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/runin/generated2-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.checksum.
  • platform/chromium-mac/fast/runin/generated2-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.png.
  • platform/chromium-mac/fast/runin/generated3-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.checksum.
  • platform/chromium-mac/fast/runin/generated3-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.png.
  • platform/chromium-mac/fast/runin/generated4-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.checksum.
  • platform/chromium-mac/fast/runin/generated4-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.png.
  • platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/runin/generated2-expected.checksum: Added.
  • platform/chromium-win/fast/runin/generated2-expected.png: Added.
  • platform/chromium-win/fast/runin/generated2-expected.txt: Added.
  • platform/chromium-win/fast/runin/generated3-expected.checksum: Added.
  • platform/chromium-win/fast/runin/generated3-expected.png: Added.
  • platform/chromium-win/fast/runin/generated3-expected.txt: Added.
  • platform/chromium-win/fast/runin/generated4-expected.checksum: Added.
  • platform/chromium-win/fast/runin/generated4-expected.png: Added.
  • platform/chromium-win/fast/runin/generated4-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:
16:58 Changeset [56750] by eric@webkit.org
  • 8 edits in trunk

2010-03-29 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

Added a function, WebCore::shouldTreatAsAttachment, to HTTPParsers.*

https://bugs.webkit.org/show_bug.cgi?id=36395

This function, which was moved from WebKit/chromium/src/FrameClientImpl.cpp,
is used to check whether or not a request is supposed to be rendered or
simply downloaded based on the "Content-Disposition" header sent by the
web server. The intent of code refactoring is to avoid code duplication
so that this piece of code can be used by other implementations such as
QtWebKit.

  • platform/network/HTTPParsers.cpp: (WebCore::shouldTreatAsAttachment):
  • platform/network/HTTPParsers.h:

2010-03-29 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

Factored out the 'ShouldTreatAsAttachment' function to HTTPParsers.*
and replacted local version with the factored out version.

The code was factored out to make possible its use in other implementations
such as QtWebKit.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):

2010-03-29 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

[Qt] Added support for handling the HTTP "Content-Disposition" header.

https://bugs.webkit.org/show_bug.cgi?id=36395

Whenever a server response contains a "Content-Disposition: attachment..." header,
treat the request as a download and emit the unsupportedContent signal.

  • Api/qwebpage.cpp:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):
16:38 Changeset [56749] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-29 Chris Fleizach <cfleizach@apple.com>

Reviewed by Beth Dakin.

Bug 36735 - Live regions don't send out notifications when the element changing is the live region
https://bugs.webkit.org/show_bug.cgi?id=36735

  • platform/mac/accessibility/aria-liveregion-on-image-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregion-on-image.html: Added.

2010-03-29 Chris Fleizach <cfleizach@apple.com>

Reviewed by Beth Dakin.

Bug 36735 - Live regions don't send out notifications when the element changing is the live region
https://bugs.webkit.org/show_bug.cgi?id=36735

Test: platform/mac/accessibility/aria-liveregion-on-image.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::contentChanged):
16:33 Changeset [56748] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

ValidateReviewer step is draconian and un-tested
https://bugs.webkit.org/show_bug.cgi?id=36792

ValidateReviewer logic was commented out in
http://trac.webkit.org/changeset/56744
That was a symptom of the fact that validatereviewer.py
is too inflexible to be used when real humans are driving webkit-patch.
For now we just disable ValidateReviewer when humans are at the keyboard.

  • Scripts/webkitpy/tool/steps/validatereviewer.py:
    • Only run when in non-interactive mode.
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added.
    • Test our validation logic to make sure it's sane.
16:18 Changeset [56747] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Eliminate explicit slash characters from check-webkit-style's
_rel_path() method to make its implementation more platform
independent.

https://bugs.webkit.org/show_bug.cgi?id=36759

  • Scripts/webkitpy/style/main.py:
    • Changed to use os.sep instead of slash_chars "/
      ". This can be done since os.path.abspath() converts slashes to os.sep.
15:35 Changeset [56746] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Change new-run-webkit-tests to not use more than four threads by
default on the mac port until
https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.

https://bugs.webkit.org/show_bug.cgi?id=36687

  • Scripts/webkitpy/layout_tests/port/mac.py:
15:34 Changeset [56745] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.

https://bugs.webkit.org/show_bug.cgi?id=36691

  • Scripts/webkitpy/layout_tests/port/mac.py:
15:28 Changeset [56744] by senorblanco@chromium.org
  • 5 edits
    2 adds in trunk

2010-03-29 Stephen White <senorblanco@chromium.org>

Reviewed by Dave Hyatt.

In order to speed up multiple calls to CSSPrimitiveValue::cssText(),
this CL caches the String result. When m_value is changed, the
cached string is cleared. This gives a good speedup on benchmarks
which do a lot of CSS property gets, such as Peacekeeper.
The processing cost should be negligible, since the strings are
refcounted. The memory cost is an additional 4 bytes per
CSSPrimitiveValue, and the extended lifetime of the computed string
(potentially, the same as the lifetime of the CSSPrimitiveValue).

https://bugs.webkit.org/show_bug.cgi?id=36556

Covered by fast/css/cssText-cache.html, and more.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h:

2010-03-29 Stephen White <senorblanco@chromium.org>

Reviewed by Dave Hyatt.

Added a test for CSSPrimitiveValue::cssText() string cacheing.

https://bugs.webkit.org/show_bug.cgi?id=36556

  • fast/css/cssText-cache-expected.txt: Added.
  • fast/css/cssText-cache.html: Added.
15:26 April 2010 Meeting edited by laszlo.1.gombos@nokia.com
(diff)
15:20 Changeset [56743] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests fails java/lc3 on a clean checkout
https://bugs.webkit.org/show_bug.cgi?id=36078

  • Scripts/webkitpy/layout_tests/port/mac.py:
    • Build the java support files in check_build
    • Unwrap a line which would still fit under 80col
15:19 Changeset [56742] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Build Fix: Touch WebKit.idl to force Interfaces to rebuild

15:15 Changeset [56741] by sfalken@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Build fix. Touch WebKit.idl to force rebuild.

14:44 Changeset [56740] by kenneth@webkit.org
  • 19 edits
    2 adds in trunk

JavaScriptCore: Add an enable flag for the Widgets (http://www.w3.org/TR/widgets-reqs/)
and turn it on for Qt only.

Reviewed by Simon Fraser.

  • wtf/Platform.h:

WebCore: When enabling Web Widgets, add support for the view-mode media
feature (http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

Test: fast/media/media-feature-wgt-view-mode.html

  • css/CSSValueKeywords.in:
  • css/MediaFeatureNames.h:
  • css/MediaQueryEvaluator.cpp:

(WebCore::view_modeMediaFeatureEval):

  • page/ChromeClient.h:

(WebCore::ChromeClient::isDocked):
(WebCore::ChromeClient::isFloating):
(WebCore::ChromeClient::isApplication):
(WebCore::ChromeClient::isFullscreen):

WebKit/qt: Add an internal Qt API for changing the view mode media feature
(http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

  • Api/qwebpage.cpp:

(qt_wrt_setViewMode):
(QWebPagePrivate::priv):

  • Api/qwebpage_p.h:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::isDocked):
(WebCore::ChromeClientQt::isFloating):
(WebCore::ChromeClientQt::isApplication):
(WebCore::ChromeClientQt::isFullscreen):

  • WebCoreSupport/ChromeClientQt.h:

WebKitTools: Add hooks to the Qt DRT for testing the view mode media feature.

Reviewed by Simon Fraser.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setViewModeMediaFeature):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests: Add a test and an expected result for the Widgets 1.0: View Mode
Media Feature (http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

Skip on all other platforms than Qt, that has Skipped files.

  • fast/media/media-feature-wgt-view-mode.html: Added.
  • fast/media/media-feature-wgt-view-mode-expected.txt: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
13:51 Changeset [56739] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-29 Adam Barth <abarth@webkit.org>

Unreviewed. Update expected results for unit tests.

  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
13:49 Changeset [56738] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Adam Barth <abarth@webkit.org>

Unreviewed. I think Eric meant svn_revision.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
13:40 Changeset [56737] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-03-26 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes)
https://bugs.webkit.org/show_bug.cgi?id=29311

Now that we have sheriff-bot watching the tree, it can post
rollout patches on behalf of the commit queue.

  • Scripts/webkitpy/common/checkout/commitinfo.py: add responsible_parties()
  • Scripts/webkitpy/common/checkout/commitinfo_unittest.py: test responsible_parties()
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • Break IRC logic out into _post_irc_warning for easier testing.
    • Add _post_rollout_patch for posting rollout patches to bugzilla.
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Test _rollout_reason
  • Scripts/webkitpy/tool/grammar.py:
    • Fix join_with_separators to not add Adam's "oxford comma" for two item lists.
  • Scripts/webkitpy/tool/grammar_unittest.py:
    • Test join_with_separators
13:31 Changeset [56736] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sheriffbot should actually run commands
https://bugs.webkit.org/show_bug.cgi?id=36776

Some minor changes to Sheriffbot:

1) We should actually run commands (by giving control back to the
command processing object.

2) Use URLs instead of just numbers to represent SVN revisions (making
it easier to folks in IRC ot followup).

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
12:51 QtWebKitRelease20 edited by fboudra@gmail.com
(diff)
12:50 QtWebKitRelease20 edited by fboudra@gmail.com
nicer (diff)
12:48 QtWebKitRelease20 edited by fboudra@gmail.com
Link to the top of the page (diff)
12:45 BuildingQtOnLinux edited by fboudra@gmail.com
Update build dependencies for Debian and Ubuntu (diff)
11:54 April 2010 Meeting edited by geoffrey.levand@am.sony.com
Add Geoff Levand. (diff)
11:28 Changeset [56735] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-03-29 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Eliminate use of GL_BGRA in GraphicsContext3DSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=36737

No new tests; ran WebGL demos in Chromium on Windows to verify fix.

  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
11:20 Changeset [56734] by levin@chromium.org
  • 1 edit
    109 adds in trunk/LayoutTests

Rubber-stamped by Dmitry Titov.

Add chromium specific baselines for table tests added in r56641
and for runin tests added in r56655.

  • platform/chromium-mac/fast/table/table-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-overrides-row-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-col-span-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-group-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-span-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-span-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-span-background-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-left-50px-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-left-50px-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-right-100percent-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-50px-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-right-50px-expected.txt.
  • platform/chromium-mac/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-group-background-positioned-expected.txt.
  • platform/chromium-win/fast/table/table-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-group-col-span-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-group-span-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-span-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-span-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-left-50px-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-right-100percent-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-right-50px-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-group-background-positioned-expected.txt: Added.
  • platform/chromium/fast/runin/generated2-expected.checksum: Added.
  • platform/chromium/fast/runin/generated2-expected.png: Added.
  • platform/chromium/fast/runin/generated3-expected.checksum: Added.
  • platform/chromium/fast/runin/generated3-expected.png: Added.
  • platform/chromium/fast/runin/generated4-expected.checksum: Added.
  • platform/chromium/fast/runin/generated4-expected.png: Added.
11:10 Changeset [56733] by joepeck@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-03-29 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Darin Adler.

Test for Ensuring Pseudo Class's are Respected on Dynamic Changes
https://bugs.webkit.org/show_bug.cgi?id=36765

This tests elements affected by a CSS pseudo class selector is updated
after a dynamic DOM change.

  • fast/css/dynamic-pseudo-class-expected.txt: Added.
  • fast/css/dynamic-pseudo-class.html: Added.
10:59 Changeset [56732] by apavlov@chromium.org
  • 7 edits in trunk

2010-03-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Cover the Audits panel with tests
https://bugs.webkit.org/show_bug.cgi?id=36613

LayoutTests:

  • inspector/audits-panel-functional-expected.txt: Added.
  • inspector/audits-panel-functional.html: Added.
  • inspector/resources/audits-script1.js: Added. (foo1):
  • inspector/resources/audits-script2.js: Added. (foo2):
  • inspector/resources/audits-script3.js: Added. (foo3):

WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditResultView.js: (WebInspector.AuditResultView): (WebInspector.AuditCategoryResultPane.ruleSorter): (WebInspector.AuditCategoryResultPane):
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditRuleResult.linkifyDisplayName): (WebInspector.AuditRuleResult.resourceDomain): (WebInspector.AuditRuleResult.prototype.addURL):
  • inspector/front-end/inspector.js: (WebInspector.displayNameForURL):
10:54 April 2010 Meeting edited by ericu@chromium.org
(diff)
10:50 Changeset [56731] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-29 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Antti Koivisto.

Use 'Mobile Safari' instead of 'Safari' on mobile Qt platforms.

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
10:39 Changeset [56730] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Fix build break introduced in r56724.

Reviewed by nobody, build fix.

  • WebCore.pro:
10:31 Changeset [56729] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-29 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Corrected name of (u)int64_t compile time assert.
https://bugs.webkit.org/show_bug.cgi?id=36739

int64_t_is_four_bytes -> int64_t_is_eight_bytes

  • os-win32/stdint.h:
10:13 Changeset [56728] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-29 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

Pass a WebFrame to WebFrameClient::allowDatabase instead of a WebSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=36743

  • public/WebFrameClient.h: (WebKit::WebFrameClient::allowDatabase):
  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
10:11 Changeset [56727] by apavlov@chromium.org
  • 4 edits in trunk

2010-03-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector should highlight when clicking a node's closing tag
https://bugs.webkit.org/show_bug.cgi?id=16258

LayoutTests:

  • inspector/elements-panel-limited-children.html:

WebCore:

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set suppressRevealAndSelect): (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode): (WebInspector.ElementsTreeOutline.prototype._keyDown): (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.showChild): (WebInspector.ElementsTreeElement.prototype.onpopulate): (WebInspector.ElementsTreeElement.prototype.updateChildren): (WebInspector.ElementsTreeElement.prototype.insertChildElement): (WebInspector.ElementsTreeElement.prototype.moveChild): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.onexpand): (WebInspector.ElementsTreeElement.prototype.oncollapse): (WebInspector.ElementsTreeElement.prototype.onselect): (WebInspector.ElementsTreeElement.prototype.ondblclick): ():
10:03 April 2010 Meeting edited by chang.shu@nokia.com
(diff)
10:00 April 2010 Meeting edited by cjerdonek@webkit.org
Alphabetize list of attendees (diff)
09:56 April 2010 Meeting edited by darin@chromium.org
(diff)
09:56 Changeset [56726] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-29 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

https://bugs.webkit.org/show_bug.cgi?id=36315

Remove obsolete Geolocation::m_currentPosition
(follow up on https://bugs.webkit.org/show_bug.cgi?id=30676)

  • page/Geolocation.cpp: (WebCore::Geolocation::positionChanged): (WebCore::Geolocation::makeSuccessCallbacks):
  • page/Geolocation.h:
  • platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceChromium::GeolocationServiceChromium):
09:52 April 2010 Meeting edited by treat@kde.org
(diff)
09:51 April 2010 Meeting edited by dbates@webkit.org
Added myself to the list of attendees (diff)
09:31 April 2010 Meeting edited by levin@chromium.org
(diff)
09:24 Changeset [56725] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Use the -l syntax for linking against JavaScriptCore on Windows.
This allow qmake to extract dependencies correctly when generating VS
solutions.

Reviewed by Simon Hausmann.

09:24 Changeset [56724] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Do not generate INSTALLS for webkit when building inside Qt.
Qt will do this for us.

Reviewed by Simon Hausmann.

  • WebCore.pro:
09:21 April 2010 Meeting edited by rik@webkit.org
(diff)
09:19 April 2010 Meeting edited by ben@webkit.org
(diff)
09:10 April 2010 Meeting edited by levin@chromium.org
(diff)
09:05 Changeset [56723] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36703
Timer restart loop during page loading

Reviewed by Kenneth Rohde Christiansen.

Fix regression introduced in http://trac.webkit.org/changeset/54526.
Restarting the request timer unconditionally from the timer callback is a bad idea.
Instead, start the timer when a non-cached request completes.

  • loader/loader.cpp:

(WebCore::Loader::Host::nonCacheRequestComplete):
(WebCore::Loader::Host::servePendingRequests):

09:04 April 2010 Meeting edited by vestbo@webkit.org
(diff)
08:29 April 2010 Meeting edited by kenneth@webkit.org
(diff)
08:28 April 2010 Meeting edited by kenneth@webkit.org
(diff)
08:16 April 2010 Meeting created by cjerdonek@webkit.org
Started page for WebKit meeting
08:15 Changeset [56722] by ossy@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

Add support for iframe flattening
https://bugs.webkit.org/show_bug.cgi?id=36662

  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.
08:12 WikiStart edited by cjerdonek@webkit.org
Fix typo (diff)
08:11 WikiStart edited by cjerdonek@webkit.org
Created link to a page for the April 2010 WebKit meeting (diff)
07:48 Changeset [56721] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] unit tests don't compile inside of Qt

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=36756

  • tests/tests.pri: Don't do the target substitution inside Qt and find the sources

through VPATH instead of relying on the location of the .pro file exclusively.

07:40 Changeset [56720] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

Add support for iframe flattening
https://bugs.webkit.org/show_bug.cgi?id=36662

  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: updated after r56718.
07:03 Changeset [56719] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Shadowbuilds of WebCore with Qt on Symbian fails.

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=36749

Doing a 'make sis' expects the dll in the libdir, so place it
there. This fixes out-of-source building to always put the dll
in the expected dir.

  • WebCore.pro: Fix for shadow builds inside Qt.
07:03 Changeset [56718] by kenneth@webkit.org
  • 47 edits
    2 adds in trunk

WebCore: Implement flattening for iframes.

Reviewed by Antti Koivisto.

Refactoring of frameset flattening code to reuse it for
iframe flattening.

Tests: fast/frames/flattening/iframe-flattening-simple.html

  • WebCore.base.exp:
  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setFrameFlatteningEnabled):

  • page/Settings.h:

(WebCore::Settings::frameFlatteningEnabled):

  • rendering/RenderFrame.cpp:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::flattenFrameSet):

  • rendering/RenderFrameSet.h:
  • rendering/RenderPart.cpp:

(WebCore::RenderPart::layoutWithFlattening):

  • rendering/RenderPart.h:
  • rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):

  • rendering/RenderPartObject.h:

WebKit/mac: Change method name due to it dealing with both flattening
of frame sets and inner frames.

Reviewed by Antti Koivisto.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences isFrameFlatteningEnabled]):
(-[WebPreferences setFrameFlatteningEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/qt: Change due to renaming of frame flattening setting.

Reviewed by Antti Koivisto.

  • Api/qwebpage.cpp:

(qt_drt_setFrameFlatteningEnabled):

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

  • symbian/eabi/QtWebKitu.def:

WebKit/win: Change method name due to it dealing with both flattening
of frame sets and inner frames.

Reviewed by Antti Koivisto.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::isFrameFlatteningEnabled):
(WebPreferences::setFrameFlatteningEnabled):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

WebKitTools: Renaming of frame flattening LayoutTestController method
to setFrameFlatteningEnabled(bool)

Reviewed by Antti Koivisto.

  • DumpRenderTree/LayoutTestController.cpp:

(setFrameFlatteningEnabledCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

LayoutTests: Add new iframe flattening test and change existing frameset
flattening tests to use the new LayoutTestController method.

Reviewed by Antti Koivisto.

  • fast/frames/flattening/frameset-flattening-advanced.html:
  • fast/frames/flattening/frameset-flattening-grid.html:
  • fast/frames/flattening/frameset-flattening-simple.html:
  • fast/frames/flattening/frameset-flattening-subframe-resize.html:
  • fast/frames/flattening/frameset-flattening-subframesets.html:
  • fast/frames/flattening/iframe-flattening-simple.html: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.
06:53 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:53 QtWebKitBackportingFixes edited by yael.aharon@nokia.com
(diff)
05:23 Changeset [56717] by ossy@webkit.org
  • 1 edit
    51 adds in trunk/LayoutTests

[Qt] Platform specific expected file added for tests introduced in r56655,
because they pass. Compared to png file and Mac expected file.

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/fast/table/table-background-expected.checksum: Added.
  • platform/qt/fast/table/table-background-expected.png: Added.
  • platform/qt/fast/table/table-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-background-expected.png: Added.
  • platform/qt/fast/table/table-col-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-group-background-expected.png: Added.
  • platform/qt/fast/table/table-col-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/qt/fast/table/table-col-group-span-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-span-background-expected.png: Added.
  • platform/qt/fast/table/table-col-span-background-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-expected.png: Added.
  • platform/qt/fast/table/table-row-background-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/qt/fast/table/table-row-background-left-50px-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/qt/fast/table/table-row-background-right-50px-expected.txt: Added.
  • platform/qt/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-row-group-background-expected.png: Added.
  • platform/qt/fast/table/table-row-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.txt: Added.
04:54 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
04:49 Changeset [56716] by benm@google.com
  • 4 edits
    1 add in trunk/WebCore

Page Cache does not work on Android with V8
https://bugs.webkit.org/show_bug.cgi?id=36665

Patch by Andrei Popescu <andreip@google.com> on 2010-03-29
Reviewed by Adam Barth.

No new tests, existing tests should suffice, this is platform code.

This implementation simply saves the context and the global object
just before the frame is navigated to a new url. At restore time,
the global object is reattached to the context and the context
is attached to the window shell of the frame.

Note that isolated worlds are not taken into account in any way,
as Android does not use them.

  • bindings/v8/ScriptCachedFrameData.cpp: Added.

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::domWindow):
(WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):

  • bindings/v8/ScriptCachedFrameData.h:
  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::setContext):

  • bindings/v8/V8DOMWindowShell.h:
04:14 Changeset [56715] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Make it possible to build using both Windows and Linux for Symbian
https://bugs.webkit.org/show_bug.cgi?id=36748

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

  • WebCore.pro: don't assume Windows buildsystem is the only one

and exclude the windows-only setters from the linux builds.

04:07 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:55 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:49 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:44 Changeset [56714] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36745

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

[Qt] Fix def file builds with Qt 4.7.

Switched to using DEF_FILE, which is the official variable.

  • WebCore.pro: Use DEF_FILE
02:35 QtWebKitJournal edited by hausmann@webkit.org
(diff)
02:26 Changeset [56713] by jorlow@chromium.org
  • 13 edits
    8 copies
    2 adds in trunk

2010-03-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

A few more steps towards IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=36546

Add a callback interface to be used by all async methods.
Add the first fragments of IDBDatabase.
Clean up on IDBDatabaseError.
Flesh out IndexedDatabase further.

Not enough hooked up yet to test. Soon though...

  • WebCore.gypi:
  • storage/IDBCallbacks.h: Added. (WebCore::IDBCallbacks::~IDBCallbacks):
  • storage/IDBDatabase.cpp: Added.
  • storage/IDBDatabase.h: Added. (WebCore::IDBDatabase::~IDBDatabase):
  • storage/IDBDatabaseError.h: (WebCore::IDBDatabaseError::create): (WebCore::IDBDatabaseError::message): (WebCore::IDBDatabaseError::IDBDatabaseError):
  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):

2010-03-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

More IndexedDB plumbing
https://bugs.webkit.org/show_bug.cgi?id=36546

Plumbing work towards the goal of making IndexedDatabase::open work.

  • WebKit.gyp:
  • public/WebIDBCallbacks.h: Added. (WebKit::WebIDBCallbacks::~WebIDBCallbacks):
  • public/WebIDBDatabase.h: Added. (WebKit::WebIDBDatabase::~WebIDBDatabase):
  • public/WebIDBDatabaseError.h: Added. (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::operator=):
  • public/WebIndexedDatabase.h:
  • public/WebKitClient.h: (WebKit::WebKitClient::indexedDatabase):
  • public/WebSerializedScriptValue.h:
  • src/IDBCallbacksProxy.h: Added. (WebCore::IDBCallbacksProxy::IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::onSuccess): (WebCore::IDBCallbacksProxy::onError):
  • src/IDBDatabaseProxy.cpp: Added. (WebCore::IDBDatabaseProxy::create): (WebCore::IDBDatabaseProxy::IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy):
  • src/IDBDatabaseProxy.h: Added.
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::open):
  • src/IndexedDatabaseProxy.h:
  • src/WebIDBDatabaseError.cpp: Added. (WebKit::WebIDBDatabaseError::~WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::assign): (WebKit::WebIDBDatabaseError::code): (WebKit::WebIDBDatabaseError::message): (WebKit::WebIDBDatabaseError::operator=): (WebKit::WebIDBDatabaseError::operator PassRefPtr<IDBDatabaseError>):
02:10 Changeset [56712] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=36742

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

gcc for Symbian doesn't support gcc extensions like atomicity.h - disable

  • wtf/Threading.h: also detect os symbian
01:52 Changeset [56711] by mnaganov@chromium.org
  • 7 edits in trunk

2010-03-29 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Remove a possibility of confusion from Profiles panel Welcome screen
by turning buttons into non-clickable glyphs. Also, span instructions
alongside panel width.

https://bugs.webkit.org/show_bug.cgi?id=34319

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.get welcomeMessage):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._addWelcomeMessage):
  • inspector/front-end/inspector.css: (.panel-enabler-view.welcome .instructions): (.panel-enabler-view.welcome button.status-bar-item):
  • src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage):
01:17 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
00:41 Changeset [56710] by philn@webkit.org
  • 2 edits in trunk/WebCore

2010-03-26 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] define static variables with DEFINE_STATIC_LOCAL macro
https://bugs.webkit.org/show_bug.cgi?id=36653

Defined the static variables using DEFINE_STATIC_GLOBAL.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
00:37 Changeset [56709] by philn@webkit.org
  • 2 edits in trunk/WebCore

2010-03-26 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] player header cleanups
https://bugs.webkit.org/show_bug.cgi?id=36656

Destructor made private and added missing
mediaPlayerPrivateMuteChangedCallback declaration.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
00:34 Changeset [56708] by yurys@chromium.org
  • 7 edits
    7 adds in trunk

2010-03-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Protect global object from being GC'ed if there are messages written to console from the iframe with that global object.

Whent serializing objects in the injected script check that global object properties are still defined before using them as arguments. The may become undefined if owning frame navigated to a different domain.

https://bugs.webkit.org/show_bug.cgi?id=36612

Test: http/tests/inspector-enabled/console-log-before-frame-navigation.html

  • bindings/js/ScriptState.h: (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
  • bindings/v8/ScriptState.h: (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::~ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/ConsoleMessage.h:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):

2010-03-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: don't crash when there are messages in console from previous iframe content.

https://bugs.webkit.org/show_bug.cgi?id=36612

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt: Added.
  • http/tests/inspector-enabled/console-log-before-frame-navigation.html: Added.
  • http/tests/inspector-enabled/resources/console-log-before-frame-navigation.js: Added. (doit.callback): (doit): (receiveMessage): (frontend_dumpConsoleMessages):
  • http/tests/inspector-enabled/resources/console-log-frame-after-navigation.html: Added.
  • http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html: Added.
00:29 Changeset [56707] by philn@webkit.org
  • 5 edits in trunk/WebCore

2010-03-26 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

It should be possible to use GStreamer in addition to another media engine
https://bugs.webkit.org/show_bug.cgi?id=36654

Renamed gstreamer player and added a WTF_USE_GSTREAMER
define. Made the MediaPlayer register the GStreamer backend only
if it's enabled (true by default on WebKitGTK+).

  • GNUmakefile.am:
  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivateGStreamer::create): (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): (WebCore::MediaPlayerPrivateGStreamer::isAvailable): (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::load): (WebCore::MediaPlayerPrivateGStreamer::commitLoad): (WebCore::MediaPlayerPrivateGStreamer::changePipelineState): (WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): (WebCore::MediaPlayerPrivateGStreamer::play): (WebCore::MediaPlayerPrivateGStreamer::pause): (WebCore::MediaPlayerPrivateGStreamer::duration): (WebCore::MediaPlayerPrivateGStreamer::currentTime): (WebCore::MediaPlayerPrivateGStreamer::seek): (WebCore::MediaPlayerPrivateGStreamer::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivateGStreamer::cancelSeek): (WebCore::MediaPlayerPrivateGStreamer::endPointTimerFired): (WebCore::MediaPlayerPrivateGStreamer::paused): (WebCore::MediaPlayerPrivateGStreamer::seeking): (WebCore::MediaPlayerPrivateGStreamer::naturalSize): (WebCore::MediaPlayerPrivateGStreamer::hasVideo): (WebCore::MediaPlayerPrivateGStreamer::hasAudio): (WebCore::MediaPlayerPrivateGStreamer::setVolume): (WebCore::MediaPlayerPrivateGStreamer::volumeChangedTimerFired): (WebCore::MediaPlayerPrivateGStreamer::volumeChanged): (WebCore::MediaPlayerPrivateGStreamer::setRate): (WebCore::MediaPlayerPrivateGStreamer::networkState): (WebCore::MediaPlayerPrivateGStreamer::readyState): (WebCore::MediaPlayerPrivateGStreamer::buffered): (WebCore::MediaPlayerPrivateGStreamer::processBufferingStats): (WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded): (WebCore::MediaPlayerPrivateGStreamer::bytesLoaded): (WebCore::MediaPlayerPrivateGStreamer::totalBytes): (WebCore::MediaPlayerPrivateGStreamer::cancelLoad): (WebCore::MediaPlayerPrivateGStreamer::updateStates): (WebCore::MediaPlayerPrivateGStreamer::mediaLocationChanged): (WebCore::MediaPlayerPrivateGStreamer::loadNextLocation): (WebCore::MediaPlayerPrivateGStreamer::loadStateChanged): (WebCore::MediaPlayerPrivateGStreamer::sizeChanged): (WebCore::MediaPlayerPrivateGStreamer::timeChanged): (WebCore::MediaPlayerPrivateGStreamer::didEnd): (WebCore::MediaPlayerPrivateGStreamer::durationChanged): (WebCore::MediaPlayerPrivateGStreamer::supportsMuting): (WebCore::MediaPlayerPrivateGStreamer::setMuted): (WebCore::MediaPlayerPrivateGStreamer::muteChangedTimerFired): (WebCore::MediaPlayerPrivateGStreamer::muteChanged): (WebCore::MediaPlayerPrivateGStreamer::loadingFailed): (WebCore::MediaPlayerPrivateGStreamer::setSize): (WebCore::MediaPlayerPrivateGStreamer::setVisible): (WebCore::MediaPlayerPrivateGStreamer::repaint): (WebCore::MediaPlayerPrivateGStreamer::paint): (WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes): (WebCore::MediaPlayerPrivateGStreamer::supportsType): (WebCore::MediaPlayerPrivateGStreamer::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen): (WebCore::MediaPlayerPrivateGStreamer::setPreload): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

03/28/10:

21:11 Changeset [56706] by ap@apple.com
  • 2 edits in trunk/WebKit/chromium

Build fix. Removed extraneous includes of KeyboardCodesWin.h and KeyboardCodesPosix.h -
these no longer exist, but they weren't needed even before reshuffling KeyboardCodes headers.

20:53 Changeset [56705] by ap@apple.com
  • 10 edits in trunk/WebKit

Build fix. Include WindowsKeyboardCodes.h instead of KeyboardCodes.h.

20:41 Changeset [56704] by ap@apple.com
  • 13 edits
    1 move
    1 add
    5 deletes in trunk/WebCore

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=36733
Use a common header for Windows virtual key codes on all platforms

No change in functionality, so no new tests.

  • platform/WindowsKeyboardCodes.h: Added. Define VK_* key codes as macros, matching Windows.
  • platform/KeyboardCodes.h: Removed.
  • platform/android/KeyboardCodes.h: Removed.
  • platform/chromium/KeyboardCodesPosix.h: Removed.
  • platform/chromium/KeyboardCodesWin.h: Removed.
  • platform/haiku/KeyboardCodes.h: Removed.
  • platform/wx/KeyboardCodes.h: Removed. Removed platform specific attempts to do the same thing. In fact, platform/KeyboardCodes.h was supposed to be cross-platform, but it didn't have a sufficiently descriptive name, and its name was the same as platform-specific versions, so I chose a new one.
  • platform/chromium/KeyboardCodes.h: Copied from WebCore/platform/chromium/KeyboardCodesWin.h. Chromium redefines Windows constants to different names; keeping the header doing that to avoid breaking Chromium code.
  • GNUmakefile.am:
  • WebCore.gypi: Replaced KeyboardCodes.h with WindowsKeyboardCodes.h.
  • WebCore.xcodeproj/project.pbxproj:
  • platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForKeyCode): (WebCore::windowsKeyCodeForCharCode): Mac used to hardcode the key codes; changed to use VK_* macros.
  • config.h: Removed a hack to include KeyboardCodes.h, it shouldn't be necessary any more.
  • platform/android/KeyEventAndroid.cpp:
  • platform/brew/PlatformKeyboardEventBrew.cpp:
  • platform/efl/PlatformKeyboardEventEfl.cpp:
  • platform/gtk/KeyEventGtk.cpp:
  • platform/haiku/PlatformKeyboardEventHaiku.cpp:
  • platform/qt/PlatformKeyboardEventQt.cpp:
  • platform/wx/KeyboardEventWx.cpp: Changed to include WindowsKeyboardCodes.h.
15:48 Changeset [56703] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-28 Gustavo Noronha Silva <gns@gnome.org>

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

Skip tests that need more load notifications than we provide in
our DRT currently.

  • platform/gtk/Skipped:
15:36 Changeset [56702] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-28 Gustavo Noronha Silva <gns@gnome.org>

Skipping new tests.

  • platform/gtk/Skipped:
15:29 Changeset [56701] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-28 Gustavo Noronha Silva <gns@gnome.org>

No review, rolling out r56679.
http://trac.webkit.org/changeset/56679
https://bugs.webkit.org/show_bug.cgi?id=36454

Lots of tests broken.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView):
14:41 Changeset [56700] by eric@webkit.org
  • 4 edits in trunk

2010-03-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Remove the definition of WTF_CHANGES guards from the build system
https://bugs.webkit.org/show_bug.cgi?id=31670

  • JavaScriptCore.pro: Remove the definition of WTF_CHANGES as it is already defined in config.h

2010-03-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Remove the definition of WTF_CHANGES guards from the build system
https://bugs.webkit.org/show_bug.cgi?id=31670

No new tests as there is no new functionality.

  • WebCore.pri: Remove the definition of WTF_CHANGES as it is already defined in config.h
13:00 QtWebKitJournal edited by hausmann@webkit.org
(diff)
12:19 Changeset [56699] by cjerdonek@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Fixed typo in deprecated_logging_unittest.py, which is masking
sys.stderr while running test-webkitpy.

See also-- https://bugs.webkit.org/show_bug.cgi?id=36725#c3

  • Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
10:47 Changeset [56698] by weinig@apple.com
  • 2 edits in trunk/WebCore

Clean up the Xcode project a bit.

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj:
10:41 Changeset [56697] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-03-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Toggling style properties on/off does not always work.

https://bugs.webkit.org/show_bug.cgi?id=36720

  • inspector/InspectorController.cpp:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::buildArrayForDisabledStyleProperties):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):
10:32 Changeset [56696] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-03-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: resource links should navigate to resource panel enabler when resource tracking is off.

https://bugs.webkit.org/show_bug.cgi?id=36722

09:59 Changeset [56695] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-28 Dirk Schulze <krit@webkit.org>

Unreviewed test update for Win.

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

May mixed up the win bot with the win-chromium bot.

  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
09:30 Changeset [56694] by krit@webkit.org
  • 6 edits in trunk

2010-03-28 Dirk Schulze <krit@webkit.org>

Unreviewed build-fix for chromium linux.

SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):

2010-03-28 Dirk Schulze <krit@webkit.org>

Unreviewed test update.

SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185

Marker results update for Qt port.

  • platform/qt/svg/custom/marker-opacity-expected.txt:
  • platform/qt/svg/custom/marker-referencePoint-expected.txt:
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
09:01 Changeset [56693] by krit@webkit.org
  • 43 edits
    2 adds
    2 deletes in trunk

2010-03-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185

This moves SVGResourceMarker to RenderersSVGResourceMarker. This follows other
SVG resources like masker and clipper and makes DRT results more readable and
adds additonal informations.
Some marker specific code also moved out from RenderSVGViewportContainer to
RenderersSVGResourceMarker.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::destroy):
  • rendering/RenderSVGResource.h: (WebCore::):
  • rendering/RenderSVGResourceMarker.cpp: Added. (WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker): (WebCore::RenderSVGResourceMarker::~RenderSVGResourceMarker): (WebCore::RenderSVGResourceMarker::layout): (WebCore::RenderSVGResourceMarker::addClient): (WebCore::RenderSVGResourceMarker::invalidateClients): (WebCore::RenderSVGResourceMarker::invalidateClient): (WebCore::RenderSVGResourceMarker::applyViewportClip): (WebCore::RenderSVGResourceMarker::markerBoundaries): (WebCore::RenderSVGResourceMarker::localToParentTransform): (WebCore::RenderSVGResourceMarker::referencePoint): (WebCore::RenderSVGResourceMarker::angle): (WebCore::RenderSVGResourceMarker::markerTransformation): (WebCore::RenderSVGResourceMarker::draw): (WebCore::RenderSVGResourceMarker::markerContentTransformation): (WebCore::RenderSVGResourceMarker::viewportTransform): (WebCore::RenderSVGResourceMarker::calcViewport):
  • rendering/RenderSVGResourceMarker.h: Added. (WebCore::RenderSVGResourceMarker::renderName): (WebCore::RenderSVGResourceMarker::applyResource): (WebCore::RenderSVGResourceMarker::resourceBoundingBox): (WebCore::RenderSVGResourceMarker::markerUnits): (WebCore::RenderSVGResourceMarker::resourceType):
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport): (WebCore::RenderSVGViewportContainer::viewportTransform):
  • rendering/RenderSVGViewportContainer.h:
  • rendering/SVGMarkerData.h: (WebCore::SVGMarkerData::SVGMarkerData): (WebCore::SVGMarkerData::marker): (WebCore::SVGMarkerData::updateTypeAndMarker):
  • rendering/SVGMarkerLayoutInfo.cpp: (WebCore::processStartAndMidMarkers): (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker):
  • rendering/SVGMarkerLayoutInfo.h: (WebCore::MarkerLayout::MarkerLayout): (WebCore::SVGMarkerLayoutInfo::midMarker):
  • rendering/SVGRenderSupport.cpp: (WebCore::deregisterFromResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeSVGResource):
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::childrenChanged): (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle): (WebCore::SVGMarkerElement::createRenderer):
  • svg/SVGMarkerElement.h: (WebCore::SVGMarkerElement::):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
  • svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isFilter):
  • svg/graphics/SVGResourceMarker.cpp: Removed.
  • svg/graphics/SVGResourceMarker.h: Removed.

2010-03-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185

DRT results changed after moving SVGResourceMarker and need updates.

  • platform/mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-marker-creation-expected.txt:
  • platform/mac/svg/custom/marker-changes-expected.txt:
  • platform/mac/svg/custom/marker-child-changes-expected.txt:
  • platform/mac/svg/custom/marker-default-width-height-expected.txt:
  • platform/mac/svg/custom/marker-opacity-expected.txt:
  • platform/mac/svg/custom/marker-overflow-clip-expected.txt:
  • platform/mac/svg/custom/marker-referencePoint-expected.txt:
  • platform/mac/svg/custom/marker-strokeWidth-changes-expected.txt:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
08:23 Changeset [56692] by cjerdonek@webkit.org
  • 10 edits in trunk/WebKitTools

Renamed check-webkit-style's --debug flag to --verbose to be more
in line with other WebKit scripts. Also renamed the current
--verbose flag to --min-confidence to allow the --debug rename.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=36521

We also renamed the internal "verbose" variables to "confidence" or
"min_confidence," as appropriate, to avoid confusion with the
--verbose flag, and because the new names are more accurate.

  • Scripts/check-webkit-style:
    • Renamed is_debug to is_verbose.
  • Scripts/webkitpy/style/checker.py:
    • Renamed _DEFAULT_VERBOSITY to _DEFAULT_CONFIDENCE.
    • Renamed "verbosity" parameters to "min_confidence" throughout.
    • Renamed configure_logging()'s is_debug parameter to is_verbose.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the unit tests as necessary.
  • Scripts/webkitpy/style/error_handlers.py:
    • Updated the call to StyleCheckerConfiguration.write_style_error().
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated the unit tests as necessary.
  • Scripts/webkitpy/style/optparser.py:
    • Updated the usage string with the new flag names.
    • Renamed the verbosity parameter to min_confidence throughout.
    • Renamed the is_debug parameter to is_verbose throughout.
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Updated the unit tests as necessary.
  • Scripts/webkitpy/style/processors/cpp.py:
    • Renamed the verbosity parameter to min_confidence throughout.
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
    • Updated the unit tests as necessary.
08:05 Changeset [56691] by cjerdonek@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Added back a line that accidentally got deleted in r56690.

  • Scripts/check-webkit-style:
07:51 Changeset [56690] by cjerdonek@webkit.org
  • 5 edits in trunk/WebKitTools

Add to check-webkit-style support for checking directories.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35234

  • Scripts/check-webkit-style:
    • Replaced the call to check_file() with a call to check_paths().
  • Scripts/webkitpy/style/checker.py:
    • In the StyleChecker class:
      • Added a check_paths() method that accepts a list of paths to files and directories.
      • Added a _check_directory() method that checks the files in a directory.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added a StyleCheckerCheckPathsTest to unit-test the new check_paths() method.
  • Scripts/webkitpy/style/optparser.py:
    • Updated the usage string.
03:43 Changeset [56689] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-03-28 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Add API for reporting additional memory cost of JavaScript objects
https://bugs.webkit.org/show_bug.cgi?id=36650

  • qt/api/qscriptengine.cpp: (QScriptEngine::reportAdditionalMemoryCost):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.h: (QScriptEnginePrivate::reportAdditionalMemoryCost):
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::reportAdditionalMemoryCost):
03:33 Changeset [56688] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-03-28 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Consolidate Tree Hierarchy Attribute HTML Generation
https://bugs.webkit.org/show_bug.cgi?id=36719

Consolidates the generation of Element Tree Hierarchy attribute code
generation to a single function: _attributeHTML.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._addNewAttribute): convert to use attributeHTML. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.regenerateStyledAttribute): convert to use attributeHTML. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._attributeHTML): a single point for generating the html for attributes.
03:33 Changeset [56687] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-03-28 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481

Ensure blacklisting happens by checking it in _startEditingTagName
instead of all the possible entry points.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): don't check blacklist here. (WebInspector.ElementsTreeElement.prototype._startEditingTagName): check blacklist here.
03:03 Changeset [56686] by eric@webkit.org
  • 6 edits in trunk/JavaScriptCore

2010-03-28 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

QScriptEngine API was enriched by globalObject() method
which give an access to the global object.

[Qt] QScriptEngine doesn't give an access to global object
https://bugs.webkit.org/show_bug.cgi?id=36603

  • qt/api/qscriptengine.cpp: (QScriptEngine::globalObject):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::globalObject):
  • qt/api/qscriptengine_p.h:
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::globalObject):
02:46 Changeset [56685] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-28 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: Timing functions don't work with transitions
https://bugs.webkit.org/show_bug.cgi?id=36589

If the animation value doesn't have timing function set, we need to
use the animation's timing function.

Fixed also a bug in passing the duration to solveCubicBezierFunction.
The duration was divided two times by 1000 and meanwhile casted to int.
It needs to be kept as double and divided by 1000 only once.

Test case: https://bugs.webkit.org/attachment.cgi?id=51619

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::applyTimingFunction): (WebCore::AnimationQt:::AnimationQtBase): (WebCore::AnimationQt::updateCurrentTime):
01:49 Changeset [56684] by joepeck@webkit.org
  • 3 edits in trunk/WebCore

2010-03-27 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481

Allow tabbing back and forth between the tag name and element
attributes when editing. Also, fixed a number of minor issues with
editing attributes and tabbing.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditingTagName): find the tag name if it wasn't provided. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): fix tabbing issues, enable tab to tag name. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.regenerateStyledAttribute): cleanup styles when tabbing.
  • inspector/front-end/inspector.css: do not display <br>s while editing
01:49 Changeset [56683] by joepeck@webkit.org
  • 11 edits in trunk/WebCore

2010-03-27 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481

Allow editing an Element's Tag Name by double clicking
on the tag name in the Element's Tree Hierarchy.

The usual asynchronous InspectorBackend, InspectorDOMAgent, InspectorFrontend flow.

  • inspector/InspectorBackend.cpp: moved DOM manipulation to InspectorDOMAgent (WebCore::InspectorBackend::removeNode): (WebCore::InspectorBackend::changeTagName):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::changeTagName):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didChangeTagName):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js:

Handle the UI for editing an Element's tag name.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): allow editing from double click. (WebInspector.ElementsTreeElement.prototype._startEditingTagName.keyupListener): update the closing tag (WebInspector.ElementsTreeElement.prototype._startEditingTagName.editingComitted): remove extra listener and commit (WebInspector.ElementsTreeElement.prototype._startEditingTagName.editingCancelled): remove extra listener and cancel (WebInspector.ElementsTreeElement.prototype._startEditingTagName): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.cancel): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.editTagNameCallback): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted): (WebInspector.ElementsTreeElement.prototype._distinctClosingTagElement): get the closing tag for an opening tag (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo): wrap the tagName in span.webkit-html-tag-name

Miscellaneous updates.

  • inspector/front-end/treeoutline.js: fixed a typo.
00:54 Changeset [56682] by cjerdonek@webkit.org
  • 7 edits
    2 adds in trunk/WebKitTools

Changed check-webkit-style to convert paths to paths relative to
the checkout root when invoking check-webkit-style with path
arguments. Also added warning messages where appropriate.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35498

Converting paths to paths relative to the checkout root ensures
that style checking will behave as expected (since path-specific
rules assume input paths are relative to a source root).

  • Scripts/check-webkit-style:
    • Added debug logging of whether the current directory was found to be in a WebKit checkout.
    • Added the found_checkout parameter to the call to parser.parse().
    • Renamed the files variable to paths.
    • Added a call to change_directory() prior to checking style.
  • Scripts/webkitpy/style/checker.py:
    • For StyleChecker.check_file():
      • Updated the docstring.
      • Added two log messages.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated a call to parser.parse() with the found_checkout parameter.
  • Scripts/webkitpy/style/main.py: Added.
    • Added a new file so the code in this patch could be unit-tested, as opposed to adding new code to check-webkit-style.
    • Added the method _rel_path() as a substitute for os.path.relpath(), which is available only in Python 2.6.
    • Added the method change_directory(), which contains most of the new functionality in this patch.
  • Scripts/webkitpy/style/main_unittest.py: Added.
    • Added RelPathTest to test main._rel_path().
    • Added ChangeDirectoryTest to test main.change_directory().
  • Scripts/webkitpy/style/optparser.py:
    • Updated check-webkit-style's usage string.
    • For the ArgumentParser.parse() method:
      • Added a found_checkout parameter.
      • Renamed filenames to paths.
      • Added logic so that an error is raised if no paths are passed if found_checkout is False.
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Updated the ArgumentParser.parse() unit tests to include coverage for the new found_checkout parameter.
  • Scripts/webkitpy/style/unittests.py:
    • Added an import statement for main_unittest.
  • Scripts/webkitpy/style_references.py:
    • Renamed SimpleScm to WebKitCheckout.
    • Added a detect_checkout() function to allow returning None instead of a WebKitCheckout instance if no checkout is found.
    • Renamed checkout_root to root_path.

03/27/10:

23:09 Changeset [56681] by eric@webkit.org
  • 7 edits in trunk

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Removed 5 http/history tests from Skipped file

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • platform/gtk/Skipped:

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

FrameLoader emits onload-event when handling
dispatchDidHandleOnloadEvents

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents): implemented, now it emits onload-event signal
  • webkit/webkitwebview.cpp: added onload-event signal

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Print didHandleOnloadEventsForFrame in the callback of
onload-event signal comming from frame loader

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewOnloadEvent): (createWebView): added connection to signal::onload-event and signal callback
22:51 Changeset [56680] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Print didCommitLoadForFrame in the callback of signal::load-committed

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadCommitted): (createWebView): added connection to sinal::load-committed and signal callback
22:34 Changeset [56679] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Print didStartProvisionalLoadForFrame in the callback of
notify::load-status property change notification

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webInspectorCloseWindow): (webInspectorInspectWebView): (createWebView): added connection to notify::load-status and signal callback
21:16 Changeset [56678] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-03-27 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Use WebKitClient to instantiate WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=36669

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize):
19:50 Changeset [56677] by eric@webkit.org
  • 1 edit
    8 deletes in trunk/WebKitTools

2010-03-27 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

In webkitpy/, deleted the /unittests.py files since test-webkitpy
now auto-detects all *_unittest.py files.

https://bugs.webkit.org/show_bug.cgi?id=36712

  • Scripts/webkitpy/common/net/irc/unittests.py: Removed.
  • Scripts/webkitpy/common/system/unittests.py: Removed.
  • Scripts/webkitpy/common/thread/unittests.py: Removed.
  • Scripts/webkitpy/common/unittests.py: Removed.
  • Scripts/webkitpy/python24/unittests.py: Removed.
  • Scripts/webkitpy/style/unittests.py: Removed.
  • Scripts/webkitpy/tool/unittests.py: Removed.
  • Scripts/webkitpy/unittests.py: Removed.
19:32 Changeset [56676] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-27 Dmitry Gorbik <socket.h@gmail.com>

Reviewed by Pavel Feldman.

Fix the regression caused by r28078: a global variable
definition masks a local one in an inspector console
https://bugs.webkit.org/show_bug.cgi?id=32442

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
18:56 Changeset [56675] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

More updated results for r56673.

  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
18:07 Changeset [56674] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Add a CR after printing didFinishDocumentLoadForFrame

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadFinished):
17:59 Changeset [56673] by mitz@apple.com
  • 12 edits in trunk

WebCore: <rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
https://bugs.webkit.org/show_bug.cgi?id=36700

Reviewed by Darin Adler.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::createColor): Reverted to returning an RGB color value rather than an
identifier for the transparent color.

LayoutTests: Updated results and one test for
<rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
https://bugs.webkit.org/show_bug.cgi?id=36700

Reviewed by Darin Adler.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/invalid-import-rule-insertion.html:
  • http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt:
  • http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt:
  • http/tests/security/cross-origin-css-expected.txt:
  • http/tests/security/cross-origin-css-in-xml-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
16:29 Changeset [56672] by cjerdonek@webkit.org
  • 1 edit
    1 move in trunk/WebKitTools

Rubber-stamped by Adam Barth.

Fixed the name of a unit test file in webkitpy.

  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py.
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: Removed.
15:56 Changeset [56671] by cjerdonek@webkit.org
  • 2 edits
    3 adds in trunk/WebKitTools

2010-03-26 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

The test-webkitpy script now automatically detects all unit-test
files in webkitpy/. This lets us eliminate the need to have and
maintain all of the unittests.py files.

https://bugs.webkit.org/show_bug.cgi?id=36591

  • Scripts/test-webkitpy:
    • Replaced the "from webkitpy.unittests import *" with a call to webkitpy.test.main.Tester().run_tests().
  • Scripts/webkitpy/test/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
    • Required file for the new webkitpy/test/ directory.
  • Scripts/webkitpy/test/main.py: Added.
    • Added a Tester class that contains the following methods:
      • _find_unittest_files() to detect all the unit-test files.
      • _modules_from_paths() to convert the paths to the unit-test files to fully-qualified module names.
      • run_tests() which calls the above two methods and then passes the module names to Python's unittest module.
14:42 Changeset [56670] by joepeck@webkit.org
  • 6 edits in trunk/WebCore

2010-03-26 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Converge Inspector ids to be long, not ints
https://bugs.webkit.org/show_bug.cgi?id=36706

Part 1: Converge on long for callIds, nodeIds, and other Ids.

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
12:51 Changeset [56669] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Fix the newly-added test to not trip over a bug that causes some subsequent tests to fail.

Rubber-stamped by Dan Bernstein.

  • fast/dom/script-tests/setPrimitiveValue-exceptions.js:
12:31 Changeset [56668] by robert@webkit.org
  • 5 edits in trunk

2010-03-27 Robert Hogan <robert@webkit.org>

Reviewed by Simon Fraser.

[Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow.

https://bugs.webkit.org/show_bug.cgi?id=36701

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): Add onSetWindow. (webkit_test_plugin_destroy_instance): Add onSetWindow. (webkit_test_plugin_set_window): Add onSetWindow.
  • DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New): Add onSetWindow. (NPP_Destroy): Add onSetWindow. (NPP_SetWindow): Add onSetWindow.

2010-03-27 Robert Hogan <robert@webkit.org>

Unreviewed skip failing test.

[Qt] Skip test added in r56646. Tracked by https://bugs.webkit.org/show_bug.cgi?id=36702

https://bugs.webkit.org/show_bug.cgi?id=36701

  • platform/qt/Skipped: Add plugins/reentrant-update-widget-positions.html
12:24 Changeset [56667] by darin@apple.com
  • 2 edits in trunk/WebKit/mac
  • Misc/WebNSFileManagerExtras.m:

(-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
Removed stray "!". How did that get in there?

12:20 Changeset [56666] by darin@apple.com
  • 3 edits in trunk/WebKit/mac

WebKit NSFileManager methods don't handle broken symlinks correctly.
Part of <rdar://problem/7574046>.

Reviewed by Mark Rowe.

  • Misc/WebNSFileManagerExtras.h: Removed unused defines and methods.
  • Misc/WebNSFileManagerExtras.m: Removed unused methods.

(fileExists): Added. For use instead of fileExistsAtPath: for cases where we'd like
to treat a broken symlink as a file that does indeed exist.
(-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use fileExists.

12:17 Changeset [56665] by pfeldman@chromium.org
  • 2 edits
    1 add in trunk

2010-03-27 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: added missing test resource file.

  • inspector/resources/elements-panel-styles.css: Added.
11:24 Changeset [56664] by pfeldman@chromium.org
  • 7 edits
    2 adds in trunk

2010-03-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add layout test for styles panel.

https://bugs.webkit.org/show_bug.cgi?id=36699

Test: inspector/elements-panel-styles.html

  • inspector/front-end/inspector.css: (#elements-content): (#elements-sidebar):
  • inspector/front-end/inspector.js: (WebInspector.displayNameForURL):
  • inspector/front-end/utilities.js: (String.prototype.trimURL):
11:21 Changeset [56663] by mrowe@apple.com
  • 3 edits
    3 adds in trunk

CSSPrimitiveValue::setFloatValue/setStringValue should throw an exception if passed an incorrect unit type.
<http://webkit.org/b/36680> / <rdar://problem/7801016>

Reviewed by Darin Adler.

WebCore:

Test: fast/dom/setPrimitiveValue-exceptions.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::setFloatValue): Throw an INVALID_ACCESS_ERR if either of our type or the passed-in
type is not a numeric type.
(WebCore::CSSPrimitiveValue::setStringValue): Throw an INVALID_ACCESS_ERR if either of our type or the passed-in
type is not a string type.

LayoutTests:

  • fast/dom/script-tests/setPrimitiveValue-exceptions.js: Added.
  • fast/dom/setPrimitiveValue-exceptions-expected.txt: Added.
  • fast/dom/setPrimitiveValue-exceptions.html: Copied from LayoutTests/fast/dom/event-attribute-availability.html.
06:06 Changeset [56662] by robert@webkit.org
  • 2 edits in trunk/WebCore

2010-03-27 Robert Hogan <robert@webkit.org>

Reviewed by nobody, fix typo in previous commit.

Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',

when pluginsEnabled is false

Fix parentheses typo in r56661. This happened while rebasing and was not present
in the reviewed patch, so committing unreviewed.

https://bugs.webkit.org/attachment.cgi?id=49515

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
05:46 Changeset [56661] by robert@webkit.org
  • 18 edits in trunk

2010-03-26 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',

when pluginsEnabled is false.

The purpose of disabling plugins is to prevent the execution of third-party code
that may be untrustworthy. Qt plugins are implemented by the client rather than
loaded from an external source, so the client should have the opportunity to
consider them separately from other plugins.

Add a function MimeTypeRegistry::isApplicationPluginMIMEType() that WebKit
uses in conjunction with arePluginsEnabled() to determine if it should attempt
to load a plugin. If isApplicationPluginMIMEType() returns true, WebKit will load
the plugin even if arePluginsEnabled() is false.

Currently, only Qt has application-implemented plugins: these use the mimetype
'x-qt-plugin' and 'x-qt-styled-widget'. This patch permits Qt clients'
reimplementation of QWebPage::createPlugin() to decide whether or not
to create a Qt plugin, even when arePluginsEnabled is false.

For all platforms apart from Qt, isApplicationPluginMIMEType() returns false.

https://bugs.webkit.org/show_bug.cgi?id=32196

Test: plugins/application-plugin-plugins-disabled.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
  • platform/MIMETypeRegistry.h:
  • platform/brew/MIMETypeRegistryBrew.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/gtk/MIMETypeRegistryGtk.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/haiku/MIMETypeRegistryHaiku.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/mac/MIMETypeRegistryMac.mm: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/qt/MIMETypeRegistryQt.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/win/MIMETypeRegistryWin.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/wince/MIMETypeRegistryWince.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/wx/MimeTypeRegistryWx.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):

2010-03-26 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',

when pluginsEnabled is false.

For all platforms apart from Qt, isApplicationPluginMIMEType() returns false.

https://bugs.webkit.org/show_bug.cgi?id=32196

  • platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • plugins/application-plugin-plugins-disabled.html: Added.

2010-03-26 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',

when pluginsEnabled is false.

Add support for LayoutTestController.WebKitPluginsEnabled

https://bugs.webkit.org/show_bug.cgi?id=32196

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (copyWebSettingKey):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference):
05:36 Changeset [56660] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.
Skip HTMLProgressElement tests on Windows.

  • platform/win/Skipped:
02:06 Changeset [56659] by mitz@apple.com
  • 2 edits in trunk/WebCore

Fix Acid3 text-shadow rendering regression introduced in r56597.

Reviewed by Mark Rowe.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): Revert to using the simple shadow logic for zero-blur shadows,
except for color bitmap fonts.

03/26/10:

22:44 Changeset [56658] by abarth@webkit.org
  • 10 edits
    2 copies in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add some basic IRC commands to sheriffbot
https://bugs.webkit.org/show_bug.cgi?id=36684

Adds support for sheriffbot to respond to a "hi" command and a
"last-green-revision" command. It's lame that we're rebuilding
MultiCommandTool, but as discussed in person we'll intergrate the two
once we see what the requirements are.

  • Scripts/webkitpy/tool/bot/irc_command.py: Added.
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/unittests.py:
22:42 Changeset [56657] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Unreviewed. More errors in the IRC module. I have no idea how to test
ircbot.py, which is too bad. Hopefully we've abstracted it away enough
that we don't have to touch it very much after this patch.

  • Scripts/webkitpy/common/net/irc/ircbot.py:
22:37 Changeset [56656] by abarth@webkit.org
  • 3 edits
    1 copy in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Unreviewed. Add a missing "_".

  • Scripts/webkitpy/common/net/irc/ircproxy.py:
  • Scripts/webkitpy/common/net/irc/ircproxy_unittest.py: Added.
  • Scripts/webkitpy/common/net/irc/unittests.py:
22:08 Changeset [56655] by dbates@webkit.org
  • 7 edits
    68 adds in trunk

2010-03-26 Daniel Bates <dbates@rim.com>

Reviewed by Beth Dakin.

https://bugs.webkit.org/show_bug.cgi?id=9268

As per sections 14.2 (http://www.w3.org/TR/CSS2/colors.html#background)
and 17.5.1 (http://www.w3.org/TR/CSS2/tables.html#table-layers) of the
CSS 2.1 spec., the background-image of a table-row should span the
entire area of the table-row (i.e cover all the <td>'s). Moreover,
fixes background image painting with respect to row-groups, columns
and column-groups (*).

Currently, the background-image of a table row, row-group, and column-group
is inherited by the table cells. This directly contradicts section 14.2.
Instead, the background-image should cover the entire area of the table row,
row-group, column, or column-group, respectively as described in section 17.5.1.

(*) A follow up patch to compute the absolute content box of a column, and
column-group is needed so that background image positioning for these table
elements works. See bug #36104.

Tests: fast/table/table-background.html

fast/table/table-cell-border-draws-on-top-of-col-background.html
fast/table/table-cell-border-draws-on-top-of-col-group-background.html
fast/table/table-cell-border-draws-on-top-of-row-background.html
fast/table/table-cell-border-draws-on-top-of-row-group-background.html
fast/table/table-cell-overrides-row-background.html
fast/table/table-col-background.html
fast/table/table-col-group-background.html
fast/table/table-col-group-col-span-background.html
fast/table/table-col-group-span-background.html
fast/table/table-col-span-background.html
fast/table/table-row-background-left-50px.html
fast/table/table-row-background-right-100percent.html
fast/table/table-row-background-right-50px.html
fast/table/table-row-background.html
fast/table/table-row-group-background-positioned.html
fast/table/table-row-group-background.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Modified to call RenderObject::adjustBackgroundImagePosition.
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::adjustBackgroundImagePosition): Added.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::adjustBackgroundImagePosition): Added.
  • rendering/RenderTableCell.h:

2010-03-26 Daniel Bates <dbates@rim.com>

Reviewed by Beth Dakin.

https://bugs.webkit.org/show_bug.cgi?id=9268

Tests that background-image support for table, table-cell, table-row,
row-group, table-column and column-group (*) conform to section 17.5.1
of the CSS 2.1 spec.

(*) A follow up patch to compute the absolute content box of a column, and
column-group is needed so that background image positioning for these table
elements works. See bug #36104.

  • fast/table/table-background.html: Added.
  • fast/table/table-cell-border-draws-on-top-of-col-background.html: Added.
  • fast/table/table-cell-border-draws-on-top-of-col-group-background.html: Added.
  • fast/table/table-cell-border-draws-on-top-of-row-background.html: Added.
  • fast/table/table-cell-border-draws-on-top-of-row-group-background.html: Added.
  • fast/table/table-cell-overrides-row-background.html: Added.
  • fast/table/table-col-background.html: Added.
  • fast/table/table-col-group-background.html: Added.
  • fast/table/table-col-group-col-span-background.html: Added.
  • fast/table/table-col-group-span-background.html: Added.
  • fast/table/table-col-span-background.html: Added.
  • fast/table/table-row-background-left-50px.html: Added.
  • fast/table/table-row-background-right-100percent.html: Added.
  • fast/table/table-row-background-right-50px.html: Added.
  • fast/table/table-row-background.html: Added.
  • fast/table/table-row-group-background-positioned.html: Added.
  • fast/table/table-row-group-background.html: Added.
  • platform/mac/fast/table/table-background-expected.checksum: Added.
  • platform/mac/fast/table/table-background-expected.png: Added.
  • platform/mac/fast/table/table-background-expected.txt: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.txt: Added.
  • platform/mac/fast/table/table-col-background-expected.checksum: Added.
  • platform/mac/fast/table/table-col-background-expected.png: Added.
  • platform/mac/fast/table/table-col-background-expected.txt: Added.
  • platform/mac/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/mac/fast/table/table-col-group-background-expected.png: Added.
  • platform/mac/fast/table/table-col-group-background-expected.txt: Added.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.txt: Added.
  • platform/mac/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/mac/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/mac/fast/table/table-col-group-span-background-expected.txt: Added.
  • platform/mac/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/mac/fast/table/table-col-span-background-expected.png: Added.
  • platform/mac/fast/table/table-col-span-background-expected.txt: Added.
  • platform/mac/fast/table/table-row-background-expected.checksum: Added.
  • platform/mac/fast/table/table-row-background-expected.png: Added.
  • platform/mac/fast/table/table-row-background-expected.txt: Added.
  • platform/mac/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/mac/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/mac/fast/table/table-row-background-left-50px-expected.txt: Added.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.txt: Added.
  • platform/mac/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/mac/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/mac/fast/table/table-row-background-right-50px-expected.txt: Added.
  • platform/mac/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/mac/fast/table/table-row-group-background-expected.png: Added.
  • platform/mac/fast/table/table-row-group-background-expected.txt: Added.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.txt: Added.
22:00 Changeset [56654] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Unreviewed. Fix a the commit queue after my recent change.

  • Scripts/webkitpy/tool/bot/queueengine.py:
21:31 Changeset [56653] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebCore

2010-03-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, minor build fix.

[Gtk] Guard defined but not used function

Eliminate the "defined but not used" warning after r52684.
No new tests as there is no new functionality.

  • platform/ContextMenu.cpp:
19:38 Changeset [56652] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-26 Dirk Pranke <dpranke@chromium.org>

Unreviewed fix.

Fix the return value for port/base.diff_image (changed from 1/0 to
True/False in bug 34826.

  • Scripts/webkitpy/layout_tests/port/base.py:
19:15 Changeset [56651] by abarth@webkit.org
  • 5 edits
    2 adds in trunk

2010-03-26 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Security: iFrame.src accepts JavaScript URL via nodeValue or textContent
https://bugs.webkit.org/show_bug.cgi?id=36502

Overrode inherited nodeValue and textContent in Attr.idl so they proxy
to value, which performs a security check.

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt: Added.
  • http/tests/security/xss-DENIED-iframe-src-alias.html: Added.

2010-03-26 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Security: iFrame.src accepts JavaScript URL via nodeValue or textContent
https://bugs.webkit.org/show_bug.cgi?id=36502

Overrode inherited nodeValue and textContent in Attr.idl so they proxy
to value, which performs a security check.

Test: http/tests/security/xss-DENIED-iframe-src-alias.html

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::nodeValue): (WebCore::JSAttr::setNodeValue): (WebCore::JSAttr::textContent): (WebCore::JSAttr::setTextContent):
  • bindings/v8/custom/V8AttrCustom.cpp: (WebCore::V8Attr::nodeValueAccessorSetter): (WebCore::V8Attr::nodeValueAccessorGetter): (WebCore::V8Attr::textContentAccessorSetter): (WebCore::V8Attr::textContentAccessorGetter):
  • dom/Attr.idl:
18:20 Changeset [56650] by eric.carlson@apple.com
  • 12 edits in trunk/WebCore

2010-03-26 Eric Carlson <eric.carlson@apple.com>

<rdar://problem/7320584>
https://bugs.webkit.org/show_bug.cgi?id=36681
"new Audio()" doesn't work with plug-in backed media engine.

Don't require plug-in backed <video> and <audio> elements to be in the document to play.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_proxyWidget (WebCore::HTMLMediaElement::createRenderer): Set renderer widget if it has already been allocated. (WebCore::HTMLMediaElement::scheduleLoad): Call createMediaPlayerProxy to make sure we have a plug-in proxy. (WebCore::HTMLMediaElement::loadResource): Ditto. (WebCore::HTMLMediaElement::allocateMediaPlayerIfNecessary): Allocate media player. (WebCore::HTMLMediaElement::setMediaPlayerProxy): Call allocateMediaPlayerIfNecessary. (WebCore::HTMLMediaElement::getPluginProxyParams): New, return the url and params vectors. (WebCore::HTMLMediaElement::finishParsingChildren): Call createMediaPlayerProxy. (WebCore::HTMLMediaElement::createMediaPlayerProxy): New, allocate the proxy widget if necessary.
  • html/HTMLMediaElement.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createMediaPlayerProxyPlugin): Add declaration.
  • loader/FrameLoader.cpp: (WebCore::toPlugInElement): Don't allow an audio or video element to be cast to a plug-in element. (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): New, allocate a media player proxy plug-in.
  • loader/FrameLoader.h: Declare loadMediaPlayerProxyPlugin.
  • loader/FrameLoaderClient.h: Declare createMediaPlayerProxyPlugin.
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::updateWidget): Call loadMediaPlayerProxyPlugin when passed an audio or video node.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): Get default width and height from defaultSize. (WebCore::RenderVideo::defaultSize): New, return the spec defined default width and height.
  • rendering/RenderVideo.h:
18:11 Changeset [56649] by dpranke@chromium.org
  • 134 edits
    2 adds in trunk/LayoutTests

2010-03-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by David Levin.

Update a bunch of incorrect image checksums, and suppress all of the
remaining IMAGE failures in platform/mac/test_expectations.txt.

https://bugs.webkit.org/show_bug.cgi?id=36620

  • platform/mac-leopard/compositing/geometry/root-layer-update-expected.checksum:
  • platform/mac-leopard/compositing/overflow/overflow-positioning-expected.checksum:
  • platform/mac-leopard/compositing/repaint/become-overlay-composited-layer-expected.checksum:
  • platform/mac-leopard/compositing/repaint/layer-repaint-rects-expected.checksum:
  • platform/mac-leopard/media/video-zoom-controls-expected.checksum:
  • platform/mac/animations/3d/change-transform-in-end-event-expected.checksum:
  • platform/mac/animations/3d/state-at-end-event-transform-expected.checksum:
  • platform/mac/animations/state-at-end-event-expected.checksum:
  • platform/mac/compositing/animation/state-at-end-event-transform-layer-expected.checksum:
  • platform/mac/compositing/color-matching/pdf-image-match-expected.checksum:
  • platform/mac/compositing/compositing-visible-descendant-expected.checksum:
  • platform/mac/compositing/generated-content-expected.checksum:
  • platform/mac/compositing/geometry/abs-position-inside-opacity-expected.checksum:
  • platform/mac/compositing/geometry/fixed-position-expected.checksum:
  • platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum:
  • platform/mac/compositing/geometry/outline-change-expected.checksum:
  • platform/mac/compositing/geometry/partial-layout-update-expected.checksum:
  • platform/mac/compositing/geometry/root-layer-update-expected.checksum:
  • platform/mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum:
  • platform/mac/compositing/masks/direct-image-mask-expected.checksum:
  • platform/mac/compositing/masks/masked-ancestor-expected.checksum:
  • platform/mac/compositing/masks/multiple-masks-expected.checksum:
  • platform/mac/compositing/masks/simple-composited-mask-expected.checksum:
  • platform/mac/compositing/overflow/ancestor-overflow-expected.checksum:
  • platform/mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
  • platform/mac/compositing/overflow/overflow-positioning-expected.checksum:
  • platform/mac/compositing/overflow/parent-overflow-expected.checksum:
  • platform/mac/compositing/overflow/scrollbar-painting-expected.checksum:
  • platform/mac/compositing/reflections/reflection-in-composited-expected.checksum:
  • platform/mac/compositing/reflections/reflection-ordering-expected.checksum:
  • platform/mac/compositing/reflections/simple-composited-reflections-expected.checksum:
  • platform/mac/compositing/repaint/become-overlay-composited-layer-expected.checksum:
  • platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
  • platform/mac/compositing/repaint/layer-repaint-expected.checksum:
  • platform/mac/compositing/repaint/layer-repaint-rects-expected.checksum:
  • platform/mac/compositing/repaint/opacity-between-absolute-expected.checksum:
  • platform/mac/compositing/repaint/opacity-between-absolute2-expected.checksum:
  • platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
  • platform/mac/compositing/sibling-positioning-expected.checksum:
  • platform/mac/compositing/transitions/singular-scale-transition-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum:
  • platform/mac/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/mac/editing/deleting/type-delete-after-quote-expected.checksum:
  • platform/mac/editing/inserting/5418891-expected.checksum:
  • platform/mac/editing/selection/4960116-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac/editing/selection/extend-by-word-002-expected.checksum:
  • platform/mac/editing/selection/select-all-002-expected.checksum:
  • platform/mac/editing/selection/select-text-overflow-ellipsis-expected.checksum:
  • platform/mac/editing/selection/transformed-selection-rects-expected.checksum:
  • platform/mac/fast/backgrounds/background-clip-text-expected.checksum:
  • platform/mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.checksum:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/mac/fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-mask-expected.checksum:
  • platform/mac/fast/block/float/avoidance-percent-width-compat-expected.checksum:
  • platform/mac/fast/block/float/avoidance-percent-width-strict-expected.checksum:
  • platform/mac/fast/block/margin-collapse/103-expected.checksum:
  • platform/mac/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/mac/fast/box-shadow/transform-fringing-expected.checksum:
  • platform/mac/fast/css/apple-prefix-expected.checksum:
  • platform/mac/fast/css/color-correction-backgrounds-and-text-expected.checksum:
  • platform/mac/fast/css/color-correction-expected.checksum:
  • platform/mac/fast/css/color-correction-on-background-image-expected.checksum:
  • platform/mac/fast/css/color-correction-on-backgrounds-expected.checksum:
  • platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum:
  • platform/mac/fast/css/color-correction-on-text-expected.checksum:
  • platform/mac/fast/css/color-correction-on-text-shadow-expected.checksum:
  • platform/mac/fast/css/color-correction-untagged-images-expected.checksum:
  • platform/mac/fast/css/namespaces/namespaces-comments-expected.checksum:
  • platform/mac/fast/css/namespaces/namespaces-empty-expected.checksum:
  • platform/mac/fast/css/namespaces/namespaces-escapes-expected.checksum:
  • platform/mac/fast/css/namespaces/namespaces-invalid-at-expected.checksum:
  • platform/mac/fast/css/variables/misplaced-import-test-expected.checksum:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
  • platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum:
  • platform/mac/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum:
  • platform/mac/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum:
  • platform/mac/fast/forms/001-expected.checksum:
  • platform/mac/fast/forms/menulist-clip-expected.checksum:
  • platform/mac/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/mac/fast/forms/menulist-option-wrap-expected.checksum:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/mac/fast/forms/menulist-style-color-expected.checksum:
  • platform/mac/fast/forms/select-baseline-expected.checksum:
  • platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
  • platform/mac/fast/frames/viewsource-attribute-expected.checksum:
  • platform/mac/fast/inline/long-wrapped-line-expected.checksum:
  • platform/mac/fast/lists/anonymous-items-expected.checksum:
  • platform/mac/fast/lists/markers-in-selection-expected.checksum:
  • platform/mac/fast/multicol/client-rects-expected.checksum: Added.
  • platform/mac/fast/multicol/float-multicol-expected.checksum:
  • platform/mac/fast/overflow/line-clamp-expected.checksum:
  • platform/mac/fast/overflow/position-fixed-transform-clipping-expected.checksum:
  • platform/mac/fast/reflections/abs-position-in-reflection-expected.checksum:
  • platform/mac/fast/reflections/opacity-reflection-transform-expected.checksum:
  • platform/mac/fast/repaint/backgroundSizeRepaint-expected.checksum:
  • platform/mac/fast/repaint/box-shadow-h-expected.checksum:
  • platform/mac/fast/repaint/box-shadow-v-expected.checksum:
  • platform/mac/fast/repaint/line-in-scrolled-clipped-block-expected.checksum:
  • platform/mac/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum:
  • platform/mac/fast/repaint/rel-positioned-inline-with-overflow-expected.checksum:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum:
  • platform/mac/fast/repaint/subtree-layoutstate-transform-expected.checksum:
  • platform/mac/fast/repaint/table-outer-border-expected.checksum:
  • platform/mac/fast/table/fixed-table-with-percent-inside-percent-table-expected.checksum:
  • platform/mac/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.checksum:
  • platform/mac/fast/table/fixed-table-with-percent-width-inside-div-expected.checksum:
  • platform/mac/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.checksum:
  • platform/mac/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.checksum:
  • platform/mac/fast/table/fixed-table-with-small-percent-width-expected.checksum:
  • platform/mac/fast/text/atsui-partial-selection-expected.checksum:
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum:
  • platform/mac/fast/text/drawBidiText-expected.checksum:
  • platform/mac/fast/text/line-breaking-with-kerning-expected.checksum:
  • platform/mac/fast/text/sticky-typesetting-features-expected.checksum:
  • platform/mac/fast/transforms/shadows-expected.checksum:
  • platform/mac/http/tests/misc/slow-loading-mask-expected.checksum:
  • platform/mac/media/video-zoom-controls-expected.checksum:
  • platform/mac/plugins/embed-attributes-style-expected.checksum:
  • platform/mac/plugins/qt-qwidget-plugin-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug106158-1-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug106158-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug34176-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug6674-expected.checksum:
  • platform/mac/test_expectations.txt:
  • platform/mac/transforms/2d/transform-fixed-container-expected.checksum:
  • platform/mac/transitions/move-after-transition-expected.checksum:
  • platform/mac/transitions/transition-end-event-rendering-expected.checksum:
17:15 Changeset [56648] by dpranke@chromium.org
  • 3 edits
    1 add in trunk

2010-03-25 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Add a test_expectations.txt file for the mac platform so
new-run-webkit-tests can track IMAGE failures.

https://bugs.webkit.org/show_bug.cgi?id=36619

  • platform/mac/test_expectations.txt: Added.

2010-03-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Change the Mac port of new-run-webkit-tests to look for a
test_expectations.txt file in addition to the Skipped files, so we
can track pixel failures.

https://bugs.webkit.org/show_bug.cgi?id=36619

  • Scripts/webkitpy/layout_tests/port/mac.py:
16:38 Changeset [56647] by dpranke@chromium.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-03-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Implement pixel tests (image diff) properly on the Mac port.

This change introduces a new "ServerPocess" class that can be used
to manage processes that the run-webkit-tests harness forks off and
expects to stay up for longer than a single request/response session.
Both DumpRenderTree and ImageDiff use this style of communication,
although the current code forks off a new ImageDiff for each diff
(We need to restructure other parts of the code to be able to do this
safely in a multi-threaded environment).

Also, now that the ServerProcess abstraction exists, we can probably
clean up and simplify some of the thread management logic in
test_shell_thread as well.

https://bugs.webkit.org/show_bug.cgi?id=34826

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
15:23 Changeset [56646] by simon.fraser@apple.com
  • 7 edits
    4 adds in trunk

2010-03-26 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein, Darin Adler.

Re-entrant layout via plug-ins may cause crashes with bad RenderWidgets
https://bugs.webkit.org/show_bug.cgi?id=36675
<rdar://problem/7787617>

Fix two places in the code where RenderWidgets can get destroyed while being iterated over.
This can happen when plug-ins execute script from NPP_SetWindow, and that script makes a change
to the page that destroys a RenderWidget.

Tests: plugins/reentrant-update-widget-positions.html

plugins/update-widgets-crash.html

  • page/FrameView.cpp: (WebCore::FrameView::updateWidgets): ref() the RenderEmbeddedObjects that are put into the vector before iterating of them, and deref() them at the end. Rather than checking the m_widgetUpdateSet to see if the RenderWidget is still live, test object->node().
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): Initialize some data members to make it more obvious in the debugger that the object is not garbage. (WebCore::RenderView::updateWidgetPositions): Use a Vector of RenderWidget* to keep the RenderWidgets alive during iteration, by reffing and dereffing them.
  • rendering/RenderWidget.h: (WebCore::RenderWidget::ref): Make this and deref() public.
15:16 Changeset [56645] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-26 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Print didFinishLoadForFrame outcome in DRT

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadCommitted):
15:12 Changeset [56644] by bdakin@apple.com
  • 4 edits in trunk

WebCore: Partial fix for https://bugs.webkit.org/show_bug.cgi?id=36564
Performance regression for setting content of <text> in SVG
-and corresponding-
<rdar://problem/7693963>

Reviewed by Darin Adler.

toClipPath() is extremely inefficient, so this patch removes the
call to it from RenderSVGResourceClipper::resourceBoundingBox()
which is very hot code in SVG with clip-paths. It is sufficient to
call unite with the objectBoundingBox(), which will return early if
objectBoundingBox() is empty.

  • rendering/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::resourceBoundingBox):

LayoutTests: Updated test for https://bugs.webkit.org/show_bug.cgi?id=36564
Performance regression for setting content of <text> in SVG
-and corresponding-
<rdar://problem/7693963>

Reviewed by Darin Adler.

  • platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
14:51 Changeset [56643] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-26 Eric Seidel <eric@webkit.org>

Unreviewed test fix.
My change conflicted with one of Adam's causing test-webkitpy to fail.

Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629

  • Scripts/webkitpy/common/checkout/api_unittest.py:
    • modified_changelogs is now on Checkout instead of scm.
14:45 Changeset [56642] by abarth@webkit.org
  • 7 edits
    1 copy
    1 add in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Refactor IRCBot controller logic to allow for commands
https://bugs.webkit.org/show_bug.cgi?id=36676

We need to move the controller logic into the tool package so it can
know about commands. The changes to queueengine could go in a
different patch, but we're going to need it anyway.

  • Scripts/webkitpy/common/config/irc.py: Added.
  • Scripts/webkitpy/common/net/irc/ircbot.py:
  • Scripts/webkitpy/common/net/irc/ircproxy.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot.py: Added.
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
13:44 Changeset [56641] by joepeck@webkit.org
  • 3 edits
    6 adds in trunk

2010-03-26 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Dave Hyatt.

Generated run-in Content is Mistakenly Getting Deleted
https://bugs.webkit.org/show_bug.cgi?id=36505
<rdar://problem/7767161>

Test: fast/runin/generated2.html
Test: fast/runin/generated3.html
Test: fast/runin/generated4.html

Do not destroy :before/:after generated content with display run-in
when relaying out different nodes. Have their real owners correctly
handle them.

  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent): simplified logic (WebCore::RenderObjectChildList::beforeAfterContainer): skip generated run-ins when checking children, check for them in grandchildren

2010-03-26 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Dave Hyatt.

Generated run-in Content is Mistakenly Getting Deleted
https://bugs.webkit.org/show_bug.cgi?id=36505
<rdar://problem/7767161>

Test dynamic update of the inner block, containing the generated
run-in, but not owning it with the :before rule, and owners.

  • fast/runin/generated2.html: Added.
  • platform/mac/fast/runin/generated2-expected.txt: Added.

Test dynamic update of the outer block, this block owns the
generated run-in, but it is actually contained in a child block.

  • fast/runin/generated3.html: Added.
  • platform/mac/fast/runin/generated3-expected.txt: Added.

Test dynamic updates affecting generated run-ins both
in relation to and not in relation to list markers.

  • fast/runin/generated4.html: Added.
  • platform/mac/fast/runin/generated4-expected.txt: Added.
13:22 Changeset [56640] by abarth@webkit.org
  • 5 edits
    4 moves
    3 adds in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

Move the threading code into its own module. (It has nothing to do with IRC.)

  • Scripts/webkitpy/common/net/irc/ircbot.py:
  • Scripts/webkitpy/common/net/irc/ircproxy.py:
  • Scripts/webkitpy/common/net/irc/messagepump.py: Removed.
  • Scripts/webkitpy/common/net/irc/messagepump_unittest.py: Removed.
  • Scripts/webkitpy/common/net/irc/threadedmessagequeue.py: Removed.
  • Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: Removed.
  • Scripts/webkitpy/common/net/irc/unittests.py:
  • Scripts/webkitpy/common/thread: Added.
  • Scripts/webkitpy/common/thread/init.py: Added.
  • Scripts/webkitpy/common/thread/messagepump.py: Copied from Scripts/webkitpy/common/net/irc/messagepump.py.
  • Scripts/webkitpy/common/thread/messagepump_unittest.py: Copied from Scripts/webkitpy/common/net/irc/messagepump_unittest.py.
  • Scripts/webkitpy/common/thread/threadedmessagequeue.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue.py.
  • Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py.
  • Scripts/webkitpy/common/thread/unittests.py: Added.
  • Scripts/webkitpy/common/unittests.py:
13:19 Changeset [56639] by ojan@chromium.org
  • 8 edits in trunk

2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

shift+home/end and cmd+shift+left/right don't extend the selection correctly
https://bugs.webkit.org/show_bug.cgi?id=36539

  • editing/selection/extend-after-mouse-selection.html:
  • editing/selection/extend-selection-expected.txt: Extending forward by lineboundary selects the whole line. Now extending backwards by lineboundary after the whole line is selected is a noop instead of collapsed the selection to the start.
  • editing/selection/move-begin-end.html: Just cleaned up this test.
  • platform/mac/editing/selection/extend-after-mouse-selection-expected.txt:

2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

shift+home/end and cmd+shift+left/right don't extend the selection correctly
https://bugs.webkit.org/show_bug.cgi?id=36539

  • WebCore.base.exp:
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify):
  • editing/SelectionController.h:
12:47 Changeset [56638] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-03-26 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629

Finally add some basic unit testing for Checkout.commit_message_for_this_commit

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py: Added.
  • Scripts/webkitpy/common/unittests.py:
12:40 Changeset [56637] by jhawkins@chromium.org
  • 8 edits
    4 adds in trunk/WebKit/chromium

2010-03-24 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement WebFormControlElement and WebSelectElement. Add
a getFormControlElements method to WebFormElement.

https://bugs.webkit.org/show_bug.cgi?id=36562

  • WebKit.gyp:
  • public/WebElement.h:
  • public/WebFormControlElement.h: Added.
  • public/WebFormElement.h:
  • public/WebInputElement.h: (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::assign):
  • public/WebSelectElement.h: Added.
  • src/WebElement.cpp: (WebKit::WebElement::isFormControlElement):
  • src/WebFormControlElement.cpp: Added.
  • src/WebFormElement.cpp: (WebKit::WebFormElement::getFormControlElements):
  • src/WebInputElement.cpp: (WebKit::WebInputElement::WebInputElement):
  • src/WebSelectElement.cpp: Added.
12:30 Changeset [56636] by tonikitoo@webkit.org
  • 5 edits
    2 adds in trunk/WebKitTools

User Agent Switcher on QtLauncher https://bugs.webkit.org/show_bug.cgi?id=36451

Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-26
Reviewed by Simon Hausmann.

Make possible to change the QtLauncher user agent via
a predefined list.

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/QtLauncher.qrc: Added.
  • QtLauncher/main.cpp:

(LauncherWindow::showUserAgentDialog):
(LauncherWindow::createChrome):

  • QtLauncher/useragentlist.txt: Added.
  • QtLauncher/webpage.cpp:

(WebPage::userAgentForUrl):

  • QtLauncher/webpage.h:

(WebPage::setUserAgent):

11:21 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
11:14 Changeset [56635] by eric@webkit.org
  • 9 edits
    4 adds in trunk/WebKitTools

2010-03-26 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

Host layout test flakiness dashboard in TestResultServer appengine.

Flakiness dashboard is a tool to monitor layout test status and
help layout test regression diagnostics.

https://bugs.webkit.org/show_bug.cgi?id=36195

  • TestResultServer/handlers/dashboardhandler.py: Added.
    • New handler to handle dashboard request
  • TestResultServer/handlers/menu.py:
    • Add new dashboard links
  • TestResultServer/handlers/testfilehandler.py:
    • Request routes refactory
  • TestResultServer/index.yaml:
  • TestResultServer/main.py:
    • Add new dashboard request routes and refactor test result file rountes.
  • TestResultServer/model/dashboardfile.py: Added.
    • Model to access datastore for dashboard files
  • TestResultServer/model/testfile.py:
  • TestResultServer/stylesheets/dashboardfile.css: Added.
  • TestResultServer/templates/dashboardfilelist.html: Added.
  • TestResultServer/templates/showfilelist.html:
11:06 Changeset [56634] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Add fast/multicol/hit-test-above-or-below.html, this is failing in the same way as Qt, and is being
tracked by the same bug (https://bugs.webkit.org/show_bug.cgi?id=35973).

  • platform/win/Skipped:
10:38 Changeset [56633] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Nate Chapin.

[chromium] Updated test expectations due to recent failures,
added bugs, etc.

  • platform/chromium/test_expectations.txt:
10:37 FastMalloc Glossary created by ggaren@apple.com
10:32 Changeset [56632] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-03-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove some evil statics from CommitInfo
https://bugs.webkit.org/show_bug.cgi?id=36637

These methods should really be on checkout. You can tell because they
know about ChangeLogs and take an SCM as an argument. :)

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/commitinfo.py:
  • Scripts/webkitpy/tool/commands/queries.py:
10:32 WikiStart edited by ggaren@apple.com
(diff)
10:29 WikiStart edited by ggaren@apple.com
(diff)
10:04 Changeset [56631] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-26 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Laszlo Gombos.

Don't undefine SKIP_STATIC_CONSTRUCTORS_ON_GCC for Symbian HW targets.
https://bugs.webkit.org/show_bug.cgi?id=34081

Defining StringImpl instances as globals will cause a crash on process exit as
StringImpl::Remove expects TLS which was already deleted at time of exiting main and ends up
constructing one exiting thread.

  • config.h:
09:34 Changeset [56630] by eric@webkit.org
  • 8 edits in trunk

2010-03-26 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Send worker resource content to inspector to enable display of web
workers in inspector's resource tab.
https://bugs.webkit.org/show_bug.cgi?id=36658

  • inspector/InspectorController.cpp: (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported):
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::type): (WebCore::InspectorResource::setOverrideContent): (WebCore::InspectorResource::sourceString):
  • inspector/InspectorResource.h:
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished):
  • workers/Worker.cpp: (WebCore::Worker::notifyFinished):

2010-03-26 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Send worker resource content to inspector to enable display of web
workers in inspector's resource tab.
https://bugs.webkit.org/show_bug.cgi?id=36658

  • src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished):
08:42 Changeset [56629] by yael.aharon@nokia.com
  • 10 edits in trunk

WebCore: Fix the rendering of HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36206

Reviewed by Antti Koivisto.

Update the rendering and css to conform to
http://www.whatwg.org/specs/web-apps/current-work/complete.html#the-progress-element-0.
Updated the tests and the expected results accordingly.

  • css/html.css:
  • rendering/RenderProgress.cpp:
  • rendering/RenderProgress.h:

LayoutTests: Fix the rendering of HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36206
Add dir=rtl test and update the expected results.

Reviewed by Antti Koivisto.

  • fast/dom/HTMLProgressElement/progress-element.html:
  • platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
  • platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt:
08:30 Changeset [56628] by jchaffraix@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build fix.

FontPlatformDataPango.cpp: prototype for
'WebCore::FontPlatformData::FontPlatformData(cairo_font_face_t*, int, bool, bool)'
does not match any in class
https://bugs.webkit.org/show_bug.cgi?id=36496

  • platform/graphics/gtk/FontPlatformDataPango.cpp:

(WebCore::FontPlatformData::FontPlatformData): The 'size' parameter
should be a float to match the declaration and the other definitions.

08:22 Changeset [56627] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-26 Shu Chang <chang.shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Prevent referring d->m_job in the future because calling abort()
deletes the instance itself.
https://bugs.webkit.org/show_bug.cgi?id=36618

Test: http/tests/appcache/fallback.html

  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::cancel):
07:49 QtWebKit edited by zoltan@webkit.org
(diff)
07:37 Changeset [56626] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Compile with QT_USE_FAST_OPERATOR_PLUS

Patch by Olivier Goffart <ogoffart@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorClientQt::populateSetting):
(WebCore::InspectorClientQt::storeSetting):

07:35 Changeset [56625] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Doc: Simplified Commercial Editions for Qt 4.7.

Patch by David Boddie <dboddie@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.

  • docs/qtwebkit.qdoc:
07:26 Changeset [56624] by senorblanco@chromium.org
  • 4 edits
    2 deletes in trunk

2010-03-26 Stephen White <senorblanco@chromium.org>

Unreviewed; build fix.

Rolling out 56620; too many layout test failures.

Covered by fast/css/*.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):

2010-03-26 Stephen White <senorblanco@chromium.org>

Unreviewed; build fix.

Rolling out 56620; too many layout test failures.

  • fast/css/cssText-cache-expected.txt: Removed.
  • fast/css/cssText-cache.html: Removed.
07:05 Changeset [56623] by hausmann@webkit.org
  • 9 edits in trunk

[Qt] Build JavaScriptCore as a static library.
https://bugs.webkit.org/show_bug.cgi?id=36590

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-03-26
Reviewed by Simon Hausmann.

This patch takes what was left of the unused JavaScriptCore.pro
and moved the compilation logic from JavaScriptCore.pri to
JavaScriptCore.pro.

.:

  • WebKit.pro:

JavaScriptCore:

WebCore:

  • WebCore.pro:
06:44 Changeset [56622] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix compilation on Windows

Patch by Olivier Goffart <ogoffart@trolltech.com> on 2010-03-26
Reviewed by Simon Hausmann.

For some reason, the MSVC compiler choose the
operator+(const QString &, const QString &) instead of
operator+(const WebCore::String &, const WebCore::String &)
resulting in errors when QT_USE_FAST_OPERATOR_PLUS is used.

  • dom/XMLTokenizerQt.cpp:

(WebCore::handleElementNamespaces):

06:28 Changeset [56621] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-26 Philippe Normand <pnormand@igalia.com>

fast/parser/xml-declaration-missing-ending-mark.html crashed on Gtk bot
https://bugs.webkit.org/show_bug.cgi?id=33027

Skipping test that fails on GTK+ Debug bots.

  • platform/gtk/Skipped:
06:18 Changeset [56620] by senorblanco@chromium.org
  • 4 edits
    2 adds in trunk

2010-03-24 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Adler.

In order to speed up multiple calls to CSSPrimitiveValue::cssText(),
this CL caches the String result. When m_value is changed, the
cached string is cleared. This gives a good speedup on benchmarks
which do a lot of CSS property gets, such as Peacekeeper.
The processing cost should be negligible, since the strings are
refcounted. The memory cost is an additional 4 bytes per
CSSPrimitiveValue, and the extended lifetime of the computed string
(potentially, the same as the lifetime of the CSSPrimitiveValue).

https://bugs.webkit.org/show_bug.cgi?id=36556

Covered by fast/css/large-number-round-trip.html, and more.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h:

2010-03-25 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Adler.

Added a test for CSSPrimitiveValue::cssText() string cacheing.

https://bugs.webkit.org/show_bug.cgi?id=36556

  • fast/css/cssText-cache-expected.txt: Added.
  • fast/css/cssText-cache.html: Added.
05:58 Changeset [56619] by eric@webkit.org
  • 4 edits in trunk

2010-03-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/canvas/drawImage-with-negative-source-destination.html failed
https://bugs.webkit.org/show_bug.cgi?id=35005

Enable fast/canvas/drawImage-with-negative-source-destination.html

  • platform/qt/Skipped:

2010-03-26 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] fast/canvas/drawImage-with-negative-source-destination.html failed
https://bugs.webkit.org/show_bug.cgi?id=35005

To support negative width or height at context.drawImage

  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
05:52 Changeset [56618] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

Reviewed by Simon Hausmann.

Add an option to QtLauncher to enable/disable a QGLWidget as Viewport
of the QGraphicsView when the launcher is running on graphicsview mode.

[Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as Viewport
https://bugs.webkit.org/show_bug.cgi?id=36270

  • QtLauncher/QtLauncher.pro:
  • QtLauncher/main.cpp:

(LauncherWindow::toggleQGLWidgetViewport):
(LauncherWindow::createChrome):

04:11 Changeset [56617] by ager@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-26 Mads Ager <ager@chromium.org>

Reviewed by Jeremy Orlow.

Tweak Chromium test expectations
https://bugs.webkit.org/show_bug.cgi?id=36651

fast/js/large-expressions.html started failing on Linux in release
mode occassionally. Also fails on other platforms.

  • platform/chromium/test_expectations.txt:
02:21 Changeset [56616] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, removing websocket/tests/long-invalid-header.html from Chromium test_expectations.txt

  • platform/chromium/test_expectations.txt: remove websocket/tests/long-invalid-header.html
01:58 Changeset [56615] by philn@webkit.org
  • 2 edits in trunk/WebCore

2010-03-08 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GStreamer] soften dependency on libsoup in the http src element
https://bugs.webkit.org/show_bug.cgi?id=35864

Replaced SoupURI calls with KURL and pause/resume internal soup
messages only if the element is compiled for a port depending on
libsoup.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webkit_web_src_init): (webKitWebSrcSetUri): (webKitWebSrcNeedDataMainCb): (webKitWebSrcEnoughDataMainCb):
01:45 Changeset [56614] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-26 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

[Chromium-Win] websocket_server.py failed to start
https://bugs.webkit.org/show_bug.cgi?id=36586

subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
We don't need stdin, so use devnull as stdin.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin
01:05 Changeset [56613] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-03-25 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Shot record filter is implemented in Timeline Panel.
https://bugs.webkit.org/show_bug.cgi?id=36606

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord.prototype.get _isLongEvent):
  • inspector/front-end/inspector.css:
00:58 Changeset [56612] by tkent@chromium.org
  • 1 edit
    2 adds in trunk/WebKitTools

2010-03-26 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add TestNavigationController and TestWebWorker
https://bugs.webkit.org/show_bug.cgi?id=36520

Add LayoutTestController class, which is going to be used by
DumpRenderTree Chromium port. These files are based on:

  • src/webkit/tools/test_shell/layout_test_controller.cc
  • src/webkit/tools/test_shell/layout_test_controller.h of Chromium rev.40492.
  • DumpRenderTree/chromium/LayoutTestController.cpp: Added.
  • DumpRenderTree/chromium/LayoutTestController.h: Added.
00:55 Changeset [56611] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with new exports used by QtLauncher.

  • symbian/eabi/QtWebKitu.def:
00:43 Changeset [56610] by tkent@chromium.org
  • 3 edits in trunk/WebCore

Rollout r56609. It was accidental commit.

00:34 Changeset [56609] by tkent@chromium.org
  • 3 edits in trunk/WebCore

2009-10-20 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: populate child nodes before sorting them.

https://bugs.webkit.org/show_bug.cgi?id=29673

  • inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode): Swapped with BottomUpProfileDataGridTree to be consistent with TopDownProfileDataGridNode. (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate): (WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
  • inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.sort): Added missing parentheses. (WebInspector.ProfileDataGridNode.prototype.get _parent): (WebInspector.ProfileDataGridNode.prototype._populate):
  • inspector/front-end/TopDownProfileDataGridTree.js: (WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
00:13 Changeset [56608] by pfeldman@chromium.org
  • 10 edits in trunk/WebCore

2010-03-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Implement CSSStyleSelector::pseudoStyleForElement and use it in the InspectorDOMAgent.

https://bugs.webkit.org/show_bug.cgi?id=36509

This change provides pseudo elements information into the inspector styles sidebar pane.
Changes applied:

  • CSSStyleSelector::pseudoStyleRulesForElement implemented. I changed the signature to accept PseudoId instead of a String since it better reflected the needs;
  • Accompanied elementStyle checks with m_collectRulesOnly checks;
  • Removed pseudoStyleRulesForElement usage from DOMWindow::getMatchedCSSRules. It was anyways returning 0, while I would need to convert String to PseudoId in order to leave the call in place;
  • Needed to introduce AFTER_LAST_INTERNAL_PSEUDOID marker const in RenderStyleConstants' PseudoId enum
  • InspectorDOMAgent is now iterating over all pseudo ids to get all styles (including internal ones).
  • Brushed up front-end code so that proper overriding took place locally within pseudo id categories.
  • English.lproj/localizedStrings.js:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • css/CSSStyleSelector.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::buildObjectForAttributeStyles): (WebCore::InspectorDOMAgent::buildArrayForCSSRules): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.callback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.insertInheritedNodeSeparator): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules): (WebInspector.StylesSidebarPane.prototype._markUsedProperties): (WebInspector.StylesSidebarPane.prototype._refreshSectionsForStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.StylesSidebarPane.prototype._changeColorFormat): (WebInspector.StylesSidebarPane.prototype.addBlankSection): (WebInspector.StylesSidebarPane.prototype.removeSection):
  • inspector/front-end/inspector.css: (.styles-sidebar-separator):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::getMatchedCSSRules):
  • rendering/style/RenderStyleConstants.h: (WebCore::):
00:11 Changeset [56607] by mrowe@apple.com
  • 7 edits in trunk/WebKitLibraries

Update WebCoreSQLite3 to SQLite v3.6.12.

Rubber-stamped by Dan Bernstein.

  • WebCoreSQLite3/sqlite3.h:
  • WebCoreSQLite3/sqlite3ext.h:
  • libWebCoreSQLite3.a:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

03/25/10:

23:34 Changeset [56606] by abarth@webkit.org
  • 12 edits
    1 move
    2 adds
    1 delete in trunk

2010-03-25 Charlie Reis <creis@chromium.org>

Reviewed by Adam Barth.

onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481

Adds a layout test for bug 27481. Requires calling shouldClose on
the WebView, which is done with a new method on LayoutTestController.

  • fast/events/onbeforeunload-focused-iframe-expected.txt: Added.
  • fast/events/onbeforeunload-focused-iframe.html: Added.
  • fast/events/resources/onbeforeunload-focused-iframe-frame.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-03-25 Charlie Reis <creis@chromium.org>

Reviewed by Adam Barth.

onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481

Test: fast/events/onbeforeunload-focused-iframe.html

Replaces initial manual tests with a layout test.

  • manual-tests/onbeforeunload-focused-iframe.html: Removed.
  • manual-tests/resources/focused-iframe.html: Removed.

2010-03-25 Charlie Reis <creis@chromium.org>

Reviewed by Adam Barth.

onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481

Adds a callShouldCloseOnWebView method to LayoutTestController,
to allow automated testing for bug 27481.

  • DumpRenderTree/LayoutTestController.cpp: (callShouldCloseOnWebViewCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::callShouldCloseOnWebView):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::callShouldCloseOnWebView):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::callShouldCloseOnWebView):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::callShouldCloseOnWebView):
23:23 Changeset [56605] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION: plugins/netscape-construct.html and plugins/mouse-events-fixedpos.html failing on Snow Leopard Bot
https://bugs.webkit.org/show_bug.cgi?id=36462

Adding tests to the Skipped list per Alexey's recommendation
until someone from Apple can update the version of Safari
on the Snow Leopard bot.

  • platform/mac-snowleopard/Skipped:
23:06 Changeset [56604] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-25 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Missing lock in call to doneCreatingDatabase
https://bugs.webkit.org/show_bug.cgi?id=36473

Added new test storage/open-database-over-quota.html.

  • storage/open-database-over-quota.html: Added.
  • storage/open-database-over-quota-expected.txt: Added.

2010-03-25 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Missing lock in call to doneCreatingDatabase
https://bugs.webkit.org/show_bug.cgi?id=36473

Added new test storage/open-database-over-quota.html.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): Added missing lock call.
22:48 Changeset [56603] by eric@webkit.org
  • 5 edits in trunk

2010-03-25 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] correctly handle move drag operations
https://bugs.webkit.org/show_bug.cgi?id=36484

  • platform/chromium/test_expectations.txt:

2010-03-25 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] correctly handle move drag operations
https://bugs.webkit.org/show_bug.cgi?id=36484

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnter): (WebKit::WebViewImpl::dragTargetDragOver): (WebKit::WebViewImpl::dragTargetDragEnterOrOver): Combine common code into a helper method

and properly mask against the drag effect.

(WebKit::WebViewImpl::createUniqueIdentifierForRequest):

  • src/WebViewImpl.h:
22:42 Changeset [56602] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add webkit-patch lkgr for finding last known good revision
https://bugs.webkit.org/show_bug.cgi?id=36626

This is rather slow for now because the command
has to compute this information from the buildbot.
A better long-term solution would be to have a server
somewhere store a pre-computed LKGR and then any
script (like webkit-patch) could just fetch it.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/tool/commands/queries.py:
22:38 Changeset [56601] by abarth@webkit.org
  • 10 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move modified_changelogs (and friends) from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36636

These functions know about ChangeLogs, which is forbidden knowledge in
scm.py.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/revertrevision.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
22:32 Changeset [56600] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move apply_patch from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36635

SCM shouldn't have any knowledge of WebKit scripts.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/applypatch.py:
21:48 Changeset [56599] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-25 Eric Seidel <eric@webkit.org>

Unreviewed build fix to un-break webkit-patch land.
Test-case coming in follow-up commit.

Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629

  • Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage
21:40 Changeset [56598] by ojan@chromium.org
  • 4 edits in trunk

WebCore:
2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[chromium] REGRESSION: Some LayoutTests fail after r56567
https://bugs.webkit.org/show_bug.cgi?id=36630

Fix boolean logic goofup. This was a last minute code review
change that didn't get tested on Windows before commit.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setIsDirectional):

LayoutTests:
2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[chromium] REGRESSION: Some LayoutTests fail after r56567
https://bugs.webkit.org/show_bug.cgi?id=36630

  • platform/chromium/test_expectations.txt:
21:35 Changeset [56597] by mitz@apple.com
  • 11 edits
    1 copy
    5 adds in trunk

<rdar://problem/7728903> Support color bitmap fonts

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/fonts/color-bitmap.html

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances): Added. Calls CGContextShowGlyphsWithAdvances()
or CTFontShowGlyphs() depending on whether the font is a color bitmap font.
(WebCore::Font::drawGlyphs): Use showGlyphsWithAdvances(). Don’t include the font’s matrix in
the context’s text matrix when drawing with a color bitmap font, because CTFontShowGlyphs()
factors it in.

  • platform/graphics/mac/FontPlatformData.h:

(WebCore::FontPlatformData::FontPlatformData): Added m_isColorBitmapFont member
and initialized it in constructors.
(WebCore::FontPlatformData::isColorBitmapFont): Added this getter.

  • platform/graphics/mac/FontPlatformDataMac.mm:

(WebCore::FontPlatformData::FontPlatformData): Initialize m_isColorBitmapFont.
(WebCore::FontPlatformData::operator=): Copy m_isColorBitmapFont.
(WebCore::FontPlatformData::setFont): Set m_isColorBitmapFont.

WebKitTools:

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf

and ColorBits-A.png.

  • DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
  • DumpRenderTree/fonts/ColorBits.ttf: Added.
  • DumpRenderTree/mac/DumpRenderTree.mm:

(activateFonts): Activate ColorBits.ttf.

LayoutTests:

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/fonts/color-bitmap-expected.checksum: Added.
  • platform/mac/fonts/color-bitmap-expected.png: Added.
  • platform/mac/fonts/color-bitmap-expected.txt: Added.
  • platform/mac/fonts/color-bitmap.html: Added.
21:28 Changeset [56596] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, another attempt to unblock Chromium Win test bot.

  • platform/chromium/test_expectations.txt:
21:23 Changeset [56595] by dimich@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, removing stale expectation file for Chromium.

The test was updated by http://trac.webkit.org/changeset/56506 to a script test.

  • platform/chromium-win/editing/inserting/6633727-expected.txt: Removed.
21:13 Changeset [56594] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, temporarily disabling test on Chromium bots.

http://crbug.com/39423

  • platform/chromium/test_expectations.txt:
20:04 Changeset [56593] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Remove a printf that was causing commit-log-editor to spew the name of the editor
to the terminal many times during a commit.

  • Scripts/commit-log-editor:
20:04 Changeset [56592] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move commit_message_for_this_commit from scm to checkout
https://bugs.webkit.org/show_bug.cgi?id=36629

This function requires knowledge of ChangeLogs, but scm shouldn't know
about ChangeLogs.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
  • Scripts/webkitpy/tool/steps/commit.py:
19:46 Changeset [56591] by eric@webkit.org
  • 7 edits
    20 adds in trunk

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Implement allow-top-navigation for HTML5 sandbox attribute
https://bugs.webkit.org/show_bug.cgi?id=36549

Test various cases relating to navigating top level frames and the
allow-top-navigation directive. This feature is tricky to test
exhaustively because there are a lot of permutations.

  • fast/frames/resources/fail-and-notify-done.html: Added.
  • fast/frames/resources/navigate-top-by-constant-name-to-pass.html: Added.
  • fast/frames/resources/navigate-top-by-constant-name2-to-pass.html: Added.
  • fast/frames/resources/navigate-top-by-name-to-fail.html: Added.
  • fast/frames/resources/navigate-top-by-name-to-pass.html: Added.
  • fast/frames/resources/navigate-top-to-fail.html: Added.
  • fast/frames/resources/navigate-top-to-pass.html: Added.
  • fast/frames/resources/pass-and-notify-done.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-name-denied-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-name-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top-by-name.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-denied-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top-denied.html: Added.
  • fast/frames/sandboxed-iframe-navigation-top-expected.txt: Added.
  • fast/frames/sandboxed-iframe-navigation-top.html: Added.

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Implement allow-top-navigation for HTML5 sandbox attribute
https://bugs.webkit.org/show_bug.cgi?id=36549

Tests: fast/frames/sandboxed-iframe-navigation-top-by-constant-name.html

fast/frames/sandboxed-iframe-navigation-top-by-constant-name2.html
fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html
fast/frames/sandboxed-iframe-navigation-top-by-name.html
fast/frames/sandboxed-iframe-navigation-top-denied.html
fast/frames/sandboxed-iframe-navigation-top.html

  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): Moved the security check to FrameLoader because we need to allow window.open navigation to succeed sometimes when the SandboxNavigation bit is set.
  • html/HTMLIFrameElement.cpp: (WebCore::parseSandboxAttribute): Added allow-top-navigation to the parser.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): The SandboxNavigation check now occurs after we search for the frame by name. Notice that the named frame navigation case is caught by the generic navigation access check. (WebCore::FrameLoader::shouldAllowNavigation): Update the navigation access check to allow navigating of top unless it's forbidden.
  • loader/FrameLoaderTypes.h: Introduce a bit for SandboxedTopNavigation. (WebCore::):
19:32 Changeset [56590] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): Re-fetch host proxy in a way that works in a function that doesn't have a pluginID argument for some reason.
19:21 Changeset [56589] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: webkit-patch land can't land "rubber-stamped" patches
https://bugs.webkit.org/show_bug.cgi?id=36582

Allow a "-" in rubber stamped.

  • Scripts/webkitpy/tool/steps/validatereviewer.py:
19:12 Changeset [56588] by dumi@chromium.org
  • 5 edits in trunk

Unreviewed, Chromium build fix.

WebCore:

V8CustomVoidCallback should not check if a return value is a
boolean. It should only convert the value to a boolean.

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

LayoutTests:

Update the expectations for statement-error-callback.html for Chromium.

  • platform/chromium-mac/storage/statement-error-callback-expected.txt:
  • platform/chromium-win/storage/statement-error-callback-expected.txt:
18:48 Changeset [56587] by dimich@chromium.org
  • 4 edits in trunk/WebCore

Revert "2010-03-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>"

This reverts commit 2a3b308efc33f4829fe9717d93a4b245d3b25f6d.

18:26 Changeset [56586] by abarth@webkit.org
  • 14 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Fix some copyright lines to remove extraneous comma and
python directive.

  • Scripts/webkitpy/tool/bot/patchcollection.py:
  • Scripts/webkitpy/tool/bot/patchcollection_unittest.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/comments.py:
  • Scripts/webkitpy/tool/grammar.py:
  • Scripts/webkitpy/tool/multicommandtool.py:
  • Scripts/webkitpy/tool/multicommandtool_unittest.py:
18:04 Changeset [56585] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Fix build if NPAPI support is disabled
https://bugs.webkit.org/show_bug.cgi?id=36621

No new tests, this is a build fix.

  • plugins/PluginView.cpp: Guard getValueStatic() with NETSCAPE_PLUGIN_API (WebCore::PluginView::getValue):
  • plugins/PluginView.h: Guard getValue() with NETSCAPE_PLUGIN_API
  • plugins/PluginViewNone.cpp: Guard platformGetValue() and platformGetValueStatic with NETSCAPE_PLUGIN_API; Guard privateBrowsingStateChanged() and setJavaScriptPaused() with PLATFORM(MAC)
17:53 Changeset [56584] by dimich@chromium.org
  • 6 edits in trunk/LayoutTests

Not reviewed, update pixel results for Chromium bots.

The rendering of these tests was changed by http://trac.webkit.org/changeset/56507.
Also updated Chromium's test_expectations.txt.

  • platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum:
  • platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
  • platform/chromium/test_expectations.txt: Use BUG_WKXXXX instead of WKXXXX notation to appease validation on the bot.
17:46 Changeset [56583] by simon.fraser@apple.com
  • 4 edits in trunk/WebKitTools

2010-03-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler, Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=36631
Allow the test plugin to run scripts in response to NPP_SetWindow calls

Hook up the ability for the TestNetscapePlugIn to run JavaScript in
response to NPP_SetWindow.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_Destroy): (NPP_SetWindow):
17:26 Changeset [56582] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing Chromium test bots.

[chromium] REGRESSION: Some LayoutTests fail after r56567
https://bugs.webkit.org/show_bug.cgi?id=36630

  • platform/chromium/test_expectations.txt: Update expectations.
17:24 Changeset [56581] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-03-25 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher crashes on Mac OS and Linux when exiting with QGraphicsView mode enabled
https://bugs.webkit.org/show_bug.cgi?id=35251

Followed the way QWebView registers for the signal QWebPage::destroyed(), to prevent
QGraphicsWebView from referencing QWebPage after it was deleted.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_pageDestroyed): (QGraphicsWebView::setPage):
  • Api/qgraphicswebview.h:
17:06 Changeset [56580] by eric@webkit.org
  • 9 edits in trunk

2010-03-25 Drew Wilson <atwilson@chromium.org>

Reviewed by Nate Chapin.

[v8] Error in getScriptExecutionContext() when worker context is terminating.
https://bugs.webkit.org/show_bug.cgi?id=36565

Removed WorkerScriptExecutionProxy::retrieve() and added WorkerScriptController::controllerForContext(). This allows
callers to differentiate between "the current context is shutting down" vs "the current context is not a worker context".

Test: Existing worker tests suffice.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
  • bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
  • bindings/v8/WorkerContextExecutionProxy.cpp: Removed WorkerScriptExecutionProxy::retrieve().
  • bindings/v8/WorkerContextExecutionProxy.h: Removed WorkerScriptExecutionProxy::retrieve().
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::controllerForContext): Added helper function to get the WorkerScriptController for the current context.
  • bindings/v8/WorkerScriptController.h: Added declaration for controllerForContext().

2010-03-25 Drew Wilson <atwilson@chromium.org>

Reviewed by Nate Chapin.

[v8] Error in getScriptExecutionContext() when worker context is terminating
https://bugs.webkit.org/show_bug.cgi?id=36565

Test: Existing worker tests suffice.

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::createWorkerContextProxy): Changed to use WorkerScriptController::controllerForContext() instead of WorkerScriptExecutionProxy::retrieve().
16:48 Changeset [56579] by eric@webkit.org
  • 4 edits
    1 add in trunk/WebKit/chromium

2010-03-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add an ASSERT macro to the Chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=36545

  • WebKit.gyp: Add WebCommon.cpp
  • public/WebCommon.h: Add the Macro.
  • public/WebPrivatePtr.h: (WebKit::WebPrivatePtr::~WebPrivatePtr): Verify the pointer is now 0.
  • src/WebCommon.cpp: Added. (WebKit::failedAssertion): Calls the WTF assert function and then crashes.
16:33 Changeset [56578] by kov@webkit.org
  • 3 edits in trunk/LayoutTests

2010-03-25 Gustavo Noronha Silva <gns@gnome.org>

Needs a "LinuxEditingBehavior", perhaps with a better name
https://bugs.webkit.org/show_bug.cgi?id=36627

Skipping tests that started failing after 56567. We need to figure
out a proper fix, that may involve adding a new editing behavior
for our platform.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
16:30 Changeset [56577] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-25 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] QWebFrame::pageChanged() signal is not documented
https://bugs.webkit.org/show_bug.cgi?id=36609

  • Api/qwebframe.cpp:
16:12 Changeset [56576] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-25 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the package build on Maemo 5

https://bugs.webkit.org/show_bug.cgi?id=36607

Always embed the stylesheet for the no-listbox rendering. This way it'll be
included in the generated files for the package generation.

  • WebCore.pri:
16:09 Changeset [56575] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebKitTools

2010-03-25 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, build fix.

[Qt] Fix QtLauncher guards.

  • QtLauncher/main.cpp: (LauncherWindow::showFPS): (LauncherWindow::updateFPS):
15:49 Changeset [56574] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-03-25 Reinout van Schouwen <reinouts@gnome.org>

Reviewed by Gustavo Noronha.

Updated Dutch translation
https://bugs.webkit.org/show_bug.cgi?id=36432

  • nl.po:
15:38 Changeset [56573] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-25 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, expectations tweak.

Reorganized and updated comments for media test expectations.

  • platform/chromium/test_expectations.txt: Tweaked.
15:29 Changeset [56572] by dumi@chromium.org
  • 8 edits in trunk

WebCore: Changing the V8 and JSC implementations of
SQLStatementErrorCallback to interpret as false all results that
could be converted to a false boolean. Pretty much a revert of
r54981.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=36569

  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::invokeCallback):

  • bindings/v8/custom/V8CustomVoidCallback.h:

LayoutTests: Updating the test to conform to the latest spec changes.

Reviewed by Dimitri Glazkov.

  • storage/statement-error-callback-expected.txt:
  • storage/statement-error-callback.html:
15:25 Changeset [56571] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-03-25 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Remove ASSERT(isMainThread()) which is violated for workers and not necessary at this point.
https://bugs.webkit.org/show_bug.cgi?id=36614

  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
14:58 Changeset [56570] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, fix Chromium tests.

Recent http://trac.webkit.org/changeset/56489 made all urls in Chromium that
have unspecified port to return invalidPortNumber from KURL::port().

  • platform/KURLGoogle.cpp: Return 0 for unspecified ports, mimic WebKit KURL behavior for invalid ports.

(WebCore::KURL::port):

14:39 Changeset [56569] by krit@webkit.org
  • 3 edits in trunk/WebCore

2010-03-25 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

This is a follow up of:
https://bugs.webkit.org/show_bug.cgi?id=30055
Bad DOM performance in large SVG files

Just save and restore the GraphicsContext, if we realy modify it.
(Cairo)Path::contains checks if a point is in the boundingBox
as a heuristic. The intention was to make the process faster for
points outside of this rect, but it rather causes the
opposite.

No new test cases added. No change in functionality.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::contains):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
14:33 Changeset [56568] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-03-25 Simon Fraser <simon.fraser@apple.com>

Revert r56565 which was based on an incorrect premise.

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::getAnimatedStyle): (WebCore::CompositeAnimation::setAnimating): (WebCore::CompositeAnimation::timeToNextService): (WebCore::CompositeAnimation::getAnimationForProperty): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations): (WebCore::CompositeAnimation::isAnimatingProperty): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::numberOfActiveAnimations):
13:21 Changeset [56567] by ojan@chromium.org
  • 11 edits
    8 deletes in trunk

2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

mouse-based selections are always directional on Window/Linux
https://bugs.webkit.org/show_bug.cgi?id=25195

The tests are modified to expect different things for Win/Linux vs. Mac.

  • editing/selection/5195166-1.html:
  • editing/selection/extend-after-mouse-selection.html:
  • editing/selection/extend-selection-after-double-click-expected.txt:
  • editing/selection/extend-selection-after-double-click.html:
  • platform/chromium-linux/editing/selection/5195166-1-expected.checksum: Removed.
  • platform/chromium-linux/editing/selection/5195166-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/5195166-1-expected.checksum: Removed.
  • platform/chromium-win/editing/selection/5195166-1-expected.png: Removed.
  • platform/chromium-win/editing/selection/5195166-1-expected.txt: Removed.
  • platform/mac/editing/selection/5195166-1-expected.checksum: Removed.
  • platform/mac/editing/selection/5195166-1-expected.png: Removed.
  • platform/mac/editing/selection/5195166-1-expected.txt:
  • platform/qt/editing/selection/5195166-1-expected.txt: Removed.
  • platform/win/editing/selection/extend-after-mouse-selection-expected.txt:

2010-03-25 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

mouse-based selections are always directional on Windows/Linux
https://bugs.webkit.org/show_bug.cgi?id=25195

Change m_lastChangeWasHorizontalExtension to m_isDirectional
and make m_isDirectional always be true for Windows/Linux.

  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::setIsDirectional): (WebCore::SelectionController::willBeModified): When double-clicking, the base/extent will be in the middle of the selection instead of the start/end of it. Changed to maintain that modifications after double-click still move the start/end of the selection, not the base/extent. (WebCore::SelectionController::modify):
  • editing/SelectionController.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDrag):
13:20 Changeset [56566] by yurys@chromium.org
  • 11 edits in trunk/WebKitTools

2010-03-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled.

https://bugs.webkit.org/show_bug.cgi?id=36610

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldEnableDeveloperExtras): (runTest):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
  • DumpRenderTree/mac/DumpRenderTree.mm: (shouldEnableDeveloperExtras): (runTest):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::shouldEnableDeveloperExtras): (WebCore::DumpRenderTree::open):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::closeWebInspector): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::setJavaScriptProfilingEnabled):
  • DumpRenderTree/win/DumpRenderTree.cpp: (shouldEnableDeveloperExtras): (runTest):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setDeveloperExtrasEnabled): (LayoutTestController::showWebInspector): (LayoutTestController::closeWebInspector):
12:57 Changeset [56565] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-03-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Carlson.

Make calls to m_keyframeAnimations.checkConsistency() debug-only
https://bugs.webkit.org/show_bug.cgi?id=36555

Remove lots of calls to m_keyframeAnimations.checkConsistency(); which were left after some earlier
debugging. Leave one in CompositeAnimation::animate() to catch any future issues, which is OK since
these calls are no-ops in release builds.

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::getAnimatedStyle): (WebCore::CompositeAnimation::setAnimating): (WebCore::CompositeAnimation::timeToNextService): (WebCore::CompositeAnimation::getAnimationForProperty): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations): (WebCore::CompositeAnimation::isAnimatingProperty): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::numberOfActiveAnimations):
12:07 Changeset [56564] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2010-03-25 Simon Fraser <simon.fraser@apple.com>

Build fix: no review.

Another c_str() -> data().

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate):
11:58 Changeset [56563] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):

Reviewed by NOBODY (build fix).

11:48 Changeset [56562] by simon.fraser@apple.com
  • 3 edits
    6 adds in trunk

2010-03-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=36557
Animations use the wrong timing-function sometimes

Fix an issue where animations picked the wrong style for their "unanimated" value.

Previously, the "unanimated" style was considered to be the style before the animation
was applied. This caused us to pick up stale values for animation timing functions, for
blending when a property is missing from the first keyframe, and for resuming transitions
once an animation ends.

Instead, we need to use the "current" style, which is the one that causes the animation
to kick off.

Tests: animations/longhand-timing-function.html

animations/transition-and-animation-3.html
animations/unanimated-style.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
11:37 WebKit Team edited by cjerdonek@webkit.org
Updated link to committers.py. (diff)
11:29 Changeset [56561] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed expected file fix.

  • platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Needless newline removed.
11:20 Changeset [56560] by barraclough@apple.com
  • 16 edits in trunk

Bug 36611 - Cleanup JSC::CString
Rename CString::c_str() -> CString::data(), CString::size() -> CString::length(),
remove UString::getCString() (all uses are wrong, should use UString::UTF8String()).

Reviewed by Geoff Garen.

JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):

  • jsc.cpp:

(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):

  • profiler/CallIdentifier.h:

(JSC::CallIdentifier::c_str):

  • profiler/Profile.cpp:

(JSC::Profile::debugPrintDataSampleStyle):

  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

  • runtime/DateConversion.cpp:

(JSC::parseDate):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::globalFuncJSCPrint):

  • runtime/UString.cpp:

(JSC::operator==):
(JSC::UString::toDouble):

  • runtime/UString.h:

(JSC::CString::length):
(JSC::CString::data):

WebCore:

  • bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/jsc/JNIBridgeJSC.cpp:

(JavaField::valueFromInstance):
(JavaField::setValueToInstance):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::UTF8String):

11:03 Changeset [56559] by jwieczorek@webkit.org
  • 7 edits in trunk/LayoutTests

2010-03-25 Jakub Wieczorek <jwieczorek@webkit.org>

Rubber-stamped by Tor Arne Vestbø.

[Qt] Update test results after r56555.
https://bugs.webkit.org/show_bug.cgi?id=36413

  • platform/qt/fast/forms/basic-inputs-expected.txt:
  • platform/qt/fast/forms/isindex-placeholder-expected.txt:
  • platform/qt/fast/forms/text-style-color-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:
11:00 Changeset [56558] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

Correctness fix after r56493.

  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCRunSyncOpenPanel): We still need to update our hostProxy reference, even though we didn't use to have instanceProxy. Nothing guarantees that the host proxy won't go away while the open panel is up.
10:51 Changeset [56557] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-25 Antonio Gomes <tonikitoo@webkit.org>

Unreview expectation result fix.

After http://trac.webkit.org/changeset/56547, the test needs new (and proper)
results.

  • platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt:
10:39 Changeset [56556] by joepeck@webkit.org
  • 2 edits in trunk/WebKitSite

2010-03-25 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Levin.

Asking Questions Page Grammar Fixes
https://bugs.webkit.org/show_bug.cgi?id=36608

  • asking_questions.html:
10:30 Changeset [56555] by jwieczorek@webkit.org
  • 6 edits in trunk

2010-03-25 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Eric Seidel.

[Qt] RenderTheme: fix size adjustment for text fields
https://bugs.webkit.org/show_bug.cgi?id=36413

Update test results after RenderTheme changes.

  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:

2010-03-25 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Eric Seidel.

[Qt] RenderTheme: fix size adjustment for text fields
https://bugs.webkit.org/show_bug.cgi?id=36413

To match other ports, remove the hardcoded dimensions for text fields so that
the default ones from WebCore can be used.
Properly apply the correct padding to text areas - this fixes their appearance
with the Oxygen style.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
10:21 Changeset [56554] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

Tweaks to sheriffbot to improve latency by keeping the working copy up
to date even when there's no build break. Also, officially move
sheriffbot to #webkit.

(Also teach ValidateReviewer to understand rubber stamps.)

  • Scripts/webkitpy/common/net/irc/ircbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
10:18 Changeset [56553] by tonikitoo@webkit.org
  • 4 edits in trunk/WebKitTools

Not displaying FPS info on the terminal. On S60 and Maemo the Window title will be used and Status bar will used on desktop.

Reviewed by Simon Hausmann.
Patch by Jesus Palencia <jesus.palencia@openbossa.org>

[Qt] QtLauncher's FPS info should not be displayed on the terminal
https://bugs.webkit.org/show_bug.cgi?id=36244

  • QtLauncher/main.cpp:

(LauncherWindow::initializeView):
(LauncherWindow::showFPS):
(LauncherWindow::updateFPS):

  • QtLauncher/webview.cpp:

(WebViewGraphicsBased::setFrameRateMeasurementEnabled):
(WebViewGraphicsBased::updateFrameRate):

  • QtLauncher/webview.h:

(WebViewGraphicsBased::frameRateMeasurementEnabled):

09:42 Changeset [56552] by vestbo@webkit.org
  • 6 edits in trunk

[Qt] Implement ChromeClient::windowResizerRect()

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=21300

We assume the resize corner to be in the lower right corner of
the window and having the width and height of the scrollbars.

The helper function geometryRelativeToOwnerWidget() in the page
client is used to clip the resize rect to the actual size of the
viewport, not the size of the QGraphicsView.

09:31 Changeset [56551] by joepeck@webkit.org
  • 2 edits in trunk/WebKitSite

2010-03-25 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

New Asking Questions Page is not Valid HTML5
https://bugs.webkit.org/show_bug.cgi?id=36605

  • asking_questions.html: fixed issues raised by the validator.
09:18 Changeset [56550] by jchaffraix@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt][GTK] http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html
fails after r56394
https://bugs.webkit.org/show_bug.cgi?id=36531

Reviewed by Alexey Proskuryakov.

The test was assuming that we would receive 3 progress events which may not be the case anymore
due to the event throttling added in r56394.

  • http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Removed

the counting as it belonged to the original version of the test and instead use the position
to determine when to reset the XHR.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:

Removed the test from the Skipped lists now that it should pass.

09:09 Changeset [56549] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-03-25 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: reloading debug target window with cmd-R from inspector window produces beep.
https://bugs.webkit.org/show_bug.cgi?id=36554

  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown): prevent the default behavior, if handled, which would result in a system beep.
08:49 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
08:25 Changeset [56548] by eric@webkit.org
  • 7 edits in trunk

2010-03-25 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Forward DatabaseTracker::canEstablishDatabase to chromium layer.
https://bugs.webkit.org/show_bug.cgi?id=36595

  • storage/chromium/DatabaseObserver.h:
  • storage/chromium/DatabaseTrackerChromium.cpp: (WebCore::DatabaseTracker::canEstablishDatabase):

2010-03-25 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Forward DatabaseTracker::canEstablishDatabase to chromium layer.
https://bugs.webkit.org/show_bug.cgi?id=36595

  • public/WebFrameClient.h: (WebKit::WebFrameClient::allowDatabase):
  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/WebWorkerBase.h: (WebKit::WebWorkerBase::allowDatabase):
08:24 Changeset [56547] by tonikitoo@webkit.org
  • 5 edits in trunk

Added missing frame flattening activation on fast/frames/flattening/frameset-flattening-grid.html; removed unnecessary CONSOLE MESSAGE from the expected file; reset the setFrameSetFlatteningEnabled for each test.

Reviewed by Kenneth Christiansen.
Patch by Diego Gonzalez <diego.gonzalez@openbossa.org>

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

LayoutTests:

  • fast/frames/flattening/frameset-flattening-grid.html:
  • platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt:
08:06 Changeset [56546] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-25 yael aharon <yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Windowed netscape plugins don't work with QGraphicsWebView on Symbian
https://bugs.webkit.org/show_bug.cgi?id=35112

Add a proxy widget when loading a QWidget based plugin in a QGraphicsWebView.

  • plugins/symbian/PluginContainerSymbian.cpp: (PluginContainerSymbian::PluginContainerSymbian): (PluginContainerSymbian::focusInEvent):
  • plugins/symbian/PluginContainerSymbian.h: (WebCore::PluginContainerSymbian::proxy):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
08:04 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
08:04 Changeset [56545] by cjerdonek@webkit.org
  • 3 edits in trunk/WebKitTools

Moved deprecated_logging unit test import statement from
webkitpy/unittests.py to webkitpy/common/system/unittests.py.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/webkitpy/common/system/unittests.py:
  • Scripts/webkitpy/unittests.py:
07:46 Changeset [56544] by cjerdonek@webkit.org
  • 40 edits
    2 moves in trunk/WebKitTools

Moved webkit_logging.py to common/system/deprecated_logging.py
inside webkitpy.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/validate-committer-lists:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/credentials.py:
  • Scripts/webkitpy/common/net/irc/ircproxy.py:
  • Scripts/webkitpy/common/net/networktransaction.py:
  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py.
  • Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py.
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/openbugs.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/multicommandtool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/applypatch.py:
  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/closebug.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
  • Scripts/webkitpy/tool/steps/confirmdiff.py:
  • Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
  • Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
  • Scripts/webkitpy/tool/steps/obsoletepatches.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/update.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
  • Scripts/webkitpy/unittests.py:
  • Scripts/webkitpy/webkit_logging.py: Removed.
  • Scripts/webkitpy/webkit_logging_unittest.py: Removed.
07:31 Changeset [56543] by simon.fraser@apple.com
  • 5 edits
    2 adds in trunk

2010-03-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=35714
Computed style on delayed transform animations is incorrect

When fetching computed style while a delayed accelerated animation is in effect,
we would get the value form the first keyframe, rather than getting the current
style.

Fix by checking to see whether we've in the delay phase (with no backwards-fill)
in KeyframeAnimation::getAnimatedStyle().

Test: compositing/animation/computed-style-during-delay.html

  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::getAnimatedStyle):
07:31 Changeset [56542] by simon.fraser@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Additional refptr/passrefptr workarounds for WINSCW compiler

https://bugs.webkit.org/show_bug.cgi?id=28054

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12

Reviewed by Tor Arne Vestbø.

  • wtf/PassRefPtr.h:

(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):

  • wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::::operator):

07:27 Changeset [56541] by jchaffraix@webkit.org
  • 2 edits
    1 add in trunk/WebKitSite

Add a page on how to ask questions
https://bugs.webkit.org/show_bug.cgi?id=35223

Reviewed by David Levin.

  • asking_questions.html: Added.

Add a page on how to ask questions based on Ariya Hidayat's mail: how
to get help effectively
(http://article.gmane.org/gmane.os.opendarwin.webkit.user/145/match=get+help+effectively)

  • contact.html: Tweaked the wording to make it more clear what the

mailing list are used for. Also changed the formatting to better
underline the different mailing lists.

07:14 PythonGuidelines edited by cjerdonek@webkit.org
Added note on cleaning *.pyc files. (diff)
07:13 Changeset [56540] by jchaffraix@webkit.org
  • 2 edits in trunk/WebKitTools

commit-log-editor can call itself in an infinite loop
https://bugs.webkit.org/show_bug.cgi?id=35291

Reviewed by Kenneth Rohde Christiansen.

if $editor ends up being commit-log-editor, the script will exec itself
in an infinite loop.

To avoid this, we now check that the $editor variable is not
commit-log-editor to avoid this case.

  • Scripts/commit-log-editor: Added an isCommitLogEditor method and

reworked the $editor setting to add this check.

07:04 Changeset [56539] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Add a Toggle Frame Flattening option to QtLauncher.
It will be enabled by default on Maemo5 and S60 platforms.

[Qt] Add enable/disable Frame Flattening option to QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=36558

  • QtLauncher/main.cpp: (LauncherWindow::applyPrefs): (LauncherWindow::toggleFrameFlattening): (LauncherWindow::createChrome):
06:45 Changeset [56538] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Initialize Web Inspector title with inspected page URL when opening Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=36534

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontend):
06:43 Changeset [56537] by chang.shu@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-03-25 Shu Chang <chang.shu@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Added documentation for delete button.
https://bugs.webkit.org/show_bug.cgi?id=31560

  • Api/qwebsettings.cpp:
06:21 Changeset [56536] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_DESKTOPSERVICES
https://bugs.webkit.org/show_bug.cgi?id=36533

  • Api/qwebsettings.cpp: (QWebSettings::enablePersistentStorage):
06:02 Changeset [56535] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-25 Antti Koivisto <koivisto@iki.fi>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=36316
Tiles of selected content do not update if not in viewport

Don't clip repaints to viewport when tiling is enabled.

  • page/Frame.cpp: (WebCore::Frame::setView): (WebCore::Frame::setTiledBackingStoreEnabled):
05:43 Changeset [56534] by eric@webkit.org
  • 4 edits in trunk

2010-03-25 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Eric Seidel.

Missing forward ENABLE_DATALIST macro to JavaScript enabled features macros
on WebKit.pri

[Qt] Forward ENABLE_DATALIST macro to JavaScript enabled macros
https://bugs.webkit.org/show_bug.cgi?id=36547

  • platform/qt/Skipped:

2010-03-25 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Eric Seidel.

Missing forward ENABLE_DATALIST macro to JavaScript enabled features macros
on WebKit.pri

[Qt] Forward ENABLE_DATALIST macro to JavaScript enabled macros
https://bugs.webkit.org/show_bug.cgi?id=36547

  • WebCore.pri:
05:22 Changeset [56533] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_DEBUG_STREAM
https://bugs.webkit.org/show_bug.cgi?id=36533

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::graphicsItemVisibleRect):
05:19 Changeset [56532] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-03-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Expect console object wrapping to fail.

https://bugs.webkit.org/show_bug.cgi?id=36587

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
05:03 Changeset [56531] by eric@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-03-25 Sergio Villar Senín <svillar@igalia.com>

Reviewed by Xan Lopez.

Added new API webkit_web_back_forward_list_clear. This function
clears the back forward list

[GTK] http/history tests are failing
https://bugs.webkit.org/show_bug.cgi?id=36173

  • tests/testwebbackforwardlist.c: (test_webkit_web_back_forward_list_clear): (main): added new unit test for the new API
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_clear):
  • webkit/webkitwebbackforwardlist.h: new function that clears the back forward list
04:44 Changeset [56530] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-25 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=36371
[Gtk] Elements with a title attribute should not be ignored

  • platform/gtk/accessibility/object-with-title.html: Added
  • platform/gtk/accessibility/object-with-title-expected.txt: Added

2010-03-25 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=36371
[Gtk] Elements with a title attribute should not be ignored

  • accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::accessibilityIsIgnored):
04:23 Changeset [56529] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-25 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Eric Seidel.

Make QWebPage not depend on view() but use the client->ownerWidget()
instead. Also, handle the case where there is not page client.

  • Api/qwebpage.cpp: (QWebPagePrivate::createContextMenu): (QWebPagePrivate::keyPressEvent): (QWebPage::javaScriptAlert): (QWebPage::javaScriptConfirm): (QWebPage::javaScriptPrompt): (QWebPage::shouldInterruptJavaScript): (QWebPage::createWindow): (QWebPage::action): (QWebPage::extension): (QWebPage::chooseFile): (QWebPage::userAgentForUrl):
04:20 Changeset [56528] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix on MSVC. Reverts r55633 for stdint.h

Reviewed by nobody, build fix.

This file gets included in generated moc files which don't
include the prefix header.

  • os-win32/stdint.h:
03:43 PythonGuidelines edited by cjerdonek@webkit.org
Added note about *.pyc files (diff)
03:40 Changeset [56527] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-03-24 Steve Block <steveblock@google.com>

Reviewed by David Levin.

Adds a missing ENABLE(WORKERS) guards to the V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=36550

Build fix only, no new tests.

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
03:33 Changeset [56526] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-25 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Eric Seidel.

Add EFL-specific code to platform/ScrollView.cpp and
platform/Scrollbar.cpp.
http://webkit.org/b/36305

  • platform/ScrollView.cpp:
  • platform/Scrollbar.cpp:
03:30 PythonGuidelines edited by cjerdonek@webkit.org
Added Basics and Code Structure sub-sections (diff)
03:12 Changeset [56525] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_LIBRARY
https://bugs.webkit.org/show_bug.cgi?id=36533

  • platform/FileSystem.h:
  • platform/qt/FileSystemQt.cpp: (WebCore::unloadModule):
02:46 Changeset [56524] by zoltan@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-25 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

svn-create-patch prints a warning for large patches
https://bugs.webkit.org/show_bug.cgi?id=32582

svn-create-patch prints a warning message for larger patches than 20k.

  • Scripts/svn-create-patch:
02:40 Changeset [56523] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_ANIMATION
https://bugs.webkit.org/show_bug.cgi?id=36526

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl):
  • platform/graphics/qt/GraphicsLayerQt.h:
02:32 Changeset [56522] by abarth@webkit.org
  • 3 edits
    2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Renamed early_warning_system.py to earlywarningsystem.py.
https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/tool/commands/early_warning_system.py: Removed.
  • Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py.
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py.
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/unittests.py:
02:30 Changeset [56521] by cjerdonek@webkit.org
  • 3 edits
    2 copies
    1 add in trunk/WebKitTools

In webkitpy, pushed the unit test import statements in
webkitpy/unittests.py into appropriate unittests.py files in the
new root-level packages beneath webkitpy.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/webkitpy/common/system/unittests.py:
  • Scripts/webkitpy/common/unittests.py: Added.
  • Scripts/webkitpy/python24/unittests.py: Added.
  • Scripts/webkitpy/tool/unittests.py: Added.
  • Scripts/webkitpy/unittests.py:
02:17 Changeset [56520] by abarth@webkit.org
  • 3 edits
    1 move in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move WebKitCheckout into the webkitpy.common.checkout
package.
https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py.
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/webkitcheckout.py: Removed.
02:11 Changeset [56519] by abarth@webkit.org
  • 10 edits
    1 move in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move OutputCapture to webkitpy.common.system.
https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
  • Scripts/webkitpy/outputcapture.py: Removed.
  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/multicommandtool_unittest.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
02:05 Changeset [56518] by abarth@webkit.org
  • 7 edits
    2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move user.py to webkitpy.common.system.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/credentials.py:
  • Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py.
  • Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py.
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/unittests.py:
  • Scripts/webkitpy/user.py: Removed.
  • Scripts/webkitpy/user_unittest.py: Removed.
02:01 Changeset [56517] by abarth@webkit.org
  • 19 edits
    2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move executive.py to webkitpy.common.system.
https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
  • Scripts/webkitpy/common/net/credentials.py:
  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py.
  • Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py.
  • Scripts/webkitpy/executive.py: Removed.
  • Scripts/webkitpy/executive_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/early_warning_system.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/unittests.py:
  • Scripts/webkitpy/webkit_logging_unittest.py:
01:50 Changeset [56516] by abarth@webkit.org
  • 9 edits
    2 moves in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move grammary.py into webkitpy.tool.
https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/grammar.py: Removed.
  • Scripts/webkitpy/grammar_unittest.py: Removed.
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py.
  • Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py.
  • Scripts/webkitpy/tool/multicommandtool.py:
  • Scripts/webkitpy/tool/steps/obsoletepatches.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/unittests.py:
01:49 Changeset [56515] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-10 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Fix up WebMouseWheelEventBuilder to properly calculate the units
https://bugs.webkit.org/show_bug.cgi?id=35989

  • src/WebInputEventConversion.cpp:
01:48 Changeset [56514] by cjerdonek@webkit.org
  • 6 edits
    1 move in trunk/WebKitTools

In webkitpy, moved init/ to common/system/.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init.
  • Scripts/webkitpy/common/system/logutils.py:
  • Scripts/webkitpy/common/system/logutils_unittest.py:
  • Scripts/webkitpy/init: Removed.
  • Scripts/webkitpy/init/init.py: Removed.
  • Scripts/webkitpy/init/logtesting.py: Removed.
  • Scripts/webkitpy/init/logutils.py: Removed.
  • Scripts/webkitpy/init/logutils_unittest.py: Removed.
  • Scripts/webkitpy/init/unittests.py: Removed.
  • Scripts/webkitpy/python24/versioning_unittest.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/unittests.py:
01:46 Changeset [56513] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-03-25 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=33697
Have dragOpFromIEOp("move") return DragOperationGeneric | DragOperationMove
because only returning Generic doesn't work for platforms that don't
have a generic operation.

Covered by existing tests (fast/events/drag-and-drop.html).

  • dom/Clipboard.cpp: (WebCore::dragOpFromIEOp): (WebCore::Clipboard::destinationOperation): (WebCore::Clipboard::setDestinationOperation):
01:42 Changeset [56512] by abarth@webkit.org
  • 4 edits
    1 move in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move stepsequence to webkitpy.tool.commands.
https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/stepsequence.py: Removed.
  • Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py.
01:38 Changeset [56511] by ukai@chromium.org
  • 4 edits in trunk

2010-03-25 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

[Qt] websocket/tests/long-invalid-header.html fails
https://bugs.webkit.org/show_bug.cgi?id=36492

  • websocket/tests/long-invalid-header-expected.txt: trim console message.

2010-03-25 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

[Qt] websocket/tests/long-invalid-header.html fails
https://bugs.webkit.org/show_bug.cgi?id=36492

trim message at most 128 bytes from the current position.
I believe it's enough data to investigate the error reason and
it makes test not depend on buffered size.

  • websockets/WebSocketHandshake.cpp: (WebCore::trimConsoleMessage): (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders):
01:34 Changeset [56510] by abarth@webkit.org
  • 15 edits
    1 copy
    8 moves
    1 add in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Create webkitpy.common.checkout as described in
https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/changelogs.py: Removed.
  • Scripts/webkitpy/changelogs_unittest.py: Removed.
  • Scripts/webkitpy/commitinfo.py: Removed.
  • Scripts/webkitpy/commitinfo_unittest.py: Removed.
  • Scripts/webkitpy/common/checkout: Added.
  • Scripts/webkitpy/common/checkout/init.py: Copied from Scripts/webkitpy/common/init.py.
  • Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
  • Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
  • Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
  • Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
  • Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
  • Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
  • Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
  • Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
  • Scripts/webkitpy/common/net/credentials.py:
  • Scripts/webkitpy/diff_parser.py: Removed.
  • Scripts/webkitpy/diff_parser_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/scm.py: Removed.
  • Scripts/webkitpy/scm_unittest.py: Removed.
  • Scripts/webkitpy/stepsequence.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/comments.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
  • Scripts/webkitpy/unittests.py:
  • Scripts/webkitpy/webkitcheckout.py:
01:02 Changeset [56509] by cjerdonek@webkit.org
  • 5 edits
    1 copy
    2 moves
    1 add in trunk/WebKitTools

In webkitpy, moved init/versioning.py to python24/.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/test-webkitpy:
  • Scripts/webkit-patch:
  • Scripts/webkitpy/init/unittests.py:
  • Scripts/webkitpy/init/versioning.py: Removed.
  • Scripts/webkitpy/init/versioning_unittest.py: Removed.
  • Scripts/webkitpy/python24: Added.
  • Scripts/webkitpy/python24/init.py: Copied from WebKitTools/Scripts/webkitpy/tool/init.py.
  • Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
  • Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
  • Scripts/webkitpy/unittests.py:
00:52 Changeset [56508] by abarth@webkit.org
  • 20 edits
    10 moves
    2 adds in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed.

Create webkitpy.common.net as described in
https://bugs.webkit.org/show_bug.cgi?id=36093

  • Scripts/webkitpy/bugzilla.py: Removed.
  • Scripts/webkitpy/bugzilla_unittest.py: Removed.
  • Scripts/webkitpy/buildbot.py: Removed.
  • Scripts/webkitpy/buildbot_unittest.py: Removed.
  • Scripts/webkitpy/commitinfo.py:
  • Scripts/webkitpy/common/net: Added.
  • Scripts/webkitpy/common/net/init.py: Added.
  • Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
  • Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
  • Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
  • Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
  • Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
  • Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
  • Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
  • Scripts/webkitpy/common/net/irc/ircbot.py:
  • Scripts/webkitpy/common/net/irc/ircproxy.py:
  • Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
  • Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
  • Scripts/webkitpy/common/net/irc/unittests.py:
  • Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
  • Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
  • Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
  • Scripts/webkitpy/credentials.py: Removed.
  • Scripts/webkitpy/credentials_unittest.py: Removed.
  • Scripts/webkitpy/irc: Removed.
  • Scripts/webkitpy/irc/init.py: Removed.
  • Scripts/webkitpy/irc/ircbot.py: Removed.
  • Scripts/webkitpy/irc/ircproxy.py: Removed.
  • Scripts/webkitpy/irc/messagepump.py: Removed.
  • Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
  • Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
  • Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
  • Scripts/webkitpy/irc/unittests.py: Removed.
  • Scripts/webkitpy/networktransaction.py: Removed.
  • Scripts/webkitpy/networktransaction_unittest.py: Removed.
  • Scripts/webkitpy/scm_unittest.py:
  • Scripts/webkitpy/statusserver.py: Removed.
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
  • Scripts/webkitpy/unittests.py:
00:37 Changeset [56507] by jhoneycutt@apple.com
  • 4 edits in trunk

<rdar://problem/7780798> Missing plug-ins should be represented by text
only, instead of lego block

https://bugs.webkit.org/show_bug.cgi?id=36583

Reviewed by Dan Bernstein.

WebCore:

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintReplaced):
Set the font rendering mode and the computed size, so that the text will
draw properly on Windows.

WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::createPlugin):
Return 0 if we failed to initialize the plug-in, which causes the new
"missing plug-in" text to draw.

00:34 Changeset [56506] by eric@webkit.org
  • 2 edits
    2 adds
    4 deletes in trunk/LayoutTests

2010-03-25 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Rewrite the layout test editing/inserting/6633727 to use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=31579

  • editing/inserting/6633727-expected.txt: Added.
  • editing/inserting/6633727.html:
  • editing/inserting/script-tests/6633727.js: Added.
  • platform/gtk/editing/inserting/6633727-expected.txt: Removed.
  • platform/mac/editing/inserting/6633727-expected.checksum: Removed.
  • platform/mac/editing/inserting/6633727-expected.png: Removed.
  • platform/mac/editing/inserting/6633727-expected.txt: Removed.
00:24 Changeset [56505] by cjerdonek@webkit.org
  • 11 edits in trunk/WebKitTools

In webkitpy, renamed MockBugzillaTool to MockTool.

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
00:18 Changeset [56504] by cjerdonek@webkit.org
  • 14 edits
    2 copies
    4 moves
    2 adds in trunk/WebKitTools

In Scripts/webkitpy, moved webkitport.py and committers.py into
common/config/ (also creating common/config/).

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

  • Scripts/validate-committer-lists:
  • Scripts/webkitpy/bugzilla.py:
  • Scripts/webkitpy/bugzilla_unittest.py:
  • Scripts/webkitpy/changelogs.py:
  • Scripts/webkitpy/commitinfo.py:
  • Scripts/webkitpy/commitinfo_unittest.py:
  • Scripts/webkitpy/committers.py: Removed.
  • Scripts/webkitpy/committers_unittest.py: Removed.
  • Scripts/webkitpy/common: Added.
  • Scripts/webkitpy/common/init.py: Copied from WebKitTools/Scripts/webkitpy/style/init.py.
  • Scripts/webkitpy/common/config: Added.
  • Scripts/webkitpy/common/config/init.py: Copied from WebKitTools/Scripts/webkitpy/style/init.py.
  • Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
  • Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
  • Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
  • Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
  • Scripts/webkitpy/mock_bugzillatool.py:
  • Scripts/webkitpy/tool/commands/early_warning_system.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/unittests.py:
  • Scripts/webkitpy/webkitport.py: Removed.
  • Scripts/webkitpy/webkitport_unittest.py: Removed.
00:09 Changeset [56503] by abarth@webkit.org
  • 10 edits
    1 move in trunk/WebKitTools

2010-03-25 Adam Barth <abarth@webkit.org>

Unreviewed. Move mock_bugzillatool.py to tool/mocktool.py.

  • Scripts/webkitpy/mock_bugzillatool.py: Removed.
  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
00:07 Changeset [56502] by eric@webkit.org
  • 6 edits in trunk

2010-03-24 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Removing unecessary redraws of LayerSkia contents:
https://bugs.webkit.org/show_bug.cgi?id=36470

Test: No new functionality added, no tests.

  • platform/graphics/skia/LayerRendererSkia.cpp: (WebCore::LayerRendererSkia::drawLayerInCanvasRecursive): Debug borders now rendered at composite time rather than update time.
  • platform/graphics/skia/LayerSkia.cpp: (WebCore::LayerSkia::updateContents): (WebCore::LayerSkia::drawDebugBorder): Debug border drawing removed from updateContents and split into a separate method that can be called at composite time. (WebCore::LayerSkia::setBounds): Resetting the bounds causes the layer to redraw its contents. (WebCore::LayerSkia::setNeedsDisplay):
  • platform/graphics/skia/LayerSkia.h: Added declaration for drawDebugBorders method.

2010-03-24 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Eliminate unecessary redraws of GraphicsLayer contents when doing accelerated compositing:
https://bugs.webkit.org/show_bug.cgi?id=36470

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): Remove call that forced redrawing the contents of the entire layer hierarchy.
Note: See TracTimeline for information about the timeline view.