Timeline



Mar 31, 2010:

11:35 PM Changeset in webkit [56899] by Chris Jerdonek
  • 4 edits
    3 adds in trunk/WebKitTools

Added Python style checking to check-webkit-style using
the third-party pep8 module (via autoinstall).

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=33639

  • Scripts/webkitpy/style/checker.py:
    • Added PYTHON to FileType.
    • Updated ProcessorDispatcher to return a PythonProcessor for *.py files.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the ProcessorDispatcher unit tests for *.py files.
  • Scripts/webkitpy/style/processors/python.py: Added.
    • Added PythonProcessor class.
  • Scripts/webkitpy/style/processors/python_unittest.py: Added.
    • Added PythonProcessor unit tests.
  • Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
    • Added a sample Python file to test the PythonProcessor.process() code path (since pep8 accepts a file path).
  • Scripts/webkitpy/style/unittests.py:
    • Updated the style unit test file to import python_unittest.py.
  • Scripts/webkitpy/style_references.py:
    • Adjusted style references to import pep8.
11:23 PM Changeset in webkit [56898] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

fast/replaced/border-radius-clip.html failed on Snow Leopard Debug bot
https://bugs.webkit.org/show_bug.cgi?id=36642

This test is flaky (seemingly due to <video> load times)
and is thus useless until fixed. Skipping for now.

  • platform/mac/Skipped:
11:09 PM Changeset in webkit [56897] by Chris Jerdonek
  • 9 edits
    1 add
    2 deletes in trunk/WebKitTools

Rewrote autoinstall.py to support unzipping *.zip files after
download, unzipping and extracting *.tar.gz files after download,
and copying installed files to a given destination directory.

Reviewed by Dave Levin.

https://bugs.webkit.org/show_bug.cgi?id=35163

These changes will let us autoinstall pep8.py from the web and put
our third-party autoinstalled code in an explicit directory like
webkitpy/thirdparty/autoinstalled. These changes should also speed
up the execution of autoinstalled *.zip packages slightly since
*.pyc files cannot be generated when importing from zipped
packages using the current autoinstall.

  • Scripts/test-webkitpy:
    • Addressed the FIXME to enable auto-install logging once autoinstall was rewritten not to log as verbosely.
  • Scripts/webkitpy/common/net/bugzilla.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/common/net/buildbot.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/common/net/irc/ircbot.py:
    • Updated ircbot and irclib import statements.
  • Scripts/webkitpy/common/net/networktransaction.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/common/net/networktransaction_unittest.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/common/net/statusserver.py:
    • Updated mechanize import statement.
  • Scripts/webkitpy/common/system/autoinstall.py: Added.
    • Added AutoInstaller class.
    • Added sample/testing usage to the main block.
  • Scripts/webkitpy/thirdparty/init.py:
    • Updated the autoinstall lines to use the new autoinstall methods.
    • Added pep8.py to the list of auto-installed packages.
    • Added a README file to the target autoinstallation directory so users know that the directory is safe to delete.
  • Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
    • This is replaced by the rewritten autoinstall webkitpy/common/system/autoinstall.py.
  • Scripts/webkitpy/thirdparty/autoinstalled/init.py: Removed.
    • The target autoinstallation directory is now auto-generated.
10:22 PM Changeset in webkit [56896] by rolandsteiner@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-04-01 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed - add missing Chromium layout test results for:

Bug 36803 - 'Inline-table' workaround for <ruby> broken with ruby support
https://bugs.webkit.org/show_bug.cgi?id=36803

(original patch review by Darin Adler).

  • platform/chromium-linux/fast/ruby/ruby-inline-table-expected.checksum: Added.
  • platform/chromium-linux/fast/ruby/ruby-inline-table-expected.png: Added.
  • platform/chromium-linux/fast/ruby/ruby-inline-table-expected.txt: Added.
  • platform/chromium-win/fast/ruby/ruby-inline-table-expected.checksum: Added.
  • platform/chromium-win/fast/ruby/ruby-inline-table-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-inline-table-expected.txt: Added.
10:02 PM Changeset in webkit [56895] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-31 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

Crash when writing into a detached TITLE element
https://bugs.webkit.org/show_bug.cgi?id=25567

  • fast/dom/title-content-write-set-expected.txt: Added.
  • fast/dom/title-content-write-set.html: Added.

2010-03-31 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

Crash when writing into a detached TITLE element
https://bugs.webkit.org/show_bug.cgi?id=25567

Document::setTitle() invoked HTMLTitleElement::setText(), which
contains DOM tree modification, even when setTitle() is called
from HTMLTitleElement::childrenChanged(). Fix to skip setText()
when setTitle() is called childrenChanged() to avoid cascading
DOM mutations between Document and HTMLTitleElement.

Test: fast/dom/title-content-write-set.html

  • dom/Document.cpp: (WebCore::Document::setTitle):
9:50 PM Changeset in webkit [56894] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Tweak webkitpy's logtesting.LogTesting class to get more mileage out
of our unit tests that test log messages.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=36886

This patch adds to the LogTesting class's tearDown() method a line
asserting that the array of remaining log messages is empty. This
ensures that no extra log messages are getting logged that the caller
might not be aware of or may have forgotten to check for.

  • Scripts/webkitpy/common/system/logtesting.py:
    • Modified the tearDown() method as described above.
    • Also modified the assertMessages() method to clear the array of log messages after asserting.
9:22 PM Changeset in webkit [56893] by Chris Jerdonek
  • 4 edits in trunk/WebKitTools

Added support for a --verbose-logging flag to test-webkitpy.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36429

Verbose logging is useful for debugging test-webkitpy code that
runs before the actual unit tests -- things like autoinstalling and
unit-test auto-detection logic. This is different from verbose
logging of the unit tests themselves (which corresponds to the
unittest module's --verbose flag).

  • Scripts/test-webkitpy:
    • In the configure_logging() method--
      • Added an is_verbose_logging parameter that sets the logging level to logging.DEBUG instead of logging.INFO.
      • Changed the method to throttle the logging level on the root logger's handler instead of directly on the root logger itself.
      • Enabled logging of the autoinstall module when the flag is set.
  • Scripts/webkitpy/thirdparty/autoinstalled/init.py:
    • Added a work-around for a bug in Python 2.6's logging module that was discovered while working on this patch.
8:56 PM Changeset in webkit [56892] by Chris Jerdonek
  • 7 edits in trunk/WebKitTools

Enabled Python's logging module for webkit-patch, and replaced
deprecated_logging with Python logging in networktransaction.py.
This eliminates some spurious output when running test-webkitpy.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36725

  • Scripts/webkit-patch:
    • Replaced the configure_logging() function with a call to the new logutils.configure_logging() function.
  • Scripts/webkitpy/common/net/networktransaction.py:
    • Replaced the use of deprecated_logging with Python logging.
  • Scripts/webkitpy/common/system/logutils.py:
    • Added _default_handlers() which creates the default logging handler for webkitpy.
    • Added configure_logging() which configures default logging for webkitpy.
  • Scripts/webkitpy/common/system/logutils_unittest.py:
    • Added unit tests for logutils.configure_logging().
  • Scripts/webkitpy/style/checker.py:
    • Refactored check-webkit-style's configure_logging() method to call the new logutils.configure_logging().
  • Scripts/webkitpy/style_references.py:
    • Updated references as necessary.
8:49 PM Changeset in webkit [56891] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch land fails if not run from the root directory
https://bugs.webkit.org/show_bug.cgi?id=35822

The root of the problem was that ChangeLog.init expects a path
relative to the current working directory, and SCM expects to
return paths relative to the SCM root. Fix it by converting from
SCM-relative to absolute paths in Checkout.modified_changelogs

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
8:28 PM Changeset in webkit [56890] by rolandsteiner@chromium.org
  • 3 edits
    4 adds in trunk

2010-03-29 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Darin Adler.

Bug 36803 - 'Inline-table' workaround for <ruby> broken with ruby support
https://bugs.webkit.org/show_bug.cgi?id=36803

Don't use ruby rendering if the underlying 'display' property has been
changed into a value other than 'inline' or 'block' (such as 'inline-table').

Test: fast/ruby/ruby-inline-table.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject):

Add layout test to confirm that 'inline-table' rendering is not affected
by ruby implementation.

  • fast/ruby/ruby-inline-table.html: Added.
  • platform/mac/fast/ruby/ruby-inline-table-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-inline-table-expected.png: Added.
  • platform/mac/fast/ruby/ruby-inline-table-expected.txt: Added.
8:27 PM Changeset in webkit [56889] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add more tests for webkitpy.common.checkout
https://bugs.webkit.org/show_bug.cgi?id=36926

We don't have a great way of testing checkout, sadly.

  • Scripts/webkitpy/common/checkout/api_unittest.py:
7:55 PM Changeset in webkit [56888] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: EWS crashes on failure
https://bugs.webkit.org/show_bug.cgi?id=36924

Turns out we need to pass one more argument. My test is kind of lame,
but at least it's there.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
7:33 PM Changeset in webkit [56887] by Chris Jerdonek
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Fixed typo in WebKitTools/ChangeLog: opsys -> ospath.

7:08 PM Changeset in webkit [56886] by eric@webkit.org
  • 7 edits in trunk/LayoutTests

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

Fix 3 failed tests on Snow Leopard bot from 33416
https://bugs.webkit.org/show_bug.cgi?id=36910

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Considering the case where EXT_packed_depth_stencil is unsupported.
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Ditto.
  • fast/canvas/webgl/context-attributes-expected.txt: Ditto.
  • fast/canvas/webgl/context-attributes.html: Ditto.
  • fast/canvas/webgl/gl-get-calls-expected.txt: Ditto.
  • fast/canvas/webgl/gl-get-calls.html: Ditto.
6:54 PM Changeset in webkit [56885] by ggaren@apple.com
  • 4 edits
    2 adds in trunk

Crash submitting display:none textarea in a form
https://bugs.webkit.org/show_bug.cgi?id=36905

Reviewed by Darin Adler.

WebCore:

Test: fast/forms/textarea-submit-crash.html

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData): Do update layout before
asking our renderer for its text, since we can't rely on our renderer's
text if layout is needed.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textWithHardLineBreaks): Don't update layout
while being asked for our text, since doing so may delete us, causing a crash.

LayoutTests:

  • fast/forms/textarea-submit-crash-expected.txt: Added.
  • fast/forms/textarea-submit-crash.html: Added.
6:43 PM Changeset in webkit [56884] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make the EWS go faster by being optimistic
https://bugs.webkit.org/show_bug.cgi?id=36916

Have the EWS be optimistic that a patch will correctly build. This
should speed up the common case by not requiring two builds for every
patch.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/queues.py:
6:13 PM Changeset in webkit [56883] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add the ability to restart sheriffbot from IRC
https://bugs.webkit.org/show_bug.cgi?id=36909

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
5:58 PM Changeset in webkit [56882] by Chris Fleizach
  • 8 edits
    2 adds in trunk

WebCore: Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
https://bugs.webkit.org/show_bug.cgi?id=36845

Reviewed by Darin Adler.

Provide a way through WebKit to set an accessible label that describes the web area.

Test: platform/mac/accessibility/html-with-aria-label.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setAccessibleName):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::setAccessibleName):

  • accessibility/AccessibilityRenderObject.h:

WebKit/mac: Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
https://bugs.webkit.org/show_bug.cgi?id=36845

Reviewed by Darin Adler.

Provide a way through WebKit to set an accessible label that describes the web area.

  • WebView/WebFrame.mm:

(-[WebFrame setAccessibleName:]):

  • WebView/WebFramePrivate.h:

LayoutTests: Test for
Bug 36845 - AX: need a way to set the label of a AXWebArea through WebKit
https://bugs.webkit.org/show_bug.cgi?id=36845

Reviewed by Darin Adler.

  • platform/mac/accessibility/html-with-aria-label-expected.txt: Added.
  • platform/mac/accessibility/html-with-aria-label.html: Added.
5:47 PM Changeset in webkit [56881] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add win-ews to QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=36876

The win-ews is still experimental, but it seems to be more or less
running. We should show its results to the people.

  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/statusbubble.html:
5:23 PM Changeset in webkit [56880] by hclam@chromium.org
  • 2 edits in trunk/WebKit/chromium

Not reviewed. Build fix.

Fixing a build break caused by 56872. One of the Chromium bots doesn't
like std::strstr(). Includes string.h and use strstr() instead.

  • src/WebGraphicsContext3DDefaultImpl.cpp:

(WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
Includes string.h and use strstr().

5:13 PM Changeset in webkit [56879] by mrowe@apple.com
  • 5 edits in trunk

<http://webkit.org/b/36878> REGRESSION: Trailing colon on hostnames (with no port specified) causes "Not allowed to use restricted network port"

Reviewed by Darin Adler.

WebCore:

  • platform/KURL.cpp:

(WebCore::KURL::port): Explicitly handle the case of a colon being present in the URL after the host name but with
no port number before the path. This is handled in the same manner as the colon and port being omitted completely.

LayoutTests:

Add explicit tests for handling of allowed ports. We currently only test the ports that map to port 80: 0, 80, and "".

  • platform/mac/security/block-test-expected.txt:
  • security/block-test.html:
5:12 PM Changeset in webkit [56878] by barraclough@apple.com
  • 9 edits in trunk/WebCore

Remove dependency on TextBreakIterator from StringImpl.cpp,
and from member methods of String.

Reviewed by Oliver Hunt.

Make 'numGraphemeClusters' & 'numCharactersInGraphemeClusters'
global function defined in PlatformString.h, rather than
member methods on String (these can be implemented purely
using the characters() and length() public interface),
and make 'makeCapitalized' a static function in RenderText.cpp.

  • dom/InputElement.cpp:

(WebCore::InputElement::sanitizeUserInputValue):
(WebCore::InputElement::handleBeforeTextInsertedEvent):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::tooLong):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
(WebCore::HTMLTextAreaElement::sanitizeUserInputValue):
(WebCore::HTMLTextAreaElement::tooLong):

  • platform/text/PlatformString.h:

(WebCore::String::makeSecure):

  • platform/text/String.cpp:

(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):

  • platform/text/StringImpl.cpp:
  • platform/text/StringImpl.h:
  • rendering/RenderText.cpp:

(WebCore::makeCapitalized):
(WebCore::RenderText::setTextInternal):

5:09 PM Changeset in webkit [56877] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-31 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by David Levin.

[V8] SerializedScriptValue must be deserialized only once and in the right context
https://bugs.webkit.org/show_bug.cgi?id=36892

See also https://bugs.webkit.org/show_bug.cgi?id=34227 for the
corresponding JSC change.

General idea: SerializedScriptValue must be deserialized only once
and in the context of the intended MessageEvent recepient. The
approach we take for now is to eagerly deserialize when a
JavaScript wrapper for MessageEvent is created.

A better fix would be to keep a reference to the context in
MessageEvent and use it when lazily deserializing. It's harder to
do since the API doesn't have a clean method to have such a reference.

Tested by fast/dom/Window/window-postmessage-clone-frames.html. This
test still fails but only for the types which we can't serialize yet.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserializeAndSetProperty):
  • bindings/v8/custom/V8MessageEventCustom.cpp: (WebCore::V8MessageEvent::initMessageEventCallback):
4:45 PM Changeset in webkit [56876] by victorw@chromium.org
  • 4 edits in trunk/WebKitTools

2010-03-30 Victor Wang <victorw@chromium.org>

Reviewed by Eric Seidel.

Update rebaseline tool to check the release image diff binary and
fallback to debug if the release version does not exist.

https://bugs.webkit.org/show_bug.cgi?id=36245

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4:22 PM Changeset in webkit [56875] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Cleanup RedirectScheduler
https://bugs.webkit.org/show_bug.cgi?id=36874

Removed the nutty ScheduledRedirection struct in favor of a hierarchy
of classes to represent the various kinds of scheduled redirects.
Doing this lets us get rid of the pseudo RTTI switch statements on
"type" in favour of calling virtual functions.

No new tests because this change should be API identical with the
existing RedirectScheduler.

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledNavigation::~ScheduledNavigation): (WebCore::ScheduledNavigation::isLocationChange): (WebCore::ScheduledNavigation::shouldStartTimer): (WebCore::ScheduledNavigation::didStartTimer): (WebCore::ScheduledNavigation::didStopTimer): (WebCore::ScheduledNavigation::delay): (WebCore::ScheduledNavigation::lockHistory): (WebCore::ScheduledNavigation::lockBackForwardList): (WebCore::ScheduledNavigation::wasDuringLoad): (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledURLNavigation::didStartTimer): (WebCore::ScheduledURLNavigation::didStopTimer): (WebCore::ScheduledURLNavigation::url): (WebCore::ScheduledURLNavigation::referrer): (WebCore::ScheduledURLNavigation::wasUserGesture): (WebCore::ScheduledRedirect::ScheduledRedirect): (WebCore::ScheduledRedirect::isLocationChange): (WebCore::ScheduledRedirect::shouldStartTimer): (WebCore::ScheduledLocationChange::ScheduledLocationChange): (WebCore::ScheduledRefresh::ScheduledRefresh): (WebCore::ScheduledRefresh::fire): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::RedirectScheduler::redirectScheduledDuringLoad): (WebCore::RedirectScheduler::clear): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::locationChangePending): (WebCore::RedirectScheduler::scheduleHistoryNavigation): (WebCore::RedirectScheduler::timerFired): (WebCore::RedirectScheduler::schedule): (WebCore::RedirectScheduler::startTimer): (WebCore::RedirectScheduler::cancel):
  • loader/RedirectScheduler.h:
3:55 PM Changeset in webkit [56874] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach buildbot.py how to parse builder activity from /one_box_per_builder
https://bugs.webkit.org/show_bug.cgi?id=36898

I also removed some obsolete FIXMEs and
refactored one_box_per_builder parsing into multiple
methods for easier reading.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
3:53 PM Changeset in webkit [56873] by scherkus@chromium.org
  • 2 edits
    10 adds in trunk/LayoutTests

2010-03-31 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Dmitry Titov.

Checking in Chromium media baselines for layout tests fixed in r56481.

https://bugs.webkit.org/show_bug.cgi?id=36860

  • platform/chromium-linux/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-linux/media/video-no-audio-expected.png: Added.
  • platform/chromium-mac/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-mac/media/video-no-audio-expected.png: Added.
  • platform/chromium-mac/media/video-no-audio-expected.txt: Added.
  • platform/chromium-win/media/audio-constructor-src-expected.txt: Added.
  • platform/chromium-win/media/video-no-audio-expected.checksum: Added.
  • platform/chromium-win/media/video-no-audio-expected.png: Added.
  • platform/chromium-win/media/video-no-audio-expected.txt: Added.
  • platform/chromium-win/media/video-source-add-src-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Tests are now passing.
3:15 PM Changeset in webkit [56872] by eric@webkit.org
  • 15 edits
    2 adds in trunk

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Added.
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Added.
  • fast/canvas/webgl/context-attributes-expected.txt: WebGL context attributes behavior changed with this fix.
  • fast/canvas/webgl/context-attributes.html: Ditto.
  • fast/canvas/webgl/gl-get-calls-expected.txt: Stencil buffer is enabled, thus Stencil Bits is no longer 0.
  • fast/canvas/webgl/gl-get-calls.html: Ditto.

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

Test: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Fix an index bug. (WebCore::V8HTMLCanvasElement::getContextCallback):
  • platform/graphics/GraphicsContext3D.h: Add members/functions for multisampling/stencil buffer purpose.
  • platform/graphics/mac/Canvas3DLayer.h: Add GraphicsContext3D as a member of Canvas3DLayer.
  • platform/graphics/mac/Canvas3DLayer.mm: Add multisampling support. (-[Canvas3DLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]):
  • platform/graphics/mac/GraphicsContext3DMac.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Mac. (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::validateAttributes): (WebCore::GraphicsContext3D::reshape): (WebCore::GraphicsContext3D::prepareTexture): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::readPixels):
  • platform/graphics/mac/GraphicsLayerCA.mm: Adjust to modified Canvas3DLayer init call. (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

  • src/WebGraphicsContext3DDefaultImpl.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Chrome. (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Deal with wrong returned alpha values in Mac.
  • src/WebGraphicsContext3DDefaultImpl.h: Add a function.
2:51 PM Changeset in webkit [56871] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-03-31 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Fix logging in new-run-webkit-tests so that we don't report IMAGE
expected failures as unexpected passes when we run with pixel tests
disabled.

This change splits some of the logic embedded into the TestExpectations
classes out into separate pure functions (result_was_expected,
remove_image_failures) to make them easier to test. This also adds
a parameter to matches_an_expected_result() to indicate whether or
not pixel test results should be included in the expectations.

https://bugs.webkit.org/show_bug.cgi?id=36771

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2:44 PM Changeset in webkit [56870] by Chris Jerdonek
  • 4 edits
    2 adds in trunk/WebKitTools

In webkitpy, refactored two calls to os.path.relpath() replacements
to use a common method.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=36891

  • Scripts/webkitpy/common/net/bugzilla.py:
    • Replaced the relpath implementation with a call to webkitpy.common.system.opsys.relpath().
  • Scripts/webkitpy/common/system/ospath.py: Added.
    • Moved the relpath() implementation from style/main.py.
  • Scripts/webkitpy/common/system/ospath_unittest.py: Added.
    • Moved the relpath() unit tests from style/main_unittest.py.
  • Scripts/webkitpy/style/main.py:
    • Replaced the relpath implementation with a call to webkitpy.common.system.opsys.relpath().
  • Scripts/webkitpy/style/main_unittest.py:
    • Moved the relpath unit tests to opsys_unittest.py.
2:23 PM Changeset in webkit [56869] by jianli@chromium.org
  • 6 edits
    2 adds in trunk/WebCore

Add support to create UUID string.
https://bugs.webkit.org/show_bug.cgi?id=36472

Reviewed by Dmitry Titov.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/UUID.cpp: Added.

(WebCore::createCanonicalUUIDString):

  • platform/UUID.h: Added.
2:15 PM Changeset in webkit [56868] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix pt II).

1:59 PM Changeset in webkit [56867] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix).

1:57 PM Changeset in webkit [56866] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a Builder.force_build method
https://bugs.webkit.org/show_bug.cgi?id=36875

We plan to eventually use this in SheriffBot to break deadlocks created
by flaky tests.

  • Scripts/webkitpy/common/net/buildbot.py:
1:38 PM Changeset in webkit [56865] by eric@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2010-03-31 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable LayoutTests/fast/canvas/zero-size-fill-rect.html
https://bugs.webkit.org/show_bug.cgi?id=36837

Remove zero-size-fill-rect.html from skipped and create expected files.

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/zero-size-fill-rect-expected.checksum: Added.
  • platform/qt/fast/canvas/zero-size-fill-rect-expected.png: Added.
  • platform/qt/fast/canvas/zero-size-fill-rect-expected.txt:
1:36 PM Changeset in webkit [56864] by barraclough@apple.com
  • 6 edits
    2 adds in trunk

Bug 36871 - Remove JSC::CString
Use WTF::CString instead (which until recently was WebCore::CString).

Reviewed by Geoff Garen.

JavaScriptCore:

JavaScriptGlue:

  • ForwardingHeaders/wtf/text: Added.
  • ForwardingHeaders/wtf/text/CString.h: Added.
1:28 PM Changeset in webkit [56863] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch reads wrong bug url from unified diff context
https://bugs.webkit.org/show_bug.cgi?id=36477

Instead of trying to figure out the bug_id from the diff, we should
just get the information from the Checkout object, which understands
these concepts.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/commitinfo.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/mocktool.py:
1:28 PM Changeset in webkit [56862] by Darin Adler
  • 2 edits in trunk/WebCore
  • rendering/RenderThemeChromiumWin.h: Fix inconsistent line endings.
1:21 PM Changeset in webkit [56861] by hclam@chromium.org
  • 4 edits in trunk/LayoutTests

2010-03-31 Alpha Lam <hclam@chromium.org>

Reviewed by Darin Fisher.

Update test results due to changes in r56824.
https://bugs.webkit.org/show_bug.cgi?id=36900

  • platform/chromium-win/fast/forms/input-file-re-render-expected.checksum:
  • platform/chromium-win/fast/forms/input-file-re-render-expected.png:
  • platform/chromium/test_expectations.txt: fast/forms/input-file-re-render.html generates incorrect results on Linux, mark it so.
1:18 PM Changeset in webkit [56860] by eric@webkit.org
  • 5 edits
    3 adds in trunk/WebCore

2010-03-31 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - form controls style
https://bugs.webkit.org/show_bug.cgi?id=36370

Adjusting Mameo5 form elements rendering.

  • WebCore.pri:
  • WebCore.pro:
  • css/themeQtMaemo5.css: Added. (select): (select:disabled): (select:active): (select:active:disabled): (textarea): (textarea:disabled): (textarea:active):
  • platform/qt/Maemo5Webstyle.cpp: Added. (Maemo5WebStyle::Maemo5WebStyle): (drawRectangularControlBackgorund): (Maemo5WebStyle::drawChecker): (Maemo5WebStyle::findChecker): (Maemo5WebStyle::drawRadio): (Maemo5WebStyle::findRadio): (Maemo5WebStyle::drawControl): (Maemo5WebStyle::drawComplexControl):
  • platform/qt/Maemo5Webstyle.h: Added.
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::isControlStyled): (WebCore::RenderThemeQt::popupInternalPaddingBottom): (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
  • platform/qt/RenderThemeQt.h:
12:51 PM Changeset in webkit [56859] by ap@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36897
<rdar://problem/7804018> REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com)

Addressing additional review comments.

  • rendering/RenderWidget.cpp: Removed an unneeded include.
  • rendering/RenderWidget.h: Reworded the new comment.
12:48 PM Changeset in webkit [56858] by ap@apple.com
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=36897
<rdar://problem/7804018> REGRESSION (r56429): Flash ads are clipped when main page is scrolled (boxofficemojo.com)

  • manual-tests/plugin-in-iframe-scroll.html: Added.
  • manual-tests/resources/plugin-in-iframe-scroll-iframe.html: Added.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidgetGeometry): This method isn't called when an iframe containing the widget moves, so we should store a value that is not dependent on current scroll offset. (WebCore::RenderWidget::windowClipRect): Apply scroll offset and window clip now.
  • rendering/RenderWidget.h: Renamed m_windowClipRect to m_clipRect, because it is no longer in window coordinates.
  • WebCore.base.exp: Export RenderWidget::windowClipRect(), since it's no longer inline.
12:32 PM Changeset in webkit [56857] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch commit-queue should land patches optimistically
https://bugs.webkit.org/show_bug.cgi?id=34187

This patch adds an optimistic path to commit-queue and a "fail twice"
requirement for rejecting patches. That means we'll land good patches
faster (via the optmistic first run) and we'll reject many fewer
patches due to flaky tests.

  • Scripts/webkitpy/tool/commands/queues.py:
12:17 PM Changeset in webkit [56856] by kenneth@webkit.org
  • 3 edits in trunk/WebCore

Unreviewed crash fix.

Crash with frame flattening on after r56854
https://bugs.webkit.org/show_bug.cgi?id=36894

Solution tested by Greg Bolsinga, thanks.

  • page/FrameView.cpp:

(WebCore::FrameView::avoidScrollbarCreation):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

12:12 PM PythonGuidelines edited by Chris Jerdonek
Retitled, and clarified the minimum Python version requirement. (diff)
11:46 AM Changeset in webkit [56855] by Csaba Osztrogonác
  • 4 edits
    8 adds in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

iframe flattening doesn't flatten
https://bugs.webkit.org/show_bug.cgi?id=36798

Platform specific expected files added, and updated after r56852.

  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt: Added.
11:03 AM Changeset in webkit [56854] by kenneth@webkit.org
  • 6 edits in trunk/WebCore

Do not draw scrollbars for subframes when frame flattening is
enabled. Implemented using a virtual method in ScrollView as
suggested by Dave Hyatt.

Reviewed by Antti Koivisto.

Do not suppress scrollbars as that is wrong according to
Dave Hyatt.

Covered by current tests.

  • page/FrameView.cpp:

(WebCore::FrameView::avoidScrollbarCreation):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

  • platform/ScrollView.h:

(WebCore::ScrollView::avoidScrollbarCreation):

  • rendering/RenderPart.cpp:

(WebCore::RenderPart::layoutWithFlattening):

11:00 AM Changeset in webkit [56853] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-03-31 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[chromium] including WebKit.gyp:webkit should automatically add Skia
and NPAPI include paths

https://bugs.webkit.org/show_bug.cgi?id=36887

  • WebKit.gyp:
10:55 AM Changeset in webkit [56852] by kenneth@webkit.org
  • 3 edits
    4 adds in trunk

iframe flattening doesn't flatten
https://bugs.webkit.org/show_bug.cgi?id=36798

WebCore: Fix wrongly reversing logic in frame flattening check.

Reviewed by Antti Koivisto.

Tests:
fast/frames/flattening/iframe-flattening-fixed-height.html
fast/frames/flattening/iframe-flattening-fixed-width.html
fast/frames/flattening/iframe-flattening-fixed-width-and-height.html
fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html

  • rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::flattenFrame):

LayoutTests: Add more tests for iframe flattening

Reviewed by Antti Koivisto.

  • fast/frames/flattening/iframe-flattening-fixed-height.html
  • fast/frames/flattening/iframe-flattening-fixed-width.html
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height.html
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html
10:54 AM PythonGuidelines edited by Chris Jerdonek
Eliminated the Tips section (diff)
10:47 AM Changeset in webkit [56851] by eric@webkit.org
  • 23 edits in trunk

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Implements cancelGeolocationPermissionRequestForFrame.
Similar to requestGeolocationPermissionForFrame(), passes Geolocation* to cancelGeolocationPermissionRequestForFrame(),
so that the embedder can identify which Geolocation object is cancelling the pending permission request.
Calls cancelGeolocationPermissionRequestForFrame() before stopUpdating() so it better matches the startUpdating() / requestPermission() flow.
https://bugs.webkit.org/show_bug.cgi?id=35031

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::cancelGeolocationPermissionRequestForFrame):
  • page/Chrome.cpp: (WebCore::Chrome::cancelGeolocationPermissionRequestForFrame):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame):

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Implements cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

  • public/WebGeolocationService.h: (WebKit::WebGeolocationService::cancelPermissionRequestForFrame):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
  • src/ChromeClientImpl.h:

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame):
  • WebCoreSupport/ChromeClientGtk.h:

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebCoreSupport/ChromeClientHaiku.h: (WebCore::ChromeClientHaiku::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::cancelGeolocationPermissionRequestForFrame):

2010-03-31 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031

  • WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::cancelGeolocationPermissionRequestForFrame):
10:06 AM Changeset in webkit [56850] by yael.aharon@nokia.com
  • 8 edits
    2 adds in trunk/WebCore

Add animation to progress element
https://bugs.webkit.org/show_bug.cgi?id=36664

Reviewed by Antti Koivisto.

Add a timer to control the animation. The timer is started after painting
or a state change in the progress bar, to prevent animation from running
when the progress bar is not visible.

  • html/HTMLProgressElement.cpp:
  • platform/qt/RenderThemeQt.cpp:
  • platform/qt/RenderThemeQt.h:
  • rendering/RenderProgress.cpp:
  • rendering/RenderProgress.h:
  • rendering/RenderTheme.cpp:
  • rendering/RenderTheme.h:
10:01 AM Changeset in webkit [56849] by pfeldman@chromium.org
  • 9 edits in trunk

2010-03-31 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out r56829 since it broke chromium layout tests.

[REGRESSION] Inspector tests started crashing since r56829
https://bugs.webkit.org/show_bug.cgi?id=36888

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/V8Utilities.h:
  • loader/FrameLoaderClient.h: WebKit/chromium:
  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:
9:53 AM Changeset in webkit [56848] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-31 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

[Chromium] Enable fast/events/onbeforeunload-focused-iframe.html
https://bugs.webkit.org/show_bug.cgi?id=36781

  • platform/chromium/test_expectations.txt: Enable test now that callShouldCloseOnWebView is implemented in test_shell.
9:44 AM PythonGuidelines edited by Chris Jerdonek
Added section on consequences of not using Python 2.6 (diff)
9:29 AM Changeset in webkit [56847] by cmarrin@apple.com
  • 1 edit in trunk/WebKitSite/blog-files/webgl/WebGL+CSS.html

more tweaks to WebGL+CSS

9:23 AM Changeset in webkit [56846] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-03-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: creating new style bugfixing.

https://bugs.webkit.org/show_bug.cgi?id=36884

  • InspectorDOMAgent should clear internal state upon reset (we are re-using single dom agent instance throughout entire inspector controller lifetime)
  • Brought back blank style 'refresh' processing logic - remove it by mistake earlier
  • Blocked couple of click handlers so that double-click to edit was not expanding / collapsing the pane
  • There is no need to reach out for matched rules upon 'refresh' update - getting computed style is sufficient.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.getStylesCallback): (WebInspector.StylesSidebarPane.prototype.update.getComputedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._refreshUpdate): (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.StylesSidebarPane.prototype.addBlankSection): (WebInspector.StylePropertiesSection.prototype._dblclickEmptySpace): (WebInspector.StylePropertiesSection.prototype._clickSelector):
9:22 AM PythonGuidelines edited by Chris Jerdonek
Wording improvements to upgrade section. (diff)
9:16 AM PythonGuidelines edited by Chris Jerdonek
Added outline (diff)
9:10 AM Changeset in webkit [56845] by Laszlo Gombos
  • 2 edits in trunk/JavaScriptCore

2010-03-31 Laszlo Gombos <Laszlo Gombos>

Unreviewed, fix after r56842.

Add UNUSED_PARAM a to silence warning.

  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
9:09 AM Changeset in webkit [56844] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-03-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium build fix: create missing v8::HandleScope.

https://bugs.webkit.org/show_bug.cgi?id=36828

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::canAccessInspectedWindow):
9:01 AM Changeset in webkit [56843] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-03-31 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix crash

Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test_shell
https://bugs.webkit.org/show_bug.cgi?id=36885

  • inspector/audits-panel-functional.html:
  • platform/chromium/test_expectations.txt:
8:59 AM Changeset in webkit [56842] by Laszlo Gombos
  • 3 edits in trunk/JavaScriptCore

2010-03-31 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

Refactor JITStubs.cpp so that the list of STUB_FUNCTIONs
are not dependent on the JSVALUE32_64 guard.

  • jit/JITStubs.cpp: Place the JSVALUE32_64 guard inside the body of cti_op_eq_strings.
  • jit/JITStubs.h: Remove JSVALUE32_64 guard from cti_op_eq_strings stub.
8:24 AM Changeset in webkit [56841] by yurys@chromium.org
  • 10 edits in trunk

2010-03-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Check that injected script can still access inspected window object when wrapping console object. When the window cannot be access serialize objects as strings. Also don't call InjectedScript.dispatch if the window cannot be accessed (due to frame navigation).

https://bugs.webkit.org/show_bug.cgi?id=36828

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::canAccessInspectedWindow):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::canAccessInspectedWindow):
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::wrapForConsole):
  • inspector/InjectedScriptHost.h:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

2010-03-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: get rid of "Unsafe JavaScript attempt..." message when inspecting frames whose content has changed.

https://bugs.webkit.org/show_bug.cgi?id=36828

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
  • http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html:
7:45 AM Changeset in webkit [56840] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-31 Mattias Nissler <mnissler@google.com>

Reviewed by Pavel Feldman.

Allow generic resource URLs for cookie handling in the inspector. This
enables display of all cookies, not only those that are associated
with resources accessed through http, https or file.
https://bugs.webkit.org/show_bug.cgi?id=36877

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
  • inspector/front-end/DOMAgent.js: (WebInspector.Cookies.cookieMatchesResourceURL):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
7:42 AM Changeset in webkit [56839] by Nikolas Zimmermann
  • 1 edit
    2 adds in trunk/LayoutTests

2010-03-31 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add missing pixel test results for svg/filters/feColorMatrix-values.svg

  • platform/mac/svg/filters/feColorMatrix-values-expected.checksum: Added.
  • platform/mac/svg/filters/feColorMatrix-values-expected.png: Added.
7:26 AM Changeset in webkit [56838] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-31 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Custom user agent for user agent switcher
https://bugs.webkit.org/show_bug.cgi?id=36757

  • QtLauncher/main.cpp: (LauncherWindow::showUserAgentDialog):
6:27 AM Changeset in webkit [56837] by antti.j.koivisto@nokia.com
  • 3 edits in trunk/WebKit/qt

https://bugs.webkit.org/show_bug.cgi?id=36446
[Qt] QWebSettings::TiledBackingStoreEnabled attribute lacks documentation and default value

Reviewed by Kenneth Rohde Christiansen.

  • Api/qgraphicswebview.cpp:
  • Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

4:04 AM Changeset in webkit [56836] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Add stubs for moveWindowBy and setAttachedWindowHeight.

https://bugs.webkit.org/show_bug.cgi?id=36842

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsSetAttachedWindowHeight): (WebKit::WebDevToolsFrontendImpl::jsMoveWindowBy):
  • src/WebDevToolsFrontendImpl.h:
3:45 AM Changeset in webkit [56835] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

path to committers.py in commit-queue rejection message is wrong
https://bugs.webkit.org/show_bug.cgi?id=36865

This fix would have only been 3 lines long if we had

  1. Had access to an SCM object or tool to give us the checkout root
  2. Been able to depend on Python 2.6 Instead I've added a bunch of hack code, but at least now we should never have to update this string again as the location of committers.py is fully dynamically discovered. :p
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
3:35 AM Changeset in webkit [56834] by jorlow@chromium.org
  • 6 edits
    1 copy
    1 move in trunk/WebCore

2010-03-30 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB: Finish hooking up bindings for IndexedDatabaseRequest
https://bugs.webkit.org/show_bug.cgi?id=36830

Still not enough hooked up to test. Soon!

  • WebCore.gypi:
  • bindings/v8/custom/V8CustomIDBCallback.h: Removed.
  • bindings/v8/custom/V8CustomIDBCallbacks.h: Added. (WebCore::V8CustomIDBCallbacks::create): (WebCore::V8CustomIDBCallbacks::~V8CustomIDBCallbacks): (WebCore::V8CustomIDBCallbacks::onSuccess): (WebCore::V8CustomIDBCallbacks::onError): (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks):
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
  • storage/IDBDatabaseRequest.cpp: Added. (WebCore::IDBDatabaseRequest::IDBDatabaseRequest): (WebCore::IDBDatabaseRequest::~IDBDatabaseRequest):
  • storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::create):
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:
3:26 AM Changeset in webkit [56833] by eric@webkit.org
  • 5 edits in trunk

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Implement memmove behavior for WebGLArray set()
https://bugs.webkit.org/show_bug.cgi?id=35619

  • fast/canvas/webgl/array-setters-expected.txt: Testing shared overlapping buffer set() behaviors.
  • fast/canvas/webgl/array-setters.html: Ditto.

2010-03-31 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Implement memmove behavior for WebGLArray set()
https://bugs.webkit.org/show_bug.cgi?id=35619

New test cases are added to fast/canvas/webgl/array-setters.html.

  • html/canvas/WebGLArray.cpp: Use memmove instead of memcpy; with memmove, copying takes place as if an intermediate buffer was used, allowing the destination and source to overlap. (WebCore::WebGLArray::setImpl):
3:08 AM Changeset in webkit [56832] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-31 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

[chromium] test_expectations.txt swept for MAC test cases becoming PASS
https://bugs.webkit.org/show_bug.cgi?id=36863

  • platform/chromium/test_expectations.txt: Cleaned up test_expectations.txt for MAC which are now PASS.
2:50 AM Changeset in webkit [56831] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-31 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Darin Adler.

tryLayoutDoingPositionedMovementOnly does not have to be in RenderObject or be virtual
https://bugs.webkit.org/show_bug.cgi?id=36810

Move tryLayoutDoingPositionedMovementOnly as a regular method of RenderBox

  • rendering/RenderBox.h: (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
  • rendering/RenderObject.h:
2:48 AM QtWebKitJournal edited by fboudra@gmail.com
(diff)
1:56 AM Changeset in webkit [56830] by eric@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2010-03-31 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Darin Adler.

[Qt] Remove LayoutTests/fast/canvas/image-object-in-canvas.html from Skipped
https://bugs.webkit.org/show_bug.cgi?id=36836

Enable LayoutTests/fast/canvas/image-object-in-canvas.html at LayoutTests

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/image-object-in-canvas-expected.checksum: Added.
  • platform/qt/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/qt/fast/canvas/image-object-in-canvas-expected.txt:
1:37 AM Changeset in webkit [56829] by eric@webkit.org
  • 9 edits in trunk

2010-03-31 John Gregg <johnnyg@google.com>

Reviewed by Darin Fisher.

[chromium] add logging of cross-frame property accesses for site isolation
https://bugs.webkit.org/show_bug.cgi?id=35773

No new tests as no new functionality.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Utilities.cpp: (WebCore::logPropertyAccess):
  • bindings/v8/V8Utilities.h:
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::logCrossFramePropertyAccess):

2010-03-31 John Gregg <johnnyg@google.com>

Reviewed by Darin Fisher.

[chromium] add logging of cross-frame property accesses for site isolation
https://bugs.webkit.org/show_bug.cgi?id=35773

  • public/WebFrameClient.h: (WebKit::WebFrameClient::logCrossFramePropertyAccess):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::logCrossFramePropertyAccess):
  • src/FrameLoaderClientImpl.h:
12:16 AM April 2010 Meeting edited by kim.gronholm@nomovok.com
(diff)
12:14 AM Changeset in webkit [56828] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-31 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed test fix for r56809.

webkit-patch what-broke throws exception
https://bugs.webkit.org/show_bug.cgi?id=36852

  • Scripts/webkitpy/common/checkout/api_unittest.py:
12:04 AM Changeset in webkit [56827] by hamaji@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2010-03-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

[Chromium] fast/repaint/overflow-scroll-body-appear need to be rebaselined
https://bugs.webkit.org/show_bug.cgi?id=36825

  • platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

Mar 30, 2010:

11:09 PM Changeset in webkit [56826] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixing b0rked version of JavaScriptCore.vcproj - added lines were truncated.

Reviewed by NOBODY (windows build fix).

10:44 PM Changeset in webkit [56825] by barraclough@apple.com
  • 259 edits
    2 moves
    3 adds in trunk

Rubber stamped by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=36866
Move CString to WTF

JavaScriptCore:

(WTF::CStringBuffer::data):
(WTF::CStringBuffer::length):
(WTF::CStringBuffer::create):
(WTF::CStringBuffer::CStringBuffer):
(WTF::CStringBuffer::mutableData):
(WTF::CString::CString):
(WTF::CString::isNull):
(WTF::CString::buffer):
(WTF::operator!=):

WebCore:

  • Android.mk:
  • ForwardingHeaders/wtf/text: Added.
  • ForwardingHeaders/wtf/text/CString.h: Added.
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/ScheduledAction.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bridge/jni/JNIBridge.cpp:
  • bridge/jni/v8/JavaStringV8.h:

(JSC::Bindings::JavaStringImpl::init):

  • css/CSSParser.cpp:
  • dom/CharacterData.cpp:
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/Node.cpp:
  • dom/Position.cpp:
  • dom/Range.cpp:
  • dom/Text.cpp:
  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizerLibxml2.cpp:
  • dom/XMLTokenizerQt.cpp:
  • editing/SelectionController.cpp:
  • editing/VisiblePosition.cpp:
  • editing/VisibleSelection.cpp:
  • history/CachedFrame.cpp:
  • history/HistoryItem.cpp:
  • history/qt/HistoryItemQt.cpp:
  • html/FormDataList.h:

(WebCore::FormDataList::appendData):
(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::data):

  • html/HTMLDocument.cpp:
  • html/PreloadScanner.cpp:
  • inspector/InspectorController.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • loader/DocLoader.cpp:
  • loader/FTPDirectoryDocument.cpp:
  • loader/FrameLoader.cpp:
  • loader/HistoryController.cpp:
  • loader/ProgressTracker.cpp:
  • loader/appcache/ApplicationCacheStorage.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/icon/wince/IconDatabaseWince.cpp:
  • loader/loader.cpp:
  • page/Console.cpp:
  • page/DOMWindow.cpp:
  • page/SecurityOrigin.cpp:
  • page/XSSAuditor.cpp:
  • page/animation/AnimationBase.cpp:
  • platform/ContextMenu.cpp:
  • platform/FileSystem.h:
  • platform/KURL.cpp:
  • platform/KURLGoogle.cpp:
  • platform/KURLGooglePrivate.h:
  • platform/Pasteboard.h:
  • platform/android/FileSystemAndroid.cpp:
  • platform/android/TemporaryLinkStubs.cpp:
  • platform/brew/KURLBrew.cpp:
  • platform/cf/FileSystemCF.cpp:
  • platform/chromium/MIMETypeRegistryChromium.cpp:
  • platform/efl/FileSystemEfl.cpp:
  • platform/efl/PasteboardEfl.cpp:
  • platform/efl/PlatformKeyboardEventEfl.cpp:
  • platform/efl/PlatformScreenEfl.cpp:
  • platform/efl/RenderThemeEfl.cpp:
  • platform/efl/ScrollbarEfl.cpp:
  • platform/efl/SharedBufferEfl.cpp:
  • platform/efl/WidgetEfl.cpp:
  • platform/graphics/GlyphPageTreeNode.cpp:
  • platform/graphics/cairo/FontPlatformDataCairo.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/chromium/FontCacheLinux.cpp:
  • platform/graphics/chromium/FontPlatformDataLinux.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gtk/FontPlatformDataPango.cpp:
  • platform/graphics/gtk/IconGtk.cpp:
  • platform/graphics/gtk/ImageGtk.cpp:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp:
  • platform/graphics/mac/GraphicsContext3DMac.cpp:
  • platform/graphics/mac/GraphicsLayerCA.mm:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/skia/GraphicsLayerSkia.cpp:
  • platform/graphics/win/GraphicsLayerCACF.cpp:
  • platform/graphics/win/WKCACFLayer.cpp:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/gtk/ClipboardGtk.cpp:
  • platform/gtk/ContextMenuItemGtk.cpp:
  • platform/gtk/DataObjectGtk.h:
  • platform/gtk/FileChooserGtk.cpp:
  • platform/gtk/FileSystemGtk.cpp:
  • platform/gtk/GeolocationServiceGtk.cpp:
  • platform/gtk/KURLGtk.cpp:
  • platform/gtk/Language.cpp:
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/gtk/PopupMenuGtk.cpp:
  • platform/gtk/RenderThemeGtk.cpp:
  • platform/gtk/SharedBufferGtk.cpp:
  • platform/haiku/FileSystemHaiku.cpp:
  • platform/haiku/PlatformKeyboardEventHaiku.cpp:
  • platform/network/CredentialStorage.cpp:
  • platform/network/FormData.cpp:
  • platform/network/FormData.h:
  • platform/network/FormDataBuilder.cpp:
  • platform/network/FormDataBuilder.h:
  • platform/network/HTTPParsers.cpp:
  • platform/network/android/ResourceHandleAndroid.cpp:
  • platform/network/cf/FormDataStreamCFNet.cpp:
  • platform/network/cf/ResourceHandleCFNet.cpp:
  • platform/network/chromium/ResourceResponse.h:
  • platform/network/curl/FormDataStreamCurl.cpp:
  • platform/network/curl/ResourceHandleManager.cpp:
  • platform/network/curl/ResourceHandleManager.h:
  • platform/network/mac/FormDataStreamMac.mm:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/qt/QNetworkReplyHandler.cpp:
  • platform/network/soup/CookieJarSoup.cpp:
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/soup/ResourceRequestSoup.cpp:
  • platform/network/soup/ResourceResponseSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp:
  • platform/posix/FileSystemPOSIX.cpp:
  • platform/qt/FileSystemQt.cpp:
  • platform/qt/KURLQt.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp:
  • platform/text/CString.cpp: Removed.
  • platform/text/CString.h: Removed.
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:
  • platform/text/StringImpl.cpp:
  • platform/text/TextCodec.h:
  • platform/text/TextCodecICU.cpp:
  • platform/text/TextCodecLatin1.cpp:
  • platform/text/TextCodecUTF16.cpp:
  • platform/text/TextCodecUserDefined.cpp:
  • platform/text/TextEncoding.cpp:
  • platform/text/TextEncoding.h:
  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
  • platform/text/gtk/TextCodecGtk.cpp:
  • platform/text/haiku/StringHaiku.cpp:
  • platform/text/mac/TextCodecMac.cpp:
  • platform/text/qt/TextCodecQt.cpp:
  • platform/text/wx/StringWx.cpp:
  • platform/win/ClipboardUtilitiesWin.cpp:
  • platform/win/ClipboardWin.cpp:
  • platform/win/ContextMenuItemWin.cpp:
  • platform/win/ContextMenuWin.cpp:
  • platform/win/FileSystemWin.cpp:
  • platform/win/GDIObjectCounter.cpp:
  • platform/win/Language.cpp:
  • platform/win/PasteboardWin.cpp:
  • platform/wince/FileSystemWince.cpp:
  • platform/wince/KeygenWince.cpp:
  • platform/wince/PasteboardWince.cpp:
  • platform/wx/FileSystemWx.cpp:
  • platform/wx/LoggingWx.cpp:
  • plugins/PluginDebug.h:
  • plugins/PluginPackage.cpp:
  • plugins/PluginStream.cpp:
  • plugins/PluginStream.h:
  • plugins/PluginView.h:
  • plugins/gtk/PluginPackageGtk.cpp:
  • plugins/mac/PluginPackageMac.cpp:
  • plugins/qt/PluginPackageQt.cpp:
  • plugins/symbian/PluginPackageSymbian.cpp:
  • plugins/win/PluginPackageWin.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderTreeAsText.cpp:
  • storage/Database.cpp:
  • storage/SQLTransactionCoordinator.cpp:
  • storage/SQLTransactionCoordinator.h:
  • storage/StorageAreaSync.cpp:
  • storage/StorageSyncManager.cpp:
  • storage/chromium/DatabaseTrackerChromium.cpp:
  • storage/chromium/QuotaTracker.cpp:
  • storage/chromium/QuotaTracker.h:
  • svg/SVGFontFaceElement.cpp:
  • svg/SVGStyledElement.cpp:
  • svg/SVGUseElement.cpp:
  • websockets/WebSocket.cpp:
  • websockets/WebSocketChannel.cpp:
  • websockets/WebSocketHandshake.cpp:
  • wml/WMLErrorHandling.cpp:
  • wml/WMLGoElement.cpp:
  • wml/WMLPageState.cpp:
  • wml/WMLPostfieldElement.cpp:
  • wml/WMLSelectElement.cpp:
  • xml/XMLHttpRequest.cpp:
  • xml/XSLStyleSheetLibxslt.cpp:
  • xml/XSLTProcessorLibxslt.cpp:

WebKit:

  • efl/WebCoreSupport/ChromeClientEfl.cpp:
  • efl/ewk/ewk_frame.cpp:

(ewk_frame_name_get):
(ewk_frame_selection_get):
(ewk_frame_uri_changed):

  • efl/ewk/ewk_history.cpp:
  • efl/ewk/ewk_settings.cpp:

WebKit/chromium:

  • public/WebCString.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/GraphicsContext3D.cpp:
  • src/WebCString.cpp:

(WebKit::WebCString::assign):
(WebKit::WebCString::WebCString):
(WebKit::WebCString::operator=):
(WebKit::WebCString::operator WTF::CString):

  • src/WebMediaPlayerClientImpl.cpp:
  • src/WebString.cpp:
  • src/WebURLError.cpp:

WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • WebCoreSupport/EditorClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/InspectorClientGtk.cpp:
  • gdom/ConvertToGCharPrivate.h:
  • webkit/webkitdownload.cpp:
  • webkit/webkithittestresult.cpp:
  • webkit/webkitnetworkrequest.cpp:
  • webkit/webkitprivate.h:
  • webkit/webkitsecurityorigin.cpp:
  • webkit/webkitwebdatabase.cpp:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_finalize):
(webkit_web_history_item_get_target):

  • webkit/webkitwebresource.cpp:
  • webkit/webkitwebsettings.cpp:
  • webkit/webkitwebview.cpp:

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::getCookies):
(WebKit::NetscapePluginInstanceProxy::getProxy):
(WebKit::NetscapePluginInstanceProxy::getAuthenticationInfo):
(WebKit::NetscapePluginInstanceProxy::resolveURL):

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView resolveURL:forTarget:]):

WebKit/qt:

  • Api/qwebelement.cpp:

WebKit/win:

  • WebDownload.cpp:
  • WebDownloadCFNet.cpp:
  • WebDownloadCurl.cpp:
  • WebHistoryItem.cpp:
  • WebLocalizableStrings.cpp:
  • WebMutableURLRequest.cpp:
  • WebPreferences.cpp:

(WebPreferences::migrateWebKitPreferencesToCFPreferences):

  • WebView.cpp:

WebKit/wx:

  • WebFrame.cpp:
  • WebView.cpp:
9:35 PM Changeset in webkit [56824] by tkent@chromium.org
  • 7 edits in trunk

2010-03-30 Kent Tamura <tkent@chromium.org>

Reviewed by Brady Eidson.

REGRESSION (r56439) - Crash when a renderer for a file upload control
with a selected file is recreated
https://bugs.webkit.org/show_bug.cgi?id=36723

  • fast/forms/input-file-re-render.html: Force to do re-layout to check the regression.

2010-03-30 Kent Tamura <tkent@chromium.org>

Reviewed by Brady Eidson.

REGRESSION (r56439) - Crash when a renderer for a file upload control
with a selected file is recreated
https://bugs.webkit.org/show_bug.cgi?id=36723

RenderFileUploadControl::chooseIconForFiles was called before
m_fileChooser was initialized.

  • platform/FileChooser.cpp: (WebCore::FileChooser::FileChooser): Introduce m_isInitializing flag to avoid FileChooserClient::repaint() call. (WebCore::FileChooser::loadIcon): (WebCore::FileChooser::iconLoaded):
  • platform/FileChooser.h: Add a FielChooser parameter to FileChooserClient::chooseIconForFiles().
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::chooseIconForFiles): (WebCore::RenderFileUploadControl::paintObject): Add an assertion.
  • rendering/RenderFileUploadControl.h:
9:32 PM Changeset in webkit [56823] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Rubber stamped by Dave Levin.

Made check-webkit-style less chatty.

Examples include:

  • Scripts/webkitpy/style/checker.py:
    • Changed unrecognized file type log message from info to debug.
8:36 PM Changeset in webkit [56822] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2010-03-30 Stanislav Paltis <Stanislav.Paltis@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] qmake/symbian build failure
https://bugs.webkit.org/show_bug.cgi?id=36745

Fix build break in Symbian build introduced in r56714,
by modifying comment escape character from ";" to "#".

  • WebCore.pro:
8:09 PM April 2010 Meeting edited by staikos@kde.org
(diff)
7:00 PM Changeset in webkit [56821] by yuzo@google.com
  • 3 edits
    2 deletes in trunk/LayoutTests

2010-03-30 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Fix LayoutTests/fast/dom/Window/window-resize.html
The test failed on Mac if Dock is placed on the left or the right because the window's width
and horizontal position can be adjusted by the OS.
This patch fixes it by using window.availWidth instead of window.width as the expected
values and by avoid using constant expected values.
As a side effect, the expected values become platform independent.

https://bugs.webkit.org/show_bug.cgi?id=36813

  • fast/dom/Window/window-resize-expected.txt:
  • fast/dom/Window/window-resize.html:
  • platform/mac/fast/dom/Window/window-resize-expected.txt: Removed.
  • platform/win/fast/dom/Window/window-resize-expected.txt: Removed.
6:25 PM Changeset in webkit [56820] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Alpha Lam <hclam@chromium.org>

Reviewed by Dmitry Titov.

[chromium] Fix test expectations for a new test added in r56779
https://bugs.webkit.org/show_bug.cgi?id=36868

inspector/audits-panel-functional.html is crashing on Windows. Mark it so.

  • platform/chromium/test_expectations.txt: Add expectation for inspector/audits-panel-functional.html to mark it as crashing.
6:19 PM Changeset in webkit [56819] by kevino@webkit.org
  • 6 edits in trunk

wx build fixes after new method additions and a method rename.

5:35 PM Changeset in webkit [56818] by hclam@chromium.org
  • 7 edits
    6 adds in trunk/LayoutTests

2010-03-30 Alpha Lam <hclam@chromium.org>

Reviewed by Dmitry Titov.

[chromium] New test results due to 56776
https://bugs.webkit.org/show_bug.cgi?id=36857

Adding new layout test results for chromium for tests added in r56776.

  • platform/chromium-linux/svg/custom/glyph-transformation-with-hkern-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/chromium-win/svg/custom/glyph-transformation-with-hkern-expected.checksum: Added.
  • platform/chromium-win/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium/test_expectations.txt: Removed the failing expectation for platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html because the difference in only in the scroll bar, there is not difference in the image content. Also fixed a grammar problem in last commit.
5:34 PM Changeset in webkit [56817] by hclam@chromium.org
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py

fixed rebaseline

5:27 PM Changeset in webkit [56816] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, expectations tweak.

Updating expectations to stop skipping tests that were fixed in r56481.

  • platform/chromium/test_expectations.txt: Don't skip fixed tests.
4:58 PM Changeset in webkit [56815] by weinig@apple.com
  • 2 edits in trunk/WebCore

Add missing export.

Reviewed by Anders Carlsson.

  • WebCore.base.exp:
4:44 PM Changeset in webkit [56814] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Alpha Lam <hclam@chromium.org>

Reviewed by David Levin.

[chromium] Fix test_expectations for new test added in r56795
https://bugs.webkit.org/show_bug.cgi?id=36861

  • platform/chromium/test_expectations.txt: Expects svg/animations/animate-points.html to fail because a API is missing in Chromium. See http://crbug.com/39904.
4:12 PM Changeset in webkit [56813] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Incorrect insertion position after typing THAI CHARACTER SARA AM = 0E33.
<rdar://problem/7810749>
https://bugs.webkit.org/show_bug.cgi?id=36858

Reviewed by Darin Adler.

WebCore:

Test: fast/text/multiglyph-characters.html

Characters with multiple glyph were not supported correctly.
Computing the advance width was producing a division by zero.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::advance):

LayoutTests:

  • fast/text/multiglyph-characters-expected.txt: Added.
  • fast/text/multiglyph-characters.html: Added.
3:35 PM Changeset in webkit [56812] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

3:33 PM Changeset in webkit [56811] by mrowe@apple.com
  • 1 copy in tags/Safari-533.3

New tag.

2:51 PM Changeset in webkit [56810] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2010-03-30 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add test for SVG pattern canvas tainting.

https://bugs.webkit.org/show_bug.cgi?id=36838

  • fast/canvas/svg-taint.html: Added
  • fast/canvas/svg-taint-expected.txt: Added
  • fast/canvas/resources/empty.svg: Added

2010-03-30 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Taint the canvas if an SVG-derived pattern is rendered into it.

https://bugs.webkit.org/show_bug.cgi?id=36838

Test: fast/canvas/svg-taint.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern): Take into account the image's hasSingleSecurityOrigin() property.
2:44 PM Changeset in webkit [56809] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch what-broke throws exception
https://bugs.webkit.org/show_bug.cgi?id=36852

  • Scripts/webkitpy/common/checkout/api.py: Add missing import StringIO.
  • Scripts/webkitpy/common/checkout/api_unittest.py: Test the function which previously threw and exception.
2:27 PM Changeset in webkit [56808] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36616
Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown

https://bugs.webkit.org/show_bug.cgi?id=36797
For non-Roman layouts, keydown Event.keyCode is always 0

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): Generate a correct keyCode for keys used in tests (we used to always pass 0 for 'A').
1:58 PM April 2010 Meeting edited by jasonr@bsquare.com
(diff)
1:48 PM Changeset in webkit [56807] by scherkus@chromium.org
  • 3 edits in trunk/LayoutTests

2010-03-30 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Darin Adler.

Updating expectations for video-no-audio.html to reflect changes made in r56481.

https://bugs.webkit.org/show_bug.cgi?id=36846

  • platform/mac-tiger/media/video-no-audio-expected.txt: Updating due to different source video dimensions.
  • platform/win/media/video-no-audio-expected.txt: Ditto.
1:37 PM Changeset in webkit [56806] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=36848
<rdar://problem/7362913>
Menu items appropriate only for rich-content editing can appear in plain-text contexts

Reviewed by Dan Bernstein.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView validRequestorForSendType:returnType:]):
Don't return self for non-string content if _canEditRichly is false.

1:10 PM Changeset in webkit [56805] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-30 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QGraphicsScene mousePressEvent does not set the clickCausedFocus flag
https://bugs.webkit.org/show_bug.cgi?id=35259

The clickCausedFocus flag is not being set in method
mousePressEvent(QGraphicsSceneMouseEvent* ev). This flag is used
in conjunction with QStyle::RSIP_OnMouseClickAndAlreadyFocused when
deciding to launch the software input panel.

  • Api/qwebpage.cpp: (QWebPagePrivate::mousePressEvent):
1:00 PM Changeset in webkit [56804] by ap@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36616
Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown

https://bugs.webkit.org/show_bug.cgi?id=36797
For non-Roman layouts, keydown Event.keyCode is always 0

  • platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForKeyCode): This is now the primary function for determining Windows key code - there is no reason to round trip a virtual key code via character code to get Windows virtual key code, and this can't work for non-Roman alphabets. (WebCore::windowsKeyCodeForCharCode): Removed keys that are now handled in windowsKeyCodeForKeyCode(), only keeping those for which we don't have known key codes (yet?).
  • platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Added comments.
12:51 PM Changeset in webkit [56803] by eric@webkit.org
  • 9 edits
    2 copies
    1 move
    1 add in trunk

2010-03-30 Marcus Bulach <bulach@chromium.org>

Reviewed by Darin Fisher.

Rename / tidy up Geolocation bridge
Uses Geoposition instead of individual params for setLastPosition.
https://bugs.webkit.org/show_bug.cgi?id=36535

  • platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceChromium::GeolocationServiceChromium): (WebCore::GeolocationServiceChromium::setIsAllowed): (WebCore::GeolocationServiceChromium::setLastPosition):
  • platform/chromium/GeolocationServiceChromium.h:

2010-03-30 Marcus Bulach <bulach@chromium.org>

Reviewed by Darin Fisher.

Rename / tidy up Geolocation bridge:
Rename GeolocationServiceBridgeChromium.cpp to WebGeolocationServiceBridgeImpl.cpp
Uses a temporary compatibility layer in GeolocationServiceBridgeChromium.h.

https://bugs.webkit.org/show_bug.cgi?id=36535

  • WebKit.gyp:
  • public/GeolocationServiceBridgeChromium.h:
  • public/WebGeolocationService.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h. (WebKit::WebGeolocationService::detachBridge):
  • public/WebGeolocationServiceBridge.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
  • public/WebViewClient.h: (WebKit::WebViewClient::geolocationService):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
  • src/ChromiumBridge.cpp:
  • src/GeolocationServiceBridgeChromium.cpp: Removed.
  • src/WebGeolocationServiceBridgeImpl.cpp: Copied from WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp. (WebKit::createGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::getBridgeId): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::getWebViewClient):
  • src/WebGeolocationServiceBridgeImpl.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
12:31 PM Changeset in webkit [56802] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement win-ews
https://bugs.webkit.org/show_bug.cgi?id=36809

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
12:21 PM Changeset in webkit [56801] by cmarrin@apple.com
  • 1 edit in trunk/WebKitSite/blog-files/webgl/WebGL+CSS.html

Fixed some size issues caused by how we now compute the WebGL canvas size

11:16 AM Changeset in webkit [56800] by agl@chromium.org
  • 7 edits in trunk

2010-03-30 Adam Langley <agl@chromium.org>

Reviewed by David Levin.

[chromium] linux: prefer the "hinting" fontconfig preference.

fontconfig can give contradictory hinting information, setting
"hinting" to zero and "hintstyle" to non-zero. In this case we
should take the "hinting" preference.

https://bugs.webkit.org/show_bug.cgi?id=36602

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
10:42 AM Changeset in webkit [56799] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-03-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Copying from the Content tab in Resources includes line numbers.

https://bugs.webkit.org/show_bug.cgi?id=35104

10:32 AM Changeset in webkit [56798] by pfeldman@chromium.org
  • 5 edits in trunk

2010-03-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not send empty matching rules for pseudo elements to frontend.

https://bugs.webkit.org/show_bug.cgi?id=36834

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update):
10:09 AM Changeset in webkit [56797] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=36791
Add assertions for instance proxy validity

Add some assertions that the instance proxy hasn't been deleted. We sometimes keep a raw
pointer to one across complicated function calls, relying on the caller to protect the
reference.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::renderContextID): (WebKit::NetscapePluginInstanceProxy::pluginView): (WebKit::NetscapePluginInstanceProxy::hostProxy):
9:57 AM Changeset in webkit [56796] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Update test_expectations.txt to enable send-dragged-sliced-file.html
https://bugs.webkit.org/show_bug.cgi?id=36764

Reviewed by Dmitry Titov.

  • platform/chromium/test_expectations.txt:
9:40 AM Changeset in webkit [56795] by krit@webkit.org
  • 8 edits
    3 adds in trunk

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Cannot animate "points" attribute for <svg:polygon>
https://bugs.webkit.org/show_bug.cgi?id=21371

Add animation support for 'points' on polygons in SVG.

Test: svg/animations/animate-points.html

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::determinePropertyType): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGAnimateElement.h: (WebCore::SVGAnimateElement::): added PropertyType PointsProperty
  • svg/SVGPointList.cpp: (WebCore::blendFunc): (WebCore::SVGPointList::createAnimated): calculates animated PointList
  • svg/SVGPointList.h:

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Cannot animate "points" attribute for <svg:polygon>
https://bugs.webkit.org/show_bug.cgi?id=21371

Tests if points of a polygon are animateable.

  • svg/animations/animate-points-expected.txt: Added.
  • svg/animations/animate-points.html: Added.
  • svg/animations/script-tests/animate-points.js: Added. (sample1): (sample2): (sample3): (executeTest):
9:18 AM Changeset in webkit [56794] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Adjusted test-webkitpy to delete all orphaned *.pyc files
from webkitpy/ prior to importing any modules from webkitpy.
This ensures that no import statements in webkitpy falsely
succeed because of leftover *.pyc files.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=36599

  • Scripts/test-webkitpy:
    • Added _clean_pyc_files() to delete orphaned *.pyc files from a directory.
    • Added _clean_webkitpy_with_test() to call and test _clean_pyc_files().
    • Moved the "import webkitpy.python24.versioning" statement from the top of the module to the init() method -- immediately after the call to _clean_webkitpy_with_test().
8:43 AM Changeset in webkit [56793] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: bring test expectation back - it still fails for some
reason.

  • platform/chromium/test_expectations.txt:
8:40 AM Changeset in webkit [56792] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits: bad CSS selector results in exception inside evaluated code
https://bugs.webkit.org/show_bug.cgi?id=36821

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
8:23 AM Changeset in webkit [56791] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Fix build break on Qt Mac.

Reviewed by nobody, build break.

DESTDIR path on Mac do not include the configuration path by default
like on Windows. Have to force it.

7:51 AM Changeset in webkit [56790] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Package build fixes for Symbian

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-03-29
Reviewed by Simon Hausmann.

  • enable building standalone QtWebkit for Symbian using qtlibinfix configuration option

qtlibinfix adds possibility having multiple versions of Qt in Symbian devices.
Fix also allows unfrozen DLL exports during development.

  • Removed heap size configuration. DLLs don't have a heap.
  • Removed enforcement to def files for package builds. Instead inherit the setting from

Qt's qconfig.pri whether to use def files or not. It's still possible to override this
also at qmake time by passing CONFIG+=def_files.

  • WebCore.pro:
7:50 AM Changeset in webkit [56789] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-03-30 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Title for show/hide short records button was adjusted.
Some unused code was removed.
https://bugs.webkit.org/show_bug.cgi?id=36823

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
7:49 AM Changeset in webkit [56788] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium/test_expectations.txt:
7:45 AM Changeset in webkit [56787] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: removed failure expectation from Chromium.

  • platform/chromium/test_expectations.txt:
7:16 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
7:13 AM Changeset in webkit [56786] by Adam Roben
  • 2 edits in trunk/WebKit/win

Windows build fix

  • Interfaces/WebKit.idl: Touched this to force a build.
7:13 AM Changeset in webkit [56785] by Adam Roben
  • 2 edits in trunk/WebCore

Enable extra Direct3D debugging information in Debug builds

This makes it easier to track down memory leaks and misuses of the D3D
APIs in Debug builds.

Fixes <http://webkit.org/b/36820>

Reviewed by John Sullivan.

  • platform/graphics/win/WKCACFLayerRenderer.cpp: Define D3D_DEBUG_INFO

in Debug builds before #including d3d9.h so that extra D3D debugging
information will be enabled.

7:10 AM April 2010 Meeting edited by ukai@chromium.org
Add Fumitoshi Ukai (diff)
7:10 AM Changeset in webkit [56784] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2010-03-30 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - QtMaemoWebPopup class
https://bugs.webkit.org/show_bug.cgi?id=36790

Moving maemo5 theme related code from WebCore.pri to WebCore.pro and adding
new maemo menu lists popup class source and header to the project.

The code was in .pri file because of a theme css that was conditionally included.
As the css file is been included unconditionally there is no need to this
code to be kept in webcore.pri.

  • WebCore.pri:
  • WebCore.pro:

2010-03-30 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - QtMaemoWebPopup class
https://bugs.webkit.org/show_bug.cgi?id=36790

A new QtAbstractWebPopup descendant class to be used for maemo menu lists.
This is the first step. The next step will be the dialogs implementation that
will come in bug 36789 and finally to use QtMaemoWebPopup instead of QtFallbackWebPopup
that will come in bug 36368.

  • WebCoreSupport/QtMaemoWebPopup.cpp: Added. (WebCore::QtMaemoWebPopup::QtMaemoWebPopup): (WebCore::QtMaemoWebPopup::~QtMaemoWebPopup): (WebCore::QtMaemoWebPopup::createSingleSelectionPopup): (WebCore::QtMaemoWebPopup::createMultipleSelectionPopup): (WebCore::QtMaemoWebPopup::createPopup): (WebCore::QtMaemoWebPopup::show): (WebCore::QtMaemoWebPopup::hide): (WebCore::QtMaemoWebPopup::popupClosed): (WebCore::QtMaemoWebPopup::itemClicked):
  • WebCoreSupport/QtMaemoWebPopup.h: Added. (WebCore::Maemo5Popup::Maemo5Popup):
7:01 AM FAQ edited by tony@gonk.net
Fixed incorrect use of “it’s”. Changed hyphen to m-dash. (diff)
7:01 AM Changeset in webkit [56783] by jchaffraix@webkit.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

fast/parser/comments.html needs some clean-up
https://bugs.webkit.org/show_bug.cgi?id=36537

Reviewed by Darin Adler.

  • The test is converted to dumpAsText now.
  • The output is also made more explicit as to what is expected (adding some PASSED and FAILED).
  • Finally some part of the test were actually commented so added some comment endings to make sure we run all the part of the test.
  • fast/parser/comments-expected.txt: Added.
  • fast/parser/comments.html:
  • platform/chromium-linux/fast/parser/comments-expected.checksum: Removed.
  • platform/chromium-linux/fast/parser/comments-expected.png: Removed.
  • platform/chromium-win/fast/parser/comments-expected.checksum: Removed.
  • platform/chromium-win/fast/parser/comments-expected.png: Removed.
  • platform/chromium-win/fast/parser/comments-expected.txt: Removed.
  • platform/mac/fast/parser/comments-expected.checksum: Removed.
  • platform/mac/fast/parser/comments-expected.png: Removed.
  • platform/mac/fast/parser/comments-expected.txt: Removed.
  • platform/qt/fast/parser/comments-expected.txt: Removed.
6:45 AM Changeset in webkit [56782] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-30 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Remove dysfunctional implementation of canEstablishDatabase for
Workers. I postpone this implementation until Workers can actually
access Web Databases.

https://bugs.webkit.org/show_bug.cgi?id=36795

  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/WebWorkerBase.h:
6:27 AM Changeset in webkit [56781] by eric@webkit.org
  • 16 edits
    1 add in trunk

2010-03-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by David Kilzer.

Guard Geolocation files with ENABLE_GEOLOCATION
https://bugs.webkit.org/show_bug.cgi?id=25756

The intent is to guard the Geolocation implementation files
and minimize the impact on on clients/call sites.

  • DerivedSources.make:
  • WebCore.Geolocation.exp: Added. Exported interfaces if GEOLOCATION is enabled.
  • WebCore.base.exp:
  • bindings/js/JSCustomPositionCallback.cpp:
  • bindings/js/JSCustomPositionErrorCallback.cpp:
  • bindings/js/JSGeolocationCustom.cpp:
  • page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame): Stub implementation if GEOLOCATION is turned off. (WebCore::Geolocation::Geolocation): Ditto. (WebCore::Geolocation::~Geolocation): Ditto. (WebCore::Geolocation::setIsAllowed): Ditto.
  • page/Geolocation.h:
  • page/Geolocation.idl:
  • page/GeolocationPositionCache.cpp:
  • page/Geoposition.idl:
  • page/PositionError.idl:
  • platform/GeolocationService.cpp:
  • platform/mock/GeolocationServiceMock.cpp:

2010-03-30 Laszlo Gombos <Laszlo Gombos>

Reviewed by David Kilzer.

Explicit guards for ENABLE_GEOLOCATION
https://bugs.webkit.org/show_bug.cgi?id=25756

  • WebCoreSupport/WebGeolocationMock.mm: (-[WebGeolocationMock setError:code:]): Make the body conditional on ENABLE(GEOLOCATION) (-[WebGeolocationMock setPosition:]): Ditto.
6:08 AM Changeset in webkit [56780] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-30 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Support EventTarget interface in fake workers (both for Worker object
and WorkerContext). Use MessagePort to implement message passing to
support passing ports in PostMessage.
https://bugs.webkit.org/show_bug.cgi?id=36763

  • inspector/front-end/InjectedFakeWorker.js: (InjectedFakeWorker.Worker.onmessageGetter): (InjectedFakeWorker.Worker.onmessageSetter): (InjectedFakeWorker.Worker): (InjectedFakeWorker.FakeWorker): (InjectedFakeWorker.FakeWorker.prototype.postMessage): (InjectedFakeWorker.FakeWorker.prototype.terminate): (InjectedFakeWorker.FakeWorker.prototype._onWorkerFrameLoaded): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.onmessageGetter): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.onmessageSetter): (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext): (InjectedFakeWorker.FakeWorker.prototype._addEventListener): (InjectedFakeWorker.FakeWorker.prototype._removeEventListener): (InjectedFakeWorker.FakeWorker.prototype._callbackWrapper): (InjectedFakeWorker.FakeWorker.prototype._handleException):
5:44 AM Changeset in webkit [56779] by apavlov@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-03-30 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, test missing in r56732.

  • inspector/audits-panel-functional-expected.txt: Added.
  • inspector/audits-panel-functional.html: Added.
  • inspector/resources/audits-script1.js: Added. (foo1):
  • inspector/resources/audits-script2.js: Added. (foo2):
  • inspector/resources/audits-script3.js: Added. (foo3):
  • inspector/resources/audits-style1.css: Added.
5:44 AM Changeset in webkit [56778] by benm@google.com
  • 2 edits in trunk/WebCore

[v8] Add if ENABLE guard for Worker specific code.
https://bugs.webkit.org/show_bug.cgi?id=36597

Patch by Kristian Monsen <kristianm@google.com> on 2010-03-30
Reviewed by David Levin.

Build fix only, no new tests.

  • bindings/v8/V8DOMWrapper.h:
4:58 AM Changeset in webkit [56777] by jorlow@chromium.org
  • 20 edits
    1 copy
    1 move
    3 deletes in trunk

2010-03-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

More IndexedDB work
https://bugs.webkit.org/show_bug.cgi?id=36770

Add the "singleton" IndexedDatabase object to PageGroup
IndexedDatabase now has a create() method since PageGroup can own the instance (at least for now)
Rip out the IDBRequest stuff (now obsolete).
DOMWindow now can instantiate indexedDatabase objects on demand.

New layout tests starting with the next patch (which should make indexedDB.open() "work").

  • WebCore.gypi:
  • bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::indexedDB):
  • page/DOMWindow.h:
  • page/PageGroup.cpp: (WebCore::PageGroup::indexedDatabase):
  • page/PageGroup.h:
  • storage/IDBDatabase.cpp:
  • storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::createObjectStore):
  • storage/IDBDatabaseRequest.idl:
  • storage/IDBRequest.cpp: Removed.
  • storage/IDBRequest.h: Removed.
  • storage/IDBRequest.idl: Removed.
  • storage/IndexedDatabase.cpp: (WebCore::IndexedDatabase::create):
  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::create): (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest):
  • storage/IndexedDatabaseRequest.h: (WebCore::IndexedDatabaseRequest::create):
  • storage/IndexedDatabaseRequest.idl:
  • storage/chromium/IndexedDatabase.cpp: (WebCore::IndexedDatabase::create):

2010-03-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

More IndexedDB work
https://bugs.webkit.org/show_bug.cgi?id=36770

Start the implementation of WebIndexedDatabase (for entrance back into WebKit).

  • WebKit.gyp:
  • public/WebIndexedDatabase.h:
  • src/WebIndexedDatabaseImpl.cpp: Added. (WebKit::WebIndexedDatabase::create): (WebKit::WebIndexedDatabaseImpl::~WebIndexedDatabaseImpl): (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h: Added.
4:30 AM Changeset in webkit [56776] by krit@webkit.org
  • 8 edits
    5 adds in trunk

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyph transformations wrong on use of SVGFont
https://bugs.webkit.org/show_bug.cgi?id=36731

Kerning on SVGFonts should be applied to the userSpace of the current Char
and not to the userSpace of the viewport. This means scaling the kerning
to match the current userSpace.

Test: svg/custom/glyph-transformation-with-hkern.svg

  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Glyph transformations wrong on use of SVGFont
https://bugs.webkit.org/show_bug.cgi?id=36731

Test of correct scaled kerning, if userSpace on SVGFont doesn't
match the scaling of the viewport userSpace.

  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • svg/custom/glyph-transformation-with-hkern.svg: Added.
  • svg/custom/resources/SVGFreeSans.svg: Added.
4:28 AM Changeset in webkit [56775] by krit@webkit.org
  • 3 edits
    4 adds in trunk

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Animation doesn't respect 'currentColor'
https://bugs.webkit.org/show_bug.cgi?id=36695

Test: svg/custom/animation-currentColor.svg

SVG Animation can't handle currentColor at the moment. This patch catches the
color value of the target element and replaces 'currentColor' with it's color string.

  • svg/SVGAnimationElement.cpp: (WebCore::adjustForCurrentColor): (WebCore::SVGAnimationElement::startedActiveInterval):

2010-03-30 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Animation doesn't respect 'currentColor'
https://bugs.webkit.org/show_bug.cgi?id=36695

Check if SVG animation takes the color value of the target element as 'currentColor'.

  • platform/mac/svg/custom/animation-currentColor-expected.checksum: Added.
  • platform/mac/svg/custom/animation-currentColor-expected.png: Added.
  • platform/mac/svg/custom/animation-currentColor-expected.txt: Added.
  • svg/custom/animation-currentColor.svg: Added.
2:27 AM Changeset in webkit [56774] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-30 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

[Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
https://bugs.webkit.org/show_bug.cgi?id=36811

subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
We don't need stdin, so use devnull as stdin.
Same as https://bugs.webkit.org/show_bug.cgi?id=36586

  • Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin
2:11 AM Changeset in webkit [56773] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-03-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Skip http/tests/inspector-enabled on Linux and Mac where LayoutTestContoller doesn't support inspector methods yet.

https://bugs.webkit.org/show_bug.cgi?id=36807

  • platform/chromium/test_expectations.txt:
1:59 AM Changeset in webkit [56772] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-03-30 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Visible/captured records counter should be implemented in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=36708

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.get statusBarItems): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._updateRecordsCounter): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._createRootRecord): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._filterRecords):
  • inspector/front-end/inspector.css: (.timeline-records-counter):
12:53 AM April 2010 Meeting edited by Philippe Normand
Igalia people (diff)
12:24 AM Changeset in webkit [56771] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Adam Barth.

  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum: Due to r56655.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Ditto.
12:09 AM Changeset in webkit [56770] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-03-30 Philippe Normand <pnormand@igalia.com>

[GStreamer] define static variables with DEFINE_STATIC_LOCAL macro
https://bugs.webkit.org/show_bug.cgi?id=36653

Unreviewed, don't define the bool variable with
DEFINE_STATIC_LOCAL, it makes sense only for objects which have a
destructor. Thanks to Dan Bernstein for spotting this.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
12:08 AM Changeset in webkit [56769] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-03-29 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

There is a build break due to the disabled() when wml feature is
enabled. This break comes from the Bug 35056 - Disabled menu options
are still submitted.(https://bugs.webkit.org/show_bug.cgi?id=35056)
The WMLOptionElement.h needs to define the disabled() as well.
And, there is an additional break due to Bug 36177 - Multiselect Popup

https://bugs.webkit.org/show_bug.cgi?id=36698

  • wml/WMLOptionElement.h: (WebCore::WMLOptionElement::disabled):
  • wml/WMLSelectElement.h: (WebCore::WMLSelectElement::listBoxSelectItem):
12:02 AM Changeset in webkit [56768] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Adam Barth.

Needed to fix test_expectations.txt for recent addition in r56764.

  • platform/chromium/test_expectations.txt: Added IMAGE (due to the results on OSX).

Mar 29, 2010:

11:52 PM Changeset in webkit [56767] by alice.liu@apple.com
  • 2 edits in trunk/JavaScriptCore

add JSObjectRefPrivate.h

Reviewed by NOBODY (build fix).

11:46 PM BuildingQtOnLinux edited by fboudra@gmail.com
Fix typo (diff)
11:44 PM Changeset in webkit [56766] by levin@chromium.org
  • 11 edits
    9 adds in trunk/LayoutTests

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Shinichiro Hamaji.

Various rebaselines due to changes in layout or new tests. The revision that caused
each change is by the change.

  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Added. Due to r56655.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Added. Ditto.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1296-expected.txt.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Added. Ditto.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Added. Ditto.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1430-expected.txt.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Added. Due to r56740.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Added. Ditto.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Added. Ditto.
  • platform/chromium-win/svg/custom/marker-overflow-clip-expected.txt: Due to r56693.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum: Due to r56655.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Ditto.
  • platform/chromium/test_expectations.txt: Added a few failures with follow up bugs.
11:42 PM BuildingQtOnLinux edited by fboudra@gmail.com
Add missing build dependencies (diff)
11:16 PM Changeset in webkit [56765] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Unreviewed, build fix only.

  • Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import.
11:15 PM Changeset in webkit [56764] by hamaji@chromium.org
  • 7 edits
    4 adds in trunk

2010-03-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Hyatt.

No vertical scrollbar after the CSS class change
https://bugs.webkit.org/show_bug.cgi?id=36461

  • fast/repaint/overflow-scroll-body-appear.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-03-29 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Hyatt.

No vertical scrollbar after the CSS class change
https://bugs.webkit.org/show_bug.cgi?id=36461

Don't suppress scrollbar change for non-first layouts.
In the first layout, the scrollbar change will happen in later
adjustViewSize() call, but in other layouts, adjustViewSize() may
not be called when the size of contents doesn't change.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
11:08 PM Changeset in webkit [56763] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-29 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Remove '_flymake' suffix from base part of file name so that
check-webkit-style uses a correct header guard name when it is called from Emacs's flymake.

https://bugs.webkit.org/show_bug.cgi?id=36573

  • Scripts/webkitpy/style/processors/cpp.py:
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
10:41 PM Changeset in webkit [56762] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Get the following test-webkitpy unit test working again:
scm_unittest.SVNTest.test_svn_apply().

https://bugs.webkit.org/show_bug.cgi?id=36696

  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Add leading spaces to the empty lines of the ChangeLog strings.
    • Manually set the _reviewer attribute on the Attachment object to get the tests to pass.
10:09 PM Changeset in webkit [56761] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2010-03-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adele Peterson.

Default value of accelerated compositing should be false for Windows
https://bugs.webkit.org/show_bug.cgi?id=36805

  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):
9:04 PM Changeset in webkit [56760] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-03-29 Martin Robinson <Martin Robinson>

Reviewed by Holger Freyther.

[GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=36390

Suppress debugging messages sent to the GLib logger during DRT runs.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (logHandler): Added. (main): Use logHandler as the default GLib log message handler.
7:59 PM Changeset in webkit [56759] by eric@webkit.org
  • 9 edits in trunk/JavaScriptCore

2010-03-29 Chao-ying Fu <fu@mips.com>

Reviewed by Oliver Hunt.

MIPS JIT Supports
https://bugs.webkit.org/show_bug.cgi?id=30144

The following changes enable MIPS JIT.

  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::lbu): (JSC::MIPSAssembler::linkWithOffset):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::load8): (JSC::MacroAssemblerMIPS::branch8): (JSC::MacroAssemblerMIPS::branchTest8): (JSC::MacroAssemblerMIPS::setTest8): (JSC::MacroAssemblerMIPS::setTest32):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::preserveReturnAddressAfterCall): (JSC::JIT::restoreReturnAddressBeforeReturn):
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):
  • wtf/Platform.h:
7:44 PM Changeset in webkit [56758] by levin@chromium.org
  • 49 edits in trunk/LayoutTests

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Dimitri Glazkov.

r56655 changed how tables layout which causes a lot of pixels tests for
tables to need rebaselines.

r56693 did some svg changes.

  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
  • platform/chromium-win/svg/custom/invalid-css-expected.txt: Due to r56693.
  • platform/chromium-win/svg/custom/marker-default-width-height-expected.txt: Ditto.
  • platform/chromium-win/svg/custom/shapes-supporting-markers-expected.txt: Ditto.
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
  • platform/chromium/test_expectations.txt: Two newly added tests are timing out (covered by http://crbug.com/35387).
7:32 PM Changeset in webkit [56757] by eric@webkit.org
  • 6 edits in trunk

2010-03-29 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

  • fast/xmlhttprequest/xmlhttprequest-no-file-access.html: Check that an isolated file:// origin can access about:blank iframes that it created itself.

2010-03-29 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Don't use unique domains for file:// separation: it breaks local
databases, and access to your own same-origin iframes. Instead, use
path-based access checks.

https://bugs.webkit.org/show_bug.cgi?id=36692

Test: fast/xmlhttprequest/xmlhttprequest-no-file-access.html

  • dom/Document.cpp: (WebCore::Document::initSecurityContext): renamed API.
  • page/SecurityOrigin.h:
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): Initialize new flag. Take note of file:// path. Copy new fields in copy constructor. (WebCore::SecurityOrigin::canAccess): Take into account path-based origin separation for file:// (WebCore::SecurityOrigin::enforceFilePathSeparation): New method to enable file:// path origin separation. (WebCore::SecurityOrigin::toString): Return a null domain for an isolated file origin. (WebCore::SecurityOrigin::isSameSchemeHostPort): Take into account path-based origin separation for file:// (WebCore::SecurityOrigin::passesFileCheck): Abstraction of common logic for file:// access checks.
6:38 PM Changeset in webkit [56756] by eric@webkit.org
  • 11 edits in trunk

2010-03-29 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission):
  • notifications/NotificationPresenter.h:

2010-03-29 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

  • public/WebNotificationPresenter.h: (WebKit::WebNotificationPresenter::checkPermission):
  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission):
  • src/NotificationPresenterImpl.h:

2010-03-29 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission):
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
6:15 PM Changeset in webkit [56755] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot should comment on bugs when builders break
https://bugs.webkit.org/show_bug.cgi?id=36786

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • Add a new _post_blame_comment_to_bug and all it from process_work_item
    • Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands.
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Test the new _post_blame_comment_to_bug call
6:07 PM Changeset in webkit [56754] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot fails to get information about certain builds
https://bugs.webkit.org/show_bug.cgi?id=36768

This seems to be caused by:
http://buildbot.net/trac/ticket/753
I have no work-around, but for now at least we're logging
the error better. I also added allow_none to our ServerProxy
creation in case that fixes things for other versions of python.

  • Scripts/webkitpy/common/net/buildbot.py:
5:34 PM Changeset in webkit [56753] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-29 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

Add sign in/out link to TestResults appengine

Add a link to main menu for sign in/out to this appengine.
People signed in with admin privilege could perform
actions that are only allowed to admins like deleting files.

https://bugs.webkit.org/show_bug.cgi?id=36767

  • TestResultServer/handlers/menu.py:
  • TestResultServer/stylesheets/menu.css: (.sign):
  • TestResultServer/templates/menu.html:
5:16 PM Changeset in webkit [56752] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-29 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Multiselect - Adding method itemIsSelected() to QtAbstractWebPopup
https://bugs.webkit.org/show_bug.cgi?id=36769

Adding method itemIsSelected() to QtAbstractWebPopup.

  • platform/qt/QtAbstractWebPopup.h: (WebCore::QtAbstractWebPopup::itemIsSelected):
4:58 PM Changeset in webkit [56751] by levin@chromium.org
  • 8 edits
    6 moves
    53 adds in trunk/LayoutTests

Rubber-stamped by Dmitry Titov.

[Chromium] pixel layout test fixes.

r56655 caused runin test which needed separate results for each platform.
r56673 caused computed-style-expected.
r56655 cause the fast/table changes (and we need linux specific results).
r56644 caused clip-path-referencing-use2-expected.
r56693 caused painting-marker-01-f-expected.

  • platform/chromium-linux/fast/runin/generated2-expected.checksum: Added.
  • platform/chromium-linux/fast/runin/generated2-expected.png: Added.
  • platform/chromium-linux/fast/runin/generated2-expected.txt: Added.
  • platform/chromium-linux/fast/runin/generated3-expected.checksum: Added.
  • platform/chromium-linux/fast/runin/generated3-expected.png: Added.
  • platform/chromium-linux/fast/runin/generated3-expected.txt: Added.
  • platform/chromium-linux/fast/runin/generated4-expected.checksum: Added.
  • platform/chromium-linux/fast/runin/generated4-expected.png: Added.
  • platform/chromium-linux/fast/runin/generated4-expected.txt: Added.
  • platform/chromium-linux/fast/table/table-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-col-span-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-expected.png: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/runin/generated2-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.checksum.
  • platform/chromium-mac/fast/runin/generated2-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.png.
  • platform/chromium-mac/fast/runin/generated3-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.checksum.
  • platform/chromium-mac/fast/runin/generated3-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.png.
  • platform/chromium-mac/fast/runin/generated4-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.checksum.
  • platform/chromium-mac/fast/runin/generated4-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.png.
  • platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/runin/generated2-expected.checksum: Added.
  • platform/chromium-win/fast/runin/generated2-expected.png: Added.
  • platform/chromium-win/fast/runin/generated2-expected.txt: Added.
  • platform/chromium-win/fast/runin/generated3-expected.checksum: Added.
  • platform/chromium-win/fast/runin/generated3-expected.png: Added.
  • platform/chromium-win/fast/runin/generated3-expected.txt: Added.
  • platform/chromium-win/fast/runin/generated4-expected.checksum: Added.
  • platform/chromium-win/fast/runin/generated4-expected.png: Added.
  • platform/chromium-win/fast/runin/generated4-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:
4:58 PM Changeset in webkit [56750] by eric@webkit.org
  • 8 edits in trunk

2010-03-29 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

Added a function, WebCore::shouldTreatAsAttachment, to HTTPParsers.*

https://bugs.webkit.org/show_bug.cgi?id=36395

This function, which was moved from WebKit/chromium/src/FrameClientImpl.cpp,
is used to check whether or not a request is supposed to be rendered or
simply downloaded based on the "Content-Disposition" header sent by the
web server. The intent of code refactoring is to avoid code duplication
so that this piece of code can be used by other implementations such as
QtWebKit.

  • platform/network/HTTPParsers.cpp: (WebCore::shouldTreatAsAttachment):
  • platform/network/HTTPParsers.h:

2010-03-29 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

Factored out the 'ShouldTreatAsAttachment' function to HTTPParsers.*
and replacted local version with the factored out version.

The code was factored out to make possible its use in other implementations
such as QtWebKit.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):

2010-03-29 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

[Qt] Added support for handling the HTTP "Content-Disposition" header.

https://bugs.webkit.org/show_bug.cgi?id=36395

Whenever a server response contains a "Content-Disposition: attachment..." header,
treat the request as a download and emit the unsupportedContent signal.

  • Api/qwebpage.cpp:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::download): (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):
4:38 PM Changeset in webkit [56749] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-03-29 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Bug 36735 - Live regions don't send out notifications when the element changing is the live region
https://bugs.webkit.org/show_bug.cgi?id=36735

  • platform/mac/accessibility/aria-liveregion-on-image-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregion-on-image.html: Added.

2010-03-29 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Bug 36735 - Live regions don't send out notifications when the element changing is the live region
https://bugs.webkit.org/show_bug.cgi?id=36735

Test: platform/mac/accessibility/aria-liveregion-on-image.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::contentChanged):
4:33 PM Changeset in webkit [56748] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

ValidateReviewer step is draconian and un-tested
https://bugs.webkit.org/show_bug.cgi?id=36792

ValidateReviewer logic was commented out in
http://trac.webkit.org/changeset/56744
That was a symptom of the fact that validatereviewer.py
is too inflexible to be used when real humans are driving webkit-patch.
For now we just disable ValidateReviewer when humans are at the keyboard.

  • Scripts/webkitpy/tool/steps/validatereviewer.py:
    • Only run when in non-interactive mode.
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added.
    • Test our validation logic to make sure it's sane.
4:18 PM Changeset in webkit [56747] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Eliminate explicit slash characters from check-webkit-style's
_rel_path() method to make its implementation more platform
independent.

https://bugs.webkit.org/show_bug.cgi?id=36759

  • Scripts/webkitpy/style/main.py:
    • Changed to use os.sep instead of slash_chars "/
      ". This can be done since os.path.abspath() converts slashes to os.sep.
3:35 PM Changeset in webkit [56746] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Change new-run-webkit-tests to not use more than four threads by
default on the mac port until
https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.

https://bugs.webkit.org/show_bug.cgi?id=36687

  • Scripts/webkitpy/layout_tests/port/mac.py:
3:34 PM Changeset in webkit [56745] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.

https://bugs.webkit.org/show_bug.cgi?id=36691

  • Scripts/webkitpy/layout_tests/port/mac.py:
3:28 PM Changeset in webkit [56744] by senorblanco@chromium.org
  • 5 edits
    2 adds in trunk

2010-03-29 Stephen White <senorblanco@chromium.org>

Reviewed by Dave Hyatt.

In order to speed up multiple calls to CSSPrimitiveValue::cssText(),
this CL caches the String result. When m_value is changed, the
cached string is cleared. This gives a good speedup on benchmarks
which do a lot of CSS property gets, such as Peacekeeper.
The processing cost should be negligible, since the strings are
refcounted. The memory cost is an additional 4 bytes per
CSSPrimitiveValue, and the extended lifetime of the computed string
(potentially, the same as the lifetime of the CSSPrimitiveValue).

https://bugs.webkit.org/show_bug.cgi?id=36556

Covered by fast/css/cssText-cache.html, and more.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h:

2010-03-29 Stephen White <senorblanco@chromium.org>

Reviewed by Dave Hyatt.

Added a test for CSSPrimitiveValue::cssText() string cacheing.

https://bugs.webkit.org/show_bug.cgi?id=36556

  • fast/css/cssText-cache-expected.txt: Added.
  • fast/css/cssText-cache.html: Added.
3:26 PM April 2010 Meeting edited by Laszlo Gombos
(diff)
3:20 PM Changeset in webkit [56743] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests fails java/lc3 on a clean checkout
https://bugs.webkit.org/show_bug.cgi?id=36078

  • Scripts/webkitpy/layout_tests/port/mac.py:
    • Build the java support files in check_build
    • Unwrap a line which would still fit under 80col
3:19 PM Changeset in webkit [56742] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Build Fix: Touch WebKit.idl to force Interfaces to rebuild

3:15 PM Changeset in webkit [56741] by sfalken@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Build fix. Touch WebKit.idl to force rebuild.

2:44 PM Changeset in webkit [56740] by kenneth@webkit.org
  • 19 edits
    2 adds in trunk

JavaScriptCore: Add an enable flag for the Widgets (http://www.w3.org/TR/widgets-reqs/)
and turn it on for Qt only.

Reviewed by Simon Fraser.

  • wtf/Platform.h:

WebCore: When enabling Web Widgets, add support for the view-mode media
feature (http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

Test: fast/media/media-feature-wgt-view-mode.html

  • css/CSSValueKeywords.in:
  • css/MediaFeatureNames.h:
  • css/MediaQueryEvaluator.cpp:

(WebCore::view_modeMediaFeatureEval):

  • page/ChromeClient.h:

(WebCore::ChromeClient::isDocked):
(WebCore::ChromeClient::isFloating):
(WebCore::ChromeClient::isApplication):
(WebCore::ChromeClient::isFullscreen):

WebKit/qt: Add an internal Qt API for changing the view mode media feature
(http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

  • Api/qwebpage.cpp:

(qt_wrt_setViewMode):
(QWebPagePrivate::priv):

  • Api/qwebpage_p.h:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::isDocked):
(WebCore::ChromeClientQt::isFloating):
(WebCore::ChromeClientQt::isApplication):
(WebCore::ChromeClientQt::isFullscreen):

  • WebCoreSupport/ChromeClientQt.h:

WebKitTools: Add hooks to the Qt DRT for testing the view mode media feature.

Reviewed by Simon Fraser.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setViewModeMediaFeature):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests: Add a test and an expected result for the Widgets 1.0: View Mode
Media Feature (http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

Skip on all other platforms than Qt, that has Skipped files.

  • fast/media/media-feature-wgt-view-mode.html: Added.
  • fast/media/media-feature-wgt-view-mode-expected.txt: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
1:51 PM Changeset in webkit [56739] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-03-29 Adam Barth <abarth@webkit.org>

Unreviewed. Update expected results for unit tests.

  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1:49 PM Changeset in webkit [56738] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-29 Adam Barth <abarth@webkit.org>

Unreviewed. I think Eric meant svn_revision.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
1:40 PM Changeset in webkit [56737] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-03-26 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes)
https://bugs.webkit.org/show_bug.cgi?id=29311

Now that we have sheriff-bot watching the tree, it can post
rollout patches on behalf of the commit queue.

  • Scripts/webkitpy/common/checkout/commitinfo.py: add responsible_parties()
  • Scripts/webkitpy/common/checkout/commitinfo_unittest.py: test responsible_parties()
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • Break IRC logic out into _post_irc_warning for easier testing.
    • Add _post_rollout_patch for posting rollout patches to bugzilla.
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Test _rollout_reason
  • Scripts/webkitpy/tool/grammar.py:
    • Fix join_with_separators to not add Adam's "oxford comma" for two item lists.
  • Scripts/webkitpy/tool/grammar_unittest.py:
    • Test join_with_separators
1:31 PM Changeset in webkit [56736] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-03-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sheriffbot should actually run commands
https://bugs.webkit.org/show_bug.cgi?id=36776

Some minor changes to Sheriffbot:

1) We should actually run commands (by giving control back to the
command processing object.

2) Use URLs instead of just numbers to represent SVN revisions (making
it easier to folks in IRC ot followup).

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
12:51 PM QtWebKitRelease20 edited by fboudra@gmail.com
(diff)
12:50 PM QtWebKitRelease20 edited by fboudra@gmail.com
nicer (diff)
12:48 PM QtWebKitRelease20 edited by fboudra@gmail.com
Link to the top of the page (diff)
12:45 PM BuildingQtOnLinux edited by fboudra@gmail.com
Update build dependencies for Debian and Ubuntu (diff)
11:54 AM April 2010 Meeting edited by geoffrey.levand@am.sony.com
Add Geoff Levand. (diff)
11:28 AM Changeset in webkit [56735] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-03-29 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Eliminate use of GL_BGRA in GraphicsContext3DSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=36737

No new tests; ran WebGL demos in Chromium on Windows to verify fix.

  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
11:20 AM Changeset in webkit [56734] by levin@chromium.org
  • 1 edit
    109 adds in trunk/LayoutTests

Rubber-stamped by Dmitry Titov.

Add chromium specific baselines for table tests added in r56641
and for runin tests added in r56655.

  • platform/chromium-mac/fast/table/table-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-overrides-row-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-col-span-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-group-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-span-background-expected.txt.
  • platform/chromium-mac/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-col-span-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-col-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-span-background-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-left-50px-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-left-50px-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-right-100percent-expected.txt.
  • platform/chromium-mac/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-background-right-50px-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-right-50px-expected.txt.
  • platform/chromium-mac/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-group-background-expected.txt.
  • platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-group-background-positioned-expected.txt.
  • platform/chromium-win/fast/table/table-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-group-col-span-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-group-span-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-col-span-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-col-span-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-left-50px-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-right-100percent-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-background-right-50px-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-group-background-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-group-background-expected.txt: Added.
  • platform/chromium-win/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/chromium-win/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/chromium-win/fast/table/table-row-group-background-positioned-expected.txt: Added.
  • platform/chromium/fast/runin/generated2-expected.checksum: Added.
  • platform/chromium/fast/runin/generated2-expected.png: Added.
  • platform/chromium/fast/runin/generated3-expected.checksum: Added.
  • platform/chromium/fast/runin/generated3-expected.png: Added.
  • platform/chromium/fast/runin/generated4-expected.checksum: Added.
  • platform/chromium/fast/runin/generated4-expected.png: Added.
11:10 AM Changeset in webkit [56733] by Joseph Pecoraro
  • 1 edit
    2 adds in trunk/LayoutTests

2010-03-29 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Test for Ensuring Pseudo Class's are Respected on Dynamic Changes
https://bugs.webkit.org/show_bug.cgi?id=36765

This tests elements affected by a CSS pseudo class selector is updated
after a dynamic DOM change.

  • fast/css/dynamic-pseudo-class-expected.txt: Added.
  • fast/css/dynamic-pseudo-class.html: Added.
10:59 AM Changeset in webkit [56732] by apavlov@chromium.org
  • 7 edits in trunk

2010-03-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Cover the Audits panel with tests
https://bugs.webkit.org/show_bug.cgi?id=36613

LayoutTests:

  • inspector/audits-panel-functional-expected.txt: Added.
  • inspector/audits-panel-functional.html: Added.
  • inspector/resources/audits-script1.js: Added. (foo1):
  • inspector/resources/audits-script2.js: Added. (foo2):
  • inspector/resources/audits-script3.js: Added. (foo3):

WebCore:

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditResultView.js: (WebInspector.AuditResultView): (WebInspector.AuditCategoryResultPane.ruleSorter): (WebInspector.AuditCategoryResultPane):
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CssInHeadRule.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditRuleResult.linkifyDisplayName): (WebInspector.AuditRuleResult.resourceDomain): (WebInspector.AuditRuleResult.prototype.addURL):
  • inspector/front-end/inspector.js: (WebInspector.displayNameForURL):
10:54 AM April 2010 Meeting edited by ericu@chromium.org
(diff)
10:50 AM Changeset in webkit [56731] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-03-29 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Antti Koivisto.

Use 'Mobile Safari' instead of 'Safari' on mobile Qt platforms.

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
10:39 AM Changeset in webkit [56730] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Fix build break introduced in r56724.

Reviewed by nobody, build fix.

  • WebCore.pro:
10:31 AM Changeset in webkit [56729] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-03-29 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Corrected name of (u)int64_t compile time assert.
https://bugs.webkit.org/show_bug.cgi?id=36739

int64_t_is_four_bytes -> int64_t_is_eight_bytes

  • os-win32/stdint.h:
10:13 AM Changeset in webkit [56728] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-03-29 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

Pass a WebFrame to WebFrameClient::allowDatabase instead of a WebSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=36743

  • public/WebFrameClient.h: (WebKit::WebFrameClient::allowDatabase):
  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
10:11 AM Changeset in webkit [56727] by apavlov@chromium.org
  • 4 edits in trunk

2010-03-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector should highlight when clicking a node's closing tag
https://bugs.webkit.org/show_bug.cgi?id=16258

LayoutTests:

  • inspector/elements-panel-limited-children.html:

WebCore:

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set suppressRevealAndSelect): (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode): (WebInspector.ElementsTreeOutline.prototype._keyDown): (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype.showChild): (WebInspector.ElementsTreeElement.prototype.onpopulate): (WebInspector.ElementsTreeElement.prototype.updateChildren): (WebInspector.ElementsTreeElement.prototype.insertChildElement): (WebInspector.ElementsTreeElement.prototype.moveChild): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.onexpand): (WebInspector.ElementsTreeElement.prototype.oncollapse): (WebInspector.ElementsTreeElement.prototype.onselect): (WebInspector.ElementsTreeElement.prototype.ondblclick): ():
10:03 AM April 2010 Meeting edited by chang.shu@nokia.com
(diff)
10:00 AM April 2010 Meeting edited by Chris Jerdonek
Alphabetize list of attendees (diff)
9:56 AM April 2010 Meeting edited by darin@chromium.org
(diff)
9:56 AM Changeset in webkit [56726] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-03-29 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

https://bugs.webkit.org/show_bug.cgi?id=36315

Remove obsolete Geolocation::m_currentPosition
(follow up on https://bugs.webkit.org/show_bug.cgi?id=30676)

  • page/Geolocation.cpp: (WebCore::Geolocation::positionChanged): (WebCore::Geolocation::makeSuccessCallbacks):
  • page/Geolocation.h:
  • platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceChromium::GeolocationServiceChromium):
9:52 AM April 2010 Meeting edited by treat@kde.org
(diff)
9:51 AM April 2010 Meeting edited by dbates@webkit.org
Added myself to the list of attendees (diff)
9:31 AM April 2010 Meeting edited by levin@chromium.org
(diff)
9:24 AM Changeset in webkit [56725] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Use the -l syntax for linking against JavaScriptCore on Windows.
This allow qmake to extract dependencies correctly when generating VS
solutions.

Reviewed by Simon Hausmann.

9:24 AM Changeset in webkit [56724] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Do not generate INSTALLS for webkit when building inside Qt.
Qt will do this for us.

Reviewed by Simon Hausmann.

  • WebCore.pro:
9:21 AM April 2010 Meeting edited by rik@webkit.org
(diff)
9:19 AM April 2010 Meeting edited by ben@webkit.org
(diff)
9:10 AM April 2010 Meeting edited by levin@chromium.org
(diff)
9:05 AM Changeset in webkit [56723] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36703
Timer restart loop during page loading

Reviewed by Kenneth Rohde Christiansen.

Fix regression introduced in http://trac.webkit.org/changeset/54526.
Restarting the request timer unconditionally from the timer callback is a bad idea.
Instead, start the timer when a non-cached request completes.

  • loader/loader.cpp:

(WebCore::Loader::Host::nonCacheRequestComplete):
(WebCore::Loader::Host::servePendingRequests):

9:04 AM April 2010 Meeting edited by vestbo@webkit.org
(diff)
8:29 AM April 2010 Meeting edited by kenneth@webkit.org
(diff)
8:28 AM April 2010 Meeting edited by kenneth@webkit.org
(diff)
8:16 AM April 2010 Meeting created by Chris Jerdonek
Started page for WebKit meeting
8:15 AM Changeset in webkit [56722] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

Add support for iframe flattening
https://bugs.webkit.org/show_bug.cgi?id=36662

  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.
8:12 AM WikiStart edited by Chris Jerdonek
Fix typo (diff)
8:11 AM WikiStart edited by Chris Jerdonek
Created link to a page for the April 2010 WebKit meeting (diff)
7:48 AM Changeset in webkit [56721] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] unit tests don't compile inside of Qt

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=36756

  • tests/tests.pri: Don't do the target substitution inside Qt and find the sources

through VPATH instead of relying on the location of the .pro file exclusively.

7:40 AM Changeset in webkit [56720] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

Add support for iframe flattening
https://bugs.webkit.org/show_bug.cgi?id=36662

  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: updated after r56718.
7:03 AM Changeset in webkit [56719] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Shadowbuilds of WebCore with Qt on Symbian fails.

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=36749

Doing a 'make sis' expects the dll in the libdir, so place it
there. This fixes out-of-source building to always put the dll
in the expected dir.

  • WebCore.pro: Fix for shadow builds inside Qt.
7:03 AM Changeset in webkit [56718] by kenneth@webkit.org
  • 47 edits
    2 adds in trunk

WebCore: Implement flattening for iframes.

Reviewed by Antti Koivisto.

Refactoring of frameset flattening code to reuse it for
iframe flattening.

Tests: fast/frames/flattening/iframe-flattening-simple.html

  • WebCore.base.exp:
  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setFrameFlatteningEnabled):

  • page/Settings.h:

(WebCore::Settings::frameFlatteningEnabled):

  • rendering/RenderFrame.cpp:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::flattenFrameSet):

  • rendering/RenderFrameSet.h:
  • rendering/RenderPart.cpp:

(WebCore::RenderPart::layoutWithFlattening):

  • rendering/RenderPart.h:
  • rendering/RenderPartObject.cpp:

(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):

  • rendering/RenderPartObject.h:

WebKit/mac: Change method name due to it dealing with both flattening
of frame sets and inner frames.

Reviewed by Antti Koivisto.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences isFrameFlatteningEnabled]):
(-[WebPreferences setFrameFlatteningEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/qt: Change due to renaming of frame flattening setting.

Reviewed by Antti Koivisto.

  • Api/qwebpage.cpp:

(qt_drt_setFrameFlatteningEnabled):

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

  • symbian/eabi/QtWebKitu.def:

WebKit/win: Change method name due to it dealing with both flattening
of frame sets and inner frames.

Reviewed by Antti Koivisto.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::isFrameFlatteningEnabled):
(WebPreferences::setFrameFlatteningEnabled):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

WebKitTools: Renaming of frame flattening LayoutTestController method
to setFrameFlatteningEnabled(bool)

Reviewed by Antti Koivisto.

  • DumpRenderTree/LayoutTestController.cpp:

(setFrameFlatteningEnabledCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

LayoutTests: Add new iframe flattening test and change existing frameset
flattening tests to use the new LayoutTestController method.

Reviewed by Antti Koivisto.

  • fast/frames/flattening/frameset-flattening-advanced.html:
  • fast/frames/flattening/frameset-flattening-grid.html:
  • fast/frames/flattening/frameset-flattening-simple.html:
  • fast/frames/flattening/frameset-flattening-subframe-resize.html:
  • fast/frames/flattening/frameset-flattening-subframesets.html:
  • fast/frames/flattening/iframe-flattening-simple.html: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.
6:53 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:53 AM QtWebKitBackportingFixes edited by yael.aharon@nokia.com
(diff)
5:23 AM Changeset in webkit [56717] by Csaba Osztrogonác
  • 1 edit
    51 adds in trunk/LayoutTests

[Qt] Platform specific expected file added for tests introduced in r56655,
because they pass. Compared to png file and Mac expected file.

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/fast/table/table-background-expected.checksum: Added.
  • platform/qt/fast/table/table-background-expected.png: Added.
  • platform/qt/fast/table/table-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.png: Added.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-background-expected.png: Added.
  • platform/qt/fast/table/table-col-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-group-background-expected.png: Added.
  • platform/qt/fast/table/table-col-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.png: Added.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-group-span-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-group-span-background-expected.png: Added.
  • platform/qt/fast/table/table-col-group-span-background-expected.txt: Added.
  • platform/qt/fast/table/table-col-span-background-expected.checksum: Added.
  • platform/qt/fast/table/table-col-span-background-expected.png: Added.
  • platform/qt/fast/table/table-col-span-background-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-expected.png: Added.
  • platform/qt/fast/table/table-row-background-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-left-50px-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-left-50px-expected.png: Added.
  • platform/qt/fast/table/table-row-background-left-50px-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.png: Added.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.txt: Added.
  • platform/qt/fast/table/table-row-background-right-50px-expected.checksum: Added.
  • platform/qt/fast/table/table-row-background-right-50px-expected.png: Added.
  • platform/qt/fast/table/table-row-background-right-50px-expected.txt: Added.
  • platform/qt/fast/table/table-row-group-background-expected.checksum: Added.
  • platform/qt/fast/table/table-row-group-background-expected.png: Added.
  • platform/qt/fast/table/table-row-group-background-expected.txt: Added.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.checksum: Added.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.png: Added.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.txt: Added.
4:54 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
4:49 AM Changeset in webkit [56716] by benm@google.com
  • 4 edits
    1 add in trunk/WebCore

Page Cache does not work on Android with V8
https://bugs.webkit.org/show_bug.cgi?id=36665

Patch by Andrei Popescu <andreip@google.com> on 2010-03-29
Reviewed by Adam Barth.

No new tests, existing tests should suffice, this is platform code.

This implementation simply saves the context and the global object
just before the frame is navigated to a new url. At restore time,
the global object is reattached to the context and the context
is attached to the window shell of the frame.

Note that isolated worlds are not taken into account in any way,
as Android does not use them.

  • bindings/v8/ScriptCachedFrameData.cpp: Added.

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::domWindow):
(WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):

  • bindings/v8/ScriptCachedFrameData.h:
  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::setContext):

  • bindings/v8/V8DOMWindowShell.h:
4:14 AM Changeset in webkit [56715] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Make it possible to build using both Windows and Linux for Symbian
https://bugs.webkit.org/show_bug.cgi?id=36748

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

  • WebCore.pro: don't assume Windows buildsystem is the only one

and exclude the windows-only setters from the linux builds.

4:07 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:55 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:49 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
3:44 AM Changeset in webkit [56714] by Simon Hausmann
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36745

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

[Qt] Fix def file builds with Qt 4.7.

Switched to using DEF_FILE, which is the official variable.

  • WebCore.pro: Use DEF_FILE
2:35 AM QtWebKitJournal edited by Simon Hausmann
(diff)
2:26 AM Changeset in webkit [56713] by jorlow@chromium.org
  • 13 edits
    8 copies
    2 adds in trunk

2010-03-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

A few more steps towards IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=36546

Add a callback interface to be used by all async methods.
Add the first fragments of IDBDatabase.
Clean up on IDBDatabaseError.
Flesh out IndexedDatabase further.

Not enough hooked up yet to test. Soon though...

  • WebCore.gypi:
  • storage/IDBCallbacks.h: Added. (WebCore::IDBCallbacks::~IDBCallbacks):
  • storage/IDBDatabase.cpp: Added.
  • storage/IDBDatabase.h: Added. (WebCore::IDBDatabase::~IDBDatabase):
  • storage/IDBDatabaseError.h: (WebCore::IDBDatabaseError::create): (WebCore::IDBDatabaseError::message): (WebCore::IDBDatabaseError::IDBDatabaseError):
  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl): (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):

2010-03-24 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

More IndexedDB plumbing
https://bugs.webkit.org/show_bug.cgi?id=36546

Plumbing work towards the goal of making IndexedDatabase::open work.

  • WebKit.gyp:
  • public/WebIDBCallbacks.h: Added. (WebKit::WebIDBCallbacks::~WebIDBCallbacks):
  • public/WebIDBDatabase.h: Added. (WebKit::WebIDBDatabase::~WebIDBDatabase):
  • public/WebIDBDatabaseError.h: Added. (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::operator=):
  • public/WebIndexedDatabase.h:
  • public/WebKitClient.h: (WebKit::WebKitClient::indexedDatabase):
  • public/WebSerializedScriptValue.h:
  • src/IDBCallbacksProxy.h: Added. (WebCore::IDBCallbacksProxy::IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::onSuccess): (WebCore::IDBCallbacksProxy::onError):
  • src/IDBDatabaseProxy.cpp: Added. (WebCore::IDBDatabaseProxy::create): (WebCore::IDBDatabaseProxy::IDBDatabaseProxy): (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy):
  • src/IDBDatabaseProxy.h: Added.
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy): (WebCore::IndexedDatabaseProxy::open):
  • src/IndexedDatabaseProxy.h:
  • src/WebIDBDatabaseError.cpp: Added. (WebKit::WebIDBDatabaseError::~WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::assign): (WebKit::WebIDBDatabaseError::code): (WebKit::WebIDBDatabaseError::message): (WebKit::WebIDBDatabaseError::operator=): (WebKit::WebIDBDatabaseError::operator PassRefPtr<IDBDatabaseError>):
2:10 AM Changeset in webkit [56712] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=36742

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

gcc for Symbian doesn't support gcc extensions like atomicity.h - disable

  • wtf/Threading.h: also detect os symbian
1:52 AM Changeset in webkit [56711] by mnaganov@chromium.org
  • 7 edits in trunk

2010-03-29 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Remove a possibility of confusion from Profiles panel Welcome screen
by turning buttons into non-clickable glyphs. Also, span instructions
alongside panel width.

https://bugs.webkit.org/show_bug.cgi?id=34319

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.get welcomeMessage):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._addWelcomeMessage):
  • inspector/front-end/inspector.css: (.panel-enabler-view.welcome .instructions): (.panel-enabler-view.welcome button.status-bar-item):
  • src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage):
1:17 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:41 AM Changeset in webkit [56710] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-03-26 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] define static variables with DEFINE_STATIC_LOCAL macro
https://bugs.webkit.org/show_bug.cgi?id=36653

Defined the static variables using DEFINE_STATIC_GLOBAL.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
12:37 AM Changeset in webkit [56709] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-03-26 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] player header cleanups
https://bugs.webkit.org/show_bug.cgi?id=36656

Destructor made private and added missing
mediaPlayerPrivateMuteChangedCallback declaration.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
12:34 AM Changeset in webkit [56708] by yurys@chromium.org
  • 7 edits
    7 adds in trunk

2010-03-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Protect global object from being GC'ed if there are messages written to console from the iframe with that global object.

Whent serializing objects in the injected script check that global object properties are still defined before using them as arguments. The may become undefined if owning frame navigated to a different domain.

https://bugs.webkit.org/show_bug.cgi?id=36612

Test: http/tests/inspector-enabled/console-log-before-frame-navigation.html

  • bindings/js/ScriptState.h: (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
  • bindings/v8/ScriptState.h: (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::~ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/ConsoleMessage.h:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):

2010-03-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: don't crash when there are messages in console from previous iframe content.

https://bugs.webkit.org/show_bug.cgi?id=36612

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt: Added.
  • http/tests/inspector-enabled/console-log-before-frame-navigation.html: Added.
  • http/tests/inspector-enabled/resources/console-log-before-frame-navigation.js: Added. (doit.callback): (doit): (receiveMessage): (frontend_dumpConsoleMessages):
  • http/tests/inspector-enabled/resources/console-log-frame-after-navigation.html: Added.
  • http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html: Added.
12:29 AM Changeset in webkit [56707] by Philippe Normand
  • 5 edits in trunk/WebCore

2010-03-26 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

It should be possible to use GStreamer in addition to another media engine
https://bugs.webkit.org/show_bug.cgi?id=36654

Renamed gstreamer player and added a WTF_USE_GSTREAMER
define. Made the MediaPlayer register the GStreamer backend only
if it's enabled (true by default on WebKitGTK+).

  • GNUmakefile.am:
  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateMessageCallback): (WebCore::mediaPlayerPrivateSourceChangedCallback): (WebCore::mediaPlayerPrivateVolumeChangedCallback): (WebCore::mediaPlayerPrivateMuteChangedCallback): (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivateGStreamer::create): (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): (WebCore::MediaPlayerPrivateGStreamer::isAvailable): (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::load): (WebCore::MediaPlayerPrivateGStreamer::commitLoad): (WebCore::MediaPlayerPrivateGStreamer::changePipelineState): (WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): (WebCore::MediaPlayerPrivateGStreamer::play): (WebCore::MediaPlayerPrivateGStreamer::pause): (WebCore::MediaPlayerPrivateGStreamer::duration): (WebCore::MediaPlayerPrivateGStreamer::currentTime): (WebCore::MediaPlayerPrivateGStreamer::seek): (WebCore::MediaPlayerPrivateGStreamer::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivateGStreamer::cancelSeek): (WebCore::MediaPlayerPrivateGStreamer::endPointTimerFired): (WebCore::MediaPlayerPrivateGStreamer::paused): (WebCore::MediaPlayerPrivateGStreamer::seeking): (WebCore::MediaPlayerPrivateGStreamer::naturalSize): (WebCore::MediaPlayerPrivateGStreamer::hasVideo): (WebCore::MediaPlayerPrivateGStreamer::hasAudio): (WebCore::MediaPlayerPrivateGStreamer::setVolume): (WebCore::MediaPlayerPrivateGStreamer::volumeChangedTimerFired): (WebCore::MediaPlayerPrivateGStreamer::volumeChanged): (WebCore::MediaPlayerPrivateGStreamer::setRate): (WebCore::MediaPlayerPrivateGStreamer::networkState): (WebCore::MediaPlayerPrivateGStreamer::readyState): (WebCore::MediaPlayerPrivateGStreamer::buffered): (WebCore::MediaPlayerPrivateGStreamer::processBufferingStats): (WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded): (WebCore::MediaPlayerPrivateGStreamer::bytesLoaded): (WebCore::MediaPlayerPrivateGStreamer::totalBytes): (WebCore::MediaPlayerPrivateGStreamer::cancelLoad): (WebCore::MediaPlayerPrivateGStreamer::updateStates): (WebCore::MediaPlayerPrivateGStreamer::mediaLocationChanged): (WebCore::MediaPlayerPrivateGStreamer::loadNextLocation): (WebCore::MediaPlayerPrivateGStreamer::loadStateChanged): (WebCore::MediaPlayerPrivateGStreamer::sizeChanged): (WebCore::MediaPlayerPrivateGStreamer::timeChanged): (WebCore::MediaPlayerPrivateGStreamer::didEnd): (WebCore::MediaPlayerPrivateGStreamer::durationChanged): (WebCore::MediaPlayerPrivateGStreamer::supportsMuting): (WebCore::MediaPlayerPrivateGStreamer::setMuted): (WebCore::MediaPlayerPrivateGStreamer::muteChangedTimerFired): (WebCore::MediaPlayerPrivateGStreamer::muteChanged): (WebCore::MediaPlayerPrivateGStreamer::loadingFailed): (WebCore::MediaPlayerPrivateGStreamer::setSize): (WebCore::MediaPlayerPrivateGStreamer::setVisible): (WebCore::MediaPlayerPrivateGStreamer::repaint): (WebCore::MediaPlayerPrivateGStreamer::paint): (WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes): (WebCore::MediaPlayerPrivateGStreamer::supportsType): (WebCore::MediaPlayerPrivateGStreamer::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen): (WebCore::MediaPlayerPrivateGStreamer::setPreload): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Mar 28, 2010:

9:11 PM Changeset in webkit [56706] by ap@apple.com
  • 2 edits in trunk/WebKit/chromium

Build fix. Removed extraneous includes of KeyboardCodesWin.h and KeyboardCodesPosix.h -
these no longer exist, but they weren't needed even before reshuffling KeyboardCodes headers.

8:53 PM Changeset in webkit [56705] by ap@apple.com
  • 10 edits in trunk/WebKit

Build fix. Include WindowsKeyboardCodes.h instead of KeyboardCodes.h.

8:41 PM Changeset in webkit [56704] by ap@apple.com
  • 13 edits
    1 move
    1 add
    5 deletes in trunk/WebCore

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=36733
Use a common header for Windows virtual key codes on all platforms

No change in functionality, so no new tests.

  • platform/WindowsKeyboardCodes.h: Added. Define VK_* key codes as macros, matching Windows.
  • platform/KeyboardCodes.h: Removed.
  • platform/android/KeyboardCodes.h: Removed.
  • platform/chromium/KeyboardCodesPosix.h: Removed.
  • platform/chromium/KeyboardCodesWin.h: Removed.
  • platform/haiku/KeyboardCodes.h: Removed.
  • platform/wx/KeyboardCodes.h: Removed. Removed platform specific attempts to do the same thing. In fact, platform/KeyboardCodes.h was supposed to be cross-platform, but it didn't have a sufficiently descriptive name, and its name was the same as platform-specific versions, so I chose a new one.
  • platform/chromium/KeyboardCodes.h: Copied from WebCore/platform/chromium/KeyboardCodesWin.h. Chromium redefines Windows constants to different names; keeping the header doing that to avoid breaking Chromium code.
  • GNUmakefile.am:
  • WebCore.gypi: Replaced KeyboardCodes.h with WindowsKeyboardCodes.h.
  • WebCore.xcodeproj/project.pbxproj:
  • platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForKeyCode): (WebCore::windowsKeyCodeForCharCode): Mac used to hardcode the key codes; changed to use VK_* macros.
  • config.h: Removed a hack to include KeyboardCodes.h, it shouldn't be necessary any more.
  • platform/android/KeyEventAndroid.cpp:
  • platform/brew/PlatformKeyboardEventBrew.cpp:
  • platform/efl/PlatformKeyboardEventEfl.cpp:
  • platform/gtk/KeyEventGtk.cpp:
  • platform/haiku/PlatformKeyboardEventHaiku.cpp:
  • platform/qt/PlatformKeyboardEventQt.cpp:
  • platform/wx/KeyboardEventWx.cpp: Changed to include WindowsKeyboardCodes.h.
3:48 PM Changeset in webkit [56703] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

Skip tests that need more load notifications than we provide in
our DRT currently.

  • platform/gtk/Skipped:
3:36 PM Changeset in webkit [56702] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Skipping new tests.

  • platform/gtk/Skipped:
3:29 PM Changeset in webkit [56701] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

No review, rolling out r56679.
http://trac.webkit.org/changeset/56679
https://bugs.webkit.org/show_bug.cgi?id=36454

Lots of tests broken.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView):
2:41 PM Changeset in webkit [56700] by eric@webkit.org
  • 4 edits in trunk

2010-03-28 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Remove the definition of WTF_CHANGES guards from the build system
https://bugs.webkit.org/show_bug.cgi?id=31670

  • JavaScriptCore.pro: Remove the definition of WTF_CHANGES as it is already defined in config.h

2010-03-28 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Remove the definition of WTF_CHANGES guards from the build system
https://bugs.webkit.org/show_bug.cgi?id=31670

No new tests as there is no new functionality.

  • WebCore.pri: Remove the definition of WTF_CHANGES as it is already defined in config.h
1:00 PM QtWebKitJournal edited by Simon Hausmann
(diff)
12:19 PM Changeset in webkit [56699] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Unreviewed.

Fixed typo in deprecated_logging_unittest.py, which is masking
sys.stderr while running test-webkitpy.

See also-- https://bugs.webkit.org/show_bug.cgi?id=36725#c3

  • Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
10:47 AM Changeset in webkit [56698] by weinig@apple.com
  • 2 edits in trunk/WebCore

Clean up the Xcode project a bit.

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj:
10:41 AM Changeset in webkit [56697] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-03-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Toggling style properties on/off does not always work.

https://bugs.webkit.org/show_bug.cgi?id=36720

  • inspector/InspectorController.cpp:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::buildArrayForDisabledStyleProperties):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):
10:32 AM Changeset in webkit [56696] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-03-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: resource links should navigate to resource panel enabler when resource tracking is off.

https://bugs.webkit.org/show_bug.cgi?id=36722

9:59 AM Changeset in webkit [56695] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-03-28 Dirk Schulze <krit@webkit.org>

Unreviewed test update for Win.

Out of bounds read in SVG feColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=32714

May mixed up the win bot with the win-chromium bot.

  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
9:30 AM Changeset in webkit [56694] by krit@webkit.org
  • 6 edits in trunk

2010-03-28 Dirk Schulze <krit@webkit.org>

Unreviewed build-fix for chromium linux.

SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):

2010-03-28 Dirk Schulze <krit@webkit.org>

Unreviewed test update.

SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185

Marker results update for Qt port.

  • platform/qt/svg/custom/marker-opacity-expected.txt:
  • platform/qt/svg/custom/marker-referencePoint-expected.txt:
  • platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
9:01 AM Changeset in webkit [56693] by krit@webkit.org
  • 43 edits
    2 adds
    2 deletes in trunk

2010-03-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185

This moves SVGResourceMarker to RenderersSVGResourceMarker. This follows other
SVG resources like masker and clipper and makes DRT results more readable and
adds additonal informations.
Some marker specific code also moved out from RenderSVGViewportContainer to
RenderersSVGResourceMarker.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::destroy):
  • rendering/RenderSVGResource.h: (WebCore::):
  • rendering/RenderSVGResourceMarker.cpp: Added. (WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker): (WebCore::RenderSVGResourceMarker::~RenderSVGResourceMarker): (WebCore::RenderSVGResourceMarker::layout): (WebCore::RenderSVGResourceMarker::addClient): (WebCore::RenderSVGResourceMarker::invalidateClients): (WebCore::RenderSVGResourceMarker::invalidateClient): (WebCore::RenderSVGResourceMarker::applyViewportClip): (WebCore::RenderSVGResourceMarker::markerBoundaries): (WebCore::RenderSVGResourceMarker::localToParentTransform): (WebCore::RenderSVGResourceMarker::referencePoint): (WebCore::RenderSVGResourceMarker::angle): (WebCore::RenderSVGResourceMarker::markerTransformation): (WebCore::RenderSVGResourceMarker::draw): (WebCore::RenderSVGResourceMarker::markerContentTransformation): (WebCore::RenderSVGResourceMarker::viewportTransform): (WebCore::RenderSVGResourceMarker::calcViewport):
  • rendering/RenderSVGResourceMarker.h: Added. (WebCore::RenderSVGResourceMarker::renderName): (WebCore::RenderSVGResourceMarker::applyResource): (WebCore::RenderSVGResourceMarker::resourceBoundingBox): (WebCore::RenderSVGResourceMarker::markerUnits): (WebCore::RenderSVGResourceMarker::resourceType):
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport): (WebCore::RenderSVGViewportContainer::viewportTransform):
  • rendering/RenderSVGViewportContainer.h:
  • rendering/SVGMarkerData.h: (WebCore::SVGMarkerData::SVGMarkerData): (WebCore::SVGMarkerData::marker): (WebCore::SVGMarkerData::updateTypeAndMarker):
  • rendering/SVGMarkerLayoutInfo.cpp: (WebCore::processStartAndMidMarkers): (WebCore::SVGMarkerLayoutInfo::calculateBoundaries): (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker):
  • rendering/SVGMarkerLayoutInfo.h: (WebCore::MarkerLayout::MarkerLayout): (WebCore::SVGMarkerLayoutInfo::midMarker):
  • rendering/SVGRenderSupport.cpp: (WebCore::deregisterFromResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeSVGResource):
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::childrenChanged): (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle): (WebCore::SVGMarkerElement::createRenderer):
  • svg/SVGMarkerElement.h: (WebCore::SVGMarkerElement::):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
  • svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isFilter):
  • svg/graphics/SVGResourceMarker.cpp: Removed.
  • svg/graphics/SVGResourceMarker.h: Removed.

2010-03-28 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
https://bugs.webkit.org/show_bug.cgi?id=36185

DRT results changed after moving SVGResourceMarker and need updates.

  • platform/mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-marker-creation-expected.txt:
  • platform/mac/svg/custom/marker-changes-expected.txt:
  • platform/mac/svg/custom/marker-child-changes-expected.txt:
  • platform/mac/svg/custom/marker-default-width-height-expected.txt:
  • platform/mac/svg/custom/marker-opacity-expected.txt:
  • platform/mac/svg/custom/marker-overflow-clip-expected.txt:
  • platform/mac/svg/custom/marker-referencePoint-expected.txt:
  • platform/mac/svg/custom/marker-strokeWidth-changes-expected.txt:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
8:23 AM Changeset in webkit [56692] by Chris Jerdonek
  • 10 edits in trunk/WebKitTools

Renamed check-webkit-style's --debug flag to --verbose to be more
in line with other WebKit scripts. Also renamed the current
--verbose flag to --min-confidence to allow the --debug rename.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=36521

We also renamed the internal "verbose" variables to "confidence" or
"min_confidence," as appropriate, to avoid confusion with the
--verbose flag, and because the new names are more accurate.

  • Scripts/check-webkit-style:
    • Renamed is_debug to is_verbose.
  • Scripts/webkitpy/style/checker.py:
    • Renamed _DEFAULT_VERBOSITY to _DEFAULT_CONFIDENCE.
    • Renamed "verbosity" parameters to "min_confidence" throughout.
    • Renamed configure_logging()'s is_debug parameter to is_verbose.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the unit tests as necessary.
  • Scripts/webkitpy/style/error_handlers.py:
    • Updated the call to StyleCheckerConfiguration.write_style_error().
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated the unit tests as necessary.
  • Scripts/webkitpy/style/optparser.py:
    • Updated the usage string with the new flag names.
    • Renamed the verbosity parameter to min_confidence throughout.
    • Renamed the is_debug parameter to is_verbose throughout.
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Updated the unit tests as necessary.
  • Scripts/webkitpy/style/processors/cpp.py:
    • Renamed the verbosity parameter to min_confidence throughout.
  • Scripts/webkitpy/style/processors/cpp_unittest.py:
    • Updated the unit tests as necessary.
8:05 AM Changeset in webkit [56691] by Chris Jerdonek
  • 2 edits in trunk/WebKitTools

Unreviewed.

Added back a line that accidentally got deleted in r56690.

  • Scripts/check-webkit-style:
7:51 AM Changeset in webkit [56690] by Chris Jerdonek
  • 5 edits in trunk/WebKitTools

Add to check-webkit-style support for checking directories.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35234

  • Scripts/check-webkit-style:
    • Replaced the call to check_file() with a call to check_paths().
  • Scripts/webkitpy/style/checker.py:
    • In the StyleChecker class:
      • Added a check_paths() method that accepts a list of paths to files and directories.
      • Added a _check_directory() method that checks the files in a directory.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added a StyleCheckerCheckPathsTest to unit-test the new check_paths() method.
  • Scripts/webkitpy/style/optparser.py:
    • Updated the usage string.
3:43 AM Changeset in webkit [56689] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-03-28 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Add API for reporting additional memory cost of JavaScript objects
https://bugs.webkit.org/show_bug.cgi?id=36650

  • qt/api/qscriptengine.cpp: (QScriptEngine::reportAdditionalMemoryCost):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.h: (QScriptEnginePrivate::reportAdditionalMemoryCost):
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::reportAdditionalMemoryCost):
3:33 AM Changeset in webkit [56688] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-03-28 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Consolidate Tree Hierarchy Attribute HTML Generation
https://bugs.webkit.org/show_bug.cgi?id=36719

Consolidates the generation of Element Tree Hierarchy attribute code
generation to a single function: _attributeHTML.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._addNewAttribute): convert to use attributeHTML. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.regenerateStyledAttribute): convert to use attributeHTML. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._attributeHTML): a single point for generating the html for attributes.
3:33 AM Changeset in webkit [56687] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-03-28 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481

Ensure blacklisting happens by checking it in _startEditingTagName
instead of all the possible entry points.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): don't check blacklist here. (WebInspector.ElementsTreeElement.prototype._startEditingTagName): check blacklist here.
3:03 AM Changeset in webkit [56686] by eric@webkit.org
  • 6 edits in trunk/JavaScriptCore

2010-03-28 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

QScriptEngine API was enriched by globalObject() method
which give an access to the global object.

[Qt] QScriptEngine doesn't give an access to global object
https://bugs.webkit.org/show_bug.cgi?id=36603

  • qt/api/qscriptengine.cpp: (QScriptEngine::globalObject):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::globalObject):
  • qt/api/qscriptengine_p.h:
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::globalObject):
2:46 AM Changeset in webkit [56685] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-28 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: Timing functions don't work with transitions
https://bugs.webkit.org/show_bug.cgi?id=36589

If the animation value doesn't have timing function set, we need to
use the animation's timing function.

Fixed also a bug in passing the duration to solveCubicBezierFunction.
The duration was divided two times by 1000 and meanwhile casted to int.
It needs to be kept as double and divided by 1000 only once.

Test case: https://bugs.webkit.org/attachment.cgi?id=51619

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::applyTimingFunction): (WebCore::AnimationQt:::AnimationQtBase): (WebCore::AnimationQt::updateCurrentTime):
1:49 AM Changeset in webkit [56684] by Joseph Pecoraro
  • 3 edits in trunk/WebCore

2010-03-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481

Allow tabbing back and forth between the tag name and element
attributes when editing. Also, fixed a number of minor issues with
editing attributes and tabbing.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditingTagName): find the tag name if it wasn't provided. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): fix tabbing issues, enable tab to tag name. (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.regenerateStyledAttribute): cleanup styles when tabbing.
  • inspector/front-end/inspector.css: do not display <br>s while editing
1:49 AM Changeset in webkit [56683] by Joseph Pecoraro
  • 11 edits in trunk/WebCore

2010-03-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481

Allow editing an Element's Tag Name by double clicking
on the tag name in the Element's Tree Hierarchy.

The usual asynchronous InspectorBackend, InspectorDOMAgent, InspectorFrontend flow.

  • inspector/InspectorBackend.cpp: moved DOM manipulation to InspectorDOMAgent (WebCore::InspectorBackend::removeNode): (WebCore::InspectorBackend::changeTagName):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::changeTagName):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didChangeTagName):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js:

Handle the UI for editing an Element's tag name.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): allow editing from double click. (WebInspector.ElementsTreeElement.prototype._startEditingTagName.keyupListener): update the closing tag (WebInspector.ElementsTreeElement.prototype._startEditingTagName.editingComitted): remove extra listener and commit (WebInspector.ElementsTreeElement.prototype._startEditingTagName.editingCancelled): remove extra listener and cancel (WebInspector.ElementsTreeElement.prototype._startEditingTagName): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.cancel): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.editTagNameCallback): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted): (WebInspector.ElementsTreeElement.prototype._distinctClosingTagElement): get the closing tag for an opening tag (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo): wrap the tagName in span.webkit-html-tag-name

Miscellaneous updates.

  • inspector/front-end/treeoutline.js: fixed a typo.
12:54 AM Changeset in webkit [56682] by Chris Jerdonek
  • 7 edits
    2 adds in trunk/WebKitTools

Changed check-webkit-style to convert paths to paths relative to
the checkout root when invoking check-webkit-style with path
arguments. Also added warning messages where appropriate.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35498

Converting paths to paths relative to the checkout root ensures
that style checking will behave as expected (since path-specific
rules assume input paths are relative to a source root).

  • Scripts/check-webkit-style:
    • Added debug logging of whether the current directory was found to be in a WebKit checkout.
    • Added the found_checkout parameter to the call to parser.parse().
    • Renamed the files variable to paths.
    • Added a call to change_directory() prior to checking style.
  • Scripts/webkitpy/style/checker.py:
    • For StyleChecker.check_file():
      • Updated the docstring.
      • Added two log messages.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated a call to parser.parse() with the found_checkout parameter.
  • Scripts/webkitpy/style/main.py: Added.
    • Added a new file so the code in this patch could be unit-tested, as opposed to adding new code to check-webkit-style.
    • Added the method _rel_path() as a substitute for os.path.relpath(), which is available only in Python 2.6.
    • Added the method change_directory(), which contains most of the new functionality in this patch.
  • Scripts/webkitpy/style/main_unittest.py: Added.
    • Added RelPathTest to test main._rel_path().
    • Added ChangeDirectoryTest to test main.change_directory().
  • Scripts/webkitpy/style/optparser.py:
    • Updated check-webkit-style's usage string.
    • For the ArgumentParser.parse() method:
      • Added a found_checkout parameter.
      • Renamed filenames to paths.
      • Added logic so that an error is raised if no paths are passed if found_checkout is False.
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Updated the ArgumentParser.parse() unit tests to include coverage for the new found_checkout parameter.
  • Scripts/webkitpy/style/unittests.py:
    • Added an import statement for main_unittest.
  • Scripts/webkitpy/style_references.py:
    • Renamed SimpleScm to WebKitCheckout.
    • Added a detect_checkout() function to allow returning None instead of a WebKitCheckout instance if no checkout is found.
    • Renamed checkout_root to root_path.

Mar 27, 2010:

11:09 PM Changeset in webkit [56681] by eric@webkit.org
  • 7 edits in trunk

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Removed 5 http/history tests from Skipped file

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • platform/gtk/Skipped:

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

FrameLoader emits onload-event when handling
dispatchDidHandleOnloadEvents

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents): implemented, now it emits onload-event signal
  • webkit/webkitwebview.cpp: added onload-event signal

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Print didHandleOnloadEventsForFrame in the callback of
onload-event signal comming from frame loader

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewOnloadEvent): (createWebView): added connection to signal::onload-event and signal callback
10:51 PM Changeset in webkit [56680] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Print didCommitLoadForFrame in the callback of signal::load-committed

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadCommitted): (createWebView): added connection to sinal::load-committed and signal callback
10:34 PM Changeset in webkit [56679] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Print didStartProvisionalLoadForFrame in the callback of
notify::load-status property change notification

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webInspectorCloseWindow): (webInspectorInspectWebView): (createWebView): added connection to notify::load-status and signal callback
9:16 PM Changeset in webkit [56678] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-03-27 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Use WebKitClient to instantiate WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=36669

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize):
7:50 PM Changeset in webkit [56677] by eric@webkit.org
  • 1 edit
    8 deletes in trunk/WebKitTools

2010-03-27 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

In webkitpy/, deleted the /unittests.py files since test-webkitpy
now auto-detects all *_unittest.py files.

https://bugs.webkit.org/show_bug.cgi?id=36712

  • Scripts/webkitpy/common/net/irc/unittests.py: Removed.
  • Scripts/webkitpy/common/system/unittests.py: Removed.
  • Scripts/webkitpy/common/thread/unittests.py: Removed.
  • Scripts/webkitpy/common/unittests.py: Removed.
  • Scripts/webkitpy/python24/unittests.py: Removed.
  • Scripts/webkitpy/style/unittests.py: Removed.
  • Scripts/webkitpy/tool/unittests.py: Removed.
  • Scripts/webkitpy/unittests.py: Removed.
7:32 PM Changeset in webkit [56676] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-03-27 Dmitry Gorbik <socket.h@gmail.com>

Reviewed by Pavel Feldman.

Fix the regression caused by r28078: a global variable
definition masks a local one in an inspector console
https://bugs.webkit.org/show_bug.cgi?id=32442

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
6:56 PM Changeset in webkit [56675] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

More updated results for r56673.

  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
6:07 PM Changeset in webkit [56674] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-03-27 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Eric Seidel.

Add a CR after printing didFinishDocumentLoadForFrame

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadFinished):
5:59 PM Changeset in webkit [56673] by mitz@apple.com
  • 12 edits in trunk

WebCore: <rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
https://bugs.webkit.org/show_bug.cgi?id=36700

Reviewed by Darin Adler.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::createColor): Reverted to returning an RGB color value rather than an
identifier for the transparent color.

LayoutTests: Updated results and one test for
<rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
https://bugs.webkit.org/show_bug.cgi?id=36700

Reviewed by Darin Adler.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/invalid-import-rule-insertion.html:
  • http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt:
  • http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt:
  • http/tests/security/cross-origin-css-expected.txt:
  • http/tests/security/cross-origin-css-in-xml-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
4:29 PM Changeset in webkit [56672] by Chris Jerdonek
  • 1 edit
    1 move in trunk/WebKitTools

Rubber-stamped by Adam Barth.

Fixed the name of a unit test file in webkitpy.

  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py.
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: Removed.
3:56 PM Changeset in webkit [56671] by Chris Jerdonek
  • 2 edits
    3 adds in trunk/WebKitTools

2010-03-26 Chris Jerdonek <Chris Jerdonek>

Reviewed by Adam Barth.

The test-webkitpy script now automatically detects all unit-test
files in webkitpy/. This lets us eliminate the need to have and
maintain all of the unittests.py files.

https://bugs.webkit.org/show_bug.cgi?id=36591

  • Scripts/test-webkitpy:
    • Replaced the "from webkitpy.unittests import *" with a call to webkitpy.test.main.Tester().run_tests().
  • Scripts/webkitpy/test/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
    • Required file for the new webkitpy/test/ directory.
  • Scripts/webkitpy/test/main.py: Added.
    • Added a Tester class that contains the following methods:
      • _find_unittest_files() to detect all the unit-test files.
      • _modules_from_paths() to convert the paths to the unit-test files to fully-qualified module names.
      • run_tests() which calls the above two methods and then passes the module names to Python's unittest module.
2:42 PM Changeset in webkit [56670] by Joseph Pecoraro
  • 6 edits in trunk/WebCore

2010-03-26 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Converge Inspector ids to be long, not ints
https://bugs.webkit.org/show_bug.cgi?id=36706

Part 1: Converge on long for callIds, nodeIds, and other Ids.

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
12:51 PM Changeset in webkit [56669] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Fix the newly-added test to not trip over a bug that causes some subsequent tests to fail.

Rubber-stamped by Dan Bernstein.

  • fast/dom/script-tests/setPrimitiveValue-exceptions.js:
12:31 PM Changeset in webkit [56668] by robert@webkit.org
  • 5 edits in trunk

2010-03-27 Robert Hogan <robert@webkit.org>

Reviewed by Simon Fraser.

[Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow.

https://bugs.webkit.org/show_bug.cgi?id=36701

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): Add onSetWindow. (webkit_test_plugin_destroy_instance): Add onSetWindow. (webkit_test_plugin_set_window): Add onSetWindow.
  • DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New): Add onSetWindow. (NPP_Destroy): Add onSetWindow. (NPP_SetWindow): Add onSetWindow.

2010-03-27 Robert Hogan <robert@webkit.org>

Unreviewed skip failing test.

[Qt] Skip test added in r56646. Tracked by https://bugs.webkit.org/show_bug.cgi?id=36702

https://bugs.webkit.org/show_bug.cgi?id=36701

  • platform/qt/Skipped: Add plugins/reentrant-update-widget-positions.html
12:24 PM Changeset in webkit [56667] by Darin Adler
  • 2 edits in trunk/WebKit/mac
  • Misc/WebNSFileManagerExtras.m:

(-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
Removed stray "!". How did that get in there?

12:20 PM Changeset in webkit [56666] by Darin Adler
  • 3 edits in trunk/WebKit/mac

WebKit NSFileManager methods don't handle broken symlinks correctly.
Part of <rdar://problem/7574046>.

Reviewed by Mark Rowe.

  • Misc/WebNSFileManagerExtras.h: Removed unused defines and methods.
  • Misc/WebNSFileManagerExtras.m: Removed unused methods.

(fileExists): Added. For use instead of fileExistsAtPath: for cases where we'd like
to treat a broken symlink as a file that does indeed exist.
(-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use fileExists.

12:17 PM Changeset in webkit [56665] by pfeldman@chromium.org
  • 2 edits
    1 add in trunk

2010-03-27 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: added missing test resource file.

  • inspector/resources/elements-panel-styles.css: Added.
11:24 AM Changeset in webkit [56664] by pfeldman@chromium.org
  • 7 edits
    2 adds in trunk

2010-03-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add layout test for styles panel.

https://bugs.webkit.org/show_bug.cgi?id=36699

Test: inspector/elements-panel-styles.html

  • inspector/front-end/inspector.css: (#elements-content): (#elements-sidebar):
  • inspector/front-end/inspector.js: (WebInspector.displayNameForURL):
  • inspector/front-end/utilities.js: (String.prototype.trimURL):
11:21 AM Changeset in webkit [56663] by mrowe@apple.com
  • 3 edits
    3 adds in trunk

CSSPrimitiveValue::setFloatValue/setStringValue should throw an exception if passed an incorrect unit type.
<http://webkit.org/b/36680> / <rdar://problem/7801016>

Reviewed by Darin Adler.

WebCore:

Test: fast/dom/setPrimitiveValue-exceptions.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::setFloatValue): Throw an INVALID_ACCESS_ERR if either of our type or the passed-in
type is not a numeric type.
(WebCore::CSSPrimitiveValue::setStringValue): Throw an INVALID_ACCESS_ERR if either of our type or the passed-in
type is not a string type.

LayoutTests:

  • fast/dom/script-tests/setPrimitiveValue-exceptions.js: Added.
  • fast/dom/setPrimitiveValue-exceptions-expected.txt: Added.
  • fast/dom/setPrimitiveValue-exceptions.html: Copied from LayoutTests/fast/dom/event-attribute-availability.html.
6:06 AM Changeset in webkit [56662] by robert@webkit.org
  • 2 edits in trunk/WebCore

2010-03-27 Robert Hogan <robert@webkit.org>

Reviewed by nobody, fix typo in previous commit.

Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',

when pluginsEnabled is false

Fix parentheses typo in r56661. This happened while rebasing and was not present
in the reviewed patch, so committing unreviewed.

https://bugs.webkit.org/attachment.cgi?id=49515

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
5:46 AM Changeset in webkit [56661] by robert@webkit.org
  • 18 edits in trunk

2010-03-26 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',

when pluginsEnabled is false.

The purpose of disabling plugins is to prevent the execution of third-party code
that may be untrustworthy. Qt plugins are implemented by the client rather than
loaded from an external source, so the client should have the opportunity to
consider them separately from other plugins.

Add a function MimeTypeRegistry::isApplicationPluginMIMEType() that WebKit
uses in conjunction with arePluginsEnabled() to determine if it should attempt
to load a plugin. If isApplicationPluginMIMEType() returns true, WebKit will load
the plugin even if arePluginsEnabled() is false.

Currently, only Qt has application-implemented plugins: these use the mimetype
'x-qt-plugin' and 'x-qt-styled-widget'. This patch permits Qt clients'
reimplementation of QWebPage::createPlugin() to decide whether or not
to create a Qt plugin, even when arePluginsEnabled is false.

For all platforms apart from Qt, isApplicationPluginMIMEType() returns false.

https://bugs.webkit.org/show_bug.cgi?id=32196

Test: plugins/application-plugin-plugins-disabled.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
  • platform/MIMETypeRegistry.h:
  • platform/brew/MIMETypeRegistryBrew.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/gtk/MIMETypeRegistryGtk.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/haiku/MIMETypeRegistryHaiku.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/mac/MIMETypeRegistryMac.mm: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/qt/MIMETypeRegistryQt.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/win/MIMETypeRegistryWin.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/wince/MIMETypeRegistryWince.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
  • platform/wx/MimeTypeRegistryWx.cpp: (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):

2010-03-26 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',

when pluginsEnabled is false.

For all platforms apart from Qt, isApplicationPluginMIMEType() returns false.

https://bugs.webkit.org/show_bug.cgi?id=32196

  • platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • plugins/application-plugin-plugins-disabled.html: Added.

2010-03-26 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',

when pluginsEnabled is false.

Add support for LayoutTestController.WebKitPluginsEnabled

https://bugs.webkit.org/show_bug.cgi?id=32196

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (copyWebSettingKey):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference):
5:36 AM Changeset in webkit [56660] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

Unreviewed.
Skip HTMLProgressElement tests on Windows.

  • platform/win/Skipped:
2:06 AM Changeset in webkit [56659] by mitz@apple.com
  • 2 edits in trunk/WebCore

Fix Acid3 text-shadow rendering regression introduced in r56597.

Reviewed by Mark Rowe.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): Revert to using the simple shadow logic for zero-blur shadows,
except for color bitmap fonts.

Note: See TracTimeline for information about the timeline view.