Timeline


and

04/06/10:

23:40 Changeset [57195] by eric@webkit.org

2010-03-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add webkit-patch command to crawl buildbot history and find when tests
started to fail.
https://bugs.webkit.org/show_bug.cgi?id=36911

This is a very bare-bones implementation, which works, but isn't pretty.
We will need further re-factoring and improvement to this code, but
after long discussions with Adam, I think it's best that we land this
and iterate from there.

  • Scripts/webkitpy/common/net/buildbot.py:
    • Add revision_build_pairs_with_results for cleaner code and possible optimization of this command.
    • Return None if a build number can't be found for a revision in build_for_revision
    • Separate out suspect_revisions_for_transition for re-use by FailureReason
    • Add LayoutTestResults.failing_tests() and make our parsing code explict about what tables it accepts.
  • Scripts/webkitpy/tool/commands/queries.py:
    • Move _print_blame_information_for_commit out of WhatBroke for re-use by FailureReason.
    • Add FailureReason command which can crawl a given builder and explain why it is currently red on a per-test basis.
22:14 Changeset [57194] by bolsinga@apple.com

https://bugs.webkit.org/show_bug.cgi?id=37188
WebCore::page::Geolocation::m_shouldClearCache is not used.

Reviewed by Darin Adler.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Geolocation): Remove m_shouldClearCache.

  • page/Geolocation.h:

(WebCore::Geolocation::): Ditto.

21:58 Changeset [57193] by eric@webkit.org

2010-04-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Remove obsolete MOBILE flag
https://bugs.webkit.org/show_bug.cgi?id=37125

The MOBILE flag is no longer used by any of the ports.
The flag use to control some tokenizer defaults that
can be changed runtime.

No new tests as there is no new functionality.

  • config.h:
  • html/HTMLTokenizer.cpp:
21:38 Changeset [57192] by eric@webkit.org

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646

Add a new exception type for forcibly terminating a JavaScript stack.
The new exception functions similarly to the
InterruptedExecutionException but is conceptually different because
execution is terminated instead of just interrupted.

  • GNUmakefile.am:
    • Added new Terminator.h file.
  • JavaScriptCore.gypi:
    • Added new Terminator.h file.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
    • Added new Terminator.h file.
  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Added new Terminator.h file.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::throwException):
    • Fully unwind the stack for TerminatedExecutionException.

(JSC::Interpreter::privateExecute):

  • Check if we've been terminated at the same time we check if we've timed out.
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
    • Check if we've been terminated at the same time we check if we've timed out.
  • runtime/Completion.cpp:
    • Some exceptions define special completion types so that calls can see why we terminated evaluation.

(JSC::evaluate):

  • runtime/Completion.h:
    • Define a new completion type for termination.

(JSC::):

  • runtime/ExceptionHelpers.cpp:
    • Define TerminatedExecutionException and refactor pseudo-RTTI virtual function to be more semantic.

(JSC::InterruptedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::toString):
(JSC::createTerminatedExecutionException):

  • runtime/ExceptionHelpers.h:
    • Entry point for generating a TerminatedExecutionException.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
    • Add a Terminator object that can be used to asynchronously terminate a JavaScript execution stack.
  • runtime/JSGlobalData.h:
  • runtime/JSObject.h: (JSC::JSObject::exceptionType):
    • Define that, by default, thrown objects have a normal exception type.
  • runtime/Terminator.h: Added.
    • Added a new controller object that can be used to terminate execution asynchronously. This object is more or less a glorified bool.

(JSC::Terminator::Terminator):
(JSC::Terminator::termianteSoon):
(JSC::Terminator::shouldTerminate):

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646

  • fast/workers/resources/worker-run-forever.js: Added.
  • fast/workers/worker-terminate-forever-expected.txt: Added.
  • fast/workers/worker-terminate-forever.html: Added.
    • Test what happens when we terminate an infinitely running worker. The essential point is that we don't spam the console with nonsense about a timeout.
  • platform/mac/Skipped:
    • Rescue worker-terminate.html from the Skipped list now that we've fixed the underlying bug that was causing the flakiness.

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646

Cause the worker code to swallow termination exceptions because these
need not be reported to the user because they are an implementation
detail of how we terminate worker execution.

Test: fast/workers/worker-terminate-forever.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::reportException):
    • Refuse to report termination exceptions to the user because they are an implementation detail.
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::forbidExecution):
    • Instead of using timeouts to stop run away workers, use our fancy new Terminator object.
21:17 Changeset [57191] by eric@webkit.org

2010-04-06 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Seidel.

Checking in new baselines for media/video-controls-rendering.html and fast/layers/video-layer.html.
https://bugs.webkit.org/show_bug.cgi?id=37180

  • platform/chromium-linux/media/video-controls-rendering-expected.checksum: Wasn't rebaselined when Linux scrollbars changed.
  • platform/chromium-linux/media/video-controls-rendering-expected.png: Ditto.
  • platform/chromium-mac/fast/layers/video-layer-expected.txt: Wasn't rebaselined when audio/video UI was refreshed.
  • platform/chromium-win/fast/layers/video-layer-expected.txt: Ditto.
  • platform/chromium/test_expectations.txt: Removed expectations for the above two tests.
20:10 Changeset [57190] by mitz@apple.com

Tiger build fix after r57184.

  • WebView/WebHTMLViewPrivate.h:
19:54 Changeset [57189] by mitz@apple.com

Tiger build fix after r57184.

  • WebView/WebHTMLViewPrivate.h:
19:39 Changeset [57188] by tkent@chromium.org

2010-04-06 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add DumpRenderTree.gyp, and some small fixes
https://bugs.webkit.org/show_bug.cgi?id=37137

  • Add DumpRenderTree.gyp
  • Remove some dependencies to base/string_util.h, base/compiler_specific.h, base/file_path.h, base/file_util.h, base/message_loop.h, base/sys_string_conversions.h,
  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Added.
  • DumpRenderTree/chromium/CppVariant.cpp: (CppVariant::toStringVector):
  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::keyDown): (EventSender::scheduleAsynchronousClick): (EventSender::beginDragWithFiles):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::pathToLocalResource):
  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::markedRange): (TextInputController::selectedRange):
19:33 Changeset [57187] by dpranke@chromium.org

2010-04-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Write stack traces into the results directory for new-run-webkit-tests,
instead of writing them alongside the test file.

https://bugs.webkit.org/show_bug.cgi?id=36504

  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
19:29 Changeset [57186] by abarth@webkit.org

2010-04-06 Adam Barth <abarth@webkit.org>

Unreviewed.

Speculative build fix for Tiger.

  • WebView/WebHTMLViewPrivate.h:
19:27 Changeset [57185] by dpranke@chromium.org

2010-04-06 Dirk Pranke <dpranke@chromium.org>

Unreviewed build fix.

Enable pixel tests by default in new-run-webkit-tests unless
explicitly set by the port or by the command line. This was broken in
the fix for bug 36801 (rev. 57173).

https://bugs.webkit.org/show_bug.cgi?id=37184

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18:53 Changeset [57184] by mitz@apple.com

Expose WebHTMLView’s page breaking logic as SPI.

Reviewed by Sam Weinig and Anders Carlsson.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): Factored out of -adjustPageHeightNew:top:bottom:limit:
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Call -_adjustedBottomOfPageWithTop:bottom:limit:

  • WebView/WebHTMLViewPrivate.h: Declared -_adjustedBottomOfPageWithTop:bottom:limit:
18:40 Changeset [57183] by mrowe@apple.com

Add an #if in order to make Tiger happy.

  • WebView/WebViewData.mm:

(-[WebViewPrivate init]):

18:29 Changeset [57182] by eric@webkit.org

2010-04-06 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Add basic FileSystem operations for FileReader/FileWriter support for POSIX (incl. Mac)
https://bugs.webkit.org/show_bug.cgi?id=36938

No new tests; will be added when we implement upper layers.

  • platform/FileSystem.h: (WebCore::):
  • platform/posix/FileSystemPOSIX.cpp: (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::writeToFile): (WebCore::readFromFile):
18:15 Changeset [57181] by mrowe@apple.com

Build fix.

  • WebView/WebViewData.mm:

(-[WebViewPrivate init]): Use objc_collectingEnabled like we do elsewhere in WebKit.

18:02 Changeset [57180] by eric@webkit.org

2010-04-06 Nicolas Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Implement DragImage functionality for chromium/mac.
https://bugs.webkit.org/show_bug.cgi?id=37069

  • page/chromium/DragControllerChromium.cpp: (WebCore::DragController::maxDragImageSize): Use a max size of 400x400 on OS X.
  • platform/chromium/DragImageChromiumMac.cpp: (WebCore::dragImageSize): Implement. (WebCore::deleteDragImage): Implement. (WebCore::scaleDragImage): Implement. (WebCore::dissolveDragImageToFraction): Implement. (WebCore::createDragImageFromImage): Implement.
  • platform/chromium/DragImageRef.h: Use CGImageRefs as DragImageRef on OS X.

2010-04-06 Nicolas Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Use drag images on OS X as well.
https://bugs.webkit.org/show_bug.cgi?id=37069

  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
16:37 Changeset [57179] by mrowe@apple.com

REGRESSION (r57113): editing/inserting/break-blockquote-after-delete.html fails on Windows
<http://webkit.org/b/37156> / <rdar://problem/7832408>

Rubber-stamped by Oliver Hunt.

Land Windows-specific results for editing/inserting/break-blockquote-after-delete.html. <rdar://problem/7834280>
tracks understanding the root cause of this difference between Mac and Windows.

  • platform/win/editing/inserting/break-blockquote-after-delete-expected.checksum: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.checksum.
  • platform/win/editing/inserting/break-blockquote-after-delete-expected.png: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.png.
  • platform/win/editing/inserting/break-blockquote-after-delete-expected.txt: Copied from LayoutTests/platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt.
16:36 Changeset [57178] by eric@webkit.org

2010-04-06 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add test for javascript:window.open() popup blocker bypass.
https://bugs.webkit.org/show_bug.cgi?id=37138

  • fast/events/popup-blocked-from-window-open.html: added
  • fast/events/popup-blocked-from-window-open-expected.txt: added

2010-04-06 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Use the new UserGestureIndictor to process javascript:window.open()

https://bugs.webkit.org/show_bug.cgi?id=37138

  • bindings/v8/ScriptController.cpp (WebCore::ScriptController::processingUserGesture): Use the new UserGestureIndicator when processing a javascript:window.open()
16:27 Changeset [57177] by eric@webkit.org

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
https://bugs.webkit.org/show_bug.cgi?id=37145

The timeout on this test is wrong because the helper library assumes
that we're only going to do one transition, but the test actually does
two in sequence. This patch doubles the timeout to account for that.

The design of these tests are quite unfortunate because these timeout
behaviors don't seem like they'd be reliable on slow machines like
Tiger. I'm not 100% convinced that this will fix the flakiness, but it
seems like an improvement.

I'll file a separate bug about DRT leaking state from one test to
another.

  • transitions/transition-end-event-helpers.js:
  • transitions/transition-end-event-set-none.html:
16:17 Changeset [57176] by eric@webkit.org

2010-04-06 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Renaming Graphics Layer related classes used by Chromium from *Skia to *Chromium and replacing wherever possible Skia-specific
data types with WebCore equivalents. The source files will be renamed accordingly and moved out of platform/graphics/skia
in a subsequent CL.
https://bugs.webkit.org/show_bug.cgi?id=37116

No new functionality so no new tests.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/skia/GraphicsLayerSkia.cpp: (WebCore::setLayerBorderColor): (WebCore::clearBorderColor): (WebCore::setLayerBackgroundColor): (WebCore::clearLayerBackgroundColor): (WebCore::GraphicsLayer::create): (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::setName): (WebCore::GraphicsLayerChromium::nativeLayer): (WebCore::GraphicsLayerChromium::setChildren): (WebCore::GraphicsLayerChromium::addChild): (WebCore::GraphicsLayerChromium::addChildAtIndex): (WebCore::GraphicsLayerChromium::addChildBelow): (WebCore::GraphicsLayerChromium::addChildAbove): (WebCore::GraphicsLayerChromium::replaceChild): (WebCore::GraphicsLayerChromium::removeFromParent): (WebCore::GraphicsLayerChromium::setPosition): (WebCore::GraphicsLayerChromium::setAnchorPoint): (WebCore::GraphicsLayerChromium::setSize): (WebCore::GraphicsLayerChromium::setTransform): (WebCore::GraphicsLayerChromium::setChildrenTransform): (WebCore::GraphicsLayerChromium::setPreserves3D): (WebCore::GraphicsLayerChromium::setMasksToBounds): (WebCore::GraphicsLayerChromium::setDrawsContent): (WebCore::GraphicsLayerChromium::setBackgroundColor): (WebCore::GraphicsLayerChromium::clearBackgroundColor): (WebCore::GraphicsLayerChromium::setContentsOpaque): (WebCore::GraphicsLayerChromium::setBackfaceVisibility): (WebCore::GraphicsLayerChromium::setOpacity): (WebCore::GraphicsLayerChromium::setNeedsDisplay): (WebCore::GraphicsLayerChromium::setNeedsDisplayInRect): (WebCore::GraphicsLayerChromium::setContentsRect): (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::setContentsToVideo): (WebCore::GraphicsLayerChromium::setGeometryOrientation): (WebCore::GraphicsLayerChromium::hostLayerForSublayers): (WebCore::GraphicsLayerChromium::layerForSuperlayer): (WebCore::GraphicsLayerChromium::platformLayer): (WebCore::GraphicsLayerChromium::setDebugBackgroundColor): (WebCore::GraphicsLayerChromium::setDebugBorder): (WebCore::GraphicsLayerChromium::updateSublayerList): (WebCore::GraphicsLayerChromium::updateLayerPosition): (WebCore::GraphicsLayerChromium::updateLayerSize): (WebCore::GraphicsLayerChromium::updateAnchorPoint): (WebCore::GraphicsLayerChromium::updateTransform): (WebCore::GraphicsLayerChromium::updateChildrenTransform): (WebCore::GraphicsLayerChromium::updateMasksToBounds): (WebCore::GraphicsLayerChromium::updateContentsOpaque): (WebCore::GraphicsLayerChromium::updateBackfaceVisibility): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore::GraphicsLayerChromium::updateLayerDrawsContent): (WebCore::GraphicsLayerChromium::updateLayerBackgroundColor): (WebCore::GraphicsLayerChromium::updateContentsImage): (WebCore::GraphicsLayerChromium::updateContentsVideo): (WebCore::GraphicsLayerChromium::updateContentsRect): (WebCore::GraphicsLayerChromium::updateGeometryOrientation): (WebCore::GraphicsLayerChromium::setupContentsLayer): (WebCore::GraphicsLayerChromium::updateOpacityOnLayer):
  • platform/graphics/skia/GraphicsLayerSkia.h: (WebCore::GraphicsLayerChromium::primaryLayer): (WebCore::GraphicsLayerChromium::contentsLayer):
  • platform/graphics/skia/LayerRendererSkia.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::updateLayerContents): (WebCore::LayerRendererChromium::drawLayersInCanvas): (WebCore::LayerRendererChromium::drawLayerInCanvasRecursive): (WebCore::LayerRendererChromium::updateLayerContentsRecursive):
  • platform/graphics/skia/LayerRendererSkia.h: (WebCore::LayerRendererChromium::setRootLayer): (WebCore::LayerRendererChromium::rootLayer):
  • platform/graphics/skia/LayerSkia.cpp: (WebCore::LayerChromium::create): (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::updateGraphicsContext): (WebCore::LayerChromium::updateContents): (WebCore::LayerChromium::drawDebugBorder): (WebCore::LayerChromium::setNeedsCommit): (WebCore::LayerChromium::addSublayer): (WebCore::LayerChromium::insertSublayer): (WebCore::LayerChromium::removeFromSuperlayer): (WebCore::LayerChromium::removeSublayer): (WebCore::LayerChromium::indexOfSublayer): (WebCore::LayerChromium::setBackingStoreRect): (WebCore::LayerChromium::setBounds): (WebCore::LayerChromium::setFrame): (WebCore::LayerChromium::rootLayer): (WebCore::LayerChromium::removeAllSublayers): (WebCore::LayerChromium::setSublayers): (WebCore::LayerChromium::setSuperlayer): (WebCore::LayerChromium::superlayer): (WebCore::LayerChromium::setNeedsDisplay):
  • platform/graphics/skia/LayerSkia.h: (WebCore::LayerChromium::setAnchorPoint): (WebCore::LayerChromium::anchorPoint): (WebCore::LayerChromium::borderWidth): (WebCore::LayerChromium::bounds): (WebCore::LayerChromium::frame): (WebCore::LayerChromium::setPosition): (WebCore::LayerChromium::position): (WebCore::LayerChromium::zPosition): (WebCore::LayerChromium::getSublayers): (WebCore::LayerChromium::setSublayerTransform): (WebCore::LayerChromium::sublayerTransform): (WebCore::LayerChromium::setTransform): (WebCore::LayerChromium::transform):

2010-04-06 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Changing references to Graphics Layer related classes from *Skia to *Chromium.
https://bugs.webkit.org/show_bug.cgi?id=37116

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::setAcceleratedCompositing): (WebKit::WebViewImpl::updateRootLayerContents):
  • src/WebViewImpl.h:
16:04 Changeset [57175] by eric@webkit.org

2010-04-06 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] These tests can be removed from the skipped list since these
work after the redirection loop detection implemented in qt network.
https://bugs.webkit.org/show_bug.cgii?id=36690

  • platform/qt/Skipped:
15:55 Changeset [57174] by eric@webkit.org

2010-04-06 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Laszlo Gombos.

[Qt] WebKit does not build on Windows with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=37026

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform):
15:47 Changeset [57173] by dpranke@chromium.org

2010-04-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Disable pixel tests on the mac port by default.

Also, revamp the way we check for pixel tests being enabled or
disabled. We now look for options.pixel_tests instead of
options.no_pixel_tests, and we have the "--pixel-tests" (force enable)
and "--no-pixel-tests" (force disable) flags.

https://bugs.webkit.org/show_bug.cgi?id=36801

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15:42 Changeset [57172] by eric@webkit.org

2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Laszlo Gombos.

[Qt] Added the iPhone and iPad latest user agent in QtLauncher UA switcher
https://bugs.webkit.org/show_bug.cgi?id=37159

  • QtLauncher/useragentlist.txt:
15:39 Changeset [57171] by jhawkins@chromium.org

2010-04-06 James Hawkins <jhawkins@chromium.org>

Reviewed by Adam Barth.

[Chromium] Implement WebInputElement::maxLength.
https://bugs.webkit.org/show_bug.cgi?id=37172

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::maxLength):
15:32 Changeset [57170] by eric@webkit.org

2010-04-06 Abhinav Mithal <abhinav.mithal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] npapi header leaves XP_WIN flag defined even when SYMBIAN32 flag is found
https://bugs.webkit.org/show_bug.cgi?id=34614

Do not define XP_WIN if WebKit is compiled for Symbian.

No new tests as there is no new functionality.

  • bridge/npapi.h:
15:02 Changeset [57169] by aestes@apple.com

Added myself to the committers list.

14:58 Changeset [57168] by scherkus@chromium.org

2010-04-06 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, media test expectations tweak.

We now regularly run http/tests/media and have to mark a few tests as TIMEOUT.

  • platform/chromium/test_expectations.txt:
14:28 Changeset [57167] by cfleizach@apple.com

aria-label doesn't work on image map area
https://bugs.webkit.org/show_bug.cgi?id=36977

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/area-with-aria-label.html

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::accessibilityDescription):

LayoutTests:

  • platform/mac/accessibility/area-with-aria-label-expected.txt: Added.
  • platform/mac/accessibility/area-with-aria-label.html: Added.
14:21 Changeset [57166] by scherkus@chromium.org

2010-04-06 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, cleaning up media layout test expectations.

Mostly correcting bug numbers, updating comments, and fixing expectations.

  • platform/chromium/test_expectations.txt:
13:44 Changeset [57165] by jamesr@google.com

2010-04-06 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Reverts the incorrect fixed position fastpath scrolling logic
https://bugs.webkit.org/show_bug.cgi?id=33150

This code does not properly handle overflow or transforms on fixed
position elements, causing repaint bugs on scroll.

No new tests.

  • page/FrameView.cpp: (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
  • platform/ScrollView.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
12:58 Changeset [57164] by kevino@webkit.org

[wx] Build fix for wxMac / Cocoa on wx trunk.

12:50 Changeset [57163] by eric@webkit.org

2010-04-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Darin Adler.

JS code generator does not support feature conditional attributes that are writable
https://bugs.webkit.org/show_bug.cgi?id=37149

Write out the feature #ifdef not only for the getter, but also for the setter
function.

  • bindings/scripts/CodeGeneratorJS.pm:
12:17 Changeset [57162] by eric@webkit.org

2010-04-06 Evan Stade <estade@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811

Use the DragImageRef that the DragController passes to us.

This was previously committed but rolled back for breaking layout
tests. The fix is on the WebKit/chromium side.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/DragImageChromium.cpp: Removed.
  • platform/chromium/DragImageChromiumMac.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageChromiumSkia.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageRef.h:

2010-04-06 Evan Stade <estade@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811

Basic implementation using SkBitmap. Transformations are not supported
yet. No implementation for mac.

This was previously committed but rolled back for breaking layout
tests.

  • public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag): new: check for null dragImage.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
  • src/WebViewImpl.h:
11:56 Changeset [57161] by yuzo@google.com

2010-04-01 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Fix bug: CSS3 :not selector with ID simple selector sequence test fails
https://bugs.webkit.org/show_bug.cgi?id=36276

  • fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
  • fast/css/invalid-not-with-simple-selector-sequence.html: Added.

2010-04-01 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Fix bug: CSS3 :not selector with ID simple selector sequence test fails
As per http://www.w3.org/TR/css3-selectors/#negation, :not(X) takes a simple selector as an argument.
WebKit was accepting a simple selector *sequence*.
This patch adds WebCore::CSSSelector::isSimple which judges if the selector is simple.
The method is used in CSSGrammar.y to decide whether to accept the selector as the argument of :not().
https://bugs.webkit.org/show_bug.cgi?id=36276

Test: fast/css/invalid-not-with-simple-selector-sequence.html

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::isSimple):
  • css/CSSSelector.h:
11:18 Changeset [57160] by darin@apple.com

REGRESSION (r57109): editing/pasteboard/drag-image-to-contenteditable-in-iframe.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=37157

  • platform/win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:

Copied from platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt.
Windows gets a different result than Mac because the dragging code ends up making the src attribute
of the dragged element have a full path on Windows, but not on Mac.

11:17 Changeset [57159] by mitz@apple.com

Rubber-stamped by Dan Bernstein.

Patch by Andy Estes <aestes@apple.com> on 2010-04-06
Remove non-ASCII characters from license headers to fix build errors on
Japanese Windows.

https://bugs.webkit.org/show_bug.cgi?id=37008

  • dom/UserGestureIndicator.cpp:
  • dom/UserGestureIndicator.h:
10:59 Changeset [57158] by jhawkins@chromium.org

2010-04-06 James Hawkins <jhawkins@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Move the getElementsByTagName from WebDocument to WebNode.
https://bugs.webkit.org/show_bug.cgi?id=37161

  • public/WebDocument.h:
  • public/WebNode.h:
  • src/WebDocument.cpp:
  • src/WebNode.cpp: (WebKit::WebNode::getElementsByTagName):
10:49 Changeset [57157] by eric@webkit.org

2010-04-06 Andrei Popescu <andreip@google.com>

Reviewed by Dimitri Glazkov.

[V8][Android] PageCache crashes when JavaScript is disabled
https://bugs.webkit.org/show_bug.cgi?id=37150

This patch ensures that saving and restoration of the script
state only happens when JS is enabled and each frame has a
non-null context.

No new tests: existing tests show the feature is working
when JS is enabled. When JS is disabled, manual testing
is required.

  • bindings/v8/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore):
10:39 Changeset [57156] by eric@webkit.org

2010-04-06 Bryan Yeung <bryeung@chromium.org>

Reviewed by Dimitri Glazkov.

Update chromium expectations for passing Linux tests.

  • platform/chromium/test_expectations.txt:
10:29 Changeset [57155] by eric@webkit.org

2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Add mechanism to detect QtWebKit 2.0 via the preprocessor
https://bugs.webkit.org/show_bug.cgi?id=36538

  • Api/qwebkitglobal.h:
10:11 Changeset [57154] by yurys@chromium.org

2010-04-06 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations for fast/dom/error-to-string-stack-overflow.html.

  • platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium/test_expectations.txt:
09:15 Changeset [57153] by loislo@chromium.org

2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for Chromium DEPS.

  • DEPS:
08:56 Changeset [57152] by loislo@chromium.org

2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed: build fixi for WebKit Chromium bots.

  • DEPS:
08:11 Changeset [57151] by loislo@chromium.org

2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

Web Inspector: missed files were added.

  • GNUmakefile.am:
  • bindings/js/ScriptGCEvent.h: Added. (WebCore::ScriptGCEvent::addEventListener): (WebCore::ScriptGCEvent::removeEventListener): (WebCore::ScriptGCEvent::getHeapSize):
  • bindings/v8/ScriptGCEvent.cpp: Added. (WebCore::ScriptGCEvent::addEventListener): (WebCore::ScriptGCEvent::removeEventListener): (WebCore::ScriptGCEvent::getHeapSize): (WebCore::ScriptGCEvent::getUsedHeapSize): (WebCore::ScriptGCEvent::gcPrologueCallback): (WebCore::ScriptGCEvent::gcEpilogueCallback):
  • bindings/v8/ScriptGCEvent.h: Added.
  • inspector/ScriptGCEventListener.h: Added. (WebCore::ScriptGCEventListener::~ScriptGCEventListener):
07:50 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
07:46 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
07:44 Changeset [57150] by loislo@chromium.org

2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: The JS code can be not optimal from memory usage point of view.
As example it can generate a lot of temp objects and GC will spend significant time to collect these objects.
GC event will show us these moments. Also each event can show us how much memory is in use.
https://bugs.webkit.org/show_bug.cgi?id=37025

  • WebCore.gypi:
  • WebCore.pro:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::didGC): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::setHeapSizeStatistic): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::instanceCount): (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry): (WebCore::InspectorTimelineAgent::GCEvent::GCEvent):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGCEventData):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/Popover.js: (WebInspector.PopoverHelper.prototype._mouseHover):
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
07:33 Changeset [57149] by tonikitoo@webkit.org

Unreviewed identation fix.

07:32 Changeset [57148] by tonikitoo@webkit.org

Remove unused DIRECTIONAL_PAD_NAVIGATION
https://bugs.webkit.org/show_bug.cgi?id=37134

Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Android browser was planning to have a "directional pad navigation" available on
trunk, under a build guard called DIRECTIONAL_PAD_NAVIGATION, but according to
https://bugs.webkit.org/show_bug.cgi?id=23145#c3 , the plan was dropped.

However bug 23163 landed some code relying on the build flag supposedly to be added,
and is now dead code in trunk.

  • dom/Element.cpp:

(WebCore::Element::updateFocusAppearance):

07:00 Changeset [57147] by yurys@chromium.org

2010-04-06 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

https://bugs.webkit.org/show_bug.cgi?id=36375

  • platform/chromium-win/fast/workers/worker-script-error-expected.txt:
06:45 Changeset [57146] by pfeldman@chromium.org

2010-04-06 Mattias Nissler <mnissler@chromium.org>

Reviewed by Pavel Feldman.

Rework inspector docking to issue a request call from the frontend
whenever the user triggers to (un)dock the inspector window. Doing so
enables InspectorFrontendHost implementations to asynchronously decide
whether the window is docked or not. The old canAttachWindow() is not
required anymore, remove it.
https://bugs.webkit.org/show_bug.cgi?id=36944

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::requestAttachWindow):
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::requestAttachWindow):
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/inspector.js: (WebInspector.toggleAttach):

2010-04-06 Mattias Nissler <mnissler@chromium.org>

Reviewed by Pavel Feldman.

Handle docking requests from the developer tools and forward them to
WebDevToolsFrontendClient.
https://bugs.webkit.org/show_bug.cgi?id=36944

  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::requestDockWindow):
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsRequestAttachWindow):
  • src/WebDevToolsFrontendImpl.h:
06:33 Changeset [57145] by vitalyr@chromium.org

2010-04-06 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Yury Semikhatsky.

[V8] Extend the set of types supported by SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=37052

New types include sparse arrays, Uint32, Date, and ImageData.

Serialization process became more flexible. A state can either
directly write primitive values (instead of returning them like
iterator) or construct a new state for serializing complex values
that will return to the current state when done.

Deserialization process now avoids exposing the tags using a set
of factory functions for complex objects instead.

Internal buffer type changed to uint8_t to be independent of
whether char is signed or not.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::Writer): (WebCore::Writer::writeString): (WebCore::Writer::writeUint32): (WebCore::Writer::writeDate): (WebCore::Writer::writeNumber): (WebCore::Writer::writeImageData): (WebCore::Writer::writeArray): (WebCore::Writer::writeObject): (WebCore::Writer::writeSparseArray): (WebCore::Writer::doWriteUint32): (WebCore::Writer::doWriteNumber): (WebCore::Writer::append): (WebCore::Writer::fillHole): (WebCore::Writer::byteAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::writeArray): (WebCore::Serializer::writeObject): (WebCore::Serializer::writeSparseArray): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::ErrorState::ErrorState): (WebCore::Serializer::ErrorState::advance): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::State): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::objectDone): (WebCore::Serializer::SparseArrayState::SparseArrayState): (WebCore::Serializer::SparseArrayState::objectDone): (WebCore::Serializer::push): (WebCore::Serializer::pop): (WebCore::Serializer::handleError): (WebCore::Serializer::checkComposite): (WebCore::Serializer::writeString): (WebCore::Serializer::writeImageData): (WebCore::Serializer::newArrayState): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::Reader::Reader): (WebCore::Reader::read): (WebCore::Reader::readString): (WebCore::Reader::readUint32): (WebCore::Reader::readDate): (WebCore::Reader::readNumber): (WebCore::Reader::readImageData): (WebCore::Reader::doReadUint32): (WebCore::Reader::doReadNumber): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::createArray): (WebCore::Deserializer::createObject): (WebCore::Deserializer::createSparseArray): (WebCore::Deserializer::initializeObject): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::stackDepth): (WebCore::SerializedScriptValue::deserialize):
06:29 QtWebKitTriageRoster edited by koshuin@gmail.com
(diff)
06:19 Changeset [57144] by eric@webkit.org

2010-04-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add current user-agent string for Symbian for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=37131

  • QtLauncher/useragentlist.txt:
05:53 QtWebKitTriageRoster edited by benjamin.poulain@nokia.com
(diff)
05:50 QtWebKitTriageRoster edited by antti.j.koivisto@nokia.com
(diff)
05:46 QtWebKitTriageRoster edited by kenneth@webkit.org
(diff)
05:35 QtWebKitTriageRoster edited by hausmann@webkit.org
(diff)
05:31 QtWebKitTriageRoster created by hausmann@webkit.org
05:26 Changeset [57143] by pfeldman@chromium.org

2010-04-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rebaselining Chromium layout test expectations.

  • platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
  • platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Added.
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium/test_expectations.txt:
05:26 QtWebKitBugs edited by hausmann@webkit.org
(diff)
05:25 QtWebKitBugs edited by hausmann@webkit.org
(diff)
05:25 QtWebKitBugs edited by hausmann@webkit.org
(diff)
04:54 Changeset [57142] by eric@webkit.org

2010-04-06 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Eric Seidel.

[Qt] LayoutTests/fast/canvas/canvas-text-alignment.html skipped on Qt
https://bugs.webkit.org/show_bug.cgi?id=36058

fast/canvas/canvas-text-alignment.html passes, so it can be unskipped.
Compared to png file and Mac expected file.

  • platform/qt/Skipped: fast/canvas/canvas-text-alignment.html unskipped.
  • platform/qt/fast/canvas/canvas-text-alignment-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/qt/fast/canvas/canvas-text-alignment-expected.txt: Added.
03:47 Changeset [57141] by ossy@webkit.org

Unreviewed buildfix for --minimal build.
Buildfix after r57134. Add ENABLE(WORKERS) guard.

original bug: https://bugs.webkit.org/show_bug.cgi?id=36375

  • bindings/js/JSWorkerContextErrorHandler.cpp:
03:37 Changeset [57140] by krit@webkit.org

2010-04-06 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

SVG/SMIL parse failure on attribute keySplines
https://bugs.webkit.org/show_bug.cgi?id=37071

Test: svg/animations/animate-keySplines.html

The String in 'keySplines' can have multiple spaces between numbers
and delimiters. The parsing code is inspired by SVGParserUtilities
and respects this.

  • svg/SVGAnimationElement.cpp: (WebCore::parseKeySplines):

2010-04-06 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

SVG/SMIL parse failure on attribute keySplines
https://bugs.webkit.org/show_bug.cgi?id=37071

Test correct parsing of keySplines.

  • svg/animations/animate-keySplines-expected.txt: Added.
  • svg/animations/animate-keySplines.html: Added.
  • svg/animations/script-tests/animate-keySplines.js: Added. (sample1): (sample2): (sample3): (executeTest):
03:34 Changeset [57139] by pfeldman@chromium.org

2010-04-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: more updates to test expectations for Chromium roll.

  • platform/chromium/test_expectations.txt:
03:14 Changeset [57138] by eric@webkit.org

2010-04-06 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Fixed logging of unhndled worker exceptions.
https://bugs.webkit.org/show_bug.cgi?id=37143

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
02:59 Changeset [57137] by eric@webkit.org

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Explain how to handle rollout patches
https://bugs.webkit.org/show_bug.cgi?id=37139

We need to set expectations for how long landing rollout patches with
the commit-queue takes. The commit-queue is optimized for safety, not
performance. Also, give folks an alternative way to land patches
quickly.

In addition, improve our testing of add_patch_to_bug by having
MockBugzilla log. This caused me to tighten a bunch of tests and
notice that one of our tests wasn't being run.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
02:58 Changeset [57136] by pfeldman@chromium.org

2010-04-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: more updates to test expectations for Chromium roll.

  • platform/chromium/test_expectations.txt:
02:07 Changeset [57135] by pfeldman@chromium.org

2010-04-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: updated test expectations for Chromium roll.

  • platform/chromium/test_expectations.txt:
01:46 Changeset [57134] by yurys@chromium.org

2010-04-06 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Refactored error reporting mechanizm on Worker Global Objects.
Unlike other event listeners which accept single argument(Event)
onerror handler on worker global object should be a function
accepting three arguments. This error reporting was implementedas
EventListener::reportError method which had custom implementations
for v8 and JSC. This patch removes EventListener::reportError and
moves its functionality into custom bindings(V8WorkerContextErrorHandler
and JSWorkerContextErrorHandler) that implement EventListener inerface
for the onerror handler.

This patch also makes uncaught exceptions that happen in the onerror
listener be reported to the Worker's onerror handler.

https://bugs.webkit.org/show_bug.cgi?id=36375

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventListener.h:
  • bindings/js/JSWorkerContextErrorHandler.cpp: Added. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
  • bindings/js/JSWorkerContextErrorHandler.h: Added. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8WorkerContextErrorHandler.cpp: Added. (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler): (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
  • bindings/v8/V8WorkerContextErrorHandler.h: Added. (WebCore::V8WorkerContextErrorHandler::create):
  • bindings/v8/V8WorkerContextEventListener.cpp:
  • bindings/v8/V8WorkerContextEventListener.h:
  • dom/EventListener.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException):
  • workers/WorkerContext.h:

2010-04-06 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that exception which occurs in onerror handler is reported to the Worker object.

https://bugs.webkit.org/show_bug.cgi?id=36375

  • fast/workers/worker-script-error-expected.txt:
  • fast/workers/worker-script-error.html:
01:12 Changeset [57133] by pfeldman@chromium.org

2010-04-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: reverting v8 change at r57079 for crashing Chromium layout tests.

00:27 Changeset [57132] by abarth@webkit.org

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Turns out commit_info.committer() can be None
https://bugs.webkit.org/show_bug.cgi?id=37106

When the committer isn't in committers.py, the committer() property on
commit_info can be None. We need to handle that case gracefully.

  • Scripts/webkitpy/common/checkout/commitinfo.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/queries.py:
00:09 Changeset [57131] by eric@webkit.org

2010-04-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] Build fix for Dumprendertree if Qt printing is not supported
https://bugs.webkit.org/show_bug.cgi?id=37082

Use the QT_NO_PRINTER guard to flag QPrinter dependent code.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dryRunPrint):

04/05/10:

23:59 Changeset [57130] by eric@webkit.org

2010-04-05 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

RenderProgress.cpp is missing CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=37080

No new tests. just fixed compilation error.

  • rendering/RenderProgress.cpp:
23:48 Changeset [57129] by eric@webkit.org

2010-04-05 Peter Nelson <charn.opcode@gmail.com>

Reviewed by Eric Seidel.

Fixed style errors in DOMCoreClasses.h to bring it up to scratch
for https://bugs.webkit.org/show_bug.cgi?id=34979.

  • DOMCoreClasses.h: (DOMObject::throwException): (DOMObject::callWebScriptMethod): (DOMObject::evaluateWebScript): (DOMObject::removeWebScriptKey): (DOMObject::stringRepresentation): (DOMObject::webScriptValueAtIndex): (DOMObject::setWebScriptValueAtIndex): (DOMObject::setException): (DOMNodeList::throwException): (DOMNodeList::callWebScriptMethod): (DOMNodeList::evaluateWebScript): (DOMNodeList::removeWebScriptKey): (DOMNodeList::stringRepresentation): (DOMNodeList::webScriptValueAtIndex): (DOMNodeList::setWebScriptValueAtIndex): (DOMNodeList::setException): (DOMDocument::throwException): (DOMDocument::callWebScriptMethod): (DOMDocument::evaluateWebScript): (DOMDocument::removeWebScriptKey): (DOMDocument::stringRepresentation): (DOMDocument::webScriptValueAtIndex): (DOMDocument::setWebScriptValueAtIndex): (DOMDocument::setException): (DOMDocument::nodeName): (DOMDocument::nodeValue): (DOMDocument::setNodeValue): (DOMDocument::nodeType): (DOMDocument::parentNode): (DOMDocument::childNodes): (DOMDocument::firstChild): (DOMDocument::lastChild): (DOMDocument::previousSibling): (DOMDocument::nextSibling): (DOMDocument::attributes): (DOMDocument::ownerDocument): (DOMDocument::insertBefore): (DOMDocument::replaceChild): (DOMDocument::removeChild): (DOMDocument::appendChild): (DOMDocument::hasChildNodes): (DOMDocument::cloneNode): (DOMDocument::isSupported): (DOMDocument::namespaceURI): (DOMDocument::prefix): (DOMDocument::setPrefix): (DOMDocument::localName): (DOMDocument::hasAttributes): (DOMDocument::isSameNode): (DOMDocument::isEqualNode): (DOMDocument::textContent): (DOMDocument::setTextContent): (DOMElement::throwException): (DOMElement::callWebScriptMethod): (DOMElement::evaluateWebScript): (DOMElement::removeWebScriptKey): (DOMElement::stringRepresentation): (DOMElement::webScriptValueAtIndex): (DOMElement::setWebScriptValueAtIndex): (DOMElement::setException): (DOMElement::nodeName): (DOMElement::nodeValue): (DOMElement::setNodeValue): (DOMElement::nodeType): (DOMElement::parentNode): (DOMElement::childNodes): (DOMElement::firstChild): (DOMElement::lastChild): (DOMElement::previousSibling): (DOMElement::nextSibling): (DOMElement::attributes): (DOMElement::ownerDocument): (DOMElement::insertBefore): (DOMElement::replaceChild): (DOMElement::removeChild): (DOMElement::appendChild): (DOMElement::hasChildNodes): (DOMElement::cloneNode): (DOMElement::isSupported): (DOMElement::namespaceURI): (DOMElement::prefix): (DOMElement::setPrefix): (DOMElement::localName): (DOMElement::hasAttributes): (DOMElement::isSameNode): (DOMElement::isEqualNode): (DOMElement::textContent): (DOMElement::setTextContent):
23:33 Changeset [57128] by eric@webkit.org

2010-04-05 Eric Uhrhane <ericu@chromium.org>

Reviewed by Brady Eidson.

window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5
https://bugs.webkit.org/show_bug.cgi?id=36671

The previous "fix" I mistakenly compared hashes, an improvement over comparing pointers, but still not right.

No new tests.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Use SecurityOrigin::equal to compare instead of SecurityOriginHash.
23:32 WebInspector edited by joepeck@webkit.org
(diff)
23:11 Changeset [57127] by eric@webkit.org

2010-04-05 Anthony Ricaud <rik@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Audits launcher view is unusable with a small height window
https://bugs.webkit.org/show_bug.cgi?id=37109

Use flex box instead of absolute positioning to avoid overlapping elements.

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/audits.css: (.audit-launcher-view .audit-launcher-view-content): (.audit-launcher-view div.button-container): (.audit-launcher-view .flexible-space):
23:08 WikiStart edited by joepeck@webkit.org
(diff)
23:01 Changeset [57126] by eric@webkit.org

2010-04-05 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - wrong spelling
https://bugs.webkit.org/show_bug.cgi?id=37110

Correcting wrong spelling in RenderThemeQt.cpp.

  • platform/qt/RenderThemeQt.cpp:
22:52 Changeset [57125] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should force_build builders that are idle and have failed exactly once
https://bugs.webkit.org/show_bug.cgi?id=37059

We can get into a deadlocked state where the commit-queue is stopped
because the builders are red but the SheriffBot hasn't taken action
because the builder has failed only once. The SheriffBot should force
build idle builders that have failed exactly once to either turn the
tree green again (if the test was flaky) or trigger the "failed twice"
remedies (IRC and bug posts).

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/mocktool.py:
22:51 Changeset [57124] by eric@webkit.org

2010-04-05 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL-specific code to platform/Platform*Event.h.
http://webkit.org/b/36309

  • platform/PlatformWheelEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformKeyboardEvent.h:
22:23 Changeset [57123] by oliver@apple.com

Another build fix

22:07 Changeset [57122] by oliver@apple.com

And another build fix.

22:00 Changeset [57121] by oliver@apple.com

Build fix

21:18 Changeset [57120] by oliver@apple.com

2010-04-05 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Support weak maps in JSC
https://bugs.webkit.org/show_bug.cgi?id=37132

Expose an API to allow creation of a map for storing
weak JS references.

  • API/JSWeakObjectMapRefInternal.h: Added. (OpaqueJSWeakObjectMap::create): (OpaqueJSWeakObjectMap::map): (OpaqueJSWeakObjectMap::~OpaqueJSWeakObjectMap): (OpaqueJSWeakObjectMap::OpaqueJSWeakObjectMap):
  • API/JSWeakObjectMapRefPrivate.cpp: Added.
  • API/JSWeakObjectMapRefPrivate.h: Added.
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::registerWeakMap): (JSC::JSGlobalObject::deregisterWeakMap):
20:59 Changeset [57119] by hamaji@chromium.org

2010-04-05 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Fixed check-webkit-style issue where the script was prematurely
exiting when encountering deleted files in patches.

https://bugs.webkit.org/show_bug.cgi?id=37122

  • Scripts/webkitpy/style/checker.py:
    • Changed non-existent file message from ERROR to WARN.
    • StyleChecker.check_file() no longer raises an exception when a file is not found.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated unit tests as necessary.
20:50 Changeset [57118] by eric@webkit.org

2010-04-05 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL-specific code to platform/graphics/*.h.
http://webkit.org/b/36308

  • platform/graphics/Icon.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/IntPoint.h:
20:33 Changeset [57117] by eric@webkit.org

2010-04-05 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Put a maximum on consecutive redirections so we don't have to
worry about whether it's the same url or not.

Tolerate up to 10 consecutive redirections, anything beyond
that is considered a potentially infinite recursion in the
redirection requests. This is the same behaviour as Firefox.

https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  • platform/network/qt/QNetworkReplyHandler.h:
20:08 Changeset [57116] by jamesr@google.com

2010-04-05 Dimitri Glazkov <dglazkov@chromium.org> and James Robinson <jamesr@chromium.org>

Reviewed by Darin Adler and Dimitri Glazkov.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864

Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html

fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html

  • dom/Document.cpp: (WebCore::Document::finishedParsing): Added updateStyleIfNeeded()

call to ensure that object loads start before firing window load.

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of

Document::updateStyleForAllDocuments

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit

recalc to ensure accuracy of representation, especially for
menuList/listBox switches.

2010-04-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864

Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.

Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
  • fast/forms/textarea-and-mutation-events.html: Added.
20:02 Changeset [57115] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should include blamelist when posting to bugs
https://bugs.webkit.org/show_bug.cgi?id=37113

When posting on bugs, we should include the full list of SVN revisions
that caused the regression to folks have a better sense of whether they
are to blame.

  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
19:32 Changeset [57114] by cjerdonek@webkit.org

Unreviewed after discussion with Adam, Darin, and Eric.

Deleted the auto-install directory since it is no longer needed in
source control (it is auto-generated).

Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's
svn:ignore property.

  • Scripts/webkitpy/thirdparty/autoinstalled: Removed.
19:24 Changeset [57113] by mrowe@apple.com

Update a test result.

  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
19:03 Changeset [57112] by tonikitoo@webkit.org

2010-04-05 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Laszlo Gombos.

Cleaned up spatial-navigation-test-cases.html by removing the wrongly
used <frameset> tag. Patch also adds a manual-test specifically to
test Spatial Navigation with framesets.

  • manual-tests/spatial-navigation/frameset.html: Added.
  • manual-tests/spatial-navigation/spatial-navigation-test-cases.html:
18:45 Changeset [57111] by mrowe@apple.com

Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI

Reviewed by Adele Peterson.

WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison
manually. This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests.

WebKitTools:

Add a JavaScript hook in DRT to call through to WebView's -setEditable:. This is required in order to reproduce
the crash.

  • DumpRenderTree/LayoutTestController.cpp:

(setWebViewEditableCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setWebViewEditable):
(LayoutTestController::layerTreeAsText):

LayoutTests:

  • platform/mac/editing/deleting/deletionUI-successful-deletion-expected.txt: Added.
  • platform/mac/editing/deleting/deletionUI-successful-deletion.html: Added.
  • platform/mac/editing/deleting/resources/deletionUI-helpers.js:

(deletionUIDeleteButtonForElement):
(determineDeletionUIExistence):

18:45 Changeset [57110] by mrowe@apple.com

Roll out r56989 as it introduced crashes in Mail.
<http://webkit.org/b/37115> / <rdar://problem/7829331>

Reviewed by Adele Peterson.

  • dom/Position.cpp:

(WebCore::Position::isCandidate):

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate):

18:38 Changeset [57109] by darin@apple.com

Images must re-load when an image-holding element moves into a new document
https://bugs.webkit.org/show_bug.cgi?id=37127

Reviewed by Sam Weinig.

WebCore:

Test: fast/images/move-image-to-new-document.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::willMoveToNewOwnerDocument): Call ImageLoader's
elementWillMoveToNewOwnerDocument function.

  • html/HTMLImageElement.h: Added willMoveToNewOwnerDocument.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLPlugInImageElement.h: Ditto.
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLVideoElement.h: Ditto.
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::willMoveToNewOwnerDocument): Ditto.

  • svg/SVGImageElement.h: Ditto.
  • html/HTMLMediaElement.h: Made willMoveToNewOwnerDocument protected

so it can be called by HTMLVideoElement.cpp.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::elementWillMoveToNewOwnerDocument): Added.
Resets the loader by clearing out the cached image.

  • loader/ImageLoader.h: Added it.

LayoutTests:

  • fast/images/move-image-to-new-document-expected.txt: Added.
  • fast/images/move-image-to-new-document.html: Added.
  • fast/images/script-tests/move-image-to-new-document.js: Added.
  • fast/js/resources/js-test-post.js: Added a feature for doing asynchronous scripting

tests. The caller sets jsTestIsAsync to true and then calls finishJSTest when done.
Used by the above test.

  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:

Updated since the old test result relied on an incorrect load of an image.
The relative URL has a different base when moved into the subframe document.

17:55 Changeset [57108] by eric@webkit.org

2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Symbian] Consolidate Symbian WINSCW environment configuration
https://bugs.webkit.org/show_bug.cgi?id=37100

Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.

PLATFORM(WIN) and OS(WIN) no longer needs to be undefined as
undefining WIN32 takes care of it.

  • wtf/Platform.h:

2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Symbian] Consolidate Symbian WINSCW environment configuration
https://bugs.webkit.org/show_bug.cgi?id=37100

Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.

No new tests as there is no new functionality.

  • config.h:
17:34 Changeset [57107] by eric@webkit.org

2010-04-05 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add missing ClipboardEfl.h to platform/efl.
http://webkit.org/b/36242

  • platform/efl/ClipboardEfl.h: Added.
17:18 Changeset [57106] by eric@webkit.org

2010-04-05 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Adler.

A few tests in fast/canvas/webgl/ failed on Leopard Release Bot randomly.
https://bugs.webkit.org/show_bug.cgi?id=37077
https://bugs.webkit.org/show_bug.cgi?id=37098

  • fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Gathering more information about framebuffer status when failure happens.
  • fast/canvas/webgl/drawArraysOutOfBounds.html: Ditto.
  • fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Ditto.
  • fast/canvas/webgl/drawElementssOutOfBounds.html: Ditto.
  • fast/canvas/webgl/index-validation-copies-indices-expected.txt: Ditto.
  • fast/canvas/webgl/index-validation-copies-indices.html: Ditto.
17:08 Changeset [57105] by eric@webkit.org

2010-04-05 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Escape control characters in CSS string value when it is serialilzed.

When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.

As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).

CSS string value is not correctly serialized when it contains binary characters
https://bugs.webkit.org/show_bug.cgi?id=28938

  • fast/css/script-tests/string-quote-binary.js: Added.
  • fast/css/string-quote-binary-expected.txt: Added.
  • fast/css/string-quote-binary.html: Added.
  • fast/js/resources/js-test-pre.js: (shouldBeEqualToString): Considering the case when the argument contains binary characters.

2010-04-05 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Escape control characters in CSS string value when it is serialilzed.

When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.

As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).

CSS string value is not correctly serialized when it contains binary characters
https://bugs.webkit.org/show_bug.cgi?id=28938

Test: fast/css/string-quote-binary.html

  • css/CSSParser.cpp: (WebCore::isCSSTokenizerIdentifier): (WebCore::isCSSTokenizerURL): (WebCore::quoteCSSString): (WebCore::quoteCSSStringIfNeeded): (WebCore::quoteCSSURLIfNeeded):
  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
  • css/FontFamilyValue.cpp: (WebCore::FontFamilyValue::cssText):
17:06 Changeset [57104] by darin@apple.com

Updated the ignore property for changes to the contents here.

  • .: Modified property svn:ignore.
16:54 Changeset [57103] by eric@webkit.org

2010-04-05 John Gregg <johnnyg@google.com>

Reviewed by Darin Adler.

Notifications should not resolve an empty icon parameter as a relative URL
https://bugs.webkit.org/show_bug.cgi?id=36862

  • fast/notifications/notifications-no-icon-expected.txt: Added.
  • fast/notifications/notifications-no-icon.html-disabled: Added.

2010-04-05 John Gregg <johnnyg@google.com>

Reviewed by Darin Adler.

Notifications should not resolve an empty icon parameter as a relative URL
https://bugs.webkit.org/show_bug.cgi?id=36862

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
16:40 Changeset [57102] by darin@apple.com

Ignore more files the Python tools strew about the working directory.

  • Scripts/webkitpy: Added property svn:ignore.
  • Scripts/webkitpy/common: Added property svn:ignore.
  • Scripts/webkitpy/common/checkout: Added property svn:ignore.
  • Scripts/webkitpy/common/config: Added property svn:ignore.
  • Scripts/webkitpy/common/net: Added property svn:ignore.
  • Scripts/webkitpy/common/thread: Added property svn:ignore.
  • Scripts/webkitpy/python24: Added property svn:ignore.
  • Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore.
  • Scripts/webkitpy/tool/bot: Added property svn:ignore.
16:19 Changeset [57101] by darin@apple.com

Removed some unneeded type casts.

Reviewed by Mark Rowe.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText): Removed an unneeded cast.

  • page/Location.cpp:

(WebCore::Location::host): Removed unneeded parentheses and cast.
(WebCore::Location::port): Ditto.

  • platform/KURLGoogle.cpp:

(WebCore::KURL::setPort): Ditto.

  • workers/WorkerLocation.cpp:

(WebCore::WorkerLocation::host): Ditto.
(WebCore::WorkerLocation::port): Ditto.

16:07 Changeset [57100] by abarth@webkit.org

2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57081.
http://trac.webkit.org/changeset/57081
https://bugs.webkit.org/show_bug.cgi?id=37121

We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip-expected.txt: Removed.
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Removed.
  • fast/forms/select-change-popup-to-listbox-roundtrip-expected.txt: Removed.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Removed.
  • fast/forms/textarea-and-mutation-events-expected.txt: Removed.
  • fast/forms/textarea-and-mutation-events.html: Removed.

2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57081.
http://trac.webkit.org/changeset/57081
https://bugs.webkit.org/show_bug.cgi?id=37121

We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
15:57 Changeset [57099] by beidson@apple.com

ASSERT close()ing the same StorageAreaImpl twice when using multiple PageGroups
<rdar://problem/7828420> and https://bugs.webkit.org/show_bug.cgi?id=37120

Reviewed by Oliver Hunt.

No new tests. (No behavior change)

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::close): Change this invalid ASSERT to an early return.

15:39 Changeset [57098] by ap@apple.com

Updated expected pixel results for missing plug-in, now using text placeholder.

  • platform/mac/plugins/qt-qwidget-plugin-expected.checksum:
  • platform/mac/plugins/qt-qwidget-plugin-expected.png:
15:03 Changeset [57097] by yael.aharon@nokia.com

Unreviewed.
Separate test results for windows platform because progress element is not implemented for that platform yet.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/win/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/win/fast/js: Added.
  • platform/win/fast/js/global-constructors-expected.txt: Added.
14:52 Changeset [57096] by abarth@webkit.org

2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57030.
http://trac.webkit.org/changeset/57030
https://bugs.webkit.org/show_bug.cgi?id=37114

Regressed fast/repaint/line-flow-with-floats-9 pixel tests in
chromium port (Requested by jamesr on #webkit).

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
14:49 Changeset [57095] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37111
<rdar://problem/7790327> Draw replacement text when plug-in host crashes

14:16 Changeset [57094] by cfleizach@apple.com

Unreviewed.

Bug 37112 - aria-liveregion-notifications.html fails on leopard release bot
https://bugs.webkit.org/show_bug.cgi?id=37112

Disabling this test on Leopard until further investigation can reveal the answer.
It looks like at this point, any new test added will cause this test to fail on Leopard
release bot, even if it has nothing to do with live regions.

  • platform/mac-leopard/Skipped:
13:41 Changeset [57093] by cfleizach@apple.com

WebCore: Bug 37040 - AX: need to send selected children change notification when aria-selected changed
https://bugs.webkit.org/show_bug.cgi?id=37040

Reviewed by Darin Adler.

When aria-selected is changed in the DOM, it will trigger a selected children change notification.

Test: platform/mac/accessibility/aria-listbox-selectedchildren-change.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::selectedChildrenChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::controlType):

Remove extra whitespace before comment (webkit-style).

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::observableObject):

Allowed a listBox to be an observable object.

(WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):

Updated and streamlined existing code.

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests: Tests for
Bug 37040 - AX: need to send selected children change notification when aria-selected changed
https://bugs.webkit.org/show_bug.cgi?id=37040

Reviewed by Darin Adler.

  • platform/mac/accessibility/aria-listbox-selectedchildren-change-expected.txt: Added.
  • platform/mac/accessibility/aria-listbox-selectedchildren-change.html: Added.
13:38 Changeset [57092] by yael.aharon@nokia.com

Unreviewed.
Separate test results for gtk platform because progress element is not implemented for that platform yet.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/gtk/fast/js: Added.
  • platform/gtk/fast/js/global-constructors-expected.txt: Added.
12:55 Changeset [57091] by ojan@chromium.org

2010-04-05 Adam Barth <abarth@webkit.org>

Unreviewed. Add Vitaly Repeshko as a committer.

  • Scripts/webkitpy/common/config/committers.py:
12:33 Changeset [57090] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Unreviewed. Add Vitaly Repeshko as a committer.

  • Scripts/webkitpy/common/config/committers.py:
12:27 Changeset [57089] by treat@webkit.org

Fix regression in pixel test for animated svg background images.

Patch by Adam Treat <atreat@rim.com> on 2010-04-05
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37027

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):

11:30 Changeset [57088] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Unreviewed. Update kenne's IRC nick to his registered nick.

  • Scripts/webkitpy/common/config/committers.py:
11:27 Changeset [57087] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Unreviewed.

Update expected results for addition of HTMLProgressElement. We didn't
see these errors until later because our dependencies are screwed up.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
11:24 Changeset [57086] by kenneth@webkit.org

Unreviewed layout test fix.

Update mac results for iframe flattening.

  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
11:16 WebKit Team edited by abarth@webkit.org
(diff)
10:57 Changeset [57085] by robert@webkit.org

2010-04-05 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde-Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Qt enters an infinite loop if a redirect response redirects to itself.

Fixes http/tests/xmlhttprequest/connection-error-sync.html

https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

2010-04-05 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde-Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Unskip http/tests/xmlhttprequest/connection-error-sync.html

https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/qt/Skipped:
10:55 Changeset [57084] by ojan@chromium.org

2010-04-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

prepare-ChangeLog should take a merge-base for which git branch to diff against.
https://bugs.webkit.org/show_bug.cgi?id=36394

  • Scripts/prepare-ChangeLog:
10:36 Changeset [57083] by kenneth@webkit.org

Unreviewed layout test fix.

Update Qt results for iframe flattening.

  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt:
10:35 Changeset [57082] by yurys@chromium.org

2010-04-05 Yury Semikhatsky <yurys@chromium.org>

Unreviewed, revert r57078.

10:27 Changeset [57081] by dglazkov@chromium.org

2010-04-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864

Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.

Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
  • fast/forms/textarea-and-mutation-events.html: Added.

2010-04-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864

Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html

fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of

Document::updateStyleForAllDocuments

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit

recalc to ensure accuracy of representation, especially for
menuList/listBox switches.

10:18 Changeset [57080] by kenneth@webkit.org

iframe flattening doesn't flatten
https://bugs.webkit.org/show_bug.cgi?id=36798

Reviewed by Dave Hyatt.

Fixed to the iframe flattening code so that the iframes on
http://www.samisite.com/test-csb2nf/id43.htm are actually
flattened.

Covered by current tests.

  • page/FrameView.cpp: Propagate contents changes of iframes

and subframes in framesets to the parent so that it is relayouted
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scheduleRelayout):

  • rendering/RenderPart.cpp: HTMLIFrameElement do not inherit from

HTMLFrameElement, but HTMLFrameElementBase, correct cast. Correct
the use of inset border values. Avoid a sometimes unnecessary
relayout.
(WebCore::RenderPart::layoutWithFlattening):

  • rendering/RenderPartObject.cpp: Make the calcHeight and calcWidth

return the right values, considering scrolling and fixed width/height
(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):

10:06 Changeset [57079] by vitalyr@chromium.org

2010-04-05 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Yury Semikhatsky.

[V8] Extend the set of types supported by SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=37052

New types include sparse arrays, Uint32, Date, and ImageData.

Serialization process became more flexible. A state can either
directly write primitive values (instead of returning them like
iterator) or construct a new state for serializing complex values
that will return to the current state when done.

Deserialization process now avoids exposing the tags using a set
of factory functions for complex objects instead.

Internal buffer type changed to uint8_t to be independent of
whether char is signed or not.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::Writer): (WebCore::Writer::writeString): (WebCore::Writer::writeUint32): (WebCore::Writer::writeDate): (WebCore::Writer::writeNumber): (WebCore::Writer::writeImageData): (WebCore::Writer::writeArray): (WebCore::Writer::writeObject): (WebCore::Writer::writeSparseArray): (WebCore::Writer::doWriteUint32): (WebCore::Writer::doWriteNumber): (WebCore::Writer::append): (WebCore::Writer::fillHole): (WebCore::Writer::byteAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::writeArray): (WebCore::Serializer::writeObject): (WebCore::Serializer::writeSparseArray): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::ErrorState::ErrorState): (WebCore::Serializer::ErrorState::advance): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::State): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::objectDone): (WebCore::Serializer::SparseArrayState::SparseArrayState): (WebCore::Serializer::SparseArrayState::objectDone): (WebCore::Serializer::push): (WebCore::Serializer::pop): (WebCore::Serializer::handleError): (WebCore::Serializer::checkComposite): (WebCore::Serializer::writeString): (WebCore::Serializer::writeImageData): (WebCore::Serializer::newArrayState): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::Reader::Reader): (WebCore::Reader::read): (WebCore::Reader::readString): (WebCore::Reader::readUint32): (WebCore::Reader::readDate): (WebCore::Reader::readNumber): (WebCore::Reader::readImageData): (WebCore::Reader::doReadUint32): (WebCore::Reader::doReadNumber): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::createArray): (WebCore::Deserializer::createObject): (WebCore::Deserializer::createSparseArray): (WebCore::Deserializer::initializeObject): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::stackDepth): (WebCore::SerializedScriptValue::deserialize):
10:00 Changeset [57078] by yurys@chromium.org

2010-04-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Refactored error reporting mechanizm on Worker Global Objects.
Unlike other event listeners which accept single argument(Event)
onerror handler on worker global object should be a function
accepting three arguments. This error reporting was implementedas
EventListener::reportError method which had custom implementations
for v8 and JSC. This patch removes EventListener::reportError and
moves its functionality into custom bindings(V8WorkerContextErrorHandler
and JSWorkerContextErrorHandler) that implement EventListener inerface
for the onerror handler.

This patch also makes uncaught exceptions that happen in the onerror
listener be reported to the Worker's onerror handler.

https://bugs.webkit.org/show_bug.cgi?id=36375

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventListener.h:
  • bindings/js/JSWorkerContextErrorHandler.cpp: Added. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
  • bindings/js/JSWorkerContextErrorHandler.h: Added. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8WorkerContextErrorHandler.cpp: Added. (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler): (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
  • bindings/v8/V8WorkerContextErrorHandler.h: Added. (WebCore::V8WorkerContextErrorHandler::create):
  • bindings/v8/V8WorkerContextEventListener.cpp:
  • bindings/v8/V8WorkerContextEventListener.h:
  • dom/EventListener.h: Removed reportError method that was used only for reporting worker errors.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException):

2010-04-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that exception which occurs in onerror handler is reported to the Worker object.

https://bugs.webkit.org/show_bug.cgi?id=36375

  • fast/workers/worker-script-error-expected.txt:
  • fast/workers/worker-script-error.html:
  • workers/WorkerContext.h:
08:53 Changeset [57077] by tonikitoo@webkit.org

Fix some "explicit braces to avoid ambiguous 'else'" warnings
https://bugs.webkit.org/show_bug.cgi?id=37088

Reviewed by Darin Adler.
Patch by Antonio Gomes (tonikitoo@webkit.org)

  • dom/Node.cpp:

(WebCore::Node::dispatchGenericEvent):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchEvent):

07:28 Changeset [57076] by laszlo.1.gombos@nokia.com

2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Consolidate the definition of SKIP_STATIC_CONSTRUCTORS_ON_GCC

Instead of defining and undefining it later, let's not
define SKIP_STATIC_CONSTRUCTORS_ON_GCC for WINSCW.

No new tests as there is no new functionality.

  • config.h:
07:12 Changeset [57075] by robert@webkit.org

2010-04-05 Robert Hogan <robert@webkit.org>

Rubber-stamped by Kenneth-Rohde Christiansen.

re-login.html and re-login-async.html are now tracked in bugzilla.

https://bugs.webkit.org/show_bug.cgi?id=37084

  • platform/qt/Skipped:
06:47 Changeset [57074] by eric@webkit.org

2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] Remove obsolete build flags for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37083

Symbian port of QtWebKit port does not use icu, so it does
not need U_HAVE_* defines.

Symbian now has inttypes.h as part of OpenC.

stdio.h, limits.h and MathExtras.h are already included in
more appropriate locations.

No new tests as there is no new functionality.

  • config.h:
05:48 Changeset [57073] by pfeldman@chromium.org

2010-04-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium build fix.

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platformCallback): (WebCore::V8InspectorFrontendHost::portCallback):
05:48 Changeset [57072] by kov@webkit.org

2010-04-05 Lucas Lommer <llommer@svn.gnome.org>

Reviewed by Gustavo Noronha.

Czech translation for WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=36879

  • cs.po: Added.
05:44 Changeset [57071] by kov@webkit.org

2010-04-05 Christian Kirbach <Christian.Kirbach@googlemail.com>

Reviewed by Gustavo Noronha.

Updated German translation
https://bugs.webkit.org/show_bug.cgi?id=36453

  • de.po:
05:38 Changeset [57070] by kov@webkit.org

2010-04-05 Luca Ferretti <elle.uca@libero.it>

Reviewed by Gustavo Noronha.

Italian translation for 1.1.90
https://bugs.webkit.org/show_bug.cgi?id=36323

  • it.po:
05:37 Changeset [57069] by pfeldman@chromium.org

2010-04-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] platform detection in Chromium
has regressed to unknown.

https://bugs.webkit.org/show_bug.cgi?id=37081

  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::platform): (WebCore::JSInspectorFrontendHost::port):
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platform): (WebCore::V8InspectorFrontendHost::port):
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
04:59 Changeset [57068] by eric@webkit.org

2010-04-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Remove logging of successful XHR and worker's importScript()
to inspector console
https://bugs.webkit.org/show_bug.cgi?id=37078

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::importScripts):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::V8WorkerContext::importScriptsCallback):
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::importScripts):
  • workers/DedicatedWorkerContext.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • workers/WorkerContext.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
02:27 Changeset [57067] by pfeldman@chromium.org

2010-04-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium test expectations update for the roll.

  • platform/chromium/test_expectations.txt:
00:41 Changeset [57066] by eric@webkit.org

2010-04-05 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Removed the PatchStyleErrorHandler class and incorporated its
functionality into the DefaultStyleErrorHandler class.

https://bugs.webkit.org/show_bug.cgi?id=37067

  • Scripts/webkitpy/style/checker.py:
    • In the StyleChecker class:
      • Added a line_number parameter to the check_file() method.
      • Renamed the handle_style_error parameter to mock_handle_style_error to be consistent with the other mock_* parameter names.
      • Added a mock_check_file parameter to the check_patch() method to facilitate unit testing the changes in this patch.
      • Rewrote the check_patch() method with the patch-parsing logic taken from the PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added a StyleCheckerCheckFileBase class and sub-classed the existing StyleCheckerCheckFileTest class from it.
    • Added a StyleCheckerCheckPatchTest class to unit-test the rewritten check_patch() method.
    • Removed the vestigial main code at the bottom of the file. This is left over from when check-webkit-style was implemented as a module and a wrapper module.
  • Scripts/webkitpy/style/error_handlers.py:
    • Added an optional line_numbers parameter to the DefaultStyleErrorHandler class constructor and adjusted the call() method as necessary.
    • Removed the PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Removed the PatchStyleErrorHandlerTest class which unit-tested the PatchStyleErrorHandler class which is being removed in this patch.
    • Added a test_line_numbers() test method to the DefaultStyleErrorHandlerTest class to test use of the DefaultStyleErrorHandler's new line_numbers attribute.
00:24 Changeset [57065] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Unreviewed.

Tighten SheriffBot's flaky test detector
https://bugs.webkit.org/show_bug.cgi?id=37063

Instead of just looking for two sequential red builds, look for two
sequential failures of the same test. This should reduce sheriffbot
false positive substantially.

I'm landing this change unreviewed because I've noticed SheriffBot
triggering a lot more false positives now that we've expanded the set
of core builders. I've tried to take Eric's comments on Bug 37063 into
account. I'm happy to iterate on this patch tomorrow once Eric wakes
up.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/tool/commands/queries.py:

04/04/10:

23:30 Changeset [57064] by pfeldman@chromium.org

2010-04-04 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out chromium changes r57028 and r57032
for breaking chromium layout tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/DragImageChromium.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageChromiumMac.cpp: Removed.
  • platform/chromium/DragImageChromiumSkia.cpp: Removed.
  • platform/chromium/DragImageRef.h:


WebKit/chromium:

  • public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
  • src/WebViewImpl.h:
19:28 Changeset [57063] by johnnyg@google.com

2010-04-04 John Gregg <johnnyg@google.com>

Unreviewed, add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
19:11 Changeset [57062] by tonikitoo@webkit.org

Unreviewed expected results fix.
Patch by Antonio Gomes <tonikitoo@webkit.org>

The implementation was fixed, and results were no longer valid.

  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
19:10 Changeset [57061] by tonikitoo@webkit.org

2010-03-29 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Spatial Navigation: Initial code simplification in FocusController.cpp and SpatialNavigation.cpp

WebCore::distanceInDirection method was handling much of the logic not
strictly only related to the distance between nodes acquisition. This
method was simplified and renamed to 'WebCore::distanceDataForNode'.
The latter is now responsible for only getting the distance and alignment
data, while all assignement logic previously in distanceInDirection method
was moved place to updateFocusCandidateIfCloser.

Parent document distance and alignment acquisitions, in turn, have also
changed location: they are both got from deepFindFocusableNodeInDirection,
and passed in a recursive call to findFocusableNodeInDirection via the
candidateParent variable (optional parameter). In addition, the need for
the 'focusCandidateCopy' variable in deepFindFocusableNodeInDirection method
was removed, making the code much cleaner.

No behaviour change at this point. Mostly moving code around to the place
where it should live in.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally): (WebCore::updateFocusCandidateIfCloser): (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
  • page/FocusController.h:
  • page/SpatialNavigation.cpp: (WebCore::distanceDataForNode): (WebCore::renderRectRelativeToRootDocument):
  • page/SpatialNavigation.
15:18 Changeset [57060] by eric@webkit.org

2010-04-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: In the inherited styles, do not render non-inherited properties as overriden.

https://bugs.webkit.org/show_bug.cgi?id=37072

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
15:00 Changeset [57059] by pfeldman@chromium.org

2010-04-04 Pavel Feldman <pfeldman@chromium.org>

(Not reviewed).

Adding images for inspector blog post. Previewed by Timothy Hatcher.

  • blog-files/inspector/audits_launcher.png: Added.
  • blog-files/inspector/audits_panel.png: Added.
  • blog-files/inspector/console_panel.png: Added.
  • blog-files/inspector/context_menu.png: Added.
  • blog-files/inspector/css_highlighted_line.png: Added.
  • blog-files/inspector/css_line_number_snippet.png: Added.
  • blog-files/inspector/css_line_numbers.png: Added.
  • blog-files/inspector/deactivate_breakpoints.png: Added.
  • blog-files/inspector/evaluate_on_hover.png: Added.
  • blog-files/inspector/evaluate_on_hover_2.png: Added.
  • blog-files/inspector/inherited_styles.png: Added.
  • blog-files/inspector/large_dom.png: Added.
  • blog-files/inspector/large_resources.png: Added.
  • blog-files/inspector/pseudo_elements.png: Added.
  • blog-files/inspector/redirect_headers.png: Added.
  • blog-files/inspector/redirect_headers_full.png: Added.
  • blog-files/inspector/redirects.png: Added.
  • blog-files/inspector/redirects_full.png: Added.
  • blog-files/inspector/timeline_overview.png: Added.
  • blog-files/inspector/timeline_panel.png: Added.
  • blog-files/inspector/timeline_record_details.png: Added.
04:52 Changeset [57058] by robert@webkit.org

2010-04-04 Robert Hogan <robert@webkit.org>

Unreviewed, add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
01:53 Changeset [57057] by dumi@chromium.org

Unreviewed, adding my IRC nickname to committers.py

  • Scripts/webkitpy/common/config/committers.py:
01:26 Changeset [57056] by cjerdonek@webkit.org

2010-04-04 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style's option-parsing code.

https://bugs.webkit.org/show_bug.cgi?id=37064

  • Scripts/check-webkit-style:
    • Moved the "WebKit checkout not found" check from ArgumentParser.parse() to the calling code.
    • Moved the --git-commit argument validation from the calling code to ArgumentParser.parse().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated a unit test as necessary.
  • Scripts/webkitpy/style/optparser.py:
    • Renamed ArgumentParser._exit_with_help() to _parse_error() and made its error_message parameter required.
    • Removed the found_checkout parameter from ArgumentParser.parse().
    • Removed the "WebKit checkout not found" check and moved it to the calling code.
    • Added --git-commit argument checking.
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Adjusted the import statements to be fully qualified.
    • Changed the ArgumentParserTest class to inherit from LoggingTestCase, and updated the class as necessary.
    • Added a unit-test for the --git-commit validation.
    • Added unit tests for the --git-diff and --git-since variants of --git-commit.

04/03/10:

23:53 Changeset [57055] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=37068
Change UString to use a 0 rep for null strings instead of a null object.

Reviewed by Oliver Hunt.

No performance impact.

(JSC::InternalFunction::InternalFunction):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):

  • runtime/UString.cpp:

(JSC::initializeUString):

  • runtime/UString.h:

(JSC::UString::UString):
(JSC::UString::data):
(JSC::UString::size):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::cost):

18:53 PythonGuidelines edited by cjerdonek@webkit.org
Added another reason for the from/import ordering suggestion. (diff)
18:17 Changeset [57054] by eric@webkit.org

2010-04-03 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Fix uninitalised members in CallLinkInfo and BytecodeGenerator.

https://bugs.webkit.org/show_bug.cgi?id=36816

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock):
  • bytecode/CodeBlock.h: (JSC::CallLinkInfo::CallLinkInfo):
13:28 PythonGuidelines edited by cjerdonek@webkit.org
Moved the PEP8 remark to the style section. (diff)
13:20 PythonGuidelines edited by cjerdonek@webkit.org
Fixed typo. (diff)
13:19 PythonGuidelines edited by cjerdonek@webkit.org
Added a style section. (diff)
13:01 WikiStart edited by cjerdonek@webkit.org
Retitled link to Python page (diff)
11:59 Changeset [57053] by jwieczorek@webkit.org

2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org>

Unreviewed.

[Qt] Skip five XMLHttpRequest tests that are timing out.

  • platform/qt/Skipped: Add a comment on why they are failing.
10:40 Changeset [57052] by jwieczorek@webkit.org

2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org>

Rubber-stamped by Daniel Bates.

Fix the fast/events/popup-allowed-from-gesture-initiated-event.html test
failure on the Qt and GTK+ ports.

Refactor it to not hardcode any metrics (in order to dispatch mouse events)
but instead calculate them from the offset* properties.

  • fast/events/popup-allowed-from-gesture-initiated-event.html:
10:40 WikiStart edited by abarth@webkit.org
(diff)
10:38 Keeping the Tree Green edited by abarth@webkit.org
(diff)
10:35 Keeping the Tree Green edited by abarth@webkit.org
(diff)
10:34 Keeping the Tree Green edited by abarth@webkit.org
(diff)
10:34 Keeping the Tree Green created by abarth@webkit.org
10:27 Changeset [57051] by eric@webkit.org

2010-04-03 yael aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Enable HTMLProgressElement for Safari on OSX
https://bugs.webkit.org/show_bug.cgi?id=36961

  • Configurations/FeatureDefines.xcconfig:

2010-04-03 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
https://bugs.webkit.org/show_bug.cgi?id=36574

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

  • fast/canvas/webgl/null-uniform-location-expected.txt: Added.
  • fast/canvas/webgl/null-uniform-location.html: Added.
  • fast/canvas/webgl/script-tests/null-uniform-location.js: Added. (callUniformFunction):
  • fast/canvas/webgl/uniform-location-expected.txt:

2010-04-03 yael aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Enable HTMLProgressElement for Safari on OSX
https://bugs.webkit.org/show_bug.cgi?id=36961

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeMac::animationDurationForProgressBar): (WebCore::RenderThemeMac::adjustProgressBarStyle): (WebCore::RenderThemeMac::paintProgressBar):

2010-04-03 yael aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Enable HTMLProgressElement for Safari on OSX
https://bugs.webkit.org/show_bug.cgi?id=36961

  • Configurations/FeatureDefines.xcconfig:
07:34 Changeset [57050] by jwieczorek@webkit.org

2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org>

Unreviewed.

Fix debug build with GCC >= 4.3.

  • platform/graphics/GraphicsLayer.cpp: Include stdio.h explicitly.
00:49 Changeset [57049] by eric@webkit.org

2010-04-03 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
https://bugs.webkit.org/show_bug.cgi?id=36574

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

  • fast/canvas/webgl/null-uniform-location-expected.txt: Added.
  • fast/canvas/webgl/null-uniform-location.html: Added.
  • fast/canvas/webgl/script-tests/null-uniform-location.js: Added. (callUniformFunction):
  • fast/canvas/webgl/uniform-location-expected.txt:

2010-04-03 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
https://bugs.webkit.org/show_bug.cgi?id=36574

Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
points causing them to throw exceptions rather than synthesize GL
errors. Fixed the implementations to synthesize INVALID_VALUE
rather than INVALID_OPERATION to comply to the WebGL spec. Updated
uniform-location-expected.txt to incorporate the correct error.
Tested in Safari and Chromium.

Test: fast/canvas/webgl/null-uniform-location.html

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::V8WebGLRenderingContext::getUniformCallback): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv):
00:46 Changeset [57048] by cjerdonek@webkit.org

The check-webkit-style script now logs an ERROR and exits when
encountering a file path that does not exist. Previously, it failed
silently on such paths.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=36957

  • Scripts/webkitpy/common/system/logtesting.py:
    • Added a FIXME to rename the LoggingTestCase class to LoggingTestCaseBase.
  • Scripts/webkitpy/style/checker.py:
    • In the StyleChecker.check_file() method:
      • Added a mock_os_path_exists parameter.
      • Renamed the process_file parameter to mock_process_file.
      • Added logic to log an error and exist if the given path does not exist.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Refactored the StyleCheckerCheckFileTest class slightly to inherit from LoggingTestCase.
    • Added a test method to unit-test the case of a file that does not exist.
    • Adjusted the other test methods as necessary.
00:34 Changeset [57047] by abarth@webkit.org

2010-04-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red)
https://bugs.webkit.org/show_bug.cgi?id=33289

Add Tiger and SnowLeopard Tests to the core builders. This is a bit of
an experiment now that the bots are green. Hopefully we can keep them
on the list and have the tree stay greener.

  • Scripts/webkitpy/common/net/buildbot.py:
00:12 Changeset [57046] by darin@chromium.org

2010-04-03 Darin Fisher <darin@chromium.org>

Add default implementations of WebNotificationPresenter methods to
repair the downstream Chromium build.

  • public/WebNotificationPresenter.h: (WebKit::WebNotificationPresenter::show): (WebKit::WebNotificationPresenter::cancel): (WebKit::WebNotificationPresenter::objectDestroyed): (WebKit::WebNotificationPresenter::checkPermission): (WebKit::WebNotificationPresenter::requestPermission):
00:05 Changeset [57045] by abarth@webkit.org

2010-04-02 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

Tests for https://bugs.webkit.org/show_bug.cgi?id=37008.

  • fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
  • fast/events/popup-allowed-from-gesture-initiated-event.html: Added.
  • fast/events/popup-blocked-from-fake-button-click-expected.txt: Added.
  • fast/events/popup-blocked-from-fake-button-click.html: Added.
  • fast/events/popup-blocked-from-fake-focus-expected.txt: Added.
  • fast/events/popup-blocked-from-fake-focus.html: Added.

2010-04-02 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

The previous mechanism for testing whether an event was due to a user
gesture only checked the event type, not the source of the event. This
allowed scripts to defeat popup blocking by programatically emitting
certain types of events.

Change the user gesture detection to check for a flag that is only set
when the event in question was generated through the platform and not
through the DOM.

https://bugs.webkit.org/show_bug.cgi?id=37008

Tests: fast/events/popup-allowed-from-gesture-initiated-event.html

fast/events/popup-blocked-from-fake-button-click.html
fast/events/popup-blocked-from-fake-focus.html

  • Android.mk: Add UserGestureIndicator.{cpp, h}.
  • GNUmakefile.am: Same.
  • WebCore.gypi: Same.
  • WebCore.pro: Same.
  • WebCore.vcproj/WebCore.vcproj: Same.
  • WebCore.xcodeproj/project.pbxproj: Same.
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): Check the value of UserGesureIndicator::processingUserGesture().
  • dom/Document.cpp: (WebCore::Document::createEvent): Remove call to Event::setCreatedByDOM().
  • dom/Event.cpp: (WebCore::Event::Event): Remove initializers for m_createdByDOM. (WebCore::Event::fromUserGesture): Check the value of UserGestureIndicator::processingUserGesture().
  • dom/Event.h: Remove m_createdByDOM.
  • dom/UserGestureIndicator.cpp: Added. (WebCore::UserGestureIndicator::UserGestureIndicator): Save the previous value of s_processingUserGesture before setting it to true. (WebCore::UserGestureIndicator::~UserGestureIndicator): Restore s_processingUserGesture to its previous value.
  • dom/UserGestureIndicator.h: Added. (WebCore::UserGestureIndicator::processingUserGesture): Return the value of s_processingUserGesture.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Instantiate a UserGestureIndicator object on the stack to indicate a user gesture is being processed. (WebCore::EventHandler::handleMouseDoubleClickEvent): Same. (WebCore::EventHandler::handleMouseReleaseEvent): Same. (WebCore::EventHandler::keyEvent): Same. (WebCore::EventHandler::handleTouchEvent): Same.

04/02/10:

23:15 Changeset [57044] by abarth@webkit.org

2010-04-02 Adam Barth <abarth@webkit.org>

Unreviewed.

REGRESSION(56394): http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html fails on Tiger
https://bugs.webkit.org/show_bug.cgi?id=36934

Attempt Alexey's solution of using a non-sniffable MIME type.

  • http/tests/xmlhttprequest/resources/download-with-delay.php:
22:49 Changeset [57043] by abarth@webkit.org

2010-04-02 Adam Barth <abarth@webkit.org>

Unreviewed. Disabled fast/workers/worker-terminate.html because it
randomly fails about 25% of the time.

https://bugs.webkit.org/show_bug.cgi?id=36646

  • platform/mac/Skipped:
21:48 Changeset [57042] by darin@chromium.org

2010-04-02 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36647
Make replacestate-in-frame.html less insane and hopefully no longer flaky.

  • fast/loader/stateobjects/replacestate-in-iframe-expected.txt:
  • fast/loader/stateobjects/replacestate-in-iframe.html:
  • fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html: Added.
  • fast/loader/stateobjects/resources/replacestate-in-iframe-window.html: Added.
21:20 Changeset [57041] by abarth@webkit.org

2010-04-02 Justin Schuh <jschuh@chromium.org>

Reviewed by Alexey Proskuryakov.

XHR allows arbitrary XSRF across domains
https://bugs.webkit.org/show_bug.cgi?id=36843

Added a one-line change to prevent bypassing the XDC check on
synchronous preflighted requests. Added layout tests to cover
variations of this problem.

  • http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-header-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-method-denied-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-preflight-denied-xsrf.php: Added.

2010-04-02 Justin Schuh <jschuh@chromium.org>

Reviewed by Alexey Proskuryakov.

XHR allows arbitrary XSRF across domains
https://bugs.webkit.org/show_bug.cgi?id=36843

Added a one-line change to prevent bypassing the XDC check on
synchronous preflighted requests. Added layout tests to cover
variations of this problem.

Tests: http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html

http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html
http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::preflightFailure):
21:09 Changeset [57040] by abarth@webkit.org

2010-04-02 Adam Barth <abarth@webkit.org>

Unreviewed.

Have Eric and Adam watch the SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=37054

  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
18:05 Changeset [57039] by simon.fraser@apple.com

2010-04-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Very bad scrolling-performance with the Trackpad at http://www.apple.com/ipad/app-store/
https://bugs.webkit.org/show_bug.cgi?id=36978

When we update compositing layers (which can happen on scrolling, when there are fixed position elements
on the page), we can end up redundantly setting images as layer contents if we have to color-correct
the image. This is because we call CGImageCreateCopyWithColorSpace(), which hands back a new image
every time.

Avoid this by storing a reference to the original uncorrected image, which is used to then
avoid work if the image does not change.

  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToImage):
18:03 Changeset [57038] by eric@webkit.org

2010-04-02 Nayan Kumar K <nayankk@gmail.com>

Reviewed by Eric Seidel.

Fix for WML enabled build failure.

https://bugs.webkit.org/show_bug.cgi?id=36648

  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::disabled):
  • wml/WMLOptionElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::listBoxSelectItem):
  • wml/WMLSelectElement.h:
17:38 Changeset [57037] by eric@webkit.org

2010-04-02 MORITA Hajime <morrita@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=37011
Position::primaryDirection() should not use its own accessor.

No new tests. This is small clenaup with no behaviour change.

  • dom/Position.cpp: (WebCore::Position::primaryDirection):
17:16 Changeset [57036] by eric@webkit.org

2010-04-02 Eric Uhrhane <ericu@chromium.org>

Reviewed by Brady Eidson.

window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5. This is caused by a SecurityOrigin pointer comparison that I should have switched to be a hash comparison in r56293 [bug 34991].
https://bugs.webkit.org/show_bug.cgi?id=36671

No new tests. Requires testing on Safari on Windows.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Convert a pointer comparison to use SecurityOriginHash::hash() instead, and move it to the end of the clause for speed in the easy-out case.
17:14 Changeset [57035] by abarth@webkit.org

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

commit-queue should ignore builders when landing rollouts
https://bugs.webkit.org/show_bug.cgi?id=37051

When we moved the "builders are red" check into the master process, we
forgot about rollouts. I thought we had a test covering this case, but
looking at the test, it was a bit too loose. I added a new test and
introduced some new logging technology into MockTool to make the test
tighter.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
17:06 Changeset [57034] by eric@webkit.org

2010-04-02 Michael Nordman <michaeln@google.com>

Reviewed by Nate Chapin.

Set the close policy used by the DatabaseCloseTask in a constructor argument
instead of hard coding it.
https://bugs.webkit.org/show_bug.cgi?id=37037

No new tests, new new functionality.

  • storage/Database.cpp: This callsite passes in DoNotRemoveFromDatabaseContext to retain its current behavior. (WebCore::Database::markAsDeletedAndClose):
  • storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::DatabaseCloseTask): (WebCore::DatabaseCloseTask::doPerformTask):
  • storage/DatabaseTask.h: (WebCore::DatabaseCloseTask::create):

2010-04-02 Michael Nordman <michaeln@google.com>

Reviewed by Nate Chapin.

Set the close policy used by the DatabaseCloseTask at this callsite to
RemoveDatabaseFromContext. This restores its behavior to what it was prior to
r56293.
https://bugs.webkit.org/show_bug.cgi?id=37037

  • src/WebDatabase.cpp: (WebKit::WebDatabase::closeDatabaseImmediately):
16:52 Changeset [57033] by jamesr@google.com

2010-04-02 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Remove an ASSERT that sometimes flakes due to time dependent animations
https://bugs.webkit.org/show_bug.cgi?id=37048

The outline repaint rectangle for a layer might change between two calls
if there are animations involved, even if nothing in the DOM has actually
changed between the calls.

No change in behavior, no new tests.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
16:45 Changeset [57032] by abarth@webkit.org

2010-04-02 Evan Stade <estade@chromium.org>

Reviewed by Adam Barth.

[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811

Add two files that failed to get added in my previous patch.

  • platform/chromium/DragImageChromiumMac.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageChromiumSkia.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
16:30 Changeset [57031] by eric.carlson@apple.com

2010-04-02 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Configure multi-language movies: when QuickTime has sufficiently loaded
the movie, call into wkQTMovieSelectPreferredAlternates to select the
movie's alternate tracks according to the user's language preferences.

https://bugs.webkit.org/show_bug.cgi?id=36624

  • WebCore.base.exp:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): If the movie is sufficiently loaded, call wkQTMovieSelectPreferredAlternates to set up the alternate tracks.
  • platform/mac/WebCoreSystemInterface.h: Declare WKQTMovieSelectPreferredAlternates.
  • platform/mac/WebCoreSystemInterface.mm: Add WKQTMovieSelectPreferredAlternates.

2010-04-02 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.


https://bugs.webkit.org/show_bug.cgi?id=36624

Update WebKitSystemInterface

  • WebKitSystemInterface.h: add WKQTMovieSelectPreferredAlternates.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

2010-04-02 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

https://bugs.webkit.org/show_bug.cgi?id=36624
Add an INIT macro for the WebKitSystemInterface function wkQTMovieSelectPreferredAlternates.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
16:21 Changeset [57030] by jamesr@google.com

2010-04-02 James Robinson <jamesr@chromium.org>

Reviewed by Darin Adler.

Splits RenderBlock::layoutInline into smaller functions
https://bugs.webkit.org/show_bug.cgi?id=36921

RenderBlock::layoutInlineChildren is 351 lines long and very difficult
to comprehend or edit safely. This patch splits it up into a few
slightly smaller functions. Most of the code is now in the 241 line
layoutRunsAndFloats() which is a slight improvement.

Perf neutral on the page cyclers. This doesn't introduce any function
calls into the hottest layout paths inside layoutRunsAndFloats and
findNextLineBreak.

No change in behavior, no new tests.

  • rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutReplacedElements): (WebCore::RenderBlock::createLineBoxesForResolver): (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::layoutInlineChildren):
15:57 Changeset [57029] by eric@webkit.org

2010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] Rebaseline Symbian def file
https://bugs.webkit.org/show_bug.cgi?id=37038

Switch the ordinal numbers for qtwebkit_webframe_scrollRecursively
and QWebInspector::closeEvent to match QtWebkit 4.6 branch

Fix the signature for qt_drt_setFrameFlatteningEnabled
after r56718.

Add new QtWebKit API symbols introduced not listed in the file yet.

  • symbian/eabi/QtWebKitu.def:
15:48 Changeset [57028] by eric@webkit.org

2010-04-02 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811

Basic implementation using SkBitmap. Transformations are not supported
yet. No implementation for mac.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/DragImageChromium.cpp:
  • platform/chromium/DragImageRef.h:

2010-04-02 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811

Use the DragImageRef that the DragController passes to us.

  • public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
  • src/WebViewImpl.h:
15:23 Changeset [57027] by eric@webkit.org

2010-04-02 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

[chromium] font fallback for generic fonts picks wrong font
https://bugs.webkit.org/show_bug.cgi?id=37033

When a page specifies the generic "monospace" font and the user's
browser-configured monospace font doesn't exist, we previously relied
on getLastResortFallbackFont to eventually pick a monospace font for us.

But that doesn't quite work: WebKit first falls back to the user's
"preferred standard font" before hitting the last resort code path.
So if the above conditions hold but this font exists, we'll end up
never hitting the last resort codepath.

The fix is to allow OS-level font fallback when first attempting to
resolve monospace. The existing code tried to do this, but the logic
was wrong. We would eventually fall back to the correct font anyway
so we didn't notice the logic was wrong.

This code is all handling cases where particular fonts aren't installed,
so I can't think of a way to test it; existing tests should still pass.

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
15:13 Changeset [57026] by eric@webkit.org

2010-04-02 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Clean up unused calls after changes to checkPermission and requestPermission argument lists.

  • public/WebNotificationPresenter.h:
  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission): (WebKit::NotificationPresenterImpl::requestPermission):

2010-04-02 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Adam Barth.

Clean up unused calls after changes to checkPermission and requestPermission argument lists.

  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::requestPermission):
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:
14:53 Changeset [57025] by eric@webkit.org

2010-04-02 Ruben Van Boxem <vanboxem.ruben@gmail.com>

Reviewed by Eric Seidel.

Mingw-w64 fixes for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=35607

  • runtime/Collector.cpp: use the msvc code for mingw-w64 (but not mingw-w32) (JSC::Heap::allocateBlock): (JSC::Heap::freeBlockPtr): (JSC::currentThreadStackBase): (JSC::currentThreadStackBase):
  • wtf/Platform.h: added COMPILER(MINGW64) check to differentiate between mingw.org and mingw-w64 functions
14:21 Changeset [57024] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37043
Java regression tests spam stderr about being unable to set status message

With this change, there is still spam about "Attempt to access JavaScript from destroyed
applet, type 9." I haven't investigated if that indicates a problem or not.

  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]): Removed check for _documentView. We don't seem to care.
14:18 Changeset [57023] by scherkus@chromium.org

2010-04-02 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson and Eric Seidel.

Don't stop the playback event timer when media resource loading has suspended.
https://bugs.webkit.org/show_bug.cgi?id=37003

When a user agent decides to suspend media resource loading and enters the
NETWORK_IDLE state we are supposed to only stop the progress event timer but
keep the playback timer running.

Test: http/tests/media/video-play-suspend.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Only stop the progress event timer.

2010-04-02 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Carlson and Eric Seidel.

Don't stop the playback event timer when media resource loading has suspended.
https://bugs.webkit.org/show_bug.cgi?id=37003

When a user agent decides to suspend media resource loading and enters the
NETWORK_IDLE state we are supposed to only stop the progress event timer but
keep the playback timer running.

Currently Chromium is the only platform that fires the suspend event
hence most platforms skipping this test.

  • http/tests/media/video-play-suspend-expected.txt: Added.
  • http/tests/media/video-play-suspend.html: Added.
  • platform/gtk/Skipped: Doesn't fire a suspend event.
  • platform/mac/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
14:01 Changeset [57022] by darin@apple.com

Fix mispelling that broke the build.

  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/CanvasRenderingContext2D.h:

Dashbard -> Dashboard.

13:40 Changeset [57021] by ggaren@apple.com

Build fix: updated the .def file.

13:31 Changeset [57020] by levin@chromium.org

(non-generated) code should only use CanvasRenderingContext::canvas as a CanvasSurface.
https://bugs.webkit.org/show_bug.cgi?id=36906

Reviewed by Darin Adler.

WebCore:

  • dom/CanvasSurface.cpp: Added methods for items that depended on

CanvasRenderingContext::canvas() being an HTMLElement(), so that this usage
can be dealt with in one place.
(WebCore::CanvasSurface::securityOrigin): Only used by methods that are
only run in the document context.
(WebCore::CanvasSurface::renderBox): Will likely return 0 in a worker context.
(WebCore::CanvasSurface::computedStyle): Used by setFont. Return value is TBD for
the worker context.
(WebCore::CanvasSurface::styleSelector): Ditto.

  • dom/CanvasSurface.h:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext): Passing in information into
the CanvasRenderingContext2D constructor to eliminate some uses of document
inside of the CanvasRenderingContext2D class.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::renderBox): Added to disambiguate between the
two parent class versions of the method.
(WebCore::HTMLCanvasElement::computedStyle): Ditto.

  • html/canvas/CanvasRenderingContext2D.cpp: All of these changes are about

removing document usage either by using a bool that is set in the constructor or
by calling one of the new methods added to CanvasSurface.
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode):
(WebCore::CanvasRenderingContext2D::checkOrigin):
(WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGLRenderingContext.cpp: Removed some duplicate includes.

(WebCore::WebGLRenderingContext::markContextChanged): Reduced calls to renderBox

as it may become slightly more expensive in the future.

(WebCore::WebGLRenderingContext::reshape): Ditto.

LayoutTests:

  • fast/canvas/script-tests/canvas-gradient-addStop-error.js: Changed the test

to create a new canvas after switching to dashboard compatiblity mode, which is
needed now that the compatibility mode is cached in the canvas.

13:15 Changeset [57019] by ggaren@apple.com

Inlined toThisString and toThisJSString to avoid virtual function call overhead
https://bugs.webkit.org/show_bug.cgi?id=37039

Reviewed by Oliver Hunt.

Maybe a 1% speedup on iBench JS.

  • runtime/JSCell.cpp:
  • runtime/JSCell.h:
  • runtime/JSNumberCell.cpp:
  • runtime/JSNumberCell.h:
  • runtime/JSString.cpp:
  • runtime/JSString.h:
  • runtime/JSValue.h:
  • runtime/JSZombie.h:

(JSC::JSZombie::toThisObject): Nixed the old virtual-type implementation.

  • runtime/JSObject.h:

(JSC::JSValue::toThisString):
(JSC::JSValue::toThisJSString): Added the inlined implementation.

13:03 Changeset [57018] by eric@webkit.org

2010-04-02 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
https://bugs.webkit.org/show_bug.cgi?id=35611

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added, test framebuffer object attachment behavior.
  • fast/canvas/webgl/framebuffer-object-attachment.html: Added, framebuffer object attachment behavior.
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: DEPTH_COMPONENT is no longer a valid input, use DEPTH_COMPONENT16 instead.
  • platform/mac-snowleopard/Skipped: The bot does not support EXT_packed_depth_stencil, skip the framebuffer-object-attachment.html test.

2010-04-02 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
https://bugs.webkit.org/show_bug.cgi?id=35611

Test: fast/canvas/webgl/framebuffer-object-attachment.html

  • html/canvas/WebGLFramebuffer.cpp: Keep track of attached stencil/depth renderbuffers in WebGLFramebuffer. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setIsAttached):
  • html/canvas/WebGLFramebuffer.h: Ditto. (WebCore::WebGLFramebuffer::isDepthAttached): (WebCore::WebGLFramebuffer::isStencilAttached): (WebCore::WebGLFramebuffer::isDepthStencilAttached):
  • html/canvas/WebGLRenderbuffer.cpp: Keep track of internalformat. (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
  • html/canvas/WebGLRenderbuffer.h: Ditto. (WebCore::WebGLRenderbuffer::setInternalformat): (WebCore::WebGLRenderbuffer::getInternalformat):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Detect stencil/depth buffer conflicts. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Handling DEPTH_STENCIL case. (WebCore::WebGLRenderingContext::getRenderbufferParameter): Get correct WebGL internalformat. (WebCore::WebGLRenderingContext::renderbufferStorage): Detect illegal enums.
  • html/canvas/WebGLRenderingContext.idl: Add DEPTH_STENCIL enums.
  • platform/graphics/GraphicsContext3D.h: Add DEPTH_STENCIL enums. (WebCore::GraphicsContext3D::):
  • platform/graphics/mac/GraphicsContext3DMac.cpp: Map to correct DEPTH_STENCIL format. (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):

2010-04-02 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

Implement and test new framebuffer object attachment behavior.
https://bugs.webkit.org/show_bug.cgi?id=35611

Test: fast/canvas/webgl/framebuffer-object-attachment.html

  • src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format. (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv): (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):
12:55 Changeset [57017] by tonikitoo@webkit.org

Stored focused frame and document in a vars, instead of querying for them many times.

Reviewed by Adam Treat.
Patch by Antonio Gomes <tonikitoo@webkit.org>

  • Api/qwebpage.cpp:

(QWebPagePrivate::mousePressEvent(QEvent* ev)):
(QWebPagePrivate::mousePressEvent(QGraphicsSceneMouseEvent* ev):

12:51 Changeset [57016] by eric@webkit.org

2010-04-02 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Geoffrey Garen.

Beef up documentation for ASSERT* and CRASH macros a bit.

https://bugs.webkit.org/show_bug.cgi?id=36527

  • wtf/Assertions.h:
12:21 Changeset [57015] by eric@webkit.org

2010-04-02 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=36908

  • fast/canvas/webgl/index-validation-expected.txt: Gathering more information about the cause of the failure. It's not a fix, and it won't worse change the current test behavior either, i.e., it won't make it better or worse.
  • fast/canvas/webgl/script-tests/index-validation.js: Ditto.
12:11 Changeset [57014] by eric@webkit.org

2010-04-02 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

The popup type (select or suggestion) is now passed to the
WebClient::createPopupMenu() method. This is required for
Chromium on Linux to make the select popups work correctly.
https://bugs.webkit.org/show_bug.cgi?id=37013

  • WebKit.gyp:
  • public/WebPopupType.h: Added. (WebKit::):
  • public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
  • src/ChromeClientImpl.cpp: (WebCore::convertPopupType): (WebKit::ChromeClientImpl::popupOpened):
12:09 Changeset [57013] by tkent@chromium.org

2010-04-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Form control state shouldn't be restored for hidden inputs.
https://bugs.webkit.org/show_bug.cgi?id=26241

  • fast/forms/button-state-restore.html: Updated for the behavior change.
  • fast/forms/state-restore-to-non-edited-controls-expected.txt: Added.
  • fast/forms/state-restore-to-non-edited-controls.html: Added.

2010-04-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Form control state shouldn't be restored for hidden inputs.
https://bugs.webkit.org/show_bug.cgi?id=26241

To fix this issue, we don't save values if it is not changed from
the default value.

Updating the value IDL attribute of some controls such as
type=hidden also updates the value content attribute, and it's
impossible to distinguish the initial value and the current
value. The values of such controls are not saved. It won't be a
problem because we want to save and restore user-edited values.

Test: fast/forms/state-restore-to-non-edited-controls.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::saveFormControlState): Do not save the value if it is same as the default value.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::saveFormControlState): ditto.
11:31 Changeset [57012] by eric@webkit.org

2010-04-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Forms with autocomplete=off should not consume saved state
https://bugs.webkit.org/show_bug.cgi?id=36762

  • fast/forms/state-restore-to-non-autocomplete-form-expected.txt: Added.
  • fast/forms/state-restore-to-non-autocomplete-form.html: Added.

2010-04-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Forms with autocomplete=off should not consume saved state
https://bugs.webkit.org/show_bug.cgi?id=36762

Introduce Element::shouldSaveAndRestoreFormControlState() to check
if we should save and restore control state.

Test: fast/forms/state-restore-to-non-autocomplete-form.html

  • dom/Document.cpp: (WebCore::Document::formElementsState): Check shouldSaveAndRestoreFormControlState().
  • dom/Element.h: (WebCore::Element::shouldSaveAndRestoreFormControlState): Added. It just returns true.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::autoComplete): Added. It return autocomplete state of the form. (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): Added. It returns the result of autoComplete(). (WebCore::HTMLFormControlElementWithState::finishParsingChildren): Do not restore state if shouldSaveAndRestoreFormControlState() is false.
  • html/HTMLFormControlElement.h: Declare autoComplete() and overriding methods.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::autoComplete): Reduce code by using autoComplete() of the parent class. (WebCore::HTMLInputElement::saveFormControlState): Remove the autoComplete() check. Document::formElementsState() does equivalent check.
11:03 Changeset [57011] by levin@chromium.org

sherrifbot should ensure that the rollout reason doesn't start with - (and fix webkit-patch upload).
https://bugs.webkit.org/show_bug.cgi?id=37030

Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/sheriff.py: Ensure that the rollout reason doesn't start with -.
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: A test with a rollout reason which starts with -.
  • Scripts/webkitpy/tool/steps/createbug.py: Fix webkit-patch upload.
10:41 Changeset [57010] by cjerdonek@webkit.org

Unreviewed.

Fixed check-webkit-style to recognize the short form of the
--verbose option, as stated in --help.

  • Scripts/check-webkit-style:
    • Tweaked one line.
10:40 Changeset [57009] by simon.fraser@apple.com

2010-04-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Avoid doing work in FrameView::scrollPositionChanged() if there are no fixed position elements
https://bugs.webkit.org/show_bug.cgi?id=36994

r55890 added knowledge to FrameView about whether it contains any fixed-position elements. We can
use this to avoid updating widget positions, and compositing layer positions when possible.

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged):
  • page/FrameView.h: (WebCore::FrameView::hasFixedObjects):
10:33 Changeset [57008] by japhet@chromium.org

2010-04-02 Nate Chapin <japhet@chromium.org>

Rubber-stamped by Dimitri Glazkov.

http://trac.webkit.org/changeset/57004 caused
fast/dom/console-log-stack-overflow.html to fail for Chromium.
Add check for empty wrappers before using them to create a hidden reference.

  • bindings/scripts/CodeGeneratorV8.pm:
10:24 Changeset [57007] by krit@webkit.org

2010-04-02 Dirk Schulze <krit@webkit.org>

Unreviewed.

[Gtk] LayoutTest feColorMatrix-value with different results over Gtk bots
https://bugs.webkit.org/show_bug.cgi?id=37029

Adding svg/filters/feColorMatrix-values.svg to the Gtk skip list. Opened
the bug report from above.

  • platform/gtk/Skipped:
10:01 Changeset [57006] by eric@webkit.org

2010-04-02 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Incorrect insertion position after typing 'ำ' (THAI CHARACTER SARA AM = 0E33)
https://bugs.webkit.org/show_bug.cgi?id=36858

Add failing results for Tiger to make the Tiger bot green.
We may wish to actually fix Tiger at some point.

  • platform/mac-tiger/fast/text/multiglyph-characters-expected.txt: Added.
09:45 Changeset [57005] by kevino@webkit.org

[wx] Build fix for DumpRenderTree after addition of layerTreeAsText.

09:40 Changeset [57004] by japhet@chromium.org

2010-04-01 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Generalize (and generate!) the creation of hidden references
between JS wrappers.


https://bugs.webkit.org/show_bug.cgi?id=36777

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm: Generate calls to setHiddenReference() in attribute getters.
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::setHiddenReference): Split common logic out of hidden setHiddenWindowReference (WebCore::V8DOMWrapper::setHiddenWindowReference): Now contains logic specific to putting a hidden reference on a global object. (WebCore::globalObjectPrototypeIsDOMWindow): Be more thorough in the COMPILE_ASSERTs. (WebCore::V8DOMWrapper::convertEventTargetToV8Object): Cleanup: Remove a duplicate if statement.
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/WrapperTypeInfo.h:
  • bindings/v8/custom/V8BarInfoCustom.cpp: Removed.
  • bindings/v8/custom/V8CSSStyleSheetCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8DOMSelectionCustom.cpp: Removed.
  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8MessageChannelConstructor.cpp: (WebCore::V8MessageChannel::constructorCallback):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
  • bindings/v8/custom/V8ScreenCustom.cpp: Removed.
  • bindings/v8/custom/V8StyleSheetCustom.cpp: (WebCore::toV8):
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::frame): Add frame() accessor.
08:43 Changeset [57003] by pfeldman@chromium.org

2010-04-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: start editing DOM and styles on click-and-pause (part 1).

https://bugs.webkit.org/show_bug.cgi?id=36965

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.onattach): (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._handleClickAndPause): (WebInspector.ElementsTreeElement.prototype._startEditingTarget): (WebInspector.ElementsTreeElement.prototype._startEditingAttribute): (WebInspector.ElementsTreeElement.prototype._startEditingTextNode): (WebInspector.ElementsTreeElement.prototype._startEditingTagName): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick): (WebInspector.StylePropertiesSection.prototype._handleSelectorClick): (WebInspector.StylePropertiesSection.prototype._handleSelectorClickAndPause): (WebInspector.StylePropertiesSection.prototype._handleSelectorDoubleClick): (WebInspector.StylePropertiesSection.prototype._startEditingOnMouseEvent): (WebInspector.StylePropertyTreeElement.prototype.onattach): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js:
  • inspector/front-end/treeoutline.js: (TreeElement.prototype._attach): (TreeElement.treeElementMouseDown): (TreeElement.prototype.selectOnMouseDown):
08:07 Changeset [57002] by darin@chromium.org

2010-04-02 Darin Fisher <darin@chromium.org>

Add chromium suppression for http/tests/xhtmlmp since we do not support
this feature.

  • platform/chromium/test_expectations.txt:
07:54 Changeset [57001] by laszlo.1.gombos@nokia.com

2010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, minor build fix.

Change the order of the member initialisation list
in constructor to match declaration order

  • runtime/Collector.cpp: (JSC::Heap::Heap):
06:41 WebKit Team edited by chang.shu@nokia.com
(diff)
06:05 Changeset [57000] by laszlo.1.gombos@nokia.com

2010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed build fix when building --no-svg.

Build fix after r56941. Add ENABLE(SVG) guard.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
05:55 Changeset [56999] by yurys@chromium.org

2010-04-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Implement InspectorFrontendHost::showContextMenu for Chromium.


Move inspector frontend context menu code from InspectorFrontendClient to InspectorFrontendHost as it's platform independent.


https://bugs.webkit.org/show_bug.cgi?id=36817

  • WebCore.Inspector.exp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal): (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::FrontendMenuProvider::create): (WebCore::FrontendMenuProvider::disconnect): (WebCore::FrontendMenuProvider::FrontendMenuProvider): (WebCore::FrontendMenuProvider::~FrontendMenuProvider): (WebCore::FrontendMenuProvider::populateContextMenu): (WebCore::FrontendMenuProvider::contextMenuItemSelected): (WebCore::FrontendMenuProvider::contextMenuCleared): (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::disconnectClient): (WebCore::InspectorFrontendHost::showContextMenu):
  • inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::create):

2010-04-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Implement InspectorFrontendClient in Chromium and remove all custom bindings for the host methods from WebDevToolsFrontendImpl.

https://bugs.webkit.org/show_bug.cgi?id=36817

  • WebKit.gyp:
  • src/InspectorFrontendClientImpl.cpp: Added. (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::~InspectorFrontendClientImpl): (WebKit::InspectorFrontendClientImpl::windowObjectCleared): (WebKit::InspectorFrontendClientImpl::frontendLoaded): (WebKit::InspectorFrontendClientImpl::moveWindowBy): (WebKit::InspectorFrontendClientImpl::localizedStringsURL): (WebKit::InspectorFrontendClientImpl::hiddenPanels): (WebKit::InspectorFrontendClientImpl::bringToFront): (WebKit::InspectorFrontendClientImpl::closeWindow): (WebKit::InspectorFrontendClientImpl::canAttachWindow): (WebKit::InspectorFrontendClientImpl::attachWindow): (WebKit::InspectorFrontendClientImpl::detachWindow): (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight): (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
  • src/InspectorFrontendClientImpl.h: Added.
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
  • src/WebDevToolsFrontendImpl.h:
  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
  • src/js/DevTools.js: ():
05:18 Changeset [56998] by ossy@webkit.org

[Qt] http/tests/xmlhttprequest/access-control-response-with-body.html was introduced in r56955,
but it fails: "NETWORK_ERR: XMLHttpRequest Exception 101: A network error occured in synchronous requests."

  • platform/qt/Skipped: http/tests/xmlhttprequest/access-control-response-with-body.html skipped.
05:17 Changeset [56997] by loislo@chromium.org

2010-04-02 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Timeline Overview pane should support short records filtering.
https://bugs.webkit.org/show_bug.cgi?id=37020

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.update.markTimeline): (WebInspector.TimelineOverviewPane.prototype.update):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelinePanel.FormattedRecord.prototype.isLong):
04:25 Changeset [56996] by ossy@webkit.org

[Qt] Platform specific expected file added for test introduced in r56775,
because it passes. Compared to png file and Mac expected file.

  • platform/qt/svg/custom/animation-currentColor-expected.txt: Added.
03:10 Changeset [56995] by tkent@chromium.org

Unreviewed. Update the expectation for fast/dom/HTMLProgressElement/set-progress-properties.html

02:31 Changeset [56994] by eric@webkit.org

2010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
https://bugs.webkit.org/show_bug.cgi?id=34262

Add a simple test that fails if XHTML-MP mime
type is not accepted.

  • http/conf/mime.types: Register XHTML-MP mime type with the test server
  • http/tests/xhtmlmp: Added.
  • http/tests/xhtmlmp/xhtml-expected.txt: Added.
  • http/tests/xhtmlmp/xhtml.xhtmlmp: Added. Testcase with the newly registered file extension.

2010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
https://bugs.webkit.org/show_bug.cgi?id=34262

Enable processing XHTML-MP mime type as an XHTML document
even if XHTML-MP support is not enabled.

  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes):

2010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Accept XHTML-MP content type as XHTML content
https://bugs.webkit.org/show_bug.cgi?id=34262

Register xhtmlmp file extension as the new type
for XHTML-MP test content.

  • Scripts/run-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/test_files.py:
  • Scripts/webkitpy/layout_tests/port/lighttpd.conf:
02:20 Changeset [56993] by eric@webkit.org

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

create-rollout doesn't fill out ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=37010

The contract between apply_reverse_diff and PrepareChangeLogForRevert
was unclear. I broke filling out the ChangeLog during rollout earlier
when I changed apply_reverse_diff to revert the ChangeLogs because
PrepareChangeLogForRevert thought that it was supposed to do that.
I've now taught PrepareChangeLogsForRevert the new contract.

It's unclear to me how to test this change because it's essentially an
integration issue that requires the file system. At some point we
should think about a testing strategy for integration. As the system
becomes larger, we're running into more of these issues.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
02:10 Changeset [56992] by eric@webkit.org

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add cr-win-ews to QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=37004

  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/statusbubble.html:
02:00 Changeset [56991] by eric@webkit.org

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Make XSSAuditor go fast with large POST data
https://bugs.webkit.org/show_bug.cgi?id=36694

There were two things slowing down this bechmark:

1) Searching the large POST data for each inline event handler. To

make this faster, we now use a suffix tree to fast-reject strings
that don't appear as substrings of the POST data.

2) The next largest cost was flattening the form data into a string.

To make this fater, we now use the form data object itself as a key
and only flatten once.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::CachingURLCanonicalizer::canonicalizeURL): (WebCore::XSSAuditor::CachingURLCanonicalizer::clear): (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::findInRequest):
  • page/XSSAuditor.h: (WebCore::XSSAuditor::CachingURLCanonicalizer::CachingURLCanonicalizer): (WebCore::XSSAuditor::CachingURLCanonicalizer::generation):
  • platform/text/SuffixTree.h: Added. (WebCore::UnicodeCodebook::codeWord): (WebCore::UnicodeCodebook::): (WebCore::ASCIICodebook::codeWord): (WebCore::ASCIICodebook::): (WebCore::SuffixTree::SuffixTree): (WebCore::SuffixTree::mightContain): (WebCore::SuffixTree::Node::Node): (WebCore::SuffixTree::Node::~Node): (WebCore::SuffixTree::Node::at): (WebCore::SuffixTree::build):
01:33 Changeset [56990] by tkent@chromium.org

2010-04-02 Kent Tamura <tkent@chromium.org>

Unreviewed test fix. Follow the behavior change by r56962.

  • editing/selection/4960137.html:
01:31 Changeset [56989] by eric@webkit.org

2010-04-02 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Eric Seidel.

Bug 36741 - Duplicate, slightly divergent implementation of Position[Iterator]::isCandidate()
https://bugs.webkit.org/show_bug.cgi?id=36741

Patch: change Position::isCandididate() to call the PositionIterator::isCandidate() version.
Update PositionIterator::isCandidate() to mirror Position::isCandidate().

Rationale: PositionIterator::isCandidate() is called in a tight loop within
next/previousCandidate(). Also, creation of a PositionIterator from a Position
is cheaper than vice-versa.

Tests: ran all tests in 'editing'.

  • dom/Position.cpp: (WebCore::Position::isCandidate):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
01:31 Changeset [56988] by cjerdonek@webkit.org

2010-04-02 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

Unit-test networktransaction.py's log messages, and add a base
class to make unit-testing log messages even easier.

https://bugs.webkit.org/show_bug.cgi?id=36958

The purpose of this patch is also to provide a mini-tutorial on
how to unit-test Python logging.py messages.

  • Scripts/webkitpy/common/net/networktransaction_unittest.py:
    • Unit-tested the log messages in test_retry().
  • Scripts/webkitpy/common/system/logtesting.py:
    • Adjusted the LogTesting class by moving the code that clears the array of log messages into a finally block. This prevents redundant AssertionErrors from getting rendered to the screen while running unit tests.
    • Added a LoggingTestCase class so the setUp() and tearDown() methods do not need to be implemented in order to test logging. Rather, TestCase classes can simply inherit from this class.
01:27 Changeset [56987] by cjerdonek@webkit.org

2010-04-02 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Re-wrote check-webkit-style's argument parsing code to use
Python's optparser module and more uniform error-handling logic.

https://bugs.webkit.org/show_bug.cgi?id=34676

  • Scripts/webkitpy/style/optparser.py:
    • Removed "option help" from check-webkit-style's usage string since that is provided separately by the OptionParser class.
    • Also changed the usage string from a function to a constant string _USAGE.
    • Added an _EPILOG string which renders after OptionParser's usage string and option help.
    • In the ArgumentParser class:
      • Changed the constructor's stderr_write parameter to a mock_stderr since the OptionParser accepts a sys.stderr substitute rather than a sys.stderr.write substitute.
      • Changed the constructor to set a _parser data attribute with an OptionParser instance.
      • Added a _create_option_parser() method which instantiates the OptionParser.
      • Updated _exit_with_help() to interact with the OptionParser's help method.
      • Updated the parse() method as necessary. Also changed the raising of ValueErrors to calls to _exit_with_help().
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Removed the CreateUsageTest class since the create_usage method was replaced by a constant string.
    • Added a _MockStdErr class to the ArgumentParserTest class.
    • Updated the unit tests as necessary.
01:18 Changeset [56986] by abarth@webkit.org

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The master commit-queue process should take responsibility for checking that the builders are green
https://bugs.webkit.org/show_bug.cgi?id=37009

We had a failure where the child process noticed that the builders were
red. We've always had this race condition, but the new optimistic
design made it easier to trigger.

  • Scripts/webkitpy/tool/commands/queues.py:
01:18 Changeset [56985] by abarth@webkit.org

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Tweak rollout changelog to pass ValidateReviewer check
https://bugs.webkit.org/show_bug.cgi?id=37019

We need to use the magic word "unreviewed" to make the commit-queue
happy when landing rollouts.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
01:16 Changeset [56984] by eric@webkit.org

2010-04-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Eric Seidel.

[Qt]Fix compile error with QT_NO_SETTINGS
https://bugs.webkit.org/show_bug.cgi?id=36533

If QT_NO_SETTINGS is defined, QSettings is not available.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): (WebCore::InspectorClientQt::storeSetting):
01:13 Changeset [56983] by cjerdonek@webkit.org

Unreviewed.

Removed duplicate ChangeLog entry.

01:04 Changeset [56982] by eric@webkit.org

2010-04-02 Eric Seidel <eric@webkit.org>

Unreviewed, just updating expected results for passing tests.

suppress image failures for now to get a clean test run w/ pixel tests enabled for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=36620

Remove several tests marked MISSING which no longer seem to be missing.

  • platform/mac/test_expectations.txt:
01:03 Changeset [56981] by cjerdonek@webkit.org

Rubber-stamped by Eric Seidel.

To the Python 2.4 error message, added a link to the wiki page
that contains instructions on how to upgrade.

  • Scripts/test-webkitpy:
    • Eliminated a use of the ternary operator in configure_logging() to let the version warning display in case of Python 2.4.
  • Scripts/webkitpy/python24/versioning_unittest.py:
    • Updated unit test text.
00:39 Changeset [56980] by eric@webkit.org

2010-04-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - customized popup for <select multiple> elements
https://bugs.webkit.org/show_bug.cgi?id=36368

Using QtMaemoWebPopup instead of QtFallbackWebPopup for Maemo.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate):
00:30 Changeset [56979] by abarth@webkit.org

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(56295): http/tests/security/xssAuditor/xss-protection-parsing-01.html times out on Tiger Bot
https://bugs.webkit.org/show_bug.cgi?id=36933

Change the test design in an attempt to get this passing on Tiger. In
this variation, we use a POST request to work around possible caching
issues in Tiger's CFNetwork.

  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-01.html:
00:25 Changeset [56978] by sfalken@apple.com

Database code falsely returns errors due to errant pointer check
https://bugs.webkit.org/show_bug.cgi?id=37014

Reviewed by Dan Bernstein.

r56943 introduced a check to see if there were any unprocessed
SQL commands after calling sqlite3_prepare16_v2.

Accessing the remaining data via pointer wasn't possible since
the query string is deallocated immediately after the
query runs. The String returned from strippedWhiteSpace
goes out of scope at that point.

Fix is to store the strippedWhiteSpace in a temporary String
so we can access it via character ptr later in the function.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

00:14 Changeset [56977] by eric@webkit.org

2010-04-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Record the IRC nick of folks who request rollouts
https://bugs.webkit.org/show_bug.cgi?id=36999

  • Scripts/webkitpy/common/net/irc/ircbot.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
00:04 Changeset [56976] by eric@webkit.org

2010-04-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add cr-win-ews
https://bugs.webkit.org/show_bug.cgi?id=36974

Adds support for an Early Warning System for Chromium on Linux. The
interface to the Chromium port is the same on every platform, so we
don't need to create a new Port object for this queue.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
Note: See TracTimeline for information about the timeline view.