Timeline


and

04/08/10:

23:43 Changeset [57313] by abarth@webkit.org

2010-04-08 Chris Evans <cevans@chromium.org>

Reviewed by Sam Weinig.

Add test for POST & _blank popup blocker bypass.
https://bugs.webkit.org/show_bug.cgi?id=34541

  • fast/events/popup-blocked-to-post-blank.html: added
  • fast/events/popup-blocked-to-post-blank-expected.txt: added

2010-04-08 Chris Evans <cevans@chromium.org>

Reviewed by Sam Weinig.

Use the new UserGestureIndictor for _blank POST requests.

https://bugs.webkit.org/show_bug.cgi?id=34541

Test: fast/events/popup-blocked-to-post-blank.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): Use UserGestureIndicator in more cases.
  • page/EventHandler.cpp: (WebCore::EventHandler): Impact from UserGestureIndicator API change. (WebCore::FrameLoader::submitForm): Block the load immediately if popups are not allowed and it would open a new window.
  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): Note the UserGestureIndicator status at the time of submission. (WebCore::ScheduledFormSubmission::fire): Use the stored UserGestureIndicator status in the asynchronous callback.
  • dom/UserGestureIndicator.h:
  • dom/UserGestureIndicator.cpp: (WebCore::UserGestureIndicator::UserGestureIndicator): Add ability to store a negative indication.
18:14 Changeset [57312] by weinig@apple.com

Add option to build WebKit2 to build-webkit.

Reviewed by Darin Adler.

  • Scripts/build-webkit:
17:52 Changeset [57311] by weinig@apple.com

Add build support for WebKit2.

Reviewed by Anders Carlsson.

  • Configurations: Added.
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/FeatureDefines.xcconfig: Added.
  • Configurations/Version.xcconfig: Added.
  • Configurations/WebKit2.xcconfig: Added.
  • English.lproj: Added.
  • English.lproj/InfoPlist.strings: Added.
  • Info.plist: Added.
  • Makefile: Added.
  • WebKit2.xcodeproj: Added.
  • WebKit2.xcodeproj/project.pbxproj: Added.
  • WebKit2Prefix.cpp: Added.
  • WebKit2Prefix.h: Added.
  • WebKit2_Prefix.pch: Added.
  • WebProcess-Info.plist: Added.
  • version.plist: Added.
  • win: Added.
  • win/WebKit2.def: Added.
  • win/WebKit2.vcproj: Added.
  • win/WebKit2Generated.make: Added.
  • win/WebKit2Generated.vcproj: Added.
  • win/WebKit2WebProcess.vcproj: Added.
17:50 Changeset [57310] by weinig@apple.com

Add WebKit2/UIProcess directory.

Patch by Anders Carlsson <andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig.

  • UIProcess: Added.
  • UIProcess/API: Added.
  • UIProcess/API/C: Added.
  • UIProcess/API/C/WKAPICast.h: Added.
  • UIProcess/API/C/WKBase.h: Added.
  • UIProcess/API/C/WKContext.cpp: Added.
  • UIProcess/API/C/WKContext.h: Added.
  • UIProcess/API/C/WKFrame.cpp: Added.
  • UIProcess/API/C/WKFrame.h: Added.
  • UIProcess/API/C/WKFramePolicyListener.cpp: Added.
  • UIProcess/API/C/WKFramePolicyListener.h: Added.
  • UIProcess/API/C/WKPage.cpp: Added.
  • UIProcess/API/C/WKPage.h: Added.
  • UIProcess/API/C/WKPageNamespace.cpp: Added.
  • UIProcess/API/C/WKPageNamespace.h: Added.
  • UIProcess/API/C/WKPreferences.cpp: Added.
  • UIProcess/API/C/WKPreferences.h: Added.
  • UIProcess/API/C/WebKit2.h: Added.
  • UIProcess/API/mac: Added.
  • UIProcess/API/mac/PageClientImpl.h: Added.
  • UIProcess/API/mac/PageClientImpl.mm: Added.
  • UIProcess/API/mac/WKView.h: Added.
  • UIProcess/API/mac/WKView.mm: Added.
  • UIProcess/API/mac/WKViewInternal.h: Added.
  • UIProcess/API/win: Added.
  • UIProcess/API/win/WKAPICastWin.h: Added.
  • UIProcess/API/win/WKBaseWin.h: Added.
  • UIProcess/API/win/WKView.cpp: Added.
  • UIProcess/API/win/WKView.h: Added.
  • UIProcess/Launcher: Added.
  • UIProcess/Launcher/WebProcessLauncher.h: Added.
  • UIProcess/Launcher/mac: Added.
  • UIProcess/Launcher/mac/WebProcessLauncher.mm: Added.
  • UIProcess/Launcher/win: Added.
  • UIProcess/Launcher/win/WebProcessLauncher.cpp: Added.
  • UIProcess/PageClient.h: Added.
  • UIProcess/ProcessModel.h: Added.
  • UIProcess/ResponsivenessTimer.cpp: Added.
  • UIProcess/ResponsivenessTimer.h: Added.
  • UIProcess/ScriptReturnValueCallback.cpp: Added.
  • UIProcess/ScriptReturnValueCallback.h: Added.
  • UIProcess/WebContext.cpp: Added.
  • UIProcess/WebContext.h: Added.
  • UIProcess/WebFramePolicyListenerProxy.cpp: Added.
  • UIProcess/WebFramePolicyListenerProxy.h: Added.
  • UIProcess/WebFrameProxy.cpp: Added.
  • UIProcess/WebFrameProxy.h: Added.
  • UIProcess/WebLoaderClient.cpp: Added.
  • UIProcess/WebLoaderClient.h: Added.
  • UIProcess/WebPageNamespace.cpp: Added.
  • UIProcess/WebPageNamespace.h: Added.
  • UIProcess/WebPageProxy.cpp: Added.
  • UIProcess/WebPageProxy.h: Added.
  • UIProcess/WebPolicyClient.cpp: Added.
  • UIProcess/WebPolicyClient.h: Added.
  • UIProcess/WebPreferences.cpp: Added.
  • UIProcess/WebPreferences.h: Added.
  • UIProcess/WebProcessManager.cpp: Added.
  • UIProcess/WebProcessManager.h: Added.
  • UIProcess/WebProcessProxy.cpp: Added.
  • UIProcess/WebProcessProxy.h: Added.
  • UIProcess/WebUIClient.cpp: Added.
  • UIProcess/WebUIClient.h: Added.
  • UIProcess/mac: Added.
  • UIProcess/mac/DrawingAreaProxy.h: Added.
  • UIProcess/mac/DrawingAreaProxy.mm: Added.
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.h: Added.
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: Added.
  • UIProcess/win: Added.
  • UIProcess/win/DrawingAreaProxy.cpp: Added.
  • UIProcess/win/DrawingAreaProxy.h: Added.
  • UIProcess/win/WebView.cpp: Added.
  • UIProcess/win/WebView.h: Added.
17:49 Changeset [57309] by weinig@apple.com

Add WebKit2/WebProcess directory.

Patch by Anders Carlsson <andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig and Oliver Hunt.

  • WebProcess: Added.
  • WebProcess/Launching: Added.
  • WebProcess/Launching/mac: Added.
  • WebProcess/Launching/mac/WebProcessMain.mm: Added.
  • WebProcess/Launching/win: Added.
  • WebProcess/Launching/win/WebProcessWinMain.cpp: Added.
  • WebProcess/WebCoreSupport: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.h: Added.
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebContextMenuClient.h: Added.
  • WebProcess/WebCoreSupport/WebDragClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebDragClient.h: Added.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebEditorClient.h: Added.
  • WebProcess/WebCoreSupport/WebErrors.h: Added.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebInspectorClient.h: Added.
  • WebProcess/WebCoreSupport/mac: Added.
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: Added.
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.h: Added.
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.m: Added.
  • WebProcess/WebCoreSupport/win: Added.
  • WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp: Added.
  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: Added.
  • WebProcess/WebPage: Added.
  • WebProcess/WebPage/DrawingArea.cpp: Added.
  • WebProcess/WebPage/DrawingArea.h: Added.
  • WebProcess/WebPage/WebFrame.cpp: Added.
  • WebProcess/WebPage/WebFrame.h: Added.
  • WebProcess/WebPage/WebPage.cpp: Added.
  • WebProcess/WebPage/WebPage.h: Added.
  • WebProcess/WebPage/mac: Added.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: Added.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h: Added.
  • WebProcess/WebPage/mac/WebPageMac.mm: Added.
  • WebProcess/WebPage/win: Added.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp: Added.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.h: Added.
  • WebProcess/WebPage/win/WebPageWin.cpp: Added.
  • WebProcess/WebProcess.cpp: Added.
  • WebProcess/WebProcess.h: Added.
  • WebProcess/win: Added.
  • WebProcess/win/DllMain.cpp: Added.
  • WebProcess/win/WebLocalizableStrings.cpp: Added.
  • WebProcess/win/WebLocalizableStrings.h: Added.
  • WebProcess/win/WebProcessMain.cpp: Added.
  • WebProcess/win/WebProcessMain.h: Added.
17:47 Changeset [57308] by weinig@apple.com

Add WebKit2/Shared directory.

Reviewed by Anders Carlsson.

  • Shared: Added.
  • Shared/CoreIPCSupport: Added.
  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Added.
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Added.
  • Shared/CoreIPCSupport/WebPageMessageKinds.h: Added.
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added.
  • Shared/CoreIPCSupport/WebProcessMessageKinds.h: Added.
  • Shared/NotImplemented.h: Added.
  • Shared/WebCoreTypeArgumentMarshalling.h: Added.
  • Shared/WebEvent.h: Added.
  • Shared/WebEventConversion.cpp: Added.
  • Shared/WebEventConversion.h: Added.
  • Shared/WebPreferencesStore.cpp: Added.
  • Shared/WebPreferencesStore.h: Added.
  • Shared/mac: Added.
  • Shared/mac/UpdateChunk.cpp: Added.
  • Shared/mac/UpdateChunk.h: Added.
  • Shared/mac/WebEventFactory.h: Added.
  • Shared/mac/WebEventFactory.mm: Added.
  • Shared/win: Added.
  • Shared/win/UpdateChunk.cpp: Added.
  • Shared/win/UpdateChunk.h: Added.
  • Shared/win/WebEventFactory.cpp: Added.
  • Shared/win/WebEventFactory.h: Added.
17:46 Changeset [57307] by weinig@apple.com

Add WebKit2/Platform directory.

Reviewed by Anders Carlsson.

  • Platform: Added.
  • Platform/CoreIPC: Added.
  • Platform/CoreIPC/ArgumentDecoder.cpp: Added.
  • Platform/CoreIPC/ArgumentDecoder.h: Added.
  • Platform/CoreIPC/ArgumentEncoder.cpp: Added.
  • Platform/CoreIPC/ArgumentEncoder.h: Added.
  • Platform/CoreIPC/Arguments.h: Added.
  • Platform/CoreIPC/Attachment.cpp: Added.
  • Platform/CoreIPC/Attachment.h: Added.
  • Platform/CoreIPC/Connection.cpp: Added.
  • Platform/CoreIPC/Connection.h: Added.
  • Platform/CoreIPC/MessageID.h: Added.
  • Platform/CoreIPC/mac: Added.
  • Platform/CoreIPC/mac/ConnectionMac.cpp: Added.
  • Platform/CoreIPC/mac/MachPort.h: Added.
  • Platform/CoreIPC/win: Added.
  • Platform/CoreIPC/win/ConnectionWin.cpp: Added.
  • Platform/PlatformProcessIdentifier.h: Added.
  • Platform/RunLoop.cpp: Added.
  • Platform/RunLoop.h: Added.
  • Platform/WorkItem.h: Added.
  • Platform/WorkQueue.cpp: Added.
  • Platform/WorkQueue.h: Added.
  • Platform/mac: Added.
  • Platform/mac/RunLoopMac.mm: Added.
  • Platform/mac/WorkQueueMac.cpp: Added.
  • Platform/win: Added.
  • Platform/win/RunLoopWin.cpp: Added.
17:37 Changeset [57306] by darin@apple.com

run-webkit-tests should respect argument order
https://bugs.webkit.org/show_bug.cgi?id=37257

Reviewed by Alexey Proskuryakov.

  • Scripts/run-webkit-tests: Changed so that sorting is done only

on the results of iterating directories. Test order is based on
what's passed on the command line. Removed code that aimed to
eliminate duplicates since it can be useful to run the same test
more than once.

16:31 Changeset [57305] by ojan@chromium.org

2010-04-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[Chromium] Mark failing tests after r57292
https://bugs.webkit.org/show_bug.cgi?id=37298

  • platform/chromium/test_expectations.txt:
16:24 Changeset [57304] by tonikitoo@webkit.org

Spatial Navigation: proper handle negative x or y coordinates https://bugs.webkit.org/show_bug.cgi?id=36773

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

In Spatial Navigation logic, during rect acquisition in renderRectRelativeToRootDocument,
sometimes negative x() or y() values are got, and the current algorithm bails out in
any of such cases.

However, when a node is in a scrollable content (content overflow <div>) and
this scrollable container scrolled up, element gets offscreen, and gets negative values
for y(), for example. In such cases, they are still valid to be used in Spatial Navigation
logic.

Test: fast/events/spatial-navigation/snav-offscreen-content.html

  • page/SpatialNavigation.cpp:

(WebCore::distanceDataForNode):
(WebCore::checkNegativeCoordsForNode):

LayoutTests:

  • fast/events/spatial-navigation/snav-offscreen-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-offscreen-content.html: Added.
16:07 Changeset [57303] by ossy@webkit.org

[Qt] r57274 removed fast/forms/willvalidate-000.html,
so it should be removed from Skipped list too.

  • platform/qt/Skipped: fast/forms/willvalidate-000.html removed.
15:59 Changeset [57302] by sfalken@apple.com

WebView::isLoading should null check m_mainFrame
https://bugs.webkit.org/show_bug.cgi?id=37294

Reviewed by Darin Adler.

  • WebView.cpp:

(WebView::isLoading):

15:55 Changeset [57301] by dumi@chromium.org

WebCore: Create the creation callback is the current world.
https://bugs.webkit.org/show_bug.cgi?id=37290

Reviewed by Geoffrey Garen.

  • bindings/js/JSDatabaseCallback.cpp:

(WebCore::JSDatabaseCallback::JSDatabaseCallback):

LayoutTests: Test that the creation callback is executed in the world where it
was created.
https://bugs.webkit.org/show_bug.cgi?id=37290

Reviewed by Geoffrey Garen.

  • storage/open-database-creation-callback-isolated-world-expected.txt:
  • storage/open-database-creation-callback-isolated-world.html:
15:39 Changeset [57300] by ossy@webkit.org

[Qt] Skip new tests introduced in r57292, because of unimplemented
layoutTestController.computedStyleIncludingVisitedInfo()

  • platform/qt/Skipped:
    • fast/history/nested-visited-test.html skipped.
    • fast/history/self-is-visited.html skipped.
    • fast/history/sibling-visited-test.html skipped.
15:37 Changeset [57299] by hyatt@apple.com

Followup optimization to bug 24300, don't leak history info via CSS :visited. If a Web
site uses document colors that are the same for link and vlink in HTML and also doesn't
specify any :link or :visited rules, then don't waste time resolving visited styles.

Reviewed by Oliver Hunt.

There is a further optimization that could be done to detect when :link and :visited are
used together in the same rule to specify a color, and this is how most sites turn off
visited link colors, but this fix doesn't address that. It just restores the optimization
that existed prior to the patch in 24300 landing.

  • css/CSSGrammar.y:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::usesLinkRules):
(WebCore::Document::setUsesLinkRules):

15:36 WebKit2 edited by weinig@apple.com
(diff)
15:18 Changeset [57298] by yuzo@google.com

2010-04-08 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Another trial

Tests that should have been landed as part of the earlier patch for Bug 36276.
https://bugs.webkit.org/show_bug.cgi?id=36276

  • fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
  • fast/css/invalid-not-with-simple-selector-sequence.html: Added.
15:18 WebKit2 created by weinig@apple.com
Initial chech-in.
15:17 Changeset [57297] by hyatt@apple.com

Caught by pixel tests. I missed patching the borderRightColor() call for fieldset border painting so the
border stopped showing up.

Reviewed by Oliver Hunt.

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBorderMinusLegend):

15:16 WikiStart edited by weinig@apple.com
Add link to WebKit2 design doc (diff)
15:09 Changeset [57296] by weinig@apple.com

Rubber-stamped by Mark Rowe.

Add WebKit2 directory.

15:05 Changeset [57295] by yuzo@google.com

2010-04-08 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Tests that should have been landed as part of the earlier patch for Bug 36276.
https://bugs.webkit.org/show_bug.cgi?id=36276

  • fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
  • fast/css/invalid-not-with-simple-selector-sequence.html: Added.
15:02 Changeset [57294] by hyatt@apple.com

Fix Qt build.

14:48 Changeset [57293] by ojan@chromium.org

2010-04-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

I missed the linux-only results in http://trac.webkit.org/changeset/57291

  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
14:29 Changeset [57292] by hyatt@apple.com

WebCore: https://bugs.webkit.org/show_bug.cgi?id=24300, don't leak history info via CSS :visited.

Reviewed by Oliver Hunt.

This patch implements the policy described by David Baron here:

http://dbaron.org/mozilla/visited-privacy

Added new tests in fast/history.

  • WebCore.base.exp:

Expose functions needed for the WebKit SPI used by layout tests.

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isVisited):
Make sure accessibility objects still return visited information.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSComputedStyleDeclaration.h:

(WebCore::computedStyle):
Add a boolean to computed style declarations that - if set - causes the computed style
to still return :visited information. For normal Web pages, this will be false. It is set
to true for the Web Inspector and by the WebKit SPI used by the layout tests.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::keyframeStylesForAnimation):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyPropertyToStyle):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):

  • css/CSSStyleSelector.h:

Rework the style selector to resolve two styles instead of one. The first forces the link to
be unvisited, and the second forces the link to be visited. The real state of the link is
cached on the principal (unvisited) style. The visited style hangs off the principal style
as a pseudo style (VISITED_LINK).

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):
Make sure to deal with the VISITED_LINK pseudo to know when only :visited style info changed.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getStyles):
Let the Web Inspector see :visited computed styles by default.

  • platform/LinkHash.cpp:

(WebCore::visitedURL):
Fix an issue where <a href=""> is not hashed properly to the document's base URI, so it wasn't
correctly reported as :visited.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintObject):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBorderMinusLegend):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintFocusRings):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::drawArcForBoxSide):
(WebCore::RenderObject::paintOutline):
(WebCore::decorationColor):
(WebCore::RenderObject::getTextDecorationColors):

  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp:

(WebCore::RenderPath::paint):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

  • rendering/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::paint):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paint):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::collapsedLeftBorder):
(WebCore::RenderTableCell::collapsedRightBorder):
(WebCore::RenderTableCell::collapsedTopBorder):
(WebCore::RenderTableCell::collapsedBottomBorder):
(WebCore::RenderTableCell::paintCollapsedBorder):

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::operator==):
Patch painting code to fetch visitedDependentColors from the RenderStyle. Properties that
are honored include background-color, color, border colors, outline color, column rules,
and fill and stroke (both SVG and our custom versions).

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):
(WebCore::borderStyleForColorProperty):
(WebCore::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::NonInheritedFlags::operator==):
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::insideLink):
(WebCore::InheritedFlags::isLink):
(WebCore::InheritedFlags::setInsideLink):
(WebCore::InheritedFlags::setIsLink):

  • rendering/style/RenderStyleConstants.h:

Change how link information is stored. The noninherited flags now have a bit set for if you're a link
or not. The inherited flags now cache whether you're inside a visited or unvisited link (or no link at
all).

(WebCore::):

  • svg/graphics/SVGPaintServer.cpp:

(WebCore::SVGPaintServer::fillPaintServer):
(WebCore::SVGPaintServer::strokePaintServer):
Patch SVG fill/stroke painting to honor :visited.

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS

Reviewed by Oliver Hunt.

Add SPI so that layout tests can access computed style including :visited information.

  • WebView/WebRenderNode.mm:

(copyRenderNode):

  • WebView/WebView.mm:

(-[WebView _computedStyleIncludingVisitedInfo:forElement:]):

  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS. Add a new method for
obtaining computed style with :visited info included. This allows layout tests to actually tell that
:visited is in effect.

Reviewed by Oliver Hunt.

  • DumpRenderTree/LayoutTestController.cpp:

(computedStyleIncludingVisitedInfoCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::computedStyleIncludingVisitedInfo):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS

Reviewed by Oliver Hunt.

  • fast/history/clicked-link-is-visited.html: Removed.
  • fast/history/nested-visited-test-expected.txt: Added.
  • fast/history/nested-visited-test.html: Added.
  • fast/history/resources/dummy.html: Added.
  • fast/history/self-is-visited-expected.txt: Added.
  • fast/history/self-is-visited.html: Added.
  • fast/history/sibling-visited-test-expected.txt: Added.
  • fast/history/sibling-visited-test.html: Added.
  • fast/history/subframe-is-visited-expected.txt: Removed.
  • fast/history/subframe-is-visited.html: Removed.
14:09 Changeset [57291] by ojan@chromium.org

2010-04-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Daniel Bates.

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Adds new results for all the tests that started failing after http://trac.webkit.org/changeset/57287.

  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
13:47 Changeset [57290] by dpranke@chromium.org

2010-04-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix trunk (non-standalone) builds for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37136

Test for source files before building instead of relying on
standalone_package config.

  • WebKit.pro:
12:46 Changeset [57289] by dbates@webkit.org

2010-04-08 Daniel Bates <dbates@rim.com>

No review, rolling out 56717.
http://trac.webkit.org/changeset/56717
https://bugs.webkit.org/show_bug.cgi?id=9268

Rolling out the change committed in change set 56717
since we rolled out the change committed in change set 56655,
<http://trac.webkit.org/changeset/56655> (in change set 57287,
<http://trac.webkit.org/changeset/57287>). The change committed
in change set 56655 caused a layout test regression of the some
of the mozilla- and mozilla expected failure- tests. See bug #9268
for more details.

  • platform/qt/fast/table/table-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-background-expected.png: Removed.
  • platform/qt/fast/table/table-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-group-span-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-group-span-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-group-span-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-span-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-span-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-span-background-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-left-50px-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-left-50px-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-left-50px-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-right-50px-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-right-50px-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-right-50px-expected.txt: Removed.
  • platform/qt/fast/table/table-row-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-row-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.png: Removed.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.txt: Removed.
12:42 Changeset [57288] by otte@webkit.org

2010-04-08 Benjamin Otte <otte@gnome.org>

Reviewed by Gustavo Noronha.

Fix build with MathML enabled.

  • GNUmakefile.am:
12:21 Changeset [57287] by dbates@webkit.org

2010-04-08 Daniel Bates <dbates@rim.com>

No review, rolling out 56655.
http://trac.webkit.org/changeset/56655
https://bugs.webkit.org/show_bug.cgi?id=9268

Rolling out the change committed in change set 56655
because it caused a regression in some of the mozilla
and mozilla expected failure test cases, such as:
tables/mozilla/marvin/backgr_simple-table-row.html, and
tables/mozilla/marvin/backgr_simple-table-row-group.html.

We need to look into this issue some more.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.h:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:

2010-04-08 Daniel Bates <dbates@rim.com>

No review, rolling out 56655.
http://trac.webkit.org/changeset/56655
https://bugs.webkit.org/show_bug.cgi?id=9268

Rolling out the change committed in change set 56655
because it caused a regression in some of the mozilla
and mozilla expected failure test cases, such as:
tables/mozilla/marvin/backgr_simple-table-row.html, and
tables/mozilla/marvin/backgr_simple-table-row-group.html.

We need to look into this issue some more.

  • fast/table/table-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-col-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-col-group-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-row-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-row-group-background.html: Removed.
  • fast/table/table-cell-overrides-row-background.html: Removed.
  • fast/table/table-col-background.html: Removed.
  • fast/table/table-col-group-background.html: Removed.
  • fast/table/table-col-group-col-span-background.html: Removed.
  • fast/table/table-col-group-span-background.html: Removed.
  • fast/table/table-col-span-background.html: Removed.
  • fast/table/table-row-background-left-50px.html: Removed.
  • fast/table/table-row-background-right-100percent.html: Removed.
  • fast/table/table-row-background-right-50px.html: Removed.
  • fast/table/table-row-background.html: Removed.
  • fast/table/table-row-group-background-positioned.html: Removed.
  • fast/table/table-row-group-background.html: Removed.
  • platform/mac/fast/table/table-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-background-expected.png: Removed.
  • platform/mac/fast/table/table-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-group-span-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-group-span-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-group-span-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-span-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-span-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-span-background-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-left-50px-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-left-50px-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-left-50px-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-right-50px-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-right-50px-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-right-50px-expected.txt: Removed.
  • platform/mac/fast/table/table-row-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-row-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.png: Removed.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.txt: Removed.
11:40 Changeset [57286] by dumi@chromium.org

Refactor DatabaseTracker, part 1: Remove the dependency on
OriginQuotaManager from DatabaseTracker.h.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31482

  • storage/DatabaseTracker.cpp:

(originQuotaManager):
(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • storage/DatabaseTracker.h:
  • storage/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didExecuteStatement):

11:11 Changeset [57285] by ojan@chromium.org

2010-04-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Dimitri Glazkov.

A couple test expectations cleanups
https://bugs.webkit.org/show_bug.cgi?id=37285

  • platform/chromium/test_expectations.txt:
09:57 BuildBot edited by wsiegrist@apple.com
webkit-dev is a better choice for bot discussions (diff)
09:35 Changeset [57284] by ojan@chromium.org

2010-04-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

Fix http.conf for GTK-Debug and Chromium-Linux bots
https://bugs.webkit.org/show_bug.cgi?id=37279

  • http/conf/apache2-debian-httpd.conf:
09:23 Changeset [57283] by eric@webkit.org

2010-04-08 Kwang Yul Seo <skyul@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Replace max with std::max
https://bugs.webkit.org/show_bug.cgi?id=37201

std::max is preferred.

  • platform/wince/FileSystemWince.cpp: (WebCore::makeAllDirectories): (WebCore::pathGetFileName):
09:08 Changeset [57282] by tonikitoo@webkit.org

[EFL] Move AccessibilityObjectEfl.cpp from page to accessibility
https://bugs.webkit.org/show_bug.cgi?id=36405

Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>

  • accessibility/efl/AccessibilityObjectEfl.cpp: Renamed from WebCore/page/efl/AccessibilityObjectEfl.cpp.

(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

08:57 Changeset [57281] by eric@webkit.org

2010-04-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Warnings when compiling InspectorClientQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=37266

Add a default: for the switch()-case to avoid
warnings.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::variantToSetting):
08:27 Changeset [57280] by pfeldman@chromium.org

2010-04-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Render Load, DOM Content and MarkTimeline event dividers on Timeline panel.

https://bugs.webkit.org/show_bug.cgi?id=37267

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent):
  • inspector/InspectorController.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.removeEventDividers):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._updateMarks): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition): (WebInspector.TimelineRecordGraphRow.prototype.update):
  • inspector/front-end/inspector.css: (.resources-event-divider): (.resources-red-divider): (.resources-blue-divider): (.resources-orange-divider):
08:00 Changeset [57279] by tkent@chromium.org

Unreviewed. Fix a test for the behavior change by r57274.

  • fast/css/pseudo-invalid-novalidate-001.html:
07:43 Changeset [57278] by tonikitoo@webkit.org

2010-04-05 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

[Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
https://bugs.webkit.org/show_bug.cgi?id=29431

Added stubs for Mac, win, gtk and wx DRTs to implement setScrollbarPolicy method.

  • DumpRenderTree/LayoutTestController.cpp: (setScrollbarPolicyCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setScrollbarPolicy):
07:38 Changeset [57277] by tonikitoo@webkit.org

2010-04-01 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by David Hyatt.

[Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
https://bugs.webkit.org/show_bug.cgi?id=29431

Test: fast/overflow/scrollbar-restored-and-then-locked.html

WebCore:

Patch introduces a lock scrollbars concept to ScrollView, as in WebDynamicScrollBarsView.mm/h
on WebKit/mac. It is needed because in QtWebKit, we have Api for setting both vertical and
horizontal scrollbars on/off/auto. When it is set to off, for example, it should remain
as such, unless unset.

For the locking concept, optional 'lock' parameters were added to setScrollbarModes,
setHorizontalScrollbarMode and setVerticalScrollbarMode methods of ScrollView. As these
are all optional, any previous code calling them do not need modification.

Two optional parameters were also added to Frame's createView method, for horizontal and vertical
lock state persistence cross page loads.

  • WebCore.base.exp:
  • page/Frame.cpp: (WebCore::Frame::createView):
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::setScrollbarModes): (WebCore::ScrollView::setHorizontalScrollbarMode): (WebCore::ScrollView::setVerticalScrollbarMode):
  • platform/ScrollView.h: (WebCore::ScrollView::setHorizontalScrollbarLock): (WebCore::ScrollView::isHorizontalScrollbarLocked): (WebCore::ScrollView::setVerticalScrollbarLock): (WebCore::ScrollView::isVerticalScrollbarLocked): (WebCore::ScrollView::setScrollingModesLocked):

WebKit/qt:

Make use of the new lock parameter of set{Vertical,Horizontal}ScrollbarMode.

Always added a qt auto test for set scrollbar policy feature.

  • Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy):
  • tests/qwebframe/tst_qwebframe.cpp:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (FrameLoaderClientQt::transitionToCommittedForNewPage):

WebKitTools:

Make possible to DRT to set scrollbar policies (on, off or auto).

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • QtLauncher/main.cpp: (LauncherWindow::toggleScrollbars): (LauncherWindow::createChrome):

LayoutTests:

  • fast/overflow/scrollbar-restored-and-then-locked-expected.txt: Added.
  • fast/overflow/scrollbar-restored-and-then-locked.html: Added.
07:29 QtWebKitJournal edited by henry.haverinen@nokia.com
(diff)
07:28 Changeset [57276] by yurys@chromium.org

2010-04-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Correctly save number of properties when object being serialized
have properties in its prorotype.

https://bugs.webkit.org/show_bug.cgi?id=37263

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::ZigZag::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::ZigZag::Serializer::AbstractObjectState::advance):

2010-04-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that object with ptototype can be sent as message.

https://bugs.webkit.org/show_bug.cgi?id=37263

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:
07:14 Changeset [57275] by jorlow@chromium.org

2010-04-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Yury Semikhatsky.

IDB callbacks should fire asynchronously
https://bugs.webkit.org/show_bug.cgi?id=37265

Fix the firing behavior of the callbacks to not be synchronous.

There's still a major bug that I'm trying to track down that is keeping
us from testing this stuff. Promise lots of tests ASAP.

  • bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::onSuccessAsync): (WebCore::V8CustomIDBCallbacks::onErrorAsync):
  • storage/IDBCallbacks.h: (WebCore::IDBCallbacks::IDBCallbacks): (WebCore::IDBCallbacks::onSuccess): (WebCore::IDBCallbacks::onError): (WebCore::IDBCallbacks::timerFired):
  • storage/IndexedDatabaseRequest.cpp:
07:10 Changeset [57274] by tkent@chromium.org

willValidate doesn't need to check existence of a form element and a name attribute.
https://bugs.webkit.org/show_bug.cgi?id=34733

Reviewed by Darin Adler.

WebCore:

Remove checks against m_form and m_hasName in
HTMLFormControlElement::willValidate(), and remove the code to
track their updates.

Test: fast/forms/willvalidate.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::insertedIntoTree):
(WebCore::HTMLFormControlElement::removedFromTree):
(WebCore::HTMLFormControlElement::recalcWillValidate):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):

  • html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElement::formDestroyed):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setInputType):

setNeedsWillValidateCheck() should be called before
setAttribute(valueAttr, ...) is called.

LayoutTests:

  • Merge willvalidate-00x tests into one file.
  • Update tests affected by the willValidate behavior change.
  • fast/forms/input-live-pseudo-selectors-expected.txt:
  • fast/forms/resources/input-live-pseudo-selectors.js:
  • fast/forms/resources/textarea-live-pseudo-selectors.js:
  • fast/forms/script-tests/willvalidate.js: Added.
  • fast/forms/textarea-live-pseudo-selectors-expected.txt:
  • fast/forms/willvalidate-000-expected.txt: Removed.
  • fast/forms/willvalidate-000.html: Removed.
  • fast/forms/willvalidate-001-expected.txt: Removed.
  • fast/forms/willvalidate-001.html: Removed.
  • fast/forms/willvalidate-002-expected.txt: Removed.
  • fast/forms/willvalidate-002.html: Removed.
  • fast/forms/willvalidate-003-expected.txt: Removed.
  • fast/forms/willvalidate-003.html: Removed.
  • fast/forms/willvalidate-004-expected.txt: Removed.
  • fast/forms/willvalidate-004.html: Removed.
  • fast/forms/willvalidate-005-expected.txt: Removed.
  • fast/forms/willvalidate-005.html: Removed.
  • fast/forms/willvalidate-006-expected.txt: Removed.
  • fast/forms/willvalidate-006.html: Removed.
  • fast/forms/willvalidate-007-expected.txt: Removed.
  • fast/forms/willvalidate-007.html: Removed.
  • fast/forms/willvalidate-008-expected.txt: Removed.
  • fast/forms/willvalidate-008.html: Removed.
  • fast/forms/willvalidate-009-expected.txt: Removed.
  • fast/forms/willvalidate-009.html: Removed.
  • fast/forms/willvalidate-expected.txt: Added.
  • fast/forms/willvalidate.html: Added.
07:05 Changeset [57273] by eric@webkit.org

2010-04-08 Young Han Lee <joybro@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Add missing headers
https://bugs.webkit.org/show_bug.cgi?id=37199

Include missing headers.

  • platform/graphics/wince/FontCustomPlatformData.cpp:
  • platform/graphics/wince/FontPlatformData.cpp:
  • platform/graphics/wince/GraphicsContextWince.cpp:
  • platform/graphics/wince/ImageBufferWince.cpp:
  • platform/graphics/wince/PlatformPathWince.h:
  • platform/wince/FileSystemWince.cpp:
06:54 Changeset [57272] by eric@webkit.org

2010-04-08 Kwang Yul Seo <skyul@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Use WebCore::instanceHandle()
https://bugs.webkit.org/show_bug.cgi?id=37202

Page::instanceHandle() is moved to WebCore::instanceHandle().

  • platform/wince/PasteboardWince.cpp: (WebCore::Pasteboard::Pasteboard):
  • platform/wince/SharedTimerWince.cpp: (WebCore::initializeOffScreenTimerWindow):
06:44 Changeset [57271] by eric@webkit.org

2010-04-08 Kwang Yul Seo <skyul@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Check if ARM or _ARM_ is defined
https://bugs.webkit.org/show_bug.cgi?id=37200

MSVC defines ARM and _ARM_ for Windows CE ARM. Define WTF_CPU_ARM=1
when either ARM or _ARM_ is defined.

  • wtf/Platform.h:
06:24 Changeset [57270] by eric@webkit.org

2010-04-08 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

[Qt] WebKit crashes while input text through input method.
The formatted text underline painting crashes when painting with invalid indexes.
https://bugs.webkit.org/show_bug.cgi?id=36870

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethodsTextFormat_data): (tst_QWebPage::inputMethodsTextFormat):
05:38 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:15 Changeset [57269] by vitalyr@chromium.org

2010-04-08 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix crash in NodeFilterCondition in detached iframe
https://bugs.webkit.org/show_bug.cgi?id=37234

Test: fast/dom/node-filter-detached-iframe-crash.html

  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): Switched to using callFunctionWithoutFrame.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunctionWithoutFrame): Added a function to call V8 with no current frame.
  • bindings/v8/V8Proxy.h:

2010-04-08 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix crash in NodeFilterCondition in detached iframe
https://bugs.webkit.org/show_bug.cgi?id=37234

  • fast/dom/node-filter-detached-iframe-crash-expected.txt: Added.
  • fast/dom/node-filter-detached-iframe-crash.html: Added.
02:50 Changeset [57268] by eric@webkit.org

2010-04-08 Eric Seidel <eric@webkit.org>

Unreviewed. Update test_expectations to account for tests which fail
when run out of order.

fast/dom/SelectorAPI/dumpNodeList tests fail when run out of order.
https://bugs.webkit.org/show_bug.cgi?id=37259

  • platform/mac/test_expectations.txt:
02:23 Changeset [57267] by eric@webkit.org

2010-04-08 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>

Reviewed by Simon Hausmann.

[Qt] Remove shaderSource manipulation from GraphicsContext3DQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=37226

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::shaderSource):
02:13 Changeset [57266] by eric@webkit.org

2010-04-08 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

[Qt] qtwebkit_webframe_scrollRecursively scrolls when body.style.overflow="hidden"
https://bugs.webkit.org/show_bug.cgi?id=36674

The scrolling check was based on the frameview's scrolloffset, and
maximumScrollPosition, which does not acknowledge the overflow properties.

I am now basing the scrolling off the scrollbar position. The scrollbars are
affected by the overflow properties indicating when not to scroll. The scrollbar
positions also continue to work for CSS ::-webkit-scrollbar styles.

  • Api/qwebframe.cpp: (qtwebkit_webframe_scrollRecursively):
01:59 Changeset [57265] by abarth@webkit.org

2010-04-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should give a percent complete indication
https://bugs.webkit.org/show_bug.cgi?id=37258

Because it's awesome.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
01:26 Changeset [57264] by abarth@webkit.org

2010-04-08 Adam Barth <abarth@webkit.org>

Unreviewed. Update test_expectations to account for some tests that
fail when run out of order.

  • platform/mac/test_expectations.txt:
01:19 Changeset [57263] by eric@webkit.org

2010-04-08 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add test for SVG image with excessive nesting.
https://bugs.webkit.org/show_bug.cgi?id=37247

  • fast/images/svg-nested.html: added
  • fast/images/svg-nested-expected.txt: added

2010-04-08 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Sanity: apply a max node depth to XML parsing.

https://bugs.webkit.org/show_bug.cgi?id=37247

Test: fast/images/svg-nested.html

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode): Error out the parse upon a really large node depth.
01:16 Changeset [57262] by ossy@webkit.org

Reviewed Oliver Hunt.

[Qt]r57240 broke Qt build (might be a gcc bug)
https://bugs.webkit.org/show_bug.cgi?id=37253

Workaround until fix. On PLATFORM(QT) use inline instead of ALWAYS_INLINE.

  • wtf/PassRefPtr.h: Qt guards added.
01:04 Changeset [57261] by abarth@webkit.org

2010-04-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

cross-frame-access-put depends on test ordering
https://bugs.webkit.org/show_bug.cgi?id=37254

If you run the tests in a different order, the value of this property
can change. We just need to avoid printing the actual value.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
00:54 Changeset [57260] by eric@webkit.org

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104

Turns out the CYGWIN also uses Apache 1.3, so can't bind to ::1 either.

  • http/conf/cygwin-httpd.conf:
00:51 Changeset [57259] by scherkus@chromium.org

2010-04-08 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, cleaning up Chromium Mac test expecatations for fast/media.

  • platform/chromium/test_expectations.txt:
00:49 Changeset [57258] by abarth@webkit.org

2010-04-08 Adam Barth <abarth@webkit.org>

Unreviewed.

Add back the --target option because it's needed by the downstream
Chromium bots.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
00:45 Changeset [57257] by abarth@webkit.org

2010-04-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should understand set-webkit-configuration
https://bugs.webkit.org/show_bug.cgi?id=37252

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
00:27 Changeset [57256] by abarth@webkit.org

2010-04-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename target to configuration in new-run-webkit-tests to match the rest of WebKit
https://bugs.webkit.org/show_bug.cgi?id=37251

The rest of our tools call --debug or --release the configuration.
It's confusing to call it target in this script.

  • Scripts/webkitpy/layout_tests/driver_test.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
00:19 Changeset [57255] by scherkus@chromium.org

2010-04-08 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, cleaning up test expectations for fast/media and media/video-played-reset.html.

Previously all of fast/media was marked as PASS FAIL, but now has finer-grained
expectations for all tests.

Due to Chromium-side changes, media/video-played-reset.html is now passing again.

  • platform/chromium/test_expectations.txt:

04/07/10:

23:56 Changeset [57254] by abarth@webkit.org

2010-04-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove depricated op.popen2 call in new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37249

Python complains that this API is depricated. We already solved this
problem in executive.py.

  • Scripts/webkitpy/layout_tests/port/mac.py:
23:55 Changeset [57253] by abarth@webkit.org

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests crashes when run on a 64-bit machine
https://bugs.webkit.org/show_bug.cgi?id=37248

  • Scripts/webkitpy/layout_tests/port/mac.py:
    • The code was trying to always run the 32-bit intel version of the DumpRenderTree binary. DRT does not build 32-bit on 64-bit machines so that makes no sense. This may have made sense for test_shell at some point, but I think we should just remove this for DRT.
23:51 Changeset [57252] by abarth@webkit.org

2010-04-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
https://bugs.webkit.org/show_bug.cgi?id=37145

I think this test might be getting confused because it only expects the
end event to fire once but actually it fires again for the second
transition. Let's try this patch and see if it fixes the flakiness.

  • transitions/transition-end-event-set-none.html:
23:40 QtWebKit edited by henry.haverinen@nokia.com
(diff)
23:13 Changeset [57251] by mjs@apple.com

(Not reviewed.)

Random demo to look cool on twitter.

  • misc/gradient-input.html: Added.
23:03 Changeset [57250] by eric@webkit.org

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104

Apache 1.3 does not support IPv6, so remove the Listen [::1] directive
and add a warning about how that may cause flakiness on systems which
use Apache 1.3, but support IPv6.

  • http/conf/httpd.conf:
22:00 Changeset [57249] by abarth@webkit.org

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104

WebKit Apache configs were only listening on IPv4 loopback (127.0.0.1), however
the system will resolve "localhost." to both IPv4 and IPv6 (::1) loopback
addreses when IPv6 is enabled. Since DNS lookup returns addresses in random
order, we would occasionally fail to make connections to "localhost" addresses
if the various network re-tries all happen to resolve to the IPv6 loopback.

To make matters worse, the kernel has a connection reset throttle which we
could trigger if we would repeatedly attempt to connect to ::1 and fail.
The trottle would cause a 1 or 2 second delay on the connection, sometimes
causing slow tests to time out.

I also discovered during this investigation that we have some partial support
for specifying our apache port numbers at runtime. The support is already incomplete
by not accounting for WebSockets or SSL ports. This fix will make our partial
support for dynamic apache port numbers even more broken.

I've added Listen [::1]:PORT directives for 8000, 8080, and 8443 to all
platforms (except cygwin which does not have the 8443 directive to begin with).

  • http/conf/apache2-debian-httpd.conf:
  • http/conf/apache2-httpd.conf:
  • http/conf/cygwin-httpd.conf:
  • http/conf/fedora-httpd.conf:
  • http/conf/httpd.conf:

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104

Add warnings that the partial support for specifying what port numbers
apache should bind to is even more broken after this fix.

  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
21:35 Changeset [57248] by oliver@apple.com

Vector<UString> makes many needless calls to UString::UString and UString::~UString

Reviewed by Anders Carlsson.

Add a VectorTrait<UString> specialisation to allow vector to simply memset/memcpy
data around. Only difference from the VectorTrait<RefPtr<T> > traits is the inability
to use memset to initialize data.

  • runtime/UString.h:

(WTF::):

21:12 Changeset [57247] by hamaji@chromium.org

2010-04-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

LayoutTestController::m_handlesAuthenticationChallenges isn't initialized
https://bugs.webkit.org/show_bug.cgi?id=37190

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
21:11 Changeset [57246] by mitz@apple.com

Refactor WebHTMLView printing code and add private methods to enter and exit printing mode.
https://bugs.webkit.org/show_bug.cgi?id=37246

Reviewed by Adele Peterson.

  • Misc/WebNSPrintOperationExtras.h: Declared -_web_availablePaperWidth and -_web_availablePaperHeight.
  • Misc/WebNSPrintOperationExtras.m:

(-[NSPrintOperation _web_availablePaperWidth]): Turned -[WebHTMLView _availablePaperWidthForPrintOperation:]
into this method.
(-[NSPrintOperation _web_availablePaperHeight]): Turned -[WebHTMLView _calculatePrintHeight] into this
method.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _isInPrintMode]): Added this accessor.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Added. Moved the code from -knowsPageRange: that
computes the layout widths and enters printing mode into this private method.
(-[WebHTMLView _endPrintMode]): New private method (the old -_endPrintMode has been renamed).
(-[WebHTMLView _scaleFactorForPrintOperation:]): Use -[NSPrintOperation _web_availablePaperWidth].
(-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Renamed -_endPrintMode to this, changed it to call
_endPrintMode.
(-[WebHTMLView _delayedEndPrintMode:]): Updated for rename.
(-[WebHTMLView knowsPageRange:]): Use -_beginPrintModeWithPageWidth:shrintToFit:,
-[NSPrintOperation _web_availablePaperWidth], and -[NSPrintOperation _web_availablePaperHeight]. Updated for
rename.
(-[WebHTMLView beginDocument]): Updated for rename.
(-[WebHTMLView endDocument]): Ditto.

  • WebView/WebHTMLViewPrivate.h: Declared new private methods -_isInPrintMode,

-_beginPrintModeWithPageWidth:shrinkToFit: and -_endPrintMode.

18:18 Changeset [57245] by dumi@chromium.org

Fix Chromium's HTML5 DB support in --single-process mode.
https://bugs.webkit.org/show_bug.cgi?id=37186.

Reviewed by Jeremy Orlow.

Always register and use Chromium's SQLite VFS for
WebSQLDatabases. Keep using the default VFS in all other
cases. This change should allow Chromium to support
WebSQLDatabases in --single-process mode.

Also, cleaning up a bit SQLiteFileSystemChromium and getting rid
of the SQLITE_OPEN_FULLMUTEX flag: we use sqlite DB handles only
on the DB thread, so we don't need multi-threaded support.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open):

  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::openDatabase):

  • platform/sql/SQLiteFileSystem.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp:

(WebCore::SQLiteFileSystem::openDatabase):

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

(WebCore::SQLiteFileSystem::registerSQLiteVFS):

  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:

(WebCore::SQLiteFileSystem::registerSQLiteVFS):

  • storage/Database.cpp:

(WebCore::Database::performOpenAndVerify):

17:38 Changeset [57244] by cmarrin@apple.com

Remove QuartzCoreInterface from the build


No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5).

17:32 Changeset [57243] by ojan@chromium.org

2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57178.
http://trac.webkit.org/changeset/57178
https://bugs.webkit.org/show_bug.cgi?id=37240

Caused chromium browser_test and ui_test regressions
(Requested by ojan on #webkit).

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
16:52 Changeset [57242] by ojan@chromium.org

2010-04-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

New chromium expected results after r57215
https://bugs.webkit.org/show_bug.cgi?id=37239

  • platform/chromium-linux/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/chromium-linux/fast/text/line-breaks-expected.checksum:
  • platform/chromium-linux/fast/text/line-breaks-expected.png:
  • platform/chromium-linux/fast/text/line-breaks-expected.txt: Our new behavior is no more broken than the old behavior. Evan says he'll fix the underlying problem some day.
  • platform/chromium-win/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/chromium-win/fast/repaint/stacked-diacritics-expected.txt: Added. This is a new test. These are just the usual windows vs. mac font rendering differences.
  • platform/chromium/test_expectations.txt:
16:49 Changeset [57241] by abarth@webkit.org

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
https://bugs.webkit.org/show_bug.cgi?id=37235

Tiger's CFNetwork doesn't seem to understand "max-age=-1" so we'll
use "expires=some date in the past" to clear cookies instead.
I've verified that these tests still work on Snow Leopard.

  • http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
  • http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
16:06 Changeset [57240] by oliver@apple.com

Beat gcc with a clue bat -- force inlining of refIfNotNull and derefIfNotNull

Reviewed by Geoff Garen.

  • wtf/PassRefPtr.h:
16:04 Changeset [57239] by jianli@chromium.org

Add the comment and assert that we're generating version 4 random number
based UUIDs.
https://bugs.webkit.org/show_bug.cgi?id=36472

Reviewed by Adam Barth and Dmitry Titov.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

  • platform/UUID.h:
15:59 Changeset [57238] by eric@webkit.org

2010-04-07 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Barth.

Allow white listing access from origin to local origin.
https://bugs.webkit.org/show_bug.cgi?id=37228

This makes it possible to load a local resource from a non local
origin if the access has previously been white listed by calling
SecurityOrigin::whiteListAccessFromOrigin.

  • http/tests/security/local-image-from-remote-whitelisted-expected.txt: Added.
  • http/tests/security/local-image-from-remote-whitelisted.html: Added.

2010-04-07 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Barth.

Allow white listing access from origin to local origin.
https://bugs.webkit.org/show_bug.cgi?id=37228

This makes it possible to load a local resource from a non local
origin if the access has previously been white listed by calling
SecurityOrigin::whiteListAccessFromOrigin.

Test: http/tests/security/local-image-from-remote-whitelisted.html

  • page/OriginAccessEntry.cpp: (WebCore::OriginAccessEntry::OriginAccessEntry): Removed assert that only the http and https protocol are valid.
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canRequest): Use isAccessWhiteListed (WebCore::SecurityOrigin::isAccessWhiteListed): Extracted code that goes through the originAccessMap to do the origin matching. (WebCore::SecurityOrigin::canLoad): Check if access has been white listed.
  • page/SecurityOrigin.h: Add private function isAccessWhiteListed
15:43 Changeset [57237] by eric@webkit.org

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
https://bugs.webkit.org/show_bug.cgi?id=37235

Added a ?clear=1 query parameter to the two "set cookies" cgi scripts
that these tests use, and call it to clear the cookies before leaving the test.

I could not resist the temptation of cleaning up the ridiculously awful copy/paste
in these tests, so the changes are larger than strictly necessary.

  • http/tests/xmlhttprequest/cookies.html:
  • http/tests/xmlhttprequest/cross-origin-cookie-storage.html:
  • http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
  • http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
14:53 Changeset [57236] by eric@webkit.org

2010-04-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

Adding static method zero() to classes IntPoint and FloatPoint.
https://bugs.webkit.org/show_bug.cgi?id=37220

Adding static method zero() to classes IntPoint and FloatPoint as suggested by Darin Adler.

  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::zero):
  • platform/graphics/IntPoint.h: (WebCore::IntPoint::zero): (WebCore::IntPoint::clampNegativeToZero):
14:32 Changeset [57235] by ap@apple.com
  • platform/network/mac/AuthenticationMac.mm: Fix a typo in comment.
14:30 Changeset [57234] by eric@webkit.org

2010-04-07 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

A few tests in fast/canvas/webgl failed randomly on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=37098

  • fast/canvas/webgl/resources/webgl-test.js: Turn off stencil/antialias by default. (create3DContext):
  • fast/canvas/webgl/script-tests/index-validation.js: By default antialias is off.
14:25 Changeset [57233] by ap@apple.com

Fix a typo.

14:25 Changeset [57232] by ap@apple.com

Reviewed by Darinn Adler.

https://bugs.webkit.org/show_bug.cgi?id=37230
<rdar://problem/7813115> REGRESSION (4.0.5): Safari asks for credentials all the time when
authenticating to Windows IIS Server

  • platform/network/ProtectionSpace.h: (WebCore::ProtectionSpaceAuthenticationScheme): Added a constant for ProtectionSpaceAuthenticationSchemeUnknown.
  • platform/network/cf/AuthenticationCF.cpp: (WebCore::core):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::authenticationSchemeFromAuthenticationMethod): Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.
  • platform/network/mac/AuthenticationMac.mm: (WebCore::mac): Support NTLM on systems older than 10.6. We actually get this string from NSURLConnection, even though there was no public constant. (WebCore::core): Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.
14:20 Changeset [57231] by eric@webkit.org

2010-04-07 Jaime Yap <jaimeyap@google.com>

Reviewed by Pavel Feldman.
Tests expectations changed due to the addition of the function symbol name for
the call location for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839

No new tests.

  • inspector/timeline-test.js:
  • platform/chromium-win/inspector/timeline-event-dispatch-expected.txt:
  • platform/chromium-win/inspector/timeline-mark-timeline-expected.txt:
  • platform/chromium-win/inspector/timeline-network-resource-expected.txt:
  • platform/chromium-win/inspector/timeline-paint-expected.txt:
  • platform/chromium-win/inspector/timeline-parse-html-expected.txt:

2010-04-07 Jaime Yap <jaimeyap@google.com>

Reviewed by Pavel Feldman.

Adds the ability to get the function symbol name when looking up the call location
for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839

No new tests.

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
  • bindings/js/ScriptCallStack.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createUtilityContext): (WebCore::ScriptDebugServer::topStackFrame):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::utilityContext):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
14:10 Changeset [57230] by eric@webkit.org

2010-04-07 Jay Civelli <jcivelli@chromium.org>

Reviewed by Jian Li.

[chromium] Add test for a popup related crasher.
https://bugs.webkit.org/show_bug.cgi?id=37141

  • platform/chromium/fast/forms: Added.
  • platform/chromium/fast/forms/search-popup-crasher-expected.txt: Added.
  • platform/chromium/fast/forms/search-popup-crasher.html: Added.

2010-04-07 Jay Civelli <jcivelli@chromium.org>

Reviewed by Jian Li.

[chromium] Fixing a NULL pointer being dereferenced in some cases.
https://bugs.webkit.org/show_bug.cgi?id=37141

Test: platform/chromium/fast/forms/search-popup-crasher.html

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenu::~PopupMenu):
13:47 Changeset [57229] by jianli@chromium.org

Add skeleton FileStream module for providing sync file operations for FileAPI
https://bugs.webkit.org/show_bug.cgi?id=37217

Patch by Kinuko Yasuda <kinuko@chromium.org> on 2010-04-07
Reviewed by Jian Li.

For now the module just defines an interface and is almost empty.
Implementation will be added.

No new tests; will be added when we have complete implementation.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/FileStream.cpp: Added.
  • html/FileStream.h: Added.
  • html/FileStreamClient.h: Added.
  • html/FileThread.cpp:

(WebCore::SameFilePredicate::SameFilePredicate):
(WebCore::SameFilePredicate::operator()):
(WebCore::FileThread::unscheduleTasks):

  • html/FileThread.h:

(WebCore::FileThread::Task::stream):
(WebCore::FileThread::Task::Task):

13:44 Changeset [57228] by ossy@webkit.org

Rubber-stamped by Kenneth Rohde Christiansen.

Poor rendering on lala.com with frame flattening
https://bugs.webkit.org/show_bug.cgi?id=37164

Platform specific expected files added for test introduced in r57225.

  • platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
13:37 Changeset [57227] by oliver@apple.com

2010-04-07 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Remove some unnecessary uses of commonJSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=37229

Pass the ExecState down to identifierFromNPIdentifier and update call sites

  • bridge/NP_jsobject.cpp: (_NPN_Invoke): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::getPropertyNames):
  • bridge/c/c_utility.cpp: (JSC::Bindings::identifierFromNPIdentifier):
  • bridge/c/c_utility.h:
13:32 Changeset [57226] by eric@webkit.org

2010-04-07 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Replace isprint with isASCIIPrintable
https://bugs.webkit.org/show_bug.cgi?id=37223

WebKit does not use functions in <ctype.h> as they are dependent on the current
locale. Use the equivalent functions in <wtf/ASCIICType.h>. isASCIIPrintable
replaces isprint.

  • pcre/pcre_exec.cpp: (pchars):
13:22 Changeset [57225] by eric@webkit.org

2010-04-07 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Darin Adler.

Poor rendering on lala.com with frame flattening
https://bugs.webkit.org/show_bug.cgi?id=37164

Do not flatten offscreen iframes.

Test: fast/frames/flattening/iframe-flattening-offscreen.html

  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::flattenFrame):
  • rendering/RenderPartObject.h:
12:57 BuildBot edited by wsiegrist@apple.com
update contact and port (diff)
12:49 Changeset [57224] by abarth@webkit.org

2010-04-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Make sure that calling bindings constructors as function does not result in crash.

  • fast/constructors: Added.
  • fast/constructors/constructor-as-function-crash-expected.txt: Added.
  • fast/constructors/constructor-as-function-crash.html: Added.

2010-04-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

[V8] Add a missing check for constructor call in WebKitPointConstructor.
https://bugs.webkit.org/show_bug.cgi?id=37210

Test: fast/constructors/constructor-as-function-crash.html

  • bindings/v8/custom/V8WebKitPointConstructor.cpp: (WebCore::V8WebKitPoint::constructorCallback): Added a check for constructor call.
12:17 Changeset [57223] by ojan@chromium.org

2010-04-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Simon Fraser.

Make tests pass with tolerance=0 after r57215
https://bugs.webkit.org/show_bug.cgi?id=37225

  • platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
  • platform/mac/fast/repaint/stacked-diacritics-expected.png:
11:54 Changeset [57222] by scherkus@chromium.org

2010-04-07 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, skipping fast/media/media-feature-wgt-view-mode.html for Chromium.

Chromium doesn't implement layoutTestController.setViewModeMediaFeature(), which is needed
to pass this layout test.

  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Removed.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Removed.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Skip fast/media/media-feature-wgt-view-mode.html.
11:44 Changeset [57221] by enrica@apple.com

Fixing TIGER build (take 2)

11:16 Changeset [57220] by pfeldman@chromium.org

2010-04-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: support themes in devtools window.

https://bugs.webkit.org/attachment.cgi?bugid=37216

  • WebKit.gypi:
  • src/js/DevTools.js: (WebInspector.setToolbarColors): (WebInspector.resetToolbarColors):
  • src/js/Images/segmentChromium2.png: Added.
  • src/js/Images/segmentHoverChromium2.png: Added.
  • src/js/Images/segmentSelectedChromium2.png: Added.
  • src/js/Images/statusbarBackgroundChromium2.png: Added.
  • src/js/Images/statusbarMenuButtonChromium2.png: Added.
11:12 Changeset [57219] by scherkus@chromium.org

2010-04-07 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in missing image baselines for fast/layers/video-layer.html

  • platform/chromium-linux/fast/layers/video-layer-expected.checksum: Added.
  • platform/chromium-linux/fast/layers/video-layer-expected.png: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.checksum: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.png: Added.
  • platform/chromium-win/fast/layers/video-layer-expected.checksum: Updated.
  • platform/chromium-win/fast/layers/video-layer-expected.png: Updated.
10:59 Changeset [57218] by enrica@apple.com

https://bugs.webkit.org/show_bug.cgi?id=37219

Reviewed by Darin Adler.

JavaScriptCore:

This change disables text caret for the iPhone platflorm.

  • wtf/Platform.h: Disabled text caret for iPhone.

WebCore:

This change disables text caret for the iPhone platflorm.
Added UNUSED_PARAM to build when ENABLE_TEXT_CARET is 0.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::paintCaret):

  • page/Frame.cpp:

(WebCore::Frame::paintDragCaret):

10:57 Changeset [57217] by enrica@apple.com

Fixing TIGER build

10:06 Changeset [57216] by enrica@apple.com

Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

  • fast/repaint/stacked-diacritics.html: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.
10:01 Changeset [57215] by enrica@apple.com

WebCore: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

In order to be able to handle successfully this case, it is necessary to change the glyph width cache to store
the bounding box for the glyph instead of the simply caching the glyph width.
Retrieving the bounding box for the glyph is expensive, therefore we do it only
when we are rendering text using the complex text path to minimize the performance impact.
To support characters with stacked diacritics, the method canUseGlyphCache has been modified to
return false for the range of characters with stacked diacritics.
The glyph cache has been also updated to allow storing the glyph bounding box together with the
horizontal width. The bounding box is populated only for complex text.

The original version of this patch has been written by Dan Bernstein.

Test: fast/repaint/stacked-diacritics.html

  • Android.mk: File name change.
  • GNUmakefile.am: File name change.
  • WebCore.base.exp: Added parameter in exported function.
  • WebCore.gypi: File name change.
  • WebCore.vcproj/WebCore.vcproj: File name change.
  • WebCore.xcodeproj/project.pbxproj: File name change.
  • platform/graphics/Font.cpp:

(WebCore::Font::floatWidth): Added glyphOverflow parameter.

  • platform/graphics/Font.h:

(WebCore::GlyphOverflow::GlyphOverflow): Added.
(WebCore::Font::width): Added glyphOverflow parameter.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::canUseGlyphCache): Modified to render characters with stacked diacritics with complex text path.

  • platform/graphics/GlyphMetricsMap.cpp: Copied from WebCore/platform/graphics/GlyphWidthMap.cpp.

(WebCore::GlyphMetricsMap::locatePageSlowCase): Class name changed to reflect new semantics.

  • platform/graphics/GlyphMetricsMap.h: Copied from WebCore/platform/graphics/GlyphWidthMap.h.

(WebCore::GlyphMetricsMap::GlyphMetricsMap):
(WebCore::GlyphMetricsMap::~GlyphMetricsMap):
(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::widthForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
(WebCore::GlyphMetricsMap::locatePage):

  • platform/graphics/GlyphWidthMap.cpp: Removed.
  • platform/graphics/GlyphWidthMap.h: Removed.
  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit):

  • platform/graphics/SimpleFontData.h:

(WebCore::):
(WebCore::SimpleFontData::widthForGlyph):
(WebCore::SimpleFontData::metricsForGlyph):

  • platform/graphics/cairo/SimpleFontDataCairo.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/chromium/FontLinux.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::platformWidthForGlyph): Name and signature vachange

  • platform/graphics/efl/FontEfl.cpp:

(WebCore::Font::floatWidthForComplexText): Name and signature change.

  • platform/graphics/gtk/SimpleFontDataPango.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/haiku/FontHaiku.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/haiku/SimpleFontDataHaiku.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::minGlyphBoundingBoxX):
(WebCore::ComplexTextController::maxGlyphBoundingBoxX):
(WebCore::ComplexTextController::minGlyphBoundingBoxY):
(WebCore::ComplexTextController::maxGlyphBoundingBoxY):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::floatWidthForComplexText): Added paramter.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText): Added paramter.

  • platform/graphics/win/FontWin.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::metricsForGDIGlyph):

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/graphics/win/UniscribeController.h:

(WebCore::UniscribeController::minGlyphBoundingBoxX):
(WebCore::UniscribeController::maxGlyphBoundingBoxX):
(WebCore::UniscribeController::minGlyphBoundingBoxY):
(WebCore::UniscribeController::maxGlyphBoundingBoxY):

  • platform/graphics/wince/FontWince.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/wx/FontWx.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::computeVerticalOverflow):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::setFallbackFonts):
(WebCore::InlineTextBox::fallbackFonts):
(WebCore::InlineTextBox::setGlyphOverflow):
(WebCore::InlineTextBox::glyphOverflow):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::clearGlyphOverflowAndFallbackFontMap): Added.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::calcPrefWidths):
(WebCore::RenderText::setText):
(WebCore::RenderText::width):

  • rendering/RenderText.h:

LayoutTests: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

  • fast/repaint/stacked-diacritics.html: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.
09:53 Changeset [57214] by eric@webkit.org

2010-04-07 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Darin Adler.

Fix incorrect white-space in WebGLRenderingContext.idl
https://bugs.webkit.org/show_bug.cgi?id=31339

  • html/canvas/WebGLRenderingContext.idl: Remove offending extra whitespace.
09:43 Changeset [57213] by eric@webkit.org

2010-04-07 Rodrigo Belem <rodrigo.belem@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] The build system is not installing the generated headers (QGraphicsWebView, QWebDatabase, etc)
https://bugs.webkit.org/show_bug.cgi?id=37173

This patch sets the correct path to the classheaders.pri and then
fixes the installation of the generated headers.

  • WebCore.pro:
09:33 Changeset [57212] by eric@webkit.org

2010-04-07 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add ewk_view (the high level object to acces the WebKit-EFL browser
component) to efl/ewk.
http://webkit.org/b/35932

  • efl/ewk/ewk_view.cpp: Added.
  • efl/ewk/ewk_view.h: Added.
09:32 Changeset [57211] by tonikitoo@webkit.org

Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable https://bugs.webkit.org/show_bug.cgi?id=37135

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

It happens, for example, when distanceDataForNode assigns numeric_limits<long long> to
current focus candidate's. It means that current candidate is not in direction, or not
a valid target node.

  • page/FocusController.cpp:

(WebCore::FocusController::findFocusableNodeInDirection):

09:18 Changeset [57210] by eric@webkit.org

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed inspector methods from ScriptExecutionContext and derived classes.
Removed MessageDestination parameter from console-related calls (we now always
log to the same destination(s)).
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoadNotifier.cpp:
  • loader/ResourceLoadNotifier.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::appendToBuffer):
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::postConsoleMessageTask): (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts): (WebCore::WorkerContext::addMessage):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:
  • xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): (WebCore::XMLHttpRequest::didFinishLoading):

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed inspector methods from ScriptExecutionContext and derived classes.
Removed MessageDestination parameter from console-related calls (we now always
log to the same destination(s)).
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject): (WebKit::WebWorkerBase::postConsoleMessageTask):
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask):
  • src/WebWorkerClientImpl.h:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/FrameLoaderClientQt.cpp:
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebKitSupport/FrameLoaderClientWx.cpp:
  • WebKitSupport/FrameLoaderClientWx.h:
08:52 Changeset [57209] by jorlow@chromium.org

2010-04-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] WebIDBDatabaseError::assign doesn't work correctly
https://bugs.webkit.org/show_bug.cgi?id=37209

  • src/WebIDBDatabaseError.cpp: (WebKit::WebIDBDatabaseError::assign):
07:14 Changeset [57208] by hausmann@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=36827

Patch by Dawit Alemayehu <adawit@kde.org> on 2010-04-07
Reviewed by Simon Hausmann.

WebCore:

Replaced the 'shouldTreatAsAttachment' function with a more generic
function that returns the content disposition type.

See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395

  • platform/network/HTTPParsers.cpp:

(WebCore::contentDispositionType):

  • platform/network/HTTPParsers.h:

(WebCore::):

WebKit/chromium:

Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.

See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):

WebKit/qt:

Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.

See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):

07:04 Changeset [57207] by vitalyr@chromium.org

2010-04-07 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Yury Semikhatsky.

[V8] Throw exception in SerializedScriptValue on input errors
https://bugs.webkit.org/show_bug.cgi?id=37160

When cycles are detected SerializedScriptValue should throw
NOT_SUPPORTED_ERR. See
http://www.whatwg.org/specs/web-apps/2009-10-27/multipage/urls.html#structured-clone

  • bindings/scripts/CodeGeneratorV8.pm: Custom processing for function arguments of type SerializedScriptValue.
  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::create): Added a constructor function with an extra paratemer to check whether an exception was thrown.

SerializedScriptValue::create callers updated to check for
exceptions:

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::postMessageCallback):
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: (WebCore::V8DedicatedWorkerContext::postMessageCallback):
  • bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::pushStateCallback): (WebCore::V8History::replaceStateCallback):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::V8MessagePort::postMessageCallback):
  • bindings/v8/custom/V8PopStateEventCustom.cpp: (WebCore::V8PopStateEvent::initPopStateEventCallback):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::postMessageCallback):
06:10 Changeset [57206] by apavlov@chromium.org

2010-04-07 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Provide a placeholder for resources with no content available
https://bugs.webkit.org/show_bug.cgi?id=37142

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ImageView.js: (WebInspector.ImageView): (WebInspector.ImageView.prototype.contentTabSelected):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab): (WebInspector.ResourceView.prototype.contentTabSelected):
  • inspector/front-end/inspector.css: (.resource-content-unavailable):
05:48 Changeset [57205] by hausmann@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=36750

Reviewed by Laszlo Gombos.

[Qt] Package build without touch support is broken

Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.

  • dom/Document.idl: Use conditional instead of #ifdef.
  • dom/Element.idl: Ditto.
  • page/DOMWindow.idl: Ditto.
05:03 Changeset [57204] by hausmann@webkit.org

Add the touch event related IDL files to the idl generation, so that
they can be safely included from generated JS bindings files. The
generated files have #ifdef feature guards.

Reviewed by Holger Freyther.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
04:39 Changeset [57203] by jorlow@chromium.org

2010-04-06 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

V8CustomIDBCallbacks<> should not hold a reference to the frame
https://bugs.webkit.org/show_bug.cgi?id=37154

Don't hold on to a Frame reference.
Instead, be an ActiveDOMObject and use scriptExecutionContext()
to get the v8 context.
Factor the guts of onSuccess and onError out.

Doesn't work enough to test yet.

  • bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::create): (WebCore::V8CustomIDBCallbacks::onSuccess): (WebCore::V8CustomIDBCallbacks::onError): (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks): (WebCore::V8CustomIDBCallbacks::onEvent):
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
  • storage/IDBCallbacks.h: (WebCore::IDBCallbacks::IDBCallbacks):
04:14 Changeset [57202] by eric@webkit.org

2010-04-07 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] When providing a widget for the PDF mime type it will cause a crash

m_pluginView may actually be a Widget (for embedded Qt widgets),
so always check isPluginView() before calling PluginView specific methods.

https://bugs.webkit.org/show_bug.cgi?id=29450

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad):
03:19 Changeset [57201] by eric@webkit.org

2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57196.
http://trac.webkit.org/changeset/57196
https://bugs.webkit.org/show_bug.cgi?id=37196

Multiple layout test failures on Chromium (Requested by yurys
on #webkit).

  • inspector/timeline-test.js:

2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57196.
http://trac.webkit.org/changeset/57196
https://bugs.webkit.org/show_bug.cgi?id=37196

Multiple layout test failures on Chromium (Requested by yurys
on #webkit).

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
  • bindings/js/ScriptCallStack.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptDebugServer.cpp:
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createUtilityContext): (WebCore::V8Proxy::sourceLineNumber): (WebCore::V8Proxy::sourceName):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::utilityContext):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
03:07 QtWebKitTriageRoster edited by ossy@webkit.org
(diff)
02:19 Changeset [57200] by hausmann@webkit.org

Unreviewed, rolling out r57199.
http://trac.webkit.org/changeset/57199
https://bugs.webkit.org/show_bug.cgi?id=36750

Breaks non-touch enabled build

  • dom/Document.idl:
  • dom/Element.idl:
  • page/DOMWindow.idl:
02:08 Changeset [57199] by hausmann@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=36750

Reviewed by Laszlo Gombos.

[Qt] Package build without touch support is broken

Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.

  • dom/Document.idl: Use conditional instead of #ifdef.
  • dom/Element.idl: Ditto.
  • page/DOMWindow.idl: Ditto.
01:15 Changeset [57198] by eric@webkit.org

2010-04-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix trunk (non-standalone) builds for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37136

Test for source files before building instead of relying on
standalone_package config.

  • WebKit.pro:
00:39 Changeset [57197] by eric@webkit.org

2010-04-07 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

Add createApplicationCacheHost to WebFrameClient so
the ApplicationCacheHost has access to its frame.

https://bugs.webkit.org/show_bug.cgi?id=36882

  • public/WebFrameClient.h: (WebKit::WebFrameClient::createApplicationCacheHost):
  • src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
00:20 Changeset [57196] by eric@webkit.org

2010-04-07 Jaime Yap <jaimeyap@google.com>

Reviewed by Yury Semikhatsky.

Adds callerFuncName to the list of nondeterministic fields in the timeline
layout tests.
https://bugs.webkit.org/show_bug.cgi?id=36839

  • inspector/timeline-test.js:

2010-04-07 Jaime Yap <jaimeyap@google.com>

Reviewed by Yury Semikhatsky.

Adds the ability to get the function symbol name when looking up the call location
for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839

No new tests.

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
  • bindings/js/ScriptCallStack.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createUtilityContext): (WebCore::ScriptDebugServer::lastCallFrame):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::utilityContext):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):

04/06/10:

23:40 Changeset [57195] by eric@webkit.org

2010-03-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add webkit-patch command to crawl buildbot history and find when tests
started to fail.
https://bugs.webkit.org/show_bug.cgi?id=36911

This is a very bare-bones implementation, which works, but isn't pretty.
We will need further re-factoring and improvement to this code, but
after long discussions with Adam, I think it's best that we land this
and iterate from there.

  • Scripts/webkitpy/common/net/buildbot.py:
    • Add revision_build_pairs_with_results for cleaner code and possible optimization of this command.
    • Return None if a build number can't be found for a revision in build_for_revision
    • Separate out suspect_revisions_for_transition for re-use by FailureReason
    • Add LayoutTestResults.failing_tests() and make our parsing code explict about what tables it accepts.
  • Scripts/webkitpy/tool/commands/queries.py:
    • Move _print_blame_information_for_commit out of WhatBroke for re-use by FailureReason.
    • Add FailureReason command which can crawl a given builder and explain why it is currently red on a per-test basis.
22:14 Changeset [57194] by bolsinga@apple.com

https://bugs.webkit.org/show_bug.cgi?id=37188
WebCore::page::Geolocation::m_shouldClearCache is not used.

Reviewed by Darin Adler.

  • page/Geolocation.cpp:

(WebCore::Geolocation::Geolocation): Remove m_shouldClearCache.

  • page/Geolocation.h:

(WebCore::Geolocation::): Ditto.

21:58 Changeset [57193] by eric@webkit.org

2010-04-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Remove obsolete MOBILE flag
https://bugs.webkit.org/show_bug.cgi?id=37125

The MOBILE flag is no longer used by any of the ports.
The flag use to control some tokenizer defaults that
can be changed runtime.

No new tests as there is no new functionality.

  • config.h:
  • html/HTMLTokenizer.cpp:
21:38 Changeset [57192] by eric@webkit.org

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646

Add a new exception type for forcibly terminating a JavaScript stack.
The new exception functions similarly to the
InterruptedExecutionException but is conceptually different because
execution is terminated instead of just interrupted.

  • GNUmakefile.am:
    • Added new Terminator.h file.
  • JavaScriptCore.gypi:
    • Added new Terminator.h file.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
    • Added new Terminator.h file.
  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Added new Terminator.h file.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::throwException):
    • Fully unwind the stack for TerminatedExecutionException.

(JSC::Interpreter::privateExecute):

  • Check if we've been terminated at the same time we check if we've timed out.
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
    • Check if we've been terminated at the same time we check if we've timed out.
  • runtime/Completion.cpp:
    • Some exceptions define special completion types so that calls can see why we terminated evaluation.

(JSC::evaluate):

  • runtime/Completion.h:
    • Define a new completion type for termination.

(JSC::):

  • runtime/ExceptionHelpers.cpp:
    • Define TerminatedExecutionException and refactor pseudo-RTTI virtual function to be more semantic.

(JSC::InterruptedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::exceptionType):
(JSC::TerminatedExecutionError::toString):
(JSC::createTerminatedExecutionException):

  • runtime/ExceptionHelpers.h:
    • Entry point for generating a TerminatedExecutionException.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
    • Add a Terminator object that can be used to asynchronously terminate a JavaScript execution stack.
  • runtime/JSGlobalData.h:
  • runtime/JSObject.h: (JSC::JSObject::exceptionType):
    • Define that, by default, thrown objects have a normal exception type.
  • runtime/Terminator.h: Added.
    • Added a new controller object that can be used to terminate execution asynchronously. This object is more or less a glorified bool.

(JSC::Terminator::Terminator):
(JSC::Terminator::termianteSoon):
(JSC::Terminator::shouldTerminate):

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646

  • fast/workers/resources/worker-run-forever.js: Added.
  • fast/workers/worker-terminate-forever-expected.txt: Added.
  • fast/workers/worker-terminate-forever.html: Added.
    • Test what happens when we terminate an infinitely running worker. The essential point is that we don't spam the console with nonsense about a timeout.
  • platform/mac/Skipped:
    • Rescue worker-terminate.html from the Skipped list now that we've fixed the underlying bug that was causing the flakiness.

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: Worker termination via JS timeout may cause worker tests like fast/workers/worker-terminate.html fail.
https://bugs.webkit.org/show_bug.cgi?id=36646

Cause the worker code to swallow termination exceptions because these
need not be reported to the user because they are an implementation
detail of how we terminate worker execution.

Test: fast/workers/worker-terminate-forever.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::reportException):
    • Refuse to report termination exceptions to the user because they are an implementation detail.
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::forbidExecution):
    • Instead of using timeouts to stop run away workers, use our fancy new Terminator object.
21:17 Changeset [57191] by eric@webkit.org

2010-04-06 Andrew Scherkus <scherkus@chromium.org>

Reviewed by Eric Seidel.

Checking in new baselines for media/video-controls-rendering.html and fast/layers/video-layer.html.
https://bugs.webkit.org/show_bug.cgi?id=37180

  • platform/chromium-linux/media/video-controls-rendering-expected.checksum: Wasn't rebaselined when Linux scrollbars changed.
  • platform/chromium-linux/media/video-controls-rendering-expected.png: Ditto.
  • platform/chromium-mac/fast/layers/video-layer-expected.txt: Wasn't rebaselined when audio/video UI was refreshed.
  • platform/chromium-win/fast/layers/video-layer-expected.txt: Ditto.
  • platform/chromium/test_expectations.txt: Removed expectations for the above two tests.
20:10 Changeset [57190] by mitz@apple.com

Tiger build fix after r57184.

  • WebView/WebHTMLViewPrivate.h:
19:54 Changeset [57189] by mitz@apple.com

Tiger build fix after r57184.

  • WebView/WebHTMLViewPrivate.h:
19:39 Changeset [57188] by tkent@chromium.org

2010-04-06 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add DumpRenderTree.gyp, and some small fixes
https://bugs.webkit.org/show_bug.cgi?id=37137

  • Add DumpRenderTree.gyp
  • Remove some dependencies to base/string_util.h, base/compiler_specific.h, base/file_path.h, base/file_util.h, base/message_loop.h, base/sys_string_conversions.h,
  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Added.
  • DumpRenderTree/chromium/CppVariant.cpp: (CppVariant::toStringVector):
  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::keyDown): (EventSender::scheduleAsynchronousClick): (EventSender::beginDragWithFiles):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::pathToLocalResource):
  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::markedRange): (TextInputController::selectedRange):
19:33 Changeset [57187] by dpranke@chromium.org

2010-04-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Write stack traces into the results directory for new-run-webkit-tests,
instead of writing them alongside the test file.

https://bugs.webkit.org/show_bug.cgi?id=36504

  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
19:29 Changeset [57186] by abarth@webkit.org

2010-04-06 Adam Barth <abarth@webkit.org>

Unreviewed.

Speculative build fix for Tiger.

  • WebView/WebHTMLViewPrivate.h:
19:27 Changeset [57185] by dpranke@chromium.org

2010-04-06 Dirk Pranke <dpranke@chromium.org>

Unreviewed build fix.

Enable pixel tests by default in new-run-webkit-tests unless
explicitly set by the port or by the command line. This was broken in
the fix for bug 36801 (rev. 57173).

https://bugs.webkit.org/show_bug.cgi?id=37184

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18:53 Changeset [57184] by mitz@apple.com

Expose WebHTMLView’s page breaking logic as SPI.

Reviewed by Sam Weinig and Anders Carlsson.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]): Factored out of -adjustPageHeightNew:top:bottom:limit:
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Call -_adjustedBottomOfPageWithTop:bottom:limit:

  • WebView/WebHTMLViewPrivate.h: Declared -_adjustedBottomOfPageWithTop:bottom:limit:
18:40 Changeset [57183] by mrowe@apple.com

Add an #if in order to make Tiger happy.

  • WebView/WebViewData.mm:

(-[WebViewPrivate init]):

18:29 Changeset [57182] by eric@webkit.org

2010-04-06 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Add basic FileSystem operations for FileReader/FileWriter support for POSIX (incl. Mac)
https://bugs.webkit.org/show_bug.cgi?id=36938

No new tests; will be added when we implement upper layers.

  • platform/FileSystem.h: (WebCore::):
  • platform/posix/FileSystemPOSIX.cpp: (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::writeToFile): (WebCore::readFromFile):
18:15 Changeset [57181] by mrowe@apple.com

Build fix.

  • WebView/WebViewData.mm:

(-[WebViewPrivate init]): Use objc_collectingEnabled like we do elsewhere in WebKit.

18:02 Changeset [57180] by eric@webkit.org

2010-04-06 Nicolas Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Implement DragImage functionality for chromium/mac.
https://bugs.webkit.org/show_bug.cgi?id=37069

  • page/chromium/DragControllerChromium.cpp: (WebCore::DragController::maxDragImageSize): Use a max size of 400x400 on OS X.
  • platform/chromium/DragImageChromiumMac.cpp: (WebCore::dragImageSize): Implement. (WebCore::deleteDragImage): Implement. (WebCore::scaleDragImage): Implement. (WebCore::dissolveDragImageToFraction): Implement. (WebCore::createDragImageFromImage): Implement.
  • platform/chromium/DragImageRef.h: Use CGImageRefs as DragImageRef on OS X.

2010-04-06 Nicolas Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Use drag images on OS X as well.
https://bugs.webkit.org/show_bug.cgi?id=37069

  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
16:37 Changeset [57179] by mrowe@apple.com

REGRESSION (r57113): editing/inserting/break-blockquote-after-delete.html fails on Windows
<http://webkit.org/b/37156> / <rdar://problem/7832408>

Rubber-stamped by Oliver Hunt.

Land Windows-specific results for editing/inserting/break-blockquote-after-delete.html. <rdar://problem/7834280>
tracks understanding the root cause of this difference between Mac and Windows.

  • platform/win/editing/inserting/break-blockquote-after-delete-expected.checksum: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.checksum.
  • platform/win/editing/inserting/break-blockquote-after-delete-expected.png: Copied from LayoutTests/platform/mac/editing/inserting/break-blockquote-after-delete-expected.png.
  • platform/win/editing/inserting/break-blockquote-after-delete-expected.txt: Copied from LayoutTests/platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt.
16:36 Changeset [57178] by eric@webkit.org

2010-04-06 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add test for javascript:window.open() popup blocker bypass.
https://bugs.webkit.org/show_bug.cgi?id=37138

  • fast/events/popup-blocked-from-window-open.html: added
  • fast/events/popup-blocked-from-window-open-expected.txt: added

2010-04-06 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Use the new UserGestureIndictor to process javascript:window.open()

https://bugs.webkit.org/show_bug.cgi?id=37138

  • bindings/v8/ScriptController.cpp (WebCore::ScriptController::processingUserGesture): Use the new UserGestureIndicator when processing a javascript:window.open()
16:27 Changeset [57177] by eric@webkit.org

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
https://bugs.webkit.org/show_bug.cgi?id=37145

The timeout on this test is wrong because the helper library assumes
that we're only going to do one transition, but the test actually does
two in sequence. This patch doubles the timeout to account for that.

The design of these tests are quite unfortunate because these timeout
behaviors don't seem like they'd be reliable on slow machines like
Tiger. I'm not 100% convinced that this will fix the flakiness, but it
seems like an improvement.

I'll file a separate bug about DRT leaking state from one test to
another.

  • transitions/transition-end-event-helpers.js:
  • transitions/transition-end-event-set-none.html:
16:17 Changeset [57176] by eric@webkit.org

2010-04-06 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Renaming Graphics Layer related classes used by Chromium from *Skia to *Chromium and replacing wherever possible Skia-specific
data types with WebCore equivalents. The source files will be renamed accordingly and moved out of platform/graphics/skia
in a subsequent CL.
https://bugs.webkit.org/show_bug.cgi?id=37116

No new functionality so no new tests.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/skia/GraphicsLayerSkia.cpp: (WebCore::setLayerBorderColor): (WebCore::clearBorderColor): (WebCore::setLayerBackgroundColor): (WebCore::clearLayerBackgroundColor): (WebCore::GraphicsLayer::create): (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::setName): (WebCore::GraphicsLayerChromium::nativeLayer): (WebCore::GraphicsLayerChromium::setChildren): (WebCore::GraphicsLayerChromium::addChild): (WebCore::GraphicsLayerChromium::addChildAtIndex): (WebCore::GraphicsLayerChromium::addChildBelow): (WebCore::GraphicsLayerChromium::addChildAbove): (WebCore::GraphicsLayerChromium::replaceChild): (WebCore::GraphicsLayerChromium::removeFromParent): (WebCore::GraphicsLayerChromium::setPosition): (WebCore::GraphicsLayerChromium::setAnchorPoint): (WebCore::GraphicsLayerChromium::setSize): (WebCore::GraphicsLayerChromium::setTransform): (WebCore::GraphicsLayerChromium::setChildrenTransform): (WebCore::GraphicsLayerChromium::setPreserves3D): (WebCore::GraphicsLayerChromium::setMasksToBounds): (WebCore::GraphicsLayerChromium::setDrawsContent): (WebCore::GraphicsLayerChromium::setBackgroundColor): (WebCore::GraphicsLayerChromium::clearBackgroundColor): (WebCore::GraphicsLayerChromium::setContentsOpaque): (WebCore::GraphicsLayerChromium::setBackfaceVisibility): (WebCore::GraphicsLayerChromium::setOpacity): (WebCore::GraphicsLayerChromium::setNeedsDisplay): (WebCore::GraphicsLayerChromium::setNeedsDisplayInRect): (WebCore::GraphicsLayerChromium::setContentsRect): (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::setContentsToVideo): (WebCore::GraphicsLayerChromium::setGeometryOrientation): (WebCore::GraphicsLayerChromium::hostLayerForSublayers): (WebCore::GraphicsLayerChromium::layerForSuperlayer): (WebCore::GraphicsLayerChromium::platformLayer): (WebCore::GraphicsLayerChromium::setDebugBackgroundColor): (WebCore::GraphicsLayerChromium::setDebugBorder): (WebCore::GraphicsLayerChromium::updateSublayerList): (WebCore::GraphicsLayerChromium::updateLayerPosition): (WebCore::GraphicsLayerChromium::updateLayerSize): (WebCore::GraphicsLayerChromium::updateAnchorPoint): (WebCore::GraphicsLayerChromium::updateTransform): (WebCore::GraphicsLayerChromium::updateChildrenTransform): (WebCore::GraphicsLayerChromium::updateMasksToBounds): (WebCore::GraphicsLayerChromium::updateContentsOpaque): (WebCore::GraphicsLayerChromium::updateBackfaceVisibility): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D): (WebCore::GraphicsLayerChromium::updateLayerDrawsContent): (WebCore::GraphicsLayerChromium::updateLayerBackgroundColor): (WebCore::GraphicsLayerChromium::updateContentsImage): (WebCore::GraphicsLayerChromium::updateContentsVideo): (WebCore::GraphicsLayerChromium::updateContentsRect): (WebCore::GraphicsLayerChromium::updateGeometryOrientation): (WebCore::GraphicsLayerChromium::setupContentsLayer): (WebCore::GraphicsLayerChromium::updateOpacityOnLayer):
  • platform/graphics/skia/GraphicsLayerSkia.h: (WebCore::GraphicsLayerChromium::primaryLayer): (WebCore::GraphicsLayerChromium::contentsLayer):
  • platform/graphics/skia/LayerRendererSkia.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::updateLayerContents): (WebCore::LayerRendererChromium::drawLayersInCanvas): (WebCore::LayerRendererChromium::drawLayerInCanvasRecursive): (WebCore::LayerRendererChromium::updateLayerContentsRecursive):
  • platform/graphics/skia/LayerRendererSkia.h: (WebCore::LayerRendererChromium::setRootLayer): (WebCore::LayerRendererChromium::rootLayer):
  • platform/graphics/skia/LayerSkia.cpp: (WebCore::LayerChromium::create): (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::updateGraphicsContext): (WebCore::LayerChromium::updateContents): (WebCore::LayerChromium::drawDebugBorder): (WebCore::LayerChromium::setNeedsCommit): (WebCore::LayerChromium::addSublayer): (WebCore::LayerChromium::insertSublayer): (WebCore::LayerChromium::removeFromSuperlayer): (WebCore::LayerChromium::removeSublayer): (WebCore::LayerChromium::indexOfSublayer): (WebCore::LayerChromium::setBackingStoreRect): (WebCore::LayerChromium::setBounds): (WebCore::LayerChromium::setFrame): (WebCore::LayerChromium::rootLayer): (WebCore::LayerChromium::removeAllSublayers): (WebCore::LayerChromium::setSublayers): (WebCore::LayerChromium::setSuperlayer): (WebCore::LayerChromium::superlayer): (WebCore::LayerChromium::setNeedsDisplay):
  • platform/graphics/skia/LayerSkia.h: (WebCore::LayerChromium::setAnchorPoint): (WebCore::LayerChromium::anchorPoint): (WebCore::LayerChromium::borderWidth): (WebCore::LayerChromium::bounds): (WebCore::LayerChromium::frame): (WebCore::LayerChromium::setPosition): (WebCore::LayerChromium::position): (WebCore::LayerChromium::zPosition): (WebCore::LayerChromium::getSublayers): (WebCore::LayerChromium::setSublayerTransform): (WebCore::LayerChromium::sublayerTransform): (WebCore::LayerChromium::setTransform): (WebCore::LayerChromium::transform):

2010-04-06 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Changing references to Graphics Layer related classes from *Skia to *Chromium.
https://bugs.webkit.org/show_bug.cgi?id=37116

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::setAcceleratedCompositing): (WebKit::WebViewImpl::updateRootLayerContents):
  • src/WebViewImpl.h:
16:04 Changeset [57175] by eric@webkit.org

2010-04-06 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] These tests can be removed from the skipped list since these
work after the redirection loop detection implemented in qt network.
https://bugs.webkit.org/show_bug.cgii?id=36690

  • platform/qt/Skipped:
15:55 Changeset [57174] by eric@webkit.org

2010-04-06 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Laszlo Gombos.

[Qt] WebKit does not build on Windows with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=37026

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform):
15:47 Changeset [57173] by dpranke@chromium.org

2010-04-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Disable pixel tests on the mac port by default.

Also, revamp the way we check for pixel tests being enabled or
disabled. We now look for options.pixel_tests instead of
options.no_pixel_tests, and we have the "--pixel-tests" (force enable)
and "--no-pixel-tests" (force disable) flags.

https://bugs.webkit.org/show_bug.cgi?id=36801

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15:42 Changeset [57172] by eric@webkit.org

2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Laszlo Gombos.

[Qt] Added the iPhone and iPad latest user agent in QtLauncher UA switcher
https://bugs.webkit.org/show_bug.cgi?id=37159

  • QtLauncher/useragentlist.txt:
15:39 Changeset [57171] by jhawkins@chromium.org

2010-04-06 James Hawkins <jhawkins@chromium.org>

Reviewed by Adam Barth.

[Chromium] Implement WebInputElement::maxLength.
https://bugs.webkit.org/show_bug.cgi?id=37172

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::maxLength):
15:32 Changeset [57170] by eric@webkit.org

2010-04-06 Abhinav Mithal <abhinav.mithal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] npapi header leaves XP_WIN flag defined even when SYMBIAN32 flag is found
https://bugs.webkit.org/show_bug.cgi?id=34614

Do not define XP_WIN if WebKit is compiled for Symbian.

No new tests as there is no new functionality.

  • bridge/npapi.h:
15:02 Changeset [57169] by aestes@apple.com

Added myself to the committers list.

14:58 Changeset [57168] by scherkus@chromium.org

2010-04-06 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, media test expectations tweak.

We now regularly run http/tests/media and have to mark a few tests as TIMEOUT.

  • platform/chromium/test_expectations.txt:
14:28 Changeset [57167] by cfleizach@apple.com

aria-label doesn't work on image map area
https://bugs.webkit.org/show_bug.cgi?id=36977

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/area-with-aria-label.html

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::accessibilityDescription):

LayoutTests:

  • platform/mac/accessibility/area-with-aria-label-expected.txt: Added.
  • platform/mac/accessibility/area-with-aria-label.html: Added.
14:21 Changeset [57166] by scherkus@chromium.org

2010-04-06 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, cleaning up media layout test expectations.

Mostly correcting bug numbers, updating comments, and fixing expectations.

  • platform/chromium/test_expectations.txt:
13:44 Changeset [57165] by jamesr@google.com

2010-04-06 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Reverts the incorrect fixed position fastpath scrolling logic
https://bugs.webkit.org/show_bug.cgi?id=33150

This code does not properly handle overflow or transforms on fixed
position elements, causing repaint bugs on scroll.

No new tests.

  • page/FrameView.cpp: (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
  • platform/ScrollView.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
12:58 Changeset [57164] by kevino@webkit.org

[wx] Build fix for wxMac / Cocoa on wx trunk.

12:50 Changeset [57163] by eric@webkit.org

2010-04-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Darin Adler.

JS code generator does not support feature conditional attributes that are writable
https://bugs.webkit.org/show_bug.cgi?id=37149

Write out the feature #ifdef not only for the getter, but also for the setter
function.

  • bindings/scripts/CodeGeneratorJS.pm:
12:17 Changeset [57162] by eric@webkit.org

2010-04-06 Evan Stade <estade@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811

Use the DragImageRef that the DragController passes to us.

This was previously committed but rolled back for breaking layout
tests. The fix is on the WebKit/chromium side.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/DragImageChromium.cpp: Removed.
  • platform/chromium/DragImageChromiumMac.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageChromiumSkia.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageRef.h:

2010-04-06 Evan Stade <estade@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] need DragImage implementation
https://bugs.webkit.org/show_bug.cgi?id=35811

Basic implementation using SkBitmap. Transformations are not supported
yet. No implementation for mac.

This was previously committed but rolled back for breaking layout
tests.

  • public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag): new: check for null dragImage.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
  • src/WebViewImpl.h:
11:56 Changeset [57161] by yuzo@google.com

2010-04-01 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Fix bug: CSS3 :not selector with ID simple selector sequence test fails
https://bugs.webkit.org/show_bug.cgi?id=36276

  • fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
  • fast/css/invalid-not-with-simple-selector-sequence.html: Added.

2010-04-01 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Fix bug: CSS3 :not selector with ID simple selector sequence test fails
As per http://www.w3.org/TR/css3-selectors/#negation, :not(X) takes a simple selector as an argument.
WebKit was accepting a simple selector *sequence*.
This patch adds WebCore::CSSSelector::isSimple which judges if the selector is simple.
The method is used in CSSGrammar.y to decide whether to accept the selector as the argument of :not().
https://bugs.webkit.org/show_bug.cgi?id=36276

Test: fast/css/invalid-not-with-simple-selector-sequence.html

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::isSimple):
  • css/CSSSelector.h:
11:18 Changeset [57160] by darin@apple.com

REGRESSION (r57109): editing/pasteboard/drag-image-to-contenteditable-in-iframe.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=37157

  • platform/win/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:

Copied from platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt.
Windows gets a different result than Mac because the dragging code ends up making the src attribute
of the dragged element have a full path on Windows, but not on Mac.

11:17 Changeset [57159] by mitz@apple.com

Rubber-stamped by Dan Bernstein.

Patch by Andy Estes <aestes@apple.com> on 2010-04-06
Remove non-ASCII characters from license headers to fix build errors on
Japanese Windows.

https://bugs.webkit.org/show_bug.cgi?id=37008

  • dom/UserGestureIndicator.cpp:
  • dom/UserGestureIndicator.h:
10:59 Changeset [57158] by jhawkins@chromium.org

2010-04-06 James Hawkins <jhawkins@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Move the getElementsByTagName from WebDocument to WebNode.
https://bugs.webkit.org/show_bug.cgi?id=37161

  • public/WebDocument.h:
  • public/WebNode.h:
  • src/WebDocument.cpp:
  • src/WebNode.cpp: (WebKit::WebNode::getElementsByTagName):
10:49 Changeset [57157] by eric@webkit.org

2010-04-06 Andrei Popescu <andreip@google.com>

Reviewed by Dimitri Glazkov.

[V8][Android] PageCache crashes when JavaScript is disabled
https://bugs.webkit.org/show_bug.cgi?id=37150

This patch ensures that saving and restoration of the script
state only happens when JS is enabled and each frame has a
non-null context.

No new tests: existing tests show the feature is working
when JS is enabled. When JS is disabled, manual testing
is required.

  • bindings/v8/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore):
10:39 Changeset [57156] by eric@webkit.org

2010-04-06 Bryan Yeung <bryeung@chromium.org>

Reviewed by Dimitri Glazkov.

Update chromium expectations for passing Linux tests.

  • platform/chromium/test_expectations.txt:
10:29 Changeset [57155] by eric@webkit.org

2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Add mechanism to detect QtWebKit 2.0 via the preprocessor
https://bugs.webkit.org/show_bug.cgi?id=36538

  • Api/qwebkitglobal.h:
10:11 Changeset [57154] by yurys@chromium.org

2010-04-06 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations for fast/dom/error-to-string-stack-overflow.html.

  • platform/chromium-mac/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium-win/fast/dom/error-to-string-stack-overflow-expected.txt:
  • platform/chromium/test_expectations.txt:
09:15 Changeset [57153] by loislo@chromium.org

2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for Chromium DEPS.

  • DEPS:
08:56 Changeset [57152] by loislo@chromium.org

2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed: build fixi for WebKit Chromium bots.

  • DEPS:
08:11 Changeset [57151] by loislo@chromium.org

2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

Web Inspector: missed files were added.

  • GNUmakefile.am:
  • bindings/js/ScriptGCEvent.h: Added. (WebCore::ScriptGCEvent::addEventListener): (WebCore::ScriptGCEvent::removeEventListener): (WebCore::ScriptGCEvent::getHeapSize):
  • bindings/v8/ScriptGCEvent.cpp: Added. (WebCore::ScriptGCEvent::addEventListener): (WebCore::ScriptGCEvent::removeEventListener): (WebCore::ScriptGCEvent::getHeapSize): (WebCore::ScriptGCEvent::getUsedHeapSize): (WebCore::ScriptGCEvent::gcPrologueCallback): (WebCore::ScriptGCEvent::gcEpilogueCallback):
  • bindings/v8/ScriptGCEvent.h: Added.
  • inspector/ScriptGCEventListener.h: Added. (WebCore::ScriptGCEventListener::~ScriptGCEventListener):
07:50 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
07:46 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
07:44 Changeset [57150] by loislo@chromium.org

2010-04-06 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: The JS code can be not optimal from memory usage point of view.
As example it can generate a lot of temp objects and GC will spend significant time to collect these objects.
GC event will show us these moments. Also each event can show us how much memory is in use.
https://bugs.webkit.org/show_bug.cgi?id=37025

  • WebCore.gypi:
  • WebCore.pro:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::didGC): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::setHeapSizeStatistic): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::): (WebCore::InspectorTimelineAgent::instanceCount): (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry): (WebCore::InspectorTimelineAgent::GCEvent::GCEvent):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGCEventData):
  • inspector/TimelineRecordFactory.h:
  • inspector/front-end/Popover.js: (WebInspector.PopoverHelper.prototype._mouseHover):
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
07:33 Changeset [57149] by tonikitoo@webkit.org

Unreviewed identation fix.

07:32 Changeset [57148] by tonikitoo@webkit.org

Remove unused DIRECTIONAL_PAD_NAVIGATION
https://bugs.webkit.org/show_bug.cgi?id=37134

Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Android browser was planning to have a "directional pad navigation" available on
trunk, under a build guard called DIRECTIONAL_PAD_NAVIGATION, but according to
https://bugs.webkit.org/show_bug.cgi?id=23145#c3 , the plan was dropped.

However bug 23163 landed some code relying on the build flag supposedly to be added,
and is now dead code in trunk.

  • dom/Element.cpp:

(WebCore::Element::updateFocusAppearance):

07:00 Changeset [57147] by yurys@chromium.org

2010-04-06 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

https://bugs.webkit.org/show_bug.cgi?id=36375

  • platform/chromium-win/fast/workers/worker-script-error-expected.txt:
06:45 Changeset [57146] by pfeldman@chromium.org

2010-04-06 Mattias Nissler <mnissler@chromium.org>

Reviewed by Pavel Feldman.

Rework inspector docking to issue a request call from the frontend
whenever the user triggers to (un)dock the inspector window. Doing so
enables InspectorFrontendHost implementations to asynchronously decide
whether the window is docked or not. The old canAttachWindow() is not
required anymore, remove it.
https://bugs.webkit.org/show_bug.cgi?id=36944

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::requestAttachWindow):
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::requestAttachWindow):
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/inspector.js: (WebInspector.toggleAttach):

2010-04-06 Mattias Nissler <mnissler@chromium.org>

Reviewed by Pavel Feldman.

Handle docking requests from the developer tools and forward them to
WebDevToolsFrontendClient.
https://bugs.webkit.org/show_bug.cgi?id=36944

  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::requestDockWindow):
  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::jsRequestAttachWindow):
  • src/WebDevToolsFrontendImpl.h:
06:33 Changeset [57145] by vitalyr@chromium.org

2010-04-06 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Yury Semikhatsky.

[V8] Extend the set of types supported by SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=37052

New types include sparse arrays, Uint32, Date, and ImageData.

Serialization process became more flexible. A state can either
directly write primitive values (instead of returning them like
iterator) or construct a new state for serializing complex values
that will return to the current state when done.

Deserialization process now avoids exposing the tags using a set
of factory functions for complex objects instead.

Internal buffer type changed to uint8_t to be independent of
whether char is signed or not.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::Writer): (WebCore::Writer::writeString): (WebCore::Writer::writeUint32): (WebCore::Writer::writeDate): (WebCore::Writer::writeNumber): (WebCore::Writer::writeImageData): (WebCore::Writer::writeArray): (WebCore::Writer::writeObject): (WebCore::Writer::writeSparseArray): (WebCore::Writer::doWriteUint32): (WebCore::Writer::doWriteNumber): (WebCore::Writer::append): (WebCore::Writer::fillHole): (WebCore::Writer::byteAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::writeArray): (WebCore::Serializer::writeObject): (WebCore::Serializer::writeSparseArray): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::ErrorState::ErrorState): (WebCore::Serializer::ErrorState::advance): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::State): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::objectDone): (WebCore::Serializer::SparseArrayState::SparseArrayState): (WebCore::Serializer::SparseArrayState::objectDone): (WebCore::Serializer::push): (WebCore::Serializer::pop): (WebCore::Serializer::handleError): (WebCore::Serializer::checkComposite): (WebCore::Serializer::writeString): (WebCore::Serializer::writeImageData): (WebCore::Serializer::newArrayState): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::Reader::Reader): (WebCore::Reader::read): (WebCore::Reader::readString): (WebCore::Reader::readUint32): (WebCore::Reader::readDate): (WebCore::Reader::readNumber): (WebCore::Reader::readImageData): (WebCore::Reader::doReadUint32): (WebCore::Reader::doReadNumber): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::createArray): (WebCore::Deserializer::createObject): (WebCore::Deserializer::createSparseArray): (WebCore::Deserializer::initializeObject): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::stackDepth): (WebCore::SerializedScriptValue::deserialize):
06:29 QtWebKitTriageRoster edited by koshuin@gmail.com
(diff)
06:19 Changeset [57144] by eric@webkit.org

2010-04-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add current user-agent string for Symbian for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=37131

  • QtLauncher/useragentlist.txt:
05:53 QtWebKitTriageRoster edited by benjamin.poulain@nokia.com
(diff)
05:50 QtWebKitTriageRoster edited by antti.j.koivisto@nokia.com
(diff)
05:46 QtWebKitTriageRoster edited by kenneth@webkit.org
(diff)
05:35 QtWebKitTriageRoster edited by hausmann@webkit.org
(diff)
05:31 QtWebKitTriageRoster created by hausmann@webkit.org
05:26 Changeset [57143] by pfeldman@chromium.org

2010-04-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rebaselining Chromium layout test expectations.

  • platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
  • platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Added.
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/chromium/test_expectations.txt:
05:26 QtWebKitBugs edited by hausmann@webkit.org
(diff)
05:25 QtWebKitBugs edited by hausmann@webkit.org
(diff)
05:25 QtWebKitBugs edited by hausmann@webkit.org
(diff)
04:54 Changeset [57142] by eric@webkit.org

2010-04-06 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Eric Seidel.

[Qt] LayoutTests/fast/canvas/canvas-text-alignment.html skipped on Qt
https://bugs.webkit.org/show_bug.cgi?id=36058

fast/canvas/canvas-text-alignment.html passes, so it can be unskipped.
Compared to png file and Mac expected file.

  • platform/qt/Skipped: fast/canvas/canvas-text-alignment.html unskipped.
  • platform/qt/fast/canvas/canvas-text-alignment-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/qt/fast/canvas/canvas-text-alignment-expected.txt: Added.
03:47 Changeset [57141] by ossy@webkit.org

Unreviewed buildfix for --minimal build.
Buildfix after r57134. Add ENABLE(WORKERS) guard.

original bug: https://bugs.webkit.org/show_bug.cgi?id=36375

  • bindings/js/JSWorkerContextErrorHandler.cpp:
03:37 Changeset [57140] by krit@webkit.org

2010-04-06 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

SVG/SMIL parse failure on attribute keySplines
https://bugs.webkit.org/show_bug.cgi?id=37071

Test: svg/animations/animate-keySplines.html

The String in 'keySplines' can have multiple spaces between numbers
and delimiters. The parsing code is inspired by SVGParserUtilities
and respects this.

  • svg/SVGAnimationElement.cpp: (WebCore::parseKeySplines):

2010-04-06 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

SVG/SMIL parse failure on attribute keySplines
https://bugs.webkit.org/show_bug.cgi?id=37071

Test correct parsing of keySplines.

  • svg/animations/animate-keySplines-expected.txt: Added.
  • svg/animations/animate-keySplines.html: Added.
  • svg/animations/script-tests/animate-keySplines.js: Added. (sample1): (sample2): (sample3): (executeTest):
03:34 Changeset [57139] by pfeldman@chromium.org

2010-04-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: more updates to test expectations for Chromium roll.

  • platform/chromium/test_expectations.txt:
03:14 Changeset [57138] by eric@webkit.org

2010-04-06 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Fixed logging of unhndled worker exceptions.
https://bugs.webkit.org/show_bug.cgi?id=37143

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
02:59 Changeset [57137] by eric@webkit.org

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Explain how to handle rollout patches
https://bugs.webkit.org/show_bug.cgi?id=37139

We need to set expectations for how long landing rollout patches with
the commit-queue takes. The commit-queue is optimized for safety, not
performance. Also, give folks an alternative way to land patches
quickly.

In addition, improve our testing of add_patch_to_bug by having
MockBugzilla log. This caused me to tighten a bunch of tests and
notice that one of our tests wasn't being run.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
02:58 Changeset [57136] by pfeldman@chromium.org

2010-04-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: more updates to test expectations for Chromium roll.

  • platform/chromium/test_expectations.txt:
02:07 Changeset [57135] by pfeldman@chromium.org

2010-04-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: updated test expectations for Chromium roll.

  • platform/chromium/test_expectations.txt:
01:46 Changeset [57134] by yurys@chromium.org

2010-04-06 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Refactored error reporting mechanizm on Worker Global Objects.
Unlike other event listeners which accept single argument(Event)
onerror handler on worker global object should be a function
accepting three arguments. This error reporting was implementedas
EventListener::reportError method which had custom implementations
for v8 and JSC. This patch removes EventListener::reportError and
moves its functionality into custom bindings(V8WorkerContextErrorHandler
and JSWorkerContextErrorHandler) that implement EventListener inerface
for the onerror handler.

This patch also makes uncaught exceptions that happen in the onerror
listener be reported to the Worker's onerror handler.

https://bugs.webkit.org/show_bug.cgi?id=36375

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventListener.h:
  • bindings/js/JSWorkerContextErrorHandler.cpp: Added. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
  • bindings/js/JSWorkerContextErrorHandler.h: Added. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8WorkerContextErrorHandler.cpp: Added. (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler): (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
  • bindings/v8/V8WorkerContextErrorHandler.h: Added. (WebCore::V8WorkerContextErrorHandler::create):
  • bindings/v8/V8WorkerContextEventListener.cpp:
  • bindings/v8/V8WorkerContextEventListener.h:
  • dom/EventListener.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException):
  • workers/WorkerContext.h:

2010-04-06 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that exception which occurs in onerror handler is reported to the Worker object.

https://bugs.webkit.org/show_bug.cgi?id=36375

  • fast/workers/worker-script-error-expected.txt:
  • fast/workers/worker-script-error.html:
01:12 Changeset [57133] by pfeldman@chromium.org

2010-04-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: reverting v8 change at r57079 for crashing Chromium layout tests.

00:27 Changeset [57132] by abarth@webkit.org

2010-04-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Turns out commit_info.committer() can be None
https://bugs.webkit.org/show_bug.cgi?id=37106

When the committer isn't in committers.py, the committer() property on
commit_info can be None. We need to handle that case gracefully.

  • Scripts/webkitpy/common/checkout/commitinfo.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/queries.py:
00:09 Changeset [57131] by eric@webkit.org

2010-04-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] Build fix for Dumprendertree if Qt printing is not supported
https://bugs.webkit.org/show_bug.cgi?id=37082

Use the QT_NO_PRINTER guard to flag QPrinter dependent code.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dryRunPrint):

04/05/10:

23:59 Changeset [57130] by eric@webkit.org

2010-04-05 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

RenderProgress.cpp is missing CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=37080

No new tests. just fixed compilation error.

  • rendering/RenderProgress.cpp:
23:48 Changeset [57129] by eric@webkit.org

2010-04-05 Peter Nelson <charn.opcode@gmail.com>

Reviewed by Eric Seidel.

Fixed style errors in DOMCoreClasses.h to bring it up to scratch
for https://bugs.webkit.org/show_bug.cgi?id=34979.

  • DOMCoreClasses.h: (DOMObject::throwException): (DOMObject::callWebScriptMethod): (DOMObject::evaluateWebScript): (DOMObject::removeWebScriptKey): (DOMObject::stringRepresentation): (DOMObject::webScriptValueAtIndex): (DOMObject::setWebScriptValueAtIndex): (DOMObject::setException): (DOMNodeList::throwException): (DOMNodeList::callWebScriptMethod): (DOMNodeList::evaluateWebScript): (DOMNodeList::removeWebScriptKey): (DOMNodeList::stringRepresentation): (DOMNodeList::webScriptValueAtIndex): (DOMNodeList::setWebScriptValueAtIndex): (DOMNodeList::setException): (DOMDocument::throwException): (DOMDocument::callWebScriptMethod): (DOMDocument::evaluateWebScript): (DOMDocument::removeWebScriptKey): (DOMDocument::stringRepresentation): (DOMDocument::webScriptValueAtIndex): (DOMDocument::setWebScriptValueAtIndex): (DOMDocument::setException): (DOMDocument::nodeName): (DOMDocument::nodeValue): (DOMDocument::setNodeValue): (DOMDocument::nodeType): (DOMDocument::parentNode): (DOMDocument::childNodes): (DOMDocument::firstChild): (DOMDocument::lastChild): (DOMDocument::previousSibling): (DOMDocument::nextSibling): (DOMDocument::attributes): (DOMDocument::ownerDocument): (DOMDocument::insertBefore): (DOMDocument::replaceChild): (DOMDocument::removeChild): (DOMDocument::appendChild): (DOMDocument::hasChildNodes): (DOMDocument::cloneNode): (DOMDocument::isSupported): (DOMDocument::namespaceURI): (DOMDocument::prefix): (DOMDocument::setPrefix): (DOMDocument::localName): (DOMDocument::hasAttributes): (DOMDocument::isSameNode): (DOMDocument::isEqualNode): (DOMDocument::textContent): (DOMDocument::setTextContent): (DOMElement::throwException): (DOMElement::callWebScriptMethod): (DOMElement::evaluateWebScript): (DOMElement::removeWebScriptKey): (DOMElement::stringRepresentation): (DOMElement::webScriptValueAtIndex): (DOMElement::setWebScriptValueAtIndex): (DOMElement::setException): (DOMElement::nodeName): (DOMElement::nodeValue): (DOMElement::setNodeValue): (DOMElement::nodeType): (DOMElement::parentNode): (DOMElement::childNodes): (DOMElement::firstChild): (DOMElement::lastChild): (DOMElement::previousSibling): (DOMElement::nextSibling): (DOMElement::attributes): (DOMElement::ownerDocument): (DOMElement::insertBefore): (DOMElement::replaceChild): (DOMElement::removeChild): (DOMElement::appendChild): (DOMElement::hasChildNodes): (DOMElement::cloneNode): (DOMElement::isSupported): (DOMElement::namespaceURI): (DOMElement::prefix): (DOMElement::setPrefix): (DOMElement::localName): (DOMElement::hasAttributes): (DOMElement::isSameNode): (DOMElement::isEqualNode): (DOMElement::textContent): (DOMElement::setTextContent):
23:33 Changeset [57128] by eric@webkit.org

2010-04-05 Eric Uhrhane <ericu@chromium.org>

Reviewed by Brady Eidson.

window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5
https://bugs.webkit.org/show_bug.cgi?id=36671

The previous "fix" I mistakenly compared hashes, an improvement over comparing pointers, but still not right.

No new tests.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Use SecurityOrigin::equal to compare instead of SecurityOriginHash.
23:32 WebInspector edited by joepeck@webkit.org
(diff)
23:11 Changeset [57127] by eric@webkit.org

2010-04-05 Anthony Ricaud <rik@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Audits launcher view is unusable with a small height window
https://bugs.webkit.org/show_bug.cgi?id=37109

Use flex box instead of absolute positioning to avoid overlapping elements.

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/audits.css: (.audit-launcher-view .audit-launcher-view-content): (.audit-launcher-view div.button-container): (.audit-launcher-view .flexible-space):
23:08 WikiStart edited by joepeck@webkit.org
(diff)
23:01 Changeset [57126] by eric@webkit.org

2010-04-05 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Maemo5 theme - wrong spelling
https://bugs.webkit.org/show_bug.cgi?id=37110

Correcting wrong spelling in RenderThemeQt.cpp.

  • platform/qt/RenderThemeQt.cpp:
22:52 Changeset [57125] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should force_build builders that are idle and have failed exactly once
https://bugs.webkit.org/show_bug.cgi?id=37059

We can get into a deadlocked state where the commit-queue is stopped
because the builders are red but the SheriffBot hasn't taken action
because the builder has failed only once. The SheriffBot should force
build idle builders that have failed exactly once to either turn the
tree green again (if the test was flaky) or trigger the "failed twice"
remedies (IRC and bug posts).

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/mocktool.py:
22:51 Changeset [57124] by eric@webkit.org

2010-04-05 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL-specific code to platform/Platform*Event.h.
http://webkit.org/b/36309

  • platform/PlatformWheelEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformKeyboardEvent.h:
22:23 Changeset [57123] by oliver@apple.com

Another build fix

22:07 Changeset [57122] by oliver@apple.com

And another build fix.

22:00 Changeset [57121] by oliver@apple.com

Build fix

21:18 Changeset [57120] by oliver@apple.com

2010-04-05 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Support weak maps in JSC
https://bugs.webkit.org/show_bug.cgi?id=37132

Expose an API to allow creation of a map for storing
weak JS references.

  • API/JSWeakObjectMapRefInternal.h: Added. (OpaqueJSWeakObjectMap::create): (OpaqueJSWeakObjectMap::map): (OpaqueJSWeakObjectMap::~OpaqueJSWeakObjectMap): (OpaqueJSWeakObjectMap::OpaqueJSWeakObjectMap):
  • API/JSWeakObjectMapRefPrivate.cpp: Added.
  • API/JSWeakObjectMapRefPrivate.h: Added.
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::registerWeakMap): (JSC::JSGlobalObject::deregisterWeakMap):
20:59 Changeset [57119] by hamaji@chromium.org

2010-04-05 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Fixed check-webkit-style issue where the script was prematurely
exiting when encountering deleted files in patches.

https://bugs.webkit.org/show_bug.cgi?id=37122

  • Scripts/webkitpy/style/checker.py:
    • Changed non-existent file message from ERROR to WARN.
    • StyleChecker.check_file() no longer raises an exception when a file is not found.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated unit tests as necessary.
20:50 Changeset [57118] by eric@webkit.org

2010-04-05 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL-specific code to platform/graphics/*.h.
http://webkit.org/b/36308

  • platform/graphics/Icon.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/IntPoint.h:
20:33 Changeset [57117] by eric@webkit.org

2010-04-05 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Put a maximum on consecutive redirections so we don't have to
worry about whether it's the same url or not.

Tolerate up to 10 consecutive redirections, anything beyond
that is considered a potentially infinite recursion in the
redirection requests. This is the same behaviour as Firefox.

https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  • platform/network/qt/QNetworkReplyHandler.h:
20:08 Changeset [57116] by jamesr@google.com

2010-04-05 Dimitri Glazkov <dglazkov@chromium.org> and James Robinson <jamesr@chromium.org>

Reviewed by Darin Adler and Dimitri Glazkov.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864

Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html

fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html

  • dom/Document.cpp: (WebCore::Document::finishedParsing): Added updateStyleIfNeeded()

call to ensure that object loads start before firing window load.

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of

Document::updateStyleForAllDocuments

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit

recalc to ensure accuracy of representation, especially for
menuList/listBox switches.

2010-04-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864

Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.

Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
  • fast/forms/textarea-and-mutation-events.html: Added.
20:02 Changeset [57115] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should include blamelist when posting to bugs
https://bugs.webkit.org/show_bug.cgi?id=37113

When posting on bugs, we should include the full list of SVN revisions
that caused the regression to folks have a better sense of whether they
are to blame.

  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
19:32 Changeset [57114] by cjerdonek@webkit.org

Unreviewed after discussion with Adam, Darin, and Eric.

Deleted the auto-install directory since it is no longer needed in
source control (it is auto-generated).

Also added webkitpy/thirdparty/autoinstalled to webkitpy/thirdparty's
svn:ignore property.

  • Scripts/webkitpy/thirdparty/autoinstalled: Removed.
19:24 Changeset [57113] by mrowe@apple.com

Update a test result.

  • platform/mac/editing/inserting/break-blockquote-after-delete-expected.txt:
19:03 Changeset [57112] by tonikitoo@webkit.org

2010-04-05 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Laszlo Gombos.

Cleaned up spatial-navigation-test-cases.html by removing the wrongly
used <frameset> tag. Patch also adds a manual-test specifically to
test Spatial Navigation with framesets.

  • manual-tests/spatial-navigation/frameset.html: Added.
  • manual-tests/spatial-navigation/spatial-navigation-test-cases.html:
18:45 Changeset [57111] by mrowe@apple.com

Test case for <http://webkit.org/b/37115> / <rdar://problem/7829331>.
REGRESSION(r56989): Crash in Mail in WebCore::Position::isCandidate when deleting block using block deletion UI

Reviewed by Adele Peterson.

WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]): Ask the window whether it is the key window rather than doing the comparison
manually. This allows DumpRenderTree's override of isKeyWindow to force this code path to be taken during tests.

WebKitTools:

Add a JavaScript hook in DRT to call through to WebView's -setEditable:. This is required in order to reproduce
the crash.

  • DumpRenderTree/LayoutTestController.cpp:

(setWebViewEditableCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setWebViewEditable):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setWebViewEditable):
(LayoutTestController::layerTreeAsText):

LayoutTests:

  • platform/mac/editing/deleting/deletionUI-successful-deletion-expected.txt: Added.
  • platform/mac/editing/deleting/deletionUI-successful-deletion.html: Added.
  • platform/mac/editing/deleting/resources/deletionUI-helpers.js:

(deletionUIDeleteButtonForElement):
(determineDeletionUIExistence):

18:45 Changeset [57110] by mrowe@apple.com

Roll out r56989 as it introduced crashes in Mail.
<http://webkit.org/b/37115> / <rdar://problem/7829331>

Reviewed by Adele Peterson.

  • dom/Position.cpp:

(WebCore::Position::isCandidate):

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate):

18:38 Changeset [57109] by darin@apple.com

Images must re-load when an image-holding element moves into a new document
https://bugs.webkit.org/show_bug.cgi?id=37127

Reviewed by Sam Weinig.

WebCore:

Test: fast/images/move-image-to-new-document.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::willMoveToNewOwnerDocument): Call ImageLoader's
elementWillMoveToNewOwnerDocument function.

  • html/HTMLImageElement.h: Added willMoveToNewOwnerDocument.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLPlugInImageElement.h: Ditto.
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::willMoveToNewOwnerDocument): Ditto.

  • html/HTMLVideoElement.h: Ditto.
  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::willMoveToNewOwnerDocument): Ditto.

  • svg/SVGImageElement.h: Ditto.
  • html/HTMLMediaElement.h: Made willMoveToNewOwnerDocument protected

so it can be called by HTMLVideoElement.cpp.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::elementWillMoveToNewOwnerDocument): Added.
Resets the loader by clearing out the cached image.

  • loader/ImageLoader.h: Added it.

LayoutTests:

  • fast/images/move-image-to-new-document-expected.txt: Added.
  • fast/images/move-image-to-new-document.html: Added.
  • fast/images/script-tests/move-image-to-new-document.js: Added.
  • fast/js/resources/js-test-post.js: Added a feature for doing asynchronous scripting

tests. The caller sets jsTestIsAsync to true and then calls finishJSTest when done.
Used by the above test.

  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:

Updated since the old test result relied on an incorrect load of an image.
The relative URL has a different base when moved into the subframe document.

17:55 Changeset [57108] by eric@webkit.org

2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Symbian] Consolidate Symbian WINSCW environment configuration
https://bugs.webkit.org/show_bug.cgi?id=37100

Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.

PLATFORM(WIN) and OS(WIN) no longer needs to be undefined as
undefining WIN32 takes care of it.

  • wtf/Platform.h:

2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Symbian] Consolidate Symbian WINSCW environment configuration
https://bugs.webkit.org/show_bug.cgi?id=37100

Move the "undefinition" of WIN32 and _WIN32 from WebCore/config.h
to JavaScriptCore/wtf/Platform.h as it is not specific to WebCore.

No new tests as there is no new functionality.

  • config.h:
17:34 Changeset [57107] by eric@webkit.org

2010-04-05 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add missing ClipboardEfl.h to platform/efl.
http://webkit.org/b/36242

  • platform/efl/ClipboardEfl.h: Added.
17:18 Changeset [57106] by eric@webkit.org

2010-04-05 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Adler.

A few tests in fast/canvas/webgl/ failed on Leopard Release Bot randomly.
https://bugs.webkit.org/show_bug.cgi?id=37077
https://bugs.webkit.org/show_bug.cgi?id=37098

  • fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Gathering more information about framebuffer status when failure happens.
  • fast/canvas/webgl/drawArraysOutOfBounds.html: Ditto.
  • fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Ditto.
  • fast/canvas/webgl/drawElementssOutOfBounds.html: Ditto.
  • fast/canvas/webgl/index-validation-copies-indices-expected.txt: Ditto.
  • fast/canvas/webgl/index-validation-copies-indices.html: Ditto.
17:08 Changeset [57105] by eric@webkit.org

2010-04-05 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Escape control characters in CSS string value when it is serialilzed.

When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.

As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).

CSS string value is not correctly serialized when it contains binary characters
https://bugs.webkit.org/show_bug.cgi?id=28938

  • fast/css/script-tests/string-quote-binary.js: Added.
  • fast/css/string-quote-binary-expected.txt: Added.
  • fast/css/string-quote-binary.html: Added.
  • fast/js/resources/js-test-pre.js: (shouldBeEqualToString): Considering the case when the argument contains binary characters.

2010-04-05 Yuta Kitamura <yutak@chromium.org>

Reviewed by Darin Adler.

Escape control characters in CSS string value when it is serialilzed.

When WebKit serializes a CSS string value that contains binary characters
('\0\1\2' for example), it did not escape these characters. As a result,
users got (invisible) control characters through scripts. This change fixes
this issue.

As a side effect, two separate codes for escaping CSS strings are merged, and
become a public function (quoteCSSString).

CSS string value is not correctly serialized when it contains binary characters
https://bugs.webkit.org/show_bug.cgi?id=28938

Test: fast/css/string-quote-binary.html

  • css/CSSParser.cpp: (WebCore::isCSSTokenizerIdentifier): (WebCore::isCSSTokenizerURL): (WebCore::quoteCSSString): (WebCore::quoteCSSStringIfNeeded): (WebCore::quoteCSSURLIfNeeded):
  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
  • css/FontFamilyValue.cpp: (WebCore::FontFamilyValue::cssText):
17:06 Changeset [57104] by darin@apple.com

Updated the ignore property for changes to the contents here.

  • .: Modified property svn:ignore.
16:54 Changeset [57103] by eric@webkit.org

2010-04-05 John Gregg <johnnyg@google.com>

Reviewed by Darin Adler.

Notifications should not resolve an empty icon parameter as a relative URL
https://bugs.webkit.org/show_bug.cgi?id=36862

  • fast/notifications/notifications-no-icon-expected.txt: Added.
  • fast/notifications/notifications-no-icon.html-disabled: Added.

2010-04-05 John Gregg <johnnyg@google.com>

Reviewed by Darin Adler.

Notifications should not resolve an empty icon parameter as a relative URL
https://bugs.webkit.org/show_bug.cgi?id=36862

  • notifications/Notification.cpp: (WebCore::Notification::Notification):
16:40 Changeset [57102] by darin@apple.com

Ignore more files the Python tools strew about the working directory.

  • Scripts/webkitpy: Added property svn:ignore.
  • Scripts/webkitpy/common: Added property svn:ignore.
  • Scripts/webkitpy/common/checkout: Added property svn:ignore.
  • Scripts/webkitpy/common/config: Added property svn:ignore.
  • Scripts/webkitpy/common/net: Added property svn:ignore.
  • Scripts/webkitpy/common/thread: Added property svn:ignore.
  • Scripts/webkitpy/python24: Added property svn:ignore.
  • Scripts/webkitpy/thirdparty/autoinstalled: Modified property svn:ignore.
  • Scripts/webkitpy/tool/bot: Added property svn:ignore.
16:19 Changeset [57101] by darin@apple.com

Removed some unneeded type casts.

Reviewed by Mark Rowe.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText): Removed an unneeded cast.

  • page/Location.cpp:

(WebCore::Location::host): Removed unneeded parentheses and cast.
(WebCore::Location::port): Ditto.

  • platform/KURLGoogle.cpp:

(WebCore::KURL::setPort): Ditto.

  • workers/WorkerLocation.cpp:

(WebCore::WorkerLocation::host): Ditto.
(WebCore::WorkerLocation::port): Ditto.

16:07 Changeset [57100] by abarth@webkit.org

2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57081.
http://trac.webkit.org/changeset/57081
https://bugs.webkit.org/show_bug.cgi?id=37121

We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip-expected.txt: Removed.
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Removed.
  • fast/forms/select-change-popup-to-listbox-roundtrip-expected.txt: Removed.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Removed.
  • fast/forms/textarea-and-mutation-events-expected.txt: Removed.
  • fast/forms/textarea-and-mutation-events.html: Removed.

2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57081.
http://trac.webkit.org/changeset/57081
https://bugs.webkit.org/show_bug.cgi?id=37121

We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
15:57 Changeset [57099] by beidson@apple.com

ASSERT close()ing the same StorageAreaImpl twice when using multiple PageGroups
<rdar://problem/7828420> and https://bugs.webkit.org/show_bug.cgi?id=37120

Reviewed by Oliver Hunt.

No new tests. (No behavior change)

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::close): Change this invalid ASSERT to an early return.

15:39 Changeset [57098] by ap@apple.com

Updated expected pixel results for missing plug-in, now using text placeholder.

  • platform/mac/plugins/qt-qwidget-plugin-expected.checksum:
  • platform/mac/plugins/qt-qwidget-plugin-expected.png:
15:03 Changeset [57097] by yael.aharon@nokia.com

Unreviewed.
Separate test results for windows platform because progress element is not implemented for that platform yet.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt: Added.
  • platform/win/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/win/fast/js: Added.
  • platform/win/fast/js/global-constructors-expected.txt: Added.
14:52 Changeset [57096] by abarth@webkit.org

2010-04-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57030.
http://trac.webkit.org/changeset/57030
https://bugs.webkit.org/show_bug.cgi?id=37114

Regressed fast/repaint/line-flow-with-floats-9 pixel tests in
chromium port (Requested by jamesr on #webkit).

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
14:49 Changeset [57095] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37111
<rdar://problem/7790327> Draw replacement text when plug-in host crashes

14:16 Changeset [57094] by cfleizach@apple.com

Unreviewed.

Bug 37112 - aria-liveregion-notifications.html fails on leopard release bot
https://bugs.webkit.org/show_bug.cgi?id=37112

Disabling this test on Leopard until further investigation can reveal the answer.
It looks like at this point, any new test added will cause this test to fail on Leopard
release bot, even if it has nothing to do with live regions.

  • platform/mac-leopard/Skipped:
13:41 Changeset [57093] by cfleizach@apple.com

WebCore: Bug 37040 - AX: need to send selected children change notification when aria-selected changed
https://bugs.webkit.org/show_bug.cgi?id=37040

Reviewed by Darin Adler.

When aria-selected is changed in the DOM, it will trigger a selected children change notification.

Test: platform/mac/accessibility/aria-listbox-selectedchildren-change.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::selectedChildrenChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::controlType):

Remove extra whitespace before comment (webkit-style).

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::observableObject):

Allowed a listBox to be an observable object.

(WebCore::AccessibilityRenderObject::ariaRoleHasPresentationalChildren):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):

Updated and streamlined existing code.

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests: Tests for
Bug 37040 - AX: need to send selected children change notification when aria-selected changed
https://bugs.webkit.org/show_bug.cgi?id=37040

Reviewed by Darin Adler.

  • platform/mac/accessibility/aria-listbox-selectedchildren-change-expected.txt: Added.
  • platform/mac/accessibility/aria-listbox-selectedchildren-change.html: Added.
13:38 Changeset [57092] by yael.aharon@nokia.com

Unreviewed.
Separate test results for gtk platform because progress element is not implemented for that platform yet.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Added.
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/gtk/fast/js: Added.
  • platform/gtk/fast/js/global-constructors-expected.txt: Added.
12:55 Changeset [57091] by ojan@chromium.org

2010-04-05 Adam Barth <abarth@webkit.org>

Unreviewed. Add Vitaly Repeshko as a committer.

  • Scripts/webkitpy/common/config/committers.py:
12:33 Changeset [57090] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Unreviewed. Add Vitaly Repeshko as a committer.

  • Scripts/webkitpy/common/config/committers.py:
12:27 Changeset [57089] by treat@webkit.org

Fix regression in pixel test for animated svg background images.

Patch by Adam Treat <atreat@rim.com> on 2010-04-05
Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37027

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):

11:30 Changeset [57088] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Unreviewed. Update kenne's IRC nick to his registered nick.

  • Scripts/webkitpy/common/config/committers.py:
11:27 Changeset [57087] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Unreviewed.

Update expected results for addition of HTMLProgressElement. We didn't
see these errors until later because our dependencies are screwed up.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
11:24 Changeset [57086] by kenneth@webkit.org

Unreviewed layout test fix.

Update mac results for iframe flattening.

  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
11:16 WebKit Team edited by abarth@webkit.org
(diff)
10:57 Changeset [57085] by robert@webkit.org

2010-04-05 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde-Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Qt enters an infinite loop if a redirect response redirects to itself.

Fixes http/tests/xmlhttprequest/connection-error-sync.html

https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

2010-04-05 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde-Christiansen.

[Qt] Fix infinite redirection loop in QNetworkReplyHandler

Unskip http/tests/xmlhttprequest/connection-error-sync.html

https://bugs.webkit.org/show_bug.cgi?id=37097

  • platform/qt/Skipped:
10:55 Changeset [57084] by ojan@chromium.org

2010-04-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

prepare-ChangeLog should take a merge-base for which git branch to diff against.
https://bugs.webkit.org/show_bug.cgi?id=36394

  • Scripts/prepare-ChangeLog:
10:36 Changeset [57083] by kenneth@webkit.org

Unreviewed layout test fix.

Update Qt results for iframe flattening.

  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt:
10:35 Changeset [57082] by yurys@chromium.org

2010-04-05 Yury Semikhatsky <yurys@chromium.org>

Unreviewed, revert r57078.

10:27 Changeset [57081] by dglazkov@chromium.org

2010-04-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864

Modified listbox-selection.html to correctly set the size during
creation. Otherwise, options added to it as a menuList, resulting
in a default selection of the first item.

Added a few more tests to ensure we capture correct behavior for
select elements and their default selection, as well as the influence
of when layout occurs.

  • fast/forms/listbox-selection.html:
  • fast/forms/select-change-listbox-to-popup-roundtrip.html: Added.
  • fast/forms/select-change-popup-to-listbox-roundtrip.html: Added.
  • fast/forms/textarea-and-mutation-events.html: Added.

2010-04-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Style update done due to mutation event dispatching in textarea can be
used to corrupt the render tree.
https://bugs.webkit.org/show_bug.cgi?id=36864

Tests: fast/forms/select-change-listbox-to-popup-roundtrip.html

fast/forms/select-change-popup-to-listbox-roundtrip.html
fast/forms/textarea-and-mutation-events.html

  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Removed invocation of

Document::updateStyleForAllDocuments

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): Added explicit

recalc to ensure accuracy of representation, especially for
menuList/listBox switches.

10:18 Changeset [57080] by kenneth@webkit.org

iframe flattening doesn't flatten
https://bugs.webkit.org/show_bug.cgi?id=36798

Reviewed by Dave Hyatt.

Fixed to the iframe flattening code so that the iframes on
http://www.samisite.com/test-csb2nf/id43.htm are actually
flattened.

Covered by current tests.

  • page/FrameView.cpp: Propagate contents changes of iframes

and subframes in framesets to the parent so that it is relayouted
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scheduleRelayout):

  • rendering/RenderPart.cpp: HTMLIFrameElement do not inherit from

HTMLFrameElement, but HTMLFrameElementBase, correct cast. Correct
the use of inset border values. Avoid a sometimes unnecessary
relayout.
(WebCore::RenderPart::layoutWithFlattening):

  • rendering/RenderPartObject.cpp: Make the calcHeight and calcWidth

return the right values, considering scrolling and fixed width/height
(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):

10:06 Changeset [57079] by vitalyr@chromium.org

2010-04-05 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Yury Semikhatsky.

[V8] Extend the set of types supported by SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=37052

New types include sparse arrays, Uint32, Date, and ImageData.

Serialization process became more flexible. A state can either
directly write primitive values (instead of returning them like
iterator) or construct a new state for serializing complex values
that will return to the current state when done.

Deserialization process now avoids exposing the tags using a set
of factory functions for complex objects instead.

Internal buffer type changed to uint8_t to be independent of
whether char is signed or not.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::Writer): (WebCore::Writer::writeString): (WebCore::Writer::writeUint32): (WebCore::Writer::writeDate): (WebCore::Writer::writeNumber): (WebCore::Writer::writeImageData): (WebCore::Writer::writeArray): (WebCore::Writer::writeObject): (WebCore::Writer::writeSparseArray): (WebCore::Writer::doWriteUint32): (WebCore::Writer::doWriteNumber): (WebCore::Writer::append): (WebCore::Writer::fillHole): (WebCore::Writer::byteAt): (WebCore::Serializer::Serializer): (WebCore::Serializer::serialize): (WebCore::Serializer::writeArray): (WebCore::Serializer::writeObject): (WebCore::Serializer::writeSparseArray): (WebCore::Serializer::StateBase::StateBase): (WebCore::Serializer::ErrorState::ErrorState): (WebCore::Serializer::ErrorState::advance): (WebCore::Serializer::State::composite): (WebCore::Serializer::State::State): (WebCore::Serializer::ArrayState::ArrayState): (WebCore::Serializer::ArrayState::advance): (WebCore::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::Serializer::AbstractObjectState::advance): (WebCore::Serializer::ObjectState::ObjectState): (WebCore::Serializer::ObjectState::objectDone): (WebCore::Serializer::SparseArrayState::SparseArrayState): (WebCore::Serializer::SparseArrayState::objectDone): (WebCore::Serializer::push): (WebCore::Serializer::pop): (WebCore::Serializer::handleError): (WebCore::Serializer::checkComposite): (WebCore::Serializer::writeString): (WebCore::Serializer::writeImageData): (WebCore::Serializer::newArrayState): (WebCore::Serializer::newObjectState): (WebCore::Serializer::doSerialize): (WebCore::Reader::Reader): (WebCore::Reader::read): (WebCore::Reader::readString): (WebCore::Reader::readUint32): (WebCore::Reader::readDate): (WebCore::Reader::readNumber): (WebCore::Reader::readImageData): (WebCore::Reader::doReadUint32): (WebCore::Reader::doReadNumber): (WebCore::Deserializer::Deserializer): (WebCore::Deserializer::createArray): (WebCore::Deserializer::createObject): (WebCore::Deserializer::createSparseArray): (WebCore::Deserializer::initializeObject): (WebCore::Deserializer::doDeserialize): (WebCore::Deserializer::stackDepth): (WebCore::SerializedScriptValue::deserialize):
10:00 Changeset [57078] by yurys@chromium.org

2010-04-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Refactored error reporting mechanizm on Worker Global Objects.
Unlike other event listeners which accept single argument(Event)
onerror handler on worker global object should be a function
accepting three arguments. This error reporting was implementedas
EventListener::reportError method which had custom implementations
for v8 and JSC. This patch removes EventListener::reportError and
moves its functionality into custom bindings(V8WorkerContextErrorHandler
and JSWorkerContextErrorHandler) that implement EventListener inerface
for the onerror handler.

This patch also makes uncaught exceptions that happen in the onerror
listener be reported to the Worker's onerror handler.

https://bugs.webkit.org/show_bug.cgi?id=36375

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventListener.h:
  • bindings/js/JSWorkerContextErrorHandler.cpp: Added. (WebCore::JSWorkerContextErrorHandler::JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::~JSWorkerContextErrorHandler): (WebCore::JSWorkerContextErrorHandler::handleEvent):
  • bindings/js/JSWorkerContextErrorHandler.h: Added. (WebCore::JSWorkerContextErrorHandler::create): (WebCore::createJSWorkerContextErrorHandler):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8WorkerContextErrorHandler.cpp: Added. (WebCore::V8WorkerContextErrorHandler::V8WorkerContextErrorHandler): (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
  • bindings/v8/V8WorkerContextErrorHandler.h: Added. (WebCore::V8WorkerContextErrorHandler::create):
  • bindings/v8/V8WorkerContextEventListener.cpp:
  • bindings/v8/V8WorkerContextEventListener.h:
  • dom/EventListener.h: Removed reportError method that was used only for reporting worker errors.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::reportException):

2010-04-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that exception which occurs in onerror handler is reported to the Worker object.

https://bugs.webkit.org/show_bug.cgi?id=36375

  • fast/workers/worker-script-error-expected.txt:
  • fast/workers/worker-script-error.html:
  • workers/WorkerContext.h:
08:53 Changeset [57077] by tonikitoo@webkit.org

Fix some "explicit braces to avoid ambiguous 'else'" warnings
https://bugs.webkit.org/show_bug.cgi?id=37088

Reviewed by Darin Adler.
Patch by Antonio Gomes (tonikitoo@webkit.org)

  • dom/Node.cpp:

(WebCore::Node::dispatchGenericEvent):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchEvent):

07:28 Changeset [57076] by laszlo.1.gombos@nokia.com

2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Consolidate the definition of SKIP_STATIC_CONSTRUCTORS_ON_GCC

Instead of defining and undefining it later, let's not
define SKIP_STATIC_CONSTRUCTORS_ON_GCC for WINSCW.

No new tests as there is no new functionality.

  • config.h:
07:12 Changeset [57075] by robert@webkit.org

2010-04-05 Robert Hogan <robert@webkit.org>

Rubber-stamped by Kenneth-Rohde Christiansen.

re-login.html and re-login-async.html are now tracked in bugzilla.

https://bugs.webkit.org/show_bug.cgi?id=37084

  • platform/qt/Skipped:
06:47 Changeset [57074] by eric@webkit.org

2010-04-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Symbian] Remove obsolete build flags for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37083

Symbian port of QtWebKit port does not use icu, so it does
not need U_HAVE_* defines.

Symbian now has inttypes.h as part of OpenC.

stdio.h, limits.h and MathExtras.h are already included in
more appropriate locations.

No new tests as there is no new functionality.

  • config.h:
05:48 Changeset [57073] by pfeldman@chromium.org

2010-04-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium build fix.

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platformCallback): (WebCore::V8InspectorFrontendHost::portCallback):
05:48 Changeset [57072] by kov@webkit.org

2010-04-05 Lucas Lommer <llommer@svn.gnome.org>

Reviewed by Gustavo Noronha.

Czech translation for WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=36879

  • cs.po: Added.
05:44 Changeset [57071] by kov@webkit.org

2010-04-05 Christian Kirbach <Christian.Kirbach@googlemail.com>

Reviewed by Gustavo Noronha.

Updated German translation
https://bugs.webkit.org/show_bug.cgi?id=36453

  • de.po:
05:38 Changeset [57070] by kov@webkit.org

2010-04-05 Luca Ferretti <elle.uca@libero.it>

Reviewed by Gustavo Noronha.

Italian translation for 1.1.90
https://bugs.webkit.org/show_bug.cgi?id=36323

  • it.po:
05:37 Changeset [57069] by pfeldman@chromium.org

2010-04-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] platform detection in Chromium
has regressed to unknown.

https://bugs.webkit.org/show_bug.cgi?id=37081

  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::platform): (WebCore::JSInspectorFrontendHost::port):
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::platform): (WebCore::V8InspectorFrontendHost::port):
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
04:59 Changeset [57068] by eric@webkit.org

2010-04-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Remove logging of successful XHR and worker's importScript()
to inspector console
https://bugs.webkit.org/show_bug.cgi?id=37078

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::importScripts):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::V8WorkerContext::importScriptsCallback):
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::importScripts):
  • workers/DedicatedWorkerContext.h:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • workers/WorkerContext.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
02:27 Changeset [57067] by pfeldman@chromium.org

2010-04-05 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium test expectations update for the roll.

  • platform/chromium/test_expectations.txt:
00:41 Changeset [57066] by eric@webkit.org

2010-04-05 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Removed the PatchStyleErrorHandler class and incorporated its
functionality into the DefaultStyleErrorHandler class.

https://bugs.webkit.org/show_bug.cgi?id=37067

  • Scripts/webkitpy/style/checker.py:
    • In the StyleChecker class:
      • Added a line_number parameter to the check_file() method.
      • Renamed the handle_style_error parameter to mock_handle_style_error to be consistent with the other mock_* parameter names.
      • Added a mock_check_file parameter to the check_patch() method to facilitate unit testing the changes in this patch.
      • Rewrote the check_patch() method with the patch-parsing logic taken from the PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added a StyleCheckerCheckFileBase class and sub-classed the existing StyleCheckerCheckFileTest class from it.
    • Added a StyleCheckerCheckPatchTest class to unit-test the rewritten check_patch() method.
    • Removed the vestigial main code at the bottom of the file. This is left over from when check-webkit-style was implemented as a module and a wrapper module.
  • Scripts/webkitpy/style/error_handlers.py:
    • Added an optional line_numbers parameter to the DefaultStyleErrorHandler class constructor and adjusted the call() method as necessary.
    • Removed the PatchStyleErrorHandler class.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Removed the PatchStyleErrorHandlerTest class which unit-tested the PatchStyleErrorHandler class which is being removed in this patch.
    • Added a test_line_numbers() test method to the DefaultStyleErrorHandlerTest class to test use of the DefaultStyleErrorHandler's new line_numbers attribute.
00:24 Changeset [57065] by abarth@webkit.org

2010-04-05 Adam Barth <abarth@webkit.org>

Unreviewed.

Tighten SheriffBot's flaky test detector
https://bugs.webkit.org/show_bug.cgi?id=37063

Instead of just looking for two sequential red builds, look for two
sequential failures of the same test. This should reduce sheriffbot
false positive substantially.

I'm landing this change unreviewed because I've noticed SheriffBot
triggering a lot more false positives now that we've expanded the set
of core builders. I've tried to take Eric's comments on Bug 37063 into
account. I'm happy to iterate on this patch tomorrow once Eric wakes
up.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/tool/commands/queries.py:

04/04/10:

23:30 Changeset [57064] by pfeldman@chromium.org

2010-04-04 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out chromium changes r57028 and r57032
for breaking chromium layout tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/DragImageChromium.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageChromiumMac.cpp: Removed.
  • platform/chromium/DragImageChromiumSkia.cpp: Removed.
  • platform/chromium/DragImageRef.h:


WebKit/chromium:

  • public/WebViewClient.h: (WebKit::WebViewClient::startDragging):
  • src/DragClientImpl.cpp: (WebKit::DragClientImpl::startDrag):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::startDragging):
  • src/WebViewImpl.h:
19:28 Changeset [57063] by johnnyg@google.com

2010-04-04 John Gregg <johnnyg@google.com>

Unreviewed, add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
19:11 Changeset [57062] by tonikitoo@webkit.org

Unreviewed expected results fix.
Patch by Antonio Gomes <tonikitoo@webkit.org>

The implementation was fixed, and results were no longer valid.

  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
19:10 Changeset [57061] by tonikitoo@webkit.org

2010-03-29 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Spatial Navigation: Initial code simplification in FocusController.cpp and SpatialNavigation.cpp

WebCore::distanceInDirection method was handling much of the logic not
strictly only related to the distance between nodes acquisition. This
method was simplified and renamed to 'WebCore::distanceDataForNode'.
The latter is now responsible for only getting the distance and alignment
data, while all assignement logic previously in distanceInDirection method
was moved place to updateFocusCandidateIfCloser.

Parent document distance and alignment acquisitions, in turn, have also
changed location: they are both got from deepFindFocusableNodeInDirection,
and passed in a recursive call to findFocusableNodeInDirection via the
candidateParent variable (optional parameter). In addition, the need for
the 'focusCandidateCopy' variable in deepFindFocusableNodeInDirection method
was removed, making the code much cleaner.

No behaviour change at this point. Mostly moving code around to the place
where it should live in.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally): (WebCore::updateFocusCandidateIfCloser): (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
  • page/FocusController.h:
  • page/SpatialNavigation.cpp: (WebCore::distanceDataForNode): (WebCore::renderRectRelativeToRootDocument):
  • page/SpatialNavigation.
15:18 Changeset [57060] by eric@webkit.org

2010-04-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: In the inherited styles, do not render non-inherited properties as overriden.

https://bugs.webkit.org/show_bug.cgi?id=37072

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
15:00 Changeset [57059] by pfeldman@chromium.org

2010-04-04 Pavel Feldman <pfeldman@chromium.org>

(Not reviewed).

Adding images for inspector blog post. Previewed by Timothy Hatcher.

  • blog-files/inspector/audits_launcher.png: Added.
  • blog-files/inspector/audits_panel.png: Added.
  • blog-files/inspector/console_panel.png: Added.
  • blog-files/inspector/context_menu.png: Added.
  • blog-files/inspector/css_highlighted_line.png: Added.
  • blog-files/inspector/css_line_number_snippet.png: Added.
  • blog-files/inspector/css_line_numbers.png: Added.
  • blog-files/inspector/deactivate_breakpoints.png: Added.
  • blog-files/inspector/evaluate_on_hover.png: Added.
  • blog-files/inspector/evaluate_on_hover_2.png: Added.
  • blog-files/inspector/inherited_styles.png: Added.
  • blog-files/inspector/large_dom.png: Added.
  • blog-files/inspector/large_resources.png: Added.
  • blog-files/inspector/pseudo_elements.png: Added.
  • blog-files/inspector/redirect_headers.png: Added.
  • blog-files/inspector/redirect_headers_full.png: Added.
  • blog-files/inspector/redirects.png: Added.
  • blog-files/inspector/redirects_full.png: Added.
  • blog-files/inspector/timeline_overview.png: Added.
  • blog-files/inspector/timeline_panel.png: Added.
  • blog-files/inspector/timeline_record_details.png: Added.
04:52 Changeset [57058] by robert@webkit.org

2010-04-04 Robert Hogan <robert@webkit.org>

Unreviewed, add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
01:53 Changeset [57057] by dumi@chromium.org

Unreviewed, adding my IRC nickname to committers.py

  • Scripts/webkitpy/common/config/committers.py:
01:26 Changeset [57056] by cjerdonek@webkit.org

2010-04-04 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style's option-parsing code.

https://bugs.webkit.org/show_bug.cgi?id=37064

  • Scripts/check-webkit-style:
    • Moved the "WebKit checkout not found" check from ArgumentParser.parse() to the calling code.
    • Moved the --git-commit argument validation from the calling code to ArgumentParser.parse().
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated a unit test as necessary.
  • Scripts/webkitpy/style/optparser.py:
    • Renamed ArgumentParser._exit_with_help() to _parse_error() and made its error_message parameter required.
    • Removed the found_checkout parameter from ArgumentParser.parse().
    • Removed the "WebKit checkout not found" check and moved it to the calling code.
    • Added --git-commit argument checking.
  • Scripts/webkitpy/style/optparser_unittest.py:
    • Adjusted the import statements to be fully qualified.
    • Changed the ArgumentParserTest class to inherit from LoggingTestCase, and updated the class as necessary.
    • Added a unit-test for the --git-commit validation.
    • Added unit tests for the --git-diff and --git-since variants of --git-commit.
Note: See TracTimeline for information about the timeline view.