Timeline


and

04/11/10:

23:53 April 2010 Meeting edited by xan@webkit.org
(diff)
23:19 April 2010 Meeting edited by levin@chromium.org
(diff)
23:11 April 2010 Meeting edited by levin@chromium.org
(diff)
22:47 April 2010 Meeting edited by levin@chromium.org
(diff)
22:41 April 2010 Meeting edited by mjs@apple.com
(diff)
21:54 Changeset [57469] by abarth@webkit.org
  • 41 edits
    2 deletes in trunk

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
  • src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::close):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/DocumentWriter.cpp: Removed.
  • loader/DocumentWriter.h: Removed.
  • loader/FrameLoader.cpp: (WebCore::canReferToParentFrameEncoding): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::replaceDocument): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::responseMIMEType): (WebCore::FrameLoader::setResponseMIMEType): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::end): (WebCore::FrameLoader::endIfNotLoadingMainResource): (WebCore::FrameLoader::encoding): (WebCore::FrameLoader::setEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h:
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
21:34 April 2010 Meeting edited by morrita@google.com
(diff)
21:20 Changeset [57468] by abarth@webkit.org
  • 41 edits
    2 adds in trunk

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
  • src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

This patch separates the begin/write/end cycle of decoding network
bytes and putting them into a document from the rest of the loading
machinery. The code and state required to write bytes into a document
doesn't interact very much with the rest of the loading machinery.

No tests because there is no behavior change (hopefully!).

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::close):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/DocumentWriter.cpp: Added.
  • loader/DocumentWriter.h: Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::setURL): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::didEndDocument): (WebCore::FrameLoader::willSetEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h: (WebCore::FrameLoader::writer): (WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
21:05 April 2010 Meeting edited by ben@webkit.org
(diff)
20:52 Changeset [57467] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-11 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style so that the StyleChecker class
has no dependencies on patch-related concepts.

https://bugs.webkit.org/show_bug.cgi?id=37065

This patch is an intermediate step towards making the StyleChecker
class a generalized file processor that can do arbitary operations
on the files corresponding to a list of paths. This patch
also simplifies the unit-testing of patch-checking code.

  • Scripts/check-webkit-style:
    • Updated to use the new PatchChecker class.
  • Scripts/webkitpy/style/checker.py:
    • Refactored the StyleChecker.check_patch() method into the check() method of a new PatchChecker class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Refactored the unit tests as necessary, changing the StyleCheckerCheckPatchTest class to a PatchCheckerTest class.
20:50 April 2010 Meeting edited by ben@webkit.org
(diff)
20:02 April 2010 Meeting edited by dimich@chromium.org
(diff)
19:56 April 2010 Meeting edited by morrita@google.com
(diff)
19:54 Changeset [57466] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-11 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix new-run-webkit-tests regressions cased by Eric's option parsing patch
https://bugs.webkit.org/show_bug.cgi?id=37430

We need some basic unit testing of this script, or we're going to keep
breaking it like this. Added missing namespace qualifiers and
propagated renaming of an option.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/layout_tests/driver_test.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
19:47 Changeset [57465] by tony@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-04-11 Tony Chang <tony@chromium.org>

Not reviewed, layout test fix for QT bots.

Update paste expected results on QT and skip a new d&d test.

  • platform/qt/Skipped:
  • platform/qt/editing/pasteboard/onpaste-text-html-expected.txt: Added.
19:21 Changeset [57464] by tony@chromium.org
  • 6 edits
    4 adds in trunk

2010-04-11 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] implement getData('text/html') for paste and drop events
https://bugs.webkit.org/show_bug.cgi?id=37193

  • editing/pasteboard/onpaste-text-html-expected.txt: Added.
  • editing/pasteboard/onpaste-text-html.html: Added.
  • fast/events/ondrop-text-html-expected.txt: Added.
  • fast/events/ondrop-text-html.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:

2010-04-07 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] implement getData('text/html') for paste and drop events
https://bugs.webkit.org/show_bug.cgi?id=37193

Tests: editing/pasteboard/onpaste-text-html.html

fast/events/ondrop-text-html.html

  • platform/chromium/ClipboardChromium.cpp: (WebCore::): (WebCore::clipboardTypeFromMIMEType): add html type (WebCore::ClipboardChromium::clearData): implement clear text/html (WebCore::ClipboardChromium::getData): implement get text/html (similar to text/plain) (WebCore::ClipboardChromium::setData): implement set text/html
19:16 Changeset [57463] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Break new-run-webkit-tests options into groups for easier re-use and possible relocation
https://bugs.webkit.org/show_bug.cgi?id=37408

new-run-webkit-tests currently has one huge function for
dealing with all options-parsing.
This patch is a first attempt at trying to split that large
function down into smaller (hopefully more readable?) chunks
dealing with the different areas of options.
For example, it would make sense to move configuration
options off into some module which deals with the vagries of
WebKit's configuration system. It would also make sense to move
Chromium options off onto the Chromium port object (where they are used).
It may make sense to move results.json options over to the results.json code.
This change is a first iteration, and we will certainly need more
refinement to this code over time. Hopefully I didn't make things
harder to read here.

  • Scripts/webkitpy/layout_tests/driver_test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
19:07 April 2010 Meeting edited by ariya@webkit.org
add myself (diff)
18:58 Changeset [57462] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

create-rollout copy needs to be updated to reflect removal of --no-build
https://bugs.webkit.org/show_bug.cgi?id=37425

Removed --no-build and --no-test from the instructions because these
don't exist anymore.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
    • Updated the expected results to reflect the new copy.
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
18:04 Changeset [57461] by tony@chromium.org
  • 5 edits in trunk

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57460.
http://trac.webkit.org/changeset/57460
https://bugs.webkit.org/show_bug.cgi?id=37424

broke chromium builders (Requested by tonywork on #webkit).

  • DEPS:
  • gyp_webkit:

2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57460.
http://trac.webkit.org/changeset/57460
https://bugs.webkit.org/show_bug.cgi?id=37424

broke chromium builders (Requested by tonywork on #webkit).

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
17:49 Changeset [57460] by tony@chromium.org
  • 5 edits in trunk

2010-04-11 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
https://bugs.webkit.org/show_bug.cgi?id=36578

  • DEPS:
  • gyp_webkit: Add DumpRenderTree.gyp so we generate xcode projects for DRT.

2010-04-11 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
https://bugs.webkit.org/show_bug.cgi?id=36578

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Small fix to avoid a circular dependency between WebKit.gyp and webkit.gyp.
16:57 April 2010 Meeting edited by tkent@chromium.org
(diff)
16:44 April 2010 Meeting edited by yutak@chromium.org
(diff)
16:22 April 2010 Meeting edited by tkent@chromium.org
Add tkent to attendees list (diff)
16:08 April 2010 Meeting edited by maruel@chromium.org
(diff)
16:05 April 2010 Meeting edited by abarth@webkit.org
(diff)
15:55 April 2010 Meeting edited by maruel@chromium.org
(diff)
15:47 April 2010 Meeting edited by eric@webkit.org
(diff)
15:25 ApplicationsGtk edited by khorben@defora.org
Added DeforaOS Surfer (diff)
15:23 ApplicationsGtk edited by khorben@defora.org
Typos (diff)
15:18 April 2010 Meeting edited by jamesr@google.com
(diff)
15:09 April 2010 Meeting edited by kbr@google.com
(diff)
14:42 April 2010 Meeting edited by staikos@kde.org
(diff)
14:22 Changeset [57459] by mrowe@apple.com
  • 2 edits in tags/Safari-533.4.1/JavaScriptCore

Merge r57457.

14:15 April 2010 Meeting edited by mjs@apple.com
(diff)
14:14 April 2010 Meeting edited by mjs@apple.com
(diff)
14:14 April 2010 Meeting edited by mjs@apple.com
(diff)
14:12 Changeset [57458] by weinig@apple.com
  • 5 edits
    1 add in trunk/WebKit2

Fix for https://bugs.webkit.org/show_bug.cgi?id=37417
Move duplicated internal CoreIPC message kinds to a
header.

Reviewed by Darin Adler.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

  • Platform/CoreIPC/CoreIPCMessageKinds.h: Added.

(CoreIPC::CoreIPCMessage::):
(CoreIPC::):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
14:05 April 2010 Meeting edited by mjs@apple.com
(diff)
14:04 Changeset [57457] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/7851332> Fix the build.

Reviewed by Sam Weinig.

  • wtf/FastMalloc.cpp:

(WTF::TCMallocStats::): Initialize extra members of malloc_introspection_t to zero.

14:04 April 2010 Meeting edited by mjs@apple.com
(diff)
13:55 April 2010 Meeting edited by mjs@apple.com
(diff)
13:54 April 2010 Meeting edited by mjs@apple.com
(diff)
13:46 April 2010 Meeting edited by mjs@apple.com
(diff)
13:43 April 2010 Meeting edited by eric@webkit.org
(diff)
13:43 April 2010 Meeting edited by eric@webkit.org
(diff)
13:42 April 2010 Meeting edited by eric@webkit.org
(diff)
13:41 April 2010 Meeting edited by eric@webkit.org
(diff)
13:41 April 2010 Meeting edited by eric@webkit.org
(diff)
13:37 April 2010 Meeting edited by weinig@apple.com
(diff)
13:35 April 2010 Meeting edited by mjs@apple.com
(diff)
13:34 Changeset [57456] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Disable not-implemented warnings by default for now.

Rubber-stamped by Anders Carlsson.

  • Shared/NotImplemented.h:
13:33 April 2010 Meeting edited by weinig@apple.com
(diff)
13:32 April 2010 Meeting edited by mjs@apple.com
(diff)
13:31 April 2010 Meeting edited by mjs@apple.com
(diff)
13:31 April 2010 Meeting edited by mjs@apple.com
(diff)
13:30 April 2010 Meeting edited by eric@webkit.org
(diff)
13:30 April 2010 Meeting edited by eric@webkit.org
(diff)
13:28 April 2010 Meeting edited by mjs@apple.com
(diff)
13:25 April 2010 Meeting edited by mjs@apple.com
(diff)
13:24 April 2010 Meeting edited by cjerdonek@webkit.org
Typo fix (diff)
13:22 April 2010 Meeting edited by mjs@apple.com
(diff)
13:20 April 2010 Meeting edited by eric@webkit.org
(diff)
13:19 Changeset [57455] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-11 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Eric Seidel.

svn-apply errors out when removing directories in git
https://bugs.webkit.org/show_bug.cgi?id=34871

  • Scripts/svn-apply: (isDirectoryEmptyForRemoval): early break if the directory doesn't exist (scmRemove): have git ignore unmatched files
13:18 Changeset [57454] by weinig@apple.com
  • 12 edits in trunk/WebKit2

Fix for https://bugs.webkit.org/show_bug.cgi?id=37399
Remove use of STL data structures from CoreIPC code

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decodeBytes):
(CoreIPC::ArgumentDecoder::removeAttachment):

  • Platform/CoreIPC/ArgumentDecoder.h:

Use WTF::Deque instead of std::queue and WTF::Vector
instead of std::vector. Replace use of malloc/free with
fastMalloc/fastFree.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::addAttachment):
(CoreIPC::ArgumentEncoder::releaseAttachments):

  • Platform/CoreIPC/ArgumentEncoder.h:

Use WTF::Vector instead of std::list. Replace use of malloc/free
with fastMalloc/fastFree.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::sendOutgoingMessages):
(CoreIPC::Connection::dispatchMessages):

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createArgumentDecoder):
Use WTF::Vector instead of std::queue.

  • Platform/RunLoop.cpp:

(RunLoop::performWork):
(RunLoop::scheduleWork):

  • Platform/RunLoop.h:

Ditto.

  • Platform/WorkQueue.h:
  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::scheduleWork):
(WorkQueue::performWork):
Ditto.

13:17 April 2010 Meeting edited by eric@webkit.org
(diff)
13:16 April 2010 Meeting edited by eric@webkit.org
(diff)
13:15 April 2010 Meeting edited by eric@webkit.org
(diff)
12:09 Changeset [57453] by dbates@webkit.org
  • 4 edits
    3 deletes in trunk/WebKitTools

2010-04-11 Daniel Bates <dbates@rim.com>

No review, rolling out 57440.
http://trac.webkit.org/changeset/57440
https://bugs.webkit.org/show_bug.cgi?id=27204

Did not handle Git patches that included both file and property
changes to the same file. Rolling this change out while I look
into this.

  • Scripts/VCSUtils.pm:
  • Scripts/svn-apply:
  • Scripts/svn-unapply:
  • Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Removed.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Removed.
  • Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Removed.
11:51 Changeset [57452] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2010-04-11 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Eric Seidel.

Minor Updates and Cleanup to the Contributing Page
https://bugs.webkit.org/show_bug.cgi?id=37415

  • coding/contributing.html:
11:43 Changeset [57451] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix typo in log path for AbstractQueue
https://bugs.webkit.org/show_bug.cgi?id=37414

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
10:34 Changeset [57450] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-11 Adam Barth <abarth@webkit.org>

Unreviewed. Add missing import statement.

  • Scripts/webkitpy/common/system/executive.py:
08:37 Changeset [57449] by eric@webkit.org
  • 7 edits in trunk

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

Unskip:

http/tests/security/no-referrer.html
fast/loader/onload-willSendRequest-null-for-frame.html
fast/loader/onload-willSendRequest-null-for-script.html

https://bugs.webkit.org/show_bug.cgi?id=37410

  • platform/qt/Skipped:

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

https://bugs.webkit.org/show_bug.cgi?id=37410

  • WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null): (qt_set_will_send_request_clear_headers): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

https://bugs.webkit.org/show_bug.cgi?id=37410

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setWillSendRequestReturnsNull): (LayoutTestController::setWillSendRequestClearHeader):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
02:05 Changeset [57448] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] Unreviewed buildfix for --debug build after r57433.

Refactor Qt DRT support in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35844

  • QtLauncher/main.cpp: qt_drt_garbageCollector_collect(); renamed to DumpRenderTreeSupportQt::garbageCollectorCollect();

(launcherMain):

00:46 Changeset [57447] by joepeck@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-11 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Mark Rowe.

Make commit-log-editor Rubber-stamp aware. And other minor cleanups.
https://bugs.webkit.org/show_bug.cgi?id=37407

  • Scripts/commit-log-editor:
00:41 Changeset [57446] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2010-04-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add PrettyPatch links to new-run-webkit-tests output
https://bugs.webkit.org/show_bug.cgi?id=37406

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • We're leaking a file handle here, add a FIXME.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
    • Add pretty diff links.
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Add support for generating pretty diffs using PrettyPatch.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • We're leaking another file handle here, another FIXME.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
    • Update write_output_files signature.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
    • Remove unused arguments from write_output_files.
    • Add support for dumping pretty diffs to write_output_files.
    • Fix a bunch of file descriptor leaks in this file.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
    • Update write_output_files signature.

04/10/10:

23:57 Changeset [57445] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-04-10 Adam Barth <abarth@webkit.org>

Unreviewed. Rename m_forceSandboxFlags to m_forcedSandoxFlags, as
requested by Darin Adler.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::updateSandboxFlags):
  • loader/FrameLoader.h: (WebCore::FrameLoader::setForcedSandboxFlags):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
23:52 Changeset [57444] by abarth@webkit.org
  • 9 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

kill_process is copy/pasted in five places
https://bugs.webkit.org/show_bug.cgi?id=37405

We shouldn't replicate the kill_process logic in every port. Instead,
we should move the process interaction to Executive.

Dirk mentioned that he wanted this abstraction to make it easier to
mock things out for testing. It turns out this function is only used
in one place where it can't be used as a mock point for testing because
the corresponding create process actually creates a real process. In
the long term, we should indirect both these calls through a non-static
Executive as a mock point. However, we should wait on that until we
actually want to write the test.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
23:13 Changeset [57443] by abarth@webkit.org
  • 10 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests shouldn't alter its path to import packages
https://bugs.webkit.org/show_bug.cgi?id=37404

  • Scripts/new-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
  • Scripts/webkitpy/thirdparty/simplejson/decoder.py:
23:05 Changeset [57442] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests should store results to a directory under the build tree
https://bugs.webkit.org/show_bug.cgi?id=37380

  • Scripts/webkitpy/layout_tests/port/webkit.py:
22:57 Changeset [57441] by mrowe@apple.com
  • 8 edits
    1 move in trunk

<rdar://problem/7845305> Further adoption of formal protocols for delegates.

Reviewed by Dan Bernstein.

Move EmptyProtocolDefinitions.h down in to WebCore, and add the new protocols. Adopt the protocols in the appropriate places.

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/EmptyProtocolDefinitions.h: Renamed from WebKit/mac/Misc/EmptyProtocolDefinitions.h.
  • platform/network/mac/ResourceHandleMac.mm:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

  • Misc/EmptyProtocolDefinitions.h: Removed.
  • Misc/WebDownload.mm:
  • WebKitPrefix.h:
22:46 Changeset [57440] by eric@webkit.org
  • 4 edits
    3 adds in trunk/WebKitTools

2010-04-10 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27204

Implement support for changing the executable bit of a file.
The executable bit is among the most changed file properties.
Future support can include other property changes.

Currently, if a patch changes the executable bit of a file
it is not respected by svn-apply or svn-unapply. Since the
commit-queue bot uses these tools as part of its workflow,
such patches cannot be committed by it. That is, such patches
need to be committed by hand. Instead, we should add support
for the executable bit so that such patches can be committed
by the commit-queue bot.

  • Scripts/VCSUtils.pm: Also change reference to Apple Computer, Inc. in copyright to Apple, Inc.
  • Scripts/svn-apply:
  • Scripts/svn-unapply:
  • Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Added.
  • Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Added.
22:27 Changeset [57439] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WinEWS bot fails to svn update because scm.clean_working_directory leaves files around
https://bugs.webkit.org/show_bug.cgi?id=37401

The Git-based bots don't have this trouble because
Git.clean_working_directory fully removes files that were
marked as "add". SVN.clean_working_directory previously just
called "svn revert" which would leave added files in the
working directory untracked. This patch makes
SVN.clean_working_directory function more like
Git.clean_working_directory by removing added files after revert.

  • Scripts/webkitpy/common/checkout/scm.py:
    • Add SCM.absolute_path for easy conversion between repository-relative paths and absolute paths.
    • Add SCM.add and SCM.added_files
    • Make SVN.clean_working_directory remove any added_files after svn revert.
    • The new unit tests found a bug in Git.status_command, change to use git diff --name-status instead.
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Add tests for added code.
22:17 Changeset [57438] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-10 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Defense in depth: make sure an SVG document in the <img> context has
a unique origin.

https://bugs.webkit.org/show_bug.cgi?id=37392

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Force the temporary rendering context into a unique origin.
  • loader/FrameLoader.h: (WebCore::FrameLoader::setForceSandboxFlags): Support for setting sandbox flags that will always be applied.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateSandboxFlags): Always apply any forced flags.
22:10 Changeset [57437] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests can't find ImageDiff on Windows
https://bugs.webkit.org/show_bug.cgi?id=37403

It turns out the build directory on Windows is structured differently
than it is on other platforms. Instead of assuming the normal
structure, we should just ask perl to figure it out for us.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
22:03 Changeset [57436] by eric@webkit.org
  • 4 edits
    6 moves in trunk

2010-04-10 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Moving files associated with the GPU compositor from platform/graphics/skia to platform/graphics/chromium. Class
rename was done in a previous CL, this CL does the file move and rename.
https://bugs.webkit.org/show_bug.cgi?id=37231

No new functionality, no new tests.

  • WebCore.gypi:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: Copied from WebCore/platform/graphics/skia/GraphicsLayerSkia.cpp.
  • platform/graphics/chromium/GraphicsLayerChromium.h: Copied from WebCore/platform/graphics/skia/GraphicsLayerSkia.h.
  • platform/graphics/chromium/LayerChromium.cpp: Copied from WebCore/platform/graphics/skia/LayerSkia.cpp.
  • platform/graphics/chromium/LayerChromium.h: Copied from WebCore/platform/graphics/skia/LayerSkia.h.
  • platform/graphics/chromium/LayerRendererChromium.cpp: Copied from WebCore/platform/graphics/skia/LayerRendererSkia.cpp.
  • platform/graphics/chromium/LayerRendererChromium.h: Copied from WebCore/platform/graphics/skia/LayerRendererSkia.h.
  • platform/graphics/skia/GraphicsLayerSkia.cpp: Removed.
  • platform/graphics/skia/GraphicsLayerSkia.h: Removed.
  • platform/graphics/skia/LayerRendererSkia.cpp: Removed.
  • platform/graphics/skia/LayerRendererSkia.h: Removed.
  • platform/graphics/skia/LayerSkia.cpp: Removed.
  • platform/graphics/skia/LayerSkia.h: Removed.

2010-04-10 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Include file change as a result of renaming LayerRenderSkia.h to LayerRenderChromium.h
https://bugs.webkit.org/show_bug.cgi?id=37231

  • src/WebViewImpl.h:
21:03 Changeset [57435] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Change "Gathering files" status line to "Collecting tests". Gathering
the files sounds silly to me.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
20:51 Changeset [57434] by abarth@webkit.org
  • 4 edits
    1 add in trunk

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix bugs to make new-run-webkit-tests almost run on windows
https://bugs.webkit.org/show_bug.cgi?id=37400

Add an empty test expectations file. I'm not sure whether we'll use
this one or make a common one for each port. However, as written, this
file is requires to run new-run-webkit-tests on Windows.

  • platform/win/test_expectations.txt: Added.

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix bugs to make new-run-webkit-tests almost run on windows
https://bugs.webkit.org/show_bug.cgi?id=37400

Fix some minor bugs that prevent new-run-webkit-tests from being run on
Windows. I still haven't run it to completion, but I'm getting
further.

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
18:35 Changeset [57433] by eric@webkit.org
  • 17 edits
    2 adds in trunk

2010-04-10 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

https://bugs.webkit.org/show_bug.cgi?id=35844

  • WebCore.pro: Add DumpRenderTreeSupportQt.cpp

2010-04-10 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

Move all QT DRT support functions to a static class.

https://bugs.webkit.org/show_bug.cgi?id=35844

  • Api/qwebframe.cpp: Remove static functions.
  • Api/qwebframe.h: Make DumpRenderTreeSupportQt a friend.
  • Api/qwebpage.cpp: Remove static functions.
  • Api/qwebpage.h: Make DumpRenderTreeSupportQt a friend.
  • Api/qwebsecurityorigin.cpp: Remove static functions.
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: Added. (DumpRenderTreeSupportQt::DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::~DumpRenderTreeSupportQt): (DumpRenderTreeSupportQt::overwritePluginDirectories): (DumpRenderTreeSupportQt::workerThreadCount): (DumpRenderTreeSupportQt::setDumpRenderTreeModeEnabled): (DumpRenderTreeSupportQt::setFrameFlatteningEnabled): (DumpRenderTreeSupportQt::webPageSetGroupName): (DumpRenderTreeSupportQt::webPageGroupName): (DumpRenderTreeSupportQt::webInspectorExecuteScript): (DumpRenderTreeSupportQt::webInspectorClose): (DumpRenderTreeSupportQt::webInspectorShow): (DumpRenderTreeSupportQt::setTimelineProfilingEnabled): (DumpRenderTreeSupportQt::hasDocumentElement): (DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled): (DumpRenderTreeSupportQt::pauseAnimation): (DumpRenderTreeSupportQt::pauseTransitionOfProperty): (DumpRenderTreeSupportQt::pauseSVGAnimation): (DumpRenderTreeSupportQt::numberOfActiveAnimations): (DumpRenderTreeSupportQt::clearFrameName): (DumpRenderTreeSupportQt::javaScriptObjectsCount): (DumpRenderTreeSupportQt::garbageCollectorCollect): (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread): (DumpRenderTreeSupportQt::counterValueForElementById): (DumpRenderTreeSupportQt::pageNumberForElementById): (DumpRenderTreeSupportQt::numberOfPages): (DumpRenderTreeSupportQt::suspendActiveDOMObjects): (DumpRenderTreeSupportQt::resumeActiveDOMObjects): (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld): (DumpRenderTreeSupportQt::whiteListAccessFromOrigin): (DumpRenderTreeSupportQt::resetOriginAccessWhiteLists): (DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme): (DumpRenderTreeSupportQt::setCaretBrowsingEnabled): (DumpRenderTreeSupportQt::setMediaType): (DumpRenderTreeSupportQt::setViewMode):
  • WebCoreSupport/DumpRenderTreeSupportQt.h: Added.
  • WebCoreSupport/EditorClientQt.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::multiplePageGroupsAndLocalStorage): (tst_QWebPage::inputMethodsTextFormat): (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):

2010-04-10 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Refactor Qt DRT support in QtWebKit

Update Qt DRT to use new DumpRenderTreeSupportQt static class.

https://bugs.webkit.org/show_bug.cgi?id=35844

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::dumpFramesAsText):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/GCControllerQt.cpp: (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
  • DumpRenderTree/qt/GCControllerQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::counterValueForElementById): (LayoutTestController::setViewModeMediaFeature): (LayoutTestController::setMediaType): (LayoutTestController::closeWebInspector): (LayoutTestController::showWebInspector): (LayoutTestController::evaluateInWebInspector): (LayoutTestController::setFrameFlatteningEnabled): (LayoutTestController::setJavaScriptProfilingEnabled): (LayoutTestController::setTimelineProfilingEnabled): (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::sampleSVGAnimationForElementAtTime): (LayoutTestController::numberOfActiveAnimations): (LayoutTestController::whiteListAccessFromOrigin): (LayoutTestController::setCaretBrowsingEnabled): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme): (LayoutTestController::workerThreadCount): (LayoutTestController::pageNumberForElementById): (LayoutTestController::numberOfPages):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
18:25 Changeset [57432] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move global queue log to the logs directory so it survives git clean -f
https://bugs.webkit.org/show_bug.cgi?id=37395

  • Scripts/webkitpy/tool/commands/queues.py:
18:16 Changeset [57431] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-10 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Eric Seidel.

Cleanup after chromium breakage. All interface methods are
returned to being abstract.

  • public/WebNotificationPresenter.h:
18:06 Changeset [57430] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should spam when it encounters errors
https://bugs.webkit.org/show_bug.cgi?id=37329

We need to always update the status server so we don't get stuck in a
spam loop. I tried writing a test for this change, but it kind of
got out of control. We need a better way to do failure injection.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:
17:51 Changeset [57429] by joepeck@webkit.org
  • 4 edits in trunk/WebCore

2010-04-10 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by David Kilzer.

Missing CONTEXT_MENUS Guards
https://bugs.webkit.org/show_bug.cgi?id=37398

Added missing ENABLE(CONTEXT_MENUS) guards.

  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::disconnectClient):
  • inspector/InspectorFrontendHost.h:
17:49 Changeset [57428] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-10 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Add slow expectations based on webkit-dev discussion.

  • platform/mac/test_expectations.txt:
17:44 Changeset [57427] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Unreviewed attempt to fix the Chromium Mac canary.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
  • Scripts/webkitpy/common/system/executive.py:
17:28 Changeset [57426] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Unreviewed.

Add the Apache bits to win.py for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37397

I still have run this yet, but I looked around to figure out what the
various paths appear to be. I'll figure out a way to remove the
copy/paste code in a future patch.

  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
16:39 Changeset [57425] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out the win port for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37393

I haven't tried running this yet, but we've got to start somewhere.

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py: Added.
15:44 Changeset [57424] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-10 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

webkit-patch land should not build and test by default
https://bugs.webkit.org/show_bug.cgi?id=33631

Reverse the sense of --no-build and --no-test to be --build and --test.
Also, decoupled the build and test options so you can test without
building.

(Patch manngled by Adam Barth. All bugs are his fault.)

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
15:18 Changeset [57423] by abarth@webkit.org
  • 4 edits
    1 copy in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor WebKitPort out of MacPort to allow for WinPort
https://bugs.webkit.org/show_bug.cgi?id=37388

The split is a bit of a guess. We might have to adjust things once we
actually have a second port to work with.

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py: Added.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
15:17 Changeset [57422] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

run_webkit_tests.py shouldn't have platform-specific logic
https://bugs.webkit.org/show_bug.cgi?id=37387

Dirk Pranke pointed out that my last patch was wrong because I
introduced platform-specific logic into run_webkit_tests.py, limiting
the parallelism in Chromium to work around a bug in the main Mac port.

  • Scripts/webkitpy/common/system/executive.py:
    • Fix a typo pointed out by Chris Jerdonek.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15:09 Changeset [57421] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Fix an obviously incorrect part of the Xcode configuration cleanup that resulted in debug builds
asserting shortly after launch.

  • WebKit2.xcodeproj/project.pbxproj: Fix the setting of DEBUG_DEFINES for the Debug configuration.
14:39 Changeset [57420] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-10 Stephan Aßmus <superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Fix crash in Gradient::fill()
https://bugs.webkit.org/show_bug.cgi?id=37386

Covered by existing tests.

  • platform/graphics/haiku/GradientHaiku.cpp: (WebCore::Gradient::fill):
    • Make sure the platform gradient is already cached before dereferencing its pointer.
14:30 Changeset [57419] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-10 Stephan Aßmus <superstippi@gmx.de>

Reviewed by Eric Seidel.

[Haiku] Fix build of ImageHaiku.cpp
<https://bugs.webkit.org/show_bug.cgi?id=37384>

No new tests needed.

  • platform/graphics/haiku/ImageHaiku.cpp: (WebCore::Image::drawPattern):
    • include SharedBuffer.h
    • changed parameter name to be in line with other ports, the code I landed in an earlier commit was already using this name.
05:28 Changeset [57418] by robert@webkit.org
  • 4 edits in trunk

[Qt] Fix regressions in http/tests/navigation from r57416

2010-04-10 Robert Hogan <robert@webkit.org>

Unreviewed fix to regressions in r57416.

[Qt] Fix regressions in http/tests/navigation from r57416

Unskip tests skipped after regression in r57416.

https://bugs.webkit.org/show_bug.cgi?id=37237

  • platform/qt/Skipped:

2010-04-10 Robert Hogan <robert@webkit.org>

Unreviewed fix to regressions in r57416.

[Qt] Fix regressions in http/tests/navigation from r57416

Reset willSendRequestReturnsNullOnRedirect after each test to
prevent it leaking to subsequent tests.

Error pointed out by Jakub Wieczorek.

https://bugs.webkit.org/show_bug.cgi?id=37237

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
03:41 Changeset [57417] by robert@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

2010-04-10 Robert Hogan <robert@webkit.org>

Unreviewed fix to regressions from r57416.

Add expected results missing from r57416

Skip 2 tests that now fail.

http/tests/navigation/postredirect-reload.html
http/tests/navigation/redirect302-basic.html

These regressions will be worked under:
https://bugs.webkit.org/show_bug.cgi?id=37237

  • platform/qt/Skipped:
  • platform/qt/http/tests/misc/window-dot-stop-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.
03:12 Changeset [57416] by robert@webkit.org
  • 8 edits in trunk

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Unskip http/tests/xmlhttprequest/abort-should-cancel-load.html

http/tests/misc/will-send-request-returns-null-on-redirect.html
fast/loader/user-style-sheet-resource-load-callbacks.html
http/tests/misc/window-dot-stop.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html

QNetworkReply::OperationCanceledError has a value of 5 rather than -999, so add platform-specific results accordingly.

Add platform-specific results for the the following, though leave them skipped for now. They've started failing again
since review was granted (see https://bugs.webkit.org/show_bug.cgi?id=37382):

http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

https://bugs.webkit.org/show_bug.cgi?id=37237

  • platform/qt/Skipped:
  • platform/qt/http/tests/misc/window-dot-stop-expected.txt: Added.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • platform/qt/http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Unskip http/tests/xmlhttprequest/abort-should-cancel-load.html

http/tests/misc/will-send-request-returns-null-on-redirect.html
fast/loader/user-style-sheet-resource-load-callbacks.html
http/tests/misc/window-dot-stop.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
http/tests/xmlhttprequest/abort-should-cancel-load.html

QNetworkReply::OperationCanceledError has a value of 5, so update expected results accordingly.

https://bugs.webkit.org/show_bug.cgi?id=37237

  • WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null_on_redirect): (drtDescriptionSuitableForTestResult): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoading): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.

Add support for layoutTestController.setWillSendRequestReturnsNullOnRedirect to Qt DRT.
Prevent dumping resource load callbacks once layout test has dumped.

https://bugs.webkit.org/show_bug.cgi?id=37237

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
02:09 Changeset [57415] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, fixing description and expectation for media/video-replaces-poster.html.

  • platform/chromium/test_expectations.txt:
02:06 Changeset [57414] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, marking media/video-replaces-poster.html as flaky.

  • platform/chromium/test_expectations.txt:
01:35 Changeset [57413] by scherkus@chromium.org
  • 3 edits in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in corrected baselines for media/video-replaces-poster.html
on Chromium Win.

  • platform/chromium-win/media/video-replaces-poster-expected.checksum:
  • platform/chromium-win/media/video-replaces-poster-expected.png:
01:18 Changeset [57412] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed, platform specific expected files updated after r57408.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: updated.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
01:11 Changeset [57411] by scherkus@chromium.org
  • 120 edits
    41 adds in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, enable the rest of the fast/media tests for Chromium Mac and Linux
by checking in new baselines.

  • platform/chromium-linux/fast/media/media-descriptor-syntax-01-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-01-expected.png:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-02-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-02-expected.png:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-03-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-03-expected.png:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-04-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-04-expected.png:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-05-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-05-expected.png:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-06-expected.checksum:
  • platform/chromium-linux/fast/media/media-descriptor-syntax-06-expected.png:
  • platform/chromium-linux/fast/media/media-type-syntax-01-expected.checksum:
  • platform/chromium-linux/fast/media/media-type-syntax-01-expected.png:
  • platform/chromium-linux/fast/media/media-type-syntax-02-expected.checksum:
  • platform/chromium-linux/fast/media/media-type-syntax-02-expected.png:
  • platform/chromium-linux/fast/media/mq-animation-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-animation-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-aspect-ratio-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-aspect-ratio-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-compound-query-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-compound-query-01-expected.png:
  • platform/chromium-linux/fast/media/mq-compound-query-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-compound-query-02-expected.png:
  • platform/chromium-linux/fast/media/mq-compound-query-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-compound-query-03-expected.png:
  • platform/chromium-linux/fast/media/mq-compound-query-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-compound-query-04-expected.png:
  • platform/chromium-linux/fast/media/mq-compound-query-05-expected.checksum:
  • platform/chromium-linux/fast/media/mq-compound-query-05-expected.png:
  • platform/chromium-linux/fast/media/mq-grid-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-grid-01-expected.png:
  • platform/chromium-linux/fast/media/mq-grid-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-grid-02-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-01-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-02-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-03-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-media-feature-04-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-01-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-02-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-03-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-04-expected.png:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-05-expected.checksum:
  • platform/chromium-linux/fast/media/mq-invalid-syntax-05-expected.png:
  • platform/chromium-linux/fast/media/mq-js-media-except-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-media-except-01-expected.png:
  • platform/chromium-linux/fast/media/mq-js-media-except-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-media-except-02-expected.png:
  • platform/chromium-linux/fast/media/mq-js-media-except-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-media-except-03-expected.png:
  • platform/chromium-linux/fast/media/mq-js-media-forward-syntax-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-media-forward-syntax-expected.png:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-01-expected.png:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-02-expected.png:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-03-expected.png:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-js-stylesheet-media-04-expected.png:
  • platform/chromium-linux/fast/media/mq-max-pixel-ratio-expected.checksum:
  • platform/chromium-linux/fast/media/mq-max-pixel-ratio-expected.png:
  • platform/chromium-linux/fast/media/mq-min-constraint-expected.checksum:
  • platform/chromium-linux/fast/media/mq-min-constraint-expected.png:
  • platform/chromium-linux/fast/media/mq-orientation-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-orientation-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-pixel-ratio-expected.checksum:
  • platform/chromium-linux/fast/media/mq-pixel-ratio-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-01-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-02-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-03-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-04-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-05-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-neg-query-05-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-query-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-query-01-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-query-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-query-02-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-query-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-query-03-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-query-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-query-04-expected.png:
  • platform/chromium-linux/fast/media/mq-simple-query-05-expected.checksum:
  • platform/chromium-linux/fast/media/mq-simple-query-05-expected.png:
  • platform/chromium-linux/fast/media/mq-transform-01-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-transform-01-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-transform-02-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-transform-02-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-transform-03-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-transform-03-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-transform-04-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-transform-04-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-transition-expected.checksum: Added.
  • platform/chromium-linux/fast/media/mq-transition-expected.png: Added.
  • platform/chromium-linux/fast/media/mq-valueless-expected.checksum:
  • platform/chromium-linux/fast/media/mq-valueless-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-01-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-02-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-03-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-04-expected.png:
  • platform/chromium-linux/fast/media/viewport-media-query-expected.checksum:
  • platform/chromium-linux/fast/media/viewport-media-query-expected.png:
  • platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-01-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-02-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-03-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-04-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png: Added.
  • platform/chromium/test_expectations.txt:
00:47 Changeset [57410] by scherkus@chromium.org
  • 4 edits
    8 adds in trunk/LayoutTests

2010-04-10 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in updated baselines and expectations for Chromium media layout tests.

  • platform/chromium-linux/media/video-replaces-poster-expected.checksum: Added.
  • platform/chromium-linux/media/video-replaces-poster-expected.png: Added.
  • platform/chromium-mac/media/controls-drag-timebar-expected.txt: Added.
  • platform/chromium-mac/media/video-currentTime-set-expected.txt:
  • platform/chromium-mac/media/video-replaces-poster-expected.checksum: Added.
  • platform/chromium-mac/media/video-replaces-poster-expected.png: Added.
  • platform/chromium-win/media/controls-drag-timebar-expected.txt: Added.
  • platform/chromium-win/media/video-currentTime-set-expected.txt:
  • platform/chromium-win/media/video-replaces-poster-expected.checksum: Added.
  • platform/chromium-win/media/video-replaces-poster-expected.png: Added.
  • platform/chromium/test_expectations.txt:
00:46 Changeset [57409] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] animations/dynamic-stylesheet-loading.html fails with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=37381

  • platform/qt/Skipped: animations/dynamic-stylesheet-loading.html skipped until fix.
00:35 Changeset [57408] by laszlo.1.gombos@nokia.com
  • 13 edits
    2 adds in trunk

2010-04-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

Map WebKit notifications to Qt's SystemTray API and
implement DRT tracing.

This patch does not implement the security part of
WebKit notifications.

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::notificationPresenter):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp: Added. (qt_dump_notification): (NotificationPresenterClientQt::NotificationPresenterClientQt): (NotificationPresenterClientQt::show): (NotificationPresenterClientQt::cancel): (NotificationPresenterClientQt::notificationObjectDestroyed): (NotificationPresenterClientQt::requestPermission): (NotificationPresenterClientQt::checkPermission):
  • WebCoreSupport/NotificationPresenterClientQt.h: Added.

2010-04-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

No new tests enabled as notification DRT tests are
disabled at the moment.

  • WebCore.pri: Add files to the build system and turn on the feature by default.
  • WebCore.pro: Add files to the build system
  • bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission): (WebCore::JSNotification::addEventListener): (WebCore::JSNotification::removeEventListener): Fix build regresssion.

2010-04-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement Desktop Notifications API for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=35503

DRT stubs for notification. Enables to run and pass
3 (currently disabled) tests.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::checkDesktopNotificationPermission):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

04/09/10:

23:35 Changeset [57407] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, another change to executive.py to make it run with
python 2.4.

  • Scripts/webkitpy/common/system/executive.py:
23:20 Changeset [57406] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, attempting to make executive.py run with python 2.4
(which is still used on Chromium's Windows canary bot).

  • Scripts/webkitpy/common/system/executive.py:
22:02 Changeset [57405] by pfeldman@chromium.org
  • 6 edits in trunk

2010-04-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Console with two recursive arrays causes infinite loop trying to display.
https://bugs.webkit.org/show_bug.cgi?id=37133

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._printArray): (WebInspector.ConsoleView.prototype._formatAsArrayEntry):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
20:18 WebKit2 edited by dbates@webkit.org
Spelling corrections. (diff)
20:09 Changeset [57404] by eric@webkit.org
  • 11 edits in trunk

2010-04-09 Kevin Watters <kevinwatters@gmail.com>

Reviewed by Eric Seidel.

[wx] Basic implementation of SVG support for wx port.

  • css/CSSFontFaceSource.cpp:
  • platform/graphics/wx/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size):
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::setLineDash):
  • platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::strokeContains): (WebCore::Path::debugString): (WebCore::Path::operator=): (WebCore::Path::isEmpty):
  • rendering/RenderSVGResourceMasker.cpp:
  • wscript:

2010-04-09 Kevin Watters <kevinwatters@gmail.com>

Reviewed by Eric Seidel.

[wx] Basic implementation of SVG support for wx port.

  • wx/build/settings.py:
19:59 Changeset [57403] by eric@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-04-09 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):
19:50 Changeset [57402] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-09 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] Linux: respect the scale factor during printing
https://bugs.webkit.org/show_bug.cgi?id=37168

Chromium doesn't support testing .pdfs from printing at the moment, so
this change is not covered by any tests.

  • src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::spoolPage):
19:34 Changeset [57401] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-04-09 Aaron Boodman <aa@chromium.org>

Reviewed by Eric Seidel.

Remove applicationID() from WebDocument as it is Chromium-specific.
https://bugs.webkit.org/show_bug.cgi?id=37350

  • public/WebDocument.h:
  • src/WebDocument.cpp:
19:24 Changeset [57400] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-09 Adam Barth <abarth@webkit.org>

Unreviewed.

Test a theory about why this is failing downstream.

  • http/tests/security/xss-DENIED-mime-type-execute-as-html.html:
19:17 Changeset [57399] by abarth@webkit.org
  • 10 edits in trunk/WebKitTools

2010-04-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't reinvent Executive.cpu_count for every port
https://bugs.webkit.org/show_bug.cgi?id=37377

mac.py and chromium_mac.py had some copy/paste code. This code doesn't
actually have anything to do with WebKit ports. It's really just
something in the multiprocessing package. The lame bit is that package
isn't available in older versions of Python, so we need to implement a
fallback. However, we already have the fallback in common. We don't
need to reinvent it specificly for layout_tests.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
19:17 Changeset [57398] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests --release fails to build release DRT when global configuration is Debug
https://bugs.webkit.org/show_bug.cgi?id=37376

We need to explicitly pass the --release flag. I bet there are more
instances of this bug.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
19:16 Changeset [57397] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-09 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt]Fix compile error with QT_NO_IM
https://bugs.webkit.org/show_bug.cgi?id=36533

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup):
19:13 Changeset [57396] by scherkus@chromium.org
  • 59 edits in trunk/LayoutTests

2010-04-09 Sergey Ulanov <sergeyu@chromium.org>

Unreviewed, checking in baselines due to Chromium's new video scaling algorithm.

  • platform/chromium-linux/media/controls-after-reload-expected.checksum:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.checksum:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-layer-crash-expected.checksum:
  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.checksum:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.checksum:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.checksum:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.checksum:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-layer-crash-expected.checksum:
  • platform/chromium-mac/media/video-layer-crash-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-transformed-expected.checksum:
  • platform/chromium-mac/media/video-transformed-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.checksum:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.checksum:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.checksum:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.checksum:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.checksum:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.checksum:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-transformed-expected.checksum:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.checksum:
  • platform/chromium-win/media/video-volume-slider-expected.png:
19:06 Changeset [57395] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-09 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] DRT compile fix on win/linux
https://bugs.webkit.org/show_bug.cgi?id=37314

Looks like this was missed when upstreaming.

  • DumpRenderTree/chromium/EventSender.cpp: (applyKeyModifier):
18:56 Changeset [57394] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-09 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

StorageEvent destructor should be in StorageEvent.cpp
https://bugs.webkit.org/show_bug.cgi?id=37356

Because Storage is forward-declared in StorageEvent.h, we need to define
the StorageEvent destructor in the .cpp file so that the RefPtr<Storage>
destructor has a complete type for Storage.

  • storage/StorageEvent.cpp: (WebCore::StorageEvent::~StorageEvent):
  • storage/StorageEvent.h:
18:45 Changeset [57393] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-04-09 Young Han Lee <joybro@company100.net>

Reviewed by Eric Seidel.

[WINCE] Add forwarding header for UnicodeWince.h
https://bugs.webkit.org/show_bug.cgi?id=37224

  • ForwardingHeaders/wtf/unicode/wince/UnicodeWince.h: Added.
18:15 Changeset [57392] by mrowe@apple.com
  • 5 edits in trunk/WebKit2

Bring the WebKit2 Xcode configuration in to sync with recent changes to the WebKit Xcode configuration files.

Reviewed by Sam Weinig.

In particular, this updates the FEATURE_DEFINES to match those used in the other projects, and brings in
the changes to support building WebKit for older Mac OS X versions from the current Mac OS X version.

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:
18:09 Changeset [57391] by ggaren@apple.com
  • 7 edits in trunk/WebCore

Tidied up some more DOMWrapperWorld lifetime issues.

Reviewed by Sam "R the K!" Weinig.

  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld): Notify the document that
we're going away instead of deleting its data, since deleting other
objects' data is error-prone and, more importantly, rude.

  • bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::didCreateWrapperCache):
(WebCore::DOMWrapperWorld::didDestroyWrapperCache): A few renames for
clarity.

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h: Converted forgetAllDOMNodesForDocument

to a Document member function, for the same reason.

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::createWrapperCache):
(WebCore::Document::destroyWrapperCache):
(WebCore::Document::destroyAllWrapperCaches):

  • dom/Document.h: Added a destroyWrapperCache function to balance

createWrapperCache, so it's clear who allocates and deletes these wrapper
caches.

18:00 Changeset [57390] by cmarrin@apple.com
  • 4 edits
    4 adds in trunk

Reviewed by Simon Fraser.

Fixed bug where animation time was not updated when dynamically loading a style sheet
https://bugs.webkit.org/show_bug.cgi?id=37352

A dynamically loaded style sheet kicks off its own styleRecalc cycle. This was not
bracketed with a beginAnimationUpdate/endAnimationUpdate which wasn't resetting the
animation time. In some time-dependent cases this was causing a negative elapsedTime
to be sent to the keyframe animator. This is an invalid case which destroys the
animation prematurely. I not only added the brackets, but I also added an assert
and protection for when the elapsedTime comes up negative.

Test: animations/dynamic-stylesheet-loading.html

  • dom/Document.cpp: Added brackets (WebCore::Document::updateStyleSelector):
  • page/animation/KeyframeAnimation.cpp: Added assert and protection (WebCore::KeyframeAnimation::getKeyframeAnimationInterval):
17:52 Changeset [57389] by mrowe@apple.com
  • 5 edits
    1 copy
    1 move
    1 add in trunk/WebKit2

Clean up the Xcode project configuration.

Reviewed by Sam Weinig.

Common target settings are pulled out in to BaseTarget.xcconfig. The majority of setting overrides are
removed from the Xcode project itself. Info.plist files are updated to match those used in other frameworks.

  • Configurations/BaseTarget.xcconfig: Copied from WebKit2/Configurations/WebKit2.xcconfig.
  • Configurations/WebKit2.xcconfig:
  • Configurations/WebProcess.xcconfig: Copied from WebKit2/Configurations/WebKit2.xcconfig.
  • Info.plist:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess-Info.plist: Removed.
  • WebProcess/Info.plist: Moved from WebProcess-Info.plist.
17:51 Changeset [57388] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-09 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebFrame::popupFocus() fails
https://bugs.webkit.org/show_bug.cgi?id=37320

The QWebPopup class has been moved & renamed, so tst_QWebFrame::popupFocus() should use
the class name "QComboBox", rather than "WebCore::QWebPopup" to find the popup menu.

  • tests/qwebframe/tst_qwebframe.cpp:
17:41 Changeset [57387] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-09 Jaime Yap <jaimeyap@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Fixes "wrong parent" for GCEvents that come at the end of a
timeline record node.
https://bugs.webkit.org/show_bug.cgi?id=37340

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
17:26 Changeset [57386] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

2010-04-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Prevent HTTP responses served with JSON content type from being rendered as HTML.

Test: http/tests/security/xss-DENIED-mime-type-execute-as-html.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isTextMIMEType): Render application/json as text/plain.
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): Add a compile assert to prevent addition of new mime types in non-image types.

2010-04-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Test non-image and javascript mime types are not rendered as HTML.

  • http/tests/security/resources/send-mime-types.php: Added.
  • http/tests/security/xss-DENIED-mime-type-execute-as-html-expected.txt: Added.
  • http/tests/security/xss-DENIED-mime-type-execute-as-html.html: Added.
16:45 Changeset [57385] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.m:

(InitWebCoreSystemInterface): Update for recent WKSI changes.

16:40 Changeset [57384] by hamaji@chromium.org
  • 3 edits in trunk/WebCore

2010-04-09 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

Prevent wrong use of PrintContext
https://bugs.webkit.org/show_bug.cgi?id=37194

No new tests because this doesn't change the behavior.

  • page/PrintContext.cpp: (WebCore::PrintContext::PrintContext): (WebCore::PrintContext::~PrintContext): (WebCore::PrintContext::begin): (WebCore::PrintContext::end):
  • page/PrintContext.h:
16:28 Changeset [57383] by abarth@webkit.org
  • 1 edit
    1 move in trunk/WebKitTools

2010-04-09 Adam Barth <abarth@webkit.org>

Unreviewed, but approved by Dirk Pranke.

rename test_expectations_test.py to test_expectations_unittest.py so it actually gets run
https://bugs.webkit.org/show_bug.cgi?id=37372

We need to end unit tests with _unittest.py for them to be autodetected
by the test harness. +6 tests.

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py.
16:28 Changeset [57382] by vitalyr@chromium.org
  • 2 edits in trunk/WebCore

2010-04-09 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Darin Fisher.

[V8] SerializedScriptValue value doesn't follow the spec for DOM objects and files
https://bugs.webkit.org/show_bug.cgi?id=37094

This patch adds support for file-related types.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::): (WebCore::Writer::writeString): (WebCore::Writer::writeWebCoreString): (WebCore::Writer::writeBlob): (WebCore::Writer::writeFile): (WebCore::Writer::writeFileList): (WebCore::Writer::doWriteString): (WebCore::Writer::doWriteWebCoreString): (WebCore::Serializer::writeBlob): (WebCore::Serializer::writeFile): (WebCore::Serializer::writeFileList): (WebCore::Serializer::doSerialize): (WebCore::Reader::read): (WebCore::Reader::readWebCoreString): (WebCore::Reader::readBlob): (WebCore::Reader::readFile): (WebCore::Reader::readFileList): (WebCore::SerializedScriptValue::SerializedScriptValue):
16:19 Changeset [57381] by abarth@webkit.org
  • 6 edits
    1 move in trunk/WebKitTools

2010-04-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should talk about DumpRenderTree not test_shell
https://bugs.webkit.org/show_bug.cgi?id=37371

test_shell is some strange Chromium thing.
DumpRenderTree (tm) is the real deal.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16:18 Changeset [57380] by zoltan@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-09 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix 2 issues (what were introduced in r56524) in svn-create-patch's generateDiff()
https://bugs.webkit.org/show_bug.cgi?id=32582

Add missing return variable. Initialize $patch variable and remove unnecessary condition.

  • Scripts/svn-create-patch:
16:16 Changeset [57379] by ggaren@apple.com
  • 7 edits in trunk/WebCore

Tidied up some DOMWrapperWorld lifetime issues.

Reviewed by Cameron Zwarich.

  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld): Made DOMWrapperWorld wholly
responsible for managing its presence in WebCoreJSClientData's world set.
This is simpler and more encapsulated than making its clients sometimes
responsible for managing that set and sometimes not.

  • bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::create): Made isNormal default to false,
removing one of the reasons for the IsolatedWorld class to exist, so I
could remove that class.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData): Used the work-around below.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWorld): Nixed IsolatedWorld, which is
now superfluous.

  • bindings/js/WebCoreJSClientData.h:

(WebCore::initNormalWorldClientData): Added a work-around for the fact
that WebCoreJSClientData must be set as globalData->clientData before
the DOMWrapperWorld constructor runs. This removed the other reason
for the IsolatedWorld class to exist, so I could remove that class.

16:12 Changeset [57378] by yaar@chromium.org
  • 1 edit
    5 adds in trunk/WebCore

2010-04-09 Yaar Schnitman <yaar@chromium.org>

Reviewed by Nate Chapin.

Testing utility for CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=37286

  • bindings/v8/test: Added.
  • bindings/v8/test/TestObj.idl: Contains basic IDL definitions for testing purposes.
  • bindings/v8/test/V8TestObj.cpp: Expected output.
  • bindings/v8/test/V8TestObj.h: Expected output.
  • bindings/v8/test/run_tests.py: Tool for generating the above h/cpp files from the idl file.
15:58 Changeset [57377] by darin@apple.com
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=37370
Division by 0 in RenderBoxModelObject::calculateFillTileSize

Reviewed by Maciej Stachowiak.

WebCore:

Test: fast/backgrounds/background-fill-zero-area-crash.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize): Added checks for
zero before doing division. These come up when the area to fill is zero.

LayoutTests:

  • fast/backgrounds/background-fill-zero-area-crash-expected.txt: Added.
  • fast/backgrounds/background-fill-zero-area-crash.html: Added.
15:53 Changeset [57376] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after addition of LayoutTestController method.

15:50 Changeset [57375] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix for https://bugs.webkit.org/show_bug.cgi?id=37351
Cannot build with build-webkit --webkit2

Reviewed by Darin Adler.

Add some headers that it seems others are not getting
already.

  • Platform/mac/WorkQueueMac.cpp: #inlude <mach/mach_port.h>
  • Shared/mac/UpdateChunk.cpp: #inlude <mach/vm_map.h>
15:46 Changeset [57374] by weinig@apple.com
  • 1 edit
    29 adds in trunk/WebKitTools

Fix for https://bugs.webkit.org/show_bug.cgi?id=37368
Add MiniBrowser.

Reviewed by Anders Carlsson.

  • MiniBrowser: Added.
  • MiniBrowser/MiniBrowser.vcproj: Added.
  • MiniBrowser/MiniBrowser.xcodeproj: Added.
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added.
  • MiniBrowser/mac: Added.
  • MiniBrowser/mac/AppDelegate.h: Added.
  • MiniBrowser/mac/AppDelegate.m: Added.
  • MiniBrowser/mac/BrowserWindowController.h: Added.
  • MiniBrowser/mac/BrowserWindowController.m: Added.
  • MiniBrowser/mac/English.lproj: Added.
  • MiniBrowser/mac/English.lproj/BrowserWindow.xib: Added.
  • MiniBrowser/mac/English.lproj/InfoPlist.strings: Added.
  • MiniBrowser/mac/English.lproj/MainMenu.xib: Added.
  • MiniBrowser/mac/MiniBrowser-Info.plist: Added.
  • MiniBrowser/mac/MiniBrowser_Prefix.pch: Added.
  • MiniBrowser/mac/main.m: Added.
  • MiniBrowser/win: Added.
  • MiniBrowser/win/BrowserView.cpp: Added.
  • MiniBrowser/win/BrowserView.h: Added.
  • MiniBrowser/win/BrowserWindow.cpp: Added.
  • MiniBrowser/win/BrowserWindow.h: Added.
  • MiniBrowser/win/MiniBrowser.cpp: Added.
  • MiniBrowser/win/MiniBrowser.h: Added.
  • MiniBrowser/win/MiniBrowser.rc: Added.
  • MiniBrowser/win/Resources: Added.
  • MiniBrowser/win/main.cpp: Added.
  • MiniBrowser/win/resource.h: Added.
  • MiniBrowser/win/stdafx.cpp: Added.
  • MiniBrowser/win/stdafx.h: Added.
15:33 Changeset [57373] by ap@apple.com
  • 16 edits
    3 copies
    2 adds
    2 deletes in trunk

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=24572
XMLHttpRequest.statusText returns always "OK" on Mac

Covered by existing tests, which now pass.

  • WebCore.base.exp:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: Added a WebKitSystemInterface method to fetch status line.
  • platform/network/HTTPParsers.cpp: (WebCore::extractReasonPhraseFromHTTPStatusLine):
  • platform/network/HTTPParsers.h:
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit): Moved code for parsing status line to HTTPHeaders, as it's used for both Mac and CF now.
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Use the actual reason phrase when available, and "OK" otherwise. Synthesizing a reson when there isn't one is misleading, so we'll stick to our old broken behavior on Tiger, rather than introduce a new broken one.
15:19 Changeset [57372] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling back the last two changes. The failing tests
are a Chromium problem, not a WebKit one.

  • platform/chromium/test_expectations.txt:
15:14 Changeset [57371] by hyatt@apple.com
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=37361, clean up FillLayer.

Reviewed by Oliver Hunt.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • rendering/style/FillLayer.h:

(WebCore::FillLayer::sizeType):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::backgroundImage):
(WebCore::InheritedFlags::backgroundRepeatX):
(WebCore::InheritedFlags::backgroundRepeatY):
(WebCore::InheritedFlags::backgroundComposite):
(WebCore::InheritedFlags::backgroundAttachment):
(WebCore::InheritedFlags::backgroundClip):
(WebCore::InheritedFlags::backgroundOrigin):
(WebCore::InheritedFlags::backgroundXPosition):
(WebCore::InheritedFlags::backgroundYPosition):
(WebCore::InheritedFlags::backgroundSizeType):
(WebCore::InheritedFlags::backgroundSizeLength):
(WebCore::InheritedFlags::maskImage):
(WebCore::InheritedFlags::maskRepeatX):
(WebCore::InheritedFlags::maskRepeatY):
(WebCore::InheritedFlags::maskComposite):
(WebCore::InheritedFlags::maskAttachment):
(WebCore::InheritedFlags::maskClip):
(WebCore::InheritedFlags::maskOrigin):
(WebCore::InheritedFlags::maskXPosition):
(WebCore::InheritedFlags::maskYPosition):
(WebCore::InheritedFlags::maskSizeType):
(WebCore::InheritedFlags::maskSizeLength):

15:05 Changeset [57370] by mrowe@apple.com
  • 2 edits in tags/Safari-533.4.1/WebKit/win

Merge r57336.

14:59 Changeset [57369] by mrowe@apple.com
  • 4 edits in tags/Safari-533.4.1

Versioning.

14:40 Changeset [57368] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, adding a TIMEOUT expectations for worker-simple.html
on Linux.
https://bugs.webkit.org/show_bug.cgi?id=37274

  • platform/chromium/test_expectations.txt:
14:36 Changeset [57367] by andersca@apple.com
  • 4 edits in trunk/WebKit2

More build fixes.

  • WebProcess/win/WebProcessMain.h:

Include windows.h here.

  • win/WebKit2.def:

Add new exports.

  • win/WebKit2.vcproj:

Add new files.

14:36 Changeset [57366] by mrowe@apple.com
  • 1 copy in tags/Safari-533.4.1

New tag.

14:20 Changeset [57365] by weinig@apple.com
  • 2 edits in trunk/WebCore

Add another missing export to fix the build.

  • WebCore.base.exp:
14:19 Changeset [57364] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Add new WKString.h and WKURL.h headers to top
level include.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WebKit2.h:
14:10 Changeset [57363] by andersca@apple.com
  • 4 edits in trunk/WebKit2

More Windows build fixes.

  • Shared/NotImplemented.h:
  • UIProcess/API/C/cf/WKURLCF.cpp:

Fix typo.

(WKURLCreateWithCFURL):

  • UIProcess/API/C/cf/WKURLCF.h:

Ditto.

  • win/WebKit2Generated.make:

Copy the new CF headers.

14:06 Changeset [57362] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping a test on Linux in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=37359

  • platform/chromium/test_expectations.txt:
14:01 Changeset [57361] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch attached my patch to the wrong bug
https://bugs.webkit.org/show_bug.cgi?id=37015

The problem here is that SVN was violating SCM's implicit
contract of always returning paths relative to the repository root.
That can easily be fixed by telling SVN that the CWD is the repository root.

When fixing this I realized there are a large number of places in SCM.py where
we want to consider explicitly passing self.checkout_root as the CWD.
That would allow scm methods to be executed even when the CWD is not inside
the scm tree at all, and would also make sure (in the case of SVN) that paths
returned are relative to the root. Git (almost always) returns paths relative
to the repository root.

  • Scripts/webkitpy/common/checkout/scm.py:
    • Explicitly pass self.checkout_root as cwd in run_status_and_extract_filenames
    • Add a ton of FIXMEs about the need to go back and decide which methods require cwd=self.checkout_root and which do not. We'll probably add a helper function to scm (likely SCM._run) which always passes cwd=self.checkout_root to Executive.run_command
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Add a test for this change.
  • Scripts/webkitpy/tool/commands/upload.py:
    • Removed the explicit os.chdir to the repository root, since scm.py methods should be robust against the cwd not being equal to the root.
13:51 Changeset [57360] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Two more #include sorting issues.

Reviewed by Anders Carlsson.

  • Shared/NotImplemented.h:
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:
13:49 Changeset [57359] by weinig@apple.com
  • 37 edits in trunk/WebKit2

Fix minor style nits found by the style-script.

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/ArgumentEncoder.cpp:
  • Platform/CoreIPC/Attachment.cpp:
  • Platform/CoreIPC/Connection.cpp:
  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • Platform/CoreIPC/win/ConnectionWin.cpp:
  • Platform/WorkQueue.h:
  • Platform/mac/WorkQueueMac.cpp:
  • Platform/win/RunLoopWin.cpp:
  • Shared/KURLWrapper.h:
  • Shared/WebCoreTypeArgumentMarshalling.h:
  • Shared/mac/UpdateChunk.cpp:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKURL.cpp:
  • UIProcess/Launcher/win/WebProcessLauncher.cpp:
  • UIProcess/ResponsivenessTimer.cpp:
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPolicyClient.cpp:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/win/DrawingAreaProxy.cpp:
  • UIProcess/win/WebView.cpp:
  • WebProcess/Launching/win/WebProcessWinMain.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.h:
  • WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp:
  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
  • WebProcess/WebProcess.h:
  • WebProcess/win/WebLocalizableStrings.cpp:
  • WebProcess/win/WebLocalizableStrings.h:
  • WebProcess/win/WebProcessMain.cpp:
13:44 Changeset [57358] by hyatt@apple.com
  • 5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=37353, clean up cursors used by RenderStyles.

Reviewed by Adam Roben.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):

  • rendering/style/CursorData.h:

(WebCore::CursorData::CursorData):
(WebCore::CursorData::operator==):
(WebCore::CursorData::image):
(WebCore::CursorData::hotSpot):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::addCursor):

13:40 Changeset [57357] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-09 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Holger Freyther.

Removing the use of topLevelWidget of QWidget class since it is deprecated/obsolete
since Qt 4.5. window() method is being used instead now.

See http://doc.trolltech.com/4.5/qwidget-obsolete.html#topLevelWidget for more info.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::windowRect): (WebCore::ChromeClientQt::show): (WebCore::ChromeClientQt::windowResizerRect):
13:35 Changeset [57356] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows build.

  • Shared/NotImplemented.h:

Include stdio.h.

13:21 Changeset [57355] by hyatt@apple.com
  • 11 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=37349, RenderStyle cleanup. Working from the outside in to
bring some style consistency to RenderStyle and its associated classes. This patch cleans up the
border and outline classes.

Reviewed by Adam Roben.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::calcBorderLeft):
(WebCore::RenderTable::calcBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):

  • rendering/RenderTableCell.cpp:

(WebCore::compareBorders):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcOuterBorderTop):
(WebCore::RenderTableSection::calcOuterBorderBottom):
(WebCore::RenderTableSection::calcOuterBorderLeft):
(WebCore::RenderTableSection::calcOuterBorderRight):

  • rendering/style/BorderData.h:

(WebCore::BorderData::hasBorder):
(WebCore::BorderData::hasBorderRadius):
(WebCore::BorderData::borderLeftWidth):
(WebCore::BorderData::borderRightWidth):
(WebCore::BorderData::borderTopWidth):
(WebCore::BorderData::borderBottomWidth):
(WebCore::BorderData::operator==):
(WebCore::BorderData::left):
(WebCore::BorderData::right):
(WebCore::BorderData::top):
(WebCore::BorderData::bottom):
(WebCore::BorderData::image):
(WebCore::BorderData::topLeft):
(WebCore::BorderData::topRight):
(WebCore::BorderData::bottomLeft):
(WebCore::BorderData::bottomRight):

  • rendering/style/BorderValue.h:

(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::nonZero):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::color):
(WebCore::BorderValue::width):
(WebCore::BorderValue::style):

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::width):
(WebCore::CollapsedBorderValue::style):
(WebCore::CollapsedBorderValue::exists):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::isTransparent):
(WebCore::CollapsedBorderValue::precedence):
(WebCore::CollapsedBorderValue::operator==):

  • rendering/style/OutlineValue.h:

(WebCore::OutlineValue::OutlineValue):
(WebCore::OutlineValue::operator==):
(WebCore::OutlineValue::offset):
(WebCore::OutlineValue::isAuto):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getBorderRadiiForRect):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::borderLeft):
(WebCore::InheritedFlags::borderRight):
(WebCore::InheritedFlags::borderTop):
(WebCore::InheritedFlags::borderBottom):
(WebCore::InheritedFlags::borderImage):
(WebCore::InheritedFlags::borderTopLeftRadius):
(WebCore::InheritedFlags::borderTopRightRadius):
(WebCore::InheritedFlags::borderBottomLeftRadius):
(WebCore::InheritedFlags::borderBottomRightRadius):
(WebCore::InheritedFlags::borderLeftStyle):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderLeftIsTransparent):
(WebCore::InheritedFlags::borderRightStyle):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderRightIsTransparent):
(WebCore::InheritedFlags::borderTopStyle):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderTopIsTransparent):
(WebCore::InheritedFlags::borderBottomStyle):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::borderBottomIsTransparent):
(WebCore::InheritedFlags::outlineWidth):
(WebCore::InheritedFlags::outlineStyleIsAuto):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::outlineOffset):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::resetBorderTop):
(WebCore::InheritedFlags::resetBorderRight):
(WebCore::InheritedFlags::resetBorderBottom):
(WebCore::InheritedFlags::resetBorderLeft):
(WebCore::InheritedFlags::resetBorderImage):
(WebCore::InheritedFlags::resetBorderTopLeftRadius):
(WebCore::InheritedFlags::resetBorderTopRightRadius):
(WebCore::InheritedFlags::resetBorderBottomLeftRadius):
(WebCore::InheritedFlags::resetBorderBottomRightRadius):
(WebCore::InheritedFlags::setBorderImage):
(WebCore::InheritedFlags::setBorderTopLeftRadius):
(WebCore::InheritedFlags::setBorderTopRightRadius):
(WebCore::InheritedFlags::setBorderBottomLeftRadius):
(WebCore::InheritedFlags::setBorderBottomRightRadius):
(WebCore::InheritedFlags::setBorderLeftWidth):
(WebCore::InheritedFlags::setBorderLeftStyle):
(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightWidth):
(WebCore::InheritedFlags::setBorderRightStyle):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopWidth):
(WebCore::InheritedFlags::setBorderTopStyle):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomWidth):
(WebCore::InheritedFlags::setBorderBottomStyle):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineWidth):
(WebCore::InheritedFlags::setOutlineStyle):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setOutlineOffset):
(WebCore::InheritedFlags::setColumnRuleColor):
(WebCore::InheritedFlags::setColumnRuleWidth):

  • rendering/style/StyleMultiColData.h:

(WebCore::StyleMultiColData::ruleWidth):

13:20 Changeset [57354] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-09 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Make CallIdentifier constructor to handle null urls.

https://bugs.webkit.org/show_bug.cgi?id=37341

  • profiler/CallIdentifier.h: (JSC::CallIdentifier::CallIdentifier):
13:10 Changeset [57353] by weinig@apple.com
  • 1 edit in trunk/WebKit2/ChangeLog

Add some missing URLs to ChangeLogs.

13:08 Changeset [57352] by weinig@apple.com
  • 21 edits
    10 adds in trunk/WebKit2

Fix for https://bugs.webkit.org/show_bug.cgi?id=37347
Don't use CF types in the new C API

Reviewed by Anders Carlsson.

Replace all uses of CF types in the C API.

  • Replace CFStringRef with WKStringRef.
  • Replace CFURLRef with WKURLRef.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • Shared/KURLWrapper.h: Added. RefCounted wrapper around KURL.
  • UIProcess/API/C/WKAPICast.h: Add new conversions.
  • UIProcess/API/C/WKBase.h: Add new types.
  • UIProcess/API/C/WKFrame.cpp:
  • UIProcess/API/C/WKFrame.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:

Replace uses of CF types with WK equivalents.

  • UIProcess/API/C/WKString.cpp: Added.
  • UIProcess/API/C/WKString.h: Added.

Represents a WebCore::StringImpl*.

  • UIProcess/API/C/WKURL.cpp: Added.
  • UIProcess/API/C/WKURL.h: Added.

Represents a WebKit::KURLWrapper*.

  • UIProcess/API/C/cf: Added.
  • UIProcess/API/C/cf/WKStringCF.cpp: Added.
  • UIProcess/API/C/cf/WKStringCF.h: Added.
  • UIProcess/API/C/cf/WKURLCF.cpp: Added.
  • UIProcess/API/C/cf/WKURLCF.h: Added.

CoreFoundation conversion files. Allows converting

WKStringRef <-> CFStringRef
WKURLRef <-> CFURLRef

  • UIProcess/ScriptReturnValueCallback.cpp:

(WebKit::ScriptReturnValueCallback::performCallbackWithReturnValue):

  • UIProcess/ScriptReturnValueCallback.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didReceiveTitleForFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::urlAtProcessExit):

  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):

  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::runJavaScriptAlert):

  • UIProcess/WebUIClient.h:

Don't use CF types internally at all.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::frameLoaderDestroyed):
Fix typo.

13:01 Changeset [57351] by eric@webkit.org
  • 6 edits in trunk

2010-04-09 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Darin Adler.

Changed expectation for text status for HTTP status of 4xx following
a fix for localized status messages.
https://bugs.webkit.org/show_bug.cgi?id=37274

  • platform/mac/http/tests/xmlhttprequest/web-apps/013-expected.txt:
  • platform/mac/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt:

2010-04-09 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Darin Adler.

Fixed ResourceError::failingURL() and ResourceResponse::httpStatusText()
to return meaningful values.
https://bugs.webkit.org/show_bug.cgi?id=37274

  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::platformLazyInit):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
12:50 Changeset [57350] by eric@webkit.org
  • 13 edits in trunk

2010-04-09 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Move the IDB::open ExceptionCode paramter to be last
https://bugs.webkit.org/show_bug.cgi?id=37277

Move the ExceptionCode paramter to the last position in
IndexedDatabaseRequest::open and friends. It should definitely
go after the callbacks to keep the parameters that come directly
from javascript together. And having output parameters appear
last is done often in the code base, so it makes sense to push
it past the Frame* param as well.

No functional change.

  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:

2010-04-09 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Move the IDB::open ExceptionCode paramter to be last
https://bugs.webkit.org/show_bug.cgi?id=37277

Move the ExceptionCode paramter to the last position in
IndexedDatabaseRequest::open and friends. It should definitely
go after the callbacks to keep the parameters that come directly
from javascript together. And having output parameters appear
last is done often in the code base, so it makes sense to push
it past the Frame* param as well.

  • public/WebIndexedDatabase.h:
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
  • src/IndexedDatabaseProxy.h:
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h:
12:29 Changeset [57349] by dimich@chromium.org
  • 12 edits
    2 adds in trunk

WebCore: WorkerGlobalScope.close() should let the currently running script complete execution, then terminate the worker.
https://bugs.webkit.org/show_bug.cgi?id=37053

Reviewed by Darin Adler.

WebCore:

Test: fast/workers/worker-close-more.html

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::forbidExecution):

  • bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::):
Added option parameter to forbidExecution (both JCS and V8 versions) that specifies whether currently running
script should be immediately terminated or left executed until the end.

  • bindings/js/WorkerScriptController.h:

(WebCore::WorkerScriptController::workerContextWrapper):
This method now can return 0 instead of context if the further execution of JS is forbidden. Since any JS execution requires
fetching JS global object first, returning 0 here is a good way to prevent re-entry into JS once worker started termination.
V8 version does similar thing already in WorkerScriptController::proxy().

  • workers/DedicatedWorkerContext.cpp:

(WebCore::DedicatedWorkerContext::postMessage):
Removed check that immediately disables postMessage from WorkerContext after close().

  • workers/WorkerContext.cpp:

(WebCore::CloseWorkerContextTask::create):
(WebCore::CloseWorkerContextTask::performTask):
(WebCore::CloseWorkerContextTask::isCleanupTask):
(WebCore::WorkerContext::close):
Use new forbidExecution(LetRunningScriptFinish) to avoid termination of script until it executes and exits.
Post a task to actually terminate the worker once the currently executing JS fragment exits.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):
Use new forbidExecution(TerminateRunningScript) to immediately terminate the JS.

LayoutTests:

  • fast/workers/resources/worker-close.js:
  • fast/workers/worker-close-expected.txt:

Updated tests to expect the script fragment that includes close() to run to completion.

  • fast/workers/worker-close-more-expected.txt: Added.
  • fast/workers/worker-close-more.html: Added.
  • fast/workers/worker-close.html:

Added test to check terminate() after close() and close() in the case of multiple MessagePort messages dispatching.

12:10 Changeset [57348] by eric@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-04-09 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r57343.
http://trac.webkit.org/changeset/57343
https://bugs.webkit.org/show_bug.cgi?id=37311

Broke Tiger compile.

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):
11:56 Changeset [57347] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7846015> REGRESSION (r57332) - Crash in [WebDynamicScrollBarsView(WebInternal) reflectScrolledClipView:] when opening the Downloads window

Reviewed by Darin Adler.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView initWithCoder:]): Added. Calls super and then initializes _private.

11:03 Changeset [57346] by tkent@chromium.org
  • 6 edits
    13 adds in trunk

Implement interactive validation for forms.
https://bugs.webkit.org/show_bug.cgi?id=34930

Reviewed by Darin Adler.

WebCore:

  • HTMLFormControlElement::checkValidity() supports unhandled invalid control list
  • HTMLFormElement::validateInteractively() called from prepareSubmit() prevents the submission if neither noValidate nor formNoValidate is specified, and focuses on the first invalid control of which "invalid" event is not canceled.

Tests: fast/forms/checkValidity-cancel.html

fast/forms/interactive-validation-cancel.html
fast/forms/interactive-validation-formnovalidate.html
fast/forms/interactive-validation-novalidate.html
fast/forms/interactive-validation-prevented.html
fast/forms/interactive-validation-remove-node-in-handler.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::checkValidity):

If the control is invalid and the "invalid" is not canceled,
push the control to the specified vector.

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

The main part of the interactive validation.

(WebCore::HTMLFormElement::prepareSubmit):

Calls validateInteractively().

(WebCore::HTMLFormElement::checkValidity):

Uses collectUnhandledInvalidControls().

(WebCore::HTMLFormElement::collectUnhandledInvalidControls):

  • html/HTMLFormElement.h:

LayoutTests:

Add tests for "invalid" event and interactive validation.

  • fast/forms/checkValidity-cancel-expected.txt: Added.
  • fast/forms/checkValidity-cancel.html: Added.
  • fast/forms/interactive-validation-cancel-expected.txt: Added.
  • fast/forms/interactive-validation-cancel.html: Added.
  • fast/forms/interactive-validation-formnovalidate-expected.txt: Added.
  • fast/forms/interactive-validation-formnovalidate.html: Added.
  • fast/forms/interactive-validation-novalidate-expected.txt: Added.
  • fast/forms/interactive-validation-novalidate.html: Added.
  • fast/forms/interactive-validation-prevented-expected.txt: Added.
  • fast/forms/interactive-validation-prevented.html: Added.
  • fast/forms/interactive-validation-remove-node-in-handler-expected.txt: Added.
  • fast/forms/interactive-validation-remove-node-in-handler.html: Added.
  • fast/forms/script-tests/checkValidity-cancel.js: Added.
10:45 Changeset [57345] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-09 Gustavo Noronha Silva <gns@gnome.org>

[GTK+] media/video-src-invalid-remove.html
https://bugs.webkit.org/show_bug.cgi?id=37344

Skip test that is failing constantly but apparently without reason
on the 64 bits release bot.

  • platform/gtk/Skipped:
10:04 Changeset [57344] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix the mac WebKit2 build.

  • WebCore.base.exp:
09:53 Changeset [57343] by eric@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-04-09 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Work around QTMovieView bug (<rdar://problem/7712713>) by using a QTMovieLayer instead.
https://bugs.webkit.org/show_bug.cgi?id=37311 / <rdar://problem/7749993>

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): (-[WebVideoFullscreenController setMediaElement:WebCore::]):
09:49 Changeset [57342] by abecsi@webkit.org
  • 1 edit
    107 adds in trunk/LayoutTests

[Qt] Add expected results for passing new tests. Compared to the Mac png-s and expected files these
platform dependent results only differ from Mac resulst in font metrics and svg implementation.

Rubber-stamped by Simon Hausmann.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu>

  • platform/qt/editing/deleting/non-smart-delete-expected.checksum: Added.
  • platform/qt/editing/deleting/non-smart-delete-expected.png: Added.
  • platform/qt/editing/deleting/non-smart-delete-expected.txt: Added.
  • platform/qt/fast/css/first-letter-first-line-hover-expected.checksum: Added.
  • platform/qt/fast/css/first-letter-first-line-hover-expected.png: Added.
  • platform/qt/fast/css/first-letter-first-line-hover-expected.txt: Added.
  • platform/qt/fast/forms/basic-selects-expected.checksum: Added.
  • platform/qt/fast/forms/basic-selects-expected.png: Added.
  • platform/qt/fast/forms/basic-selects-expected.txt: Added.
  • platform/qt/fast/repaint/moving-shadow-on-container-expected.checksum: Added.
  • platform/qt/fast/repaint/moving-shadow-on-container-expected.png: Added.
  • platform/qt/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.checksum: Added.
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
  • platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
  • platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum: Added.
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: Added.
  • platform/qt/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/qt/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/qt/fast/repaint/stacked-diacritics-expected.txt: Added.
  • platform/qt/fast/ruby: Added.
  • platform/qt/fast/ruby/ruby-inline-table-expected.checksum: Added.
  • platform/qt/fast/ruby/ruby-inline-table-expected.png: Added.
  • platform/qt/fast/ruby/ruby-inline-table-expected.txt: Added.
  • platform/qt/fast/runin/generated2-expected.checksum: Added.
  • platform/qt/fast/runin/generated2-expected.png: Added.
  • platform/qt/fast/runin/generated2-expected.txt: Added.
  • platform/qt/fast/runin/generated3-expected.checksum: Added.
  • platform/qt/fast/runin/generated3-expected.png: Added.
  • platform/qt/fast/runin/generated3-expected.txt: Added.
  • platform/qt/fast/runin/generated4-expected.checksum: Added.
  • platform/qt/fast/runin/generated4-expected.png: Added.
  • platform/qt/fast/runin/generated4-expected.txt: Added.
  • platform/qt/fast/text/international/hebrew-vowels-expected.checksum: Added.
  • platform/qt/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/qt/fast/text/international/hebrew-vowels-expected.txt: Added.
  • platform/qt/svg/custom/mask-invalidation-expected.checksum: Added.
  • platform/qt/svg/custom/mask-invalidation-expected.png: Added.
  • platform/qt/svg/custom/mask-invalidation-expected.txt: Added.
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.checksum: Added.
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.png: Added.
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.txt: Added.
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.checksum: Added.
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.png: Added.
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Added.
  • platform/qt/svg/custom/pattern-skew-transformed-expected.checksum: Added.
  • platform/qt/svg/custom/pattern-skew-transformed-expected.png: Added.
  • platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Added.
  • platform/qt/svg/custom/stroke-width-large-expected.checksum: Added.
  • platform/qt/svg/custom/stroke-width-large-expected.png: Added.
  • platform/qt/svg/custom/stroke-width-large-expected.txt: Added.
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
  • platform/qt/svg/filters/filter-on-tspan-expected.checksum: Added.
  • platform/qt/svg/filters/filter-on-tspan-expected.png: Added.
  • platform/qt/svg/filters/filter-on-tspan-expected.txt: Added.
  • platform/qt/svg/overflow: Added.
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-inner-svg-element-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.checksum: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Added.
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
  • platform/qt/svg/text/selection-doubleclick-expected.checksum: Added.
  • platform/qt/svg/text/selection-doubleclick-expected.png: Added.
  • platform/qt/svg/text/selection-doubleclick-expected.txt: Added.
  • platform/qt/svg/text/selection-styles-expected.checksum: Added.
  • platform/qt/svg/text/selection-styles-expected.png: Added.
  • platform/qt/svg/text/selection-styles-expected.txt: Added.
  • platform/qt/svg/text/selection-tripleclick-expected.checksum: Added.
  • platform/qt/svg/text/selection-tripleclick-expected.png: Added.
  • platform/qt/svg/text/selection-tripleclick-expected.txt: Added.
09:38 Changeset [57341] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-04-09 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

Complete move of createApplicationCacheHost from WebKitClient to WebFrameClient.
https://bugs.webkit.org/show_bug.cgi?id=37330

  • public/WebApplicationCacheHost.h:
  • public/WebKitClient.h:
  • src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
09:35 Changeset [57340] by ap@apple.com
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37181
<rdar://problem/7835374> REGRESSION (r54400): Hangs when doing AJAX update with large amount of data

Test: fast/events/gc-freeze-with-attribute-listeners.html

The problem was that we were creating JS wrappers for nodes with attribute event listeners,
and GC is very slow if there are nodes with wrappers in a detached tree whose root does not
have a wrapper.

  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Don't create wrappers for attribute event listeners - if there is a node, JSLazyEventListener::initializeJSFunction() will create one.
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Added a FIXME about the problem we are stepping around now.
08:56 Changeset [57339] by aroben@apple.com
  • 4 edits
    8 adds in trunk

Make :visited tests added in r57292 not assert on Windows and GTK builds

Fixes <http://webkit.org/b/37333>.

Reviewed by Anders Carlsson.

WebKitTools:

Don't return 0 as a JSValueRef

That is an illegal use of the JSC API.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):
Return an "undefined" JSValueRef instead of 0.

LayoutTests:

Add Windows- and GTK-specific results for new :visited tests

These platforms haven't yet implemented the new LayoutTestController
API these tests require. Implementing the API is tracked by
<http://webkit.org/b/37336> and <http://webkit.org/b/37337>.

  • platform/gtk/fast/history/nested-visited-test-expected.txt: Added.
  • platform/gtk/fast/history/self-is-visited-expected.txt: Added.
  • platform/gtk/fast/history/sibling-visited-test-expected.txt: Added.
  • platform/win/fast/history/nested-visited-test-expected.txt: Added.
  • platform/win/fast/history/self-is-visited-expected.txt: Added.
  • platform/win/fast/history/sibling-visited-test-expected.txt: Added.
07:25 QtWebKitBackportingFixes edited by joseph.ligman@nokia.com
(diff)
07:01 Changeset [57338] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-04-09 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

WebGtk GLib-CRITICAL Segmentation fault
https://bugs.webkit.org/show_bug.cgi?id=34937

Do not crash if a plugin does not return anything in
NP_GetMIMEDescription. This can happen, and other ports gracefully
handle the situation.

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
06:44 Changeset [57337] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-04-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Cannot select elements within iframes with the magnifying glass.

https://bugs.webkit.org/show_bug.cgi?id=31732

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspect): (WebCore::InspectorController::handleMousePress):
  • inspector/InspectorController.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
06:40 Changeset [57336] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Windows Debug/Release build fix after r57244

  • WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or

QuartzCoreInterface.dll in any configurations. r57244 made this change
only for Debug_Internal.

06:14 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:13 Changeset [57335] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-09 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection
Should not try to access WebViewClient if the frame has already been disconnected.
https://bugs.webkit.org/show_bug.cgi?id=37318

  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
06:03 Changeset [57334] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-09 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt]Fix compile error with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=36526

Disable dynamic properties when QT_NO_PROPERTIES is defined.

  • bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fieldNamed):
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getPropertyNames): (JSC::Bindings::QtField::name): (JSC::Bindings::QtField::valueFromInstance): (JSC::Bindings::QtField::setValueToInstance):
  • bridge/qt/qt_runtime.h: (JSC::Bindings::QtField::):
05:47 QtWebKitJournal edited by hausmann@webkit.org
(diff)
05:15 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:14 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:12 Changeset [57333] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Symbian apps crash on exit due to a bad qObject_cast.

Patch by David Leong <david.leong@nokia.com> on 2010-04-09
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=37303

Added check for NULL to avoid the crash.

  • plugins/symbian/PluginViewSymbian.cpp:

(WebCore::PluginView::platformDestroy):

05:03 Changeset [57332] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]

[ Re-landing of r57329 with the requisite memset added in -initWithFrame: so that the tests keep working. ]

Reviewed by John Sullivan.

In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
size and layout of their subclasses is baked in at compile time. This results in instances
being allocated that are smaller than the new code expects, and may result in the new instance
variables sharing the same memory space as any instance variables that the subclass defines.

We can avoid this problem by having the class contain only a single member that acts as a pointer
to a heap-allocated structure that acts as storage for the real instance variables. This makes
us free to add instance variables in the future without risk of changing the size of the class.
To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
are able to run against older versions of WebKit we pad the class out to its previous size. This
results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
with both versions of the code.

This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
instance variables of its superclass. However, this is a private header and no known subclasses
of WebDynamicScrollBarsView access superclass instance variables in this fashion.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView dealloc]):
(-[WebDynamicScrollBarsView finalize]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
(-[WebDynamicScrollBarsView contentViewFrame]):
(-[WebDynamicScrollBarsView tile]):
(-[WebDynamicScrollBarsView setSuppressLayout:]):
(-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
(-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setScrollingModesLocked:]):
(-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
(-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
(-[WebDynamicScrollBarsView scrollWheel:]):

04:55 Changeset [57331] by hausmann@webkit.org
  • 2 edits in trunk

Unreviewed crash fix.

Revert part of 57320 that would remove NDEBUG in release builds for
DRT, etc.

  • WebKit.pri:
04:55 Changeset [57330] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

Roll out r57329 since the bots are seeing lots of failures that I wasn't seeing locally.

04:51 WebKit2 edited by mrowe@apple.com
(diff)
04:47 WebKit2 edited by mjs@apple.com
(diff)
04:44 Changeset [57329] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

<rdar://problem/7814899> REGRESSION(r56008): iTunes crashes on quit inside -[NSScrollView dealloc]

Reviewed by John Sullivan.

In r56008 new instance variables were added to WebDynamicScrollBarsView, increasing its size.
This causes problems for 32-bit applications that derive from WebDynamicScrollBarsView, as the
size and layout of their subclasses is baked in at compile time. This results in instances
being allocated that are smaller than the new code expects, and may result in the new instance
variables sharing the same memory space as any instance variables that the subclass defines.

We can avoid this problem by having the class contain only a single member that acts as a pointer
to a heap-allocated structure that acts as storage for the real instance variables. This makes
us free to add instance variables in the future without risk of changing the size of the class.
To ensure that 32-bit applications that are built against this new WebDynamicScrollBarsView header
are able to run against older versions of WebKit we pad the class out to its previous size. This
results in any subclasses of WebDynamicScrollBarsView being created with a layout that is compatible
with both versions of the code.

This change could potentially break a subclass of WebDynamicScrollBarsView that directly accesses
instance variables of its superclass. However, this is a private header and no known subclasses
of WebDynamicScrollBarsView access superclass instance variables in this fashion.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView initWithFrame:]):
(-[WebDynamicScrollBarsView dealloc]):
(-[WebDynamicScrollBarsView finalize]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsScrollersToOverlapContent:]):
(-[WebDynamicScrollBarsView setAlwaysHideHorizontalScroller:]):
(-[WebDynamicScrollBarsView setAlwaysHideVerticalScroller:]):
(-[WebDynamicScrollBarsView horizontalScrollingAllowed]):
(-[WebDynamicScrollBarsView verticalScrollingAllowed]):
(-[WebDynamicScrollBarsView contentViewFrame]):
(-[WebDynamicScrollBarsView tile]):
(-[WebDynamicScrollBarsView setSuppressLayout:]):
(-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView scrollingModes:WebCore::vertical:WebCore::]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setScrollingModes:vertical:andLock:]):
(-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
(-[WebDynamicScrollBarsView setScrollingModesLocked:]):
(-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
(-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
(-[WebDynamicScrollBarsView scrollWheel:]):

04:42 WebKit2 edited by mjs@apple.com
(diff)
04:30 Changeset [57328] by ossy@webkit.org
  • 4 edits in trunk/WebKitTools

Make DumpRenderTree parallelizable
https://bugs.webkit.org/show_bug.cgi?id=36899

Reviewed by Eric Seidel.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(libraryPathForDumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree): Use DUMPRENDERTREE_TEMP if exist.

  • Scripts/run-webkit-tests:
    • Create a unique temporary directory and pass its path to DumpRenderTree with DUMPRENDERTREE_TEMP environment variable.
04:26 chromium-webkit-stack.png attached to WebKit2 by mjs@apple.com
04:26 WebKit2 edited by mjs@apple.com
(diff)
04:14 WebKit2 edited by mjs@apple.com
(diff)
04:13 WebKit2 edited by mjs@apple.com
(diff)
04:12 webkit2-stack.png attached to WebKit2 by mjs@apple.com
webkit2-stack
04:12 mac-webkit-stack.png attached to WebKit2 by mjs@apple.com
mac-webkit-stack
03:55 Changeset [57327] by eric@webkit.org
  • 6 edits in trunk/WebKit/qt

2010-04-09 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compile error with QT_NO_ACTION
https://bugs.webkit.org/show_bug.cgi?id=36529

Make sure QT_NO_ACTION is not defined to use QAction

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::pageAction):
  • Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPage::updatePositionDependentActions):
  • Api/qwebpage.h:
  • Api/qwebview.cpp:
  • Api/qwebview.h:
03:53 Changeset [57326] by mrowe@apple.com
  • 3 edits
    1 add in trunk

<http://webkit.org/b/37326> IDL files are being copied in to the WebCore framework again

Reviewed by Oliver Hunt.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Wire up the script. Remove the three inappropriate

files from the Copy Bundle Resources build phase.

WebKitTools:

Add a script to detect the presence of inappropriate files in the frameworks. At present
it only looks for .css, .idl and .in files in the top level of WebCore.framework/Resources,
as these are the only cases we've encountered recently. It can be extended to check the
other frameworks or for other inappropriate files in the future.

  • Scripts/check-for-inappropriate-files-in-framework: Added.
03:46 Changeset [57325] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-04-09 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Expose SecurityOrigin::canRequest in WebSecurityOrigin.
https://bugs.webkit.org/show_bug.cgi?id=37271

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::canRequest):
03:37 Changeset [57324] by eric@webkit.org
  • 8 edits in trunk

2010-04-09 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Passing null WebGLObjects should synthesize INVALID_VALUE error
https://bugs.webkit.org/show_bug.cgi?id=37047

  • fast/canvas/webgl/error-reporting-expected.txt: Change a few errors from INVALID_OPERATION to INVALID_VALUE.
  • fast/canvas/webgl/getActiveTest-expected.txt: Ditto.
  • fast/canvas/webgl/null-object-behaviour-expected.txt: Ditto.
  • fast/canvas/webgl/script-tests/error-reporting.js: Ditto.

2010-04-09 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Passing null WebGLObjects should synthesize INVALID_VALUE error
https://bugs.webkit.org/show_bug.cgi?id=37047

  • html/canvas/WebGLRenderingContext.cpp: Synthesize INVALID_VALUE error when input object is 0. (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::validateWebGLObject): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource):
  • html/canvas/WebGLRenderingContext.h: Add helper function to validate webgl object input parameters.
03:10 Changeset [57323] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] tests/qgraphicswebview fails
https://bugs.webkit.org/show_bug.cgi?id=37317

Reviewed by Lars Knoll.

  • Api/qwebpage.cpp:

(QWebPage::userAgentForUrl): Don't crash if the ownerWidget is null.

03:06 Changeset [57322] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-04-09 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=37174

  • fast/canvas/webgl/copy-tex-image-and-sub-image-2d-expected.txt: Added.
  • fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html: Added.
  • fast/canvas/webgl/resources/utils3d.js: Add ContextAttributes parameter to initWebGL function.

2010-04-09 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=37174

Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html

  • platform/graphics/mac/GraphicsContext3DMac.cpp: resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D. (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D):

2010-04-09 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=37174

Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html

  • src/WebGraphicsContext3DDefaultImpl.cpp: Resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D. (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D):
03:00 ApplicationsGtk edited by scaroo@gmail.com
(diff)
02:48 Changeset [57321] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-09 Evan Stade <estade@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] <select> dropdowns don't die when an item is selected
https://bugs.webkit.org/show_bug.cgi?id=37243

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::hidePopup): (WebCore::PopupContainer::notifyPopupHidden): (WebCore::PopupListBox::hidePopup): inform container that popup is closing
  • platform/chromium/PopupMenuChromium.h:
02:03 Changeset [57320] by hausmann@webkit.org
  • 6 edits in trunk

[Qt] Fix crashes with package builds in release

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-04-09
Reviewed by Simon Hausmann.

.:

  • WebKit.pri: Don't randomly add NDEBUG to the defines.

JavaScriptCore:

Add NDEBUG to the defines for package build in JavaScriptCore.pri,
so that it's consistently used for JavaScriptCore, WebCore, jsc and all
other tools using wtf, etc. data structures directly. Mixing NDEBUG with
non-NDEBUG builds causes crashes due to differences in data structures when
assertions/checks are enabled.

WebCore:

  • WebCore.pro: Don't add NDEBUG to the defines here, add it from JavaScriptCore.pri
01:59 Changeset [57319] by eric@webkit.org
  • 5 edits in trunk

2010-04-09 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Fraser.

Update test as the 'all' value has been removed

  • fast/media/media-feature-wgt-view-mode.html:

2010-04-09 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Fraser.

Remove "all" value from the view-mode media feature (as agreed on
1-Apr-2010) in the Widgets voice conf.

  • css/CSSValueKeywords.in:
  • css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):
01:36 Changeset [57318] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-04-09 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Implement NO_RETURN for COMPILER(MSVC).
https://bugs.webkit.org/show_bug.cgi?id=33056

Added NO_RETURN_WITH_VALUE for functions with non-void return type.

  • jsc.cpp:
  • wtf/AlwaysInline.h:
  • wtf/FastMalloc.cpp:
01:21 WebKit2 edited by mjs@apple.com
(diff)
01:20 QtWebKitRelease20 edited by hausmann@webkit.org
(diff)
01:15 Changeset [57317] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-09 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57286.
http://trac.webkit.org/changeset/57286
https://bugs.webkit.org/show_bug.cgi?id=37312

"Caused intermittent test failures on all Mac bots."
(Requested by eseidel on #webkit).

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originQuotaManagerNoLock): (WebCore::DatabaseTracker::originQuotaManager): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::getMaxSizeForDatabase): (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::usageForOriginNoLock): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::deleteOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile):
  • storage/DatabaseTracker.h:
  • storage/SQLTransactionClient.cpp: (WebCore::SQLTransactionClient::didExecuteStatement):
01:06 WebKit2 edited by mjs@apple.com
(diff)
00:59 Changeset [57316] by abecsi@webkit.org
  • 7 edits in trunk

[Qt] User agent style sheets are crippled by moc -E in make-css-file-arrays.pl
https://bugs.webkit.org/show_bug.cgi?id=37296

Reviewed by Simon Hausmann.
Patch by Andras Becsi <abecsi@inf.u-szeged.hu>

WebCore:

Do not use moc to preprocess user agent style sheets because it removes at-symbols
and hexadecimal colours from declarations.
Remove unneeded preprocessor usage from make-css-file-arrays.pl since the script
processes default css files using regular expressions therefore preprocessing is redundant.

  • WebCore.pri: remove --preprocessor usage
  • css/make-css-file-arrays.pl: remove gcc dependency

LayoutTests:

Update expected files after removal of moc preprocessing of default css sheets.
These test results now only differ in metrics from Mac ones.

  • platform/qt/editing/execCommand/insert-list-xml-expected.txt:
  • platform/qt/svg/custom/createImageElement2-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
00:58 WebKit2 edited by mjs@apple.com
(diff)
00:35 Changeset [57315] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

00:33 Changeset [57314] by mrowe@apple.com
  • 1 copy in tags/Safari-533.4

New tag.

04/08/10:

23:43 Changeset [57313] by abarth@webkit.org
  • 8 edits
    2 adds in trunk

2010-04-08 Chris Evans <cevans@chromium.org>

Reviewed by Sam Weinig.

Add test for POST & _blank popup blocker bypass.
https://bugs.webkit.org/show_bug.cgi?id=34541

  • fast/events/popup-blocked-to-post-blank.html: added
  • fast/events/popup-blocked-to-post-blank-expected.txt: added

2010-04-08 Chris Evans <cevans@chromium.org>

Reviewed by Sam Weinig.

Use the new UserGestureIndictor for _blank POST requests.

https://bugs.webkit.org/show_bug.cgi?id=34541

Test: fast/events/popup-blocked-to-post-blank.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): Use UserGestureIndicator in more cases.
  • page/EventHandler.cpp: (WebCore::EventHandler): Impact from UserGestureIndicator API change. (WebCore::FrameLoader::submitForm): Block the load immediately if popups are not allowed and it would open a new window.
  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): Note the UserGestureIndicator status at the time of submission. (WebCore::ScheduledFormSubmission::fire): Use the stored UserGestureIndicator status in the asynchronous callback.
  • dom/UserGestureIndicator.h:
  • dom/UserGestureIndicator.cpp: (WebCore::UserGestureIndicator::UserGestureIndicator): Add ability to store a negative indication.
18:14 Changeset [57312] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Add option to build WebKit2 to build-webkit.

Reviewed by Darin Adler.

  • Scripts/build-webkit:
17:52 Changeset [57311] by weinig@apple.com
  • 1 edit
    23 adds in trunk/WebKit2

Add build support for WebKit2.

Reviewed by Anders Carlsson.

  • Configurations: Added.
  • Configurations/Base.xcconfig: Added.
  • Configurations/DebugRelease.xcconfig: Added.
  • Configurations/FeatureDefines.xcconfig: Added.
  • Configurations/Version.xcconfig: Added.
  • Configurations/WebKit2.xcconfig: Added.
  • English.lproj: Added.
  • English.lproj/InfoPlist.strings: Added.
  • Info.plist: Added.
  • Makefile: Added.
  • WebKit2.xcodeproj: Added.
  • WebKit2.xcodeproj/project.pbxproj: Added.
  • WebKit2Prefix.cpp: Added.
  • WebKit2Prefix.h: Added.
  • WebKit2_Prefix.pch: Added.
  • WebProcess-Info.plist: Added.
  • version.plist: Added.
  • win: Added.
  • win/WebKit2.def: Added.
  • win/WebKit2.vcproj: Added.
  • win/WebKit2Generated.make: Added.
  • win/WebKit2Generated.vcproj: Added.
  • win/WebKit2WebProcess.vcproj: Added.
17:50 Changeset [57310] by weinig@apple.com
  • 1 edit
    73 adds in trunk/WebKit2

Add WebKit2/UIProcess directory.

Patch by Anders Carlsson <andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig.

  • UIProcess: Added.
  • UIProcess/API: Added.
  • UIProcess/API/C: Added.
  • UIProcess/API/C/WKAPICast.h: Added.
  • UIProcess/API/C/WKBase.h: Added.
  • UIProcess/API/C/WKContext.cpp: Added.
  • UIProcess/API/C/WKContext.h: Added.
  • UIProcess/API/C/WKFrame.cpp: Added.
  • UIProcess/API/C/WKFrame.h: Added.
  • UIProcess/API/C/WKFramePolicyListener.cpp: Added.
  • UIProcess/API/C/WKFramePolicyListener.h: Added.
  • UIProcess/API/C/WKPage.cpp: Added.
  • UIProcess/API/C/WKPage.h: Added.
  • UIProcess/API/C/WKPageNamespace.cpp: Added.
  • UIProcess/API/C/WKPageNamespace.h: Added.
  • UIProcess/API/C/WKPreferences.cpp: Added.
  • UIProcess/API/C/WKPreferences.h: Added.
  • UIProcess/API/C/WebKit2.h: Added.
  • UIProcess/API/mac: Added.
  • UIProcess/API/mac/PageClientImpl.h: Added.
  • UIProcess/API/mac/PageClientImpl.mm: Added.
  • UIProcess/API/mac/WKView.h: Added.
  • UIProcess/API/mac/WKView.mm: Added.
  • UIProcess/API/mac/WKViewInternal.h: Added.
  • UIProcess/API/win: Added.
  • UIProcess/API/win/WKAPICastWin.h: Added.
  • UIProcess/API/win/WKBaseWin.h: Added.
  • UIProcess/API/win/WKView.cpp: Added.
  • UIProcess/API/win/WKView.h: Added.
  • UIProcess/Launcher: Added.
  • UIProcess/Launcher/WebProcessLauncher.h: Added.
  • UIProcess/Launcher/mac: Added.
  • UIProcess/Launcher/mac/WebProcessLauncher.mm: Added.
  • UIProcess/Launcher/win: Added.
  • UIProcess/Launcher/win/WebProcessLauncher.cpp: Added.
  • UIProcess/PageClient.h: Added.
  • UIProcess/ProcessModel.h: Added.
  • UIProcess/ResponsivenessTimer.cpp: Added.
  • UIProcess/ResponsivenessTimer.h: Added.
  • UIProcess/ScriptReturnValueCallback.cpp: Added.
  • UIProcess/ScriptReturnValueCallback.h: Added.
  • UIProcess/WebContext.cpp: Added.
  • UIProcess/WebContext.h: Added.
  • UIProcess/WebFramePolicyListenerProxy.cpp: Added.
  • UIProcess/WebFramePolicyListenerProxy.h: Added.
  • UIProcess/WebFrameProxy.cpp: Added.
  • UIProcess/WebFrameProxy.h: Added.
  • UIProcess/WebLoaderClient.cpp: Added.
  • UIProcess/WebLoaderClient.h: Added.
  • UIProcess/WebPageNamespace.cpp: Added.
  • UIProcess/WebPageNamespace.h: Added.
  • UIProcess/WebPageProxy.cpp: Added.
  • UIProcess/WebPageProxy.h: Added.
  • UIProcess/WebPolicyClient.cpp: Added.
  • UIProcess/WebPolicyClient.h: Added.
  • UIProcess/WebPreferences.cpp: Added.
  • UIProcess/WebPreferences.h: Added.
  • UIProcess/WebProcessManager.cpp: Added.
  • UIProcess/WebProcessManager.h: Added.
  • UIProcess/WebProcessProxy.cpp: Added.
  • UIProcess/WebProcessProxy.h: Added.
  • UIProcess/WebUIClient.cpp: Added.
  • UIProcess/WebUIClient.h: Added.
  • UIProcess/mac: Added.
  • UIProcess/mac/DrawingAreaProxy.h: Added.
  • UIProcess/mac/DrawingAreaProxy.mm: Added.
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.h: Added.
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: Added.
  • UIProcess/win: Added.
  • UIProcess/win/DrawingAreaProxy.cpp: Added.
  • UIProcess/win/DrawingAreaProxy.h: Added.
  • UIProcess/win/WebView.cpp: Added.
  • UIProcess/win/WebView.h: Added.
17:49 Changeset [57309] by weinig@apple.com
  • 1 edit
    50 adds in trunk/WebKit2

Add WebKit2/WebProcess directory.

Patch by Anders Carlsson <andersca@apple.com> on 2010-04-08
Reviewed by Sam Weinig and Oliver Hunt.

  • WebProcess: Added.
  • WebProcess/Launching: Added.
  • WebProcess/Launching/mac: Added.
  • WebProcess/Launching/mac/WebProcessMain.mm: Added.
  • WebProcess/Launching/win: Added.
  • WebProcess/Launching/win/WebProcessWinMain.cpp: Added.
  • WebProcess/WebCoreSupport: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.h: Added.
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebContextMenuClient.h: Added.
  • WebProcess/WebCoreSupport/WebDragClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebDragClient.h: Added.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebEditorClient.h: Added.
  • WebProcess/WebCoreSupport/WebErrors.h: Added.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: Added.
  • WebProcess/WebCoreSupport/WebInspectorClient.h: Added.
  • WebProcess/WebCoreSupport/mac: Added.
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: Added.
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.h: Added.
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.m: Added.
  • WebProcess/WebCoreSupport/win: Added.
  • WebProcess/WebCoreSupport/win/WebCoreLocalizedStrings.cpp: Added.
  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: Added.
  • WebProcess/WebPage: Added.
  • WebProcess/WebPage/DrawingArea.cpp: Added.
  • WebProcess/WebPage/DrawingArea.h: Added.
  • WebProcess/WebPage/WebFrame.cpp: Added.
  • WebProcess/WebPage/WebFrame.h: Added.
  • WebProcess/WebPage/WebPage.cpp: Added.
  • WebProcess/WebPage/WebPage.h: Added.
  • WebProcess/WebPage/mac: Added.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: Added.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h: Added.
  • WebProcess/WebPage/mac/WebPageMac.mm: Added.
  • WebProcess/WebPage/win: Added.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp: Added.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.h: Added.
  • WebProcess/WebPage/win/WebPageWin.cpp: Added.
  • WebProcess/WebProcess.cpp: Added.
  • WebProcess/WebProcess.h: Added.
  • WebProcess/win: Added.
  • WebProcess/win/DllMain.cpp: Added.
  • WebProcess/win/WebLocalizableStrings.cpp: Added.
  • WebProcess/win/WebLocalizableStrings.h: Added.
  • WebProcess/win/WebProcessMain.cpp: Added.
  • WebProcess/win/WebProcessMain.h: Added.
17:47 Changeset [57308] by weinig@apple.com
  • 1 edit
    24 adds in trunk/WebKit2

Add WebKit2/Shared directory.

Reviewed by Anders Carlsson.

  • Shared: Added.
  • Shared/CoreIPCSupport: Added.
  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Added.
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Added.
  • Shared/CoreIPCSupport/WebPageMessageKinds.h: Added.
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added.
  • Shared/CoreIPCSupport/WebProcessMessageKinds.h: Added.
  • Shared/NotImplemented.h: Added.
  • Shared/WebCoreTypeArgumentMarshalling.h: Added.
  • Shared/WebEvent.h: Added.
  • Shared/WebEventConversion.cpp: Added.
  • Shared/WebEventConversion.h: Added.
  • Shared/WebPreferencesStore.cpp: Added.
  • Shared/WebPreferencesStore.h: Added.
  • Shared/mac: Added.
  • Shared/mac/UpdateChunk.cpp: Added.
  • Shared/mac/UpdateChunk.h: Added.
  • Shared/mac/WebEventFactory.h: Added.
  • Shared/mac/WebEventFactory.mm: Added.
  • Shared/win: Added.
  • Shared/win/UpdateChunk.cpp: Added.
  • Shared/win/UpdateChunk.h: Added.
  • Shared/win/WebEventFactory.cpp: Added.
  • Shared/win/WebEventFactory.h: Added.
17:46 Changeset [57307] by weinig@apple.com
  • 1 edit
    29 adds in trunk/WebKit2

Add WebKit2/Platform directory.

Reviewed by Anders Carlsson.

  • Platform: Added.
  • Platform/CoreIPC: Added.
  • Platform/CoreIPC/ArgumentDecoder.cpp: Added.
  • Platform/CoreIPC/ArgumentDecoder.h: Added.
  • Platform/CoreIPC/ArgumentEncoder.cpp: Added.
  • Platform/CoreIPC/ArgumentEncoder.h: Added.
  • Platform/CoreIPC/Arguments.h: Added.
  • Platform/CoreIPC/Attachment.cpp: Added.
  • Platform/CoreIPC/Attachment.h: Added.
  • Platform/CoreIPC/Connection.cpp: Added.
  • Platform/CoreIPC/Connection.h: Added.
  • Platform/CoreIPC/MessageID.h: Added.
  • Platform/CoreIPC/mac: Added.
  • Platform/CoreIPC/mac/ConnectionMac.cpp: Added.
  • Platform/CoreIPC/mac/MachPort.h: Added.
  • Platform/CoreIPC/win: Added.
  • Platform/CoreIPC/win/ConnectionWin.cpp: Added.
  • Platform/PlatformProcessIdentifier.h: Added.
  • Platform/RunLoop.cpp: Added.
  • Platform/RunLoop.h: Added.
  • Platform/WorkItem.h: Added.
  • Platform/WorkQueue.cpp: Added.
  • Platform/WorkQueue.h: Added.
  • Platform/mac: Added.
  • Platform/mac/RunLoopMac.mm: Added.
  • Platform/mac/WorkQueueMac.cpp: Added.
  • Platform/win: Added.
  • Platform/win/RunLoopWin.cpp: Added.
17:37 Changeset [57306] by darin@apple.com
  • 2 edits in trunk/WebKitTools

run-webkit-tests should respect argument order
https://bugs.webkit.org/show_bug.cgi?id=37257

Reviewed by Alexey Proskuryakov.

  • Scripts/run-webkit-tests: Changed so that sorting is done only

on the results of iterating directories. Test order is based on
what's passed on the command line. Removed code that aimed to
eliminate duplicates since it can be useful to run the same test
more than once.

16:31 Changeset [57305] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[Chromium] Mark failing tests after r57292
https://bugs.webkit.org/show_bug.cgi?id=37298

  • platform/chromium/test_expectations.txt:
16:24 Changeset [57304] by tonikitoo@webkit.org
  • 3 edits
    2 adds in trunk

Spatial Navigation: proper handle negative x or y coordinates https://bugs.webkit.org/show_bug.cgi?id=36773

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

In Spatial Navigation logic, during rect acquisition in renderRectRelativeToRootDocument,
sometimes negative x() or y() values are got, and the current algorithm bails out in
any of such cases.

However, when a node is in a scrollable content (content overflow <div>) and
this scrollable container scrolled up, element gets offscreen, and gets negative values
for y(), for example. In such cases, they are still valid to be used in Spatial Navigation
logic.

Test: fast/events/spatial-navigation/snav-offscreen-content.html

  • page/SpatialNavigation.cpp:

(WebCore::distanceDataForNode):
(WebCore::checkNegativeCoordsForNode):

LayoutTests:

  • fast/events/spatial-navigation/snav-offscreen-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-offscreen-content.html: Added.
16:07 Changeset [57303] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] r57274 removed fast/forms/willvalidate-000.html,
so it should be removed from Skipped list too.

  • platform/qt/Skipped: fast/forms/willvalidate-000.html removed.
15:59 Changeset [57302] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

WebView::isLoading should null check m_mainFrame
https://bugs.webkit.org/show_bug.cgi?id=37294

Reviewed by Darin Adler.

  • WebView.cpp:

(WebView::isLoading):

15:55 Changeset [57301] by dumi@chromium.org
  • 5 edits in trunk

WebCore: Create the creation callback is the current world.
https://bugs.webkit.org/show_bug.cgi?id=37290

Reviewed by Geoffrey Garen.

  • bindings/js/JSDatabaseCallback.cpp:

(WebCore::JSDatabaseCallback::JSDatabaseCallback):

LayoutTests: Test that the creation callback is executed in the world where it
was created.
https://bugs.webkit.org/show_bug.cgi?id=37290

Reviewed by Geoffrey Garen.

  • storage/open-database-creation-callback-isolated-world-expected.txt:
  • storage/open-database-creation-callback-isolated-world.html:
15:39 Changeset [57300] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skip new tests introduced in r57292, because of unimplemented
layoutTestController.computedStyleIncludingVisitedInfo()

  • platform/qt/Skipped:
    • fast/history/nested-visited-test.html skipped.
    • fast/history/self-is-visited.html skipped.
    • fast/history/sibling-visited-test.html skipped.
15:37 Changeset [57299] by hyatt@apple.com
  • 5 edits in trunk/WebCore

Followup optimization to bug 24300, don't leak history info via CSS :visited. If a Web
site uses document colors that are the same for link and vlink in HTML and also doesn't
specify any :link or :visited rules, then don't waste time resolving visited styles.

Reviewed by Oliver Hunt.

There is a further optimization that could be done to detect when :link and :visited are
used together in the same rule to specify a color, and this is how most sites turn off
visited link colors, but this fix doesn't address that. It just restores the optimization
that existed prior to the patch in 24300 landing.

  • css/CSSGrammar.y:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::usesLinkRules):
(WebCore::Document::setUsesLinkRules):

15:36 WebKit2 edited by weinig@apple.com
(diff)
15:18 Changeset [57298] by yuzo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-04-08 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Another trial

Tests that should have been landed as part of the earlier patch for Bug 36276.
https://bugs.webkit.org/show_bug.cgi?id=36276

  • fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
  • fast/css/invalid-not-with-simple-selector-sequence.html: Added.
15:18 WebKit2 created by weinig@apple.com
Initial chech-in.
15:17 Changeset [57297] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Caught by pixel tests. I missed patching the borderRightColor() call for fieldset border painting so the
border stopped showing up.

Reviewed by Oliver Hunt.

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBorderMinusLegend):

15:16 WikiStart edited by weinig@apple.com
Add link to WebKit2 design doc (diff)
15:09 Changeset [57296] by weinig@apple.com
  • 2 adds in trunk/WebKit2

Rubber-stamped by Mark Rowe.

Add WebKit2 directory.

15:05 Changeset [57295] by yuzo@google.com
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-04-08 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Tests that should have been landed as part of the earlier patch for Bug 36276.
https://bugs.webkit.org/show_bug.cgi?id=36276

  • fast/css/invalid-not-with-simple-selector-sequence-expected.txt: Added.
  • fast/css/invalid-not-with-simple-selector-sequence.html: Added.
15:02 Changeset [57294] by hyatt@apple.com
  • 1 edit in trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp

Fix Qt build.

14:48 Changeset [57293] by ojan@chromium.org
  • 22 edits
    1 delete in trunk/LayoutTests

2010-04-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

I missed the linux-only results in http://trac.webkit.org/changeset/57291

  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
14:29 Changeset [57292] by hyatt@apple.com
  • 44 edits
    7 adds
    3 deletes in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=24300, don't leak history info via CSS :visited.

Reviewed by Oliver Hunt.

This patch implements the policy described by David Baron here:

http://dbaron.org/mozilla/visited-privacy

Added new tests in fast/history.

  • WebCore.base.exp:

Expose functions needed for the WebKit SPI used by layout tests.

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isVisited):
Make sure accessibility objects still return visited information.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSComputedStyleDeclaration.h:

(WebCore::computedStyle):
Add a boolean to computed style declarations that - if set - causes the computed style
to still return :visited information. For normal Web pages, this will be false. It is set
to true for the Web Inspector and by the WebKit SPI used by the layout tests.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::keyframeStylesForAnimation):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyPropertyToStyle):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):

  • css/CSSStyleSelector.h:

Rework the style selector to resolve two styles instead of one. The first forces the link to
be unvisited, and the second forces the link to be visited. The real state of the link is
cached on the principal (unvisited) style. The visited style hangs off the principal style
as a pseudo style (VISITED_LINK).

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):
Make sure to deal with the VISITED_LINK pseudo to know when only :visited style info changed.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getStyles):
Let the Web Inspector see :visited computed styles by default.

  • platform/LinkHash.cpp:

(WebCore::visitedURL):
Fix an issue where <a href=""> is not hashed properly to the document's base URI, so it wasn't
correctly reported as :visited.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintObject):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBorderMinusLegend):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintFocusRings):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::drawArcForBoxSide):
(WebCore::RenderObject::paintOutline):
(WebCore::decorationColor):
(WebCore::RenderObject::getTextDecorationColors):

  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp:

(WebCore::RenderPath::paint):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

  • rendering/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::paint):

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

  • rendering/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paint):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::collapsedLeftBorder):
(WebCore::RenderTableCell::collapsedRightBorder):
(WebCore::RenderTableCell::collapsedTopBorder):
(WebCore::RenderTableCell::collapsedBottomBorder):
(WebCore::RenderTableCell::paintCollapsedBorder):

  • rendering/style/CollapsedBorderValue.h:

(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(WebCore::CollapsedBorderValue::color):
(WebCore::CollapsedBorderValue::operator==):
Patch painting code to fetch visitedDependentColors from the RenderStyle. Properties that
are honored include background-color, color, border colors, outline color, column rules,
and fill and stroke (both SVG and our custom versions).

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::diff):
(WebCore::borderStyleForColorProperty):
(WebCore::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::NonInheritedFlags::operator==):
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::insideLink):
(WebCore::InheritedFlags::isLink):
(WebCore::InheritedFlags::setInsideLink):
(WebCore::InheritedFlags::setIsLink):

  • rendering/style/RenderStyleConstants.h:

Change how link information is stored. The noninherited flags now have a bit set for if you're a link
or not. The inherited flags now cache whether you're inside a visited or unvisited link (or no link at
all).

(WebCore::):

  • svg/graphics/SVGPaintServer.cpp:

(WebCore::SVGPaintServer::fillPaintServer):
(WebCore::SVGPaintServer::strokePaintServer):
Patch SVG fill/stroke painting to honor :visited.

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS

Reviewed by Oliver Hunt.

Add SPI so that layout tests can access computed style including :visited information.

  • WebView/WebRenderNode.mm:

(copyRenderNode):

  • WebView/WebView.mm:

(-[WebView _computedStyleIncludingVisitedInfo:forElement:]):

  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:

WebKitTools: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS. Add a new method for
obtaining computed style with :visited info included. This allows layout tests to actually tell that
:visited is in effect.

Reviewed by Oliver Hunt.

  • DumpRenderTree/LayoutTestController.cpp:

(computedStyleIncludingVisitedInfoCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::computedStyleIncludingVisitedInfo):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=24300, don't expose history info via CSS

Reviewed by Oliver Hunt.

  • fast/history/clicked-link-is-visited.html: Removed.
  • fast/history/nested-visited-test-expected.txt: Added.
  • fast/history/nested-visited-test.html: Added.
  • fast/history/resources/dummy.html: Added.
  • fast/history/self-is-visited-expected.txt: Added.
  • fast/history/self-is-visited.html: Added.
  • fast/history/sibling-visited-test-expected.txt: Added.
  • fast/history/sibling-visited-test.html: Added.
  • fast/history/subframe-is-visited-expected.txt: Removed.
  • fast/history/subframe-is-visited.html: Removed.
14:09 Changeset [57291] by ojan@chromium.org
  • 33 edits
    4 deletes in trunk/LayoutTests

2010-04-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Daniel Bates.

[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Adds new results for all the tests that started failing after http://trac.webkit.org/changeset/57287.

  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
13:47 Changeset [57290] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix trunk (non-standalone) builds for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37136

Test for source files before building instead of relying on
standalone_package config.

  • WebKit.pro:
12:46 Changeset [57289] by dbates@webkit.org
  • 1 edit
    51 deletes in trunk/LayoutTests

2010-04-08 Daniel Bates <dbates@rim.com>

No review, rolling out 56717.
http://trac.webkit.org/changeset/56717
https://bugs.webkit.org/show_bug.cgi?id=9268

Rolling out the change committed in change set 56717
since we rolled out the change committed in change set 56655,
<http://trac.webkit.org/changeset/56655> (in change set 57287,
<http://trac.webkit.org/changeset/57287>). The change committed
in change set 56655 caused a layout test regression of the some
of the mozilla- and mozilla expected failure- tests. See bug #9268
for more details.

  • platform/qt/fast/table/table-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-background-expected.png: Removed.
  • platform/qt/fast/table/table-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.png: Removed.
  • platform/qt/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-group-col-span-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-group-span-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-group-span-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-group-span-background-expected.txt: Removed.
  • platform/qt/fast/table/table-col-span-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-col-span-background-expected.png: Removed.
  • platform/qt/fast/table/table-col-span-background-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-left-50px-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-left-50px-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-left-50px-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-right-100percent-expected.txt: Removed.
  • platform/qt/fast/table/table-row-background-right-50px-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-background-right-50px-expected.png: Removed.
  • platform/qt/fast/table/table-row-background-right-50px-expected.txt: Removed.
  • platform/qt/fast/table/table-row-group-background-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-group-background-expected.png: Removed.
  • platform/qt/fast/table/table-row-group-background-expected.txt: Removed.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.png: Removed.
  • platform/qt/fast/table/table-row-group-background-positioned-expected.txt: Removed.
12:42 Changeset [57288] by otte@webkit.org
  • 2 edits in trunk/WebCore

2010-04-08 Benjamin Otte <otte@gnome.org>

Reviewed by Gustavo Noronha.

Fix build with MathML enabled.

  • GNUmakefile.am:
12:21 Changeset [57287] by dbates@webkit.org
  • 7 edits
    68 deletes in trunk

2010-04-08 Daniel Bates <dbates@rim.com>

No review, rolling out 56655.
http://trac.webkit.org/changeset/56655
https://bugs.webkit.org/show_bug.cgi?id=9268

Rolling out the change committed in change set 56655
because it caused a regression in some of the mozilla
and mozilla expected failure test cases, such as:
tables/mozilla/marvin/backgr_simple-table-row.html, and
tables/mozilla/marvin/backgr_simple-table-row-group.html.

We need to look into this issue some more.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.h:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:

2010-04-08 Daniel Bates <dbates@rim.com>

No review, rolling out 56655.
http://trac.webkit.org/changeset/56655
https://bugs.webkit.org/show_bug.cgi?id=9268

Rolling out the change committed in change set 56655
because it caused a regression in some of the mozilla
and mozilla expected failure test cases, such as:
tables/mozilla/marvin/backgr_simple-table-row.html, and
tables/mozilla/marvin/backgr_simple-table-row-group.html.

We need to look into this issue some more.

  • fast/table/table-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-col-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-col-group-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-row-background.html: Removed.
  • fast/table/table-cell-border-draws-on-top-of-row-group-background.html: Removed.
  • fast/table/table-cell-overrides-row-background.html: Removed.
  • fast/table/table-col-background.html: Removed.
  • fast/table/table-col-group-background.html: Removed.
  • fast/table/table-col-group-col-span-background.html: Removed.
  • fast/table/table-col-group-span-background.html: Removed.
  • fast/table/table-col-span-background.html: Removed.
  • fast/table/table-row-background-left-50px.html: Removed.
  • fast/table/table-row-background-right-100percent.html: Removed.
  • fast/table/table-row-background-right-50px.html: Removed.
  • fast/table/table-row-background.html: Removed.
  • fast/table/table-row-group-background-positioned.html: Removed.
  • fast/table/table-row-group-background.html: Removed.
  • platform/mac/fast/table/table-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-background-expected.png: Removed.
  • platform/mac/fast/table/table-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.png: Removed.
  • platform/mac/fast/table/table-cell-overrides-row-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-group-col-span-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-group-span-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-group-span-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-group-span-background-expected.txt: Removed.
  • platform/mac/fast/table/table-col-span-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-col-span-background-expected.png: Removed.
  • platform/mac/fast/table/table-col-span-background-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-left-50px-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-left-50px-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-left-50px-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-right-100percent-expected.txt: Removed.
  • platform/mac/fast/table/table-row-background-right-50px-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-background-right-50px-expected.png: Removed.
  • platform/mac/fast/table/table-row-background-right-50px-expected.txt: Removed.
  • platform/mac/fast/table/table-row-group-background-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-group-background-expected.png: Removed.
  • platform/mac/fast/table/table-row-group-background-expected.txt: Removed.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.checksum: Removed.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.png: Removed.
  • platform/mac/fast/table/table-row-group-background-positioned-expected.txt: Removed.
11:40 Changeset [57286] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Refactor DatabaseTracker, part 1: Remove the dependency on
OriginQuotaManager from DatabaseTracker.h.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31482

  • storage/DatabaseTracker.cpp:

(originQuotaManager):
(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • storage/DatabaseTracker.h:
  • storage/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didExecuteStatement):

11:11 Changeset [57285] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Dimitri Glazkov.

A couple test expectations cleanups
https://bugs.webkit.org/show_bug.cgi?id=37285

  • platform/chromium/test_expectations.txt:
09:57 BuildBot edited by wsiegrist@apple.com
webkit-dev is a better choice for bot discussions (diff)
09:35 Changeset [57284] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

Fix http.conf for GTK-Debug and Chromium-Linux bots
https://bugs.webkit.org/show_bug.cgi?id=37279

  • http/conf/apache2-debian-httpd.conf:
09:23 Changeset [57283] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-08 Kwang Yul Seo <skyul@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Replace max with std::max
https://bugs.webkit.org/show_bug.cgi?id=37201

std::max is preferred.

  • platform/wince/FileSystemWince.cpp: (WebCore::makeAllDirectories): (WebCore::pathGetFileName):
09:08 Changeset [57282] by tonikitoo@webkit.org
  • 1 edit
    1 move
    1 add in trunk/WebCore

[EFL] Move AccessibilityObjectEfl.cpp from page to accessibility
https://bugs.webkit.org/show_bug.cgi?id=36405

Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>

  • accessibility/efl/AccessibilityObjectEfl.cpp: Renamed from WebCore/page/efl/AccessibilityObjectEfl.cpp.

(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

08:57 Changeset [57281] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Warnings when compiling InspectorClientQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=37266

Add a default: for the switch()-case to avoid
warnings.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::variantToSetting):
08:27 Changeset [57280] by pfeldman@chromium.org
  • 14 edits in trunk

2010-04-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Render Load, DOM Content and MarkTimeline event dividers on Timeline panel.

https://bugs.webkit.org/show_bug.cgi?id=37267

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent):
  • inspector/InspectorController.h:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
  • inspector/InspectorTimelineAgent.h: (WebCore::):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
  • inspector/front-end/TimelineAgent.js:
  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.removeEventDividers):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get _recordStyles): (WebInspector.TimelinePanel.prototype._updateMarks): (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._clearPanel): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition): (WebInspector.TimelineRecordGraphRow.prototype.update):
  • inspector/front-end/inspector.css: (.resources-event-divider): (.resources-red-divider): (.resources-blue-divider): (.resources-orange-divider):
08:00 Changeset [57279] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Fix a test for the behavior change by r57274.

  • fast/css/pseudo-invalid-novalidate-001.html:
07:43 Changeset [57278] by tonikitoo@webkit.org
  • 7 edits in trunk/WebKitTools

2010-04-05 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

[Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
https://bugs.webkit.org/show_bug.cgi?id=29431

Added stubs for Mac, win, gtk and wx DRTs to implement setScrollbarPolicy method.

  • DumpRenderTree/LayoutTestController.cpp: (setScrollbarPolicyCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setScrollbarPolicy):
07:38 Changeset [57277] by tonikitoo@webkit.org
  • 19 edits
    2 adds in trunk

2010-04-01 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by David Hyatt.

[Qt] REGRESSION:(r50665) QWebFrame::setScrollBarPolicy(Qt::Vertical,Qt::ScrollBarAlwaysOff) has no effect.
https://bugs.webkit.org/show_bug.cgi?id=29431

Test: fast/overflow/scrollbar-restored-and-then-locked.html

WebCore:

Patch introduces a lock scrollbars concept to ScrollView, as in WebDynamicScrollBarsView.mm/h
on WebKit/mac. It is needed because in QtWebKit, we have Api for setting both vertical and
horizontal scrollbars on/off/auto. When it is set to off, for example, it should remain
as such, unless unset.

For the locking concept, optional 'lock' parameters were added to setScrollbarModes,
setHorizontalScrollbarMode and setVerticalScrollbarMode methods of ScrollView. As these
are all optional, any previous code calling them do not need modification.

Two optional parameters were also added to Frame's createView method, for horizontal and vertical
lock state persistence cross page loads.

  • WebCore.base.exp:
  • page/Frame.cpp: (WebCore::Frame::createView):
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::setScrollbarModes): (WebCore::ScrollView::setHorizontalScrollbarMode): (WebCore::ScrollView::setVerticalScrollbarMode):
  • platform/ScrollView.h: (WebCore::ScrollView::setHorizontalScrollbarLock): (WebCore::ScrollView::isHorizontalScrollbarLocked): (WebCore::ScrollView::setVerticalScrollbarLock): (WebCore::ScrollView::isVerticalScrollbarLocked): (WebCore::ScrollView::setScrollingModesLocked):

WebKit/qt:

Make use of the new lock parameter of set{Vertical,Horizontal}ScrollbarMode.

Always added a qt auto test for set scrollbar policy feature.

  • Api/qwebframe.cpp: (QWebFrame::setScrollBarPolicy):
  • tests/qwebframe/tst_qwebframe.cpp:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (FrameLoaderClientQt::transitionToCommittedForNewPage):

WebKitTools:

Make possible to DRT to set scrollbar policies (on, off or auto).

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setScrollbarPolicy):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • QtLauncher/main.cpp: (LauncherWindow::toggleScrollbars): (LauncherWindow::createChrome):

LayoutTests:

  • fast/overflow/scrollbar-restored-and-then-locked-expected.txt: Added.
  • fast/overflow/scrollbar-restored-and-then-locked.html: Added.
07:29 QtWebKitJournal edited by henry.haverinen@nokia.com
(diff)
07:28 Changeset [57276] by yurys@chromium.org
  • 5 edits in trunk

2010-04-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Correctly save number of properties when object being serialized
have properties in its prorotype.

https://bugs.webkit.org/show_bug.cgi?id=37263

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::ZigZag::Serializer::AbstractObjectState::AbstractObjectState): (WebCore::ZigZag::Serializer::AbstractObjectState::advance):

2010-04-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Test that object with ptototype can be sent as message.

https://bugs.webkit.org/show_bug.cgi?id=37263

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:
07:14 Changeset [57275] by jorlow@chromium.org
  • 4 edits in trunk/WebCore

2010-04-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Yury Semikhatsky.

IDB callbacks should fire asynchronously
https://bugs.webkit.org/show_bug.cgi?id=37265

Fix the firing behavior of the callbacks to not be synchronous.

There's still a major bug that I'm trying to track down that is keeping
us from testing this stuff. Promise lots of tests ASAP.

  • bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::onSuccessAsync): (WebCore::V8CustomIDBCallbacks::onErrorAsync):
  • storage/IDBCallbacks.h: (WebCore::IDBCallbacks::IDBCallbacks): (WebCore::IDBCallbacks::onSuccess): (WebCore::IDBCallbacks::onError): (WebCore::IDBCallbacks::timerFired):
  • storage/IndexedDatabaseRequest.cpp:
07:10 Changeset [57274] by tkent@chromium.org
  • 9 edits
    3 adds
    20 deletes in trunk

willValidate doesn't need to check existence of a form element and a name attribute.
https://bugs.webkit.org/show_bug.cgi?id=34733

Reviewed by Darin Adler.

WebCore:

Remove checks against m_form and m_hasName in
HTMLFormControlElement::willValidate(), and remove the code to
track their updates.

Test: fast/forms/willvalidate.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseMappedAttribute):
(WebCore::HTMLFormControlElement::insertedIntoTree):
(WebCore::HTMLFormControlElement::removedFromTree):
(WebCore::HTMLFormControlElement::recalcWillValidate):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):

  • html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElement::formDestroyed):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setInputType):

setNeedsWillValidateCheck() should be called before
setAttribute(valueAttr, ...) is called.

LayoutTests:

  • Merge willvalidate-00x tests into one file.
  • Update tests affected by the willValidate behavior change.
  • fast/forms/input-live-pseudo-selectors-expected.txt:
  • fast/forms/resources/input-live-pseudo-selectors.js:
  • fast/forms/resources/textarea-live-pseudo-selectors.js:
  • fast/forms/script-tests/willvalidate.js: Added.
  • fast/forms/textarea-live-pseudo-selectors-expected.txt:
  • fast/forms/willvalidate-000-expected.txt: Removed.
  • fast/forms/willvalidate-000.html: Removed.
  • fast/forms/willvalidate-001-expected.txt: Removed.
  • fast/forms/willvalidate-001.html: Removed.
  • fast/forms/willvalidate-002-expected.txt: Removed.
  • fast/forms/willvalidate-002.html: Removed.
  • fast/forms/willvalidate-003-expected.txt: Removed.
  • fast/forms/willvalidate-003.html: Removed.
  • fast/forms/willvalidate-004-expected.txt: Removed.
  • fast/forms/willvalidate-004.html: Removed.
  • fast/forms/willvalidate-005-expected.txt: Removed.
  • fast/forms/willvalidate-005.html: Removed.
  • fast/forms/willvalidate-006-expected.txt: Removed.
  • fast/forms/willvalidate-006.html: Removed.
  • fast/forms/willvalidate-007-expected.txt: Removed.
  • fast/forms/willvalidate-007.html: Removed.
  • fast/forms/willvalidate-008-expected.txt: Removed.
  • fast/forms/willvalidate-008.html: Removed.
  • fast/forms/willvalidate-009-expected.txt: Removed.
  • fast/forms/willvalidate-009.html: Removed.
  • fast/forms/willvalidate-expected.txt: Added.
  • fast/forms/willvalidate.html: Added.
07:05 Changeset [57273] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-04-08 Young Han Lee <joybro@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Add missing headers
https://bugs.webkit.org/show_bug.cgi?id=37199

Include missing headers.

  • platform/graphics/wince/FontCustomPlatformData.cpp:
  • platform/graphics/wince/FontPlatformData.cpp:
  • platform/graphics/wince/GraphicsContextWince.cpp:
  • platform/graphics/wince/ImageBufferWince.cpp:
  • platform/graphics/wince/PlatformPathWince.h:
  • platform/wince/FileSystemWince.cpp:
06:54 Changeset [57272] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-08 Kwang Yul Seo <skyul@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Use WebCore::instanceHandle()
https://bugs.webkit.org/show_bug.cgi?id=37202

Page::instanceHandle() is moved to WebCore::instanceHandle().

  • platform/wince/PasteboardWince.cpp: (WebCore::Pasteboard::Pasteboard):
  • platform/wince/SharedTimerWince.cpp: (WebCore::initializeOffScreenTimerWindow):
06:44 Changeset [57271] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-08 Kwang Yul Seo <skyul@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Check if ARM or _ARM_ is defined
https://bugs.webkit.org/show_bug.cgi?id=37200

MSVC defines ARM and _ARM_ for Windows CE ARM. Define WTF_CPU_ARM=1
when either ARM or _ARM_ is defined.

  • wtf/Platform.h:
06:24 Changeset [57270] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-04-08 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

[Qt] WebKit crashes while input text through input method.
The formatted text underline painting crashes when painting with invalid indexes.
https://bugs.webkit.org/show_bug.cgi?id=36870

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethodsTextFormat_data): (tst_QWebPage::inputMethodsTextFormat):
05:38 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
03:15 Changeset [57269] by vitalyr@chromium.org
  • 9 edits
    2 adds in trunk

2010-04-08 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix crash in NodeFilterCondition in detached iframe
https://bugs.webkit.org/show_bug.cgi?id=37234

Test: fast/dom/node-filter-detached-iframe-crash.html

  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): Switched to using callFunctionWithoutFrame.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunctionWithoutFrame): Added a function to call V8 with no current frame.
  • bindings/v8/V8Proxy.h:

2010-04-08 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix crash in NodeFilterCondition in detached iframe
https://bugs.webkit.org/show_bug.cgi?id=37234

  • fast/dom/node-filter-detached-iframe-crash-expected.txt: Added.
  • fast/dom/node-filter-detached-iframe-crash.html: Added.
02:50 Changeset [57268] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Eric Seidel <eric@webkit.org>

Unreviewed. Update test_expectations to account for tests which fail
when run out of order.

fast/dom/SelectorAPI/dumpNodeList tests fail when run out of order.
https://bugs.webkit.org/show_bug.cgi?id=37259

  • platform/mac/test_expectations.txt:
02:23 Changeset [57267] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-08 Jarkko Sakkinen <jarkko.sakkinen@tieto.com>

Reviewed by Simon Hausmann.

[Qt] Remove shaderSource manipulation from GraphicsContext3DQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=37226

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::shaderSource):
02:13 Changeset [57266] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-08 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

[Qt] qtwebkit_webframe_scrollRecursively scrolls when body.style.overflow="hidden"
https://bugs.webkit.org/show_bug.cgi?id=36674

The scrolling check was based on the frameview's scrolloffset, and
maximumScrollPosition, which does not acknowledge the overflow properties.

I am now basing the scrolling off the scrollbar position. The scrollbars are
affected by the overflow properties indicating when not to scroll. The scrollbar
positions also continue to work for CSS ::-webkit-scrollbar styles.

  • Api/qwebframe.cpp: (qtwebkit_webframe_scrollRecursively):
01:59 Changeset [57265] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should give a percent complete indication
https://bugs.webkit.org/show_bug.cgi?id=37258

Because it's awesome.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
01:26 Changeset [57264] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Adam Barth <abarth@webkit.org>

Unreviewed. Update test_expectations to account for some tests that
fail when run out of order.

  • platform/mac/test_expectations.txt:
01:19 Changeset [57263] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-08 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Add test for SVG image with excessive nesting.
https://bugs.webkit.org/show_bug.cgi?id=37247

  • fast/images/svg-nested.html: added
  • fast/images/svg-nested-expected.txt: added

2010-04-08 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Sanity: apply a max node depth to XML parsing.

https://bugs.webkit.org/show_bug.cgi?id=37247

Test: fast/images/svg-nested.html

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode): Error out the parse upon a really large node depth.
01:16 Changeset [57262] by ossy@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed Oliver Hunt.

[Qt]r57240 broke Qt build (might be a gcc bug)
https://bugs.webkit.org/show_bug.cgi?id=37253

Workaround until fix. On PLATFORM(QT) use inline instead of ALWAYS_INLINE.

  • wtf/PassRefPtr.h: Qt guards added.
01:04 Changeset [57261] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

cross-frame-access-put depends on test ordering
https://bugs.webkit.org/show_bug.cgi?id=37254

If you run the tests in a different order, the value of this property
can change. We just need to avoid printing the actual value.

  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
00:54 Changeset [57260] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104

Turns out the CYGWIN also uses Apache 1.3, so can't bind to ::1 either.

  • http/conf/cygwin-httpd.conf:
00:51 Changeset [57259] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, cleaning up Chromium Mac test expecatations for fast/media.

  • platform/chromium/test_expectations.txt:
00:49 Changeset [57258] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-08 Adam Barth <abarth@webkit.org>

Unreviewed.

Add back the --target option because it's needed by the downstream
Chromium bots.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
00:45 Changeset [57257] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests should understand set-webkit-configuration
https://bugs.webkit.org/show_bug.cgi?id=37252

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
00:27 Changeset [57256] by abarth@webkit.org
  • 15 edits in trunk/WebKitTools

2010-04-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename target to configuration in new-run-webkit-tests to match the rest of WebKit
https://bugs.webkit.org/show_bug.cgi?id=37251

The rest of our tools call --debug or --release the configuration.
It's confusing to call it target in this script.

  • Scripts/webkitpy/layout_tests/driver_test.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
00:19 Changeset [57255] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-08 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, cleaning up test expectations for fast/media and media/video-played-reset.html.

Previously all of fast/media was marked as PASS FAIL, but now has finer-grained
expectations for all tests.

Due to Chromium-side changes, media/video-played-reset.html is now passing again.

  • platform/chromium/test_expectations.txt:

04/07/10:

23:56 Changeset [57254] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove depricated op.popen2 call in new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37249

Python complains that this API is depricated. We already solved this
problem in executive.py.

  • Scripts/webkitpy/layout_tests/port/mac.py:
23:55 Changeset [57253] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests crashes when run on a 64-bit machine
https://bugs.webkit.org/show_bug.cgi?id=37248

  • Scripts/webkitpy/layout_tests/port/mac.py:
    • The code was trying to always run the 32-bit intel version of the DumpRenderTree binary. DRT does not build 32-bit on 64-bit machines so that makes no sense. This may have made sense for test_shell at some point, but I think we should just remove this for DRT.
23:51 Changeset [57252] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
https://bugs.webkit.org/show_bug.cgi?id=37145

I think this test might be getting confused because it only expects the
end event to fire once but actually it fires again for the second
transition. Let's try this patch and see if it fixes the flakiness.

  • transitions/transition-end-event-set-none.html:
23:40 QtWebKit edited by henry.haverinen@nokia.com
(diff)
23:13 Changeset [57251] by mjs@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

(Not reviewed.)

Random demo to look cool on twitter.

  • misc/gradient-input.html: Added.
23:03 Changeset [57250] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104

Apache 1.3 does not support IPv6, so remove the Listen [::1] directive
and add a warning about how that may cause flakiness on systems which
use Apache 1.3, but support IPv6.

  • http/conf/httpd.conf:
22:00 Changeset [57249] by abarth@webkit.org
  • 9 edits in trunk

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104

WebKit Apache configs were only listening on IPv4 loopback (127.0.0.1), however
the system will resolve "localhost." to both IPv4 and IPv6 (::1) loopback
addreses when IPv6 is enabled. Since DNS lookup returns addresses in random
order, we would occasionally fail to make connections to "localhost" addresses
if the various network re-tries all happen to resolve to the IPv6 loopback.

To make matters worse, the kernel has a connection reset throttle which we
could trigger if we would repeatedly attempt to connect to ::1 and fail.
The trottle would cause a 1 or 2 second delay on the connection, sometimes
causing slow tests to time out.

I also discovered during this investigation that we have some partial support
for specifying our apache port numbers at runtime. The support is already incomplete
by not accounting for WebSockets or SSL ports. This fix will make our partial
support for dynamic apache port numbers even more broken.

I've added Listen [::1]:PORT directives for 8000, 8080, and 8443 to all
platforms (except cygwin which does not have the 8443 directive to begin with).

  • http/conf/apache2-debian-httpd.conf:
  • http/conf/apache2-httpd.conf:
  • http/conf/cygwin-httpd.conf:
  • http/conf/fedora-httpd.conf:
  • http/conf/httpd.conf:

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WebKit Apache configs only listen on IPv4 addresses, causing random timeouts
https://bugs.webkit.org/show_bug.cgi?id=37104

Add warnings that the partial support for specifying what port numbers
apache should bind to is even more broken after this fix.

  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
21:35 Changeset [57248] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Vector<UString> makes many needless calls to UString::UString and UString::~UString

Reviewed by Anders Carlsson.

Add a VectorTrait<UString> specialisation to allow vector to simply memset/memcpy
data around. Only difference from the VectorTrait<RefPtr<T> > traits is the inability
to use memset to initialize data.

  • runtime/UString.h:

(WTF::):

21:12 Changeset [57247] by hamaji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

LayoutTestController::m_handlesAuthenticationChallenges isn't initialized
https://bugs.webkit.org/show_bug.cgi?id=37190

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
21:11 Changeset [57246] by mitz@apple.com
  • 5 edits in trunk/WebKit/mac

Refactor WebHTMLView printing code and add private methods to enter and exit printing mode.
https://bugs.webkit.org/show_bug.cgi?id=37246

Reviewed by Adele Peterson.

  • Misc/WebNSPrintOperationExtras.h: Declared -_web_availablePaperWidth and -_web_availablePaperHeight.
  • Misc/WebNSPrintOperationExtras.m:

(-[NSPrintOperation _web_availablePaperWidth]): Turned -[WebHTMLView _availablePaperWidthForPrintOperation:]
into this method.
(-[NSPrintOperation _web_availablePaperHeight]): Turned -[WebHTMLView _calculatePrintHeight] into this
method.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _isInPrintMode]): Added this accessor.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Added. Moved the code from -knowsPageRange: that
computes the layout widths and enters printing mode into this private method.
(-[WebHTMLView _endPrintMode]): New private method (the old -_endPrintMode has been renamed).
(-[WebHTMLView _scaleFactorForPrintOperation:]): Use -[NSPrintOperation _web_availablePaperWidth].
(-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Renamed -_endPrintMode to this, changed it to call
_endPrintMode.
(-[WebHTMLView _delayedEndPrintMode:]): Updated for rename.
(-[WebHTMLView knowsPageRange:]): Use -_beginPrintModeWithPageWidth:shrintToFit:,
-[NSPrintOperation _web_availablePaperWidth], and -[NSPrintOperation _web_availablePaperHeight]. Updated for
rename.
(-[WebHTMLView beginDocument]): Updated for rename.
(-[WebHTMLView endDocument]): Ditto.

  • WebView/WebHTMLViewPrivate.h: Declared new private methods -_isInPrintMode,

-_beginPrintModeWithPageWidth:shrinkToFit: and -_endPrintMode.

18:18 Changeset [57245] by dumi@chromium.org
  • 9 edits in trunk/WebCore

Fix Chromium's HTML5 DB support in --single-process mode.
https://bugs.webkit.org/show_bug.cgi?id=37186.

Reviewed by Jeremy Orlow.

Always register and use Chromium's SQLite VFS for
WebSQLDatabases. Keep using the default VFS in all other
cases. This change should allow Chromium to support
WebSQLDatabases in --single-process mode.

Also, cleaning up a bit SQLiteFileSystemChromium and getting rid
of the SQLITE_OPEN_FULLMUTEX flag: we use sqlite DB handles only
on the DB thread, so we don't need multi-threaded support.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open):

  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::openDatabase):

  • platform/sql/SQLiteFileSystem.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp:

(WebCore::SQLiteFileSystem::openDatabase):

  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

(WebCore::SQLiteFileSystem::registerSQLiteVFS):

  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:

(WebCore::SQLiteFileSystem::registerSQLiteVFS):

  • storage/Database.cpp:

(WebCore::Database::performOpenAndVerify):

17:38 Changeset [57244] by cmarrin@apple.com
  • 7 edits
    3 deletes in trunk

Remove QuartzCoreInterface from the build


No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5).

17:32 Changeset [57243] by ojan@chromium.org
  • 2 edits
    2 deletes in trunk

2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57178.
http://trac.webkit.org/changeset/57178
https://bugs.webkit.org/show_bug.cgi?id=37240

Caused chromium browser_test and ui_test regressions
(Requested by ojan on #webkit).

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
16:52 Changeset [57242] by ojan@chromium.org
  • 5 edits
    4 adds in trunk/LayoutTests

2010-04-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

New chromium expected results after r57215
https://bugs.webkit.org/show_bug.cgi?id=37239

  • platform/chromium-linux/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/chromium-linux/fast/text/line-breaks-expected.checksum:
  • platform/chromium-linux/fast/text/line-breaks-expected.png:
  • platform/chromium-linux/fast/text/line-breaks-expected.txt: Our new behavior is no more broken than the old behavior. Evan says he'll fix the underlying problem some day.
  • platform/chromium-win/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/chromium-win/fast/repaint/stacked-diacritics-expected.txt: Added. This is a new test. These are just the usual windows vs. mac font rendering differences.
  • platform/chromium/test_expectations.txt:
16:49 Changeset [57241] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
https://bugs.webkit.org/show_bug.cgi?id=37235

Tiger's CFNetwork doesn't seem to understand "max-age=-1" so we'll
use "expires=some date in the past" to clear cookies instead.
I've verified that these tests still work on Snow Leopard.

  • http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
  • http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
16:06 Changeset [57240] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Beat gcc with a clue bat -- force inlining of refIfNotNull and derefIfNotNull

Reviewed by Geoff Garen.

  • wtf/PassRefPtr.h:
16:04 Changeset [57239] by jianli@chromium.org
  • 3 edits in trunk/WebCore

Add the comment and assert that we're generating version 4 random number
based UUIDs.
https://bugs.webkit.org/show_bug.cgi?id=36472

Reviewed by Adam Barth and Dmitry Titov.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

  • platform/UUID.h:
15:59 Changeset [57238] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-04-07 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Barth.

Allow white listing access from origin to local origin.
https://bugs.webkit.org/show_bug.cgi?id=37228

This makes it possible to load a local resource from a non local
origin if the access has previously been white listed by calling
SecurityOrigin::whiteListAccessFromOrigin.

  • http/tests/security/local-image-from-remote-whitelisted-expected.txt: Added.
  • http/tests/security/local-image-from-remote-whitelisted.html: Added.

2010-04-07 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Barth.

Allow white listing access from origin to local origin.
https://bugs.webkit.org/show_bug.cgi?id=37228

This makes it possible to load a local resource from a non local
origin if the access has previously been white listed by calling
SecurityOrigin::whiteListAccessFromOrigin.

Test: http/tests/security/local-image-from-remote-whitelisted.html

  • page/OriginAccessEntry.cpp: (WebCore::OriginAccessEntry::OriginAccessEntry): Removed assert that only the http and https protocol are valid.
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canRequest): Use isAccessWhiteListed (WebCore::SecurityOrigin::isAccessWhiteListed): Extracted code that goes through the originAccessMap to do the origin matching. (WebCore::SecurityOrigin::canLoad): Check if access has been white listed.
  • page/SecurityOrigin.h: Add private function isAccessWhiteListed
15:43 Changeset [57237] by eric@webkit.org
  • 5 edits in trunk/LayoutTests

2010-04-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
https://bugs.webkit.org/show_bug.cgi?id=37235

Added a ?clear=1 query parameter to the two "set cookies" cgi scripts
that these tests use, and call it to clear the cookies before leaving the test.

I could not resist the temptation of cleaning up the ridiculously awful copy/paste
in these tests, so the changes are larger than strictly necessary.

  • http/tests/xmlhttprequest/cookies.html:
  • http/tests/xmlhttprequest/cross-origin-cookie-storage.html:
  • http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
  • http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
14:53 Changeset [57236] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

Adding static method zero() to classes IntPoint and FloatPoint.
https://bugs.webkit.org/show_bug.cgi?id=37220

Adding static method zero() to classes IntPoint and FloatPoint as suggested by Darin Adler.

  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::zero):
  • platform/graphics/IntPoint.h: (WebCore::IntPoint::zero): (WebCore::IntPoint::clampNegativeToZero):
14:32 Changeset [57235] by ap@apple.com
  • 2 edits in trunk/WebCore
  • platform/network/mac/AuthenticationMac.mm: Fix a typo in comment.
14:30 Changeset [57234] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-07 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

A few tests in fast/canvas/webgl failed randomly on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=37098

  • fast/canvas/webgl/resources/webgl-test.js: Turn off stencil/antialias by default. (create3DContext):
  • fast/canvas/webgl/script-tests/index-validation.js: By default antialias is off.
14:25 Changeset [57233] by ap@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix a typo.

14:25 Changeset [57232] by ap@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Darinn Adler.

https://bugs.webkit.org/show_bug.cgi?id=37230
<rdar://problem/7813115> REGRESSION (4.0.5): Safari asks for credentials all the time when
authenticating to Windows IIS Server

  • platform/network/ProtectionSpace.h: (WebCore::ProtectionSpaceAuthenticationScheme): Added a constant for ProtectionSpaceAuthenticationSchemeUnknown.
  • platform/network/cf/AuthenticationCF.cpp: (WebCore::core):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::authenticationSchemeFromAuthenticationMethod): Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.
  • platform/network/mac/AuthenticationMac.mm: (WebCore::mac): Support NTLM on systems older than 10.6. We actually get this string from NSURLConnection, even though there was no public constant. (WebCore::core): Return ProtectionSpaceAuthenticationSchemeUnknown for unknown scheme.
14:20 Changeset [57231] by eric@webkit.org
  • 17 edits in trunk

2010-04-07 Jaime Yap <jaimeyap@google.com>

Reviewed by Pavel Feldman.
Tests expectations changed due to the addition of the function symbol name for
the call location for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839

No new tests.

  • inspector/timeline-test.js:
  • platform/chromium-win/inspector/timeline-event-dispatch-expected.txt:
  • platform/chromium-win/inspector/timeline-mark-timeline-expected.txt:
  • platform/chromium-win/inspector/timeline-network-resource-expected.txt:
  • platform/chromium-win/inspector/timeline-paint-expected.txt:
  • platform/chromium-win/inspector/timeline-parse-html-expected.txt:

2010-04-07 Jaime Yap <jaimeyap@google.com>

Reviewed by Pavel Feldman.

Adds the ability to get the function symbol name when looking up the call location
for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839

No new tests.

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
  • bindings/js/ScriptCallStack.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createUtilityContext): (WebCore::ScriptDebugServer::topStackFrame):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::utilityContext):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
14:10 Changeset [57230] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-04-07 Jay Civelli <jcivelli@chromium.org>

Reviewed by Jian Li.

[chromium] Add test for a popup related crasher.
https://bugs.webkit.org/show_bug.cgi?id=37141

  • platform/chromium/fast/forms: Added.
  • platform/chromium/fast/forms/search-popup-crasher-expected.txt: Added.
  • platform/chromium/fast/forms/search-popup-crasher.html: Added.

2010-04-07 Jay Civelli <jcivelli@chromium.org>

Reviewed by Jian Li.

[chromium] Fixing a NULL pointer being dereferenced in some cases.
https://bugs.webkit.org/show_bug.cgi?id=37141

Test: platform/chromium/fast/forms/search-popup-crasher.html

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenu::~PopupMenu):
13:47 Changeset [57229] by jianli@chromium.org
  • 8 edits
    3 copies in trunk/WebCore

Add skeleton FileStream module for providing sync file operations for FileAPI
https://bugs.webkit.org/show_bug.cgi?id=37217

Patch by Kinuko Yasuda <kinuko@chromium.org> on 2010-04-07
Reviewed by Jian Li.

For now the module just defines an interface and is almost empty.
Implementation will be added.

No new tests; will be added when we have complete implementation.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/FileStream.cpp: Added.
  • html/FileStream.h: Added.
  • html/FileStreamClient.h: Added.
  • html/FileThread.cpp:

(WebCore::SameFilePredicate::SameFilePredicate):
(WebCore::SameFilePredicate::operator()):
(WebCore::FileThread::unscheduleTasks):

  • html/FileThread.h:

(WebCore::FileThread::Task::stream):
(WebCore::FileThread::Task::Task):

13:44 Changeset [57228] by ossy@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Rubber-stamped by Kenneth Rohde Christiansen.

Poor rendering on lala.com with frame flattening
https://bugs.webkit.org/show_bug.cgi?id=37164

Platform specific expected files added for test introduced in r57225.

  • platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
  • platform/qt/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
13:37 Changeset [57227] by oliver@apple.com
  • 5 edits in trunk/WebCore

2010-04-07 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Remove some unnecessary uses of commonJSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=37229

Pass the ExecState down to identifierFromNPIdentifier and update call sites

  • bridge/NP_jsobject.cpp: (_NPN_Invoke): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::getPropertyNames):
  • bridge/c/c_utility.cpp: (JSC::Bindings::identifierFromNPIdentifier):
  • bridge/c/c_utility.h:
13:32 Changeset [57226] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-07 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Replace isprint with isASCIIPrintable
https://bugs.webkit.org/show_bug.cgi?id=37223

WebKit does not use functions in <ctype.h> as they are dependent on the current
locale. Use the equivalent functions in <wtf/ASCIICType.h>. isASCIIPrintable
replaces isprint.

  • pcre/pcre_exec.cpp: (pchars):
13:22 Changeset [57225] by eric@webkit.org
  • 3 edits
    1 add in trunk

2010-04-07 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Darin Adler.

Poor rendering on lala.com with frame flattening
https://bugs.webkit.org/show_bug.cgi?id=37164

Do not flatten offscreen iframes.

Test: fast/frames/flattening/iframe-flattening-offscreen.html

  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::flattenFrame):
  • rendering/RenderPartObject.h:
12:57 BuildBot edited by wsiegrist@apple.com
update contact and port (diff)
12:49 Changeset [57224] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2010-04-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Make sure that calling bindings constructors as function does not result in crash.

  • fast/constructors: Added.
  • fast/constructors/constructor-as-function-crash-expected.txt: Added.
  • fast/constructors/constructor-as-function-crash.html: Added.

2010-04-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

[V8] Add a missing check for constructor call in WebKitPointConstructor.
https://bugs.webkit.org/show_bug.cgi?id=37210

Test: fast/constructors/constructor-as-function-crash.html

  • bindings/v8/custom/V8WebKitPointConstructor.cpp: (WebCore::V8WebKitPoint::constructorCallback): Added a check for constructor call.
12:17 Changeset [57223] by ojan@chromium.org
  • 5 edits in trunk/LayoutTests

2010-04-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Simon Fraser.

Make tests pass with tolerance=0 after r57215
https://bugs.webkit.org/show_bug.cgi?id=37225

  • platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
  • platform/mac/fast/repaint/stacked-diacritics-expected.png:
11:54 Changeset [57222] by scherkus@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

2010-04-07 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, skipping fast/media/media-feature-wgt-view-mode.html for Chromium.

Chromium doesn't implement layoutTestController.setViewModeMediaFeature(), which is needed
to pass this layout test.

  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Removed.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Removed.
  • platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Skip fast/media/media-feature-wgt-view-mode.html.
11:44 Changeset [57221] by enrica@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/mac/SimpleFontDataMac.mm

Fixing TIGER build (take 2)

11:16 Changeset [57220] by pfeldman@chromium.org
  • 3 edits
    5 adds in trunk/WebKit/chromium

2010-04-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: support themes in devtools window.

https://bugs.webkit.org/attachment.cgi?bugid=37216

  • WebKit.gypi:
  • src/js/DevTools.js: (WebInspector.setToolbarColors): (WebInspector.resetToolbarColors):
  • src/js/Images/segmentChromium2.png: Added.
  • src/js/Images/segmentHoverChromium2.png: Added.
  • src/js/Images/segmentSelectedChromium2.png: Added.
  • src/js/Images/statusbarBackgroundChromium2.png: Added.
  • src/js/Images/statusbarMenuButtonChromium2.png: Added.
11:12 Changeset [57219] by scherkus@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

2010-04-07 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in missing image baselines for fast/layers/video-layer.html

  • platform/chromium-linux/fast/layers/video-layer-expected.checksum: Added.
  • platform/chromium-linux/fast/layers/video-layer-expected.png: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.checksum: Added.
  • platform/chromium-mac/fast/layers/video-layer-expected.png: Added.
  • platform/chromium-win/fast/layers/video-layer-expected.checksum: Updated.
  • platform/chromium-win/fast/layers/video-layer-expected.png: Updated.
10:59 Changeset [57218] by enrica@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=37219

Reviewed by Darin Adler.

JavaScriptCore:

This change disables text caret for the iPhone platflorm.

  • wtf/Platform.h: Disabled text caret for iPhone.

WebCore:

This change disables text caret for the iPhone platflorm.
Added UNUSED_PARAM to build when ENABLE_TEXT_CARET is 0.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::recomputeCaretRect):
(WebCore::SelectionController::paintCaret):

  • page/Frame.cpp:

(WebCore::Frame::paintDragCaret):

10:57 Changeset [57217] by enrica@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/mac/SimpleFontDataMac.mm

Fixing TIGER build

10:06 Changeset [57216] by enrica@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

  • fast/repaint/stacked-diacritics.html: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.
10:01 Changeset [57215] by enrica@apple.com
  • 42 edits
    2 moves
    4 adds in trunk

WebCore: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

In order to be able to handle successfully this case, it is necessary to change the glyph width cache to store
the bounding box for the glyph instead of the simply caching the glyph width.
Retrieving the bounding box for the glyph is expensive, therefore we do it only
when we are rendering text using the complex text path to minimize the performance impact.
To support characters with stacked diacritics, the method canUseGlyphCache has been modified to
return false for the range of characters with stacked diacritics.
The glyph cache has been also updated to allow storing the glyph bounding box together with the
horizontal width. The bounding box is populated only for complex text.

The original version of this patch has been written by Dan Bernstein.

Test: fast/repaint/stacked-diacritics.html

  • Android.mk: File name change.
  • GNUmakefile.am: File name change.
  • WebCore.base.exp: Added parameter in exported function.
  • WebCore.gypi: File name change.
  • WebCore.vcproj/WebCore.vcproj: File name change.
  • WebCore.xcodeproj/project.pbxproj: File name change.
  • platform/graphics/Font.cpp:

(WebCore::Font::floatWidth): Added glyphOverflow parameter.

  • platform/graphics/Font.h:

(WebCore::GlyphOverflow::GlyphOverflow): Added.
(WebCore::Font::width): Added glyphOverflow parameter.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::canUseGlyphCache): Modified to render characters with stacked diacritics with complex text path.

  • platform/graphics/GlyphMetricsMap.cpp: Copied from WebCore/platform/graphics/GlyphWidthMap.cpp.

(WebCore::GlyphMetricsMap::locatePageSlowCase): Class name changed to reflect new semantics.

  • platform/graphics/GlyphMetricsMap.h: Copied from WebCore/platform/graphics/GlyphWidthMap.h.

(WebCore::GlyphMetricsMap::GlyphMetricsMap):
(WebCore::GlyphMetricsMap::~GlyphMetricsMap):
(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::widthForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
(WebCore::GlyphMetricsMap::locatePage):

  • platform/graphics/GlyphWidthMap.cpp: Removed.
  • platform/graphics/GlyphWidthMap.h: Removed.
  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit):

  • platform/graphics/SimpleFontData.h:

(WebCore::):
(WebCore::SimpleFontData::widthForGlyph):
(WebCore::SimpleFontData::metricsForGlyph):

  • platform/graphics/cairo/SimpleFontDataCairo.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/chromium/FontLinux.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::platformWidthForGlyph): Name and signature vachange

  • platform/graphics/efl/FontEfl.cpp:

(WebCore::Font::floatWidthForComplexText): Name and signature change.

  • platform/graphics/gtk/SimpleFontDataPango.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/haiku/FontHaiku.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/haiku/SimpleFontDataHaiku.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::minGlyphBoundingBoxX):
(WebCore::ComplexTextController::maxGlyphBoundingBoxX):
(WebCore::ComplexTextController::minGlyphBoundingBoxY):
(WebCore::ComplexTextController::maxGlyphBoundingBoxY):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::floatWidthForComplexText): Added paramter.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText): Added paramter.

  • platform/graphics/win/FontWin.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::metricsForGDIGlyph):

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/graphics/win/UniscribeController.h:

(WebCore::UniscribeController::minGlyphBoundingBoxX):
(WebCore::UniscribeController::maxGlyphBoundingBoxX):
(WebCore::UniscribeController::minGlyphBoundingBoxY):
(WebCore::UniscribeController::maxGlyphBoundingBoxY):

  • platform/graphics/wince/FontWince.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/wx/FontWx.cpp:

(WebCore::Font::floatWidthForComplexText): Added parameter.

  • platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::platformMetricsForGlyph): Name and signature change.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::computeVerticalOverflow):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::setFallbackFonts):
(WebCore::InlineTextBox::fallbackFonts):
(WebCore::InlineTextBox::setGlyphOverflow):
(WebCore::InlineTextBox::glyphOverflow):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::clearGlyphOverflowAndFallbackFontMap): Added.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::trimmedPrefWidths):
(WebCore::RenderText::calcPrefWidths):
(WebCore::RenderText::setText):
(WebCore::RenderText::width):

  • rendering/RenderText.h:

LayoutTests: Text repainting does not account for glyphs which draw outside the typographic bounds of the font (6274).
<rdar://problem/6649734>
<https://bugs.webkit.org/show_bug.cgi?id=6274>

Reviewed by Dave Hyatt.

  • fast/repaint/stacked-diacritics.html: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/mac/fast/repaint/stacked-diacritics-expected.txt: Added.
09:53 Changeset [57214] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-07 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Darin Adler.

Fix incorrect white-space in WebGLRenderingContext.idl
https://bugs.webkit.org/show_bug.cgi?id=31339

  • html/canvas/WebGLRenderingContext.idl: Remove offending extra whitespace.
09:43 Changeset [57213] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-07 Rodrigo Belem <rodrigo.belem@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] The build system is not installing the generated headers (QGraphicsWebView, QWebDatabase, etc)
https://bugs.webkit.org/show_bug.cgi?id=37173

This patch sets the correct path to the classheaders.pri and then
fixes the installation of the generated headers.

  • WebCore.pro:
09:33 Changeset [57212] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-04-07 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add ewk_view (the high level object to acces the WebKit-EFL browser
component) to efl/ewk.
http://webkit.org/b/35932

  • efl/ewk/ewk_view.cpp: Added.
  • efl/ewk/ewk_view.h: Added.
09:32 Changeset [57211] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable https://bugs.webkit.org/show_bug.cgi?id=37135

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

It happens, for example, when distanceDataForNode assigns numeric_limits<long long> to
current focus candidate's. It means that current candidate is not in direction, or not
a valid target node.

  • page/FocusController.cpp:

(WebCore::FocusController::findFocusableNodeInDirection):

09:18 Changeset [57210] by eric@webkit.org
  • 44 edits in trunk

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed inspector methods from ScriptExecutionContext and derived classes.
Removed MessageDestination parameter from console-related calls (we now always
log to the same destination(s)).
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • dom/Document.cpp: (WebCore::Document::reportException): (WebCore::Document::addMessage):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoadNotifier.cpp:
  • loader/ResourceLoadNotifier.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::appendToBuffer):
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::postConsoleMessageTask): (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts): (WebCore::WorkerContext::addMessage):
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerReportingProxy.h:
  • xml/XMLHttpRequest.cpp: (WebCore::reportUnsafeUsage): (WebCore::XMLHttpRequest::didFinishLoading):

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed inspector methods from ScriptExecutionContext and derived classes.
Removed MessageDestination parameter from console-related calls (we now always
log to the same destination(s)).
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject): (WebKit::WebWorkerBase::postConsoleMessageTask):
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject): (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask):
  • src/WebWorkerClientImpl.h:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/FrameLoaderClientQt.cpp:
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

2010-04-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949

  • WebKitSupport/FrameLoaderClientWx.cpp:
  • WebKitSupport/FrameLoaderClientWx.h:
08:52 Changeset [57209] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[Chromium] WebIDBDatabaseError::assign doesn't work correctly
https://bugs.webkit.org/show_bug.cgi?id=37209

  • src/WebIDBDatabaseError.cpp: (WebKit::WebIDBDatabaseError::assign):
07:14 Changeset [57208] by hausmann@webkit.org
  • 7 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=36827

Patch by Dawit Alemayehu <adawit@kde.org> on 2010-04-07
Reviewed by Simon Hausmann.

WebCore:

Replaced the 'shouldTreatAsAttachment' function with a more generic
function that returns the content disposition type.

See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395

  • platform/network/HTTPParsers.cpp:

(WebCore::contentDispositionType):

  • platform/network/HTTPParsers.h:

(WebCore::):

WebKit/chromium:

Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.

See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):

WebKit/qt:

Updated the WebCore::shouldTreatAsAttachement function call with the
new more generic replacement WebCore::contentDispositionType.

See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):

07:04 Changeset [57207] by vitalyr@chromium.org
  • 10 edits in trunk/WebCore

2010-04-07 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Yury Semikhatsky.

[V8] Throw exception in SerializedScriptValue on input errors
https://bugs.webkit.org/show_bug.cgi?id=37160

When cycles are detected SerializedScriptValue should throw
NOT_SUPPORTED_ERR. See
http://www.whatwg.org/specs/web-apps/2009-10-27/multipage/urls.html#structured-clone

  • bindings/scripts/CodeGeneratorV8.pm: Custom processing for function arguments of type SerializedScriptValue.
  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/SerializedScriptValue.h: (WebCore::SerializedScriptValue::create): Added a constructor function with an extra paratemer to check whether an exception was thrown.

SerializedScriptValue::create callers updated to check for
exceptions:

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::postMessageCallback):
  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp: (WebCore::V8DedicatedWorkerContext::postMessageCallback):
  • bindings/v8/custom/V8HistoryCustom.cpp: (WebCore::V8History::pushStateCallback): (WebCore::V8History::replaceStateCallback):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::V8MessagePort::postMessageCallback):
  • bindings/v8/custom/V8PopStateEventCustom.cpp: (WebCore::V8PopStateEvent::initPopStateEventCallback):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::V8Worker::postMessageCallback):
06:10 Changeset [57206] by apavlov@chromium.org
  • 5 edits in trunk/WebCore

2010-04-07 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Provide a placeholder for resources with no content available
https://bugs.webkit.org/show_bug.cgi?id=37142

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ImageView.js: (WebInspector.ImageView): (WebInspector.ImageView.prototype.contentTabSelected):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._innerSelectContentTab): (WebInspector.ResourceView.prototype.contentTabSelected):
  • inspector/front-end/inspector.css: (.resource-content-unavailable):
05:48 Changeset [57205] by hausmann@webkit.org
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36750

Reviewed by Laszlo Gombos.

[Qt] Package build without touch support is broken

Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.

  • dom/Document.idl: Use conditional instead of #ifdef.
  • dom/Element.idl: Ditto.
  • page/DOMWindow.idl: Ditto.
05:03 Changeset [57204] by hausmann@webkit.org
  • 4 edits in trunk/WebCore

Add the touch event related IDL files to the idl generation, so that
they can be safely included from generated JS bindings files. The
generated files have #ifdef feature guards.

Reviewed by Holger Freyther.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
04:39 Changeset [57203] by jorlow@chromium.org
  • 4 edits in trunk/WebCore

2010-04-06 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

V8CustomIDBCallbacks<> should not hold a reference to the frame
https://bugs.webkit.org/show_bug.cgi?id=37154

Don't hold on to a Frame reference.
Instead, be an ActiveDOMObject and use scriptExecutionContext()
to get the v8 context.
Factor the guts of onSuccess and onError out.

Doesn't work enough to test yet.

  • bindings/v8/custom/V8CustomIDBCallbacks.h: (WebCore::V8CustomIDBCallbacks::create): (WebCore::V8CustomIDBCallbacks::onSuccess): (WebCore::V8CustomIDBCallbacks::onError): (WebCore::V8CustomIDBCallbacks::V8CustomIDBCallbacks): (WebCore::V8CustomIDBCallbacks::onEvent):
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: (WebCore::V8IndexedDatabaseRequest::openCallback):
  • storage/IDBCallbacks.h: (WebCore::IDBCallbacks::IDBCallbacks):
04:14 Changeset [57202] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-07 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] When providing a widget for the PDF mime type it will cause a crash

m_pluginView may actually be a Widget (for embedded Qt widgets),
so always check isPluginView() before calling PluginView specific methods.

https://bugs.webkit.org/show_bug.cgi?id=29450

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad):
03:19 Changeset [57201] by eric@webkit.org
  • 12 edits in trunk

2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57196.
http://trac.webkit.org/changeset/57196
https://bugs.webkit.org/show_bug.cgi?id=37196

Multiple layout test failures on Chromium (Requested by yurys
on #webkit).

  • inspector/timeline-test.js:

2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57196.
http://trac.webkit.org/changeset/57196
https://bugs.webkit.org/show_bug.cgi?id=37196

Multiple layout test failures on Chromium (Requested by yurys
on #webkit).

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
  • bindings/js/ScriptCallStack.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptDebugServer.cpp:
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::createUtilityContext): (WebCore::V8Proxy::sourceLineNumber): (WebCore::V8Proxy::sourceName):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::utilityContext):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
03:07 QtWebKitTriageRoster edited by ossy@webkit.org
(diff)
02:19 Changeset [57200] by hausmann@webkit.org
  • 4 edits in trunk/WebCore

Unreviewed, rolling out r57199.
http://trac.webkit.org/changeset/57199
https://bugs.webkit.org/show_bug.cgi?id=36750

Breaks non-touch enabled build

  • dom/Document.idl:
  • dom/Element.idl:
  • page/DOMWindow.idl:
02:08 Changeset [57199] by hausmann@webkit.org
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=36750

Reviewed by Laszlo Gombos.

[Qt] Package build without touch support is broken

Use the conditional attribute instead of #ifdefs in the idl file for the
touch specific properties, to make the generated files compile with and
without the touch events enabled.

  • dom/Document.idl: Use conditional instead of #ifdef.
  • dom/Element.idl: Ditto.
  • page/DOMWindow.idl: Ditto.
01:15 Changeset [57198] by eric@webkit.org
  • 2 edits in trunk

2010-04-07 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix trunk (non-standalone) builds for Symbian
https://bugs.webkit.org/show_bug.cgi?id=37136

Test for source files before building instead of relying on
standalone_package config.

  • WebKit.pro:
00:39 Changeset [57197] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-04-07 Jochen Eisinger <jochen@chromium.org>

Reviewed by Darin Fisher.

Add createApplicationCacheHost to WebFrameClient so
the ApplicationCacheHost has access to its frame.

https://bugs.webkit.org/show_bug.cgi?id=36882

  • public/WebFrameClient.h: (WebKit::WebFrameClient::createApplicationCacheHost):
  • src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
00:20 Changeset [57196] by eric@webkit.org
  • 12 edits in trunk

2010-04-07 Jaime Yap <jaimeyap@google.com>

Reviewed by Yury Semikhatsky.

Adds callerFuncName to the list of nondeterministic fields in the timeline
layout tests.
https://bugs.webkit.org/show_bug.cgi?id=36839

  • inspector/timeline-test.js:

2010-04-07 Jaime Yap <jaimeyap@google.com>

Reviewed by Yury Semikhatsky.

Adds the ability to get the function symbol name when looking up the call location
for records sent by the InspectorTimelineAgent.
https://bugs.webkit.org/show_bug.cgi?id=36839

No new tests.

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation):
  • bindings/js/ScriptCallStack.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createUtilityContext): (WebCore::ScriptDebugServer::lastCallFrame):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::utilityContext):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
Note: See TracTimeline for information about the timeline view.