Timeline


and

04/18/10:

23:36 Changeset [57805] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

Make failure-reason more forgiving
https://bugs.webkit.org/show_bug.cgi?id=37525

Removed search_limit, which wasn't very useful anyway.
Added a log about the long load time loading from the builders.
Prompt the user for what revision to start walking from (makes it easy to restart upon failure).

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/tool/commands/queries.py:
22:13 Changeset [57804] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-18 Kwang Yul Seo <skyul@company100.net>

Reviewed by Laszlo Gombos.

[WINCE] Don't define WTF_CPU_MIDDLE_ENDIAN=1
https://bugs.webkit.org/show_bug.cgi?id=37434

Windows CE supports little-endian format only, so don't define
WTF_CPU_MIDDLE_ENDIAN=1.

  • wtf/Platform.h:
21:26 Changeset [57803] by cjerdonek@webkit.org
  • 3 edits
    2 adds in trunk/WebKitTools

Created a class for check-webkit-style that encapsulates iterating
over text files and reading them.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=37754

This revision is an intermediate step towards separating our
style-checking code from the logic of iterating over files and
reading them.

  • Scripts/webkitpy/common/system/logtesting.py:
    • Added a logMessages() method to the LoggingTestCase class. This method provides unit tests with access to the raw list of log messages in case the tester needs to do something more than simply assert the list of existing messages.
  • Scripts/webkitpy/style/checker.py:
    • Added a ProcessorBase class that processors of lists of lines should eventually inherit from.
    • Also added a FIXME to use the ProcessorBase class and the TextFileReader class added below.
  • Scripts/webkitpy/style/filereader.py: Added.
    • Created a TextFileReader class that encapsulates reading and iterating over text files.
  • Scripts/webkitpy/style/filereader_unittest.py: Added.
    • Added a TextFileReaderTest class to unit-test the new TextFileReader class.
21:22 Changeset [57802] by eric@webkit.org
  • 4 edits in trunk

2010-04-18 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix JavaScriptCore's include path for WinCE builds

https://bugs.webkit.org/show_bug.cgi?id=36751

2010-04-18 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix JavaScriptCore's include path for WinCE builds

https://bugs.webkit.org/show_bug.cgi?id=36751

  • WebCore.pro:
21:08 Changeset [57801] by eric@webkit.org
  • 2 edits in trunk

2010-04-18 Michael Forney <michael@mforney.org>

Reviewed by Laszlo Gombos.

https://bugs.webkit.org/show_bug.cgi?id=37762

Fixes the sandbox option in configure.

  • configure.ac: Fix cut and paste error in the sandbox option causing --{enable,disable}-sandbox to be ineffective, and it to be controlled by the ruby flag.
20:26 Changeset [57800] by tony@chromium.org
  • 5 edits in trunk/WebKitTools

2010-04-15 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] new-run-webkit-tests should be able to use chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=37645

Make sure that the lack of a chromium checkout doesn't cause the script to
fail.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths

to be relative to an upstream output dir.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
14:25 Changeset [57799] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <eric@webkit.org>

Unreviewed, fixing the Qt bot.

Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
https://bugs.webkit.org/show_bug.cgi?id=37632

  • Scripts/run-webkit-tests:
    • Exit non-zero of launching the harness fails.
13:58 Changeset [57798] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <eric@webkit.org>

Unreviewed, fixing the Qt bot.

Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
https://bugs.webkit.org/show_bug.cgi?id=37632

  • Scripts/run-webkit-tests:
    • Fix the wrapper to work for users who do not have WebKitTools/Scripts in their path.
13:56 Changeset [57797] by abarth@webkit.org
  • 2 edits in trunk/WebKitSite

2010-04-18 Adam Barth <abarth@webkit.org>

Unreviewed. Update a label of the diagram to better match the
description in the text of the blog post.

  • blog-files/loader-diagram.svg:
13:34 Changeset [57796] by eric@webkit.org
  • 3 edits
    1 copy in trunk/WebKitTools

2010-04-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add a layer of indirection when calling run-webkit-tests to
allow testing new-run-webkit-tests on various platforms.
https://bugs.webkit.org/show_bug.cgi?id=37632

This will let us test and fix bugs in new-run-webkit-tests
without needing to restart the buildbot master between tests.

Currently this change leaves run-webkit-tests as-is, but once
its landed we will easily be able to turn on/off
new-run-webkit-tests for various ports/configurations.

I will send a note out to webkit-dev about how we will
be using this launcher script to test on the bots.

  • Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
  • Scripts/run-webkit-tests:
    • A new script which decides whether to run new- or old- run-webkit-tests based on the platform.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add some dummy argument handling for arguments which old-run-webkit-tests supports but new-run-webkit-tests does not yet.
10:43 Changeset [57795] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
https://bugs.webkit.org/show_bug.cgi?id=33295

The Gtk builders have been green every time I've looked
at them in the last 5 days or so. It would appear webkit
is now keeping them green and we should update the core
builder list to match reality.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
04:01 Changeset [57794] by robert@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

[Qt] Add support for LayoutTestController commands

2010-04-18 Robert Hogan <robert@webkit.org>

Unreviewed fix to pixel differences in unskipped layout tests.

[Qt] Add support for LayoutTestController commands

Fix up minor pixel differences on unskipped tests from r57793.

https://bugs.webkit.org/show_bug.cgi?id=35844

  • platform/qt/editing/deleting/smart-delete-003-expected.txt:
  • platform/qt/editing/deleting/smart-delete-004-expected.txt:
  • platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
  • platform/qt/editing/selection/5195166-2-expected.txt:
03:36 Changeset [57793] by robert@webkit.org
  • 17 edits in trunk

[Qt] Add support for LayoutTestController commands
2010-04-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

https://bugs.webkit.org/show_bug.cgi?id=35844

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebpage_p.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setSmartInsertDeleteEnabled): (DumpRenderTreeSupportQt::setSelectTrailingWhitespaceEnabled): (DumpRenderTreeSupportQt::executeCoreCommandByName): (DumpRenderTreeSupportQt::isCommandEnabled):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::smartInsertDeleteEnabled): (WebCore::EditorClientQt::toggleSmartInsertDelete): (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
  • WebCoreSupport/EditorClientQt.h:

2010-04-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

Unskip tests:
editing/deleting/smart-editing-disabled.html
editing/execCommand/19089.html
editing/execCommand/delete-image-in-anchor.html
editing/execCommand/enabling-and-selection-2.html
editing/selection/doubleclick-whitespace-crash.html
editing/selection/doubleclick-whitespace-img-crash.html
editing/selection/doubleclick-whitespace.html
editing/selection/select-line.html
editing/deleting/5300379.html
editing/deleting/smart-delete-003.html
editing/deleting/smart-delete-004.html
editing/selection/5195166-1.html
editing/selection/5195166-2.html

https://bugs.webkit.org/show_bug.cgi?id=35844

  • platform/qt/Skipped:
  • platform/qt/editing/deleting/5300379-expected.txt: Update platform-specific results.
  • platform/qt/editing/deleting/smart-delete-003-expected.txt: Update platform-specific results.
  • platform/qt/editing/deleting/smart-delete-004-expected.txt: Update platform-specific results.
  • platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
  • platform/qt/editing/selection/5195166-2-expected.txt: Update platform-specific results.

2010-04-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

https://bugs.webkit.org/show_bug.cgi?id=35844

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): (LayoutTestController::setSelectTrailingWhitespaceEnabled): (LayoutTestController::execCommand): (LayoutTestController::isCommandEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
03:25 Changeset [57792] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-18 Antonio Gomes <tonikitoo@webkit.org>

[Qt] Unreviewed fix: remove svg/custom/clip-path-display-none-child.svg from Skipped (non-existent test)

It was removed by r57511.

  • platform/qt/Skipped:

04/17/10:

23:27 Changeset [57791] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitSite

2010-04-17 Adam Barth <abarth@webkit.org>

Unreviewed. Added loader diagram for upcoming blog post.

  • blog-files/loader-diagram.svg: Added.
23:03 Changeset [57790] by ap@apple.com
  • 8 edits in trunk

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=37720
<rdar://problem/7873752> HTMLFrameSetElement-window-eventListener-attributes.html sometimes
crashes on SnowLeopard Release

Tests:

  • fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:
  • fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:
  • bindings/scripts/CodeGeneratorJS.pm: Use global object as a wrapper for window event listeners set via document.body. The body wrapper can go away if nothing else references it.
  • html/HTMLBodyElement.idl: Override listeners that exist on Element with custom implementations, because we need to use window object as a wrapper, not the element. Marked all window event listeners as such for code generator.
  • html/HTMLFrameSetElement.idl: Ditto.
22:00 Changeset [57789] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-04-17 Juan C. Montemayor <jmonte03@cs.tufts.edu>

Reviewed by Joseph Pecoraro.

Databases pane doesn't recognize table creation/deletion
https://bugs.webkit.org/show_bug.cgi?id=20219

  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
17:42 Changeset [57788] by eric@webkit.org
  • 13 edits
    2 deletes in trunk/WebKitTools

2010-04-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove steps_references and commands_references
https://bugs.webkit.org/show_bug.cgi?id=37758

We tried using the mumble_references convention to manage our
dependencies, but it doesn't seem to be providing much value for the
steps and commands module because these modules are small pieces of the
larger tool module. In this patch, I've removed the references file
for these modules.

I've left the style_references file for the style module because that
module seems better isolated from the rest of webkitpy and the
style_references file appears to be providing some value.

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/commands_references.py: Removed.
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
  • Scripts/webkitpy/tool/steps_references.py: Removed.
13:43 Changeset [57787] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-04-17 Yaar Schnitman <yaar@chromium.org>

Reviewed by Adam Barth.

Auto-generate V8 bindings for canvas.* overloads
https://bugs.webkit.org/show_bug.cgi?id=37453

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Deleted custom code that is now auto-generated.
  • bindings/scripts/CodeGeneratorV8.pm: Not generating custom signatures for overloaded methods and accepting Object as a string input.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Added missing 9-arguments overloads for drawImage.
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl: Overloaded methods defined (V8 only).
13:10 Changeset [57786] by eric@webkit.org
  • 2 edits
    1 copy
    2 adds in trunk/LayoutTests

2010-04-17 Adam Barth <abarth@webkit.org>

Unreviewed.

Test file: URL canonicalization
https://bugs.webkit.org/show_bug.cgi?id=37700

Re-land http://trac.webkit.org/changeset/57719, hopefully not breaking
the Windows bot this time.

  • fast/url/file-expected.txt: Added.
  • fast/url/file.html: Added.
  • fast/url/mailto.html:
  • fast/url/script-tests/file.js: Added.
13:00 Changeset [57785] by eric@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-04-17 Adam Barth <abarth@webkit.org>

Unreviewed, but I took Jeremy Orlow's suggestions on an earlier
iteration of this patch.

Add URL parsing tests for relative URL resolution
https://bugs.webkit.org/show_bug.cgi?id=37644

I've split the platform specific parts of this test into separate
files. On KURL-based ports these should have the same results on every
platform. We can decide whether to have platform-specific behavior at
a later time.

  • fast/url/relative-expected.txt: Added.
  • fast/url/relative-unix-expected.txt: Added.
  • fast/url/relative-unix.html: Added.
  • fast/url/relative-win-expected.txt: Added.
  • fast/url/relative-win.html: Added.
  • fast/url/relative.html: Added.
  • fast/url/script-tests/relative-unix.js: Added.
  • fast/url/script-tests/relative-win.js: Added.
  • fast/url/script-tests/relative.js: Added.
11:42 Changeset [57784] by eric@webkit.org
  • 9 edits
    2 moves in trunk/WebCore

2010-04-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move JavaScriptCallFrame.{h,cpp} to WebCore/bindings/js

https://bugs.webkit.org/show_bug.cgi?id=37740

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JavaScriptCallFrame.cpp: Renamed from WebCore/inspector/JavaScriptCallFrame.cpp. (WebCore::JavaScriptCallFrame::JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::caller): (WebCore::JavaScriptCallFrame::scopeChain): (WebCore::JavaScriptCallFrame::dynamicGlobalObject): (WebCore::JavaScriptCallFrame::functionName): (WebCore::JavaScriptCallFrame::type): (WebCore::JavaScriptCallFrame::thisObject): (WebCore::JavaScriptCallFrame::evaluate):
  • bindings/js/JavaScriptCallFrame.h: Renamed from WebCore/inspector/JavaScriptCallFrame.h. (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::invalidate): (WebCore::JavaScriptCallFrame::isValid): (WebCore::JavaScriptCallFrame::sourceID): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::update):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorController.h:
09:00 Changeset [57783] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-17 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/audio-constructor-preload.html
https://bugs.webkit.org/show_bug.cgi?id=37753

  • platform/gtk/Skipped:
08:49 Changeset [57782] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-17 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping inspector/timeline-paint.html
https://bugs.webkit.org/show_bug.cgi?id=37752

  • platform/gtk/Skipped:
08:16 Changeset [57781] by alex@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-04-17 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

We have to initialize the timer attribute after destroying it, not
doing it was causing crashes in some situations.

  • webkit/webkitdownload.cpp: (webkit_download_finalize):
07:55 Changeset [57780] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-04-17 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding definition of GLES2Context class.
https://bugs.webkit.org/show_bug.cgi?id=37541

No new functionality implemented yet, no tests.

  • WebCore.gypi: Added GLES2Context.h
  • platform/chromium/GLES2Context.h: Added.

2010-04-17 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
https://bugs.webkit.org/show_bug.cgi?id=37541

  • WebKit.gyp:
  • public/WebGLES2Context.h: Added. (WebKit::WebGLES2Context::~WebGLES2Context):
  • src/GLES2Context.cpp: Added. (WebCore::GLES2ContextInternal::GLES2ContextInternal): (WebCore::GLES2ContextInternal::~GLES2ContextInternal): (WebCore::GLES2ContextInternal::getWebGLES2Context): (WebCore::GLES2ContextInternal::initialize): (WebCore::GLES2Context::create): (WebCore::GLES2Context::~GLES2Context): (WebCore::GLES2Context::initialize): (WebCore::GLES2Context::makeCurrent): (WebCore::GLES2Context::destroy): (WebCore::GLES2Context::swapBuffers):
06:37 Changeset [57779] by jchaffraix@webkit.org
  • 3 edits
    3 adds in trunk

Crash while handling SVG font in the wrong namespace imported with @font-face
https://bugs.webkit.org/show_bug.cgi?id=18862

Reviewed by Darin Adler.

WebCore:

Test: fast/invalid/invalidSVGFont.html

  • loader/CachedFont.cpp:

(WebCore::CachedFont::getSVGFontById): Make sure we really get an SVGFontElement by using
getElementsByNameNS: the element factory chooses which element to create based on both
localName and namespace.

LayoutTests:

Test that load an SVG document not in the SVG namespace with @font-face does not
lead to a crash.

  • fast/invalid/invalidSVGFont-expected.txt: Added.
  • fast/invalid/invalidSVGFont.html: Added.
  • fast/invalid/resources/svgFontWrongNamespace.svg: Added.
01:13 Changeset [57778] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WebKit needs a Chromium Mac EWS Builder
https://bugs.webkit.org/show_bug.cgi?id=37742

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
01:02 Changeset [57777] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-17 Adam Barth <abarth@webkit.org>

Fix expected results for unit test broken by
http://trac.webkit.org/changeset/57772

  • Scripts/webkitpy/common/net/buildbot_unittest.py:

04/16/10:

23:14 Changeset [57776] by ossy@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r57770.
http://trac.webkit.org/changeset/57770
https://bugs.webkit.org/show_bug.cgi?id=37746

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-04-16
8 test cases crashed (Requested by Ossy on #webkit).

WebCore:

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::AnimationQtBase::AnimationQtBase):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::OpacityAnimationQt::applyFrame):
(WebCore::GraphicsLayerQt::addAnimation):

LayoutTests:

  • platform/qt/Skipped:
21:40 Changeset [57775] by dbates@webkit.org
  • 11 edits
    2 adds in trunk/WebCore

2010-04-16 Daniel Bates <dbates@rim.com>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=36312

Adds support for the viewport meta tag. The code is largely derived in whole
or in part from the WebCore-528.15 source published as part of the iPhone 3.1.3
source code <http://www.opensource.apple.com/source/WebCore/WebCore-528.15/>.

  • Android.mk: Added file ViewportArguments.cpp.
  • GNUmakefile.am: Added files ViewportArguments.cpp and ViewportArguments.h.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::isSeparator): Added. (WebCore::Document::processArguments): Added. (WebCore::Document::processViewport): Added.
  • dom/Document.h:
  • dom/ViewportArguments.cpp: Added. (WebCore::setViewportFeature): (WebCore::viewportErrorMessageTemplate): (WebCore::viewportErrorMessageLevel): (WebCore::reportViewportWarning):
  • dom/ViewportArguments.h: Added. (WebCore::): (WebCore::ViewportArguments::): (WebCore::ViewportArguments::ViewportArguments): (WebCore::ViewportArguments::hasCustomArgument):
  • html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): Modified to call Document::processViewport.
  • page/ChromeClient.h: (WebCore::ChromeClient::didReceiveViewportArguments): Added.
20:23 Changeset [57774] by weinig@apple.com
  • 4 edits
    1 delete in trunk/WebKit2

Remove the need for a .defs file! Define WK_EXPORT.

Reviewed by Jon "The Belly" Honeycutt.

  • UIProcess/API/C/WKBase.h:
  • WebProcess/win/WebProcessMain.h:
  • win/WebKit2.def: Removed.
  • win/WebKit2.vcproj:
20:06 Changeset [57773] by weinig@apple.com
  • 8 edits in trunk

Teach windows MiniBrowser how to work with window.open()
and targeted links.

Reviewed by Adam Roben.

WebKit2:

Export WKPageSetPageUIClient.

  • win/WebKit2.def:

WebKitTools:

  • MiniBrowser/win/BrowserView.cpp:

(createNewPage): Create a new BrowserWindow and return its page.
(showPage): Show the page.
(closePage): Empty implementation.
(runJavaScriptAlert): Empty implementation.
(BrowserView::create): Register a UIClient.

  • MiniBrowser/win/BrowserView.h:

(BrowserView::webView): Added.
Change create to take a BrowserWindow instead of an HWND.

  • MiniBrowser/win/BrowserWindow.cpp:

(BrowserWindow::wndProc): Respond to WM_NCDESTROY.
(BrowserWindow::goToURL): Added. Forwards to BrowserView.
(BrowserWindow::onCreate): Don't always go to the default
url. Let the caller do this.
(BrowserWindow::onNCDestroy): Delete the window.

  • MiniBrowser/win/BrowserWindow.h:

(BrowserWindow::view): Added.
(BrowserWindow::window): Added.

  • MiniBrowser/win/main.cpp:

(_tWinMain):
Go to the default URL for the initial page. Allocate the initial
window on the heap for correctness.

19:53 Changeset [57772] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Add the Windows Debug (Test) builder to the list of core builders

It's been green for a few days now, and all the known Windows
flakiness is Release-only.

Rubber-stamped by Mark Rowe.

  • Scripts/webkitpy/common/net/buildbot.py:

(BuildBot.core_builder_name_regexps): Added a regular expression to
match the "Windows Debug (Test)" builder.

19:30 Changeset [57771] by dumi@chromium.org
  • 2 edits in trunk/WebKit/chromium

Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
https://bugs.webkit.org/show_bug.cgi?id=37733

Reviewed by Eric Seidel.

  • src/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

19:04 Changeset [57770] by eric@webkit.org
  • 4 edits in trunk

2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216

Remove LayoutTests/animations/fill-mode-transform.html from the skip list

  • platform/qt/Skipped:

2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216
Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
enables a key-frame animation to go to the animation's starting point before the delay,
and/or to stay at the animation's ending point after its ended, without reverting to the default
value.
We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQtBase::AnimationQtBase): (WebCore::TransformAnimationQt::~TransformAnimationQt): (WebCore::TransformAnimationQt::applyFrame): (WebCore::GraphicsLayerQt::addAnimation):
17:24 Changeset [57769] by barraclough@apple.com
  • 2 edits in trunk/WebCore
  • bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotification::addEventListener):
(WebCore::JSNotification::removeEventListener):

Reviewed by NOBODY (arm build fix).

17:20 Changeset [57768] by dumi@chromium.org
  • 4 edits in trunk/WebKit/chromium

Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
https://bugs.webkit.org/show_bug.cgi?id=34466

Reviewed by Jeremy Orlow.

Changing the return type of
WebSecurityOrigin::createFromDatabaseIdentifier() from
WebSecurityOrigin* to WebSecurityOrigin, to make it more
consistent with the other WebSecurityOrigin methods.

  • public/WebSecurityOrigin.h:
  • src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):

17:14 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
17:12 Changeset [57767] by dimich@chromium.org
  • 7 edits
    1 move
    1 add in trunk

WebCore: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror.
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Existing worker-close.html will now work in Chromium.

  • bindings/v8/V8Utilities.cpp:

(WebCore::getScriptExecutionContext): Stop using proxy() to just retrieve WorkerContext which should be always available.

  • bindings/v8/WorkerContextExecutionProxy.h: removed workerContext() accessor which moved to WorkerScriptController.
  • bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::workerContext): Added, to be able to pull WorkerContext out from the controller.

WebKit/chromium: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext.

LayoutTests: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Moved the expected result into platform-independent chromium subdirectory, since
the only chromium-specific difference is the way v8 formats an error message.
Also updated the expected result to match the passing now test.

  • platform/chromium-win/fast/workers/worker-close-expected.txt: Removed.
  • platform/chromium/fast/workers/worker-close-expected.txt: Added.
17:10 Changeset [57766] by barraclough@apple.com
  • 28 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=37735
Remove JSC specific code from WebCore::AtomicString

Reviewed by Sam Weinig.

Add generic constructor/add/find methods that take a UChar* & length, along
with a known existing hash for the string.
This removes the remaining JSC specific code from platform/text.

  • bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):
(WebCore::findAtomicString):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::childFrameGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSElementCustom.cpp:

(WebCore::JSElement::setAttribute):
(WebCore::JSElement::setAttributeNS):

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::canGetItemsForName):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):

  • bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

  • bindings/js/JSMimeTypeArrayCustom.cpp:

(WebCore::JSMimeTypeArray::canGetItemsForName):
(WebCore::JSMimeTypeArray::nameGetter):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):

  • bindings/js/JSPluginArrayCustom.cpp:

(WebCore::JSPluginArray::canGetItemsForName):
(WebCore::JSPluginArray::nameGetter):

  • bindings/js/JSPluginCustom.cpp:

(WebCore::JSPlugin::canGetItemsForName):
(WebCore::JSPlugin::nameGetter):

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore::JSPopStateEvent::initPopStateEvent):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::getResponseHeader):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

  • platform/text/AtomicString.h:

(WebCore::AtomicString::AtomicString):

16:58 Changeset [57765] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Fix typo from r55729

  • platform/win/Skipped:
16:51 Changeset [57764] by weinig@apple.com
  • 5 edits in trunk

Fix window.open() and targeted links.

Reviewed by Anders Carlsson.

WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveSyncMessage): Pass in the new pageID
instead of 0.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::createWebPage): Allow for the page to have already
been created, as is the case with programmatic window opening from within
WebCore (e.g. window.open() or <a target="_blank">).

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(_createNewPage): Use the correct initializer to and load the window.

16:45 Changeset [57763] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Fixing chromium build.

[chromium] Upstream test_expectations.txt changes from chromium.
Mark letter_spacing.html as consistently failing for mac.
Fixing a syntax error in the test_expectations.txt file.

  • platform/chromium/test_expectations.txt:
16:31 Changeset [57762] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Fixing chromiumg build.

[chromium] filterRes.svg is consistently failing now. Marking as such.

  • platform/chromium/test_expectations.txt:
16:23 Changeset [57761] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Don't optimize debug builds.

Reviewed by Mark Rowe.

  • WebKit2.xcodeproj/project.pbxproj: Define GCC_OPTIMIZATION_LEVEL correctly.
16:13 Changeset [57760] by ukai@chromium.org
  • 3 edits
    4 adds in trunk

2010-04-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket crash when it receives bad header.
https://bugs.webkit.org/show_bug.cgi?id=37682

  • websocket/tests/bad-handshake-crash-expected.txt: Added.
  • websocket/tests/bad-handshake-crash.html: Added.
  • websocket/tests/bad-handshake-crash_wsh.py: Added.
  • websocket/tests/script-tests/bad-handshake-crash.js: Added.

2010-04-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket crash when it receives bad header.
https://bugs.webkit.org/show_bug.cgi?id=37682

If name or value is not valid UTF-8, nameStr or valueStr would be
null string, so crashed in headers->add(nameStr, valueStr).
Check both nameStr and valueStr are not null string.
Otherwise handshake will fail.

Test: websocket/tests/bad-handshake-crash.html

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readHTTPHeaders): check nameStr and valueStr are not null string.
16:10 Changeset [57759] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/7873647> Crash when updating hover state

Reviewed by Simon Fraser.

WebCore:

Test: fast/dynamic/hover-style-recalc-crash.html

Updating the hover state of an element caused the document to need style
recalc, and then updating the hover state of a link caused style recalc,
which changed the render tree while updateHoverActiveState() was iterating
over it, leading to a crash.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateHoverActiveState): Collect the nodes to be
updated into vectors, then update their active and hover states.

LayoutTests:

  • fast/dynamic/hover-style-recalc-crash-expected.txt: Added.
  • fast/dynamic/hover-style-recalc-crash.html: Added.
16:07 Changeset [57758] by ajwong@chromium.org
  • 2 edits in trunk/WebKit/chromium

Not reviewed. Build fix.

[chromium] Compile fix. Missing include header, and missing type conversion.

  • src/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3DInternal::beginPaint):

15:42 Changeset [57757] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

15:31 Changeset [57756] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:
15:29 Changeset [57755] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, fixing Chromium test_expectations.txt due to removed tests in r57292.

  • platform/chromium/test_expectations.txt:
15:11 Changeset [57754] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Make Safari correctly allocate 5MB of DB storage to all new
origins.
https://bugs.webkit.org/show_bug.cgi?id=36671

Reviewed by Alexey Proskuryakov.

Eric fixed the same problem in
DatabaseTracker::fullPathForDatabaseNoLock() in r57128, but forgot
to fix it in DatabaseTracker::detailsForNameAndOrigin() too.

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::detailsForNameAndOrigin):

15:06 Changeset [57753] by scherkus@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-04-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in Chromium baselines for media/video-seek-past-end-playing.html.

  • platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Added.
  • platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:05 Changeset [57752] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:
14:57 Changeset [57751] by mrowe@apple.com
  • 4 edits in tags/Safari-533.5.2/WebKit/win

Merge r57615.

14:56 Changeset [57750] by mrowe@apple.com
  • 5 edits in tags/Safari-533.5.2

Versioning.

14:55 Changeset [57749] by kinuko@chromium.org
  • 9 edits
    3 adds in trunk/WebCore

2010-04-16 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Implement FileStreamProxy that calls FileStream methods on FileThread for FileAPI
https://bugs.webkit.org/show_bug.cgi?id=37218

No new tests; tests will be added when we add upper layer implementations.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/FileStream.cpp: (WebCore::FileStream::stop):
  • html/FileStream.h:
  • html/FileStreamClient.h: (WebCore::FileStreamClient::didStop):
  • html/FileStreamProxy.cpp: Added
  • html/FileStreamProxy.h: Added
  • html/FileThreadTask.h: Added
14:50 Changeset [57748] by barraclough@apple.com
  • 11 edits in trunk

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

JavaScriptCore:

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:

WebCore:

Remove ustring() method, and constructor passed a UString.

  • WebCore.base.exp:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::stringimplToUString):
(WebCore::jsStringSlowCase):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::identifierToString):

  • bindings/js/JSDOMBinding.h:

(WebCore::jsString):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::operator UString):

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::create):

  • platform/text/StringImpl.h:
14:39 Changeset [57747] by eric@webkit.org
  • 7 edits in trunk

2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL is not visible when QGLWidget viewport is used
https://bugs.webkit.org/show_bug.cgi?id=37070

Added HostWindow parameter to the constructor of GraphicsContext3D.
Shared OpenGL context is initialized with parent QGLWidget.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getOwnerGLWidget): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):

2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL is not visible when QGLWidget viewport is used
https://bugs.webkit.org/show_bug.cgi?id=37070

Added HostWindow parameter to the constructor of GraphicsContext3D.
Shared OpenGL context is initialized with parent QGLWidget.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
14:39 Changeset [57746] by mrowe@apple.com
  • 1 copy in tags/Safari-533.5.2

New tag.

14:27 Changeset [57745] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebKit compilation fails with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=37699

API for readPixels() has been changed.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::readPixels):
14:16 Changeset [57744] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt]QtLauncher crash on page with CSS 3D transform
https://bugs.webkit.org/show_bug.cgi?id=36859

Added a neccessary null-pointer check, lack of which created the crash circumstances.

Tested by http://css-vfx.googlecode.com/svn/trunk/snowstack/snowstack.html

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
14:14 Changeset [57743] by scherkus@chromium.org
  • 59 edits in trunk/LayoutTests

2010-04-16 Sergey Ulanov <sergeyu@chromium.org>

Unreviewed, checking in baselines due to changes to Chromium's video scaling algorithm.

  • platform/chromium-linux/media/controls-after-reload-expected.checksum:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.checksum:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-layer-crash-expected.checksum:
  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.checksum:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.checksum:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.checksum:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.checksum:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-layer-crash-expected.checksum:
  • platform/chromium-mac/media/video-layer-crash-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-transformed-expected.checksum:
  • platform/chromium-mac/media/video-transformed-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.checksum:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.checksum:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.checksum:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.checksum:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.checksum:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.checksum:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-transformed-expected.checksum:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.checksum:
  • platform/chromium-win/media/video-volume-slider-expected.png:
14:08 Changeset [57742] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Fix links to layout test results from build status pages

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ExtractTestResults.finished): Prepend "/" on the URL of the test
results page so that it is treated as an absolute URL.

13:52 Changeset [57741] by andersca@apple.com
  • 2 edits in trunk/WebCore

Make sure to update the current graphics context when calling out to AppKit.

Reviewed by Sam Weinig.

  • platform/mac/ThemeMac.mm:

(WebCore::paintCheckbox):
(WebCore::paintRadio):

13:34 Changeset [57740] by barraclough@apple.com
  • 3 edits in trunk/WebKit/win
  • WebFrame.cpp:

(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):

  • WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix).

13:26 Changeset [57739] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Fix windows build.

Reviewed by Sam Weinig.

  • Platform/win/RunLoopWin.cpp:

(RunLoop::run):

  • UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::webThreadBody):
(WebKit::launchWebProcess):

  • WebProcess/win/WebProcessMain.cpp:

(WebKit::WebProcessMain):

13:21 Changeset [57738] by barraclough@apple.com
  • 73 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=37675
Remove casts/constructors to/from JSC::UString type from WebCore::String

Reviewed by Sam Weinig & Oliver Hunt.

WebCore's strings should not know about JSC::UString, this should be abstracted
away in the bindings. Add explicit conversion methods rather than relying on
overloaded cast operators / constructors being implicitly called.

This patch only changes the class String, once this has landed StringImpl, and
hopefully AtomicString too, should follow suit.

WebCore:

This patch adds:

WebCore::identifierToString
WebCore::ustringToString
WebCore::stringToUString

  • to JSDOMBindings.h, and updates code to call these methods.
  • WebCore.base.exp:
  • WebCore.order:
  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

  • bindings/js/JSAudioConstructor.cpp:

(WebCore::constructAudio):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::nameGetter):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
(WebCore::JSCanvasRenderingContext2D::setShadow):
(WebCore::JSCanvasRenderingContext2D::fillText):
(WebCore::JSCanvasRenderingContext2D::strokeText):

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):
(WebCore::JSClipboard::clearData):
(WebCore::JSClipboard::getData):
(WebCore::JSClipboard::setData):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::identifierToString):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::valueToStringWithNullCheck):
(WebCore::valueToStringWithUndefinedOrNullCheck):
(WebCore::reportException):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::JSDOMFormData::append):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::setLocation):
(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSEventSourceConstructor.cpp:

(WebCore::constructEventSource):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::documentWrite):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::createInjectedScript):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::assign):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):

  • bindings/js/JSOptionConstructor.cpp:

(WebCore::constructHTMLOptionElement):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/js/JSSharedWorkerConstructor.cpp:

(WebCore::constructSharedWorker):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):
(WebCore::JSStorage::putDelegate):

  • bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::canGetItemsForName):
(WebCore::JSStyleSheetList::nameGetter):

  • bindings/js/JSWebKitCSSMatrixConstructor.cpp:

(WebCore::constructWebKitCSSMatrix):

  • bindings/js/JSWebSocketConstructor.cpp:

(WebCore::constructWebSocket):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/js/JSWorkerConstructor.cpp:

(WebCore::constructWorker):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::importScripts):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):
(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::overrideMimeType):

  • bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • bindings/js/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::ScriptCallFrame):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):
(WebCore::ScriptDebugServer::sourceParsed):

  • bindings/js/ScriptEventListener.cpp:

(WebCore::getEventListenerHandlerBody):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):

  • bindings/js/ScriptObject.cpp:

(WebCore::ScriptObject::set):

  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):

  • bindings/js/ScriptString.h:

(WebCore::ScriptString::operator String):
(WebCore::ScriptString::ustring):
(WebCore::ScriptString::operator+=):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::getString):

  • bindings/js/ScriptValue.h:

(WebCore::ScriptValue::toString):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedObject::set):
(WebCore::SerializingTreeWalker::convertIfTerminal):
(WebCore::DeserializingTreeWalker::putProperty):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::StringSourceProvider):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::identifierFromNPIdentifier):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::scriptImported):
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::createProfileHeader):

  • inspector/InspectorResource.cpp:

(WebCore::InspectorResource::sourceString):

  • inspector/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::functionName):

  • platform/KURL.h:

(WebCore::KURL::operator const String&):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::operator UString):

  • platform/text/AtomicString.h:
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:

WebKit/mac:

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(identifierFromIdentifierRep):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray):
(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::getPropertyNames):

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame evaluateWebScript:]):

  • WebView/WebScriptDebugger.mm:

(toNSURL):

  • WebView/WebView.mm:

(aeDescFromJSValue):

13:15 Changeset [57737] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Make resizing responsive on Windows.

Reviewed by Anders Carlsson.

  • Use the same waitFor logic as do for the Mac resizing DrawingAreaUpdateChunk code.
  • Shared/win/UpdateChunk.cpp:

(WebKit::UpdateChunk::UpdateChunk):

  • Shared/win/UpdateChunk.h: Add a constructor that only takes an IntRect and allocates the shared memory mapping for you.
  • UIProcess/win/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::ensureBackingStore):
(WebKit::DrawingAreaProxy::paint):
(WebKit::DrawingAreaProxy::drawUpdateChunkIntoBackingStore):
(WebKit::DrawingAreaProxy::setSize):
(WebKit::DrawingAreaProxy::didSetSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):

  • UIProcess/win/DrawingAreaProxy.h:

Perform wait in paint as we do on the mac.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onSizeEvent):
Change to use an IntSize.

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):
(WebKit::DrawingAreaUpdateChunk::display):
(WebKit::DrawingAreaUpdateChunk::setSize):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.h:

Specialize setSize() drawing and factor out painting
into a helper function.

13:13 Changeset [57736] by ajwong@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-mac and chromium-win
also since this test there as well.

  • platform/chromium-mac/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
  • platform/chromium-mac/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
  • platform/chromium-mac/fast/url/standard-url-expected.txt:
  • platform/chromium-win/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
  • platform/chromium-win/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
  • platform/chromium-win/fast/url/standard-url-expected.txt:
13:05 Changeset [57735] by ajwong@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-linux since this test
fully passes on this platform.

  • platform/chromium-linux/fast/url/host-expected.txt: Added.
  • platform/chromium-linux/fast/url/path-expected.txt: Added.
  • platform/chromium-linux/fast/url/standard-url-expected.txt: Added.
12:58 Changeset [57734] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Always pass a view to the AppKit drawing functions.
https://bugs.webkit.org/show_bug.cgi?id=37724

  • platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
12:45 Changeset [57733] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=37718
Safari crashes with certain JavaScript charCode events in EventHandler::needsKeyboardEventDisambiguationQuirks

Test: fast/events/recorded-keydown-event.html

  • dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::charCode): Check if the view (window) is frameless.
12:36 Changeset [57732] by andersca@apple.com
  • 8 edits in trunk/WebKit2

2010-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Make run loops be allocated as thread specific data.
https://bugs.webkit.org/show_bug.cgi?id=37723

  • Platform/RunLoop.cpp: (RunLoop::initializeMainRunLoop): (RunLoop::current): (RunLoop::main):
  • Platform/RunLoop.h:
  • Platform/mac/RunLoopMac.mm: (RunLoop::run): (RunLoop::stop):
  • UIProcess/Launcher/mac/WebProcessLauncher.mm: (WebKit::webThreadBody): (WebKit::launchWebProcess):
  • UIProcess/ResponsivenessTimer.cpp: (WebKit::ResponsivenessTimer::ResponsivenessTimer):
  • WebProcess/Launching/mac/WebProcessMain.mm: (main):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::isSeparateProcess):
11:52 Changeset [57731] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip HTMLFrameSetElement-window-eventListener-attributes.html on SnowLeopard

It is crashing sometimes. <http://webkit.org/b/37720> tracks investigating this.

Rubber-stamped by Sam Weinig.

  • platform/mac-snowleopard/Skipped:
11:40 Changeset [57730] by aroben@apple.com
  • 3 edits in trunk/WebKit/win

Make it possible for clients to instantiate a WebUserContentURLPattern

Reviewed by Tim Hatcher.

  • ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which

lists all our instantiatable classes.

  • WebKitClassFactory.cpp: Added a now-required #include.
11:19 Changeset [57729] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

SKip xss-DENIED-mime-type-execute-as-html.html to see if it makes the http test stop timing out on Windows

<http://webkit.org/b/37714> tracks this investigation.

Rubber-stamped by Sam Weinig.

  • platform/win/Skipped:
11:19 Changeset [57728] by ukai@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Jian Li.

[chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
https://bugs.webkit.org/show_bug.cgi?id=37687

  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.
11:07 Changeset [57727] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-04-16 Jian Li <jianli@chromium.org>

Reviewed by Dmitry Titov.

Update FormDataList to fix style violations in old code.
https://bugs.webkit.org/show_bug.cgi?id=37689

  • html/FormDataList.h: (WebCore::FormDataList::appendData): (WebCore::FormDataList::appendBlob):
11:00 Changeset [57726] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Update FormDataList to fix style violations in old code.
https://bugs.webkit.org/show_bug.cgi?id=37689

Reviewed by Dmitry Titov.

  • html/FormDataList.h:

(WebCore::FormDataList::appendData):
(WebCore::FormDataList::appendBlob):

10:59 Changeset [57725] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix WebKit2 build.

  • WebCore.base.exp:
10:18 Changeset [57724] by eric@webkit.org
  • 6 edits
    1 add in trunk

2010-04-16 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
https://bugs.webkit.org/show_bug.cgi?id=37436

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
  • platform/chromium/PopupMenuChromium.h:

2010-04-16 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
Also adding unit-tests for the select popup code.
https://bugs.webkit.org/show_bug.cgi?id=37436

  • WebKit.gyp:
  • src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup):
  • tests/PopupMenuTest.cpp: Added.
10:09 Changeset [57723] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Expose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.

Reviewed by John Sullivan.

  • WebView/WebHTMLView.mm:

Replaced two macros with constants.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Changed to use the constants.
(-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.

  • WebView/WebHTMLViewPrivate.h: Declared _WebHTMLViewPrintingMinimumShrinkFactor and

_WebHTMLViewPrintingMaximumShrinkFactor.

09:18 Changeset [57722] by eric@webkit.org
  • 9 edits
    3 deletes in trunk/LayoutTests

2010-04-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57719.
http://trac.webkit.org/changeset/57719
https://bugs.webkit.org/show_bug.cgi?id=37708

Broke 8 URL tests on Windows due to use of file:///tmp/ URLs,
which don't work on Windows. (Requested by aroben on #webkit).

  • fast/url/anchor.html:
  • fast/url/file-expected.txt: Removed.
  • fast/url/file.html: Removed.
  • fast/url/ipv4.html:
  • fast/url/path-url.html:
  • fast/url/port.html:
  • fast/url/query.html:
  • fast/url/script-tests/TEMPLATE.html:
  • fast/url/script-tests/file.js: Removed.
  • fast/url/standard-url.html:
  • fast/url/trivial.html:
07:11 Changeset [57721] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 Antonio Gomes <tonikitoo@webkit.org>

Unreviewed QtWebKit (with Qt 4.7) build fix.

Bug 37683 moved code from FontQt.cpp to FontPlatformDataQt.cpp but did not
renamed the variable used.

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
01:06 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
00:36 Changeset [57720] by eric@webkit.org
  • 5 edits in trunk

2010-04-16 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] build DRT on Linux
https://bugs.webkit.org/show_bug.cgi?id=37690

  • DEPS: Need to roll deps to remove a dependency on src/chrome
  • gyp_webkit: generate makefiles for DRT.gyp on Linux

2010-04-16 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] build DRT on Linux
https://bugs.webkit.org/show_bug.cgi?id=37690

  • Scripts/build-dumprendertree: Add support for win and linux
00:27 Changeset [57719] by mjs@apple.com
  • 9 edits
    3 adds in trunk/LayoutTests

2010-04-16 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Test file: URL canonicalization
https://bugs.webkit.org/show_bug.cgi?id=37700

  • fast/url/script-tests/file.js: Added new test.
  • fast/url/file-expected.txt: Added (expected results).
  • fast/url/file.html: Added (wrapper).
  • fast/url/script-tests/TEMPLATE.html: Add an explicit dependable <base> URL to the template, to avoid making test expectations system dependent.


Other test wrappers regenerated for the above change:

  • fast/url/anchor.html:
  • fast/url/ipv4.html:
  • fast/url/path-url.html:
  • fast/url/port.html:
  • fast/url/query.html:
  • fast/url/standard-url.html:
  • fast/url/trivial.html:
00:25 Changeset [57718] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-16 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Make GraphicsLayerQt always use ItemCoordinateCache, and remove ItemUsesExtendedStyleOption.
This aligns our implementation with the Safari implementation - layers are always uploaded
to textures in item units, and WebCore is responsible for the heuristics.

[Qt] GraphicsLayer: performance optimizations
https://bugs.webkit.org/show_bug.cgi?id=35393

No new tests. Still no FPS benchmarks available (on any platform)
but animations are noticably better.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::TransformAnimationQt::updateState):
00:20 QtWebKitRelease20 edited by henry.haverinen@nokia.com
(diff)
00:19 QtWebKit edited by henry.haverinen@nokia.com
(diff)
00:14 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
00:14 Changeset [57717] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-16 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebCore::Font::font() causes a QFont detach
https://bugs.webkit.org/show_bug.cgi?id=37683

Moved the setStyleStrategy call to FontPlatformData
to avoid the detach.

Thanks to Holger for spotting this.

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::font):
00:13 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
00:10 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
00:03 Changeset [57716] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-04-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35915

  • efl/WebCoreSupport/FrameLoaderClientEfl.cpp: Added.
  • efl/WebCoreSupport/FrameLoaderClientEfl.h: Added.

04/15/10:

23:20 Changeset [57715] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-15 Matt Perry <mpcomplete@chromium.org>

Reviewed by Adam Barth.

Remove the check for the main frame's scheme when deciding which
v8 extensions to add to a script context. Instead, Chromium will
handle that check elsewhere to allow finer-grained control over
what APIs we expose to web pages.
https://bugs.webkit.org/show_bug.cgi?id=37681

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
22:59 Changeset [57714] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-04-15 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

No default selection for <select multiple> menu lists.
https://bugs.webkit.org/show_bug.cgi?id=37530

Manual test: manual-tests/no-listbox-rendering.html

For menu lists, if the selection is not indicated by the html file, the first <option> will be
selected after loading the page or reseting the form. On the other hand listboxes may have no
element selected after loading the page or reseting the form.

When NO_LISTBOX_RENDERING is enabled listboxes becomes menu lists. Those <select multiple>
that did not have selected elements, now being menu lists, will have the first <option>
selected. That is the behavior difference that this patch corrects.

When NO_LISTBOX_RENDERING is enabled usesMenuList() always returns true then usesMenuList() cannot
be used to decide about initial selection of the elements. This patch replaces (usesMenuLists())
by (!multiple && size <= 1) where initial selection is considered.

  • dom/SelectElement.cpp: (WebCore::SelectElement::recalcListItems): (WebCore::SelectElement::reset):
  • manual-tests/no-listbox-rendering.html: Added.
22:36 Changeset [57713] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-15 Tony Chang <tony@chromium.org>

Not reviewed, trying to make the tree green.

[qt] fast/url/hosts.html is failing, skip until someone can
investigate.
https://bugs.webkit.org/show_bug.cgi?id=37697

  • platform/qt/Skipped:
19:50 Changeset [57712] by eric@webkit.org
  • 9 edits in trunk/LayoutTests

2010-04-15 Adam Barth <abarth@webkit.org>

Reviewed by Jeremy Orlow.

Clean up unicode URL tests cases
https://bugs.webkit.org/show_bug.cgi?id=37678

When we started writing these URL tests, I didn't understand how to
handle the unicodes test cases properly. With a bunch of help (and a
pointer to http://rishida.net/tools/conversion/), I've fixed these to
be more or less faithful to the original unit tests.

  • fast/url/anchor-expected.txt:
  • fast/url/query-expected.txt:
  • fast/url/script-tests/anchor.js:
  • fast/url/script-tests/query.js:
  • fast/url/script-tests/standard-url.js:
  • fast/url/script-tests/trivial.js:
    • Updated this test to use the shared implementations
    • Also, removed assumptions about the base URL.
  • fast/url/standard-url-expected.txt:
  • fast/url/trivial-expected.txt:
19:38 Changeset [57711] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-15 Adam Barth <abarth@webkit.org>

Reviewed by Jeremy Orlow.

Add URL parsing tests for host names
https://bugs.webkit.org/show_bug.cgi?id=37666

  • fast/url/host-expected.txt: Added.
  • fast/url/host.html: Added.
  • fast/url/script-tests/host.js: Added.
19:27 Changeset [57710] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-15 Adam Barth <abarth@webkit.org>

Reviewed by Jeremy Orlow.

Add URL parsing tests for paths
https://bugs.webkit.org/show_bug.cgi?id=37672

  • fast/url/path-expected.txt: Added.
  • fast/url/path.html: Added.
  • fast/url/script-tests/path.js: Added.
19:01 Changeset [57709] by eric@webkit.org
  • 7 edits in trunk

2010-04-15 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Index validation code validates too many vertex attributes
https://bugs.webkit.org/show_bug.cgi?id=31892

  • fast/canvas/webgl/index-validation-expected.txt: Add new test cases for index validations.
  • fast/canvas/webgl/script-tests/index-validation.js: Ditto.

2010-04-15 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Index validation code validates too many vertex attributes
https://bugs.webkit.org/show_bug.cgi?id=31892

  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::cacheActiveAttribLocations): Cache active attribute locations for a program at linkProgram time. (WebCore::WebGLProgram::getActiveAttribLocation): Get the cached attribute location. (WebCore::WebGLProgram::numActiveAttribLocations): Get the number of cached attribute locations.
  • html/canvas/WebGLProgram.h: Add attribute locations member.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateRenderingState): Add logic not to validate those attributes that do not belong to the current program. (WebCore::WebGLRenderingContext::linkProgram): Call cacheActiveAttribLocations().
18:38 Changeset [57708] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Mark send-form-data-with-sliced-file.html as failed on Chromium Linux.

  • platform/chromium/test_expectations.txt:
18:34 Changeset [57707] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Use GDI text rendering on Windows by default.

Reviewed by Adam Roben.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformInitialize): Use the AlternateRenderingMode
setting.

18:24 Changeset [57706] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Use the threaded process model for MiniBrowser if holding down
the shift key on startup.

Reviewed by Adam Roben.

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

18:20 Changeset [57705] by weinig@apple.com
  • 2 edits in trunk/WebCore

Don't assert when soft-linked libraries can't be found

Patch by Adam Roben <aroben@apple.com> on 2010-04-16
In some situations (e.g., when using SOFT_LINK_OPTIONAL), we expect soft-link libraries not
to be able to be found in all cases. So we shouldn't assert that they're always found.

Reviewed by Sam Weinig.

  • platform/win/SoftLinking.h:

(SOFT_LINK): Don't assert when LoadLibrary fails.

18:17 Changeset [57704] by dimich@chromium.org
  • 15 edits
    8 deletes in trunk

2010-04-15 Dmitry Titov <dimich@chromium.org>

Unreviewed, rolling out r57688.
http://trac.webkit.org/changeset/57688
https://bugs.webkit.org/show_bug.cgi?id=34992

Makes fast/workers/dedicated-worker-lifecycle.html crashing on all GTK bots

  • fast/workers/change-version-handle-reuse-worker-expected.txt: Removed.
  • fast/workers/change-version-handle-reuse-worker.html: Removed.
  • fast/workers/execute-sql-args-worker-expected.txt: Removed.
  • fast/workers/execute-sql-args-worker.html: Removed.
  • fast/workers/resources/database-worker-controller.js: Removed.
  • fast/workers/resources/database-worker.js: Removed.
  • storage/change-version-handle-reuse-expected.txt:
  • storage/change-version-handle-reuse.html:
  • storage/change-version-handle-reuse.js: Removed.
  • storage/execute-sql-args.html:
  • storage/execute-sql-args.js: Removed.

2010-04-15 Dmitry Titov <dimich@chromium.org>

Unreviewed, rolling out r57688.
http://trac.webkit.org/changeset/57688
https://bugs.webkit.org/show_bug.cgi?id=34992

Makes fast/workers/dedicated-worker-lifecycle.html crashing on all GTK bots

  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • storage/Database.idl:
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::openDatabase):
  • workers/WorkerContext.h: (WebCore::WorkerContext::databaseExceededQuota):
  • workers/WorkerContext.idl:
18:16 Changeset [57703] by tony@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-04-15 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Add TestShellGtk.cpp so we can link on Linux
https://bugs.webkit.org/show_bug.cgi?id=37561

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and

add platform file exceptions.

  • DumpRenderTree/chromium/TestShellGtk.cpp: Added. (AlarmHandler): (TestShell::waitTestFinished):
18:13 Changeset [57702] by tony@chromium.org
  • 5 edits in trunk

2010-04-15 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

build DRT on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=37639

  • gyp_webkit: generate build files for DRT on mac

2010-04-15 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

build DRT on chromium mac
https://bugs.webkit.org/show_bug.cgi?id=37639

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • Scripts/build-dumprendertree: enable build-dumprendertree --chromium
18:08 Changeset [57701] by yurys@chromium.org
  • 18 edits
    1 add in trunk

2010-04-15 Yury Semikhatsky <yurys@google.com>

Reviewed by Pavel Feldman.


Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

https://bugs.webkit.org/show_bug.cgi?id=37604

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::setDebuggerScriptSource): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setBreakpointsActivated): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::currentCallFrameV8): (WebCore::ScriptDebugServer::onV8DebugMessage): (WebCore::ScriptDebugServer::onV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugMessage): (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled): (WebCore::ScriptDebugServer::didResume):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::setMessageLoopDispatchHandler):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):

2010-04-15 Yury Semikhatsky <yurys@google.com>

Reviewed by Pavel Feldman.

Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

https://bugs.webkit.org/show_bug.cgi?id=37604

  • WebKit.gypi:
  • src/DebuggerAgent.h:
  • src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::hostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
  • src/DebuggerAgentManager.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
  • src/js/DebuggerScript.js: Added. (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript): (debuggerScriptConstructor.DebuggerScript.getScripts): (debuggerScriptConstructor.DebuggerScript._formatScript): (debuggerScriptConstructor.DebuggerScript.setBreakpoint): (debuggerScriptConstructor.DebuggerScript.removeBreakpoint): (debuggerScriptConstructor.DebuggerScript.currentCallFrame): (debuggerScriptConstructor.DebuggerScript.stepIntoStatement): (debuggerScriptConstructor.DebuggerScript.stepOverStatement): (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction): (debuggerScriptConstructor.DebuggerScript.clearBreakpoints): (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated): (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame): (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber): (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber): (debuggerScriptConstructor):
  • src/js/DevTools.js: (WebInspector.loaded): (.): ():
  • src/js/DevToolsHostStub.js: (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
18:00 Changeset [57700] by mrowe@apple.com
  • 2 edits in tags/Safari-533.5.1/WebKit/mac

Merge r57692.

18:00 Changeset [57699] by eric@webkit.org
  • 7 edits in trunk/WebKit/chromium

2010-04-15 Matt Perry <mpcomplete@chromium.org>

Reviewed by Dimitri Glazkov.

Implement layoutTestController's addUserStyleSheet and
setAuthorAndUserStylesEnabled on Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=37595

  • public/WebSettings.h:
  • public/WebView.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAuthorAndUserStylesEnabled):
  • src/WebSettingsImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::addUserStyleSheet):
  • src/WebViewImpl.h:
17:58 Changeset [57698] by mrowe@apple.com
  • 5 edits in tags/Safari-533.5.1

Versioning.

17:58 Changeset [57697] by jianli@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed.

Updated Skipped list to use the right directory due to directory
shuffling at r57695.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
17:54 Changeset [57696] by ajwong@chromium.org
  • 5 edits in trunk/LayoutTests

Not reviewed. Sheriffing.

[Chromium] Build fix. Rebaseline these again since the fonts changed again.

  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png:
17:50 Changeset [57695] by jianli@chromium.org
  • 12 edits
    2 moves
    9 adds
    1 delete in trunk

Support using FormData to send a sliced file via XHR.
https://bugs.webkit.org/show_bug.cgi?id=36678

Reviewed by Dmitry Titov.

WebCore:

Tests: http/tests/local/formdata/send-form-data-with-sliced-file.html

  • html/Blob.h:

(WebCore::Blob::isFile):

  • html/DOMFormData.cpp:

(WebCore::DOMFormData::append):

  • html/File.h:

(WebCore::File::isFile):

  • html/FormDataList.h:

(WebCore::FormDataList::appendBlob):
(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::blob):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::appendFormData):

  • platform/network/FormData.cpp:

(WebCore::FormData::appendDOMFormData):

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::closeCurrentStream):

LayoutTests:

Move common functionality to test sending FormData into a helper file
so that it can be shared by FormData layout tests.
Also move the form data testing files to a new subdirectory formdata/.

  • http/tests/local/formdata/resources/send-form-data-common.js: Added.
  • http/tests/local/formdata/script-tests/TEMPLATE.html: Added.
  • http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js: Added.
  • http/tests/local/formdata/script-tests/send-form-data.js: Added.
  • http/tests/local/formdata/send-form-data-expected.txt: Renamed from LayoutTests/http/tests/local/send-form-data-expected.txt.
  • http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Added.
  • http/tests/local/formdata/send-form-data-with-sliced-file.html: Added.
  • http/tests/local/formdata/send-form-data.html: Added.
  • http/tests/local/resources/send-form-data.js: Removed.
  • http/tests/local/send-form-data.html: Removed.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
17:43 Changeset [57694] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-04-15 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
https://bugs.webkit.org/show_bug.cgi?id=37178

  • fast/canvas/webgl/point-size-expected.txt: Added.
  • fast/canvas/webgl/point-size.html: Added.

2010-04-15 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
https://bugs.webkit.org/show_bug.cgi?id=37178

Test: fast/canvas/webgl/point-size.html

  • platform/graphics/mac/GraphicsContext3DMac.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization. (WebCore::GraphicsContext3D::GraphicsContext3D):

2010-04-15 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
https://bugs.webkit.org/show_bug.cgi?id=37178

  • src/WebGraphicsContext3DDefaultImpl.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization. (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
17:42 Changeset [57693] by mrowe@apple.com
  • 1 copy in tags/Safari-533.5.1

New tag.

17:40 Changeset [57692] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7870651> WebDynamicScrollBarsView.h generates compile errors when included in plain Objective-C files.

Reviewed by Sam Weinig.

  • WebView/WebDynamicScrollBarsView.h:
17:36 Changeset [57691] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix crash when trying to load an invalid URL.

Reviewed by Adam Roben.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURL): Use constructor for ResourceRequest
that takes a KURL instead of the one that takes a String. The one
that takes a string expects a valid URL.

17:31 Changeset [57690] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-04-15 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add LayoutTestHelper for Mac
https://bugs.webkit.org/show_bug.cgi?id=37668

LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm
of Chromium.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/LayoutTestHelper.mm: Added.
17:22 Changeset [57689] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Make tooltips work. Thanks Adam!

Reviewed by Adam Roben.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::toolTipChanged): Pass the WebView's HWND, not the tooltip's.

17:10 Changeset [57688] by eric@webkit.org
  • 15 edits
    3 copies
    5 adds in trunk

2010-04-15 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
https://bugs.webkit.org/show_bug.cgi?id=34992

  • storage/change-version-handle-reuse.html: Refactored to share code with the worker version of the test.
  • storage/change-version-handle-reuse-expected.html: Removed reference to reloading, which this test doesn't do.
  • storage/change-version-handle-reuse.js: This is the extracted shared core of the test.
  • storage/execute-sql-args.html: Refactored to share code with the worker version of the test.
  • storage/execute-sql-args.js: This is the extracted shared core of the test.

These are the worker versions of the tests; they're tiny shims around shared code.

  • fast/workers/execute-sql-args-worker-expected.txt: Added.
  • fast/workers/execute-sql-args-worker.html: Added.
  • fast/workers/change-version-handle-reuse-worker-expected.txt: Added.
  • fast/workers/change-version-handle-reuse-worker.html: Added. This file gets included from worker database tests; it does all the boilerplate that's needed on the DOM side.
  • fast/workers/resources/database-worker-controller.js: Added. This file is the boilerplate for the worker side of the database tests. It will import and run the actual test on command, and will report back completion and exceptions.
  • fast/workers/resources/database-worker.js: Added.

2010-04-15 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
https://bugs.webkit.org/show_bug.cgi?id=34992

Tests: storage/change-version-handle-reuse-worker.html

storage/execute-sql-args-worker.html

  • bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding. (WebCore::JSWorkerContext::openDatabase):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there. (WebCore::V8WorkerContext::openDatabaseCallback):

Add NoStaticTables flags to all objects now shared with workers.

  • storage/Database.idl:
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • workers/WorkerContext.h: Add databaseExceededQuota.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now. (WebCore::WorkerContext::openDatabase): Remove invalid assertion.

Add the IDL for the call to openDatabase.

  • workers/WorkerContext.idl:
16:58 Changeset [57687] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-15 Nicolas Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

Fix drag image thumbnails for indexed images.
https://bugs.webkit.org/show_bug.cgi?id=37621

  • platform/chromium/DragImageChromiumMac.cpp: (WebCore::scaleDragImage): Always use RGB color space. (WebCore::dissolveDragImageToFraction): Always use RGB color space.
16:56 Changeset [57686] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build dependencies.

Reviewed by Adam Roben.

  • WebKit2.sln:
16:52 Changeset [57685] by ap@apple.com
  • 5 edits
    1 delete in trunk

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=37494
<rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html
fails on Windows

  • DumpRenderTree/win/EventSender.cpp: (makeEventSender):
  • DumpRenderTree/win/EventSender.h: Tell EventSender if it's being created for a top frame.


  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset EventSender machinery when a new test is loaded, not when an iframe (or just its global object) is created.
16:51 Changeset [57684] by weinig@apple.com
  • 5 edits in trunk

Fix Windows WebKit2 build.

WebKit2:

Patch by Adam Roben <aroben@apple.com> on 2010-04-15

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidExit):

  • win/WebKit2Generated.make:

WebKitTools:

Patch by Adam Roben <aroben@apple.com> on 2010-04-15

  • MiniBrowser/win/MiniBrowser.cpp:
16:37 WebKit Team edited by joepeck@webkit.org
Italics look like quotes in WikiFormatting. But its Magic Quotes. (diff)
16:34 WebKit Team edited by joepeck@webkit.org
Moving up in the world ;) (diff)
15:53 Changeset [57683] by aroben@apple.com
  • 2 edits in trunk/WebKit/mac

Export WebUserContentURLPattern from WebKit

Rubber-stamped by Mark Rowe.

  • WebKit.exp:
15:33 Changeset [57682] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Made consecutive calls to -[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:] work
without intermediate calls -[WebHTMLView _endPrintMode].

Reviewed by Simon Fraser.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):

15:30 Changeset [57681] by cfleizach@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed.

Layout test fix for new test that works differently on leopard v. snow leopard.

AXHelp is being appended from ancestors incorrectly
https://bugs.webkit.org/show_bug.cgi?id=37659

  • platform/mac/accessibility/unexpected-help-text-expected.txt:
  • platform/mac/accessibility/unexpected-help-text.html:
15:19 Changeset [57680] by aroben@apple.com
  • 11 edits
    5 adds in trunk

Expose UserContentURLPattern as WebKit SPI

Fixes <http://webkit.org/b/37354>.

Reviewed by Tim Hatcher.

WebCore:

  • WebCore.base.exp: Export UserContentURLPattern::parse, and sorted

the file.

  • WebCore.xcodeproj/project.pbxproj: Marked UserContentURLPattern.h as

"Private".

  • page/UserContentURLPattern.h:

(WebCore::UserContentURLPattern::UserContentURLPattern): Added a
default constructor.
(WebCore::UserContentURLPattern::isValid): Added this getter.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Add WebUserContentURLPattern.

WebKit/mac:

  • Misc/WebUserContentURLPattern.h: Added.
  • Misc/WebUserContentURLPattern.mm: Added.

(-[WebUserContentURLPattern initWithPatternString:]): Initialize
_private and then parse the passed-in string into a
UserContentURLPattern.
(-[WebUserContentURLPattern dealloc]): Release _private.

(-[WebUserContentURLPattern isValid]):
(-[WebUserContentURLPattern scheme]):
(-[WebUserContentURLPattern host]):
(-[WebUserContentURLPattern matchesSubdomains]):
Call through to UserContentURLPattern.

WebKit/win:

  • Interfaces/IWebUserContentURLPattern.idl: Added.
  • Interfaces/WebKit.idl: Added WebUserContentURLPattern.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebUserContentURLPattern.
  • WebKit.vcproj/WebKit.vcproj: Added WebUserContentURLPattern.
  • WebUserContentURLPattern.cpp: Added.

(WebUserContentURLPattern::WebUserContentURLPattern):
(WebUserContentURLPattern::~WebUserContentURLPattern):
(WebUserContentURLPattern::createInstance):
(WebUserContentURLPattern::AddRef):
(WebUserContentURLPattern::Release):
(WebUserContentURLPattern::QueryInterface):
Standard COM implementations.

(WebUserContentURLPattern::parse): Parse the string into a
UserContentURLPattern and store it.

(WebUserContentURLPattern::isValid):
(WebUserContentURLPattern::scheme):
(WebUserContentURLPattern::host):
(WebUserContentURLPattern::matchesSubdomains):
Call through to UserContentURLPattern.

  • WebUserContentURLPattern.h: Added.
15:18 Changeset [57679] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

Include codereview issue number in patch description
https://bugs.webkit.org/show_bug.cgi?id=37677

This lets us know which rietveld issue this patch is tied to.

Also, make it so that --fancy-review overrides --no-review.

  • Scripts/webkitpy/tool/steps/postcodereview.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
15:11 Changeset [57678] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Make --exit-after-n-failures work when all tests are timing out or crashing

Fixes <http://webkit.org/b/37679>.

Reviewed by Jon Honeycutt.

  • Scripts/run-webkit-tests:

(top level): When a test crashes or times out, break out of the main loop if
stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop
from here...
(stopRunningTestsEarlyIfNeeded): ...to here.

14:50 Changeset [57677] by ajwong@chromium.org
  • 6 edits in trunk/LayoutTests

Not reviewed, sheriffing.

[Chromium] Update chromium layout tests expecataions with new baselines. Remove expectations for some tests that seem to be passing now.

  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png:
  • platform/chromium/test_expectations.txt:
14:23 Changeset [57676] by weinig@apple.com
  • 14 edits
    2 copies
    5 adds in trunk

Add WebHistoryClient support.
https://bugs.webkit.org/show_bug.cgi?id=37671

Reviewed by Anders Carlsson.

WebKit2:

Adds the following callbacks:

didNavigateWithNavigationData
didPerformClientRedirect
didPerformServerRedirect
didUpdateHistoryTitle

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

(WebPageProxyMessage::):

  • Shared/WebNavigationDataStore.h: Added.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKNavigationData.cpp: Added.
  • UIProcess/API/C/WKNavigationData.h: Added.
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/WebHistoryClient.cpp: Copied from UIProcess/WebUIClient.cpp.
  • UIProcess/WebHistoryClient.h: Copied from UIProcess/WebUIClient.h.
  • UIProcess/WebNavigationData.cpp: Added.
  • UIProcess/WebNavigationData.h: Added.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • win/WebKit2.vcproj:

WebKitTools:

Add HistoryClient logging.

  • MiniBrowser/mac/BrowserWindowController.m:

(_didNavigateWithNavigationData):
(_didPerformClientRedirect):
(_didPerformServerRedirect):
(_didUpdateHistoryTitle):
(-[BrowserWindowController awakeFromNib]):

14:15 Changeset [57675] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

2010-04-15 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Start the mini browser in threaded mode if shift is pressed during startup.
https://bugs.webkit.org/show_bug.cgi?id=37670

  • MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate init]):
14:05 Changeset [57674] by cfleizach@apple.com
  • 11 edits
    2 adds in trunk

AXHelp is being appended from ancestors incorrectly
https://bugs.webkit.org/show_bug.cgi?id=37659

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/unexpected-help-text.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::helpText):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getHelpTextCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::helpText):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::helpText):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::helpText):

LayoutTests:

  • platform/mac/accessibility/table-attributes-expected.txt:
  • platform/mac/accessibility/table-sections-expected.txt:

Update tests because they were wrong. AXCells should not have their AXHelp come from the AXTable.

  • platform/mac/accessibility/unexpected-help-text-expected.txt: Added.
  • platform/mac/accessibility/unexpected-help-text.html: Added.
14:01 Changeset [57673] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-15 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance.
(broken by r57463 and r57381, at least). I've also filed bug 37477
to fix check-webkit-style to catch these things.

https://bugs.webkit.org/show_bug.cgi?id=38586

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:01 Changeset [57672] by dpranke@chromium.org
  • 5 edits in trunk/WebKitTools

2010-04-15 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Add a way to override the user-visible name for the test binary since
some ports don't call it DumpRenderTree (e.g., Chromium Win uses
test_shell, Chromium Mac uses TestShell) by adding a driver_name()
method to the Port interface.

https://bugs.webkit.org/show_bug.cgi?id=37631

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
13:55 Changeset [57671] by hyatt@apple.com
  • 5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=37669, REGRESSION: visited styles don't work right when only the visited path specifies
a pseudoelement.

Reviewed by Anders Carlsson.

Rework the pseudo cache on RenderStyles to support nesting, i.e., a pseudo hanging off a pseudo. The existing model gets
confused by this concept, since it relies on a singly linked list of chained pseudo styles (instead of a Vector owned by a primary
style). I changed the style cache to be a Vector instead.

Reworked both styleForElement and pseudoStyleForElement to resolve visited styles first, since in the pseudoStyleForElement case
you need to do this in order to know to allocate an unvisited pseudo style even if one shouldn't normally exist.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):

  • dom/Element.cpp:

(WebCore::Element::pseudoStyleCacheIsInvalid):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::addCachedPseudoStyle):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::cachedPseudoStyles):

13:45 Changeset [57670] by ajwong@chromium.org
  • 18 edits
    1 delete in trunk

2010-04-15 Albert J. Wong <ajwong@chromium.org>

Unreviewed, rolling out r57660.
http://trac.webkit.org/changeset/57660
https://bugs.webkit.org/show_bug.cgi?id=37604

Broke a large number of inspector layout tests in chromium.

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/v8/ScriptDebugServer.cpp:
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setBreakpointsActivated): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::ScriptDebugServer):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):

2010-04-15 Albert J. Wong <ajwong@chromium.org>

Unreviewed, rolling out r57660.
http://trac.webkit.org/changeset/57660
https://bugs.webkit.org/show_bug.cgi?id=37604

Broke a large number of inspector layout tests in chromium.

  • WebKit.gypi:
  • src/DebuggerAgent.h:
  • src/DebuggerAgentImpl.cpp:
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
  • src/DebuggerAgentManager.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
  • src/js/DebuggerScript.js: Removed.
  • src/js/DevTools.js: (WebInspector.loaded): (WebInspector.UnresolvedPropertyValue): ():
  • src/js/DevToolsHostStub.js:
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
13:44 Changeset [57669] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-15 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Mark QWebFrame::overloadedSlots autotest as expected failure

https://bugs.webkit.org/show_bug.cgi?id=37319

  • tests/qwebframe/tst_qwebframe.cpp:
13:40 Changeset [57668] by dumi@chromium.org
  • 4 edits in trunk/WebCore

DatabaseTracker refactoring: remove the dependency on
OriginQuotaManager from DatabaseTracker.h
https://bugs.webkit.org/show_bug.cgi?id=31482

Reviewed by Dimitri Glazkov.

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::DatabaseTracker):
(WebCore::DatabaseTracker::~DatabaseTracker):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • storage/DatabaseTracker.h:
  • storage/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didExecuteStatement):

13:36 Changeset [57667] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Remove empty file configurations.

Reviewed by Adam Roben.

  • win/WebKit2.vcproj:
13:28 Changeset [57666] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-15 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

[v8] mark Array.prototype.sort tests which verify if sorting is stable as passing for Chromium
https://bugs.webkit.org/show_bug.cgi?id=37655

  • platform/chromium/test_expectations.txt:
13:18 Changeset [57665] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebKit

2010-04-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35918

  • efl/WebCoreSupport/EditorClientEfl.cpp: Added.
  • efl/WebCoreSupport/EditorClientEfl.h: Added.
13:07 Changeset [57664] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-15 Zhenyao Mo <zmo@google.com>

Reviewed by Adam Barth.

Several tests in fast/canvas/webgl/ failed randomly on Leopard Commit Bot
This fixes an uninitialized variable bug and restores a glFinish call that used to be present.
https://bugs.webkit.org/show_bug.cgi?id=36908

  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): Initialize width/height to 0/0. (WebCore::GraphicsContext3D::prepareTexture): Restore glFinish() in every path.
12:33 Changeset [57663] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Spatial Navigation: make hasOffscreenRect() to earlier return 'true' if absoluteClippedOverflowRect() gives an empty rect
https://bugs.webkit.org/show_bug.cgi?id=37635

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

absoluteClippedOverflowRect method of RenderObject does return an empty IntRect for offscreen nodes.
So hasOffscreenRect method (SpatialNavigation.cpp) can safily bail out earlier in such cases.

  • page/SpatialNavigation.cpp:

(WebCore::hasOffscreenRect):

12:26 Changeset [57662] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Spatial Navigation: remove unnecessery assignment in updateFocusCandidateIfCloser method https://bugs.webkit.org/show_bug.cgi?id=37634

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

This assignment line is not longer needed after r57061, bug that refactored all
assignment logic to happen lines below in the method.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

11:47 Changeset [57661] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix WebKit2s build. Don't return temporaries.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/cf/WKStringCF.cpp:

(WKStringCreateWithCFString):

  • UIProcess/API/C/cf/WKURLCF.cpp:

(WKURLCreateWithCFURL):
(WKURLCopyCFURL):

11:40 Changeset [57660] by yurys@chromium.org
  • 18 edits
    1 add in trunk

2010-04-15 Yury Semikhatsky <yurys@google.com>

Reviewed by Pavel Feldman.


Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

https://bugs.webkit.org/show_bug.cgi?id=37604

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::setDebuggerScriptSource): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints): (WebCore::ScriptDebugServer::setBreakpointsActivated): (WebCore::ScriptDebugServer::continueProgram): (WebCore::ScriptDebugServer::stepIntoStatement): (WebCore::ScriptDebugServer::stepOverStatement): (WebCore::ScriptDebugServer::stepOutOfFunction): (WebCore::ScriptDebugServer::currentCallFrameState): (WebCore::ScriptDebugServer::currentCallFrameV8): (WebCore::ScriptDebugServer::onV8DebugMessage): (WebCore::ScriptDebugServer::onV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugHostDispatch): (WebCore::ScriptDebugServer::handleV8DebugMessage): (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled): (WebCore::ScriptDebugServer::didResume):
  • bindings/v8/ScriptDebugServer.h: (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::setMessageLoopDispatchHandler):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::V8InjectedScriptHost::currentCallFrameCallback): (WebCore::V8InjectedScriptHost::isActivationCallback):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):

2010-04-15 Yury Semikhatsky <yurys@google.com>

Reviewed by Pavel Feldman.

Support basic debugging capabilities including step in/over/out in v8
implementation of ScriptDebugServer.

https://bugs.webkit.org/show_bug.cgi?id=37604

  • WebKit.gypi:
  • src/DebuggerAgent.h:
  • src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
  • src/DebuggerAgentImpl.h:
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::hostDispatchHandler): (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
  • src/DebuggerAgentManager.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
  • src/js/DebuggerScript.js: Added. (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript): (debuggerScriptConstructor.DebuggerScript.getScripts): (debuggerScriptConstructor.DebuggerScript._formatScript): (debuggerScriptConstructor.DebuggerScript.setBreakpoint): (debuggerScriptConstructor.DebuggerScript.removeBreakpoint): (debuggerScriptConstructor.DebuggerScript.currentCallFrame): (debuggerScriptConstructor.DebuggerScript.stepIntoStatement): (debuggerScriptConstructor.DebuggerScript.stepOverStatement): (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction): (debuggerScriptConstructor.DebuggerScript.clearBreakpoints): (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated): (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame): (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber): (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber): (debuggerScriptConstructor):
  • src/js/DevTools.js: (WebInspector.loaded): (.): ():
  • src/js/DevToolsHostStub.js: (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
11:32 Changeset [57659] by zimmermann@webkit.org
  • 6 edits
    4 adds in trunk

2010-04-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Beth Dakin.

RenderSVGResource <-> id mapping should be cached
https://bugs.webkit.org/show_bug.cgi?id=37575

Test: svg/custom/clip-path-id-changes.svg

  • rendering/RenderSVGResource.h: (WebCore::RenderSVGResource::RenderSVGResource): (WebCore::RenderSVGResource::~RenderSVGResource): (WebCore::RenderSVGResource::idChanged): (WebCore::getRenderSVGResourceById):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addResource): (WebCore::SVGDocumentExtensions::removeResource): (WebCore::SVGDocumentExtensions::resourceById):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged):

2010-04-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Beth Dakin.

RenderSVGResource <-> id mapping should be cached
https://bugs.webkit.org/show_bug.cgi?id=37575

  • platform/mac/svg/custom/clip-path-id-changes-expected.checksum: Added.
  • platform/mac/svg/custom/clip-path-id-changes-expected.png: Added.
  • platform/mac/svg/custom/clip-path-id-changes-expected.txt: Added.
  • svg/custom/clip-path-id-changes.svg: Added.
11:24 Changeset [57658] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

2010-04-15 Justin Schuh <jschuh@chromium.org>

Reviewed by Dimitri Glazkov.

LayoutTest breakage in V8 bindings after r57627
https://bugs.webkit.org/show_bug.cgi?id=37660

Fixes breakage of the following tests due to an error in V8 bindings for
NamedNodeMap:
hc_namednodemapinuseattributeerr.html
hc_namednodemapsetnameditemreturnvalue.html
hc_namednodemapwrongdocumenterr.html
hc_namednodemapinvalidtype1.html
NamedNodeMap-setNamedItem-crash.html

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::setNamedItemNSCallback): (WebCore::V8NamedNodeMap::setNamedItemCallback):
11:22 Changeset [57657] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=37567, :first-letter inside a :visited link is wrong color. Make sure
that the pseudo style caching allows visited link styles to hang off other pseudo styles.

Reviewed by Anders Carlsson.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getCachedPseudoStyle):

11:21 Changeset [57656] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

REGRESSION(r56552): Broken scrollbars size https://bugs.webkit.org/show_bug.cgi?id=36853

Reviewed by Kenneth Christiansen and Tor Arne Vestbø.
Patch by Antonio Gomes <tonikitoo@webkit.org>

The regression was caused by r56552, which introduced a fix to bug
webkit.org/b/21300. The bug solved an issue with the resize handle on mac,
but did it in a way that affected all Qt platforms and thus broke the behavior
on non-mac platforms.

This patch makes the mac specific change ifdef'ed and only applied for the mac
platform.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowResizerRect):

11:13 Changeset [57655] by benm@google.com
  • 5 edits in trunk

2010-04-15 Ben Murdoch <benm@google.com>

Unreviewed, rolling out r57652.
http://trac.webkit.org/changeset/57652
https://bugs.webkit.org/show_bug.cgi?id=37609

Caused a build break on Chromium Mac and Layout Test fail on
Qt

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchPointState):

2010-04-15 Ben Murdoch <benm@google.com>

Unreviewed, rolling out r57652.
http://trac.webkit.org/changeset/57652
https://bugs.webkit.org/show_bug.cgi?id=37609

Caused a build break on Chromium Mac and Layout Test fail on
Qt

  • platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::):
  • platform/qt/PlatformTouchPointQt.cpp: (WebCore::PlatformTouchPoint::PlatformTouchPoint):
10:51 Changeset [57654] by andersca@apple.com
  • 4 edits in trunk/WebKitTools

2010-04-14 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Add "Force Repaint" to debug menu.
https://bugs.webkit.org/show_bug.cgi?id=37627

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController forceRepaint:]):
  • MiniBrowser/mac/English.lproj/MainMenu.xib:
10:33 Changeset [57653] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-15 Yaar Schnitman <yaar@chromium.org>

Reviewed by Nate Chapin.

Overloads auto-generation in V8
https://bugs.webkit.org/show_bug.cgi?id=37373

This will be used by XHR.send/open, Canvas.*, WebGL.* methods that are currently custom. When more than a single overload exists for a method, the correct overload is chosen based on the total number of arguments passed as well as the values passed to non-primitive arguments.

Overload dispatch order depends on the order the functions are defined in the IDL. Overloads must be specified from the most precise (overloads with wrapper type arguments) to the least precise (overloads with only primitive type arguments).

  • bindings/scripts/CodeGeneratorV8.pm: Identify and output overloads callbacks and dispatch code.
  • bindings/v8/test/TestObj.idl: Overloads sample.
  • bindings/v8/test/V8TestObj.cpp: Output change.
10:18 Changeset [57652] by benm@google.com
  • 5 edits in trunk

2010-04-14 Ben Murdoch <benm@google.com>

Reviewed by Kenneth Rohde Christiansen.

The TouchStationary state of WebCore::PlatformTouchPoint is not
handled inside the touch event handler.
https://bugs.webkit.org/show_bug.cgi?id=37609

After discussions at the WebKit contributors meeting, we decided that
this is a currently unused state without a good future use case in the
Touch API and thus decided to remove it. This patch actions that decision.

  • src/WebInputEventConversion.cpp: (WebKit::toPlatformTouchPointState): Remove TouchStationary.

2010-04-15 Ben Murdoch <benm@google.com>

Reviewed by Kenneth Rohde Christiansen.

The TouchStationary state of WebCore::PlatformTouchPoint
is not handled inside the touch event handler.
https://bugs.webkit.org/show_bug.cgi?id=37609

After discussions at the WebKit contributors meeting, we decided
that this is a currently unused state without a good future use
case in the Touch API and thus decided to remove it. This patch
actions that decision.

As the TouchStationary state is not handled in the EventHandler,
there is no change in functionality so no new tests are required.

  • platform/PlatformTouchPoint.h: (WebCore::PlatformTouchPoint::): Remove TouchStationary.
  • platform/qt/PlatformTouchPointQt.cpp: (WebCore::PlatformTouchPoint::PlatformTouchPoint): Remove TouchStationary.
10:03 Changeset [57651] by weinig@apple.com
  • 2 edits
    1 copy in trunk/WebKitTools

Add debug-minibrowser script.

Reviewed by Adam Roben.

  • Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser.
  • Scripts/webkitdirs.pm:
09:57 Changeset [57650] by sfalken@apple.com
  • 3 edits in trunk/WebCore

2010-04-15 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Use a lower-overhead mechanism for plug-in message throttling
https://bugs.webkit.org/show_bug.cgi?id=37642
<rdar://problem/7418285> Very high CPU usage idling in gmail under Windows 7 (plug-in related)


GMail has an instance of Flash that loads on the main mail page.
This Flash content sends us a constant stream of WM_USER+1 messsages.


There was already code in PluginMessageThrottlerWin to queue and process these
excess WM_USER+1 messages from Flash. Unfortunately, there were a couple of
problems with this code:


  • The timer used to process the excess messages had a very low timeout (1ms). Chrome uses a value of 5ms for this delay, and doesn't use excess CPU here, while still maintaining good Flash frame rate.


  • The overhead involved in generating a constant stream of 5ms timers still swamped the CPU, resulting in continued high CPU utilization.


To fix this, I changed the throttling code to:


  • Process a queued WM_USER+1 message directly if none has been processed in 5ms. This allows us to avoid the overhead of a timer.


  • Process remaining delayed WM_USER+1 messages on a 16ms timer.


This reduces our CPU utilization idling in GMail from ~20% to ~2-3% on my system.
I also verified the frame rate for Flash content wasn't reduced with this change.

  • plugins/win/PluginMessageThrottlerWin.cpp: (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Initialize m_lastMessageTime. (WebCore::PluginMessageThrottlerWin::appendMessage): Process a queued message directly if >5ms have passed. (WebCore::PluginMessageThrottlerWin::processQueuedMessage): Split out from messageThrottleTimerFired. (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired): Call through to processQueuedMessage.
  • plugins/win/PluginMessageThrottlerWin.h: Add processQueuedMessage, m_lastMessageTime.
08:59 Changeset [57649] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-04-15 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
https://bugs.webkit.org/show_bug.cgi?id=37636

Second patch: add Windows-specific implementation parts
of TestShell.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/TestShell.h: (TestShell::finishedEvent):
  • DumpRenderTree/chromium/TestShellWin.cpp: (watchDogThread): (TestShell::waitTestFinished):
08:50 Changeset [57648] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-04-15 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
https://bugs.webkit.org/show_bug.cgi?id=37636

First patch: fix compiler errors.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::reset): (EventSender::dispatchMessage):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):
  • DumpRenderTree/chromium/TestWebWorker.h:
  • DumpRenderTree/chromium/TextInputController.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
08:20 Changeset [57647] by antonm@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2010-04-15 Anton Muhin <antonm@chromium.org>

Not reviewed, sheriffing.

[Chromium] rebaseline URL related tests: update expectations for Win and Mac.

https://bugs.webkit.org/show_bug.cgi?id=37654

  • platform/chromium-mac/fast/url/mailto-expected.txt: Added.
  • platform/chromium-mac/fast/url/scheme-expected.txt: Added.
  • platform/chromium-win/fast/url/mailto-expected.txt: Added.
  • platform/chromium-win/fast/url/scheme-expected.txt: Added.
07:52 Changeset [57646] by hamaji@chromium.org
  • 3 edits in trunk/WebCore

2010-04-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

LEAK: in ThreadableWebSocketChannel::create()
https://bugs.webkit.org/show_bug.cgi?id=37584

No new tests because this change just fixes a leak.

  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
  • websockets/WorkerThreadableWebSocketChannel.h: (WebCore::WorkerThreadableWebSocketChannel::Bridge::create):
07:41 Changeset [57645] by ggaren@apple.com
  • 17 edits
    1 delete in trunk/WebKit2

Fixed complexity and performance FIXME created by using KURL in the UI
process -- it turned out that everywhere we were using KURL, we could
have just used String instead. (That's how Windows WebKit works, too.)

Reviewed by Anders Carlsson.

I kept WKURLRef and WKStringRef distinct opaque types in the API for now,
though, since there may be profit in changing their backing stores in the
future, and it's nice for the API to encode a difference between generic
strings and strings that are valid, canonical URLs.

  • Shared/KURLWrapper.h: Removed. Yay!
  • Shared/WebCoreTypeArgumentMarshalling.h: Nixed KURL marshalling functions.

Old callers marshal Strings now, instead. (This is what KURL was doing
under the covers, anyway.)

  • UIProcess/API/C/WKAPICast.h:

(toWK): Backed by StringImpl* now.
(toURLRef): Added a disambiguating function for specifying that you want
a WKURLRef, since StringImpl* converts to WKStringRef by default.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetProvisionalURL):
(WKFrameGetURL):

  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadURL):

  • UIProcess/API/C/WKURL.cpp:
  • UIProcess/API/C/cf/WKURLCF.cpp:

(WKURLCreateWithCFURL):
(WKURLCopyCFURL):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::urlAtProcessExit):

  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):

  • UIProcess/WebPolicyClient.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURL):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h: Replaced KURL / KURLWrapper with String.
07:40 Changeset [57644] by antonm@chromium.org
  • 6 edits in trunk/LayoutTests

2010-04-15 Anton Muhin <antonm@chromium.org>

Not reviewed, sheriffing.

[Chromium] rebaseline svg/custom/path-bad-data.svg after http://trac.webkit.org/changeset/57591/

http://trac.webkit.org/changeset/57591://bugs.webkit.org/show_bug.cgi?id=37657

  • platform/chromium-linux/svg/custom/path-bad-data-expected.checksum:
  • platform/chromium-linux/svg/custom/path-bad-data-expected.png:
  • platform/chromium-win/svg/custom/path-bad-data-expected.checksum:
  • platform/chromium-win/svg/custom/path-bad-data-expected.png:
  • platform/chromium-win/svg/custom/path-bad-data-expected.txt:
07:18 Changeset [57643] by antonm@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2010-04-15 Anton Muhin <antonm@chromium.org>

Not reviewed, sheriffing.

[Chromium] rebaseline fast/repaint/fixed-tranformed.html after
http://trac.webkit.org/changeset/57633/

https://bugs.webkit.org/show_bug.cgi?id=37656

  • platform/chromium-linux/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint: Added.
  • platform/chromium-win-xp/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/fixed-tranformed-expected.png: Added.
06:41 Changeset [57642] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg

2010-04-15 William Siegrist <wsiegrist@apple.com>

Give a name to new KillOldProcesss step so it does not collide with the other compile step.

06:39 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
06:19 Changeset [57641] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

2010-04-15 William Siegrist <wsiegrist@apple.com>

Add core/noncore categories to builders.

06:15 Changeset [57640] by antonm@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

2010-04-15 Anton Muhin <antonm@chromium.org>

Not reviewed, sheriffing.

Rebaseline some recently added LayoutTests under fast/url.

  • platform/chromium-linux/fast/url: Added.
  • platform/chromium-linux/fast/url/mailto-expected.txt: Added.
  • platform/chromium-linux/fast/url/scheme-expected.txt: Added.
  • platform/chromium-mac/fast/url: Added.
  • platform/chromium-mac/fast/url/ipv6-expected.txt: Added.
  • platform/chromium-mac/fast/url/path-url-expected.txt: Added.
  • platform/chromium-mac/fast/url/port-expected.txt: Added.
  • platform/chromium-mac/fast/url/standard-url-expected.txt: Added.
  • platform/chromium-win/fast/url: Added.
  • platform/chromium-win/fast/url/ipv6-expected.txt: Added.
  • platform/chromium-win/fast/url/path-url-expected.txt: Added.
  • platform/chromium-win/fast/url/port-expected.txt: Added.
  • platform/chromium-win/fast/url/standard-url-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
06:03 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
05:54 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
05:32 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
04:51 Changeset [57639] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

Duplicated patches related to wml were pushed to trunk. So, one of
the patches should be reverted.
https://bugs.webkit.org/show_bug.cgi?id=37542

  • wml/WMLOptionElement.h:
  • wml/WMLSelectElement.h:
04:01 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
03:32 BuildingQtOnLinux edited by jocelyn.turcotte@nokia.com
(diff)
03:03 Changeset [57638] by eric@webkit.org
  • 5 edits in trunk

2010-04-15 Bruno Schmidt <bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Null QObjects properties cause Segmentation Fault
https://bugs.webkit.org/show_bug.cgi?id=34730

QObjects exported to the QWebkit javascript with properties that are
a null "QObject*" cause Segmentation Fault.

If an QObject is added to the javascript context and it contains
properties of the type QObject* with NULL value, calling the property
causes Segmentation Fault.
So now the code below properly checks for null pointers:

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getClass): may return NULL (JSC::Bindings::QtInstance::getMethod): may return jsNull() (JSC::Bindings::QtInstance::stringValue): may return jsNull() (JSC::Bindings::QtInstance::booleanValue): may return false
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue): May return jsNull on QObjectStar

2010-04-15 Bruno Schmidt <bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Null QObjects properties cause Segmentation Fault
https://bugs.webkit.org/show_bug.cgi?id=34730

QObjects exported to the QWebkit javascript with properties that are
a null "QObject*" cause Segmentation Fault.

If an QObject is added to the javascript context and it contains
properties of the type QObject* with NULL value, calling the property
causes Segmentation Fault.

Follow the tests for the corrections done over WebCore.

  • tests/qwebframe/tst_qwebframe.cpp: (MyQObject::MyQObject): init the field m_objectStar (MyQObject::objectStarProperty): read the Object* prop (MyQObject::setObjectStarProperty): write the Object* prop (tst_QWebFrame::getSetStaticProperty): new tests for the new prop
02:53 Changeset [57637] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-04-15 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix memory leak in QScriptEngine::evaluate().

QScriptEnginePrivate::evaluate should release temporary variables.

[Qt] QScriptEngine::evaluate has memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37596

  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::evaluate):
  • qt/api/qscriptengine_p.h:
01:14 Changeset [57636] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-15 Jonathan Dixon <joth@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=37492

Add mailto: canonicalization tests to the URL regressions tests

  • fast/url/mailto-expected.txt: Added.
  • fast/url/mailto.html: Added.
  • fast/url/script-tests/mailto.js: Added.
01:07 Changeset [57635] by abarth@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-04-15 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add URL scheme parsing tests
https://bugs.webkit.org/show_bug.cgi?id=37496

I'm not super happy with how these test turned out. It's difficult to
test these cases with this methodology because most of the cases get
treated as relative URLs. I tired using the "protocol" property of the
HTMLAnchorElement, but that often caused the test case to be ignored
for reasons I don't fully understand.

  • fast/url/resources/utilities.js: (setBaseURL):
    • In the course of trying various variations of this test, I wrote this function. It seemed useful, so I left it here for the benefit of future test writing.
  • fast/url/scheme-expected.txt: Added.
  • fast/url/scheme.html: Added.
  • fast/url/script-tests/scheme.js: Added.
00:55 Changeset [57634] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Add comments back to IPv4 URL parsing test
https://bugs.webkit.org/show_bug.cgi?id=37620

I removed these comments when importing this test. The comments are
likley to be helpful to us in the future, so I've restored them.

  • fast/url/script-tests/ipv4.js:

04/14/10:

23:49 April 2010 Meeting edited by vestbo@webkit.org
(diff)
21:48 Changeset [57633] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2010-04-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Repaint of fixed, transformed element is broken
https://bugs.webkit.org/show_bug.cgi?id=37637

RenderBox::computeRectForRepaint() failed to set the 'fixed' flag correctly
for elements that had both fixed position and a transform. If the element has
a transform, 'fixed' should only remain true if the element itself is fixed
position.

Also cache style()->position() in a local variable for performance.

Test: fast/repaint/fixed-tranformed.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint):
21:47 Changeset [57632] by simon.fraser@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Additional refptr/passrefptr workarounds for WINSCW compiler

https://bugs.webkit.org/show_bug.cgi?id=28054

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12

Reviewed by Tor Arne Vestbø.

  • wtf/PassRefPtr.h:

(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):

  • wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):
(WTF::::operator):

21:04 Changeset [57631] by eric@webkit.org
  • 8 edits in trunk

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615

specification: http://dev.w3.org/2006/waf/widgets-vmmf/

  • fast/media/media-feature-wgt-view-mode.html:

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615

test: fast/media/media-feature-wgt-view-mode.html

specification: http://dev.w3.org/2006/waf/widgets-vmmf/

  • css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):
  • page/ChromeClient.h: (WebCore::ChromeClient::isWindowed): (WebCore::ChromeClient::isMaximized): (WebCore::ChromeClient::isMinimized):

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615

test: fast/media/media-feature-wgt-view-mode.html

specification: http://dev.w3.org/2006/waf/widgets-vmmf/

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::isWindowed): (WebCore::ChromeClientQt::isFullscreen): (WebCore::ChromeClientQt::isMaximized): (WebCore::ChromeClientQt::isMinimized):
  • WebCoreSupport/ChromeClientQt.h:
20:37 Changeset [57630] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Adam Barth <abarth@webkit.org>

Unreviewed attempt to fix Qt build.

  • bindings/js/JSNodeCustom.cpp:
20:34 Changeset [57629] by eric@webkit.org
  • 6 edits in trunk

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
https://bugs.webkit.org/show_bug.cgi?id=37622

Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
(bug 35844). Moving it back.

  • Api/qwebpage.cpp: (qt_wrt_setViewMode):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setMediaType):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
https://bugs.webkit.org/show_bug.cgi?id=37622

Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
(bug 35844). Moving it back.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):
20:17 Changeset [57628] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a memory leak in QScriptValue::inherits.

[Qt] QScriptValue::inherits has a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37617

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::inherits):
20:11 Changeset [57627] by abarth@webkit.org
  • 16 edits in trunk

2010-04-14 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Javascript URL can be set as iframe.src via multiple DOM aliases
https://bugs.webkit.org/show_bug.cgi?id=37031

Moved frame/iframe checks from Attr to Node on inherited members.
Node child manipulation methods now return NOT_SUPPORTED_ERR if used
on a frame/iframe src attribute.
NamedNodeMap set methods now perform frame/iframe src checks.
Moved allowSettingSrcToJavascriptURL static helper function from
JSElementCustom.cpp to exported function in JSDOMBinding.h.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
  • bindings/js/JSDOMBinding.cpp: (WebCore::allowSettingSrcToJavascriptURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSElementCustom.cpp:
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::setNamedItem): (WebCore::JSNamedNodeMap::setNamedItemNS):
  • bindings/js/JSNodeCustom.cpp: (WebCore::isAttrFrameSrc): (WebCore::JSNode::setNodeValue): (WebCore::JSNode::setTextContent): (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild):
  • bindings/v8/custom/V8AttrCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: (WebCore::V8NamedNodeMap::setNamedItemNSCallback): (WebCore::V8NamedNodeMap::setNamedItemCallback): (WebCore::toV8):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::isFrameSrc): (WebCore::V8Node::textContentAccessorSetter): (WebCore::V8Node::nodeValueAccessorSetter): (WebCore::V8Node::insertBeforeCallback): (WebCore::V8Node::replaceChildCallback): (WebCore::V8Node::removeChildCallback): (WebCore::V8Node::appendChildCallback):
  • dom/Attr.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:

2010-04-14 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Fix frame/iframe src setting for JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=37031

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
20:07 Changeset [57626] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a few memory leaks in QScriptEngine.

Syntax checking caused memory leak, not all temporary variables were released.

[Qt] Syntax checking in the QtScript cause a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37610

  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::checkSyntax):
  • qt/api/qscriptsyntaxcheckresult.cpp: (QScriptSyntaxCheckResultPrivate::errorMessage): (QScriptSyntaxCheckResultPrivate::errorLineNumber):
19:58 Changeset [57625] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix memory leak inside QScriptEnginePrivate::makeJSValue.

QScriptEnginePrivate::makeJSValue should release temporary JSStringRef variable.

[Qt] tst_QScriptValue::toString has a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=37598

  • qt/api/qscriptengine_p.h: (QScriptEnginePrivate::makeJSValue):
18:39 Changeset [57624] by alex@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

We have to check if the resource handler is cancelled before
checking the client, other case it could crash.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
18:06 Changeset [57623] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-04-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Rendering artifacts on Qt plugins when scrolling the page
https://bugs.webkit.org/show_bug.cgi?id=37152

Because we no longer repaint the entire viewport on scroll,
we must trigger a repaint of QtPluginWidgets when their geometry changes.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
17:59 Changeset [57622] by dpranke@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-04-15 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Add some very minimal unit tests for new-run-webkit-tests. This should
be enough to catch egregious brokenness like syntax errors and import
declaration issues.

https://bugs.webkit.org/show_bug.cgi?id=37432

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.
17:46 Changeset [57621] by andersca@apple.com
  • 6 edits in trunk/WebKit2

2010-04-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix horizontal scrollbar repainting
https://bugs.webkit.org/show_bug.cgi?id=37626

Make sure that the update chunk is flipped because that's what WebCore expects.


  • Shared/mac/UpdateChunk.cpp: (WebKit::UpdateChunk::createImage):
  • Shared/mac/UpdateChunk.h: Add new createImage member function that creates a CGImageRef from the update chunk.


  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: (WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore): Pass the right rectangle here; CoreGraphics wants it in non-flipped coordinates.


(WebKit::DrawingAreaProxyUpdateChunk::ensureBackingStore):
Create a flipped backing store.

  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk): Flip the update chunk.
17:13 Changeset [57620] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-12 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
https://bugs.webkit.org/show_bug.cgi?id=36578

  • DEPS: Pull sub deps from chromium's DEPS file
16:33 Changeset [57619] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

16:31 Changeset [57618] by mrowe@apple.com
  • 1 copy in tags/Safari-533.5

New tag.

16:25 Changeset [57617] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Xan Lopez <xlopez@igalia.com>

[GTK] scrollbars/scrollbar-crash-on-refresh.html is flakey on debug bots
https://bugs.webkit.org/show_bug.cgi?id=37623

We are on a mission here, people.

  • platform/gtk/Skipped:
16:11 Changeset [57616] by eric@webkit.org
  • 5 edits
    2 deletes in trunk

2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57609.
http://trac.webkit.org/changeset/57609
https://bugs.webkit.org/show_bug.cgi?id=37614

"Broke multiple builders. Probably needs new test results,
but may be an Inspector bug." (Requested by eseidel on
#webkit).

  • inspector/console-resource-errors-expected.txt: Removed.
  • inspector/console-resource-errors.html: Removed.

2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57609.
http://trac.webkit.org/changeset/57609
https://bugs.webkit.org/show_bug.cgi?id=37614

"Broke multiple builders. Probably needs new test results,
but may be an Inspector bug." (Requested by eseidel on
#webkit).

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
16:01 Changeset [57615] by aroben@apple.com
  • 5 edits in trunk/WebKit/win

Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows

Fixes <http://webkit.org/b/37619>.

Reviewed by Steve Falkenburg.

  • Interfaces/IWebScriptWorld.idl: Added unregisterWorld.
  • Interfaces/WebKit.idl: Touched to force a build.
  • WebScriptWorld.cpp:

(WebScriptWorld::unregisterWorld):

  • WebScriptWorld.h:

Added. Just calls through to DOMWrapperWorld::unregisterWorld.

15:32 Changeset [57614] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping fast/workers/shared-worker-frame-lifecycle.html
https://bugs.webkit.org/show_bug.cgi?id=37616

  • platform/gtk/Skipped:
15:15 Changeset [57613] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2010-04-14 Steve Falkenburg <sfalken@apple.com>

Reviewed by Dan Bernstein.

Don't cache SimpleFontData* in getLastResortFallbackFont. The cached entry may be invalidated.
https://bugs.webkit.org/show_bug.cgi?id=37599

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::fontDataFromDescriptionAndLogFont): (WebCore::FontCache::getLastResortFallbackFont):
15:06 Changeset [57612] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing, I've duplicated the other printing bugs and
left this one.
https://bugs.webkit.org/show_bug.cgi?id=37613

  • platform/gtk/Skipped:
14:53 Changeset [57611] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to fix the build

14:51 Changeset [57610] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping inspector/timeline-layout.html fails
https://bugs.webkit.org/show_bug.cgi?id=37611

  • platform/gtk/Skipped:
14:49 Changeset [57609] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-04-14 Andrey Kosyakov <caseq@chromium.ru>

Reviewed by Timothy Hatcher.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
https://bugs.webkit.org/show_bug.cgi?id=37215

  • inspector/console-resource-errors-expected.txt: Added.
  • inspector/console-resource-errors.html: Added.

2010-04-14 Andrey Kosyakov <caseq@chromium.ru>

Reviewed by Timothy Hatcher.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
https://bugs.webkit.org/show_bug.cgi?id=37215

Test: inspector/console-resource-errors.html

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
14:38 Changeset [57608] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-04-14 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

Move the YARR JIT fallback detection from RegexJIT.cpp to
RegexCompiler.cpp.

https://bugs.webkit.org/show_bug.cgi?id=37571

  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::atomBackReference): (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateTerm): (JSC::Yarr::RegexGenerator::RegexGenerator): (JSC::Yarr::jitCompileRegex):
  • yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::operator!):
  • yarr/RegexPattern.h: (JSC::Yarr::RegexPattern::RegexPattern): (JSC::Yarr::RegexPattern::reset):
14:24 Changeset [57607] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/page-break-always.html
https://bugs.webkit.org/show_bug.cgi?id=37607

  • platform/gtk/Skipped:
14:10 Changeset [57606] by eric@webkit.org
  • 6 edits
    1 delete in trunk

2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57599.
http://trac.webkit.org/changeset/57599
https://bugs.webkit.org/show_bug.cgi?id=37605

"Broke Chromium build" (Requested by dglazkov on #webkit).

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
  • platform/chromium/PopupMenuChromium.h:

2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57599.
http://trac.webkit.org/changeset/57599
https://bugs.webkit.org/show_bug.cgi?id=37605

"Broke Chromium build" (Requested by dglazkov on #webkit).

  • WebKit.gyp:
  • src/WebViewImpl.h:
  • tests/PopupMenuTest.cpp: Removed.
14:08 Changeset [57605] by weinig@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

Add WKRetainPtr helper class as private header
https://bugs.webkit.org/show_bug.cgi?id=37603

Reviewed by Anders Carlsson.

WKRetainPtr is just like RetainPtr, but works for WK types instead of
CF/NS types.

  • UIProcess/API/cpp: Added.
  • UIProcess/API/cpp/WKRetainPtr.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Add new file.
  • win/WebKit2.vcproj: Ditto.
13:51 Changeset [57604] by aa@chromium.org
  • 10 edits in trunk

2010-04-14 Aaron Boodman <aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

  • notifications/Notification.cpp: (WebCore::Notification::Notification): Accept resolved KURL instead of relative string.
  • notifications/Notification.h: (WebCore::Notification::create): Ditto. (WebCore::Notification::iconURL): Return resolved KURL instead of relative string.
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): Immediately resolve URL instead of passing off relative string. (WebCore::NotificationCenter::createNotification): Ditto.
  • notifications/NotificationContents.h: (WebCore::NotificationContents::NotificationContents): Accept resolved KURL instead of relative string. (WebCore::NotificationContents::icon): Return resolved URL.

2010-04-14 Aaron Boodman <aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

  • public/WebNotification.h: Remove deprecated icon() method.
  • src/WebNotification.cpp: Ditto.

2010-04-14 Aaron Boodman <aa@chromium.org>

Reviewed by David Levin.

Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
unsupported. Fixed by resolving the relative URL first.

https://bugs.webkit.org/show_bug.cgi?id=36623

Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.

  • WebCoreSupport/NotificationPresenterClientQt.cpp: (NotificationPresenterClientQt::show): Return type of NotificationContents::iconURL() changed.
13:39 Changeset [57603] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-04-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add ThemeMac::ensuredView and get rid of a workaround in ThemeMac::paintButton.
https://bugs.webkit.org/show_bug.cgi?id=37601

  • platform/mac/ThemeMac.h:
  • platform/mac/ThemeMac.mm: (-[WebCoreFlippedView isFlipped]): (WebCore::paintButton): (WebCore::ThemeMac::ensuredView):
13:32 Changeset [57602] by bweinstein@apple.com
  • 2 edits
    2 adds in trunk/WebKitTools

Add a way for the buildbot to kill any old processes that are running. This
is useful because the Windows bots can get in states where a process remains
running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
state, and the processes must be killed manually.

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill

the old processes that might be running.

  • BuildSlaveSupport/win/kill-old-processes: Added.
13:26 Changeset [57601] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Make the WebProcess a LSUIElement to suppress its icon from the Dock.

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Info.plist:
13:23 Changeset [57600] by weinig@apple.com
  • 4 edits in trunk/WebKitTools

Tear down WebKit more completely on window closing and application
termination. We still don't block application termination for pending
close, but this is a step in the right direction.

Reviewed by Anders Carlsson.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate applicationWillTerminate:]):

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController dealloc]):
(-[BrowserWindowController windowWillClose:]):
(-[BrowserWindowController applicationTerminating]):

13:21 Changeset [57599] by eric@webkit.org
  • 6 edits
    1 add in trunk

2010-04-14 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
https://bugs.webkit.org/show_bug.cgi?id=37436

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
  • platform/chromium/PopupMenuChromium.h:

2010-04-14 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
Also adding unit-tests for the select popup code.
https://bugs.webkit.org/show_bug.cgi?id=37436

  • WebKit.gyp:
  • src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup):
  • tests/PopupMenuTest.cpp: Added.
13:18 Changeset [57598] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip xss-DENIED-iframe-src-alias.html on Windows

I thought that skipping this test was causing other http tests to time
out, but Brian Weinstein pointed out that the timing-out tests come
before this one so shouldn't be affected by it.

<http://webkit.org/b/37096> tracks making this test not time out.

Rubber-stamped by Brian Weinstein.

  • platform/win/Skipped:
13:01 Changeset [57597] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

Add tests for ipv6 address canonicalization.
https://bugs.webkit.org/show_bug.cgi?id=37583

  • fast/url/ipv6-expected.txt: Added.
  • fast/url/ipv6.html: Added.
  • fast/url/script-tests/ipv6.js: Added.
12:44 PythonGuidelines edited by cjerdonek@webkit.org
Clarified suggested import ordering style guideline. (diff)
12:42 Changeset [57596] by andersca@apple.com
  • 3 edits in trunk/WebKit2

2010-04-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Factor code to paint into an update chunk out into a separate function.
https://bugs.webkit.org/show_bug.cgi?id=37594

  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk): (WebKit::DrawingAreaUpdateChunk::display): (WebKit::DrawingAreaUpdateChunk::setSize):
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h:
12:24 Changeset [57595] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Remove an incorrect ASSERT in UniscribeHelper::draw().
https://bugs.webkit.org/show_bug.cgi?id=37533

Reviewed by Jian Li.

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

11:56 Changeset [57594] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: readline shortcuts don't work in Chromium.

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._onKeyDown): (WebInspector.TextPrompt.prototype._moveCaretToStartOfPrompt):
11:45 Changeset [57593] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/page-break-always-for-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=37592

  • platform/gtk/Skipped:
11:42 Changeset [57592] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Console: Shift-Tab does not cycle autocompletions in the reverse order
https://bugs.webkit.org/show_bug.cgi?id=37582

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): (WebInspector.TextPrompt.prototype._completionsReady): (WebInspector.TextPrompt.prototype._tabKeyPressed):
11:30 Changeset [57591] by eric@webkit.org
  • 8 edits in trunk

2010-04-14 Jeff Schiller <codedread@gmail.com>

Reviewed by Dirk Schulze.

Update path parser test for Bug 37413: https://bugs.webkit.org/show_bug.cgi?id=37413
now that all path segments render up until the first error

  • platform/mac/svg/custom/path-bad-data-expected.txt: updated path segments that render
  • svg/custom/path-bad-data.svg: updated test to ensure reference image is the same
  • svg/dom/fuzz-path-parser-expected.txt: updated path segments that render
  • svg/dom/path-parser-expected.txt: updated path segments that render
  • svg/dom/script-tests/path-parser.js: changed expected results for path segments that render ():

2010-04-14 Jeff Schiller <codedread@gmail.com>

Reviewed by Dirk Schulze.

Render SVG Paths up to first error, bug 37413: https://bugs.webkit.org/show_bug.cgi?id=37413

  • svg/SVGParserUtilities.cpp: (WebCore::SVGPathSegListBuilder::build):
11:18 Changeset [57590] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Ctrl-L (Clear History) does nothing on Windows
https://bugs.webkit.org/show_bug.cgi?id=37579

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
10:51 Changeset [57589] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping printing/numberOfPages.html
https://bugs.webkit.org/show_bug.cgi?id=37585

  • platform/gtk/Skipped:
10:42 Changeset [57588] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Add port URL tests
https://bugs.webkit.org/show_bug.cgi?id=37524

This went pretty well.

  • fast/url/port-expected.txt: Added.
  • fast/url/port.html: Added.
  • fast/url/script-tests/port.js: Added.
10:27 Changeset [57587] by eric@webkit.org
  • 5 edits
    1 copy in trunk/WebKitTools

2010-04-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Use pretty patch for confirming webkit-patch diffs
https://bugs.webkit.org/show_bug.cgi?id=37489

  • Scripts/webkitpy/common/prettypatch.py: Added.
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/confirmdiff.py:
10:16 Changeset [57586] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Add LayoutTests for parsing "path" URLs
https://bugs.webkit.org/show_bug.cgi?id=37581

  • fast/url/path-url-expected.txt: Added.
  • fast/url/path-url.html: Added.
  • fast/url/script-tests/path-url.js: Added.
10:06 Changeset [57585] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Add LayoutTests for parsing standard URLs
https://bugs.webkit.org/show_bug.cgi?id=37580

  • fast/url/script-tests/standard-url.js: Added.
  • fast/url/standard-url-expected.txt: Added.
  • fast/url/standard-url.html: Added.
09:39 Changeset [57584] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Roll out r57566

It seems to have caused other http tests to hang on Windows.

  • platform/win/Skipped:
09:26 Changeset [57583] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-14 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Maciej Stachowiak.

Mac OS X: Use deployment target to determine whether memory tagging should be enabled
https://bugs.webkit.org/show_bug.cgi?id=34888

When building on (Snow) Leopard but targeting Tiger
(TARGETING_TIGER defined, BUILDING_ON_TIGER not defined),
WebKit would crash on Tiger because the tags passed to mmap
caused those function calls to fail.

Conversely, when building on Tiger but targeting Leopard
(BUILDING_ON_TIGER defined, TARGETING_LEOPARD defined), WebKit
would crash on Leopard because the tags passed to vm_map and
vm_allocate caused those function calls to fail.

Solution: Use TARGETING_TIGER rather than BUILDING_ON_TIGER to
govern the tag definitions. Use the same tags for vm_map and
vm_allocate regardless of target, since they work on
both. Fall back to the mmap tags that work on Tiger (that is,
"no tags") if targeting Tiger, since those tags also work on
Leopard.

  • wtf/VMTags.h:
09:17 WebInspector edited by apavlov@chromium.org
Fix column title, add Chrome/Chromium-specific shortcuts (diff)
09:08 Changeset [57582] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

Skip some and add test expectations for other layout tests which started to fail
against Chromium after http://trac.webkit.org/changeset/57535/

  • platform/chromium/test_expectations.txt:
08:48 WebInspector edited by apavlov@chromium.org
Add Win/Linux shortcuts (diff)
08:19 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
08:10 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
08:07 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
08:02 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
07:56 Changeset [57581] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skipping another crash on the 64bit Gtk slave.

  • platform/gtk/Skipped:
07:52 Changeset [57580] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping plugins/open-and-close-window-with-plugin.html
https://bugs.webkit.org/show_bug.cgi?id=37572

Skipping media/video-played-ranges-1.html
https://bugs.webkit.org/show_bug.cgi?id=37573

  • platform/gtk/Skipped:
07:45 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
07:25 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
07:12 Changeset [57579] by antonm@chromium.org
  • 26 edits
    147 adds
    1 delete in trunk/LayoutTests/platform

Not reviewed.

BUG=http://code.google.com/p/chromium/issues/detail?id=41450

06:49 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
05:12 Changeset [57578] by antonm@chromium.org
  • 2 edits in trunk/WebCore

2010-04-14 Anton Muhin <antonm@chromium.org>

Not review, build fix.

Add <limits.h> include to bring UINT_MAX.

  • html/canvas/WebGLArray.h:
04:11 Changeset [57577] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57573.
http://trac.webkit.org/changeset/57573
https://bugs.webkit.org/show_bug.cgi?id=37569

Revert r57573 which unskipped http/tests/media/video-
cookie.html on SnowLeopard Intel Release (Tests). Let's get a
core builder back to green again. (Requested by WildFox on
#webkit).

  • platform/mac/Skipped:
04:00 Changeset [57576] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2010-04-14 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to unbreak build - NodeRenderStyle.h is an _interessting_ concept...

  • rendering/style/SVGRenderStyle.cpp: Include 'NodeRenderStyle.h'
03:44 Changeset [57575] by zimmermann@webkit.org
  • 14 edits in trunk/WebCore

2010-04-14 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGRenderStyle/SVGRenderStyleDefs needs a cleanup
https://bugs.webkit.org/show_bug.cgi?id=37568

Cleanup SVGRenderStyle / SVGRenderStyleDefs:

  • use copy constructors in initialization list to initialize members, instead of assignment operators in the body
  • fix style issues (misplaced references, abbrevations)
  • merge StyleClipData/StyleMaskData to save memory, rename it StyleResourceData
  • move filter property in StyleResourceData
  • rename StyleMarkerData to StyleInheritedResourceData to highlight the difference to StyleResourceData
  • unify naming schemes for all resources (filter/clipper/masker/markers)
    • clipPath() -> clipperResource()
    • maskElement() -> maskerResource()
    • startMarker() -> markerStartResource()
    • midMarker() -> markerMidResource()
    • endMarker() -> markerEndResource()
    • filter() -> filterResource()

Adapt all callsites to the renames above.
No new tests, as this doesn't affect anything except memory overhead.

  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer): (WebCore::deregisterFromResources):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle): (WebCore::SVGRenderStyle::operator==): (WebCore::SVGRenderStyle::inheritedNotEqual): (WebCore::SVGRenderStyle::inheritFrom):
  • rendering/style/SVGRenderStyle.h:
  • rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleFillData::StyleFillData): (WebCore::StyleFillData::operator==): (WebCore::StyleStrokeData::StyleStrokeData): (WebCore::StyleStrokeData::operator==): (WebCore::StyleStopData::StyleStopData): (WebCore::StyleStopData::operator==): (WebCore::StyleTextData::StyleTextData): (WebCore::StyleMiscData::StyleMiscData): (WebCore::StyleMiscData::operator==): (WebCore::StyleShadowSVGData::StyleShadowSVGData): (WebCore::StyleShadowSVGData::operator==): (WebCore::StyleResourceData::StyleResourceData): (WebCore::StyleResourceData::operator==): (WebCore::StyleInheritedResourceData::StyleInheritedResourceData): (WebCore::StyleInheritedResourceData::operator==):
  • rendering/style/SVGRenderStyleDefs.h: (WebCore::StyleFillData::operator!=): (WebCore::StyleStopData::operator!=): (WebCore::StyleMiscData::create): (WebCore::StyleMiscData::copy): (WebCore::StyleMiscData::operator!=): (WebCore::StyleShadowSVGData::create): (WebCore::StyleShadowSVGData::copy): (WebCore::StyleShadowSVGData::operator!=): (WebCore::StyleResourceData::create): (WebCore::StyleResourceData::copy): (WebCore::StyleResourceData::operator!=): (WebCore::StyleInheritedResourceData::create): (WebCore::StyleInheritedResourceData::copy): (WebCore::StyleInheritedResourceData::operator!=):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addResource): (WebCore::SVGDocumentExtensions::removeResource):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
03:23 Changeset [57574] by eric@webkit.org
  • 9 edits
    2 adds in trunk

2010-04-14 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
https://bugs.webkit.org/show_bug.cgi?id=34718

  • fast/canvas/webgl/read-pixels-expected.txt: Verify pixelStorei and readPixels.
  • fast/canvas/webgl/read-pixels.html: Ditto.

2010-04-14 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
https://bugs.webkit.org/show_bug.cgi?id=34718

Test: fast/canvas/webgl/read-pixels.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Init members to support pack_alignment. (WebCore::WebGLRenderingContext::pixelStorei): Save pack/unpack_alignment. (WebCore::WebGLRenderingContext::readPixels): Validate enum and deal with pack_alignment.
  • html/canvas/WebGLRenderingContext.h: Add members to support pack_alignment.
  • platform/graphics/GraphicsContext3D.h: Refactor readPixels.
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.

2010-04-14 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

readPixels must take PACK_ALIGNMENT into account
https://bugs.webkit.org/show_bug.cgi?id=34718

  • src/GraphicsContext3D.cpp: Refactor readPixels.
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): Temporarily disable pack alignment for glReadPixels. (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.
03:11 Changeset [57573] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Nicolas Weber <thakis@chromium.org>

Reviewed by Gustavo Noronha Silva.

Remove passing test from Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=34287

  • platform/mac/Skipped: video-cookie.html seems to be passing, so remove it from Skipped list.
02:00 Changeset [57572] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach webkit-patch how to handle revisions missing ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=37519

Make commit_info_for_revision return None when revision
is missing a ChangeLog. Previously we would throw an array index
exception.
Teach callers how to handle None.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
01:51 Changeset [57571] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-14 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Re-write testProfilerTab to match the new implementation.

https://bugs.webkit.org/show_bug.cgi?id=37516

  • src/js/Tests.js: (.TestSuite.prototype.testProfilerTab.findDisplayedNode): (.TestSuite.prototype.testProfilerTab.findVisibleView): (.TestSuite.prototype.testProfilerTab):
00:34 Changeset [57570] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/audio-data-url.html
https://bugs.webkit.org/show_bug.cgi?id=37564

  • platform/gtk/Skipped:
00:15 Changeset [57569] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-14 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping plugins/update-widgets-crash.html
https://bugs.webkit.org/show_bug.cgi?id=37562

  • platform/gtk/Skipped:
00:03 Changeset [57568] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/video-seeking.html
https://bugs.webkit.org/show_bug.cgi?id=37551

Skipping media/video-timeupdate-reverse-play.html
https://bugs.webkit.org/show_bug.cgi?id=37552

Skipping media/video-played-reset.html
https://bugs.webkit.org/show_bug.cgi?id=37556

Skipping http/tests/misc/image-blocked-src-change.html
https://bugs.webkit.org/show_bug.cgi?id=37557

Skipping inspector/console-clear.html
https://bugs.webkit.org/show_bug.cgi?id=37558

Skipping inspector/console-format-collections.html
https://bugs.webkit.org/show_bug.cgi?id=37559

Skipping svg/dom/SVGScriptElement/script-set-href.svg
https://bugs.webkit.org/show_bug.cgi?id=37560

  • platform/gtk/Skipped:
Note: See TracTimeline for information about the timeline view.