Timeline


and

04/20/10:

23:55 Changeset [57956] by eric@webkit.org

2010-04-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests has much higher startup latency than run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37643

I got rid of the -expected.checksum reads during startup.
This makes startup noticably better on my laptop.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Use image_hash() instead of .image_hash now that expected.checksum file reads are done lazily.
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
    • Add debug logging for this sleep call. In my testing I never saw this sleep() hit.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
    • Sleep a shorter interval to make websocket server startup more responsive. On my machine startup was taking around 1 second.
    • Remove the unconditional .5s delay on startup.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Make image_hash file reads done lazily in a new image_hash() function.
    • Add a "Starting testing ..." meter update after DRT threads have been started, but before we get updates from the first one.
    • Rename variable "t" to a full english name to match WebKit style.
23:41 Changeset [57955] by oliver@apple.com

2010-04-20 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

[ES5] RegExp literals are constants that should be persistent across multiple function calls.
https://bugs.webkit.org/show_bug.cgi?id=37908

Dump the separate RegExp constant pool, and just use the standard JS constant pool
in codeblock. This allows us to drop op_new_regexp and all associated code as well.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::shrinkToFit):
  • bytecode/CodeBlock.h:
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::RegExpNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h: (JSC::):

2010-04-20 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

[ES5] RegExp literals are constants that should be persistent across multiple function calls.
https://bugs.webkit.org/show_bug.cgi?id=37908

Add tests to ensure correct persistence of RegExp literals, and correctly avoid
sharing "identical" regexps used in different places.

  • fast/js/regexp-literals-are-constants-expected.txt: Added.
  • fast/js/regexp-literals-are-constants.html: Added.
  • fast/js/script-tests/regexp-literals-are-constants.js: Added. (test1): (returnRegExpLiteral): (returnConditionalRegExpLiteral):
22:54 Changeset [57954] by rniwa@webkit.org

Nested <ul>s are mishandled when converted to <ol> using execCommand('insertorderedlist')
https://bugs.webkit.org/show_bug.cgi?id=19539

Reviewed by Justin Garcia.

WebCore:

Fixes a bug where two consecutive lists are not merged if they have been converted
from ordered/unordered lists inside another list.

The bug was caused by InsertListCommand::doApply where it did not merge a newly inserted
list element and its neighbors. This patch adds code to doApply so that after inserting
the list element, it updates previousList and nextList to the outermost list elements around
insertionPos under the same enclosing list. Because the next and the previous list elements
are not necessarily visually next to the newly inserted element before moveParagraph moves
the paragraph into the new list element, doApply merges lists after moveParagraph is called.

Test: editing/execCommand/insert-lists-inside-another-list.html

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApply): Modified as described above

  • editing/htmlediting.cpp:

(WebCore::outermostEnclosingList): Added rootNode. Returns the outermost list element,

which is a descendent of rootNode.

  • editing/htmlediting.h:

LayoutTests:

Test to make sure InsertListCommand merges consecutive lists when converting
ordered/unordered lists to the opposite type of lists inside another list.

  • editing/execCommand/insert-lists-inside-another-list-expected.txt: Added.
  • editing/execCommand/insert-lists-inside-another-list.html: Added.
  • editing/execCommand/script-tests/insert-lists-inside-another-list.js: Added.

(testList):

  • platform/mac/editing/execCommand/create-list-from-range-selection-expected.txt:
22:48 Changeset [57953] by simon.fraser@apple.com

2010-04-20 Simon Fraser <simon.fraser@apple.com>

Fix test result after r57913.

  • compositing/iframes/composited-iframe-expected.txt:
22:25 Changeset [57952] by yuzo@google.com

2010-04-20 Yuzo Fujishima <yuzo@google.com>

Unreviewed test skipping for Chromium Win.

Skip editing/pasteboard/copy-backslash-with-euc.html for Chromium Win.
https://bugs.webkit.org/show_bug.cgi?id=36419

  • platform/chromium/test_expectations.txt:
21:55 Changeset [57951] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37776
<rdar://problem/7877716> REGRESSION: When using dvorak, keydown/keyup reports qwerty keyCodes

  • platform/cocoa/KeyEventCocoa.mm: (WebCore::windowsKeyCodeForCharCode): Re-added mapping for Roman letters and punctuation.
  • platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Improved approximation of IE behavior. Keyboard layouts that change location of Roman letters (like AZERTY or Dvorak) also switch their keycodes. Also, restored Safari 4 behavior for punctuation. It's difficult to match Windows for punctuation exactly, because keyboard layouts make arbitrary changes to their keycodes.
21:11 Changeset [57950] by hamaji@chromium.org

Fix a ChangeLog entry.

21:09 Changeset [57949] by hamaji@chromium.org

2010-04-20 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

A backslash in EUC-JP becomes to a yen sign when it is copied
https://bugs.webkit.org/show_bug.cgi?id=36419

Add editing/pasteboard/copy-backslash-with-euc into Gtk's skipped list.

  • platform/gtk/Skipped:
20:54 Changeset [57948] by dbates@webkit.org

2010-04-20 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=37748

Make Sheriffbot more inspirational.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
20:31 Changeset [57947] by tkent@chromium.org

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Import Chromium image_diff as ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=37790

ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/ImageDiff.cpp: Added.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
18:13 Changeset [57946] by xan@webkit.org

2010-04-20 Xan Lopez <xlopez@igalia.com>

Another attempt to fix the build.

  • GNUmakefile.am:
18:13 Changeset [57945] by andersca@apple.com

Don't paint the web page before we've blit the last update chunk to the backing store.

Reviewed by Sam Weinig.

  • UIProcess/win/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::update):
(WebKit::DrawingAreaProxy::didReceiveMessage):

  • UIProcess/win/DrawingAreaProxy.h:
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk):
(WebKit::DrawingAreaUpdateChunk::display):
(WebKit::DrawingAreaUpdateChunk::scheduleDisplay):
(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didUpdate):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.h:
17:54 Changeset [57944] by xan@webkit.org

2010-04-20 Xan Lopez <xlopez@igalia.com>

Build fix?

  • autotools/webkit.m4:
17:50 Changeset [57943] by oliver@apple.com

Fix license on create_regex_tables

17:47 Changeset [57942] by oliver@apple.com

Fix gtk

17:09 Changeset [57941] by andersca@apple.com

Fix build.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::receivedData):

16:51 Changeset [57940] by hamaji@chromium.org

2010-04-20 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler and Alexey Proskuryakov.

A backslash in EUC-JP becomes to a yen sign when it is copied
https://bugs.webkit.org/show_bug.cgi?id=36419

  • editing/execCommand/transpose-backslash-with-euc-expected.txt: Added.
  • editing/execCommand/transpose-backslash-with-euc.html: Added.
  • editing/pasteboard/copy-backslash-with-euc-expected.txt: Added.
  • editing/pasteboard/copy-backslash-with-euc.html: Added.
  • editing/pasteboard/resources/copy-backslash-euc.html: Added.

2010-04-20 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler and Alexey Proskuryakov.

A backslash in EUC-JP becomes to a yen sign when it is copied
https://bugs.webkit.org/show_bug.cgi?id=36419

Tests: editing/execCommand/transpose-backslash-with-euc.html

editing/pasteboard/copy-backslash-with-euc.html

  • editing/Editor.cpp: Remove an unnecessary displayStringModifiedByEncoding calls. (WebCore::Editor::addToKillRing):
  • editing/TextIterator.cpp: TextIterator can use RenderText::textWithoutTranscoding and now plainText() uses this version (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::init): (WebCore::TextIterator::emitText): (WebCore::plainTextToMallocAllocatedBuffer):
  • editing/TextIterator.h: (WebCore::):
  • platform/mac/PasteboardMac.mm: Remove an unnecessary displayStringModifiedByEncoding call. (WebCore::Pasteboard::writeSelection):
  • platform/text/TextEncoding.h: Make backslashAsCurrencySymbol public.
  • rendering/RenderText.cpp: Add RenderText::textWithoutTranscoding (WebCore::RenderText::RenderText): (WebCore::RenderText::updateNeedsTranscoding): (WebCore::RenderText::styleDidChange): (WebCore::isInlineFlowOrEmptyText): (WebCore::RenderText::previousCharacter): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::textWithoutTranscoding): (WebCore::RenderText::transformText):
  • rendering/RenderText.h:
  • rendering/RenderTextControl.cpp: Remove an unnecessary displayStringModifiedByEncoding call. (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::finishText):
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::previousCharacter):
  • rendering/RenderTextFragment.h:
16:42 Changeset [57939] by scherkus@chromium.org

2010-04-20 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, updating Chromium test_expectations for media/video-zoom.html.

  • platform/chromium/test_expectations.txt:
16:27 Changeset [57938] by jamesr@google.com

2010-04-20 James Robinson <jamesr@chromium.org>

Unreviewed. Update chromium expectations. Also consolidate identical
platform expectations for fast/dom/prototype-inheritance.html.

  • platform/chromium-linux/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/prototype-inheritance-expected.txt.
  • platform/chromium/test_expectations.txt:
16:22 Changeset [57937] by oliver@apple.com

Fix gtk

16:18 Changeset [57936] by japhet@chromium.org

2010-04-20 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=37367

Fix style violations in code generated by CodeGeneratorV8.pm.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/test/V8TestObj.cpp:
  • bindings/v8/test/V8TestObj.h:
15:57 Changeset [57935] by ossy@webkit.org

Unreviewed, rolling out r57924.
http://trac.webkit.org/changeset/57924
https://bugs.webkit.org/show_bug.cgi?id=37898

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-04-20
It broke 3-4 test on all bot (Requested by Ossy on #webkit).

WebCore:

  • page/AbstractView.idl:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::media):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/media/lifetime.html:
  • fast/media/matchmedium-query-api.html:
  • fast/media/print-restores-previous-mediatype-expected.txt:
  • fast/media/print-restores-previous-mediatype.html:
15:43 Changeset [57934] by dpranke@chromium.org

2010-04-20 Dirk Pranke <dpranke@chromium.org>

This patch to new-run-webkit-tests adds a --log 'trace' option
that prints out detailed info about a given test as it executes
(where the baselines are, what the expectation is, what we got,
how long it took).

https://bugs.webkit.org/show_bug.cgi?id=37726

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • use the newly exposed TestResult class and implement --log trace
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
    • rename TestStats to TestResult and make it more public, resulting in cleaner code
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
    • add expectation_to_string() as a separate callable function
15:38 Changeset [57933] by andersca@apple.com

2010-04-20 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Don't paint the web page before we've blit the last update chunk to the backing store
https://bugs.webkit.org/show_bug.cgi?id=37896

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: (DrawingAreaMessage::):
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.h:
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: (WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore): (WebKit::DrawingAreaProxyUpdateChunk::update): (WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk): (WebKit::DrawingAreaUpdateChunk::display): (WebKit::DrawingAreaUpdateChunk::scheduleDisplay): (WebKit::DrawingAreaUpdateChunk::setSize): (WebKit::DrawingAreaUpdateChunk::didUpdate): (WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h:
15:34 Changeset [57932] by barraclough@apple.com

JavaScriptCore: Bug 37895 - Share common code from UStringImplBase with StringImpl

Reviewed by Oliver Hunt.

The implementation of StringImpl & UStringImpl is very similar. Restructure
StringImpl to match UStringImpl, moving the flags and length into a base class,
so that this can be shared between both string types to increase code reuse.

(JSC::RopeImpl::RopeImpl):

  • runtime/UStringImpl.h:

(JSC::UStringImpl::UStringImpl):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::characters):

  • wtf/text/StringImplBase.h: Copied from JavaScriptCore/runtime/UStringImpl.h.

(WTF::StringImplBase::length):
(WTF::StringImplBase::operator new):
(WTF::StringImplBase::StringImplBase):

JavaScriptGlue: Bug 37895 - Share common code from UStringImplBase with StringImpl
Add forwarding header.

Reviewed by Oliver Hunt.

  • ForwardingHeaders/wtf/text/StringImplBase.h: Added.

WebCore: Bug 37895 - Share common code from UStringImplBase with StringImpl
Add forwarding header.

Reviewed by Oliver Hunt.

  • ForwardingHeaders/wtf/text/StringImplBase.h: Added.
15:26 Changeset [57931] by abarth@webkit.org

2010-04-20 Adam Barth <abarth@webkit.org>

Unreviewed build fix fro Chromium.

  • loader/DocumentWriter.cpp:

2010-04-20 Adam Barth <abarth@webkit.org>

Unreviewed build fix.

  • Api/qwebframe.cpp: (QWebFrame::setUrl):
15:24 Changeset [57930] by pfeldman@chromium.org

2010-04-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Support live edit while on a breakpoint, preserve breakpoints when adding new lines.

https://bugs.webkit.org/show_bug.cgi?id=37820

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.editScriptLine.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptLine):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleDoubleClick): (WebInspector.TextViewer.prototype._cancelEditingLine):
15:24 Changeset [57929] by simon.fraser@apple.com

2010-04-20 Simon Fraser <simon.fraser@apple.com>

Test fix, no review.

Disable compositing/iframes/composited-iframe.html because compositing is
turned off at runtime on Leopard (based on QuickTime version), so we can't
rely on the result.

  • platform/mac-leopard/Skipped:
15:19 Changeset [57928] by jamesr@google.com

2010-04-20 James Robinson <jamesr@chromium.org>

Reviewed by dglazkov.

Update chromium SVG baselines for r57886
https://bugs.webkit.org/show_bug.cgi?id=37891

  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.txt: Removed.
  • platform/chromium-mac/svg/batik/text/textProperties-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/feDisplacementMap-01-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/non-opaque-filters-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/visibility-override-filter-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/big-sized-filter-2-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/feColorMatrix-values-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/feMerge-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/feOffset-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/filter-on-tspan-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/subRegion-in-userSpace-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/subRegion-one-effect-expected.txt: Removed.
  • platform/chromium-mac/svg/filters/subRegion-two-effects-expected.txt: Removed.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/custom/empty-merge-expected.txt: Removed.
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/chromium-win/svg/custom/feDisplacementMap-01-expected.txt: Removed.
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/chromium-win/svg/custom/invalid-css-expected.txt:
  • platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
  • platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.txt: Removed.
  • platform/chromium-win/svg/custom/text-filter-expected.txt:
  • platform/chromium-win/svg/custom/visibility-override-filter-expected.txt: Removed.
  • platform/chromium-win/svg/filters/big-sized-filter-2-expected.txt: Removed.
  • platform/chromium-win/svg/filters/big-sized-filter-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
  • platform/chromium-win/svg/filters/feComposite-expected.txt:
  • platform/chromium-win/svg/filters/feDisplacementMap-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feMerge-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feMerge-wrong-input-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feOffset-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feTile-expected.txt: Removed.
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.txt: Removed.
  • platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
  • platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.txt: Removed.
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.txt: Removed.
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
15:12 Changeset [57927] by abarth@webkit.org

2010-04-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

This patch separates the begin/write/end cycle of decoding network
bytes and putting them into a document from the rest of the loading
machinery. The code and state required to write bytes into a document
doesn't interact very much with the rest of the loading machinery.

No tests because there is no behavior change (hopefully!).

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::close):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/DocumentWriter.cpp: Added.
  • loader/DocumentWriter.h: Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::setURL): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::didEndDocument): (WebCore::FrameLoader::willSetEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h: (WebCore::FrameLoader::writer): (WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):

2010-04-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
  • src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-04-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-04-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-04-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):

2010-04-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-04-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):
15:09 Changeset [57926] by andersca@apple.com

Fix build.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::chooseIconForFiles):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
15:05 Changeset [57925] by oliver@apple.com

2010-04-20 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Autogenerate yarr character tables
https://bugs.webkit.org/show_bug.cgi?id=37877

Use a python script to automatically generate character tables
for the builtin YARR character classes. This allows us to generate
actual tables as well, by using these tables we can both increase
performance of the check (for complex builtins) and reduce the actual
code size.

4-8% win on string-unpack-code, but lots of noise on other tests so
i'm only confident saying its a 1% win overall.

  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ExtendedAddress::ExtendedAddress):
  • assembler/MacroAssembler.h: (JSC::MacroAssembler::branchTest8):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::branchTest8):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::branchTest8):
  • assembler/X86Assembler.h: (JSC::X86Assembler::cmpb_im): (JSC::X86Assembler::testb_im):
  • bytecode/SamplingTool.cpp: (JSC::SamplingTool::dump):
  • create_regex_tables: Added.
  • yarr/RegexCompiler.cpp: (JSC::Yarr::CharacterClassConstructor::charClass):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::matchCharacterClass): (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
  • yarr/RegexPattern.h: (JSC::Yarr::CharacterClassTable::create): (JSC::Yarr::CharacterClassTable::CharacterClassTable): (JSC::Yarr::CharacterClass::CharacterClass):
15:04 Changeset [57924] by kenneth@webkit.org

Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187

Reviewed by Simon Fraser.

WebCore:

It has been defined that the AbstractView media extension
defined in the CSSOM View spec should be renamed to styleMedia.
This patch does that and updates the current layout tests
making use of it.

  • page/AbstractView.idl:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::styleMedia):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Update layout tests.

  • fast/media/lifetime.html:
  • fast/media/matchmedium-query-api.html:
  • fast/media/print-restores-previous-mediatype.html:
14:50 Changeset [57923] by timothy@apple.com

Fix matching of "file:///*" patterns by not trying to compare the host. The host is
irrelevant for file URLs.

Also fix comparisons to be case insensitive.

https://bugs.webkit.org/show_bug.cgi?id=37889

Reviewed by Dave Hyatt.

  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::parse): Use equalIgnoringCase when comparing for "file" schemes.
(WebCore::UserContentURLPattern::matches): Use equalIgnoringCase when comparing schemes. Only call
matchesHost if the scheme isn't "file".
(WebCore::UserContentURLPattern::matchesHost): Call equalIgnoringCase when comparing hosts. The endsWith
was already doing a case-insensitive compare, so existing tests worked though this path.

14:42 Changeset [57922] by japhet@chromium.org

2010-04-20 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Invalid cast due to <video> inside <foreignObject> inside <svg> inside <img>
https://bugs.webkit.org/show_bug.cgi?id=37331

Added a setting to enable/disable media per-page and have the SVGImage
disable media for its dummy page. Also found and fixed a related bad
cast in the V8 bindings (JSC had a custom wrapper for this already).

Tests: media/svg-as-image-with-media-blocked.html

14:32 Changeset [57921] by tonikitoo@webkit.org

Spatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut when FocusCandidate is null
https://bugs.webkit.org/show_bug.cgi?id=37802

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

In updateFocusCandidateIfCloser method, we do all bail out checks in the begining of
the method body. If after those bail out checks, no "best FocusCandidate" has been taken
yet (i.e. focusCandidate.isNull() == true), we can safely take the current candidate,
and exit earlier.

No behavior change, it is just a safe assignment shortcut.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

14:29 Changeset [57920] by eric@webkit.org

2010-04-20 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r57907.
http://trac.webkit.org/changeset/57907
https://bugs.webkit.org/show_bug.cgi?id=37765

Appears to have broken MacEWS and possibly webkit-patch upload
for svn users. Needs further investigation.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/commitinfo.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/statusserver.py:
  • Scripts/webkitpy/common/prettypatch.py:
  • Scripts/webkitpy/common/system/autoinstall.py:
  • Scripts/webkitpy/common/system/deprecated_logging.py:
  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/postdiffforcommit.py:
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
14:24 Changeset [57919] by simon.fraser@apple.com

2010-04-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Hook compositing layers together across iframes
https://bugs.webkit.org/show_bug.cgi?id=37878

First step: if an iframe's document goes into compositing mode, also throw the parent
document into compositing mode (all the way up to the root). This is required both
to preserve layering (since parent document content can obscure iframe content),
and so that we can eventually hook the layer trees together.

Test: compositing/iframes/composited-iframe.html

  • rendering/RenderIFrame.h:
  • rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::requiresLayer): In order to make an iframe composited, it also has to have a RenderLayer, so must return |true| from requiresLayer(). (WebCore::RenderIFrame::requiresAcceleratedCompositing): Returns true if the content document is in compositing mode. (WebCore::RenderIFrame::isRenderIFrame): Required so that RenderLayerCompositor can check if a renderer is an iframe. (WebCore::toRenderIFrame): Required so that RenderLayerCompositor can cast to a RenderIFrame.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): Call out to the RenderView when the compositing mode changes, so that the parent document can update its compositing status. (WebCore::RenderLayerCompositor::requiresCompositingLayer): Call requiresCompositingForIFrame(). (WebCore::RenderLayerCompositor::requiresCompositingForIFrame): Check to see if the iframe wants to be composited.
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderIFrame): Base class returns false.
  • rendering/RenderView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::compositingStateChanged): New method that allows an iframe to notify its parent document that a recalcStyle is required, to update compositing state.
14:17 Changeset [57918] by japhet@chromium.org

2010-04-20 Nate Chapin <japhet@chromium.org>

Unreviewed.

Update my irc handle in committers.py (natechapin -> japhet).

  • Scripts/webkitpy/common/config/committers.py:
14:13 Changeset [57917] by barraclough@apple.com
  • wtf/text/AtomicString.h:

Reviewed by NOBODY (speculative windows fix - missed a bit!).

14:12 Changeset [57916] by dimich@chromium.org

worker-close.html is flaky on slow machines.
https://bugs.webkit.org/show_bug.cgi?id=37887

Reviewed by Adam Barth.

  • fast/workers/worker-close.html: Move the start of the timer to terminate the test after an expected message is received.
14:03 Changeset [57915] by jamesr@google.com

2010-04-20 James Robinson <jamesr@chromium.org>

Unreviewed. Another round of chromium test expectation SVG updates.

  • platform/chromium/test_expectations.txt:
13:58 Changeset [57914] by barraclough@apple.com
  • wtf/text/AtomicString.h:

Reviewed by NOBODY (speculative windows fix).

13:41 Changeset [57913] by simon.fraser@apple.com

2010-04-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

backgroundColor is oddly indented in layer tree dump
https://bugs.webkit.org/show_bug.cgi?id=37885

The writeIndent() was mistakenly outside the LayerTreeAsTextDebug clause, causing indents
to be written twice.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
13:33 Changeset [57912] by barraclough@apple.com

JavaScriptCore: Add missing .def file entries.

Reviewed by NOBODY (windows build fix).

WebCore: Speculative tiger build fix.

Reviewed by NOBODY (build fix).

  • WebCore.NPAPI.exp:
  • WebCore.PluginHostProcess.exp:
  • WebCore.base.exp:
13:23 Changeset [57911] by barraclough@apple.com

Speculative tiger build fix.

Reviewed by NOBODY (build fix).

  • WebCore.NPAPI.exp:
  • WebCore.PluginHostProcess.exp:
  • WebCore.base.exp:
13:22 Changeset [57910] by jamesr@google.com

2010-04-20 James Robinson <jamesr@chromium.org>

Unreviewed. Fix typo in chromium test expectations.

  • platform/chromium/test_expectations.txt:
13:18 Changeset [57909] by pfeldman@chromium.org

2010-04-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add basic script editing capabilities to the front-end.

https://bugs.webkit.org/show_bug.cgi?id=37875

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype._editLine): (WebInspector.ScriptView.prototype._editLineComplete):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype.canEditScripts): (WebInspector.ScriptsPanel.prototype.editScriptLine):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.updateContent): (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
  • inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.reset):
  • inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.prototype.copyRange):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.set editCallback): (WebInspector.TextViewer.prototype._buildChunks): (WebInspector.TextViewer.prototype._handleKeyDown): (WebInspector.TextViewer.prototype._handleDoubleClick): (WebInspector.TextViewer.prototype._commitEditingLine): (WebInspector.TextViewer.prototype._cancelEditingLine):
  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown): (WebInspector.log.logMessage): (WebInspector.log): (WebInspector.isEditingAnyField): (WebInspector.startEditing.cleanUpAfterEditing):

2010-04-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add basic script editing capabilities to the front-end.

https://bugs.webkit.org/show_bug.cgi?id=37875

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.resolveScriptSource): (devtools.DebuggerAgent.prototype.editScriptLine.this.requestSeqToCallback_.cmd.getSequenceNumber): (devtools.DebuggerAgent.prototype.editScriptLine): (devtools.DebuggerAgent.prototype.handleDebuggerOutput_):
  • src/js/DevTools.js:
  • src/js/InspectorControllerImpl.js: (.devtools.InspectorBackendImpl.prototype.editScriptLine):
13:06 Changeset [57908] by barraclough@apple.com

Add missing .def file entries.

Reviewed by NOBODY (windows build fix).

12:54 Changeset [57907] by eric@webkit.org

2010-04-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
https://bugs.webkit.org/show_bug.cgi?id=37765

I fixed the queue to not ignore Tor as a reviwer in r57531,
but instead it throws an exception every time his name is in a patch.

This fixes our Executive.run_command code to work around a Popen
bug http://bugs.python.org/issue5290 whereby python versions before 2.6
do not correctly handle unicode objects as input or output to
Popen.communicate.

Following the advice of:
http://farmdev.com/talks/unicode/
I'm attempting to take the python unicode plunge and use unicode()
objects as strings instead of str() objects everywhere in webkitpy.

We do not have to use u"" instead of "" because u"a" == "a" as expected
in Python. Python will generate a warning to the console in cases where
a unicode() == str() operation cannot be performed.

I also cleaned up the input handling in run_command a little by adding
a new _compute_input() method which can return early instead of having
such a long/cluttered if-block.

Executive.run* now correctly accept and return unicode() objects.
I attempted to fix all the places that we call .write() to make sure we
encode any unicode() objects into utf-8.

All places which use StringIO need to be sure to pass StringIO a
pre-encoded byte-array (str object) instead of unicode so that
clients which read from the StringIO don't have encoding exceptions.
To make this easier, I removed the patch_file_object support from
add_patch_to_bug, and changed the 4 places which previously used
StringIO to create a fake patch file.

I attempted to document any places where we are not correctly converting
to/from bytes (str() objects) to strings (unicode() objects).

  • Scripts/webkitpy/common/checkout/api_unittest.py:
    • Read/write utf-8 files instead of ascii.
    • Update the tests to use test for proper unicode() handling.
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
    • Use unicode() strings instead of str() byte arrays.
  • Scripts/webkitpy/common/checkout/scm.py:
    • Remove use of str().
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Read/write utf-8 files and use unicode() strings in testing.
  • Scripts/webkitpy/common/config/committers.py:
    • Use \u instead of \x to make slightly clearer what we're doing.
  • Scripts/webkitpy/common/net/bugzilla.py:
    • Add a new _string_contents() method and explain why we have to call unicode() on the result of soup.string and why it's safe to do so w/o needing to pass a codec name.
    • Remove the (unused) support for passing a file object to add_patch_to_bug().
  • Scripts/webkitpy/common/net/buildbot.py:
    • Use unicode() instead of str() when needing to coax a NavigableString object into a unicode() object.
  • Scripts/webkitpy/common/net/statusserver.py:
    • Remove use of str()
  • Scripts/webkitpy/common/prettypatch.py:
    • Write out the patch file as utf-8.
  • Scripts/webkitpy/common/system/autoinstall.py:
    • Add a FIXME about encoding.
  • Scripts/webkitpy/common/system/deprecated_logging.py:
    • Document that tee() works on bytes, not strings.
  • Scripts/webkitpy/common/system/executive.py:
    • Make run* properly take and return unicode() objects.
  • Scripts/webkitpy/common/system/executive_unittest.py:
    • Added a unit test to make sure we don't break Tor again!
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Write out the test list as utf-8.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
    • Write out json files as utf-8.
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
    • Add FIXME about encoding handling.
  • Scripts/webkitpy/tool/commands/upload.py:
    • Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
  • Scripts/webkitpy/tool/mocktool.py:
    • Rename add_patch_to_bug argument to match bugzilla.py
  • Scripts/webkitpy/tool/steps/postdiff.py:
    • Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
  • Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto.
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto.
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
    • Fixed spurious logging seen when running test-webkitpy
12:52 Changeset [57906] by jamesr@google.com

2010-04-20 James Robinson <jamesr@chromium.org>

Unreviewed. Update chromium test expectations to reflect changes
in SVG tests from r57886.

  • platform/chromium/test_expectations.txt:
12:42 PythonGuidelines edited by cjerdonek@webkit.org
Stubbed out section on strings and unicode. (diff)
12:34 Changeset [57905] by eric@webkit.org

2010-04-20 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

For check-webkit-style, implemented eq() and ne() (the
built-in equality and inequality methods) for the
DefaultStyleErrorHandler class.

https://bugs.webkit.org/show_bug.cgi?id=37850

This will facilitate unit-testing for a subsequent patch,
namely for https://bugs.webkit.org/show_bug.cgi?id=37850

  • Scripts/webkitpy/style/error_handlers.py:
    • Added eq() and ne() to the DefaultStyleErrorHandler class.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Added unit tests for eq() and ne().
    • Also included a minor clean-up refactoring of combining the StyleErrorHandlerTestBase class (which has not needed to be separate due to previous changes) into the DefaultStyleErrorHandlerTest class.
12:28 Changeset [57904] by barraclough@apple.com

Bug 37828 - Move WebCore's String classes to WTF

Reviewed by Geoff Garen.

Move these classes up to WTF so they are available to all clients of WTF (in
particular JSC).

As a first patch, making the most minimal change possible, since this patch
could easily grow rather large since we'll have to change every class forward
declaration ( e.g. every "namespace WebCore { class String; }" much change to
"namespace WTF { class String; }").

JavaScriptCore:

Moving the files, but leaving the classes logically in the WebCore namespace -
which is technically a layering violation - I'll come back and fix this up in a
subsequent patch.

  • Android.mk:
  • Android.v8.wtf.mk:
  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • config.h:
  • wtf/StaticConstructors.h: Copied from WebCore/platform/StaticConstructors.h.
  • wtf/text/AtomicString.cpp: Copied from WebCore/platform/text/AtomicString.cpp.
  • wtf/text/AtomicString.h: Copied from WebCore/platform/text/AtomicString.h.
  • wtf/text/AtomicStringImpl.h: Copied from WebCore/platform/text/AtomicStringImpl.h.
  • wtf/text/StringBuffer.h: Copied from WebCore/platform/text/StringBuffer.h.
  • wtf/text/StringHash.h: Copied from WebCore/platform/text/StringHash.h.
  • wtf/text/StringImpl.cpp: Copied from WebCore/platform/text/StringImpl.cpp.
  • wtf/text/StringImpl.h: Copied from WebCore/platform/text/StringImpl.h.
  • wtf/text/WTFString.cpp: Copied from WebCore/platform/text/String.cpp.

(WebCore::charactersToFloat):

  • wtf/text/WTFString.h: Copied from WebCore/platform/text/PlatformString.h.

WebCore:

Moving the files, but leaving the classes logically in the WebCore namespace –
which is technically a layering violation – I'll come back and fix this up in a
subsequent patch.

  • Android.mk:
  • ForwardingHeaders/wtf/StaticConstructors.h: Added.
  • ForwardingHeaders/wtf/text/AtomicString.h: Added.
  • ForwardingHeaders/wtf/text/AtomicStringImpl.h: Added.
  • ForwardingHeaders/wtf/text/StringBuffer.h: Added.
  • ForwardingHeaders/wtf/text/StringHash.h: Added.
  • ForwardingHeaders/wtf/text/StringImpl.h: Added.
  • ForwardingHeaders/wtf/text/WTFString.h: Added.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/MediaFeatureNames.cpp:
  • dom/QualifiedName.cpp:
  • dom/make_names.pl:
  • platform/StaticConstructors.h: Removed.
  • platform/text/AtomicString.cpp: Removed.
  • platform/text/AtomicString.h:
  • platform/text/AtomicStringImpl.h:
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:
  • platform/text/StringHash.h:
  • platform/text/StringImpl.cpp: Removed.
  • platform/text/StringImpl.h:
12:20 Changeset [57903] by eric@webkit.org

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

Change PassRefPtr<FileChooser> parameter of chooseIconForFiles()
to FileChooser*. Though an implementation of chooseIconForFiles()
might have ownership of the FileChooser instance, we don't need to
use PassRefPtr<> in this case.

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::chooseIconForFiles):
  • page/Chrome.cpp: (WebCore::Chrome::chooseIconForFiles):
  • page/Chrome.h:
  • page/ChromeClient.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles):
  • src/ChromeClientImpl.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::chooseIconForFiles):
  • WebCoreSupport/ChromeClientGtk.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::chooseIconForFiles):
  • WebCoreSupport/ChromeClientHaiku.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::chooseIconForFiles):

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::chooseIconForFiles):
  • WebCoreSupport/ChromeClientQt.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::chooseIconForFiles):
  • WebCoreSupport/WebChromeClient.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::chooseIconForFiles):
  • WebKitSupport/ChromeClientWx.h:
12:08 Changeset [57902] by eric@webkit.org

2010-04-20 Diego Escalante Urrelo <descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449

Implement ATK_ROLE_FORM.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
11:52 Changeset [57901] by mrobinson@webkit.org

2010-04-20 Martin Robinson <mrobinson@webkit.org>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Move most of the PasteboardHelper logic into WebCore. This helps
prepare for WebKit2 and leads to a clearer separation of concerns
between the WebKit and WebCore layers.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::collapseSelection): Converted this logic to a GClosure callback. (WebKit::EditorClient::respondToChangedSelection): Collapse selection via GClosure now.
  • WebCoreSupport/PasteboardHelperGtk.cpp: Moved most of the code to WebCore. (WebKit::PasteboardHelperGtk::PasteboardHelperGtk): This constructor just initializes the target list. (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk): The destructor no longer needs to free the target list. (WebKit::PasteboardHelperGtk::getIdForTargetType): Added, virtual method for getting target ids. (WebKit::PasteboardHelperGtk::usePrimarySelectionClipboard): Added, virtual method for querying current clipboard.
  • WebCoreSupport/PasteboardHelperGtk.h: Update method list to reflect reduced functionality.

2010-04-20 Martin Robinson <mrobinson@webkit.org>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Move most of the PasteboardHelper logic into WebCore. This helps
prepare for WebKit2 and leads to a clearer separation of concerns
between the WebKit and WebCore layers.

No new tests as functionality has not changed.

  • GNUmakefile.am: Add PastboardHelper.cpp to list of sources.
  • platform/Pasteboard.h: Added a getter for the PasteboardHelper and made the member private.
  • platform/gtk/PasteboardGtk.cpp: Update PasteboardHelper method calls to use new naming. (WebCore::clipboard_get_contents_cb): Ditto. (WebCore::Pasteboard::helper): Added, member is now private. (WebCore::Pasteboard::writeURL): Ditto. (WebCore::Pasteboard::documentFragment): Update to reflect method renaming. (WebCore::Pasteboard::plainText): Ditto.
  • platform/gtk/PasteboardHelper.cpp: Added. (WebCore::PasteboardHelper::PasteboardHelper): Added. (WebCore::PasteboardHelper::~PasteboardHelper): Added. (WebCore::PasteboardHelper::initializeTargetList): Added, originally from WebKit. (WebCore::widgetFromFrame): Added helper function. (WebCore::PasteboardHelper::getCurrentClipboard): Added, originally from WebKit. (WebCore::PasteboardHelper::getClipboard): Ditto. (WebCore::PasteboardHelper::getPrimarySelectionClipboard): Ditto. (WebCore::PasteboardHelper::targetList): Ditto. (WebCore::PasteboardHelper::fillSelectionData): Ditto. (WebCore::PasteboardHelper::targetListForDataObject): Ditto. (WebCore::getClipboardContentsCallback): Ditto. (WebCore::clearClipboardContentsCallback): Ditto. (WebCore::PasteboardHelper::writeClipboardContents): Ditto.
  • platform/gtk/PasteboardHelper.h: Moved methods from WebKit to WebCore.
11:22 Changeset [57900] by simon.fraser@apple.com

2010-04-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dimitri Glazkov.

Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741

RenderPartObject is a useless intermediate class between RenderPart and
RenderEmbeddedObject, and we can now remove it. Its only method, viewCleared(),
applies to objects and embeds when the content is a FrameView, so can move
to RenderEmbeddedObject.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject): (WebCore::RenderEmbeddedObject::requiresLayer): (WebCore::RenderEmbeddedObject::paint): (WebCore::RenderEmbeddedObject::viewCleared):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFrameBase.h:
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart):
  • rendering/RenderPart.h:
  • rendering/RenderPartObject.cpp: Removed.
  • rendering/RenderPartObject.h: Removed.
11:15 Changeset [57899] by scherkus@chromium.org

2010-04-20 Sergey Ulanov <sergeyu@chromium.org>

Unreviewed, checking in baselines due to changes to Chromium's video scaling algorithm.

  • platform/chromium-linux/media/video-replaces-poster-expected.checksum:
  • platform/chromium-linux/media/video-replaces-poster-expected.png:
  • platform/chromium-mac/media/video-replaces-poster-expected.checksum:
  • platform/chromium-mac/media/video-replaces-poster-expected.png:
  • platform/chromium-win/media/video-replaces-poster-expected.checksum:
  • platform/chromium-win/media/video-replaces-poster-expected.png:
  • platform/chromium-win/media/video-zoom-expected.checksum: Added.
  • platform/chromium-win/media/video-zoom-expected.png: Added.
  • platform/chromium-win/media/video-zoom-expected.txt: Added.
11:00 Changeset [57898] by jwieczorek@webkit.org

2010-04-20 Jakub Wieczorek <jwieczorek@webkit.org>

Unreviewed.

Add my IRC nick to the committers.py list.

  • Scripts/webkitpy/common/config/committers.py:
10:41 Changeset [57897] by hausmann@webkit.org

[Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
https://bugs.webkit.org/show_bug.cgi?id=37816

Patch by Kim Grönholm <kim.gronholm@nomovok.com> on 2010-04-20
Reviewed by Simon Hausmann.

Fix multi-touch mocking in QtLauncher when using QGraphicsView.
Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955

  • QtLauncher/main.cpp:

(LauncherWindow::eventFilter):
(LauncherWindow::initializeView):

10:31 Changeset [57896] by krit@webkit.org

2010-04-20 Robin Cao <robin.webkit@gmail.com>

Reviewed by Dirk Schulze.

SVG no AnimateColor for stroke or fill if they are set to none on target.
https://bugs.webkit.org/show_bug.cgi?id=36718

SVGAnimateElement::resetToBaseValue reset 'm_propertyType' in the process of animation.
This will cause problems when attributes 'fill' and 'stroke' have the value 'none', because in this case
the property type determined by base value may be different from the one determined by 'fromTo' values.

No new tests. The test suite in svg/animation is not working for target element with attribute 'fill' set to 'none'.
Now animateColor on target element with attributes 'fill' and 'stroke' set to 'none' is possible.

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::resetToBaseValue):

2010-04-20 Robin Cao <robin.webkit@gmail.com>

Reviewed by Dirk Schulze.

Update expected results after bug fix: https://bugs.webkit.org/show_bug.cgi?id=36718
now animateColor on target element with attributes 'fill' and 'stroke' set to 'none' is possible.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum: Updated.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Updated.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Updated.
  • svg/custom/animation-currentColor.svg: Updated.
09:09 Changeset [57895] by simon.fraser@apple.com

2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57892.
http://trac.webkit.org/changeset/57892
https://bugs.webkit.org/show_bug.cgi?id=37864

Caused an assertion in Mac builds (Requested by smfr on
#webkit).

  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
  • page/Frame.cpp: (WebCore::Frame::ownerRenderer):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::clear): (WebCore::FrameView::invalidateRect): (WebCore::FrameView::createScrollbar):
  • rendering/RenderFrameBase.h:
  • rendering/RenderObject.h:

2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57892.
http://trac.webkit.org/changeset/57892
https://bugs.webkit.org/show_bug.cgi?id=37864

Caused an assertion in Mac builds (Requested by smfr on
#webkit).

  • WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]):
  • WebView/WebFrameView.mm: (-[WebFrameView _install]):
08:54 Changeset [57894] by morrita@google.com

2010-04-20 MORITA Hajime <morrita@google.com>

Unreviewed, add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
08:12 Changeset [57893] by jwieczorek@webkit.org

2010-04-20 Jakub Wieczorek <jwieczorek@webkit.org>

Reviewed by Darin Adler.

RenderListItem: change enclosingList() to only traverse the render tree.
https://bugs.webkit.org/show_bug.cgi?id=37319

This makes the function safe to use for items with nodes that are detached from
the DOM tree and simplifies the code quite a bit.

Covered by existing tests.

  • rendering/RenderListItem.cpp: (WebCore::enclosingList): (WebCore::previousListItem): (WebCore::RenderListItem::explicitValueChanged):
08:06 Changeset [57892] by simon.fraser@apple.com

2010-04-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741

Make Frame::ownerRenderer() return a RenderFrameBase* rather than a
RenderPart*, and add the necessary toRenderFrameBase() and isRenderFrameBase().

  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
  • page/Frame.cpp: (WebCore::Frame::ownerRenderer):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::clear): (WebCore::FrameView::invalidateRect): (WebCore::FrameView::createScrollbar):
  • rendering/RenderFrameBase.h: (WebCore::RenderFrameBase::isRenderFrameBase): (WebCore::toRenderFrameBase):
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderFrameBase):
07:58 Changeset [57891] by eric@webkit.org

2010-04-20 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Pressing tab now closes the select popup as it should.
https://bugs.webkit.org/show_bug.cgi?id=37721

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::handleKeyEvent):

2010-04-20 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Tests that pressing tab now closes the select popup.
https://bugs.webkit.org/show_bug.cgi?id=37721

  • tests/PopupMenuTest.cpp: (WebKit::TEST_F):
07:50 Changeset [57890] by aroben@apple.com

Unskip xss-DENIED-mime-type-execute-as-html.html on Windows

This is essentially a rollout of r57729. I was hoping that skipping
this test would fix the spurious timeouts described in
<http://webkit.org/b/37714>, but that hasn't happened.

  • platform/win/Skipped:
07:16 Changeset [57889] by eric@webkit.org

2010-04-20 Yaar Schnitman <yaar@chromium.org>

Reviewed by Nate Chapin.

Null value should be legit value for wrapped types. This requires some cleanup in canvas which was missing built-in null argument checks;
https://bugs.webkit.org/show_bug.cgi?id=37810

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): Passes ec to drawImage(3) too
  • bindings/scripts/CodeGeneratorV8.pm: A null value is now legit value for wrapped types.
  • bindings/v8/test/V8TestObj.cpp: (WebCore::TestObjInternal::overloadedMethodCallback):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Added null checks. (WebCore::CanvasRenderingContext2D::createPattern): Added null checks.
  • html/canvas/CanvasRenderingContext2D.h: Added needed raises "DOMException".
  • html/canvas/CanvasRenderingContext2D.idl: Added needed raises "DOMException".
06:44 Changeset [57888] by eric@webkit.org

2010-04-20 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

[chromium] crash when dragging images
https://bugs.webkit.org/show_bug.cgi?id=37715

NULL check the return value of nativeImageForCurrentFrame(),
and NULL check Image just for good measure.

Tested by new DragImageTest unit test.

  • platform/chromium/DragImageChromiumSkia.cpp: (WebCore::createDragImageFromImage):

2010-04-20 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

[chromium] crash when dragging images
https://bugs.webkit.org/show_bug.cgi?id=37715

Added unit tests for DragImageChromiumSkia.

  • WebKit.gyp:
  • tests/DragImageTest.cpp: Added. (WebCore::TestImage::TestImage): (WebCore::TestImage::~TestImage): (WebCore::TestImage::size): (WebCore::TestImage::nativeImageForCurrentFrame): (WebCore::TestImage::destroyDecodedData): (WebCore::TestImage::decodedSize): (WebCore::TestImage::draw): (WebCore::TEST):
06:23 Changeset [57887] by eric@webkit.org

2010-04-20 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by David Levin.

Remove a workaround in plugin cursor setting that was obsoleted by
the change in https://bugs.webkit.org/show_bug.cgi?id=35132
https://bugs.webkit.org/show_bug.cgi?id=37811

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::ChromeClientImpl): (WebKit::ChromeClientImpl::setCursor): (WebKit::ChromeClientImpl::setCursorForPlugin):
  • src/ChromeClientImpl.h:
06:14 PythonGuidelines edited by cjerdonek@webkit.org
Added single quote/double quote example. (diff)
05:57 PythonGuidelines edited by cjerdonek@webkit.org
Added unittest naming convention. (diff)
05:52 Changeset [57886] by krit@webkit.org

2010-04-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceFilter needs to be moved to under Renderers
https://bugs.webkit.org/show_bug.cgi?id=35320

This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
from the SVGResources.
A clean-up solves the dependencies between SVGFilterElement, the filter primitives
and SVGResources. This shall make the filter code more readable and better maintable.
The Filter primitives get dumped now, as long as they have externalRepresentation
implemented.

No behavior changes, so no new tests were added.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint): (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGResource.h: (WebCore::): (WebCore::RenderSVGResource::postApplyResource):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: Added. (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::invalidateClients): (WebCore::RenderSVGResourceFilter::invalidateClient): (WebCore::RenderSVGResourceFilter::buildPrimitives): (WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize): (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource): (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h: Added. (WebCore::FilterData::FilterData): (WebCore::RenderSVGResourceFilter::renderName): (WebCore::RenderSVGResourceFilter::filterUnits): (WebCore::RenderSVGResourceFilter::primitiveUnits): (WebCore::RenderSVGResourceFilter::resourceType):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint):
  • rendering/RenderSVGText.cpp:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::deregisterFromResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources): (WebCore::writeRenderResources):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBox::paint):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::build):
  • svg/SVGFETurbulenceElement.h: (WebCore::):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::createRenderer):
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect): (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
  • svg/graphics/SVGResource.cpp:
  • svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer):
  • svg/graphics/SVGResourceFilter.cpp: Removed.
  • svg/graphics/SVGResourceFilter.h: Removed.
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::externalRepresentation):
  • svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::namedEffects):

2010-04-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceFilter needs to be moved to under Renderers
https://bugs.webkit.org/show_bug.cgi?id=35320

All SVG tests with filters need an update. A new renderer for
SVGFilterElement was created. This renderer also dumps filter
primitives as long as they have externalRepresentation implemented.

  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/custom/empty-merge-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/text-filter-expected.txt:
  • platform/mac/svg/custom/visibility-override-filter-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-2-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • platform/mac/svg/filters/feComposite-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feGaussianBlur-expected.txt:
  • platform/mac/svg/filters/feMerge-expected.txt:
  • platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/mac/svg/filters/feOffset-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filter-clip-expected.txt:
  • platform/mac/svg/filters/filter-on-tspan-expected.txt:
  • platform/mac/svg/filters/filter-source-position-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/filters/shadow-on-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/mac/svg/filters/sourceAlpha-expected.txt:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt:
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/filters/filter-source-position-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
05:46 Changeset [57885] by ossy@webkit.org

[Qt] Unreviewed speculative buildfix for WinCE after r57882
https://bugs.webkit.org/show_bug.cgi?id=37701

04:33 Changeset [57884] by barraclough@apple.com

Speculative Chromium/Win build fix, attempt #2.

Reviewed by NOBODY (build fix).

  • config.h:
04:19 Changeset [57883] by barraclough@apple.com

Speculative Chromium/Win build fix.

Reviewed by NOBODY (build fix).

  • config.h: JS_EXPORTDATA should do nothing on !JSC builds.
04:16 Changeset [57882] by ossy@webkit.org

[Qt] Target(WebCore,jsc,...) must depends on static library of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=37701

Reviewed by Simon Hausmann.

03:37 Changeset [57881] by eric@webkit.org

2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57880.
http://trac.webkit.org/changeset/57880
https://bugs.webkit.org/show_bug.cgi?id=37846

Broke several bots, FEDisplacmentMap dumps includes pointers,
no one noticed. Dirk will upload a new patch later. (Requested
by WildFox on #webkit).

  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/custom/empty-merge-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/text-filter-expected.txt:
  • platform/mac/svg/custom/visibility-override-filter-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-2-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • platform/mac/svg/filters/feComposite-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feGaussianBlur-expected.txt:
  • platform/mac/svg/filters/feMerge-expected.txt:
  • platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/mac/svg/filters/feOffset-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filter-clip-expected.txt:
  • platform/mac/svg/filters/filter-on-tspan-expected.txt:
  • platform/mac/svg/filters/filter-source-position-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/filters/shadow-on-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/mac/svg/filters/sourceAlpha-expected.txt:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt:
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt:

2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57880.
http://trac.webkit.org/changeset/57880
https://bugs.webkit.org/show_bug.cgi?id=37846

Broke several bots, FEDisplacmentMap dumps includes pointers,
no one noticed. Dirk will upload a new patch later. (Requested
by WildFox on #webkit).

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint): (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGResource.h: (WebCore::):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: Removed.
  • rendering/RenderSVGResourceFilter.h: Removed.
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint):
  • rendering/RenderSVGText.cpp:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::deregisterFromResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources): (WebCore::writeRenderResources):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBox::paint):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::build):
  • svg/SVGFETurbulenceElement.h: (WebCore::):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::buildFilter): (WebCore::SVGFilterElement::canvasResource):
  • svg/SVGFilterElement.h: (WebCore::SVGFilterElement::rendererIsNeeded):
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect): (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
  • svg/graphics/SVGResource.cpp:
  • svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isFilter):
  • svg/graphics/SVGResourceFilter.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::filterBoundingBox): (WebCore::shouldProcessFilter): (WebCore::SVGResourceFilter::addFilterEffect): (WebCore::SVGResourceFilter::fitsInMaximumImageSize): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter): (WebCore::SVGResourceFilter::externalRepresentation): (WebCore::getFilterById):
  • svg/graphics/SVGResourceFilter.h: Added. (WebCore::SVGResourceFilter::create): (WebCore::SVGResourceFilter::resourceType): (WebCore::SVGResourceFilter::setFilterResolution): (WebCore::SVGResourceFilter::setHasFilterResolution): (WebCore::SVGResourceFilter::filterBoundingBoxMode): (WebCore::SVGResourceFilter::setFilterBoundingBoxMode): (WebCore::SVGResourceFilter::effectBoundingBoxMode): (WebCore::SVGResourceFilter::setEffectBoundingBoxMode): (WebCore::SVGResourceFilter::filterRect): (WebCore::SVGResourceFilter::setFilterRect): (WebCore::SVGResourceFilter::scaleX): (WebCore::SVGResourceFilter::scaleY): (WebCore::SVGResourceFilter::setFilterBoundingBox): (WebCore::SVGResourceFilter::builder):
  • svg/graphics/filters/SVGFilterBuilder.h:
02:45 Changeset [57880] by krit@webkit.org

2010-04-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceFilter needs to be moved to under Renderers
https://bugs.webkit.org/show_bug.cgi?id=35320

This patch adds a renderer for SVGFilterElement. SVGFilterElement is now independent
from the SVGResources.
A clean-up solves the dependencies between SVGFilterElement, the filter primitives
and SVGResources. This shall make the filter code more readable and better maintable.
The Filter primitives get dumped now, as long as they have externalRepresentation
implemented.

No behavior changes, so no new tests were added.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint): (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGResource.h: (WebCore::):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: Added. (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::invalidateClients): (WebCore::RenderSVGResourceFilter::invalidateClient): (WebCore::RenderSVGResourceFilter::buildPrimitives): (WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize): (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource): (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h: Added. (WebCore::FilterData::FilterData): (WebCore::RenderSVGResourceFilter::renderName): (WebCore::RenderSVGResourceFilter::filterUnits): (WebCore::RenderSVGResourceFilter::primitiveUnits): (WebCore::RenderSVGResourceFilter::resourceType):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint):
  • rendering/RenderSVGText.cpp:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::deregisterFromResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::writeSVGResource): (WebCore::writeResources): (WebCore::writeRenderResources):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBox::paint):
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::build):
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::build):
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build):
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build):
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::build):
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::build):
  • svg/SVGFETurbulenceElement.h: (WebCore::):
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::createRenderer):
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::isFilterEffect): (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::invalidateResources):
  • svg/graphics/SVGResource.cpp:
  • svg/graphics/SVGResource.h: (WebCore::): (WebCore::SVGResource::isPaintServer):
  • svg/graphics/SVGResourceFilter.cpp: Removed.
  • svg/graphics/SVGResourceFilter.h: Removed.
  • svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::namedEffects):

2010-04-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGResourceFilter needs to be moved to under Renderers
https://bugs.webkit.org/show_bug.cgi?id=35320

All SVG tests with filters need an update. A new renderer for
SVGFilterElement was created. This renderer also dumps filter
primitives as long as they have externalRepresentation implemented.

  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/custom/empty-merge-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/text-filter-expected.txt:
  • platform/mac/svg/custom/visibility-override-filter-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-2-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • platform/mac/svg/filters/feComposite-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feGaussianBlur-expected.txt:
  • platform/mac/svg/filters/feMerge-expected.txt:
  • platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/mac/svg/filters/feOffset-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filter-clip-expected.txt:
  • platform/mac/svg/filters/filter-on-tspan-expected.txt:
  • platform/mac/svg/filters/filter-source-position-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/filters/shadow-on-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/mac/svg/filters/sourceAlpha-expected.txt:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt:
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt:
01:30 Changeset [57879] by barraclough@apple.com

Rubber stamped by Maciej Stachowiak (relanding r57829).
Added missing JS_EXPORTDATA

JavaScriptCore:

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/Identifier.cpp:

(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):

  • runtime/Identifier.h:
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::create):

  • wtf/WTFThreadData.cpp: Copied from JavaScriptCore/wtf/WTFThreadData.cpp.
  • wtf/WTFThreadData.h: Copied from JavaScriptCore/wtf/WTFThreadData.h.

JavaScriptGlue:

  • ForwardingHeaders/wtf/WTFThreadData.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/WTFThreadData.h.
  • JSUtils.cpp:

(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

  • ForwardingHeaders/wtf/WTFThreadData.h: Copied from WebCore/ForwardingHeaders/wtf/WTFThreadData.h.
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::eventNames):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable):

01:28 Changeset [57878] by eric@webkit.org

2010-04-20 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216

Remove LayoutTests/animations/fill-mode-transform.html from the skip list

  • platform/qt/Skipped:

2010-04-20 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216
Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
enables a key-frame animation to go to the animation's starting point before the delay,
and/or to stay at the animation's ending point after its ended, without reverting to the default
value.
We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQtBase::AnimationQtBase): (WebCore::TransformAnimationQt::~TransformAnimationQt): (WebCore::TransformAnimationQt::applyFrame): (WebCore::GraphicsLayerQt::addAnimation):
00:30 Changeset [57877] by tkent@chromium.org

Unreviewed.
Attempt to fix fast/forms/interactive-validation-lost-focusable.html failures on non-Mac.

00:15 Changeset [57876] by tkent@chromium.org

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Fix some unexpected results of editing
https://bugs.webkit.org/show_bug.cgi?id=37843

This change fixes about 70 unexpected results.
The original test_webview_delegate.cc doesn't have this bug.
The bug was introduced when I ported it to WebKit tree.

  • DumpRenderTree/chromium/WebViewHost.cpp: (printRangeDescription): Replace the latter startContainer() with endContainer().
00:03 Changeset [57875] by tkent@chromium.org

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

More tests for interactive validation
https://bugs.webkit.org/show_bug.cgi?id=37345

Add tests for cases that event handlers modify DOM structures.
These improve test coverage for r57346.

  • fast/forms/checkValidity-handler-updates-dom-expected.txt: Added.
  • fast/forms/checkValidity-handler-updates-dom.html: Added.
  • fast/forms/interactive-validation-lost-focusable-expected.txt: Added.
  • fast/forms/interactive-validation-lost-focusable.html: Added.
  • fast/forms/script-tests/checkValidity-handler-updates-dom.js: Added.

04/19/10:

23:39 Changeset [57874] by eric@webkit.org

2010-04-19 Diego Escalante Urrelo <descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449

Expand testatkroles to test ATK form roles.

  • tests/testatkroles.c: (test_webkit_atk_get_role_check_box): (test_webkit_atk_get_role_entry): (test_webkit_atk_get_role_label): (test_webkit_atk_get_role_listbox): (test_webkit_atk_get_role_password_text): (test_webkit_atk_get_role_push_button): (test_webkit_atk_get_role_radio_button): (main):
23:30 Changeset [57873] by eric@webkit.org

2010-04-19 Leandro Pereira <leandro@profusion.mobi>

Reviewed by David Hyatt.

Add missing dummy implementations in PluginPackageNone and PluginViewNone.
http://webkit.org/b/37478

  • plugins/PluginPackageNone.cpp: (WebCore::PluginPackage::NPVersion): Add dummy implementation.
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::handleFocusInEvent): Add dummy implementation. (WebCore::PluginView::handleFocusOutEvent): Add dummy implementation.
23:18 Changeset [57872] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Turn off some unit tests for now - the new-run-webkit-tests dryrun
tests for chromium won't work if you don't have a chromium checkout.

https://bugs.webkit.org/show_bug.cgi?id=37841

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
23:00 Changeset [57871] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

(Re-)add dryrun.py; this was renamed from passing.py in the previous
CL but apparently somehow didn't get checked in.

https://bugs.webkit.org/show_bug.cgi?id=37841

  • Scripts/webkitpy/layout_tests/port/dryrun.py: Added.
22:41 Changeset [57870] by hamaji@chromium.org

2010-04-19 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

check-webkit-style: exits when encountering a deleted file
https://bugs.webkit.org/show_bug.cgi?id=37122

This reverts the quick fix done by r57119 and makes check_patch
not call check_file for deleted files.

Also this change fixes the behavior for "-", which should mean
stdin. Before this change, the style checker just ignored "-"
with a warning message.

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
22:10 Changeset [57869] by dbates@webkit.org

2010-04-19 Daniel Bates <dbates@rim.com>

No review, rolling out 57868.
http://trac.webkit.org/changeset/57868
https://bugs.webkit.org/show_bug.cgi?id=37748

Sheriffbot wasn't very inspirational after this patch.
Instead, he was silent when you said hi :-(. Rolling
out this patch so that I can debug/test this some more.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
21:34 Changeset [57868] by dbates@webkit.org

2010-04-19 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=37748

Make Sheriffbot more inspirational.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
21:22 Changeset [57867] by simon.fraser@apple.com

2010-04-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Geoff Garen.

Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741

Move m_hasFallbackContent from RenderPart to RenderEmbeddedObject,
since it's only used for <object> fallback.

  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
  • rendering/RenderEmbeddedObject.h: (WebCore::RenderEmbeddedObject::hasFallbackContent):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart):
  • rendering/RenderPart.h:
21:02 Changeset [57866] by simon.fraser@apple.com

2010-04-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741

Add a new renderer for iframes, named RenderIFrame. Add a new shared base class
between this and RenderFrame, called RenderFrameBase (following the existing HTMLFrameElementBase),
and move code from RenderPart and RenderPartObject into these new classes.


There should be no functionality difference with this change, so no new tests.


Fixing up renderer names in the layout tests will be done in a later pass.


Fix build systems to include the new files.


  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::createRenderer):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::RenderFrame):
  • rendering/RenderFrame.h:
  • rendering/RenderFrameBase.cpp: Added. (WebCore::RenderFrameBase::RenderFrameBase): (WebCore::RenderFrameBase::layoutWithFlattening):
  • rendering/RenderFrameBase.h: Added.
  • rendering/RenderIFrame.cpp: Added. (WebCore::RenderIFrame::RenderIFrame): (WebCore::RenderIFrame::calcHeight): (WebCore::RenderIFrame::calcWidth): (WebCore::RenderIFrame::flattenFrame): (WebCore::RenderIFrame::layout):
  • rendering/RenderIFrame.h: Added. (WebCore::RenderIFrame::renderName):
  • rendering/RenderPart.cpp:
  • rendering/RenderPart.h:
  • rendering/RenderPartObject.cpp:
  • rendering/RenderPartObject.h:
20:59 Changeset [57865] by dumi@chromium.org

Bindings clean-up.
https://bugs.webkit.org/show_bug.cgi?id=37833

Reviewed by Geoffrey Garen.

Move some WebSQLDatabases logic out of the bindings into
DOMWindow.cpp where it should be.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

19:59 Changeset [57864] by kevino@webkit.org

Fix the Mac builders for now by restoring the keepAlive function.

19:10 Changeset [57863] by kevino@webkit.org

Build fixes for wx with latest trunk.

18:43 Changeset [57862] by jamesr@google.com

2010-04-19 James Robinson <jamesr@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
17:56 Changeset [57861] by jberlin@webkit.org

Remove an extra space in the getComputedStyle-with-psuedo-element test that was causing it to fail on the Chromium bots, and remove the platform-specific results that were landed in the meantime.

Reviewed by Dan Bernstein.

  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
  • platform/chromium-linux/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Removed.
  • platform/chromium-win/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Removed.
17:53 Changeset [57860] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
that can be used to test platforms other than the one you are running
on. This can be useful for checking baselines and testing code
coverage.

Note that running the code on the "wrong" port requires each
port-specific implementation to actually not require any
platform-specific python code (e.g., the chromium-win port must
test for the existence of windows functions before calling them).

https://bugs.webkit.org/show_bug.cgi?id=37782

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
17:34 Changeset [57859] by mrowe@apple.com

Touch WebKit.idl to force generated interfaces to be rebuilt. Boo.

17:33 Changeset [57858] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add --build (default) and --no-build
options to make that step optional. This flag modifies what happens
in port.check_build().

https://bugs.webkit.org/show_bug.cgi?id=37786

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
17:24 Changeset [57857] by jamesr@google.com

2010-04-19 James Robinson <jamesr@chromium.org>

Unreviewed. Update chromium test expectations.

  • platform/chromium/test_expectations.txt:
17:16 Changeset [57856] by mrowe@apple.com

Roll out r57823.

It adds methods to IWebFrameLoadDelegatePrivate2, a delegate interface that is implemented
by shipping clients of WebKit on Windows. Adding methods to a delegate interface in this
manner breaks ABI compatibility and leads to crashes or other unexpected behavior when the
methods are used.

16:35 Changeset [57855] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests - fix a typo in r57480 that caused us to stop
logging the actual list of unexpected results.

https://bugs.webkit.org/show_bug.cgi?id=37831

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16:30 Changeset [57854] by andersca@apple.com

Fix build.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidChangeIcons):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
16:26 Changeset [57853] by barraclough@apple.com

This broke windows.

Reviewed by NOBODY (rolling out r57829).

JavaScriptCore:

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/Identifier.cpp:

(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):

  • runtime/Identifier.h:

(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::create):

  • wtf/WTFThreadData.cpp: Removed.
  • wtf/WTFThreadData.h: Removed.

JavaScriptGlue:

  • ForwardingHeaders/wtf/WTFThreadData.h: Removed.
  • JSUtils.cpp:

(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

  • ForwardingHeaders/wtf/WTFThreadData.h: Removed.
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::atomicStringTable):

  • platform/text/AtomicString.cpp:

(WebCore::stringTable):

16:24 Changeset [57852] by mrowe@apple.com

Build fix.

  • platform/graphics/mac/GraphicsContext3DMac.cpp:
16:10 Changeset [57851] by andersca@apple.com

Reviewed and landed by Anders Carlsson.

Patch by Douglas Gregor <dgregor@apple.com> on 2010-04-19

  • runtime/UStringImpl.h:

Fix class/struct declaration mismatches.

16:05 Changeset [57850] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

From a patch by Tor Arne Vestbo <tor.arne.vestbo@nokia.com>

new-run-webkit-tests: make the retry step more explicit
https://bugs.webkit.org/show_bug.cgi?id=37606

It might be confusing to see the test and percent counters
reset without any notice of what's going on, so we make the
message that a retry-run is started explicit.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15:59 Changeset [57849] by weinig@apple.com

Add support for opening a new window (File->New Window) to
Windows MiniBrowser. Accelerator doesn't work.

Reviewed by Anders Carlsson.

  • MiniBrowser/win/BrowserView.cpp:

(createNewPage): Use BrowserView::create.

  • MiniBrowser/win/BrowserWindow.cpp:

(BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
by creating a new window.

  • MiniBrowser/win/BrowserWindow.h:

(BrowserWindow::create): Added. Don't allow creating
BrowserWindows on the stack by making constructor
private and exposing the create function.

  • MiniBrowser/win/MiniBrowser.cpp:

(MiniBrowser::createNewWindow): Move new window creation
logic here.

  • MiniBrowser/win/MiniBrowser.h:
  • MiniBrowser/win/MiniBrowser.rc:
  • MiniBrowser/win/main.cpp:

(_tWinMain): Use the new MiniBrowser::createNewWindow().

15:54 QtWebKitGraphics edited by noam.rosenthal@nokia.com
(diff)
15:27 Changeset [57848] by cfleizach@apple.com

2010-04-19 Chris Fleizach <cfleizach@apple.com>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
https://bugs.webkit.org/show_bug.cgi?id=37808

Test: platform/mac/accessibility/element-haspopup.html

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::ariaHasPopup):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::ariaHasPopup): (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

2010-04-19 Chris Fleizach <cfleizach@apple.com>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
https://bugs.webkit.org/show_bug.cgi?id=37808

  • platform/mac/accessibility/element-haspopup-expected.txt: Added.
  • platform/mac/accessibility/element-haspopup.html: Added.

2010-04-19 Chris Fleizach <cfleizach@apple.com>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
https://bugs.webkit.org/show_bug.cgi?id=37808

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::hasPopup):
15:09 Changeset [57847] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Submit a better workaround for r57806 than the one in r57831 - log
an error and exit if you try to run new-run-webkit-tests with --use-drt
on Windows.

https://bugs.webkit.org/show_bug.cgi?id=37822

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:03 Changeset [57846] by jesus@webkit.org

Unreviewed.

Just adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
14:59 Changeset [57845] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Add slightly better logging to the websocket python wrapper script,
including a --verbose flag for debug output.

https://bugs.webkit.org/show_bug.cgi?id=37233

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/new-run-webkit-websocketserver:
14:57 Changeset [57844] by andersca@apple.com

Fix a crash when rendering <select> elements with WebKit2.

Reviewed by Sam Weinig.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuList):
Set the current NSGraphicsContext before calling out to AppKit, otherwise the current graphics context
could point to a CGContext whose memory has been freed.

14:56 Changeset [57843] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add a way (--print-unexpected-results) to
(re-)print out the tests that produced unexpected results in the
last run. Also add a way (--retry-unexpected-results) to
automatically re-test them.

https://bugs.webkit.org/show_bug.cgi?id=37783

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:48 Changeset [57842] by jamesr@google.com

2010-04-19 James Robinson <jamesr@chromium.org>

Unreviewed, move chromium baselines for fast/url around.

The desired behavior is that chromium-win use one set of baselines and
chromium-mac/chromium-linux use another, however to do we have to
duplicate the mac+linux results into chromium-mac and chromium-linux.

  • platform/chromium-linux/fast/url/file-expected.txt: Added.
  • platform/chromium-linux/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium-linux/fast/url/relative-win-expected.txt: Added.
  • platform/chromium-mac/fast/url/file-expected.txt: Added.
  • platform/chromium-mac/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium-mac/fast/url/relative-win-expected.txt: Added.
  • platform/chromium/fast/url/file-expected.txt: Removed.
  • platform/chromium/fast/url/relative-unix-expected.txt: Removed.
  • platform/chromium/fast/url/relative-win-expected.txt: Removed.
14:41 Changeset [57841] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Restructure the logging in new-run-webkit-tests so that many of log
messages that were logged to the MeteredStream also get logged in
--verbose mode.

https://bugs.webkit.org/show_bug.cgi?id=37780

  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:39 Changeset [57840] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: add 'summary' and 'unexpected-results' options
to the --log flag. Also add a 'progress' flag to enable the regular
progress bar (as opposed to 'detailed-progress', which enables the
dots). Also add a 'nothing' flag to allow you to be explicit that
you don't want any logging on the command line.

The default is
'--log detailed-progress,summary,unexpected,unexpected-results'

(The default logging is unchanged by this patch, this just makes things
properly configurable).

Note that 'nothing' doesn't work properly yet; I need a couple other
patches to land to avoid rewriting things several different ways.

https://bugs.webkit.org/show_bug.cgi?id=37785

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:15 Changeset [57839] by dglazkov@chromium.org

Manipulating document fragment members while adding it to tree may result in loss of tree integrity.
https://bugs.webkit.org/show_bug.cgi?id=36031

Reviewed by Darin Adler.

WebCore:

Changes the logic of appending/inserting document fragment to first stashing all of its children
to a vector, then processing the vector. This avoids ghastliness that would be caused by mutation
events mucking with the document fragment while it's being appended/inserted.

Test: fast/dom/Node/fragment-mutation.html

  • dom/ContainerNode.cpp:

(WebCore::targetNodes): Added method to populate a vector of nodes (targets) to be used in

inserting/appending operation.

(WebCore::ContainerNode::insertBefore): Changed to use vector-based iteration.
(WebCore::ContainerNode::appendChild): Ditto.

  • dom/Node.cpp:

(WebCore::Node::checkReplaceChild): Cleaned up comments.
(WebCore::Node::checkAddChild): Ditto.

LayoutTests:

These tests study various side-effects of DOM mutation events fired during appending/inserting
document fragments.

  • fast/dom/Node/fragment-mutation-expected.txt: Added.
  • fast/dom/Node/fragment-mutation.html: Added.
14:10 Changeset [57838] by jamesr@google.com

2010-04-19 James Robinson <jamesr@chromium.org>

Unreviewed - yet more rebaselines and expectation updates.

  • platform/chromium-win/fast/url/file-expected.txt: Added.
  • platform/chromium-win/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium-win/fast/url/relative-win-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:07 Changeset [57837] by ggaren@apple.com

Checked in these tests I wrote becuase Balazs Kelemen wanted to use them.

Reviewed by Beth Dakin.

  • tests/perf: Added.
  • tests/perf/bench-allocate-nonretained.js: Added.
  • tests/perf/bench-allocate-retained.js: Added.
13:56 Changeset [57836] by kenneth@webkit.org

Make the URL change on committed load.

Reviewed by Simon Hausmann.

  • QtLauncher/mainwindow.cpp:

(MainWindow::buildUI):
(MainWindow::setAddressUrl):

  • QtLauncher/mainwindow.h:
13:51 Changeset [57835] by barraclough@apple.com

Reviewed by NOBODY (windows build fix).

13:50 Changeset [57834] by jamesr@google.com

2010-04-19 James Robinson <jamesr@chromium.org>

Unreviewed. More chromium rebaselines+expectation updates.

  • platform/chromium-linux/fast/css/getComputedStyle: Added.
  • platform/chromium-linux/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
  • platform/chromium-mac/media/video-src-change-expected.txt:
  • platform/chromium-mac/media/video-src-invalid-remove-expected.txt: Removed.
  • platform/chromium-win/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
  • platform/chromium-win/media/video-src-change-expected.txt:
  • platform/chromium-win/media/video-src-invalid-remove-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
13:35 Changeset [57833] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Fix a typo in the rebaselining tool that causes us to use "debug"
instead of "Debug" in a directory path, which fails on platforms with
case-sensitive filesystems.

https://bugs.webkit.org/show_bug.cgi?id=37819

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
13:20 Changeset [57832] by jamesr@google.com

2010-04-19 James Robinson <jamesr@chromium.org>

Unreviewed build fix.

Update chromium expectations

  • platform/chromium/test_expectations.txt:
13:17 Changeset [57831] by dpranke@chromium.org

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix breakage of chromium-win canary bots caused by r57806. That patch
introduced the option of using Chrome's new port of DumpRenderTree,
but unfortunately that port relies on the webkit.py class
implementation which uses non-blocking I/O that isn't available on
Windows. This patch turns off that option and doesn't import the
class if we're running on Windows.

https://bugs.webkit.org/show_bug.cgi?id=37817

  • Scripts/webkitpy/layout_tests/port/chromium.py:
13:12 Changeset [57830] by eric.carlson@apple.com

2010-04-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix regression introduced in r57820.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loadNextSourceChild): Create a new MediaPlayer instead of just setting a URL on the one used for the previous <source> element. This restores the behavior prior to the changes for https://bugs.webkit.org/show_bug.cgi?id=37728.
13:05 Changeset [57829] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=37745
Move string uniquing tables to (new) WTFThreadData class.

Reviewed by Sam Weinig.

Remove AtomicString's dependency on ThreadGlobalData so that we can move
WebCore's string classes up to WTF.

JavaScriptCore:

WTFThreadData.cpp/.h are based on ThreadGlobalData from WebCore.
Moved JSC & WebCore's string uniquing tables to this class.

This patch introduces a temporary layering violation in providing forward
declarations of classes from JSC and WTF; this will be resolved as we move
more string code up to WTF.

  • API/APIShims.h:

(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/Identifier.cpp:

(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):

  • runtime/Identifier.h:
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::create):

  • wtf/WTFThreadData.cpp: Copied from WebCore/platform/ThreadGlobalData.cpp.

(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

  • wtf/WTFThreadData.h: Copied from WebCore/platform/ThreadGlobalData.h.

(WTF::WTFThreadData::atomicStringTable):
(WTF::WTFThreadData::initializeIdentifierTable):
(WTF::WTFThreadData::currentIdentifierTable):
(WTF::WTFThreadData::setCurrentIdentifierTable):
(WTF::WTFThreadData::resetCurrentIdentifierTable):
(WTF::wtfThreadData):

JavaScriptGlue:

  • ForwardingHeaders/wtf/WTFThreadData.h: Added.
  • JSUtils.cpp: Update

(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

  • ForwardingHeaders/wtf/WTFThreadData.h: Added.
  • platform/ThreadGlobalData.cpp: Remove m_atomicStringTable, all wtfThreadData() to ensure threadsafely initialized.

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):

  • platform/ThreadGlobalData.h: Remove m_atomicStringTable.

(WebCore::ThreadGlobalData::eventNames):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable): Access the AtomicStringTable on wtfThreadData() rather then threadGlobalData().

13:00 CommitterTips edited by jesus@webkit.org
There is no more "--no-build" option anymore. (diff)
12:36 Changeset [57828] by jamesr@google.com

2010-04-19 James Robinson <jamesr@chromium.org>

Reviewed by abarth.

Fix a typo

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
12:29 Changeset [57827] by jamesr@google.com

2010-04-19 James Robinson <jamesr@chromium.org>

Unreviewed build fix for Chromium

Add baselines for new platform-specific tests.

  • platform/chromium/fast/url: Added.
  • platform/chromium/fast/url/file-expected.txt: Added.
  • platform/chromium/fast/url/relative-expected.txt: Added.
  • platform/chromium/fast/url/relative-unix-expected.txt: Added.
  • platform/chromium/fast/url/relative-win-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:13 Changeset [57826] by adachan@apple.com

Build fix: wrap Settings::setLocalStorageQuota() and Settings::setSessionStorageQuota()
in #if ENABLE(DOM_STORAGE).

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
12:13 Changeset [57825] by aroben@apple.com

Fix run-webkit-tests when there are spaces in the path

Fixes <http://webkit.org/b/37809>

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: Use an "indirect object" to specify the

path to the harness to exec(). According to perldoc, this usage will
prohibit perl from parsing the arguments to exec() via the shell,
which would incorrectly split paths with spaces in them, etc.

12:01 Changeset [57824] by dglazkov@chromium.org

Touch WebKit.idl to force a rebuild of Interfaces.vcproj

11:49 Changeset [57823] by dglazkov@chromium.org

WebCore: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

Test: fast/dom/icon-url-property.html

  • dom/Document.cpp:

(WebCore::Document::setIconURL):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setIconURL):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::iconURL):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setIconURL):
(WebCore::FrameLoader::didChangeIcons):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

WebKit/chromium: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::didChangeIcons):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):

  • src/FrameLoaderClientImpl.h:

WebKit/gtk: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidChangeIcons):

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidChangeIcons):

WebKit/qt: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
(WebCore::FrameLoaderClientQt::didChangeTitle):

  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

  • Interfaces/IWebFrameLoadDelegatePrivate2.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidChangeIcons):

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:

(WebFrame::didChangeIcons):

  • WebFrame.h:

WebKitTools: Add test support for icon changes.

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(dumpIconChangesCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::dumpIconChanges):
(LayoutTestController::setDumpIconChanges):

  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::didChangeIcons):

  • DumpRenderTree/win/FrameLoadDelegate.h:
  • WinLauncher/WinLauncher.h:

(WinLauncherWebHost::didChangeIcons):

LayoutTests: Add test for icon change notifications.

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

  • fast/dom/icon-url-property-expected.txt: Added.
  • fast/dom/icon-url-property.html: Added.
  • Skipped on all platforms but Win
11:37 Changeset [57822] by adachan@apple.com

WebCore: https://bugs.webkit.org/show_bug.cgi?id=37717
Allow clients concerned with memory consumption to set a quota on session storage
since the memory used won't be released until the Page is destroyed.
The default is noQuota, which matches the current behavior.

Reviewed by Jeremy Orlow.

  • WebCore.base.exp: Export Settings::setSessionStorageQuota().
  • page/Page.cpp:

(WebCore::Page::sessionStorage):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageQuota):

  • page/Settings.h:

(WebCore::Settings::sessionStorageQuota):

  • storage/StorageNamespace.cpp:

(WebCore::StorageNamespace::sessionStorageNamespace):

  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::sessionStorageNamespace):

  • storage/StorageNamespaceImpl.h:

WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=37717
Changes needed now that StorageNamespaceImpl::sessionStorageNamespace() and
StorageNamespace::sessionStorageNamespace() take in a quota parameter.

Reviewed by Jeremy Orlow.

  • src/StorageNamespaceProxy.cpp:

(WebCore::StorageNamespace::sessionStorageNamespace):

  • src/WebStorageNamespaceImpl.cpp:

(WebKit::WebStorageNamespace::createSessionStorageNamespace):

11:34 Changeset [57821] by hausmann@webkit.org

[Qt] Build fix for WinCE.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-04-19
Reviewed by Simon Hausmann.

Moved the include of the non-existing errno.h header file inside
platform guard macros.

  • jit/ExecutableAllocatorFixedVMPool.cpp:
11:28 Changeset [57820] by eric.carlson@apple.com

2010-04-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Setting media element 'src' attribute should trigger immediate load
https://bugs.webkit.org/show_bug.cgi?id=37728

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Schedule load every time 'src' attribute changes unless it is missing. (WebCore::HTMLMediaElement::prepareForLoad): Include steps 3 to 6 from loadInternal. (WebCore::HTMLMediaElement::loadInternal): Steps 3 to 6 are now in prepareForLoad. (WebCore::HTMLMediaElement::loadResource): MediaPlayer is now allocated in prepareForLoad so the previously loading file, if any, is cancelled there.

2010-04-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Setting media element 'src' attribute should trigger immediate load
https://bugs.webkit.org/show_bug.cgi?id=37728

  • media/event-attributes-expected.txt: Updated results.
  • media/event-attributes.html: Do not need to call load().
  • media/video-source-add-src-expected.txt: Removed.
  • media/video-source-add-src.html: Removed.
  • media/video-src-change-expected.txt: Updated results.
  • media/video-src-change.html: Update test to match current behavior.
  • media/video-src-invalid-remove-expected.txt: Updated results.
  • media/video-src-invalid-remove.html: Update test to match current behavior.
11:07 Changeset [57819] by hausmann@webkit.org

[Qt] Fix compilation against namespaced Qt.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-04-19
Reviewed by Simon Hausmann.

WebCore:

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/Tile.h:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
  • platform/network/qt/NetworkStateNotifierPrivate.h:

WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/QtFallbackWebPopup.h:
11:00 Changeset [57818] by eric@webkit.org

2010-04-19 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Destroy SharedTimerQt before destruction of QCoreApplication.

To avoid unsafe situations caused by running WebCore code (through firing timers) when destruction of QCoreApplication
has been started, we should explicitly destroy the SharedTimerQt instance on application exit.
We can achieve that through installing a self-destroying slot for the QCoreApplication::aboutToQuit() signal
into the SharedTimerQt instance.

https://bugs.webkit.org/show_bug.cgi?id=36832

No functional change so no new tests.

  • platform/qt/SharedTimerQt.cpp: (WebCore::SharedTimerQt::SharedTimerQt): (WebCore::SharedTimerQt::destroy): (WebCore::SharedTimerQt::inst):
10:48 Changeset [57817] by mitz@apple.com

Make the fix for <rdar://problem/7873647> from r57759 more robust.

Reviewed by Darin Adler.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateHoverActiveState): Use RefPtrs for the Nodes.

10:43 Changeset [57816] by dglazkov@chromium.org

2010-04-19 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Roben.

WinLauncher.h should use LF line-endings and use native line-endings style.
https://bugs.webkit.org/show_bug.cgi?id=37807

  • WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
10:38 Changeset [57815] by eric@webkit.org

2010-04-19 Diego Escalante Urrelo <descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449

Add and enable the build of testatkroles to test ATK non form roles.

  • GNUmakefile.am:

2010-04-19 Diego Escalante Urrelo <descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449

Add testatkroles to test ATK non form roles.

  • tests/testatkroles.c: Added. (finish_loading): (atk_roles_fixture_setup): (atk_roles_fixture_teardown): (get_child_and_test_role): (test_webkit_atk_get_role_document_frame): (test_webkit_atk_get_role_heading): (test_webkit_atk_get_role_image): (test_webkit_atk_get_role_link): (test_webkit_atk_get_role_list_and_item): (test_webkit_atk_get_role_paragraph): (test_webkit_atk_get_role_section): (test_webkit_atk_get_role_table): (main):
10:21 Changeset [57814] by mitz@apple.com

Finish exposing extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.

Reviewed by Sam Weinig.

  • WebKit.exp: Export _WebHTMLViewPrintingMinimumShrinkFactor and _WebHTMLViewPrintingMaximumShrinkFactor.
10:11 Changeset [57813] by yurys@chromium.org

2010-04-19 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium build fix.

  • bindings/v8/JavaScriptCallFrame.h:
10:01 Changeset [57812] by yurys@chromium.org

2010-04-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement JavaScriptCallFrame that works for v8.
Implementing this binding for v8 allows to make evaluations on
call frames and protects access to the debugger context from
inspected context.

https://bugs.webkit.org/show_bug.cgi?id=37755

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/v8/JavaScriptCallFrame.cpp: Added. (WebCore::JavaScriptCallFrame::JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::~JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::caller): (WebCore::JavaScriptCallFrame::sourceID): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::functionName): (WebCore::JavaScriptCallFrame::scopeChain): (WebCore::JavaScriptCallFrame::scopeType): (WebCore::JavaScriptCallFrame::thisObject): (WebCore::JavaScriptCallFrame::evaluate):
  • bindings/v8/JavaScriptCallFrame.h: Added. (WebCore::JavaScriptCallFrame::create):
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::currentCallFrame):
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp: Added. (WebCore::V8JavaScriptCallFrame::evaluateCallback): (WebCore::V8JavaScriptCallFrame::scopeChainAccessorGetter): (WebCore::V8JavaScriptCallFrame::scopeTypeCallback): (WebCore::V8JavaScriptCallFrame::thisObjectAccessorGetter): (WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
  • inspector/JavaScriptCallFrame.idl:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
09:41 Changeset [57811] by ossy@webkit.org

[Qt] Unskip a bunch of now passing tests, add expected files and pixel results.
Additionally fix some minor pixel differences.

Rubber-stamped by Simon Hausmann.

Compared to Mac png files and Mac expected files.

  • platform/qt/Skipped:
  • platform/qt/fast/frames/frame-navigation-expected.checksum: Added.
  • platform/qt/fast/frames/frame-navigation-expected.png: Added.
  • platform/qt/fast/frames/frame-navigation-expected.txt: Updated.
  • platform/qt/fast/overflow/line-clamp-expected.checksum: Added.
  • platform/qt/fast/overflow/line-clamp-expected.png: Added.
  • platform/qt/fast/overflow/line-clamp-expected.txt: Added.
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.checksum: Added.
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.png: Added.
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.txt: Added.
  • platform/qt/fast/repaint/fixed-tranformed-expected.checksum: Added.
  • platform/qt/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/qt/fast/repaint/fixed-tranformed-expected.txt: Added.
  • platform/qt/fast/repaint/repaint-during-scroll-expected.checksum: Added.
  • platform/qt/fast/repaint/repaint-during-scroll-expected.png: Added.
  • platform/qt/fast/repaint/repaint-during-scroll-expected.txt: Added.
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.checksum: Added.
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.png: Added.
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt: Updated.
  • platform/qt/http/tests/misc/error404-expected.checksum: Added.
  • platform/qt/http/tests/misc/error404-expected.png: Added.
  • platform/qt/http/tests/misc/error404-expected.txt: Added.
  • platform/qt/http/tests/misc/frame-access-during-load-expected.checksum: Added.
  • platform/qt/http/tests/misc/frame-access-during-load-expected.png: Added.
  • platform/qt/http/tests/misc/frame-access-during-load-expected.txt: Added.
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.checksum: Added.
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.png: Added.
  • platform/qt/http/tests/misc/generated-content-inside-table-expected.txt: Added.
  • platform/qt/http/tests/misc/iframe404-expected.checksum: Added.
  • platform/qt/http/tests/misc/iframe404-expected.png: Added.
  • platform/qt/http/tests/misc/iframe404-expected.txt: Added.
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.checksum: Added.
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.png: Added.
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt: Added.
  • platform/qt/http/tests/uri/css-href-expected.checksum: Added.
  • platform/qt/http/tests/uri/css-href-expected.png: Added.
  • platform/qt/http/tests/uri/css-href-expected.txt: Updated.
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.checksum: Added.
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
08:05 Changeset [57810] by jberlin@webkit.org

Rubber Stamped by Adam Roben

Chromium Release Build Fix.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
In the case where the DATALIST is not enabled, fall through to NOPSEUDO instead of omitting PseudoInputListButton entirely from the switch.

06:28 Changeset [57809] by jberlin@webkit.org

First steps towards fixing bug 24021 - pseudo-element styles not accessible / retrievable via DOM methods.
https://bugs.webkit.org/show_bug.cgi?id=24021

Reviewed by Dave Hyatt.

WebCore:

Allows access to the computed styles for the pseudo-elements through the second argument to getComputedStyle.
This approach does not provide the correct values for 'length' properties and does not work for the ':selection' pseudo-element and will instead return results similiar to those returned by Firefox. This approach also requires waiting until at least one iteration of a hardware accelerated composited animation to return the correct values for the "opacity" and "transform" properties of a pseudo-element associated with the element being animated.
Those values need to be retrieved from the renderer for the pseudo-element as opposed to the cached RenderStyle for the element on which the pseudo-element is defined, which is further complicated by the fact that not all elements have renderers.

Test: fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html

  • WebCore.base.exp:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
Parse the and store the pseudo-element specifier from the string provided by the user.
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Get the computed style for the pseudo-element if it has been specified, with a FIXME noting that the values returned for the "opacity" and "transform" properties of a pseudo-element associated with an element being animated and using hardware accelerated compositing will not be correct until after the first iteration of the animation.
(WebCore::CSSComputedStyleDeclaration::length):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
Ditto.

  • css/CSSComputedStyleDeclaration.h:

(WebCore::computedStyle):
Take into consideration the pseudo-element.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
Return the PseudoId that corresponds to the given PseudoType. If there is no corresponding PseudoId, returns NOPSEUDO.
(WebCore::nameToPseudoTypeMap):
Create and return the mapping between string names and PseudoTypes.
(WebCore::CSSSelector::parsePseudoType):
Parse and the given string into a PseudoType.
(WebCore::CSSSelector::extractPseudoType):
Refactored to use parsePseudoType.

  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Refactored to use pseudoId.

  • dom/Element.cpp:

(WebCore::Element::computedStyle):
If the pseudo-element is specified, then return the cached RenderStyle for that PseudoId. Added a FIXME to find the actual renders of the pseudo-elements instead of just the cached RenderStyle of the RenderStyle for the associated element.

  • dom/Element.h:

(WebCore::Element::virtualComputedStyle):
Because Element::computedStyle is used so often, don't make it virtual. Instead, provide a virtualComputedStyle method in the Node.h class andmake computedStyle non-virtual. That way the Element version and the Node version of computedStyle will have the same name and look the same at the call site, but the Element version will be more efficient.

  • dom/Node.h:

(WebCore::Node::computedStyle):
Ditto.

  • dom/Node.cpp:

(WebCore::Node::virtualComputedStyle):
Get the computed style for the pseudo-element if it has been specified.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getComputedStyle):
Ditto.

LayoutTests:

  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html: Added.
04:54 Changeset [57808] by ossy@webkit.org

[Qt] lacks clipToImageBuffer()
https://bugs.webkit.org/show_bug.cgi?id=24289

Skip svg/clip-path tests introduced in r52511,
and move clip related tests here.

  • platform/qt/Skipped:
02:05 Changeset [57807] by tkent@chromium.org

2010-04-19 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Fix a test initialization problem
https://bugs.webkit.org/show_bug.cgi?id=37791

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): Call resetTestController() before runFileTest(). Some controllers initialize their fields in reset() and not in their constructors.
01:52 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
01:40 Changeset [57806] by tkent@chromium.org

2010-04-19 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
https://bugs.webkit.org/show_bug.cgi?id=37793

We need to use WebKitDriver instead of ChromiumDriver for Chromium
DRT because its interface is different from test_shell.

Chromium DRT has no UI. So we can't use it to show test results.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

04/18/10:

23:36 Changeset [57805] by eric@webkit.org

2010-04-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

Make failure-reason more forgiving
https://bugs.webkit.org/show_bug.cgi?id=37525

Removed search_limit, which wasn't very useful anyway.
Added a log about the long load time loading from the builders.
Prompt the user for what revision to start walking from (makes it easy to restart upon failure).

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/tool/commands/queries.py:
22:13 Changeset [57804] by eric@webkit.org

2010-04-18 Kwang Yul Seo <skyul@company100.net>

Reviewed by Laszlo Gombos.

[WINCE] Don't define WTF_CPU_MIDDLE_ENDIAN=1
https://bugs.webkit.org/show_bug.cgi?id=37434

Windows CE supports little-endian format only, so don't define
WTF_CPU_MIDDLE_ENDIAN=1.

  • wtf/Platform.h:
21:26 Changeset [57803] by cjerdonek@webkit.org

Created a class for check-webkit-style that encapsulates iterating
over text files and reading them.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=37754

This revision is an intermediate step towards separating our
style-checking code from the logic of iterating over files and
reading them.

  • Scripts/webkitpy/common/system/logtesting.py:
    • Added a logMessages() method to the LoggingTestCase class. This method provides unit tests with access to the raw list of log messages in case the tester needs to do something more than simply assert the list of existing messages.
  • Scripts/webkitpy/style/checker.py:
    • Added a ProcessorBase class that processors of lists of lines should eventually inherit from.
    • Also added a FIXME to use the ProcessorBase class and the TextFileReader class added below.
  • Scripts/webkitpy/style/filereader.py: Added.
    • Created a TextFileReader class that encapsulates reading and iterating over text files.
  • Scripts/webkitpy/style/filereader_unittest.py: Added.
    • Added a TextFileReaderTest class to unit-test the new TextFileReader class.
21:22 Changeset [57802] by eric@webkit.org

2010-04-18 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix JavaScriptCore's include path for WinCE builds

https://bugs.webkit.org/show_bug.cgi?id=36751

2010-04-18 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix JavaScriptCore's include path for WinCE builds

https://bugs.webkit.org/show_bug.cgi?id=36751

  • WebCore.pro:
21:08 Changeset [57801] by eric@webkit.org

2010-04-18 Michael Forney <michael@mforney.org>

Reviewed by Laszlo Gombos.

https://bugs.webkit.org/show_bug.cgi?id=37762

Fixes the sandbox option in configure.

  • configure.ac: Fix cut and paste error in the sandbox option causing --{enable,disable}-sandbox to be ineffective, and it to be controlled by the ruby flag.
20:26 Changeset [57800] by tony@chromium.org

2010-04-15 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] new-run-webkit-tests should be able to use chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=37645

Make sure that the lack of a chromium checkout doesn't cause the script to
fail.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths

to be relative to an upstream output dir.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
14:25 Changeset [57799] by eric@webkit.org

2010-04-18 Eric Seidel <eric@webkit.org>

Unreviewed, fixing the Qt bot.

Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
https://bugs.webkit.org/show_bug.cgi?id=37632

  • Scripts/run-webkit-tests:
    • Exit non-zero of launching the harness fails.
13:58 Changeset [57798] by eric@webkit.org

2010-04-18 Eric Seidel <eric@webkit.org>

Unreviewed, fixing the Qt bot.

Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
https://bugs.webkit.org/show_bug.cgi?id=37632

  • Scripts/run-webkit-tests:
    • Fix the wrapper to work for users who do not have WebKitTools/Scripts in their path.
13:56 Changeset [57797] by abarth@webkit.org

2010-04-18 Adam Barth <abarth@webkit.org>

Unreviewed. Update a label of the diagram to better match the
description in the text of the blog post.

  • blog-files/loader-diagram.svg:
13:34 Changeset [57796] by eric@webkit.org

2010-04-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add a layer of indirection when calling run-webkit-tests to
allow testing new-run-webkit-tests on various platforms.
https://bugs.webkit.org/show_bug.cgi?id=37632

This will let us test and fix bugs in new-run-webkit-tests
without needing to restart the buildbot master between tests.

Currently this change leaves run-webkit-tests as-is, but once
its landed we will easily be able to turn on/off
new-run-webkit-tests for various ports/configurations.

I will send a note out to webkit-dev about how we will
be using this launcher script to test on the bots.

  • Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
  • Scripts/run-webkit-tests:
    • A new script which decides whether to run new- or old- run-webkit-tests based on the platform.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add some dummy argument handling for arguments which old-run-webkit-tests supports but new-run-webkit-tests does not yet.
10:43 Changeset [57795] by eric@webkit.org

2010-04-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
https://bugs.webkit.org/show_bug.cgi?id=33295

The Gtk builders have been green every time I've looked
at them in the last 5 days or so. It would appear webkit
is now keeping them green and we should update the core
builder list to match reality.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
04:01 Changeset [57794] by robert@webkit.org

[Qt] Add support for LayoutTestController commands

2010-04-18 Robert Hogan <robert@webkit.org>

Unreviewed fix to pixel differences in unskipped layout tests.

[Qt] Add support for LayoutTestController commands

Fix up minor pixel differences on unskipped tests from r57793.

https://bugs.webkit.org/show_bug.cgi?id=35844

  • platform/qt/editing/deleting/smart-delete-003-expected.txt:
  • platform/qt/editing/deleting/smart-delete-004-expected.txt:
  • platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
  • platform/qt/editing/selection/5195166-2-expected.txt:
03:36 Changeset [57793] by robert@webkit.org

[Qt] Add support for LayoutTestController commands
2010-04-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

https://bugs.webkit.org/show_bug.cgi?id=35844

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):
  • Api/qwebpage_p.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setSmartInsertDeleteEnabled): (DumpRenderTreeSupportQt::setSelectTrailingWhitespaceEnabled): (DumpRenderTreeSupportQt::executeCoreCommandByName): (DumpRenderTreeSupportQt::isCommandEnabled):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::smartInsertDeleteEnabled): (WebCore::EditorClientQt::toggleSmartInsertDelete): (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
  • WebCoreSupport/EditorClientQt.h:

2010-04-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

Unskip tests:
editing/deleting/smart-editing-disabled.html
editing/execCommand/19089.html
editing/execCommand/delete-image-in-anchor.html
editing/execCommand/enabling-and-selection-2.html
editing/selection/doubleclick-whitespace-crash.html
editing/selection/doubleclick-whitespace-img-crash.html
editing/selection/doubleclick-whitespace.html
editing/selection/select-line.html
editing/deleting/5300379.html
editing/deleting/smart-delete-003.html
editing/deleting/smart-delete-004.html
editing/selection/5195166-1.html
editing/selection/5195166-2.html

https://bugs.webkit.org/show_bug.cgi?id=35844

  • platform/qt/Skipped:
  • platform/qt/editing/deleting/5300379-expected.txt: Update platform-specific results.
  • platform/qt/editing/deleting/smart-delete-003-expected.txt: Update platform-specific results.
  • platform/qt/editing/deleting/smart-delete-004-expected.txt: Update platform-specific results.
  • platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
  • platform/qt/editing/selection/5195166-2-expected.txt: Update platform-specific results.

2010-04-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for LayoutTestController commands:

setSmartInsertDeleteEnabled
setSelectTrailingWhitespaceEnabled
execCommand
isCommandEnabled

https://bugs.webkit.org/show_bug.cgi?id=35844

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): (LayoutTestController::setSelectTrailingWhitespaceEnabled): (LayoutTestController::execCommand): (LayoutTestController::isCommandEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
03:25 Changeset [57792] by tonikitoo@webkit.org

2010-04-18 Antonio Gomes <tonikitoo@webkit.org>

[Qt] Unreviewed fix: remove svg/custom/clip-path-display-none-child.svg from Skipped (non-existent test)

It was removed by r57511.

  • platform/qt/Skipped:

04/17/10:

23:27 Changeset [57791] by abarth@webkit.org

2010-04-17 Adam Barth <abarth@webkit.org>

Unreviewed. Added loader diagram for upcoming blog post.

  • blog-files/loader-diagram.svg: Added.
23:03 Changeset [57790] by ap@apple.com

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=37720
<rdar://problem/7873752> HTMLFrameSetElement-window-eventListener-attributes.html sometimes
crashes on SnowLeopard Release

Tests:

  • fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:
  • fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:
  • bindings/scripts/CodeGeneratorJS.pm: Use global object as a wrapper for window event listeners set via document.body. The body wrapper can go away if nothing else references it.
  • html/HTMLBodyElement.idl: Override listeners that exist on Element with custom implementations, because we need to use window object as a wrapper, not the element. Marked all window event listeners as such for code generator.
  • html/HTMLFrameSetElement.idl: Ditto.
22:00 Changeset [57789] by joepeck@webkit.org

2010-04-17 Juan C. Montemayor <jmonte03@cs.tufts.edu>

Reviewed by Joseph Pecoraro.

Databases pane doesn't recognize table creation/deletion
https://bugs.webkit.org/show_bug.cgi?id=20219

  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
17:42 Changeset [57788] by eric@webkit.org

2010-04-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove steps_references and commands_references
https://bugs.webkit.org/show_bug.cgi?id=37758

We tried using the mumble_references convention to manage our
dependencies, but it doesn't seem to be providing much value for the
steps and commands module because these modules are small pieces of the
larger tool module. In this patch, I've removed the references file
for these modules.

I've left the style_references file for the style module because that
module seems better isolated from the rest of webkitpy and the
style_references file appears to be providing some value.

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/commands_references.py: Removed.
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
  • Scripts/webkitpy/tool/steps_references.py: Removed.
13:43 Changeset [57787] by eric@webkit.org

2010-04-17 Yaar Schnitman <yaar@chromium.org>

Reviewed by Adam Barth.

Auto-generate V8 bindings for canvas.* overloads
https://bugs.webkit.org/show_bug.cgi?id=37453

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Deleted custom code that is now auto-generated.
  • bindings/scripts/CodeGeneratorV8.pm: Not generating custom signatures for overloaded methods and accepting Object as a string input.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Added missing 9-arguments overloads for drawImage.
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl: Overloaded methods defined (V8 only).
13:10 Changeset [57786] by eric@webkit.org

2010-04-17 Adam Barth <abarth@webkit.org>

Unreviewed.

Test file: URL canonicalization
https://bugs.webkit.org/show_bug.cgi?id=37700

Re-land http://trac.webkit.org/changeset/57719, hopefully not breaking
the Windows bot this time.

  • fast/url/file-expected.txt: Added.
  • fast/url/file.html: Added.
  • fast/url/mailto.html:
  • fast/url/script-tests/file.js: Added.
13:00 Changeset [57785] by eric@webkit.org

2010-04-17 Adam Barth <abarth@webkit.org>

Unreviewed, but I took Jeremy Orlow's suggestions on an earlier
iteration of this patch.

Add URL parsing tests for relative URL resolution
https://bugs.webkit.org/show_bug.cgi?id=37644

I've split the platform specific parts of this test into separate
files. On KURL-based ports these should have the same results on every
platform. We can decide whether to have platform-specific behavior at
a later time.

  • fast/url/relative-expected.txt: Added.
  • fast/url/relative-unix-expected.txt: Added.
  • fast/url/relative-unix.html: Added.
  • fast/url/relative-win-expected.txt: Added.
  • fast/url/relative-win.html: Added.
  • fast/url/relative.html: Added.
  • fast/url/script-tests/relative-unix.js: Added.
  • fast/url/script-tests/relative-win.js: Added.
  • fast/url/script-tests/relative.js: Added.
11:42 Changeset [57784] by eric@webkit.org

2010-04-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move JavaScriptCallFrame.{h,cpp} to WebCore/bindings/js

https://bugs.webkit.org/show_bug.cgi?id=37740

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JavaScriptCallFrame.cpp: Renamed from WebCore/inspector/JavaScriptCallFrame.cpp. (WebCore::JavaScriptCallFrame::JavaScriptCallFrame): (WebCore::JavaScriptCallFrame::caller): (WebCore::JavaScriptCallFrame::scopeChain): (WebCore::JavaScriptCallFrame::dynamicGlobalObject): (WebCore::JavaScriptCallFrame::functionName): (WebCore::JavaScriptCallFrame::type): (WebCore::JavaScriptCallFrame::thisObject): (WebCore::JavaScriptCallFrame::evaluate):
  • bindings/js/JavaScriptCallFrame.h: Renamed from WebCore/inspector/JavaScriptCallFrame.h. (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::invalidate): (WebCore::JavaScriptCallFrame::isValid): (WebCore::JavaScriptCallFrame::sourceID): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::update):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorController.h:
09:00 Changeset [57783] by alex@webkit.org

2010-04-17 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping media/audio-constructor-preload.html
https://bugs.webkit.org/show_bug.cgi?id=37753

  • platform/gtk/Skipped:
08:49 Changeset [57782] by alex@webkit.org

2010-04-17 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping inspector/timeline-paint.html
https://bugs.webkit.org/show_bug.cgi?id=37752

  • platform/gtk/Skipped:
08:16 Changeset [57781] by alex@webkit.org

2010-04-17 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

We have to initialize the timer attribute after destroying it, not
doing it was causing crashes in some situations.

  • webkit/webkitdownload.cpp: (webkit_download_finalize):
07:55 Changeset [57780] by eric@webkit.org

2010-04-17 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding definition of GLES2Context class.
https://bugs.webkit.org/show_bug.cgi?id=37541

No new functionality implemented yet, no tests.

  • WebCore.gypi: Added GLES2Context.h
  • platform/chromium/GLES2Context.h: Added.

2010-04-17 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
https://bugs.webkit.org/show_bug.cgi?id=37541

  • WebKit.gyp:
  • public/WebGLES2Context.h: Added. (WebKit::WebGLES2Context::~WebGLES2Context):
  • src/GLES2Context.cpp: Added. (WebCore::GLES2ContextInternal::GLES2ContextInternal): (WebCore::GLES2ContextInternal::~GLES2ContextInternal): (WebCore::GLES2ContextInternal::getWebGLES2Context): (WebCore::GLES2ContextInternal::initialize): (WebCore::GLES2Context::create): (WebCore::GLES2Context::~GLES2Context): (WebCore::GLES2Context::initialize): (WebCore::GLES2Context::makeCurrent): (WebCore::GLES2Context::destroy): (WebCore::GLES2Context::swapBuffers):
06:37 Changeset [57779] by jchaffraix@webkit.org

Crash while handling SVG font in the wrong namespace imported with @font-face
https://bugs.webkit.org/show_bug.cgi?id=18862

Reviewed by Darin Adler.

WebCore:

Test: fast/invalid/invalidSVGFont.html

  • loader/CachedFont.cpp:

(WebCore::CachedFont::getSVGFontById): Make sure we really get an SVGFontElement by using
getElementsByNameNS: the element factory chooses which element to create based on both
localName and namespace.

LayoutTests:

Test that load an SVG document not in the SVG namespace with @font-face does not
lead to a crash.

  • fast/invalid/invalidSVGFont-expected.txt: Added.
  • fast/invalid/invalidSVGFont.html: Added.
  • fast/invalid/resources/svgFontWrongNamespace.svg: Added.
01:13 Changeset [57778] by eric@webkit.org

2010-04-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WebKit needs a Chromium Mac EWS Builder
https://bugs.webkit.org/show_bug.cgi?id=37742

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
01:02 Changeset [57777] by abarth@webkit.org

2010-04-17 Adam Barth <abarth@webkit.org>

Fix expected results for unit test broken by
http://trac.webkit.org/changeset/57772

  • Scripts/webkitpy/common/net/buildbot_unittest.py:

04/16/10:

23:14 Changeset [57776] by ossy@webkit.org

Unreviewed, rolling out r57770.
http://trac.webkit.org/changeset/57770
https://bugs.webkit.org/show_bug.cgi?id=37746

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-04-16
8 test cases crashed (Requested by Ossy on #webkit).

WebCore:

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::AnimationQtBase::AnimationQtBase):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::OpacityAnimationQt::applyFrame):
(WebCore::GraphicsLayerQt::addAnimation):

LayoutTests:

  • platform/qt/Skipped:
21:40 Changeset [57775] by dbates@webkit.org

2010-04-16 Daniel Bates <dbates@rim.com>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=36312

Adds support for the viewport meta tag. The code is largely derived in whole
or in part from the WebCore-528.15 source published as part of the iPhone 3.1.3
source code <http://www.opensource.apple.com/source/WebCore/WebCore-528.15/>.

  • Android.mk: Added file ViewportArguments.cpp.
  • GNUmakefile.am: Added files ViewportArguments.cpp and ViewportArguments.h.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::isSeparator): Added. (WebCore::Document::processArguments): Added. (WebCore::Document::processViewport): Added.
  • dom/Document.h:
  • dom/ViewportArguments.cpp: Added. (WebCore::setViewportFeature): (WebCore::viewportErrorMessageTemplate): (WebCore::viewportErrorMessageLevel): (WebCore::reportViewportWarning):
  • dom/ViewportArguments.h: Added. (WebCore::): (WebCore::ViewportArguments::): (WebCore::ViewportArguments::ViewportArguments): (WebCore::ViewportArguments::hasCustomArgument):
  • html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::process): Modified to call Document::processViewport.
  • page/ChromeClient.h: (WebCore::ChromeClient::didReceiveViewportArguments): Added.
20:23 Changeset [57774] by weinig@apple.com

Remove the need for a .defs file! Define WK_EXPORT.

Reviewed by Jon "The Belly" Honeycutt.

  • UIProcess/API/C/WKBase.h:
  • WebProcess/win/WebProcessMain.h:
  • win/WebKit2.def: Removed.
  • win/WebKit2.vcproj:
20:06 Changeset [57773] by weinig@apple.com

Teach windows MiniBrowser how to work with window.open()
and targeted links.

Reviewed by Adam Roben.

WebKit2:

Export WKPageSetPageUIClient.

  • win/WebKit2.def:

WebKitTools:

  • MiniBrowser/win/BrowserView.cpp:

(createNewPage): Create a new BrowserWindow and return its page.
(showPage): Show the page.
(closePage): Empty implementation.
(runJavaScriptAlert): Empty implementation.
(BrowserView::create): Register a UIClient.

  • MiniBrowser/win/BrowserView.h:

(BrowserView::webView): Added.
Change create to take a BrowserWindow instead of an HWND.

  • MiniBrowser/win/BrowserWindow.cpp:

(BrowserWindow::wndProc): Respond to WM_NCDESTROY.
(BrowserWindow::goToURL): Added. Forwards to BrowserView.
(BrowserWindow::onCreate): Don't always go to the default
url. Let the caller do this.
(BrowserWindow::onNCDestroy): Delete the window.

  • MiniBrowser/win/BrowserWindow.h:

(BrowserWindow::view): Added.
(BrowserWindow::window): Added.

  • MiniBrowser/win/main.cpp:

(_tWinMain):
Go to the default URL for the initial page. Allocate the initial
window on the heap for correctness.

19:53 Changeset [57772] by aroben@apple.com

Add the Windows Debug (Test) builder to the list of core builders

It's been green for a few days now, and all the known Windows
flakiness is Release-only.

Rubber-stamped by Mark Rowe.

  • Scripts/webkitpy/common/net/buildbot.py:

(BuildBot.core_builder_name_regexps): Added a regular expression to
match the "Windows Debug (Test)" builder.

19:30 Changeset [57771] by dumi@chromium.org

Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
https://bugs.webkit.org/show_bug.cgi?id=37733

Reviewed by Eric Seidel.

  • src/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

19:04 Changeset [57770] by eric@webkit.org

2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216

Remove LayoutTests/animations/fill-mode-transform.html from the skip list

  • platform/qt/Skipped:

2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt] GraphicsLayer: support fill-modes
https://bugs.webkit.org/show_bug.cgi?id=36216
Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
enables a key-frame animation to go to the animation's starting point before the delay,
and/or to stay at the animation's ending point after its ended, without reverting to the default
value.
We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQtBase::AnimationQtBase): (WebCore::TransformAnimationQt::~TransformAnimationQt): (WebCore::TransformAnimationQt::applyFrame): (WebCore::GraphicsLayerQt::addAnimation):
17:24 Changeset [57769] by barraclough@apple.com
  • bindings/js/JSDesktopNotificationsCustom.cpp:

(WebCore::JSNotification::addEventListener):
(WebCore::JSNotification::removeEventListener):

Reviewed by NOBODY (arm build fix).

17:20 Changeset [57768] by dumi@chromium.org

Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
https://bugs.webkit.org/show_bug.cgi?id=34466

Reviewed by Jeremy Orlow.

Changing the return type of
WebSecurityOrigin::createFromDatabaseIdentifier() from
WebSecurityOrigin* to WebSecurityOrigin, to make it more
consistent with the other WebSecurityOrigin methods.

  • public/WebSecurityOrigin.h:
  • src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):

17:14 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
17:12 Changeset [57767] by dimich@chromium.org

WebCore: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror.
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Existing worker-close.html will now work in Chromium.

  • bindings/v8/V8Utilities.cpp:

(WebCore::getScriptExecutionContext): Stop using proxy() to just retrieve WorkerContext which should be always available.

  • bindings/v8/WorkerContextExecutionProxy.h: removed workerContext() accessor which moved to WorkerScriptController.
  • bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::workerContext): Added, to be able to pull WorkerContext out from the controller.

WebKit/chromium: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

  • src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext.

LayoutTests: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Moved the expected result into platform-independent chromium subdirectory, since
the only chromium-specific difference is the way v8 formats an error message.
Also updated the expected result to match the passing now test.

  • platform/chromium-win/fast/workers/worker-close-expected.txt: Removed.
  • platform/chromium/fast/workers/worker-close-expected.txt: Added.
17:10 Changeset [57766] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=37735
Remove JSC specific code from WebCore::AtomicString

Reviewed by Sam Weinig.

Add generic constructor/add/find methods that take a UChar* & length, along
with a known existing hash for the string.
This removes the remaining JSC specific code from platform/text.

  • bindings/js/JSAbstractWorkerCustom.cpp:

(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):

  • bindings/js/JSDOMApplicationCacheCustom.cpp:

(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):
(WebCore::findAtomicString):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::childFrameGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):

  • bindings/js/JSElementCustom.cpp:

(WebCore::JSElement::setAttribute):
(WebCore::JSElement::setAttributeNS):

  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::canGetItemsForName):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):

  • bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):

  • bindings/js/JSMimeTypeArrayCustom.cpp:

(WebCore::JSMimeTypeArray::canGetItemsForName):
(WebCore::JSMimeTypeArray::nameGetter):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):

  • bindings/js/JSPluginArrayCustom.cpp:

(WebCore::JSPluginArray::canGetItemsForName):
(WebCore::JSPluginArray::nameGetter):

  • bindings/js/JSPluginCustom.cpp:

(WebCore::JSPlugin::canGetItemsForName):
(WebCore::JSPlugin::nameGetter):

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore::JSPopStateEvent::initPopStateEvent):

  • bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::getResponseHeader):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):

  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:

(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::add):
(WebCore::AtomicString::find):

  • platform/text/AtomicString.h:

(WebCore::AtomicString::AtomicString):

16:58 Changeset [57765] by aroben@apple.com

Fix typo from r55729

  • platform/win/Skipped:
16:51 Changeset [57764] by weinig@apple.com

Fix window.open() and targeted links.

Reviewed by Anders Carlsson.

WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveSyncMessage): Pass in the new pageID
instead of 0.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::createWebPage): Allow for the page to have already
been created, as is the case with programmatic window opening from within
WebCore (e.g. window.open() or <a target="_blank">).

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(_createNewPage): Use the correct initializer to and load the window.

16:45 Changeset [57763] by ajwong@chromium.org

Not reviewed. Fixing chromium build.

[chromium] Upstream test_expectations.txt changes from chromium.
Mark letter_spacing.html as consistently failing for mac.
Fixing a syntax error in the test_expectations.txt file.

  • platform/chromium/test_expectations.txt:
16:31 Changeset [57762] by ajwong@chromium.org

Not reviewed. Fixing chromiumg build.

[chromium] filterRes.svg is consistently failing now. Marking as such.

  • platform/chromium/test_expectations.txt:
16:23 Changeset [57761] by weinig@apple.com

Don't optimize debug builds.

Reviewed by Mark Rowe.

  • WebKit2.xcodeproj/project.pbxproj: Define GCC_OPTIMIZATION_LEVEL correctly.
16:13 Changeset [57760] by ukai@chromium.org

2010-04-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket crash when it receives bad header.
https://bugs.webkit.org/show_bug.cgi?id=37682

  • websocket/tests/bad-handshake-crash-expected.txt: Added.
  • websocket/tests/bad-handshake-crash.html: Added.
  • websocket/tests/bad-handshake-crash_wsh.py: Added.
  • websocket/tests/script-tests/bad-handshake-crash.js: Added.

2010-04-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket crash when it receives bad header.
https://bugs.webkit.org/show_bug.cgi?id=37682

If name or value is not valid UTF-8, nameStr or valueStr would be
null string, so crashed in headers->add(nameStr, valueStr).
Check both nameStr and valueStr are not null string.
Otherwise handshake will fail.

Test: websocket/tests/bad-handshake-crash.html

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readHTTPHeaders): check nameStr and valueStr are not null string.
16:10 Changeset [57759] by mitz@apple.com

<rdar://problem/7873647> Crash when updating hover state

Reviewed by Simon Fraser.

WebCore:

Test: fast/dynamic/hover-style-recalc-crash.html

Updating the hover state of an element caused the document to need style
recalc, and then updating the hover state of a link caused style recalc,
which changed the render tree while updateHoverActiveState() was iterating
over it, leading to a crash.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateHoverActiveState): Collect the nodes to be
updated into vectors, then update their active and hover states.

LayoutTests:

  • fast/dynamic/hover-style-recalc-crash-expected.txt: Added.
  • fast/dynamic/hover-style-recalc-crash.html: Added.
16:07 Changeset [57758] by ajwong@chromium.org

Not reviewed. Build fix.

[chromium] Compile fix. Missing include header, and missing type conversion.

  • src/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3DInternal::beginPaint):

15:42 Changeset [57757] by andersca@apple.com

Fix build.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

15:31 Changeset [57756] by barraclough@apple.com

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:
15:29 Changeset [57755] by scherkus@chromium.org

2010-04-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, fixing Chromium test_expectations.txt due to removed tests in r57292.

  • platform/chromium/test_expectations.txt:
15:11 Changeset [57754] by dumi@chromium.org

Make Safari correctly allocate 5MB of DB storage to all new
origins.
https://bugs.webkit.org/show_bug.cgi?id=36671

Reviewed by Alexey Proskuryakov.

Eric fixed the same problem in
DatabaseTracker::fullPathForDatabaseNoLock() in r57128, but forgot
to fix it in DatabaseTracker::detailsForNameAndOrigin() too.

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::detailsForNameAndOrigin):

15:06 Changeset [57753] by scherkus@chromium.org

2010-04-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, checking in Chromium baselines for media/video-seek-past-end-playing.html.

  • platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Added.
  • platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:05 Changeset [57752] by barraclough@apple.com

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:
14:57 Changeset [57751] by mrowe@apple.com

Merge r57615.

14:56 Changeset [57750] by mrowe@apple.com

Versioning.

14:55 Changeset [57749] by kinuko@chromium.org

2010-04-16 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Implement FileStreamProxy that calls FileStream methods on FileThread for FileAPI
https://bugs.webkit.org/show_bug.cgi?id=37218

No new tests; tests will be added when we add upper layer implementations.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/FileStream.cpp: (WebCore::FileStream::stop):
  • html/FileStream.h:
  • html/FileStreamClient.h: (WebCore::FileStreamClient::didStop):
  • html/FileStreamProxy.cpp: Added
  • html/FileStreamProxy.h: Added
  • html/FileThreadTask.h: Added
14:50 Changeset [57748] by barraclough@apple.com

Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

JavaScriptCore:

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

(JSC::UStringImpl::create):

  • runtime/UStringImpl.h:

WebCore:

Remove ustring() method, and constructor passed a UString.

  • WebCore.base.exp:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::stringimplToUString):
(WebCore::jsStringSlowCase):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::identifierToString):

  • bindings/js/JSDOMBinding.h:

(WebCore::jsString):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::operator UString):

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::create):

  • platform/text/StringImpl.h:
14:39 Changeset [57747] by eric@webkit.org

2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL is not visible when QGLWidget viewport is used
https://bugs.webkit.org/show_bug.cgi?id=37070

Added HostWindow parameter to the constructor of GraphicsContext3D.
Shared OpenGL context is initialized with parent QGLWidget.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getOwnerGLWidget): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):

2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL is not visible when QGLWidget viewport is used
https://bugs.webkit.org/show_bug.cgi?id=37070

Added HostWindow parameter to the constructor of GraphicsContext3D.
Shared OpenGL context is initialized with parent QGLWidget.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D):
14:39 Changeset [57746] by mrowe@apple.com

New tag.

14:27 Changeset [57745] by eric@webkit.org

2010-04-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebKit compilation fails with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=37699

API for readPixels() has been changed.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::readPixels):
14:16 Changeset [57744] by eric@webkit.org

2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Antti Koivisto.

[Qt]QtLauncher crash on page with CSS 3D transform
https://bugs.webkit.org/show_bug.cgi?id=36859

Added a neccessary null-pointer check, lack of which created the crash circumstances.

Tested by http://css-vfx.googlecode.com/svn/trunk/snowstack/snowstack.html

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
14:14 Changeset [57743] by scherkus@chromium.org

2010-04-16 Sergey Ulanov <sergeyu@chromium.org>

Unreviewed, checking in baselines due to changes to Chromium's video scaling algorithm.

  • platform/chromium-linux/media/controls-after-reload-expected.checksum:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.checksum:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-layer-crash-expected.checksum:
  • platform/chromium-linux/media/video-layer-crash-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.checksum:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-transformed-expected.checksum:
  • platform/chromium-linux/media/video-transformed-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.checksum:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.checksum:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-layer-crash-expected.checksum:
  • platform/chromium-mac/media/video-layer-crash-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-transformed-expected.checksum:
  • platform/chromium-mac/media/video-transformed-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.checksum:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.checksum:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-strict-expected.checksum:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/video-aspect-ratio-expected.checksum:
  • platform/chromium-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.checksum:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.checksum:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.checksum:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-transformed-expected.checksum:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.checksum:
  • platform/chromium-win/media/video-volume-slider-expected.png:
14:08 Changeset [57742] by aroben@apple.com

Fix links to layout test results from build status pages

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(ExtractTestResults.finished): Prepend "/" on the URL of the test
results page so that it is treated as an absolute URL.

13:52 Changeset [57741] by andersca@apple.com

Make sure to update the current graphics context when calling out to AppKit.

Reviewed by Sam Weinig.

  • platform/mac/ThemeMac.mm:

(WebCore::paintCheckbox):
(WebCore::paintRadio):

13:34 Changeset [57740] by barraclough@apple.com
  • WebFrame.cpp:

(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):

  • WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix).

13:26 Changeset [57739] by andersca@apple.com

Fix windows build.

Reviewed by Sam Weinig.

  • Platform/win/RunLoopWin.cpp:

(RunLoop::run):

  • UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::webThreadBody):
(WebKit::launchWebProcess):

  • WebProcess/win/WebProcessMain.cpp:

(WebKit::WebProcessMain):

13:21 Changeset [57738] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=37675
Remove casts/constructors to/from JSC::UString type from WebCore::String

Reviewed by Sam Weinig & Oliver Hunt.

WebCore's strings should not know about JSC::UString, this should be abstracted
away in the bindings. Add explicit conversion methods rather than relying on
overloaded cast operators / constructors being implicitly called.

This patch only changes the class String, once this has landed StringImpl, and
hopefully AtomicString too, should follow suit.

WebCore:

This patch adds:

WebCore::identifierToString
WebCore::ustringToString
WebCore::stringToUString

  • to JSDOMBindings.h, and updates code to call these methods.
  • WebCore.base.exp:
  • WebCore.order:
  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

  • bindings/js/JSAudioConstructor.cpp:

(WebCore::constructAudio):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::nameGetter):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
(WebCore::JSCanvasRenderingContext2D::setShadow):
(WebCore::JSCanvasRenderingContext2D::fillText):
(WebCore::JSCanvasRenderingContext2D::strokeText):

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):
(WebCore::JSClipboard::clearData):
(WebCore::JSClipboard::getData):
(WebCore::JSClipboard::setData):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::identifierToString):
(WebCore::ustringToString):
(WebCore::stringToUString):
(WebCore::valueToStringWithNullCheck):
(WebCore::valueToStringWithUndefinedOrNullCheck):
(WebCore::reportException):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::JSDOMFormData::append):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::setLocation):
(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::setLocation):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSEventSourceConstructor.cpp:

(WebCore::constructEventSource):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):
(WebCore::documentWrite):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::createInjectedScript):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::setHref):
(WebCore::JSLocation::setProtocol):
(WebCore::JSLocation::setHost):
(WebCore::JSLocation::setHostname):
(WebCore::JSLocation::setPathname):
(WebCore::JSLocation::setSearch):
(WebCore::JSLocation::setHash):
(WebCore::JSLocation::replace):
(WebCore::JSLocation::assign):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::initMessageEvent):

  • bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):

  • bindings/js/JSOptionConstructor.cpp:

(WebCore::constructHTMLOptionElement):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/js/JSSharedWorkerConstructor.cpp:

(WebCore::constructSharedWorker):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::canGetItemsForName):
(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):
(WebCore::JSStorage::putDelegate):

  • bindings/js/JSStyleSheetListCustom.cpp:

(WebCore::JSStyleSheetList::canGetItemsForName):
(WebCore::JSStyleSheetList::nameGetter):

  • bindings/js/JSWebKitCSSMatrixConstructor.cpp:

(WebCore::constructWebKitCSSMatrix):

  • bindings/js/JSWebSocketConstructor.cpp:

(WebCore::constructWebSocket):

  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocket::send):

  • bindings/js/JSWorkerConstructor.cpp:

(WebCore::constructWorker):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::importScripts):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):
(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::overrideMimeType):

  • bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

  • bindings/js/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::ScriptCallFrame):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):
(WebCore::ScriptDebugServer::sourceParsed):

  • bindings/js/ScriptEventListener.cpp:

(WebCore::getEventListenerHandlerBody):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):

  • bindings/js/ScriptObject.cpp:

(WebCore::ScriptObject::set):

  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):

  • bindings/js/ScriptString.h:

(WebCore::ScriptString::operator String):
(WebCore::ScriptString::ustring):
(WebCore::ScriptString::operator+=):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::getString):

  • bindings/js/ScriptValue.h:

(WebCore::ScriptValue::toString):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedObject::set):
(WebCore::SerializingTreeWalker::convertIfTerminal):
(WebCore::DeserializingTreeWalker::putProperty):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::StringSourceProvider):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::identifierFromNPIdentifier):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::scriptImported):
(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::createProfileHeader):

  • inspector/InspectorResource.cpp:

(WebCore::InspectorResource::sourceString):

  • inspector/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::functionName):

  • platform/KURL.h:

(WebCore::KURL::operator const String&):

  • platform/text/AtomicString.cpp:

(WebCore::AtomicString::operator UString):

  • platform/text/AtomicString.h:
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:

WebKit/mac:

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(identifierFromIdentifierRep):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray):
(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::getPropertyNames):

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame evaluateWebScript:]):

  • WebView/WebScriptDebugger.mm:

(toNSURL):

  • WebView/WebView.mm:

(aeDescFromJSValue):

13:15 Changeset [57737] by weinig@apple.com

Make resizing responsive on Windows.

Reviewed by Anders Carlsson.

  • Use the same waitFor logic as do for the Mac resizing DrawingAreaUpdateChunk code.
  • Shared/win/UpdateChunk.cpp:

(WebKit::UpdateChunk::UpdateChunk):

  • Shared/win/UpdateChunk.h: Add a constructor that only takes an IntRect and allocates the shared memory mapping for you.
  • UIProcess/win/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::ensureBackingStore):
(WebKit::DrawingAreaProxy::paint):
(WebKit::DrawingAreaProxy::drawUpdateChunkIntoBackingStore):
(WebKit::DrawingAreaProxy::setSize):
(WebKit::DrawingAreaProxy::didSetSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):

  • UIProcess/win/DrawingAreaProxy.h:

Perform wait in paint as we do on the mac.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onSizeEvent):
Change to use an IntSize.

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):
(WebKit::DrawingAreaUpdateChunk::display):
(WebKit::DrawingAreaUpdateChunk::setSize):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.h:

Specialize setSize() drawing and factor out painting
into a helper function.

13:13 Changeset [57736] by ajwong@chromium.org

Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-mac and chromium-win
also since this test there as well.

  • platform/chromium-mac/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
  • platform/chromium-mac/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
  • platform/chromium-mac/fast/url/standard-url-expected.txt:
  • platform/chromium-win/fast/url/host-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/host-expected.txt.
  • platform/chromium-win/fast/url/path-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/url/path-expected.txt.
  • platform/chromium-win/fast/url/standard-url-expected.txt:
13:05 Changeset [57735] by ajwong@chromium.org

Not reviewed. Build fix for chromium.

[chromium] Add in new baselines for chromium-linux since this test
fully passes on this platform.

  • platform/chromium-linux/fast/url/host-expected.txt: Added.
  • platform/chromium-linux/fast/url/path-expected.txt: Added.
  • platform/chromium-linux/fast/url/standard-url-expected.txt: Added.
12:58 Changeset [57734] by andersca@apple.com

2010-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Always pass a view to the AppKit drawing functions.
https://bugs.webkit.org/show_bug.cgi?id=37724

  • platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
12:45 Changeset [57733] by ap@apple.com

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=37718
Safari crashes with certain JavaScript charCode events in EventHandler::needsKeyboardEventDisambiguationQuirks

Test: fast/events/recorded-keydown-event.html

  • dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::charCode): Check if the view (window) is frameless.
12:36 Changeset [57732] by andersca@apple.com

2010-04-16 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Make run loops be allocated as thread specific data.
https://bugs.webkit.org/show_bug.cgi?id=37723

  • Platform/RunLoop.cpp: (RunLoop::initializeMainRunLoop): (RunLoop::current): (RunLoop::main):
  • Platform/RunLoop.h:
  • Platform/mac/RunLoopMac.mm: (RunLoop::run): (RunLoop::stop):
  • UIProcess/Launcher/mac/WebProcessLauncher.mm: (WebKit::webThreadBody): (WebKit::launchWebProcess):
  • UIProcess/ResponsivenessTimer.cpp: (WebKit::ResponsivenessTimer::ResponsivenessTimer):
  • WebProcess/Launching/mac/WebProcessMain.mm: (main):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::isSeparateProcess):
11:52 Changeset [57731] by aroben@apple.com

Skip HTMLFrameSetElement-window-eventListener-attributes.html on SnowLeopard

It is crashing sometimes. <http://webkit.org/b/37720> tracks investigating this.

Rubber-stamped by Sam Weinig.

  • platform/mac-snowleopard/Skipped:
11:40 Changeset [57730] by aroben@apple.com

Make it possible for clients to instantiate a WebUserContentURLPattern

Reviewed by Tim Hatcher.

  • ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which

lists all our instantiatable classes.

  • WebKitClassFactory.cpp: Added a now-required #include.
11:19 Changeset [57729] by aroben@apple.com

SKip xss-DENIED-mime-type-execute-as-html.html to see if it makes the http test stop timing out on Windows

<http://webkit.org/b/37714> tracks this investigation.

Rubber-stamped by Sam Weinig.

  • platform/win/Skipped:
11:19 Changeset [57728] by ukai@chromium.org

2010-04-16 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Jian Li.

[chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
https://bugs.webkit.org/show_bug.cgi?id=37687

  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.
11:07 Changeset [57727] by dglazkov@chromium.org

2010-04-16 Jian Li <jianli@chromium.org>

Reviewed by Dmitry Titov.

Update FormDataList to fix style violations in old code.
https://bugs.webkit.org/show_bug.cgi?id=37689

  • html/FormDataList.h: (WebCore::FormDataList::appendData): (WebCore::FormDataList::appendBlob):
11:00 Changeset [57726] by jianli@chromium.org

Update FormDataList to fix style violations in old code.
https://bugs.webkit.org/show_bug.cgi?id=37689

Reviewed by Dmitry Titov.

  • html/FormDataList.h:

(WebCore::FormDataList::appendData):
(WebCore::FormDataList::appendBlob):

10:59 Changeset [57725] by andersca@apple.com

Fix WebKit2 build.

  • WebCore.base.exp:
10:18 Changeset [57724] by eric@webkit.org

2010-04-16 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
https://bugs.webkit.org/show_bug.cgi?id=37436

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::notifyPopupHidden):
  • platform/chromium/PopupMenuChromium.h:

2010-04-16 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Select popups would assert when destroyed.
Also adding unit-tests for the select popup code.
https://bugs.webkit.org/show_bug.cgi?id=37436

  • WebKit.gyp:
  • src/WebViewImpl.h: (WebKit::WebViewImpl::selectPopup):
  • tests/PopupMenuTest.cpp: Added.
10:09 Changeset [57723] by mitz@apple.com

Expose the extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.

Reviewed by John Sullivan.

  • WebView/WebHTMLView.mm:

Replaced two macros with constants.
(-[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:]): Changed to use the constants.
(-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.

  • WebView/WebHTMLViewPrivate.h: Declared _WebHTMLViewPrintingMinimumShrinkFactor and

_WebHTMLViewPrintingMaximumShrinkFactor.

09:18 Changeset [57722] by eric@webkit.org

2010-04-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57719.
http://trac.webkit.org/changeset/57719
https://bugs.webkit.org/show_bug.cgi?id=37708

Broke 8 URL tests on Windows due to use of file:///tmp/ URLs,
which don't work on Windows. (Requested by aroben on #webkit).

  • fast/url/anchor.html:
  • fast/url/file-expected.txt: Removed.
  • fast/url/file.html: Removed.
  • fast/url/ipv4.html:
  • fast/url/path-url.html:
  • fast/url/port.html:
  • fast/url/query.html:
  • fast/url/script-tests/TEMPLATE.html:
  • fast/url/script-tests/file.js: Removed.
  • fast/url/standard-url.html:
  • fast/url/trivial.html:
07:11 Changeset [57721] by tonikitoo@webkit.org

2010-04-16 Antonio Gomes <tonikitoo@webkit.org>

Unreviewed QtWebKit (with Qt 4.7) build fix.

Bug 37683 moved code from FontQt.cpp to FontPlatformDataQt.cpp but did not
renamed the variable used.

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
01:06 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
00:36 Changeset [57720] by eric@webkit.org

2010-04-16 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] build DRT on Linux
https://bugs.webkit.org/show_bug.cgi?id=37690

  • DEPS: Need to roll deps to remove a dependency on src/chrome
  • gyp_webkit: generate makefiles for DRT.gyp on Linux

2010-04-16 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] build DRT on Linux
https://bugs.webkit.org/show_bug.cgi?id=37690

  • Scripts/build-dumprendertree: Add support for win and linux
00:27 Changeset [57719] by mjs@apple.com

2010-04-16 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Test file: URL canonicalization
https://bugs.webkit.org/show_bug.cgi?id=37700

  • fast/url/script-tests/file.js: Added new test.
  • fast/url/file-expected.txt: Added (expected results).
  • fast/url/file.html: Added (wrapper).
  • fast/url/script-tests/TEMPLATE.html: Add an explicit dependable <base> URL to the template, to avoid making test expectations system dependent.


Other test wrappers regenerated for the above change:

  • fast/url/anchor.html:
  • fast/url/ipv4.html:
  • fast/url/path-url.html:
  • fast/url/port.html:
  • fast/url/query.html:
  • fast/url/standard-url.html:
  • fast/url/trivial.html:
00:25 Changeset [57718] by eric@webkit.org

2010-04-16 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Make GraphicsLayerQt always use ItemCoordinateCache, and remove ItemUsesExtendedStyleOption.
This aligns our implementation with the Safari implementation - layers are always uploaded
to textures in item units, and WebCore is responsible for the heuristics.

[Qt] GraphicsLayer: performance optimizations
https://bugs.webkit.org/show_bug.cgi?id=35393

No new tests. Still no FPS benchmarks available (on any platform)
but animations are noticably better.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::TransformAnimationQt::updateState):
00:20 QtWebKitRelease20 edited by henry.haverinen@nokia.com
(diff)
00:19 QtWebKit edited by henry.haverinen@nokia.com
(diff)
00:14 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
00:14 Changeset [57717] by eric@webkit.org

2010-04-16 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebCore::Font::font() causes a QFont detach
https://bugs.webkit.org/show_bug.cgi?id=37683

Moved the setStyleStrategy call to FontPlatformData
to avoid the detach.

Thanks to Holger for spotting this.

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::font):
00:13 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
00:10 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
00:03 Changeset [57716] by eric@webkit.org

2010-04-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Add EFL port files to efl/WebCoreSupport.
http://webkit.org/b/35915

  • efl/WebCoreSupport/FrameLoaderClientEfl.cpp: Added.
  • efl/WebCoreSupport/FrameLoaderClientEfl.h: Added.
Note: See TracTimeline for information about the timeline view.