Timeline


and

04/27/10:

23:45 Changeset [58384] by yuzo@google.com
  • 7 edits in trunk

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Reviewed by Dimitri Glazkov.

Enhance CSS parser for Paged Media (Iteration 3)
Implement size parameter parsing for Paged Media.
https://bugs.webkit.org/show_bug.cgi?id=35851

  • printing/page-rule-css-text-expected.txt:
  • printing/page-rule-css-text.html:

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Reviewed by Dimitri Glazkov.

Enhance CSS parser for Paged Media (Iteration 3)
Implement size parameter parsing for Paged Media.
https://bugs.webkit.org/show_bug.cgi?id=35851

I believe size property hasn't been used so far because (1) it hasn't been properly parsed and
(2) a comment in CSSComputedStyleDeclaration::getPropertyCSSValue says so.
Changing the way of parsing it should not cause any regressions -- no existing tests fail because of this change.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseSize): (WebCore::CSSParser::parseSizeParameter):
  • css/CSSParser.h: (WebCore::CSSParser::):
  • css/CSSValueKeywords.in:
23:19 Changeset [58383] by yuzo@google.com
  • 11 edits
    2 adds in trunk

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Enhance CSS parser for Paged Media (Iteration 2)
Parse and hold paged media rules in CSSStyleSelector.

fast/dom/script-tests/prototype-inheritance-2.js is rebaselined because it assumes @page is ignored.

https://bugs.webkit.org/show_bug.cgi?id=35782

  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/script-tests/prototype-inheritance-2.js:
  • printing/page-rule-css-text-expected.txt: Added.
  • printing/page-rule-css-text.html: Added.

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Enhance CSS parser for Paged Media (Iteration 2)
Parse and hold paged media rules in CSSStyleSelector.

https://bugs.webkit.org/show_bug.cgi?id=35782

Test: printing/page-rule-css-text.html

  • css/CSSGrammar.y:
  • css/CSSPageRule.cpp: (WebCore::CSSPageRule::CSSPageRule): (WebCore::CSSPageRule::selectorText):
  • css/CSSPageRule.h: (WebCore::CSSPageRule::create): (WebCore::CSSPageRule::isPageRule):
  • css/CSSParser.cpp: (WebCore::CSSParser::createPageRule):
  • css/CSSStyleRule.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getPageRules): (WebCore::CSSRuleSet::CSSRuleSet): (WebCore::CSSRuleSet::~CSSRuleSet): (WebCore::CSSRuleSet::addPageRule): (WebCore::CSSRuleSet::addRulesFromSheet):
  • css/CSSStyleSelector.h:
  • css/StyleBase.h: (WebCore::StyleBase::isPageRule):
23:00 Changeset [58382] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Jens Alfke <snej@chromium.org>

Reviewed by Eric Seidel.

[chromium] Fix bug that prevents autosave of forms without action attribute
https://bugs.webkit.org/show_bug.cgi?id=38014
Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test.
It needs a native unit test, which would go in the Chromium repo, not WebKit.

  • src/WebPasswordFormData.cpp: (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL
22:42 Changeset [58381] by dbates@webkit.org
  • 7 edits
    6 adds in trunk

2010-04-27 Daniel Bates <dbates@rim.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=37686

Fixes an issue where the canvas method strokeRect will stroke a
rectangle whose dimensions are 0 when lineWidth > 1.

As per the definition of strokeRect in the HTML Canvas 2D Context
spec. <http://www.w3.org/TR/2dcontext/#dom-context-2d-strokerect>,
this method should have no effect when both the height and width
are zero.

Tests: fast/canvas/canvas-clearRect.html

fast/canvas/canvas-fillRect.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::validateRectForCanvas): Return false if height, width == 0.

2010-04-27 Daniel Bates <dbates@rim.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=37686

Tests that strokeRect does not paint any artifacts when the
specified rectangle has height, width = 0 and lineWidth > 1.

Also tests that clearRect, fillRect, and rect are ignored when
height, width = 0.

  • fast/canvas/canvas-clearRect-expected.txt: Added.
  • fast/canvas/canvas-clearRect.html: Added.
  • fast/canvas/canvas-fillRect-expected.txt: Added.
  • fast/canvas/canvas-fillRect.html: Added.
  • fast/canvas/canvas-modify-emptyPath-expected.txt:
  • fast/canvas/canvas-strokeRect-expected.txt: Updated results.
  • fast/canvas/script-tests/canvas-clearRect.js: Added.
  • fast/canvas/script-tests/canvas-fillRect.js: Added.
  • fast/canvas/script-tests/canvas-modify-emptyPath.js: Added test case.
  • fast/canvas/script-tests/canvas-strokeRect.js: Ditto. Also, added debug statements so as to distinguish the results for each test.
22:40 Changeset [58380] by eric@webkit.org
  • 8 edits in trunk

2010-04-27 Michael Nordman <michaeln@google.com>

Reviewed by Dmitry Titov.

[Chromium] Add two things to the webkit API to support appcaches in workers.
1) WebURLRequest TargetTypes for worker and shared worker main resources.
2) Factory method on class WebCommonWorkerClient to

createApplicationCacheHost() for the associated worker.

https://bugs.webkit.org/show_bug.cgi?id=38147

  • public/WebCommonWorkerClient.h: add the factory method
  • public/WebURLRequest.h: add the TargetTypes
  • src/WebWorkerBase.cpp: call the embedder's factory when needed (WebKit::WebWorkerBase::didCreateDataSource) (WebKit::WebWorkerBase::createApplicationCacheHost)
  • src/WebWorkerBase.h: ditto
  • src/WebWorkerClientImpl.h: add a stub impl of the factory method (WebKit::WebWorkerClientImpl::createApplicationCacheHost):

2010-04-27 Michael Nordman <michaeln@google.com>

Reviewed by Dmitry Titov.

[Chromium] Add two things to the webkit API to support appcaches in workers.
1) WebURLRequest TargetTypes for worker and shared worker main resources.
2) Factory method on class WebCommonWorkerClient to

createApplicationCacheHost() for the associated worker.

https://bugs.webkit.org/show_bug.cgi?id=38147

  • DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method (TestWebWorker::createApplicationCacheHost):
22:31 Changeset [58379] by eric@webkit.org
  • 8 edits
    3 deletes in trunk/WebCore

2010-04-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove obsolete custom bindings file
https://bugs.webkit.org/show_bug.cgi?id=38223

We don't need these files anymore because they are empty.

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAbstractWorkerCustom.cpp: Removed.
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDocumentFragmentCustom.cpp: Removed.
  • bindings/js/JSEventSourceCustom.cpp: Removed.
22:21 Changeset [58378] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Daniel Cheng <dcheng@chromium.org>

Reviewed by Jian Li.

[Chromium] Filter out URLs with a file scheme from text/uri-list when dragging.
https://bugs.webkit.org/show_bug.cgi?id=38227

Unfortunately, the simple fix of not populating the drag data with file URLs doesn't work
since the default drop handling uses the drag data URL to navigate to dropped files/URLs.
For now, we hack around the problem in the Chromium platform, but the proper long term
solution is to change DragController::performDrag to check dragData::asFilenames().

No new tests.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::types):
21:53 Changeset [58377] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Enable Windows project generation
https://bugs.webkit.org/show_bug.cgi?id=38103

  • Avoid platform.system(), which causes a crash with python.exe in depot_tools. Use sys.platform instead.
  • Process DumpRenderTree.gyp on all platforms.
  • gyp_webkit:
21:49 Changeset [58376] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

run-bindings-tests doesn't work in an SVN checkout
https://bugs.webkit.org/show_bug.cgi?id=38225

Previously detect_scm_system needed an absolute path for SVN. Now we
accept a relative path.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
21:20 Changeset [58375] by simon.fraser@apple.com
  • 3 edits
    5 adds in trunk

2010-04-27 Simon Fraser <simon.fraser@apple.com>

Reviewed by the inimitable Dan Bernstein.

SVG as background image renders incorrectly after zooming
https://bugs.webkit.org/show_bug.cgi?id=38215

When doing a partial redraw of an SVGImage used as a CSS background
image, we're limited to drawing the entire Frame, clipped to the dirty rect.
Because of this, we need to fix up the CTM so that the origin is at the
top left of the unclipped image, rather than the top left of the
portion being redrawn.

Test: fast/images/svg-background-partial-redraw.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::draw):
20:42 Changeset [58374] by yuzo@google.com
  • 8 edits
    2 adds in trunk

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Hyatt.

Retry of: Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

https://bugs.webkit.org/show_bug.cgi?id=35329

  • fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
  • fast/css/parsing-page-rule.html: Added.

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Hyatt.

Retry of: Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

https://bugs.webkit.org/show_bug.cgi?id=35329

Test: fast/css/parsing-page-rule.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::createPageRule): (WebCore::CSSParser::createMarginAtRule): (WebCore::CSSParser::startDeclarationsForMarginBox): (WebCore::CSSParser::endDeclarationsForMarginBox):
  • css/CSSParser.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/tokenizer.flex:
20:37 Changeset [58373] by jchaffraix@webkit.org
  • 4 edits
    5 deletes in trunk

Unreviewed, rolling out my changes as it rendered the Qt bot unreliable.

WebCore:

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::loadRequest):

LayoutTests:

  • http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Removed.
  • http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Removed.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Removed.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Removed.
  • http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Removed.
  • platform/qt/Skipped:
20:08 Changeset [58372] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt/Skipped: Add the 2 newly added test cases to the list

as they involve preflight requests.

19:44 Changeset [58371] by jchaffraix@webkit.org
  • 3 edits
    5 adds in trunk

[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html

http/tests/xmlhttprequest/access-control-preflight-credential-sync.html

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.

LayoutTests:

Test that doing a cross-origin request with a preflight check does
not raise a NETWORK_ERR exception and does not send the credentials.

  • http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
  • http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.
19:29 Changeset [58370] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Makes clicking a select element close its associated popup if
it is open.
https://bugs.webkit.org/show_bug.cgi?id=38105

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown):
19:08 Changeset [58369] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-04-27 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

[chromium] Merged the WebView public method to close suggestion popups
into a single method to close all popups (select and suggestions).
That ensures select popups are closed when the browser window is moved
or resized.
https://bugs.webkit.org/show_bug.cgi?id=37837

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::hidePopups): (WebKit::WebViewImpl::hideSuggestionsPopup):
  • src/WebViewImpl.h:
18:45 Changeset [58368] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Always build WebKit2 when building on SnowLeopard and later.

Reviewed by Stephanie Lewis.

  • Scripts/build-webkit:
18:28 Changeset [58367] by weinig@apple.com
  • 6 edits in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
Allow both WebKit and WebKit2 to link to the same WebCore.framework

Reviewed by Maciej Stachowiak.

WebCore:

  • Configurations/WebCore.xcconfig: Use -allowable_client WebKit2 to add

WebKit2 to the list of frameworks that can link directly to WebCore. It
is not necessary for it to be an umbrella since we don't need to reexport
any symbols.

WebKit2:

  • Configurations/WebKit2.xcconfig: Remove the OTHER_LDFLAGS. We don't

need to set WebCore as a sub_umbrella of WebKit2, since we are not
reexporting any of its symbols.

WebKitTools:

  • Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building

WebCore for WebKit2, it is no longer necessary.

18:24 Changeset [58366] by dumi@chromium.org
  • 11 edits in trunk

WebCore: Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases.
https://bugs.webkit.org/show_bug.cgi?id=38191

Reviewed by David Levin.

Vacuum all databases when the number of free pages is at least 10%
of the number of total pages. Also, add a guard against a bug that
was fixed in SQLite only starting with version 3.6.16.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::maximumSize):
(WebCore::SQLiteDatabase::freeSpaceSize):
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):

  • platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::):

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):
(WebCore::SQLiteStatement::step):

  • storage/Database.cpp:

(WebCore::Database::performOpenAndVerify):
(WebCore::Database::incrementalVacuumIfNeeded):

  • storage/Database.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::postflightAndCommit):

LayoutTests: Adjusting the expected amount of space used by quota-tracking.html.
https://bugs.webkit.org/show_bug.cgi?id=38191

Reviewed by David Levin.

The expectations changed because of AUTO_VACUUM's overhead.

  • platform/chromium/test_expectations.txt:
  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:
18:19 Changeset [58365] by jam@chromium.org
  • 1 edit
    1 delete in trunk/WebKit/chromium

2010-04-27 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Adler.

Remove unnecessary header now that Chrome is updated
https://bugs.webkit.org/show_bug.cgi?id=38211

  • public/win/WebThemeEngine.h: Removed.
18:15 Changeset [58364] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-04-27 James Robinson <jamesr@chromium.org>

Reviewed by David Levin.

Fix a typo in chromium.py that causes NRWT to fail in --verbose
mode in a Chromium checkout.
https://bugs.webkit.org/show_bug.cgi?id=38234

  • Scripts/webkitpy/layout_tests/port/chromium.py:
18:09 Changeset [58363] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-04-27 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Turn all of the touch event handlers into RuntimeEnabledFeatures, and
modify the createEvent methond on Document so that it won't create a
TouchEvent if the feature is disabled.
https://bugs.webkit.org/show_bug.cgi?id=37485

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::touchEnabled): (WebCore::RuntimeEnabledFeatures::setTouchEnabled): (WebCore::RuntimeEnabledFeatures::ontouchstartEnabled): (WebCore::RuntimeEnabledFeatures::ontouchmoveEnabled): (WebCore::RuntimeEnabledFeatures::ontouchendEnabled): (WebCore::RuntimeEnabledFeatures::ontouchcancelEnabled):
  • dom/Document.cpp: (WebCore::Document::createEvent):
  • dom/Document.idl:
  • dom/Element.idl:
  • page/DOMWindow.idl:
17:55 Changeset [58362] by eric@webkit.org
  • 10 edits in trunk

2010-04-27 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add some notifications and an accessor to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=37625

  • dom/Node.cpp: (WebCore::Node::hasNonEmptyBoundingBox): New method.
  • dom/Node.h:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable): Moved part of method into new Node method

2010-04-27 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add some notifications and an accessor to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=37625

  • public/WebFrameClient.h: (WebKit::WebFrameClient::didFirstLayout): (WebKit::WebFrameClient::didFirstVisuallyNonEmptyLayout):
  • public/WebNode.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidFirstLayout): (WebKit::FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout):
  • src/WebElement.cpp:
  • src/WebNode.cpp: (WebKit::WebNode::hasNonEmptyBoundingBox):
17:41 Changeset [58361] by evan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Evan Martin <evan@chromium.org>

Reviewed by David Levin.

[chromium] update test expectations for ancient linux bug
https://bugs.webkit.org/show_bug.cgi?id=38229

According to
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fembed-attributes-setting.html
this hasn't crashed in a long time, so the CRASH annotation is superfluous.

  • platform/chromium/test_expectations.txt:
17:38 Changeset [58360] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-27 Jochen Eisinger <jochen@chromium.org>

Reviewed by Shinichiro Hamaji.

Fix gyp build on Mac OS X with enable_svg=0.
https://bugs.webkit.org/show_bug.cgi?id=38192

  • WebCore.gyp/WebCore.gyp: Only generate SVG symbols if enable_svg!=0.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing unimplemented CSS properties to switch statement.
17:33 EFLWebKit edited by barbieri@profusion.mobi
update to reflect current situation (diff)
17:29 Changeset [58359] by crogers@google.com
  • 5 edits in branches/audio/WebCore
  • added <xaudio> tag (this is temporary to support the old API)
  • some build changes for new audio javascript types
17:28 Changeset [58358] by eric@webkit.org
  • 6 edits in trunk

2010-04-27 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Remove deprecated form of didChangeLocationWithinPage
https://bugs.webkit.org/show_bug.cgi?id=38178

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):

2010-04-27 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Remove deprecated form of didChangeLocationWithinPage
https://bugs.webkit.org/show_bug.cgi?id=38178

Switch over to implementing didNavigateWithinPage.

  • DumpRenderTree/chromium/WebViewHost.cpp: (TestWebViewDelegate::didNavigateWithinPage): (WebViewHost::didChangeLocationWithinPage):
  • DumpRenderTree/chromium/WebViewHost.h:
17:13 Changeset [58357] by crogers@google.com
  • 3 edits
    1 add in branches/audio/WebCore

hacks for CachedAudio including changes to EventTarget
(this supports a temporary and hackish loading mechanism for audio assets later to be replaced by XHR)

17:13 Changeset [58356] by crogers@google.com
  • 1 add in branches/audio/WebCore/audio/HRIR

add HRIR symlink

16:56 Changeset [58355] by slewis@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Tiger build.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::Carve):

16:42 Changeset [58354] by evan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Evan Martin <evan@chromium.org>

Unreviewed.

Adding myself to commmitters list.

  • Scripts/webkitpy/common/config/committers.py:
16:25 Changeset [58353] by slewis@apple.com
  • 3 deletes in trunk/WebKitLibraries

Remove more files I didn't intend to commit

16:24 Changeset [58352] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-04-27 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

[V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
https://bugs.webkit.org/show_bug.cgi?id=38207

No new tests.

  • WebCore.gyp/scripts/action_derivedsourcesallinone.py:
16:23 Changeset [58351] by crogers@google.com
  • 2 deletes in branches/audio/WebCore/audio

remove initial test files

16:19 Changeset [58350] by slewis@apple.com
  • 8 edits in trunk

Revert Files I didn't intend to commit

16:13 Changeset [58349] by eric@webkit.org
  • 5 edits
    8 adds in trunk

2010-04-27 François Sausset <sausset@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Additional MathML mroot & msqrt tests.
https://bugs.webkit.org/show_bug.cgi?id=37044

  • mathml/presentation/roots.xhtml: Added.
  • platform/mac/mathml/presentation/roots-expected.checksum: Added.
  • platform/mac/mathml/presentation/roots-expected.png: Added.
  • platform/mac/mathml/presentation/roots-expected.txt: Added.

2010-04-27 François Sausset <sausset@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Implementation of the MathML mroot & msqrt elements.
https://bugs.webkit.org/show_bug.cgi?id=37044

Test: mathml/presentation/roots.xhtml

  • WebCore.xcodeproj/project.pbxproj:
  • css/mathml.css: (mroot): (mroot > * + *): (mroot > * + mrow, mroot > * + mfenced):
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
  • mathml/RenderMathMLRoot.cpp: Added. (WebCore::RenderMathMLRoot::RenderMathMLRoot): (WebCore::RenderMathMLRoot::addChild): (WebCore::RenderMathMLRoot::paint): (WebCore::RenderMathMLRoot::layout):
  • mathml/RenderMathMLRoot.h: Added.
  • mathml/RenderMathMLSquareRoot.cpp: Added. (WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot): (WebCore::RenderMathMLSquareRoot::paint): (WebCore::RenderMathMLSquareRoot::layout):
  • mathml/RenderMathMLSquareRoot.h: Added.
16:02 Changeset [58348] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-04-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Create new baseline for caret-rtl-2
https://bugs.webkit.org/show_bug.cgi?id=38126

http://trac.webkit.org/changeset/58191/ caused the caret-rtl-2 layout
test to start failing under Chromium. Since we're the only ones who
run pixel tests, it's possible that the actual baseline needs to be updated
and not just the chromium baseline...but I'm not sure.

I'm tracking the overall progress of figuring this out here:
https://bugs.webkit.org/show_bug.cgi?id=38109

  • platform/chromium-mac/editing/selection/caret-rtl-2-actual.checksum: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-actual.png: Added.
15:56 Changeset [58347] by darin@apple.com
  • 1 edit
    1 delete in trunk/WebCore

I noticed an unused forwarding header.

Reviewed by Maciej Stachowiak.

  • ForwardingHeaders/runtime/PropertyMap.h: Removed.
15:55 Changeset [58346] by slewis@apple.com
  • 8 edits
    9 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=38154 FastMalloc calls madvise too often.
<rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028 (return memory quicker).
To save on madvise calls when recommitting memory recommit the entire span and then carve it
instead of carving the span up and only committing the part that will be used immediately.

Reviewed by Geoff Garen.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Carve):

15:51 Changeset [58345] by jamesr@google.com
  • 12 edits in trunk/WebCore

2010-04-27 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

Fix gcc 4.4.1 warnings on Linux in the chromium V8 bindings code.
https://bugs.webkit.org/show_bug.cgi?id=38153

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::callFunction):
15:48 Changeset [58344] by evan@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-04-27 Evan Martin <evan@chromium.org>

Unreviewed, making the bots happy.

[chromium] bold bengali text not rendered properly on Linux
https://bugs.webkit.org/show_bug.cgi?id=37904

Check in a baseline for Mac pulled from the bots.

  • platform/mac/fast/text/international/bold-bengali-expected.txt: Added.
15:47 Changeset [58343] by crogers@google.com
  • 2446 adds in branches/audio/WebCore/audio/AudioSpatialization

add HRIR spatialization files

15:04 Changeset [58342] by eric@webkit.org
  • 13 edits
    1 move
    2 deletes in trunk

2010-04-27 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r58318.
http://trac.webkit.org/changeset/58318
https://bugs.webkit.org/show_bug.cgi?id=37215

Broke test on Tiger. Might just need updated results,
unclear.

  • http/tests/inspector/console-resource-errors-expected.txt: Removed.
  • http/tests/inspector/console-resource-errors.html: Removed.
  • http/tests/inspector/console-tests.js: Removed.
  • inspector/console-clear.html:
  • inspector/console-dir.html:
  • inspector/console-dirxml.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format.html:
  • inspector/console-log-before-inspector-open.html:
  • inspector/console-tests.html:
  • inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontend_dumpConsoleMessages):

2010-04-27 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r58318.
http://trac.webkit.org/changeset/58318
https://bugs.webkit.org/show_bug.cgi?id=37215

Broke test on Tiger. Might just need updated results,
unclear.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
14:53 Changeset [58341] by evan@chromium.org
  • 6 edits
    4 adds in trunk

2010-04-27 Evan Martin <evan@chromium.org>

Reviewed by David Levin.

[chromium] bold bengali text not rendered properly on Linux
https://bugs.webkit.org/show_bug.cgi?id=37904

Add a layout test containing some bold Bengali text.

  • fast/text/international/bold-bengali.html: Added.
  • platform/chromium-linux/fast/text/international/bold-bengali-expected.checksum: Added.
  • platform/chromium-linux/fast/text/international/bold-bengali-expected.png: Added.
  • platform/chromium-linux/fast/text/international/bold-bengali-expected.txt: Added.

2010-04-27 Evan Martin <evan@chromium.org>

Reviewed by David Levin.

[chromium] bold bengali text not rendered properly on Linux
https://bugs.webkit.org/show_bug.cgi?id=37904

We must let Skia do font fallback, rather than picking a font name
then handing that to Skia. For example, if we have Bengali text and
choose FreeSans + fake bold, and then later reuse the name, Skia will
helpfully use FreeSansBold (which doesn't cover Bengali).

Test: fast/text/international/bold-bengali.html

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):

2010-04-27 Evan Martin <evan@chromium.org>

Reviewed by David Levin.

[chromium] bold bengali text not rendered properly on Linux
Roll forward Chrome DEPS so we get new Skia API.

  • DEPS: update Chrome to r45696.
14:52 Changeset [58340] by jamesr@google.com
  • 6 edits in trunk/WebCore

2010-04-27 James Robinson <jamesr@chromium.org>

Reviewed by Darin Adler.

Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
https://bugs.webkit.org/show_bug.cgi?id=38158

Most of the issues are signed/unsigned mismatches, but there are a few unusued variables
and functions mixed in.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::adjustTextRenderMode): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::isCoordinateSkiaSafe): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
14:51 Changeset [58339] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-27 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Add test for NodeIterator prototype change behavior
https://bugs.webkit.org/show_bug.cgi?id=38219

In the process of remove the custom code from NodeIterator, we thought
we fixed a subtle bug where iterating over nodes from another frame
would get the wrong prototype chain. This test documents that we
didn't actually change the behavior and we still have the bug.

  • traversal/node-iterator-prototype-expected.txt: Added.
  • traversal/node-iterator-prototype.html: Added.
  • traversal/resources/node-iterator-prototype-frame.html: Added.
14:44 Changeset [58338] by crogers@google.com
  • 130 adds in branches/audio/WebCore/audio

add initial set of audio engine source files

14:35 Changeset [58337] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/7911140> Hitting the "delete" key goes back twice

Reviewed by Maciej Stachowiak.

  • WebView.cpp:

(WebView::keyDown):
Return true if we navigated back or forward from the key event to
prevent the event from being propagated further.

14:31 Changeset [58336] by jianli@chromium.org
  • 5 edits in trunk/WebCore

Sending a package file using FormData crashes WebKit on Mac.
https://bugs.webkit.org/show_bug.cgi?id=37882

Reviewed by Darin Adler.

Can't add a layout test because DRT does not support generating the file name.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::navigateToDifferentDocument):

  • platform/network/FormData.cpp:

(WebCore::FormData::appendDOMFormData):

  • platform/network/FormData.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

14:06 Changeset [58335] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Ojan Vafai <ojan@chromium.org>

Unreviewed. Minor fix after goofup in http://trac.webkit.org/changeset/58331

layoutTestController should have dumpAsMarkup
https://bugs.webkit.org/show_bug.cgi?id=26501

Forgot to reset the test results after doing the code review feedback
of adding a newline.

  • editing/selection/dump-as-markup-expected.txt:
13:59 Changeset [58334] by crogers@google.com
  • 1 add in branches/audio/WebCore/audio/test-commit2

test commit 2

13:55 Changeset [58333] by abarth@webkit.org
  • 14 edits
    1 delete in trunk/WebCore

2010-04-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove custom NodeIterator bindings
https://bugs.webkit.org/show_bug.cgi?id=38188

Another example of CallWith=ScriptState. This case shows us the right
way to handle the interaction with exception codes.

In my previous patch, I put the exception code handling after the
ScriptState exception handling. It turns out this was a mistake
(although a harmless one at the time because no IDL caused us to
generate that code). Now that we're generating both kinds of exception
handling, we need to generate them in the right order.

  • WebCore.gypi:
  • bindings/js/JSNodeIteratorCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_with_script_state_void_exception): (webkit_dom_test_obj_with_script_state_obj_exception):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException): (WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::withScriptStateVoidCallback): (WebCore::TestObjInternal::withScriptStateObjCallback): (WebCore::TestObjInternal::withScriptStateVoidExceptionCallback): (WebCore::TestObjInternal::withScriptStateObjExceptionCallback): (WebCore::):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: Removed.
  • dom/NodeIterator.idl:
13:35 Changeset [58332] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Add comment about not using StringImpl::createCFString in WKStringCopyCFString.

Reviewed by Geoffrey Garen.

  • UIProcess/API/C/cf/WKStringCF.cpp:

(WKStringCopyCFString):

13:29 Changeset [58331] by ojan@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-04-26 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

layoutTestController should have dumpAsMarkup
https://bugs.webkit.org/show_bug.cgi?id=26501

  • editing/selection/dump-as-markup-expected.txt: Added.
  • editing/selection/dump-as-markup.html: Added.
  • resources/dump-as-markup.js: Added. (Markup.dump.get var): (Markup.dump.get catch): (Markup.dump): (Markup.waitUntilDone): (Markup.notifyDone): (Markup._spaces): (Markup._getAttributes): (Markup._getMarkupForTextNode): (Markup._getSelectionMarker):
13:26 Changeset [58330] by abarth@webkit.org
  • 32 edits in trunk/WebCore

2010-04-27 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove copy/paste addEventListener "custom" bindings via code generation
https://bugs.webkit.org/show_bug.cgi?id=38210

It's somewhat lame to special case addEventListener and
removeEventListener in the code generator, but it saves a large amount
of boilerplate "custom" bindings code.

Idea shamelessly stolen from the V8 code generator.

This patch points to some good refactoring opportunities in
CodeGeneratorJS.pm, but I'm going to hold off on those for a future
patch. By generating test coverage for the code generator, we make
these future refactorings easier.

  • bindings/js/JSAbstractWorkerCustom.cpp:
  • bindings/js/JSDOMApplicationCacheCustom.cpp:
  • bindings/js/JSDesktopNotificationsCustom.cpp:
  • bindings/js/JSEventSourceCustom.cpp:
  • bindings/js/JSMessagePortCustom.cpp:
  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/JSSVGElementInstanceCustom.cpp:
  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionAddEventListener): (WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::addEventListenerCallback): (WebCore::TestObjInternal::removeEventListenerCallback): (WebCore::):
  • dom/MessagePort.idl:
  • dom/Node.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • notifications/Notification.idl:
  • page/EventSource.idl:
  • svg/SVGElementInstance.idl:
  • websockets/WebSocket.idl:
  • workers/AbstractWorker.idl:
  • workers/WorkerContext.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.idl:
13:25 Changeset [58329] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

run-bindings-tests should use --reset-results instead of --overwrite
https://bugs.webkit.org/show_bug.cgi?id=38200

As requested by Ojan.

  • Scripts/run-bindings-tests:
13:22 Changeset [58328] by abarth@webkit.org
  • 22 edits in trunk/WebKitTools

2010-04-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r58261): webkit-patch edit-changelogs is broken
https://bugs.webkit.org/show_bug.cgi?id=38204

In 58261, we added code to abstract step that interrogates the squash
and git_commit options, but it doesn't declare that it uses those
options. That means any command that doesn't happen to declare those
options might be broken if it uses the cached_lookup mechanism.

  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/applypatch.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/closebug.py:
  • Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
  • Scripts/webkitpy/tool/steps/commit.py:
  • Scripts/webkitpy/tool/steps/confirmdiff.py:
  • Scripts/webkitpy/tool/steps/createbug.py:
  • Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
  • Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
  • Scripts/webkitpy/tool/steps/obsoletepatches.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/update.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
13:16 Changeset [58327] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
https://bugs.webkit.org/show_bug.cgi?id=38212

  • Scripts/prepare-ChangeLog:
    • Pass --insecure to curl to work around CYGWIN missing certs.
13:15 Changeset [58326] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/test-commit

testing git svn dcommit

13:05 Changeset [58325] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Remove call to StringImpl::createCFString and instead use CFStringCreateWithCharacters
directly. StringImpl::createCFString only an optimization when called
from the thread that WebCore is running on, which is never the case for
WKStringCopyCFString. We should revisit this later, perhaps adding a
threadspecific allocator. We also now honor the passed in allocator.

Reviewed by Geoffrey Garen.

  • UIProcess/API/C/cf/WKStringCF.cpp:

(WKStringCopyCFString):

12:51 Changeset [58324] by weinig@apple.com
  • 8 edits in trunk

WebCore: Remove now unnecessary EXPERIMENTAL_SINGLE_VIEW_MODE #define.

Rubber-stamped by Beth Dakin.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clearDragState):

  • page/EventHandler.h:
  • page/mac/DragControllerMac.mm:
  • page/mac/EventHandlerMac.mm:
  • platform/mac/PopupMenuMac.mm:

WebKitTools: It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
or WTF_USE_WEB_THREAD. Remove them.

Rubber-stamped by Beth Dakin.

  • Scripts/build-webkit:
12:50 WebKit Team edited by cjerdonek@webkit.org
Changed myself from committer to reviewer. (diff)
12:45 Changeset [58323] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Ben Murdoch <benm@google.com>

Reviewed by Simon Hausmann.

The TouchStationary state of WebCore::PlatformTouchPoint is not handled inside the touch event handler.
https://bugs.webkit.org/show_bug.cgi?id=37609

No new tests required, only updating documentation.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Improve the documentation for handling

the TouchStationary state as a result of discussions in bug 37609.

12:44 Changeset [58322] by cjerdonek@webkit.org
  • 2 edits in trunk/WebKitTools

Changed Chris Jerdonek from committer to reviewer.

Reviewed by David Levin.

  • Scripts/webkitpy/common/config/committers.py:
12:33 Changeset [58321] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-27 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
https://bugs.webkit.org/show_bug.cgi?id=35834

The scene should always have the size of the web view otherwhise it is
possible to scroll the graphics view.

  • QtLauncher/webview.cpp: (WebViewGraphicsBased::resizeEvent):
12:26 Changeset [58320] by simon.fraser@apple.com
  • 5 edits
    5 adds in trunk/WebCore

2010-04-27 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler, Maciej Stachowiak.

REGRESSION (r57919): Some pages opened in background tabs don't render the first time you activate their tab
https://bugs.webkit.org/show_bug.cgi?id=38183

Rather than sprinkle PLATFORM #ifdefs around, add a new method,
RenderLayerCompositor::shouldPropagateCompositingToIFrameParent(), that indicates whether
an iframe with composited content should trigger compositing mode in the enclosing document
(a behavior that differs between platforms).

Use this new method to determine whether to trigger a style recalc in the parent document
when an iframe becomes composited.

Move the code formerly in RenderView::compositingStateChanged() into RenderLayerCompositor().

  • manual-tests/compositing/accel-comp-iframe-tab-repaint.html: Added.
  • manual-tests/compositing/resources/flash-frame.html: Added.
  • manual-tests/compositing/resources/tab-repaint-part-2.html: Added.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): (WebCore::RenderLayerCompositor::shouldPropagateCompositingToIFrameParent): (WebCore::RenderLayerCompositor::requiresCompositingForIFrame):
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderView.cpp:
  • rendering/RenderView.h:
12:11 Changeset [58319] by diegohcg@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Adding myself to committers.py

  • Scripts/webkitpy/common/config/committers.py:
11:47 Changeset [58318] by eric@webkit.org
  • 13 edits
    1 move
    2 adds in trunk

2010-04-27 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Log error message to inspector console if a resource fails to load.
Moved console-tests.js to http tests. Added support for sorting
console messages, in case order may vary.
https://bugs.webkit.org/show_bug.cgi?id=37215

  • http/tests/inspector/console-resource-errors-expected.txt: Added.
  • http/tests/inspector/console-resource-errors.html: Added.
  • http/tests/inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontend_dumpConsoleMessages):
  • inspector/console-clear.html:
  • inspector/console-dir.html:
  • inspector/console-dirxml.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format.html:
  • inspector/console-log-before-inspector-open.html:
  • inspector/console-tests.html:
  • inspector/console-tests.js: Removed.

2010-04-27 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
https://bugs.webkit.org/show_bug.cgi?id=37215

Test: http/tests/inspector/console-resource-errors.html

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
11:17 Changeset [58317] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

2010-04-26 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add specialized thunks for a char code related string functions
https://bugs.webkit.org/show_bug.cgi?id=38177

This is a simple extension to my prior patch. Basically hoist the
existing character loading logic from the charCodeAt thunk and into
a helper function, then add a helper to load strings from the small
string cache. This allows trivial implementations of fromCharCode
and charAt.

  • create_hash_table:
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnJSCell): (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
  • jit/ThunkGenerators.cpp: (JSC::stringCharLoad): (JSC::charToString): (JSC::charCodeAtThunkGenerator): (JSC::charAtThunkGenerator): (JSC::fromCharCodeThunkGenerator):
  • jit/ThunkGenerators.h:
  • runtime/SmallStrings.h: (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
10:58 Changeset [58316] by vitalyr@chromium.org
  • 2 edits in trunk/WebCore

2010-04-27 Vitaly Repeshko <vitalyr@chromium.org>

Reviewed by Nate Chapin.

[V8] Fix XHR memory leak in GC controller.
https://bugs.webkit.org/show_bug.cgi?id=38202

http://trac.webkit.org/changeset/55798 simplified processing of
active DOM objects but introduced a subtle bug in garbage
collection of XHRs. ActiveDOMObject is not a direct base class of
XHR and so upcasting changes pointer identity and breaks DOM
maps. This leads to forever live persistent handles to XHR that
had pending activity while V8 GC happened.

  • bindings/v8/V8GCController.cpp: (WebCore::GCEpilogueVisitor::visitDOMWrapper):
10:54 Changeset [58315] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Adam Barth <abarth@webkit.org>

Unreviewed. Regenerate reference bindings code generator output.

  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::withScriptStateVoidCallback): (WebCore::TestObjInternal::withScriptStateObjCallback):
10:50 Changeset [58314] by eric@webkit.org
  • 14 edits in trunk/WebKitTools

2010-04-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

[chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
https://bugs.webkit.org/show_bug.cgi?id=37987

After further research, I believe the hang is caused by:
http://bugs.python.org/issue2320
Basically Popen() is not reentrant.
The workaround is to pass close_fds=True to Popen() on Mac/Linux.

I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
when appropriate.

I audited all places we call Popen() and either moved them to run_command
or left a FIXME that they are not thread safe. A few places I added the
close_fds workaround there and left an explanitory note.

  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Added note that this Popen use is not threadsafe.
  • Scripts/webkitpy/common/system/executive.py:
    • Fixed our Executive.run_* to workaround python bug 2320.
  • Scripts/webkitpy/common/system/user.py: _ Added note that this Popen use is not threadsafe.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
  • Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Change wdiff back to using run_command now that we believe it to be threadsafe.
  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • Fix to use Executive in places.
    • Pass self._executive down to the Driver for easier unit testing.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Re-factor to use a _kill_all method.
    • Made the _kill_all method use run_command to be threadsafe.
  • Scripts/webkitpy/layout_tests/port/http_server.py:
    • Add FIXME about using Executive.
  • Scripts/webkitpy/layout_tests/port/server_process.py:
    • Use Executive to be threadsafe.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Pass self._executive down to the Driver.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
    • Add note about Popen not being threadsafe.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • Move one caller to run_command add notes about moving others.
10:19 Changeset [58313] by joepeck@webkit.org
  • 6 edits
    4 adds in trunk

2010-04-27 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Dan Bernstein.

<input type="search"> with uneven padding causes text clipping
https://bugs.webkit.org/show_bug.cgi?id=38160

  • fast/css/input-search-padding.html: Added.
  • platform/mac/fast/css/input-search-padding-expected.checksum: Added.
  • platform/mac/fast/css/input-search-padding-expected.png: Added.
  • platform/mac/fast/css/input-search-padding-expected.txt: Added.

2010-04-27 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Dan Bernstein.

<input type="search"> with uneven padding causes text clipping
https://bugs.webkit.org/show_bug.cgi?id=38160

Test: fast/css/input-search-padding.html

An <input type="search"> contains an inner block, which is explicitly
centered in RenderTextControlSingleLine based on the height of the element.
However, the clipping rect was not using the set location, and instead
calculated off of the top border and padding alone. This also vertically
centers the Caps Lock indicator.

  • rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
  • rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator (WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
  • rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">
09:39 Changeset [58312] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Restore breakpoints associated with script's URL once
script is parsed.
https://bugs.webkit.org/show_bug.cgi?id=38132

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.initUI): (devtools.DebuggerAgent.prototype.addBreakpoint): (devtools.DebuggerAgent.prototype.addScriptInfo_): (devtools.DebuggerAgent.prototype.restoreBreakpoints_): (devtools.BreakpointInfo): (devtools.BreakpointInfo.prototype.enabled): (devtools.BreakpointInfo.prototype.condition):
07:48 Changeset [58311] by pfeldman@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-04-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chrome Dev Tools: Further beautify themes.

https://bugs.webkit.org/show_bug.cgi?id=38187

  • src/js/DevTools.js: (WebInspector.setToolbarColors):
  • src/js/devTools.css: (body.platform-windows #toolbar, body.platform-windows.inactive #toolbar):
07:27 Changeset [58310] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix linking on Symbian on Linux using the Makefile based mkspec.

Patch by Thomas Zander <t.zander@nokia.com> on 2010-04-27
Reviewed by Simon Hausmann.

Disable thumb mode due to library size limitations, just like it's done
for the sbs/sbsv2 based build system.

  • WebCore.pro:
07:24 Changeset [58309] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Fix the build on Symbian on Linux using the Makefile based mkspec

Patch by Thomas Zander <t.zander@nokia.com> on 2010-04-27
Reviewed by Simon Hausmann.

  • JavaScriptCore.pri: It is necessary to specify the library search path

when linking against JavaScriptCore.

06:56 Changeset [58308] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk/JavaScriptCore

Compile fix for Visual Studio 2010
https://bugs.webkit.org/show_bug.cgi?id=37867

Reviewed by Simon Hausmann.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com>

  • runtime/Structure.cpp:

(JSC::Structure::transitionTableAdd):

  • wtf/MathExtras.h:
  • wtf/Platform.h:
06:56 Changeset [58307] by jocelyn.turcotte@nokia.com
  • 9 edits in trunk/JavaScriptCore

Rename COMPILER(MSVC7) to COMPILER(MSVC7_OR_LOWER)

Reviewed by Simon Hausmann.

  • config.h:

(JSC::Structure::transitionTableAdd):

  • wtf/Assertions.h:
  • wtf/Atomics.h:
  • wtf/CurrentTime.h:

(WTF::getLocalTime):

  • wtf/Platform.h:
  • wtf/StaticConstructors.h:
  • wtf/StringExtras.h:
  • wtf/Vector.h:

(WTF::::append):

06:55 Changeset [58306] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/JavaScriptCore

[Qt] Fix Mac build break.

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=37867

  • Make sure JavaScriptCore's debug_and_release config follows that of WebCore.
  • Use different name for JavaScriptCore target in debug and release since they might be written in the same path at the same time on parallel builds
  • Consolidate the DESTDIR determination logic in JavaScriptCore.pri
06:55 Changeset [58305] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk

[Qt] Make sure WebKit is not compiled using C++0x.
https://bugs.webkit.org/show_bug.cgi?id=37867

Reviewed by Kenneth Rohde Christiansen.

As the rest of Qt compiles in the C++0x mode, people might start
compiling it in this mode. WebKit don't support this yet.

Patch by Thiago Macieira <thiago.macieira@nokia.com>

JavaScriptCore:

WebCore:

  • WebCore.pro:
05:56 Changeset [58304] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Jeremy Orlow <jorlow@chromium.org>

Unreviewed. Previous disabling only did so via
TIMEOUT failures. Needs to ignore TEXT failures
on quota-tracking.html as well.

  • platform/chromium/test_expectations.txt:
05:05 Changeset [58303] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-27 Jeremy Orlow <jorlow@chromium.org>

Unreviewed. Disable quota-tracking in Chromium
until Dumi can take a look.

  • platform/chromium/test_expectations.txt:
04:18 Changeset [58302] by jorlow@chromium.org
  • 10 edits in trunk

2010-04-27 Jeremy Orlow <jorlow@chromium.org>

Unreviewed build fix.

Revert 58274 and 58269 (WebSQLDatabase changes)
https://bugs.webkit.org/show_bug.cgi?id=38191

  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:

2010-04-27 Jeremy Orlow <jorlow@chromium.org>

Unreviewed build fix.

Revert 58274 and 58269 (WebSQLDatabase changes)
https://bugs.webkit.org/show_bug.cgi?id=38191

Chromium bots are hitting ASSERTS when running layout tests.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::maximumSize): (WebCore::SQLiteDatabase::freeSpaceSize):
  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):
  • storage/Database.cpp: (WebCore::Database::performOpenAndVerify):
  • storage/Database.h:
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit):
03:54 Changeset [58301] by yuzo@google.com
  • 8 edits
    2 deletes in trunk

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed, fix build breakage by reverting r58299.

https://bugs.webkit.org/show_bug.cgi?id=35329

  • fast/css/parsing-page-rule-expected.txt: Removed.
  • fast/css/parsing-page-rule.html: Removed.

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed, fix build breakage by reverting r58299.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::clearProperties):
  • css/CSSParser.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/tokenizer.flex:
02:53 Changeset [58300] by yuzo@google.com
  • 2 edits in trunk/WebCore

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

WebCore::CSSSelector::RareData::parseNth doesn't check whether the search for '-' in the argument was successful.
This results in incorrect parsing.
For example, '3n' is parsed as if it were '3n-3'. The code has been working OK just accidentally.

https://bugs.webkit.org/show_bug.cgi?id=37787

No new tests are added because the original behavior is accidentally OK.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::RareData::parseNth):
02:38 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
02:35 Changeset [58299] by yuzo@google.com
  • 8 edits
    2 adds in trunk

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Hyatt.

Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

https://bugs.webkit.org/show_bug.cgi?id=35329

  • fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
  • fast/css/parsing-page-rule.html: Added.

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Reviewed by David Hyatt.

Enhance CSS parser for Paged Media (Iteration 1)

In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
The contents of the methods should be implemented by other changes.

https://bugs.webkit.org/show_bug.cgi?id=35329

Test: fast/css/parsing-page-rule.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::lex): (WebCore::CSSParser::text): (WebCore::CSSParser::createPageRule): (WebCore::CSSParser::createMarginAtRule): (WebCore::CSSParser::startDeclarationsForMarginBox): (WebCore::CSSParser::endDeclarationsForMarginBox):
  • css/CSSParser.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/tokenizer.flex:
02:32 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
02:29 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
02:27 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
02:26 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
02:12 Changeset [58298] by abarth@webkit.org
  • 14 edits
    1 delete in trunk/WebCore

2010-04-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove custom bindings for TreeWalker
https://bugs.webkit.org/show_bug.cgi?id=38182

This custom code is just CallWith=ScriptState.

  • WebCore.gypi:
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::markChildren):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: Removed.
  • dom/TreeWalker.idl:
02:10 Changeset [58297] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-27 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
https://bugs.webkit.org/show_bug.cgi?id=38186

Unfortunately, we don't have a good way of testing this change because
our test coverage of the scm.py API is poor...

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
01:44 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
01:02 Changeset [58296] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move code out of GenerateImplementation to make it more smaller
https://bugs.webkit.org/show_bug.cgi?id=38176

  • bindings/scripts/CodeGeneratorJS.pm:
    • Move some code into a new GenerateAttributesHashTable method.
00:15 Changeset [58295] by abarth@webkit.org
  • 14 edits in trunk/WebCore

2010-04-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add CallWith=DynamicFrame to CodeGenerator
https://bugs.webkit.org/show_bug.cgi?id=38174

I've only used this in one instance, but this is infrastructure that I
think will help remove a bunch of custom bindings code. Also, added a
few tests of tricky argument cases.

  • bindings/js/JSHTMLFormElementCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_with_dynamic_frame): (webkit_dom_test_obj_with_dynamic_frame_and_arg): (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrame): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::withDynamicFrameCallback): (WebCore::TestObjInternal::withDynamicFrameAndArgCallback): (WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback): (WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback): (WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback): (WebCore::):
  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:
  • html/HTMLFormElement.idl:

04/26/10:

23:28 Changeset [58294] by jam@chromium.org
  • 3 edits
    1 add in trunk/WebKit/chromium

2010-04-26 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Prepare to making WebThemeEngine cross-platform
https://bugs.webkit.org/show_bug.cgi?id=38077

  • WebKit.gyp:
  • public/WebThemeEngine.h: Added.
  • public/win/WebThemeEngine.h:
23:19 Changeset [58293] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove unused code from text_diff.py
https://bugs.webkit.org/show_bug.cgi?id=38170

  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
    • Remove is_render_tree_dump which appears unused.
23:10 Changeset [58292] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-26 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[Chromium] Crash after calling window.print() on a window object that has been closed.
https://bugs.webkit.org/show_bug.cgi?id=38148

It is unfortunately not possible to write a layout test for this as the
crash occurs in an API that is only called by Chrome while showing a
print dialog.

  • src/WebViewImpl.cpp: (WebKit::WebView::willEnterModalLoop): (WebKit::WebView::didExitModalLoop):
22:56 Changeset [58291] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch pretty-diff is broken
https://bugs.webkit.org/show_bug.cgi?id=38172

We need to register for these options because they're used when we look
up the diff.

  • Scripts/webkitpy/tool/steps/confirmdiff.py:
22:30 Changeset [58290] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Adam Barth <abarth@webkit.org>

Unreviewed. Update comment to better reflect reality.

  • bindings/scripts/test/TestObj.idl:
22:01 Changeset [58289] by abarth@webkit.org
  • 3 edits
    8 adds in trunk

2010-04-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add ObjC and GObject to run-bindings-test
https://bugs.webkit.org/show_bug.cgi?id=38168

Added expected results.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Added. (WebKit::kit): (webkit_dom_test_obj_void_method): (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_with_exception): (webkit_dom_test_obj_method_with_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args): (webkit_dom_test_obj_get_read_only_int_attr): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_int_attr): (webkit_dom_test_obj_set_int_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_attr_with_exception): (webkit_dom_test_obj_set_attr_with_exception): (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_get_attr_with_getter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (WebKit::wrapTestObj): (WebKit::core): (webkit_dom_test_obj_finalize): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init): (webkit_dom_test_obj_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h: Added.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Added.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Added. (-[DOMTestObj dealloc]): (-[DOMTestObj finalize]): (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]): (core): (kit):
  • bindings/scripts/test/ObjC/DOMTestObjInternal.h: Added.

2010-04-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add ObjC and GObject to run-bindings-test
https://bugs.webkit.org/show_bug.cgi?id=38168

  • Scripts/run-bindings-tests:
21:49 Changeset [58288] by abarth@webkit.org
  • 4 edits
    2 moves
    4 adds in trunk

2010-04-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add testing infrastructure for JSC bindings generator
https://bugs.webkit.org/show_bug.cgi?id=38167

This required moving the test files around a bit more.

  • bindings/scripts/test/JS/JSTestObj.cpp: Added. (WebCore::): (WebCore::JSTestObjConstructor::JSTestObjConstructor): (WebCore::JSTestObjConstructor::classInfo): (WebCore::JSTestObjConstructor::createStructure): (WebCore::JSTestObjConstructor::getOwnPropertySlot): (WebCore::JSTestObjConstructor::getOwnPropertyDescriptor): (WebCore::JSTestObjPrototype::self): (WebCore::JSTestObjPrototype::getOwnPropertySlot): (WebCore::JSTestObjPrototype::getOwnPropertyDescriptor): (WebCore::JSTestObj::JSTestObj): (WebCore::JSTestObj::~JSTestObj): (WebCore::JSTestObj::createPrototype): (WebCore::JSTestObj::getOwnPropertySlot): (WebCore::JSTestObj::getOwnPropertyDescriptor): (WebCore::jsTestObjReadOnlyIntAttr): (WebCore::jsTestObjReadOnlyStringAttr): (WebCore::jsTestObjReadOnlyTestObjAttr): (WebCore::jsTestObjIntAttr): (WebCore::jsTestObjStringAttr): (WebCore::jsTestObjTestObjAttr): (WebCore::jsTestObjAttrWithException): (WebCore::jsTestObjAttrWithSetterException): (WebCore::jsTestObjAttrWithGetterException): (WebCore::jsTestObjCustomAttr): (WebCore::jsTestObjConstructor): (WebCore::JSTestObj::put): (WebCore::setJSTestObjIntAttr): (WebCore::setJSTestObjStringAttr): (WebCore::setJSTestObjTestObjAttr): (WebCore::setJSTestObjAttrWithException): (WebCore::setJSTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithGetterException): (WebCore::setJSTestObjCustomAttr): (WebCore::JSTestObj::getConstructor): (WebCore::jsTestObjPrototypeFunctionVoidMethod): (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionIntMethod): (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionObjMethod): (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithException): (WebCore::jsTestObjPrototypeFunctionCustomMethod): (WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): (WebCore::toJS): (WebCore::toTestObj):
  • bindings/scripts/test/JS/JSTestObj.h: Added. (WebCore::JSTestObj::classInfo): (WebCore::JSTestObj::createStructure): (WebCore::JSTestObj::impl): (WebCore::JSTestObjPrototype::classInfo): (WebCore::JSTestObjPrototype::createStructure): (WebCore::JSTestObjPrototype::JSTestObjPrototype):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: Renamed from WebCore/bindings/scripts/test/V8TestObj.cpp. (WebCore::): (WebCore::TestObjInternal::V8_USE): (WebCore::TestObjInternal::readOnlyIntAttrAttrGetter): (WebCore::TestObjInternal::readOnlyStringAttrAttrGetter): (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrSetter): (WebCore::TestObjInternal::stringAttrAttrGetter): (WebCore::TestObjInternal::stringAttrAttrSetter): (WebCore::TestObjInternal::testObjAttrAttrGetter): (WebCore::TestObjInternal::testObjAttrAttrSetter): (WebCore::TestObjInternal::attrWithExceptionAttrGetter): (WebCore::TestObjInternal::attrWithExceptionAttrSetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter): (WebCore::TestObjInternal::voidMethodCallback): (WebCore::TestObjInternal::voidMethodWithArgsCallback): (WebCore::TestObjInternal::intMethodCallback): (WebCore::TestObjInternal::intMethodWithArgsCallback): (WebCore::TestObjInternal::objMethodCallback): (WebCore::TestObjInternal::objMethodWithArgsCallback): (WebCore::TestObjInternal::methodWithExceptionCallback): (WebCore::TestObjInternal::methodWithOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): (WebCore::TestObjInternal::overloadedMethod1Callback): (WebCore::TestObjInternal::overloadedMethod2Callback): (WebCore::TestObjInternal::overloadedMethod3Callback): (WebCore::TestObjInternal::overloadedMethod4Callback): (WebCore::TestObjInternal::overloadedMethodCallback): (WebCore::ConfigureV8TestObjTemplate): (WebCore::V8TestObj::GetRawTemplate): (WebCore::V8TestObj::GetTemplate): (WebCore::V8TestObj::toNative): (WebCore::V8TestObj::HasInstance): (WebCore::V8TestObj::wrap): (WebCore::toV8): (WebCore::V8TestObj::derefObject):
  • bindings/scripts/test/V8/V8TestObj.h: Renamed from WebCore/bindings/scripts/test/V8TestObj.h.

2010-04-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add testing infrastructure for JSC bindings generator
https://bugs.webkit.org/show_bug.cgi?id=38167

Add support for testing more than one bindings. Also, converted the
script to PEP8 style.

  • Scripts/run-bindings-tests:
21:39 Changeset [58287] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix windows

21:22 Changeset [58286] by oliver@apple.com
  • 21 edits
    3 adds in trunk

2010-04-26 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Need to support more efficient dispatch of lightweight builtins
https://bugs.webkit.org/show_bug.cgi?id=38155

The problem with calling lightweight builtins is that marshalling
the call from the nitro calling convention to the system calling
convention is very expensive relative to the cost of the actually
evaluating the function. To work around this problem this patch
adds the ability to define a custom thunk for a builtin.

This allows us to use high performance custom implementations of
the common and sensible versions of simple builtins. This patch
includes a simple (use of which is currently hardcoded) thunk for
charCodeAt.

This adds a JSInterfaceJIT subclass called SpecializedThunkJIT
that has helper functions to remove (or at least reduce) the need
to have separate thunk implementations for each JSValue encoding.

  • create_hash_table: Add thunk generation callbacks to the hash tables, currently we hardcode the script to only support charCodeAt
  • jit/JITStubCall.h:
  • jit/JITStubs.cpp: (JSC::JITThunks::~JITThunks): (JSC::JITThunks::specializedThunk):
  • jit/JITStubs.h:
  • jit/SpecializedThunkJIT.h: Added. (JSC::SpecializedThunkJIT::SpecializedThunkJIT): (JSC::SpecializedThunkJIT::loadCellArgument): (JSC::SpecializedThunkJIT::loadJSStringArgument): (JSC::SpecializedThunkJIT::loadInt32Argument): (JSC::SpecializedThunkJIT::appendFailure): (JSC::SpecializedThunkJIT::returnInt32): (JSC::SpecializedThunkJIT::finalize): (JSC::SpecializedThunkJIT::argumentToVirtualRegister): (JSC::SpecializedThunkJIT::tagReturnAsInt32):
  • jit/ThunkGenerators.cpp: Added. (JSC::ThunkHelpers::stringImplDataOffset): (JSC::ThunkHelpers::jsStringLengthOffset): (JSC::ThunkHelpers::jsStringValueOffset): (JSC::charCodeAtThunkGenerator):
  • jit/ThunkGenerators.h: Added.
  • runtime/Executable.h: (JSC::NativeExecutable::NativeExecutable):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction):
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::getThunk):
  • runtime/JSString.h: (JSC::):
  • runtime/JSValue.h: Protect some of the JSVALUE32 and JSVALUE32_64 only constants and function behind appropriate USE() guards to make it harder to use the wrong flags for the target build.
  • runtime/Lookup.cpp: (JSC::HashTable::createTable): (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::HashEntry::initialize): (JSC::HashEntry::generator): (JSC::HashEntry::): Make the lookup tables use a specialized thunkGenerator if present
  • wtf/text/StringImpl.h:

2010-04-26 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Need to support more efficient dispatch of lightweight builtins
https://bugs.webkit.org/show_bug.cgi?id=38155

Update bindings generation to include new thunk generator field
in the property map hash tables.

  • bindings/scripts/CodeGeneratorJS.pm:
21:21 Changeset [58285] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-26 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Refactor results.html generation out into a new method and test it
https://bugs.webkit.org/show_bug.cgi?id=38164

Hopefully this results in no change in functionality.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
21:12 Changeset [58284] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix

20:45 Changeset [58283] by oliver@apple.com
  • 4 edits
    1 add in trunk/JavaScriptCore

2010-04-26 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Factor some basic JS interface logic out of JIT and into a superclass
https://bugs.webkit.org/show_bug.cgi?id=38163

Create JSInterfaceJIT to hold some common low level functions for
interacting with the JS RegisterFile. Doing this separately from
https://bugs.webkit.org/show_bug.cgi?id=38155 to ease reviewing.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
  • jit/JSInterfaceJIT.h: Added. (JSC::JSInterfaceJIT::emitLoadJSCell): (JSC::JSInterfaceJIT::emitJumpIfNotJSCell): (JSC::JSInterfaceJIT::emitLoadInt32): (JSC::JSInterfaceJIT::tagFor): (JSC::JSInterfaceJIT::payloadFor): (JSC::JSInterfaceJIT::addressFor):
20:36 Changeset [58282] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Adam Barth <abarth@webkit.org>

Unreviewed, rolling out r58265.
http://trac.webkit.org/changeset/58265
https://bugs.webkit.org/show_bug.cgi?id=38021

This change prevents me from uploading patches. It also breaks sheriff-bot.

  • Scripts/webkitpy/tool/steps/options.py:
20:35 Changeset [58281] by abarth@webkit.org
  • 3 edits
    3 moves
    1 add in trunk

2010-04-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move bindings test directory into the scripts directory
https://bugs.webkit.org/show_bug.cgi?id=38161

This test is really of the bindings scripts not of the bindings
themselves. By moving the files into the scripts directory, we'll be
able to test JSC as well.

  • bindings/scripts/test/TestObj.idl: Renamed from WebCore/bindings/v8/test/TestObj.idl.
  • bindings/scripts/test/V8TestObj.cpp: Renamed from WebCore/bindings/v8/test/V8TestObj.cpp. (WebCore::): (WebCore::TestObjInternal::V8_USE): (WebCore::TestObjInternal::readOnlyIntAttrAttrGetter): (WebCore::TestObjInternal::readOnlyStringAttrAttrGetter): (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrGetter): (WebCore::TestObjInternal::intAttrAttrSetter): (WebCore::TestObjInternal::stringAttrAttrGetter): (WebCore::TestObjInternal::stringAttrAttrSetter): (WebCore::TestObjInternal::testObjAttrAttrGetter): (WebCore::TestObjInternal::testObjAttrAttrSetter): (WebCore::TestObjInternal::attrWithExceptionAttrGetter): (WebCore::TestObjInternal::attrWithExceptionAttrSetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter): (WebCore::TestObjInternal::voidMethodCallback): (WebCore::TestObjInternal::voidMethodWithArgsCallback): (WebCore::TestObjInternal::intMethodCallback): (WebCore::TestObjInternal::intMethodWithArgsCallback): (WebCore::TestObjInternal::objMethodCallback): (WebCore::TestObjInternal::objMethodWithArgsCallback): (WebCore::TestObjInternal::methodWithExceptionCallback): (WebCore::TestObjInternal::methodWithOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback): (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): (WebCore::TestObjInternal::overloadedMethod1Callback): (WebCore::TestObjInternal::overloadedMethod2Callback): (WebCore::TestObjInternal::overloadedMethod3Callback): (WebCore::TestObjInternal::overloadedMethod4Callback): (WebCore::TestObjInternal::overloadedMethodCallback): (WebCore::ConfigureV8TestObjTemplate): (WebCore::V8TestObj::GetRawTemplate): (WebCore::V8TestObj::GetTemplate): (WebCore::V8TestObj::toNative): (WebCore::V8TestObj::HasInstance): (WebCore::V8TestObj::wrap): (WebCore::toV8): (WebCore::V8TestObj::derefObject):
  • bindings/scripts/test/V8TestObj.h: Renamed from WebCore/bindings/v8/test/V8TestObj.h.

2010-04-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move bindings test directory into the scripts directory
https://bugs.webkit.org/show_bug.cgi?id=38161

Change script to point to the new location of these data files.

  • Scripts/run-bindings-tests:
20:07 Changeset [58280] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Daniel Cheng <dcheng@chromium.org>

Reviewed by Jian Li.

[chromium] Fix ChromiumDataObject::setURL to not populate its internal URL list with empty URLs.
https://bugs.webkit.org/show_bug.cgi?id=38159

No new tests.

  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::setURL):
19:33 Changeset [58279] by eric@webkit.org
  • 10 edits
    2 adds in trunk/WebKitTools

2010-04-26 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

[chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
https://bugs.webkit.org/show_bug.cgi?id=37987

Rolled out:
http://trac.webkit.org/changeset/58062
http://trac.webkit.org/changeset/58060
http://trac.webkit.org/changeset/58059
http://trac.webkit.org/changeset/58055
http://trac.webkit.org/changeset/58054
and parts of:
http://trac.webkit.org/changeset/58050

I also wrote some new comments and a tiny amount of new
code to help make ChromiumDriver.run_test easier to read.

In order to unit-test my new code, I had to change ChromiumDriver
to not automatically start itself when created. That ended up
being a lot of plumbing, but is hopefully easier to understand now.

There are no tests for the (restored) wdiff code. wdiff does not
exist on all systems, so for now we will assume it worked since
it is just old code being reverted.

  • Scripts/webkitpy/layout_tests/driver_test.py:
    • Use create_driver instead of start_driver, and be sure to call .stop()
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Use create_driver instead of start_driver
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Added a comment to explain that diffs are binary files.
    • Various patch reverts relating to wdiff
    • Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver.
    • Made _command_wrapper use shlex.split to get rid of the FIXME.
  • Scripts/webkitpy/layout_tests/port/base_unittest.py: Added.
    • test the new _command_wrapper
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Use _command_wrapper to get rid of a bunch of ugly code.
  • Make init stop auto-starting.
  • Rename create_driver to start_driver.
  • Added _write_command_and_read_line to make it possible to put a FIXME next to read_line() w/o having to put it in two places.
  • Moved test_shell command building into _test_shell_command and tested it.
  • Fix comments to say test_shell since ChromiumDriver is test_shell only.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added.
    • Test the new test_shell_command method.
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
    • Rename create_driver to start_driver.
  • Scripts/webkitpy/layout_tests/port/test.py:
    • Rename create_driver to start_driver.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Rename create_driver to start_driver.
    • Treat output as binary arrays.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
    • Treat diff files as binary.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
    • Treat diff files as binary.
19:22 Changeset [58278] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Adam Barth <abarth@webkit.org>

Unreviewed. Mark run-bindings-tests executable so we can execute it.

  • Scripts/run-bindings-tests:
19:12 Changeset [58277] by yuzo@google.com
  • 1 edit
    1 move
    1 add
    1 delete in trunk/LayoutTests

2010-04-26 Yuzo Fujishima <yuzo@google.com>

Unreviewed, Chromium test expectation change.

To keep up with the change that turned on HTML5 DB AUTO_VACUUM.
https://bugs.webkit.org/show_bug.cgi?id=36251

  • platform/chromium-mac/storage/quota-tracking-expected.txt: Removed.
  • platform/chromium-win/storage/quota-tracking-expected.txt: Removed.
  • platform/chromium/storage/quota-tracking-expected.txt: Added.
18:32 Changeset [58276] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Daniel Cheng <dcheng@chromium.org>

Reviewed by Jian Li.

[Chromium] Don't make file paths available in text/uri-list when dragging files.
https://bugs.webkit.org/show_bug.cgi?id=25882

Test will be checked in with WebCore/platform/mac fix.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::types):
18:26 Changeset [58275] by tony@chromium.org
  • 4 edits in trunk/WebKitTools

2010-04-26 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] build-webkit --chromium should build release by default
https://bugs.webkit.org/show_bug.cgi?id=38028

  • Scripts/build-dumprendertree: Also should build release by default
  • Scripts/build-webkit: Make sure to pass command line args through
  • Scripts/webkitdirs.pm: Build the right configuration
17:37 Changeset [58274] by dumi@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing the build breakage introduced by r58269.

Turning on AUTO_VACUUM has increased the amount of space used by databases.

  • storage/quota-tracking-expected.txt:
  • storage/quota-tracking.html:
17:09 Changeset [58273] by mjs@apple.com
  • 9 edits in trunk/WebCore

2010-04-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

REGRESSION (r57292): 1.5% page load speed regression from visited link information leak fix
https://bugs.webkit.org/show_bug.cgi?id=38131

I did a number of separate optimizations which speed up style
resolution enough to more than make up for the regression. This
measures as a total PLT speedup of somewhere between 1.5% and
3.7%.


Optimizations done:

  • Cache determineLinkState results, to avoid the need to repeatedly compute the visited link hash for the same element. This directly addresses much of the slowdown, since all elements get their style computed twice now.
  • Added a fast way to get the length of a CSSMutableStyleDeclaration, and use in CSSStyleSelector::matchRulesForList, since it was hot there.
  • Hoist some loop invariant code that's not detected by the compiler out of the main loop in matchRulesForList
  • inline CSSStyleSelector::initElement and locateSharedStyle, since there is only one call site in each case
  • Inline the common non-line fast case of determineLinkState, and split the rest into out-of-line determineLinkStateSlowCase.
  • Added inline versions of the functions called by visitedLinkHash (the version called by determineLinkState).
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::length): Implemented in terms of new inline nonvirtual mutableLength().
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::mutableLength): Added new nonvirtual inline way to get the length if you know you have a mutable style decl.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::init): Clear cached link state. (WebCore::CSSStyleSelector::matchRulesForList): hoist some code out of the main loop and get style decl length more efficiently. (WebCore::CSSStyleSelector::initElement): inline (only one call site) (WebCore::CSSStyleSelector::SelectorChecker::determineLinkState): Inline fast case, call slow case. (WebCore::CSSStyleSelector::SelectorChecker::determineLinkStateSlowCase): Split most of the above function into this slow case helper. (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the cache-enabled way to get the current link state. (WebCore::CSSStyleSelector::locateSharedStyle): inline (WebCore::CSSStyleSelector::styleForElement): Use the cache-enabled way to get the current link state.
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::currentElementLinkState): inline way to get link state for the current element; manages the cache
  • platform/LinkHash.cpp: (WebCore::visitedLinkHashInline): inline version of below function (WebCore::visitedLinkHash): call the inline version (WebCore::visitedURLInline): inline version of below function (WebCore::visitedURL): call the inline version (WebCore::visitedURL): call inline versions of above two functions
16:30 Changeset [58272] by weinig@apple.com
  • 2 edits in trunk/WebCore

Remove last use of WEB_THREAD.

Reviewed by Alexey Proskuryakov.

  • platform/mac/WebCoreObjCExtras.mm:

(WebCoreObjCScheduleDeallocateOnMainThread): This can always use
isMainThread().

16:10 Changeset [58271] by crogers@google.com
  • 2 adds in branches/audio/WebCore/audio

initial commit test

15:58 Changeset [58270] by dumi@chromium.org
  • 7 edits in trunk/WebCore

Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases, and
vacuum all databases when the number of free pages is at least 10%
of the number of total pages. Also, adding a guard against a bug
that was fixed in SQLite only starting with version 3.6.16.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=36251

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):

  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

  • storage/Database.cpp:

(WebCore::Database::performOpenAndVerify):
(WebCore::Database::incrementalVacuumIfNeeded):

  • storage/Database.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::postflightAndCommit):

15:45 Changeset [58269] by crogers@google.com
  • 1 copy in branches/audio

creating private audio branch to implement new audio features with javascript API

15:45 Changeset [58268] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Tiger build.

  • wtf/mac/MainThreadMac.mm:

(WTF::isMainThread):

15:44 Changeset [58267] by ggaren@apple.com
  • 9 edits in trunk

<rdar://problem/7766413>

Reviewed by Sam Weinig.

Fixed a crash seen when using the JavaScriptCore API with WebKit.

No layout test because DumpRenderTree doesn't use the JavaScriptCore API
in this way.

JavaScriptCore:

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::setGlobalObject):
(JSC::RegisterFile::clearGlobalObject):
(JSC::RegisterFile::globalObject):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::RegisterFile): Use WeakGCPtr for managing m_globalObject,
since it's a weak pointer. (We never noticed this error before because,
in WebKit, global objects always have a self-reference in a global variable,
so marking the register file's global variables would keep m_globalObject
alive. In the JavaScriptCore API, you can allocate a global object with
no self-reference.)

  • runtime/JSActivation.h: Removed unneeded #include.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::~JSGlobalObject): Don't use ==, since a weak
pointer is 0 when the object it points to runs its destructor.

  • runtime/WeakGCPtr.h:

(JSC::WeakGCPtr::clear): Changed to return a bool indicating whether the
clear actually happened.
(JSC::WeakGCPtr::assign): Changed to forbid assignment of 0 as a shorthand
for calling clear(). A client should never clear by assigning 0, since
clear() should be conditional on whether the object doing the clearing
is still pointed to by the weak pointer. (Otherwise, a zombie object might
clear a pointer to a new, valid object.)

WebCore:

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener): Don't assign 0 to a WeakGCPtr.
JavaScriptCore no longer allows this.

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::setWrapper): No need to initialize a WeakGCPtr
to 0, or ASSERT a non-0 value before assigning to a WeakGCPtr -- both are
default behaviors.

15:38 Changeset [58266] by weinig@apple.com
  • 56 edits in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
Disentangle initializing the main thread from initializing threading

Reviewed by Maciej Stachowiak.

JavaScriptCore:

This is the first step in getting rid of the WEB_THREAD #define and
paving the way to allowing mac both WebKit and WebKit2 to use the same
WebCore.

  • JavaScriptCore.exp: Export initializeMainThread and initializeMainThreadToProcessMainThread.
  • JavaScriptCore.xcodeproj/project.pbxproj: Sort files.
  • wtf/MainThread.cpp:

(WTF::mainThreadInitializationMutex):
(WTF::mainThreadFunctionQueueMutex):
(WTF::initializeMainThread):
(WTF::deprecatedInitializeMainThread):

  • wtf/MainThread.h:

Added Mac only initializeMainThreadToProcessMainThread which sets up callOnMainThread
and isMainThead calls to assume that WebCore's main thread is also the
process's main thread. Since it is possible that both initializeMainThread
and initializeMainThreadToProcessMainThread could be called, the first one called
wins (either will work).

  • wtf/Threading.h: Moved to top of file.
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Remove call to initializeMainThread.

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading): Ditto.

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeThreading): Ditto.

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::initializeMainThreadToProcessMainThread):
(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::isMainThread):
Add runtime switch between the old behavior of using the system's main
thread and a stored pointer to the main thread. Tiger always uses the
system's main thread.

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeThreading): Remove call to initializeMainThread.

  • wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform): Add call to initializeCurrentThreadInternal
removed from initializeThreading.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Sort files.
  • accessibility/mac/AccessibilityObjectWrapper.mm: Remove unnessary

+initialize method. The AccessibilityObjectWrapper has no data members
that need to be derefed, so it does not need to be finalized on the main
thread.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject initialize]): Add call to initializeMainThreadToProcessMainThread.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::initializeThreading): Add call to initializeMainThread.

  • platform/mac/SharedBufferMac.mm:

(+[WebCoreSharedBufferData initialize]): Add call to initializeMainThreadToProcessMainThread.

WebKit/chromium:

  • src/WebKit.cpp:

(WebKit::initialize): Add call to initializeMainThread.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl): Ditto.

WebKit/gtk:

  • webkit/webkitprivate.cpp:

(webkit_init): Add call to initializeMainThread.

WebKit/mac:

Calls initializeMainThreadToProcessMainThread since there is no way to ensure
that the initialize method will be called on the main thread.

  • Carbon/CarbonWindowAdapter.mm:

(+[CarbonWindowAdapter initialize]): Add call to initializeMainThreadToProcessMainThread.

  • History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]): Ditto.

  • History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]): Ditto.

  • Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]): Ditto.

  • Misc/WebIconDatabase.mm:

(+[WebIconDatabase initialize]): Ditto.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]): Ditto.

  • Plugins/WebBaseNetscapePluginView.mm:

(+[WebBaseNetscapePluginView initialize]): Ditto.

  • Plugins/WebBasePluginPackage.mm:

(+[WebBasePluginPackage initialize]): Ditto.

  • Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]): Ditto.

  • WebCoreSupport/WebEditorClient.mm:

(+[WebEditCommand initialize]): Ditto.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(+[WebFramePolicyListener initialize]): Ditto.

  • WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]): Ditto.

  • WebView/WebDataSource.mm:

(+[WebDataSourcePrivate initialize]): Ditto.

  • WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]): Ditto.
(+[WebHTMLView initialize]): Ditto.

  • WebView/WebResource.mm:

(+[WebResourcePrivate initialize]): Ditto.

  • WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]): Ditto.

  • WebView/WebView.mm:
  • WebView/WebViewData.mm: Ditto.

(+[WebViewPrivate initialize]): Ditto.

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): Add call to initializeMainThread.

WebKit/win:

  • WebKitClassFactory.cpp:

(WebKitClassFactory::WebKitClassFactory): Add call to initializeMainThread.

  • WebView.cpp:

(WebView::WebView): Ditto.

WebKit/wx:

  • WebView.cpp:

(wxWebView::Create): Add call to initializeMainThread.

WebKit2:

  • UIProcess/Launcher/mac/WebProcessLauncher.mm:

(WebKit::webThreadBody): Add call to initializeMainThread.

  • UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::webThreadBody): Ditto.

  • WebProcess/Launching/mac/WebProcessMain.mm:

(main): Ditto.

  • WebProcess/win/WebProcessMain.cpp:

(WebKit::WebProcessMain): Ditto.

14:52 Changeset [58265] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-26 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

complete rietveld bugzilla integration
https://bugs.webkit.org/show_bug.cgi?id=38021

Makes --fancy-review the default. All this means is that the patch will
be uploaded to rietveld in addition to bugs.webkit.org.

  • Scripts/webkitpy/tool/steps/options.py:
14:43 Changeset [58264] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=38128
Don't add empty credential to CredentialStorage.

An empty credential is currently regarded as a invalid login because it means a missing value in
protectionSpaceToCredentialMap. This change makes it consistent with current WebCore's behavior
by ignoring empty credentials.

No new tests added since this only affects credential entered by user from credential dialog,
which is not testable in DRT.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedCredential):
14:01 Changeset [58263] by cjerdonek@webkit.org
  • 3 edits
    1 move in trunk/WebKitTools

For check-webkit-style, renamed the style/processors/ directory
to style/checkers/.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=38122

  • Scripts/webkitpy/style/checker.py:
    • Updated import statements.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated import statements.
  • Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors.
  • Scripts/webkitpy/style/processors: Removed.
  • Scripts/webkitpy/style/processors/init.py: Removed.
  • Scripts/webkitpy/style/processors/common.py: Removed.
  • Scripts/webkitpy/style/processors/common_unittest.py: Removed.
  • Scripts/webkitpy/style/processors/cpp.py: Removed.
  • Scripts/webkitpy/style/processors/cpp_unittest.py: Removed.
  • Scripts/webkitpy/style/processors/python.py: Removed.
  • Scripts/webkitpy/style/processors/python_unittest.py: Removed.
  • Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
  • Scripts/webkitpy/style/processors/text.py: Removed.
  • Scripts/webkitpy/style/processors/text_unittest.py: Removed.
12:26 Changeset [58262] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Clean-up WebCore.pro after now that JavaScriptCore is built separately
https://bugs.webkit.org/show_bug.cgi?id=38123

HAVE_STDINT_H, and HAVE_PTHREAD_NP_H no longer needs to be defined
for QtWebKit as JavaScriptCore is built separately. These defines are only
used by JavaScriptCore and for JavaScriptCore these are already
properly defined in JavaScriptCore/config.h.

No new tests, no new functionality.

  • WebCore.pro:
10:48 Changeset [58261] by ojan@chromium.org
  • 26 edits in trunk/WebKitTools

2010-04-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

Include git commits in the diff for webkit-patch upload/land.
https://bugs.webkit.org/show_bug.cgi?id=36394

Adds --squash, --no-squash and --git-commit.

--git-commit will use a specific local commit for land/upload.
If a commit-range is specified, then that range is treated as
a single squashed commit.

--squash will squash all local changes including working copy changes
into a single patch.

--no-squash is the legacy behavior (upload only considers the working copy,
land commits the working copy and then each local commit separately to SVN)

If neither is specified, then an informative error is raised if there is
more than one local commit or when there are local commit(s) and working
copy changes.

If the webkit-patch.squash git config parameter is set, then
that will be respected instead of raising an error.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/api_unittest.py:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/style/optparser.py: --git-since is removed and --git-commit no longer implies commit_id.. Instead, it treats that individual commit, but also supports commit ranges (e.g. commit_id..) as arguments.
  • Scripts/webkitpy/style/optparser_unittest.py:
  • Scripts/webkitpy/style_references.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/commit.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/postdiff.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
10:03 Changeset [58260] by evan@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2010-04-26 Roman Gershman <romange@google.com>

Reviewed by Adam Barth.

[Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.
The following manual test checks for desired behavior.

https://bugs.webkit.org/show_bug.cgi?id=37977

  • manual-tests/chromium/suggestions-popup-font-change.html: Added.
09:56 Changeset [58259] by evan@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-26 Roman Gershman <romange@google.com>

Reviewed by Adam Barth.

[Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.

https://bugs.webkit.org/show_bug.cgi?id=37977

  • src/SuggestionsPopupMenuClient.cpp: (WebKit::SuggestionsPopupMenuClient::initialize):
09:21 Changeset [58258] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

View modes names in CSSValueKeywords.in
https://bugs.webkit.org/show_bug.cgi?id=38125

View mode names has changed in previous patch but CSSValueKeywords.in file was
not updated.

  • css/CSSValueKeywords.in:
08:16 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
08:10 Changeset [58257] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix compilation with RVCT 4
https://bugs.webkit.org/show_bug.cgi?id=37727

Reviewed by Kenneth Rohde Christiansen.

Swap extern and declspec to fix visibility of symbol imported from QtGui.

  • page/qt/EventHandlerQt.cpp:
07:58 Changeset [58256] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-04-26 Ruben Van Boxem <vanboxem.ruben@gmail.com>

Reviewed by Adam Roben.

Fixes for Win64 compilation under gcc (mingw-w64)

  • WebCore/bridge/npapi.h: for win64 compatibility, mirroring mozilla-central, see Mozilla bug 560298
  • WebCore/platform/Arena.h: uword is used to cast from pointers here. unsigned long is 32-bit on Windows (but 64-bit on mac), and too small to hold a pointer. uintptr_t is 32-bit on 32-bit systems (mac, linux and windows) and 64-bit on all 64-bit systems
  • WebCore/platform/graphics/transforms/TransformationMatrix.h: let mingw-w64/w32 use MSVC codepath
  • WebCore/platform/text/TextStream.cpp: let mingw-w64 use MSVC codepath
  • WebCore/platform/text/TextStream.h: let mingw-w64 use MSVC codepath
  • WebCore/plugins/PluginView.cpp: fix pointer casts on WIN64 and let mingw-w64 use MSVC codepath
  • WebCore/plugins/win/PluginViewWin.cpp: fix pointer casts on WIN64
07:54 Changeset [58255] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Fix the include header <qstring.h> -> <QtCore/qstring.h>

Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2010-04-26
Reviewed by Simon Hausmann.

The module/header.h style inclusion removes the need to have -I$QTDIR/include/depending-module
in the include search path for the application.

  • Api/qwebkitversion.h:
07:37 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
07:33 Changeset [58254] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] HTTP pipelining efficiency increase
https://bugs.webkit.org/show_bug.cgi?id=38062

Patch by Markus Goetz <Markus.Goetz@nokia.com> on 2010-04-26
Reviewed by Simon Hausmann.

Increase number of network requests that are fed into
QNetworkAccessManager.

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::initializeMaximumHTTPConnectionCountPerHost):

06:56 Changeset [58253] by pfeldman@chromium.org
  • 9 edits
    5 deletes in trunk/WebKit/chromium

2010-04-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium Dev Tools: brush up images.

https://bugs.webkit.org/show_bug.cgi?id=38124

  • WebKit.gypi:
  • src/js/DevTools.js: (WebInspector.setToolbarColors):
  • src/js/Images/segmentChromium.png:
  • src/js/Images/segmentChromium2.png: Removed.
  • src/js/Images/segmentHoverChromium2.png: Removed.
  • src/js/Images/segmentSelectedChromium2.png: Removed.
  • src/js/Images/statusbarBackgroundChromium.png:
  • src/js/Images/statusbarBackgroundChromium2.png: Removed.
  • src/js/Images/statusbarBottomBackgroundChromium.png:
  • src/js/Images/statusbarButtonsChromium.png:
  • src/js/Images/statusbarMenuButtonChromium.png:
  • src/js/Images/statusbarMenuButtonChromium2.png: Removed.
  • src/js/devTools.css: (.section > .header): (.console-group-messages .section > .header): (#resources-filter): (.crumbs .crumb): (.crumbs .crumb.end): (.crumbs .crumb.selected): (.crumbs .crumb.selected:hover): (.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover): (.crumbs .crumb:hover): (.crumbs .crumb.dimmed:hover): (.crumbs .crumb.end:hover): (body.drawer-visible #main-status-bar): (.status-bar): (button.status-bar-item): (select.status-bar-item:active): (#drawer): (select.status-bar-item):
06:37 Changeset [58252] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-26 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: undefined shows up on inspector.
https://bugs.webkit.org/show_bug.cgi?id=38120

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.hide):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible):
06:31 QtWebKitRelease20 edited by hausmann@webkit.org
(diff)
06:01 Changeset [58251] by cjerdonek@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-26 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Deleted the StyleChecker-related classes that are no longer
being used.

https://bugs.webkit.org/show_bug.cgi?id=38118

  • Scripts/webkitpy/style/checker.py:
    • Deleted the DeprecatedStyleChecker class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Deleted the StyleCheckerTest, StyleCheckerCheckFileBase, StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes.
05:47 Changeset [58250] by eric@webkit.org
  • 4 edits in trunk

2010-04-26 Bruno Schmidt <bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Exposing an QVariantMap containing QObjectStar to Javascript
causes Segmentation Fault
https://bugs.webkit.org/show_bug.cgi?id=34729

If an QVariantMap containing QObjectStar is added to the to QtWebkit
Javascript, it's use causes Segmentation Fault.
It happens because, in the case QMetaType::QVariantMap, the "root"
object that is inside of a PassRefPtr is passed recursively inside a
loop to recover the content of the map, but the PassRefPtr semantics
prohibit its use inside a loop, so the "root" object mus be passed
using the method "PassRefPtr::get" in order to keep the current
reference.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue): change to root.get()

2010-04-26 Bruno Schmidt <bruno.schmidt@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Exposing an QVariantMap containing QObjectStar to Javascript
causes Segmentation Fault
https://bugs.webkit.org/show_bug.cgi?id=34729

If an QVariantMap containing QObjectStar is added to the to QtWebkit
Javascript, it's use causes Segmentation Fault.
It happens because, in the case QMetaType::QVariantMap, the "root"
object that is inside of a PassRefPtr is passed recursively inside a
loop to recover the content of the map, but the PassRefPtr semantics
prohibit its use inside a loop, so the "root" object mus be passed
using the method "PassRefPtr::get" in order to keep the current
reference.

  • tests/qwebframe/tst_qwebframe.cpp: (MyQObject::MyQObject): new property variantMapProperty (MyQObject::variantMapProperty): read variantMapProperty (MyQObject::setVariantMapProperty): write variantMapProperty
05:28 Changeset [58249] by cjerdonek@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-26 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Shinichiro Hamaji.

Changed the StyleChecker class to use the new TextFileReader class.

https://bugs.webkit.org/show_bug.cgi?id=37066

This revision separates the code responsible for reading and iterating
over text files from the rest of check-webkit-style.

  • Scripts/check-webkit-style:
    • Changed the script to use the new StyleProcessor and TextFileReader classes instead of the StyleChecker class.
  • Scripts/webkitpy/style/checker.py:
    • Added a FIXME to rename many of uses of the word "processor" to "checker". We did this to clarify the difference between ProcessorBase instances passed to the TextFileReader and classes that process and check lines for style.
    • Added a FIXME to remove FileType.NONE as a possible return value of ProcessorDispatcher._file_type(). This will better consolidate the logic of which files should be skipped.
    • Added a FIXME to delete the StyleChecker class.
    • Added the StyleProcessor class which implements ProcessorBase. This class is responsible for processing lines to check style (but not for reading files). For each file, this class creates creates both a carriage-return checker and a format-specific style checker (e.g. one of C++, Python, etc).
    • Updated the PatchChecker class to use a TextFileReader instance instead of a StyleChecker.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Added the StyleProcessor_EndToEndTest class to do "end-to-end" tests of the StyleProcessor class.
    • Added the StyleProcessor_CodeCoverageTest to test the StyleProcessor class with more complete code coverage. Unlike the StyleProcessor_EndToEndTest class, this class makes heavy use of mock parameters.
    • Added FIXME's to delete the unit test classes that are no longer needed.
    • Updated the PatchCheckerTest class to use a MockTextFileReader instead of a MockStyleChecker.
  • Scripts/webkitpy/style/filereader.py:
  • Scripts/webkitpy/style/filereader_unittest.py:
    • In the TextFileReaderTest class:
      • Moved the test_process_fileshould_not_process() method.
      • Added a test_process_filefile_stdin() method to test the file path "-".
05:28 Changeset [58248] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-26 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a memory leak in the QScriptString.

QScriptStringPrivate's constructor shouldn't call JSStringRetain as
QScriptConverter implicitly pass a JSStringRef ownership.

[Qt] QScriptStringPrivate c'tor problem
https://bugs.webkit.org/show_bug.cgi?id=38110

  • qt/api/qscriptstring_p.h: (QScriptStringPrivate::QScriptStringPrivate):
04:36 Changeset [58247] by pfeldman@chromium.org
  • 3 edits in trunk

2010-04-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Render clip in summary bar using "arc", not "quadraticCurveTo".

https://bugs.webkit.org/show_bug.cgi?id=38107

  • inspector/front-end/SummaryBar.js: (WebInspector.SummaryBar.prototype._drawSummaryGraph.drawPill): (WebInspector.SummaryBar.prototype._drawSummaryGraph):
04:32 Changeset [58246] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-26 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix compilation against Qt 4.7

Some QtMultimedia things have been moved into QtMediaServices
https://bugs.webkit.org/show_bug.cgi?id=38111

  • WebCore.pro:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::supportsType): (WebCore::MediaPlayerPrivate::totalBytes):
04:23 Changeset [58245] by eric@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-04-26 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Add expected results after r58228
https://bugs.webkit.org/show_bug.cgi?id=38098

  • platform/qt/Skipped:
  • platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
04:01 Changeset [58244] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

c

03:25 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
03:23 QtWebKitBugs edited by jocelyn.turcotte@nokia.com
Triaging should now use the Triaged keyword instead of the assignee (diff)
03:07 QtWebKitJournal edited by hausmann@webkit.org
(diff)
03:05 Changeset [58243] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-26 Zoltan Herczeg <zherczeg@webkit.org>

Reviewed by Dirk Schulze.

Call setStrokeStyle in applyStrokeStyleToContext
https://bugs.webkit.org/show_bug.cgi?id=37849

Not all platforms set the stroke style to solid if they
get an empty line dash array. Some just ignore the operation.

  • rendering/SVGRenderSupport.cpp: (WebCore::applyStrokeStyleToContext):
02:35 Changeset [58242] by loislo@chromium.org
  • 5 edits in trunk/WebCore

2010-04-23 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Aggregated stats of time spent in children records should be visible
in the popup panel of parent record. Crash in pushGCEventRecord also was fixed.
https://bugs.webkit.org/show_bug.cgi?id=37820

  • English.lproj/localizedStrings.js:
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::pushGCEventRecords):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.prototype._createRootRecord): (WebInspector.TimelinePanel.prototype._showPopover): (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages): (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):
  • inspector/front-end/inspector.css: (.timeline-graph-bar.with-children): (.timeline-graph-bar.cpu): (.timeline-aggregated-category): (.timeline-loading): (.timeline-scripting): (.timeline-rendering): (.popover .timeline-aggregated-category.timeline-loading): (.timeline-details-title):
01:23 Changeset [58241] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-26 Tony Chang <tony@chromium.org>

Not reviewed, removing duplicate expectations.

[chromium] Check and rebaseline SVG test expectations for Chromium
https://bugs.webkit.org/show_bug.cgi?id=38106

  • platform/chromium/test_expectations.txt:
01:23 Changeset [58240] by tkent@chromium.org
  • 3 edits in trunk/WebKit/chromium

Unreviewed. Roll out r58237 and r58238 because of Chromium/Linux build break.

01:21 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
01:21 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
01:19 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
01:11 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
01:06 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
01:02 Changeset [58239] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-04-26 Yuzo Fujishima <yuzo@google.com>

Unreviewed, Chromium test expectation change.

Change SVG test expectations for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=38106

  • platform/chromium/test_expectations.txt:
01:01 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
00:56 Changeset [58238] by tkent@chromium.org
  • 1 edit in trunk/WebKit/chromium/DEPS

Unreviewd. Chromium build fix for r58237.

  • DEPS: Add third_party/mesa
00:33 Changeset [58237] by tkent@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-04-26 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Enable Windows project generation
https://bugs.webkit.org/show_bug.cgi?id=38103

  • Bump the Chromium revision to r45515 to have GYP r818, which fixes a Windows project generation bug.
  • Avoid platform.system(), which causes a crash with python.exe in depot_tools. Use sys.platform instead.
  • Process DumpRenderTree.gyp on all platforms.
  • DEPS:
  • gyp_webkit:
00:07 Changeset [58236] by tkent@chromium.org
  • 10 edits
    4 adds in trunk

2010-04-25 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

WebKit crashes with deeply nested divs.
https://bugs.webkit.org/show_bug.cgi?id=18282

Add a test for deeply nested <span> elements like block-nesting-cap.html.

  • fast/parser/element-nesting-cap-expected.txt: Added.
  • fast/parser/element-nesting-cap.html: Added.
  • fast/parser/script-tests/element-nesting-cap.js: Added.

2010-04-25 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

WebKit crashes with deeply nested divs
https://bugs.webkit.org/show_bug.cgi?id=18282

The HTML parser caps a tree depth by MAX_DOM_TREE_DEPTH defined in
TreeDepthLimit.h. This is performance-efficient, but does not work for
DOM operations such as Node.appendChild().

Test: fast/parser/element-nesting-cap.html

  • dom/Node.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::pushCurrentNode):
  • html/HTMLParser.cpp:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/TreeDepthLimit.h: Added. Define MAX_DOM_TREE_DEPTH. The default value is 5000.
  • dom/XMLTokenizer.cpp: Use maxDOMTreeDepth. (WebCore::XMLTokenizer::pushCurrentNode):
  • html/HTMLParser.cpp: Introduce m_treeDepth, which counts the depth of the tree. Unlike m_blocksInStack, it contains the number of non-block nodes. (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::reset): (WebCore::HTMLParser::limitDepth): Renamed from limitBlockDepth. Add check for m_nodeDepth. (WebCore::HTMLParser::insertNodeAfterLimitDepth): Renamed from insertNodeAfterLimitBlockDepth. (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popOneBlockCommon): (WebCore::HTMLParser::freeBlock):
  • html/HTMLParser.h:

04/25/10:

23:49 Changeset [58235] by yuzo@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-25 Yuzo Fujishima <yuzo@google.com>

Unreviewed, Chromium test expectation change.

Rebaseline test expectation for Chromium.
The following tests pass for Chromium.

https://bugs.webkit.org/show_bug.cgi?id=38083

  • platform/chromium/fast/js/ToNumber-expected.txt: Added.
  • platform/chromium/fast/js/parseFloat-expected.txt: Added.
23:45 Changeset [58234] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-25 Tony Chang <tony@chromium.org>

Not reviewed, trying to get the chromium bots green.
Adding image diffs to pixel tests.

REGRESSION(r58191): Caret moved a pixel, pixel tests failing
https://bugs.webkit.org/show_bug.cgi?id=38104

  • platform/chromium/test_expectations.txt:
23:12 Changeset [58233] by tony@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

2010-04-25 Tony Chang <tony@chromium.org>

Not reviewed, trying to get the chromium bots
green.

https://bugs.webkit.org/show_bug.cgi?id=38099
Rebaseline a new test and add another new test to the
expected fail list on windows and linux.

  • platform/chromium-linux/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
22:56 Changeset [58232] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-04-25 Yuzo Fujishima <yuzo@google.com>

Unreviewed, Chromium test expectation change.

editing/inserting/caret-position.html is expected to fail for Chromium.
This is because TextInputController::firstRectForCharacterRange is unimplemented for Chromium.

https://bugs.webkit.org/show_bug.cgi?id=38100

  • platform/chromium/test_expectations.txt:
15:03 Changeset [58231] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Update focus handling code to match current approaches used by other platforms,
and fix focus handling for corner cases such as when a mouse down pops up a dialog.

https://bugs.webkit.org/show_bug.cgi?id=38086

09:16 Changeset [58230] by hamaji@chromium.org
  • 2 edits in trunk/WebKit/qt

2010-04-25 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Simon Hausmann.

[Qt] layoutTestController.counterValueForElementById crashes for a nonexistent ID
https://bugs.webkit.org/show_bug.cgi?id=34573

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::counterValueForElementById):
08:46 Changeset [58229] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-25 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Adam Barth.

Added tests for pages event handlers being called with
page context when an event is dispatched from an isolated
world.
https://bugs.webkit.org/show_bug.cgi?id=37947

  • http/tests/security/isolatedWorld/dispatchEvent-expected.txt: Added.
  • http/tests/security/isolatedWorld/dispatchEvent.html: Added.

2010-04-25 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Adam Barth.

Get context properly when event handler was created on
the main world.
https://bugs.webkit.org/show_bug.cgi?id=37947

Test: http/tests/security/isolatedWorld/dispatchEvent.html

  • bindings/v8/WorldContextHandle.cpp: (WebCore::WorldContextHandle::adjustedContext):
06:52 Changeset [58228] by eric@webkit.org
  • 15 edits
    5 adds in trunk

2010-04-25 yael aharon <yael.aharon@nokia.com>

Reviewed by Adele Peterson.

Allow styling of HTMLProgressElement.
https://bugs.webkit.org/show_bug.cgi?id=37901

Added a test for changing the -webkit-appearance statically and dynamically.

  • fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/dom/HTMLProgressElement: Added.
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-04-25 yael aharon <yael.aharon@nokia.com>

Reviewed by Adele Peterson.

Allow styling of HTMLProgressElement.
https://bugs.webkit.org/show_bug.cgi?id=37901

Added a new pseudo element to represent the value portion of the progress element.
Web developers can style this pseudo element separate from the rest of the progress element.

Test: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • css/CSSValueKeywords.in:
  • platform/ThemeTypes.h:
  • rendering/RenderProgress.cpp: (WebCore::ProgressValueElement::isShadowNode): (WebCore::ProgressValueElement::shadowParentNode): (WebCore::ProgressValueElement::ProgressValueElement): (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::layout): (WebCore::RenderProgress::styleDidChange): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::updateValuePartState): (WebCore::RenderProgress::createStyleForValuePart): (WebCore::RenderProgress::updateAnimationState):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
04:37 Changeset [58227] by eric@webkit.org
  • 3 edits in trunk/WebKit/win

2010-04-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector client shouldn't check if it can be opened
docked if it is already in that state.

https://bugs.webkit.org/show_bug.cgi?id=37946

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::WebInspectorFrontendClient): (WebInspectorFrontendClient::showWindowWithoutNotifications):
  • WebCoreSupport/WebInspectorClient.h:

04/24/10:

23:44 Changeset [58226] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2010-04-24 Steve Falkenburg <sfalken@apple.com>

Reviewed by Sam Weinig.

Typo in Geolocation code causes crashes when updates are stopped
https://bugs.webkit.org/show_bug.cgi?id=38089
<rdar://problem/7904104> Crash closing geolocation tab after allowing to use geolocation

  • WebCoreSupport/WebGeolocationControllerClient.cpp: (WebGeolocationControllerClient::stopUpdating): Call unregister instead of register.
22:06 Changeset [58225] by darin@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix log message.

22:00 Changeset [58224] by darin@apple.com
  • 4 edits
    6 adds in trunk

2010-04-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r56560): Crash in parseFloat if passed invalid UTF-16 data
https://bugs.webkit.org/show_bug.cgi?id=38083
rdar://problem/7901044

Tests: fast/js/ToNumber.html

fast/js/parseFloat.html

  • runtime/JSGlobalObjectFunctions.cpp: (JSC::parseInt): Added a FIXME comment about a problem I noticed. (JSC::parseFloat): Added a FIXME comment about a problem I noticed; covered by test cases in the test I added.
  • runtime/UString.cpp: (JSC::UString::toDouble): Added FIXME comments about two problem I noticed; covered by test cases in the tests I added. Added a return statement so we don't crash when illegal UTF-16 sequences are present.

2010-04-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r56560): Crash in parseFloat if passed invalid UTF-16 data
https://bugs.webkit.org/show_bug.cgi?id=38083
rdar://problem/7901044

  • fast/js/parseFloat-expected.txt: Added.
  • fast/js/parseFloat.html: Added.
  • fast/js/script-tests/parseFloat.js: Added.
  • fast/js/ToNumber-expected.txt: Added.
  • fast/js/ToNumber.html: Added.
  • fast/js/script-tests/ToNumber.js: Added.
17:47 Changeset [58223] by mitz@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add platform-specific results for Mac after r58222.

  • platform/mac/compositing/iframes: Added.
  • platform/mac/compositing/iframes/composited-iframe-expected.txt: Added.
16:59 Changeset [58222] by mitz@apple.com
  • 2 edits in trunk/WebCore

Don't propagate compositing out of iframes on Mac
https://bugs.webkit.org/show_bug.cgi?id=38072

Patch by Simon Fraser <simon.fraser@apple.com> on 2010-04-24
Reviewed by Dan Bernstein.

Propagating compositing out of iframes caused too many regressions on Mac,
so only do it for other platforms that may need to hook compositing layers
together across iframe boundaries.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForIFrame):

14:54 Changeset [58221] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/7903728> REGRESSION (r51617): WebView fails to load plug-in MIME types
https://bugs.webkit.org/show_bug.cgi?id=38085

Reviewed by Darin Adler.

WebView was calling -_webView in a few places where it should have just used itself. It never
makes sense for WebView to call -_webView on itself, and these calls look like they were copied
from similar code in WebHTMLView, WebFrameView and WebDataSource, where -_webView has a different,
useful meaning.

  • WebView/WebView.mm:

(-[WebView drawSingleRect:]): Replaced [self _webView] with self.
(-[WebView _viewClass:andRepresentationClass:forMIMEType:]): Replaced [[self _webView] preferences]
with _private->preferences.
(-[WebView _canShowMIMEType:]): Ditto.

10:53 Changeset [58220] by eric@webkit.org
  • 5 edits in trunk

2010-04-24 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Adler.

Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

Former implementation attempted to use AtomicString(HashTableDeletedValue)
however those values cannot be used that way: one cannot construct
QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
in the table, for example.
https://bugs.webkit.org/show_bug.cgi?id=37722

  • wtf/RefPtr.h: expose hash table deleted value

2010-04-24 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Adler.

Allow to construct HashTraits<WebCore::QualifiedName>::constructDeletedValue

Former implementation attempted to use AtomicString(HashTableDeletedValue)
however those values cannot be used that way: one cannot construct
QualifiedNameImpl out of such AtomicString as we'll try to lookup this string
in the table, for example.
https://bugs.webkit.org/show_bug.cgi?id=37722

  • dom/QualifiedName.cpp: (WebCore::QualifiedName::deref): check that hash table deleted values never derefed
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName): add a constructor to create hash table deleted values (WebCore::QualifiedName::isHashTableDeletedValue): add a check if given instance is hash table deleted value (WTF::):
09:40 Changeset [58219] by jchaffraix@webkit.org
  • 4 edits
    2 adds in trunk

protocolHostAndPortEquals host check makes a wrong assumption
https://bugs.webkit.org/show_bug.cgi?id=37777

Reviewed by Alexey Proskuryakov.

WebCore:

The host check assumed that both host started at the same position. This is true
if both URL are the same but sometimes one has credential and the other does not.
In this case, the method would compare invalid positions.

Test: http/tests/appcache/credential-url.html

  • platform/KURL.cpp:

(WebCore::protocolHostAndPortAreEqual):

  • platform/KURLGoogle.cpp:

(WebCore::protocolHostAndPortAreEqual):
Fix the host check to take both URL's credential into account.

LayoutTests:

Add a check that the URL with credential matches the current URL.

  • http/tests/appcache/credential-url-expected.txt: Added.
  • http/tests/appcache/credential-url.html: Added.
07:43 Changeset [58218] by robert@webkit.org
  • 10 edits
    3 adds in trunk

[Qt] Add more support for textInputController

2010-04-20 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add more support for textInputController

Add support for selectedRange(), setMarkedText(), insertText(),
and firstRectForCharacterRange().

Unskip tests:

fast/forms/input-maxlength-ime-preedit.html
fast/forms/input-maxlength-ime-completed.html
fast/text/international/thai-cursor-position.html
fast/events/ime-composition-events-001.html
editing/selection/5825350-1.html
editing/selection/5825350-2.html
editing/selection/mixed-editability-10.html

https://bugs.webkit.org/show_bug.cgi?id=35702

  • platform/qt/Skipped:

2010-04-20 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add more support for textInputController

Add support for selectedRange(), setMarkedText(), insertText(),
and firstRectForCharacterRange().

Unskip tests:

fast/forms/input-maxlength-ime-preedit.html
fast/forms/input-maxlength-ime-completed.html
fast/text/international/thai-cursor-position.html
fast/events/ime-composition-events-001.html
editing/selection/5825350-1.html
editing/selection/5825350-2.html
editing/selection/mixed-editability-10.html

https://bugs.webkit.org/show_bug.cgi?id=35702

  • DumpRenderTree/qt/TextInputControllerQt.cpp: (TextInputController::setMarkedText): (TextInputController::insertText): (TextInputController::selectedRange): (TextInputController::firstRectForCharacterRange):
  • DumpRenderTree/qt/TextInputControllerQt.h:

2010-04-20 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add more support for textInputController

Add support for selectedRange(), setMarkedText(), insertText(),
and firstRectForCharacterRange().

https://bugs.webkit.org/show_bug.cgi?id=35702

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::selectedRange): (DumpRenderTreeSupportQt::firstRectForCharacterRange):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
06:48 Changeset [58217] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.


Attempt to turn the last core builder green again (not related anymore to my previous SVG checkins :-)
Skip http/tests/media/video-play-stall-seek.html on Windows as well (just like it has been done for Mac in r58107).
Bug https://bugs.webkit.org/show_bug.cgi?id=38000 describes the problem, and says it's ok to skip the test.

  • platform/win/Skipped:
06:37 Changeset [58216] by zimmermann@webkit.org
  • 1 edit
    10 adds in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add new results for all SVG tests that were missing on Gtk/Qt (since a while, just took the opportunity to add them now)

  • platform/gtk/svg/custom/broken-internal-references-expected.txt: Added.
  • platform/gtk/svg/custom/clip-path-id-changes-expected.txt: Added.
  • platform/qt/svg/custom/broken-internal-references-expected.txt: Added.
  • platform/qt/svg/custom/clip-path-id-changes-expected.txt: Added.
  • platform/qt/svg/custom/mask-on-multiple-objects-expected.txt: Added.
  • platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt: Added.
  • platform/qt/svg/filters/filter-clip-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
06:01 Changeset [58215] by zimmermann@webkit.org
  • 13 edits in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update Qt SVG results, and a weird fast/xpath change (newline added).

  • fast/xpath/namespace-vs-predicate-expected.txt:
  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/qt/svg/css/mask-with-shadow-expected.txt:
  • platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/qt/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.txt:
05:47 Changeset [58214] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix linkage on several bots (no idea, why it worked in a from-scratch rebuild on Leopard on my machine!) -> include NodeRenderStyle.h
Having to include NodeRenderStyle.h just to pull in the renderStyle() is a crazy concept, but I see what it tries to avoid (including RenderObject.h in Node.h)

  • rendering/SVGRenderSupport.cpp:
05:35 Changeset [58213] by zimmermann@webkit.org
  • 4 edits in trunk/WebCore

2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix release builds, wrap resourceMode assertion in NDEBUG blocks, use UNUSED_PARAM() otherwhise.

  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource):
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyResource):
04:42 Changeset [58212] by zimmermann@webkit.org
  • 192 edits
    1 add
    3 deletes in trunk

2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGPaintServer needs to be converted to the new RenderSVGResource* system
https://bugs.webkit.org/show_bug.cgi?id=37986

Huge speedup for SVG painting using paint servers (gradient/patterns). Cache underlying
WebCore::Gradient/Pattern datastructures, do not rebuild them on every painting. This marks
the finish of the SVGResource -> RenderSVGResource transition.

Outline of same key changes:

  • RenderSVGResource is an abstract base class now, and the previous class is now named RenderSVGResourceContainer All resources except RenderSVGResourceSolidColor now inherit from RenderSVGResourceContainer, as they are all associated with a SVG*Element class. RenderSVGResourceSolidColor inherits from RenderSVGResource, and is not associated with any SVG*Element class. RenderSVGResourceSolidColor is not a render tree object, despite its name. The reason for that is consistency with all other painting resources.
  • RenderSVGResourceSolidColor does not live in the render tree, and exists only as static object, which is shared and always used when filling/stroking with solid colors - just like the old SVGPaintServerSolid.
  • RenderSVGResourceGradient/RenderSVGResourcePattern now store the underlying WebCore::Gradient/Pattern object instead of rebuilding it everytime we're asked to paint -> this is the main difference with the old concept, leading to much faster speed.
  • SVGResource has vanished. All resources (clipper/filter/marker/masker/gradient/pattern) now share the same codepaths to handle updates and client invalidation - which is a huge benefit, and makes the code easier to understand.
  • Android.mk: Remove svg/graphics/SVGResource*, svg/graphics/SVGPaintServer.h from build.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/Gradient.cpp: Add addColorStop() method taking a ColorStop const-reference. (WebCore::Gradient::addColorStop):
  • platform/graphics/Gradient.h: Ditto.
  • platform/graphics/TextRun.h: Rename SVGPaintServer to RenderSVGResource (WebCore::TextRun::TextRun): (WebCore::TextRun::activePaintingResource): Renamed from activePaintServer. (WebCore::TextRun::setActivePaintingResource): Renamed from setActivePaintServer.
  • platform/graphics/win/GraphicsContextWin.cpp: Remove references to SVGResourceImage, which was removed a long time ago.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::toRenderSVGResourceContainer): Renamed from toRenderSVGResource().
  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGGradientStop): Added. (WebCore::RenderObject::isSVGResourceContainer): Renamed from isSVGResource().
  • rendering/RenderPath.cpp: Utilize RenderSVGResource::fill/strokePaintingResource to request paint servers, instead of SVGPaintServer. (WebCore::RenderPath::fillContains): Adapt to new concept. (WebCore::RenderPath::strokeContains): Ditto. (WebCore::fillAndStrokePath): Ditto. (WebCore::RenderPath::paint): Ditto.
  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange): Ditto.
  • rendering/RenderSVGGradientStop.h: Fixed indention.
  • rendering/RenderSVGResource.cpp: Refactored old SVGPaintServer code to request fill/stroke painting resources, splitted up in several methods to aid readability. (WebCore::registerPendingResource): (WebCore::adjustColorForPseudoRules): (WebCore::RenderSVGResource::fillPaintingResource): (WebCore::RenderSVGResource::strokePaintingResource): (WebCore::RenderSVGResource::sharedSolidPaintingResource): (WebCore::RenderSVGResource::markForLayoutAndResourceInvalidation):
  • rendering/RenderSVGResource.h: Make RenderSVGResource an abstract base class, see above for the reasoning. (WebCore::RenderSVGResource::RenderSVGResource): (WebCore::RenderSVGResource::~RenderSVGResource): (WebCore::RenderSVGResource::postApplyResource):
  • rendering/RenderSVGResourceClipper.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::invalidateClient): (WebCore::RenderSVGResourceClipper::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters) (WebCore::RenderSVGResourceClipper::applyClippingToContext):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceContainer.h: Added. Renamed from RenderSVGResource. Now inherits from RenderSVGHiddenContainer and RenderSVGResource. (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::~RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::idChanged): (WebCore::RenderSVGResourceContainer::isSVGResourceContainer): (WebCore::RenderSVGResourceContainer::drawsContents): (WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer): (WebCore::getRenderSVGResourceContainerById): (WebCore::getRenderSVGResourceById):
  • rendering/RenderSVGResourceFilter.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::invalidateClient): (WebCore::RenderSVGResourceFilter::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters) (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.cpp: Moved from SVGPaintServerGradient, cleaned up and refactored. (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient): (WebCore::RenderSVGResourceGradient::~RenderSVGResourceGradient): (WebCore::RenderSVGResourceGradient::invalidateClients): (WebCore::RenderSVGResourceGradient::invalidateClient): (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceLinearGradient.cpp: Moved from SVGPaintServerLinearGradient, cleaned up and refactored. (WebCore::RenderSVGResourceLinearGradient::RenderSVGResourceLinearGradient): (WebCore::RenderSVGResourceLinearGradient::~RenderSVGResourceLinearGradient): (WebCore::RenderSVGResourceLinearGradient::buildGradient):
  • rendering/RenderSVGResourceLinearGradient.h: (WebCore::RenderSVGResourceLinearGradient::renderName): (WebCore::RenderSVGResourceLinearGradient::resourceType):
  • rendering/RenderSVGResourceMarker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker): (WebCore::RenderSVGResourceMarker::invalidateClient):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::applyResource):
  • rendering/RenderSVGResourceMasker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource. (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker): (WebCore::RenderSVGResourceMasker::invalidateClient): (WebCore::RenderSVGResourceMasker::applyResource):
  • rendering/RenderSVGResourceMasker.h: (WebCore::MaskerData::MaskerData):
  • rendering/RenderSVGResourcePattern.cpp: Moved from SVGPaintServerPattern, cleaned up and refactored. (WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern): (WebCore::RenderSVGResourcePattern::~RenderSVGResourcePattern): (WebCore::RenderSVGResourcePattern::invalidateClients): (WebCore::RenderSVGResourcePattern::invalidateClient): (WebCore::RenderSVGResourcePattern::applyResource): (WebCore::RenderSVGResourcePattern::postApplyResource): (WebCore::calculatePatternBoundaries): (WebCore::RenderSVGResourcePattern::calculatePatternBoundariesIncludingOverflow): (WebCore::RenderSVGResourcePattern::createTileImage): (WebCore::RenderSVGResourcePattern::buildPattern):
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::renderName): (WebCore::RenderSVGResourcePattern::resourceBoundingBox): (WebCore::RenderSVGResourcePattern::resourceType):
  • rendering/RenderSVGResourceRadialGradient.cpp: Moved from SVGPaintServerRadialGradient, cleaned up and refactored. (WebCore::RenderSVGResourceRadialGradient::RenderSVGResourceRadialGradient): (WebCore::RenderSVGResourceRadialGradient::~RenderSVGResourceRadialGradient): (WebCore::RenderSVGResourceRadialGradient::buildGradient):
  • rendering/RenderSVGResourceRadialGradient.h: (WebCore::RenderSVGResourceRadialGradient::renderName): (WebCore::RenderSVGResourceRadialGradient::resourceType):
  • rendering/RenderSVGResourceSolidColor.cpp: Moved from SVGPaintServerSolid, cleaned up and refactored. (WebCore::RenderSVGResourceSolidColor::RenderSVGResourceSolidColor): (WebCore::RenderSVGResourceSolidColor::~RenderSVGResourceSolidColor): (WebCore::RenderSVGResourceSolidColor::applyResource): (WebCore::RenderSVGResourceSolidColor::postApplyResource):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::invalidateClients): (WebCore::RenderSVGResourceSolidColor::invalidateClient): (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox): (WebCore::RenderSVGResourceSolidColor::resourceType): (WebCore::RenderSVGResourceSolidColor::color): (WebCore::RenderSVGResourceSolidColor::setColor):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::paint): Early exit if painting is disabled.
  • rendering/RenderTreeAsText.cpp: (WebCore::write): Add RenderSVGGradientStop dumping. (WebCore::externalRepresentation): Remove SVGResource dumping.
  • rendering/SVGInlineTextBox.cpp: Adapt to SVGPaintServer changes (paint server request). (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintDecoration):
  • rendering/SVGInlineTextBox.h: Ditto. (WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
  • rendering/SVGRenderSupport.cpp: Ditto. (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::invalidatePaintingResource): (WebCore::deregisterFromResources): (WebCore::dashArrayFromRenderingStyle): Moved here from SVGPaintServer. (WebCore::applyStrokeStyleToContext): Ditto.
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: Add new gradient/pattern dumping code. Stops are now properly dumped as well! (WebCore::operator<<): (WebCore::writeSVGPaintingResource): (WebCore::writeStyle): (WebCore::boundingBoxModeString): (WebCore::writeCommonGradientProperties): (WebCore::writeSVGResourceContainer): (WebCore::writeSVGGradientStop):
  • rendering/SVGRenderTreeAsText.h:
  • rendering/SVGRootInlineBox.cpp: Adapt to SVGPaintServer changes (paint server request). (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBoxPaintWalker::~SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBoxPaintWalker::teardownFillPaintServer): (WebCore::SVGRootInlineBoxPaintWalker::teardownStrokePaintServer): (WebCore::SVGRootInlineBoxPaintWalker::setupBackground): (WebCore::SVGRootInlineBoxPaintWalker::setupFill): (WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection): (WebCore::SVGRootInlineBoxPaintWalker::setupStroke): (WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection): (WebCore::SVGRootInlineBoxPaintWalker::setupForeground): (WebCore::SVGRootInlineBoxPaintWalker::activePaintingResource): (WebCore::SVGRootInlineBoxPaintWalker::paintChunk):
  • svg/GradientAttributes.h: Remove SVGGradientStop, use Gradient::ColorStop vector. Cleanup. (WebCore::GradientAttributes::stops): (WebCore::GradientAttributes::setStops):
  • svg/LinearGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
  • svg/PatternAttributes.h: Add missing includes and class forwards.
  • svg/RadialGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
  • svg/SVGClipPathElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGClipPathElement::svgAttributeChanged): (WebCore::SVGClipPathElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
  • svg/SVGClipPathElement.h:
  • svg/SVGDocumentExtensions.cpp: Change HashMaps to hash AtomicStrings instead of Strings. Rename RenderSVGResource to RenderSVGResourceContainer. (WebCore::SVGDocumentExtensions::addResource): (WebCore::SVGDocumentExtensions::removeResource): (WebCore::SVGDocumentExtensions::resourceById): (WebCore::SVGDocumentExtensions::addPendingResource):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument): Remove reference to SVGResource::invalidateClients(), handled differently now. (WebCore::SVGElement::updateAnimatedSVGAttribute): Change assertion, that is incorrect now.
  • svg/SVGElement.h: Make updateAnimatedSVGAttribute() public.
  • svg/SVGFont.cpp: Adapt to SVGPaintServer changes (paint server request). (WebCore::Font::drawTextUsingSVGFont):
  • svg/SVGGElement.cpp: If style()->display() is NONE, create a RenderSVGHiddenContainer, removing hacks in SVGStopElement for pservers-grad-19-b.svg (yes, SVG is crazy.) (WebCore::SVGGElement::createRenderer):
  • svg/SVGGElement.h: Remove childrenChanged() method which _always_ called renderer->setNeedsLayout(true), which is completly wrong and unnecessary. (WebCore::SVGGElement::rendererIsNeeded): Always return true.
  • svg/SVGGradientElement.cpp: Adapt to new RenderSVGResourceGradient code. (WebCore::SVGGradientElement::svgAttributeChanged): (WebCore::SVGGradientElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set. (WebCore::SVGGradientElement::buildStops):
  • svg/SVGGradientElement.h:
  • svg/SVGLinearGradientElement.cpp: Adapt to new RenderSVGResourceLinearGradient code. (WebCore::SVGLinearGradientElement::svgAttributeChanged): (WebCore::SVGLinearGradientElement::createRenderer): (WebCore::SVGLinearGradientElement::collectGradientProperties): (WebCore::SVGLinearGradientElement::calculateStartEndPoints):
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMarkerElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set. (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle):
  • svg/SVGMaskElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
  • svg/SVGPatternElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients(). (WebCore::SVGPatternElement::svgAttributeChanged): (WebCore::SVGPatternElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set. (WebCore::SVGPatternElement::createRenderer):
  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.h: Remove unneded rendererIsNeeded() override.
  • svg/SVGRadialGradientElement.cpp: Adapt to new RenderSVGResourceRadialGradient code. (WebCore::SVGRadialGradientElement::svgAttributeChanged): (WebCore::SVGRadialGradientElement::createRenderer): (WebCore::SVGRadialGradientElement::collectGradientProperties): (WebCore::SVGRadialGradientElement::calculateFocalCenterPointsAndRadius):
  • svg/SVGRadialGradientElement.h:
  • svg/SVGStopElement.cpp: Clean up code, moved stop color calculation from SVGGradientElement to here, where it belongs. (WebCore::SVGStopElement::parseMappedAttribute): (WebCore::SVGStopElement::stopColorIncludingOpacity):
  • svg/SVGStopElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::~SVGStyledElement): (WebCore::SVGStyledElement::svgAttributeChanged): Only invalidateResourcesInAncestorChain()/deregisterFromResources() when we're not parsing. (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain): Early exit if we find a parent resources, there is no resource nesting. (WebCore::SVGStyledElement::invalidateResourceClients): Renamed from invalidateCanvasResources() (WebCore::SVGStyledElement::childrenChanged): Only invalidate SVGElementInstances when !changedByParser is set.
  • svg/SVGStyledElement.h: Remove canvasResource() logic, remove detach() method.
  • svg/SVGTextPathElement.h:
  • svg/graphics/SVGPaintServer.h: Removed.
  • svg/graphics/SVGResource.cpp: Removed.
  • svg/graphics/SVGResource.h: Removed.

2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGPaintServer needs to be converted to the new RenderSVGResource* system
https://bugs.webkit.org/show_bug.cgi?id=37986

Rebaseline SVG tests, after the RenderSVGResource transition.

NOTE: This WILL affect _any_ platform with custom svg results for tests using gradients/patterns.

That means I have to wait for the bot results, and update them ASAP. Therefore landing out
of california business hours and on the weekend - please stay tuned I'll fix any breakages soon.
(Except for chromium whose test results are not available on build.webkit.org, sorry.)

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/batik/paints/gradientLimit-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegionA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/carto.net/colourpicker-expected.txt:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/mac/svg/css/mask-with-shadow-expected.txt:
  • platform/mac/svg/custom/broken-internal-references-expected.txt:
  • platform/mac/svg/custom/deep-dynamic-updates-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/fill-fallback-expected.txt:
  • platform/mac/svg/custom/gradient-add-stops-expected.txt:
  • platform/mac/svg/custom/gradient-attr-update-expected.txt:
  • platform/mac/svg/custom/gradient-cycle-detection-expected.txt:
  • platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.txt:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.txt:
  • platform/mac/svg/custom/gradient-stop-style-change-expected.txt:
  • platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/mac/svg/custom/gradient-stroke-width-expected.png:
  • platform/mac/svg/custom/gradient-stroke-width-expected.txt:
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
  • platform/mac/svg/custom/group-opacity-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
  • platform/mac/svg/custom/js-update-gradient-expected.checksum:
  • platform/mac/svg/custom/js-update-gradient-expected.png:
  • platform/mac/svg/custom/js-update-gradient-expected.txt:
  • platform/mac/svg/custom/js-update-pattern-child-expected.txt:
  • platform/mac/svg/custom/js-update-pattern-expected.txt:
  • platform/mac/svg/custom/js-update-stop-expected.txt:
  • platform/mac/svg/custom/large-bounding-box-percents-expected.txt:
  • platform/mac/svg/custom/pattern-cycle-detection-expected.txt:
  • platform/mac/svg/custom/pattern-deep-referencing-expected.txt:
  • platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
  • platform/mac/svg/custom/pattern-in-defs-expected.txt:
  • platform/mac/svg/custom/pattern-rotate-expected.txt:
  • platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
  • platform/mac/svg/custom/pattern-skew-transformed-expected.txt:
  • platform/mac/svg/custom/pattern-with-transformation-expected.txt:
  • platform/mac/svg/custom/pattern-y-offset-expected.txt:
  • platform/mac/svg/custom/resource-client-removal-expected.txt:
  • platform/mac/svg/custom/stroke-fallback-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/custom/text-gradient-no-content-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/hixie/error/003-expected.txt:
  • platform/mac/svg/hixie/perf/005-expected.txt:
  • platform/mac/svg/hixie/perf/006-expected.txt:
  • platform/mac/svg/text/selection-background-color-expected.txt:
  • platform/mac/svg/text/selection-styles-expected.txt:
  • platform/mac/svg/text/text-gradient-positioning-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • platform/win/svg/custom/broken-internal-references-expected.txt:
  • svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
03:29 Changeset [58211] by zimmermann@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add win specific result for svg/custom/broken-internal-references.svg
It's a bad idea that textPath dumps FLT_MAX when it's not shown - that should be fixed, but it's not related to Moritas testcase.

  • platform/win/svg/custom/broken-internal-references-expected.txt: Added.
00:03 Changeset [58210] by eric@webkit.org
  • 9 edits
    1 copy in trunk/WebKitTools

2010-04-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

check-webkit-style complains about non-utf8 data in layout test result
https://bugs.webkit.org/show_bug.cgi?id=38027

The problem was we were assuming patch files/diff output as utf-8.
Turns out they're not. We have to treat them as binary data because
a single patch may have multiple text files in it with conflicting encodings!

  • Scripts/webkitpy/common/checkout/api.py:
    • contents_at_revision returns a byte array, so decode it to unicode before passing it to parse_latest_entry_from_file
  • Scripts/webkitpy/common/checkout/api_unittest.py:
    • Update our mock mock_contents_at_revision to match the encoding semantics of the real one.
  • Scripts/webkitpy/common/checkout/scm.py:
    • Be careful not to decode output which may contain file contents (like diff, cat or show) as the encoding for that content is unknown.
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Update our tests to use both latin1 and utf-8 encoded data.
  • Scripts/webkitpy/common/net/bugzilla.py:
    • _fill_attachment_form should not assume unicode data. Callers may wish to attach other types of files to bugs.
  • Scripts/webkitpy/common/prettypatch.py:
    • Diffs are byte arrays, deal with them as such.
  • Scripts/webkitpy/common/prettypatch_unittest.py:
    • Test to make sure we handle diffs with multiple conflicting encodings.
  • Scripts/webkitpy/common/system/executive_unittest.py:
    • Make sure that our unicode support does not break our byte array input support for run_command.

04/23/10:

22:17 Changeset [58209] by eric@webkit.org
  • 5 edits in trunk

2010-04-23 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Add isGLES2Compliant to GraphicsContext3D: make the method const.
https://bugs.webkit.org/show_bug.cgi?id=37872

  • platform/graphics/GraphicsContext3D.h: Make isGLES2Compliant() const.
  • platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto. (WebCore::GraphicsContext3D::isGLES2Compliant):

2010-04-23 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Fisher.

Add isGLES2Compliant to GraphicsContext3D: make the method const.
https://bugs.webkit.org/show_bug.cgi?id=37872

  • src/GraphicsContext3D.cpp: Make isGLES2Compliant() const. (WebCore::GraphicsContext3DInternal::isGLES2Compliant): (WebCore::GraphicsContext3D::isGLES2Compliant):
20:36 Changeset [58208] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-23 Ben Murdoch <benm@google.com>

Reviewed by Jeremy Orlow.

[Android] The touchmove delta used in basic-single-touch-events.html is too small for Android
https://bugs.webkit.org/show_bug.cgi?id=38056

  • fast/events/touch/basic-single-touch-events-expected.txt:
    • update the test expected output
  • fast/events/touch/script-tests/basic-single-touch-events.js: (verifyTouch): update test expectation with new coordinates. (singleTouchSequence): increase the touch move delta. (touchTargets): Start the touch at a different point to

singleTouchSequence to make examining behavior easier.

20:27 Changeset [58207] by eric@webkit.org
  • 3 edits
    1 delete in trunk

2010-04-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
https://bugs.webkit.org/show_bug.cgi?id=37276

pointInPath.html passed because the expected.txt expect it fail, it is wrong.

  • platform/qt/fast/canvas/pointInPath-expected.txt: Removed.

2010-04-23 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
https://bugs.webkit.org/show_bug.cgi?id=37276

QPainterPath::contains doesn't count the point on the bound.

  • platform/graphics/qt/PathQt.cpp: (WebCore::isPointOnPathBorder): (WebCore::Path::contains):
18:07 Changeset [58206] by weinig@apple.com
  • 9 edits
    3 copies
    9 adds in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
Split up Threading.h

Reviewed by David Levin.

JavaScriptCore:

Move bits for of Threading.h into 3 new files.

  • Atomics.h for atomic operations.
  • ThreadSafeShared.h for the ThreadSafeShared class.
  • ThreadingPrimitives.h for the primitives and platform types.

Basic threading operations (creation, etc.) remain in Threading.h.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/Atomics.h: Copied from wtf/Threading.h.
  • wtf/ThreadSafeShared.h: Copied from wtf/Threading.h.
  • wtf/Threading.h:
  • wtf/ThreadingPrimitives.h: Copied from wtf/Threading.h.

JavaScriptGlue:

Add necessary forwarding headers.

  • ForwardingHeaders/wtf/Atomics.h: Added.
  • ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
  • ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.

WebCore:

Add necessary forwarding headers.

  • ForwardingHeaders/wtf/Atomics.h: Added.
  • ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
  • ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.

WebKitTools:

Add necessary forwarding headers.

  • DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
18:05 Changeset [58205] by eric@webkit.org
  • 4 edits
    1 add in trunk

2010-04-23 Rafael Weinstein <rafaelw@grafaelw.sfo.corp.google.com>

Reviewed by Darin Fisher.

This patch adds a vector of additionalFeatures to WindowFeatures
and populates it with any feature strings that evaluate to "yes"
and aren't directly observed in WindowFeatures. This allows
clients to capture experimental window features.

https://bugs.webkit.org/show_bug.cgi?id=38013

  • page/WindowFeatures.cpp: (WebCore::WindowFeatures::setWindowFeature):
  • page/WindowFeatures.h:

2010-04-23 Rafael Weinstein <rafaelw@grafaelw.sfo.corp.google.com>

Reviewed by Darin Fisher.

This patch adds a WebWindowFeatures binding struct for the
chromium client in anticipation of a follow-on patch which will
pass it to WebViewClient::createWindow.

https://bugs.webkit.org/show_bug.cgi?id=38013

  • public/WebViewClient.h: (WebKit::WebViewClient::createView):
  • public/WebWindowFeatures.h: Added. (WebKit::WebWindowFeatures::WebWindowFeatures):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow):
17:54 Changeset [58204] by xji@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-23 Xiaomei Ji <xji@chromium.org>

No need to review.

Add xji as committer.

  • Scripts/webkitpy/common/config/committers.py:
17:48 Changeset [58203] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2010-04-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

ASSERT(willBeComposited == needsToBeComposited(layer)); on gmail.com
https://bugs.webkit.org/show_bug.cgi?id=38066

When a layer goes into compositing mode because it has a negative z-index child that is going
into compositing mode, then set willBeComposited to true. Also add another assertion to catch
any other cases where the state of willBeComposited is mismanaged.

Test: compositing/composited-negative-zindex-child.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
17:48 Changeset [58202] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2010-04-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

<rdar://problem/7894489> When printing Flash, send a drawRect event, rather than NPPrint

When printing Flash plug-ins in 32-bit, send a drawRect event with a CGContextRef, rather than calling
NPPrint with a GWorldPtr, since Flash prefers the CGContext path.

  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView drawRect:]):
17:16 Changeset [58201] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/7898436> :after content is duplicated

Reviewed by Simon Fraser.

WebCore:

Test: fast/css-generated-content/after-duplicated-after-split.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::splitInlines): Pass the correct owner of the child list.

LayoutTests:

  • fast/css-generated-content/after-duplicated-after-split.html: Added.
  • platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
17:12 Changeset [58200] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix, add platform stub for new LayoutTestController method.

17:02 Changeset [58199] by weinig@apple.com
  • 5 edits
    1 copy
    5 moves
    1 delete in trunk/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=38065
Merge mac and win DrawingAreaProxyUpdateChunk implementations.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView drawRect:]):

  • UIProcess/DrawingAreaProxy.cpp: Copied from UIProcess/mac/DrawingAreaProxy.mm.
  • UIProcess/DrawingAreaProxy.h: Copied from UIProcess/mac/DrawingAreaProxy.h.
  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.mm.

(WebKit::DrawingAreaProxyUpdateChunk::DrawingAreaProxyUpdateChunk):
(WebKit::DrawingAreaProxyUpdateChunk::paint):
(WebKit::DrawingAreaProxyUpdateChunk::setSize):
(WebKit::DrawingAreaProxyUpdateChunk::didSetSize):
(WebKit::DrawingAreaProxyUpdateChunk::update):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):

  • UIProcess/DrawingAreaProxyUpdateChunk.h: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.h.
  • UIProcess/mac/DrawingAreaProxy.h: Removed.
  • UIProcess/mac/DrawingAreaProxy.mm: Removed.
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.h: Removed.
  • UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: Removed.
  • UIProcess/mac/DrawingAreaProxyUpdateChunkMac.mm: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.mm.

(WebKit::DrawingAreaProxyUpdateChunk::page):
(WebKit::DrawingAreaProxyUpdateChunk::invalidateBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::platformPaint):
(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):

  • UIProcess/win/DrawingAreaProxy.cpp: Removed.
  • UIProcess/win/DrawingAreaProxy.h: Removed.
  • UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp: Copied from UIProcess/win/DrawingAreaProxy.cpp.

(WebKit::DrawingAreaProxyUpdateChunk::page):
(WebKit::DrawingAreaProxyUpdateChunk::ensureBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::invalidateBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::platformPaint):
(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::onPaintEvent):

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
16:50 Changeset [58198] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-23 Xiaomei Ji <xji@chromium.org>

Reviewed by Eric Seidel

QT does not support textInputController.firstRectForCharacterRange(),
so, skip editing/inserting/caret-position.html for QT.
https://bugs.webkit.org/show_bug.cgi?id=25319

  • platform/qt/Skipped:
16:21 Changeset [58197] by adele@apple.com
  • 2 edits in trunk/WebCore

Fixing the Tiger build for real.

  • platform/graphics/mac/SimpleFontDataMac.mm:
16:08 Changeset [58196] by adele@apple.com
  • 2 edits in trunk/WebCore

Fixing the Tiger build.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformBoundsForGlyph):

15:31 Changeset [58195] by morrita@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-04-23 MORITA Hajime <morrita@google.com>

Not reviewed. Added missing expectation files for
https://bugs.webkit.org/show_bug.cgi?id=37187

  • platform/mac/svg/custom/broken-internal-references-expected.checksum: Added.
  • platform/mac/svg/custom/broken-internal-references-expected.png: Added.
15:20 Changeset [58194] by jianli@chromium.org
  • 13 edits
    2 adds in trunk/WebCore

Add FileError for File API.
https://bugs.webkit.org/show_bug.cgi?id=37840

Reviewed by Dmitry Titov.

The test will be added when implementing FileReader and FilerWriter.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ExceptionCode.h:

(WebCore::):

  • html/FileError.h: Added.
  • html/FileError.idl: Added.
  • page/DOMWindow.idl:
15:20 Changeset [58193] by jianli@chromium.org
  • 5 edits in trunk/WebCore

Improve code generator scripts to handle OR ('|') condition in the
extended attributes.
https://bugs.webkit.org/show_bug.cgi?id=37998

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/IDLStructure.pm:
15:16 Changeset [58192] by adele@apple.com
  • 21 edits
    1 delete in trunk/WebCore

Fix for <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
https://bugs.webkit.org/show_bug.cgi?id=37936

Reviewed by Dan Bernstein.

This change breaks the GlyphMetricsMap into two maps - one for width and one for bounds, so that we don't store
a FloatRect for the glyph bounds unless we need to.

Covered by existing tests. This should not cause any change in functionality.

Updated for removal of GlyphMetricsMap.cpp

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Made GlyphMetricsMap a template, so it can be used for separate width and bounds maps.

  • platform/graphics/GlyphMetricsMap.cpp: Removed.
  • platform/graphics/GlyphMetricsMap.h:

(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
(WebCore::::unknownMetrics):
(WebCore::::locatePageSlowCase):

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::adjustGlyphsAndAdvances):

Call boundsForGlyph instead of metricsForGlyph.

  • platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::shapeAndPlaceItem):

ditto.

  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::platformGlyphInit):

Call setMetricsForGlyph for both glyph maps.

Break getters and setters for metricsForGlyph into widthForGlyph and boundsForGlyph, maintaining present behavior.

  • platform/graphics/SimpleFontData.h:

(WebCore::):
(WebCore::SimpleFontData::boundsForGlyph):
(WebCore::SimpleFontData::widthForGlyph):

  • platform/graphics/cairo/SimpleFontDataCairo.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/gtk/SimpleFontDataPango.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

  • platform/graphics/win/SimpleFontDataCairoWin.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::boundsForGDIGlyph):
(WebCore::SimpleFontData::widthForGDIGlyph):

  • platform/graphics/wince/SimpleFontDataWince.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):

  • platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

15:07 Changeset [58191] by xji@chromium.org
  • 4 edits
    2 adds in trunk

2010-04-23 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein and Darin Adler

Fix issue "caret does not paint after type in characters in right
aligned div or after delete all characters in RTL div or
0px right padding RTL textarea"
https://bugs.webkit.org/show_bug.cgi?id=25319

Test: editing/inserting/caret-position.html

  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):

2010-04-23 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein and Darin Adler

Fix issue "caret does not paint after type in characters in right
aligned div or after delete all characters in RTL div or
0px right padding RTL textarea"
https://bugs.webkit.org/show_bug.cgi?id=25319

  • editing/inserting/caret-position-expected.txt: Added.
  • editing/inserting/caret-position.html: Added.
  • platform/mac/editing/input/caret-primary-bidi-expected.txt:
15:02 Changeset [58190] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-23 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [Performance] GraphicsLayer: constructing the layers takes too long
https://bugs.webkit.org/show_bug.cgi?id=36365

The issue came from using QGraphicsView's cache as is. The problem is that
several code-paths require re-rendering of the item, but not re-rendering
of the web content into the cache.

The way to solve it is by having GraphicsLayerQt manage the cache directly
via QPixmapCache, instead of using QGraphicsItem cache modes.

FPS measurement shows significant improvement (20FPS before, 40FPS after)
on several use-cases, including blog-files/leaves on a desktop environment.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::recache): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
14:58 Changeset [58189] by weinig@apple.com
  • 5 edits
    1 copy
    3 moves
    1 delete in trunk/WebKit2

Fix for https://bugs.webkit.org/show_bug.cgi?id=38059
Merge mac and win DrawingAreaUpdateChunk implementation.

Reviewed by Anders Carlsson.

  • UIProcess/win/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::didSetSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):

  • UIProcess/win/DrawingAreaProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/DrawingAreaUpdateChunk.cpp: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp.

(WebKit::DrawingAreaUpdateChunk::setSize):

  • WebProcess/WebPage/DrawingAreaUpdateChunk.h: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: Removed.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h: Removed.
  • WebProcess/WebPage/mac/DrawingAreaUpdateChunkMac.cpp: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp: Removed.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.h: Removed.
  • WebProcess/WebPage/win/DrawingAreaUpdateChunkWin.cpp: Copied from WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp.

(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):

  • win/WebKit2.vcproj:
14:13 Changeset [58188] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-04-23 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Avoid marking symbols as dllexport in chromium win builds
https://bugs.webkit.org/show_bug.cgi?id=38058

No new tests.

  • config.h:
13:39 Changeset [58187] by morrita@google.com
  • 6 edits
    2 adds in trunk

2010-04-23 MORITA Hajime <morrita@google.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=37187
SVG <use href="foo"> is interpreted as <use href="#foo">

getTarget() did return url parameter as is if doesn't have
fragment identifier. So fixed to return empty string in such case
because we need to distinguish "yyy.html" from "xxx.svg#yyy.html".


Test: svg/custom/broken-internal-references.svg

  • svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument):
  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):

2010-04-23 MORITA Hajime <morrita@google.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=37187
SVG <use href="foo"> is interpreted as <use href="#foo">

  • platform/mac/svg/custom/broken-internal-references-expected.checksum: Added.
  • platform/mac/svg/custom/broken-internal-references-expected.png: Added.
  • platform/mac/svg/custom/broken-internal-references-expected.txt: Added.
  • svg/custom/broken-internal-references.svg: Added.
  • svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.txt:
  • svg/dynamic-updates/script-tests/SVGTRefElement-dom-href-attr.js: (executeTest): Updated to follow this fix. href value should be an URL, not an id.
13:22 Changeset [58186] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2010-04-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

When webkitAnimationEnd event fires, on-screen rendering should show the last frame of animation
https://bugs.webkit.org/show_bug.cgi?id=37955

After r37484, animation and transition end events were fired on a timer, after the animation/transition
ended. This opened up one event loop cycle in which the non-animating state of the element was visible
before the event fired, resulting in flashes in content that reset style from the event handler.

Fix by firing these events in the same event cycle as the animation end, once all animations
have been updated. This also required moving the place that start animations are fixed until
a later state in the state machine, so that animations have their start time set at the point
the event is fired (to avoid an assertion when using the freeze API in DRT).

Not testable, since the flash is very transitory and cannot be captured in a pixel test.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine): Move the firing of 'start' events into the state where the start time is known.
  • page/animation/AnimationControllerPrivate.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired): Call the new fireEventsAndUpdateStyle() method. (WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): New method to share code that used to be in updateStyleIfNeededDispatcherFired(). (WebCore::AnimationControllerPrivate::animationTimerFired): Call fireEventsAndUpdateStyle() once we've processed all animations.
13:22 Changeset [58185] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-04-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

CompositeAnimation::updateKeyframeAnimations() can make a KeyframeAnimation for animation "none"
https://bugs.webkit.org/show_bug.cgi?id=38017

Check to see if the animation name is "none", and don't fire off a keyframe animation in
that case.

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
13:10 Changeset [58184] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Remove an assert. (It's not valid when resizing).

Reviewed by Sam Weinig.

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::didUpdate):

12:43 Changeset [58183] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests: add a "--retry-failures" flag and a
"--no-retry-failures" flag (the former is the default). Also, rename
"--print-unexpected-results" and "--retry-unexpected-results" to
"--print-last-failures" and "--retry-last-failures" because the
retry flag was confusing. The new flag names aren't great, but
hopefully they're less confusing.

https://bugs.webkit.org/show_bug.cgi?id=37838

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12:35 Changeset [58182] by agl@chromium.org
  • 45 edits in trunk/LayoutTests

2010-04-23 Adam Langley <agl@chromium.org>

Unreviewed, expectations update.

Merging Skia r526 lead to a number of pixels changing color by 1 in
layout tests. This is the rebaseline for Windows and Linux. (Mac isn't
using Skia for this.)

  • platform/chromium-linux/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum:
  • platform/chromium-linux/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png:
  • platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.checksum:
  • platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
  • platform/chromium-linux/fast/dom/Window/btoa-pnglet-expected.checksum:
  • platform/chromium-linux/fast/dom/Window/btoa-pnglet-expected.png:
  • platform/chromium-linux/fast/replaced/image-solid-color-with-alpha-expected.checksum:
  • platform/chromium-linux/fast/replaced/image-solid-color-with-alpha-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10633-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug10633-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug20804-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug20804-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4803-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4803-expected.png:
  • platform/chromium-win/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum:
  • platform/chromium-win/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png:
  • platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.checksum:
  • platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
  • platform/chromium-win/fast/dom/Window/btoa-pnglet-expected.checksum:
  • platform/chromium-win/fast/dom/Window/btoa-pnglet-expected.png:
  • platform/chromium-win/fast/replaced/image-solid-color-with-alpha-expected.checksum:
  • platform/chromium-win/fast/replaced/image-solid-color-with-alpha-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10565-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10633-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug10633-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug14323-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug16012-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug16012-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug20804-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug20804-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4803-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4803-expected.png:
12:11 Changeset [58181] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Qt build.

  • wtf/qt/MainThreadQt.cpp: #include <QThread>
12:01 Changeset [58180] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Fix build.

  • UIProcess/win/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::paint):
(WebKit::DrawingAreaProxy::setSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:

(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):

11:59 Changeset [58179] by weinig@apple.com
  • 13 edits
    2 adds in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=38022
Move isMainThread predicate function to MainThread.h

Reviewed by Anders Carlsson.

JavaScriptCore:

  • wtf/MainThread.cpp:

(WTF::initializeMainThread):
(WTF::isMainThread):

  • wtf/MainThread.h:
  • wtf/Threading.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

  • wtf/gtk/ThreadingGtk.cpp:

(WTF::initializeThreading):

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::isMainThread):

  • wtf/qt/MainThreadQt.cpp:

(WTF::isMainThread):

  • wtf/qt/ThreadingQt.cpp:

(WTF::initializeThreading):

  • wtf/text/AtomicString.cpp:

JavaScriptGlue:

Added forwarding header for MainThread.h

  • ForwardingHeaders/wtf/MainThread.h: Added.

WebKitTools:

Added forwarding header for MainThread.h

  • DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added.
11:31 Changeset [58178] by eric@webkit.org
  • 4 edits in trunk

2010-04-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Netscape plugin support for minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=38026

No new tests, as there is no new functionality.

  • WebCore.pri:

2010-04-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Netscape plugin support for minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=38026

Pass the minimal configuration option to Qt build system
as part of the CONFIG variable.

  • Scripts/build-webkit:
10:33 Changeset [58177] by hamaji@chromium.org
  • 21 edits in trunk/WebCore

2010-04-23 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Need borderAndPadding(Width|Height)
https://bugs.webkit.org/show_bug.cgi?id=38046

Refactoring only, so no new tests.

  • rendering/InlineBox.cpp: (WebCore::InlineBox::height):
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::calcPrefWidths):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcBorderBoxWidth): (WebCore::RenderBox::calcBorderBoxHeight): (WebCore::RenderBox::calcContentBoxWidth): (WebCore::RenderBox::calcContentBoxHeight): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::availableHeightUsing): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced): (WebCore::RenderBox::positionForPoint):
  • rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::borderAndPaddingHeight): (WebCore::RenderBoxModelObject::borderAndPaddingWidth):
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::calcPrefWidths):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcPrefWidths):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::calcPrefWidths):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcPrefWidths): (WebCore::RenderFlexibleBox::allowedChildFlex):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcPrefWidths):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcPrefWidths): (WebCore::RenderListBox::calcHeight):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::calcPrefWidths):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calcPrefWidths):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcPrefWidths):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::calcPrefWidths): (WebCore::RenderSlider::layout):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::styleOrColWidth):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textBlockHeight): (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::updateWidgetPosition):
10:18 Changeset [58176] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Size mismatch between format string and argument in dumpTextEncodingNameMap()

Reviewed by Darin Adler.

See Bug 38030 and r58157.

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::dumpTextEncodingNameMap): Assigned
textEncodingNameMap->size() to an unsigned variable before using
it in the fprintf() statement.

10:00 Changeset [58175] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

BUILD FIX: Attempt to fix Windows build after Bug 36187 landed in r58168

  • DerivedSources.cpp: Changed include of JSMedia.cpp to

JSStyleMedia.cpp.

09:47 Changeset [58174] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

BUILD FIX: Fix Mac build after Bug 36187 landed in r58168

  • WebCore.xcodeproj/project.pbxproj: Renamed DOMMedia.h,

DOMMedia.mm, DOMMediaInternal.h to DOMStyleMedia.h,
DOMStyleMedia.mm, DOMStyleMediaInternal.h.

09:33 Changeset [58173] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build fix.

Change Media to StyleMedia

  • DerivedSources.make:
09:28 Changeset [58172] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed layout fix.

Change [object Media] to [object StyleMedia]

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
09:24 Changeset [58171] by kenneth@webkit.org
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild.

09:15 Changeset [58170] by kenneth@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed layout fix.

Change [object Media] to [object StyleMedia]

  • fast/dom/Window/window-properties-expected.txt:
09:08 Changeset [58169] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-04-23 Xan Lopez <xlopez@igalia.com>

Try to fix the GTK+ bots.

  • GNUmakefile.am:
08:42 Changeset [58168] by kenneth@webkit.org
  • 15 edits
    3 moves in trunk

WebCore: Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187

Reviewed by Laszlo Gombos.

Rename the interface Media to StyleMedia as required by the
new CSSOM View spec.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/Media.cpp: Removed.
  • css/Media.h: Removed.
  • css/Media.idl: Removed.
  • css/StyleMedia.cpp: Added.

(WebCore::StyleMedia::StyleMedia):
(WebCore::StyleMedia::type):
(WebCore::StyleMedia::matchMedium):

  • css/StyleMedia.h: Added.

(WebCore::StyleMedia::create):
(WebCore::StyleMedia::disconnectFrame):

  • css/StyleMedia.idl: Added.
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::styleMedia):

  • page/DOMWindow.h:

(WebCore::DOMWindow::optionalMedia):

  • page/DOMWindow.idl:

LayoutTests: Updated test results as the interface Media was renamed
to StyleMedia.

Reviewed by NOBODY (OOPS!).

  • fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
08:38 Changeset [58167] by eric@webkit.org
  • 7 edits in trunk/JavaScriptCore

2010-04-23 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Laszlo Gombos.

Add RVCT support for Linux

Developed in cooperation with Gabor Loki.

  • API/JSStringRef.h:
  • jit/ExecutableAllocator.h:
  • jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutableAllocator::cacheFlush):
  • jit/JITStubs.cpp:
  • wtf/MathExtras.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
08:02 Changeset [58166] by yurys@chromium.org
  • 6 edits in trunk/WebCore

2010-04-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide JSC implementation for scopeType method on
call frame and use same jsvascript code for JSC and v8 when collecting
scope chain data.

https://bugs.webkit.org/show_bug.cgi?id=37663

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
  • inspector/InjectedScriptHost.idl:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
07:59 Changeset [58165] by eric@webkit.org
  • 3 edits
    1 move in trunk/JavaScriptCore

2010-04-23 Patrick Gansterer <paroga@paroga.com>

Reviewed by Laszlo Gombos.

[WIN] Move OwnPtrWin.cpp into platform specific folder.
https://bugs.webkit.org/show_bug.cgi?id=38042

07:45 Changeset [58164] by eric@webkit.org
  • 1 edit
    1 move in trunk/JavaScriptCore

2010-04-23 Patrick Gansterer <paroga@paroga.com>

Reviewed by Laszlo Gombos.

[BREWMP] Move OwnPtrBrew.cpp into platform specific folder.
https://bugs.webkit.org/show_bug.cgi?id=38042

  • wtf/OwnPtrBrew.cpp: Removed.
  • wtf/brew/OwnPtrBrew.cpp: Copied from JavaScriptCore/wtf/OwnPtrBrew.cpp.
06:05 Changeset [58163] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-23 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with the hosting page name
https://bugs.webkit.org/show_bug.cgi?id=37988

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
02:51 Changeset [58162] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-23 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Flaky Inspector tests.
https://bugs.webkit.org/show_bug.cgi?id=36217

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
02:42 Changeset [58161] by eric@webkit.org
  • 9 edits in trunk

2010-04-23 Yaar Schnitman <yaar@chromium.org>

Reviewed by Adam Barth.

Auto-generate WebGLRenderingContext overloads in V8
https://bugs.webkit.org/show_bug.cgi?id=37818

  • fast/canvas/webgl/script-tests/texImageTest.js: Test was wrong: Passing 0 value for a WebGLArray argument in texImage2D should throw the same exception as when passed to textSubImage2D.
  • platform/chromium-mac/fast/canvas/webgl/texImageTest-expected.txt:
  • fast/canvas/webgl/texImageTest-expected.txt: Changes to reflect test.

2010-04-23 Yaar Schnitman <yaar@chromium.org>

Reviewed by Adam Barth.

Auto-generate WebGLRenderingContext overloads in V8
https://bugs.webkit.org/show_bug.cgi?id=37818

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • html/canvas/WebGLRenderingContext.cpp: Added missing overloads for the following:. (WebCore::WebGLRenderingContext::texImage2D) (WebCore::WebGLRenderingContext::texSubImage2D)
  • html/canvas/WebGLRenderingContext.h: Added missing overloads.
  • html/canvas/WebGLRenderingContext.idl: IDL definition of overloads.
02:31 Changeset [58160] by eric@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2010-04-23 Jeff Schiller <codedread@gmail.com>

Reviewed by Nikolas Zimmermann.

Display tooltips when hovering over SVG elements, Bug 16854
https://bugs.webkit.org/show_bug.cgi?id=16854

Manual test added for verifying tooltips.

  • manual-tests/svg-tooltip.svg: Added.
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::title): xlink:title takes precedence, otherwise SVGStyledElement::title() is used
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title): checks for a shadow parent and uses that title, otherwise uses the content's title
  • svg/SVGStyledElement.h: add title() method declaration
01:43 Changeset [58159] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-04-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed, Chromium test expectation change.

Change expectation of fast/url/file-http-base.html for Chromium to TEXT.
https://bugs.webkit.org/show_bug.cgi?id=38038

  • platform/chromium/test_expectations.txt:
01:23 Changeset [58158] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<http://webkit.org/b/38032> No need to content sniff 304 responses
<rdar://problem/7891726>

Reviewed by Brady Eidson.

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
No need to adjust the MIME type on 304 responses since they're
only used to determine if the resource needs to be refetched.

01:05 Changeset [58157] by ddkilzer@apple.com
  • 3 edits in trunk/WebCore

<http://webkit.org/b/38030> Add WebCore::dumpTextEncodingNameMap() to dump text encoding map on debug builds

Reviewed by Alexey Proskuryakov.

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::dumpTextEncodingNameMap): Added.

  • platform/text/TextEncodingRegistry.h:

(WebCore::dumpTextEncodingNameMap): Added declaration.

00:36 Changeset [58156] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

<http://webkit.org/b/38029> +[WebTextIteratorPrivate initialize] is missing call to JSC::initializeThreading()

Reviewed by Timothy Hatcher.

Every other Objective-C class that calls
WebCoreObjCFinalizeOnMainThread(self) in +initialize also calls
JSC::initializeThreading(). The WebTextIteratorPrivate class
was the only one missing this call.

  • WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]): Added call to
JSC::initializeThreading().

00:18 Changeset [58155] by aestes@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to force a rebuild.

00:14 Changeset [58154] by aestes@apple.com
  • 3 edits in trunk/WebKit/win

Roll out http://trac.webkit.org/changeset/55385.

Rubber stamped by Steve Falkenburg.

<rdar://problem/7884444>

  • Interfaces/IWebUIDelegatePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::createPlugin):

00:04 Changeset [58153] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-04-22 Tony Chang <tony@chromium.org>

Reviewed by Dan Bernstein.

Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
https://bugs.webkit.org/show_bug.cgi?id=37950

  • editing/text-iterator/rtl-selection-crash-expected.txt: Added.
  • editing/text-iterator/rtl-selection-crash.html: Added.

2010-04-22 Tony Chang <tony@chromium.org>

Reviewed by Dan Bernstein.

Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
https://bugs.webkit.org/show_bug.cgi?id=37950

Test: editing/text-iterator/rtl-selection-crash.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode):
00:00 Changeset [58152] by mjs@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Add a test for file URL canonicalization with an http base
https://bugs.webkit.org/show_bug.cgi?id=38035

  • fast/url/file-http-base-expected.txt: Added.
  • fast/url/file-http-base.html: Added.
  • fast/url/script-tests/file-http-base.js: Added.
Note: See TracTimeline for information about the timeline view.