Timeline



May 2, 2010:

10:40 PM Changeset in webkit [58666] by Chris Jerdonek
  • 1 edit in trunk/WebKitTools/ChangeLog

Unreviewed.

Corrected a file path in the ChangeLog entry for r58663 (bug 38319) below.

9:25 PM Changeset in webkit [58665] by mitz@apple.com
  • 3 edits
    2 adds in trunk

Another case of <rdar://problem/7552959> REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()
https://bugs.webkit.org/show_bug.cgi?id=38445

Reviewed by Simon Fraser.

WebCore:

Test: editing/selection/mixed-editability-11.html

  • dom/Position.cpp:

(WebCore::downstreamIgnoringEditingBoundaries): Added. Returns the furthest visually equivalent
position downstream, crossing any editability boundaries.
(WebCore::upstreamIgnoringEditingBoundaries): Similarly for upstream.
(WebCore::Position::getInlineBoxAndOffset): Changed the logic for finding an inline box for positions
whose node is a block flow. Instead of traversing the DOM, advance downstream or upstream as far as
possible, crossing any editability boudaries. Infinite recursion is avoided by advancing all the way
and checking that the new position is different from the starting position. Also replaced the specific
test for buttons with the generic and more comprehensive canHaveChildrenForEditing().

LayoutTests:

  • editing/selection/mixed-editability-11-expected.txt: Added.
  • editing/selection/mixed-editability-11.html: Added.
7:21 PM Changeset in webkit [58664] by eric@webkit.org
  • 2 edits in trunk

2010-05-02 Geoff Levand <geoff.levand@am.sony.com>

Reviewed by Eric Seidel.

[GTK] Fix out of source build failure
https://bugs.webkit.org/show_bug.cgi?id=38051

Add a preprocessor include path for generated GTK header files.
Fixes build errors like these when building GTK out of source:

webkit.h: error: webkit/webkitversion.h: No such file or directory

  • GNUmakefile.am:
6:49 PM Changeset in webkit [58663] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-02 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=38319

  • Scripts/VCSUtils.pm:
    • In parseDiffHeader()--
      • Added an "scmFormat" hash key to the return value to represent whether the diff is Git or SVN formatted.
      • Adjusted the code so the value of "copiedFromPath" will be undef rather than "does not exist" if the file was not copied.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Added a FIXME to refactor these unit tests to use is_deeply().
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Updated the unit tests to test the "scmFormat" value.
    • Simplified the unit tests by refactoring them to use is_deeply().
3:18 PM Changeset in webkit [58662] by eric@webkit.org
  • 5 edits in trunk

2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with QT_NO_BEARERMANAGEMENT
https://bugs.webkit.org/show_bug.cgi?id=38324

  • platform/network/NetworkStateNotifier.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:

2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with QT_NO_BEARERMANAGEMENT
https://bugs.webkit.org/show_bug.cgi?id=38324

  • Api/qwebsettings.cpp:
2:48 PM Changeset in webkit [58661] by Simon Hausmann
  • 3 edits
    1 add in trunk

[Qt] QtWebKit versioning added
https://bugs.webkit.org/show_bug.cgi?id=37207

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-04-29
Reviewed by Simon Hausmann.

QtWebkit releases separated from Qt release cycle.

WebCore:

  • WebCore.pro:

WebKit/qt:

  • qtwebkit_version.pri: Added.
2:42 PM Changeset in webkit [58660] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Old Style trimWhitespace() should be trim()
https://bugs.webkit.org/show_bug.cgi?id=38441

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
2:31 PM Changeset in webkit [58659] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with QT_NO_LINEEDIT
https://bugs.webkit.org/show_bug.cgi?id=38324

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::~RenderThemeQt): (WebCore::RenderThemeQt::findFrameLineWidth):
1:18 PM Changeset in webkit [58658] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-05-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Touch inspector controller to kick windows tests.

  • inspector/InspectorController.cpp:
11:32 AM Changeset in webkit [58657] by pfeldman@chromium.org
  • 3 edits in trunk

2010-05-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: IMG nodes are being added to the DOM tree late, sometimes hiding the revealed element.

https://bugs.webkit.org/show_bug.cgi?id=38432

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode): (WebInspector.ElementsTreeElement.prototype.updateTitle): (WebInspector.ElementsTreeElement.prototype._attributeHTML): ():
10:08 AM WebInspector edited by pfeldman@chromium.org
(diff)
9:30 AM Changeset in webkit [58656] by krit@webkit.org
  • 22 edits
    4 adds in trunk

2010-05-02 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hkern implementation incomplete
https://bugs.webkit.org/show_bug.cgi?id=38407

Test: svg/text/text-hkern.svg

The current SVG hkern implementation is incomplete and partly wrong. We pass the ACID3 test
by accident.
The new implementation supports all glyph and unicode combinations that are allowed by the Spec
and fixes various of bugs. The parser moved from SVGFontElement to the general parsing code in
SVGParserUtilities.
Some clean-up makes the code more readable and reuseable for the upcoming vkern implementation.
hkern support for text on path is missing and will be added by a following patch.
Unicode strings of hkern elements are just parsed once and not on every glyph again anymore.

  • rendering/SVGRootInlineBox.cpp: (WebCore::calculateCSSKerning): (WebCore::applySVGKerning): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
  • svg/SVGFontElement.cpp: (WebCore::stringMatchesUnicodeRange): (WebCore::stringMatchesGlyphName): (WebCore::matches): (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
  • svg/SVGFontElement.h:
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::buildHorizontalKerningPair):
  • svg/SVGHKernElement.h:
  • svg/SVGParserUtilities.cpp: (WebCore::parseGlyphName): (WebCore::parseUnicodeRange): (WebCore::parseKerningUnicodeString):
  • svg/SVGParserUtilities.h:

2010-05-02 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hkern implementation incomplete
https://bugs.webkit.org/show_bug.cgi?id=38407

The hkern patch fixes some very old bugs in some tests of the official
SVG Test suite. Added a new test to check correct behavior on different
use cases of textin SVG.

  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/mac/svg/text/kerning-expected.checksum:
  • platform/mac/svg/text/kerning-expected.png:
  • platform/mac/svg/text/text-hkern-expected.checksum: Added.
  • platform/mac/svg/text/text-hkern-expected.png: Added.
  • platform/mac/svg/text/text-hkern-expected.txt: Added.
  • svg/text/text-hkern.svg: Added.

2010-05-02 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hkern implementation incomplete
https://bugs.webkit.org/show_bug.cgi?id=38407

We support hkern now. Mention this in the SVG status page.

  • projects/svg/status.xml:
8:27 AM Changeset in webkit [58655] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: debugger shortcuts are processed twice if source frame has focus.

https://bugs.webkit.org/show_bug.cgi?id=38431

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
8:03 AM Changeset in webkit [58654] by tkent@chromium.org
  • 1 edit in trunk/WebCore/platform/ThreadGlobalData.cpp

Unreviewed. Build fix on Japanese Windows.
Replace a non-ASCII character in a comment with an ASCII character.

5:47 AM Changeset in webkit [58653] by eric@webkit.org
  • 2 edits in trunk

2010-05-02 Kartikaya Gupta <kagupta@rim.com>

Reviewed by George Staikos.

When running the IDL file through the preprocessor, wait for the preprocessor subcommand to fully terminate before continuing. Without this, if multiple IDL files are parsed in a tight loop, the code dies after 64 IDL files because it exhausts the available system resources.

https://bugs.webkit.org/show_bug.cgi?id=37888

No new tests. None needed.

  • bindings/scripts/IDLParser.pm:
5:26 AM Changeset in webkit [58652] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

[Qt] Enable JIT for QtWebKit on Symbian
https://bugs.webkit.org/show_bug.cgi?id=38339

JIT on Symbian has been stable for quite some time, it
is time to turn it on by default.

  • wtf/Platform.h:
5:05 AM Changeset in webkit [58651] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Eric Seidel.

[Qt] Build error in GraphicsContext3DQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=38382

Removed duplicate implementation of isGLES2Compliant from
GraphicsContext3DQt.cpp. Removed deprecated API stuff for
texImage2D/texSubImage2D.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:
4:54 AM Changeset in webkit [58650] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Garret Kelly <gdk@chromium.org>

Reviewed by David Levin.

Make the Touch RuntimeEnabledFeature disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=38392

  • bindings/generic/RuntimeEnabledFeatures.cpp: Disable the Touch feature by default.
4:29 AM Changeset in webkit [58649] by tkent@chromium.org
  • 1 edit in trunk/WebKit/chromium/src/SharedWorkerRepository.cpp

Unreviewed. Fix a build failure by r58647.

1:55 AM Changeset in webkit [58648] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-05-02 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage::userAgentForUrl is terrible API
https://bugs.webkit.org/show_bug.cgi?id=33875

Simplify the creation of the user agent string to avoid some
overhead for each loaded url.

The static part of the user agent is cached so it only have
to be made once.
This creation has been made in order to simplify the code.

The two variable: application name and current language are
set dynamically when needed.
The default locale is non longer created if the widget locale
is used.

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::userAgentApplicationName): (tst_QWebPage::userAgentLocaleChange):
1:39 AM Changeset in webkit [58647] by eric@webkit.org
  • 10 edits in trunk

2010-05-02 Michael Nordman <Michael Nordman>

Reviewed by Dmitry Titov.

Define two new ResourceRequestBase TargetTypes for worker and shared worker
main resources. Use the new target types where appropiate. Add logic to marshal
the target type specified by requests initiated on a background worker thread.

https://bugs.webkit.org/show_bug.cgi?id=38295

No new tests. This doesn't have script visible artifacts.

  • platform/network/ResourceRequestBase.cpp: marshal the values (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData):
  • platform/network/ResourceRequestBase.h: define the types (WebCore::ResourceRequestBase::):
  • workers/DefaultSharedWorkerRepository.cpp: use TargetIsSharedWorker (WebCore::SharedWorkerScriptLoader::load):
  • workers/Worker.cpp: use TargetIsWorker (WebCore::Worker::Worker):
  • workers/WorkerContext.cpp: use TargetIsScript for importScripts (WebCore::WorkerContext::importScripts):
  • workers/WorkerScriptLoader.cpp: add a data member for the target type (WebCore::WorkerScriptLoader::WorkerScriptLoader): (WebCore::WorkerScriptLoader::createResourceRequest):
  • workers/WorkerScriptLoader.h:

2010-05-02 Michael Nordman <Michael Nordman>

Reviewed by Dmitry Titov.

Define two new ResourceRequestBase TargetTypes for worker and shared worker
main resources. Use the new target types where appropiate. Add logic to marshal
the target type specified by requests initiated on a background worker thread.

https://bugs.webkit.org/show_bug.cgi?id=38295

  • src/SharedWorkerRepository.cpp: use TargetIsSharedWorker (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
1:12 AM Changeset in webkit [58646] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-02 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] Upstream test expectations for:
http/tests/loading/basic-auth-resend-wrong-credentials.html
https://bugs.webkit.org/show_bug.cgi?id=38387

  • platform/chromium/test_expectations.txt:
1:01 AM Changeset in webkit [58645] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: animation incorrect when scrolling
https://bugs.webkit.org/show_bug.cgi?id=38371

This is a regression introduced with the invalidate-on-scroll code path, that uses QGraphicsWebViewPrivate::update()
instead of QGraphicsWebViewPrivate::scroll(). The patch makes sure that the scrolling position is correct on
each content update - this shouldn't have a performance impact - the only overhead is an additional value-test on each update.

Tested by http://www.the-art-of-web.com/css/css-animation/

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update):
12:50 AM Changeset in webkit [58644] by eric@webkit.org
  • 8 edits
    1 move in trunk/LayoutTests

2010-05-02 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

fast/events/touch has non-standard script test wrappers
https://bugs.webkit.org/show_bug.cgi?id=38084

Tidy up the touch event layout tests. Make the script-tests TEMPLATE.html
generate asynchronous style tests using js-test-post-function.js and move
the non-standard synchronous test into the resources directory.

  • fast/events/touch/basic-multi-touch-events.html: Regenerate from TEMPLATE.html
  • fast/events/touch/basic-single-touch-events.html: ditto.
  • fast/events/touch/send-oncancel-event.html: ditto.
  • fast/events/touch/touch-target.html: ditto.
  • fast/events/touch/create-touch-event.html: Link to script in resources rather than

script-tests as this test is not generated from TEMPLATE.html.

  • fast/events/touch/resources/create-touch-event.js: Copied from LayoutTests/fast/events/touch/script-tests/create-touch-event.js.
  • fast/events/touch/script-tests/TEMPLATE.html: Update to generate asynchronous tests.
  • fast/events/touch/script-tests/create-touch-event.js: Removed.
  • fast/events/touch/script-tests/touch-target.js: Refactor to work with new wrapper

generated from TEMPLATE.html.

12:23 AM Changeset in webkit [58643] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-05-02 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Darin Fisher.

Include WebWindowFeatures in call to WebViewClient::createView.
https://bugs.webkit.org/show_bug.cgi?id=38301

  • public/WebViewClient.h: (WebKit::WebViewClient::createView):
  • public/WebWindowFeatures.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow):
12:12 AM Changeset in webkit [58642] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Adele Peterson.

Webkit doesn't compile with 3D-canvas enabled and video disabled
https://bugs.webkit.org/show_bug.cgi?id=38297

Added a #ifdef ENABLE(VIDEO) to WebGL code

No new tests: compile fix.

  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::texImage2D): (WebCore::JSWebGLRenderingContext::texSubImage2D):
12:01 AM Changeset in webkit [58641] by eric@webkit.org
  • 4 edits in trunk

2010-05-01 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

[chromium] Skia needs to fade DragImages
https://bugs.webkit.org/show_bug.cgi?id=38008

tested by DragImageTest

  • platform/chromium/DragImageChromiumSkia.cpp: (WebCore::dissolveDragImageToFraction):implement (WebCore::createDragImageFromImage):deep copy instead of shallow

2010-05-01 Evan Stade <estade@chromium.org>

Reviewed by David Levin

[chromium] Skia needs to fade DragImages
https://bugs.webkit.org/show_bug.cgi?id=38008

  • tests/DragImageTest.cpp: (DragImageTest.CreateDragImage): test that the drag image is a deep copy

May 1, 2010:

10:27 PM Changeset in webkit [58640] by ap@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Not reviewed.

More shortening of Sputnik paths.

  • fast/js/sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples: Copied from fast/js/sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples_of_Automatic_Semicolon_Insertion.
  • fast/js/sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples_of_Automatic_Semicolon_Insertion: Removed.
10:07 PM Changeset in webkit [58639] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-01 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

Add fast/repaint/fixed-move-after-keyboard-scroll.html to skipped list pending investigation
https://bugs.webkit.org/show_bug.cgi?id=38416

  • platform/mac-snowleopard/Skipped:
6:25 PM Changeset in webkit [58638] by ddkilzer@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Land test case that was supposed to be in r53607.

2010-01-20 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Stylesheet href property shows redirected URL unlike other browsers
https://bugs.webkit.org/show_bug.cgi?id=33683

Test whether the href property of style sheets contains the original or
final URL of the redirect chain that lead to the style sheet.

I couldn't figure out how to test the XSLStyleSheet parts of this
change. There didn't seem to be DOM bindings for the href property
here. If I missed it, please let me know.

  • http/tests/security/stylesheet-href-redirect-expected.txt: Added.
  • http/tests/security/stylesheet-href-redirect.html: Added.
3:44 PM Changeset in webkit [58637] by dbates@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-01 Daniel Bates <dbates@rim.com>

Reviewed by Chris Jerdonek.

https://bugs.webkit.org/show_bug.cgi?id=38423

Adds infrastructure to change the file mode of a file using
the appropriate SCM-specific routines.

No functionality was changed, so no new tests.

  • Scripts/VCSUtils.pm: Added subroutines scmToggleExecutableBit, scmAddExecutableBit, and scmRemoveExecutableBit.
  • Scripts/svn-apply: Check for the hash key executableBitDelta and toggle the executable bit.
  • Scripts/svn-unapply: Ditto.
1:23 PM Changeset in webkit [58636] by mjs@apple.com
  • 3 edits
    1 add in trunk/WebCore

2010-05-01 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

REGRESSION (r58273): Visited links do not change color immediately when Cmd-clicked
https://bugs.webkit.org/show_bug.cgi?id=38422
<rdar://problem/7921778>

Tests:

manual-tests/visited-link-new-window.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initElement): Only cache the visited link state when invoked as part of a helper call to styleForElement or pseudoStyleForElement, to avoid caching the visited link state beyond the scope of a single style lookup. (WebCore::CSSStyleSelector::styleForElement): Adjust for above change. (WebCore::CSSStyleSelector::pseudoStyleForElement): Adjust for above change.
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::styleForElement): Change so "visited link helper mode" can't accidentally be called from outside CSSStyleSelector itself. (WebCore::CSSStyleSelector::pseudoStyleForElement): ditto
  • manual-tests/visited-link-new-window.html: Added. I could not figure out any way to make an automated test that supports visited link coloring.
5:06 AM Changeset in webkit [58635] by yael.aharon@nokia.com
  • 8 edits in trunk/WebCore

Move number parsing code out of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=38203

Reviewed by Darin Adler.

The numebr parsing code follows HTML5 parsing rules and should be available outside of HTMLInputElement.
No new tests as no new functionality was introduced.

  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/HTMLParser.cpp:
  • html/HTMLParser.h:
  • html/StepRange.cpp:
  • html/ValidityState.cpp:
  • rendering/RenderSlider.cpp:
3:42 AM Changeset in webkit [58634] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-05-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Oliver Hunt.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Test webkit_dom_document_get_links.

  • tests/testdomdocument.c: (test_dom_document_get_links): (main):
3:40 AM Changeset in webkit [58633] by xan@webkit.org
  • 4 edits in trunk/WebCore

2010-05-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Oliver Hunt.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Unify more logic to skip functions into SkipFunction, and
whitelist the two [Custom] methods in HTMLCollection.idl.

  • bindings/scripts/CodeGeneratorGObject.pm:
3:20 AM Changeset in webkit [58632] by robert@webkit.org
  • 8 edits in trunk/LayoutTests

[Qt] Fix up width/height differences in smart-paste-00* results

Unreviewed fix to height/width rendering differences in results added
by r58631.

[Qt] Fix up width/height differences in smart-paste-00* results

https://bugs.webkit.org/show_bug.cgi?id=38136

  • platform/qt/editing/pasteboard/smart-paste-001-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-002-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-003-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-005-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-006-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
3:02 AM Changeset in webkit [58631] by robert@webkit.org
  • 8 edits
    1 copy
    6 adds in trunk

[Qt] Add smart paste support
2010-05-01 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add smart paste support

https://bugs.webkit.org/show_bug.cgi?id=38136

Add platform specific results.

Unskip tests:

editing/pasteboard/smart-paste-001.html
editing/pasteboard/smart-paste-002.html
editing/pasteboard/smart-paste-003.html
editing/pasteboard/smart-paste-004.html
editing/pasteboard/smart-paste-005.html
editing/pasteboard/smart-paste-006.html
editing/pasteboard/smart-paste-007.html

  • platform/qt/Skipped:
  • platform/qt/editing/pasteboard/smart-paste-001-expected.txt: Added.
  • platform/qt/editing/pasteboard/smart-paste-002-expected.txt: Added.
  • platform/qt/editing/pasteboard/smart-paste-003-expected.txt: Added.
  • platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Added.
  • platform/qt/editing/pasteboard/smart-paste-005-expected.txt: Added.
  • platform/qt/editing/pasteboard/smart-paste-006-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-007-expected.txt: Added.
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Enable smart paste support by default.
  • WebCore.pro:
  • editing/qt/SmartReplaceQt.cpp: Added. (WebCore::isCharacterSmartReplaceExempt):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::canSmartReplace):
12:07 AM Changeset in webkit [58630] by hamaji@chromium.org
  • 3 edits
    2 adds in trunk

2010-04-30 Yoshiki Hayashi <yhayashi@google.com>

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=38249

Fixes an issue where border height and padding height are ignored when computing vertically shrinking flexbox's height.

  • fast/flexbox/child-flexing-expected.txt: Added.
  • fast/flexbox/child-flexing.html: Added.

2010-04-30 Yoshiki Hayashi <yhayashi@google.com>

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=38249

Fixes an issue where border height and padding height are ignored when computing vertically shrinking flexbox's height.

Test: fast/flexbox/child-flexing.html

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::allowedChildFlex):

Apr 30, 2010:

10:34 PM Changeset in webkit [58629] by hamaji@chromium.org
  • 5 edits in trunk

2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203

  • platform/mac/Skipped:
  • platform/mac/printing/media-queries-print-expected.txt:

2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203

Use the renderer's width insteead of screen's width as the width of
a screen depends on machines.

  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):
8:09 PM Changeset in webkit [58628] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-04-30 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Timothy Hatcher.

Web Inspector: Missing INSPECTOR Guard in Console::lastWMLErrorMessage
https://bugs.webkit.org/show_bug.cgi?id=38366

Console::lastWMLErrorMessage is only available if WML is enabled, however
its implementation only makes sense as long as INSPECTOR is enabled
as well. So this adds the ENABLE(INSPECTOR) guard in the function. A
browser without ENABLE(INSPECTOR) will always get an empty result.

  • page/Console.cpp:
7:54 PM Changeset in webkit [58627] by Joseph Pecoraro
  • 8 edits
    4 adds in trunk

2010-04-28 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Oliver Hunt.

<input type="search"> with uneven padding causes text clipping
https://bugs.webkit.org/show_bug.cgi?id=38160

  • fast/css/input-search-padding.html: Added.
  • platform/mac/fast/css/input-search-padding-expected.checksum: Added.
  • platform/mac/fast/css/input-search-padding-expected.png: Added.
  • platform/mac/fast/css/input-search-padding-expected.txt: Added.

2010-04-28 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Oliver Hunt.

<input type="search"> with uneven padding causes text clipping
https://bugs.webkit.org/show_bug.cgi?id=38160

Test: fast/css/input-search-padding.html

An <input type="search"> contains an inner block, which is explicitly
centered in RenderTextControlSingleLine based on the height of the element.
However, the clipping rect was not using the set location, and instead
calculated off of the top border and padding alone. This also vertically
centers the Caps Lock indicator.

  • rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
  • rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator (WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
  • rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">
6:01 PM Changeset in webkit [58626] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix the build.

  • Platform/CoreIPC/mac/ConnectionMac.cpp: Add missing #include.
5:49 PM Changeset in webkit [58625] by jhoneycutt@apple.com
  • 5 edits
    1 add in trunk

Caret may fail to blink if a focus handler brings up a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=38372

Reviewed by Darin Adler.

WebCore:

  • manual-tests/onfocus-alert-blinking-caret.html: Added.
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
Moved the call to setCaretBlinkingSuspended() from here...
(WebCore::EventHandler::handleMousePressEvent):
... to here. This makes us suspend caret blinking before dispatching the
mouse down event. If dispatching the mouse down event allows the message
loop to run, we want mouse up events received in that message loop to be
able to resume caret blinking.
(WebCore::EventHandler::lostMouseCapture):
We've lost mouse capture and won't be notified of mouse up events;
resume caret blinking.

  • page/EventHandler.h:

Declare lostMouseCapture().

WebKit/win:

  • WebView.cpp:

(WebView::handleMouseEvent):
If the message is WM_CANCELMODE, which indicates that we our capturing
of mouse events has been cancelled, tell the EventHandler.
It's possible to re-enter this function if handling a mouse event allows
the message loop to run; moved up the call to setMouseActivated(), so
that if we do re-enter this function, the later mouse event will not be
considered as activating the window.
(WebView::WebViewWndProc):
Handle WM_CANCELMODE by calling handleMouseEvent().

5:22 PM Changeset in webkit [58624] by weinig@apple.com
  • 12 edits
    3 adds in trunk/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=38413
Add callback based API to get the textual representation of the RenderTree.

Reviewed by Anders Carlsson.

  • Also ensures that any pending callbacks are invalidated if the WebPage closes (expectedly or unexpectedly).
  • A follow up patch will unify the callback mechanism with a common base class.
  • Shared/CoreIPCSupport/WebPageMessageKinds.h:

(WebPageMessage::):

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

(WebPageProxyMessage::):

  • UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame_f):
(WKPageRenderTreeExternalRepresentation_f):
(callRenderTreeExternalRepresentationBlockAndDispose):
(disposeRenderTreeExternalRepresentationBlock):
(WKPageRenderTreeExternalRepresentation):

  • UIProcess/API/C/WKPagePrivate.h: Added.
  • UIProcess/RenderTreeExternalRepresentationCallback.cpp: Added.

(WebKit::generateCallbackID):
(WebKit::RenderTreeExternalRepresentationCallback::RenderTreeExternalRepresentationCallback):
(WebKit::RenderTreeExternalRepresentationCallback::~RenderTreeExternalRepresentationCallback):
(WebKit::RenderTreeExternalRepresentationCallback::performCallbackWithReturnValue):
(WebKit::RenderTreeExternalRepresentationCallback::invalidate):

  • UIProcess/RenderTreeExternalRepresentationCallback.h: Added.

(WebKit::RenderTreeExternalRepresentationCallback::create):
(WebKit::RenderTreeExternalRepresentationCallback::callbackID):

  • UIProcess/ScriptReturnValueCallback.cpp:

(WebKit::ScriptReturnValueCallback::~ScriptReturnValueCallback):
(WebKit::ScriptReturnValueCallback::performCallbackWithReturnValue):
(WebKit::ScriptReturnValueCallback::invalidate):

  • UIProcess/ScriptReturnValueCallback.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getRenderTreeExternalRepresentation):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
  • win/WebKit2.vcproj:
4:54 PM Changeset in webkit [58623] by Simon Fraser
  • 3 edits in trunk/WebKit/mac

2010-04-30 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/7477071> REGRESSION: Bad flicker when wheel-scrolling Google Maps, iPad gallery and other sites

Sites that frequently toggle content in and out of compositing layers (like http://www.tumblr.com/boothed)
can cause flickering because of unsychronized compositing layer and view-based updates. There were two
underlying issues:

  1. On SnowLeopard, AppKit can throttle window updates, thus breaking an assumption that NSView drawing will happen on the runloop cycle after a repaint. This provided a window for the layerSyncRunLoopObserver to fire and commit layer changes too early.

Fix this by having the layerSyncRunLoopObserver in WebView check to see if a display is pending,
and not commit layer changes in that case. We'll commit layer changes later when we
finally draw.

  1. The change in r49269 was wrong; it was attempting to fix an issue that was actually caused by -drawRects: coming in for page snapshots. The correct approach is to avoid hitting the synchronization and update disabling code in WebHTMLView for draws that are not to the screen.
  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
  • WebView/WebView.mm: (layerSyncRunLoopObserverCallBack): (-[WebView _scheduleCompositingLayerSync]):
4:42 PM Changeset in webkit [58622] by cmarrin@apple.com
  • 3 edits
    3 adds in trunk

Enabled accelerated compositing in DRT for Windows
https://bugs.webkit.org/show_bug.cgi?id=38404

4:30 PM Changeset in webkit [58621] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

Unreviewed, build fix.

[Chromium] Added a simple IdentifierRep struct and removed dependency on
IdentifierRep.h.

  • bindings/v8/V8NPObject.cpp: Added simple IdentifierRep struct.
4:30 PM Changeset in webkit [58620] by Dimitri Glazkov
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed, expectations update.

[Chromium] More missing pixel test results.

  • platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/svg-as-border-image-expected.checksum: Added.
  • platform/chromium/test_expectations.txt:
4:25 PM Changeset in webkit [58619] by jamesr@google.com
  • 2 edits
    27 adds in trunk/LayoutTests

2010-04-30 James Robinson <jamesr@chromium.org>

Unreviewed. Add Chromium expectations for a bunch of repaint tests that we now pass (yay!)

  • platform/chromium-linux/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/chromium-linux/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-linux/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
  • platform/chromium-linux/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
  • platform/chromium-win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
  • platform/chromium-win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
  • platform/chromium-win/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-win/fast/repaint/fixed-move-after-scroll-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:06 PM Changeset in webkit [58618] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Fix for https://bugs.webkit.org/show_bug.cgi?id=38406
Add support for sending messages with a size greater than 4096 bytes

Reviewed by Anders Carlsson.

Adds support by putting message bodies that are larger than 4096 bytes
in OOL memory.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::dispatchMessages):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::OutgoingMessage::OutgoingMessage):
(CoreIPC::Connection::OutgoingMessage::messageID):
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):

  • Platform/CoreIPC/MessageID.h:

(CoreIPC::MessageID::):
(CoreIPC::MessageID::MessageID):
(CoreIPC::MessageID::equalIgnoringFlags):
(CoreIPC::MessageID::copyAddingFlags):
(CoreIPC::MessageID::fromInt):
(CoreIPC::MessageID::toInt):
(CoreIPC::MessageID::isMessageBodyOOL):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createArgumentDecoder):

4:00 PM Changeset in webkit [58617] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

Unreviewed, build fix.

[Chromium] Remove bridge/ from include paths.

  • WebCore.gyp/WebCore.gyp: Removed bridge/ from include path.
3:54 PM Changeset in webkit [58616] by ddkilzer@apple.com
  • 5 edits
    3 adds in trunk

WebCore: Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
Eliminated unused m_dragInitiator accessor to prevent dereferencing.
https://bugs.webkit.org/show_bug.cgi?id=37618

Patch by Abhishek Arya <inferno@chromium.org> on 2010-04-30
Reviewed by David Kilzer.

Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

  • page/DragController.cpp:

(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):

  • page/DragController.h:

(WebCore::DragController::draggingImageURL):
(WebCore::DragController::documentUnderMouse):

LayoutTests: Tests for a crash when an image drag-drop operation happens inside a continuously refreshing iframe.
https://bugs.webkit.org/show_bug.cgi?id=37618

Patch by Abhishek Arya <inferno@chromium.org> on 2010-04-30
Reviewed by David Kilzer.

  • editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Added.
  • editing/pasteboard/drag-drop-iframe-refresh-crash.html: Added.
  • editing/resources/drag-drop.html: Added.
  • platform/qt/Skipped:
3:26 PM Changeset in webkit [58615] by jamesr@google.com
  • 5 edits
    5 adds in trunk

2010-04-29 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Calls FrameView::scrollPositionChanged whenever a ScrollView is scrolled
https://bugs.webkit.org/show_bug.cgi?id=38286

When a ScrollView's scroll position is changed, we have to call
FrameView::scrollPositionChanged to generate repaint invalidation for
fixed position elements. This ends up getting called indirectly when
the ScrollView has a platformWidget through the port layer
(see WebHTMLView.mm's _frameOrBoundsChanged method for how the mac
port does it) but not when there is no platformWidget.

This is tested by the fast/repaint/fixed-* tests when run in pixel
mode.

Test: fast/repaint/fixed-move-after-keyboard-scroll.html

  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::valueChanged):
  • platform/ScrollView.h: (WebCore::ScrollView::scrollPositionChanged):
3:22 PM Changeset in webkit [58614] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Part of the previous part (forgot to save).

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView stopTimers]):
(-[WebNetscapePluginView startTimers]):
(-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
(-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
(-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]):
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
(-[WebNetscapePluginView unscheduleTimer:]):
(-[WebNetscapePluginView getVariable:forURL:value:length:]):
(-[WebNetscapePluginView setVariable:forURL:value:length:]):

3:20 PM Changeset in webkit [58613] by andersca@apple.com
  • 5 edits in trunk

Use C99 integer types in more places.

Reviewed by Darin Adler.

WebCore:

  • manual-tests/NPN_Invoke/main.c:

(NPP_New):
(NPP_NewStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_HandleEvent):
(functionPointerForTVector):

  • plugins/mac/PluginViewMac.cpp:

(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::handlePostReadFile):

WebKit/mac:

  • Plugins/WebNetscapePluginView.mm:

(getNPRect):

3:18 PM Changeset in webkit [58612] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, expectations update.

[Chromium] Add more missing pixel results.

  • platform/chromium-win/transforms/svg-vs-css-expected.checksum: Added.
  • platform/chromium-win/transforms/svg-vs-css-expected.png: Added.
3:03 PM Changeset in webkit [58611] by Darin Adler
  • 4 edits in trunk/WebCore

2010-04-30 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Remove unused scrollRectIntoViewRecursively function
https://bugs.webkit.org/show_bug.cgi?id=38403

  • page/Chrome.cpp: (WebCore::Chrome::scrollRectIntoView): Moved comment here that was previously in the scrollRectIntoViewRecursively function.
  • platform/ScrollView.cpp: Get rid scrollRectIntoViewRecursively.
  • platform/ScrollView.h: Ditto. Fix comment that refers to the two functions. Also correct all uses of the term "method" to use the C++ term "function" and got rid of double spaces after periods.
2:59 PM Changeset in webkit [58610] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

Fix Tiger build.

  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm:

(WebNetscapePluginStream::startStream):

2:42 PM Changeset in webkit [58609] by andersca@apple.com
  • 2 edits in trunk/WebCore

Another Qt build fix.

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::platformGetValueStatic):

2:35 PM Changeset in webkit [58608] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Another 32-bit build fix.

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):

2:34 PM Changeset in webkit [58607] by Dimitri Glazkov
  • 1 edit
    11 adds in trunk/LayoutTests

Unreviewed, expectations updated.

[Chromium] Add missing pixel results.

  • platform/chromium-linux/fast/borders/svg-as-border-image-2-expected.checksum: Added.
  • platform/chromium-linux/fast/borders/svg-as-border-image-expected.checksum: Added.
  • platform/chromium-linux/transforms/svg-vs-css-expected.checksum: Added.
  • platform/chromium-linux/transforms/svg-vs-css-expected.png: Added.
  • platform/chromium-mac/svg/custom/mask-changes-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/mask-changes-expected.png: Added.
  • platform/chromium-mac/transforms/svg-vs-css-expected.checksum: Added.
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.checksum: Added.
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png: Added.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum: Added.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.png: Added.
2:27 PM BuildingOnWindows edited by rls.webkit@schnapp.org
Clarification about CFNetwork.resources contents needed (diff)
2:23 PM Changeset in webkit [58606] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Try to fix GTK+ build.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:

(webkit_test_plugin_new_stream):

2:13 PM Changeset in webkit [58605] by andersca@apple.com
  • 2 edits in trunk/WebCore

Add back TRUE, FALSE and NULL macros. They were not meant to be removed!

  • bridge/npapi.h:
2:04 PM Changeset in webkit [58604] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

<http://webkit.org/b/38364> MIME typo in LayoutTests/http/tests/security/xss-DENIED-mime-type-execute-as-html.html

Reviewed by NOBODY (OOPS!).

  • http/tests/security/xss-DENIED-mime-type-execute-as-html.html:

Fixed MIME typo from "application-javascript" to
"application/javascript".

2:04 PM Changeset in webkit [58603] by andersca@apple.com
  • 2 edits in trunk/WebCore

Try to fix the Qt build this time.

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
(WebCore::PluginPackage::NPVersion):

2:03 PM Changeset in webkit [58602] by andersca@apple.com
  • 2 edits in trunk/WebCore

Yet another build fix.

  • plugins/gtk/PluginPackageGtk.cpp:

(WebCore::PluginPackage::NPVersion):

2:02 PM Changeset in webkit [58601] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

Fix 32-bit build (again).

  • Plugins/WebNetscapeContainerCheckContextInfo.h:
  • Plugins/WebNetscapeContainerCheckContextInfo.mm:

(-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
(-[WebNetscapeContainerCheckContextInfo checkRequestID]):
(-[WebNetscapeContainerCheckContextInfo callback]):

  • Plugins/WebNetscapePluginPackage.h:
1:55 PM Changeset in webkit [58600] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix build.

  • bridge/npapi.h:
1:50 PM Changeset in webkit [58599] by jianli@chromium.org
  • 7 edits
    1 add in trunk

[chromium] Add WebFileSystem interface and hook up with all FileSystem methods.
https://bugs.webkit.org/show_bug.cgi?id=38228

Reviewed by Darin Fisher.

WebCore:

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/FileSystemChromium.cpp:

(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):

WebKit/chromium:

  • WebKit.gyp:
  • public/WebFileSystem.h: Added.
  • public/WebKitClient.h:

(WebKit::WebKitClient::fileSystem):

  • src/ChromiumBridge.cpp:

(WebCore::ChromiumBridge::fileExists):
(WebCore::ChromiumBridge::deleteFile):
(WebCore::ChromiumBridge::deleteEmptyDirectory):
(WebCore::ChromiumBridge::getFileSize):
(WebCore::ChromiumBridge::getFileModificationTime):
(WebCore::ChromiumBridge::directoryName):
(WebCore::ChromiumBridge::pathByAppendingComponent):
(WebCore::ChromiumBridge::makeAllDirectories):
(WebCore::ChromiumBridge::getAbsolutePath):
(WebCore::ChromiumBridge::isDirectory):
(WebCore::ChromiumBridge::filePathToURL):
(WebCore::ChromiumBridge::openFile):
(WebCore::ChromiumBridge::closeFile):
(WebCore::ChromiumBridge::seekFile):
(WebCore::ChromiumBridge::truncateFile):
(WebCore::ChromiumBridge::readFromFile):
(WebCore::ChromiumBridge::writeToFile):

1:49 PM Changeset in webkit [58598] by andersca@apple.com
  • 2 edits in trunk/WebCore

2010-04-30 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Final part of


https://bugs.webkit.org/show_bug.cgi?id=20784
move npapi.h to C99 integer types

  • bridge/npapi.h: Remove the old types.
1:25 PM Changeset in webkit [58597] by eric@webkit.org
  • 15 edits
    8 deletes in trunk

2010-04-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r58569.
http://trac.webkit.org/changeset/58569
https://bugs.webkit.org/show_bug.cgi?id=38399

This broke the GTK bots due to bad GC behavior (Requested by
ericu on #webkit).

  • fast/workers/change-version-handle-reuse-worker-expected.txt: Removed.
  • fast/workers/change-version-handle-reuse-worker.html: Removed.
  • fast/workers/execute-sql-args-worker-expected.txt: Removed.
  • fast/workers/execute-sql-args-worker.html: Removed.
  • fast/workers/resources/database-worker-controller.js: Removed.
  • fast/workers/resources/database-worker.js: Removed.
  • storage/change-version-handle-reuse-expected.txt:
  • storage/change-version-handle-reuse.html:
  • storage/change-version-handle-reuse.js: Removed.
  • storage/execute-sql-args.html:
  • storage/execute-sql-args.js: Removed.

2010-04-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r58569.
http://trac.webkit.org/changeset/58569
https://bugs.webkit.org/show_bug.cgi?id=38399

This broke the GTK bots due to bad GC behavior (Requested by
ericu on #webkit).

  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
  • storage/Database.idl:
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::openDatabase):
  • workers/WorkerContext.h: (WebCore::WorkerContext::databaseExceededQuota):
  • workers/WorkerContext.idl:
1:11 PM Changeset in webkit [58596] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

Fix 32-bit build.

  • Plugins/WebNetscapeContainerCheckContextInfo.h:
  • Plugins/WebNetscapeContainerCheckContextInfo.mm:

(-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):

  • Plugins/WebNetscapeContainerCheckPrivate.h:
  • Plugins/WebNetscapePluginPackage.mm:

(functionPointerForTVector):

  • Plugins/WebNetscapePluginView.mm:

(PluginTimer::PluginTimer):
(-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):

12:36 PM Changeset in webkit [58595] by yaar@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-30 Yaar Schnitman <yaar@chromium.org>

Not Reviewed.

Updating expectations for svg-as-border-*
https://bugs.webkit.org/show_bug.cgi?id=38398

  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt: Added.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.txt: Added.
  • platform/chromium-win/transforms/svg-vs-css-expected.txt: Added.
12:25 PM Changeset in webkit [58594] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Not reviewed.

  • platform/mac-tiger/Skipped: Added two tests that fail on buidbot.
12:25 PM Changeset in webkit [58593] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix GTK+ build.

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::handlePostReadFile):
(WebCore::PluginView::platformGetValueStatic):

12:23 PM Changeset in webkit [58592] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Fix build.

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
12:18 PM Changeset in webkit [58591] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix Qt build.

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::handlePostReadFile):
(WebCore::PluginView::platformGetValue):

12:17 PM Changeset in webkit [58590] by andersca@apple.com
  • 22 edits in trunk

2010-04-30 Anders Carlsson <andersca@apple.com>

Reviewed by Timothy Hatcher.

Next step towards fixing


https://bugs.webkit.org/show_bug.cgi?id=20784
move npapi.h to C99 integer types

Use the C99 types everywhere. The "old" types are still around but will be removed
in a subsequent commit.

  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::deliverData):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebNetscapePluginView getAuthenticationInfoWithProtocol:host:port:scheme:realm:username:usernameLength:password:passwordLength:]):
  • Plugins/npapi.mm: (NPN_MemAlloc): (NPN_MemFlush): (NPN_PostURLNotify): (NPN_PostURL): (NPN_Write): (NPN_ScheduleTimer): (NPN_UnscheduleTimer): (NPN_GetValueForURL): (NPN_SetValueForURL): (NPN_GetAuthenticationInfo): (WKN_CheckIfAllowedToLoadURL): (WKN_CancelCheckIfAllowedToLoadURL):

2010-04-30 Anders Carlsson <andersca@apple.com>

Reviewed by Timothy Hatcher.

Next step towards fixing


https://bugs.webkit.org/show_bug.cgi?id=20784
move npapi.h to C99 integer types

Use the C99 types everywhere. The "old" types are still around but will be removed
in a subsequent commit.

  • bridge/npapi.h: (_NPCocoaEvent::):
  • plugins/PluginPackage.h:
  • plugins/PluginStream.cpp: (WebCore::PluginStream::deliverData):
  • plugins/PluginStream.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::postURLNotify): (WebCore::PluginView::postURL): (WebCore::PluginView::write): (WebCore::PluginView::handlePost):
  • plugins/PluginView.h:
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::handlePostReadFile):
  • plugins/npapi.cpp: (NPN_MemAlloc): (NPN_MemFlush): (NPN_PostURLNotify): (NPN_PostURL): (NPN_Write):
  • plugins/npfunctions.h:
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handlePostReadFile):

2010-04-30 Anders Carlsson <andersca@apple.com>

Reviewed by Timothy Hatcher.

Next step towards fixing


https://bugs.webkit.org/show_bug.cgi?id=20784
move npapi.h to C99 integer types

Use the C99 types everywhere. The "old" types are still around but will be removed
in a subsequent commit.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (int32VariantToIdentifier): (doubleVariantToIdentifier): (testIdentifierToInt): (testGetIntIdentifier):
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_NewStream): (NPP_WriteReady): (NPP_Write): (NPP_HandleEvent):
  • DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New): (NPP_NewStream): (NPP_WriteReady): (NPP_Write): (NPP_HandleEvent):
12:00 PM Changeset in webkit [58589] by pkasting@chromium.org
  • 9 edits in trunk/WebCore

Make all image decoders set the "failed" bit if an image could not be
completely decoded, but no more data is coming. The ICO and BMP
decoders already did this.
https://bugs.webkit.org/show_bug.cgi?id=35411

Reviewed by David Levin.

"Failed" does not cause the image to not be displayed, it simply causes
us to not bother to try to decode again if future requests are made, and
for some decoders, lets the decoder clean up some of its temporary
objects.

No layout tests because this does not change the visible output of decoding in any way.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::frameComplete): Return whether the frame could be marked as complete.
(WebCore::GIFImageDecoder::decode): Fail if read() needs more data (and thus returns false) and no more is coming.

  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::do_lzw): Instead of returning true for buffer underrun and false for failure, return false for both and set the failure flag on failure.
(GIFImageReader::read): Ditto.

  • platform/image-decoders/gif/GIFImageReader.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::):
(WebCore::JPEGImageReader::decode): See do_lzw() comment above.
(WebCore::JPEGImageDecoder::decode): Fail if decode() needs more data (and thus returns false) and no more is coming.

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::decode): Return true for decode success, false for buffer underrun or decode failure, and set the failure flag on decode failure.
(WebCore::PNGImageDecoder::decode): See JPEGImageDecoder::decode() comment above.

  • platform/image-decoders/png/PNGImageDecoder.h:
11:39 AM Changeset in webkit [58588] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot
https://bugs.webkit.org/show_bug.cgi?id=37334

  • platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframesets.html skipped until fix.
11:33 AM Changeset in webkit [58587] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Not reviewed.

Enable Sputnik tests on Tiger.

  • platform/mac-tiger/Skipped: Only skip tests that fail for me on Tiger/PPC, and Unicode tests.
11:24 AM Changeset in webkit [58586] by beidson@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/7902467> - Audio plays upon loading of npr.org but shouldn't

Reviewed by Eric Carlson.

No new tests. (Currently no way to test such site specific hack behavior)

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::asyncEventTimerFired): If the event to be dispatched is the canplay

event, wrap the dispatch with m_dispatchingCanPlayEvent set.

(WebCore::HTMLMediaElement::play): If m_dispatchingCanPlayEvent is true and the site is npr.org,

don't perform the play().

  • html/HTMLMediaElement.h: Add m_dispatchingCanPlayEvent member.
10:50 AM Changeset in webkit [58585] by mitz@apple.com
  • 9 edits in trunk

WebCore: Part of <rdar://problem/6649734> Text repainting does not account for glyphs which draw outside the typographic bounds of the font
https://bugs.webkit.org/show_bug.cgi?id=6274

Reviewed by Adele Peterson.

Account for glyph overflow of characters in the range U+1E00..U+2000, but without sending them
through the complex text code path. Instead, introduce a variant of the fast path that tracks
glyph overflow.

  • platform/graphics/Font.cpp:

(WebCore::Font::drawText): Use codePath().
(WebCore::Font::floatWidth): Use codePath(). Pass the GlyphOverflow pointer through to
floatWidthForSimpleText() if the code path is SimpleWithGlyphOverflow.
(WebCore::Font::selectionRectForText): Use codePath().
(WebCore::Font::offsetForPosition): Ditto.

  • platform/graphics/Font.h: Replaced canUseGlyphCache() with codePath(). Added a GlyphOverflow

parameter to floatWidthForSimpleText().

  • platform/graphics/FontFastPath.cpp:

Removed ROMAN_AND_GREEK_DIACRITICS_CAN_USE_GLYPH_CACHE.
(WebCore::Font::codePath): Renamed canUseGlyphCache() to this. Where it used to return false,
it now returns Complex. Where it used to return true, it now returns Simple, except for
the range U+1E00..U+2000, where it now returns SimpleWithGlyphOverflow.
(WebCore::Font::floatWidthForSimpleText): Added a GlyphOverflow parameter. If not 0, have the
width iterator account for glyph bounds, then update the GlyphOverflow accordingly.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Added boolean parameter telling the width iterator
whether to account for glyph bounds. Initialize m_accountForGlyphBounds accordingly. Initialize
m_maxGlyphBoundingBoxY, m_minGlyphBoundingBoxY, m_firstGlyphOverflow and m_lastGlyphOverflow.
(WebCore::WidthIterator::advance): If accounting for glyph bounds, update the above member variables.

  • platform/graphics/WidthIterator.h:

(WebCore::WidthIterator::maxGlyphBoundingBoxY): Added this accessor.
(WebCore::WidthIterator::minGlyphBoundingBoxY): Ditto.
(WebCore::WidthIterator::firstGlyphOverflow): Ditto.
(WebCore::WidthIterator::lastGlyphOverflow): Ditto.

LayoutTests: Updated results for <rdar://problem/6649734> Text repainting does not account for glyphs which draw outside the typographic bounds of the font
https://bugs.webkit.org/show_bug.cgi?id=6274

Reviewed by Adele Peterson.

  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
  • platform/mac/fast/repaint/stacked-diacritics-expected.png:
10:23 AM Changeset in webkit [58584] by cmarrin@apple.com
  • 10 edits
    4 adds in trunk

2010-04-30 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Reversed the order of the CSSMatrix.multiply method
https://bugs.webkit.org/show_bug.cgi?id=38337

  • css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::multiply):
  • platform/graphics/transforms/TransformationMatrix.cpp:

These are the existing tests for 2D and 3D CSSMatrix and SVGMatrix.
I've added tests missing between the two styles and now do tests
that confirm that SVGMatrix and CSSMatrix both multiply the same.

This also adds a new test from Simon which compares SVG to CSS matrixes.
This is a pixel test for mac only.

  • platform/mac/transforms/svg-vs-css-expected.checksum: Added.
  • platform/mac/transforms/svg-vs-css-expected.png: Added.
  • platform/mac/transforms/svg-vs-css-expected.txt: Added.
  • svg/dom/SVGMatrix-interface-expected.txt:
  • svg/dom/SVGMatrix-interface.xhtml:
  • transforms/cssmatrix-2d-interface-expected.txt:
  • transforms/cssmatrix-2d-interface.xhtml:
  • transforms/cssmatrix-3d-interface-expected.txt:
  • transforms/cssmatrix-3d-interface.xhtml:
  • transforms/svg-vs-css.xhtml: Added.
9:56 AM Changeset in webkit [58583] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed. Attempt to fix the Chromium Mac build after the last commit.

9:35 AM Changeset in webkit [58582] by Dimitri Glazkov
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed, expectations update.

[Chromium] Provide expectations for svg/custom/repaint-stroke-width-changes.svg,
which was added in http://trac.webkit.org/changeset/58570/.

  • platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/repaint-stroke-width-changes-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/repaint-stroke-width-changes-expected.png: Added.
  • platform/chromium-win/svg/custom/repaint-stroke-width-changes-expected.checksum: Added.
  • platform/chromium-win/svg/custom/repaint-stroke-width-changes-expected.png: Added.
9:33 AM Changeset in webkit [58581] by kevino@webkit.org
  • 3 edits
    2 copies in trunk/WebCore

Reviewed by Dan Bernstein.

Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac.
https://bugs.webkit.org/show_bug.cgi?id=38334

9:09 AM Changeset in webkit [58580] by Simon Fraser
  • 9 edits
    4 adds
    8 deletes in trunk/LayoutTests

2010-04-30 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Update image results for SVG as CSS border image tests
https://bugs.webkit.org/show_bug.cgi?id=37028

Improve the tests for SVG in border image to use an image that is not a solid color,
and by adding comparison elements with PNG-based borders.

Remove unused "green rect" SVG files.

Update Mac pixel results, and remove Chromium pixel results with the expectation
that someone will commit new ones.

  • fast/borders/resources/green-fixed-size-rect.svg: Removed.
  • fast/borders/resources/green-relative-size-rect.svg: Removed.
  • fast/borders/resources/large-tiles.png: Added.
  • fast/borders/resources/tiles-fixed-size.svg: Added.
  • fast/borders/resources/tiles-relative-size.svg: Added.
  • fast/borders/resources/tiles.png: Added.
  • fast/borders/svg-as-border-image-2.html:
  • fast/borders/svg-as-border-image.html:
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.txt: Removed.
  • platform/mac/fast/borders/svg-as-border-image-2-expected.checksum:
  • platform/mac/fast/borders/svg-as-border-image-2-expected.png:
  • platform/mac/fast/borders/svg-as-border-image-2-expected.txt:
  • platform/mac/fast/borders/svg-as-border-image-expected.checksum:
  • platform/mac/fast/borders/svg-as-border-image-expected.png:
  • platform/mac/fast/borders/svg-as-border-image-expected.txt:
8:53 AM Changeset in webkit [58579] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations tweak.

[Chromium] Defer Sputnik tests.

  • platform/chromium/test_expectations.txt: Tagged fast/js/sputnik with DEFER.
8:46 AM Changeset in webkit [58578] by hamaji@chromium.org
  • 3 edits
    2 adds in trunk

2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Simon Fraser.

SHOULD NEVER BE REACHED assertion loading forbes.com
https://bugs.webkit.org/show_bug.cgi?id=38272

  • printing/pseudo-class-outside-page-expected.txt: Added.
  • printing/pseudo-class-outside-page.html: Added.

2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Simon Fraser.

SHOULD NEVER BE REACHED assertion loading forbes.com
https://bugs.webkit.org/show_bug.cgi?id=38272

Ignore page media related pseudo classes.

Test: printing/pseudo-class-outside-page.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
8:39 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
8:22 AM Changeset in webkit [58577] by steveblock@google.com
  • 2 edits in trunk/WebKitTools

Changed Steve Block from committer to reviewer.

8:11 AM Changeset in webkit [58576] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. While I'm at it: Update prototype-inheritance-2-expected.txt result, it's failing since CSSPageRule has been introduced.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
8:08 AM Changeset in webkit [58575] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Windows fails on svg/custom/mask-changes.svg. Trying to fix the test which is really flawed. Shows a DRT difference between Mac/Win.

  • svg/custom/mask-changes.svg:
8:08 AM WebKit Team edited by steveblock@google.com
(diff)
6:34 AM Changeset in webkit [58574] by jorlow@chromium.org
  • 3 edits in trunk/LayoutTests

2010-04-30 Jeremy Orlow <jorlow@chromium.org>

Unreviewed. Fixing a missed test from https://bugs.webkit.org/show_bug.cgi?id=38331

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
6:31 AM Changeset in webkit [58573] by Laszlo Gombos
  • 2 edits in trunk/WebCore

2010-04-30 Laszlo Gombos <Laszlo Gombos>

Unreviewed, build fix.

Fix compiler warning "suggest parentheses around"

No new tests as there is no new functionality.

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues):
4:49 AM Changeset in webkit [58572] by tkent@chromium.org
  • 4 edits in trunk

WebCore: Unreviewed. Regression fix.

Revert a part of r58564 to be compatible with prior behavior
https://bugs.webkit.org/show_bug.cgi?id=38383

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::forwardEvent):

r58564 made a region check for the cancel button stricter, but it
made some tests failing on Chromium. So, relax the check again.

LayoutTests: Unreviewed.

Revert a part of r58564 to be compatible with prior behavior
https://bugs.webkit.org/show_bug.cgi?id=38383

  • platform/chromium/test_expectations.txt: Remove expectations added by r58568.
4:26 AM Changeset in webkit [58571] by jorlow@chromium.org
  • 11 edits in trunk

2010-04-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Change StorageEvent.uri to StorageEvent.url to match the spec
https://bugs.webkit.org/show_bug.cgi?id=38331

Change the existing tests to test 'url' rather than 'uri'.

  • storage/domstorage/events/documentURI-expected.txt:
  • storage/domstorage/events/script-tests/documentURI.js: (step2): (step3):
  • storage/domstorage/localstorage/resources/iframe-events-second.html:
  • storage/domstorage/sessionstorage/resources/iframe-events-second.html:

2010-04-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Change StorageEvent.uri to StorageEvent.url to match the spec
https://bugs.webkit.org/show_bug.cgi?id=38331

As I mentioned in http://www.mail-archive.com/public-webapps@w3.org/msg08495.html
WebKit is the only one who places the document's URL in a 'uri' property
rather than a 'url' property. Even though we've shipped several versions of
browsers with the old name, we probably should change this to comply with the
spec.

This stuff is covered by existing tests.

  • storage/StorageEvent.cpp: (WebCore::StorageEvent::create): (WebCore::StorageEvent::StorageEvent): (WebCore::StorageEvent::initStorageEvent):
  • storage/StorageEvent.h: (WebCore::StorageEvent::url):
  • storage/StorageEvent.idl:

2010-04-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Change StorageEvent.uri to StorageEvent.url to match the spec
https://bugs.webkit.org/show_bug.cgi?id=38331

Get rid of a stale FIXME and combine 2 lines that needn't be split.

  • src/StorageEventDispatcherImpl.cpp: (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent):
4:22 AM Changeset in webkit [58570] by Nikolas Zimmermann
  • 19 edits
    4 adds in trunk

2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed
https://bugs.webkit.org/show_bug.cgi?id=38385

The last SVG performance patch broke repainting if bounds of a RenderPath get smaller.
It would only repaint the smaller part, not the original larger bounds.

Remove all lazy calculation of the repaint rects, instead calculate object/strokeBoundingBox and repaintRectInLocalCoordinates
once in layout - after LayoutRepainter grabbed the initial bounds, before calling repaintAfterLayout(). We can now inline
all these functions, and save a lot of m_path.isEmpty() checks, which are expensive. No need to store a seperated markerBoundingBox(),
combine with strokeBoundingBox() -> save one FloatRect per RenderPath. Move strokeBoundingBox() from SVGRenderBase to RenderObject,
right next to objectBoundingBox() - to save unnecessary toSVGRenderBase() calls. Completly remove this method.

Overall this is a regression fix, a performance improvement and saves memory. Something for everyone.

Tests: svg/custom/repaint-stroke-width-changes.svg

  • rendering/RenderObject.cpp: Added strokeBoundingBox() here, to avoid the toSVGRenderBase() dance. (WebCore::RenderObject::strokeBoundingBox):
  • rendering/RenderObject.h: Ditto.
  • rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath): (WebCore::RenderPath::layout): Fix regression, do repainting correctly, by recalculating the boundaries, if needed, instead of nulling them. (WebCore::RenderPath::paint): Cache SVGRenderStyle in local variable, remove no longer valid FIXME. (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Return a FloatRect, to avoid having to store the marker bounding box seperated. (WebCore::RenderPath::styleWillChange): Mark boundaries as dirty. (WebCore::RenderPath::updateCachedBoundaries): New function to (re-)calculate all cached boundaries, only called from layout().
  • rendering/RenderPath.h: Rename cached rect variables to have more sensible names. (WebCore::RenderPath::objectBoundingBox): Inlined, just returns the cached value - no more lazy creation. Huge speedup as this is hot code. (WebCore::RenderPath::strokeBoundingBox): Ditto. (WebCore::RenderPath::repaintRectInLocalCoordinates): Ditto.
  • rendering/RenderSVGBlock.h: Remove toSVGRenderBase() method.
  • rendering/RenderSVGImage.h: Ditto.
  • rendering/RenderSVGInline.cpp: No need to call toSVGRenderBase() just to get the strokeBoundingBox(). Unifies code to retrieve bounding boxes. (WebCore::RenderSVGInline::strokeBoundingBox):
  • rendering/RenderSVGInline.h: Remove toSVGRenderBase() method.
  • rendering/RenderSVGModelObject.h: Ditto.
  • rendering/RenderSVGResourceFilter.cpp: No need to call toSVGRenderBase() anymore, just grab the strokeBoundingBox() from the RenderObject. (WebCore::RenderSVGResourceFilter::applyResource):
  • rendering/RenderSVGText.h: Remove toSVGRenderBase() method.
  • rendering/SVGRenderSupport.h: Ditto. Remove markerBoundingBox() method, now combined with strokeBoundingBox(). (WebCore::SVGRenderBase::strokeBoundingBox):
  • rendering/SVGRootInlineBox.h: Remove toSVGRenderBase() method.
  • rendering/style/SVGRenderStyle.h: Add hasMarkers() helper method, to avoid doing unnecessary work in RenderPath. (WebCore::SVGRenderStyle::hasMarkers):

2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed
https://bugs.webkit.org/show_bug.cgi?id=38385

Add new test covering the repaint problem. Influences some marker results, that can be safely ignored.

  • platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
  • platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
  • platform/mac/svg/custom/repaint-stroke-width-changes-expected.checksum: Added.
  • platform/mac/svg/custom/repaint-stroke-width-changes-expected.png: Added.
  • platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt: Added.
  • svg/custom/repaint-stroke-width-changes.svg: Added.
4:11 AM Changeset in webkit [58569] by eric@webkit.org
  • 15 edits
    3 copies
    5 adds in trunk

2010-04-30 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
https://bugs.webkit.org/show_bug.cgi?id=34992

  • storage/change-version-handle-reuse.html: Refactored to share code with the worker version of the test.
  • storage/change-version-handle-reuse-expected.html: Removed reference to reloading, which this test doesn't do.
  • storage/change-version-handle-reuse.js: This is the extracted shared core of the test.
  • storage/execute-sql-args.html: Refactored to share code with the worker version of the test.
  • storage/execute-sql-args.js: This is the extracted shared core of the test.

These are the worker versions of the tests; they're tiny shims around shared code.

  • fast/workers/execute-sql-args-worker-expected.txt: Added.
  • fast/workers/execute-sql-args-worker.html: Added.
  • fast/workers/change-version-handle-reuse-worker-expected.txt: Added.
  • fast/workers/change-version-handle-reuse-worker.html: Added. This file gets included from worker database tests; it does all the boilerplate that's needed on the DOM side.
  • fast/workers/resources/database-worker-controller.js: Added. This file is the boilerplate for the worker side of the database tests. It will import and run the actual test on command, and will report back completion and exceptions.
  • fast/workers/resources/database-worker.js: Added.

2010-04-30 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
https://bugs.webkit.org/show_bug.cgi?id=34992

Tests: storage/change-version-handle-reuse-worker.html

storage/execute-sql-args-worker.html

  • bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding. (WebCore::JSWorkerContext::openDatabase):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there. (WebCore::V8WorkerContext::openDatabaseCallback):

Add NoStaticTables flags to all objects now shared with workers.

  • storage/Database.idl:
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • workers/WorkerContext.h: Add databaseExceededQuota.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now. (WebCore::WorkerContext::openDatabase): Remove invalid assertion.

Add the IDL for the call to openDatabase.

  • workers/WorkerContext.idl:
3:06 AM Changeset in webkit [58568] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewd, update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=38383

Start failing after WebKit r58563:r58565

  • fast/forms/search-abs-pos-cancel-button.html
  • fast/forms/search-cancel-button-mouseup.html
  • fast/forms/search-rtl.html
  • fast/forms/search-zoomed.html
  • platform/chromium/test_expectations.txt:
2:24 AM Changeset in webkit [58567] by tkent@chromium.org
  • 2 edits in trunk

Unreviewed. Fix wrong bug numbers in ChangeLogs for r58564.

2:14 AM Changeset in webkit [58566] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Unnecessary PrintContext::end() calls
https://bugs.webkit.org/show_bug.cgi?id=38247

Refactoring only, so no new tests.

  • page/PrintContext.cpp: (WebCore::PrintContext::pageNumberForElement): (WebCore::PrintContext::numberOfPages):
1:48 AM Changeset in webkit [58565] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewd, test expectations cleanup.

media/video-empty-source.html passes since r58480:r58515 (win), r58489 (linux), r58488:458490 (mac)
fast/backround/svg-as-background-6.html passes since r58488:r58490 (mac)
fast/repaint/caret-outside-block.html passes since r58414:r58415 (mac)
fast/replaced/border-radius-clip.html passes since r58543 (win, linux)
fast/images/svg-as-tiled-background.html passes r58488:r58490 (mac)
fast/text/line-breaks.html passes since r58480:r58515 (win)
fast/backgrounds/svg-as-background-2.html passes since r58480:r58515 (win), r58489 (linux), r58488:r58490 (mac)

  • platform/chromium/test_expectations.txt:
1:45 AM Changeset in webkit [58564] by tkent@chromium.org
  • 13 edits
    2 adds in trunk

Implement interactive behavior of spin buttons.
https://bugs.webkit.org/show_bug.cgi?id=27968

Reviewed by Adele Peterson.

WebCore:

Introduce SpinButtonElement. It is a shadow element class for
spin buttons. If the upper side of the element is clicked, calls
HTMLInputElement::stepUpFromRenderer(1). If the lower button is
clicked, calls HTMLInputElement::stepUpFromRenderer(-1).

SpinButtonElement tracks the mouse pointer position, and
RenderTheme sets ControlStates::SpinUpState if the pointer is on
the upper side.

Test: platform/mac/fast/forms/input-number-click.html

  • dom/Element.h:

(WebCore::Element::isSpinButtonElement):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):

Remove an assertion. lastEditablePositionBeforePositionInRoot() can
return null in a case that m_end is at a shadow element (a spin button)
and baseRoot is another shadow element (inner text block) in the same
node (an INPUT element).

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::stepUpFromRenderer):

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::hasSpinButton):

Add types supporting step attribute except RANGE.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::forwardEvent):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):

  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::controlStatesForRenderer):
(WebCore::RenderTheme::isSpinUpButtonPartPressed):
(WebCore::RenderTheme::isSpinUpButtonPartHovered):

  • rendering/RenderTheme.h:
  • rendering/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::defaultEventHandler):

  • rendering/TextControlInnerElements.h:

(WebCore::SpinButtonElement::isSpinButtonElement):
(WebCore::SpinButtonElement::isEnabledFormControl):
(WebCore::SpinButtonElement::onUpButton):

LayoutTests:

  • platform/mac/fast/forms/input-number-click-expected.txt: Added.
  • platform/mac/fast/forms/input-number-click.html: Added.
1:41 AM Changeset in webkit [58563] by eric@webkit.org
  • 7 edits in trunk

2010-04-30 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable DOMWindow constructor for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=38333

Update expected test results after this change

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:

2010-04-30 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable DOMWindow constructor for HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=38333

Add ENABLE_PROGRESS_TAG to FEATURES_DEFINES_JAVASCRIPT.

  • WebCore.pri:
12:56 AM Changeset in webkit [58562] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

2010-04-29 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add codegen support for unsigned right shift
https://bugs.webkit.org/show_bug.cgi?id=38375

Expose unsigned right shift in the macro assembler, and make use of it
from the jit. Currently if the result is outside the range 0..231-1
we simply fall back to the slow case, even in JSVALUE64 and JSVALUE32_64
where technically we could still return an immediate value.

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::urshift32):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::urshift32):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::urshift32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::shrl_i8r): (JSC::X86Assembler::shrl_CLr):

Add unsigned right shift to the x86 assembler

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):

op_rshift no longer simply get thrown to a stub function

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_urshift): (JSC::JIT::emitSlow_op_urshift): JSVALUE32 and JSVALUE64 implementation. Only supports double lhs in JSVALUE64.
  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emit_op_urshift): (JSC::JIT::emitSlow_op_urshift): Refactor right shift code to have shared implementation between signed and unsigned versions.
12:45 AM Changeset in webkit [58561] by tkent@chromium.org
  • 10 edits
    6 adds in trunk

2010-04-30 Kent Tamura <tkent@chromium.org>

Reviewed by Adele Peterson.

Mac implementation of outer-spin-button appearance, and anonymous
element generation for <input type=number>.
https://bugs.webkit.org/show_bug.cgi?id=32813

input-appearance-spinbutton.html checks the appearances of various
sizes of spin-buttons. input-appearance-spinbutton-size.html
checks a spin-button height is equal to or less than the
corresponding text field height.

  • platform/mac/fast/forms/input-appearance-spinbutton-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-size-expected.txt: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-size.html: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton.html: Added.

2010-04-30 Kent Tamura <tkent@chromium.org>

Reviewed by Adele Peterson.

Mac implementation of outer-spin-button appearance, and anonymous
element generation for <input type=number>.
https://bugs.webkit.org/show_bug.cgi?id=32813

The implementation uses NSStepperCell. Like the other Mac
controls, it has only three candidates for sizes.

The editable block of an input element is shrunk, and the
anonymous block for a spin button is put on the right of the
editable block.

Tests: platform/mac/fast/forms/input-appearance-spinbutton-size.html

platform/mac/fast/forms/input-appearance-spinbutton.html

  • dom/Element.cpp: (WebCore::Element::pseudoStyleCacheIsInvalid):
  • dom/InputElement.h: (WebCore::InputElement::hasSpinButton):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::hasSpinButton): Return true for NUMBER type.
  • platform/mac/ThemeMac.mm: (WebCore::sizeFromNSControlSize): Split the main part of sizeFromFont() to this in order to use stepperControlSizeForFont() instead of controlSizeForFont(). (WebCore::sizeFromFont): Just calls sizeFromNSControlSize() with sizeFromFont(). No behavior changes. (WebCore::stepperSizes): Returns sizes for mini, small, and regular. (WebCore::stepperControlSizeForFont): Dedicated version of controlSizeForFont(). (WebCore::stepper): Returns NSStepperCell object with specified settings. (WebCore::paintStepper): (WebCore::ThemeMac::controlSize): Support for OuterSpinButton. (WebCore::ThemeMac::minimumControlSize): ditto. (WebCore::ThemeMac::inflateControlPaintRect): ditto. (WebCore::ThemeMac::paint): ditto.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Move the content to paintBoxDecorationsWithSize(). (WebCore::RenderBox::paintBoxDecorationsWithSize):
  • rendering/RenderBox.h: Declare paintBoxDecorationsWithSize().
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::paintBoxDecorations): Call paintBoxDecorationsWithSize() with smaller width by decorationWidthRight(). (WebCore::RenderTextControlSingleLine::addFocusRingRects): Add a rectangle of which width is smaller by decorationWidthRight(). (WebCore::RenderTextControlSingleLine::layout): Adjust m_outerSpinButton position. (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::decorationWidthRight): (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): Creates an element for m_outerSpinButton if it is needed. (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
  • rendering/RenderTextControlSingleLine.h: Declare new methods and m_outerSpinButton.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): Support for OuterSpinButton.

Apr 29, 2010:

11:46 PM Changeset in webkit [58560] by tkent@chromium.org
  • 3 edits
    2 deletes in trunk/WebCore

Unreviewed. Roll out r58557. Compile failures on Tiger, Leopard, and Chromium/Mac.

11:26 PM Changeset in webkit [58559] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip media/media-document-audio-size.html on Windows too.

11:20 PM Changeset in webkit [58558] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed.

Add media/media-document-audio-size.html to Skipped lists.
https://bugs.webkit.org/show_bug.cgi?id=38376

  • platform/gtk/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/qt/Skipped:
11:13 PM Changeset in webkit [58557] by kevino@webkit.org
  • 3 edits
    2 copies in trunk/WebCore

Reviewed by Dan Bernstein.

Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac.
https://bugs.webkit.org/show_bug.cgi?id=38334

8:06 PM WebKit Team edited by collinj@webkit.org
(diff)
7:54 PM Changeset in webkit [58556] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-04-29 James Robinson <jamesr@chromium.org>

Unreviewed, fix chromium linux test expectations.

  • platform/chromium/test_expectations.txt:
7:49 PM Changeset in webkit [58555] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-04-29 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Handle double on righthand side of a right shift
https://bugs.webkit.org/show_bug.cgi?id=38363

In 64-bit we support right shift of a double, and there's no
reason not to in 32-bit either. This is a 1.1% sunspider
improvement in 32bit.

Given high performance javascript code frequently makes
use of bit operators to perform double->int conversion i'll
follow this patch up with similar patches for bitwise 'and'
and 'or'.

  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift):
7:31 PM Changeset in webkit [58554] by jamesr@google.com
  • 8 edits in trunk/LayoutTests

2010-04-29 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Update Chromium test expectations and add new SVG baselines
https://bugs.webkit.org/show_bug.cgi?id=38345

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/chromium/test_expectations.txt:
6:58 PM BuildingOnWindows edited by rls.webkit@schnapp.org
Document hard-won info on getting file: scheme to work (diff)
6:57 PM BuildingOnWindows edited by rls.webkit@schnapp.org
(diff)
6:56 PM BuildingOnWindows edited by rls.webkit@schnapp.org
(diff)
6:52 PM Changeset in webkit [58553] by yaar@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-29 Yaar Schnitman <yaar@chromium.org>

Not Reviewed.

Updated expectations for 2 more tests on mac:
svg/custom/dominant-baseline-hanging.svg
fast/replaced/border-radius-clip.html


https://bugs.webkit.org/show_bug.cgi?id=38365

  • platform/chromium/test_expectations.txt:
5:52 PM Changeset in webkit [58552] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-29 Adam Barth <abarth@webkit.org>

Unreviewed. Update JSC CodeGenerator baseline. Not sure how I missed
this one earlier.

  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionSerializedValue):
5:21 PM Changeset in webkit [58551] by justin.garcia@apple.com
  • 4 edits in trunk/WebCore

Need to updateLayout after typing commands too
https://bugs.webkit.org/show_bug.cgi?id=38352

Reviewed by Adele Peterson.

Replaced !m_parent checks in EditCommand.cpp by the more descriptive isTopLevelCommand().
Move the post editing operation updateLayout() call to {un,re}appliedEditing so that text insertions,
which don't go through EditCommand::{un,re}apply() can benefit from it too. No test case possible
since most platforms have a layout performed as a side effect of post operation selection code.

  • editing/EditCommand.cpp:

(WebCore::EditCommand::apply):
(WebCore::EditCommand::unapply):
(WebCore::EditCommand::reapply):

  • editing/EditCommand.h:

(WebCore::EditCommand::isTopLevelCommand):

  • editing/Editor.cpp:

(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):

4:57 PM Changeset in webkit [58550] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Not reviewed.

  • platform/mac-tiger/Skipped: Accidentally committed with a commented out line.
4:40 PM Changeset in webkit [58549] by yaar@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-29 Yaar Schnitman <yaar@chromium.org>

Not Reviewed.

Added two new timeout expectations media/audio-only-video-intrinsic-size.html, media/media-document-audio-size.html which started failing after r58543.
https://bugs.webkit.org/show_bug.cgi?id=38362

  • platform/chromium/test_expectations.txt:
4:37 PM Changeset in webkit [58548] by ap@apple.com
  • 6 edits
    23 adds in trunk/LayoutTests

Re-enable Sputnik tests on Leopard and Snow Leopard.

  • fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Applying_the_percent_Operator/S11.5.3_A4_T2-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.1_T3-expected.txt: Changed expectation to PASS.
  • platform/mac-snowleopard/Skipped: Skip the above tests, since they fail in 64 bit, and DRT may run 64 bit on Snow Leopard.
  • platform/mac-leopard/fast/js: Added.
  • platform/mac-leopard/fast/js/sputnik: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Added.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Added. Added platform specific results for tests that depend on supported Unicode version.
  • platform/mac-tiger/Skipped: Skipped Sputnik on Tiger.
  • platform/mac/Skipped: Unskipped Sputnik.
4:28 PM Changeset in webkit [58547] by yaar@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-29 Yaar Schnitman <yaar@chromium.org>

Not Reviewed.

Skipping layout tests with bad/missing expectations.
https://bugs.webkit.org/show_bug.cgi?id=38361

  • platform/chromium/test_expectations.txt:
4:18 PM Changeset in webkit [58546] by ap@apple.com
  • 1 edit
    47 moves in trunk/LayoutTests

Not reviewed.

Trying to fix Windows checkout by shortening more paths in Sputnik tests.

  • fast/js/sputnik: Many directories renamed.
4:07 PM Changeset in webkit [58545] by dino@apple.com
  • 2 edits in trunk/WebKitSite

2010-04-29 Dean Jackson <dino@apple.com>

Unreviewed. Make a note that we are no longer proposing
the evaluateMediaQuery method. Instead, we are following
the standard matchMedium method from CSS 3 View.

  • specs/MediaQueriesExtensions.html:
3:43 PM Changeset in webkit [58544] by ap@apple.com
  • 1 edit
    16 copies
    1 move
    16 deletes in trunk/LayoutTests

Not reviewed.

Trying to fix Windows checkout by shortening paths in Sputnik tests.

  • fast/js/sputnik: Many directories renamed.
3:20 PM Changeset in webkit [58543] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/7918086> REGRESSION (r57820): Controller is not displayed in window when opening a MP3 file in browser window
https://bugs.webkit.org/show_bug.cgi?id=38350

Reviewed by Simon Fraser.

WebCore:

Tests: media/audio-only-video-intrinsic-size.html

media/media-document-audio-size.html

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::RenderVideo): Until metadata is available, ignore the natural size
reported by the player.
(WebCore::RenderVideo::videoSizeChanged): Respect a natural size of zero if reported by the
player, except in standalone media documents.

LayoutTests:

  • media/audio-only-video-intrinsic-size-expected.txt: Added.
  • media/audio-only-video-intrinsic-size.html: Added.
  • media/media-document-audio-size-expected.txt: Added.
  • media/media-document-audio-size.html: Added.
3:16 PM Changeset in webkit [58542] by andersca@apple.com
  • 8 edits
    1 add in trunk

First part of
https://bugs.webkit.org/show_bug.cgi?id=20784
move npapi.h to C99 integer types.

Reviewed by Dan Bernstein.

WebCore:

Add nptypes.h to the build.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/npapi.h:
  • bridge/npruntime.h:
  • bridge/nptypes.h: Added.

WebKit/mac:

  • MigrateHeaders.make:

WebKit/win:

  • WebKit.vcproj/WebKit.vcproj:
3:11 PM Changeset in webkit [58541] by yaar@chromium.org
  • 5 edits in trunk/LayoutTests

2010-04-29 Yaar Schnitman <yaar@chromium.org>

Not Reviewed.

Fixed corrupt svg-background-partial-redraw-expected.checksum files
https://bugs.webkit.org/show_bug.cgi?id=38355

  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum:
  • platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.checksum:
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum:
2:51 PM Changeset in webkit [58540] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-04-29 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Adam Barth.

Update GObject bindings test results. We are actually moving
backwards here, but we'll update them again when we figure out
what broke.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property):
2:50 PM Changeset in webkit [58539] by yaar@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-29 Yaar Schnitman <yaar@chromium.org>

Not Reviewed.

Skip sputnik tests for chromium until we decide what to do with them.
https://bugs.webkit.org/show_bug.cgi?id=38353

  • platform/chromium/test_expectations.txt:
2:34 PM Changeset in webkit [58538] by ap@apple.com
  • 5 edits in trunk/LayoutTests

Skipping Sputnik tests, because tey fail a lot on buildbots. The current (early) theory is
that this depends on when exactly DumpRenderTree gets restarted.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
  • platform/qt/Skipped:
2:32 PM Changeset in webkit [58537] by oliver@apple.com
  • 7 edits
    1 add in trunk/JavaScriptCore

Hoist JSVALUE32_64 arithmetic implementations into a separate file.

Reviewed by Geoff Garen.

(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emit_op_div):
(JSC::JIT::compileBinaryArithOp):

  • jit/JITArithmetic32_64.cpp: Added.

(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jless):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emitSlow_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emitSlow_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emitSlow_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emitSlow_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::emitSlow_op_pre_dec):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSub32Constant):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

2:30 PM Changeset in webkit [58536] by yaar@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-29 Yaar Schnitman <yaar@chromium.org>

Not Reviewed.

Skip fast/images/svg-nested.html which crashes chromium.py
https://bugs.webkit.org/show_bug.cgi?id=38351

  • platform/chromium/test_expectations.txt:
1:52 PM Changeset in webkit [58535] by yaar@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2010-04-29 Yaar Schnitman <yaar@chromium.org>

Not reviewed.

Adding missing expectations, skipping tests
https://bugs.webkit.org/show_bug.cgi?id=38343

  • platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Added.
  • platform/chromium-mac/fast/media/media-query-invalid-value-expected.checksum: Added.
  • platform/chromium-win/fast/css/font-face-woff-expected.checksum: Added.
  • platform/chromium-win/fast/css/font-face-woff-expected.txt: Added.
  • platform/chromium-win/fast/media/media-query-invalid-value-expected.checksum: Added.
  • platform/chromium-win/fast/text/international/bold-bengali-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:43 PM Changeset in webkit [58534] by ap@apple.com
  • 1 edit
    11427 adds
    3 deletes in trunk/LayoutTests

Rubber-stamped by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=38296
Import Sputnik JavaScript test suite

  • fast/js/sputnik: Added.
  • fast/js/sputnik/AUTHORS: Added.
  • fast/js/sputnik/Conformance: Added.
  • fast/js/sputnik/Implementation_Diagnostics: Added.
  • fast/js/sputnik/LICENSE: Added.
  • fast/js/sputnik/Regression: Added.
  • fast/js/sputnik/Unicode: Added.
  • fast/js/script-tests/sputnik-S15.4.4.12_A3_T3.js: Deleted.
  • fast/js/sputnik-S15.4.4.12_A3_T3-expected.txt: Deleted.
  • fast/js/sputnik-S15.4.4.12_A3_T3.html: Deleted.
1:16 PM Changeset in webkit [58533] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=38277
MiniBrowser: -[WebCoreFlippedView currentEditor]: unrecognized selector

Reviewed by Anders Carlsson.

  • platform/mac/ThemeMac.mm:

(-[WebCoreFlippedView currentEditor]): Added currentEditor nil implementation.

1:02 PM Changeset in webkit [58532] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CodeGeneratorJS.pm should be consistent about castedThis versus castedThisObj
https://bugs.webkit.org/show_bug.cgi?id=38338

Currently CodeGeneratorJS.pm uses castThis for methods and
castedThisObj for attributes. This inconsistency makes it difficult to
factor common code genereration code into methods shared by both kinds
of bindings. This match aligns the names so that a future patch (e.g.,
in https://bugs.webkit.org/show_bug.cgi?id=38313) can reduce copy/paste
code.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::setJSTestObjIntAttr): (WebCore::setJSTestObjLongLongAttr): (WebCore::setJSTestObjUnsignedLongLongAttr): (WebCore::setJSTestObjStringAttr): (WebCore::setJSTestObjTestObjAttr): (WebCore::setJSTestObjAttrWithException): (WebCore::setJSTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithGetterException): (WebCore::jsTestObjPrototypeFunctionVoidMethod): (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionIntMethod): (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionObjMethod): (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithException): (WebCore::jsTestObjPrototypeFunctionCustomMethod): (WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): (WebCore::jsTestObjPrototypeFunctionAddEventListener): (WebCore::jsTestObjPrototypeFunctionRemoveEventListener): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrame): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid): (WebCore::jsTestObjPrototypeFunctionWithScriptStateObj): (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException): (WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
12:39 PM Changeset in webkit [58531] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-04-29 Gustavo Noronha Silva <gustavo.noronhaollabora.co.uk>

Reviewed by Xan Lopez.

[GTK] pointerCursor should use the default cursor set for the window, not GDK_LEFT_PTR
https://bugs.webkit.org/show_bug.cgi?id=36963

Use the default cursor instead of hard-coding left pointer.

  • platform/gtk/CursorGtk.cpp: (WebCore::Cursor::Cursor): (WebCore::pointerCursor):
12:14 PM Changeset in webkit [58530] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-04-29 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Consider implementing addOriginAccessWhitelistEntry method
http://trac.webkit.org/changeset/57537 introduced a new method
to manage whitelisting of origins.
Expose this method in Chromium's bridge.
https://bugs.webkit.org/show_bug.cgi?id=37578

  • public/WebSecurityPolicy.h: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method
  • src/WebSecurityPolicy.cpp: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method
11:30 AM Changeset in webkit [58529] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-28 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

webkit-patch doesn't work if a git repo is tracking multiple svn repos
https://bugs.webkit.org/show_bug.cgi?id=38290

Getting the tests to pass required getting our SVN repo to more closely
match the real svn.webkit.org repo by having a trunk directory.
That involved adding an extra commit at the beginning and thus changing
all the commit numbers in the tests.

  • Scripts/webkitpy/common/checkout/scm.py:
11:12 AM Changeset in webkit [58528] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-29 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: If Timeline panel is in recording mode and is not visible and has received
new events then these events do not appear in the panel when the panel becomes visible.
Timeline popup may appear in the upper left window corner when you switch to another panel.
https://bugs.webkit.org/show_bug.cgi?id=38322

  • inspector/front-end/Popover.js: (WebInspector.PopoverHelper.prototype._mouseMove.doHide): (WebInspector.PopoverHelper.prototype._mouseMove): (WebInspector.PopoverHelper.prototype.hidePopup): (WebInspector.PopoverHelper.prototype._hidePopup):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype.show): (WebInspector.TimelinePanel.prototype._scheduleRefresh): (WebInspector.TimelinePanel.prototype._refresh):
11:06 AM Changeset in webkit [58527] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-04-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Reinstate qt_drt_ symbol exports as of QtWebKit 4.6 release
https://bugs.webkit.org/show_bug.cgi?id=38304

This change provides backward compatibility with some previously
exported private symbols. No new functionality introduced.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (qt_resumeActiveDOMObjects): (qt_suspendActiveDOMObjects): (qt_drt_clearFrameName): (qt_drt_garbageCollector_collect): (qt_drt_garbageCollector_collectOnAlternateThread): (qt_drt_javaScriptObjectsCount): (qt_drt_numberOfActiveAnimations): (qt_drt_overwritePluginDirectories): (qt_drt_pauseAnimation): (qt_drt_pauseTransitionOfProperty): (qt_drt_resetOriginAccessWhiteLists): (qt_drt_run): (qt_drt_setJavaScriptProfilingEnabled): (qt_drt_whiteListAccessFromOrigin): (qt_webpage_groupName): (qt_webpage_setGroupName):
11:02 AM Changeset in webkit [58526] by eric@webkit.org
  • 14 edits
    2 adds in trunk

2010-04-29 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Adler.

Let's cache nodelists instead of DynamicNodeList::Caches
https://bugs.webkit.org/show_bug.cgi?id=33696

  • fast/dom/Element/node-list-identity-expected.txt: Added to verify that node lists are indeed cached
  • fast/dom/Element/node-list-identity.html: Added to verify that node lists are indeed cached
  • fast/dom/gc-9-expected.txt: Updated to follow changed semantics of caching
  • fast/dom/gc-9.html: Updated to follow changed semantics of caching

2010-04-29 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Adler.

Let's cache nodelists instead of DynamicNodeList::Caches
https://bugs.webkit.org/show_bug.cgi?id=33696

Test: fast/dom/Element/node-list-identity.html

  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Mark all cached node lists as well
  • dom/ClassNodeList.cpp: (WebCore::ClassNodeList::ClassNodeList): Don't need DynamicNodeList::Caches argument any more (WebCore::ClassNodeList::~ClassNodeList): Remove from the cache
  • dom/ClassNodeList.h: Added a field with original class names to be used as a key for removal from the cache (WebCore::ClassNodeList::create): Don't need DynamicNodeList::Caches argument any more
  • dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): Don't need DynamicNodeList::Caches argument any more (WebCore::NameNodeList::~NameNodeList): Remove from the cache
  • dom/NameNodeList.h: (WebCore::NameNodeList::create): Don't need DynamicNodeList::Caches argument any more
  • dom/Node.cpp: (WebCore::Node::removeCachedClassNodeList): Remove ClassNodeList from the cache (WebCore::Node::removeCachedNameNodeList): Remove NameNodeList from the cache (WebCore::Node::removeCachedTagNodeList): Remove TagNodeList from the cache (WebCore::Node::getElementsByTagNameNS): Switch to caching node lists themselves, not the data (WebCore::Node::getElementsByName): Switch to caching node lists themselves, not the data (WebCore::Node::getElementsByClassName): Switch to caching node lists themselves, not the data (WebCore::NodeListsNodeData::invalidateCaches): Switch to caching node lists themselves, not the data (WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes): Switch to caching node lists themselves, not the data (WebCore::NodeListsNodeData::isEmpty): Switch to caching node lists themselves, not the data (WebCore::markNodeLists): Helper to mark all the node lists in the cache (WebCore::Node::markCachedNodeListsSlow): Mark all the cached node lists if any could be present
  • dom/Node.h: (WebCore::Node::markCachedNodeLists): Fast-path marking of cached node lists---bails out if there is no rare data
  • dom/NodeRareData.h: Changed type of caches to hold raw pointers to node lists, not RefPtr's to data
  • dom/TagNodeList.cpp: (WebCore::TagNodeList::TagNodeList): Don't need DynamicNodeList::Caches argument any more (WebCore::TagNodeList::~TagNodeList): Remove from the cache
  • dom/TagNodeList.h: (WebCore::TagNodeList::create): Don't need DynamicNodeList::Caches argument any more
10:45 AM Changeset in webkit [58525] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-29 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] Update ScriptProfileNode to retrieve execution time in milliseconds.

https://bugs.webkit.org/show_bug.cgi?id=38330

  • bindings/v8/ScriptProfileNode.cpp: (WebCore::ScriptProfileNode::totalTime): (WebCore::ScriptProfileNode::selfTime):
10:41 AM Changeset in webkit [58524] by jorlow@chromium.org
  • 92 edits in trunk/LayoutTests

2010-04-29 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Rebaseline chromium SVG tests
This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=37986
https://bugs.webkit.org/show_bug.cgi?id=38106

  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-linux/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/chromium-linux/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-mac/fast/images: Added.
  • platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-mac/traversal: Added.
  • platform/chromium-mac/traversal/node-iterator-prototype-expected.txt: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
  • platform/chromium-win/svg/carto.net/tabgroup-expected.txt: Added.
  • platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/chromium-win/svg/custom/fill-fallback-expected.txt:
  • platform/chromium-win/svg/custom/gradient-cycle-detection-expected.txt:
  • platform/chromium-win/svg/custom/gradient-deep-referencing-expected.txt:
  • platform/chromium-win/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/chromium-win/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/chromium-win/svg/custom/invalid-css-expected.txt:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-update-gradient-expected.checksum:
  • platform/chromium-win/svg/custom/js-update-gradient-expected.png:
  • platform/chromium-win/svg/custom/pattern-cycle-detection-expected.txt:
  • platform/chromium-win/svg/custom/pattern-deep-referencing-expected.txt:
  • platform/chromium-win/svg/custom/pattern-rotate-expected.txt:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.txt:
  • platform/chromium-win/svg/custom/stroke-fallback-expected.txt:
  • platform/chromium-win/svg/custom/stroked-pattern-expected.txt:
  • platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-win/svg/hixie/error/003-expected.txt:
  • platform/chromium-win/svg/hixie/perf/005-expected.txt:
  • platform/chromium-win/svg/hixie/perf/006-expected.txt:
  • platform/chromium-win/svg/text/selection-background-color-expected.txt:
  • platform/chromium-win/svg/text/selection-styles-expected.txt:
  • platform/chromium-win/svg/text/text-gradient-positioning-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • platform/chromium-win/traversal: Added.
  • platform/chromium-win/traversal/node-iterator-prototype-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:35 AM Changeset in webkit [58523] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-04-29 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Get rid of forceLayout() on FrameView
https://bugs.webkit.org/show_bug.cgi?id=38199

The function FrameView::forceLayout() is missleading
because it does not actually force the layout, the call is
equivalent to layout().

This patch replace the call to forceLayout() by layout() in Qt
to avoid the misunderstanding/improve readability.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::setPreferredContentsSize):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::setMediaType):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::forceLayout):
9:43 AM Changeset in webkit [58522] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-04-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r58498.
http://trac.webkit.org/changeset/58498
https://bugs.webkit.org/show_bug.cgi?id=38332

"Broke a bunch of tests on Chromium canaries" (Requested by
dglazkov on #webkit).

  • public/WebViewClient.h: (WebKit::WebViewClient::createView):
  • public/WebWindowFeatures.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow):
9:23 AM Changeset in webkit [58521] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations tweak.

Update stale expectations I accidentally checked in in http://trac.webkit.org/changeset/58520
https://bugs.webkit.org/show_bug.cgi?id=9756

  • fast/forms/implicit-submission-expected.txt: Updated expectations.
8:53 AM Changeset in webkit [58520] by Dimitri Glazkov
  • 8 edits
    2 adds
    4 deletes in trunk

A form without a submit button unexpectedly performs its action when Return is pressed
https://bugs.webkit.org/show_bug.cgi?id=9756

Reviewed by Darin Adler.

WebCore:

Implemented implicit form submission algorithm as defined in HTML5 spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#implicit-submission,
falling back to match IE's behavior in the edge cases.

The underlying rules are:

  • If the form has no enabled submit buttons, submit if Enter/Return is pressed on the only single-line text field.
  • Otherwise, submit form using first enabled submit button if Enter/Return is pressed on a field that's not a textarea or a select.

Test: fast/forms/implicit-submission.html

  • dom/SelectElement.cpp:

(WebCore::SelectElement::menuListDefaultEventHandler): Ripped out implicit submission for select elements.
(WebCore::SelectElement::listBoxDefaultEventHandler): Ditto.
(WebCore::SelectElement::defaultEventHandler): Ditto.

  • dom/SelectElement.h: Ditto.

(WebCore::HTMLFormElement::submitImplicitly): Renamed submitClick to submitImplicitly to better match HTML5 spec

language, changed the logic to match the rules above.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler): Reamed clickDefaultButton to implicitSubmission to better match

HTML5 spec language, made radio element to trigger implicit submission.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::defaultEventHandler): Removed passing of form() as parameter, because it's no longer

necessary.

LayoutTests:

A comprehensive test for various edge cases involving implicit form submission.

  • fast/forms/implicit-submission-expected.txt: Added.
  • fast/forms/implicit-submission.html: Added.
  • fast/forms/check-box-enter-key-expected.txt: Removed because it's now part of implicit-submission.html.
  • fast/forms/check-box-enter-key.html: Ditto.
  • fast/forms/select-enter-key-expected.txt: Ditto.
  • fast/forms/select-enter-key.html: Ditto.
8:46 AM Changeset in webkit [58519] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-29 Paweł Hajdan, Jr. <phajdan.jr@chromium.org>

Reviewed by Jeremy Orlow.

Fix building with libpng-1.4.
https://bugs.webkit.org/show_bug.cgi?id=33287

No new tests (no behavior change).

Original patch by John Bowler <jbowler@acm.org>

  • platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::PNGImageEncoder::encode):
8:26 AM Changeset in webkit [58518] by agl@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-29 Adam Langley <agl@chromium.org>

Unreviewed, DEPS roll.

WebKit's r58517 needs OTS's r30 which was rolled into Chromium in
r45932.

7:57 AM Changeset in webkit [58517] by agl@chromium.org
  • 8 edits
    2 adds in trunk

2010-04-29 Adam Langley <agl@chromium.org>

Reviewed by David Levin.

This patch adds support for WOFF in Chromium. Since Chromium
already transcodes all OpenType files for security reasons we
are adding WOFF support into the transcoder.

https://bugs.webkit.org/show_bug.cgi?id=38217

  • css/CSSFontFaceSrcValue.cpp: (WebCore::CSSFontFaceSrcValue::isSupportedFormat): Recognise "woff" as a font-face format value (guarded by ENABLE(OPENTYPE_SANITIZER) at this point)
  • platform/graphics/opentype/OpenTypeSanitizer.cpp: (WebCore::OpenTypeSanitizer::sanitize): Change so that the transcoded font can be larger than the original. (WOFF files are compressed, so the transcoded TTF is typically larger.)
7:26 AM Changeset in webkit [58516] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-29 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Updates to the Qt build to enable building MathML support.

  • WebCore.pri:
  • WebCore.pro:
7:08 AM Changeset in webkit [58515] by zherczeg@webkit.org
  • 3 edits in trunk/JavaScriptCore

Add sqrt() instruction support for ARM assembler (using VFP)
https://bugs.webkit.org/show_bug.cgi?id=38312

Reviewed by Oliver Hunt

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::):
(JSC::ARMAssembler::fsqrtd_r):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::sqrtDouble):

6:50 AM Changeset in webkit [58514] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-04-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Test webkit_dom_document_get_element_by_id;

  • tests/testdomdocument.c: (test_dom_document_get_element_by_id): (main):
6:50 AM Changeset in webkit [58513] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-04-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Test webkit_dom_document_get_elements_by_class_name.

  • tests/testdomdocument.c: (test_dom_document_get_elements_by_class_name): (main):
6:50 AM Changeset in webkit [58512] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-04-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Test webkit_dom_document_get_elements_by_tag_name.

  • tests/testdomdocument.c: (test_dom_document_get_elements_by_tag_name): (main):
6:50 AM Changeset in webkit [58511] by xan@webkit.org
  • 4 edits
    1 add in trunk

2010-04-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Add WebKitDOMDocument tests to the build.

  • GNUmakefile.am:

WebKit/gtk:

2010-04-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Move WebKitDOMDocument unit tests to their own file.

  • tests/testdomdocument.c: Added. (finish_loading): (dom_document_fixture_setup): (dom_document_fixture_teardown): (test_dom_document_title): (main):
  • tests/testwebview.c:
6:49 AM Changeset in webkit [58510] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-04-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Do not generate unneeded boilerplate in {get,set}_property methods
when there are no properties to generate code for. This gets rid
of lots of compiler warnings.

  • bindings/scripts/CodeGeneratorGObject.pm:
6:48 AM Changeset in webkit [58509] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-04-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Include <webkit/webkitdom.h> in the main webkit.h header.

  • webkit/webkit.h:
6:37 AM Changeset in webkit [58508] by Csaba Osztrogonác
  • 48 edits in trunk/LayoutTests

[Qt] Loading of large page can take up to 10 seconds
https://bugs.webkit.org/show_bug.cgi?id=31719

Rubber-stamped by Simon Hausmann.

Followup patch. Update expected files because of minor differences.
(size of whitespaces, place of linebreaks)

  • platform/qt/css1/basic/inheritance-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_margin-expected.txt:
  • platform/qt/css1/color_and_background/background_attachment-expected.txt:
  • platform/qt/css1/color_and_background/background_repeat-expected.txt:
  • platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/qt/css1/font_properties/font-expected.txt:
  • platform/qt/css1/font_properties/font_style-expected.txt:
  • platform/qt/css1/formatting_model/inline_elements-expected.txt:
  • platform/qt/css1/text_properties/line_height-expected.txt:
  • platform/qt/css1/text_properties/text_decoration-expected.txt:
  • platform/qt/css1/text_properties/text_indent-expected.txt:
  • platform/qt/css1/text_properties/vertical_align-expected.txt:
  • platform/qt/css2.1/t1202-counter-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-03-b-expected.txt:
  • platform/qt/css2.1/t1202-counter-04-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-01-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-02-b-expected.txt:
  • platform/qt/css2.1/t1202-counters-03-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
  • platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
  • platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt:
  • platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
  • platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
  • platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/qt/fast/backgrounds/size/zero-expected.txt:
  • platform/qt/fast/css/font-face-opentype-expected.txt:
  • platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt:
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
  • platform/qt/fast/text/fake-italic-expected.txt:
  • platform/qt/fast/text/international/khmer-selection-expected.txt:
  • platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-doubleclick-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.txt:
  • platform/qt/svg/text/selection-tripleclick-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
6:36 AM Changeset in webkit [58507] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

[Qt] Speed up text layouting
https://bugs.webkit.org/show_bug.cgi?id=31719

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2010-04-29
Reviewed by Kenneth Rohde Christiansen.

Use QFontMetrics::width() for the text width calculation instead
of QTextLayout. This avoids expensive bearing calculations and the
line breaking code.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText):

6:11 AM Changeset in webkit [58506] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-29 Kwang Yul Seo <skyul@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Export g_stackBase with JS_EXPORTDATA
https://bugs.webkit.org/show_bug.cgi?id=37437

Declare g_stackBase with JS_EXPORTDATA as it is imported from JavaScriptCore.

  • platform/wince/SharedTimerWince.cpp:
5:05 AM Changeset in webkit [58505] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests/platform

Unreviewed. Skip editing/pasteboard/drag-drop-input-textarea.html on GTK and Qt.

4:46 AM Changeset in webkit [58504] by eric@webkit.org
  • 14 edits in trunk/WebCore

2010-04-29 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Remove custom bindings for PopStateEvent.initPopStateEvent
https://bugs.webkit.org/show_bug.cgi?id=38311

Our code generation of SerializedScriptValue was slightly buggy, but
it's easy to fix. Notice that the conversion to an atomic string is
handled by the C++ type system and doesn't require logic in the code
generator.

  • bindings/js/JSPopStateEventCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_serialized_value):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionSerializedValue):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj serializedValue:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::serializedValueCallback): (WebCore::ConfigureV8TestObjTemplate):
  • bindings/v8/custom/V8PopStateEventCustom.cpp:
  • dom/PopStateEvent.idl:
4:29 AM Changeset in webkit [58503] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests can deadlock with Chromium's TestShell
https://bugs.webkit.org/show_bug.cgi?id=38298

Fix _write_command_and_read_line to never send unicode() to
test_shell, instead to always encode as utf-8. This was causing
random hangs because if test_shell ever encounters a \0 in the
stream it can deadlock with NRWT.

There is still a deadlock bug to fix in NRWT/test_shell design, however
this fix should make the deadlock occur less often.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4:23 AM Changeset in webkit [58502] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

2010-04-29 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that selection drag-and-drop doesn't work for input/textarea.
https://bugs.webkit.org/show_bug.cgi?id=38175

  • editing/pasteboard/drag-drop-input-textarea-expected.txt: Added.
  • editing/pasteboard/drag-drop-input-textarea.html: Added.

2010-04-29 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that selection drag-and-drop doesn't work for input/textarea.
https://bugs.webkit.org/show_bug.cgi?id=38175

The code supposed the selected region was in the destination text
field. It is not true in a case of drag-and-drop.

Test: editing/pasteboard/drag-drop-input-textarea.html

  • dom/InputElement.cpp: (WebCore::InputElement::handleBeforeTextInsertedEvent):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
4:18 AM Changeset in webkit [58501] by eric@webkit.org
  • 4 edits
    1 delete in trunk/WebCore

2010-04-29 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Remove custom bindings for NodeFilter.acceptNode
https://bugs.webkit.org/show_bug.cgi?id=38309

This "custom" code was just an instance of the CallWith=ScriptState
pattern. Also, it looks like V8 just had a garbage implemenation that
did nothing.

  • WebCore.gypi:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/v8/custom/V8NodeFilterCustom.cpp: Removed.
  • dom/NodeFilter.idl:
4:05 AM Changeset in webkit [58500] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] QtWebkit doesn't link with 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=38299

Added implementation for GraphicsContext3D::isGLES2Compliant, which returns the correct value based on a Qt #define.

No new tests: build fix

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::isGLES2Compliant):
4:02 AM Changeset in webkit [58499] by Nikolas Zimmermann
  • 1 edit
    40 adds in trunk/LayoutTests

2010-04-29 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Maciej Stachowiak.

Add missing pixel test results for several tests on Mac. Now doesn't create any new files anymore, when running run-webkit-tests -p.

  • platform/mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.checksum: Added.
  • platform/mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.
  • platform/mac/fast/css/css3-space-in-nth-and-lang-expected.checksum: Added.
  • platform/mac/fast/css/css3-space-in-nth-and-lang-expected.png: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.checksum: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.checksum: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.checksum: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.checksum: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.checksum: Added.
  • platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.checksum: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.checksum: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.checksum: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.checksum: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.checksum: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.checksum: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
  • platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Added.
  • platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Added.
  • platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Added.
  • platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.png: Added.
  • platform/mac/fast/media/media-query-invalid-value-expected.checksum: Added.
  • platform/mac/fast/media/media-query-invalid-value-expected.png: Added.
  • platform/mac/fast/runin/generated2-expected.checksum: Added.
  • platform/mac/fast/runin/generated2-expected.png: Added.
  • platform/mac/fast/runin/generated3-expected.checksum: Added.
  • platform/mac/fast/runin/generated3-expected.png: Added.
  • platform/mac/fast/runin/generated4-expected.checksum: Added.
  • platform/mac/fast/runin/generated4-expected.png: Added.
  • platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.checksum: Added.
  • platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.png: Added.
4:00 AM QtWebKitBugs edited by vestbo@webkit.org
(diff)
3:55 AM Changeset in webkit [58498] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-04-29 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Darin Fisher.

Include WindowFeatures in call to WebViewClient::createView.

https://bugs.webkit.org/show_bug.cgi?id=38301

  • public/WebViewClient.h: (WebKit::WebViewClient::createView):
  • public/WebWindowFeatures.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow):
3:42 AM Changeset in webkit [58497] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Remove unnecessary call to FrameView::forceLayout() in setViewportSize()
This prevents a double relayout on resize.

Patch by Andreas Kling <andreas.kling@nokia.com> on 2010-04-29
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=38179

Thanks to Nate Whetsell <nathan.whetsell@gmail.com> for spotting this.

  • Api/qwebpage.cpp:

(QWebPage::setViewportSize):

3:35 AM Changeset in webkit [58496] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-04-29 Garret Kelly <gdk@chromium.org>

Reviewed by Darin Fisher.

Expose the RuntimeFeature for touch events through the
WebRuntimeFeatures mechanism.
https://bugs.webkit.org/show_bug.cgi?id=37486

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableTouch): (WebKit::WebRuntimeFeatures::isTouchEnabled):
3:33 AM Changeset in webkit [58495] by Chris Jerdonek
  • 5 edits
    1 add in trunk/WebKitTools

Refactored svn-apply and svn-unapply to use the new
parsePatch() subroutine.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=34033

  • Scripts/VCSUtils.pm:
    • Consolidated %diffHash documentation.
    • Added prepareParsedPatch().
  • Scripts/svn-apply:
    • Replaced main while loop with calls to parsePatch() and prepareParsedPatch().
  • Scripts/svn-unapply:
    • Replaced main while loop with calls to parsePatch() and prepareParsedPatch().
  • Scripts/test-webkitperl:
    • Changed to render relative test paths rather than absolute test paths.
  • Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl: Added.
    • Added unit tests for prepareParsedPatch().
3:25 AM Changeset in webkit [58494] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] Refactor qtscriptglobal.h
https://bugs.webkit.org/show_bug.cgi?id=37953

Use the same pattern in qtscriptglobal.h as in
qwebkitglobal.h without checking for specific OSs.

  • qt/api/qtscriptglobal.h:
3:20 AM Changeset in webkit [58493] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] REGRESSION(r57638): tst_qwebframe::objectDeleted() fails
https://bugs.webkit.org/show_bug.cgi?id=38316

Reviewed by Tor Arne Vestbø.

Accessing properties of a deleted objects doesn't throw an exception
anymore.

Continue to expose the QObject class wrapper for objects that
previously existed but don't exist anymore. QtClass is safe to
use with a deleted QObject.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getClass): Return null only if m_class
doesn't exist yet and there's no m_object.

3:04 AM Changeset in webkit [58492] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

Reverse animations don't work in some use cases
https://bugs.webkit.org/show_bug.cgi?id=38075

This was due to a code path special-casing reverse animations, that became obselete when we aligned our animation code
with the CA implementation. That special case code path is now a bug - and this patch removes it.

http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now runs the reverse
animation correctly.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::TransformAnimationQt::applyFrame):
2:42 AM Changeset in webkit [58491] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt: fast/media/media-query-invalid-value.html should be MISSING, not IMAGE.
2:33 AM Changeset in webkit [58490] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-29 Jan Hanssen <jhanssen@codeaurora.org>

Reviewed by Adam Barth.

Test whether HTMLOptionElement::ownerSelectElement() is considering the keygen element.
https://bugs.webkit.org/show_bug.cgi?id=26016

  • fast/dom/HTMLKeygenElement/keygen-option-select-expected.txt: Added.
  • fast/dom/HTMLKeygenElement/keygen-option-select.html: Added.

2010-04-29 Jan Hanssen <jhanssen@codeaurora.org>

Reviewed by Adam Barth.

HTMLOptionElement::ownerSelectElement() needs to consider keygen elements
https://bugs.webkit.org/show_bug.cgi?id=26016

Patch written by Grace Kloba <klobag@gmail.com>, test fixed by me.

Test: fast/dom/HTMLKeygenElement/keygen-option-select.html

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement): Make HTMLOptionElement::ownerSelectElement() consider the keygen element in addition to the current select element.
2:07 AM Changeset in webkit [58489] by Nikolas Zimmermann
  • 12 edits in trunk/LayoutTests

2010-04-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Maciej Stachowiak.

REGRESSION: gradient background of LayoutTests/fast/backgrounds/resources/balloon.svg fails to draw
https://bugs.webkit.org/show_bug.cgi?id=38307

balloon.svg is broken, it contains a <def> section, instead of a <defs> section.
We now properly ignored the subtree. s/def/defs/ and the testcase works again.

fast/backgrounds/svg-as-background-2.html even properly draws the gradient background instead of pure red color.
Combined with Simons SVGImage repaint fixes, we have a nice progression in this area.

Updated some fast/*expected.png files, that showed a 0.01% difference on my system. Probably a CG difference,
I can now run those tests with --tolerance 0 without a problem.

  • fast/backgrounds/resources/balloon.svg: s/def/defs/
  • fast/backgrounds/size/contain-and-cover-expected.checksum: Updated for marginal differences.
  • fast/backgrounds/size/contain-and-cover-expected.png: Ditto.
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Huge update, no more red, but a nice gradient.
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Ditto.
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Updated for marginal differences.
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Ditto.
  • platform/mac/fast/images/svg-as-tiled-background-expected.checksum: Reflect the current state: it's green now, no more red.
  • platform/mac/fast/images/svg-as-tiled-background-expected.png: Ditto.
  • platform/mac/fast/images/svg-background-partial-redraw-expected.checksum: Updated for marginal differences.
  • platform/mac/fast/images/svg-background-partial-redraw-expected.png: Ditto.
1:57 AM Changeset in webkit [58488] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectations update.

r58479 add fast/media/media-query-invalid-value.html, but it misses
image expectations.

  • platform/chromium/test_expectations.txt:
1:46 AM Changeset in webkit [58487] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-04-29 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>

Reviewed by Eric Seidel.

Add EFL-specific code to Widget.h and move the empty
frameRectsChanged() definition to Widget.cpp, since the EFL port
needs to override that.
http://webkit.org/b/36317

No new tests required.

  • WebCore.base.exp:
  • platform/Widget.cpp: (WebCore::Widget::frameRectsChanged):
  • platform/Widget.h:
1:44 AM Changeset in webkit [58486] by ukai@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2010-04-29 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

wrong filename: LayoutTests/platform/win/fast/text/international/bold-bengali-actual.txt
https://bugs.webkit.org/show_bug.cgi?id=38310

  • platform/win/fast/text/international/bold-bengali-expected.txt: Renamed from LayoutTests/platform/win/fast/text/international/bold-bengali-actual.txt.
1:41 AM Changeset in webkit [58485] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] REGRESSION(r57982): tst_qwebpage::showModalDialog() crashes
https://bugs.webkit.org/show_bug.cgi?id=38314

Reviewed by Tor Arne Vestbø.

Make sure that there's always a main frame when returning from createWindow()
to the caller in WebCore.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::createWindow):

1:25 AM Changeset in webkit [58484] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-29 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsContext3DQt.cpp does not implement isGLES2Compliant()
https://bugs.webkit.org/show_bug.cgi?id=38216

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::isGLES2Compliant):
1:14 AM Changeset in webkit [58483] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-04-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Small cleanup.

QScriptValuePrivate constructor shouldn't take QScriptEngine pointer
as a parameter, because it breaks a private / public separation rule.
QScriptEnginePrivate::get(QScriptEngine*) should return
a QScriptEnginePrivate pointer instead of a QScriptEnginePtr, it simplifies
implementation.

[Qt] QScriptValuePrivate class needs some cleanup.
https://bugs.webkit.org/show_bug.cgi?id=37729

  • qt/api/qscriptengine_p.h: (QScriptEnginePrivate::get):
  • qt/api/qscriptvalue.cpp: (QScriptValue::QScriptValue):
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::QScriptValuePrivate):
12:52 AM Changeset in webkit [58482] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-04-29 Kwang Yul Seo <skyul@company100.net>

Reviewed by Simon Hausmann.

[WINCE] Export g_stackBase with JS_EXPORTDATA
https://bugs.webkit.org/show_bug.cgi?id=37437

Export g_stackBase with JS_EXPORTDATA as it is used by SharedTimerWince.cpp.

  • runtime/Collector.cpp:
12:42 AM Changeset in webkit [58481] by eric@webkit.org
  • 7 edits in trunk

2010-04-29 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=38235

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2D): Add extractImageData; add a common entry point for texImage2D with image input. (WebCore::WebGLRenderingContext::texImage2DBase): Add this function as the common entry point for texImage2D. (WebCore::WebGLRenderingContext::texSubImage2D): Add extractImageData; add a common entry point for texSubImage2D with image input. (WebCore::WebGLRenderingContext::texSubImage2DBase): Add this function as the common entry point for texSubImage2D.
  • html/canvas/WebGLRenderingContext.h: Add tex*Image{Base/Image} function declaration.
  • platform/graphics/GraphicsContext3D.h: Remove tex*Image declaration with Image input.
  • platform/graphics/mac/GraphicsContext3DMac.cpp: Remove tex*Image implementation with Image input. (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D):

2010-04-29 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=38235

  • src/GraphicsContext3D.cpp: Remove tex*image implementation with Image input.
12:15 AM Changeset in webkit [58480] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: flicker when starting an animation before the previous one ended.
https://bugs.webkit.org/show_bug.cgi?id=38076

This was due to the cude in the removeAnimations functions, which called deleteLater() without stopping the
animation synchronously. The delay between the call to that function and the actual call to the animation's destructor
is when the flicker occured. We fix this by calling stop() synchronously, and making sure that the value is reverted
upon stop (updateState) and not upon the object's destruction.

http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now doesn't flicker when
the animation is toggled frequently.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::TransformAnimationQt::~TransformAnimationQt): (WebCore::TransformAnimationQt::applyFrame): (WebCore::TransformAnimationQt::updateState): (WebCore::OpacityAnimationQt::~OpacityAnimationQt): (WebCore::OpacityAnimationQt::updateState): (WebCore::GraphicsLayerQt::removeAnimationsForProperty): (WebCore::GraphicsLayerQt::removeAnimationsForKeyframes):
12:05 AM Changeset in webkit [58479] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Simon Fraser.

Media queries empty values
https://bugs.webkit.org/show_bug.cgi?id=38116

Adding isValid() method to MediaQueryExp to make it possible to differentiate
between queries with empty values and queries with invalid values.

  • fast/media/media-query-invalid-value-expected.txt: Added.
  • fast/media/media-query-invalid-value.html: Added.

2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Simon Fraser.

Media queries empty values
https://bugs.webkit.org/show_bug.cgi?id=38116

Adding isValid() method to MediaQueryExp to make it possible to differentiate
between queries with empty values and queries with invalid values.

Test: fast/media/media-query-invalid-value.html

  • css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::eval):
  • css/MediaQueryExp.cpp: (WebCore::MediaQueryExp::MediaQueryExp):
  • css/MediaQueryExp.h: (WebCore::MediaQueryExp::isValid):

Apr 28, 2010:

11:23 PM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
11:19 PM Changeset in webkit [58478] by Chris Jerdonek
  • 3 edits in trunk/WebKitTools

2010-04-28 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Added to VCSUtils's parseDiffHeader() support for binary patches.

https://bugs.webkit.org/show_bug.cgi?id=38094

The parseDiffHeader() function is part of new patch-parsing code
for svn-apply and svn-unapply that will go live in a subsequent
revision.

  • Scripts/VCSUtils.pm:
    • Added logic to parseDiffHeader() to recognize the ending of the header portion of a binary diff.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Added unit test cases for SVN and Git binary diffs.
11:15 PM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
11:10 PM Changeset in webkit [58477] by eric@webkit.org
  • 8 edits in trunk

2010-04-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Allow editing script resources when resource tracking is enabled.

https://bugs.webkit.org/show_bug.cgi?id=38269

  • inspector/front-end/ScriptView.js:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.canEditScripts): (WebInspector.ScriptsPanel.prototype.editScriptSource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.get textModel):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype._addBreakpoint): (WebInspector.SourceView.prototype._editLine): (WebInspector.SourceView.prototype._editLineComplete): (WebInspector.SourceView.prototype._sourceIDForLine):

2010-04-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Allow editing script resources when resource tracking is enabled.

http://bugs.webkit.org/show_bug.cgi?id=38269

  • src/js/DebuggerAgent.js:
  • src/js/InspectorControllerImpl.js: (.devtools.InspectorBackendImpl.prototype.setBreakpoint): (.devtools.InspectorBackendImpl.prototype.editScriptSource):
9:45 PM Changeset in webkit [58476] by tonikitoo@webkit.org
  • 5 edits
    5 adds in trunk

2010-04-25 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Darin Adler.

Clicking a scrollbar blurs the currently focused element
https://bugs.webkit.org/show_bug.cgi?id=16809

WebKit ports that do not use native (platform) widgets for rendering the scrollbars
are currently mismatching a common behaviour of other browser vendors (including
Firefox and Opera): clicking on a frame scrollbar *should not* steal focus from content.
WebKit browsers based ports that do use WebCore for handling scrollbars, like QtWebKit for
instance, can observe the opposite behaviour.

Patch fixes this behaviour by checking if current MouseDown event targets a frame scrollbar.
If that is the case, it bails out and do not change focus behavior at all.

It is important to note that the given way this is implemented by this patch, non-frame
scrollbars (e.g. a vertical scrollbar of an overflowed textareas or divs) will keep working
in the same way as it works currently.

Tests: scrollbars/scrollbar-click-does-not-blur-content.html

scrollbars/scrollbar-iframe-click-does-not-blur-content.html

  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEve
9:34 PM Changeset in webkit [58475] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Do an unordered compare so that we don't treat NaN incorrectly.

RS=Gavin Barraclough

  • jit/ThunkGenerators.cpp:

(JSC::powThunkGenerator):

9:23 PM Changeset in webkit [58474] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix test failures seen on the Leopard build bot after r58467

Rubber-stamped by Maciej Stachowiak.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::platformGlyphInit): Initialize m_zeroWidthSpaceGlyph before
calling widthForGlyph(), as the latter uses the former.

9:20 PM Changeset in webkit [58473] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-04-28 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Document that subprocess.poll/wait are not threadsafe
https://bugs.webkit.org/show_bug.cgi?id=38289

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
9:16 PM Changeset in webkit [58472] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

9:13 PM Changeset in webkit [58471] by mrowe@apple.com
  • 1 copy in tags/Safari-533.7

New tag.

9:13 PM Changeset in webkit [58470] by Martin Robinson
  • 9 edits in trunk

2010-04-28 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Make ClipboardGtk a "live" DataTransfer object, able to modify
the clipboard when setData(...) is called.

  • platform/gtk/Skipped: Uncomment tests that are now passing.

2010-04-28 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Make ClipboardGtk a "live" DataTransfer object, able to modify
the clipboard when setData(...) is called.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::Editor::newGeneralClipboard): Pass the GtkClipboard into the factory method. (WebCore::ClipboardGtk::ClipboardGtk): Create two separate constructors, one for DnD data and one for clipboard data. (WebCore::dataObjectTypeFromHTMLClipboardType): Added. (WebCore::ClipboardGtk::clearData): Clear the member DataObject, optionally write the clipboard. (WebCore::ClipboardGtk::clearAllData): Ditto. (WebCore::joinURIList): Added. (WebCore::ClipboardGtk::getData): Get the data from the clipboard, if possible. (WebCore::ClipboardGtk::setData): Write data to the DataObject and maybe the clipboard. (WebCore::ClipboardGtk::types): Read the clipboard/DataObject to find applicable types. (WebCore::ClipboardGtk::files): Read the clipboard/DataObject to find the files. (WebCore::ClipboardGtk::writeURL): Write to the DataObject and maybe the clipboard. (WebCore::ClipboardGtk::writeRange): Ditto. (WebCore::ClipboardGtk::writePlainText): Ditto. (WebCore::ClipboardGtk::hasData): Query the clipboard/DataObject.
  • platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create): Added one factory for pasteboard-backed DataObjects and one for DnD-backed objects.
  • platform/gtk/DataObjectGtk.cpp: (WebCore::replaceNonBreakingSpaceWithSpace): Added this helper function to clean &nbsp; from plain text. (WebCore::DataObjectGtk::markup): Actually return the range if it's set. (WebCore::DataObjectGtk::setText): Clean &nbsp; from plain text. (WebCore::DataObjectGtk::clearText): Added. (WebCore::DataObjectGtk::clearMarkup): Added.
  • platform/gtk/DataObjectGtk.h: (WebCore::DataObjectGtk::clearURIList): Added. (WebCore::DataObjectGtk::clearImage): Added.
  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::initializeTargetList): Added target ID's for URI list and Netscape URL targets. (WebCore::urisToKURLVector): Added. (WebCore::PasteboardHelper::getClipboardContents): Added. (WebCore::PasteboardHelper::fillSelectionData): Added logic for URI lists and Netscape URLs. (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
  • platform/gtk/PasteboardHelper.h: Added default argument to writeClipboardContents and new method.
8:57 PM Changeset in webkit [58469] by oliver@apple.com
  • 19 edits in trunk/JavaScriptCore

2010-04-28 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Add fast paths for Math.pow and Math.sqrt
https://bugs.webkit.org/show_bug.cgi?id=38294

Add specialized thunks for Math.pow and Math.sqrt.
This requires adding a sqrtDouble function to the MacroAssembler
and sqrtsd to the x86 assembler.

Math.pow is slightly more complicated, in that we have
to implement exponentiation ourselves rather than relying
on hardware support. The inline exponentiation is restricted
to positive integer exponents on a numeric base. Exponentiation
is finally performed through the "Exponentiation by Squaring"
algorithm.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsFloatingPointSqrt): (JSC::MacroAssemblerARM::loadDouble): (JSC::MacroAssemblerARM::sqrtDouble):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt): (JSC::MacroAssemblerARMv7::sqrtDouble):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::loadDouble): (JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::sqrtDouble):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::loadDouble): (JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::movsd_mr): (JSC::X86Assembler::sqrtsd_rr): (JSC::X86Assembler::X86InstructionFormatter::twoByteOp): (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
  • create_hash_table:
  • jit/JIT.h:
  • jit/JITInlineMethods.h:
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.h: (JSC::JITThunks::ctiNativeCallThunk):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitLoadDouble): (JSC::JSInterfaceJIT::emitJumpIfImmediateNumber): (JSC::JSInterfaceJIT::emitJumpIfNotImmediateNumber): (JSC::JSInterfaceJIT::emitLoadInt32):
  • jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::loadDoubleArgument): (JSC::SpecializedThunkJIT::loadInt32Argument): (JSC::SpecializedThunkJIT::returnJSValue): (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::finalize):
  • jit/ThunkGenerators.cpp: (JSC::sqrtThunkGenerator): (JSC::powThunkGenerator):
  • jit/ThunkGenerators.h:
  • runtime/Executable.h: (JSC::NativeExecutable::NativeExecutable):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction):
8:46 PM Changeset in webkit [58468] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-04-28 Martin Robinson <Martin Robinson>

Reviewed by Gustavo Noronha.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Use the length of the UTF-8 markup data in bytes when filling GtkSelectionData.

No new tests, because pasteboard DataTransfer tests will be enabled
with the completion of the GTK+ DataTransfer object.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::clipboard_get_contents_cb): Use strlen here instead of g_utf8_strlen.
8:11 PM Changeset in webkit [58467] by mitz@apple.com
  • 3 edits in trunk/WebCore

More of <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
https://bugs.webkit.org/show_bug.cgi?id=37936

Reviewed by Adele Peterson.

Assigning zero width and empty bounds to the ZERO WIDTH SPACE glyph often allocates a width map
page and a bounds map page for the glyph, each of which pages contains 255 unused entries. Save
this space by not storing the zero width and empty bounds in the metrics maps.

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData): Initialize m_zeroWidthSpaceGlyph.
(WebCore::SimpleFontData::platformGlyphInit): Set m_zeroWidthSpaceGlyph. Don’t create entries
for the ZERO WIDTH SPACE glyph in the width map and in the bounds map.

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::boundsForGlyph): Return empty bounds for the ZERO WIDTH SPACE glyph
without consulting the bounds map.
(WebCore::SimpleFontData::widthForGlyph): Return zero for the ZERO WIDTH SPACE glyph without
consulting the width map.

8:05 PM Changeset in webkit [58466] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7847573> Safari welcome page logs JavaScript exception during page load

Reviewed by Adele Peterson.

The Safari welcome page runs afoul of the same-origin restriction on access to stylesheet rules
that was added to address <https://bugs.webkit.org/show_bug.cgi?id=20527>. To work around this we're
adding a temporary site-specific quirk that relaxes this restriction for the particular cross-origin
access that occurs on the Safari welcome page.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::cssRules):

8:00 PM Changeset in webkit [58465] by mthole@apple.com
  • 3 edits in trunk/WebKit2

Build fix, not reviewed.

Fix WebKit2 build by stubbing out WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace().

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
7:30 PM Changeset in webkit [58464] by Chris Jerdonek
  • 5 edits in trunk/WebKitTools

Removed the dividing line (i.e. "====...") logic from the code
called by svn-apply and svn-unapply.

Reviewed by Daniel Bates.

https://bugs.webkit.org/show_bug.cgi?id=38093

The dividing line logic is unnecessary. Removing it simplifies the
code and makes some subsequent changes easier.

  • Scripts/VCSUtils.pm:
    • Removed the logic in gitdiff2svndiff() to convert the git "index" line to an SVN dividing line.
    • Adjusted the logic similarly in parseDiffHeader().
  • Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated the unit tests as necessary.
    • Corrected an error in the unit tests whereby all elements of an array were referencing the same element rather than distinct elements -- causing unit test failures to be masked.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Updated the unit tests as necessary.
    • Made the same unit test correction as above for parseDiff.pl.
7:22 PM Changeset in webkit [58463] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-04-28 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Qt build fix.

[Qt] Guard the body of the function instead of the function for
exported functions.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::webInspectorExecuteScript): (DumpRenderTreeSupportQt::webInspectorClose): (DumpRenderTreeSupportQt::webInspectorShow): (DumpRenderTreeSupportQt::setTimelineProfilingEnabled):
6:50 PM Changeset in webkit [58462] by estade@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py: adding myself as a committer
5:54 PM Changeset in webkit [58461] by mthole@apple.com
  • 5 edits
    1 add in trunk

JavaScriptCore: Reenable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK now that an
exports file for it has been added.

Reviewed by Mark Rowe.

  • wtf/Platform.h:

WebCore: Add separate exports file for symbols dependent on WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK.

Reviewed by Mark Rowe.

  • DerivedSources.make: Updated for WebCore.ProtectionSpaceAuthCallback.exp.
  • WebCore.ProtectionSpaceAuthCallback.exp: Added.
  • WebCore.xcodeproj/project.pbxproj:
5:51 PM Changeset in webkit [58460] by crogers@google.com
  • 1 edit in branches/audio/WebCore/WebCore.xcodeproj/project.pbxproj

Changes to WebCore.xcodeproj to build in audio code

5:51 PM Changeset in webkit [58459] by crogers@google.com
  • 5 edits in branches/audio/WebCore/audio

More compile fixes

5:51 PM Changeset in webkit [58458] by crogers@google.com
  • 38 edits in branches/audio/WebCore/audio

Lots of compile error fixes mostly revolving around 64bit double to 32bit float conversions

5:51 PM Changeset in webkit [58457] by crogers@google.com
  • 1 edit in branches/audio/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

Make Complex.h be in PrivateHeaders

5:51 PM Changeset in webkit [58456] by crogers@google.com
  • 2 adds in branches/audio/WebCore/audio

Although deprecated, need BiquadFilter class to get build going

5:51 PM Changeset in webkit [58455] by crogers@google.com
  • 1 edit
    1 add in branches/audio

Add Complex.h to ForwardingHeaders and JavaScriptCore project

5:50 PM Changeset in webkit [58454] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/DynamicsCompressor.h

fix compile warning with virtual methods

5:50 PM Changeset in webkit [58453] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioFloatArray.h

For now implement zero() method directly in AudioFloatArray

5:50 PM Changeset in webkit [58452] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/DynamicsCompressor.cpp

include config.h

5:50 PM Changeset in webkit [58451] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/Accelerate.h

include config.h instead of wtf/Platform.h

5:50 PM Changeset in webkit [58450] by crogers@google.com
  • 1 edit
    1 add in branches/audio

Add wtf/Vector3.h to ForwardingHeaders and JavaScriptCore project

5:50 PM Changeset in webkit [58449] by crogers@google.com
  • 3 adds in branches/audio/WebCore/audio

temporarily add old AudioEffect class (although deprecated still needed in places)

5:50 PM Changeset in webkit [58448] by crogers@google.com
  • 1 edit in branches/audio/WebCore/DerivedSources.make

Add audio directory to search path

5:38 PM Changeset in webkit [58447] by evan@chromium.org
  • 5 edits in trunk

2010-04-28 Evan Martin <evan@chromium.org>

Reviewed by David Levin.

[chromium] revert getFontDataForCharacters change in r58341
https://bugs.webkit.org/show_bug.cgi?id=38288

  • platform/chromium/test_expectations.txt: add the test to the now-failing list.

2010-04-28 Evan Martin <evan@chromium.org>

Reviewed by David Levin.

[chromium] revert getFontDataForCharacters change in r58341
https://bugs.webkit.org/show_bug.cgi?id=38288

It caused a performance regression.

  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
5:34 PM Changeset in webkit [58446] by eric@webkit.org
  • 4 edits
    3 deletes in trunk

2010-04-28 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r58441.
http://trac.webkit.org/changeset/58441
https://bugs.webkit.org/show_bug.cgi?id=37618

Broke 3 test on Qt.

  • editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Removed.
  • editing/pasteboard/drag-drop-iframe-refresh-crash.html: Removed.
  • editing/resources/drag-drop.html: Removed.

2010-04-28 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r58441.
http://trac.webkit.org/changeset/58441
https://bugs.webkit.org/show_bug.cgi?id=37618

Broke 3 test on Qt.

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::concludeEditDrag):
  • page/DragController.h: (WebCore::DragController::setDragInitiator): (WebCore::DragController::dragInitiator): (WebCore::DragController::documentUnderMouse):
5:22 PM Changeset in webkit [58445] by Darin Adler
  • 8 edits in trunk/WebCore

2010-04-28 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Remove some obsolete scrolling code
https://bugs.webkit.org/show_bug.cgi?id=38293

  • page/Chrome.cpp: (WebCore::Chrome::scrollRectIntoView): Removed ScrollView* argument.
  • page/Chrome.h: Made scrollRectIntoView non-virtual, and removed ScrollView* argument.
  • page/FrameView.cpp: Removed scrollRectIntoViewRecursively.
  • page/FrameView.h: Removed scrollRectIntoViewRecursively and made setScrollPosition non-virtual, since there is no class derived from this class, and ScrollView's setScrollPosition is non-virtual.
  • platform/HostWindow.h: Removed scrollRectIntoView.
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): Updated comment since I was able to do most of the tasks listed here.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Removed 0 passed for ScrollView* argument to Chrome::scrollRectIntoView.
5:14 PM Changeset in webkit [58444] by mthole@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix, not reviewed.

  • wtf/Platform.h:

Disable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK until an exports file is created.

4:58 PM Changeset in webkit [58443] by weinig@apple.com
  • 7 edits in trunk

.: Add WebKit2 to the lists of modules to build.

Reviewed by Mark Rowe.

  • Makefile:

WebKit2: Only build on SnowLeopard and later when using the Makefile.

Reviewed by Mark Rowe.

  • Makefile:

WebKitTools: Add MiniBrowser to the lists of modules to build and only build it on
SnowLeopard and later.

Reviewed by Mark Rowe.

  • Makefile:
  • MiniBrowser/Makefile:
4:16 PM Changeset in webkit [58442] by mthole@apple.com
  • 21 edits in trunk

Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
can be inspected before attempting to authenticate against it
https://bugs.webkit.org/show_bug.cgi?id=38271

Reviewed by David Kilzer.

JavaScriptCore:

  • wtf/Platform.h: Add WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK define.

WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Added.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::canAuthenticateAgainstProtectionSpace): Added.

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.

  • platform/network/ProtectionSpace.h:

(WebCore::):

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpace): Added.

  • platform/network/mac/AuthenticationMac.mm:

(WebCore::mac):
Add cases for case ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested and
ProtectionSpaceAuthenticationSchemeClientCertificateRequested. Guarded with the
#if USE(PROTECTION_SPACE_AUTH_CALLBACK) as the new NSURLProtectionSpace constants don't
exist prior to Mac OS X 10.6.
(WebCore::core): Ditto.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): Added.
(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Added.

WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
Added. If the resource load delegate implements the callback, use its answer. If it does
not, then only send authentication challenges for pre-10.6 protection spaces, which matches
CFNetwork's default behavior.

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebDelegateImplementationCaching.mm:

(CallResourceLoadDelegateReturningBoolean): Added case for passing three objects.

  • WebView/WebResourceLoadDelegatePrivate.h:

Added private SPI definition: webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:

  • WebView/WebView.mm:

(-[WebView _cacheResourceLoadDelegateImplementations]):

3:48 PM Changeset in webkit [58441] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2010-04-28 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Tests for a crash when an image drag-drop operation happens inside a continuously refreshing iframe.
https://bugs.webkit.org/show_bug.cgi?id=37618

  • editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Added.
  • editing/pasteboard/drag-drop-iframe-refresh-crash.html: Added.
  • editing/resources/drag-drop.html: Added.

2010-04-28 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
Eliminated unused m_dragInitiator accessor to prevent dereferencing.
https://bugs.webkit.org/show_bug.cgi?id=37618

Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::concludeEditDrag):
  • page/DragController.h: (WebCore::DragController::draggingImageURL): (WebCore::DragController::documentUnderMouse):
3:33 PM Changeset in webkit [58440] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, fixing a build problem introduced by the previous patch.

  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):

3:28 PM Changeset in webkit [58439] by agl@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-04-28 Adam Langley <agl@chromium.org>

Unreviewed, expectations update.

These results are no longer specific to chromium-win. I believe that
they should have been deleted in r58182, but I didn't notice the
deletions, only the modified files.

  • platform/chromium-win/fast/canvas/canvas-empty-image-pattern-expected.checksum: Removed.
  • platform/chromium-win/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
3:17 PM Changeset in webkit [58438] by weinig@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.

Reviewed by Mark Rowe.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/make-launchable.sh: Added.
3:17 PM Changeset in webkit [58437] by dumi@chromium.org
  • 7 edits
    5 adds in trunk/WebCore

Adding some required classes for the sync WebSQLDatabases API.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Jeremy Orlow.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/DatabaseSync.cpp: Added.

(WebCore::DatabaseSync::databaseInfoTableName):
(WebCore::DatabaseSync::setIsAvailable):
(WebCore::DatabaseSync::isAvailable):
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::version):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):

  • storage/DatabaseSync.h: Added.

(WebCore::DatabaseSync::databaseDebugName):

  • storage/SQLTransactionSync.cpp: Added.

(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::~SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):

  • storage/SQLTransactionSync.h: Added.

(WebCore::SQLTransactionSync::database):
(WebCore::SQLTransactionSync::isReadOnly):

  • storage/SQLTransactionSyncCallback.h: Added.

(WebCore::SQLTransactionSyncCallback::~SQLTransactionSyncCallback):

3:05 PM Changeset in webkit [58436] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-28 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Simon Hausmann.

Fix compilation with QT_NO_CURSOR defined.

  • platform/qt/QWebPageClient.h: (QWebPageClient::resetCursor): (QWebPageClient::setCursor):
2:53 PM Changeset in webkit [58435] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2010-04-28 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

fix linux expected result for fast/text/line-breaks.html
https://bugs.webkit.org/show_bug.cgi?id=38283

This is needed after r58426. See http://trac.webkit.org/changeset/57242
for more details.

  • platform/chromium-linux/fast/text/line-breaks-expected.checksum:
  • platform/chromium-linux/fast/text/line-breaks-expected.png:
  • platform/chromium-linux/fast/text/line-breaks-expected.txt:
2:51 PM Changeset in webkit [58434] by eric@webkit.org
  • 14 edits
    1 copy in trunk/WebKitTools

2010-04-28 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Audit all uses of subprocess in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=38284

After further discussions with Jeffrey Yasskin
about http://bugs.python.org/issue2320
and related issues of using subprocess from
multiple threads, I have learned that subprocess
is known to be non-threadsafe through recent
Python 2.7 builds.

I'm attempting to lessen our exposure to these
subprocess bugs by auditing each use of subprocess
in webkitpy. I did not find any unsafe calls
in my audit, but I did remove numerous unneeded
import subprocess lines.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
2:42 PM Changeset in webkit [58433] by ap@apple.com
  • 3 edits
    4 adds in trunk

Reviewed by Alexey Proskuryakov.

Added a check to make sure that resources from a different https origin are not cached.
https://bugs.webkit.org/show_bug.cgi?id=33456

Test: http/tests/appcache/different-https-origin-resource-main.html

  • loader/appcache/ManifestParser.cpp: (WebCore::parseManifest):
2:23 PM Changeset in webkit [58432] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2010-04-28 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

<rdar://problem/7918719> ASSERT(isMainThread()) from Font::setShouldUseSmoothing()

Ensure that the WebView +initialize method initializes threading, so that things are correctly
initialized when the first call into the WebKit framework is via a WebView class method.

  • WebView/WebView.mm: (+[WebView initialize]):
2:19 PM Changeset in webkit [58431] by weinig@apple.com
  • 2 edits in trunk/WebCore

Only set -allowable_client WebKit2 for engineering builds on SnowLeopard
and later.

Reviewed by Mark Rowe.

  • Configurations/WebCore.xcconfig:
2:04 PM Changeset in webkit [58430] by evan@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-04-28 Evan Martin <evan@chromium.org>

Reviewed by Adam Roben.

rebaseline for fast/text/international/bold-bengali
https://bugs.webkit.org/show_bug.cgi?id=38281

  • platform/win/fast/text/international/bold-bengali-actual.txt: Added.
2:02 PM Changeset in webkit [58429] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Don't use CFAbsoluteTimeGetCurrent on Mac OS X, since it's just a cover
for gettimeofday anyway.

Reviewed by Sam Weinig.

  • wtf/CurrentTime.cpp:

(WTF::currentTime): Remove the CF version of this. Change the "other POSIX"
version to pass 0 for the time zone instead of ignoring a return value.
Also get rid of unneeded type casts, since operations involving both
integers and doubles are always evaluated as doubles in C without explicit
type casting.

1:57 PM Changeset in webkit [58428] by Darin Adler
  • 7 edits in trunk

2010-04-28 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

REGRESSION: Autoscroll does not work in Mail messages
https://bugs.webkit.org/show_bug.cgi?id=38267
rdar://problem/7559799

The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
view had gotten broken in multiple ways. For some reason, a combination of bugs made it
partly work until around r48064. This brings it back.

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scrollRectIntoView): When converting coordinates, use the document view rather than the WebView itself. This logic may not be correct for the case where usesDocumentViews is NO, but that is currently an experimental mode and can be fixed later.

2010-04-28 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

REGRESSION: Autoscroll does not work in Mail messages
https://bugs.webkit.org/show_bug.cgi?id=38267
rdar://problem/7559799

Still haven't figured out a good way to test this with DumpRenderTree
or with Safari. Testing has to be done with Mail for now.

The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
view had gotten broken in multiple ways. For some reason, a combination of bugs made it
partly work until around r48064. This brings it back.

There were three problems:

1) Code in EventHandler decided there was nothing to scroll, so didn't start

the autoscroll timer.

2) The wrong rectangle was passed to Chrome::scrollRectIntoView.
3) The Mac WebKit implementation of ChromeClient::scrollRectIntoView did incorrect

coordinate conversion.

I verified that none of these have any effect on regression tests, or behavior in
web browsers, or behavior on platforms other than Mac.

  • page/EventHandler.cpp: (WebCore::canAutoscroll): Added. Returns true for boxes that can scroll directly and for the top level box of the top frame. (WebCore::EventHandler::handleMouseDraggedEvent): Use canAutoscroll. (WebCore::EventHandler::updateAutoscrollRenderer): Ditto.
  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor): Fixed comment.
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively): Put ASSERT_NOT_REACHED into this now-unused function along with some comments about removing some obsolete code.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Removed call to scrollRectIntoViewRecursively since from the WebKit point of view this is the topmost scroll view anyway. Instead call setScrollPosition. Moved the code to call Chrome::scrollRectIntoView here since it needs to use a different rectangle anyway.
1:50 PM Changeset in webkit [58427] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] tst_QWebHistoryInterface::visitedLinks() fails
https://bugs.webkit.org/show_bug.cgi?id=37323

Patch by Antonio Gomes <tonikitoo@webkit.org>, Yi Shen <yi.4.shen@nokia.com> on 2010-04-28
Reviewed by NOBODY Simon Hausmann.

Patch fixes styleProperty method of QWebElement to make use of
CSSComputedStyleDeclaration::computedStyle 'allowVisitedStyle' parameter
and the corresponding failing QWebHistoryInterface::visitedLinks method.

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

  • tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp:

(tst_QWebHistoryInterface::visitedLinks):

1:50 PM Changeset in webkit [58426] by ojan@chromium.org
  • 5 edits in trunk

2010-04-21 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

http://trac.webkit.org/changeset/57215 caused perf/memory regressions
https://bugs.webkit.org/show_bug.cgi?id=37292

#if out the canUseGlyphCache Changes from r57215 as they caused a
8% perf regression on Chromium's international page load tests so that
the perf regression can be fixed properly without being left in the tree.

  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
  • platform/mac/fast/repaint/stacked-diacritics-expected.png:

2010-04-21 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

http://trac.webkit.org/changeset/57215 caused perf/memory regressions
https://bugs.webkit.org/show_bug.cgi?id=37292

#if out the canUseGlyphCache Changes from r57215 as they caused a
8% perf regression on Chromium's international page load tests so that
the perf regression can be fixed properly without being left in the tree.

  • platform/graphics/FontFastPath.cpp: (WebCore::Font::canUseGlyphCache):
1:35 PM Changeset in webkit [58425] by darin@chromium.org
  • 8 edits in trunk

2010-04-28 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[Chromium] callOnMainThread should equate to MessageLoop::PostTask
https://bugs.webkit.org/show_bug.cgi?id=38276

  • JavaScriptCore.gyp/JavaScriptCore.gyp:
  • wtf/MainThread.cpp:
  • wtf/chromium/ChromiumThreading.h:
  • wtf/chromium/MainThreadChromium.cpp: (WTF::initializeMainThread): (WTF::callOnMainThread): (WTF::callOnMainThreadAndWait): (WTF::setMainThreadCallbacksPaused): (WTF::isMainThread):
1:30 PM Changeset in webkit [58424] by ap@apple.com
  • 5 edits in trunk/LayoutTests

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=38278
https://localhost:8443 doesn't work in WebKit tests

We only had a VirtualHost for 127.0.0.1:8443. Changed that to *:8443.

  • http/conf/apache2-debian-httpd.conf:
  • http/conf/apache2-httpd.conf:
  • http/conf/fedora-httpd.conf:
  • http/conf/httpd.conf:
12:48 PM Changeset in webkit [58423] by Beth Dakin
  • 8 edits in trunk

Fix for <rdar://problem/7474349>

Reviewed by Darin Adler.

Add a synchronous display mechanism for WKCACFLayerRenderer.

WebCore:

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::setRootContentsAndDisplay): This is
just like setRootContents(), but it calls paint() instead of
renderSoon().

  • platform/graphics/win/WKCACFLayerRenderer.h:

WebKit/win:

  • Interfaces/IWebViewPrivate.idl:
  • Interfaces/WebKit.idl:
  • WebView.cpp:

(WebView::WebView):
(WebView::updateRootLayerContents):
(WebView::nextDisplayIsSynchronous):

  • WebView.h:
12:42 PM Changeset in webkit [58422] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-27 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Make WebThemeEngine::paint take a const ref of ExtraParams
https://bugs.webkit.org/show_bug.cgi?id=38242

  • public/WebThemeEngine.h: (WebKit::WebThemeEngine::paint):
12:39 PM Changeset in webkit [58421] by dimich@chromium.org
  • 9 edits in trunk/WebCore

REGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=37554

Reviewed by Geoffrey Garen.

The flaky fast/workers/wrapper-map-gc.html will stop being flaky.

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):
check if JS execution was terminated, as in cases of Worker.terminate() or WorkerGlobalScope.close().

  • bindings/js/JSWorkerContextBase.cpp:

(WebCore::toJS): ASSERT the value of workerContextWrapper, it should never be 0.

  • bindings/js/WorkerScriptController.h:

(WebCore::WorkerScriptController::workerContextWrapper): remove returning 0 if JS execution was forbidden.
(WebCore::WorkerScriptController::isExecutionForbidden):

  • bindings/v8/WorkerScriptController.h:

(WebCore::WorkerScriptController::isExecutionForbidden):

Add ScriptExecutionContext::isJSExecutionTerminated(), it is always 'false' for Document
and 'true' for WorkerContext when script is terminated.

  • dom/ScriptExecutionContext.h:
  • dom/Document.h:

(WebCore::Document::isJSExecutionTerminated):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::isJSExecutionTerminated):

  • workers/WorkerContext.h:
12:24 PM Changeset in webkit [58420] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Multiple Main Resource Content Loaded marks appear in Resource panel.
https://bugs.webkit.org/show_bug.cgi?id=38270

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
12:15 PM Changeset in webkit [58419] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Timeline: We can have precise urls in the EvaluateScript records.
https://bugs.webkit.org/show_bug.cgi?id=38264

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
11:36 AM Changeset in webkit [58418] by crogers@google.com
  • 4 adds in branches/audio/WebCore/audio

Add biquad filter files

11:35 AM Changeset in webkit [58417] by alex
  • 2 edits in trunk/LayoutTests

2010-04-28 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Failing test http/tests/misc/isindex-with-no-form.html
https://bugs.webkit.org/show_bug.cgi?id=30815

The test currently works, removing from Skipped.

  • platform/gtk/Skipped:
  • platform/gtk/Skipped:
11:25 AM Changeset in webkit [58416] by evan@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-04-28 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

fast/text/international/bold-bengali needs baselines
https://bugs.webkit.org/show_bug.cgi?id=38273

  • platform/chromium-win/fast/text/international/bold-bengali-expected.checksum: Added.
  • platform/chromium-win/fast/text/international/bold-bengali-expected.png: Added.
  • platform/mac/fast/text/international/bold-bengali-expected.checksum: Added.
  • platform/mac/fast/text/international/bold-bengali-expected.png: Added.
10:54 AM Changeset in webkit [58415] by xji@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-04-28 Xiaomei Ji <xji@chromium.org>

Reviewed by Dimitri Glazkov

Rebaseline Webkit Mac pixel results and chromium pixel results
caused by http://trac.webkit.org/changeset/58191
Webkit Mac pixel results failed with --tolerance=0
https://bugs.webkit.org/show_bug.cgi?id=38104

  • platform/chromium-linux/editing/deleting/4845371-expected.checksum:
  • platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/5126166-expected.checksum:
  • platform/chromium-linux/editing/deleting/5126166-expected.png:
  • platform/chromium-linux/editing/deleting/5483370-expected.checksum:
  • platform/chromium-linux/editing/deleting/5483370-expected.png:
  • platform/chromium-linux/editing/deleting/table-cells-expected.checksum:
  • platform/chromium-linux/editing/deleting/table-cells-expected.png: Removed.
  • platform/chromium-linux/editing/inserting/4875189-2-expected.checksum:
  • platform/chromium-linux/editing/inserting/4875189-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/5387578-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/5387578-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed.
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png: Removed.
  • platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.checksum:
  • platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/caret-outside-block-expected.checksum:
  • platform/chromium-linux/fast/repaint/caret-outside-block-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/4845371-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5126166-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5483370-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added.
  • platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Added.
  • platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/caret-outside-block-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/caret-outside-block-expected.png: Added.
  • platform/chromium-win/editing/deleting/4845371-expected.checksum:
  • platform/chromium-win/editing/deleting/4845371-expected.png:
  • platform/chromium-win/editing/deleting/5126166-expected.checksum:
  • platform/chromium-win/editing/deleting/5126166-expected.png:
  • platform/chromium-win/editing/deleting/5483370-expected.checksum:
  • platform/chromium-win/editing/deleting/5483370-expected.png:
  • platform/chromium-win/editing/deleting/table-cells-expected.checksum:
  • platform/chromium-win/editing/deleting/table-cells-expected.png:
  • platform/chromium-win/editing/inserting/4875189-2-expected.checksum:
  • platform/chromium-win/editing/inserting/4875189-2-expected.png:
  • platform/chromium-win/editing/pasteboard/5387578-expected.checksum:
  • platform/chromium-win/editing/pasteboard/5387578-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-table-cells-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.checksum:
  • platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/chromium-win/fast/repaint/caret-outside-block-expected.checksum:
  • platform/chromium-win/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/editing/deleting/4845371-expected.png:
  • platform/mac/editing/deleting/5126166-expected.png:
  • platform/mac/editing/deleting/5483370-expected.png:
  • platform/mac/editing/deleting/table-cells-expected.png:
  • platform/mac/editing/inserting/4875189-2-expected.png:
  • platform/mac/editing/pasteboard/5387578-expected.png:
  • platform/mac/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/mac/editing/pasteboard/paste-table-001-expected.png:
  • platform/mac/editing/pasteboard/paste-table-cells-expected.png:
  • platform/mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/mac/fast/repaint/caret-outside-block-expected.png:
10:53 AM Changeset in webkit [58414] by xji@chromium.org
  • 55 edits
    13 adds
    7 deletes in trunk/LayoutTests

2010-04-28 Xiaomei Ji <xji@chromium.org>

Reviewed by Dimitri Glazkov

Rebaseline Webkit Mac pixel results and chromium pixel results
caused by http://trac.webkit.org/changeset/58191
Webkit Mac pixel results failed with --tolerance=0

  • platform/chromium-linux/editing/deleting/4845371-expected.checksum:
  • platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/5126166-expected.checksum:
  • platform/chromium-linux/editing/deleting/5126166-expected.png:
  • platform/chromium-linux/editing/deleting/5483370-expected.checksum:
  • platform/chromium-linux/editing/deleting/5483370-expected.png:
  • platform/chromium-linux/editing/deleting/table-cells-expected.checksum:
  • platform/chromium-linux/editing/deleting/table-cells-expected.png: Removed.
  • platform/chromium-linux/editing/inserting/4875189-2-expected.checksum:
  • platform/chromium-linux/editing/inserting/4875189-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/5387578-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/5387578-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed.
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png: Removed.
  • platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.checksum:
  • platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/caret-outside-block-expected.checksum:
  • platform/chromium-linux/fast/repaint/caret-outside-block-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/4845371-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5126166-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/5483370-expected.checksum: Added.
  • platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added.
  • platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Added.
  • platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/caret-outside-block-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/caret-outside-block-expected.png: Added.
  • platform/chromium-win/editing/deleting/4845371-expected.checksum:
  • platform/chromium-win/editing/deleting/4845371-expected.png:
  • platform/chromium-win/editing/deleting/5126166-expected.checksum:
  • platform/chromium-win/editing/deleting/5126166-expected.png:
  • platform/chromium-win/editing/deleting/5483370-expected.checksum:
  • platform/chromium-win/editing/deleting/5483370-expected.png:
  • platform/chromium-win/editing/deleting/table-cells-expected.checksum:
  • platform/chromium-win/editing/deleting/table-cells-expected.png:
  • platform/chromium-win/editing/inserting/4875189-2-expected.checksum:
  • platform/chromium-win/editing/inserting/4875189-2-expected.png:
  • platform/chromium-win/editing/pasteboard/5387578-expected.checksum:
  • platform/chromium-win/editing/pasteboard/5387578-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-table-cells-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.checksum:
  • platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/chromium-win/fast/repaint/caret-outside-block-expected.checksum:
  • platform/chromium-win/fast/repaint/caret-outside-block-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/editing/deleting/4845371-expected.png:
  • platform/mac/editing/deleting/5126166-expected.png:
  • platform/mac/editing/deleting/5483370-expected.png:
  • platform/mac/editing/deleting/table-cells-expected.png:
  • platform/mac/editing/inserting/4875189-2-expected.png:
  • platform/mac/editing/pasteboard/5387578-expected.png:
  • platform/mac/editing/pasteboard/paste-4039777-fix-expected.png:
  • platform/mac/editing/pasteboard/paste-table-001-expected.png:
  • platform/mac/editing/pasteboard/paste-table-cells-expected.png:
  • platform/mac/editing/selection/move-past-trailing-space-expected.png:
  • platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png:
  • platform/mac/fast/repaint/caret-outside-block-expected.png:
10:14 AM Changeset in webkit [58413] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-04-28 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Fixed passing breakpoints to V8.
https://bugs.webkit.org/show_bug.cgi?id=38266

  • src/js/InspectorControllerImpl.js: (.devtools.InspectorBackendImpl.prototype.setBreakpoint):
10:10 AM Changeset in webkit [58412] by pfeldman@chromium.org
  • 10 edits in trunk/WebCore

2010-04-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Linkify node and function in the event listeners panel.

https://bugs.webkit.org/show_bug.cgi?id=38251

  • bindings/js/ScriptEventListener.cpp: (WebCore::eventListenerHandlerBody): (WebCore::eventListenerHandlerLocation):
  • bindings/js/ScriptEventListener.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::eventListenerHandlerBody): (WebCore::eventListenerHandlerLocation):
  • bindings/v8/ScriptEventListener.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForEventListener):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeReference): (WebInspector.ElementsPanel.prototype.linkifyNodeReference.preventDefault):
  • inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update): ():
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
  • inspector/front-end/inspector.css: (.node-link):
9:56 AM Changeset in webkit [58411] by Darin Adler
  • 2 edits in trunk/WebKitTools

Ignore a directory the Python tools creates.

  • Scripts/webkitpy/style: Modified property svn:ignore.
9:44 AM Changeset in webkit [58410] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/extract-localizable-strings: Fix minor mistake in

argument checking.

9:29 AM Changeset in webkit [58409] by jchaffraix@webkit.org
  • 5 edits
    5 adds in trunk

[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html

http/tests/xmlhttprequest/access-control-preflight-credential-sync.html

Rolling the patch in as I could not reproduce Qt results locally.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.

LayoutTests:

Test that doing a cross-origin request with a preflight check does
not raise a NETWORK_ERR exception and does not send the credentials.

  • http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
  • http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.
  • platform/mac-tiger/Skipped:
  • platform/qt/Skipped:

Added those 2 tests to the Skipped lists.

8:49 AM weinre-src.zip attached to WebInspector by pmuellr@yahoo.com
archive containing the source for the weinre experiment
8:49 AM weinre.zip attached to WebInspector by pmuellr@yahoo.com
archive containing a runnable demo of weinre
8:47 AM WebInspector edited by pmuellr@yahoo.com
add info about the weinre experiment (diff)
7:23 AM Changeset in webkit [58408] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-28 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: preserves-3d and backface visibility
https://bugs.webkit.org/show_bug.cgi?id=35312

Implement preserves-3d by maintaining the 3D transformation heirarchy inside GraphicsLayerQt, and extrapolating
the relative QTransform. When the extrapolation fails (un-invertible matrix) we ignore the transformation change.

WebKitSite/blog-files/3d-transforms test now work with Qt.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::updateTransform): (WebCore::GraphicsLayerQtImpl::opaqueArea): (WebCore::GraphicsLayerQtImpl::boundingRect): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
6:58 AM Changeset in webkit [58407] by eric@webkit.org
  • 2 edits
    12 adds in trunk/LayoutTests

2010-04-28 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] Rebaseline svg-background-partial-redraw, node-iterator-prototype, and upstream test expectations for fast/text/international/bold-bengali.html
https://bugs.webkit.org/show_bug.cgi?id=38259

  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-mac/fast/images: Added.
  • platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-mac/traversal: Added.
  • platform/chromium-mac/traversal/node-iterator-prototype-expected.txt: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Added.
  • platform/chromium-win/traversal: Added.
  • platform/chromium-win/traversal/node-iterator-prototype-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:49 AM Changeset in webkit [58406] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: View frame selector for Timeline overview panel is redesigned a bit.
Now it is possible to adjust view frame by resizer bars and by click-n-drag in overview pane.
https://bugs.webkit.org/show_bug.cgi?id=38251

  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype.reset): (WebInspector.TimelineOverviewPane.prototype._dragWindow): (WebInspector.TimelineOverviewPane.prototype._windowSelectorDragging): (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging): (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft): (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight): (WebInspector.TimelineOverviewPane.prototype._setWindowPosition): (WebInspector.TimelinePanel.WindowSelector): (WebInspector.TimelinePanel.WindowSelector.prototype._createSelectorElement): (WebInspector.TimelinePanel.WindowSelector.prototype._close): (WebInspector.TimelinePanel.WindowSelector.prototype._updatePosition):
  • inspector/front-end/inspector.css: (#timeline-overview-grid): (.timeline-window-selector): (#timeline-overview-window): (.timeline-overview-dividers-background): (.timeline-overview-window-rulers): (.timeline-window-resizer):
5:58 AM Changeset in webkit [58405] by eric@webkit.org
  • 6 edits in trunk

2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
https://bugs.webkit.org/show_bug.cgi?id=38119

Replacing method qt_wrt_setViewMode by wrt_viewMode property.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::event):
  • Api/qwebpage_p.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::wrt_viewModes):

2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
https://bugs.webkit.org/show_bug.cgi?id=38119

Replacing method qt_wrt_setViewMode by wrt_viewMode property.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):
5:53 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
4:58 AM Changeset in webkit [58404] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-04-28 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Reverts 58340 (https://bugs.webkit.org/show_bug.cgi?id=38158) due to regression on fast/text/international/khmer-selection.html
https://bugs.webkit.org/show_bug.cgi?id=38254

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::adjustTextRenderMode): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::isCoordinateSkiaSafe): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
4:49 AM Changeset in webkit [58403] by eric@webkit.org
  • 13 edits
    5 adds
    1 delete in trunk

2010-04-28 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Log error message to inspector console if a resource fails to load.
Moved console-tests.js to http tests. Added support for sorting
console messages, in case order may vary.
https://bugs.webkit.org/show_bug.cgi?id=37215

  • http/tests/inspector/console-resource-errors-expected.txt: Added.
  • http/tests/inspector/console-resource-errors.html: Added.
  • http/tests/inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontend_dumpConsoleMessages):
  • inspector/console-clear.html:
  • inspector/console-dir.html:
  • inspector/console-dirxml.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-collections.html:
  • inspector/console-format.html:
  • inspector/console-log-before-inspector-open.html:
  • inspector/console-tests.html:
  • inspector/console-tests.js: Removed.
  • platform/mac-tiger/http/tests/inspector: Added.
  • platform/mac-tiger/http/tests/inspector/console-resource-errors-expected.txt: Added.

2010-04-28 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Log error message to inspector console if a resource fails to load.
Disable checking of mime-type consistency for failed resources.
https://bugs.webkit.org/show_bug.cgi?id=37215

Test: http/tests/inspector/console-resource-errors.html

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
4:39 AM Changeset in webkit [58402] by eric@webkit.org
  • 5 edits in trunk

2010-04-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Support pause on exceptions in v8 implementation of ScriptDebugServer.

https://bugs.webkit.org/show_bug.cgi?id=38205

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::currentCallFrame): (WebCore::ScriptDebugServer::handleV8DebugMessage): (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • bindings/v8/ScriptDebugServer.h:

2010-04-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Support pause on exceptions in v8 implementation of ScriptDebugServer.

https://bugs.webkit.org/show_bug.cgi?id=38205

  • src/js/DebuggerScript.js: (debuggerScriptConstructor.DebuggerScript.getScripts): (debuggerScriptConstructor.DebuggerScript.pauseOnExceptionsState): (debuggerScriptConstructor.DebuggerScript.setPauseOnExceptionsState): (debuggerScriptConstructor.DebuggerScript._v8ToWebkitLineNumber): (debuggerScriptConstructor):
4:19 AM Changeset in webkit [58401] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-28 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Adjusted check-webkit-style so that files with file type NONE
are automatically skipped without warning.

https://bugs.webkit.org/show_bug.cgi?id=38197

This change simplifies configuring which files to skip. It also
addresses an issue whereby check-webkit-style was unintentionally
checking .vcproj files for carriage returns.

  • Scripts/webkitpy/style/checker.py:
    • Moved the C++, Python, and text file extensions to new module-level configuration variables.
    • Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration variable.
    • Changed the numeric values of the FileType enum so that FileType.NONE evaluates to False.
    • For ProcessorDispatcher.should_skip_without_warning():
      • Changed the method to return True for FileType.NONE files.
      • Made ChangeLog files an exception to getting skipped.
    • Changed the StyleProcessor.process() method to raise an exception if given a file path that should not be processed.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the unit tests and added more test cases as necessary.
3:57 AM Changeset in webkit [58400] by jorlow@chromium.org
  • 6 edits
    4 deletes in trunk

2010-04-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r58313.
http://trac.webkit.org/changeset/58313
https://bugs.webkit.org/show_bug.cgi?id=38253

Regression evident in pixel tests: the search icon is always
clipped at the bottom. (Requested by jorlow on #webkit).

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::controlClipRect):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::hasControlClip):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint):
  • rendering/RenderTextControlSingleLine.h:

2010-04-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r58313.
http://trac.webkit.org/changeset/58313
https://bugs.webkit.org/show_bug.cgi?id=38253

Regression evident in pixel tests: the search icon is always
clipped at the bottom. (Requested by jorlow on #webkit).

  • fast/css/input-search-padding.html: Removed.
  • platform/mac/fast/css/input-search-padding-expected.checksum: Removed.
  • platform/mac/fast/css/input-search-padding-expected.png: Removed.
  • platform/mac/fast/css/input-search-padding-expected.txt: Removed.
3:54 AM QtWebKitBugs edited by jocelyn.turcotte@nokia.com
(diff)
3:32 AM Changeset in webkit [58399] by Simon Hausmann
  • 1 edit in trunk/WebCore/inspector/InspectorFrontend.cpp

Removed execute permissions from WebCore/inspector/InspectorFrontend.cpp

3:29 AM Changeset in webkit [58398] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed. Disable printing/media-queries-print for now.

Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203

  • platform/mac/Skipped:
3:09 AM Changeset in webkit [58397] by ukai@chromium.org
  • 10 edits in trunk/WebKitTools

2010-04-28 Eric Seidel <eric@webkit.org>

Reviewed by Jeremy Orlow.

webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',)
https://bugs.webkit.org/show_bug.cgi?id=38248

The previous code did not check the return code of taskkill.
When I moved that callsite from using subprocess.call to
Executive.run_command having a non-zero return code became an error.

In this change I've centralized our killall handling in executive,
and added tests for it to make sure it works.

Currently kill_process and kill_all swallow exceptions in the cases
where the process(es) to be killed do(es) not exist.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
2:58 AM Changeset in webkit [58396] by hamaji@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed. Added missing expectation files missed in r58386.

Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203

  • platform/mac/printing/media-queries-print-expected.checksum: Added.
  • platform/mac/printing/media-queries-print-expected.png: Added.
  • platform/mac/printing/media-queries-print-expected.txt: Added.
2:44 AM Changeset in webkit [58395] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-28 Eric Seidel <eric@webkit.org>

Reviewed by Shinichiro Hamaji.

wdiff_text throws ScriptError because wdiff returns non-zero when files differ
https://bugs.webkit.org/show_bug.cgi?id=38246

wdiff returns 0 when files are the same, 1 when they differ.
run_command by default raises ScriptError if the return code is non-zero.
Fixed this by adding a custom error handler which only raises if the
return code is not 1.

I broke up the huge wdiff_text() method into little pieces
for easier unit testing. There is only one functional change here
and that is the addition of the custom error handler.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
2:21 AM Changeset in webkit [58394] by ukai@chromium.org
  • 3 edits in trunk/WebKitTools

Unreviewed build fix.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::willSendRequest): too few arguments for format.

2:06 AM Changeset in webkit [58393] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

JSC's currentThreadStackBase is not reentrant on some platforms
https://bugs.webkit.org/show_bug.cgi?id=37195

Patch by Simon Hausmann <simon.hausmann@nokia.com>, Kent Hansen <kent.hansen@nokia.com> on 2010-04-28
Reviewed by Darin Adler.

This function needs to be reentrant to avoid memory corruption on platforms where
the implementation uses global variables.

This patch adds a mutex lock where necessary and makes the Symbian implementation
reentrant.

  • runtime/Collector.cpp:

(JSC::currentThreadStackBaseMutex):
(JSC::currentThreadStackBase):

1:55 AM Changeset in webkit [58392] by Simon Hausmann
  • 3 edits in trunk/JavaScriptCore

Fix compilation with gcc 3.4.

Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2010-04-28
Reviewed by Simon Hausmann.

AtomicStringImpl.h:29: error: base `WebCore::StringImpl' with only
non-default constructor in class without a constructor

  • wtf/text/AtomicStringImpl.h:

(WebCore::AtomicStringImpl::AtomicStringImpl): Provide a default constructor.

  • wtf/text/StringImpl.h: Allow AtomicStringImpl to call a StringImpl constructor through a friend declaration.
1:31 AM Changeset in webkit [58391] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] WINS DEF file freeze

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-04-28
Reviewed by Simon Hausmann <simon.hausmann@nokia.com>

Updated WINSCW def file with added and removed symbols.

  • symbian/bwins/QtWebKitu.def:
1:29 AM Changeset in webkit [58390] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix detection of Qt 4.7's multimedia libraries

Patch by Justin McPherson <justin.mcpherson@nokia.com> on 2010-04-28
Reviewed by Simon Hausmann.

QtMultimedia has been split into an additional media services library, which
we're using. mediaservices depends on multimedia.

  • WebCore.pro:
12:49 AM Changeset in webkit [58389] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed attempt to fix the chromium build.

Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203

  • rendering/RenderTreeAsText.cpp:
12:47 AM Changeset in webkit [58388] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-04-28 Daniel Bates <dbates@rim.com>

Unreviewed, rebase expected result of failing test.

Rebasing Qt expected result for selection-gap-overflow-scroll-2.html.
Following the landing of bug #37686, this test started failing despite
being unrelated to this bug. From looking at the diff of the result,
which shows a 1 pixel shift in widths, and based on Csaba Osztrogonac's
comment, we have decided to rebase this result.

  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
12:33 AM Changeset in webkit [58387] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

WebView drawing code may access null backing store dirty region
https://bugs.webkit.org/show_bug.cgi?id=38245
<rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)

Reviewed by Maciej Stachowiak.

  • WebView.cpp:

(WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.

12:30 AM Changeset in webkit [58386] by hamaji@chromium.org
  • 14 edits in trunk

2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler and Eric Seidel.

Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203

Now we can test media queries with the new function because the
render tree has the color information of the box.

Note that the pixel test is currently failing. We'll need another
patch to enable printing mode for pixel tests.

  • platform/mac/Skipped:
  • platform/mac/printing/media-queries-print-expected.checksum: Added.
  • platform/mac/printing/media-queries-print-expected.png: Added.
  • platform/mac/printing/media-queries-print-expected.txt: Added.
  • printing/media-queries-print.html:

2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler and Eric Seidel.

Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203

Added RenderAsTextPrintingMode as a behavior of externalRepresentation.

Now ~PrintContext() calls end() automatically.

  • page/PrintContext.cpp: (WebCore::PrintContext::~PrintContext):
  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):
  • rendering/RenderTreeAsText.h: (WebCore::):

2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler and Eric Seidel.

Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]):

2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler and Eric Seidel.

Add layoutTestController.setPrinting()
https://bugs.webkit.org/show_bug.cgi?id=37203

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setPrintingCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::isPrinting): (LayoutTestController::setIsPrinting):
  • DumpRenderTree/mac/DumpRenderTree.mm: (dump):
12:09 AM Changeset in webkit [58385] by yuzo@google.com
  • 6 edits in trunk

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Enhance CSS parser for Paged Media (Iteration 4)
Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
https://bugs.webkit.org/show_bug.cgi?id=35853

  • printing/page-rule-css-text-expected.txt:
  • printing/page-rule-css-text.html:

2010-04-27 Yuzo Fujishima <yuzo@google.com>

Reviewed by Eric Seidel.

Enhance CSS parser for Paged Media (Iteration 4)
Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
https://bugs.webkit.org/show_bug.cgi?id=35853

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parsePage):
  • css/CSSParser.h:
Note: See TracTimeline for information about the timeline view.