Timeline


and

05/06/10:

23:42 Changeset [58940] by mrowe@apple.com

Exclude leaks due to <rdar://problem/7815391> from the output.

Rubber-stamped by Dan Bernstein.

  • Scripts/old-run-webkit-tests:
23:22 Changeset [58939] by laszlo.1.gombos@nokia.com

2010-05-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable YARR_JIT for X86 Mac for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=38668

  • wtf/Platform.h:
23:18 Changeset [58938] by mitz@apple.com

Skip compositing/layer-creation/overflow-scroll-overlap.html from r58936, since hardware
compositing is disabled on the Leopard test bot.

  • platform/mac-leopard/Skipped:
22:12 Changeset [58937] by tony@chromium.org

2010-04-27 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] clicking a scrollbar in an iframe shouldn't lose the selection
https://bugs.webkit.org/show_bug.cgi?id=38189

  • fast/events/mousedown-in-subframe-scrollbar-expected.txt: Added.
  • fast/events/mousedown-in-subframe-scrollbar.html: Added.
  • fast/events/resources/mousedown-in-subframe-scrollbar.html: Added.
  • platform/win/Skipped:

2010-04-27 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] clicking a scrollbar in an iframe shouldn't lose the selection
https://bugs.webkit.org/show_bug.cgi?id=38189

Test: fast/events/mousedown-in-subframe-scrollbar.html

  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): If clicking on

a scrollbar, pass the event directly to the scrollbar. This matches
mac which passes the event to the NSScroller.

22:04 Changeset [58936] by simon.fraser@apple.com

2010-05-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Compositing layers that are clipped out by an overflow:scroll parent fail to get created on reveal
https://bugs.webkit.org/show_bug.cgi?id=38712

When compositing layer creation is testing layer overlap, we need to re-run the
algorithm when an overflow:scroll element scrolls, to create new layers for revealed
elements.

Test: compositing/layer-creation/overflow-scroll-overlap.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): First, move the compositing updates until after the call to updateWidgetPositions(), so that this order is similar to what we done when a FrameView scrolls. This change has no known side effects. Second, if compositingConsultsOverlap() is true, we need to actually do a compositing layer update to compute whether revealed/hidden layers should be created/destroyed.
21:58 Changeset [58935] by barraclough@apple.com

Bug 38714 - Add result caching for Math.sin

Reviewed by Geoff Garen.

Math.sin is frequently called with the same operand, caching the result should
improve performance. CachedTranscendentalFunction adds a generic mechanism to
cache results for pure functions with the signature "double func(double)", and
where NaN maps to NaN.

CachedTranscendentalFunction uses a very simple hash function designed to be
fast to execute since we cannot cache the result, and trivial to JIT generate,
should we wish to do so.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/CachedTranscendentalFunction.h: Added.

(JSC::CachedTranscendentalFunction::CachedTranscendentalFunction):
(JSC::CachedTranscendentalFunction::~CachedTranscendentalFunction):
(JSC::CachedTranscendentalFunction::operator()):
(JSC::CachedTranscendentalFunction::initialize):
(JSC::CachedTranscendentalFunction::hash):

  • runtime/JSGlobalData.h:
  • runtime/MathObject.cpp:

(JSC::mathProtoFuncSin):

  • wtf/Platform.h:
21:51 Changeset [58934] by eric@webkit.org

2010-05-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r58933.
http://trac.webkit.org/changeset/58933
https://bugs.webkit.org/show_bug.cgi?id=38717

"Broke all websocket tests on Tiger" (Requested by eseidel on
#webkit).

  • Scripts/new-run-webkit-websocketserver:
  • Scripts/old-run-webkit-tests:
  • Scripts/run-webkit-websocketserver:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • Scripts/webkitpy/thirdparty/init.py:
  • Scripts/webkitpy/thirdparty/pywebsocket/COPYING: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/MANIFEST.in: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/README: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/example/echo_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/init.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/dispatch.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/handshake.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/msgutil.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/setup.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/config.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/mock.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/run_all.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_dispatch.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_handshake.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_memorizingfile.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_mock.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_msgutil.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
  • Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added.
20:56 Changeset [58933] by ukai@chromium.org

2010-05-06 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

WebSocket: pywebsocket 0.5
https://bugs.webkit.org/show_bug.cgi?id=38034

Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.

  • Scripts/new-run-webkit-websocketserver: Add --output-dir option.
  • Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
  • Scripts/run-webkit-websocketserver: Ditto.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
  • Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
  • Scripts/webkitpy/thirdparty/pywebsocket: Removed.
20:13 Changeset [58932] by cjerdonek@webkit.org

svn-apply now understands the Git diff "copy from" syntax when the
similarity index is 100%.

Reviewed by Daniel Bates.

https://bugs.webkit.org/show_bug.cgi?id=38628

  • Scripts/VCSUtils.pm:
    • Adjusted parseGitDiffHeader() to parse the "copy from" and "similarity index" lines.
  • Scripts/svn-unapply:
    • Adjusted the patch() subroutine so that copies are recognized as file additions.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
    • Added unit tests for the cases of a copy with similarity index 100% and less than 100%.
19:58 Changeset [58931] by mrowe@apple.com

Versioning.

19:58 Changeset [58930] by mrowe@apple.com

New tag.

19:54 Changeset [58929] by cjerdonek@webkit.org

2010-05-06 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Daniel Bates.

Removed the need for svn-apply and -unapply to re-parse whether
a diff is binary or not.

https://bugs.webkit.org/show_bug.cgi?id=38320

  • Scripts/VCSUtils.pm:
    • Adjusted parseGitDiffHeader() to set the isBinary key.
    • Adjusted parseSvnDiffHeader() to set the isBinary key.
    • Adjusted parseDiffHeader() to set the isBinary key.
    • Changed the scmFormat key set by parseDiffHeader() to isGit and isSvn keys.
    • Adjusted parseDiff() to set the isBinary, isGit, and isSvn keys.
  • Scripts/svn-apply:
    • Updated the patch() method to use the isBinary, isGit, and isSvn keys.
  • Scripts/svn-unapply:
    • Updated the patch() method to use the isBinary and isSvn keys.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated the unit tests as necessary.
    • Added a test case to test that the isBinary key is getting set properly.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
    • Updated the unit tests as necessary.
19:37 Changeset [58928] by dpranke@chromium.org

2010-05-06 Dirk Pranke <dpranke@chromium.org>

Unreviewed, rebaseline and expectation changes from WK roll from a
few days ago.

  • platform/chromium-linux/http/tests/loading/bad-scheme-subframe-expected.txt: Copied from LayoutTests/platform/chromium-mac/http/tests/loading/bad-scheme-subframe-expected.txt.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-linux/svg/text/kerning-expected.checksum:
  • platform/chromium-linux/svg/text/kerning-expected.png:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/editing/selection/caret-rtl-2-actual.checksum.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/selection/caret-rtl-2-actual.png.
  • platform/chromium-mac/svg/text/kerning-expected.checksum: Added.
  • platform/chromium/test_expectations.txt:
18:56 Changeset [58927] by tkent@chromium.org

2010-05-06 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add support for resources on Mac
https://bugs.webkit.org/show_bug.cgi?id=38637

  • DEPS: Check out tools/data_pack.

2010-05-06 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add support for resources on Mac
https://bugs.webkit.org/show_bug.cgi?id=38637

Repack webkit_chromium_resources.pak, webkit_strings_en-US.pak,
and webkit_resources.pak, and put them as Mac bundle resource.
The 'actions' section is almost same as a part of test_shell.gypi.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
18:29 Changeset [58926] by dpranke@chromium.org

2010-05-06 Dirk Pranke <dpranke@chromium.org>

Unreviewed, rebaseline a chromium test.

Need a linux baseline for fast/notifications/notifications-replace-expected.txt to override the windows version.

  • platform/chromium-linux/fast/notifications/notifications-replace-expected.txt: Added.
17:47 Changeset [58925] by mjs@apple.com

Not reviewed, build fix.

Try again - with quotes this time. *facepalm*

  • dom/Notation.cpp:
17:39 Changeset [58924] by mjs@apple.com

Not reviewed, build fix.

Speculative fix for Qt and Gtk.

  • dom/Notation.cpp:
17:34 BuildingQtOnWindows edited by laszlo.1.gombos@nokia.com
few words on how to generate MSVC project files (diff)
17:25 Changeset [58923] by mjs@apple.com

Not reviewed, build fix.

Fix an assert that I failed to update in my earlier change.

  • dom/CharacterData.h:

(WebCore::CharacterData::CharacterData):

17:03 Changeset [58922] by ap@apple.com

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=38697
REGRESSION (r58299): Replying on reddit.com no longer works

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Don't recognize :first, :left and :right. The aren't allowed in all contexts, and properly implementing them is out of scope for this regression fix.
17:01 Changeset [58921] by jianli@chromium.org

Improve code generator scripts to support converting ScriptString.
https://bugs.webkit.org/show_bug.cgi?id=38699

Reviewed by Adam Barth.

Change both JSC and V8 generators to introduce "ConvertScriptString"
attribute to allow converting from ScriptString. Also updated the
bindings test result.

These changes are necessary in order to avoid adding custom binding codes
when we add the FileReader interface.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_script_string_attr):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::):
(WebCore::jsTestObjScriptStringAttr):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj scriptStringAttr]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::scriptStringAttrAttrGetter):
(WebCore::):

16:45 Changeset [58920] by ossy@webkit.org

[Qt] Unreviewed buildfix after r58917.

  • DumpRenderTree/qt/LayoutTestControllerQt.h: Missing function declaration added.
16:33 Changeset [58919] by jianli@chromium.org

Improve code generator scripts to pass additional ScriptExecutionContext
argument to the constructor.
https://bugs.webkit.org/show_bug.cgi?id=38687

Reviewed by Adam Barth.

Change both JSC and V8 generators to introduce "CallWith=ScriptExecutionContext"
attribute to allow passing the additional ScriptExecutionContext argument to
the constructor. Also add another test IDL file to test interface-level
features.

These changes are necessary in order to avoid adding custom binding codes
when we add the FileReader interface.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h: Added.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Added.
  • bindings/scripts/test/JS/JSTestInterface.h: Added.
  • bindings/scripts/test/ObjC/DOMTestInterface.h: Added.
  • bindings/scripts/test/ObjC/DOMTestInterface.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h: Added.
  • bindings/scripts/test/TestInterface.idl: Added.
  • bindings/scripts/test/V8/V8TestInterface.cpp: Added.
  • bindings/scripts/test/V8/V8TestInterface.h: Added.
  • bindings/v8/V8Proxy.h:

(WebCore::V8Proxy::constructDOMObjectWithScriptExecutionContext):

16:23 Changeset [58918] by mjs@apple.com

Build fix, not reviewed.

Speculative Windows and Debug build fixes for the last change.

  • dom/Node.h:

(WebCore::Node::inDocument):
(WebCore::Node::setFlag):

16:23 Changeset [58917] by andersca@apple.com

2010-05-06 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler and Dan Bernstein..

REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>

When the plug-in database is initialized, we will register all the MIME types it supports with the global
WebView dictionary. When plug-ins are disabled for a single web view, the MIME types still need to be
in the global mapping (because other web views might still have plug-ins enabled).


Prior to r51617 we would always look at the plug-in database to determine that the MIME type belongs to a
plug-in, but now we won't even touch the plug-in database when plug-ins are disabled.


In order to fix this, a new set of registered MIME types that are known to be plug-ins is added. When
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:] is called and allowingPlugins is FALSE
we check if the MIME type is a known plug-in MIME type and return false in that case.


  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
  • WebView/WebView.mm: (knownPluginMIMETypes): (+[WebView _registerPluginMIMEType:]): (+[WebView _unregisterPluginMIMEType:]): (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
  • WebView/WebViewInternal.h:

2010-05-06 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler and Dan Bernstein..

REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>

Add tests.

  • platform/mac/plugins/disable-plugins-expected.txt: Added.
  • platform/mac/plugins/disable-plugins.html: Added.

2010-05-06 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler and Dan Bernstein..

REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>

Add a 'setPluginsEnabled' layoutTestController function for disabling plug-ins. This is only implemented on Mac currently
because the bug that needs this functionality is mac specific.

  • DumpRenderTree/LayoutTestController.cpp: (setPluginsEnabledCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setPluginsEnabled):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setPluginsEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setPluginsEnabled):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setPluginsEnabled):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setPluginsEnabled):
16:18 Changeset [58916] by jamesr@google.com

2010-05-06 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
https://bugs.webkit.org/show_bug.cgi?id=38158

Fixes:

  • replace NULL with 0
  • remove unusued locals
add parens around ambiguous looking compound predicates like (a
b && c)

This also adds a check for x >= 0 to FontLinux.cpp's in this statement:

if (x < walker.width())

This is more documentation than anything else since walker.width() returns
an unsigned the current behavior is that x is promoted to unsigned and as
long as x + walker.width() is less than 231 all negative values of x
end up wrapping around and not being < walker.width(). This behavior is
tested by fast/text/international/khmer-selection.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::adjustTextRenderMode): (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::length): (WebCore::TextRunWalker::width): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::isCoordinateSkiaSafe): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
15:53 Changeset [58915] by adachan@apple.com

https://bugs.webkit.org/show_bug.cgi?id=38695

Reviewed by David Kilzer.

Check the result from widget() for NULL before accessing it.

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::calcHeight):
(WebCore::RenderIFrame::calcWidth):

15:41 Changeset [58914] by mjs@apple.com

2010-05-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

further fixes towards REGRESSION (r57292): 1% PLT regression from visited link information leak fix
https://bugs.webkit.org/show_bug.cgi?id=38682
<rdar://problem/7859794>

Looks like a 1-2% speedup on PLT.

  • Reorder CSS properties.
  • Remove short circuit tag check in matchRulesForList which costs more than it saves.
  • Inline initForStyleResolve.
  • Optimize applyDeclarations to avoid switch and take fewer branches in the inner loop.


  • Change the way Node handles flags - replace bitfield with a uint32_t and explicit masking, to make it cheaper to initialize the bits and give faster access.
  • Added new Node flags to check for isStyledElement, isHTMLElement, isSVGElement, isComment, and devirtualize those methods.
  • Inline constructors for Node, Element, Text, CharacterData, StyledElement, etc since they are very simple and lots of nodes get constructed.


  • css/CSSPropertyNames.in: Move a few of the properties up front so we can check for them with < instead of switch statements
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): Remove unnecessary preflight check for tag match before checking selector. This check very rarely short circuits anything, since most rules with a tag end up in the appropriate tag bucket. So doing the check cost more time than the time saved. (WebCore::CSSStyleSelector::initForStyleResolve): Inline. Create RenderStyle in a better way. (WebCore::CSSStyleSelector::applyDeclarations): Get rid of switch statement and use <= to check for the high priority properties. Convert to template to avoid checking "applyFirst" each time through the loop. (WebCore::CSSStyleSelector::styleForElement): Adjust for new applyDeclarations() signature. (WebCore::CSSStyleSelector::keyframeStylesForAnimation): ditto (WebCore::CSSStyleSelector::pseudoStyleForElement): ditto
  • css/CSSStyleSelector.h: Adjust for new applyDeclarations() signature.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle): Inline constructor.
  • rendering/style/RenderStyle.h: Make constructor private so it can be inline.
  • dom/Node.h: (WebCore::): See high-level description of changes above. Redid the way boolean flags work. (WebCore::Node::isElementNode): (WebCore::Node::isContainerNode): (WebCore::Node::isTextNode): (WebCore::Node::isHTMLElement): (WebCore::Node::isSVGElement): (WebCore::Node::isStyledElement): (WebCore::Node::isCommentNode): (WebCore::Node::hasID): (WebCore::Node::hasClass): (WebCore::Node::active): (WebCore::Node::inActiveChain): (WebCore::Node::inDetach): (WebCore::Node::hovered): (WebCore::Node::attached): (WebCore::Node::setAttached): (WebCore::Node::needsStyleRecalc): (WebCore::Node::styleChangeType): (WebCore::Node::childNeedsStyleRecalc): (WebCore::Node::isLink): (WebCore::Node::setHasID): (WebCore::Node::setHasClass): (WebCore::Node::setChildNeedsStyleRecalc): (WebCore::Node::clearChildNeedsStyleRecalc): (WebCore::Node::setInDocument): (WebCore::Node::clearInDocument): (WebCore::Node::setInActiveChain): (WebCore::Node::clearInActiveChain): (WebCore::Node::setIsLink): (WebCore::Node::clearIsLink): (WebCore::Node::setActive): (WebCore::Node::setHovered): (WebCore::Node::inDocument): (WebCore::Node::): (WebCore::Node::getFlag): (WebCore::Node::setFlag): (WebCore::Node::clearFlag): (WebCore::Node::hasRareData): (WebCore::Node::isParsingChildrenFinished): (WebCore::Node::setIsParsingChildrenFinished): (WebCore::Node::clearIsParsingChildrenFinished): (WebCore::Node::isStyleAttributeValid): (WebCore::Node::setIsStyleAttributeValid): (WebCore::Node::clearIsStyleAttributeValid): (WebCore::Node::isSynchronizingStyleAttribute): (WebCore::Node::setIsSynchronizingStyleAttribute): (WebCore::Node::clearIsSynchronizingStyleAttribute): (WebCore::Node::areSVGAttributesValid): (WebCore::Node::setAreSVGAttributesValid): (WebCore::Node::clearAreSVGAttributesValid): (WebCore::Node::isSynchronizingSVGAttributes): (WebCore::Node::setIsSynchronizingSVGAttributes): (WebCore::Node::clearIsSynchronizingSVGAttributes): (WebCore::Node::hasRareSVGData): (WebCore::Node::setHasRareSVGData): (WebCore::Node::clearHasRareSVGData): (WebCore::Node::initialRefCount):
  • dom/Node.cpp: (WebCore::Node::trackForDebugging): Adjusted for changes in flag handling. (WebCore::Node::ensureRareData): ditto (WebCore::Node::setStyleChange): ditto (WebCore::Node::setNeedsStyleRecalc): ditto (WebCore::Node::lazyAttach): ditto (WebCore::Node::attach): ditto (WebCore::Node::detach): ditto (WebCore::Node::insertedIntoDocument): ditto (WebCore::Node::removedFromDocument): ditto
  • dom/CharacterData.cpp:
  • dom/CharacterData.h: (WebCore::CharacterData::CharacterData): Inline the constructor (moved from .cpp)
  • dom/Comment.cpp: (WebCore::Comment::Comment): Tell the base class that we're a comment.
  • dom/Comment.h: Remove isCommentNode override.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::detach): Adjusted for changes in flag handling. (WebCore::ContainerNode::removedFromDocument): ditto
  • dom/Document.cpp: (WebCore::Document::Document): Adjusted for changes in flag handling. (WebCore::Document::recalcStyle): ditto (WebCore::Document::setFocusedNode): ditto
  • dom/Document.h: (WebCore::Node::Node): Inline the Node constructor - goes here because it uses Document.
  • dom/DocumentFragment.cpp: include Document.h due to above change
  • dom/EditingText.cpp: ditto
  • dom/EntityReference.cpp: ditto
  • dom/Element.cpp: (WebCore::Element::getAttribute): Adjusted for changes in flag handling. (WebCore::Element::setAttribute): ditto (WebCore::Element::hasAttributes): ditto (WebCore::Element::recalcStyle): ditto (WebCore::Element::finishParsingChildren): ditto
  • dom/Element.h: (WebCore::Element::Element): Inline (moved from .cpp) (WebCore::Element::isFinishedParsingChildren): (WebCore::Element::beginParsingChildren): (WebCore::Element::attributes): Adjusted for changes in flag handling.
  • dom/StyledElement.cpp: (WebCore::StyledElement::updateStyleAttribute): Adjust for changes to flag handling. (WebCore::StyledElement::mapToEntry): ditto (WebCore::StyledElement::parseMappedAttribute): ditto (WebCore::StyledElement::copyNonAttributeProperties): ditto
  • dom/StyledElement.h: (WebCore::StyledElement::StyledElement): Inline (moved from.cpp) (WebCore::StyledElement::invalidateStyleAttribute): Adjust for changes in flag handling.
  • dom/Text.h: (WebCore::Text::Text): Inline (moved from .cpp)
  • dom/Text.cpp:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): Adjust for changes in flag handling. (WebCore::HTMLAnchorElement::parseMappedAttribute): ditto
  • html/HTMLElement.cpp: (WebCore::HTMLElement::create): Tell base class we're an HTML element.
  • html/HTMLElement.h: ditto above; remove isHTMLElement override.
  • html/HTMLFormControlElement.h: Tell base class we're an HTML element.
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): ditto
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::HTMLProgressElement): ditto
  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement): Tell base class we're a styled element.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): Adjust for changes in flag handling. (WebCore::MediaControlElement::MediaControlElement): ditto (WebCore::MediaControlInputElement::MediaControlInputElement): ditto
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement): ditto
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateHoverActiveState): ditto
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::updateValuePartState): ditto
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): ditto
  • rendering/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): ditto
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): ditto
  • svg/SVGAnimatedProperty.h: (WebCore::SVGAnimatedPropertyTearOff::setBaseVal): ditto (WebCore::SVGAnimatedPropertyTearOff::setAnimVal): ditto
  • svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): Tell base class we're an svg element. (WebCore::SVGElement::ensureRareSVGData): Adjust for flag handling changes. (WebCore::SVGElement::updateAnimatedSVGAttribute): ditto
  • svg/SVGElement.h: (WebCore::SVGElement::invalidateSVGAttributes): ditto
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged): ditto
  • wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::WMLAnchorElement): ditto
  • wml/WMLElement.cpp: (WebCore::WMLElement::WMLElement): Tell base class we're a styled element.
15:28 Changeset [58913] by mitz@apple.com

<rdar://problem/7951285> REGRESSION (r58847): Composited iframe content obscures Safari's application chrome

Reviewed by Simon Fraser.

Fixed this other regression from r58847. The regression was caused by overriding -visibleRect to
return the WebClipView’s full bounds. AppKit uses -visibleRect to determine the geometry
of the surface for the child WebFrameView. The fix is to restrict the special behavior of
-[WebClipView visibleRect] to when AppKit is consulting it for the purpose of invalidating
areas while scrolling.

  • WebView/WebClipView.h:
  • WebView/WebClipView.mm:

(-[WebClipView visibleRect]): If the WebClipView is not scrolling, always return
[super visibleRect].
(-[WebClipView _immediateScrollToPoint:]): Override this internal NSClipView method
to set a flag telling -visibleRect that the view is scrolling.

  • WebView/WebView.mm:

(layerSyncRunLoopObserverCallBack): Ensure that screen updates, disabled by AppKit
when it thinks an upcoming window flush will re-enable them, are enabled here in
case the -setNeedsDisplayInRect: override has prevented the window from needing to be
flushed.

15:28 Changeset [58912] by johnnyg@google.com

2010-05-06 John Gregg <johnnyg@google.com>

Unreviewed, rebaseline for chromium test.

[chromium] Deal with different local path structure on windows.

  • platform/chromium-win/fast/notifications: Added.
  • platform/chromium-win/fast/notifications/notifications-replace-expected.txt: Added.
15:19 Changeset [58911] by ggaren@apple.com

Windows build fix.

  • bytecode/SamplingTool.cpp:

(JSC::SamplingFlags::sample): Use a cast, so Windows will be happy when
this code is enabled.

  • wtf/Platform.h: Reverted last change to this file, which seems to have

been accidental.

15:12 Changeset [58910] by abarth@webkit.org

2010-05-06 Adam Barth <abarth@webkit.org>

Unreviewed. Fix indent. Sorry, my OCD was acting up.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
15:09 Changeset [58909] by dpranke@chromium.org

2010-05-06 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations fix.

Delete a line for a test that is no longer failing on chromium linux.

  • platform/chromium/test_expectations.txt:
14:20 BuildingQtOnSymbian edited by laszlo.1.gombos@nokia.com
(diff)
13:50 Changeset [58908] by eric@webkit.org

2010-05-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: store selected Headers / Content tab on explicit switch and/or explicit navigate only.

https://bugs.webkit.org/show_bug.cgi?id=38660

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectHeadersTab): (WebInspector.ResourceView.prototype.selectContentTab):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource):
13:47 Changeset [58907] by barraclough@apple.com

Add compile switch to make debugger keyword plant breakpoint instructions.

Reviewed by Oliver Hunt.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_debug):

  • wtf/Platform.h:
13:38 Changeset [58906] by eric@webkit.org

2010-05-06 Luiz Agostini <luiz.agostini@openbossa.org>

Rubber-stamped by Simon Hausmann.

[Qt] use QT_MOBILE_THEME in Symbian
https://bugs.webkit.org/show_bug.cgi?id=38440

Putting QT_MOBILE_THEME into use for Symbian.

  • WebCore.pro:
13:26 Changeset [58905] by eric@webkit.org

2010-05-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, build fix WinCE for QtWebKit.

[Qt] Compilation with Plugins disabled is broken
https://bugs.webkit.org/show_bug.cgi?id=31407

Rename platform/qt/TemporaryLinkStubs.cpp to avoid name collition on
Windows.

Thanks for Ismail "cartman" Donmez for help.

No new tests, as there is no new functionality.

  • WebCore.gypi:
  • WebCore.pro:
  • platform/qt/TemporaryLinkStubs.cpp: Removed.
  • platform/qt/TemporaryLinkStubsQt.cpp: Copied from WebCore/platform/qt/TemporaryLinkStubs.cpp.
13:04 Changeset [58904] by oliver@apple.com

Fix ARM builds

13:01 Changeset [58903] by eric@webkit.org

2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] REGRESSION: Loading of external CSS and JS files over network fails in some cases
https://bugs.webkit.org/show_bug.cgi?id=36755

Enable the direct connection between QtNetwork and QtWebKit only for Qt versions
greater than 4.6.2, due to a bug in Qt that's been fixed after 4.6.2.

  • platform/network/qt/QNetworkReplyHandler.cpp:
12:39 Changeset [58902] by oliver@apple.com

2010-05-06 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Improve performance of single character string compares
https://bugs.webkit.org/show_bug.cgi?id=38659

Add logic to the jit to identify comparisons to single character string literals
and then just perform the comparison inline, rather than ignoring the evidence
and attempting to perform an integer comparison.

Multiple changes required -- add jnlesseq opcode, add helper function to identify
single character string constants, add a helper to load single character strings.
Then add the 32_64 and normal codepaths to the JIT.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::load16):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpIfTrue):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jlesseq): (JSC::JIT::emitSlow_op_jnlesseq):
  • jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emitBinaryDoubleOp):
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadCharacterString): (JSC::JIT::isOperandConstantImmediateChar):
  • jit/JSInterfaceJIT.h: (JSC::ThunkHelpers::stringImplDataOffset): (JSC::ThunkHelpers::jsStringLengthOffset): (JSC::ThunkHelpers::jsStringValueOffset): Moved from ThunkGenerators to make it possible to share.
  • jit/ThunkGenerators.cpp:

2010-05-06 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Improve performance of single character string compares
https://bugs.webkit.org/show_bug.cgi?id=38659

Add many tests of <, >, <=, >=, ==, ===, !=, !== as the existing
tests were woefully inadequate.

  • fast/js/comparison-operators-expected.txt: Added.
  • fast/js/comparison-operators-greater-expected.txt: Added.
  • fast/js/comparison-operators-greater.html: Added.
  • fast/js/comparison-operators-less-expected.txt: Added.
  • fast/js/comparison-operators-less.html: Added.
  • fast/js/comparison-operators.html: Added.
  • fast/js/script-tests/comparison-operators-greater.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
  • fast/js/script-tests/comparison-operators-less.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
  • fast/js/script-tests/comparison-operators.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
12:06 Changeset [58901] by mrobinson@webkit.org

2010-05-06 Martin Robinson <mrobinson@webkit.org>

Reviewed by Xan Lopez.

Remove use of GOwnPtr to hold GObject types.
https://bugs.webkit.org/show_bug.cgi?id=38669

Change use of GOwnPtr to GRefPtr to types which are natively reference-counted.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): Change GOwnPtr to GRefPtr in some places. (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto.
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_new_with_core_request): Ditto.
  • webkit/webkitnetworkresponse.cpp: (webkit_network_response_new_with_core_response): Ditto.
  • webkit/webkitprivate.cpp: Remove GOwnPtr reference counting template specialization.
  • webkit/webkitprivate.h: Ditto.
11:50 Changeset [58900] by aroben@apple.com

2010-05-06 Adam Roben <aroben@apple.com>

Bail out of WebView::paint when there's nothing to paint

Fixes <http://webkit.org/b/38670> <rdar://problem/7947105> REGRESSION
(r58067): Crash in WebView::paint when Web Inspector is docked and
window is resized so small that WebView disappears

When the WebView is 0-sized, ensureBackingStore() bails out without
creating a bitmap, leaving m_backingStoreBitmap null. Before r58067,
m_backingStoreBitmap was an HBITMAP, so we were happily passing along
a null HBITMAP to various Windows APIs. These calls would fail but not
crash. r58067 changed m_backingStoreBitmap to a RefCountedHBITMAP, and
dereferencing a null RefCountedHBITMAP* of course crashes.

Reviewed by Steve Falkenburg.

  • WebView.cpp: (WebView::paint): Bail if the rect to paint is empty.
11:47 Changeset [58899] by johnnyg@google.com

2010-05-06 John Gregg <johnnyg@google.com>

Unreviewed. Updating test expectations.

[chromium] enabling notifications tests after test_shell change.

  • platform/chromium/test_expectations.txt:
11:46 Changeset [58898] by kov@webkit.org

2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Rework where we get page step and line step from, so we do not
depend on scrollbars existing. Caught by API test I forgot to run.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
10:47 Changeset [58897] by kov@webkit.org

2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Adjustment resetting uses wrong values, and misses page_size and steps
https://bugs.webkit.org/show_bug.cgi?id=38657

Fix resetting adjustment values. In the page cache case, we were
confusing page_size and upper, leading to stray scrollbars
sometimes.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
10:42 Changeset [58896] by ojan@chromium.org

2010-05-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

editing/selection/shift-click.html fails on GTK and QT
https://bugs.webkit.org/show_bug.cgi?id=38656

r58892 added this test. It's the first test for shift+click behavior,
so it exposed bugs in GTK/QT. Skipping to green the bots.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
10:37 Changeset [58895] by sfalken@apple.com

2010-05-06 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

WebFrame::paintDocumentRectToContext paints content at the wrong location
https://bugs.webkit.org/show_bug.cgi?id=38651

  • WebFrame.cpp: (WebFrame::paintDocumentRectToContext):
10:12 Changeset [58894] by darin@apple.com

2010-05-06 Darin Adler <darin@apple.com>

Reviewed by Beth Dakin.

Page::setCanStartMedia does not properly handle the case where a media listener is removed
https://bugs.webkit.org/show_bug.cgi?id=38602

We can't find any real case where this causes a crash at this time, but
we want to harden the code anyway. Thus there are no new regression tests.

  • page/Page.cpp: (WebCore::Page::removeMediaCanStartListener): Removed incorrect assertion. (WebCore::Page::setCanStartMedia): Change algorithm so we notify listeners one at a time and don't notify any listener that has already been removed from the set.
10:05 Changeset [58893] by evan@chromium.org

2010-05-06 Evan Martin <evan@chromium.org>

Unreviewed. Updating test expectations.

[chromium] new baselines for r58886
https://bugs.webkit.org/show_bug.cgi?id=38652

  • platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.txt:
  • platform/chromium-linux/fast/text/international/danda-space-expected.checksum:
  • platform/chromium-linux/fast/text/international/danda-space-expected.png:
  • platform/chromium-linux/fast/text/international/danda-space-expected.txt:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt:
  • platform/chromium/test_expectations.txt:
09:58 Changeset [58892] by ojan@chromium.org

2010-05-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

shift+click on an existing selection doesn't work right
https://bugs.webkit.org/show_bug.cgi?id=36542

NSTextView behavior is to move the end of the selection
closest to the shift-click. Win/Linux behavior is to always
move the focus end of the selection.

  • editing/selection/script-tests/shift-click.js: Added. (shiftClick): (assertSelectionString):
  • editing/selection/shift-click-expected.txt: Added.
  • editing/selection/shift-click.html: Added.
  • platform/win/editing/selection/shift-click-expected.txt: Added.

2010-05-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

shift+click on an existing selection doesn't work right
https://bugs.webkit.org/show_bug.cgi?id=36542

NSTextView behavior is to move the end of the selection
closest to the shift-click. Win/Linux behavior is to always
move the focus end of the selection.

Test: editing/selection/shift-click.html

  • page/EventHandler.cpp: (WebCore::textDistance): (WebCore::EventHandler::handleMousePressEventSingleClick):
09:53 Changeset [58891] by pfeldman@chromium.org

2010-05-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: implement panels history traversal on Cmd+Left/Right.

https://bugs.webkit.org/show_bug.cgi?id=38649

09:49 Changeset [58890] by pfeldman@chromium.org

2010-05-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Chromium Dev Tools: Large toolbar icons flash when dev
tools is opened in docked mode.

https://bugs.webkit.org/show_bug.cgi?id=38631

  • src/js/DevTools.js: (devtools.domContentLoaded):
09:46 Changeset [58889] by eric@webkit.org

2010-05-06 Jochen Eisinger <jochen@chromium.org>

Reviewed by Dimitri Glazkov.

Make ImageDiff depend on WebKit. When compiled from within Chromium, WTF is not a standalone dynamic library but depends on WebKit.
https://bugs.webkit.org/show_bug.cgi?id=38632

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
09:43 Changeset [58888] by tonikitoo@webkit.org

2010-05-05 Antonio Gomes <tonikitoo@webkit.org>

Rubber-stamped by Kenneth Christiansen.

Spatial Navigation: use data url in layout tests
https://bugs.webkit.org/show_bug.cgi?id=38584

In order to make Spatial Navigation layout tests more readable, patch
changes the use or src=resources/iframeXXX.html by inlined sources via
data uri schema.

It is a polishment.

  • fast/events/spatial-navigation/resources/iframe.html: Removed.
  • fast/events/spatial-navigation/resources/iframe2.html: Removed.
  • fast/events/spatial-navigation/resources/iframe3.html: Removed.
  • fast/events/spatial-navigation/resources/iframe4.html: Removed.
  • fast/events/spatial-navigation/snav-iframe-no-focusable-content.html:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
  • fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:
09:42 Changeset [58887] by tonikitoo@webkit.org

2010-05-06 Antonio Gomes <tonikitoo@webkit.org>

[Gtk] Skipped fast/events/spatial-navigation/snav-iframe-flattening-simple.html

DRT does not support frame flattening testing.
https://bugs.webkit.org/show_bug.cgi?id=38650

  • platform/gtk/Skipped:
09:34 Changeset [58886] by evan@chromium.org

2010-05-03 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

[chromium] use glyphDataForCharacter so we hit the glyphdata cache
https://bugs.webkit.org/show_bug.cgi?id=38500

Calling fontDataForCharacters() while rendering text is expensive.
Examining the relevant Mac code in WebKit revealed that calling the
similarly-named glyphDataForCharacters() results in caching the font
data on a per-glyph basis.

Since we now choose a font based on the first character in a run, we
need to be careful that all the glyphs within the run use the same font.
This is also similar to the WebKit Mac code. We need to remove all of
the script run bits eventually and this is a step in that direction.

Tests: fast/text/international/danda-space.html spacing changes slightly
(now matches Firefox better) and fast/text/international/thai-baht-space.html
now picks the correct (serif) font for the digits.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::setupFontForScriptRun):
09:32 Changeset [58885] by mrobinson@webkit.org

2010-05-06 Martin Robinson <mrobinson@webkit.org>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Convert dragging portion of drag-and-drop to use DataObjectGtk.

  • wtf/gobject/GRefPtr.h: Add forward declarations for GObject functions.

2010-05-06 Martin Robinson <mrobinson@webkit.org>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Convert dragging portion of drag-and-drop to use DataObjectGtk.

No new tests, because functionality has not changed.

  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::createDraggingClipboard): Pass the DataObjectGtk as a parameter here.
  • platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create): Take the DataObject as a parameter instead of creating it here. (WebCore::ClipboardGtk::helper): Added. (WebCore::ClipboardGtk::dataObject): Added.
  • platform/gtk/PasteboardHelper.h: Make targetListForDataObject a public method.

2010-05-06 Martin Robinson <mrobinson@webkit.org>

Reviewed by Gustavo Noronha Silva.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Convert dragging portion of drag-and-drop to use DataObjectGtk.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::willPerformDragDestinationAction): Remove the notImplemented. It is implemented, it's just a no-op. (WebKit::DragClient::startDrag): Start the drag context via the ClipboardGtk and PasteboardHelper now.
  • WebCoreSupport/DragClientGtk.h: Small style fix.
  • webkit/webkitprivate.h: Add a HashMap of contexts and DataObjects here to to represent all current drag operations.
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose): Clear all data objects during disposal. (webkit_web_view_drag_end): When a drag is over, just remove it from the map. (webkit_web_view_drag_data_get): To get the drag data, just grab it from the DataObject.
09:30 Changeset [58884] by pfeldman@chromium.org

2010-05-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not show content tab for resources
not supporting content preview.

https://bugs.webkit.org/show_bug.cgi?id=38635

  • English.lproj/localizedStrings.js:
  • inspector/front-end/FontView.js: (WebInspector.FontView.prototype.hasContentTab):
  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.hasContentTab):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype.hasContentTab):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hasContentTab):
09:23 Changeset [58883] by tonikitoo@webkit.org

2010-05-05 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

Spatial Navigation: Add LayoutTest with frame flattening feature on.
https://bugs.webkit.org/show_bug.cgi?id=38585

  • fast/events/spatial-navigation/snav-iframe-flattening-simple-expected.txt: Added.
  • fast/events/spatial-navigation/snav-iframe-flattening-simple.html: Added.
09:17 Changeset [58882] by tonikitoo@webkit.org

2010-05-06 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

Spatial Navigation: adapt the logic of {deep}findFocusableNodeInDirection to do traversal starting from Node* not Document*
https://bugs.webkit.org/show_bug.cgi?id=37803

Instead of receiving a Document pointer as incoming parameter, patch modifies
findFocusableNodeInDirection and deepFindFocusableNodeInDirection methods to
receive a Node pointer as start for content traversal.
This way we can make good use of deepFindFocusableNodeInDirection to traverse
other scrollable container like scrollable div's, and not only frames or iframes.

Patch also makes use of 'while' instead of 'for' to loop control, that gives move
flexibility to the incremental step: e.g. if a scrollable div was processed, the incremental
step in the loop does not have to do node->traverseNextNode() but node->traverseNextSibling().

No behavior change. It is a preparation for supporting scrollable containers in Spatial
Navigation.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally): (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
  • page/FocusController.h:
09:04 Changeset [58881] by ossy@webkit.org

Unreviewed WinCE buildfix after r58842.
Preprocessor doesn't understand "true", changed to "1"

  • platform/graphics/MediaPlayer.cpp:
08:31 Changeset [58880] by mnaganov@chromium.org

2010-05-06 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Temporarily disable 'console.profiles' until we can distinguish
functions from different frames

https://bugs.webkit.org/show_bug.cgi?id=38638

  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::profilesAccessorGetter):
08:13 Changeset [58879] by vitalyr@chromium.org

2010-05-06 Vitaly Repeshko <vitalyr@chromium.org>

[chromium] Unreviewed. Updating expectations.

  • platform/chromium-linux/fast/url/segments-expected.txt: Added.
  • platform/chromium-linux/fast/url/segments-from-data-url-expected.txt: Added.
  • platform/chromium-mac/fast/url/segments-expected.txt: Added.
  • platform/chromium-mac/fast/url/segments-from-data-url-expected.txt: Added.
  • platform/chromium-win/fast/url/segments-expected.txt: Added.
  • platform/chromium-win/fast/url/segments-from-data-url-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
07:12 QtWebKitTriageRoster edited by hausmann@webkit.org
(diff)
07:09 Changeset [58878] by eric@webkit.org

2010-05-06 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
https://bugs.webkit.org/show_bug.cgi?id=38544

  • wtf/Platform.h:

2010-05-06 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
https://bugs.webkit.org/show_bug.cgi?id=38544

No new tests, build fix only.

  • DerivedSources.make:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
  • bridge/jni/JNIBridge.cpp:
  • bridge/jni/JNIBridge.h:
  • bridge/jni/JNIUtility.cpp:
  • bridge/jni/JNIUtility.h:
  • bridge/jni/jni_jsobject.h:
  • bridge/jni/jni_jsobject.mm:
  • bridge/jni/jni_objc.mm:
  • bridge/jni/jsc/JNIBridgeJSC.cpp:
  • bridge/jni/jsc/JNIBridgeJSC.h:
  • bridge/jni/jsc/JNIUtilityPrivate.cpp:
  • bridge/jni/jsc/JNIUtilityPrivate.h:
  • bridge/jni/jsc/JavaClassJSC.cpp:
  • bridge/jni/jsc/JavaClassJSC.h:
  • bridge/jni/jsc/JavaInstanceJSC.cpp:
  • bridge/jni/jsc/JavaInstanceJSC.h:
  • loader/FrameLoaderClient.h:

2010-05-06 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
https://bugs.webkit.org/show_bug.cgi?id=38544

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
06:12 Changeset [58877] by eric@webkit.org

2010-05-06 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Patch to fix compilation warnings for QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=37428

Patch by Alexis Menard <alexis.menard@nokia.com>

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::itemChange):
06:00 Changeset [58876] by eric@webkit.org

2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Replace public inspector url with private property for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=35340

Replace the public API with a private dynamic property until this feature
is ready.

  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
  • symbian/bwins/QtWebKitu.def:
  • symbian/eabi/QtWebKitu.def:

2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Replace public inspector url with private property for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=35340

Replace the public API with a private dynamic property until this feature
is ready.

  • QtLauncher/main.cpp: (LauncherWindow::init):
02:44 Changeset [58875] by alex@webkit.org

2010-05-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Fixed the gobject introspection compilation with the new DOM
bindings, we needed to add DOM objects.

  • GNUmakefile.am:
02:31 Changeset [58874] by eric@webkit.org

2010-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

[WTFURL] Add a class to represent the segments of a URL
https://bugs.webkit.org/show_bug.cgi?id=38566

When paired with a string, this class represents a parsed URL.

  • wtf/url/src/URLSegments.cpp: Added. (WTF::URLSegments::length): (WTF::URLSegments::charactersBefore):
  • wtf/url/src/URLSegments.h: Added. (WTF::URLSegments::): (WTF::URLSegments::URLSegments):
  • wtf/url/wtfurl.gyp:
02:19 Changeset [58873] by eric@webkit.org

2010-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

drop support for sessionStorage in sandbox iframes
https://bugs.webkit.org/show_bug.cgi?id=38151

Update test expectation. This test was originally created to show that
we complied with the letter of the spec, but our behavior is insecure.
In the future, we might revert this change and implement a separate
storage area for each unique origin.

  • fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
  • fast/frames/sandboxed-iframe-storage-expected.txt:

2010-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

drop support for sessionStorage in sandbox iframes
https://bugs.webkit.org/show_bug.cgi?id=38151

This patch causes us to throw a security exception when a sandboxed
iframe attempts to access sessionStorage, matching our behavior for
localStorage. The letter of the spec asks us to create a separate
storage area for each unique origin. We might want to do that in a
future patch, but throwing a security error seems like a safe move now.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessSessionStorage):
  • storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):

2010-05-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

drop support for sessionStorage in sandbox iframes
https://bugs.webkit.org/show_bug.cgi?id=38151

Update client of sessionStorage to handle exceptions.

  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent):
01:51 Changeset [58872] by aestes@apple.com

WebCore: Allow forms submitting to target="_blank" to open popups if the submission
originated from a user gesture.

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=37335
<rdar://problem/7884980>

Test: fast/events/popup-allowed-from-gesture-initiated-form-submit.html

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::processingUserGesture): If no DOM event is
being processed, consult UserGestureIndicator to determine return value.

  • bindings/js/ScriptController.h: Moved the logic of processingUserGestureEvent()

into processingUserGesture().

LayoutTests: Add a test to ensure popups are allowed when the user submits a form with target="_blank".

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=37335
<rdar://problem/7884980>

  • fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Added.
  • fast/events/popup-allowed-from-gesture-initiated-form-submit.html: Added.
  • fast/events/resources/popup-allowed-from-gesture-initiated-form-submit-target.html: Added.
01:10 Changeset [58871] by xan@webkit.org

2010-05-06 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Eric Seidel.

[GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=38577

Thinko caught while refactoring, $custom variable was not
initialized.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
01:09 Changeset [58870] by xan@webkit.org

2010-05-06 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Eric Seidel.

[GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=38577

Refactor GenerateProperty out of GenerateProperties. This is in
preparation for EventListeren attributes, which won't generate
normal GObject properties.

  • bindings/scripts/CodeGeneratorGObject.pm:
01:01 Changeset [58869] by eric@webkit.org

2010-05-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: follow up to linkify event listeners.

https://bugs.webkit.org/show_bug.cgi?id=38257

  • bindings/js/ScriptEventListener.cpp: (WebCore::eventListenerHandlerLocation):
  • bindings/v8/ScriptEventListener.cpp: (WebCore::eventListenerHandlerLocation):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
  • inspector/front-end/EventListenersSidebarPane.js:
00:05 Changeset [58868] by eric@webkit.org

2010-05-05 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: build-webkit --inspector-frontend Should Exclude *.re2js
https://bugs.webkit.org/show_bug.cgi?id=38449

  • Scripts/webkitdirs.pm:

05/05/10:

23:54 Changeset [58867] by eric@webkit.org

2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos

https://bugs.webkit.org/show_bug.cgi?id=37848
Add test cases for -wap-input-format and -wap-input-required of WCSS

  • fast/wcss/wap-input-format-expected.txt: Added.
  • fast/wcss/wap-input-format.xhtml: Added.
  • fast/wcss/wap-input-required-expected.txt: Added.
  • fast/wcss/wap-input-required.xhtml: Added.

2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos

https://bugs.webkit.org/show_bug.cgi?id=37848
This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit

Tests: fast/wcss/wap-input-format.xhtml

fast/wcss/wap-input-required.xhtml

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseWCSSInputProperty):
  • css/CSSParser.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/WCSSPropertyNames.in:
  • dom/InputElement.cpp: (WebCore::InputElement::sanitizeValue): (WebCore::InputElement::handleBeforeTextInsertedEvent): (WebCore::InputElementData::InputElementData): (WebCore::formatCodes): (WebCore::cursorPositionToMaskIndex): (WebCore::InputElement::isConformToInputMask): (WebCore::InputElement::validateInputMask):
  • dom/InputElement.h: (WebCore::InputElementData::inputFormatMask): (WebCore::InputElementData::setInputFormatMask): (WebCore::InputElementData::maxInputCharsAllowed): (WebCore::InputElementData::setMaxInputCharsAllowed):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setWapInputFormat):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::data):
  • wml/WMLInputElement.h: (WebCore::WMLInputElement::data):

2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos

This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit
Make the test cases in fast/wcss optionional only when WCSS is enabled.

https://bugs.webkit.org/show_bug.cgi?id=37848

  • Scripts/old-run-webkit-tests:
  • Scripts/webkitperl/features.pm:
23:23 Changeset [58866] by hamaji@chromium.org

2010-05-05 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

[GTK] Markup of copied non ASCII characters is broken
https://bugs.webkit.org/show_bug.cgi?id=37918

This test was fixed by http://trac.webkit.org/changeset/58468

  • platform/gtk/Skipped:
23:06 Changeset [58865] by mitz@apple.com

Fixed a crash when closing Top Sites after r58847.

Reviewed by Mark Rowe.

  • WebView/WebFrameView.mm:

(-[WebFrameView webFrame]): Null-check _private.

23:02 Changeset [58864] by morrita@google.com

2010-05-05 MORITA Hajime <morrita@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=38150
Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer.

Moved a part of code chunk in HTMLFormControlElementWithState::defaultEventHandler()
which accesses the renderer from foreign node,
to TextControlInnerTextElement::defaultEventHandler() which owns the renderer.

No new tests. No behavioral change.

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::defaultEventHandler):
  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler):
22:47 Changeset [58863] by ossy@webkit.org

[Qt] Enable Sputnik tests.
https://bugs.webkit.org/show_bug.cgi?id=38457

Rubber-stamped by Alexey Proskuryakov.

  • platform/qt/Skipped: Only skip tests that fail.
22:40 Changeset [58862] by tkent@chromium.org

2010-05-05 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[DRT/Chromium] Remove InitWebCoreSystemInterface() call
https://bugs.webkit.org/show_bug.cgi?id=38624

Chromium r45167 <http://src.chromium.org/viewvc/chrome?view=rev&revision=45167>
added InitWebCoreSystemInterface() to webkit/support/platform_support_mac.mm.
So we don't need to call it from DumpRenderTree.cpp anymore.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Remove InitWebCoreSystemInterface().
22:34 Changeset [58861] by eric@webkit.org

2010-05-05 Steven Lai <steven_lai@asia.apple.com>

Reviewed by Alexey Proskuryakov.

Remove platform specific test result
Don't print the formatted string of the z-index in the test case
since there's a risk that the output on different c stdlib implementations/platforms/locale could be different
https://bugs.webkit.org/show_bug.cgi?id=38617.

  • fast/dom/clone-node-z-index-expected.txt:
  • fast/dom/clone-node-z-index.html:
  • platform/win/fast/dom/clone-node-z-index-expected.txt: Removed.
22:23 Changeset [58860] by eric@webkit.org

2010-05-05 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Add a test of URL segmentation from a data URL base
https://bugs.webkit.org/show_bug.cgi?id=38606

As requested by Alexey. These tests find some interesting behavior in
both KURL and GURL. We'll need to go through them in more detail later
to understand what the right behavior is.

  • fast/url/script-tests/segments-from-data-url.js: Added.
  • fast/url/segments-from-data-url-expected.txt: Added.
  • fast/url/segments-from-data-url.html: Added.
22:11 Changeset [58859] by eric@webkit.org

2010-05-05 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Add a test of URL segmentation
https://bugs.webkit.org/show_bug.cgi?id=38600

These tests are based on URLParser.Standard from
http://code.google.com/p/google-url/source/browse/trunk/src/url_parse_unittest.cc

  • fast/url/resources/utilities.js: (canonicalize):
    • I changed this to use deterministic IDs because (theoretically) the old way was flaky in case the IDs collided.

(segments):

  • Here we're using HTMLAnchorElement's attributes to infer the internal segmentation. Unforunately, there don't seem to be accessors for usernames and passwords of URLs.
  • fast/url/script-tests/segments.js: Added.
    • I'm not 100% sure all the test cases here represent the intent of the original test author. The tricky bit is we don't have a good way to test absolute URL parsing from the web platform, which means a bunch of these become tests of how we handle relative URLs. However, I'm not one to turn down more test cases.
  • fast/url/script-tests/trivial-segments.js: Added.
    • This is more of a test of the testing harness to make sure its working properly when running on other browsers.
  • fast/url/segments-expected.txt: Added.
  • fast/url/trivial-segments-expected.txt: Added.
    • As usual, these have their "PASS" expectations set to the Chromium behavior but have their -expected.txt set to the normal WebKit behavior, letting us track differences between the two.
  • fast/url/segments.html: Added.
  • fast/url/trivial-segments.html: Added.
21:50 Changeset [58858] by eric@webkit.org

2010-05-05 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Adding comment with link to RefPtr documentation.
https://bugs.webkit.org/show_bug.cgi?id=38601

  • wtf/RefPtr.h:
21:28 Changeset [58857] by eric@webkit.org

2010-05-05 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Line Numbers should be Aligned with the Source Code Line
https://bugs.webkit.org/show_bug.cgi?id=38593

If there is a message bubble, such as an error message, in a source view
the line number should be in line with the source code line, not centered
between the source and bubble.

  • inspector/front-end/textViewer.css: (.webkit-line-number): added vertical-align: top
20:16 Changeset [58856] by mitz@apple.com

Fixed test crashes after r58847.

Rubber-stamped by Mark Rowe.

  • WebView/WebHTMLView.mm:

(setNeedsDisplayInRect): Null-check the frame.

18:51 Changeset [58855] by dpranke@chromium.org

2010-05-05 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
18:36 Changeset [58854] by mitz@apple.com

Fix the decelerated compositing build.

  • page/FrameView.cpp:

(WebCore::FrameView::isEnclosedInCompositingLayer):

  • page/FrameView.h:
18:33 Changeset [58853] by dpranke@chromium.org

2010-05-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: clean up newline handling in printing

The new printing module seems to handle newlines somewhat
inconsistently, especially in --verbose mode. This change cleans up
the code to make things more consistent and adds a bunch of unit tests.

https://bugs.webkit.org/show_bug.cgi?id=38616

  • Scripts/webkitpy/common/array_stream.py: Added.
  • Scripts/webkitpy/common/array_stream_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
18:12 Changeset [58852] by jamesr@google.com

2010-05-05 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

Ban the single letter 'l' as an identifier name
http://trac.webkit.org/changeset/58844

Add a lint rule to ban the single letter 'l' as an identifier name
since it is very easy to confuse with the numeral '1', especially
in code like WebCore/css/CSSHelper.cpp.

See http://trac.webkit.org/changeset/58844 as an example of a bug
caused by confusing short variable names.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
18:08 Changeset [58851] by barraclough@apple.com

Bug 38604 - workers-gc2 crashing on Qt

Reviewed by Darin Adler.

This appears to be due to a couple of issues.
(1) When the atomic string table is deleted it does not clear the 'inTable' bit
on AtomicStrings - it implicitly assumes that all AtomicStrings have already
been deleted at this point (otherwise they will crash in their destructor when
they try to remove themselves from the atomic string table).
(2) We don't fix the ordering in which WTF::WTFThreadData and
WebCore::ThreadGlobalData are destructed.

We should make sure that ThreadGlobalData is cleaned up before worker threads
terminate and WTF::WTFThreadData is destroyed, and we should clear the inTable
bit of members on atomic string table destruction.

JavaScriptCore:

WTF changes (fix issue 1, above) - ensure inTable property is cleared when the
atomic string table is destroyed (also, rename InTable to IsAtomic, to make it
clear which table we are refering to!)

  • wtf/text/AtomicString.cpp:

(WebCore::AtomicStringTable::destroy):
(WebCore::CStringTranslator::translate):
(WebCore::UCharBufferTranslator::translate):
(WebCore::HashAndCharactersTranslator::translate):
(WebCore::AtomicString::add):

  • wtf/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::isAtomic):
(WebCore::StringImpl::setIsAtomic):

  • wtf/text/StringImplBase.h:

WebCore:

WTF changes (fix issue 2, above) - clean up the thread data on worker termination.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::~ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):

  • platform/ThreadGlobalData.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

18:05 Changeset [58850] by bweinstein@apple.com

Add Windows-specific results for clone-node-z-index.html. The difference in results is harmless (the number is the same),
but the difference is being tracked by https://bugs.webkit.org/show_bug.cgi?id=38617.

Rubber-stamped by Mark Rowe.

  • platform/win/fast/dom/clone-node-z-index-expected.txt: Added.
17:53 Changeset [58849] by crogers@google.com

Fix problems with node disconnection

  • add notifyInputConnection() method to AudioNode
17:53 Changeset [58848] by crogers@google.com

Cleanup AudioContext - clarify memory management a little bit

17:37 Changeset [58847] by mitz@apple.com

<rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1)
https://bugs.webkit.org/show_bug.cgi?id=38427

Reviewed by Simon Fraser.

WebCore:

Test: compositing/iframes/iframe-in-composited-layer.html

  • WebCore.base.exp: Export FrameView::isEnclosedInCompositingLayer().
  • page/FrameView.cpp:

(WebCore::FrameView::isEnclosedInCompositingLayer): Added this predicate.

  • page/FrameView.h:

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Renamed WebClipView.m to WebClipView.mm and changed it to

Objective-C++.

WebKit/mac:

  • WebView/WebClipView.m: Renamed to WebClipView.mm.
  • WebView/WebClipView.mm:

(-[WebClipView visibleRect]): Added this override, which for instances used for WebFrameViews in
composited layers, returns the clip view’s entire bounds. This prevents drawing from being clipped to
AppKit’s idea of what part of the view would be visible if it was drawn as part of the view hierarchy.
Since it is drawn into a compositing layer, that’s irrelevant, and we should not be clipping.

  • WebView/WebHTMLView.mm:

(setCursor): Style tweak.
(setNeedsDisplayInRect): Added. Replaces the default implementation of -[NSView setNeedsDisplayInRect:],
so that if the receiver is a descendant of a WebFrameView that draws into a composited layer, the invalidation
is routed back through the WebCore FrameView, which propagates it to the layer.
(+[WebHTMLViewPrivate initialize]): Swizzle the setNeedsDisplayInRect: override in.
(-[WebHTMLView visibleRect]): Removed whitespace.

  • WebView/WebView.mm:

(layerSyncRunLoopObserverCallBack): If we bailed out on syncing, due to pending layout, do an eager layout
in preparation for the displaying of compositing layers.

LayoutTests:

  • compositing/iframes/iframe-in-composited-layer.html: Added.
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
17:20 Changeset [58846] by sullivan@apple.com

<rdar://problem/7942606> Output appears in Console when exiting Safari with multiple windows opened

Reviewed by Mark Rowe.

  • WebView/WebView.mm:

(+[WebView closeAllWebViews]):
Make copy of allWebViewsSet to avoid mutating it while iterating through it.

17:02 Changeset [58845] by cmarrin@apple.com

2010-05-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Got composited iframes showing up on Mac again
https://bugs.webkit.org/show_bug.cgi?id=38565

This was broken by http://trac.webkit.org/changeset/58798. That
change connected iframes through the parent document to the root
of the layer tree. That is correct for Windows, but not for Mac.
So the places where the linkage is made were wrapped in
shouldPropagateCompositingToIFrameParent() calls, which is
always false for Mac.

Test: compositing/iframes/composited-iframe-alignment.html

  • rendering/RenderLayerCompositor.cpp:Avoid doing composited iframe linkage on Mac (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::didMoveOnscreen): (WebCore::RenderLayerCompositor::willMoveOffscreen): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
16:24 Changeset [58844] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=38260
<rdar://problem/7917548> Fix whitespace removing in deprecatedParseURL().

Broken all the way since r4 (yes, that's a revision number).

Test: http/tests/security/xss-DENIED-javascript-with-spaces.html

  • css/CSSHelper.cpp: (WebCore::deprecatedParseURL): Fixed loop conditions for remaining length.
16:12 Changeset [58843] by cfleizach@apple.com

Many AXUnknown showing up in the hierarchy
https://bugs.webkit.org/show_bug.cgi?id=38607

Reviewed by Beth Dakin.

WebCore:

The RenderTableSection should not be an accessible element.

Test: platform/mac/accessibility/parent-of-table-row-is-table.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/accessibility/parent-of-table-row-is-table-expected.txt: Added.
  • platform/mac/accessibility/parent-of-table-row-is-table.html: Added.
15:59 Changeset [58842] by ossy@webkit.org

[Qt]Disable Qt Multimedia backend for HTML 5 Audio and Video elements
Fall back to the Phonon backend until the release situation has been cleared up.

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=38612

Buildfix for QT_VERSION >= 0x040700 after r58810.

  • platform/graphics/MediaPlayer.cpp:
15:42 Changeset [58841] by jianli@chromium.org

XMLHttpRequestUpload events do not fire when sending a raw file or FormData object.
https://bugs.webkit.org/show_bug.cgi?id=37771

Reviewed by David Levin.

WebCore:

Test: http/tests/local/formdata/upload-events.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

LayoutTests:

Add a layout test to test upload events firing.

  • http/tests/local/formdata/resources/send-form-data-common.js:

(dumpResponse):
(sendFormData):
(testSendingFormData):

  • http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js:
  • http/tests/local/formdata/script-tests/send-form-data.js:
  • http/tests/local/formdata/script-tests/upload-events.js: Added.
  • http/tests/local/formdata/upload-events-expected.txt: Added.
  • http/tests/local/formdata/upload-events.html: Added.
  • platform/gtk/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in gtk platform.
  • platform/qt/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in qt platform.
  • platform/win/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in win platform.
15:28 Changeset [58840] by ossy@webkit.org

[Qt] Qt port should use its own QUuid class to create UUID string.
https://bugs.webkit.org/show_bug.cgi?id=38581

Reviewed by Simon Hausmann.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString): Added PLATFORM(QT) case.

14:51 Changeset [58839] by darin@chromium.org

2010-05-05 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] clear out deprecated methods that are no longer used
https://bugs.webkit.org/show_bug.cgi?id=38610

  • public/WebFormElement.h:
  • public/WebInputElement.h:
  • public/WebKitClient.h:
  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::createPopupMenu):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened):
  • src/WebFormElement.cpp:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::setSelectionRange):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::hideSuggestionsPopup):
  • src/WebViewImpl.h:
14:16 QtWebKitTriageRoster edited by hausmann@webkit.org
(diff)
13:16 Changeset [58838] by dpranke@chromium.org

2010-05-05 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations fix.

Update expectations with tests that are now passing (possibly flaky?).

  • platform/chromium/test_expectations.txt:
13:06 Changeset [58837] by dpranke@chromium.org

2010-05-05 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations fix.

Mark svg/custom/mask-changes.svg and http/tests/loading/bad-scheme-subframe.html as failing on Chromium Linux until they can be triaged.

  • platform/chromium/test_expectations.txt:
12:19 Changeset [58836] by ap@apple.com

Roll out r58830 for breaking tests.

Was: https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly

12:11 Changeset [58835] by crogers@google.com

Call to pull() must take return value into account for non-inplace case

12:11 Changeset [58834] by crogers@google.com

Audio buffer source node needs default number of channels

12:10 Changeset [58833] by crogers@google.com

Keep track of mixer input availability

11:52 Changeset [58832] by jianli@chromium.org

Implement FileReader class.
https://bugs.webkit.org/show_bug.cgi?id=38157

Reviewed by Adam Barth.

This patch only contains the implementation of FileReader class as defined
in the File API spec: http://www.w3.org/TR/file-upload/#dfn-filereader.

New test will be added when a IDL is exposed and the FILE_READER is turned
on.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.h:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::toFileReader):

  • dom/EventTarget.h:
  • html/FileError.h:

(WebCore::FileError::FileError):

  • html/FileReader.cpp: Added.
  • html/FileReader.h: Added.
  • html/FileStream.cpp:

(WebCore::FileStream::FileStream):
(WebCore::FileStream::openForRead):
(WebCore::FileStream::close):
(WebCore::FileStream::read):

  • html/FileStream.h:
11:35 Changeset [58831] by sfalken@apple.com

2010-05-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by Maciej Stachowiak.

REGRESSION(r57969) Image decoder is repeatedly destroyed/created in CoreGraphics-based Windows WebKit
https://bugs.webkit.org/show_bug.cgi?id=38595

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
11:26 Changeset [58830] by ap@apple.com

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly

Test: fast/frames/take-focus-from-iframe.html

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas of focused frame get out of sync temporarily.
11:24 How to CC yourself on (or make other changes to) many bugs at once created by aroben@apple.com
Initial version
11:20 WikiStart edited by aroben@apple.com
(diff)
11:17 Changeset [58829] by ap@apple.com

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=26824
<rdar://problem/7018610> EventHandler can operate on a wrong frame if focus changes during
keyboard event dispatch.

EventHandler object is tied to a frame, so it's wrong for it to continue processing a keyboard
event if focused frame changes between keydown and keypress.

  • manual-tests/focus-change-between-key-events.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Bail out early if focused frame changes while dispatching keydown. Also made similar changes for Windows to maintain matching behavior, even though EventHandler was re-entered anyway due to WM_KEYDOWN and WM_CHAR being separate events.
11:14 Changeset [58828] by eric@webkit.org

2010-05-05 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] Add quota parameter to WebStorageNamespace::createSessionStorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=38589

  • public/WebStorageNamespace.h: (WebKit::WebStorageNamespace::createSessionStorageNamespace):
  • src/WebStorageNamespaceImpl.cpp: (WebKit::WebStorageNamespace::createSessionStorageNamespace):
10:53 Changeset [58827] by hamaji@chromium.org

2010-05-05 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

Commit and Review policy should encourage unofficial reviews
https://bugs.webkit.org/show_bug.cgi?id=38517

  • coding/commit-review-policy.html:
10:20 Changeset [58826] by eric@webkit.org

2010-05-05 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

MediaError.h is missing PassRefPtr.h include
https://bugs.webkit.org/show_bug.cgi?id=38575

No new tests, build fix only.

  • html/MediaError.h:
10:06 Changeset [58825] by eric@webkit.org

2010-05-05 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits panel: Resource counters get reset when switching panels while reloading page
https://bugs.webkit.org/show_bug.cgi?id=38579

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState): (WebInspector.AuditLauncherView.prototype._updateResourceProgress):
10:03 Changeset [58824] by oliver@apple.com

2010-05-05 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make Array.join specialised for actual arrays
https://bugs.webkit.org/show_bug.cgi?id=38592

Bring Array.join in line with the other array methods by specialising for
this === an array.

  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin):
09:48 Changeset [58823] by eric@webkit.org

2010-05-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Doubleclick on line number should not trigger source editing.

https://bugs.webkit.org/show_bug.cgi?id=38588

  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._handleDoubleClick):
09:30 Changeset [58822] by mrobinson@webkit.org

2010-05-05 Martin Robinson <mrobinson@webkit.org>

Reviewed by Gustavo Noronha.

[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Add support in the PasteboardHelper for images, in preparation for drag-and-drop data.

No new tests as functionality has not changed.

  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::fillSelectionData): Add support for images here. (WebCore::PasteboardHelper::targetListForDataObject): Add support for images here.
09:22 Changeset [58821] by eric@webkit.org

2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Add a "focused" parameter to Widget::setFocus, and updates Document
so that Widget is informed of focus loss as well as focus gain.
Changes all existing setFocus implementations so that they ignore
the 'false' case, so no behavior is changed until individual
platforms are updated to handle the new case (if they want to).

https://bugs.webkit.org/show_bug.cgi?id=37961

  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • platform/Widget.h:
  • platform/android/WidgetAndroid.cpp: (WebCore::Widget::setFocus):
  • platform/chromium/WidgetChromium.cpp: (WebCore::Widget::setFocus):
  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::setFocus):
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setFocus):
  • platform/haiku/WidgetHaiku.cpp: (WebCore::Widget::setFocus):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus):
  • platform/qt/WidgetQt.cpp: (WebCore::Widget::setFocus):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::setFocus):
  • platform/wx/WidgetWx.cpp: (WebCore::Widget::setFocus):
  • plugins/PluginView.h:
  • plugins/PluginViewNone.cpp: (WebCore::PluginView::setFocus):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setFocus):
  • plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::setFocus):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setFocus):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setFocus):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::setFocus):

2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Update the plugin container's setFocus implementation to pass the new
boolean argument to the next layer.

https://bugs.webkit.org/show_bug.cgi?id=37961

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setFocus):
  • src/WebPluginContainerImpl.h:

2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Update setFocus for the new boolean argument; no behavioral change.

https://bugs.webkit.org/show_bug.cgi?id=37961

  • WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::setFocus):
  • WebCoreSupport/EmbeddedWidget.h:
09:01 Changeset [58820] by jeremy@chromium.org

2010-05-05 Jeremy Moskovich <jeremy@chromium.org>

Unreviewed, updated baselines.

skia r561 broke a bunch of chromium image baselines.
Update test_expectations to include remaining failures.

  • platform/chromium/test_expectations.txt:
08:18 Changeset [58819] by jeremy@chromium.org

2010-05-05 Jeremy Moskovich <jeremy@chromium.org>

Unreviewed, updated baselines.

skia r561 broke a bunch of chromium image baselines.
Rebase a few tests that were missed by previous passes.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • platform/chromium-linux/svg/custom/mask-changes-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/mask-changes-expected.png: Added.
  • platform/chromium/test_expectations.txt:
08:08 Changeset [58818] by eric@webkit.org

2010-05-05 Steve Block <steveblock@google.com>

Reviewed by Pavel Feldman.

Move V8 ScriptDebugServer::topStackFrame() to ScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=38531

ScriptCallStack::create() uses ScriptDebugServer::topStackFrame(), but ScriptDebugServer
is guarded with ENABLE(JAVASCRIPT_DEBUGGER). This prevents ScriptCallStack from being
built on platforms that do not define ENABLE(JAVASCRIPT_DEBUGGER).

No new tests, build fix only.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::callLocation): (WebCore::ScriptCallStack::createUtilityContext): Helper for topStackFrame, moved from ScriptDebugServer (WebCore::ScriptCallStack::topStackFrame): Moved from ScriptDebugServer
  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::utilityContext): Helper for topStackFrame, moved from ScriptDebugServer
  • bindings/v8/ScriptDebugServer.cpp:
  • bindings/v8/ScriptDebugServer.h:
07:42 Changeset [58817] by jeremy@chromium.org

2010-05-05 Jeremy Moskovich <jeremy@chromium.org>

Unreviewed, updated baselines - 6th and final batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
07:18 Changeset [58816] by jeremy@chromium.org

2010-05-05 Jeremy Moskovich <jeremy@chromium.org>

Unreviewed, updated baselines - 5th batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
07:01 BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
(diff)
06:52 Changeset [58815] by jeremy@chromium.org

2010-05-05 Jeremy Moskovich <jeremy@chromium.org>

Unreviewed, updated baselines - 4th batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
06:49 QtWebKitJournal edited by hausmann@webkit.org
(diff)
06:31 Changeset [58814] by jeremy@chromium.org

2010-05-05 Jeremy Moskovich <jeremy@chromium.org>

Unreviewed, updated baselines - 3rd batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
05:57 Changeset [58813] by ossy@webkit.org

[Qt] REGRESSION(r56869): WinCE build is broken
https://bugs.webkit.org/show_bug.cgi?id=36929

Rubber-stamped by Simon Hausmann.

  • WebCore.pro: LIBS += -lOle32 added.
05:44 BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
Added python as a dependency (diff)
05:36 Changeset [58812] by jeremy@chromium.org

Unreviewed, updated baselines - 2nd batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
04:54 Changeset [58811] by jeremy@chromium.org

Unreviewed, updated baselines - 1st batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

  • platform/chromium/test_expectations.txt:
04:30 Changeset [58810] by hausmann@webkit.org

[Qt] Disable Qt Multimedia backend for HTML 5 Audio and Video elements

Reviewed by Tor Arne Vestbø.

Fall back to the Phonon backend until the release situation has been cleared up.

  • WebCore.pro:
04:30 Changeset [58809] by loislo@chromium.org

2010-05-05 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Clickable links to resources should be used as 'details' part for the all suitable kinds of records.
https://bugs.webkit.org/show_bug.cgi?id=38542

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelineRecordListRow): (WebInspector.TimelineRecordListRow.prototype.update): (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper): (WebInspector.TimelinePanel.PopupContentHelper.prototype._createCell): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
02:33 Changeset [58808] by zimmermann@webkit.org

2010-05-05 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add missing files generated by "run-bindings-test", after the DOMTestCallback.idl addition.

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Added. (WebKit::kit): (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type): (WebKit::wrapTestCallback): (WebKit::core): (webkit_dom_test_callback_finalize): (webkit_dom_test_callback_set_property): (webkit_dom_test_callback_get_property): (webkit_dom_test_callback_class_init): (webkit_dom_test_callback_init):
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h: Added.
  • bindings/scripts/test/ObjC/DOMTestCallback.h: Added.
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: Added. (-[DOMTestCallback dealloc]): (-[DOMTestCallback finalize]): (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]): (core): (kit):
  • bindings/scripts/test/ObjC/DOMTestCallbackInternal.h: Added.
01:00 Changeset [58807] by jeremy@chromium.org

Unreviewed, expectations change.

recommit r58747 - Preparing for chromium skia roll incorporating changes up to r561.
Add expected failures so bots don't turn red while rolling.

https://bugs.webkit.org/show_bug.cgi?id=38512

  • platform/chromium/test_expectations.txt:
00:57 Changeset [58806] by xan@webkit.org

2010-05-05 Xan Lopez <xlopez@igalia.com>

Skip flakey workers test.

  • platform/gtk/Skipped:
00:57 Changeset [58805] by eric@webkit.org

2010-05-05 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: FontView needs Cleanup
https://bugs.webkit.org/show_bug.cgi?id=38567

FontView was missing some of the newer practices for initialization
that other Resource Views had. Also its width calculations could
result in a single character wrapping. This is general cleanup.

  • inspector/front-end/FontView.js: (WebInspector.FontView): move initialization into contentTabSelected (WebInspector.FontView.prototype.contentTabSelected): handle initialization like other Resource Views (WebInspector.FontView.prototype.updateFontPreviewSize): use a narrower width to prevent text from widowing
00:31 Changeset [58804] by krit@webkit.org

2010-05-05 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hit testing is *way* too slow
https://bugs.webkit.org/show_bug.cgi?id=19312

Use the cached stroke and fill boundaries in RenderPath as a heuristik to
speed up SVG's hit testing.

No new tests added.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::fillContains): (WebCore::RenderPath::strokeContains):

05/04/10:

23:06 Changeset [58803] by eric@webkit.org

2010-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Shinichiro Hamaji.

PrettyPatch.pretty_diff("") should not hang
https://bugs.webkit.org/show_bug.cgi?id=38552

Also found a bug in PrettyPatch.pretty_diff where it would
hang when passed "" as input.

I suspect there may be bugs in prettify.rb (or our use there-of)
where it can hang, which would then cause the testing thread to hang.

  • Scripts/webkitpy/common/prettypatch.py:
    • Don't hang when passed ""
  • Scripts/webkitpy/common/prettypatch_unittest.py:
    • Test that we don't hang when passed ""
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Add a FIXME that we should share code with prettypatch.rb
22:09 Changeset [58802] by simon.fraser@apple.com

2010-05-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Improve check for drawing into the window that was added in r58623
https://bugs.webkit.org/show_bug.cgi?id=38562

Rather than assuming that any non-bitmap context is the window's context,
compare the current graphics context with -[NSWindow graphicsContext] to
determine that we're drawing into the window.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
20:24 Changeset [58801] by dumi@chromium.org

Auto-generate all Database callbacks.
https://bugs.webkit.org/show_bug.cgi?id=38503

Reviewed by Adam Barth.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCustomSQLStatementCallback.cpp: Removed.
  • bindings/js/JSCustomSQLStatementCallback.h: Removed.
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementErrorCallback.h: Removed.
  • bindings/js/JSCustomSQLTransactionCallback.cpp: Removed.
  • bindings/js/JSCustomSQLTransactionCallback.h: Removed.
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Removed.
  • bindings/js/JSCustomSQLTransactionErrorCallback.h: Removed.
  • bindings/js/JSDatabaseCallback.cpp: Removed.
  • bindings/js/JSDatabaseCallback.h: Removed.
  • bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomSQLStatementCallback.h: Removed.
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8SQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionCallback.h: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Removed.
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Removed.
  • bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
  • bindings/v8/custom/V8DatabaseCallback.h: Removed.
  • bindings/v8/custom/V8DatabaseCustom.cpp:

(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • storage/DatabaseCallback.h:
  • storage/DatabaseCallback.idl: Added.
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::performCallback):

  • storage/SQLStatementCallback.h:
  • storage/SQLStatementCallback.idl: Added.
  • storage/SQLStatementErrorCallback.idl: Added.
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverTransactionCallback):

  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionCallback.idl: Added.
  • storage/SQLTransactionErrorCallback.h:
  • storage/SQLTransactionErrorCallback.idl: Added.
20:06 Changeset [58800] by cmarrin@apple.com

results for new test checked in with http://trac.webkit.org/changeset/58797

19:43 Changeset [58799] by dpranke@chromium.org

2010-05-04 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations fix.

Re-add the two expectations lines that got mistakenly deleted in
r58798.

  • platform/chromium/test_expectations.txt:
19:05 Changeset [58798] by dpranke@chromium.org

2010-05-04 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Made composited iframes work on Windows
https://bugs.webkit.org/show_bug.cgi?id=32446

I've added one new test (composited-parent-iframe.html) which
shows both the parent iframe and the iframe contents document
with compositing. It also shows correct behavior with clipping,
borders, margins, padding and shadows. It also sets the iframe
size as a percent of the page to show correct resizing behavior.
The existing composited-iframe.html has been changed similarly
but without the page resizing. The existing preserve-3d-switching.html
test needed new results because of changes to the layer dumper.

  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/composited-iframe.html:
  • compositing/iframes/composited-parent-iframe.html: Added.
  • compositing/iframes/resources/composited-subframe.html:
  • platform/win/compositing/iframes/composited-iframe-expected.txt:
  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.
18:50 Changeset [58797] by cmarrin@apple.com

Reviewed by Simon Fraser.

Made composited iframes work on Windows
https://bugs.webkit.org/show_bug.cgi?id=32446


This completes the work in http://trac.webkit.org/changeset/57919
to create compositing layers in the parent document when an iframe has
a compositing layer. The parent document has a layer for the iframe
element and builds a layer tree to the page root. The layer tree for the
iframe document is then parented to the iframe element's GraphicsLayer.


The RenderLayerCompositor for the iframe document (which owns the
root of the layer tree) now has a clippingLayer which is the
parent of the layer tree root so it can be clipped to the parent
iframe's bounds, taking into account borders, padding, etc. in
the parent iframe element.


I also got rid of a no longer used function: RenderLayerCompositor::parentInRootLayer

Test: compositing/iframes/composited-parent-iframe.html

  • rendering/RenderLayerBacking.cpp:Make calls to RenderLayerCompositor to set the clipping bounds for iframe content
  • rendering/RenderLayerCompositor.cpp:Hook the iframe content to the parent iframe element
  • rendering/RenderLayerCompositor.h:
18:24 Changeset [58796] by ap@apple.com

Not reviewed.

Updated test results - the test still passes.

  • http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
18:22 Changeset [58795] by dumi@chromium.org

Fix the sticky-notes demo.
https://bugs.webkit.org/show_bug.cgi?id=38550

Reviewed by Darin Adler.

  1. Exceptions thrown by openDatabase() should be treated as

failures.

  1. Do not allow users to create new notes when openDatabase()

failed.

  • demos/sticky-notes/index.html:
18:11 Changeset [58794] by cfleizach@apple.com

AX: layout tests need to be updated to reflect what is being tested
https://bugs.webkit.org/show_bug.cgi?id=38556

Reviewed by Beth Dakin.

Many of the initial AX layout tests just dumped a lot of attributes and did not
have a focused test. This updates some of those tests (more to follow in the future).

  • accessibility/image-map1.html:
  • accessibility/img-aria-button-alt-tag-expected.txt:
  • accessibility/img-aria-button-alt-tag.html:
  • accessibility/input-image-alt-expected.txt:
  • accessibility/input-image-alt.html:
  • accessibility/placeholder-expected.txt:
  • accessibility/placeholder.html:
  • platform/mac/accessibility/image-map1-expected.txt:
18:08 Changeset [58793] by eric@webkit.org

2010-05-04 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

Provide an API for querying whether a WebWidget is using gpu accelerated compositing.
Also changed: isAcceleratedCompositing to: isAcceleratedCompositingActive.
https://bugs.webkit.org/show_bug.cgi?id=38220

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.h: (WebKit::WebPopupMenuImpl::isAcceleratedCompositingActive):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::isAcceleratedCompositingActive): (WebKit::WebViewImpl::setRootGraphicsLayer): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::updateRootLayerContents):
  • src/WebViewImpl.h:
17:57 Changeset [58792] by ap@apple.com

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=38497
<rdar://problem/7759438> Make sure that http URLs always have a host in SecurityOrigin

This is a hardening fix, and behavior really depends on what an underlying networking layer
does. So, no test.

  • page/SecurityOrigin.cpp: (WebCore::schemeRequiresAuthority): List schemes that need an authority for successful loading. (WebCore::SecurityOrigin::SecurityOrigin): Never let e.g. http origins with empty authorities have the same security origin.
17:49 Changeset [58791] by dpranke@chromium.org

2010-05-04 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Mark fast/forms/placeholder-pseudo-style.html as an IMAGE diff on
chromium-linux . This was mistaken deleted earlier today. Mark
fast/dom/clone-node-z-index.html as a TEXT diff on chromium-win; I
haven't looked at this yet but I need to roll past this to get the
new-run-webkit-tests change I checked in in r58789 downstream to
the Chromium bots.

  • platform/chromium/test_expectations.txt:
17:30 Changeset [58790] by eric@webkit.org

2010-05-04 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

getFramebufferAttachmentParameter should return the original WebGLTexture/WebGLRenderbuffer instead of creating new ones sharing names.
https://bugs.webkit.org/show_bug.cgi?id=38236

  • fast/canvas/webgl/gl-object-get-calls-expected.txt: Check if getFramebufferAttachmentParameter return a texture/renderbuffer that matches the original one.
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.

2010-05-04 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

getFramebufferAttachmentParameter should return the original WebGLTexture/WebGLRenderbuffer instead of creating new ones sharing names.
https://bugs.webkit.org/show_bug.cgi?id=38236

  • html/canvas/CanvasObject.h: Add type check functions. (WebCore::CanvasObject::isBuffer): (WebCore::CanvasObject::isFramebuffer): (WebCore::CanvasObject::isProgram): (WebCore::CanvasObject::isRenderbuffer): (WebCore::CanvasObject::isShader): (WebCore::CanvasObject::isTexture):
  • html/canvas/WebGLBuffer.h: Add type check functions. (WebCore::WebGLBuffer::isBuffer):
  • html/canvas/WebGLFramebuffer.h: Add type check functions. (WebCore::WebGLFramebuffer::isFramebuffer):
  • html/canvas/WebGLProgram.h: Add type check functions. (WebCore::WebGLProgram::isProgram):
  • html/canvas/WebGLRenderbuffer.cpp: remove constructor using existing name.
  • html/canvas/WebGLRenderbuffer.h: Add type check functions; remove constructor using existing name. (WebCore::WebGLRenderbuffer::isRenderbuffer):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Return original Texture/Renderbuffer instead of creating new ones. (WebCore::WebGLRenderingContext::findTexture): Find a WebGLTexture using a name. (WebCore::WebGLRenderingContext::findRenderbuffer): Find a WebGLRenderbuffer using a name.
  • html/canvas/WebGLRenderingContext.h: Add find* functions.
  • html/canvas/WebGLShader.h: Add type check functions. (WebCore::WebGLShader::isShader):
  • html/canvas/WebGLTexture.cpp: remove constructor using existing name.
  • html/canvas/WebGLTexture.h: Add type check functions; remove constructor using existing name. (WebCore::WebGLTexture::isTexture):
17:16 Changeset [58789] by dpranke@chromium.org

2010-05-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: turn off threading on the Chromium Mac port until
we can stabilize the port more and figure out why it is hanging so
frequently.

https://bugs.webkit.org/show_bug.cgi?id=38553

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
    • override default_child_processes() and log a warning
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • fix a typo that caused us to print a method object instead of the value the method object returns in the case where there is only one child process.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
    • Add unit tests for the output of run_webkit_tests - in this case, the handling of --child-processes and --print config
17:16 Changeset [58788] by eric@webkit.org

2010-05-04 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] QT_MOBILE_THEME compile time flag
https://bugs.webkit.org/show_bug.cgi?id=38439

Replacing preprocessor conditional used in RenderThemeQt from Q_WS_MAEMO_5 to
USE(QT_MOBILE_THEME).

  • WebCore.pro:
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::RenderThemeQt): (WebCore::RenderThemeQt::qStyle): (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::adjustMenuListButtonStyle): (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
  • platform/qt/RenderThemeQt.h:
16:57 Changeset [58787] by adachan@apple.com

https://bugs.webkit.org/show_bug.cgi?id=38555

Reviewed by David Kilzer.

Small code refactoring: move the logic to figure out the path to the
databases directory to another method.

  • Storage/WebDatabaseManager.mm:

(databasesDirectoryPath):
(WebKitInitializeDatabasesIfNecessary):

16:17 Changeset [58786] by joepeck@webkit.org

2010-05-04 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Dan Bernstein.

SVG fonts trigger GlyphPage::fill with null font
https://bugs.webkit.org/show_bug.cgi?id=38530

SVG fonts do not use the glyph page cache. This change detects when
attempting to fill a GlyphPage with an SVG font and indicates that
the glyphs were not available.

  • platform/graphics/GlyphPageTreeNode.cpp: (WebCore::fill): helper method which handles attempts to fill a GlyphPage with SVG or non-SVG fonts (WebCore::GlyphPageTreeNode::initializePage): use the helper where appropriate
15:59 Changeset [58785] by crogers@google.com

Fixes to V8DOMWrapper to handle CachedAudio

15:58 Changeset [58784] by crogers@google.com

Initial changes to gyp files to build audio engine

15:58 Changeset [58783] by crogers@google.com

Add custom V8 bindings for AudioContext and AudioNode

15:46 Changeset [58782] by levin@chromium.org

Unreviewed tests skips for qt/gtk.

Add the recently added drag and drop tests to the
skipped lists for both gtk and qt to go along with
the other drag and drop tests that are skipped on
those platforms.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
15:24 Changeset [58781] by andersca@apple.com

2010-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

[WebKit2] The web process doesn't need to paint when the web view is hidden.
https://bugs.webkit.org/show_bug.cgi?id=38549

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: (DrawingAreaMessage::): Add SuspendPainting/ResumePainting messages.


  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::setPageIsVisible): Suspend and resume painting accordingly.


  • WebProcess/WebPage/DrawingAreaUpdateChunk.cpp: (WebKit::DrawingAreaUpdateChunk::DrawingAreaUpdateChunk): Initialize m_shouldPaint to true.


(WebKit::DrawingAreaUpdateChunk::display):
Return if m_shouldPaint is false.


(WebKit::DrawingAreaUpdateChunk::scheduleDisplay):
Ditto.


(WebKit::DrawingAreaUpdateChunk::setSize):
Assert that we should paint here.

(WebKit::DrawingAreaUpdateChunk::suspendPainting):
Set m_shouldPaint to false and stop the timer.


(WebKit::DrawingAreaUpdateChunk::resumePainting):
Set m_shouldPaint to true and paint if needed.

(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):
handle SuspendPainting/ResumePainting messages.

  • WebProcess/WebPage/DrawingAreaUpdateChunk.h:
15:04 Changeset [58780] by levin@chromium.org

REGRESSION(r54368): Text drag-and-drop from input/textarea doesn't work
if the text is like a URL
https://bugs.webkit.org/show_bug.cgi?id=38374

Patch by Kent Tamura <tkent@chromium.org> on 2010-05-04
Reviewed by David Levin (and unofficially by Enrica Casucci).

WebCore:

Since r54368, documentFragmentFromDragData() creates an <a> element
with no anchor text for URL-like text dragged from input/textarea
element. If such text is dropped to input/textarea element, the text
is not inserted.
To fix this problem, use the original text or the URL as an anchor
text.

Test: editing/pasteboard/drag-drop-url-text.html

  • page/DragController.cpp:

(WebCore::documentFragmentFromDragData):

LayoutTests:

  • editing/pasteboard/drag-drop-url-text-expected.txt: Added.
  • editing/pasteboard/drag-drop-url-text.html: Added.
15:01 Changeset [58779] by eric@webkit.org

2010-05-04 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by Darin Adler.

WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
https://bugs.webkit.org/show_bug.cgi?id=38535

Don't call asFunction if callee is not a FunctionType to prevent assertion failure
in JSCell::isObject().

  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::functionName): (JSC::DebuggerCallFrame::calculatedFunctionName):
14:50 Changeset [58778] by timothy@apple.com

Remove ChangeLog from bad merge.

14:49 Changeset [58777] by timothy@apple.com

Fix the find command in extract-localizable-strings so skip
directories are correctly skipped and header files are searched.

https://bugs.webkit.org/show_bug.cgi?id=38545
rdar://problem/7941295

Reviewed by Darin Adler.

  • Scripts/extract-localizable-strings: Append -o after each -prune

so -and isn't implied. Surround all the -name arguments so they get
an implied -print action. Removed check for "icu". Skip any header that
ends in LocalizableStrings.h, so SafariLocalizableStrings.h is skipped.

  • Scripts/update-webkit-localizable-strings: Add the two icu directories

to the skip list.

14:49 Changeset [58776] by timothy@apple.com

Updated the localizable strings to run without errors.

Rubber-stamped by John Sullivan.

  • English.lproj/Localizable.strings: Updated.
  • StringsNotToBeLocalized.txt: Updated.
14:13 Changeset [58775] by steveblock@google.com

JavaInstanceJSC.cpp and JNIUtilityPrivate.cpp need to include jni_jsobject.h for jlong_to_pt() and ptr_to_jlong()
https://bugs.webkit.org/show_bug.cgi?id=38525

Reviewed by Darin Adler.

No new tests, build fix only.

  • bridge/jni/jni_jsobject.h: Guard Mac-specific code with PLATFORM(MAC)
  • bridge/jni/jsc/JNIUtilityPrivate.cpp: Include jni_jsobject.h
  • bridge/jni/jsc/JavaInstanceJSC.cpp: Include jni_jsobject.h
14:02 Changeset [58774] by eric@webkit.org

2010-05-04 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

New FileSystemPOSIX functions cause linker errors on Android
https://bugs.webkit.org/show_bug.cgi?id=38521

No new tests, build fix only.

  • platform/android/FileSystemAndroid.cpp: Remove closeFile, which is provided in FileSystemPOSIX.cpp
  • platform/posix/FileSystemPOSIX.cpp: Guard writeToFile with !PLATFORM(ANDROID)
13:49 Changeset [58773] by sfalken@apple.com

Remove redundant exports to fix Windows build warnings.

13:37 Changeset [58772] by eric@webkit.org

2010-05-04 Jesus Sanchez-Palencia <jesus@webkit.org>

Reviewed by Eric Seidel.

Wrong documentation on 'webkit-patch help land'.
https://bugs.webkit.org/show_bug.cgi?id=37871

Small fix on the help documentation for webkit-patch
land.

  • Scripts/webkitpy/tool/commands/download.py:
13:16 Changeset [58771] by bdakin@apple.com

Fix for <rdar://problem/7818509> Crash occurs when exiting Safari

Reviewed by Mike Thole.

We can avoid this crash if we call [self _removeFromAllWebViewsSet]
even in the case when we are doing a fastDocumentTeardown. This is
a much safer approach.

  • WebView/WebView.mm:

(-[WebView _close]):

13:13 Changeset [58770] by ossy@webkit.org

Unreviewed.

[Qt] http/tests/security/cross-frame-access-name-getter.html timed out
https://bugs.webkit.org/show_bug.cgi?id=38540

  • platform/qt/Skipped: http/tests/security/cross-frame-access-name-getter.html skipped until bug fixed.
13:02 Changeset [58769] by dpranke@chromium.org

2010-05-04 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Remove a bunch of test failures that are no longer failing (likely fixed in r58762).

  • platform/chromium/test_expectations.txt:
11:49 Changeset [58768] by pfeldman@chromium.org

2010-05-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: restore main and sidebar scroller positions
when switching between panels.

https://bugs.webkit.org/show_bug.cgi?id=38522

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.elementsToRestoreScrollPositionsFor):
  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.show): (WebInspector.Panel.prototype.hide): (WebInspector.Panel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.Panel.prototype._storeScrollPositions): (WebInspector.Panel.prototype._restoreScrollPositions):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.elementsToRestoreScrollPositionsFor):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
11:12 Changeset [58767] by johnnyg@google.com

Unreviewed, build fix for Qt skipping new notifications tests.

10:42 Changeset [58766] by eric@webkit.org

2010-05-04 Steven Lai <steven_lai@asia.apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37900
<rdar://problem/7806164> cloneNode() does not preserve z-index with more than six digits

  • fast/dom/HTMLInputElement/clone-input-checked-expected.txt: Added.
  • fast/dom/HTMLInputElement/clone-input-checked.html: Added.
  • fast/dom/clone-node-z-index-expected.txt: Added.
  • fast/dom/clone-node-z-index.html: Added.

2010-05-04 Steven Lai <steven_lai@asia.apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=37900
<rdar://problem/7806164> cloneNode() does not preserve z-index with more than six digits

Tests: fast/dom/HTMLInputElement/clone-input-checked.html

fast/dom/clone-node-z-index.html

  • dom/Element.cpp: undid the order change of calling copyNonAttributeProperties() before setAttributes() (WebCore::Element::cloneElementWithoutChildren): uncheck the previous radio button in the same radio button group only when the checked radio box is appended to the dom tree
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateCheckedRadioButtons): (WebCore::HTMLInputElement::attach): (WebCore::HTMLInputElement::setChecked):
  • html/HTMLInputElement.h:
10:20 Changeset [58765] by johnnyg@google.com

2010-04-29 John Gregg <johnnyg@google.com>

Reviewed by Dmitry Titov.

notifications should have dir and replaceId attributes
https://bugs.webkit.org/show_bug.cgi?id=38336

  • public/WebNotification.h:
  • src/WebNotification.cpp: (WebKit::WebNotification::dir): (WebKit::WebNotification::replaceId):

2010-04-29 John Gregg <johnnyg@google.com>

Reviewed by Dmitry Titov.

notifications should have dir and replaceId attributes.
Note that tests are only enabled in Chromium, skipped elsewhere
since notifications aren't implemented.
https://bugs.webkit.org/show_bug.cgi?id=38336

Tests: fast/notifications/notifications-replace.html

fast/notifications/notifications-rtl.html

  • notifications/Notification.h: (WebCore::Notification::dir): (WebCore::Notification::setDir): (WebCore::Notification::replaceId): (WebCore::Notification::setReplaceId):
  • notifications/Notification.idl:

2010-04-29 John Gregg <johnnyg@google.com>

Reviewed by Dmitry Titov.

notifications should have dir and replaceId attributes
Tests are disabled until the attributes are correctly handled
in Chromium test_shell.
https://bugs.webkit.org/show_bug.cgi?id=38336

  • fast/notifications/notifications-replace-expected.txt: Added.
  • fast/notifications/notifications-replace.html: Added.
  • fast/notifications/notifications-rtl-expected.txt: Added.
  • fast/notifications/notifications-rtl.html: Added.
  • platform/chromium/test_expectations.txt:
09:31 Changeset [58764] by eric@webkit.org

2010-05-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
https://bugs.webkit.org/show_bug.cgi?id=38119

Rename the property from wrt_viewMode to _q_viewMode.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::viewModes):

2010-05-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
https://bugs.webkit.org/show_bug.cgi?id=38119

Rename the property from wrt_viewMode to _q_viewMode.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):
09:24 Changeset [58763] by alex@webkit.org

2010-05-04 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Fixed error defining the float/double minimum in the object
properties, the smallest value of a float/double is
-G_MAXDOUBLE/-G_MAXFLOAT.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
08:55 Changeset [58762] by joepeck@webkit.org

2010-05-03 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Dan Bernstein.

REGRESSION: Text clipped in absolutely positioned search inputs
https://bugs.webkit.org/show_bug.cgi?id=38468

Update the test to include a second search field and show
the clipping of a search input is like a text input.

  • fast/css/input-search-padding.html:
  • platform/mac/fast/css/input-search-padding-expected.checksum:
  • platform/mac/fast/css/input-search-padding-expected.png:
  • platform/mac/fast/css/input-search-padding-expected.txt:

2010-05-03 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Dan Bernstein.

REGRESSION: Text clipped in absolutely positioned search inputs
https://bugs.webkit.org/show_bug.cgi?id=38468

Previously I incorrectly added x() and y() to the tx and ty positioning.
This clips a search input like a text input, respecting the vertically
centered text.

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): only the Y changes, so change setLocation to setY (WebCore::RenderTextControlSingleLine::controlClipRect):
08:41 Changeset [58761] by eric@webkit.org

2010-05-04 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: REGRESSION: Up/Down, PgUp/PgDown keys do not change numeric style properties
https://bugs.webkit.org/show_bug.cgi?id=38516

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
08:30 Changeset [58760] by eric@webkit.org

2010-05-04 Ben Murdoch <benm@google.com>

Reviewed by Simon Hausmann.

Crash in handleTouchEvent: using dangling node ptrs in hashmap
https://bugs.webkit.org/show_bug.cgi?id=38514

  • fast/events/touch/resources/touch-stale-node-crash.js: Added.
  • fast/events/touch/resources/send-touch-up.html: Added.
  • fast/events/touch/touch-stale-node-crash-expected.txt: Added.
  • fast/events/touch/touch-stale-node-crash.html: Added.

2010-05-04 Ben Murdoch <benm@google.com>

Reviewed by Simon Hausmann.

Crash in handleTouchEvent: using dangling node ptrs in hashmap
https://bugs.webkit.org/show_bug.cgi?id=38514

When navigating away from a page, if you have your finger still
pressed and then lift it on the new page we see a crash if the
node got deleted as we still have a dangling pointer in the
m_originatingTouchPointTargets hashmap and try to use it as the
receiver to dispatch a touchend event.

Test: fast/events/touch/touch-stale-node-crash.html

  • page/EventHandler.cpp: (WebCore::EventHandler::clear): Clear the hashmap of touch targets.
07:54 QtWebKitPackaging edited by hausmann@webkit.org
(diff)
07:53 QtWebKitPackaging edited by hausmann@webkit.org
(diff)
07:52 QtWebKitPackaging edited by hausmann@webkit.org
(diff)
07:29 Changeset [58759] by eric@webkit.org

2010-05-04 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Fix typo in run_webkit_tests.py: s/_print\./_printer./
https://bugs.webkit.org/show_bug.cgi?id=38515

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
07:15 Changeset [58758] by eric@webkit.org

2010-05-04 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Drawer Misbehaving when Docking / Undocking in Console Panel
https://bugs.webkit.org/show_bug.cgi?id=38510

  • inspector/front-end/inspector.js: (WebInspector.set attached): resize the drawer after docking/undocking
07:04 Changeset [58757] by eric@webkit.org

2010-05-04 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

[chromium] Make the select popup not close on right/middle clicks.
https://bugs.webkit.org/show_bug.cgi?id=38473

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseDown):
07:04 Changeset [58756] by laszlo.1.gombos@nokia.com

2010-05-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, build fix for Symbian.

[Symbian] Symbian builds does not support shadow builds

Revision r54715 broke the Symbian build. For Symbian
the include directory is generated in the root of the source tree.
This patch sets the INCLUDEPATH accordingly for Symbian.

  • WebKit.pri:
06:53 Changeset [58755] by eric@webkit.org

2010-05-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Holger Freyther.

Fix a memory leak inside the QScriptValue.

QSciptValuePrivate::toString should release all temporary variables.

[Qt] QScriptValue::toString have a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=38112

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toString):
06:30 Changeset [58754] by hausmann@webkit.org

[Qt] Preserve binary compatibility with qtwebkit-2.0 branch

Rubber-stamped by Tor Arne Vestbø.

Moved the WebGL attribute in QWebSettings to the end of the enum,
to ensure that the numeric values of the enum values following it
are the same as in the release branch.

  • Api/qwebsettings.h:
05:34 Changeset [58753] by kov@webkit.org

2010-05-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Darin Adler.

Does not work on SPARC because of alignment issues
https://bugs.webkit.org/show_bug.cgi?id=38455

Use AllocAlignmentInteger instead of void* on pageheap_memory to
avoid crashing at runtime in some architectures. Investigated by
Mike Hommey <mh@glandium.org>, change suggested by Darin Adler.

  • wtf/FastMalloc.cpp:
05:31 Changeset [58752] by laszlo.1.gombos@nokia.com

2010-05-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, build fix for Symbian.

[Symbian] Build fix after r58598.

Use C99 integer types for the Symbian plugin
implementation.

No new tests, as there is no new functionality.

  • plugins/symbian/PluginPackageSymbian.cpp: (WebCore::PluginPackage::NPVersion):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::handlePostReadFile):
05:07 Changeset [58751] by zimmermann@webkit.org

2010-05-04 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Split SVGCharacterLayoutInfo in smaller pieces
https://bugs.webkit.org/show_bug.cgi?id=38513

Split SVGCharacterLayoutInfo into SVGCharacterLayoutInfo/SVGCharacterData and SVGTextChunkLayoutInfo.
This is a preparation for more work in the text area.

  • Android.mk: Add SVGCharacterData.(cpp|h) and SVGTextChunkLayoutInfo.h to build.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/SVGCharacterData.cpp: Copied from rendering/SVGCharacterLayoutInfo.cpp.
  • rendering/SVGCharacterData.h: Copied from rendering/SVGCharacterLayoutInfo.h. (WebCore::SVGChar::SVGChar):
  • rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::isInitialLayout): Introduced new helper function to share code between addLayoutInformation/addStackContent. (WebCore::SVGCharacterLayoutInfo::addLayoutInformation): Use new helper function. (WebCore::SVGCharacterLayoutInfo::addStackContent): Ditto
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/SVGRootInlineBox.h: Include new files.
  • rendering/SVGTextChunkLayoutInfo.h: Copied from rendering/SVGCharacterLayoutInfo.h.
04:49 BuildingQtOnOSX edited by vestbo@webkit.org
(diff)
04:48 Changeset [58750] by jeremy@chromium.org

Revert r58747 - postponing Skia roll, at which time
we'll need to add these expected failures back.

https://bugs.webkit.org/show_bug.cgi?id=38512

  • platform/chromium/test_expectations.txt:
04:16 Changeset [58749] by xan@webkit.org

2010-05-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

[GTK] GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=33590

Use helper functions from CodeGenerator.pm to figure out whether a
type is "fundamental" or not (basically whether it's anything
other than a string or a non-pointer type).

  • bindings/scripts/CodeGeneratorGObject.pm:
03:25 Changeset [58748] by apavlov@chromium.org

2010-04-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: REGRESSION: Disabled style properties are absent in Styles sidebar after WebInspector is re-opened
https://bugs.webkit.org/show_bug.cgi?id=38255

Moved stylesheet-related mappings into a separate object stored
in InspectorController rather than InspectorDOMAgent (which gets reset
on every frontend [dis]connect).

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorCSSStore.cpp: Added. (WebCore::InspectorCSSStore::InspectorCSSStore): (WebCore::InspectorCSSStore::~InspectorCSSStore): (WebCore::InspectorCSSStore::reset):
  • inspector/InspectorCSSStore.h: Added.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setFrontend): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::bindStyle): (WebCore::InspectorDOMAgent::bindRule): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::buildObjectForRule):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::create): (WebCore::InspectorDOMAgent::cssStore):
02:55 Changeset [58747] by pfeldman@chromium.org

2010-05-04 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Pavel Feldman.

Preparing for chromium skia roll incorporating changes up to r561.
Add expected failures so bots don't turn red while rolling.

https://bugs.webkit.org/show_bug.cgi?id=38512

  • platform/chromium/test_expectations.txt:
02:36 Changeset [58746] by ossy@webkit.org

Unreviewed fix to make Qt bot happier.

r58712 made fast/workers/worker-gc2.html crash. It seems to be a DRT sideeffect,
skipping worker-event-listener.html solve the problem until we find a real fix.
https://bugs.webkit.org/show_bug.cgi?id=38502

  • platform/qt/Skipped: fast/workers/worker-event-listener.html skipped.
02:25 Changeset [58745] by mnaganov@chromium.org

2010-05-04 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Display "Recording..." item when recording an user-initiated CPU profile.

https://bugs.webkit.org/show_bug.cgi?id=38043

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.removeProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile):
  • inspector/front-end/inspector.js: (WebInspector.setRecordingProfile):
02:15 Changeset [58744] by eric@webkit.org

2010-05-04 Tucker Jay <jay.tucker@nokia.com>

Reviewed by Holger Freyther.

Animated GIF images does not animate 10x as expected by default.
https://bugs.webkit.org/show_bug.cgi?id=36818

Added test case to existing manual test to test the
fixed functionality.

  • manual-tests/qt/qt-10loop-anim.gif: Added.
  • manual-tests/qt/qt-gif-test.html:
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::repetitionCount):
01:27 Changeset [58743] by krit@webkit.org

2010-05-04 Dirk Schulze <krit@webkit.org>

Unreviewed sort of XCodes project file.

  • WebCore.xcodeproj/project.pbxproj:
01:06 Changeset [58742] by cjerdonek@webkit.org

2010-05-04 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Eric Seidel.

This revision completes the terminology change from "processor" to
"checker" for the CarriageReturnProcessor, CppProcessor,
PythonProcessor, and TextProcessor classes, etc.

https://bugs.webkit.org/show_bug.cgi?id=38262

The word "processor" currently has two uses in our code. This
revision renames the lower-level use to "checker" and preserves the
word "processor" for higher-level, more general uses. This
revision also makes whatever other name changes that logically
followed from this change.

  • Scripts/check-webkit-style:
    • Updated references to PatchChecker.
  • Scripts/webkitpy/style/checker.py:
    • Renamed the StyleCheckerConfiguration class to StyleProcessorConfiguration.
    • Renamed the ProcessorDispatcher class to CheckerDispatcher, and made similar changes for the class's method names.
    • Renamed the PatchChecker class to PatchReader.
    • Updated the file as necessary to accommodate the other class renames in this patch.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/common.py:
    • Renamed the CarriageReturnProcessor class to CarriageReturnChecker, and changed its process() method to check().
  • Scripts/webkitpy/style/checkers/common_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/cpp.py:
    • Renamed the CppProcessor class to CppChecker, and renamed its process() method to check().
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/python.py:
    • Renamed the PythonProcessor class to PythonChecker, and renamed its process() method to check().
  • Scripts/webkitpy/style/checkers/python_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/checkers/text.py:
    • Renamed the TextProcessor class to TextChecker, and renamed its process() method to check().
  • Scripts/webkitpy/style/checkers/text_unittest.py:
    • Updated the unit test code as necessary.
  • Scripts/webkitpy/style/error_handlers.py:
    • Updated the code as necessary.
  • Scripts/webkitpy/style/error_handlers_unittest.py:
    • Updated the unit test code as necessary.
01:00 Changeset [58741] by cjerdonek@webkit.org

2010-05-04 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Eric Seidel.

Adjusted svn-apply and -unapply to accept git diffs generated
using the --no-prefix flag.

https://bugs.webkit.org/show_bug.cgi?id=32438

  • Scripts/VCSUtils.pm:
    • Loosened the regular expression for the "diff --git" line to match when the --no-prefix flag is used with "git diff".
    • Also refactored the code parsing the first line so that the script exits with an error message if the first line cannot be parsed.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
    • Added a unit test case for the --no-prefix case.
00:57 Changeset [58740] by abarth@webkit.org

2010-05-04 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add first WTFURL file
https://bugs.webkit.org/show_bug.cgi?id=38470

This class represents a component of a URL, such as the scheme or path.
Essentially, the class is an index into a string buffer.

  • wtf/url: Added.
    • There was some discussion about where to put the URL library. There are a number of reasonable options, but putting the library in the WTF directory seems like a reasonable alternative. This location will make more sense once WTF is moved out of JavaScriptCore and into a top-level directory.
  • wtf/url/src: Added.
    • I've added this extra directory to the usual structure because we eventually want a "public" folder that defines the public interface to this library that clients outside of svn.webkit.org can rely upon, much like the various subfolders of the WebKit directory often define a public API.
  • wtf/url/src/URLComponent.h: Added.
    • I've added this somewhat trivial class to get the ball rolling.

(WTF::URLComponent::URLComponent):
(WTF::URLComponent::isValid):
(WTF::URLComponent::isNonempty):
(WTF::URLComponent::reset):
(WTF::URLComponent::operator==):
(WTF::URLComponent::begin):
(WTF::URLComponent::setBegin):
(WTF::URLComponent::length):
(WTF::URLComponent::setLength):
(WTF::URLComponent::end):

  • wtf/url/wtfurl.gyp: Added.
    • WTFURL will be an independently buildable library, hence the beginnings of a wtfurl.gyp file.
00:55 Changeset [58739] by cjerdonek@webkit.org

2010-05-04 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Daniel Bates.

Changed VCSUtils.pm's parseDiffHeader() to call the new
parseGitDiffHeader() method.

https://bugs.webkit.org/show_bug.cgi?id=38454

This revision makes more progress towards adding executable-bit
support to svn-apply and svn-unapply. It also makes more progress
towards refactoring the code into a more maintainable form.

  • Scripts/VCSUtils.pm:
    • Removed gitdiff2svndiff().
    • Removed the Git-specific logic from parseDiffHeader() and renamed it parseSvnDiffHeader().
    • Added a new parseDiffHeader() subroutine which calls parseSvnDiffHeader() or parseGitDiffHeader() depending on the format of the first header line.
  • Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Removed.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Removed most of the test cases since these cases are now covered by the unit tests for parseSvnDiffHeader() and parseGitDiffHeader().
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl: Added.
    • Copied the SVN unit tests from parseDiffHeader.pl and updated them as necessary.
00:22 Changeset [58738] by alex@webkit.org

2010-05-04 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip test.

Skipping inspector/timeline-parse-html.html
https://bugs.webkit.org/show_bug.cgi?id=38509

  • platform/gtk/Skipped:
00:03 Changeset [58737] by eric@webkit.org

2010-05-03 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Builders should run the perl and python unit tests on every commit
https://bugs.webkit.org/show_bug.cgi?id=37976

The unit tests take a few seconds to run, so they should not
have any noticable effect on builder speed.

We're running the tests everywhere but Tiger as Tiger's
Python version is ancient.
I would have rather have detected the python version of the
slave but I couldn't find any API to do that, and I didn't want
to hack version detection into test-webkitpy (at least not yet).

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

05/03/10:

23:52 Changeset [58736] by eric@webkit.org

2010-05-03 Steven Lai <steven_lai@asia.apple.com>

Reviewed by Brady Eidson.

Test hashchange() event is fired in asynchronous manner.
https://bugs.webkit.org/show_bug.cgi?id=36201

  • fast/loader/hashchange-event-async-expected.txt: Added.
  • fast/loader/hashchange-event-async.html: Added.

2010-05-03 Steven Lai <steven_lai@asia.apple.com>

Reviewed by Brady Eidson.

Reverted hashchange() event back to async.
(This change does not update HashChangeEvent to its new proposed interface)
https://bugs.webkit.org/show_bug.cgi?id=36201
rdar://problem/7780794
rdar://problem/7761278 (partial fix)

Tests: fast/loader/hashchange-event-async.html

  • dom/Document.cpp: reverted hashchange() event back to async (WebCore::Document::enqueueHashchangeEvent):
23:14 Changeset [58735] by cjerdonek@webkit.org

2010-05-03 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Adam Barth.

Fixed a recent REGRESSION that caused svn-apply and -unapply to
skip over changes to the first file in a diff if leading junk was
present (like in an e-mail diff) and if the --force option was used.

https://bugs.webkit.org/show_bug.cgi?id=38507

  • Scripts/svn-apply:
    • Removed the bit of code at the beginning of the patch() subroutine that checks for the "Index:" line at the beginning of a file diff (since the parsePatch() subroutine already checks this).
  • Scripts/svn-unapply:
    • Removed the bit of code at the beginning of the patch() subroutine that checks for the "Index:" line at the beginning of a file diff (since the parsePatch() subroutine already checks this).
21:44 Changeset [58734] by zecke@webkit.org

[Cairo,WX] Stop leaking a FontPlatformData.

Allocate the FontPlatformData on the stack and fix
a memory leak by doing so.

2010-05-03 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber-stamped by Xan Lopez.

[Cairo,WX] Stop leaking a FontPlatformData.
https://bugs.webkit.org/show_bug.cgi?id=37500

Stephan Aßmus pointed out that the pango font backend
is leaking memory and fixed it. The WX font backend
and the Cairo/Fontconfig backend have the same snippet
of code and are leaking memory as well. This commit is
fixing that.

  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::smallCapsFontData):
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::smallCapsFontData):
21:16 Changeset [58733] by cjerdonek@webkit.org

Unreviewed.

Adjusted the ChangeLog entry below for r58732 (bug 35804) to reflect
the fact that the change will not become active until the patch
for bug 38454 lands.

21:00 Changeset [58732] by cjerdonek@webkit.org

2010-05-03 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Eric Seidel.

The svn-apply and svn-unapply scripts now display an instructive
error message if the --binary flag is left off the "git diff" command
for diffs containing binary file differences.

https://bugs.webkit.org/show_bug.cgi?id=35804

  • Scripts/VCSUtils.pm:
    • Adjusted parseDiffHeader() to exit with an appropriate error message if it encounters a line of the form "Binary files <path1> and <path2> differ".
19:53 Changeset [58731] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests: r58728 broke the buildbot logic for parsing the
output of the log; specifying --verbose should basically be equivalent
to --print everything, but instead it was equivalent to not specifying
--print and getting the default set. Now, --verbose acts as if
--print everything was implicitly specified as the default (you can
still override it if you specify both; this is a somewhat debatable
call).

https://bugs.webkit.org/show_bug.cgi?id=38504

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
19:39 Changeset [58730] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=38368
<rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028
(return memory quicker).
Instead of returning everything but the smallest spans spread out
the spans kept over several size lists.

Reviewed by Geoff Garen.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::scavenge):

19:26 Changeset [58729] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

new-run-webkit-tests: Fix minor precedence bug introduced in r58728 where we printed
"-\n" 78 times instead of "-" 78 times followed by a single "\n".

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
18:59 Changeset [58728] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: refactor a large chunk of the printing/logging
code out of run-webkit-tests py (almost 300 lines out of 1900).

This change also renames --log to --print (to be slightly more
descriptive). I've also added better help messages for printing.

The new code has unit tests!

There is still more code to be moved, but this patch is big enough as
it is. Namely, still to move are the printing of the actual results
and the timing statistics, which should move another 300-400 lines
out of the file.

Notable changes to run_webkit_tests.py beyond code simply moving:

  • MeteredStream is now hidden under the new printing.Printer class. All the references to self._meter now point to self._printer.
  • All logging configuration is done in printing.configure_logging()
  • Instead of using write() lambdas to control what is and isn't printed, we use separate methods on the printer object. This will make it easier to grep which print statements are printed under protection of each flag.
  • The print_results flag I added a few revs back to suppress printing in the unit tests has been replaced with --print nothing.
  • The ResultSummary class now stores the entire TestResult for each test, not just the actual result type.
  • summarize_unexpected_results() got moved from a method on TestRunner to a standalone function. This should move into a separate file along with the ResultSummary class and the TestResult class
  • The --trace option added recently has been replaced by '--print trace-everything' and '--print trace-unexpected'

https://bugs.webkit.org/show_bug.cgi?id=38018

  • Scripts/new-run-webkit-tests:
    • update to new entry points in run_webkit_tests.py
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
    • fix a minor nit where we were printing an empty string where we didn't need to
  • Scripts/webkitpy/layout_tests/layout_package/printing.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Added
  • Scripts/webkitpy/layout_tests/port/test.py:
    • implement relative_test_filename() and expected_filename() so we can test printing unexpected results in a platform-neutral way
  • Scripts/webkitpy/run_webkit_test.py:
    • move a lot of the printing code into printing.py
    • change the signatures of the exported entry points for easier unit testing
  • Scripts/webkitpy/run_webkit_tests_unittest.py:
    • update w/ changes to run_webkit_tests entry points.
18:55 Changeset [58727] by laszlo.1.gombos@nokia.com

2010-05-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Expose HTMLTokenizer yielding parameters
https://bugs.webkit.org/show_bug.cgi?id=37023

Enables to set TimeDelay and ChunkSize for
HTMLTokenizer.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent):
18:37 Changeset [58726] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Fix expectation for fast/forms/searchfield-heights.html - IMAGE+TEXT
on Linux, IMAGE on win and mac.

  • platform/chromium/test_expectations.txt:
18:32 Changeset [58725] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Restore editing/pasteboard/paste-xml.xhtml as failing w/ a TEXT
failure (was failing prior to landing fix for 27751).

Mark editiing/selection/caret-rtl-2.html as failing w/ IMAGE; need
to investigate further.

Mark svg/text/kerning.svg as failing on mac w/ IMAGE as well as Linux.

  • platform/chromium/test_expectations.txt:
18:08 Changeset [58724] by dpranke@chromium.org

2010-05-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Dirk Pranke.

Roll back test expectations change, initially needed to land bug 27751.

  • platform/chromium/test_expectations.txt:
17:45 Changeset [58723] by bweinstein@apple.com

Touch WebKit.idl to force a rebuild

17:42 Changeset [58722] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Roll in Chromium expectations from overrides file.

  • platform/chromium/test_expectations.txt:
17:35 Changeset [58721] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Mark the SVG test failures as linux-only.
Mark fast/forms/searchfield-heights.html as IMAGE+TEXT, not IMAGE.

  • platform/chromium/test_expectations.txt:
17:15 Changeset [58720] by andersca@apple.com

2010-05-03 Anders Carlsson <andersca@apple.com>

Reviewed by Jon Honeycutt.

[WebKit2] WKView should respond to WM_SHOWWINDOW messages
https://bugs.webkit.org/show_bug.cgi?id=38496

  • UIProcess/win/WebView.cpp: (WebKit::WebView::wndProc): Add case for WM_SHOWWINDOW.

(WebKit::WebView::onShowWindowEvent):
Update the page visibility accordingly.

  • UIProcess/win/WebView.h:
17:07 Changeset [58719] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

And add one more Linux test (fast/forms/search-placeholder-value-changed.html)
from r58700. Plus, fix sorting of tests from that rev.

  • platform/chromium/test_expectations.txt:
17:03 Changeset [58718] by jamesr@google.com

2010-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

Clean up a few compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=38073

  • wtf/text/StringImpl.cpp: (WebCore::StringImpl::ascii):

2010-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

Clean up a few compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=38073

  • html/TextMetrics.h: (WebCore::TextMetrics::width):
  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.h:
17:01 Changeset [58717] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Mark yet more mac-specific tests as failling from r58700.

  • platform/chromium/test_expectations.txt:
16:48 Changeset [58716] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Mark more tests as failing from r58700 and change the sandbox test from SLOW to a
flaky PASS TIMEOUT.

  • platform/chromium/test_expectations.txt:
16:43 Changeset [58715] by darin@apple.com
  • English.lproj/Localizable.strings: Regenerated.
  • StringsNotToBeLocalized.txt: Updated for recent changes.
16:09 Changeset [58714] by andersca@apple.com

2010-05-03 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of PageClient::isPageVisible and pass visibility directly in setPageIsVisible
https://bugs.webkit.org/show_bug.cgi?id=38493

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: Remove isPageVisible.


  • UIProcess/API/mac/WKView.mm: (isViewVisible): New function (moved here from PageClientImpl).


(-[WKView _updateVisibility]):
Call didChangeVisibility.


(-[WKView viewDidMoveToWindow]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
Call _updateVisibility.


  • UIProcess/DrawingAreaProxy.h: Rename didChangeVisibility to setPageIsVisible and add an isVisible parameter.


  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::setPageIsVisible): Don't call WebPageProxy::isVisible.
  • UIProcess/DrawingAreaProxyUpdateChunk.h:


  • UIProcess/PageClient.h: Remove isPageVisible.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h: Remove isVisible.
16:07 Changeset [58713] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Mark more editing/* tests from r58703 as failing. Also, (re-?) add the SVG tests again
as they do fail on some platforms.

  • platform/chromium/test_expectations.txt:
16:03 Changeset [58712] by barraclough@apple.com

Rolling out r58114 - this introduced memory leaks of
AtomicStrings then workers terminated.

Reviewed by NOBODY (reverting previous commit).

(JSC::ThunkHelpers::stringImplDataOffset):

  • runtime/Identifier.cpp:

(JSC::IdentifierTable::~IdentifierTable):
(JSC::IdentifierTable::add):
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierCStringTranslator::equal):
(JSC::IdentifierCStringTranslator::translate):
(JSC::Identifier::add):
(JSC::IdentifierUCharBufferTranslator::hash):
(JSC::IdentifierUCharBufferTranslator::equal):
(JSC::IdentifierUCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):

  • runtime/Identifier.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:
  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

  • wtf/WTFThreadData.h:

(JSC::IdentifierTable::remove):
(JSC::IdentifierTable::literalTable):
(WTF::WTFThreadData::atomicStringTable):

  • wtf/text/AtomicString.cpp:

(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable):
(WebCore::CStringTranslator::hash):
(WebCore::CStringTranslator::equal):
(WebCore::CStringTranslator::translate):
(WebCore::operator==):
(WebCore::AtomicString::add):
(WebCore::equal):
(WebCore::UCharBufferTranslator::hash):
(WebCore::UCharBufferTranslator::equal):
(WebCore::UCharBufferTranslator::translate):
(WebCore::HashAndCharactersTranslator::hash):
(WebCore::HashAndCharactersTranslator::equal):
(WebCore::HashAndCharactersTranslator::translate):
(WebCore::AtomicString::find):
(WebCore::AtomicString::remove):

  • wtf/text/AtomicStringTable.h: Removed.
  • wtf/text/StringImpl.cpp:

(WebCore::StringImpl::~StringImpl):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::inTable):
(WebCore::StringImpl::setInTable):
(WebCore::equal):

  • wtf/text/StringImplBase.h:

(WTF::StringImplBase::StringImplBase):

15:46 Changeset [58711] by ossy@webkit.org

[Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot
Fails caused by layoutTestController.display() in fast/frames/flattening/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=37334

  • platform/qt/Skipped:
    • fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix
    • fast/frames/flattening/frameset-flattening-subframesets.html unskipped, because it works.
15:37 Changeset [58710] by dumi@chromium.org

Add the ability to auto-generate callbacks to all code generators.
https://bugs.webkit.org/show_bug.cgi?id=38414

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp: Added.

(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
(WebCore::JSTestCallback::callbackWithClass1Param):
(WebCore::JSTestCallback::callbackWithClass2Param):

  • bindings/scripts/test/JS/JSTestCallback.h: Added.

(WebCore::JSTestCallback::create):

  • bindings/scripts/test/V8/JSTestCallback.cpp: Added.

(WebCore::V8TestCallback::V8TestCallback):
(WebCore::V8TestCallback::~V8TestCallback):
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):

  • bindings/scripts/test/V8/V8TestCallback.h: Added.

(WebCore::V8TestCallback::create):

  • bindings/scripts/test/TestCallback.idl: Added.
15:37 Changeset [58709] by kevino@webkit.org

Reviewed by Kevin Ollivier.

[wx] Implement scheduleDispatchFunctionsOnMainThread for wx port.
https://bugs.webkit.org/show_bug.cgi?id=38480

15:34 Changeset [58708] by kevino@webkit.org

Fix missing bug URL.

15:31 Changeset [58707] by kevino@webkit.org

Reviewed by Kevin Ollivier.

[wx] Build and use Mac's ComplexTextController to support complex text in wx.
https://bugs.webkit.org/show_bug.cgi?id=38482

15:27 Changeset [58706] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Mark the editing/* tests from r58703 as temporarily expected to fail
until the other half of the two-sided patch can land.

  • platform/chromium/test_expectations.txt:
15:18 Changeset [58705] by oliver@apple.com

2010-05-03 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Interpreter crashes due to incorrect refcounting of cached structures.
https://bugs.webkit.org/show_bug.cgi?id=38491
rdar://problem/7926160

Make sure we ref/deref structures used for cached custom property getters

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures):

2010-05-03 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Interpreter crashes due to incorrect refcounting of cached structures.
https://bugs.webkit.org/show_bug.cgi?id=38491

Add test for cached structure chains used for custom getters.

  • fast/js/pic/cached-named-property-getter.html:
14:51 Changeset [58704] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Fix duplicate expectation, remove the SVG tests added in r58700.

  • platform/chromium/test_expectations.txt:
14:50 Changeset [58703] by abarth@webkit.org

2010-05-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Tests that javascript cannot access clipboard.
https://bugs.webkit.org/show_bug.cgi?id=27751

  • editing/execCommand/clipboard-access-expected.txt: Added.
  • editing/execCommand/clipboard-access.html: Added.
  • editing/execCommand/script-tests/clipboard-access.js: Added. (enabled): (whenEnabled):

2010-05-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751

Test: editing/execCommand/clipboard-access.html

  • WebCore.base.exp:
  • editing/EditorCommand.cpp: (WebCore::supportedCopyCut): (WebCore::supportedPaste): (WebCore::createCommandMap):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setJavaScriptCanAccessClipboard):
  • page/Settings.h: (WebCore::Settings::javaScriptCanAccessClipboard):

2010-05-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
  • src/WebSettingsImpl.h:

2010-05-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2010-05-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences javaScriptCanAccessClipboard]): (-[WebPreferences setJavaScriptCanAccessClipboard:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-05-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-05-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::javaScriptCanAccessClipboard): (WebPreferences::setJavaScriptCanAccessClipboard):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

2010-05-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Add support for controlling clipboard access from javascript.
Clipboard access from javascript is enabled in test framework.
https://bugs.webkit.org/show_bug.cgi?id=27751

  • DumpRenderTree/LayoutTestController.cpp: (setJavaScriptCanAccessClipboardCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::overridePreference):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
14:43 Changeset [58702] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Mark a sandbox test as SLOW and change one of the fast/forms tests I
just changed from IMAGE+TEXT->IMAGE back to IMAGE.

  • platform/chromium/test_expectations.txt:
14:34 Changeset [58701] by andersca@apple.com

2010-05-03 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Maui MiniBrowser: Add an option to show/hide the web view
https://bugs.webkit.org/show_bug.cgi?id=38486

  • MiniBrowser/win/BrowserWindow.cpp: (BrowserWindow::createWindow): Set the background brush to something other than null.

(BrowserWindow::onCommand):
Show and hide the web view accordingly.


  • MiniBrowser/win/MiniBrowser.rc:
  • MiniBrowser/win/resource.h: Add new menu item.
14:15 Changeset [58700] by dpranke@chromium.org

2010-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Change expectations for some of the fast/forms tests that just started
failing from IMAGE+TEXT to just IMAGE, and add some failing SVG tests
so that we can get the bots to green up.

  • platform/chromium/test_expectations.txt:
13:45 Changeset [58699] by eric@webkit.org

2010-05-03 Kevin Watters <kevinwatters@gmail.com>

Reviewed by Kevin Ollivier.

Provide access to GrantUniversalAccess to allow enabling of XSS support.

  • WebFrame.cpp: (wxWebFrame::GrantUniversalAccess):
  • WebFrame.h:
  • WebView.cpp: (wxWebView::GetParseMode): (wxWebView::GrantUniversalAccess):
  • WebView.h:
13:36 Changeset [58698] by yaar@chromium.org

2010-05-03 Yaar Schnitman <yaar@chromium.org>

Not Reviewed.

Preparing for chromium webkit roll 58626:TBD: Rebaselines
https://bugs.webkit.org/show_bug.cgi?id=38485

  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium/test_expectations.txt:
13:19 Changeset [58697] by andersca@apple.com

2010-05-03 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Implement PageClient::isPageVisible on Windows.
https://bugs.webkit.org/show_bug.cgi?id=38483

  • UIProcess/PageClient.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::isPageVisible):
  • UIProcess/win/WebView.h:
13:12 Changeset [58696] by ap@apple.com

Fixed a typo in ChangeLog.

13:04 Changeset [58695] by ap@apple.com

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=38285
<rdar://problem/7903453> REGRESSION: Javascript command window.open does not work in empty tab

Cannot be tested, because new windows created in DRT always have an opener, and thus inherit
its security origin. Only new windows and tabs created by browser chrome had this problem.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Moved updateSandboxFlags() call to the beginning, so that an initial document would get correct flags.

LayoutTests:

These tests don't verify that this bug is fixed (that cannpt be tested automatically),
but test closely related behavior that hasn't been covered before.

  • http/tests/security/resources/iframe-no-src.html: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-2.html: Added.
  • http/tests/security/sandbox-inherit-to-initial-document-expected.txt: Added.
  • http/tests/security/sandbox-inherit-to-initial-document.html: Added.
12:51 Changeset [58694] by eric@webkit.org

2010-05-03 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Darin Adler.

WebGL compile issue.
Added ExceptionCode.h to JSWebGLArrayBufferConstructor.cpp, for some reason it was missing.
https://bugs.webkit.org/show_bug.cgi?id=38453

No new tests: compile fix.

  • bindings/js/JSWebGLArrayBufferConstructor.cpp:
12:47 Changeset [58693] by andersca@apple.com

Fix Windows build.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

  • Shared/win/UpdateChunk.cpp:

(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):

  • Shared/win/UpdateChunk.h:

(WebKit::UpdateChunk::rect):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyUpdateChunk.h:
  • UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp:

(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):

  • WebProcess/WebPage/win/DrawingAreaUpdateChunkWin.cpp:

(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):

  • WebProcess/win/WebProcessMain.cpp:
12:11 Changeset [58692] by yaar@chromium.org

2010-05-03 Yaar Schnitman <yaar@chromium.org>

Not Reviewed.

Preparing for Chromium WebKit roll 58626:TBD
https://bugs.webkit.org/show_bug.cgi?id=38479

  • platform/chromium/test_expectations.txt: added missing expectation
11:51 Changeset [58691] by yaar@chromium.org

2010-05-03 Yaar Schnitman <yaar@chromium.org>

Not Reviewed.

Added missing chromium baselines for svg text kerning
https://bugs.webkit.org/show_bug.cgi?id=38476

  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • platform/chromium-win/svg/text/kerning-expected.checksum:
  • platform/chromium-win/svg/text/kerning-expected.png:
  • platform/chromium-win/svg/text/text-hkern-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-hkern-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:49 Changeset [58690] by eric@webkit.org

2010-05-03 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r58685.
http://trac.webkit.org/changeset/58685
https://bugs.webkit.org/show_bug.cgi?id=38461

Broke a test on Gtk

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates):
11:23 Changeset [58689] by yaar@chromium.org

2010-05-03 Yaar Schnitman <yaar@chromium.org>

Not Reviewed.

Preparing for chromium webkit roll 58626:TBD
https://bugs.webkit.org/show_bug.cgi?id=38474

  • platform/chromium/test_expectations.txt: Added temporary expectations.
11:19 Changeset [58688] by andersca@apple.com

2010-04-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=38415
Have the WKView notify the DrawingAreaProxy when its visibility changes.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::isPageVisible):
  • UIProcess/API/mac/WKView.mm: (-[WKView viewDidMoveToWindow]): (-[WKView viewDidHide]): (-[WKView viewDidUnhide]):
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: (WebKit::DrawingAreaProxyUpdateChunk::DrawingAreaProxyUpdateChunk): (WebKit::DrawingAreaProxyUpdateChunk::didChangeVisibility):
  • UIProcess/DrawingAreaProxyUpdateChunk.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::isVisible):
  • UIProcess/WebPageProxy.h:
11:16 Changeset [58687] by yael.aharon@nokia.com

Use HTML5 number parsing in HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=38434

Reviewed by Darin Adler.

WebCore:

Use parseToDoubleForNumberType instead of toDouble.
Throw an exception when the number is NaN or Infinity.

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::value):
(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::max):
(WebCore::HTMLProgressElement::setMax):

  • html/HTMLProgressElement.h:
  • html/HTMLProgressElement.idl:

LayoutTests:

  • fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
  • fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:
11:12 Changeset [58686] by eric@webkit.org

2010-05-03 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareSubmit): Call frame loader's dispatchWillSendSubmitEvent
  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchWillSendSubmitEvent): New empty method

2010-05-03 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • efl/WebCoreSupport/FrameLoaderClientEfl.h: (WebCore::FrameLoaderClientEfl::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • public/WebFrameClient.h: (WebKit::WebFrameClient::willSendSubmitEvent): New empty method
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendSubmitEvent): Delegate to client
  • src/FrameLoaderClientImpl.h:

2010-05-03 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientGtk.h: (WebKit::FrameLoaderClient::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientHaiku.h: (WebCore::FrameLoaderClientHaiku::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/WebFrameLoaderClient.h: (WebFrameLoaderClient::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientQt.h: (WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebFrame.h:

2010-05-03 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebKitSupport/FrameLoaderClientWx.h: (WebCore::FrameLoaderClientWx::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h: (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
10:58 Changeset [58685] by philn@webkit.org

2010-05-03 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] forgotten call to durationChanged in updateStates()
https://bugs.webkit.org/show_bug.cgi?id=38461

Notify MediaPlayer if duration is known after playback started.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates):
10:28 Changeset [58684] by weinig@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=38471
Add generic callback mechanism

Reviewed by Anders Carlsson.

Added GenericCallback class replacing RenderTreeExternalRepresentationCallback
and ScriptReturnValueCallback.

Also,

  • Standardize C API callbacks to take the context last.
  • Standardize C API callbacks to not have the _f suffix (now the block variants have a _b suffix).
  • Re-write toWK and toRef methods as a set of template functions using the generic API->implementation mapping information.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageRunJavaScriptInMainFrame):
(callRunJavaScriptBlockAndRelease):
(disposeRunJavaScriptBlock):
(WKPageRunJavaScriptInMainFrame_b):
(WKPageRenderTreeExternalRepresentation):
(WKPageRenderTreeExternalRepresentation_b):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/GenericCallback.h: Added.

(WebKit::GenericCallback::create):
(WebKit::GenericCallback::~GenericCallback):
(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::GenericCallback::invalidate):
(WebKit::GenericCallback::callbackID):
(WebKit::GenericCallback::generateCallbackID):
(WebKit::GenericCallback::GenericCallback):

  • UIProcess/RenderTreeExternalRepresentationCallback.cpp: Removed.
  • UIProcess/RenderTreeExternalRepresentationCallback.h: Removed.
  • UIProcess/ScriptReturnValueCallback.cpp: Removed.
  • UIProcess/ScriptReturnValueCallback.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
10:25 Changeset [58683] by abarth@webkit.org

Remove URLCore top-level directory. The diff wasn't clear where this folder was going and Darin Adler would prefer that we not put this code in a top-level directory.

10:24 Changeset [58682] by eric@webkit.org

2010-05-03 Ryuan Choi <ryuan.choi@gmail.com>

Reviewed by Darin Adler.

fixing build break due to clearWatch() when Geolocation feature is
disabled.

https://bugs.webkit.org/show_bug.cgi?id=38091

no test because this is a build fix only

  • page/Geolocation.cpp: (WebCore::Geolocation::clearWatch):
10:09 Changeset [58681] by eric@webkit.org

2010-05-03 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Daniel Bates.

Added a parseGitDiffHeader() subroutine to VCSUtils.pm that
parses any changes to the executable bit in a Git diff.

https://bugs.webkit.org/show_bug.cgi?id=38425

This revision is more preparation towards adding "executable bit"
support to svn-apply and svn-unapply. No code is going "live" in
this change except for the new unit tests in test-webkitperl.

  • Scripts/VCSUtils.pm:
    • Added isExecutable() to determine whether a file mode has the executable bit set or not.
    • Added parseGitDiffHeader() to parse the header of a Git diff.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Added.
    • Added unit tests for parseGitDiffHeader().
10:00 Changeset [58680] by abarth@webkit.org

Add empty folder to house URL parser
https://bugs.webkit.org/show_bug.cgi?id=38470

Reviewed by Darin Adler.

Add URLCore directory.

09:56 Changeset [58679] by eric@webkit.org

2010-05-03 Stephan Aßmus <superstippi@gmx.de>

Reviewed by Holger Freyther.

[Gtk] Fix leaking the FontPlatformData instance used to create the the
small caps font data.
https://bugs.webkit.org/show_bug.cgi?id=37500

No new tests needed.

  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::smallCapsFontData):
    • Use a stack allocated FontPlatformData instead of a heap allocated one that is never freed.
09:37 Changeset [58678] by eric@webkit.org

2010-05-03 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: support webGL
https://bugs.webkit.org/show_bug.cgi?id=35388

Added support GraphicsContext3D to GraphicsLayer.
Added paint method to GraphicsContext3D for Qt platform that
uses drawTexture() when QGLWidget is used as viewport of
QGraphicsWebView.
Fine-tuned texture and handling and image to texture conversion to
work also when drawTexture() blitting is used.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::paint): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::): (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToGraphicsContext3D): (WebCore::GraphicsLayerQt::setGraphicsContext3DNeedsDisplay):
  • platform/graphics/qt/GraphicsLayerQt.h:
09:20 Changeset [58677] by abarth@webkit.org

2010-05-03 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add some more Chromium-specific files to gitignore
https://bugs.webkit.org/show_bug.cgi?id=38469

These files are generated as part of the update-webkit --chromium
script.

  • .gitignore:
08:59 Changeset [58676] by ossy@webkit.org

Unreviewed. Qt specific expected files added after r58675.

  • platform/qt/editing/pasteboard/4944770-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/5028447-expected.txt: Added.
  • platform/qt/editing/pasteboard/5089327-expected.txt: Added.
  • platform/qt/editing/pasteboard/5601583-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-text-013-expected.txt: Added.
  • platform/qt/editing/pasteboard/select-element-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/testcase-9507-expected.txt: Added.
  • platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
  • platform/qt/editing/pasteboard/unrendered-br-expected.txt: Added.
08:39 Changeset [58675] by robert@webkit.org

2010-05-03 Csaba Osztrogonác <ossy@webkit.org>

Unreviewed. Qt specific expected files added and updated.

[Qt] Unskip editing/pasteboard tests that fail due to 'x,y' differences
https://bugs.webkit.org/show_bug.cgi?id=38435

  • platform/qt/editing/pasteboard/3976872-expected.txt:
  • platform/qt/editing/pasteboard/4076267-3-expected.txt:
  • platform/qt/editing/pasteboard/4242293-expected.txt:
  • platform/qt/editing/pasteboard/4631972-expected.txt:
  • platform/qt/editing/pasteboard/4641033-expected.txt:
  • platform/qt/editing/pasteboard/4700297-expected.txt:
  • platform/qt/editing/pasteboard/4806874-expected.txt:
  • platform/qt/editing/pasteboard/4840662-expected.txt:
  • platform/qt/editing/pasteboard/4944770-1-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/4989774-expected.txt:
  • platform/qt/editing/pasteboard/5006779-expected.txt:
  • platform/qt/editing/pasteboard/5027857-expected.txt:
  • platform/qt/editing/pasteboard/5028447-expected.txt: Added.
  • platform/qt/editing/pasteboard/5032095-expected.txt:
  • platform/qt/editing/pasteboard/5065605-expected.txt:
  • platform/qt/editing/pasteboard/5071074-2-expected.txt:
  • platform/qt/editing/pasteboard/5071074-expected.txt:
  • platform/qt/editing/pasteboard/5075944-2-expected.txt:
  • platform/qt/editing/pasteboard/5075944-3-expected.txt:
  • platform/qt/editing/pasteboard/5075944-expected.txt:
  • platform/qt/editing/pasteboard/5089327-expected.txt: Added.
  • platform/qt/editing/pasteboard/5134759-expected.txt:
  • platform/qt/editing/pasteboard/5156401-1-expected.txt:
  • platform/qt/editing/pasteboard/5245519-expected.txt:
  • platform/qt/editing/pasteboard/5247341-expected.txt:
  • platform/qt/editing/pasteboard/5368833-expected.txt:
  • platform/qt/editing/pasteboard/5478250-expected.txt:
  • platform/qt/editing/pasteboard/5483567-expected.txt:
  • platform/qt/editing/pasteboard/5601583-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/5780697-2-expected.txt:
  • platform/qt/editing/pasteboard/7955-expected.txt:
  • platform/qt/editing/pasteboard/8145-1-expected.txt:
  • platform/qt/editing/pasteboard/8145-2-expected.txt:
  • platform/qt/editing/pasteboard/8145-3-expected.txt:
  • platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
  • platform/qt/editing/pasteboard/cut-text-001-expected.txt:
  • platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/displaced-placeholder-expected.txt:
  • platform/qt/editing/pasteboard/display-block-on-spans-expected.txt:
  • platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
  • platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-3-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-4-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-3-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-4-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-5-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-list-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-table-expected.txt:
  • platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
  • platform/qt/editing/pasteboard/merge-start-list-expected.txt:
  • platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-4038267-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-1-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-2-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-3-expected.txt:
  • platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-line-endings-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-004-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
  • platform/qt/editing/pasteboard/paste-list-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-pre-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-pre-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-table-cells-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-004-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-009-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-010-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-011-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-012-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-013-expected.txt: Added.
  • platform/qt/editing/pasteboard/paste-text-014-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-015-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-016-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-017-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-018-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-019-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
  • platform/qt/editing/pasteboard/pasting-object-expected.txt:
  • platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
  • platform/qt/editing/pasteboard/quirks-mode-br-1-expected.txt:
  • platform/qt/editing/pasteboard/select-element-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/styled-element-markup-expected.txt:
  • platform/qt/editing/pasteboard/testcase-9507-expected.txt: Added.
  • platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
  • platform/qt/editing/pasteboard/unrendered-br-expected.txt: Added.

2010-05-03 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Unskip editing/pasteboard tests that fail due to 'x,y' differences

https://bugs.webkit.org/show_bug.cgi?id=38435

Unskip a large number of editing/pasteboard tests that fail only due
to rendertree differences in the height/width of rendered text.

Reduce the skipped editing/pasteboard tests to those that fail for
a good reason and add some initial commentary on each.

Unskip:

editing/pasteboard/3976872.html
editing/pasteboard/4076267-3.html
editing/pasteboard/4242293.html
editing/pasteboard/4631972.html
editing/pasteboard/4641033.html
editing/pasteboard/4700297.html
editing/pasteboard/4840662.html
editing/pasteboard/4944770-1.html
editing/pasteboard/4944770-2.html
editing/pasteboard/4989774.html
editing/pasteboard/5006779.html
editing/pasteboard/5027857.html
editing/pasteboard/5028447.html
editing/pasteboard/5032095.html
editing/pasteboard/5065605.html
editing/pasteboard/5071074-2.html
editing/pasteboard/5071074.html
editing/pasteboard/5075944-2.html
editing/pasteboard/5075944-3.html
editing/pasteboard/5075944.html
editing/pasteboard/5089327.html
editing/pasteboard/5134759.html
editing/pasteboard/5156401-1.html
editing/pasteboard/5245519.html
editing/pasteboard/5247341.html
editing/pasteboard/5368833.html
editing/pasteboard/5478250.html
editing/pasteboard/5483567.html
editing/pasteboard/5601583-1.html
editing/pasteboard/5780697-2.html
editing/pasteboard/7955.html
editing/pasteboard/8145-1.html
editing/pasteboard/8145-2.html
editing/pasteboard/8145-3.html
editing/pasteboard/copy-paste-bidi.html
editing/pasteboard/cut-text-001.html
editing/pasteboard/displaced-generic-placeholder.html
editing/pasteboard/displaced-placeholder.html
editing/pasteboard/display-block-on-spans.html
editing/pasteboard/emacs-cntl-y-001.html
editing/pasteboard/innerText-inline-table.html
editing/pasteboard/interchange-newline-1.html
editing/pasteboard/interchange-newline-3.html
editing/pasteboard/interchange-newline-4.html
editing/pasteboard/merge-after-delete-1.html
editing/pasteboard/merge-after-delete-2.html
editing/pasteboard/merge-after-delete.html
editing/pasteboard/merge-end-1.html
editing/pasteboard/merge-end-2.html
editing/pasteboard/merge-end-3.html
editing/pasteboard/merge-end-4.html
editing/pasteboard/merge-end-5.html
editing/pasteboard/merge-end-blockquote.html
editing/pasteboard/merge-end-borders.html
editing/pasteboard/merge-end-list.html
editing/pasteboard/merge-end-table.html
editing/pasteboard/merge-start-blockquote.html
editing/pasteboard/merge-start-list.html
editing/pasteboard/paste-4035648-fix.html
editing/pasteboard/paste-4038267-fix.html
editing/pasteboard/paste-4039777-fix.html
editing/pasteboard/paste-blockquote-1.html
editing/pasteboard/paste-blockquote-2.html
editing/pasteboard/paste-blockquote-3.html
editing/pasteboard/paste-blockquote-after-blockquote.html
editing/pasteboard/paste-blockquote-into-blockquote-2.html
editing/pasteboard/paste-blockquote-into-blockquote-3.html
editing/pasteboard/paste-blockquote-into-blockquote-4.html
editing/pasteboard/paste-blockquote-into-blockquote.html
editing/pasteboard/paste-line-endings-001.html
editing/pasteboard/paste-line-endings-002.html
editing/pasteboard/paste-line-endings-003.html
editing/pasteboard/paste-line-endings-004.html
editing/pasteboard/paste-line-endings-005.html
editing/pasteboard/paste-line-endings-006.html
editing/pasteboard/paste-line-endings-007.html
editing/pasteboard/paste-line-endings-008.html
editing/pasteboard/paste-line-endings-009.html
editing/pasteboard/paste-line-endings-010.html
editing/pasteboard/paste-list-001.html
editing/pasteboard/paste-match-style-001.html
editing/pasteboard/paste-match-style-002.html
editing/pasteboard/paste-pre-001.html
editing/pasteboard/paste-pre-002.html
editing/pasteboard/paste-table-001.html
editing/pasteboard/paste-table-003.html
editing/pasteboard/paste-table-cells.html
editing/pasteboard/paste-text-002.html
editing/pasteboard/paste-text-003.html
editing/pasteboard/paste-text-004.html
editing/pasteboard/paste-text-005.html
editing/pasteboard/paste-text-006.html
editing/pasteboard/paste-text-007.html
editing/pasteboard/paste-text-009.html
editing/pasteboard/paste-text-010.html
editing/pasteboard/paste-text-011.html
editing/pasteboard/paste-text-012.html
editing/pasteboard/paste-text-013.html
editing/pasteboard/paste-text-014.html
editing/pasteboard/paste-text-015.html
editing/pasteboard/paste-text-016.html
editing/pasteboard/paste-text-017.html
editing/pasteboard/paste-text-018.html
editing/pasteboard/paste-text-019.html
editing/pasteboard/paste-text-at-tabspan-002.html
editing/pasteboard/paste-text-at-tabspan-003.html
editing/pasteboard/paste-unrendered-select.html
editing/pasteboard/pasting-object.html
editing/pasteboard/prevent-block-nesting-01.html
editing/pasteboard/quirks-mode-br-1.html
editing/pasteboard/select-element-1.html
editing/pasteboard/styled-element-markup.html
editing/pasteboard/testcase-9507.html
editing/pasteboard/undoable-fragment-removes.html
editing/pasteboard/unrendered-br.html

  • platform/qt/Skipped:
08:18 Changeset [58674] by philn@webkit.org

2010-05-03 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Csaba Osztrogonac.

media/video-duration-known-after-eos.html failing
https://bugs.webkit.org/show_bug.cgi?id=38466

  • platform/qt/Skipped: Skipping failing test. A lot of media tests are already skipped on this platform. Tor Arne said he'd look at them, at some point.
07:13 Changeset [58673] by hausmann@webkit.org

[Qt] Fix qtlibraryinfix not to contain space

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-05-03
Reviewed by Simon Hausmann.

List catenation with += adds whitespace cutting the infix
from the final target.

  • WebCore.pro:
07:10 Changeset [58672] by vestbo@webkit.org

[Qt] Fix rendering of <button> elements on Mac OS X

Reviewed by Simon Hausmann.

The <button> element has ButtonPart appearance, not PushButton part,
so we have to include ButtonPart when we decide if we should draw the
button as raised on Mac OS X.

07:09 Changeset [58671] by philn@webkit.org

2010-04-30 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] endless loop after playback ended
https://bugs.webkit.org/show_bug.cgi?id=38384

At playback end ensure duration() will return a valid duration if
we managed to calculate it based on current position.

Test: media/video-duration-known-after-eos.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::didEnd):

2010-04-30 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] endless loop after playback ended
https://bugs.webkit.org/show_bug.cgi?id=38384

  • media/video-duration-known-after-eos-expected.txt: Added.
  • media/video-duration-known-after-eos.html: Added.
05:00 Changeset [58670] by vestbo@webkit.org

[Qt] Prune dead code in QWebPage

Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
04:17 Changeset [58669] by vestbo@webkit.org

[Qt] Fix build break on Mac OS X

  • plugins/mac/PluginPackageMac.cpp: Use correct type
  • WebCore.pro: Remove duplicate symbol, we now have a Qt implementation
04:00 Changeset [58668] by eric@webkit.org

2010-05-03 Daniel Bates <dbates@rim.com>

Reviewed by Chris Jerdonek.

https://bugs.webkit.org/show_bug.cgi?id=38447

Refactor the unit tests in VCSUtils_unittest/parseDiff.pl to use
Test::More::is_deeply like we do in VCSUtils_unittest/parseDiffHeader.pl.

  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
02:09 QtWebKitRelease20 edited by hausmann@webkit.org
(diff)
01:57 QtWebKitRelease20 edited by hausmann@webkit.org
(diff)
01:22 QtWebKitRelease20 edited by hausmann@webkit.org
(diff)
01:16 QtWebKitRelease20 edited by hausmann@webkit.org
(diff)
01:15 QtWebKitRelease20 edited by hausmann@webkit.org
(diff)
00:59 QtWebKitTriageRoster edited by hausmann@webkit.org
(diff)
00:12 Changeset [58667] by hausmann@webkit.org

[Qt] Fix library infix usage when compiling inside of Qt

Patch by Thomas Zander <t.zander@nokia.com> on 2010-05-03
Reviewed by Simon Hausmann.

Don't apply the infix when building inside Qt, as that's done through the
inclusion of qbase.pri.

  • WebCore.pro:

05/02/10:

22:40 Changeset [58666] by cjerdonek@webkit.org

Unreviewed.

Corrected a file path in the ChangeLog entry for r58663 (bug 38319) below.

21:25 Changeset [58665] by mitz@apple.com

Another case of <rdar://problem/7552959> REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()
https://bugs.webkit.org/show_bug.cgi?id=38445

Reviewed by Simon Fraser.

WebCore:

Test: editing/selection/mixed-editability-11.html

  • dom/Position.cpp:

(WebCore::downstreamIgnoringEditingBoundaries): Added. Returns the furthest visually equivalent
position downstream, crossing any editability boundaries.
(WebCore::upstreamIgnoringEditingBoundaries): Similarly for upstream.
(WebCore::Position::getInlineBoxAndOffset): Changed the logic for finding an inline box for positions
whose node is a block flow. Instead of traversing the DOM, advance downstream or upstream as far as
possible, crossing any editability boudaries. Infinite recursion is avoided by advancing all the way
and checking that the new position is different from the starting position. Also replaced the specific
test for buttons with the generic and more comprehensive canHaveChildrenForEditing().

LayoutTests:

  • editing/selection/mixed-editability-11-expected.txt: Added.
  • editing/selection/mixed-editability-11.html: Added.
19:21 Changeset [58664] by eric@webkit.org

2010-05-02 Geoff Levand <geoff.levand@am.sony.com>

Reviewed by Eric Seidel.

[GTK] Fix out of source build failure
https://bugs.webkit.org/show_bug.cgi?id=38051

Add a preprocessor include path for generated GTK header files.
Fixes build errors like these when building GTK out of source:

webkit.h: error: webkit/webkitversion.h: No such file or directory

  • GNUmakefile.am:
18:49 Changeset [58663] by eric@webkit.org

2010-05-02 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=38319

  • Scripts/VCSUtils.pm:
    • In parseDiffHeader()--
      • Added an "scmFormat" hash key to the return value to represent whether the diff is Git or SVN formatted.
      • Adjusted the code so the value of "copiedFromPath" will be undef rather than "does not exist" if the file was not copied.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Added a FIXME to refactor these unit tests to use is_deeply().
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Updated the unit tests to test the "scmFormat" value.
    • Simplified the unit tests by refactoring them to use is_deeply().
15:18 Changeset [58662] by eric@webkit.org

2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with QT_NO_BEARERMANAGEMENT
https://bugs.webkit.org/show_bug.cgi?id=38324

  • platform/network/NetworkStateNotifier.h:
  • platform/network/qt/NetworkStateNotifierQt.cpp:

2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with QT_NO_BEARERMANAGEMENT
https://bugs.webkit.org/show_bug.cgi?id=38324

  • Api/qwebsettings.cpp:
14:48 Changeset [58661] by hausmann@webkit.org

[Qt] QtWebKit versioning added
https://bugs.webkit.org/show_bug.cgi?id=37207

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-04-29
Reviewed by Simon Hausmann.

QtWebkit releases separated from Qt release cycle.

WebCore:

  • WebCore.pro:

WebKit/qt:

  • qtwebkit_version.pri: Added.
14:42 Changeset [58660] by eric@webkit.org

2010-05-02 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Old Style trimWhitespace() should be trim()
https://bugs.webkit.org/show_bug.cgi?id=38441

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
14:31 Changeset [58659] by eric@webkit.org

2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with QT_NO_LINEEDIT
https://bugs.webkit.org/show_bug.cgi?id=38324

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::~RenderThemeQt): (WebCore::RenderThemeQt::findFrameLineWidth):
13:18 Changeset [58658] by pfeldman@chromium.org

2010-05-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Touch inspector controller to kick windows tests.

  • inspector/InspectorController.cpp:
11:32 Changeset [58657] by pfeldman@chromium.org

2010-05-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: IMG nodes are being added to the DOM tree late, sometimes hiding the revealed element.

https://bugs.webkit.org/show_bug.cgi?id=38432

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmousemove): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip): (WebInspector.ElementsTreeElement.prototype._createTooltipForNode): (WebInspector.ElementsTreeElement.prototype.updateTitle): (WebInspector.ElementsTreeElement.prototype._attributeHTML): ():
10:08 WebInspector edited by pfeldman@chromium.org
(diff)
09:30 Changeset [58656] by krit@webkit.org

2010-05-02 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hkern implementation incomplete
https://bugs.webkit.org/show_bug.cgi?id=38407

Test: svg/text/text-hkern.svg

The current SVG hkern implementation is incomplete and partly wrong. We pass the ACID3 test
by accident.
The new implementation supports all glyph and unicode combinations that are allowed by the Spec
and fixes various of bugs. The parser moved from SVGFontElement to the general parsing code in
SVGParserUtilities.
Some clean-up makes the code more readable and reuseable for the upcoming vkern implementation.
hkern support for text on path is missing and will be added by a following patch.
Unicode strings of hkern elements are just parsed once and not on every glyph again anymore.

  • rendering/SVGRootInlineBox.cpp: (WebCore::calculateCSSKerning): (WebCore::applySVGKerning): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
  • svg/SVGFontElement.cpp: (WebCore::stringMatchesUnicodeRange): (WebCore::stringMatchesGlyphName): (WebCore::matches): (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
  • svg/SVGFontElement.h:
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::buildHorizontalKerningPair):
  • svg/SVGHKernElement.h:
  • svg/SVGParserUtilities.cpp: (WebCore::parseGlyphName): (WebCore::parseUnicodeRange): (WebCore::parseKerningUnicodeString):
  • svg/SVGParserUtilities.h:

2010-05-02 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hkern implementation incomplete
https://bugs.webkit.org/show_bug.cgi?id=38407

The hkern patch fixes some very old bugs in some tests of the official
SVG Test suite. Added a new test to check correct behavior on different
use cases of textin SVG.

  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/mac/svg/text/kerning-expected.checksum:
  • platform/mac/svg/text/kerning-expected.png:
  • platform/mac/svg/text/text-hkern-expected.checksum: Added.
  • platform/mac/svg/text/text-hkern-expected.png: Added.
  • platform/mac/svg/text/text-hkern-expected.txt: Added.
  • svg/text/text-hkern.svg: Added.

2010-05-02 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hkern implementation incomplete
https://bugs.webkit.org/show_bug.cgi?id=38407

We support hkern now. Mention this in the SVG status page.

  • projects/svg/status.xml:
08:27 Changeset [58655] by eric@webkit.org

2010-05-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: debugger shortcuts are processed twice if source frame has focus.

https://bugs.webkit.org/show_bug.cgi?id=38431

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
08:03 Changeset [58654] by tkent@chromium.org

Unreviewed. Build fix on Japanese Windows.
Replace a non-ASCII character in a comment with an ASCII character.

05:47 Changeset [58653] by eric@webkit.org

2010-05-02 Kartikaya Gupta <kagupta@rim.com>

Reviewed by George Staikos.

When running the IDL file through the preprocessor, wait for the preprocessor subcommand to fully terminate before continuing. Without this, if multiple IDL files are parsed in a tight loop, the code dies after 64 IDL files because it exhausts the available system resources.

https://bugs.webkit.org/show_bug.cgi?id=37888

No new tests. None needed.

  • bindings/scripts/IDLParser.pm:
05:26 Changeset [58652] by eric@webkit.org

2010-05-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Enable JIT for QtWebKit on Symbian
https://bugs.webkit.org/show_bug.cgi?id=38339

JIT on Symbian has been stable for quite some time, it
is time to turn it on by default.

  • wtf/Platform.h:
05:05 Changeset [58651] by eric@webkit.org

2010-05-02 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Eric Seidel.

[Qt] Build error in GraphicsContext3DQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=38382

Removed duplicate implementation of isGLES2Compliant from
GraphicsContext3DQt.cpp. Removed deprecated API stuff for
texImage2D/texSubImage2D.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:
04:54 Changeset [58650] by eric@webkit.org

2010-05-02 Garret Kelly <gdk@chromium.org>

Reviewed by David Levin.

Make the Touch RuntimeEnabledFeature disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=38392

  • bindings/generic/RuntimeEnabledFeatures.cpp: Disable the Touch feature by default.
04:29 Changeset [58649] by tkent@chromium.org

Unreviewed. Fix a build failure by r58647.

01:55 Changeset [58648] by eric@webkit.org

2010-05-02 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage::userAgentForUrl is terrible API
https://bugs.webkit.org/show_bug.cgi?id=33875

Simplify the creation of the user agent string to avoid some
overhead for each loaded url.

The static part of the user agent is cached so it only have
to be made once.
This creation has been made in order to simplify the code.

The two variable: application name and current language are
set dynamically when needed.
The default locale is non longer created if the widget locale
is used.

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::userAgentApplicationName): (tst_QWebPage::userAgentLocaleChange):
01:39 Changeset [58647] by eric@webkit.org

2010-05-02 Michael Nordman <michaeln@google.com>

Reviewed by Dmitry Titov.

Define two new ResourceRequestBase TargetTypes for worker and shared worker
main resources. Use the new target types where appropiate. Add logic to marshal
the target type specified by requests initiated on a background worker thread.

https://bugs.webkit.org/show_bug.cgi?id=38295

No new tests. This doesn't have script visible artifacts.

  • platform/network/ResourceRequestBase.cpp: marshal the values (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData):
  • platform/network/ResourceRequestBase.h: define the types (WebCore::ResourceRequestBase::):
  • workers/DefaultSharedWorkerRepository.cpp: use TargetIsSharedWorker (WebCore::SharedWorkerScriptLoader::load):
  • workers/Worker.cpp: use TargetIsWorker (WebCore::Worker::Worker):
  • workers/WorkerContext.cpp: use TargetIsScript for importScripts (WebCore::WorkerContext::importScripts):
  • workers/WorkerScriptLoader.cpp: add a data member for the target type (WebCore::WorkerScriptLoader::WorkerScriptLoader): (WebCore::WorkerScriptLoader::createResourceRequest):
  • workers/WorkerScriptLoader.h:

2010-05-02 Michael Nordman <michaeln@google.com>

Reviewed by Dmitry Titov.

Define two new ResourceRequestBase TargetTypes for worker and shared worker
main resources. Use the new target types where appropiate. Add logic to marshal
the target type specified by requests initiated on a background worker thread.

https://bugs.webkit.org/show_bug.cgi?id=38295

  • src/SharedWorkerRepository.cpp: use TargetIsSharedWorker (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
01:12 Changeset [58646] by eric@webkit.org

2010-05-02 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

[chromium] Upstream test expectations for:
http/tests/loading/basic-auth-resend-wrong-credentials.html
https://bugs.webkit.org/show_bug.cgi?id=38387

  • platform/chromium/test_expectations.txt:
01:01 Changeset [58645] by eric@webkit.org

2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: animation incorrect when scrolling
https://bugs.webkit.org/show_bug.cgi?id=38371

This is a regression introduced with the invalidate-on-scroll code path, that uses QGraphicsWebViewPrivate::update()
instead of QGraphicsWebViewPrivate::scroll(). The patch makes sure that the scrolling position is correct on
each content update - this shouldn't have a performance impact - the only overhead is an additional value-test on each update.

Tested by http://www.the-art-of-web.com/css/css-animation/

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::update):
00:50 Changeset [58644] by eric@webkit.org

2010-05-02 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

fast/events/touch has non-standard script test wrappers
https://bugs.webkit.org/show_bug.cgi?id=38084

Tidy up the touch event layout tests. Make the script-tests TEMPLATE.html
generate asynchronous style tests using js-test-post-function.js and move
the non-standard synchronous test into the resources directory.

  • fast/events/touch/basic-multi-touch-events.html: Regenerate from TEMPLATE.html
  • fast/events/touch/basic-single-touch-events.html: ditto.
  • fast/events/touch/send-oncancel-event.html: ditto.
  • fast/events/touch/touch-target.html: ditto.
  • fast/events/touch/create-touch-event.html: Link to script in resources rather than

script-tests as this test is not generated from TEMPLATE.html.

  • fast/events/touch/resources/create-touch-event.js: Copied from LayoutTests/fast/events/touch/script-tests/create-touch-event.js.
  • fast/events/touch/script-tests/TEMPLATE.html: Update to generate asynchronous tests.
  • fast/events/touch/script-tests/create-touch-event.js: Removed.
  • fast/events/touch/script-tests/touch-target.js: Refactor to work with new wrapper

generated from TEMPLATE.html.

00:23 Changeset [58643] by eric@webkit.org

2010-05-02 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Darin Fisher.

Include WebWindowFeatures in call to WebViewClient::createView.
https://bugs.webkit.org/show_bug.cgi?id=38301

  • public/WebViewClient.h: (WebKit::WebViewClient::createView):
  • public/WebWindowFeatures.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow):
00:12 Changeset [58642] by eric@webkit.org

2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Adele Peterson.

Webkit doesn't compile with 3D-canvas enabled and video disabled
https://bugs.webkit.org/show_bug.cgi?id=38297

Added a #ifdef ENABLE(VIDEO) to WebGL code

No new tests: compile fix.

  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::texImage2D): (WebCore::JSWebGLRenderingContext::texSubImage2D):
00:01 Changeset [58641] by eric@webkit.org

2010-05-01 Evan Stade <estade@chromium.org>

Reviewed by David Levin.

[chromium] Skia needs to fade DragImages
https://bugs.webkit.org/show_bug.cgi?id=38008

tested by DragImageTest

  • platform/chromium/DragImageChromiumSkia.cpp: (WebCore::dissolveDragImageToFraction):implement (WebCore::createDragImageFromImage):deep copy instead of shallow

2010-05-01 Evan Stade <estade@chromium.org>

Reviewed by David Levin

[chromium] Skia needs to fade DragImages
https://bugs.webkit.org/show_bug.cgi?id=38008

  • tests/DragImageTest.cpp: (DragImageTest.CreateDragImage): test that the drag image is a deep copy
Note: See TracTimeline for information about the timeline view.