Timeline
05/10/10:
- 23:43 Changeset [59143] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Fix asserting GTK build.
r59137 changed the behavior of RenderObject::repaintUsingContainer(). I mistakenly
thought that non-compositing builds would always pass a 0 repaintContainer, but
actually the RenderView is passed in this case. So use this to repaint if
ACCELERATED_COMPOSITING is turned off.
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):
- 23:32 Changeset [59142] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Skip two new flakey tests:
# Tests are flakey: https://bugs.webkit.org/show_bug.cgi?id=38888
compositing/iframes/iframe-resize.html
compositing/iframes/overlapped-iframe.html
- platform/mac/Skipped:
- 23:22 Changeset [59141] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
No review; attempt to fix failing tests.
Increase the timeout to give compositing updates a chance to happen.
- compositing/iframes/iframe-resize.html:
- compositing/iframes/overlapped-iframe.html:
- 23:08 QtWebKitTriageRoster edited by
- (diff)
- 23:06 Changeset [59140] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Fix warning on Windows about unreachable code.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
- 23:05 Changeset [59139] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
No review.
Reduce timeouts from 500 to 50ms to make the tests run more quickly.
- compositing/iframes/resources/enter-compositing-subframe.html:
- compositing/iframes/resources/leave-compositing-subframe.html:
- 22:47 Changeset [59138] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
When painting an iframe into a compositing layer, the "PaintBehaviorFlattenCompositingLayers"
flag was mistakenly set, because we'd detect that we were drawing into a bitmap. This caused
content to show up in both compositing layers, and the painted background inside the iframe.
Fix by taking the flattening state from the parent frame, if there is one. For the root
frame, we continue to look to see if we're painting into a bitmap.
- WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]):
- 22:47 Changeset [59137] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
RenderObject::repaintUsingContainer() incorrectly did a view-based
repaint if the repaint container was the RenderView. Instead, we need
to check to see if the RenderView's layer is composited, and, if so,
whether it's painting into the window or not. This can occur when iframes
are composited.
The bug is timing-sensitive, involving compositing in iframes, and I was not able to
concoct a good testcase.
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):
- 22:44 Changeset [59136] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Changes to allow compositing layers for iframes to switch between being hosted
by the iframe's layer-backed NSView, and parented in the GraphicsLayer tree of the
enclosing document.
Tests: compositing/iframes/connect-compositing-iframe.html
compositing/iframes/connect-compositing-iframe2.html
compositing/iframes/connect-compositing-iframe3.html
- page/FrameView.h:
- page/FrameView.cpp: (WebCore::FrameView::hasCompositedContent): New convenience method. (WebCore::FrameView::setIsOverlapped): If we're composited, poke the owner document in case it
wants to re-evaluate compositing decisions.
(WebCore::FrameView::isOverlapped): Just expose the existing flag.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): If this is an iframe, we need
to ensure that the layers for the iframe content are hooked up.
(WebCore::RenderLayerBacking::updateDrawsContent): When an iframe toggles between different
attachments, the 'drawsContent' behavior of its root layer changes, so needs to be updated.
- rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer()
instead of detachRootPlatformLayer() and manually zeroing out the OwnPtrs.
(WebCore::RenderLayerCompositor::updateBacking): If a RenderIFrame changes compositing mode,
we need to ensure that its content compositor attachment is updated.
(WebCore::RenderLayerCompositor::repaintOnCompositingChange): The existing code had a bug
that caused repaints for RenderViews (which have no parent) to bail. We only want to bail
for non-RenderViews that are not attached.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Factored the iframe-connecting
code into a new method, parentIFrameContentLayers().
(WebCore::RenderLayerCompositor::parentIFrameContentLayers): New method to share the code that hooks
up the iframe's compositing layers to the parent.
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Add logic to propagate
compositing out of iframes on Mac in two situations: 1) when the FrameView is overlapped, and 2)
if the parent document is already composited.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Clean up the logic here to better deal
with dynamic changes of the attachment type.
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Clean up and null out the clipping layer here.
(WebCore::RenderLayerCompositor::attachRootPlatformLayer): Call rootLayerAttachmentChanged().
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Ditto. Also unparent the clipping and platform layers.
(WebCore::RenderLayerCompositor::updateRootLayerAttachment): Call ensureRootPlatformLayer() to re-evaluate
the layer attachment.
(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged): We need to update the drawsContent() status
of the RenderView's layer's backing, because it changes depending on the attachment.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Do overlap testing if the frameView can do fast repaints (as before),
but also now when the frameView has composited content.
- 22:37 Changeset [59135] by
-
Adding a test that makes sure openDatabaseSync() deals correctly with invalid inputs.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Brady Eidson.
- fast/workers/storage: Added.
- fast/workers/storage/open-database-sync-inputs-expected.txt: Added.
- fast/workers/storage/open-database-sync-inputs.html: Added.
- fast/workers/storage/resources: Added.
- fast/workers/storage/resources/open-database-sync-inputs.js: Added.
(notAString.toString):
- fast/workers/storage/resources/test-inputs-common.js: Added.
(log):
(finishTest):
(runTest.worker.onmessage):
(runTest):
- 22:34 Changeset [59134] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Rename the static shouldPropagateCompositingToIFrameParent() to shouldPropagateCompositingToEnclosingIFrame(),
to pave the way for runtime switches in the propagation behavior. We have to make sure we call it on
the correct RenderLayerCompositor (that belonging to the iframe's content document).
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintingGoesToWindow): Now that we know the root layer attachment, we can simplify this method.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): No need for the setNeedsStyleRecalc() here, because the ensureRootPlatformLayer() or destroyRootPlatformLayer() will have already done it.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Use the root layer attachment to determine
whether to parent the iframe's layers.
(WebCore::RenderLayerCompositor::didMoveOnscreen): Method name change.
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Name change.
(WebCore::RenderLayerCompositor::requiresCompositingForIFrame): We need to consult the iframe contents
document's compositor to ask whether propagation is appropriate.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Name change.
- 22:33 Changeset [59133] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Use an enum for the type of root layer attachment on a RenderLayerCompositor, so we can
determine if the attachment is via the ChromeClient, via an enclosing iframe, or unattached.
- rendering/RenderLayerCompositor.h: New RootLayerAttachment enum. (WebCore::RenderLayerCompositor::rootLayerAttachment): getter for the current attachment.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): Init m_rootLayerAttachment. (WebCore::RenderLayerCompositor::~RenderLayerCompositor): Assert that is unattached. (WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer instead of willMoveOffscreen, when there are no layers left. Also clear out the clipping layer. (WebCore::RenderLayerCompositor::didMoveOnscreen): Call attachRootPlatformLayer. (WebCore::RenderLayerCompositor::willMoveOffscreen): Call ensureRootPlatformLayer with the appropriate attachment. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Only create the m_rootPlatformLayer if we don't have one
already, but be sure to always set the root layer geometry orientation. Also only create the
m_clippingLayer if we need to.
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Call detachRootPlatformLayer().
(WebCore::RenderLayerCompositor::attachRootPlatformLayer): Code moved from didMoveOnscreen, but switching on
attachment.
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Code moved from willMoveOffscreen, but switching on
attachment.
- 22:27 Changeset [59132] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Clean up the geometry logic when propagating compositing out of iframes.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition): Geometry on m_rootPlatformLayer no longer needs to be special when there's a clipping layer.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Don't set the clipping layer to have
flipped geometry ever, and only set the root layer to have flipped geometry if it is not
being hosted in an iframe. Also no need to set a custom anchor point on the clipping layer.
- 22:22 Changeset [59131] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Fix up test results from last commit, which were generated with a build from before r59129.
- platform/win/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/win/compositing/iframes/iframe-resize-expected.txt:
- platform/win/compositing/iframes/leave-compositing-iframe-expected.txt:
- platform/win/compositing/iframes/overlapped-iframe-expected.txt:
- 22:12 Changeset [59130] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=38856
Allow compositing layers to be connected across iframe boundaries on Mac
Add several more iframe-compositing-related tests. These tests:
- an iframe dynamically entering compositing mode
- an iframe dynamically leaving compositing mode
- an overlapped iframe
- a compositing iframe being resized
composited-iframe.html had no value and is removed.
- compositing/iframes/composited-iframe-expected.txt: Removed.
- compositing/iframes/composited-iframe.html: Removed.
- compositing/iframes/enter-compositing-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/enter-compositing-iframe.html: Added.
- compositing/iframes/iframe-resize-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/iframe-resize.html: Added.
- compositing/iframes/leave-compositing-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/leave-compositing-iframe.html: Added.
- compositing/iframes/overlapped-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
- compositing/iframes/overlapped-iframe.html: Added.
- compositing/iframes/resources/enter-compositing-subframe.html: Added.
- compositing/iframes/resources/leave-compositing-subframe.html: Added.
- platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
- platform/win/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
- platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.
- 22:08 Changeset [59129] by
-
2010-05-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson
Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856
Clean up some methods related to composited iframes. No behavioral changes.
- rendering/RenderLayerBacking.h: Move innerRenderLayerCompositor() to be a static method:
RenderLayerCompositor::iframeContentsCompositor().
- rendering/RenderLayerBacking.cpp: Remove innerRenderLayerCompositor(). (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call iframeContentsCompositor().
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): Call enclosingIFrameElement() (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): iframeContentsCompositor() is now a static method in this class. Also check that the iframe contents are in compositing mode (slightly clearer than relying on rootPlatformLayer() returning null). (WebCore::RenderLayerCompositor::iframeContentsCompositor): Moved from RenderLayerBacking. (WebCore::RenderLayerCompositor::didMoveOnscreen): Use enclosingIFrameElement() method. (WebCore::RenderLayerCompositor::willMoveOffscreen): Ditto. (WebCore::RenderLayerCompositor::enclosingIFrameElement): New method. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Call enclosingIFrameElement().
- rendering/RenderLayerCompositor.h: New method, iframeContentsCompositor().
- 22:06 Changeset [59128] by
-
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Final set of baselines and expectations to green up the build.
- platform/chromium-mac/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
- platform/chromium-win/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 21:49 Changeset [59127] by
-
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] rebaseline SVG test for windows after recent changes.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-win/svg/batik/filters/feTile-expected.png:
- platform/chromium-win/svg/batik/filters/feTile-expected.txt:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.checksum:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
- platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
- platform/chromium-win/svg/batik/text/textEffect-expected.png: Added.
- platform/chromium-win/svg/batik/text/textEffect-expected.txt:
- platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
- platform/chromium-win/svg/batik/text/textEffect3-expected.png: Added.
- platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
- platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
- platform/chromium-win/svg/batik/text/textProperties-expected.txt:
- platform/chromium-win/svg/custom/empty-mask-expected.txt:
- platform/chromium-win/svg/custom/empty-merge-expected.checksum:
- platform/chromium-win/svg/custom/empty-merge-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.checksum:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/chromium-win/svg/custom/feDisplacementMap-01-expected.checksum:
- platform/chromium-win/svg/custom/feDisplacementMap-01-expected.png:
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.checksum:
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/chromium-win/svg/custom/invalid-css-expected.txt:
- platform/chromium-win/svg/custom/mask-invalidation-expected.txt:
- platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
- platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.checksum:
- platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
- platform/chromium-win/svg/custom/text-filter-expected.checksum:
- platform/chromium-win/svg/custom/text-filter-expected.png:
- platform/chromium-win/svg/custom/text-filter-expected.txt:
- platform/chromium-win/svg/custom/visibility-override-filter-expected.checksum:
- platform/chromium-win/svg/custom/visibility-override-filter-expected.png:
- platform/chromium-win/svg/filters/big-sized-filter-2-expected.checksum:
- platform/chromium-win/svg/filters/big-sized-filter-2-expected.png:
- platform/chromium-win/svg/filters/big-sized-filter-expected.checksum:
- platform/chromium-win/svg/filters/big-sized-filter-expected.png:
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum:
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.png:
- platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
- platform/chromium-win/svg/filters/feComposite-expected.checksum:
- platform/chromium-win/svg/filters/feComposite-expected.png:
- platform/chromium-win/svg/filters/feComposite-expected.txt:
- platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
- platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
- platform/chromium-win/svg/filters/feMerge-expected.checksum:
- platform/chromium-win/svg/filters/feMerge-expected.png:
- platform/chromium-win/svg/filters/feOffset-expected.checksum:
- platform/chromium-win/svg/filters/feOffset-expected.png:
- platform/chromium-win/svg/filters/feTile-expected.checksum:
- platform/chromium-win/svg/filters/feTile-expected.png:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.checksum:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
- platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
- platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
- platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
- platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.png:
- platform/chromium-win/svg/filters/subRegion-one-effect-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
- platform/chromium-win/svg/filters/subRegion-two-effects-expected.checksum:
- platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
- platform/chromium-win/svg/text/text-vkern-expected.checksum: Added.
- platform/chromium-win/svg/text/text-vkern-expected.png: Added.
- 21:12 Changeset [59126] by
-
Unreviewed, fixing the expectations for Chromium.
- platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
- 20:51 Changeset [59125] by
-
Fix a crash when closing a WebView while the Web Inspector is open.
<rdar://problem/7966830>
Reviewed by Mark Rowe.
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController destroyInspectorView]): Null check Page since it can be null.
- WebView/WebView.mm:
(-[WebView _close]): Null out _private->page before deleting the page, so code called
during destruction don't access a half deleted Page object.
- 20:45 Changeset [59124] by
-
2010-05-10 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Build DRT when running build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=38730
This allows DRT to use the same .o and .lib files when building
on Windows.
- WebKit.gyp: Move DRT.gyp targets into this file.
- gyp_webkit: DRT.gyp is gone
2010-05-10 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Build DRT when running build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=38730
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
- Scripts/build-dumprendertree: This does nothing now.
- 20:40 Changeset [59123] by
-
2010-05-10 Eric Seidel <eric@webkit.org>
Unreviewed, just removing newline from -expected.txt file
REGRESSION(r59100): "Added test is broken on many platforms." (Requested by eseidel on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=38881
Looks like http://trac.webkit.org/changeset/59119
added an extra newline by mistake. Removing.
- plugins/geturlnotify-during-document-teardown-expected.txt:
- 19:54 Changeset [59122] by
-
Unreviewed, fixing Qt's expectations.
- platform/qt/http/tests/security/cross-frame-access-call-expected.txt:
- 19:39 Changeset [59121] by
-
Remove conflict markers from ChangeLog
- 19:35 Changeset [59120] by
-
REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881
Reviewed by Eric Seidel.
- platform/mac-snowleopard/Skipped:
Skipped, because we're not logging NPP_Destroy on Snow Leopard.
- platform/qt/Skipped:
Skipped due to lack of support for setCallCloseOnWebViews on
LayoutTestController.
- 19:35 Changeset [59119] by
-
REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881
Reviewed by Eric Seidel.
WebKitTools:
- DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_Destroy):
Use pluginLog, rather than printf, to match other platforms.
LayoutTests:
- plugins/geturlnotify-during-document-teardown-expected.txt:
Update the expected result.
- 19:06 Changeset [59118] by
-
WebCore: Cleaning up and fixing the existing JSC DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Brady Eidson.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::openDatabase):
- bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabase::transaction):
(WebCore::JSDatabase::readTransaction):
- bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
LayoutTests: Fixing the expectations for openDatabase() in cross-frame-access-call.html.
Related to changes in patches #6 and #7 at https://bugs.webkit.org/show_bug.cgi?id=34994.
Reviewed by Brady Eidson.
- http/tests/security/cross-frame-access-call-expected.txt:
- http/tests/security/cross-frame-access-call.html:
- platform/chromium-linux/http/tests/security/cross-frame-access-call-expected.txt: Removed.
- platform/chromium-mac/http/tests/security/cross-frame-access-call-expected.txt: Removed.
- platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt: Removed.
- platform/chromium/http: Added.
- platform/chromium/http/tests: Added.
- platform/chromium/http/tests/security: Added.
- platform/chromium/http/tests/security/cross-frame-access-call-expected.txt: Copied from LayoutTests/platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt.
- 18:52 Changeset [59117] by
-
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Fix a build failure caused by assuming the default platform in
a unit test for new-run-webkit-tests instead of specifying
--platform test.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 18:50 Changeset [59116] by
-
2010-05-10 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
WebSocket needs to suspend/resume as Active DOM object.
https://bugs.webkit.org/show_bug.cgi?id=38171
Implement suspend()/resume() in WebSocket and WebSocketChannel.
While WebSocketChannel is suspended, it only adds received data in m_buffer
or record the handle was closed, and report no event to WebSocket.
When resumed, it will process buffer or handle closing.
Since suspend/resume would be called while processing JavaScript event handler (e.g. before/after alert()), WebSocketChannel method that would fire an event need to be reentrant.
So, WebSocketChannel::processBuffer() call WebSocket to fire an event at most once and skips buffer before the calling,
so that next call of processBuffer() would process the next frame.
- websockets/ThreadableWebSocketChannel.h:
- websockets/ThreadableWebSocketChannelClientWrapper.h: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect): Mark channel is opened, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage): Push message back in pending queue, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): Mark channel is closed, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::suspend): Mark suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::resume): Unmark suspended, and process pending events. (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
- websockets/WebSocket.cpp: (WebCore::WebSocket::canSuspend): (WebCore::WebSocket::suspend): (WebCore::WebSocket::resume): (WebCore::WebSocket::didClose):
- websockets/WebSocket.h:
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::connect): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::close): (WebCore::WebSocketChannel::suspend): (WebCore::WebSocketChannel::resume): When resumed, it will process buffer and handle closing if handle was already closed while suspended. (WebCore::WebSocketChannel::didClose): If suspended, record unhandled bufferedAmount and set m_closed true, so that closing will be processed when resumed. (WebCore::WebSocketChannel::didReceiveData): Add received data in buffer and process buffer while it is not suspended. (WebCore::WebSocketChannel::processBuffer): Process handshake header or one frame message. Return true if there are more data to be processed. Return false otherwise (e.g. incomplete handshake header or incomplete frame).
- websockets/WebSocketChannel.h:
- websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::suspend): (WebCore::WorkerThreadableWebSocketChannel::resume): (WebCore::WorkerThreadableWebSocketChannel::Peer::suspend): (WebCore::WorkerThreadableWebSocketChannel::Peer::resume): (WebCore::WorkerThreadableWebSocketChannel::mainThreadSuspend): (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend): (WebCore::WorkerThreadableWebSocketChannel::mainThreadResume): (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
- websockets/WorkerThreadableWebSocketChannel.h:
- 18:45 Changeset [59115] by
-
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Fix sort order for expectations after previous change.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- 18:30 Changeset [59114] by
-
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build-fix
new-run-webkit-tests: fix test failure caused by me failing to update
the expected output. Also, run '--platform test' instead of
'platform dryrun' since the former is guaranteed to work and the
latter isn't.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 18:18 Changeset [59113] by
-
Implement the JSC bindings for the sync DB API.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Brady Eidson.
- bindings/js/JSDatabaseSyncCustom.cpp:
(WebCore::JSDatabaseSync::changeVersion):
(WebCore::createTransaction):
- bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql):
- 18:07 Changeset [59112] by
-
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Unreviewed, test expectation change for Chromium following r59010.
- platform/chromium/fast/dom/prototype-inheritance-expected.txt:
- 17:44 Changeset [59111] by
-
2010-05-10 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=36566
The animation-fill-mode property was missing from
a few places where the animation shorthand is set up.
Test: animations/animation-shorthand-removed.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Make sure animation-fill-mode is included in the animation shorthand
- css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
- 17:10 Changeset [59110] by
-
2010-05-10 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add WebKitScrollbar interface to allow Chromium code to reuse the scrollbar code
https://bugs.webkit.org/show_bug.cgi?id=38854
- public/WebScrollbar.h: Added. (WebKit::WebScrollbar::): (WebKit::WebScrollbar::~WebScrollbar):
- public/WebScrollbarClient.h: Added.
- public/WebThemeEngine.h:
- src/AssertMatchingEnums.cpp:
- src/WebScrollbarImpl.cpp: Added. (WebKit::WebScrollbar::create): (WebKit::WebScrollbar::defaultThickness): (WebKit::WebScrollbarImpl::WebScrollbarImpl): (WebKit::WebScrollbarImpl::~WebScrollbarImpl): (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::value): (WebKit::WebScrollbarImpl::setValue): (WebKit::WebScrollbarImpl::setDocumentSize): (WebKit::WebScrollbarImpl::scroll): (WebKit::WebScrollbarImpl::paint): (WebKit::WebScrollbarImpl::handleInputEvent): (WebKit::WebScrollbarImpl::onMouseDown): (WebKit::WebScrollbarImpl::onMouseUp): (WebKit::WebScrollbarImpl::onMouseMove): (WebKit::WebScrollbarImpl::onMouseLeave): (WebKit::WebScrollbarImpl::onMouseWheel): (WebKit::WebScrollbarImpl::onKeyDown): (WebKit::WebScrollbarImpl::valueChanged): (WebKit::WebScrollbarImpl::invalidateScrollbarRect): (WebKit::WebScrollbarImpl::isActive): (WebKit::WebScrollbarImpl::scrollbarCornerPresent): (WebKit::WebScrollbarImpl::getTickmarks):
- src/WebScrollbarImpl.h: Added.
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollViewWithKeyboard): (WebKit::WebViewImpl::mapKeyCodeForScroll):
- src/WebViewImpl.h:
- 17:08 Changeset [59109] by
-
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.
Reviewed by Darin Adler.
Test: fast/dom/Element/normalize-crash.html
- dom/Element.cpp:
(WebCore::Element::normalizeAttributes): Copy attributes to a vector
before iterating.
- dom/NamedAttrMap.cpp:
(WebCore::NamedNodeMap::copyAttributesToVector): Added.
- dom/NamedAttrMap.h:
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.
Reviewed by Darin Adler.
- fast/dom/Element/normalize-crash-expected.txt: Added.
- fast/dom/Element/normalize-crash.html: Added.
- 17:01 Changeset [59108] by
-
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
new-run-webkit-tests: looks like the unicode conversion broke
--print-last-failures and --retest-last-failures. Fixing.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 17:00 Changeset [59107] by
-
Hook the realtime analyser into the modular routing API
- 17:00 Changeset [59106] by
-
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by David Levin.
Re-attempt to fix 38616 - newline handling in new-run-webkit-tests.
I didn't handle some cases correctly before and the solution was
confusing. The new patch assumes all calls to the printing module
don't have newlines, and will append newlines where necessary, just
like logging does.
- Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
- Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/printing.py:
- Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 16:58 Changeset [59105] by
-
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Unreviewed, svg test rebaselines after r59002 for linux.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
- platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-linux/svg/batik/filters/feTile-expected.png:
- platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
- platform/chromium-linux/svg/batik/filters/filterRegions-expected.checksum:
- platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
- platform/chromium-linux/svg/batik/filters/filterRegions-expected.txt: Added.
- platform/chromium-linux/svg/batik/masking/maskRegions-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
- platform/chromium-linux/svg/batik/text/textEffect-expected.png: Added.
- platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
- platform/chromium-linux/svg/batik/text/textEffect3-expected.png: Added.
- platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Added.
- platform/chromium-linux/svg/batik/text/textProperties-expected.txt: Added.
- platform/chromium-linux/svg/custom/empty-mask-expected.txt: Added.
- platform/chromium-linux/svg/custom/empty-merge-expected.checksum:
- platform/chromium-linux/svg/custom/empty-merge-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.txt: Added.
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.txt: Added.
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.txt: Added.
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.checksum:
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
- platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.txt: Added.
- platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.checksum:
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.checksum:
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.png: Removed.
- platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/chromium-linux/svg/custom/invalid-css-expected.txt: Added.
- platform/chromium-linux/svg/custom/mask-invalidation-expected.txt: Added.
- platform/chromium-linux/svg/custom/non-opaque-filters-expected.txt: Added.
- platform/chromium-linux/svg/custom/text-filter-expected.checksum:
- platform/chromium-linux/svg/custom/text-filter-expected.png: Removed.
- platform/chromium-linux/svg/custom/text-filter-expected.txt: Added.
- platform/chromium-linux/svg/custom/visibility-override-filter-expected.checksum: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-2-expected.checksum: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-expected.checksum: Added.
- platform/chromium-linux/svg/filters/big-sized-filter-expected.png: Added.
- platform/chromium-linux/svg/filters/feColorMatrix-values-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Added.
- platform/chromium-linux/svg/filters/feColorMatrix-values-expected.txt: Added.
- platform/chromium-linux/svg/filters/feComposite-expected.checksum:
- platform/chromium-linux/svg/filters/feComposite-expected.png: Removed.
- platform/chromium-linux/svg/filters/feComposite-expected.txt: Added.
- platform/chromium-linux/svg/filters/feGaussianBlur-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feMerge-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feMerge-expected.png: Added.
- platform/chromium-linux/svg/filters/feOffset-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feTile-expected.checksum: Added.
- platform/chromium-linux/svg/filters/feTile-expected.png: Added.
- platform/chromium-linux/svg/filters/filter-on-tspan-expected.checksum:
- platform/chromium-linux/svg/filters/filter-on-tspan-expected.png: Removed.
- platform/chromium-linux/svg/filters/filter-on-tspan-expected.txt: Added.
- platform/chromium-linux/svg/filters/sourceAlpha-expected.txt: Added.
- platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
- platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.png: Added.
- platform/chromium-linux/svg/filters/subRegion-one-effect-expected.checksum:
- platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png: Removed.
- platform/chromium-linux/svg/filters/subRegion-two-effects-expected.checksum:
- platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png: Removed.
- platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added.
- platform/chromium-linux/svg/text/text-vkern-expected.png: Added.
- 16:38 Changeset [59104] by
-
[V8] Fix V8 code generator script to generate the correct code for
converting ScriptString.
https://bugs.webkit.org/show_bug.cgi?id=38873
Reviewed by Adam Barth.
Updated the bindings test result. Note that the result is also updated
to reflect other script generator changes not introduced by this patch.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
- bindings/scripts/test/JS/JSTestCallback.h:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::scriptStringAttrAttrGetter):
- 16:35 Changeset [59103] by
-
Add test to GTK skipped list.
Rubber-stamped by Mark Rowe.
- platform/gtk/Skipped:
- 16:14 Changeset [59102] by
-
Fix the 32-bit WebKit2 build.
- WebCore.base.exp:
- 16:13 WebKit Team edited by
- Move tkent to the reviewers section (diff)
- 16:02 Changeset [59101] by
-
2010-05-10 Kent Tamura <tkent@chromium.org>
Reviewed by Adam Barth.
Make tkent a reviewer
https://bugs.webkit.org/show_bug.cgi?id=38875
- Scripts/webkitpy/common/config/committers.py:
- 15:56 Changeset [59100] by
-
Crash closing window containing Flash plug-in
https://bugs.webkit.org/show_bug.cgi?id=38797
<rdar://problem/7935266>
Reviewed by Eric Seidel.
WebCore:
Test: plugins/geturlnotify-during-document-teardown.html
- plugins/PluginView.cpp:
(WebCore::PluginView::load):
Null check the DocumentLoader; it's possible for this to be null while
the Document is being torn down and before the plug-in is destroyed.
WebKitTools:
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginAllocate):
Initialize new member to false.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
Added a new member.
- DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_New):
Check whether the element has the "testGetURLOnDestroy" attribute, and
record that.
(NPP_Destroy):
If "testGetURLOnDestroy" is set, perform a load while destroying the
plug-in.
LayoutTests:
- plugins/geturlnotify-during-document-teardown.html: Added.
- plugins/resources/geturlnotify-on-destroy.html: Added.
- 15:48 Changeset [59099] by
-
2010-05-10 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
Executive.kill_* do not work with windows python
https://bugs.webkit.org/show_bug.cgi?id=38872
http://trac.webkit.org/changeset/57444 is where the original
breakage occurred.
http://trac.webkit.org/changeset/58314 is where the regression
started affecting chromium.
I have since learned that sys.platform has no "windows" value.
"win32" is always the value, under 32 or 64 bit windows
The tests for this code are not run anywhere because
test-webkitpy does not yet work on "win32". Mostly due to
depending on unixisms like "cat" and "yes".
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_unittest.py:
- 15:13 Changeset [59098] by
-
Reviewed by Darin Adler.
Based on a patch by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28697
<rdar://problem/7946578> WebKit crash on WebCore::Node::nodeIndex()
It's not OK to call ContainerNode::willRemoveChild() in a loop, because Range code assumes
that it can adjust start and end position to any node except for the one being removed -
so these notifications cannot be batched.
Test: fast/dom/Range/remove-all-children-crash.html
- dom/ContainerNode.cpp: (WebCore::willRemoveChild): Removed unused ExceptionCode. (WebCore::willRemoveChildren): New function, used in removeChildren() case. (WebCore::ContainerNode::removeChild): ExceptionCode return was always 0, don't bother with it. (WebCore::ContainerNode::removeChildren): Call willRemoveChildrenFromNode. (WebCore::dispatchChildRemovalEvents): Moved some logic out into willRemoveChildrenFromNode and willRemoveChild.
- dom/Document.cpp: (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
- dom/Document.h: (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
- dom/Range.h:
- dom/Range.cpp: (WebCore::boundaryNodeChildrenWillBeRemoved): New function, used in removeChildren() case. (WebCore::Range::nodeChildrenWillBeRemoved): Ditto.
- 14:44 Changeset [59097] by
-
Add custom bindings for attributes which are custom JS objects to avoid compiler warnings/errors
- this is a problem which seems to only occur with the JS (not V8) bindings
- JSAudioMiscCustom.cpp may be temporary until these can be split out into separate files (if necessary)
- 14:34 Changeset [59096] by
-
Implement the V8 bindings for the sync DB API.
https://bugs.webkit.org.show_bug.cgi?id=34994
Reviewed by Adam Barth.
- bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContextCustom::openDatabaseSyncCallback):
- 13:46 Changeset [59095] by
-
Clean up and fix the existing V8 DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Adam Barth.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- 13:03 Changeset [59094] by
-
[wx] Build fix for wx 2.8 after complex text changes.
- 12:59 Changeset [59093] by
-
Unbreak the world. (Fix Mac builds).
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 12:53 Changeset [59092] by
-
2010-05-07 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Add a bunch of windows-specific chromium baselines for the different
versions of windows to update them from a skia change.
- platform/chromium/test_expectations.txt:
- 12:47 Changeset [59091] by
-
2010-05-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Fix a bug in rebaseline-chromium-webkit-tests where we would crash
instead of logging an error and exiting if it couldn't find either a
debug or a release build of the image diff binary.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Added.
- 12:46 Changeset [59090] by
-
2010-05-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL
https://bugs.webkit.org/show_bug.cgi?id=38861
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_unittest.py:
- 12:36 Changeset [59089] by
-
2010-05-10 John Gregg <johnnyg@google.com>
[chromium] Try to fix the chromium build after r59085 by
including MathExtras.h before using isnan().
https://bugs.webkit.org/show_bug.cgi?id=38860
- html/canvas/WebGLIntegralTypedArrayBase.h:
- 11:59 Changeset [59088] by
-
[wx] Build fix for wx trunk after complex text changes.
- 11:14 Changeset [59087] by
-
2010-05-10 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Provide mechanism to cache metadata for a resource
https://bugs.webkit.org/show_bug.cgi?id=37874
No new tests because no new functionality.
- WebCore.gypi:
- loader/CachedMetadata.h: Added. (WebCore::CachedMetadata::create): (WebCore::CachedMetadata::deserialize): (WebCore::CachedMetadata::serialize): (WebCore::CachedMetadata::~CachedMetadata): (WebCore::CachedMetadata::dataTypeID): (WebCore::CachedMetadata::data): (WebCore::CachedMetadata::size): (WebCore::CachedMetadata::readUnsigned): (WebCore::CachedMetadata::appendUnsigned): (WebCore::CachedMetadata::CachedMetadata):
- loader/CachedResource.cpp: (WebCore::CachedResource::setSerializedCachedMetadata): (WebCore::CachedResource::setCachedMetadata): (WebCore::CachedResource::cachedMetadata):
- loader/CachedResource.h:
- loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveCachedMetadata):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveCachedMetadata):
- loader/SubresourceLoader.h:
- loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
- loader/loader.cpp: (WebCore::Loader::Host::didReceiveCachedMetadata):
- loader/loader.h:
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveCachedMetadata):
2010-05-10 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Provide mechanism to cache metadata for a resource
https://bugs.webkit.org/show_bug.cgi?id=37874
- src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
- 11:12 Changeset [59086] by
-
Change the order of the RendererType enum values, so that old versions of WebKitPluginHost will
use accelerated compositing and not layer backed views.
Reviewed by Simon Fraser.
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 10:53 Changeset [59085] by
-
2010-05-09 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Refactor WebGLArray types to share more code
https://bugs.webkit.org/show_bug.cgi?id=37712
Refactored WebGLArray types for maximal code sharing. Added
WebGLTypedArrayBase and WebGLIntegralTypedArrayBase template
superclasses. Changed overridden virtuals to have minimal
visibility (private instead of public). Fixed const correctness of
a few methods. There are no changes to the public APIs of the
WebGLArray classes; the JavaScript bindings are unchanged.
No new tests; existing tests cover this functionality. Ran all
WebGL layout tests in Safari and Chromium on Mac OS X.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/WebGLArray.h: (WebCore::WebGLArray::buffer): (WebCore::WebGLArray::baseAddress): (WebCore::WebGLArray::byteOffset):
- html/canvas/WebGLByteArray.cpp: (WebCore::WebGLByteArray::create): (WebCore::WebGLByteArray::WebGLByteArray): (WebCore::WebGLByteArray::slice):
- html/canvas/WebGLByteArray.h: (WebCore::WebGLByteArray::isByteArray):
- html/canvas/WebGLFloatArray.cpp: (WebCore::WebGLFloatArray::create): (WebCore::WebGLFloatArray::WebGLFloatArray): (WebCore::WebGLFloatArray::slice):
- html/canvas/WebGLFloatArray.h: (WebCore::WebGLFloatArray::set): (WebCore::WebGLFloatArray::item): (WebCore::WebGLFloatArray::isFloatArray):
- html/canvas/WebGLIntArray.cpp: (WebCore::WebGLIntArray::create): (WebCore::WebGLIntArray::WebGLIntArray): (WebCore::WebGLIntArray::slice):
- html/canvas/WebGLIntArray.h: (WebCore::WebGLIntArray::isIntArray):
- html/canvas/WebGLIntegralTypedArrayBase.h: Added. (WebCore::WebGLIntegralTypedArrayBase::set): (WebCore::WebGLIntegralTypedArrayBase::item): (WebCore::WebGLIntegralTypedArrayBase::WebGLIntegralTypedArrayBase):
- html/canvas/WebGLShortArray.cpp: (WebCore::WebGLShortArray::create): (WebCore::WebGLShortArray::WebGLShortArray): (WebCore::WebGLShortArray::slice):
- html/canvas/WebGLShortArray.h: (WebCore::WebGLShortArray::isShortArray):
- html/canvas/WebGLTypedArrayBase.h: Added. (WebCore::WebGLTypedArrayBase::data): (WebCore::WebGLTypedArrayBase::set): (WebCore::WebGLTypedArrayBase::length): (WebCore::WebGLTypedArrayBase::WebGLTypedArrayBase): (WebCore::WebGLTypedArrayBase::create): (WebCore::WebGLTypedArrayBase::sliceImpl): (WebCore::WebGLTypedArrayBase::byteLength):
- html/canvas/WebGLUnsignedByteArray.cpp: (WebCore::WebGLUnsignedByteArray::create): (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray): (WebCore::WebGLUnsignedByteArray::slice):
- html/canvas/WebGLUnsignedByteArray.h: (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
- html/canvas/WebGLUnsignedIntArray.cpp: (WebCore::WebGLUnsignedIntArray::create): (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray): (WebCore::WebGLUnsignedIntArray::slice):
- html/canvas/WebGLUnsignedIntArray.h: (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
- html/canvas/WebGLUnsignedShortArray.cpp: (WebCore::WebGLUnsignedShortArray::create): (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray): (WebCore::WebGLUnsignedShortArray::slice):
- html/canvas/WebGLUnsignedShortArray.h: (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
- 10:25 Changeset [59084] by
-
Unreviewed.
Adding myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 10:12 Changeset [59083] by
-
Build fix, not reviewed.
Correct post-build copy command for WinCairo port to make sure
cairo headers are available for WebKit.dll build.
- WebCore.vcproj/WebCore.vcproj:
- 09:23 Changeset [59082] by
-
2010-05-10 Dirk Schulze <krit@webkit.org>
Unreviewed.
Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820
New baseline for Qt.
- platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/qt/svg/css/mask-with-shadow-expected.txt:
- platform/qt/svg/custom/empty-mask-expected.txt:
- platform/qt/svg/custom/mask-invalidation-expected.txt:
- platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/qt/svg/custom/transformedMaskFails-expected.txt:
- 08:59 Changeset [59081] by
-
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820
This is a further optimization to get smaller repaintRects on SVG objects
in combination with masker or clipper resources.
Masker takes the unite of all stroke boundaries of it's childs.
Both, clipper and masker, store this union to avoid multiple calls of the childs
and the unite calculations now.
The unite rect can be transformed to any targets objectBoundingBox, if the content
unit of the resource is set to objectBoundingBoxMode.
This speeds up the use of resources with multiple target objects.
No behavior changes, the smaller repaintRects cause updates for DRT results.
- rendering/RenderSVGResource.h:
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::invalidateClients): (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
- rendering/RenderSVGResourceClipper.h:
- rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
- rendering/RenderSVGResourceFilter.h:
- rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
- rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
- rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClients): (WebCore::RenderSVGResourceMasker::createMaskImage): (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect): (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
- rendering/RenderSVGResourceMasker.h:
- rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
- rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820
The repaintRect of SVG objects with masks got smaller. This made
updates of some results necessary.
- platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
- platform/mac/svg/batik/masking/maskRegions-expected.txt:
- platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
- platform/mac/svg/css/mask-with-shadow-expected.txt:
- platform/mac/svg/custom/empty-mask-expected.txt:
- platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
- platform/mac/svg/custom/mask-inside-defs-expected.txt:
- platform/mac/svg/custom/mask-invalidation-expected.txt:
- platform/mac/svg/custom/mask-with-all-units-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/visibility-override-mask-expected.txt:
- svg/custom/transformedMaskFails-expected.txt:
- 08:21 Changeset [59080] by
-
2010-05-11 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Cosmetic changes.
1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
2) Standard tooltips for resource links are clashing with Popover.
3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
https://bugs.webkit.org/show_bug.cgi?id=38732
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
- 07:48 Changeset [59079] by
-
2010-05-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Layout test for Session Storage quota should only expect to fit 39 objects.
https://bugs.webkit.org/show_bug.cgi?id=38843
The script should be ready for the exception when inserting the 40th
element, as that is where it will be thrown if a quota is enforced.
This is the same change as in http://trac.webkit.org/changeset/50979.
- storage/domstorage/quota-expected.txt:
- storage/domstorage/script-tests/quota.js: (testNoQuota):
- 07:36 Changeset [59078] by
-
2010-05-10 Adam Langley <agl@chromium.org>
Expectations change. Not reviewed.
Delete the current baselines for the WOFF test because they are
incomplete.
Remove the SKIP tag from test_expectations so that the builders
will run the test and then the rebaseline tool can be used to
checkin real baselines.
- platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Removed.
- platform/chromium-win/fast/css/font-face-woff-expected.checksum: Removed.
- platform/chromium-win/fast/css/font-face-woff-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 07:27 Changeset [59077] by
-
2010-05-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
https://bugs.webkit.org/show_bug.cgi?id=38750
Put a per-origin quota on session storage since it is using memory in
the browser process, and should not be allowed to grow arbitrarily
large. See also http://trac.webkit.org/changeset/58828.
- public/WebStorageNamespace.h:
- public/WebViewClient.h: (WebKit::WebViewClient::createSessionStorageNamespace):
- src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
2010-05-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
[Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
https://bugs.webkit.org/show_bug.cgi?id=38750
Put a per-origin quota on session storage since it is using memory in
the browser process, and should not be allowed to grow arbitrarily
large. See also http://trac.webkit.org/changeset/58828.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createSessionStorageNamespace):
- DumpRenderTree/chromium/WebViewHost.h:
- 07:03 Changeset [59076] by
-
[Qt] Roll-out r59020 and r59021, because the Qt part of these changes
haven't been landed in Qt trunk yet. Should be rolled-in again after the merge.
Rubber-stamped by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=32967
WebCore:
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
WebKitTools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
LayoutTests:
- platform/qt/Skipped:
- platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Removed.
- 06:48 BuildingQtOnWindows edited by
- add mingw-w64 howto (diff)
- 06:18 Changeset [59075] by
-
2010-05-10 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Simon Hausmann.
Qt after 4.6.3 has its integrated DNS cache. Therefore some
code is not necessary anymore.
- platform/network/qt/DnsPrefetchHelper.h: (WebCore::DnsPrefetchHelper::lookup): (WebCore::DnsPrefetchHelper::lookedUp):
- 06:07 Changeset [59074] by
-
2010-05-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
[Qt] Disable JIT support for mingw-w64
https://bugs.webkit.org/show_bug.cgi?id=38747
Disale JIT for mingw-w64 as it is reportedly
unstable.
Thanks for Vanboxem Rruben for the investigation.
- wtf/Platform.h:
- 04:53 Changeset [59073] by
-
2010-05-10 Dirk Schulze <krit@webkit.org>
Uneviewed.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
New baseline for Win. Only two tests needed an update.
- platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/win/svg/filters/feColorMatrix-values-expected.txt:
- 04:40 Changeset [59072] by
-
2010-05-10 Chris Jerdonek <cjerdonek@webkit.org>
Reviewed by Darin Adler.
Asserted that Node::setDocument() is not being used to change
the document of a node.
- dom/Node.cpp: (WebCore::Node::setDocument): Added an ASSERT at the beginning of the function.
- dom/Node.h: Documented that Node::setDocument() should not be used to change the document of a node until after the node has been removed from its prior document.
- 04:37 Changeset [59071] by
-
2010-05-10 Dirk Schulze <krit@webkit.org>
Unreviewed.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
New baseline for Gtk. Just one test needed an update.
- platform/gtk/svg/filters/filter-on-tspan-expected.txt:
- 04:34 Changeset [59070] by
-
2010-05-10 Dirk Schulze <krit@webkit.org>
Unreviewed.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
New baseline for Qt.
- platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/qt/svg/filters/feColorMatrix-values-expected.txt:
- platform/qt/svg/filters/feComposite-expected.txt:
- platform/qt/svg/filters/feGaussianBlur-expected.txt:
- platform/qt/svg/filters/feMerge-expected.txt:
- platform/qt/svg/filters/feOffset-expected.txt:
- platform/qt/svg/filters/feTile-expected.txt:
- platform/qt/svg/filters/filter-clip-expected.txt:
- platform/qt/svg/filters/filter-on-tspan-expected.txt:
- platform/qt/svg/filters/filter-source-position-expected.txt:
- platform/qt/svg/filters/shadow-on-filter-expected.txt:
- platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/qt/svg/filters/sourceAlpha-expected.txt:
- platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/qt/svg/filters/subRegion-one-effect-expected.txt:
- platform/qt/svg/filters/subRegion-two-effects-expected.txt:
- 04:15 Changeset [59069] by
-
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
All SVG Filter effects get dumped now. The structure of the DRT output
changed. The last effect is shown first, followed by the previous effects.
No changed behaior, so no new test added.
- platform/graphics/filters/FEBlend.cpp: (WebCore::operator<<): (WebCore::FEBlend::externalRepresentation):
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::operator<<): (WebCore::FEColorMatrix::externalRepresentation):
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::operator<<): (WebCore::FEComponentTransfer::externalRepresentation):
- platform/graphics/filters/FEComponentTransfer.h:
- platform/graphics/filters/FEComposite.cpp: (WebCore::operator<<): (WebCore::FEComposite::externalRepresentation):
- platform/graphics/filters/FEComposite.h: (WebCore::): (WebCore::FEComposite::uniteChildEffectSubregions):
- platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::externalRepresentation):
- platform/graphics/filters/FEGaussianBlur.h: (WebCore::FEGaussianBlur::uniteChildEffectSubregions):
- platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::externalRepresentation):
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::externalRepresentation):
- platform/graphics/filters/SourceAlpha.h:
- platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::externalRepresentation):
- platform/graphics/filters/SourceGraphic.h:
- rendering/RenderTreeAsText.cpp: (WebCore::writeIndent):
- rendering/RenderTreeAsText.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer):
- svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::operator<<): (WebCore::FEConvolveMatrix::externalRepresentation):
- svg/graphics/filters/SVGFEConvolveMatrix.h:
- svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::externalRepresentation):
- svg/graphics/filters/SVGFEDiffuseLighting.h:
- svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::operator<<): (WebCore::FEDisplacementMap::externalRepresentation):
- svg/graphics/filters/SVGFEDisplacementMap.h:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::externalRepresentation):
- svg/graphics/filters/SVGFEFlood.h:
- svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::externalRepresentation):
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::externalRepresentation):
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::operator<<): (WebCore::FEMorphology::externalRepresentation):
- svg/graphics/filters/SVGFEMorphology.h:
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::externalRepresentation):
- svg/graphics/filters/SVGFEOffset.h:
- svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::externalRepresentation):
- svg/graphics/filters/SVGFESpecularLighting.h:
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::externalRepresentation):
- svg/graphics/filters/SVGFETile.h:
- svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::operator<<): (WebCore::FETurbulence::externalRepresentation):
- svg/graphics/filters/SVGFETurbulence.h:
2010-05-10 Dirk Schulze <krit@webkit.org>
Reviewed by Darin Adler.
SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683
All SVG Filter effects get dumped now. The structure of the DRT output
changed. The last effect is shown first, followed by the previous effects.
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/mac/svg/batik/filters/feTile-expected.txt:
- platform/mac/svg/batik/filters/filterRegions-expected.txt:
- platform/mac/svg/batik/text/textEffect-expected.txt:
- platform/mac/svg/batik/text/textEffect3-expected.txt:
- platform/mac/svg/batik/text/textFeatures-expected.txt:
- platform/mac/svg/batik/text/textProperties-expected.txt:
- platform/mac/svg/custom/empty-merge-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/non-opaque-filters-expected.txt:
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
- platform/mac/svg/custom/text-filter-expected.txt:
- platform/mac/svg/custom/visibility-override-filter-expected.txt:
- platform/mac/svg/filters/big-sized-filter-2-expected.txt:
- platform/mac/svg/filters/big-sized-filter-expected.txt:
- platform/mac/svg/filters/feColorMatrix-values-expected.txt:
- platform/mac/svg/filters/feComposite-expected.txt:
- platform/mac/svg/filters/feDisplacementMap-expected.txt:
- platform/mac/svg/filters/feGaussianBlur-expected.txt:
- platform/mac/svg/filters/feMerge-expected.txt:
- platform/mac/svg/filters/feOffset-expected.txt:
- platform/mac/svg/filters/feTile-expected.txt:
- platform/mac/svg/filters/filter-clip-expected.txt:
- platform/mac/svg/filters/filter-on-tspan-expected.txt:
- platform/mac/svg/filters/filter-source-position-expected.txt:
- platform/mac/svg/filters/filterRes-expected.txt:
- platform/mac/svg/filters/shadow-on-filter-expected.txt:
- platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
- platform/mac/svg/filters/sourceAlpha-expected.txt:
- platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
- platform/mac/svg/filters/subRegion-one-effect-expected.txt:
- platform/mac/svg/filters/subRegion-two-effects-expected.txt:
- 02:53 Changeset [59068] by
-
2010-05-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Change IndexedDB to use events instead of callbacks
https://bugs.webkit.org/show_bug.cgi?id=38594
Switch IndexedDB over to an event based model to match what
Mozilla (and probably MS?) are doing. This also gets rid of
a lot of template mess at the expense of a little extra boiler
plate code (for each type that IDBResult.result could be).
This change also introduces JSC bindings that match the level of
functionality the V8 bindings have.
Still not testable, but that shoudl change shortly.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventCustom.cpp:
- bindings/js/JSIDBRequestCustom.cpp: Added. (WebCore::JSIDBRequest::result):
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- bindings/v8/custom/V8CustomIDBCallbacks.h: Removed.
- bindings/v8/custom/V8IDBRequestCustom.cpp: Added. (WebCore::V8IDBRequest::resultAccessorGetter):
- bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: Removed.
- dom/EventTarget.cpp: (WebCore::EventTarget::toIDBRequest):
- dom/EventTarget.h:
- storage/IDBCallbacks.h:
- storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::createObjectStore):
- storage/IDBRequest.cpp: Added. (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::idbDatabaseResult): (WebCore::IDBRequest::serializedScriptValueResult): (WebCore::IDBRequest::onError): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::scriptExecutionContext): (WebCore::IDBRequest::stop): (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::eventTargetData): (WebCore::IDBRequest::ensureEventTargetData): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
- storage/IDBRequest.h: Added. (WebCore::IDBRequest::create): (WebCore::IDBRequest::): (WebCore::IDBRequest::resultType): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::error): (WebCore::IDBRequest::toIDBRequest): (WebCore::IDBRequest::refEventTarget): (WebCore::IDBRequest::derefEventTarget):
- storage/IDBRequest.idl: Added.
- storage/IndexedDatabase.h:
- storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
- storage/IndexedDatabaseImpl.h:
- storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
- storage/IndexedDatabaseRequest.h:
- storage/IndexedDatabaseRequest.idl:
2010-05-10 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Change IndexedDB to use events instead of callbacks
https://bugs.webkit.org/show_bug.cgi?id=38594
Change the glue here to match the changes I made in WebCore.
- WebKit.gyp:
- public/WebIDBCallbacks.h:
- public/WebIndexedDatabase.h:
- src/IDBCallbacksProxy.cpp: Added. (WebCore::IDBCallbacksProxy::IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::onError): (WebCore::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
- src/IndexedDatabaseProxy.h:
- src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
- src/WebIndexedDatabaseImpl.h:
- 00:02 Changeset [59067] by
-
2010-05-09 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
JavaScriptCore/wtf/MD5.h: checksum should take a reference to output.
https://bugs.webkit.org/show_bug.cgi?id=38723
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- wtf/MD5.cpp: (WTF::expectMD5): Fix for checksum change. (WTF::MD5::checksum): Take a reference to output, instead of returning the result by value, to reduce coping for performance.
- wtf/MD5.h:
05/09/10:
- 22:07 Changeset [59066] by
-
Unreviewed, test expectation update.
Update Chromium/Linux expectation for fast/forms/input-file-re-render.html.
http://crbug.com/40027
- platform/chromium-linux/fast/forms/input-file-re-render-expected.checksum:
- platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
- platform/chromium/test_expectations.txt:
- 19:17 Changeset [59065] by
-
Fix accidental repeat addition of emit_op_new_regexp
- 18:41 Changeset [59064] by
-
2010-05-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Reserve a large-ish initial capacity for Lexer::m_buffer16.
SunSpider says 0.3% faster.
m_buffer16 is used when parsing complex strings -- for example, strings
with escape sequences in them. These kinds of strings can be really long,
and we want to avoid repeatedly copying as we grow m_buffer16.
The net memory cost is quite low, since it's proporitional to source
code we already have in memory, and we throw away m_buffer16 right when
we're done parsing.
- parser/Lexer.cpp: (JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor, since setCode will be called before we're asked to lex anything. (JSC::Lexer::setCode): Reserve enough space to lex half the source code as a complex string without having to copy. (JSC::Lexer::clear): No need to reserve initial capacity here either, since setCode will be called before we're asked to lex anything.
2010-05-09 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
REGRESSION(r57955): RegExp literals should not actually be cached, so r57955 should be rolled out.
https://bugs.webkit.org/show_bug.cgi?id=38828
Replace incorrect test for caching regexp literals with ones that tests that they are not cached.
- fast/js/regexp-literals-are-constants-expected.txt: Removed.
- fast/js/regexp-literals-are-constants.html: Removed.
- fast/js/regexp-literals-arent-constants-expected.txt: Added.
- fast/js/regexp-literals-arent-constants.html: Added.
- fast/js/script-tests/regexp-literals-are-constants.js: Removed.
- fast/js/script-tests/regexp-literals-arent-constants.js: Added. (test1): (returnRegExpLiteral): (returnConditionalRegExpLiteral):
- 15:09 Changeset [59063] by
-
2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
Not reviewed: rollback the commit r59062
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
- 14:38 Changeset [59062] by
-
2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Cosmetic changes.
1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
2) Standard tooltips for resource links are clashing with Popover.
3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
https://bugs.webkit.org/show_bug.cgi?id=38732
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
- inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
- 14:16 Changeset [59061] by
-
Reserve a large-ish initial capacity for Lexer::m_buffer16.
Reviewed by Oliver Hunt.
SunSpider says 0.3% faster.
m_buffer16 is used when parsing complex strings -- for example, strings
with escape sequences in them. These kinds of strings can be really long,
and we want to avoid repeatedly copying as we grow m_buffer16.
The net memory cost is quite low, since it's proporitional to source
code we already have in memory, and we throw away m_buffer16 right when
we're done parsing.
- parser/Lexer.cpp:
(JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor,
since setCode will be called before we're asked to lex anything.
(JSC::Lexer::setCode): Reserve enough space to lex half the source code
as a complex string without having to copy.
(JSC::Lexer::clear): No need to reserve initial capacity here either,
since setCode will be called before we're asked to lex anything.
- 14:11 Changeset [59060] by
-
2010-05-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt] Remove YARR configuration rules from Qt make system
https://bugs.webkit.org/show_bug.cgi?id=38819
Setting YARR based on JIT seeting is now in Platform.h
for all ports. This patch essentially reverses r49238.
- JavaScriptCore.pri:
- 13:58 Changeset [59059] by
-
2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: If some record is not in visible area then it's expand element also is not
visible even if it has children in visible area.
https://bugs.webkit.org/show_bug.cgi?id=38643
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._refreshRecords):
- 13:34 Changeset [59058] by
-
Fix for https://bugs.webkit.org/show_bug.cgi?id=38557
r58526 introduced a ~30% regression on Dromaeo JS lib
Reviewed by Darin Adler.
This fix does two things.
- Don't use QualifiedName as the key to a HashMap, use a RefPtr<QualifiedNameImpl> instead. We should remove the HashTraits for QualifiedName and that will happen in a follow up patch.
- Only mark cached NodeLists on Documents instead of all Nodes. This is okay since the marking of NodeLists is an optimization to keep NodeList wrappers alive and is not mandated by any spec.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::markChildren):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren):
- dom/Node.cpp:
(WebCore::Node::removeCachedTagNodeList):
(WebCore::Node::getElementsByTagNameNS):
- dom/NodeRareData.h:
- 09:37 Changeset [59057] by
-
2010-05-09 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Crash in QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate when animation were used
https://bugs.webkit.org/show_bug.cgi?id=38574
The fix uses a QWeakPointer for rootGraphicsLayer, protecting from a crash in case the layer is deleted before the QGraphicsWebView.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::setRootGraphicsLayer): (QGraphicsWebViewPrivate::updateCompositingScrollPosition):
- 04:42 Changeset [59056] by
-
2010-05-09 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej Stachowiak.
Improve string indexing performance
https://bugs.webkit.org/show_bug.cgi?id=38814
Add an assembly stub to do indexed loads from strings much
more cheaply than the current stub dispatch logic. We can
do this because we are able to make guarantees about the
register contents when entering the stub so the call overhead
is negligible.
- jit/JIT.h:
- jit/JITInlineMethods.h:
- jit/JITOpcodes.cpp:
- jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emitSlow_op_get_by_val):
Moved from JITOpcodes.cpp to keep the slowcase next to
the normal case codegen as we do for everything else.
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emitSlow_op_get_by_val):
- jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitFastArithImmToInt):
- 04:18 Changeset [59055] by
-
2010-05-09 Maciej Stachowiak <mjs@apple.com>
Fixed version of: "Optimized o[s] where o is a cell and s is a string"
https://bugs.webkit.org/show_bug.cgi?id=38815
Fixed the previous patch for this from Geoff Garen.
The two problems were a missing exception check and a PropertySlot
initialized improperly, leading to crashes and failures in the case
of getters accessed with bracket syntax.
Previous patch:
Optimized o[s] where o is a cell and s is a string, removing some old
code that wasn't really tuned for the JIT.
SunSpider says 0.8% faster.
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- runtime/JSCell.h:
- 03:24 Changeset [59054] by
-
2010-05-09 Robert Hogan <robert@webkit.org>
[Qt] Update expected results for unskipped editing/inserting tests
Unreviewed, remove platform-specific results for editing/inserting/6633727.html
- platform/qt/editing/inserting/6633727-expected.txt: Removed.
- 03:15 Changeset [59053] by
-
[Qt] Update expected results for unskipped editing/inserting tests
Unreviewed, add expected results for unskipped tests. Results are taken
from Qt bot.
- 02:52 Changeset [59052] by
-
[Qt] Unskip editing/inserting tests that fail due to x/y differences
2010-05-03 Robert Hogan <robert@webkit.org>
Reviewed by Eric Seidel.
[Qt] Unskip editing/inserting tests that fail due to x/y differences
Unskip the following tests:
editing/inserting/12882.html
editing/inserting/4840662.html
editing/inserting/4875189-1.html
editing/inserting/4959067.html
editing/inserting/4960120-2.html
editing/inserting/5002441.html
editing/inserting/5058163-2.html
editing/inserting/5156401-2.html
editing/inserting/5418891.html
editing/inserting/5510537.html
editing/inserting/5549929-2.html
editing/inserting/5549929-3.html
editing/inserting/6633727.html
editing/inserting/6703873.html
editing/inserting/editable-inline-element.html
editing/inserting/insert-3654864-fix.html
editing/inserting/insert-3659587-fix.html
editing/inserting/insert-3775316-fix.html
editing/inserting/insert-3778059-fix.html
editing/inserting/insert-3786362-fix.html
editing/inserting/insert-3800346-fix.html
editing/inserting/insert-3851164-fix.html
editing/inserting/insert-3907422-fix.html
editing/inserting/insert-after-delete-001.html
editing/inserting/insert-at-end-01.html
editing/inserting/insert-at-end-02.html
editing/inserting/insert-before-link-1.html
editing/inserting/insert-br-001.html
editing/inserting/insert-br-002.html
editing/inserting/insert-br-003.html
editing/inserting/insert-br-004.html
editing/inserting/insert-br-005.html
editing/inserting/insert-br-006.html
editing/inserting/insert-br-007.html
editing/inserting/insert-br-008.html
editing/inserting/insert-br-009.html
editing/inserting/insert-br-at-tabspan-001.html
editing/inserting/insert-br-at-tabspan-002.html
editing/inserting/insert-br-at-tabspan-003.html
editing/inserting/insert-br-quoted-001.html
editing/inserting/insert-br-quoted-002.html
editing/inserting/insert-br-quoted-003.html
editing/inserting/insert-br-quoted-004.html
editing/inserting/insert-br-quoted-005.html
editing/inserting/insert-br-quoted-006.html
editing/inserting/insert-div-001.html
editing/inserting/insert-div-002.html
editing/inserting/insert-div-003.html
editing/inserting/insert-div-004.html
editing/inserting/insert-div-005.html
editing/inserting/insert-div-006.html
editing/inserting/insert-div-007.html
editing/inserting/insert-div-008.html
editing/inserting/insert-div-009.html
editing/inserting/insert-div-010.html
editing/inserting/insert-div-011.html
editing/inserting/insert-div-012.html
editing/inserting/insert-div-013.html
editing/inserting/insert-div-014.html
editing/inserting/insert-div-015.html
editing/inserting/insert-div-016.html
editing/inserting/insert-div-017.html
editing/inserting/insert-div-018.html
editing/inserting/insert-div-019.html
editing/inserting/insert-div-020.html
editing/inserting/insert-div-021.html
editing/inserting/insert-div-022.html
editing/inserting/insert-div-024.html
editing/inserting/insert-div-025.html
editing/inserting/insert-div-026.html
editing/inserting/insert-div-027.html
editing/inserting/insert-paragraph-01.html
editing/inserting/insert-paragraph-02.html
editing/inserting/insert-paragraph-03.html
editing/inserting/insert-paragraph-04.html
editing/inserting/insert-paragraph-05.html
editing/inserting/insert-space-in-empty-doc.html
editing/inserting/insert-tab-001.html
editing/inserting/insert-tab-002.html
editing/inserting/insert-tab-004.html
editing/inserting/insert-text-at-tabspan-001.html
editing/inserting/insert-text-at-tabspan-002.html
editing/inserting/insert-text-at-tabspan-003.html
editing/inserting/line-break.html
editing/inserting/paragraph-separator-01.html
editing/inserting/paragraph-separator-02.html
editing/inserting/paragraph-separator-in-table-1.html
editing/inserting/paragraph-separator-in-table-2.html
editing/inserting/redo.html
editing/inserting/return-key-with-selection-003.html
editing/inserting/typing-001.html
editing/inserting/typing-002.html
editing/inserting/typing-003.html
editing/inserting/typing-around-br-001.html
editing/inserting/typing-around-image-001.html
editing/inserting/5058163-1.html
editing/inserting/edited-whitespace-1.html
editing/inserting/paragraph-separator-03.html
editing/inserting/return-key-with-selection-001.html
editing/inserting/return-key-with-selection-002.html
editing/inserting/4875189-2.html
- platform/qt/Skipped:
- 02:50 Changeset [59051] by
-
2010-05-09 Daniel Bates <dbates@rim.com>
Reviewed by Chris Jerdonek.
Make the regular expressions for parsing the start of an SVN
and Git header global variables since they are used throughout
VCSUtils.pm.
- Scripts/VCSUtils.pm:
- 02:08 Changeset [59050] by
-
2010-05-07 Daniel Bates <dbates@rim.com>
Unreviewed, change log fix.
Add back some entries inadvertently deleted in changeset 59000
<http://trac.webkit.org/changeset/59000> and not restored (as
intended) in changeset 59005 <http://trac.webkit.org/changeset/59005>.
- 01:42 Changeset [59049] by
-
Add back some entries accidentally deleted in r59000 and not restored as intended in r59005.
- 00:21 Changeset [59048] by
-
2010-05-09 Chris Jerdonek <cjerdonek@webkit.org>
Reviewed by Daniel Bates.
Finished moving the header-parsing logic from svn-apply and -unapply
to VCSUtils.pm's parsing methods.
- Scripts/VCSUtils.pm:
- Added to parseGitDiffHeader() the ability to parse and store whether a file is new or deleted.
- Also reordered in parseGitDiffHeader() some of the else statements to a more readable ordering.
- Added to parseSvnDiffHeader() the ability to parse and store whether a file is new.
- Scripts/svn-apply:
- Changed handleGitBinaryChange() to use the new "isNew" and "isDeletion" diffHash key-values.
- Changed patch() to use the new "isNew" diffHash key-value.
- Scripts/svn-unapply:
- Changed patch() to use the new "isNew" and "isDeletion" diffHash key-values.
- Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Added unit tests for new and deleted files.
- Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
- Updated the unit tests as necessary.
- Added a unit test for a deleted file.
- Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
- Updated the unit tests as necessary.
- Scripts/VCSUtils.pm:
05/08/10:
- 23:50 Changeset [59047] by
-
2010-05-08 Chris Jerdonek <cjerdonek@webkit.org>
Reviewed by Maciej Stachowiak.
Allow long comment lines to wrap to the window width instead
of to 80 characters.
- Bugzilla/Constants.pm:
- Introduced a new constant COMMENT_COLS_WRAP to replace COMMENT_COLS inside the wrap_comment() subroutine. The new constant effectively disables text wrapping by increasing the value used in wrap_comment() from 80 characters to a very large value (8000).
- Bugzilla/Util.pm:
- Replaced COMMENT_COLS with COMMENT_COLS_WRAP inside wrap_comment().
- skins/custom/global.css:
(.bz_comment_text):
- Eliminate the width styling on comments to allow long lines to wrap at the window width.
(.bz_comment_text > span.quote):
- Inherit the "white-space" property. This prevents long quoted lines in comments from causing non-quoted lines to extend beyond the window width.
- Bugzilla/Constants.pm:
- 20:21 Changeset [59046] by
-
2010-05-08 Antonio Gomes <tonikitoo@webkit.org>
Unreviewed attempt to fix Windows build.
- page/SpatialNavigation.h: (WebCore::fudgeFactor):
- 20:05 Changeset [59045] by
-
Spatial Navigation: create a getter for the "fudgeFactor"
https://bugs.webkit.org/show_bug.cgi?id=38488
Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>
A couple of places in the Spatial Navigation code make use of a "fudge factor"
to improve precision by working around outline focus metrics and such. Patch adds
a helper method for unify getter operations of this value, instead of having it
declared locally in the various methods it is used.
No behaviour change.
- page/SpatialNavigation.cpp:
(WebCore::scrollIntoView):
(WebCore::deflateIfOverlapped):
- page/SpatialNavigation.h:
(WebCore::fudgeFactor):
- 19:52 Changeset [59044] by
-
Added to svn-apply support for git renames and copies with similarity
index less than 100%.
Reviewed by Daniel Bates.
https://bugs.webkit.org/show_bug.cgi?id=32834
- Scripts/VCSUtils.pm:
- Added to parseGitDiffHeader() support for renames and similarity index less than 100%.
- Added to parseDiff() support for processing renames, renames with changes, and copies with changes.
- Added to parsePatch() the ability to process multiple return values from parseDiff().
- Scripts/svn-apply:
- Added to patch() the ability to process diff hashes with the isDeletion key-value set.
- Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Updated the unit tests as necessary.
- Added unit tests for rename with similarity index 100%, rename with similarity index < 100%, and rename with a change to the executable bit.
- Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
- Added unit tests for rename with similarity index 100%, rename with similarity index < 100%, and rename with a change to the executable bit.
- Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
- Updated the unit tests as necessary.
- Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
- Simplified the carriage-return unit test to more narrowly test only carriage returns.
- Scripts/VCSUtils.pm:
- 19:37 Changeset [59043] by
-
This revision suppresses the misleading "error: pathspec..." messages
when using svn-apply to add a binary file from a Git diff.
Reviewed by Daniel Bates.
https://bugs.webkit.org/show_bug.cgi?id=38047
When adding a new binary file from a Git diff, svn-apply prints
a misleading error of the form -- "error: pathspec '<filename>' did
not match any file(s) known to git. Did you forget to 'git add'?"
This patch suppresses these messages since they are normal.
- Scripts/VCSUtils.pm: Added the callSilently() subroutine from runPatchCommand.pl, which executes a Perl function while suppressing STDERR.
- Scripts/svn-apply: Refactored the Git portion of scmKnowsOfFile() into a gitKnowsOfFile(), and called this new subroutine using callSilently().
- Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Removed callSilently() since it was moved to VCSUtils.pm in this patch.
- 19:02 Changeset [59042] by
-
2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, build fix.
Fix missing terminating ' character warning
The warning has been only seen on the Gtk buildbots.
- wtf/Platform.h:
- 17:38 Changeset [59041] by
-
2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Gavin Barraclough.
Refactor YARR and YARR_JIT default rules in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=38727
Turn on YARR and YARR JIT by default of JIT is enabled.
Ports can overrule this default decisions as they wish.
- wtf/Platform.h:
- 15:59 Changeset [59040] by
-
2010-05-08 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Split JSVALUE32_64 code out of JITOpcodes.cpp and into JITOpcodes32_64.cpp
https://bugs.webkit.org/show_bug.cgi?id=38808
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JITOpcodes.cpp:
- jit/JITOpcodes32_64.cpp: Added. (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::emit_op_mov): (JSC::JIT::emit_op_end): (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emitSlow_op_loop_if_lesseq): (JSC::JIT::emit_op_new_object): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emitSlow_op_instanceof): (JSC::JIT::emit_op_new_func): (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_tear_off_activation): (JSC::JIT::emit_op_tear_off_arguments): (JSC::JIT::emit_op_new_array): (JSC::JIT::emit_op_resolve): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emitSlow_op_to_primitive): (JSC::JIT::emit_op_strcat): (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_resolve_skip): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_not): (JSC::JIT::emitSlow_op_not): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emitSlow_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emitSlow_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_sret): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::compileOpStrictEq): (JSC::JIT::emit_op_stricteq): (JSC::JIT::emitSlow_op_stricteq): (JSC::JIT::emit_op_nstricteq): (JSC::JIT::emitSlow_op_nstricteq): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_resolve_with_base): (JSC::JIT::emit_op_new_func_exp): (JSC::JIT::emit_op_throw): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_push_scope): (JSC::JIT::emit_op_pop_scope): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emitSlow_op_to_jsnumber): (JSC::JIT::emit_op_push_new_scope): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_jmp_scopes): (JSC::JIT::emit_op_switch_imm): (JSC::JIT::emit_op_switch_char): (JSC::JIT::emit_op_switch_string): (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_debug): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation): (JSC::JIT::emit_op_create_arguments): (JSC::JIT::emit_op_init_arguments): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emitSlow_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call):
- 13:47 Changeset [59039] by
-
2010-05-08 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Adler.
Change the npapi.h header guards to match the npapi-headers repository
copy.
- bridge/npapi.h:
- 13:03 Changeset [59038] by
-
2010-05-08 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Fix halfword loads on ARM
https://bugs.webkit.org/show_bug.cgi?id=38741
The BaseIndex and ImplicitAddress are contain 32bit wide offset, but
the load16 functions were working with 8 bit data (encoded in the
instruction). If the offset cannot be encoded in an instruction, it
should be stored in a temporary register.
- assembler/ARMAssembler.h: (JSC::ARMAssembler::getOffsetForHalfwordDataTransfer):
- assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::load16):
- 12:51 Changeset [59037] by
-
2010-05-08 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
Fix spanning branch instruction on Cortex-A8 with Thumb-2 JIT
https://bugs.webkit.org/show_bug.cgi?id=38280
If the 32-bit Thumb-2 branch instruction spans two 4KiB regions and
the target of the branch falls within the first region it is
possible for the processor to incorrectly determine the branch
instruction, and it is also possible in some cases for the processor
to enter a deadlock state.
- assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::linkJumpAbsolute):
- 12:36 Changeset [59036] by
-
2010-05-08 Victor Wang <victorw@chromium.org>
Reviewed by Adam Barth.
[chromium]: Upload test results json files to app engine server
Add an option to run_webkit_tests.py to upload generated
JSON files to app engine server. These JSON files will be used
by chromium layout test falkiness dashboard.
- Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Added.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 12:23 Changeset [59035] by
-
2010-05-08 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Resolve most of the whitespace/comment/order differences in npapi.h
and npruntime.h relative to the npapi-headers repository versions.
No changes to the substance of the code.
- bridge/npapi.h: (_NPPrint::): (_NPCocoaEvent::):
- bridge/npruntime.h:
- 12:05 Changeset [59034] by
-
2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Fix guard around IndexedDatabase
https://bugs.webkit.org/show_bug.cgi?id=38710
No new tests, there is no new functionality.
- page/PageGroup.h:
- 11:51 Changeset [59033] by
-
2010-05-08 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Platform plugin
https://bugs.webkit.org/show_bug.cgi?id=38438
Select popups delegate private API. To provide select popup delegates
a plugin that implements QWebKitPlatformPlugin must be found
in QCoreApplication::libraryPaths.
- WebCore.pro:
2010-05-08 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Platform plugin
https://bugs.webkit.org/show_bug.cgi?id=38438
Select popups delegate private API. To provide select popup delegates
a plugin that implements QWebKitPlatformPlugin must be found
in QCoreApplication::libraryPaths.
- Api/headers.pri:
- Api/qwebkitplatformplugin.h: Added. (QWebSelectData::~QWebSelectData): (QWebSelectData::): (QWebSelectMethod::~QWebSelectMethod): (QWebKitPlatformPlugin::~QWebKitPlatformPlugin): (QWebKitPlatformPlugin::):
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
- WebCoreSupport/ChromeClientQt.h:
- WebCoreSupport/QtPlatformPlugin.cpp: Added. (WebCore::SelectData::SelectData): (WebCore::SelectData::itemText): (WebCore::SelectData::itemToolTip): (WebCore::SelectData::itemIsEnabled): (WebCore::SelectData::itemCount): (WebCore::SelectData::itemIsSelected): (WebCore::SelectData::multiple): (WebCore::SelectData::itemType): (WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::show): (WebCore::SelectInputMethodWrapper::hide): (WebCore::SelectInputMethodWrapper::selectItem): (WebCore::SelectInputMethodWrapper::didHide): (WebCore::getPluginObject): (WebCore::QtPlatformPlugin::~QtPlatformPlugin): (WebCore::QtPlatformPlugin::plugin): (WebCore::QtPlatformPlugin::createSelectInputMethod):
- WebCoreSupport/QtPlatformPlugin.h: Added. (WebCore::QtPlatformPlugin::QtPlatformPlugin):
- 11:40 Changeset [59032] by
-
2010-05-08 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Laszlo Gombos.
[EFL] Only compile database stuff if ENABLE_DATABASE is set.
http://webkit.org/b/38777
- efl/WebCoreSupport/ChromeClientEfl.cpp:
- 11:29 Changeset [59031] by
-
2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Build the ImageDiff tool for all platforms including Windows and Symbian
https://bugs.webkit.org/show_bug.cgi?id=38706
- WebKit.pro:
2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Build the ImageDiff tool for all platforms including Windows and Symbian
https://bugs.webkit.org/show_bug.cgi?id=38706
Use qmath.h instead of math.h to make it portable.
- DumpRenderTree/qt/ImageDiff.cpp: (main):
- 11:17 Changeset [59030] by
-
2010-05-08 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
[EFL] It does not make sense to use RenderThemeEfl::RenderThemeEfl, so
use RenderThemeEfl (GCC 4.5 seems to be pickier about this).
http://webkit.org/b/38770
- platform/efl/RenderThemeEfl.cpp: (WebCore::renderThemeEflColorClassSelectionActive): (WebCore::renderThemeEflColorClassSelectionInactive): (WebCore::renderThemeEflColorClassFocusRing): (WebCore::renderThemeEflColorClassButtonText): (WebCore::renderThemeEflColorClassComboText): (WebCore::renderThemeEflColorClassEntryText): (WebCore::renderThemeEflColorClassSearchText): (WebCore::RenderThemeEfl::adjustCheckboxStyle): (WebCore::RenderThemeEfl::adjustRadioStyle): (WebCore::RenderThemeEfl::adjustButtonStyle): (WebCore::RenderThemeEfl::adjustMenuListStyle): (WebCore::RenderThemeEfl::adjustTextFieldStyle): (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
- 11:06 Changeset [59029] by
-
2010-05-08 Jens Alfke <snej@chromium.org>
Reviewed by Darin Fisher.
[chromium] WebFrame::registerPasswordListener shouldn't assert on duplicate listener.
https://bugs.webkit.org/show_bug.cgi?id=38765
- public/WebFrame.h: (WebKit::WebFrameImpl::registerPasswordListener): Changed return type to bool. Updated comment.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::registerPasswordListener): Return false instead of asserting.
- src/WebFrameImpl.h: (WebKit::WebFrameImpl::registerPasswordListener): Changed return type to bool.
- 10:53 Changeset [59028] by
-
2010-05-08 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
ResourceHandleSoup should depend only on GLib, not on GTK+.
http://webkit.org/b/38763
- platform/network/soup/ResourceHandleSoup.cpp: Include glib.h instead of gtk/gtk.h.
- 09:49 Changeset [59027] by
-
2010-05-08 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r59023.
http://trac.webkit.org/changeset/59023
https://bugs.webkit.org/show_bug.cgi?id=37874
Caused Chromium Windows build to fail to link.
- WebCore.gypi:
- loader/CachedMetadata.h: Removed.
- loader/CachedResource.cpp:
- loader/CachedResource.h:
- loader/ResourceLoader.h:
- loader/SubresourceLoader.cpp:
- loader/SubresourceLoader.h:
- loader/SubresourceLoaderClient.h:
- loader/loader.cpp:
- loader/loader.h:
- platform/network/ResourceHandle.cpp:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.h:
- 06:31 Changeset [59026] by
-
2010-05-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Document a limitation of QWebPage::linkClicked
https://bugs.webkit.org/show_bug.cgi?id=37694
- Api/qwebpage.cpp:
- 06:20 Changeset [59025] by
-
2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Timothy Hatcher.
WebInspector: Autocompletion in console is not usable because it is not add to the entered text the common prefix of suggestions.
As example if you entered $0.getE then getElementByClassName will be suggested as gray text.
If you press tab then getElementByClassName be suggested again and lementByClassName becomes selected as black text with selection background.
Really after pressing the TAB the next suggestion should be selected (getElementByTagName) and only flexible part of suggestions should be selected.
In this case it should be TagName because getElementBy is the common part for all getE prefix suggestions.
https://bugs.webkit.org/show_bug.cgi?id=38753
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):
- 06:09 Changeset [59024] by
-
2010-05-08 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
[WTFURL] Add a buffer for managing the output of the canonicalizer
https://bugs.webkit.org/show_bug.cgi?id=38671
The canonicalizer produces a stream of canonicalized characters, which
we will store in a URLBuffer. URLBuffer is quite similar to Vector,
but serves as an abstraction to isolate us from the underlying
character storage. In the case of WebKit, we'll probably implement a
subclass of URLBuffer with Vector. In Chromium, the backing store is a
std::string, which avoids an unnecessary memcpy that would be caused by
using Vector instead.
- wtf/url/src/URLBuffer.h: Added. (WTF::URLBuffer::URLBuffer): (WTF::URLBuffer::~URLBuffer): (WTF::URLBuffer::at): (WTF::URLBuffer::set): (WTF::URLBuffer::capacity): (WTF::URLBuffer::length): (WTF::URLBuffer::data): (WTF::URLBuffer::setLength): (WTF::URLBuffer::append): (WTF::URLBuffer::grow):
- 05:58 Changeset [59023] by
-
2010-05-08 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
Provide mechanism to store cached metadata on a CachedResource.
https://bugs.webkit.org/show_bug.cgi?id=37874
No new tests because no new functionality.
- WebCore.gypi:
- loader/CachedMetadata.h: Added. (WebCore::CachedMetadata::~CachedMetadata): (WebCore::CachedMetadata::data): (WebCore::CachedMetadata::size): (WebCore::CachedMetadata::create): (WebCore::CachedMetadata::deserialize): (WebCore::CachedMetadata::serialize): (WebCore::CachedMetadata::dataTypeID): (WebCore::CachedMetadata::readUnsigned): (WebCore::CachedMetadata::appendUnsigned): (WebCore::CachedMetadata::CachedMetadata):
- loader/CachedResource.cpp: (WebCore::CachedResource::setSerializedCachedMetadata): (WebCore::CachedResource::setCachedMetadata): (WebCore::CachedResource::cachedMetadata):
- loader/CachedResource.h:
- loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveCachedMetadata):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveCachedMetadata):
- loader/SubresourceLoader.h:
- loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
- loader/loader.cpp: (WebCore::Loader::Host::didReceiveCachedMetadata):
- loader/loader.h:
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveCachedMetadata):
- 05:39 Changeset [59022] by
-
2010-05-08 Michael Nordman <michaeln@google.com>
Reviewed by Dmitry Titov.
Have WorkerScriptLoader provide access to the ResourceResponse for the loaded script
through the WorkerScriptLoaderClient interface.
https://bugs.webkit.org/show_bug.cgi?id=38605
No new tests. There are no script visible changes.
- workers/WorkerScriptLoader.cpp: Call the client with the response. (WebCore::WorkerScriptLoader::didReceiveResponse):
- workers/WorkerScriptLoaderClient.h: Define a new method to receive the response. (WebCore::WorkerScriptLoaderClient::didReceiveResponse):
2010-05-08 Michael Nordman <michaeln@google.com>
Reviewed by Dmitry Titov.
Add an additional parameter to the WebSharedWorker::startWorkerContext method
to indicate which appcache the shared worker script resource was loaded from,
and provide that value when calling out to chrome via this interface.
https://bugs.webkit.org/show_bug.cgi?id=38605
I'm keeping the old method around until patches can land in both repositories
that make the old method obsolete and unneeded. There's a FIXME for that.
Also somewhat related but independent change to propagate the runtime enabled
flag thru to the page settings instance used by the 'shadow page'.
- public/WebSharedWorker.h: Add the new param (but keep the old interface around for now too) (WebKit::WebSharedWorker::startWorkerContext):
- src/SharedWorkerRepository.cpp: Provide the value when calling out to chrome. (WebCore::SharedWorkerScriptLoader::notifyFinished):
- src/WebSharedWorkerImpl.cpp: (WebKit::WebSharedWorkerImpl::startWorkerContext):
- src/WebSharedWorkerImpl.h:
- src/WebWorkerBase.cpp: Propagate runtime enabled flag thru to the page settings. (WebKit::WebWorkerBase::initializeLoader):
- 05:13 Changeset [59021] by
-
2010-05-08 Robert Hogan <robert@webkit.org>
Unreviewed Qt bot fix: test unskipped accidentally in r59020.
- platform/qt/Skipped: Uncommented http/tests/xmlhttprequest/failed-auth.html again.
- 04:50 Changeset [59020] by
-
[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html
2010-05-08 Robert Hogan <robert@roberthogan.net>
Reviewed by Simon Hausmann.
[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html
and http/tests/xmlhttprequest/cross-origin-authorization.html
QHttpNetworkRequest adds Authorization and Cookie headers to XHRs
without knowing if this is valid behaviour or not. In order to allow
Qt to decide whether Cookie/Authorization headers should be added
to an XHR QtWebKit needs to use an attribute added to QNetworkRequest.
These new attributes are: QNetworkRequest::CookieLoadControlAttribute,
QNetworkRequest::CookieSaveControlAttribute,and
QNetworkRequest::AuthenticationReuseControlAttribute.
QtWebKit will set QNetworkRequest::AuthenticationReuseControlAttribute to false
unless withCredentials is set to true in the XHR.
QtWebkit will set CookieLoad/SaveControlAttribute to false unless withCredentials
is set to true in the XHR.
Qt will pass the values onto QHttpNetworkRequest and this will permit
the Qt network access processing to decide whether or not to add either
or both of the Cookie/Authorisation headers, and whether to save cookies
returned from such requests. By default the attribute
will always be true so unless QtWebKit sets it to false normal
header processing is unaffected.
There are platform-specific results for cross-origin-no-authorization.html:
- Qt's DRT does not capture the final 'DONE'.
- QNetworkReplyHandler.cpp's ignoreHttpError() means that async requests do not execute didFail() when they receive a 401 HTTP response. This results in async tests passing with '401 Authorisation required' rather than 'received error event'.
The Qt part of these changes was merged at: http://gitorious.org/qt/qt/merge_requests/592
In order to properly support the tests, Qt's DRT needs to use one
NetworkAccessManager for all pages. This allows it to use cached
credentials where appropriate.
The tests now pass when run individually but there seems to be a problem with
leaking the results of requests across tests when run with the others in
http/tests. This will be addressed in a separate patch.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
- platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
- platform/qt/Skipped: Group together the tests that are waiting for 4.7 to be unskipped.
- platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
- 04:48 Changeset [59019] by
-
2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInsector: Record expand UI element should be extracted from TimelineRecordGraphRow as separate class for future reuse.
https://bugs.webkit.org/show_bug.cgi?id=38726
- inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._refreshRecords): (WebInspector.TimelineRecordGraphRow): (WebInspector.TimelineRecordGraphRow.prototype.update): (WebInspector.TimelineExpandableElement): (WebInspector.TimelineExpandableElement.prototype._update): (WebInspector.TimelineExpandableElement.prototype._dispose):
- 04:08 Changeset [59018] by
-
2010-05-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Forgot to rebase fast/dom/prototype-inheritance-2.html after the <vkern> patches.
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- 04:01 Changeset [59017] by
-
[Qt] unskip http/tests/plugins/npapi-response-headers.html
2010-05-04 Robert Hogan <robert@webkit.org>
Reviewed by Eric Seidel.
[Qt] unskip http/tests/plugins/npapi-response-headers.html
Turns out this failed because run-webkit-tests was eating the first occurrence
of 'Content-Type: text/plain' in the test output as a header. Strange but true.
So do as Chromium does and preface all text dumps with the
'Content-Type: text/plain' header.
Take this opportunity to unskip plugins/private-browsing-mode.html too, which
has passed since r55433. See https://bugs.webkit.org/show_bug.cgi?id=33180
and https://bugs.webkit.org/show_bug.cgi?id=35576.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
- platform/qt/Skipped:
- 03:55 Changeset [59016] by
-
[Qt] Fix encoding of status message in Plugin API
2010-05-05 Robert Hogan <robert@webkit.org>
Reviewed by Alexey Proskuryakov.
[Qt] Fix encoding of status message in Plugin API
Spotted by Alexey Proskuryakov.
- platform/qt/Skipped: Unskip plugins/set-status.html
- plugins/PluginView.cpp: (WebCore::PluginView::status):
- 03:11 Changeset [59015] by
-
2010-05-08 Dirk Schulze <krit@webkit.org>
Unreviewed win build fix.
JS bindings were missing in DerivedSources.cpp
- DerivedSources.cpp:
- 03:01 Changeset [59014] by
-
2010-05-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline Win specific results after exposing JSSVGVKernElement/JSSVGHKernElement.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 02:56 Changeset [59013] by
-
2010-05-08 Dirk Schulze <krit@webkit.org>
Uneviewed fix of Win bot
Added JS bindings to Win build system.
- WebCore.vcproj/WebCore.vcproj:
- 02:54 Changeset [59012] by
-
2010-05-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline GTK specific results after exposing JSSVGVKernElement/JSSVGHKernElement.
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- 02:28 Changeset [59011] by
-
2010-05-08 Dirk Schulze <krit@webkit.org>
Unreviewed try to fix Win bot.
SVGFont's VKern implementation missing
https://bugs.webkit.org/show_bug.cgi?id=38663
- bindings/scripts/CodeGeneratorJS.pm:
- 02:06 Changeset [59010] by
-
2010-05-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGFont's VKern implementation missing
https://bugs.webkit.org/show_bug.cgi?id=38663
Implementation of vkern, needed by SVGFont. Also added DOM and JS bindings
for vkern and hkern. Made some clean-up in SVGParserUtilities and SVGFontElement.
SVGHKernElement and SVGVKernElement share most of the code now.
Test: svg/text/text-vkern.svg
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/DOMWindow.idl:
- rendering/SVGRootInlineBox.cpp: (WebCore::applySVGKerning): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
- svg/SVGAllInOne.cpp:
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::invalidateGlyphCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::matches): (WebCore::kerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs):
- svg/SVGFontElement.h: (WebCore::SVGKerningPair::SVGKerningPair): (WebCore::SVGFontElement::rendererIsNeeded):
- svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::buildHorizontalKerningPair):
- svg/SVGHKernElement.h:
- svg/SVGParserUtilities.cpp: (WebCore::parseGlyphName): (WebCore::parseKerningUnicodeString):
- svg/SVGParserUtilities.h:
- svg/SVGVKernElement.cpp: Added. (WebCore::SVGVKernElement::SVGVKernElement): (WebCore::SVGVKernElement::~SVGVKernElement): (WebCore::SVGVKernElement::insertedIntoDocument): (WebCore::SVGVKernElement::removedFromDocument): (WebCore::SVGVKernElement::buildVerticalKerningPair):
- svg/SVGVKernElement.h: Added. (WebCore::SVGVKernElement::rendererIsNeeded):
- svg/SVGVKernElement.idl: Added.
- svg/svgtags.in:
2010-05-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGFont's VKern implementation missing
https://bugs.webkit.org/show_bug.cgi?id=38663
The changes in DOMWindow.idl and the implementation of the DOM
and JS bindings of VKern and HKern made some updates necessary.
Added new test case for SVGFont's VKern.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-property-descriptors-expected.txt:
- fast/dom/prototype-inheritance-2-expected.txt:
- fast/dom/prototype-inheritance-expected.txt:
- fast/js/global-constructors-expected.txt:
- platform/mac/svg/text/text-vkern-expected.checksum: Added.
- platform/mac/svg/text/text-vkern-expected.png: Added.
- platform/mac/svg/text/text-vkern-expected.txt: Added.
- svg/custom/global-constructors-expected.txt:
- svg/text/text-vkern.svg: Added.
2010-05-08 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGFont's VKern implementation missing
https://bugs.webkit.org/show_bug.cgi?id=38663
- projects/svg/status.xml:
- 01:44 Changeset [59009] by
-
Unreviewed, just fixing windows build.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h: Add #if USE(ACCELERATED_COMPOSITING) guards around GraphicsLayer areas of the code. Include GraphicsLayer.h directly.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: As above.
- platform/graphics/win/QTMovieVisualContext.cpp: Remove the #include of d3d9types.h.
- 01:26 Changeset [59008] by
-
Fix the windows build (by adding #if USE(ACCELERATED_COMPOSITING) guards).
- 00:38 Changeset [59007] by
-
Fix the windows build.
- 00:24 Changeset [59006] by
-
2010-05-08 Eric Seidel <eric@webkit.org>
Reviewed by Daniel Bates.
test-webkitpy fails under cygwin
https://bugs.webkit.org/show_bug.cgi?id=38718
- Scripts/webkitpy/common/system/executive.py:
- Add _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE and _KILL_ALL_KILLED_PROCESS_EXIT_CODE to store the expected exit codes of processes killed by kill_process and kill_all. These two constants are only used by the unit tests but are stored in executive.py so they can be right next to the platform ifs.
- Remove unnecessary str() conversion, run_command does that for us.
- Make os.kill retry on cygwin on EAGAIN. It's unclear why CYGWIN throws EAGAIN, but it only does so sometimes. 3 may not be enough retries, but we'll try it to start with.
- Add _windows_image_name to automatically convert "yes" to "yes.exe" for use with taskkill.exe /im. Various callers to kill_all could be updated to remove the .exe, but that can be done in another patch.
- Use taskkill.exe for killall on cygwin.
- Scripts/webkitpy/common/system/executive_unittest.py:
- Use the new *_KILLED_PROCESS_EXIT_CODE constants which are correctly set to 0 on windows/cygwin systems where taskkill.exe is used.
- Test _windows_image_name
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Add FIXME about including mac-snowleopard in baseline_search_path.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Make default_configuration actually read from the Configuration file.
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
- Test default_configuration
- Scripts/webkitpy/layout_tests/port/win.py:
- Need a basic baseline_search_path if --platform dryrun is to work.
- Scripts/webkitpy/common/system/executive.py:
- 00:14 Changeset [59005] by
-
2010-05-08 Eric Seidel <eric@webkit.org>
Unreviewed, just reverting commit.
REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
https://bugs.webkit.org/show_bug.cgi?id=38798
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitResolve):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_resolve_global):
2010-05-08 Eric Seidel <eric@webkit.org>
Unreviewed, just reverting commit.
REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
https://bugs.webkit.org/show_bug.cgi?id=38798
- fast/js/global-resolve-through-eval-expected.txt: Added.
- fast/js/global-resolve-through-eval.html: Added.
- fast/js/script-tests/global-resolve-through-eval.js: Added. (accessGlobal): (accessLocal):
- platform/win/Skipped:
2010-05-08 Eric Seidel <eric@webkit.org>
Unreviewed, just reverting commit.
REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
https://bugs.webkit.org/show_bug.cgi?id=38798
Test: fast/js/global-resolve-through-eval.html
- bindings/js/JSCallbackData.h: (WebCore::JSCallbackData::JSCallbackData): (WebCore::JSCallbackData::~JSCallbackData): (WebCore::DeleteCallbackDataTask::create): (WebCore::DeleteCallbackDataTask::performTask): (WebCore::DeleteCallbackDataTask::isCleanupTask): (WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
- bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::JSCustomVoidCallback): (WebCore::JSCustomVoidCallback::~JSCustomVoidCallback):
- bindings/js/JSCustomVoidCallback.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::):
- bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::):
- workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownFinishTask::performTask): (WebCore::WorkerThreadShutdownStartTask::performTask):
2010-05-08 Eric Seidel <eric@webkit.org>
Unreviewed, just reverting commit.
REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
https://bugs.webkit.org/show_bug.cgi?id=38798
- Scripts/webkitpy/common/system/executive.py:
- Scripts/webkitpy/common/system/executive_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/win.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/download_unittest.py:
- 00:08 Changeset [59004] by
-
[Qt] Unreviewed, QtWebKit versioning for the trunk.
The next version is going to be 2.1, based off the trunk.
- Api/qwebkitglobal.h:
05/07/10:
- 23:56 Changeset [59003] by
-
Fix the windows build.
- 23:27 Changeset [59002] by
-
Fixed the inverse function of f(x) = ((x + 0.055) / 1.055) 2.4
https://bugs.webkit.org/show_bug.cgi?id=38735
Reviewed by Dirk Schulze
It is ((x (1 / 2.4)) * 1.055) - 0.055
Chromium pixel tests cover the issue.
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::transformColorSpace):
- 23:24 Changeset [59001] by
-
JavaScriptCore: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>
Reviewed by Maciej Stachowiak
Added cancelCallOnMainThread. callOnMainThread should always now be paired
with cancelCallOnMainThread in situations where the refcon passed to callOnMainThread
may be dealloced before the main thread function can be dispatched.
- wtf/MainThread.cpp:
(WTF::FunctionWithContext::operator == ): Supports the FunctionWithContextFinder predicate functor.
(WTF::FunctionWithContextFinder::FunctionWithContextFinder): Predicate functor for use with Dequeue::findIf
(WTF::FunctionWithContextFinder::operator()):
(WTF::cancelCallOnMainThread):
- wtf/MainThread.h:
WebCore: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>
Reviewed by Eric Carlson
The original functionality of QTMovieWin has been split between QTMovieGWorld,
and a new class: QTMovie. QTMovie contains all the "controller" parts (changing
the rate, seeking, etc) while QTMovieGWorld retains all the drawing code. QTMovieGWorld
now takes a QTMovie, and as such QTMovie is now retainable. QTMovieGWorld registers
itself as a client of QTMovie, so that it can receive load-state notifications,
and thus QTMovie must now support multiple clients. Movie tasking timer support
has been moved into its own class (QTMovieTask) and will be addressed in a future
patch. Most of the functions listed below only changed so much as their class name changed.
- platform/graphics/win/QTMovie.cpp: Copied from WebCore/platform/graphics/win/QTMovieWin.cpp.
(QTMoviePrivate::QTMoviePrivate):
(QTMoviePrivate::~QTMoviePrivate):
(QTMoviePrivate::startTask):
(QTMoviePrivate::endTask):
(QTMoviePrivate::task):
(QTMoviePrivate::createMovieController):
(QTMovie::QTMovie):
(QTMovie::~QTMovie):
(QTMovie::addClient):
(QTMovie::removeClient):
(QTMovie::play):
(QTMovie::pause):
(QTMovie::rate):
(QTMovie::setRate):
(QTMovie::duration):
(QTMovie::currentTime):
(QTMovie::setCurrentTime):
(QTMovie::setVolume):
(QTMovie::setPreservesPitch):
(QTMovie::dataSize):
(QTMovie::maxTimeLoaded):
(QTMovie::loadState):
(QTMovie::getNaturalSize):
(QTMovie::load):
(QTMovie::disableUnsupportedTracks):
(QTMovie::isDisabled):
(QTMovie::setDisabled):
(QTMovie::hasVideo):
(QTMovie::hasAudio):
(QTMovie::hasClosedCaptions):
(QTMovie::setClosedCaptionsVisible):
(QTMovie::countSupportedTypes):
(QTMovie::getSupportedType):
(QTMovie::initializeQuickTime):
(QTMovie::getMovieHandle):
- platform/graphics/win/QTMovie.h: Copied from WebCore/platform/graphics/win/QTMovieWin.h.
- platform/graphics/win/QTMovieGWorld.cpp: Copied from WebCore/platform/graphics/win/QTMovieWin.cpp.
(QTMovieGWorldPrivate::QTMovieGWorldPrivate):
(QTMovieGWorldPrivate::~QTMovieGWorldPrivate):
(QTMovieGWorldPrivate::cacheMovieScale):
(movieDrawingCompleteProc):
(QTMovieGWorldPrivate::registerDrawingCallback):
(QTMovieGWorldPrivate::unregisterDrawingCallback):
(QTMovieGWorldPrivate::drawingComplete):
(QTMovieGWorldPrivate::updateGWorld):
(QTMovieGWorldPrivate::createGWorld):
(QTMovieGWorldPrivate::clearGWorld):
(QTMovieGWorldPrivate::setSize):
(QTMovieGWorldPrivate::updateMovieSize):
(QTMovieGWorldPrivate::deleteGWorld):
(QTMovieGWorldPrivate::movieEnded):
(QTMovieGWorldPrivate::movieLoadStateChanged):
(QTMovieGWorldPrivate::movieTimeChanged):
(QTMovieGWorld::QTMovieGWorld):
(QTMovieGWorld::~QTMovieGWorld):
(QTMovieGWorld::setSize):
(QTMovieGWorld::setVisible):
(QTMovieGWorld::getCurrentFrameInfo):
(QTMovieGWorld::paint):
(QTMovieGWorld::setDisabled):
(QTMovieGWorld::isDisabled):
(QTMovieGWorld::fullscreenWndProc):
(QTMovieGWorld::enterFullscreen):
(QTMovieGWorld::exitFullscreen):
(QTMovieGWorld::setMovie):
(QTMovieGWorld::movie):
- platform/graphics/win/QTMovieGWorld.h: Copied from WebCore/platform/graphics/win/QTMovieWin.h.
- platform/graphics/win/QTMovieTask.cpp: Added.
(QTMovieTask::QTMovieTask):
(QTMovieTask::~QTMovieTask):
(QTMovieTask::sharedTask):
(QTMovieTask::updateTaskTimer):
(QTMovieTask::fireTaskClients):
(QTMovieTask::addTaskClient):
(QTMovieTask::removeTaskClient):
(QTMovieTask::setTaskTimerFuncs):
- platform/graphics/win/QTMovieTask.h: Added.
WebKit/win: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
https://bugs.webkit.org/show_bug.cgi?id=34005
Reviewed by Adele Peterson.
QTMovieWin is now QTMovieGWorld.
- FullscreenVideoController.cpp:
(FullscreenVideoController::movie):
- FullscreenVideoController.h:
- 23:10 Changeset [59000] by
-
2010-05-06 Eric Seidel <eric@webkit.org>
Reviewed by Daniel Bates.
test-webkitpy fails under cygwin
https://bugs.webkit.org/show_bug.cgi?id=38718
- Scripts/webkitpy/common/system/executive.py:
- Add _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE and _KILL_ALL_KILLED_PROCESS_EXIT_CODE to store the expected exit codes of processes killed by kill_process and kill_all. These two constants are only used by the unit tests but are stored in executive.py so they can be right next to the platform ifs.
- Remove unnecessary str() conversion, run_command does that for us.
- Make os.kill retry on cygwin on EAGAIN. It's unclear why CYGWIN throws EAGAIN, but it only does so sometimes. 3 may not be enough retries, but we'll try it to start with.
- Add _windows_image_name to automatically convert "yes" to "yes.exe" for use with taskkill.exe /im. Various callers to kill_all could be updated to remove the .exe, but that can be done in another patch.
- Use taskkill.exe for killall on cygwin.
- Scripts/webkitpy/common/system/executive_unittest.py:
- Use the new *_KILLED_PROCESS_EXIT_CODE constants which are correctly set to 0 on windows/cygwin systems where taskkill.exe is used.
- Test _windows_image_name
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Add FIXME about including mac-snowleopard in baseline_search_path.
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Make default_configuration actually read from the Configuration file.
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
- Test default_configuration
- Scripts/webkitpy/layout_tests/port/win.py:
- Need a basic baseline_search_path if --platform dryrun is to work.
- Scripts/webkitpy/common/system/executive.py:
- 23:03 Changeset [58999] by
-
2010-05-07 Eric Seidel <eric@webkit.org>
Reviewed by Nikolas Zimmermann.
DryrunTest fails on every platform other than mac
https://bugs.webkit.org/show_bug.cgi?id=38796
The test uses the port detection logic to find a suitable
port to use results from. However that detection logic assumes
chromium on linux, which requires a chromium checkout which the
bots don't have. The test is broken and we'll need to fix it.
For now I'm just going to disable the test on all platforms besides mac.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 23:01 Changeset [58998] by
-
2010-05-07 Eric Uhrhane <ericu@chromium.org>
Reviewed by Dmitry Titov.
JSCallbackData is deleted on the Main thread, not the Context thread.
https://bugs.webkit.org/show_bug.cgi?id=38623
No new tests; you'll only see a problem after the worker-access-to-DB
code goes in. Without this fix, the GTK bots assert, but it's
timing-sensitive and not truly platform-specific.
- bindings/js/JSCallbackData.h: (WebCore::JSCallbackData::JSCallbackData): (WebCore::JSCallbackData::~JSCallbackData): Store the allocating thread, then assert that we're on it at deletion.
(WebCore::DeleteCallbackDataTask):
This is the task that can get posted to the context thread for cleanup.
- bindings/js/JSCustomVoidCallback.cpp:
- bindings/js/JSCustomVoidCallback.h: This callback isn't autogenerated, so we have to do the cleanup manually.
- bindings/scripts/CodeGeneratorJS.pm: Add the proper cleanup to all autogenerated callbacks.
- workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownFinishTask::performTask): (WebCore::WorkerThreadShutdownStartTask::performTask): WorkerContext::clearScript can't be called until the posted deletion tasks have completed; move the call from shutdown start to shutdown finish.
- 22:51 Changeset [58997] by
-
2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Attempt to turn Windows bots green again.
Skip two failing tests:
https://bugs.webkit.org/show_bug.cgi?id=38794
fast/css/display-none-inline-style-change-crash.html (fails on Windows Release bot)
https://bugs.webkit.org/show_bug.cgi?id=38795
inspector/timeline-paint.html
- platform/win/Skipped:
- 22:35 Changeset [58996] by
-
2010-05-07 Eric Seidel <eric@webkit.org>
Reviewed by Daniel Bates.
Clean up baseline_search_path to use map to reduce copy/paste code
https://bugs.webkit.org/show_bug.cgi?id=38792
Reading which portnames a port falls back to is easier if
we convert port names to paths with map instead of using copy/paste code.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
- 21:17 Changeset [58995] by
-
2010-05-07 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r58990.
http://trac.webkit.org/changeset/58990
Broke 4 tests on Snow Leopard and Qt.
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- runtime/JSCell.h:
- 21:00 Changeset [58994] by
-
2010-05-07 Eric Seidel <eric@webkit.org>
Reviewed by Daniel Bates.
rollout commands fail when commit is missing bug number
https://bugs.webkit.org/show_bug.cgi?id=38791
- Scripts/webkitpy/tool/commands/download.py:
- _commit_info failed to actually return the CommitInfo in the no-bug-id case.
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Test that the fix worked.
- Scripts/webkitpy/tool/commands/download.py:
- 20:19 Changeset [58993] by
-
Optimize access to the global object from a function that uses eval
https://bugs.webkit.org/show_bug.cgi?id=38644
Reviewed by Gavin Barraclough.
Fix bug where cross scope access to a global var (vs. property) would
be allowed without checking for intervening dynamic scopes.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
LayoutTests:
Add test case to ensure we don't incorrectly allow dynamic scopes
to be skipped when doing direct var access.
- fast/js/global-resolve-through-eval-expected.txt: Added.
- fast/js/global-resolve-through-eval.html: Added.
- fast/js/script-tests/global-resolve-through-eval.js: Added.
(accessGlobal):
(accessLocal):
- 20:16 Changeset [58992] by
-
2010-05-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix JSC binding generation to match webkit style
https://bugs.webkit.org/show_bug.cgi?id=38173
Add spaces around "|" to match webkit style.
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/test/JS/JSTestObj.cpp:
- 19:49 Changeset [58991] by
-
Macro expansion I stab at thee!
32bit test fix
- 19:18 Changeset [58990] by
-
Optimized o[s] where o is a cell and s is a string, removing some old
code that wasn't really tuned for the JIT.
Reviewed by Darin Adler.
SunSpider says 0.8% faster.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/JSCell.h:
- 18:27 Changeset [58989] by
-
Adding the IDL files for the sync DB API and the stubs for the JS and V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994
Reviewed by Brady Eidson.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDatabaseSyncCustom.cpp: Added.
(WebCore::JSDatabaseSync::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabaseSync::transaction):
(WebCore::JSDatabaseSync::readTransaction):
- bindings/js/JSSQLTransactionSyncCustom.cpp: Added.
(WebCore::JSSQLTransactionSync::executeSql):
- bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::openDatabaseSync):
- bindings/v8/custom/V8BindingMacros.h: Added.
- bindings/v8/custom/V8DatabaseSyncCustom.cpp: Added.
(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):
(WebCore::V8DatabaseSync::transactionCallback):
(WebCore::V8DatabaseSync::readTransactionCallback):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp: Added.
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::openDatabaseSyncCallback):
- storage/Database.idl:
- storage/DatabaseCallback.h:
- storage/DatabaseCallback.idl:
- storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):
- storage/DatabaseSync.h:
- storage/DatabaseSync.idl: Added.
- storage/SQLError.idl:
- storage/SQLResultSet.idl:
- storage/SQLResultSetRowList.idl:
- storage/SQLTransaction.idl:
- storage/SQLTransactionSync.idl: Added.
- storage/SQLTransactionSyncCallback.h:
- storage/SQLTransactionSyncCallback.idl: Added.
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::openDatabaseSync):
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
- 18:05 Changeset [58988] by
-
Windows build fix
- 17:51 Changeset [58987] by
-
Windows build fix.
- 17:05 Changeset [58986] by
-
2010-05-07 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Optimize access to the global object from a function that uses eval
https://bugs.webkit.org/show_bug.cgi?id=38644
Add op_resolve_global_dynamic, a variant of op_resolve_global that
checks each node in the scope chain for dynamically inserted properties
and falls back to the normal resolve logic in that case.
- JavaScriptCore.exp:
- bytecode/CodeBlock.cpp: (JSC::isGlobalResolve): (JSC::CodeBlock::printStructures): (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::findScopedProperty):
Now take an additional reference parameter to used to indicate that
there were nodes that may gain dynamic properties
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveWithBase):
deal with additional argument to findScopedProperty
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp: (JSC::FunctionCallResolveNode::emitBytecode): (JSC::PostfixResolveNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode): (JSC::ReadModifyResolveNode::emitBytecode): (JSC::AssignResolveNode::emitBytecode):
These functions use findScopedProperty directly in order to
optimise lookup. They cannot trivially handle any degree of
dynamism in the lookup so we just give up in such case.
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::execute): (JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_resolve_global_dynamic): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global_dynamic):
Happily resolve_global_dynamic can share the slow case!
- jit/JITStubs.h: (JSC::):
- runtime/JSActivation.cpp: (JSC::JSActivation::isDynamicScope):
- runtime/JSActivation.h:
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::isDynamicScope):
- runtime/JSGlobalObject.h:
- runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::isDynamicScope):
- runtime/JSStaticScopeObject.h:
- runtime/JSVariableObject.h:
- 16:53 Changeset [58985] by
-
2010-05-07 Darin Fisher <darin@chromium.org>
Fix build bustage. Update to Chromium code that avoids a bad
dependency from net/ on chrome/.
- DEPS:
- 16:51 Changeset [58984] by
-
2010-05-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Alexey Proskuryakov.
Rewrite test to fail faster if the inner frame doesn't load at all
for some reason (previous version would raise a TypeError before
the timeout was set).
- http/tests/security/sandbox-inherit-to-initial-document-2.html:
- platform/chromium/test_expectations.txt:
- 16:35 Changeset [58983] by
-
Fix for <rdar://problem/7956972> REGRESSION: Can't focus and type
in GMail due to bad repainting
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=38782
Reviewed by Simon Fraser.
This patch reverts back to pre-r58797 behavior when
shouldPropagateCompositingToIFrameParent() is false.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintingGoesToWindow):
- 16:23 Changeset [58982] by
-
<rdar://problem/7947356>
QT Plug-in in hardware-accelerated WebKit is missing the controller
Reviewed by Sam Weinig and Simon Fraser.
Replace the useSoftwareRenderer boolean with an enum that lets the plug-in host opt into using a layer
backed NSView instead of inserting the layer into the WebCore layer hierarchy.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCInstantiatePluginReply):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
(WebKit::NetscapePluginInstanceProxy::rendererType):
(WebKit::NetscapePluginInstanceProxy::setRendererType):
(WebKit::NetscapePluginInstanceProxy::InstantiatePluginReply::InstantiatePluginReply):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Replace the useSoftwareRenderer boolean everywhere with the RendererType enum.
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
Only go into full compositing mode when the renderer type returned is UseAcceleratedCompositing.
Otherwise, use a layer backed NSView.
- Plugins/Hosted/WebKitPluginHostTypes.h:
Add a RendererType enum.
- 16:15 Changeset [58981] by
-
2010-05-07 Darin Fisher <darin@chromium.org>
Fix build bustage. Update to Chromium code that no longer uses
deprecated methods.
- DEPS:
- 16:10 Changeset [58980] by
-
Pull more AudioBasicProcessorNode::process() code inside the lock
- 15:55 Changeset [58979] by
-
Fix AudioBasicProcessorNode::inputHasBeenConnected() to allow dynamic re-initialization.
- this requires a lock around process()
- also fix uninitialize() method
- 15:55 Changeset [58978] by
-
Initial rough implementation for buffer source gain - later to be more optimized
- 15:55 Changeset [58977] by
-
More descriptive debugging message for resampler channel mismatch
- 15:55 Changeset [58976] by
-
Add temporary mono and stereo processing busses for use by any processing node.
- also change local variables from PassRefPtr to RefPtr
- 15:50 Changeset [58975] by
-
2010-05-07 Darin Fisher <darin@chromium.org>
Fix build bustage: toElement<T> should be to<T>.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
- 15:18 Changeset [58974] by
-
Fixed Sputnik failure seen on buildbot.
Reviewed by Gavin Barraclough.
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString): Cast to unsigned before checking magnitude,
to efficiently exclude negative numbers, which require two characters
instead of one.
- 14:44 Changeset [58973] by
-
2010-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r58963.
http://trac.webkit.org/changeset/58963
https://bugs.webkit.org/show_bug.cgi?id=38773
Broke Chromium layout tests. (Requested by dcheng on #webkit).
- platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):
- 14:18 Changeset [58972] by
-
2010-05-07 John Gregg <johnnyg@google.com>
Unreviewed [re-]baseline of chromium tests.
- platform/chromium-linux/fast/frames/take-focus-from-iframe-expected.checksum: Added.
- platform/chromium-linux/fast/frames/take-focus-from-iframe-expected.png: Added.
- platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.checksum: Added.
- platform/chromium-win/fast/frames/take-focus-from-iframe-expected.checksum: Added.
- platform/chromium-win/fast/frames/take-focus-from-iframe-expected.png: Added.
- platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt: Added.
- platform/chromium-win/svg/hixie/error/017-expected.txt:
- 13:28 Changeset [58971] by
-
2010-05-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
Adjust the position of the comment on the WOFF test and
link to the bug report. This should fix a spurious error
while running layout tests.
- platform/gtk/Skipped:
- 13:13 Changeset [58970] by
-
Slightly more effective way to guarantee a compile-time constant, at
least on gcc.
Reviewed by Alexey Proskuryakov.
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString): Use pointer notation instead of array
notation, so the compiler treats the string and its contents as constant.
- 13:13 Changeset [58969] by
-
2010-05-07 Dirk Schulze <krit@webkit.org>
Unreviewed fix of Windows test.
Windows need an platform dependent DRT result for clip-path-referencing-use2.svg,
Win doesn't have console output during DRT.
- platform/win/svg/custom/clip-path-referencing-use2-expected.txt: Added.
- 13:03 Changeset [58968] by
-
2010-05-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
https://bugs.webkit.org/show_bug.cgi?id=38769
ClipboardGtk should write the URL label in the text portion of the DataObject
No tests as this code path is currently unused in the GTK+ port.
- platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::writeURL): Write the label to the text portion of the DataObject, instead of the URL.
- 12:57 Changeset [58967] by
-
2010-05-07 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] clear out more deprecated methods that are no longer used
https://bugs.webkit.org/show_bug.cgi?id=38702
- public/WebFrame.h:
- public/WebNode.h:
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
- src/WebNode.cpp:
- 12:56 Changeset [58966] by
-
2010-05-07 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
[WTFURL] Add core URL parser
https://bugs.webkit.org/show_bug.cgi?id=38572
This patch adds the core of the URL parser. The URL parser uses a
templated notion of a code unit to support different string types.
Later we'll add some non-templated APIs with concrete types that
clients can use more conveniently.
The URLParser has a couple calls to ASSERT(), which I've commented out
for now. I'm not 100% sure how to handle the dependency issues there
yet, so I've punted on the issue for now.
Also, there are a number of methods that are declared public in this
patch that are only used by the canonicalizer. My plan is to make
those private or protected and make the canonicalizer a friend of the
parser. The details will be in a later patch.
- wtf/url/src/URLComponent.h: (WTF::URLComponent::fromRange): (WTF::URLComponent::isNonEmpty): (WTF::URLComponent::isEmptyOrInvalid):
- wtf/url/src/URLParser.h: Added. (WTF::URLParser::): (WTF::URLParser::isPossibleAuthorityTerminator): (WTF::URLParser::parseAuthority): (WTF::URLParser::extractScheme): (WTF::URLParser::parseAfterScheme): (WTF::URLParser::parseStandardURL): (WTF::URLParser::parsePath): (WTF::URLParser::parsePathURL): (WTF::URLParser::parseMailtoURL): (WTF::URLParser::parsePort): (WTF::URLParser::extractFileName): (WTF::URLParser::extractQueryKeyValue): (WTF::URLParser::isURLSlash): (WTF::URLParser::shouldTrimFromURL): (WTF::URLParser::trimURL): (WTF::URLParser::consecutiveSlashes): (WTF::URLParser::isPortDigit): (WTF::URLParser::nextAuthorityTerminator): (WTF::URLParser::parseUserInfo): (WTF::URLParser::parseServerInfo):
- 12:35 Changeset [58965] by
-
2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
RenderSVGResourceClipper assigns a temporary mutated RenderStyle but does not correctly preserve the old style
https://bugs.webkit.org/show_bug.cgi?id=38767
Fix small logic error leading to a problem in RenderSVGResourceClipper. It assigns a new temporary RenderStyle
to the target object, but fails to reset it correctly to the old style. Fixes all svg/clip-path errors on the windows bots.
- rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::createClipData):
2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
RenderSVGResourceClipper assigns a temporary mutated RenderStyle but does not correctly preserve the old style
https://bugs.webkit.org/show_bug.cgi?id=38767
Update baseline after fixing a logic error in RenderSVGResourceClipper.
- platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt:
- platform/mac/svg/clip-path/clip-path-childs-clipped-expected.txt:
- platform/mac/svg/clip-path/clip-path-clipped-expected.txt:
- platform/mac/svg/clip-path/clip-path-evenodd-expected.txt:
- platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
- platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
- platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt:
- 12:30 Changeset [58964] by
-
Added a fast path for number-to-character conversion via
Number.prototype.toString base 36.
Reviewed by Oliver Hunt.
0.7% speedup on SunSpider.
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString): Made radix interpretation a little more
efficient by keeping it in int space. Turned "const char" into
"static const char" just in case. Added a fast path for base 36
conversion of something that will turn into a character.
- 12:23 Changeset [58963] by
-
Add a few more files with Windows linefeeds to the .gitattributes file.
Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2010-05-07
- .gitattributes:
- 11:46 Changeset [58962] by
-
2010-05-07 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Fix debug-only render tree output to show object addresses in hex.
- rendering/RenderTreeAsText.cpp: (WebCore::writeRenderObject): (WebCore::write):
- 11:40 Changeset [58961] by
-
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly
Test: fast/frames/take-focus-from-iframe.html
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas of focused frame get out of sync temporarily.
- 11:24 Changeset [58960] by
-
2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
svg/custom/use-instanceRoot-as-event-target.xhtml crashes randomly
https://bugs.webkit.org/show_bug.cgi?id=37798
When creating JSEventListeners through attributes (onclick, etc..) or add/removeEventListener
calls on a SVGElementInstance, do NOT pass the element instance itself as JS wrapper object
but the correspondingElement(). SVGElementInstance redirects all event listener registrations
to the correspondingElement(), as they share an event listener list, per SVG spec. The old
code was very dangerous, leading to random assertions, when garbage collection teared down
the JSSVGElementInstance and event listeners fired, whose listeners were registered with
it, but residing in the correspondingElement() event listener list.
Removes the need for CustomToJS code for JSSVGElementInstance, which was wrong anyways. We hoped
to keep the event listeers alive by just creating a js wrapper of the correspondingElement(), that
could only work as long as garbage collection didn't tear it down, just luck. Also remove the
CustomPushEventHandlerScope marker, as it is only used for JSLazyEventListeners and only works
for JSNode derived objects, it was a no-op for SVGElementInstance, thus removed it.
Should fix all random crashes/assertions seen with svg/custom/use-instanceRoot-as-event-target.xhtml
See bug report for a detailed crash analysis.
- bindings/js/JSSVGElementInstanceCustom.cpp: Remove custom toJS()/pushEventHandlerScope() handling, not necessary anymore. (WebCore::JSSVGElementInstance::markChildren):
- bindings/scripts/CodeGeneratorJS.pm: For JSSVGElementInstance pass the correspondingElement() as JS wrapper object, not itself.
- svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Be sure to trigger a style update here, so dirty shadow trees for <use> get rebuild. Otherwhise DOM may be out-of-sync. (WebCore::SVGElementInstance::eventTargetData): Add ASSERT_NOT_REACHED(), all event listener calls are forwarded to the correspondingElement(). (WebCore::SVGElementInstance::ensureEventTargetData): Ditto.
- svg/SVGElementInstance.idl: Remove CustomToJS, CustomPushEventHandlerScope markers.
2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
svg/custom/use-instanceRoot-as-event-target.xhtml crashes randomly
https://bugs.webkit.org/show_bug.cgi?id=37798
Make use-instanceRoot-as-event-target.xhtml behave more correctly. Due a copy & paste problem test #7 was not executed. Fixed.
Make destruction more reliable, by using the standard js-test-post.js injection through <script> before calling notifyDone(), and "TEST COMPLETE" magically appears.
- platform/mac/svg/hixie/error/017-expected.txt: Update result, now that invalidateAllInstancesOfElement(), correctly triggers <use> shadow tree rebuilds.
- svg/custom/use-instanceRoot-as-event-target-expected.txt: Update result, was missing a "TEST COMPLETE" marker, and Test #7 was not executed before.
- svg/custom/use-instanceRoot-as-event-target.xhtml: Fix typo, test #7 is now executed, it also had a bug which has been corrected.
- 11:20 Changeset [58959] by
-
2010-05-07 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
[WTFURL] Add a malloc-backed URLBuffer
https://bugs.webkit.org/show_bug.cgi?id=38694
This patch adds a URLBuffer that uses new/delete to manage the backing
store for the buffer.
- wtf/url/src/RawURLBuffer.h: Added. (WTF::RawURLBuffer::RawURLBuffer): (WTF::RawURLBuffer::~RawURLBuffer): (WTF::RawURLBuffer::resize):
- 11:05 Changeset [58958] by
-
2010-05-07 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by Dimitri Glazkov.
[chromium]: Fixing Find in page crash on sites.google.com
https://bugs.webkit.org/show_bug.cgi?id=38591
setMarkerActive should not try to set a collapsed marker as
active. This can happen when you Edit a Sites page after doing
a Find operation and then you press FindNext.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkerActive):
- 10:52 Changeset [58957] by
-
2010-05-06 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
WebCore::WebGLUnsignedIntArrayInternal::getCallback ReadAV@Arbitrary (deef89ee3d0345edebeaf13cf974c47c)
https://bugs.webkit.org/show_bug.cgi?id=38039
Web IDL now allows indexed getters and setters to be unnamed. Per
discussion in WebGL working group and recent update to spec,
removed the buggy get() and single-element set() methods from the
JavaScript bindings to the WebGL array types. Refactored set()
implementation in JSC bindings to share more code and modified V8
binding to look more like it. Added unit tests for indexed getter
with out-of-range indices and verifying removal of get and
single-element set methods. Updated existing WebGL array tests.
Tests: fast/canvas/webgl/array-get-and-set-method-removal.html
fast/canvas/webgl/array-get-out-of-bounds.html
- bindings/js/JSWebGLArrayHelper.h: (WebCore::setWebGLArrayHelper):
- bindings/js/JSWebGLByteArrayCustom.cpp: (WebCore::JSWebGLByteArray::set):
- bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::set):
- bindings/js/JSWebGLIntArrayCustom.cpp: (WebCore::JSWebGLIntArray::set):
- bindings/js/JSWebGLShortArrayCustom.cpp: (WebCore::JSWebGLShortArray::set):
- bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: (WebCore::JSWebGLUnsignedByteArray::set):
- bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::set):
- bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: (WebCore::JSWebGLUnsignedShortArray::set):
- bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::setWebGLArrayHelper):
- bindings/v8/custom/V8WebGLByteArrayCustom.cpp: (WebCore::V8WebGLByteArray::setCallback):
- bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: (WebCore::V8WebGLFloatArray::setCallback):
- bindings/v8/custom/V8WebGLIntArrayCustom.cpp: (WebCore::V8WebGLIntArray::setCallback):
- bindings/v8/custom/V8WebGLShortArrayCustom.cpp: (WebCore::V8WebGLShortArray::setCallback):
- bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: (WebCore::V8WebGLUnsignedByteArray::setCallback):
- bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: (WebCore::V8WebGLUnsignedIntArray::setCallback):
- bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: (WebCore::V8WebGLUnsignedShortArray::setCallback):
- html/canvas/WebGLByteArray.h:
- html/canvas/WebGLByteArray.idl:
- html/canvas/WebGLFloatArray.h:
- html/canvas/WebGLFloatArray.idl:
- html/canvas/WebGLIntArray.h:
- html/canvas/WebGLIntArray.idl:
- html/canvas/WebGLShortArray.h:
- html/canvas/WebGLShortArray.idl:
- html/canvas/WebGLUnsignedByteArray.h:
- html/canvas/WebGLUnsignedByteArray.idl:
- html/canvas/WebGLUnsignedIntArray.h:
- html/canvas/WebGLUnsignedIntArray.idl:
- html/canvas/WebGLUnsignedShortArray.h:
- html/canvas/WebGLUnsignedShortArray.idl:
2010-05-06 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
WebCore::WebGLUnsignedIntArrayInternal::getCallback ReadAV@Arbitrary (deef89ee3d0345edebeaf13cf974c47c)
https://bugs.webkit.org/show_bug.cgi?id=38039
Web IDL now allows indexed getters and setters to be unnamed. Per
discussion in WebGL working group and recent update to spec,
removed the buggy get() and single-element set() methods from the
JavaScript bindings to the WebGL array types. Refactored set()
implementation in JSC bindings to share more code and modified V8
binding to look more like it. Added unit tests for indexed getter
with out-of-range indices and verifying removal of get and
single-element set methods. Updated existing WebGL array tests.
- fast/canvas/webgl/array-get-and-set-method-removal-expected.txt: Added.
- fast/canvas/webgl/array-get-and-set-method-removal.html: Added.
- fast/canvas/webgl/array-get-out-of-bounds-expected.txt: Added.
- fast/canvas/webgl/array-get-out-of-bounds.html: Added.
- fast/canvas/webgl/array-setters-expected.txt:
- fast/canvas/webgl/array-setters.html:
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
- fast/canvas/webgl/bug-32456-expected.txt:
- fast/canvas/webgl/bug-32456.html:
- 10:32 Changeset [58956] by
-
2010-05-07 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium dev tools tests fix.
Add a more strict check prior to accessing constructor property in
Web Inspector frontend.
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 10:30 Changeset [58955] by
-
2010-05-07 John Gregg <johnnyg@google.com>
Unreviewed, rebaseline for chromium.
- platform/chromium-mac/fast/layers/video-layer-expected.checksum:
- platform/chromium-mac/fast/layers/video-layer-expected.png:
- 10:03 Changeset [58954] by
-
2010-05-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: On Linux/Windows panel history is
traversed while iterating over words in text prompt.
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt):
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
- 09:59 Changeset [58953] by
-
2010-05-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: come up with InjectedScript._className that works for both JSC and V8.
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
- 09:32 Changeset [58952] by
-
2010-05-07 John Gregg <johnnyg@google.com>
Unreviewed, rebaseline for chromium.
- platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
- platform/chromium-mac/media/audio-controls-rendering-expected.png:
- platform/chromium-mac/media/controls-after-reload-expected.checksum:
- platform/chromium-mac/media/controls-after-reload-expected.png:
- platform/chromium-mac/media/controls-strict-expected.checksum:
- platform/chromium-mac/media/controls-strict-expected.png:
- platform/chromium-mac/media/video-controls-rendering-expected.checksum:
- platform/chromium-mac/media/video-controls-rendering-expected.png:
- platform/chromium-mac/media/video-display-toggle-expected.checksum:
- platform/chromium-mac/media/video-display-toggle-expected.png:
- platform/chromium-mac/media/video-empty-source-expected.checksum:
- platform/chromium-mac/media/video-empty-source-expected.png:
- platform/chromium-mac/media/video-no-audio-expected.checksum:
- platform/chromium-mac/media/video-no-audio-expected.png:
- platform/chromium-mac/media/video-volume-slider-expected.checksum:
- platform/chromium-mac/media/video-volume-slider-expected.png:
- 08:54 Changeset [58951] by
-
Refactored VCSUtils.pm's parse-related methods to leave inapplicable
hash values unset instead of setting them to "undef".
Reviewed by Daniel Bates.
https://bugs.webkit.org/show_bug.cgi?id=38724
Preferring "not set" over "undef" keeps the unit tests smaller and
easier to maintain. Otherwise, we would have to update every unit
test case each time we add support for a new key-value pair --
instead of just the relevant ones.
- Scripts/VCSUtils.pm:
- In parseGitDiffHeader(), adjusted the handling of these key-values: executableBitDelta and isBinary.
- In parseSvnDiffHeader(), adjusted the handling of these key-values: copiedFromPath, isBinary, and sourceRevision.
- In parseDiffHeader(), adjusted the handling of these key-values: isGit and isSvn.
- In parseDiff(), adjusted the handling of these key-values: isBinary, isGit, isSvn, and sourceRevision.
- Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Updated the unit tests as necessary.
- Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
- Updated the unit tests as necessary.
- Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
- Updated the unit tests as necessary.
- Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
- Updated the unit tests as necessary.
- Scripts/VCSUtils.pm:
- 08:42 Changeset [58950] by
-
2010-05-07 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Adam Barth.
document.write is not synchronous after page load
https://bugs.webkit.org/show_bug.cgi?id=38146
If there are no pending scripts, a document.write call should be
synchronous. This matches other browsers and the HTML5 spec. Forcing
the tokenizer to be synchronous in Document::write does not affect
external scripts written by the write call. This should only change
behavior of document.write after the page is done loading.
Difficult to test reliably due to HTMLTokenizing relying on processing time.
I made a manual test because the test requires processing very large strings
synchronously and therefore can take some time.
Test: WebCore/manual-tests/dom/document-write-synchronous-after-page-load.html
- dom/Document.cpp: (WebCore::SynchronousHTMLTokenizerGuard::SynchronousHTMLTokenizerGuard): if the provided tokenizer is an HTMLTokenizer make it synchronous (WebCore::SynchronousHTMLTokenizerGuard::~SynchronousHTMLTokenizerGuard): if the provided tokenizer was an HTMLTokenizer return its synchronous state (WebCore::Document::write): temporarily set the tokenizer to synchronous during document.write
- dom/Tokenizer.h: (WebCore::Tokenizer::asHTMLTokenizer): default implementation returns 0, to be overridden by HTMLTokenizer
- html/HTMLTokenizer.h: allow access to to the force synchronous state (WebCore::HTMLTokenizer::forceSynchronous): accessor (WebCore::HTMLTokenizer::asHTMLTokenizer): override the default to return itself
- manual-tests/dom/document-write-synchronous-after-page-load.html: Added.
- 08:15 QtWebKitJournal edited by
- (diff)
- 08:13 Changeset [58949] by
-
[Qt] Fix rendering of -webkit-user-select: none
Reviewed by Simon Hausmann.
-webkit-user-select: none is implemented by filling
the area with an invalid default-constructed Color.
In most ports passing an invalid color down to the
graphics backend seems to produce transparent fills.
In Qt the behavior of painting with an invalid QColor
is undefined, and in practice it results in painting
black opaque areas.
One way to fix this would be to use Qt::transparent
when converting an undefined Color to a QColor, but
Qt does not have short circuits for fully transparent
painting, and we actually end up in slow code paths
due to the transparency. So, we're better of doing the
short circuit in WebKit.
https://bugs.webkit.org/show_bug.cgi?id=38523
- platform/graphics/qt/GraphicsContextQt.cpp:
- 08:04 Changeset [58948] by
-
2010-05-07 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler.
Potential crash in EventHandler::handleTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=38646
Fix a ref counting bug that can cause a crash if the m_originatingouchPointTargets
hashmap holds the last ref to an EventTarget when the user lifts their finger.
This is very hard to reproduce in a consistent way and clearly a
simple logic error in the code, therefore no new tests.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Don't let the RefPtr we get back from
the hasmap go out of scope so soon as it could delete the wrapped ptr if the
hashmap held the last ref (and we use the raw ptr that the RefPtr
wraps later in the WebCore::Touch constructor).
- 08:03 Changeset [58947] by
-
Add a few more files with Windows linefeeds to the .gitattributes file.
- .gitattributes:
- 07:08 Changeset [58946] by
-
2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Kenneth Rohde Christiansen.
[GTK] Fails to build on GTK+ < 2.14
https://bugs.webkit.org/show_bug.cgi?id=38746
Build fix only. Do basically the same as gtk_adjustment_configure
would do if we are bellow GTK+ 2.14.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::AdjustmentConfigure):
- 06:43 Changeset [58945] by
-
2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Crash with MgOpenModerna font, with non-UTF-8 character
https://bugs.webkit.org/show_bug.cgi?id=37795
NULL-check the font platform data, for now, to avoid the crash.
Could not yet figure out a way to get a test written that does not
involve adding the font to the tree, but there are doubts about
licensing.
- platform/graphics/cairo/FontCacheCairo.cpp: (WebCore::FontCache::getFontDataForCharacters):
- 05:33 Changeset [58944] by
-
2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Turn Tiger core builder green again, filed https://bugs.webkit.org/show_bug.cgi?id=38743 for failing webarchive/test-link-rel-icon.html.
- platform/mac-tiger/Skipped:
- 05:31 Changeset [58943] by
-
2010-05-07 MORITA Hajime <morrita@google.com>
Reviewed by Eric Seidel.
[Chromium] RenderThemeChromiumMac.mm should share the code with RenderThemeMac.mm
https://bugs.webkit.org/show_bug.cgi?id=37204
Made RenderThemeChromiumMac subclass of RenderThemeMac, instead of RenderTheme.
Added some method to RenderThemeMac for overriding on RenderThemeChromiumMac.
No new tests; Should have no behavioural change.
- WebCore.gyp/WebCore.gyp:
- rendering/RenderThemeChromiumMac.h:
- rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor): (WebCore::RenderThemeChromiumMac::documentViewFor): (WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
- rendering/RenderThemeMac.h: (WebCore::RenderThemeMac::updateActiveState): Added for overriding
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::usesTestModeFocusRingColor): Added for overriding (WebCore::RenderThemeMac::documentViewFor): Added for overriding (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::setPopupButtonCellState): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::setSearchCellState): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): (WebCore::RenderThemeMac::adjustSliderThumbSize): (WebCore::RenderThemeMac::adjustMediaSliderThumbSize): Added for overriding (WebCore::RenderThemeMac::extraMediaControlsStyleSheet):
- 04:53 Changeset [58942] by
-
Symbian build fix.
[Qt] Updated the def file with absent exports.
- symbian/eabi/QtWebKitu.def:
- 00:32 Changeset [58941] by
-
2010-05-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
JavaScriptCore/wtf/RandomNumber.h should provide using WTF::*
https://bugs.webkit.org/show_bug.cgi?id=38719
- wtf/RandomNumber.h: Add using directives.
2010-05-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Alexey Proskuryakov.
JavaScriptCore/wtf/RandomNumber.h should provide using WTF::*
https://bugs.webkit.org/show_bug.cgi?id=38719
- platform/graphics/wince/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
- Remove WTF
- prefix from randomNumber()
- platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString): Ditto.
05/06/10:
- 23:42 Changeset [58940] by
-
Exclude leaks due to <rdar://problem/7815391> from the output.
Rubber-stamped by Dan Bernstein.
- Scripts/old-run-webkit-tests:
- 23:22 Changeset [58939] by
-
2010-05-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable YARR_JIT for X86 Mac for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=38668
- wtf/Platform.h:
- 23:18 Changeset [58938] by
-
Skip compositing/layer-creation/overflow-scroll-overlap.html from r58936, since hardware
compositing is disabled on the Leopard test bot.
- platform/mac-leopard/Skipped:
- 22:12 Changeset [58937] by
-
2010-04-27 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] clicking a scrollbar in an iframe shouldn't lose the selection
https://bugs.webkit.org/show_bug.cgi?id=38189
- fast/events/mousedown-in-subframe-scrollbar-expected.txt: Added.
- fast/events/mousedown-in-subframe-scrollbar.html: Added.
- fast/events/resources/mousedown-in-subframe-scrollbar.html: Added.
- platform/win/Skipped:
2010-04-27 Tony Chang <tony@chromium.org>
Reviewed by Eric Seidel.
[chromium] clicking a scrollbar in an iframe shouldn't lose the selection
https://bugs.webkit.org/show_bug.cgi?id=38189
Test: fast/events/mousedown-in-subframe-scrollbar.html
- page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): If clicking on
a scrollbar, pass the event directly to the scrollbar. This matches
mac which passes the event to the NSScroller.
- 22:04 Changeset [58936] by
-
2010-05-06 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Compositing layers that are clipped out by an overflow:scroll parent fail to get created on reveal
https://bugs.webkit.org/show_bug.cgi?id=38712
When compositing layer creation is testing layer overlap, we need to re-run the
algorithm when an overflow:scroll element scrolls, to create new layers for revealed
elements.
Test: compositing/layer-creation/overflow-scroll-overlap.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): First, move the compositing updates until after the call to updateWidgetPositions(), so that this order is similar to what we done when a FrameView scrolls. This change has no known side effects. Second, if compositingConsultsOverlap() is true, we need to actually do a compositing layer update to compute whether revealed/hidden layers should be created/destroyed.
- 21:58 Changeset [58935] by
-
Bug 38714 - Add result caching for Math.sin
Reviewed by Geoff Garen.
Math.sin is frequently called with the same operand, caching the result should
improve performance. CachedTranscendentalFunction adds a generic mechanism to
cache results for pure functions with the signature "double func(double)", and
where NaN maps to NaN.
CachedTranscendentalFunction uses a very simple hash function designed to be
fast to execute since we cannot cache the result, and trivial to JIT generate,
should we wish to do so.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/CachedTranscendentalFunction.h: Added.
(JSC::CachedTranscendentalFunction::CachedTranscendentalFunction):
(JSC::CachedTranscendentalFunction::~CachedTranscendentalFunction):
(JSC::CachedTranscendentalFunction::operator()):
(JSC::CachedTranscendentalFunction::initialize):
(JSC::CachedTranscendentalFunction::hash):
- runtime/JSGlobalData.h:
- runtime/MathObject.cpp:
(JSC::mathProtoFuncSin):
- wtf/Platform.h:
- 21:51 Changeset [58934] by
-
2010-05-06 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r58933.
http://trac.webkit.org/changeset/58933
https://bugs.webkit.org/show_bug.cgi?id=38717
"Broke all websocket tests on Tiger" (Requested by eseidel on
#webkit).
- Scripts/new-run-webkit-websocketserver:
- Scripts/old-run-webkit-tests:
- Scripts/run-webkit-websocketserver:
- Scripts/webkitpy/layout_tests/port/websocket_server.py:
- Scripts/webkitpy/thirdparty/init.py:
- Scripts/webkitpy/thirdparty/pywebsocket/COPYING: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/MANIFEST.in: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/README: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/example/echo_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/init.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/dispatch.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/handshake.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/msgutil.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/setup.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/config.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/mock.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/run_all.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_dispatch.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_handshake.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_memorizingfile.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_mock.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_msgutil.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
- Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added.
- 20:56 Changeset [58933] by
-
2010-05-06 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
WebSocket: pywebsocket 0.5
https://bugs.webkit.org/show_bug.cgi?id=38034
Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.
- Scripts/new-run-webkit-websocketserver: Add --output-dir option.
- Scripts/old-run-webkit-tests: Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
- Scripts/run-webkit-websocketserver: Ditto.
- Scripts/webkitpy/layout_tests/port/websocket_server.py: Use autoinstalled pywebsocket.
- Scripts/webkitpy/thirdparty/init.py: Autoinstall pywebsocket
- Scripts/webkitpy/thirdparty/pywebsocket: Removed.
- 20:13 Changeset [58932] by
-
svn-apply now understands the Git diff "copy from" syntax when the
similarity index is 100%.
Reviewed by Daniel Bates.
https://bugs.webkit.org/show_bug.cgi?id=38628
- Scripts/VCSUtils.pm:
- Adjusted parseGitDiffHeader() to parse the "copy from" and "similarity index" lines.
- Scripts/svn-unapply:
- Adjusted the patch() subroutine so that copies are recognized as file additions.
- Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
- Added unit tests for the cases of a copy with similarity index 100% and less than 100%.
- Scripts/VCSUtils.pm:
- 19:58 Changeset [58931] by
-
Versioning.
- 19:58 Changeset [58930] by
-
New tag.
- 19:54 Changeset [58929] by
-
2010-05-06 Chris Jerdonek <cjerdonek@webkit.org>
Reviewed by Daniel Bates.
Removed the need for svn-apply and -unapply to re-parse whether
a diff is binary or not.
- Scripts/VCSUtils.pm:
- Adjusted parseGitDiffHeader() to set the isBinary key.
- Adjusted parseSvnDiffHeader() to set the isBinary key.
- Adjusted parseDiffHeader() to set the isBinary key.
- Changed the scmFormat key set by parseDiffHeader() to isGit and isSvn keys.
- Adjusted parseDiff() to set the isBinary, isGit, and isSvn keys.
- Scripts/svn-apply:
- Updated the patch() method to use the isBinary, isGit, and isSvn keys.
- Scripts/svn-unapply:
- Updated the patch() method to use the isBinary and isSvn keys.
- Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Updated the unit tests as necessary.
- Added a test case to test that the isBinary key is getting set properly.
- Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
- Updated the unit tests as necessary.
- Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
- Updated the unit tests as necessary.
- Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
- Updated the unit tests as necessary.
- Scripts/VCSUtils.pm:
- 19:37 Changeset [58928] by
-
2010-05-06 Dirk Pranke <dpranke@chromium.org>
Unreviewed, rebaseline and expectation changes from WK roll from a
few days ago.
- platform/chromium-linux/http/tests/loading/bad-scheme-subframe-expected.txt: Copied from LayoutTests/platform/chromium-mac/http/tests/loading/bad-scheme-subframe-expected.txt.
- platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
- platform/chromium-linux/svg/text/kerning-expected.checksum:
- platform/chromium-linux/svg/text/kerning-expected.png:
- platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/editing/selection/caret-rtl-2-actual.checksum.
- platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/selection/caret-rtl-2-actual.png.
- platform/chromium-mac/svg/text/kerning-expected.checksum: Added.
- platform/chromium/test_expectations.txt:
- 18:56 Changeset [58927] by
-
2010-05-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add support for resources on Mac
https://bugs.webkit.org/show_bug.cgi?id=38637
- DEPS: Check out tools/data_pack.
2010-05-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Add support for resources on Mac
https://bugs.webkit.org/show_bug.cgi?id=38637
Repack webkit_chromium_resources.pak, webkit_strings_en-US.pak,
and webkit_resources.pak, and put them as Mac bundle resource.
The 'actions' section is almost same as a part of test_shell.gypi.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 18:29 Changeset [58926] by
-
2010-05-06 Dirk Pranke <dpranke@chromium.org>
Unreviewed, rebaseline a chromium test.
Need a linux baseline for fast/notifications/notifications-replace-expected.txt to override the windows version.
- platform/chromium-linux/fast/notifications/notifications-replace-expected.txt: Added.
- 17:47 Changeset [58925] by
-
Not reviewed, build fix.
Try again - with quotes this time. *facepalm*
- dom/Notation.cpp:
- 17:39 Changeset [58924] by
-
Not reviewed, build fix.
Speculative fix for Qt and Gtk.
- dom/Notation.cpp:
- 17:34 BuildingQtOnWindows edited by
- few words on how to generate MSVC project files (diff)
- 17:25 Changeset [58923] by
-
Not reviewed, build fix.
Fix an assert that I failed to update in my earlier change.
- dom/CharacterData.h:
(WebCore::CharacterData::CharacterData):
- 17:03 Changeset [58922] by
-
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=38697
REGRESSION (r58299): Replying on reddit.com no longer works
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Don't recognize :first, :left and :right. The aren't allowed in all contexts, and properly implementing them is out of scope for this regression fix.
- 17:01 Changeset [58921] by
-
Improve code generator scripts to support converting ScriptString.
https://bugs.webkit.org/show_bug.cgi?id=38699
Reviewed by Adam Barth.
Change both JSC and V8 generators to introduce "ConvertScriptString"
attribute to allow converting from ScriptString. Also updated the
bindings test result.
These changes are necessary in order to avoid adding custom binding codes
when we add the FileReader interface.
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_script_string_attr):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::):
(WebCore::jsTestObjScriptStringAttr):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj scriptStringAttr]):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::scriptStringAttrAttrGetter):
(WebCore::):
- 16:45 Changeset [58920] by
-
[Qt] Unreviewed buildfix after r58917.
- DumpRenderTree/qt/LayoutTestControllerQt.h: Missing function declaration added.
- 16:33 Changeset [58919] by
-
Improve code generator scripts to pass additional ScriptExecutionContext
argument to the constructor.
https://bugs.webkit.org/show_bug.cgi?id=38687
Reviewed by Adam Barth.
Change both JSC and V8 generators to introduce "CallWith=ScriptExecutionContext"
attribute to allow passing the additional ScriptExecutionContext argument to
the constructor. Also add another test IDL file to test interface-level
features.
These changes are necessary in order to avoid adding custom binding codes
when we add the FileReader interface.
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h: Added.
- bindings/scripts/test/JS/JSTestInterface.cpp: Added.
- bindings/scripts/test/JS/JSTestInterface.h: Added.
- bindings/scripts/test/ObjC/DOMTestInterface.h: Added.
- bindings/scripts/test/ObjC/DOMTestInterface.mm: Added.
- bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h: Added.
- bindings/scripts/test/TestInterface.idl: Added.
- bindings/scripts/test/V8/V8TestInterface.cpp: Added.
- bindings/scripts/test/V8/V8TestInterface.h: Added.
- bindings/v8/V8Proxy.h:
(WebCore::V8Proxy::constructDOMObjectWithScriptExecutionContext):
- 16:23 Changeset [58918] by
-
Build fix, not reviewed.
Speculative Windows and Debug build fixes for the last change.
- dom/Node.h:
(WebCore::Node::inDocument):
(WebCore::Node::setFlag):
- 16:23 Changeset [58917] by
-
2010-05-06 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Dan Bernstein..
REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>
When the plug-in database is initialized, we will register all the MIME types it supports with the global
WebView dictionary. When plug-ins are disabled for a single web view, the MIME types still need to be
in the global mapping (because other web views might still have plug-ins enabled).
Prior to r51617 we would always look at the plug-in database to determine that the MIME type belongs to a
plug-in, but now we won't even touch the plug-in database when plug-ins are disabled.
In order to fix this, a new set of registered MIME types that are known to be plug-ins is added. When
+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:] is called and allowingPlugins is FALSE
we check if the MIME type is a known plug-in MIME type and return false in that case.
- Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
- WebView/WebView.mm: (knownPluginMIMETypes): (+[WebView _registerPluginMIMEType:]): (+[WebView _unregisterPluginMIMEType:]): (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
- WebView/WebViewInternal.h:
2010-05-06 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Dan Bernstein..
REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>
Add tests.
- platform/mac/plugins/disable-plugins-expected.txt: Added.
- platform/mac/plugins/disable-plugins.html: Added.
2010-05-06 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Dan Bernstein..
REGRESSION (r51617): when plugins are disabled, plugins show up as garbage characters
https://bugs.webkit.org/show_bug.cgi?id=38698
<rdar://problem/7942075>
Add a 'setPluginsEnabled' layoutTestController function for disabling plug-ins. This is only implemented on Mac currently
because the bug that needs this functionality is mac specific.
- DumpRenderTree/LayoutTestController.cpp: (setPluginsEnabledCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setPluginsEnabled):
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setPluginsEnabled):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setPluginsEnabled):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setPluginsEnabled):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setPluginsEnabled):
- 16:18 Changeset [58916] by
-
2010-05-06 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
https://bugs.webkit.org/show_bug.cgi?id=38158
Fixes:
- replace NULL with 0
- remove unusued locals
add parens around ambiguous looking compound predicates like (a b && c) This also adds a check for x >= 0 to FontLinux.cpp's in this statement:
if (x < walker.width())
This is more documentation than anything else since walker.width() returns
an unsigned the current behavior is that x is promoted to unsigned and as
long as x + walker.width() is less than 231 all negative values of x
end up wrapping around and not being < walker.width(). This behavior is
tested by fast/text/international/khmer-selection.html
- platform/graphics/chromium/FontLinux.cpp: (WebCore::adjustTextRenderMode): (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::length): (WebCore::TextRunWalker::width): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::Font::offsetForPositionForComplexText):
- platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
- platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint):
- platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::isCoordinateSkiaSafe): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
- 15:53 Changeset [58915] by
-
https://bugs.webkit.org/show_bug.cgi?id=38695
Reviewed by David Kilzer.
Check the result from widget() for NULL before accessing it.
- rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::calcHeight):
(WebCore::RenderIFrame::calcWidth):
- 15:41 Changeset [58914] by
-
2010-05-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Darin Adler.
further fixes towards REGRESSION (r57292): 1% PLT regression from visited link information leak fix
https://bugs.webkit.org/show_bug.cgi?id=38682
<rdar://problem/7859794>
Looks like a 1-2% speedup on PLT.
- Reorder CSS properties.
- Remove short circuit tag check in matchRulesForList which costs more than it saves.
- Inline initForStyleResolve.
- Optimize applyDeclarations to avoid switch and take fewer branches in the inner loop.
- Change the way Node handles flags - replace bitfield with a uint32_t and explicit masking, to make it cheaper to initialize the bits and give faster access.
- Added new Node flags to check for isStyledElement, isHTMLElement, isSVGElement, isComment, and devirtualize those methods.
- Inline constructors for Node, Element, Text, CharacterData, StyledElement, etc since they are very simple and lots of nodes get constructed.
- css/CSSPropertyNames.in: Move a few of the properties up front so we can check for them with < instead of switch statements
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): Remove unnecessary preflight check for tag match before checking selector. This check very rarely short circuits anything, since most rules with a tag end up in the appropriate tag bucket. So doing the check cost more time than the time saved. (WebCore::CSSStyleSelector::initForStyleResolve): Inline. Create RenderStyle in a better way. (WebCore::CSSStyleSelector::applyDeclarations): Get rid of switch statement and use <= to check for the high priority properties. Convert to template to avoid checking "applyFirst" each time through the loop. (WebCore::CSSStyleSelector::styleForElement): Adjust for new applyDeclarations() signature. (WebCore::CSSStyleSelector::keyframeStylesForAnimation): ditto (WebCore::CSSStyleSelector::pseudoStyleForElement): ditto
- css/CSSStyleSelector.h: Adjust for new applyDeclarations() signature.
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle): Inline constructor.
- rendering/style/RenderStyle.h: Make constructor private so it can be inline.
- dom/Node.h: (WebCore::): See high-level description of changes above. Redid the way boolean flags work. (WebCore::Node::isElementNode): (WebCore::Node::isContainerNode): (WebCore::Node::isTextNode): (WebCore::Node::isHTMLElement): (WebCore::Node::isSVGElement): (WebCore::Node::isStyledElement): (WebCore::Node::isCommentNode): (WebCore::Node::hasID): (WebCore::Node::hasClass): (WebCore::Node::active): (WebCore::Node::inActiveChain): (WebCore::Node::inDetach): (WebCore::Node::hovered): (WebCore::Node::attached): (WebCore::Node::setAttached): (WebCore::Node::needsStyleRecalc): (WebCore::Node::styleChangeType): (WebCore::Node::childNeedsStyleRecalc): (WebCore::Node::isLink): (WebCore::Node::setHasID): (WebCore::Node::setHasClass): (WebCore::Node::setChildNeedsStyleRecalc): (WebCore::Node::clearChildNeedsStyleRecalc): (WebCore::Node::setInDocument): (WebCore::Node::clearInDocument): (WebCore::Node::setInActiveChain): (WebCore::Node::clearInActiveChain): (WebCore::Node::setIsLink): (WebCore::Node::clearIsLink): (WebCore::Node::setActive): (WebCore::Node::setHovered): (WebCore::Node::inDocument): (WebCore::Node::): (WebCore::Node::getFlag): (WebCore::Node::setFlag): (WebCore::Node::clearFlag): (WebCore::Node::hasRareData): (WebCore::Node::isParsingChildrenFinished): (WebCore::Node::setIsParsingChildrenFinished): (WebCore::Node::clearIsParsingChildrenFinished): (WebCore::Node::isStyleAttributeValid): (WebCore::Node::setIsStyleAttributeValid): (WebCore::Node::clearIsStyleAttributeValid): (WebCore::Node::isSynchronizingStyleAttribute): (WebCore::Node::setIsSynchronizingStyleAttribute): (WebCore::Node::clearIsSynchronizingStyleAttribute): (WebCore::Node::areSVGAttributesValid): (WebCore::Node::setAreSVGAttributesValid): (WebCore::Node::clearAreSVGAttributesValid): (WebCore::Node::isSynchronizingSVGAttributes): (WebCore::Node::setIsSynchronizingSVGAttributes): (WebCore::Node::clearIsSynchronizingSVGAttributes): (WebCore::Node::hasRareSVGData): (WebCore::Node::setHasRareSVGData): (WebCore::Node::clearHasRareSVGData): (WebCore::Node::initialRefCount):
- dom/Node.cpp: (WebCore::Node::trackForDebugging): Adjusted for changes in flag handling. (WebCore::Node::ensureRareData): ditto (WebCore::Node::setStyleChange): ditto (WebCore::Node::setNeedsStyleRecalc): ditto (WebCore::Node::lazyAttach): ditto (WebCore::Node::attach): ditto (WebCore::Node::detach): ditto (WebCore::Node::insertedIntoDocument): ditto (WebCore::Node::removedFromDocument): ditto
- dom/CharacterData.cpp:
- dom/CharacterData.h: (WebCore::CharacterData::CharacterData): Inline the constructor (moved from .cpp)
- dom/Comment.cpp: (WebCore::Comment::Comment): Tell the base class that we're a comment.
- dom/Comment.h: Remove isCommentNode override.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::detach): Adjusted for changes in flag handling. (WebCore::ContainerNode::removedFromDocument): ditto
- dom/Document.cpp: (WebCore::Document::Document): Adjusted for changes in flag handling. (WebCore::Document::recalcStyle): ditto (WebCore::Document::setFocusedNode): ditto
- dom/Document.h: (WebCore::Node::Node): Inline the Node constructor - goes here because it uses Document.
- dom/DocumentFragment.cpp: include Document.h due to above change
- dom/EditingText.cpp: ditto
- dom/EntityReference.cpp: ditto
- dom/Element.cpp: (WebCore::Element::getAttribute): Adjusted for changes in flag handling. (WebCore::Element::setAttribute): ditto (WebCore::Element::hasAttributes): ditto (WebCore::Element::recalcStyle): ditto (WebCore::Element::finishParsingChildren): ditto
- dom/Element.h: (WebCore::Element::Element): Inline (moved from .cpp) (WebCore::Element::isFinishedParsingChildren): (WebCore::Element::beginParsingChildren): (WebCore::Element::attributes): Adjusted for changes in flag handling.
- dom/StyledElement.cpp: (WebCore::StyledElement::updateStyleAttribute): Adjust for changes to flag handling. (WebCore::StyledElement::mapToEntry): ditto (WebCore::StyledElement::parseMappedAttribute): ditto (WebCore::StyledElement::copyNonAttributeProperties): ditto
- dom/StyledElement.h: (WebCore::StyledElement::StyledElement): Inline (moved from.cpp) (WebCore::StyledElement::invalidateStyleAttribute): Adjust for changes in flag handling.
- dom/Text.h: (WebCore::Text::Text): Inline (moved from .cpp)
- dom/Text.cpp:
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): Adjust for changes in flag handling. (WebCore::HTMLAnchorElement::parseMappedAttribute): ditto
- html/HTMLElement.cpp: (WebCore::HTMLElement::create): Tell base class we're an HTML element.
- html/HTMLElement.h: ditto above; remove isHTMLElement override.
- html/HTMLFormControlElement.h: Tell base class we're an HTML element.
- html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): ditto
- html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::HTMLProgressElement): ditto
- mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement): Tell base class we're a styled element.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): Adjust for changes in flag handling. (WebCore::MediaControlElement::MediaControlElement): ditto (WebCore::MediaControlInputElement::MediaControlInputElement): ditto
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement): ditto
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateHoverActiveState): ditto
- rendering/RenderProgress.cpp: (WebCore::RenderProgress::updateValuePartState): ditto
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::updateFromElement): ditto
- rendering/SVGShadowTreeElements.cpp: (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): ditto
- rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): ditto
- svg/SVGAnimatedProperty.h: (WebCore::SVGAnimatedPropertyTearOff::setBaseVal): ditto (WebCore::SVGAnimatedPropertyTearOff::setAnimVal): ditto
- svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): Tell base class we're an svg element. (WebCore::SVGElement::ensureRareSVGData): Adjust for flag handling changes. (WebCore::SVGElement::updateAnimatedSVGAttribute): ditto
- svg/SVGElement.h: (WebCore::SVGElement::invalidateSVGAttributes): ditto
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged): ditto
- wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::WMLAnchorElement): ditto
- wml/WMLElement.cpp: (WebCore::WMLElement::WMLElement): Tell base class we're a styled element.
- 15:28 Changeset [58913] by
-
<rdar://problem/7951285> REGRESSION (r58847): Composited iframe content obscures Safari's application chrome
Reviewed by Simon Fraser.
Fixed this other regression from r58847. The regression was caused by overriding -visibleRect to
return the WebClipView’s full bounds. AppKit uses -visibleRect to determine the geometry
of the surface for the child WebFrameView. The fix is to restrict the special behavior of
-[WebClipView visibleRect] to when AppKit is consulting it for the purpose of invalidating
areas while scrolling.
- WebView/WebClipView.h:
- WebView/WebClipView.mm:
(-[WebClipView visibleRect]): If the WebClipView is not scrolling, always return
[super visibleRect].
(-[WebClipView _immediateScrollToPoint:]): Override this internal NSClipView method
to set a flag telling -visibleRect that the view is scrolling.
- WebView/WebView.mm:
(layerSyncRunLoopObserverCallBack): Ensure that screen updates, disabled by AppKit
when it thinks an upcoming window flush will re-enable them, are enabled here in
case the -setNeedsDisplayInRect: override has prevented the window from needing to be
flushed.
- 15:28 Changeset [58912] by
-
2010-05-06 John Gregg <johnnyg@google.com>
Unreviewed, rebaseline for chromium test.
[chromium] Deal with different local path structure on windows.
- platform/chromium-win/fast/notifications: Added.
- platform/chromium-win/fast/notifications/notifications-replace-expected.txt: Added.
- 15:19 Changeset [58911] by
-
Windows build fix.
- bytecode/SamplingTool.cpp:
(JSC::SamplingFlags::sample): Use a cast, so Windows will be happy when
this code is enabled.
- wtf/Platform.h: Reverted last change to this file, which seems to have
been accidental.
- 15:12 Changeset [58910] by
-
2010-05-06 Adam Barth <abarth@webkit.org>
Unreviewed. Fix indent. Sorry, my OCD was acting up.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
- 15:09 Changeset [58909] by
-
2010-05-06 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations fix.
Delete a line for a test that is no longer failing on chromium linux.
- platform/chromium/test_expectations.txt:
- 14:20 BuildingQtOnSymbian edited by
- (diff)
- 13:50 Changeset [58908] by
-
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: store selected Headers / Content tab on explicit switch and/or explicit navigate only.
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectHeadersTab): (WebInspector.ResourceView.prototype.selectContentTab):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.showResource):
- 13:47 Changeset [58907] by
-
Add compile switch to make debugger keyword plant breakpoint instructions.
Reviewed by Oliver Hunt.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
- wtf/Platform.h:
- 13:38 Changeset [58906] by
-
2010-05-06 Luiz Agostini <luiz.agostini@openbossa.org>
Rubber-stamped by Simon Hausmann.
[Qt] use QT_MOBILE_THEME in Symbian
https://bugs.webkit.org/show_bug.cgi?id=38440
Putting QT_MOBILE_THEME into use for Symbian.
- WebCore.pro:
- 13:26 Changeset [58905] by
-
2010-05-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed, build fix WinCE for QtWebKit.
[Qt] Compilation with Plugins disabled is broken
https://bugs.webkit.org/show_bug.cgi?id=31407
Rename platform/qt/TemporaryLinkStubs.cpp to avoid name collition on
Windows.
Thanks for Ismail "cartman" Donmez for help.
No new tests, as there is no new functionality.
- WebCore.gypi:
- WebCore.pro:
- platform/qt/TemporaryLinkStubs.cpp: Removed.
- platform/qt/TemporaryLinkStubsQt.cpp: Copied from WebCore/platform/qt/TemporaryLinkStubs.cpp.
- 13:04 Changeset [58904] by
-
Fix ARM builds
- 13:01 Changeset [58903] by
-
2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] REGRESSION: Loading of external CSS and JS files over network fails in some cases
https://bugs.webkit.org/show_bug.cgi?id=36755
Enable the direct connection between QtNetwork and QtWebKit only for Qt versions
greater than 4.6.2, due to a bug in Qt that's been fixed after 4.6.2.
- platform/network/qt/QNetworkReplyHandler.cpp:
- 12:39 Changeset [58902] by
-
2010-05-06 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Improve performance of single character string compares
https://bugs.webkit.org/show_bug.cgi?id=38659
Add logic to the jit to identify comparisons to single character string literals
and then just perform the comparison inline, rather than ignoring the evidence
and attempting to perform an integer comparison.
Multiple changes required -- add jnlesseq opcode, add helper function to identify
single character string constants, add a helper to load single character strings.
Then add the 32_64 and normal codepaths to the JIT.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::load16):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpIfTrue):
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jlesseq): (JSC::JIT::emitSlow_op_jnlesseq):
- jit/JITArithmetic32_64.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emitBinaryDoubleOp):
- jit/JITInlineMethods.h: (JSC::JIT::emitLoadCharacterString): (JSC::JIT::isOperandConstantImmediateChar):
- jit/JSInterfaceJIT.h: (JSC::ThunkHelpers::stringImplDataOffset): (JSC::ThunkHelpers::jsStringLengthOffset): (JSC::ThunkHelpers::jsStringValueOffset): Moved from ThunkGenerators to make it possible to share.
- jit/ThunkGenerators.cpp:
2010-05-06 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Improve performance of single character string compares
https://bugs.webkit.org/show_bug.cgi?id=38659
Add many tests of <, >, <=, >=, ==, ===, !=, !== as the existing
tests were woefully inadequate.
- fast/js/comparison-operators-expected.txt: Added.
- fast/js/comparison-operators-greater-expected.txt: Added.
- fast/js/comparison-operators-greater.html: Added.
- fast/js/comparison-operators-less-expected.txt: Added.
- fast/js/comparison-operators-less.html: Added.
- fast/js/comparison-operators.html: Added.
- fast/js/script-tests/comparison-operators-greater.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
- fast/js/script-tests/comparison-operators-less.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
- fast/js/script-tests/comparison-operators.js: Added. (description.makeTest.func.f.toString): (description.makeTest): (doTest):
- 12:06 Changeset [58901] by
-
2010-05-06 Martin Robinson <mrobinson@webkit.org>
Reviewed by Xan Lopez.
Remove use of GOwnPtr to hold GObject types.
https://bugs.webkit.org/show_bug.cgi?id=38669
Change use of GOwnPtr to GRefPtr to types which are natively reference-counted.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): Change GOwnPtr to GRefPtr in some places. (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto.
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_new_with_core_request): Ditto.
- webkit/webkitnetworkresponse.cpp: (webkit_network_response_new_with_core_response): Ditto.
- webkit/webkitprivate.cpp: Remove GOwnPtr reference counting template specialization.
- webkit/webkitprivate.h: Ditto.
- 11:50 Changeset [58900] by
-
2010-05-06 Adam Roben <aroben@apple.com>
Bail out of WebView::paint when there's nothing to paint
Fixes <http://webkit.org/b/38670> <rdar://problem/7947105> REGRESSION
(r58067): Crash in WebView::paint when Web Inspector is docked and
window is resized so small that WebView disappears
When the WebView is 0-sized, ensureBackingStore() bails out without
creating a bitmap, leaving m_backingStoreBitmap null. Before r58067,
m_backingStoreBitmap was an HBITMAP, so we were happily passing along
a null HBITMAP to various Windows APIs. These calls would fail but not
crash. r58067 changed m_backingStoreBitmap to a RefCountedHBITMAP, and
dereferencing a null RefCountedHBITMAP* of course crashes.
Reviewed by Steve Falkenburg.
- WebView.cpp: (WebView::paint): Bail if the rect to paint is empty.
- 11:47 Changeset [58899] by
-
2010-05-06 John Gregg <johnnyg@google.com>
Unreviewed. Updating test expectations.
[chromium] enabling notifications tests after test_shell change.
- platform/chromium/test_expectations.txt:
- 11:46 Changeset [58898] by
-
2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Rework where we get page step and line step from, so we do not
depend on scrollbars existing. Caught by API test I forgot to run.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
- 10:47 Changeset [58897] by
-
2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Adjustment resetting uses wrong values, and misses page_size and steps
https://bugs.webkit.org/show_bug.cgi?id=38657
Fix resetting adjustment values. In the page cache case, we were
confusing page_size and upper, leading to stray scrollbars
sometimes.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments):
- 10:42 Changeset [58896] by
-
2010-05-06 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
editing/selection/shift-click.html fails on GTK and QT
https://bugs.webkit.org/show_bug.cgi?id=38656
r58892 added this test. It's the first test for shift+click behavior,
so it exposed bugs in GTK/QT. Skipping to green the bots.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 10:37 Changeset [58895] by
-
2010-05-06 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebFrame::paintDocumentRectToContext paints content at the wrong location
https://bugs.webkit.org/show_bug.cgi?id=38651
- WebFrame.cpp: (WebFrame::paintDocumentRectToContext):
- 10:12 Changeset [58894] by
-
2010-05-06 Darin Adler <darin@apple.com>
Reviewed by Beth Dakin.
Page::setCanStartMedia does not properly handle the case where a media listener is removed
https://bugs.webkit.org/show_bug.cgi?id=38602
We can't find any real case where this causes a crash at this time, but
we want to harden the code anyway. Thus there are no new regression tests.
- page/Page.cpp: (WebCore::Page::removeMediaCanStartListener): Removed incorrect assertion. (WebCore::Page::setCanStartMedia): Change algorithm so we notify listeners one at a time and don't notify any listener that has already been removed from the set.
- 10:05 Changeset [58893] by
-
2010-05-06 Evan Martin <evan@chromium.org>
Unreviewed. Updating test expectations.
[chromium] new baselines for r58886
https://bugs.webkit.org/show_bug.cgi?id=38652
- platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.txt:
- platform/chromium-linux/fast/text/international/danda-space-expected.checksum:
- platform/chromium-linux/fast/text/international/danda-space-expected.png:
- platform/chromium-linux/fast/text/international/danda-space-expected.txt:
- platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
- platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
- platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt:
- platform/chromium/test_expectations.txt:
- 09:58 Changeset [58892] by
-
2010-05-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
shift+click on an existing selection doesn't work right
https://bugs.webkit.org/show_bug.cgi?id=36542
NSTextView behavior is to move the end of the selection
closest to the shift-click. Win/Linux behavior is to always
move the focus end of the selection.
- editing/selection/script-tests/shift-click.js: Added. (shiftClick): (assertSelectionString):
- editing/selection/shift-click-expected.txt: Added.
- editing/selection/shift-click.html: Added.
- platform/win/editing/selection/shift-click-expected.txt: Added.
2010-05-05 Ojan Vafai <ojan@chromium.org>
Reviewed by Darin Adler.
shift+click on an existing selection doesn't work right
https://bugs.webkit.org/show_bug.cgi?id=36542
NSTextView behavior is to move the end of the selection
closest to the shift-click. Win/Linux behavior is to always
move the focus end of the selection.
Test: editing/selection/shift-click.html
- page/EventHandler.cpp: (WebCore::textDistance): (WebCore::EventHandler::handleMousePressEventSingleClick):
- 09:53 Changeset [58891] by
-
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: implement panels history traversal on Cmd+Left/Right.
- inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.PanelHistory): (WebInspector.PanelHistory.prototype.canGoBack): (WebInspector.PanelHistory.prototype.goBack): (WebInspector.PanelHistory.prototype.canGoForward): (WebInspector.PanelHistory.prototype.goForward): (WebInspector.PanelHistory.prototype.setPanel):
- 09:49 Changeset [58890] by
-
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Chromium Dev Tools: Large toolbar icons flash when dev
tools is opened in docked mode.
- src/js/DevTools.js: (devtools.domContentLoaded):
- 09:46 Changeset [58889] by
-
2010-05-06 Jochen Eisinger <jochen@chromium.org>
Reviewed by Dimitri Glazkov.
Make ImageDiff depend on WebKit. When compiled from within Chromium, WTF is not a standalone dynamic library but depends on WebKit.
https://bugs.webkit.org/show_bug.cgi?id=38632
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 09:43 Changeset [58888] by
-
2010-05-05 Antonio Gomes <tonikitoo@webkit.org>
Rubber-stamped by Kenneth Christiansen.
Spatial Navigation: use data url in layout tests
https://bugs.webkit.org/show_bug.cgi?id=38584
In order to make Spatial Navigation layout tests more readable, patch
changes the use or src=resources/iframeXXX.html by inlined sources via
data uri schema.
It is a polishment.
- fast/events/spatial-navigation/resources/iframe.html: Removed.
- fast/events/spatial-navigation/resources/iframe2.html: Removed.
- fast/events/spatial-navigation/resources/iframe3.html: Removed.
- fast/events/spatial-navigation/resources/iframe4.html: Removed.
- fast/events/spatial-navigation/snav-iframe-no-focusable-content.html:
- fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
- fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:
- 09:42 Changeset [58887] by
-
2010-05-06 Antonio Gomes <tonikitoo@webkit.org>
[Gtk] Skipped fast/events/spatial-navigation/snav-iframe-flattening-simple.html
DRT does not support frame flattening testing.
https://bugs.webkit.org/show_bug.cgi?id=38650
- platform/gtk/Skipped:
- 09:34 Changeset [58886] by
-
2010-05-03 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
[chromium] use glyphDataForCharacter so we hit the glyphdata cache
https://bugs.webkit.org/show_bug.cgi?id=38500
Calling fontDataForCharacters() while rendering text is expensive.
Examining the relevant Mac code in WebKit revealed that calling the
similarly-named glyphDataForCharacters() results in caching the font
data on a per-glyph basis.
Since we now choose a font based on the first character in a run, we
need to be careful that all the glyphs within the run use the same font.
This is also similar to the WebKit Mac code. We need to remove all of
the script run bits eventually and this is a step in that direction.
Tests: fast/text/international/danda-space.html spacing changes slightly
(now matches Firefox better) and fast/text/international/thai-baht-space.html
now picks the correct (serif) font for the digits.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::setupFontForScriptRun):
- 09:32 Changeset [58885] by
-
2010-05-06 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Convert dragging portion of drag-and-drop to use DataObjectGtk.
- wtf/gobject/GRefPtr.h: Add forward declarations for GObject functions.
2010-05-06 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Convert dragging portion of drag-and-drop to use DataObjectGtk.
No new tests, because functionality has not changed.
- page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::createDraggingClipboard): Pass the DataObjectGtk as a parameter here.
- platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create): Take the DataObject as a parameter instead of creating it here. (WebCore::ClipboardGtk::helper): Added. (WebCore::ClipboardGtk::dataObject): Added.
- platform/gtk/PasteboardHelper.h: Make targetListForDataObject a public method.
2010-05-06 Martin Robinson <mrobinson@webkit.org>
Reviewed by Gustavo Noronha Silva.
[GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Convert dragging portion of drag-and-drop to use DataObjectGtk.
- WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::willPerformDragDestinationAction): Remove the notImplemented. It is implemented, it's just a no-op. (WebKit::DragClient::startDrag): Start the drag context via the ClipboardGtk and PasteboardHelper now.
- WebCoreSupport/DragClientGtk.h: Small style fix.
- webkit/webkitprivate.h: Add a HashMap of contexts and DataObjects here to to represent all current drag operations.
- webkit/webkitwebview.cpp: (webkit_web_view_dispose): Clear all data objects during disposal. (webkit_web_view_drag_end): When a drag is over, just remove it from the map. (webkit_web_view_drag_data_get): To get the drag data, just grab it from the DataObject.
- 09:30 Changeset [58884] by
-
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not show content tab for resources
not supporting content preview.
- English.lproj/localizedStrings.js:
- inspector/front-end/FontView.js: (WebInspector.FontView.prototype.hasContentTab):
- inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.hasContentTab):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype.hasContentTab):
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hasContentTab):
- 09:23 Changeset [58883] by
-
2010-05-05 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
Spatial Navigation: Add LayoutTest with frame flattening feature on.
https://bugs.webkit.org/show_bug.cgi?id=38585
- fast/events/spatial-navigation/snav-iframe-flattening-simple-expected.txt: Added.
- fast/events/spatial-navigation/snav-iframe-flattening-simple.html: Added.
- 09:17 Changeset [58882] by
-
2010-05-06 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
Spatial Navigation: adapt the logic of {deep}findFocusableNodeInDirection to do traversal starting from Node* not Document*
https://bugs.webkit.org/show_bug.cgi?id=37803
Instead of receiving a Document pointer as incoming parameter, patch modifies
findFocusableNodeInDirection and deepFindFocusableNodeInDirection methods to
receive a Node pointer as start for content traversal.
This way we can make good use of deepFindFocusableNodeInDirection to traverse
other scrollable container like scrollable div's, and not only frames or iframes.
Patch also makes use of 'while' instead of 'for' to loop control, that gives move
flexibility to the incremental step: e.g. if a scrollable div was processed, the incremental
step in the loop does not have to do node->traverseNextNode() but node->traverseNextSibling().
No behavior change. It is a preparation for supporting scrollable containers in Spatial
Navigation.
- page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally): (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
- page/FocusController.h:
- 09:04 Changeset [58881] by
-
Unreviewed WinCE buildfix after r58842.
Preprocessor doesn't understand "true", changed to "1"
- platform/graphics/MediaPlayer.cpp:
- 08:31 Changeset [58880] by
-
2010-05-06 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Temporarily disable 'console.profiles' until we can distinguish
functions from different frames
- bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::profilesAccessorGetter):
- 08:13 Changeset [58879] by
-
2010-05-06 Vitaly Repeshko <vitalyr@chromium.org>
[chromium] Unreviewed. Updating expectations.
- platform/chromium-linux/fast/url/segments-expected.txt: Added.
- platform/chromium-linux/fast/url/segments-from-data-url-expected.txt: Added.
- platform/chromium-mac/fast/url/segments-expected.txt: Added.
- platform/chromium-mac/fast/url/segments-from-data-url-expected.txt: Added.
- platform/chromium-win/fast/url/segments-expected.txt: Added.
- platform/chromium-win/fast/url/segments-from-data-url-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 07:12 QtWebKitTriageRoster edited by
- (diff)
- 07:09 Changeset [58878] by
-
2010-05-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
https://bugs.webkit.org/show_bug.cgi?id=38544
- wtf/Platform.h:
2010-05-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
https://bugs.webkit.org/show_bug.cgi?id=38544
No new tests, build fix only.
- DerivedSources.make:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
- bindings/js/ScriptController.h:
- bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
- bridge/jni/JNIBridge.cpp:
- bridge/jni/JNIBridge.h:
- bridge/jni/JNIUtility.cpp:
- bridge/jni/JNIUtility.h:
- bridge/jni/jni_jsobject.h:
- bridge/jni/jni_jsobject.mm:
- bridge/jni/jni_objc.mm:
- bridge/jni/jsc/JNIBridgeJSC.cpp:
- bridge/jni/jsc/JNIBridgeJSC.h:
- bridge/jni/jsc/JNIUtilityPrivate.cpp:
- bridge/jni/jsc/JNIUtilityPrivate.h:
- bridge/jni/jsc/JavaClassJSC.cpp:
- bridge/jni/jsc/JavaClassJSC.h:
- bridge/jni/jsc/JavaInstanceJSC.cpp:
- bridge/jni/jsc/JavaInstanceJSC.h:
- loader/FrameLoaderClient.h:
2010-05-06 Steve Block <steveblock@google.com>
Reviewed by Eric Seidel.
MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
https://bugs.webkit.org/show_bug.cgi?id=38544
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- 06:12 Changeset [58877] by
-
2010-05-06 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Patch to fix compilation warnings for QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=37428
Patch by Alexis Menard <alexis.menard@nokia.com>
- Api/qgraphicswebview.cpp: (QGraphicsWebView::itemChange):
- 06:00 Changeset [58876] by
-
2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Replace public inspector url with private property for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=35340
Replace the public API with a private dynamic property until this feature
is ready.
- Api/qwebsettings.cpp:
- Api/qwebsettings.h:
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):
- symbian/bwins/QtWebKitu.def:
- symbian/eabi/QtWebKitu.def:
2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Replace public inspector url with private property for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=35340
Replace the public API with a private dynamic property until this feature
is ready.
- QtLauncher/main.cpp: (LauncherWindow::init):
- 02:44 Changeset [58875] by
-
2010-05-05 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Fixed the gobject introspection compilation with the new DOM
bindings, we needed to add DOM objects.
- GNUmakefile.am:
- 02:31 Changeset [58874] by
-
2010-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
[WTFURL] Add a class to represent the segments of a URL
https://bugs.webkit.org/show_bug.cgi?id=38566
When paired with a string, this class represents a parsed URL.
- wtf/url/src/URLSegments.cpp: Added. (WTF::URLSegments::length): (WTF::URLSegments::charactersBefore):
- wtf/url/src/URLSegments.h: Added. (WTF::URLSegments::): (WTF::URLSegments::URLSegments):
- wtf/url/wtfurl.gyp:
- 02:19 Changeset [58873] by
-
2010-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
drop support for sessionStorage in sandbox iframes
https://bugs.webkit.org/show_bug.cgi?id=38151
Update test expectation. This test was originally created to show that
we complied with the letter of the spec, but our behavior is insecure.
In the future, we might revert this change and implement a separate
storage area for each unique origin.
- fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
- fast/frames/sandboxed-iframe-storage-expected.txt:
2010-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
drop support for sessionStorage in sandbox iframes
https://bugs.webkit.org/show_bug.cgi?id=38151
This patch causes us to throw a security exception when a sandboxed
iframe attempts to access sessionStorage, matching our behavior for
localStorage. The letter of the spec asks us to create a separate
storage area for each unique origin. We might want to do that in a
future patch, but throwing a security error seems like a safe move now.
- page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessSessionStorage):
- storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch):
2010-05-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
drop support for sessionStorage in sandbox iframes
https://bugs.webkit.org/show_bug.cgi?id=38151
Update client of sessionStorage to handle exceptions.
- src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent):
- 01:51 Changeset [58872] by
-
WebCore: Allow forms submitting to target="_blank" to open popups if the submission
originated from a user gesture.
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=37335
<rdar://problem/7884980>
Test: fast/events/popup-allowed-from-gesture-initiated-form-submit.html
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture): If no DOM event is
being processed, consult UserGestureIndicator to determine return value.
- bindings/js/ScriptController.h: Moved the logic of processingUserGestureEvent()
into processingUserGesture().
LayoutTests: Add a test to ensure popups are allowed when the user submits a form with target="_blank".
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=37335
<rdar://problem/7884980>
- fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Added.
- fast/events/popup-allowed-from-gesture-initiated-form-submit.html: Added.
- fast/events/resources/popup-allowed-from-gesture-initiated-form-submit-target.html: Added.
- 01:10 Changeset [58871] by
-
2010-05-06 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Eric Seidel.
[GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=38577
Thinko caught while refactoring, $custom variable was not
initialized.
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
- 01:09 Changeset [58870] by
-
2010-05-06 Xan Lopez <xlopez@igalia.com>
Rubber-stamped by Eric Seidel.
[GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=38577
Refactor GenerateProperty out of GenerateProperties. This is in
preparation for EventListeren attributes, which won't generate
normal GObject properties.
- bindings/scripts/CodeGeneratorGObject.pm:
- 01:01 Changeset [58869] by
-
2010-05-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: follow up to linkify event listeners.
- bindings/js/ScriptEventListener.cpp: (WebCore::eventListenerHandlerLocation):
- bindings/v8/ScriptEventListener.cpp: (WebCore::eventListenerHandlerLocation):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
- inspector/front-end/EventListenersSidebarPane.js:
- 00:05 Changeset [58868] by
-
2010-05-05 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Pavel Feldman.
Web Inspector: build-webkit --inspector-frontend Should Exclude *.re2js
https://bugs.webkit.org/show_bug.cgi?id=38449
- Scripts/webkitdirs.pm:
