Timeline


and

05/11/10:

22:50 Changeset [59210] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-05-11 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Shorthand Properties Getting Deleted When Editing
https://bugs.webkit.org/show_bug.cgi?id=38958

  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands): was getting regular values instead of shorthand values
22:10 Changeset [59209] by cjerdonek@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-11 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Eric Seidel.

Fixed two FIXME's in svn-apply: eliminated the unnecessary %copiedFiles
variable and changed gitKnowsOfFile() to use exitStatus().

https://bugs.webkit.org/show_bug.cgi?id=38862

  • Scripts/svn-apply:
21:58 WebKit Team edited by andreas.kling@nokia.com
(diff)
21:57 WebKit Team edited by andreas.kling@nokia.com
(diff)
21:56 Changeset [59208] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-11 Eric Seidel <eric@webkit.org>

Unreviewed, just fixing python typo.

EWS bots should poll more often than every 5 minutes
https://bugs.webkit.org/show_bug.cgi?id=38968

Typo in _now(), add a unittest to prove I fixed it.

  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
21:44 Changeset [59207] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Qt build failures cause SheriffBot false positives
https://bugs.webkit.org/show_bug.cgi?id=38969

The Qt buildbot randomly fails to compile occasionally because its
network connection causes SVn to leave zero-byte files around. These
compile failures confuse SheriffBot into thinking someone's patch
caused a build break.

In this patch, I've temporarily removed Qt from the list of core
builders. Ossy is working on a script to clean up the zero byte files.
Once that goes in, we can add Qt back to the core builders.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
21:36 Changeset [59206] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot is spammy.
https://bugs.webkit.org/show_bug.cgi?id=38936

Reduce sheriffbot spam by not warning about new blameworthy revisions
that can be explained by previously blamed revisions. This might cause
us to not warn about some real failures, but we're getting too much
spam from slow builders that have large blamelists (and we've already
poked the responsible folks using data from a fast builder).

  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
    • Removed unneeded import
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • The logic change
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Tests of the change
  • Scripts/webkitpy/tool/mocktool.py:
    • Merged two declarations of MockBuilder
21:30 Changeset [59205] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Slight simplification to the calling convention: read RegisterFile::end()
from an absolute address, instead of from a pointer to the RegisterFile
on the stack.

Reviewed by Gavin Barraclough.

SunSpider reports no change.

This should free us to remove the RegisterFile argument from the stack.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

21:20 Changeset [59204] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-05-11 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

sheriffbot is spammy.
https://bugs.webkit.org/show_bug.cgi?id=38936

Reduce sheriffbot spam by not warning about new blameworthy revisions
that can be explained by previously blamed revisions. This might cause
us to not warn about some real failures, but we're getting too much
spam from slow builders that have large blamelists (and we've already
poked the responsible folks using data from a fast builder).

  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
    • Removed unneeded import
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
    • The logic change
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
    • Tests of the change
  • Scripts/webkitpy/tool/mocktool.py:
    • Merged two declarations of MockBuilder
20:53 Changeset [59203] by tony@chromium.org
  • 4 edits in trunk

2010-05-11 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] Remove subframe scrollbar routing (r58937)
https://bugs.webkit.org/show_bug.cgi?id=38894

  • platform/win/Skipped: This test should pass on windows.

2010-05-11 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] Remove subframe scrollbar routing (r58937)
https://bugs.webkit.org/show_bug.cgi?id=38894

  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe):
20:53 Changeset [59202] by bweinstein@apple.com
  • 3 edits in trunk/JavaScriptCore

Possible Gtk build fix - use ALWAYS_INLINE on functions that were inlined.

  • wtf/text/AtomicString.h:

(WebCore::AtomicString::add): Use ALWAYS_INLINE.

  • wtf/text/WTFString.h:

(WebCore::String::length): Ditto.
(WebCore::String::isEmpty): Ditto.

20:51 Changeset [59201] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-11 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] detect num processors to pass to make -j on Linux
https://bugs.webkit.org/show_bug.cgi?id=38833

  • Scripts/webkitdirs.pm:
20:41 Changeset [59200] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-05-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should commit rollouts without running tests
https://bugs.webkit.org/show_bug.cgi?id=38940

Most of this change is improving our test coverage for the commit-queue.
The only functional change is removing the --test flag when the commit-queue
is running in rollouts mode.

I added test coverage for status updates, and updated the commit-queue status
messages to distinguish rollout vs. normal landing mode in its empty queue
and land patch messages.

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
    • Got rid of a bunch of copy/paste code using _default_expected_stderr
  • Scripts/webkitpy/tool/commands/queues.py:
    • Moved rollout patch filtering out of _validate_patches_in_commit_queue so that we only have to check if the builders are green in one place.
    • Make the "empty queue" message note which queue it is referring to.
    • Don't pass --text to land-attachment when in rollout mode.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Update results now that we're testing status updates.
    • Test _can_build_and_test since I made a typo in that call while writing this change and the unit tests failed to catch it!
  • Scripts/webkitpy/tool/mocktool.py:
    • Log status updates to make them testable in our unit tests.
20:25 Changeset [59199] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2010-05-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Maciej Stachowiak.

Body not redrawn, and filled with garbage on some composited pages
https://bugs.webkit.org/show_bug.cgi?id=38951
<rdar://problem/7891548>

When the root layer becomes composited (for example, because a negative z-index
descendant in its stacking context becomes composited), then it has to be made
large enough to fill the viewport, because the page background draws into it.

Test: compositing/geometry/composited-html-size.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds):
19:33 Changeset [59198] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Add a compile time assert that sizeof(String) == sizeof(AtomicString).

Reviewed by Sam Weinig.

  • wtf/text/AtomicString.cpp:
19:28 Changeset [59197] by andersca@apple.com
  • 6 edits in trunk

2010-05-11 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=38961
Move some member variables around to reduce class sizes.


Make AtomicString no longer inherit from FastAllocBase.

Since AtomicString's first (and only) member variable, a RefPtr, also inherits from FastAllocBase this
was causing the size of AtomicString to contain sizeof(void*) bytes of padding.

  • wtf/text/AtomicString.h:

2010-05-11 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=38961
Move some member variables around to reduce class sizes.

If a class inherits (directly or indirectly) from FastAllocBase, we don't want the first member variable
of that class to also inherit (directly or indirectly) from FastAllocBase as this will add padding to the class
and thus increasing its size.

  • css/CSSParserValues.h:
  • css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::RareData::RareData):
  • platform/graphics/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
19:25 Changeset [59196] by bweinstein@apple.com
  • 8 edits in trunk/JavaScriptCore

Patch by Gavin Barraclough.

Reviewed by Maciej Stachowiak.

Rest of REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Inline string functions that are commonly used in WTFString, CString, and AtomicString.

  • JavaScriptCore.exp: Remove exports of inline functions.
  • wtf/text/AtomicString.cpp:

(WebCore::AtomicString::addSlowCase): Rename add to addSlowCase, and inline the fast path

of add.

  • wtf/text/AtomicString.h:

(WebCore::AtomicString::add): Inline the fast path of add.

  • wtf/text/CString.cpp: Inline implementation of data and length in the header.
  • wtf/text/CString.h:

(WTF::CString::data): Inline implementation of data.
(WTF::CString::length): Inline implementation of length.

  • wtf/text/WTFString.cpp: Remove implementations of functions to be inlined.
  • wtf/text/WTFString.h:

(WebCore::String::String): Inline implementation.
(WebCore::String::length): Ditto.
(WebCore::String::characters): Ditto.
(WebCore::String::operator[]): Ditto.
(WebCore::String::isEmpty): Ditto.

19:20 Changeset [59195] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Adding a function needed by the V8 code generator to turn on/off
the binding for WorkerContext::openDatabaseSync().
https://bugs.webkit.org/show_bug.cgi?id=38960

Reviewed by Adam Barth.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):

  • bindings/generic/RuntimeEnabledFeatures.h:
19:15 Changeset [59194] by morrita@google.com
  • 3 edits
    5 adds in trunk

2010-05-11 MORITA Hajime <morrita@google.com>

Reviewed by Dirk Schulze.

CSS SVG font doesn't recognize URL without element reference
https://bugs.webkit.org/show_bug.cgi?id=37144

  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • svg/custom/resources/graffiti-with-empty-first-font.svg: Added.
  • svg/custom/svg-fonts-with-no-element-reference.html: Added.

2010-05-11 MORITA Hajime <morrita@google.com>

Reviewed by Dirk Schulze.

CSS SVG font doesn't recognize URL without element reference
https://bugs.webkit.org/show_bug.cgi?id=37144

CachedFont::getSVGFontById() did assume that element reference (ID) is given.
So fixed to handle an empty or missing element reference. In which case,
the first font element is returned if available.

Test: svg/custom/svg-fonts-with-no-element-reference.html

  • loader/CachedFont.cpp: (WebCore::CachedFont::getSVGFontById):
18:53 Changeset [59193] by tkent@chromium.org
  • 14 edits
    2 adds in trunk

2010-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Apply recent changes of test_shell to DRT
https://bugs.webkit.org/show_bug.cgi?id=38895

  • DEPS: Update Chromium revision to use the recent webkit_support change.
  • WebKit.gyp: Add JavaScriptCore/wtf to 'include' section.
  • src/WebGraphicsContext3D.cpp: Remove ENABLE(3D_CANVAS) to provide an empty implementation of WebGraphicsContext3D::createDefault().

2010-05-11 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Apply recent changes of test_shell to DRT
https://bugs.webkit.org/show_bug.cgi?id=38895

Port the changes to test_shell during (r40492, r46810] of Chromium.
Highlights:

  • Introduce NotificationPresenter
  • Fix parameter mismatch of WebViewClient::startDragging()

This change fixes dozens of unexpected behaviors.

  • DumpRenderTree/DumpRenderTree.gypi: Add NotificationPresenter.{cpp,h}
  • DumpRenderTree/chromium/EventSender.cpp: (applyKeyModifier): (EventSender::EventSender): (EventSender::reset): (EventSender::webview): (EventSender::doDragDrop): (EventSender::keyDown): (EventSender::addTouchPoint): (EventSender::clearTouchPoints): (EventSender::releaseTouchPoint): (EventSender::setTouchModifier): (EventSender::updateTouchPoint): (EventSender::cancelTouchPoint): (EventSender::sendCurrentTouchEvent): (EventSender::touchEnd): (EventSender::touchMove): (EventSender::touchStart): (EventSender::touchCancel):
  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::showWebInspector): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setScrollbarPolicy): (LayoutTestController::setWillSendRequestClearHeader): (LayoutTestController::callShouldCloseOnWebView): (LayoutTestController::grantDesktopNotificationPermission): (LayoutTestController::removeOriginAccessWhitelistEntry): (LayoutTestController::addUserScript): (LayoutTestController::addUserStyleSheet):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/NotificationPresenter.cpp: Added.
  • DumpRenderTree/chromium/NotificationPresenter.h: Added.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::runFileTest): (TestShell::resetTestController):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::eventSender): (TestShell::notificationPresenter): (TestShell::showDevTools):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): (WebViewHost::createPopupMenu): (WebViewHost::startDragging): (WebViewHost::notificationPresenter): (WebViewHost::createApplicationCacheHost): (WebViewHost::willSendRequest): (WebViewHost::updateAddressBar): (WebViewHost::updateURL):
  • DumpRenderTree/chromium/WebViewHost.h: (WebViewHost::addClearHeader): (WebViewHost::clearHeaders):
18:35 Changeset [59192] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

No Review.

Fix the Windows Debug Build: the correct VCProj variable to use when linking against
JavaScriptCore is $(WebKitDLLConfigSuffix), not $(WebKitConfigSuffix), which expands
to an empty string rather than "_debug".

  • WebCore.vcproj/QTMovieWin.vcproj:
18:16 Changeset [59191] by jer.noble@apple.com
  • 2 edits in trunk/WebKit/win

No Review.

Fix build error: The QTMovieWin project is dependent on the JavaScriptCore project.

  • WebKit.vcproj/WebKit.sln:
17:41 Changeset [59190] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

2010-05-11 Jer Noble <jer.noble@apple.com>

Darin Adler.

19 media tests are crashing on Windows Release
https://bugs.webkit.org/show_bug.cgi?id=38950
rdar://problem/7971658

Link against JavaScriptCore.lib instead of WTF.lib, so the free and malloc used by
QTMovieWin is always the free and malloc in JavaScriptCore.dll.


  • WebCore.vcproj/QTMovieWin.vcproj:
17:35 Changeset [59189] by darin@apple.com
  • 6 edits in trunk/WebCore

Another refactoring patch in preparation for a fix to
https://bugs.webkit.org/show_bug.cgi?id=38871
REGRESSION: Crash clicking background NPR tab after few minutes of sitting idle

Reviewed by Beth Dakin.

  • dom/Document.cpp:

(WebCore::Document::addMediaCanStartListener): Added.
(WebCore::Document::removeMediaCanStartListener): Added.

  • dom/Document.h: Added add/removeMediaCanStartListener.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call removeMediaCanStartListener
on the document instead of the page.
(WebCore::HTMLMediaElement::willMoveToNewOwnerDocument): Call
removeMediaCanStartListener on the current document.
(WebCore::HTMLMediaElement::didMoveToNewOwnerDocument): Call
addMediaCanStartListener on the new document.
(WebCore::HTMLMediaElement::loadInternal): Call addMediaCanStartListener
on the document instead of the page.

  • plugins/PluginView.cpp:

(WebCore::PluginView::startOrAddToUnstartedList): Call addMediaCanStartListener
on the document instead of the page.
(WebCore::PluginView::~PluginView): Call removeMediaCanStartListener
on the document instead of the page, and do it in line instead of calling
a function.

  • plugins/PluginView.h: Removed unused removeFromUnstartedListIfNecessary.
17:26 Changeset [59188] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Not reviewed.

https://bugs.webkit.org/show_bug.cgi?id=38956
[Gtk] http/tests/xmlhttprequest/basic-auth-default.html fails

  • platform/gtk/Skipped: Skipping the new failing test on Gtk.
17:22 Changeset [59187] by bweinstein@apple.com
  • 15 edits
    1 add in trunk

JavaScriptCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg and Jon Honeycutt.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).

We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.

handled in WebCore.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added

here (the post build step is in JavaScriptCoreCommon.vsprops).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled

by WebCore into the WebKitOutputDir directory.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
  • JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
  • wtf/text/AtomicString.cpp: Moved code to StringStatics.
  • wtf/text/StringImpl.cpp: Ditto.
  • wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so

the rest of the files can be compiled in WebCore.

(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.

WebCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg and Jon Honeycutt.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).

No new tests because no change in behavior.

  • WebCore.vcproj/WebCore.vcproj:
17:04 Changeset [59186] by bdakin@apple.com
  • 3 edits in trunk/WebCore

Small re-factoring patch in preparation for fixing https://
bugs.webkit.org/show_bug.cgi?id=38871 REGRESSION: Crash clicking
background NPR tab after few minutes of sitting idle

Reviewed by Darin Adler.

  • page/Page.cpp:

(WebCore::Page::takeAnyMediaCanStartListener):
(WebCore::Page::setCanStartMedia):

  • page/Page.h:
16:41 Changeset [59185] by ap@apple.com
  • 4 edits
    8 adds in trunk

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=37989
Safari (still) doesn't always send basic credentials preemptively

Test: http/tests/xmlhttprequest/basic-auth-default.html

After fetching credentials from WebCore storage, put them back right away. This will add
default credentials for the directory, since this may be the first time we learn about its
associated protection space.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):
16:41 Changeset [59184] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Load a blank page on creation to initialize WebCore objects properly.
https://bugs.webkit.org/show_bug.cgi?id=38932

16:39 Changeset [59183] by kevino@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Create an NSFont on Mac builds that do not have built-in methods to do so.
https://bugs.webkit.org/show_bug.cgi?id=38931

16:22 Changeset [59182] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests: fix a path-handling bug that was breaking the
dryrun ports on windows, and add a comment about why we don't run
the chromium dryrun tests by default on every port.

https://bugs.webkit.org/show_bug.cgi?id=38796

  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
16:12 Changeset [59181] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

<http://webkit.org/b/38941> build-webkit shouldn't always override ENABLE_FOO Xcode configuration settings

Reviewed by Darin Adler.

  • Scripts/build-webkit: Don't pass the ENABLE setting to xcodebuild if the value matches the default.

This will lead to xcodebuild picking up the settings from FeatureDefines.xcconfig, and will aid in
revealing problems that are due to inconsistent values for settings across projects.

16:11 Changeset [59180] by jianli@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed. Remove unneeded rebaselined result for enter-clicks-buttons.html

  • platform/chromium-win/fast/forms/enter-clicks-buttons-expected.txt: Removed.
16:04 Changeset [59179] by eric@webkit.org
  • 6 edits in trunk

2010-05-11 Avi Drissman <avi@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Pipe RTL info into WebPopupMenuInfo
https://bugs.webkit.org/show_bug.cgi?id=38749

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::menuStyle):
  • platform/chromium/PopupMenuChromium.h:

2010-05-11 Avi Drissman <avi@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Pipe RTL info into WebPopupMenuInfo
https://bugs.webkit.org/show_bug.cgi?id=38749

  • public/WebPopupMenuInfo.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::getPopupMenuInfo):
15:56 Changeset [59178] by alice.liu@apple.com
  • 4 edits in trunk

Fix build error when enabling debugging block in WebKit win painting code

Rubber-stamped by Gavin Barraclough.

JavaScriptCore:

WebKit/win:

  • WebView.cpp:

(WebView::paintIntoBackingStore):

15:43 Changeset [59177] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Build fix.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
15:39 Changeset [59176] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-11 David Holloway <dhollowa@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add size method to WebInputElement class, providing same data
as HTMLInputElement::size(). During form AutoFill Chromium needs to
access the input element's size attribute in aid of form matching and
filling heuristics.

https://bugs.webkit.org/show_bug.cgi?id=38825

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::size):
15:28 Changeset [59175] by alice.liu@apple.com
  • 8 edits in trunk/WebKit/win

https://bugs.webkit.org/show_bug.cgi?id=38937
W7 window preview paints content at the wrong location

Reviewed by Steve Falkenburg.

  • WebFrame.cpp:

(WebFrame::paintDocumentRectToContext): Revert r58895
(WebFrame::paintDocumentRectToContextAtPoint): Added

  • Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint
  • Interfaces/IWebViewPrivate.idl: ditto
  • Interfaces/WebKit.idl: touch to rebuild
  • WebFrame.h: ditto
  • WebView.cpp: ditto

(WebView::paintDocumentRectToContextAtPoint): ditto

  • WebView.h: ditto
15:19 Changeset [59174] by mrowe@apple.com
  • 8 edits in trunk

Fix the world.

In r59162 a change was made to WebCore's FeatureDefines.xcconfig that enabled FILE_READER and FILE_WRITER.
The author and reviewer of that patch ignored the carefully-worded warning at the top of that file asking
that changes to the file be kept in sync across JavaScriptCore, WebCore and WebKit, as well as being kept
in sync with build-webkit. This led to WebCore and WebKit having different views of Document's vtable
and results in crashes in Safari shortly after launch when virtual function calls resulted in the wrong
function in WebCore being called.

We fix this by bringing the FeatureDefines.xcconfig files in to sync. Based on the ChangeLog message and
other changes in r59162 it appears that enabling FILE_WRITER was unintentional so that particular change
has been reverted.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:
15:01 Changeset [59173] by dglazkov@chromium.org
  • 11 edits in trunk

2010-05-11 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
https://bugs.webkit.org/show_bug.cgi?id=38913

Updated the test to include coverage of button elements.

  • fast/forms/enter-clicks-buttons-expected.txt: Updated expectations to account for implicit

submission which now correctly happens from the right element (button).

  • fast/forms/implicit-submission-expected.txt: Updated expectations with new test results.
  • fast/forms/implicit-submission.html: Added tests and code to cover button elements.

2010-05-11 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r58520): Implicit submission on forms with button type="submit" no longer works
https://bugs.webkit.org/show_bug.cgi?id=38913

  • Widened the check for a successful submit button to include all HTMLFormControlElements.
  • Clarified implicit submission code by:
    • introducing HTMLFormControlElement::canTriggerImplicitSubmission flag,
    • getting rid of static casting and checking for tag names.
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::canTriggerImplicitSubmission): Added.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitImplicitly): Renamed parameters for clarity, refactored code

to use canTriggerImplicitSubmission.

  • html/HTMLFormElement.h: Renamed parameter for clarity.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Used canTriggerImplicitSubmission()

instead of isTextField() for clarity.

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::canTriggerImplicitSubmission): Added.
  • html/HTMLIsIndexElement.h: (WebCore::HTMLIsIndexElement::canTriggerImplicitSubmission): Added.
14:35 Changeset [59172] by eric@webkit.org
  • 12 edits
    1 delete in trunk

2010-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59171.
http://trac.webkit.org/changeset/59171
https://bugs.webkit.org/show_bug.cgi?id=38933

"Broke the world" (Requested by bweinstein on #webkit).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/text/AtomicString.cpp: (WebCore::AtomicString::init):
  • wtf/text/StringImpl.cpp: (WebCore::StringImpl::empty):
  • wtf/text/StringStatics.cpp: Removed.

2010-05-11 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59171.
http://trac.webkit.org/changeset/59171
https://bugs.webkit.org/show_bug.cgi?id=38933

"Broke the world" (Requested by bweinstein on #webkit).

  • WebCore.vcproj/WebCore.vcproj:
13:52 Changeset [59171] by bweinstein@apple.com
  • 12 edits
    1 add in trunk

JavaScriptCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

When the String classes were moved from WebCore to WTF, it meant that on Windows, all operations
on Strings in WebCore had to cross a DLL boundary (from WebKit.dll to JavaScript.dll).

We fix this by refactoring some of the WTF string code, so the code in AtomicString, StringImpl, and
WTFString can be built by both WebCore and WTF, and we don't need to talk across a DLL to do operations
on Strings.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove string exports, because these are now

handled in WebCore.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove the post-build step that was added

here (the post build step is in JavaScriptCoreCommon.vsprops).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Copy the three cpp files that need to be compiled

by WebCore into the WebKitOutputDir directory.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Add the StringStatics file.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Add the three WTF string cpp files to this project.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Remove the need to link against WTF.lib (since jsc links against JavaScriptCore).
  • JavaScriptCore.xcodeproj/project.pbxproj: Add the StringStatics file.
  • wtf/text/AtomicString.cpp: Moved code to StringStatics.
  • wtf/text/StringImpl.cpp: Ditto.
  • wtf/text/StringStatics.cpp: Added. Move functions in WTF Strings that define static variables to here, so

the rest of the files can be compiled in WebCore.

(WebCore::StringImpl::empty): Moved from StringImpl.cpp to here.
(WebCore::AtomicString::init): Moved from AtomicString.cpp to here.

WebCore: Patch by Gavin Barraclough.

Reviewed by Steve Falkenburg.

REGRESSION (r57900-57919): 3% PLT Regression from moving strings into WTF.
https://bugs.webkit.org/show_bug.cgi?id=38930
<rdar://problem/7937188>

Add the WTF strings into the WebCore vcproj, from their copied location in $(WebKitOutputDir).

No new tests because no change in behavior.

  • WebCore.vcproj/WebCore.vcproj:
13:38 Changeset [59170] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed test failures seen on SnowLeopard buildbot.

  • runtime/JSString.cpp:

(JSC::JSString::replaceCharacter): Don't use size_t and wtf::notFound.
Instead, use the individual types and notFound values of the string APIs
we're using, since they're not necessarily the same in 64bit.

13:32 Changeset [59169] by japhet@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-11 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Crash fix in WebPageSerializerImpl::serialize().

https://bugs.webkit.org/show_bug.cgi?id=38543

The relevant test is a test_shell_test in src.chromium.org, because neither
DRT nor the Chromium webkit unit tests can currently cover the serializer
functionality.

  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::serialize): Check each frame's url before using it,

since they are not guaranteed to be valid (e.g., if the frame was treated as a download).

13:11 Changeset [59168] by ojan@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-10 Ojan Vafai <ojan@chromium.org>

Reviewed by David Levin.

CheckStyle was eating script errors when there were local-commits and working copy changes
https://bugs.webkit.org/show_bug.cgi?id=38880

  • Scripts/webkitpy/tool/steps/checkstyle.py:
  • Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Added.
12:58 Changeset [59167] by crogers@google.com
  • 2 edits in branches/audio/WebCore

Create a symlink in the built WebCore.framework/Resources to point to audio spatialization files

  • which exist in WebKit/WebCore/audio/AudioSpatialization
  • This is a temporary hack so that people can build WebKit "build-webkit" in my private "audio" branch and then
  • run the "run-safari" script to test out the new audio features.
12:55 Changeset [59166] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed. Fix compiling erron on snow leopard.

  • html/FileThreadTask.h:

(WebCore::createFileThreadTask):

12:48 Changeset [59165] by tonikitoo@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot
https://bugs.webkit.org/show_bug.cgi?id=37334

Rubber-stamped by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Removing unneeded call to LayoutTestController.display(). It was originally intending
to force a layout, but a re-layout will happen regardless because document.body.offsetTop
is called afterwards

  • fast/frames/flattening/frameset-flattening-subframe-resize.html:
  • platform/qt/Skipped:
12:37 Changeset [59164] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip file-reader.html that is not enabled in chromium yet.

  • platform/chromium/test_expectations.txt:
12:20 Changeset [59163] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] emit initialLayoutCompleted signal from FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout
https://bugs.webkit.org/show_bug.cgi?id=38921

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

Emit initialLayoutCompleted signal from FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout
instead of FrameLoaderClientQt::dispatchDidFirstLayout , because the former ensures that a
visual content layed out on the frame.

It matches to QWebFrame::initialLayoutCompleted signal documentation at:

"... This is the first time you will see contents displayed on the frame ..."

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
(WebCore::FrameLoaderClientQt::dispatchDidFirstVisuallyNonEmptyLayout):

12:04 Changeset [59162] by jianli@chromium.org
  • 28 edits
    1 copy
    10 adds in trunk

Expose FileReader interface.
https://bugs.webkit.org/show_bug.cgi?id=38609

Reviewed by Dmitry Titov.

WebCore:

Test: fast/files/file-reader.html

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::convertEventTargetToV8Object):

  • html/FileError.idl:
  • html/FileReader.idl: Added.
  • page/DOMWindow.idl:

WebKit/chromium:

  • features.gypi: turn on building FileReader for Chromium.

WebKitTools:

  • Scripts/build-webkit: turn on building FileReader for Apple's WebKit.

LayoutTests:

Add a layout test to test basic FileReader operations.
Also update layout tests affected by adding the constructors to DOMWindow.

  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/constructed-objects-prototypes.js:
  • fast/dom/script-tests/prototype-inheritance-2.js:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/files/file-reader-expected.txt: Added.
  • fast/files/file-reader.html: Added.
  • fast/files/resources/UTF16BE-BOM.txt: Added.
  • fast/files/resources/UTF16BE.txt: Added.
  • fast/files/resources/UTF16LE-BOM.txt: Added.
  • fast/files/resources/UTF8-BOM.txt: Added.
  • fast/files/resources/UTF8.txt: Added.
  • fast/files/resources/empty-file: Added.
  • fast/js/script-tests/global-constructors.js:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in gtk platform.
  • platform/qt/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in qt platform.
  • platform/win/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in win platform.
11:42 Changeset [59161] by ggaren@apple.com
  • 7 edits in trunk/JavaScriptCore

Start using ropes in String.prototype.replace.

Reviewed by Oliver Hunt and Darin Adler.

1%-1.5% speedup on SunSpider.

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope): Updated for RopeImpl refactoring.

(JSC::JSString::replaceCharacter): Added a replaceCharacter function, which creates
a rope for the resulting replacement.

  • runtime/JSString.h: A few changes here:

(JSC::):
(JSC::RopeBuilder::RopeIterator::RopeIterator):
(JSC::RopeBuilder::RopeIterator::operator++):
(JSC::RopeBuilder::RopeIterator::operator*):
(JSC::RopeBuilder::RopeIterator::operator!=):
(JSC::RopeBuilder::RopeIterator::WorkItem::WorkItem):
(JSC::RopeBuilder::RopeIterator::WorkItem::operator!=):
(JSC::RopeBuilder::RopeIterator::skipRopes): Created a RopeIterator abstraction.
We use this to do a substring find without having to resolve the rope.
(We could use this iterator when resolving ropes, too, but resolving
ropes backwards is usually more efficient.)

(JSC::RopeBuilder::JSString): Added constructors for 2 & 3 UStrings.

(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::size): Updated for RopeImpl refactoring.

  • runtime/Operations.h: Updated for RopeImpl refactoring.

(JSC::jsString): Added jsString functions for 2 & 3 UStrings.

  • runtime/RopeImpl.cpp:

(JSC::RopeImpl::derefFibersNonRecursive):

  • runtime/RopeImpl.h:

(JSC::RopeImpl::initializeFiber):
(JSC::RopeImpl::size):
(JSC::RopeImpl::fibers):
(JSC::RopeImpl::deref):
(JSC::RopeImpl::RopeImpl): A little refactoring to make this patch easier:
Moved statics to the top of the class; put multi-statement functions on
multiple lines; renamed "fiberCount" to "size" to match other collections;
changed the "fibers" accessor to return the fibers buffer, instead of an
item in the buffer, to make iteration easier.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace): Don't resolve a rope unless we need to. Do
use our new replaceCharacter function if possible. Do use a rope to
represent splicing three strings together.

11:35 Changeset [59160] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[chromium] Mark flaky layout tests.

  • platform/chromium/test_expectations.txt:
10:58 Changeset [59159] by jam@chromium.org
  • 1 edit in trunk/WebKit/chromium/src/WebScrollbarImpl.cpp

[chromium] Fix build break on Chromium Mac

10:53 Changeset [59158] by mrobinson@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-05-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Doesn't support gtk-key-themes
https://bugs.webkit.org/show_bug.cgi?id=28257

Add support for GTK+ key themes.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::backspaceCallback): Added. (WebKit::cutClipboardCallback): Added. (WebKit::copyClipboardCallback): Added. (WebKit::pasteClipboardCallback): Added. (WebKit::selectAllCallback): Added. (WebKit::deleteFromCursorCallback): Added. (WebKit::moveCursorCallback): Added. (WebKit::EditorClient::generateEditorCommands): Added. (WebKit::EditorClient::executePendingEditorCommands): Added. (WebKit::EditorClient::handleKeyboardEvent): Derive editor commands both from internal text widget and a list of fallbacks. (WebKit::EditorClient::EditorClient): Add m_nativeWidget initializer.
  • WebCoreSupport/EditorClientGtk.h: (WebKit::EditorClient::addPendingEditorCommand): Add m_nativeWidget member.
10:37 Changeset [59157] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[gtk] critical warning in soup_message_set_first_party() when cancelling a navigation
https://bugs.webkit.org/show_bug.cgi?id=38653

Check if willSendRequest cancelled the request before setting the
first party for the cookies in the message, otherwise we'll get a
critical warning.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
10:11 Changeset [59156] by jam@chromium.org
  • 1 edit in trunk/WebKit/chromium/WebKit.gyp

Check in gyp changes for r59110

09:47 Changeset [59155] by weinig@apple.com
  • 4 edits in trunk/WebCore

REGRESSION (r59001): 11 media tests are failing on Windows (38847)
rdar://problem/7962997
https://bugs.webkit.org/show_bug.cgi?id=38847

Patch by Jer Noble <jer.noble@apple.com> on 2010-05-11
Reviewed by Adele Peterson.

QTMovieWin was too much refactored; the cacheMovieScale() function should have
been left in QTMovie (instead of being moved into QTMovieGWorld). This fixes the
video-size-intrinsic-scale test.

QTMovieTask::updateTaskTimer() was ignoring the maxInterval parameter unless
QTGetTimeUntilNextTask() returned an error, which caused the next timer to be
scheduled for extremely far in the future, breaking some of the layout tests.

QTMovieTask::fireTaskClients() now makes a local copy of the task list before
calling clients, in case one of them removes themselves from the task list and
invalidates our iterating pointer.

  • platform/graphics/win/QTMovie.cpp:

(QTMoviePrivate::task):
(QTMoviePrivate::createMovieController):
(QTMoviePrivate::cacheMovieScale):

  • platform/graphics/win/QTMovieGWorld.cpp:

(QTMovieGWorldPrivate::movieLoadStateChanged):

  • platform/graphics/win/QTMovieTask.cpp:

(QTMovieTask::updateTaskTimer):
(QTMovieTask::fireTaskClients):

09:38 Changeset [59154] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-11 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

Port SharedBuffer to WinCE.
https://bugs.webkit.org/show_bug.cgi?id=37222

Use only functions which are available on Win32 and WinCE.

  • platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
09:14 Changeset [59153] by tkent@chromium.org
  • 1 edit
    2 adds
    6 deletes in trunk/LayoutTests

Merge some pseudo-valid-*.html tests into one.
https://bugs.webkit.org/show_bug.cgi?id=38846

Reviewed by Shinichiro Hamaji.

No additional test cases and no removed test cases.

  • fast/css/pseudo-valid-003-expected.txt: Removed.
  • fast/css/pseudo-valid-003.html: Removed.
  • fast/css/pseudo-valid-005-expected.txt: Removed.
  • fast/css/pseudo-valid-005.html: Removed.
  • fast/css/pseudo-valid-006-expected.txt: Removed.
  • fast/css/pseudo-valid-006.html: Removed.
  • fast/css/pseudo-valid-unapplied-expected.txt: Added.
  • fast/css/pseudo-valid-unapplied.html: Added.
08:45 Changeset [59152] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-05-11 Jesus Sanchez-Palencia <jesus@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Add PageClientQGraphicsWidget specific implementation.
QGraphicsWebViewPrivate doesn't inherit QWebPageClient anymore
and the needed functions were moved to this new PageClient class,
including Tiling and Accelerated Composite specific ones.

[Qt] PageClientQt specific implementation for QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=37866

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::syncLayers): (QGraphicsWebViewPrivate::_q_scaleChanged): (QGraphicsWebView::event): (QGraphicsWebView::setPage): (QGraphicsWebView::updateGeometry): (QGraphicsWebView::setGeometry): (QGraphicsWebView::setResizesToContents):
  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay): (WebCore::PageClientQGraphicsWidget::syncLayers): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer): (WebCore::PageClientQGraphicsWidget::markForSync): (WebCore::PageClientQGraphicsWidget::updateCompositingScrollPosition): (WebCore::PageClientQGraphicsWidget::updateTiledBackingStoreScale): (WebCore::PageClientQGraphicsWidget::setInputMethodEnabled): (WebCore::PageClientQGraphicsWidget::inputMethodEnabled): (WebCore::PageClientQGraphicsWidget::setInputMethodHint): (WebCore::PageClientQGraphicsWidget::cursor): (WebCore::PageClientQGraphicsWidget::updateCursor): (WebCore::PageClientQGraphicsWidget::palette): (WebCore::PageClientQGraphicsWidget::screenNumber): (WebCore::PageClientQGraphicsWidget::ownerWidget): (WebCore::PageClientQGraphicsWidget::geometryRelativeToOwnerWidget): (WebCore::PageClientQGraphicsWidget::pluginParent): (WebCore::PageClientQGraphicsWidget::style):
  • WebCoreSupport/PageClientQt.h: (WebCore::QGraphicsItemOverlay::page): (WebCore::QGraphicsItemOverlay::boundingRect): (WebCore::QGraphicsItemOverlay::paint): (WebCore::QGraphicsItemOverlay::prepareGraphicsItemGeometryChange): (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::isQWidgetClient): (WebCore::PageClientQGraphicsWidget::allowsAcceleratedCompositing): (WebCore::PageClientQGraphicsWidget::):
08:18 QtWebKitTriageRoster edited by laszlo.1.gombos@nokia.com
(diff)
08:15 Changeset [59151] by eric@webkit.org
  • 4 edits in trunk

2010-05-11 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/text/find-hidden-text.html
https://bugs.webkit.org/show_bug.cgi?id=32922

Remove fast/text/find-hidden-text.html from the skipped list of Qt.

  • platform/qt/Skipped:

2010-05-11 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/text/find-hidden-text.html
https://bugs.webkit.org/show_bug.cgi?id=32922

Use the real page step for populating the QStyleOption otherwhise
the size can be negative, which can break the QStyle used.

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
07:15 Changeset [59150] by pfeldman@chromium.org
  • 10 edits in trunk

2010-05-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make styles rendering more user-friendly.

https://bugs.webkit.org/show_bug.cgi?id=36747

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): (WebInspector.ComputedStyleSidebarPane): (WebInspector.StylePropertiesSection): (WebInspector.StylePropertiesSection.prototype.collapse): (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
  • inspector/front-end/inspector.css: (#elements-content): (#elements-sidebar): (.styles-sidebar-separator): (.styles-section): (.styles-section .header): (.styles-section .header .title): (.styles-section .header .subtitle): (.styles-section .header .subtitle a): (.styles-section .properties): (.styles-section.no-affect .properties li): (.styles-section.no-affect .properties li.editing): (.styles-section.expanded .properties): (.styles-section .properties li): (.styles-section .properties li.parent): (.styles-section .properties ol): (.styles-section .properties ol.expanded): (.styles-section .properties li.parent::before): (.styles-section .properties li.parent.expanded::before): (.styles-section .properties li .info): (.styles-section:hover .properties .enabled-button): (.styles-section .properties li.disabled .enabled-button): (.styles-section .properties .enabled-button): (.styles-section .properties .overloaded, .styles-section .properties .disabled): (.styles-section.computed-style .properties .disabled): (.styles-section .properties .implicit, .styles-section .properties .inherited): (.styles-section .properties .inherited): (.styles-section.show-inherited .properties .inherited):
06:09 Changeset [59149] by johnnyg@google.com
  • 3 edits
    7 adds in trunk/LayoutTests

2010-05-11 John Gregg <johnnyg@google.com>

[chromium] Unreviewed, test expectations.

  • platform/chromium-mac/svg/filters/filteredImage-expected.checksum: Added.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/filters/filteredImage-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filteredImage-expected.png: Added.
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png: Added.
  • platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
05:11 Changeset [59148] by zimmermann@webkit.org
  • 13 edits
    10 adds in trunk

2010-05-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs
https://bugs.webkit.org/show_bug.cgi?id=38799

Cleanup SVGRootInlineBox/SVGInlineTextBox. Move buildLayoutInformationForTextBox to SVGInlineTextBox.
Move lots of helper methods into new SVGTextLayoutUtilities class. Adapted all callsites.

Fixed bug in kerning handling, hkern was applyable to vertical text as well. Covered by two new tests.

Tests: svg/text/text-hkern-on-vertical-text.svg

svg/text/text-vkern-on-horizontal-text.svg

  • Android.mk: Add SVGTextLayoutUtilities.cpp/h to build.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): Use textRenderer()->characters() instead of textRenderer()->text()->characters() as shortcut. (WebCore::SVGInlineTextBox::svgCharacterHitsPosition): Fix style issue, no else if after a return branch. (WebCore::SVGInlineTextBox::paintSelection): Use !color.alpha() instead of color.alpha() == 0. (WebCore::SVGInlineTextBox::buildLayoutInformation): Moved from SVGRootInlineBox::buildLayoutInformationForTextBox.
  • rendering/SVGInlineTextBox.h: Fix indention. (WebCore::SVGInlineTextBox::selectionTop): Inlined. (WebCore::SVGInlineTextBox::selectionHeight): Inlined.
  • rendering/SVGRenderTreeAsText.cpp: Include SVGTextLayoutUtilities.h
  • rendering/SVGRootInlineBox.cpp: Move almost all static text layout helper functions in SVGTextLayoutUtilities (WebCore::calculateTextLengthCorrectionForTextChunk): Fixed style issue in long if conditions spanning multiple lines. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Use different topLeftPositionOfCharacterRange() taking start/end iterators. (WebCore::SVGRootInlineBox::buildLayoutInformation): Use the moved SVGInlineTextBox::buildLayoutInformation() method. (WebCore::SVGRootInlineBox::buildTextChunks): Fixed small style issue, remove unneeded parenthesis. (WebCore::SVGRootInlineBox::layoutTextChunks): Fix style issue in debugging code.
  • rendering/SVGRootInlineBox.h: Rename 'LastGlyphInfo' to 'SVGLastGlyphInfo' and move to SVGTextLayoutUtilities. (WebCore::SVGRootInlineBox::svgTextChunks): Inlined for speed.
  • rendering/SVGTextLayoutUtilities.cpp: Added. (WebCore::isVerticalWritingMode): (WebCore::dominantBaselineToShift): (WebCore::alignmentBaselineToShift): (WebCore::glyphOrientationToAngle): (WebCore::glyphOrientationIsMultiplyOf180Degrees): (WebCore::applyGlyphAdvanceAndShiftRespectingOrientation): (WebCore::topLeftPositionOfCharacterRange): (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::cummulatedHeightOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox): (WebCore::calculateCSSKerning): (WebCore::applySVGKerning):
  • rendering/SVGTextLayoutUtilities.h: Added. (WebCore::): (WebCore::SVGTextPaintInfo::SVGTextPaintInfo): (WebCore::SVGLastGlyphInfo::SVGLastGlyphInfo):

2010-05-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Move buildLayoutInformationForTextBox() from SVGRootInlineBox in SVGInlineTextBox where it belongs
https://bugs.webkit.org/show_bug.cgi?id=38799

  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.png: Added.
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.checksum: Added.
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
  • svg/text/text-hkern-on-vertical-text.svg: Added.
  • svg/text/text-vkern-on-horizontal-text.svg: Added.
02:22 Changeset [59147] by zherczeg@webkit.org
  • 4 edits
    5 adds in trunk

WebCore: RenderSVGImage::imageChanged should invalidate the SVG filter cache
https://bugs.webkit.org/show_bug.cgi?id=38838

Reviewed by Dirk Schulze.

Test: svg/filters/filteredImage.svg

  • rendering/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::imageChanged):

LayoutTests: Test case for SVG filter cache invalidation, after an image resource arrives.
https://bugs.webkit.org/show_bug.cgi?id=38838

Reviewed by Dirk Schulze.

  • platform/gtk/Skipped:
  • platform/mac/svg/filters/filteredImage-expected.checksum: Added.
  • platform/mac/svg/filters/filteredImage-expected.png: Added.
  • platform/mac/svg/filters/filteredImage-expected.txt: Added.
  • platform/qt/svg/filters/filteredImage-expected.txt: Added.
  • svg/filters/filteredImage.svg: Added.
01:08 Changeset [59146] by simon.fraser@apple.com
  • 1 edit
    6 adds in trunk/LayoutTests

2010-05-11 Simon Fraser <simon.fraser@apple.com>

Test result fixes for Leopard.

Leopard needs custom results for tests that dump the layer tree, because Leopard
CA does not have geometry flipping, so we do that ourselves by setting a transform.

  • platform/mac-leopard/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/mac-leopard/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
00:24 Changeset [59145] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-10 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] don't build DRT in chromium checkouts due to a circular gyp dependency
https://bugs.webkit.org/show_bug.cgi?id=38889

  • WebKit.gyp:
00:18 Changeset [59144] by johnnyg@google.com
  • 3 edits in trunk/LayoutTests

2010-05-11 John Gregg <johnnyg@google.com>

[chromium] Update win-vista version of the baseline recently updated for win-xp.

  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.txt:

05/10/10:

23:43 Changeset [59143] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Fix asserting GTK build.

r59137 changed the behavior of RenderObject::repaintUsingContainer(). I mistakenly
thought that non-compositing builds would always pass a 0 repaintContainer, but
actually the RenderView is passed in this case. So use this to repaint if
ACCELERATED_COMPOSITING is turned off.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):
23:32 Changeset [59142] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Skip two new flakey tests:

# Tests are flakey: https://bugs.webkit.org/show_bug.cgi?id=38888
compositing/iframes/iframe-resize.html
compositing/iframes/overlapped-iframe.html

  • platform/mac/Skipped:
23:22 Changeset [59141] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2010-05-10 Simon Fraser <simon.fraser@apple.com>

No review; attempt to fix failing tests.

Increase the timeout to give compositing updates a chance to happen.

  • compositing/iframes/iframe-resize.html:
  • compositing/iframes/overlapped-iframe.html:
23:08 QtWebKitTriageRoster edited by hausmann@webkit.org
(diff)
23:06 Changeset [59140] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Fix warning on Windows about unreachable code.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
23:05 Changeset [59139] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2010-05-10 Simon Fraser <simon.fraser@apple.com>

No review.

Reduce timeouts from 500 to 50ms to make the tests run more quickly.

  • compositing/iframes/resources/enter-compositing-subframe.html:
  • compositing/iframes/resources/leave-compositing-subframe.html:
22:47 Changeset [59138] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856

When painting an iframe into a compositing layer, the "PaintBehaviorFlattenCompositingLayers"
flag was mistakenly set, because we'd detect that we were drawing into a bitmap. This caused
content to show up in both compositing layers, and the painted background inside the iframe.

Fix by taking the flattening state from the parent frame, if there is one. For the root
frame, we continue to look to see if we're painting into a bitmap.

  • WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]):
22:47 Changeset [59137] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856

RenderObject::repaintUsingContainer() incorrectly did a view-based
repaint if the repaint container was the RenderView. Instead, we need
to check to see if the RenderView's layer is composited, and, if so,
whether it's painting into the window or not. This can occur when iframes
are composited.

The bug is timing-sensitive, involving compositing in iframes, and I was not able to
concoct a good testcase.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer):
22:44 Changeset [59136] by simon.fraser@apple.com
  • 16 edits
    3 copies
    4 adds
    1 delete in trunk

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856

Changes to allow compositing layers for iframes to switch between being hosted
by the iframe's layer-backed NSView, and parented in the GraphicsLayer tree of the
enclosing document.

Tests: compositing/iframes/connect-compositing-iframe.html

compositing/iframes/connect-compositing-iframe2.html
compositing/iframes/connect-compositing-iframe3.html

  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::hasCompositedContent): New convenience method. (WebCore::FrameView::setIsOverlapped): If we're composited, poke the owner document in case it

wants to re-evaluate compositing decisions.

(WebCore::FrameView::isOverlapped): Just expose the existing flag.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::isSelfPaintingLayer):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): If this is an iframe, we need

to ensure that the layers for the iframe content are hooked up.

(WebCore::RenderLayerBacking::updateDrawsContent): When an iframe toggles between different

attachments, the 'drawsContent' behavior of its root layer changes, so needs to be updated.

  • rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer()

instead of detachRootPlatformLayer() and manually zeroing out the OwnPtrs.

(WebCore::RenderLayerCompositor::updateBacking): If a RenderIFrame changes compositing mode,

we need to ensure that its content compositor attachment is updated.

(WebCore::RenderLayerCompositor::repaintOnCompositingChange): The existing code had a bug

that caused repaints for RenderViews (which have no parent) to bail. We only want to bail
for non-RenderViews that are not attached.

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Factored the iframe-connecting

code into a new method, parentIFrameContentLayers().

(WebCore::RenderLayerCompositor::parentIFrameContentLayers): New method to share the code that hooks

up the iframe's compositing layers to the parent.

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Add logic to propagate

compositing out of iframes on Mac in two situations: 1) when the FrameView is overlapped, and 2)
if the parent document is already composited.

(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Clean up the logic here to better deal

with dynamic changes of the attachment type.

(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Clean up and null out the clipping layer here.
(WebCore::RenderLayerCompositor::attachRootPlatformLayer): Call rootLayerAttachmentChanged().
(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Ditto. Also unparent the clipping and platform layers.
(WebCore::RenderLayerCompositor::updateRootLayerAttachment): Call ensureRootPlatformLayer() to re-evaluate

the layer attachment.

(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged): We need to update the drawsContent() status

of the RenderView's layer's backing, because it changes depending on the attachment.

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Do overlap testing if the frameView can do fast repaints (as before),

but also now when the frameView has composited content.

22:37 Changeset [59135] by dumi@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

Adding a test that makes sure openDatabaseSync() deals correctly with invalid inputs.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Brady Eidson.

  • fast/workers/storage: Added.
  • fast/workers/storage/open-database-sync-inputs-expected.txt: Added.
  • fast/workers/storage/open-database-sync-inputs.html: Added.
  • fast/workers/storage/resources: Added.
  • fast/workers/storage/resources/open-database-sync-inputs.js: Added.

(notAString.toString):

  • fast/workers/storage/resources/test-inputs-common.js: Added.

(log):
(finishTest):
(runTest.worker.onmessage):
(runTest):

22:34 Changeset [59134] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856

Rename the static shouldPropagateCompositingToIFrameParent() to shouldPropagateCompositingToEnclosingIFrame(),
to pave the way for runtime switches in the propagation behavior. We have to make sure we call it on
the correct RenderLayerCompositor (that belonging to the iframe's content document).

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintingGoesToWindow): Now that we know the root layer attachment, we can simplify this method.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): No need for the setNeedsStyleRecalc() here, because the ensureRootPlatformLayer() or destroyRootPlatformLayer() will have already done it.

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Use the root layer attachment to determine
whether to parent the iframe's layers.

(WebCore::RenderLayerCompositor::didMoveOnscreen): Method name change.
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Name change.
(WebCore::RenderLayerCompositor::requiresCompositingForIFrame): We need to consult the iframe contents
document's compositor to ask whether propagation is appropriate.
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Name change.

22:33 Changeset [59133] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856

Use an enum for the type of root layer attachment on a RenderLayerCompositor, so we can
determine if the attachment is via the ChromeClient, via an enclosing iframe, or unattached.

  • rendering/RenderLayerCompositor.h: New RootLayerAttachment enum. (WebCore::RenderLayerCompositor::rootLayerAttachment): getter for the current attachment.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): Init m_rootLayerAttachment. (WebCore::RenderLayerCompositor::~RenderLayerCompositor): Assert that is unattached. (WebCore::RenderLayerCompositor::updateCompositingLayers): Call destroyRootPlatformLayer instead of willMoveOffscreen, when there are no layers left. Also clear out the clipping layer. (WebCore::RenderLayerCompositor::didMoveOnscreen): Call attachRootPlatformLayer. (WebCore::RenderLayerCompositor::willMoveOffscreen): Call ensureRootPlatformLayer with the appropriate attachment. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Only create the m_rootPlatformLayer if we don't have one

already, but be sure to always set the root layer geometry orientation. Also only create the
m_clippingLayer if we need to.

(WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Call detachRootPlatformLayer().
(WebCore::RenderLayerCompositor::attachRootPlatformLayer): Code moved from didMoveOnscreen, but switching on

attachment.

(WebCore::RenderLayerCompositor::detachRootPlatformLayer): Code moved from willMoveOffscreen, but switching on

attachment.

22:27 Changeset [59132] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856

Clean up the geometry logic when propagating compositing out of iframes.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition): Geometry on m_rootPlatformLayer no longer needs to be special when there's a clipping layer.

(WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Don't set the clipping layer to have
flipped geometry ever, and only set the root layer to have flipped geometry if it is not
being hosted in an iframe. Also no need to set a custom anchor point on the clipping layer.

22:22 Changeset [59131] by simon.fraser@apple.com
  • 5 edits in trunk/LayoutTests

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Fix up test results from last commit, which were generated with a build from before r59129.

  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/win/compositing/iframes/iframe-resize-expected.txt:
  • platform/win/compositing/iframes/leave-compositing-iframe-expected.txt:
  • platform/win/compositing/iframes/overlapped-iframe-expected.txt:
22:12 Changeset [59130] by simon.fraser@apple.com
  • 1 edit
    1 copy
    1 move
    11 adds
    1 delete in trunk/LayoutTests

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=38856
Allow compositing layers to be connected across iframe boundaries on Mac

Add several more iframe-compositing-related tests. These tests:

  • an iframe dynamically entering compositing mode
  • an iframe dynamically leaving compositing mode
  • an overlapped iframe
  • a compositing iframe being resized

composited-iframe.html had no value and is removed.

  • compositing/iframes/composited-iframe-expected.txt: Removed.
  • compositing/iframes/composited-iframe.html: Removed.
  • compositing/iframes/enter-compositing-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
  • compositing/iframes/enter-compositing-iframe.html: Added.
  • compositing/iframes/iframe-resize-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
  • compositing/iframes/iframe-resize.html: Added.
  • compositing/iframes/leave-compositing-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
  • compositing/iframes/leave-compositing-iframe.html: Added.
  • compositing/iframes/overlapped-iframe-expected.txt: Copied from LayoutTests/platform/mac/compositing/iframes/composited-iframe-expected.txt.
  • compositing/iframes/overlapped-iframe.html: Added.
  • compositing/iframes/resources/enter-compositing-subframe.html: Added.
  • compositing/iframes/resources/leave-compositing-subframe.html: Added.
  • platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/win/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.
22:08 Changeset [59129] by simon.fraser@apple.com
  • 5 edits in trunk/WebCore

2010-05-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

Allow compositing layers to be connected across iframe boundaries on Mac
https://bugs.webkit.org/show_bug.cgi?id=38856

Clean up some methods related to composited iframes. No behavioral changes.

  • rendering/RenderLayerBacking.h: Move innerRenderLayerCompositor() to be a static method:

RenderLayerCompositor::iframeContentsCompositor().

  • rendering/RenderLayerBacking.cpp: Remove innerRenderLayerCompositor(). (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Call iframeContentsCompositor().
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enableCompositingMode): Call enclosingIFrameElement() (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): iframeContentsCompositor() is now a static method in this class. Also check that the iframe contents are in compositing mode (slightly clearer than relying on rootPlatformLayer() returning null). (WebCore::RenderLayerCompositor::iframeContentsCompositor): Moved from RenderLayerBacking. (WebCore::RenderLayerCompositor::didMoveOnscreen): Use enclosingIFrameElement() method. (WebCore::RenderLayerCompositor::willMoveOffscreen): Ditto. (WebCore::RenderLayerCompositor::enclosingIFrameElement): New method. (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Call enclosingIFrameElement().
  • rendering/RenderLayerCompositor.h: New method, iframeContentsCompositor().
22:06 Changeset [59128] by johnnyg@google.com
  • 2 edits
    2 adds in trunk/LayoutTests

2010-05-10 John Gregg <johnnyg@google.com>

[chromium] Final set of baselines and expectations to green up the build.

  • platform/chromium-mac/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
  • platform/chromium-win/plugins/geturlnotify-during-document-teardown-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
21:49 Changeset [59127] by johnnyg@google.com
  • 114 edits
    4 adds in trunk/LayoutTests

2010-05-10 John Gregg <johnnyg@google.com>

[chromium] rebaseline SVG test for windows after recent changes.

  • platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.txt:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.checksum:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.txt:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/custom/empty-mask-expected.txt:
  • platform/chromium-win/svg/custom/empty-merge-expected.checksum:
  • platform/chromium-win/svg/custom/empty-merge-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/chromium-win/svg/custom/feDisplacementMap-01-expected.checksum:
  • platform/chromium-win/svg/custom/feDisplacementMap-01-expected.png:
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.checksum:
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/chromium-win/svg/custom/invalid-css-expected.txt:
  • platform/chromium-win/svg/custom/mask-invalidation-expected.txt:
  • platform/chromium-win/svg/custom/non-opaque-filters-expected.txt:
  • platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.checksum:
  • platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium-win/svg/custom/text-filter-expected.checksum:
  • platform/chromium-win/svg/custom/text-filter-expected.png:
  • platform/chromium-win/svg/custom/text-filter-expected.txt:
  • platform/chromium-win/svg/custom/visibility-override-filter-expected.checksum:
  • platform/chromium-win/svg/custom/visibility-override-filter-expected.png:
  • platform/chromium-win/svg/filters/big-sized-filter-2-expected.checksum:
  • platform/chromium-win/svg/filters/big-sized-filter-2-expected.png:
  • platform/chromium-win/svg/filters/big-sized-filter-expected.checksum:
  • platform/chromium-win/svg/filters/big-sized-filter-expected.png:
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum:
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.png:
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
  • platform/chromium-win/svg/filters/feComposite-expected.checksum:
  • platform/chromium-win/svg/filters/feComposite-expected.png:
  • platform/chromium-win/svg/filters/feComposite-expected.txt:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-win/svg/filters/feMerge-expected.checksum:
  • platform/chromium-win/svg/filters/feMerge-expected.png:
  • platform/chromium-win/svg/filters/feOffset-expected.checksum:
  • platform/chromium-win/svg/filters/feOffset-expected.png:
  • platform/chromium-win/svg/filters/feTile-expected.checksum:
  • platform/chromium-win/svg/filters/feTile-expected.png:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.checksum:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
  • platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.checksum:
  • platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.png:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.checksum:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.checksum:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-win/svg/text/text-vkern-expected.checksum: Added.
  • platform/chromium-win/svg/text/text-vkern-expected.png: Added.
21:12 Changeset [59126] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing the expectations for Chromium.

  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
20:51 Changeset [59125] by timothy@apple.com
  • 3 edits in trunk/WebKit/mac

Fix a crash when closing a WebView while the Web Inspector is open.

<rdar://problem/7966830>

Reviewed by Mark Rowe.

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController destroyInspectorView]): Null check Page since it can be null.

  • WebView/WebView.mm:

(-[WebView _close]): Null out _private->page before deleting the page, so code called
during destruction don't access a half deleted Page object.

20:45 Changeset [59124] by tony@chromium.org
  • 6 edits
    1 add
    1 delete in trunk

2010-05-10 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Build DRT when running build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=38730

This allows DRT to use the same .o and .lib files when building
on Windows.

  • WebKit.gyp: Move DRT.gyp targets into this file.
  • gyp_webkit: DRT.gyp is gone

2010-05-10 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Build DRT when running build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=38730

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
  • Scripts/build-dumprendertree: This does nothing now.
20:40 Changeset [59123] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-10 Eric Seidel <eric@webkit.org>

Unreviewed, just removing newline from -expected.txt file

REGRESSION(r59100): "Added test is broken on many platforms." (Requested by eseidel on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=38881

Looks like http://trac.webkit.org/changeset/59119
added an extra newline by mistake. Removing.

  • plugins/geturlnotify-during-document-teardown-expected.txt:
19:54 Changeset [59122] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing Qt's expectations.

  • platform/qt/http/tests/security/cross-frame-access-call-expected.txt:
19:39 Changeset [59121] by abarth@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Remove conflict markers from ChangeLog

19:35 Changeset [59120] by jhoneycutt@apple.com
  • 3 edits in trunk/LayoutTests

REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881

Reviewed by Eric Seidel.

  • platform/mac-snowleopard/Skipped:

Skipped, because we're not logging NPP_Destroy on Snow Leopard.

  • platform/qt/Skipped:

Skipped due to lack of support for setCallCloseOnWebViews on
LayoutTestController.

19:35 Changeset [59119] by jhoneycutt@apple.com
  • 4 edits in trunk

REGRESSION(r59100): Added test is broken on many platforms.
https://bugs.webkit.org/show_bug.cgi?id=38881

Reviewed by Eric Seidel.

WebKitTools:

  • DumpRenderTree/win/TestNetscapePlugin/main.cpp:

(NPP_Destroy):
Use pluginLog, rather than printf, to match other platforms.

LayoutTests:

  • plugins/geturlnotify-during-document-teardown-expected.txt:

Update the expected result.

19:06 Changeset [59118] by dumi@chromium.org
  • 7 edits
    1 move
    3 adds
    2 deletes in trunk

WebCore: Cleaning up and fixing the existing JSC DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Brady Eidson.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabase::transaction):
(WebCore::JSDatabase::readTransaction):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

LayoutTests: Fixing the expectations for openDatabase() in cross-frame-access-call.html.
Related to changes in patches #6 and #7 at https://bugs.webkit.org/show_bug.cgi?id=34994.

Reviewed by Brady Eidson.

  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • platform/chromium-linux/http/tests/security/cross-frame-access-call-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-call-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt: Removed.
  • platform/chromium/http: Added.
  • platform/chromium/http/tests: Added.
  • platform/chromium/http/tests/security: Added.
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt: Copied from LayoutTests/platform/chromium-win/http/tests/security/cross-frame-access-call-expected.txt.
18:52 Changeset [59117] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-10 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix a build failure caused by assuming the default platform in
a unit test for new-run-webkit-tests instead of specifying
--platform test.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
18:50 Changeset [59116] by ukai@chromium.org
  • 9 edits in trunk/WebCore

2010-05-10 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket needs to suspend/resume as Active DOM object.
https://bugs.webkit.org/show_bug.cgi?id=38171

Implement suspend()/resume() in WebSocket and WebSocketChannel.
While WebSocketChannel is suspended, it only adds received data in m_buffer
or record the handle was closed, and report no event to WebSocket.
When resumed, it will process buffer or handle closing.
Since suspend/resume would be called while processing JavaScript event handler (e.g. before/after alert()), WebSocketChannel method that would fire an event need to be reentrant.
So, WebSocketChannel::processBuffer() call WebSocket to fire an event at most once and skips buffer before the calling,
so that next call of processBuffer() would process the next frame.

  • websockets/ThreadableWebSocketChannel.h:
  • websockets/ThreadableWebSocketChannelClientWrapper.h: (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect): Mark channel is opened, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage): Push message back in pending queue, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::didClose): Mark channel is closed, and process pending events if not suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::suspend): Mark suspended. (WebCore::ThreadableWebSocketChannelClientWrapper::resume): Unmark suspended, and process pending events. (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper): (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingEvents):
  • websockets/WebSocket.cpp: (WebCore::WebSocket::canSuspend): (WebCore::WebSocket::suspend): (WebCore::WebSocket::resume): (WebCore::WebSocket::didClose):
  • websockets/WebSocket.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::connect): (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::bufferedAmount): (WebCore::WebSocketChannel::close): (WebCore::WebSocketChannel::suspend): (WebCore::WebSocketChannel::resume): When resumed, it will process buffer and handle closing if handle was already closed while suspended. (WebCore::WebSocketChannel::didClose): If suspended, record unhandled bufferedAmount and set m_closed true, so that closing will be processed when resumed. (WebCore::WebSocketChannel::didReceiveData): Add received data in buffer and process buffer while it is not suspended. (WebCore::WebSocketChannel::processBuffer): Process handshake header or one frame message. Return true if there are more data to be processed. Return false otherwise (e.g. incomplete handshake header or incomplete frame).
  • websockets/WebSocketChannel.h:
  • websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::suspend): (WebCore::WorkerThreadableWebSocketChannel::resume): (WebCore::WorkerThreadableWebSocketChannel::Peer::suspend): (WebCore::WorkerThreadableWebSocketChannel::Peer::resume): (WebCore::WorkerThreadableWebSocketChannel::mainThreadSuspend): (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend): (WebCore::WorkerThreadableWebSocketChannel::mainThreadResume): (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
  • websockets/WorkerThreadableWebSocketChannel.h:
18:45 Changeset [59115] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

2010-05-10 John Gregg <johnnyg@google.com>

[chromium] Fix sort order for expectations after previous change.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
18:30 Changeset [59114] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-10 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build-fix

new-run-webkit-tests: fix test failure caused by me failing to update
the expected output. Also, run '--platform test' instead of
'platform dryrun' since the former is guaranteed to work and the
latter isn't.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
18:18 Changeset [59113] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Implement the JSC bindings for the sync DB API.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Brady Eidson.

  • bindings/js/JSDatabaseSyncCustom.cpp:

(WebCore::JSDatabaseSync::changeVersion):
(WebCore::createTransaction):

  • bindings/js/JSSQLTransactionSyncCustom.cpp:

(WebCore::JSSQLTransactionSync::executeSql):

18:07 Changeset [59112] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

2010-05-10 John Gregg <johnnyg@google.com>

[chromium] Unreviewed, test expectation change for Chromium following r59010.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
17:44 Changeset [59111] by dino@apple.com
  • 4 edits
    2 adds in trunk

2010-05-10 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=36566
The animation-fill-mode property was missing from
a few places where the animation shorthand is set up.

Test: animations/animation-shorthand-removed.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Make sure animation-fill-mode is included in the animation shorthand
  • css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
17:10 Changeset [59110] by jam@chromium.org
  • 5 edits
    4 adds in trunk/WebKit/chromium

2010-05-10 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add WebKitScrollbar interface to allow Chromium code to reuse the scrollbar code
https://bugs.webkit.org/show_bug.cgi?id=38854

  • public/WebScrollbar.h: Added. (WebKit::WebScrollbar::): (WebKit::WebScrollbar::~WebScrollbar):
  • public/WebScrollbarClient.h: Added.
  • public/WebThemeEngine.h:
  • src/AssertMatchingEnums.cpp:
  • src/WebScrollbarImpl.cpp: Added. (WebKit::WebScrollbar::create): (WebKit::WebScrollbar::defaultThickness): (WebKit::WebScrollbarImpl::WebScrollbarImpl): (WebKit::WebScrollbarImpl::~WebScrollbarImpl): (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::value): (WebKit::WebScrollbarImpl::setValue): (WebKit::WebScrollbarImpl::setDocumentSize): (WebKit::WebScrollbarImpl::scroll): (WebKit::WebScrollbarImpl::paint): (WebKit::WebScrollbarImpl::handleInputEvent): (WebKit::WebScrollbarImpl::onMouseDown): (WebKit::WebScrollbarImpl::onMouseUp): (WebKit::WebScrollbarImpl::onMouseMove): (WebKit::WebScrollbarImpl::onMouseLeave): (WebKit::WebScrollbarImpl::onMouseWheel): (WebKit::WebScrollbarImpl::onKeyDown): (WebKit::WebScrollbarImpl::valueChanged): (WebKit::WebScrollbarImpl::invalidateScrollbarRect): (WebKit::WebScrollbarImpl::isActive): (WebKit::WebScrollbarImpl::scrollbarCornerPresent): (WebKit::WebScrollbarImpl::getTickmarks):
  • src/WebScrollbarImpl.h: Added.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollViewWithKeyboard): (WebKit::WebViewImpl::mapKeyCodeForScroll):
  • src/WebViewImpl.h:
17:08 Changeset [59109] by weinig@apple.com
  • 5 edits
    2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.

Reviewed by Darin Adler.

Test: fast/dom/Element/normalize-crash.html

  • dom/Element.cpp:

(WebCore::Element::normalizeAttributes): Copy attributes to a vector
before iterating.

  • dom/NamedAttrMap.cpp:

(WebCore::NamedNodeMap::copyAttributesToVector): Added.

  • dom/NamedAttrMap.h:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=38583
<rdar://problem/7948784> Crash in Element::normalizeAttributes.

Reviewed by Darin Adler.

  • fast/dom/Element/normalize-crash-expected.txt: Added.
  • fast/dom/Element/normalize-crash.html: Added.
17:01 Changeset [59108] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by David Levin.

new-run-webkit-tests: looks like the unicode conversion broke
--print-last-failures and --retest-last-failures. Fixing.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
17:00 Changeset [59107] by crogers@google.com
  • 12 edits
    1 copy
    2 adds in branches/audio/WebCore

Hook the realtime analyser into the modular routing API

17:00 Changeset [59106] by dpranke@chromium.org
  • 6 edits in trunk/WebKitTools

2010-05-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by David Levin.

Re-attempt to fix 38616 - newline handling in new-run-webkit-tests.
I didn't handle some cases correctly before and the solution was
confusing. The new patch assumes all calls to the printing module
don't have newlines, and will append newlines where necessary, just
like logging does.

https://bugs.webkit.org/show_bug.cgi?id=38790

  • Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  • Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
16:58 Changeset [59105] by johnnyg@google.com
  • 46 edits
    59 adds
    6 deletes in trunk/LayoutTests

2010-05-10 John Gregg <johnnyg@google.com>

[chromium] Unreviewed, svg test rebaselines after r59002 for linux.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.checksum:
  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.txt: Added.
  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png: Added.
  • platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png: Added.
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textProperties-expected.txt: Added.
  • platform/chromium-linux/svg/custom/empty-mask-expected.txt: Added.
  • platform/chromium-linux/svg/custom/empty-merge-expected.checksum:
  • platform/chromium-linux/svg/custom/empty-merge-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.txt: Added.
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.txt: Added.
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.txt: Added.
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.txt: Added.
  • platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.checksum:
  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.checksum:
  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.png: Removed.
  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/chromium-linux/svg/custom/invalid-css-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mask-invalidation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/non-opaque-filters-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-filter-expected.checksum:
  • platform/chromium-linux/svg/custom/text-filter-expected.png: Removed.
  • platform/chromium-linux/svg/custom/text-filter-expected.txt: Added.
  • platform/chromium-linux/svg/custom/visibility-override-filter-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/big-sized-filter-2-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Added.
  • platform/chromium-linux/svg/filters/big-sized-filter-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/big-sized-filter-expected.png: Added.
  • platform/chromium-linux/svg/filters/feColorMatrix-values-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/chromium-linux/svg/filters/feColorMatrix-values-expected.txt: Added.
  • platform/chromium-linux/svg/filters/feComposite-expected.checksum:
  • platform/chromium-linux/svg/filters/feComposite-expected.png: Removed.
  • platform/chromium-linux/svg/filters/feComposite-expected.txt: Added.
  • platform/chromium-linux/svg/filters/feGaussianBlur-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/feMerge-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/feMerge-expected.png: Added.
  • platform/chromium-linux/svg/filters/feOffset-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/feTile-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/feTile-expected.png: Added.
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.checksum:
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.png: Removed.
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.txt: Added.
  • platform/chromium-linux/svg/filters/sourceAlpha-expected.txt: Added.
  • platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.png: Added.
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.checksum:
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png: Removed.
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.checksum:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png: Removed.
  • platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added.
  • platform/chromium-linux/svg/text/text-vkern-expected.png: Added.
16:38 Changeset [59104] by jianli@chromium.org
  • 5 edits in trunk/WebCore

[V8] Fix V8 code generator script to generate the correct code for
converting ScriptString.
https://bugs.webkit.org/show_bug.cgi?id=38873

Reviewed by Adam Barth.

Updated the bindings test result. Note that the result is also updated
to reflect other script generator changes not introduced by this patch.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):

  • bindings/scripts/test/JS/JSTestCallback.h:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::scriptStringAttrAttrGetter):

16:35 Changeset [59103] by jhoneycutt@apple.com
  • 2 edits in trunk/LayoutTests

Add test to GTK skipped list.

Rubber-stamped by Mark Rowe.

  • platform/gtk/Skipped:
16:14 Changeset [59102] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the 32-bit WebKit2 build.

  • WebCore.base.exp:
16:13 WebKit Team edited by tkent@chromium.org
Move tkent to the reviewers section (diff)
16:02 Changeset [59101] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-10 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

Make tkent a reviewer
https://bugs.webkit.org/show_bug.cgi?id=38875

  • Scripts/webkitpy/common/config/committers.py:
15:56 Changeset [59100] by jhoneycutt@apple.com
  • 7 edits
    3 adds in trunk

Crash closing window containing Flash plug-in
https://bugs.webkit.org/show_bug.cgi?id=38797
<rdar://problem/7935266>

Reviewed by Eric Seidel.

WebCore:

Test: plugins/geturlnotify-during-document-teardown.html

  • plugins/PluginView.cpp:

(WebCore::PluginView::load):
Null check the DocumentLoader; it's possible for this to be null while
the Document is being torn down and before the plug-in is destroyed.

WebKitTools:

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:

(pluginAllocate):
Initialize new member to false.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:

Added a new member.

  • DumpRenderTree/win/TestNetscapePlugin/main.cpp:

(NPP_New):
Check whether the element has the "testGetURLOnDestroy" attribute, and
record that.
(NPP_Destroy):
If "testGetURLOnDestroy" is set, perform a load while destroying the
plug-in.

LayoutTests:

  • plugins/geturlnotify-during-document-teardown.html: Added.
  • plugins/resources/geturlnotify-on-destroy.html: Added.
15:48 Changeset [59099] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-10 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Executive.kill_* do not work with windows python
https://bugs.webkit.org/show_bug.cgi?id=38872

http://trac.webkit.org/changeset/57444 is where the original
breakage occurred.
http://trac.webkit.org/changeset/58314 is where the regression
started affecting chromium.

I have since learned that sys.platform has no "windows" value.
"win32" is always the value, under 32 or 64 bit windows

The tests for this code are not run anywhere because
test-webkitpy does not yet work on "win32". Mostly due to
depending on unixisms like "cat" and "yes".

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
15:13 Changeset [59098] by ap@apple.com
  • 7 edits
    2 adds in trunk

Reviewed by Darin Adler.

Based on a patch by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=28697
<rdar://problem/7946578> WebKit crash on WebCore::Node::nodeIndex()

It's not OK to call ContainerNode::willRemoveChild() in a loop, because Range code assumes
that it can adjust start and end position to any node except for the one being removed -
so these notifications cannot be batched.

Test: fast/dom/Range/remove-all-children-crash.html

  • dom/ContainerNode.cpp: (WebCore::willRemoveChild): Removed unused ExceptionCode. (WebCore::willRemoveChildren): New function, used in removeChildren() case. (WebCore::ContainerNode::removeChild): ExceptionCode return was always 0, don't bother with it. (WebCore::ContainerNode::removeChildren): Call willRemoveChildrenFromNode. (WebCore::dispatchChildRemovalEvents): Moved some logic out into willRemoveChildrenFromNode and willRemoveChild.
  • dom/Document.cpp: (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
  • dom/Document.h: (WebCore::Document::nodeChildrenWillBeRemoved): New function, used in removeChildren() case.
  • dom/Range.h:
  • dom/Range.cpp: (WebCore::boundaryNodeChildrenWillBeRemoved): New function, used in removeChildren() case. (WebCore::Range::nodeChildrenWillBeRemoved): Ditto.
14:44 Changeset [59097] by crogers@google.com
  • 6 edits
    1 add in branches/audio/WebCore

Add custom bindings for attributes which are custom JS objects to avoid compiler warnings/errors

  • this is a problem which seems to only occur with the JS (not V8) bindings
  • JSAudioMiscCustom.cpp may be temporary until these can be split out into separate files (if necessary)
14:34 Changeset [59096] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Implement the V8 bindings for the sync DB API.
https://bugs.webkit.org.show_bug.cgi?id=34994

Reviewed by Adam Barth.

  • bindings/v8/custom/V8DatabaseSyncCustom.cpp:

(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContextCustom::openDatabaseSyncCallback):

13:46 Changeset [59095] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Clean up and fix the existing V8 DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Adam Barth.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • bindings/v8/custom/V8DatabaseCustom.cpp:

(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

13:03 Changeset [59094] by kevino@webkit.org
  • 3 edits in trunk/WebCore

[wx] Build fix for wx 2.8 after complex text changes.

12:59 Changeset [59093] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Unbreak the world. (Fix Mac builds).

  • Plugins/Hosted/WebKitPluginHostTypes.h:
12:53 Changeset [59092] by dpranke@chromium.org
  • 59 edits
    2 copies
    4 adds in trunk/LayoutTests

2010-05-07 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Add a bunch of windows-specific chromium baselines for the different
versions of windows to update them from a skia change.

https://bugs.webkit.org/show_bug.cgi?id=38784

  • platform/chromium/test_expectations.txt:
12:47 Changeset [59091] by dpranke@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Fix a bug in rebaseline-chromium-webkit-tests where we would crash
instead of logging an error and exiting if it couldn't find either a
debug or a release build of the image diff binary.

https://bugs.webkit.org/show_bug.cgi?id=38692

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Added.
12:46 Changeset [59090] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests fails when run under sys.platform == "windows" due to undefined signal.SIGKILL
https://bugs.webkit.org/show_bug.cgi?id=38861

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
12:36 Changeset [59089] by johnnyg@google.com
  • 2 edits in trunk/WebCore

2010-05-10 John Gregg <johnnyg@google.com>

[chromium] Try to fix the chromium build after r59085 by
including MathExtras.h before using isnan().
https://bugs.webkit.org/show_bug.cgi?id=38860

  • html/canvas/WebGLIntegralTypedArrayBase.h:
11:59 Changeset [59088] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix for wx trunk after complex text changes.

11:14 Changeset [59087] by eric@webkit.org
  • 15 edits
    1 add in trunk

2010-05-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Provide mechanism to cache metadata for a resource
https://bugs.webkit.org/show_bug.cgi?id=37874

No new tests because no new functionality.

  • WebCore.gypi:
  • loader/CachedMetadata.h: Added. (WebCore::CachedMetadata::create): (WebCore::CachedMetadata::deserialize): (WebCore::CachedMetadata::serialize): (WebCore::CachedMetadata::~CachedMetadata): (WebCore::CachedMetadata::dataTypeID): (WebCore::CachedMetadata::data): (WebCore::CachedMetadata::size): (WebCore::CachedMetadata::readUnsigned): (WebCore::CachedMetadata::appendUnsigned): (WebCore::CachedMetadata::CachedMetadata):
  • loader/CachedResource.cpp: (WebCore::CachedResource::setSerializedCachedMetadata): (WebCore::CachedResource::setCachedMetadata): (WebCore::CachedResource::cachedMetadata):
  • loader/CachedResource.h:
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveCachedMetadata):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveCachedMetadata):
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
  • loader/loader.cpp: (WebCore::Loader::Host::didReceiveCachedMetadata):
  • loader/loader.h:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveCachedMetadata):

2010-05-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Provide mechanism to cache metadata for a resource
https://bugs.webkit.org/show_bug.cgi?id=37874

  • src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
11:12 Changeset [59086] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Change the order of the RendererType enum values, so that old versions of WebKitPluginHost will
use accelerated compositing and not layer backed views.

Reviewed by Simon Fraser.

  • Plugins/Hosted/WebKitPluginHostTypes.h:
10:53 Changeset [59085] by kbr@google.com
  • 18 edits
    2 adds in trunk/WebCore

2010-05-09 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Refactor WebGLArray types to share more code
https://bugs.webkit.org/show_bug.cgi?id=37712

Refactored WebGLArray types for maximal code sharing. Added
WebGLTypedArrayBase and WebGLIntegralTypedArrayBase template
superclasses. Changed overridden virtuals to have minimal
visibility (private instead of public). Fixed const correctness of
a few methods. There are no changes to the public APIs of the
WebGLArray classes; the JavaScript bindings are unchanged.

No new tests; existing tests cover this functionality. Ran all
WebGL layout tests in Safari and Chromium on Mac OS X.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGLArray.h: (WebCore::WebGLArray::buffer): (WebCore::WebGLArray::baseAddress): (WebCore::WebGLArray::byteOffset):
  • html/canvas/WebGLByteArray.cpp: (WebCore::WebGLByteArray::create): (WebCore::WebGLByteArray::WebGLByteArray): (WebCore::WebGLByteArray::slice):
  • html/canvas/WebGLByteArray.h: (WebCore::WebGLByteArray::isByteArray):
  • html/canvas/WebGLFloatArray.cpp: (WebCore::WebGLFloatArray::create): (WebCore::WebGLFloatArray::WebGLFloatArray): (WebCore::WebGLFloatArray::slice):
  • html/canvas/WebGLFloatArray.h: (WebCore::WebGLFloatArray::set): (WebCore::WebGLFloatArray::item): (WebCore::WebGLFloatArray::isFloatArray):
  • html/canvas/WebGLIntArray.cpp: (WebCore::WebGLIntArray::create): (WebCore::WebGLIntArray::WebGLIntArray): (WebCore::WebGLIntArray::slice):
  • html/canvas/WebGLIntArray.h: (WebCore::WebGLIntArray::isIntArray):
  • html/canvas/WebGLIntegralTypedArrayBase.h: Added. (WebCore::WebGLIntegralTypedArrayBase::set): (WebCore::WebGLIntegralTypedArrayBase::item): (WebCore::WebGLIntegralTypedArrayBase::WebGLIntegralTypedArrayBase):
  • html/canvas/WebGLShortArray.cpp: (WebCore::WebGLShortArray::create): (WebCore::WebGLShortArray::WebGLShortArray): (WebCore::WebGLShortArray::slice):
  • html/canvas/WebGLShortArray.h: (WebCore::WebGLShortArray::isShortArray):
  • html/canvas/WebGLTypedArrayBase.h: Added. (WebCore::WebGLTypedArrayBase::data): (WebCore::WebGLTypedArrayBase::set): (WebCore::WebGLTypedArrayBase::length): (WebCore::WebGLTypedArrayBase::WebGLTypedArrayBase): (WebCore::WebGLTypedArrayBase::create): (WebCore::WebGLTypedArrayBase::sliceImpl): (WebCore::WebGLTypedArrayBase::byteLength):
  • html/canvas/WebGLUnsignedByteArray.cpp: (WebCore::WebGLUnsignedByteArray::create): (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray): (WebCore::WebGLUnsignedByteArray::slice):
  • html/canvas/WebGLUnsignedByteArray.h: (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
  • html/canvas/WebGLUnsignedIntArray.cpp: (WebCore::WebGLUnsignedIntArray::create): (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray): (WebCore::WebGLUnsignedIntArray::slice):
  • html/canvas/WebGLUnsignedIntArray.h: (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
  • html/canvas/WebGLUnsignedShortArray.cpp: (WebCore::WebGLUnsignedShortArray::create): (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray): (WebCore::WebGLUnsignedShortArray::slice):
  • html/canvas/WebGLUnsignedShortArray.h: (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
10:25 Changeset [59084] by jer.noble@apple.com
  • 2 edits in trunk/WebKitTools

Unreviewed.

Adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
10:12 Changeset [59083] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Build fix, not reviewed.

Correct post-build copy command for WinCairo port to make sure
cairo headers are available for WebKit.dll build.

  • WebCore.vcproj/WebCore.vcproj:
09:23 Changeset [59082] by krit@webkit.org
  • 7 edits in trunk/LayoutTests

2010-05-10 Dirk Schulze <krit@webkit.org>

Unreviewed.

Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820


New baseline for Qt.

  • platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/qt/svg/css/mask-with-shadow-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/mask-invalidation-expected.txt:
  • platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/qt/svg/custom/transformedMaskFails-expected.txt:
08:59 Changeset [59081] by krit@webkit.org
  • 26 edits in trunk

2010-05-10 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820


This is a further optimization to get smaller repaintRects on SVG objects
in combination with masker or clipper resources.
Masker takes the unite of all stroke boundaries of it's childs.
Both, clipper and masker, store this union to avoid multiple calls of the childs
and the unite calculations now.
The unite rect can be transformed to any targets objectBoundingBox, if the content
unit of the resource is set to objectBoundingBoxMode.
This speeds up the use of resources with multiple target objects.


No behavior changes, the smaller repaintRects cause updates for DRT results.

  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::invalidateClients): (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClients): (WebCore::RenderSVGResourceMasker::createMaskImage): (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect): (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):

2010-05-10 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Further optimization for SVG's repaintRect calculation
https://bugs.webkit.org/show_bug.cgi?id=38820


The repaintRect of SVG objects with masks got smaller. This made
updates of some results necessary.

  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
  • platform/mac/svg/css/mask-with-shadow-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
  • platform/mac/svg/custom/mask-inside-defs-expected.txt:
  • platform/mac/svg/custom/mask-invalidation-expected.txt:
  • platform/mac/svg/custom/mask-with-all-units-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/visibility-override-mask-expected.txt:
  • svg/custom/transformedMaskFails-expected.txt:
08:21 Changeset [59080] by loislo@chromium.org
  • 3 edits in trunk/WebCore

2010-05-11 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Cosmetic changes.
1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
2) Standard tooltips for resource links are clashing with Popover.
3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
https://bugs.webkit.org/show_bug.cgi?id=38732

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
  • inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
07:48 Changeset [59079] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-05-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Layout test for Session Storage quota should only expect to fit 39 objects.
https://bugs.webkit.org/show_bug.cgi?id=38843

The script should be ready for the exception when inserting the 40th
element, as that is where it will be thrown if a quota is enforced.
This is the same change as in http://trac.webkit.org/changeset/50979.

  • storage/domstorage/quota-expected.txt:
  • storage/domstorage/script-tests/quota.js: (testNoQuota):
07:36 Changeset [59078] by agl@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

2010-05-10 Adam Langley <agl@chromium.org>

Expectations change. Not reviewed.

Delete the current baselines for the WOFF test because they are
incomplete.

Remove the SKIP tag from test_expectations so that the builders
will run the test and then the rebaseline tool can be used to
checkin real baselines.

  • platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Removed.
  • platform/chromium-win/fast/css/font-face-woff-expected.checksum: Removed.
  • platform/chromium-win/fast/css/font-face-woff-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
07:27 Changeset [59077] by eric@webkit.org
  • 7 edits in trunk

2010-05-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
https://bugs.webkit.org/show_bug.cgi?id=38750

Put a per-origin quota on session storage since it is using memory in
the browser process, and should not be allowed to grow arbitrarily
large. See also http://trac.webkit.org/changeset/58828.

  • public/WebStorageNamespace.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::createSessionStorageNamespace):
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):

2010-05-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
https://bugs.webkit.org/show_bug.cgi?id=38750

Put a per-origin quota on session storage since it is using memory in
the browser process, and should not be allowed to grow arbitrarily
large. See also http://trac.webkit.org/changeset/58828.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createSessionStorageNamespace):
  • DumpRenderTree/chromium/WebViewHost.h:
07:03 Changeset [59076] by ossy@webkit.org
  • 7 edits
    1 delete in trunk

[Qt] Roll-out r59020 and r59021, because the Qt part of these changes
haven't been landed in Qt trunk yet. Should be rolled-in again after the merge.

Rubber-stamped by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=32967

WebCore:

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::DumpRenderTree):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

LayoutTests:

  • platform/qt/Skipped:
  • platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Removed.
06:48 BuildingQtOnWindows edited by vanboxem.ruben@gmail.com
add mingw-w64 howto (diff)
06:18 Changeset [59075] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-10 Markus Goetz <Markus.Goetz@nokia.com>

Reviewed by Simon Hausmann.

Qt after 4.6.3 has its integrated DNS cache. Therefore some
code is not necessary anymore.

https://bugs.webkit.org/show_bug.cgi?id=38834

  • platform/network/qt/DnsPrefetchHelper.h: (WebCore::DnsPrefetchHelper::lookup): (WebCore::DnsPrefetchHelper::lookedUp):
06:07 Changeset [59074] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

[Qt] Disable JIT support for mingw-w64
https://bugs.webkit.org/show_bug.cgi?id=38747

Disale JIT for mingw-w64 as it is reportedly
unstable.

Thanks for Vanboxem Rruben for the investigation.

  • wtf/Platform.h:
04:53 Changeset [59073] by krit@webkit.org
  • 3 edits in trunk/LayoutTests

2010-05-10 Dirk Schulze <krit@webkit.org>

Uneviewed.

SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683


New baseline for Win. Only two tests needed an update.

  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
04:40 Changeset [59072] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-10 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Darin Adler.

Asserted that Node::setDocument() is not being used to change
the document of a node.

https://bugs.webkit.org/show_bug.cgi?id=38821

  • dom/Node.cpp: (WebCore::Node::setDocument): Added an ASSERT at the beginning of the function.
  • dom/Node.h: Documented that Node::setDocument() should not be used to change the document of a node until after the node has been removed from its prior document.
04:37 Changeset [59071] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-10 Dirk Schulze <krit@webkit.org>

Unreviewed.

SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683


New baseline for Gtk. Just one test needed an update.

  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
04:34 Changeset [59070] by krit@webkit.org
  • 17 edits in trunk/LayoutTests

2010-05-10 Dirk Schulze <krit@webkit.org>

Unreviewed.

SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683


New baseline for Qt.

  • platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/filter-clip-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/filters/filter-source-position-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
04:15 Changeset [59069] by krit@webkit.org
  • 97 edits in trunk

2010-05-10 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683

All SVG Filter effects get dumped now. The structure of the DRT output
changed. The last effect is shown first, followed by the previous effects.

No changed behaior, so no new test added.

  • platform/graphics/filters/FEBlend.cpp: (WebCore::operator<<): (WebCore::FEBlend::externalRepresentation):
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::operator<<): (WebCore::FEColorMatrix::externalRepresentation):
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::operator<<): (WebCore::FEComponentTransfer::externalRepresentation):
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp: (WebCore::operator<<): (WebCore::FEComposite::externalRepresentation):
  • platform/graphics/filters/FEComposite.h: (WebCore::): (WebCore::FEComposite::uniteChildEffectSubregions):
  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::externalRepresentation):
  • platform/graphics/filters/FEGaussianBlur.h: (WebCore::FEGaussianBlur::uniteChildEffectSubregions):
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::externalRepresentation):
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::externalRepresentation):
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::externalRepresentation):
  • platform/graphics/filters/SourceGraphic.h:
  • rendering/RenderTreeAsText.cpp: (WebCore::writeIndent):
  • rendering/RenderTreeAsText.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer):
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::operator<<): (WebCore::FEConvolveMatrix::externalRepresentation):
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::externalRepresentation):
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::operator<<): (WebCore::FEDisplacementMap::externalRepresentation):
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::externalRepresentation):
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::externalRepresentation):
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::externalRepresentation):
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::operator<<): (WebCore::FEMorphology::externalRepresentation):
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::externalRepresentation):
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::externalRepresentation):
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::externalRepresentation):
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::operator<<): (WebCore::FETurbulence::externalRepresentation):
  • svg/graphics/filters/SVGFETurbulence.h:

2010-05-10 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler.

SVG FilterEffects need more detailed DRT information
https://bugs.webkit.org/show_bug.cgi?id=38683

All SVG Filter effects get dumped now. The structure of the DRT output
changed. The last effect is shown first, followed by the previous effects.

  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/custom/empty-merge-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/non-opaque-filters-expected.txt:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
  • platform/mac/svg/custom/text-filter-expected.txt:
  • platform/mac/svg/custom/visibility-override-filter-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-2-expected.txt:
  • platform/mac/svg/filters/big-sized-filter-expected.txt:
  • platform/mac/svg/filters/feColorMatrix-values-expected.txt:
  • platform/mac/svg/filters/feComposite-expected.txt:
  • platform/mac/svg/filters/feDisplacementMap-expected.txt:
  • platform/mac/svg/filters/feGaussianBlur-expected.txt:
  • platform/mac/svg/filters/feMerge-expected.txt:
  • platform/mac/svg/filters/feOffset-expected.txt:
  • platform/mac/svg/filters/feTile-expected.txt:
  • platform/mac/svg/filters/filter-clip-expected.txt:
  • platform/mac/svg/filters/filter-on-tspan-expected.txt:
  • platform/mac/svg/filters/filter-source-position-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.txt:
  • platform/mac/svg/filters/shadow-on-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/mac/svg/filters/sourceAlpha-expected.txt:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt:
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt:
02:53 Changeset [59068] by jorlow@chromium.org
  • 29 edits
    4 copies
    2 adds
    2 deletes in trunk

2010-05-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Change IndexedDB to use events instead of callbacks
https://bugs.webkit.org/show_bug.cgi?id=38594

Switch IndexedDB over to an event based model to match what
Mozilla (and probably MS?) are doing. This also gets rid of
a lot of template mess at the expense of a little extra boiler
plate code (for each type that IDBResult.result could be).

This change also introduces JSC bindings that match the level of
functionality the V8 bindings have.

Still not testable, but that shoudl change shortly.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp:
  • bindings/js/JSIDBRequestCustom.cpp: Added. (WebCore::JSIDBRequest::result):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • bindings/v8/custom/V8CustomIDBCallbacks.h: Removed.
  • bindings/v8/custom/V8IDBRequestCustom.cpp: Added. (WebCore::V8IDBRequest::resultAccessorGetter):
  • bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp: Removed.
  • dom/EventTarget.cpp: (WebCore::EventTarget::toIDBRequest):
  • dom/EventTarget.h:
  • storage/IDBCallbacks.h:
  • storage/IDBDatabaseRequest.h: (WebCore::IDBDatabaseRequest::createObjectStore):
  • storage/IDBRequest.cpp: Added. (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::idbDatabaseResult): (WebCore::IDBRequest::serializedScriptValueResult): (WebCore::IDBRequest::onError): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::scriptExecutionContext): (WebCore::IDBRequest::stop): (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::eventTargetData): (WebCore::IDBRequest::ensureEventTargetData): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h: Added. (WebCore::IDBRequest::create): (WebCore::IDBRequest::): (WebCore::IDBRequest::resultType): (WebCore::IDBRequest::readyState): (WebCore::IDBRequest::error): (WebCore::IDBRequest::toIDBRequest): (WebCore::IDBRequest::refEventTarget): (WebCore::IDBRequest::derefEventTarget):
  • storage/IDBRequest.idl: Added.
  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:
  • storage/IndexedDatabaseRequest.idl:

2010-05-10 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Change IndexedDB to use events instead of callbacks
https://bugs.webkit.org/show_bug.cgi?id=38594

Change the glue here to match the changes I made in WebCore.

  • WebKit.gyp:
  • public/WebIDBCallbacks.h:
  • public/WebIndexedDatabase.h:
  • src/IDBCallbacksProxy.cpp: Added. (WebCore::IDBCallbacksProxy::IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::onError): (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
  • src/IndexedDatabaseProxy.h:
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h:
00:02 Changeset [59067] by ukai@chromium.org
  • 5 edits in trunk/JavaScriptCore

2010-05-09 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

JavaScriptCore/wtf/MD5.h: checksum should take a reference to output.
https://bugs.webkit.org/show_bug.cgi?id=38723

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/MD5.cpp: (WTF::expectMD5): Fix for checksum change. (WTF::MD5::checksum): Take a reference to output, instead of returning the result by value, to reduce coping for performance.
  • wtf/MD5.h:

05/09/10:

22:07 Changeset [59066] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed, test expectation update.

Update Chromium/Linux expectation for fast/forms/input-file-re-render.html.
http://crbug.com/40027

  • platform/chromium-linux/fast/forms/input-file-re-render-expected.checksum:
  • platform/chromium-linux/fast/forms/input-file-re-render-expected.png:
  • platform/chromium/test_expectations.txt:
19:17 Changeset [59065] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix accidental repeat addition of emit_op_new_regexp

18:41 Changeset [59064] by oliver@apple.com
  • 14 edits
    2 moves
    1 add
    1 delete in trunk

2010-05-09 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Reserve a large-ish initial capacity for Lexer::m_buffer16.

SunSpider says 0.3% faster.

m_buffer16 is used when parsing complex strings -- for example, strings
with escape sequences in them. These kinds of strings can be really long,
and we want to avoid repeatedly copying as we grow m_buffer16.

The net memory cost is quite low, since it's proporitional to source
code we already have in memory, and we throw away m_buffer16 right when
we're done parsing.

  • parser/Lexer.cpp: (JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor, since setCode will be called before we're asked to lex anything. (JSC::Lexer::setCode): Reserve enough space to lex half the source code as a complex string without having to copy. (JSC::Lexer::clear): No need to reserve initial capacity here either, since setCode will be called before we're asked to lex anything.

2010-05-09 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

REGRESSION(r57955): RegExp literals should not actually be cached, so r57955 should be rolled out.
https://bugs.webkit.org/show_bug.cgi?id=38828

Replace incorrect test for caching regexp literals with ones that tests that they are not cached.

  • fast/js/regexp-literals-are-constants-expected.txt: Removed.
  • fast/js/regexp-literals-are-constants.html: Removed.
  • fast/js/regexp-literals-arent-constants-expected.txt: Added.
  • fast/js/regexp-literals-arent-constants.html: Added.
  • fast/js/script-tests/regexp-literals-are-constants.js: Removed.
  • fast/js/script-tests/regexp-literals-arent-constants.js: Added. (test1): (returnRegExpLiteral): (returnConditionalRegExpLiteral):
15:09 Changeset [59063] by loislo@chromium.org
  • 3 edits in trunk/WebCore

2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>

Not reviewed: rollback the commit r59062

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
  • inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
14:38 Changeset [59062] by loislo@chromium.org
  • 3 edits in trunk/WebCore

2010-05-10 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Cosmetic changes.
1) Inner Function Call event of Timer Fire should be merged into parent even if it is not the only child.
2) Standard tooltips for resource links are clashing with Popover.
3) Recalculate Style caller info are duplicating in Details Popover (Caller and Details rows).
https://bugs.webkit.org/show_bug.cgi?id=38732

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
  • inspector/front-end/inspector.js: (WebInspector.linkifyURLAsNode):
14:16 Changeset [59061] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reserve a large-ish initial capacity for Lexer::m_buffer16.

Reviewed by Oliver Hunt.

SunSpider says 0.3% faster.

m_buffer16 is used when parsing complex strings -- for example, strings
with escape sequences in them. These kinds of strings can be really long,
and we want to avoid repeatedly copying as we grow m_buffer16.

The net memory cost is quite low, since it's proporitional to source
code we already have in memory, and we throw away m_buffer16 right when
we're done parsing.

  • parser/Lexer.cpp:

(JSC::Lexer::Lexer): No need to reserve initial capacity in our constructor,
since setCode will be called before we're asked to lex anything.
(JSC::Lexer::setCode): Reserve enough space to lex half the source code
as a complex string without having to copy.
(JSC::Lexer::clear): No need to reserve initial capacity here either,
since setCode will be called before we're asked to lex anything.

14:11 Changeset [59060] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

[Qt] Remove YARR configuration rules from Qt make system
https://bugs.webkit.org/show_bug.cgi?id=38819

Setting YARR based on JIT seeting is now in Platform.h
for all ports. This patch essentially reverses r49238.

13:58 Changeset [59059] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: If some record is not in visible area then it's expand element also is not
visible even if it has children in visible area.
https://bugs.webkit.org/show_bug.cgi?id=38643

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._refreshRecords):
13:34 Changeset [59058] by weinig@apple.com
  • 5 edits in trunk/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=38557
r58526 introduced a ~30% regression on Dromaeo JS lib

Reviewed by Darin Adler.

This fix does two things.

  • Don't use QualifiedName as the key to a HashMap, use a RefPtr<QualifiedNameImpl> instead. We should remove the HashTraits for QualifiedName and that will happen in a follow up patch.
  • Only mark cached NodeLists on Documents instead of all Nodes. This is okay since the marking of NodeLists is an optimization to keep NodeList wrappers alive and is not mandated by any spec.
  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::markChildren):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::markChildren):

  • dom/Node.cpp:

(WebCore::Node::removeCachedTagNodeList):
(WebCore::Node::getElementsByTagNameNS):

  • dom/NodeRareData.h:
09:37 Changeset [59057] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-09 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Crash in QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate when animation were used
https://bugs.webkit.org/show_bug.cgi?id=38574

The fix uses a QWeakPointer for rootGraphicsLayer, protecting from a crash in case the layer is deleted before the QGraphicsWebView.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): (QGraphicsWebViewPrivate::setRootGraphicsLayer): (QGraphicsWebViewPrivate::updateCompositingScrollPosition):
04:42 Changeset [59056] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

2010-05-09 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Improve string indexing performance
https://bugs.webkit.org/show_bug.cgi?id=38814

Add an assembly stub to do indexed loads from strings much
more cheaply than the current stub dispatch logic. We can
do this because we are able to make guarantees about the
register contents when entering the stub so the call overhead
is negligible.

  • jit/JIT.h:
  • jit/JITInlineMethods.h:
  • jit/JITOpcodes.cpp:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emitSlow_op_get_by_val):

Moved from JITOpcodes.cpp to keep the slowcase next to
the normal case codegen as we do for everything else.

  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::stringGetByValStubGenerator): (JSC::JIT::emitSlow_op_get_by_val):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitFastArithImmToInt):
04:18 Changeset [59055] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-05-09 Maciej Stachowiak <mjs@apple.com>

Fixed version of: "Optimized o[s] where o is a cell and s is a string"
https://bugs.webkit.org/show_bug.cgi?id=38815


Fixed the previous patch for this from Geoff Garen.


The two problems were a missing exception check and a PropertySlot
initialized improperly, leading to crashes and failures in the case
of getters accessed with bracket syntax.

Previous patch:

Optimized o[s] where o is a cell and s is a string, removing some old
code that wasn't really tuned for the JIT.


SunSpider says 0.8% faster.

  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/JSCell.h:
03:24 Changeset [59054] by robert@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-05-09 Robert Hogan <robert@webkit.org>

[Qt] Update expected results for unskipped editing/inserting tests

Unreviewed, remove platform-specific results for editing/inserting/6633727.html

https://bugs.webkit.org/show_bug.cgi?id=38472

  • platform/qt/editing/inserting/6633727-expected.txt: Removed.
03:15 Changeset [59053] by robert@webkit.org
  • 97 edits
    5 adds in trunk/LayoutTests

[Qt] Update expected results for unskipped editing/inserting tests

Unreviewed, add expected results for unskipped tests. Results are taken
from Qt bot.

https://bugs.webkit.org/show_bug.cgi?id=38472

02:52 Changeset [59052] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unskip editing/inserting tests that fail due to x/y differences

2010-05-03 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Unskip editing/inserting tests that fail due to x/y differences

https://bugs.webkit.org/show_bug.cgi?id=38472

Unskip the following tests:

editing/inserting/12882.html
editing/inserting/4840662.html
editing/inserting/4875189-1.html
editing/inserting/4959067.html
editing/inserting/4960120-2.html
editing/inserting/5002441.html
editing/inserting/5058163-2.html
editing/inserting/5156401-2.html
editing/inserting/5418891.html
editing/inserting/5510537.html
editing/inserting/5549929-2.html
editing/inserting/5549929-3.html
editing/inserting/6633727.html
editing/inserting/6703873.html
editing/inserting/editable-inline-element.html
editing/inserting/insert-3654864-fix.html
editing/inserting/insert-3659587-fix.html
editing/inserting/insert-3775316-fix.html
editing/inserting/insert-3778059-fix.html
editing/inserting/insert-3786362-fix.html
editing/inserting/insert-3800346-fix.html
editing/inserting/insert-3851164-fix.html
editing/inserting/insert-3907422-fix.html
editing/inserting/insert-after-delete-001.html
editing/inserting/insert-at-end-01.html
editing/inserting/insert-at-end-02.html
editing/inserting/insert-before-link-1.html
editing/inserting/insert-br-001.html
editing/inserting/insert-br-002.html
editing/inserting/insert-br-003.html
editing/inserting/insert-br-004.html
editing/inserting/insert-br-005.html
editing/inserting/insert-br-006.html
editing/inserting/insert-br-007.html
editing/inserting/insert-br-008.html
editing/inserting/insert-br-009.html
editing/inserting/insert-br-at-tabspan-001.html
editing/inserting/insert-br-at-tabspan-002.html
editing/inserting/insert-br-at-tabspan-003.html
editing/inserting/insert-br-quoted-001.html
editing/inserting/insert-br-quoted-002.html
editing/inserting/insert-br-quoted-003.html
editing/inserting/insert-br-quoted-004.html
editing/inserting/insert-br-quoted-005.html
editing/inserting/insert-br-quoted-006.html
editing/inserting/insert-div-001.html
editing/inserting/insert-div-002.html
editing/inserting/insert-div-003.html
editing/inserting/insert-div-004.html
editing/inserting/insert-div-005.html
editing/inserting/insert-div-006.html
editing/inserting/insert-div-007.html
editing/inserting/insert-div-008.html
editing/inserting/insert-div-009.html
editing/inserting/insert-div-010.html
editing/inserting/insert-div-011.html
editing/inserting/insert-div-012.html
editing/inserting/insert-div-013.html
editing/inserting/insert-div-014.html
editing/inserting/insert-div-015.html
editing/inserting/insert-div-016.html
editing/inserting/insert-div-017.html
editing/inserting/insert-div-018.html
editing/inserting/insert-div-019.html
editing/inserting/insert-div-020.html
editing/inserting/insert-div-021.html
editing/inserting/insert-div-022.html
editing/inserting/insert-div-024.html
editing/inserting/insert-div-025.html
editing/inserting/insert-div-026.html
editing/inserting/insert-div-027.html
editing/inserting/insert-paragraph-01.html
editing/inserting/insert-paragraph-02.html
editing/inserting/insert-paragraph-03.html
editing/inserting/insert-paragraph-04.html
editing/inserting/insert-paragraph-05.html
editing/inserting/insert-space-in-empty-doc.html
editing/inserting/insert-tab-001.html
editing/inserting/insert-tab-002.html
editing/inserting/insert-tab-004.html
editing/inserting/insert-text-at-tabspan-001.html
editing/inserting/insert-text-at-tabspan-002.html
editing/inserting/insert-text-at-tabspan-003.html
editing/inserting/line-break.html
editing/inserting/paragraph-separator-01.html
editing/inserting/paragraph-separator-02.html
editing/inserting/paragraph-separator-in-table-1.html
editing/inserting/paragraph-separator-in-table-2.html
editing/inserting/redo.html
editing/inserting/return-key-with-selection-003.html
editing/inserting/typing-001.html
editing/inserting/typing-002.html
editing/inserting/typing-003.html
editing/inserting/typing-around-br-001.html
editing/inserting/typing-around-image-001.html

editing/inserting/5058163-1.html
editing/inserting/edited-whitespace-1.html
editing/inserting/paragraph-separator-03.html
editing/inserting/return-key-with-selection-001.html
editing/inserting/return-key-with-selection-002.html
editing/inserting/4875189-2.html

  • platform/qt/Skipped:
02:50 Changeset [59051] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-09 Daniel Bates <dbates@rim.com>

Reviewed by Chris Jerdonek.

https://bugs.webkit.org/show_bug.cgi?id=38812

Make the regular expressions for parsing the start of an SVN
and Git header global variables since they are used throughout
VCSUtils.pm.

  • Scripts/VCSUtils.pm:
02:08 Changeset [59050] by dbates@webkit.org
  • 3 edits in trunk

2010-05-07 Daniel Bates <dbates@rim.com>

Unreviewed, change log fix.

Add back some entries inadvertently deleted in changeset 59000
<http://trac.webkit.org/changeset/59000> and not restored (as
intended) in changeset 59005 <http://trac.webkit.org/changeset/59005>.

01:42 Changeset [59049] by mjs@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Add back some entries accidentally deleted in r59000 and not restored as intended in r59005.

00:21 Changeset [59048] by cjerdonek@webkit.org
  • 7 edits in trunk/WebKitTools

2010-05-09 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Daniel Bates.

Finished moving the header-parsing logic from svn-apply and -unapply
to VCSUtils.pm's parsing methods.

https://bugs.webkit.org/show_bug.cgi?id=38802

  • Scripts/VCSUtils.pm:
    • Added to parseGitDiffHeader() the ability to parse and store whether a file is new or deleted.
    • Also reordered in parseGitDiffHeader() some of the else statements to a more readable ordering.
    • Added to parseSvnDiffHeader() the ability to parse and store whether a file is new.
  • Scripts/svn-apply:
    • Changed handleGitBinaryChange() to use the new "isNew" and "isDeletion" diffHash key-values.
    • Changed patch() to use the new "isNew" diffHash key-value.
  • Scripts/svn-unapply:
    • Changed patch() to use the new "isNew" and "isDeletion" diffHash key-values.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Added unit tests for new and deleted files.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
    • Updated the unit tests as necessary.
    • Added a unit test for a deleted file.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
    • Updated the unit tests as necessary.

05/08/10:

23:50 Changeset [59047] by cjerdonek@webkit.org
  • 4 edits in trunk/BugsSite

2010-05-08 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Maciej Stachowiak.

Allow long comment lines to wrap to the window width instead
of to 80 characters.

https://bugs.webkit.org/show_bug.cgi?id=37792

  • Bugzilla/Constants.pm:
    • Introduced a new constant COMMENT_COLS_WRAP to replace COMMENT_COLS inside the wrap_comment() subroutine. The new constant effectively disables text wrapping by increasing the value used in wrap_comment() from 80 characters to a very large value (8000).
  • Bugzilla/Util.pm:
    • Replaced COMMENT_COLS with COMMENT_COLS_WRAP inside wrap_comment().
  • skins/custom/global.css: (.bz_comment_text):
    • Eliminate the width styling on comments to allow long lines to wrap at the window width.

(.bz_comment_text > span.quote):

  • Inherit the "white-space" property. This prevents long quoted lines in comments from causing non-quoted lines to extend beyond the window width.
20:21 Changeset [59046] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

2010-05-08 Antonio Gomes <tonikitoo@webkit.org>

Unreviewed attempt to fix Windows build.

  • page/SpatialNavigation.h: (WebCore::fudgeFactor):
20:05 Changeset [59045] by tonikitoo@webkit.org
  • 3 edits in trunk/WebCore

Spatial Navigation: create a getter for the "fudgeFactor"
https://bugs.webkit.org/show_bug.cgi?id=38488

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

A couple of places in the Spatial Navigation code make use of a "fudge factor"
to improve precision by working around outline focus metrics and such. Patch adds
a helper method for unify getter operations of this value, instead of having it
declared locally in the various methods it is used.

No behaviour change.

  • page/SpatialNavigation.cpp:

(WebCore::scrollIntoView):
(WebCore::deflateIfOverlapped):

  • page/SpatialNavigation.h:

(WebCore::fudgeFactor):

19:52 Changeset [59044] by cjerdonek@webkit.org
  • 7 edits in trunk/WebKitTools

Added to svn-apply support for git renames and copies with similarity
index less than 100%.

Reviewed by Daniel Bates.

https://bugs.webkit.org/show_bug.cgi?id=32834

  • Scripts/VCSUtils.pm:
    • Added to parseGitDiffHeader() support for renames and similarity index less than 100%.
    • Added to parseDiff() support for processing renames, renames with changes, and copies with changes.
    • Added to parsePatch() the ability to process multiple return values from parseDiff().
  • Scripts/svn-apply:
    • Added to patch() the ability to process diff hashes with the isDeletion key-value set.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated the unit tests as necessary.
    • Added unit tests for rename with similarity index 100%, rename with similarity index < 100%, and rename with a change to the executable bit.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
    • Added unit tests for rename with similarity index 100%, rename with similarity index < 100%, and rename with a change to the executable bit.
  • Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
    • Simplified the carriage-return unit test to more narrowly test only carriage returns.
19:37 Changeset [59043] by cjerdonek@webkit.org
  • 4 edits in trunk/WebKitTools

This revision suppresses the misleading "error: pathspec..." messages
when using svn-apply to add a binary file from a Git diff.

Reviewed by Daniel Bates.

https://bugs.webkit.org/show_bug.cgi?id=38047

When adding a new binary file from a Git diff, svn-apply prints
a misleading error of the form -- "error: pathspec '<filename>' did
not match any file(s) known to git. Did you forget to 'git add'?"
This patch suppresses these messages since they are normal.

  • Scripts/VCSUtils.pm: Added the callSilently() subroutine from runPatchCommand.pl, which executes a Perl function while suppressing STDERR.
  • Scripts/svn-apply: Refactored the Git portion of scmKnowsOfFile() into a gitKnowsOfFile(), and called this new subroutine using callSilently().
  • Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Removed callSilently() since it was moved to VCSUtils.pm in this patch.
19:02 Changeset [59042] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/JavaScriptCore

2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, build fix.

Fix missing terminating ' character warning

The warning has been only seen on the Gtk buildbots.

  • wtf/Platform.h:
17:38 Changeset [59041] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Gavin Barraclough.

Refactor YARR and YARR_JIT default rules in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=38727

Turn on YARR and YARR JIT by default of JIT is enabled.
Ports can overrule this default decisions as they wish.

  • wtf/Platform.h:
15:59 Changeset [59040] by oliver@apple.com
  • 7 edits
    1 add in trunk/JavaScriptCore

2010-05-08 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Split JSVALUE32_64 code out of JITOpcodes.cpp and into JITOpcodes32_64.cpp
https://bugs.webkit.org/show_bug.cgi?id=38808

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp: Added. (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::emit_op_mov): (JSC::JIT::emit_op_end): (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emitSlow_op_loop_if_lesseq): (JSC::JIT::emit_op_new_object): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emitSlow_op_instanceof): (JSC::JIT::emit_op_new_func): (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_tear_off_activation): (JSC::JIT::emit_op_tear_off_arguments): (JSC::JIT::emit_op_new_array): (JSC::JIT::emit_op_resolve): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emitSlow_op_to_primitive): (JSC::JIT::emit_op_strcat): (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_resolve_skip): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_not): (JSC::JIT::emitSlow_op_not): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emitSlow_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emitSlow_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_sret): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::compileOpStrictEq): (JSC::JIT::emit_op_stricteq): (JSC::JIT::emitSlow_op_stricteq): (JSC::JIT::emit_op_nstricteq): (JSC::JIT::emitSlow_op_nstricteq): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_resolve_with_base): (JSC::JIT::emit_op_new_func_exp): (JSC::JIT::emit_op_throw): (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_push_scope): (JSC::JIT::emit_op_pop_scope): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emitSlow_op_to_jsnumber): (JSC::JIT::emit_op_push_new_scope): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_jmp_scopes): (JSC::JIT::emit_op_switch_imm): (JSC::JIT::emit_op_switch_char): (JSC::JIT::emit_op_switch_string): (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_debug): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation): (JSC::JIT::emit_op_create_arguments): (JSC::JIT::emit_op_init_arguments): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emitSlow_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call):
13:47 Changeset [59039] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-08 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Adler.

Change the npapi.h header guards to match the npapi-headers repository
copy.

https://bugs.webkit.org/show_bug.cgi?id=38666

  • bridge/npapi.h:
13:03 Changeset [59038] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-05-08 Gabor Loki <loki@webkit.org>

Reviewed by Gavin Barraclough.

Fix halfword loads on ARM
https://bugs.webkit.org/show_bug.cgi?id=38741

The BaseIndex and ImplicitAddress are contain 32bit wide offset, but
the load16 functions were working with 8 bit data (encoded in the
instruction). If the offset cannot be encoded in an instruction, it
should be stored in a temporary register.

  • assembler/ARMAssembler.h: (JSC::ARMAssembler::getOffsetForHalfwordDataTransfer):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::load16):
12:51 Changeset [59037] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-08 Gabor Loki <loki@webkit.org>

Reviewed by Gavin Barraclough.

Fix spanning branch instruction on Cortex-A8 with Thumb-2 JIT
https://bugs.webkit.org/show_bug.cgi?id=38280

If the 32-bit Thumb-2 branch instruction spans two 4KiB regions and
the target of the branch falls within the first region it is
possible for the processor to incorrectly determine the branch
instruction, and it is also possible in some cases for the processor
to enter a deadlock state.

  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::linkJumpAbsolute):
12:36 Changeset [59036] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-08 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

[chromium]: Upload test results json files to app engine server
Add an option to run_webkit_tests.py to upload generated
JSON files to app engine server. These JSON files will be used
by chromium layout test falkiness dashboard.

https://bugs.webkit.org/show_bug.cgi?id=36063

  • Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Added.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12:23 Changeset [59035] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-08 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Resolve most of the whitespace/comment/order differences in npapi.h
and npruntime.h relative to the npapi-headers repository versions.
No changes to the substance of the code.

https://bugs.webkit.org/show_bug.cgi?id=38666

  • bridge/npapi.h: (_NPPrint::): (_NPCocoaEvent::):
  • bridge/npruntime.h:
12:05 Changeset [59034] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Fix guard around IndexedDatabase
https://bugs.webkit.org/show_bug.cgi?id=38710

No new tests, there is no new functionality.

  • page/PageGroup.h:
11:51 Changeset [59033] by eric@webkit.org
  • 6 edits
    3 adds in trunk

2010-05-08 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Platform plugin
https://bugs.webkit.org/show_bug.cgi?id=38438

Select popups delegate private API. To provide select popup delegates
a plugin that implements QWebKitPlatformPlugin must be found
in QCoreApplication::libraryPaths.

  • WebCore.pro:

2010-05-08 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Platform plugin
https://bugs.webkit.org/show_bug.cgi?id=38438

Select popups delegate private API. To provide select popup delegates
a plugin that implements QWebKitPlatformPlugin must be found
in QCoreApplication::libraryPaths.

  • Api/headers.pri:
  • Api/qwebkitplatformplugin.h: Added. (QWebSelectData::~QWebSelectData): (QWebSelectData::): (QWebSelectMethod::~QWebSelectMethod): (QWebKitPlatformPlugin::~QWebKitPlatformPlugin): (QWebKitPlatformPlugin::):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/QtPlatformPlugin.cpp: Added. (WebCore::SelectData::SelectData): (WebCore::SelectData::itemText): (WebCore::SelectData::itemToolTip): (WebCore::SelectData::itemIsEnabled): (WebCore::SelectData::itemCount): (WebCore::SelectData::itemIsSelected): (WebCore::SelectData::multiple): (WebCore::SelectData::itemType): (WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::show): (WebCore::SelectInputMethodWrapper::hide): (WebCore::SelectInputMethodWrapper::selectItem): (WebCore::SelectInputMethodWrapper::didHide): (WebCore::getPluginObject): (WebCore::QtPlatformPlugin::~QtPlatformPlugin): (WebCore::QtPlatformPlugin::plugin): (WebCore::QtPlatformPlugin::createSelectInputMethod):
  • WebCoreSupport/QtPlatformPlugin.h: Added. (WebCore::QtPlatformPlugin::QtPlatformPlugin):
11:40 Changeset [59032] by eric@webkit.org
  • 2 edits in trunk/WebKit

2010-05-08 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Laszlo Gombos.

[EFL] Only compile database stuff if ENABLE_DATABASE is set.
http://webkit.org/b/38777

  • efl/WebCoreSupport/ChromeClientEfl.cpp:
11:29 Changeset [59031] by eric@webkit.org
  • 4 edits in trunk

2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Build the ImageDiff tool for all platforms including Windows and Symbian
https://bugs.webkit.org/show_bug.cgi?id=38706

  • WebKit.pro:

2010-05-08 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Build the ImageDiff tool for all platforms including Windows and Symbian
https://bugs.webkit.org/show_bug.cgi?id=38706

Use qmath.h instead of math.h to make it portable.

  • DumpRenderTree/qt/ImageDiff.cpp: (main):
11:17 Changeset [59030] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-08 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

[EFL] It does not make sense to use RenderThemeEfl::RenderThemeEfl, so
use RenderThemeEfl (GCC 4.5 seems to be pickier about this).
http://webkit.org/b/38770

  • platform/efl/RenderThemeEfl.cpp: (WebCore::renderThemeEflColorClassSelectionActive): (WebCore::renderThemeEflColorClassSelectionInactive): (WebCore::renderThemeEflColorClassFocusRing): (WebCore::renderThemeEflColorClassButtonText): (WebCore::renderThemeEflColorClassComboText): (WebCore::renderThemeEflColorClassEntryText): (WebCore::renderThemeEflColorClassSearchText): (WebCore::RenderThemeEfl::adjustCheckboxStyle): (WebCore::RenderThemeEfl::adjustRadioStyle): (WebCore::RenderThemeEfl::adjustButtonStyle): (WebCore::RenderThemeEfl::adjustMenuListStyle): (WebCore::RenderThemeEfl::adjustTextFieldStyle): (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
11:06 Changeset [59029] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-05-08 Jens Alfke <snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] WebFrame::registerPasswordListener shouldn't assert on duplicate listener.
https://bugs.webkit.org/show_bug.cgi?id=38765

  • public/WebFrame.h: (WebKit::WebFrameImpl::registerPasswordListener): Changed return type to bool. Updated comment.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::registerPasswordListener): Return false instead of asserting.
  • src/WebFrameImpl.h: (WebKit::WebFrameImpl::registerPasswordListener): Changed return type to bool.
10:53 Changeset [59028] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-08 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

ResourceHandleSoup should depend only on GLib, not on GTK+.
http://webkit.org/b/38763

  • platform/network/soup/ResourceHandleSoup.cpp: Include glib.h instead of gtk/gtk.h.
09:49 Changeset [59027] by eric@webkit.org
  • 13 edits
    1 delete in trunk/WebCore

2010-05-08 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r59023.
http://trac.webkit.org/changeset/59023
https://bugs.webkit.org/show_bug.cgi?id=37874

Caused Chromium Windows build to fail to link.

  • WebCore.gypi:
  • loader/CachedMetadata.h: Removed.
  • loader/CachedResource.cpp:
  • loader/CachedResource.h:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/loader.cpp:
  • loader/loader.h:
  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
06:31 Changeset [59026] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Document a limitation of QWebPage::linkClicked
https://bugs.webkit.org/show_bug.cgi?id=37694

  • Api/qwebpage.cpp:
06:20 Changeset [59025] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Autocompletion in console is not usable because it is not add to the entered text the common prefix of suggestions.
As example if you entered $0.getE then getElementByClassName will be suggested as gray text.
If you press tab then getElementByClassName be suggested again and lementByClassName becomes selected as black text with selection background.
Really after pressing the TAB the next suggestion should be selected (getElementByTagName) and only flexible part of suggestions should be selected.
In this case it should be TagName because getElementBy is the common part for all getE prefix suggestions.
https://bugs.webkit.org/show_bug.cgi?id=38753

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._completionsReady):
06:09 Changeset [59024] by eric@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2010-05-08 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

[WTFURL] Add a buffer for managing the output of the canonicalizer
https://bugs.webkit.org/show_bug.cgi?id=38671

The canonicalizer produces a stream of canonicalized characters, which
we will store in a URLBuffer. URLBuffer is quite similar to Vector,
but serves as an abstraction to isolate us from the underlying
character storage. In the case of WebKit, we'll probably implement a
subclass of URLBuffer with Vector. In Chromium, the backing store is a
std::string, which avoids an unnecessary memcpy that would be caused by
using Vector instead.

  • wtf/url/src/URLBuffer.h: Added. (WTF::URLBuffer::URLBuffer): (WTF::URLBuffer::~URLBuffer): (WTF::URLBuffer::at): (WTF::URLBuffer::set): (WTF::URLBuffer::capacity): (WTF::URLBuffer::length): (WTF::URLBuffer::data): (WTF::URLBuffer::setLength): (WTF::URLBuffer::append): (WTF::URLBuffer::grow):
05:58 Changeset [59023] by eric@webkit.org
  • 13 edits
    1 add in trunk/WebCore

2010-05-08 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

Provide mechanism to store cached metadata on a CachedResource.
https://bugs.webkit.org/show_bug.cgi?id=37874

No new tests because no new functionality.

  • WebCore.gypi:
  • loader/CachedMetadata.h: Added. (WebCore::CachedMetadata::~CachedMetadata): (WebCore::CachedMetadata::data): (WebCore::CachedMetadata::size): (WebCore::CachedMetadata::create): (WebCore::CachedMetadata::deserialize): (WebCore::CachedMetadata::serialize): (WebCore::CachedMetadata::dataTypeID): (WebCore::CachedMetadata::readUnsigned): (WebCore::CachedMetadata::appendUnsigned): (WebCore::CachedMetadata::CachedMetadata):
  • loader/CachedResource.cpp: (WebCore::CachedResource::setSerializedCachedMetadata): (WebCore::CachedResource::setCachedMetadata): (WebCore::CachedResource::cachedMetadata):
  • loader/CachedResource.h:
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveCachedMetadata):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveCachedMetadata):
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveCachedMetadata):
  • loader/loader.cpp: (WebCore::Loader::Host::didReceiveCachedMetadata):
  • loader/loader.h:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveCachedMetadata):
05:39 Changeset [59022] by eric@webkit.org
  • 9 edits in trunk

2010-05-08 Michael Nordman <michaeln@google.com>

Reviewed by Dmitry Titov.

Have WorkerScriptLoader provide access to the ResourceResponse for the loaded script
through the WorkerScriptLoaderClient interface.
https://bugs.webkit.org/show_bug.cgi?id=38605

No new tests. There are no script visible changes.

  • workers/WorkerScriptLoader.cpp: Call the client with the response. (WebCore::WorkerScriptLoader::didReceiveResponse):
  • workers/WorkerScriptLoaderClient.h: Define a new method to receive the response. (WebCore::WorkerScriptLoaderClient::didReceiveResponse):

2010-05-08 Michael Nordman <michaeln@google.com>

Reviewed by Dmitry Titov.

Add an additional parameter to the WebSharedWorker::startWorkerContext method
to indicate which appcache the shared worker script resource was loaded from,
and provide that value when calling out to chrome via this interface.
https://bugs.webkit.org/show_bug.cgi?id=38605

I'm keeping the old method around until patches can land in both repositories
that make the old method obsolete and unneeded. There's a FIXME for that.

Also somewhat related but independent change to propagate the runtime enabled
flag thru to the page settings instance used by the 'shadow page'.

  • public/WebSharedWorker.h: Add the new param (but keep the old interface around for now too) (WebKit::WebSharedWorker::startWorkerContext):
  • src/SharedWorkerRepository.cpp: Provide the value when calling out to chrome. (WebCore::SharedWorkerScriptLoader::notifyFinished):
  • src/WebSharedWorkerImpl.cpp: (WebKit::WebSharedWorkerImpl::startWorkerContext):
  • src/WebSharedWorkerImpl.h:
  • src/WebWorkerBase.cpp: Propagate runtime enabled flag thru to the page settings. (WebKit::WebWorkerBase::initializeLoader):
05:13 Changeset [59021] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-08 Robert Hogan <robert@webkit.org>

Unreviewed Qt bot fix: test unskipped accidentally in r59020.

  • platform/qt/Skipped: Uncommented http/tests/xmlhttprequest/failed-auth.html again.
04:50 Changeset [59020] by robert@webkit.org
  • 7 edits
    1 add in trunk

[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html

2010-05-08 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html

and http/tests/xmlhttprequest/cross-origin-authorization.html

QHttpNetworkRequest adds Authorization and Cookie headers to XHRs
without knowing if this is valid behaviour or not. In order to allow
Qt to decide whether Cookie/Authorization headers should be added
to an XHR QtWebKit needs to use an attribute added to QNetworkRequest.
These new attributes are: QNetworkRequest::CookieLoadControlAttribute,
QNetworkRequest::CookieSaveControlAttribute,and
QNetworkRequest::AuthenticationReuseControlAttribute.

QtWebKit will set QNetworkRequest::AuthenticationReuseControlAttribute to false
unless withCredentials is set to true in the XHR.

QtWebkit will set CookieLoad/SaveControlAttribute to false unless withCredentials
is set to true in the XHR.

Qt will pass the values onto QHttpNetworkRequest and this will permit
the Qt network access processing to decide whether or not to add either
or both of the Cookie/Authorisation headers, and whether to save cookies
returned from such requests. By default the attribute
will always be true so unless QtWebKit sets it to false normal
header processing is unaffected.

There are platform-specific results for cross-origin-no-authorization.html:

  1. Qt's DRT does not capture the final 'DONE'.
  2. QNetworkReplyHandler.cpp's ignoreHttpError() means that async requests do not execute didFail() when they receive a 401 HTTP response. This results in async tests passing with '401 Authorisation required' rather than 'received error event'.

The Qt part of these changes was merged at: http://gitorious.org/qt/qt/merge_requests/592

In order to properly support the tests, Qt's DRT needs to use one
NetworkAccessManager for all pages. This allows it to use cached
credentials where appropriate.

The tests now pass when run individually but there seems to be a problem with
leaking the results of requests across tests when run with the others in
http/tests. This will be addressed in a separate patch.

https://bugs.webkit.org/show_bug.cgi?id=32967

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/Skipped: Group together the tests that are waiting for 4.7 to be unskipped.
  • platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
04:48 Changeset [59019] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-08 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInsector: Record expand UI element should be extracted from TimelineRecordGraphRow as separate class for future reuse.
https://bugs.webkit.org/show_bug.cgi?id=38726

04:08 Changeset [59018] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Forgot to rebase fast/dom/prototype-inheritance-2.html after the <vkern> patches.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
04:01 Changeset [59017] by robert@webkit.org
  • 4 edits in trunk

[Qt] unskip http/tests/plugins/npapi-response-headers.html

2010-05-04 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] unskip http/tests/plugins/npapi-response-headers.html

Turns out this failed because run-webkit-tests was eating the first occurrence
of 'Content-Type: text/plain' in the test output as a header. Strange but true.
So do as Chromium does and preface all text dumps with the
'Content-Type: text/plain' header.

Take this opportunity to unskip plugins/private-browsing-mode.html too, which
has passed since r55433. See https://bugs.webkit.org/show_bug.cgi?id=33180
and https://bugs.webkit.org/show_bug.cgi?id=35576.

https://bugs.webkit.org/show_bug.cgi?id=38541

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
  • platform/qt/Skipped:
03:55 Changeset [59016] by robert@webkit.org
  • 4 edits in trunk

[Qt] Fix encoding of status message in Plugin API

2010-05-05 Robert Hogan <robert@webkit.org>

Reviewed by Alexey Proskuryakov.

[Qt] Fix encoding of status message in Plugin API

Spotted by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=35144

  • platform/qt/Skipped: Unskip plugins/set-status.html
  • plugins/PluginView.cpp: (WebCore::PluginView::status):
03:11 Changeset [59015] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-05-08 Dirk Schulze <krit@webkit.org>

Unreviewed win build fix.

JS bindings were missing in DerivedSources.cpp

  • DerivedSources.cpp:
03:01 Changeset [59014] by zimmermann@webkit.org
  • 4 edits in trunk/LayoutTests

2010-05-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline Win specific results after exposing JSSVGVKernElement/JSSVGHKernElement.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
02:56 Changeset [59013] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-05-08 Dirk Schulze <krit@webkit.org>

Uneviewed fix of Win bot

Added JS bindings to Win build system.

  • WebCore.vcproj/WebCore.vcproj:
02:54 Changeset [59012] by zimmermann@webkit.org
  • 4 edits in trunk/LayoutTests

2010-05-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline GTK specific results after exposing JSSVGVKernElement/JSSVGHKernElement.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
02:28 Changeset [59011] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-05-08 Dirk Schulze <krit@webkit.org>

Unreviewed try to fix Win bot.

SVGFont's VKern implementation missing
https://bugs.webkit.org/show_bug.cgi?id=38663

  • bindings/scripts/CodeGeneratorJS.pm:
02:06 Changeset [59010] by krit@webkit.org
  • 31 edits
    7 adds in trunk

2010-05-08 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGFont's VKern implementation missing
https://bugs.webkit.org/show_bug.cgi?id=38663

Implementation of vkern, needed by SVGFont. Also added DOM and JS bindings
for vkern and hkern. Made some clean-up in SVGParserUtilities and SVGFontElement.
SVGHKernElement and SVGVKernElement share most of the code now.

Test: svg/text/text-vkern.svg

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.idl:
  • rendering/SVGRootInlineBox.cpp: (WebCore::applySVGKerning): (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
  • svg/SVGAllInOne.cpp:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::invalidateGlyphCache): (WebCore::SVGFontElement::ensureGlyphCache): (WebCore::matches): (WebCore::kerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs): (WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs):
  • svg/SVGFontElement.h: (WebCore::SVGKerningPair::SVGKerningPair): (WebCore::SVGFontElement::rendererIsNeeded):
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::buildHorizontalKerningPair):
  • svg/SVGHKernElement.h:
  • svg/SVGParserUtilities.cpp: (WebCore::parseGlyphName): (WebCore::parseKerningUnicodeString):
  • svg/SVGParserUtilities.h:
  • svg/SVGVKernElement.cpp: Added. (WebCore::SVGVKernElement::SVGVKernElement): (WebCore::SVGVKernElement::~SVGVKernElement): (WebCore::SVGVKernElement::insertedIntoDocument): (WebCore::SVGVKernElement::removedFromDocument): (WebCore::SVGVKernElement::buildVerticalKerningPair):
  • svg/SVGVKernElement.h: Added. (WebCore::SVGVKernElement::rendererIsNeeded):
  • svg/SVGVKernElement.idl: Added.
  • svg/svgtags.in:

2010-05-08 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGFont's VKern implementation missing
https://bugs.webkit.org/show_bug.cgi?id=38663

The changes in DOMWindow.idl and the implementation of the DOM
and JS bindings of VKern and HKern made some updates necessary.
Added new test case for SVGFont's VKern.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/mac/svg/text/text-vkern-expected.checksum: Added.
  • platform/mac/svg/text/text-vkern-expected.png: Added.
  • platform/mac/svg/text/text-vkern-expected.txt: Added.
  • svg/custom/global-constructors-expected.txt:
  • svg/text/text-vkern.svg: Added.

2010-05-08 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGFont's VKern implementation missing
https://bugs.webkit.org/show_bug.cgi?id=38663

  • projects/svg/status.xml:
01:44 Changeset [59009] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

Unreviewed, just fixing windows build.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h: Add #if USE(ACCELERATED_COMPOSITING) guards around GraphicsLayer areas of the code. Include GraphicsLayer.h directly.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: As above.
  • platform/graphics/win/QTMovieVisualContext.cpp: Remove the #include of d3d9types.h.
01:26 Changeset [59008] by jer.noble@apple.com
  • 2 edits in trunk/WebCore/platform/graphics/win

Fix the windows build (by adding #if USE(ACCELERATED_COMPOSITING) guards).

00:38 Changeset [59007] by jer.noble@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h

Fix the windows build.

00:24 Changeset [59006] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-05-08 Eric Seidel <eric@webkit.org>

Reviewed by Daniel Bates.

test-webkitpy fails under cygwin
https://bugs.webkit.org/show_bug.cgi?id=38718

  • Scripts/webkitpy/common/system/executive.py:
    • Add _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE and _KILL_ALL_KILLED_PROCESS_EXIT_CODE to store the expected exit codes of processes killed by kill_process and kill_all. These two constants are only used by the unit tests but are stored in executive.py so they can be right next to the platform ifs.
    • Remove unnecessary str() conversion, run_command does that for us.
    • Make os.kill retry on cygwin on EAGAIN. It's unclear why CYGWIN throws EAGAIN, but it only does so sometimes. 3 may not be enough retries, but we'll try it to start with.
    • Add _windows_image_name to automatically convert "yes" to "yes.exe" for use with taskkill.exe /im. Various callers to kill_all could be updated to remove the .exe, but that can be done in another patch.
    • Use taskkill.exe for killall on cygwin.
  • Scripts/webkitpy/common/system/executive_unittest.py:
    • Use the new *_KILLED_PROCESS_EXIT_CODE constants which are correctly set to 0 on windows/cygwin systems where taskkill.exe is used.
    • Test _windows_image_name
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Add FIXME about including mac-snowleopard in baseline_search_path.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Make default_configuration actually read from the Configuration file.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
    • Test default_configuration
  • Scripts/webkitpy/layout_tests/port/win.py:
    • Need a basic baseline_search_path if --platform dryrun is to work.
00:14 Changeset [59005] by eric@webkit.org
  • 25 edits
    3 adds
    1 delete in trunk

2010-05-08 Eric Seidel <eric@webkit.org>

Unreviewed, just reverting commit.

REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
https://bugs.webkit.org/show_bug.cgi?id=38798

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitResolve):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_resolve_global):

2010-05-08 Eric Seidel <eric@webkit.org>

Unreviewed, just reverting commit.

REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
https://bugs.webkit.org/show_bug.cgi?id=38798

  • fast/js/global-resolve-through-eval-expected.txt: Added.
  • fast/js/global-resolve-through-eval.html: Added.
  • fast/js/script-tests/global-resolve-through-eval.js: Added. (accessGlobal): (accessLocal):
  • platform/win/Skipped:

2010-05-08 Eric Seidel <eric@webkit.org>

Unreviewed, just reverting commit.

REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
https://bugs.webkit.org/show_bug.cgi?id=38798

Test: fast/js/global-resolve-through-eval.html

  • bindings/js/JSCallbackData.h: (WebCore::JSCallbackData::JSCallbackData): (WebCore::JSCallbackData::~JSCallbackData): (WebCore::DeleteCallbackDataTask::create): (WebCore::DeleteCallbackDataTask::performTask): (WebCore::DeleteCallbackDataTask::isCleanupTask): (WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::JSCustomVoidCallback): (WebCore::JSCustomVoidCallback::~JSCustomVoidCallback):
  • bindings/js/JSCustomVoidCallback.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::):
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::):
  • workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownFinishTask::performTask): (WebCore::WorkerThreadShutdownStartTask::performTask):

2010-05-08 Eric Seidel <eric@webkit.org>

Unreviewed, just reverting commit.

REGRESSION(59000): r59000 contained all sorts of changes it should not have, needs revert.
https://bugs.webkit.org/show_bug.cgi?id=38798

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
00:08 Changeset [59004] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Unreviewed, QtWebKit versioning for the trunk.

The next version is going to be 2.1, based off the trunk.

  • Api/qwebkitglobal.h:

05/07/10:

23:56 Changeset [59003] by jer.noble@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/win/QTMovieVisualContext.cpp

Fix the windows build.

23:27 Changeset [59002] by zherczeg@webkit.org
  • 2 edits in trunk/WebCore

Fixed the inverse function of f(x) = ((x + 0.055) / 1.055) 2.4
https://bugs.webkit.org/show_bug.cgi?id=38735

Reviewed by Dirk Schulze

It is ((x (1 / 2.4)) * 1.055) - 0.055

Chromium pixel tests cover the issue.

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::transformColorSpace):

23:24 Changeset [59001] by jer.noble@apple.com
  • 14 edits
    4 copies
    2 moves
    10 adds in trunk

JavaScriptCore: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>

Reviewed by Maciej Stachowiak

Added cancelCallOnMainThread. callOnMainThread should always now be paired
with cancelCallOnMainThread in situations where the refcon passed to callOnMainThread
may be dealloced before the main thread function can be dispatched.

  • wtf/MainThread.cpp:

(WTF::FunctionWithContext::operator == ): Supports the FunctionWithContextFinder predicate functor.
(WTF::FunctionWithContextFinder::FunctionWithContextFinder): Predicate functor for use with Dequeue::findIf
(WTF::FunctionWithContextFinder::operator()):
(WTF::cancelCallOnMainThread):

  • wtf/MainThread.h:

WebCore: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
<https://bugs.webkit.org/show_bug.cgi?id=34005>
<rdar://problem/7569713>

Reviewed by Eric Carlson

The original functionality of QTMovieWin has been split between QTMovieGWorld,
and a new class: QTMovie. QTMovie contains all the "controller" parts (changing
the rate, seeking, etc) while QTMovieGWorld retains all the drawing code. QTMovieGWorld
now takes a QTMovie, and as such QTMovie is now retainable. QTMovieGWorld registers
itself as a client of QTMovie, so that it can receive load-state notifications,
and thus QTMovie must now support multiple clients. Movie tasking timer support
has been moved into its own class (QTMovieTask) and will be addressed in a future
patch. Most of the functions listed below only changed so much as their class name changed.

  • platform/graphics/win/QTMovie.cpp: Copied from WebCore/platform/graphics/win/QTMovieWin.cpp.

(QTMoviePrivate::QTMoviePrivate):
(QTMoviePrivate::~QTMoviePrivate):
(QTMoviePrivate::startTask):
(QTMoviePrivate::endTask):
(QTMoviePrivate::task):
(QTMoviePrivate::createMovieController):
(QTMovie::QTMovie):
(QTMovie::~QTMovie):
(QTMovie::addClient):
(QTMovie::removeClient):
(QTMovie::play):
(QTMovie::pause):
(QTMovie::rate):
(QTMovie::setRate):
(QTMovie::duration):
(QTMovie::currentTime):
(QTMovie::setCurrentTime):
(QTMovie::setVolume):
(QTMovie::setPreservesPitch):
(QTMovie::dataSize):
(QTMovie::maxTimeLoaded):
(QTMovie::loadState):
(QTMovie::getNaturalSize):
(QTMovie::load):
(QTMovie::disableUnsupportedTracks):
(QTMovie::isDisabled):
(QTMovie::setDisabled):
(QTMovie::hasVideo):
(QTMovie::hasAudio):
(QTMovie::hasClosedCaptions):
(QTMovie::setClosedCaptionsVisible):
(QTMovie::countSupportedTypes):
(QTMovie::getSupportedType):
(QTMovie::initializeQuickTime):
(QTMovie::getMovieHandle):

  • platform/graphics/win/QTMovie.h: Copied from WebCore/platform/graphics/win/QTMovieWin.h.
  • platform/graphics/win/QTMovieGWorld.cpp: Copied from WebCore/platform/graphics/win/QTMovieWin.cpp.

(QTMovieGWorldPrivate::QTMovieGWorldPrivate):
(QTMovieGWorldPrivate::~QTMovieGWorldPrivate):
(QTMovieGWorldPrivate::cacheMovieScale):
(movieDrawingCompleteProc):
(QTMovieGWorldPrivate::registerDrawingCallback):
(QTMovieGWorldPrivate::unregisterDrawingCallback):
(QTMovieGWorldPrivate::drawingComplete):
(QTMovieGWorldPrivate::updateGWorld):
(QTMovieGWorldPrivate::createGWorld):
(QTMovieGWorldPrivate::clearGWorld):
(QTMovieGWorldPrivate::setSize):
(QTMovieGWorldPrivate::updateMovieSize):
(QTMovieGWorldPrivate::deleteGWorld):
(QTMovieGWorldPrivate::movieEnded):
(QTMovieGWorldPrivate::movieLoadStateChanged):
(QTMovieGWorldPrivate::movieTimeChanged):
(QTMovieGWorld::QTMovieGWorld):
(QTMovieGWorld::~QTMovieGWorld):
(QTMovieGWorld::setSize):
(QTMovieGWorld::setVisible):
(QTMovieGWorld::getCurrentFrameInfo):
(QTMovieGWorld::paint):
(QTMovieGWorld::setDisabled):
(QTMovieGWorld::isDisabled):
(QTMovieGWorld::fullscreenWndProc):
(QTMovieGWorld::enterFullscreen):
(QTMovieGWorld::exitFullscreen):
(QTMovieGWorld::setMovie):
(QTMovieGWorld::movie):

  • platform/graphics/win/QTMovieGWorld.h: Copied from WebCore/platform/graphics/win/QTMovieWin.h.
  • platform/graphics/win/QTMovieTask.cpp: Added.

(QTMovieTask::QTMovieTask):
(QTMovieTask::~QTMovieTask):
(QTMovieTask::sharedTask):
(QTMovieTask::updateTaskTimer):
(QTMovieTask::fireTaskClients):
(QTMovieTask::addTaskClient):
(QTMovieTask::removeTaskClient):
(QTMovieTask::setTaskTimerFuncs):

  • platform/graphics/win/QTMovieTask.h: Added.

WebKit/win: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
https://bugs.webkit.org/show_bug.cgi?id=34005

Reviewed by Adele Peterson.

QTMovieWin is now QTMovieGWorld.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::movie):

  • FullscreenVideoController.h:
23:10 Changeset [59000] by eric@webkit.org
  • 25 edits
    1 add
    3 deletes in trunk

2010-05-06 Eric Seidel <eric@webkit.org>

Reviewed by Daniel Bates.

test-webkitpy fails under cygwin
https://bugs.webkit.org/show_bug.cgi?id=38718

  • Scripts/webkitpy/common/system/executive.py:
    • Add _KILL_PROCESS_KILLED_PROCESS_EXIT_CODE and _KILL_ALL_KILLED_PROCESS_EXIT_CODE to store the expected exit codes of processes killed by kill_process and kill_all. These two constants are only used by the unit tests but are stored in executive.py so they can be right next to the platform ifs.
    • Remove unnecessary str() conversion, run_command does that for us.
    • Make os.kill retry on cygwin on EAGAIN. It's unclear why CYGWIN throws EAGAIN, but it only does so sometimes. 3 may not be enough retries, but we'll try it to start with.
    • Add _windows_image_name to automatically convert "yes" to "yes.exe" for use with taskkill.exe /im. Various callers to kill_all could be updated to remove the .exe, but that can be done in another patch.
    • Use taskkill.exe for killall on cygwin.
  • Scripts/webkitpy/common/system/executive_unittest.py:
    • Use the new *_KILLED_PROCESS_EXIT_CODE constants which are correctly set to 0 on windows/cygwin systems where taskkill.exe is used.
    • Test _windows_image_name
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
    • Add FIXME about including mac-snowleopard in baseline_search_path.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • Make default_configuration actually read from the Configuration file.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
    • Test default_configuration
  • Scripts/webkitpy/layout_tests/port/win.py:
    • Need a basic baseline_search_path if --platform dryrun is to work.
23:03 Changeset [58999] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-07 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

DryrunTest fails on every platform other than mac
https://bugs.webkit.org/show_bug.cgi?id=38796

The test uses the port detection logic to find a suitable
port to use results from. However that detection logic assumes
chromium on linux, which requires a chromium checkout which the
bots don't have. The test is broken and we'll need to fix it.
For now I'm just going to disable the test on all platforms besides mac.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
23:01 Changeset [58998] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-05-07 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dmitry Titov.

JSCallbackData is deleted on the Main thread, not the Context thread.
https://bugs.webkit.org/show_bug.cgi?id=38623

No new tests; you'll only see a problem after the worker-access-to-DB
code goes in. Without this fix, the GTK bots assert, but it's
timing-sensitive and not truly platform-specific.

  • bindings/js/JSCallbackData.h: (WebCore::JSCallbackData::JSCallbackData): (WebCore::JSCallbackData::~JSCallbackData): Store the allocating thread, then assert that we're on it at deletion.

(WebCore::DeleteCallbackDataTask):
This is the task that can get posted to the context thread for cleanup.

  • bindings/js/JSCustomVoidCallback.cpp:
  • bindings/js/JSCustomVoidCallback.h: This callback isn't autogenerated, so we have to do the cleanup manually.
  • bindings/scripts/CodeGeneratorJS.pm: Add the proper cleanup to all autogenerated callbacks.
  • workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownFinishTask::performTask): (WebCore::WorkerThreadShutdownStartTask::performTask): WorkerContext::clearScript can't be called until the posted deletion tasks have completed; move the call from shutdown start to shutdown finish.
22:51 Changeset [58997] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to turn Windows bots green again.

Skip two failing tests:

https://bugs.webkit.org/show_bug.cgi?id=38794
fast/css/display-none-inline-style-change-crash.html (fails on Windows Release bot)

https://bugs.webkit.org/show_bug.cgi?id=38795
inspector/timeline-paint.html

  • platform/win/Skipped:
22:35 Changeset [58996] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-05-07 Eric Seidel <eric@webkit.org>

Reviewed by Daniel Bates.

Clean up baseline_search_path to use map to reduce copy/paste code
https://bugs.webkit.org/show_bug.cgi?id=38792

Reading which portnames a port falls back to is easier if
we convert port names to paths with map instead of using copy/paste code.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
21:17 Changeset [58995] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-05-07 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r58990.
http://trac.webkit.org/changeset/58990

Broke 4 tests on Snow Leopard and Qt.

  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/JSCell.h:
21:00 Changeset [58994] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-07 Eric Seidel <eric@webkit.org>

Reviewed by Daniel Bates.

rollout commands fail when commit is missing bug number
https://bugs.webkit.org/show_bug.cgi?id=38791

  • Scripts/webkitpy/tool/commands/download.py:
    • _commit_info failed to actually return the CommitInfo in the no-bug-id case.
  • Scripts/webkitpy/tool/commands/download_unittest.py:
    • Test that the fix worked.
20:19 Changeset [58993] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Optimize access to the global object from a function that uses eval
https://bugs.webkit.org/show_bug.cgi?id=38644

Reviewed by Gavin Barraclough.

JavaScriptCore:

Fix bug where cross scope access to a global var (vs. property) would
be allowed without checking for intervening dynamic scopes.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolve):

LayoutTests:

Add test case to ensure we don't incorrectly allow dynamic scopes
to be skipped when doing direct var access.

  • fast/js/global-resolve-through-eval-expected.txt: Added.
  • fast/js/global-resolve-through-eval.html: Added.
  • fast/js/script-tests/global-resolve-through-eval.js: Added.

(accessGlobal):
(accessLocal):

20:16 Changeset [58992] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fix JSC binding generation to match webkit style
https://bugs.webkit.org/show_bug.cgi?id=38173

Add spaces around "|" to match webkit style.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp:
19:49 Changeset [58991] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Macro expansion I stab at thee!

32bit test fix

19:18 Changeset [58990] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Optimized o[s] where o is a cell and s is a string, removing some old
code that wasn't really tuned for the JIT.

Reviewed by Darin Adler.

SunSpider says 0.8% faster.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSCell.h:
18:27 Changeset [58989] by dumi@chromium.org
  • 25 edits
    8 adds in trunk/WebCore

Adding the IDL files for the sync DB API and the stubs for the JS and V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Brady Eidson.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDatabaseSyncCustom.cpp: Added.

(WebCore::JSDatabaseSync::changeVersion):
(WebCore::createTransaction):
(WebCore::JSDatabaseSync::transaction):
(WebCore::JSDatabaseSync::readTransaction):

  • bindings/js/JSSQLTransactionSyncCustom.cpp: Added.

(WebCore::JSSQLTransactionSync::executeSql):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::openDatabaseSync):

  • bindings/v8/custom/V8BindingMacros.h: Added.
  • bindings/v8/custom/V8DatabaseSyncCustom.cpp: Added.

(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):
(WebCore::V8DatabaseSync::transactionCallback):
(WebCore::V8DatabaseSync::readTransactionCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp: Added.

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::openDatabaseSyncCallback):

  • storage/Database.idl:
  • storage/DatabaseCallback.h:
  • storage/DatabaseCallback.idl:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):

  • storage/DatabaseSync.h:
  • storage/DatabaseSync.idl: Added.
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • storage/SQLTransactionSync.idl: Added.
  • storage/SQLTransactionSyncCallback.h:
  • storage/SQLTransactionSyncCallback.idl: Added.
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabaseSync):

  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:
18:05 Changeset [58988] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix

17:51 Changeset [58987] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

17:05 Changeset [58986] by oliver@apple.com
  • 20 edits in trunk/JavaScriptCore

2010-05-07 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Optimize access to the global object from a function that uses eval
https://bugs.webkit.org/show_bug.cgi?id=38644

Add op_resolve_global_dynamic, a variant of op_resolve_global that
checks each node in the scope chain for dynamically inserted properties
and falls back to the normal resolve logic in that case.

  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::isGlobalResolve): (JSC::CodeBlock::printStructures): (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::findScopedProperty):

Now take an additional reference parameter to used to indicate that
there were nodes that may gain dynamic properties

(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveWithBase):

deal with additional argument to findScopedProperty

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::FunctionCallResolveNode::emitBytecode): (JSC::PostfixResolveNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode): (JSC::ReadModifyResolveNode::emitBytecode): (JSC::AssignResolveNode::emitBytecode):

These functions use findScopedProperty directly in order to
optimise lookup. They cannot trivially handle any degree of
dynamism in the lookup so we just give up in such case.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::execute): (JSC::Interpreter::privateExecute):
  • interpreter/Interpreter.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_resolve_global_dynamic): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global_dynamic):

Happily resolve_global_dynamic can share the slow case!

  • jit/JITStubs.h: (JSC::):
  • runtime/JSActivation.cpp: (JSC::JSActivation::isDynamicScope):
  • runtime/JSActivation.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::isDynamicScope):
  • runtime/JSGlobalObject.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::isDynamicScope):
  • runtime/JSStaticScopeObject.h:
  • runtime/JSVariableObject.h:
16:53 Changeset [58985] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-07 Darin Fisher <darin@chromium.org>

Fix build bustage. Update to Chromium code that avoids a bad
dependency from net/ on chrome/.

  • DEPS:
16:51 Changeset [58984] by dpranke@chromium.org
  • 3 edits in trunk/LayoutTests

2010-05-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Alexey Proskuryakov.

Rewrite test to fail faster if the inner frame doesn't load at all
for some reason (previous version would raise a TypeError before
the timeout was set).

https://bugs.webkit.org/show_bug.cgi?id=38705

  • http/tests/security/sandbox-inherit-to-initial-document-2.html:
  • platform/chromium/test_expectations.txt:
16:35 Changeset [58983] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/7956972> REGRESSION: Can't focus and type
in GMail due to bad repainting
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=38782

Reviewed by Simon Fraser.

This patch reverts back to pre-r58797 behavior when
shouldPropagateCompositingToIFrameParent() is false.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintingGoesToWindow):

16:23 Changeset [58982] by andersca@apple.com
  • 8 edits in trunk/WebKit/mac

<rdar://problem/7947356>
QT Plug-in in hardware-accelerated WebKit is missing the controller

Reviewed by Sam Weinig and Simon Fraser.

Replace the useSoftwareRenderer boolean with an enum that lets the plug-in host opt into using a layer
backed NSView instead of inserting the layer into the WebCore layer hierarchy.

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::instantiatePlugin):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCInstantiatePluginReply):

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:

(WebKit::NetscapePluginInstanceProxy::rendererType):
(WebKit::NetscapePluginInstanceProxy::setRendererType):
(WebKit::NetscapePluginInstanceProxy::InstantiatePluginReply::InstantiatePluginReply):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Replace the useSoftwareRenderer boolean everywhere with the RendererType enum.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView createPlugin]):
Only go into full compositing mode when the renderer type returned is UseAcceleratedCompositing.
Otherwise, use a layer backed NSView.

  • Plugins/Hosted/WebKitPluginHostTypes.h:

Add a RendererType enum.

16:15 Changeset [58981] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-07 Darin Fisher <darin@chromium.org>

Fix build bustage. Update to Chromium code that no longer uses
deprecated methods.

  • DEPS:
16:10 Changeset [58980] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioBasicProcessorNode.cpp

Pull more AudioBasicProcessorNode::process() code inside the lock

15:55 Changeset [58979] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Fix AudioBasicProcessorNode::inputHasBeenConnected() to allow dynamic re-initialization.

  • this requires a lock around process()
  • also fix uninitialize() method
15:55 Changeset [58978] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Initial rough implementation for buffer source gain - later to be more optimized

15:55 Changeset [58977] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioResampler.cpp

More descriptive debugging message for resampler channel mismatch

15:55 Changeset [58976] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Add temporary mono and stereo processing busses for use by any processing node.

  • also change local variables from PassRefPtr to RefPtr
15:50 Changeset [58975] by darin@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-07 Darin Fisher <darin@chromium.org>

Fix build bustage: toElement<T> should be to<T>.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
15:18 Changeset [58974] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed Sputnik failure seen on buildbot.

Reviewed by Gavin Barraclough.

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString): Cast to unsigned before checking magnitude,
to efficiently exclude negative numbers, which require two characters
instead of one.

14:44 Changeset [58973] by johnnyg@google.com
  • 2 edits in trunk/WebCore

2010-05-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r58963.
http://trac.webkit.org/changeset/58963
https://bugs.webkit.org/show_bug.cgi?id=38773

Broke Chromium layout tests. (Requested by dcheng on #webkit).

  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):
14:18 Changeset [58972] by johnnyg@google.com
  • 2 edits
    6 adds in trunk/LayoutTests

2010-05-07 John Gregg <johnnyg@google.com>

Unreviewed [re-]baseline of chromium tests.

  • platform/chromium-linux/fast/frames/take-focus-from-iframe-expected.checksum: Added.
  • platform/chromium-linux/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.checksum: Added.
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.checksum: Added.
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt: Added.
  • platform/chromium-win/svg/hixie/error/017-expected.txt:
13:28 Changeset [58971] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Adjust the position of the comment on the WOFF test and
link to the bug report. This should fix a spurious error
while running layout tests.

  • platform/gtk/Skipped:
13:13 Changeset [58970] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Slightly more effective way to guarantee a compile-time constant, at
least on gcc.

Reviewed by Alexey Proskuryakov.

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString): Use pointer notation instead of array
notation, so the compiler treats the string and its contents as constant.

13:13 Changeset [58969] by krit@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-05-07 Dirk Schulze <krit@webkit.org>

Unreviewed fix of Windows test.

Windows need an platform dependent DRT result for clip-path-referencing-use2.svg,
Win doesn't have console output during DRT.

  • platform/win/svg/custom/clip-path-referencing-use2-expected.txt: Added.
13:03 Changeset [58968] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-05-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

https://bugs.webkit.org/show_bug.cgi?id=38769
ClipboardGtk should write the URL label in the text portion of the DataObject

No tests as this code path is currently unused in the GTK+ port.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::writeURL): Write the label to the text portion of the DataObject, instead of the URL.
12:57 Changeset [58967] by darin@chromium.org
  • 6 edits in trunk/WebKit/chromium

2010-05-07 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] clear out more deprecated methods that are no longer used
https://bugs.webkit.org/show_bug.cgi?id=38702

  • public/WebFrame.h:
  • public/WebNode.h:
  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:
  • src/WebNode.cpp:
12:56 Changeset [58966] by abarth@webkit.org
  • 2 edits
    1 add in trunk/JavaScriptCore

2010-05-07 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

[WTFURL] Add core URL parser
https://bugs.webkit.org/show_bug.cgi?id=38572

This patch adds the core of the URL parser. The URL parser uses a
templated notion of a code unit to support different string types.
Later we'll add some non-templated APIs with concrete types that
clients can use more conveniently.

The URLParser has a couple calls to ASSERT(), which I've commented out
for now. I'm not 100% sure how to handle the dependency issues there
yet, so I've punted on the issue for now.

Also, there are a number of methods that are declared public in this
patch that are only used by the canonicalizer. My plan is to make
those private or protected and make the canonicalizer a friend of the
parser. The details will be in a later patch.

  • wtf/url/src/URLComponent.h: (WTF::URLComponent::fromRange): (WTF::URLComponent::isNonEmpty): (WTF::URLComponent::isEmptyOrInvalid):
  • wtf/url/src/URLParser.h: Added. (WTF::URLParser::): (WTF::URLParser::isPossibleAuthorityTerminator): (WTF::URLParser::parseAuthority): (WTF::URLParser::extractScheme): (WTF::URLParser::parseAfterScheme): (WTF::URLParser::parseStandardURL): (WTF::URLParser::parsePath): (WTF::URLParser::parsePathURL): (WTF::URLParser::parseMailtoURL): (WTF::URLParser::parsePort): (WTF::URLParser::extractFileName): (WTF::URLParser::extractQueryKeyValue): (WTF::URLParser::isURLSlash): (WTF::URLParser::shouldTrimFromURL): (WTF::URLParser::trimURL): (WTF::URLParser::consecutiveSlashes): (WTF::URLParser::isPortDigit): (WTF::URLParser::nextAuthorityTerminator): (WTF::URLParser::parseUserInfo): (WTF::URLParser::parseServerInfo):
12:35 Changeset [58965] by zimmermann@webkit.org
  • 10 edits in trunk

2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGResourceClipper assigns a temporary mutated RenderStyle but does not correctly preserve the old style
https://bugs.webkit.org/show_bug.cgi?id=38767

Fix small logic error leading to a problem in RenderSVGResourceClipper. It assigns a new temporary RenderStyle
to the target object, but fails to reset it correctly to the old style. Fixes all svg/clip-path errors on the windows bots.

  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::createClipData):

2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGResourceClipper assigns a temporary mutated RenderStyle but does not correctly preserve the old style
https://bugs.webkit.org/show_bug.cgi?id=38767

Update baseline after fixing a logic error in RenderSVGResourceClipper.

  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.txt:
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt:
12:30 Changeset [58964] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Added a fast path for number-to-character conversion via
Number.prototype.toString base 36.

Reviewed by Oliver Hunt.

0.7% speedup on SunSpider.

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString): Made radix interpretation a little more
efficient by keeping it in int space. Turned "const char" into
"static const char" just in case. Added a fast path for base 36
conversion of something that will turn into a character.

12:23 Changeset [58963] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Add a few more files with Windows linefeeds to the .gitattributes file.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2010-05-07

  • .gitattributes:
11:46 Changeset [58962] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-05-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Fix debug-only render tree output to show object addresses in hex.

  • rendering/RenderTreeAsText.cpp: (WebCore::writeRenderObject): (WebCore::write):
11:40 Changeset [58961] by ap@apple.com
  • 3 edits
    4 adds in trunk

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=38546
Node.focus() fails to move focus from subframe properly

Test: fast/frames/take-focus-from-iframe.html

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas of focused frame get out of sync temporarily.
11:24 Changeset [58960] by zimmermann@webkit.org
  • 9 edits in trunk

2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

svg/custom/use-instanceRoot-as-event-target.xhtml crashes randomly
https://bugs.webkit.org/show_bug.cgi?id=37798

When creating JSEventListeners through attributes (onclick, etc..) or add/removeEventListener
calls on a SVGElementInstance, do NOT pass the element instance itself as JS wrapper object
but the correspondingElement(). SVGElementInstance redirects all event listener registrations
to the correspondingElement(), as they share an event listener list, per SVG spec. The old
code was very dangerous, leading to random assertions, when garbage collection teared down
the JSSVGElementInstance and event listeners fired, whose listeners were registered with
it, but residing in the correspondingElement() event listener list.

Removes the need for CustomToJS code for JSSVGElementInstance, which was wrong anyways. We hoped
to keep the event listeers alive by just creating a js wrapper of the correspondingElement(), that
could only work as long as garbage collection didn't tear it down, just luck. Also remove the
CustomPushEventHandlerScope marker, as it is only used for JSLazyEventListeners and only works
for JSNode derived objects, it was a no-op for SVGElementInstance, thus removed it.

Should fix all random crashes/assertions seen with svg/custom/use-instanceRoot-as-event-target.xhtml
See bug report for a detailed crash analysis.

  • bindings/js/JSSVGElementInstanceCustom.cpp: Remove custom toJS()/pushEventHandlerScope() handling, not necessary anymore. (WebCore::JSSVGElementInstance::markChildren):
  • bindings/scripts/CodeGeneratorJS.pm: For JSSVGElementInstance pass the correspondingElement() as JS wrapper object, not itself.
  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Be sure to trigger a style update here, so dirty shadow trees for <use> get rebuild. Otherwhise DOM may be out-of-sync. (WebCore::SVGElementInstance::eventTargetData): Add ASSERT_NOT_REACHED(), all event listener calls are forwarded to the correspondingElement(). (WebCore::SVGElementInstance::ensureEventTargetData): Ditto.
  • svg/SVGElementInstance.idl: Remove CustomToJS, CustomPushEventHandlerScope markers.

2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

svg/custom/use-instanceRoot-as-event-target.xhtml crashes randomly
https://bugs.webkit.org/show_bug.cgi?id=37798

Make use-instanceRoot-as-event-target.xhtml behave more correctly. Due a copy & paste problem test #7 was not executed. Fixed.
Make destruction more reliable, by using the standard js-test-post.js injection through <script> before calling notifyDone(), and "TEST COMPLETE" magically appears.

  • platform/mac/svg/hixie/error/017-expected.txt: Update result, now that invalidateAllInstancesOfElement(), correctly triggers <use> shadow tree rebuilds.
  • svg/custom/use-instanceRoot-as-event-target-expected.txt: Update result, was missing a "TEST COMPLETE" marker, and Test #7 was not executed before.
  • svg/custom/use-instanceRoot-as-event-target.xhtml: Fix typo, test #7 is now executed, it also had a bug which has been corrected.
11:20 Changeset [58959] by eric@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2010-05-07 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

[WTFURL] Add a malloc-backed URLBuffer
https://bugs.webkit.org/show_bug.cgi?id=38694

This patch adds a URLBuffer that uses new/delete to manage the backing
store for the buffer.

  • wtf/url/src/RawURLBuffer.h: Added. (WTF::RawURLBuffer::RawURLBuffer): (WTF::RawURLBuffer::~RawURLBuffer): (WTF::RawURLBuffer::resize):
11:05 Changeset [58958] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-05-07 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

[chromium]: Fixing Find in page crash on sites.google.com
https://bugs.webkit.org/show_bug.cgi?id=38591

setMarkerActive should not try to set a collapsed marker as
active. This can happen when you Edit a Sites page after doing
a Find operation and then you press FindNext.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkerActive):
10:52 Changeset [58957] by kbr@google.com
  • 38 edits
    4 adds in trunk

2010-05-06 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

WebCore::WebGLUnsignedIntArrayInternal::getCallback ReadAV@Arbitrary (deef89ee3d0345edebeaf13cf974c47c)
https://bugs.webkit.org/show_bug.cgi?id=38039

Web IDL now allows indexed getters and setters to be unnamed. Per
discussion in WebGL working group and recent update to spec,
removed the buggy get() and single-element set() methods from the
JavaScript bindings to the WebGL array types. Refactored set()
implementation in JSC bindings to share more code and modified V8
binding to look more like it. Added unit tests for indexed getter
with out-of-range indices and verifying removal of get and
single-element set methods. Updated existing WebGL array tests.

Tests: fast/canvas/webgl/array-get-and-set-method-removal.html

fast/canvas/webgl/array-get-out-of-bounds.html

  • bindings/js/JSWebGLArrayHelper.h: (WebCore::setWebGLArrayHelper):
  • bindings/js/JSWebGLByteArrayCustom.cpp: (WebCore::JSWebGLByteArray::set):
  • bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::set):
  • bindings/js/JSWebGLIntArrayCustom.cpp: (WebCore::JSWebGLIntArray::set):
  • bindings/js/JSWebGLShortArrayCustom.cpp: (WebCore::JSWebGLShortArray::set):
  • bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: (WebCore::JSWebGLUnsignedByteArray::set):
  • bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::set):
  • bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: (WebCore::JSWebGLUnsignedShortArray::set):
  • bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::setWebGLArrayHelper):
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp: (WebCore::V8WebGLByteArray::setCallback):
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: (WebCore::V8WebGLFloatArray::setCallback):
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp: (WebCore::V8WebGLIntArray::setCallback):
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp: (WebCore::V8WebGLShortArray::setCallback):
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: (WebCore::V8WebGLUnsignedByteArray::setCallback):
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: (WebCore::V8WebGLUnsignedIntArray::setCallback):
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: (WebCore::V8WebGLUnsignedShortArray::setCallback):
  • html/canvas/WebGLByteArray.h:
  • html/canvas/WebGLByteArray.idl:
  • html/canvas/WebGLFloatArray.h:
  • html/canvas/WebGLFloatArray.idl:
  • html/canvas/WebGLIntArray.h:
  • html/canvas/WebGLIntArray.idl:
  • html/canvas/WebGLShortArray.h:
  • html/canvas/WebGLShortArray.idl:
  • html/canvas/WebGLUnsignedByteArray.h:
  • html/canvas/WebGLUnsignedByteArray.idl:
  • html/canvas/WebGLUnsignedIntArray.h:
  • html/canvas/WebGLUnsignedIntArray.idl:
  • html/canvas/WebGLUnsignedShortArray.h:
  • html/canvas/WebGLUnsignedShortArray.idl:

2010-05-06 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

WebCore::WebGLUnsignedIntArrayInternal::getCallback ReadAV@Arbitrary (deef89ee3d0345edebeaf13cf974c47c)
https://bugs.webkit.org/show_bug.cgi?id=38039

Web IDL now allows indexed getters and setters to be unnamed. Per
discussion in WebGL working group and recent update to spec,
removed the buggy get() and single-element set() methods from the
JavaScript bindings to the WebGL array types. Refactored set()
implementation in JSC bindings to share more code and modified V8
binding to look more like it. Added unit tests for indexed getter
with out-of-range indices and verifying removal of get and
single-element set methods. Updated existing WebGL array tests.

  • fast/canvas/webgl/array-get-and-set-method-removal-expected.txt: Added.
  • fast/canvas/webgl/array-get-and-set-method-removal.html: Added.
  • fast/canvas/webgl/array-get-out-of-bounds-expected.txt: Added.
  • fast/canvas/webgl/array-get-out-of-bounds.html: Added.
  • fast/canvas/webgl/array-setters-expected.txt:
  • fast/canvas/webgl/array-setters.html:
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/bug-32456-expected.txt:
  • fast/canvas/webgl/bug-32456.html:
10:32 Changeset [58956] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-05-07 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: chromium dev tools tests fix.
Add a more strict check prior to accessing constructor property in
Web Inspector frontend.

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
10:30 Changeset [58955] by johnnyg@google.com
  • 3 edits in trunk/LayoutTests

2010-05-07 John Gregg <johnnyg@google.com>

Unreviewed, rebaseline for chromium.

  • platform/chromium-mac/fast/layers/video-layer-expected.checksum:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
10:03 Changeset [58954] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-05-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: On Linux/Windows panel history is
traversed while iterating over words in text prompt.

https://bugs.webkit.org/show_bug.cgi?id=38740

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt):
  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
09:59 Changeset [58953] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-05-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: come up with InjectedScript._className that works for both JSC and V8.

https://bugs.webkit.org/show_bug.cgi?id=38755

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
09:32 Changeset [58952] by johnnyg@google.com
  • 17 edits in trunk/LayoutTests

2010-05-07 John Gregg <johnnyg@google.com>

Unreviewed, rebaseline for chromium.

  • platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.checksum:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
08:54 Changeset [58951] by cjerdonek@webkit.org
  • 6 edits in trunk/WebKitTools

Refactored VCSUtils.pm's parse-related methods to leave inapplicable
hash values unset instead of setting them to "undef".

Reviewed by Daniel Bates.

https://bugs.webkit.org/show_bug.cgi?id=38724

Preferring "not set" over "undef" keeps the unit tests smaller and
easier to maintain. Otherwise, we would have to update every unit
test case each time we add support for a new key-value pair --
instead of just the relevant ones.

  • Scripts/VCSUtils.pm:
    • In parseGitDiffHeader(), adjusted the handling of these key-values: executableBitDelta and isBinary.
    • In parseSvnDiffHeader(), adjusted the handling of these key-values: copiedFromPath, isBinary, and sourceRevision.
    • In parseDiffHeader(), adjusted the handling of these key-values: isGit and isSvn.
    • In parseDiff(), adjusted the handling of these key-values: isBinary, isGit, isSvn, and sourceRevision.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
    • Updated the unit tests as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
    • Updated the unit tests as necessary.
08:42 Changeset [58950] by joepeck@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2010-05-07 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Adam Barth.

document.write is not synchronous after page load
https://bugs.webkit.org/show_bug.cgi?id=38146

If there are no pending scripts, a document.write call should be
synchronous. This matches other browsers and the HTML5 spec. Forcing
the tokenizer to be synchronous in Document::write does not affect
external scripts written by the write call. This should only change
behavior of document.write after the page is done loading.

Difficult to test reliably due to HTMLTokenizing relying on processing time.
I made a manual test because the test requires processing very large strings
synchronously and therefore can take some time.

Test: WebCore/manual-tests/dom/document-write-synchronous-after-page-load.html

  • dom/Document.cpp: (WebCore::SynchronousHTMLTokenizerGuard::SynchronousHTMLTokenizerGuard): if the provided tokenizer is an HTMLTokenizer make it synchronous (WebCore::SynchronousHTMLTokenizerGuard::~SynchronousHTMLTokenizerGuard): if the provided tokenizer was an HTMLTokenizer return its synchronous state (WebCore::Document::write): temporarily set the tokenizer to synchronous during document.write
  • dom/Tokenizer.h: (WebCore::Tokenizer::asHTMLTokenizer): default implementation returns 0, to be overridden by HTMLTokenizer
  • html/HTMLTokenizer.h: allow access to to the force synchronous state (WebCore::HTMLTokenizer::forceSynchronous): accessor (WebCore::HTMLTokenizer::asHTMLTokenizer): override the default to return itself
  • manual-tests/dom/document-write-synchronous-after-page-load.html: Added.
08:15 QtWebKitJournal edited by hausmann@webkit.org
(diff)
08:13 Changeset [58949] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix rendering of -webkit-user-select: none

Reviewed by Simon Hausmann.

-webkit-user-select: none is implemented by filling
the area with an invalid default-constructed Color.
In most ports passing an invalid color down to the
graphics backend seems to produce transparent fills.

In Qt the behavior of painting with an invalid QColor
is undefined, and in practice it results in painting
black opaque areas.

One way to fix this would be to use Qt::transparent
when converting an undefined Color to a QColor, but
Qt does not have short circuits for fully transparent
painting, and we actually end up in slow code paths
due to the transparency. So, we're better of doing the
short circuit in WebKit.

https://bugs.webkit.org/show_bug.cgi?id=38523

  • platform/graphics/qt/GraphicsContextQt.cpp:
08:04 Changeset [58948] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-07 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

Potential crash in EventHandler::handleTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=38646

Fix a ref counting bug that can cause a crash if the m_originatingouchPointTargets
hashmap holds the last ref to an EventTarget when the user lifts their finger.

This is very hard to reproduce in a consistent way and clearly a
simple logic error in the code, therefore no new tests.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Don't let the RefPtr we get back from

the hasmap go out of scope so soon as it could delete the wrapped ptr if the
hashmap held the last ref (and we use the raw ptr that the RefPtr
wraps later in the WebCore::Touch constructor).

08:03 Changeset [58947] by hausmann@webkit.org
  • 2 edits in trunk

Add a few more files with Windows linefeeds to the .gitattributes file.

  • .gitattributes:
07:08 Changeset [58946] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Kenneth Rohde Christiansen.

[GTK] Fails to build on GTK+ < 2.14
https://bugs.webkit.org/show_bug.cgi?id=38746

Build fix only. Do basically the same as gtk_adjustment_configure
would do if we are bellow GTK+ 2.14.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::AdjustmentConfigure):
06:43 Changeset [58945] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-05-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Crash with MgOpenModerna font, with non-UTF-8 character
https://bugs.webkit.org/show_bug.cgi?id=37795

NULL-check the font platform data, for now, to avoid the crash.

Could not yet figure out a way to get a test written that does not
involve adding the font to the tree, but there are doubts about
licensing.

  • platform/graphics/cairo/FontCacheCairo.cpp: (WebCore::FontCache::getFontDataForCharacters):
05:33 Changeset [58944] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Turn Tiger core builder green again, filed https://bugs.webkit.org/show_bug.cgi?id=38743 for failing webarchive/test-link-rel-icon.html.

  • platform/mac-tiger/Skipped:
05:31 Changeset [58943] by morrita@google.com
  • 6 edits in trunk/WebCore

2010-05-07 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

[Chromium] RenderThemeChromiumMac.mm should share the code with RenderThemeMac.mm
https://bugs.webkit.org/show_bug.cgi?id=37204

Made RenderThemeChromiumMac subclass of RenderThemeMac, instead of RenderTheme.
Added some method to RenderThemeMac for overriding on RenderThemeChromiumMac.

No new tests; Should have no behavioural change.

  • WebCore.gyp/WebCore.gyp:
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor): (WebCore::RenderThemeChromiumMac::documentViewFor): (WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
  • rendering/RenderThemeMac.h: (WebCore::RenderThemeMac::updateActiveState): Added for overriding
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::usesTestModeFocusRingColor): Added for overriding (WebCore::RenderThemeMac::documentViewFor): Added for overriding (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::setPopupButtonCellState): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::setSearchCellState): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): (WebCore::RenderThemeMac::adjustSliderThumbSize): (WebCore::RenderThemeMac::adjustMediaSliderThumbSize): Added for overriding (WebCore::RenderThemeMac::extraMediaControlsStyleSheet):
04:53 Changeset [58942] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with absent exports.

  • symbian/eabi/QtWebKitu.def:
00:32 Changeset [58941] by ukai@chromium.org
  • 5 edits in trunk

2010-05-06 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

JavaScriptCore/wtf/RandomNumber.h should provide using WTF::*
https://bugs.webkit.org/show_bug.cgi?id=38719

  • wtf/RandomNumber.h: Add using directives.

2010-05-06 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

JavaScriptCore/wtf/RandomNumber.h should provide using WTF::*
https://bugs.webkit.org/show_bug.cgi?id=38719

  • platform/graphics/wince/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
Remove WTF
prefix from randomNumber()
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString): Ditto.
Note: See TracTimeline for information about the timeline view.