Timeline


and

05/18/10:

23:45 Changeset [59748] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-18 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip test.

Skipping fast/workers/storage
https://bugs.webkit.org/show_bug.cgi?id=39346

  • platform/gtk/Skipped:
23:30 Changeset [59747] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make the HTML5 parser correctly parse <div>Hello</div>
https://bugs.webkit.org/show_bug.cgi?id=39345

Again, this patch is covered by a large number of LayoutTests.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::HTML5Lexer): (WebCore::HTML5Lexer::reset): (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitCommentToken): (WebCore::HTML5Lexer::emitCharacter): (WebCore::HTML5Lexer::emitCurrentTagToken):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::beginCharacter): (WebCore::HTML5Token::appendToCharacter): (WebCore::HTML5Token::characters):
  • html/HTML5Tokenizer.cpp: (WebCore::convertToOldStyle):
23:04 Changeset [59746] by barraclough@apple.com
  • 15 edits in trunk/JavaScriptCore

Bug 39343 - Dynamically generate a native call thunk per NativeFunction

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=39252 regressed performance on i386,
by adding an extra indirection to making a native call. By introducing per-
NativeFunction thunks we can hard code the function pointer into the thunk
so that it need not be loaded from the callee.

  • jit/JIT.h:

(JSC::JIT::compileCTINativeCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITStubs.cpp:

(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::getCTIStub):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

  • wtf/Platform.h:
22:30 Changeset [59745] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make the HTML5 parser actually parse <div></div>
https://bugs.webkit.org/show_bug.cgi?id=39342

This patch is covered by every LayoutTest. Yes. All of them. :)

  • html/HTML5Lexer.cpp: (WebCore::toLowerCase): (WebCore::HTML5Lexer::HTML5Lexer): (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitCharacter):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::HTML5Token): (WebCore::HTML5Token::beginStartTag): (WebCore::HTML5Token::beginEndTag): (WebCore::HTML5Token::appendToName): (WebCore::HTML5Token::type): (WebCore::HTML5Token::name): (WebCore::HTML5Token::selfClosing): (WebCore::HTML5Token::attrs):
  • html/HTML5Tokenizer.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5Tokenizer::write):
22:27 Changeset [59744] by tkent@chromium.org
  • 5 edits in trunk

[DRT/Chromium] Fix a repaint issue and textarea tests
https://bugs.webkit.org/show_bug.cgi?id=39054

Reviewed by Dimitri Glazkov.

WebKit/chromium:

  • DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion and textAreaResizeCorner.png
  • WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::canvas): Remove m_paintRect initialization in canvas().

This line updated m_paintRect unexpectedly during paintRect().
We don't need to initialize m_paintRect because show() does it.

22:12 Changeset [59743] by tony@chromium.org
  • 6 edits in trunk/WebKitTools

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] new-run-webkit-tests --use-drt should run on Linux
https://bugs.webkit.org/show_bug.cgi?id=37845

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
22:10 Changeset [59742] by ggaren@apple.com
  • 25 edits
    2 adds in trunk

JavaScriptCore: Simplified handling of 'arguments' -- 1.2% SunSpider speedup
https://bugs.webkit.org/show_bug.cgi?id=39200

Reviewed by Darin Adler.

Removed the reserved OptionalCalleeArguments slot from the CallFrame.
Now, slots for 'arguments' are allocated and initialized only by
functions that might need them.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump): Updated for new bytecode operands.

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::unmodifiedArgumentsRegister): Added a helper function for mapping
from the arguments register to its unmodified counterpart.

(JSC::CodeBlock::setArgumentsRegister):
(JSC::CodeBlock::argumentsRegister):
(JSC::CodeBlock::usesArguments): Changed from a "usesArguments" bool to
an optional int index representing the arguments register.

  • bytecode/Opcode.h: Updated for new bytecode operands.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar): Factored out a helper function for
allocating an anonymous var.

(JSC::BytecodeGenerator::BytecodeGenerator): Merged / simplified some
arguments vs activation logic, and added code to allocate the arguments
registers when needed.

(JSC::BytecodeGenerator::createArgumentsIfNecessary): Updated for new bytecode operands.

(JSC::BytecodeGenerator::emitCallEval): No need to create the arguments
object before calling eval; the activation object will lazily create the
arguments object if eval resolves it.

(JSC::BytecodeGenerator::emitReturn): Updated for new bytecode operands.

(JSC::BytecodeGenerator::emitPushScope):
(JSC::BytecodeGenerator::emitPushNewScope): Ditto emitCallEval.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::addVar): Factored out a helper function for
allocating an anonymous var.

(JSC::BytecodeGenerator::registerFor): No more need for special handling
of the arguments registers; they're allocated just like normal registers
now.

  • interpreter/CallFrame.h:

(JSC::ExecState::callerFrame):
(JSC::ExecState::init):

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::resetCallFrame): Nixed optionalCalleeArguments.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments): Opcodes accessing 'arguments' now
take operands specifying registers, just like all other opcodes.
JSActivation::copyRegisters is no longer responsible for tearing off the
arguments object; instead, the VM is responsible for both.

Also, a behavior change: Each access to f.arguments creates a new object,
unless f itself uses 'arguments'. This matches Chrome, and is necessary
for the optimization. f.arguments is a nonstandard, deprecated feature,
so high fidelity to a given implementation is not necessarily a goal.
Also, as illustrated by the new test case, the identity of f.arguments
has been broken since 2008, except in the case where f itself accesses
f.arguments -- but nobody seemed to notice. So, hopefully this change won't
break the web.

  • interpreter/Register.h: Nixed the special arguments accessor. It's no

longer needed.

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_arguments):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_arguments): The actual optimization: Removed
OptionalCalleeArguments from the callframe slot. Now, it doesn't need
to be initialized for most calls.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC::): Updated stubs to support arbitrary 'arguments' registers,
instead of hard-coding something in the call frame.

  • runtime/Arguments.h:

(JSC::JSActivation::copyRegisters): Removed some obfuscatory abstraction.

  • runtime/Executable.h:

(JSC::FunctionExecutable::generatedByteCode): Added a helper for accessing
the 'arguments' register. In a future patch, that kind of data should
probably move out of CodeBlock and into Executable.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::argumentsGetter):

  • runtime/JSActivation.h: Simplified / fixed access to 'arguments' via

the activation object. It now implements the same behavior implemented
by optimized variable access in the VM. This simplifies some other
things, too -- like eval code generation.

LayoutTests: Simplified handling of 'arguments' -- 1.2% SunSpider speedup
https://bugs.webkit.org/show_bug.cgi?id=39200

Reviewed by Darin Adler.

  • fast/js/function-dot-arguments-expected.txt:
  • fast/js/script-tests/function-dot-arguments.js:

(argumentsIdentity): Updated to match new behavior.

  • fast/js/function-dot-arguments2-expected.txt:
  • fast/js/function-dot-arguments2.html: New tests for some things that

weren't covered before.

  • fast/js/global-recursion-on-full-stack.html: Rejiggered the stack

usage in this test. Since stack usage is more efficient now, you
need a slightly different usage pattern to hit the exact thing this
test wanted to test.

  • fast/js/kde/script-tests/function_arguments.js:

(f): Updated to more specifically test what this was trying to test,
to avoid just testing the identity of f.arguments.

21:24 Changeset [59741] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed test fix.

fast/css/pseudo-required-optional-unapplied.html failure with ENABLE_METER_TAG
https://bugs.webkit.org/show_bug.cgi?id=39341

Remove test elements at the end of the test because dumpAsText() output
for <meter> depends on ENABLE_METER_TAG.

  • fast/css/pseudo-required-optional-unapplied-expected.txt:
  • fast/css/pseudo-required-optional-unapplied.html:
  • platform/qt/Skipped:
20:54 Changeset [59740] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/platform/qt/Skipped

Unreviewed. Add pseudo-required-optional-unapplied.html to qt/Skipped.
https://bugs.webkit.org/show_bug.cgi?id=39341

20:30 Changeset [59739] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
https://bugs.webkit.org/show_bug.cgi?id=38232

  • editing/execCommand/crash-indenting-list-item-expected.txt: Added.
  • editing/execCommand/crash-indenting-list-item.html: Added.

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
https://bugs.webkit.org/show_bug.cgi?id=38232

Test: editing/execCommand/crash-indenting-list-item.html

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::tryIndentingAsListItem): (WebCore::IndentOutdentCommand::indentIntoBlockquote):
20:15 Changeset [59738] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

':optional' pseudo selector should not be applied to <keygen> and <progress>
https://bugs.webkit.org/show_bug.cgi?id=39292

Reviewed by Darin Adler.

WebCore:

Test: fast/css/pseudo-required-optional-unapplied.html

  • html/HTMLKeygenElement.h:

(WebCore::HTMLKeygenElement::isOptionalFormControl):

Add isOptionalFormControl() returning false.
HTMLKeygenElement inherits HTMLSelectElement, which should return true
for isOptionalFormControl(). However, <keygen> is not :optional
according to the standard.

  • html/HTMLProgressElement.h: Remove isOptionalFormControl().

LayoutTests:

Add a test for non-optional form elements.

  • fast/css/pseudo-required-optional-unapplied-expected.txt: Added.
  • fast/css/pseudo-required-optional-unapplied.html: Added.
19:59 Changeset [59737] by tkent@chromium.org
  • 4 edits in trunk/WebKitTools

2010-05-18 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix some initialization/reset issues
https://bugs.webkit.org/show_bug.cgi?id=39281

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::reset): Reset m_userStyleSheetLocation.
  • DumpRenderTree/chromium/LayoutTestController.h: Remove unused variable, m_workQueueFrozen. (LayoutTestController::WorkQueue::WorkQueue): Initialize m_frozen.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController): Reset WebSettings too.
19:57 Changeset [59736] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement the DOCTYPE states for the HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39335

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken): (WebCore::emitCurrentDoctypeToken):
  • html/HTML5Lexer.h:
19:33 Changeset [59735] by tony@chromium.org
  • 3 edits
    1 add in trunk

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] ignore IME events if the keydown event was prevented
https://bugs.webkit.org/show_bug.cgi?id=37692

A manual test to verify the IME behavior since the existing methods of
textInputController test at a lower level than the fix.

  • manual-tests/ime-keydown-preventdefault.html: Added.

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] ignore IME events if the keydown event was prevented
https://bugs.webkit.org/show_bug.cgi?id=37692

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleCompositionEvent):
19:26 Changeset [59734] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix the build for platforms that don't always include UnusedParam.h

  • dom/Attribute.cpp:
19:24 Changeset [59733] by morrita@google.com
  • 7 edits in trunk

2010-05-18 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Windows: Determinate progress bar should have glossy overlay
https://bugs.webkit.org/show_bug.cgi?id=39269

  • Moved animation code from RenderThemeChromiumWin to chromium tree because it should be behind the theme implementation, which lives in chromium tree.
  • Passed current time to the bridge, which will be used to compute the state of the theme animation.

No new tests, animation effect can be confirmed only manually.

  • platform/chromium/ChromiumBridge.h:
  • rendering/RenderProgress.h: (WebCore::RenderProgress::animationStartTime): Added.
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar): (WebCore::RenderThemeChromiumWin::paintProgressBar):

2010-05-18 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Windows: Determinate progress bar should have glossy overlay
https://bugs.webkit.org/show_bug.cgi?id=39269

Changed WebThemeEngine::drawProgressBar() signature to delegate
theme implementation detail to the engine.
Chromium side will come to http://crbug.com/44430.

No new tests, animation effect can be confirmed only manually.

  • public/WebThemeEngine.h: (WebKit::WebThemeEngine::paintProgressBar):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::paintProgressBar):
19:18 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
19:12 Changeset [59732] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix release build.

  • dom/Attribute.cpp:

(WebCore::Attribute::unbindAttr):

18:56 Changeset [59731] by weinig@apple.com
  • 4 edits in trunk/WebCore

Move Attr pointer from Attribute to a global HashMap.
https://bugs.webkit.org/show_bug.cgi?id=39337
<rdar://problem/8001168>

Reviewed by Maciej Stachowiak.

Shaves another word off of Attribute.

  • dom/Attr.cpp:

(WebCore::Attr::Attr):
(WebCore::Attr::~Attr):

  • dom/Attribute.cpp:

(WebCore::attributeAttrMap):
(WebCore::Attribute::attr):
(WebCore::Attribute::createAttrIfNeeded):
(WebCore::Attribute::bindAttr):
(WebCore::Attribute::unbindAttr):

  • dom/Attribute.h:

(WebCore::Attribute::Attribute):

18:52 Changeset [59730] by jamesr@google.com
  • 5 edits
    52 adds in trunk/LayoutTests

2010-05-18 James Robinson <jamesr@chromium.org>

Unreviewed.

Add leopard-specific pixel results for more tests that need them
https://bugs.webkit.org/show_bug.cgi?id=39325

This adds new Leopard baselines for all tests that currently
pass with tolerance=0 on Snow Leopard but fail on Leopard
with an image diff of <= 0.1%. These tests previously had
expectations in platform/mac that were Snow Leopard specific.

  • platform/mac-leopard/animations: Added.
  • platform/mac-leopard/animations/3d: Added.
  • platform/mac-leopard/animations/3d/change-transform-in-end-event-expected.checksum: Added.
  • platform/mac-leopard/animations/3d/change-transform-in-end-event-expected.png: Added.
  • platform/mac-leopard/compositing/animation: Added.
  • platform/mac-leopard/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
  • platform/mac-leopard/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
  • platform/mac-leopard/compositing/compositing-visible-descendant-expected.checksum: Added.
  • platform/mac-leopard/compositing/compositing-visible-descendant-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/fixed-position-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/fixed-position-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/partial-layout-update-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/partial-layout-update-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/mac-leopard/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
  • platform/mac-leopard/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/mac-leopard/compositing/masks: Added.
  • platform/mac-leopard/compositing/masks/direct-image-mask-expected.checksum: Added.
  • platform/mac-leopard/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/mac-leopard/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
  • platform/mac-leopard/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/mac-leopard/compositing/reflections/reflection-in-composited-expected.checksum: Added.
  • platform/mac-leopard/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/mac-leopard/compositing/reflections/reflection-ordering-expected.checksum: Added.
  • platform/mac-leopard/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/content-into-overflow-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/content-into-overflow-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/layer-repaint-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/mac-leopard/fast/borders: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.checksum: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.png: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-expected.checksum: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-expected.png: Added.
  • platform/mac-leopard/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/mac-leopard/fast/multicol: Added.
  • platform/mac-leopard/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/mac-leopard/media/controls-strict-expected.checksum:
  • platform/mac-leopard/media/controls-strict-expected.png:
  • platform/mac-leopard/media/video-display-toggle-expected.checksum:
  • platform/mac-leopard/media/video-display-toggle-expected.png:
  • platform/mac-leopard/media/video-replaces-poster-expected.checksum: Added.
  • platform/mac-leopard/media/video-replaces-poster-expected.png: Added.
18:32 Changeset [59729] by jpetsovits@rim.com
  • 1 edit
    2 adds in trunk/WebCore

2010-05-18 Jakob Petsovits <jpetsovits@rim.com>

Unreviewed, forgot to svn add source file in r59619.
http://trac.webkit.org/changeset/59619

  • platform/image-decoders/openvg: Added.
  • platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Added. (WebCore::RGBA32Buffer::asNewNativeImage):
18:16 Changeset [59728] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-18 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

[GTK] fast/dom/Geolocation/enabled.html is crashing on the bots
https://bugs.webkit.org/show_bug.cgi?id=39326

  • platform/gtk/Skipped: Skip another test causing crashes.
18:05 Changeset [59727] by yaar@chromium.org
  • 29 edits
    2 deletes in trunk

2010-05-18 Yaar Schnitman <yaar@chromium.org>

Unreviewed, rolling out r59693.
http://trac.webkit.org/changeset/59693
https://bugs.webkit.org/show_bug.cgi?id=37815

Broke GTK Release

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/JSMainThreadExecState.cpp: Removed.
  • bindings/js/JSMainThreadExecState.h: Removed.
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-18 Yaar Schnitman <yaar@chromium.org>

Unreviewed, rolling out r59693.
http://trac.webkit.org/changeset/59693
https://bugs.webkit.org/show_bug.cgi?id=37815

Broke GTK Release

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
17:57 Changeset [59726] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement comment states for HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39334

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
17:52 Changeset [59725] by dpranke@chromium.org
  • 11 edits
    23 adds in trunk/WebKitTools

2010-05-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: implement '--reset-results' flag to complement
the '--new-baseline' flag. '--new-baseline' will always write the
results into the platform directory; '--reset-results' will update the
existing baseline wherever it happens to be. Both sets of behavior
are useful in different circumstances.

https://bugs.webkit.org/show_bug.cgi?id=38879

  • Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Added.
  • Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/misc/crash.html: Added.
  • Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Added.
  • Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/misc/passing.html: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: Added.
  • Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/text/article-element.html: Added.
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
17:50 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
17:42 Changeset [59724] by andersca@apple.com
  • 15 edits
    1 delete in trunk/WebCore

2010-05-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move all member variables from MappedAttribute to Attribute.
https://bugs.webkit.org/show_bug.cgi?id=39336
<rdar://problem/8000853>

This saves one word because we no longer have any virtual member functions in Attribute, and
thus no vtable pointer.


I plan to remove MappedAttribute altogether in a subsequent commit.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
  • dom/Attribute.cpp: (WebCore::Attribute::clone):
  • dom/Attribute.h: (WebCore::Attribute::create): (WebCore::Attribute::style): (WebCore::Attribute::decl): (WebCore::Attribute::setDecl): (WebCore::Attribute::isMappedAttribute): (WebCore::Attribute::Attribute):
  • dom/MappedAttribute.cpp: Removed.
  • dom/MappedAttribute.h: (WebCore::MappedAttribute::create): (WebCore::MappedAttribute::MappedAttribute): (WebCore::toMappedAttribute):
  • dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::declCount): (WebCore::NamedMappedAttrMap::mapsEquivalent):
  • dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged):
  • svg/SVGSVGElement.cpp: (WebCore::updateCSSForAttribute):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute):
17:36 Changeset [59723] by jamesr@google.com
  • 1 edit
    36 adds in trunk/LayoutTests

2010-05-18 James Robinson <jamesr@chromium.org>

Unreviewed.

Add leopard-specific pixel results for tests that need them
https://bugs.webkit.org/show_bug.cgi?id=39325

This adds new Leopard baselines for all tests that currently
pass with tolerance=0 on Snow Leopard but fail on Leopard
with an image diff of <= 0.01%. These tests previously had
expectations in platform/mac that were Snow Leopard specific.

  • platform/mac-leopard/compositing/color-matching: Added.
  • platform/mac-leopard/compositing/color-matching/pdf-image-match-expected.checksum: Added.
  • platform/mac-leopard/compositing/color-matching/pdf-image-match-expected.png: Added.
  • platform/mac-leopard/compositing/reflections: Added.
  • platform/mac-leopard/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
  • platform/mac-leopard/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/overflow-into-content-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/overflow-into-content-expected.png: Added.
  • platform/mac-leopard/editing/pasteboard: Added.
  • platform/mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
  • platform/mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
  • platform/mac-leopard/fast/css: Added.
  • platform/mac-leopard/fast/css/pseudo-cache-stale-expected.checksum: Added.
  • platform/mac-leopard/fast/css/pseudo-cache-stale-expected.png: Added.
  • platform/mac-leopard/fast/frames: Added.
  • platform/mac-leopard/fast/frames/take-focus-from-iframe-expected.checksum: Added.
  • platform/mac-leopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/mac-leopard/fast/repaint: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/text/format-control-expected.checksum: Added.
  • platform/mac-leopard/fast/text/format-control-expected.png: Added.
  • platform/mac-leopard/plugins: Added.
  • platform/mac-leopard/plugins/qt-qwidget-plugin-expected.checksum: Added.
  • platform/mac-leopard/plugins/qt-qwidget-plugin-expected.png: Added.
  • platform/mac-leopard/transforms/svg-vs-css-expected.checksum: Added.
  • platform/mac-leopard/transforms/svg-vs-css-expected.png: Added.
  • platform/mac-leopard/transitions: Added.
  • platform/mac-leopard/transitions/move-after-transition-expected.checksum: Added.
  • platform/mac-leopard/transitions/move-after-transition-expected.png: Added.
17:36 Changeset [59722] by tony@chromium.org
  • 3 edits
    1 add in trunk

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24943
Command-B and Command-I do not generate keydown events in contentEditable regions.

  • manual-tests/style-keypress-events.html: Added.

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24943
Command-B and Command-I do not generate keydown events in contentEditable regions.

Manual test because performKeyEquivalent is not called by DRT.

Test: manual-tests/style-keypress-events.html

  • WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): Move style key handling until after webcore gets a chance to handle the event
17:31 Changeset [59721] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add more state to the HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39333

This code is just transliteration from the spec.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::HTML5Lexer): (WebCore::HTML5Lexer::nextToken):
  • html/HTML5Lexer.h:
16:55 Changeset [59720] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement two more lexer states
https://bugs.webkit.org/show_bug.cgi?id=39298

No tests because Eric is still working on wiring up the lexer to the
test harness.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitParseError): (WebCore::HTML5Lexer::emitCurrentTagToken):
  • html/HTML5Lexer.h:
16:53 Changeset [59719] by beidson@apple.com
  • 10 edits
    1 copy
    4 adds in trunk

Repro crash with many Google image search results
<rdar://problem/7685669> and https://bugs.webkit.org/show_bug.cgi?id=39323

Reviewed by Maciej Stachowiak.

WebCore:

When an iframe has a plugin resource as its src, that case bypassed the plugin sandboxing checks and continued to load
the data for the plugin resource. It handed that data off to a nonexistent Widget, causing a null deref and the crash.

By replacing PluginDocuments in sandboxes iframes with a new "SinkDocument" that just acts as a data sink, we prevent the
crash and also prevent actually loading the plugin binaries.

I filed https://bugs.webkit.org/show_bug.cgi?id=39330 to follow up and let us cancel the load as soon as we know we should.

Test: fast/loader/sandboxed-plugin-crash.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin): If the created document is a PluginDocument and the plugin sandbox flag is set,

replace it with a SinkDocument.

  • loader/PluginDocument.h:

(WebCore::PluginDocument::isPluginDocument): Make public (it was already public at the Document.h level).

Add a simple document/tokenizer pair that simply presents a blank HTML document and acts as a data sink for whatever
data is handed to it:

  • loader/SinkDocument.cpp: Added.

(WebCore::SinkTokenizer::SinkTokenizer):
(WebCore::SinkTokenizer::write):
(WebCore::SinkTokenizer::isWaitingForScripts):
(WebCore::SinkTokenizer::wantsRawData):
(WebCore::SinkTokenizer::writeRawData):
(WebCore::SinkTokenizer::stopParsing):
(WebCore::SinkTokenizer::finish):
(WebCore::SinkDocument::SinkDocument):
(WebCore::SinkDocument::createTokenizer):

  • loader/SinkDocument.h: Added.

(WebCore::SinkDocument::create):

LayoutTests:

  • fast/loader/resources/test.swf: Copied from LayoutTests/fast/replaced/resources/test.swf.
  • fast/loader/sandboxed-plugin-crash-expected.txt: Added.
  • fast/loader/sandboxed-plugin-crash.html: Added.
15:53 Changeset [59718] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-18 Martin Robinson <mrobinson@igalia.com>

No review necessary.

[GTK] fast/dom/Geolocation/enabled.html is crashing on the bots
https://bugs.webkit.org/show_bug.cgi?id=39326

  • platform/gtk/Skipped: Skip the crashing tests.
15:47 Changeset [59717] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-05-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Symbian build fix.

[Qt] Updated the def file with new exports after r59335.

  • symbian/eabi/QtWebKitu.def:
15:38 Changeset [59716] by weinig@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39321
Reduce the size of ListHashSets used by Document
<rdar://problem/7999388>

Reviewed by Anders Carlsson.

Reduce Membuster peak memory usage by ~450K by reducing the pool sizes
of the ListHashSets used by Document.

  • dom/Document.cpp:

(WebCore::Document::addStyleSheetCandidateNode):
(WebCore::Document::recalcStyleSelector):

  • dom/Document.h:
15:29 Changeset [59715] by jianli@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Updated WebCore/Change to correct the bug link.

15:14 Changeset [59714] by mrobinson@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-05-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DragClientGtk::startDrag leaks GdkEvents
https://bugs.webkit.org/show_bug.cgi?id=39322

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Properly clean up allocated GdkEvent.
14:59 Changeset [59713] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Return null when creating an ImageBuffer failed, due to for
instance a nulled pixmap.

Rubberstamped by Simon Hausmann.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):

14:55 Changeset [59712] by jianli@chromium.org
  • 7 edits in trunk

Fix bug 39285: fast/files/file-reader.html is timing out on all mac bots.
https://bugs.webkit.org/show_bug.cgi?id=39135

Reviewed by Dmitry Titov.

WebCore:

The timeout is caused by 59659 that changed the GC timer to 0 and thus
triggered a bug in FileReader code. The fix is to add more states so
that hasPendingActivity() can do the check correctly.

  • html/FileReader.cpp:

(WebCore::FileReader::FileReader):
(WebCore::FileReader::hasPendingActivity):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::terminate):
(WebCore::FileReader::didStart):
(WebCore::FileReader::didGetSize):
(WebCore::FileReader::didRead):
(WebCore::FileReader::didFinish):
(WebCore::FileReader::didFail):
(WebCore::FileReader::readyState):
(WebCore::FileReader::result):

  • html/FileReader.h:

(WebCore::FileReader::):

LayoutTests:

Re-enale the file reader test.

  • fast/files/file-reader-expected.txt:
  • fast/files/file-reader.html:
  • platform/mac/Skipped:
14:37 Changeset [59711] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2010-05-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Clean up GraphicsLayer naming code
https://bugs.webkit.org/show_bug.cgi?id=39316

Move code that generates a name for the GraphicsLayer (used in debug builds only) into
a new nameForLayer() method. Use it when naming the foreground layer.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::nameForLayer):
  • rendering/RenderLayerBacking.h:
14:22 Changeset [59710] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59556.

14:22 Changeset [59709] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59495.

14:22 Changeset [59708] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch/WebCore

Merge r59576.

14:22 Changeset [59707] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59486.

14:22 Changeset [59706] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59577.

14:22 Changeset [59705] by mrowe@apple.com
  • 3 edits
    1 add in branches/safari-533-branch/WebCore

Merge r59610.

14:22 Changeset [59704] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59609.

14:22 Changeset [59703] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59516.

14:21 Changeset [59702] by mrowe@apple.com
  • 1 edit
    1 add in branches/safari-533-branch/LayoutTests

Merge r59444.

14:21 Changeset [59701] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533-branch

Merge r59443.

14:21 Changeset [59700] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59390.

14:21 Changeset [59699] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59591.

14:21 Changeset [59698] by mrowe@apple.com
  • 11 edits in branches/safari-533-branch/WebCore

Merge r59629.

14:21 Changeset [59697] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59583.

14:21 Changeset [59696] by mrowe@apple.com
  • 6 edits in branches/safari-533-branch

Merge r59514.

14:21 Changeset [59695] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59587.

14:20 Changeset [59694] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch

Merge r59547.

14:15 Changeset [59693] by yaar@chromium.org
  • 29 edits
    2 adds in trunk

2010-05-18 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/JSMainThreadExecState.cpp: Added.
  • bindings/js/JSMainThreadExecState.h: Added. (WebCore::JSMainThreadExecState::currentState): (WebCore::JSMainThreadExecState::call): (WebCore::JSMainThreadExecState::evaluate): (WebCore::JSMainThreadExecState::JSMainThreadExecState): (WebCore::JSMainThreadExecState::~JSMainThreadExecState): (WebCore::JSMainThreadNullState::JSMainThreadNullState):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-18 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
14:11 Changeset [59692] by crogers@google.com
  • 13 edits
    2 copies
    2 adds in branches/audio

Add initial implementation for JavascriptAudioSourceNode

  • this is very experimental to get us quickly up and running
  • fix AudioContext to not use static global for timing!
  • unfinished steps at getting V8 bindings working again
13:52 Changeset [59691] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed: Speculative build fix for Chromium win.

  • platform/graphics/skia/SkiaFontWin.cpp: Properly set inlineCapacity.
13:39 Changeset [59690] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed fix for Chromium build break.

  • platform/graphics/skia/SkiaFontWin.cpp: Now set inlineCapacity param.
13:22 Changeset [59689] by dimich@chromium.org
  • 8 edits in trunk

DragData::asURL() shouldn't do file validity checks
https://bugs.webkit.org/show_bug.cgi?id=38711

Patch by Daniel Cheng <dcheng@chromium.org> on 2010-05-18
Reviewed by Darin Adler, Jian Li.

WebCore:

There's no point to trying to make sure the file is valid in
DragData::asURL(). It's better to ask for forgiveness than to ask for
permission, since asking for permission is prone to race conditions
and results in unnecessary I/O. Consumers of this function either:

  • need to verify the file exists themselves (e.g. the loader)
  • don't care about file validity (rich text drag-and-drop)
  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

WebKit/mac:

Change [NSPasteboard _web_bestURL] to still return a file URL for paths
that don't exist. Callers who care about the existence of the file or
whether or not it is a directory should check themselves when they
want to use the file. The directory check has been left in for now,
since the Mac implementation of ResourceHandle, which uses this function
indirectly via DragController::performDrag) handles directories somewhat
non-intuitively: it opens the parent directory in the Finder, rather
than opening the directory itself.

  • Misc/WebNSPasteboardExtras.mm:

(-[NSPasteboard _web_bestURL]):

LayoutTests:

Several layout tests depended on the fact that dropping a file would
never trigger navigation. This never happened to occur in the past,
since it just so happened that the filenames used in the tests never
resolved to files that exist. Since DragData::asURL() no longer tries
to verify file existence, the layout tests were updated to either
suppress navigation or log any navigation that should occur as part of
the test.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js:

(runTest.window.onbeforeunload):
(runTest):

  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:
13:21 Changeset [59688] by timothy@apple.com
  • 12 edits in trunk/WebCore

Fix a handful of various localization issues in the Web Inspector.

  • Localize strings that where not localized.
  • Make WebInspector.UIString work without bind.
  • Always pass WebInspector.UIString to Number.secondsToString and Number.bytesToString.
  • Never pass a variable to WebInspector.UIString, since that prevents auto-generation.
  • Use an ellipsis instead of three periods.

https://webkit.org/b/39303
rdar://problem/7997101

Reviewed by Adam Roben.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype.contentTabSelected):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
(WebInspector.ProfileDataGridNode.prototype.get data):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourceTimeCalculator.prototype.formatValue):
(WebInspector.ResourceTransferTimeCalculator.prototype.formatValue):
(WebInspector.ResourceTransferDurationCalculator.prototype.formatValue):
(WebInspector.ResourceTransferSizeCalculator.prototype.formatValue):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._registerShortcuts):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._contextMenu):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewCalculator):
(WebInspector.TimelineOverviewCalculator.prototype.formatValue):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.formatValue):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow):

  • inspector/front-end/inspector.js:

(WebInspector.loaded):
(WebInspector.setRecordingProfile):
(WebInspector.UIString):

13:16 Changeset [59687] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

Add an --html5-parser option to DumpRenderTree to allow testing the new HTML5Lexer
https://bugs.webkit.org/show_bug.cgi?id=39311

This flag allows us to run the new HTML5Lexer code.
Right now all documents parse as empty documents, but
now that we're able to run the code we can fix that.

Once we're able to lex a few basic documents I'll add
an --html5-parser flag to run-webkit-tests so that we test
running all of the layout tests with the HTML5 parser.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): (initializeGlobalsFromCommandLineOptions):
13:13 Changeset [59686] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another attempt to fix the build.

  • css/CSSCursorImageValue.cpp:
12:48 QtWebKitTriageRoster edited by hausmann@webkit.org
(diff)
12:46 QtWebKitBugs edited by hausmann@webkit.org
(diff)
12:45 Changeset [59685] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the windows build.

  • API/JSStringRefBSTR.cpp:
12:33 Changeset [59684] by aroben@apple.com
  • 2 edits in trunk/WebCore

Make accelerated compositing work on machines that don't support hardware vertex processing

Fixes <http://webkit.org/b/39299> <rdar://problem/7997692> Accelerated
compositing on Windows doesn't work on machines that don't support
hardware vertex processing, but should

Reviewed by Eric Carlson.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::createRenderer): Query the device
capabilities to decide whether to request hardware or software vertex
processing.

12:33 Changeset [59683] by aroben@apple.com
  • 3 edits
    1 move in trunk/WebCore

Make WKCACFLayerRenderer robust against temporary failure of Direct3DCreate9 and IDirect3D9::CreateDevice

For a short time after waking from sleep, Direct3DCreate9() will
return an IDirect3D9 for which IDirect3D9::CreateDevice will always
fail. Also during this time period, IDirect3D9::CreateDevice
will fail even for non-bad IDirect3D9s. (It will later start
succeeding.) WKCACFLayerRenderer now works around this behavior by
detecting when it might be in this situation and calling these
functions again later.

Fixes <http://webkit.org/b/39297> <rdar://problem/7997431> WebView
doesn't repaint until page reloads when page using hardware
acceleration loads just after waking from sleep

Reviewed by John Sullivan.

  • manual-tests/crash-and-no-repaint-after-wake-from-sleep.html:

Renamed from WebCore/manual-tests/crash-after-wake-from-sleep.html.
Modified to also include instructions for reproducing this bug.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Replaced
m_triedToCreateD3DRenderer with m_mightBeAbleToCreateDeviceLater. The
new member is initialized to true, since we haven't even tried to
create a device once yet.
(WebCore::WKCACFLayerRenderer::createRenderer): If we already have a
D3D device, or we don't have one and are sure that we won't be able to
create one later, just return the previously-created device, if any.
We assume that we won't be able to create a device later if this
function fails, unless the function fails due to CreateDevice failing.
As noted above, CreateDevice will sometimes temporarily fail and then
later start working again. When CreateDevice fails, we also assume
that we might have a bad IDirect3D9, so we get rid of the one we have
so a new (and hopefully non-bad) one will be allocated later.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Reset
m_mightBeAbleToCreateDeviceLater to true, since we no longer have a
device.
(WebCore::WKCACFLayerRenderer::paint): Before trying to paint, try to
create our D3D device and renderer. If this fails, we bail out, but if
we think we might be able to create a device later we schedule another
paint (via renderSoon()) so that we'll try again soon.

  • platform/graphics/win/WKCACFLayerRenderer.h: Replaced

m_triedToCreateD3DRenderer with m_mightBeAbleToCreateDeviceLater.

12:32 Changeset [59682] by aroben@apple.com
  • 2 edits
    1 add in trunk/WebCore

Fix a crash when a page that uses accelerated compositing loads soon after the computer wakes from sleep

The set-up:

For a short time after waking from sleep, IDirect3D9::CreateDevice
will fail. This caused WKCACFLayerRenderer::createRenderer to fail,
and meant that WKCACFLayerRenderer never allocated a root layer.
WebView wouldn't notice that createRenderer failed, and would go ahead
and try to use the root layer anyway, resulting in a crash.

The fix:

We now allocate the root layer (and all the other members of
WKCACFLayerRenderer that aren't dependent on having an
IDirect3DDevice9) in WKCACFLayerRenderer's constructor. This way the
layers will always be present, even when creating the D3D device
fails.

There are two remaining problems:

1) This results in slightly more memory usage in the case where

CreateDevice fails.

2) Once we get into this bad state, the WebView doesn't repaint

until we navigate somewhere else.

(2) is covered by
<http://webkit.org/b/39297>/<rdar://problem/7997431>. We'll fix it by
retrying CreateDevice later in hopes that it will succeed after more
time has passed. This will in turn fix (1). (We should never end up in
a case where CreateDevice fails forever because we already did some
preliminary checks in acceleratedCompositingAvailable().)

Fixes <http://webkit.org/b/39295> <rdar://problem/7971319> Crash
(preceded by assertion) in WKCACFLayerRenderer::setNeedsDisplay when
computer wakes from sleep on particular page

Reviewed by John Sullivan.

  • manual-tests/crash-after-wake-from-sleep.html: Added. This

is the Poster Circle demo from webkit.org/blog, but modified to
automatically reload every 5 seconds and with instructions to put the
computer to sleep and wake it up again.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Moved code to
initialize m_context, m_renderContext, and m_*Layer here...
(WebCore::WKCACFLayerRenderer::createRenderer): ...from here.

12:32 Changeset [59681] by aroben@apple.com
  • 2 edits in trunk/WebCore

Remove an unused member variable from WKCACFLayerRenderer

Rubber-stamped by Ada Chan.

  • platform/graphics/win/WKCACFLayerRenderer.h: Removed m_viewLayer,

which is unused.

12:25 Changeset [59680] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-05-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Allocate the m_preloads list hash set dynamically and free it when done.
https://bugs.webkit.org/show_bug.cgi?id=39309
<rdar://problem/7998495>

This saves about 6000 bytes on a fully loaded document.

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload): (WebCore::DocLoader::clearPreloads):
  • loader/DocLoader.h:
12:16 Changeset [59679] by andersca@apple.com
  • 2 edits in trunk/WebCore

Revert unintended indentation and unnecessary nested name specifier.

  • rendering/RenderBlock.cpp:

(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::insertPositionedObject):

11:58 Changeset [59678] by andersca@apple.com
  • 6 edits in trunk

2010-05-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add an inlineCapacity template parameter to ListHashSet and use it to shrink the positioned object list hash set.
https://bugs.webkit.org/show_bug.cgi?id=39304
<rdar://problem/7998366>

Add an inlineCapacity template parameter to ListHashSet.

  • wtf/ListHashSet.h: (WTF::::ListHashSet): (WTF::::operator): (WTF::::swap): (WTF::::~ListHashSet): (WTF::::size): (WTF::::capacity): (WTF::::isEmpty): (WTF::::begin): (WTF::::end): (WTF::::find): (WTF::::contains): (WTF::::add): (WTF::::insertBefore): (WTF::::remove): (WTF::::clear): (WTF::::unlinkAndDelete): (WTF::::appendNode): (WTF::::insertNodeBefore): (WTF::::deleteAllNodes): (WTF::::makeIterator): (WTF::::makeConstIterator): (WTF::deleteAllValues):

2010-05-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add an inlineCapacity template parameter to ListHashSet and use it to shrink the positioned object list hash set.
https://bugs.webkit.org/show_bug.cgi?id=39304
<rdar://problem/7998366>

Set the inlineCapacity for the positionedObjects ListHashSet to 4 instead of 256. Since a RenderBlock usually has
few positioned objects, this saves memory.

  • WebCore.base.exp:
  • rendering/RenderBlock.cpp: (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::insertPositionedObject):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
11:43 Changeset [59677] by weinig@apple.com
  • 11 edits
    2 moves in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39258
Remove NamedAttrMap residual gunk

Reviewed by Darin Adler.

Replace NamedAttrMap.h/cpp with NamedNodeMap.h/cpp which was the class
it contained.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/custom/V8NamedNodesCollection.cpp:
  • dom/NamedAttrMap.cpp: Removed.
  • dom/NamedAttrMap.h: Removed.
  • dom/NamedNodeMap.cpp: Copied from dom/NamedAttrMap.cpp.
  • dom/NamedNodeMap.h: Replaced with dom/NamedAttrMap.h.
  • editing/ReplaceNodeWithSpanCommand.cpp:
  • platform/chromium/ClipboardChromium.cpp:
11:32 Changeset [59676] by loki@webkit.org
  • 5 edits in trunk/JavaScriptCore

Fix the interpreter after r59637
https://bugs.webkit.org/show_bug.cgi?id=39287

Reviewed by Darin Adler.

  • runtime/Executable.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):

  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:
11:28 Changeset [59675] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Build fix. Disable file-reader.html for more investigation.

  • platform/mac/Skipped:
11:28 Changeset [59674] by beidson@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/7993468> REGRESSION (r58586): Audio doesn't play on first click of play button at NPR.org

Reviewed by Eric Carlson.

NPR swallows the first mouse click on the play button, calls load() on the element, then waits for the
canplay event to come in before calling play itself.

After the site specific hack added in r58586, we disallowed play() from within the canplay event handler.
By tracking whether a load() was triggered by a user gesture, we can differentiate between the original
canplay event that we meant to ignore and the one resulting from the first mouse click which we want to honor.

No new tests. (Currently no way to test such site specific hack behavior)

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::load): Set the m_loadInitiatedByUserGesture flag
(WebCore::HTMLMediaElement::play): Only apply the site specific hack if the load wasn't initiated by a user gesture.

  • html/HTMLMediaElement.h:
11:09 Changeset [59673] by jpetsovits@rim.com
  • 3 edits in trunk/WebCore

2010-05-18 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Fix stupid build errors from the OpenVG Path commit
https://bugs.webkit.org/show_bug.cgi?id=39228

  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::clipPath):
  • platform/graphics/openvg/PathOpenVG.cpp: (WebCore::Path::transform):
10:30 Changeset [59672] by jianli@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Build fix. Disable test cases in file-reader.html that
cause time-out in mac bot for further investigation.

  • fast/files/file-reader-expected.txt:
  • fast/files/file-reader.html:
10:27 Changeset [59671] by jparent@chromium.org
  • 3 edits in trunk/BugsSite

Rietveld review page should dedicate more space to Rietveld, less to high level comments form.

Reviewed by Ojan Vafai.

https://bugs.webkit.org/show_bug.cgi?id=39244

  • template/en/custom/attachment/reviewform.html.tmpl:

Delete a random BR amongst the hidden elements that was causing extra whitespace.

  • template/en/custom/attachment/rietveldreview.html.tmpl:

Increase size of Rietveld frame to 80%, from 60%.

09:18 Changeset [59670] by cjerdonek@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by Darin Adler.

Refactored FrameLoader::isDocumentSandboxed() from a private member function
to a static, non-member, non-friend function.

https://bugs.webkit.org/show_bug.cgi?id=39157

Making this function non-private lets us make FrameLoader::createWindow()
a non-member function in a subsequent patch. We also made it non-member
rather than member to increase encapsulation and limit the number of
public functions with access to private FrameLoader data.

No new functionality, so no new tests.

  • loader/FrameLoader.cpp: (WebCore::isDocumentSandboxed):
    • Moved this function from a private member function of FrameLoader to a static, non-member, non-friend function.

(WebCore::FrameLoader::createWindow):

  • Updated the call to isDocumentSandboxed().

(WebCore::FrameLoader::submitForm):

  • Updated the call to isDocumentSandboxed().

(WebCore::FrameLoader::requestObject):

  • Updated the call to isDocumentSandboxed().

(WebCore::FrameLoader::shouldAllowNavigation):

  • Updated the call to isDocumentSandboxed().
  • loader/FrameLoader.h:
    • Removed isDocumentSandboxed() and added a FIXME to move createWindow() out of the FrameLoader class.
07:07 Changeset [59669] by hausmann@webkit.org
  • 5 edits in trunk

[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html

2010-05-08 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html

and http/tests/xmlhttprequest/cross-origin-authorization.html

QHttpNetworkRequest adds Authorization and Cookie headers to XHRs
without knowing if this is valid behaviour or not. In order to allow
Qt to decide whether Cookie/Authorization headers should be added
to an XHR QtWebKit needs to use an attribute added to QNetworkRequest.
These new attributes are: QNetworkRequest::CookieLoadControlAttribute,
QNetworkRequest::CookieSaveControlAttribute,and
QNetworkRequest::AuthenticationReuseControlAttribute.

QtWebKit will set QNetworkRequest::AuthenticationReuseControlAttribute to false
unless withCredentials is set to true in the XHR.

QtWebkit will set CookieLoad/SaveControlAttribute to false unless withCredentials
is set to true in the XHR.

Qt will pass the values onto QHttpNetworkRequest and this will permit
the Qt network access processing to decide whether or not to add either
or both of the Cookie/Authorisation headers, and whether to save cookies
returned from such requests. By default the attribute
will always be true so unless QtWebKit sets it to false normal
header processing is unaffected.

There are platform-specific results for cross-origin-no-authorization.html:

  1. Qt's DRT does not capture the final 'DONE'.
  2. QNetworkReplyHandler.cpp's ignoreHttpError() means that async requests do not execute didFail() when they receive a 401 HTTP response. This results in async tests passing with '401 Authorisation required' rather than 'received error event'.

The Qt part of these changes was merged at: http://gitorious.org/qt/qt/merge_requests/592

In order to properly support the tests, Qt's DRT needs to use one
NetworkAccessManager for all pages. This allows it to use cached
credentials where appropriate.

The tests now pass when run individually but there seems to be a problem with
leaking the results of requests across tests when run with the others in
http/tests. This will be addressed in a separate patch.

https://bugs.webkit.org/show_bug.cgi?id=32967

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/Skipped: Group together the tests that are waiting for 4.7 to be unskipped.
  • platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
06:25 Changeset [59668] by zherczeg@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Implementing clipToImageBuffer for Qt port.
https://bugs.webkit.org/show_bug.cgi?id=24289

Reviewed by Kenneth Rohde Christiansen.

The implementation combines pixmap layers and destinationIn
composition mode.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::TransparencyLayer::TransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::clipToImageBuffer):

04:04 Changeset [59667] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Eric Seidel <eric@webkit.org>

Unreviewed build fix.

Make it possible to enable the new HTML5Tokenizer for testing
https://bugs.webkit.org/show_bug.cgi?id=39275

  • WebCore.gypi:
    • Fix HTMLLexer.* -> HTML5Lexer.*
  • WebCore.vcproj/WebCore.vcproj:
    • Add HTML5Lexer and HTML5Tokenizer to project.
03:40 Changeset [59666] by ukai@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-18 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

run_webkit_tests_unittest fails on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=39279

  • Scripts/webkitpy/layout_tests/port/base.py: Return copy of os.environ.
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Check os.environ was not modified.
03:38 Changeset [59665] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-18 Eric Seidel <eric@webkit.org>

Unreviewed build fix.

Make it possible to enable the new HTML5Tokenizer for testing
https://bugs.webkit.org/show_bug.cgi?id=39275

  • dom/NamedAttrMap.cpp: (WebCore::NamedNodeMap::setNamedItemNS):
    • Move this to the .cpp file so as to avoid needing to include "Node.h" in the header.
  • dom/NamedAttrMap.h:
  • html/HTML5Token.h:
    • Remove #include "String.h" which was wrong. Adam meant "PlatformString.h"
    • Remove unneeded #include "Node.h", it was only needed because NamedAttrMap.h was incorrectly depending on Node.h but not including it. It didn't actually need Node.h except for one inlined method setNamedItemNS, so I moved setNamedItemNS into the .cpp to get rid of the Node.h requirement.
03:17 Changeset [59664] by eric@webkit.org
  • 20 edits
    2 copies in trunk

2010-05-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to enable the new HTML5Tokenizer for testing
https://bugs.webkit.org/show_bug.cgi?id=39275

I added html5ParserEnabled to Settings so that we can enable/disable
the HTML5 parser for testing.

I also ripped out a bunch of dead code from HTML5Lexer.

I had to add HTML5Lexer/HTML5Tokenizer to all build systems so that
the build wouldn't fail now that we reference these classes from HTMLDocument.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::reset): (WebCore::isWhitespace): (WebCore::HTML5Lexer::nextToken):
  • html/HTML5Lexer.h:
  • html/HTML5Tokenizer.cpp: Added. (WebCore::HTML5Tokenizer::HTML5Tokenizer): (WebCore::HTML5Tokenizer::~HTML5Tokenizer): (WebCore::HTML5Tokenizer::begin): (WebCore::HTML5Tokenizer::write): (WebCore::HTML5Tokenizer::end): (WebCore::HTML5Tokenizer::finish): (WebCore::HTML5Tokenizer::isWaitingForScripts):
  • html/HTML5Tokenizer.h: Added.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
  • html/HTMLTokenizer.h:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setHTML5ParserEnabled): (WebCore::Settings::html5ParserEnabled):

2010-05-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth (and Maciej Stachowiak).

Make it possible to enable the new HTML5Tokenizer for testing
https://bugs.webkit.org/show_bug.cgi?id=39275

Expose the WebCore::Settings::html5ParserEnabled as a private WebKit setting.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (-[WebPreferences html5ParserEnabled]): (-[WebPreferences setHTML5ParserEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
02:08 Changeset [59663] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2010-05-18 Maciej Stachowiak <mjs@apple.com>

Not reviewed, build fix.

Attempt to fix build for v8 bindings (untested).

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
  • bindings/v8/ScriptController.h:
02:04 Changeset [59662] by mjs@apple.com
  • 3 edits in trunk/WebCore

Not reviewed, build fix.

Attempt to fix build for v8 bindings (untested).

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearWindowShell):

  • bindings/v8/ScriptController.h:
01:52 Changeset [59661] by ukai@chromium.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-05-18 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Chromium: new-run-webkit-httpd fails to setup_mount
https://bugs.webkit.org/show_bug.cgi?id=39257

  • Scripts/webkitpy/common/system/executive.py: Assert type of args in run_command.
  • Scripts/webkitpy/common/system/executive_unittest.py: Add test_run_command_args_type
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Executive.run_command takes array for command line.
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Test if setup_environ_for_server() run setup_mount.bat.
01:42 Changeset [59660] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Fix QWebHistory serialization.

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2010-05-18
Reviewed by Simon Hausmann.

Regression was caused by bug 33224. The streaming function
should generate a documentSequenceNumber for all loaded values.

[Qt] tst_QWebHistory::serialize_2() fails
https://bugs.webkit.org/show_bug.cgi?id=37322

  • Api/qwebhistory.cpp:

(operator>>):

01:09 Changeset [59659] by mjs@apple.com
  • 5 edits in trunk/WebCore

2010-05-17 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

GC more promptly when navigating to a new inner window, but not at all when it went in the page cache
https://bugs.webkit.org/show_bug.cgi?id=39254
<rdar://problem/7996370>

~1% PLT speedup
~4% iBench HTML speedup

  • bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectSoon): Change back to a 0 delay timer instead of 0.5 second.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): Add a new boolean parameter. Don't garbageColectSoon if the page is going into the page cache.
  • bindings/js/ScriptController.h: Prototype change for above.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Indicate when the page is going into the page cache.
00:24 Changeset [59658] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement ScriptData states for HTML5Lexer
https://bugs.webkit.org/show_bug.cgi?id=39273

This patch implements more of the lexer states according to the HTML5
specification. Currently, this code is compiled by not tested. We're
working on bringing up a test harness in parallel with transliterating
the spec into code.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::tokenize): (WebCore::HTML5Lexer::temporaryBufferIs):
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::):
00:00 Changeset [59657] by eric@webkit.org
  • 2 edits
    2 moves in trunk/WebCore

2010-05-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename HTML5Tokenzier to HTML5Lexer so that we can add a new HTML5Tokenizer which implements Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39272

Strictly a rename, no functionality change.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5Lexer.cpp: Added.
  • html/HTML5Lexer.h: Added.
  • html/HTML5Tokenizer.cpp: Removed.
  • html/HTML5Tokenizer.h: Removed.

05/17/10:

23:01 Changeset [59656] by atwilson@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed test expectations update for chromium.

  • platform/chromium-mac/html5lib/runner-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt: Added.
22:56 Changeset [59655] by tkent@chromium.org
  • 8 edits in trunk

2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
http://trac.webkit.org/changeset/59652
https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js: (runTest):
  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:

2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
http://trac.webkit.org/changeset/59652
https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):

2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59652.
http://trac.webkit.org/changeset/59652
https://bugs.webkit.org/show_bug.cgi?id=39268

file-input-files-access test is broken on Mac (Requested by
dcheng on #webkit).

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_bestURL]):
22:51 Changeset [59654] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement RAWTEXT tokenizer states
https://bugs.webkit.org/show_bug.cgi?id=39267

More tokenizer states. There's a bunch of functionality notImplemented
that we'll come back to.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::tokenize):
  • html/HTML5Tokenizer.h:
22:17 Changeset [59653] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement more parser states in HTML5Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39265

This patch implements some easy states. I'll come back and do the
harder states later.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::tokenize): (WebCore::HTML5Tokenizer::emitParseError):
  • html/HTML5Tokenizer.h:
22:11 Changeset [59652] by tkent@chromium.org
  • 8 edits in trunk

2010-05-17 Daniel Cheng <dcheng@chromium.org>

DragData::asURL() shouldn't do file validity checks
https://bugs.webkit.org/show_bug.cgi?id=38711

Several layout tests depended on the fact that dropping a file would
never trigger navigation. This never happened to occur in the past,
since it just so happened that the filenames used in the tests never
resolved to files that exist. Since DragData::asURL() no longer tries
to verify file existence, the layout tests were updated to either
suppress navigation or log any navigation that should occur as part of
the test.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js: (runTest.window.onbeforeunload): (runTest):
  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:

2010-05-17 Daniel Cheng <dcheng@chromium.org>

Reviewed by Darin Adler.

DragData::asURL() shouldn't do file validity checks
https://bugs.webkit.org/show_bug.cgi?id=38711

There's no point to trying to make sure the file is valid in
DragData::asURL(). It's better to ask for forgiveness than to ask for
permission, since asking for permission is prone to race conditions
and results in unnecessary I/O. Consumers of this function either:

  • need to verify the file exists themselves (e.g. the loader)
  • don't care about file validity (rich text drag-and-drop)
  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):

2010-05-17 Daniel Cheng <dcheng@chromium.org>

Reviewed by Darin Adler.

DragData::asURL() shouldn't do file validity checks
https://bugs.webkit.org/show_bug.cgi?id=38711

Change [NSPasteboard _web_bestURL] to still return a file URL for paths
that don't exist. Callers who care about the existence of the file or
whether or not it is a directory should check themselves when they
want to use the file. The directory check has been left in for now,
since the Mac implementation of ResourceHandle, which uses this function
indirectly via DragController::performDrag) handles directories somewhat
non-intuitively: it opens the parent directory in the Finder, rather
than opening the directory itself.

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_bestURL]):
22:05 Changeset [59651] by tkent@chromium.org
  • 6 edits in trunk

Unreviewed. Roll out r59650.
A workaround of a buildbot issue triggered by r59650 wasn't resolved by r59646.

21:56 Changeset [59650] by tkent@chromium.org
  • 6 edits in trunk

[DRT/Chromium] Fix repaint, WebGL, textarea tests
https://bugs.webkit.org/show_bug.cgi?id=39054

Reviewed by Dimitri Glazkov.

WebKit/chromium:

  • DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion and textAreaResizeCorner.png
  • WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
  • features.gypi: Enable ENABLE_3D_CANVAS.

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::canvas): Remove m_paintRect initialization in canvas().

This line updated m_paintRect unexpectedly during paintRect().
We don't need to initialize m_paintRect because show() does it.

21:46 Changeset [59649] by yuzo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-16 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Add tests for Bug 31267 - :nth-child(-2n) should match no element.
http://trac.webkit.org/changeset/58300 has fixed this already.
https://bugs.webkit.org/show_bug.cgi?id=31267

  • fast/css/nth-child-negative-a-param-expected.txt: Added.
  • fast/css/nth-child-negative-a-param.html: Added.
21:27 Changeset [59648] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update states in HTML5Tokenizer to match HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=39264

I've also implemented the DataState. More states to follow.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::reset): (WebCore::HTML5Tokenizer::tokenize):
  • html/HTML5Tokenizer.h: (WebCore::HTML5Tokenizer::):
21:24 Changeset [59647] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed.

Update a test for the behavior change of r59645.
https://bugs.webkit.org/show_bug.cgi?id=39162

  • fast/forms/script-tests/willvalidate.js:
  • fast/forms/willvalidate-expected.txt:
21:04 Changeset [59646] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

Chromium Windows build system does not rebuild correctly when
enabling/disabling a feature
https://bugs.webkit.org/show_bug.cgi?id=38926

Reviewed by David Levin.

Add a workaround of this issue.

  • Scripts/update-webkit: Chromium-Windows only: If WebKit/chromium/features.gyp has been updated, remove WebKit/chromium/Debug and WebKit/chromium/Release.
20:57 Changeset [59645] by tkent@chromium.org
  • 7 edits in trunk

':valid' CSS selector should not be applied to some form controls
https://bugs.webkit.org/show_bug.cgi?id=39162

Reviewed by Darin Adler.

WebCore:

  • html/HTMLElement.cpp:

(WebCore::inlineTagList): Always includes progressTag. This change is
needed in a case of no ENABLE_PROGRESS_TAG. Without this change and
ENABLE_PROGRESS_TAG, <progress> tags disappear.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::recalcWillValidate):

Return false for SUBMIT and IMAGE.

  • html/HTMLProgressElement.h:

(WebCore::HTMLProgressElement::recalcWillValidate):

Return false. This change is needed in a case of ENABLE_PROGRESS_TAG.

LayoutTests:

Add test cases for

  • <input type=submit>
  • <input type=image>
  • <progress>
  • <meter>
  • fast/css/pseudo-valid-unapplied-expected.txt:
  • fast/css/pseudo-valid-unapplied.html:
20:41 Changeset [59644] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove load-related code from HTML5Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39263

This code is related to reloading resources and not to tokenizing. In
the PreloadScanner, these concerns are coupled, but we want to decouple
them.

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::HTML5Tokenizer): (WebCore::HTML5Tokenizer::~HTML5Tokenizer): (WebCore::HTML5Tokenizer::begin): (WebCore::HTML5Tokenizer::end): (WebCore::HTML5Tokenizer::reset): (WebCore::HTML5Tokenizer::write): (WebCore::HTML5Tokenizer::consumeEntity): (WebCore::HTML5Tokenizer::tokenize): (WebCore::HTML5Tokenizer::processAttribute): (WebCore::HTML5Tokenizer::emitCharacter): (WebCore::HTML5Tokenizer::emitTag):
  • html/HTML5Tokenizer.h:
20:25 Changeset [59643] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add HTML5Tokenizer to the build system on Mac
https://bugs.webkit.org/show_bug.cgi?id=39262

This file will be easier to work with if we're actually compiling it.
Hopefully we'll get this wired into the PreloadScanner soon. Once we
start actually calling the code, we'll add it to the build system on
other platforms.

  • WebCore.xcodeproj/project.pbxproj:
20:24 Changeset [59642] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Oops, meant ebx not eax there. Fix Qt (and probably Win too).

Reviewed by Geoff Garen.

  • jit/JITOpcodes32_64.cpp:
20:21 Changeset [59641] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39261

  • html/HTML5Tokenizer.cpp: Rename PreloadScanner to HTML5Tokenizer.
  • html/HTML5Tokenizer.h: ditto.
20:15 Changeset [59640] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39261

This time copy the cpp from the right file.

  • html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.cpp.
20:08 Changeset [59639] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-05-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Copy PreloadScanner.* to HTML5Tokenizer.* to start work on the new HTML5 Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39261

  • html/HTML5Tokenizer.cpp: Copied from WebCore/html/PreloadScanner.h.
  • html/HTML5Tokenizer.h: Copied from WebCore/html/PreloadScanner.h.
20:06 Changeset [59638] by abarth@webkit.org
  • 1 edit
    21 adds in trunk/LayoutTests

2010-05-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add the html5lib HTML parser tests
https://bugs.webkit.org/show_bug.cgi?id=39260

We currently fail a bunch of these. Hopefully we'll get better as we
implement the HTML5 parser.

Source: http://gsnedders.html5.org/html5lib-tests/runner.html

  • html5lib/resources/dom2string.js: Added. (String.prototype.toAsciiLowerCase): (indent): (dom2string):
  • html5lib/resources/tests1.dat: Added.
  • html5lib/resources/tests10.dat: Added.
  • html5lib/resources/tests11.dat: Added.
  • html5lib/resources/tests12.dat: Added.
  • html5lib/resources/tests13.dat: Added.
  • html5lib/resources/tests14.dat: Added.
  • html5lib/resources/tests15.dat: Added.
  • html5lib/resources/tests16.dat: Added.
  • html5lib/resources/tests2.dat: Added.
  • html5lib/resources/tests3.dat: Added.
  • html5lib/resources/tests4.dat: Added.
  • html5lib/resources/tests5.dat: Added.
  • html5lib/resources/tests6.dat: Added.
  • html5lib/resources/tests7.dat: Added.
  • html5lib/resources/tests8.dat: Added.
  • html5lib/resources/tests9.dat: Added.
  • html5lib/runner-expected.txt: Added.
  • html5lib/runner.html: Added.
19:39 Changeset [59637] by barraclough@apple.com
  • 20 edits in trunk/JavaScriptCore

Bug 39252 - Move host/native JSFunction's NativeFunction onto NativeExecutable.

Reviewed by Geoff Garen.

Currently host functions reuse JSFunction's ScopeChain as storage for their
NativeFunction (the C function pointer to the host function implementation).
Instead, move this onto NativeExecutable. This will allow host functions to
have a scopechain (which will be implemented as a separate patch).

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITStubs.cpp:

(JSC::JITThunks::specializedThunk):

  • jit/JITStubs.h:

(JSC::JITThunks::ctiNativeCall):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):

  • jit/ThunkGenerators.h:
  • runtime/Executable.h:

(JSC::NativeExecutable::create):
(JSC::NativeExecutable::function):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):

  • runtime/JSFunction.h:

(JSC::JSFunction::scope):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::getThunk):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

18:38 Changeset [59636] by atwilson@chromium.org
  • 4 edits in trunk/WebKitTools

2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59631.
http://trac.webkit.org/changeset/59631
https://bugs.webkit.org/show_bug.cgi?id=39255

chromium canaries can no longer run webkit_tests, suspect this
change. (Requested by atwilson on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
18:28 Changeset [59635] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-05-17 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Windows: Speed of indeterminate progress bar should be constant
https://bugs.webkit.org/show_bug.cgi?id=39211

No new tests, animation effect can be confirmed only manually.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar): (WebCore::RenderThemeChromiumWin::paintProgressBar):
17:58 Changeset [59634] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for Qt and Chromium. Added missing #include in Frame.h.

https://bugs.webkit.org/show_bug.cgi?id=39147

  • page/Frame.h: Now includes CSSMutableStyleDeclaration.h.
17:19 Changeset [59633] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-05-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Remove unused member member from Document
https://bugs.webkit.org/show_bug.cgi?id=39251

Remove m_associatedHistoryItems from Document; it is never used.

  • dom/Document.h:
17:15 Changeset [59632] by darin@apple.com
  • 3 edits in trunk/WebCore

Fix Qt build.

  • page/Frame.cpp:

(WebCore::Frame::setTypingStyle): Move back to make non-inline.

  • page/Frame.h: Removed inline version of setTypingStyle.
17:15 Changeset [59631] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Attempt to make new-run-webkit-tests --help more sane
https://bugs.webkit.org/show_bug.cgi?id=37836

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • Add a FIXME about options.singly and options.batch_size being different.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • Add support for hidden options.
    • Add option groupings to attempt to simplify --help.
    • Fix a bunch of option helps to start with a capitalized verb.
    • Hide a bunch of options which make no sense to users.
    • Sort options in --help.
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
    • Add tests for option sorting.
16:48 Changeset [59630] by darin@apple.com
  • 4 edits in trunk/WebCore

2010-05-14 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

Frame has many trivial member functions that should be inlined
https://bugs.webkit.org/show_bug.cgi?id=39147

  • WebCore.base.exp: Export the functions that are now inlined.
  • page/Frame.cpp: (WebCore::Frame::removeEditingStyleFromBodyElement): Removed the body of this function.
  • page/Frame.h: (WebCore::Frame::init): Moved here from .cpp. (WebCore::Frame::loader): Ditto. (WebCore::Frame::redirectScheduler): Ditto. (WebCore::Frame::view): Ditto. (WebCore::Frame::script): Ditto. (WebCore::Frame::document): Ditto. (WebCore::Frame::selection): Ditto. (WebCore::Frame::editor): Ditto. (WebCore::Frame::animation): Ditto. (WebCore::Frame::mark): Ditto. (WebCore::Frame::setMark): Ditto. (WebCore::Frame::zoomFactor): Ditto. (WebCore::Frame::jsStatusBarText): Ditto. (WebCore::Frame::jsDefaultStatusBarText): Ditto. (WebCore::Frame::needsReapplyStyles): Ditto. (WebCore::Frame::typingStyle): Ditto. (WebCore::Frame::setTypingStyle): Ditto. (WebCore::Frame::clearTypingStyle): Ditto. (WebCore::Frame::ownerElement): Ditto. (WebCore::Frame::isDisconnected): Ditto. (WebCore::Frame::setIsDisconnected): Ditto. (WebCore::Frame::excludeFromTextSearch): Ditto. (WebCore::Frame::setExcludeFromTextSearch): Ditto. (WebCore::Frame::inViewSourceMode): Ditto. (WebCore::Frame::setInViewSourceMode): Ditto. (WebCore::Frame::markedTextMatchesAreHighlighted): Ditto. (WebCore::Frame::tree): Ditto. (WebCore::Frame::page): Ditto. (WebCore::Frame::detachFromPage): Ditto. (WebCore::Frame::eventHandler): Ditto. (WebCore::Frame::shouldClose): Ditto.
16:03 Changeset [59629] by andersca@apple.com
  • 11 edits in trunk/WebCore

2010-05-17 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=39247
<rdar://problem/7994707>
Move rarely used data members to the rare structures, thus saving memory.

Move rarely used member variables from StyleInheritedData and StyleVisualData to
StyleRareInheritedData and StyleRareNonInheritedData, namely:

indent, cursorData, m_effectiveZoom, widows and orphans move from StyleInheritedData to StyleRareInheritedData.
m_counterIncrement and m_counterReset move from StyleVisualData to StyleRareNonInheritedData.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): (WebCore::RenderStyle::addCursor): (WebCore::RenderStyle::setCursorList): (WebCore::RenderStyle::clearCursorList):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::textIndent): (WebCore::InheritedFlags::effectiveZoom): (WebCore::InheritedFlags::counterIncrement): (WebCore::InheritedFlags::counterReset): (WebCore::InheritedFlags::cursors): (WebCore::InheritedFlags::widows): (WebCore::InheritedFlags::orphans): (WebCore::InheritedFlags::setTextIndent): (WebCore::InheritedFlags::setEffectiveZoom): (WebCore::InheritedFlags::setCounterIncrement): (WebCore::InheritedFlags::setCounterReset): (WebCore::InheritedFlags::setWidows): (WebCore::InheritedFlags::setOrphans):
  • rendering/style/StyleInheritedData.cpp: (WebCore::StyleInheritedData::StyleInheritedData): (WebCore::StyleInheritedData::operator==):
  • rendering/style/StyleInheritedData.h:
  • rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::cursorDataEquivalent): (WebCore::StyleRareInheritedData::operator==):
  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h:
  • rendering/style/StyleVisualData.cpp: (WebCore::StyleVisualData::StyleVisualData):
  • rendering/style/StyleVisualData.h: (WebCore::StyleVisualData::operator==):
15:25 Changeset [59628] by jamesr@google.com
  • 6 edits
    4 adds in trunk/LayoutTests

2010-05-17 James Robinson <jamesr@chromium.org>

Reviewed by Darin Adler.

Rebaseline fast/multicol pixel results on mac
https://bugs.webkit.org/show_bug.cgi?id=39241

  • fast/multicol/client-rects-expected.checksum:
  • fast/multicol/client-rects-expected.png:
  • platform/mac/fast/multicol/float-multicol-expected.png:
  • platform/mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/mac/fast/multicol/nested-columns-expected.png: Added.
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
15:21 Changeset [59627] by atwilson@chromium.org
  • 8 edits
    6 adds in trunk/LayoutTests

Unreviewed. Update Chromium test expectations.

  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/nested-columns-expected.png: Added.
13:46 QtWebKitTableOfFeatures20 edited by noam.rosenthal@nokia.com
(diff)
13:45 Changeset [59626] by robert@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Robert Hogan <robert@webkit.org>

Rubber-stamped by Eric Seidel.

Fix --no-svg build.

I have no idea where the SVG-dependent include of this file is hidden, but
it is probably better to include it explicitly anyway like V8WorkerContextCustom.cpp.

  • bindings/js/JSWorkerContextCustom.cpp:
13:39 Changeset [59625] by atwilson@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewd: Update Chromium test expectations.

  • platform/chromium-win/fast/multicol/nested-columns-expected.txt: Added.
13:29 Changeset [59624] by hyatt@apple.com
  • 3 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=39231

Reviewed by Dan Bernstein.

Fix failures in the RTL portion of fast/multicol/layers-in-multicol.html. Make sure block children of RTL blocks are positioned using
the reduced column width instead of the total content width.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestContents):
(WebCore::RenderBlock::adjustForColumns):

12:36 Changeset [59623] by robert@webkit.org
  • 7 edits
    4 adds in trunk

2010-05-17 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Icon Database by default in Qt DRT

Unskip:

http/tests/misc/favicon-loads-with-images-disabled.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

Qt returns 5 (QNetworkReply::OperationCanceledError) instead of -999 for the XFrameOptions tests,
so update accordingly.

https://bugs.webkit.org/show_bug.cgi?id=37382

  • platform/qt/Skipped:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added. Qt returns 5 instead of -999.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added. Qt returns 5 instead of -999.
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added. Qt returns 5 instead of -999.

2010-05-17 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Disable Icon Database by default in Qt DRT

Unskip:

http/tests/misc/favicon-loads-with-images-disabled.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html

https://bugs.webkit.org/show_bug.cgi?id=37382

Add support for layoutTestController.setIconDatabaseEnabled and layoutTestController.disableImageLoading().
The XFrameOptions tests were failing because of an extra resource load callback for favicon.ico requests.
These extra callbacks are removed by supporting both of the above layoutTestContoller commands.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::drtStoragePath):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::disableImageLoading): (LayoutTestController::setIconDatabaseEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
12:33 Changeset [59622] by mrowe@apple.com
  • 12 edits in branches/safari-533-branch

<rdar://problem/7987585> Disable SVG filters.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

WebKitTools:

  • Scripts/build-webkit:
12:32 Changeset [59621] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch

<rdar://problem/7987743> Disable Blob.slice.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:
12:32 Changeset [59620] by mrowe@apple.com
  • 8 edits in branches/safari-533-branch

<rdar://problem/7987750> Disable progress element.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:
12:09 Changeset [59619] by jpetsovits@rim.com
  • 6 edits
    3 adds in trunk/WebCore

2010-05-17 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by George Staikos.

[OpenVG] Add support for decoding and drawing images
https://bugs.webkit.org/show_bug.cgi?id=36072

OpenVG has a maximum image size (how large is
specific to the OpenVG implementation), so this
requires us to store them as separate image tiles.

Image decoding and initial drawing code by
Adam Treat <atreat@rim.com>. Image decoder
downsampling support by Yong Li <yoli@rim.com>.

  • platform/graphics/ImageSource.h:
  • platform/graphics/openvg/ImageOpenVG.cpp: Added. (WebCore::FrameData::clear): (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::adjustSourceRectForDownSampling): (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern): (WebCore::Image::loadPlatformResource):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::drawImage): (WebCore::PainterOpenVG::asNewNativeImage):
  • platform/graphics/openvg/PainterOpenVG.h:
  • platform/graphics/openvg/TiledImageOpenVG.cpp: Added. (WebCore::TiledImageOpenVG::TiledImageOpenVG): (WebCore::TiledImageOpenVG::operator=): (WebCore::TiledImageOpenVG::~TiledImageOpenVG): (WebCore::TiledImageOpenVG::numTiles): (WebCore::TiledImageOpenVG::numColumns): (WebCore::TiledImageOpenVG::numRows): (WebCore::TiledImageOpenVG::setTile): (WebCore::TiledImageOpenVG::tilesInRect): (WebCore::TiledImageOpenVG::tile): (WebCore::TiledImageOpenVG::tileRect): (WebCore::TiledImageOpenVG::detachTiles): (WebCore::TiledImageOpenVG::destroyTiles):
  • platform/graphics/openvg/TiledImageOpenVG.h: Added. (WebCore::TiledImageOpenVG::size): (WebCore::TiledImageOpenVG::maxTileSize):
  • platform/graphics/openvg/VGUtils.cpp: (WebCore::VGUtils::bytesForImage): (WebCore::VGUtils::bytesForImageScanline): (WebCore::VGUtils::imageFormatBitsPerPixel): (WebCore::VGUtils::endianAwareImageFormat):
  • platform/graphics/openvg/VGUtils.h:
  • platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Added. (WebCore::RGBA32Buffer::asNewNativeImage):
11:42 Changeset [59618] by yaar@chromium.org
  • 3 edits in trunk/WebCore

2010-05-17 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Adler.

Fix JSC's generation of 'Optional' arguments. When a single 'Optional' extended attribute precedes multiple method arguments, all of these arguments are optional as a group (either all or non must be specified). This fix, which makes JSC compliant with V8 and with the Web IDL specs, is pretty harmless, since Optional is currently not being used anywhere in JSC, but it blocks further work on overloads.
https://bugs.webkit.org/show_bug.cgi?id=39227

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
11:05 Changeset [59617] by weinig@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39192
Remove unused PERFECT_HASH code CodeGeneratorJS.

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorJS.pm:
10:57 Changeset [59616] by hyatt@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test of columns inside columns. The test also puts a RenderLayer in the 2nd column of the 2nd column
to make sure layer positioning works across nested columns.

Reviewed by Dan Bernstein.

  • fast/multicol/nested-columns.html: Added.
  • platform/mac/fast/multicol/nested-columns-expected.txt: Added.
10:54 Changeset [59615] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Jeremy Orlow.

Remove debug code that was introduced to help narrow down the
source of a crash.
https://bugs.webkit.org/show_bug.cgi?id=36426

No change in behavior, so no new tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):
10:43 Changeset [59614] by eric@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-05-17 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix compilation with QT_NO_COMBOBOX
https://bugs.webkit.org/show_bug.cgi?id=38324

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup):
  • WebCoreSupport/QtFallbackWebPopup.cpp:
  • WebCoreSupport/QtFallbackWebPopup.h:
10:32 Changeset [59613] by eric@webkit.org
  • 6 edits
    3 adds in trunk

2010-05-17 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify proper behavior of createImageData(ImageData)
and createImageData(width, height) with negative arguments.
https://bugs.webkit.org/show_bug.cgi?id=39189

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata

  • fast/canvas/canvas-createImageData-expected.txt: Added.
  • fast/canvas/canvas-createImageData.html: Added.
  • fast/canvas/script-tests/canvas-createImageData.js: Added.

2010-05-17 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Bring CanvasRenderingContext2D's createImageData() in line with HTML5 spec
Added createImageData(ImageData) which returns a new ImageData with the same size as the one passed.
Changed createImageData(width, height) to use the absolute values of width and height.

https://bugs.webkit.org/show_bug.cgi?id=39189

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createimagedata

Test: fast/canvas/canvas-createImageData.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::createImageData):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:
08:37 Changeset [59612] by antti.j.koivisto@nokia.com
  • 2 edits in trunk/WebCore

This was missing from previous commit.

  • platform/qt/QWebPageClient.h:

(QWebPageClient::graphicsItemVisibleRect):

08:34 Changeset [59611] by antti.j.koivisto@nokia.com
  • 11 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=39218
[Qt] Tiled backing store tiles sometimes flicker when exiting a zoom animation

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Tiles sometimes flicker when exiting a zoom animation. This happens as a result
of the visible rectangle being momentarily out of sync.

Instead of updating the visible rect by explicitly setting it, pull it through
the client and recompute in the WebKit level.

  • page/ChromeClient.h:

(WebCore::ChromeClient::visibleRectForTiledBackingStore):

  • page/Frame.cpp:

(WebCore::Frame::tiledBackingStoreVisibleRect):

  • page/Frame.h:
  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::checkVisibleRectChanged):
(WebCore::TiledBackingStore::createTiles):

  • platform/graphics/TiledBackingStore.h:
  • platform/graphics/TiledBackingStoreClient.h:

WebKit/qt:

Tiles sometimes flicker when exiting a zoom animation. This happens as a result
of the visible rectangle being momentarily out of sync.

Instead of updating the visible rect by explicitly setting it, pull it through
the client and recompute in WebKit the level.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebView::paint):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::visibleRectForTiledBackingStore):

  • WebCoreSupport/ChromeClientQt.h:
08:04 Changeset [59610] by aroben@apple.com
  • 3 edits
    1 add in trunk/WebCore

Periodically try to reset a lost IDirect3DDevice9 until we succeed

This is how MSDN says we must respond to a lost device (see
<http://msdn.microsoft.com/en-us/library/bb174714(v=VS.85).aspx>).

Only testable by a manual test, unfortunately.

Fixes <rdar://problem/7986906> <http://webkit.org/b/39139> Pages that
use hardware acceleration don't repaint after waking computer from
sleep

Reviewed by John Sullivan.

  • manual-tests/no-repaint-after-wake-from-sleep.html: Added. This is

the Poster Circle demo from webkit.org/blog, but with instructions for
putting the computer to sleep and waking it up again.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Initialize new
member that tells us whether we need to try to reset the device before
rendering.
(WebCore::WKCACFLayerRenderer::resize): Changed to tell resetDevice
the reason why the device needs to be reset (which is because the
window's size has changed).
(WebCore::WKCACFLayerRenderer::render): Before we do anything else,
check if we need to reset the device before rendering. If we do, try
to reset it. If that fails, bail out and set a timer to try again
later. If we discover that the device is lost when calling
IDirect3DDevice9::Present and resetting the device fails, bail out and
set a timer to try again later.
(WebCore::WKCACFLayerRenderer::resetDevice): Changed to return a
boolean indicating whether resetting succeeded or not. Added a
ResetReason parameter so callers can specify whey the device needs to
be reset. Before trying to do anything, we call
IDirect3DDevice9::TestCooperativeLevel to find out whether the device
can be reset currently. If it can't, we set a flag to tell ourselves
that the device must be reset before we next render, and indicate to
the caller that the reset failed. If we thought the device was lost
but it turns out not to be, we don't have to do anything and can tell
the caller that the reset succeeded. Otherwise we go ahead and reset
the device as before, and indicate to the caller that the reset
succeeded.

  • platform/graphics/win/WKCACFLayerRenderer.h: Changed resetDevice to

return a boolean and take a ResetReason parameter. Added a comment
about when and why this function should be called. And added
m_mustResetLostDeviceBeforeRendering.

08:04 Changeset [59609] by aroben@apple.com
  • 2 edits in trunk/WebCore

Call CARenderOGLPurge whenever we call IDirect3DDevice9::Reset

MSDN says that all resoures allocated with D3DPOOL_DEFAULT must be
destroyed before calling IDirect3DDevice9::Reset. The only way to
guarantee this with Core Animation is to call CARenderOGLPurge.

Unfortunately this isn't testable at the moment, as we don't use any
features of Core Animation (e.g., mask layers) that actually make this
required. But it seems like a good idea to fix the code now so that
if/when we do start using those features we won't run into problems.

Fixes <http://webkit.org/b/39159> WKCACFLayerRenderer::resetDevice
might fail due to failing to destroy all D3DPOOL_DEFAULT resources

Reviewed by John Sullivan.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::render): Moved the call to
CARenderOGLPurge from here...
(WebCore::WKCACFLayerRenderer::resetDevice): ...to here, so that it
will be called whenever we reset the device (e.g., when resizing the
window).

07:42 Changeset [59608] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Build fix. Remove bashism from build system.

  • GNUmakefile.am:
07:25 Changeset [59607] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59483.
http://trac.webkit.org/changeset/59483
https://bugs.webkit.org/show_bug.cgi?id=39215

"page_cycler_intl1 regression on Linux" (Requested by yurys on
#webkit).

  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
06:49 Changeset [59606] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

REGRESSION(59563): [Qt] JSValue QtClass::fallbackObject can be optimized

Reviewed by Laszlo Gombos.

Patch declared a variable index, which shadowed an earlier declared
variable.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

06:33 Changeset [59605] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-05-14 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBRequest is not a proper ActiveDomObject
https://bugs.webkit.org/show_bug.cgi?id=39001

Add IDBRequest interface to the IsActiveDomType
routine of the CodeGeneratorV8.pm.

Rename IDBRequest::m_stopped to m_suspended and reset
the flag when resume() is called.

No new tests, Indexed Database isn't yet testable.

  • bindings/scripts/CodeGeneratorV8.pm:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h:
06:22 Changeset [59604] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Xan Lopez <xlopez@igalia.com>

Do not include the indexed database headers if the feature is not
enabled. Should fix the build in GTK+.

  • bindings/js/JSEventCustom.cpp:
05:55 Changeset [59603] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-17 Xan Lopez <xlopez@igalia.com>

Try to fix GTK+ build.

  • GNUmakefile.am:
04:20 Changeset [59602] by jorlow@chromium.org
  • 30 edits
    12 copies
    2 moves
    6 adds in trunk

2010-05-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up IndexedDB events
https://bugs.webkit.org/show_bug.cgi?id=39117

Add the beginnings of a test for IndexedDB. It currently fails, but we'll
update this (and/or add other tests) as things start passing.

Disable it on all !Chromium platforms since none of them compile it
in. (Note that Chromium keeps it behind a runtime flag at the moment,
despite compiling it in...so don't worry.)

This also makes evalAndLog return the result of the evaluation. I think
this was just an oversight when I originally added it, and it's going to
come in useful for these tests.

  • fast/js/resources/js-test-pre.js: (evalAndLog):
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/indexeddb/basics-expected.txt: Added.
  • storage/indexeddb/basics.html: Added.
  • storage/indexeddb/script-tests/TEMPLATE.html: Copied from LayoutTests/storage/domstorage/script-tests/TEMPLATE.html.
  • storage/indexeddb/script-tests/basics.js: Added. (eventShared): (successFunction): (errorFunction): (test):

2010-05-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Finish up IndexedDB events
https://bugs.webkit.org/show_bug.cgi?id=39117

Implement the indexed database event interfaces as proposed by Mozilla.
Refactor the run time type detection code that was in IDBRequest into its own
class named IDBAny. Use this new class within the new event classes and
IDBResults.

Test: storage/indexeddb/basics.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/js/JSIDBAnyCustom.cpp: Added. (WebCore::toJS):
  • bindings/js/JSIDBRequestCustom.cpp: Removed.
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • bindings/v8/custom/V8IDBAnyCustom.cpp: Added. (WebCore::toV8):
  • bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
  • dom/Event.cpp: (WebCore::Event::isIDBErrorEvent): (WebCore::Event::isIDBSuccessEvent):
  • dom/Event.h:
  • storage/IDBAny.cpp: Added. (WebCore::IDBAny::create): (WebCore::IDBAny::IDBAny): (WebCore::IDBAny::~IDBAny): (WebCore::IDBAny::idbDatabaseRequest): (WebCore::IDBAny::indexedDatabaseRequest): (WebCore::IDBAny::serializedScriptValue): (WebCore::IDBAny::set):
  • storage/IDBAny.h: Added. (WebCore::IDBAny::): (WebCore::IDBAny::type):
  • storage/IDBAny.idl: Added.
  • storage/IDBErrorEvent.cpp: Added. (WebCore::IDBErrorEvent::create): (WebCore::IDBErrorEvent::IDBErrorEvent): (WebCore::IDBErrorEvent::~IDBErrorEvent):
  • storage/IDBErrorEvent.h: Added. (WebCore::IDBErrorEvent::code): (WebCore::IDBErrorEvent::message): (WebCore::IDBErrorEvent::isIDBErrorEvent):
  • storage/IDBErrorEvent.idl: Added.
  • storage/IDBEvent.cpp: Added. (WebCore::IDBEvent::IDBEvent): (WebCore::IDBEvent::~IDBEvent): (WebCore::IDBEvent::source):
  • storage/IDBEvent.h: Added.
  • storage/IDBEvent.idl: Added.
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h: (WebCore::IDBRequest::create): (WebCore::IDBRequest::result):
  • storage/IDBRequest.idl:
  • storage/IDBSuccessEvent.cpp: Added. (WebCore::IDBSuccessEvent::create): (WebCore::IDBSuccessEvent::IDBSuccessEvent): (WebCore::IDBSuccessEvent::~IDBSuccessEvent): (WebCore::IDBSuccessEvent::result):
  • storage/IDBSuccessEvent.h: Added. (WebCore::IDBSuccessEvent::isIDBSuccessEvent):
  • storage/IDBSuccessEvent.idl: Added.
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::IndexedDatabaseRequest): (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:
01:44 Changeset [59601] by yurys@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2010-05-17 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-win-xp/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
01:11 Changeset [59600] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-17 Patrick Gansterer <paroga@paroga.com>

Reviewed by Laszlo Gombos.

[Qt] Remove WinCE endian dedection.
https://bugs.webkit.org/show_bug.cgi?id=38511

Windows CE supports little-endian format only.
Correct dedection was added in r57804.

  • wtf/Platform.h:
01:10 Changeset [59599] by mjs@apple.com
  • 2 edits in trunk/SunSpider

Browser-hosted version of SunSpider runs tests twice as many times as advertised
https://bugs.webkit.org/show_bug.cgi?id=39201

Reviewed by Mark Rowe.

  • make-hosted: Make sure to reset test list after every test suite.
01:03 Changeset [59598] by cjerdonek@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Unreviewed.

Removed the stray equals sign from the reviewer's name in the
"Reviewed by" line of the ChangeLog entry for r59596:

http://trac.webkit.org/changeset/59596

00:42 Changeset [59597] by yurys@chromium.org
  • 8 edits
    15 adds
    1 delete in trunk/LayoutTests

2010-05-17 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt:
  • platform/chromium-linux/fast/multicol/client-rects-expected.txt: Removed.
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-win/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.txt: Added.
  • platform/chromium-win/fast/multicol/column-rules-expected.txt:
  • platform/chromium-win/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt: Added.
  • platform/chromium-win/fast/multicol/single-line-expected.txt:
00:34 Changeset [59596] by cjerdonek@webkit.org
  • 7 edits in trunk/WebCore

2010-05-16 Chris Jerdonek <cjerdonek@webkit.org>

Reviewed by =Adam Barth.

Refactored FrameLoader::changeLocation() and urlSelected() to share more code.

https://bugs.webkit.org/show_bug.cgi?id=38827

No change in behavior, so no new tests.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • bindings/js/ScriptController.h:
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • bindings/v8/ScriptController.h:
    • Changed a parameter from boolean to the ShouldReplaceDocumentIfJavaScriptURL enum.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation):
    • Changed to call the new private overload of urlSelected().

(WebCore::FrameLoader::urlSelected):

  • Added a private overload of urlSelected().
  • Changed the public urlSelected() to call the private overload.

(WebCore::FrameLoader::submitForm):

  • loader/FrameLoader.h:
    • Added a private overload of urlSelected().
  • loader/FrameLoaderTypes.h:
    • Added a ShouldReplaceDocumentIfJavaScriptURL enum.
00:06 Changeset [59595] by ukai@chromium.org
  • 7 edits
    1 add in trunk/WebKitTools

2010-05-17 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Chromium: Add --chromium option to new-run-webkit-websocketserver
https://bugs.webkit.org/show_bug.cgi?id=37664

os.environ setup and setup_mount for cygwin are moved in ChromiumWinPort.setup_environ_for_server.

  • Scripts/new-run-webkit-httpd: Remove passing register_cygwin.
  • Scripts/new-run-webkit-websocketserver: Add --chromium flag. Remove passing register_cygwin. Create port object using options.
  • Scripts/webkitpy/layout_tests/port/base.py: Add setup_environ_for_server().
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/http_server.py: Remove register_cygwin_parameter. Call setup_environ_for_server().
  • Scripts/webkitpy/layout_tests/port/websocket_server.py: Ditto.

05/16/10:

23:10 Changeset [59594] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed

Patch by Takeshi Yoshino <tyoshino@google.com> on 2010-05-16
Update test_expectations.txt for Chromium
fast/loader/recursive-before-unload-crash.html is flaky on Linux and Win
See http://code.google.com/p/chromium/issues/detail?id=44229 for detail.

  • platform/chromium/test_expectations.txt:
23:10 Changeset [59593] by dbates@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-05-16 Daniel Bates <dbates@rim.com>

Reviewed by Chris Jerdonek.

https://bugs.webkit.org/show_bug.cgi?id=39184

Adds function VCSUtils::parseSvnProperty to parse an SVN property with
either a single-line or multi-line value change.

  • Scripts/VCSUtils.pm:
    • Added function parseSvnProperty. We will use this function towards resolving Bug #38885 <https://bugs.webkit.org/show_bug.cgi?id=38885>.
    • Removed FIXME comment above function parseSvnPropertyValue, since it is being used by parseSvnProperty.
    • Modified function parseSvnPropertyValue to break out of "while (<$fileHandle>)" loop when it encounters the start of the next property so that it can be processed by its caller, parseSvnPropertyValue. We reference this bullet below by (*).
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Added.
    • Added unit tests.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
    • Changed the name of the unit test "simple multi-line '-' change" to "single-line '-' change followed by empty line" since the former was an incorrect description of this test.
    • Added unit test "single-line '-' change followed by the next property", and "multi-line '-' change followed by the next property" to test (*) above.
21:58 Changeset [59592] by dbates@webkit.org
  • 23 edits
    1 add in trunk/WebCore

2010-05-16 Daniel Bates <dbates@rim.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=39196

Rollout changeset 59274 <http://trac.webkit.org/changeset/59274>.

Prepared on behalf of David Hyatt.

"Not worth the memory use." Just roll this out.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection): (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox): (WebCore::EllipsisBox::height):
  • rendering/InlineBox.cpp: (WebCore::InlineBox::height): (WebCore::InlineBox::adjustPosition): (WebCore::InlineBox::canAccommodateEllipsis):
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::isInlineBox): (WebCore::InlineBox::hasVirtualHeight): (WebCore::InlineBox::setHasVirtualHeight): (WebCore::InlineBox::virtualHeight): (WebCore::InlineBox::setWidth): (WebCore::InlineBox::width): (WebCore::InlineBox::setX): (WebCore::InlineBox::x): (WebCore::InlineBox::setY): (WebCore::InlineBox::y): (WebCore::InlineBox::baselinePosition): (WebCore::InlineBox::lineHeight):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::computeVerticalOverflow): (WebCore::InlineFlowBox::nodeAtPoint): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask): (WebCore::InlineFlowBox::paintTextDecorations):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::visibleOverflowRect): (WebCore::InlineFlowBox::topLayoutOverflow): (WebCore::InlineFlowBox::bottomLayoutOverflow): (WebCore::InlineFlowBox::leftLayoutOverflow): (WebCore::InlineFlowBox::rightLayoutOverflow): (WebCore::InlineFlowBox::layoutOverflowRect): (WebCore::InlineFlowBox::topVisualOverflow): (WebCore::InlineFlowBox::bottomVisualOverflow): (WebCore::InlineFlowBox::leftVisualOverflow): (WebCore::InlineFlowBox::rightVisualOverflow): (WebCore::InlineFlowBox::visualOverflowRect): (WebCore::InlineFlowBox::setHorizontalOverflowPositions): (WebCore::InlineFlowBox::setVerticalOverflowPositions):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::nodeAtPoint): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintCompositionUnderline): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::setSpaceAdd):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPointWithInlineChildren):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren):
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineFlowBox):
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::createTextBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootInlineBox):
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint): (WebCore::RenderText::firstRunX): (WebCore::RenderText::firstRunY):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::closestLeafChildForXPos):
  • rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::SVGInlineFlowBox): (WebCore::SVGInlineFlowBox::virtualHeight): (WebCore::SVGInlineFlowBox::setHeight):
  • rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::virtualHeight): (WebCore::SVGInlineTextBox::setHeight): (WebCore::SVGInlineTextBox::selectionTop): (WebCore::SVGInlineTextBox::selectionHeight):
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::SVGRootInlineBox): (WebCore::SVGRootInlineBox::virtualHeight): (WebCore::SVGRootInlineBox::setHeight):
  • rendering/TrailingFloatsRootInlineBox.h: Added. (WebCore::TrailingFloatsRootInlineBox::TrailingFloatsRootInlineBox): (WebCore::TrailingFloatsRootInlineBox::virtualHeight):
21:08 Changeset [59591] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-13 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

REGRESSION: Crash by pasting to a textarea with white-space:nowrap
https://bugs.webkit.org/show_bug.cgi?id=38992

  • editing/pasteboard/paste-plaintext-nowrap-expected.txt: Added.
  • editing/pasteboard/paste-plaintext-nowrap.html: Added.

2010-05-13 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

REGRESSION: Crash by pasting to a textarea with white-space:nowrap
https://bugs.webkit.org/show_bug.cgi?id=38992

Test: editing/pasteboard/paste-plaintext-nowrap.html

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::highestVisuallyEquivalentDivBelowRoot): (WebCore::InsertParagraphSeparatorCommand::doApply):
20:34 Changeset [59590] by hyatt@apple.com
  • 2 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=39194

Reviewed by Dan Bernstein.

Fix all of the multi-column painting and hit testing functions to properly account for RTL directionality.

Added fast/multicol/column-count-with-rules.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::adjustRectForColumns):

20:03 Changeset [59589] by mitz@apple.com
  • 5 edits in trunk/WebCore

Fix SVG test failures after r59588.

Reviewed by Dave Hyatt.

Updated SVG InlineBox virtual method overrides to match HTML ones. Removed
SVGInlineFlowBox::verticallyAlignBoxes() since InlineFlowBox no longer declares
verticallyAlignBoxes().

  • rendering/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::placeBoxesHorizontally):

  • rendering/SVGInlineFlowBox.h:
  • rendering/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::placeBoxesHorizontally):
(WebCore::SVGRootInlineBox::verticallyAlignBoxes):

  • rendering/SVGRootInlineBox.h:
18:43 Changeset [59588] by mitz@apple.com
  • 10 edits in trunk/WebCore

Move transient glyph overflow and fallback font data from a global to the stack
https://bugs.webkit.org/show_bug.cgi?id=39050

Reviewed by Darin Adler.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesHorizontally): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read glyph overflow from the map.
(WebCore::InlineFlowBox::computeLogicalBoxHeights): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read fallback fonts from the map.
(WebCore::InlineFlowBox::computeVerticalOverflow): Added a GlyphOverflowAndFallbackFontsMap
parameter. Read glyph overflow from the map.

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: Removed setFallbackFonts(), fallbackFonts(), setGlyphOverflow(),

and glyphOverflow(). Removed s_glyphOverflowAndFallbackFontsMap.

  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a GlyphOverflowAndFallbackFontsMap
parameter. Write fallback fonts and glyph overflow into the map.
(WebCore::RenderBlock::computeVerticalPositionsForLine): Added a GlyphOverflowAndFallbackFontsMap
parameter. Pass it down to verticallyAlignBoxes().
(WebCore::RenderBlock::layoutInlineChildren): Create a GlyphOverflowAndFallbackFontsMap on the
stack and pass it down to computeHorizontalPositionsForLine(), computeVerticalPositionsForLine(),
and verticallyAlignBoxes().

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticallyAlignBoxes): Added a GlyphOverflowAndFallbackFontsMap parameter.
Pass it down to computeLogicalBoxHeights() and computeVerticalOverflow().

  • rendering/RootInlineBox.h:
  • rendering/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutInlineBoxes): Updated.

18:02 Changeset [59587] by simon.fraser@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-05-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Reduce the size of FunctionExecutable
https://bugs.webkit.org/show_bug.cgi?id=39180

Change m_numVariables from a size_t to 31 bits in a bitfield,
packed with another bit for m_forceUsesArguments (which in turn
get packed with the base class).

Reduces the size of FunctionExecutable from 160 to 152 bytes.

  • runtime/Executable.h: (JSC::FunctionExecutable::variableCount): (JSC::FunctionExecutable::FunctionExecutable):
18:00 Changeset [59586] by tony@chromium.org
  • 4 edits
    2 copies
    3 adds in trunk

2010-05-16 Tony Chang <tony@chromium.org>

Not reviewed, fixing layout test.

Add tiger and SL results. Remove Inspect Element from leopard results.

  • platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt:
  • platform/mac-snowleopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
  • platform/mac-tiger/editing/spelling/context-menu-suggestions-expected.txt: Added.

2010-05-16 Tony Chang <tony@chromium.org>

Not reviewed, fixing layout test.

Don't output Inspect Element since this is not enabled on the bots,
but most developers probably have it installed.

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController contextClick:]):
17:26 Changeset [59585] by tony@chromium.org
  • 9 edits
    3 adds in trunk

2010-05-12 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
https://bugs.webkit.org/show_bug.cgi?id=25639

  • editing/spelling/context-menu-suggestions.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-05-12 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
https://bugs.webkit.org/show_bug.cgi?id=25639

Test: editing/spelling/context-menu-suggestions.html

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

2010-05-12 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
https://bugs.webkit.org/show_bug.cgi?id=25639

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController contextClick:]): add a bool parameter that

when true, dumps the context menu items to stdout.

16:48 Changeset [59584] by crogers@google.com
  • 6 edits in branches/audio/WebCore/audio

compile fixes for Snow Leopard

16:42 Changeset [59583] by weinig@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39190
Shave a word off of GlyphPageTreeNode
<rdar://problem/7990428>

Reviewed by Dan Bernstein.

  • platform/graphics/GlyphPageTreeNode.h:

(WebCore::GlyphPageTreeNode::GlyphPageTreeNode):

14:46 Changeset [59582] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-05-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify proper handling of invalid arguments to getImageData().
Updated old putImageData() test with correct expectations.

https://bugs.webkit.org/show_bug.cgi?id=39175

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation

  • fast/canvas/canvas-getImageData-invalid-expected.txt: Added.
  • fast/canvas/canvas-getImageData-invalid.html: Added.
  • fast/canvas/canvas-putImageData-expected.txt:
  • fast/canvas/canvas-putImageData.js:
  • fast/canvas/script-tests/canvas-getImageData-invalid.js: Added.

2010-05-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Properly handle invalid arguments to CanvasRenderingContext2D's getImageData() and putImageData().
Both should throw NOT_SUPPORTED_ERR when called with nonfinite arguments.
getImageData() should throw INDEX_SIZE_ERR if either width or height is 0.

https://bugs.webkit.org/show_bug.cgi?id=39175

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation

Test: fast/canvas/canvas-getImageData-invalid.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData): (WebCore::CanvasRenderingContext2D::getImageData): (WebCore::CanvasRenderingContext2D::putImageData):
14:08 Changeset [59581] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2010-05-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify that Canvas's toDataURL() is case insensitive wrt the mimeType argument.
https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Added.
  • fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Added. (tryMimeType):
  • platform/gtk/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.

2010-05-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html

  • dom/CanvasSurface.cpp: (WebCore::CanvasSurface::toDataURL):
13:13 Changeset [59580] by robert@webkit.org
  • 14 edits in trunk

[Qt] Fix FrameLoaderClientQt.cpp to print relative filename paths correctly.

2010-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Fix FrameLoaderClientQt.cpp to print relative filename paths correctly.

Move qt_* functions in FrameLoaderClientQt, EditorClientQt, and NotificationPresenterClientQt
to DumpRenderTreeSupportQt. Create new functions to replace them in DumpRenderTreeSupportQt.
Support for the old function names is retained until confirmed that no one uses them outside
QtWebKit.

https://bugs.webkit.org/show_bug.cgi?id=38867

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::dumpFrameLoader): (DumpRenderTreeSupportQt::dumpResourceLoadCallbacks): (DumpRenderTreeSupportQt::dumpResourceLoadCallbacksPath): (DumpRenderTreeSupportQt::setWillSendRequestReturnsNullOnRedirect): (DumpRenderTreeSupportQt::setWillSendRequestReturnsNull): (DumpRenderTreeSupportQt::setWillSendRequestClearHeaders): (DumpRenderTreeSupportQt::dumpEditingCallbacks): (DumpRenderTreeSupportQt::dumpSetAcceptsEditing): (DumpRenderTreeSupportQt::dumpNotification): (qt_dump_frame_loader): (qt_dump_resource_load_callbacks): (qt_dump_resource_load_callbacks_path): (qt_set_will_send_request_returns_null_on_redirect): (qt_set_will_send_request_returns_null): (qt_set_will_send_request_clear_headers): (qt_dump_editing_callbacks): (qt_dump_set_accepts_editing): (qt_dump_notification):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/EditorClientQt.cpp:
  • WebCoreSupport/EditorClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (drtDescriptionSuitableForTestResult):
  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp:
  • WebCoreSupport/NotificationPresenterClientQt.h:

Update Qt DRT to use frame loader, editor client and notificaiton presenter
functions in DumpRenderTreeSupportQt.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::reset): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::dumpFrameLoadCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::setWillSendRequestReturnsNullOnRedirect): (LayoutTestController::setWillSendRequestReturnsNull): (LayoutTestController::setWillSendRequestClearHeader):

Unskip fast/loader/main-document-url-for-non-http-loads.html

  • platform/qt/Skipped:
11:01 Changeset [59579] by eric@webkit.org
  • 4 edits in trunk

2010-05-16 Mike Belshe <mbelshe@chromium.org>

Reviewed by Dimitri Glazkov.

Add a flag to the ResourceResponse for tracking if a request was
fetched via the TLS/Next-Protocol-Negotiation mechanism.

Also cleaned up the style in ResourceResponse to group the flags
together (and alphabetically) and hopefully improve readability of
the file.

https://bugs.webkit.org/show_bug.cgi?id=39078

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasNpnNegotiated): (WebKit::WebURLResponse::setWasNpnNegotiated):
10:50 Changeset [59578] by eric@webkit.org
  • 6 edits in trunk

2010-05-16 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r59571.
http://trac.webkit.org/changeset/59571
https://bugs.webkit.org/show_bug.cgi?id=39054

Broke Cr Win, but we didn't notice immediately due to
https://bugs.webkit.org/show_bug.cgi?id=38926. It's possible
that this didn't actually break Cr Win, but rather that bug
38926 necessitates a clean compile after this and sucessive
checkins only produced a partial recompile and thus failed to
build.

  • DEPS:
  • WebKit.gyp:
  • features.gypi:

2010-05-16 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r59571.
http://trac.webkit.org/changeset/59571
https://bugs.webkit.org/show_bug.cgi?id=39054

Broke Cr Win, but we didn't notice immediately due to
https://bugs.webkit.org/show_bug.cgi?id=38926. It's possible
that this didn't actually break Cr Win, but rather that bug
38926 necessitates a clean compile after this and sucessive
checkins only produced a partial recompile and thus failed to
build.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::canvas):
10:24 Changeset [59577] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-05-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Shrink SimpleFontData
https://bugs.webkit.org/show_bug.cgi?id=39179

Change SimpleFontData to have a pointer to the m_glyphToBoundsMap,
and to allocate this lazily. This reduces the size of the class from
5632 to 1536 bytes.

  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::boundsForGlyph):
08:43 Changeset [59576] by simon.fraser@apple.com
  • 9 edits in trunk/WebCore

2010-05-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Maciej Stachowiak.

Reduce the size of CachedResource
https://bugs.webkit.org/show_bug.cgi?id=39171

Make protected data members of CachedResource private, to allow for
easier rearrangement, and hide the fact that enums are in bitfields.

Rearrange the data members of CachedResource to save 32 bytes per instance
in 64-bit. Also modernized the constructor code.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::didAddClient): (WebCore::CachedCSSStyleSheet::data): (WebCore::CachedCSSStyleSheet::checkNotify): (WebCore::CachedCSSStyleSheet::error):
  • loader/CachedFont.cpp: (WebCore::CachedFont::load): (WebCore::CachedFont::didAddClient): (WebCore::CachedFont::data): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::ensureSVGFontData): (WebCore::CachedFont::checkNotify): (WebCore::CachedFont::error):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::load): (WebCore::CachedImage::didAddClient): (WebCore::CachedImage::allClientsRemoved): (WebCore::CachedImage::image): (WebCore::CachedImage::data): (WebCore::CachedImage::error): (WebCore::CachedImage::checkNotify): (WebCore::CachedImage::destroyDecodedData):
  • loader/CachedImage.h: (WebCore::CachedImage::stillNeedsLoad):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::type): (WebCore::CachedResource::preloadResult): (WebCore::CachedResource::status): (WebCore::CachedResource::setStatus): (WebCore::CachedResource::isLoaded): (WebCore::CachedResource::isLoading): (WebCore::CachedResource::setErrorOccurred):
  • loader/CachedScript.cpp: (WebCore::CachedScript::didAddClient): (WebCore::CachedScript::data): (WebCore::CachedScript::checkNotify): (WebCore::CachedScript::error):
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::didAddClient): (WebCore::CachedXSLStyleSheet::data): (WebCore::CachedXSLStyleSheet::checkNotify): (WebCore::CachedXSLStyleSheet::error):
06:44 Changeset [59575] by eric@webkit.org
  • 5 edits in trunk

2010-05-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59574.
http://trac.webkit.org/changeset/59574
https://bugs.webkit.org/show_bug.cgi?id=39176

Supposedly broke cr-win, but the errors seems somewhat
unrelated (Requested by abarth on #webkit).

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::setSecurityInfo): (WebCore::ResourceResponse::isContentFiltered): (WebCore::ResourceResponse::setIsContentFiltered): (WebCore::ResourceResponse::setAppCacheID): (WebCore::ResourceResponse::setAppCacheManifestURL): (WebCore::ResourceResponse::setWasFetchedViaSPDY): (WebCore::ResourceResponse::setIsMultipartPayload): (WebCore::ResourceResponse::setResponseTime):

2010-05-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59574.
http://trac.webkit.org/changeset/59574
https://bugs.webkit.org/show_bug.cgi?id=39176

Supposedly broke cr-win, but the errors seems somewhat
unrelated (Requested by abarth on #webkit).

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp:
01:58 Changeset [59574] by eric@webkit.org
  • 4 edits in trunk

2010-05-16 Mike Belshe <mbelshe@chromium.org>

Reviewed by Dimitri Glazkov.

Add a flag to the ResourceResponse for tracking if a request was
fetched via the TLS/Next-Protocol-Negotiation mechanism.

Also cleaned up the style in ResourceResponse to group the flags
together (and alphabetically) and hopefully improve readability of
the file.

https://bugs.webkit.org/show_bug.cgi?id=39078

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasNpnNegotiated): (WebKit::WebURLResponse::setWasNpnNegotiated):
01:55 Changeset [59573] by robert@webkit.org
  • 8 edits in trunk

[Qt]Unskip security/set-form-autocomplete-attribute.html

2010-05-16 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt]Unskip security/set-form-autocomplete-attribute.html

Add support for layoutTestController.elementDoesAutoCompleteForElementWithId().

https://bugs.webkit.org/show_bug.cgi?id=38859

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • platform/qt/Skipped:
01:49 Changeset [59572] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Prospective Qt/Mac build fix.

The friend declaration of QGraphicsWidget confuses gcc and thinks that it's an implicit
forward declaration, moving the class into the WebCore namespace (WebCore::QGraphicsWidget).

The declaration seems useless as no method of QGraphicsWidget is going to call anything
in this class.

  • WebCoreSupport/PageClientQt.h:
01:47 Changeset [59571] by eric@webkit.org
  • 6 edits in trunk

2010-05-16 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix repaint, WebGL, textarea tests
https://bugs.webkit.org/show_bug.cgi?id=39054

  • DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion and textAreaResizeCorner.png
  • WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
  • features.gypi: Enable ENABLE_3D_CANVAS.

2010-05-16 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix repaint, WebGL, textarea tests
https://bugs.webkit.org/show_bug.cgi?id=39054

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::canvas): Remove m_paintRect initialization in canvas(). This line updated m_paintRect unexpectedly during paintRect(). We don't need to initialize m_paintRect because show() does it.
01:10 Changeset [59570] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-16 Dan Bernstein <mitz@apple.com>

Reviewed by Darin Adler.

Scalar types allocated on the heap due to misuse of DEFINE_STATIC_LOCAL
https://bugs.webkit.org/show_bug.cgi?id=39086

Use global variables directly.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::createUtilityContext):
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::shouldUseATSUIAPI):
00:58 Changeset [59569] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2010-05-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to check proper return value (null) from invalid canvas getContext() calls.

https://bugs.webkit.org/show_bug.cgi?id=39150

  • fast/canvas/canvas-getContext-invalid-expected.txt: Added.
  • fast/canvas/canvas-getContext-invalid.html: Added.
  • fast/canvas/script-tests/canvas-getContext-invalid.js: Added.

2010-05-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas's getContext() must return null when called with an invalid/unsupported parameter.
(HTML5 spec 4.8.11): http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvas-getcontext

https://bugs.webkit.org/show_bug.cgi?id=39150

Test: fast/canvas/canvas-getContext-invalid.html

  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
00:44 Changeset [59568] by eric@webkit.org
  • 4 edits in trunk

2010-05-16 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

Removed 5 http/history tests from Skipped file

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • platform/gtk/Skipped:

2010-05-16 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Improve reporting of frame loader callbacks in DRT
https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadStatusNotified): (createWebView): added connection to notify::load-status and signal callback

05/15/10:

23:57 Changeset [59567] by eric@webkit.org
  • 3 edits
    3 deletes in trunk

2010-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59565.
http://trac.webkit.org/changeset/59565
https://bugs.webkit.org/show_bug.cgi?id=39173

Broke GTK (Requested by abarth on #webkit).

  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Removed.
  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Removed.
  • fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Removed.

2010-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59565.
http://trac.webkit.org/changeset/59565
https://bugs.webkit.org/show_bug.cgi?id=39173

Broke GTK (Requested by abarth on #webkit).

  • dom/CanvasSurface.cpp: (WebCore::CanvasSurface::toDataURL):
20:50 Changeset [59566] by dbates@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-15 Daniel Bates <dbates@rim.com>

Reviewed by Chris Jerdonek.

https://bugs.webkit.org/show_bug.cgi?id=39170

Add function parseSvnPropertyValue to parse single-line and multi-line
property values of an SVN property change.

  • Scripts/VCSUtils.pm:

Added function parseSvnPropertyValue. We will use this as part of
Bug #38885 <https://bugs.webkit.org/show_bug.cgi?id=38885>.

  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl: Added.
20:15 Changeset [59565] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-05-15 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add a test to verify that Canvas's toDataURL() is case insensitive wrt the mimeType argument.
https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Added.
  • fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html: Added.
  • fast/canvas/script-tests/canvas-toDataURL-case-insensitive-mimetype.js: Added. (tryMimeType):

2010-05-15 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas's toDataURL() should be case insensitive wrt the mimeType argument.
https://bugs.webkit.org/show_bug.cgi?id=39153

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-canvas-todataurl

Test: fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html

  • dom/CanvasSurface.cpp: (WebCore::CanvasSurface::toDataURL):
20:03 Changeset [59564] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Anders Bakken <agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

QObject::objectName() returns a QString and QtField::name()
creates a temporary QByteArray object and returns constData() from it.
This is not safe.

This patch changes the signature of the function to return a
QByteArray instead of const char *.

https://bugs.webkit.org/show_bug.cgi?id=39010

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getPropertyNames): (JSC::Bindings::QtField::name):
  • bridge/qt/qt_runtime.h:
19:52 Changeset [59563] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-15 Anders Bakken <agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Don't unnecessarily copy data when searching for methods in QtClass.

[Qt] JSValue QtClass::fallbackObject can be optimized
https://bugs.webkit.org/show_bug.cgi?id=37684

  • bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject):
19:34 Changeset [59562] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-15 Anders Bakken <agbakken@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Identifier::ascii() is not threadsafe and shouldn't be used for
converting to and from QString/QByteArray.

https://bugs.webkit.org/show_bug.cgi?id=39009

  • bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject): (JSC::Bindings::QtClass::fieldNamed):
19:22 Changeset [59561] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-15 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Based on the spec and Philip Taylor's test suite, createImageData() should throw
an INDEX_SIZE_ERR exception if either the sw or sh arguments are zero.
The link to the spec:
http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.imageData.getcreate.zero

https://bugs.webkit.org/show_bug.cgi?id=39166

The complete test suite is in the process of checking in.
https://bugs.webkit.org/show_bug.cgi?id=20553

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData):
19:08 Changeset [59560] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-05-15 Darin Fisher <darin@chromium.org>

Reviewed by Adam Barth.

[chromium] Expose element accessor on WebPluginContainer
https://bugs.webkit.org/show_bug.cgi?id=39152

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::element):
  • src/WebPluginContainerImpl.h:
18:43 Changeset [59559] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

XMLHttpRequest.getResponseHeader doesn't need to be custom
https://bugs.webkit.org/show_bug.cgi?id=39125

I don't see any reason this method needs to be custom. No new tests
because there's no behavior change.

  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.idl:
17:30 Changeset [59558] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-05-15 Adam Barth <abarth@webkit.org>

Reviewed by David Hyatt.

Rebaseline client-rects.html on Qt
https://bugs.webkit.org/show_bug.cgi?id=39169

  • platform/qt/Skipped:
  • platform/qt/fast/multicol/client-rects-expected.txt:
17:19 Changeset [59557] by eric@webkit.org
  • 14 edits in trunk/WebCore

2010-05-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

XMLHttpRequest.setRequestHeader shouldn't be custom
https://bugs.webkit.org/show_bug.cgi?id=39124

I don't see any reason why this method needs to be custom. No tests
because no behavior change.

  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::methodThatRequiresAllArgsCallback): (WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback): (WebCore::ConfigureV8TestObjTemplate):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.idl:
15:33 Changeset [59556] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=39048
<rdar://problem/7978384> REGRESSION (r55802): XML errors on Google maps ("Entity 'nbsp' not
defined") with JavaScript disabled

Google Maps goes into mobile mode if JavaScript is disabled for some reason, and sends XHTML
content with XHTML Mobile DOCTYPE. We want to handle it whether XHTMLMP is enabled or not.

Test: fast/doctypes/xhtml-with-xhtmlmp-doctype.xhtml

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::externalSubsetHandler): Restore pre-55802 behavior for builds that don't have XHTMLMP enabled. Given that r55802 negated the condition without breaking XHTMLMP, this line is actually always needed.
15:29 Changeset [59555] by eric@webkit.org
  • 8 edits in trunk

2010-05-15 Jochen Eisinger <jochen@chromium.org>

Reviewed by Dmitry Titov.

Implement canEstablishDatabase call for workers.
https://bugs.webkit.org/show_bug.cgi?id=38742

  • public/WebCommonWorkerClient.h:
  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::allowDatabase): (WebKit::WebWorkerBase::allowDatabaseTask): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::cancel): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::result): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::signalCompleted): (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::didComplete):
  • src/WebWorkerBase.h:
  • src/WebWorkerClientImpl.h: (WebKit::WebWorkerClientImpl::allowDatabase):

2010-05-15 Jochen Eisinger <jochen@chromium.org>

Reviewed by Dmitry Titov.

Add allowDatabase method to TestWebWorker.
https://bugs.webkit.org/show_bug.cgi?id=38742

  • DumpRenderTree/chromium/TestWebWorker.h: (TestWebWorker::allowDatabase):
15:19 Changeset [59554] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

Fixing LayerChromium hierarchy updates where due to mixed ownership
handling, sublayer updates didn't always properly update parent-to-child
and child-to-parent pointers in sync.
https://bugs.webkit.org/show_bug.cgi?id=39138

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::setNeedsCommit): Typo fix. (WebCore::LayerChromium::insertSublayer): (WebCore::LayerChromium::removeFromSuperlayer): (WebCore::LayerChromium::removeSublayer): (WebCore::LayerChromium::replaceSublayer): (WebCore::LayerChromium::removeAllSublayers): (WebCore::LayerChromium::setSublayers):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setSuperlayer):
15:08 Changeset [59553] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Timothy Hatcher.

Got rid of absolute positioning in favor of flex boxes where possible.
Added shadow for help window.
Changed window style names to more comprehensible.
https://bugs.webkit.org/show_bug.cgi?id=39120

  • inspector/front-end/HelpScreen.js: (WebInspector.HelpScreen):
  • inspector/front-end/helpScreen.css: (.help-window-outer): (body.attached .help-window-outer): (.help-window-main): (body.attached .help-window-main): (.help-window-caption): (body.attached .help-window-caption): (.help-window-title): (.help-scrollable): (.help-close-button): (body.platform-mac .help-close-button): (body:not(.platform-mac) .help-close-button):
13:29 Changeset [59552] by hausmann@webkit.org
  • 1 edit
    19 deletes in trunk/WebKitTools

[Qt] Rename QtLauncher to QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=37665

Rubber-stamped by Antti Koivisto.

Forgot to remove the original directory after the rename.

  • QtLauncher: Removed.
13:23 Changeset [59551] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59549.
http://trac.webkit.org/changeset/59549
https://bugs.webkit.org/show_bug.cgi?id=39167

Broke Chromium build (Requested by abarth on #webkit).

  • bindings/scripts/CodeGeneratorV8.pm:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h:
13:03 Changeset [59550] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-15 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

Adding code path for composited layers (LayerChromium) containing only
an Image element.
https://bugs.webkit.org/show_bug.cgi?id=39142

No new tests, covered under the existing tests for composited layers.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::updateContentsImage):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::setContents):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::contents):
12:53 Changeset [59549] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBRequest is not a proper ActiveDomObject
https://bugs.webkit.org/show_bug.cgi?id=39001

Add IDBRequest interface to the IsActiveDomType
routine of the CodeGeneratorV8.pm.

Rename IDBRequest::m_stopped to m_suspended and reset
the flag when resume() is called.

No new tests, Indexed Database isn't yet testable.

  • bindings/scripts/CodeGeneratorV8.pm:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::suspend): (WebCore::IDBRequest::resume): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
  • storage/IDBRequest.h:
12:41 Changeset [59548] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-15 Andrei Bucur <abucur@adobe.com>

Reviewed by Gustavo Noronha Silva.

Functions using the cairo_pattern_t object returned by
Pattern::createPlatformPattern sould destroy it after the painting
operation. Failing to do so causes memory leaks.

Test: No test was added because the patch adds no new functionality.
It just completes the normal life cycle of a cairo_pattern_t object.

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): (WebCore::setPlatformStroke):
12:22 Changeset [59547] by oliver@apple.com
  • 7 edits in trunk

2010-05-15 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Incorrect codegen for slowcase of < in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=39151

Call the correct stud for the slowcases of the < operator.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jless):

2010-05-15 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Incorrect codegen for slowcase of < in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=39151

Add yet more tests for the < operator when comparing integer strings.

  • fast/js/comparison-operators-greater-expected.txt:
  • fast/js/comparison-operators-less-expected.txt:
  • fast/js/script-tests/comparison-operators-greater.js:
  • fast/js/script-tests/comparison-operators-less.js:
11:56 Changeset [59546] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59544.
http://trac.webkit.org/changeset/59544
https://bugs.webkit.org/show_bug.cgi?id=39165

Cased LayoutTest to start crashing (Requested by abarth on
#webkit).

  • Scripts/old-run-webkit-tests:
11:38 Changeset [59545] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-15 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Darin Adler.

Fix bug https://bugs.webkit.org/show_bug.cgi?id=38890

  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
11:26 Changeset [59544] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-15 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

Ensure DRT loads GAIL (Gtk+ module), for a11y tests
https://bugs.webkit.org/show_bug.cgi?id=38648

Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port

  • Scripts/old-run-webkit-tests:
10:34 Changeset [59543] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-15 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

[chromium] Adding a notification on WebViewClient when a new
node gets focused.
https://bugs.webkit.org/show_bug.cgi?id=38508

  • public/WebViewClient.h: (WebKit::WebViewClient::focusedNodeChanged):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focusedNodeChanged):
10:01 Changeset [59542] by yael.aharon@nokia.com
  • 5 edits in trunk/LayoutTests

Unreviewed.

Update expected results after 59541

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
09:41 Changeset [59541] by yael.aharon@nokia.com
  • 26 edits
    16 adds in trunk

Initial support for HTMLMeterElement
https://bugs.webkit.org/show_bug.cgi?id=38140

Reviewed by Kent Tamura.

WebCore:

This patch adds support for HTMLMeterElement, including default rendering
of the meter element. That is because some platforms do not have a native gauge.
The feature is turned on only for the Qt platform.

Tests: fast/dom/HTMLMeterElement/meter-element.html

fast/dom/HTMLMeterElement/set-meter-properties.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • css/html.css:

(meter):
(meter::-webkit-meter):

  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::inlineTagList):

  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLMeterElement.cpp: Added.

(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::create):
(WebCore::HTMLMeterElement::createRenderer):
(WebCore::HTMLMeterElement::formControlType):
(WebCore::HTMLMeterElement::parseMappedAttribute):
(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::setValue):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::setLow):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::setHigh):
(WebCore::HTMLMeterElement::optimum):
(WebCore::HTMLMeterElement::setOptimum):

  • html/HTMLMeterElement.h: Added.

(WebCore::HTMLMeterElement::recalcWillValidate):

  • html/HTMLMeterElement.idl: Added.
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:
  • platform/ThemeTypes.h:
  • rendering/RenderMeter.cpp: Added.

(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::layout):
(WebCore::RenderMeter::updateFromElement):

  • rendering/RenderMeter.h: Added.

(WebCore::RenderMeter::renderName):
(WebCore::RenderMeter::isMeter):
(WebCore::toRenderMeter):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isMeter):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::adjustMeterStyle):
(WebCore::RenderTheme::paintMeter):

  • rendering/RenderTheme.h:

LayoutTests:

  • fast/dom/HTMLMeterElement: Added.
  • fast/dom/HTMLMeterElement/meter-element.html: Added.
  • fast/dom/HTMLMeterElement/script-tests: Added.
  • fast/dom/HTMLMeterElement/script-tests/TEMPLATE.html: Added.
  • fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js: Added.
  • fast/dom/HTMLMeterElement/set-meter-properties-expected.txt: Added.
  • fast/dom/HTMLMeterElement/set-meter-properties.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/fast/dom/HTMLMeterElement: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/win/Skipped:
09:36 Changeset [59540] by eric@webkit.org
  • 10 edits
    3 copies
    5 adds in trunk

2010-05-15 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
https://bugs.webkit.org/show_bug.cgi?id=34992

  • storage/change-version-handle-reuse.html: Refactored to share code with the worker version of the test.
  • storage/change-version-handle-reuse-expected.html: Removed reference to reloading, which this test doesn't do.
  • storage/change-version-handle-reuse.js: This is the extracted shared core of the test.
  • storage/execute-sql-args.html: Refactored to share code with the worker version of the test.
  • storage/execute-sql-args.js: This is the extracted shared core of the test.

These are the worker versions of the tests; they're tiny shims around shared code.

  • fast/workers/storage/execute-sql-args-worker-expected.txt: Added.
  • fast/workers/storage/execute-sql-args-worker.html: Added.
  • fast/workers/storage/change-version-handle-reuse-worker-expected.txt: Added.
  • fast/workers/storage/change-version-handle-reuse-worker.html: Added. This file gets included from worker database tests; it does all the boilerplate that's needed on the DOM side.
  • fast/workers/storage/resources/database-worker-controller.js: Added. This file is the boilerplate for the worker side of the database tests. It will import and run the actual test on command, and will report back completion and exceptions.
  • fast/workers/storage/resources/database-worker.js: Added.

2010-05-15 Eric Uhrhane <ericu@chromium.org>

Reviewed by Dmitry Titov.

Add bindings for async DB API in Workers.
https://bugs.webkit.org/show_bug.cgi?id=34992

Tests: storage/change-version-handle-reuse-worker.html

storage/execute-sql-args-worker.html

  • bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding. (WebCore::JSWorkerContext::openDatabase):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there. (WebCore::V8WorkerContext::openDatabaseCallback):

Add NoStaticTables flags to all objects now shared with workers.

  • storage/Database.idl:
  • storage/SQLError.idl:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLTransaction.idl:
  • workers/WorkerContext.h: Add databaseExceededQuota.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now. (WebCore::WorkerContext::openDatabase): Remove invalid assertion.

Add the IDL for the call to openDatabase.

  • workers/WorkerContext.idl:
07:00 Changeset [59539] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-05-15 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by Simon Hausmann.

This patch fixes the build failure of WebKit on Linux for Qt4.5
https://bugs.webkig.org/show_bug.cgi?id=39108

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::syncLayers):
  • WebCoreSupport/QtPlatformPlugin.cpp:
06:49 Changeset [59538] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-05-15 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Add script to check for minimum python version and install if missing on Tiger
https://bugs.webkit.org/show_bug.cgi?id=38886

Per Maciej's request on webkit-dev:
https://lists.webkit.org/pipermail/webkit-dev/2010-May/012785.html
provide a script which can automatically install Python on Tiger where
the system provided version is too old to be of use.

Note this uses the official Mac Python installer from python.org.
This installs a copy of Python in /Library/Frameworks/Python.framework.
It also makes symlinks from /usr/local/bin to the Python.framework/bin.

I have tested this script on Leopard and it worked fine. I have not
tested it on Tiger as I do not have access to a Tiger machine. In
either case this should provide a great starting point for someone
wishing to upgrade their copy of Python on Tiger.

Future patches can make our scripts depend on a success return from this
script and then they can either skip tests/sections for which python is
insufficient, or they can fail themselves.

  • Scripts/ensure-valid-python: Added.
06:37 Changeset [59537] by eric@webkit.org
  • 6 edits
    36 adds in trunk

2010-05-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • cmake/FindCFLite.cmake: Added.
  • cmake/FindCairo.cmake: Added.
  • cmake/FindEFL.cmake: Added.
  • cmake/FindFreetype.cmake: Added.
  • cmake/FindGDK-PixBuf.cmake: Added.
  • cmake/FindGDK.cmake: Added.
  • cmake/FindGIO.cmake: Added.
  • cmake/FindGlib.cmake: Added.
  • cmake/FindICU.cmake: Added.
  • cmake/FindLibSoup2.cmake: Added.
  • cmake/FindLibXlst.cmake: Added.
  • cmake/FindPango.cmake: Added.
  • cmake/FindSqlite.cmake: Added.
  • cmake/LibFindMacros.cmake: Added.
  • cmake/OptionsCommon.cmake: Added.
  • cmake/OptionsEfl.cmake: Added.
  • cmake/WebKitEfl.cmake: Added.
  • cmake/WebKitFS.cmake: Added.
  • cmake/WebKitFeatures.cmake: Added.
  • cmake/WebKitGenerators.cmake: Added.
  • cmake/WebKitHelpers.cmake: Added.
  • cmake/WebKitMacros.cmake: Added.
  • cmakeconfig.h.cmake: Added.

2010-05-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • CMakeListsEfl.txt: Added.
  • config.h: Add conditional to look for cmakeconfig.h.
  • jsc/CMakeLists.txt: Added.
  • jsc/CMakeListsEfl.txt: Added.
  • wtf/CMakeLists.txt: Added.
  • wtf/CMakeListsEfl.txt: Added.

2010-05-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • CMakeListsEfl.txt: Added.
  • config.h: Add conditional to look for cmakeconfig.h.

2010-05-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Adam Treat.

[EFL] Add build system for the EFL port.
http://webkit.org/b/37945

  • CMakeLists.txt: Added.
  • CMakeListsEfl.txt: Added.
06:14 Changeset [59536] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Clipboard.setData doesn't need to be custom
https://bugs.webkit.org/show_bug.cgi?id=39133

The implementation of the custom binding for this function was a bit
different than its declaration in the IDL file. I've updated the IDL
to match the implementation, but we probably should check whether our
behavior is correct with respect to the specification.

No tests because I've maintained our current behavior.

  • bindings/js/JSClipboardCustom.cpp:
  • bindings/v8/custom/V8ClipboardCustom.cpp:
  • dom/Clipboard.idl:
05:09 Changeset [59535] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-15 Xan Lopez <xlopez@igalia.com>

Skip failing test, it depends on one patch still in the commit
queue.

  • platform/gtk/Skipped:
03:42 Changeset [59534] by eric@webkit.org
  • 9 edits
    2 copies
    1 add in trunk/WebKitTools

2010-05-15 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Display queue position inside EWS bubbles
https://bugs.webkit.org/show_bug.cgi?id=38979

This ended up being a lot of clean-up to our status server code.

Added a new WorkItems model, a form with which to fill it,
and taught the Attachment class how to calculate the current queue
postion for an attachment using the data in WorkItems.

I also finally made statusbubble.* and dashboard.* not use copy-paste code.

The Attachment class has this summary() method which is very
controller/view-like and does not belong in a model class.
This patch got rid of all direct uses of summary().

  • QueueStatusServer/handlers/dashboard.py:
    • Build row objects to hand off to the view instead of handing off a summary object and expecting the view to process it directly.
  • QueueStatusServer/handlers/statusbubble.py:
    • Build bubble object and hand them off to the view.
  • QueueStatusServer/handlers/updatestatus.py:
    • Code cleanup. Just move some code into _queue_status_from_request to make the main put() handler easier to read.
  • QueueStatusServer/handlers/updateworkitems.py: Added.
    • Controller to handle storing WorkItems model objects.
  • QueueStatusServer/main.py:
    • Add route for /update-work-items
  • QueueStatusServer/model/attachment.py:
    • Add new methods to replace direct summary() access.
    • Teach attachment how to calculate queue positions from WorkItems data.
  • QueueStatusServer/model/queues.py:
    • Move name_with_underscores here for easier re-use.
  • QueueStatusServer/model/workitems.py: Added.
    • New model for storing what items are currently queue for any bot.
  • QueueStatusServer/templates/dashboard.html:
    • Kill the copy/paste code!
  • QueueStatusServer/templates/statusbubble.html:
    • Kill the copy/paste code!
  • QueueStatusServer/templates/updateworkitems.html: Added.
    • Simple form for updating a queue's current work items.
03:14 Changeset [59533] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-05-15 Yaar Schnitman <yaar@chromium.org>

Reviewed by Adam Barth.

V8 overload support ported to JSC. Unforking of overloaded declarations in WebGL & Canvas will be done in subsequent patches.
https://bugs.webkit.org/show_bug.cgi?id=38920

Note that JSTestCallback.cpp/h include minor irrelevant changes too since somebody forgot to update them after changing the JS generator.

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestCallback.cpp: (WebCore::JSTestCallback::JSTestCallback): (WebCore::JSTestCallback::~JSTestCallback):
  • bindings/scripts/test/JS/JSTestCallback.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): (WebCore::testObjPrototypeFunctionOverloadedMethod):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
02:55 Changeset [59532] by eric@webkit.org
  • 5 edits
    2 adds in trunk

2010-05-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30500
[Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail

The "announcement" is now made in the form of an object attribute
associated with the AtkObject.

  • platform/gtk/accessibility/object-attributes.html: Added.
  • platform/gtk/accessibility/object-attributes-expected.txt: Added.

2010-05-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30500
[Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail

The "announcement" is now made in the form of an object attribute
associated with the AtkObject.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_attributes):

2010-05-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=30500
[Gtk] Find a way for WebKit to "announce" itself so that ATs can readily distinguish it from true Gtk/Gail

The "announcement" is now made in the form of an object attribute
associated with the AtkObject.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::allAttributes): (attributeSetToString):
02:44 Changeset [59531] by eric@webkit.org
  • 4 edits in trunk

2010-05-15 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

Accessibility: Implement isSelected in DRT for GTK
https://bugs.webkit.org/show_bug.cgi?id=31018

Do not skip aria-controls-with-tabs.html anymore

  • platform/gtk/Skipped:

2010-05-15 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

Accessibility: Implement isSelected in DRT for GTK
https://bugs.webkit.org/show_bug.cgi?id=31018

Implement AccessibilityUIElement::isSelected() for Gtk

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isSelected):
02:33 Changeset [59530] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-05-15 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Update notifications test results
https://bugs.webkit.org/show_bug.cgi?id=39126
Add missing line endings.

  • fast/notifications/notifications-replace-expected.txt:
  • fast/notifications/notifications-request-permission-expected.txt:
  • fast/notifications/notifications-rtl-expected.txt:
02:21 Changeset [59529] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-15 Evan Stade <estade@chromium.org>

Reviewed by Adam Barth.

[chromium] "Check spelling in this field" context menu item always checked
https://bugs.webkit.org/show_bug.cgi?id=39018

Initialize all POD members of WebContextMenuData in a default
constructor.

No tests because this code would need some major refactoring to unit
test, and AFAICT it's not testable via layout tests. See note at top
of getCustomMenuFromDefaultItems.

  • public/WebContextMenuData.h: (WebKit::WebContextMenuData::WebContextMenuData):
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
02:10 Changeset [59528] by eric@webkit.org
  • 6 edits in trunk

2010-05-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Show a console message when X-Frame-Options blocks a load
https://bugs.webkit.org/show_bug.cgi?id=39087

Update expected results to show the console message.

  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:

2010-05-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Show a console message when X-Frame-Options blocks a load
https://bugs.webkit.org/show_bug.cgi?id=39087

The blank page confuses people when X-Frame-Options blocks a load. The
console message should at least give them a hint as to what's going on.

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
01:58 Changeset [59527] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-05-15 Chao-ying Fu <fu@mips.com>

Reviewed by Oliver Hunt.

Update MIPS JIT for unsigned right shift, Math.sqrt, load16
https://bugs.webkit.org/show_bug.cgi?id=38412

Fixed MIPS build failure.

  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::srl): (JSC::MIPSAssembler::srlv): (JSC::MIPSAssembler::sqrtd):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::urshift32): (JSC::MacroAssemblerMIPS::sqrtDouble): (JSC::MacroAssemblerMIPS::load16): (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
  • jit/JSInterfaceJIT.h:
01:46 Changeset [59526] by eric@webkit.org
  • 11 edits
    1 copy in trunk

2010-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Geoffrey Garen.

WebInspector: JSC Should provide heap size info for Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=38420

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/Collector.cpp: (JSC::Heap::size):
  • runtime/Collector.h:

2010-05-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Geoffrey Garen.

WebInspector: JSC Should provide heap size info for Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=38420

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptGCEvent.cpp: Added. (WebCore::ScriptGCEvent::getHeapSize):
  • bindings/js/ScriptGCEvent.h:
01:25 Changeset [59525] by eric@webkit.org
  • 6 edits in trunk

2010-05-15 Dave Tapuska <dtapuska@rim.com>

Reviewed by Darin Adler.

Add a new define for we need strict arena alignment. ARMv5 with
double word instructions set this value.

  • wtf/Platform.h:

2010-05-15 Dave Tapuska <dtapuska@rim.com>

Reviewed by Darin Adler.

Fix alignment faults on ARMv5TE architectures.

In debug mode the RenderAreaDebugHeader was 12 bytes which
caused an alignment failure for RenderObjects because they
would start on a 4 byte boundary. Align the RenderArenaDebugHeader
using the ARENA_ALIGN macro.

In NDEBUG mode the RenderArena objects come from a pool which
has 4 byte alignment. Allow the alignment to be based on the
AllocAlignmentInteger. This define will be activated for ARMv5TE.

https://bugs.webkit.org/show_bug.cgi?id=19946

05/14/10:

23:50 Changeset [59524] by darin@chromium.org
  • 18 edits in trunk/WebKit/chromium

2010-05-14 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Remove temporary relative include paths
https://bugs.webkit.org/show_bug.cgi?id=38776

  • public/WebPasswordAutocompleteListener.h:
  • src/FrameLoaderClientImpl.h:
  • src/PlatformMessagePortChannel.h:
  • src/WebAnimationControllerImpl.h:
  • src/WebBindings.cpp:
  • src/WebDataSourceImpl.h:
  • src/WebDevToolsAgentPrivate.h:
  • src/WebFileChooserCompletionImpl.h:
  • src/WebFrameImpl.h:
  • src/WebInputEventConversion.h:
  • src/WebPluginContainerImpl.h:
  • src/WebPluginLoadObserver.h:
  • src/WebPopupMenuImpl.h:
  • src/WebSettingsImpl.h:
  • src/WebViewImpl.h:
  • src/WebWorkerClientImpl.h:
  • src/WrappedResourceRequest.h:
  • src/WrappedResourceResponse.h:
23:32 Changeset [59523] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-05-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

XMLHttpRequest.overrideMimeType doesn't need to be custom
https://bugs.webkit.org/show_bug.cgi?id=39127

I don't see any reason why this method should be custom. No tests
because no behavior change.

  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
  • xml/XMLHttpRequest.idl:
23:28 Changeset [59522] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

scm.py should use self.run instead of run_command
https://bugs.webkit.org/show_bug.cgi?id=38957

We've wanted to do this for a while, but it's a prerequiste for running
SVN from the cwd instead of the checkout_root.

  • Scripts/webkitpy/common/checkout/scm.py:
23:27 Changeset [59521] by sfalken@apple.com
  • 5 edits in tags/Safari-533.9.3

Versioning.

23:11 Changeset [59520] by sfalken@apple.com
  • 2 edits in tags/Safari-533.9.3/WebCore

Merge r59515.

23:07 Changeset [59519] by sfalken@apple.com
  • 1 copy in tags/Safari-533.9.3

New tag.

23:05 Changeset [59518] by sfalken@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59515.

22:32 Changeset [59517] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-14 Adam Barth <abarth@webkit.org>

Unreviewed.

Skip new test that fails on Qt. I'm sure skipping is the wrong thing
but no one is around to help me figure out what the right thing to do
is and I don't want to leave the bot red all weekend.

  • platform/qt/Skipped:
21:46 Changeset [59516] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=39095
<rdar://problem/7984158> REGRESSION (r53085): Infinite recursion in Position::getInlineBoxAndOffset when changing writing direction to right-to-left

Reviewed by Dave Hyatt.

Test: editing/selection/applystyle-to-inline-inside-block.html

  • dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset): Now that this function correctly goes in and out of editable areas by calling

downstreamIgnoringEditingBoundaries and upstreamIgnoringEditingBoundaries for blocks (added in r58665), we no longer need a special case to
jump out to the parent when we hit an inline (which was added in r53085 when this issue was introduced).

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=39095
<rdar://problem/7984158> REGRESSION (r53085): Infinite recursion in Position::getInlineBoxAndOffset when changing writing direction to right-to-left

Reviewed by Dave Hyatt.

  • editing/selection/applystyle-to-inline-in-block-expected.txt: Added.
  • editing/selection/applystyle-to-inline-in-block.html: Added.
20:49 Changeset [59515] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Hopefully a last fix for the build. Call -mkdir instead of mkdir, so we don't bail if the mkdir call fails. Additionally,
use the %Env% syntax instead of $(Env), which is what we need if we are referring to Windows environment variables instead
of nmake variables.

Reviewed by Mark Rowe.

  • WebCore.vcproj/WebCore.make:
20:40 Changeset [59514] by slewis@apple.com
  • 6 edits in trunk

Update order files.

Rubber-stamped by Mark Rowe.

JavaScriptCore:

WebCore:

  • WebCore.order:

WebKit/mac:

  • WebKit.order:
20:17 Changeset [59513] by hyatt@apple.com
  • 16 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=39137

Reviewed by Simon Fraser.

WebCore:

Make RenderLayers position properly inside multicolumn layout.

(1) Create RenderLayers when column properties are specified. This allows descendant layers to easily
know they are inside a multicolumn layout when positioning.

(2) Patch updateLayerPosition to offset the layer into the first column that contains the layer. Splitting
of a layer across columns still does not work, but the layer will now at least appear in the first column in
which it occurs.

(3) Fix pagination bugs caused by the fact that visual overflow doesn't propagate up the line box tree when layers
are involved. Make sure to use lineTop and lineBottom in this case (it's not perfect, but it gets most cases
working properly). With this change elements like <video> will paginate properly and not get split across pages.

(4) Make column repainting and layer positioning work with RTL columns by fixing adjustForColumns to
account for RTL.

(5) Fix RTL pagination by making sure the column pagination rects are the content width of the whole block and not just
the width of one column.

Added fast/multicol/layers-in-multicol.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderBox.h:

(WebCore::RenderBox::locationOffset):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::requiresLayer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:

(WebCore::RenderView::requiresLayer):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::specifiesColumns):

LayoutTests:

Reset all multicolumn test results now that columns create RenderLayers.

  • fast/multicol/client-rects-expected.txt:
  • fast/multicol/layers-in-multicol.html: Added.
  • fast/multicol/single-line-expected.txt:
  • platform/mac/fast/multicol/column-rules-expected.txt:
  • platform/mac/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.txt:


Add a layout test for various types of RenderLayers inside multicol layouts.

  • platform/mac/fast/multicol/layers-in-multicol-expected.txt: Added.
19:54 Changeset [59512] by eric@webkit.org
  • 5 edits in trunk

2010-05-14 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Consider implementing addOriginAccessWhitelistEntry method
https://bugs.webkit.org/show_bug.cgi?id=37578

Remove deprecated methods.

  • public/WebSecurityPolicy.h:
  • src/WebSecurityPolicy.cpp:

2010-05-14 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Consider implementing addOriginAccessWhitelistEntry method
https://bugs.webkit.org/show_bug.cgi?id=37578

Remove deprecated methods.

  • DumpRenderTree/chromium/LayoutTestController.cpp
  • DumpRenderTree/chromium/LayoutTestController.h
18:57 Changeset [59511] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-14 Leon Clarke <leonclarke@google.com>

Reviewed by Steve Block.

Refactor signature of tokenizeRelAttribute and the variables it refers to so that new features don't keep changing the signature, and make m_disabledState into an enum.
https://bugs.webkit.org/show_bug.cgi?id=38900

No new tests. Refactoring only.

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute): (WebCore::HTMLLinkElement::isAlternate): (WebCore::HTMLLinkElement::isDisabled): (WebCore::HTMLLinkElement::isEnabledViaScript): (WebCore::HTMLLinkElement::isIcon): (WebCore::HTMLLinkElement::):
  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::processAttribute):
18:43 Changeset [59510] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer caches directly composited images
https://bugs.webkit.org/show_bug.cgi?id=38444

Directly-composited images and solid fills shouldn't be cached, as that cache
is never used (see GraphicsLayerQtImpl::paint). Cache is only relevant for HTML content,
but we were missing that test.
The fix makes sure we only cache HTML content.

No new tests: this is a minor optimization.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
18:18 Changeset [59509] by mrowe@apple.com
  • 5 edits in tags/Safari-533.9.2

Versioning.

18:08 Changeset [59508] by mrowe@apple.com
  • 2 edits in tags/Safari-533.9.2/WebCore

Merge r59505.

17:56 Changeset [59507] by mrowe@apple.com
  • 1 copy in tags/Safari-533.9.2

New tag.

17:55 Changeset [59506] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59505.

17:45 Changeset [59505] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Build fix. Had the environment variables wrong for source and destination of the copy operation
that was added.

Reviewed by Mark Rowe.

  • WebCore.vcproj/WebCore.make:
17:29 Changeset [59504] by ap@apple.com
  • 2 edits
    4 moves in trunk/LayoutTests

Inspired by Simon Fraser, rubber-stamped by Geoff Garen.

Disabled Sputnik tests that take over 10 seconds in debug builds on my MacBook Pro.

  • platform/mac-tiger/Skipped: These tests were alrady skipped on Tiger, no need to skip explicitly any more.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html: Removed.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html-disabled: Copied from fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html: Removed.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html-disabled: Copied from fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html: Removed.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html-disabled: Copied from fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.1.html.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html: Removed.
  • fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html-disabled: Copied from fast/js/sputnik/Unicode/Unicode_218/S7.6_A3.2.html.
17:08 Changeset [59503] by eric@webkit.org
  • 9 edits in trunk/JavaScriptCore

2010-05-14 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Implementation of QtScript API that provide method to convert a value to an object.

[Qt] QtScript is missing toObject API
https://bugs.webkit.org/show_bug.cgi?id=36594

  • qt/api/qscriptengine.cpp: (QScriptEngine::toObject):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptvalue.cpp: (QScriptValue::toObject):
  • qt/api/qscriptvalue.h:
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::toObject):
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::toObject): (tst_QScriptEngine::toObjectTwoEngines):
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::toObjectSimple):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
16:34 Changeset [59502] by abarth@webkit.org
  • 7 edits in trunk/WebCore

2010-05-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove custom bindings for HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=38344

Fix a bug in the TestObj.idl file and update expected results. This
was originally part of a larger change reviewed by Eric, but I'm
landing it separately to help me understand the more interesting bits
of the patch clearly.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithSetterException): (WebCore::setJSTestObjAttrWithGetterException):
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj setAttrWithGetterException:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrSetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter):
16:12 Changeset [59501] by jparent@chromium.org
  • 2 edits in trunk/BugsSite

Bugzilla: Only show "Rietveld Review" link when in-rietveld is set to +.

Reviewed by Ojan Vafai.

https://bugs.webkit.org/show_bug.cgi?id=39141

  • template/en/custom/attachment/list.html.tmpl:
15:54 Changeset [59500] by jparent@chromium.org
  • 2 edits in trunk/BugsSite

Bugzilla: Don't send mail if the only change is to the in-rietveld flag.

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=39090

  • Bugzilla/BugMail.pm:
15:52 EFLWebKit edited by leandro@profusion.mobi
(diff)
15:52 EFLWebKit edited by leandro@profusion.mobi
(diff)
15:50 EFLWebKit edited by leandro@profusion.mobi
(diff)
15:50 EFLWebKit edited by leandro@profusion.mobi
(diff)
15:37 Changeset [59499] by kbr@google.com
  • 30 edits
    64 moves in trunk

2010-05-14 Kenneth Russell <kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData):

2010-05-14 Kenneth Russell <kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSArrayBufferConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.cpp. (WebCore::): (WebCore::JSArrayBufferConstructor::JSArrayBufferConstructor): (WebCore::constructCanvasArrayBuffer): (WebCore::JSArrayBufferConstructor::getConstructData):
  • bindings/js/JSArrayBufferConstructor.h: Copied from WebCore/bindings/js/JSWebGLArrayBufferConstructor.h. (WebCore::construct):
  • bindings/js/JSArrayBufferViewCustom.cpp: Copied from WebCore/bindings/js/JSWebGLArrayCustom.cpp. (WebCore::toJS): (WebCore::JSArrayBufferView::slice):
  • bindings/js/JSArrayBufferViewHelper.h: Copied from WebCore/bindings/js/JSWebGLArrayHelper.h.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::arrayBuffer): (WebCore::JSDOMWindow::int8Array): (WebCore::JSDOMWindow::uint8Array): (WebCore::JSDOMWindow::int32Array): (WebCore::JSDOMWindow::uint32Array): (WebCore::JSDOMWindow::int16Array): (WebCore::JSDOMWindow::uint16Array): (WebCore::JSDOMWindow::floatArray): (WebCore::JSDOMWindow::webGLArrayBuffer): (WebCore::JSDOMWindow::webGLByteArray): (WebCore::JSDOMWindow::webGLUnsignedByteArray): (WebCore::JSDOMWindow::webGLIntArray): (WebCore::JSDOMWindow::webGLUnsignedIntArray): (WebCore::JSDOMWindow::webGLShortArray): (WebCore::JSDOMWindow::webGLUnsignedShortArray): (WebCore::JSDOMWindow::webGLFloatArray):
  • bindings/js/JSFloatArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.cpp. (WebCore::): (WebCore::JSFloatArrayConstructor::JSFloatArrayConstructor): (WebCore::constructCanvasFloatArray): (WebCore::JSFloatArrayConstructor::getConstructData):
  • bindings/js/JSFloatArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLFloatArrayConstructor.h.
  • bindings/js/JSFloatArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLFloatArrayCustom.cpp. (WebCore::JSFloatArray::indexSetter): (WebCore::toJS): (WebCore::JSFloatArray::set):
  • bindings/js/JSInt16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.cpp. (WebCore::): (WebCore::JSInt16ArrayConstructor::JSInt16ArrayConstructor): (WebCore::constructCanvasShortArray): (WebCore::JSInt16ArrayConstructor::getConstructData):
  • bindings/js/JSInt16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLShortArrayConstructor.h.
  • bindings/js/JSInt16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLShortArrayCustom.cpp. (WebCore::JSInt16Array::indexSetter): (WebCore::toJS): (WebCore::JSInt16Array::set):
  • bindings/js/JSInt32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.cpp. (WebCore::): (WebCore::JSInt32ArrayConstructor::JSInt32ArrayConstructor): (WebCore::constructCanvasIntArray): (WebCore::JSInt32ArrayConstructor::getConstructData):
  • bindings/js/JSInt32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLIntArrayConstructor.h.
  • bindings/js/JSInt32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLIntArrayCustom.cpp. (WebCore::JSInt32Array::indexSetter): (WebCore::toJS): (WebCore::JSInt32Array::set):
  • bindings/js/JSInt8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.cpp. (WebCore::): (WebCore::JSInt8ArrayConstructor::JSInt8ArrayConstructor): (WebCore::constructCanvasByteArray): (WebCore::JSInt8ArrayConstructor::getConstructData):
  • bindings/js/JSInt8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLByteArrayConstructor.h.
  • bindings/js/JSInt8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLByteArrayCustom.cpp. (WebCore::JSInt8Array::indexSetter): (WebCore::toJS): (WebCore::JSInt8Array::set):
  • bindings/js/JSUint16ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp. (WebCore::): (WebCore::JSUint16ArrayConstructor::JSUint16ArrayConstructor): (WebCore::constructCanvasUnsignedShortArray): (WebCore::JSUint16ArrayConstructor::getConstructData):
  • bindings/js/JSUint16ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayConstructor.h.
  • bindings/js/JSUint16ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedShortArrayCustom.cpp. (WebCore::JSUint16Array::indexSetter): (WebCore::toJS): (WebCore::JSUint16Array::set):
  • bindings/js/JSUint32ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp. (WebCore::): (WebCore::JSUint32ArrayConstructor::JSUint32ArrayConstructor): (WebCore::constructCanvasUnsignedIntArray): (WebCore::JSUint32ArrayConstructor::getConstructData):
  • bindings/js/JSUint32ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayConstructor.h.
  • bindings/js/JSUint32ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedIntArrayCustom.cpp. (WebCore::JSUint32Array::indexSetter): (WebCore::toJS): (WebCore::JSUint32Array::set):
  • bindings/js/JSUint8ArrayConstructor.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp. (WebCore::): (WebCore::JSUint8ArrayConstructor::JSUint8ArrayConstructor): (WebCore::constructCanvasUnsignedByteArray): (WebCore::JSUint8ArrayConstructor::getConstructData):
  • bindings/js/JSUint8ArrayConstructor.h: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayConstructor.h.
  • bindings/js/JSUint8ArrayCustom.cpp: Copied from WebCore/bindings/js/JSWebGLUnsignedByteArrayCustom.cpp. (WebCore::JSUint8Array::indexSetter): (WebCore::toJS): (WebCore::JSUint8Array::set):
  • bindings/js/JSWebGLArrayBufferConstructor.cpp: Removed.
  • bindings/js/JSWebGLArrayBufferConstructor.h: Removed.
  • bindings/js/JSWebGLArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLArrayHelper.h: Removed.
  • bindings/js/JSWebGLByteArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLByteArrayConstructor.h: Removed.
  • bindings/js/JSWebGLByteArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLFloatArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLFloatArrayConstructor.h: Removed.
  • bindings/js/JSWebGLFloatArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLIntArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLIntArrayConstructor.h: Removed.
  • bindings/js/JSWebGLIntArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::bufferData): (WebCore::JSWebGLRenderingContext::bufferSubData): (WebCore::JSWebGLRenderingContext::texImage2D): (WebCore::JSWebGLRenderingContext::texSubImage2D): (WebCore::dataFunctionf): (WebCore::dataFunctioni): (WebCore::dataFunctionMatrix):
  • bindings/js/JSWebGLShortArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLShortArrayConstructor.h: Removed.
  • bindings/js/JSWebGLShortArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLUnsignedByteArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLUnsignedByteArrayConstructor.h: Removed.
  • bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLUnsignedIntArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLUnsignedIntArrayConstructor.h: Removed.
  • bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: Removed.
  • bindings/js/JSWebGLUnsignedShortArrayConstructor.cpp: Removed.
  • bindings/js/JSWebGLUnsignedShortArrayConstructor.h: Removed.
  • bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: Removed.
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayBufferCustom.cpp. (WebCore::V8ArrayBuffer::constructorCallback):
  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.cpp. (WebCore::toV8): (WebCore::V8ArrayBufferView::sliceCallback):
  • bindings/v8/custom/V8ArrayBufferViewCustom.h: Copied from WebCore/bindings/v8/custom/V8WebGLArrayCustom.h. (WebCore::constructWebGLArray):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::WebGLArrayBufferAccessorGetter): (WebCore::V8DOMWindow::WebGLByteArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedByteArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLShortArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedShortArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLIntArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLUnsignedIntArrayAccessorGetter): (WebCore::V8DOMWindow::WebGLFloatArrayAccessorGetter):
  • bindings/v8/custom/V8FloatArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLFloatArrayCustom.cpp. (WebCore::V8FloatArray::constructorCallback): (WebCore::V8FloatArray::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Int16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLShortArrayCustom.cpp. (WebCore::V8Int16Array::constructorCallback): (WebCore::V8Int16Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Int32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLIntArrayCustom.cpp. (WebCore::V8Int32Array::constructorCallback): (WebCore::V8Int32Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Int8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLByteArrayCustom.cpp. (WebCore::V8Int8Array::constructorCallback): (WebCore::V8Int8Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp. (WebCore::V8Uint16Array::constructorCallback): (WebCore::V8Uint16Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp. (WebCore::V8Uint32Array::constructorCallback): (WebCore::V8Uint32Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp: Copied from WebCore/bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp. (WebCore::V8Uint8Array::constructorCallback): (WebCore::V8Uint8Array::setCallback): (WebCore::toV8):
  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLArrayCustom.h: Removed.
  • bindings/v8/custom/V8WebGLByteArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLFloatArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLIntArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
  • bindings/v8/custom/V8WebGLShortArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp: Removed.
  • bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp: Removed.
  • html/canvas/ArrayBuffer.cpp: Copied from WebCore/html/canvas/WebGLArrayBuffer.cpp. (WebCore::ArrayBuffer::create): (WebCore::ArrayBuffer::ArrayBuffer): (WebCore::ArrayBuffer::data): (WebCore::ArrayBuffer::byteLength): (WebCore::ArrayBuffer::~ArrayBuffer): (WebCore::ArrayBuffer::tryAllocate):
  • html/canvas/ArrayBuffer.h: Copied from WebCore/html/canvas/WebGLArrayBuffer.h.
  • html/canvas/ArrayBuffer.idl: Copied from WebCore/html/canvas/WebGLArrayBuffer.idl.
  • html/canvas/ArrayBufferView.cpp: Copied from WebCore/html/canvas/WebGLArray.cpp. (WebCore::ArrayBufferView::ArrayBufferView): (WebCore::ArrayBufferView::~ArrayBufferView): (WebCore::ArrayBufferView::setImpl): (WebCore::ArrayBufferView::calculateOffsetAndLength):
  • html/canvas/ArrayBufferView.h: Copied from WebCore/html/canvas/WebGLArray.h. (WebCore::ArrayBufferView::buffer): (WebCore::ArrayBufferView::verifySubRange): (WebCore::ArrayBufferView::clampOffsetAndNumElements):
  • html/canvas/ArrayBufferView.idl: Copied from WebCore/html/canvas/WebGLArray.idl.
  • html/canvas/FloatArray.cpp: Copied from WebCore/html/canvas/WebGLFloatArray.cpp. (WebCore::FloatArray::create): (WebCore::FloatArray::FloatArray): (WebCore::FloatArray::slice):
  • html/canvas/FloatArray.h: Copied from WebCore/html/canvas/WebGLFloatArray.h. (WebCore::FloatArray::set): (WebCore::FloatArray::item):
  • html/canvas/FloatArray.idl: Copied from WebCore/html/canvas/WebGLFloatArray.idl.
  • html/canvas/Int16Array.cpp: Copied from WebCore/html/canvas/WebGLShortArray.cpp. (WebCore::Int16Array::create): (WebCore::Int16Array::Int16Array): (WebCore::Int16Array::slice):
  • html/canvas/Int16Array.h: Copied from WebCore/html/canvas/WebGLShortArray.h.
  • html/canvas/Int16Array.idl: Copied from WebCore/html/canvas/WebGLShortArray.idl.
  • html/canvas/Int32Array.cpp: Copied from WebCore/html/canvas/WebGLIntArray.cpp. (WebCore::Int32Array::create): (WebCore::Int32Array::Int32Array): (WebCore::Int32Array::slice):
  • html/canvas/Int32Array.h: Copied from WebCore/html/canvas/WebGLIntArray.h.
  • html/canvas/Int32Array.idl: Copied from WebCore/html/canvas/WebGLIntArray.idl.
  • html/canvas/Int8Array.cpp: Copied from WebCore/html/canvas/WebGLByteArray.cpp. (WebCore::Int8Array::create): (WebCore::Int8Array::Int8Array): (WebCore::Int8Array::slice):
  • html/canvas/Int8Array.h: Copied from WebCore/html/canvas/WebGLByteArray.h.
  • html/canvas/Int8Array.idl: Copied from WebCore/html/canvas/WebGLByteArray.idl.
  • html/canvas/IntegralTypedArrayBase.h: Copied from WebCore/html/canvas/WebGLIntegralTypedArrayBase.h. (WebCore::IntegralTypedArrayBase::set): (WebCore::IntegralTypedArrayBase::item): (WebCore::IntegralTypedArrayBase::IntegralTypedArrayBase):
  • html/canvas/TypedArrayBase.h: Copied from WebCore/html/canvas/WebGLTypedArrayBase.h. (WebCore::TypedArrayBase::set): (WebCore::TypedArrayBase::TypedArrayBase): (WebCore::TypedArrayBase::create):
  • html/canvas/Uint16Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.cpp. (WebCore::Uint16Array::create): (WebCore::Uint16Array::Uint16Array): (WebCore::Uint16Array::slice):
  • html/canvas/Uint16Array.h: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.h.
  • html/canvas/Uint16Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedShortArray.idl.
  • html/canvas/Uint32Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.cpp. (WebCore::Uint32Array::create): (WebCore::Uint32Array::Uint32Array): (WebCore::Uint32Array::slice):
  • html/canvas/Uint32Array.h: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.h.
  • html/canvas/Uint32Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedIntArray.idl.
  • html/canvas/Uint8Array.cpp: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.cpp. (WebCore::Uint8Array::create): (WebCore::Uint8Array::Uint8Array): (WebCore::Uint8Array::slice):
  • html/canvas/Uint8Array.h: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.h.
  • html/canvas/Uint8Array.idl: Copied from WebCore/html/canvas/WebGLUnsignedByteArray.idl.
  • html/canvas/WebGLArray.cpp: Removed.
  • html/canvas/WebGLArray.h: Removed.
  • html/canvas/WebGLArray.idl: Removed.
  • html/canvas/WebGLArrayBuffer.cpp: Removed.
  • html/canvas/WebGLArrayBuffer.h: Removed.
  • html/canvas/WebGLArrayBuffer.idl: Removed.
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferData): (WebCore::WebGLBuffer::associateBufferSubData):
  • html/canvas/WebGLBuffer.h: (WebCore::WebGLBuffer::elementArrayBuffer):
  • html/canvas/WebGLByteArray.cpp: Removed.
  • html/canvas/WebGLByteArray.h: Removed.
  • html/canvas/WebGLByteArray.idl: Removed.
  • html/canvas/WebGLFloatArray.cpp: Removed.
  • html/canvas/WebGLFloatArray.h: Removed.
  • html/canvas/WebGLFloatArray.idl: Removed.
  • html/canvas/WebGLGetInfo.cpp: (WebCore::WebGLGetInfo::WebGLGetInfo): (WebCore::WebGLGetInfo::getWebGLFloatArray): (WebCore::WebGLGetInfo::getWebGLIntArray): (WebCore::WebGLGetInfo::getWebGLUnsignedByteArray):
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLIntArray.cpp: Removed.
  • html/canvas/WebGLIntArray.h: Removed.
  • html/canvas/WebGLIntArray.idl: Removed.
  • html/canvas/WebGLIntegralTypedArrayBase.h: Removed.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::vertexAttrib1fv): (WebCore::WebGLRenderingContext::vertexAttrib2fv): (WebCore::WebGLRenderingContext::vertexAttrib3fv): (WebCore::WebGLRenderingContext::vertexAttrib4fv): (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter): (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter): (WebCore::WebGLRenderingContext::getWebGLUnsignedByteArrayParameter):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLShortArray.cpp: Removed.
  • html/canvas/WebGLShortArray.h: Removed.
  • html/canvas/WebGLShortArray.idl: Removed.
  • html/canvas/WebGLTypedArrayBase.h: Removed.
  • html/canvas/WebGLUnsignedByteArray.cpp: Removed.
  • html/canvas/WebGLUnsignedByteArray.h: Removed.
  • html/canvas/WebGLUnsignedByteArray.idl: Removed.
  • html/canvas/WebGLUnsignedIntArray.cpp: Removed.
  • html/canvas/WebGLUnsignedIntArray.h: Removed.
  • html/canvas/WebGLUnsignedIntArray.idl: Removed.
  • html/canvas/WebGLUnsignedShortArray.cpp: Removed.
  • html/canvas/WebGLUnsignedShortArray.h: Removed.
  • html/canvas/WebGLUnsignedShortArray.idl: Removed.
  • page/DOMWindow.idl:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData):

2010-05-14 Kenneth Russell <kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • fast/dom/script-tests/constructed-objects-prototypes.js: (constructorPropertiesOnWindow):
  • fast/dom/script-tests/prototype-inheritance-2.js: (constructorNamesForWindow):

2010-05-14 Kenneth Russell <kbr@google.com>

Reviewed by Darin Adler.

Rename WebGLArray types to TypedArray types
https://bugs.webkit.org/show_bug.cgi?id=39091

Extended functionality of do-webcore-rename script and used it to
rename the WebGLArray types to the TypedArray naming convention.
The only source files which were touched by hand, and which are
being manually reviewed, are:

WebCore/page/DOMWindow.idl
WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

These only needed to be touched to update the aliases between the
WebGLArray and TypedArray names introduced in bug 39036. (It was
not feasible to have do-webcore-rename handle this as it would
introduce circular renamings.) These aliases will be removed in
roughly a month once existing WebGL content has been updated.

No new tests; covered under existing WebGL tests. Updated
constructed-objects-prototypes and prototype-inheritance-2 tests.
Ran all layout tests in Safari and all WebGL tests in Chromium.

  • Scripts/do-webcore-rename: Handle the case where some renames are substrings of others. Support renaming files containing custom JS bindings. If isDOMTypeRename is non-zero, expand the regexp which rewrites the file's contents in order to support custom JS bindings.
15:32 Changeset [59498] by sfalken@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7985864> Connection properties dictionary should use standard callbacks for keys, values
https://bugs.webkit.org/show_bug.cgi?id=39132

Reviewed by Sam Weinig.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::createConnectionProperties):

15:27 Changeset [59497] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebKit/win/ChangeLog

Merge r59438.

15:27 Changeset [59496] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch/WebKit/win

Merge r59434.

15:14 Changeset [59495] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-05-14 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Tests that large colspan in a fixed table layout does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=38261

  • fast/table/fixed-table-layout-large-colspan-crash-expected.txt: Added.
  • fast/table/fixed-table-layout-large-colspan-crash.html: Added.

2010-05-14 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Move the m_width(Length) and m_columns(RenderTable::ColumnStruct)
vector out-of-bounds check out of the ASSERT into the main code.
https://bugs.webkit.org/show_bug.cgi?id=38261

Test: fast/table/fixed-table-layout-large-colspan-crash.html

  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
15:08 Changeset [59494] by mrowe@apple.com
  • 5 edits in tags/Safari-533.9.1

Versioning.

15:04 Changeset [59493] by mrowe@apple.com
  • 2 edits in tags/Safari-533.9.1/WebCore

Merge r59481.

14:54 Changeset [59492] by mrowe@apple.com
  • 1 copy in tags/Safari-533.9.1

New tag.

14:54 Changeset [59491] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59481.

14:14 Changeset [59490] by eric@webkit.org
  • 28 edits in trunk

2010-05-14 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r59489.
http://trac.webkit.org/changeset/59489
https://bugs.webkit.org/show_bug.cgi?id=37815

abarth broke the known universe and then some.

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:

2010-05-14 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r59489.
http://trac.webkit.org/changeset/59489
https://bugs.webkit.org/show_bug.cgi?id=37815

abarth broke the known universe and then some.

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):
13:52 Changeset [59489] by abarth@webkit.org
  • 28 edits in trunk

2010-05-14 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).

  • Android.jscbindings.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm: (WebCore::ObjCEventListener::handleEvent):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-14 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
13:49 Changeset [59488] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2010-05-14 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Update tools.html to mention that Tiger users require a newer Python
https://bugs.webkit.org/show_bug.cgi?id=38822

Also updated the instructions that only Tiger users need
to install a subversion client. Newer OSes already have
subversion included in the install.

  • building/tools.html:
13:36 Changeset [59487] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Adding resized image caching for Skia.
https://bugs.webkit.org/show_bug.cgi?id=39085

Patch by Sergey Ulanov <sergeyu@chromium.org> on 2010-05-14
Reviewed by Dmitry Titov and Brett Wilson.

Tests: HTML5 video on YouTube.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::Image::drawPattern): Use bitmap->resizedBitmap() to cache resized image when possible.

13:32 Changeset [59486] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=39008
<rdar://problem/7976142> REGRESSION (r58950): Webkit crashes on clicking back button when in Hotmail

Test: fast/parser/tokenizer-close-during-document-write.html

  • dom/Document.cpp: (WebCore::Document::write): Check that the tokenizer is still around after calling write(). It can become null (as it happens in regression test), and I don't see any guarantee that it would never be replaced with a different one (but I can't make a test for that).
13:31 Changeset [59485] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Fix the code indentation inside a namespace to be consistent with the
style guide.

Rubber-stamped by Dmitry Titov.

  • workers/GenericWorkerTask.h:
13:24 Changeset [59484] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Remove the ENABLE(WORKERS) guard from GenericWorkerTask.h and rename
all occurrences of GenericWorkerTask* to GenericTask* in this file.
https://bugs.webkit.org/show_bug.cgi?id=39129

Reviewed by Dmitry Titov.

I will have another patch to rename the file and move it to the right
place.

  • workers/GenericWorkerTask.h:

(WebCore::):
(WebCore::GenericTask1::create):
(WebCore::GenericTask1::GenericTask1):
(WebCore::GenericTask2::create):
(WebCore::GenericTask2::GenericTask2):
(WebCore::GenericTask3::create):
(WebCore::GenericTask3::GenericTask3):
(WebCore::GenericTask4::create):
(WebCore::GenericTask4::GenericTask4):
(WebCore::GenericTask5::create):
(WebCore::GenericTask5::GenericTask5):
(WebCore::GenericTask6::create):
(WebCore::GenericTask6::GenericTask6):
(WebCore::GenericTask7::create):
(WebCore::GenericTask7::GenericTask7):
(WebCore::GenericTask8::create):
(WebCore::GenericTask8::GenericTask8):
(WebCore::createCallbackTask):

13:16 Changeset [59483] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-14 Evan Martin <evan@chromium.org>

Reviewed by David Levin.

[chromium] don't call fontconfig twice in complex text path
https://bugs.webkit.org/show_bug.cgi?id=38701

Previously getFontDataForCharacters would call fontconfig once to
resolve a font name, then pass that name to getCachedFontPlatformData
to load the font. This would be two trips through fontconfig (including
IPCs). With this change, we completely load the font in the first pass.

This patch is actually the same code as in r58341, which was reverted
because of a performance problem; a performance improvement has now
been committed, and with that change in place this change improves
the Chromium intl2 page cycler performance by another 5%.

See also https://bugs.webkit.org/show_bug.cgi?id=37904 .

Test: fast/text/international/bold-bengali.html
(Was checked in as part of the first attempt at this change, continues
to pass after this change.)

  • platform/chromium/ChromiumBridge.h:
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
12:49 Changeset [59482] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Young Han Lee <joybro@company100.net>

Reviewed by Darin Adler.

Don't include RetainPtr.h unless PLATFORM(CF) is set.
The RetainPtr is only used for CF platform in this class.
https://bugs.webkit.org/show_bug.cgi?id=39043

No new tests, there is no new functionality.

  • platform/network/curl/ResourceHandleManager.cpp:
12:21 Changeset [59481] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

Build fix, we need to copy over the files in $(WebKitOutputDir)/include/JavaScriptCore/private before
WebCore builds. This is because we are building a couple WTF files in WebCore and JavaScriptCore.

Reviewed by Adam Roben.

  • WebCore.vcproj/WebCore.make:
12:18 Changeset [59480] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch rollout throws exception if bug is already open
https://bugs.webkit.org/show_bug.cgi?id=38803

This was caused by someone incorrectly wrapping the code. :p
I'm going to have to start demanding unit tests for wrapping changes...

I also fixed the code to be able to reopen bugs which were never confirmed.
Before it regressed, the code would just log in that case. Now it actually
will reopen the bug, but there is a FIXME about how the logic is a bit backwards.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
    • Yay testing!
11:59 Changeset [59479] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-05-14 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

Temporarily remove a few test cases that failed on leopard bot.
https://bugs.webkit.org/show_bug.cgi?id=33805

  • fast/canvas/webgl/texture-npot-expected.txt: Removed failed test cases.
  • fast/canvas/webgl/texture-npot.html: Ditto.
11:49 Changeset [59478] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-14 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium: update test expectations.

  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt:
09:55 Changeset [59477] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2010-05-14 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed. Attempt to fix chromium's memory bot error.

More :visited link optimizations to reduce memory usage
https://bugs.webkit.org/show_bug.cgi?id=39084

The original change (r59386) adds check for m_element in initElement.
As don't initialize m_element in the constructor of CSSStyleSelector,
valgrind complains.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):
09:33 Changeset [59476] by jorlow@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2010-05-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dimitri Glazkov.

Instead of rebaslining prototype-inheritance for Chromium, add indexedDB to its exceptions
https://bugs.webkit.org/show_bug.cgi?id=39122

The test has a way to name properties that shouldn't be tested (used when they're not enabled
by most ports). Use this feature rather than creating custom baselines.

  • fast/dom/script-tests/prototype-inheritance.js:
  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
09:03 Changeset [59475] by jorlow@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Rebaseline prototype-inheritance
https://bugs.webkit.org/show_bug.cgi?id=39116

IndexedDB is now turned on for Chromium's test shell. I'm not sure
if this is the correct behavior or not (can someone confirm which it is?)
but we should get this test running again so we can catch real regressions.
And, before taking this out from behind a flag, we should be sure to fix it.

  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Added.
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Added.
08:59 QtWebKitBugs edited by hausmann@webkit.org
(diff)
08:24 Changeset [59474] by hausmann@webkit.org
  • 5 edits
    3 copies
    2 deletes in trunk

.: [Qt] Rename QtLauncher to QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=37665

Rubber-stamped by Antti Koivisto.

  • WebKit.pro:

WebKitTools: [Qt] Rename QtLauncher to QtTestBrowser

Rubber-stamped by Antti Koivisto.

  • QtTestBrowser: Copied from WebKitTools/QtLauncher.
  • QtTestBrowser/QtLauncher.pro: Removed.
  • QtTestBrowser/QtLauncher.qrc: Removed.
  • QtTestBrowser/QtTestBrowser.pro: Copied from WebKitTools/QtLauncher/QtLauncher.pro.
  • QtTestBrowser/QtTestBrowser.qrc: Copied from WebKitTools/QtLauncher/QtLauncher.qrc.
  • Scripts/run-launcher:
  • Scripts/webkitdirs.pm:
08:12 QtWebKitTriageRoster edited by jesus@webkit.org
(diff)
08:11 QtWebKitBugs edited by jesus@webkit.org
(diff)
07:47 Changeset [59473] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

CSSParser::parseColor() shouldn't alter 'color' unless passed a valid color string.
https://bugs.webkit.org/show_bug.cgi?id=39031

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor):
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::extractTextStyles): Don't depend on old behavior.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): Remove dead code.
07:16 Changeset [59472] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Jens Alfke <snej@chromium.org>

Reviewed by John Sullivan.

Don't clear yellow autofill highlight from text fields until the user edits them.
https://bugs.webkit.org/show_bug.cgi?id=39032
No new tests (Couldn't find any autofill tests. The flag doesn't seem to be exposed to JS.)

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::handleFocusEvent): Don't clear the autofilled flag. (WebCore::HTMLInputElement::setValueFromRenderer): Clear the autofilled flag.
05:57 Changeset [59471] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, unskip passing tests.

[Qt] animations/dynamic-stylesheet-loading.html fails with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=37381

  • platform/qt/Skipped:
    • animations/simultaneous-start-left.html unskipped.
    • animations/dynamic-stylesheet-loading.html unskipped.
05:52 Changeset [59470] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-05-14 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must implement OpenGL ES 2.0 semantics for NPOT textures
https://bugs.webkit.org/show_bug.cgi?id=33805

  • fast/canvas/webgl/texture-npot-expected.txt: Added.
  • fast/canvas/webgl/texture-npot.html: Added.

2010-05-14 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Must implement OpenGL ES 2.0 semantics for NPOT textures
https://bugs.webkit.org/show_bug.cgi?id=33805

Test: fast/canvas/webgl/texture-npot.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Create black 1x1 textures. (WebCore::WebGLRenderingContext::bindTexture): Set texture dimensionality. (WebCore::WebGLRenderingContext::copyTexImage2D): Error check, set texture size. (WebCore::WebGLRenderingContext::drawArrays): Bind to black textures if needed. (WebCore::WebGLRenderingContext::drawElements): Bind to black textures if needed. (WebCore::WebGLRenderingContext::generateMipmap): Error check. (WebCore::WebGLRenderingContext::texImage2DBase): Error check, set texture size. (WebCore::WebGLRenderingContext::texParameterf): Set texture parameter. (WebCore::WebGLRenderingContext::texParameteri): Ditto. (WebCore::WebGLRenderingContext::handleNPOTTextures): Bind to black textures if needed before draw, and bind back to original textures after draw.
  • html/canvas/WebGLRenderingContext.h: Add black 1x1 textures.
  • html/canvas/WebGLTexture.cpp: Add support to track NPOT textures. (WebCore::WebGLTexture::createBlackTexture1x1): Create a black 1x1 texture. (WebCore::WebGLTexture::WebGLTexture): Initialize parameters and states. (WebCore::WebGLTexture::setDimensionality): Set dimensionality. (WebCore::WebGLTexture::setParameteri): Set parameter. (WebCore::WebGLTexture::setParameterf): Ditto. (WebCore::WebGLTexture::setSize): Set level 0 texture size. (WebCore::WebGLTexture::isNPOT): Whether the texture is NPOT. (WebCore::WebGLTexture::updateNPOTStates): Calculate NPOT and NeedToUseBlackTexture states.
  • html/canvas/WebGLTexture.h: Add support to track NPOT textures. (WebCore::WebGLTexture::isNPOT): (WebCore::WebGLTexture::needToUseBlackTexture):
05:39 Changeset [59469] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-14 Chao-ying Fu <fu@mips.com>

Reviewed by Oliver Hunt.

String Indexing Failure on JSVALUE32 targets
https://bugs.webkit.org/show_bug.cgi?id=39034

Remove zero-extend/shift-right code on regT1, because we already have
it in emit_op_get_by_val().

  • jit/JITPropertyAccess.cpp: (JSC::JIT::stringGetByValStubGenerator):
05:36 Changeset [59468] by pfeldman@chromium.org
  • 17 edits
    3 adds in trunk/WebCore

2010-05-14 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add help on keyboard shortcuts (take 2).

https://bugs.webkit.org/show_bug.cgi?id=38667

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype._placardSelected): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._registerShortcuts):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._keyDown):
  • inspector/front-end/HelpScreen.js: Added.
  • inspector/front-end/KeyboardShortcut.js:
  • inspector/front-end/ScriptsPanel.js:
05:32 QtWebKitTriageRoster edited by ossy@webkit.org
(diff)
05:28 Changeset [59467] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-05-14 Jochen Eisinger <jochen@chromium.org>

Reviewed by Eric Seidel.

Make ImageDiff depend on webkit (again).
https://bugs.webkit.org/show_bug.cgi?id=39000

  • WebKit.gyp:
05:16 Changeset [59466] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-05-14 James Simonsen <simonjam+webkit@google.com>

Reviewed by Darin Fisher.

[chromium] Expose volume through WebMediaPlayerClient
https://bugs.webkit.org/show_bug.cgi?id=38947

  • public/WebMediaPlayerClient.h:
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::volume):
  • src/WebMediaPlayerClientImpl.h:
05:03 QtWebKitJournal edited by hausmann@webkit.org
(diff)
04:55 Changeset [59465] by eric@webkit.org
  • 10 edits in trunk

2010-05-14 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

[chromium] Update chromium port to send/receive cached metadata
https://bugs.webkit.org/show_bug.cgi?id=38665

No new tests because no new functionality.

  • platform/chromium/ChromiumBridge.h:
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::responseTime): (WebCore::ResourceResponse::setResponseTime):

2010-05-14 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

[chromium] Update chromium port to send/receive cached metadata
https://bugs.webkit.org/show_bug.cgi?id=38665

  • public/WebKitClient.h: (WebKit::WebKitClient::cacheMetadata):
  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didReceiveCachedMetadata):
  • public/WebURLResponse.h:
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::cacheMetadata):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveCachedMetadata): (WebCore::ResourceHandle::cacheMetadata):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::responseTime): (WebKit::WebURLResponse::setResponseTime):
04:32 Changeset [59464] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Stop CCing webkit-bot-watchers
https://bugs.webkit.org/show_bug.cgi?id=39020

webkit-bot-watchers is somewhat of a failed experiment. No one
subscribed to the list (not even me). Removing it from the code
because wms says it bounces email sometimes.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
04:24 Changeset [59463] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

Fix a VS2010 assert in std::copy
https://bugs.webkit.org/show_bug.cgi?id=38630

Reviewed by Alexey Proskuryakov.

The assert complains that the output iterator is null.

  • wtf/Vector.h:

(WTF::::operator):

04:21 Changeset [59462] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-05-14 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

Chromium-specific fix to prevent zombie infobars.

https://bugs.webkit.org/show_bug.cgi?id=38948

  • bindings/v8/ScriptController.cpp (WebCore::ScriptController::processingUserGesture): Require a more definite "no" signal.
  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::fire): Use a very strong yes / no signal; no need for "possible" here.
  • dom/UserGestureIndicator.h:
  • dom/UserGestureIndicator.cpp: Adapt to tri-state: definitely yes; definitely no; not sure.
03:55 Changeset [59461] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION: webkit-patch commit-message throws exception
https://bugs.webkit.org/show_bug.cgi?id=38997

  • Scripts/webkitpy/tool/commands/upload.py:
    • Fix to respect and pass the --squash and --git-commit options.
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
    • Fix the unit test to use the central MockCheckout instead of its own custom Mock which didn't require enough parameters.
02:58 Changeset [59460] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

[Qt] JavaScript unable to invoke methods declared in QML
https://bugs.webkit.org/show_bug.cgi?id=38949

Patch by Aaron Kennedy <tffeeb@gmail.com> on 2010-05-14
Reviewed by Simon Hausmann.

JavaScript code executed by webkit cannot call into QML declared
methods, as it does not check for dynamic meta objects.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::stringValue): Use QMetaObject::metacall.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call): Ditto.

02:50 Changeset [59459] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 Ben Murdoch <benm@google.com>

Reviewed by Darin Fisher.

Touch events are disabled by default when using V8.
https://bugs.webkit.org/show_bug.cgi?id=38990

Touch events are protected by a compile time guard, so it's safe to
assume that the runtime flag should be enabled by default when this
guard is present.

No new tests, build fix for Android.

  • bindings/generic/RuntimeEnabledFeatures.cpp: enable touch events by default.
02:29 Changeset [59458] by mrowe@apple.com
  • 10 edits in branches/safari-533-branch

<rdar://problem/7677994> Disable WebGL

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

WebCore:

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

  • Scripts/build-webkit:
02:23 Changeset [59457] by jorlow@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-05-14 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Rebaseline storage/domstorage/quota.html
https://bugs.webkit.org/show_bug.cgi?id=38996

Chromium enforces quota on session storage and thus expects to "fail"
the first part of this test.

  • platform/chromium-mac/storage/domstorage/quota-expected.txt: Added.
  • platform/chromium-win/storage/domstorage/quota-expected.txt: Added.
02:14 Changeset [59456] by hausmann@webkit.org
  • 15 edits in trunk/WebKit/qt

[Qt] Merge overhaul of the QtWebKit API documentation

Patch by Kent Hansen <kent.hansen@nokia.com>, Jocelyn Turcotte <jocelyn.turcotte@nokia.com>, Tor Arne Vestbø <tor.arne.vestbo@nokia.com>, Henry Haverinen <henry.haverinen@nokia.com>, Jedrzej Nowacki <jedrzej.nowacki@nokia.com>, Andreas Kling <andreas.kling@nokia.com> on 2010-05-14
Reviewed by Simon Hausmann.

Numerous improvements in wording, qdoc warning fixes and
clarifications, done in a team work effort.

No functional changes.

  • Api/qwebdatabase.cpp:
  • Api/qwebelement.cpp:
  • Api/qwebframe.cpp:
  • Api/qwebhistoryinterface.cpp:
  • Api/qwebinspector.cpp:
  • Api/qwebkitversion.cpp:
  • Api/qwebpage.cpp:
  • Api/qwebpluginfactory.cpp:
  • Api/qwebsecurityorigin.cpp:
  • Api/qwebsettings.cpp:
  • Api/qwebsettings.h:
  • docs/qtwebkit.qdoc:
  • docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp:

(wrapInFunction):

  • docs/webkitsnippets/webelement/main.cpp:

(findButtonAndClick):
(autocomplete1):
(autocomplete2):
(main):

02:04 Changeset [59455] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Documentation: Fix overview grouping.

Patch by Martin Smith <msmith@trolltech.com> on 2010-05-14
Reviewed by Simon Hausmann.

  • docs/qtwebkit.qdoc:
01:49 Changeset [59454] by yurys@chromium.org
  • 7 edits
    2 adds in trunk/LayoutTests

2010-05-14 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium: update test expectations.

  • platform/chromium-linux/editing/deleting/5408255-expected.checksum:
  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt: Added.
  • platform/chromium-mac/editing/deleting/5408255-expected.checksum: Added.
  • platform/chromium-win/editing/deleting/5408255-expected.checksum:
  • platform/chromium-win/editing/deleting/5408255-expected.txt:
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
  • platform/chromium-win/editing/selection/4895428-1-expected.txt:
  • platform/chromium-win/editing/selection/4895428-4-expected.txt:
01:44 Changeset [59453] by eric@webkit.org
  • 2 edits in trunk/WebKit

2010-05-14 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by David Levin.

[EF] Include missing header.
http://webkit.org/b/38905

  • efl/ewk/ewk_main.cpp: Include PageGroup.h
01:43 Changeset [59452] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKitTools

Merge r59177.

01:32 Changeset [59451] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-14 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Laszlo Gombos.

[QT] Update the Symbian version for the user agent
https://bugs.webkit.org/show_bug.cgi?id=38389

Update the user agent for Symbian2 to Symbian4

  • Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
01:23 Changeset [59450] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Disable the Audits panel and Workers sidebar in the Web Inspector.

Patch by Timothy Hatcher <timothy@apple.com> on 2010-05-13
<rdar://problem/7947035>

Reviewed by Ada Chan.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel): Don't make a workers sidebar pane.
(WebInspector.ScriptsPanel.prototype.reset): Null check workers sidebar pane.

  • inspector/front-end/Settings.js: Set auditsPanelEnabled to false.
  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.didCreateWorker): Null check workers sidebar pane.
(WebInspector.didDestroyWorker): Ditto.

01:21 Changeset [59449] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-14 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

Implemented createJavaAppletWidget to activate Java applet support.

https://bugs.webkit.org/show_bug.cgi?id=33044

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
01:09 Changeset [59448] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-14 George Wright <gwright@rim.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=38909

Update JSDataGridColumnListCustom.cpp to call identifierToAtomicString()
on the property name.

  • bindings/js/JSDataGridColumnListCustom.cpp: (WebCore::JSDataGridColumnList::canGetItemsForName): (WebCore::JSDataGridColumnList::nameGetter):
00:43 Changeset [59447] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-05-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Add test to check that setting various CanvasRenderingContext2D properties
to invalid values is ignored.

https://bugs.webkit.org/show_bug.cgi?id=38841

  • fast/canvas/canvas-invalid-values-expected.txt: Added.
  • fast/canvas/canvas-invalid-values.html: Added.
  • fast/canvas/script-tests/canvas-invalid-values.js: Added. (trySettingMiterLimit): (trySettingLineWidth): (trySettingShadowBlur): (trySettingShadowOffsetX): (trySettingShadowOffsetY):

2010-05-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Ignore invalid values for various CanvasRenderingContext2D properties
(lineWidth, miterLimit, shadowOffsetX, shadowOffsetY and shadowBlur)

https://bugs.webkit.org/show_bug.cgi?id=38841

Test: fast/canvas/canvas-invalid-values.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setLineWidth): (WebCore::CanvasRenderingContext2D::setMiterLimit): (WebCore::CanvasRenderingContext2D::setShadowOffsetX): (WebCore::CanvasRenderingContext2D::setShadowOffsetY): (WebCore::CanvasRenderingContext2D::setShadowBlur):
00:08 Changeset [59446] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed, test expectation update.

deleted-host-in-resource-load-delegate-callback.html sometimes crashes on Windows Release.

Note: See TracTimeline for information about the timeline view.