Timeline


and

06/03/10:

23:35 Changeset [60658] by morrita@google.com
  • 5 edits in trunk/WebCore

2010-06-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Carlson.

Fix a crash when trying to use an invalid media src url by
moving the isValid url checks to a central location in
isSafeToLoadURL function. Also added an empty string check
in DocumentLoader::didTellClientAboutLoad.

Test: media/invalid-media-url-crash.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad):
23:16 Changeset [60657] by tkent@chromium.org
  • 6 edits
    2 adds in trunk

2010-06-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Carlson.

Tests that invalid media src url does not result in crash.

  • media/invalid-media-url-crash-expected.txt: Added.
  • media/invalid-media-url-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-06-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Carlson.

Fix a crash when trying to use an invalid media src url by
moving the isValid url checks to a central location in
isSafeToLoadURL function. Also added an empty string check
in DocumentLoader::didTellClientAboutLoad.

Test: media/invalid-media-url-crash.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad):
23:09 Changeset [60656] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-03 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Add dependencies required to link with VS Express 2005.
https://bugs.webkit.org/show_bug.cgi?id=40038

Visual Studio implicitly links against these libs.
VC++ Express does not.

  • WebKitAPITest/WebKitAPITestCommon.vsprops:
  • WinLauncher/WinLauncher.vcproj:
22:57 Changeset [60655] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-03 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

New states in QScriptValuePrivate.

The CSpecial state was divided into CNull and CUndefined. It simplify
the QScriptValue code by avoiding a few "cast" and "if".
Moreover the MSVS compiler didn't like casting between a double and an
enum which is avoided now.

[Qt] The QScriptValuePrivate::CSpecial is too generic.
https://bugs.webkit.org/show_bug.cgi?id=40067

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toObject): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::isNumberBased):
22:14 Changeset [60654] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
https://bugs.webkit.org/show_bug.cgi?id=40105

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • kill pywebsocket process when url is not alive and the process is not terminated, not to leave pywebsocket server running.
  • fix codecs.open parameters.
21:28 Changeset [60653] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Test expectation fix.

Skip fast/dom/Geolocation/callback-to-remote-context.html on GTK.
https://bugs.webkit.org/show_bug.cgi?id=40153

  • platform/gtk/Skipped:
21:22 Changeset [60652] by ukai@chromium.org
  • 5 edits in trunk

2010-06-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058

  • platform/mac-tiger/Skipped:
  • remove websocket/tests from skipped list.

2010-06-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058

  • Scripts/ensure-valid-python:
    • Perl 5.8 doesn't have File::Temp->newdir(). Use File::Temp->tempdir() instead.
    • Add --check-only and --help option.
    • --check-only option only checks python version and don't try to install Python 2.5.
    • Set executable bit.
  • Scripts/old-run-webkit-tests:
    • Check if it can run the websocket tests by calling ensure-valid-python --check-only.
18:57 Changeset [60651] by morrita@google.com
  • 4 edits in trunk/WebKit/chromium

2010-05-26 MORITA Hajime <morrita@google.com>

Reviewed by Jian Li.

[Chromium] Dragging over an element with scrollbars should scroll the element when dragging near edges
https://bugs.webkit.org/show_bug.cgi?id=39725

Added WebViewImpl::scrollForDragging() to handle scroll-on-drag.
Note that this change handes both source and destination cases.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragTargetDragEnterOrOver): (WebKit::WebViewImpl::scrollForDragging):
  • src/WebViewImpl.h:
18:44 Changeset [60650] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • wtf/Platform.h:

Reviewed by NOBODY (Qt build fix).

18:31 Changeset [60649] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60642.
http://trac.webkit.org/changeset/60642
https://bugs.webkit.org/show_bug.cgi?id=40151

Broke rendering of border images on rotated elements
(Requested by jamesr on #webkit).

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
18:18 Changeset [60648] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Add exceptions for some newly-passing tests in Chromium.

  • platform/chromium/test_expectations.txt:
17:45 Changeset [60647] by adachan@apple.com
  • 3 edits in trunk/WebKit2

Reviewed by Anders Carlsson.

Add UIProcess\API\cpp to the list of additional include directories.
Allow WKViewRef to work with WKRetainPtr on Windows.

  • UIProcess/API/cpp/WKRetainPtr.h:
  • win/WebKit2.vcproj:
17:34 Changeset [60646] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Bug 40150 - ENABLE_JIT_OPTIMIZE_NATIVE_CALL on all x86/x86_64 platforms
This was fixed in bug #40094.

Reviewed by Mark Rowe.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/Platform.h:
16:46 Changeset [60645] by steveblock@google.com
  • 1 edit
    5 adds in trunk/LayoutTests

2010-06-03 Steve Block <steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Geolocation needs LayoutTest to test making callbacks to remote frames
https://bugs.webkit.org/show_bug.cgi?id=40129

  • fast/dom/Geolocation/callback-to-remote-context-expected.txt: Added.
  • fast/dom/Geolocation/callback-to-remote-context.html: Added.
  • fast/dom/Geolocation/resources: Added.
  • fast/dom/Geolocation/resources/callback-to-remote-context-inner.html: Added.
  • fast/dom/Geolocation/script-tests/callback-to-remote-context.js: Added.
16:39 Changeset [60644] by jamesr@google.com
  • 1 edit
    18 adds in trunk/LayoutTests

2010-06-03 James Robinson <jamesr@chromium.org>

Unreviewed. Add chromium-specific baselines for new tests added by 60640

  • platform/chromium-linux/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
16:19 Changeset [60643] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-03 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

notifications: in display+close layout test, don't close the notification
until the display event has been received asynchronously; also don't use
an invalid icon URL, since that should generate an error event.
https://bugs.webkit.org/show_bug.cgi?id=39782

  • fast/notifications/notifications-display-close-events.html:
16:13 Changeset [60642] by kdecker@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Beth Dakin.

Pixel cracks in border images when drawing with a scale factor > 1
<rdar://problem/7994266>pixel cracks in border images
https://bugs.webkit.org/show_bug.cgi?id=15720


  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h: Added two new methods to support drawing using FloatRect. If the boolean flag roundToPixels is true, the pixels are adjusted with the pixel boundaries.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
15:49 Changeset [60641] by mrobinson@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60632.
http://trac.webkit.org/changeset/60632
https://bugs.webkit.org/show_bug.cgi?id=40143

This change broke the 64-bit bots. (Requested by mrobinson on
#webkit).

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::DragClient): (WebKit::DragClient::startDrag):
  • WebCoreSupport/DragClientGtk.h:
15:07 Changeset [60640] by jamesr@google.com
  • 3 edits
    18 adds in trunk

2010-06-03 James Robinson <jamesr@chromium.org>

Reviewed by Dan Bernstein.

Take container's scroll offset and clip into account when initializing LayoutState
https://bugs.webkit.org/show_bug.cgi?id=38506

When doing a subtree layout, the initial LayoutState creation needs to
take the layout root container's offset and its scroll offset into account
to create the initial offset. Otherwise if a subtree layout occurs
for a layout root whose container has a non-zero scroll offset
the LayoutState's offset and clip are wrong, resulting in a mispaint.
See the test cases for examples.

Tests: fast/repaint/layout-state-scrolloffset.html

fast/repaint/layout-state-scrolloffset2.html
fast/repaint/layout-state-scrolloffset3.html

  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):

2010-06-03 James Robinson <jamesr@chromium.org>

Reviewed by Dan Bernstein.


Tests repainting a layout subtree with scroll offsets
https://bugs.webkit.org/show_bug.cgi?id=38506


Has to be run as a pixel test to be useful.

  • layout-state-scrolloffset.html tests the layout root having a non-zero scroll offset.
  • layout-state-scrolloffset2.html tests the layout root and its container having

non-zero scroll offsets.

  • layout-state-scrolloffset3.html tests the layout root having non-zero a scroll offset

and clipping its descendants.

  • fast/repaint/layout-state-scrolloffset.html: Added.
  • fast/repaint/layout-state-scrolloffset2.html: Added.
  • fast/repaint/layout-state-scrolloffset3.html: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
14:45 Changeset [60639] by barraclough@apple.com
  • 3 edits in trunk/WebCore
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

Reviewed by NOBODY (speculative Qt build fix II).

14:36 Changeset [60638] by barraclough@apple.com
  • 2 edits in trunk/WebCore
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

Reviewed by NOBODY (speculative Qt build fix).

14:29 Changeset [60637] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

(JSC::Interpreter::privateExecute):

Reviewed by NOBODY (Interpreter build fix).

14:10 Changeset [60636] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix II).

13:49 Changeset [60635] by ojan@chromium.org
  • 14 edits in trunk/WebKitTools

2010-05-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
https://bugs.webkit.org/show_bug.cgi?id=38918

Patches with in-rietveld? get uploaded to rietveld and get marked
in-rietveld+. If the upload fails, they are marked in-rietveld-
and an error is logged to the bug, like the commit-queue.

Also, get rid of --fancy-review and the ability to upload to rietveld
using webkit-patch upload/post.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py:
13:48 Changeset [60634] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix).

13:20 Changeset [60633] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-24 Ojan Vafai <ojan@chromium.org>

Reviewed by Chris Jerdonek.

many webkit-patch commands fail in a non-svn tracking git checkout
https://bugs.webkit.org/show_bug.cgi?id=38156

If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
If neither exists, then error out. This makes webkit-patch work
for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
to checkout webkit. The fallback to master is for people who don't
do the steps on that page for tracking svn.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
13:08 Changeset [60632] by mrobinson@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Drag gesture can take mouse grab indefinitely
https://bugs.webkit.org/show_bug.cgi?id=32840

Start GTK+ drags with the previous mouse button down event instead of
synthesizing the event. The synthesized event was not completely valid
and froze some drags indefinitely.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::buttonPressEvent): Added. (WebKit::DragClient::DragClient): Connect to the 'button-press-event' signal of the WebView. (WebKit::DragClient::startDrag): Instead of synthesizing a button press event use the last real one.
  • WebCoreSupport/DragClientGtk.h: (WebKit::DragClient::setLastButtonPressEvent): Added.
13:00 Changeset [60631] by barraclough@apple.com
  • 71 edits in trunk

Bug 40094 - The return type of NativeFunction should be EncodedJSValue
On Windows & Linux, using JSVALUE32_64, EncodedJSValue is returned in registers, but JSValue is not.

Reviewed by Oliver Hunt.

JavaScriptCore:

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::call):

(JSC::Interpreter::executeCall):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • jsc.cpp:

(functionPrint):
(functionDebug):
(functionGC):
(functionVersion):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(functionSetSamplingFlags):
(functionClearSamplingFlags):
(functionReadline):
(functionQuit):

  • runtime/ArrayConstructor.cpp:

(JSC::callArrayConstructor):
(JSC::arrayConstructorIsArray):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

  • runtime/BooleanConstructor.cpp:

(JSC::callBooleanConstructor):

  • runtime/BooleanPrototype.cpp:

(JSC::booleanProtoFuncToString):
(JSC::booleanProtoFuncValueOf):

  • runtime/CallData.h:
  • runtime/DateConstructor.cpp:

(JSC::callDate):
(JSC::dateParse):
(JSC::dateNow):
(JSC::dateUTC):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::dateProtoFuncSetTime):
(JSC::dateProtoFuncSetMilliSeconds):
(JSC::dateProtoFuncSetUTCMilliseconds):
(JSC::dateProtoFuncSetSeconds):
(JSC::dateProtoFuncSetUTCSeconds):
(JSC::dateProtoFuncSetMinutes):
(JSC::dateProtoFuncSetUTCMinutes):
(JSC::dateProtoFuncSetHours):
(JSC::dateProtoFuncSetUTCHours):
(JSC::dateProtoFuncSetDate):
(JSC::dateProtoFuncSetUTCDate):
(JSC::dateProtoFuncSetMonth):
(JSC::dateProtoFuncSetUTCMonth):
(JSC::dateProtoFuncSetFullYear):
(JSC::dateProtoFuncSetUTCFullYear):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear):
(JSC::dateProtoFuncToJSON):

  • runtime/ErrorConstructor.cpp:

(JSC::callErrorConstructor):

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

  • runtime/FunctionConstructor.cpp:

(JSC::callFunctionConstructor):

  • runtime/FunctionPrototype.cpp:

(JSC::callFunctionPrototype):
(JSC::functionProtoFuncToString):
(JSC::functionProtoFuncApply):
(JSC::functionProtoFuncCall):

  • runtime/JSCell.h:

(JSC::getCallData):
(JSC::getConstructData):

  • runtime/JSFunction.cpp:

(JSC::callHostFunctionAsConstructor):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncIsNaN):
(JSC::globalFuncIsFinite):
(JSC::globalFuncDecodeURI):
(JSC::globalFuncDecodeURIComponent):
(JSC::globalFuncEncodeURI):
(JSC::globalFuncEncodeURIComponent):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
(JSC::globalFuncJSCPrint):

  • runtime/JSGlobalObjectFunctions.h:
  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):

  • runtime/JSObject.cpp:

(JSC::callDefaultValueFunction):

  • runtime/JSValue.h:
  • runtime/MathObject.cpp:

(JSC::mathProtoFuncAbs):
(JSC::mathProtoFuncACos):
(JSC::mathProtoFuncASin):
(JSC::mathProtoFuncATan):
(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncCeil):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncExp):
(JSC::mathProtoFuncFloor):
(JSC::mathProtoFuncLog):
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
(JSC::mathProtoFuncPow):
(JSC::mathProtoFuncRandom):
(JSC::mathProtoFuncRound):
(JSC::mathProtoFuncSin):
(JSC::mathProtoFuncSqrt):
(JSC::mathProtoFuncTan):

  • runtime/NativeErrorConstructor.cpp:

(JSC::callNativeErrorConstructor):

  • runtime/NumberConstructor.cpp:

(JSC::callNumberConstructor):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString):
(JSC::numberProtoFuncValueOf):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToPrecision):

  • runtime/ObjectConstructor.cpp:

(JSC::callObjectConstructor):
(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncValueOf):
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncIsPrototypeOf):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncPropertyIsEnumerable):
(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:

(JSC::callRegExpConstructor):

  • runtime/RegExpObject.cpp:

(JSC::callRegExpObject):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):

  • runtime/StringConstructor.cpp:

(JSC::stringFromCharCode):
(JSC::callStringConstructor):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToString):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncConcat):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::stringProtoFuncTrim):
(JSC::stringProtoFuncTrimLeft):
(JSC::stringProtoFuncTrimRight):

JavaScriptGlue:

  • JSObject.cpp:

(nativeCallFunction):

WebCore:

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::open):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::createInjectedScript):

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::callNodeList):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::callPlugin):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::executeFunctionInContext):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializingTreeWalker::convertIfTerminal):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:

(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Construct):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::callObjCFallbackObject):

  • bridge/runtime_method.cpp:

(JSC::callRuntimeMethod):

  • bridge/runtime_object.cpp:

(JSC::Bindings::callRuntimeObject):

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):

11:59 HackingGtk edited by mrobinson@webkit.org
(diff)
11:56 HackingGtk edited by mrobinson@webkit.org
(diff)
11:38 HackingGtk edited by mrobinson@webkit.org
Update source module locations and put the directory first (diff)
10:34 Changeset [60630] by yael.aharon@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Don't send notifications event after the page was navigated away
https://bugs.webkit.org/show_bug.cgi?id=40127

Reviewed by Laszlo Gombos.

Added a check before sending events to the notification and before logging.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::sendEvent):

10:33 Changeset [60629] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

10:30 Changeset [60628] by mrowe@apple.com
  • 1 copy in tags/Safari-533.16

New tag.

10:30 Changeset [60627] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59498.

09:42 Changeset [60626] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

fast/events/transformaction removed from expectations,
because these tests were rolled-out by r60624.

Rubber-stamped by Simon Hausmann.

  • platform/chromium/test_expectations.txt:
09:29 Changeset [60625] by ossy@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, rolling out r60617.
http://trac.webkit.org/changeset/60617
https://bugs.webkit.org/show_bug.cgi?id=40124

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-06-03
Followup patch for rolled-out r60614 (Requested by Ossy on
#webkit).

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
09:25 Changeset [60624] by ossy@webkit.org
  • 31 edits
    6 deletes in trunk

Unreviewed, rolling out r60614.
http://trac.webkit.org/changeset/60614
https://bugs.webkit.org/show_bug.cgi?id=40123

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-06-03
It made fast/dom/Window/window-postmessage-clone.html fail on
Mac bots (Requested by Ossy on #webkit).

WebCore:

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • dom/Document.cpp:

(WebCore::Document::createEvent):
(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:

(WebCore::Document::):

  • dom/Document.idl:
  • dom/Element.h:
  • dom/Element.idl:
  • dom/Event.cpp:

(WebCore::Event::fromUserGesture):

  • dom/Event.h:
  • dom/EventNames.h:
  • dom/TransformActionEvent.cpp: Removed.
  • dom/TransformActionEvent.h: Removed.
  • dom/TransformActionEvent.idl: Removed.
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/events/transformaction/create-transformaction-event-expected.txt: Removed.
  • fast/events/transformaction/create-transformaction-event.html: Removed.
  • fast/events/transformaction/resources/create-transformaction-event.js: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
09:03 Changeset [60623] by yurys@chromium.org
  • 4 edits in trunk

2010-06-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: show "Object" as description for values with anonymous constructor
https://bugs.webkit.org/show_bug.cgi?id=40121

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

2010-06-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: show "Object" as description for values with anonymous constructor
https://bugs.webkit.org/show_bug.cgi?id=40121

  • src/js/DevTools.js: don't call DebuggerAgent methods if ScriptDebugServer is used.
08:56 Changeset [60622] by dglazkov@chromium.org
  • 2 edits in trunk/WebKit/chromium

[DRT/Chromium] Checking out lighttpd
https://bugs.webkit.org/show_bug.cgi?id=39948

Patch by Kent Tamura <tkent@chromium.org> on 2010-06-03
Reviewed by Dimitri Glazkov.

  • Add lighttpd only on Windows. It is used by new-run-webkit-tests.
  • Add libvpx.
  • Remove pthreads-win32 from DEPS. It has not been used since Chromium r28642.
  • Update Chromium revision to use Windows resource query code and webkit_glue dependency fix.
  • DEPS:
06:38 Changeset [60621] by vestbo@webkit.org
  • 4 edits
    1 move in trunk/WebCore

[Qt] Fix NPAPI support on Mac OS X/Cocoa-32

Reviewed by Simon Hausmann.

qt_mac_window_for() returns a NSWindow on Cocoa, so we were
passing in a NSWindow instead of a WindowRef as part of the
NP_CGContext.

https://bugs.webkit.org/show_bug.cgi?id=38762

  • WebCore.gypi: Reflect rename
  • WebCore.pro: Reflect rename
  • plugins/mac/PluginViewMac.cpp: Renamed to PluginViewMac.mm

and fix bug by getting the Carbon windowRef from the NSWindow.

  • wscript: Reflect rename
06:02 Changeset [60620] by mike.fenton@torchmobile.com
  • 2 edits in trunk/WebKitTools

2010-06-03 Mike Fenton <mifenton@rim.com>

Unreviewed.

Reverse e-mail for myself in committers.py to correspond with bugzilla account.

  • Scripts/webkitpy/common/config/committers.py:
04:11 Changeset [60619] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Test expectation update.

  • platform/chromium/test_expectations.txt: Restore Mac expectation of fixed-move-after-keyboard-scroll.html.
03:04 Changeset [60618] by pfeldman@chromium.org
  • 6 edits in trunk

2010-06-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: a number of fixes that make InspectorController
happy with null redirects.

https://bugs.webkit.org/show_bug.cgi?id=40109

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):

2010-06-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: a number of fixes that make InspectorController
happy with null redirects.

https://bugs.webkit.org/show_bug.cgi?id=40109

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest):
  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
02:58 Changeset [60617] by hausmann@webkit.org
  • 5 edits in trunk/LayoutTests

Not reviewed: Add TransformActionEvent to the window object tests, after r60614.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
02:37 Changeset [60616] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Test expectation update.

Rebaseline fixed-move-after-keyboard-scroll for Chromium-Linux
https://bugs.webkit.org/show_bug.cgi?id=40101

  • platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
02:24 Changeset [60615] by tkent@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed. Test expectation update.

Rebaseline fixed-move-after-keyboard-scroll, and add an entry for
fast/events/transformaction.
https://bugs.webkit.org/show_bug.cgi?id=40101

  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium/test_expectations.txt:
01:38 Changeset [60614] by hausmann@webkit.org
  • 31 edits
    8 adds in trunk

Add TransformActionEvent support
https://bugs.webkit.org/show_bug.cgi?id=39757

Patch by Kim Grönholm <kim.1.gronholm@nokia.com> on 2010-06-03
Reviewed by Simon Hausmann.

WebCore:

Added only the necessary TransformAction event interfaces and not e.g.
any eventhandler hooks that generate and dispatch them.

Test: fast/events/transformaction/create-transformaction-event.html
More tests will be added with the machinery that generates and
dispatches these events.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::transformactionEnabled):
(WebCore::RuntimeEnabledFeatures::setTransformActionEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionstartEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionupdateEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionendEnabled):

  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • dom/Document.cpp:

(WebCore::Document::createEvent):
(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:

(WebCore::Document::):

  • dom/Document.idl:
  • dom/Element.h:
  • dom/Element.idl:
  • dom/Event.cpp:

(WebCore::Event::isTransformActionEvent):
(WebCore::Event::fromUserGesture):

  • dom/Event.h:
  • dom/EventNames.h:
  • dom/TransformActionEvent.cpp: Added.

(WebCore::TransformActionEvent::TransformActionEvent):
(WebCore::TransformActionEvent::initTransformActionEvent):

  • dom/TransformActionEvent.h: Added.

(WebCore::TransformActionEvent::create):
(WebCore::TransformActionEvent::translateX):
(WebCore::TransformActionEvent::translateY):
(WebCore::TransformActionEvent::translateSpeedX):
(WebCore::TransformActionEvent::translateSpeedY):
(WebCore::TransformActionEvent::scale):
(WebCore::TransformActionEvent::scaleSpeed):
(WebCore::TransformActionEvent::rotate):
(WebCore::TransformActionEvent::rotateSpeed):
(WebCore::TransformActionEvent::TransformActionEvent):
(WebCore::TransformActionEvent::isTransformActionEvent):

  • dom/TransformActionEvent.idl: Added.
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/events/transformaction/create-transformaction-event-expected.txt: Added.
  • fast/events/transformaction/create-transformaction-event.html: Added.
  • fast/events/transformaction/resources/create-transformaction-event.js: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
01:21 Changeset [60613] by pfeldman@chromium.org
  • 19 edits in trunk/LayoutTests

2010-06-03 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Rebaseline chromium tests as a follow up to r60611.

https://bugs.webkit.org/show_bug.cgi?id=37364

  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.png:
  • platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
00:52 Changeset [60612] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation update.

4 websocket tests don't fail now.

  • platform/chromium/test_expectations.txt:
  • remove websocket/tests/unicode.html, websocket/tests/send.html, websocket/tests/handshake-error.html and websocket/tests/long-invalid-header.html
00:22 Changeset [60611] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-06-03 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out aggressive cache part of the r60391
described in the bug below. It was orthogonal to the rest of
the patch and caused regression.

https://bugs.webkit.org/show_bug.cgi?id=37364

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::drawResampledBitmap):
00:07 Changeset [60610] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-02 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] refactor WebKit.gyp's DRT section so the conditions are less messy
https://bugs.webkit.org/show_bug.cgi?id=40104

  • WebKit.gyp:
00:03 Changeset [60609] by eric@webkit.org
  • 6 edits in trunk

2010-06-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Shinichiro Hamaji.

[Qt] Fix compilation with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=38324

  • Api/qwebpage.cpp: (QWebPage::event):
  • Api/qwebpage_p.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):

2010-06-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Shinichiro Hamaji.

[Qt] Fix compilation with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=38324

  • QtTestBrowser/main.cpp: (LauncherWindow::init):

06/02/10:

22:38 Changeset [60608] by eric@webkit.org
  • 5 edits
    9 adds in trunk

2010-06-02 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

location.href and outgoing referrer not updated properly by
pushState/replaceState
https://bugs.webkit.org/show_bug.cgi?id=40027

  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html: Updated this test to account for location being modified by replaceState.
  • fast/loader/stateobjects/pushstate-updates-location-expected.txt: Added.
  • fast/loader/stateobjects/pushstate-updates-location.html: Added.
  • fast/loader/stateobjects/replacestate-updates-location-expected.txt: Added.
  • fast/loader/stateobjects/replacestate-updates-location.html: Added.
  • http/tests/navigation/pushstate-updates-referrer-expected.txt: Added.
  • http/tests/navigation/pushstate-updates-referrer.html: Added.
  • http/tests/navigation/replacestate-updates-referrer-expected.txt: Added.
  • http/tests/navigation/replacestate-updates-referrer.html: Added.
  • http/tests/navigation/resources/check-referrer.html: Added.

2010-06-02 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

location.href and outgoing referrer not updated properly by
pushState/replaceState
https://bugs.webkit.org/show_bug.cgi?id=40027

Tests: fast/loader/stateobjects/pushstate-updates-location.html

fast/loader/stateobjects/replacestate-updates-location.html
http/tests/navigation/pushstate-updates-referrer.html
http/tests/navigation/replacestate-updates-referrer.html

  • dom/Document.cpp: (WebCore::Document::updateURLForPushOrReplaceState): Update the FrameLoader's notion of the current URL as well!
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): Use the 'url' parameter instead of m_URL since m_URL might have changed during the handling of the PopState event. Eventually, this will become irrelevant since the PopState event should be dispatched asynchronously, but just in case we patch HashChange to be asynchronous before PopState, this change would be needed.
22:25 Changeset [60607] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-02 Tony Chang <tony@chromium.org>

Not reviewed, build fix in downstream chromium.

Fix the path to repack.py so it works in a chromium checkout too.

  • WebKit.gyp:
22:25 Changeset [60606] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(60409): document.write is not synchronous when using the HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40047

The HTML5 spec states that we should "spin the event loop" while
waiting for stylesheets to load. Currently we do that by yielding
out of the parser when stylesheets are loading. Because it was easy
we made inline <scripts> yield for stylesheet loads as well. However,
this caused document.write() to return after encountering the first
inline <script> tag in many cases which is incorrect. document.write
is supposed to block until the entire document is parsed (including)
executing inline script tags. To match the exiting parser, we'll just
make inline <script> tags not block on stylesheets for now.

This is tested by WebCore/benchmarks/html-parser.html as well
as likely several other tests in LayoutTests which we haven't
triaged yet.

  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::executeScript):
    • ASSERT that either stylesheets have loaded or we're executing an inline <script> tag.

(WebCore::HTML5ScriptRunner::runScript):

  • Remove the code to block inline <script> tags on stylesheet loads.
22:00 Changeset [60605] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-06-02 MORITA Hajime <morrita@google.com>

Unreviewd, Chromium windows build fix.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintProgressBar):
21:45 Changeset [60604] by morrita@google.com
  • 4 edits in trunk/WebCore

2010-06-02 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Support HTML5 <progress> element on Linux.
https://bugs.webkit.org/show_bug.cgi?id=37310

Implemented RenderThemeChromiumSkia::paintProgressBar(), extracing
determinateProgressValueRectFor() from RenderThemeChromiumWin to
RenderThemeChromiumSkia

No new tests. Expectations will come after ENABLE_PROGRESS_BAR get
enabled on chromium.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::determinateProgressValueRectFor): (WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor): (WebCore::RenderThemeChromiumSkia::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeChromiumSkia::animationDurationForProgressBar): (WebCore::RenderThemeChromiumSkia::paintProgressBar): (WebCore::RenderThemeChromiumSkia::progressValueRectFor):
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintProgressBar):
21:40 Changeset [60603] by mrowe@apple.com
  • 2 edits in tags/Safari-534.0.1/JavaScriptCore

Merge r60595.

21:40 Changeset [60602] by mrowe@apple.com
  • 5 edits in tags/Safari-534.0.1

Versioning.

21:32 Changeset [60601] by mrowe@apple.com
  • 1 copy in tags/Safari-534.0.1

New tag.

21:28 Changeset [60600] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Test expectation update.

  • platform/qt/Skipped: Add editing/input/page-up-down-scrolls.html
21:21 Changeset [60599] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Fix a tes_expectation error.

21:10 Changeset [60598] by barraclough@apple.com
  • 4 edits
    3 adds in trunk/JavaScriptCore

Add value-representation specific sections to the mac export file.

Patch by Mark Rowe <mrowe@apple.com> on 2010-06-02
Reviewed by Gavin Barraclough.

20:36 Changeset [60597] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation update.

Add fixed-move-after-keyboard-scroll.html temporarily
https://bugs.webkit.org/show_bug.cgi?id=40101

  • platform/chromium/test_expectations.txt:
20:22 Changeset [60596] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-02 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] generate DumpRenderTree.pak on DRT linux
https://bugs.webkit.org/show_bug.cgi?id=40098

  • WebKit.gyp:
20:15 Changeset [60595] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/8054988> Work around an LLVM GCC code generation bug that results in crashes inside PCRE.

Reviewed by Gavin Barraclough.

  • pcre/pcre_exec.cpp:

(repeatInformationFromInstructionOffset): Change the type of instructionOffset to int. There's no good
reason for it to be a short, and using int prevents this code from triggering the LLVM GCC bug.

19:53 Changeset [60594] by tony@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60592.
http://trac.webkit.org/changeset/60592
https://bugs.webkit.org/show_bug.cgi?id=40099

broke the build, need to coordiate updating DEPS (Requested by
tonywork on #webkit).

  • DEPS:
  • public/WebMediaPlayer.h:
19:37 Changeset [60593] by eric@webkit.org
  • 5 edits in trunk/WebKit/qt

2010-06-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Shared platform plugin
https://bugs.webkit.org/show_bug.cgi?id=39968

Allow several instances of class QtPlatformPlugin to share the QWebKitPlatformPlugin
object provided by a plugin.

Updated plugin interface version number due to ABI breaking change.

  • Api/qwebkitplatformplugin.h: (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::load): (WebCore::QtPlatformPlugin::~QtPlatformPlugin): (WebCore::QtPlatformPlugin::plugin):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
19:23 Changeset [60592] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-06-02 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

Modifying the WebMediaPlayer interface to be compatible with
a change in chrome.
This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
has been updated, so this commit should NOT break chromium anymore.
https://bugs.webkit.org/show_bug.cgi?id=39445

  • DEPS: Updated to a newer chrome revision number.
  • public/WebMediaPlayer.h: Changed buffered() to be non-const.
19:10 Changeset [60591] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-06-02 Nico Weber <thakis@chromium.org>

Reviewed by Simon Fraser.

Scroll events are sent twice per keypress for ports that don't have a platformWidget scrollbar.

This was regressed by http://trac.webkit.org/changeset/58615 . Fix this by slightly tweaking
that patch, add a layout test.

https://bugs.webkit.org/show_bug.cgi?id=39918

  • editing/input/page-up-down-scrolls-expected.txt: Added.
  • editing/input/page-up-down-scrolls.html: Added.

2010-06-02 Nico Weber <thakis@chromium.org>

Reviewed by Simon Fraser.

Scroll events are sent twice per keypress for ports that don't have a platformWidget scrollbar
https://bugs.webkit.org/show_bug.cgi?id=39918

This was regressed by http://trac.webkit.org/changeset/58615 . Fix this by slightly tweaking
that patch.

Test: editing/input/page-up-down-scrolls.html

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::valueChanged):
  • platform/ScrollView.h: (WebCore::ScrollView::repaintFixedElementsAfterScrolling):
19:00 Changeset [60590] by pkasting@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed, emergency fix for test crashes (verbal r+ beforehand from
John Gregg).

Temporarily make notificationObjectDestroyed() a no-op to avoid an
ASSERT failure.

https://bugs.webkit.org/show_bug.cgi?id=40097

  • src/NotificationPresenterImpl.cpp:

(WebKit::NotificationPresenterImpl::notificationObjectDestroyed):

18:54 Changeset [60589] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-02 Raine Makelainen <raine.makelainen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] On Maemo6 platform auto upper case and predictive text input method hints are not disabled for password field.
https://bugs.webkit.org/show_bug.cgi?id=40062

Introducing Q_WS_MAEMO_6 for Maemo6 specific code. Enabling code that sets input
method hints Qt::ImhNoAutoUppercase and Qt::ImhNoPredictiveText true for Maemo6.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
18:35 Changeset [60588] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/Cone.cpp

Fix build

18:35 Changeset [60587] by crogers@google.com
  • 1 edit
    2 adds in branches/audio/WebCore

For performance/debugging purposes add PerformanceTimer class (mac-only)

  • also fixed WebCore xcode project path problems
18:33 Changeset [60586] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-06-02 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make possible run DRT with QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=40016

Make possible to use a environment variable for switching backend.
Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebViewGraphicsBased::WebViewGraphicsBased): (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::setGraphicsBased): (WebCore::DumpRenderTree::isGraphicsBased): (WebCore::WebViewGraphicsBased::graphicsView): (WebCore::WebViewGraphicsBased::setPage):
  • Scripts/old-run-webkit-tests:
18:19 Changeset [60585] by eric@webkit.org
  • 5 edits
    1 add in trunk/JavaScriptCore

2010-06-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix the QScriptValue::strictlyEquals function.

Handling for a few edge cases was added.

New autotest that covers the QScriptValue::strictlyEquals function.

[Qt] QScriptValue::strictlyEquals is broken
https://bugs.webkit.org/show_bug.cgi?id=36600

  • qt/api/qscriptvalue.cpp: (QScriptValue::strictlyEquals):
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::strictlyEquals):
  • qt/tests/qscriptvalue/qscriptvalue.pro:
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: Added. (tst_QScriptValue::strictlyEquals_initData): (tst_QScriptValue::strictlyEquals_makeData): (tst_QScriptValue::strictlyEquals_test):
18:05 Changeset [60584] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-02 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use platform-specific key designations in shortcuts help for mac
https://bugs.webkit.org/show_bug.cgi?id=39158

  • inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut.shortcutToString): (WebInspector.KeyboardShortcut._keyName): (WebInspector.KeyboardShortcut._modifiersToString):
  • inspector/front-end/inspector.js: (WebInspector._registerShortcuts):
17:27 Changeset [60583] by eric@webkit.org
  • 6 edits in trunk/JavaScriptCore

2010-06-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

New function QScriptEngine::newObject.

The function creates a object of class Object and returns it
as a QScriptValue.

[Qt] QScriptEngine API should contain a newObject function
https://bugs.webkit.org/show_bug.cgi?id=39114

  • qt/api/qscriptengine.cpp: (QScriptEngine::newObject):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::newObject):
  • qt/api/qscriptengine_p.h:
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::newObject):
16:57 Changeset [60582] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-06-02 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Enable WebGL on more platforms even if accelerated compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=40085

Conditionalize the code which prevents a WebGL rendering context
from being created if accelerated compositing is disabled.
Currently Chromium is the only port which will create a context if
accelerated compositing is disabled; other ports may opt in to
this code path if desired.

Tested with existing WebGL layout tests in Safari and Chromium on
Mac OS X.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext):
16:41 Changeset [60581] by eric@webkit.org
  • 3 edits
    3 deletes in trunk

2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60580.
http://trac.webkit.org/changeset/60580
https://bugs.webkit.org/show_bug.cgi?id=40087

This broke dragging links if the selection was in a
contentEditable element. (Requested by arv on #webkit).

  • editing/selection/click-in-focusable-link-should-not-clear-selection-expected.txt: Removed.
  • editing/selection/click-in-focusable-link-should-not-clear-selection.html: Removed.
  • editing/selection/script-tests/click-in-focusable-link-should-not-clear-selection.js: Removed.

2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60580.
http://trac.webkit.org/changeset/60580
https://bugs.webkit.org/show_bug.cgi?id=40087

This broke dragging links if the selection was in a
contentEditable element. (Requested by arv on #webkit).

  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded):
14:38 Changeset [60580] by arv@chromium.org
  • 3 edits
    3 adds in trunk

2010-06-02 Erik Arvidsson <arv@chromium.org>

Reviewed by ojan@chromium.org.

REGRESSION: Weird focus behavior affects quoting on University of Washington message board system
https://bugs.webkit.org/show_bug.cgi?id=38548

  • editing/selection/click-in-focusable-link-should-not-clear-selection-expected.txt: Added.
  • editing/selection/click-in-focusable-link-should-not-clear-selection.html: Added.
  • editing/selection/script-tests/click-in-focusable-link-should-not-clear-selection.js: Added. (description.getElementCenter): (doubleClickOnElement): (mouseDownOnElement): (selectionShouldBe):

2010-06-02 Erik Arvidsson <arv@chromium.org>

Reviewed by ojan@chromium.org.

REGRESSION: Weird focus behavior affects quoting on University of Washington message board system
https://bugs.webkit.org/show_bug.cgi?id=38548

Test: editing/selection/click-in-focusable-link-should-not-clear-selection.html

  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded):
14:33 Changeset [60579] by crogers@google.com
  • 7 edits
    8 adds in branches/audio/WebCore

windows build changes to get us compiling and linking (courtesy of Ian Lewis)

14:19 Changeset [60578] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed, layout test fix.

Web Inspector: disable resource tracking on exiting the inspector layout test.
This is a short-term fix while I am working on making sure DRT disables it
automatically on the test exit.

https://bugs.webkit.org/show_bug.cgi?id=40083

  • http/tests/inspector/resource-parameters.html:
13:56 Changeset [60577] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=40011

Reviewed by Gavin Barraclough.

Thumb-2 build fix: The offset parameter of ldrh should be encoded as an
imm12 immediate constant in load16. If it is not fit in the instruction
a temporary register has to be used.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load16):

13:44 Changeset [60576] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Eric Seidel <eric@webkit.org>

Unreviewed. Just reverting part of r60556 as requested by Dave Hyatt on webkit-commits@list.webkit.org.

Several layout tests needlessly use invalid HTML
https://bugs.webkit.org/show_bug.cgi?id=39985

css1/box_properties/float_elements_in_series.html
remains invalid HTML, but we can't change it because
css1/ is meant to be a pristine copy of the CSS1 test suite.

  • css1/box_properties/float_elements_in_series.html:
    • Revert changes to this test. Dave Hyatt points out that although undocumented, this directory is meant to contain a pristine copy of the CSS1 test suite. It really should be documented and/or moved somewhere special, but for now we'll just revert the changes.
13:41 Changeset [60575] by ossy@webkit.org
  • 3 edits in trunk/WebKitTools

Slave lost shouldn't be recognized as build failed.
https://bugs.webkit.org/show_bug.cgi?id=39282

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
  • Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
13:11 Changeset [60574] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Just disable the current version of multi-column layout completely when the new
pagination model is in effect.

Reviewed by Anders Carlsson.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::setDesiredColumnCountAndWidth):

12:37 Changeset [60573] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: added new inspector test to Skipped in Tiger for
its loader not reporting the resource size right.

https://bugs.webkit.org/show_bug.cgi?id=40049

  • platform/mac-tiger/Skipped:
12:28 Changeset [60572] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Turn off unforced page breaking at paint time when the new page breaking model is being used.

Reviewed by Anders Carlsson.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

12:20 Changeset [60571] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Don't check page break properties at paint time if we're using the new page breaking model.

Reviewed by Anders Carlsson.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):

11:24 Changeset [60570] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2010-06-02 Nate Chapin <japhet@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix an infinite recursion crash when trying to wrap
media elements without a media player.

No test because there isn't a good way to ensure the media player
is off.

  • dom/make_names.pl: Call, e.g., V8HTMLElement::wrap(HTMLElement*) instead of toV8(HTMLElement*).
10:14 Changeset [60569] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

Notification object ref counting is not correct.
https://bugs.webkit.org/show_bug.cgi?id=39998

Reviewed by Darin Adler.

Return PassRefPtr<Notification> instead of a raw pointer from the create methods
for Web Notifications.

No new tests are needed, as existing tests show the problem when sending the
"display" event asynchronously.

  • notifications/Notification.h:

(WebCore::Notification::create):

  • notifications/NotificationCenter.h:

(WebCore::NotificationCenter::createHTMLNotification):
(WebCore::NotificationCenter::createNotification):

09:21 Changeset [60568] by mnaganov@chromium.org
  • 21 edits
    3 copies in trunk

2010-06-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yuri Semikhatsky.

Web Inspector: add Console API for retrieving memory stats

Add 'console.memory' property which returns an object. Currently
it has two fields: totalJSHeapSize and usedJSHeapSize. Later, it can be
extended for reporting total browser's memory consumption.

https://bugs.webkit.org/show_bug.cgi?id=39646

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::memory):
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::memoryAccessorGetter):
  • page/Console.h:
  • page/Console.idl:
  • page/MemoryInfo.cpp: Added. (WebCore::MemoryInfo::MemoryInfo):
  • page/MemoryInfo.h: Added. (WebCore::MemoryInfo::create): (WebCore::MemoryInfo::totalJSHeapSize): (WebCore::MemoryInfo::usedJSHeapSize):
  • page/MemoryInfo.idl: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
08:20 Changeset [60567] by yurys@chromium.org
  • 7 edits in trunk/WebCore

2010-06-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: support "Continue to Here" in debugger
https://bugs.webkit.org/show_bug.cgi?id=39953

  • English.lproj/localizedStrings.js:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setOneTimeBreakpoint): (WebInspector.BreakpointManager.prototype.removeOneTimeBreakpoint): (WebInspector.BreakpointManager.prototype.addBreakpoint):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype._continueToLine):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.continueToLine): (WebInspector.ScriptsPanel.prototype.debuggerPaused):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype._continueToLine): (WebInspector.SourceView.prototype.updateLocalContent):
07:31 Changeset [60566] by yael.aharon@nokia.com
  • 12 edits in trunk

[Qt] Fix the lifecycle of notification objects
https://bugs.webkit.org/show_bug.cgi?id=40003

Reviewed by Kenneth Rohde Christiansen.

WebKit/qt:

Notification objects are not tightly related to the page that created them,
and should be decoupled from the page.
Create one NotificationPresenter that handles all notifications.
Add ref/deref to the notification objects when they are added/removed from
the queue of active notifications. The same technique is used for XMLHttpRequest.
Instead of deleting all notifications associated with a page when the page is navigated,
delete them on a timer, using the same timeout that QSystemTrayIcon is using.
Break up the show() method into smaller methods.
Use OwnPtr instead of raw pointer for QSystemTrayIcon.
Move creating the QIcon to just before showing it in the QSyetemTrayIcon.

No new tests as this is just a refactoring. Existing notifications test cover the code.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::~QWebPagePrivate):

  • Api/qwebpage_p.h:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::notificationPresenter):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setNotificationsReceiver):
(DumpRenderTreeSupportQt::allowNotificationForOrigin):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::notificationPresenter):
(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::~NotificationIconWrapper):
(WebCore::NotificationIconWrapper::close):
(WebCore::NotificationPresenterClientQt::NotificationPresenterClientQt):
(WebCore::NotificationPresenterClientQt::removeClient):
(WebCore::NotificationPresenterClientQt::show):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationObjectDestroyed):
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::sendEvent):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore::NotificationPresenterClientQt::addClient):

WebKitTools:

Remove the dependency of notifications on QWebPage.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::requestPermissionCallback):
(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::requestPermission):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:
07:30 Changeset [60565] by mnaganov@chromium.org
  • 18 edits
    3 deletes in trunk

2010-06-02 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed, rolling out r60563.
http://trac.webkit.org/changeset/60563
https://bugs.webkit.org/show_bug.cgi?id=39646

windows build failed

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:

2010-06-02 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed, rolling out r60563.
http://trac.webkit.org/changeset/60563
https://bugs.webkit.org/show_bug.cgi?id=39646

windows build failed

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/v8/custom/V8ConsoleCustom.cpp:
  • page/Console.h:
  • page/Console.idl:
  • page/MemoryInfo.cpp: Removed.
  • page/MemoryInfo.h: Removed.
  • page/MemoryInfo.idl: Removed.
07:14 Changeset [60564] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: adding new inspector test into GTK's Skipped.

https://bugs.webkit.org/show_bug.cgi?id=40049

  • platform/gtk/Skipped:
07:12 Changeset [60563] by mnaganov@chromium.org
  • 18 edits
    3 copies in trunk

2010-06-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by NOBODY (OOPS!).

Web Inspector: add Console API for retrieving memory stats

Add 'console.memory' property which returns an object. Currently
it has two fields: totalJSHeapSize and usedJSHeapSize. Later, it can be
extended for reporting total browser's memory consumption.

https://bugs.webkit.org/show_bug.cgi?id=39646

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::memory):
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::memoryAccessorGetter):
  • page/Console.h:
  • page/Console.idl:
  • page/MemoryInfo.cpp: Added. (WebCore::MemoryInfo::MemoryInfo):
  • page/MemoryInfo.h: Added. (WebCore::MemoryInfo::create): (WebCore::MemoryInfo::totalJSHeapSize): (WebCore::MemoryInfo::usedJSHeapSize):
  • page/MemoryInfo.idl: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
06:55 Changeset [60562] by pfeldman@chromium.org
  • 34 edits
    4 adds
    1 delete in trunk

2010-06-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add test for resource parameters.

https://bugs.webkit.org/show_bug.cgi?id=40026


Test: http/tests/inspector/resource-parameters.html

  • inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype._buildParameters):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._parseParameters):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshParms):

2010-06-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add test for resource parameters.

https://bugs.webkit.org/show_bug.cgi?id=40026

  • http/tests/inspector/inspector-test.js: (onload): (dumpObject): (dumpArray):
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters-expected.txt: Added.
  • http/tests/inspector/resource-parameters.html: Added.
  • http/tests/inspector/resource-tests.js: Added. (resourceURLComparer):
  • http/tests/inspector/resources/resource-form-data-receiver-iframe.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-expected.txt:
  • inspector/console-log-before-inspector-open-expected.txt:
  • inspector/console-tests-expected.txt:
  • inspector/elements-panel-structure-expected.txt:
  • inspector/elements-panel-styles-expected.txt:
  • inspector/elements-panel-xhtml-structure-expected.txt:
  • inspector/evaluate-in-frontend-expected.txt:
  • inspector/styles-source-offsets-expected.txt:
  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/timeline-event-dispatch-expected.txt:
  • inspector/timeline-layout-expected.txt:
  • inspector/timeline-mark-timeline-expected.txt:
  • inspector/timeline-network-resource-expected.txt:
  • inspector/timeline-paint-expected.txt:
  • inspector/timeline-parse-html-expected.txt:
  • inspector/timeline-recalculate-styles-expected.txt:
  • inspector/timeline-script-tag-1-expected.txt:
  • inspector/timeline-script-tag-2-expected.txt:
  • inspector/timeline-test.js: (printTimelineRecordProperties):
  • platform/chromium-win/inspector/console-log-before-inspector-open-expected.txt: Removed.
  • platform/chromium-win/inspector/timeline-event-dispatch-expected.txt:
  • platform/chromium-win/inspector/timeline-mark-timeline-expected.txt:
  • platform/chromium-win/inspector/timeline-network-resource-expected.txt:
  • platform/chromium-win/inspector/timeline-paint-expected.txt:
  • platform/chromium-win/inspector/timeline-parse-html-expected.txt:
05:48 Changeset [60561] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix make install on Symbian for headers in package builds when INSTALL_HEADERS is not defined

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-06-02
Reviewed by Simon Hausmann.

First we wrote inst_headers.output with $$[QT_INSTALL_HEADERS] and then
overwrote it with the $$INSTALL_HEADERS variant without checking if the
variable was set.

Fixed and cleaned up the logic of falling back to $$[QT_INSTALL_HEADERS].

  • WebCore.pro:
05:31 Changeset [60560] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60559.
http://trac.webkit.org/changeset/60559
https://bugs.webkit.org/show_bug.cgi?id=40055

It broke python unit test (Requested by Ossy on #webkit).

  • Scripts/webkitpy/common/net/buildbot.py:
05:12 Changeset [60559] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

Slave lost shouldn't be recognized as build failed.
https://bugs.webkit.org/show_bug.cgi?id=39282

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/net/buildbot.py:
04:14 Changeset [60558] by xan@webkit.org
  • 7 edits in trunk/WebCore

2010-06-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Style fixes for the generated code in DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=39949

Get rid of extra spaces and wrong indentation in the generated
code.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type): (webkit_dom_test_callback_set_property): (webkit_dom_test_callback_get_property):
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: (webkit_dom_test_interface_set_property): (webkit_dom_test_interface_get_property):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_void_method): (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws): (webkit_dom_test_obj_serialized_value): (webkit_dom_test_obj_method_with_exception): (webkit_dom_test_obj_with_dynamic_frame): (webkit_dom_test_obj_with_dynamic_frame_and_arg): (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad): (webkit_dom_test_obj_with_script_state_void): (webkit_dom_test_obj_with_script_state_obj): (webkit_dom_test_obj_with_script_state_void_exception): (webkit_dom_test_obj_with_script_state_obj_exception): (webkit_dom_test_obj_method_with_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args): (webkit_dom_test_obj_get_read_only_int_attr): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_int_attr): (webkit_dom_test_obj_set_int_attr): (webkit_dom_test_obj_get_long_long_attr): (webkit_dom_test_obj_set_long_long_attr): (webkit_dom_test_obj_get_unsigned_long_long_attr): (webkit_dom_test_obj_set_unsigned_long_long_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_attr_with_exception): (webkit_dom_test_obj_set_attr_with_exception): (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_get_attr_with_getter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (webkit_dom_test_obj_get_script_string_attr): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
04:10 Changeset [60557] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] tests failing with leftover unload handlers
https://bugs.webkit.org/show_bug.cgi?id=30585

  • platform/gtk/Skipped:
03:45 Changeset [60556] by eric@webkit.org
  • 7 edits in trunk/LayoutTests

2010-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Several layout tests needlessly use invalid HTML
https://bugs.webkit.org/show_bug.cgi?id=39985

This change does not change behavior or reduce test coverage.
It only makes our test suite more clear by making our non-parser
tests not bother to test parser quirks which are already covered
by our parsing test suites.

Two invalid cases which are already tested by
the html5lib tests as well as others.

  • Unclosed <title> swallowing the document is covered by <!doctype html><title>foo/title><link></head><body>X and other subtests in html5lib/resources/tests16.dat Missing </title> is also covered by the (invalid) test: fast/js/missing-title-end-tag-js.html
  • Unclosed <tag swallowing the next tag is covered by: fast/invalid/016.html. I suspect it's also covered by various html5lib tests but proved difficult to grep for.
  • css1/box_properties/float_elements_in_series.html:
    • Unclosed <td> tags swallow the following <img> tags. This parser quirk is tested by the HTML5 tests and is an intentional behavior change as part of HTML5. No need for this test to depend on WebKit's old parser behavior.
  • editing/selection/inactive-selection.html:
    • Same as above. Here <div swallows the <script> tag.
  • editing/selection/select-text-overflow-ellipsis.html:
    • An unclosed <title> will swallow the whole document. Intentional HTML5 change, tested by HTML5 test suite and no need to depend on the old title behavior here.
  • fast/dom/title-content-write-set.html:
    • Again, no need to leave an unclosed title.
  • fast/forms/select-set-inner.html:
    • Unclosed <body swallows <p>
  • fast/js/exception-linenums-in-html-2.html:
    • Unclosed <title> swallows the document.
  • html5lib/resources/webkit01.dat:
    • Added a test for <img<img> to make sure it's covered.
03:16 Changeset [60555] by pfeldman@chromium.org
  • 10 edits
    3 adds in trunk

2010-06-02 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Added conversion of inspector's resource representation into HAR.
Moved common resource accessors from ResourceView to Resource.
https://bugs.webkit.org/show_bug.cgi?id=30567

Test: http/tests/inspector/resource-har-conversion.html

03:10 Changeset [60554] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60547.
http://trac.webkit.org/changeset/60547
https://bugs.webkit.org/show_bug.cgi?id=40051

It made fast/overflow/overflow-with-local-background-
attachment.html crash (Requested by Ossy on #webkit).

  • notifications/Notification.h: (WebCore::Notification::create):
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
03:07 Changeset [60553] by eric@webkit.org
  • 12 edits in trunk

2010-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTML5 parser does not track line numbers
https://bugs.webkit.org/show_bug.cgi?id=39984

Update our expectations to show the proper line numbers.
These new line numbers match what the old parser produces.

  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:

2010-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTML5 parser does not track line numbers
https://bugs.webkit.org/show_bug.cgi?id=39984

This adds rudimentary line-number tracking to the HTML5Lexer.
We'll still need to handle \r\n cases eventually, but this
fixes the vast majority of our line-number related failures.

Fixes 268 layout tests. :)

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::reset):
    • Reset m_lineNumber to 0.

(WebCore::HTML5Lexer::consumeEntity):

  • Pass m_lineNumber to advance().

(WebCore::HTML5Lexer::nextToken):

  • Pass m_lineNumber to advance().
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::lineNumber):
    • Expose m_lineNumber for HTML5Tokenizer.

(WebCore::HTML5Lexer::columnNumber):

  • Mirrors the implementation in the old HTMLTokenizer. we might some day support column number tracking in the Lexer. It certainly would be possible.
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::HTML5ScriptRunner):
    • ASSERT we're passed a host.

(WebCore::HTML5ScriptRunner::sourceFromPendingScript):

  • Use PendingScript.startingLineNumber when PendingScript is an inline script.

(WebCore::HTML5ScriptRunner::execute):

  • Now expects a start line number passed from the TreeBuilder.

(WebCore::HTML5ScriptRunner::runScript):

  • Now expects a start line number.
  • html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::PendingScript::PendingScript):
    • Track startingLineNumber for any inline script.
  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::begin):
    • Add a FIXME. The old HTMLTokenizer resets its "lexer" state here.

(WebCore::HTML5Tokenizer::pumpLexer):

  • Pass scriptStartLine to the HTML5ScriptRunner

(WebCore::HTML5Tokenizer::lineNumber):

  • Implementation for Tokenizer.h

(WebCore::HTML5Tokenizer::columnNumber):

  • Implementation for Tokenizer.h
  • html/HTML5Tokenizer.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder):
    • Initialize the new line number tracking variables.

(WebCore::HTML5TreeBuilder::handleScriptEndTag):

  • Save off the line number from the start tag to pass to the ScriptRunner.

(WebCore::HTML5TreeBuilder::takeScriptToProcess):

  • Return the line number from the start tag.

(WebCore::HTML5TreeBuilder::passTokenToLegacyParser):

  • Save off the line number of ever script start tag we see.
  • html/HTML5TreeBuilder.h:
    • Keep both the line number of the last start tag, and the line number of the script we know we're expecting our caller to run before resuming parsing. These are separate to keep the code clean, especially since the last script start tag line number is a hack specific to using the old HTMLParser.
02:54 Changeset [60552] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-02 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Timeline should nicely format the Timer timeout
https://bugs.webkit.org/show_bug.cgi?id=40040

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): Format the Timer's timeout time.
02:49 Changeset [60551] by tkent@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed. Test expectation update.

Remove Chromium-Mac expectation of mask-changes.html. The results
is now identical to platform/mac.

  • platform/chromium-mac/svg/custom/mask-changes-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/mask-changes-expected.png: Removed.
02:30 Changeset [60550] by tkent@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Unreviewed. Test expectation update.

Update Windows and Linux results of empty-clip-path.html and
empty-mask.html for r60541.

  • platform/chromium-linux/svg/custom/empty-mask-expected.txt: Removed.
  • platform/chromium-win/svg/custom/empty-clip-path-expected.txt:
  • platform/chromium-win/svg/custom/empty-mask-expected.txt:
02:14 Changeset [60549] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-02 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Fix crash caused when assigned_to is disabled
https://bugs.webkit.org/show_bug.cgi?id=40039

  • Scripts/webkitpy/common/net/bugzilla.py:
02:01 Changeset [60548] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-02 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Clamp dirtyRect updates of composited layer contents to the size
of the layer to avoid writing outside texture bounds.
https://bugs.webkit.org/show_bug.cgi?id=40030

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::updateTextureContents):
01:45 Changeset [60547] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-02 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Notification object ref counting is not correct.
https://bugs.webkit.org/show_bug.cgi?id=39998

Return PassRefPtr<Notification> instead of a raw pointer from the create methods
for Web Notifications.

No new tests are needed, as existing tests show the problem when sending the
"display" event asynchronously.

  • notifications/Notification.h: (WebCore::Notification::create):
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
01:30 Changeset [60546] by eric@webkit.org
  • 4 edits in trunk

2010-06-02 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Dirk Schulze.

[Qt] Image shadow doesn't work
https://bugs.webkit.org/show_bug.cgi?id=37804

Enable image shadow basic test and disable image shadow transparent test case, that failed
because of the Qt known issue on transparent image.

  • platform/qt/Skipped:

2010-06-02 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Dirk Schulze.

[Qt] Image shadow doesn't work
https://bugs.webkit.org/show_bug.cgi?id=37804

Implement the code for image shadow

  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
01:18 Changeset [60545] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-02 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

Adding the precision qualifier to fragment shaders used by the GL
compositor in chromium to turn them into valid GLSL ES.
https://bugs.webkit.org/show_bug.cgi?id=40022

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedGLObjects):
01:04 Changeset [60544] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by David Levin.

Fix type qualifier is meaningless on cast type in SVGFEColorMatrixElement::build
https://bugs.webkit.org/show_bug.cgi?id=40015

No new tests as there is no new functionality.

Remove const from the cast type.

  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
00:50 Changeset [60543] by eric@webkit.org
  • 17 edits in trunk

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • configure.ac:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • Configurations/FeatureDefines.xcconfig:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • features.gypi:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • Configurations/FeatureDefines.xcconfig:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • Scripts/build-webkit:
00:18 Changeset [60542] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Dirk Schulze <krit@webkit.org>

Uneviewed.

SVG repaintRect should be empty if content got clipped away
https://bugs.webkit.org/show_bug.cgi?id=39965


Baseline update for Qt.

  • platform/qt/svg/custom/empty-mask-expected.txt:

06/01/10:

23:16 Changeset [60541] by krit@webkit.org
  • 25 edits in trunk

2010-06-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
https://bugs.webkit.org/show_bug.cgi?id=39965


The SVG repaintRect of the renderer was not empty, if the content got clipped away.
The MaskerData/ClipperData <-> RenderObject mapping is set up during the layout phase now, to be able to
relayout a RenderObject, if it's repaintRect is empty. This has the following reason:
We apply the object to the resource on painting at the moment.
With an empty repaintRect, paint() quits earlier and therefore the object doesn't get applied to the resource.
This can cause problems, if the resource get changed by animations or scripts.
On a change, the resource tells all it's callers to relayout.
If the reference to the caller (our RenderObject) is missing, the object won't ever update
and therefore won't get drawn.
We already have LayoutTests that cover this problem. The complete repaintRect calculation
(including the smallest clipping area and shadow size calculation) moved from the renderers to SVGRenderSupport.
This eliminates redundant code.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::updateCachedBoundaries):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::intersectRepaintRectWithResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasClipper): (WebCore::SVGRenderStyle::hasMasker): (WebCore::SVGRenderStyle::hasFilter):


2010-06-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
https://bugs.webkit.org/show_bug.cgi?id=39965


New repaintRect calculation causes updates of tests, where the content gets
clipped away.

  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/custom/empty-clip-path-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
23:13 Changeset [60540] by krit@webkit.org
  • 26 edits in trunk

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60539.
http://trac.webkit.org/changeset/60539
https://bugs.webkit.org/show_bug.cgi?id=40043

Accidentally added an unreviewed and invalid change to the
patch. (Requested by krit on #webkit).

  • rendering/RenderPath.cpp: (WebCore::RenderPath::updateCachedBoundaries):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.h:
  • svg/SVGColor.cpp: (WebCore::SVGColor::colorFromRGBColorString):

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60539.
http://trac.webkit.org/changeset/60539
https://bugs.webkit.org/show_bug.cgi?id=40043

Accidentally added an unreviewed and invalid change to the
patch. (Requested by krit on #webkit).

  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/custom/empty-clip-path-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
23:04 Changeset [60539] by krit@webkit.org
  • 26 edits in trunk

2010-06-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
https://bugs.webkit.org/show_bug.cgi?id=39965


The SVG repaintRect of the renderer was not empty, if the content got clipped away.
The MaskerData/ClipperData <-> RenderObject mapping is set up during the layout phase now, to be able to
relayout a RenderObject, if it's repaintRect is empty. This has the following reason:
We apply the object to the resource on painting at the moment.
With an empty repaintRect, paint() quits earlier and therefore the object doesn't get applied to the resource.
This can cause problems, if the resource get changed by animations or scripts.
On a change, the resource tells all it's callers to relayout.
If the reference to the caller (our RenderObject) is missing, the object won't ever update
and therefore won't get drawn.
We already have LayoutTests that cover this problem. The complete repaintRect calculation
(including the smallest clipping area and shadow size calculation) moved from the renderers to SVGRenderSupport.
This eliminates redundant code.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::updateCachedBoundaries):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::intersectRepaintRectWithResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasClipper): (WebCore::SVGRenderStyle::hasMasker): (WebCore::SVGRenderStyle::hasFilter):


2010-06-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
https://bugs.webkit.org/show_bug.cgi?id=39965


New repaintRect calculation causes updates of tests, where the content gets
clipped away.

  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/custom/empty-clip-path-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
22:57 Changeset [60538] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed, build fix.

Roll our r60536. The change was not wrong, but not good for Chromium bots status.

22:49 Changeset [60537] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebKit/qt

2010-06-01 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add documentation to the QtWebkit bridge
https://bugs.webkit.org/show_bug.cgi?id=35861

This patch includes comprehensive qdoc documentation for the QtWebkit bridge.

  • docs/qtwebkit-bridge.qdoc: Added.
  • docs/qtwebkit.qdoc:
  • docs/webkitsnippets/doc_src_qtscript.qdoc: Added.
  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: Added. (wrapInFunction):
22:47 Changeset [60536] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Checking out lighttpd
https://bugs.webkit.org/show_bug.cgi?id=39948

  • Add lighttpd only on Windows. It is used by new-run-webkit-tests.
  • Add libvpx.
  • Remove pthreads-win32 from DEPS. It has not been used since Chromium r28642.
  • Update Chromium revision to use Windows resource query code and webkit_glue dependency fix.
  • DEPS:
22:04 Changeset [60535] by eric@webkit.org
  • 9 edits
    3 deletes in trunk

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60530.
http://trac.webkit.org/changeset/60530
https://bugs.webkit.org/show_bug.cgi?id=40041

resource-har-conversion failed on GTK (Requested by abarth on
#webkit).

  • http/tests/inspector/inspector-test.js:
  • http/tests/inspector/resource-har-conversion-expected.txt: Removed.
  • http/tests/inspector/resource-har-conversion.html: Removed.

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60530.
http://trac.webkit.org/changeset/60530
https://bugs.webkit.org/show_bug.cgi?id=40041

resource-har-conversion failed on GTK (Requested by abarth on
#webkit).

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/HAREntry.js: Removed.
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.set url):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshQueryString): (WebInspector.ResourceView.prototype._refreshFormData): (WebInspector.ResourceView.prototype._refreshParms):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
20:52 Changeset [60534] by tkent@chromium.org
  • 2 edits
    12 adds in trunk/LayoutTests

Unreviewed. Test expectation update.

Add Chromium-win Chromium-linux results for backslash-to-yen-sign*.html tests.

  • platform/chromium-linux/fast/text/backslash-to-yen-sign-dynamic-expected.checksum: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-expected.checksum: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-dynamic-expected.checksum: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-dynamic-expected.png: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.checksum: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
20:42 Changeset [60533] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations.

  • platform/chromium/test_expectations.txt: moving-shadow-on-path has been rebaselined. input-search-padding may or may not be flaky.
20:40 Changeset [60532] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-01 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: warnings when reloading page
https://bugs.webkit.org/show_bug.cgi?id=39694

Made sure recaching and masks aren't attempted on zero-size layers.

No new tests. Old tests (e.g. LayoutTests/compositing/masks) show the problem.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::MaskEffectQt::draw): (WebCore::GraphicsLayerQtImpl::recache):
20:28 Changeset [60531] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-01 anton muhin <antonm@google.com>

Reviewed by Nate Chapin.

[Chromium] enforce presence of named property query callback if named property enumerator is present
https://bugs.webkit.org/show_bug.cgi?id=40006
We need to be able to distinguish between enumerable and not enumerable properties
in the presence of named interceptor. V8 is migrating to use query
callback to report enumerable properties and fallback check---
using getter callback---would report properties as not enumerable.
Thus if there is an enumerator callback, there should be query callback as well.
(see V8's r4751).

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8NPObject.cpp: (WebCore::npObjectQueryProperty): (WebCore::createV8ObjectForNPObject):
  • bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Storage::namedPropertyQuery):
20:15 Changeset [60530] by eric@webkit.org
  • 9 edits
    3 adds in trunk

2010-06-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Added test for contents of resource record and HAR conversion results.
Added generic object dumper to inspector-tests.js.
https://bugs.webkit.org/show_bug.cgi?id=30567

  • http/tests/inspector/inspector-test.js: (dumpObject):
  • http/tests/inspector/resource-har-conversion-expected.txt: Added.
  • http/tests/inspector/resource-har-conversion.html: Added.

2010-06-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Added conversion of inspector's resource representation into HAR.
Moved common resource accessors from ResourceView to Resource.
https://bugs.webkit.org/show_bug.cgi?id=30567

Test: http/tests/inspector/resource-har-conversion.html

20:03 Changeset [60529] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix "variable may be used before being set" warning in TextResourceDecoder::checkForHeadCharset
https://bugs.webkit.org/show_bug.cgi?id=40001

No new tests as there is no new functionality.

Initialize len to 0 just to eliminate the compiler warning.

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
19:52 Changeset [60528] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-01 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Safari specific files InspectorFrontendClientLocal were removed from chromium project.
https://bugs.webkit.org/show_bug.cgi?id=39993

  • WebCore.gypi:
19:38 Changeset [60527] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Fix broken code generation in GenerateParametersCheckExpression.
https://bugs.webkit.org/show_bug.cgi?id=39960

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: Updated baseline.
19:27 Changeset [60526] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations.

  • Mark input-search-padding.html flaky on Mac
  • Remove function_arguments.html, styles-disable-then-enable.html, notifications-replace.html and notifications-rtl.html. They pass recently.
  • platform/chromium/test_expectations.txt:
19:07 Changeset [60525] by eric@webkit.org
  • 6 edits in trunk

2010-06-01 Raine Makelainen <raine.makelainen@nokia.com>

Reviewed by Simon Hausmann.

[Qt]: REGRESSION(r58703): QWebSettings::JavascriptCanAccessClipboard has wrong case in "Javascript" part.
https://bugs.webkit.org/show_bug.cgi?id=39878

QWebSettings::JavaScriptCanAccessClipboard reverted back to
QWebSettings::JavascriptCanAccessClipboard. QWebSettings::DOMPasteAllowed enum removed.

Value of QWebSettings::JavascriptCanAccessClipboard to setDOMPasteAllowed and
setJavaScriptCanAccessClipboard of WebCore::Settings.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-06-01 Raine Makelainen <raine.makelainen@nokia.com>

Reviewed by Simon Hausmann.

Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
18:24 Changeset [60524] by jamesr@google.com
  • 19 edits
    14 adds
    1 delete in trunk/LayoutTests

2010-06-01 James Robinson <jamesr@chromium.org>

Unreviewed. Update the chromium baselines.

  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.png: Removed.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.txt:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/chromium/test_expectations.txt:
17:34 Changeset [60523] by mrowe@apple.com
  • 1 edit
    1 delete in trunk/WebCore

Remove Breakpoint.js. It was emptied in r60450 but for some reason it was not
deleted at that time. The presence of empty files within the inspector's resource
folder causes Mac OS X production builds to fail.

Rubber-stamped by Adam Roben.

  • inspector/front-end/Breakpoint.js: Removed.
17:30 Changeset [60522] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Fixes Gtk buildbot. Suggested by Gavin Barraclough.

https://bugs.webkit.org/show_bug.cgi?id=40012
Callable objects created via JavaScriptCore API cannot be used as Geolocation callbacks

Disable subtests that check Math.abs - JS host objects are still InternalFunctions in
interpreter, so they behave differently from JIT. The bug tracks deciding what's the best
solution here.

  • fast/dom/Geolocation/argument-types-expected.txt:
  • fast/dom/Geolocation/script-tests/argument-types.js:
17:23 Changeset [60521] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

17:22 Changeset [60520] by mrowe@apple.com
  • 1 copy in tags/Safari-533.15

New tag.

17:04 Changeset [60519] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r60504.

17:04 Changeset [60518] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r60502.

17:04 Changeset [60517] by alice.liu@apple.com
  • 2 edits in trunk/WebKit2

Build fix. Not reviewed

  • win/WebKit2Generated.make: Added WKRetainPtr.h
16:58 Changeset [60516] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-06-01 James Robinson <jamesr@chromium.org>

Unreviewed. Update expected results for r60503
https://bugs.webkit.org/show_bug.cgi?id=38851

  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
16:58 Changeset [60515] by jhawkins@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 James Hawkins <jhawkins@chromium.org>

UNREVIEWED: build fix.

Implement the added virtual methods from PopupMenuClient to
TestPopupMenuClient.

  • tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::selectionChanged): (WebKit::TestPopupMenuClient::selectionCleared):
16:29 Changeset [60514] by jhawkins@chromium.org
  • 12 edits in trunk

2010-05-24 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement new PopupMenuClient methods selectionChanged()
and selectionCleared(). Expose placeHolder methods and isAutoFilled()
in WebInputElement.

https://bugs.webkit.org/show_bug.cgi?id=39639

  • public/WebInputElement.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::didSelectAutoFillSuggestion): (WebKit::WebViewClient::didClearAutoFillSelection):
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::selectionChanged): (WebKit::AutoFillPopupMenuClient::selectionCleared): (WebKit::AutoFillPopupMenuClient::popupDidHide):
  • src/AutoFillPopupMenuClient.h:
  • src/SuggestionsPopupMenuClient.h: (WebKit::SuggestionsPopupMenuClient::selectionChanged): (WebKit::SuggestionsPopupMenuClient::selectionCleared):
  • src/WebInputElement.cpp: (WebKit::WebInputElement::setPlaceholder): (WebKit::WebInputElement::placeholder): (WebKit::WebInputElement::isAutofilled):

2010-05-24 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

Added ability for PopupMenuClient to signal when

  • selection changed, and
  • selection cleared.

https://bugs.webkit.org/show_bug.cgi?id=39639

No new tests because this functionality is intentionally hidden from
everything other than renderer.

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::clearSelection):
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::RenderMenuList::selectionChanged): (WebCore::RenderMenuList::RenderMenuList::selectionCleared):
  • rendering/RenderTextControlSingleLine.h: (WebCore::RenderTextControlSingleLine::selectionChanged): (WebCore::RenderTextControlSingleLine::selectionCleared):
16:25 Changeset [60513] by dumi@chromium.org
  • 6 edits in trunk/WebCore

Check if a database needs to be auto-vacuumed only after transactions that have deleted something.
https://bugs.webkit.org/show_bug.cgi?id=39688

Reviewed by Dimitri Glazkov.

  • storage/Database.cpp:

(WebCore::Database::resetDeletes):
(WebCore::Database::hadDeletes):

  • storage/Database.h:
  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::resetDeletes):
(WebCore::DatabaseAuthorizer::dropTable):
(WebCore::DatabaseAuthorizer::dropTempTable):
(WebCore::DatabaseAuthorizer::dropIndex):
(WebCore::DatabaseAuthorizer::dropTempIndex):
(WebCore::DatabaseAuthorizer::dropTrigger):
(WebCore::DatabaseAuthorizer::dropTempTrigger):
(WebCore::DatabaseAuthorizer::dropView):
(WebCore::DatabaseAuthorizer::dropTempView):
(WebCore::DatabaseAuthorizer::dropVTable):
(WebCore::DatabaseAuthorizer::allowDelete):
(WebCore::DatabaseAuthorizer::updateDeletesBasedOnTableName): Added.

  • storage/DatabaseAuthorizer.h:

(WebCore::DatabaseAuthorizer::hadDeletes):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):

16:13 Changeset [60512] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Bug 40021 - Refactor bytecode generation for calls so that register for this & args are allocated together

Reviewed by Sam Weinig.

This is a useful stepping stone towards reversing argument order.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addParameter):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallEval):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::thisRegister):
(JSC::CallArguments::argumentRegister):
(JSC::CallArguments::callFrame):
(JSC::CallArguments::count):
(JSC::BytecodeGenerator::shouldEmitProfileHooks):

  • bytecompiler/NodesCodegen.cpp:

(JSC::NewExprNode::emitBytecode):
(JSC::CallArguments::CallArguments):
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

15:47 Changeset [60511] by ap@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

A nicer Tiger build fix.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/Base.xcconfig: Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
15:37 Changeset [60510] by sullivan@apple.com
  • 3 edits in trunk/WebKit2

Added _WKRetainPtr to .exp file, and added .exp file to Xcode project.

Rubber-stamped by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:

Added mac/WebKit2.exp.

  • mac/WebKit2.exp:

Added _WKRetainPtr.

14:41 Changeset [60509] by hyatt@apple.com
  • 8 edits in trunk

Add a preference for paginating during layout (the new model for computing page breaks).

Reviewed by Anders Carlsson.

WebCore:

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setPaginateDuringLayoutEnabled):
(WebCore::Settings::paginateDuringLayoutEnabled):

WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences paginateDuringLayoutEnabled]):
(-[WebPreferences setPaginateDuringLayoutEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

14:39 Changeset [60508] by dumi@chromium.org
  • 11 edits in trunk/WebCore

Clean up the DB classes in preparation for a bigger refactoring.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

  • storage/ChangeVersionWrapper.cpp:
  • storage/ChangeVersionWrapper.h:
  • storage/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::lastActionChangedDatabase):
(WebCore::Database::lastActionWasInsert):
(WebCore::Database::inProgressTransactionCompleted):
(WebCore::Database::securityOrigin):

  • storage/Database.h:

(WebCore::Database::sqliteDatabase):
(WebCore::Database::databaseDebugName):

  • storage/DatabaseTask.cpp:

(WebCore::DatabaseTransactionTask::doPerformTask):

  • storage/DatabaseTask.h:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):

  • storage/SQLStatement.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::postflightAndCommit):
(WebCore::SQLTransaction::cleanupAfterSuccessCallback):
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):

  • storage/SQLTransaction.h:
14:26 Changeset [60507] by ossy@webkit.org
  • 4 edits in trunk/LayoutTests

[Qt] Update expected results after r60503.

Reviewed by Laszlo Gombos.

  • platform/qt/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/qt/svg/css/arrow-with-shadow-expected.txt:
  • platform/qt/svg/css/stars-with-shadow-expected.txt:
14:26 Changeset [60506] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

Fixed typo/wordo that prevented a certain flavor of constructor from compiling.

Rubber-stamped by Anders Carlsson.

  • UIProcess/API/cpp/WKRetainPtr.h:

(WebKit::WKRetainPtr::WKRetainPtr):
Changed the mysterious "retainWKPtr" to "WKRetain".

14:21 Changeset [60505] by ap@apple.com
  • 2 edits in trunk/WebKitTools

A real Tiger build fix.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS for all configurations, not just debug.
14:15 Changeset [60504] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=40025
<rdar://problem/8046273> All Flash content crashes after installing CS5 Design Premium.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView supportsSnapshotting]): Do not support snapshotting Flash 10.1 if the version is less than 10.1.53.60.
13:33 Changeset [60503] by rwlbuis@webkit.org
  • 19 edits
    3 adds in trunk

2010-06-01 Rob Buis <rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

Large SVG rect with shadow fails to render
https://bugs.webkit.org/show_bug.cgi?id=38851

Store intermediate shadow calculation in floats to prevent integer overflow.

Test: svg/filters/shadow-on-rect-large.svg

  • rendering/style/SVGRenderStyle.cpp: (WebCore::getSVGShadowExtent): (WebCore::SVGRenderStyle::inflateForShadow):
13:15 Changeset [60502] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

QuickTime 7.6.4 + Safari Nightly = Crash
https://bugs.webkit.org/show_bug.cgi?id=40019
rdar://problem/8035443

Reviewed by Sam Weinig.

Check the return value of QTCFPropertyListCreateXMLData before calling CFDataGetLength().

  • platform/graphics/win/QTCFDictionary.cpp:

(QTCFDictionaryCreateCopyWithDataCallback):

13:06 Changeset [60501] by rwlbuis@webkit.org
  • 6 edits
    3 adds in trunk

2010-06-01 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

Manipulating SVG element attributes in Javascript does not work as expected
https://bugs.webkit.org/show_bug.cgi?id=34328

Reset the viewBox to be empty when removing the viewBox attribute.

Test: svg/custom/svg-viewBox-dynamic.html

13:03 Changeset [60500] by jer.noble@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Rolling back change made on wrong branch.

12:42 Changeset [60499] by jer.noble@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

QuickTime 7.6.4 + Safari Nightly = Crash
https://bugs.webkit.org/show_bug.cgi?id=40019
rdar://problem/8035443

Reviewed by Sam Weinig.

Check the return value of QTCFPropertyListCreateXMLData before calling CFDataGetLength().

  • platform/graphics/win/QTCFDictionary.cpp:

(QTCFDictionaryCreateCopyWithDataCallback):

12:21 Changeset [60498] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Memory Leak: The main resource of page is not free.
https://bugs.webkit.org/show_bug.cgi?id=39973

Fix refcount tracking of the main resource. Patch by Genhua Liu.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
12:12 Changeset [60497] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Tiger build fix.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
12:09 Changeset [60496] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter:] when it encounters a parameterized attribute that it doesn't handle.
https://bugs.webkit.org/show_bug.cgi?id=39324

Reviewed by Beth Dakin.

There are some parameters that super handles that are not explicitly returned by the list of the element's attributes.
In those cases, super should handle.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

12:01 Changeset [60495] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60483.
http://trac.webkit.org/changeset/60483
https://bugs.webkit.org/show_bug.cgi?id=40013

Breaks Mac and Linux builds (Requested by antonm on #webkit).

  • DEPS:
11:58 Changeset [60494] by hyatt@apple.com
  • 3 edits
    8 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=15550, complete implementation of column-span. Add support for nested column
spans. When a column span is nested inside multiple enclosing blocks, the blocks have to be split around the column-span.
We do this using block element continuations, the same kind of solution we employed for blocks inside inlines.

Reviewed by Beth Dakin.

The code for block continuations is very similar to the code for inline continuations. It may be possible to refactor the
code into RenderBoxModelObject so that more of it can be shared, but this first pass avoids that so as not to risk
causing any regressions in core rendering.

Note also that - just as with inline continuations - you can't unsplit block continuations yet. There is no technical limitation
here... the functions just need to be written to handle it.

Added new tests in fast/multicol/span.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::continuationBefore):
(WebCore::RenderBlock::addChildToContinuation):
(WebCore::RenderBlock::containingColumnsBlock):
(WebCore::RenderBlock::clone):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::splitFlow):
(WebCore::RenderBlock::splitAnonymousBlocksAroundChild):
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks):
(WebCore::RenderBlock::columnsBlockForSpanningElement):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::addChildIgnoringContinuation):
(WebCore::RenderBlock::blockElementContinuation):
(WebCore::RenderBlock::layoutColumns):

  • rendering/RenderBlock.h:
11:51 Changeset [60493] by ap@apple.com
  • 3 edits in trunk/WebCore

Build fix.

Hopefully, touching WebCore.base.exp will actually rebuild the export file.

  • WebCore.Geolocation.exp:
  • WebCore.base.exp:
11:50 Changeset [60492] by dumi@chromium.org
  • 5 edits in trunk

WebCore: Execute void callbacks in the context they were created in.
https://bugs.webkit.org/show_bug.cgi?id=39145

Reviewed by Adam Barth.

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::V8CustomVoidCallback::V8CustomVoidCallback):
(WebCore::V8CustomVoidCallback::handleEvent):

  • bindings/v8/custom/V8CustomVoidCallback.h:

LayoutTests: storage/transaction-success-callback-isolated-world.html is being fixed.
https://bugs.webkit.org/show_bug.cgi?id=39145

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
11:40 Changeset [60491] by xan@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-06-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix-up for previous leak fix, the identifier was not always duped.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_add_resource):
11:08 Changeset [60490] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Plug a small leak.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
11:04 Changeset [60489] by mrobinson@webkit.org
  • 4 edits
    2 adds in trunk

2010-05-12 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Get more mouse tests passing
https://bugs.webkit.org/show_bug.cgi?id=39040

Unskip tests that are now passing.

  • platform/gtk/Skipped:

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Get more mouse tests passing
https://bugs.webkit.org/show_bug.cgi?id=39040

Reproduce the logic from the Windows EventSender for mapping
button numbers to GDK button numbers. Move this logic to the
prepareMouseButtonEvent helper.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Reproduce Windows logic. (contextClickCallback): Move mapping logic to prepareMouseButtonEvent. (mouseDownCallback): Ditto. (mouseUpCallback): Ditto.
10:48 Changeset [60488] by ap@apple.com
  • 22 edits
    2 adds
    2 deletes in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=39434
REGRESSION (r59811): Geolocation callbacks cannot be created

  • DerivedSources.make: Don't append both WebCore.Geolocation.exp and WebCore.ClientBasedGeolocation.exp, they are mutually exclusive.
  • WebCore.Geolocation.exp: Touched to force .exp file rebuild.
  • WebCore.xcodeproj/project.pbxproj: Removed GeolocationService related files.
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionCallback): Functions defined in JavaScript code no longer inherit from InternalFunction, they inherit from JSFunction. This check is still imperfect, because it's not clear what definition of "function" should really be used, if any - other bindings code never checks callback type. (WebCore::createPositionErrorCallback): Ditto.
  • page/Geolocation.h: Don't include GeolocationService.h unless it's going to be used.
10:46 Changeset [60487] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-01 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Explicitly use PTHREAD_MUTEX_NORMAL to create pthread mutex.
https://bugs.webkit.org/show_bug.cgi?id=39893

  • wtf/ThreadingPthreads.cpp: (WTF::Mutex::Mutex):
10:26 Changeset [60486] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Xan Lopez.

[GTK] Use DEFINE_STATIC_LOCAL for threadMapMutex and threadMap
https://bugs.webkit.org/show_bug.cgi?id=39831

Use DEFINE_STATIC_LOCAL for static local variables.

  • wtf/gtk/ThreadingGtk.cpp: (WTF::threadMapMutex): (WTF::threadMap): (WTF::identifierByGthreadHandle):
10:26 Changeset [60485] by mrobinson@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed. Fix ChangeLog reordering from my last commit.

10:24 Changeset [60484] by jorlow@chromium.org
  • 15 edits in trunk

2010-06-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

IndexedDB cleanup
https://bugs.webkit.org/show_bug.cgi?id=40007

Remove the exception code parameter since this function can no longer
cause an exception.

  • storage/IDBObjectStoreRequest.idl:
  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:
  • storage/IndexedDatabaseRequest.idl:

2010-06-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

IndexedDB cleanup
https://bugs.webkit.org/show_bug.cgi?id=40007

Remove the exception code paramter (that hasn't been used for a while).
Add asserts to default implementations.

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::name): (WebKit::WebIDBDatabase::description): (WebKit::WebIDBDatabase::version): (WebKit::WebIDBDatabase::objectStores):
  • public/WebIndexedDatabase.h: (WebKit::WebIndexedDatabase::open):
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h:
10:21 Changeset [60483] by antonm@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling Chromium revision to bring recent changes to V8.

  • DEPS:
10:18 Changeset [60482] by mrobinson@webkit.org
  • 10 edits
    2 adds in trunk

2010-06-01 Sergio Villar Senin <svillar@igalia.com>

Unskipping tests. No review necessary.

[GTK] unskip some editing tests that are actually working
https://bugs.webkit.org/show_bug.cgi?id=39999

  • platform/gtk/Skipped:

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853

Add GOwnPtr wrapper for GdkEvent and expose a setter for
PlatformMouseEvent::m_clickCount.

  • GNUmakefile.am: Add GOwnPtrGtk.{cpp,h} to the sources list.
  • platform/PlatformMouseEvent.h: (WebCore::PlatformMouseEvent::setClickCount): Added.
  • platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::GdkEvent):
  • platform/gtk/GOwnPtrGtk.h: Added.

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853

Handle click counting much like the Windows port. GTK+ only
counts triple-clicks natively, so use GTK+ double-click settings
to count clicks with even larger click counts. Also filter the
extra GDK_BUTTON_PRESS before GDK_{2,3}BUTTON_PRESS events using
gdk_event_peek().

  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): Count clicks manually. Filter extra events.

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853

WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
the GDK event queue entirely, we simply do not send the extra event.

  • DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately. (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
10:02 Changeset [60481] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-01 Sergio Villar Senin <svillar@igalia.com>

Unskipping tests. No review necessary.

[GTK] unskip some editing tests that are actually working
https://bugs.webkit.org/show_bug.cgi?id=39999

  • platform/gtk/Skipped:
09:06 Changeset [60480] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Not reviewed. Build fix.

Fix GTK+ build caused by a bad merge.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
08:47 Changeset [60479] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-01 Martin Robinson <mrobinson@webkit.org>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853

Small EventSender cleanups. Consolidate some common code. Style fixes.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Added. (contextClickCallback): Use prepareMouseButtonEvent. (mouseDownCallback): Use prepareMouseButtonEvent. (mouseUpCallback): Use prepareMouseButtonEvent. (mouseMoveToCallback): Small style fix.
08:04 QtWebKitTriageRoster edited by ossy@webkit.org
bbandix <=> Ossy (diff)
07:58 Changeset [60478] by mrobinson@webkit.org
  • 4 edits in trunk/WebKitTools

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853

Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
to pause for a specified amount of time. It is used in the processing of drag-
-and-drop data as well as to separate distinct mouse double-clicks in some tests.
This patch enables tests that rely on the latter behavior to pass.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
  • DumpRenderTree/gtk/EventSender.cpp: (leapForwardCallback): Add support for adjusting the time offset on leapForward(). (contextClickCallback): Use sendOrQueueEvent. (updateClickCount): Take the time offset into account when counting clicks. (mouseDownCallback): Use sendOrQueueEvent. (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton. (mouseUpCallback): Use sendOrQueueEvent. (mouseMoveToCallback): Ditto. (mouseWheelToCallback): Ditto. (sendOrQueueEvent): Added. (dispatchEvent): Added. (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent. (makeEventSender): Only initialize the EventSender when loading the top frame.
  • DumpRenderTree/gtk/EventSender.h: Ditto.
07:52 Changeset [60477] by agl@chromium.org
  • 2 edits in trunk/WebCore

2010-06-01 Adam Langley <agl@chromium.org>

Reviewed by Eric Seidel.

[chromium] respect the user's embedded bitmap settings on Linux.

We plumbed everything through Skia and Chrome, but forgot to connect
the two wires inside WebCore.

(Note: no layout test because test_shell forces this option off. Also,

the test font which triggers this behaviour is 32MB.)

https://bugs.webkit.org/show_bug.cgi?id=39894
http://code.google.com/p/chromium/issues/detail?id=21149

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
07:33 Changeset [60476] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix installation of the QtWebKit module .pri file when building inside of Qt

Reviewed by Laszlo Gombos.

  • WebCore.pro:
06:26 Changeset [60475] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix a QtWebKit.pc corruption problem.
https://bugs.webkit.org/show_bug.cgi?id=36826

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-06-01
Reviewed by Simon Hausmann.

The problem occurs while installing QtWebKit from trunk
or a source package.

  • WebCore.pro:
06:24 Changeset [60474] by hausmann@webkit.org
  • 3 edits
    1 move in trunk

WebCore: [Qt] Fix Symbian package dependencies of apps against QtWebKit when installing into Qt

Reviewed by Laszlo Gombos.

Install the versioning qt_webkit_version.pri into $$[QMAKE_MKSPECS]/modules, which is
where mkspecs/features/qt.prf expects it.

  • WebCore.pro:

WebKit/qt: [Qt] Rename versioning .pri file to what Qt's mkspecs/features/qt.pri expects.

Reviewed by Laszlo Gombos.

  • qt_webkit_version.pri: Renamed from WebKit/qt/qtwebkit_version.pri.
06:12 Changeset [60473] by eric@webkit.org
  • 9 edits in trunk

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60470.
http://trac.webkit.org/changeset/60470
https://bugs.webkit.org/show_bug.cgi?id=39990

Need to rollout until bot can be updated (Requested by jorlow
on #webkit).

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyDeleter): (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::indexedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60470.
http://trac.webkit.org/changeset/60470
https://bugs.webkit.org/show_bug.cgi?id=39990

Need to rollout until bot can be updated (Requested by jorlow
on #webkit).

  • DEPS:
05:44 Changeset [60472] by kov@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-05-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Missing links to documentation of general functions
https://bugs.webkit.org/show_bug.cgi?id=39964

Add global functions section, and move those functions that are
currently in WebKitWebView's source file to the bottom, along with
the description.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_dom_document): (webkit_get_default_session):
04:59 Changeset [60471] by mrobinson@webkit.org
  • 85 edits
    1 delete in trunk

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=39101

The timing fix changed expected results for many tests, so regenerate
results for these tests.

  • platform/gtk/Skipped: Unskip tests that should be passing now.
  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/basic/comments-expected.txt:
  • platform/gtk/css1/basic/containment-expected.txt:
  • platform/gtk/css1/basic/id_as_selector-expected.txt:
  • platform/gtk/css1/basic/inheritance-expected.txt:
  • platform/gtk/css1/box_properties/acid_test-expected.txt: Removed.
  • platform/gtk/css1/box_properties/border-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
  • platform/gtk/css1/box_properties/border_left-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width-expected.txt:
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width-expected.txt:
  • platform/gtk/css1/box_properties/border_style-expected.txt:
  • platform/gtk/css1/box_properties/border_top-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width-expected.txt:
  • platform/gtk/css1/box_properties/border_width-expected.txt:
  • platform/gtk/css1/box_properties/clear-expected.txt:
  • platform/gtk/css1/box_properties/clear_float-expected.txt:
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/gtk/css1/box_properties/float_margin-expected.txt:
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/gtk/css1/box_properties/height-expected.txt:
  • platform/gtk/css1/box_properties/margin-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom-expected.txt:
  • platform/gtk/css1/box_properties/margin_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_left-expected.txt:
  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/margin_top-expected.txt:
  • platform/gtk/css1/box_properties/padding-expected.txt:
  • platform/gtk/css1/box_properties/padding_bottom-expected.txt:
  • platform/gtk/css1/box_properties/padding_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_left-expected.txt:
  • platform/gtk/css1/box_properties/padding_right-expected.txt:
  • platform/gtk/css1/box_properties/padding_top-expected.txt:
  • platform/gtk/css1/box_properties/width-expected.txt:
  • platform/gtk/css1/cascade/cascade_order-expected.txt:
  • platform/gtk/css1/classification/display-expected.txt:
  • platform/gtk/css1/classification/list_style_type-expected.txt:
  • platform/gtk/css1/classification/white_space-expected.txt:
  • platform/gtk/css1/color_and_background/background-expected.txt:
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt:
  • platform/gtk/css1/color_and_background/background_position-expected.txt:
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt:
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/gtk/css1/font_properties/font-expected.txt:
  • platform/gtk/css1/font_properties/font_family-expected.txt:
  • platform/gtk/css1/font_properties/font_size-expected.txt:
  • platform/gtk/css1/font_properties/font_weight-expected.txt:
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt:
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt:
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css1/pseudo/anchor-expected.txt:
  • platform/gtk/css1/pseudo/firstletter-expected.txt:
  • platform/gtk/css1/pseudo/firstline-expected.txt:
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt:
  • platform/gtk/css1/text_properties/line_height-expected.txt:
  • platform/gtk/css1/text_properties/text_decoration-expected.txt:
  • platform/gtk/css1/text_properties/text_indent-expected.txt:
  • platform/gtk/css1/text_properties/text_transform-expected.txt:
  • platform/gtk/css1/text_properties/vertical_align-expected.txt:
  • platform/gtk/css1/text_properties/word_spacing-expected.txt:
  • platform/gtk/css1/units/color_units-expected.txt:
  • platform/gtk/css1/units/length_units-expected.txt:
  • platform/gtk/css1/units/percentage_units-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/gtk/fast/multicol/nested-columns-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-tranformed-expected.txt:
  • platform/gtk/fast/repaint/repaint-during-scroll-expected.txt:
  • platform/gtk/fast/text/format-control-expected.txt:

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=39101

Work around timing issues for render tree dumps by pumping the
main loop before doing the dump. Resize events are asynchronous
in GTK+, so sometimes resize requests are still pending when DRT
dumps the tree.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): Pump the main loop before dumping the render tree.
04:30 Changeset [60470] by eric@webkit.org
  • 8 edits in trunk

2010-06-01 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[Chromium] get rid of named interceptor on HTMLDocument and introduce/remove accessors when named items get deleted/removed
https://bugs.webkit.org/show_bug.cgi?id=39877

This patch makes callbacks invoked on named items addition/removal
install API accessors and thus there is no more need in
named and indexed interceptors on HTMLDocument which
speeds up invocation of methods on document.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
02:05 Changeset [60469] by pfeldman@chromium.org
  • 7 edits in trunk/WebKit/chromium

2010-05-31 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Chromium: save inspector settings as dictionary, not as string.
https://bugs.webkit.org/show_bug.cgi?id=32118

  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::didUpdateInspectorSetting):
  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::populateSetting): (WebKit::InspectorClientImpl::storeSetting):
  • src/InspectorClientImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::inspectorSetting): (WebKit::WebViewImpl::setInspectorSetting):
  • src/WebViewImpl.h:
01:57 Changeset [60468] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-06-01 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

Fix style errors of dtoa
https://bugs.webkit.org/show_bug.cgi?id=39972

Fix all errors reported by check-webkit-style.

  • wtf/dtoa.cpp:
  • wtf/dtoa.h:
01:55 Changeset [60467] by pfeldman@chromium.org
  • 8 edits
    7 adds in trunk/LayoutTests

2010-06-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Chromium: rebaseline some svg tests.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
00:44 QtWebKitTriageRoster edited by hausmann@webkit.org
(diff)
00:29 Changeset [60466] by zherczeg@webkit.org
  • 7 edits
    5 adds in trunk

WebCore: Make the spot light anti-alias effect look similar to SVG expected values.
https://bugs.webkit.org/show_bug.cgi?id=39477

Reviewed by Dirk Schulze.

The W3 standard only mention, that the edge of the spotlight should be
anti-aliased but it does not specify how. The provided expected values
gives some hint about their intentions. The algorithm uses a fixed
range, which computed as follows: let a = cos(spot light cutoff range)
the light fades off in the [a-0.016, a] range.

Test: svg/W3C-SVG-1.1/filters-light-04-f.svg
Updated pixel test: svg/W3C-SVG-1.1/filters-light-01-f.svg

  • svg/graphics/filters/SVGLightSource.cpp:

(WebCore::SpotLightSource::initPaintingData):

LayoutTests: Testing the anti-aliasing effect of the spot light edge
https://bugs.webkit.org/show_bug.cgi?id=39477

Reviewed by Dirk Schulze.

  • platform/gtk/Skipped:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
  • platform/qt/Skipped:
  • svg/W3C-SVG-1.1/filters-light-04-f.png: Added.
  • svg/W3C-SVG-1.1/filters-light-04-f.svg: Added.
00:06 Changeset [60465] by eric@webkit.org
  • 8 edits in trunk

2010-05-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix default action for EndTagOpenState
https://bugs.webkit.org/show_bug.cgi?id=39982

Add a test for a bogus end tag to webkit01.dat and update expected
results now that we pass some more tests.

Adding this test revealed a bug in resuming the bogus comment state.
I've left these broken expectations, but I'll fix the bug in a future
patch. (The bug existed prior to this patch, just not the test.)

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:

2010-05-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix default action for EndTagOpenState
https://bugs.webkit.org/show_bug.cgi?id=39982

Add a test for a bogus end tag to webkit01.dat and update expected
results now that we pass some more tests.

Adding this test revealed a bug in resuming the bogus comment state.
I've left these broken expectations, but I'll fix the bug in a future
patch. (The bug existed prior to this patch, just not the test.)

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:

05/31/10:

23:21 Changeset [60464] by jamesr@google.com
  • 4 edits in trunk/WebKit/chromium

2010-05-31 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Expose html5 parser enabled flag in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=39913

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setHTML5ParserEnabled):
  • src/WebSettingsImpl.h:
23:13 Changeset [60463] by tkent@chromium.org
  • 18 edits in trunk

2010-05-31 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): (WebCore::AccessibilityRenderObject::doAXRangeForLine):
  • editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • editing/EditorCommand.cpp: (WebCore::executeDeleteBackward): (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): (WebCore::executeDeleteForward): (WebCore::executeDeleteToBeginningOfLine): (WebCore::executeDeleteToBeginningOfParagraph): (WebCore::executeDeleteToEndOfLine): (WebCore::executeDeleteToEndOfParagraph): (WebCore::executeDeleteWordBackward): (WebCore::executeDeleteWordForward): (WebCore::executeForwardDelete): (WebCore::executeMoveBackward): (WebCore::executeMoveBackwardAndModifySelection): (WebCore::executeMoveDown): (WebCore::executeMoveDownAndModifySelection): (WebCore::executeMoveForward): (WebCore::executeMoveForwardAndModifySelection): (WebCore::executeMoveLeft): (WebCore::executeMoveLeftAndModifySelection): (WebCore::executeMovePageDown): (WebCore::executeMovePageDownAndModifySelection): (WebCore::executeMovePageUp): (WebCore::executeMovePageUpAndModifySelection): (WebCore::executeMoveRight): (WebCore::executeMoveRightAndModifySelection): (WebCore::executeMoveToBeginningOfDocument): (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): (WebCore::executeMoveToBeginningOfLine): (WebCore::executeMoveToBeginningOfLineAndModifySelection): (WebCore::executeMoveToBeginningOfParagraph): (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): (WebCore::executeMoveToBeginningOfSentence): (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfDocument): (WebCore::executeMoveToEndOfDocumentAndModifySelection): (WebCore::executeMoveToEndOfSentence): (WebCore::executeMoveToEndOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfLine): (WebCore::executeMoveToEndOfLineAndModifySelection): (WebCore::executeMoveToEndOfParagraph): (WebCore::executeMoveToEndOfParagraphAndModifySelection): (WebCore::executeMoveParagraphBackwardAndModifySelection): (WebCore::executeMoveParagraphForwardAndModifySelection): (WebCore::executeMoveUp): (WebCore::executeMoveUpAndModifySelection): (WebCore::executeMoveWordBackward): (WebCore::executeMoveWordBackwardAndModifySelection): (WebCore::executeMoveWordForward): (WebCore::executeMoveWordForwardAndModifySelection): (WebCore::executeMoveWordLeft): (WebCore::executeMoveWordLeftAndModifySelection): (WebCore::executeMoveWordRight): (WebCore::executeMoveWordRightAndModifySelection): (WebCore::executeMoveToLeftEndOfLine): (WebCore::executeMoveToLeftEndOfLineAndModifySelection): (WebCore::executeMoveToRightEndOfLine): (WebCore::executeMoveToRightEndOfLineAndModifySelection):
  • editing/SelectionController.cpp: (WebCore::SelectionController::willBeModified): (WebCore::SelectionController::modify):
  • editing/SelectionController.h: (WebCore::SelectionController::):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::modify): (WebCore::DOMSelection::deleteFromDocument):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleKeyboardSelectionMovement):

2010-05-31 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

  • efl/WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::handleEditingKeyboardEvent):

2010-05-31 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeCommand):

2010-05-31 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2010-05-31 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
22:55 Changeset [60462] by rolandsteiner@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-05-31 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: land new Chromium baselines to unblock WebKit roll

Bug 39980 - Add Chromium baselines for svg/filters/parent-children-with-same-filter
https://bugs.webkit.org/show_bug.cgi?id=39980

Add new baselines

  • platform/chromium-linux/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
  • platform/chromium-linux/svg/filters/parent-children-with-same-filter-expected.png: Added.
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png: Added.
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png: Added.
21:50 Changeset [60461] by abarth@webkit.org
  • 5 edits in trunk

2010-05-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(60409): window.onload never fires when using HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=39981

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::finish):
    • The logic was just wrong here. We should only be setting m_wasWaitingOnScriptsDuringFinish if isWaitingForScripts() is true, and we should be calling end() when it is not.

(WebCore::HTML5Tokenizer::resumeParsingAfterScriptExecution):

  • Add another ASSERT to catch cases like this.
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::finished):
    • Add a comment about why we don't need to call m_document->finishedParsing()

2010-05-31 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(60409): window.onload never fires when using HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=39981

Now that we can actually run the tests again we pass 6 more.

  • html5lib/runner-expected-html5.txt:
20:25 Changeset [60460] by rolandsteiner@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-31 Roland Steiner <rolandsteiner@chromium.org>

Bug 39977 - Missing Chromium bindings for InspectorController methods introduced in r60443
https://bugs.webkit.org/show_bug.cgi?id=39977

add missing InspectorController JS bindings:

  • getStyleSheet
  • getRuleRangesForStyleSheetId

Tests: inspector/styles-source-offsets.html

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
19:16 Changeset [60459] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-31 Tony Chang <tony@chromium.org>

Reviewed by Dan Bernstein.

REGRESSION (r58665): Infinite recursion in Position::getInlineBoxAndOffset()
https://bugs.webkit.org/show_bug.cgi?id=39946

  • editing/selection/mixed-editability-12-expected.txt: Added.
  • editing/selection/mixed-editability-12.html: Added.

2010-05-31 Tony Chang <tony@chromium.org>

Reviewed by Dan Bernstein.

REGRESSION (r58665): Infinite recursion in Position::getInlineBoxAndOffset()
https://bugs.webkit.org/show_bug.cgi?id=39946

r58665 added an infinite recursion check, but didn't take into consideration recursion between two
Positions. This adds a check for when
downstreamIgnoringEditingBoundaries(p1) == p2 and upstreamIgnoringEditingBoundaries(p2) == p1

Test: editing/selection/mixed-editability-12.html

  • dom/Position.cpp: (WebCore::Position::getInlineBoxAndOffset):
18:23 Changeset [60458] by weinig@apple.com
  • 15 edits
    11 adds in trunk

Fix canvas.toDataURL(type, quality, ...) to let it support quality parameter.
And implement it in Qt port.
https://bugs.webkit.org/show_bug.cgi?id=37304

Patch by Leo Yang <leo.yang@torchmobile.com.cn> on 2010-05-31
Reviewed by George Staikos.

WebCore:

Tests: platform/qt/fast/canvas/toDataURL-jpeg-alpha.html

platform/qt/fast/canvas/toDataURL-jpeg-primarycolors.html
platform/qt/fast/canvas/toDataURL-jpeg-quality-basic.html
platform/qt/fast/canvas/toDataURL-jpeg-quality-notnumber.html
platform/qt/fast/canvas/toDataURL-jpeg-quality-outsiderange.html

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::toDataURL):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::toDataURLCallback):

  • dom/CanvasSurface.cpp:

(WebCore::CanvasSurface::toDataURL):

  • dom/CanvasSurface.h:

(WebCore::CanvasSurface::toDataURL):

  • html/HTMLCanvasElement.idl:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/haiku/ImageBufferHaiku.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/wince/ImageBufferWince.cpp:

(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::toDataURL):

LayoutTests:

  • platform/qt/fast/canvas/toDataURL-jpeg-alpha-expected.txt: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-alpha.html: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-primarycolors-expected.txt: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-primarycolors.html: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-basic-expected.txt: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-basic.html: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-notnumber-expected.txt: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-notnumber.html: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-outsiderange-expected.txt: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-outsiderange.html: Added.
  • platform/qt/fast/canvas/toDataURL-jpeg.js: Added.
18:21 Changeset [60457] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-31 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60456.
http://trac.webkit.org/changeset/60456
https://bugs.webkit.org/show_bug.cgi?id=39974

Broke Chromium Linux/Max build (Requested by tkent on
#webkit).

  • DEPS:
17:44 Changeset [60456] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-31 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Checking out lighttpd
https://bugs.webkit.org/show_bug.cgi?id=39948

  • Checking out lighttpd only on Windows. It is used by new-run-webkit-tests.
  • Update Chromium revision to use Windows resource query code
  • DEPS:
17:42 Changeset [60455] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-31 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix crash of a test after another test with multiple windows
https://bugs.webkit.org/show_bug.cgi?id=39942

If a test opens multiple windows, focuses on non-main window, and
the focused window is closed, TestShell::m_focusedWidget points a
deleted object.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::closeWindow): Clear m_focusedWidget.
15:58 Changeset [60454] by eric@webkit.org
  • 13 edits
    2 adds in trunk

2010-05-31 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add Context Menu implementation
https://bugs.webkit.org/show_bug.cgi?id=39821

  • platform/ContextMenu.h: add port-specific attributes.
  • platform/ContextMenuItem.h: create PlatformMenuItemDescription as in other ports (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
  • platform/efl/ContextMenuEfl.cpp:implement needed methods for this port. (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::releasePlatformDescription):
  • platform/efl/ContextMenuItemEfl.cpp: implement needed methods for this port. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::checked): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::enabled): (WebCore::ContextMenuItem::setEnabled):

2010-05-31 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add Context Menu implementation
https://bugs.webkit.org/show_bug.cgi?id=39821

  • CMakeListsEfl.txt: add context menu files.
  • efl/WebCoreSupport/ContextMenuClientEfl.cpp: (WebCore::ContextMenuClientEfl::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientEfl::newPlatformDescription): (WebCore::ContextMenuClientEfl::freePlatformDescription): (WebCore::ContextMenuClientEfl::appendItem): (WebCore::ContextMenuClientEfl::show):
  • efl/WebCoreSupport/ContextMenuClientEfl.h:
  • efl/ewk/EWebKit.h:
  • efl/ewk/ewk_contextmenu.cpp: Added. Implement the API used by browser for manipulating context menus. (ewk_context_menu_ref): (ewk_context_menu_unref): (ewk_context_menu_destroy): (ewk_context_menu_item_list_get): (ewk_context_menu_item_new): (ewk_context_menu_item_select): (ewk_context_menu_item_free): (ewk_context_menu_item_type_get): (ewk_context_menu_item_type_set): (ewk_context_menu_item_action_get): (ewk_context_menu_item_action_set): (ewk_context_menu_item_title_get): (ewk_context_menu_item_title_set): (ewk_context_menu_item_checked_get): (ewk_context_menu_item_checked_set): (ewk_context_menu_item_enabled_get): (ewk_context_menu_item_enabled_set): (ewk_context_menu_new): (ewk_context_menu_free): (ewk_context_menu_item_append): (ewk_context_menu_custom_get): (ewk_context_menu_show):
  • efl/ewk/ewk_contextmenu.h: Added.
  • efl/ewk/ewk_private.h:
  • efl/ewk/ewk_view.cpp: (ewk_view_context_menu_forward_event): inform browser a new context menu was created. (ewk_view_exceeded_database_quota): small fix to previous changed function.
  • efl/ewk/ewk_view.h:
15:40 Changeset [60453] by eric@webkit.org
  • 27 edits
    2 deletes in trunk/LayoutTests

2010-05-31 Stephen White <senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

New Chromium Win+Linux baselines for background image resize layout tests.
https://bugs.webkit.org/show_bug.cgi?id=38686

  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-linux/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.checksum:
  • platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png: Removed.
  • platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.png: Removed.
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.png:
  • platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.checksum:
  • platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium/test_expectations.txt:
15:28 Changeset [60452] by eric@webkit.org
  • 6 edits
    2 adds in trunk/WebCore

2010-05-31 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Classes for native serialization to JSON were implemented.
https://bugs.webkit.org/show_bug.cgi?id=34204

  • GNUmakefile.am:
  • WebCore.Inspector.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorValues.cpp: Added. (WebCore::escapeChar): (WebCore::doubleQuoteString): (WebCore::InspectorBaseValue::toJSONString): (WebCore::InspectorBaseValue::writeJSON): (WebCore::InspectorValue::writeJSON): (WebCore::InspectorString::writeJSON): (WebCore::InspectorObject::writeJSON): (WebCore::InspectorArray::writeJSON):
  • inspector/InspectorValues.h: Added. (WebCore::InspectorBaseValue::InspectorBaseValue): (WebCore::InspectorBaseValue::~InspectorBaseValue): (WebCore::InspectorBaseValue::null): (WebCore::InspectorBaseValue::): (WebCore::InspectorBaseValue::type): (WebCore::InspectorValue::create): (WebCore::InspectorValue::InspectorValue): (WebCore::InspectorValue::): (WebCore::InspectorString::create): (WebCore::InspectorString::InspectorString): (WebCore::InspectorObject::create): (WebCore::InspectorObject::~InspectorObject): (WebCore::InspectorObject::InspectorObject): (WebCore::InspectorArray::create): (WebCore::InspectorArray::~InspectorArray): (WebCore::InspectorArray::length): (WebCore::InspectorArray::InspectorArray): (WebCore::InspectorObject::setBool): (WebCore::InspectorObject::setNumber): (WebCore::InspectorObject::setString): (WebCore::InspectorObject::set): (WebCore::InspectorArray::pushBool): (WebCore::InspectorArray::pushNumber): (WebCore::InspectorArray::pushString): (WebCore::InspectorArray::push):
15:16 Changeset [60451] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-31 Olivier Goffart <olivier.goffart@nokia.com>

Reviewed by Oliver Hunt.

[PATCH] compilation error with clang in JSDOMBinding.h
https://bugs.webkit.org/show_bug.cgi?id=39945

JSNode is only forward declared at this point. And since neither
"wrapper" nor JSValue are type-dependent. Compilers should report errors
at the first compilation pass.

The fix is to move the conversion the line above, as the call to the
function getCachedDOMNodeWrapper is type-dependent, the conversion will
happen at template-instantiation time.

See also http://llvm.org/bugs/show_bug.cgi?id=7244

  • bindings/js/JSDOMBinding.h: (WebCore::getDOMNodeWrapper):
12:46 Changeset [60450] by pfeldman@chromium.org
  • 13 edits
    1 add in trunk/WebCore

2010-05-31 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Moved breakpoints add/remove logic to the BreakpointManager.

https://bugs.webkit.org/show_bug.cgi?id=14190

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/Breakpoint.js:
  • inspector/front-end/BreakpointManager.js: Added.
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype.reset): (WebInspector.BreakpointsSidebarPane.prototype._breakpointAdded): (WebInspector.BreakpointsSidebarPane.prototype._breakpointRemoved): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
  • inspector/front-end/Object.js: (WebInspector.Object.prototype.dispatchEventToListeners):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype._addBreakpoint):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointAdded): (WebInspector.ScriptsPanel.prototype._breakpointRemoved): (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback): (WebInspector.ScriptsPanel.prototype.editScriptSource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._contextMenu):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint): (WebInspector.SourceView.prototype._removeBreakpoint):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.restoredBreakpoint): (WebInspector.reset):
11:46 Changeset [60449] by apavlov@chromium.org
  • 4 edits in trunk/WebCore

2010-05-31 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, build fix.

Add references to inspector/front-end/TabbedPane.js wherever applicable.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/WebKit.qrc:
11:06 Changeset [60448] by apavlov@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2010-05-31 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, add a file not added in r60445.

  • inspector/front-end/TabbedPane.js: Added
10:31 Changeset [60447] by mrobinson@webkit.org
  • 4 edits
    1 add in trunk

2010-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Text copied from a WebView cannot be pasted into gnome-terminal
https://bugs.webkit.org/show_bug.cgi?id=39827

Switch all methods in Pasteboard to use the PasteboardHelper + DataObjectGtk
approach used in other parts of WebKit GTK+.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection): Switch to using PasteboardHelper. (WebCore::Pasteboard::writePlainText): Ditto. (WebCore::Pasteboard::writeURL): Ditto. (WebCore::Pasteboard::writeImage): Ditto. (WebCore::Pasteboard::clear): Small cleanup. (WebCore::Pasteboard::documentFragment): Switch to using PasteboardHelper. (WebCore::Pasteboard::plainText): Ditto.

2010-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Text copied from a WebView cannot be pasted into gnome-terminal
https://bugs.webkit.org/show_bug.cgi?id=39827

Add a test to prevent regressions for this issue.

  • tests/testcopyandpaste.c: Added. (test_info_new): (test_info_destroy): (copy_and_paste_fixture_setup): (copy_and_paste_fixture_teardown): (load_status_cb): (map_event_cb): (test_copy_and_paste): (main):
10:23 Changeset [60446] by darin@apple.com
  • 3 edits in trunk/WebCore

Updated bindings test results for change in JavaScript host calling convention change
from 2 days ago.

  • bindings/scripts/test/JS/JSTestObj.cpp: Regenerated and inspected to see that the new

result is correct.

  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
10:18 Changeset [60445] by apavlov@chromium.org
  • 5 edits in trunk/WebCore

2010-05-31 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Implement additional tabs support in ResourceView
https://bugs.webkit.org/show_bug.cgi?id=39822

  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectHeadersTab): (WebInspector.ResourceView.prototype._innerSelectContentTab):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.resize): (WebInspector.SourceView.prototype.updateLocalContent): (WebInspector.SourceView.prototype.selectLocalContentTab):
  • inspector/front-end/TabbedPane.js: Added. (WebInspector.TabbedPane): (WebInspector.TabbedPane.prototype.appendTab): (WebInspector.TabbedPane.prototype.tabObjectForId): (WebInspector.TabbedPane.prototype.hideTab): (WebInspector.TabbedPane.prototype.selectTabById):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype._getSelection):
  • inspector/front-end/inspector.html:
09:51 Changeset [60444] by dbates@webkit.org
  • 3 edits in trunk

2010-05-31 Daniel Bates <dbates@rim.com>

Unreviewed, add change log entries for change-set 60419 <http://trac.webkit.org/changeset/60419>
and change-set 60420 <http://trac.webkit.org/changeset/60420>.

I inadvertently didn't update the change log files when I committed
change-set 60419 and change-set 60420

09:45 Changeset [60443] by apavlov@chromium.org
  • 14 edits
    2 adds in trunk

2010-05-31 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Implement retrieval of CSS stylesheets for source editing
https://bugs.webkit.org/show_bug.cgi?id=39833

Test: inspector/styles-source-offsets.html

WebCore:

  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::createStyleRule):
  • css/CSSParser.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getStyleSheet): (WebCore::InspectorBackend::getRuleRangesForStyleSheetId):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::getRuleRangesForStyleSheet): (WebCore::InspectorCSSStore::asCSSStyleRule): (WebCore::InspectorCSSStore::styleSheetForId):
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyleSheet): (WebCore::InspectorDOMAgent::getRuleRangesForStyleSheetId): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule): (WebCore::InspectorDOMAgent::getParentStyleSheet):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetStyleSheet):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration):

LayoutTests:

  • inspector/styles-source-offsets-expected.txt: Added.
  • inspector/styles-source-offsets.html: Added.
09:36 Changeset [60442] by philn@webkit.org
  • 2 edits in trunk/WebCore

2010-05-31 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GStreamer] float variables misused
https://bugs.webkit.org/show_bug.cgi?id=38842

Use 0.0f for float variables instead of 0.0. Also added some
missing casts around GST_SECOND.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::playbackPosition): (WebCore::MediaPlayerPrivateGStreamer::duration): (WebCore::MediaPlayerPrivateGStreamer::currentTime): (WebCore::MediaPlayerPrivateGStreamer::seek): (WebCore::MediaPlayerPrivateGStreamer::naturalSize): (WebCore::MediaPlayerPrivateGStreamer::setRate): (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded): (WebCore::MediaPlayerPrivateGStreamer::totalBytes):
09:12 Changeset [60441] by steveblock@google.com
  • 6 edits
    3 deletes in trunk

Unreviewed, rolling out r60069.
http://trac.webkit.org/changeset/60069
https://bugs.webkit.org/show_bug.cgi?id=39288

Roll out r60069 while the need for Geolocation::stop() is
investigated.

WebCore:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/Geolocation.cpp:

(WebCore::Geolocation::disconnectFrame):

  • page/Geolocation.h:

LayoutTests:

  • fast/dom/Geolocation/ongoing-request-leak-expected.txt: Removed.
  • fast/dom/Geolocation/ongoing-request-leak.html: Removed.
  • fast/dom/Geolocation/script-tests/ongoing-request-leak.js: Removed.
  • platform/gtk/Skipped:
09:04 Changeset [60440] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-31 Olivier Tilloy <olivier@tilloy.net>

Reviewed by Gustavo Noronha Silva.

[Gtk] Implement RenderThemeGtk::systemColor to apply the correct colors
from the current GTK theme.
https://bugs.webkit.org/show_bug.cgi?id=37779

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::RenderThemeGtk::systemColor): (WebCore::RenderThemeGtk::gtkButton):
  • platform/gtk/RenderThemeGtk.h:
08:25 Changeset [60439] by krit@webkit.org
  • 4 edits
    4 adds in trunk

2010-05-31 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter: Crash if parent and child elements use the same filter
https://bugs.webkit.org/show_bug.cgi?id=39536

If a parent and a child used the same filter, the temporary saved
context reference got overwritten by the child. The reference is
stored in FilterData now. FilterData depends to the target object
and avoids overwriting any reference.

Test: svg/filters/parent-children-with-same-filter.svg

  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter): (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceFilter.h:

2010-05-31 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter: Crash if parent and child elements use the same filter
https://bugs.webkit.org/show_bug.cgi?id=39536

Check, that parent and child nodes can take the same filter without
crashing webkit.

  • platform/mac/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.png: Added.
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.txt: Added.
  • svg/filters/parent-children-with-same-filter.svg: Added.
08:12 Changeset [60438] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix all compiler warnings.

  • plugins/gtk/gtk2xtbin.c: (xt_event_dispatch): (gtk_xtbin_get_type): (gtk_xtbin_set_position): (xt_add_focus_listener): (xt_remove_focus_listener):
08:10 Changeset [60437] by xan@webkit.org
  • 2 edits in trunk

2010-05-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Copy the NEWS file to the toplevel when creating the release
tarballs, otherwise it's a bit hard to find.

  • GNUmakefile.am:
07:36 Changeset [60436] by yurys@chromium.org
  • 7 edits in trunk/WebKit/chromium

2010-05-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: allow hiding Scripts panel from Chromium code. This
is needed to support v8 debugging protocol which has an implementation
that conflicts with debugger provided by the inspector.
https://bugs.webkit.org/show_bug.cgi?id=39952

  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::exposeV8DebuggerProtocol):
  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::WebDevToolsFrontendClient): (WebKit::WebDevToolsFrontendClient::sendMessageToAgent): (WebKit::WebDevToolsFrontendClient::sendDebuggerCommandToAgent): (WebKit::WebDevToolsFrontendClient::sendDebuggerPauseScript): (WebKit::WebDevToolsFrontendClient::activateWindow): (WebKit::WebDevToolsFrontendClient::closeWindow): (WebKit::WebDevToolsFrontendClient::requestDockWindow): (WebKit::WebDevToolsFrontendClient::requestUndockWindow): (WebKit::WebDevToolsFrontendClient::hideScriptsPanel):
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugAttach): (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
  • src/DebuggerAgentManager.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::hiddenPanels):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::attach):
06:52 Changeset [60435] by hausmann@webkit.org
  • 5 edits in trunk

[Qt] Escape backslashes in the .pro files

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-05-31
Reviewed by Simon Hausmann.

qmake in Qt 4.7 warns about unescaped backspaces and deprecates them.

WebCore:

  • WebCore.pro:

WebKit/qt:

  • Api/DerivedSources.pro:
  • docs/docs.pri:
06:34 Changeset [60434] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-31 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Adler.

Make NodeList getters take AtomicString instead of plain String
https://bugs.webkit.org/show_bug.cgi?id=39892

Those methods turn String into AtomicString later. And this conversion
is faster if underlying string is already atomic.
That buys small (~2-3%) speed up for Chromium on Dromaeo DOM Core.
I don't know if Safari benefits from it.

  • dom/Node.cpp: (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS):
  • dom/Node.h:
06:08 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
01:05 Changeset [60433] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-31 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: update Chromium expectations for html5lib/runner.html

Update the Chromium version of runner-expected.txt after r60430

  • platform/chromium/html5lib/runner-expected.txt:
00:16 Changeset [60432] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-05-31 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Accessibility tests shouldn't rely on crazy <title> parsing
https://bugs.webkit.org/show_bug.cgi?id=39940

We have a separate test for crazy <title> parsing already in
fast/tokenizer. Also, this patch makes these tests pass with the HTML5
parser (and run in Firefox).

  • accessibility/image-link-inline-cont.html:
  • accessibility/image-link.html:
  • accessibility/inline-continuations.html:

05/30/10:

23:39 Changeset [60431] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-30 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: add failing test to Chromium test_expectations.txt

WK rev. 60386 added storage/transaction-success-callback-isolated-world.html
which fails in Chromium on all platforms.

  • platform/chromium/test_expectations.txt:
23:24 Changeset [60430] by eric@webkit.org
  • 5 edits in trunk

2010-05-30 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Fix LayoutTests/fast/parser/xml-declaration-missing-ending-mark.html in HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=39939

Add some tests for the bogus comment state.

  • html5lib/resources/comments01.dat:
  • html5lib/runner-expected.txt:

2010-05-30 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Fix LayoutTests/fast/parser/xml-declaration-missing-ending-mark.html in HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=39939

Turns out we need to implement the bogus comment state. :)

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
23:01 Changeset [60429] by rolandsteiner@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-05-30 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: rebaseline range-between-block-and-inline for Chromium.

Add rebaselined test expectations for Chromium Win & Linux for
editing/selection/range-between-block-and-inline.html

  • platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.checksum: Added.
  • platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.png: Added.
  • platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.txt: Added.
  • platform/chromium-win/editing/selection/range-between-block-and-inline-expected.checksum: Added.
  • platform/chromium-win/editing/selection/range-between-block-and-inline-expected.png: Added.
  • platform/chromium-win/editing/selection/range-between-block-and-inline-expected.txt: Added.
22:11 Changeset [60428] by rolandsteiner@chromium.org
  • 1 edit
    1 move
    2 deletes in trunk/LayoutTests

2010-05-30 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: fix Chromium test expectations.

Fix Chromium test expectations for html5lib/runner.html

  • platform/chromium-mac/html5lib/runner-expected.txt: Removed.
  • platform/chromium-win/html5lib/runner-expected.txt: Removed.
  • platform/chromium/html5lib/runner-expected.txt: Added.
  • platform/chromium/html5lib/webkit-runner-expected.txt: Removed.
21:07 Changeset [60427] by tkent@chromium.org
  • 8 edits
    2 adds in trunk/WebKitTools

2010-05-30 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

new-run-webkit-tests: Support DRT on Chromium-win
https://bugs.webkit.org/show_bug.cgi?id=39810

Add --test-shell flag to DRT/Chromium, and it changes DRT so that
it behaves like test_shell about command analysis, printing
format, pixel dumping, and timeout handling.

chromium.py and chromium_win.py supports the --test-shell flag and
DRT/Chromium-win binary names.

  • DumpRenderTree/DumpRenderTree.gypi: Add new files.
  • DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): Support for test_shell-style command. (main): Introduce --test-shell.
  • DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
  • DumpRenderTree/chromium/TestEventPrinter.h: Added. TestEventPrinter class manages stdio output and image output. TestEventPrinter.cpp has two implementations; DRTPrinter and TestShellPrinter.
  • DumpRenderTree/chromium/TestShell.cpp: Some changes for TestEventPrinter. (TestShell::TestShell): (TestShell::runFileTest): (TestShell::testTimedOut): (TestShell::dump): (TestShell::dumpImage):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::printer): (TestShell::layoutTestTimeout): (TestShell::layoutTestTimeoutForWatchDog): (TestShell::setLayoutTestTimeout):
  • DumpRenderTree/chromium/TestShellWin.cpp: (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
18:25 Changeset [60426] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

18:24 Changeset [60425] by mrowe@apple.com
  • 1 copy in tags/Safari-533.14

New tag.

18:23 Changeset [60424] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebKit/win

Merge r59912.

18:23 Changeset [60423] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch

Merge r59910.

18:04 Changeset [60422] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

fast/tokenizer/write-partial-entity.html hits ASSERT SegmentedString in the HTML5 Parser
https://bugs.webkit.org/show_bug.cgi?id=39935

Test: fast/tokenizer/write-partial-entity.html

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::executeScript):
    • Use m_source.append(oldInsertionPoint) instead of oldInsertionPoint.prepend(m_source) because m_source may have had characters pushed onto it and prepend() does not handle that case.
17:51 Changeset [60421] by eric@webkit.org
  • 12 edits in trunk

2010-05-30 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

This is a coding style cleanup before fixing to bug 35530.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

  • editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): (WebCore::Editor::fontForSelection): (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle): (WebCore::Editor::applyStyleToSelection): (WebCore::Editor::applyParagraphStyleToSelection): (WebCore::triStateOfStyleInComputedStyle): (WebCore::Editor::selectionStartHasStyle): (WebCore::Editor::selectionHasStyle): (WebCore::Editor::paste): (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::findFirstMisspellingInRange): (WebCore::findFirstGrammarDetailInRange): (WebCore::findFirstBadGrammarInRange): (WebCore::findFirstMisspellingOrBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::isRangeUngrammatical): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::guessesForMisspelledOrUngrammaticalRange): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • editing/EditorCommand.cpp: (WebCore::applyCommandToFrame): (WebCore::executeToggleStyleInList): (WebCore::executeApplyParagraphStyle): (WebCore::executeDelete): (WebCore::executeForwardDelete): (WebCore::executeInsertLineBreak): (WebCore::supportedCopyCut): (WebCore::supportedPaste): (WebCore::enabledDelete):
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRight): (WebCore::SelectionController::modifyExtendingForward): (WebCore::SelectionController::modifyMovingRight): (WebCore::SelectionController::modifyMovingForward): (WebCore::SelectionController::modifyExtendingLeft): (WebCore::SelectionController::modifyExtendingBackward): (WebCore::SelectionController::modifyMovingLeft): (WebCore::SelectionController::modifyMovingBackward): (WebCore::SelectionController::modify): (WebCore::SelectionController::xPosForVerticalArrowNavigation): (WebCore::SelectionController::debugRenderer):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::insertLineBreak): (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): (WebCore::TypingCommand::insertParagraphSeparator): (WebCore::TypingCommand::doApply): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::updatePreservesTypingStyle):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::canHandleDragAndDropForTarget): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::handleKeyboardSelectionMovement): (WebCore::EventHandler::handleDrag):

2010-05-30 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

This is a coding style cleanup before fixing to bug 35530.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::find): (WebKit::WebFrameImpl::scopeStringMatches): (WebKit::WebFrameImpl::createChildFrame): (WebKit::WebFrameImpl::shouldScopeMatches):

2010-05-30 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

This is a coding style cleanup before fixing to bug 35530.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2010-05-30 Lyon Chen <liachen@rim.com>

Reviewed by Kent Tamura.

This is a coding style cleanup before fixing to bug 35530.

Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::registerCommandForUndo): (WebCore::EditorClientQt::handleKeyboardEvent):
17:16 Changeset [60420] by dbates@webkit.org
  • 1 edit in trunk/WebKit/chromium/src/WebSearchableFormData.cpp

2010-05-30 Daniel Bates <dbates@rim.com>

Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.

I missed a few call sites in the Chromium source when I
landed http://trac.webkit.org/changeset/60419.

Credit to Chris Jerdonek for looking over both this patch and the patch
committed in r60419.

  • src/WebSearchableFormData.cpp: (WebCore::GetButtonToActivate): (WebCore::HasSuitableTextElement):
16:55 Changeset [60419] by dbates@webkit.org
  • 7 edits in trunk

2010-05-30 Daniel Bates <dbates@rim.com>

Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.

  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::isEnabledFormControl): (WebCore::HTMLFormControlElement::isReadOnlyFormControl): (WebCore::HTMLFormControlElement::isFormControlElement):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isPasswordField):

2010-05-30 Daniel Bates <dbates@rim.com>

Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::autofill):
  • src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::formControlName): (WebKit::WebFormControlElement::formControlType):
  • src/WebFormElement.cpp: (WebKit::WebFormElement::getFormControlElements):
  • src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields):

2010-05-30 Daniel Bates <dbates@rim.com>

Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.

  • WebFrame.cpp: (WebFrame::elementWithName): (WebFrame::controlsInForm):
14:49 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
14:22 Changeset [60418] by darin@apple.com
  • 57 edits in trunk

2010-05-30 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Make more HTML DOM members private, especially constructors, third and final batch
https://bugs.webkit.org/show_bug.cgi?id=39916

  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementWithName:inForm:]): Use the new HTMLFormElement function, associatedElements, rather than getting directly at a data member named formElements. (-[WebHTMLRepresentation controlsInForm:]): Ditto.

2010-05-30 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Make more HTML DOM members private, especially constructors, third and final batch
https://bugs.webkit.org/show_bug.cgi?id=39916

  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
  • editing/EditorCommand.cpp: (WebCore::executeInsertHorizontalRule): (WebCore::executeInsertImage):
  • editing/htmlediting.cpp: (WebCore::createDefaultParagraphElement): (WebCore::createListItemElement):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::headCreateErrorCheck): (WebCore::HTMLParser::formCreateErrorCheck): (WebCore::HTMLParser::createHead): (WebCore::HTMLParser::handleIsindex): (WebCore::HTMLParser::finished):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): Use create instead of new to create HTML elements.
  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): (WebCore::HTMLFormCollection::item): (WebCore::HTMLFormCollection::getNamedFormItem): (WebCore::HTMLFormCollection::updateNameCache):
  • html/HTMLFormControlElement.h: Updated for name and privacy changes in HTMLFormElement.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::create): (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::length): (WebCore::HTMLFormElement::submitImplicitly): (WebCore::HTMLFormElement::createFormData): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::reset): (WebCore::HTMLFormElement::formElementIndex): (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement): (WebCore::HTMLFormElement::registerImgElement): (WebCore::HTMLFormElement::removeImgElement): (WebCore::HTMLFormElement::defaultButton): (WebCore::HTMLFormElement::collectUnhandledInvalidControls): (WebCore::HTMLFormElement::addElementAlias): (WebCore::HTMLFormElement::documentDidBecomeActive):
  • html/HTMLFormElement.h: Added create functions. Made constructors and other members private. Used an OwnPtr for m_elementAliases. Renamed collectionInfo to m_collectionCache and used an OwnPtr for it. Renamed formElements to m_associatedElements (since its contents are what HTML5 calls "form-associated element", not form elements). Renamed imgElements to m_imageElements.
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::HTMLFrameSetElement): (WebCore::HTMLFrameSetElement::create): (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  • html/HTMLFrameSetElement.h: Added create functions. Made constructors and other members private. Renamed m_rows and m_cols to m_rowLengths and m_colLengths and used OwnArrayPtr for both.
  • html/HTMLLabelElement.cpp: (WebCore::nodeAsLabelableFormControl): Made this cast to Element instead of HTMLElement, since isFormControlElement is available on Element. (WebCore::HTMLLabelElement::HTMLLabelElement): (WebCore::HTMLLabelElement::create):
  • html/HTMLLabelElement.h: Added create functions. Made constructors and other members private.
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::HTMLLegendElement): (WebCore::HTMLLegendElement::create): (WebCore::HTMLLegendElement::associatedControl): (WebCore::HTMLLegendElement::focus): (WebCore::HTMLLegendElement::accessKeyAction):
  • html/HTMLLegendElement.h: Added create functions. Made constructors and other members private. Renamed formElement to associatedControl since hte control associated with this legend is not a "form element".
  • editing/DeleteButton.cpp: (WebCore::DeleteButton::DeleteButton): (WebCore::DeleteButton::create):
  • editing/DeleteButton.h:
  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::HTMLDivElement): (WebCore::HTMLDivElement::create):
  • html/HTMLDivElement.h:
  • html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::create):
  • html/HTMLFontElement.h:
  • html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::HTMLHRElement): (WebCore::HTMLHRElement::create):
  • html/HTMLHRElement.h:
  • html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::HTMLHeadElement): (WebCore::HTMLHeadElement::create):
  • html/HTMLHeadElement.h:
  • html/HTMLHeadingElement.cpp: (WebCore::HTMLHeadingElement::HTMLHeadingElement): (WebCore::HTMLHeadingElement::create):
  • html/HTMLHeadingElement.h:
  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::HTMLHtmlElement): (WebCore::HTMLHtmlElement::create):
  • html/HTMLHtmlElement.h:
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::HTMLImageElement): (WebCore::HTMLImageElement::create):
  • html/HTMLImageElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): (WebCore::HTMLInputElement::create): (WebCore::HTMLInputElement::createTemporaryFormForIsIndex):
  • html/HTMLInputElement.h:
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::HTMLIsIndexElement): (WebCore::HTMLIsIndexElement::create):
  • html/HTMLIsIndexElement.h:
  • html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::HTMLLIElement): (WebCore::HTMLLIElement::create):
  • html/HTMLLIElement.h:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::create):
  • html/HTMLLinkElement.h: Added create functions. Made constructors and other members private.
  • html/HTMLTagNames.in: Removed the createWithNew flag from all the tags that were still using it: div, font, form, frameset, h1, h2, h3, h4, h5, h6, head, hr, html, image, img, input, ins, isindex, label, legend, li, and link.
  • html/HTMLTextAreaElement.h: Removed unneeded definition of the readOnly function, since the one in HTMLFormElement does the same thing.
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentElement::ImageDocumentElement): (WebCore::ImageDocumentElement::create): (WebCore::ImageDocument::createDocumentStructure): Added create functions. Made constructors and other members private.
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Use the non-virtual disabled function instead of the virtual isEnabledFormControl function, which just turns around and calls the disabled function.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): (WebCore::MediaControlShadowRootElement::create): (WebCore::MediaControlElement::MediaControlElement): (WebCore::MediaControlElement::create): (WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement): (WebCore::MediaControlTimelineContainerElement::create): (WebCore::MediaControlTimelineContainerElement::rendererIsNeeded): (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): (WebCore::MediaControlVolumeSliderContainerElement::create): (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement): (WebCore::MediaControlStatusDisplayElement::create): (WebCore::MediaControlStatusDisplayElement::update): (WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlInputElement::styleForElement): (WebCore::MediaControlInputElement::rendererIsNeeded): (WebCore::MediaControlInputElement::attach): (WebCore::MediaControlInputElement::updateStyle): (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): (WebCore::MediaControlMuteButtonElement::create): (WebCore::MediaControlMuteButtonElement::defaultEventHandler): (WebCore::MediaControlMuteButtonElement::updateDisplayType): (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): (WebCore::MediaControlPlayButtonElement::create): (WebCore::MediaControlPlayButtonElement::defaultEventHandler): (WebCore::MediaControlPlayButtonElement::updateDisplayType): (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): (WebCore::MediaControlSeekButtonElement::create): (WebCore::MediaControlSeekButtonElement::isForwardButton): (WebCore::MediaControlSeekButtonElement::defaultEventHandler): (WebCore::MediaControlSeekButtonElement::seekTimerFired): (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): (WebCore::MediaControlRewindButtonElement::create): (WebCore::MediaControlRewindButtonElement::defaultEventHandler): (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): (WebCore::MediaControlReturnToRealtimeButtonElement::create): (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): (WebCore::MediaControlToggleClosedCaptionsButtonElement::create): (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler): (WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlTimelineElement::create): (WebCore::MediaControlTimelineElement::defaultEventHandler): (WebCore::MediaControlTimelineElement::update): (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): (WebCore::MediaControlVolumeSliderElement::create): (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): (WebCore::MediaControlVolumeSliderElement::update): (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): (WebCore::MediaControlFullscreenButtonElement::create): (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): (WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement): (WebCore::MediaControlTimeDisplayElement::create):
  • rendering/MediaControlElements.h: Added create functions. Made constructors and other members private.
  • rendering/RenderFileUploadControl.cpp: (WebCore::ShadowInputElement::ShadowInputElement): (WebCore::ShadowInputElement::create): (WebCore::RenderFileUploadControl::updateFromElement): Added create functions. Made constructors and other members private.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createControlsShadowRoot): (WebCore::RenderMedia::createPanel): (WebCore::RenderMedia::createMuteButton): (WebCore::RenderMedia::createPlayButton): (WebCore::RenderMedia::createSeekBackButton): (WebCore::RenderMedia::createSeekForwardButton): (WebCore::RenderMedia::createRewindButton): (WebCore::RenderMedia::createReturnToRealtimeButton): (WebCore::RenderMedia::createToggleClosedCaptionsButton): (WebCore::RenderMedia::createStatusDisplay): (WebCore::RenderMedia::createTimelineContainer): (WebCore::RenderMedia::createTimeline): (WebCore::RenderMedia::createVolumeSliderContainer): (WebCore::RenderMedia::createVolumeSlider): (WebCore::RenderMedia::createCurrentTimeDisplay): (WebCore::RenderMedia::createTimeRemainingDisplay): (WebCore::RenderMedia::createFullscreenButton): Use create instead of new.
  • rendering/RenderProgress.cpp: (WebCore::ProgressValueElement::ProgressValueElement): (WebCore::ProgressValueElement::create): (WebCore::RenderProgress::updateValuePartState):
  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::SliderThumbElement): (WebCore::SliderThumbElement::create): (WebCore::RenderSlider::updateFromElement): Added create functions. Made constructors and other members private.
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement): (WebCore::TextControlInnerElement::create): (WebCore::TextControlInnerTextElement::TextControlInnerTextElement): (WebCore::TextControlInnerTextElement::create): (WebCore::TextControlInnerTextElement::defaultEventHandler): (WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement): (WebCore::SearchFieldResultsButtonElement::create): (WebCore::SearchFieldResultsButtonElement::defaultEventHandler): (WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement): (WebCore::SearchFieldCancelButtonElement::create): (WebCore::SearchFieldCancelButtonElement::defaultEventHandler): (WebCore::SpinButtonElement::SpinButtonElement): (WebCore::SpinButtonElement::create): (WebCore::SpinButtonElement::defaultEventHandler):
  • rendering/TextControlInnerElements.h: Added create functions. Made constructors and other members private.
11:27 Changeset [60417] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore
  • wtf/OwnArrayPtr.h:

(WTF::OwnArrayPtr::set): Fix the assertion in here to match the one in OwnPtr.
At some point someone fixed the "asserts when assigning to 0 and the pointer is
already 0" issue in OwnPtr but forgot to do it here.

Reviewed by Sam Weinig.

11:10 Changeset [60416] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-05-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Darin Adler.

Incorrect build dependencies for GObject DOM Bindings
https://bugs.webkit.org/show_bug.cgi?id=39932

-include does not execute the implicit % expansion, we have to do
it manually.

  • GNUmakefile.am:
10:53 Changeset [60415] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2010-05-30 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enhance Qt DRT implementation to support platform scroll wheel events.

https://bugs.webkit.org/show_bug.cgi?id=36004

Unskip:

fast/events/remove-child-onscroll.html
fast/events/platform-wheelevent-in-scrolling-div.html
fast/events/continuous-platform-wheelevent-in-scrolling-div.html

Add platform-specific results for Qt. Required because QWheelEvent only supports sending an event
for scrolling movement one axis at a time. Naturally the test's check for the axis the event does
not pertain to will 'fail' in such cases. So we get 6 lines of output in total, i.e.:

FAIL event.wheelDeltaY should be -24000. Was 0.
PASS event.wheelDeltaX is window.expectedScrollLeft*-120
PASS event.wheelDelta is window.expectedScrollLeft*-120

and then:

PASS event.wheelDeltaY is window.expectedScrollTop*-120
FAIL event.wheelDeltaX should be -12000. Was 0.
PASS event.wheelDelta is window.expectedScrollTop*-120

instead of just 3 like Mac:

PASS event.wheelDeltaY is window.expectedScrollTop*-120
PASS event.wheelDeltaX is window.expectedScrollLeft*-120
PASS event.wheelDelta is window.expectedScrollTop*-120

  • platform/qt-linux/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Added.
  • platform/qt-linux/fast/events/platform-wheelevent-in-scrolling-div-expected.txt: Added.
  • platform/qt/Skipped:

2010-05-30 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enhance Qt DRT implementation to support platform scroll wheel events.

https://bugs.webkit.org/show_bug.cgi?id=36004

Fix the bug in webkit.org/b/29601 for Qt. A delta not divisible by 120
indicates a device that is sending fine-resolution scroll events, so
use the delta as the number of pixels to scroll.

  • platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::applyDelta):

2010-05-30 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enhance Qt DRT implementation to support platform scroll wheel events.

https://bugs.webkit.org/show_bug.cgi?id=36004

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match

Scrollbar::pixelsPerLineStep() for DRT testing.

(EventSender::mouseScrollBy): Added
(EventSender::continuousMouseScrollBy): Added

  • DumpRenderTree/qt/EventSenderQt.h:
06:16 Changeset [60414] by jberlin@webkit.org
  • 19 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=39224
Bug 39224 - Web Inspector: There should be a way to clean up profiles

Reviewed by Pavel Feldman.

WebCore:

Adds a button to clear the profiles from the profiles panel like that
used for the console, the audits panel, and the timeline panel.
Consolidates the css rules, since they all use the same image.
Also allows for individual profiles to be deleted via the keyboard
(U+0008 or U+007F) and uses this new schema for the Elements Tree.

  • English.lproj/localizedStrings.js:

Add tooltip text for the button to clear the profiles pane.

  • inspector/InspectorBackend.idl:

Add ability to remove the profiles from the backend when they are
deleted or cleared in the frontend.

  • inspector/InspectorBackend.cpp:

(WebCore::InspectorBackend::removeProfile):
(WebCore::InspectorBackend::clearProfiles):

  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::removeProfile):
(WebCore::InspectorController::clearProfiles):

  • inspector/InspectorController.h:
  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):
Use the 'clear-status-bar-item' class.

  • inspector/front-end/ChangesView.js:

(WebInspector.ChangesView):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createStatusbarButtons):

  • inspector/front-end/audits.css:
  • inspector/front-end/inspector.css:

(.clear-status-bar-item .glyph):

  • inspector/front-end/inspector.html:
  • inspector/front-end/ElementsTreeOutline.js:

Replace the keyDown handler on the Outline with specific methods to
handle delete and enter on the TreeElements.
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype.get editing):
Return whether or not an element in the tree is currently being edited.
(WebInspector.ElementsTreeElement.prototype.ondelete):
(WebInspector.ElementsTreeElement.prototype.onenter):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.createSidebar):
Make the TreeOutline for a Panel's sidebar aware of its enclosing Panel.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):
Add the clear button.
(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype._clearProfiles):
Remove the profiles from the backend, the reset the frontend interface.
(WebInspector.ProfilesPanel.prototype.removeProfileHeader):
Remove the profile from both the frontend and the backend, and clear the
view when the last profile is removed.
(WebInspector.ProfilesPanel.prototype._updateInterface):
Hide the clear button when profiling is disabled.
(WebInspector.ProfileSidebarTreeElement.prototype.onselect):
Replace access to global variable with reference to the Panel held by the
TreeOutline.
(WebInspector.ProfileSidebarTreeElement.prototype.ondelete):
Remove the profile corresponding the tree element when the user deletes
that tree element.

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype._treeKeyDown):
Allow the selected tree element to handle the user pressing a delete
key or enter key.

WebKit/chromium:

  • src/js/InspectorControllerImpl.js:

(devtools.InspectorBackendImpl):

Note: See TracTimeline for information about the timeline view.