Timeline



Jun 5, 2010:

11:53 PM Changeset in webkit [60757] by tkent@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed, test expectation fix.

Add image results of tests added by r60752 for Chromium.

  • platform/chromium-mac/svg/custom/fill-opacity-hsl-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/fill-opacity-hsl-expected.png: Added.
  • platform/chromium-mac/svg/custom/fill-opacity-rgba-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/fill-opacity-rgba-expected.png: Added.
9:27 PM Changeset in webkit [60756] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

<rdar://problem/8063622> Failure to launch WebProcess.app when framework is outside of the build directory

Rubber-stamped by Dan Bernstein.

  • Configurations/WebProcess.xcconfig:
1:35 PM Changeset in webkit [60755] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, typo/build fix.

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8SQLStatementErrorCallback::handleEvent):

1:19 PM Changeset in webkit [60754] by dumi@chromium.org
  • 4 edits in trunk/WebCore

Do not pass empty handles to v8.
https://bugs.webkit.org/show_bug.cgi?id=39896

Reviewed by Adam Barth.

Passing an empty handle to v8 results in a crash with a stack
trace that doesn't give us much information about the cause of the
crash. Instead, if we check the handles we pass to v8 and crash
when they are empty, we do not make things worse, and should get a
more informative stack trace.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8SQLStatementErrorCallback::handleEvent):

8:21 AM Changeset in webkit [60753] by tonikitoo@webkit.org
  • 20 edits in trunk/WebCore

2010-05-30 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Darin Adler.

Add a convenient helper getter for Frame* to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=39928

document()->frame() is being called enough from RenderObject derivated classes
that it worth adding a helper Frame getter as a shortcut.

No behavior change, so no new tests.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isOffScreen): (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::selection): (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange):
  • page/EventHandler.cpp: (WebCore::canAutoscroll):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintCustomHighlight): (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::isActive):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::flattenFrameSet):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRings):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::addDashboardRegions):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::panScrollFromPoint): (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::isActive): (showLayerTree):
  • rendering/RenderLayerBacking.cpp: (WebCore::inspectorTimelineAgent):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground): (WebCore::RenderListBox::panScroll): (WebCore::RenderListBox::autoscroll): (WebCore::RenderListBox::isActive):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::~RenderObject): (WebCore::RenderObject::selectionBackgroundColor): (WebCore::RenderObject::selectionForegroundColor): (WebCore::RenderObject::destroy): (WebCore::RenderObject::addDashboardRegions): (WebCore::RenderObject::animation):
  • rendering/RenderObject.h: (WebCore::RenderObject::document): (WebCore::RenderObject::frame):
7:29 AM Changeset in webkit [60752] by eric@webkit.org
  • 6 edits
    8 adds in trunk

2010-06-05 Jonathan Kliegman <kliegs@chromium.org>

Reviewed by Dirk Schulze.

SVG doesn't support rgba colors
https://bugs.webkit.org/show_bug.cgi?id=16183

Enabled processing of rgba, hsl and hsla color specifications
for SVG files. SVG spec calls for CSS2 but common usage and
other browsers suppor CSS3 colors being used in SVG files

  • platform/mac/svg/custom/fill-opacity-hsl-expected.checksum: Added.
  • platform/mac/svg/custom/fill-opacity-hsl-expected.png: Added.
  • platform/mac/svg/custom/fill-opacity-hsl-expected.txt: Added.
  • platform/mac/svg/custom/fill-opacity-rgba-expected.checksum: Added.
  • platform/mac/svg/custom/fill-opacity-rgba-expected.png: Added.
  • platform/mac/svg/custom/fill-opacity-rgba-expected.txt: Added.
  • svg/custom/fill-opacity-hsl.svg: Added.
  • svg/custom/fill-opacity-rgba.svg: Added.

2010-06-05 Jonathan Kliegman <kliegs@chromium.org>

Reviewed by Dirk Schulze.

SVG doesn't support rgba colors
https://bugs.webkit.org/show_bug.cgi?id=16183

Enabled processing of rgba, hsl and hsla color specifications
for SVG files. SVG spec calls for CSS2 but common usage and
other browsers suppor CSS3 colors being used in SVG files

Removed unused svg paramater from CSSParser::parseColorFromValue

Tests: svg/custom/fill-opacity-hsl.svg

svg/custom/fill-opacity-rgba.svg

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColorFromValue):
  • css/CSSParser.h:
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • svg/SVGColor.cpp: (WebCore::SVGColor::colorFromRGBColorString):
5:15 AM Changeset in webkit [60751] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ContextMenuItemQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39780

  • platform/qt/ContextMenuItemQt.cpp:
5:03 AM Changeset in webkit [60750] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ContextMenuQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39779

  • platform/qt/ContextMenuQt.cpp:
4:50 AM Changeset in webkit [60749] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] DragDataQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39777

  • platform/qt/DragDataQt.cpp:
4:04 AM Changeset in webkit [60748] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] FileChooserQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39776

  • platform/qt/FileChooserQt.cpp:
3:52 AM Changeset in webkit [60747] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] FileSystemQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39775

  • platform/qt/FileSystemQt.cpp:
3:27 AM Changeset in webkit [60746] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] KURLQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39774

  • platform/qt/KURLQt.cpp:
3:12 AM Changeset in webkit [60745] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] LoggingQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39772

  • platform/qt/LoggingQt.cpp:
3:00 AM Changeset in webkit [60744] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] PlatformKeyboardEventQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39770

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2:00 AM Changeset in webkit [60743] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] PlatformScreenQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39768

  • platform/qt/PlatformMouseEventQt.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1:28 AM Changeset in webkit [60742] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] RenderThemeQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39767

  • platform/qt/RenderThemeQt.cpp:
12:52 AM Changeset in webkit [60741] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-05 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ScrollbarQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39765

  • platform/qt/ScrollbarQt.cpp:
12:40 AM Changeset in webkit [60740] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-05 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add PLATFORM(BREWMP) guard for using std::xxx
https://bugs.webkit.org/show_bug.cgi?id=39710

Build fix for BREW MP.

  • wtf/MathExtras.h:

Jun 4, 2010:

11:57 PM Changeset in webkit [60739] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048

This patch changes us from using a jump table for each character to
using absolute jumps between parser states. This appears to be about a
1% improvement on the parser bench mark (which is 1/10th of what we
need to catch the old parser).

I've kept the underlying logic as close to the old logic as possible.
This new form will make it easier to handle the input stream part of
the spec and to make further performance improvements.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::reset): (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitCurrentToken):
  • html/HTML5Lexer.h:
11:25 PM Changeset in webkit [60738] by abarth@webkit.org
  • 7 edits in trunk

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

HTML5 parser should be within 1% of old parser performance
https://bugs.webkit.org/show_bug.cgi?id=40172

Fix cast in this operator= to allow for assignment between vectors with
different inline capacities (as clearly intended by its author).

  • wtf/Vector.h: (WTF::::operator):

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

HTML5 parser should be within 1% of old parser performance
https://bugs.webkit.org/show_bug.cgi?id=40172

Stop using adopt(). I think this function is cause us to do extra
mallocs that are hurting performance. Instead of caching AtomicString
on HTML5Token, just use the AtomicString on the old token. Also,
reserve inline capacity for 10 attributes.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::isAppropriateEndTag):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::beginStartTag): (WebCore::HTML5Token::beginEndTag): (WebCore::HTML5Token::beginCharacter): (WebCore::HTML5Token::beginComment): (WebCore::HTML5Token::beginDOCTYPE): (WebCore::HTML5Token::name): (WebCore::HTML5Token::characters): (WebCore::HTML5Token::comment):
  • html/HTML5TreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
11:07 PM Changeset in webkit [60737] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ScrollbarThemeQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39764

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::scPart): (WebCore::scrollbarPart): (WebCore::styleOptionSlider):
10:51 PM Changeset in webkit [60736] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] SharedTimerQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39763

  • platform/qt/SharedTimerQt.cpp:
10:39 PM Changeset in webkit [60735] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

WidgetQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39759

  • platform/qt/WidgetQt.cpp:
10:27 PM Changeset in webkit [60734] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

TemporaryLinkStubsQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39761

  • platform/qt/TemporaryLinkStubsQt.cpp:
10:14 PM Changeset in webkit [60733] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] SoundQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39762

  • platform/qt/SoundQt.cpp:
9:53 PM Changeset in webkit [60732] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-04 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Ojan Vafai.

Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
https://bugs.webkit.org/show_bug.cgi?id=40183

  • Scripts/webkitpy/tool/steps/preparechangelog.py:
9:41 PM Changeset in webkit [60731] by eric@webkit.org
  • 5 edits in trunk

2010-06-04 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Dirk Schulze.

Canvas createPattern(img, repetition) shouldn't throw INVALID_STATE_ERR when !img.complete
https://bugs.webkit.org/show_bug.cgi?id=40166

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createpattern

  • http/tests/misc/canvas-pattern-from-incremental-image-expected.txt: Updated baseline.
  • http/tests/misc/canvas-pattern-from-incremental-image.html: Fleshed out test.

2010-06-04 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Dirk Schulze.

Canvas createPattern(img, repetition) shouldn't throw INVALID_STATE_ERR when !img.complete
https://bugs.webkit.org/show_bug.cgi?id=40166

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-createpattern

Test: http/tests/misc/canvas-pattern-from-incremental-image.html (updated)

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
8:52 PM Changeset in webkit [60730] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Anders Bakken <agbakken@gmail.com>

Reviewed by David Levin.

[Qt] Localizations.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39773

  • platform/qt/Localizations.cpp: (WebCore::localizedMediaTimeDescription):
8:40 PM Changeset in webkit [60729] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Lyon Chen <liachen@rim.com>

Reviewed by Darin Adler.

ApplicationCacheStorage::storeNewestCache() Crash WebKit when openDatabase(true) failed
https://bugs.webkit.org/show_bug.cgi?id=40074

Adding m_database.isOpen() check for every openDatabase(true) call, this is needed because
openDatabase(true) could still fail, for example when cacheStorage is full or no longer available.

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): (WebCore::ApplicationCacheStorage::storeNewestCache):
6:28 PM Changeset in webkit [60728] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60684.
http://trac.webkit.org/changeset/60684
https://bugs.webkit.org/show_bug.cgi?id=40196

This patch broke chromium reliability tests (Requested by
tonyg-cr on #webkit).

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
6:21 PM WebKit Team edited by dumi@chromium.org
(diff)
6:12 PM Changeset in webkit [60727] by Chris Fleizach
  • 6 edits
    2 adds in trunk

AX: need an aria-help
https://bugs.webkit.org/show_bug.cgi?id=40010

Reviewed by David Kilzer.

WebCore:

Test: accessibility/aria-help.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::helpText):

  • html/HTMLAttributeNames.in:

LayoutTests:

  • accessibility/aria-help-expected.txt: Added.
  • accessibility/aria-help.html: Added.
  • platform/gtk/Skipped:
  • platform/win/Skipped:
5:43 PM Changeset in webkit [60726] by eric@webkit.org
  • 4 edits in trunk

2010-06-04 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Canvas arc() with zero radius should draw a line to the start point
https://bugs.webkit.org/show_bug.cgi?id=40164

Unskip canvas/philip/tests/2d.path.arc.zeroradius.html

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc

  • platform/qt/Skipped:

2010-06-04 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Canvas arc() with zero radius should draw a line to the start point
https://bugs.webkit.org/show_bug.cgi?id=40164

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
5:23 PM Changeset in webkit [60725] by eric@webkit.org
  • 6 edits in trunk/JavaScriptCore

2010-06-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

New QtScript API; QScriptValue::instanceOf.

New function create an easy way to check value's prototype hierarchy.

[Qt] QScriptValue should have an instanceOf method
https://bugs.webkit.org/show_bug.cgi?id=40120

  • qt/api/qscriptvalue.cpp: (QScriptValue::instanceOf):
  • qt/api/qscriptvalue.h:
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::instanceOf):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: (tst_QScriptValue::instanceOf_initData): (tst_QScriptValue::instanceOf_makeData): (tst_QScriptValue::instanceOf_test):
5:12 PM Changeset in webkit [60724] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] RenderThemeGtk leaks memory
https://bugs.webkit.org/show_bug.cgi?id=40168

Call gtk_widget_destroy in the RenderThemeGtk destructor. This cleans
up all widget resources when a theme is destroyed.

No new tests, because functionality has not changed.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::~RenderThemeGtk): Call gtk_widget_destroy on m_gtkWindow.
5:11 PM Changeset in webkit [60723] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] RenderThemeGtk leaks memory
https://bugs.webkit.org/show_bug.cgi?id=40168

Remove the use of releaseRef to assign a value to a RefPtr. This results in
the original pointer taking an extra reference.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::initMediaStyling): Remove the use of releaseRef here.
5:10 PM Changeset in webkit [60722] by alice.liu@apple.com
  • 8 edits in trunk/WebKit/win

WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars
https://bugs.webkit.org/show_bug.cgi?id=40034
<rdar://problem/7799848>

Reviewed by Jon Honeycutt.

  • WebFrame.cpp:

(WebFrame::paintScrollViewRectToContextAtPoint): Renamed from paintDocumentRectToContextAtPoint.
Call paint() instead of paintContents(). Also move the dirtyRect to counteract the moving that happens in paint().

Just renaming changes:

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/IWebViewPrivate.idl:
  • WebFrame.h:
  • WebView.cpp:

(WebView::paintScrollViewRectToContextAtPoint):

  • WebView.h:
  • Interfaces/WebKit.idl: Touched for rebuild.
4:54 PM Changeset in webkit [60721] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

Added a couple of symbols needed to start using WKFrameRefs in Mac clients.

Rubber-stamped by Ada Chan.

  • mac/WebKit2.exp:

Added _WKFrameRelease and _WKFrameRetain.

4:38 PM Changeset in webkit [60720] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

Reviewed by NOBODY (interpreter build fix).

4:20 PM Changeset in webkit [60719] by abarth@webkit.org
  • 1 edit in trunk/WebCore/html/HTML5Lexer.cpp

Actually disable the correct warning.

4:11 PM Changeset in webkit [60718] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-04 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Add my new email and IRC nick to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
4:08 PM Changeset in webkit [60717] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Gavin Barraclough.

Try to fix the windows build
https://bugs.webkit.org/show_bug.cgi?id=40189

Suppress the "unreachable code" warning because we want to assert that
we don't reach certain code points.

  • html/HTML5Lexer.cpp:
3:57 PM Changeset in webkit [60716] by mrowe@apple.com
  • 5 edits in trunk/JavaScriptCore

Silence some warnings seen on the build bot.

complain about not knowing how to compile them.

3:51 PM Changeset in webkit [60715] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-04 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Skipping another test which shows 1-pixel differences between the
32-bit and 64-bit bot.

  • platform/gtk/Skipped:
3:48 PM Changeset in webkit [60714] by kinuko@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-04 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed.

Revert changes in json_results_generator.py's _get_svn_revision.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3:19 PM Changeset in webkit [60713] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] GtkLauncher should support relative file paths
https://bugs.webkit.org/show_bug.cgi?id=39944

Allow GtkLauncher to handle relative file paths passed via command-line arguments.

  • GtkLauncher/main.c: (filename_to_url): Added. (main): Try to resolve arguments as relative file URLs first.
3:12 PM Changeset in webkit [60712] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048

A couple more cases like the previous patch that I missed.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
2:56 PM Changeset in webkit [60711] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048

Make all the state transitions in the machine explicit. This allows us
to remove all the break statements, which won't work correctly after we
change the macro definitions.

Also, while I was looking at every line of code, I fixed a bunch of the
one-line-if style errors introduces in my previous patches.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
2:56 PM Changeset in webkit [60710] by mrobinson@webkit.org
  • 1 edit
    20 adds in trunk/LayoutTests

2010-06-04 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests. They all seem to be working fine.

  • platform/gtk/editing/selection/range-between-block-and-inline-expected.txt: Added.
  • platform/gtk/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
  • platform/gtk/fast/lists/alpha-boundary-values-expected.txt: Added.
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
  • platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
  • platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
  • platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
  • platform/gtk/svg/filters/feLighting-crash-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/feLighting-crash-expected.txt.
  • platform/gtk/svg/filters/parent-children-with-same-filter-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/parent-children-with-same-filter-expected.txt.
2:47 PM Changeset in webkit [60709] by mrobinson@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Drag gesture can take mouse grab indefinitely
https://bugs.webkit.org/show_bug.cgi?id=32840

Initiate drag events with the current GTK+ event instead of synthesizing
an event. Something about synthesized events is causing a drag freeze in
certain situations.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Start the drag with the current GTK+ event.
2:38 PM Changeset in webkit [60708] by barraclough@apple.com
  • 45 edits in trunk

Bug 40187 - Change function signature of NativeConstructor to match NativeFunction

Reviewed by Oliver Hunt.

Mostly for consistency, but constructor & args arguments are redundant,
and this will help if we wish to be able to JIT calls to more constructors.

JavaScriptCore:

  • API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::construct):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::executeConstruct):

  • interpreter/Interpreter.h:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/ArrayConstructor.cpp:

(JSC::constructWithArrayConstructor):

  • runtime/BooleanConstructor.cpp:

(JSC::constructWithBooleanConstructor):

  • runtime/ConstructData.cpp:

(JSC::construct):

  • runtime/ConstructData.h:
  • runtime/DateConstructor.cpp:

(JSC::constructWithDateConstructor):

  • runtime/Error.cpp:

(JSC::constructNativeError):
(JSC::Error::create):

  • runtime/ErrorConstructor.cpp:

(JSC::constructWithErrorConstructor):

  • runtime/FunctionConstructor.cpp:

(JSC::constructWithFunctionConstructor):

  • runtime/NativeErrorConstructor.cpp:

(JSC::constructWithNativeErrorConstructor):

  • runtime/NativeErrorConstructor.h:

(JSC::NativeErrorConstructor::errorStructure):

  • runtime/NumberConstructor.cpp:

(JSC::constructWithNumberConstructor):

  • runtime/ObjectConstructor.cpp:

(JSC::constructWithObjectConstructor):

  • runtime/RegExpConstructor.cpp:

(JSC::constructWithRegExpConstructor):

  • runtime/StringConstructor.cpp:

(JSC::constructWithStringConstructor):

WebCore:

  • bindings/js/JSArrayBufferConstructor.cpp:

(WebCore::constructCanvasArrayBuffer):

  • bindings/js/JSAudioConstructor.cpp:

(WebCore::constructAudio):

  • bindings/js/JSEventSourceConstructor.cpp:

(WebCore::constructEventSource):

  • bindings/js/JSFloatArrayConstructor.cpp:

(WebCore::constructCanvasFloatArray):

  • bindings/js/JSImageConstructor.cpp:

(WebCore::constructImage):

  • bindings/js/JSInt16ArrayConstructor.cpp:

(WebCore::constructCanvasShortArray):

  • bindings/js/JSInt32ArrayConstructor.cpp:

(WebCore::constructCanvasIntArray):

  • bindings/js/JSInt8ArrayConstructor.cpp:

(WebCore::constructCanvasByteArray):

  • bindings/js/JSMessageChannelConstructor.cpp:

(WebCore::JSMessageChannelConstructor::construct):

  • bindings/js/JSMessageChannelConstructor.h:
  • bindings/js/JSOptionConstructor.cpp:

(WebCore::constructHTMLOptionElement):

  • bindings/js/JSSharedWorkerConstructor.cpp:

(WebCore::constructSharedWorker):

  • bindings/js/JSUint16ArrayConstructor.cpp:

(WebCore::constructCanvasUnsignedShortArray):

  • bindings/js/JSUint32ArrayConstructor.cpp:

(WebCore::constructCanvasUnsignedIntArray):

  • bindings/js/JSUint8ArrayConstructor.cpp:

(WebCore::constructCanvasUnsignedByteArray):

  • bindings/js/JSWebKitCSSMatrixConstructor.cpp:

(WebCore::constructWebKitCSSMatrix):

  • bindings/js/JSWebKitPointConstructor.cpp:

(WebCore::constructWebKitPoint):

  • bindings/js/JSWebSocketConstructor.cpp:

(WebCore::constructWebSocket):

  • bindings/js/JSWorkerConstructor.cpp:

(WebCore::constructWorker):

  • bindings/js/JSXMLHttpRequestConstructor.cpp:

(WebCore::constructXMLHttpRequest):

  • bindings/js/JSXSLTProcessorConstructor.cpp:

(WebCore::constructXSLTProcessor):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/runtime_object.cpp:

(JSC::Bindings::callRuntimeConstructor):

2:06 PM Changeset in webkit [60707] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/RealtimeAnalyser.cpp

Don't crash if null array passed into real-time analyser

1:58 PM Changeset in webkit [60706] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-04 Stephen White <senorblanco@chromium.org>

Unreviewed; expectations fix.

Fix chromium test expectations, post-r60693. We are still failing the test in the same way, but since there are now fallback results, our results are no longer MISSING, but TEXT.

  • platform/chromium/test_expectations.txt:
1:54 PM Changeset in webkit [60705] by adachan@apple.com
  • 4 edits in trunk/WebKit2

Reviewed by Anders Carlsson.

http://bugs.webkit.org/show_bug.cgi?id=40186


Need to close WebPageProxy when the WebView is destroyed.
Also, WebPageProxy shouldn't hold an OwnPtr to the PageClient, which is the WebView on Windows.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): (WebKit::WebPageProxy::setPageClient):
  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::close):
1:06 PM Changeset in webkit [60704] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048

Change the intent of the loop to match what it's going to be once we
remove the loop. This is a whitespace only change that will make the
final diff much, much smaller. Sorry for the transient ugly style.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
1:00 PM Changeset in webkit [60703] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048

Introduce ADVANCE_TO macro. This is the last macro we need to
introduce.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:54 PM Changeset in webkit [60702] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048

Fix the rest of the RECONSUME_IN cases that were missed by our script.
Also, reorder some assigment to prepare for the ADVANCE_TO patch.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:44 PM Changeset in webkit [60701] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048

This patch handles the FLUSH_AND_ADVANCE_TO case. Again, this patch
introduces style errors that will be fixed shortly.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:41 PM Changeset in webkit [60700] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
https://bugs.webkit.org/show_bug.cgi?id=40182

Instead of invoking signal handlers directly via g_signal_emit_by_name, call
gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
without breaking DRT.

  • DumpRenderTree/gtk/EventSender.cpp: (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly. (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
12:38 PM Changeset in webkit [60699] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048

This patch handles the FLUSH_EMIT_AND_RESUME_IN case. This patch
introduces some bad style w.r.t. one-line if statements, but we'll fix
them all automatically in cleanup patch when we're done.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:37 PM Changeset in webkit [60698] by senorblanco@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-06-04 Stephen White <senorblanco@chromium.org>

Unreviewed; build fix.

[CHROMIUM] Add new chromium test results for new layout test svg/filters/filter-on-filter-for-text.svg

  • platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.png: Added.
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.txt: Added.
12:30 PM Changeset in webkit [60697] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048

More small steps. This patch deals with emitting tokens.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:19 PM Changeset in webkit [60696] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048

The next step: using macros to delimit each state. Evetually, we're
going to change what these macros expand to.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:13 PM Changeset in webkit [60695] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-04 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

Accessibility focus change notifications are now sent from
ChromeClientImpl::focusedNodeChanged().
https://bugs.webkit.org/show_bug.cgi?id=39792

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focus): (WebKit::ChromeClientImpl::focusedNodeChanged):
12:06 PM Changeset in webkit [60694] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make HTML5Lexer go fast
https://bugs.webkit.org/show_bug.cgi?id=40048

We're going to do this patch in small steps to make it easier to verify correctness.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
12:03 PM Changeset in webkit [60693] by andersca@apple.com
  • 4 edits
    1 add
    3 deletes in trunk

2010-06-04 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Make the editing/spelling/context-menu-suggestions.html test more robust
https://bugs.webkit.org/show_bug.cgi?id=40178

  • editing/spelling/context-menu-suggestions-expected.txt: Added. Add new expected test result.


  • editing/spelling/context-menu-suggestions.html: Instead of dumping the menu item titles, check the length and check that the number of items is greater when there are spell checker suggestions.
  • platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Removed.
  • platform/mac-snowleopard/editing/spelling/context-menu-suggestions-expected.txt: Removed.
  • platform/mac-tiger/editing/spelling/context-menu-suggestions-expected.txt: Removed. Remove platform specific versions.

2010-06-04 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Make the editing/spelling/context-menu-suggestions.html test more robust
https://bugs.webkit.org/show_bug.cgi?id=40178

Change the contextClick method to return an array of strings describing the context menu items.

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController contextClick]):
11:48 AM Changeset in webkit [60692] by eric@webkit.org
  • 4 edits in trunk

2010-06-04 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

[chromium] Adding support for the left and right Windows keys to the

NativeWebKeyboardEvent.

https://bugs.webkit.org/show_bug.cgi?id=39752

  • platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):

2010-06-04 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

[chromium] Adding support for the left and right Windows keys to the

NativeWebKeyboardEvent.

https://bugs.webkit.org/show_bug.cgi?id=39752

  • src/gtk/WebInputEventFactory.cpp: (WebKit::gdkEventToWindowsKeyCode):
11:25 AM Changeset in webkit [60691] by adachan@apple.com
  • 5 edits in trunk/WebKit2

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=40152


Need to remove the WebView from WindowMessageBroadcaster's listeners list when the WebView is destroyed.

  • UIProcess/API/win/WKView.cpp: (WKViewSetHostWindow): Expose API to change the host window of a WKView. (WKViewWindowAncestryDidChange): Expose API to allow clients to notify WebKit when a WKView's window ancestry has changed.
  • UIProcess/API/win/WKView.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::wndProc): Set the WebView's host window to 0 when it's destroyed. setHostWindow() will call windowAncestryDidChange(), which will remove this WebView from the WindowMessageBroadcaster's listeners list. (WebKit::WebView::WebView): Initialize m_isBeingDestroyed. (WebKit::WebView::setHostWindow): Update the window's parent window and call windowAncestryDidChange(). (WebKit::WebView::close): Set the host window to 0.
  • UIProcess/win/WebView.h:
11:19 AM Changeset in webkit [60690] by kinuko@chromium.org
  • 5 edits in trunk/WebKitTools

2010-06-03 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Shinichiro Hamaji.

Clean up chromium-specific code from json_results_generator.py.
https://bugs.webkit.org/show_bug.cgi?id=39665

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
11:02 AM Changeset in webkit [60689] by krit@webkit.org
  • 5 edits
    4 adds in trunk

2010-06-04 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG filter on filter don't work
https://bugs.webkit.org/show_bug.cgi?id=32708


Any child of <text> was not allowed to use the same filter as the text root.
I couldn't found any reason in the SVG specification that legimitate this.
Only batik also doesn't allow the same filter on the text root as on it's childs,
while any other effect is still allowed.
I removed this limitation so that the result looks like the result on Firefox.

Test: svg/filters/filter-on-filter-for-text.svg

  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker): (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback): (WebCore::SVGRootInlineBox::paint):

2010-06-04 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG filter on filter don't work
https://bugs.webkit.org/show_bug.cgi?id=32708


Test that a filter can be used by the text root as well as on it's childs.

  • platform/mac/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.png: Added.
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.txt: Added.
  • svg/filters/filter-on-filter-for-text.svg: Added.
10:41 AM Changeset in webkit [60688] by Nate Chapin
  • 7 edits in trunk/WebCore

2010-06-04 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Factor PageCache functionality out of FrameLoader and into
PageCache itself.

https://bugs.webkit.org/show_bug.cgi?id=39382

Refactor only, so no new tests.

  • history/PageCache.cpp: (WebCore::pageCacheLogPrefix): (WebCore::pageCacheLog): (WebCore::logCanCacheFrameDecision): (WebCore::logCanCachePageDecision): (WebCore::PageCache::canCachePageContainingThisFrame): (WebCore::PageCache::canCache): (WebCore::PageCache::add): (WebCore::PageCache::get):
  • history/PageCache.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitIfReady):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::prepareForCachedPageRestore): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::navigateToDifferentDocument):
  • loader/FrameLoader.h: (WebCore::FrameLoader::quickRedirectComing):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
10:23 AM Changeset in webkit [60687] by loislo@chromium.org
  • 3 edits in trunk/WebCore

2010-06-04 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Web Inspector: it would be better to push object properties to JSON string in order of insertion.
https://bugs.webkit.org/show_bug.cgi?id=40140

  • inspector/InspectorValues.cpp: (WebCore::InspectorObject::writeJSON):
  • inspector/InspectorValues.h: (WebCore::InspectorObject::setBool): (WebCore::InspectorObject::setNumber): (WebCore::InspectorObject::setString): (WebCore::InspectorObject::set):
10:07 AM Changeset in webkit [60686] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-06-04 Laszlo Gombos <Laszlo Gombos>

Symbian build fix.

[Qt] Updated the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
10:05 AM Changeset in webkit [60685] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Unskip fast/dom/Window/window-properties-geolocation.html - a comment says it should be
enabled once bug 34025 is fixed, which happened long ago. The test passes for me.

  • platform/mac/Skipped:
9:59 AM Changeset in webkit [60684] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-04 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark shows a 3-4% improvement on fast hardware.

No new tests because no new functionality.

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
9:44 AM Changeset in webkit [60683] by eric@webkit.org
  • 17 edits in trunk

2010-06-04 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Add a takeFirst() method to Deque and use it where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=40089

  • wtf/Deque.h: (WTF::::takeFirst):
  • wtf/MainThread.cpp: (WTF::dispatchFunctionsFromMainThread):
  • wtf/MessageQueue.h: (WTF::::tryGetMessage):

2010-06-04 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Utilize new takeFirst() method where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=40089

No new tests because no new functionality.

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::PendingCallbacks::callAndRemoveFirstCallback):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::executeExternalScriptsIfReady):
  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::advanceSubstring):
  • storage/Database.cpp: (WebCore::Database::scheduleTransaction):
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::getNextStatement):
  • storage/SQLTransactionCoordinator.cpp: (WebCore::SQLTransactionCoordinator::processPendingTransactions):

2010-06-04 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Utilize new takeFirst() method where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=40089

  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::removeAttachment):

2010-06-04 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Utilize new takeFirst() method where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=40089

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::replaySavedEvents):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::WorkQueue::processWork): (LayoutTestController::WorkQueue::reset):
8:37 AM Changeset in webkit [60682] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: better Function.prototype.bind for the internal code.

In the "Event Listeners" pane show handler function instead of Function.prototype.bind.

https://bugs.webkit.org/show_bug.cgi?id=40080

  • inspector/front-end/utilities.js: (Function.prototype.bind.bound): (Function.prototype.bind.bound.toString): (Function.prototype.bind):
8:01 AM Changeset in webkit [60681] by apavlov@chromium.org
  • 4 edits in trunk/WebCore

2010-06-04 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, fix Qt build.

Add references to a new file.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/WebKit.qrc:
7:17 AM Changeset in webkit [60680] by apavlov@chromium.org
  • 4 edits
    1 add in trunk/WebCore

2010-06-04 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Eliminate direct dependency of StylesSidebarPane on InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=40069

No new tests are needed, as this is a refactoring.

  • inspector/front-end/CSSStyleModel.js: Added. (WebInspector.CSSStyleModel): (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype.toggleStyleEnabled): (WebInspector.CSSStyleModel.prototype.setCSSText): (WebInspector.CSSStyleModel.prototype.applyStyleText):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.stylesCallback): (WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylesSidebarPane.prototype._arrayContainsInheritedProperty): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
7:06 AM Changeset in webkit [60679] by yurys@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-06-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Create resource for DebuggerScript.js.
https://bugs.webkit.org/show_bug.cgi?id=40122

  • WebKit.grd:
  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::debuggerScriptSource):
6:50 AM Changeset in webkit [60678] by yael.aharon@nokia.com
  • 2 edits in trunk/WebKitTools

[Qt] QtTestLauncher should allow notifications by default.
https://bugs.webkit.org/show_bug.cgi?id=40078

Reviewed by Simon Hausmann.

  • QtTestBrowser/main.cpp:

(NotificationsPermissionController::NotificationsPermissionController):
(NotificationsPermissionController::checkPermission):
(NotificationsPermissionController::requestPermission):
(LauncherWindow::LauncherWindow):

6:26 AM Changeset in webkit [60677] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Compilation fails when compiling against Qt 4.7 and Qt Mobility is installed
https://bugs.webkit.org/show_bug.cgi?id=40116

Reviewed by Tor Arne Vestbø.

CONFIG += mobility has the side-effect of pulling in mobility includes, which conflict
with Qt 4.7's bearer managenent includes and break the build.

  • WebCore.pro:
5:05 AM Changeset in webkit [60676] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Fix scrolling bug with pages using accelerated compositing.
https://bugs.webkit.org/show_bug.cgi?id=40037

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::drawLayers):
4:52 AM Changeset in webkit [60675] by eric@webkit.org
  • 15 edits in trunk

2010-06-04 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

CG implementation needed for compression quality in canvas.toDataURL
https://bugs.webkit.org/show_bug.cgi?id=38492

  • platform/mac/Skipped:

2010-06-04 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

CG implementation needed for compression quality in canvas.toDataURL
https://bugs.webkit.org/show_bug.cgi?id=38492

Took toDataURL.jpeg.quality.basic.html test off of Skipped list. Passes.

Went the route of avoiding in-band signaling to flag the use of a quality
parameter or not. So, instead of simply passing the quality down as a
double, instead I pass a reference to the quality parameter from where
it comes in just after the JS bindings. Thus, no need for any global
constants to signify when the quality is not specified. Updated the other
platforms to support this (qt was on the only one currently with any
implementation).

  • bindings/js/JSHTMLCanvasElementCustom.cpp: Moved range check logic for quality parameter down lower. Updated call to toDataURL to use double* instead of just passing the quality directly. (WebCore::JSHTMLCanvasElement::toDataURL):
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Updated toDataURL call to pass double* (WebCore::V8HTMLCanvasElement::toDataURLCallback):
  • dom/CanvasSurface.cpp: Updated method prototype. (WebCore::CanvasSurface::toDataURL):
  • dom/CanvasSurface.h: Updated method prototype. (WebCore::CanvasSurface::toDataURL):
  • platform/graphics/ImageBuffer.h: Updated method signature to use double* for quality param.
  • platform/graphics/cairo/ImageBufferCairo.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/cg/ImageBufferCG.cpp: Implemented support for quality parametejr when jpeg MIME type used. (WebCore::jpegUTI): (WebCore::utiFromMIMEType): (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/haiku/ImageBufferHaiku.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/qt/ImageBufferQt.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/skia/ImageBufferSkia.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/wince/ImageBufferWince.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/wx/ImageBufferWx.cpp: Updated prototype for consistency. (WebCore::ImageBuffer::toDataURL):
4:06 AM Changeset in webkit [60674] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed. Rolling out r60671 because it caused a lot of test
failures on Chromium.

3:56 AM Changeset in webkit [60673] by alex
  • 2 edits in trunk/WebCore

2010-06-04 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Leaks in listDirectory
https://bugs.webkit.org/show_bug.cgi?id=40008

Fixed both leaks.

  • platform/gtk/FileSystemGtk.cpp: (WebCore::listDirectory):
3:44 AM Changeset in webkit [60672] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

Skip fast/dom/Geolocation/callback-to-remote-context2.html on GTK.
https://bugs.webkit.org/show_bug.cgi?id=40153

  • platform/gtk/Skipped:
3:37 AM QtWebKitJournal edited by Simon Hausmann
(diff)
3:24 AM Changeset in webkit [60671] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-04 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

Modifying the WebMediaPlayer interface to be compatible with
a change in chrome.
This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
has been updated, so this commit should NOT break chromium anymore.
https://bugs.webkit.org/show_bug.cgi?id=39445

  • public/WebMediaPlayer.h: Changed buffered() to be non-const.
2:58 AM Changeset in webkit [60670] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-06-04 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[Chromium] get rid of named interceptor on HTMLDocument and introduce/remove accessors when named items get deleted/removed
https://bugs.webkit.org/show_bug.cgi?id=39877

This patch makes callbacks invoked on named items addition/removal
install API accessors and thus there is no more need in
named and indexed interceptors on HTMLDocument which
speeds up invocation of methods on document.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
2:56 AM Changeset in webkit [60669] by steveblock@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-06-04 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Geolocation needs more LayoutTests to test making callbacks to remote frames
https://bugs.webkit.org/show_bug.cgi?id=40146

This test is similar to callback-to-remote-context.html in that it test making a callback
from a Geolocation object to a remote frame. In callback-to-remote-context.html, the call
chain to the Geolocation method is started from the owning frame. In this test, however,
the call chain is started from the remote frame.

  • fast/dom/Geolocation/callback-to-remote-context2-expected.txt: Added.
  • fast/dom/Geolocation/callback-to-remote-context2.html: Added.
  • fast/dom/Geolocation/script-tests/callback-to-remote-context2.js: Added.
2:42 AM QtWebKitJournal edited by Simon Hausmann
(diff)
2:42 AM Changeset in webkit [60668] by eric@webkit.org
  • 9 edits in trunk/WebCore

2010-06-04 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

Change filenameFromString to return CString
https://bugs.webkit.org/show_bug.cgi?id=39494

filenameFromString returns a newly allocated string and the caller must
free the string. GTK and EFL ports use g_free while all others ports use
fastFree. This is confusing because the same function behaves
differently with respect to ports. Change filenameFromString to return
CString.

  • platform/FileSystem.cpp: (WebCore::filenameFromString):
  • platform/FileSystem.h:
  • platform/efl/FileSystemEfl.cpp: (WebCore::filenameFromString):
  • platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
  • platform/gtk/FileSystemGtk.cpp: (WebCore::filenameFromString): (WebCore::filenameForDisplay): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::makeAllDirectories): (WebCore::pathGetFileName): (WebCore::directoryName): (WebCore::listDirectory):
  • platform/gtk/SharedBufferGtk.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
  • platform/posix/SharedBufferPOSIX.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
2:32 AM Changeset in webkit [60667] by steveblock@google.com
  • 19 edits in trunk/LayoutTests

2010-06-04 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Geolocation LayoutTests should make more careful use of LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=39994

Guards calls to LayoutTestController methods with 'if (window.layoutTestController)'
and adds test output to make it clear if the test can not pass without LayoutTestController.
Also removes superfluous calls to LayoutTestController.waitUntilDone(), which are now made
by js-test-post.js.

  • fast/dom/Geolocation/callback-exception-expected.txt:
  • fast/dom/Geolocation/script-tests/callback-exception.js:
  • fast/dom/Geolocation/script-tests/error.js:
  • fast/dom/Geolocation/script-tests/maximum-age.js:
  • fast/dom/Geolocation/script-tests/notimer-after-unload.js:
  • fast/dom/Geolocation/script-tests/permission-denied-already-clear-watch.js:
  • fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
  • fast/dom/Geolocation/script-tests/permission-denied-already-success.js:
  • fast/dom/Geolocation/script-tests/permission-denied-stops-watches.js:
  • fast/dom/Geolocation/script-tests/permission-denied.js:
  • fast/dom/Geolocation/script-tests/position-string.js:
  • fast/dom/Geolocation/script-tests/reentrant-error.js:
  • fast/dom/Geolocation/script-tests/reentrant-success.js:
  • fast/dom/Geolocation/script-tests/success.js:
  • fast/dom/Geolocation/script-tests/timeout-clear-watch.js:
  • fast/dom/Geolocation/script-tests/timeout-zero.js:
  • fast/dom/Geolocation/script-tests/timeout.js:
  • fast/dom/Geolocation/script-tests/watch.js:
1:55 AM Changeset in webkit [60666] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-06-04 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Detect whether the user's environment can open a browser.
https://bugs.webkit.org/show_bug.cgi?id=40136

Some environments like cygwin silently fail webbrowser.open() causing
webkit-patch upload not to display any diff. This detects environments
where webbrowser.open() would fail by testing if webbrowser.get()
raises an exception.

  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/confirmdiff.py:
1:44 AM Changeset in webkit [60665] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-04 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix compilation with QT_NO_FEATURE
https://bugs.webkit.org/show_bug.cgi?id=38324

The #ifdef QT_NO_GRAPHICSEFFECT was in the wrong place, would have
made AC not work at all.

No new tests.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
1:32 AM Changeset in webkit [60664] by eric@webkit.org
  • 4 edits in trunk

2010-06-04 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html
https://bugs.webkit.org/show_bug.cgi?id=38645

Remove 2d.path.arcTo.ensuresubpath.1.html from Skipped.

  • platform/qt/Skipped:

2010-06-04 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html
https://bugs.webkit.org/show_bug.cgi?id=38645

Path arcto function need to ensure there is subpath before it.

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo):
1:20 AM Changeset in webkit [60663] by eric@webkit.org
  • 4 edits in trunk

2010-06-04 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.3.html
https://bugs.webkit.org/show_bug.cgi?id=38537

Remove canvas/philip/tests/2d.path.arcTo.2d.path.arc.angle.3.html and
canvas/philip/tests/2d.path.arcTo.2d.path.arc.angle.5.html from Skipped.

  • platform/qt/Skipped:

2010-06-04 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arc.angle.3.html
https://bugs.webkit.org/show_bug.cgi?id=38537

For path.arc function handle span > 2PI

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
1:08 AM Changeset in webkit [60662] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Remove a QEXPECT_FAIL flag from an autotest.

Test tst_QScriptEngine::globalObject pass after 36600 bug
fix have been applied.

[Qt] Expected fail in the tst_QScriptEngine::globalObject should be removed.
https://bugs.webkit.org/show_bug.cgi?id=40114

  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::globalObject):
12:58 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:57 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:54 AM Changeset in webkit [60661] by eric@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-06-04 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix QScriptValue::equals.

Handling for a few edge cases were added. Now comparison between
NaN, an invalid objects should works as supposed.

[Qt] QScriptValue::equals problems
https://bugs.webkit.org/show_bug.cgi?id=40110

  • qt/api/qscriptvalue.cpp: (QScriptValue::equals):
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::equals):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: (tst_QScriptValue::equals_initData): (tst_QScriptValue::equals_makeData): (tst_QScriptValue::equals_test):
12:54 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
12:48 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:42 AM Changeset in webkit [60660] by eric@webkit.org
  • 5 edits in trunk

2010-06-04 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Set attributes.stencil to false by default at context creation
https://bugs.webkit.org/show_bug.cgi?id=40090

  • fast/canvas/webgl/context-attributes-expected.txt: Check if the default attributes.stencil == false.
  • fast/canvas/webgl/context-attributes.html: Ditto.

2010-06-04 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Set attributes.stencil to false by default at context creation
https://bugs.webkit.org/show_bug.cgi?id=40090

  • platform/graphics/GraphicsContext3D.h: Set default attributes.stencil to false. (WebCore::GraphicsContext3D::Attributes::Attributes):
12:07 AM Changeset in webkit [60659] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation update.

websocket/tests/reload-crash.html sometimes crash.

  • platform/chromium/test_expectations.txt:

Jun 3, 2010:

11:35 PM Changeset in webkit [60658] by morrita@google.com
  • 5 edits in trunk/WebCore

2010-06-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Carlson.

Fix a crash when trying to use an invalid media src url by
moving the isValid url checks to a central location in
isSafeToLoadURL function. Also added an empty string check
in DocumentLoader::didTellClientAboutLoad.

Test: media/invalid-media-url-crash.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad):
11:16 PM Changeset in webkit [60657] by tkent@chromium.org
  • 6 edits
    2 adds in trunk

2010-06-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Carlson.

Tests that invalid media src url does not result in crash.

  • media/invalid-media-url-crash-expected.txt: Added.
  • media/invalid-media-url-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-06-03 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Carlson.

Fix a crash when trying to use an invalid media src url by
moving the isValid url checks to a central location in
isSafeToLoadURL function. Also added an empty string check
in DocumentLoader::didTellClientAboutLoad.

Test: media/invalid-media-url-crash.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::selectNextSourceChild): (WebCore::HTMLMediaElement::getPluginProxyParams):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad):
11:09 PM Changeset in webkit [60656] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-03 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Add dependencies required to link with VS Express 2005.
https://bugs.webkit.org/show_bug.cgi?id=40038

Visual Studio implicitly links against these libs.
VC++ Express does not.

  • WebKitAPITest/WebKitAPITestCommon.vsprops:
  • WinLauncher/WinLauncher.vcproj:
10:57 PM Changeset in webkit [60655] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-03 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

New states in QScriptValuePrivate.

The CSpecial state was divided into CNull and CUndefined. It simplify
the QScriptValue code by avoiding a few "cast" and "if".
Moreover the MSVS compiler didn't like casting between a double and an
enum which is avoided now.

[Qt] The QScriptValuePrivate::CSpecial is too generic.
https://bugs.webkit.org/show_bug.cgi?id=40067

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::isNull): (QScriptValuePrivate::isUndefined): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toObject): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::isNumberBased):
10:14 PM Changeset in webkit [60654] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
https://bugs.webkit.org/show_bug.cgi?id=40105

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
  • kill pywebsocket process when url is not alive and the process is not terminated, not to leave pywebsocket server running.
  • fix codecs.open parameters.
9:28 PM Changeset in webkit [60653] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Test expectation fix.

Skip fast/dom/Geolocation/callback-to-remote-context.html on GTK.
https://bugs.webkit.org/show_bug.cgi?id=40153

  • platform/gtk/Skipped:
9:22 PM Changeset in webkit [60652] by ukai@chromium.org
  • 5 edits in trunk

2010-06-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058

  • platform/mac-tiger/Skipped:
  • remove websocket/tests from skipped list.

2010-06-03 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058

  • Scripts/ensure-valid-python:
    • Perl 5.8 doesn't have File::Temp->newdir(). Use File::Temp->tempdir() instead.
    • Add --check-only and --help option.
    • --check-only option only checks python version and don't try to install Python 2.5.
    • Set executable bit.
  • Scripts/old-run-webkit-tests:
    • Check if it can run the websocket tests by calling ensure-valid-python --check-only.
6:57 PM Changeset in webkit [60651] by morrita@google.com
  • 4 edits in trunk/WebKit/chromium

2010-05-26 MORITA Hajime <morrita@google.com>

Reviewed by Jian Li.

[Chromium] Dragging over an element with scrollbars should scroll the element when dragging near edges
https://bugs.webkit.org/show_bug.cgi?id=39725

Added WebViewImpl::scrollForDragging() to handle scroll-on-drag.
Note that this change handes both source and destination cases.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragTargetDragEnterOrOver): (WebKit::WebViewImpl::scrollForDragging):
  • src/WebViewImpl.h:
6:44 PM Changeset in webkit [60650] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore
  • wtf/Platform.h:

Reviewed by NOBODY (Qt build fix).

6:31 PM Changeset in webkit [60649] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60642.
http://trac.webkit.org/changeset/60642
https://bugs.webkit.org/show_bug.cgi?id=40151

Broke rendering of border images on rotated elements
(Requested by jamesr on #webkit).

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
6:18 PM Changeset in webkit [60648] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Add exceptions for some newly-passing tests in Chromium.

  • platform/chromium/test_expectations.txt:
5:45 PM Changeset in webkit [60647] by adachan@apple.com
  • 3 edits in trunk/WebKit2

Reviewed by Anders Carlsson.

Add UIProcess\API\cpp to the list of additional include directories.
Allow WKViewRef to work with WKRetainPtr on Windows.

  • UIProcess/API/cpp/WKRetainPtr.h:
  • win/WebKit2.vcproj:
5:34 PM Changeset in webkit [60646] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Bug 40150 - ENABLE_JIT_OPTIMIZE_NATIVE_CALL on all x86/x86_64 platforms
This was fixed in bug #40094.

Reviewed by Mark Rowe.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/Platform.h:
4:46 PM Changeset in webkit [60645] by steveblock@google.com
  • 1 edit
    5 adds in trunk/LayoutTests

2010-06-03 Steve Block <steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Geolocation needs LayoutTest to test making callbacks to remote frames
https://bugs.webkit.org/show_bug.cgi?id=40129

  • fast/dom/Geolocation/callback-to-remote-context-expected.txt: Added.
  • fast/dom/Geolocation/callback-to-remote-context.html: Added.
  • fast/dom/Geolocation/resources: Added.
  • fast/dom/Geolocation/resources/callback-to-remote-context-inner.html: Added.
  • fast/dom/Geolocation/script-tests/callback-to-remote-context.js: Added.
4:39 PM Changeset in webkit [60644] by jamesr@google.com
  • 1 edit
    18 adds in trunk/LayoutTests

2010-06-03 James Robinson <jamesr@chromium.org>

Unreviewed. Add chromium-specific baselines for new tests added by 60640

  • platform/chromium-linux/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
4:19 PM Changeset in webkit [60643] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-03 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

notifications: in display+close layout test, don't close the notification
until the display event has been received asynchronously; also don't use
an invalid icon URL, since that should generate an error event.
https://bugs.webkit.org/show_bug.cgi?id=39782

  • fast/notifications/notifications-display-close-events.html:
4:13 PM Changeset in webkit [60642] by kdecker@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Beth Dakin.

Pixel cracks in border images when drawing with a scale factor > 1
<rdar://problem/7994266>pixel cracks in border images
https://bugs.webkit.org/show_bug.cgi?id=15720


  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h: Added two new methods to support drawing using FloatRect. If the boolean flag roundToPixels is true, the pixels are adjusted with the pixel boundaries.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
3:49 PM Changeset in webkit [60641] by mrobinson@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60632.
http://trac.webkit.org/changeset/60632
https://bugs.webkit.org/show_bug.cgi?id=40143

This change broke the 64-bit bots. (Requested by mrobinson on
#webkit).

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::DragClient): (WebKit::DragClient::startDrag):
  • WebCoreSupport/DragClientGtk.h:
3:07 PM Changeset in webkit [60640] by jamesr@google.com
  • 3 edits
    18 adds in trunk

2010-06-03 James Robinson <jamesr@chromium.org>

Reviewed by Dan Bernstein.

Take container's scroll offset and clip into account when initializing LayoutState
https://bugs.webkit.org/show_bug.cgi?id=38506

When doing a subtree layout, the initial LayoutState creation needs to
take the layout root container's offset and its scroll offset into account
to create the initial offset. Otherwise if a subtree layout occurs
for a layout root whose container has a non-zero scroll offset
the LayoutState's offset and clip are wrong, resulting in a mispaint.
See the test cases for examples.

Tests: fast/repaint/layout-state-scrolloffset.html

fast/repaint/layout-state-scrolloffset2.html
fast/repaint/layout-state-scrolloffset3.html

  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):

2010-06-03 James Robinson <jamesr@chromium.org>

Reviewed by Dan Bernstein.


Tests repainting a layout subtree with scroll offsets
https://bugs.webkit.org/show_bug.cgi?id=38506


Has to be run as a pixel test to be useful.

  • layout-state-scrolloffset.html tests the layout root having a non-zero scroll offset.
  • layout-state-scrolloffset2.html tests the layout root and its container having

non-zero scroll offsets.

  • layout-state-scrolloffset3.html tests the layout root having non-zero a scroll offset

and clipping its descendants.

  • fast/repaint/layout-state-scrolloffset.html: Added.
  • fast/repaint/layout-state-scrolloffset2.html: Added.
  • fast/repaint/layout-state-scrolloffset3.html: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
2:45 PM Changeset in webkit [60639] by barraclough@apple.com
  • 3 edits in trunk/WebCore
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

Reviewed by NOBODY (speculative Qt build fix II).

2:36 PM Changeset in webkit [60638] by barraclough@apple.com
  • 2 edits in trunk/WebCore
  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):

Reviewed by NOBODY (speculative Qt build fix).

2:29 PM Changeset in webkit [60637] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

(JSC::Interpreter::privateExecute):

Reviewed by NOBODY (Interpreter build fix).

2:10 PM Changeset in webkit [60636] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix II).

1:49 PM Changeset in webkit [60635] by ojan@chromium.org
  • 14 edits in trunk/WebKitTools

2010-05-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
https://bugs.webkit.org/show_bug.cgi?id=38918

Patches with in-rietveld? get uploaded to rietveld and get marked
in-rietveld+. If the upload fails, they are marked in-rietveld-
and an error is logged to the bug, like the commit-queue.

Also, get rid of --fancy-review and the ability to upload to rietveld
using webkit-patch upload/post.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py:
1:48 PM Changeset in webkit [60634] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (windows build fix).

1:20 PM Changeset in webkit [60633] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-24 Ojan Vafai <ojan@chromium.org>

Reviewed by Chris Jerdonek.

many webkit-patch commands fail in a non-svn tracking git checkout
https://bugs.webkit.org/show_bug.cgi?id=38156

If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
If neither exists, then error out. This makes webkit-patch work
for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
to checkout webkit. The fallback to master is for people who don't
do the steps on that page for tracking svn.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
1:08 PM Changeset in webkit [60632] by mrobinson@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Drag gesture can take mouse grab indefinitely
https://bugs.webkit.org/show_bug.cgi?id=32840

Start GTK+ drags with the previous mouse button down event instead of
synthesizing the event. The synthesized event was not completely valid
and froze some drags indefinitely.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::buttonPressEvent): Added. (WebKit::DragClient::DragClient): Connect to the 'button-press-event' signal of the WebView. (WebKit::DragClient::startDrag): Instead of synthesizing a button press event use the last real one.
  • WebCoreSupport/DragClientGtk.h: (WebKit::DragClient::setLastButtonPressEvent): Added.
1:00 PM Changeset in webkit [60631] by barraclough@apple.com
  • 71 edits in trunk

Bug 40094 - The return type of NativeFunction should be EncodedJSValue
On Windows & Linux, using JSVALUE32_64, EncodedJSValue is returned in registers, but JSValue is not.

Reviewed by Oliver Hunt.

JavaScriptCore:

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:

(JSC::::call):

(JSC::Interpreter::executeCall):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • jsc.cpp:

(functionPrint):
(functionDebug):
(functionGC):
(functionVersion):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(functionSetSamplingFlags):
(functionClearSamplingFlags):
(functionReadline):
(functionQuit):

  • runtime/ArrayConstructor.cpp:

(JSC::callArrayConstructor):
(JSC::arrayConstructorIsArray):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

  • runtime/BooleanConstructor.cpp:

(JSC::callBooleanConstructor):

  • runtime/BooleanPrototype.cpp:

(JSC::booleanProtoFuncToString):
(JSC::booleanProtoFuncValueOf):

  • runtime/CallData.h:
  • runtime/DateConstructor.cpp:

(JSC::callDate):
(JSC::dateParse):
(JSC::dateNow):
(JSC::dateUTC):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::dateProtoFuncSetTime):
(JSC::dateProtoFuncSetMilliSeconds):
(JSC::dateProtoFuncSetUTCMilliseconds):
(JSC::dateProtoFuncSetSeconds):
(JSC::dateProtoFuncSetUTCSeconds):
(JSC::dateProtoFuncSetMinutes):
(JSC::dateProtoFuncSetUTCMinutes):
(JSC::dateProtoFuncSetHours):
(JSC::dateProtoFuncSetUTCHours):
(JSC::dateProtoFuncSetDate):
(JSC::dateProtoFuncSetUTCDate):
(JSC::dateProtoFuncSetMonth):
(JSC::dateProtoFuncSetUTCMonth):
(JSC::dateProtoFuncSetFullYear):
(JSC::dateProtoFuncSetUTCFullYear):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear):
(JSC::dateProtoFuncToJSON):

  • runtime/ErrorConstructor.cpp:

(JSC::callErrorConstructor):

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

  • runtime/FunctionConstructor.cpp:

(JSC::callFunctionConstructor):

  • runtime/FunctionPrototype.cpp:

(JSC::callFunctionPrototype):
(JSC::functionProtoFuncToString):
(JSC::functionProtoFuncApply):
(JSC::functionProtoFuncCall):

  • runtime/JSCell.h:

(JSC::getCallData):
(JSC::getConstructData):

  • runtime/JSFunction.cpp:

(JSC::callHostFunctionAsConstructor):

  • runtime/JSFunction.h:
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncIsNaN):
(JSC::globalFuncIsFinite):
(JSC::globalFuncDecodeURI):
(JSC::globalFuncDecodeURIComponent):
(JSC::globalFuncEncodeURI):
(JSC::globalFuncEncodeURIComponent):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
(JSC::globalFuncJSCPrint):

  • runtime/JSGlobalObjectFunctions.h:
  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):

  • runtime/JSObject.cpp:

(JSC::callDefaultValueFunction):

  • runtime/JSValue.h:
  • runtime/MathObject.cpp:

(JSC::mathProtoFuncAbs):
(JSC::mathProtoFuncACos):
(JSC::mathProtoFuncASin):
(JSC::mathProtoFuncATan):
(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncCeil):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncExp):
(JSC::mathProtoFuncFloor):
(JSC::mathProtoFuncLog):
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
(JSC::mathProtoFuncPow):
(JSC::mathProtoFuncRandom):
(JSC::mathProtoFuncRound):
(JSC::mathProtoFuncSin):
(JSC::mathProtoFuncSqrt):
(JSC::mathProtoFuncTan):

  • runtime/NativeErrorConstructor.cpp:

(JSC::callNativeErrorConstructor):

  • runtime/NumberConstructor.cpp:

(JSC::callNumberConstructor):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToLocaleString):
(JSC::numberProtoFuncValueOf):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToPrecision):

  • runtime/ObjectConstructor.cpp:

(JSC::callObjectConstructor):
(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncValueOf):
(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncIsPrototypeOf):
(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncPropertyIsEnumerable):
(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):

  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp:

(JSC::callRegExpConstructor):

  • runtime/RegExpObject.cpp:

(JSC::callRegExpObject):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):

  • runtime/StringConstructor.cpp:

(JSC::stringFromCharCode):
(JSC::callStringConstructor):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToString):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncConcat):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::stringProtoFuncTrim):
(JSC::stringProtoFuncTrimLeft):
(JSC::stringProtoFuncTrimRight):

JavaScriptGlue:

  • JSObject.cpp:

(nativeCallFunction):

WebCore:

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::callHTMLCollection):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::open):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::createInjectedScript):

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::callNodeList):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::callPlugin):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::executeFunctionInContext):

  • bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializingTreeWalker::convertIfTerminal):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:

(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Construct):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::callObjCFallbackObject):

  • bridge/runtime_method.cpp:

(JSC::callRuntimeMethod):

  • bridge/runtime_object.cpp:

(JSC::Bindings::callRuntimeObject):

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):

11:59 AM HackingGtk edited by mrobinson@webkit.org
(diff)
11:56 AM HackingGtk edited by mrobinson@webkit.org
(diff)
11:38 AM HackingGtk edited by mrobinson@webkit.org
Update source module locations and put the directory first (diff)
10:34 AM Changeset in webkit [60630] by yael.aharon@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Don't send notifications event after the page was navigated away
https://bugs.webkit.org/show_bug.cgi?id=40127

Reviewed by Laszlo Gombos.

Added a check before sending events to the notification and before logging.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::sendEvent):

10:33 AM Changeset in webkit [60629] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

10:30 AM Changeset in webkit [60628] by mrowe@apple.com
  • 1 copy in tags/Safari-533.16

New tag.

10:30 AM Changeset in webkit [60627] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59498.

9:42 AM Changeset in webkit [60626] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

fast/events/transformaction removed from expectations,
because these tests were rolled-out by r60624.

Rubber-stamped by Simon Hausmann.

  • platform/chromium/test_expectations.txt:
9:29 AM Changeset in webkit [60625] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed, rolling out r60617.
http://trac.webkit.org/changeset/60617
https://bugs.webkit.org/show_bug.cgi?id=40124

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-06-03
Followup patch for rolled-out r60614 (Requested by Ossy on
#webkit).

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
9:25 AM Changeset in webkit [60624] by Csaba Osztrogonác
  • 31 edits
    6 deletes in trunk

Unreviewed, rolling out r60614.
http://trac.webkit.org/changeset/60614
https://bugs.webkit.org/show_bug.cgi?id=40123

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-06-03
It made fast/dom/Window/window-postmessage-clone.html fail on
Mac bots (Requested by Ossy on #webkit).

WebCore:

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • dom/Document.cpp:

(WebCore::Document::createEvent):
(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:

(WebCore::Document::):

  • dom/Document.idl:
  • dom/Element.h:
  • dom/Element.idl:
  • dom/Event.cpp:

(WebCore::Event::fromUserGesture):

  • dom/Event.h:
  • dom/EventNames.h:
  • dom/TransformActionEvent.cpp: Removed.
  • dom/TransformActionEvent.h: Removed.
  • dom/TransformActionEvent.idl: Removed.
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/events/transformaction/create-transformaction-event-expected.txt: Removed.
  • fast/events/transformaction/create-transformaction-event.html: Removed.
  • fast/events/transformaction/resources/create-transformaction-event.js: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
9:03 AM Changeset in webkit [60623] by yurys@chromium.org
  • 4 edits in trunk

2010-06-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: show "Object" as description for values with anonymous constructor
https://bugs.webkit.org/show_bug.cgi?id=40121

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):

2010-06-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: show "Object" as description for values with anonymous constructor
https://bugs.webkit.org/show_bug.cgi?id=40121

  • src/js/DevTools.js: don't call DebuggerAgent methods if ScriptDebugServer is used.
8:56 AM Changeset in webkit [60622] by Dimitri Glazkov
  • 2 edits in trunk/WebKit/chromium

[DRT/Chromium] Checking out lighttpd
https://bugs.webkit.org/show_bug.cgi?id=39948

Patch by Kent Tamura <tkent@chromium.org> on 2010-06-03
Reviewed by Dimitri Glazkov.

  • Add lighttpd only on Windows. It is used by new-run-webkit-tests.
  • Add libvpx.
  • Remove pthreads-win32 from DEPS. It has not been used since Chromium r28642.
  • Update Chromium revision to use Windows resource query code and webkit_glue dependency fix.
  • DEPS:
6:38 AM Changeset in webkit [60621] by vestbo@webkit.org
  • 4 edits
    1 move in trunk/WebCore

[Qt] Fix NPAPI support on Mac OS X/Cocoa-32

Reviewed by Simon Hausmann.

qt_mac_window_for() returns a NSWindow on Cocoa, so we were
passing in a NSWindow instead of a WindowRef as part of the
NP_CGContext.

https://bugs.webkit.org/show_bug.cgi?id=38762

  • WebCore.gypi: Reflect rename
  • WebCore.pro: Reflect rename
  • plugins/mac/PluginViewMac.cpp: Renamed to PluginViewMac.mm

and fix bug by getting the Carbon windowRef from the NSWindow.

  • wscript: Reflect rename
6:02 AM Changeset in webkit [60620] by mike.fenton@torchmobile.com
  • 2 edits in trunk/WebKitTools

2010-06-03 Mike Fenton <mifenton@rim.com>

Unreviewed.

Reverse e-mail for myself in committers.py to correspond with bugzilla account.

  • Scripts/webkitpy/common/config/committers.py:
4:11 AM Changeset in webkit [60619] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Test expectation update.

  • platform/chromium/test_expectations.txt: Restore Mac expectation of fixed-move-after-keyboard-scroll.html.
3:04 AM Changeset in webkit [60618] by pfeldman@chromium.org
  • 6 edits in trunk

2010-06-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: a number of fixes that make InspectorController
happy with null redirects.

https://bugs.webkit.org/show_bug.cgi?id=40109

  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):

2010-06-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: a number of fixes that make InspectorController
happy with null redirects.

https://bugs.webkit.org/show_bug.cgi?id=40109

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest):
  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest):
2:58 AM Changeset in webkit [60617] by Simon Hausmann
  • 5 edits in trunk/LayoutTests

Not reviewed: Add TransformActionEvent to the window object tests, after r60614.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
2:37 AM Changeset in webkit [60616] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Test expectation update.

Rebaseline fixed-move-after-keyboard-scroll for Chromium-Linux
https://bugs.webkit.org/show_bug.cgi?id=40101

  • platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
2:24 AM Changeset in webkit [60615] by tkent@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed. Test expectation update.

Rebaseline fixed-move-after-keyboard-scroll, and add an entry for
fast/events/transformaction.
https://bugs.webkit.org/show_bug.cgi?id=40101

  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium/test_expectations.txt:
1:38 AM Changeset in webkit [60614] by Simon Hausmann
  • 31 edits
    8 adds in trunk

Add TransformActionEvent support
https://bugs.webkit.org/show_bug.cgi?id=39757

Patch by Kim Grönholm <kim.1.gronholm@nokia.com> on 2010-06-03
Reviewed by Simon Hausmann.

WebCore:

Added only the necessary TransformAction event interfaces and not e.g.
any eventhandler hooks that generate and dispatch them.

Test: fast/events/transformaction/create-transformaction-event.html
More tests will be added with the machinery that generates and
dispatches these events.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::transformactionEnabled):
(WebCore::RuntimeEnabledFeatures::setTransformActionEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionstartEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionupdateEnabled):
(WebCore::RuntimeEnabledFeatures::ontransformactionendEnabled):

  • bindings/js/JSEventCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

  • dom/Document.cpp:

(WebCore::Document::createEvent):
(WebCore::Document::addListenerTypeIfNeeded):

  • dom/Document.h:

(WebCore::Document::):

  • dom/Document.idl:
  • dom/Element.h:
  • dom/Element.idl:
  • dom/Event.cpp:

(WebCore::Event::isTransformActionEvent):
(WebCore::Event::fromUserGesture):

  • dom/Event.h:
  • dom/EventNames.h:
  • dom/TransformActionEvent.cpp: Added.

(WebCore::TransformActionEvent::TransformActionEvent):
(WebCore::TransformActionEvent::initTransformActionEvent):

  • dom/TransformActionEvent.h: Added.

(WebCore::TransformActionEvent::create):
(WebCore::TransformActionEvent::translateX):
(WebCore::TransformActionEvent::translateY):
(WebCore::TransformActionEvent::translateSpeedX):
(WebCore::TransformActionEvent::translateSpeedY):
(WebCore::TransformActionEvent::scale):
(WebCore::TransformActionEvent::scaleSpeed):
(WebCore::TransformActionEvent::rotate):
(WebCore::TransformActionEvent::rotateSpeed):
(WebCore::TransformActionEvent::TransformActionEvent):
(WebCore::TransformActionEvent::isTransformActionEvent):

  • dom/TransformActionEvent.idl: Added.
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/events/transformaction/create-transformaction-event-expected.txt: Added.
  • fast/events/transformaction/create-transformaction-event.html: Added.
  • fast/events/transformaction/resources/create-transformaction-event.js: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
1:21 AM Changeset in webkit [60613] by pfeldman@chromium.org
  • 19 edits in trunk/LayoutTests

2010-06-03 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Rebaseline chromium tests as a follow up to r60611.

https://bugs.webkit.org/show_bug.cgi?id=37364

  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.png:
  • platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
12:52 AM Changeset in webkit [60612] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation update.

4 websocket tests don't fail now.

  • platform/chromium/test_expectations.txt:
  • remove websocket/tests/unicode.html, websocket/tests/send.html, websocket/tests/handshake-error.html and websocket/tests/long-invalid-header.html
12:22 AM Changeset in webkit [60611] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-06-03 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out aggressive cache part of the r60391
described in the bug below. It was orthogonal to the rest of
the patch and caused regression.

https://bugs.webkit.org/show_bug.cgi?id=37364

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::drawResampledBitmap):
12:07 AM Changeset in webkit [60610] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-02 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] refactor WebKit.gyp's DRT section so the conditions are less messy
https://bugs.webkit.org/show_bug.cgi?id=40104

  • WebKit.gyp:
12:03 AM Changeset in webkit [60609] by eric@webkit.org
  • 6 edits in trunk

2010-06-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Shinichiro Hamaji.

[Qt] Fix compilation with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=38324

  • Api/qwebpage.cpp: (QWebPage::event):
  • Api/qwebpage_p.h:
  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend):

2010-06-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Shinichiro Hamaji.

[Qt] Fix compilation with QT_NO_PROPERTIES
https://bugs.webkit.org/show_bug.cgi?id=38324

  • QtTestBrowser/main.cpp: (LauncherWindow::init):

Jun 2, 2010:

10:38 PM Changeset in webkit [60608] by eric@webkit.org
  • 5 edits
    9 adds in trunk

2010-06-02 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

location.href and outgoing referrer not updated properly by
pushState/replaceState
https://bugs.webkit.org/show_bug.cgi?id=40027

  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html: Updated this test to account for location being modified by replaceState.
  • fast/loader/stateobjects/pushstate-updates-location-expected.txt: Added.
  • fast/loader/stateobjects/pushstate-updates-location.html: Added.
  • fast/loader/stateobjects/replacestate-updates-location-expected.txt: Added.
  • fast/loader/stateobjects/replacestate-updates-location.html: Added.
  • http/tests/navigation/pushstate-updates-referrer-expected.txt: Added.
  • http/tests/navigation/pushstate-updates-referrer.html: Added.
  • http/tests/navigation/replacestate-updates-referrer-expected.txt: Added.
  • http/tests/navigation/replacestate-updates-referrer.html: Added.
  • http/tests/navigation/resources/check-referrer.html: Added.

2010-06-02 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

location.href and outgoing referrer not updated properly by
pushState/replaceState
https://bugs.webkit.org/show_bug.cgi?id=40027

Tests: fast/loader/stateobjects/pushstate-updates-location.html

fast/loader/stateobjects/replacestate-updates-location.html
http/tests/navigation/pushstate-updates-referrer.html
http/tests/navigation/replacestate-updates-referrer.html

  • dom/Document.cpp: (WebCore::Document::updateURLForPushOrReplaceState): Update the FrameLoader's notion of the current URL as well!
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): Use the 'url' parameter instead of m_URL since m_URL might have changed during the handling of the PopState event. Eventually, this will become irrelevant since the PopState event should be dispatched asynchronously, but just in case we patch HashChange to be asynchronous before PopState, this change would be needed.
10:25 PM Changeset in webkit [60607] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-02 Tony Chang <tony@chromium.org>

Not reviewed, build fix in downstream chromium.

Fix the path to repack.py so it works in a chromium checkout too.

  • WebKit.gyp:
10:25 PM Changeset in webkit [60606] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(60409): document.write is not synchronous when using the HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40047

The HTML5 spec states that we should "spin the event loop" while
waiting for stylesheets to load. Currently we do that by yielding
out of the parser when stylesheets are loading. Because it was easy
we made inline <scripts> yield for stylesheet loads as well. However,
this caused document.write() to return after encountering the first
inline <script> tag in many cases which is incorrect. document.write
is supposed to block until the entire document is parsed (including)
executing inline script tags. To match the exiting parser, we'll just
make inline <script> tags not block on stylesheets for now.

This is tested by WebCore/benchmarks/html-parser.html as well
as likely several other tests in LayoutTests which we haven't
triaged yet.

  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::executeScript):
    • ASSERT that either stylesheets have loaded or we're executing an inline <script> tag.

(WebCore::HTML5ScriptRunner::runScript):

  • Remove the code to block inline <script> tags on stylesheet loads.
10:00 PM Changeset in webkit [60605] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-06-02 MORITA Hajime <morrita@google.com>

Unreviewd, Chromium windows build fix.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintProgressBar):
9:45 PM Changeset in webkit [60604] by morrita@google.com
  • 4 edits in trunk/WebCore

2010-06-02 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Support HTML5 <progress> element on Linux.
https://bugs.webkit.org/show_bug.cgi?id=37310

Implemented RenderThemeChromiumSkia::paintProgressBar(), extracing
determinateProgressValueRectFor() from RenderThemeChromiumWin to
RenderThemeChromiumSkia

No new tests. Expectations will come after ENABLE_PROGRESS_BAR get
enabled on chromium.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::determinateProgressValueRectFor): (WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor): (WebCore::RenderThemeChromiumSkia::animationRepeatIntervalForProgressBar): (WebCore::RenderThemeChromiumSkia::animationDurationForProgressBar): (WebCore::RenderThemeChromiumSkia::paintProgressBar): (WebCore::RenderThemeChromiumSkia::progressValueRectFor):
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintProgressBar):
9:40 PM Changeset in webkit [60603] by mrowe@apple.com
  • 2 edits in tags/Safari-534.0.1/JavaScriptCore

Merge r60595.

9:40 PM Changeset in webkit [60602] by mrowe@apple.com
  • 5 edits in tags/Safari-534.0.1

Versioning.

9:32 PM Changeset in webkit [60601] by mrowe@apple.com
  • 1 copy in tags/Safari-534.0.1

New tag.

9:28 PM Changeset in webkit [60600] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Test expectation update.

  • platform/qt/Skipped: Add editing/input/page-up-down-scrolls.html
9:21 PM Changeset in webkit [60599] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

Unreviewed. Fix a tes_expectation error.

9:10 PM Changeset in webkit [60598] by barraclough@apple.com
  • 4 edits
    3 adds in trunk/JavaScriptCore

Add value-representation specific sections to the mac export file.

Patch by Mark Rowe <mrowe@apple.com> on 2010-06-02
Reviewed by Gavin Barraclough.

8:36 PM Changeset in webkit [60597] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation update.

Add fixed-move-after-keyboard-scroll.html temporarily
https://bugs.webkit.org/show_bug.cgi?id=40101

  • platform/chromium/test_expectations.txt:
8:22 PM Changeset in webkit [60596] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-02 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] generate DumpRenderTree.pak on DRT linux
https://bugs.webkit.org/show_bug.cgi?id=40098

  • WebKit.gyp:
8:15 PM Changeset in webkit [60595] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/8054988> Work around an LLVM GCC code generation bug that results in crashes inside PCRE.

Reviewed by Gavin Barraclough.

  • pcre/pcre_exec.cpp:

(repeatInformationFromInstructionOffset): Change the type of instructionOffset to int. There's no good
reason for it to be a short, and using int prevents this code from triggering the LLVM GCC bug.

7:53 PM Changeset in webkit [60594] by tony@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60592.
http://trac.webkit.org/changeset/60592
https://bugs.webkit.org/show_bug.cgi?id=40099

broke the build, need to coordiate updating DEPS (Requested by
tonywork on #webkit).

  • DEPS:
  • public/WebMediaPlayer.h:
7:37 PM Changeset in webkit [60593] by eric@webkit.org
  • 5 edits in trunk/WebKit/qt

2010-06-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Shared platform plugin
https://bugs.webkit.org/show_bug.cgi?id=39968

Allow several instances of class QtPlatformPlugin to share the QWebKitPlatformPlugin
object provided by a plugin.

Updated plugin interface version number due to ABI breaking change.

  • Api/qwebkitplatformplugin.h: (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::load): (WebCore::QtPlatformPlugin::~QtPlatformPlugin): (WebCore::QtPlatformPlugin::plugin):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
7:23 PM Changeset in webkit [60592] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-06-02 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

Modifying the WebMediaPlayer interface to be compatible with
a change in chrome.
This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
has been updated, so this commit should NOT break chromium anymore.
https://bugs.webkit.org/show_bug.cgi?id=39445

  • DEPS: Updated to a newer chrome revision number.
  • public/WebMediaPlayer.h: Changed buffered() to be non-const.
7:10 PM Changeset in webkit [60591] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-06-02 Nico Weber <thakis@chromium.org>

Reviewed by Simon Fraser.

Scroll events are sent twice per keypress for ports that don't have a platformWidget scrollbar.

This was regressed by http://trac.webkit.org/changeset/58615 . Fix this by slightly tweaking
that patch, add a layout test.

https://bugs.webkit.org/show_bug.cgi?id=39918

  • editing/input/page-up-down-scrolls-expected.txt: Added.
  • editing/input/page-up-down-scrolls.html: Added.

2010-06-02 Nico Weber <thakis@chromium.org>

Reviewed by Simon Fraser.

Scroll events are sent twice per keypress for ports that don't have a platformWidget scrollbar
https://bugs.webkit.org/show_bug.cgi?id=39918

This was regressed by http://trac.webkit.org/changeset/58615 . Fix this by slightly tweaking
that patch.

Test: editing/input/page-up-down-scrolls.html

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChanged):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::valueChanged):
  • platform/ScrollView.h: (WebCore::ScrollView::repaintFixedElementsAfterScrolling):
7:00 PM Changeset in webkit [60590] by pkasting@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed, emergency fix for test crashes (verbal r+ beforehand from
John Gregg).

Temporarily make notificationObjectDestroyed() a no-op to avoid an
ASSERT failure.

https://bugs.webkit.org/show_bug.cgi?id=40097

  • src/NotificationPresenterImpl.cpp:

(WebKit::NotificationPresenterImpl::notificationObjectDestroyed):

6:54 PM Changeset in webkit [60589] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-02 Raine Makelainen <raine.makelainen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] On Maemo6 platform auto upper case and predictive text input method hints are not disabled for password field.
https://bugs.webkit.org/show_bug.cgi?id=40062

Introducing Q_WS_MAEMO_6 for Maemo6 specific code. Enabling code that sets input
method hints Qt::ImhNoAutoUppercase and Qt::ImhNoPredictiveText true for Maemo6.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
6:35 PM Changeset in webkit [60588] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/Cone.cpp

Fix build

6:35 PM Changeset in webkit [60587] by crogers@google.com
  • 1 edit
    2 adds in branches/audio/WebCore

For performance/debugging purposes add PerformanceTimer class (mac-only)

  • also fixed WebCore xcode project path problems
6:33 PM Changeset in webkit [60586] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-06-02 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make possible run DRT with QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=40016

Make possible to use a environment variable for switching backend.
Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebViewGraphicsBased::WebViewGraphicsBased): (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/DumpRenderTreeQt.h: (WebCore::DumpRenderTree::setGraphicsBased): (WebCore::DumpRenderTree::isGraphicsBased): (WebCore::WebViewGraphicsBased::graphicsView): (WebCore::WebViewGraphicsBased::setPage):
  • Scripts/old-run-webkit-tests:
6:19 PM Changeset in webkit [60585] by eric@webkit.org
  • 5 edits
    1 add in trunk/JavaScriptCore

2010-06-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix the QScriptValue::strictlyEquals function.

Handling for a few edge cases was added.

New autotest that covers the QScriptValue::strictlyEquals function.

[Qt] QScriptValue::strictlyEquals is broken
https://bugs.webkit.org/show_bug.cgi?id=36600

  • qt/api/qscriptvalue.cpp: (QScriptValue::strictlyEquals):
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::strictlyEquals):
  • qt/tests/qscriptvalue/qscriptvalue.pro:
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: Added. (tst_QScriptValue::strictlyEquals_initData): (tst_QScriptValue::strictlyEquals_makeData): (tst_QScriptValue::strictlyEquals_test):
6:05 PM Changeset in webkit [60584] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-02 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use platform-specific key designations in shortcuts help for mac
https://bugs.webkit.org/show_bug.cgi?id=39158

  • inspector/front-end/KeyboardShortcut.js: (WebInspector.KeyboardShortcut.shortcutToString): (WebInspector.KeyboardShortcut._keyName): (WebInspector.KeyboardShortcut._modifiersToString):
  • inspector/front-end/inspector.js: (WebInspector._registerShortcuts):
5:27 PM Changeset in webkit [60583] by eric@webkit.org
  • 6 edits in trunk/JavaScriptCore

2010-06-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

New function QScriptEngine::newObject.

The function creates a object of class Object and returns it
as a QScriptValue.

[Qt] QScriptEngine API should contain a newObject function
https://bugs.webkit.org/show_bug.cgi?id=39114

  • qt/api/qscriptengine.cpp: (QScriptEngine::newObject):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::newObject):
  • qt/api/qscriptengine_p.h:
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::newObject):
4:57 PM Changeset in webkit [60582] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-06-02 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Enable WebGL on more platforms even if accelerated compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=40085

Conditionalize the code which prevents a WebGL rendering context
from being created if accelerated compositing is disabled.
Currently Chromium is the only port which will create a context if
accelerated compositing is disabled; other ports may opt in to
this code path if desired.

Tested with existing WebGL layout tests in Safari and Chromium on
Mac OS X.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext):
4:41 PM Changeset in webkit [60581] by eric@webkit.org
  • 3 edits
    3 deletes in trunk

2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60580.
http://trac.webkit.org/changeset/60580
https://bugs.webkit.org/show_bug.cgi?id=40087

This broke dragging links if the selection was in a
contentEditable element. (Requested by arv on #webkit).

  • editing/selection/click-in-focusable-link-should-not-clear-selection-expected.txt: Removed.
  • editing/selection/click-in-focusable-link-should-not-clear-selection.html: Removed.
  • editing/selection/script-tests/click-in-focusable-link-should-not-clear-selection.js: Removed.

2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60580.
http://trac.webkit.org/changeset/60580
https://bugs.webkit.org/show_bug.cgi?id=40087

This broke dragging links if the selection was in a
contentEditable element. (Requested by arv on #webkit).

  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded):
2:38 PM Changeset in webkit [60580] by arv@chromium.org
  • 3 edits
    3 adds in trunk

2010-06-02 Erik Arvidsson <arv@chromium.org>

Reviewed by ojan@chromium.org.

REGRESSION: Weird focus behavior affects quoting on University of Washington message board system
https://bugs.webkit.org/show_bug.cgi?id=38548

  • editing/selection/click-in-focusable-link-should-not-clear-selection-expected.txt: Added.
  • editing/selection/click-in-focusable-link-should-not-clear-selection.html: Added.
  • editing/selection/script-tests/click-in-focusable-link-should-not-clear-selection.js: Added. (description.getElementCenter): (doubleClickOnElement): (mouseDownOnElement): (selectionShouldBe):

2010-06-02 Erik Arvidsson <arv@chromium.org>

Reviewed by ojan@chromium.org.

REGRESSION: Weird focus behavior affects quoting on University of Washington message board system
https://bugs.webkit.org/show_bug.cgi?id=38548

Test: editing/selection/click-in-focusable-link-should-not-clear-selection.html

  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded):
2:33 PM Changeset in webkit [60579] by crogers@google.com
  • 7 edits
    8 adds in branches/audio/WebCore

windows build changes to get us compiling and linking (courtesy of Ian Lewis)

2:19 PM Changeset in webkit [60578] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed, layout test fix.

Web Inspector: disable resource tracking on exiting the inspector layout test.
This is a short-term fix while I am working on making sure DRT disables it
automatically on the test exit.

https://bugs.webkit.org/show_bug.cgi?id=40083

  • http/tests/inspector/resource-parameters.html:
1:56 PM Changeset in webkit [60577] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=40011

Reviewed by Gavin Barraclough.

Thumb-2 build fix: The offset parameter of ldrh should be encoded as an
imm12 immediate constant in load16. If it is not fit in the instruction
a temporary register has to be used.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load16):

1:44 PM Changeset in webkit [60576] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Eric Seidel <eric@webkit.org>

Unreviewed. Just reverting part of r60556 as requested by Dave Hyatt on webkit-commits@list.webkit.org.

Several layout tests needlessly use invalid HTML
https://bugs.webkit.org/show_bug.cgi?id=39985

css1/box_properties/float_elements_in_series.html
remains invalid HTML, but we can't change it because
css1/ is meant to be a pristine copy of the CSS1 test suite.

  • css1/box_properties/float_elements_in_series.html:
    • Revert changes to this test. Dave Hyatt points out that although undocumented, this directory is meant to contain a pristine copy of the CSS1 test suite. It really should be documented and/or moved somewhere special, but for now we'll just revert the changes.
1:41 PM Changeset in webkit [60575] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

Slave lost shouldn't be recognized as build failed.
https://bugs.webkit.org/show_bug.cgi?id=39282

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
  • Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
1:11 PM Changeset in webkit [60574] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Just disable the current version of multi-column layout completely when the new
pagination model is in effect.

Reviewed by Anders Carlsson.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::setDesiredColumnCountAndWidth):

12:37 PM Changeset in webkit [60573] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: added new inspector test to Skipped in Tiger for
its loader not reporting the resource size right.

https://bugs.webkit.org/show_bug.cgi?id=40049

  • platform/mac-tiger/Skipped:
12:28 PM Changeset in webkit [60572] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Turn off unforced page breaking at paint time when the new page breaking model is being used.

Reviewed by Anders Carlsson.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

12:20 PM Changeset in webkit [60571] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Don't check page break properties at paint time if we're using the new page breaking model.

Reviewed by Anders Carlsson.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):

11:24 AM Changeset in webkit [60570] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-06-02 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

[V8] Fix an infinite recursion crash when trying to wrap
media elements without a media player.

No test because there isn't a good way to ensure the media player
is off.

  • dom/make_names.pl: Call, e.g., V8HTMLElement::wrap(HTMLElement*) instead of toV8(HTMLElement*).
10:14 AM Changeset in webkit [60569] by yael.aharon@nokia.com
  • 3 edits in trunk/WebCore

Notification object ref counting is not correct.
https://bugs.webkit.org/show_bug.cgi?id=39998

Reviewed by Darin Adler.

Return PassRefPtr<Notification> instead of a raw pointer from the create methods
for Web Notifications.

No new tests are needed, as existing tests show the problem when sending the
"display" event asynchronously.

  • notifications/Notification.h:

(WebCore::Notification::create):

  • notifications/NotificationCenter.h:

(WebCore::NotificationCenter::createHTMLNotification):
(WebCore::NotificationCenter::createNotification):

9:21 AM Changeset in webkit [60568] by mnaganov@chromium.org
  • 21 edits
    3 copies in trunk

2010-06-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yuri Semikhatsky.

Web Inspector: add Console API for retrieving memory stats

Add 'console.memory' property which returns an object. Currently
it has two fields: totalJSHeapSize and usedJSHeapSize. Later, it can be
extended for reporting total browser's memory consumption.

https://bugs.webkit.org/show_bug.cgi?id=39646

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::memory):
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::memoryAccessorGetter):
  • page/Console.h:
  • page/Console.idl:
  • page/MemoryInfo.cpp: Added. (WebCore::MemoryInfo::MemoryInfo):
  • page/MemoryInfo.h: Added. (WebCore::MemoryInfo::create): (WebCore::MemoryInfo::totalJSHeapSize): (WebCore::MemoryInfo::usedJSHeapSize):
  • page/MemoryInfo.idl: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
8:20 AM Changeset in webkit [60567] by yurys@chromium.org
  • 7 edits in trunk/WebCore

2010-06-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: support "Continue to Here" in debugger
https://bugs.webkit.org/show_bug.cgi?id=39953

  • English.lproj/localizedStrings.js:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setOneTimeBreakpoint): (WebInspector.BreakpointManager.prototype.removeOneTimeBreakpoint): (WebInspector.BreakpointManager.prototype.addBreakpoint):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.ScriptView.prototype._continueToLine):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.continueToLine): (WebInspector.ScriptsPanel.prototype.debuggerPaused):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype._continueToLine): (WebInspector.SourceView.prototype.updateLocalContent):
7:31 AM Changeset in webkit [60566] by yael.aharon@nokia.com
  • 12 edits in trunk

[Qt] Fix the lifecycle of notification objects
https://bugs.webkit.org/show_bug.cgi?id=40003

Reviewed by Kenneth Rohde Christiansen.

WebKit/qt:

Notification objects are not tightly related to the page that created them,
and should be decoupled from the page.
Create one NotificationPresenter that handles all notifications.
Add ref/deref to the notification objects when they are added/removed from
the queue of active notifications. The same technique is used for XMLHttpRequest.
Instead of deleting all notifications associated with a page when the page is navigated,
delete them on a timer, using the same timeout that QSystemTrayIcon is using.
Break up the show() method into smaller methods.
Use OwnPtr instead of raw pointer for QSystemTrayIcon.
Move creating the QIcon to just before showing it in the QSyetemTrayIcon.

No new tests as this is just a refactoring. Existing notifications test cover the code.

  • Api/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::~QWebPagePrivate):

  • Api/qwebpage_p.h:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::notificationPresenter):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setNotificationsReceiver):
(DumpRenderTreeSupportQt::allowNotificationForOrigin):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::notificationPresenter):
(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::~NotificationIconWrapper):
(WebCore::NotificationIconWrapper::close):
(WebCore::NotificationPresenterClientQt::NotificationPresenterClientQt):
(WebCore::NotificationPresenterClientQt::removeClient):
(WebCore::NotificationPresenterClientQt::show):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationObjectDestroyed):
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::sendEvent):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore::NotificationPresenterClientQt::addClient):

WebKitTools:

Remove the dependency of notifications on QWebPage.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::requestPermissionCallback):
(WebCore::WebPage::WebPage):
(WebCore::DumpRenderTree::requestPermission):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:
7:30 AM Changeset in webkit [60565] by mnaganov@chromium.org
  • 18 edits
    3 deletes in trunk

2010-06-02 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed, rolling out r60563.
http://trac.webkit.org/changeset/60563
https://bugs.webkit.org/show_bug.cgi?id=39646

windows build failed

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:

2010-06-02 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed, rolling out r60563.
http://trac.webkit.org/changeset/60563
https://bugs.webkit.org/show_bug.cgi?id=39646

windows build failed

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/v8/custom/V8ConsoleCustom.cpp:
  • page/Console.h:
  • page/Console.idl:
  • page/MemoryInfo.cpp: Removed.
  • page/MemoryInfo.h: Removed.
  • page/MemoryInfo.idl: Removed.
7:14 AM Changeset in webkit [60564] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: adding new inspector test into GTK's Skipped.

https://bugs.webkit.org/show_bug.cgi?id=40049

  • platform/gtk/Skipped:
7:12 AM Changeset in webkit [60563] by mnaganov@chromium.org
  • 18 edits
    3 copies in trunk

2010-06-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by NOBODY (OOPS!).

Web Inspector: add Console API for retrieving memory stats

Add 'console.memory' property which returns an object. Currently
it has two fields: totalJSHeapSize and usedJSHeapSize. Later, it can be
extended for reporting total browser's memory consumption.

https://bugs.webkit.org/show_bug.cgi?id=39646

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::memory):
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::memoryAccessorGetter):
  • page/Console.h:
  • page/Console.idl:
  • page/MemoryInfo.cpp: Added. (WebCore::MemoryInfo::MemoryInfo):
  • page/MemoryInfo.h: Added. (WebCore::MemoryInfo::create): (WebCore::MemoryInfo::totalJSHeapSize): (WebCore::MemoryInfo::usedJSHeapSize):
  • page/MemoryInfo.idl: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
6:55 AM Changeset in webkit [60562] by pfeldman@chromium.org
  • 34 edits
    4 adds
    1 delete in trunk

2010-06-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add test for resource parameters.

https://bugs.webkit.org/show_bug.cgi?id=40026


Test: http/tests/inspector/resource-parameters.html

  • inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype._buildParameters):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._parseParameters):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshParms):

2010-06-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add test for resource parameters.

https://bugs.webkit.org/show_bug.cgi?id=40026

  • http/tests/inspector/inspector-test.js: (onload): (dumpObject): (dumpArray):
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters-expected.txt: Added.
  • http/tests/inspector/resource-parameters.html: Added.
  • http/tests/inspector/resource-tests.js: Added. (resourceURLComparer):
  • http/tests/inspector/resources/resource-form-data-receiver-iframe.html:
  • inspector/console-format-collections-expected.txt:
  • inspector/console-format-expected.txt:
  • inspector/console-log-before-inspector-open-expected.txt:
  • inspector/console-tests-expected.txt:
  • inspector/elements-panel-structure-expected.txt:
  • inspector/elements-panel-styles-expected.txt:
  • inspector/elements-panel-xhtml-structure-expected.txt:
  • inspector/evaluate-in-frontend-expected.txt:
  • inspector/styles-source-offsets-expected.txt:
  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/timeline-event-dispatch-expected.txt:
  • inspector/timeline-layout-expected.txt:
  • inspector/timeline-mark-timeline-expected.txt:
  • inspector/timeline-network-resource-expected.txt:
  • inspector/timeline-paint-expected.txt:
  • inspector/timeline-parse-html-expected.txt:
  • inspector/timeline-recalculate-styles-expected.txt:
  • inspector/timeline-script-tag-1-expected.txt:
  • inspector/timeline-script-tag-2-expected.txt:
  • inspector/timeline-test.js: (printTimelineRecordProperties):
  • platform/chromium-win/inspector/console-log-before-inspector-open-expected.txt: Removed.
  • platform/chromium-win/inspector/timeline-event-dispatch-expected.txt:
  • platform/chromium-win/inspector/timeline-mark-timeline-expected.txt:
  • platform/chromium-win/inspector/timeline-network-resource-expected.txt:
  • platform/chromium-win/inspector/timeline-paint-expected.txt:
  • platform/chromium-win/inspector/timeline-parse-html-expected.txt:
5:48 AM Changeset in webkit [60561] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix make install on Symbian for headers in package builds when INSTALL_HEADERS is not defined

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-06-02
Reviewed by Simon Hausmann.

First we wrote inst_headers.output with $$[QT_INSTALL_HEADERS] and then
overwrote it with the $$INSTALL_HEADERS variant without checking if the
variable was set.

Fixed and cleaned up the logic of falling back to $$[QT_INSTALL_HEADERS].

  • WebCore.pro:
5:31 AM Changeset in webkit [60560] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60559.
http://trac.webkit.org/changeset/60559
https://bugs.webkit.org/show_bug.cgi?id=40055

It broke python unit test (Requested by Ossy on #webkit).

  • Scripts/webkitpy/common/net/buildbot.py:
5:12 AM Changeset in webkit [60559] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Slave lost shouldn't be recognized as build failed.
https://bugs.webkit.org/show_bug.cgi?id=39282

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/net/buildbot.py:
4:14 AM Changeset in webkit [60558] by xan@webkit.org
  • 7 edits in trunk/WebCore

2010-06-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Style fixes for the generated code in DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=39949

Get rid of extra spaces and wrong indentation in the generated
code.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type): (webkit_dom_test_callback_set_property): (webkit_dom_test_callback_get_property):
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: (webkit_dom_test_interface_set_property): (webkit_dom_test_interface_get_property):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_void_method): (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws): (webkit_dom_test_obj_serialized_value): (webkit_dom_test_obj_method_with_exception): (webkit_dom_test_obj_with_dynamic_frame): (webkit_dom_test_obj_with_dynamic_frame_and_arg): (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad): (webkit_dom_test_obj_with_script_state_void): (webkit_dom_test_obj_with_script_state_obj): (webkit_dom_test_obj_with_script_state_void_exception): (webkit_dom_test_obj_with_script_state_obj_exception): (webkit_dom_test_obj_method_with_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args): (webkit_dom_test_obj_get_read_only_int_attr): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_int_attr): (webkit_dom_test_obj_set_int_attr): (webkit_dom_test_obj_get_long_long_attr): (webkit_dom_test_obj_set_long_long_attr): (webkit_dom_test_obj_get_unsigned_long_long_attr): (webkit_dom_test_obj_set_unsigned_long_long_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_attr_with_exception): (webkit_dom_test_obj_set_attr_with_exception): (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_get_attr_with_getter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (webkit_dom_test_obj_get_script_string_attr): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
4:10 AM Changeset in webkit [60557] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] tests failing with leftover unload handlers
https://bugs.webkit.org/show_bug.cgi?id=30585

  • platform/gtk/Skipped:
3:45 AM Changeset in webkit [60556] by eric@webkit.org
  • 7 edits in trunk/LayoutTests

2010-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Several layout tests needlessly use invalid HTML
https://bugs.webkit.org/show_bug.cgi?id=39985

This change does not change behavior or reduce test coverage.
It only makes our test suite more clear by making our non-parser
tests not bother to test parser quirks which are already covered
by our parsing test suites.

Two invalid cases which are already tested by
the html5lib tests as well as others.

  • Unclosed <title> swallowing the document is covered by <!doctype html><title>foo/title><link></head><body>X and other subtests in html5lib/resources/tests16.dat Missing </title> is also covered by the (invalid) test: fast/js/missing-title-end-tag-js.html
  • Unclosed <tag swallowing the next tag is covered by: fast/invalid/016.html. I suspect it's also covered by various html5lib tests but proved difficult to grep for.
  • css1/box_properties/float_elements_in_series.html:
    • Unclosed <td> tags swallow the following <img> tags. This parser quirk is tested by the HTML5 tests and is an intentional behavior change as part of HTML5. No need for this test to depend on WebKit's old parser behavior.
  • editing/selection/inactive-selection.html:
    • Same as above. Here <div swallows the <script> tag.
  • editing/selection/select-text-overflow-ellipsis.html:
    • An unclosed <title> will swallow the whole document. Intentional HTML5 change, tested by HTML5 test suite and no need to depend on the old title behavior here.
  • fast/dom/title-content-write-set.html:
    • Again, no need to leave an unclosed title.
  • fast/forms/select-set-inner.html:
    • Unclosed <body swallows <p>
  • fast/js/exception-linenums-in-html-2.html:
    • Unclosed <title> swallows the document.
  • html5lib/resources/webkit01.dat:
    • Added a test for <img<img> to make sure it's covered.
3:16 AM Changeset in webkit [60555] by pfeldman@chromium.org
  • 10 edits
    3 adds in trunk

2010-06-02 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Added conversion of inspector's resource representation into HAR.
Moved common resource accessors from ResourceView to Resource.
https://bugs.webkit.org/show_bug.cgi?id=30567

Test: http/tests/inspector/resource-har-conversion.html

3:10 AM Changeset in webkit [60554] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60547.
http://trac.webkit.org/changeset/60547
https://bugs.webkit.org/show_bug.cgi?id=40051

It made fast/overflow/overflow-with-local-background-
attachment.html crash (Requested by Ossy on #webkit).

  • notifications/Notification.h: (WebCore::Notification::create):
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
3:07 AM Changeset in webkit [60553] by eric@webkit.org
  • 12 edits in trunk

2010-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTML5 parser does not track line numbers
https://bugs.webkit.org/show_bug.cgi?id=39984

Update our expectations to show the proper line numbers.
These new line numbers match what the old parser produces.

  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:

2010-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTML5 parser does not track line numbers
https://bugs.webkit.org/show_bug.cgi?id=39984

This adds rudimentary line-number tracking to the HTML5Lexer.
We'll still need to handle \r\n cases eventually, but this
fixes the vast majority of our line-number related failures.

Fixes 268 layout tests. :)

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::reset):
    • Reset m_lineNumber to 0.

(WebCore::HTML5Lexer::consumeEntity):

  • Pass m_lineNumber to advance().

(WebCore::HTML5Lexer::nextToken):

  • Pass m_lineNumber to advance().
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::lineNumber):
    • Expose m_lineNumber for HTML5Tokenizer.

(WebCore::HTML5Lexer::columnNumber):

  • Mirrors the implementation in the old HTMLTokenizer. we might some day support column number tracking in the Lexer. It certainly would be possible.
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::HTML5ScriptRunner):
    • ASSERT we're passed a host.

(WebCore::HTML5ScriptRunner::sourceFromPendingScript):

  • Use PendingScript.startingLineNumber when PendingScript is an inline script.

(WebCore::HTML5ScriptRunner::execute):

  • Now expects a start line number passed from the TreeBuilder.

(WebCore::HTML5ScriptRunner::runScript):

  • Now expects a start line number.
  • html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::PendingScript::PendingScript):
    • Track startingLineNumber for any inline script.
  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::begin):
    • Add a FIXME. The old HTMLTokenizer resets its "lexer" state here.

(WebCore::HTML5Tokenizer::pumpLexer):

  • Pass scriptStartLine to the HTML5ScriptRunner

(WebCore::HTML5Tokenizer::lineNumber):

  • Implementation for Tokenizer.h

(WebCore::HTML5Tokenizer::columnNumber):

  • Implementation for Tokenizer.h
  • html/HTML5Tokenizer.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder):
    • Initialize the new line number tracking variables.

(WebCore::HTML5TreeBuilder::handleScriptEndTag):

  • Save off the line number from the start tag to pass to the ScriptRunner.

(WebCore::HTML5TreeBuilder::takeScriptToProcess):

  • Return the line number from the start tag.

(WebCore::HTML5TreeBuilder::passTokenToLegacyParser):

  • Save off the line number of ever script start tag we see.
  • html/HTML5TreeBuilder.h:
    • Keep both the line number of the last start tag, and the line number of the script we know we're expecting our caller to run before resuming parsing. These are separate to keep the code clean, especially since the last script start tag line number is a hack specific to using the old HTMLParser.
2:54 AM Changeset in webkit [60552] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Timeline should nicely format the Timer timeout
https://bugs.webkit.org/show_bug.cgi?id=40040

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): Format the Timer's timeout time.
2:49 AM Changeset in webkit [60551] by tkent@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed. Test expectation update.

Remove Chromium-Mac expectation of mask-changes.html. The results
is now identical to platform/mac.

  • platform/chromium-mac/svg/custom/mask-changes-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/mask-changes-expected.png: Removed.
2:30 AM Changeset in webkit [60550] by tkent@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Unreviewed. Test expectation update.

Update Windows and Linux results of empty-clip-path.html and
empty-mask.html for r60541.

  • platform/chromium-linux/svg/custom/empty-mask-expected.txt: Removed.
  • platform/chromium-win/svg/custom/empty-clip-path-expected.txt:
  • platform/chromium-win/svg/custom/empty-mask-expected.txt:
2:14 AM Changeset in webkit [60549] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-02 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Fix crash caused when assigned_to is disabled
https://bugs.webkit.org/show_bug.cgi?id=40039

  • Scripts/webkitpy/common/net/bugzilla.py:
2:01 AM Changeset in webkit [60548] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-02 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Clamp dirtyRect updates of composited layer contents to the size
of the layer to avoid writing outside texture bounds.
https://bugs.webkit.org/show_bug.cgi?id=40030

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::updateTextureContents):
1:45 AM Changeset in webkit [60547] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-02 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Notification object ref counting is not correct.
https://bugs.webkit.org/show_bug.cgi?id=39998

Return PassRefPtr<Notification> instead of a raw pointer from the create methods
for Web Notifications.

No new tests are needed, as existing tests show the problem when sending the
"display" event asynchronously.

  • notifications/Notification.h: (WebCore::Notification::create):
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
1:30 AM Changeset in webkit [60546] by eric@webkit.org
  • 4 edits in trunk

2010-06-02 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Dirk Schulze.

[Qt] Image shadow doesn't work
https://bugs.webkit.org/show_bug.cgi?id=37804

Enable image shadow basic test and disable image shadow transparent test case, that failed
because of the Qt known issue on transparent image.

  • platform/qt/Skipped:

2010-06-02 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Dirk Schulze.

[Qt] Image shadow doesn't work
https://bugs.webkit.org/show_bug.cgi?id=37804

Implement the code for image shadow

  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
1:18 AM Changeset in webkit [60545] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-02 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

Adding the precision qualifier to fragment shaders used by the GL
compositor in chromium to turn them into valid GLSL ES.
https://bugs.webkit.org/show_bug.cgi?id=40022

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedGLObjects):
1:04 AM Changeset in webkit [60544] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-02 Laszlo Gombos <Laszlo Gombos>

Reviewed by David Levin.

Fix type qualifier is meaningless on cast type in SVGFEColorMatrixElement::build
https://bugs.webkit.org/show_bug.cgi?id=40015

No new tests as there is no new functionality.

Remove const from the cast type.

  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::build):
12:50 AM Changeset in webkit [60543] by eric@webkit.org
  • 17 edits in trunk

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • configure.ac:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • Configurations/FeatureDefines.xcconfig:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • features.gypi:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • Configurations/FeatureDefines.xcconfig:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-06-02 Sterling Swigart <sswigart@google.com>

Reviewed by David Levin.

Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=39906

  • Scripts/build-webkit:
12:18 AM Changeset in webkit [60542] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-02 Dirk Schulze <krit@webkit.org>

Uneviewed.

SVG repaintRect should be empty if content got clipped away
https://bugs.webkit.org/show_bug.cgi?id=39965


Baseline update for Qt.

  • platform/qt/svg/custom/empty-mask-expected.txt:

Jun 1, 2010:

11:16 PM Changeset in webkit [60541] by krit@webkit.org
  • 25 edits in trunk

2010-06-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
https://bugs.webkit.org/show_bug.cgi?id=39965


The SVG repaintRect of the renderer was not empty, if the content got clipped away.
The MaskerData/ClipperData <-> RenderObject mapping is set up during the layout phase now, to be able to
relayout a RenderObject, if it's repaintRect is empty. This has the following reason:
We apply the object to the resource on painting at the moment.
With an empty repaintRect, paint() quits earlier and therefore the object doesn't get applied to the resource.
This can cause problems, if the resource get changed by animations or scripts.
On a change, the resource tells all it's callers to relayout.
If the reference to the caller (our RenderObject) is missing, the object won't ever update
and therefore won't get drawn.
We already have LayoutTests that cover this problem. The complete repaintRect calculation
(including the smallest clipping area and shadow size calculation) moved from the renderers to SVGRenderSupport.
This eliminates redundant code.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::updateCachedBoundaries):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::intersectRepaintRectWithResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasClipper): (WebCore::SVGRenderStyle::hasMasker): (WebCore::SVGRenderStyle::hasFilter):


2010-06-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
https://bugs.webkit.org/show_bug.cgi?id=39965


New repaintRect calculation causes updates of tests, where the content gets
clipped away.

  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/custom/empty-clip-path-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
11:13 PM Changeset in webkit [60540] by krit@webkit.org
  • 26 edits in trunk

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60539.
http://trac.webkit.org/changeset/60539
https://bugs.webkit.org/show_bug.cgi?id=40043

Accidentally added an unreviewed and invalid change to the
patch. (Requested by krit on #webkit).

  • rendering/RenderPath.cpp: (WebCore::RenderPath::updateCachedBoundaries):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::filterBoundingBoxForRenderer): (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer): (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.h:
  • svg/SVGColor.cpp: (WebCore::SVGColor::colorFromRGBColorString):

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60539.
http://trac.webkit.org/changeset/60539
https://bugs.webkit.org/show_bug.cgi?id=40043

Accidentally added an unreviewed and invalid change to the
patch. (Requested by krit on #webkit).

  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/custom/empty-clip-path-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
11:04 PM Changeset in webkit [60539] by krit@webkit.org
  • 26 edits in trunk

2010-06-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
https://bugs.webkit.org/show_bug.cgi?id=39965


The SVG repaintRect of the renderer was not empty, if the content got clipped away.
The MaskerData/ClipperData <-> RenderObject mapping is set up during the layout phase now, to be able to
relayout a RenderObject, if it's repaintRect is empty. This has the following reason:
We apply the object to the resource on painting at the moment.
With an empty repaintRect, paint() quits earlier and therefore the object doesn't get applied to the resource.
This can cause problems, if the resource get changed by animations or scripts.
On a change, the resource tells all it's callers to relayout.
If the reference to the caller (our RenderObject) is missing, the object won't ever update
and therefore won't get drawn.
We already have LayoutTests that cover this problem. The complete repaintRect calculation
(including the smallest clipping area and shadow size calculation) moved from the renderers to SVGRenderSupport.
This eliminates redundant code.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::updateCachedBoundaries):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.h: (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
  • rendering/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.h: (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::intersectRepaintRectWithResources):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeResources):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasClipper): (WebCore::SVGRenderStyle::hasMasker): (WebCore::SVGRenderStyle::hasFilter):


2010-06-01 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG repaintRect should be empty if content got clipped away
https://bugs.webkit.org/show_bug.cgi?id=39965


New repaintRect calculation causes updates of tests, where the content gets
clipped away.

  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/custom/empty-clip-path-expected.txt:
  • platform/mac/svg/custom/empty-mask-expected.txt:
10:57 PM Changeset in webkit [60538] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed, build fix.

Roll our r60536. The change was not wrong, but not good for Chromium bots status.

10:49 PM Changeset in webkit [60537] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebKit/qt

2010-06-01 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add documentation to the QtWebkit bridge
https://bugs.webkit.org/show_bug.cgi?id=35861

This patch includes comprehensive qdoc documentation for the QtWebkit bridge.

  • docs/qtwebkit-bridge.qdoc: Added.
  • docs/qtwebkit.qdoc:
  • docs/webkitsnippets/doc_src_qtscript.qdoc: Added.
  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: Added. (wrapInFunction):
10:47 PM Changeset in webkit [60536] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Checking out lighttpd
https://bugs.webkit.org/show_bug.cgi?id=39948

  • Add lighttpd only on Windows. It is used by new-run-webkit-tests.
  • Add libvpx.
  • Remove pthreads-win32 from DEPS. It has not been used since Chromium r28642.
  • Update Chromium revision to use Windows resource query code and webkit_glue dependency fix.
  • DEPS:
10:04 PM Changeset in webkit [60535] by eric@webkit.org
  • 9 edits
    3 deletes in trunk

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60530.
http://trac.webkit.org/changeset/60530
https://bugs.webkit.org/show_bug.cgi?id=40041

resource-har-conversion failed on GTK (Requested by abarth on
#webkit).

  • http/tests/inspector/inspector-test.js:
  • http/tests/inspector/resource-har-conversion-expected.txt: Removed.
  • http/tests/inspector/resource-har-conversion.html: Removed.

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60530.
http://trac.webkit.org/changeset/60530
https://bugs.webkit.org/show_bug.cgi?id=40041

resource-har-conversion failed on GTK (Requested by abarth on
#webkit).

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/HAREntry.js: Removed.
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.set url):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshQueryString): (WebInspector.ResourceView.prototype._refreshFormData): (WebInspector.ResourceView.prototype._refreshParms):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
8:52 PM Changeset in webkit [60534] by tkent@chromium.org
  • 2 edits
    12 adds in trunk/LayoutTests

Unreviewed. Test expectation update.

Add Chromium-win Chromium-linux results for backslash-to-yen-sign*.html tests.

  • platform/chromium-linux/fast/text/backslash-to-yen-sign-dynamic-expected.checksum: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-expected.checksum: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-dynamic-expected.checksum: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-dynamic-expected.png: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.checksum: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:42 PM Changeset in webkit [60533] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations.

  • platform/chromium/test_expectations.txt: moving-shadow-on-path has been rebaselined. input-search-padding may or may not be flaky.
8:40 PM Changeset in webkit [60532] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-01 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: warnings when reloading page
https://bugs.webkit.org/show_bug.cgi?id=39694

Made sure recaching and masks aren't attempted on zero-size layers.

No new tests. Old tests (e.g. LayoutTests/compositing/masks) show the problem.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::MaskEffectQt::draw): (WebCore::GraphicsLayerQtImpl::recache):
8:28 PM Changeset in webkit [60531] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-01 anton muhin <antonm@google.com>

Reviewed by Nate Chapin.

[Chromium] enforce presence of named property query callback if named property enumerator is present
https://bugs.webkit.org/show_bug.cgi?id=40006
We need to be able to distinguish between enumerable and not enumerable properties
in the presence of named interceptor. V8 is migrating to use query
callback to report enumerable properties and fallback check---
using getter callback---would report properties as not enumerable.
Thus if there is an enumerator callback, there should be query callback as well.
(see V8's r4751).

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8NPObject.cpp: (WebCore::npObjectQueryProperty): (WebCore::createV8ObjectForNPObject):
  • bindings/v8/custom/V8StorageCustom.cpp: (WebCore::V8Storage::namedPropertyQuery):
8:15 PM Changeset in webkit [60530] by eric@webkit.org
  • 9 edits
    3 adds in trunk

2010-06-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Added test for contents of resource record and HAR conversion results.
Added generic object dumper to inspector-tests.js.
https://bugs.webkit.org/show_bug.cgi?id=30567

  • http/tests/inspector/inspector-test.js: (dumpObject):
  • http/tests/inspector/resource-har-conversion-expected.txt: Added.
  • http/tests/inspector/resource-har-conversion.html: Added.

2010-06-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Added conversion of inspector's resource representation into HAR.
Moved common resource accessors from ResourceView to Resource.
https://bugs.webkit.org/show_bug.cgi?id=30567

Test: http/tests/inspector/resource-har-conversion.html

8:03 PM Changeset in webkit [60529] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-01 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Fix "variable may be used before being set" warning in TextResourceDecoder::checkForHeadCharset
https://bugs.webkit.org/show_bug.cgi?id=40001

No new tests as there is no new functionality.

Initialize len to 0 just to eliminate the compiler warning.

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
7:52 PM Changeset in webkit [60528] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-01 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Safari specific files InspectorFrontendClientLocal were removed from chromium project.
https://bugs.webkit.org/show_bug.cgi?id=39993

  • WebCore.gypi:
7:38 PM Changeset in webkit [60527] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Fix broken code generation in GenerateParametersCheckExpression.
https://bugs.webkit.org/show_bug.cgi?id=39960

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: Updated baseline.
7:27 PM Changeset in webkit [60526] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test expectations.

  • Mark input-search-padding.html flaky on Mac
  • Remove function_arguments.html, styles-disable-then-enable.html, notifications-replace.html and notifications-rtl.html. They pass recently.
  • platform/chromium/test_expectations.txt:
7:07 PM Changeset in webkit [60525] by eric@webkit.org
  • 6 edits in trunk

2010-06-01 Raine Makelainen <raine.makelainen@nokia.com>

Reviewed by Simon Hausmann.

[Qt]: REGRESSION(r58703): QWebSettings::JavascriptCanAccessClipboard has wrong case in "Javascript" part.
https://bugs.webkit.org/show_bug.cgi?id=39878

QWebSettings::JavaScriptCanAccessClipboard reverted back to
QWebSettings::JavascriptCanAccessClipboard. QWebSettings::DOMPasteAllowed enum removed.

Value of QWebSettings::JavascriptCanAccessClipboard to setDOMPasteAllowed and
setJavaScriptCanAccessClipboard of WebCore::Settings.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:

2010-06-01 Raine Makelainen <raine.makelainen@nokia.com>

Reviewed by Simon Hausmann.

Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setJavaScriptCanAccessClipboard):
6:24 PM Changeset in webkit [60524] by jamesr@google.com
  • 19 edits
    14 adds
    1 delete in trunk/LayoutTests

2010-06-01 James Robinson <jamesr@chromium.org>

Unreviewed. Update the chromium baselines.

  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.png: Removed.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.txt:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/chromium/test_expectations.txt:
5:34 PM Changeset in webkit [60523] by mrowe@apple.com
  • 1 edit
    1 delete in trunk/WebCore

Remove Breakpoint.js. It was emptied in r60450 but for some reason it was not
deleted at that time. The presence of empty files within the inspector's resource
folder causes Mac OS X production builds to fail.

Rubber-stamped by Adam Roben.

  • inspector/front-end/Breakpoint.js: Removed.
5:30 PM Changeset in webkit [60522] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Fixes Gtk buildbot. Suggested by Gavin Barraclough.

https://bugs.webkit.org/show_bug.cgi?id=40012
Callable objects created via JavaScriptCore API cannot be used as Geolocation callbacks

Disable subtests that check Math.abs - JS host objects are still InternalFunctions in
interpreter, so they behave differently from JIT. The bug tracks deciding what's the best
solution here.

  • fast/dom/Geolocation/argument-types-expected.txt:
  • fast/dom/Geolocation/script-tests/argument-types.js:
5:23 PM Changeset in webkit [60521] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

5:22 PM Changeset in webkit [60520] by mrowe@apple.com
  • 1 copy in tags/Safari-533.15

New tag.

5:04 PM Changeset in webkit [60519] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebKit/mac

Merge r60504.

5:04 PM Changeset in webkit [60518] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r60502.

5:04 PM Changeset in webkit [60517] by alice.liu@apple.com
  • 2 edits in trunk/WebKit2

Build fix. Not reviewed

  • win/WebKit2Generated.make: Added WKRetainPtr.h
4:58 PM Changeset in webkit [60516] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-06-01 James Robinson <jamesr@chromium.org>

Unreviewed. Update expected results for r60503
https://bugs.webkit.org/show_bug.cgi?id=38851

  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
4:58 PM Changeset in webkit [60515] by jhawkins@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 James Hawkins <jhawkins@chromium.org>

UNREVIEWED: build fix.

Implement the added virtual methods from PopupMenuClient to
TestPopupMenuClient.

  • tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::selectionChanged): (WebKit::TestPopupMenuClient::selectionCleared):
4:29 PM Changeset in webkit [60514] by jhawkins@chromium.org
  • 12 edits in trunk

2010-05-24 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement new PopupMenuClient methods selectionChanged()
and selectionCleared(). Expose placeHolder methods and isAutoFilled()
in WebInputElement.

https://bugs.webkit.org/show_bug.cgi?id=39639

  • public/WebInputElement.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::didSelectAutoFillSuggestion): (WebKit::WebViewClient::didClearAutoFillSelection):
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::selectionChanged): (WebKit::AutoFillPopupMenuClient::selectionCleared): (WebKit::AutoFillPopupMenuClient::popupDidHide):
  • src/AutoFillPopupMenuClient.h:
  • src/SuggestionsPopupMenuClient.h: (WebKit::SuggestionsPopupMenuClient::selectionChanged): (WebKit::SuggestionsPopupMenuClient::selectionCleared):
  • src/WebInputElement.cpp: (WebKit::WebInputElement::setPlaceholder): (WebKit::WebInputElement::placeholder): (WebKit::WebInputElement::isAutofilled):

2010-05-24 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

Added ability for PopupMenuClient to signal when

  • selection changed, and
  • selection cleared.

https://bugs.webkit.org/show_bug.cgi?id=39639

No new tests because this functionality is intentionally hidden from
everything other than renderer.

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::clearSelection):
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::RenderMenuList::selectionChanged): (WebCore::RenderMenuList::RenderMenuList::selectionCleared):
  • rendering/RenderTextControlSingleLine.h: (WebCore::RenderTextControlSingleLine::selectionChanged): (WebCore::RenderTextControlSingleLine::selectionCleared):
4:25 PM Changeset in webkit [60513] by dumi@chromium.org
  • 6 edits in trunk/WebCore

Check if a database needs to be auto-vacuumed only after transactions that have deleted something.
https://bugs.webkit.org/show_bug.cgi?id=39688

Reviewed by Dimitri Glazkov.

  • storage/Database.cpp:

(WebCore::Database::resetDeletes):
(WebCore::Database::hadDeletes):

  • storage/Database.h:
  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::resetDeletes):
(WebCore::DatabaseAuthorizer::dropTable):
(WebCore::DatabaseAuthorizer::dropTempTable):
(WebCore::DatabaseAuthorizer::dropIndex):
(WebCore::DatabaseAuthorizer::dropTempIndex):
(WebCore::DatabaseAuthorizer::dropTrigger):
(WebCore::DatabaseAuthorizer::dropTempTrigger):
(WebCore::DatabaseAuthorizer::dropView):
(WebCore::DatabaseAuthorizer::dropTempView):
(WebCore::DatabaseAuthorizer::dropVTable):
(WebCore::DatabaseAuthorizer::allowDelete):
(WebCore::DatabaseAuthorizer::updateDeletesBasedOnTableName): Added.

  • storage/DatabaseAuthorizer.h:

(WebCore::DatabaseAuthorizer::hadDeletes):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::postflightAndCommit):

4:13 PM Changeset in webkit [60512] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Bug 40021 - Refactor bytecode generation for calls so that register for this & args are allocated together

Reviewed by Sam Weinig.

This is a useful stepping stone towards reversing argument order.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addParameter):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallEval):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::thisRegister):
(JSC::CallArguments::argumentRegister):
(JSC::CallArguments::callFrame):
(JSC::CallArguments::count):
(JSC::BytecodeGenerator::shouldEmitProfileHooks):

  • bytecompiler/NodesCodegen.cpp:

(JSC::NewExprNode::emitBytecode):
(JSC::CallArguments::CallArguments):
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

3:47 PM Changeset in webkit [60511] by ap@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

A nicer Tiger build fix.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/Base.xcconfig: Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
3:37 PM Changeset in webkit [60510] by sullivan@apple.com
  • 3 edits in trunk/WebKit2

Added _WKRetainPtr to .exp file, and added .exp file to Xcode project.

Rubber-stamped by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:

Added mac/WebKit2.exp.

  • mac/WebKit2.exp:

Added _WKRetainPtr.

2:41 PM Changeset in webkit [60509] by hyatt@apple.com
  • 8 edits in trunk

Add a preference for paginating during layout (the new model for computing page breaks).

Reviewed by Anders Carlsson.

WebCore:

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setPaginateDuringLayoutEnabled):
(WebCore::Settings::paginateDuringLayoutEnabled):

WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences paginateDuringLayoutEnabled]):
(-[WebPreferences setPaginateDuringLayoutEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

2:39 PM Changeset in webkit [60508] by dumi@chromium.org
  • 11 edits in trunk/WebCore

Clean up the DB classes in preparation for a bigger refactoring.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

  • storage/ChangeVersionWrapper.cpp:
  • storage/ChangeVersionWrapper.h:
  • storage/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::lastActionChangedDatabase):
(WebCore::Database::lastActionWasInsert):
(WebCore::Database::inProgressTransactionCompleted):
(WebCore::Database::securityOrigin):

  • storage/Database.h:

(WebCore::Database::sqliteDatabase):
(WebCore::Database::databaseDebugName):

  • storage/DatabaseTask.cpp:

(WebCore::DatabaseTransactionTask::doPerformTask):

  • storage/DatabaseTask.h:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):

  • storage/SQLStatement.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::postflightAndCommit):
(WebCore::SQLTransaction::cleanupAfterSuccessCallback):
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):

  • storage/SQLTransaction.h:
2:26 PM Changeset in webkit [60507] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Update expected results after r60503.

Reviewed by Laszlo Gombos.

  • platform/qt/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/qt/svg/css/arrow-with-shadow-expected.txt:
  • platform/qt/svg/css/stars-with-shadow-expected.txt:
2:26 PM Changeset in webkit [60506] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

Fixed typo/wordo that prevented a certain flavor of constructor from compiling.

Rubber-stamped by Anders Carlsson.

  • UIProcess/API/cpp/WKRetainPtr.h:

(WebKit::WKRetainPtr::WKRetainPtr):
Changed the mysterious "retainWKPtr" to "WKRetain".

2:21 PM Changeset in webkit [60505] by ap@apple.com
  • 2 edits in trunk/WebKitTools

A real Tiger build fix.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS for all configurations, not just debug.
2:15 PM Changeset in webkit [60504] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=40025
<rdar://problem/8046273> All Flash content crashes after installing CS5 Design Premium.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView supportsSnapshotting]): Do not support snapshotting Flash 10.1 if the version is less than 10.1.53.60.
1:33 PM Changeset in webkit [60503] by rwlbuis@webkit.org
  • 19 edits
    3 adds in trunk

2010-06-01 Rob Buis <rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

Large SVG rect with shadow fails to render
https://bugs.webkit.org/show_bug.cgi?id=38851

Store intermediate shadow calculation in floats to prevent integer overflow.

Test: svg/filters/shadow-on-rect-large.svg

  • rendering/style/SVGRenderStyle.cpp: (WebCore::getSVGShadowExtent): (WebCore::SVGRenderStyle::inflateForShadow):
1:15 PM Changeset in webkit [60502] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

QuickTime 7.6.4 + Safari Nightly = Crash
https://bugs.webkit.org/show_bug.cgi?id=40019
rdar://problem/8035443

Reviewed by Sam Weinig.

Check the return value of QTCFPropertyListCreateXMLData before calling CFDataGetLength().

  • platform/graphics/win/QTCFDictionary.cpp:

(QTCFDictionaryCreateCopyWithDataCallback):

1:06 PM Changeset in webkit [60501] by rwlbuis@webkit.org
  • 6 edits
    3 adds in trunk

2010-06-01 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

Manipulating SVG element attributes in Javascript does not work as expected
https://bugs.webkit.org/show_bug.cgi?id=34328

Reset the viewBox to be empty when removing the viewBox attribute.

Test: svg/custom/svg-viewBox-dynamic.html

1:03 PM Changeset in webkit [60500] by jer.noble@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Rolling back change made on wrong branch.

12:42 PM Changeset in webkit [60499] by jer.noble@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

QuickTime 7.6.4 + Safari Nightly = Crash
https://bugs.webkit.org/show_bug.cgi?id=40019
rdar://problem/8035443

Reviewed by Sam Weinig.

Check the return value of QTCFPropertyListCreateXMLData before calling CFDataGetLength().

  • platform/graphics/win/QTCFDictionary.cpp:

(QTCFDictionaryCreateCopyWithDataCallback):

12:21 PM Changeset in webkit [60498] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Memory Leak: The main resource of page is not free.
https://bugs.webkit.org/show_bug.cgi?id=39973

Fix refcount tracking of the main resource. Patch by Genhua Liu.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
12:12 PM Changeset in webkit [60497] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Tiger build fix.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
12:09 PM Changeset in webkit [60496] by Chris Fleizach
  • 2 edits in trunk/WebCore

AX: WebKit doesn't call [super -accessibilityAttributeValue:attribute forParameter:] when it encounters a parameterized attribute that it doesn't handle.
https://bugs.webkit.org/show_bug.cgi?id=39324

Reviewed by Beth Dakin.

There are some parameters that super handles that are not explicitly returned by the list of the element's attributes.
In those cases, super should handle.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

12:01 PM Changeset in webkit [60495] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60483.
http://trac.webkit.org/changeset/60483
https://bugs.webkit.org/show_bug.cgi?id=40013

Breaks Mac and Linux builds (Requested by antonm on #webkit).

  • DEPS:
11:58 AM Changeset in webkit [60494] by hyatt@apple.com
  • 3 edits
    8 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=15550, complete implementation of column-span. Add support for nested column
spans. When a column span is nested inside multiple enclosing blocks, the blocks have to be split around the column-span.
We do this using block element continuations, the same kind of solution we employed for blocks inside inlines.

Reviewed by Beth Dakin.

The code for block continuations is very similar to the code for inline continuations. It may be possible to refactor the
code into RenderBoxModelObject so that more of it can be shared, but this first pass avoids that so as not to risk
causing any regressions in core rendering.

Note also that - just as with inline continuations - you can't unsplit block continuations yet. There is no technical limitation
here... the functions just need to be written to handle it.

Added new tests in fast/multicol/span.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::continuationBefore):
(WebCore::RenderBlock::addChildToContinuation):
(WebCore::RenderBlock::containingColumnsBlock):
(WebCore::RenderBlock::clone):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::splitFlow):
(WebCore::RenderBlock::splitAnonymousBlocksAroundChild):
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks):
(WebCore::RenderBlock::columnsBlockForSpanningElement):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::addChildIgnoringContinuation):
(WebCore::RenderBlock::blockElementContinuation):
(WebCore::RenderBlock::layoutColumns):

  • rendering/RenderBlock.h:
11:51 AM Changeset in webkit [60493] by ap@apple.com
  • 3 edits in trunk/WebCore

Build fix.

Hopefully, touching WebCore.base.exp will actually rebuild the export file.

  • WebCore.Geolocation.exp:
  • WebCore.base.exp:
11:50 AM Changeset in webkit [60492] by dumi@chromium.org
  • 5 edits in trunk

WebCore: Execute void callbacks in the context they were created in.
https://bugs.webkit.org/show_bug.cgi?id=39145

Reviewed by Adam Barth.

  • bindings/v8/custom/V8CustomVoidCallback.cpp:

(WebCore::V8CustomVoidCallback::V8CustomVoidCallback):
(WebCore::V8CustomVoidCallback::handleEvent):

  • bindings/v8/custom/V8CustomVoidCallback.h:

LayoutTests: storage/transaction-success-callback-isolated-world.html is being fixed.
https://bugs.webkit.org/show_bug.cgi?id=39145

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
11:40 AM Changeset in webkit [60491] by xan@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-06-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix-up for previous leak fix, the identifier was not always duped.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_add_resource):
11:08 AM Changeset in webkit [60490] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Plug a small leak.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
11:04 AM Changeset in webkit [60489] by mrobinson@webkit.org
  • 4 edits
    2 adds in trunk

2010-05-12 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Get more mouse tests passing
https://bugs.webkit.org/show_bug.cgi?id=39040

Unskip tests that are now passing.

  • platform/gtk/Skipped:

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Get more mouse tests passing
https://bugs.webkit.org/show_bug.cgi?id=39040

Reproduce the logic from the Windows EventSender for mapping
button numbers to GDK button numbers. Move this logic to the
prepareMouseButtonEvent helper.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Reproduce Windows logic. (contextClickCallback): Move mapping logic to prepareMouseButtonEvent. (mouseDownCallback): Ditto. (mouseUpCallback): Ditto.
10:48 AM Changeset in webkit [60488] by ap@apple.com
  • 22 edits
    2 adds
    2 deletes in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=39434
REGRESSION (r59811): Geolocation callbacks cannot be created

  • DerivedSources.make: Don't append both WebCore.Geolocation.exp and WebCore.ClientBasedGeolocation.exp, they are mutually exclusive.
  • WebCore.Geolocation.exp: Touched to force .exp file rebuild.
  • WebCore.xcodeproj/project.pbxproj: Removed GeolocationService related files.
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionCallback): Functions defined in JavaScript code no longer inherit from InternalFunction, they inherit from JSFunction. This check is still imperfect, because it's not clear what definition of "function" should really be used, if any - other bindings code never checks callback type. (WebCore::createPositionErrorCallback): Ditto.
  • page/Geolocation.h: Don't include GeolocationService.h unless it's going to be used.
10:46 AM Changeset in webkit [60487] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-01 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Explicitly use PTHREAD_MUTEX_NORMAL to create pthread mutex.
https://bugs.webkit.org/show_bug.cgi?id=39893

  • wtf/ThreadingPthreads.cpp: (WTF::Mutex::Mutex):
10:26 AM Changeset in webkit [60486] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Xan Lopez.

[GTK] Use DEFINE_STATIC_LOCAL for threadMapMutex and threadMap
https://bugs.webkit.org/show_bug.cgi?id=39831

Use DEFINE_STATIC_LOCAL for static local variables.

  • wtf/gtk/ThreadingGtk.cpp: (WTF::threadMapMutex): (WTF::threadMap): (WTF::identifierByGthreadHandle):
10:26 AM Changeset in webkit [60485] by mrobinson@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed. Fix ChangeLog reordering from my last commit.

10:24 AM Changeset in webkit [60484] by jorlow@chromium.org
  • 15 edits in trunk

2010-06-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

IndexedDB cleanup
https://bugs.webkit.org/show_bug.cgi?id=40007

Remove the exception code parameter since this function can no longer
cause an exception.

  • storage/IDBObjectStoreRequest.idl:
  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):
  • storage/IndexedDatabaseRequest.h:
  • storage/IndexedDatabaseRequest.idl:

2010-06-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

IndexedDB cleanup
https://bugs.webkit.org/show_bug.cgi?id=40007

Remove the exception code paramter (that hasn't been used for a while).
Add asserts to default implementations.

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::name): (WebKit::WebIDBDatabase::description): (WebKit::WebIDBDatabase::version): (WebKit::WebIDBDatabase::objectStores):
  • public/WebIndexedDatabase.h: (WebKit::WebIndexedDatabase::open):
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h:
10:21 AM Changeset in webkit [60483] by antonm@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-01 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

Rolling Chromium revision to bring recent changes to V8.

  • DEPS:
10:18 AM Changeset in webkit [60482] by mrobinson@webkit.org
  • 10 edits
    2 adds in trunk

2010-06-01 Sergio Villar Senin <svillar@igalia.com>

Unskipping tests. No review necessary.

[GTK] unskip some editing tests that are actually working
https://bugs.webkit.org/show_bug.cgi?id=39999

  • platform/gtk/Skipped:

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853

Add GOwnPtr wrapper for GdkEvent and expose a setter for
PlatformMouseEvent::m_clickCount.

  • GNUmakefile.am: Add GOwnPtrGtk.{cpp,h} to the sources list.
  • platform/PlatformMouseEvent.h: (WebCore::PlatformMouseEvent::setClickCount): Added.
  • platform/gtk/GOwnPtrGtk.cpp: Added. (WTF::GdkEvent):
  • platform/gtk/GOwnPtrGtk.h: Added.

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853

Handle click counting much like the Windows port. GTK+ only
counts triple-clicks natively, so use GTK+ double-click settings
to count clicks with even larger click counts. Also filter the
extra GDK_BUTTON_PRESS before GDK_{2,3}BUTTON_PRESS events using
gdk_event_peek().

  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): Count clicks manually. Filter extra events.

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853

WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
the GDK event queue entirely, we simply do not send the extra event.

  • DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately. (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
10:02 AM Changeset in webkit [60481] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-01 Sergio Villar Senin <svillar@igalia.com>

Unskipping tests. No review necessary.

[GTK] unskip some editing tests that are actually working
https://bugs.webkit.org/show_bug.cgi?id=39999

  • platform/gtk/Skipped:
9:06 AM Changeset in webkit [60480] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Not reviewed. Build fix.

Fix GTK+ build caused by a bad merge.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
8:47 AM Changeset in webkit [60479] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-01 Martin Robinson <mrobinson@webkit.org>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853

Small EventSender cleanups. Consolidate some common code. Style fixes.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Added. (contextClickCallback): Use prepareMouseButtonEvent. (mouseDownCallback): Use prepareMouseButtonEvent. (mouseUpCallback): Use prepareMouseButtonEvent. (mouseMoveToCallback): Small style fix.
8:04 AM QtWebKitTriageRoster edited by Csaba Osztrogonác
bbandix <=> Ossy (diff)
7:58 AM Changeset in webkit [60478] by mrobinson@webkit.org
  • 4 edits in trunk/WebKitTools

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Double clicks cause three button press events
https://bugs.webkit.org/show_bug.cgi?id=38853

Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
to pause for a specified amount of time. It is used in the processing of drag-
-and-drop data as well as to separate distinct mouse double-clicks in some tests.
This patch enables tests that rely on the latter behavior to pass.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
  • DumpRenderTree/gtk/EventSender.cpp: (leapForwardCallback): Add support for adjusting the time offset on leapForward(). (contextClickCallback): Use sendOrQueueEvent. (updateClickCount): Take the time offset into account when counting clicks. (mouseDownCallback): Use sendOrQueueEvent. (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton. (mouseUpCallback): Use sendOrQueueEvent. (mouseMoveToCallback): Ditto. (mouseWheelToCallback): Ditto. (sendOrQueueEvent): Added. (dispatchEvent): Added. (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent. (makeEventSender): Only initialize the EventSender when loading the top frame.
  • DumpRenderTree/gtk/EventSender.h: Ditto.
7:52 AM Changeset in webkit [60477] by agl@chromium.org
  • 2 edits in trunk/WebCore

2010-06-01 Adam Langley <agl@chromium.org>

Reviewed by Eric Seidel.

[chromium] respect the user's embedded bitmap settings on Linux.

We plumbed everything through Skia and Chrome, but forgot to connect
the two wires inside WebCore.

(Note: no layout test because test_shell forces this option off. Also,

the test font which triggers this behaviour is 32MB.)

https://bugs.webkit.org/show_bug.cgi?id=39894
http://code.google.com/p/chromium/issues/detail?id=21149

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
7:33 AM Changeset in webkit [60476] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix installation of the QtWebKit module .pri file when building inside of Qt

Reviewed by Laszlo Gombos.

  • WebCore.pro:
6:26 AM Changeset in webkit [60475] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix a QtWebKit.pc corruption problem.
https://bugs.webkit.org/show_bug.cgi?id=36826

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-06-01
Reviewed by Simon Hausmann.

The problem occurs while installing QtWebKit from trunk
or a source package.

  • WebCore.pro:
6:24 AM Changeset in webkit [60474] by Simon Hausmann
  • 3 edits
    1 move in trunk

WebCore: [Qt] Fix Symbian package dependencies of apps against QtWebKit when installing into Qt

Reviewed by Laszlo Gombos.

Install the versioning qt_webkit_version.pri into $$[QMAKE_MKSPECS]/modules, which is
where mkspecs/features/qt.prf expects it.

  • WebCore.pro:

WebKit/qt: [Qt] Rename versioning .pri file to what Qt's mkspecs/features/qt.pri expects.

Reviewed by Laszlo Gombos.

  • qt_webkit_version.pri: Renamed from WebKit/qt/qtwebkit_version.pri.
6:12 AM Changeset in webkit [60473] by eric@webkit.org
  • 9 edits in trunk

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60470.
http://trac.webkit.org/changeset/60470
https://bugs.webkit.org/show_bug.cgi?id=39990

Need to rollout until bot can be updated (Requested by jorlow
on #webkit).

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyDeleter): (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::indexedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):

2010-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r60470.
http://trac.webkit.org/changeset/60470
https://bugs.webkit.org/show_bug.cgi?id=39990

Need to rollout until bot can be updated (Requested by jorlow
on #webkit).

  • DEPS:
5:44 AM Changeset in webkit [60472] by kov@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-05-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] Missing links to documentation of general functions
https://bugs.webkit.org/show_bug.cgi?id=39964

Add global functions section, and move those functions that are
currently in WebKitWebView's source file to the bottom, along with
the description.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_dom_document): (webkit_get_default_session):
4:59 AM Changeset in webkit [60471] by mrobinson@webkit.org
  • 85 edits
    1 delete in trunk

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=39101

The timing fix changed expected results for many tests, so regenerate
results for these tests.

  • platform/gtk/Skipped: Unskip tests that should be passing now.
  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/basic/comments-expected.txt:
  • platform/gtk/css1/basic/containment-expected.txt:
  • platform/gtk/css1/basic/id_as_selector-expected.txt:
  • platform/gtk/css1/basic/inheritance-expected.txt:
  • platform/gtk/css1/box_properties/acid_test-expected.txt: Removed.
  • platform/gtk/css1/box_properties/border-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
  • platform/gtk/css1/box_properties/border_left-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width-expected.txt:
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width-expected.txt:
  • platform/gtk/css1/box_properties/border_style-expected.txt:
  • platform/gtk/css1/box_properties/border_top-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width-expected.txt:
  • platform/gtk/css1/box_properties/border_width-expected.txt:
  • platform/gtk/css1/box_properties/clear-expected.txt:
  • platform/gtk/css1/box_properties/clear_float-expected.txt:
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/gtk/css1/box_properties/float_margin-expected.txt:
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/gtk/css1/box_properties/height-expected.txt:
  • platform/gtk/css1/box_properties/margin-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom-expected.txt:
  • platform/gtk/css1/box_properties/margin_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_left-expected.txt:
  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/margin_top-expected.txt:
  • platform/gtk/css1/box_properties/padding-expected.txt:
  • platform/gtk/css1/box_properties/padding_bottom-expected.txt:
  • platform/gtk/css1/box_properties/padding_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_left-expected.txt:
  • platform/gtk/css1/box_properties/padding_right-expected.txt:
  • platform/gtk/css1/box_properties/padding_top-expected.txt:
  • platform/gtk/css1/box_properties/width-expected.txt:
  • platform/gtk/css1/cascade/cascade_order-expected.txt:
  • platform/gtk/css1/classification/display-expected.txt:
  • platform/gtk/css1/classification/list_style_type-expected.txt:
  • platform/gtk/css1/classification/white_space-expected.txt:
  • platform/gtk/css1/color_and_background/background-expected.txt:
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt:
  • platform/gtk/css1/color_and_background/background_position-expected.txt:
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt:
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/gtk/css1/font_properties/font-expected.txt:
  • platform/gtk/css1/font_properties/font_family-expected.txt:
  • platform/gtk/css1/font_properties/font_size-expected.txt:
  • platform/gtk/css1/font_properties/font_weight-expected.txt:
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt:
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt:
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css1/pseudo/anchor-expected.txt:
  • platform/gtk/css1/pseudo/firstletter-expected.txt:
  • platform/gtk/css1/pseudo/firstline-expected.txt:
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt:
  • platform/gtk/css1/text_properties/line_height-expected.txt:
  • platform/gtk/css1/text_properties/text_decoration-expected.txt:
  • platform/gtk/css1/text_properties/text_indent-expected.txt:
  • platform/gtk/css1/text_properties/text_transform-expected.txt:
  • platform/gtk/css1/text_properties/vertical_align-expected.txt:
  • platform/gtk/css1/text_properties/word_spacing-expected.txt:
  • platform/gtk/css1/units/color_units-expected.txt:
  • platform/gtk/css1/units/length_units-expected.txt:
  • platform/gtk/css1/units/percentage_units-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/gtk/fast/multicol/nested-columns-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-tranformed-expected.txt:
  • platform/gtk/fast/repaint/repaint-during-scroll-expected.txt:
  • platform/gtk/fast/text/format-control-expected.txt:

2010-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=39101

Work around timing issues for render tree dumps by pumping the
main loop before doing the dump. Resize events are asynchronous
in GTK+, so sometimes resize requests are still pending when DRT
dumps the tree.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump): Pump the main loop before dumping the render tree.
4:30 AM Changeset in webkit [60470] by eric@webkit.org
  • 8 edits in trunk

2010-06-01 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[Chromium] get rid of named interceptor on HTMLDocument and introduce/remove accessors when named items get deleted/removed
https://bugs.webkit.org/show_bug.cgi?id=39877

This patch makes callbacks invoked on named items addition/removal
install API accessors and thus there is no more need in
named and indexed interceptors on HTMLDocument which
speeds up invocation of methods on document.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
2:05 AM Changeset in webkit [60469] by pfeldman@chromium.org
  • 7 edits in trunk/WebKit/chromium

2010-05-31 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Chromium: save inspector settings as dictionary, not as string.
https://bugs.webkit.org/show_bug.cgi?id=32118

  • public/WebView.h:
  • public/WebViewClient.h: (WebKit::WebViewClient::didUpdateInspectorSetting):
  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::populateSetting): (WebKit::InspectorClientImpl::storeSetting):
  • src/InspectorClientImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::inspectorSetting): (WebKit::WebViewImpl::setInspectorSetting):
  • src/WebViewImpl.h:
1:57 AM Changeset in webkit [60468] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-06-01 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

Fix style errors of dtoa
https://bugs.webkit.org/show_bug.cgi?id=39972

Fix all errors reported by check-webkit-style.

  • wtf/dtoa.cpp:
  • wtf/dtoa.h:
1:55 AM Changeset in webkit [60467] by pfeldman@chromium.org
  • 8 edits
    7 adds in trunk/LayoutTests

2010-06-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Chromium: rebaseline some svg tests.

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:44 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
12:29 AM Changeset in webkit [60466] by zherczeg@webkit.org
  • 7 edits
    5 adds in trunk

WebCore: Make the spot light anti-alias effect look similar to SVG expected values.
https://bugs.webkit.org/show_bug.cgi?id=39477

Reviewed by Dirk Schulze.

The W3 standard only mention, that the edge of the spotlight should be
anti-aliased but it does not specify how. The provided expected values
gives some hint about their intentions. The algorithm uses a fixed
range, which computed as follows: let a = cos(spot light cutoff range)
the light fades off in the [a-0.016, a] range.

Test: svg/W3C-SVG-1.1/filters-light-04-f.svg
Updated pixel test: svg/W3C-SVG-1.1/filters-light-01-f.svg

  • svg/graphics/filters/SVGLightSource.cpp:

(WebCore::SpotLightSource::initPaintingData):

LayoutTests: Testing the anti-aliasing effect of the spot light edge
https://bugs.webkit.org/show_bug.cgi?id=39477

Reviewed by Dirk Schulze.

  • platform/gtk/Skipped:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
  • platform/qt/Skipped:
  • svg/W3C-SVG-1.1/filters-light-04-f.png: Added.
  • svg/W3C-SVG-1.1/filters-light-04-f.svg: Added.
12:06 AM Changeset in webkit [60465] by eric@webkit.org
  • 8 edits in trunk

2010-05-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix default action for EndTagOpenState
https://bugs.webkit.org/show_bug.cgi?id=39982

Add a test for a bogus end tag to webkit01.dat and update expected
results now that we pass some more tests.

Adding this test revealed a bug in resuming the bogus comment state.
I've left these broken expectations, but I'll fix the bug in a future
patch. (The bug existed prior to this patch, just not the test.)

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:

2010-05-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix default action for EndTagOpenState
https://bugs.webkit.org/show_bug.cgi?id=39982

Add a test for a bogus end tag to webkit01.dat and update expected
results now that we pass some more tests.

Adding this test revealed a bug in resuming the bogus comment state.
I've left these broken expectations, but I'll fix the bug in a future
patch. (The bug existed prior to this patch, just not the test.)

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:
Note: See TracTimeline for information about the timeline view.