Timeline


and

06/16/10:

23:59 Changeset [61309] by hamaji@chromium.org

2010-06-16 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Refactor layout tests for printing to use common code.

https://bugs.webkit.org/show_bug.cgi?id=40559

  • printing/numberOfPages-expected.txt:
  • printing/numberOfPages.html:
  • printing/page-break-always-expected.txt:
  • printing/page-break-always-for-overflow-expected.txt:
  • printing/page-break-always-for-overflow.html:
  • printing/page-break-always.html:
  • printing/page-break-inside-avoid-expected.txt: Added.
  • printing/page-break-inside-avoid.html: Added.
  • printing/page-break-inside-expected.txt: Removed.
  • printing/page-break-inside.html: Removed.
  • printing/pageNumerForElementById-expected.txt:
  • printing/pageNumerForElementById.html:
  • printing/resources/paged-media-test-utils.js: (numberOfPagesShouldBe): (ratioToPageHeightToPixels): (createBlockWithRatioToPageHeight): (createBlockWithNumberOfLines):
  • printing/script-tests/TEMPLATE.html:
  • printing/script-tests/numberOfPages.js: (test):
  • printing/script-tests/page-break-always-for-overflow.js: (test):
  • printing/script-tests/page-break-always.js: (test):
  • printing/script-tests/page-break-inside-avoid.js: Added. (test):
  • printing/script-tests/page-break-inside.js: Removed.
  • printing/script-tests/pageNumerForElementById.js: (test):
23:28 Changeset [61308] by tkent@chromium.org

2010-06-16 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Fix crash on Mac Release
https://bugs.webkit.org/show_bug.cgi?id=40759

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintRect): We should not use m_canvas directly because it is created lazily in canvas().
22:38 Changeset [61307] by hausmann@webkit.org

[Qt] QtWebKit crashes while initializing flash plugin 10.1.53.64.
https://bugs.webkit.org/show_bug.cgi?id=40567

Patch by Dawit Alemayehu <adawit@kde.org> on 2010-06-16
Reviewed by Simon Hausmann.

Avoid preventable crashes by ensuring gtk_init() is called in the
flash viewer plugins before calling NP_Initialize.

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::load):

22:23 Changeset [61306] by eric@webkit.org

2010-06-16 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Guarantee that references are held for CachedScripts in HTMLDocumentParser.
https://bugs.webkit.org/show_bug.cgi?id=40177

No new tests because no new functionality.

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::reset): (WebCore::HTMLDocumentParser::executeExternalScriptsIfReady):
22:07 Changeset [61305] by eric@webkit.org

2010-06-16 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Adler.

Improve assertion macro documentation.

https://bugs.webkit.org/show_bug.cgi?id=40565

  • coding/assertion-guidelines.html:
21:29 Changeset [61304] by eric@webkit.org

2010-06-16 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Geoffrey Garen.

Add an index of technical articles to the WebKit site. This makes the
links to the RefPtr and Assertion documentation discoverable and
provides an easy way to find some useful blog posts.

https://bugs.webkit.org/show_bug.cgi?id=40561

  • coding/technical-articles.html: Added.
  • nav.inc: Add link to technical articles.
21:15 Changeset [61303] by eric@webkit.org

2010-06-16 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Repeat pattern should start from origin
https://bugs.webkit.org/show_bug.cgi?id=39225

Remove the following test case from Skipped:
canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html
canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html
canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html

  • platform/qt/Skipped:

2010-06-16 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Repeat pattern should start from origin
https://bugs.webkit.org/show_bug.cgi?id=39225

Patterns must be painted so that the top left of the first image
is anchored at the origin of the coordinate space.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawRepeatPattern): (WebCore::GraphicsContext::fillRect):
21:04 Changeset [61302] by kevino@webkit.org

[wx] Build fix after new method addition.

19:55 Changeset [61301] by eric@webkit.org

2010-06-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL viewport does not show up on N900
https://bugs.webkit.org/show_bug.cgi?id=38528

With OGLES2 add default precision to the shader code.
Use GLsizeiptr and GLintptr with OGLES2.
Call paint() in beginPaint() so that drawTexture() is used
whenever possible.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::paint): (WebCore::GraphicsContext3D::shaderSource):
19:18 Changeset [61300] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

This "test" no longer exists. Turns out it was an image resource for
another test.

  • platform/mac/Skipped:
19:05 Changeset [61299] by tkent@chromium.org

2010-06-16 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Set current working directory for each of tests
https://bugs.webkit.org/show_bug.cgi?id=40668

  • DEPS: Update Chromium to r49915 to have webkit_support::SetCurrentDirectoryForFileURL().

2010-06-16 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Set current working directory for each of tests
https://bugs.webkit.org/show_bug.cgi?id=40668

This change fixes tests with eventSender.beginDragWithFiles().

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest):
17:57 Changeset [61298] by tonikitoo@webkit.org

Spatial Navigation: refactor scrollInDirection to work with scrollable content
https://bugs.webkit.org/show_bug.cgi?id=39195

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

scrollInDirection now receives as parameter the node that the Spatial Navigation
found as the more appropriated to move focus to. If it is in a scrollable container
(e.g. <div> with clipped overflow content), it scrolls recursively starting from
the container, not the current focused node.

Test: fast/events/spatial-navigation/snav-only-clipped-overflow-content.html

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

  • page/SpatialNavigation.cpp:

(WebCore::scrollInDirection):

  • page/SpatialNavigation.h:

LayoutTests:

  • fast/events/spatial-navigation/snav-only-clipped-overflow-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-only-clipped-overflow-content.html: Added.
17:51 Changeset [61297] by weinig@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=40732
WebKit2: Implement didClearWindowForFrame for InjectedBundles

Reviewed by Geoffrey Garen.

WebKit2:

More InjectedBundle work.

  • Add really basic page level APIs for the WebProcess side:
    • Basic client interface with just didClearWindowForFrame (more will be added later)
    • Simple main frame url getter.

These APIs are experimental and are intended to allow me to get a DRT implementation
up and running. They will be changing.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Added.

(WKBundlePageSetClient):
(WKBundlePageGetMainFrameURL):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added.
  • WebProcess/InjectedBundle/InjectedBundlePageClient.cpp: Added.

(WebKit::InjectedBundlePageClient::InjectedBundlePageClient):
(WebKit::InjectedBundlePageClient::initialize):
(WebKit::InjectedBundlePageClient::didClearWindowObjectForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageClient.h: Added.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundleClient):
(WebKit::WebPage::mainFrameURL):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::injectedBundleClient):

  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:

WebKitTools:

  • Stub out use of bundlified didClearWindowForFrame with logging.
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
  • MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.

(_didClearWindow):
(_didCreatePage):
(WKBundleInitialize):

17:27 Changeset [61296] by beidson@apple.com

<rdar://problem/7249553> and https://bugs.webkit.org/show_bug.cgi?id=40749
ResourceLoader::willCacheResponse() needs to null-check Frame::Settings()

Reviewed by Eric Carlson

No new tests. (Discovered via crash reports, no reproducible cases noted)

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willCacheResponse): Null check m_frame->settings(),

but also add an ASSERT so debug-build developers can learn more about why
this might be happening.

16:53 Changeset [61295] by simon.fraser@apple.com

2010-06-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Allow transitions and animations of clip: rect
https://bugs.webkit.org/show_bug.cgi?id=38130

Make the CSS clip property animatable.

Test: transitions/clip-transition.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc): New blend function for LengthBox (WebCore::AnimationBase::ensurePropertyMap): Create a PropertyWrapper for LengthBoxes.
  • platform/LengthBox.h: (WebCore::LengthBox::LengthBox): New ctor that takes 4 length values.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setClip): New method that takes a LengthBox.
16:39 Changeset [61294] by darin@apple.com

Try to fix the MathML build.

  • mathml/MathMLMathElement.h: Added missing return type.
16:07 Changeset [61293] by darin@apple.com

2010-06-16 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Deploy adoptRef in more places, including all HTML and MathML elements
https://bugs.webkit.org/show_bug.cgi?id=39941

  • wtf/ThreadSafeShared.h: Made the constructor protected and removed the unneeded support for initial reference counts other than 1.

2010-06-16 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Deploy adoptRef in more places, including all HTML and MathML elements
https://bugs.webkit.org/show_bug.cgi?id=39941

  • dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): Use create instead of new in commented-out code. (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
  • dom/Node.h: Removed now-unused CreateElementZeroRefCount and CreateHTMLElementZeroRefCount.
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): Use create instead of new, fixing a storage leak.
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel): Removed "WithType" from function name. Use create instead of new, fixing a storage leak. (WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel): Use create instead of new, fixing a storage leak.
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::create): Use adoptRef, fixing a storage leak.
  • editing/ModifySelectionListLevel.h: Added create functions.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement):
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::HTMLMeterElement):
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::HTMLProgressElement): Removed code to explicitly pass CreateHTMLElement construction type since that's now the type used for all HTML elements.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement):
  • html/HTMLFormControlElement.h: Removed construction type argument, since CreateHTMLElement is now the type used for all HTML elements.
  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement): Removed construction type of CreateStyledElementZeroRefCount so we'll use the default construction type, CreateStyledElement. (WebCore::MathMLElement::create): Use adoptRef.
  • mathml/MathMLElement.h: Made isMathMLElement function private and removed unneeded override of createRenderer, because it did the same thing as the base class's createRenderer function.
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::create): Use adoptRef. (WebCore::MathMLInlineContainerElement::createRenderer): Removed unnecessarily initialization of local variable and removed the case for mathTag, since that uses a different derived class.
  • mathml/MathMLInlineContainerElement.h: Made createRenderrer override private.
  • mathml/MathMLMathElement.cpp: (WebCore::MathMLMathElement::MathMLMathElement): Marked inline since it is called in only one place. (WebCore::MathMLMathElement::create): Use adoptRef. (WebCore::MathMLMathElement::createRenderer): Added. Creates a RenderMathMLMath object.
  • mathml/MathMLMathElement.h: Made constructor private and added a private override of createRenderer.
  • mathml/MathMLTextElement.cpp: (WebCore::MathMLTextElement::MathMLTextElement): Marked inline since it is called in only one place. (WebCore::MathMLTextElement::create): Use adoptRef. (WebCore::MathMLTextElement::createRenderer): Changed to call through to the base class instead of calling RenderObject::createObject directly.
  • mathml/MathMLTextElement.h: Made the constructor and createRenderer function private.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): Removed an unneeded initializer.
  • rendering/RenderProgress.cpp: Tweaked includes.
  • rendering/ShadowElement.cpp: Added a "using namespace" directive.
  • rendering/ShadowElement.h: Tweaked formatting. Made more functions private.
  • editing/DeleteButton.cpp: (WebCore::DeleteButton::create):
  • html/HTMLAudioElement.cpp: (WebCore::HTMLAudioElement::create): (WebCore::HTMLAudioElement::createForJSConstructor):
  • html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::create):
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::create):
  • html/HTMLBaseFontElement.cpp: (WebCore::HTMLBaseFontElement::create):
  • html/HTMLBlockquoteElement.cpp: (WebCore::HTMLBlockquoteElement::create):
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::create):
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::create):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::create):
  • html/HTMLDListElement.cpp: (WebCore::HTMLDListElement::create):
  • html/HTMLDataGridCellElement.cpp: (WebCore::HTMLDataGridCellElement::create):
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::create):
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::create):
  • html/HTMLDataGridRowElement.cpp: (WebCore::HTMLDataGridRowElement::create):
  • html/HTMLDataListElement.cpp: (WebCore::HTMLDataListElement::create):
  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::create):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::create):
  • html/HTMLElement.h: (WebCore::HTMLElement::HTMLElement):
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::create):
  • html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::create):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::create):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::create):
  • html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::create):
  • html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::create):
  • html/HTMLHeadingElement.cpp: (WebCore::HTMLHeadingElement::create):
  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::create):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::create): (WebCore::HTMLImageElement::createForJSConstructor):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::create):
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::create):
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::create):
  • html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::create):
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::create):
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::create):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::create):
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::create):
  • html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::create):
  • html/HTMLMenuElement.cpp: (WebCore::HTMLMenuElement::create):
  • html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::create):
  • html/HTMLModElement.cpp: (WebCore::HTMLModElement::create):
  • html/HTMLNoScriptElement.cpp: (WebCore::HTMLNoScriptElement::create):
  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::create):
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::create):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::create): (WebCore::HTMLOptionElement::createForJSConstructor):
  • html/HTMLParagraphElement.cpp: (WebCore::HTMLParagraphElement::create):
  • html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::create):
  • html/HTMLPreElement.cpp: (WebCore::HTMLPreElement::create):
  • html/HTMLQuoteElement.cpp: (WebCore::HTMLQuoteElement::create):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::create):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::create):
  • html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::create):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::create):
  • html/HTMLTableCaptionElement.cpp: (WebCore::HTMLTableCaptionElement::create):
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::create):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::create):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::create):
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::create):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::create):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::create):
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::create):
  • html/HTMLUListElement.cpp: (WebCore::HTMLUListElement::create):
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::create):
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentElement::create):
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::create): (WebCore::MediaControlElement::create): (WebCore::MediaControlTimelineContainerElement::create): (WebCore::MediaControlVolumeSliderContainerElement::create): (WebCore::MediaControlStatusDisplayElement::create): (WebCore::MediaControlMuteButtonElement::create): (WebCore::MediaControlPlayButtonElement::create): (WebCore::MediaControlSeekButtonElement::create): (WebCore::MediaControlRewindButtonElement::create): (WebCore::MediaControlReturnToRealtimeButtonElement::create): (WebCore::MediaControlToggleClosedCaptionsButtonElement::create): (WebCore::MediaControlTimelineElement::create): (WebCore::MediaControlVolumeSliderElement::create): (WebCore::MediaControlFullscreenButtonElement::create): (WebCore::MediaControlTimeDisplayElement::create):
  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::create):
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::create): (WebCore::TextControlInnerTextElement::create): (WebCore::SearchFieldResultsButtonElement::create): (WebCore::SearchFieldCancelButtonElement::create): (WebCore::SpinButtonElement::create): Use adoptRef.
16:04 Changeset [61292] by dglazkov@chromium.org

2010-06-16 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations tweak.

  • platform/chromium/test_expectations.txt: Transferred a failure from downstream.
15:58 Changeset [61291] by mrobinson@webkit.org

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] r60803 broke media/controls-drag-timebar.html
https://bugs.webkit.org/show_bug.cgi?id=40269

  • platform/gtk/Skipped: Unskip test which is now passing.

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] r60803 broke media/controls-drag-timebar.html
https://bugs.webkit.org/show_bug.cgi?id=40269

Only queue events while the mouse button is down, if drag mode is enabled. Some
tests may disable drag mode, to prevent the queuing of events in this situation.

  • DumpRenderTree/gtk/EventSender.cpp: (sendOrQueueEvent): Only queue events here if dragMode is true.
15:47 Changeset [61290] by aroben@apple.com

Remove some CVS directories that snuck into Subversion

These were added back when the Mozilla tables tests were imported.

Rubber-stamped by Dan Berstein.

  • tables/mozilla/images/CVS: Removed.
  • tables/mozilla_expected_failures/images/CVS: Removed.
15:38 Changeset [61289] by aroben@apple.com

Delete tables/mozilla/images/adforce_imgis_com.html and its associated results

This file is a GIF that somehow obtained a .html extension. It isn't
referenced by any other test. (It was failing on Windows because the
HTML5 parser turns null bytes into U+FFFD, whose rendering is
font-dependent.)

Fixes <http://webkit.org/b/40741> REGRESSION (r61234):
tables/mozilla/images/adforce_imgis_com.html fails on Windows.

Reviewed by Dave Hyatt.

  • platform/chromium-linux/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
  • platform/mac-leopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
  • platform/mac-leopard/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
  • platform/mac/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
  • platform/mac/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
  • platform/mac/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
  • platform/qt/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
  • tables/mozilla/images/adforce_imgis_com.html: Removed.
15:26 Changeset [61288] by mrobinson@webkit.org

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
https://bugs.webkit.org/show_bug.cgi?id=40600

  • platform/gtk/Skipped: This change exposed some failures which were previously not reported. Skip them.

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
https://bugs.webkit.org/show_bug.cgi?id=40600

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Reset the click count after a drag starts.
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): Reset the click count after a load is committed.
  • webkit/webkitprivate.h: Move static click counting variables to be per-view.
  • webkit/webkitwebview.cpp: (getEventTime): Added. (webkit_web_view_button_press_event): If the event time is zero, use the current time. (webkit_web_view_finalize): Clean up click counting member. (webkit_web_view_init): Initialize click counting member.

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
https://bugs.webkit.org/show_bug.cgi?id=40600

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
15:13 Changeset [61287] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add a hidden land-cowboy command to webkit-patch to help land quick
build fixes.

  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
14:57 Changeset [61286] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 parser crash when setTimeout document.write after slow script
https://bugs.webkit.org/show_bug.cgi?id=40726

According to the HTML5 spec, we're supposed to open() a new document if
we receive a document.write() after we've received EOF for the network.
The old parser just dumped those bytes onto the end of the network
stream. After this patch, our behavior matches Minefield.

Test: http/tests/misc/write-while-waiting.html

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::write):
  • dom/DocumentParser.h:
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::finishWasCalled):
  • dom/XMLDocumentParser.h:
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::finishWasCalled):
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::InputStream::isClosed):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finishWasCalled):
  • html/HTMLDocumentParser.h:
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finishWasCalled):
  • loader/MediaDocument.cpp: (WebCore::MediaDocumentParser::finishWasCalled):
  • loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::finishWasCalled):
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::finishWasCalled):
  • loader/TextDocument.cpp: (WebCore::TextDocumentParser::finishWasCalled):

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 parser crash when setTimeout document.write after slow script
https://bugs.webkit.org/show_bug.cgi?id=40726

Adds a test for what happens when we receive a document.write() while
we're waiting for an external script to load (and after receiving EOF
from the network).

  • http/tests/misc/write-while-waiting-expected.txt: Added.
  • http/tests/misc/write-while-waiting.html: Added.
14:56 Changeset [61285] by eric@webkit.org

2010-06-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Enable HTML5 Parser in Safari on Mac
https://bugs.webkit.org/show_bug.cgi?id=40739

The HTML5 parser is probably off on all webkit ports.
We should either flip the meaning of the default so that
"false" means HTML5 on all ports, or we'll have to write
more code like this for all the other ports.

  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):
14:51 Changeset [61284] by dglazkov@chromium.org

Unreviewed, expectations update.

Updated platform/chromium-* expectations for the tests after HTML5 parser switch.

14:38 Changeset [61283] by dglazkov@chromium.org

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt: Removed already passing tests.
14:22 WebKit Team edited by mrobinson@webkit.org
(diff)
14:22 Changeset [61282] by aroben@apple.com

Convert fast/dom/stripNullFromTextNodes.html to dumpAsText

There's nothing in this test that requires a render tree dump. We have
other tests that test rendering of U+FFFD characters (which was what
was causing the test to fail, since Windows uses a different font for
that character than Mac does).

Fixes <http://webkit.org/b/40738> REGRESSION: (r61234):
fast/dom/stripNullFromTextNodes.html fails on Windows

Reviewed by Dan Bernstein.

  • fast/dom/stripNullFromTextNodes-expected.txt: Added.
  • fast/dom/stripNullFromTextNodes.html: Added a call to

layoutTestController.dumpAsText().

  • platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
  • platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.png: Removed.
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.png: Removed.
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.png: Removed.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
  • platform/mac/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
  • platform/mac/fast/dom/stripNullFromTextNodes-expected.png: Removed.
  • platform/mac/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
  • platform/qt/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
14:18 WebKit Team edited by diegohcg@webkit.org
(diff)
14:18 Changeset [61281] by mrobinson@webkit.org

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] ClipboardGtk::setURL does not match the behavior of other platforms
https://bugs.webkit.org/show_bug.cgi?id=40640

Instead of writing URL labels to the text portion of the clipboard or
drag-and-drop data, write the URL itself. Also escape the label text
of URLs. Abstracts logic into DataObjectGtk, so ClipboardGtk and
PasteboardGtk can share it.

Tests for this issue will be activated when dropping support has been
added to the GTK+ EventSender.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::writeURL): Use DataObjectGtk::setURL.
  • platform/gtk/DataObjectGtk.cpp: (WebCore::DataObjectGtk::setURL): Added. Write URL to the text portion and remember to escape the label when creating the markup portion.
  • platform/gtk/DataObjectGtk.h: Add declaration of new method.
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeURL): Use DataObjectGtk::setURL.
14:15 WebKit Team edited by jesus@webkit.org
(diff)
14:15 Changeset [61280] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Hit assertion in WebCore::HTML5Token::appendToSystemIdentifier
https://bugs.webkit.org/show_bug.cgi?id=40729

This was a copy/paste error. Yay for ASSERTs.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Hit assertion in WebCore::HTML5Token::appendToSystemIdentifier
https://bugs.webkit.org/show_bug.cgi?id=40729

Add more test coverage of DOCTYPE parsing states. Turns out you use a
different state if there's no whitespace between the public and system
identifiers.

  • html5lib/resources/doctype01.dat:
14:09 WebKit Team edited by diegohcg@webkit.org
(diff)
13:54 Changeset [61279] by aroben@apple.com

Convert console messages to UTF-8 before printing them

Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
http/tests/security/xssAuditor/embed-tag-null-char.html and
http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
Windows. (I can't test the fix because Apache is crashing on my
computer.)

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(toUTF8): Extracted the code into an overload that takes a wide string
and a length, then added an overload that takes a wstring.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8

overload.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
UTF-8 instead of letting printf convert to the current code page.

13:28 Changeset [61278] by eric@webkit.org

2010-06-16 Drew Wilson <atwilson@chromium.org>

Reviewed by Kent Tamura.

Added plumbing to Chromium WebKit API to allow setting/getting the name
of top level frames.

https://bugs.webkit.org/show_bug.cgi?id=40430

  • public/WebFrame.h: Added setName() API.
  • public/WebViewClient.h: (WebKit::WebViewClient::createView): Now takes a "name" parameter.
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow): Passes a name parameter.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setName): Allows setting the frame name by calling through to the WebCore API.
  • src/WebFrameImpl.h:

2010-06-16 Drew Wilson <atwilson@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Plumbing for top-level frame names
https://bugs.webkit.org/show_bug.cgi?id=40430

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): Migrate to new createView() API.
  • DumpRenderTree/chromium/WebViewHost.h: Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
13:08 Changeset [61277] by eric@webkit.org

2010-06-16 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Anders Carlsson.

Bring npapi.h more in line with upstream npapi-headers version:

  • Remove obsolete XP_MAC sections.
  • Remove Metrowerks defines.
  • Add OS/2 defines.
  • Add Maemo defines.
  • Add new version of the custom Carbon event definitions.
  • Sync platform define style/details

https://bugs.webkit.org/show_bug.cgi?id=38666

  • bridge/npapi.h:
12:27 Changeset [61276] by diegohcg@webkit.org

2010-06-16 Diego Gonzalez <diegohcg@webkit.org>

[Qt] Scroll wheel event support to graphics based DRT
https://bugs.webkit.org/show_bug.cgi?id=40577

Reviewed by Kenneth Rohde Christiansen.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::continuousMouseScrollBy): (EventSender::createGraphicsSceneWheelEvent):
  • DumpRenderTree/qt/EventSenderQt.h:
12:16 Changeset [61275] by simon.fraser@apple.com

2010-06-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Fix clipping via CSS clip: with composited descendants
https://bugs.webkit.org/show_bug.cgi?id=40579

Consult the 'clip' style, as well as overflow, when creating clipping
compositing layers.

Tests: compositing/geometry/clip.html

compositing/overflow/clip-descendents.html

  • rendering/RenderLayerBacking.cpp: (WebCore::clipBox): Utility function that returns the union of the clip and overflow boxes. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Use clipBox() to get the correct clipping rectangle.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer): Look for clip as well as overflow. (WebCore::RenderLayerCompositor::clipsCompositingDescendants): Ditto.
12:11 Changeset [61274] by simon.fraser@apple.com

2010-06-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

REGRESSION: Undocked inspector toolbar is white
https://bugs.webkit.org/show_bug.cgi?id=40644

Make the html element 100% height so that we don't erase the background to white, after r61215.

  • inspector/front-end/inspector.css: (html):
12:10 Changeset [61273] by aroben@apple.com

Remove a stray newline from the Windows version of TestNetscapePlugin

Reviewed by Alexey Proskuryakov.

Fixes <http://webkit.org/b/40728>
plugins/geturlnotify-during-document-teardown.html fails on Windows

  • DumpRenderTree/win/TestNetscapePlugin/main.cpp:

(NPP_Destroy): Removed extra newline that the Mac version doesn't
have.

12:02 Changeset [61272] by andersca@apple.com

Fix build.

  • NetscapeCoreAnimationMoviePlugin/main.m:

(NPP_New):
(NPP_WriteReady):
(NPP_Write):
(NPP_HandleEvent):

12:00 Changeset [61271] by bweinstein@apple.com

User scripts injected on start are not run on image documents.
https://bugs.webkit.org/show_bug.cgi?id=40722
<rdar://8087394>

Reviewed by Darin Adler.

User scripts that are injected on start are run from FrameLoader::dispatchDocumentElementAvailable,
but this is never called from ImageDocument, so call it when we create a document element for
our image document.

  • loader/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure): Call FrameLoader::dispatchDocumentElementAvailable

after creating our document element.

11:56 Changeset [61270] by aroben@apple.com

Respect LayoutTestController::isPrinting on Windows

This gets some printing tests closer to passing (like
printing/page-rule-in-media-query.html).

Fixes <http://webkit.org/b/40727>.

Reviewed by Dan Bernstein.

WebKit/win:

Add a "forPrinting" boolean parameter to
IWebFramePrivate::renderTreeAsExternalRepresentation

  • Interfaces/IWebFramePrivate.idl: Renamed the current

renderTreeAsExternalRepresentation to unused1, and added a new version
that takes a boolean "forPrinting" parameter.

  • Interfaces/WebKit.idl: Touched to force a build.
  • WebFrame.cpp:

(WebFrame::renderTreeAsExternalRepresentation): Added a boolean
"forPrinting" parameter, and used it to tell externalRepresentation
what kind of behavior to use.

  • WebFrame.h: Renamed the old renderTreeAsExternalRepresentation and

added the new one.

WebKitTools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dump): Pass LayoutTestController::isPrinting to
IWebFramePrivate::renderTreeAsExternalRepresentation.

11:51 Changeset [61269] by cmarrin@apple.com

Now fixing the path to WebGLLayer.*

11:47 Changeset [61268] by cmarrin@apple.com

Additional minor fix to path of GraphicsContext3D.mac

11:46 Changeset [61267] by cmarrin@apple.com

Fixing path to GraphicsContext3D.mac (hopefully)

11:32 Changeset [61266] by eric@webkit.org

2010-06-16 Eric Seidel <eric@webkit.org>

Unreviewed. Disabling a test which fails on Tiger for platform-specific decoding reasons.

fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
https://bugs.webkit.org/show_bug.cgi?id=40725

  • platform/mac-tiger/Skipped:
    • Skipping the test until someone with Tiger access can look.
11:17 Changeset [61265] by beidson@apple.com
  • WebCore.xcodeproj/project.pbxproj: Make paths relative to the project root.

Reviewed by NOBODY (Build fix for Mac)

11:05 Changeset [61264] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Add Tiger-specific expectations because U+FFFD is a different length on
Tiger. :(

  • platform/mac-tiger/fast/dom: Added.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.checksum: Added.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.png: Added.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.txt: Added.
10:33 Changeset [61263] by cmarrin@apple.com

2010-06-16 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Carlson.

https://bugs.webkit.org/show_bug.cgi?id=40643


Second of three steps - rename Canvas3DLayer to WebGLLayer

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/mac/Canvas3DLayer.h: Removed.
  • platform/graphics/mac/Canvas3DLayer.mm: Removed.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):
  • platform/graphics/mac/WebGLLayer.h: Copied from WebCore/platform/graphics/mac/Canvas3DLayer.h.
  • platform/graphics/mac/WebGLLayer.mm: Copied from WebCore/platform/graphics/mac/Canvas3DLayer.mm.
10:05 Changeset [61262] by cmarrin@apple.com

2010-06-16 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=40643


Rename GraphicsContext3DMac.cpp so it can interact with CALayer

  • platform/graphics/mac/GraphicsContext3DMac.cpp: Removed.
  • platform/graphics/mac/GraphicsContext3DMac.mm: Copied from WebCore/platform/graphics/mac/GraphicsContext3DMac.cpp.
  • WebCore.xcodeproj/project.pbxproj
09:12 Changeset [61261] by aroben@apple.com

Land new expected Windows results for two failing tests

These test results should have been updated in r61136, but weren't.

Reviewed by Anders Carlsson.

Fixes <http://webkit.org/b/40713> REGRESSION (r61136):
fast/dom/prototype-inheritance-2.html and
fast/js/global-constructors.html are failing on Windows.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:

Updated with the actual results from the bots.

09:04 Changeset [61260] by mrobinson@webkit.org

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

Add baselines for tests that should be passing consistently now.

  • platform/gtk/Skipped: Unskip tests. They should pass consistently.
  • platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Added.
  • platform/gtk/svg/text/foreignObject-repaint-expected.txt: Added.
08:58 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
08:53 Changeset [61259] by bulach@chromium.org

2010-06-16 Marcus Bulach <bulach@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Rebaseline tests following r61240
https://bugs.webkit.org/show_bug.cgi?id=40711

Following r61240 (new HTML5 lexer), we need to rebaseline a few tests.

  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.checksum:
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt:
  • platform/chromium-mac/fast/parser/script-tag-with-trailing-slash-expected.txt: Removed.
  • platform/chromium-mac/fast/tokenizer/script_extra_close-expected.txt:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-win/fast/doctypes/003-expected.checksum:
  • platform/chromium-win/fast/doctypes/003-expected.png:
  • platform/chromium-win/fast/doctypes/003-expected.txt:
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.checksum:
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.png:
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.txt:
  • platform/chromium-win/fast/invalid/016-expected.checksum:
  • platform/chromium-win/fast/invalid/016-expected.png:
  • platform/chromium-win/fast/invalid/016-expected.txt:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.checksum:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.png:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.txt: Removed.
  • platform/chromium-win/fast/parser/comment-in-style-expected.checksum:
  • platform/chromium-win/fast/parser/comment-in-style-expected.png:
  • platform/chromium-win/fast/parser/comment-in-style-expected.txt:
  • platform/chromium-win/fast/parser/parseCommentsInTitles-expected.checksum:
  • platform/chromium-win/fast/parser/parseCommentsInTitles-expected.png:
  • platform/chromium-win/fast/parser/parseCommentsInTitles-expected.txt:
  • platform/chromium-win/fast/parser/script-tag-with-trailing-slash-expected.txt: Removed.
  • platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.checksum:
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.png:
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt:
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.checksum:
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.png:
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.txt: Removed.
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.checksum:
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.png:
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.txt: Removed.
  • platform/chromium-win/fast/tokenizer/script_extra_close-expected.txt:
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.checksum:
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.png:
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.txt:
08:45 Changeset [61258] by mrobinson@webkit.org

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

Unskip passing test.

  • platform/gtk/Skipped: Unskip this test which appears to be passing now.
08:32 Changeset [61257] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Skip this test because I keep screwing up the expectations for this
test. I'll get it cleared up by the end of the day.

  • platform/mac/Skipped:
08:15 Changeset [61256] by aroben@apple.com

Land new expected Windows results for tests that use <video controls>

The current expected results expect a fullscreen button to be included
in the controls. But the fullscreen button is only included when
accelerated compositing is enabled, and the bots build without
accelerated compositing enabled.

Rubber-stamped by Dan Bernstein.

Fixes <http://webkit.org/b/40710> Tests that use <video controls> are
failing on Windows.

  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-drag-timebar-expected.txt:
  • platform/win/media/controls-strict-expected.txt:
  • platform/win/media/controls-styling-expected.txt:
  • platform/win/media/video-controls-rendering-expected.txt:
  • platform/win/media/video-display-toggle-expected.txt:
  • platform/win/media/video-no-audio-expected.txt:

Updated with the actual results from the bots.

08:10 Changeset [61255] by zimmermann@webkit.org

2010-06-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add new files, needed in SVG Text rewrite
https://bugs.webkit.org/show_bug.cgi?id=40676

Land SVGTextChunkLayoutInfo.cpp and SVGTextQuery.(cpp|h), both with an "#if 0" on top, as they will be needed
in a later patch, completing the SVG Text rewrite, that will enable them.

Doesn't affect any code for now, it should just reduce the review amount.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/SVGTextChunkLayoutInfo.cpp: Added. (WebCore::cummulatedWidthOrHeightOfTextChunk): (WebCore::cummulatedWidthOfTextChunk): (WebCore::cummulatedHeightOfTextChunk): (WebCore::calculateTextAnchorShiftForTextChunk): (WebCore::applyTextAnchorToTextChunk): (WebCore::calculateTextLengthCorrectionForTextChunk): (WebCore::applyTextLengthCorrectionToTextChunk): (WebCore::SVGTextChunkLayoutInfo::startTextChunk): (WebCore::SVGTextChunkLayoutInfo::closeTextChunk): (WebCore::SVGTextChunkLayoutInfo::buildTextChunks): (WebCore::SVGTextChunkLayoutInfo::recursiveBuildTextChunks): (WebCore::SVGTextChunkLayoutInfo::layoutTextChunks):
  • rendering/SVGTextChunkLayoutInfo.h: Add missing include, otherwhise compiling SVGTextChunkLayoutInfo.cpp will fail.
  • rendering/SVGTextQuery.cpp: Added. (WebCore::SVGTextQuery::Data::Data): (WebCore::flowBoxForRenderer): (WebCore::mapLengthThroughChunkTransformation): (WebCore::SVGTextQuery::SVGTextQuery): (WebCore::SVGTextQuery::collectTextBoxesInFlowBox): (WebCore::SVGTextQuery::executeQuery): (WebCore::SVGTextQuery::mapStartAndLengthIntoChunkPartCoordinates): (WebCore::SVGTextQuery::measureCharacterRange): (WebCore::NumberOfCharactersData::NumberOfCharactersData): (WebCore::SVGTextQuery::numberOfCharactersCallback): (WebCore::SVGTextQuery::numberOfCharacters): (WebCore::TextLengthData::TextLengthData): (WebCore::SVGTextQuery::textLengthCallback): (WebCore::SVGTextQuery::textLength): (WebCore::SubStringLengthData::SubStringLengthData): (WebCore::SVGTextQuery::subStringLengthCallback): (WebCore::SVGTextQuery::subStringLength): (WebCore::StartPositionOfCharacterData::StartPositionOfCharacterData): (WebCore::SVGTextQuery::startPositionOfCharacterCallback): (WebCore::SVGTextQuery::startPositionOfCharacter): (WebCore::EndPositionOfCharacterData::EndPositionOfCharacterData): (WebCore::SVGTextQuery::endPositionOfCharacterCallback): (WebCore::SVGTextQuery::endPositionOfCharacter): (WebCore::RotationOfCharacterData::RotationOfCharacterData): (WebCore::SVGTextQuery::rotationOfCharacterCallback): (WebCore::SVGTextQuery::rotationOfCharacter): (WebCore::ExtentOfCharacterData::ExtentOfCharacterData): (WebCore::SVGTextQuery::extentOfCharacterCallback): (WebCore::SVGTextQuery::extentOfCharacter): (WebCore::CharacterNumberAtPositionData::CharacterNumberAtPositionData): (WebCore::SVGTextQuery::characterNumberAtPositionCallback): (WebCore::SVGTextQuery::characterNumberAtPosition):
  • rendering/SVGTextQuery.h: Added.
08:09 Changeset [61254] by hausmann@webkit.org

[Qt] Fix tiled backing store painting when calling QGraphicsWebView::setPage() after setResizesToContents(true)

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-16
Reviewed by Simon Hausmann.

When calling setPage() after setResizesToContents, the value of the property wasn't propagated
to the page client. Therefore the visible rect for the tiled backing store was incorrect.

Simply move the variable assignment into updateResizesToContentsForPage(), which is always called.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::updateResizesToContentsForPage):
(QGraphicsWebView::setResizesToContents):

06:51 Changeset [61253] by zimmermann@webkit.org

2010-06-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Provide floating-point support for text selection framework
https://bugs.webkit.org/show_bug.cgi?id=40665

This is the first chunk of the SVG Text rewrite patches.
offsetForPosition() / selectionRectForText() should accept float/FloatPoint arguments instead
of int/IntPoint. offsetForPosition() already worked with floats internally in Qt and Mac.
selectionRectForText() was already returning a FloatRect, but the passed in origin was an integer.
Fixing these problems in order to support sub-pixel positioning in the upcoming SVG Text rewrite patch.

Add a glyphScale parameter to TextRun, that will be used to support text selection
in lengthAdjust/textLength scenarios in SVG text, soon.

Doesn't affect any testcases so far. HTML is not affected in any way,
as it only ever passes integers to these functions.

  • platform/graphics/Font.cpp: (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition):
  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPositionForSimpleText):
  • platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::glyphScale): (WebCore::TextRun::setGlyphScale): (WebCore::TextRun::applyGlyphScaling):
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance):
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/efl/FontEfl.cpp: (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/haiku/FontHaiku.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition):
  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/FontComplexTextMac.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::offsetForPositionForSimpleText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/win/FontWin.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/wince/FontWince.cpp: (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/wx/FontWx.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • svg/SVGFont.cpp: (WebCore::Font::selectionRectForTextUsingSVGFont): (WebCore::Font::offsetForPositionForTextUsingSVGFont):
05:42 Changeset [61252] by antonm@chromium.org

2010-06-16 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Introduce single element caches for WebCore::String to v8::String conversions
https://bugs.webkit.org/show_bug.cgi?id=40435
Measurements show that for some web apps (GMail, Wave) and some scenarios
(intensive reading and/or keeping a tab open for a long time),
hit rate lies in 30--50% interval.
Inlining fast case gives another minor performance win.

  • bindings/v8/V8Binding.cpp: (WebCore::getStringCache): (WebCore::v8ExternalStringSlow):
  • bindings/v8/V8Binding.h: (WebCore::v8ExternalString):
04:47 Changeset [61251] by hausmann@webkit.org

Swap WebGL and SiteSpecificQuirks attributes in the QWebSettings
enum, to allow for binary compatibility with qtwebkit-2.0, where
WebGL is not in the settings but SiteSpecificQuirks will be.

Rubber-stamped by Tor Arne Vestbø.

  • Api/qwebsettings.h:
04:46 Changeset [61250] by tonikitoo@webkit.org

2010-05-20 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

Spatial Navigation: using offset{Left,Top} is not enough to get the proper inner frames position
https://bugs.webkit.org/show_bug.cgi?id=39439

As pointed out by Darin Adler in https://bugs.webkit.org/show_bug.cgi?id=18662#c20,
"It's not correct to use the offsetLeft and offsetTop of the frame owner element's renderer because
that's just the distance from the offsetParent, not the absolute position".

Patch fixes that behavior by now considering the offsetTop and offsetLeft the offsetParent recursively,
starting from the HtmlFrameOwnerElement. Previously, only calling offsetTop and offsetLeft works
because all tests were done in html samples where the {i}frame element was a directly a child of the body,
e.g. <html>...<body><iframe src=xxx>....<body></html>.

WebCore:
Test: fast/events/spatial-navigation/snav-iframe-recursive-offset-parent.html

  • page/SpatialNavigation.cpp: (WebCore::renderRectRelativeToRootDocument):

LayoutTests:

  • fast/events/spatial-navigation/snav-iframe-recursive-offset-parent-expected.txt: Added.
  • fast/events/spatial-navigation/snav-iframe-recursive-offset-parent.html: Added.
02:26 Changeset [61249] by mitz@apple.com

Try to fix the Tiger build

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformBoundsForGlyph):

02:23 Changeset [61248] by eric@webkit.org

2010-06-16 Eric Seidel <eric@webkit.org>

Unreviewed. Disabling a test which fails on Gtk for unexplained
reasons which are specific to the Gtk port.

Gtk pumps the HTML5Lexer an extra time, causing inspector/timeline-script-tag-1.html to fail
https://bugs.webkit.org/show_bug.cgi?id=40664

  • platform/qt/Skipped:
    • Skip the test until a Gtk person can take a look.
02:15 Changeset [61247] by mitz@apple.com

Try to fix the Tiger build

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformBoundsForGlyph):

02:12 Changeset [61246] by eric@webkit.org

2010-06-16 Eric Seidel <eric@webkit.org>

Unreviewed. Disabling a test which due to a Qt decoding bug
is now failing with the HTML5 lexer.

fast/encoding/japanese-encoding-mix.html fails on Qt after enabling HTML5 Lexer
https://bugs.webkit.org/show_bug.cgi?id=40661

Qt's decoders don't seem to be passing the "--" of the "-->" to the
HTML5DocumentParser correctly, thus the comment is never closed
and the rest of the document gets eaten.

  • platform/qt/Skipped:
    • Skip the test until a Qt person can take a look.
01:59 Changeset [61245] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Add two XSS Auditor tests to the Skipped list. These tests actually
pass in the sense that the attack is blocked. However, the U+FFFD in
the console output is getting mangled. We could check in Qt-specific
expected results, but that doesn't quite seem right. There's something
wrong with the Qt UT8 decoder, which I suspect is related to (or the
same as) https://bugs.webkit.org/show_bug.cgi?id=35263

  • platform/qt/Skipped:
01:50 Changeset [61244] by abecsi@webkit.org

Store matchBegin directly in the array of output instead of the stack.
https://bugs.webkit.org/show_bug.cgi?id=38988

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-06-16
Reviewed by Geoffrey Garen.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateDisjunction): (JSC::Yarr::RegexGenerator::generate):
01:48 Changeset [61243] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Add platform-specific results for Snow Leopard. Maciej thinks there is
something going on here related to BIDI and additional FFFD
replacements. This test is already on our list of things to
investigate more closely.

  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Added.
  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.txt: Added.
01:25 Changeset [61242] by eric@webkit.org

2010-06-16 Eric Seidel <eric@webkit.org>

Unreviewed, just updating qt platform result to match new expectations.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Windows and Chromium will still need updates, but I don't have easy
access to those results.

  • platform/qt/fast/text/stripNullFromText-expected.txt:
    • \0 now gets converted to 0xfffd per HTML5.
  • platform/qt/fast/text/international/hindi-whitespace-expected.txt:
01:23 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
01:20 Changeset [61241] by mitz@apple.com

WebCore: <rdar://problem/8077119> REGRESSION (r60247): Google Reader contains the tops of pieces of unidentifiable text under feed headlines.
https://bugs.webkit.org/show_bug.cgi?id=40386

Reviewed by Alexey Proskuryakov.

Test: platform/mac/fast/text/x-height.html

The result of platformBoundsForGlyph() is in flipped coordinates, whereas the result of
-[NSFont boundingRectForGlyph:] was not. r60247 failed to account for this.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit): Measure the height of the x glyph above the baseline
correctly.
(WebCore::SimpleFontData::platformBoundsForGlyph): Return a rect in flipped coordinates on Tiger
as well.

LayoutTests: <rdar://problem/8077119> REGRESSION: Google Reader contains the tops of pieces of unidentifiable text under feed headlines.
https://bugs.webkit.org/show_bug.cgi?id=40386

Reviewed by Alexey Proskuryakov.

  • platform/mac/fast/text/x-height-expected.checksum: Added.
  • platform/mac/fast/text/x-height-expected.png: Added.
  • platform/mac/fast/text/x-height-expected.txt: Added.
  • platform/mac/fast/text/x-height.html: Added.
01:06 Changeset [61240] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Update platform-specific expected results for Qt.

  • platform/qt/fast/text/international/hindi-whitespace-expected.txt:
00:59 Changeset [61239] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't crash when a document ends with an entity
https://bugs.webkit.org/show_bug.cgi?id=40658

When we SWITCH_TO a state, we're expecting our caller to have advanced
the source. Rather than have all the callers check for empty, we do
that ourselves.

  • html/HTML5Lexer.cpp:

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't crash when a document ends with an entity
https://bugs.webkit.org/show_bug.cgi?id=40658

Add a test for an entity being the only contents of a file.

  • html5lib/resources/webkit01.dat:
00:51 Changeset [61238] by eric@webkit.org

2010-06-16 Eric Seidel <eric@webkit.org>

Unreviewed, just updating platform results to match new expectations.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Update platform-specific results for broken CSS test whose results
changed as part of http://trac.webkit.org/changeset/61234.

  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
00:30 Changeset [61237] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

I seem to have screwed up generating the updated expectation file.
This file is from the bots.

  • platform/mac/tables/mozilla/images/adforce_imgis_com-expected.txt:
00:04 Changeset [61236] by abarth@webkit.org

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Revert unintentional change to expected results. I have a different
diff on my machine because I have some errant cookies.

  • inspector/audits-panel-functional-expected.txt:

06/15/10:

23:51 Changeset [61235] by abarth@webkit.org

2010-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Change some tests not to rely upon <script/>. We already cover that
case in parsing tests.

  • fast/lists/ol-nested-items-dynamic-insert.html:
  • fast/lists/ol-nested-items-dynamic-remove.html:
  • fast/lists/ol-nested-items.html:
  • fast/lists/ol-nested-list-dynamic-insert.html:
  • fast/lists/ol-nested-list-dynamic-remove.html:
  • fast/lists/ol-nested-list.html:
23:27 Changeset [61234] by abarth@webkit.org

2010-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

  • page/Settings.cpp: (WebCore::Settings::Settings):

2010-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

This patch updates the expected results for tests that conflict with
the HTML5 specification. In a later patch, I'll update the tests
themselves to fix pass/fail messages.

  • fast/doctypes/005-case-preserving-expected.txt:
    • HTML5 specifies case normalization for DOCTYPEs.
  • fast/js/missing-title-end-tag-js-expected.txt:
    • HTML5 requires us to swallow the entire document when <title> is unterminated.
  • fast/parser/comment-in-iframe-expected.txt:
  • fast/parser/comment-in-script-tricky-expected.txt:
  • fast/parser/comment-in-title-expected.txt:
  • fast/parser/comments-expected.txt:
    • Differences due to HTML5 comment parsing.
  • fast/parser/eightdigithexentity-expected.txt:
    • HTML5 specifies a different behavior for &#x00FFFFFF;
  • fast/parser/entity-end-iframe-tag-expected.txt:
    • HTML5 specifies a different behavior for &lt;/iframe>
  • fast/parser/entity-surrogate-pairs-expected.txt:
    • HTML5 doesn't allow entities to create surrogate pairs.
  • fast/parser/html-whitespace-expected.txt:
    • HTML5 has a different handling of CR in this case.
  • fast/parser/script-tag-with-trailing-slash-expected.txt:
    • HTML5 does not allow self-closing <script/> tags.
  • fast/parser/tag-with-exclamation-point-expected.txt:
    • HTML5 treats bogus DOCTYPEs as comments.
  • fast/parser/xml-directive-in-dom-expected.txt:
    • HTML5 attaches <?xml?> processing directives to the DOM as comments.
  • fast/xpath/xpath-functional-test-expected.txt:
    • I don't fully understand this test, but our new behavior matches the Firefox nightly builds (which have an HTML5 parser).
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:
    • Massive progressions on HTML5 conformance.
  • http/tests/loading/gmail-assert-on-load-expected.txt:
    • I don't fully understand this behavior change. It might represent a bug. We're still investigating.
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
    • Update expected results for change in NULL char handling.
  • http/tests/security/xssAuditor/img-onerror-tricky-expected.txt:
    • This exploit no longer works in the HTML5 parser, so it's not blocked.
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
    • This a real regression. We need to update the XSSAuditor to use the HTML5 parser's HTML entity decoder. I'll do that in a followup patch because there doesn't appear to be an easy way to key the choice off of the WebCore::Setting.
  • http/tests/security/xssAuditor/malformed-HTML-expected.txt:
    • Slightly different handling of malformed HTML. The exploit is still blocked.
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
    • Update expected result due to different NULL character handling.
  • inspector/audits-panel-functional-expected.txt:
  • inspector/timeline-script-tag-1-expected.txt:
    • Slightly different semantics around document.write.
  • inspector/elements-panel-structure-expected.txt:
    • HTML5 specifies case normalization for DOCTYPEs.
  • platform/mac/css1/box_properties/float_elements_in_series-expected.txt:
    • HTML5 specifies different handling of "<foo<bar"
  • platform/mac/fast/doctypes/003-expected.txt:
    • HTML5 specifies case normalization for DOCTYPEs.
  • platform/mac/fast/dom/stripNullFromTextNodes-expected.txt:
    • HTML5 specifies different handling of NULL characters.
  • platform/mac/fast/invalid/016-expected.txt:
    • HTML5 specifies different handling of "<foo<bar"
  • platform/mac/fast/parser/broken-comments-vs-parsing-mode-expected.txt:
    • HTML5 specifies different handling of HTML comments.
  • platform/mac/fast/parser/comment-in-style-expected.txt:
    • HTML5 specifies different handling of HTML comments.
  • platform/mac/fast/parser/parseCommentsInTitles-expected.txt:
    • HTML5 specifies different handling of HTML comments.
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/mac/fast/text/international/hindi-whitespace-expected.txt:
    • HTML5 specifies different handling CR. I don't fully understand the consequences of this change, but our new behavior matches the Firefox nightly.
  • platform/mac/fast/text/stripNullFromText-expected.txt:
    • HTML5 specifies different handling of NULL characters.
  • platform/mac/fast/tokenizer/missing-title-end-tag-1-expected.txt:
  • platform/mac/fast/tokenizer/missing-title-end-tag-2-expected.txt:
    • HTML5 requires us to swallow the entire document when <title> is unterminated.
  • platform/mac/fast/tokenizer/script_extra_close-expected.txt:
    • We're coalescing text nodes slightly different in the new parser. We're going to get this up to spec when we work on the TreeConstructor (which is where the spec handles text node coalescing).
  • platform/mac/tables/mozilla/images/adforce_imgis_com-expected.txt:
    • Different handling of crazy unicode characters (replaced with FFFD). Still investigating whether this is a real bug.
  • webarchive/archive-empty-frame-dom-expected.webarchive:
    • HTML5 specifies case normalization for DOCTYPEs.

2010-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

  • DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions):
21:50 Changeset [61233] by mrowe@apple.com

Don't leak WebGeolocationPositionInternal and GeolocationPosition instances for every WebGeolocationPosition created.

Reviewed by Sam Weinig.

  • WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPosition dealloc]): Implement -dealloc and release our WebGeolocationPositionInternal instance.

20:23 Changeset [61232] by yuzo@google.com

2010-06-15 Dmitry Titov <dimich@chromium.org>

Not reviewed, updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:

2010-06-15 Mark Rowe <mrowe@apple.com>

Rubber-stamped by David Harrison.

sqlite3_prepare16_v2 is not documented as always setting "tail" during error cases.
Explicitly initialize it to null, just to be safe.

  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):

2010-06-10 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement render style selection for pages to support CSS3 Paged Media.
https://bugs.webkit.org/show_bug.cgi?id=35961

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame pageProperty:propertyName:]):

2010-06-10 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement render style selection for pages to support CSS3 Paged Media.
https://bugs.webkit.org/show_bug.cgi?id=35961

  • DumpRenderTree/LayoutTestController.cpp: (parsePagePropertyParameters): (pagePropertyCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageProperty):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageProperty):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageProperty):
19:27 Changeset [61231] by mrowe@apple.com

sqlite3_prepare16_v2 is not documented as always setting "tail" during error cases.
Explicitly initialize it to null, just to be safe.

Rubber-stamped by David Harrison.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

19:23 Changeset [61230] by mrowe@apple.com

<rdar://problem/8091103> URLs not added to history when initial load happens via back/forward navigation

Reviewed by Brady Eidson.

Back/forward navigation currently does not create or update items in the global history. This is usually
desirable, except for in the event where the back/forward list was created programmatically and attached
to the WebView and the initial load in that WebView is being performed as a result of a back/forward
navigation. In that situation it is preferable to ensure that global history item is created or updated.

No test case is added because DumpRenderTree is not able to test the scenario where the initial
load in a WebView occurs via a back/forward navigation.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): If we're committing the first load in this frame as a
back/forward navigation then we should update the history as if it were a standard load, with the
exception of updating the back/forward list.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateForStandardLoad): Add a parameter to allow callers to skip updating
the back/forward list.

  • loader/HistoryController.h:

(WebCore::HistoryController::):

18:07 Changeset [61229] by dimich@chromium.org

Not reviewed, updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:
17:45 Changeset [61228] by weinig@apple.com

Fix for <rdar://problem/8010805>
Assertion failure ("mainThreadPthread") in isMainThread() mousing over cnn.com in Mini Browser

Reviewed by Anders Carlsson.

Don't use WebCore::String::operator NSString*() from the UIProcess, since it uses
StringImpl::createCFString() which expects to be called from WebCore's main thread.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::nsStringFromWebCoreString):
(WebKit::PageClientImpl::toolTipChanged):

  • UIProcess/API/mac/WKView.mm:

(-[WKView view:stringForToolTip:point:userData:]):

17:19 Changeset [61227] by dimich@chromium.org

Not reviewed, updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:
16:42 Changeset [61226] by simon.fraser@apple.com

2010-06-15 Simon Fraser <simon.fraser@apple.com>

Fix crashing tests; need to check for null documentElement().

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
16:36 Changeset [61225] by kinuko@chromium.org

2010-06-15 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Fix compilation errors in BlobBuilder with FILE_WRITER enabled
https://bugs.webkit.org/show_bug.cgi?id=40606

No functionality change so no new tests.

  • html/BlobBuilder.cpp:
  • html/BlobBuilder.h:
16:35 Changeset [61224] by xan@webkit.org

2010-06-15 Xan Lopez <xlopez@igalia.com>

Fix compilation with older GTK+.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::pageRect):
16:29 Changeset [61223] by jianli@chromium.org

Move type attribute from File.idl to Blob.idl per latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=40642

Reviewed by David Levin.

  • html/Blob.idl:
  • html/File.idl:
16:17 Changeset [61222] by weinig@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
WebKit2: Add mechanism to inject code into the WebProcess on startup

Reviewed by Anders Carlsson.

Add initial InjectedBundle support.

WebKit2:

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Add new LoadInjectedBundle message kind.

  • UIProcess/API/C/WKContext.cpp:

(toWK):
(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):

  • UIProcess/API/C/WKContext.h:

Rename WKContextCreateWithProcessModel to WKContextCreate and add
WKContextCreateWithInjectedBundlePath for creating a context with
a bundle.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebContext.h:

(WebKit::WebContext::create):
(WebKit::WebContext::processModel):
(WebKit::WebContext::bundlePath):

  • UIProcess/WebPageNamespace.cpp:

(WebKit::WebPageNamespace::ensureWebProcess):
(WebKit::WebPageNamespace::reviveIfNecessary):

  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::getWebProcess):

  • UIProcess/WebProcessManager.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::WebProcessProxy):

  • UIProcess/WebProcessProxy.h:

Thread the bundle path through process creation.

  • WebProcess/InjectedBundle: Added.
  • WebProcess/InjectedBundle/API: Added.
  • WebProcess/InjectedBundle/API/c: Added.
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: Added.

(WKBundleSetClient):

  • WebProcess/InjectedBundle/API/c/WKBundle.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h: Added.

(WebKit::):
(toWK):
(toRef):

  • WebProcess/InjectedBundle/API/c/WKBundleBase.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundleInitialize.h: Added.
  • WebProcess/InjectedBundle/InjectedBundle.cpp: Added.

(WebKit::InjectedBundle::InjectedBundle):
(WebKit::InjectedBundle::~InjectedBundle):
(WebKit::InjectedBundle::initializeClient):
(WebKit::InjectedBundle::didCreatePage):

  • WebProcess/InjectedBundle/InjectedBundle.h: Added.

(WebKit::InjectedBundle::create):
Add bundle boilerplate.

  • WebProcess/InjectedBundle/mac: Added.
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: Added.

(WebKit::InjectedBundle::load):
Load the InjectedBundle using CFBundle.

  • WebProcess/InjectedBundle/win: Added.
  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: Added.

(WebKit::pathGetFileName):
(WebKit::directoryName):
(WebKit::InjectedBundle::load):
Load the InjectedBundle using HMODULE.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Add initial bundle callback for page creation. More to come.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::loadInjectedBundle):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::injectedBundle):
Load the InjectedBundle on LoadInjectedBundle message.

  • WebKit2.xcodeproj/project.pbxproj:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add the new files.

WebKitTools:

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/WebBundle-Info.plist: Added.

Add test InjectedBundle to the project.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
Get the path to the WebBundle from the the main bundle and pass it to the new
WKContextCreateWithInjectedBundlePath function.

  • MiniBrowser/mac/BrowserWindowController.m:

(_didChangeProgress):
Fix the build. This has been broken for a while.

  • MiniBrowser/mac/WebBundle: Added.
  • MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.

(_didCreatePage):
(WKBundleInitialize):
Add really basic InjectedBundle.

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):
Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.

15:47 Changeset [61221] by dumi@chromium.org

Adding myself to the reviewers list.
https://bugs.webkit.org/show_bug.cgi?id=40693

Reviewed by Darin Adler.

  • Scripts/webkitpy/common/config/committers.py:
15:44 Changeset [61220] by scherkus@chromium.org

2010-06-15 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, updating Chromium test expectations for media layout tests.

  • platform/chromium/test_expectations.txt:
15:33 Changeset [61219] by darin@apple.com

Fix build.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::shouldClose): Call loader()->shouldClose().

15:30 Changeset [61218] by dimich@chromium.org

Unreviewed, updating Chromium test expectations.

Mark following tests SLOW so they won't fail on TIMEOUT in Debug:
fast/frames/lots-of-iframes.html
fast/frames/lots-of-objects.html

  • platform/chromium/test_expectations.txt:
15:20 Changeset [61217] by darin@apple.com

2010-06-15 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dispatchBeforeUnloadEvent): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebView.cpp: (WebView::shouldClose): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebFrame.cpp: (wxWebFrame::ShouldClose): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebView/WebView.mm: (-[WebView shouldClose]): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

Refactoring that does not require new tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL): Call setStatus and setDefaultStatus on DOMWindow rather than going through Frame. (WebCore::FrameLoader::open): Ditto. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call shouldClose on this object instead of going through Frame.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents): Call shouldClose on FrameLoader instead of going through Frame. (WebCore::DOMWindow::focus): Moved the code from Frame::focusWindow in here. (WebCore::DOMWindow::blur): Moved the code from Frame::unfocusWindow in here. (WebCore::DOMWindow::close): Moved the code from Frame::scheduleClose in here. (WebCore::DOMWindow::setStatus): Moved the code from Frame::setJSStatusBarText in here. (WebCore::DOMWindow::setDefaultStatus): Moved the code from Frame::setJSDefaultStatusBarText in here.
  • page/DOMWindow.h: Added m_status and m_defaultStatus members to store the status messages being set by the DOM.
  • page/Frame.cpp: Removed all the functions that were marked "to be moved into Chrome".
  • page/Frame.h: Ditto.

2010-06-15 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryClose): Call shouldClose on FrameLoader instead of going through Frame.
15:04 Changeset [61216] by darin@chromium.org

2010-06-15 Darin Fisher <darin@chromium.org>

Fix whitespace error in expected results.

Looks like Chromium's TestShell and DRT do not agree in how whitespace
is generated in some cases.

  • fast/history/history-back-within-subframe-expected.txt:
  • platform/chromium/test_expectations.txt:
15:00 Changeset [61215] by simon.fraser@apple.com

2010-06-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Garbage shown outside HTML if HTML is absolutely positioned
https://bugs.webkit.org/show_bug.cgi?id=36163

Add a check that the root renderer (the document element's renderer) covers
the entire viewport before deciding that we don't need the RenderView
to paint its background. Fixes lack of painting with positioned, floated, and
display: table html elements.

Test: fast/repaint/positioned-document-element.html

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
15:00 Changeset [61214] by simon.fraser@apple.com

2010-06-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Safari 5 does not clear background with transformed html element
https://bugs.webkit.org/show_bug.cgi?id=40498

When the document element is composited, ensure that the FrameView
paints the background, because the composited layer may be transparent,
or might get moved via animation.

Test: compositing/repaint/composited-document-element.html

  • rendering/RenderView.cpp: (WebCore::isComposited): (WebCore::rendererObscuresBackground):
14:48 Changeset [61213] by andersca@apple.com

Remove getPluginInfoFromBundleAndMIMEDictionary:

Reviewed by Dan Bernstein.

  • Plugins/WebBasePluginPackage.mm:
14:40 Changeset [61212] by andersca@apple.com

Fold getPluginInfoFromBundleAndMIMEDictionary: into its sole caller.

Reviewed by Dan Bernstein.

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage getPluginInfoFromPLists]):

13:57 Changeset [61211] by mrobinson@webkit.org

2010-06-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Switch to using GIO methods instead of realpath in GtkLauncher to determine
the file URI. This should remove warnings about realpath being undefined
when compiling with '-ansi'.

  • GtkLauncher/main.c: (filenameToURL): Use GIO instead of realpath to determine file URI.
13:48 WebKit Team edited by dumi@chromium.org
(diff)
13:41 Changeset [61210] by darin@chromium.org

2010-06-15 Darin Fisher <darin@chromium.org>

Adding missing test results.

  • fast/history/history-back-within-subframe-expected.txt: Added.
12:49 Changeset [61209] by xan@webkit.org

2010-06-15 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Remove GSEAL from the debug config since the bots have a GTK+
version too old, duh.

  • GNUmakefile.am:
12:32 Changeset [61208] by xan@webkit.org

2010-06-15 Xan Lopez <xlopez@igalia.com>

Try to fix GTK+ build.

  • platform/gtk/GtkVersioning.h:
12:31 Changeset [61207] by darin@chromium.org

2010-06-15 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

Introduce HistoryItem::itemSequenceNumber and use it to identify
HistoryItems that are clones of one another.

Changes HistoryController::recursiveGoToItem to use itemSequenceNumber
equality instead of isTargetItem as the pre-requisite for not calling
FrameLoader::loadItem.

Changes FrameLoader::loadItem to require equivalent
documentSequenceNumber before initiating a same document navigation.
This alone would appear to fix the bug, but it does not go far enough
since without the itemSequenceNumber equality check, we'd re-load more
often than we should.

Moves documentSequenceNumber assignment into createItemTree as cleanup
and to ensure that it gets called properly whenever we create a cloned
HistoryItem. (createItemTree's mission is to create clones up until
or including the target frame depending on the value of the doClip
parameter.)

Removes the now unused HistoryController::urlsMatchItem.

https://bugs.webkit.org/show_bug.cgi?id=40451

Test: fast/history/history-back-within-subframe.html

http/tests/navigation/history-back-across-form-submission-to-fragment.html

  • history/HistoryItem.cpp: (WebCore::generateSequenceNumber): (WebCore::HistoryItem::HistoryItem):
  • history/HistoryItem.h: (WebCore::HistoryItem::setItemSequenceNumber): (WebCore::HistoryItem::itemSequenceNumber):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
  • loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::createItemTree): (WebCore::HistoryController::recursiveGoToItem): (WebCore::HistoryController::pushState):
  • loader/HistoryController.h:
12:14 Changeset [61206] by xan@webkit.org

2010-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Add GSEAL_ENABLE flag when doing debug builds.

  • GNUmakefile.am:

WebCore:

2010-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Fix compilation with GSEAL_ENABLE.

  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::detachAdjustment): (ScrollbarGtk::updateThumbPosition): (ScrollbarGtk::updateThumbProportion):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint): (WebCore::PluginView::initXEvent): (WebCore::PluginView::platformGetValue): (WebCore::PluginView::platformStart):
  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_realize): (gtk_xtbin_new): (gtk_xtbin_set_position): (gtk_xtbin_unrealize):

WebKit/gtk:

2010-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Fix compilation with GSEAL_ENABLE.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::contentsSizeChanged):
  • tests/testdomnode.c: (test_dom_node_insertion):
  • webkit/webkitwebview.cpp: (webkit_web_view_realize): (webkit_web_view_script_dialog): (webkit_web_view_drag_end): (webkit_web_view_init):
11:59 Changeset [61205] by ap@apple.com

Increase limit on number of (i)frames from 200 to 1000.
https://bugs.webkit.org/show_bug.cgi?id=39427

Move the right test this time, move remove-iframe-crash back. Oops.

  • compositing/iframes/lots-of-iframes-expected.txt: Removed.
  • compositing/iframes/lots-of-iframes.html: Removed.
  • compositing/iframes/remove-iframe-crash-expected.txt: Copied from fast/frames/remove-iframe-crash-expected.txt.
  • compositing/iframes/remove-iframe-crash.html: Copied from fast/frames/remove-iframe-crash.html.
  • fast/frames/lots-of-iframes-expected.txt: Copied from compositing/iframes/lots-of-iframes-expected.txt.
  • fast/frames/lots-of-iframes.html: Copied from compositing/iframes/lots-of-iframes.html.
  • fast/frames/remove-iframe-crash-expected.txt: Removed.
  • fast/frames/remove-iframe-crash.html: Removed.
11:54 Changeset [61204] by simon.fraser@apple.com

2010-06-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8084721> Pages using accelerated compositing fail to update correctly in Carbon apps

The run loop observer used to commit compositing layer changes does not do
updates if [window viewsNeedDisplay] is true, because this indicates that a delayed window
update is pending (added in r58623).

However, Carbon apps don't use the NSWindow updating mechanism, so [window viewsNeedDisplay] always returns YES.
This caused us to never sync compositing layers.

So detect if the current window is wrapping a carbon window, and in that case consult the root
HIView to detect if display is pending.

  • WebView/WebView.mm: (layerSyncRunLoopObserverCallBack):
11:52 Changeset [61203] by andersca@apple.com

Make JavaScriptCore build with clang++.

Reviewed by Sam Weinig.

  • jit/JITInlineMethods.h:

(JSC::JIT::emitPutVirtualRegister):
Explicitly cast to an int.

  • yarr/RegexCompiler.cpp:

(JSC::Yarr::compileRegex):
Return 0 instead of false.

11:48 Changeset [61202] by kbr@google.com

2010-06-15 Kenneth Russell <kbr@google.com>

Unreviewed, test fix.

Fix test breakage from 40175
https://bugs.webkit.org/show_bug.cgi?id=40631

  • fast/canvas/webgl/texture-npot.html:
11:40 Changeset [61201] by xan@webkit.org

2010-06-15 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Fix the build when WebSockets are disabled.

  • bindings/js/JSWorkerContextCustom.cpp:
11:37 Changeset [61200] by simon.fraser@apple.com

2010-06-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

YouTube thumbnail borders vanish during transition
https://bugs.webkit.org/show_bug.cgi?id=40551

Turn off the direct image optimization if the image has a clip style, so that is is
correctly rendered with the clip.

Test: compositing/images/clip-on-directly-composited-image.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
11:31 Changeset [61199] by ap@apple.com

Not reviewed, just moving tests.

Increase limit on number of (i)frames from 200 to 1000.
https://bugs.webkit.org/show_bug.cgi?id=39427

Move the new tests out of compositing directory.

  • compositing/iframes/lots-of-objects-expected.txt: Removed.
  • compositing/iframes/lots-of-objects.html: Removed.
  • compositing/iframes/remove-iframe-crash-expected.txt: Removed.
  • compositing/iframes/remove-iframe-crash.html: Removed.
  • fast/frames/lots-of-objects-expected.txt: Copied from LayoutTests/compositing/iframes/lots-of-objects-expected.txt.
  • fast/frames/lots-of-objects.html: Copied from LayoutTests/compositing/iframes/lots-of-objects.html.
  • fast/frames/remove-iframe-crash-expected.txt: Copied from LayoutTests/compositing/iframes/remove-iframe-crash-expected.txt.
  • fast/frames/remove-iframe-crash.html: Copied from LayoutTests/compositing/iframes/remove-iframe-crash.html.
10:50 Changeset [61198] by yurys@chromium.org

2010-06-15 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: make ui tests pass when ScriptDebugServer is used
https://bugs.webkit.org/show_bug.cgi?id=40623

  • bindings/v8/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::functionName): return empty string for anonymous functions instead of [anonymous].
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::handleV8DebugEvent): autocontinue on syntax errors since there is no stack trace and not much to inspect.

2010-06-15 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: make ui tests pass when ScriptDebugServer is used
https://bugs.webkit.org/show_bug.cgi?id=40623

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.formatCallFrame_): return empty function name for anonymous functions.
  • src/js/DebuggerScript.js:
  • src/js/Tests.js: (.TestSuite.prototype.testProfilerTab.findVisibleView): (.TestSuite.prototype.testProfilerTab): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed): (.TestSuite.prototype.testSetBreakpoint.this): (.TestSuite.prototype.testSetBreakpoint): (.TestSuite.prototype.testEvalOnCallFrame.waitForBreakpointHit): (.TestSuite.prototype._executeCodeWhenScriptsAreParsed.executeFunctionInInspectedPage): (.TestSuite.prototype.testExpandScope.examineScopes): (.TestSuite.prototype.testExpandScope): (.TestSuite.prototype.testDebugIntrinsicProperties):
10:25 Changeset [61197] by yael.aharon@nokia.com

[Qt] Rename NotificatioIconWrapper to NotificationWrapper
https://bugs.webkit.org/show_bug.cgi?id=40571

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationWrapper::close):
(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationWrapper::iconData):
(WebCore::NotificationWrapper::notificationClosed):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationForWrapper):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore::NotificationWrapper::~NotificationWrapper):

09:55 Changeset [61196] by aroben@apple.com

Remove some unnecessary steps for setting up the debugger on Windows

Apparently update-webkit does this for you now.

WebKitSite:

Rubber-stamped by Steve Falkenburg.

  • building/debug.html: Removed the first two Windows steps, which are

now unnecessary, and updated the third to reflect reality.

WebKitTools:

Remove the redundant set-apple-windows-environment-variables script

Apparently update-webkit does this for you these days.

Rubber-stamped by Steve Falkenburg.

  • Scripts/set-apple-windows-environment-variables: Removed.
09:40 Changeset [61195] by aroben@apple.com

Make WebCore's and JavaScriptCore's DerivedSources available for debugging in production builds

Fixes <http://webkit.org/b/40626> <rdar://problem/8094205>.

Reviewed by Sam Weinig.

JavaScriptCore:

JavaScriptCore's DerivedSources directory to
AppleInternal/Sources/JavaScriptCore.

WebCore:

  • WebCore.vcproj/WebCore.make: Copy the contents of WebCore's

DerivedSources directory to AppleInternal/Sources/WebCore.

09:40 Changeset [61194] by aroben@apple.com

Improve instructions for debugging on Windows

Fixes <http://webkit.org/b/40585>.

Reviewed by Steve Falkenburg.

  • building/debug.html: Improved the Windows instructions. We now

instruct users to set things up so that hitting F5 from WebKit.sln
will launch Safari with the WEBKITNIGHTLY environment variable
pointing to the location of the built WebKit.dll.

  • building/console_vs2005.jpg: Removed.
  • building/debug_vs2005.jpg: Removed.
  • building/launch-debugger-vs2005.png: Added.
  • building/set-as-startup-project-vs2005.png: Added.
  • building/set-debugging-properties-vs2005.png: Added.
09:39 Changeset [61193] by aroben@apple.com

Add a script to set the WebKitOutputDir and WebKitLibrariesDir environment variables

Fixes <http://webkit.org/b/40595>.

Reviewed by Steve Falkenburg.

  • Scripts/set-apple-windows-environment-variables: Added.

(to_windows_path): Passes the passed-in path through cygpath to
generate a Windows-style path.
(main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
variables to their defaults, if they aren't already set.

09:39 Changeset [61192] by aroben@apple.com

Speed up run-safari/debug-safari on Windows

Fixes <http://webkit.org/b/40586>.

Reviewed by Steve Falkenburg.

  • Scripts/webkitdirs.pm:

(runSafari): When debugging, set up the environment to run Safari
using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
actually launch the debugger. When not debugging, just run WebKit.exe
and it will do the rest for us.

09:39 Changeset [61191] by aroben@apple.com

Add WebKitLauncherWin to WebKit.sln

Fixes <http://webkit.org/b/40583>.

Reviewed by Darin Adler.

  • WebKit.vcproj/WebKit.sln: Added WebKitLauncherWin.vcproj. It depends

on WebKitAPITest, so is the last project to build. (Also removed
QTMovieWin's direct dependency on JavaScriptCore, since it already has
an indirect dependency on it.)

09:18 Changeset [61190] by laszlo.1.gombos@nokia.com

2010-06-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
09:18 Changeset [61189] by mitz@apple.com

WebKit/mac: <rdar://problem/8077032> REGRESSION (r50796): Black background on AppleScript generated email

Reviewed by John Sullivan.

Test: platform/mac/editing/input/NSBackgroundColor-transparent.html

r50796 changed the initial background color from invalid to transparent. As a result,
NSAttributedStrings returned from +_web_attributedStringFromRange started including the
NSBackgroundColor attribute, with a transparent color as the value. This caused problems for
components in the system that ignore the alpha component, turning the color into opaque black.

  • Misc/WebNSAttributedStringExtras.mm:

(+[NSAttributedString _web_attributedStringFromRange:]): Change to not include the background
and foreground color attributes if the color are transparent.

LayoutTests: Test for <rdar://problem/8077032> REGRESSION (r50796): Black background on AppleScript generated email

Reviewed by John Sullivan.

  • platform/mac/editing/input/NSBackgroundColor-transparent-expected.txt: Added.
  • platform/mac/editing/input/NSBackgroundColor-transparent.html: Added.
09:15 Changeset [61188] by yael.aharon@nokia.com

Unreviewed.

Fix typo in reviewer name in r61187

09:10 Changeset [61187] by yael.aharon@nokia.com

[Qt] Build fix for Qt minimal after r61121
https://bugs.webkit.org/show_bug.cgi?id=40624

Reviewed by Somon Fraser.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::close):
(WebCore::NotificationIconWrapper::title):
(WebCore::NotificationIconWrapper::message):
(WebCore::NotificationIconWrapper::iconData):
(WebCore::NotificationIconWrapper::notificationClosed):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore::NotificationIconWrapper::~NotificationIconWrapper):

06:57 Changeset [61186] by kov@webkit.org

2010-06-15 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed EFL build fix. Simple typo.

  • efl/WebCoreSupport/InspectorClientEfl.cpp: (WebCore::InspectorClientEfl::sendMessageToFrontend):
06:38 Changeset [61185] by eric@webkit.org

2010-06-15 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Bring framebuffer functions to GLES2 conformance
https://bugs.webkit.org/show_bug.cgi?id=40175

  • fast/canvas/webgl/framebuffer-test-expected.txt: Added.
  • fast/canvas/webgl/framebuffer-test.html: Added.
  • fast/canvas/webgl/resources/webgl-test.js: (assertMsg): Function added.
  • fast/canvas/webgl/texture-npot.html: Remove assertMsg function.

2010-06-15 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Bring framebuffer functions to GLES2 conformance
https://bugs.webkit.org/show_bug.cgi?id=40175

Test: fast/canvas/webgl/framebuffer-test.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::checkFramebufferStatus): Check input parameters and deal with default framebuffer situation. (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Check input parameters. (WebCore::WebGLRenderingContext::framebufferTexture2D): Ditto. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Ditto. (WebCore::WebGLRenderingContext::validateFramebufferFuncParameters): Check input parameters.
  • html/canvas/WebGLRenderingContext.h: Add validateFramebufferFuncParameters.
06:21 Changeset [61184] by eric@webkit.org

2010-06-15 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT EventSender support to graphics context events
https://bugs.webkit.org/show_bug.cgi?id=40324

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick):
06:08 Changeset [61183] by eric@webkit.org

2010-06-15 Patrick Gansterer <paroga@paroga.com>

Reviewed by David Levin.

Buildfix for ResourceHandleWin after r24202 and r55542.
https://bugs.webkit.org/show_bug.cgi?id=32963

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestComplete): (WebCore::transferJobStatusCallback): (WebCore::ResourceHandle::start):
04:41 Changeset [61182] by alex@webkit.org

2010-06-15 Alejandro G. Castro <alex@igalia.com>

Unreviewed.

Add expected results changes requiered for the patch in the review
60961.
https://bugs.webkit.org/show_bug.cgi?id=40581

  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
04:38 Changeset [61181] by pfeldman@chromium.org

2010-06-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joe Pecoraro.

Web Inspector: Should not expose window.console._inspectorCommandLineAPI to the web.

https://bugs.webkit.org/show_bug.cgi?id=40500

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
02:14 Changeset [61180] by loki@webkit.org

Fix invalid access to non-static data member warning in JITPropertyAccess32_64 on ARM
https://bugs.webkit.org/show_bug.cgi?id=40423

Rubber-stamped by Eric Seidel.

Using OBJECT_OFFSETOF macro instead of objectof to bypass access to
non-static data member warning.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

01:15 Changeset [61179] by hausmann@webkit.org

[Qt] The qt_webkit_version.pri file gets overwritten on install
https://bugs.webkit.org/show_bug.cgi?id=40487

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-06-15
Reviewed by Simon Hausmann.

Don't install qt_webkit_version.pri when building WebKit inside of Qt.
The import of WebKit into Qt will take care of providing the file
in mkspecs/modules and it'll be installed through projects.pro.

  • WebCore.pro:
01:09 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
01:06 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
01:04 QtWebKitTableOfFeatures20 edited by henry.haverinen@nokia.com
(diff)
01:03 Changeset [61178] by tony@chromium.org

2010-06-15 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

resolve urls in text/html clipboard data
https://bugs.webkit.org/show_bug.cgi?id=40044

  • editing/pasteboard/copy-resolves-urls-expected.txt: Added.
  • editing/pasteboard/copy-resolves-urls.html: Added.
  • editing/pasteboard/paste-noscript-expected.txt:
  • editing/pasteboard/paste-noscript.html: Updated to no longer throw a JS exception so the results are the same

with V8 and JSC

  • http/tests/misc/copy-resolves-urls-expected.txt: Added.
  • http/tests/misc/copy-resolves-urls.html: Added.
  • platform/chromium-mac/editing/pasteboard/paste-noscript-expected.txt: No longer needed since results should match JSC
  • platform/chromium-win/editing/pasteboard/paste-noscript-expected.txt: No longer needed since results should match JSC

2010-06-15 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

resolve urls in text/html clipboard data
https://bugs.webkit.org/show_bug.cgi?id=40044

Allow text/html data copied from a page to contain full URLs when
dragging or copy/pasting.

Tests: editing/pasteboard/copy-resolves-urls.html

http/tests/misc/copy-resolves-urls.html

  • WebCore.base.exp:
  • editing/markup.cpp: (WebCore::appendStartMarkup): (WebCore::getStartMarkup): (WebCore::MarkupAccumulator::appendMarkup): (WebCore::createMarkup):
  • editing/markup.h: (WebCore::):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection):
  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::writeRange):
  • platform/gtk/DataObjectGtk.cpp: (WebCore::DataObjectGtk::markup):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection):
  • platform/haiku/PasteboardHaiku.cpp: (WebCore::Pasteboard::writeSelection):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeRange):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeSelection):
00:36 QtWebKitTriageRoster edited by kent.hansen@nokia.com
(diff)
00:01 Changeset [61177] by dimich@chromium.org

Not reviewed, update Chromium expectations for a new test.

  • platform/chromium/test_expectations.txt:

06/14/10:

23:17 Changeset [61176] by cfleizach@apple.com

No review. GTK build fix.

AX: need ListItemRole and PresentationalRole
https://bugs.webkit.org/show_bug.cgi?id=40133

Mostly speculative fix to make GTK unit tests work.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(atkRole):
(webkit_accessible_get_role):

21:31 Changeset [61175] by tony@chromium.org

2010-06-14 Anders Carlsson <andersca@apple.com>

Fix Chromium build.

  • src/WebPluginListBuilderImpl.cpp: (WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):

2010-06-14 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] checkout chromium third_party directly
https://bugs.webkit.org/show_bug.cgi?id=40556

  • Scripts/update-webkit-chromium: some migration code for the bots
20:55 Changeset [61174] by eric.carlson@apple.com

2010-06-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/8090895> Update http streaming MIME types.

  • platform/MIMETypeRegistry.cpp: (WebCore::TypeExtensionPair::): Add http streaming MIME synonyms.
19:55 Changeset [61173] by eric.carlson@apple.com

2010-06-14 Eric Carlson <eric.carlson@apple.com>

Unreviewed, fix GTK and Qt builds.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
19:29 Changeset [61172] by eric.carlson@apple.com

2010-06-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

audio/x-mp3 MIME type not recognized
<rdar://problem/7875393>
https://bugs.webkit.org/show_bug.cgi?id=40594


Allow MIMETypeRegistry to have more than one MIME type for a
media file extension, and have the QTKit media engine register
all MIME types it can find for each file type QTKit supports.

Test: media/media-can-play-mp3.html

  • platform/MIMETypeRegistry.cpp: (WebCore::mediaMIMETypeMap): Update for new HashMap format. (WebCore::TypeExtensionPair::): Store String+Vector<String> (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Only consult mediaMIMETypeMap(), it has the canonical answer. (WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): New, return a Vector of all MIME types for an extension.
  • platform/MIMETypeRegistry.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): Add all MIME types returned in the getMediaMIMETypesForExtension Vector.

2010-06-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

audio/x-mp3 MIME type not recognized
https://bugs.webkit.org/show_bug.cgi?id=40594

  • media/media-can-play-mp3-expected.txt: Added.
  • media/media-can-play-mp3.html: Added.
18:50 Changeset [61171] by mrowe@apple.com

<rdar://problem/8071866> REGRESSION: Crash on launch on Tiger and Leopard with network home folder

Reviewed by Brady Eidson.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare): Don't assume that tail is always non-null, since that may
not be the case with some versions of SQLite. Instead we must null-check before dereferencing.

18:41 Changeset [61170] by andersca@apple.com

Fix Chromium build.

  • src/WebPluginListBuilderImpl.cpp:

(WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):

18:37 Changeset [61169] by andersca@apple.com

Fix Tiger build.

  • plugins/mac/PluginDataMac.mm:
18:30 Changeset [61168] by andersca@apple.com

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Use an array for extensions in MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40602

Get rid of MimeClassInfo::suffixes and replace it with an array of extensions.

  • plugins/MimeType.cpp: (WebCore::MimeType::suffixes): Create a string of joined extensions.
  • plugins/MimeType.h:
  • plugins/PluginData.h: (WebCore::operator==):
  • plugins/chromium/PluginDataChromium.cpp: (WebCore::getPluginMimeTypeFromExtension):
  • plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
  • plugins/mac/PluginDataMac.mm: (WebCore::PluginData::initPlugins):
  • plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
  • plugins/win/PluginDataWin.cpp: (WebCore::PluginData::initPlugins):
  • plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins):
17:52 Changeset [61167] by abarth@webkit.org

2010-06-14 Adam Barth <abarth@webkit.org>

Unreviewed.

Add an include to try to fix Chromium build.

  • html/HTML5DocumentParser.cpp:
17:35 Changeset [61166] by sfalken@apple.com

Windows build fix.
Reorder build event to fix cygwin path issue.

  • win/WebKit2Generated.vcproj:
17:25 Changeset [61165] by abarth@webkit.org

2010-06-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Safari beach-balls loading large pages with HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40596

Implement parser yielding, similar to how the old
HTMLDocumentParser yields.

This implementation re-uses the tokenizerTimeDelay and
tokenizerChunkSize settings even though they don't map exactly
to the token loop that the HTML5 parser uses.

  • dom/DocumentParser.h:
    • Add a FIXME for processingData() and clarify how the appendData flag is used by renaming it to isFromNetwork.
  • html/HTML5DocumentParser.cpp: (WebCore::parserTimeLimit):
    • Defaults accessor, probably belongs on Page.

(WebCore::parserChunkSize):

  • Defaults accessor, probably belongs on Page.

(WebCore::HTML5DocumentParser::HTML5DocumentParser):
(WebCore::HTML5DocumentParser::stopParsing):

  • Stop the continue-parsing timer if active.

(WebCore::HTML5DocumentParser::processingData):

  • Implement this poorly understood accessor to match the old parser's behavior. It's unclear what this does and it does not affect any layout tests to my knowledge but likely affects the WebKit API in some way.

(WebCore::HTML5DocumentParser::pumpLexerIfPossible):

  • Pass SynchronousMode.
  • Do not ever pump if we've yielded to the timer.

(WebCore::HTML5DocumentParser::PumpSession::PumpSession):

  • A struct for storing the yield counters.

(WebCore::HTML5DocumentParser::shouldContinueParsing):

  • Mostly matches HTMLDocumentParser::shouldContinueParsing.

(WebCore::HTML5DocumentParser::pumpLexer):

  • Respect SynchronousMode.
  • ASSERT that a timer is not scheduled if we're pumping.

(WebCore::isLayoutTimerActive):

  • This belongs on Document.

(WebCore::HTML5DocumentParser::continueNextChunkTimerFired):
(WebCore::HTML5DocumentParser::write):
(WebCore::HTML5DocumentParser::end):

  • We should never end() if a timer is still outstanding.

(WebCore::HTML5DocumentParser::attemptToEnd):
(WebCore::HTML5DocumentParser::endIfDelayed):
(WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution):

  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::):
  • html/HTMLDocumentParser.cpp:
    • Clarify the old TimeDelay and ChunkSize constants.
17:20 Changeset [61164] by sfalken@apple.com

Windows build fix.
Add build failure stopping code.

  • win/WebKit2WebProcess.vcproj:
17:07 Changeset [61163] by abarth@webkit.org

2010-06-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preload scanner for the HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40557

This patch adds a simple preload scanner for the HTML5 parser. This
preload scanner is not as awesome as the old one because it doesn't
scan CSS, but it's much simpler.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
    • Build file torture.
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::write):
    • Call into the preload scanner when waiting for a script.
  • html/HTML5DocumentParser.h:
  • html/HTML5PreloadScanner.cpp: Copied from WebCore/html/PreloadScanner.cpp. (WebCore::HTML5PreloadScanner::HTML5PreloadScanner): (WebCore::HTML5PreloadScanner::scan):
    • A simple loop to pump the preload scanner's lexer.

(WebCore::HTML5PreloadScanner::processToken):

  • Preload interesting resources. Stolen from the old preload scanner.

(WebCore::HTML5PreloadScanner::scanningBody):

  • html/HTML5PreloadScanner.h: Copied from WebCore/html/PreloadScanner.h.
17:00 Changeset [61162] by tony@chromium.org

2010-06-14 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Chromium shouldn't build inside the source directory
https://bugs.webkit.org/show_bug.cgi?id=40489

Ignore directories fetched by chromium and chromium mac output dir.

  • chromium: Added property svn:ignore.

2010-06-13 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Chromium shouldn't build inside the source directory
https://bugs.webkit.org/show_bug.cgi?id=40489

Ignore Chromium Linux build files.

  • .: Added property svn:ignore. Modified property svn:ignore.
16:58 Changeset [61161] by abarth@webkit.org

2010-06-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Constify some HTML5Token methods
https://bugs.webkit.org/show_bug.cgi?id=40592

I keep wanting these methods to be const. Eric wanted this in a
separate patch.

  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::state):
  • html/HTML5Token.h: (WebCore::HTML5Token::attributes): (WebCore::HTML5Token::name): (WebCore::HTML5Token::characters): (WebCore::HTML5Token::comment): (WebCore::HTML5Token::publicIdentifier): (WebCore::HTML5Token::systemIdentifier):
  • html/HTML5TreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5TreeBuilder::adjustedLexerState):
    • Technically, this might belong in the other patch, but I think it's fine here.

(WebCore::HTML5TreeBuilder::passTokenToLegacyParser):

  • html/HTML5TreeBuilder.h:
16:47 Changeset [61160] by sfalken@apple.com

Windows build fix.
Add build failure stopping code.

  • win/WebKit2Generated.vcproj:
16:11 Changeset [61159] by dimich@chromium.org

Unreviewed, more Chromium expectations updates.

  • platform/chromium/test_expectations.txt:
15:31 Changeset [61158] by dumi@chromium.org

Unreviewed, build fix.

  • WebCore.xcodeproj/project.pbxproj:
15:27 Changeset [61157] by ap@apple.com

Chromium build fix.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
15:27 Changeset [61156] by dglazkov@chromium.org

Unreviewed, build fix.

Remove accidental specifying of the class name twice.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::prepareFormData): Removed my ghastly typo.

15:08 Changeset [61155] by adachan@apple.com

Rubber-stamped by Steve Falkenburg.

  • Fix the release configuration to use release.vsprops.
  • Add Debug_Internal and Debug_All configurations to the WebKit2WebProcess project.
  • Fix launchWebProcess() to get the right path to the WebKit2WebProcess executable.
  • UIProcess/Launcher/win/WebProcessLauncher.cpp: (WebKit::launchWebProcess):
  • win/WebKit2WebProcess.vcproj:
15:07 Changeset [61154] by dumi@chromium.org

Get DatabaseTracker ready for sync DBs.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

WebCore:

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::~AbstractDatabase):

  • storage/AbstractDatabase.h:
  • storage/Database.cpp:

(WebCore::Database::closeImmediately):

  • storage/Database.h:

(WebCore::Database::scriptExecutionContext):

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • storage/DatabaseTracker.h:
  • storage/OriginQuotaManager.cpp:

(WebCore::OriginQuotaManager::markDatabase):

  • storage/OriginQuotaManager.h:
  • storage/chromium/DatabaseObserver.h:
  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::TrackerRemoveOpenDatabaseTask::create):
(WebCore::TrackerRemoveOpenDatabaseTask::TrackerRemoveOpenDatabaseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):

WebKit/chromium:

  • public/WebDatabase.h:
  • src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):

  • src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):
(WebKit::WebDatabase::WebDatabase):
(WebKit::WebDatabase::operator=):
(WebKit::WebDatabase::operator WTF::PassRefPtr<AbstractDatabase>):

14:58 Changeset [61153] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=40529
eventSender.keyDown("delete") incorrectly sends a backspace on some platforms

WebCore:

  • platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use virtual key code to force correct character code for clarity. Also, reworded comment, since saying that "backspace needs to always be 8" misleadingly implied that it could "sometimes" be such without this code.

WebKitTools:

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken event for "delete" - it had virtual key code from forward delete, and text from backspace. Fixed "delete" to mean forward delete.
  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
  • DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Mac DRT confusion has propagated to other platforms, fixing those.

LayoutTests:

  • editing/deleting/forward-delete-key-expected.txt: Added.
  • editing/deleting/forward-delete-key.html: Added. Added a test for forward delete key working (particularly in DRT, since there was a lot of confusion between platform maintainers about it).
  • fast/forms/resources/input-live-pseudo-selectors.js:
  • fast/forms/resources/textarea-live-pseudo-selectors.js: These two tests expected that keyDown("delete") executed backward delete, changed them to send "\x08" for backspace.
14:51 Changeset [61152] by dglazkov@chromium.org

2010-06-14 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Refactor form submission code in HTMLFormElement to add clarity.
https://bugs.webkit.org/show_bug.cgi?id=39430

Covered by existing tests in fast/forms/mailto.

  • html/HTMLFormElement.cpp: (WebCore::appendMailtoPostFormDataToURL): Renamed from transferMailtoPostFormDataToUrl,

removed clearing out of the FormData and moved it to a new place (next to the call site).

(WebCore::HTMLFormElement::prepareFormData): Renamed from createFormData, moved the logic of

prepareing FormData here, including the use of appendMailtoPostFormDataToURL.

(WebCore::HTMLFormElement::submit): Consolidated multiple invocations of submitForm().

  • html/HTMLFormElement.h: Renamed createFormData to prepareFormData.
14:48 Changeset [61151] by cfleizach@apple.com

AX: need ListItemRole and PresentationalRole
https://bugs.webkit.org/show_bug.cgi?id=40133

Reviewed by Darin Adler.

WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isListItem):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):

WebKit/chromium:

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
14:45 Changeset [61150] by andersca@apple.com

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove pluginIndex from MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40588

  • src/WebPluginListBuilderImpl.cpp: (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin):

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove pluginIndex from MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40588

  • plugins/PluginData.h:
  • plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
  • plugins/mac/PluginDataMac.mm: (WebCore::PluginData::initPlugins):
  • plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
  • plugins/win/PluginDataWin.cpp: (WebCore::PluginData::initPlugins):
  • plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins):
14:41 Changeset [61149] by kinuko@chromium.org

2010-06-14 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Implement BlobBuilder internal class for BlobBuilder support as defined in FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36903

No new tests; they will be added when we add jsc bindings.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: Added.
  • html/BlobBuilder.h: Added. (WebCore::BlobBuilder::create):
  • platform/BlobItem.cpp: (WebCore::StringBlobItem::convertToCString): Added EndingNative support.
  • platform/BlobItem.h: Added EndingNative line-ending type. (WebCore::):
14:37 Changeset [61148] by dimich@chromium.org

Unreviewed, temporary update Chromium expectations after http://trac.webkit.org/changeset/61128

  • platform/chromium/test_expectations.txt:
14:13 Changeset [61147] by andersca@apple.com

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Stop using MimeClassInfo::pluginIndex
https://bugs.webkit.org/show_bug.cgi?id=40582

Add a pluginIndicies vector to PluginData and use it instead of MimeClassInfo::pluginIndex.

  • plugins/MimeType.cpp: (WebCore::MimeType::enabledPlugin): Get the plug-in index from the mimePluginIndices vector.


  • plugins/Plugin.cpp: (WebCore::Plugin::item): Compare the mime plugin index as well.


  • plugins/PluginData.cpp: (WebCore::PluginData::PluginData): Populate the m_mimePluginIndices vector.

(WebCore::PluginData::pluginNameForMimeType):
Get the plug-in index from the m_mimePluginIndices vector.

  • plugins/PluginData.h: (WebCore::operator==): Don't check for pluginIndex.

(WebCore::PluginData::mimePluginIndices):
Add getter for m_mimePluginIndices.

14:08 Changeset [61146] by weinig@apple.com

Better build fix.

  • bindings/js/JSBindingsAllInOne.cpp:
14:06 Changeset [61145] by weinig@apple.com

Another windows build fix.

  • bindings/js/JSBindingsAllInOne.cpp:
14:03 Changeset [61144] by mrobinson@webkit.org

2010-06-14 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Small GtkLauncher build fix for some systems.

  • GtkLauncher/main.c: Add <limit.h> include.
13:54 Changeset [61143] by weinig@apple.com

Another build fix.

  • bindings/js/JSDOMWindowCustom.cpp:
13:45 Changeset [61142] by ossy@webkit.org

[Qt] Unreviewed fix. Platform specific expected results updated after r61136.

  • platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
13:09 Changeset [61141] by crogers@google.com

A little cleanup in realtime analyser code

13:09 Changeset [61140] by crogers@google.com

Handle edge case of reverb 1 -> 4 -> 2 matrixing

13:09 Changeset [61139] by crogers@google.com

include config.h in MidSide

13:05 Changeset [61138] by ossy@webkit.org

Unreviewed.

[Qt] fast/text/justify-padding-distribution.html fails
https://bugs.webkit.org/show_bug.cgi?id=40584

  • platform/qt/Skipped: fast/text/justify-padding-distribution.html skipped until fix.
12:51 Changeset [61137] by weinig@apple.com

Add missing comma to fix GTK build.

  • xml/XSLTProcessor.idl:
12:46 Changeset [61136] by weinig@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=40581
Auto-generate most of the JS constructors

Reviewed by Alexey Proskuryakov.

WebCore:

  • Auto-generates all the JS constructors that don't have custom names (eg, Not Image(), Audio() or Option())
  • Fixes two typos.

(new XSLTConstructor()).toString() [object XSLTProcessorConsructor] -> [object XSLTProcessorConstructor])
(new EventSource()).toString() [object EventSourceContructor] -> [object EventSourceConstructor])

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSArrayBufferConstructor.cpp: Removed.
  • bindings/js/JSArrayBufferConstructor.h: Removed.
  • bindings/js/JSArrayBufferCustom.cpp: Copied from WebCore/bindings/js/JSArrayBufferConstructor.cpp.

(WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferView):

  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSEventSourceConstructor.cpp: Removed.
  • bindings/js/JSEventSourceConstructor.h: Removed.
  • bindings/js/JSEventSourceCustom.cpp: Copied from WebCore/bindings/js/JSEventSourceConstructor.cpp.

(WebCore::JSEventSourceConstructor::constructJSEventSource):

  • bindings/js/JSFloat32ArrayConstructor.cpp: Removed.
  • bindings/js/JSFloat32ArrayConstructor.h: Removed.
  • bindings/js/JSFloat32ArrayCustom.cpp:

(WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):

  • bindings/js/JSInt16ArrayConstructor.cpp: Removed.
  • bindings/js/JSInt16ArrayConstructor.h: Removed.
  • bindings/js/JSInt16ArrayCustom.cpp:

(WebCore::JSInt16ArrayConstructor::constructJSInt16Array):

  • bindings/js/JSInt32ArrayConstructor.cpp: Removed.
  • bindings/js/JSInt32ArrayConstructor.h: Removed.
  • bindings/js/JSInt32ArrayCustom.cpp:

(WebCore::JSInt32ArrayConstructor::constructJSInt32Array):

  • bindings/js/JSInt8ArrayConstructor.cpp: Removed.
  • bindings/js/JSInt8ArrayConstructor.h: Removed.
  • bindings/js/JSInt8ArrayCustom.cpp:

(WebCore::JSInt8ArrayConstructor::constructJSInt8Array):

  • bindings/js/JSMessageChannelConstructor.cpp: Removed.
  • bindings/js/JSMessageChannelConstructor.h: Removed.
  • bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannelConstructor::constructJSMessageChannel):

  • bindings/js/JSSharedWorkerConstructor.cpp: Removed.
  • bindings/js/JSSharedWorkerConstructor.h: Removed.
  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

  • bindings/js/JSUint16ArrayConstructor.cpp: Removed.
  • bindings/js/JSUint16ArrayConstructor.h: Removed.
  • bindings/js/JSUint16ArrayCustom.cpp:

(WebCore::JSUint16ArrayConstructor::constructJSUint16Array):

  • bindings/js/JSUint32ArrayConstructor.cpp: Removed.
  • bindings/js/JSUint32ArrayConstructor.h: Removed.
  • bindings/js/JSUint32ArrayCustom.cpp:

(WebCore::JSUint32ArrayConstructor::constructJSUint32Array):

  • bindings/js/JSUint8ArrayConstructor.cpp: Removed.
  • bindings/js/JSUint8ArrayConstructor.h: Removed.
  • bindings/js/JSUint8ArrayCustom.cpp:

(WebCore::JSUint8ArrayConstructor::constructJSUint8Array):

  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: Removed.
  • bindings/js/JSWebKitCSSMatrixConstructor.h: Removed.
  • bindings/js/JSWebKitCSSMatrixCustom.cpp: Copied from WebCore/bindings/js/JSWebKitCSSMatrixConstructor.cpp.

(WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):

  • bindings/js/JSWebKitPointConstructor.cpp: Removed.
  • bindings/js/JSWebKitPointConstructor.h: Removed.
  • bindings/js/JSWebKitPointCustom.cpp: Copied from WebCore/bindings/js/JSWebKitPointConstructor.cpp.

(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):

  • bindings/js/JSWebSocketConstructor.cpp: Removed.
  • bindings/js/JSWebSocketConstructor.h: Removed.
  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):

  • bindings/js/JSWorkerConstructor.cpp: Removed.
  • bindings/js/JSWorkerConstructor.h: Removed.
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

  • bindings/js/JSXSLTProcessorConstructor.cpp: Removed.
  • bindings/js/JSXSLTProcessorConstructor.h: Removed.
  • bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):

  • bindings/scripts/CodeGeneratorJS.pm:
  • css/WebKitCSSMatrix.idl:
  • dom/MessageChannel.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • page/EventSource.idl:
  • page/WebKitPoint.idl:
  • websockets/WebSocket.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
  • xml/XSLTProcessor.idl:

LayoutTests:

  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/js/global-constructors-expected.txt:
12:11 Changeset [61135] by tonikitoo@webkit.org

2010-05-16 Antonio Gomes <tonikitoo@webkit.org>

Unreviewed naming fixes of local variables used in Spatial Navigation methods.

Summary:

  • "candidate" renamed to "node";
  • "currentFocusCandidate" renamed to "candidate"
  • "closestFocusCandidate" renamed to "closest"

That way naming is more consistent in the various Spatial Navigation methods.

  • page/FocusController.cpp: (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
12:10 Changeset [61134] by tonikitoo@webkit.org

Spatial Navigation: make it work with focusable elements in overflow content
https://bugs.webkit.org/show_bug.cgi?id=36463

Reviewed by Simon Fraser and Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

This patch addresses the problem with Spatial Navigation. It currently does not
properly traverse scrollable contents, including scrollable div's. For this to work,
a new class member called scrollableEnclosingBox was introduced to FocusCandidate class which
keeps track of the current scrollable box Node wrapping a FocusCandidate.

To make use of enclosingScrollableBox of FocusCandidate, the DOM traversal routine
(FocusController::findNextFocusableInDirection) was changed as follows: when it
encounters a scrollable Node, each focusable node which is 'inner' keeps track of
the container reference. By the time a sibling of the scrollable Node is encountered,
there is no need to track this reference any more and the traversal algorithm continues
normally.

The common case is obviously that there is no scrollable container wrapping it.

updateFocusCandiditeIfCloser logic was also adapted to fit the need of the
newly introduced enclosingScrollableBox class member, getting simpler and more
easily maintainable.

Tests: fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html

fast/events/spatial-navigation/snav-clipped-overflow-content.html

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateInSameContainer):
(WebCore::updateFocusCandidateIfCloser):
(WebCore::FocusController::findFocusableNodeInDirection):
(WebCore::FocusController::deepFindFocusableNodeInDirection):

  • page/SpatialNavigation.cpp:

(WebCore::isScrollableContainerNode):

  • page/SpatialNavigation.h:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::FocusCandidate::inScrollableContainer):

LayoutTests:

  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html: Added.
  • fast/events/spatial-navigation/snav-clipped-overflow-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-clipped-overflow-content.html: Added.
11:59 Changeset [61133] by jianli@chromium.org

Unreviewed. Fix build break in GTK.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
11:43 Changeset [61132] by cfleizach@apple.com

AX: AXUnknown objects are being returned
https://bugs.webkit.org/show_bug.cgi?id=40574

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

  • platform/mac/accessibility/no-unknown-objects-when-title-attribute-present-expected.txt: Added.
  • platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html: Added.
11:34 Changeset [61131] by jianli@chromium.org

Fix code generators to better support Conditional attribute and add test
coverage for it.
https://bugs.webkit.org/show_bug.cgi?id=39512

Reviewed by Darin Adler.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj conditionalAttr1]):
(-[DOMTestObj setConditionalAttr1:]):
(-[DOMTestObj conditionalAttr2]):
(-[DOMTestObj setConditionalAttr2:]):
(-[DOMTestObj conditionalAttr3]):
(-[DOMTestObj setConditionalAttr3:]):

  • bindings/scripts/test/TestInterface.idl:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestInterface.cpp:
  • bindings/scripts/test/V8/V8TestInterface.h:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::conditionalAttr1AttrGetter):
(WebCore::TestObjInternal::conditionalAttr1AttrSetter):
(WebCore::TestObjInternal::conditionalAttr2AttrGetter):
(WebCore::TestObjInternal::conditionalAttr2AttrSetter):
(WebCore::TestObjInternal::conditionalAttr3AttrGetter):
(WebCore::TestObjInternal::conditionalAttr3AttrSetter):
(WebCore::):

11:30 Changeset [61130] by cfleizach@apple.com

Bug 40576 - AX: need to update iframe-bastardization.html LayoutTest to be more modern
https://bugs.webkit.org/show_bug.cgi?id=40576

10:29 Changeset [61129] by eric@webkit.org

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip canvas/philip/tests/2d.shadow.enable.x.html
and canvas/philip/tests/2d.shadow.enable.y.html.

https://bugs.webkit.org/show_bug.cgi?id=40434

  • platform/qt/Skipped:

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Change the type of ShadowSize from IntSize to FloatSize in GraphicsContext.
Using IntSize loses precision and fails the test.
Note: This code change fixes Qt port but Mac is still failing due to
platform issue.

https://bugs.webkit.org/show_bug.cgi?id=40434

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::applyShadow):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::getShadow):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::calculateShadowBufferDimensions): (WebCore::drawPathShadow): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::strokePath): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow):
  • platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::drawText):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setPlatformShadow):

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[win] Make windows compile after API changes.

https://bugs.webkit.org/show_bug.cgi?id=40434

  • WebKitGraphics.cpp: (WebDrawText):
10:06 Changeset [61128] by mitz@apple.com

<rdar://problem/7752961> Unevenly distributed space in justified text
https://bugs.webkit.org/show_bug.cgi?id=36105

Reviewed by Simon Fraser.

WebCore:

Test: fast/text/justify-padding-distribution.html

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Initialize m_padPerSpace to the quotient of the total
padding and the number of spaces rather than truncating it.
(WebCore::WidthIterator::advance): Subtract m_padPerSpace from m_padding and add the difference
between its old and new values, when rounded, to the advance.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/graphics/win/UniscribeController.h:

LayoutTests:

  • fast/text/justify-padding-distribution-expected.checksum: Added.
  • fast/text/justify-padding-distribution-expected.png: Added.
  • fast/text/justify-padding-distribution-expected.txt: Added.
  • fast/text/justify-padding-distribution.html: Added.
  • platform/mac/css1/box_properties/clear_float-expected.checksum:
  • platform/mac/css1/box_properties/clear_float-expected.png:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/mac/css1/text_properties/text_align-expected.checksum:
  • platform/mac/css1/text_properties/text_align-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.checksum:
  • platform/mac/fast/multicol/float-avoidance-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/mac/fast/text/atsui-spacing-features-expected.checksum:
  • platform/mac/fast/text/atsui-spacing-features-expected.png:
  • platform/mac/fast/text/justified-selection-at-edge-expected.checksum:
  • platform/mac/fast/text/justified-selection-at-edge-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:
09:38 Changeset [61127] by eric@webkit.org

2010-06-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Stack overflow when converting navigator object to QVariant
https://bugs.webkit.org/show_bug.cgi?id=40572

Protect against infinite recursion in JSValue->QVariant conversion.
This fixes a crash when trying to convert MimeType objects (they
recurse infinitely and on-the-fly via the enabledPlugin property.)

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):
09:27 Changeset [61126] by eric@webkit.org

2010-06-14 Yong Li <yoli@rim.com>

Test cases created by: Robin Cao <robin.cao@torchmobile.com.cn>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=38910

Suspend Document::m_executeScriptSoonTimer objects when the page is deferred.
There's no reason why we suspend all active DOM timers on the page but not suspend
this one. Document::m_executeScriptSoonTimer can run JS and schedule more DOM Timers.

It can only be tested manually.

  • manual-tests/load-deferrer-script-element.html: Added.
  • manual-tests/resources/load-deferrer-script-element.js: Added.
  • dom/Document.cpp: (WebCore::Document::executeScriptSoon): (WebCore::Document::suspendExecuteScriptSoonTimer): Added. (WebCore::Document::resumeExecuteScriptSoonTimer): Added.
  • dom/Document.h:
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
08:23 Changeset [61125] by bulach@chromium.org

2010-06-14 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Rebaseline LayoutTests/platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt.
https://bugs.webkit.org/show_bug.cgi?id=40568

https://bugs.webkit.org/show_bug.cgi?id=39994 changed the test expectations, and we need to rebaseline.

  • platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt:
08:13 Changeset [61124] by loislo@chromium.org

2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

This is a fix for flaky inspector tests at gtk-debug bots.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorFrontendClient::destroyInspectorWindow):
08:07 Changeset [61123] by laszlo.1.gombos@nokia.com

2010-06-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
07:31 Changeset [61122] by mitz@apple.com

Fixed a typo and reviewr information in ChangeLog files

07:09 Changeset [61121] by yael.aharon@nokia.com

[Qt] Platform plugin support for Notifications UI
https://bugs.webkit.org/show_bug.cgi?id=40005

Reviewed by Kenneth Rohde Christiansen.

WebCore:

To avoid race condition when GC is run during shutdown,
disconnect the Notification from the NotificationPresenter
when the presenter deletes itself.
This cannot be tested by a layout test, the race condition happens only
when GC is run during shutdown. It can be tested manually by loading
manually any notification test and closing the browser.

  • notifications/Notification.cpp:

(WebCore::Notification::~Notification):

  • notifications/Notification.h:

(WebCore::Notification::detachPresenter):

WebKit/qt:

Add an interface to the platform plugin to display notifications.
Implemented the notification in the example platform plugin.
This interface is enabled by default, but could be turned off with
a build flag. The platform plugin should control its own lifecycle,
so now the close timer applies only when using the QSystemTrayIcon.
That's because QSystemTrayIcon does not inform its caller when it
is closed.

Changed the way NotificationPresenterClientQt is deleted because it
is being accessed when GC is deleting the Notification objects.
NotificationPresenterClientQt is now detaching itself from the
Notifications before it is deleted.

  • Api/qwebkitplatformplugin.h:

(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebKitPlatformPlugin::):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::title):
(WebCore::NotificationIconWrapper::message):
(WebCore::NotificationIconWrapper::iconData):
(WebCore::NotificationPresenterClientQt::~NotificationPresenterClientQt):
(WebCore::NotificationIconWrapper::notificationClosed):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationForWrapper):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::detachNotification):

  • WebCoreSupport/NotificationPresenterClientQt.h:
  • WebCoreSupport/QtPlatformPlugin.cpp:

(WebCore::QtPlatformPlugin::createNotificationPresenter):

  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebNotificationPresenter.cpp: Added.

(WebNotificationWidget::WebNotificationWidget):
(WebNotificationWidget::~WebNotificationWidget):
(WebNotificationWidget::showNotification):
(WebNotificationWidget::event):

  • examples/platformplugin/WebNotificationPresenter.h: Added.

(WebNotificationPresenter::WebNotificationPresenter):
(WebNotificationPresenter::~WebNotificationPresenter):
(WebNotificationPresenter::showNotification):

  • examples/platformplugin/WebPlugin.cpp:

(WebPlugin::supportsExtension):

  • examples/platformplugin/WebPlugin.h:

(WebPlugin::createNotificationPresenter):

  • examples/platformplugin/platformplugin.pro:
  • examples/platformplugin/qwebkitplatformplugin.h:

(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebKitPlatformPlugin::):

06:42 Changeset [61120] by bulach@chromium.org

2010-06-08 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds IndexedDB's KeyRange.
https://bugs.webkit.org/show_bug.cgi?id=40250

  • storage/indexeddb/idb-keyrange-expected.txt: Added.
  • storage/indexeddb/idb-keyrange.html: Added.
  • storage/indexeddb/script-tests/idb-keyrange.js: Added. (checkSingleKeyRange): (checkLeftBoundKeyRange): ():

2010-06-08 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds IndexedDB's KeyRange.
https://bugs.webkit.org/show_bug.cgi?id=40250

Test: storage/indexeddb/idb-keyrange.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/IDBKeyRange.cpp: Added. (WebCore::IDBKeyRange::IDBKeyRange):
  • storage/IDBKeyRange.h: Added. (WebCore::IDBKeyRange::): (WebCore::IDBKeyRange::create): (WebCore::IDBKeyRange::~IDBKeyRange): (WebCore::IDBKeyRange::left): (WebCore::IDBKeyRange::right): (WebCore::IDBKeyRange::flags):
  • storage/IDBKeyRange.idl: Added.
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::makeSingleKeyRange): (WebCore::IndexedDatabaseRequest::makeLeftBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeRightBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeBoundKeyRange):
  • storage/IndexedDatabaseRequest.h:
  • storage/IndexedDatabaseRequest.idl:
06:28 Changeset [61119] by jorlow@chromium.org

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

And another.

  • storage/IndexedDatabaseRequest.h:
06:21 Changeset [61118] by jorlow@chromium.org

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

More build fixes.

  • storage/IndexedDatabaseRequest.h:

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Build fix.

  • src/IDBCallbacksProxy.h:
06:05 Changeset [61117] by ossy@webkit.org

[Qt] navigator.geolocation support for Qt port
https://bugs.webkit.org/show_bug.cgi?id=39724

Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-06-14
Reviewed by Laszlo Gombos.

WebCore:

Implemetion for Qt port of navigator.gelocation. Using qtmobility location service.

  • WebCore.pri:
  • WebCore.pro:
  • platform/qt/GeolocationServiceQt.cpp: Added.

(WebCore::GeolocationServiceQt::create):
(WebCore::GeolocationServiceQt::GeolocationServiceQt):
(WebCore::GeolocationServiceQt::~GeolocationServiceQt):
(WebCore::GeolocationServiceQt::positionUpdated):
(WebCore::GeolocationServiceQt::startUpdating):
(WebCore::GeolocationServiceQt::stopUpdating):

  • platform/qt/GeolocationServiceQt.h: Added.

(WebCore::GeolocationServiceQt::lastPosition):
(WebCore::GeolocationServiceQt::lastError):

WebKit/qt:

Implement ChromeClientQt::requestGeolocationPermissionForFrame() which delegates call to QWebPage::allowGeolocationRequest
Layout and unit test cases for the are also added.

  • Api/qwebpage.cpp:

(QWebPage::allowGeolocationRequest):

  • Api/qwebpage.h:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::shouldInterruptJavaScript):
(JSTestPage::allowGeolocationRequest):
(JSTestPage::setGeolocationPermission):
(tst_QWebPage::geolocationRequestJS):

WebKitTools:

Implementation for geolocation cases to DumpRenderTreeQt

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::allowGeolocationRequest):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setGeolocationPermission):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::setMockGeolocationPosition):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController::isGeolocationPermissionSet):
(LayoutTestController::geolocationPermission):

LayoutTests:

Uncommenting gelocation cases from Qt. Skipped one case: fast/dom/Geolocation/callback-to-remote-context2.html

  • platform/qt/Skipped:
05:57 Changeset [61116] by jorlow@chromium.org

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

2 more build fixes.

  • storage/IDBDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.h:
05:48 Changeset [61115] by jorlow@chromium.org

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Unreviewed build fix for my last.

  • workers/WorkerScriptLoaderClient.h:
05:35 Changeset [61114] by jorlow@chromium.org

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[V8] Clean up SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=40482

SerializedScriptValue doesn't follow WebKit's style guidelines very well
and needlessly inlines quite a bit within the .h file. This change cleans
things up. No funcitonal changes.

No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::deserializeAndSetProperty): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/SerializedScriptValue.h:
05:32 Changeset [61113] by loislo@chromium.org

2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
data from inspected page to WebInspector as JSON string via http. The native
serialization to JSON string is supported by InspectorValue's classes. This patch
has the implementation of sendMessageToFrontend function. WebKit version of it still
uses ScriptFunctionCall and will be switched to another transport a little bit later.
https://bugs.webkit.org/show_bug.cgi?id=40134

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::frontendLoaded):
  • inspector/InspectorValues.cpp: (WebCore::InspectorObject::writeJSON):
  • inspector/front-end/inspector.js: (WebInspector.dispatchMessageToFrontend):
  • loader/EmptyClients.h: (WebCore::EmptyInspectorClient::sendMessageToFrontend):
05:09 Changeset [61112] by eric@webkit.org

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Reenable IDBDatabaseRequest's description attribute
https://bugs.webkit.org/show_bug.cgi?id=39826

Existing test now fixed.

  • storage/indexeddb/idb-database-request-expected.txt:

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Reenable IDBDatabaseRequest's description attribute
https://bugs.webkit.org/show_bug.cgi?id=39826

On the 26th, Beth commented out the description attribute in
IDBDatabaseRequest because it was causing problems with the
objective c bindings. Turns out that this is the same bug as
in http://trac.webkit.org/changeset/19486. (Thanks for the
pointer, Mark!)

The solution is to change the objective C bindings generator
to change the name in the generated code. id and hash both
just appended "Name" to them in the past. I couldn't think
of anything else particularly better to append, so I just
went with name as well.

Test: building the world works on the first try. Layout

test verifies description works again.

  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_description): (webkit_dom_test_obj_get_id): (webkit_dom_test_obj_set_id): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjDescription): (WebCore::jsTestObjId): (WebCore::jsTestObjHash): (WebCore::setJSTestObjId):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj descriptionName]): (-[DOMTestObj idName]): (-[DOMTestObj setIdName:]): (-[DOMTestObj hashName]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::descriptionAttrGetter): (WebCore::TestObjInternal::idAttrGetter): (WebCore::TestObjInternal::idAttrSetter): (WebCore::TestObjInternal::hashAttrGetter): (WebCore::):
  • storage/IDBDatabaseRequest.idl:
00:55 Changeset [61111] by ossy@webkit.org

Unreviewed trivial fix.

[Qt] Update platform specific expected file after r61100.

  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.

06/13/10:

23:32 Changeset [61110] by eric@webkit.org

2010-06-13 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Test case to verify that MIME type in uppercase (TEXT/HTML) is supported.
https://bugs.webkit.org/show_bug.cgi?id=39492

  • http/tests/mime/resources/uppercase-mime-type.php: Added.
  • http/tests/mime/uppercase-mime-type-expected.txt: Added.
  • http/tests/mime/uppercase-mime-type.html: Added.

2010-06-13 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

Fix the QtWebKit which doesn't recognize the MIME type of HTML/TEXT in uppercase
https://bugs.webkit.org/show_bug.cgi?id=39492

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canShowMIMEType):
23:20 Changeset [61109] by eric@webkit.org

2010-06-13 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] ScreenQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39766

  • platform/qt/ScreenQt.cpp:
22:58 Changeset [61108] by eric@webkit.org

2010-06-13 Nathan Lawrence <nlawrence@apple.com>

Reviewed by Darin Adler.

Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
be a way of overwriting the Xcode system path. Making
$WEBKITOUTPUTDIR take precedence over the system default would make
this possible.

  • Scripts/webkitdirs.pm:
22:19 Changeset [61107] by eric@webkit.org

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename HTMLParser to LegacyHTMLTreeConstructor
https://bugs.webkit.org/show_bug.cgi?id=40554

This makes our old HTML parsing system closer match the
HTML5 spec, and thus easier to compare to the new HTML5
parsing system.

This rename was entirely automatic. Done by do-webcore-rename.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:
  • dom/DocumentParser.h: (WebCore::DocumentParser::htmlTreeConstructor):
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::htmlTreeConstructor):
  • html/HTML5DocumentParser.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder):
  • html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::legacyTreeConstructor):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser):
  • html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::htmlTreeConstructor):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
  • html/HTMLInputElement.cpp:
  • html/HTMLMeterElement.cpp:
  • html/HTMLProgressElement.cpp:
  • html/LegacyHTMLTreeConstructor.cpp: Renamed from WebCore/html/HTMLParser.cpp. (WebCore::addTags): (WebCore::HTMLStackElem::HTMLStackElem): (WebCore::HTMLStackElem::derefNode): (WebCore::LegacyHTMLTreeConstructor::LegacyHTMLTreeConstructor): (WebCore::LegacyHTMLTreeConstructor::~LegacyHTMLTreeConstructor): (WebCore::LegacyHTMLTreeConstructor::reset): (WebCore::LegacyHTMLTreeConstructor::setCurrent): (WebCore::tagPriorityOfNode): (WebCore::LegacyHTMLTreeConstructor::limitDepth): (WebCore::LegacyHTMLTreeConstructor::insertNodeAfterLimitDepth): (WebCore::LegacyHTMLTreeConstructor::parseToken): (WebCore::LegacyHTMLTreeConstructor::parseDoctypeToken): (WebCore::isTableSection): (WebCore::isTablePart): (WebCore::isTableRelated): (WebCore::isScopingTag): (WebCore::LegacyHTMLTreeConstructor::insertNode): (WebCore::LegacyHTMLTreeConstructor::handleError): (WebCore::LegacyHTMLTreeConstructor::textCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::commentCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::headCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::bodyCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::framesetCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::formCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::isindexCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::selectCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::ddCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::dtCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::rpCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::rtCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedPCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::nestedStyleCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::tableCellCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::tableSectionCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noembedCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noframesCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::noscriptCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::pCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::pCloserStrictCreateErrorCheck): (WebCore::LegacyHTMLTreeConstructor::mapCreateErrorCheck): (WebCore::mapTagToFunc): (WebCore::mapTagsToFunc): (WebCore::LegacyHTMLTreeConstructor::getNode): (WebCore::LegacyHTMLTreeConstructor::allowNestedRedundantTag): (WebCore::LegacyHTMLTreeConstructor::processCloseTag): (WebCore::LegacyHTMLTreeConstructor::isHeadingTag): (WebCore::LegacyHTMLTreeConstructor::isInline): (WebCore::LegacyHTMLTreeConstructor::isResidualStyleTag): (WebCore::LegacyHTMLTreeConstructor::isAffectedByResidualStyle): (WebCore::LegacyHTMLTreeConstructor::handleResidualStyleCloseTagAcrossBlocks): (WebCore::LegacyHTMLTreeConstructor::reopenResidualStyleTags): (WebCore::LegacyHTMLTreeConstructor::pushBlock): (WebCore::LegacyHTMLTreeConstructor::popBlock): (WebCore::LegacyHTMLTreeConstructor::popOneBlockCommon): (WebCore::LegacyHTMLTreeConstructor::popOneBlock): (WebCore::LegacyHTMLTreeConstructor::moveOneBlockToStack): (WebCore::LegacyHTMLTreeConstructor::checkIfHasPElementInScope): (WebCore::LegacyHTMLTreeConstructor::popInlineBlocks): (WebCore::LegacyHTMLTreeConstructor::freeBlock): (WebCore::LegacyHTMLTreeConstructor::createHead): (WebCore::LegacyHTMLTreeConstructor::handleIsindex): (WebCore::LegacyHTMLTreeConstructor::startBody): (WebCore::LegacyHTMLTreeConstructor::finished): (WebCore::LegacyHTMLTreeConstructor::reportErrorToConsole): (WebCore::shouldCreateImplicitHead): (WebCore::serializeForNumberType): (WebCore::parseToDoubleForNumberType):
  • html/LegacyHTMLTreeConstructor.h: Renamed from WebCore/html/HTMLParser.h. (WebCore::LegacyHTMLTreeConstructor::skipMode): (WebCore::LegacyHTMLTreeConstructor::isHandlingResidualStyleAcrossBlocks): (WebCore::LegacyHTMLTreeConstructor::setSkipMode): (WebCore::LegacyHTMLTreeConstructor::popBlock): (WebCore::LegacyHTMLTreeConstructor::hasPElementInScope): (WebCore::LegacyHTMLTreeConstructor::reportError): (WebCore::LegacyHTMLTreeConstructor::): (WebCore::shouldCreateImplicitHead):
  • html/StepRange.cpp:
  • html/ValidityState.cpp:
  • rendering/RenderSlider.cpp:
21:48 Changeset [61106] by abarth@webkit.org

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Rename m_parser, htmlParser() to m_treeConstructor, htmlTreeConstructor() in preparation for renaming HTMLParser
https://bugs.webkit.org/show_bug.cgi?id=40514

This rename was done by hand. I realize now I should have
renamed HTMLParser to HTMLTreeConstructor before renaming HTMLTokenizer.

No functional changes, thus no tests.

  • dom/DocumentParser.h: (WebCore::DocumentParser::htmlTreeConstructor):
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::pumpLexerIfPossible): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::end): (WebCore::HTML5DocumentParser::htmlTreeConstructor): (WebCore::HTML5DocumentParser::isWaitingForScripts): (WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution): (WebCore::HTML5DocumentParser::notifyFinished): (WebCore::HTML5DocumentParser::executeScriptsWaitingForStylesheets):
  • html/HTML5DocumentParser.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser): (WebCore::HTML5TreeBuilder::finished):
  • html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::legacyTreeConstructor):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::scriptHandler): (WebCore::HTMLDocumentParser::parseTag): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::processToken): (WebCore::HTMLDocumentParser::processDoctypeToken):
  • html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::htmlTreeConstructor):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
21:44 Changeset [61105] by abarth@webkit.org

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Rename tok, asHTMLTokenizer to parser, asHTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40513

Last set of Tokenizer related renames, also done via do-webcore-rename:
asHTMLTokenizer => asHTMLDocumentParser
tok => parser

No functional changes, thus no tests.

  • dom/Document.cpp: (WebCore::Document::write):
  • dom/DocumentParser.h: (WebCore::DocumentParser::asHTMLDocumentParser):
  • html/HTMLDocumentParser.cpp: (WebCore::parseHTMLDocumentFragment):
  • html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::asHTMLDocumentParser):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
21:40 Changeset [61104] by abarth@webkit.org

2010-06-13 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Fix the rest of the references to the old Tokenizer class (now DocumentParser)
https://bugs.webkit.org/show_bug.cgi?id=40512

No functional changes, thus no new tests.
This was mostly done by do-webcore-rename:
tokenizer => parser
m_tokenizer => m_parser
createTextTokenizer => createTextDocumentParser
createTokenizer => createParser
getTokenizer => getParser

However had to be careful to avoid renaming things related to
css/tokenizer.flex (which we should later rename to CSSTokenizer.flex)

Still a couple references with "tok" and "asHTMLTokenizer" which I'll
get in the next patch.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isLoaded):
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • dom/Document.cpp: (WebCore::Document::removedLastRef): (WebCore::Document::~Document): (WebCore::Document::createParser): (WebCore::Document::open): (WebCore::Document::cancelParsing): (WebCore::Document::implicitOpen): (WebCore::Document::implicitClose): (WebCore::Document::write): (WebCore::Document::finishParsing): (WebCore::Document::removePendingSheet):
  • dom/Document.h: (WebCore::Document::parser):
  • dom/DocumentParser.h:
  • dom/ViewportArguments.cpp: (WebCore::reportViewportWarning):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::PendingCallbacks::): (WebCore::getParser): (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::warningHandler): (WebCore::fatalErrorHandler): (WebCore::normalErrorHandler): (WebCore::getEntityHandler): (WebCore::startDocumentHandler): (WebCore::endDocumentHandler): (WebCore::internalSubsetHandler): (WebCore::externalSubsetHandler): (WebCore::parseXMLDocumentFragment):
  • dom/XMLDocumentParserQt.cpp: (WebCore::parseXMLDocumentFragment):
  • html/HTML5EntityParser.cpp:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • html/HTMLDocument.h:
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::write): (WebCore::HTMLDocumentParser::stopParsing):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::finished): (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser): (WebCore::HTMLViewSourceDocument::addLine):
  • html/HTMLViewSourceDocument.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin): (WebCore::DocumentWriter::addData):
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocument::createParser):
  • loader/FTPDirectoryDocument.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stop):
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::createParser):
  • loader/ImageDocument.h:
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::createParser):
  • loader/MediaDocument.h:
  • loader/PluginDocument.cpp: (WebCore::PluginDocument::createParser):
  • loader/PluginDocument.h:
  • loader/SinkDocument.cpp: (WebCore::SinkDocument::createParser):
  • loader/SinkDocument.h:
  • loader/TextDocument.cpp: (WebCore::TextDocument::createParser): (WebCore::createTextDocumentParser):
  • loader/TextDocument.h:
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
  • wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing):
  • wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
  • wml/WMLTemplateElement.cpp: (WebCore::WMLTemplateElement::registerTemplatesInDocument):
21:00 Changeset [61103] by cfleizach@apple.com

AX: link won't return linked element if URL contains #
https://bugs.webkit.org/show_bug.cgi?id=40192

WebCore:

Reviewed by Darin Adler.

Test: platform/mac/accessibility/internal-link-when-document-has-fragment.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::internalLinkElement):

WebKitTools:

Reviewed by Darin Adler.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(linkedUIElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::linkedUIElementAtIndex):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::linkedUIElementAtIndex):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::linkedUIElementAtIndex):

LayoutTests:

Reviewed by Darin Alder.

  • platform/mac/accessibility/internal-link-when-document-has-fragment-expected.txt: Added.
  • platform/mac/accessibility/internal-link-when-document-has-fragment.html: Added.
20:37 Changeset [61102] by simon.fraser@apple.com

2010-06-13 Simon Fraser <simon.fraser@apple.com>

Fix GTK bots; don't include the offsetWidth in the results
since it can differ between platforms.

  • transitions/font-family-during-transition-expected.txt:
  • transitions/font-family-during-transition.html:
19:42 Changeset [61101] by weinig@apple.com

Try and fix the chrome build.

  • bindings/scripts/CodeGeneratorV8.pm:
  • xml/XMLHttpRequest.idl:
19:27 Changeset [61100] by weinig@apple.com

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=40550
XMLHttpRequest constructor object should expose the constants from the IDL.

Reviewed by Anders Carlsson.

Test: fast/dom/XMLHttpRequest-constants.html

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: Removed.
  • bindings/js/JSXMLHttpRequestConstructor.h: Removed.
  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):

  • bindings/scripts/CodeGeneratorJS.pm:
  • xml/XMLHttpRequest.idl:

LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=40550
XMLHttpRequest constructor object should expose the constants from the IDL.

Reviewed by Anders Carlsson.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/XMLHttpRequest-constants-expected.txt: Added.
  • fast/dom/XMLHttpRequest-constants.html: Added.
  • fast/dom/script-tests/XMLHttpRequest-constants.js: Added.
18:47 Changeset [61099] by simon.fraser@apple.com

2010-06-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

-webkit-transition font-size and font-family
https://bugs.webkit.org/show_bug.cgi?id=33429

When animating font-size, update the font with a saved
version of the font selector to ensure that we don't clobber
the font family.

Test: transitions/font-family-during-transition.html

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setBlendedFontSize):
18:37 Changeset [61098] by eric@webkit.org

2010-06-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
https://bugs.webkit.org/show_bug.cgi?id=39550

This can cause an extra request to bugs.webkit.org durig upload, but it
shouldn't be too bad. Also, this won't work if you remove the
boilerplate created by prepare-ChangeLog.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
17:58 Changeset [61097] by tony@chromium.org

2010-06-13 Tony Chang <tony@chromium.org>

Build fix, not reviewed.

fix chromium compile after r61094 (id attribute refactor)
https://bugs.webkit.org/show_bug.cgi?id=40553

  • bindings/v8/custom/V8NamedNodesCollection.cpp: (WebCore::V8NamedNodesCollection::itemWithName):

2010-06-13 Tony Chang <tony@chromium.org>

Build fix, not reviewed.

fix chromium compile after r61094 (id attribute refactor)
https://bugs.webkit.org/show_bug.cgi?id=40553

  • src/ChromeClientImpl.cpp:
  • src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::nameForAutofill):
12:01 Changeset [61096] by darin@apple.com

Updated Windows-platform results for the fix for bug 40394.
The patch fixed the cross-platform results, GTK results, and Qt results,
but there were Windows results too.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
10:50 Changeset [61095] by darin@apple.com

Partly done support for alternate ID attributes should be removed
https://bugs.webkit.org/show_bug.cgi?id=39692

Reviewed by Alexey Proskuryakov.

Removed the include of "HTMLNames.h" from "Element.h". This prevents
near-world-rebuilds every time you change HTMLTagNames.in.

Renamed the getIDAttribute function in the Element class to
idForStyleResolution, since it returns a value of the id attribute
that has been lowercased as appropriate for style matching, not the
actual value of the attribute. With the old name it was easy to
misuse it in non-style contexts.

Got rid of the idAttributeName function on Element, since it is
easy to use it wrong. Replace it with isIdAttributeName, getIdAttribute,
and setIdAttribute functions, which are a good fit for the needs of
most call sites that were dealing with the id attribute.

Added an idAttributeName function to Document. This is for a future
where a document can have a custom id attribute name specified in its
doctype. It's possible this will be insufficient because the same
document might have XHTML or SVG elements in it, and it's possible
that on those elements we will want the attribute named "id" with
no namespace to still work. We can deal with that when we implement
the actual feature, though. For now, it seems OK to fetch the name
of the id attribute from the document.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeList::itemWithName):

  • dom/StaticNodeList.cpp:

(WebCore::StaticNodeList::itemWithName):

  • rendering/RenderSVGResourceContainer.h:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::idChanged):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::handleDeepUseReferencing):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):
Use the new idForStyleResolution function, which is the new name of
the getIDAttribute function. There's a good chance these call sites are
incorrect, which is something we should investigate later, so there's
a FIXME at each call site.

  • dom/Document.cpp:

(WebCore::Document::Document): Initialize m_idAttributeName to the
standard id attribute from HTML.
(WebCore::Document::getElementById): Use Element::getIdAttribute.

  • dom/Document.h: Added Document::idAttributeName.
  • dom/Element.cpp:

(WebCore::Element::setAttribute): Use Document::idAttributeName.
(WebCore::Element::setAttributeMap): Use Element::isIdAttributeName.
(WebCore::Element::insertedIntoDocument): Use Document::idAttributeName.
(WebCore::Element::removedFromDocument): Ditto.
(WebCore::Element::formatForDebugger): Use Element::getIdAttribute.

  • dom/Element.h: Added isIdAttributeName, getIdAttribute, setIdAttribute,

idForStyleResolution. Removed rareIDAttributeName.

  • dom/ElementRareData.h: Removed m_idAttributeName.
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setAttributes): Use Document::idAttributeName.

  • dom/NamedNodeMap.h: Renamed id, setID, and m_id to idForStyleResolution,

setIdForStyleResolution, and m_idForStyleResolution since this is not the
value of the id attribute because it gets lowercased for compatibility-mode
documents.

  • rendering/RenderIFrame.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderProgress.cpp:

Added include of HTMLNames.h now that Element.h no longer includes it.

  • editing/SetNodeAttributeCommand.h:
  • editing/markup.cpp:
  • html/HTMLParser.cpp:

Removed unneeded includes.

  • html/HTMLParser.h: Sorted includes.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::matchRules): Use idForStyleResolution.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Use idForStyleResolution.

  • dom/Attr.cpp:

(WebCore::Attr::isId): Use Document::idAttributeName.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::parseMappedAttribute): Use isIdAttributeName,
and setIdForStyleResolution.

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI): Use setIdAttribute.

  • editing/EditorCommand.cpp:

(WebCore::executeInsertHorizontalRule): Ditto.

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::parseMappedAttribute): Use isIdAttributeName.
(WebCore::HTMLAppletElement::createRenderer): Use getIdAttribute.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::checkForNameMatch): Use getIdAttribute.
(WebCore::HTMLCollection::updateNameCache): Use getIdAttribute.

  • html/HTMLDataGridColElement.cpp:

(WebCore::HTMLDataGridColElement::ensureColumn): Use getIdAttribute.
(WebCore::HTMLDataGridColElement::parseMappedAttribute): Use isIdAttributeName.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute): Use isIdAttributeName.

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::nextNamedItem): Added missing braces.
(WebCore::HTMLFormCollection::updateNameCache): Use getIdAttribute.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseMappedAttribute): Use isIdAttributeName.
(WebCore::HTMLFrameElementBase::setName): Use getIdAttribute.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseMappedAttribute): Use isIdAttributeName.

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::parseMappedAttribute): Use isIdAttributeName.
Also restructured the function a bit to make its structure clearer and added
a comment pointing out that it can't be quite right.

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::itemAfter): Use getIdAttribute.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute): Use isIdAttributeName.

  • html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::parseMappedAttribute): Use isIdAttributeName.

  • loader/CachedFont.cpp:

(WebCore::CachedFont::getSVGFontById): Use getIdAttribute.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::nameForLayer): Use getIdAttribute.

  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGPaintingResource): Use getIdAttribute.
(WebCore::writeSVGResourceContainer): Ditto.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::insertedIntoDocument): Use getIdAttribute.

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::isKnownAttribute): Use isIdAttributeName.
(WebCore::SVGStyledElement::svgAttributeChanged): Use isIdAttributeName.

  • wml/WMLElement.cpp:

(WebCore::WMLElement::parseMappedAttribute): Use isIdAttributeName.

10:29 Changeset [61094] by darin@apple.com

2010-06-12 Darin Adler <darin@apple.com>

Reviewed by Alexey Proskuryakov.

Partly done support for alternate ID attributes should be removed
https://bugs.webkit.org/show_bug.cgi?id=39692

Removed the include of "HTMLNames.h" from "Element.h". This prevents
near-world-rebuilds every time you change HTMLTagNames.in.

Renamed the getIDAttribute function in the Element class to
idForStyleResolution, since it returns a value of the id attribute
that has been lowercased as appropriate for style matching, not the
actual value of the attribute. With the old name it was easy to
misuse it in non-style contexts.

Got rid of the idAttributeName function on Element, since it is
easy to use it wrong. Replace it with isIdAttributeName, getIdAttribute,
and setIdAttribute functions, which are a good fit for the needs of
most call sites that were dealing with the id attribute.

Added an idAttributeName function to Document. This is for a future
where a document can have a custom id attribute name specified in its
doctype. It's possible this will be insufficient because the same
document might have XHTML or SVG elements in it, and it's possible
that on those elements we will want the attribute named "id" with
no namespace to still work. We can deal with that when we implement
the actual feature, though. For now, it seems OK to fetch the name
of the id attribute from the document.

  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
  • dom/StaticNodeList.cpp: (WebCore::StaticNodeList::itemWithName):
  • rendering/RenderSVGResourceContainer.h: (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::idChanged):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::handleDeepUseReferencing):
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations): Use the new idForStyleResolution function, which is the new name of the getIDAttribute function. There's a good chance these call sites are incorrect, which is something we should investigate later, so there's a FIXME at each call site.
  • dom/Document.cpp: (WebCore::Document::Document): Initialize m_idAttributeName to the standard id attribute from HTML. (WebCore::Document::getElementById): Use Element::getIdAttribute.
  • dom/Document.h: Added Document::idAttributeName.
  • dom/Element.cpp: (WebCore::Element::setAttribute): Use Document::idAttributeName. (WebCore::Element::setAttributeMap): Use Element::isIdAttributeName. (WebCore::Element::insertedIntoDocument): Use Document::idAttributeName. (WebCore::Element::removedFromDocument): Ditto. (WebCore::Element::formatForDebugger): Use Element::getIdAttribute.
  • dom/Element.h: Added isIdAttributeName, getIdAttribute, setIdAttribute, idForStyleResolution. Removed rareIDAttributeName.
  • dom/ElementRareData.h: Removed m_idAttributeName.
  • dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::setAttributes): Use Document::idAttributeName.
  • dom/NamedNodeMap.h: Renamed id, setID, and m_id to idForStyleResolution, setIdForStyleResolution, and m_idForStyleResolution since this is not the value of the id attribute because it gets lowercased for compatibility-mode documents.
  • rendering/RenderIFrame.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderProgress.cpp: Added include of HTMLNames.h now that Element.h no longer includes it.
  • editing/SetNodeAttributeCommand.h:
  • editing/markup.cpp:
  • html/HTMLParser.cpp: Removed unneeded includes.
  • html/HTMLParser.h: Sorted includes.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): Use idForStyleResolution. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Use idForStyleResolution.
  • dom/Attr.cpp: (WebCore::Attr::isId): Use Document::idAttributeName.
  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Use isIdAttributeName, and setIdForStyleResolution.
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI): Use setIdAttribute.
  • editing/EditorCommand.cpp: (WebCore::executeInsertHorizontalRule): Ditto.
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::parseMappedAttribute): Use isIdAttributeName. (WebCore::HTMLAppletElement::createRenderer): Use getIdAttribute.
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): Use getIdAttribute. (WebCore::HTMLCollection::updateNameCache): Use getIdAttribute.
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::ensureColumn): Use getIdAttribute. (WebCore::HTMLDataGridColElement::parseMappedAttribute): Use isIdAttributeName.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): Use isIdAttributeName.
  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::nextNamedItem): Added missing braces. (WebCore::HTMLFormCollection::updateNameCache): Use getIdAttribute.
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): Use isIdAttributeName. (WebCore::HTMLFrameElementBase::setName): Use getIdAttribute.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Use isIdAttributeName.
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute): Use isIdAttributeName. Also restructured the function a bit to make its structure clearer and added a comment pointing out that it can't be quite right.
  • html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::itemAfter): Use getIdAttribute.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): Use isIdAttributeName.
  • html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::parseMappedAttribute): Use isIdAttributeName.
  • loader/CachedFont.cpp: (WebCore::CachedFont::getSVGFontById): Use getIdAttribute.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::nameForLayer): Use getIdAttribute.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGPaintingResource): Use getIdAttribute. (WebCore::writeSVGResourceContainer): Ditto.
  • svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument): Use getIdAttribute.
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isKnownAttribute): Use isIdAttributeName. (WebCore::SVGStyledElement::svgAttributeChanged): Use isIdAttributeName.
  • wml/WMLElement.cpp: (WebCore::WMLElement::parseMappedAttribute): Use isIdAttributeName.
10:22 Changeset [61093] by mitz@apple.com

Updated results after r61092.

  • fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
09:40 Changeset [61092] by mitz@apple.com

<rdar://problem/8087385> REGRESSION (r60974): Continuous wheel scrolling is too fast in list boxes and in Safari Reader
https://bugs.webkit.org/show_bug.cgi?id=40537

Reviewed by Darin Adler.

  • platform/mac/WheelEventMac.mm:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Only multiply by pixelsPerLineStep() if the
event is not continuous, as was before r56012.

06:54 Changeset [61091] by abecsi@webkit.org

Centralize the gperf code generation commands into make-hash-tools.pl
to avoid redundancy across multiple build systems.
Do this in preparation of refactoring the usage of these generated
sources to fix the debug linking error on Linux with gcc >= 4.4.0.

WebCore:

Reviewed by Darin Adler.

webkit.org/b/29244

No functionality change, so no new tests needed.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_gperf.py: Removed.
  • WebCore.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:

(WebCore::cssPropertyID):
(WebCore::cssValueKeywordID):

  • css/makeprop.pl:
  • css/makevalues.pl:
  • html/DocTypeStrings.gperf:
  • html/HTML5EntityParser.cpp:
  • html/HTMLDocumentParser.cpp:
  • html/HTMLEntityNames.gperf:
  • html/PreloadScanner.cpp:
  • make-hash-tools.pl: Added.
  • platform/ColorData.gperf:
  • platform/graphics/Color.cpp:

WebKit/chromium:

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-06-13
Reviewed by Darin Adler.

webkit.org/b/29244

  • src/WebEntities.cpp:
06:29 Changeset [61090] by robert@webkit.org

2010-06-08 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
https://bugs.webkit.org/show_bug.cgi?id=40330

  • platform/qt/Skipped: Unskip fast/events/onbeforeunload-focused-iframe.html

2010-06-08 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
https://bugs.webkit.org/show_bug.cgi?id=40330

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shouldClose):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-08 Robert Hogan <robert@webkit.org>

Reviewed by Eric Seidel.

[Qt] Add support for callShouldCloseOnWebView() to DRT
https://bugs.webkit.org/show_bug.cgi?id=40330

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::callShouldCloseOnWebView):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::setCallCloseOnWebViews):
06:05 Changeset [61089] by eric@webkit.org

2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tests/hybridPixmap fails
https://bugs.webkit.org/show_bug.cgi?id=37316

The problem was that JSC::Instance::createRuntimeObject was never called.
This is fixed by overloading newRuntimeObject and calling Instance::createRuntimeObject
in between, instead of creating the runtime object directly inside the static function
QtPixmapInstance::createRuntimeObject, which had to be renamed as to not overshadow the virtual function.

This fixes an existing test, tests/hybridPixmap

  • bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapInstance::newRuntimeObject): (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):
  • bridge/qt/qt_pixmapruntime.h:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
02:11 Changeset [61088] by adachan@apple.com

Unreviewed fix for a linking error with WebKit2LocalizableStringsBundle for Windows release build.

  • WebProcess/win/WebLocalizableStrings.cpp: (findCachedString):
01:33 Changeset [61087] by eric@webkit.org

2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Darin Adler.

GraphicsContext3D.h in the Qt port includes too many unnecessary files
https://bugs.webkit.org/show_bug.cgi?id=40536

Removed unncessary includes.

No new tests; Compilation improvement.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
01:20 Changeset [61086] by eric@webkit.org

2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Eric Seidel.

[Qt] GraphicsLayer: recaching images creates an unnecessary deep copy
https://bugs.webkit.org/show_bug.cgi?id=40535

Made sure the painter ends its operation before copying the pixmap.

No new tests: this is an optimization.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::recache):
00:54 Changeset [61085] by eric@webkit.org

2010-06-13 Clemmitt Sigler <cmsigler@gmail.com>

Reviewed by Eric Seidel.

Patch to fix missing references to RenderMathMLRoot,
RenderMathMLSquareRoot when building GtkLauncher.
https://bugs.webkit.org/show_bug.cgi?id=40326

No change in functionality so no new tests.

  • GNUmakefile.am:

06/12/10:

22:50 Changeset [61084] by dimich@chromium.org

Not reviewed, update Chromium expected result following r61071.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
22:49 Changeset [61083] by adachan@apple.com

2010-06-12 Brian Weinstein <bweinstein@apple.com>

Reviewed by Dan Bernstein.


https://bugs.webkit.org/show_bug.cgi?id=40538


Some machines have started to see the return of the dreaded: WebCore.lib : fatal error LNK1106: invalid
file or disk full. Since we don't have the hotfix for VS2005, work around this in the meantime
by creating an EditingAllInOne file, that includes all of the cpp files in the editing subdirectory.


  • WebCore.vcproj/WebCore.vcproj: Prevnt the editing cpp from building, so we only compile EditingAllInOne.
  • editing/EditingAllInOne.cpp: Added. Includes all of the editing cpp files.
22:39 Changeset [61082] by eric@webkit.org

2010-06-12 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61031.
http://trac.webkit.org/changeset/61031
https://bugs.webkit.org/show_bug.cgi?id=40539

Crashes Dromaeo jslib test in Release Chromium (Requested by
dimich_ on #webkit).

  • bindings/v8/V8Binding.cpp: (WebCore::v8ExternalString):
  • bindings/v8/V8Binding.h:
22:36 Changeset [61081] by eric@webkit.org

2010-06-12 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename the last few *Tokenizer classes (which don't have their own files) to *DocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40508

This was a very simple do-webcore-rename-generated patch.

PluginTokenizer => PluginDocumentParser
TextTokenizer => TextDocumentParser
SinkTokenizer => SinkDocumentParser
MediaTokenizer => MediaDocumentParser
FTPDirectoryTokenizer => FTPDirectoryDocumentParser

No functional changes, thus no tests.

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
  • html/HTMLViewSourceDocument.h:
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser): (WebCore::FTPDirectoryDocumentParser::appendEntry): (WebCore::FTPDirectoryDocumentParser::createTDForFilename): (WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine): (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate): (WebCore::FTPDirectoryDocumentParser::createBasicDocument): (WebCore::FTPDirectoryDocumentParser::write): (WebCore::FTPDirectoryDocumentParser::finish): (WebCore::FTPDirectoryDocument::createTokenizer):
  • loader/MediaDocument.cpp: (WebCore::MediaDocumentParser::MediaDocumentParser): (WebCore::MediaDocumentParser::write): (WebCore::MediaDocumentParser::createDocumentStructure): (WebCore::MediaDocumentParser::writeRawData): (WebCore::MediaDocumentParser::finish): (WebCore::MediaDocumentParser::isWaitingForScripts): (WebCore::MediaDocument::createTokenizer):
  • loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::PluginDocumentParser): (WebCore::PluginDocumentParser::pluginWidgetFromDocument): (WebCore::PluginDocumentParser::write): (WebCore::PluginDocumentParser::createDocumentStructure): (WebCore::PluginDocumentParser::writeRawData): (WebCore::PluginDocumentParser::finish): (WebCore::PluginDocumentParser::isWaitingForScripts): (WebCore::PluginDocument::createTokenizer): (WebCore::PluginDocument::pluginWidget):
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::SinkDocumentParser): (WebCore::SinkDocumentParser::finish): (WebCore::SinkDocument::createTokenizer):
  • loader/TextDocument.cpp: (WebCore::TextDocumentParser::TextDocumentParser): (WebCore::TextDocumentParser::~TextDocumentParser): (WebCore::TextDocumentParser::write): (WebCore::TextDocumentParser::finish): (WebCore::TextDocumentParser::isWaitingForScripts): (WebCore::TextDocument::createTokenizer): (WebCore::createTextTokenizer):
22:19 Changeset [61080] by eric@webkit.org

2010-06-12 Eric Seidel <eric@webkit.org>

Reviewed by Daniel Bates.

do-webcore-rename should have a --verbose option
https://bugs.webkit.org/show_bug.cgi?id=40497

  • Scripts/do-webcore-rename:
    • Unified how we handle skipping files/directories this will allow us to "black list" certain files and directories when performing renames.
    • Made do-webcore-rename log what it's skipping when passed --verbose.
21:52 Changeset [61079] by darin@apple.com
  • Scripts/run-bindings-tests: Fixed a typo in a message.
21:46 Changeset [61078] by eric@webkit.org

2010-06-12 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] EventHandlerQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40259

Coding style change only.

  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::eventActivatedView):
21:29 Changeset [61077] by eric@webkit.org

2010-06-12 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Unify fileSystemRepresentation and filenameFromString
https://bugs.webkit.org/show_bug.cgi?id=40201

Remove filenameFromString and use fileSystemRepresentation instead
as they do the same job.

  • platform/FileSystem.cpp: Removed.
  • platform/FileSystem.h:
  • platform/efl/FileSystemEfl.cpp: (WebCore::fileSystemRepresentation):
  • platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
  • platform/gtk/FileSystemGtk.cpp: (WebCore::fileSystemRepresentation): (WebCore::filenameForDisplay): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::makeAllDirectories): (WebCore::pathGetFileName): (WebCore::directoryName): (WebCore::listDirectory):
  • platform/gtk/SharedBufferGtk.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
  • platform/posix/SharedBufferPOSIX.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
21:15 Changeset [61076] by eric@webkit.org

2010-06-12 Patrick Gansterer <paroga@paroga.com>

Reviewed by Eric Seidel.

[Haiku] Cleanup SharedBuffer::createWithContentsOfFile
https://bugs.webkit.org/show_bug.cgi?id=39003

  • platform/haiku/SharedBufferHaiku.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
21:04 Changeset [61075] by eric@webkit.org

2010-06-12 Anders Bakken <agbakken@gmail.com>

Reviewed by Eric Seidel.

[Qt] WheelEventQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=39760

  • platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
20:41 Changeset [61074] by eric@webkit.org

2010-06-12 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Don't include POSIX headers in WebCorePrefix.h
https://bugs.webkit.org/show_bug.cgi?id=39411

When building for BREW MP, don't include POSIX headers:
<fcntl.h>, <pthread.h> and <sys/types.h>.

  • WebCorePrefix.h:
19:16 Changeset [61073] by eric@webkit.org

2010-06-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename the rest of the *Tokenizer classes to *DocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40507

  • wtf/Platform.h:
    • fixed a comment to match new names.

2010-06-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename the rest of the *Tokenizer classes to *DocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40507

This search/replace was done by do-webcore-rename.
Just looking for a rubber stamp.

XMLTokenizer => XMLDocumentParser
XMLTokenizerLibxml2 => XMLDocumentParserLibxml2
XMLTokenizerQt => XMLDocumentParserQt
XMLTokenizerScope => XMLDocumentParserScope
HTML5Tokenizer => HTML5DocumentParser
HTMLTokenizer => HTMLDocumentParser

No functional change, thus no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
  • dom/Document.cpp: (WebCore::Document::createTokenizer): (WebCore::Document::write):
  • dom/Document.h: (WebCore::Document::setXMLEncoding):
  • dom/DocumentParser.h: (WebCore::DocumentParser::asHTMLTokenizer):
  • dom/Element.cpp:
  • dom/ProcessingInstruction.cpp:
  • dom/XMLDocumentParser.cpp: Added. (WebCore::XMLDocumentParser::isWMLDocument): (WebCore::XMLDocumentParser::pushCurrentNode): (WebCore::XMLDocumentParser::popCurrentNode): (WebCore::XMLDocumentParser::clearCurrentNodeStack): (WebCore::XMLDocumentParser::write): (WebCore::XMLDocumentParser::handleError): (WebCore::XMLDocumentParser::enterText): (WebCore::toString): (WebCore::XMLDocumentParser::exitText): (WebCore::XMLDocumentParser::end): (WebCore::XMLDocumentParser::finish): (WebCore::createXHTMLParserErrorHeader): (WebCore::XMLDocumentParser::insertErrorMessageBlock): (WebCore::XMLDocumentParser::notifyFinished): (WebCore::XMLDocumentParser::isWaitingForScripts): (WebCore::XMLDocumentParser::pauseParsing):
  • dom/XMLDocumentParser.h: Added. (WebCore::XMLParserContext::context): (WebCore::XMLParserContext::XMLParserContext): (WebCore::XMLDocumentParser::): (WebCore::XMLDocumentParser::setIsXHTMLDocument): (WebCore::XMLDocumentParser::isXHTMLDocument): (WebCore::XMLDocumentParser::setIsXHTMLMPDocument): (WebCore::XMLDocumentParser::isXHTMLMPDocument): (WebCore::XMLDocumentParser::wellFormed): (WebCore::XMLDocumentParser::context):
  • dom/XMLDocumentParserLibxml2.cpp: Added. (WebCore::PendingCallbacks::~PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::isEmpty): (WebCore::PendingCallbacks::PendingCallback::~PendingCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::PendingCallbacks::): (WebCore::matchFunc): (WebCore::OffsetBuffer::OffsetBuffer): (WebCore::OffsetBuffer::readOutBytes): (WebCore::shouldAllowExternalLoad): (WebCore::openFunc): (WebCore::readFunc): (WebCore::writeFunc): (WebCore::closeFunc): (WebCore::errorFunc): (WebCore::XMLParserContext::createStringParser): (WebCore::XMLParserContext::createMemoryParser): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLParserContext::~XMLParserContext): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::toString): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::internalSubset): (WebCore::getTokenizer): (WebCore::hackAroundLibXMLEntityBug): (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::warningHandler): (WebCore::fatalErrorHandler): (WebCore::normalErrorHandler): (WebCore::): (WebCore::sharedXHTMLEntity): (WebCore::getXHTMLEntity): (WebCore::getEntityHandler): (WebCore::startDocumentHandler): (WebCore::endDocumentHandler): (WebCore::internalSubsetHandler): (WebCore::externalSubsetHandler): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::xmlDocPtrForString): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::parseXMLDocumentFragment): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes):
  • dom/XMLDocumentParserQt.cpp: Added. (WebCore::EntityResolver::resolveUndeclaredEntity): (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::stopParsing): (WebCore::XMLDocumentParser::resumeParsing): (WebCore::parseXMLDocumentFragment): (WebCore::attributesStartElementNsHandler): (WebCore::parseAttributes): (WebCore::prefixFromQName): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseCharacters): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::endDocument): (WebCore::XMLDocumentParser::hasError): (WebCore::XMLDocumentParser::parseDtd):
  • dom/XMLDocumentParserScope.cpp: Added. (WebCore::XMLDocumentParserScope::XMLDocumentParserScope): (WebCore::XMLDocumentParserScope::~XMLDocumentParserScope):
  • dom/XMLDocumentParserScope.h: Added.
  • dom/XMLTokenizer.cpp: Removed.
  • dom/XMLTokenizer.h: Removed.
  • dom/XMLTokenizerLibxml2.cpp: Removed.
  • dom/XMLTokenizerQt.cpp: Removed.
  • dom/XMLTokenizerScope.cpp: Removed.
  • dom/XMLTokenizerScope.h: Removed.
  • html/HTML5DocumentParser.cpp: Added. (WebCore::): (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::~HTML5DocumentParser): (WebCore::HTML5DocumentParser::begin): (WebCore::HTML5DocumentParser::pumpLexerIfPossible): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::write): (WebCore::HTML5DocumentParser::end): (WebCore::HTML5DocumentParser::attemptToEnd): (WebCore::HTML5DocumentParser::endIfDelayed): (WebCore::HTML5DocumentParser::finish): (WebCore::HTML5DocumentParser::executingScript): (WebCore::HTML5DocumentParser::lineNumber): (WebCore::HTML5DocumentParser::columnNumber): (WebCore::HTML5DocumentParser::htmlParser): (WebCore::HTML5DocumentParser::isWaitingForScripts): (WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution): (WebCore::HTML5DocumentParser::watchForLoad): (WebCore::HTML5DocumentParser::stopWatchingForLoad): (WebCore::HTML5DocumentParser::shouldLoadExternalScriptFromSrc): (WebCore::HTML5DocumentParser::executeScript): (WebCore::HTML5DocumentParser::notifyFinished): (WebCore::HTML5DocumentParser::executeScriptsWaitingForStylesheets): (WebCore::HTML5DocumentParser::script):
  • html/HTML5DocumentParser.h: Added. (WebCore::HTML5DocumentParser::InputStream::InputStream): (WebCore::HTML5DocumentParser::InputStream::appendToEnd): (WebCore::HTML5DocumentParser::InputStream::insertAtCurrentInsertionPoint): (WebCore::HTML5DocumentParser::InputStream::close): (WebCore::HTML5DocumentParser::InputStream::current): (WebCore::HTML5DocumentParser::InputStream::splitInto): (WebCore::HTML5DocumentParser::InputStream::mergeFrom): (WebCore::HTML5DocumentParser::InsertionPointRecord::InsertionPointRecord): (WebCore::HTML5DocumentParser::InsertionPointRecord::~InsertionPointRecord): (WebCore::HTML5DocumentParser::inWrite):
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::columnNumber):
  • html/HTML5Tokenizer.cpp: Removed.
  • html/HTML5Tokenizer.h: Removed.
  • html/HTML5TreeBuilder.cpp:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
  • html/HTMLDocumentParser.cpp: Added. (WebCore::): (WebCore::fixUpChar): (WebCore::tagMatch): (WebCore::Token::addAttribute): (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::reset): (WebCore::HTMLDocumentParser::begin): (WebCore::HTMLDocumentParser::setForceSynchronous): (WebCore::HTMLDocumentParser::processListing): (WebCore::HTMLDocumentParser::parseNonHTMLText): (WebCore::HTMLDocumentParser::scriptHandler): (WebCore::HTMLDocumentParser::scriptExecution): (WebCore::HTMLDocumentParser::parseComment): (WebCore::HTMLDocumentParser::parseServer): (WebCore::HTMLDocumentParser::parseProcessingInstruction): (WebCore::HTMLDocumentParser::parseText): (WebCore::HTMLDocumentParser::parseEntity): (WebCore::HTMLDocumentParser::parseDoctype): (WebCore::HTMLDocumentParser::parseTag): (WebCore::HTMLDocumentParser::continueProcessing): (WebCore::HTMLDocumentParser::advance): (WebCore::HTMLDocumentParser::willWriteHTML): (WebCore::HTMLDocumentParser::didWriteHTML): (WebCore::HTMLDocumentParser::write): (WebCore::HTMLDocumentParser::stopParsing): (WebCore::HTMLDocumentParser::processingData): (WebCore::HTMLDocumentParser::timerFired): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::finish): (WebCore::HTMLDocumentParser::processToken): (WebCore::HTMLDocumentParser::processDoctypeToken): (WebCore::HTMLDocumentParser::~HTMLDocumentParser): (WebCore::HTMLDocumentParser::enlargeBuffer): (WebCore::HTMLDocumentParser::enlargeScriptBuffer): (WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::HTMLDocumentParser::notifyFinished): (WebCore::HTMLDocumentParser::executeExternalScriptsIfReady): (WebCore::HTMLDocumentParser::executeExternalScriptsTimerFired): (WebCore::HTMLDocumentParser::continueExecutingExternalScripts): (WebCore::HTMLDocumentParser::isWaitingForScripts): (WebCore::HTMLDocumentParser::setSrc): (WebCore::parseHTMLDocumentFragment): (WebCore::decodeNamedEntity):
  • html/HTMLDocumentParser.h: Added. (WebCore::Token::Token): (WebCore::Token::~Token): (WebCore::Token::isOpenTag): (WebCore::Token::isCloseTag): (WebCore::Token::reset): (WebCore::Token::addViewSourceChar): (WebCore::): (WebCore::DoctypeToken::DoctypeToken): (WebCore::DoctypeToken::reset): (WebCore::DoctypeToken::state): (WebCore::DoctypeToken::setState): (WebCore::HTMLDocumentParser::forceSynchronous): (WebCore::HTMLDocumentParser::executingScript): (WebCore::HTMLDocumentParser::lineNumber): (WebCore::HTMLDocumentParser::columnNumber): (WebCore::HTMLDocumentParser::processingContentWrittenByScript): (WebCore::HTMLDocumentParser::htmlParser): (WebCore::HTMLDocumentParser::asHTMLTokenizer): (WebCore::HTMLDocumentParser::checkBuffer): (WebCore::HTMLDocumentParser::checkScriptBuffer): (WebCore::HTMLDocumentParser::): (WebCore::HTMLDocumentParser::State::State): (WebCore::HTMLDocumentParser::State::tagState): (WebCore::HTMLDocumentParser::State::setTagState): (WebCore::HTMLDocumentParser::State::entityState): (WebCore::HTMLDocumentParser::State::setEntityState): (WebCore::HTMLDocumentParser::State::inScript): (WebCore::HTMLDocumentParser::State::setInScript): (WebCore::HTMLDocumentParser::State::inStyle): (WebCore::HTMLDocumentParser::State::setInStyle): (WebCore::HTMLDocumentParser::State::inXmp): (WebCore::HTMLDocumentParser::State::setInXmp): (WebCore::HTMLDocumentParser::State::inTitle): (WebCore::HTMLDocumentParser::State::setInTitle): (WebCore::HTMLDocumentParser::State::inIFrame): (WebCore::HTMLDocumentParser::State::setInIFrame): (WebCore::HTMLDocumentParser::State::inPlainText): (WebCore::HTMLDocumentParser::State::setInPlainText): (WebCore::HTMLDocumentParser::State::inProcessingInstruction): (WebCore::HTMLDocumentParser::State::setInProcessingInstruction): (WebCore::HTMLDocumentParser::State::inComment): (WebCore::HTMLDocumentParser::State::setInComment): (WebCore::HTMLDocumentParser::State::inDoctype): (WebCore::HTMLDocumentParser::State::setInDoctype): (WebCore::HTMLDocumentParser::State::inTextArea): (WebCore::HTMLDocumentParser::State::setInTextArea): (WebCore::HTMLDocumentParser::State::escaped): (WebCore::HTMLDocumentParser::State::setEscaped): (WebCore::HTMLDocumentParser::State::inServer): (WebCore::HTMLDocumentParser::State::setInServer): (WebCore::HTMLDocumentParser::State::skipLF): (WebCore::HTMLDocumentParser::State::setSkipLF): (WebCore::HTMLDocumentParser::State::startTag): (WebCore::HTMLDocumentParser::State::setStartTag): (WebCore::HTMLDocumentParser::State::discardLF): (WebCore::HTMLDocumentParser::State::setDiscardLF): (WebCore::HTMLDocumentParser::State::allowYield): (WebCore::HTMLDocumentParser::State::setAllowYield): (WebCore::HTMLDocumentParser::State::loadingExtScript): (WebCore::HTMLDocumentParser::State::setLoadingExtScript): (WebCore::HTMLDocumentParser::State::forceSynchronous): (WebCore::HTMLDocumentParser::State::setForceSynchronous): (WebCore::HTMLDocumentParser::State::inAnyNonHTMLText): (WebCore::HTMLDocumentParser::State::hasTagState): (WebCore::HTMLDocumentParser::State::hasEntityState): (WebCore::HTMLDocumentParser::State::needsSpecialWriteHandling): (WebCore::HTMLDocumentParser::State::): (WebCore::HTMLDocumentParser::State::setBit): (WebCore::HTMLDocumentParser::State::testBit):
  • html/HTMLElement.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::reportErrorToConsole):
  • html/HTMLParser.h:
  • html/HTMLTokenizer.cpp: Removed.
  • html/HTMLTokenizer.h: Removed.
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::addViewSourceToken):
  • html/HTMLViewSourceDocument.h:
  • loader/DocumentLoader.cpp:
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::FTPDirectoryTokenizer): (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): (WebCore::FTPDirectoryTokenizer::finish):
  • loader/FrameLoader.cpp:
  • loader/ImageDocument.cpp:
  • loader/MediaDocument.cpp:
  • loader/PluginDocument.cpp:
  • loader/TextDocument.cpp:
  • page/XSSAuditor.h:
  • svg/SVGDocumentExtensions.cpp:
  • wml/WMLErrorHandling.cpp: (WebCore::reportWMLError):
  • xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::parseString):
  • xml/XSLTProcessor.cpp:
  • xml/XSLTProcessorLibxslt.cpp:

2010-06-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename the rest of the *Tokenizer classes to *DocumentParser
https://bugs.webkit.org/show_bug.cgi?id=40507

  • src/WebEntities.cpp:
    • Fix a comment to match new class names.
19:09 Changeset [61072] by eric@webkit.org

2010-06-12 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] Menu key should act on current selection even if it is not editable
https://bugs.webkit.org/show_bug.cgi?id=40348

Allow the menu key to act on non-editable selections.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):
18:03 Changeset [61071] by eric@webkit.org

2010-06-12 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Window object should have CanvasGradient and CanvasPattern
https://bugs.webkit.org/show_bug.cgi?id=40394

Unskipped 2 tests that are now working properly.

  • canvas/philip/tests/2d.gradient.object.return-expected.txt:
  • canvas/philip/tests/2d.pattern.basic.type-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:

2010-06-12 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Window object should have CanvasGradient and CanvasPattern
https://bugs.webkit.org/show_bug.cgi?id=40394

This fixes the following tests:

  • canvas/philip/tests/2d.gradient.object.return.html
  • canvas/philip/tests/2d.pattern.basic.type.html
  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasPattern.idl:
  • page/DOMWindow.idl:
16:35 Changeset [61070] by mitz@apple.com

<rdar://problem/8025267> REGRESSION (Safari 4-TOT): Crash when a frame’s resize handler removes the frame
https://bugs.webkit.org/show_bug.cgi?id=40534

Reviewed by Oliver Hunt.

WebCore:

Test: fast/replaced/frame-removed-during-resize.html

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetPosition): Null-check m_widget, since resizing the widget
may trigger an iframe’s resize handler, which may destroy the widget.

LayoutTests:

  • fast/replaced/frame-removed-during-resize-expected.txt: Added.
  • fast/replaced/frame-removed-during-resize.html: Added.
15:34 Changeset [61069] by dimich@chromium.org

Not reviewed, update for Chromium test expectations.

  • platform/chromium/test_expectations.txt:
15:16 Changeset [61068] by simon.fraser@apple.com

2010-06-12 Dean Jackson <dino@apple.com>

Reviewed by Darin Adler.

Animation keyframe timing functions are applying incorrectly
https://bugs.webkit.org/show_bug.cgi?id=38963

When copying RenderStyles, we have to clone the AnimationList so that each keyframe
can have its own timing function.

Tests: animations/keyframe-timing-functions-transform.html

animations/keyframe-timing-functions2.html

  • platform/animation/Animation.h: (WebCore::Animation::create):
  • platform/animation/AnimationList.cpp: (WebCore::AnimationList::AnimationList):
  • platform/animation/AnimationList.h: (WebCore::AnimationList::AnimationList):
14:08 Changeset [61067] by bweinstein@apple.com

Roll out r61066, it was meant to be made on the trunk, not the branch.

14:00 Changeset [61066] by bweinstein@apple.com

Some machines have started to see the return of the dreaded: WebCore.lib : fatal error LNK1106:
invalid file or disk full. Since we don't have the hotfix for VS2005, work around this in the meantime
by creating an EditingAllInOne file, that includes all of the cpp files in the editing subdirectory.

Rubber-stamped by Darin Adler.

  • WebCore.vcproj/WebCore.vcproj: Prevnt the editing cpp from building, so we only compile EditingAllInOne.
  • editing/EditingAllInOne.cpp: Added. Includes all of the editing cpp files.
13:05 Changeset [61065] by mitz@apple.com

<rdar://problem/7882140> -webkit-column-break-* properties don’t do anything
https://bugs.webkit.org/show_bug.cgi?id=40531

Reviewed by Dave Hyatt.

WebCore:

Test: fast/multicol/break-properties.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren): Check for -webkit-column-break-{before,after}: always
and -webkit-column-break-inside: avoid when doing column layout.

LayoutTests:

  • fast/multicol/break-properties-expected.txt: Added.
  • fast/multicol/break-properties.html: Added.
11:06 ApplicationsGtk edited by patternjake@hotmail.com
(diff)
11:05 Applications using WebKit edited by patternjake@hotmail.com
(diff)
11:05 Changeset [61064] by eric@webkit.org

2010-06-12 Dawit Alemayehu <adawit@kde.org>

Reviewed by Kenneth Rohde Christiansen.

Added an attribute to enable/disable site specific quirks mode in WebKit.
The attribute is enabled by default.

https://bugs.webkit.org/show_bug.cgi?id=40073

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
09:45 Changeset [61063] by robert@webkit.org

2010-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix tst_qwebframe regression from http://trac.webkit.org/changeset/61062

Only use cacheableBindingRootObject() if the object has QtOwnership.

https://bugs.webkit.org/show_bug.cgi?id=40527

  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):
06:41 Changeset [61062] by robert@webkit.org

2010-06-13 Robert Hogan <robert@webkit.org>

Reviewed by Alexey Proskuryakov.

FrameLoader::clear() clears JS objects that cached pages later rely on

https://bugs.webkit.org/show_bug.cgi?id=37725
https://bugs.webkit.org/show_bug.cgi?id=31626

Fix the following tests for Qt:

fast/events/pageshow-pagehide-on-back-cached.html
fast/events/pageshow-pagehide-on-back-cached-with-frames.html
fast/loader/input-element-page-cache-crash.html
fast/dom/Window/timer-resume-on-navigation-back.html
loader/go-back-to-different-window-size.html
fast/dom/javascript-url-crash-function.html
fast/dom/location-new-window-no-crash.html
http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html

which currently fail because the page's Qt-bindings runtime objects are
cleared when navigating away from the page containing them.

Track Qt-bindings objects in a separate ScriptController::cacheableRootBindingObject().
RuntimeObjects tracked by this root object will not get invalidated on page navigations,
so they will still be available when the pages containing them are retrieved from the
b/f cache.

This means the Qt bindings objects will only get cleared on Frame::pageDestroyed().

  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::cacheableBindingRootObject):
  • bindings/js/ScriptController.h:
  • platform/qt/Skipped:
05:44 Changeset [61061] by tkent@chromium.org

2010-06-12 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
https://bugs.webkit.org/show_bug.cgi?id=40402

_build_path() of each Chromium port check existence of build path
of Chromium checkout first, then check existence of build path of
WebKit-only checkout.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
04:33 Changeset [61060] by tkent@chromium.org

REGRESSION: Can't submit a form with <input type=radio required>
https://bugs.webkit.org/show_bug.cgi?id=40429

Reviewed by Darin Adler.

WebCore:

Validity state was not updated correctly for radio buttons, and it
prevents form submission even if a radio button group has a
checked radio button.

Test: fast/forms/interactive-validation-required-radio.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateCheckedRadioButtons):

Call setNeedsValidityCheck() for all of radio buttons in the same group
to update validity state.

(WebCore::HTMLInputElement::setChecked):

Remove setNeedsValidityCheck() call because it is called in
updateCheckedRadioButtons().

LayoutTests:

  • fast/forms/ValidityState-valueMissing-radio-expected.txt:
  • fast/forms/interactive-validation-required-radio-expected.txt: Added.
  • fast/forms/interactive-validation-required-radio.html: Added.
  • fast/forms/script-tests/ValidityState-valueMissing-radio.js: We need to test against a radio group with at least three radio buttons because we should test behaviors of
    • checked
    • unchecked
    • neither checked nor unchecked
04:19 Changeset [61059] by tkent@chromium.org

Disable interactive form validation in non-strict modes
https://bugs.webkit.org/show_bug.cgi?id=40218

Reviewed by Dimitri Glazkov.

WebCore:

The interactive validation feature of HTML5 is not compatible with
HTML4, and users and page authors don't expect existing sites work
differently in WebKit. For example, maxlength and required attributes
in existing sites unexpectedly prevented form submission.
So, we disable the interactive validation feature in non-strict
modes to improve compatibility.

Test: fast/forms/interactive-validation-compat-mode.html

fast/forms/interactive-validation-html4.html

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

Process interactive validation only in the strict mode.

LayoutTests:

  • fast/forms/interactive-validation-compat-mode-expected.txt: Added.
  • fast/forms/interactive-validation-compat-mode.html: Added.
  • fast/forms/interactive-validation-html4-expected.txt: Added.
  • fast/forms/interactive-validation-html4.html: Added.
01:21 Changeset [61058] by eric@webkit.org

2010-06-12 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add documentation to the QtWebkit bridge
https://bugs.webkit.org/show_bug.cgi?id=35861

The previous accepted patch was actually a faulty one; It was hard to trace since it's just a documentation
change. The new patch amends that, with the correct snippets and grammar fixes.

  • docs/qtwebkit-bridge.qdoc:
  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction):
01:10 Changeset [61057] by eric@webkit.org

2010-06-12 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Rename Tokenizer to DocumentParser to match what it actually does
https://bugs.webkit.org/show_bug.cgi?id=40504

The rename was entirely done by do-webcore-rename.
The only manual changes were removing out-dated comments
and fixing Tokenizer_h to DocumentParser_h in the header guards.

I'll do all the rest of the renames (like the tokenizer subclasses
and the tokenizer() createTokenizer() methods) in separate changes.

No functional change, thus no tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/v8/ScriptEventListener.cpp:
  • dom/Document.cpp: (WebCore::Document::createTokenizer):
  • dom/Document.h: (WebCore::Document::tokenizer):
  • dom/DocumentParser.h: Added. (WebCore::DocumentParser::~DocumentParser): (WebCore::DocumentParser::stopParsing): (WebCore::DocumentParser::processingData): (WebCore::DocumentParser::executingScript): (WebCore::DocumentParser::wantsRawData): (WebCore::DocumentParser::writeRawData): (WebCore::DocumentParser::inViewSourceMode): (WebCore::DocumentParser::setInViewSourceMode): (WebCore::DocumentParser::wellFormed): (WebCore::DocumentParser::lineNumber): (WebCore::DocumentParser::columnNumber): (WebCore::DocumentParser::executeScriptsWaitingForStylesheets): (WebCore::DocumentParser::htmlParser): (WebCore::DocumentParser::asHTMLTokenizer): (WebCore::DocumentParser::xssAuditor): (WebCore::DocumentParser::setXSSAuditor): (WebCore::DocumentParser::DocumentParser):
  • dom/Tokenizer.h: Removed.
  • dom/ViewportArguments.cpp: (WebCore::reportViewportWarning):
  • dom/XMLTokenizer.h:
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::stopParsing):
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::stopParsing):
  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::HTML5Tokenizer):
  • html/HTML5Tokenizer.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
  • html/HTMLDocument.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::stopParsing):
  • html/HTMLTokenizer.h:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
  • html/HTMLViewSourceDocument.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::addData):
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocument::createTokenizer):
  • loader/FTPDirectoryDocument.h:
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::createTokenizer):
  • loader/ImageDocument.h:
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::createTokenizer):
  • loader/MediaDocument.h:
  • loader/PluginDocument.cpp: (WebCore::PluginDocument::createTokenizer):
  • loader/PluginDocument.h:
  • loader/SinkDocument.cpp: (WebCore::SinkDocument::createTokenizer):
  • loader/SinkDocument.h:
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextDocument::createTokenizer): (WebCore::createTextTokenizer):
  • loader/TextDocument.h:
  • wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing):
00:36 Changeset [61056] by eric@webkit.org

2010-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Back-forward list dumping is incorrect

https://bugs.webkit.org/show_bug.cgi?id=36392

Support dumping child history items in DRT.

Unskip:

fast/loader/frame-src-change-added-to-history.html
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

  • platform/qt/Skipped:

2010-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Back-forward list dumping is incorrect

https://bugs.webkit.org/show_bug.cgi?id=36392

Support dumping child history items in DRT.

Unskip:

fast/loader/frame-src-change-added-to-history.html
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

  • Api/qwebhistory.cpp: (QWebHistoryItemPrivate::core):
  • Api/qwebhistory.h:
  • Api/qwebhistory_p.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::isTargetItem): (DumpRenderTreeSupportQt::historyItemTarget): (DumpRenderTreeSupportQt::getChildHistoryItems):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-12 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Back-forward list dumping is incorrect

https://bugs.webkit.org/show_bug.cgi?id=36392

Support dumping child history items in DRT.

Unskip:

fast/loader/frame-src-change-added-to-history.html
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem):
00:23 Changeset [61055] by eric@webkit.org

2010-06-12 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTML5Tokenizer needs to tell the InspectorTimelineAgent before and after it writes
https://bugs.webkit.org/show_bug.cgi?id=40417

This "fixes" inspector/timeline-script-tag-1.html. HTML5 results
differ from the old parser for expected reasons.

HTML5Tokenizer calls InspectorTimelineAgent::will/didWriteHTML every
time we pump the lexer instead of every write() call.
We end up pumping the lexer slightly more often than the old code called
write() in order to cleanly handle unclosed-entities, unclosed tags,
buffered characters, etc. at the end of a document.

I discussed this extensively with James Robinson in #webkit and we decided
that it was better for the HTML5Tokenizer to call for every pump and
that the Inspector should later filter out empty pumps.

We can't filter out empty pumps yet, because the number of parsed
characters is passed in willWrite instead of didWrite and thus is
speculative (and wrong). This is a problem independent of this change
as willWrite's "length" argument is wrong in different ways for the old
parser, including always being 0 when the old parser resumes.

Tested by inspector/timeline-script-tag-1.html

  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::willPumpLexer):
    • Notify the InspectorTimelineAgent we're about to process input.

(WebCore::HTML5Tokenizer::didPumpLexer):

  • Notify the InspectorTimelineAgent we did process tokens.

(WebCore::HTML5Tokenizer::pumpLexer):

  • Call willPump and didPump
  • html/HTML5Tokenizer.h:
  • inspector/InspectorTimelineAgent.h:
    • Add a FIXME about passing length to didWrite instead of willWrite.
00:09 Changeset [61054] by eric@webkit.org

2010-06-11 Eric Seidel <eric@webkit.org>

Unreviewed. Just updating expectations.

tables/mozilla/bugs/bug1188.html needlessly depends on HTML Parser text node handling
https://bugs.webkit.org/show_bug.cgi?id=40485

The current HTML5 parser is expected to fail the new webkit01 test.
It will be fixed when we fix text-node coalescing as discussed in
the previous commit.

  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:
Note: See TracTimeline for information about the timeline view.