Timeline



Jun 18, 2010:

11:54 PM Changeset in webkit [61466] by aa@chromium.org
  • 5 edits in trunk

2010-06-18 Aaron Boodman <aa@chromium.org>

WebKit API: Undo static hooks into V8 when WebKit is shut down.
https://bugs.webkit.org/show_bug.cgi?id=40816

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded): (WebCore::V8DOMWindowShell::initializeV8IfNeeded): (WebCore::V8DOMWindowShell::uninitializeV8IfNeeded):
  • bindings/v8/V8DOMWindowShell.h:

2010-06-18 Aaron Boodman <aa@chromium.org>

WebKit API: Undo static hooks into V8 when WebKit is shut downm
https://bugs.webkit.org/show_bug.cgi?id=40816

  • src/WebKit.cpp: (WebKit::shutdown): Call new WebCore::V8DOMWindowShell::uninitializeV8IfNeeded().
9:33 PM Changeset in webkit [61465] by rwlbuis@webkit.org
  • 1 edit
    1 move
    3 adds in trunk/LayoutTests

2010-06-18 Rob Buis <rwlbuis@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19575
layout test svg/batik/text/textDecoration.svg hangs

Reenable this test since crash is gone (tested on OS X 10.5.8).

  • platform/mac/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/mac/svg/batik/text/textDecoration-expected.png: Added.
  • platform/mac/svg/batik/text/textDecoration-expected.txt: Added.
  • svg/batik/text/textDecoration.svg: Renamed from LayoutTests/svg/batik/text/textDecoration.svg-disabled.
8:35 PM Changeset in webkit [61464] by abarth@webkit.org
  • 6 edits in trunk/WebKit/mac

2010-06-18 Adam Barth <abarth@webkit.org>

Unreviewed, rolling out r61459.
http://trac.webkit.org/changeset/61459
https://bugs.webkit.org/show_bug.cgi?id=40869

Seems to have broken two tests on the Tiger buildbot:

dom/html/level2/html/AppletsCollection.html
plugins/qt-qwidget-plugin.html

Anders wasn't on #webkit...

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage setName:]): (-[WebBasePluginPackage setPath:]): (-[WebBasePluginPackage setPluginDescription:]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
8:23 PM Changeset in webkit [61463] by jberlin@webkit.org
  • 2 edits in trunk/WebCore

Bug 19509 - Database Tables in the Inspector should be sortable
https://bugs.webkit.org/show_bug.cgi?id=19509

Reviewed by Darin Adler.

  • inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel.prototype.dataGridForResult):
Make each column in the DataGrid sortable.
(WebInspector.StoragePanel.prototype._sortDataGrid.comparator):
Make sure to sort numeric columns by their numeric values, instead of lexicographically.
(WebInspector.StoragePanel.prototype._sortDataGrid):
Sort the entries in the DataGrid based on the selected column.

8:18 PM Changeset in webkit [61462] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

  • WebCore.gyp/WebCore.gyp: Modified inclusion rule in to actually add WebSystemInterface.mm.
6:15 PM Changeset in webkit [61461] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage isJavaPlugIn]):

6:07 PM Changeset in webkit [61460] by andersca@apple.com
  • 4 edits in trunk/WebCore

More clang++ warning fixes.

Reviewed by Oliver Hunt.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):

  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/mac/WebLayer.mm:

(-[CALayer _descriptionWithPrefix:]):

5:35 PM Changeset in webkit [61459] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
https://bugs.webkit.org/show_bug.cgi?id=40869

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
5:15 PM Changeset in webkit [61458] by atwilson@chromium.org
  • 6 edits in trunk

[Chromium] Plumbing for top-level frame names
https://bugs.webkit.org/show_bug.cgi?id=40430

Reviewed by Darin Fisher.

WebKit/chromium:

  • public/WebFrame.h:

Removed obsolete clearName() API and added better documentation for
setName().

  • src/WebFrameImpl.cpp:

Removed clearName() API.

  • src/WebFrameImpl.h:

Removed clearName() API.

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):
Changed obsolete call to clearName() to use setName(WebString()) instead.

5:15 PM Changeset in webkit [61457] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Test by Chris Brichford.

https://bugs.webkit.org/show_bug.cgi?id=19759
ChildNodeList for an attribute node is not properly invalidated after appending a child

This issue has been fixed in another bug, just landing an additional test.

  • fast/dom/Attr/child-nodes-length-cache-expected.txt: Added.
  • fast/dom/Attr/child-nodes-length-cache.html: Added.
5:01 PM Changeset in webkit [61456] by andersca@apple.com
  • 3 edits
    1 move in trunk/WebKit

WebKit: Rename WebPluginPackage.m to make it an Objective-C++ file.

Reviewed by Sam Weinig.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac: Rename WebPluginPackage.m to make it an Objective-C++ file.

Reviewed by Sam Weinig.

  • Plugins/WebPluginPackage.m: Removed.
  • Plugins/WebPluginPackage.mm: Copied from Plugins/WebPluginPackage.m.
4:56 PM Changeset in webkit [61455] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

  • WebCore.gyp/WebCore.gyp: Renamed WebSystemInterface.m to WebSystemInterface.mm.
4:51 PM Changeset in webkit [61454] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of the NSEnumerators from WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40868

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage MIMETypes]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
4:23 PM Changeset in webkit [61453] by andersca@apple.com
  • 10 edits
    2 moves in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebKit.xcodeproj/project.pbxproj:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebCoreSupport/WebSystemInterface.h:
  • WebCoreSupport/WebSystemInterface.m: Removed.
  • WebCoreSupport/WebSystemInterface.mm: Copied from WebKit/mac/WebCoreSupport/WebSystemInterface.m.

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • platform/mac/WebCoreSystemInterface.h:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.h:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.m: Removed.
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: Copied from WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.m.
  • mac/WebKit2.exp:
4:17 PM Changeset in webkit [61452] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Clean up WebPluginDatabase.mm
https://bugs.webkit.org/show_bug.cgi?id=40866

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (pathByResolvingSymlinksAndAliases): (-[WebBasePluginPackage initWithPath:]): Change an instance method into a static function.


  • Plugins/WebPluginDatabase.mm: (PluginPackageCandidates::PluginPackageCandidates): (PluginPackageCandidates::update): (PluginPackageCandidates::bestCandidate): Add a new PluginPackageCandidates class.


(-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
Use PluginPackageCandidates here.

4:13 PM Changeset in webkit [61451] by levin@chromium.org
  • 4 edits
    2 adds in trunk

WebCore: Convert column span from an unsigned short type to an unsigned int
type. Fixes a divide-by-zero crash arising from using a zero colspan
value coming from a narrow cast of an int to an unsigned short.
https://bugs.webkit.org/show_bug.cgi?id=40812

Patch by Abhishek Arya <inferno@chromium.org> on 2010-06-18
Reviewed by Adam Barth.

Test: fast/table/zero-colspan-crash.html

  • rendering/RenderTable.h: Change span from unsigned short to unsigned int.
  • rendering/RenderTableSection.cpp: Fix a compiler warning with comparing unsigned int with signed int. Value of an unsigned int here cannot be greater than maximum positive value of a signed int.

(WebCore::RenderTableSection::addCell):

LayoutTests: Tests that we do not crash while rendering a fixed table layout.
https://bugs.webkit.org/show_bug.cgi?id=40812

Patch by Abhishek Arya <inferno@chromium.org> on 2010-06-18
Reviewed by Adam Barth.

  • fast/table/zero-colspan-crash-expected.txt: Added.
  • fast/table/zero-colspan-crash.html: Added.
4:09 PM Changeset in webkit [61450] by oliver@apple.com
  • 4 edits in trunk

2010-06-18 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Incorrect handling of multiple BOMs scattered through a file.
https://bugs.webkit.org/show_bug.cgi?id=40865

When determining the offset of open and close braces in a source
with BOMs we were finishing our count early as we failed to account
for BOMs prior to the open/close brace positions effecting those
positions.

  • parser/Lexer.cpp: (JSC::Lexer::sourceCode):

2010-06-18 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Incorrect handling of multiple BOMs scattered through a file.
https://bugs.webkit.org/show_bug.cgi?id=40865

Put a few more BOMs into this testcase so that it hits the other cases
that were missed before.

  • fast/js/resources/bom-in-file-retains-correct-offset.js: (g.f): (g):
4:01 PM Changeset in webkit [61449] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • WebCoreSupport/WebPlatformStrategies.mm:
3:30 PM Changeset in webkit [61448] by Dimitri Glazkov
  • 11 edits
    2 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update a few more chromium-win baselines after http://trac.webkit.org/changeset/61393.

3:20 PM Changeset in webkit [61447] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add platform strategies for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=40863

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added. (WebKit::WebPlatformStrategies::initialize): (WebKit::WebPlatformStrategies::WebPlatformStrategies): (WebKit::WebPlatformStrategies::createPluginStrategy): (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess):
3:16 PM Changeset in webkit [61446] by Dimitri Glazkov
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update a few more chromium-mac baselines after http://trac.webkit.org/changeset/61393.

3:11 PM Changeset in webkit [61445] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Text spacing miscalculation when using wordSpacing.
https://bugs.webkit.org/show_bug.cgi?id=40483

Patch by Ananth Jasty <ext-ananth.jasty@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

Removed wordSpacing compensation in FontQt whitespace width
calculation. The QFontMetrics::width() overload that takes
a character does not take QFont's word spacing into account.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText):

3:08 PM Changeset in webkit [61444] by andersca@apple.com
  • 10 edits
    1 delete in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PluginDataMac.mm and use the plug-in strategy instead
https://bugs.webkit.org/show_bug.cgi?id=40860

  • Plugins/WebBasePluginPackage.h:
  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createPluginStrategy): (WebPlatformStrategies::refreshPlugins): (WebPlatformStrategies::getPluginInfo):
  • WebCoreSupport/WebViewFactory.mm:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PluginDataMac.mm and use the plug-in strategy instead
https://bugs.webkit.org/show_bug.cgi?id=40860

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/WebCoreViewFactory.h:
  • plugins/PluginData.cpp: (WebCore::PluginData::refresh): (WebCore::PluginData::initPlugins):
  • plugins/PluginStrategy.h:
  • plugins/mac/PluginDataMac.mm: Removed.
2:52 PM Changeset in webkit [61443] by weinig@apple.com
  • 9 edits
    5 adds
    1 delete in trunk
2:50 PM Changeset in webkit [61442] by Dimitri Glazkov
  • 18 edits in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update chromium baselines after http://trac.webkit.org/changeset/61418.

2:48 PM Changeset in webkit [61441] by andersca@apple.com
  • 7 edits in trunk/WebCore

Fix some (not all) clang++ warnings.

Reviewed by Dan Bernstein.

  • dom/Position.h:

(WebCore::lastOffsetInNode):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::resourceForRequest):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition):
(WebCore::ComplexTextController::collectComplexTextRuns):

  • platform/network/CredentialStorage.cpp:

(WebCore::protectionSpaceMapKeyFromURL):

  • rendering/style/StyleRareNonInheritedData.h:
2:44 PM Changeset in webkit [61440] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Skipped some failing tests and conglomerated a skipped test into another group.

  • platform/gtk/Skipped: Cleanups and three more skipped tests.
2:40 PM Changeset in webkit [61439] by Dimitri Glazkov
  • 285 edits
    58 adds
    44 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update chromium-linux baselines after http://trac.webkit.org/changeset/61393.

2:23 PM Changeset in webkit [61438] by andersca@apple.com
  • 8 edits
    2 adds in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebKit.xcodeproj/project.pbxproj:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebCoreSupport/WebPlatformStrategies.h: Added.
  • WebCoreSupport/WebPlatformStrategies.mm: Added. (WebPlatformStrategies::initialize): (WebPlatformStrategies::WebPlatformStrategies): (WebPlatformStrategies::createPluginStrategy):
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebCore.base.exp:
  • platform/PlatformStrategies.cpp:
  • platform/PlatformStrategies.h: (WebCore::PlatformStrategies::~PlatformStrategies):
2:19 PM Changeset in webkit [61437] by Dimitri Glazkov
  • 798 edits
    73 adds in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Update chromium-win baselines after http://trac.webkit.org/changeset/61393.

2:09 PM Changeset in webkit [61436] by andersca@apple.com
  • 4 edits in trunk/WebCore

Fix build errors when building with clang++.

Reviewed by Darin Adler.

  • loader/archive/cf/LegacyWebArchiveMac.mm:

Move the const qualifier to the right place.

  • page/EditorClient.h:
  • platform/Pasteboard.h:

Use @class when forward declaring Objective-C classes in Objective-C.

2:05 PM Changeset in webkit [61435] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=40852
<rdar://problem/8105498> Limit simultaneous DNS prefetch request number (40852)

No change in functionality, so no tests.

We still queue up to 64 names, but only make up to 8 requests at once. If there are names
remaining in queue, we retry after a short timeout (which is easier than posting
notifications from client callback).

  • platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::add): (WebCore::DNSResolveQueue::fired):
2:03 PM Changeset in webkit [61434] by mrobinson@webkit.org
  • 2 edits
    27 adds in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests and correcting one incorrect baseline.

  • platform/gtk/media/video-replaces-poster-expected.txt: Correting this incorrect baseline.
  • platform/gtk/svg/hixie/text/001-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-1-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-2-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-3-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-4-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt: Added.
2:01 PM Changeset in webkit [61433] by robert@webkit.org
  • 4 edits in trunk

2010-06-18 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • platform/qt/Skipped:

2010-06-18 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):
1:44 PM Changeset in webkit [61432] by zmo@google.com
  • 2 edits in trunk/WebCore

WebGL demos show bad flicker
https://bugs.webkit.org/show_bug.cgi?id=38560

1:41 PM Changeset in webkit [61431] by mrobinson@webkit.org
  • 2 edits
    74 adds in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests. Some tests that fail have been labeled
with bug numbers. Also removed a newly defunct test from the skipped list.

  • platform/gtk/Skipped: Removed newly baselined tests and one defunct test.
  • platform/gtk/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
  • platform/gtk/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt: Added.
  • platform/gtk/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
  • platform/gtk/fast/css/inline-element-line-break-expected.txt: Added.
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt: Added.
  • platform/gtk/fast/css/pseudo-element-line-break-expected.txt: Added.
  • platform/gtk/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.
  • platform/gtk/fast/multicol/single-line-expected.txt: Added.
  • platform/gtk/fast/repaint/block-no-inflow-children-expected.txt: Added.
  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-div-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-small-percent-width-expected.txt: Added.
  • platform/gtk/media/video-replaces-poster-expected.txt: Added.
  • platform/gtk/svg/css/shadow-and-opacity-expected.txt: Copied from LayoutTests/platform/mac/svg/css/shadow-and-opacity-expected.txt.
  • platform/gtk/svg/custom/empty-mask-expected.txt: Added.
  • platform/gtk/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt.
  • platform/gtk/svg/custom/marker-opacity-expected.txt: Added.
  • platform/gtk/svg/custom/marker-referencePoint-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/marker-referencePoint-expected.txt.
  • platform/gtk/svg/custom/mask-invalidation-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt.
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-skew-transformed-expected.txt.
  • platform/gtk/svg/custom/relative-sized-content-expected.txt: Added.
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt: Added.
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt: Added.
  • platform/gtk/svg/custom/stroke-width-large-expected.txt: Added.
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
  • platform/gtk/svg/filters/feDisplacementMap-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/feDisplacementMap-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-inner-svg-element-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
  • platform/gtk/svg/text/selection-background-color-expected.txt: Added.
  • platform/gtk/svg/text/selection-doubleclick-expected.txt: Added.
  • platform/gtk/svg/text/selection-styles-expected.txt: Added.
  • platform/gtk/svg/text/selection-tripleclick-expected.txt: Added.
  • platform/gtk/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/gtk/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/gtk/transforms/2d/hindi-rotated-expected.txt: Added.
1:14 PM Changeset in webkit [61430] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-06-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Don't throw away exception information for functions that use exceptions
https://bugs.webkit.org/show_bug.cgi?id=40786

Simple patch to stop JSC from throwing away the exception information
of a function that uses "exceptiony" features like try and throw. This
is a speed up for catching expressions but it's difficult to quantify as
the old cost of reparsing is amortised over all exceptions caught in the
effected function.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::emitCatch):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitThrow):
1:08 PM Changeset in webkit [61429] by andersca@apple.com
  • 5 edits
    3 adds in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PlatformStrategies and PluginStrategy classes.
https://bugs.webkit.org/show_bug.cgi?id=40850

  • wtf/Platform.h:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PlatformStrategies and PluginStrategy classes.
https://bugs.webkit.org/show_bug.cgi?id=40850

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PlatformStrategies.cpp: Added. (WebCore::PlatformStrategies::~PlatformStrategies): (WebCore::platformStrategies): (WebCore::setPlatformStrategies):
  • platform/PlatformStrategies.h: Added. (WebCore::PlatformStrategies::pluginStrategy): (WebCore::PlatformStrategies::PlatformStrategies):
  • plugins/PluginData.cpp:
  • plugins/PluginStrategy.h: Added. (WebCore::PluginStrategy::~PluginStrategy):
1:01 PM Changeset in webkit [61428] by mrobinson@webkit.org
  • 3 edits in trunk/WebCore

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the GTK+ build after r61413 and 61379.

  • bindings/scripts/CodeGeneratorGObject.pm: Produce a g_value_set that uses getterExpressionPrefix instead of the raw getter.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_property): Update expected test results.
12:45 PM Changeset in webkit [61427] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

No review. Fix Tiger and Leopards tests.

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
12:16 PM Changeset in webkit [61426] by leandro@webkit.org
  • 4 edits in trunk

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

  • wtf/CMakeLists.txt: Add MD5.cpp.

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

  • CMakeLists.txt: Add inspector/ScriptBreakpoint.cpp.
12:11 PM Changeset in webkit [61425] by aestes@apple.com
  • 2 edits in trunk/WebCore

Update copyright header.

Rubber-stamped by Sam Weinig.

  • html/HTMLLinkElement.h:
12:03 PM Changeset in webkit [61424] by aestes@apple.com
  • 4 edits
    2 adds in trunk

WebCore: <rdar://problem/8091385> Prevent a crash in WebCore when removing a stylesheet link element in
in a listener to its beforeload event.
https://bugs.webkit.org/show_bug.cgi?id=40742

Reviewed by Dan Bernstein.

Postpone loading of link elements until after they have been inserted into the DOM and
attached. This prevents DOM mutations triggered by beforeload handlers from firing in the
midst of DOM insertion, which can lead to assertion failures and crashes.

Test: fast/dom/beforeload/remove-link-in-beforeload-listener.html

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement): Initialize m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::processCallback): Add a static callback function which calls
HTMLLinkElement::process().
(WebCore::HTMLLinkElement::insertedIntoDocument): Instead of calling process() directly, set
m_shouldProcessAfterAttach to true to indicate that process() should be called after attach().
(WebCore::HTMLLinkElement::removedFromDocument): Set m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::attach): If m_shouldProcessAfterAttach is true, register
HTMLLinkElement::processCallback() as a post-attach callback.

  • html/HTMLLinkElement.h: Add m_shouldProcessAfterAttach.

(WebCore::HTMLLinkElement::canLazyAttach): Override canLazyAttach() to return false to
indicate that a full attach should be performed. This ensures the post-attach callbacks are
fired.

LayoutTests: <rdar://problem/8091385> Test that removing a stylesheet link element in a listener to its
beforeload event does not crash WebCore.
https://bugs.webkit.org/show_bug.cgi?id=40742

Reviewed by Dan Bernstein.

  • fast/dom/beforeload/remove-link-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-link-in-beforeload-listener.html: Added.
11:40 AM Changeset in webkit [61423] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected files after r61418.

  • platform/qt/editing/pasteboard/paste-text-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-014-expected.txt:
11:20 AM WebKit Team edited by luiz@webkit.org
(diff)
11:18 AM Changeset in webkit [61422] by Chris Fleizach
  • 2 edits in trunk/WebCore

Unreviewed. Windows build fix.

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

10:58 AM Changeset in webkit [61421] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

Reviewed by David Kilzer.

WebCore:

Test: platform/mac/accessibility/inherited-presentational-lists.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::node):

LayoutTests:

  • platform/mac/accessibility/inherited-presentational-lists-expected.txt: Added.
  • platform/mac/accessibility/inherited-presentational-lists.html: Added.
10:54 AM Changeset in webkit [61420] by Darin Adler
  • 3 edits in trunk/WebCore

Fix GTK build after reflection change.

  • bindings/scripts/CodeGeneratorGObject.pm: Changed code

that emits setters to convey the correct type of the attribute.
The GObject code generator takes a different approach to attributes
than the others, so it's hacked a bit to make it more like them.
We should find a way to share more code between the different generators.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

Updated to expect correct results.

10:42 AM Changeset in webkit [61419] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-06-18 Yury Semikhatsky <yurys@chromium.org>

Unreviewed: Qt build fix.

  • inspector/InspectorController.cpp:
10:35 AM Changeset in webkit [61418] by justin.garcia@apple.com
  • 21 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=39798
No selection change notification for editing operation that doesn't change the selection's DOM position

Reviewed by Ojan Vafai.

WebCore:

Some editing operations change the selection visually without affecting its position within
the DOM. This was previously known to occur for certain typing commands, but it can also
occur for some Pastes and changes to block style.

  • editing/Editor.cpp:

(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::changeSelectionAfterCommand):

  • editing/Editor.h:

LayoutTests:

block-style-001.html demonstrated the bug, so no new tests have been added.

  • platform/mac/editing/execCommand/format-block-expected.txt:
  • platform/mac/editing/execCommand/outdent-selection-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-005-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-006-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-007-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-014-expected.txt:
  • platform/mac/editing/style/apple-style-editable-mix-expected.txt:
  • platform/mac/editing/style/block-style-001-expected.txt:
  • platform/mac/editing/style/block-style-002-expected.txt:
  • platform/mac/editing/style/block-style-003-expected.txt:
  • platform/mac/editing/style/create-block-for-style-005-expected.txt:
  • platform/mac/editing/style/create-block-for-style-006-expected.txt:
  • platform/mac/editing/style/create-block-for-style-008-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-002-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-003-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-004-expected.txt:
  • platform/mac/editing/style/table-selection-expected.txt:
10:22 AM Changeset in webkit [61417] by atwilson@chromium.org
  • 2 edits in trunk/WebKit/chromium

Roll chromium DEPS 50089:50171
https://bugs.webkit.org/show_bug.cgi?id=40842

Reviewed by Dumitru Daniliuc.

  • DEPS:

Update chromium_rev to r50171 to remove downstream reference to WebFrame::clearName().

10:12 AM Changeset in webkit [61416] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break on Debug build.
https://bugs.webkit.org/show_bug.cgi?id=40810

  • CMakeLists.txt: Add CSSPreloadScanner.cpp
9:59 AM Changeset in webkit [61415] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=40803
TestNetscapePlugin has an incorrect implementation of "property" property

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't pass a static string back, it's going to be released by NPAPI implementation.
9:51 AM Changeset in webkit [61414] by yurys@chromium.org
  • 13 edits
    1 add in trunk/WebCore

2010-06-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: persist breakpoints in inspector settings.
https://bugs.webkit.org/show_bug.cgi?id=14190

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setSessionSettings): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
  • inspector/InspectorController.h:
  • inspector/InspectorValues.cpp: (WebCore::InspectorValue::parseJSON):
  • inspector/InspectorValues.h:
  • inspector/ScriptBreakpoint.cpp: Added. (WebCore::ScriptBreakpoint::sourceBreakpointsFromInspectorObject): (WebCore::ScriptBreakpoint::inspectorObjectFromSourceBreakpoints):
  • inspector/ScriptBreakpoint.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.addBreakpoint): (WebInspector.BreakpointManager.prototype.restoredBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointsForSourceID): (WebInspector.BreakpointManager.prototype.breakpointsForURL): (WebInspector.BreakpointManager.prototype._addBreakpoint):
  • inspector/front-end/inspector.js: (WebInspector.restoredBreakpoint):
9:47 AM Changeset in webkit [61413] by Darin Adler
  • 78 edits in trunk/WebCore

2010-06-18 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Implement additional DOM attribute reflection for bindings
https://bugs.webkit.org/show_bug.cgi?id=39936

  • Added support for [Reflect] for long, unsigned long, and boolean attributes.
  • Fixed code that set attributes like this: <video controls="controls"> to instead set them like this: <video controls>.
  • Added lots more uses of [Reflect].
  • Removed now-unneeded [ConvertFromString].
  • Made [Reflect] imply [ConvertNullToNullString] so we can get rid of most uses of the latter.
  • Made [Reflect] automatically lowercase the name of the reflected content attribute to minimize the need to specify a custom content attribute name.

One thing this patch does *not* do is remove the unneeded functions
in the various DOM classes that are no longer used by the bindings.
We should do that in a followup.

  • bindings/scripts/CodeGenerator.pm: Added new functions so code can be shared across bindings, GetterExpressionPrefix and SetterExpressionPrefix. We can do a lot more refactoring like this in the future.
  • bindings/scripts/CodeGeneratorCPP.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes.
  • bindings/scripts/CodeGeneratorGObject.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes. Fixed a few things in the output so the .cpp file will have more WebKit style. The .h file should be GTK style, but the .cpp file can be the standard WebKit style eventually.
  • bindings/scripts/CodeGeneratorJS.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/CodeGeneratorObjC.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Redid the special cases for ownerDocument and for operator to fit better with the new code paths. Removed unneeded ConvertFromString handling.
  • bindings/scripts/CodeGeneratorV8.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/test/TestObj.idl: Added some test cases for content attribute reflection and for exceptions in string-typed attributes.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.cpp: Updated.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
  • dom/Element.cpp: (WebCore::Element::getIntegralAttribute): Added. (WebCore::Element::setIntegralAttribute): Added. (WebCore::Element::getUnsignedIntegralAttribute): Added. (WebCore::Element::setUnsignedIntegralAttribute): Added.
  • dom/Element.h: Added new attribute get/set functions for bindings.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isURLAttribute): Added. Returns true for srcAttr.
  • html/HTMLMediaElement.h: Added isURLAttribute.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::isURLAttribute): Changed to call HTMLMediaElement::isURLAttribute before checking for posterAttr.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
  • svg/SVGElement.idl: Added more uses of [Reflect]. Got rid of uses of [ConvertNullToNullString] that are now unneeded since [Reflect] now implies that. Changed formatting to be simpler and consistent without all the lining up and multiple lines.
9:39 AM Changeset in webkit [61412] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Remove some unnecessary checks that cause compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=40772

Reviewed by Dimitri Glazkov.

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/npruntime.cpp:
9:11 AM Changeset in webkit [61411] by mnaganov@chromium.org
  • 13 edits in trunk

2010-06-18 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Implement 'takeHeapSnapshot' in InspectorController.

https://bugs.webkit.org/show_bug.cgi?id=40834

  • bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::takeHeapSnapshot):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::takeHeapSnapshot):
  • inspector/InspectorController.h:
  • src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
  • src/js/ProfilerAgent.js: (devtools.ProfilerAgent.prototype.startProfiling):
8:55 AM Changeset in webkit [61410] by mitz@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r61379?): Assertion failure in Element::getURLAttribute() when accessing the src attribute of a script element
https://bugs.webkit.org/show_bug.cgi?id=40831

Reviewed by Anders Carlsson.

WebCore:

Test: fast/dom/HTMLScriptElement/isURLAttribute.html

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::isURLAttribute): Check for the 'src' attribute.

LayoutTests:

  • fast/dom/HTMLScriptElement/isURLAttribute-expected.txt: Added.
  • fast/dom/HTMLScriptElement/isURLAttribute.html: Added.
8:54 AM Changeset in webkit [61409] by Dimitri Glazkov
  • 33 edits
    29 adds
    23 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

New baselines after http://trac.webkit.org/changeset/61393.

8:46 AM Changeset in webkit [61408] by eric@webkit.org
  • 5 edits
    3 deletes in trunk

2010-06-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61405.
http://trac.webkit.org/changeset/61405
https://bugs.webkit.org/show_bug.cgi?id=40838

broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).

  • fast/js/parser-high-byte-character-expected.txt: Removed.
  • fast/js/parser-high-byte-character.html: Removed.
  • fast/js/script-tests/parser-high-byte-character.js: Removed.

2010-06-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61405.
http://trac.webkit.org/changeset/61405
https://bugs.webkit.org/show_bug.cgi?id=40838

broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
8:44 AM Changeset in webkit [61407] by leandro@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
8:40 AM QtWebKitJournal edited by Simon Hausmann
(diff)
8:14 AM Changeset in webkit [61406] by eric@webkit.org
  • 8 edits in trunk

2010-06-18 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
https://bugs.webkit.org/show_bug.cgi?id=40176

  • fast/canvas/webgl/gl-object-get-calls-expected.txt: Test name == 0 cases, and test getVertexAttrib return original WebGLBuffer object.
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.

2010-06-18 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
https://bugs.webkit.org/show_bug.cgi?id=40176

  • html/canvas/WebGLBuffer.cpp: Remove constructor with existing name.
  • html/canvas/WebGLBuffer.h: Ditto.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getVertexAttrib): Use findBuffer instead of creating a new WebGLBuffer. (WebCore::WebGLRenderingContext::findTexture): Deal with name == 0 case and return raw pointer. (WebCore::WebGLRenderingContext::findRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::findBuffer): Find WebGLBuffer object using given name.
  • html/canvas/WebGLRenderingContext.h: Add findBuffer function declaration, change return type to raw pointer.
8:00 AM Changeset in webkit [61405] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

When V8 ScriptData caching was originally submitted it causes crashes
in external scripts with high-byte characters. This new test crashes on
the original code, but now passes.

  • fast/js/parser-high-byte-character-expected.txt: Added.
  • fast/js/parser-high-byte-character.html: Added.
  • fast/js/script-tests/parser-high-byte-character.js: Added. (runTest):

2010-06-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark showed a ~7% improvement when this was
originally submitted (before it had to be rolled back).

Test: fast/js/parser-high-byte-character.html

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
6:35 AM Changeset in webkit [61404] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fix documentation for the declarative module import.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
6:09 AM Changeset in webkit [61403] by krit@webkit.org
  • 9 edits in trunk/LayoutTests

2010-06-18 Dirk Schulze <krit@webkit.org>

Not reviewed. Rebaseline gtk results.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
5:50 AM Changeset in webkit [61402] by antonm@chromium.org
  • 4 edits in trunk

2010-06-18 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Finish migration to new named property query API
https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.
Requires V8 roll.

  • DEPS:

2010-06-18 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Finish migration to new named property query API
https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.

  • config.h:
5:50 AM Changeset in webkit [61401] by Nikolas Zimmermann
  • 6 edits
    3 adds in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline win results.

  • platform/win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • platform/win/svg/custom/broken-internal-references-expected.txt:
  • platform/win/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/win/svg/custom/junk-data-expected.txt: Added.
  • platform/win/svg/custom/missing-xlink-expected.txt: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
5:38 AM Changeset in webkit [61400] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Fix documentation issue on the onAlert handler.
Fix compilation issue with QT_NO_ACTION.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
  • declarative/qdeclarativewebview_p.h:
5:34 AM Changeset in webkit [61399] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline mac-snowleopard results.

  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
5:28 AM Changeset in webkit [61398] by Nikolas Zimmermann
  • 6 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline mac-tiger test results.

  • platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003a-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
5:27 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:27 AM Changeset in webkit [61397] by pfeldman@chromium.org
  • 15 edits in trunk

2010-06-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: bring XHR console records back.

  • adds "Enable XHR Monitor" / "Disable XHR Monitor" actions to the console's context menu
  • make the chosen option persist in the settings.

https://bugs.webkit.org/show_bug.cgi?id=40799

  • English.lproj/localizedStrings.js:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::disableSearchingForNode): (WebCore::InspectorBackend::enableMonitoringXHR): (WebCore::InspectorBackend::disableMonitoringXHR):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setMonitoringXHR): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::ensureSettingsLoaded):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::monitoringXHRWasEnabled): (WebCore::InspectorFrontend::monitoringXHRWasDisabled):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._handleContextMenuEvent): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.enableMonitoringXHR): (.WebInspector.InspectorBackendStub.prototype.disableMonitoringXHR):
  • inspector/front-end/inspector.js: (WebInspector.monitoringXHRWasEnabled): (WebInspector.monitoringXHRWasDisabled):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
5:25 AM Changeset in webkit [61396] by Nikolas Zimmermann
  • 17 edits
    2 adds in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaselined Qt test results.

  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/mask-invalidation-expected.txt:
  • platform/qt/svg/custom/stroke-width-large-expected.txt:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/dom/altGlyph-dom-expected.txt: Added.
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt: Added.
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-doubleclick-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.txt:
  • platform/qt/svg/text/selection-tripleclick-expected.txt:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
5:23 AM Changeset in webkit [61395] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

REGRESSION(r60958) [Qt] qwebpage::inputMethods auto-test fails
https://bugs.webkit.org/show_bug.cgi?id=40830

Reviewed by Antti Koivisto.

When activating a regular input method field, always set or unset the ImhHiddenText
input method hint.

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

4:37 AM Changeset in webkit [61394] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-18 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Merge text_expectations.txt of Chromium tree. Mainly for <progress> and <meter>.
4:18 AM Changeset in webkit [61393] by Nikolas Zimmermann
  • 759 edits
    4 moves
    102 adds in trunk

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Modernize SVG Text code, following the HTML design
https://bugs.webkit.org/show_bug.cgi?id=40663

SVG Text does not support subpixel positioning
https://bugs.webkit.org/show_bug.cgi?id=12172

RenderSVGText can't do partial repaints
https://bugs.webkit.org/show_bug.cgi?id=15386

HTML and SVG need to share more text painting code
https://bugs.webkit.org/show_bug.cgi?id=15644

Rewrite SVG Text rendering, only keeping the layout of the actual characters/chunks as it was.
We're now drawing SVG Text very similar to HTML Text, utilizing the SVGInlineFlowBox/SVGInlineTextBox structure,
instead of painting all text content of a <text> element from the SVGRootInlineBox, as it was the last years.

Rough overview of the changes:

  • Partial repainting support for text selections (startPos/endPos are respected), no more redrawing of the whole <text> content while selecting
  • Subpixel positioning (near pixel-perfect rendering for all W3C tests that contain text, finally!) -> much better textPath results, characters now align as expected, as all rounding hacks are disabled for SVG text runs, and subpixel precision is used while painting
  • No more custom handling of selection, the standard methods offsetFromPosition() / selectionRectForText() are used instead.
  • Selection works as expected on stretched/squeezed text (lengthAdjust="spacingAndGlyphs"), takes 'includePartialGlyphs' into account - just like HTML text
  • Correct text decoration drawing (proper with and positions and rendering-order, underline/overline before text, strike-through afterwards)
  • Proper sizing of all InlineBoxes, starting from the SVGRootInlineBox, down to every single flow & text box -> correct DRT results, no more weird negative offsets of text runs, etc. Looks exactly like the HTML text test results.
  • Rewritten SVGTextContentElement API to take per-character / per-chunk transformations into account.
  • Speeeeeed! Drawing is much faster now.

Add 24 new testcases covering basic selection features and the SVGTextContentElement API. Each test draws a half-opaque red rectangle, calculated using
SVGTextContentElement API to highlight the area that is supposed to be selected. Then eventSender API is utilized to move the mouse to the calculated
start origin, holding it down and moving it to the end position.

A detailed list of tests that show progression, can be found in the corresponding LayoutTests/ChangeLog.
Note that this requires a rebaselining of all SVG tests containing text elements.

Tests: svg/hixie/text/001.xml (moved from svg/hixie/text/001-broken.xml)

svg/text/lengthAdjust-text-metrics.html
svg/text/select-textLength-spacing-squeeze-1.svg
svg/text/select-textLength-spacing-squeeze-2.svg
svg/text/select-textLength-spacing-squeeze-3.svg
svg/text/select-textLength-spacing-squeeze-4.svg
svg/text/select-textLength-spacing-stretch-1.svg
svg/text/select-textLength-spacing-stretch-2.svg
svg/text/select-textLength-spacing-stretch-3.svg
svg/text/select-textLength-spacing-stretch-4.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-3.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-4.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-1.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-3.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-4.svg
svg/text/select-x-list-1.svg
svg/text/select-x-list-2.svg
svg/text/select-x-list-3.svg
svg/text/select-x-list-4.svg
svg/text/select-x-list-with-tspans-1.svg
svg/text/select-x-list-with-tspans-2.svg
svg/text/select-x-list-with-tspans-3.svg
svg/text/select-x-list-with-tspans-4.svg

  • rendering/InlineBox.h: Remove not needed isInlineBox() method. (WebCore::InlineBox::isInlineTextBox): Constify this method. (WebCore::InlineBox::isSVGInlineTextBox): Added, with ENABLE(SVG) guards, just like the existing isSVGRootInlineBox(). (WebCore::InlineBox::isSVGRootInlineBox): Constify this method. (WebCore::InlineBox::calculateBoundaries): Added, with ENABLE(SVG) guards, used to calculate the whole boundaries of a InlineText/FlowBox, only used in SVG text.
  • rendering/InlineFlowBox.h: Devirtualize placeBoxesHorizontally(), SVG no more overrides it.
  • rendering/InlineTextBox.h: Virtualize selectionStartEnd() - SVGInlineTextBox needs to change start/endPositions based on the current text chunk part that it's rendering.

SVGTextChunkLayoutInfo.h contains a detailed documentation what a SVGTextChunk/SVGTextChunkPart is, and why they are necessary.

(WebCore::InlineTextBox::isInlineTextBox): Constify this method.

  • rendering/RenderBlock.h: (WebCore::RenderBlock::forceLayoutInlineChildren): Add helper method, used only by RenderSVGText, to use a simplified layout strategy, which is a big speed win.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Remove all isSVGText() special cases, as this function is not called anymore for SVG text. (WebCore::RenderBlock::layoutInlineChildren): Don't call computeHorizontalPositionsForLine() for SVG text. computePerCharacterLayoutInformation() overrides it anyway.
  • rendering/RenderSVGInline.cpp: Remove custom absoluteRects/absoluteQuads code, all shared with RenderInline now. (WebCore::RenderSVGInline::clippedOverflowRectForRepaint): Added, forward to SVGRenderBase, just like all other non-text SVG renderers do. (WebCore::RenderSVGInline::computeRectForRepaint): Ditto. (WebCore::RenderSVGInline::mapLocalToContainer): Ditto
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGInlineText.cpp: Remove destroy() hack, which called setNeedsLayoutAndPrefWidthsRecalc/repaint on destruction.

As repaint rects work properly now, this hack is no longer necessary, it was only hiding the real problem.

(WebCore::RenderSVGInlineText::styleDidChange): Don't skip RenderText::styleDidChange() anymore, which automatically schedules layout changes for us.
(WebCore::RenderSVGInlineText::localCaretRect): Remove outdated comment, localCaretRect() is not yet needed in SVG text code.

  • rendering/RenderSVGInlineText.h: Remove custom absoluteRects/absoluteQuads/selectionRectForRepaint/positionForPoint/destroy/computeRectForRepaint* code, all shared with RenderText now.
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer): Take x/y translation into account, but do NOT include in localToParentTransform(), as that would affect rendering. (WebCore::RenderSVGText::layout): Use super-simplified layout strategy, removing a lot of uncessary stuff done by RenderBlock, that SVG does not need. (WebCore::RenderSVGText::absoluteRects): Remove dead-code, retreving the RenderSVGRoot* object, not necessary since a longer time. (WebCore::RenderSVGText::absoluteQuads): Ditto. (WebCore::RenderSVGText::paint): Early exit if we're not in PaintPhaseForeground/PaintPhaseSelfOutline. We're not interessted in other phases. (WebCore::RenderSVGText::strokeBoundingBox): Fix stroke width calculation, no need to special case SVGFonts.
  • rendering/RenderSVGText.h: Remove updateFirstLineBlock/updateFirstLetter overrides, the new RenderSVGText::layout() code, doesn't use these methods at all.

We asked RenderBlock to layout before, which was calling updateFirstLetter & co, this is gone now, as it was all not needed.

(WebCore::RenderSVGText::objectBoundingBox): Directly return the frameRect here, inlined for speed.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::verticallyAlignBoxes): Early-exit if we're a SVGRootInlineBox. SVG handles this on its own.
  • rendering/RootInlineBox.h: Devirtualize verticallyAlignBoxes(), SVG no longer overrides it. Remove virtual computePerCharacterLayoutInformation() method, only lives in SVGRootInlineBox now.
  • rendering/SVGCharacterData.h: Remove no longer needed SVGTextDecorationInfo.
  • rendering/SVGCharacterLayoutInfo.cpp: Don't pass a reference to a Vector<SVGChar> to SVGCharacterLayoutInfo, let it create it. (WebCore::SVGCharacterLayoutInfo::SVGCharacterLayoutInfo):
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint): Ask children to paint. (WebCore::SVGInlineFlowBox::calculateBoundaries): Calculate boundaries by uniting all direct children boundaries.
  • rendering/SVGInlineFlowBox.h: Remove placeBoxesHorizontally, which does not get called anymore, and does not need to be overriden.
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::SVGInlineTextBox): Don't use abbrevations for variable names, initialize new member variables. (WebCore::SVGInlineTextBox::measureCharacter): New helper function extracted from buildLayoutInformation, replacing calculateGlyphWidth/Height. (WebCore::SVGInlineTextBox::offsetForPosition): Implement this method by utilizing Font::offsetForPosition(), but respecting the text chunk parts. (WebCore::SVGInlineTextBox::positionForOffset): No change here, still not used. (WebCore::SVGInlineTextBox::selectionRect): Rewritten, utilizing Font::selectionRectForText(), taking text chunk parts into account, and the supplied startPos/endPos. (WebCore::SVGInlineTextBox::paint): Rewritten, to handle paint servers much more elegant, than the old solution. See code for details, too much to explain here. (WebCore::SVGInlineTextBox::acquirePaintingResource): Helper function, used from paint(). (WebCore::SVGInlineTextBox::releasePaintingResource): Ditto. (WebCore::SVGInlineTextBox::prepareGraphicsContextForTextPainting): Ditto. (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting): Ditto. (WebCore::SVGInlineTextBox::constructTextRun): Helper function centralizing the creation of a TextRun object, used to draw/measure SVG text. (WebCore::SVGInlineTextBox::mapStartEndPositionsIntoChunkPartCoordinates): Important helper function, mapping a startPos/endPos from InlineTextBox

coordinate space to the SVGInlineTextBox, respecting the current text chunk part.

(WebCore::SVGInlineTextBox::selectionStartEnd): Call InlineTextBox::selectionStartEnd(), and apply post fixes when m_currentChunkPart is set. (called when painting a selected chunk part)
(WebCore::positionOffsetForDecoration): Refactored from old paintDecoration() code.
(WebCore::thicknessForDecoration): Ditto.
(WebCore::findRenderObjectDefininingTextDecoration): Ditto.
(WebCore::SVGInlineTextBox::paintDecoration): Ditto. (Can not share the code with HTML, as we need floating point precision, and directly call fillRect, instead of drawHighlightForText.)
(WebCore::SVGInlineTextBox::paintDecorationWithStyle): Ditto.
(WebCore::SVGInlineTextBox::paintSelection): New method, painting text selections with floating-point precision.
(WebCore::SVGInlineTextBox::paintText): New method, painting text with floating-point precision, correctly handling selected text, removing the need for special SVG text sub-paint phases.

(GlyphFill/StrokeSelectionPhase, GlyphFill/StrokePhase)

(WebCore::SVGInlineTextBox::buildLayoutInformation): Use new measureCharacter() helper function, renamed some variables, to avoid abbrevations.
(WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Rewritten to use new measureCharacter() helper function.
(WebCore::SVGInlineTextBox::calculateBoundaries): Rewritten to take text chunk parts into account, serves as central method used to layout InlineBoxes (see SVGRootInlineBox.)

  • rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::isSVGInlineTextBox): Added. (WebCore::SVGInlineTextBox::setHeight): Rename variable, to avoid abbrevations. (WebCore::SVGInlineTextBox::chunkTransformation): New helper function, returning the transformation, that gets applied to the complete text chunk, if any. (WebCore::SVGInlineTextBox::setChunkTransformation): New helper function used by SVGRrootInlineBox, to set the chunk transformation, during text chunk part propagation phase. (WebCore::SVGInlineTextBox::addChunkPartInformation): Ditto. (WebCore::SVGInlineTextBox::svgTextChunkParts): Ditto.
  • rendering/SVGRootInlineBox.cpp: Virtually rewritten, to be designed more like HTMLs RootInlineBox, diving into children for painting. (WebCore::SVGRootInlineBox::paint): Ask children to paint, nothing more. No more traversing through the SVGTextChunks, figuring out which part to render, this is done in layout phase now. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Completly redesigned, see SVGTextChunkLayoutInfo.h for a high-level overview. (WebCore::SVGRootInlineBox::buildLayoutInformation): Just small cleanups, nothing changed here. (WebCore::SVGRootInlineBox::layoutChildBoxes): New helper function, extracted from old layoutInlineBoxes(). (WebCore::SVGRootInlineBox::layoutRootBox): Ditto. (WebCore::SVGRootInlineBox::propagateTextChunkPartInformation): Key-concept of the new design, builds "text chunk parts" and propagates that knownledge to all child SVGInlineTextBoxes.
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::isSVGRootInlineBox): Constified method. (WebCore::SVGRootInlineBox::setHeight): Change variable name, to avoid abbrevations.
  • rendering/SVGTextChunkLayoutInfo.cpp: Remove if 0, enable compilation.
  • rendering/SVGTextChunkLayoutInfo.h: Add large comment explaining text chunk parts, the key concept of the new design. Remove SVGTextChunkWalker & friends, no longer used. (WebCore::SVGTextChunkPart::SVGTextChunkPart): (WebCore::SVGTextChunkPart::isValid): (WebCore::SVGTextChunk::SVGTextChunk): (WebCore::SVGTextChunkLayoutInfo::SVGTextChunkLayoutInfo): (WebCore::SVGTextChunkLayoutInfo::textChunks):
  • rendering/SVGTextLayoutUtilities.cpp: (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::cummulatedHeightOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox): Disable rounding hacks, explain parameters with comments, why they have which values.
  • rendering/SVGTextLayoutUtilities.h: Remove SVGTextPaintSubphase and SVGTextPaintInfo.
  • rendering/SVGTextQuery.cpp: Remove if 0, enable compilation.
  • rendering/SVGTextQuery.h: Ditto.
  • svg/SVGStyledElement.cpp: Very important change! Do not treat CSS attributes as recognized attributes, that would lead to setNeedsLayout() calls, reducing performance!

This hack existed, as we were not dealing with text updates correctly, now that RenderSVGInlineText::styleDidChange is fixed, it's no longer necessary.

(WebCore::SVGStyledElement::isKnownAttribute):

  • svg/SVGTextContentElement.cpp: Completely remove the SVGTextContentElement API, that manually traversed all text chunks, instead use the new SVGTextQuery API. (WebCore::SVGTextContentElement::getNumberOfChars): (WebCore::SVGTextContentElement::getComputedTextLength): (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::getStartPositionOfChar): (WebCore::SVGTextContentElement::getEndPositionOfChar): (WebCore::SVGTextContentElement::getExtentOfChar): (WebCore::SVGTextContentElement::getRotationOfChar): (WebCore::SVGTextContentElement::getCharNumAtPosition):
  • svg/SVGTextElement.cpp: Very important change! Do not calls setNeedsLayout() on RenderSVGText, if childrenChanged() has been called.
  • svg/SVGTextElement.h: Completly remove childrenChanged() - no longer necessary, updates work as expected without it now.
3:41 AM Changeset in webkit [61392] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by David Levin.

Fix compilation when filters are disabled. Revision r60689
changed the signature of SVGRenderBase::prepareToRenderSVGContent()
but didn't change the unsused parameters when filters are disabled.
https://bugs.webkit.org/show_bug.cgi?id=40625

No new tests. Compilation fix.

  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
3:28 AM Changeset in webkit [61391] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309

Test that data URLs can access their inline style sheets.

  • http/tests/security/data-url-inline.css-expected.txt: Added.
  • http/tests/security/data-url-inline.css.html: Added.

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309

Instead of using baseURL() to grab the security context we should just
use finalURL directly. When I wrote the original patch that added this
security check, finalURL didn't exist yet.

If finalURL is an empty URL, that means we generated the style sheet
from text that didn't have a URL. It would be slightly safer to store
a bit on CSSStyleSheet indicating whether it came from an inline style
sheet, but I think this check is fairly accurate.

Test: http/tests/security/data-url-inline.css.html

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
3:04 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
2:31 AM Changeset in webkit [61390] by abarth@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180

We don't appear to require a custom binding here. The old function was
wacky in two ways:

1) It required all of its arguments.

2) If the toString of its argument threw, it would catch the exception

and re-throw a different exception.

I've kept the first behavior but changed the second (and documented it
with a test).

Test: websocket/tests/send-throw.html

  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • websockets/WebSocket.idl:

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180

Test what happens when you pass an object to WebSocket.send that throws
when you convert it to a string.

  • websocket/tests/script-tests/send-throw.js: Added. (endTest): (FIRST_MESSAGE_TO_SEND.toString): (ws.onopen): (ws.onclose): (timeOutCallback):
  • websocket/tests/send-throw-expected.txt: Added.
  • websocket/tests/send-throw.html: Added.
2:18 AM Changeset in webkit [61389] by Simon Hausmann
  • 4 edits in trunk

WebKit: [qt] Better check for the declarative plugin inclusion.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • WebKit.pro:

WebKit/qt: [Qt] Change the target path to QtWebKit.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/declarative.pro:
2:16 AM Changeset in webkit [61388] by dumi@chromium.org
  • 25 edits in trunk

Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

WebCore:

  • WebCore.base.exp
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::isAvailable):
(WebCore::AbstractDatabase::setIsAvailable):

  • storage/AbstractDatabase.h:
  • storage/Database.cpp:
  • storage/Database.h:
  • storage/DatabaseSync.cpp:
  • storage/DatabaseSync.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):
(WebCore::WorkerContext::openDatabaseSync):

  • workers/WorkerContext.h:

WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):

WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
(webkit_get_cache_model):

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

WebKit/win:

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

WebKit/wx:

  • WebView.cpp:

(wxWebView::SetDatabasesEnabled):
(wxWebView::AreDatabasesEnabled):

2:01 AM Changeset in webkit [61387] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Try to turn Gtk 32-bit Linux Debug green again.

  • platform/gtk/Skipped:
1:58 AM Changeset in webkit [61386] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Fix the namespace indent for HTML5Lexer. This patch changes
white-space only.

  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::): (WebCore::HTML5Lexer::lineNumber): (WebCore::HTML5Lexer::columnNumber): (WebCore::HTML5Lexer::state): (WebCore::HTML5Lexer::setState): (WebCore::HTML5Lexer::skipLeadingNewLineForListing): (WebCore::HTML5Lexer::InputStreamPreprocessor::InputStreamPreprocessor): (WebCore::HTML5Lexer::InputStreamPreprocessor::nextInputCharacter): (WebCore::HTML5Lexer::InputStreamPreprocessor::peek): (WebCore::HTML5Lexer::InputStreamPreprocessor::advance):
1:28 AM Changeset in webkit [61385] by ukai@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed test breakage fix.

WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340

MessageLoop runs in main thread, so we don't need to use timer in worker thread.
Also, we should not use Timer in worker thread.

  • websockets/ThreadableWebSocketChannelClientWrapper.h:

(WebCore::ThreadableWebSocketChannelClientWrapper::resume):
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):

12:22 AM QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)

Jun 17, 2010:

11:58 PM Changeset in webkit [61384] by eric@webkit.org
  • 75 edits in trunk/WebCore

2010-06-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61379.
http://trac.webkit.org/changeset/61379
https://bugs.webkit.org/show_bug.cgi?id=40813

Broke multiple tests on all platforms (Requested by tkent on
#webkit).

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::attrWithException): (WebDOMTestObj::setAttrWithException): (WebDOMTestObj::attrWithSetterException): (WebDOMTestObj::attrWithGetterException): (WebDOMTestObj::setAttrWithGetterException):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_void_method): (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws): (webkit_dom_test_obj_serialized_value): (webkit_dom_test_obj_method_with_exception): (webkit_dom_test_obj_with_dynamic_frame): (webkit_dom_test_obj_with_dynamic_frame_and_arg): (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad): (webkit_dom_test_obj_with_script_state_void): (webkit_dom_test_obj_with_script_state_obj): (webkit_dom_test_obj_with_script_state_void_exception): (webkit_dom_test_obj_with_script_state_obj_exception): (webkit_dom_test_obj_with_script_execution_context): (webkit_dom_test_obj_method_with_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args): (webkit_dom_test_obj_get_read_only_int_attr): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_int_attr): (webkit_dom_test_obj_set_int_attr): (webkit_dom_test_obj_get_long_long_attr): (webkit_dom_test_obj_set_long_long_attr): (webkit_dom_test_obj_get_unsigned_long_long_attr): (webkit_dom_test_obj_set_unsigned_long_long_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_attr_with_exception): (webkit_dom_test_obj_set_attr_with_exception): (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_get_attr_with_getter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (webkit_dom_test_obj_get_script_string_attr): (webkit_dom_test_obj_get_conditional_attr1): (webkit_dom_test_obj_set_conditional_attr1): (webkit_dom_test_obj_get_conditional_attr2): (webkit_dom_test_obj_set_conditional_attr2): (webkit_dom_test_obj_get_conditional_attr3): (webkit_dom_test_obj_set_conditional_attr3): (webkit_dom_test_obj_get_description): (webkit_dom_test_obj_get_id): (webkit_dom_test_obj_set_id): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjAttrWithException): (WebCore::jsTestObjAttrWithSetterException): (WebCore::jsTestObjAttrWithGetterException): (WebCore::setJSTestObjAttrWithException): (WebCore::setJSTestObjAttrWithGetterException): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::attrWithExceptionAttrGetter): (WebCore::TestObjInternal::attrWithExceptionAttrSetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter): (WebCore::TestObjInternal::overloadedMethodCallback): (WebCore::):
  • dom/Element.cpp:
  • dom/Element.h:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
  • svg/SVGElement.idl:
11:42 PM Changeset in webkit [61383] by rwlbuis@webkit.org
  • 5 edits
    2 adds in trunk

2010-06-17 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dave Hyatt.

CSS3 "Property is declared twice in rule" test fails
https://bugs.webkit.org/show_bug.cgi?id=36282

Filter out duplicate properties in style declaration.

Test: fast/css/duplicate-property-in-rule.html

  • css/CSSMutableStyleDeclaration.cpp: Filter out duplicate properties (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Discard negative padding values
  • css/CSSStyleSelector.cpp: Remove negative padding check (WebCore::CSSStyleSelector::applyProperty):
11:11 PM Changeset in webkit [61382] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-06-17 MORITA Hajime <morrita@google.com>

Unreviewed. Fixed a path of meter-element.html on Skipped list.

  • platform/qt/Skipped:
11:05 PM Changeset in webkit [61381] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Adding a test case to change-version.html + minor clean-ups.
https://bugs.webkit.org/show_bug.cgi?id=40604

Reviewed by Adam Barth.

  • storage/change-version.html:
11:00 PM Changeset in webkit [61380] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Update <meter> tests.
10:57 PM Changeset in webkit [61379] by Darin Adler
  • 75 edits in trunk/WebCore

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Implement additional DOM attribute reflection for bindings
https://bugs.webkit.org/show_bug.cgi?id=39936

  • Added support for [Reflect] for long, unsigned long, and boolean attributes.
  • Fixed code that set attributes like this: <video controls="controls"> to instead set them like this: <video controls>.
  • Added lots more uses of [Reflect].
  • Removed now-unneeded [ConvertFromString].
  • Made [Reflect] imply [ConvertNullToNullString] so we can get rid of most uses of the latter.
  • Made [Reflect] automatically lowercase the name of the reflected content attribute to minimize the need to specify a custom content attribute name.

One thing this patch does *not* do is remove the unneeded functions
in the various DOM classes that are no longer used by the bindings.
We should do that in a followup.

  • bindings/scripts/CodeGenerator.pm: Added new functions so code can be shared across bindings, GetterExpressionPrefix and SetterExpressionPrefix. We can do a lot more refactoring like this in the future.
  • bindings/scripts/CodeGeneratorCPP.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes.
  • bindings/scripts/CodeGeneratorGObject.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes. Fixed a few things in the output so the .cpp file will have more WebKit style. The .h file should be GTK style, but the .cpp file can be the standard WebKit style eventually.
  • bindings/scripts/CodeGeneratorJS.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/CodeGeneratorObjC.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Redid the special cases for ownerDocument and for operator to fit better with the new code paths. Removed unneeded ConvertFromString handling.
  • bindings/scripts/CodeGeneratorV8.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/test/TestObj.idl: Added some test cases for content attribute reflection and for exceptions in string-typed attributes.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.cpp: Updated.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
  • dom/Element.cpp: (WebCore::Element::getIntegralAttribute): Added. (WebCore::Element::setIntegralAttribute): Added. (WebCore::Element::getUnsignedIntegralAttribute): Added. (WebCore::Element::setUnsignedIntegralAttribute): Added.
  • dom/Element.h: Added new attribute get/set functions for bindings.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
  • svg/SVGElement.idl: Added more uses of [Reflect]. Got rid of uses of [ConvertNullToNullString] that are now unneeded since [Reflect] now implies that. Changed formatting to be simpler and consistent without all the lining up and multiple lines.
10:48 PM Changeset in webkit [61378] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-06-17 MORITA Hajime <morrita@google.com>

Unreviewed. Disabled meter-element.html temporally.
We need to rebaseline it.

  • platform/qt/Skipped:
10:35 PM Changeset in webkit [61377] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-06-17 MORITA Hajime <morrita@google.com>

Unreviewd, fixed a build break.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId):
10:13 PM Changeset in webkit [61376] by morrita@google.com
  • 31 edits
    2 copies
    8 adds in trunk

2010-06-15 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<meter> should allow styling for each gauge-level and component
https://bugs.webkit.org/show_bug.cgi?id=40280

  • Updated expectations because both rendering result, render tree structure, html.css was changed.
  • fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html: Added.
  • fast/dom/HTMLMeterElement/meter-styles.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/win/Skipped:

2010-06-16 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<meter> should allow styling for each gauge-level and component
https://bugs.webkit.org/show_bug.cgi?id=40280

  • Introduced following new pseudo classes for <meter> element.
  • -webkit-meter-horizontal-bar
  • -webkit-meter-vertical-bar
  • -webkit-meter-horizontal-optimum-value
  • -webkit-meter-vertical-optimum-value
  • -webkit-meter-horizontal-suboptimal-value
  • -webkit-meter-vertical-suboptimal-value
  • -webkit-meter-horizontal-even-less-good-value
  • -webkit-meter-vertical-even-less-good-value
  • Introduced 2 shadow nodes for RenderMeter to handle CSS styling. one for bar part and another for value part.
  • Removed RenderTheme::paintMeter() implementation because it can be handled by styled painting without RenderTheme.
  • Pulled RenderIndicator up to super class from RenderProgress, then make RenderMeter a subclass of it.
  • Moved shadow related methods from RenderProgress to ShadowBlockElement to share it with RenderMeter.
  • Added rules for html.css for new pseudo classes.

Tests: fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html

fast/dom/HTMLMeterElement/meter-styles.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/html.css: (meter::-webkit-meter-horizontal-bar): (meter::-webkit-meter-vertical-bar): (meter::-webkit-meter-horizontal-optimum-value): (meter::-webkit-meter-horizontal-suboptimal-value): (meter::-webkit-meter-horizontal-even-less-good-value): (meter::-webkit-meter-vertical-optimum-value): (meter::-webkit-meter-vertical-suboptimal-value): (meter::-webkit-meter-vertical-even-less-good-value):
  • rendering/RenderIndicator.cpp: Added. (WebCore::RenderIndicator::RenderIndicator): (WebCore::RenderIndicator::~RenderIndicator): (WebCore::RenderIndicator::layout): (WebCore::RenderIndicator::styleDidChange): (WebCore::RenderIndicator::updateFromElement): (WebCore::RenderIndicator::hasParts): (WebCore::RenderIndicator::requestLayoutForParts):
  • rendering/RenderIndicator.h: Added. (WebCore::RenderIndicator::requiresForcedStyleRecalcPropagation):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::layoutParts): Added. (WebCore::RenderMeter::shouldHaveParts): Added. (WebCore::RenderMeter::valueRatio): Added. (WebCore::RenderMeter::barPartRect): Added. (WebCore::RenderMeter::valuePartRect): Added. (WebCore::RenderMeter::isHorizontal): Added. (WebCore::RenderMeter::valuePseudoId): Added. (WebCore::RenderMeter::barPseudoId): Added. (WebCore::RenderMeter::updatePartsState): Added.
  • rendering/RenderMeter.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::paint): (WebCore::RenderProgress::layoutParts): Added. (WebCore::RenderProgress::shouldHaveParts): Added. (WebCore::RenderProgress::updatePartsState): (WebCore::RenderProgress::valuePartRect):
  • rendering/RenderProgress.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::paintMeter):
  • rendering/RenderTheme.h: (WebCore::RenderTheme::supportsMeter): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::supportsMeter): Added.
  • rendering/ShadowElement.cpp: (WebCore::ShadowBlockElement::layoutAsPart): Added. (WebCore::ShadowBlockElement::updateStyleForPart): Added. (WebCore::ShadowBlockElement::createForPart): Added. (WebCore::ShadowBlockElement::createStyleForPart): Added. (WebCore::ShadowBlockElement::partShouldHaveStyle): Added.
  • rendering/ShadowElement.h:
  • rendering/style/RenderStyleConstants.h: (WebCore::):
9:30 PM Changeset in webkit [61375] by ukai@chromium.org
  • 5 edits
    4 adds in trunk

2010-06-17 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340

Reviewed by Alexey Proskuryakov.

  • websocket/tests/alert-in-event-handler-expected.txt: Added.
  • websocket/tests/alert-in-event-handler.html: Added.
  • websocket/tests/script-tests/alert-in-event-handler.js: Added.
  • websocket/tests/send2_wsh.py: Added.

2010-06-17 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340

Test: websocket/tests/alert-in-event-handler.html

While running an event handler of WebSocket object, it may be suspended
and resumed in various reason. e.g. alert() will suspend/resume
ActiveDOM objects. In chromium, sending IPC message would also
suspend/resume ActiveDOM objects.
If resume process pending buffer in this case, another event might
be fired while running the initial event handler.
Thus, resume should not process pending buffer immediately.
Pending buffer would be processed after the current task has been
finished.

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::resume): Just set one shot timer for resumeTimerFired() if not yet set. (WebCore::WebSocketChannel::resumeTimerFired): Process pending event after resume was called.
  • websockets/WebSocketChannel.h:
9:14 PM Changeset in webkit [61374] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-06-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(HTML5 parser): editing/selection/leave-requested-block.html can fail or crash
https://bugs.webkit.org/show_bug.cgi?id=40764

HTML5ScriptRunner was careful to only call CachedResource::addClient
for cases where the resource was not already loaded. This was to
avoid getting synchronous notifyFinished callbacks from inside
addClient. (The old HTMLDocumentParser also has hacks to work around
addClient's synchronous notifyFinished behavior for already-loaded
resources as well.)

It turns out that CachedResource will mark itself as purgeable if it
has no clients, thus it could have its data cleared (but itself not
deleted) in the case where we yield back to the runloop to wait for
CSS to load before executing the loaded script.

The fix is to act more like the old parser and always call addClient
on every CachedScript we load. But unlike the old parser, we're
careful not to re-enter from addClient -> notifyFinished
using guards in HTML5DocumentParser::watchForLoad.

I do not know how to make a CachedResource purge itself
from a LayoutTest, so this is not currently testable.
If anyone knows how I'm happy to make a test.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::watchForLoad):
    • It is now expected to call watchForLoad with a loaded script.

(WebCore::HTML5DocumentParser::notifyFinished):

  • Now that watchForLoad is called with loaded scripts, notifyFinished may be be called from addClient, thus we may be in the middle of script execution when it's called. It's OK. We pass the call along to HTML5ScriptRunner::executeScriptsWaitingForLoad and it knows how to ignore the call in that case.
  • html/HTML5DocumentParser.h:
    • Document these member variables more.
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::~HTML5ScriptRunner): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::hasScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::watchForLoad):
    • Set the pending script to RegisteringForWatch state before watching and WatchingForLoad after.

(WebCore::HTML5ScriptRunner::stopWatchingForLoad):

  • Set the pending script to NotWatchingForLoad.

(WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad):

  • Assert that callers checked hasScriptsWaitingForLoad()

(WebCore::HTML5ScriptRunner::requestScript):

  • html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::PendingScript::): (WebCore::HTML5ScriptRunner::PendingScript::PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::watchingForLoad):
  • html/HTML5ScriptRunnerHost.h:
    • Document the new expectations of watchForLoad
9:02 PM Changeset in webkit [61373] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Some tests in fast/repaint/ work fine on Mac.
8:40 PM Changeset in webkit [61372] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-06-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Prevent HTML5PreloadScanner from loading resources in <noscript> tags.
https://bugs.webkit.org/show_bug.cgi?id=40779

No new tests. Will create a layout test in a subsequent patch.

  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::adjustedLexerState): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser): (WebCore::HTML5TreeBuilder::isScriptingFlagEnabled):
  • html/HTML5TreeBuilder.h:
7:53 PM Changeset in webkit [61371] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61368.
http://trac.webkit.org/changeset/61368
https://bugs.webkit.org/show_bug.cgi?id=40806

Well, actually, it still fails :( (Requested by abarth on
#webkit).

  • platform/qt/Skipped:
7:48 PM Changeset in webkit [61370] by abarth@webkit.org
  • 7 edits in trunk

2010-06-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5PreloadScanner parses <script> in DataState
https://bugs.webkit.org/show_bug.cgi?id=40804

The ScriptDataState is handled separately from the rest of the lexer
state changes because it's more complicted in the tree builder. The
easiest thing is to just handle it separately in the preloader too.

  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::processToken):

2010-06-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5PreloadScanner parses <script> in DataState
https://bugs.webkit.org/show_bug.cgi?id=40804

Remove the aforementioned hack that was working around this bug. As a
nice side effect, we get test coverage for this bug. :)

  • fast/preloader/image.html:
  • fast/preloader/link.html:
  • fast/preloader/script.html:
  • fast/preloader/style.html:
7:39 PM Changeset in webkit [61369] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation fix.

  • platform/chromium/test_expectations.txt: fast/preloader/*.html

fail because of no dumpResourceResponseMIMETypes(),
stripNullFromTextNodes.html have not failed recently.

7:31 PM Changeset in webkit [61368] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Adam Barth <abarth@webkit.org>

Unreviewed.

I bet this test passes now. :)

  • platform/qt/Skipped:
7:21 PM Changeset in webkit [61367] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-17 Adam Barth <abarth@webkit.org>

Unreviewed.

Skip fast/preloader tests on GTK and Qt because they don't implement
dumpResourceResponseMIMETypes.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
7:01 PM Changeset in webkit [61366] by abarth@webkit.org
  • 10 edits
    16 adds in trunk

2010-06-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add CSS scanning to HTML5PreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=40802

This patch just cribs the CSS preload scanning algorithm from the old
preload scanner. We also invented a way of testing the preload
scanner.

Tests: fast/preloader/image.html

fast/preloader/link.html
fast/preloader/script.html
fast/preloader/style.html

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/CSSPreloadScanner.cpp: Added. (WebCore::isWhitespace): (WebCore::CSSPreloadScanner::CSSPreloadScanner): (WebCore::CSSPreloadScanner::reset): (WebCore::CSSPreloadScanner::scan): (WebCore::CSSPreloadScanner::tokenize): (WebCore::CSSPreloadScanner::emitRule):
  • html/CSSPreloadScanner.h: Added. (WebCore::CSSPreloadScanner::):
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::HTML5PreloadScanner): (WebCore::HTML5PreloadScanner::processToken): (WebCore::HTML5PreloadScanner::scanningBody):
  • html/HTML5PreloadScanner.h:

2010-06-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add CSS scanning to HTML5PreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=40802

Add a testing framework for the preload scanner. These test cover
basic preloader behavior. They have a small hack to work around a bug
in the preload scanner discovered while writing the tests. I'll fix
the bug and remove the hack in a followup patch.

  • fast/preloader/image-expected.txt: Added.
  • fast/preloader/image.html: Added.
  • fast/preloader/link-expected.txt: Added.
  • fast/preloader/link.html: Added.
  • fast/preloader/resources/image1.png: Added.
  • fast/preloader/resources/link1.css: Added.
  • fast/preloader/resources/script1.js: Added.
  • fast/preloader/resources/style1.css: Added.
  • fast/preloader/script-expected.txt: Added.
  • fast/preloader/script.html: Added.
  • fast/preloader/style-expected.txt: Added.
  • fast/preloader/style.html: Added.
6:24 PM Changeset in webkit [61365] by dpranke@chromium.org
  • 2 edits in trunk/WebCore

2010-06-17 Abhishek Arya <inferno@chromium.org>

Reviewed by David Kilzer.

(Landed by Dirk Pranke).

Check for a null frame before setting drag selection.
https://bugs.webkit.org/show_bug.cgi?id=38893
Same Layout test as https://bugs.webkit.org/show_bug.cgi?id=37168.

Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

Note that you need to run the test manually 20-30 times for the crash
to reproduce.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
5:53 PM Changeset in webkit [61364] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Get rid of the the unused imageSize of ImageDecoderQt::internalHandleCurrentImage()
https://bugs.webkit.org/show_bug.cgi?id=40620

Remove an unused variable.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::internalHandleCurrentImage):
5:39 PM Changeset in webkit [61363] by eric@webkit.org
  • 4 edits in trunk

2010-06-17 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] cleanup redundant DEPS value and remove buildbot cleanup code
https://bugs.webkit.org/show_bug.cgi?id=40615

  • DEPS: tools/data_pack was listed twice for linux (harmless, but unnecessary)

2010-06-17 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] cleanup redundant DEPS value and remove buildbot cleanup code
https://bugs.webkit.org/show_bug.cgi?id=40615

  • Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
5:29 PM Changeset in webkit [61362] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix a race condition during startup where we would never send the InitializeConnection message to the server.

Reviewed by Sam Weinig.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):

5:24 PM Changeset in webkit [61361] by eric@webkit.org
  • 5 edits
    1 add in trunk

2010-06-17 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Fisher.

[Chromium API] Implement WebSandboxSupport on OS X and add stubs to allow
OOP loading of fonts.

https://bugs.webkit.org/show_bug.cgi?id=40544

  • platform/chromium/ChromiumBridge.h: Add prototype for loadFont()

2010-06-17 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Fisher.

[Chromium API] Implement WebSandboxSupport on OS X and add stubs to allow
OOP loading of fonts.

https://bugs.webkit.org/show_bug.cgi?id=40544

  • WebKit.gyp: Add mac WebSandboxSupport.h
  • public/mac/WebSandboxSupport.h: Added.
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::loadFont):
5:00 PM Changeset in webkit [61360] by eric@webkit.org
  • 18 edits in trunk/WebCore

2010-06-17 Nicolas Weber <thakis@chromium.org>

Reviewed by Eric Seidel.

Fix various warnings that are reported when building with clang
https://bugs.webkit.org/show_bug.cgi?id=40503

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::labelElementContainer):
  • accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::parentTable):
  • bindings/v8/NPV8Object.cpp: (WebCore::npObjectTypeInfo):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::):
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::):
  • css/CSSStyleSheet.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::getNamedElements):
  • inspector/InspectorValues.cpp: (WebCore::InspectorObject::getObject): (WebCore::InspectorObject::getArray):
  • page/animation/AnimationBase.h:
  • platform/graphics/BitmapImage.h: (WTF::):
  • platform/graphics/mac/FontPlatformData.h:
  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::ellipsisBox):
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::storageArea):
4:39 PM Changeset in webkit [61359] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Kwang Yul Seo <skyul@company100.net>

Reviewed by Pavel Feldman.

Add ENABLE(INSPECTOR) guard for m_sessionSettings
https://bugs.webkit.org/show_bug.cgi?id=40611

Build fix.

  • inspector/InspectorController.h:
4:28 PM Changeset in webkit [61358] by adachan@apple.com
  • 9 edits
    1 copy
    5 deletes in trunk

WebKit2:

Rolling out http://trac.webkit.org/changeset/61297 due to build errors.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Removed.
  • WebProcess/InjectedBundle/InjectedBundlePageClient.cpp: Removed.
  • WebProcess/InjectedBundle/InjectedBundlePageClient.h: Removed.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:

WebKitTools:

Rolling out http://trac.webkit.org/changeset/61297 due to build errors.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
  • MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
4:25 PM Changeset in webkit [61357] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add FIXME to explain HTMLDocumentParser's forceSynchronous bool
https://bugs.webkit.org/show_bug.cgi?id=40609

No functional change, just adding comment.

  • dom/Document.cpp: (WebCore::Document::write):
4:25 PM Changeset in webkit [61356] by Dimitri Glazkov
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, Chromium expectations update.

  • platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.checksum: Added.
  • platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.png: Added.
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.checksum: Changed
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png: Removed.
4:04 PM Changeset in webkit [61355] by senorblanco@chromium.org
  • 394 edits
    3 adds
    36 deletes in trunk/LayoutTests

2010-06-17 Stephen White <senorblanco@chromium.org>

Unreviewed; expectations fix.

This updates the pixel test baselines after r61341, and removes them
from test_expectations.

  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize11-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize19-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Removed.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.png: Removed.
  • platform/chromium-linux/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-linux/fast/events/pointer-events-2-expected.png:
  • platform/chromium-linux/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-linux/fast/forms/input-type-change-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.checksum: Removed.
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-win/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-win/fast/events/pointer-events-2-expected.png:
  • platform/chromium-win/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-win/fast/forms/input-type-change-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-win/fast/replaced/image-sizing-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/misc-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.checksum:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
  • platform/mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug4427-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug6404-expected.png:
  • platform/mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.checksum:
  • platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/mac/fast/backgrounds/size/zero-expected.checksum:
  • platform/mac/fast/backgrounds/size/zero-expected.png:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/mac/fast/canvas/canvas-as-image-expected.checksum:
  • platform/mac/fast/canvas/canvas-as-image-expected.png:
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/mac/fast/forms/input-type-change-expected.checksum:
  • platform/mac/fast/forms/input-type-change-expected.png:
  • platform/mac/fast/replaced/001-expected.checksum:
  • platform/mac/fast/replaced/001-expected.png:
  • platform/mac/fast/replaced/002-expected.checksum:
  • platform/mac/fast/replaced/002-expected.png:
  • platform/mac/fast/replaced/003-expected.checksum:
  • platform/mac/fast/replaced/003-expected.png:
  • platform/mac/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/mac/fast/replaced/image-sizing-expected.checksum:
  • platform/mac/fast/replaced/image-sizing-expected.png:
  • platform/mac/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug11026-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/mac/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4093-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4284-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4523-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4523-expected.png:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/mac/tables/mozilla/bugs/bug86708-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug86708-expected.png:
  • platform/mac/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/mac/tables/mozilla/core/misc-expected.checksum:
  • platform/mac/tables/mozilla/core/misc-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
3:25 PM Changeset in webkit [61354] by Dimitri Glazkov
  • 2 edits
    2 adds in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Added pixel results for Chromium.

  • platform/chromium-win/fast/js/missing-title-end-tag-js-expected.checksum: Added.
  • platform/chromium-win/fast/js/missing-title-end-tag-js-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:19 PM Changeset in webkit [61353] by robert@webkit.org
  • 4 edits in trunk

2010-06-13 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebCore EventHandler needs to take account of onLoad events fired
before layout() complete

https://bugs.webkit.org/show_bug.cgi?id=40102

WebCore 'cheats' by firing onLoad events before the frame's layout
has been performed. This can result in event listeners performing
operations that depend on the document's final layout, such as
scrolling operations.

When scrolling a frameview in eventhandler ensure the layout is complete.

  • platform/qt/Skipped: Unskip editing/input/page-up-down-scrolls.html

2010-06-13 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebCore EventHandler needs to take account of onLoad events
fired before layout() complete

https://bugs.webkit.org/show_bug.cgi?id=40102

WebCore 'cheats' by firing onLoad events before the frame's layout
has been performed. This can result in event listeners performing
operations that depend on the document's final layout, such as
scrolling operations.

When scrolling a frameview in eventhandler ensure the layout is complete.

  • page/EventHandler.cpp: (WebCore::EventHandler::scrollRecursively):
3:06 PM Changeset in webkit [61352] by dumi@chromium.org
  • 6 edits
    4 adds in trunk

Add the error codes defined in the async DB spec to SQLError.idl and SQLError.h.
https://bugs.webkit.org/show_bug.cgi?id=40748

Reviewed by Dimitri Glazkov.

WebCore:

Test: storage/sql-error-codes.html

  • storage/SQLError.h:

(WebCore::SQLError::):

  • storage/SQLError.idl:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):
(WebCore::SQLStatement::setDatabaseDeletedError):
(WebCore::SQLStatement::setVersionMismatchedError):
(WebCore::SQLStatement::setFailureDueToQuota):
(WebCore::SQLStatement::lastExecutionFailedDueToQuota):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::postflightAndCommit):

LayoutTests:

  • platform/chromium/storage/sql-error-codes-expected.txt: Added.
  • storage/sql-error-codes-expected.txt: Added.
  • storage/sql-error-codes.html: Added.
  • storage/sql-error-codes.js: Added.

(finishTest):
(transactionErrorCallback):
(transactionSuccessCallback):
(testTransaction):
(testTransactionThrowsException):
(testTransactionFailureBecauseOfStatementFailure):
(testInvalidStatement):
(testIncorrectNumberOfBindParameters):
(testBindParameterOfWrongType.badString.toString):
(testBindParameterOfWrongType):
(testQuotaExceeded):
(testVersionMismatch.db.transaction):
(testVersionMismatch):
(runTest):

2:41 PM Changeset in webkit [61351] by robert@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-06-17 Robert Hogan <robert@webkit.org>

[Qt] Build fix

Unreviewed.

Remove includes in qdeclarativewebview*.* that rely on an installation
of QtWebKit.

  • declarative/qdeclarativewebview.cpp:
  • declarative/qdeclarativewebview_p.h:
2:32 PM Changeset in webkit [61350] by Dimitri Glazkov
  • 125 edits
    48 adds
    1 delete in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Updating Chromium expectations after http://trac.webkit.org/changeset/61128.

2:15 PM Changeset in webkit [61349] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-06-17 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Fix CRLF ending conversion in StringBlobItem.
https://bugs.webkit.org/show_bug.cgi?id=40736
Also: fix referencing uninitialized member bug and slice length bug
in hybrid blob case.

Tests will be added when we add BlobBuilder jsc bindings.

  • platform/BlobItem.cpp: (WebCore::StringBlobItem::convertToCString): (WebCore::DataRangeBlobItem::DataRangeBlobItem):
1:59 PM Changeset in webkit [61348] by robert@webkit.org
  • 4 edits in trunk

2010-06-17 Robert Hogan <robert@webkit.org>

Unreviewed, rolling out r61346.
http://trac.webkit.org/changeset/61346
https://bugs.webkit.org/show_bug.cgi?id=33333

Broke inspector tests on Qt

  • platform/qt/Skipped:

2010-06-17 Robert Hogan <robert@webkit.org>

Unreviewed, rolling out r61346.
http://trac.webkit.org/changeset/61346
https://bugs.webkit.org/show_bug.cgi?id=33333

Broke inspector tests on Qt

  • Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):
1:44 PM Changeset in webkit [61347] by Dimitri Glazkov
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Removed obsolete Win XP expectations.

  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Removed.
1:39 PM Changeset in webkit [61346] by robert@webkit.org
  • 4 edits in trunk

2010-06-17 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • platform/qt/Skipped:

2010-06-17 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):
1:28 PM Changeset in webkit [61345] by Dimitri Glazkov
  • 5 edits
    2 deletes in trunk

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r61340.
http://trac.webkit.org/changeset/61340
https://bugs.webkit.org/show_bug.cgi?id=36282

Broke several editing tests.

  • fast/css/duplicate-property-in-rule-expected.txt: Removed.
  • fast/css/duplicate-property-in-rule.html: Removed.

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r61340.
http://trac.webkit.org/changeset/61340
https://bugs.webkit.org/show_bug.cgi?id=36282

Broke several editing tests.

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
1:25 PM Changeset in webkit [61344] by Dimitri Glazkov
  • 4 edits
    1 delete in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

More clean up from the HTML5 parser spin-up.

  • platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium/test_expectations.txt:
1:14 PM Changeset in webkit [61343] by jianli@chromium.org
  • 7 edits in trunk

Add optional contentType parameter to Blob.slice per latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=40647

Reviewed by David Levin.

WebCore:

Tested by http/tests/local/resources/send-sliced-dragged-file.html.

  • html/Blob.cpp:

(WebCore::Blob::slice):

  • html/Blob.h:
  • html/Blob.idl:

LayoutTests:

Updated the test for the optional parameter.

  • http/tests/local/resources/send-sliced-dragged-file.js:
  • http/tests/local/send-sliced-dragged-file-expected.txt:
1:02 PM Changeset in webkit [61342] by jesus@webkit.org
  • 12 edits in trunk

Add viewport meta tag support to QtWebKit API layer

[Qt] QtWebKit does not support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=39902

Patch by Jesus Sanchez-Palencia <jesus@webkit.org>, Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-06-01
Reviewed by Simon Hausmann.

WebCore:

Add windowRect() to page client.

  • platform/qt/QWebPageClient.h:

WebKit/qt:

This implements didReceiveViewportArguments in our ChromeClientQt
which is hooked up with QWebPage::viewportChangeRequested().
This signal does not affect the current default behavior.
The documentation of the signal explains how to make use of this new feature.

  • Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):
Store information about whether the page has been laid out or not.

  • Api/qwebpage.cpp:

(QWebPage::viewportChangeRequested):

  • Api/qwebpage_p.h:

Added class QtViewportHintsPrivate.

  • Api/qwebpage.h:

(QWebPage::setPreferredContentsSize):
Improved documentation and now only layout if the page had already
passed layout phase.
Added class QWebPage::ViewportHints.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowRect):
Modified to work as intended by the DOM, for both QWebView
and QGraphicsWebView.
(WebCore::ChromeClientQt::didReceiveViewportArguments):
Emits the signal QWebPage::viewportChangeRequested.

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
Update information about whether the page has been laid out or not.
If the page has been laid out we ignore any further viewport meta data.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):

  • WebCoreSupport/PageClientQt.h:

The PageClient is now responsible for providing the right window rect.

12:50 PM Changeset in webkit [61341] by senorblanco@chromium.org
  • 6 edits in trunk

2010-06-17 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Fix for slow multiple animated resize issue.
https://bugs.webkit.org/show_bug.cgi?id=38233

The timer-based resize quality approach implemented in
http://trac.webkit.org/changeset/34210 is a good idea, but doesn't
scale to multiple images with animated resizes. This fix unifies all
outstanding resize timers into a single timer, and removes the "use
last quality" check (which doesn't work when images are overlapping).
It also refactors the copy of this code implemented in
RenderBoxModelObject in http://trac.webkit.org/changeset/53949.

This improves Safari performance for the following IE9 platform demos on my C2D MacPro (10.5):
http://ie.microsoft.com/testdrive/Performance/01FlyingImages/Default.html (4->60fps)
http://ie.microsoft.com/testdrive/Performance/10FlickrExplorer/Default.html (3->16fps)
http://ie.microsoft.com/testdrive/Performance/11BrowserFlip/Default.html (9->60fps)

  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::ImageQualityController): Unify all timers into a single timer, rename RenderBoxModelScaleObserver to ImageQualityController, and remove the resize quality "stickness", since it doesn't work with multiple outstanding resizes. (WebCore::ImageQualityController::objectDestroyed): gImages global is now m_lastPaintTimeMap member. (WebCore::ImageQualityController::highQualityRepaintTimerFired): Function made non-static; repaint all pending resizes (not just one). (WebCore::ImageQualityController::restartTimer): Added function to restart timer at 1.05x threshold. (WebCore::imageQualityController): Static function to return singleton. (WebCore::ImageQualityController::shouldPaintAtLowQuality): Use m_lastPaintTimeMap, not gImages global. Implement new timer algorithm. Remove resize "stickiness". (WebCore::RenderBoxModelObject::shouldPaintAtLowQuality): Implement shouldPaintAtLowQuality, which pulls out "this" and passes the call to the ImageQualityController. (WebCore::RenderBoxModelObject::~RenderBoxModelObject): Call ImageQualityController singleton's objectDestroyed() instead of old static function. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Modify shouldPaintAtLowQuality() call to match new class name and function signature.
  • rendering/RenderBoxModelObject.h: Expose shouldPaintAtLowQuality as a member function.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::~RenderImage): No need to call objectDestroyed() here anymore, since the RenderBoxModelObject destructor will do this for us. (WebCore::RenderImage::paintIntoRect): Rip out RenderImageScaleObserver, and call RenderBoxModelObject::shouldPaintAtLowQuality() instead.

2010-06-17 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Temporarily modify test_expectations.txt to add tests broken by
https://bugs.webkit.org/show_bug.cgi?id=38233

  • platform/chromium/test_expectations.txt:
12:32 PM Changeset in webkit [61340] by rwlbuis@webkit.org
  • 5 edits
    2 adds in trunk

2010-06-17 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dave Hyatt.

CSS3 "Property is declared twice in rule" test fails
https://bugs.webkit.org/show_bug.cgi?id=36282

Filter out duplicate properties in style declaration.

Test: fast/css/duplicate-property-in-rule.html

  • css/CSSMutableStyleDeclaration.cpp: Filter out duplicate properties (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Discard negative padding values
  • css/CSSStyleSelector.cpp: Remove negative padding check (WebCore::CSSStyleSelector::applyProperty):
11:14 AM Changeset in webkit [61339] by kbr@google.com
  • 16 edits in trunk

2010-06-17 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Clean up error conditions for Typed Arrays
https://bugs.webkit.org/show_bug.cgi?id=40755

  • bindings/js/JSArrayBufferCustom.cpp: (WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):
    • Fixed handling of NaN/+inf/-inf lengths. Throw RangeError for too-large or negative lengths.
  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferView):
    • Changed all error code paths to throw exceptions. Clarified exception types.
  • bindings/js/JSFloat32ArrayCustom.cpp: (WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSInt16ArrayCustom.cpp: (WebCore::JSInt16ArrayConstructor::constructJSInt16Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSInt32ArrayCustom.cpp: (WebCore::JSInt32ArrayConstructor::constructJSInt32Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSInt8ArrayCustom.cpp: (WebCore::JSInt8ArrayConstructor::constructJSInt8Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSUint16ArrayCustom.cpp: (WebCore::JSUint16ArrayConstructor::constructJSUint16Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSUint32ArrayCustom.cpp: (WebCore::JSUint32ArrayConstructor::constructJSUint32Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSUint8ArrayCustom.cpp: (WebCore::JSUint8ArrayConstructor::constructJSUint8Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/v8/custom/V8ArrayBufferCustom.cpp: (WebCore::V8ArrayBuffer::constructorCallback):
    • Fixed handling of NaN/+inf/-inf lengths. Throw RangeError for too-large or negative lengths. Clarified exception types.
  • bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray):
    • Clarified exception types and throwing of exceptions along all error code paths.
  • html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::create):
    • Added necessary null checks during allocation.

2010-06-17 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Clean up error conditions for Typed Arrays
https://bugs.webkit.org/show_bug.cgi?id=40755

  • fast/canvas/webgl/array-unit-tests-expected.txt:
    • Updated test expectations.
  • fast/canvas/webgl/array-unit-tests.html:
    • Added tests for overloaded ArrayBufferView constructors taking null, and improperly aligned offsets. Improved precision of tests causing INDEX_SIZE_ERR to be thrown.
10:46 AM Changeset in webkit [61338] by chang.shu@nokia.com
  • 6 edits
    1 add in trunk

2010-06-17 Shu Chang <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the link error on symbian with ENABLE_JIT=0.

  1. Add "#if ENABLE(JIT)" in the header file;
  2. Put feature enable/disable logic to a common.pri so that both JavaScriptCore.pri and WebCore.pri can share.

https://bugs.webkit.org/show_bug.cgi?id=40780

2010-06-17 Shu Chang <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the link error on symbian with ENABLE_JIT=0.

  1. Add "#if ENABLE(JIT)" in the header file;
  2. Put feature enable/disable logic to a common.pri so that both JavaScriptCore.pri and WebCore.pri can share.

https://bugs.webkit.org/show_bug.cgi?id=40780

  • common.pri: Added.

2010-06-17 Shu Chang <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the link error on symbian with ENABLE_JIT=0.

  1. Add "#if ENABLE(JIT)" in the header file;
  2. Put feature enable/disable logic to a common.pri so that both JavaScriptCore.pri and WebCore.pri can share.

https://bugs.webkit.org/show_bug.cgi?id=40780

  • WebCore.pri:
10:39 AM Changeset in webkit [61337] by kbr@google.com
  • 7 edits
    1 delete in trunk

2010-06-17 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
https://bugs.webkit.org/show_bug.cgi?id=40750

Added V8Proxy::throwTypeError() and throwSyntaxError for parity
with JSC::throwTypeError() and throwSyntaxError. Changed
CodeGeneratorV8.pm to use throwTypeError for overload resolution
failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
instead of manual call to JSValue::encode. Deleted now-unnecessary
Chromium expectations for fast/canvas/webgl/texImageTest.html.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::throwTypeError): (WebCore::V8Proxy::throwSyntaxError):
  • bindings/v8/V8Proxy.h:

2010-06-17 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
https://bugs.webkit.org/show_bug.cgi?id=40750

Added V8Proxy::throwTypeError() and throwSyntaxError for parity
with JSC::throwTypeError() and throwSyntaxError. Changed
CodeGeneratorV8.pm to use throwTypeError for overload resolution
failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
instead of manual call to JSValue::encode. Deleted now-unnecessary
Chromium expectations for fast/canvas/webgl/texImageTest.html.

  • platform/chromium-mac/fast/canvas/webgl/texImageTest-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
10:24 AM Changeset in webkit [61336] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

tables/mozilla/images/adforce_imgis_com.html was removed after r61289. Remove
it from the GTK+ skipped list.

  • platform/gtk/Skipped: Remove a defunct test.
10:23 AM Changeset in webkit [61335] by darin@chromium.org
  • 2 edits in trunk/WebCore

2010-06-17 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

If Page::goToItem is passed a HistoryItem that is the current item,
then the page should be loaded again.

https://bugs.webkit.org/show_bug.cgi?id=40660

  • loader/HistoryController.cpp: (WebCore::HistoryController::recursiveGoToItem): Add a check to recursiveGoToItem that matches the one in FrameLoader::loadItem.
10:06 AM Changeset in webkit [61334] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Build fix for DragDataBrew
https://bugs.webkit.org/show_bug.cgi?id=40610

http://trac.webkit.org/changeset/60957 was not applied to DragDataBrew.cpp.
Add FilenameConversionPolicy argument to DragData::containsURL and DragData::asURL.

  • platform/brew/DragDataBrew.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
9:53 AM Changeset in webkit [61333] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-06-17 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

Rename internalformat to internalFormat
https://bugs.webkit.org/show_bug.cgi?id=40149

  • html/canvas/WebGLFramebuffer.cpp: Rename internalformat to internalFormat. (WebCore::WebGLFramebuffer::getColorBufferFormat):
  • html/canvas/WebGLRenderbuffer.cpp: Ditto. (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
  • html/canvas/WebGLRenderbuffer.h: Ditto. (WebCore::WebGLRenderbuffer::setInternalFormat): (WebCore::WebGLRenderbuffer::getInternalFormat):
  • html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::copyTexImage2D): (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::getRenderbufferParameter): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::texImage2DBase): (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
  • html/canvas/WebGLRenderingContext.h: Ditto.
  • html/canvas/WebGLTexture.cpp: Ditto. (WebCore::WebGLTexture::WebGLTexture):
  • html/canvas/WebGLTexture.h: Ditto. (WebCore::WebGLTexture::setInternalFormat): (WebCore::WebGLTexture::getInternalFormat):
9:39 AM Changeset in webkit [61332] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

Remove input parameter validation for "level" upper limit in *tex* functions
https://bugs.webkit.org/show_bug.cgi?id=40603

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateTexFuncParameters): Don't check for "level" upper limit.
9:26 AM Changeset in webkit [61331] by eric@webkit.org
  • 21 edits
    2 deletes in trunk

2010-06-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

Clean EFL header files in order to diminish the compilation time with
EFL from subversion. We remove the EFL includes from header files and use
forward declarations, including the headers in correspondent source
files when needed. This causes only the needed source files to be
recompiled in case a new version of EFL is installed instead of
triggering a recompilation of almost all WebCore/WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40575

No new functionalities, so no new tests.

  • CMakeListsEfl.txt:
  • platform/PlatformKeyboardEvent.h: forward declaration.
  • platform/PlatformMouseEvent.h: forward declaration and change method signature to not require enum.
  • platform/PlatformWheelEvent.h: forward declaration.
  • platform/Widget.h: forward declaration.
  • platform/efl/PlatformKeyboardEventEfl.cpp: include needed header.
  • platform/efl/PlatformMouseEventEfl.cpp: (WebCore::PlatformMouseEvent::setClickCount): change method signature as mentioned above.
  • platform/efl/PlatformWheelEventEfl.cpp: include needed header.
  • platform/efl/RenderThemeEfl.cpp: include needed header
  • platform/efl/RenderThemeEfl.h: forward declaration.
  • platform/efl/ScrollbarEfl.cpp: include needed header.
  • platform/efl/ScrollbarEfl.h: forward declaration.
  • platform/efl/WidgetEfl.cpp: include needed header.
  • platform/graphics/FloatRect.h: remove unused method.
  • platform/graphics/Icon.h: forward declaration.
  • platform/graphics/IntRect.h: remove unused method.
  • platform/graphics/efl/FloatRectEfl.cpp: Removed. This file was implementing an unused method.
  • platform/graphics/efl/IntRectEfl.cpp: Removed. This file was implementing an unused method.

2010-06-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

Clean EFL header files in order to diminish the compilation time with
EFL from subversion. We remove the EFL includes from header files and use
forward declarations, including the headers in correspondent source
files when needed. This causes only the needed source files to be
recompiled in case a new version of EFL is installed instead of
triggering a recompilation of almost all WebCore/WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40575

  • efl/WebCoreSupport/ChromeClientEfl.cpp: include needed header.
  • efl/WebCoreSupport/ChromeClientEfl.h: forward declaration.
  • efl/WebCoreSupport/EditorClientEfl.h: forward declaration.
9:25 AM Changeset in webkit [61330] by Dimitri Glazkov
  • 3 edits in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, test expectations update.

  • platform/chromium-mac/fast/dom/wrapper-classes-expected.txt:
  • platform/chromium-win/fast/dom/wrapper-classes-expected.txt: Updated results after r61322.
8:51 AM Changeset in webkit [61329] by Darin Adler
  • 2 edits in trunk/WebKitTools

One more try at fix for Chromium build.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell): Use set again instead of =.

8:45 AM Changeset in webkit [61328] by Darin Adler
  • 3 edits in trunk/WebKitTools

Fix Chromium build.

I didn't realize that neither Chromium nor Qt share the DumpRenderTree

code with all the other platforms! Wow, that should be fixed at some point.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell): Changed back to using "new".

  • DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
8:16 AM Changeset in webkit [61327] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

Unreviewed Qt build fix.

LayoutTestController in the Qt DRT is not using refs :)

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):

8:11 AM Changeset in webkit [61326] by Darin Adler
  • 3 edits in trunk/WebCore

2010-06-17 Alex Milowski <alex@milowski.com>

Reviewed by Darin Adler.

Fixed a compile error in the paint() methods by making them use the
new visitedDependentColor() method.
https://bugs.webkit.org/show_bug.cgi?id=40327

  • mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint): (WebCore::RenderMathMLRoot::layout): Fixed a crash where every child was assumed to be a RenderMathMLBlock instance when that isn't the case. Also, layout() needed to mark the index for layout before calling layout() on the index.
  • mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
8:06 AM QtWebKitTiling edited by kenneth@webkit.org
(diff)
8:03 AM Changeset in webkit [61325] by Simon Hausmann
  • 4 edits
    6 adds in trunk

[Qt] Upstream the WebKit QML integration plugin
https://bugs.webkit.org/show_bug.cgi?id=40050

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-17
Reviewed by Kenneth Rohde Christiansen.

.:

Add to the build the QML WebKit integration plugin.

  • WebKit.pro:

WebKit/qt:

Add to the Qt port the QML WebKit integration plugin.
QDeclarativeWebView is creating the item and expose
properties. The C++ API is not public, only the
properties are.

  • declarative/declarative.pro: Added.
  • declarative/plugin.cpp: Added.

(WebKitQmlPlugin::registerTypes):

  • declarative/qdeclarativewebview.cpp: Added.

(QDeclarativeWebViewPrivate::QDeclarativeWebViewPrivate):
(QDeclarativeWebViewPrivate::):
(QDeclarativeWebViewPrivate::windowObjectsAppend):
(GraphicsWebView::GraphicsWebView):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::mouseReleaseEvent):
(GraphicsWebView::mouseDoubleClickEvent):
(GraphicsWebView::timerEvent):
(GraphicsWebView::mouseMoveEvent):
(QDeclarativeWebView::QDeclarativeWebView):
(QDeclarativeWebView::~QDeclarativeWebView):
(QDeclarativeWebView::init):
(QDeclarativeWebView::componentComplete):
(QDeclarativeWebView::status):
(QDeclarativeWebView::progress):
(QDeclarativeWebView::doLoadStarted):
(QDeclarativeWebView::doLoadProgress):
(QDeclarativeWebView::pageUrlChanged):
(QDeclarativeWebView::doLoadFinished):
(QDeclarativeWebView::url):
(QDeclarativeWebView::setUrl):
(QDeclarativeWebView::preferredWidth):
(QDeclarativeWebView::setPreferredWidth):
(QDeclarativeWebView::preferredHeight):
(QDeclarativeWebView::setPreferredHeight):
(QDeclarativeWebView::evaluateJavaScript):
(QDeclarativeWebView::updateDeclarativeWebViewSize):
(QDeclarativeWebView::initialLayout):
(QDeclarativeWebView::updateContentsSize):
(QDeclarativeWebView::geometryChanged):
(QDeclarativeWebView::javaScriptWindowObjects):
(QDeclarativeWebView::qmlAttachedProperties):
(QDeclarativeWebViewPrivate::updateWindowObjects):
(QDeclarativeWebView::renderingEnabled):
(QDeclarativeWebView::setRenderingEnabled):
(QDeclarativeWebView::heuristicZoom):
(QDeclarativeWebView::pressGrabTime):
(QDeclarativeWebView::setPressGrabTime):
(QDeclarativeWebView::backAction):
(QDeclarativeWebView::forwardAction):
(QDeclarativeWebView::reloadAction):
(QDeclarativeWebView::stopAction):
(QDeclarativeWebView::title):
(QDeclarativeWebView::icon):
(QDeclarativeWebView::setStatusText):
(QDeclarativeWebView::windowObjectCleared):
(QDeclarativeWebView::statusText):
(QDeclarativeWebView::page):
(QDeclarativeWebView::settingsObject):
(QDeclarativeWebView::setPage):
(QDeclarativeWebView::load):
(QDeclarativeWebView::html):
(QDeclarativeWebView::setHtml):
(QDeclarativeWebView::setContent):
(QDeclarativeWebView::history):
(QDeclarativeWebView::settings):
(QDeclarativeWebView::createWindow):
(QDeclarativeWebView::newWindowComponent):
(QDeclarativeWebView::setNewWindowComponent):
(QDeclarativeWebView::newWindowParent):
(QDeclarativeWebView::setNewWindowParent):
(QDeclarativeWebView::contentsSize):
(QDeclarativeWebView::contentsScale):
(QDeclarativeWebView::setContentsScale):
(QDeclarativeWebView::elementAreaAt):
(QDeclarativeWebPage::QDeclarativeWebPage):
(QDeclarativeWebPage::~QDeclarativeWebPage):
(QDeclarativeWebPage::chooseFile):
(QDeclarativeWebPage::javaScriptAlert):
(QDeclarativeWebPage::javaScriptConfirm):
(QDeclarativeWebPage::javaScriptPrompt):
(QDeclarativeWebPage::viewItem):
(QDeclarativeWebPage::createWindow):

  • declarative/qdeclarativewebview_p.h: Added.

(QDeclarativeWebView::):
(QDeclarativeWebView::isComponentCompletePublic):
(QDeclarativeWebViewAttached::QDeclarativeWebViewAttached):
(QDeclarativeWebViewAttached::windowObjectName):
(QDeclarativeWebViewAttached::setWindowObjectName):
(QDeclarativeWebSettings::QDeclarativeWebSettings):
(QDeclarativeWebSettings::standardFontFamily):
(QDeclarativeWebSettings::setStandardFontFamily):
(QDeclarativeWebSettings::fixedFontFamily):
(QDeclarativeWebSettings::setFixedFontFamily):
(QDeclarativeWebSettings::serifFontFamily):
(QDeclarativeWebSettings::setSerifFontFamily):
(QDeclarativeWebSettings::sansSerifFontFamily):
(QDeclarativeWebSettings::setSansSerifFontFamily):
(QDeclarativeWebSettings::cursiveFontFamily):
(QDeclarativeWebSettings::setCursiveFontFamily):
(QDeclarativeWebSettings::fantasyFontFamily):
(QDeclarativeWebSettings::setFantasyFontFamily):
(QDeclarativeWebSettings::minimumFontSize):
(QDeclarativeWebSettings::setMinimumFontSize):
(QDeclarativeWebSettings::minimumLogicalFontSize):
(QDeclarativeWebSettings::setMinimumLogicalFontSize):
(QDeclarativeWebSettings::defaultFontSize):
(QDeclarativeWebSettings::setDefaultFontSize):
(QDeclarativeWebSettings::defaultFixedFontSize):
(QDeclarativeWebSettings::setDefaultFixedFontSize):
(QDeclarativeWebSettings::autoLoadImages):
(QDeclarativeWebSettings::setAutoLoadImages):
(QDeclarativeWebSettings::javascriptEnabled):
(QDeclarativeWebSettings::setJavascriptEnabled):
(QDeclarativeWebSettings::javaEnabled):
(QDeclarativeWebSettings::setJavaEnabled):
(QDeclarativeWebSettings::pluginsEnabled):
(QDeclarativeWebSettings::setPluginsEnabled):
(QDeclarativeWebSettings::privateBrowsingEnabled):
(QDeclarativeWebSettings::setPrivateBrowsingEnabled):
(QDeclarativeWebSettings::javascriptCanOpenWindows):
(QDeclarativeWebSettings::setJavascriptCanOpenWindows):
(QDeclarativeWebSettings::javascriptCanAccessClipboard):
(QDeclarativeWebSettings::setJavascriptCanAccessClipboard):
(QDeclarativeWebSettings::developerExtrasEnabled):
(QDeclarativeWebSettings::setDeveloperExtrasEnabled):
(QDeclarativeWebSettings::linksIncludedInFocusChain):
(QDeclarativeWebSettings::setLinksIncludedInFocusChain):
(QDeclarativeWebSettings::zoomTextOnly):
(QDeclarativeWebSettings::setZoomTextOnly):
(QDeclarativeWebSettings::printElementBackgrounds):
(QDeclarativeWebSettings::setPrintElementBackgrounds):
(QDeclarativeWebSettings::offlineStorageDatabaseEnabled):
(QDeclarativeWebSettings::setOfflineStorageDatabaseEnabled):
(QDeclarativeWebSettings::offlineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::setOfflineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::localStorageDatabaseEnabled):
(QDeclarativeWebSettings::setLocalStorageDatabaseEnabled):
(QDeclarativeWebSettings::localContentCanAccessRemoteUrls):
(QDeclarativeWebSettings::setLocalContentCanAccessRemoteUrls):

  • declarative/qmldir: Added.
  • docs/qtwebkit.qdocconf:
8:03 AM QtWebKitTiling edited by kenneth@webkit.org
(diff)
8:00 AM QtWebKitTiling created by kenneth@webkit.org
7:58 AM Changeset in webkit [61324] by Darin Adler
  • 36 edits in trunk

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
https://bugs.webkit.org/show_bug.cgi?id=40760

  • API/JSClassRef.h: Removed unneeded include of RefCounted.h.
  • API/JSWeakObjectMapRefPrivate.cpp: Ditto.
  • bytecode/CodeBlock.h: (JSC::FunctionCodeBlock::FunctionCodeBlock): Use the SharedSymbolTable::create function instead of calling new directly.
  • runtime/SymbolTable.h: Added a create function to the SharedSymbolTable class and made the constructor private.

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
https://bugs.webkit.org/show_bug.cgi?id=40760

  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Made create no longer be an inline function.
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Moved the call to addPluginInstance out of here. (WebKit::NetscapePluginInstanceProxy::create): Move it in here. This makes sure we call adoptRef on the new proxy before any caller calls ref on it.

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
https://bugs.webkit.org/show_bug.cgi?id=40760

This helps prepare for an assertion that fires if you ref or destroy an
object before calling adoptRef on it. That will help us catch mistakes
that can lead to storage leaks.

  • WebCore.base.exp: Updated export now that Frame::create is not an inline function.
  • css/CSSInitialValue.h: (WebCore::CSSInitialValue::createExplicit): Use create. (WebCore::CSSInitialValue::createImplicit): Ditto. (WebCore::CSSInitialValue::create): Added.
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::createUncachedIdentifier): Added. (WebCore::CSSPrimitiveValue::createUncachedColor): Added. (WebCore::CSSPrimitiveValue::createUncached): Added. (WebCore::CSSPrimitiveValue::createIdentifier): Use createUncachedIdentifier instead of using new directly. (WebCore::CSSPrimitiveValue::createColor): Use createUncachedColor instead of using new directly. (WebCore::CSSPrimitiveValue::create): Use createdUncached instead of using new directly.
  • css/CSSPrimitiveValue.h: Declare the new functions above.
  • css/CSSStyleSelector.cpp: (WebCore::loadFullDefaultStyle): Deref simpleDefaultStyleSheet instead of explicitly deleting it.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): Move the call to addSubresourceLoader out of here. (WebCore::SubresourceLoader::create): Move it in here. This makes it so we don't ref the loader before finishing its creation and calling adoptRef.
  • page/Frame.cpp: (WebCore::Frame::Frame): Move the call to setMainFrame out of here. Also refactor the code so an assertion is easier to read. (WebCore::Frame::create): Move the call to setMainFrame in here. This makes it so we don't ref the frame before finishing its creation and calling adoptRef.
  • page/Frame.h: Made the create function non-inline.
  • platform/text/BidiContext.cpp: (WebCore::BidiContext::createUncached): Added. (WebCore::BidiContext::create): Call createUncached instead of callling new directly.
  • platform/text/BidiContext.h: Declare createUncached.
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::buildPrimitives): Use PassRefPtr and RefPtr instead of OwnPtr. And use the create function instead of new.
  • rendering/RenderSVGResourceFilter.h: Ditto.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer): Ditto.
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::StorageAreaImpl): Move the code that calls StorageAreaSync::create out of here. (WebCore::StorageAreaImpl::create): Move it in here. This makes it so we don't ref the storage area before finishing its creation and calling adoptRef.
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::defaultFill): Use create instead of new. (WebCore::SVGPaint::defaultStroke): Ditto.
  • svg/graphics/filters/SVGFilterBuilder.h: Made the constructor private and added a create function since this is a reference counted object and should not be constructed directly.

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
https://bugs.webkit.org/show_bug.cgi?id=40760

  • DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::create): Added.
  • DumpRenderTree/LayoutTestController.h: Declare the create function.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Use create instead of new.
  • DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new.
  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use RefPtr and create instead of OwnPtr and new.
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef instead of new.
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new.
  • DumpRenderTree/wx/DumpRenderTreeWx.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new. (MyApp::OnInit): Removed unneeded code to delete the layout test controller. This is done during each test.
7:47 AM Changeset in webkit [61323] by abecsi@webkit.org
  • 4 edits in trunk

Update CMake build system to use new script for generating source files
with gperf (r61091).
https://bugs.webkit.org/show_bug.cgi?id=40628

Patch by Lucas De Marchi <lucas.demarchi@profusion.mobi> on 2010-06-17
Reviewed by Gustavo Noronha.

  • cmake/WebKitGenerators.cmake:

WebCore: Update CMake build system to use new script for generating source files
with gperf (r61091).
This updates also the build system to cope with recent changes to
source files list.
https://bugs.webkit.org/show_bug.cgi?id=40628

Patch by Lucas De Marchi <lucas.demarchi@profusion.mobi> on 2010-06-17
Reviewed by Gustavo Noronha.

No new tests since it's just compilation fixes.

  • CMakeLists.txt:
7:24 AM Changeset in webkit [61322] by Darin Adler
  • 9 edits
    3 adds in trunk

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Fix boolean reflected attributes to use empty string consistently for the content attribute value
https://bugs.webkit.org/show_bug.cgi?id=40758

Test: fast/dom/boolean-attribute-reflection.html

The HTML5 specification and other browsers are all consistent:
When setting a boolean IDL attribute to true, the attribute value
gets set to the empty string. The guidelines for authors allow either
the empty string or the name of the attribute, but for implementers
of the DOM, the reflected attribute gets empty string.

  • dom/Element.cpp: (WebCore::Element::setBooleanAttribute): Use emptyAtom to set the attribute to the empty string.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::setAutofocus): Use the empty string, not "autofocus". (WebCore::HTMLFormControlElement::setRequired): Use the empty string, not "required".

2010-06-17 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Fix boolean reflected attributes to use empty string consistently for the content attribute value
https://bugs.webkit.org/show_bug.cgi?id=40758

  • fast/dom/boolean-attribute-reflection-expected.txt: Added.
  • fast/dom/boolean-attribute-reflection.html: Added.
  • fast/dom/script-tests/boolean-attribute-reflection.js: Added.
  • fast/dom/wrapper-classes-expected.txt: Regenerated.
  • fast/dom/wrapper-classes.html: Added some classes.
  • media/video-controls-expected.txt: Regenerated.
  • media/video-controls.html: Changed to expect the new correct results. Removed unnecessary use of offsetTop to force layout. This test covers only the DOM and has nothing to do with layout.
  • svg/dom/svgpath-getPathSegAtLength.html: Let the make-script-test-wrappers script regenerate this file.
6:19 AM Changeset in webkit [61321] by pfeldman@chromium.org
  • 4 edits in trunk

2010-06-17 Pavel Feldman <pfeldman@chromium.org>

Unreviewed: chromium tests fix. Added InspectorBackend delegates for new inspector methods.

  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.clearConsoleMessages): (.WebInspector.InspectorBackendStub.prototype.getOuterHTML): (.WebInspector.InspectorBackendStub.prototype.setOuterHTML): (.WebInspector.InspectorBackendStub.prototype.addInspectedNode):

2010-06-17 Pavel Feldman <pfeldman@chromium.org>

Unreviewed: chromium tests fix. Added InspectorBackend delegates for new inspector methods.

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
5:19 AM Changeset in webkit [61320] by mnaganov@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-06-17 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Prepare to making WebDevToolsAgentClient::sendMessageToFrontendOnIOThread virtual

https://bugs.webkit.org/show_bug.cgi?id=39302

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsMessageTransport::~WebDevToolsMessageTransport):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread):
3:23 AM Changeset in webkit [61319] by Simon Hausmann
  • 8 edits in trunk

[Qt] use "win32-g++*" scope to match all MinGW makespecs

Patch by Mark Brand <mabrand@mabrand.nl> on 2010-06-17
Reviewed by Simon Hausmann.

The scope "win32-g++" comes from the name of the makespec. However, it
is frequently used to check for MinGW. This works fine as long as
win32-g++ is the only makespec for MinGW. Now we need the wildcard
to cover "win32-g++-cross" as well.

.:

  • WebKit.pri:

JavaScriptCore:

WebCore:

  • WebCore.pro:

WebKit/qt:

  • Api/DerivedSources.pro:
3:20 AM Changeset in webkit [61318] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Pavel Feldman <pfeldman@chromium.org>

Unreviewed, tests fix.

  • inspector/elements-panel-search.html:
2:43 AM Changeset in webkit [61317] by pfeldman@chromium.org
  • 17 edits in trunk/WebCore

2010-06-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joe Pecoraro.

Web Inspector: move get/setOuterHTML, addInspectedNode and
clearConsole to native InspectorDOMAgent. This is done to allow
inspected nodes array to store nodes from different domains,
also moves outerhtml manipulation closer to the rest of the DOM
operations. In addition to that, we are slowly getting rid of
InjectedScriptAccess in favor of IDL-defined InspectorBackend
interface for clearer remote debugging API.

https://bugs.webkit.org/show_bug.cgi?id=40733

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectedNode):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::changeTagName): (WebCore::InspectorBackend::getOuterHTML): (WebCore::InspectorBackend::setOuterHTML): (WebCore::InspectorBackend::addInspectedNode): (WebCore::InspectorBackend::clearConsoleMessages):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::inspectedNode): (WebCore::InspectorDOMAgent::changeTagName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::addInspectedNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetOuterHTML): (WebCore::InspectorFrontend::didSetOuterHTML):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages):
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted): ():
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/InjectedScriptAccess.js:
2:29 AM Changeset in webkit [61316] by eric@webkit.org
  • 6 edits in trunk

2010-06-17 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

Move the call to the notification presenter that a Notification is being
destroyed from the destructor (not safe) to the ActiveDOMObject::contextDestroyed
method.

Also fix up an incorrect reference loss in the V8 bindings code for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=40097

No new tests; code paths are well-covered by existing tests.

  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback):
  • notifications/Notification.cpp: (WebCore::Notification::~Notification): (WebCore::Notification::contextDestroyed):
  • notifications/Notification.h:

2010-06-17 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

Undo the build fix with the correct patch: Chromium NotificationPresenter
is now informed of the destruction before it actually happens, so this
use of the Notification object is correct.
https://bugs.webkit.org/show_bug.cgi?id=40097

  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::notificationObjectDestroyed):
2:00 AM Changeset in webkit [61315] by Csaba Osztrogonác
  • 4 edits in trunk

Unreviewed rollout r61311, because it made 2 tests fail on Qt bot.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved
https://bugs.webkit.org/show_bug.cgi?id=36702

WebCore:

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):

LayoutTests:

  • platform/qt/Skipped:
1:31 AM Changeset in webkit [61314] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-17 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Fix a bug of Windows pixel tests
https://bugs.webkit.org/show_bug.cgi?id=40763

  • DumpRenderTree/chromium/TestEventPrinter.cpp: (TestShellPrinter::handleImage):
1:23 AM Changeset in webkit [61313] by Nikolas Zimmermann
  • 5 edits in trunk/LayoutTests

2010-06-17 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Land new expected baselines for fill-opacity-(hsl|rgba).png
DRT showed a mysterious error, and the baseline obviously had a problem.

  • platform/mac/svg/custom/fill-opacity-hsl-expected.checksum:
  • platform/mac/svg/custom/fill-opacity-hsl-expected.png:
  • platform/mac/svg/custom/fill-opacity-rgba-expected.checksum:
  • platform/mac/svg/custom/fill-opacity-rgba-expected.png:
12:48 AM Changeset in webkit [61312] by Simon Hausmann
  • 5 edits in trunk

WebCore: Make repaint throttling parameters runtime configurable.
https://bugs.webkit.org/show_bug.cgi?id=38401

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2010-05-28
Reviewed by Simon Hausmann, Antti Koivisto

REPAINT_THROTTLING now chooses default values for throttling parameters.
Should be removed when applications start using runtime configuration.

  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::updateDeferredRepaintDelay):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):
(WebCore::FrameView::setRepaintThrottlingnInitialDeferredRepaintDelayDuringLoading):
(WebCore::FrameView::setRepaintThrottlingMaxDeferredRepaintDelayDuringLoading):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelayIncrementDuringLoading):

  • page/FrameView.h:

WebKit/qt: [Qt] Add internal Qt Api to configure repaint throttling parameters.
https://bugs.webkit.org/show_bug.cgi?id=38401

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2010-05-28
Reviewed by Simon Hausmann, Antti Koivisto

  • Api/qwebpage.cpp:

(QWebPagePrivate::dynamicPropertyChangeEvent):

12:33 AM Changeset in webkit [61311] by eric@webkit.org
  • 4 edits in trunk

2010-06-17 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • platform/qt/Skipped:

2010-06-17 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
12:15 AM Changeset in webkit [61310] by Simon Hausmann
  • 4 edits in trunk/WebCore

[Qt] Avoid unnecessary calls to save() and restore() when drawing images

Reviewed by Kenneth Christiansen.

Avoid calling the expensive save() and restore() on the GraphicsContext just
for changing the composition mode. Instead save and restore it manually
on QPainter.

Change fac227f609e544f8f55aca8447b4328d6534407a in Qt makes sure that the
call to QPainter::setCompositionMode doesn't do anything if the mode hasn't
changed.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::toQtCompositionMode):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

Jun 16, 2010:

11:59 PM Changeset in webkit [61309] by hamaji@chromium.org
  • 15 edits
    1 move
    2 adds
    2 deletes in trunk/LayoutTests

2010-06-16 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Refactor layout tests for printing to use common code.

https://bugs.webkit.org/show_bug.cgi?id=40559

  • printing/numberOfPages-expected.txt:
  • printing/numberOfPages.html:
  • printing/page-break-always-expected.txt:
  • printing/page-break-always-for-overflow-expected.txt:
  • printing/page-break-always-for-overflow.html:
  • printing/page-break-always.html:
  • printing/page-break-inside-avoid-expected.txt: Added.
  • printing/page-break-inside-avoid.html: Added.
  • printing/page-break-inside-expected.txt: Removed.
  • printing/page-break-inside.html: Removed.
  • printing/pageNumerForElementById-expected.txt:
  • printing/pageNumerForElementById.html:
  • printing/resources/paged-media-test-utils.js: (numberOfPagesShouldBe): (ratioToPageHeightToPixels): (createBlockWithRatioToPageHeight): (createBlockWithNumberOfLines):
  • printing/script-tests/TEMPLATE.html:
  • printing/script-tests/numberOfPages.js: (test):
  • printing/script-tests/page-break-always-for-overflow.js: (test):
  • printing/script-tests/page-break-always.js: (test):
  • printing/script-tests/page-break-inside-avoid.js: Added. (test):
  • printing/script-tests/page-break-inside.js: Removed.
  • printing/script-tests/pageNumerForElementById.js: (test):
11:28 PM Changeset in webkit [61308] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-16 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Fix crash on Mac Release
https://bugs.webkit.org/show_bug.cgi?id=40759

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintRect): We should not use m_canvas directly because it is created lazily in canvas().
10:38 PM Changeset in webkit [61307] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] QtWebKit crashes while initializing flash plugin 10.1.53.64.
https://bugs.webkit.org/show_bug.cgi?id=40567

Patch by Dawit Alemayehu <adawit@kde.org> on 2010-06-16
Reviewed by Simon Hausmann.

Avoid preventable crashes by ensuring gtk_init() is called in the
flash viewer plugins before calling NP_Initialize.

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::load):

10:23 PM Changeset in webkit [61306] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-16 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Guarantee that references are held for CachedScripts in HTMLDocumentParser.
https://bugs.webkit.org/show_bug.cgi?id=40177

No new tests because no new functionality.

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::reset): (WebCore::HTMLDocumentParser::executeExternalScriptsIfReady):
10:07 PM Changeset in webkit [61305] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2010-06-16 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Adler.

Improve assertion macro documentation.

https://bugs.webkit.org/show_bug.cgi?id=40565

  • coding/assertion-guidelines.html:
9:29 PM Changeset in webkit [61304] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebKitSite

2010-06-16 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Geoffrey Garen.

Add an index of technical articles to the WebKit site. This makes the
links to the RefPtr and Assertion documentation discoverable and
provides an easy way to find some useful blog posts.

https://bugs.webkit.org/show_bug.cgi?id=40561

  • coding/technical-articles.html: Added.
  • nav.inc: Add link to technical articles.
9:15 PM Changeset in webkit [61303] by eric@webkit.org
  • 4 edits in trunk

2010-06-16 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Repeat pattern should start from origin
https://bugs.webkit.org/show_bug.cgi?id=39225

Remove the following test case from Skipped:
canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html
canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html
canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html

  • platform/qt/Skipped:

2010-06-16 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Repeat pattern should start from origin
https://bugs.webkit.org/show_bug.cgi?id=39225

Patterns must be painted so that the top left of the first image
is anchored at the origin of the coordinate space.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawRepeatPattern): (WebCore::GraphicsContext::fillRect):
9:04 PM Changeset in webkit [61302] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after new method addition.

7:55 PM Changeset in webkit [61301] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Reviewed by Simon Hausmann.

[Qt] WebGL viewport does not show up on N900
https://bugs.webkit.org/show_bug.cgi?id=38528

With OGLES2 add default precision to the shader code.
Use GLsizeiptr and GLintptr with OGLES2.
Call paint() in beginPaint() so that drawTexture() is used
whenever possible.

  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::paint): (WebCore::GraphicsContext3D::shaderSource):
7:18 PM Changeset in webkit [61300] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

This "test" no longer exists. Turns out it was an image resource for
another test.

  • platform/mac/Skipped:
7:05 PM Changeset in webkit [61299] by tkent@chromium.org
  • 4 edits in trunk

2010-06-16 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Set current working directory for each of tests
https://bugs.webkit.org/show_bug.cgi?id=40668

  • DEPS: Update Chromium to r49915 to have webkit_support::SetCurrentDirectoryForFileURL().

2010-06-16 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Set current working directory for each of tests
https://bugs.webkit.org/show_bug.cgi?id=40668

This change fixes tests with eventSender.beginDragWithFiles().

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest):
5:57 PM Changeset in webkit [61298] by tonikitoo@webkit.org
  • 5 edits
    2 adds in trunk

Spatial Navigation: refactor scrollInDirection to work with scrollable content
https://bugs.webkit.org/show_bug.cgi?id=39195

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

scrollInDirection now receives as parameter the node that the Spatial Navigation
found as the more appropriated to move focus to. If it is in a scrollable container
(e.g. <div> with clipped overflow content), it scrolls recursively starting from
the container, not the current focused node.

Test: fast/events/spatial-navigation/snav-only-clipped-overflow-content.html

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

  • page/SpatialNavigation.cpp:

(WebCore::scrollInDirection):

  • page/SpatialNavigation.h:

LayoutTests:

  • fast/events/spatial-navigation/snav-only-clipped-overflow-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-only-clipped-overflow-content.html: Added.
5:51 PM Changeset in webkit [61297] by weinig@apple.com
  • 9 edits
    5 adds
    1 delete in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=40732
WebKit2: Implement didClearWindowForFrame for InjectedBundles

Reviewed by Geoffrey Garen.

WebKit2:

More InjectedBundle work.

  • Add really basic page level APIs for the WebProcess side:
    • Basic client interface with just didClearWindowForFrame (more will be added later)
    • Simple main frame url getter.

These APIs are experimental and are intended to allow me to get a DRT implementation
up and running. They will be changing.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Added.

(WKBundlePageSetClient):
(WKBundlePageGetMainFrameURL):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added.
  • WebProcess/InjectedBundle/InjectedBundlePageClient.cpp: Added.

(WebKit::InjectedBundlePageClient::InjectedBundlePageClient):
(WebKit::InjectedBundlePageClient::initialize):
(WebKit::InjectedBundlePageClient::didClearWindowObjectForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageClient.h: Added.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundleClient):
(WebKit::WebPage::mainFrameURL):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::injectedBundleClient):

  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:

WebKitTools:

  • Stub out use of bundlified didClearWindowForFrame with logging.
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
  • MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.

(_didClearWindow):
(_didCreatePage):
(WKBundleInitialize):

5:27 PM Changeset in webkit [61296] by beidson@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7249553> and https://bugs.webkit.org/show_bug.cgi?id=40749
ResourceLoader::willCacheResponse() needs to null-check Frame::Settings()

Reviewed by Eric Carlson

No new tests. (Discovered via crash reports, no reproducible cases noted)

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willCacheResponse): Null check m_frame->settings(),

but also add an ASSERT so debug-build developers can learn more about why
this might be happening.

4:53 PM Changeset in webkit [61295] by Simon Fraser
  • 6 edits
    2 adds in trunk

2010-06-16 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Allow transitions and animations of clip: rect
https://bugs.webkit.org/show_bug.cgi?id=38130

Make the CSS clip property animatable.

Test: transitions/clip-transition.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc): New blend function for LengthBox (WebCore::AnimationBase::ensurePropertyMap): Create a PropertyWrapper for LengthBoxes.
  • platform/LengthBox.h: (WebCore::LengthBox::LengthBox): New ctor that takes 4 length values.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setClip): New method that takes a LengthBox.
4:39 PM Changeset in webkit [61294] by Darin Adler
  • 2 edits in trunk/WebCore

Try to fix the MathML build.

  • mathml/MathMLMathElement.h: Added missing return type.
4:07 PM Changeset in webkit [61293] by Darin Adler
  • 92 edits in trunk

2010-06-16 Darin Adler <Darin Adler>

Reviewed by David Levin.

Deploy adoptRef in more places, including all HTML and MathML elements
https://bugs.webkit.org/show_bug.cgi?id=39941

  • wtf/ThreadSafeShared.h: Made the constructor protected and removed the unneeded support for initial reference counts other than 1.

2010-06-16 Darin Adler <Darin Adler>

Reviewed by David Levin.

Deploy adoptRef in more places, including all HTML and MathML elements
https://bugs.webkit.org/show_bug.cgi?id=39941

  • dom/Element.cpp: (WebCore::Element::dispatchAttrRemovalEvent): Use create instead of new in commented-out code. (WebCore::Element::dispatchAttrAdditionEvent): Ditto.
  • dom/Node.h: Removed now-unused CreateElementZeroRefCount and CreateHTMLElementZeroRefCount.
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): Use create instead of new, fixing a storage leak.
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel): Removed "WithType" from function name. Use create instead of new, fixing a storage leak. (WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel): Use create instead of new, fixing a storage leak.
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::create): Use adoptRef, fixing a storage leak.
  • editing/ModifySelectionListLevel.h: Added create functions.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement):
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::HTMLMeterElement):
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::HTMLProgressElement): Removed code to explicitly pass CreateHTMLElement construction type since that's now the type used for all HTML elements.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement):
  • html/HTMLFormControlElement.h: Removed construction type argument, since CreateHTMLElement is now the type used for all HTML elements.
  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement): Removed construction type of CreateStyledElementZeroRefCount so we'll use the default construction type, CreateStyledElement. (WebCore::MathMLElement::create): Use adoptRef.
  • mathml/MathMLElement.h: Made isMathMLElement function private and removed unneeded override of createRenderer, because it did the same thing as the base class's createRenderer function.
  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::create): Use adoptRef. (WebCore::MathMLInlineContainerElement::createRenderer): Removed unnecessarily initialization of local variable and removed the case for mathTag, since that uses a different derived class.
  • mathml/MathMLInlineContainerElement.h: Made createRenderrer override private.
  • mathml/MathMLMathElement.cpp: (WebCore::MathMLMathElement::MathMLMathElement): Marked inline since it is called in only one place. (WebCore::MathMLMathElement::create): Use adoptRef. (WebCore::MathMLMathElement::createRenderer): Added. Creates a RenderMathMLMath object.
  • mathml/MathMLMathElement.h: Made constructor private and added a private override of createRenderer.
  • mathml/MathMLTextElement.cpp: (WebCore::MathMLTextElement::MathMLTextElement): Marked inline since it is called in only one place. (WebCore::MathMLTextElement::create): Use adoptRef. (WebCore::MathMLTextElement::createRenderer): Changed to call through to the base class instead of calling RenderObject::createObject directly.
  • mathml/MathMLTextElement.h: Made the constructor and createRenderer function private.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): Removed an unneeded initializer.
  • rendering/RenderProgress.cpp: Tweaked includes.
  • rendering/ShadowElement.cpp: Added a "using namespace" directive.
  • rendering/ShadowElement.h: Tweaked formatting. Made more functions private.
  • editing/DeleteButton.cpp: (WebCore::DeleteButton::create):
  • html/HTMLAudioElement.cpp: (WebCore::HTMLAudioElement::create): (WebCore::HTMLAudioElement::createForJSConstructor):
  • html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::create):
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::create):
  • html/HTMLBaseFontElement.cpp: (WebCore::HTMLBaseFontElement::create):
  • html/HTMLBlockquoteElement.cpp: (WebCore::HTMLBlockquoteElement::create):
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::create):
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::create):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::create):
  • html/HTMLDListElement.cpp: (WebCore::HTMLDListElement::create):
  • html/HTMLDataGridCellElement.cpp: (WebCore::HTMLDataGridCellElement::create):
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::create):
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::create):
  • html/HTMLDataGridRowElement.cpp: (WebCore::HTMLDataGridRowElement::create):
  • html/HTMLDataListElement.cpp: (WebCore::HTMLDataListElement::create):
  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::create):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::create):
  • html/HTMLElement.h: (WebCore::HTMLElement::HTMLElement):
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::create):
  • html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::create):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::create):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::create):
  • html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::create):
  • html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::create):
  • html/HTMLHeadingElement.cpp: (WebCore::HTMLHeadingElement::create):
  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::create):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::create): (WebCore::HTMLImageElement::createForJSConstructor):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::create):
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::create):
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::create):
  • html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::create):
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::create):
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::create):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::create):
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::create):
  • html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::create):
  • html/HTMLMenuElement.cpp: (WebCore::HTMLMenuElement::create):
  • html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::create):
  • html/HTMLModElement.cpp: (WebCore::HTMLModElement::create):
  • html/HTMLNoScriptElement.cpp: (WebCore::HTMLNoScriptElement::create):
  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::create):
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::create):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::create): (WebCore::HTMLOptionElement::createForJSConstructor):
  • html/HTMLParagraphElement.cpp: (WebCore::HTMLParagraphElement::create):
  • html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::create):
  • html/HTMLPreElement.cpp: (WebCore::HTMLPreElement::create):
  • html/HTMLQuoteElement.cpp: (WebCore::HTMLQuoteElement::create):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::create):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::create):
  • html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::create):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::create):
  • html/HTMLTableCaptionElement.cpp: (WebCore::HTMLTableCaptionElement::create):
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::create):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::create):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::create):
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::create):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::create):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::create):
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::create):
  • html/HTMLUListElement.cpp: (WebCore::HTMLUListElement::create):
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::create):
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentElement::create):
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::create): (WebCore::MediaControlElement::create): (WebCore::MediaControlTimelineContainerElement::create): (WebCore::MediaControlVolumeSliderContainerElement::create): (WebCore::MediaControlStatusDisplayElement::create): (WebCore::MediaControlMuteButtonElement::create): (WebCore::MediaControlPlayButtonElement::create): (WebCore::MediaControlSeekButtonElement::create): (WebCore::MediaControlRewindButtonElement::create): (WebCore::MediaControlReturnToRealtimeButtonElement::create): (WebCore::MediaControlToggleClosedCaptionsButtonElement::create): (WebCore::MediaControlTimelineElement::create): (WebCore::MediaControlVolumeSliderElement::create): (WebCore::MediaControlFullscreenButtonElement::create): (WebCore::MediaControlTimeDisplayElement::create):
  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::create):
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::create): (WebCore::TextControlInnerTextElement::create): (WebCore::SearchFieldResultsButtonElement::create): (WebCore::SearchFieldCancelButtonElement::create): (WebCore::SpinButtonElement::create): Use adoptRef.
4:04 PM Changeset in webkit [61292] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-06-16 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations tweak.

  • platform/chromium/test_expectations.txt: Transferred a failure from downstream.
3:58 PM Changeset in webkit [61291] by mrobinson@webkit.org
  • 4 edits in trunk

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] r60803 broke media/controls-drag-timebar.html
https://bugs.webkit.org/show_bug.cgi?id=40269

  • platform/gtk/Skipped: Unskip test which is now passing.

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] r60803 broke media/controls-drag-timebar.html
https://bugs.webkit.org/show_bug.cgi?id=40269

Only queue events while the mouse button is down, if drag mode is enabled. Some
tests may disable drag mode, to prevent the queuing of events in this situation.

  • DumpRenderTree/gtk/EventSender.cpp: (sendOrQueueEvent): Only queue events here if dragMode is true.
3:47 PM Changeset in webkit [61290] by Adam Roben
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove some CVS directories that snuck into Subversion

These were added back when the Mozilla tables tests were imported.

Rubber-stamped by Dan Berstein.

  • tables/mozilla/images/CVS: Removed.
  • tables/mozilla_expected_failures/images/CVS: Removed.
3:38 PM Changeset in webkit [61289] by Adam Roben
  • 1 edit
    15 deletes in trunk/LayoutTests

Delete tables/mozilla/images/adforce_imgis_com.html and its associated results

This file is a GIF that somehow obtained a .html extension. It isn't
referenced by any other test. (It was failing on Windows because the
HTML5 parser turns null bytes into U+FFFD, whose rendering is
font-dependent.)

Fixes <http://webkit.org/b/40741> REGRESSION (r61234):
tables/mozilla/images/adforce_imgis_com.html fails on Windows.

Reviewed by Dave Hyatt.

  • platform/chromium-linux/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
  • platform/mac-leopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
  • platform/mac-leopard/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
  • platform/mac/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
  • platform/mac/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
  • platform/mac/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
  • platform/qt/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
  • tables/mozilla/images/adforce_imgis_com.html: Removed.
3:26 PM Changeset in webkit [61288] by mrobinson@webkit.org
  • 9 edits in trunk

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
https://bugs.webkit.org/show_bug.cgi?id=40600

  • platform/gtk/Skipped: This change exposed some failures which were previously not reported. Skip them.

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
https://bugs.webkit.org/show_bug.cgi?id=40600

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Reset the click count after a drag starts.
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup): Reset the click count after a load is committed.
  • webkit/webkitprivate.h: Move static click counting variables to be per-view.
  • webkit/webkitwebview.cpp: (getEventTime): Added. (webkit_web_view_button_press_event): If the event time is zero, use the current time. (webkit_web_view_finalize): Clean up click counting member. (webkit_web_view_init): Initialize click counting member.

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
https://bugs.webkit.org/show_bug.cgi?id=40600

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
3:13 PM Changeset in webkit [61287] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Add a hidden land-cowboy command to webkit-patch to help land quick
build fixes.

  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
2:57 PM Changeset in webkit [61286] by abarth@webkit.org
  • 15 edits
    2 adds in trunk

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 parser crash when setTimeout document.write after slow script
https://bugs.webkit.org/show_bug.cgi?id=40726

According to the HTML5 spec, we're supposed to open() a new document if
we receive a document.write() after we've received EOF for the network.
The old parser just dumped those bytes onto the end of the network
stream. After this patch, our behavior matches Minefield.

Test: http/tests/misc/write-while-waiting.html

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::write):
  • dom/DocumentParser.h:
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::finishWasCalled):
  • dom/XMLDocumentParser.h:
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::finishWasCalled):
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::InputStream::isClosed):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finishWasCalled):
  • html/HTMLDocumentParser.h:
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finishWasCalled):
  • loader/MediaDocument.cpp: (WebCore::MediaDocumentParser::finishWasCalled):
  • loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::finishWasCalled):
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::finishWasCalled):
  • loader/TextDocument.cpp: (WebCore::TextDocumentParser::finishWasCalled):

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 parser crash when setTimeout document.write after slow script
https://bugs.webkit.org/show_bug.cgi?id=40726

Adds a test for what happens when we receive a document.write() while
we're waiting for an external script to load (and after receiving EOF
from the network).

  • http/tests/misc/write-while-waiting-expected.txt: Added.
  • http/tests/misc/write-while-waiting.html: Added.
2:56 PM Changeset in webkit [61285] by eric@webkit.org
  • 2 edits in trunk/WebKit/mac

2010-06-16 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Enable HTML5 Parser in Safari on Mac
https://bugs.webkit.org/show_bug.cgi?id=40739

The HTML5 parser is probably off on all webkit ports.
We should either flip the meaning of the default so that
"false" means HTML5 on all ports, or we'll have to write
more code like this for all the other ports.

  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):
2:51 PM Changeset in webkit [61284] by Dimitri Glazkov
  • 19 edits
    43 adds
    8 deletes in trunk/LayoutTests

Unreviewed, expectations update.

Updated platform/chromium-* expectations for the tests after HTML5 parser switch.

2:38 PM Changeset in webkit [61283] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt: Removed already passing tests.
2:22 PM WebKit Team edited by mrobinson@webkit.org
(diff)
2:22 PM Changeset in webkit [61282] by Adam Roben
  • 2 edits
    1 add
    12 deletes in trunk/LayoutTests

Convert fast/dom/stripNullFromTextNodes.html to dumpAsText

There's nothing in this test that requires a render tree dump. We have
other tests that test rendering of U+FFFD characters (which was what
was causing the test to fail, since Windows uses a different font for
that character than Mac does).

Fixes <http://webkit.org/b/40738> REGRESSION: (r61234):
fast/dom/stripNullFromTextNodes.html fails on Windows

Reviewed by Dan Bernstein.

  • fast/dom/stripNullFromTextNodes-expected.txt: Added.
  • fast/dom/stripNullFromTextNodes.html: Added a call to

layoutTestController.dumpAsText().

  • platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
  • platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.png: Removed.
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.png: Removed.
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.png: Removed.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
  • platform/mac/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
  • platform/mac/fast/dom/stripNullFromTextNodes-expected.png: Removed.
  • platform/mac/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
  • platform/qt/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
2:18 PM WebKit Team edited by diegohcg@webkit.org
(diff)
2:18 PM Changeset in webkit [61281] by mrobinson@webkit.org
  • 5 edits in trunk/WebCore

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] ClipboardGtk::setURL does not match the behavior of other platforms
https://bugs.webkit.org/show_bug.cgi?id=40640

Instead of writing URL labels to the text portion of the clipboard or
drag-and-drop data, write the URL itself. Also escape the label text
of URLs. Abstracts logic into DataObjectGtk, so ClipboardGtk and
PasteboardGtk can share it.

Tests for this issue will be activated when dropping support has been
added to the GTK+ EventSender.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::writeURL): Use DataObjectGtk::setURL.
  • platform/gtk/DataObjectGtk.cpp: (WebCore::DataObjectGtk::setURL): Added. Write URL to the text portion and remember to escape the label when creating the markup portion.
  • platform/gtk/DataObjectGtk.h: Add declaration of new method.
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeURL): Use DataObjectGtk::setURL.
2:15 PM WebKit Team edited by jesus@webkit.org
(diff)
2:15 PM Changeset in webkit [61280] by abarth@webkit.org
  • 4 edits in trunk

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Hit assertion in WebCore::HTML5Token::appendToSystemIdentifier
https://bugs.webkit.org/show_bug.cgi?id=40729

This was a copy/paste error. Yay for ASSERTs.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Hit assertion in WebCore::HTML5Token::appendToSystemIdentifier
https://bugs.webkit.org/show_bug.cgi?id=40729

Add more test coverage of DOCTYPE parsing states. Turns out you use a
different state if there's no whitespace between the public and system
identifiers.

  • html5lib/resources/doctype01.dat:
2:09 PM WebKit Team edited by diegohcg@webkit.org
(diff)
1:54 PM Changeset in webkit [61279] by Adam Roben
  • 4 edits in trunk/WebKitTools

Convert console messages to UTF-8 before printing them

Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
http/tests/security/xssAuditor/embed-tag-null-char.html and
http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
Windows. (I can't test the fix because Apache is crashing on my
computer.)

Reviewed by Alexey Proskuryakov.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(toUTF8): Extracted the code into an overload that takes a wide string
and a length, then added an overload that takes a wstring.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8

overload.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
UTF-8 instead of letting printf convert to the current code page.

1:28 PM Changeset in webkit [61278] by eric@webkit.org
  • 9 edits in trunk

2010-06-16 Drew Wilson <atwilson@chromium.org>

Reviewed by Kent Tamura.

Added plumbing to Chromium WebKit API to allow setting/getting the name
of top level frames.

https://bugs.webkit.org/show_bug.cgi?id=40430

  • public/WebFrame.h: Added setName() API.
  • public/WebViewClient.h: (WebKit::WebViewClient::createView): Now takes a "name" parameter.
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow): Passes a name parameter.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setName): Allows setting the frame name by calling through to the WebCore API.
  • src/WebFrameImpl.h:

2010-06-16 Drew Wilson <atwilson@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Plumbing for top-level frame names
https://bugs.webkit.org/show_bug.cgi?id=40430

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView): Migrate to new createView() API.
  • DumpRenderTree/chromium/WebViewHost.h: Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
1:08 PM Changeset in webkit [61277] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-16 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Anders Carlsson.

Bring npapi.h more in line with upstream npapi-headers version:

  • Remove obsolete XP_MAC sections.
  • Remove Metrowerks defines.
  • Add OS/2 defines.
  • Add Maemo defines.
  • Add new version of the custom Carbon event definitions.
  • Sync platform define style/details

https://bugs.webkit.org/show_bug.cgi?id=38666

  • bridge/npapi.h:
12:27 PM Changeset in webkit [61276] by diegohcg@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-16 Diego Gonzalez <diegohcg@webkit.org>

[Qt] Scroll wheel event support to graphics based DRT
https://bugs.webkit.org/show_bug.cgi?id=40577

Reviewed by Kenneth Rohde Christiansen.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::continuousMouseScrollBy): (EventSender::createGraphicsSceneWheelEvent):
  • DumpRenderTree/qt/EventSenderQt.h:
12:16 PM Changeset in webkit [61275] by Simon Fraser
  • 4 edits
    4 adds in trunk

2010-06-16 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix clipping via CSS clip: with composited descendants
https://bugs.webkit.org/show_bug.cgi?id=40579

Consult the 'clip' style, as well as overflow, when creating clipping
compositing layers.

Tests: compositing/geometry/clip.html

compositing/overflow/clip-descendents.html

  • rendering/RenderLayerBacking.cpp: (WebCore::clipBox): Utility function that returns the union of the clip and overflow boxes. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Use clipBox() to get the correct clipping rectangle.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer): Look for clip as well as overflow. (WebCore::RenderLayerCompositor::clipsCompositingDescendants): Ditto.
12:11 PM Changeset in webkit [61274] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-06-16 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

REGRESSION: Undocked inspector toolbar is white
https://bugs.webkit.org/show_bug.cgi?id=40644

Make the html element 100% height so that we don't erase the background to white, after r61215.

  • inspector/front-end/inspector.css: (html):
12:10 PM Changeset in webkit [61273] by Adam Roben
  • 2 edits in trunk/WebKitTools

Remove a stray newline from the Windows version of TestNetscapePlugin

Reviewed by Alexey Proskuryakov.

Fixes <http://webkit.org/b/40728>
plugins/geturlnotify-during-document-teardown.html fails on Windows

  • DumpRenderTree/win/TestNetscapePlugin/main.cpp:

(NPP_Destroy): Removed extra newline that the Mac version doesn't
have.

12:02 PM Changeset in webkit [61272] by andersca@apple.com
  • 2 edits in trunk/WebKitExamplePlugins

Fix build.

  • NetscapeCoreAnimationMoviePlugin/main.m:

(NPP_New):
(NPP_WriteReady):
(NPP_Write):
(NPP_HandleEvent):

12:00 PM Changeset in webkit [61271] by bweinstein@apple.com
  • 2 edits in trunk/WebCore

User scripts injected on start are not run on image documents.
https://bugs.webkit.org/show_bug.cgi?id=40722
<rdar://8087394>

Reviewed by Darin Adler.

User scripts that are injected on start are run from FrameLoader::dispatchDocumentElementAvailable,
but this is never called from ImageDocument, so call it when we create a document element for
our image document.

  • loader/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure): Call FrameLoader::dispatchDocumentElementAvailable

after creating our document element.

11:56 AM Changeset in webkit [61270] by Adam Roben
  • 7 edits in trunk

Respect LayoutTestController::isPrinting on Windows

This gets some printing tests closer to passing (like
printing/page-rule-in-media-query.html).

Fixes <http://webkit.org/b/40727>.

Reviewed by Dan Bernstein.

WebKit/win:

Add a "forPrinting" boolean parameter to
IWebFramePrivate::renderTreeAsExternalRepresentation

  • Interfaces/IWebFramePrivate.idl: Renamed the current

renderTreeAsExternalRepresentation to unused1, and added a new version
that takes a boolean "forPrinting" parameter.

  • Interfaces/WebKit.idl: Touched to force a build.
  • WebFrame.cpp:

(WebFrame::renderTreeAsExternalRepresentation): Added a boolean
"forPrinting" parameter, and used it to tell externalRepresentation
what kind of behavior to use.

  • WebFrame.h: Renamed the old renderTreeAsExternalRepresentation and

added the new one.

WebKitTools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dump): Pass LayoutTestController::isPrinting to
IWebFramePrivate::renderTreeAsExternalRepresentation.

11:51 AM Changeset in webkit [61269] by cmarrin@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Now fixing the path to WebGLLayer.*

11:47 AM Changeset in webkit [61268] by cmarrin@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Additional minor fix to path of GraphicsContext3D.mac

11:46 AM Changeset in webkit [61267] by cmarrin@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fixing path to GraphicsContext3D.mac (hopefully)

11:32 AM Changeset in webkit [61266] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-16 Eric Seidel <eric@webkit.org>

Unreviewed. Disabling a test which fails on Tiger for platform-specific decoding reasons.

fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
https://bugs.webkit.org/show_bug.cgi?id=40725

  • platform/mac-tiger/Skipped:
    • Skipping the test until someone with Tiger access can look.
11:17 AM Changeset in webkit [61265] by beidson@apple.com
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Make paths relative to the project root.

Reviewed by NOBODY (Build fix for Mac)

11:05 AM Changeset in webkit [61264] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Add Tiger-specific expectations because U+FFFD is a different length on
Tiger. :(

  • platform/mac-tiger/fast/dom: Added.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.checksum: Added.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.png: Added.
  • platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.txt: Added.
10:33 AM Changeset in webkit [61263] by cmarrin@apple.com
  • 3 edits
    2 moves in trunk/WebCore

2010-06-16 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Carlson.

https://bugs.webkit.org/show_bug.cgi?id=40643


Second of three steps - rename Canvas3DLayer to WebGLLayer

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/mac/Canvas3DLayer.h: Removed.
  • platform/graphics/mac/Canvas3DLayer.mm: Removed.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):
  • platform/graphics/mac/WebGLLayer.h: Copied from WebCore/platform/graphics/mac/Canvas3DLayer.h.
  • platform/graphics/mac/WebGLLayer.mm: Copied from WebCore/platform/graphics/mac/Canvas3DLayer.mm.
10:05 AM Changeset in webkit [61262] by cmarrin@apple.com
  • 2 edits
    1 move in trunk/WebCore

2010-06-16 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=40643


Rename GraphicsContext3DMac.cpp so it can interact with CALayer

  • platform/graphics/mac/GraphicsContext3DMac.cpp: Removed.
  • platform/graphics/mac/GraphicsContext3DMac.mm: Copied from WebCore/platform/graphics/mac/GraphicsContext3DMac.cpp.
  • WebCore.xcodeproj/project.pbxproj
9:12 AM Changeset in webkit [61261] by Adam Roben
  • 3 edits in trunk/LayoutTests

Land new expected Windows results for two failing tests

These test results should have been updated in r61136, but weren't.

Reviewed by Anders Carlsson.

Fixes <http://webkit.org/b/40713> REGRESSION (r61136):
fast/dom/prototype-inheritance-2.html and
fast/js/global-constructors.html are failing on Windows.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:

Updated with the actual results from the bots.

9:04 AM Changeset in webkit [61260] by mrobinson@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

Add baselines for tests that should be passing consistently now.

  • platform/gtk/Skipped: Unskip tests. They should pass consistently.
  • platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Added.
  • platform/gtk/svg/text/foreignObject-repaint-expected.txt: Added.
8:58 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
8:53 AM Changeset in webkit [61259] by bulach@chromium.org
  • 44 edits
    5 deletes in trunk/LayoutTests

2010-06-16 Marcus Bulach <bulach@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Rebaseline tests following r61240
https://bugs.webkit.org/show_bug.cgi?id=40711

Following r61240 (new HTML5 lexer), we need to rebaseline a few tests.

  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.checksum:
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt:
  • platform/chromium-mac/fast/parser/script-tag-with-trailing-slash-expected.txt: Removed.
  • platform/chromium-mac/fast/tokenizer/script_extra_close-expected.txt:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-win/fast/doctypes/003-expected.checksum:
  • platform/chromium-win/fast/doctypes/003-expected.png:
  • platform/chromium-win/fast/doctypes/003-expected.txt:
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.checksum:
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.png:
  • platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.txt:
  • platform/chromium-win/fast/invalid/016-expected.checksum:
  • platform/chromium-win/fast/invalid/016-expected.png:
  • platform/chromium-win/fast/invalid/016-expected.txt:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.checksum:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.png:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.txt: Removed.
  • platform/chromium-win/fast/parser/comment-in-style-expected.checksum:
  • platform/chromium-win/fast/parser/comment-in-style-expected.png:
  • platform/chromium-win/fast/parser/comment-in-style-expected.txt:
  • platform/chromium-win/fast/parser/parseCommentsInTitles-expected.checksum:
  • platform/chromium-win/fast/parser/parseCommentsInTitles-expected.png:
  • platform/chromium-win/fast/parser/parseCommentsInTitles-expected.txt:
  • platform/chromium-win/fast/parser/script-tag-with-trailing-slash-expected.txt: Removed.
  • platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.checksum:
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.png:
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt:
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.checksum:
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.png:
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.txt: Removed.
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.checksum:
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.png:
  • platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.txt: Removed.
  • platform/chromium-win/fast/tokenizer/script_extra_close-expected.txt:
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.checksum:
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.png:
  • platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.txt:
8:45 AM Changeset in webkit [61258] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-16 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

Unskip passing test.

  • platform/gtk/Skipped: Unskip this test which appears to be passing now.
8:32 AM Changeset in webkit [61257] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Skip this test because I keep screwing up the expectations for this
test. I'll get it cleared up by the end of the day.

  • platform/mac/Skipped:
8:15 AM Changeset in webkit [61256] by Adam Roben
  • 8 edits in trunk/LayoutTests

Land new expected Windows results for tests that use <video controls>

The current expected results expect a fullscreen button to be included
in the controls. But the fullscreen button is only included when
accelerated compositing is enabled, and the bots build without
accelerated compositing enabled.

Rubber-stamped by Dan Bernstein.

Fixes <http://webkit.org/b/40710> Tests that use <video controls> are
failing on Windows.

  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-drag-timebar-expected.txt:
  • platform/win/media/controls-strict-expected.txt:
  • platform/win/media/controls-styling-expected.txt:
  • platform/win/media/video-controls-rendering-expected.txt:
  • platform/win/media/video-display-toggle-expected.txt:
  • platform/win/media/video-no-audio-expected.txt:

Updated with the actual results from the bots.

8:10 AM Changeset in webkit [61255] by Nikolas Zimmermann
  • 9 edits
    3 adds in trunk/WebCore

2010-06-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add new files, needed in SVG Text rewrite
https://bugs.webkit.org/show_bug.cgi?id=40676

Land SVGTextChunkLayoutInfo.cpp and SVGTextQuery.(cpp|h), both with an "#if 0" on top, as they will be needed
in a later patch, completing the SVG Text rewrite, that will enable them.

Doesn't affect any code for now, it should just reduce the review amount.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/SVGTextChunkLayoutInfo.cpp: Added. (WebCore::cummulatedWidthOrHeightOfTextChunk): (WebCore::cummulatedWidthOfTextChunk): (WebCore::cummulatedHeightOfTextChunk): (WebCore::calculateTextAnchorShiftForTextChunk): (WebCore::applyTextAnchorToTextChunk): (WebCore::calculateTextLengthCorrectionForTextChunk): (WebCore::applyTextLengthCorrectionToTextChunk): (WebCore::SVGTextChunkLayoutInfo::startTextChunk): (WebCore::SVGTextChunkLayoutInfo::closeTextChunk): (WebCore::SVGTextChunkLayoutInfo::buildTextChunks): (WebCore::SVGTextChunkLayoutInfo::recursiveBuildTextChunks): (WebCore::SVGTextChunkLayoutInfo::layoutTextChunks):
  • rendering/SVGTextChunkLayoutInfo.h: Add missing include, otherwhise compiling SVGTextChunkLayoutInfo.cpp will fail.
  • rendering/SVGTextQuery.cpp: Added. (WebCore::SVGTextQuery::Data::Data): (WebCore::flowBoxForRenderer): (WebCore::mapLengthThroughChunkTransformation): (WebCore::SVGTextQuery::SVGTextQuery): (WebCore::SVGTextQuery::collectTextBoxesInFlowBox): (WebCore::SVGTextQuery::executeQuery): (WebCore::SVGTextQuery::mapStartAndLengthIntoChunkPartCoordinates): (WebCore::SVGTextQuery::measureCharacterRange): (WebCore::NumberOfCharactersData::NumberOfCharactersData): (WebCore::SVGTextQuery::numberOfCharactersCallback): (WebCore::SVGTextQuery::numberOfCharacters): (WebCore::TextLengthData::TextLengthData): (WebCore::SVGTextQuery::textLengthCallback): (WebCore::SVGTextQuery::textLength): (WebCore::SubStringLengthData::SubStringLengthData): (WebCore::SVGTextQuery::subStringLengthCallback): (WebCore::SVGTextQuery::subStringLength): (WebCore::StartPositionOfCharacterData::StartPositionOfCharacterData): (WebCore::SVGTextQuery::startPositionOfCharacterCallback): (WebCore::SVGTextQuery::startPositionOfCharacter): (WebCore::EndPositionOfCharacterData::EndPositionOfCharacterData): (WebCore::SVGTextQuery::endPositionOfCharacterCallback): (WebCore::SVGTextQuery::endPositionOfCharacter): (WebCore::RotationOfCharacterData::RotationOfCharacterData): (WebCore::SVGTextQuery::rotationOfCharacterCallback): (WebCore::SVGTextQuery::rotationOfCharacter): (WebCore::ExtentOfCharacterData::ExtentOfCharacterData): (WebCore::SVGTextQuery::extentOfCharacterCallback): (WebCore::SVGTextQuery::extentOfCharacter): (WebCore::CharacterNumberAtPositionData::CharacterNumberAtPositionData): (WebCore::SVGTextQuery::characterNumberAtPositionCallback): (WebCore::SVGTextQuery::characterNumberAtPosition):
  • rendering/SVGTextQuery.h: Added.
8:09 AM Changeset in webkit [61254] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fix tiled backing store painting when calling QGraphicsWebView::setPage() after setResizesToContents(true)

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-16
Reviewed by Simon Hausmann.

When calling setPage() after setResizesToContents, the value of the property wasn't propagated
to the page client. Therefore the visible rect for the tiled backing store was incorrect.

Simply move the variable assignment into updateResizesToContentsForPage(), which is always called.

  • Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::updateResizesToContentsForPage):
(QGraphicsWebView::setResizesToContents):

6:51 AM Changeset in webkit [61253] by Nikolas Zimmermann
  • 19 edits in trunk/WebCore

2010-06-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Provide floating-point support for text selection framework
https://bugs.webkit.org/show_bug.cgi?id=40665

This is the first chunk of the SVG Text rewrite patches.
offsetForPosition() / selectionRectForText() should accept float/FloatPoint arguments instead
of int/IntPoint. offsetForPosition() already worked with floats internally in Qt and Mac.
selectionRectForText() was already returning a FloatRect, but the passed in origin was an integer.
Fixing these problems in order to support sub-pixel positioning in the upcoming SVG Text rewrite patch.

Add a glyphScale parameter to TextRun, that will be used to support text selection
in lengthAdjust/textLength scenarios in SVG text, soon.

Doesn't affect any testcases so far. HTML is not affected in any way,
as it only ever passes integers to these functions.

  • platform/graphics/Font.cpp: (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition):
  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPositionForSimpleText):
  • platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::glyphScale): (WebCore::TextRun::setGlyphScale): (WebCore::TextRun::applyGlyphScaling):
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance):
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/efl/FontEfl.cpp: (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/haiku/FontHaiku.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition):
  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/FontComplexTextMac.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::offsetForPositionForSimpleText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/win/FontWin.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/wince/FontWince.cpp: (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/wx/FontWx.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • svg/SVGFont.cpp: (WebCore::Font::selectionRectForTextUsingSVGFont): (WebCore::Font::offsetForPositionForTextUsingSVGFont):
5:42 AM Changeset in webkit [61252] by antonm@chromium.org
  • 4 edits in trunk/WebCore

2010-06-16 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Introduce single element caches for WebCore::String to v8::String conversions
https://bugs.webkit.org/show_bug.cgi?id=40435
Measurements show that for some web apps (GMail, Wave) and some scenarios
(intensive reading and/or keeping a tab open for a long time),
hit rate lies in 30--50% interval.
Inlining fast case gives another minor performance win.

  • bindings/v8/V8Binding.cpp: (WebCore::getStringCache): (WebCore::v8ExternalStringSlow):
  • bindings/v8/V8Binding.h: (WebCore::v8ExternalString):
4:47 AM Changeset in webkit [61251] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Swap WebGL and SiteSpecificQuirks attributes in the QWebSettings
enum, to allow for binary compatibility with qtwebkit-2.0, where
WebGL is not in the settings but SiteSpecificQuirks will be.

Rubber-stamped by Tor Arne Vestbø.

  • Api/qwebsettings.h:
4:46 AM Changeset in webkit [61250] by tonikitoo@webkit.org
  • 3 edits
    2 adds in trunk

2010-05-20 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

Spatial Navigation: using offset{Left,Top} is not enough to get the proper inner frames position
https://bugs.webkit.org/show_bug.cgi?id=39439

As pointed out by Darin Adler in https://bugs.webkit.org/show_bug.cgi?id=18662#c20,
"It's not correct to use the offsetLeft and offsetTop of the frame owner element's renderer because
that's just the distance from the offsetParent, not the absolute position".

Patch fixes that behavior by now considering the offsetTop and offsetLeft the offsetParent recursively,
starting from the HtmlFrameOwnerElement. Previously, only calling offsetTop and offsetLeft works
because all tests were done in html samples where the {i}frame element was a directly a child of the body,
e.g. <html>...<body><iframe src=xxx>....<body></html>.

WebCore:
Test: fast/events/spatial-navigation/snav-iframe-recursive-offset-parent.html

  • page/SpatialNavigation.cpp: (WebCore::renderRectRelativeToRootDocument):

LayoutTests:

  • fast/events/spatial-navigation/snav-iframe-recursive-offset-parent-expected.txt: Added.
  • fast/events/spatial-navigation/snav-iframe-recursive-offset-parent.html: Added.
2:26 AM Changeset in webkit [61249] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix the Tiger build

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformBoundsForGlyph):

2:23 AM Changeset in webkit [61248] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-16 Eric Seidel <eric@webkit.org>

Unreviewed. Disabling a test which fails on Gtk for unexplained
reasons which are specific to the Gtk port.

Gtk pumps the HTML5Lexer an extra time, causing inspector/timeline-script-tag-1.html to fail
https://bugs.webkit.org/show_bug.cgi?id=40664

  • platform/qt/Skipped:
    • Skip the test until a Gtk person can take a look.
2:15 AM Changeset in webkit [61247] by mitz@apple.com
  • 2 edits in trunk/WebCore

Try to fix the Tiger build

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformBoundsForGlyph):

2:12 AM Changeset in webkit [61246] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-16 Eric Seidel <eric@webkit.org>

Unreviewed. Disabling a test which due to a Qt decoding bug
is now failing with the HTML5 lexer.

fast/encoding/japanese-encoding-mix.html fails on Qt after enabling HTML5 Lexer
https://bugs.webkit.org/show_bug.cgi?id=40661

Qt's decoders don't seem to be passing the "--" of the "-->" to the
HTML5DocumentParser correctly, thus the comment is never closed
and the rest of the document gets eaten.

  • platform/qt/Skipped:
    • Skip the test until a Qt person can take a look.
1:59 AM Changeset in webkit [61245] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Add two XSS Auditor tests to the Skipped list. These tests actually
pass in the sense that the attack is blocked. However, the U+FFFD in
the console output is getting mangled. We could check in Qt-specific
expected results, but that doesn't quite seem right. There's something
wrong with the Qt UT8 decoder, which I suspect is related to (or the
same as) https://bugs.webkit.org/show_bug.cgi?id=35263

  • platform/qt/Skipped:
1:50 AM Changeset in webkit [61244] by abecsi@webkit.org
  • 2 edits in trunk/JavaScriptCore

Store matchBegin directly in the array of output instead of the stack.
https://bugs.webkit.org/show_bug.cgi?id=38988

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-06-16
Reviewed by Geoffrey Garen.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateDisjunction): (JSC::Yarr::RegexGenerator::generate):
1:48 AM Changeset in webkit [61243] by abarth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Add platform-specific results for Snow Leopard. Maciej thinks there is
something going on here related to BIDI and additional FFFD
replacements. This test is already on our list of things to
investigate more closely.

  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Added.
  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.png: Added.
  • platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.txt: Added.
1:25 AM Changeset in webkit [61242] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-16 Eric Seidel <eric@webkit.org>

Unreviewed, just updating qt platform result to match new expectations.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Windows and Chromium will still need updates, but I don't have easy
access to those results.

  • platform/qt/fast/text/stripNullFromText-expected.txt:
    • \0 now gets converted to 0xfffd per HTML5.
  • platform/qt/fast/text/international/hindi-whitespace-expected.txt:
1:23 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
1:20 AM Changeset in webkit [61241] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore: <rdar://problem/8077119> REGRESSION (r60247): Google Reader contains the tops of pieces of unidentifiable text under feed headlines.
https://bugs.webkit.org/show_bug.cgi?id=40386

Reviewed by Alexey Proskuryakov.

Test: platform/mac/fast/text/x-height.html

The result of platformBoundsForGlyph() is in flipped coordinates, whereas the result of
-[NSFont boundingRectForGlyph:] was not. r60247 failed to account for this.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit): Measure the height of the x glyph above the baseline
correctly.
(WebCore::SimpleFontData::platformBoundsForGlyph): Return a rect in flipped coordinates on Tiger
as well.

LayoutTests: <rdar://problem/8077119> REGRESSION: Google Reader contains the tops of pieces of unidentifiable text under feed headlines.
https://bugs.webkit.org/show_bug.cgi?id=40386

Reviewed by Alexey Proskuryakov.

  • platform/mac/fast/text/x-height-expected.checksum: Added.
  • platform/mac/fast/text/x-height-expected.png: Added.
  • platform/mac/fast/text/x-height-expected.txt: Added.
  • platform/mac/fast/text/x-height.html: Added.
1:06 AM Changeset in webkit [61240] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Update platform-specific expected results for Qt.

  • platform/qt/fast/text/international/hindi-whitespace-expected.txt:
12:59 AM Changeset in webkit [61239] by abarth@webkit.org
  • 4 edits in trunk

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't crash when a document ends with an entity
https://bugs.webkit.org/show_bug.cgi?id=40658

When we SWITCH_TO a state, we're expecting our caller to have advanced
the source. Rather than have all the callers check for empty, we do
that ourselves.

  • html/HTML5Lexer.cpp:

2010-06-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't crash when a document ends with an entity
https://bugs.webkit.org/show_bug.cgi?id=40658

Add a test for an entity being the only contents of a file.

  • html5lib/resources/webkit01.dat:
12:51 AM Changeset in webkit [61238] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-06-16 Eric Seidel <eric@webkit.org>

Unreviewed, just updating platform results to match new expectations.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Update platform-specific results for broken CSS test whose results
changed as part of http://trac.webkit.org/changeset/61234.

  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
12:30 AM Changeset in webkit [61237] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

I seem to have screwed up generating the updated expectation file.
This file is from the bots.

  • platform/mac/tables/mozilla/images/adforce_imgis_com-expected.txt:
12:04 AM Changeset in webkit [61236] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-16 Adam Barth <abarth@webkit.org>

Unreviewed.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Revert unintentional change to expected results. I have a different
diff on my machine because I have some errant cookies.

  • inspector/audits-panel-functional-expected.txt:

Jun 15, 2010:

11:51 PM Changeset in webkit [61235] by abarth@webkit.org
  • 7 edits in trunk/LayoutTests

2010-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

Change some tests not to rely upon <script/>. We already cover that
case in parsing tests.

  • fast/lists/ol-nested-items-dynamic-insert.html:
  • fast/lists/ol-nested-items-dynamic-remove.html:
  • fast/lists/ol-nested-items.html:
  • fast/lists/ol-nested-list-dynamic-insert.html:
  • fast/lists/ol-nested-list-dynamic-remove.html:
  • fast/lists/ol-nested-list.html:
11:27 PM Changeset in webkit [61234] by abarth@webkit.org
  • 47 edits in trunk

2010-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

  • page/Settings.cpp: (WebCore::Settings::Settings):

2010-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

This patch updates the expected results for tests that conflict with
the HTML5 specification. In a later patch, I'll update the tests
themselves to fix pass/fail messages.

  • fast/doctypes/005-case-preserving-expected.txt:
    • HTML5 specifies case normalization for DOCTYPEs.
  • fast/js/missing-title-end-tag-js-expected.txt:
    • HTML5 requires us to swallow the entire document when <title> is unterminated.
  • fast/parser/comment-in-iframe-expected.txt:
  • fast/parser/comment-in-script-tricky-expected.txt:
  • fast/parser/comment-in-title-expected.txt:
  • fast/parser/comments-expected.txt:
    • Differences due to HTML5 comment parsing.
  • fast/parser/eightdigithexentity-expected.txt:
    • HTML5 specifies a different behavior for &#x00FFFFFF;
  • fast/parser/entity-end-iframe-tag-expected.txt:
    • HTML5 specifies a different behavior for &lt;/iframe>
  • fast/parser/entity-surrogate-pairs-expected.txt:
    • HTML5 doesn't allow entities to create surrogate pairs.
  • fast/parser/html-whitespace-expected.txt:
    • HTML5 has a different handling of CR in this case.
  • fast/parser/script-tag-with-trailing-slash-expected.txt:
    • HTML5 does not allow self-closing <script/> tags.
  • fast/parser/tag-with-exclamation-point-expected.txt:
    • HTML5 treats bogus DOCTYPEs as comments.
  • fast/parser/xml-directive-in-dom-expected.txt:
    • HTML5 attaches <?xml?> processing directives to the DOM as comments.
  • fast/xpath/xpath-functional-test-expected.txt:
    • I don't fully understand this test, but our new behavior matches the Firefox nightly builds (which have an HTML5 parser).
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:
    • Massive progressions on HTML5 conformance.
  • http/tests/loading/gmail-assert-on-load-expected.txt:
    • I don't fully understand this behavior change. It might represent a bug. We're still investigating.
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
    • Update expected results for change in NULL char handling.
  • http/tests/security/xssAuditor/img-onerror-tricky-expected.txt:
    • This exploit no longer works in the HTML5 parser, so it's not blocked.
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
    • This a real regression. We need to update the XSSAuditor to use the HTML5 parser's HTML entity decoder. I'll do that in a followup patch because there doesn't appear to be an easy way to key the choice off of the WebCore::Setting.
  • http/tests/security/xssAuditor/malformed-HTML-expected.txt:
    • Slightly different handling of malformed HTML. The exploit is still blocked.
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
    • Update expected result due to different NULL character handling.
  • inspector/audits-panel-functional-expected.txt:
  • inspector/timeline-script-tag-1-expected.txt:
    • Slightly different semantics around document.write.
  • inspector/elements-panel-structure-expected.txt:
    • HTML5 specifies case normalization for DOCTYPEs.
  • platform/mac/css1/box_properties/float_elements_in_series-expected.txt:
    • HTML5 specifies different handling of "<foo<bar"
  • platform/mac/fast/doctypes/003-expected.txt:
    • HTML5 specifies case normalization for DOCTYPEs.
  • platform/mac/fast/dom/stripNullFromTextNodes-expected.txt:
    • HTML5 specifies different handling of NULL characters.
  • platform/mac/fast/invalid/016-expected.txt:
    • HTML5 specifies different handling of "<foo<bar"
  • platform/mac/fast/parser/broken-comments-vs-parsing-mode-expected.txt:
    • HTML5 specifies different handling of HTML comments.
  • platform/mac/fast/parser/comment-in-style-expected.txt:
    • HTML5 specifies different handling of HTML comments.
  • platform/mac/fast/parser/parseCommentsInTitles-expected.txt:
    • HTML5 specifies different handling of HTML comments.
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/mac/fast/text/international/hindi-whitespace-expected.txt:
    • HTML5 specifies different handling CR. I don't fully understand the consequences of this change, but our new behavior matches the Firefox nightly.
  • platform/mac/fast/text/stripNullFromText-expected.txt:
    • HTML5 specifies different handling of NULL characters.
  • platform/mac/fast/tokenizer/missing-title-end-tag-1-expected.txt:
  • platform/mac/fast/tokenizer/missing-title-end-tag-2-expected.txt:
    • HTML5 requires us to swallow the entire document when <title> is unterminated.
  • platform/mac/fast/tokenizer/script_extra_close-expected.txt:
    • We're coalescing text nodes slightly different in the new parser. We're going to get this up to spec when we work on the TreeConstructor (which is where the spec handles text node coalescing).
  • platform/mac/tables/mozilla/images/adforce_imgis_com-expected.txt:
    • Different handling of crazy unicode characters (replaced with FFFD). Still investigating whether this is a real bug.
  • webarchive/archive-empty-frame-dom-expected.webarchive:
    • HTML5 specifies case normalization for DOCTYPEs.

2010-06-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Enable HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=40650

  • DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions):
9:50 PM Changeset in webkit [61233] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Don't leak WebGeolocationPositionInternal and GeolocationPosition instances for every WebGeolocationPosition created.

Reviewed by Sam Weinig.

  • WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPosition dealloc]): Implement -dealloc and release our WebGeolocationPositionInternal instance.

8:23 PM Changeset in webkit [61232] by yuzo@google.com
  • 26 edits
    2 adds in trunk

2010-06-15 Dmitry Titov <dimich@chromium.org>

Not reviewed, updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:

2010-06-15 Mark Rowe <mrowe@apple.com>

Rubber-stamped by David Harrison.

sqlite3_prepare16_v2 is not documented as always setting "tail" during error cases.
Explicitly initialize it to null, just to be safe.

  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::prepare):

2010-06-10 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement render style selection for pages to support CSS3 Paged Media.
https://bugs.webkit.org/show_bug.cgi?id=35961

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame pageProperty:propertyName:]):

2010-06-10 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement render style selection for pages to support CSS3 Paged Media.
https://bugs.webkit.org/show_bug.cgi?id=35961

  • DumpRenderTree/LayoutTestController.cpp: (parsePagePropertyParameters): (pagePropertyCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageProperty):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageProperty):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageProperty):
7:27 PM Changeset in webkit [61231] by mrowe@apple.com
  • 2 edits in trunk/WebCore

sqlite3_prepare16_v2 is not documented as always setting "tail" during error cases.
Explicitly initialize it to null, just to be safe.

Rubber-stamped by David Harrison.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

7:23 PM Changeset in webkit [61230] by mrowe@apple.com
  • 4 edits in trunk/WebCore

<rdar://problem/8091103> URLs not added to history when initial load happens via back/forward navigation

Reviewed by Brady Eidson.

Back/forward navigation currently does not create or update items in the global history. This is usually
desirable, except for in the event where the back/forward list was created programmatically and attached
to the WebView and the initial load in that WebView is being performed as a result of a back/forward
navigation. In that situation it is preferable to ensure that global history item is created or updated.

No test case is added because DumpRenderTree is not able to test the scenario where the initial
load in a WebView occurs via a back/forward navigation.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): If we're committing the first load in this frame as a
back/forward navigation then we should update the history as if it were a standard load, with the
exception of updating the back/forward list.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateForStandardLoad): Add a parameter to allow callers to skip updating
the back/forward list.

  • loader/HistoryController.h:

(WebCore::HistoryController::):

6:07 PM Changeset in webkit [61229] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:45 PM Changeset in webkit [61228] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Fix for <rdar://problem/8010805>
Assertion failure ("mainThreadPthread") in isMainThread() mousing over cnn.com in Mini Browser

Reviewed by Anders Carlsson.

Don't use WebCore::String::operator NSString*() from the UIProcess, since it uses
StringImpl::createCFString() which expects to be called from WebCore's main thread.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::nsStringFromWebCoreString):
(WebKit::PageClientImpl::toolTipChanged):

  • UIProcess/API/mac/WKView.mm:

(-[WKView view:stringForToolTip:point:userData:]):

5:19 PM Changeset in webkit [61227] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:42 PM Changeset in webkit [61226] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-06-15 Simon Fraser <Simon Fraser>

Fix crashing tests; need to check for null documentElement().

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
4:36 PM Changeset in webkit [61225] by kinuko@chromium.org
  • 3 edits in trunk/WebCore

2010-06-15 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Fix compilation errors in BlobBuilder with FILE_WRITER enabled
https://bugs.webkit.org/show_bug.cgi?id=40606

No functionality change so no new tests.

  • html/BlobBuilder.cpp:
  • html/BlobBuilder.h:
4:35 PM Changeset in webkit [61224] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-15 Xan Lopez <xlopez@igalia.com>

Fix compilation with older GTK+.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::pageRect):
4:29 PM Changeset in webkit [61223] by jianli@chromium.org
  • 3 edits in trunk/WebCore

Move type attribute from File.idl to Blob.idl per latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=40642

Reviewed by David Levin.

  • html/Blob.idl:
  • html/File.idl:
4:17 PM Changeset in webkit [61222] by weinig@apple.com
  • 24 edits
    17 adds in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
WebKit2: Add mechanism to inject code into the WebProcess on startup

Reviewed by Anders Carlsson.

Add initial InjectedBundle support.

WebKit2:

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Add new LoadInjectedBundle message kind.

  • UIProcess/API/C/WKContext.cpp:

(toWK):
(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):

  • UIProcess/API/C/WKContext.h:

Rename WKContextCreateWithProcessModel to WKContextCreate and add
WKContextCreateWithInjectedBundlePath for creating a context with
a bundle.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebContext.h:

(WebKit::WebContext::create):
(WebKit::WebContext::processModel):
(WebKit::WebContext::bundlePath):

  • UIProcess/WebPageNamespace.cpp:

(WebKit::WebPageNamespace::ensureWebProcess):
(WebKit::WebPageNamespace::reviveIfNecessary):

  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::getWebProcess):

  • UIProcess/WebProcessManager.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::WebProcessProxy):

  • UIProcess/WebProcessProxy.h:

Thread the bundle path through process creation.

  • WebProcess/InjectedBundle: Added.
  • WebProcess/InjectedBundle/API: Added.
  • WebProcess/InjectedBundle/API/c: Added.
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp: Added.

(WKBundleSetClient):

  • WebProcess/InjectedBundle/API/c/WKBundle.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h: Added.

(WebKit::):
(toWK):
(toRef):

  • WebProcess/InjectedBundle/API/c/WKBundleBase.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundleInitialize.h: Added.
  • WebProcess/InjectedBundle/InjectedBundle.cpp: Added.

(WebKit::InjectedBundle::InjectedBundle):
(WebKit::InjectedBundle::~InjectedBundle):
(WebKit::InjectedBundle::initializeClient):
(WebKit::InjectedBundle::didCreatePage):

  • WebProcess/InjectedBundle/InjectedBundle.h: Added.

(WebKit::InjectedBundle::create):
Add bundle boilerplate.

  • WebProcess/InjectedBundle/mac: Added.
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp: Added.

(WebKit::InjectedBundle::load):
Load the InjectedBundle using CFBundle.

  • WebProcess/InjectedBundle/win: Added.
  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: Added.

(WebKit::pathGetFileName):
(WebKit::directoryName):
(WebKit::InjectedBundle::load):
Load the InjectedBundle using HMODULE.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Add initial bundle callback for page creation. More to come.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::loadInjectedBundle):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::injectedBundle):
Load the InjectedBundle on LoadInjectedBundle message.

  • WebKit2.xcodeproj/project.pbxproj:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add the new files.

WebKitTools:

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/WebBundle-Info.plist: Added.

Add test InjectedBundle to the project.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
Get the path to the WebBundle from the the main bundle and pass it to the new
WKContextCreateWithInjectedBundlePath function.

  • MiniBrowser/mac/BrowserWindowController.m:

(_didChangeProgress):
Fix the build. This has been broken for a while.

  • MiniBrowser/mac/WebBundle: Added.
  • MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.

(_didCreatePage):
(WKBundleInitialize):
Add really basic InjectedBundle.

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):
Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.

3:47 PM Changeset in webkit [61221] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Adding myself to the reviewers list.
https://bugs.webkit.org/show_bug.cgi?id=40693

Reviewed by Darin Adler.

  • Scripts/webkitpy/common/config/committers.py:
3:44 PM Changeset in webkit [61220] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-15 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, updating Chromium test expectations for media layout tests.

  • platform/chromium/test_expectations.txt:
3:33 PM Changeset in webkit [61219] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Fix build.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::shouldClose): Call loader()->shouldClose().

3:30 PM Changeset in webkit [61218] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium test expectations.

Mark following tests SLOW so they won't fail on TIMEOUT in Debug:
fast/frames/lots-of-iframes.html
fast/frames/lots-of-objects.html

  • platform/chromium/test_expectations.txt:
3:20 PM Changeset in webkit [61217] by Darin Adler
  • 16 edits in trunk

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dispatchBeforeUnloadEvent): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebView.cpp: (WebView::shouldClose): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebFrame.cpp: (wxWebFrame::ShouldClose): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebView/WebView.mm: (-[WebView shouldClose]): Call shouldClose on FrameLoader instead of going through Frame.

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

Refactoring that does not require new tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL): Call setStatus and setDefaultStatus on DOMWindow rather than going through Frame. (WebCore::FrameLoader::open): Ditto. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call shouldClose on this object instead of going through Frame.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents): Call shouldClose on FrameLoader instead of going through Frame. (WebCore::DOMWindow::focus): Moved the code from Frame::focusWindow in here. (WebCore::DOMWindow::blur): Moved the code from Frame::unfocusWindow in here. (WebCore::DOMWindow::close): Moved the code from Frame::scheduleClose in here. (WebCore::DOMWindow::setStatus): Moved the code from Frame::setJSStatusBarText in here. (WebCore::DOMWindow::setDefaultStatus): Moved the code from Frame::setJSDefaultStatusBarText in here.
  • page/DOMWindow.h: Added m_status and m_defaultStatus members to store the status messages being set by the DOM.
  • page/Frame.cpp: Removed all the functions that were marked "to be moved into Chrome".
  • page/Frame.h: Ditto.

2010-06-15 Darin Adler <Darin Adler>

Reviewed by Adam Barth.

Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryClose): Call shouldClose on FrameLoader instead of going through Frame.
3:04 PM Changeset in webkit [61216] by darin@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-15 Darin Fisher <darin@chromium.org>

Fix whitespace error in expected results.

Looks like Chromium's TestShell and DRT do not agree in how whitespace
is generated in some cases.

  • fast/history/history-back-within-subframe-expected.txt:
  • platform/chromium/test_expectations.txt:
3:00 PM Changeset in webkit [61215] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-06-15 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Garbage shown outside HTML if HTML is absolutely positioned
https://bugs.webkit.org/show_bug.cgi?id=36163

Add a check that the root renderer (the document element's renderer) covers
the entire viewport before deciding that we don't need the RenderView
to paint its background. Fixes lack of painting with positioned, floated, and
display: table html elements.

Test: fast/repaint/positioned-document-element.html

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
3:00 PM Changeset in webkit [61214] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-06-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Safari 5 does not clear background with transformed html element
https://bugs.webkit.org/show_bug.cgi?id=40498

When the document element is composited, ensure that the FrameView
paints the background, because the composited layer may be transparent,
or might get moved via animation.

Test: compositing/repaint/composited-document-element.html

  • rendering/RenderView.cpp: (WebCore::isComposited): (WebCore::rendererObscuresBackground):
2:48 PM Changeset in webkit [61213] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Remove getPluginInfoFromBundleAndMIMEDictionary:

Reviewed by Dan Bernstein.

  • Plugins/WebBasePluginPackage.mm:
2:40 PM Changeset in webkit [61212] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fold getPluginInfoFromBundleAndMIMEDictionary: into its sole caller.

Reviewed by Dan Bernstein.

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage getPluginInfoFromPLists]):

1:57 PM Changeset in webkit [61211] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Switch to using GIO methods instead of realpath in GtkLauncher to determine
the file URI. This should remove warnings about realpath being undefined
when compiling with '-ansi'.

  • GtkLauncher/main.c: (filenameToURL): Use GIO instead of realpath to determine file URI.
1:48 PM WebKit Team edited by dumi@chromium.org
(diff)
1:41 PM Changeset in webkit [61210] by darin@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-06-15 Darin Fisher <darin@chromium.org>

Adding missing test results.

  • fast/history/history-back-within-subframe-expected.txt: Added.
12:49 PM Changeset in webkit [61209] by xan@webkit.org
  • 2 edits in trunk

2010-06-15 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Remove GSEAL from the debug config since the bots have a GTK+
version too old, duh.

  • GNUmakefile.am:
12:32 PM Changeset in webkit [61208] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-06-15 Xan Lopez <xlopez@igalia.com>

Try to fix GTK+ build.

  • platform/gtk/GtkVersioning.h:
12:31 PM Changeset in webkit [61207] by darin@chromium.org
  • 10 edits
    5 adds in trunk

2010-06-15 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

Introduce HistoryItem::itemSequenceNumber and use it to identify
HistoryItems that are clones of one another.

Changes HistoryController::recursiveGoToItem to use itemSequenceNumber
equality instead of isTargetItem as the pre-requisite for not calling
FrameLoader::loadItem.

Changes FrameLoader::loadItem to require equivalent
documentSequenceNumber before initiating a same document navigation.
This alone would appear to fix the bug, but it does not go far enough
since without the itemSequenceNumber equality check, we'd re-load more
often than we should.

Moves documentSequenceNumber assignment into createItemTree as cleanup
and to ensure that it gets called properly whenever we create a cloned
HistoryItem. (createItemTree's mission is to create clones up until
or including the target frame depending on the value of the doClip
parameter.)

Removes the now unused HistoryController::urlsMatchItem.

https://bugs.webkit.org/show_bug.cgi?id=40451

Test: fast/history/history-back-within-subframe.html

http/tests/navigation/history-back-across-form-submission-to-fragment.html

  • history/HistoryItem.cpp: (WebCore::generateSequenceNumber): (WebCore::HistoryItem::HistoryItem):
  • history/HistoryItem.h: (WebCore::HistoryItem::setItemSequenceNumber): (WebCore::HistoryItem::itemSequenceNumber):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
  • loader/HistoryController.cpp: (WebCore::HistoryController::updateBackForwardListForFragmentScroll): (WebCore::HistoryController::createItemTree): (WebCore::HistoryController::recursiveGoToItem): (WebCore::HistoryController::pushState):
  • loader/HistoryController.h:
12:14 PM Changeset in webkit [61206] by xan@webkit.org
  • 12 edits in trunk

2010-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Add GSEAL_ENABLE flag when doing debug builds.

  • GNUmakefile.am:

WebCore:

2010-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Fix compilation with GSEAL_ENABLE.

  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::detachAdjustment): (ScrollbarGtk::updateThumbPosition): (ScrollbarGtk::updateThumbProportion):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint): (WebCore::PluginView::initXEvent): (WebCore::PluginView::platformGetValue): (WebCore::PluginView::platformStart):
  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_realize): (gtk_xtbin_new): (gtk_xtbin_set_position): (gtk_xtbin_unrealize):

WebKit/gtk:

2010-06-15 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Fix compilation with GSEAL_ENABLE.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::contentsSizeChanged):
  • tests/testdomnode.c: (test_dom_node_insertion):
  • webkit/webkitwebview.cpp: (webkit_web_view_realize): (webkit_web_view_script_dialog): (webkit_web_view_drag_end): (webkit_web_view_init):
11:59 AM Changeset in webkit [61205] by ap@apple.com
  • 1 edit
    4 moves in trunk/LayoutTests

Increase limit on number of (i)frames from 200 to 1000.
https://bugs.webkit.org/show_bug.cgi?id=39427

Move the right test this time, move remove-iframe-crash back. Oops.

  • compositing/iframes/lots-of-iframes-expected.txt: Removed.
  • compositing/iframes/lots-of-iframes.html: Removed.
  • compositing/iframes/remove-iframe-crash-expected.txt: Copied from fast/frames/remove-iframe-crash-expected.txt.
  • compositing/iframes/remove-iframe-crash.html: Copied from fast/frames/remove-iframe-crash.html.
  • fast/frames/lots-of-iframes-expected.txt: Copied from compositing/iframes/lots-of-iframes-expected.txt.
  • fast/frames/lots-of-iframes.html: Copied from compositing/iframes/lots-of-iframes.html.
  • fast/frames/remove-iframe-crash-expected.txt: Removed.
  • fast/frames/remove-iframe-crash.html: Removed.
11:54 AM Changeset in webkit [61204] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2010-06-11 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

<rdar://problem/8084721> Pages using accelerated compositing fail to update correctly in Carbon apps

The run loop observer used to commit compositing layer changes does not do
updates if [window viewsNeedDisplay] is true, because this indicates that a delayed window
update is pending (added in r58623).

However, Carbon apps don't use the NSWindow updating mechanism, so [window viewsNeedDisplay] always returns YES.
This caused us to never sync compositing layers.

So detect if the current window is wrapping a carbon window, and in that case consult the root
HIView to detect if display is pending.

  • WebView/WebView.mm: (layerSyncRunLoopObserverCallBack):
11:52 AM Changeset in webkit [61203] by andersca@apple.com
  • 3 edits in trunk/JavaScriptCore

Make JavaScriptCore build with clang++.

Reviewed by Sam Weinig.

  • jit/JITInlineMethods.h:

(JSC::JIT::emitPutVirtualRegister):
Explicitly cast to an int.

  • yarr/RegexCompiler.cpp:

(JSC::Yarr::compileRegex):
Return 0 instead of false.

11:48 AM Changeset in webkit [61202] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-06-15 Kenneth Russell <kbr@google.com>

Unreviewed, test fix.

Fix test breakage from 40175
https://bugs.webkit.org/show_bug.cgi?id=40631

  • fast/canvas/webgl/texture-npot.html:
11:40 AM Changeset in webkit [61201] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-06-15 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Fix the build when WebSockets are disabled.

  • bindings/js/JSWorkerContextCustom.cpp:
11:37 AM Changeset in webkit [61200] by Simon Fraser
  • 3 edits
    2 adds in trunk

2010-06-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

YouTube thumbnail borders vanish during transition
https://bugs.webkit.org/show_bug.cgi?id=40551

Turn off the direct image optimization if the image has a clip style, so that is is
correctly rendered with the clip.

Test: compositing/images/clip-on-directly-composited-image.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
11:31 AM Changeset in webkit [61199] by ap@apple.com
  • 1 edit
    4 moves in trunk/LayoutTests

Not reviewed, just moving tests.

Increase limit on number of (i)frames from 200 to 1000.
https://bugs.webkit.org/show_bug.cgi?id=39427

Move the new tests out of compositing directory.

  • compositing/iframes/lots-of-objects-expected.txt: Removed.
  • compositing/iframes/lots-of-objects.html: Removed.
  • compositing/iframes/remove-iframe-crash-expected.txt: Removed.
  • compositing/iframes/remove-iframe-crash.html: Removed.
  • fast/frames/lots-of-objects-expected.txt: Copied from LayoutTests/compositing/iframes/lots-of-objects-expected.txt.
  • fast/frames/lots-of-objects.html: Copied from LayoutTests/compositing/iframes/lots-of-objects.html.
  • fast/frames/remove-iframe-crash-expected.txt: Copied from LayoutTests/compositing/iframes/remove-iframe-crash-expected.txt.
  • fast/frames/remove-iframe-crash.html: Copied from LayoutTests/compositing/iframes/remove-iframe-crash.html.
10:50 AM Changeset in webkit [61198] by yurys@chromium.org
  • 8 edits in trunk

2010-06-15 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: make ui tests pass when ScriptDebugServer is used
https://bugs.webkit.org/show_bug.cgi?id=40623

  • bindings/v8/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::functionName): return empty string for anonymous functions instead of [anonymous].
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::handleV8DebugEvent): autocontinue on syntax errors since there is no stack trace and not much to inspect.

2010-06-15 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: make ui tests pass when ScriptDebugServer is used
https://bugs.webkit.org/show_bug.cgi?id=40623

  • src/js/DebuggerAgent.js: (devtools.DebuggerAgent.prototype.formatCallFrame_): return empty function name for anonymous functions.
  • src/js/DebuggerScript.js:
  • src/js/Tests.js: (.TestSuite.prototype.testProfilerTab.findVisibleView): (.TestSuite.prototype.testProfilerTab): (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed): (.TestSuite.prototype.testSetBreakpoint.this): (.TestSuite.prototype.testSetBreakpoint): (.TestSuite.prototype.testEvalOnCallFrame.waitForBreakpointHit): (.TestSuite.prototype._executeCodeWhenScriptsAreParsed.executeFunctionInInspectedPage): (.TestSuite.prototype.testExpandScope.examineScopes): (.TestSuite.prototype.testExpandScope): (.TestSuite.prototype.testDebugIntrinsicProperties):
10:25 AM Changeset in webkit [61197] by yael.aharon@nokia.com
  • 3 edits in trunk/WebKit/qt

[Qt] Rename NotificatioIconWrapper to NotificationWrapper
https://bugs.webkit.org/show_bug.cgi?id=40571

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationWrapper::NotificationWrapper):
(WebCore::NotificationWrapper::close):
(WebCore::NotificationWrapper::title):
(WebCore::NotificationWrapper::message):
(WebCore::NotificationWrapper::iconData):
(WebCore::NotificationWrapper::notificationClosed):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationForWrapper):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore::NotificationWrapper::~NotificationWrapper):

9:55 AM Changeset in webkit [61196] by Adam Roben
  • 3 edits
    1 delete in trunk

Remove some unnecessary steps for setting up the debugger on Windows

Apparently update-webkit does this for you now.

WebKitSite:

Rubber-stamped by Steve Falkenburg.

  • building/debug.html: Removed the first two Windows steps, which are

now unnecessary, and updated the third to reflect reality.

WebKitTools:

Remove the redundant set-apple-windows-environment-variables script

Apparently update-webkit does this for you these days.

Rubber-stamped by Steve Falkenburg.

  • Scripts/set-apple-windows-environment-variables: Removed.
9:40 AM Changeset in webkit [61195] by Adam Roben
  • 4 edits in trunk

Make WebCore's and JavaScriptCore's DerivedSources available for debugging in production builds

Fixes <http://webkit.org/b/40626> <rdar://problem/8094205>.

Reviewed by Sam Weinig.

JavaScriptCore:

JavaScriptCore's DerivedSources directory to
AppleInternal/Sources/JavaScriptCore.

WebCore:

  • WebCore.vcproj/WebCore.make: Copy the contents of WebCore's

DerivedSources directory to AppleInternal/Sources/WebCore.

9:40 AM Changeset in webkit [61194] by Adam Roben
  • 2 edits
    3 adds
    2 deletes in trunk/WebKitSite

Improve instructions for debugging on Windows

Fixes <http://webkit.org/b/40585>.

Reviewed by Steve Falkenburg.

  • building/debug.html: Improved the Windows instructions. We now

instruct users to set things up so that hitting F5 from WebKit.sln
will launch Safari with the WEBKITNIGHTLY environment variable
pointing to the location of the built WebKit.dll.

  • building/console_vs2005.jpg: Removed.
  • building/debug_vs2005.jpg: Removed.
  • building/launch-debugger-vs2005.png: Added.
  • building/set-as-startup-project-vs2005.png: Added.
  • building/set-debugging-properties-vs2005.png: Added.
9:39 AM Changeset in webkit [61193] by Adam Roben
  • 1 edit
    1 add in trunk/WebKitTools

Add a script to set the WebKitOutputDir and WebKitLibrariesDir environment variables

Fixes <http://webkit.org/b/40595>.

Reviewed by Steve Falkenburg.

  • Scripts/set-apple-windows-environment-variables: Added.

(to_windows_path): Passes the passed-in path through cygpath to
generate a Windows-style path.
(main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
variables to their defaults, if they aren't already set.

9:39 AM Changeset in webkit [61192] by Adam Roben
  • 2 edits in trunk/WebKitTools

Speed up run-safari/debug-safari on Windows

Fixes <http://webkit.org/b/40586>.

Reviewed by Steve Falkenburg.

  • Scripts/webkitdirs.pm:

(runSafari): When debugging, set up the environment to run Safari
using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
actually launch the debugger. When not debugging, just run WebKit.exe
and it will do the rest for us.

9:39 AM Changeset in webkit [61191] by Adam Roben
  • 2 edits in trunk/WebKit/win

Add WebKitLauncherWin to WebKit.sln

Fixes <http://webkit.org/b/40583>.

Reviewed by Darin Adler.

  • WebKit.vcproj/WebKit.sln: Added WebKitLauncherWin.vcproj. It depends

on WebKitAPITest, so is the last project to build. (Also removed
QTMovieWin's direct dependency on JavaScriptCore, since it already has
an indirect dependency on it.)

9:18 AM Changeset in webkit [61190] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-06-15 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
9:18 AM Changeset in webkit [61189] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebKit/mac: <rdar://problem/8077032> REGRESSION (r50796): Black background on AppleScript generated email

Reviewed by John Sullivan.

Test: platform/mac/editing/input/NSBackgroundColor-transparent.html

r50796 changed the initial background color from invalid to transparent. As a result,
NSAttributedStrings returned from +_web_attributedStringFromRange started including the
NSBackgroundColor attribute, with a transparent color as the value. This caused problems for
components in the system that ignore the alpha component, turning the color into opaque black.

  • Misc/WebNSAttributedStringExtras.mm:

(+[NSAttributedString _web_attributedStringFromRange:]): Change to not include the background
and foreground color attributes if the color are transparent.

LayoutTests: Test for <rdar://problem/8077032> REGRESSION (r50796): Black background on AppleScript generated email

Reviewed by John Sullivan.

  • platform/mac/editing/input/NSBackgroundColor-transparent-expected.txt: Added.
  • platform/mac/editing/input/NSBackgroundColor-transparent.html: Added.
9:15 AM Changeset in webkit [61188] by yael.aharon@nokia.com
  • 1 edit in trunk/WebKit/qt/ChangeLog

Unreviewed.

Fix typo in reviewer name in r61187

9:10 AM Changeset in webkit [61187] by yael.aharon@nokia.com
  • 3 edits in trunk/WebKit/qt

[Qt] Build fix for Qt minimal after r61121
https://bugs.webkit.org/show_bug.cgi?id=40624

Reviewed by Somon Fraser.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::close):
(WebCore::NotificationIconWrapper::title):
(WebCore::NotificationIconWrapper::message):
(WebCore::NotificationIconWrapper::iconData):
(WebCore::NotificationIconWrapper::notificationClosed):

  • WebCoreSupport/NotificationPresenterClientQt.h:

(WebCore::NotificationIconWrapper::~NotificationIconWrapper):

6:57 AM Changeset in webkit [61186] by kov@webkit.org
  • 2 edits in trunk/WebKit

2010-06-15 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed EFL build fix. Simple typo.

  • efl/WebCoreSupport/InspectorClientEfl.cpp: (WebCore::InspectorClientEfl::sendMessageToFrontend):
6:38 AM Changeset in webkit [61185] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-06-15 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Bring framebuffer functions to GLES2 conformance
https://bugs.webkit.org/show_bug.cgi?id=40175

  • fast/canvas/webgl/framebuffer-test-expected.txt: Added.
  • fast/canvas/webgl/framebuffer-test.html: Added.
  • fast/canvas/webgl/resources/webgl-test.js: (assertMsg): Function added.
  • fast/canvas/webgl/texture-npot.html: Remove assertMsg function.

2010-06-15 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Bring framebuffer functions to GLES2 conformance
https://bugs.webkit.org/show_bug.cgi?id=40175

Test: fast/canvas/webgl/framebuffer-test.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::checkFramebufferStatus): Check input parameters and deal with default framebuffer situation. (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Check input parameters. (WebCore::WebGLRenderingContext::framebufferTexture2D): Ditto. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Ditto. (WebCore::WebGLRenderingContext::validateFramebufferFuncParameters): Check input parameters.
  • html/canvas/WebGLRenderingContext.h: Add validateFramebufferFuncParameters.
6:21 AM Changeset in webkit [61184] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-15 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT EventSender support to graphics context events
https://bugs.webkit.org/show_bug.cgi?id=40324

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick):
6:08 AM Changeset in webkit [61183] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-15 Patrick Gansterer <paroga@paroga.com>

Reviewed by David Levin.

Buildfix for ResourceHandleWin after r24202 and r55542.
https://bugs.webkit.org/show_bug.cgi?id=32963

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestComplete): (WebCore::transferJobStatusCallback): (WebCore::ResourceHandle::start):
4:41 AM Changeset in webkit [61182] by alex
  • 2 edits in trunk/LayoutTests

2010-06-15 Alejandro G. Castro <alex@igalia.com>

Unreviewed.

Add expected results changes requiered for the patch in the review
60961.
https://bugs.webkit.org/show_bug.cgi?id=40581

  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
4:38 AM Changeset in webkit [61181] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-06-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joe Pecoraro.

Web Inspector: Should not expose window.console._inspectorCommandLineAPI to the web.

https://bugs.webkit.org/show_bug.cgi?id=40500

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
2:14 AM Changeset in webkit [61180] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fix invalid access to non-static data member warning in JITPropertyAccess32_64 on ARM
https://bugs.webkit.org/show_bug.cgi?id=40423

Rubber-stamped by Eric Seidel.

Using OBJECT_OFFSETOF macro instead of objectof to bypass access to
non-static data member warning.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

1:15 AM Changeset in webkit [61179] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] The qt_webkit_version.pri file gets overwritten on install
https://bugs.webkit.org/show_bug.cgi?id=40487

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-06-15
Reviewed by Simon Hausmann.

Don't install qt_webkit_version.pri when building WebKit inside of Qt.
The import of WebKit into Qt will take care of providing the file
in mkspecs/modules and it'll be installed through projects.pro.

  • WebCore.pro:
1:09 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:06 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:04 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
1:03 AM Changeset in webkit [61178] by tony@chromium.org
  • 15 edits
    4 adds
    2 deletes in trunk

2010-06-15 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

resolve urls in text/html clipboard data
https://bugs.webkit.org/show_bug.cgi?id=40044

  • editing/pasteboard/copy-resolves-urls-expected.txt: Added.
  • editing/pasteboard/copy-resolves-urls.html: Added.
  • editing/pasteboard/paste-noscript-expected.txt:
  • editing/pasteboard/paste-noscript.html: Updated to no longer throw a JS exception so the results are the same

with V8 and JSC

  • http/tests/misc/copy-resolves-urls-expected.txt: Added.
  • http/tests/misc/copy-resolves-urls.html: Added.
  • platform/chromium-mac/editing/pasteboard/paste-noscript-expected.txt: No longer needed since results should match JSC
  • platform/chromium-win/editing/pasteboard/paste-noscript-expected.txt: No longer needed since results should match JSC

2010-06-15 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

resolve urls in text/html clipboard data
https://bugs.webkit.org/show_bug.cgi?id=40044

Allow text/html data copied from a page to contain full URLs when
dragging or copy/pasting.

Tests: editing/pasteboard/copy-resolves-urls.html

http/tests/misc/copy-resolves-urls.html

  • WebCore.base.exp:
  • editing/markup.cpp: (WebCore::appendStartMarkup): (WebCore::getStartMarkup): (WebCore::MarkupAccumulator::appendMarkup): (WebCore::createMarkup):
  • editing/markup.h: (WebCore::):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeRange):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection):
  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::writeRange):
  • platform/gtk/DataObjectGtk.cpp: (WebCore::DataObjectGtk::markup):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection):
  • platform/haiku/PasteboardHaiku.cpp: (WebCore::Pasteboard::writeSelection):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::writeRange):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeSelection):
12:36 AM QtWebKitTriageRoster edited by kent.hansen@nokia.com
(diff)
12:01 AM Changeset in webkit [61177] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, update Chromium expectations for a new test.

  • platform/chromium/test_expectations.txt:

Jun 14, 2010:

11:17 PM Changeset in webkit [61176] by Chris Fleizach
  • 2 edits in trunk/WebCore

No review. GTK build fix.

AX: need ListItemRole and PresentationalRole
https://bugs.webkit.org/show_bug.cgi?id=40133

Mostly speculative fix to make GTK unit tests work.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(atkRole):
(webkit_accessible_get_role):

9:31 PM Changeset in webkit [61175] by tony@chromium.org
  • 4 edits in trunk

2010-06-14 Anders Carlsson <andersca@apple.com>

Fix Chromium build.

  • src/WebPluginListBuilderImpl.cpp: (WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):

2010-06-14 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] checkout chromium third_party directly
https://bugs.webkit.org/show_bug.cgi?id=40556

  • Scripts/update-webkit-chromium: some migration code for the bots
8:55 PM Changeset in webkit [61174] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-06-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/8090895> Update http streaming MIME types.

  • platform/MIMETypeRegistry.cpp: (WebCore::TypeExtensionPair::): Add http streaming MIME synonyms.
7:55 PM Changeset in webkit [61173] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2010-06-14 Eric Carlson <eric.carlson@apple.com>

Unreviewed, fix GTK and Qt builds.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
7:29 PM Changeset in webkit [61172] by eric.carlson@apple.com
  • 5 edits
    2 adds in trunk

2010-06-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

audio/x-mp3 MIME type not recognized
<rdar://problem/7875393>
https://bugs.webkit.org/show_bug.cgi?id=40594


Allow MIMETypeRegistry to have more than one MIME type for a
media file extension, and have the QTKit media engine register
all MIME types it can find for each file type QTKit supports.

Test: media/media-can-play-mp3.html

  • platform/MIMETypeRegistry.cpp: (WebCore::mediaMIMETypeMap): Update for new HashMap format. (WebCore::TypeExtensionPair::): Store String+Vector<String> (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Only consult mediaMIMETypeMap(), it has the canonical answer. (WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): New, return a Vector of all MIME types for an extension.
  • platform/MIMETypeRegistry.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): Add all MIME types returned in the getMediaMIMETypesForExtension Vector.

2010-06-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

audio/x-mp3 MIME type not recognized
https://bugs.webkit.org/show_bug.cgi?id=40594

  • media/media-can-play-mp3-expected.txt: Added.
  • media/media-can-play-mp3.html: Added.
6:50 PM Changeset in webkit [61171] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/8071866> REGRESSION: Crash on launch on Tiger and Leopard with network home folder

Reviewed by Brady Eidson.

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare): Don't assume that tail is always non-null, since that may
not be the case with some versions of SQLite. Instead we must null-check before dereferencing.

6:41 PM Changeset in webkit [61170] by andersca@apple.com
  • 2 edits in trunk/WebKit/chromium

Fix Chromium build.

  • src/WebPluginListBuilderImpl.cpp:

(WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):

6:37 PM Changeset in webkit [61169] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix Tiger build.

  • plugins/mac/PluginDataMac.mm:
6:30 PM Changeset in webkit [61168] by andersca@apple.com
  • 10 edits in trunk/WebCore

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Use an array for extensions in MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40602

Get rid of MimeClassInfo::suffixes and replace it with an array of extensions.

  • plugins/MimeType.cpp: (WebCore::MimeType::suffixes): Create a string of joined extensions.
  • plugins/MimeType.h:
  • plugins/PluginData.h: (WebCore::operator==):
  • plugins/chromium/PluginDataChromium.cpp: (WebCore::getPluginMimeTypeFromExtension):
  • plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
  • plugins/mac/PluginDataMac.mm: (WebCore::PluginData::initPlugins):
  • plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
  • plugins/win/PluginDataWin.cpp: (WebCore::PluginData::initPlugins):
  • plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins):
5:52 PM Changeset in webkit [61167] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-14 Adam Barth <abarth@webkit.org>

Unreviewed.

Add an include to try to fix Chromium build.

  • html/HTML5DocumentParser.cpp:
5:35 PM Changeset in webkit [61166] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.
Reorder build event to fix cygwin path issue.

  • win/WebKit2Generated.vcproj:
5:25 PM Changeset in webkit [61165] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-06-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Safari beach-balls loading large pages with HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40596

Implement parser yielding, similar to how the old
HTMLDocumentParser yields.

This implementation re-uses the tokenizerTimeDelay and
tokenizerChunkSize settings even though they don't map exactly
to the token loop that the HTML5 parser uses.

  • dom/DocumentParser.h:
    • Add a FIXME for processingData() and clarify how the appendData flag is used by renaming it to isFromNetwork.
  • html/HTML5DocumentParser.cpp: (WebCore::parserTimeLimit):
    • Defaults accessor, probably belongs on Page.

(WebCore::parserChunkSize):

  • Defaults accessor, probably belongs on Page.

(WebCore::HTML5DocumentParser::HTML5DocumentParser):
(WebCore::HTML5DocumentParser::stopParsing):

  • Stop the continue-parsing timer if active.

(WebCore::HTML5DocumentParser::processingData):

  • Implement this poorly understood accessor to match the old parser's behavior. It's unclear what this does and it does not affect any layout tests to my knowledge but likely affects the WebKit API in some way.

(WebCore::HTML5DocumentParser::pumpLexerIfPossible):

  • Pass SynchronousMode.
  • Do not ever pump if we've yielded to the timer.

(WebCore::HTML5DocumentParser::PumpSession::PumpSession):

  • A struct for storing the yield counters.

(WebCore::HTML5DocumentParser::shouldContinueParsing):

  • Mostly matches HTMLDocumentParser::shouldContinueParsing.

(WebCore::HTML5DocumentParser::pumpLexer):

  • Respect SynchronousMode.
  • ASSERT that a timer is not scheduled if we're pumping.

(WebCore::isLayoutTimerActive):

  • This belongs on Document.

(WebCore::HTML5DocumentParser::continueNextChunkTimerFired):
(WebCore::HTML5DocumentParser::write):
(WebCore::HTML5DocumentParser::end):

  • We should never end() if a timer is still outstanding.

(WebCore::HTML5DocumentParser::attemptToEnd):
(WebCore::HTML5DocumentParser::endIfDelayed):
(WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution):

  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::):
  • html/HTMLDocumentParser.cpp:
    • Clarify the old TimeDelay and ChunkSize constants.
5:20 PM Changeset in webkit [61164] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.
Add build failure stopping code.

  • win/WebKit2WebProcess.vcproj:
5:07 PM Changeset in webkit [61163] by abarth@webkit.org
  • 10 edits
    2 adds in trunk/WebCore

2010-06-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preload scanner for the HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40557

This patch adds a simple preload scanner for the HTML5 parser. This
preload scanner is not as awesome as the old one because it doesn't
scan CSS, but it's much simpler.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
    • Build file torture.
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::write):
    • Call into the preload scanner when waiting for a script.
  • html/HTML5DocumentParser.h:
  • html/HTML5PreloadScanner.cpp: Copied from WebCore/html/PreloadScanner.cpp. (WebCore::HTML5PreloadScanner::HTML5PreloadScanner): (WebCore::HTML5PreloadScanner::scan):
    • A simple loop to pump the preload scanner's lexer.

(WebCore::HTML5PreloadScanner::processToken):

  • Preload interesting resources. Stolen from the old preload scanner.

(WebCore::HTML5PreloadScanner::scanningBody):

  • html/HTML5PreloadScanner.h: Copied from WebCore/html/PreloadScanner.h.
5:00 PM Changeset in webkit [61162] by tony@chromium.org
  • 4 edits in trunk

2010-06-14 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Chromium shouldn't build inside the source directory
https://bugs.webkit.org/show_bug.cgi?id=40489

Ignore directories fetched by chromium and chromium mac output dir.

  • chromium: Added property svn:ignore.

2010-06-13 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Chromium shouldn't build inside the source directory
https://bugs.webkit.org/show_bug.cgi?id=40489

Ignore Chromium Linux build files.

  • .: Added property svn:ignore. Modified property svn:ignore.
4:58 PM Changeset in webkit [61161] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-06-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Constify some HTML5Token methods
https://bugs.webkit.org/show_bug.cgi?id=40592

I keep wanting these methods to be const. Eric wanted this in a
separate patch.

  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::state):
  • html/HTML5Token.h: (WebCore::HTML5Token::attributes): (WebCore::HTML5Token::name): (WebCore::HTML5Token::characters): (WebCore::HTML5Token::comment): (WebCore::HTML5Token::publicIdentifier): (WebCore::HTML5Token::systemIdentifier):
  • html/HTML5TreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5TreeBuilder::adjustedLexerState):
    • Technically, this might belong in the other patch, but I think it's fine here.

(WebCore::HTML5TreeBuilder::passTokenToLegacyParser):

  • html/HTML5TreeBuilder.h:
4:47 PM Changeset in webkit [61160] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.
Add build failure stopping code.

  • win/WebKit2Generated.vcproj:
4:11 PM Changeset in webkit [61159] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, more Chromium expectations updates.

  • platform/chromium/test_expectations.txt:
3:31 PM Changeset in webkit [61158] by dumi@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, build fix.

  • WebCore.xcodeproj/project.pbxproj:
3:27 PM Changeset in webkit [61157] by ap@apple.com
  • 2 edits in trunk/WebKitTools

Chromium build fix.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
3:27 PM Changeset in webkit [61156] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

Unreviewed, build fix.

Remove accidental specifying of the class name twice.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::prepareFormData): Removed my ghastly typo.

3:08 PM Changeset in webkit [61155] by adachan@apple.com
  • 3 edits in trunk/WebKit2

Rubber-stamped by Steve Falkenburg.

  • Fix the release configuration to use release.vsprops.
  • Add Debug_Internal and Debug_All configurations to the WebKit2WebProcess project.
  • Fix launchWebProcess() to get the right path to the WebKit2WebProcess executable.
  • UIProcess/Launcher/win/WebProcessLauncher.cpp: (WebKit::launchWebProcess):
  • win/WebKit2WebProcess.vcproj:
3:07 PM Changeset in webkit [61154] by dumi@chromium.org
  • 15 edits in trunk

Get DatabaseTracker ready for sync DBs.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

WebCore:

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::~AbstractDatabase):

  • storage/AbstractDatabase.h:
  • storage/Database.cpp:

(WebCore::Database::closeImmediately):

  • storage/Database.h:

(WebCore::Database::scriptExecutionContext):

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • storage/DatabaseTracker.h:
  • storage/OriginQuotaManager.cpp:

(WebCore::OriginQuotaManager::markDatabase):

  • storage/OriginQuotaManager.h:
  • storage/chromium/DatabaseObserver.h:
  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::TrackerRemoveOpenDatabaseTask::create):
(WebCore::TrackerRemoveOpenDatabaseTask::TrackerRemoveOpenDatabaseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):

WebKit/chromium:

  • public/WebDatabase.h:
  • src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):

  • src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):
(WebKit::WebDatabase::WebDatabase):
(WebKit::WebDatabase::operator=):
(WebKit::WebDatabase::operator WTF::PassRefPtr<AbstractDatabase>):

2:58 PM Changeset in webkit [61153] by ap@apple.com
  • 11 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=40529
eventSender.keyDown("delete") incorrectly sends a backspace on some platforms

WebCore:

  • platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use virtual key code to force correct character code for clarity. Also, reworded comment, since saying that "backspace needs to always be 8" misleadingly implied that it could "sometimes" be such without this code.

WebKitTools:

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken event for "delete" - it had virtual key code from forward delete, and text from backspace. Fixed "delete" to mean forward delete.
  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
  • DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Mac DRT confusion has propagated to other platforms, fixing those.

LayoutTests:

  • editing/deleting/forward-delete-key-expected.txt: Added.
  • editing/deleting/forward-delete-key.html: Added. Added a test for forward delete key working (particularly in DRT, since there was a lot of confusion between platform maintainers about it).
  • fast/forms/resources/input-live-pseudo-selectors.js:
  • fast/forms/resources/textarea-live-pseudo-selectors.js: These two tests expected that keyDown("delete") executed backward delete, changed them to send "\x08" for backspace.
2:51 PM Changeset in webkit [61152] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2010-06-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Refactor form submission code in HTMLFormElement to add clarity.
https://bugs.webkit.org/show_bug.cgi?id=39430

Covered by existing tests in fast/forms/mailto.

  • html/HTMLFormElement.cpp: (WebCore::appendMailtoPostFormDataToURL): Renamed from transferMailtoPostFormDataToUrl,

removed clearing out of the FormData and moved it to a new place (next to the call site).

(WebCore::HTMLFormElement::prepareFormData): Renamed from createFormData, moved the logic of

prepareing FormData here, including the use of appendMailtoPostFormDataToURL.

(WebCore::HTMLFormElement::submit): Consolidated multiple invocations of submitForm().

  • html/HTMLFormElement.h: Renamed createFormData to prepareFormData.
2:48 PM Changeset in webkit [61151] by Chris Fleizach
  • 8 edits in trunk

AX: need ListItemRole and PresentationalRole
https://bugs.webkit.org/show_bug.cgi?id=40133

Reviewed by Darin Adler.

WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isListItem):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):

WebKit/chromium:

  • public/WebAccessibilityRole.h:
  • src/AssertMatchingEnums.cpp:
2:45 PM Changeset in webkit [61150] by andersca@apple.com
  • 9 edits in trunk

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove pluginIndex from MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40588

  • src/WebPluginListBuilderImpl.cpp: (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin):

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove pluginIndex from MimeClassInfo
https://bugs.webkit.org/show_bug.cgi?id=40588

  • plugins/PluginData.h:
  • plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
  • plugins/mac/PluginDataMac.mm: (WebCore::PluginData::initPlugins):
  • plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
  • plugins/win/PluginDataWin.cpp: (WebCore::PluginData::initPlugins):
  • plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins):
2:41 PM Changeset in webkit [61149] by kinuko@chromium.org
  • 11 edits
    2 adds in trunk/WebCore

2010-06-14 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Implement BlobBuilder internal class for BlobBuilder support as defined in FileWriter
https://bugs.webkit.org/show_bug.cgi?id=36903

No new tests; they will be added when we add jsc bindings.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: Added.
  • html/BlobBuilder.h: Added. (WebCore::BlobBuilder::create):
  • platform/BlobItem.cpp: (WebCore::StringBlobItem::convertToCString): Added EndingNative support.
  • platform/BlobItem.h: Added EndingNative line-ending type. (WebCore::):
2:37 PM Changeset in webkit [61148] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, temporary update Chromium expectations after http://trac.webkit.org/changeset/61128

  • platform/chromium/test_expectations.txt:
2:13 PM Changeset in webkit [61147] by andersca@apple.com
  • 5 edits in trunk/WebCore

2010-06-14 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Stop using MimeClassInfo::pluginIndex
https://bugs.webkit.org/show_bug.cgi?id=40582

Add a pluginIndicies vector to PluginData and use it instead of MimeClassInfo::pluginIndex.

  • plugins/MimeType.cpp: (WebCore::MimeType::enabledPlugin): Get the plug-in index from the mimePluginIndices vector.


  • plugins/Plugin.cpp: (WebCore::Plugin::item): Compare the mime plugin index as well.


  • plugins/PluginData.cpp: (WebCore::PluginData::PluginData): Populate the m_mimePluginIndices vector.

(WebCore::PluginData::pluginNameForMimeType):
Get the plug-in index from the m_mimePluginIndices vector.

  • plugins/PluginData.h: (WebCore::operator==): Don't check for pluginIndex.

(WebCore::PluginData::mimePluginIndices):
Add getter for m_mimePluginIndices.

2:08 PM Changeset in webkit [61146] by weinig@apple.com
  • 2 edits in trunk/WebCore

Better build fix.

  • bindings/js/JSBindingsAllInOne.cpp:
2:06 PM Changeset in webkit [61145] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another windows build fix.

  • bindings/js/JSBindingsAllInOne.cpp:
2:03 PM Changeset in webkit [61144] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-14 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Small GtkLauncher build fix for some systems.

  • GtkLauncher/main.c: Add <limit.h> include.
1:54 PM Changeset in webkit [61143] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another build fix.

  • bindings/js/JSDOMWindowCustom.cpp:
1:45 PM Changeset in webkit [61142] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed fix. Platform specific expected results updated after r61136.

  • platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
1:09 PM Changeset in webkit [61141] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/RealtimeAnalyser.cpp

A little cleanup in realtime analyser code

1:09 PM Changeset in webkit [61140] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/Reverb.cpp

Handle edge case of reverb 1 -> 4 -> 2 matrixing

1:09 PM Changeset in webkit [61139] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

include config.h in MidSide

1:05 PM Changeset in webkit [61138] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/text/justify-padding-distribution.html fails
https://bugs.webkit.org/show_bug.cgi?id=40584

  • platform/qt/Skipped: fast/text/justify-padding-distribution.html skipped until fix.
12:51 PM Changeset in webkit [61137] by weinig@apple.com
  • 2 edits in trunk/WebCore

Add missing comma to fix GTK build.

  • xml/XSLTProcessor.idl:
12:46 PM Changeset in webkit [61136] by weinig@apple.com
  • 47 edits
    4 moves
    28 deletes in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=40581
Auto-generate most of the JS constructors

Reviewed by Alexey Proskuryakov.

WebCore:

  • Auto-generates all the JS constructors that don't have custom names (eg, Not Image(), Audio() or Option())
  • Fixes two typos.

(new XSLTConstructor()).toString() [object XSLTProcessorConsructor] -> [object XSLTProcessorConstructor])
(new EventSource()).toString() [object EventSourceContructor] -> [object EventSourceConstructor])

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSArrayBufferConstructor.cpp: Removed.
  • bindings/js/JSArrayBufferConstructor.h: Removed.
  • bindings/js/JSArrayBufferCustom.cpp: Copied from WebCore/bindings/js/JSArrayBufferConstructor.cpp.

(WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::constructArrayBufferView):

  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSEventSourceConstructor.cpp: Removed.
  • bindings/js/JSEventSourceConstructor.h: Removed.
  • bindings/js/JSEventSourceCustom.cpp: Copied from WebCore/bindings/js/JSEventSourceConstructor.cpp.

(WebCore::JSEventSourceConstructor::constructJSEventSource):

  • bindings/js/JSFloat32ArrayConstructor.cpp: Removed.
  • bindings/js/JSFloat32ArrayConstructor.h: Removed.
  • bindings/js/JSFloat32ArrayCustom.cpp:

(WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):

  • bindings/js/JSInt16ArrayConstructor.cpp: Removed.
  • bindings/js/JSInt16ArrayConstructor.h: Removed.
  • bindings/js/JSInt16ArrayCustom.cpp:

(WebCore::JSInt16ArrayConstructor::constructJSInt16Array):

  • bindings/js/JSInt32ArrayConstructor.cpp: Removed.
  • bindings/js/JSInt32ArrayConstructor.h: Removed.
  • bindings/js/JSInt32ArrayCustom.cpp:

(WebCore::JSInt32ArrayConstructor::constructJSInt32Array):

  • bindings/js/JSInt8ArrayConstructor.cpp: Removed.
  • bindings/js/JSInt8ArrayConstructor.h: Removed.
  • bindings/js/JSInt8ArrayCustom.cpp:

(WebCore::JSInt8ArrayConstructor::constructJSInt8Array):

  • bindings/js/JSMessageChannelConstructor.cpp: Removed.
  • bindings/js/JSMessageChannelConstructor.h: Removed.
  • bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannelConstructor::constructJSMessageChannel):

  • bindings/js/JSSharedWorkerConstructor.cpp: Removed.
  • bindings/js/JSSharedWorkerConstructor.h: Removed.
  • bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker):

  • bindings/js/JSUint16ArrayConstructor.cpp: Removed.
  • bindings/js/JSUint16ArrayConstructor.h: Removed.
  • bindings/js/JSUint16ArrayCustom.cpp:

(WebCore::JSUint16ArrayConstructor::constructJSUint16Array):

  • bindings/js/JSUint32ArrayConstructor.cpp: Removed.
  • bindings/js/JSUint32ArrayConstructor.h: Removed.
  • bindings/js/JSUint32ArrayCustom.cpp:

(WebCore::JSUint32ArrayConstructor::constructJSUint32Array):

  • bindings/js/JSUint8ArrayConstructor.cpp: Removed.
  • bindings/js/JSUint8ArrayConstructor.h: Removed.
  • bindings/js/JSUint8ArrayCustom.cpp:

(WebCore::JSUint8ArrayConstructor::constructJSUint8Array):

  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: Removed.
  • bindings/js/JSWebKitCSSMatrixConstructor.h: Removed.
  • bindings/js/JSWebKitCSSMatrixCustom.cpp: Copied from WebCore/bindings/js/JSWebKitCSSMatrixConstructor.cpp.

(WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):

  • bindings/js/JSWebKitPointConstructor.cpp: Removed.
  • bindings/js/JSWebKitPointConstructor.h: Removed.
  • bindings/js/JSWebKitPointCustom.cpp: Copied from WebCore/bindings/js/JSWebKitPointConstructor.cpp.

(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):

  • bindings/js/JSWebSocketConstructor.cpp: Removed.
  • bindings/js/JSWebSocketConstructor.h: Removed.
  • bindings/js/JSWebSocketCustom.cpp:

(WebCore::JSWebSocketConstructor::constructJSWebSocket):

  • bindings/js/JSWorkerConstructor.cpp: Removed.
  • bindings/js/JSWorkerConstructor.h: Removed.
  • bindings/js/JSWorkerContextCustom.cpp:
  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

  • bindings/js/JSXSLTProcessorConstructor.cpp: Removed.
  • bindings/js/JSXSLTProcessorConstructor.h: Removed.
  • bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):

  • bindings/scripts/CodeGeneratorJS.pm:
  • css/WebKitCSSMatrix.idl:
  • dom/MessageChannel.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • page/EventSource.idl:
  • page/WebKitPoint.idl:
  • websockets/WebSocket.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
  • xml/XSLTProcessor.idl:

LayoutTests:

  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/js/global-constructors-expected.txt:
12:11 PM Changeset in webkit [61135] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

2010-05-16 Antonio Gomes <tonikitoo@webkit.org>

Unreviewed naming fixes of local variables used in Spatial Navigation methods.

Summary:

  • "candidate" renamed to "node";
  • "currentFocusCandidate" renamed to "candidate"
  • "closestFocusCandidate" renamed to "closest"

That way naming is more consistent in the various Spatial Navigation methods.

  • page/FocusController.cpp: (WebCore::FocusController::findFocusableNodeInDirection): (WebCore::FocusController::deepFindFocusableNodeInDirection):
12:10 PM Changeset in webkit [61134] by tonikitoo@webkit.org
  • 5 edits
    4 adds in trunk

Spatial Navigation: make it work with focusable elements in overflow content
https://bugs.webkit.org/show_bug.cgi?id=36463

Reviewed by Simon Fraser and Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

This patch addresses the problem with Spatial Navigation. It currently does not
properly traverse scrollable contents, including scrollable div's. For this to work,
a new class member called scrollableEnclosingBox was introduced to FocusCandidate class which
keeps track of the current scrollable box Node wrapping a FocusCandidate.

To make use of enclosingScrollableBox of FocusCandidate, the DOM traversal routine
(FocusController::findNextFocusableInDirection) was changed as follows: when it
encounters a scrollable Node, each focusable node which is 'inner' keeps track of
the container reference. By the time a sibling of the scrollable Node is encountered,
there is no need to track this reference any more and the traversal algorithm continues
normally.

The common case is obviously that there is no scrollable container wrapping it.

updateFocusCandiditeIfCloser logic was also adapted to fit the need of the
newly introduced enclosingScrollableBox class member, getting simpler and more
easily maintainable.

Tests: fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html

fast/events/spatial-navigation/snav-clipped-overflow-content.html

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateInSameContainer):
(WebCore::updateFocusCandidateIfCloser):
(WebCore::FocusController::findFocusableNodeInDirection):
(WebCore::FocusController::deepFindFocusableNodeInDirection):

  • page/SpatialNavigation.cpp:

(WebCore::isScrollableContainerNode):

  • page/SpatialNavigation.h:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::FocusCandidate::inScrollableContainer):

LayoutTests:

  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html: Added.
  • fast/events/spatial-navigation/snav-clipped-overflow-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-clipped-overflow-content.html: Added.
11:59 AM Changeset in webkit [61133] by jianli@chromium.org
  • 7 edits in trunk/WebCore

Unreviewed. Fix build break in GTK.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
11:43 AM Changeset in webkit [61132] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: AXUnknown objects are being returned
https://bugs.webkit.org/show_bug.cgi?id=40574

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

  • platform/mac/accessibility/no-unknown-objects-when-title-attribute-present-expected.txt: Added.
  • platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html: Added.
11:34 AM Changeset in webkit [61131] by jianli@chromium.org
  • 29 edits in trunk/WebCore

Fix code generators to better support Conditional attribute and add test
coverage for it.
https://bugs.webkit.org/show_bug.cgi?id=39512

Reviewed by Darin Adler.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj conditionalAttr1]):
(-[DOMTestObj setConditionalAttr1:]):
(-[DOMTestObj conditionalAttr2]):
(-[DOMTestObj setConditionalAttr2:]):
(-[DOMTestObj conditionalAttr3]):
(-[DOMTestObj setConditionalAttr3:]):

  • bindings/scripts/test/TestInterface.idl:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestInterface.cpp:
  • bindings/scripts/test/V8/V8TestInterface.h:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::conditionalAttr1AttrGetter):
(WebCore::TestObjInternal::conditionalAttr1AttrSetter):
(WebCore::TestObjInternal::conditionalAttr2AttrGetter):
(WebCore::TestObjInternal::conditionalAttr2AttrSetter):
(WebCore::TestObjInternal::conditionalAttr3AttrGetter):
(WebCore::TestObjInternal::conditionalAttr3AttrSetter):
(WebCore::):

11:30 AM Changeset in webkit [61130] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

Bug 40576 - AX: need to update iframe-bastardization.html LayoutTest to be more modern
https://bugs.webkit.org/show_bug.cgi?id=40576

10:29 AM Changeset in webkit [61129] by eric@webkit.org
  • 26 edits in trunk

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip canvas/philip/tests/2d.shadow.enable.x.html
and canvas/philip/tests/2d.shadow.enable.y.html.

https://bugs.webkit.org/show_bug.cgi?id=40434

  • platform/qt/Skipped:

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Change the type of ShadowSize from IntSize to FloatSize in GraphicsContext.
Using IntSize loses precision and fails the test.
Note: This code change fixes Qt port but Mac is still failing due to
platform issue.

https://bugs.webkit.org/show_bug.cgi?id=40434

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::applyShadow):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::getShadow):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::calculateShadowBufferDimensions): (WebCore::drawPathShadow): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::strokePath): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow):
  • platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::drawText):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setPlatformShadow):

2010-06-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[win] Make windows compile after API changes.

https://bugs.webkit.org/show_bug.cgi?id=40434

  • WebKitGraphics.cpp: (WebDrawText):
10:06 AM Changeset in webkit [61128] by mitz@apple.com
  • 58 edits
    4 adds in trunk

<rdar://problem/7752961> Unevenly distributed space in justified text
https://bugs.webkit.org/show_bug.cgi?id=36105

Reviewed by Simon Fraser.

WebCore:

Test: fast/text/justify-padding-distribution.html

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Initialize m_padPerSpace to the quotient of the total
padding and the number of spaces rather than truncating it.
(WebCore::WidthIterator::advance): Subtract m_padPerSpace from m_padding and add the difference
between its old and new values, when rounded, to the advance.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/graphics/win/UniscribeController.h:

LayoutTests:

  • fast/text/justify-padding-distribution-expected.checksum: Added.
  • fast/text/justify-padding-distribution-expected.png: Added.
  • fast/text/justify-padding-distribution-expected.txt: Added.
  • fast/text/justify-padding-distribution.html: Added.
  • platform/mac/css1/box_properties/clear_float-expected.checksum:
  • platform/mac/css1/box_properties/clear_float-expected.png:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.png:
  • platform/mac/css1/text_properties/text_align-expected.checksum:
  • platform/mac/css1/text_properties/text_align-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.checksum:
  • platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.checksum:
  • platform/mac/fast/multicol/float-avoidance-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/mac/fast/text/atsui-spacing-features-expected.checksum:
  • platform/mac/fast/text/atsui-spacing-features-expected.png:
  • platform/mac/fast/text/justified-selection-at-edge-expected.checksum:
  • platform/mac/fast/text/justified-selection-at-edge-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
  • platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:
9:38 AM Changeset in webkit [61127] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Stack overflow when converting navigator object to QVariant
https://bugs.webkit.org/show_bug.cgi?id=40572

Protect against infinite recursion in JSValue->QVariant conversion.
This fixes a crash when trying to convert MimeType objects (they
recurse infinitely and on-the-fly via the enabledPlugin property.)

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):
9:27 AM Changeset in webkit [61126] by eric@webkit.org
  • 4 edits
    2 adds in trunk/WebCore

2010-06-14 Yong Li <yoli@rim.com>

Test cases created by: Robin Cao <robin.cao@torchmobile.com.cn>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=38910

Suspend Document::m_executeScriptSoonTimer objects when the page is deferred.
There's no reason why we suspend all active DOM timers on the page but not suspend
this one. Document::m_executeScriptSoonTimer can run JS and schedule more DOM Timers.

It can only be tested manually.

  • manual-tests/load-deferrer-script-element.html: Added.
  • manual-tests/resources/load-deferrer-script-element.js: Added.
  • dom/Document.cpp: (WebCore::Document::executeScriptSoon): (WebCore::Document::suspendExecuteScriptSoonTimer): Added. (WebCore::Document::resumeExecuteScriptSoonTimer): Added.
  • dom/Document.h:
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
8:23 AM Changeset in webkit [61125] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-14 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Rebaseline LayoutTests/platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt.
https://bugs.webkit.org/show_bug.cgi?id=40568

https://bugs.webkit.org/show_bug.cgi?id=39994 changed the test expectations, and we need to rebaseline.

  • platform/chromium/fast/dom/Geolocation/callback-exception-expected.txt:
8:13 AM Changeset in webkit [61124] by loislo@chromium.org
  • 2 edits in trunk/WebKit/gtk

2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

This is a fix for flaky inspector tests at gtk-debug bots.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorFrontendClient::destroyInspectorWindow):
8:07 AM Changeset in webkit [61123] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-06-14 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
7:31 AM Changeset in webkit [61122] by mitz@apple.com
  • 2 edits in trunk

Fixed a typo and reviewr information in ChangeLog files

7:09 AM Changeset in webkit [61121] by yael.aharon@nokia.com
  • 13 edits
    2 adds in trunk

[Qt] Platform plugin support for Notifications UI
https://bugs.webkit.org/show_bug.cgi?id=40005

Reviewed by Kenneth Rohde Christiansen.

WebCore:

To avoid race condition when GC is run during shutdown,
disconnect the Notification from the NotificationPresenter
when the presenter deletes itself.
This cannot be tested by a layout test, the race condition happens only
when GC is run during shutdown. It can be tested manually by loading
manually any notification test and closing the browser.

  • notifications/Notification.cpp:

(WebCore::Notification::~Notification):

  • notifications/Notification.h:

(WebCore::Notification::detachPresenter):

WebKit/qt:

Add an interface to the platform plugin to display notifications.
Implemented the notification in the example platform plugin.
This interface is enabled by default, but could be turned off with
a build flag. The platform plugin should control its own lifecycle,
so now the close timer applies only when using the QSystemTrayIcon.
That's because QSystemTrayIcon does not inform its caller when it
is closed.

Changed the way NotificationPresenterClientQt is deleted because it
is being accessed when GC is deleting the Notification objects.
NotificationPresenterClientQt is now detaching itself from the
Notifications before it is deleted.

  • Api/qwebkitplatformplugin.h:

(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebKitPlatformPlugin::):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationIconWrapper::NotificationIconWrapper):
(WebCore::NotificationIconWrapper::title):
(WebCore::NotificationIconWrapper::message):
(WebCore::NotificationIconWrapper::iconData):
(WebCore::NotificationPresenterClientQt::~NotificationPresenterClientQt):
(WebCore::NotificationIconWrapper::notificationClosed):
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationForWrapper):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::detachNotification):

  • WebCoreSupport/NotificationPresenterClientQt.h:
  • WebCoreSupport/QtPlatformPlugin.cpp:

(WebCore::QtPlatformPlugin::createNotificationPresenter):

  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebNotificationPresenter.cpp: Added.

(WebNotificationWidget::WebNotificationWidget):
(WebNotificationWidget::~WebNotificationWidget):
(WebNotificationWidget::showNotification):
(WebNotificationWidget::event):

  • examples/platformplugin/WebNotificationPresenter.h: Added.

(WebNotificationPresenter::WebNotificationPresenter):
(WebNotificationPresenter::~WebNotificationPresenter):
(WebNotificationPresenter::showNotification):

  • examples/platformplugin/WebPlugin.cpp:

(WebPlugin::supportsExtension):

  • examples/platformplugin/WebPlugin.h:

(WebPlugin::createNotificationPresenter):

  • examples/platformplugin/platformplugin.pro:
  • examples/platformplugin/qwebkitplatformplugin.h:

(QWebNotificationPresenter::QWebNotificationPresenter):
(QWebNotificationPresenter::~QWebNotificationPresenter):
(QWebKitPlatformPlugin::):

6:42 AM Changeset in webkit [61120] by bulach@chromium.org
  • 17 edits
    3 copies
    3 adds in trunk

2010-06-08 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds IndexedDB's KeyRange.
https://bugs.webkit.org/show_bug.cgi?id=40250

  • storage/indexeddb/idb-keyrange-expected.txt: Added.
  • storage/indexeddb/idb-keyrange.html: Added.
  • storage/indexeddb/script-tests/idb-keyrange.js: Added. (checkSingleKeyRange): (checkLeftBoundKeyRange): ():

2010-06-08 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Adds IndexedDB's KeyRange.
https://bugs.webkit.org/show_bug.cgi?id=40250

Test: storage/indexeddb/idb-keyrange.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/IDBKeyRange.cpp: Added. (WebCore::IDBKeyRange::IDBKeyRange):
  • storage/IDBKeyRange.h: Added. (WebCore::IDBKeyRange::): (WebCore::IDBKeyRange::create): (WebCore::IDBKeyRange::~IDBKeyRange): (WebCore::IDBKeyRange::left): (WebCore::IDBKeyRange::right): (WebCore::IDBKeyRange::flags):
  • storage/IDBKeyRange.idl: Added.
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::makeSingleKeyRange): (WebCore::IndexedDatabaseRequest::makeLeftBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeRightBoundKeyRange): (WebCore::IndexedDatabaseRequest::makeBoundKeyRange):
  • storage/IndexedDatabaseRequest.h:
  • storage/IndexedDatabaseRequest.idl:
6:28 AM Changeset in webkit [61119] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

And another.

  • storage/IndexedDatabaseRequest.h:
6:21 AM Changeset in webkit [61118] by jorlow@chromium.org
  • 4 edits in trunk

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

More build fixes.

  • storage/IndexedDatabaseRequest.h:

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Build fix.

  • src/IDBCallbacksProxy.h:
6:05 AM Changeset in webkit [61117] by Csaba Osztrogonác
  • 17 edits
    2 adds in trunk

[Qt] navigator.geolocation support for Qt port
https://bugs.webkit.org/show_bug.cgi?id=39724

Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-06-14
Reviewed by Laszlo Gombos.

WebCore:

Implemetion for Qt port of navigator.gelocation. Using qtmobility location service.

  • WebCore.pri:
  • WebCore.pro:
  • platform/qt/GeolocationServiceQt.cpp: Added.

(WebCore::GeolocationServiceQt::create):
(WebCore::GeolocationServiceQt::GeolocationServiceQt):
(WebCore::GeolocationServiceQt::~GeolocationServiceQt):
(WebCore::GeolocationServiceQt::positionUpdated):
(WebCore::GeolocationServiceQt::startUpdating):
(WebCore::GeolocationServiceQt::stopUpdating):

  • platform/qt/GeolocationServiceQt.h: Added.

(WebCore::GeolocationServiceQt::lastPosition):
(WebCore::GeolocationServiceQt::lastError):

WebKit/qt:

Implement ChromeClientQt::requestGeolocationPermissionForFrame() which delegates call to QWebPage::allowGeolocationRequest
Layout and unit test cases for the are also added.

  • Api/qwebpage.cpp:

(QWebPage::allowGeolocationRequest):

  • Api/qwebpage.h:
  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::shouldInterruptJavaScript):
(JSTestPage::allowGeolocationRequest):
(JSTestPage::setGeolocationPermission):
(tst_QWebPage::geolocationRequestJS):

WebKitTools:

Implementation for geolocation cases to DumpRenderTreeQt

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::allowGeolocationRequest):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setGeolocationPermission):
(LayoutTestController::setMockGeolocationError):
(LayoutTestController::setMockGeolocationPosition):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController::isGeolocationPermissionSet):
(LayoutTestController::geolocationPermission):

LayoutTests:

Uncommenting gelocation cases from Qt. Skipped one case: fast/dom/Geolocation/callback-to-remote-context2.html

  • platform/qt/Skipped:
5:57 AM Changeset in webkit [61116] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

2 more build fixes.

  • storage/IDBDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.h:
5:48 AM Changeset in webkit [61115] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Unreviewed build fix for my last.

  • workers/WorkerScriptLoaderClient.h:
5:35 AM Changeset in webkit [61114] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

[V8] Clean up SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=40482

SerializedScriptValue doesn't follow WebKit's style guidelines very well
and needlessly inlines quite a bit within the .h file. This change cleans
things up. No funcitonal changes.

No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::deserializeAndSetProperty): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::createFromWire): (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/SerializedScriptValue.h:
5:32 AM Changeset in webkit [61113] by loislo@chromium.org
  • 37 edits in trunk

2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
data from inspected page to WebInspector as JSON string via http. The native
serialization to JSON string is supported by InspectorValue's classes. This patch
has the implementation of sendMessageToFrontend function. WebKit version of it still
uses ScriptFunctionCall and will be switched to another transport a little bit later.
https://bugs.webkit.org/show_bug.cgi?id=40134

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::frontendLoaded):
  • inspector/InspectorValues.cpp: (WebCore::InspectorObject::writeJSON):
  • inspector/front-end/inspector.js: (WebInspector.dispatchMessageToFrontend):
  • loader/EmptyClients.h: (WebCore::EmptyInspectorClient::sendMessageToFrontend):
5:09 AM Changeset in webkit [61112] by eric@webkit.org
  • 13 edits in trunk

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Reenable IDBDatabaseRequest's description attribute
https://bugs.webkit.org/show_bug.cgi?id=39826

Existing test now fixed.

  • storage/indexeddb/idb-database-request-expected.txt:

2010-06-14 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

Reenable IDBDatabaseRequest's description attribute
https://bugs.webkit.org/show_bug.cgi?id=39826

On the 26th, Beth commented out the description attribute in
IDBDatabaseRequest because it was causing problems with the
objective c bindings. Turns out that this is the same bug as
in http://trac.webkit.org/changeset/19486. (Thanks for the
pointer, Mark!)

The solution is to change the objective C bindings generator
to change the name in the generated code. id and hash both
just appended "Name" to them in the past. I couldn't think
of anything else particularly better to append, so I just
went with name as well.

Test: building the world works on the first try. Layout

test verifies description works again.

  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_description): (webkit_dom_test_obj_get_id): (webkit_dom_test_obj_set_id): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjDescription): (WebCore::jsTestObjId): (WebCore::jsTestObjHash): (WebCore::setJSTestObjId):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj descriptionName]): (-[DOMTestObj idName]): (-[DOMTestObj setIdName:]): (-[DOMTestObj hashName]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::descriptionAttrGetter): (WebCore::TestObjInternal::idAttrGetter): (WebCore::TestObjInternal::idAttrSetter): (WebCore::TestObjInternal::hashAttrGetter): (WebCore::):
  • storage/IDBDatabaseRequest.idl:
12:55 AM Changeset in webkit [61111] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

[Qt] Update platform specific expected file after r61100.

  • platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
Note: See TracTimeline for information about the timeline view.