Timeline


and

06/21/10:

23:25 Changeset [61602] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.write from BeforeLoad should not assert
https://bugs.webkit.org/show_bug.cgi?id=40971

Test what happens when we document.write from a beforeload event.
Notice that the order is wrong. I'll fix that in a followup patch.

  • fast/tokenizer/write-before-load-expected.txt: Added.
  • fast/tokenizer/write-before-load.html: Added.

2010-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.write from BeforeLoad should not assert
https://bugs.webkit.org/show_bug.cgi?id=40971

We're setting the parse blocking script too early. It's not actually
blocking parsing yet.

Test: fast/tokenizer/write-before-load.html

  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::requestScript):
21:59 Changeset [61601] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, skip new modal tests on Tiger and update expected result for Chromium.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/mac-tiger/Skipped:
21:41 Changeset [61600] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing qt-specific expected results for r61599

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
21:24 Changeset [61599] by dimich@chromium.org
  • 54 edits
    6 adds
    7 deletes in trunk

DumpRenderTree should allow tests with modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=35350

Patch by Prasad Tammana <prasadt@chromium.org> on 2010-06-21
Reviewed by Darin Adler, Dmitry Titov.

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp:

(abortModalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::abortModal):
Add abortModal method to LayoutTestController and make it available from script.

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

LayoutTests:

Added a new test show-modal-dialog.html to harness tests to verify that showModalDialog works.

Added a new test, show-modal-dialog-onblur-onfocus.html, that takes advantage of the showModalDialog
functionality added to UIDelegate.mm. The test is only enabled on mac for now. This test will catch
regressions on the bug fix for https://bugs.webkit.org/show_bug.cgi?id=33962.

Support for showModalDialog affected the expected output for many tests that operate under the assumption
that the method is undefined. Modified the tests accordingly, in some cases disabled showModalDialog (not
currently tested anyway. Opened a bug to add showModalDialog specific tests where appropriate - Bug# 39897.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-frame-getter-precedence.html:
  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-name-getter-precedence.html:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:

Tweak tests so that showModalDialog part gets exercised only if its defined to keep output consistent across platforms.
Where its not possible, skip the test for showModalDialog, which is not currently exercised anyway.

  • fast/events/resources/modal-dialog.html: Added.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Added.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Added.
  • fast/harness/resources/modal-dialog.html: Added.
  • fast/harness/show-modal-dialog-expected.txt: Added.
  • fast/harness/show-modal-dialog.html: Added.

New tests that take advantage of showModalDialog in DRT.

  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt:

Update the expected output to reflect the fact that these tests pass now. Skip the tests on gtk, qt and win. They were all expected
to fail anyway. So no coverage lost.

  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put-expected.txt:

Skip showModalDialog to make test pass for all platforms. Added a FIXME with bug # to add a test specifically for showModalDialog.

  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • platform/chromium-mac/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/chromium-win/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.

Updaate expected output to reflect test changes. Removed some platform specific files where the only reason they're different is
because of showModalDialog.

  • platform/qt/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/win/Skipped:

Skip failing tests. Note that there is no test functionality lost. These are either new tests or tests that were dysfunctional anyway
in the absence of showModalDialog in DRT.

19:28 Changeset [61598] by morrita@google.com
  • 4 edits
    2 adds in trunk/WebKit/chromium

2010-06-21 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Dragging outside the frame immediately causes page to scroll
http://webkit.org/b/40461

This is regression that was introduced at http://webkit.org/b/39725.

There are 2 problems:

  1. It starts auto-scrolling immediately. We should have some delay.
  2. The scroll continues even after a mouse cursor goes outside a frame. The scroll should be stopped when the curosr has left.

This change introduced DragScrollTimer to handle 1.
At the same time, it fixed DragScrollTimer::scrollDistanceFor() to
handle 2, We now stop scrolling when the cursor gone.

  • WebKit.gyp:
  • src/DragScrollTimer.cpp: Added. (WebKit::distanceToRect): (WebKit::DragScrollTimer::DragScrollTimer): (WebKit::DragScrollTimer::~DragScrollTimer): (WebKit::DragScrollTimer::stop): (WebKit::DragScrollTimer::scroll): (WebKit::DragScrollTimer::update): (WebKit::DragScrollTimer::triggerScroll): (WebKit::DragScrollTimer::scrollDistanceFor):
  • src/DragScrollTimer.h: Added. (WebKit::DragScrollTimer::fired): (WebKit::DragScrollTimer::shouldScroll):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::dragSourceEndedAt): (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragTargetDrop): (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
  • src/WebViewImpl.h:
18:36 Changeset [61597] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

No review. QT build fix again.

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=40927

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

18:27 Changeset [61596] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

No review. QT build fix.

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=40927

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

18:07 Changeset [61595] by cfleizach@apple.com
  • 11 edits
    2 adds in trunk

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=40927

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/aria-expanded-notifications.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAriaExpandedChange):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::handleAriaExpandedChange):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::handleAriaExpandedChanged):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests:

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/accessibility/aria-expanded-notifications-expected.txt: Added.
  • platform/mac/accessibility/aria-expanded-notifications.html: Added.
17:33 Changeset [61594] by andersca@apple.com
  • 2 edits in trunk/WebKit2

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Support reading plug-in info from Carbon resources
https://bugs.webkit.org/show_bug.cgi?id=40959

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::ResourceMap::ResourceMap): (WebKit::ResourceMap::~ResourceMap): (WebKit::ResourceMap::isValid): (WebKit::getStringListResource): (WebKit::getPluginInfoFromCarbonResources): (WebKit::PluginInfoStore::getPluginInfo):
17:23 Changeset [61593] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):

17:07 Changeset [61592] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix an off-by-one bug I introduced.

Reviewed by Sam Weinig.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage getPluginInfoFromResources]):

17:00 Changeset [61591] by andersca@apple.com
  • 4 edits
    1 add in trunk/WebKit2

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Have PluginInfoStoreMac actually get plug-in info and populate the plug-in list
https://bugs.webkit.org/show_bug.cgi?id=40957

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::loadPluginsIfNecessary): (WebKit::PluginInfoStore::loadPluginsInDirectory): (WebKit::PluginInfoStore::loadPlugin): (WebKit::PluginInfoStore::getPlugins):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: Added. (WebKit::PluginInfoStore::pluginDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::getPluginArchitecture): (WebKit::getPluginInfoFromPropertyLists): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebKit2.xcodeproj/project.pbxproj:
16:42 Changeset [61590] by weinig@apple.com
  • 5 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.

Reviewed by Anders Carlsson.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
16:29 Changeset [61589] by simon.fraser@apple.com
  • 8 edits
    8 moves in trunk/WebKit2

2010-06-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=40948

Rename UIProcess version of DrawingAreaUpdateChunk to ChunkedUpdateDrawingAreaProxy,
and rename the Mac/Win versions of the various DrawingArea files too.

Also rename the DrawingAreaUpdateChunkType enum to ChunkedUpdateDrawingAreaType.

16:17 Changeset [61588] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

2010-06-21 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make JSC more resilient in the face of parse failures
https://bugs.webkit.org/show_bug.cgi?id=40951

A number of recent bugs have occurred due to issues like miscounting
BOMs, etc which lead to interesting crashes later on. Adding this
logic hardens JSC in the face of these errors, and has no impact on
performance (32bit jit actually gets 0.7% faster but I put that down
to cache effects).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::lineNumberForBytecodeOffset): (JSC::CodeBlock::expressionRangeForBytecodeOffset): (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::bytecodeOffset):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::prepareForRepeatCall): (JSC::Interpreter::privateExecute):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/ArrayPrototype.cpp: (JSC::isNumericCompareFunction):
  • runtime/Executable.cpp: (JSC::FunctionExecutable::compileForCall): (JSC::FunctionExecutable::compileForConstruct): (JSC::FunctionExecutable::generateJITCodeForCall): (JSC::FunctionExecutable::generateJITCodeForConstruct): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo):
  • runtime/Executable.h: (JSC::FunctionExecutable::bytecodeForCall): (JSC::FunctionExecutable::bytecodeForConstruct):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::numericCompareFunction):
16:00 Changeset [61587] by andersca@apple.com
  • 6 edits
    4 adds in trunk/WebKit2

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PluginInfoStore class
https://bugs.webkit.org/show_bug.cgi?id=40949

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::WebPreferencesStore):
  • Shared/WebPreferencesStore.h: (WebKit::WebPreferencesStore::encode): (WebKit::WebPreferencesStore::decode): Add plugInsEnabled to the preferences store.
  • UIProcess/Plugins: Added.
  • UIProcess/Plugins/PluginInfoStore.cpp: Added. (WebKit::PluginInfoStore::shared): (WebKit::PluginInfoStore::PluginInfoStore): (WebKit::PluginInfoStore::refresh): (WebKit::PluginInfoStore::getPlugins):
  • UIProcess/Plugins/PluginInfoStore.h: Added.
  • UIProcess/Plugins/mac: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):
15:57 Changeset [61586] by kinuko@chromium.org
  • 34 edits in trunk

2010-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61585.
http://trac.webkit.org/changeset/61585
https://bugs.webkit.org/show_bug.cgi?id=40950

It broke builds (Requested by kinuko on #webkit).

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::appendString): (WebCore::BlobBuilder::appendBlob):
  • html/BlobBuilder.h:
  • page/DOMWindow.idl:

2010-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61585.
http://trac.webkit.org/changeset/61585
https://bugs.webkit.org/show_bug.cgi?id=40950

It broke builds (Requested by kinuko on #webkit).

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
15:41 Changeset [61585] by kinuko@chromium.org
  • 34 edits in trunk

2010-06-21 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
https://bugs.webkit.org/show_bug.cgi?id=40593

BlobBuilder is defined in FileAPI's FileWriter spec.
(http://dev.w3.org/2009/dap/file-system/file-writer.html)

Also removes the ENABLE_FILE_WRITER ifdef guard for BlobBuilder.

Tests: http/tests/local/blob/send-data-blob.html

http/tests/local/blob/send-hybrid-blob.html
http/tests/local/blob/send-sliced-data-blob.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::append):
  • html/BlobBuilder.h:
  • html/BlobBuilder.idl: Added.
  • page/DOMWindow.idl:

2010-06-21 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
https://bugs.webkit.org/show_bug.cgi?id=40593

Add new layout tests to test BlobBuilder interface.
Also update test expectations affected by adding the constructors to DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/blob/resources/hybrid-blob-util.js: Added.
  • http/tests/local/blob/script-tests/TEMPLATE.html: Added.
  • http/tests/local/blob/script-tests/send-data-blob.js: Added.
  • http/tests/local/blob/script-tests/send-hybrid-blob.js: Added.
  • http/tests/local/blob/script-tests/send-sliced-data-blob.js: Added.
  • http/tests/local/blob/send-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-data-blob.html: Added.
  • http/tests/local/blob/send-hybrid-blob-expected.txt: Added.
  • http/tests/local/blob/send-hybrid-blob.html: Added.
  • http/tests/local/blob/send-sliced-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-sliced-data-blob.html: Added.
  • http/tests/local/resources/file-for-drag-to-send2.txt: Added.
  • http/tests/resources/post-and-verify-hybrid.cgi: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
15:33 Changeset [61584] by japhet@chromium.org
  • 25 edits
    2 adds in trunk

2010-06-21 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

FrameLoader cleanup: Split high level subframe and plugin
loading functions into a separate class.
https://bugs.webkit.org/show_bug.cgi?id=40453

Refactor only, no new tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMImplementation.cpp:
  • history/PageCache.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLMediaElement.cpp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: (WebCore::FrameLoader::subframeLoader):
  • loader/PluginDocument.cpp:
  • loader/SubframeLoader.cpp: Added. (WebCore::SubframeLoader::SubframeLoader): (WebCore::toPlugInElement): (WebCore::SubframeLoader::clear): (WebCore::SubframeLoader::requestFrame): (WebCore::SubframeLoader::requestObject): (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::allowPlugins): (WebCore::SubframeLoader::shouldUsePlugin): (WebCore::SubframeLoader::loadPlugin): (WebCore::SubframeLoader::completeURL):
  • loader/SubframeLoader.h: Added. (WebCore::SubframeLoader::containsPlugins):
  • page/Page.cpp:
  • page/XSSAuditor.h:
  • platform/graphics/wince/MediaPlayerProxy.cpp:
  • plugins/MimeType.cpp:
  • rendering/RenderApplet.cpp:
  • rendering/RenderEmbeddedObject.cpp:
15:22 Changeset [61583] by simon.fraser@apple.com
  • 9 edits
    2 moves in trunk

2010-06-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=40948

Rename DrawingAreaUpdateChunk to ChunkedUpdateDrawingArea.

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:pageNamespaceRef:]):
  • UIProcess/ChunkedUpdateDrawingArea.cpp: Added. (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::~ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::paint): (WebKit::ChunkedUpdateDrawingArea::setSize): (WebKit::ChunkedUpdateDrawingArea::setPageIsVisible): (WebKit::ChunkedUpdateDrawingArea::didSetSize): (WebKit::ChunkedUpdateDrawingArea::update): (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
  • UIProcess/ChunkedUpdateDrawingArea.h: Added. (WebKit::ChunkedUpdateDrawingArea::encode):
  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: Removed.
  • UIProcess/DrawingAreaProxyUpdateChunk.h: Removed.
  • UIProcess/mac/DrawingAreaProxyUpdateChunkMac.mm: (WebKit::ChunkedUpdateDrawingArea::page): (WebKit::ChunkedUpdateDrawingArea::ensureBackingStore): (WebKit::ChunkedUpdateDrawingArea::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingArea::platformPaint): (WebKit::ChunkedUpdateDrawingArea::drawUpdateChunkIntoBackingStore):
  • UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp: (WebKit::ChunkedUpdateDrawingArea::page): (WebKit::ChunkedUpdateDrawingArea::ensureBackingStore): (WebKit::ChunkedUpdateDrawingArea::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingArea::platformPaint): (WebKit::ChunkedUpdateDrawingArea::drawUpdateChunkIntoBackingStore):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView):
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
15:09 Changeset [61582] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Another Tiger build fix.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

14:40 Changeset [61581] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

More WebBasePluginPackage cleanup
https://bugs.webkit.org/show_bug.cgi?id=40944

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::pluginCancelledConnectionError):
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::pluginCancelledConnectionError):
  • Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::pluginName):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage finalize]): (-[WebBasePluginPackage pluginInfo]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:WebCore::]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage isJavaPlugIn]): (-[WebBasePluginPackage versionNumber]): (-[WebBasePluginPackage WebCore::]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _initWithPath:]): (-[WebNetscapePluginPackage _applyDjVuWorkaround]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage supportsSnapshotting]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage load]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
14:39 Changeset [61580] by robert@webkit.org
  • 4 edits in trunk

2010-06-21 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html

It's a Mac-specific test so just add the required LayoutTestController
function as a no-op to avoid failing. Similar approach adopted by other
ports.

https://bugs.webkit.org/show_bug.cgi?id=33344

  • platform/qt/Skipped:

2010-06-21 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html

It's a Mac-specific test so just add the required LayoutTestController
function as a no-op to avoid failing. Similar approach adopted by other
ports.

https://bugs.webkit.org/show_bug.cgi?id=33344

  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::addDisallowedURL):
14:36 Changeset [61579] by weinig@apple.com
  • 21 edits
    3 adds in trunk

Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
Add message passing support to the WebKit2 API.

Reviewed by Anders Carlsson.

WebKit2:

Adds message passing for both InjectedBundle -> WebContext
and WebContext -> InjectedBundle.

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: Added.

(WebProcessProxyMessage::):
(CoreIPC::):

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetInjectedBundleClient):
(WKContextPostMessageToInjectedBundle):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeInjectedBundleClient):
(WebKit::WebContext::forwardMessageToWebContext):
(WebKit::WebContext::postMessageToInjectedBundle):

  • UIProcess/WebContext.h:
  • UIProcess/WebContextInjectedBundleClient.cpp: Added.

(WebKit::WebContextInjectedBundleClient::WebContextInjectedBundleClient):
(WebKit::WebContextInjectedBundleClient::initialize):
(WebKit::WebContextInjectedBundleClient::didRecieveMessageFromInjectedBundle):

  • UIProcess/WebContextInjectedBundleClient.h: Added.
  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::processDidClose):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveInjectedBundleMessage):
(WebKit::WebProcessProxy::didReceiveMessage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostMessage):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::didCreatePage):
(WebKit::InjectedBundle::didRecieveMessage):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::loadInjectedBundle):
(WebKit::WebProcess::forwardMessageToInjectedBundle):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:

WebKitTools:

  • Add some test messages.
  • MiniBrowser/mac/AppDelegate.m:

(_didRecieveMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didClearWindow):
(_didCreatePage):
(_didRecieveMessage):
(WKBundleInitialize):

14:07 Changeset [61578] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-21 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Missing forward entries when dumping back/forward list

These now pass.
https://bugs.webkit.org/show_bug.cgi?id=32470

http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html
http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html

  • platform/qt/Skipped:
14:01 Changeset [61577] by sullivan@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixed bugzilla URL in previous checkin.

13:59 Changeset [61576] by sullivan@apple.com
  • 2 edits in trunk/JavaScriptCore

RetainPtr can't be used in HashMaps or HashSets
<https://bugs.webkit.org/post_bug.cgi>

Reviewed by Adam Roben.

Added hashing knowledge similar to that in COMPtr.h.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::RetainPtr):
New function, copied from COMPtr.h but for the type change.
(WTF::RetainPtr::isHashTableDeletedValue):
Ditto.
(WTF::RetainPtr::hashTableDeletedValue):
Ditto.
Added template code for HashTraits and PtrHash copied from COMPtr.h but for the type change.
The only difference is that constructDeletedValue() matches the RefPtr implementation (in HashTraits.h)
rather than the COMPtr implementation.

13:59 Changeset [61575] by robert@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-21 Robert Hogan <robert@webkit.org>

[Qt] Build fix for Qt on Windows MSVC2008

Unreviewed, build fix.

Fix by Jocelyn Turcotte.

  • Api/qwebframe.cpp:
13:50 Changeset [61574] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Another PowerPC build fix.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage openResourceFile]):
(-[WebNetscapePluginPackage _tryLoad]):

13:48 Changeset [61573] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Mark hyphenation tests as failing on Chromium
Hyphenation landed in http://trac.webkit.org/changeset/61548.

  • platform/chromium/test_expectations.txt: Added failing tests.
13:40 Changeset [61572] by japhet@chromium.org
  • 2 edits in trunk/WebKit/win

2010-06-21 Nate Chapin <japhet@chromium.org>

Unreviewed, Windows build fix.

Update WebFrame to use FrameLoaderStateMachine in

firstLayoutDone().

  • WebFrame.cpp: (WebFrame::firstLayoutDone):
13:32 Changeset [61571] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Try to fix the PowerPC build.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

13:26 Changeset [61570] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing a test expectations on Windows.

  • platform/win/fast/dom/prototype-inheritance-expected.txt:
13:20 Changeset [61569] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2010-06-21 Nate Chapin <japhet@chromium.org>

Unreviewed, build fix.

Bad merge, left a reference to m_committedFirstRealDocumentLoad in
http://trac.webkit.org/changeset/61568.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):
13:06 Changeset [61568] by japhet@chromium.org
  • 19 edits
    2 adds in trunk

2010-06-21 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Remove a couple of FrameLoader's unused boolean members
(m_receivedData, m_cancellingWithLoadInProcess) and merge
several more into a single state machine called FrameLoaderStateMachine
(m_firstLayoutDone, m_creatingInitialEmptyDocument,
m_isDisplayingInitialEmptyDocument, m_committedFirstRealDocumentLoad).

https://bugs.webkit.org/show_bug.cgi?id=39695

Refactor only, so no new tests.

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): (WebCore::DocumentWriter::begin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::logCanCachePageDecision): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::frameHasLoaded): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::dispatchDidCommitLoad):
  • loader/FrameLoader.h: (WebCore::FrameLoader::stateMachine):
  • loader/FrameLoaderStateMachine.cpp: Added.
  • loader/FrameLoaderStateMachine.h: Added.
  • loader/HistoryController.cpp: (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::saveDocumentState):
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission):
12:58 Changeset [61567] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Build fix after conversion of WebInterfaceSystem to Obj-C++.

12:57 Changeset [61566] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix. Fix header includes for ENABLE(DATABASE)

12:22 Changeset [61565] by dglazkov@chromium.org
  • 2 edits in trunk/WebKit/mac

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Dan Bernstein.

Chromium/Mac build fix.

  • WebCoreSupport/WebSystemInterface.mm: Change the order of wtf/Platform.h include to let other

headers smell it.

12:11 Changeset [61564] by atwilson@chromium.org
  • 47 edits
    6 deletes in trunk

WebKitTools: Unreviewed.

Rolling back 61551 and 61555 due to test failures.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setEditingBehavior):

  • DumpRenderTree/mac/UIDelegate.mm:

LayoutTests: Unreviewed rollback.

Rolling back 61551 and 61555 due to test failures on Linux/Win.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-frame-getter-precedence.html:
  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-name-getter-precedence.html:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/events/resources/modal-dialog.html: Removed.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Removed.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Removed.
  • fast/harness/resources/modal-dialog.html: Removed.
  • fast/harness/show-modal-dialog-expected.txt: Removed.
  • fast/harness/show-modal-dialog.html: Removed.
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
11:57 Changeset [61563] by andersca@apple.com
  • 11 edits in trunk

WebKit2: Make WebKit2 build with clang++

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView keyUp:]):
(-[WKView keyDown:]):

  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:

WebKitTools: Make DumpRenderTree build with clang++

Reviewed by Sam Weinig.

  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:

(-[LocalPasteboard setPropertyList:forType:]):

  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow keyDown:]):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::elementDoesAutoCompleteForElementWithId):
(LayoutTestController::isCommandEnabled):

11:41 Changeset [61562] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

Make all of WebKit build with clang++

Reviewed by Dan Bernstein.

  • DefaultDelegates/WebDefaultPolicyDelegate.m:

(-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setSuppressLayout:]):

  • WebView/WebHTMLRepresentation.mm:
  • WebView/WebNavigationData.mm:

(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):

  • WebView/WebPDFRepresentation.mm:

(-[WebPDFRepresentation setDataSource:]):
(-[WebPDFRepresentation receivedData:withDataSource:]):
(-[WebPDFRepresentation receivedError:withDataSource:]):

  • WebView/WebResource.mm:

(-[WebResource description]):

  • WebView/WebSerializedJSValue.mm:

(-[WebSerializedJSValue initWithValue:context:exception:]):

  • WebView/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController WebCore::]):
(-[WebVideoFullscreenController setMediaElement:WebCore::]):
(-[WebVideoFullscreenController setDelegate:]):
(-[WebVideoFullscreenController enterFullscreen:]):

  • WebView/WebView.mm:

(-[WebView _openFrameInNewWindowFromMenu:]):
(-[WebView _geolocationDidChangePosition:]):

11:38 Changeset [61561] by mitz@apple.com
  • 2 edits in trunk/WebKitLibraries

Speculative build fix.

  • WebKitSystemInterface.h:
11:29 Changeset [61560] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix clang++ build.

  • loader/FormSubmission.h:
11:19 Changeset [61559] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Add a missing include in AsyncImageResizer.h

  • html/AsyncImageResizer.h: Added the IntSize include.
11:02 Changeset [61558] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove unused dictionary ivars from WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40928

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10:51 Changeset [61557] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations tweak.

Use C++-style comments rather than Python-style.

  • platform/chromium/test_expectations.txt: Tweaked comment style.
10:46 Changeset [61556] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

10:44 Changeset [61555] by atwilson@chromium.org
  • 6 adds in trunk/LayoutTests/fast

2010-06-21 Drew Wilson <atwilson@chromium.org>

Unreviewed.

Missing files from r61551.

  • fast/events/resources/modal-dialog.html: Added.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Added.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Added.
  • fast/harness/resources/modal-dialog.html: Added.
  • fast/harness/show-modal-dialog-expected.txt: Added.
  • fast/harness/show-modal-dialog.html: Added.
10:43 Changeset [61554] by aroben@apple.com
  • 2 edits in trunk/WebCore

Call NotifyAddrChange again each time we are notified of a change

NotifyAddrChange only notifies you of a single change. If you want to
listen for subsequent changes, you have to call it again.

Fixes <http://webkit.org/b/33004> NetworkStateNotifier ignores all
state changes after the first.

No test possible, as we don't have a way to modify the system's
network adapters when running tests.

Reviewed by Anders Carlsson.

  • platform/network/win/NetworkStateNotifierWin.cpp:

(WebCore::NetworkStateNotifier::addrChangeCallback): Call
registerForAddressChange as soon as we're notified of an address
change, so we'll also get notified of the *next* address change. I
added the call here instead of in addressChanged (which is called
later on the main thread) to minimize the time between the callback
and registering again (so that we won't miss changes that happen in
rapid succession).

10:43 Changeset [61553] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-06-19 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Need to ensure that we grow the RegisterFile when creating a callframe for host code
https://bugs.webkit.org/show_bug.cgi?id=40858
<rdar://problem/8108986>

In the past the use of the callframe in hostcode was much more
limited. Now that we expect the callframe to always be valid
we need to grow the RegisterFile so that this is actually the
case. In this particular case the problem was failing to grow
the registerfile could lead to a callframe that extended beyond
RegisterFiler::end(), so vm re-entry would clobber the callframe
other scenarios could also lead to badness.

I was unable to construct a simple testcase to trigger badness,
and any such testcase would be so dependent on exact vm stack
layout that it would be unlikely to work as a testcase following
any callframe or register allocation changes anyway.

Thankfully the new assertion I added should help to catch these
failures in future, and triggers on a couple of tests currently.

  • interpreter/CallFrame.cpp: (JSC::CallFrame::registerFile):
  • interpreter/CallFrame.h: (JSC::ExecState::init):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
10:21 Changeset [61552] by mitz@apple.com
  • 2 edits in trunk/WebCore

Release build fix

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating):

10:17 Changeset [61551] by atwilson@chromium.org
  • 47 edits in trunk

DumpRenderTree should allow tests with modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=35350

Patch by Prasad Tammana <prasadt@chromium.org> on 2010-06-21
Reviewed by Darin Adler.

  • DumpRenderTree/LayoutTestController.cpp:

(abortModalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::abortModal):
Add abortModal method to LayoutTestController and make it available from script.

.:

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

WebKitTools:

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

10:14 Changeset [61550] by leandro@webkit.org
  • 2 edits in trunk

2010-06-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed debug build fix.

[CMake] Do not force build type to Release
https://bugs.webkit.org/show_bug.cgi?id=40566

  • CMakeLists.txt:
10:07 Changeset [61549] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Fixed a typo.
09:54 Changeset [61548] by mitz@apple.com
  • 42 edits
    12 adds in trunk

WebCore: CSS3: Implement the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

Tests: fast/text/hyphenate-character.html

fast/text/hyphens.html

Added -webkit-hyphens and -webkit-hyphenate-character as specified in
<http://www.w3.org/TR/2010/WD-css3-gcpm-20100608/#hyphenation>.

  • Android.mk: Added Hyphenation.cpp.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Added Hyphenation.{cpp,h}.
  • WebCore.base.exp: Exported wkGetHyphenationLocationBeforeIndex().
  • WebCore.gypi: Added Hyphenation.{cpp,h}.
  • WebCore.pro: Added Hyphenation.{cpp,h}.
  • WebCore.vcproj/WebCore.vcproj: Added Hyphenation.{cpp,h}.
  • WebCore.xcodeproj/project.pbxproj: Added Hyphenation.{cpp,h}.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added the -webkit-hyphenate-character
and -webkit-hyphens cases.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Validate values for the new properties.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added. Maps from a Hyphens value to an identifier.
(WebCore::CSSPrimitiveValue::operator Hyphens): Added. Maps from an identifier to a Hyphens value.

  • css/CSSPropertyNames.in: Added -webkit-hyphenate-character and -webkit-hyphens.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Apply the new properties to the RenderStyle.

  • css/CSSValueKeywords.in:
  • platform/mac/WebCoreSystemInterface.h: Added wkGetHyphenationLocationBeforeIndex.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • platform/text/CharacterNames.h: Added the hyphen character.
  • platform/text/Hyphenation.cpp: Added.

(WebCore::lastHyphenLocation): Added this default implementation for platforms that do not implement
hyphenation yet. It calls notImplemented() and returns 0.

  • platform/text/Hyphenation.h: Added.
  • platform/text/cf/HyphenationCF.cpp: Added.

(WebCore::lastHyphenLocation): Returns the last hyphenation location occurring in the given string before
the given index. Uses the current search locale (which is based on the top language preference of the user)
for hyphenation.

  • platform/text/mac/HyphenationMac.mm: Added.

(WebCore::lastHyphenLocation): Returns the last hyphenation location occurring in the given string before
the given index. Returns 0 if the current search locale is not "en", because the platform only knows how to
hyphenate English.

  • rendering/BidiRun.h:

(WebCore::BidiRun::BidiRun): Added a boolean member, m_hasHyphen, and initialized it to false in the constructor.

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox): Renamed m_hasEllipsisBox to m_hasEllipsisBoxOrHyphen, because this bit is now
shared by two subclass: RootInlineBox uses it for hasEllipsisBox(), while InlineTextBox uses it for hasHyphen().

  • rendering/InlineTextBox.cpp:

(WebCore::adjustCharactersAndLengthForHyphen): Added this helper function to get the hyphen string from the style
and return a UChar* and length for the concatenation of the given text with the hyphen string.
(WebCore::InlineTextBox::selectionRect): If the selected range touches the end and the box has a hyphen,
compute the width of the text with the hyphen string concatenated to it.
(WebCore::InlineTextBox::paint): If the box has a hyphen, draw the text with the hyphen string concatenated to it.
(WebCore::InlineTextBox::paintSelection): Similarly concatenate the hyphen string.

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::hasHyphen): Added this accessor.
(WebCore::InlineTextBox::setHasHyphen): Ditto.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::constructLine): Copy the m_hasHyphen flag from the run to its text box.
(WebCore::RenderBlock::computeHorizontalPositionsForLine): Add the width of the hyphen string when computing the
width of a box that has a hyphen.
(WebCore::RenderBlock::layoutInlineChildren): If the line was hyphenated, set the m_hasHyphen flag on the
logically last run.
(WebCore::tryHyphenating): Added this helper function which checks if a piece of text that does not fit on the
line could be hyphenated such that the part before the hyphen, including the hyphen, would fit. Given the amount
of space remaining on the line, it finds the longest prefix that can fit in the remaining space (which leaving room for
the hyphen), and then checks for a hyphenation location within that prefix.
(WebCore::RenderBlock::findNextLineBreak): In the 'hyphens: none' case, prevent line breaks at soft hyphens.
In the 'hyphens: auto' case, try hyphenating when a word will not fit in the remaining space on the line.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::detachEllipsisBox): Changed to use hasEllipsisBox() and setHasEllipsisBox().
(WebCore::RootInlineBox::clearTruncation): Ditto.
(WebCore::RootInlineBox::placeEllipsis): Ditto.
(WebCore::RootInlineBox::paintEllipsisBox): Ditto.
(WebCore::RootInlineBox::nodeAtPoint): Ditto.
(WebCore::RootInlineBox::ellipsisBox): Ditto.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasEllipsisBox): Added this accessor.
(WebCore::RootInlineBox::setHasEllipsisBox): Ditto.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Return a layout hint if the hyphens setting or hyphenate-character differs.
(WebCore::RenderStyle::hyphenString): Added. For hyphenate-character: auto, returns the hyphen character.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphens): Added this accessor.
(WebCore::InheritedFlags::hyphenateCharacter): Ditto.
(WebCore::InheritedFlags::setHyphens): Ditto.
(WebCore::InheritedFlags::setHyphenateCharacter): Ditto.
(WebCore::InheritedFlags::initialHyphens): Added. Returns HyphensManual.
(WebCore::InheritedFlags::initialHyphenateCharacter): Added. Returns the null string, corresponding to
a value of 'auto'.

  • rendering/style/RenderStyleConstants.h:

Added a Hyphens enum.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize and copy the new members.
(WebCore::StyleRareInheritedData::operator==): Compare the new members.

  • rendering/style/StyleRareInheritedData.h: Added two new members: hyphens and hyphenateCharacter.

WebKit/mac: WebKit part of implementing the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkGetHyphenationLocationBeforeIndex.

WebKitLibraries: WebKitSystemInterface part of CSS3: Implement the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • WebKitSystemInterface.h: Added WKGetHyphenationLocationBeforeIndex().
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

LayoutTests: Added tests for the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • fast/text/hyphenate-character.html: Added.
  • fast/text/hyphens.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/fast/text/hyphenate-character-expected.checksum: Added.
  • platform/mac/fast/text/hyphenate-character-expected.png: Added.
  • platform/mac/fast/text/hyphenate-character-expected.txt: Added.
  • platform/mac/fast/text/hyphens-expected.checksum: Added.
  • platform/mac/fast/text/hyphens-expected.png: Added.
  • platform/mac/fast/text/hyphens-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:
09:39 Changeset [61547] by dglazkov@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Enable EVENTSOURCE, FILE_WRITER, and IMAGE_RESIZER
https://bugs.webkit.org/show_bug.cgi?id=40905

EVENTSOURCE: It is already enabled in Chromium browser. This fixes
some tests with Chromium DRT.

FILE_WRITER and IMAGE_RESIZER: Enable experimental features in
order to test them before enabling them in Chromium browser.

  • features.gypi:
09:36 Changeset [61546] by dglazkov@chromium.org
  • 7 edits in trunk/WebCore

2010-06-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Plumb FormSubmission through to ScheduledFormSubmission.
https://bugs.webkit.org/show_bug.cgi?id=40137

No behavior change, covered by existing tests.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission): Moved creation of action URL

instance here from FrameLoader::submit, because it makes more sense here,
also added a FIXME to investigate existing code later.

  • loader/FormSubmission.cpp: (WebCore::FormSubmission::FormSubmission): Changed action to be a KURL, not a String. (WebCore::FormSubmission::create): Ditto. (WebCore::FormSubmission::populateFrameLoadRequest): Added, moving the logic from

FrameLoader::submit closer to the data.

  • loader/FormSubmission.h: (WebCore::FormSubmission::action): Changed type to KURL. (WebCore::FormSubmission::clearTarget): Added. (WebCore::FormSubmission::referrer): Added. (WebCore::FormSubmission::setReferrer): Added. (WebCore::FormSubmission::origin): Added. (WebCore::FormSubmission::setOrigin): Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Cleaned up to make it more about decision-making,

not data manipulation.

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): Changed to accept FormSubmission as argument. (WebCore::ScheduledFormSubmission::fire): Changed to use FormSubmission. (WebCore::RedirectScheduler::scheduleFormSubmission): Removed assert that no longer makes sense,

changed to use FormSubmission.

  • loader/RedirectScheduler.h: Updated ScheduledFormSubmission decl to hold FormSubmission ref.
09:02 Changeset [61545] by eric@webkit.org
  • 19 edits in trunk

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • configure.ac:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

No new tests are needed, because there is no new functionality.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • features.gypi:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Scripts/build-webkit:
08:50 Changeset [61544] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Use global new/delete operator overloading with USE_SYSTEM_MALLOC=1
https://bugs.webkit.org/show_bug.cgi?id=40653

Currently, other ports do not use global new/delete operator overloading
when USE_SYSTEM_MALLOC=1. Brew MP uses system malloc, but it needs to enable
"global fastMalloc new" because the default new/delete causes crash on device.
We need to replace them with Brew MP's MALLOC/FREE.

  • wtf/FastMalloc.h:
08:50 Changeset [61543] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Fix MSVC build.

Reviewed by nobody, build fix.

The max macro was replacing the max function used in StringImpl.h
when compiling moc_NotificationPresenterClientQt.cpp.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:
07:50 Changeset [61542] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-06-21 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Delete DOM storage databases when they are empty.
https://bugs.webkit.org/show_bug.cgi?id=40767

Even if a page clears its local storage, the database file for it stays around,
and there is currently no mechanism that deletes them.

After doing the "final sync" of a storage area, the StorageAreaSyncMaster should
see if the database is empty, and in that case delete it.

Tests:

manual-tests/localstorage-empty-database.html

  • manual-tests/localstorage-empty-database.html: Added link to clear local storage for testing that the file is removed.
  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask): Added local storage task type DeleteEmptyDatabase. (WebCore::LocalStorageTask::performTask): Ditto.
  • storage/LocalStorageTask.h: (WebCore::LocalStorageTask::): Ditto. (WebCore::LocalStorageTask::createDeleteEmptyDatabase): Ditto.
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::scheduleFinalSync): When scheduling final sync, also schedule DeleteEmptyDatabase. (WebCore::StorageAreaSync::sync): Return early if final sync has nothing to sync. (WebCore::StorageAreaSync::deleteEmptyDatabase): Added function to check if a database is empty and in that case delete it.
  • storage/StorageAreaSync.h: Ditto.
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase): Added function for scheduling DeleteEmptyDatabase task.
  • storage/StorageSyncManager.h: Ditto.
07:36 Changeset [61541] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Initialization for http/tests/loading/
https://bugs.webkit.org/show_bug.cgi?id=40902

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
07:08 Changeset [61540] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-21 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Avoid unnecessary image conversion in RGBA32Buffer::zeroFill()
https://bugs.webkit.org/show_bug.cgi?id=40910

  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::zeroFill):
06:37 Changeset [61539] by mnaganov@chromium.org
  • 6 edits
    1 add in trunk/WebKit/chromium

2010-06-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by NOBODY (OOPS!).

[Chromium] Remove usage of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.

Also, move WebDevToolsMessageTransport to its own header file.

https://bugs.webkit.org/show_bug.cgi?id=40913

  • DEPS:
  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsMessageTransport.h: Added. (WebKit::WebDevToolsMessageTransport::~WebDevToolsMessageTransport):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::):
05:14 Changeset [61538] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-06-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
04:43 Changeset [61537] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Unreviewed build fix.

[Qt] Fix package builds

Don't use rpath unless we're building inside the trunk.

  • declarative/declarative.pro:
02:40 Changeset [61536] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Work around a build problem with libjscore on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=40840

Reviewed by Simon Hausmann.

Sbsv2 sometimes have problems with debug/release configuration
determination causing QtWebKit in release to try linking with the debug
JavaScriptCore static library. This patch limit the jscore/jscored
r58306 fix necessary for mac builds only to the mac platform to prevent the
different name problem.

The real fix would be to fix qmake or the toolchain, this patch might
help meanwhile.

02:33 Changeset [61535] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKitTools

Adding myself to the committers list.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
01:30 Changeset [61534] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-21 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Decode images directly to QPixmap
https://bugs.webkit.org/show_bug.cgi?id=40797

Decode images to QPixmap directly instead of QImage when possible.
RGBA32Buffer transforms the pixmap back to image if
necessary.

This improve the performance with certain graphic system, and
can reduce memory usage.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::internalHandleCurrentImage):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::setPixmap):
01:10 Changeset [61533] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-21 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

Buildfix after r61338.
https://bugs.webkit.org/show_bug.cgi?id=40888

roundUpAllocationSize is needed in RegisterFile.h.

  • jit/ExecutableAllocator.h:
00:59 Changeset [61532] by dumi@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing expectations.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
00:10 Changeset [61531] by dumi@chromium.org
  • 32 edits
    2 adds in trunk

Adding the SQLException class which will be used to report sync DB errors.
https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Adam Barth.

WebCore:

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • bindings/v8/V8Proxy.h:
  • dom/ExceptionCode.cpp:

(WebCore::):
(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:

(WebCore::):

  • page/DOMWindow.idl:
  • storage/SQLException.h: Added.

(WebCore::SQLException::create):
(WebCore::SQLException::):
(WebCore::SQLException::SQLException):

  • storage/SQLException.idl: Added.

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
00:06 Changeset [61530] by eric@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

2010-06-20 Hayato Ito <hayato@chromium.org>

Reviewed by Kent Tamura.

Add tests for CSS3 Paged Media to make sure page breaks should happen at right places.
Two tests (allowed-page-break and page-break-margin-collapsed) are expected to fail
due to lack of support.

https://bugs.webkit.org/show_bug.cgi?id=40770

  • printing/allowed-page-breaks-expected.txt: Added.
  • printing/allowed-page-breaks.html: Added.
  • printing/no-content-empty-pages-expected.txt: Added.
  • printing/no-content-empty-pages.html: Added.
  • printing/page-break-display-none-expected.txt: Added.
  • printing/page-break-display-none.html: Added.
  • printing/page-break-margin-collapsed-expected.txt: Added.
  • printing/page-break-margin-collapsed.html: Added.
  • printing/script-tests/allowed-page-breaks.js: Added. (test):
  • printing/script-tests/no-content-empty-pages.js: Added. (test):
  • printing/script-tests/page-break-display-none.js: Added. (test):
  • printing/script-tests/page-break-margin-collapsed.js: Added. (test):

06/20/10:

23:44 Changeset [61529] by yurys@chromium.org
  • 5 edits in trunk

2010-06-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if browser exposes
v8 debugging protocol.
https://bugs.webkit.org/show_bug.cgi?id=40844

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::setEnabled): (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
  • bindings/v8/ScriptDebugServer.h:

2010-06-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if browser exposes
v8 debugging protocol.

  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
22:28 Changeset [61528] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break for r61527
https://bugs.webkit.org/post_bug.cgi

  • CMakeLists.txt: Add loader/FormSubmission.cpp
21:38 Changeset [61527] by tkent@chromium.org
  • 5 edits in trunk/WebKitTools

2010-06-20 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add --allow-external-pages option
https://bugs.webkit.org/show_bug.cgi?id=40762

Add --allow-external-pages introduced by Chromium r45403.
http://src.chromium.org/viewvc/chrome?view=rev&revision=45403

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::allowExternalPages): (TestShell::setAllowExternalPages):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willSendRequest):
20:35 Changeset [61526] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • Plugins/WebNetscapePluginPackage.mm:
20:20 Changeset [61525] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of the old MIMETypes getter method
https://bugs.webkit.org/show_bug.cgi?id=40898

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:WebCore::]): (-[WebBasePluginPackage MIMETypeForExtension:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
19:58 Changeset [61524] by andersca@apple.com
  • 5 edits in trunk

Remove bogus const qualifiers.

Reviewed by Dan Bernstein.

WebCore:

  • platform/mac/PasteboardHelper.h:

WebKit/mac:

  • WebCoreSupport/WebPasteboardHelper.h:
  • WebCoreSupport/WebPasteboardHelper.mm:

(WebPasteboardHelper::urlFromPasteboard):
(WebPasteboardHelper::plainTextFromPasteboard):
(WebPasteboardHelper::fragmentFromPasteboard):

19:34 Changeset [61523] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of the extensionToMIME mapping in WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40897

Instead of using the extensionToMIME mutable dictionary, use the MIME types vector.
While this makes lookup of MIME types based on extensions linear instead of constant,
the number of extensions per plug-in is too small for it to matter.

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
19:13 Changeset [61522] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add a MimeClassInfo Vector to WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40896

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage WebCore::]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
19:12 Changeset [61521] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

Buildfix for NotificationCenter.h.
https://bugs.webkit.org/show_bug.cgi?id=40890

ScriptExecutionContext::completeURL is used in header,
but ScriptExecutionContext.h wasn't included.

  • notifications/NotificationCenter.h:
18:38 Changeset [61520] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-20 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Update for other <meter> tests and flaky/slow tests
18:30 Changeset [61519] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Move the NSBundle ivar to WebPluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40894

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _initWithPath:]):
  • Plugins/WebPluginPackage.h:
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage dealloc]): (-[WebPluginPackage viewFactory]): (-[WebPluginPackage load]):
18:05 Changeset [61518] by eric@webkit.org
  • 10 edits
    4 adds in trunk

2010-06-20 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Test to make sure parsing of async attribute works for HTML script tags
and test to make sure that async is not parsed for SVG script tags.
https://bugs.webkit.org/show_bug.cgi?id=39026

  • fast/dom/HTMLScriptElement/script-async-attr-expected.txt: Added.
  • fast/dom/HTMLScriptElement/script-async-attr.html: Added.
  • svg/dom/SVGScriptElement/script-async-attr-expected.txt: Added.
  • svg/dom/SVGScriptElement/script-async-attr.svg: Added.

2010-06-20 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Recognize async attribute on HTML script tags.
https://bugs.webkit.org/show_bug.cgi?id=39026

This does not implement async behavior, it only parses the async
attribute for HTML script tags. SVG script tags continue to not
support the async attribute.

Tests: fast/dom/HTMLScriptElement/script-async-attr.html

svg/dom/SVGScriptElement/script-async-attr.svg

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::isAsynchronous): (WebCore::ScriptElementData::isDeferred):
  • dom/ScriptElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::async): (WebCore::HTMLScriptElement::setAsync): (WebCore::HTMLScriptElement::defer): (WebCore::HTMLScriptElement::asyncAttributeValue): (WebCore::HTMLScriptElement::deferAttributeValue):
  • html/HTMLScriptElement.h:
  • html/HTMLScriptElement.idl:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::asyncAttributeValue): (WebCore::SVGScriptElement::deferAttributeValue):
  • svg/SVGScriptElement.h:
17:44 Changeset [61517] by tony@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-06-20 Tony Chang <tony@chromium.org>

Not reviewed, just cleaning up svn.

Removing platform/mac-snowleopard/editing since it's empty. The test
results were moved in r60693.

  • platform/mac-snowleopard/editing: Removed.
  • platform/mac-snowleopard/editing/spelling: Removed.
16:15 Changeset [61516] by jberlin@webkit.org
  • 4 edits in trunk/WebKit2

2010-06-20 Jessie Berlin <jberlin@apple.com>

Reviewed by Dan Bernstein.

Add #if USE(PLATFORM_STRATEGIES) where WebPlatformStrategies is being used.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): Only initialize the web platform strategies if PLATFORM_STRATEGIES is being used.
15:51 Changeset [61515] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Adam Barth.

Sheriffbot: Should allow "r" in SVN_REVISION
https://bugs.webkit.org/show_bug.cgi?id=40889

  • Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
15:32 Changeset [61514] by eric@webkit.org
  • 6 edits
    1 add in trunk/WebCore

2010-06-20 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Joseph Pecoraro.

Web Inspector: Auto-completion for CSS property names in Styles pane
https://bugs.webkit.org/show_bug.cgi?id=17374

Added autocompletion for CSS properties. A suggestion for a property
shows when you type. You can also cycle through known property names
using the Up and Down arrow keys.

  • WebCore.gypi:
  • inspector/front-end/CSSCompletions.js: Added. (WebInspector.CSSCompletions): (WebInspector.CSSCompletions.startsWith): (WebInspector.CSSCompletions.firstStartsWith): (WebInspector.CSSCompletions._firstIndexOfPrefix): (WebInspector.CSSCompletions.next): (WebInspector.CSSCompletions.previous): (WebInspector.CSSCompletions._closest):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js: (Text.prototype.select): ():
14:30 Changeset [61513] by joepeck@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Dimitri Glazkov.

Python Tests Fail after r61508
https://bugs.webkit.org/show_bug.cgi?id=40891

Test's regex list needed to be updated to match the new
regex list in the source code. Added new bots to the
example_buildbots list.

Regex list fixed in r61512. Updated bot list.

  • Scripts/webkitpy/common/net/buildbot_unittest.py:
14:14 Changeset [61512] by dglazkov@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-20 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.

  • Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
14:00 Changeset [61511] by dglazkov@chromium.org
  • 11 edits
    2 adds in trunk/WebCore

2010-06-14 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Introduce FormSubmission, the structure representing a form submission.
https://bugs.webkit.org/show_bug.cgi?id=40084

No change in functionality, covered by existing tests.

  • GNUmakefile.am: Added FormSubmission.h/cpp.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission): Renamed prepareFormData to prepareFormSubmission,

added code for populating a FormSubmission instance, moved the loop of accumulating text input
values into this functions (it belongs here logically).

(WebCore::HTMLFormElement::submit): Modified to use prepareFormSubmission.

  • html/HTMLFormElement.h:
  • loader/FormSubmission.cpp: Added.
  • loader/FormSubmission.h: Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Modified to use FormSubmission. Stopped plumbing further to keep

the patch size down.

  • loader/FrameLoader.h: Modified submitForm signature.
13:53 Changeset [61510] by andersca@apple.com
  • 9 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove -[WebBasePluginPackage bundle]
https://bugs.webkit.org/show_bug.cgi?id=40892

Add -[WebBasePluginPackage bundleIdentifier] and switch clients over to it.


Move the supportsSnapshotting method over to the plug-in package.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebBaseNetscapePluginView supportsSnapshotting]):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage isQuickTimePlugIn]): (-[WebBasePluginPackage isJavaPlugIn]): (-[WebBasePluginPackage WebCore::]): Call bundleIdentifier directly instead of asking the bundle
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage supportsSnapshotting]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setAttributeKeys:andValues:]): (-[WebNetscapePluginView _createPlugin]):
  • Plugins/WebPluginDatabase.mm: (checkCandidate):
13:27 Changeset [61509] by andersca@apple.com
  • 7 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
https://bugs.webkit.org/show_bug.cgi?id=40869


Re-land r61459, with extra null-checks in WebFrameLoaderClient.

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
11:58 Changeset [61508] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/net/buildbot.py

2010-06-20 William Siegrist <wsiegrist@apple.com>

Unreviewed. Make core builder regexp more specific so new Chromium test slaves do not get core builder status.

11:55 Changeset [61507] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Unreviewed rollout r61506, because it made 1 test crash.

Causes crash. Will approach the solution in a different way.

10:02 Changeset [61506] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Should Autocomplete Style Properties
https://bugs.webkit.org/show_bug.cgi?id=38448

This Autocompletes style properties when in the console.

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
05:54 Changeset [61505] by robert@webkit.org
  • 5 edits in trunk

2010-06-20 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • platform/qt/Skipped:

2010-06-20 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
04:46 Changeset [61504] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-06-20 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

The QWebHistory regression fix.

After change r51629 and r61207 QWebHistory's function back(),
forward(), goToItem() got broken.

Use page->goToItem() instead of direct actions on the BackForwardList.

[Qt] REGRESSION(r61207): qwebhistory unit test hangs
https://bugs.webkit.org/show_bug.cgi?id=40672

  • Api/qwebhistory.cpp: (QWebHistory::back): (QWebHistory::forward): (QWebHistory::goToItem):
  • tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::init): (tst_QWebHistory::back): (tst_QWebHistory::forward):

06/19/10:

20:37 Changeset [61503] by jschuh@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
18:03 Changeset [61502] by eric@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-06-19 Hayato Ito <hayato@chromium.org>

Reviewed by Adam Barth.

Add tests for CSS 'orphans' and 'widows' properties.
All tests are expected to fail due to lack of implementations.

https://bugs.webkit.org/show_bug.cgi?id=40821

  • printing/page-break-orphans-and-widows-expected.txt: Added.
  • printing/page-break-orphans-and-widows.html: Added.
  • printing/page-break-orphans-expected.txt: Added.
  • printing/page-break-orphans.html: Added.
  • printing/page-break-widows-expected.txt: Added.
  • printing/page-break-widows.html: Added.
  • printing/script-tests/page-break-orphans-and-widows.js: Added. (test):
  • printing/script-tests/page-break-orphans.js: Added. (test):
  • printing/script-tests/page-break-widows.js: Added. (test):
17:50 Changeset [61501] by eric@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-06-19 Hayato Ito <hayato@chromium.org>

Reviewed by Adam Barth.

Add tests for 'page-break-{before,after}: avoid'.
All tests are expected to fail due to lack of implementations.

https://bugs.webkit.org/show_bug.cgi?id=40814

  • printing/page-break-after-avoid-expected.txt: Added.
  • printing/page-break-after-avoid.html: Added.
  • printing/page-break-avoid-expected.txt: Added.
  • printing/page-break-avoid.html: Added.
  • printing/page-break-before-avoid-expected.txt: Added.
  • printing/page-break-before-avoid.html: Added.
  • printing/script-tests/page-break-after-avoid.js: Added. (test):
  • printing/script-tests/page-break-avoid.js: Added. (test):
  • printing/script-tests/page-break-before-avoid.js: Added. (test):
17:39 Changeset [61500] by weinig@apple.com
  • 23 edits in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
Add ability to have a WebProcess per WebContext.

Reviewed by Anders Carlsson.

WebKit2:

  • Move to a one-to-one correspondence of WebContexts to WebProcessProxies.
  • Add explicit shared contexts for general use.
  • Only non-shared contexts can use injected bundles.
  • UIProcess/API/C/WKContext.cpp:

(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):
(WKContextGetSharedProcessContext):
(WKContextGetSharedThreadContext):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKContextPrivate.h:

Change API for WKContext to no longer take a WKProcessModel type and instead
have explicit Create/Get functions for the different kind of contexts. Added
two shared contexts, one threaded, one process, and made the threaded on private
for now.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:]):
Make WKViews that don't have an explicit context use the shared process
context by default.

  • UIProcess/Launcher/WebProcessLauncher.h:
  • UIProcess/Launcher/mac/WebProcessLauncher.mm:

(WebKit::launchWebProcess):

  • UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::launchWebProcess):
Use a boolean argument to note whether we are using a thread or a process
instead of using the process model enum.

  • UIProcess/ProcessModel.h:

(WebKit::):
Convert to using explicit Shared modifier for shared contexts.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedProcessContext):
(WebKit::WebContext::sharedThreadContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::reviveIfNecessary):

  • UIProcess/WebContext.h:

(WebKit::WebContext::create):
(WebKit::WebContext::process):

  • UIProcess/WebPageNamespace.cpp:

(WebKit::WebPageNamespace::createWebPage):
(WebKit::WebPageNamespace::preferencesDidChange):
(WebKit::WebPageNamespace::getStatistics):

  • UIProcess/WebPageNamespace.h:

(WebKit::WebPageNamespace::process):
(WebKit::WebPageNamespace::reviveIfNecessary):
Move WebProcessProxy creation logic up into WebContext.

  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::getWebProcess):
(WebKit::WebProcessManager::processDidClose):

  • UIProcess/WebProcessManager.h:

Keep a map of WebContexts to WebProcessProxies in addition to the two
shared processes.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::didClose):

  • UIProcess/WebProcessProxy.h:

Store a WebContext instead of the process model.

  • mac/WebKit2.exp:

Add new functions.

WebKitTools:

Move to use new shared contexts API.

  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate getCurrentPageNamespace]):
(-[BrowserAppDelegate validateMenuItem:]):
(-[BrowserAppDelegate _setProcessModel:]):
(-[BrowserAppDelegate setSharedProcessProcessModel:]):
(-[BrowserAppDelegate setSharedThreadProcessModel:]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

17:38 Changeset [61499] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

When V8 ScriptData caching was originally submitted it causes crashes
in external scripts with high-byte characters. This new test crashes on
the original code, but now passes.

  • fast/js/parser-high-byte-character-expected.txt: Added.
  • fast/js/parser-high-byte-character.html: Added.
  • fast/js/script-tests/parser-high-byte-character.js: Added. (runTest):

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark showed a ~7% improvement when this was
originally submitted (before it had to be rolled back).

Test: fast/js/parser-high-byte-character.html

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
14:48 Changeset [61498] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-19 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt: Tuned expectations according to the bot result runs.
13:39 Changeset [61497] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Add LayoutTest to ensure resources within <noscript> are not preloaded
https://bugs.webkit.org/show_bug.cgi?id=40849

  • fast/preloader/noscript-expected.txt: Added.
  • fast/preloader/noscript.html: Added.
  • fast/preloader/resources/noscript-image1.png: Copied from BugsSite/data/mail.
  • fast/preloader/resources/noscript-image2.png: Copied from BugsSite/data/mail.
10:24 Changeset [61496] by eric@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

2010-06-19 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port SocketStream
https://bugs.webkit.org/show_bug.cgi?id=39671

Port SocketStream with BREW MP's ISocket interface.

  • platform/network/brew/SocketStreamError.h: Added. (WebCore::SocketStreamError::SocketStreamError):
  • platform/network/brew/SocketStreamHandle.h: Added. (WebCore::SocketStreamHandle::create):
  • platform/network/brew/SocketStreamHandleBrew.cpp: Added. (WebCore::socketStreamConnectCallback): (WebCore::getHostByNameCallback): (WebCore::socketReadableCallback): (WebCore::networkManager): (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::~SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::socketConnected): (WebCore::SocketStreamHandlePrivate::socketReadyRead): (WebCore::SocketStreamHandlePrivate::connect): (WebCore::SocketStreamHandlePrivate::send): (WebCore::SocketStreamHandlePrivate::close): (WebCore::SocketStreamHandlePrivate::socketClosed): (WebCore::SocketStreamHandlePrivate::socketError): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose): (WebCore::SocketStreamHandle::didReceiveAuthenticationChallenge): (WebCore::SocketStreamHandle::receivedCredential): (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): (WebCore::SocketStreamHandle::receivedCancellation):
  • platform/network/brew/SocketStreamHandlePrivate.h: Added.
10:11 Changeset [61495] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-06-19 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Adding a < operator to WebURLs so they can be used in std::maps.
https://bugs.webkit.org/show_bug.cgi?id=40632

  • public/WebCString.h: (WebKit::operator<):
  • public/WebURL.h: (WebKit::operator<):
  • src/WebCString.cpp: (WebKit::WebCString::compare):
09:47 Changeset [61494] by eric@webkit.org
  • 6 edits in trunk

2010-06-19 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: subtitleElement.textContent is always empty. Use subtitleAsText method instead.
https://bugs.webkit.org/show_bug.cgi?id=40420

  • inspector/elements-tests.js: (frontend_getSelectedElementStyles):

2010-06-19 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: Prevent from copying "filename.css" in Styles pane
https://bugs.webkit.org/show_bug.cgi?id=40420

  • inspector/front-end/Section.js: (WebInspector.Section.prototype.set subtitle): (WebInspector.Section.prototype.get subtitleAsText):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
  • inspector/front-end/inspector.css: (.styles-section .subtitle::before, .styles-section .subtitle a::before):
09:35 Changeset [61493] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 Alex Milowski <alex@milowski.com>

Reviewed by Darin Adler.

A fix for a change in https://bugs.webkit.org/show_bug.cgi?id=39941
that caused a compile error in MathML.
https://bugs.webkit.org/show_bug.cgi?id=40827

  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement):
09:21 Changeset [61492] by eric@webkit.org
  • 6 edits
    3 copies
    3 adds in trunk/WebCore

2010-06-19 Kartikaya Gupta <kagupta@rim.com>

Reviewed by Nikolas Zimmermann.

CPP bindings missing some APIs
https://bugs.webkit.org/show_bug.cgi?id=40570

Add missing C++ DOM API bindings. Specifically:

  • NodeFilter callback support
  • Missing custom method implementations in HTMLCollection and HTMLOptionsCollection
  • Missing EventTarget static type-determination methods
  • Fix CPP binding generator to not generate d-ptrs for classes that extend EventTarget and just use the parent's d-ptr instead
  • Switch binding generator to use DOMWindow instead of AbstractView so that necessary W3C-defined methods (e.g. getComputedStyle) are accessible.
  • bindings/cpp/WebDOMDOMWindowCustom.cpp: Added. (WebDOMDOMWindow::addEventListener): (WebDOMDOMWindow::removeEventListener):
  • bindings/cpp/WebDOMEventTarget.cpp: (toWebKit):
  • bindings/cpp/WebDOMEventTarget.h:
  • bindings/cpp/WebDOMHTMLCollectionCustom.cpp: Added. (WebDOMHTMLCollection::item): (WebDOMHTMLCollection::namedItem):
  • bindings/cpp/WebDOMHTMLOptionsCollectionCustom.cpp: Added. (WebDOMHTMLOptionsCollection::length): (WebDOMHTMLOptionsCollection::setLength):
  • bindings/cpp/WebDOMNodeFilterCustom.cpp: Added. (WebDOMNodeFilter::acceptNode): (toWebKit):
  • bindings/cpp/WebNativeNodeFilterCondition.cpp: Added. (WebNativeNodeFilterCondition::WebNativeNodeFilterCondition): (WebNativeNodeFilterCondition::~WebNativeNodeFilterCondition): (WebNativeNodeFilterCondition::acceptNode):
  • bindings/cpp/WebNativeNodeFilterCondition.h: Added. (WebNativeNodeFilterCondition::create):
  • bindings/scripts/CodeGeneratorCPP.pm:
  • dom/NodeFilter.idl:
  • page/DOMWindow.idl:
08:22 Changeset [61491] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-19 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update

  • platform/chromium/test_expectations.txt: Added a flaky crash.
08:13 Changeset [61490] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed. Build fix for r61488.

  • features.gypi: Define use_accelerated_compositing.
08:05 Changeset [61489] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Include <string.h> in StringExtras.h
https://bugs.webkit.org/show_bug.cgi?id=40808

Without string.h, RVCT 2.2 can't compile StringExtras.h.
It can't find strlen and strncmp.

  • wtf/StringExtras.h:
07:53 Changeset [61488] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Adding a conditional gyp dependency for the WebCore target to
the gles2_c_lib which is required by the gpu compositor. The dependency will
only kick in if the accelerated_compositing path is enabled.
https://bugs.webkit.org/show_bug.cgi?id=40801

  • WebCore.gyp/WebCore.gyp:
07:19 Changeset [61487] by eric@webkit.org
  • 10 edits in trunk

2010-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin's multi-select does not take OptGroup into account
https://bugs.webkit.org/show_bug.cgi?id=40718

In multi-select elements, optgroup elements are counted in the index calculation,
but in single-select they are not. Keep the same logic even when NO_LISTBOX_RENDERING
is enabled.
Added tests to the existing manual test, as testing this requires a special build, in which
NO_LISTBOX_RENDERING is enabled.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxSelectItem):
  • manual-tests/no-listbox-rendering.html:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listBoxSelectItem):

2010-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin's multi-select does not take OptGroup into account
https://bugs.webkit.org/show_bug.cgi?id=40718

Make sure that SelectData is valid throughout the lifetime of the dialog.
This is mostly important for the Orbt based plugin.
Added virtual desctructors where they were missing.

  • Api/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::~SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::show):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp:
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData):
07:07 Changeset [61486] by eric@webkit.org
  • 7 edits in trunk

2010-06-19 Thomas Van Lenten <thomasvl@chromium.org>

Reviewed by David Levin.

Warnings from -Wextra in a Chromium Mac build

  1. checks of unsigned >= 0
  2. enumeral and non-enumeral type in conditional expression
  3. copy ctors that don't call the super copy ctor or ctor No functionality change so no new tests.

https://bugs.webkit.org/show_bug.cgi?id=40791

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::ChromiumDataObject):
  • platform/chromium/ThemeChromiumMac.mm: (WebCore::updateStates):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::updateActiveState):

2010-06-19 Thomas Van Lenten <thomasvl@chromium.org>

Reviewed by David Levin.

Warnings from -Wextra in a Chromium Mac build

  1. checks of unsigned >= 0
  2. enumeral and non-enumeral type in conditional expression
  3. copy ctors that don't call the super copy ctor or ctor

https://bugs.webkit.org/show_bug.cgi?id=40791

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getSuggestion): (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged):
  • src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::getSuggestion): (WebKit::AutocompletePopupMenuClient::removeSuggestionAtIndex):
06:54 Changeset [61485] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 Ben Murdoch <benm@google.com>

Reviewed by Pavel Feldman.

Fix build break with inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=40790

Replace a #include with a forward declaration.

Fixing a build break so no new tests required.

  • inspector/InspectorController.h: Forward declare InspectorValue

rather than #including its header which has its content guarded
out.

06:32 Changeset [61484] by eric@webkit.org
  • 13 edits
    5 copies in trunk

2010-06-19 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Fisher.

[chromium]Refactor input method related APIs.
https://bugs.webkit.org/show_bug.cgi?id=40608

No new tests are needed, because there is no new functionality.

  • page/FocusController.cpp: (WebCore::FocusController::setFocusedNode):

2010-06-19 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Fisher.

[chromium]Refactor input method related APIs.
https://bugs.webkit.org/show_bug.cgi?id=40608

  • WebKit.gyp:
  • public/WebCompositionCommand.h:
  • public/WebCompositionUnderline.h: Added. (WebKit::WebCompositionUnderline::WebCompositionUnderline):
  • public/WebTextInputType.h: Added. (WebKit::):
  • public/WebViewClient.h:
  • public/WebWidget.h:
  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::resetInputMethod):
  • src/CompositionUnderlineBuilder.h: Added. (WebKit::CompositionUnderlineBuilder::CompositionUnderlineBuilder):
  • src/CompositionUnderlineVectorBuilder.cpp: Added. (WebKit::CompositionUnderlineVectorBuilder::CompositionUnderlineVectorBuilder):
  • src/CompositionUnderlineVectorBuilder.h: Added.
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::setInputMethodState):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::setComposition): (WebKit::WebPopupMenuImpl::confirmComposition): (WebKit::WebPopupMenuImpl::textInputType): (WebKit::WebPopupMenuImpl::caretOrSelectionBounds):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleCompositionEvent): (WebKit::WebViewImpl::setComposition): (WebKit::WebViewImpl::confirmComposition): (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds):
  • src/WebViewImpl.h:
06:05 Changeset [61483] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-19 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

Modifying the WebMediaPlayer interface to be compatible with
a change in chrome.
This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
has been updated, so this commit should NOT break chromium anymore,
nor should it cause any test failures.
https://bugs.webkit.org/show_bug.cgi?id=39445

  • public/WebMediaPlayer.h: Changed buffered() to be non-const.
05:32 Changeset [61482] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 George Wright <gwright@rim.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=40720

Make setWapInputFormat() public again as CSSStyleSelector.cpp calls this when WCSS is enabled.

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::data):
05:31 Changeset [61481] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt:
    • progress-element.html is essentially flaky on Mac.
    • use-clipped-hit.svg passes recently.
04:58 Changeset [61480] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-19 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

Bridge documentation: some snippets have the wrong indentation
https://bugs.webkit.org/show_bug.cgi?id=40717

Fixed code snippets

  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction):
04:43 Changeset [61479] by tkent@chromium.org
  • 3 edits
    53 adds in trunk/LayoutTests

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add expectations for <meter> and <progress>.

  • platform/chromium-linux/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/test_expectations.txt:
04:02 Changeset [61478] by robert@webkit.org
  • 14 edits
    3 adds in trunk

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

This initial implementation passes 25 of the 27 tests in
http/tests/isolatedworld as well as four others that use the
call in LayoutTests.

Further work/investigation is required to support the two
remaining tests.

  • platform/qt/Skipped:

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

getOwnPropertyNames() crashes if PropertyNameArray is size 0. This change allows
http/tests/world-reuse.html and didClearWindowObject.html to fail instead of crash.

  • WebCore.pro: Add qwebscriptworld.*
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

  • Api/headers.pri:
  • Api/qwebframe.cpp: (QWebFrame::evaluateScriptInIsolatedWorld):
  • Api/qwebframe.h:
  • Api/qwebscriptworld.cpp: Added. (QWebScriptWorld::QWebScriptWorld): (QWebScriptWorld::world): (QWebScriptWorld::~QWebScriptWorld):
  • Api/qwebscriptworld.h: Added.
  • Api/qwebscriptworld_p.h: Added. (QWebScriptWorldPrivate::QWebScriptWorldPrivate): (QWebScriptWorldPrivate::~QWebScriptWorldPrivate):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
03:18 Changeset [61477] by tkent@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Rebaseline for tetDecoration.svg.

  • platform/chromium-linux/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
03:04 Changeset [61476] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-19 Olivier Goffart <olivier.goffart@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compilation in QWebPagePrivate::timerEvent with clang
https://bugs.webkit.org/show_bug.cgi?id=40714

QObject::timerEvent is protected and cannot be accessed by QWebPagePrivate
with clang

QWebPagePrivate is a friend of QWebPage and then should have access to
all protected members of parents of QWebPage, including QObject.
But the clang team do not want to conform to this aspect of the specification
because "It is either a drafting error or a horrible mistake."
See http://llvm.org/bugs/show_bug.cgi?id=6840

This change is better because QWebPage does not reimplement the timerEvent
(QWebPagePrivate::timerEvent is called from QWebPage::event)
So customers that would reimplement their own timerEvent
for their own timer now get a chance to catch them.

  • Api/qwebpage.cpp: (QWebPagePrivate::timerEvent):
02:45 Changeset [61475] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Don't use attribute((may_alias)) with the Intel compiler,
as it doesn't understand it.

  • wtf/Vector.h:
02:23 Changeset [61474] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix compilation with the Intel C++ compiler (11.1.072).

Like RVCT, label pointers must be void*, not const void*.

  • bytecode/Opcode.h:
02:09 Changeset [61473] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add the WTF_COMPILER_INTEL for when the Intel compiler is used
for building. Usually, the Intel compiler masquerades as
another compiler in the system and gets away with it, but some
times specific fixes are required (such as when using language
extensions).

  • wtf/Platform.h:
01:45 Changeset [61472] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-19 Mirko Damiani <mirko@develer.com>

Reviewed by Simon Hausmann.

[Qt] Avoid truncation of zoom factor in QWebFrame's print function.
https://bugs.webkit.org/show_bug.cgi?id=40662

The zoom factor is a qreal number but its value is truncated to an
integer. So a cast to qreal is needed to avoid this issue.

  • Api/qwebframe.cpp: (QWebFrame::print):
01:31 Changeset [61471] by eric@webkit.org
  • 5 edits in trunk

2010-06-19 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/get-active-test.html failed in Chrome Mac
https://bugs.webkit.org/show_bug.cgi?id=40496

  • fast/canvas/webgl/get-active-test-expected.txt: Test of two contexts and two programs, also test the uniform array name ends with "[0]".
  • fast/canvas/webgl/script-tests/get-active-test.js: Ditto.

2010-06-19 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/get-active-test.html failed in Chrome Mac
https://bugs.webkit.org/show_bug.cgi?id=40496

  • src/WebGraphicsContext3DDefaultImpl.cpp: Call makeContextCurrent(). (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels):
00:26 Changeset [61470] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Some very minor cleanups for HTML5 Parser
https://bugs.webkit.org/show_bug.cgi?id=40638

No new tests because no new functionality.

  • html/HTML5DocumentParser.cpp: (WebCore::): Make ctor explicit.
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::InsertionPointRecord::InsertionPointRecord): Make ctor explicit.
  • html/HTML5Lexer.cpp: (WebCore::HTMLNames::isEndTagBufferingState): Use switch to generate an efficient table with single branch.
  • html/HTML5Token.h: (WebCore::HTML5Token::forceQuirks): Add const.
  • html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::isPaused): Add const.
00:12 Changeset [61469] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add three more non-core Chromium builders to start testing DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=40335

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
00:08 Changeset [61468] by aa@chromium.org
  • 2 edits in trunk

2010-06-18 Aaron Boodman <aa@chromium.org>

Remove WebKit::WebDocument::isXHTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=40815

  • dom/Document.h: remove isXHTML() getter.

2010-06-18 Aaron Boodman <aa@chromium.org>

Remove WebKit::WebDocument::isXHTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=40815

  • public/WebDocument.h: Remove isXHTMLDocument().
  • src/WebDocument.cpp: Ditto.
00:05 Changeset [61467] by aa@chromium.org
  • 5 edits in trunk

2010-06-19 Aaron Boodman <aa@chromium.org>

Unreviewed, rolling out r61466.
http://trac.webkit.org/changeset/61466
https://bugs.webkit.org/show_bug.cgi?id=40816

Landed wrong change

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8DOMWindowShell.h:

2010-06-19 Aaron Boodman <aa@chromium.org>

Unreviewed, rolling out r61466.
http://trac.webkit.org/changeset/61466
https://bugs.webkit.org/show_bug.cgi?id=40816

Landed wrong change

  • src/WebKit.cpp: (WebKit::shutdown):

06/18/10:

23:54 Changeset [61466] by aa@chromium.org
  • 5 edits in trunk

2010-06-18 Aaron Boodman <aa@chromium.org>

WebKit API: Undo static hooks into V8 when WebKit is shut down.
https://bugs.webkit.org/show_bug.cgi?id=40816

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded): (WebCore::V8DOMWindowShell::initializeV8IfNeeded): (WebCore::V8DOMWindowShell::uninitializeV8IfNeeded):
  • bindings/v8/V8DOMWindowShell.h:

2010-06-18 Aaron Boodman <aa@chromium.org>

WebKit API: Undo static hooks into V8 when WebKit is shut downm
https://bugs.webkit.org/show_bug.cgi?id=40816

  • src/WebKit.cpp: (WebKit::shutdown): Call new WebCore::V8DOMWindowShell::uninitializeV8IfNeeded().
21:33 Changeset [61465] by rwlbuis@webkit.org
  • 1 edit
    1 move
    3 adds in trunk/LayoutTests

2010-06-18 Rob Buis <rwlbuis@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19575
layout test svg/batik/text/textDecoration.svg hangs

Reenable this test since crash is gone (tested on OS X 10.5.8).

  • platform/mac/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/mac/svg/batik/text/textDecoration-expected.png: Added.
  • platform/mac/svg/batik/text/textDecoration-expected.txt: Added.
  • svg/batik/text/textDecoration.svg: Renamed from LayoutTests/svg/batik/text/textDecoration.svg-disabled.
20:35 Changeset [61464] by abarth@webkit.org
  • 6 edits in trunk/WebKit/mac

2010-06-18 Adam Barth <abarth@webkit.org>

Unreviewed, rolling out r61459.
http://trac.webkit.org/changeset/61459
https://bugs.webkit.org/show_bug.cgi?id=40869

Seems to have broken two tests on the Tiger buildbot:

dom/html/level2/html/AppletsCollection.html
plugins/qt-qwidget-plugin.html

Anders wasn't on #webkit...

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage setName:]): (-[WebBasePluginPackage setPath:]): (-[WebBasePluginPackage setPluginDescription:]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
20:23 Changeset [61463] by jberlin@webkit.org
  • 2 edits in trunk/WebCore

Bug 19509 - Database Tables in the Inspector should be sortable
https://bugs.webkit.org/show_bug.cgi?id=19509

Reviewed by Darin Adler.

  • inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel.prototype.dataGridForResult):
Make each column in the DataGrid sortable.
(WebInspector.StoragePanel.prototype._sortDataGrid.comparator):
Make sure to sort numeric columns by their numeric values, instead of lexicographically.
(WebInspector.StoragePanel.prototype._sortDataGrid):
Sort the entries in the DataGrid based on the selected column.

20:18 Changeset [61462] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

  • WebCore.gyp/WebCore.gyp: Modified inclusion rule in to actually add WebSystemInterface.mm.
18:15 Changeset [61461] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage isJavaPlugIn]):

18:07 Changeset [61460] by andersca@apple.com
  • 4 edits in trunk/WebCore

More clang++ warning fixes.

Reviewed by Oliver Hunt.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):

  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/mac/WebLayer.mm:

(-[CALayer _descriptionWithPrefix:]):

17:35 Changeset [61459] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
https://bugs.webkit.org/show_bug.cgi?id=40869

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
17:15 Changeset [61458] by atwilson@chromium.org
  • 6 edits in trunk

[Chromium] Plumbing for top-level frame names
https://bugs.webkit.org/show_bug.cgi?id=40430

Reviewed by Darin Fisher.

WebKit/chromium:

  • public/WebFrame.h:

Removed obsolete clearName() API and added better documentation for
setName().

  • src/WebFrameImpl.cpp:

Removed clearName() API.

  • src/WebFrameImpl.h:

Removed clearName() API.

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):
Changed obsolete call to clearName() to use setName(WebString()) instead.

17:15 Changeset [61457] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Test by Chris Brichford.

https://bugs.webkit.org/show_bug.cgi?id=19759
ChildNodeList for an attribute node is not properly invalidated after appending a child

This issue has been fixed in another bug, just landing an additional test.

  • fast/dom/Attr/child-nodes-length-cache-expected.txt: Added.
  • fast/dom/Attr/child-nodes-length-cache.html: Added.
17:01 Changeset [61456] by andersca@apple.com
  • 3 edits
    1 move in trunk/WebKit

WebKit: Rename WebPluginPackage.m to make it an Objective-C++ file.

Reviewed by Sam Weinig.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac: Rename WebPluginPackage.m to make it an Objective-C++ file.

Reviewed by Sam Weinig.

  • Plugins/WebPluginPackage.m: Removed.
  • Plugins/WebPluginPackage.mm: Copied from Plugins/WebPluginPackage.m.
16:56 Changeset [61455] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

  • WebCore.gyp/WebCore.gyp: Renamed WebSystemInterface.m to WebSystemInterface.mm.
16:51 Changeset [61454] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of the NSEnumerators from WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40868

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage MIMETypes]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
16:23 Changeset [61453] by andersca@apple.com
  • 10 edits
    2 moves in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebKit.xcodeproj/project.pbxproj:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebCoreSupport/WebSystemInterface.h:
  • WebCoreSupport/WebSystemInterface.m: Removed.
  • WebCoreSupport/WebSystemInterface.mm: Copied from WebKit/mac/WebCoreSupport/WebSystemInterface.m.

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • platform/mac/WebCoreSystemInterface.h:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.h:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.m: Removed.
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: Copied from WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.m.
  • mac/WebKit2.exp:
16:17 Changeset [61452] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Clean up WebPluginDatabase.mm
https://bugs.webkit.org/show_bug.cgi?id=40866

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (pathByResolvingSymlinksAndAliases): (-[WebBasePluginPackage initWithPath:]): Change an instance method into a static function.


  • Plugins/WebPluginDatabase.mm: (PluginPackageCandidates::PluginPackageCandidates): (PluginPackageCandidates::update): (PluginPackageCandidates::bestCandidate): Add a new PluginPackageCandidates class.


(-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
Use PluginPackageCandidates here.

16:13 Changeset [61451] by levin@chromium.org
  • 4 edits
    2 adds in trunk

WebCore: Convert column span from an unsigned short type to an unsigned int
type. Fixes a divide-by-zero crash arising from using a zero colspan
value coming from a narrow cast of an int to an unsigned short.
https://bugs.webkit.org/show_bug.cgi?id=40812

Patch by Abhishek Arya <inferno@chromium.org> on 2010-06-18
Reviewed by Adam Barth.

Test: fast/table/zero-colspan-crash.html

  • rendering/RenderTable.h: Change span from unsigned short to unsigned int.
  • rendering/RenderTableSection.cpp: Fix a compiler warning with comparing unsigned int with signed int. Value of an unsigned int here cannot be greater than maximum positive value of a signed int.

(WebCore::RenderTableSection::addCell):

LayoutTests: Tests that we do not crash while rendering a fixed table layout.
https://bugs.webkit.org/show_bug.cgi?id=40812

Patch by Abhishek Arya <inferno@chromium.org> on 2010-06-18
Reviewed by Adam Barth.

  • fast/table/zero-colspan-crash-expected.txt: Added.
  • fast/table/zero-colspan-crash.html: Added.
16:09 Changeset [61450] by oliver@apple.com
  • 4 edits in trunk

2010-06-18 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Incorrect handling of multiple BOMs scattered through a file.
https://bugs.webkit.org/show_bug.cgi?id=40865

When determining the offset of open and close braces in a source
with BOMs we were finishing our count early as we failed to account
for BOMs prior to the open/close brace positions effecting those
positions.

  • parser/Lexer.cpp: (JSC::Lexer::sourceCode):

2010-06-18 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Incorrect handling of multiple BOMs scattered through a file.
https://bugs.webkit.org/show_bug.cgi?id=40865

Put a few more BOMs into this testcase so that it hits the other cases
that were missed before.

  • fast/js/resources/bom-in-file-retains-correct-offset.js: (g.f): (g):
16:01 Changeset [61449] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • WebCoreSupport/WebPlatformStrategies.mm:
15:30 Changeset [61448] by dglazkov@chromium.org
  • 11 edits
    2 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Update a few more chromium-win baselines after http://trac.webkit.org/changeset/61393.

15:20 Changeset [61447] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add platform strategies for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=40863

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added. (WebKit::WebPlatformStrategies::initialize): (WebKit::WebPlatformStrategies::WebPlatformStrategies): (WebKit::WebPlatformStrategies::createPluginStrategy): (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess):
15:16 Changeset [61446] by dglazkov@chromium.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Update a few more chromium-mac baselines after http://trac.webkit.org/changeset/61393.

15:11 Changeset [61445] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Text spacing miscalculation when using wordSpacing.
https://bugs.webkit.org/show_bug.cgi?id=40483

Patch by Ananth Jasty <ext-ananth.jasty@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

Removed wordSpacing compensation in FontQt whitespace width
calculation. The QFontMetrics::width() overload that takes
a character does not take QFont's word spacing into account.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText):

15:08 Changeset [61444] by andersca@apple.com
  • 10 edits
    1 delete in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PluginDataMac.mm and use the plug-in strategy instead
https://bugs.webkit.org/show_bug.cgi?id=40860

  • Plugins/WebBasePluginPackage.h:
  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createPluginStrategy): (WebPlatformStrategies::refreshPlugins): (WebPlatformStrategies::getPluginInfo):
  • WebCoreSupport/WebViewFactory.mm:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PluginDataMac.mm and use the plug-in strategy instead
https://bugs.webkit.org/show_bug.cgi?id=40860

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/WebCoreViewFactory.h:
  • plugins/PluginData.cpp: (WebCore::PluginData::refresh): (WebCore::PluginData::initPlugins):
  • plugins/PluginStrategy.h:
  • plugins/mac/PluginDataMac.mm: Removed.
14:52 Changeset [61443] by weinig@apple.com
  • 9 edits
    5 adds
    1 delete in trunk
14:50 Changeset [61442] by dglazkov@chromium.org
  • 18 edits in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Update chromium baselines after http://trac.webkit.org/changeset/61418.

14:48 Changeset [61441] by andersca@apple.com
  • 7 edits in trunk/WebCore

Fix some (not all) clang++ warnings.

Reviewed by Dan Bernstein.

  • dom/Position.h:

(WebCore::lastOffsetInNode):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::resourceForRequest):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition):
(WebCore::ComplexTextController::collectComplexTextRuns):

  • platform/network/CredentialStorage.cpp:

(WebCore::protectionSpaceMapKeyFromURL):

  • rendering/style/StyleRareNonInheritedData.h:
14:44 Changeset [61440] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Skipped some failing tests and conglomerated a skipped test into another group.

  • platform/gtk/Skipped: Cleanups and three more skipped tests.
14:40 Changeset [61439] by dglazkov@chromium.org
  • 285 edits
    58 adds
    44 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Update chromium-linux baselines after http://trac.webkit.org/changeset/61393.

14:23 Changeset [61438] by andersca@apple.com
  • 8 edits
    2 adds in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebKit.xcodeproj/project.pbxproj:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebCoreSupport/WebPlatformStrategies.h: Added.
  • WebCoreSupport/WebPlatformStrategies.mm: Added. (WebPlatformStrategies::initialize): (WebPlatformStrategies::WebPlatformStrategies): (WebPlatformStrategies::createPluginStrategy):
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebCore.base.exp:
  • platform/PlatformStrategies.cpp:
  • platform/PlatformStrategies.h: (WebCore::PlatformStrategies::~PlatformStrategies):
14:19 Changeset [61437] by dglazkov@chromium.org
  • 798 edits
    73 adds in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Update chromium-win baselines after http://trac.webkit.org/changeset/61393.

14:09 Changeset [61436] by andersca@apple.com
  • 4 edits in trunk/WebCore

Fix build errors when building with clang++.

Reviewed by Darin Adler.

  • loader/archive/cf/LegacyWebArchiveMac.mm:

Move the const qualifier to the right place.

  • page/EditorClient.h:
  • platform/Pasteboard.h:

Use @class when forward declaring Objective-C classes in Objective-C.

14:05 Changeset [61435] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=40852
<rdar://problem/8105498> Limit simultaneous DNS prefetch request number (40852)

No change in functionality, so no tests.

We still queue up to 64 names, but only make up to 8 requests at once. If there are names
remaining in queue, we retry after a short timeout (which is easier than posting
notifications from client callback).

  • platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::add): (WebCore::DNSResolveQueue::fired):
14:03 Changeset [61434] by mrobinson@webkit.org
  • 2 edits
    27 adds in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests and correcting one incorrect baseline.

  • platform/gtk/media/video-replaces-poster-expected.txt: Correting this incorrect baseline.
  • platform/gtk/svg/hixie/text/001-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-1-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-2-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-3-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-4-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt: Added.
14:01 Changeset [61433] by robert@webkit.org
  • 4 edits in trunk

2010-06-18 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • platform/qt/Skipped:

2010-06-18 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):
13:44 Changeset [61432] by zmo@google.com
  • 2 edits in trunk/WebCore

WebGL demos show bad flicker
https://bugs.webkit.org/show_bug.cgi?id=38560

13:41 Changeset [61431] by mrobinson@webkit.org
  • 2 edits
    74 adds in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests. Some tests that fail have been labeled
with bug numbers. Also removed a newly defunct test from the skipped list.

  • platform/gtk/Skipped: Removed newly baselined tests and one defunct test.
  • platform/gtk/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
  • platform/gtk/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt: Added.
  • platform/gtk/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
  • platform/gtk/fast/css/inline-element-line-break-expected.txt: Added.
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt: Added.
  • platform/gtk/fast/css/pseudo-element-line-break-expected.txt: Added.
  • platform/gtk/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.
  • platform/gtk/fast/multicol/single-line-expected.txt: Added.
  • platform/gtk/fast/repaint/block-no-inflow-children-expected.txt: Added.
  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-div-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-small-percent-width-expected.txt: Added.
  • platform/gtk/media/video-replaces-poster-expected.txt: Added.
  • platform/gtk/svg/css/shadow-and-opacity-expected.txt: Copied from LayoutTests/platform/mac/svg/css/shadow-and-opacity-expected.txt.
  • platform/gtk/svg/custom/empty-mask-expected.txt: Added.
  • platform/gtk/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt.
  • platform/gtk/svg/custom/marker-opacity-expected.txt: Added.
  • platform/gtk/svg/custom/marker-referencePoint-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/marker-referencePoint-expected.txt.
  • platform/gtk/svg/custom/mask-invalidation-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt.
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-skew-transformed-expected.txt.
  • platform/gtk/svg/custom/relative-sized-content-expected.txt: Added.
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt: Added.
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt: Added.
  • platform/gtk/svg/custom/stroke-width-large-expected.txt: Added.
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
  • platform/gtk/svg/filters/feDisplacementMap-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/feDisplacementMap-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-inner-svg-element-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
  • platform/gtk/svg/text/selection-background-color-expected.txt: Added.
  • platform/gtk/svg/text/selection-doubleclick-expected.txt: Added.
  • platform/gtk/svg/text/selection-styles-expected.txt: Added.
  • platform/gtk/svg/text/selection-tripleclick-expected.txt: Added.
  • platform/gtk/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/gtk/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/gtk/transforms/2d/hindi-rotated-expected.txt: Added.
13:14 Changeset [61430] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-06-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Don't throw away exception information for functions that use exceptions
https://bugs.webkit.org/show_bug.cgi?id=40786

Simple patch to stop JSC from throwing away the exception information
of a function that uses "exceptiony" features like try and throw. This
is a speed up for catching expressions but it's difficult to quantify as
the old cost of reparsing is amortised over all exceptions caught in the
effected function.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::emitCatch):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitThrow):
13:08 Changeset [61429] by andersca@apple.com
  • 5 edits
    3 adds in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PlatformStrategies and PluginStrategy classes.
https://bugs.webkit.org/show_bug.cgi?id=40850

  • wtf/Platform.h:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PlatformStrategies and PluginStrategy classes.
https://bugs.webkit.org/show_bug.cgi?id=40850

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PlatformStrategies.cpp: Added. (WebCore::PlatformStrategies::~PlatformStrategies): (WebCore::platformStrategies): (WebCore::setPlatformStrategies):
  • platform/PlatformStrategies.h: Added. (WebCore::PlatformStrategies::pluginStrategy): (WebCore::PlatformStrategies::PlatformStrategies):
  • plugins/PluginData.cpp:
  • plugins/PluginStrategy.h: Added. (WebCore::PluginStrategy::~PluginStrategy):
13:01 Changeset [61428] by mrobinson@webkit.org
  • 3 edits in trunk/WebCore

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the GTK+ build after r61413 and 61379.

  • bindings/scripts/CodeGeneratorGObject.pm: Produce a g_value_set that uses getterExpressionPrefix instead of the raw getter.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_property): Update expected test results.
12:45 Changeset [61427] by cfleizach@apple.com
  • 3 edits in trunk/LayoutTests

No review. Fix Tiger and Leopards tests.

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
12:16 Changeset [61426] by leandro@webkit.org
  • 4 edits in trunk

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

  • wtf/CMakeLists.txt: Add MD5.cpp.

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

  • CMakeLists.txt: Add inspector/ScriptBreakpoint.cpp.
12:11 Changeset [61425] by aestes@apple.com
  • 2 edits in trunk/WebCore

Update copyright header.

Rubber-stamped by Sam Weinig.

  • html/HTMLLinkElement.h:
12:03 Changeset [61424] by aestes@apple.com
  • 4 edits
    2 adds in trunk

WebCore: <rdar://problem/8091385> Prevent a crash in WebCore when removing a stylesheet link element in
in a listener to its beforeload event.
https://bugs.webkit.org/show_bug.cgi?id=40742

Reviewed by Dan Bernstein.

Postpone loading of link elements until after they have been inserted into the DOM and
attached. This prevents DOM mutations triggered by beforeload handlers from firing in the
midst of DOM insertion, which can lead to assertion failures and crashes.

Test: fast/dom/beforeload/remove-link-in-beforeload-listener.html

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement): Initialize m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::processCallback): Add a static callback function which calls
HTMLLinkElement::process().
(WebCore::HTMLLinkElement::insertedIntoDocument): Instead of calling process() directly, set
m_shouldProcessAfterAttach to true to indicate that process() should be called after attach().
(WebCore::HTMLLinkElement::removedFromDocument): Set m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::attach): If m_shouldProcessAfterAttach is true, register
HTMLLinkElement::processCallback() as a post-attach callback.

  • html/HTMLLinkElement.h: Add m_shouldProcessAfterAttach.

(WebCore::HTMLLinkElement::canLazyAttach): Override canLazyAttach() to return false to
indicate that a full attach should be performed. This ensures the post-attach callbacks are
fired.

LayoutTests: <rdar://problem/8091385> Test that removing a stylesheet link element in a listener to its
beforeload event does not crash WebCore.
https://bugs.webkit.org/show_bug.cgi?id=40742

Reviewed by Dan Bernstein.

  • fast/dom/beforeload/remove-link-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-link-in-beforeload-listener.html: Added.
11:40 Changeset [61423] by ossy@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected files after r61418.

  • platform/qt/editing/pasteboard/paste-text-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-014-expected.txt:
11:20 WebKit Team edited by luiz@webkit.org
(diff)
11:18 Changeset [61422] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

Unreviewed. Windows build fix.

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

10:58 Changeset [61421] by cfleizach@apple.com
  • 4 edits
    2 adds in trunk

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

Reviewed by David Kilzer.

WebCore:

Test: platform/mac/accessibility/inherited-presentational-lists.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::node):

LayoutTests:

  • platform/mac/accessibility/inherited-presentational-lists-expected.txt: Added.
  • platform/mac/accessibility/inherited-presentational-lists.html: Added.
10:54 Changeset [61420] by darin@apple.com
  • 3 edits in trunk/WebCore

Fix GTK build after reflection change.

  • bindings/scripts/CodeGeneratorGObject.pm: Changed code

that emits setters to convey the correct type of the attribute.
The GObject code generator takes a different approach to attributes
than the others, so it's hacked a bit to make it more like them.
We should find a way to share more code between the different generators.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

Updated to expect correct results.

10:42 Changeset [61419] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-06-18 Yury Semikhatsky <yurys@chromium.org>

Unreviewed: Qt build fix.

  • inspector/InspectorController.cpp:
10:35 Changeset [61418] by justin.garcia@apple.com
  • 21 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=39798
No selection change notification for editing operation that doesn't change the selection's DOM position

Reviewed by Ojan Vafai.

WebCore:

Some editing operations change the selection visually without affecting its position within
the DOM. This was previously known to occur for certain typing commands, but it can also
occur for some Pastes and changes to block style.

  • editing/Editor.cpp:

(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::changeSelectionAfterCommand):

  • editing/Editor.h:

LayoutTests:

block-style-001.html demonstrated the bug, so no new tests have been added.

  • platform/mac/editing/execCommand/format-block-expected.txt:
  • platform/mac/editing/execCommand/outdent-selection-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-005-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-006-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-007-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-014-expected.txt:
  • platform/mac/editing/style/apple-style-editable-mix-expected.txt:
  • platform/mac/editing/style/block-style-001-expected.txt:
  • platform/mac/editing/style/block-style-002-expected.txt:
  • platform/mac/editing/style/block-style-003-expected.txt:
  • platform/mac/editing/style/create-block-for-style-005-expected.txt:
  • platform/mac/editing/style/create-block-for-style-006-expected.txt:
  • platform/mac/editing/style/create-block-for-style-008-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-002-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-003-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-004-expected.txt:
  • platform/mac/editing/style/table-selection-expected.txt:
10:22 Changeset [61417] by atwilson@chromium.org
  • 2 edits in trunk/WebKit/chromium

Roll chromium DEPS 50089:50171
https://bugs.webkit.org/show_bug.cgi?id=40842

Reviewed by Dumitru Daniliuc.

  • DEPS:

Update chromium_rev to r50171 to remove downstream reference to WebFrame::clearName().

10:12 Changeset [61416] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break on Debug build.
https://bugs.webkit.org/show_bug.cgi?id=40810

  • CMakeLists.txt: Add CSSPreloadScanner.cpp
09:59 Changeset [61415] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=40803
TestNetscapePlugin has an incorrect implementation of "property" property

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't pass a static string back, it's going to be released by NPAPI implementation.
09:51 Changeset [61414] by yurys@chromium.org
  • 13 edits
    1 add in trunk/WebCore

2010-06-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: persist breakpoints in inspector settings.
https://bugs.webkit.org/show_bug.cgi?id=14190

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setSessionSettings): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
  • inspector/InspectorController.h:
  • inspector/InspectorValues.cpp: (WebCore::InspectorValue::parseJSON):
  • inspector/InspectorValues.h:
  • inspector/ScriptBreakpoint.cpp: Added. (WebCore::ScriptBreakpoint::sourceBreakpointsFromInspectorObject): (WebCore::ScriptBreakpoint::inspectorObjectFromSourceBreakpoints):
  • inspector/ScriptBreakpoint.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.addBreakpoint): (WebInspector.BreakpointManager.prototype.restoredBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointsForSourceID): (WebInspector.BreakpointManager.prototype.breakpointsForURL): (WebInspector.BreakpointManager.prototype._addBreakpoint):
  • inspector/front-end/inspector.js: (WebInspector.restoredBreakpoint):
09:47 Changeset [61413] by darin@apple.com
  • 78 edits in trunk/WebCore

2010-06-18 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Implement additional DOM attribute reflection for bindings
https://bugs.webkit.org/show_bug.cgi?id=39936

  • Added support for [Reflect] for long, unsigned long, and boolean attributes.
  • Fixed code that set attributes like this: <video controls="controls"> to instead set them like this: <video controls>.
  • Added lots more uses of [Reflect].
  • Removed now-unneeded [ConvertFromString].
  • Made [Reflect] imply [ConvertNullToNullString] so we can get rid of most uses of the latter.
  • Made [Reflect] automatically lowercase the name of the reflected content attribute to minimize the need to specify a custom content attribute name.

One thing this patch does *not* do is remove the unneeded functions
in the various DOM classes that are no longer used by the bindings.
We should do that in a followup.

  • bindings/scripts/CodeGenerator.pm: Added new functions so code can be shared across bindings, GetterExpressionPrefix and SetterExpressionPrefix. We can do a lot more refactoring like this in the future.
  • bindings/scripts/CodeGeneratorCPP.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes.
  • bindings/scripts/CodeGeneratorGObject.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes. Fixed a few things in the output so the .cpp file will have more WebKit style. The .h file should be GTK style, but the .cpp file can be the standard WebKit style eventually.
  • bindings/scripts/CodeGeneratorJS.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/CodeGeneratorObjC.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Redid the special cases for ownerDocument and for operator to fit better with the new code paths. Removed unneeded ConvertFromString handling.
  • bindings/scripts/CodeGeneratorV8.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/test/TestObj.idl: Added some test cases for content attribute reflection and for exceptions in string-typed attributes.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.cpp: Updated.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
  • dom/Element.cpp: (WebCore::Element::getIntegralAttribute): Added. (WebCore::Element::setIntegralAttribute): Added. (WebCore::Element::getUnsignedIntegralAttribute): Added. (WebCore::Element::setUnsignedIntegralAttribute): Added.
  • dom/Element.h: Added new attribute get/set functions for bindings.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isURLAttribute): Added. Returns true for srcAttr.
  • html/HTMLMediaElement.h: Added isURLAttribute.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::isURLAttribute): Changed to call HTMLMediaElement::isURLAttribute before checking for posterAttr.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
  • svg/SVGElement.idl: Added more uses of [Reflect]. Got rid of uses of [ConvertNullToNullString] that are now unneeded since [Reflect] now implies that. Changed formatting to be simpler and consistent without all the lining up and multiple lines.
09:39 Changeset [61412] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Remove some unnecessary checks that cause compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=40772

Reviewed by Dimitri Glazkov.

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/npruntime.cpp:
09:11 Changeset [61411] by mnaganov@chromium.org
  • 13 edits in trunk

2010-06-18 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Implement 'takeHeapSnapshot' in InspectorController.

https://bugs.webkit.org/show_bug.cgi?id=40834

  • bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::takeHeapSnapshot):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::takeHeapSnapshot):
  • inspector/InspectorController.h:
  • src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
  • src/js/ProfilerAgent.js: (devtools.ProfilerAgent.prototype.startProfiling):
08:55 Changeset [61410] by mitz@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r61379?): Assertion failure in Element::getURLAttribute() when accessing the src attribute of a script element
https://bugs.webkit.org/show_bug.cgi?id=40831

Reviewed by Anders Carlsson.

WebCore:

Test: fast/dom/HTMLScriptElement/isURLAttribute.html

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::isURLAttribute): Check for the 'src' attribute.

LayoutTests:

  • fast/dom/HTMLScriptElement/isURLAttribute-expected.txt: Added.
  • fast/dom/HTMLScriptElement/isURLAttribute.html: Added.
08:54 Changeset [61409] by dglazkov@chromium.org
  • 33 edits
    29 adds
    23 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

New baselines after http://trac.webkit.org/changeset/61393.

08:46 Changeset [61408] by eric@webkit.org
  • 5 edits
    3 deletes in trunk

2010-06-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61405.
http://trac.webkit.org/changeset/61405
https://bugs.webkit.org/show_bug.cgi?id=40838

broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).

  • fast/js/parser-high-byte-character-expected.txt: Removed.
  • fast/js/parser-high-byte-character.html: Removed.
  • fast/js/script-tests/parser-high-byte-character.js: Removed.

2010-06-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61405.
http://trac.webkit.org/changeset/61405
https://bugs.webkit.org/show_bug.cgi?id=40838

broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
08:44 Changeset [61407] by leandro@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
08:40 QtWebKitJournal edited by hausmann@webkit.org
(diff)
08:14 Changeset [61406] by eric@webkit.org
  • 8 edits in trunk

2010-06-18 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
https://bugs.webkit.org/show_bug.cgi?id=40176

  • fast/canvas/webgl/gl-object-get-calls-expected.txt: Test name == 0 cases, and test getVertexAttrib return original WebGLBuffer object.
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.

2010-06-18 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
https://bugs.webkit.org/show_bug.cgi?id=40176

  • html/canvas/WebGLBuffer.cpp: Remove constructor with existing name.
  • html/canvas/WebGLBuffer.h: Ditto.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getVertexAttrib): Use findBuffer instead of creating a new WebGLBuffer. (WebCore::WebGLRenderingContext::findTexture): Deal with name == 0 case and return raw pointer. (WebCore::WebGLRenderingContext::findRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::findBuffer): Find WebGLBuffer object using given name.
  • html/canvas/WebGLRenderingContext.h: Add findBuffer function declaration, change return type to raw pointer.
08:00 Changeset [61405] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

When V8 ScriptData caching was originally submitted it causes crashes
in external scripts with high-byte characters. This new test crashes on
the original code, but now passes.

  • fast/js/parser-high-byte-character-expected.txt: Added.
  • fast/js/parser-high-byte-character.html: Added.
  • fast/js/script-tests/parser-high-byte-character.js: Added. (runTest):

2010-06-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark showed a ~7% improvement when this was
originally submitted (before it had to be rolled back).

Test: fast/js/parser-high-byte-character.html

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
06:35 Changeset [61404] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Fix documentation for the declarative module import.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
06:09 Changeset [61403] by krit@webkit.org
  • 9 edits in trunk/LayoutTests

2010-06-18 Dirk Schulze <krit@webkit.org>

Not reviewed. Rebaseline gtk results.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
05:50 Changeset [61402] by antonm@chromium.org
  • 4 edits in trunk

2010-06-18 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Finish migration to new named property query API
https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.
Requires V8 roll.

  • DEPS:

2010-06-18 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Finish migration to new named property query API
https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.

  • config.h:
05:50 Changeset [61401] by zimmermann@webkit.org
  • 6 edits
    3 adds in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline win results.

  • platform/win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • platform/win/svg/custom/broken-internal-references-expected.txt:
  • platform/win/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/win/svg/custom/junk-data-expected.txt: Added.
  • platform/win/svg/custom/missing-xlink-expected.txt: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
05:38 Changeset [61400] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Fix documentation issue on the onAlert handler.
Fix compilation issue with QT_NO_ACTION.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
  • declarative/qdeclarativewebview_p.h:
05:34 Changeset [61399] by zimmermann@webkit.org
  • 5 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline mac-snowleopard results.

  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
05:28 Changeset [61398] by zimmermann@webkit.org
  • 6 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline mac-tiger test results.

  • platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003a-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
05:27 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:27 Changeset [61397] by pfeldman@chromium.org
  • 15 edits in trunk

2010-06-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: bring XHR console records back.

  • adds "Enable XHR Monitor" / "Disable XHR Monitor" actions to the console's context menu
  • make the chosen option persist in the settings.

https://bugs.webkit.org/show_bug.cgi?id=40799

  • English.lproj/localizedStrings.js:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::disableSearchingForNode): (WebCore::InspectorBackend::enableMonitoringXHR): (WebCore::InspectorBackend::disableMonitoringXHR):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setMonitoringXHR): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::ensureSettingsLoaded):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::monitoringXHRWasEnabled): (WebCore::InspectorFrontend::monitoringXHRWasDisabled):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._handleContextMenuEvent): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.enableMonitoringXHR): (.WebInspector.InspectorBackendStub.prototype.disableMonitoringXHR):
  • inspector/front-end/inspector.js: (WebInspector.monitoringXHRWasEnabled): (WebInspector.monitoringXHRWasDisabled):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
05:25 Changeset [61396] by zimmermann@webkit.org
  • 17 edits
    2 adds in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaselined Qt test results.

  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/mask-invalidation-expected.txt:
  • platform/qt/svg/custom/stroke-width-large-expected.txt:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/dom/altGlyph-dom-expected.txt: Added.
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt: Added.
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-doubleclick-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.txt:
  • platform/qt/svg/text/selection-tripleclick-expected.txt:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
05:23 Changeset [61395] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

REGRESSION(r60958) [Qt] qwebpage::inputMethods auto-test fails
https://bugs.webkit.org/show_bug.cgi?id=40830

Reviewed by Antti Koivisto.

When activating a regular input method field, always set or unset the ImhHiddenText
input method hint.

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

04:37 Changeset [61394] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-18 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Merge text_expectations.txt of Chromium tree. Mainly for <progress> and <meter>.
04:18 Changeset [61393] by zimmermann@webkit.org
  • 759 edits
    4 moves
    102 adds in trunk

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Modernize SVG Text code, following the HTML design
https://bugs.webkit.org/show_bug.cgi?id=40663

SVG Text does not support subpixel positioning
https://bugs.webkit.org/show_bug.cgi?id=12172

RenderSVGText can't do partial repaints
https://bugs.webkit.org/show_bug.cgi?id=15386

HTML and SVG need to share more text painting code
https://bugs.webkit.org/show_bug.cgi?id=15644

Rewrite SVG Text rendering, only keeping the layout of the actual characters/chunks as it was.
We're now drawing SVG Text very similar to HTML Text, utilizing the SVGInlineFlowBox/SVGInlineTextBox structure,
instead of painting all text content of a <text> element from the SVGRootInlineBox, as it was the last years.

Rough overview of the changes:

  • Partial repainting support for text selections (startPos/endPos are respected), no more redrawing of the whole <text> content while selecting
  • Subpixel positioning (near pixel-perfect rendering for all W3C tests that contain text, finally!) -> much better textPath results, characters now align as expected, as all rounding hacks are disabled for SVG text runs, and subpixel precision is used while painting
  • No more custom handling of selection, the standard methods offsetFromPosition() / selectionRectForText() are used instead.
  • Selection works as expected on stretched/squeezed text (lengthAdjust="spacingAndGlyphs"), takes 'includePartialGlyphs' into account - just like HTML text
  • Correct text decoration drawing (proper with and positions and rendering-order, underline/overline before text, strike-through afterwards)
  • Proper sizing of all InlineBoxes, starting from the SVGRootInlineBox, down to every single flow & text box -> correct DRT results, no more weird negative offsets of text runs, etc. Looks exactly like the HTML text test results.
  • Rewritten SVGTextContentElement API to take per-character / per-chunk transformations into account.
  • Speeeeeed! Drawing is much faster now.

Add 24 new testcases covering basic selection features and the SVGTextContentElement API. Each test draws a half-opaque red rectangle, calculated using
SVGTextContentElement API to highlight the area that is supposed to be selected. Then eventSender API is utilized to move the mouse to the calculated
start origin, holding it down and moving it to the end position.

A detailed list of tests that show progression, can be found in the corresponding LayoutTests/ChangeLog.
Note that this requires a rebaselining of all SVG tests containing text elements.

Tests: svg/hixie/text/001.xml (moved from svg/hixie/text/001-broken.xml)

svg/text/lengthAdjust-text-metrics.html
svg/text/select-textLength-spacing-squeeze-1.svg
svg/text/select-textLength-spacing-squeeze-2.svg
svg/text/select-textLength-spacing-squeeze-3.svg
svg/text/select-textLength-spacing-squeeze-4.svg
svg/text/select-textLength-spacing-stretch-1.svg
svg/text/select-textLength-spacing-stretch-2.svg
svg/text/select-textLength-spacing-stretch-3.svg
svg/text/select-textLength-spacing-stretch-4.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-3.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-4.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-1.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-3.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-4.svg
svg/text/select-x-list-1.svg
svg/text/select-x-list-2.svg
svg/text/select-x-list-3.svg
svg/text/select-x-list-4.svg
svg/text/select-x-list-with-tspans-1.svg
svg/text/select-x-list-with-tspans-2.svg
svg/text/select-x-list-with-tspans-3.svg
svg/text/select-x-list-with-tspans-4.svg

  • rendering/InlineBox.h: Remove not needed isInlineBox() method. (WebCore::InlineBox::isInlineTextBox): Constify this method. (WebCore::InlineBox::isSVGInlineTextBox): Added, with ENABLE(SVG) guards, just like the existing isSVGRootInlineBox(). (WebCore::InlineBox::isSVGRootInlineBox): Constify this method. (WebCore::InlineBox::calculateBoundaries): Added, with ENABLE(SVG) guards, used to calculate the whole boundaries of a InlineText/FlowBox, only used in SVG text.
  • rendering/InlineFlowBox.h: Devirtualize placeBoxesHorizontally(), SVG no more overrides it.
  • rendering/InlineTextBox.h: Virtualize selectionStartEnd() - SVGInlineTextBox needs to change start/endPositions based on the current text chunk part that it's rendering.

SVGTextChunkLayoutInfo.h contains a detailed documentation what a SVGTextChunk/SVGTextChunkPart is, and why they are necessary.

(WebCore::InlineTextBox::isInlineTextBox): Constify this method.

  • rendering/RenderBlock.h: (WebCore::RenderBlock::forceLayoutInlineChildren): Add helper method, used only by RenderSVGText, to use a simplified layout strategy, which is a big speed win.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Remove all isSVGText() special cases, as this function is not called anymore for SVG text. (WebCore::RenderBlock::layoutInlineChildren): Don't call computeHorizontalPositionsForLine() for SVG text. computePerCharacterLayoutInformation() overrides it anyway.
  • rendering/RenderSVGInline.cpp: Remove custom absoluteRects/absoluteQuads code, all shared with RenderInline now. (WebCore::RenderSVGInline::clippedOverflowRectForRepaint): Added, forward to SVGRenderBase, just like all other non-text SVG renderers do. (WebCore::RenderSVGInline::computeRectForRepaint): Ditto. (WebCore::RenderSVGInline::mapLocalToContainer): Ditto
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGInlineText.cpp: Remove destroy() hack, which called setNeedsLayoutAndPrefWidthsRecalc/repaint on destruction.

As repaint rects work properly now, this hack is no longer necessary, it was only hiding the real problem.

(WebCore::RenderSVGInlineText::styleDidChange): Don't skip RenderText::styleDidChange() anymore, which automatically schedules layout changes for us.
(WebCore::RenderSVGInlineText::localCaretRect): Remove outdated comment, localCaretRect() is not yet needed in SVG text code.

  • rendering/RenderSVGInlineText.h: Remove custom absoluteRects/absoluteQuads/selectionRectForRepaint/positionForPoint/destroy/computeRectForRepaint* code, all shared with RenderText now.
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer): Take x/y translation into account, but do NOT include in localToParentTransform(), as that would affect rendering. (WebCore::RenderSVGText::layout): Use super-simplified layout strategy, removing a lot of uncessary stuff done by RenderBlock, that SVG does not need. (WebCore::RenderSVGText::absoluteRects): Remove dead-code, retreving the RenderSVGRoot* object, not necessary since a longer time. (WebCore::RenderSVGText::absoluteQuads): Ditto. (WebCore::RenderSVGText::paint): Early exit if we're not in PaintPhaseForeground/PaintPhaseSelfOutline. We're not interessted in other phases. (WebCore::RenderSVGText::strokeBoundingBox): Fix stroke width calculation, no need to special case SVGFonts.
  • rendering/RenderSVGText.h: Remove updateFirstLineBlock/updateFirstLetter overrides, the new RenderSVGText::layout() code, doesn't use these methods at all.

We asked RenderBlock to layout before, which was calling updateFirstLetter & co, this is gone now, as it was all not needed.

(WebCore::RenderSVGText::objectBoundingBox): Directly return the frameRect here, inlined for speed.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::verticallyAlignBoxes): Early-exit if we're a SVGRootInlineBox. SVG handles this on its own.
  • rendering/RootInlineBox.h: Devirtualize verticallyAlignBoxes(), SVG no longer overrides it. Remove virtual computePerCharacterLayoutInformation() method, only lives in SVGRootInlineBox now.
  • rendering/SVGCharacterData.h: Remove no longer needed SVGTextDecorationInfo.
  • rendering/SVGCharacterLayoutInfo.cpp: Don't pass a reference to a Vector<SVGChar> to SVGCharacterLayoutInfo, let it create it. (WebCore::SVGCharacterLayoutInfo::SVGCharacterLayoutInfo):
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint): Ask children to paint. (WebCore::SVGInlineFlowBox::calculateBoundaries): Calculate boundaries by uniting all direct children boundaries.
  • rendering/SVGInlineFlowBox.h: Remove placeBoxesHorizontally, which does not get called anymore, and does not need to be overriden.
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::SVGInlineTextBox): Don't use abbrevations for variable names, initialize new member variables. (WebCore::SVGInlineTextBox::measureCharacter): New helper function extracted from buildLayoutInformation, replacing calculateGlyphWidth/Height. (WebCore::SVGInlineTextBox::offsetForPosition): Implement this method by utilizing Font::offsetForPosition(), but respecting the text chunk parts. (WebCore::SVGInlineTextBox::positionForOffset): No change here, still not used. (WebCore::SVGInlineTextBox::selectionRect): Rewritten, utilizing Font::selectionRectForText(), taking text chunk parts into account, and the supplied startPos/endPos. (WebCore::SVGInlineTextBox::paint): Rewritten, to handle paint servers much more elegant, than the old solution. See code for details, too much to explain here. (WebCore::SVGInlineTextBox::acquirePaintingResource): Helper function, used from paint(). (WebCore::SVGInlineTextBox::releasePaintingResource): Ditto. (WebCore::SVGInlineTextBox::prepareGraphicsContextForTextPainting): Ditto. (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting): Ditto. (WebCore::SVGInlineTextBox::constructTextRun): Helper function centralizing the creation of a TextRun object, used to draw/measure SVG text. (WebCore::SVGInlineTextBox::mapStartEndPositionsIntoChunkPartCoordinates): Important helper function, mapping a startPos/endPos from InlineTextBox

coordinate space to the SVGInlineTextBox, respecting the current text chunk part.

(WebCore::SVGInlineTextBox::selectionStartEnd): Call InlineTextBox::selectionStartEnd(), and apply post fixes when m_currentChunkPart is set. (called when painting a selected chunk part)
(WebCore::positionOffsetForDecoration): Refactored from old paintDecoration() code.
(WebCore::thicknessForDecoration): Ditto.
(WebCore::findRenderObjectDefininingTextDecoration): Ditto.
(WebCore::SVGInlineTextBox::paintDecoration): Ditto. (Can not share the code with HTML, as we need floating point precision, and directly call fillRect, instead of drawHighlightForText.)
(WebCore::SVGInlineTextBox::paintDecorationWithStyle): Ditto.
(WebCore::SVGInlineTextBox::paintSelection): New method, painting text selections with floating-point precision.
(WebCore::SVGInlineTextBox::paintText): New method, painting text with floating-point precision, correctly handling selected text, removing the need for special SVG text sub-paint phases.

(GlyphFill/StrokeSelectionPhase, GlyphFill/StrokePhase)

(WebCore::SVGInlineTextBox::buildLayoutInformation): Use new measureCharacter() helper function, renamed some variables, to avoid abbrevations.
(WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Rewritten to use new measureCharacter() helper function.
(WebCore::SVGInlineTextBox::calculateBoundaries): Rewritten to take text chunk parts into account, serves as central method used to layout InlineBoxes (see SVGRootInlineBox.)

  • rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::isSVGInlineTextBox): Added. (WebCore::SVGInlineTextBox::setHeight): Rename variable, to avoid abbrevations. (WebCore::SVGInlineTextBox::chunkTransformation): New helper function, returning the transformation, that gets applied to the complete text chunk, if any. (WebCore::SVGInlineTextBox::setChunkTransformation): New helper function used by SVGRrootInlineBox, to set the chunk transformation, during text chunk part propagation phase. (WebCore::SVGInlineTextBox::addChunkPartInformation): Ditto. (WebCore::SVGInlineTextBox::svgTextChunkParts): Ditto.
  • rendering/SVGRootInlineBox.cpp: Virtually rewritten, to be designed more like HTMLs RootInlineBox, diving into children for painting. (WebCore::SVGRootInlineBox::paint): Ask children to paint, nothing more. No more traversing through the SVGTextChunks, figuring out which part to render, this is done in layout phase now. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Completly redesigned, see SVGTextChunkLayoutInfo.h for a high-level overview. (WebCore::SVGRootInlineBox::buildLayoutInformation): Just small cleanups, nothing changed here. (WebCore::SVGRootInlineBox::layoutChildBoxes): New helper function, extracted from old layoutInlineBoxes(). (WebCore::SVGRootInlineBox::layoutRootBox): Ditto. (WebCore::SVGRootInlineBox::propagateTextChunkPartInformation): Key-concept of the new design, builds "text chunk parts" and propagates that knownledge to all child SVGInlineTextBoxes.
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::isSVGRootInlineBox): Constified method. (WebCore::SVGRootInlineBox::setHeight): Change variable name, to avoid abbrevations.
  • rendering/SVGTextChunkLayoutInfo.cpp: Remove if 0, enable compilation.
  • rendering/SVGTextChunkLayoutInfo.h: Add large comment explaining text chunk parts, the key concept of the new design. Remove SVGTextChunkWalker & friends, no longer used. (WebCore::SVGTextChunkPart::SVGTextChunkPart): (WebCore::SVGTextChunkPart::isValid): (WebCore::SVGTextChunk::SVGTextChunk): (WebCore::SVGTextChunkLayoutInfo::SVGTextChunkLayoutInfo): (WebCore::SVGTextChunkLayoutInfo::textChunks):
  • rendering/SVGTextLayoutUtilities.cpp: (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::cummulatedHeightOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox): Disable rounding hacks, explain parameters with comments, why they have which values.
  • rendering/SVGTextLayoutUtilities.h: Remove SVGTextPaintSubphase and SVGTextPaintInfo.
  • rendering/SVGTextQuery.cpp: Remove if 0, enable compilation.
  • rendering/SVGTextQuery.h: Ditto.
  • svg/SVGStyledElement.cpp: Very important change! Do not treat CSS attributes as recognized attributes, that would lead to setNeedsLayout() calls, reducing performance!

This hack existed, as we were not dealing with text updates correctly, now that RenderSVGInlineText::styleDidChange is fixed, it's no longer necessary.

(WebCore::SVGStyledElement::isKnownAttribute):

  • svg/SVGTextContentElement.cpp: Completely remove the SVGTextContentElement API, that manually traversed all text chunks, instead use the new SVGTextQuery API. (WebCore::SVGTextContentElement::getNumberOfChars): (WebCore::SVGTextContentElement::getComputedTextLength): (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::getStartPositionOfChar): (WebCore::SVGTextContentElement::getEndPositionOfChar): (WebCore::SVGTextContentElement::getExtentOfChar): (WebCore::SVGTextContentElement::getRotationOfChar): (WebCore::SVGTextContentElement::getCharNumAtPosition):
  • svg/SVGTextElement.cpp: Very important change! Do not calls setNeedsLayout() on RenderSVGText, if childrenChanged() has been called.
  • svg/SVGTextElement.h: Completly remove childrenChanged() - no longer necessary, updates work as expected without it now.
03:41 Changeset [61392] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by David Levin.

Fix compilation when filters are disabled. Revision r60689
changed the signature of SVGRenderBase::prepareToRenderSVGContent()
but didn't change the unsused parameters when filters are disabled.
https://bugs.webkit.org/show_bug.cgi?id=40625

No new tests. Compilation fix.

  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
03:28 Changeset [61391] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309

Test that data URLs can access their inline style sheets.

  • http/tests/security/data-url-inline.css-expected.txt: Added.
  • http/tests/security/data-url-inline.css.html: Added.

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309

Instead of using baseURL() to grab the security context we should just
use finalURL directly. When I wrote the original patch that added this
security check, finalURL didn't exist yet.

If finalURL is an empty URL, that means we generated the style sheet
from text that didn't have a URL. It would be slightly safer to store
a bit on CSSStyleSheet indicating whether it came from an inline style
sheet, but I think this check is fairly accurate.

Test: http/tests/security/data-url-inline.css.html

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
03:04 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
02:31 Changeset [61390] by abarth@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180

We don't appear to require a custom binding here. The old function was
wacky in two ways:

1) It required all of its arguments.

2) If the toString of its argument threw, it would catch the exception

and re-throw a different exception.

I've kept the first behavior but changed the second (and documented it
with a test).

Test: websocket/tests/send-throw.html

  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • websockets/WebSocket.idl:

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180

Test what happens when you pass an object to WebSocket.send that throws
when you convert it to a string.

  • websocket/tests/script-tests/send-throw.js: Added. (endTest): (FIRST_MESSAGE_TO_SEND.toString): (ws.onopen): (ws.onclose): (timeOutCallback):
  • websocket/tests/send-throw-expected.txt: Added.
  • websocket/tests/send-throw.html: Added.
02:18 Changeset [61389] by hausmann@webkit.org
  • 4 edits in trunk

WebKit: [qt] Better check for the declarative plugin inclusion.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • WebKit.pro:

WebKit/qt: [Qt] Change the target path to QtWebKit.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/declarative.pro:
02:16 Changeset [61388] by dumi@chromium.org
  • 25 edits in trunk

Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

WebCore:

  • WebCore.base.exp
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::isAvailable):
(WebCore::AbstractDatabase::setIsAvailable):

  • storage/AbstractDatabase.h:
  • storage/Database.cpp:
  • storage/Database.h:
  • storage/DatabaseSync.cpp:
  • storage/DatabaseSync.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):
(WebCore::WorkerContext::openDatabaseSync):

  • workers/WorkerContext.h:

WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):

WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
(webkit_get_cache_model):

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

WebKit/win:

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

WebKit/wx:

  • WebView.cpp:

(wxWebView::SetDatabasesEnabled):
(wxWebView::AreDatabasesEnabled):

02:01 Changeset [61387] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Try to turn Gtk 32-bit Linux Debug green again.

  • platform/gtk/Skipped:
01:58 Changeset [61386] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Fix the namespace indent for HTML5Lexer. This patch changes
white-space only.

  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::): (WebCore::HTML5Lexer::lineNumber): (WebCore::HTML5Lexer::columnNumber): (WebCore::HTML5Lexer::state): (WebCore::HTML5Lexer::setState): (WebCore::HTML5Lexer::skipLeadingNewLineForListing): (WebCore::HTML5Lexer::InputStreamPreprocessor::InputStreamPreprocessor): (WebCore::HTML5Lexer::InputStreamPreprocessor::nextInputCharacter): (WebCore::HTML5Lexer::InputStreamPreprocessor::peek): (WebCore::HTML5Lexer::InputStreamPreprocessor::advance):
01:28 Changeset [61385] by ukai@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed test breakage fix.

WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340

MessageLoop runs in main thread, so we don't need to use timer in worker thread.
Also, we should not use Timer in worker thread.

  • websockets/ThreadableWebSocketChannelClientWrapper.h:

(WebCore::ThreadableWebSocketChannelClientWrapper::resume):
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):

00:22 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)

06/17/10:

23:58 Changeset [61384] by eric@webkit.org
  • 75 edits in trunk/WebCore

2010-06-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61379.
http://trac.webkit.org/changeset/61379
https://bugs.webkit.org/show_bug.cgi?id=40813

Broke multiple tests on all platforms (Requested by tkent on
#webkit).

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::attrWithException): (WebDOMTestObj::setAttrWithException): (WebDOMTestObj::attrWithSetterException): (WebDOMTestObj::attrWithGetterException): (WebDOMTestObj::setAttrWithGetterException):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_void_method): (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws): (webkit_dom_test_obj_serialized_value): (webkit_dom_test_obj_method_with_exception): (webkit_dom_test_obj_with_dynamic_frame): (webkit_dom_test_obj_with_dynamic_frame_and_arg): (webkit_dom_test_obj_with_dynamic_frame_and_optional_arg): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad): (webkit_dom_test_obj_with_script_state_void): (webkit_dom_test_obj_with_script_state_obj): (webkit_dom_test_obj_with_script_state_void_exception): (webkit_dom_test_obj_with_script_state_obj_exception): (webkit_dom_test_obj_with_script_execution_context): (webkit_dom_test_obj_method_with_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg): (webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args): (webkit_dom_test_obj_get_read_only_int_attr): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_int_attr): (webkit_dom_test_obj_set_int_attr): (webkit_dom_test_obj_get_long_long_attr): (webkit_dom_test_obj_set_long_long_attr): (webkit_dom_test_obj_get_unsigned_long_long_attr): (webkit_dom_test_obj_set_unsigned_long_long_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_attr_with_exception): (webkit_dom_test_obj_set_attr_with_exception): (webkit_dom_test_obj_get_attr_with_setter_exception): (webkit_dom_test_obj_set_attr_with_setter_exception): (webkit_dom_test_obj_get_attr_with_getter_exception): (webkit_dom_test_obj_set_attr_with_getter_exception): (webkit_dom_test_obj_get_script_string_attr): (webkit_dom_test_obj_get_conditional_attr1): (webkit_dom_test_obj_set_conditional_attr1): (webkit_dom_test_obj_get_conditional_attr2): (webkit_dom_test_obj_set_conditional_attr2): (webkit_dom_test_obj_get_conditional_attr3): (webkit_dom_test_obj_set_conditional_attr3): (webkit_dom_test_obj_get_description): (webkit_dom_test_obj_get_id): (webkit_dom_test_obj_set_id): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjAttrWithException): (WebCore::jsTestObjAttrWithSetterException): (WebCore::jsTestObjAttrWithGetterException): (WebCore::setJSTestObjAttrWithException): (WebCore::setJSTestObjAttrWithGetterException): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::attrWithExceptionAttrGetter): (WebCore::TestObjInternal::attrWithExceptionAttrSetter): (WebCore::TestObjInternal::attrWithSetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrGetter): (WebCore::TestObjInternal::attrWithGetterExceptionAttrSetter): (WebCore::TestObjInternal::overloadedMethodCallback): (WebCore::):
  • dom/Element.cpp:
  • dom/Element.h:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
  • svg/SVGElement.idl:
23:42 Changeset [61383] by rwlbuis@webkit.org
  • 5 edits
    2 adds in trunk

2010-06-17 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dave Hyatt.

CSS3 "Property is declared twice in rule" test fails
https://bugs.webkit.org/show_bug.cgi?id=36282

Filter out duplicate properties in style declaration.

Test: fast/css/duplicate-property-in-rule.html

  • css/CSSMutableStyleDeclaration.cpp: Filter out duplicate properties (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Discard negative padding values
  • css/CSSStyleSelector.cpp: Remove negative padding check (WebCore::CSSStyleSelector::applyProperty):
23:11 Changeset [61382] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-06-17 MORITA Hajime <morrita@google.com>

Unreviewed. Fixed a path of meter-element.html on Skipped list.

  • platform/qt/Skipped:
23:05 Changeset [61381] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Adding a test case to change-version.html + minor clean-ups.
https://bugs.webkit.org/show_bug.cgi?id=40604

Reviewed by Adam Barth.

  • storage/change-version.html:
23:00 Changeset [61380] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Update <meter> tests.
22:57 Changeset [61379] by darin@apple.com
  • 75 edits in trunk/WebCore

2010-06-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Implement additional DOM attribute reflection for bindings
https://bugs.webkit.org/show_bug.cgi?id=39936

  • Added support for [Reflect] for long, unsigned long, and boolean attributes.
  • Fixed code that set attributes like this: <video controls="controls"> to instead set them like this: <video controls>.
  • Added lots more uses of [Reflect].
  • Removed now-unneeded [ConvertFromString].
  • Made [Reflect] imply [ConvertNullToNullString] so we can get rid of most uses of the latter.
  • Made [Reflect] automatically lowercase the name of the reflected content attribute to minimize the need to specify a custom content attribute name.

One thing this patch does *not* do is remove the unneeded functions
in the various DOM classes that are no longer used by the bindings.
We should do that in a followup.

  • bindings/scripts/CodeGenerator.pm: Added new functions so code can be shared across bindings, GetterExpressionPrefix and SetterExpressionPrefix. We can do a lot more refactoring like this in the future.
  • bindings/scripts/CodeGeneratorCPP.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes.
  • bindings/scripts/CodeGeneratorGObject.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes. Fixed a few things in the output so the .cpp file will have more WebKit style. The .h file should be GTK style, but the .cpp file can be the standard WebKit style eventually.
  • bindings/scripts/CodeGeneratorJS.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/CodeGeneratorObjC.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Redid the special cases for ownerDocument and for operator to fit better with the new code paths. Removed unneeded ConvertFromString handling.
  • bindings/scripts/CodeGeneratorV8.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/test/TestObj.idl: Added some test cases for content attribute reflection and for exceptions in string-typed attributes.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.cpp: Updated.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
  • dom/Element.cpp: (WebCore::Element::getIntegralAttribute): Added. (WebCore::Element::setIntegralAttribute): Added. (WebCore::Element::getUnsignedIntegralAttribute): Added. (WebCore::Element::setUnsignedIntegralAttribute): Added.
  • dom/Element.h: Added new attribute get/set functions for bindings.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
  • svg/SVGElement.idl: Added more uses of [Reflect]. Got rid of uses of [ConvertNullToNullString] that are now unneeded since [Reflect] now implies that. Changed formatting to be simpler and consistent without all the lining up and multiple lines.
22:48 Changeset [61378] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-06-17 MORITA Hajime <morrita@google.com>

Unreviewed. Disabled meter-element.html temporally.
We need to rebaseline it.

  • platform/qt/Skipped:
22:35 Changeset [61377] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-06-17 MORITA Hajime <morrita@google.com>

Unreviewd, fixed a build break.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId):
22:13 Changeset [61376] by morrita@google.com
  • 31 edits
    2 copies
    8 adds in trunk

2010-06-15 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<meter> should allow styling for each gauge-level and component
https://bugs.webkit.org/show_bug.cgi?id=40280

  • Updated expectations because both rendering result, render tree structure, html.css was changed.
  • fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html: Added.
  • fast/dom/HTMLMeterElement/meter-styles.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/win/Skipped:

2010-06-16 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<meter> should allow styling for each gauge-level and component
https://bugs.webkit.org/show_bug.cgi?id=40280

  • Introduced following new pseudo classes for <meter> element.
  • -webkit-meter-horizontal-bar
  • -webkit-meter-vertical-bar
  • -webkit-meter-horizontal-optimum-value
  • -webkit-meter-vertical-optimum-value
  • -webkit-meter-horizontal-suboptimal-value
  • -webkit-meter-vertical-suboptimal-value
  • -webkit-meter-horizontal-even-less-good-value
  • -webkit-meter-vertical-even-less-good-value
  • Introduced 2 shadow nodes for RenderMeter to handle CSS styling. one for bar part and another for value part.
  • Removed RenderTheme::paintMeter() implementation because it can be handled by styled painting without RenderTheme.
  • Pulled RenderIndicator up to super class from RenderProgress, then make RenderMeter a subclass of it.
  • Moved shadow related methods from RenderProgress to ShadowBlockElement to share it with RenderMeter.
  • Added rules for html.css for new pseudo classes.

Tests: fast/dom/HTMLMeterElement/meter-styles-changing-pseudo.html

fast/dom/HTMLMeterElement/meter-styles.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/html.css: (meter::-webkit-meter-horizontal-bar): (meter::-webkit-meter-vertical-bar): (meter::-webkit-meter-horizontal-optimum-value): (meter::-webkit-meter-horizontal-suboptimal-value): (meter::-webkit-meter-horizontal-even-less-good-value): (meter::-webkit-meter-vertical-optimum-value): (meter::-webkit-meter-vertical-suboptimal-value): (meter::-webkit-meter-vertical-even-less-good-value):
  • rendering/RenderIndicator.cpp: Added. (WebCore::RenderIndicator::RenderIndicator): (WebCore::RenderIndicator::~RenderIndicator): (WebCore::RenderIndicator::layout): (WebCore::RenderIndicator::styleDidChange): (WebCore::RenderIndicator::updateFromElement): (WebCore::RenderIndicator::hasParts): (WebCore::RenderIndicator::requestLayoutForParts):
  • rendering/RenderIndicator.h: Added. (WebCore::RenderIndicator::requiresForcedStyleRecalcPropagation):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): (WebCore::RenderMeter::~RenderMeter): (WebCore::RenderMeter::layoutParts): Added. (WebCore::RenderMeter::shouldHaveParts): Added. (WebCore::RenderMeter::valueRatio): Added. (WebCore::RenderMeter::barPartRect): Added. (WebCore::RenderMeter::valuePartRect): Added. (WebCore::RenderMeter::isHorizontal): Added. (WebCore::RenderMeter::valuePseudoId): Added. (WebCore::RenderMeter::barPseudoId): Added. (WebCore::RenderMeter::updatePartsState): Added.
  • rendering/RenderMeter.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::paint): (WebCore::RenderProgress::layoutParts): Added. (WebCore::RenderProgress::shouldHaveParts): Added. (WebCore::RenderProgress::updatePartsState): (WebCore::RenderProgress::valuePartRect):
  • rendering/RenderProgress.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::paintMeter):
  • rendering/RenderTheme.h: (WebCore::RenderTheme::supportsMeter): Added.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::supportsMeter): Added.
  • rendering/ShadowElement.cpp: (WebCore::ShadowBlockElement::layoutAsPart): Added. (WebCore::ShadowBlockElement::updateStyleForPart): Added. (WebCore::ShadowBlockElement::createForPart): Added. (WebCore::ShadowBlockElement::createStyleForPart): Added. (WebCore::ShadowBlockElement::partShouldHaveStyle): Added.
  • rendering/ShadowElement.h:
  • rendering/style/RenderStyleConstants.h: (WebCore::):
21:30 Changeset [61375] by ukai@chromium.org
  • 5 edits
    4 adds in trunk

2010-06-17 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340

Reviewed by Alexey Proskuryakov.

  • websocket/tests/alert-in-event-handler-expected.txt: Added.
  • websocket/tests/alert-in-event-handler.html: Added.
  • websocket/tests/script-tests/alert-in-event-handler.js: Added.
  • websocket/tests/send2_wsh.py: Added.

2010-06-17 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340

Test: websocket/tests/alert-in-event-handler.html

While running an event handler of WebSocket object, it may be suspended
and resumed in various reason. e.g. alert() will suspend/resume
ActiveDOM objects. In chromium, sending IPC message would also
suspend/resume ActiveDOM objects.
If resume process pending buffer in this case, another event might
be fired while running the initial event handler.
Thus, resume should not process pending buffer immediately.
Pending buffer would be processed after the current task has been
finished.

  • websockets/ThreadableWebSocketChannelClientWrapper.h:
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::resume): Just set one shot timer for resumeTimerFired() if not yet set. (WebCore::WebSocketChannel::resumeTimerFired): Process pending event after resume was called.
  • websockets/WebSocketChannel.h:
21:14 Changeset [61374] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-06-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(HTML5 parser): editing/selection/leave-requested-block.html can fail or crash
https://bugs.webkit.org/show_bug.cgi?id=40764

HTML5ScriptRunner was careful to only call CachedResource::addClient
for cases where the resource was not already loaded. This was to
avoid getting synchronous notifyFinished callbacks from inside
addClient. (The old HTMLDocumentParser also has hacks to work around
addClient's synchronous notifyFinished behavior for already-loaded
resources as well.)

It turns out that CachedResource will mark itself as purgeable if it
has no clients, thus it could have its data cleared (but itself not
deleted) in the case where we yield back to the runloop to wait for
CSS to load before executing the loaded script.

The fix is to act more like the old parser and always call addClient
on every CachedScript we load. But unlike the old parser, we're
careful not to re-enter from addClient -> notifyFinished
using guards in HTML5DocumentParser::watchForLoad.

I do not know how to make a CachedResource purge itself
from a LayoutTest, so this is not currently testable.
If anyone knows how I'm happy to make a test.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::watchForLoad):
    • It is now expected to call watchForLoad with a loaded script.

(WebCore::HTML5DocumentParser::notifyFinished):

  • Now that watchForLoad is called with loaded scripts, notifyFinished may be be called from addClient, thus we may be in the middle of script execution when it's called. It's OK. We pass the call along to HTML5ScriptRunner::executeScriptsWaitingForLoad and it knows how to ignore the call in that case.
  • html/HTML5DocumentParser.h:
    • Document these member variables more.
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::~HTML5ScriptRunner): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::hasScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::watchForLoad):
    • Set the pending script to RegisteringForWatch state before watching and WatchingForLoad after.

(WebCore::HTML5ScriptRunner::stopWatchingForLoad):

  • Set the pending script to NotWatchingForLoad.

(WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad):

  • Assert that callers checked hasScriptsWaitingForLoad()

(WebCore::HTML5ScriptRunner::requestScript):

  • html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::PendingScript::): (WebCore::HTML5ScriptRunner::PendingScript::PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::watchingForLoad):
  • html/HTML5ScriptRunnerHost.h:
    • Document the new expectations of watchForLoad
21:02 Changeset [61373] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Some tests in fast/repaint/ work fine on Mac.
20:40 Changeset [61372] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-06-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Prevent HTML5PreloadScanner from loading resources in <noscript> tags.
https://bugs.webkit.org/show_bug.cgi?id=40779

No new tests. Will create a layout test in a subsequent patch.

  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::adjustedLexerState): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser): (WebCore::HTML5TreeBuilder::isScriptingFlagEnabled):
  • html/HTML5TreeBuilder.h:
19:53 Changeset [61371] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61368.
http://trac.webkit.org/changeset/61368
https://bugs.webkit.org/show_bug.cgi?id=40806

Well, actually, it still fails :( (Requested by abarth on
#webkit).

  • platform/qt/Skipped:
19:48 Changeset [61370] by abarth@webkit.org
  • 7 edits in trunk

2010-06-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5PreloadScanner parses <script> in DataState
https://bugs.webkit.org/show_bug.cgi?id=40804

The ScriptDataState is handled separately from the rest of the lexer
state changes because it's more complicted in the tree builder. The
easiest thing is to just handle it separately in the preloader too.

  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::processToken):

2010-06-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5PreloadScanner parses <script> in DataState
https://bugs.webkit.org/show_bug.cgi?id=40804

Remove the aforementioned hack that was working around this bug. As a
nice side effect, we get test coverage for this bug. :)

  • fast/preloader/image.html:
  • fast/preloader/link.html:
  • fast/preloader/script.html:
  • fast/preloader/style.html:
19:39 Changeset [61369] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test expectation fix.

  • platform/chromium/test_expectations.txt: fast/preloader/*.html

fail because of no dumpResourceResponseMIMETypes(),
stripNullFromTextNodes.html have not failed recently.

19:31 Changeset [61368] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Adam Barth <abarth@webkit.org>

Unreviewed.

I bet this test passes now. :)

  • platform/qt/Skipped:
19:21 Changeset [61367] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-17 Adam Barth <abarth@webkit.org>

Unreviewed.

Skip fast/preloader tests on GTK and Qt because they don't implement
dumpResourceResponseMIMETypes.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
19:01 Changeset [61366] by abarth@webkit.org
  • 10 edits
    16 adds in trunk

2010-06-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add CSS scanning to HTML5PreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=40802

This patch just cribs the CSS preload scanning algorithm from the old
preload scanner. We also invented a way of testing the preload
scanner.

Tests: fast/preloader/image.html

fast/preloader/link.html
fast/preloader/script.html
fast/preloader/style.html

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/CSSPreloadScanner.cpp: Added. (WebCore::isWhitespace): (WebCore::CSSPreloadScanner::CSSPreloadScanner): (WebCore::CSSPreloadScanner::reset): (WebCore::CSSPreloadScanner::scan): (WebCore::CSSPreloadScanner::tokenize): (WebCore::CSSPreloadScanner::emitRule):
  • html/CSSPreloadScanner.h: Added. (WebCore::CSSPreloadScanner::):
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::HTML5PreloadScanner): (WebCore::HTML5PreloadScanner::processToken): (WebCore::HTML5PreloadScanner::scanningBody):
  • html/HTML5PreloadScanner.h:

2010-06-17 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add CSS scanning to HTML5PreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=40802

Add a testing framework for the preload scanner. These test cover
basic preloader behavior. They have a small hack to work around a bug
in the preload scanner discovered while writing the tests. I'll fix
the bug and remove the hack in a followup patch.

  • fast/preloader/image-expected.txt: Added.
  • fast/preloader/image.html: Added.
  • fast/preloader/link-expected.txt: Added.
  • fast/preloader/link.html: Added.
  • fast/preloader/resources/image1.png: Added.
  • fast/preloader/resources/link1.css: Added.
  • fast/preloader/resources/script1.js: Added.
  • fast/preloader/resources/style1.css: Added.
  • fast/preloader/script-expected.txt: Added.
  • fast/preloader/script.html: Added.
  • fast/preloader/style-expected.txt: Added.
  • fast/preloader/style.html: Added.
18:24 Changeset [61365] by dpranke@chromium.org
  • 2 edits in trunk/WebCore

2010-06-17 Abhishek Arya <inferno@chromium.org>

Reviewed by David Kilzer.

(Landed by Dirk Pranke).

Check for a null frame before setting drag selection.
https://bugs.webkit.org/show_bug.cgi?id=38893
Same Layout test as https://bugs.webkit.org/show_bug.cgi?id=37168.

Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

Note that you need to run the test manually 20-30 times for the crash
to reproduce.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
17:53 Changeset [61364] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Get rid of the the unused imageSize of ImageDecoderQt::internalHandleCurrentImage()
https://bugs.webkit.org/show_bug.cgi?id=40620

Remove an unused variable.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::internalHandleCurrentImage):
17:39 Changeset [61363] by eric@webkit.org
  • 4 edits in trunk

2010-06-17 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] cleanup redundant DEPS value and remove buildbot cleanup code
https://bugs.webkit.org/show_bug.cgi?id=40615

  • DEPS: tools/data_pack was listed twice for linux (harmless, but unnecessary)

2010-06-17 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] cleanup redundant DEPS value and remove buildbot cleanup code
https://bugs.webkit.org/show_bug.cgi?id=40615

  • Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
17:29 Changeset [61362] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix a race condition during startup where we would never send the InitializeConnection message to the server.

Reviewed by Sam Weinig.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):

17:24 Changeset [61361] by eric@webkit.org
  • 5 edits
    1 add in trunk

2010-06-17 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Fisher.

[Chromium API] Implement WebSandboxSupport on OS X and add stubs to allow
OOP loading of fonts.

https://bugs.webkit.org/show_bug.cgi?id=40544

  • platform/chromium/ChromiumBridge.h: Add prototype for loadFont()

2010-06-17 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Fisher.

[Chromium API] Implement WebSandboxSupport on OS X and add stubs to allow
OOP loading of fonts.

https://bugs.webkit.org/show_bug.cgi?id=40544

  • WebKit.gyp: Add mac WebSandboxSupport.h
  • public/mac/WebSandboxSupport.h: Added.
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::loadFont):
17:00 Changeset [61360] by eric@webkit.org
  • 18 edits in trunk/WebCore

2010-06-17 Nicolas Weber <thakis@chromium.org>

Reviewed by Eric Seidel.

Fix various warnings that are reported when building with clang
https://bugs.webkit.org/show_bug.cgi?id=40503

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::labelElementContainer):
  • accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::parentTable):
  • bindings/v8/NPV8Object.cpp: (WebCore::npObjectTypeInfo):
  • bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: (WebCore::):
  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp: (WebCore::):
  • bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: (WebCore::):
  • css/CSSStyleSheet.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::getNamedElements):
  • inspector/InspectorValues.cpp: (WebCore::InspectorObject::getObject): (WebCore::InspectorObject::getArray):
  • page/animation/AnimationBase.h:
  • platform/graphics/BitmapImage.h: (WTF::):
  • platform/graphics/mac/FontPlatformData.h:
  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::ellipsisBox):
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::storageArea):
16:39 Changeset [61359] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Kwang Yul Seo <skyul@company100.net>

Reviewed by Pavel Feldman.

Add ENABLE(INSPECTOR) guard for m_sessionSettings
https://bugs.webkit.org/show_bug.cgi?id=40611

Build fix.

  • inspector/InspectorController.h:
16:28 Changeset [61358] by adachan@apple.com
  • 9 edits
    1 copy
    5 deletes in trunk

WebKit2:

Rolling out http://trac.webkit.org/changeset/61297 due to build errors.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Removed.
  • WebProcess/InjectedBundle/InjectedBundlePageClient.cpp: Removed.
  • WebProcess/InjectedBundle/InjectedBundlePageClient.h: Removed.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:

WebKitTools:

Rolling out http://trac.webkit.org/changeset/61297 due to build errors.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
  • MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
16:25 Changeset [61357] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add FIXME to explain HTMLDocumentParser's forceSynchronous bool
https://bugs.webkit.org/show_bug.cgi?id=40609

No functional change, just adding comment.

  • dom/Document.cpp: (WebCore::Document::write):
16:25 Changeset [61356] by dglazkov@chromium.org
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, Chromium expectations update.

  • platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.checksum: Added.
  • platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.png: Added.
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.checksum: Changed
  • platform/chromium-win-xp/fast/text/atsui-spacing-features-expected.png: Removed.
16:04 Changeset [61355] by senorblanco@chromium.org
  • 394 edits
    3 adds
    36 deletes in trunk/LayoutTests

2010-06-17 Stephen White <senorblanco@chromium.org>

Unreviewed; expectations fix.

This updates the pixel test baselines after r61341, and removes them
from test_expectations.

  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize11-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize19-expected.checksum: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Removed.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
  • platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.png: Removed.
  • platform/chromium-linux/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-linux/fast/events/pointer-events-2-expected.png:
  • platform/chromium-linux/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-linux/fast/forms/input-type-change-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.checksum: Removed.
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-win/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-win/fast/events/pointer-events-2-expected.png:
  • platform/chromium-win/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-win/fast/forms/input-type-change-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-win/fast/replaced/image-sizing-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/misc-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.checksum:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
  • platform/mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug1430-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug14929-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug23235-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug4427-expected.png:
  • platform/mac-leopard/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/mac-leopard/tables/mozilla/bugs/bug6404-expected.png:
  • platform/mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/mac-leopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/mac-leopard/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.checksum:
  • platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/mac/fast/backgrounds/size/zero-expected.checksum:
  • platform/mac/fast/backgrounds/size/zero-expected.png:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/mac/fast/canvas/canvas-as-image-expected.checksum:
  • platform/mac/fast/canvas/canvas-as-image-expected.png:
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/mac/fast/forms/input-type-change-expected.checksum:
  • platform/mac/fast/forms/input-type-change-expected.png:
  • platform/mac/fast/replaced/001-expected.checksum:
  • platform/mac/fast/replaced/001-expected.png:
  • platform/mac/fast/replaced/002-expected.checksum:
  • platform/mac/fast/replaced/002-expected.png:
  • platform/mac/fast/replaced/003-expected.checksum:
  • platform/mac/fast/replaced/003-expected.png:
  • platform/mac/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/mac/fast/replaced/image-sizing-expected.checksum:
  • platform/mac/fast/replaced/image-sizing-expected.png:
  • platform/mac/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug11026-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/mac/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4093-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4284-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4523-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4523-expected.png:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/mac/tables/mozilla/bugs/bug86708-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug86708-expected.png:
  • platform/mac/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/mac/tables/mozilla/core/misc-expected.checksum:
  • platform/mac/tables/mozilla/core/misc-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
15:25 Changeset [61354] by dglazkov@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Added pixel results for Chromium.

  • platform/chromium-win/fast/js/missing-title-end-tag-js-expected.checksum: Added.
  • platform/chromium-win/fast/js/missing-title-end-tag-js-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:19 Changeset [61353] by robert@webkit.org
  • 4 edits in trunk

2010-06-13 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebCore EventHandler needs to take account of onLoad events fired
before layout() complete

https://bugs.webkit.org/show_bug.cgi?id=40102

WebCore 'cheats' by firing onLoad events before the frame's layout
has been performed. This can result in event listeners performing
operations that depend on the document's final layout, such as
scrolling operations.

When scrolling a frameview in eventhandler ensure the layout is complete.

  • platform/qt/Skipped: Unskip editing/input/page-up-down-scrolls.html

2010-06-13 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebCore EventHandler needs to take account of onLoad events
fired before layout() complete

https://bugs.webkit.org/show_bug.cgi?id=40102

WebCore 'cheats' by firing onLoad events before the frame's layout
has been performed. This can result in event listeners performing
operations that depend on the document's final layout, such as
scrolling operations.

When scrolling a frameview in eventhandler ensure the layout is complete.

  • page/EventHandler.cpp: (WebCore::EventHandler::scrollRecursively):
15:06 Changeset [61352] by dumi@chromium.org
  • 6 edits
    4 adds in trunk

Add the error codes defined in the async DB spec to SQLError.idl and SQLError.h.
https://bugs.webkit.org/show_bug.cgi?id=40748

Reviewed by Dimitri Glazkov.

WebCore:

Test: storage/sql-error-codes.html

  • storage/SQLError.h:

(WebCore::SQLError::):

  • storage/SQLError.idl:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::execute):
(WebCore::SQLStatement::setDatabaseDeletedError):
(WebCore::SQLStatement::setVersionMismatchedError):
(WebCore::SQLStatement::setFailureDueToQuota):
(WebCore::SQLStatement::lastExecutionFailedDueToQuota):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::postflightAndCommit):

LayoutTests:

  • platform/chromium/storage/sql-error-codes-expected.txt: Added.
  • storage/sql-error-codes-expected.txt: Added.
  • storage/sql-error-codes.html: Added.
  • storage/sql-error-codes.js: Added.

(finishTest):
(transactionErrorCallback):
(transactionSuccessCallback):
(testTransaction):
(testTransactionThrowsException):
(testTransactionFailureBecauseOfStatementFailure):
(testInvalidStatement):
(testIncorrectNumberOfBindParameters):
(testBindParameterOfWrongType.badString.toString):
(testBindParameterOfWrongType):
(testQuotaExceeded):
(testVersionMismatch.db.transaction):
(testVersionMismatch):
(runTest):

14:41 Changeset [61351] by robert@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-06-17 Robert Hogan <robert@webkit.org>

[Qt] Build fix

Unreviewed.

Remove includes in qdeclarativewebview*.* that rely on an installation
of QtWebKit.

  • declarative/qdeclarativewebview.cpp:
  • declarative/qdeclarativewebview_p.h:
14:32 Changeset [61350] by dglazkov@chromium.org
  • 125 edits
    48 adds
    1 delete in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Updating Chromium expectations after http://trac.webkit.org/changeset/61128.

14:15 Changeset [61349] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-06-17 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Fix CRLF ending conversion in StringBlobItem.
https://bugs.webkit.org/show_bug.cgi?id=40736
Also: fix referencing uninitialized member bug and slice length bug
in hybrid blob case.

Tests will be added when we add BlobBuilder jsc bindings.

  • platform/BlobItem.cpp: (WebCore::StringBlobItem::convertToCString): (WebCore::DataRangeBlobItem::DataRangeBlobItem):
13:59 Changeset [61348] by robert@webkit.org
  • 4 edits in trunk

2010-06-17 Robert Hogan <robert@webkit.org>

Unreviewed, rolling out r61346.
http://trac.webkit.org/changeset/61346
https://bugs.webkit.org/show_bug.cgi?id=33333

Broke inspector tests on Qt

  • platform/qt/Skipped:

2010-06-17 Robert Hogan <robert@webkit.org>

Unreviewed, rolling out r61346.
http://trac.webkit.org/changeset/61346
https://bugs.webkit.org/show_bug.cgi?id=33333

Broke inspector tests on Qt

  • Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):
13:44 Changeset [61347] by dglazkov@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Removed obsolete Win XP expectations.

  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Removed.
13:39 Changeset [61346] by robert@webkit.org
  • 4 edits in trunk

2010-06-17 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • platform/qt/Skipped:

2010-06-17 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):
13:28 Changeset [61345] by dglazkov@chromium.org
  • 5 edits
    2 deletes in trunk

2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r61340.
http://trac.webkit.org/changeset/61340
https://bugs.webkit.org/show_bug.cgi?id=36282

Broke several editing tests.

  • fast/css/duplicate-property-in-rule-expected.txt: Removed.
  • fast/css/duplicate-property-in-rule.html: Removed.

2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r61340.
http://trac.webkit.org/changeset/61340
https://bugs.webkit.org/show_bug.cgi?id=36282

Broke several editing tests.

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
13:25 Changeset [61344] by dglazkov@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

More clean up from the HTML5 parser spin-up.

  • platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium/test_expectations.txt:
13:14 Changeset [61343] by jianli@chromium.org
  • 7 edits in trunk

Add optional contentType parameter to Blob.slice per latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=40647

Reviewed by David Levin.

WebCore:

Tested by http/tests/local/resources/send-sliced-dragged-file.html.

  • html/Blob.cpp:

(WebCore::Blob::slice):

  • html/Blob.h:
  • html/Blob.idl:

LayoutTests:

Updated the test for the optional parameter.

  • http/tests/local/resources/send-sliced-dragged-file.js:
  • http/tests/local/send-sliced-dragged-file-expected.txt:
13:02 Changeset [61342] by jesus@webkit.org
  • 12 edits in trunk

Add viewport meta tag support to QtWebKit API layer

[Qt] QtWebKit does not support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=39902

Patch by Jesus Sanchez-Palencia <jesus@webkit.org>, Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-06-01
Reviewed by Simon Hausmann.

WebCore:

Add windowRect() to page client.

  • platform/qt/QWebPageClient.h:

WebKit/qt:

This implements didReceiveViewportArguments in our ChromeClientQt
which is hooked up with QWebPage::viewportChangeRequested().
This signal does not affect the current default behavior.
The documentation of the signal explains how to make use of this new feature.

  • Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):
Store information about whether the page has been laid out or not.

  • Api/qwebpage.cpp:

(QWebPage::viewportChangeRequested):

  • Api/qwebpage_p.h:

Added class QtViewportHintsPrivate.

  • Api/qwebpage.h:

(QWebPage::setPreferredContentsSize):
Improved documentation and now only layout if the page had already
passed layout phase.
Added class QWebPage::ViewportHints.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowRect):
Modified to work as intended by the DOM, for both QWebView
and QGraphicsWebView.
(WebCore::ChromeClientQt::didReceiveViewportArguments):
Emits the signal QWebPage::viewportChangeRequested.

  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):
Update information about whether the page has been laid out or not.
If the page has been laid out we ignore any further viewport meta data.

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::windowRect):
(WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):

  • WebCoreSupport/PageClientQt.h:

The PageClient is now responsible for providing the right window rect.

12:50 Changeset [61341] by senorblanco@chromium.org
  • 6 edits in trunk

2010-06-17 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Fix for slow multiple animated resize issue.
https://bugs.webkit.org/show_bug.cgi?id=38233

The timer-based resize quality approach implemented in
http://trac.webkit.org/changeset/34210 is a good idea, but doesn't
scale to multiple images with animated resizes. This fix unifies all
outstanding resize timers into a single timer, and removes the "use
last quality" check (which doesn't work when images are overlapping).
It also refactors the copy of this code implemented in
RenderBoxModelObject in http://trac.webkit.org/changeset/53949.

This improves Safari performance for the following IE9 platform demos on my C2D MacPro (10.5):
http://ie.microsoft.com/testdrive/Performance/01FlyingImages/Default.html (4->60fps)
http://ie.microsoft.com/testdrive/Performance/10FlickrExplorer/Default.html (3->16fps)
http://ie.microsoft.com/testdrive/Performance/11BrowserFlip/Default.html (9->60fps)

  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::ImageQualityController): Unify all timers into a single timer, rename RenderBoxModelScaleObserver to ImageQualityController, and remove the resize quality "stickness", since it doesn't work with multiple outstanding resizes. (WebCore::ImageQualityController::objectDestroyed): gImages global is now m_lastPaintTimeMap member. (WebCore::ImageQualityController::highQualityRepaintTimerFired): Function made non-static; repaint all pending resizes (not just one). (WebCore::ImageQualityController::restartTimer): Added function to restart timer at 1.05x threshold. (WebCore::imageQualityController): Static function to return singleton. (WebCore::ImageQualityController::shouldPaintAtLowQuality): Use m_lastPaintTimeMap, not gImages global. Implement new timer algorithm. Remove resize "stickiness". (WebCore::RenderBoxModelObject::shouldPaintAtLowQuality): Implement shouldPaintAtLowQuality, which pulls out "this" and passes the call to the ImageQualityController. (WebCore::RenderBoxModelObject::~RenderBoxModelObject): Call ImageQualityController singleton's objectDestroyed() instead of old static function. (WebCore::RenderBoxModelObject::paintFillLayerExtended): Modify shouldPaintAtLowQuality() call to match new class name and function signature.
  • rendering/RenderBoxModelObject.h: Expose shouldPaintAtLowQuality as a member function.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::~RenderImage): No need to call objectDestroyed() here anymore, since the RenderBoxModelObject destructor will do this for us. (WebCore::RenderImage::paintIntoRect): Rip out RenderImageScaleObserver, and call RenderBoxModelObject::shouldPaintAtLowQuality() instead.

2010-06-17 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Temporarily modify test_expectations.txt to add tests broken by
https://bugs.webkit.org/show_bug.cgi?id=38233

  • platform/chromium/test_expectations.txt:
12:32 Changeset [61340] by rwlbuis@webkit.org
  • 5 edits
    2 adds in trunk

2010-06-17 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dave Hyatt.

CSS3 "Property is declared twice in rule" test fails
https://bugs.webkit.org/show_bug.cgi?id=36282

Filter out duplicate properties in style declaration.

Test: fast/css/duplicate-property-in-rule.html

  • css/CSSMutableStyleDeclaration.cpp: Filter out duplicate properties (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Discard negative padding values
  • css/CSSStyleSelector.cpp: Remove negative padding check (WebCore::CSSStyleSelector::applyProperty):
11:14 Changeset [61339] by kbr@google.com
  • 16 edits in trunk

2010-06-17 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Clean up error conditions for Typed Arrays
https://bugs.webkit.org/show_bug.cgi?id=40755

  • bindings/js/JSArrayBufferCustom.cpp: (WebCore::JSArrayBufferConstructor::constructJSArrayBuffer):
    • Fixed handling of NaN/+inf/-inf lengths. Throw RangeError for too-large or negative lengths.
  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferView):
    • Changed all error code paths to throw exceptions. Clarified exception types.
  • bindings/js/JSFloat32ArrayCustom.cpp: (WebCore::JSFloat32ArrayConstructor::constructJSFloat32Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSInt16ArrayCustom.cpp: (WebCore::JSInt16ArrayConstructor::constructJSInt16Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSInt32ArrayCustom.cpp: (WebCore::JSInt32ArrayConstructor::constructJSInt32Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSInt8ArrayCustom.cpp: (WebCore::JSInt8ArrayConstructor::constructJSInt8Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSUint16ArrayCustom.cpp: (WebCore::JSUint16ArrayConstructor::constructJSUint16Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSUint32ArrayCustom.cpp: (WebCore::JSUint32ArrayConstructor::constructJSUint32Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/js/JSUint8ArrayCustom.cpp: (WebCore::JSUint8ArrayConstructor::constructJSUint8Array):
    • Removed throwing of INDEX_SIZE_ERROR, delegating responsibility to constructArrayBufferView.
  • bindings/v8/custom/V8ArrayBufferCustom.cpp: (WebCore::V8ArrayBuffer::constructorCallback):
    • Fixed handling of NaN/+inf/-inf lengths. Throw RangeError for too-large or negative lengths. Clarified exception types.
  • bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray):
    • Clarified exception types and throwing of exceptions along all error code paths.
  • html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::create):
    • Added necessary null checks during allocation.

2010-06-17 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Clean up error conditions for Typed Arrays
https://bugs.webkit.org/show_bug.cgi?id=40755

  • fast/canvas/webgl/array-unit-tests-expected.txt:
    • Updated test expectations.
  • fast/canvas/webgl/array-unit-tests.html:
    • Added tests for overloaded ArrayBufferView constructors taking null, and improperly aligned offsets. Improved precision of tests causing INDEX_SIZE_ERR to be thrown.
10:46 Changeset [61338] by chang.shu@nokia.com
  • 6 edits
    1 add in trunk

2010-06-17 Shu Chang <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the link error on symbian with ENABLE_JIT=0.

  1. Add "#if ENABLE(JIT)" in the header file;
  2. Put feature enable/disable logic to a common.pri so that both JavaScriptCore.pri and WebCore.pri can share.

https://bugs.webkit.org/show_bug.cgi?id=40780

2010-06-17 Shu Chang <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the link error on symbian with ENABLE_JIT=0.

  1. Add "#if ENABLE(JIT)" in the header file;
  2. Put feature enable/disable logic to a common.pri so that both JavaScriptCore.pri and WebCore.pri can share.

https://bugs.webkit.org/show_bug.cgi?id=40780

  • common.pri: Added.

2010-06-17 Shu Chang <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the link error on symbian with ENABLE_JIT=0.

  1. Add "#if ENABLE(JIT)" in the header file;
  2. Put feature enable/disable logic to a common.pri so that both JavaScriptCore.pri and WebCore.pri can share.

https://bugs.webkit.org/show_bug.cgi?id=40780

  • WebCore.pri:
10:39 Changeset [61337] by kbr@google.com
  • 7 edits
    1 delete in trunk

2010-06-17 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
https://bugs.webkit.org/show_bug.cgi?id=40750

Added V8Proxy::throwTypeError() and throwSyntaxError for parity
with JSC::throwTypeError() and throwSyntaxError. Changed
CodeGeneratorV8.pm to use throwTypeError for overload resolution
failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
instead of manual call to JSValue::encode. Deleted now-unnecessary
Chromium expectations for fast/canvas/webgl/texImageTest.html.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::throwTypeError): (WebCore::V8Proxy::throwSyntaxError):
  • bindings/v8/V8Proxy.h:

2010-06-17 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
https://bugs.webkit.org/show_bug.cgi?id=40750

Added V8Proxy::throwTypeError() and throwSyntaxError for parity
with JSC::throwTypeError() and throwSyntaxError. Changed
CodeGeneratorV8.pm to use throwTypeError for overload resolution
failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
instead of manual call to JSValue::encode. Deleted now-unnecessary
Chromium expectations for fast/canvas/webgl/texImageTest.html.

  • platform/chromium-mac/fast/canvas/webgl/texImageTest-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
10:24 Changeset [61336] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

tables/mozilla/images/adforce_imgis_com.html was removed after r61289. Remove
it from the GTK+ skipped list.

  • platform/gtk/Skipped: Remove a defunct test.
10:23 Changeset [61335] by darin@chromium.org
  • 2 edits in trunk/WebCore

2010-06-17 Darin Fisher <darin@chromium.org>

Reviewed by Brady Eidson.

If Page::goToItem is passed a HistoryItem that is the current item,
then the page should be loaded again.

https://bugs.webkit.org/show_bug.cgi?id=40660

  • loader/HistoryController.cpp: (WebCore::HistoryController::recursiveGoToItem): Add a check to recursiveGoToItem that matches the one in FrameLoader::loadItem.
10:06 Changeset [61334] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Build fix for DragDataBrew
https://bugs.webkit.org/show_bug.cgi?id=40610

http://trac.webkit.org/changeset/60957 was not applied to DragDataBrew.cpp.
Add FilenameConversionPolicy argument to DragData::containsURL and DragData::asURL.

  • platform/brew/DragDataBrew.cpp: (WebCore::DragData::containsURL): (WebCore::DragData::asURL):
09:53 Changeset [61333] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-06-17 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

Rename internalformat to internalFormat
https://bugs.webkit.org/show_bug.cgi?id=40149

  • html/canvas/WebGLFramebuffer.cpp: Rename internalformat to internalFormat. (WebCore::WebGLFramebuffer::getColorBufferFormat):
  • html/canvas/WebGLRenderbuffer.cpp: Ditto. (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
  • html/canvas/WebGLRenderbuffer.h: Ditto. (WebCore::WebGLRenderbuffer::setInternalFormat): (WebCore::WebGLRenderbuffer::getInternalFormat):
  • html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::copyTexImage2D): (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::getRenderbufferParameter): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::texImage2DBase): (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
  • html/canvas/WebGLRenderingContext.h: Ditto.
  • html/canvas/WebGLTexture.cpp: Ditto. (WebCore::WebGLTexture::WebGLTexture):
  • html/canvas/WebGLTexture.h: Ditto. (WebCore::WebGLTexture::setInternalFormat): (WebCore::WebGLTexture::getInternalFormat):
09:39 Changeset [61332] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-17 Zhenyao Mo <zmo@google.com>

Reviewed by David Levin.

Remove input parameter validation for "level" upper limit in *tex* functions
https://bugs.webkit.org/show_bug.cgi?id=40603

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateTexFuncParameters): Don't check for "level" upper limit.
09:26 Changeset [61331] by eric@webkit.org
  • 21 edits
    2 deletes in trunk

2010-06-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

Clean EFL header files in order to diminish the compilation time with
EFL from subversion. We remove the EFL includes from header files and use
forward declarations, including the headers in correspondent source
files when needed. This causes only the needed source files to be
recompiled in case a new version of EFL is installed instead of
triggering a recompilation of almost all WebCore/WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40575

No new functionalities, so no new tests.

  • CMakeListsEfl.txt:
  • platform/PlatformKeyboardEvent.h: forward declaration.
  • platform/PlatformMouseEvent.h: forward declaration and change method signature to not require enum.
  • platform/PlatformWheelEvent.h: forward declaration.
  • platform/Widget.h: forward declaration.
  • platform/efl/PlatformKeyboardEventEfl.cpp: include needed header.
  • platform/efl/PlatformMouseEventEfl.cpp: (WebCore::PlatformMouseEvent::setClickCount): change method signature as mentioned above.
  • platform/efl/PlatformWheelEventEfl.cpp: include needed header.
  • platform/efl/RenderThemeEfl.cpp: include needed header
  • platform/efl/RenderThemeEfl.h: forward declaration.
  • platform/efl/ScrollbarEfl.cpp: include needed header.
  • platform/efl/ScrollbarEfl.h: forward declaration.
  • platform/efl/WidgetEfl.cpp: include needed header.
  • platform/graphics/FloatRect.h: remove unused method.
  • platform/graphics/Icon.h: forward declaration.
  • platform/graphics/IntRect.h: remove unused method.
  • platform/graphics/efl/FloatRectEfl.cpp: Removed. This file was implementing an unused method.
  • platform/graphics/efl/IntRectEfl.cpp: Removed. This file was implementing an unused method.

2010-06-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

Clean EFL header files in order to diminish the compilation time with
EFL from subversion. We remove the EFL includes from header files and use
forward declarations, including the headers in correspondent source
files when needed. This causes only the needed source files to be
recompiled in case a new version of EFL is installed instead of
triggering a recompilation of almost all WebCore/WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40575

  • efl/WebCoreSupport/ChromeClientEfl.cpp: include needed header.
  • efl/WebCoreSupport/ChromeClientEfl.h: forward declaration.
  • efl/WebCoreSupport/EditorClientEfl.h: forward declaration.
09:25 Changeset [61330] by dglazkov@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, test expectations update.

  • platform/chromium-mac/fast/dom/wrapper-classes-expected.txt:
  • platform/chromium-win/fast/dom/wrapper-classes-expected.txt: Updated results after r61322.
08:51 Changeset [61329] by darin@apple.com
  • 2 edits in trunk/WebKitTools

One more try at fix for Chromium build.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell): Use set again instead of =.

08:45 Changeset [61328] by darin@apple.com
  • 3 edits in trunk/WebKitTools

Fix Chromium build.

I didn't realize that neither Chromium nor Qt share the DumpRenderTree

code with all the other platforms! Wow, that should be fixed at some point.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell): Changed back to using "new".

  • DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
08:16 Changeset [61327] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed Qt build fix.

LayoutTestController in the Qt DRT is not using refs :)

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):

08:11 Changeset [61326] by darin@apple.com
  • 3 edits in trunk/WebCore

2010-06-17 Alex Milowski <alex@milowski.com>

Reviewed by Darin Adler.

Fixed a compile error in the paint() methods by making them use the
new visitedDependentColor() method.
https://bugs.webkit.org/show_bug.cgi?id=40327

  • mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint): (WebCore::RenderMathMLRoot::layout): Fixed a crash where every child was assumed to be a RenderMathMLBlock instance when that isn't the case. Also, layout() needed to mark the index for layout before calling layout() on the index.
  • mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
08:06 QtWebKitTiling edited by kenneth@webkit.org
(diff)
08:03 Changeset [61325] by hausmann@webkit.org
  • 4 edits
    6 adds in trunk

[Qt] Upstream the WebKit QML integration plugin
https://bugs.webkit.org/show_bug.cgi?id=40050

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-17
Reviewed by Kenneth Rohde Christiansen.

.:

Add to the build the QML WebKit integration plugin.

  • WebKit.pro:

WebKit/qt:

Add to the Qt port the QML WebKit integration plugin.
QDeclarativeWebView is creating the item and expose
properties. The C++ API is not public, only the
properties are.

  • declarative/declarative.pro: Added.
  • declarative/plugin.cpp: Added.

(WebKitQmlPlugin::registerTypes):

  • declarative/qdeclarativewebview.cpp: Added.

(QDeclarativeWebViewPrivate::QDeclarativeWebViewPrivate):
(QDeclarativeWebViewPrivate::):
(QDeclarativeWebViewPrivate::windowObjectsAppend):
(GraphicsWebView::GraphicsWebView):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::mouseReleaseEvent):
(GraphicsWebView::mouseDoubleClickEvent):
(GraphicsWebView::timerEvent):
(GraphicsWebView::mouseMoveEvent):
(QDeclarativeWebView::QDeclarativeWebView):
(QDeclarativeWebView::~QDeclarativeWebView):
(QDeclarativeWebView::init):
(QDeclarativeWebView::componentComplete):
(QDeclarativeWebView::status):
(QDeclarativeWebView::progress):
(QDeclarativeWebView::doLoadStarted):
(QDeclarativeWebView::doLoadProgress):
(QDeclarativeWebView::pageUrlChanged):
(QDeclarativeWebView::doLoadFinished):
(QDeclarativeWebView::url):
(QDeclarativeWebView::setUrl):
(QDeclarativeWebView::preferredWidth):
(QDeclarativeWebView::setPreferredWidth):
(QDeclarativeWebView::preferredHeight):
(QDeclarativeWebView::setPreferredHeight):
(QDeclarativeWebView::evaluateJavaScript):
(QDeclarativeWebView::updateDeclarativeWebViewSize):
(QDeclarativeWebView::initialLayout):
(QDeclarativeWebView::updateContentsSize):
(QDeclarativeWebView::geometryChanged):
(QDeclarativeWebView::javaScriptWindowObjects):
(QDeclarativeWebView::qmlAttachedProperties):
(QDeclarativeWebViewPrivate::updateWindowObjects):
(QDeclarativeWebView::renderingEnabled):
(QDeclarativeWebView::setRenderingEnabled):
(QDeclarativeWebView::heuristicZoom):
(QDeclarativeWebView::pressGrabTime):
(QDeclarativeWebView::setPressGrabTime):
(QDeclarativeWebView::backAction):
(QDeclarativeWebView::forwardAction):
(QDeclarativeWebView::reloadAction):
(QDeclarativeWebView::stopAction):
(QDeclarativeWebView::title):
(QDeclarativeWebView::icon):
(QDeclarativeWebView::setStatusText):
(QDeclarativeWebView::windowObjectCleared):
(QDeclarativeWebView::statusText):
(QDeclarativeWebView::page):
(QDeclarativeWebView::settingsObject):
(QDeclarativeWebView::setPage):
(QDeclarativeWebView::load):
(QDeclarativeWebView::html):
(QDeclarativeWebView::setHtml):
(QDeclarativeWebView::setContent):
(QDeclarativeWebView::history):
(QDeclarativeWebView::settings):
(QDeclarativeWebView::createWindow):
(QDeclarativeWebView::newWindowComponent):
(QDeclarativeWebView::setNewWindowComponent):
(QDeclarativeWebView::newWindowParent):
(QDeclarativeWebView::setNewWindowParent):
(QDeclarativeWebView::contentsSize):
(QDeclarativeWebView::contentsScale):
(QDeclarativeWebView::setContentsScale):
(QDeclarativeWebView::elementAreaAt):
(QDeclarativeWebPage::QDeclarativeWebPage):
(QDeclarativeWebPage::~QDeclarativeWebPage):
(QDeclarativeWebPage::chooseFile):
(QDeclarativeWebPage::javaScriptAlert):
(QDeclarativeWebPage::javaScriptConfirm):
(QDeclarativeWebPage::javaScriptPrompt):
(QDeclarativeWebPage::viewItem):
(QDeclarativeWebPage::createWindow):

  • declarative/qdeclarativewebview_p.h: Added.

(QDeclarativeWebView::):
(QDeclarativeWebView::isComponentCompletePublic):
(QDeclarativeWebViewAttached::QDeclarativeWebViewAttached):
(QDeclarativeWebViewAttached::windowObjectName):
(QDeclarativeWebViewAttached::setWindowObjectName):
(QDeclarativeWebSettings::QDeclarativeWebSettings):
(QDeclarativeWebSettings::standardFontFamily):
(QDeclarativeWebSettings::setStandardFontFamily):
(QDeclarativeWebSettings::fixedFontFamily):
(QDeclarativeWebSettings::setFixedFontFamily):
(QDeclarativeWebSettings::serifFontFamily):
(QDeclarativeWebSettings::setSerifFontFamily):
(QDeclarativeWebSettings::sansSerifFontFamily):
(QDeclarativeWebSettings::setSansSerifFontFamily):
(QDeclarativeWebSettings::cursiveFontFamily):
(QDeclarativeWebSettings::setCursiveFontFamily):
(QDeclarativeWebSettings::fantasyFontFamily):
(QDeclarativeWebSettings::setFantasyFontFamily):
(QDeclarativeWebSettings::minimumFontSize):
(QDeclarativeWebSettings::setMinimumFontSize):
(QDeclarativeWebSettings::minimumLogicalFontSize):
(QDeclarativeWebSettings::setMinimumLogicalFontSize):
(QDeclarativeWebSettings::defaultFontSize):
(QDeclarativeWebSettings::setDefaultFontSize):
(QDeclarativeWebSettings::defaultFixedFontSize):
(QDeclarativeWebSettings::setDefaultFixedFontSize):
(QDeclarativeWebSettings::autoLoadImages):
(QDeclarativeWebSettings::setAutoLoadImages):
(QDeclarativeWebSettings::javascriptEnabled):
(QDeclarativeWebSettings::setJavascriptEnabled):
(QDeclarativeWebSettings::javaEnabled):
(QDeclarativeWebSettings::setJavaEnabled):
(QDeclarativeWebSettings::pluginsEnabled):
(QDeclarativeWebSettings::setPluginsEnabled):
(QDeclarativeWebSettings::privateBrowsingEnabled):
(QDeclarativeWebSettings::setPrivateBrowsingEnabled):
(QDeclarativeWebSettings::javascriptCanOpenWindows):
(QDeclarativeWebSettings::setJavascriptCanOpenWindows):
(QDeclarativeWebSettings::javascriptCanAccessClipboard):
(QDeclarativeWebSettings::setJavascriptCanAccessClipboard):
(QDeclarativeWebSettings::developerExtrasEnabled):
(QDeclarativeWebSettings::setDeveloperExtrasEnabled):
(QDeclarativeWebSettings::linksIncludedInFocusChain):
(QDeclarativeWebSettings::setLinksIncludedInFocusChain):
(QDeclarativeWebSettings::zoomTextOnly):
(QDeclarativeWebSettings::setZoomTextOnly):
(QDeclarativeWebSettings::printElementBackgrounds):
(QDeclarativeWebSettings::setPrintElementBackgrounds):
(QDeclarativeWebSettings::offlineStorageDatabaseEnabled):
(QDeclarativeWebSettings::setOfflineStorageDatabaseEnabled):
(QDeclarativeWebSettings::offlineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::setOfflineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::localStorageDatabaseEnabled):
(QDeclarativeWebSettings::setLocalStorageDatabaseEnabled):
(QDeclarativeWebSettings::localContentCanAccessRemoteUrls):
(QDeclarativeWebSettings::setLocalContentCanAccessRemoteUrls):

  • declarative/qmldir: Added.
  • docs/qtwebkit.qdocconf:
08:03 QtWebKitTiling edited by kenneth@webkit.org
(diff)
08:00 QtWebKitTiling created by kenneth@webkit.org
07:58 Changeset [61324] by darin@apple.com
  • 36 edits in trunk

2010-06-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
https://bugs.webkit.org/show_bug.cgi?id=40760

  • API/JSClassRef.h: Removed unneeded include of RefCounted.h.
  • API/JSWeakObjectMapRefPrivate.cpp: Ditto.
  • bytecode/CodeBlock.h: (JSC::FunctionCodeBlock::FunctionCodeBlock): Use the SharedSymbolTable::create function instead of calling new directly.
  • runtime/SymbolTable.h: Added a create function to the SharedSymbolTable class and made the constructor private.

2010-06-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
https://bugs.webkit.org/show_bug.cgi?id=40760

  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Made create no longer be an inline function.
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Moved the call to addPluginInstance out of here. (WebKit::NetscapePluginInstanceProxy::create): Move it in here. This makes sure we call adoptRef on the new proxy before any caller calls ref on it.

2010-06-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
https://bugs.webkit.org/show_bug.cgi?id=40760

This helps prepare for an assertion that fires if you ref or destroy an
object before calling adoptRef on it. That will help us catch mistakes
that can lead to storage leaks.

  • WebCore.base.exp: Updated export now that Frame::create is not an inline function.
  • css/CSSInitialValue.h: (WebCore::CSSInitialValue::createExplicit): Use create. (WebCore::CSSInitialValue::createImplicit): Ditto. (WebCore::CSSInitialValue::create): Added.
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::createUncachedIdentifier): Added. (WebCore::CSSPrimitiveValue::createUncachedColor): Added. (WebCore::CSSPrimitiveValue::createUncached): Added. (WebCore::CSSPrimitiveValue::createIdentifier): Use createUncachedIdentifier instead of using new directly. (WebCore::CSSPrimitiveValue::createColor): Use createUncachedColor instead of using new directly. (WebCore::CSSPrimitiveValue::create): Use createdUncached instead of using new directly.
  • css/CSSPrimitiveValue.h: Declare the new functions above.
  • css/CSSStyleSelector.cpp: (WebCore::loadFullDefaultStyle): Deref simpleDefaultStyleSheet instead of explicitly deleting it.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): Move the call to addSubresourceLoader out of here. (WebCore::SubresourceLoader::create): Move it in here. This makes it so we don't ref the loader before finishing its creation and calling adoptRef.
  • page/Frame.cpp: (WebCore::Frame::Frame): Move the call to setMainFrame out of here. Also refactor the code so an assertion is easier to read. (WebCore::Frame::create): Move the call to setMainFrame in here. This makes it so we don't ref the frame before finishing its creation and calling adoptRef.
  • page/Frame.h: Made the create function non-inline.
  • platform/text/BidiContext.cpp: (WebCore::BidiContext::createUncached): Added. (WebCore::BidiContext::create): Call createUncached instead of callling new directly.
  • platform/text/BidiContext.h: Declare createUncached.
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::buildPrimitives): Use PassRefPtr and RefPtr instead of OwnPtr. And use the create function instead of new.
  • rendering/RenderSVGResourceFilter.h: Ditto.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer): Ditto.
  • storage/StorageAreaImpl.cpp: (WebCore::StorageAreaImpl::StorageAreaImpl): Move the code that calls StorageAreaSync::create out of here. (WebCore::StorageAreaImpl::create): Move it in here. This makes it so we don't ref the storage area before finishing its creation and calling adoptRef.
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::defaultFill): Use create instead of new. (WebCore::SVGPaint::defaultStroke): Ditto.
  • svg/graphics/filters/SVGFilterBuilder.h: Made the constructor private and added a create function since this is a reference counted object and should not be constructed directly.

2010-06-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Use adoptRef and create functions in more code paths
https://bugs.webkit.org/show_bug.cgi?id=40760

  • DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::create): Added.
  • DumpRenderTree/LayoutTestController.h: Declare the create function.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Use create instead of new.
  • DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new.
  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use RefPtr and create instead of OwnPtr and new.
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef instead of new.
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new.
  • DumpRenderTree/wx/DumpRenderTreeWx.cpp: (runTest): Use RefPtr and create instead of OwnPtr and new. (MyApp::OnInit): Removed unneeded code to delete the layout test controller. This is done during each test.
07:47 Changeset [61323] by abecsi@webkit.org
  • 4 edits in trunk

Update CMake build system to use new script for generating source files
with gperf (r61091).
https://bugs.webkit.org/show_bug.cgi?id=40628

Patch by Lucas De Marchi <lucas.demarchi@profusion.mobi> on 2010-06-17
Reviewed by Gustavo Noronha.

  • cmake/WebKitGenerators.cmake:

WebCore: Update CMake build system to use new script for generating source files
with gperf (r61091).
This updates also the build system to cope with recent changes to
source files list.
https://bugs.webkit.org/show_bug.cgi?id=40628

Patch by Lucas De Marchi <lucas.demarchi@profusion.mobi> on 2010-06-17
Reviewed by Gustavo Noronha.

No new tests since it's just compilation fixes.

  • CMakeLists.txt:
07:24 Changeset [61322] by darin@apple.com
  • 9 edits
    3 adds in trunk

2010-06-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Fix boolean reflected attributes to use empty string consistently for the content attribute value
https://bugs.webkit.org/show_bug.cgi?id=40758

Test: fast/dom/boolean-attribute-reflection.html

The HTML5 specification and other browsers are all consistent:
When setting a boolean IDL attribute to true, the attribute value
gets set to the empty string. The guidelines for authors allow either
the empty string or the name of the attribute, but for implementers
of the DOM, the reflected attribute gets empty string.

  • dom/Element.cpp: (WebCore::Element::setBooleanAttribute): Use emptyAtom to set the attribute to the empty string.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::setAutofocus): Use the empty string, not "autofocus". (WebCore::HTMLFormControlElement::setRequired): Use the empty string, not "required".

2010-06-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Fix boolean reflected attributes to use empty string consistently for the content attribute value
https://bugs.webkit.org/show_bug.cgi?id=40758

  • fast/dom/boolean-attribute-reflection-expected.txt: Added.
  • fast/dom/boolean-attribute-reflection.html: Added.
  • fast/dom/script-tests/boolean-attribute-reflection.js: Added.
  • fast/dom/wrapper-classes-expected.txt: Regenerated.
  • fast/dom/wrapper-classes.html: Added some classes.
  • media/video-controls-expected.txt: Regenerated.
  • media/video-controls.html: Changed to expect the new correct results. Removed unnecessary use of offsetTop to force layout. This test covers only the DOM and has nothing to do with layout.
  • svg/dom/svgpath-getPathSegAtLength.html: Let the make-script-test-wrappers script regenerate this file.
06:19 Changeset [61321] by pfeldman@chromium.org
  • 4 edits in trunk

2010-06-17 Pavel Feldman <pfeldman@chromium.org>

Unreviewed: chromium tests fix. Added InspectorBackend delegates for new inspector methods.

  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.clearConsoleMessages): (.WebInspector.InspectorBackendStub.prototype.getOuterHTML): (.WebInspector.InspectorBackendStub.prototype.setOuterHTML): (.WebInspector.InspectorBackendStub.prototype.addInspectedNode):

2010-06-17 Pavel Feldman <pfeldman@chromium.org>

Unreviewed: chromium tests fix. Added InspectorBackend delegates for new inspector methods.

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
05:19 Changeset [61320] by mnaganov@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-06-17 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Prepare to making WebDevToolsAgentClient::sendMessageToFrontendOnIOThread virtual

https://bugs.webkit.org/show_bug.cgi?id=39302

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsMessageTransport::~WebDevToolsMessageTransport):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread):
03:23 Changeset [61319] by hausmann@webkit.org
  • 8 edits in trunk

[Qt] use "win32-g++*" scope to match all MinGW makespecs

Patch by Mark Brand <mabrand@mabrand.nl> on 2010-06-17
Reviewed by Simon Hausmann.

The scope "win32-g++" comes from the name of the makespec. However, it
is frequently used to check for MinGW. This works fine as long as
win32-g++ is the only makespec for MinGW. Now we need the wildcard
to cover "win32-g++-cross" as well.

.:

  • WebKit.pri:

JavaScriptCore:

WebCore:

  • WebCore.pro:

WebKit/qt:

  • Api/DerivedSources.pro:
03:20 Changeset [61318] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-17 Pavel Feldman <pfeldman@chromium.org>

Unreviewed, tests fix.

  • inspector/elements-panel-search.html:
02:43 Changeset [61317] by pfeldman@chromium.org
  • 17 edits in trunk/WebCore

2010-06-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joe Pecoraro.

Web Inspector: move get/setOuterHTML, addInspectedNode and
clearConsole to native InspectorDOMAgent. This is done to allow
inspected nodes array to store nodes from different domains,
also moves outerhtml manipulation closer to the rest of the DOM
operations. In addition to that, we are slowly getting rid of
InjectedScriptAccess in favor of IDL-defined InspectorBackend
interface for clearer remote debugging API.

https://bugs.webkit.org/show_bug.cgi?id=40733

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectedNode):
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::changeTagName): (WebCore::InspectorBackend::getOuterHTML): (WebCore::InspectorBackend::setOuterHTML): (WebCore::InspectorBackend::addInspectedNode): (WebCore::InspectorBackend::clearConsoleMessages):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::inspectedNode): (WebCore::InspectorDOMAgent::changeTagName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::addInspectedNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didGetOuterHTML): (WebCore::InspectorFrontend::didSetOuterHTML):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages):
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted): ():
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/InjectedScriptAccess.js:
02:29 Changeset [61316] by eric@webkit.org
  • 6 edits in trunk

2010-06-17 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

Move the call to the notification presenter that a Notification is being
destroyed from the destructor (not safe) to the ActiveDOMObject::contextDestroyed
method.

Also fix up an incorrect reference loss in the V8 bindings code for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=40097

No new tests; code paths are well-covered by existing tests.

  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::createHTMLNotificationCallback): (WebCore::V8NotificationCenter::createNotificationCallback):
  • notifications/Notification.cpp: (WebCore::Notification::~Notification): (WebCore::Notification::contextDestroyed):
  • notifications/Notification.h:

2010-06-17 John Gregg <johnnyg@google.com>

Reviewed by David Levin.

Undo the build fix with the correct patch: Chromium NotificationPresenter
is now informed of the destruction before it actually happens, so this
use of the Notification object is correct.
https://bugs.webkit.org/show_bug.cgi?id=40097

  • src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::notificationObjectDestroyed):
02:00 Changeset [61315] by ossy@webkit.org
  • 4 edits in trunk

Unreviewed rollout r61311, because it made 2 tests fail on Qt bot.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved
https://bugs.webkit.org/show_bug.cgi?id=36702

WebCore:

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):

LayoutTests:

  • platform/qt/Skipped:
01:31 Changeset [61314] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-17 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Fix a bug of Windows pixel tests
https://bugs.webkit.org/show_bug.cgi?id=40763

  • DumpRenderTree/chromium/TestEventPrinter.cpp: (TestShellPrinter::handleImage):
01:23 Changeset [61313] by zimmermann@webkit.org
  • 5 edits in trunk/LayoutTests

2010-06-17 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Land new expected baselines for fill-opacity-(hsl|rgba).png
DRT showed a mysterious error, and the baseline obviously had a problem.

  • platform/mac/svg/custom/fill-opacity-hsl-expected.checksum:
  • platform/mac/svg/custom/fill-opacity-hsl-expected.png:
  • platform/mac/svg/custom/fill-opacity-rgba-expected.checksum:
  • platform/mac/svg/custom/fill-opacity-rgba-expected.png:
00:48 Changeset [61312] by hausmann@webkit.org
  • 5 edits in trunk

WebCore: Make repaint throttling parameters runtime configurable.
https://bugs.webkit.org/show_bug.cgi?id=38401

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2010-05-28
Reviewed by Simon Hausmann, Antti Koivisto

REPAINT_THROTTLING now chooses default values for throttling parameters.
Should be removed when applications start using runtime configuration.

  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::updateDeferredRepaintDelay):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):
(WebCore::FrameView::setRepaintThrottlingnInitialDeferredRepaintDelayDuringLoading):
(WebCore::FrameView::setRepaintThrottlingMaxDeferredRepaintDelayDuringLoading):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelayIncrementDuringLoading):

  • page/FrameView.h:

WebKit/qt: [Qt] Add internal Qt Api to configure repaint throttling parameters.
https://bugs.webkit.org/show_bug.cgi?id=38401

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2010-05-28
Reviewed by Simon Hausmann, Antti Koivisto

  • Api/qwebpage.cpp:

(QWebPagePrivate::dynamicPropertyChangeEvent):

00:33 Changeset [61311] by eric@webkit.org
  • 4 edits in trunk

2010-06-17 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • platform/qt/Skipped:

2010-06-17 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
00:15 Changeset [61310] by hausmann@webkit.org
  • 4 edits in trunk/WebCore

[Qt] Avoid unnecessary calls to save() and restore() when drawing images

Reviewed by Kenneth Christiansen.

Avoid calling the expensive save() and restore() on the GraphicsContext just
for changing the composition mode. Instead save and restore it manually
on QPainter.

Change fac227f609e544f8f55aca8447b4328d6534407a in Qt makes sure that the
call to QPainter::setCompositionMode doesn't do anything if the mode hasn't
changed.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::toQtCompositionMode):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

Note: See TracTimeline for information about the timeline view.