Timeline


and

06/22/10:

23:54 Changeset [61664] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed Qt/Symbian build fix.

Fix "make clean" to not try to execute clean commands for
the extra targets we use to simulate "make install".

  • WebCore.pro: Use no_clean in CONFIG of extra compilers.
23:44 Changeset [61663] by eric@webkit.org
  • 53 edits in trunk

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Run clean-header-guards to fix some header guards
https://bugs.webkit.org/show_bug.cgi?id=41044

No functional changes, thus no tests.

This entire change was generated by running
clean-header-guards, and then reverting changes
to files which shouldn't be changed. Those which
are left all should be updated.

Some of these changes are just fixing 755 permissions
to be 644, since it seems various files have the wrong
execute bit which don't need it. clean-header-guards
made those (welcome) permission fixes unintentionally.

  • bindings/v8/custom/V8HTMLAudioElementConstructor.h:
  • bindings/v8/custom/V8HTMLImageElementConstructor.h:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h:
  • dom/Touch.h:
  • dom/TouchList.h:
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserScope.h:
  • html/HTML5DocumentParser.h:
  • html/LegacyHTMLTreeConstructor.h:
  • loader/CrossOriginPreflightResultCache.h:
  • page/OriginAccessEntry.h:
  • page/win/FrameWin.h:
  • platform/ThreadTimers.h:
  • platform/chromium/KeyboardCodes.h:
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  • platform/graphics/chromium/FontUtilsChromiumWin.h:
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/gstreamer/DataSourceGStreamer.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.h:
    • I checked, this crazy define was not referenced anywhere else. It's safe to change the name. :)
  • platform/graphics/haiku/FontPlatformData.h:
  • platform/graphics/qt/FontCustomPlatformData.h:
  • platform/graphics/skia/SkiaFontWin.h:
  • platform/graphics/win/GraphicsLayerCACF.h:
  • platform/graphics/win/QTMovieWinTimer.h:
  • platform/graphics/win/RefCountedGDIHandle.h:
  • platform/graphics/win/WebLayer.h:
  • platform/graphics/win/WebTiledLayer.h:
  • platform/graphics/wince/FontPlatformData.h:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/network/CredentialStorage.h:
  • platform/network/cf/FormDataStreamCFNet.h:
  • platform/network/curl/FormDataStreamCurl.h:
  • platform/network/qt/DnsPrefetchHelper.h:
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/win/PlatformScrollBar.h:
  • plugins/PluginDatabase.h:
  • plugins/PluginPackage.h:
  • plugins/PluginStream.h:
  • plugins/qt/PluginContainerQt.h:
  • plugins/symbian/npinterface.h:
  • rendering/RenderSelectionInfo.h:
  • rendering/SVGRenderSupport.h:
  • storage/IDBObjectStoreImpl.h:
  • svg/animation/SMILTimeContainer.h:
  • wml/WMLErrorHandling.h:

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Run clean-header-guards to fix some header guards
https://bugs.webkit.org/show_bug.cgi?id=41044

No functional changes, thus no tests.

This entire change was generated by running
clean-header-guards, and then reverting changes
to files which shouldn't be changed. Those which
are left all should be updated.

Some of these changes are just fixing 755 permissions
to be 644, since it seems various files have the wrong
execute bit which don't need it. clean-header-guards
made those (welcome) permission fixes unintentionally.

  • DumpRenderTree/chromium/WebThemeControlDRT.h:
  • DumpRenderTree/chromium/WebThemeEngineDRT.h:
  • QtTestBrowser/fpstimer.h:
23:41 Changeset [61662] by abarth@webkit.org
  • 29 edits
    2 moves in trunk

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTMLDocumentParser to LegacyHTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=41043

  • src/WebEntities.cpp:

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTMLDocumentParser to LegacyHTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=41043

As requested by Darin Adler.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
  • dom/Document.cpp: (WebCore::Document::write):
  • dom/DocumentFragment.cpp:
  • dom/DocumentParser.h: (WebCore::DocumentParser::asHTMLDocumentParser):
  • dom/XMLDocumentParserLibxml2.cpp:
  • dom/XMLDocumentParserQt.cpp:
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::columnNumber):
  • html/HTML5TreeBuilder.cpp:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • html/HTMLDocumentParser.cpp: Removed.
  • html/HTMLDocumentParser.h: Removed.
  • html/HTMLFormControlElement.cpp:
  • html/HTMLParserScheduler.cpp: (WebCore::parserChunkSize):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser): (WebCore::HTMLViewSourceDocument::addViewSourceToken):
  • html/HTMLViewSourceDocument.h:
  • html/LegacyHTMLDocumentParser.cpp: Copied from WebCore/html/HTMLDocumentParser.cpp. (WebCore::LegacyHTMLDocumentParser::LegacyHTMLDocumentParser): (WebCore::LegacyHTMLDocumentParser::reset): (WebCore::LegacyHTMLDocumentParser::begin): (WebCore::LegacyHTMLDocumentParser::setForceSynchronous): (WebCore::LegacyHTMLDocumentParser::processListing): (WebCore::LegacyHTMLDocumentParser::parseNonHTMLText): (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::scriptExecution): (WebCore::LegacyHTMLDocumentParser::parseComment): (WebCore::LegacyHTMLDocumentParser::parseServer): (WebCore::LegacyHTMLDocumentParser::parseProcessingInstruction): (WebCore::LegacyHTMLDocumentParser::parseText): (WebCore::LegacyHTMLDocumentParser::parseEntity): (WebCore::LegacyHTMLDocumentParser::parseDoctype): (WebCore::LegacyHTMLDocumentParser::parseTag): (WebCore::LegacyHTMLDocumentParser::continueProcessing): (WebCore::LegacyHTMLDocumentParser::advance): (WebCore::LegacyHTMLDocumentParser::willWriteHTML): (WebCore::LegacyHTMLDocumentParser::didWriteHTML): (WebCore::LegacyHTMLDocumentParser::write): (WebCore::LegacyHTMLDocumentParser::stopParsing): (WebCore::LegacyHTMLDocumentParser::processingData): (WebCore::LegacyHTMLDocumentParser::timerFired): (WebCore::LegacyHTMLDocumentParser::end): (WebCore::LegacyHTMLDocumentParser::finish): (WebCore::LegacyHTMLDocumentParser::finishWasCalled): (WebCore::LegacyHTMLDocumentParser::processToken): (WebCore::LegacyHTMLDocumentParser::processDoctypeToken): (WebCore::LegacyHTMLDocumentParser::~LegacyHTMLDocumentParser): (WebCore::LegacyHTMLDocumentParser::enlargeBuffer): (WebCore::LegacyHTMLDocumentParser::enlargeScriptBuffer): (WebCore::LegacyHTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::LegacyHTMLDocumentParser::notifyFinished): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsIfReady): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsTimerFired): (WebCore::LegacyHTMLDocumentParser::continueExecutingExternalScripts): (WebCore::LegacyHTMLDocumentParser::isWaitingForScripts): (WebCore::LegacyHTMLDocumentParser::setSrc): (WebCore::parseLegacyHTMLDocumentFragment):
  • html/LegacyHTMLDocumentParser.h: Copied from WebCore/html/HTMLDocumentParser.h. (WebCore::LegacyHTMLDocumentParser::asHTMLDocumentParser):
  • html/LegacyHTMLTreeConstructor.cpp: (WebCore::LegacyHTMLTreeConstructor::reportErrorToConsole):
  • html/LegacyHTMLTreeConstructor.h:
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser): (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate): (WebCore::FTPDirectoryDocumentParser::finish):
  • page/XSSAuditor.h:

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTMLDocumentParser to LegacyHTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=41043

Update the hash.

  • Scripts/do-webcore-rename:
23:35 Changeset [61661] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2010-06-22 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed attempt to fix the windows build.

Split out HTML5DocumentParser yield/resume logic into a separate class
https://bugs.webkit.org/show_bug.cgi?id=41018

  • WebCore.vcproj/WebCore.vcproj:
23:30 Changeset [61660] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2010-06-22 Sam Magnuson <smagnuson@netflix.com>

Reviewed by Shinichiro Hamaji.

Follow proper convention for variable declaration spacing.
https://bugs.webkit.org/show_bug.cgi?id=40724

Modified test so that 'int a;' is not allowed.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
23:29 Changeset [61659] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-22 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up to r61655 to make Chromium tests happy.

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
23:18 Changeset [61658] by eric@webkit.org
  • 9 edits
    2 adds in trunk/WebCore

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split out HTML5DocumentParser yield/resume logic into a separate class
https://bugs.webkit.org/show_bug.cgi?id=41018

The HTML5DocumentParser is just the coordinator, and shouldn't have
any real parsing logic of his own. Continuing along that path, I'm
moving the when-to-yield/resume logic out into a separate class.

I could have create a new HTMLParserSchedulerHost virtual interface
to allow the HTMLParserScheduler to talk back to the
HTML5DocumentParser, but instead I just exposed the one method it
needs (resumeParsing()) as a public method. Since no code besides
HTMLDocument (and DocumentFrament) ever should know about the
HTML5DocumentParser DocumentParser subclass, no class should ever
see the resumeParsing() method anyway.

Most of this change is just moving code from HTML5DocumentParser
to the new HTMLParserScheduler.

Some of this change is wrapping previous direct access to
m_continueNextChunkTimer.isActive() with isScheduledForResume().

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::stopParsing): (WebCore::HTML5DocumentParser::processingData): (WebCore::HTML5DocumentParser::pumpLexerIfPossible): (WebCore::HTML5DocumentParser::isScheduledForResume): (WebCore::HTML5DocumentParser::resumeParsing): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::end): (WebCore::HTML5DocumentParser::attemptToEnd): (WebCore::HTML5DocumentParser::endIfDelayed):
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::document):
    • Exposed for HTMLParserScheduler.
  • html/HTMLParserScheduler.cpp: Added. (WebCore::parserTimeLimit): Moved from HTML5DocumentParser. (WebCore::parserChunkSize): ditto. (WebCore::HTMLParserScheduler::HTMLParserScheduler): (WebCore::HTMLParserScheduler::~HTMLParserScheduler): (WebCore::isLayoutTimerActive): (WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
    • Moved from HTML5DocumentParser.
  • html/HTMLParserScheduler.h: Added. (WebCore::HTMLParserScheduler::PumpSession::PumpSession):
    • Moved from HTML5DocumentParser.

(WebCore::HTMLParserScheduler::shouldContinueParsing):
(WebCore::HTMLParserScheduler::isScheduledForResume):

22:59 QtWebKitReleases edited by hausmann@webkit.org
(diff)
22:26 Changeset [61657] by levin@chromium.org
  • 2 edits in trunk/LayoutTests
  • platform/qt/Skipped: Added an xhr test which requires progress events

next to the other xhr test which are disabled due to requiring progress events.

Reviewed by nobody (simple qt test fix).

22:24 Changeset [61656] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-22 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: send-data-blob.html fails.
22:17 Changeset [61655] by pfeldman@chromium.org
  • 15 edits in trunk/WebCore

2010-06-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move nodeByPath from InjectedScript to InspectorBackend.

https://bugs.webkit.org/show_bug.cgi?id=40988

  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::pushNodeByPathToFrontend):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend): (WebCore::InspectorDOMAgent::nodeForPath):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didPushNodeByPathToFrontend):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/InjectedScript.js:
  • inspector/front-end/InjectedScriptAccess.js:
21:39 Changeset [61654] by levin@chromium.org
  • 5 edits in trunk

REGRESSION: (r47291): Upload progress events are not fired for simple cross-site XHR.
https://bugs.webkit.org/show_bug.cgi?id=39029

Reviewed by Alexey Proskuryakov.

WebCore:

Specifically, WebKit should fire upload events if one or more event listeners are
registered on the XMLHttpRequestUpload object when send is called in an async manner.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest): Allow upload events to be fired when there are
handlers for them in the cross-origin simple request case.

LayoutTests:

  • http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt: Update results.
  • http/tests/xmlhttprequest/simple-cross-origin-progress-events.html: Add a test which adds an upload progress event handler before XMLHttpRequest.send() is called.
21:16 Changeset [61653] by kinuko@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-22 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed.

Update test expectations for qt/gtk.

  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
21:13 Changeset [61652] by hclam@chromium.org
  • 5 edits
    2 deletes in trunk/LayoutTests

Unreviewed. Build fix.

Rebaseline some test results to make build bots green again.

  • platform/chromium-mac/fast/js/switch-behaviour-expected.txt: Removed.
  • platform/chromium-mac/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-win/fast/js/switch-behaviour-expected.txt: Removed.
  • platform/chromium-win/inspector/timeline-parse-html-expected.txt:
  • platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium/test_expectations.txt:
21:10 Changeset [61651] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-06-22 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

Fix uninitialized SubframeLoader::m_containsPlugins
https://bugs.webkit.org/show_bug.cgi?id=41035

  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::SubframeLoader): Initialize m_containsPlugins with false.
20:55 Changeset [61650] by kinuko@chromium.org
  • 34 edits
    17 adds in trunk

2010-06-22 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
https://bugs.webkit.org/show_bug.cgi?id=40593

(Resubmitting with the correct file set.)

BlobBuilder is defined in FileAPI's FileWriter spec.
(http://dev.w3.org/2009/dap/file-system/file-writer.html)

Also removes the ENABLE_FILE_WRITER ifdef guard for BlobBuilder.

Tests: http/tests/local/blob/send-data-blob.html

http/tests/local/blob/send-hybrid-blob.html
http/tests/local/blob/send-sliced-data-blob.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::append):
  • html/BlobBuilder.h:
  • html/BlobBuilder.idl: Added.
  • page/DOMWindow.idl:

2010-06-22 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
https://bugs.webkit.org/show_bug.cgi?id=40593

(Resubmitting with the correct file set.)

Add new layout tests to test BlobBuilder interface.
Also update test expectations affected by adding the constructors to DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/blob/resources/hybrid-blob-util.js: Added.
  • http/tests/local/blob/script-tests/TEMPLATE.html: Added.
  • http/tests/local/blob/script-tests/send-data-blob.js: Added.
  • http/tests/local/blob/script-tests/send-hybrid-blob.js: Added.
  • http/tests/local/blob/script-tests/send-sliced-data-blob.js: Added.
  • http/tests/local/blob/send-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-data-blob.html: Added.
  • http/tests/local/blob/send-hybrid-blob-expected.txt: Added.
  • http/tests/local/blob/send-hybrid-blob.html: Added.
  • http/tests/local/blob/send-sliced-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-sliced-data-blob.html: Added.
  • http/tests/local/resources/file-for-drag-to-send2.txt: Added.
  • http/tests/resources/post-and-verify-hybrid.cgi: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles and Blob.slice.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles and Blob.slice.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles and Blob.slice.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
19:12 Changeset [61649] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-06-22 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix for r61648.

  • platform/graphics/GraphicsContext3D.h:
18:55 Changeset [61648] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-06-22 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kent Tamura.

Define GraphicsContext3D::platformLayer() for all remaining (non PLATFORM(MAC))
ports to get RenderLayerBacking.cpp compiling again.
https://bugs.webkit.org/show_bug.cgi?id=41026

  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::platformLayer):
18:49 Changeset [61647] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-06-22 Eric Seidel <eric@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

18:41 Changeset [61646] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-06-22 Eric Seidel <eric@webkit.org>

Unreviewed. Rolling out http://trac.webkit.org/changeset/61638
made a few tests crash.

Make PendingScript hold a CachedResourceClient open for its lifetime
https://bugs.webkit.org/show_bug.cgi?id=40968

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::watchForLoad): (WebCore::HTML5DocumentParser::notifyFinished):
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::~HTML5ScriptRunner): (WebCore::HTML5ScriptRunner::sourceFromPendingScript): (WebCore::HTML5ScriptRunner::isPendingScriptReady): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::hasScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::watchForLoad): (WebCore::HTML5ScriptRunner::stopWatchingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForStylesheets): (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::PendingScript::): (WebCore::HTML5ScriptRunner::PendingScript::PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::watchingForLoad):
  • html/HTML5ScriptRunnerHost.h:
18:27 Changeset [61645] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Fix for Crash when the renderer for the button in <input type="number"> goes away during event handling
https://bugs.webkit.org/show_bug.cgi?id=41013

Reviewed by Darin Adler.

Test: fast/forms/input-number-crash.html

  • rendering/TextControlInnerElements.cpp: (WebCore::SpinButtonElement::defaultEventHandler):

Nil check the RenderBox since its possible the renderer has gone away during event handling.

LayoutTests: Test for Crash when the renderer for the button in <input type="number"> goes away during event handling
https://bugs.webkit.org/show_bug.cgi?id=41013

Reviewed by Darin Adler.

  • fast/forms/input-number-crash-expected.txt: Added.
  • fast/forms/input-number-crash.html: Added.
17:54 Changeset [61644] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-22 Eric Seidel <eric@webkit.org>

Unreviewed. Add Tony Gentilcore now that he's a committer.

  • Scripts/webkitpy/common/config/committers.py:
17:46 Changeset [61643] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

17:45 Changeset [61642] by mrowe@apple.com
  • 1 copy in tags/Safari-534.1

New tag.

17:25 Changeset [61641] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-22 Eric Seidel <eric@webkit.org>

No review, skipping test due to revealed bug in ClipboardQt.

editing/execCommand/copy-without-selection.html fails on Qt after r61637
https://bugs.webkit.org/show_bug.cgi?id=41025

The Qt Clipboard::setData code wrongly reinterpret_casts UChar
data as char* data. This was exposed by the previous commit
which no long strips \0 characters during innerHTML.

Skipping the affected test until a Qt person can fix
platform/qt/ClipboardQt.cpp

  • platform/qt/Skipped:
16:56 Changeset [61640] by abarth@webkit.org
  • 13 edits
    3 adds in trunk

2010-06-22 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Add layout tests which test line numbers for both inline and event handler
scripts in HTML documents.
https://bugs.webkit.org/show_bug.cgi?id=40649

  • fast/js/resources/script-line-number.js: Added. (getLineFromError): (assertErrorOnLine):
  • fast/js/script-line-number-expected.txt: Added.
  • fast/js/script-line-number.html: Added.

2010-06-22 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Pull script line number from DocumentParser instead of pushing it to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=40649

This approach is cleaner and improves WebCore/benchmarks/parser/html-parser.html by ~2%.

Tests: fast/js/script-line-number.html

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::eventHandlerLineNumber):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::eventHandlerLineNumber): (WebCore::ScriptController::eventHandlerColumnNumber):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/V8Proxy.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::startElementNs):
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::pumpLexer):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::processToken):
16:55 Changeset [61639] by andersca@apple.com
  • 3 edits
    1 add in trunk/WebKit2

2010-06-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add a SimpleArgumentCoder class template that works on POD types
https://bugs.webkit.org/show_bug.cgi?id=41023

  • Platform/CoreIPC/SimpleArgumentCoder.h: Added. (CoreIPC::SimpleArgumentCoder::encode): (CoreIPC::SimpleArgumentCoder::decode):
  • Shared/WebCoreTypeArgumentMarshalling.h: (CoreIPC::):
  • WebKit2.xcodeproj/project.pbxproj:
16:46 Changeset [61638] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-06-22 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Make PendingScript hold a CachedResourceClient open for its lifetime
https://bugs.webkit.org/show_bug.cgi?id=40968

This replaces the mechanism introduced in r61374 with a simpler
approach from preventing unexpected purges; always keep a client open.
This will approach will allow deferred scripts to add a client after
the resource may have already been loaded without having to worry about
the buffer being purged in the meantime.

No new tests because making a CachedResource purge itself is not
testable from a LayoutTest.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::watchForLoad): (WebCore::HTML5DocumentParser::notifyFinished):
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::~HTML5ScriptRunner): (WebCore::HTML5ScriptRunner::sourceFromPendingScript): (WebCore::HTML5ScriptRunner::isPendingScriptReady): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::watchForLoad): (WebCore::HTML5ScriptRunner::stopWatchingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForStylesheets): (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::PendingScript::PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::~PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::setCachedScript): (WebCore::HTML5ScriptRunner::PendingScript::cachedScript): (WebCore::HTML5ScriptRunner::PendingScript::notifyFinished):
  • html/HTML5ScriptRunnerHost.h:
16:43 Changeset [61637] by abarth@webkit.org
  • 34 edits
    1 add in trunk

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fragment parsing needs to go through the HTML5 Parser code path
https://bugs.webkit.org/show_bug.cgi?id=40645

  • fast/canvas/canvas-getContext-invalid-expected.txt:
    • \0 is now converted to \uFFFD per HTML5.
  • fast/js/null-char-in-string-expected.txt: ditto.
  • fast/js/switch-behaviour-expected.txt: ditto.
  • fast/parser/comment-in-textarea-expected.txt:
    • <textarea> is parsed in the RCDATA state, which means that comments are ignored, thus the </textarea> in the comment correctly closes the <textarea>. This test is invalid. Our new behavior matches minefield.
  • fast/tokenizer/lessthan-terminates-tags-and-attrs-expected.txt:
    • This test is invalid and probably should just be removed. This same behavior is tested by fast/invalid/016.html.
  • inspector/timeline-parse-html-expected.txt:
    • The "extra" ParseHTML is expected. The HTML5 Parser tells the inspector about every parser pump, even ones which pump no data. The HTML5 parser pumps one last time in finish() to flush any buffered characters. Eventually we'll teach the inspector to filter out (not display) 0-sized pumps.
  • storage/domstorage/complex-values-expected.txt:
    • \0 is now converted to \uFFFD per HTML5
  • svg/dom/fuzz-path-parser-expected.txt: ditto.
  • svg/dom/rgb-color-parser-expected.txt: ditto
  • websocket/tests/bad-sub-protocol-control-chars-expected.txt: ditto.

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fragment parsing needs to go through the HTML5 Parser code path
https://bugs.webkit.org/show_bug.cgi?id=40645

Added a new HTML5DocumentParser::parseHTMLDocumentFragment
codepath which optionally calls through to the old fragment
parsing path, now renamed parseLegacyHTMLDocumentFragment.

  • dom/Element.cpp: (WebCore::Element::createContextualFragment):
    • Use document()->createDocumentFragment() instead of DocumentFragment::create() to match other callers (and not depend on DocumentFragment.h).
    • Update call to parseHTMLDocumentFragment to use the new HTML5 parser codepath.
  • dom/MappedAttributeEntry.h:
    • Add a FIXME about this horrible enum placement. Sadly this will cause a world-rebuild for everyone.
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::runScriptsForPausedTreeConstructor):
    • The main pumpLexer function has gotten to large. Move the script running logic into this new function.
    • Handle the case where we have no m_scriptRunner (fragment case).

(WebCore::HTML5DocumentParser::pumpLexer):

  • Use new runScriptsForPausedTreeConstructor().

(WebCore::HTML5DocumentParser::executingScript):
(WebCore::HTML5DocumentParser::inScriptExecution):

  • New function to handle the case where m_scriptRunner is null.

(WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution):

  • Use inScriptExecution() instead of m_scriptRunner->inScriptExecution().

(WebCore::HTML5DocumentParser::executeScript): ditto.
(WebCore::HTML5DocumentParser::notifyFinished): ditto.
(WebCore::HTML5DocumentParser::executeScriptsWaitingForStylesheets): ditto.
(WebCore::shouldUseLegacyParser):

  • Helper function to check the html5ParserEnabled() setting.

(WebCore::HTML5DocumentParser::parseHTMLDocumentFragment):

  • Run HTML5DocumentParser in fragment mode, or optionally run the legacy parser if !html5ParserEnabled().
  • html/HTML5DocumentParser.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
    • Implement the FragmentScriptingNotAllowed hack for platform/Pasteboard.
  • html/HTML5TreeBuilder.h:
  • html/HTMLDocumentParser.cpp: (WebCore::parseLegacyHTMLDocumentFragment):
    • Renamed from parseHTMLDocumentFragment
  • html/HTMLDocumentParser.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::insertAdjacentHTML):
    • Call HTML5DocumentParser::parseHTMLDocumentFragment.
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::documentFragment): ditto.
  • xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource): ditto.
16:37 Changeset [61636] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove Gtk 64-Release bot from core since it's broken
https://bugs.webkit.org/show_bug.cgi?id=41022

This bot alone has been responsible for more than 72 hours of
commit-queue blockage in the last week. The bot is broken -- keeps
losing its display server or similar. Until the Gtk folks can fix the
bot, we need to remove it from core. The WebKit community can't keep
it green as is.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
16:35 Changeset [61635] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2010-06-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Use the ArgumentCoder class template for decoding
https://bugs.webkit.org/show_bug.cgi?id=41021

  • Platform/CoreIPC/ArgumentCoder.h: (CoreIPC::ArgumentCoder::decode):
  • Platform/CoreIPC/ArgumentDecoder.h: (CoreIPC::ArgumentDecoder::decode):
  • Shared/WebCoreTypeArgumentMarshalling.h: (CoreIPC::):
16:22 Changeset [61634] by andersca@apple.com
  • 4 edits
    1 add in trunk/WebKit2

2010-06-22 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change the encode functions to be specializations of a class template
https://bugs.webkit.org/show_bug.cgi?id=41015

  • Platform/CoreIPC/ArgumentCoder.h: Added. (CoreIPC::ArgumentCoder::encode):
  • Platform/CoreIPC/ArgumentEncoder.h: (CoreIPC::ArgumentEncoder::encode):
  • Shared/WebCoreTypeArgumentMarshalling.h: (CoreIPC::):
  • WebKit2.xcodeproj/project.pbxproj:
16:21 Changeset [61633] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Get rid of more USE_LIBDISPATCH code.

Reviewed by Sam Weinig.

  • Plugins/Hosted/NetscapePluginHostProxy.h:
16:07 Changeset [61632] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Geoffrey Garen.

Two fast/dynamic tests needlessly depend on legacy <tag<tag> parsing behavior
https://bugs.webkit.org/show_bug.cgi?id=40946

These two tests would fail when we turned on
the HTML5 Lexer code path for DocumentFragment parsing.
This old parser quirk is covered by several other tests
including fast/invalid/016.html.

  • fast/dynamic/insertAdjacentHTML.html:
  • fast/dynamic/insertAdjacentText.html:
15:23 Changeset [61631] by cmarrin@apple.com
  • 9 edits in trunk/WebCore

2010-06-22 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=40643


Final phase of moving ownership of WebGLLayer to GraphicsContext3D.
As it turns out, I still have to have a separate CGLContextObj for
rendering because Core Animation composites in a separate thread,
so we need to disconnect WebGL rendering from CA compositing. But
this change is still worthwhile because it reduces dependencies
and makes it easier to port WebGL to other platforms.


No new tests since this is just restructuring and the current tests
are all still valid and do a sufficient test of WebGL functionality.

  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::platformLayer):
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToWebGL): (WebCore::GraphicsLayer::setWebGLNeedsDisplay):
  • platform/graphics/mac/GraphicsContext3DMac.mm: Add creation of WebGLLayer (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
  • platform/graphics/mac/GraphicsLayerCA.mm: Handle setting of WebGLLayer as content the same as for MediaLayer. Also changed WebGL related names for clarity (WebCore::GraphicsLayerCA::GraphicsLayerCA): (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateContentsWebGLLayer): (WebCore::GraphicsLayerCA::setContentsToWebGL): (WebCore::GraphicsLayerCA::setWebGLNeedsDisplay):
  • platform/graphics/mac/WebGLLayer.h:
  • platform/graphics/mac/WebGLLayer.mm: Got rid of storage for context and texture, now just store GraphicsContext3D and get them from there when needed (-[WebGLLayer copyCGLPixelFormatForDisplayMask:]): (-[WebGLLayer copyCGLContextForPixelFormat:]): (-[WebGLLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): (-[WebGLLayer copyImageSnapshotWithColorSpace:]):
  • rendering/RenderLayerBacking.cpp: Changed init of WebGL contentsLayer to pass WebGLLayer rather than GraphicsContext3D (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::rendererContentChanged):
15:13 Changeset [61630] by darin@apple.com
  • 2 edits in trunk/WebCore
  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::parseMappedAttribute): Removed incorrect FIXME comments.

Reviewed by Dave Hyatt.

15:10 Changeset [61629] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/8119403> REGRESSION (r61548): PLT is almost 1.5% slower, Google page cycler slower
https://bugs.webkit.org/show_bug.cgi?id=41012

Reviewed by Anders Carlsson.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine): Removed a redundant statement that was
left over in the original patch and resulted in double the calls to RenderText::width() here.
(WebCore::RenderBlock::findNextLineBreak): Changed the order of evaluating conditions for a
potential speedup.

15:05 QtWebKitReleases edited by hausmann@webkit.org
(diff)
14:58 QtWebKitReleases edited by hausmann@webkit.org
(diff)
14:55 QtWebKitTiling edited by jesus@webkit.org
(diff)
14:28 QtWebKitTiling edited by kenneth@webkit.org
(diff)
14:16 QtWebKitTiling edited by kenneth@webkit.org
(diff)
14:16 Changeset [61628] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Get rid of the USE_LIBDISPATCH code.

Reviewed by Sam Weinig.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):

13:30 Changeset [61627] by darin@apple.com
  • 2 edits in trunk/WebCore

Alexey asked me to take out the autorelease pools because he believes
that there is no code that should be running using Objective-C
autorelease. Most likely, the code that is triggering these stderr
messages is incorrect, and that bug should be fixed instead.

Reviewed by Alexey Proskuryakov.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::run): Roll out use of AutodrainedPool.

13:26 Changeset [61626] by darin@apple.com
  • 2 edits in trunk/WebCore

Fix autorelease problem seen when running worker regression tests.
We were seeing logs to stderr saying autorelease was used without
an autorelease pool being set up.

Reviewed by Brady Eidson.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::run): Use an AutodrainedPool as the file
thread, icon database, and database thread do. No effect on platforms
other than Mac.

12:54 Changeset [61625] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2010-06-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Wean NetscapePluginHostManager of any knowledge about WebNetscapePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=41006

  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPlugin): (WebKit::NetscapePluginHostManager::spawnPluginHost): (WebKit::NetscapePluginHostManager::instantiatePlugin): (WebKit::NetscapePluginHostManager::createPropertyListFile):
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage createPropertyListFile]):
12:39 Changeset [61624] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Implement PluginInfoStore::shouldUsePlugin.

Reviewed by Sam Weinig.

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::shouldUsePlugin):

  • WebKit2.xcodeproj/project.pbxproj:
12:16 Changeset [61623] by zherczeg@webkit.org
  • 12 edits
    3 adds in trunk/JavaScriptCore

Adding regular expression caching to JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=38142

Patch by Renata Hodovan <hodovan@inf.u-szeged.hu> on 2010-06-22
Reviewed by Geoffrey Garen.

The cache is based on Round Robin eviction policy, and
can cache at most 256 character long regular expressions,
and at most 256 of them. These values can be changed at compile time.

(JSC::RegExpNode::emitBytecode):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::regExpCache):

  • runtime/RegExpCache.cpp: Added.

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
(JSC::RegExpCache::RegExpCache):

  • runtime/RegExpCache.h: Added.
  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpKey.h: Added.

(JSC::RegExpKey::RegExpKey):
(JSC::RegExpKey::getFlagsValue):
(WTF::operator==):
(WTF::):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):

12:01 Changeset [61622] by cfleizach@apple.com
  • 5 edits
    2 adds in trunk

AX: If an element that is a continuation is removed, its parent tree is not notified appropriately that their children have changed
https://bugs.webkit.org/show_bug.cgi?id=41000

Reviewed by Darin Adler.

WebCore:

Test: accessibility/removed-continuation-element-causes-crash.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::updateChildrenIfNecessary):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/removed-continuation-element-causes-crash-expected.txt: Added.
  • accessibility/removed-continuation-element-causes-crash.html: Added.
11:15 Changeset [61621] by crogers@google.com
  • 6 adds in branches/audio/WebCore/audio

Initial incomplete work for DelayNode and WaveshaperNode

11:15 Changeset [61620] by crogers@google.com
  • 13 edits in branches/audio/WebCore/audio

Add direct audio data access to AudioBuffer

11:02 Changeset [61619] by pkasting@chromium.org
  • 14 edits in trunk/WebCore

Override setFailed() in each image decoder to clean up any temporary
objects.
https://bugs.webkit.org/show_bug.cgi?id=35411

Reviewed by Adam Barth.

In a few cases, we need to be careful to avoid deleting objects until
after they're no longer needed. These cases usually mean some jumping
through hoops, to the detriment of code simplicity.

No layout tests because this does not change the visible output of
decoding in any way.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::setData):

  • platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::setFailed):
(WebCore::BMPImageDecoder::decode):

  • platform/image-decoders/bmp/BMPImageDecoder.h:
  • platform/image-decoders/bmp/BMPImageReader.cpp:

(WebCore::BMPImageReader::decodeBMP):
(WebCore::BMPImageReader::readInfoHeaderSize):
(WebCore::BMPImageReader::processInfoHeader):
(WebCore::BMPImageReader::readInfoHeader):
(WebCore::BMPImageReader::processBitmasks):
(WebCore::BMPImageReader::processColorTable):
(WebCore::BMPImageReader::processRLEData):
(WebCore::BMPImageReader::processNonRLEData):

  • platform/image-decoders/bmp/BMPImageReader.h:

(WebCore::BMPImageReader::):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::setFailed):
(WebCore::GIFImageDecoder::decode):

  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::setFailed):
(WebCore::ICOImageDecoder::decode):

  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):
(WebCore::JPEGImageDecoder::setFailed):
(WebCore::JPEGImageDecoder::decode):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::PNGImageDecoder):
(WebCore::PNGImageDecoder::setFailed):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::decode):

  • platform/image-decoders/png/PNGImageDecoder.h:
08:56 Changeset [61618] by dglazkov@chromium.org
  • 6 edits in trunk/WebCore

2010-06-04 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Remove side effects of form submission and prepare FormDataBuilder for splitting up.
https://bugs.webkit.org/show_bug.cgi?id=40184

Refactoring, covered by existing tests.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission):
    • Changed to use new accessors on FormDataBuilder;
    • Simplified the logic around action URL;
    • Removed form submission side effect of element's enctype property being updated when

submitting a mailto form;

  • Removed unnecessary updating of action URL for mailto forms.

(WebCore::HTMLFormElement::submit): Moved action URL check into prepareFormSubmission.
(WebCore::HTMLFormElement::parseMappedAttribute): Updated to use new methods on FormDataBuilder.

  • html/HTMLFormElement.h: Removed decls for isMailtoForm and dataEncoding methods;

moved m_target and m_url to FormDataBuilder.

  • platform/network/FormData.cpp: (WebCore::FormData::appendDOMFormData): Removed unnecessary instantiation of FormDataBuilder.
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::parseAction): Moved from HTMLFormControl.
  • platform/network/FormDataBuilder.h: (WebCore::FormDataBuilder::action): Ditto. (WebCore::FormDataBuilder::target): Ditto. (WebCore::FormDataBuilder::setTarget): Ditto.
07:58 Changeset [61617] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector/elements-panel-limited-children.html test fails
https://bugs.webkit.org/show_bug.cgi?id=40924

  • http/tests/inspector/inspector-test.js: (onload): (frontend_setupTestEnvironment): always start inspector test with Elements panel as current one.
  • inspector/elements-panel-limited-children.html:
07:41 QtWebKitTriageRoster edited by hausmann@webkit.org
(diff)
07:40 Changeset [61616] by mnaganov@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-22 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Clean up after removal of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.

https://bugs.webkit.org/show_bug.cgi?id=40914

  • public/WebDevToolsAgentClient.h:
06:54 Changeset [61615] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Fix compilation with QT_NO_COMBOBOX.

Patch by Tasuku Suzuki <tasuku.suzuki@nokia.com> on 2010-06-22
Reviewed by Simon Hausmann.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::createSelectPopup):

05:25 Changeset [61614] by loki@webkit.org
  • 4 edits in trunk/JavaScriptCore

Add native call support for ARM and Thumb-2 JIT.
https://bugs.webkit.org/show_bug.cgi?id=40231

Reviewed by Geoffrey Garen.

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • wtf/Platform.h:
05:14 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
05:11 Changeset [61613] by mnaganov@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Add a sanity test for heap profiler.

https://bugs.webkit.org/show_bug.cgi?id=40917

  • src/js/Tests.js: (.TestSuite.prototype.testHeapProfiler.findDisplayedNode): (.TestSuite.prototype.testHeapProfiler.findVisibleView): (.TestSuite.prototype.testHeapProfiler):
05:03 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
04:59 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
04:44 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
04:41 Changeset [61612] by tkent@chromium.org
  • 20 edits
    3 adds
    2 deletes in trunk/LayoutTests

2010-06-22 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-linux/fast/parser/broken-comments-vs-parsing-mode-expected.checksum: Added.
  • platform/chromium-linux/fast/parser/broken-comments-vs-parsing-mode-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-mac/fast/parser/broken-comments-vs-parsing-mode-expected.checksum: Removed.
  • platform/chromium-mac/fast/parser/broken-comments-vs-parsing-mode-expected.png: Removed.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.checksum:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.png:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
04:40 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
04:37 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
04:28 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
01:59 Changeset [61611] by morrita@google.com
  • 4 edits in trunk/WebCore

2010-06-22 Yuta Kitamura <yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix WebSocketHandshakeRequest so that it fits the new handshake protocol.

The new WebSocket specification (draft 76 and later) allows a browser to
send header fields in arbitrary order. Thus we can use a HTTPHeaderMap to
store header fields instead of Vector of pairs of a field name and
a field value.

This patch also does refactoring of WebSocketHandshakeRequest class
to make it simpler and easier to use.

Fix WebSocketHandshakeRequest so that it fits the new handshake protocol
https://bugs.webkit.org/show_bug.cgi?id=39864

No new tests, because there is no functional change.

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::clientHandshakeRequest):
  • websockets/WebSocketHandshakeRequest.cpp: (WebCore::WebSocketHandshakeRequest::Key3::Key3): (WebCore::WebSocketHandshakeRequest::Key3::set): (WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest): (WebCore::WebSocketHandshakeRequest::requestMethod): (WebCore::WebSocketHandshakeRequest::url): (WebCore::WebSocketHandshakeRequest::addHeaderField): (WebCore::WebSocketHandshakeRequest::headerFields): (WebCore::WebSocketHandshakeRequest::key3): (WebCore::WebSocketHandshakeRequest::setKey3):
  • websockets/WebSocketHandshakeRequest.h:
01:45 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
01:28 Changeset [61610] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Upon closer reading of the spec, we think our behavior is correct.
We'll double-check with the working group.

  • fast/tokenizer/write-on-load-expected.txt:
  • fast/tokenizer/write-on-load.html:
01:22 Changeset [61609] by morrita@google.com
  • 7 edits in trunk

2010-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<meter> should be yellow when min < value < low < optimum
https://bugs.webkit.org/show_bug.cgi?id=40824

Update overlooked broken test results.

  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:

2010-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<meter> should be yellow when min < value < low < optimum
https://bugs.webkit.org/show_bug.cgi?id=40824

Fixed a wrong conditional on HTMLMeterElement::gaugeRegion().

  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::gaugeRegion):

Tests: fast/dom/HTMLMeterElement/meter-appearances-capacity.html

fast/dom/HTMLMeterElement/meter-optimums.html

01:14 Changeset [61608] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Follow the HTML5 spec more closely w.r.t. when to save the insertion point
https://bugs.webkit.org/show_bug.cgi?id=40976

This test no longer asserts. The output is incorrect, however. I'll
fix the output in the next patch.

  • fast/tokenizer/write-on-load-expected.txt: Added.
  • fast/tokenizer/write-on-load.html: Added.

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Follow the HTML5 spec more closely w.r.t. when to save the insertion point
https://bugs.webkit.org/show_bug.cgi?id=40976

The spec always increments the nesting level and saves the insertion
point at the same time. In this patch, we now do those operations
packaged as a RAII.

As a side effect, the test case below no longer ASSERTs. (The output
is wrong, but we'll get to that next.)

Test: fast/tokenizer/write-on-load.html

  • html/HTML5ScriptRunner.cpp: (WebCore::NestScript::NestScript): (WebCore::NestScript::~NestScript): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::executeScript): (WebCore::HTML5ScriptRunner::requestScript): (WebCore::HTML5ScriptRunner::runScript):
  • html/HTMLInputStream.h:
00:56 Changeset [61607] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Expose HTMLInputStream to ScriptRunner so that ScriptRunner can save the insertion point itself
https://bugs.webkit.org/show_bug.cgi?id=40975

This saves us having to call back into the HTML5DocumentParser each
time we need to save the insertion point. This prepares us for another
place we need to save the insertion point.

  • html/HTML5DocumentParser.cpp:
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::inputStream):
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::executeScript): (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunnerHost.h:
00:42 Changeset [61606] by abarth@webkit.org
  • 6 edits
    1 add in trunk/WebCore

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move HTMLInputStream to its own file
https://bugs.webkit.org/show_bug.cgi?id=40974

No new tests, just code motion.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5DocumentParser.h:
00:23 QtWebKitDocContrib created by henry.haverinen@nokia.com
00:23 QtWebKit edited by henry.haverinen@nokia.com
(diff)
00:13 Changeset [61605] by eric@webkit.org
  • 5 edits
    22 adds in trunk/LayoutTests

2010-06-21 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Alexey Proskuryakov.

Tests for:
Space should be allowed between -- and > in comment end
https://bugs.webkit.org/show_bug.cgi?id=21945

  • fast/css/word-space-extra.html: Tweaked the comment as -- > is now a valid comment end.
  • fast/parser/broken-comment-1-expected.txt: Added.
  • fast/parser/broken-comment-1.html: Added.
  • fast/parser/broken-comment-2-expected.txt: Added.
  • fast/parser/broken-comment-2.html: Added.
  • fast/parser/broken-comment-3-expected.txt: Added.
  • fast/parser/broken-comment-3.html: Added.
  • fast/parser/broken-comment-4-expected.txt: Added.
  • fast/parser/broken-comment-4.html: Added.
  • fast/parser/broken-comment-5-expected.txt: Added.
  • fast/parser/broken-comment-5.html: Added.
  • fast/parser/broken-comment-6-expected.txt: Added.
  • fast/parser/broken-comment-6.html: Added. Those test checks that broken comments in body are correctly parsed.
  • fast/parser/broken-comment-in-head-1-expected.txt: Added.
  • fast/parser/broken-comment-in-head-1.html: Added.
  • fast/parser/broken-comment-in-head-2-expected.txt: Added.
  • fast/parser/broken-comment-in-head-2.html: Added.
  • fast/parser/broken-comment-in-head-3-expected.txt: Added.
  • fast/parser/broken-comment-in-head-3.html: Added.
  • fast/parser/broken-comment-in-head-4-expected.txt: Added.
  • fast/parser/broken-comment-in-head-4.html: Added.
  • fast/parser/broken-comment-in-head-5-expected.txt: Added.
  • fast/parser/broken-comment-in-head-5.html: Added. Those test checks that broken comments in head are correctly parsed.
  • fast/parser/broken-comments-vs-parsing-mode.html: Needed to wrap the broken comment in a title as we match FF here and would not recover from it.
  • fast/parser/comments-expected.txt:
  • fast/parser/comments.html: Added more tests for comment parsing. Made sure that we close empty comments <!--> and <!---> as is specified in HTML5.
00:04 Changeset [61604] by abarth@webkit.org
  • 8 edits in trunk

2010-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Save the insertion point before beforeload events
https://bugs.webkit.org/show_bug.cgi?id=40973

Update expected results to show the proper document.write order.

  • fast/tokenizer/write-before-load-expected.txt:

2010-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Save the insertion point before beforeload events
https://bugs.webkit.org/show_bug.cgi?id=40973

We need to save the insertion point before dispatching the beforeload
event in case someone decides to document.write during beforeload.
Prior to this patch, such writes would pump the lexer too much and
tokenize the rest of the document before executing the script.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::dispatchBeforeLoad):
  • html/HTML5DocumentParser.h:
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunnerHost.h:
00:03 Changeset [61603] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Fix the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=40972

Reviewed by Eric Seidel.

  • DumpRenderTree/win/ImageDiff.vcproj:

06/21/10:

23:25 Changeset [61602] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.write from BeforeLoad should not assert
https://bugs.webkit.org/show_bug.cgi?id=40971

Test what happens when we document.write from a beforeload event.
Notice that the order is wrong. I'll fix that in a followup patch.

  • fast/tokenizer/write-before-load-expected.txt: Added.
  • fast/tokenizer/write-before-load.html: Added.

2010-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.write from BeforeLoad should not assert
https://bugs.webkit.org/show_bug.cgi?id=40971

We're setting the parse blocking script too early. It's not actually
blocking parsing yet.

Test: fast/tokenizer/write-before-load.html

  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::requestScript):
21:59 Changeset [61601] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, skip new modal tests on Tiger and update expected result for Chromium.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/mac-tiger/Skipped:
21:41 Changeset [61600] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing qt-specific expected results for r61599

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
21:24 Changeset [61599] by dimich@chromium.org
  • 54 edits
    6 adds
    7 deletes in trunk

DumpRenderTree should allow tests with modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=35350

Patch by Prasad Tammana <prasadt@chromium.org> on 2010-06-21
Reviewed by Darin Adler, Dmitry Titov.

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp:

(abortModalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::abortModal):
Add abortModal method to LayoutTestController and make it available from script.

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

LayoutTests:

Added a new test show-modal-dialog.html to harness tests to verify that showModalDialog works.

Added a new test, show-modal-dialog-onblur-onfocus.html, that takes advantage of the showModalDialog
functionality added to UIDelegate.mm. The test is only enabled on mac for now. This test will catch
regressions on the bug fix for https://bugs.webkit.org/show_bug.cgi?id=33962.

Support for showModalDialog affected the expected output for many tests that operate under the assumption
that the method is undefined. Modified the tests accordingly, in some cases disabled showModalDialog (not
currently tested anyway. Opened a bug to add showModalDialog specific tests where appropriate - Bug# 39897.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-frame-getter-precedence.html:
  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-name-getter-precedence.html:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:

Tweak tests so that showModalDialog part gets exercised only if its defined to keep output consistent across platforms.
Where its not possible, skip the test for showModalDialog, which is not currently exercised anyway.

  • fast/events/resources/modal-dialog.html: Added.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Added.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Added.
  • fast/harness/resources/modal-dialog.html: Added.
  • fast/harness/show-modal-dialog-expected.txt: Added.
  • fast/harness/show-modal-dialog.html: Added.

New tests that take advantage of showModalDialog in DRT.

  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt:

Update the expected output to reflect the fact that these tests pass now. Skip the tests on gtk, qt and win. They were all expected
to fail anyway. So no coverage lost.

  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put-expected.txt:

Skip showModalDialog to make test pass for all platforms. Added a FIXME with bug # to add a test specifically for showModalDialog.

  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • platform/chromium-mac/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/chromium-win/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.

Updaate expected output to reflect test changes. Removed some platform specific files where the only reason they're different is
because of showModalDialog.

  • platform/qt/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/win/Skipped:

Skip failing tests. Note that there is no test functionality lost. These are either new tests or tests that were dysfunctional anyway
in the absence of showModalDialog in DRT.

19:28 Changeset [61598] by morrita@google.com
  • 4 edits
    2 adds in trunk/WebKit/chromium

2010-06-21 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Dragging outside the frame immediately causes page to scroll
http://webkit.org/b/40461

This is regression that was introduced at http://webkit.org/b/39725.

There are 2 problems:

  1. It starts auto-scrolling immediately. We should have some delay.
  2. The scroll continues even after a mouse cursor goes outside a frame. The scroll should be stopped when the curosr has left.

This change introduced DragScrollTimer to handle 1.
At the same time, it fixed DragScrollTimer::scrollDistanceFor() to
handle 2, We now stop scrolling when the cursor gone.

  • WebKit.gyp:
  • src/DragScrollTimer.cpp: Added. (WebKit::distanceToRect): (WebKit::DragScrollTimer::DragScrollTimer): (WebKit::DragScrollTimer::~DragScrollTimer): (WebKit::DragScrollTimer::stop): (WebKit::DragScrollTimer::scroll): (WebKit::DragScrollTimer::update): (WebKit::DragScrollTimer::triggerScroll): (WebKit::DragScrollTimer::scrollDistanceFor):
  • src/DragScrollTimer.h: Added. (WebKit::DragScrollTimer::fired): (WebKit::DragScrollTimer::shouldScroll):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::dragSourceEndedAt): (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragTargetDrop): (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
  • src/WebViewImpl.h:
18:36 Changeset [61597] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

No review. QT build fix again.

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=40927

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

18:27 Changeset [61596] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

No review. QT build fix.

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=40927

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

18:07 Changeset [61595] by cfleizach@apple.com
  • 11 edits
    2 adds in trunk

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=40927

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/aria-expanded-notifications.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAriaExpandedChange):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::handleAriaExpandedChange):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::handleAriaExpandedChanged):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests:

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/accessibility/aria-expanded-notifications-expected.txt: Added.
  • platform/mac/accessibility/aria-expanded-notifications.html: Added.
17:33 Changeset [61594] by andersca@apple.com
  • 2 edits in trunk/WebKit2

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Support reading plug-in info from Carbon resources
https://bugs.webkit.org/show_bug.cgi?id=40959

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::ResourceMap::ResourceMap): (WebKit::ResourceMap::~ResourceMap): (WebKit::ResourceMap::isValid): (WebKit::getStringListResource): (WebKit::getPluginInfoFromCarbonResources): (WebKit::PluginInfoStore::getPluginInfo):
17:23 Changeset [61593] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):

17:07 Changeset [61592] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix an off-by-one bug I introduced.

Reviewed by Sam Weinig.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage getPluginInfoFromResources]):

17:00 Changeset [61591] by andersca@apple.com
  • 4 edits
    1 add in trunk/WebKit2

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Have PluginInfoStoreMac actually get plug-in info and populate the plug-in list
https://bugs.webkit.org/show_bug.cgi?id=40957

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::loadPluginsIfNecessary): (WebKit::PluginInfoStore::loadPluginsInDirectory): (WebKit::PluginInfoStore::loadPlugin): (WebKit::PluginInfoStore::getPlugins):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: Added. (WebKit::PluginInfoStore::pluginDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::getPluginArchitecture): (WebKit::getPluginInfoFromPropertyLists): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebKit2.xcodeproj/project.pbxproj:
16:42 Changeset [61590] by weinig@apple.com
  • 5 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.

Reviewed by Anders Carlsson.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
16:29 Changeset [61589] by simon.fraser@apple.com
  • 8 edits
    8 moves in trunk/WebKit2

2010-06-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=40948

Rename UIProcess version of DrawingAreaUpdateChunk to ChunkedUpdateDrawingAreaProxy,
and rename the Mac/Win versions of the various DrawingArea files too.

Also rename the DrawingAreaUpdateChunkType enum to ChunkedUpdateDrawingAreaType.

16:17 Changeset [61588] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

2010-06-21 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make JSC more resilient in the face of parse failures
https://bugs.webkit.org/show_bug.cgi?id=40951

A number of recent bugs have occurred due to issues like miscounting
BOMs, etc which lead to interesting crashes later on. Adding this
logic hardens JSC in the face of these errors, and has no impact on
performance (32bit jit actually gets 0.7% faster but I put that down
to cache effects).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::lineNumberForBytecodeOffset): (JSC::CodeBlock::expressionRangeForBytecodeOffset): (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::bytecodeOffset):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::prepareForRepeatCall): (JSC::Interpreter::privateExecute):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/ArrayPrototype.cpp: (JSC::isNumericCompareFunction):
  • runtime/Executable.cpp: (JSC::FunctionExecutable::compileForCall): (JSC::FunctionExecutable::compileForConstruct): (JSC::FunctionExecutable::generateJITCodeForCall): (JSC::FunctionExecutable::generateJITCodeForConstruct): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo):
  • runtime/Executable.h: (JSC::FunctionExecutable::bytecodeForCall): (JSC::FunctionExecutable::bytecodeForConstruct):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::numericCompareFunction):
16:00 Changeset [61587] by andersca@apple.com
  • 6 edits
    4 adds in trunk/WebKit2

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PluginInfoStore class
https://bugs.webkit.org/show_bug.cgi?id=40949

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::WebPreferencesStore):
  • Shared/WebPreferencesStore.h: (WebKit::WebPreferencesStore::encode): (WebKit::WebPreferencesStore::decode): Add plugInsEnabled to the preferences store.
  • UIProcess/Plugins: Added.
  • UIProcess/Plugins/PluginInfoStore.cpp: Added. (WebKit::PluginInfoStore::shared): (WebKit::PluginInfoStore::PluginInfoStore): (WebKit::PluginInfoStore::refresh): (WebKit::PluginInfoStore::getPlugins):
  • UIProcess/Plugins/PluginInfoStore.h: Added.
  • UIProcess/Plugins/mac: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):
15:57 Changeset [61586] by kinuko@chromium.org
  • 34 edits in trunk

2010-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61585.
http://trac.webkit.org/changeset/61585
https://bugs.webkit.org/show_bug.cgi?id=40950

It broke builds (Requested by kinuko on #webkit).

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::appendString): (WebCore::BlobBuilder::appendBlob):
  • html/BlobBuilder.h:
  • page/DOMWindow.idl:

2010-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61585.
http://trac.webkit.org/changeset/61585
https://bugs.webkit.org/show_bug.cgi?id=40950

It broke builds (Requested by kinuko on #webkit).

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
15:41 Changeset [61585] by kinuko@chromium.org
  • 34 edits in trunk

2010-06-21 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
https://bugs.webkit.org/show_bug.cgi?id=40593

BlobBuilder is defined in FileAPI's FileWriter spec.
(http://dev.w3.org/2009/dap/file-system/file-writer.html)

Also removes the ENABLE_FILE_WRITER ifdef guard for BlobBuilder.

Tests: http/tests/local/blob/send-data-blob.html

http/tests/local/blob/send-hybrid-blob.html
http/tests/local/blob/send-sliced-data-blob.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::append):
  • html/BlobBuilder.h:
  • html/BlobBuilder.idl: Added.
  • page/DOMWindow.idl:

2010-06-21 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
https://bugs.webkit.org/show_bug.cgi?id=40593

Add new layout tests to test BlobBuilder interface.
Also update test expectations affected by adding the constructors to DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/blob/resources/hybrid-blob-util.js: Added.
  • http/tests/local/blob/script-tests/TEMPLATE.html: Added.
  • http/tests/local/blob/script-tests/send-data-blob.js: Added.
  • http/tests/local/blob/script-tests/send-hybrid-blob.js: Added.
  • http/tests/local/blob/script-tests/send-sliced-data-blob.js: Added.
  • http/tests/local/blob/send-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-data-blob.html: Added.
  • http/tests/local/blob/send-hybrid-blob-expected.txt: Added.
  • http/tests/local/blob/send-hybrid-blob.html: Added.
  • http/tests/local/blob/send-sliced-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-sliced-data-blob.html: Added.
  • http/tests/local/resources/file-for-drag-to-send2.txt: Added.
  • http/tests/resources/post-and-verify-hybrid.cgi: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
15:33 Changeset [61584] by japhet@chromium.org
  • 25 edits
    2 adds in trunk

2010-06-21 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

FrameLoader cleanup: Split high level subframe and plugin
loading functions into a separate class.
https://bugs.webkit.org/show_bug.cgi?id=40453

Refactor only, no new tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMImplementation.cpp:
  • history/PageCache.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLMediaElement.cpp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: (WebCore::FrameLoader::subframeLoader):
  • loader/PluginDocument.cpp:
  • loader/SubframeLoader.cpp: Added. (WebCore::SubframeLoader::SubframeLoader): (WebCore::toPlugInElement): (WebCore::SubframeLoader::clear): (WebCore::SubframeLoader::requestFrame): (WebCore::SubframeLoader::requestObject): (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::allowPlugins): (WebCore::SubframeLoader::shouldUsePlugin): (WebCore::SubframeLoader::loadPlugin): (WebCore::SubframeLoader::completeURL):
  • loader/SubframeLoader.h: Added. (WebCore::SubframeLoader::containsPlugins):
  • page/Page.cpp:
  • page/XSSAuditor.h:
  • platform/graphics/wince/MediaPlayerProxy.cpp:
  • plugins/MimeType.cpp:
  • rendering/RenderApplet.cpp:
  • rendering/RenderEmbeddedObject.cpp:
15:22 Changeset [61583] by simon.fraser@apple.com
  • 9 edits
    2 moves in trunk

2010-06-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=40948

Rename DrawingAreaUpdateChunk to ChunkedUpdateDrawingArea.

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:pageNamespaceRef:]):
  • UIProcess/ChunkedUpdateDrawingArea.cpp: Added. (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::~ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::paint): (WebKit::ChunkedUpdateDrawingArea::setSize): (WebKit::ChunkedUpdateDrawingArea::setPageIsVisible): (WebKit::ChunkedUpdateDrawingArea::didSetSize): (WebKit::ChunkedUpdateDrawingArea::update): (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
  • UIProcess/ChunkedUpdateDrawingArea.h: Added. (WebKit::ChunkedUpdateDrawingArea::encode):
  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: Removed.
  • UIProcess/DrawingAreaProxyUpdateChunk.h: Removed.
  • UIProcess/mac/DrawingAreaProxyUpdateChunkMac.mm: (WebKit::ChunkedUpdateDrawingArea::page): (WebKit::ChunkedUpdateDrawingArea::ensureBackingStore): (WebKit::ChunkedUpdateDrawingArea::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingArea::platformPaint): (WebKit::ChunkedUpdateDrawingArea::drawUpdateChunkIntoBackingStore):
  • UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp: (WebKit::ChunkedUpdateDrawingArea::page): (WebKit::ChunkedUpdateDrawingArea::ensureBackingStore): (WebKit::ChunkedUpdateDrawingArea::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingArea::platformPaint): (WebKit::ChunkedUpdateDrawingArea::drawUpdateChunkIntoBackingStore):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView):
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
15:09 Changeset [61582] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Another Tiger build fix.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

14:40 Changeset [61581] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

More WebBasePluginPackage cleanup
https://bugs.webkit.org/show_bug.cgi?id=40944

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::pluginCancelledConnectionError):
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::pluginCancelledConnectionError):
  • Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::pluginName):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage finalize]): (-[WebBasePluginPackage pluginInfo]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:WebCore::]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage isJavaPlugIn]): (-[WebBasePluginPackage versionNumber]): (-[WebBasePluginPackage WebCore::]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _initWithPath:]): (-[WebNetscapePluginPackage _applyDjVuWorkaround]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage supportsSnapshotting]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage load]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
14:39 Changeset [61580] by robert@webkit.org
  • 4 edits in trunk

2010-06-21 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html

It's a Mac-specific test so just add the required LayoutTestController
function as a no-op to avoid failing. Similar approach adopted by other
ports.

https://bugs.webkit.org/show_bug.cgi?id=33344

  • platform/qt/Skipped:

2010-06-21 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html

It's a Mac-specific test so just add the required LayoutTestController
function as a no-op to avoid failing. Similar approach adopted by other
ports.

https://bugs.webkit.org/show_bug.cgi?id=33344

  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::addDisallowedURL):
14:36 Changeset [61579] by weinig@apple.com
  • 21 edits
    3 adds in trunk

Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
Add message passing support to the WebKit2 API.

Reviewed by Anders Carlsson.

WebKit2:

Adds message passing for both InjectedBundle -> WebContext
and WebContext -> InjectedBundle.

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: Added.

(WebProcessProxyMessage::):
(CoreIPC::):

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetInjectedBundleClient):
(WKContextPostMessageToInjectedBundle):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeInjectedBundleClient):
(WebKit::WebContext::forwardMessageToWebContext):
(WebKit::WebContext::postMessageToInjectedBundle):

  • UIProcess/WebContext.h:
  • UIProcess/WebContextInjectedBundleClient.cpp: Added.

(WebKit::WebContextInjectedBundleClient::WebContextInjectedBundleClient):
(WebKit::WebContextInjectedBundleClient::initialize):
(WebKit::WebContextInjectedBundleClient::didRecieveMessageFromInjectedBundle):

  • UIProcess/WebContextInjectedBundleClient.h: Added.
  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::processDidClose):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveInjectedBundleMessage):
(WebKit::WebProcessProxy::didReceiveMessage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostMessage):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::didCreatePage):
(WebKit::InjectedBundle::didRecieveMessage):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::loadInjectedBundle):
(WebKit::WebProcess::forwardMessageToInjectedBundle):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:

WebKitTools:

  • Add some test messages.
  • MiniBrowser/mac/AppDelegate.m:

(_didRecieveMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didClearWindow):
(_didCreatePage):
(_didRecieveMessage):
(WKBundleInitialize):

14:07 Changeset [61578] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-21 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Missing forward entries when dumping back/forward list

These now pass.
https://bugs.webkit.org/show_bug.cgi?id=32470

http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html
http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html

  • platform/qt/Skipped:
14:01 Changeset [61577] by sullivan@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixed bugzilla URL in previous checkin.

13:59 Changeset [61576] by sullivan@apple.com
  • 2 edits in trunk/JavaScriptCore

RetainPtr can't be used in HashMaps or HashSets
<https://bugs.webkit.org/post_bug.cgi>

Reviewed by Adam Roben.

Added hashing knowledge similar to that in COMPtr.h.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::RetainPtr):
New function, copied from COMPtr.h but for the type change.
(WTF::RetainPtr::isHashTableDeletedValue):
Ditto.
(WTF::RetainPtr::hashTableDeletedValue):
Ditto.
Added template code for HashTraits and PtrHash copied from COMPtr.h but for the type change.
The only difference is that constructDeletedValue() matches the RefPtr implementation (in HashTraits.h)
rather than the COMPtr implementation.

13:59 Changeset [61575] by robert@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-21 Robert Hogan <robert@webkit.org>

[Qt] Build fix for Qt on Windows MSVC2008

Unreviewed, build fix.

Fix by Jocelyn Turcotte.

  • Api/qwebframe.cpp:
13:50 Changeset [61574] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Another PowerPC build fix.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage openResourceFile]):
(-[WebNetscapePluginPackage _tryLoad]):

13:48 Changeset [61573] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Mark hyphenation tests as failing on Chromium
Hyphenation landed in http://trac.webkit.org/changeset/61548.

  • platform/chromium/test_expectations.txt: Added failing tests.
13:40 Changeset [61572] by japhet@chromium.org
  • 2 edits in trunk/WebKit/win

2010-06-21 Nate Chapin <japhet@chromium.org>

Unreviewed, Windows build fix.

Update WebFrame to use FrameLoaderStateMachine in

firstLayoutDone().

  • WebFrame.cpp: (WebFrame::firstLayoutDone):
13:32 Changeset [61571] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Try to fix the PowerPC build.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

13:26 Changeset [61570] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing a test expectations on Windows.

  • platform/win/fast/dom/prototype-inheritance-expected.txt:
13:20 Changeset [61569] by japhet@chromium.org
  • 2 edits in trunk/WebCore

2010-06-21 Nate Chapin <japhet@chromium.org>

Unreviewed, build fix.

Bad merge, left a reference to m_committedFirstRealDocumentLoad in
http://trac.webkit.org/changeset/61568.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):
13:06 Changeset [61568] by japhet@chromium.org
  • 19 edits
    2 adds in trunk

2010-06-21 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Remove a couple of FrameLoader's unused boolean members
(m_receivedData, m_cancellingWithLoadInProcess) and merge
several more into a single state machine called FrameLoaderStateMachine
(m_firstLayoutDone, m_creatingInitialEmptyDocument,
m_isDisplayingInitialEmptyDocument, m_committedFirstRealDocumentLoad).

https://bugs.webkit.org/show_bug.cgi?id=39695

Refactor only, so no new tests.

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): (WebCore::DocumentWriter::begin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::logCanCachePageDecision): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::frameHasLoaded): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::dispatchDidCommitLoad):
  • loader/FrameLoader.h: (WebCore::FrameLoader::stateMachine):
  • loader/FrameLoaderStateMachine.cpp: Added.
  • loader/FrameLoaderStateMachine.h: Added.
  • loader/HistoryController.cpp: (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::saveDocumentState):
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission):
12:58 Changeset [61567] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Build fix after conversion of WebInterfaceSystem to Obj-C++.

12:57 Changeset [61566] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix. Fix header includes for ENABLE(DATABASE)

12:22 Changeset [61565] by dglazkov@chromium.org
  • 2 edits in trunk/WebKit/mac

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Dan Bernstein.

Chromium/Mac build fix.

  • WebCoreSupport/WebSystemInterface.mm: Change the order of wtf/Platform.h include to let other

headers smell it.

12:11 Changeset [61564] by atwilson@chromium.org
  • 47 edits
    6 deletes in trunk

WebKitTools: Unreviewed.

Rolling back 61551 and 61555 due to test failures.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setEditingBehavior):

  • DumpRenderTree/mac/UIDelegate.mm:

LayoutTests: Unreviewed rollback.

Rolling back 61551 and 61555 due to test failures on Linux/Win.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-frame-getter-precedence.html:
  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-name-getter-precedence.html:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/events/resources/modal-dialog.html: Removed.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Removed.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Removed.
  • fast/harness/resources/modal-dialog.html: Removed.
  • fast/harness/show-modal-dialog-expected.txt: Removed.
  • fast/harness/show-modal-dialog.html: Removed.
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
11:57 Changeset [61563] by andersca@apple.com
  • 11 edits in trunk

WebKit2: Make WebKit2 build with clang++

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView keyUp:]):
(-[WKView keyDown:]):

  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:

WebKitTools: Make DumpRenderTree build with clang++

Reviewed by Sam Weinig.

  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:

(-[LocalPasteboard setPropertyList:forType:]):

  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow keyDown:]):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::elementDoesAutoCompleteForElementWithId):
(LayoutTestController::isCommandEnabled):

11:41 Changeset [61562] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

Make all of WebKit build with clang++

Reviewed by Dan Bernstein.

  • DefaultDelegates/WebDefaultPolicyDelegate.m:

(-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setSuppressLayout:]):

  • WebView/WebHTMLRepresentation.mm:
  • WebView/WebNavigationData.mm:

(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):

  • WebView/WebPDFRepresentation.mm:

(-[WebPDFRepresentation setDataSource:]):
(-[WebPDFRepresentation receivedData:withDataSource:]):
(-[WebPDFRepresentation receivedError:withDataSource:]):

  • WebView/WebResource.mm:

(-[WebResource description]):

  • WebView/WebSerializedJSValue.mm:

(-[WebSerializedJSValue initWithValue:context:exception:]):

  • WebView/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController WebCore::]):
(-[WebVideoFullscreenController setMediaElement:WebCore::]):
(-[WebVideoFullscreenController setDelegate:]):
(-[WebVideoFullscreenController enterFullscreen:]):

  • WebView/WebView.mm:

(-[WebView _openFrameInNewWindowFromMenu:]):
(-[WebView _geolocationDidChangePosition:]):

11:38 Changeset [61561] by mitz@apple.com
  • 2 edits in trunk/WebKitLibraries

Speculative build fix.

  • WebKitSystemInterface.h:
11:29 Changeset [61560] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix clang++ build.

  • loader/FormSubmission.h:
11:19 Changeset [61559] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Add a missing include in AsyncImageResizer.h

  • html/AsyncImageResizer.h: Added the IntSize include.
11:02 Changeset [61558] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove unused dictionary ivars from WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40928

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10:51 Changeset [61557] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations tweak.

Use C++-style comments rather than Python-style.

  • platform/chromium/test_expectations.txt: Tweaked comment style.
10:46 Changeset [61556] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

10:44 Changeset [61555] by atwilson@chromium.org
  • 6 adds in trunk/LayoutTests/fast

2010-06-21 Drew Wilson <atwilson@chromium.org>

Unreviewed.

Missing files from r61551.

  • fast/events/resources/modal-dialog.html: Added.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Added.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Added.
  • fast/harness/resources/modal-dialog.html: Added.
  • fast/harness/show-modal-dialog-expected.txt: Added.
  • fast/harness/show-modal-dialog.html: Added.
10:43 Changeset [61554] by aroben@apple.com
  • 2 edits in trunk/WebCore

Call NotifyAddrChange again each time we are notified of a change

NotifyAddrChange only notifies you of a single change. If you want to
listen for subsequent changes, you have to call it again.

Fixes <http://webkit.org/b/33004> NetworkStateNotifier ignores all
state changes after the first.

No test possible, as we don't have a way to modify the system's
network adapters when running tests.

Reviewed by Anders Carlsson.

  • platform/network/win/NetworkStateNotifierWin.cpp:

(WebCore::NetworkStateNotifier::addrChangeCallback): Call
registerForAddressChange as soon as we're notified of an address
change, so we'll also get notified of the *next* address change. I
added the call here instead of in addressChanged (which is called
later on the main thread) to minimize the time between the callback
and registering again (so that we won't miss changes that happen in
rapid succession).

10:43 Changeset [61553] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-06-19 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Need to ensure that we grow the RegisterFile when creating a callframe for host code
https://bugs.webkit.org/show_bug.cgi?id=40858
<rdar://problem/8108986>

In the past the use of the callframe in hostcode was much more
limited. Now that we expect the callframe to always be valid
we need to grow the RegisterFile so that this is actually the
case. In this particular case the problem was failing to grow
the registerfile could lead to a callframe that extended beyond
RegisterFiler::end(), so vm re-entry would clobber the callframe
other scenarios could also lead to badness.

I was unable to construct a simple testcase to trigger badness,
and any such testcase would be so dependent on exact vm stack
layout that it would be unlikely to work as a testcase following
any callframe or register allocation changes anyway.

Thankfully the new assertion I added should help to catch these
failures in future, and triggers on a couple of tests currently.

  • interpreter/CallFrame.cpp: (JSC::CallFrame::registerFile):
  • interpreter/CallFrame.h: (JSC::ExecState::init):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
10:21 Changeset [61552] by mitz@apple.com
  • 2 edits in trunk/WebCore

Release build fix

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating):

10:17 Changeset [61551] by atwilson@chromium.org
  • 47 edits in trunk

DumpRenderTree should allow tests with modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=35350

Patch by Prasad Tammana <prasadt@chromium.org> on 2010-06-21
Reviewed by Darin Adler.

  • DumpRenderTree/LayoutTestController.cpp:

(abortModalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::abortModal):
Add abortModal method to LayoutTestController and make it available from script.

.:

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

WebKitTools:

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

10:14 Changeset [61550] by leandro@webkit.org
  • 2 edits in trunk

2010-06-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed debug build fix.

[CMake] Do not force build type to Release
https://bugs.webkit.org/show_bug.cgi?id=40566

  • CMakeLists.txt:
10:07 Changeset [61549] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Fixed a typo.
09:54 Changeset [61548] by mitz@apple.com
  • 42 edits
    12 adds in trunk

WebCore: CSS3: Implement the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

Tests: fast/text/hyphenate-character.html

fast/text/hyphens.html

Added -webkit-hyphens and -webkit-hyphenate-character as specified in
<http://www.w3.org/TR/2010/WD-css3-gcpm-20100608/#hyphenation>.

  • Android.mk: Added Hyphenation.cpp.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Added Hyphenation.{cpp,h}.
  • WebCore.base.exp: Exported wkGetHyphenationLocationBeforeIndex().
  • WebCore.gypi: Added Hyphenation.{cpp,h}.
  • WebCore.pro: Added Hyphenation.{cpp,h}.
  • WebCore.vcproj/WebCore.vcproj: Added Hyphenation.{cpp,h}.
  • WebCore.xcodeproj/project.pbxproj: Added Hyphenation.{cpp,h}.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added the -webkit-hyphenate-character
and -webkit-hyphens cases.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Validate values for the new properties.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added. Maps from a Hyphens value to an identifier.
(WebCore::CSSPrimitiveValue::operator Hyphens): Added. Maps from an identifier to a Hyphens value.

  • css/CSSPropertyNames.in: Added -webkit-hyphenate-character and -webkit-hyphens.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Apply the new properties to the RenderStyle.

  • css/CSSValueKeywords.in:
  • platform/mac/WebCoreSystemInterface.h: Added wkGetHyphenationLocationBeforeIndex.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • platform/text/CharacterNames.h: Added the hyphen character.
  • platform/text/Hyphenation.cpp: Added.

(WebCore::lastHyphenLocation): Added this default implementation for platforms that do not implement
hyphenation yet. It calls notImplemented() and returns 0.

  • platform/text/Hyphenation.h: Added.
  • platform/text/cf/HyphenationCF.cpp: Added.

(WebCore::lastHyphenLocation): Returns the last hyphenation location occurring in the given string before
the given index. Uses the current search locale (which is based on the top language preference of the user)
for hyphenation.

  • platform/text/mac/HyphenationMac.mm: Added.

(WebCore::lastHyphenLocation): Returns the last hyphenation location occurring in the given string before
the given index. Returns 0 if the current search locale is not "en", because the platform only knows how to
hyphenate English.

  • rendering/BidiRun.h:

(WebCore::BidiRun::BidiRun): Added a boolean member, m_hasHyphen, and initialized it to false in the constructor.

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox): Renamed m_hasEllipsisBox to m_hasEllipsisBoxOrHyphen, because this bit is now
shared by two subclass: RootInlineBox uses it for hasEllipsisBox(), while InlineTextBox uses it for hasHyphen().

  • rendering/InlineTextBox.cpp:

(WebCore::adjustCharactersAndLengthForHyphen): Added this helper function to get the hyphen string from the style
and return a UChar* and length for the concatenation of the given text with the hyphen string.
(WebCore::InlineTextBox::selectionRect): If the selected range touches the end and the box has a hyphen,
compute the width of the text with the hyphen string concatenated to it.
(WebCore::InlineTextBox::paint): If the box has a hyphen, draw the text with the hyphen string concatenated to it.
(WebCore::InlineTextBox::paintSelection): Similarly concatenate the hyphen string.

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::hasHyphen): Added this accessor.
(WebCore::InlineTextBox::setHasHyphen): Ditto.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::constructLine): Copy the m_hasHyphen flag from the run to its text box.
(WebCore::RenderBlock::computeHorizontalPositionsForLine): Add the width of the hyphen string when computing the
width of a box that has a hyphen.
(WebCore::RenderBlock::layoutInlineChildren): If the line was hyphenated, set the m_hasHyphen flag on the
logically last run.
(WebCore::tryHyphenating): Added this helper function which checks if a piece of text that does not fit on the
line could be hyphenated such that the part before the hyphen, including the hyphen, would fit. Given the amount
of space remaining on the line, it finds the longest prefix that can fit in the remaining space (which leaving room for
the hyphen), and then checks for a hyphenation location within that prefix.
(WebCore::RenderBlock::findNextLineBreak): In the 'hyphens: none' case, prevent line breaks at soft hyphens.
In the 'hyphens: auto' case, try hyphenating when a word will not fit in the remaining space on the line.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::detachEllipsisBox): Changed to use hasEllipsisBox() and setHasEllipsisBox().
(WebCore::RootInlineBox::clearTruncation): Ditto.
(WebCore::RootInlineBox::placeEllipsis): Ditto.
(WebCore::RootInlineBox::paintEllipsisBox): Ditto.
(WebCore::RootInlineBox::nodeAtPoint): Ditto.
(WebCore::RootInlineBox::ellipsisBox): Ditto.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasEllipsisBox): Added this accessor.
(WebCore::RootInlineBox::setHasEllipsisBox): Ditto.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Return a layout hint if the hyphens setting or hyphenate-character differs.
(WebCore::RenderStyle::hyphenString): Added. For hyphenate-character: auto, returns the hyphen character.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphens): Added this accessor.
(WebCore::InheritedFlags::hyphenateCharacter): Ditto.
(WebCore::InheritedFlags::setHyphens): Ditto.
(WebCore::InheritedFlags::setHyphenateCharacter): Ditto.
(WebCore::InheritedFlags::initialHyphens): Added. Returns HyphensManual.
(WebCore::InheritedFlags::initialHyphenateCharacter): Added. Returns the null string, corresponding to
a value of 'auto'.

  • rendering/style/RenderStyleConstants.h:

Added a Hyphens enum.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize and copy the new members.
(WebCore::StyleRareInheritedData::operator==): Compare the new members.

  • rendering/style/StyleRareInheritedData.h: Added two new members: hyphens and hyphenateCharacter.

WebKit/mac: WebKit part of implementing the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkGetHyphenationLocationBeforeIndex.

WebKitLibraries: WebKitSystemInterface part of CSS3: Implement the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • WebKitSystemInterface.h: Added WKGetHyphenationLocationBeforeIndex().
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

LayoutTests: Added tests for the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • fast/text/hyphenate-character.html: Added.
  • fast/text/hyphens.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/fast/text/hyphenate-character-expected.checksum: Added.
  • platform/mac/fast/text/hyphenate-character-expected.png: Added.
  • platform/mac/fast/text/hyphenate-character-expected.txt: Added.
  • platform/mac/fast/text/hyphens-expected.checksum: Added.
  • platform/mac/fast/text/hyphens-expected.png: Added.
  • platform/mac/fast/text/hyphens-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:
09:39 Changeset [61547] by dglazkov@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Enable EVENTSOURCE, FILE_WRITER, and IMAGE_RESIZER
https://bugs.webkit.org/show_bug.cgi?id=40905

EVENTSOURCE: It is already enabled in Chromium browser. This fixes
some tests with Chromium DRT.

FILE_WRITER and IMAGE_RESIZER: Enable experimental features in
order to test them before enabling them in Chromium browser.

  • features.gypi:
09:36 Changeset [61546] by dglazkov@chromium.org
  • 7 edits in trunk/WebCore

2010-06-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Plumb FormSubmission through to ScheduledFormSubmission.
https://bugs.webkit.org/show_bug.cgi?id=40137

No behavior change, covered by existing tests.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission): Moved creation of action URL

instance here from FrameLoader::submit, because it makes more sense here,
also added a FIXME to investigate existing code later.

  • loader/FormSubmission.cpp: (WebCore::FormSubmission::FormSubmission): Changed action to be a KURL, not a String. (WebCore::FormSubmission::create): Ditto. (WebCore::FormSubmission::populateFrameLoadRequest): Added, moving the logic from

FrameLoader::submit closer to the data.

  • loader/FormSubmission.h: (WebCore::FormSubmission::action): Changed type to KURL. (WebCore::FormSubmission::clearTarget): Added. (WebCore::FormSubmission::referrer): Added. (WebCore::FormSubmission::setReferrer): Added. (WebCore::FormSubmission::origin): Added. (WebCore::FormSubmission::setOrigin): Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Cleaned up to make it more about decision-making,

not data manipulation.

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): Changed to accept FormSubmission as argument. (WebCore::ScheduledFormSubmission::fire): Changed to use FormSubmission. (WebCore::RedirectScheduler::scheduleFormSubmission): Removed assert that no longer makes sense,

changed to use FormSubmission.

  • loader/RedirectScheduler.h: Updated ScheduledFormSubmission decl to hold FormSubmission ref.
09:02 Changeset [61545] by eric@webkit.org
  • 19 edits in trunk

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • configure.ac:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

No new tests are needed, because there is no new functionality.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • features.gypi:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Scripts/build-webkit:
08:50 Changeset [61544] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Use global new/delete operator overloading with USE_SYSTEM_MALLOC=1
https://bugs.webkit.org/show_bug.cgi?id=40653

Currently, other ports do not use global new/delete operator overloading
when USE_SYSTEM_MALLOC=1. Brew MP uses system malloc, but it needs to enable
"global fastMalloc new" because the default new/delete causes crash on device.
We need to replace them with Brew MP's MALLOC/FREE.

  • wtf/FastMalloc.h:
08:50 Changeset [61543] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Fix MSVC build.

Reviewed by nobody, build fix.

The max macro was replacing the max function used in StringImpl.h
when compiling moc_NotificationPresenterClientQt.cpp.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:
07:50 Changeset [61542] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-06-21 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Delete DOM storage databases when they are empty.
https://bugs.webkit.org/show_bug.cgi?id=40767

Even if a page clears its local storage, the database file for it stays around,
and there is currently no mechanism that deletes them.

After doing the "final sync" of a storage area, the StorageAreaSyncMaster should
see if the database is empty, and in that case delete it.

Tests:

manual-tests/localstorage-empty-database.html

  • manual-tests/localstorage-empty-database.html: Added link to clear local storage for testing that the file is removed.
  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask): Added local storage task type DeleteEmptyDatabase. (WebCore::LocalStorageTask::performTask): Ditto.
  • storage/LocalStorageTask.h: (WebCore::LocalStorageTask::): Ditto. (WebCore::LocalStorageTask::createDeleteEmptyDatabase): Ditto.
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::scheduleFinalSync): When scheduling final sync, also schedule DeleteEmptyDatabase. (WebCore::StorageAreaSync::sync): Return early if final sync has nothing to sync. (WebCore::StorageAreaSync::deleteEmptyDatabase): Added function to check if a database is empty and in that case delete it.
  • storage/StorageAreaSync.h: Ditto.
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase): Added function for scheduling DeleteEmptyDatabase task.
  • storage/StorageSyncManager.h: Ditto.
07:36 Changeset [61541] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Initialization for http/tests/loading/
https://bugs.webkit.org/show_bug.cgi?id=40902

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
07:08 Changeset [61540] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-21 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Avoid unnecessary image conversion in RGBA32Buffer::zeroFill()
https://bugs.webkit.org/show_bug.cgi?id=40910

  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::zeroFill):
06:37 Changeset [61539] by mnaganov@chromium.org
  • 6 edits
    1 add in trunk/WebKit/chromium

2010-06-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by NOBODY (OOPS!).

[Chromium] Remove usage of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.

Also, move WebDevToolsMessageTransport to its own header file.

https://bugs.webkit.org/show_bug.cgi?id=40913

  • DEPS:
  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsMessageTransport.h: Added. (WebKit::WebDevToolsMessageTransport::~WebDevToolsMessageTransport):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::):
05:14 Changeset [61538] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-06-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
04:43 Changeset [61537] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Unreviewed build fix.

[Qt] Fix package builds

Don't use rpath unless we're building inside the trunk.

  • declarative/declarative.pro:
02:40 Changeset [61536] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Work around a build problem with libjscore on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=40840

Reviewed by Simon Hausmann.

Sbsv2 sometimes have problems with debug/release configuration
determination causing QtWebKit in release to try linking with the debug
JavaScriptCore static library. This patch limit the jscore/jscored
r58306 fix necessary for mac builds only to the mac platform to prevent the
different name problem.

The real fix would be to fix qmake or the toolchain, this patch might
help meanwhile.

02:33 Changeset [61535] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKitTools

Adding myself to the committers list.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
01:30 Changeset [61534] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-21 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Decode images directly to QPixmap
https://bugs.webkit.org/show_bug.cgi?id=40797

Decode images to QPixmap directly instead of QImage when possible.
RGBA32Buffer transforms the pixmap back to image if
necessary.

This improve the performance with certain graphic system, and
can reduce memory usage.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::internalHandleCurrentImage):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::setPixmap):
01:10 Changeset [61533] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-21 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

Buildfix after r61338.
https://bugs.webkit.org/show_bug.cgi?id=40888

roundUpAllocationSize is needed in RegisterFile.h.

  • jit/ExecutableAllocator.h:
00:59 Changeset [61532] by dumi@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing expectations.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
00:10 Changeset [61531] by dumi@chromium.org
  • 32 edits
    2 adds in trunk

Adding the SQLException class which will be used to report sync DB errors.
https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Adam Barth.

WebCore:

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • bindings/v8/V8Proxy.h:
  • dom/ExceptionCode.cpp:

(WebCore::):
(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:

(WebCore::):

  • page/DOMWindow.idl:
  • storage/SQLException.h: Added.

(WebCore::SQLException::create):
(WebCore::SQLException::):
(WebCore::SQLException::SQLException):

  • storage/SQLException.idl: Added.

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
00:06 Changeset [61530] by eric@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

2010-06-20 Hayato Ito <hayato@chromium.org>

Reviewed by Kent Tamura.

Add tests for CSS3 Paged Media to make sure page breaks should happen at right places.
Two tests (allowed-page-break and page-break-margin-collapsed) are expected to fail
due to lack of support.

https://bugs.webkit.org/show_bug.cgi?id=40770

  • printing/allowed-page-breaks-expected.txt: Added.
  • printing/allowed-page-breaks.html: Added.
  • printing/no-content-empty-pages-expected.txt: Added.
  • printing/no-content-empty-pages.html: Added.
  • printing/page-break-display-none-expected.txt: Added.
  • printing/page-break-display-none.html: Added.
  • printing/page-break-margin-collapsed-expected.txt: Added.
  • printing/page-break-margin-collapsed.html: Added.
  • printing/script-tests/allowed-page-breaks.js: Added. (test):
  • printing/script-tests/no-content-empty-pages.js: Added. (test):
  • printing/script-tests/page-break-display-none.js: Added. (test):
  • printing/script-tests/page-break-margin-collapsed.js: Added. (test):

06/20/10:

23:44 Changeset [61529] by yurys@chromium.org
  • 5 edits in trunk

2010-06-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if browser exposes
v8 debugging protocol.
https://bugs.webkit.org/show_bug.cgi?id=40844

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::setEnabled): (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
  • bindings/v8/ScriptDebugServer.h:

2010-06-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if browser exposes
v8 debugging protocol.

  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
22:28 Changeset [61528] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break for r61527
https://bugs.webkit.org/post_bug.cgi

  • CMakeLists.txt: Add loader/FormSubmission.cpp
21:38 Changeset [61527] by tkent@chromium.org
  • 5 edits in trunk/WebKitTools

2010-06-20 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add --allow-external-pages option
https://bugs.webkit.org/show_bug.cgi?id=40762

Add --allow-external-pages introduced by Chromium r45403.
http://src.chromium.org/viewvc/chrome?view=rev&revision=45403

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::allowExternalPages): (TestShell::setAllowExternalPages):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willSendRequest):
20:35 Changeset [61526] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • Plugins/WebNetscapePluginPackage.mm:
20:20 Changeset [61525] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of the old MIMETypes getter method
https://bugs.webkit.org/show_bug.cgi?id=40898

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:WebCore::]): (-[WebBasePluginPackage MIMETypeForExtension:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
19:58 Changeset [61524] by andersca@apple.com
  • 5 edits in trunk

Remove bogus const qualifiers.

Reviewed by Dan Bernstein.

WebCore:

  • platform/mac/PasteboardHelper.h:

WebKit/mac:

  • WebCoreSupport/WebPasteboardHelper.h:
  • WebCoreSupport/WebPasteboardHelper.mm:

(WebPasteboardHelper::urlFromPasteboard):
(WebPasteboardHelper::plainTextFromPasteboard):
(WebPasteboardHelper::fragmentFromPasteboard):

19:34 Changeset [61523] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of the extensionToMIME mapping in WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40897

Instead of using the extensionToMIME mutable dictionary, use the MIME types vector.
While this makes lookup of MIME types based on extensions linear instead of constant,
the number of extensions per plug-in is too small for it to matter.

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
19:13 Changeset [61522] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add a MimeClassInfo Vector to WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40896

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage WebCore::]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
19:12 Changeset [61521] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

Buildfix for NotificationCenter.h.
https://bugs.webkit.org/show_bug.cgi?id=40890

ScriptExecutionContext::completeURL is used in header,
but ScriptExecutionContext.h wasn't included.

  • notifications/NotificationCenter.h:
18:38 Changeset [61520] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-20 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Update for other <meter> tests and flaky/slow tests
18:30 Changeset [61519] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Move the NSBundle ivar to WebPluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40894

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _initWithPath:]):
  • Plugins/WebPluginPackage.h:
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage dealloc]): (-[WebPluginPackage viewFactory]): (-[WebPluginPackage load]):
18:05 Changeset [61518] by eric@webkit.org
  • 10 edits
    4 adds in trunk

2010-06-20 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Test to make sure parsing of async attribute works for HTML script tags
and test to make sure that async is not parsed for SVG script tags.
https://bugs.webkit.org/show_bug.cgi?id=39026

  • fast/dom/HTMLScriptElement/script-async-attr-expected.txt: Added.
  • fast/dom/HTMLScriptElement/script-async-attr.html: Added.
  • svg/dom/SVGScriptElement/script-async-attr-expected.txt: Added.
  • svg/dom/SVGScriptElement/script-async-attr.svg: Added.

2010-06-20 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Recognize async attribute on HTML script tags.
https://bugs.webkit.org/show_bug.cgi?id=39026

This does not implement async behavior, it only parses the async
attribute for HTML script tags. SVG script tags continue to not
support the async attribute.

Tests: fast/dom/HTMLScriptElement/script-async-attr.html

svg/dom/SVGScriptElement/script-async-attr.svg

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::isAsynchronous): (WebCore::ScriptElementData::isDeferred):
  • dom/ScriptElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::async): (WebCore::HTMLScriptElement::setAsync): (WebCore::HTMLScriptElement::defer): (WebCore::HTMLScriptElement::asyncAttributeValue): (WebCore::HTMLScriptElement::deferAttributeValue):
  • html/HTMLScriptElement.h:
  • html/HTMLScriptElement.idl:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::asyncAttributeValue): (WebCore::SVGScriptElement::deferAttributeValue):
  • svg/SVGScriptElement.h:
17:44 Changeset [61517] by tony@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-06-20 Tony Chang <tony@chromium.org>

Not reviewed, just cleaning up svn.

Removing platform/mac-snowleopard/editing since it's empty. The test
results were moved in r60693.

  • platform/mac-snowleopard/editing: Removed.
  • platform/mac-snowleopard/editing/spelling: Removed.
16:15 Changeset [61516] by jberlin@webkit.org
  • 4 edits in trunk/WebKit2

2010-06-20 Jessie Berlin <jberlin@apple.com>

Reviewed by Dan Bernstein.

Add #if USE(PLATFORM_STRATEGIES) where WebPlatformStrategies is being used.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): Only initialize the web platform strategies if PLATFORM_STRATEGIES is being used.
15:51 Changeset [61515] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Adam Barth.

Sheriffbot: Should allow "r" in SVN_REVISION
https://bugs.webkit.org/show_bug.cgi?id=40889

  • Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
15:32 Changeset [61514] by eric@webkit.org
  • 6 edits
    1 add in trunk/WebCore

2010-06-20 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Joseph Pecoraro.

Web Inspector: Auto-completion for CSS property names in Styles pane
https://bugs.webkit.org/show_bug.cgi?id=17374

Added autocompletion for CSS properties. A suggestion for a property
shows when you type. You can also cycle through known property names
using the Up and Down arrow keys.

  • WebCore.gypi:
  • inspector/front-end/CSSCompletions.js: Added. (WebInspector.CSSCompletions): (WebInspector.CSSCompletions.startsWith): (WebInspector.CSSCompletions.firstStartsWith): (WebInspector.CSSCompletions._firstIndexOfPrefix): (WebInspector.CSSCompletions.next): (WebInspector.CSSCompletions.previous): (WebInspector.CSSCompletions._closest):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js: (Text.prototype.select): ():
14:30 Changeset [61513] by joepeck@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Dimitri Glazkov.

Python Tests Fail after r61508
https://bugs.webkit.org/show_bug.cgi?id=40891

Test's regex list needed to be updated to match the new
regex list in the source code. Added new bots to the
example_buildbots list.

Regex list fixed in r61512. Updated bot list.

  • Scripts/webkitpy/common/net/buildbot_unittest.py:
14:14 Changeset [61512] by dglazkov@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-20 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.

  • Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
14:00 Changeset [61511] by dglazkov@chromium.org
  • 11 edits
    2 adds in trunk/WebCore

2010-06-14 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Introduce FormSubmission, the structure representing a form submission.
https://bugs.webkit.org/show_bug.cgi?id=40084

No change in functionality, covered by existing tests.

  • GNUmakefile.am: Added FormSubmission.h/cpp.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission): Renamed prepareFormData to prepareFormSubmission,

added code for populating a FormSubmission instance, moved the loop of accumulating text input
values into this functions (it belongs here logically).

(WebCore::HTMLFormElement::submit): Modified to use prepareFormSubmission.

  • html/HTMLFormElement.h:
  • loader/FormSubmission.cpp: Added.
  • loader/FormSubmission.h: Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Modified to use FormSubmission. Stopped plumbing further to keep

the patch size down.

  • loader/FrameLoader.h: Modified submitForm signature.
13:53 Changeset [61510] by andersca@apple.com
  • 9 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove -[WebBasePluginPackage bundle]
https://bugs.webkit.org/show_bug.cgi?id=40892

Add -[WebBasePluginPackage bundleIdentifier] and switch clients over to it.


Move the supportsSnapshotting method over to the plug-in package.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebBaseNetscapePluginView supportsSnapshotting]):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage isQuickTimePlugIn]): (-[WebBasePluginPackage isJavaPlugIn]): (-[WebBasePluginPackage WebCore::]): Call bundleIdentifier directly instead of asking the bundle
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage supportsSnapshotting]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setAttributeKeys:andValues:]): (-[WebNetscapePluginView _createPlugin]):
  • Plugins/WebPluginDatabase.mm: (checkCandidate):
13:27 Changeset [61509] by andersca@apple.com
  • 7 edits in trunk/WebKit/mac

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
https://bugs.webkit.org/show_bug.cgi?id=40869


Re-land r61459, with extra null-checks in WebFrameLoaderClient.

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
11:58 Changeset [61508] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/net/buildbot.py

2010-06-20 William Siegrist <wsiegrist@apple.com>

Unreviewed. Make core builder regexp more specific so new Chromium test slaves do not get core builder status.

11:55 Changeset [61507] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Unreviewed rollout r61506, because it made 1 test crash.

Causes crash. Will approach the solution in a different way.

10:02 Changeset [61506] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Should Autocomplete Style Properties
https://bugs.webkit.org/show_bug.cgi?id=38448

This Autocompletes style properties when in the console.

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
05:54 Changeset [61505] by robert@webkit.org
  • 5 edits in trunk

2010-06-20 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • platform/qt/Skipped:

2010-06-20 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
04:46 Changeset [61504] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-06-20 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

The QWebHistory regression fix.

After change r51629 and r61207 QWebHistory's function back(),
forward(), goToItem() got broken.

Use page->goToItem() instead of direct actions on the BackForwardList.

[Qt] REGRESSION(r61207): qwebhistory unit test hangs
https://bugs.webkit.org/show_bug.cgi?id=40672

  • Api/qwebhistory.cpp: (QWebHistory::back): (QWebHistory::forward): (QWebHistory::goToItem):
  • tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::init): (tst_QWebHistory::back): (tst_QWebHistory::forward):

06/19/10:

20:37 Changeset [61503] by jschuh@chromium.org
  • 2 edits in trunk/WebKitTools

2010-06-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
18:03 Changeset [61502] by eric@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-06-19 Hayato Ito <hayato@chromium.org>

Reviewed by Adam Barth.

Add tests for CSS 'orphans' and 'widows' properties.
All tests are expected to fail due to lack of implementations.

https://bugs.webkit.org/show_bug.cgi?id=40821

  • printing/page-break-orphans-and-widows-expected.txt: Added.
  • printing/page-break-orphans-and-widows.html: Added.
  • printing/page-break-orphans-expected.txt: Added.
  • printing/page-break-orphans.html: Added.
  • printing/page-break-widows-expected.txt: Added.
  • printing/page-break-widows.html: Added.
  • printing/script-tests/page-break-orphans-and-widows.js: Added. (test):
  • printing/script-tests/page-break-orphans.js: Added. (test):
  • printing/script-tests/page-break-widows.js: Added. (test):
17:50 Changeset [61501] by eric@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-06-19 Hayato Ito <hayato@chromium.org>

Reviewed by Adam Barth.

Add tests for 'page-break-{before,after}: avoid'.
All tests are expected to fail due to lack of implementations.

https://bugs.webkit.org/show_bug.cgi?id=40814

  • printing/page-break-after-avoid-expected.txt: Added.
  • printing/page-break-after-avoid.html: Added.
  • printing/page-break-avoid-expected.txt: Added.
  • printing/page-break-avoid.html: Added.
  • printing/page-break-before-avoid-expected.txt: Added.
  • printing/page-break-before-avoid.html: Added.
  • printing/script-tests/page-break-after-avoid.js: Added. (test):
  • printing/script-tests/page-break-avoid.js: Added. (test):
  • printing/script-tests/page-break-before-avoid.js: Added. (test):
17:39 Changeset [61500] by weinig@apple.com
  • 23 edits in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
Add ability to have a WebProcess per WebContext.

Reviewed by Anders Carlsson.

WebKit2:

  • Move to a one-to-one correspondence of WebContexts to WebProcessProxies.
  • Add explicit shared contexts for general use.
  • Only non-shared contexts can use injected bundles.
  • UIProcess/API/C/WKContext.cpp:

(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):
(WKContextGetSharedProcessContext):
(WKContextGetSharedThreadContext):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKContextPrivate.h:

Change API for WKContext to no longer take a WKProcessModel type and instead
have explicit Create/Get functions for the different kind of contexts. Added
two shared contexts, one threaded, one process, and made the threaded on private
for now.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:]):
Make WKViews that don't have an explicit context use the shared process
context by default.

  • UIProcess/Launcher/WebProcessLauncher.h:
  • UIProcess/Launcher/mac/WebProcessLauncher.mm:

(WebKit::launchWebProcess):

  • UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::launchWebProcess):
Use a boolean argument to note whether we are using a thread or a process
instead of using the process model enum.

  • UIProcess/ProcessModel.h:

(WebKit::):
Convert to using explicit Shared modifier for shared contexts.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedProcessContext):
(WebKit::WebContext::sharedThreadContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::reviveIfNecessary):

  • UIProcess/WebContext.h:

(WebKit::WebContext::create):
(WebKit::WebContext::process):

  • UIProcess/WebPageNamespace.cpp:

(WebKit::WebPageNamespace::createWebPage):
(WebKit::WebPageNamespace::preferencesDidChange):
(WebKit::WebPageNamespace::getStatistics):

  • UIProcess/WebPageNamespace.h:

(WebKit::WebPageNamespace::process):
(WebKit::WebPageNamespace::reviveIfNecessary):
Move WebProcessProxy creation logic up into WebContext.

  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::getWebProcess):
(WebKit::WebProcessManager::processDidClose):

  • UIProcess/WebProcessManager.h:

Keep a map of WebContexts to WebProcessProxies in addition to the two
shared processes.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::didClose):

  • UIProcess/WebProcessProxy.h:

Store a WebContext instead of the process model.

  • mac/WebKit2.exp:

Add new functions.

WebKitTools:

Move to use new shared contexts API.

  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate getCurrentPageNamespace]):
(-[BrowserAppDelegate validateMenuItem:]):
(-[BrowserAppDelegate _setProcessModel:]):
(-[BrowserAppDelegate setSharedProcessProcessModel:]):
(-[BrowserAppDelegate setSharedThreadProcessModel:]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

17:38 Changeset [61499] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

When V8 ScriptData caching was originally submitted it causes crashes
in external scripts with high-byte characters. This new test crashes on
the original code, but now passes.

  • fast/js/parser-high-byte-character-expected.txt: Added.
  • fast/js/parser-high-byte-character.html: Added.
  • fast/js/script-tests/parser-high-byte-character.js: Added. (runTest):

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark showed a ~7% improvement when this was
originally submitted (before it had to be rolled back).

Test: fast/js/parser-high-byte-character.html

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
14:48 Changeset [61498] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-19 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt: Tuned expectations according to the bot result runs.
13:39 Changeset [61497] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Add LayoutTest to ensure resources within <noscript> are not preloaded
https://bugs.webkit.org/show_bug.cgi?id=40849

  • fast/preloader/noscript-expected.txt: Added.
  • fast/preloader/noscript.html: Added.
  • fast/preloader/resources/noscript-image1.png: Copied from BugsSite/data/mail.
  • fast/preloader/resources/noscript-image2.png: Copied from BugsSite/data/mail.
10:24 Changeset [61496] by eric@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

2010-06-19 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port SocketStream
https://bugs.webkit.org/show_bug.cgi?id=39671

Port SocketStream with BREW MP's ISocket interface.

  • platform/network/brew/SocketStreamError.h: Added. (WebCore::SocketStreamError::SocketStreamError):
  • platform/network/brew/SocketStreamHandle.h: Added. (WebCore::SocketStreamHandle::create):
  • platform/network/brew/SocketStreamHandleBrew.cpp: Added. (WebCore::socketStreamConnectCallback): (WebCore::getHostByNameCallback): (WebCore::socketReadableCallback): (WebCore::networkManager): (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::~SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::socketConnected): (WebCore::SocketStreamHandlePrivate::socketReadyRead): (WebCore::SocketStreamHandlePrivate::connect): (WebCore::SocketStreamHandlePrivate::send): (WebCore::SocketStreamHandlePrivate::close): (WebCore::SocketStreamHandlePrivate::socketClosed): (WebCore::SocketStreamHandlePrivate::socketError): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose): (WebCore::SocketStreamHandle::didReceiveAuthenticationChallenge): (WebCore::SocketStreamHandle::receivedCredential): (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): (WebCore::SocketStreamHandle::receivedCancellation):
  • platform/network/brew/SocketStreamHandlePrivate.h: Added.
10:11 Changeset [61495] by eric@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-06-19 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Adding a < operator to WebURLs so they can be used in std::maps.
https://bugs.webkit.org/show_bug.cgi?id=40632

  • public/WebCString.h: (WebKit::operator<):
  • public/WebURL.h: (WebKit::operator<):
  • src/WebCString.cpp: (WebKit::WebCString::compare):
09:47 Changeset [61494] by eric@webkit.org
  • 6 edits in trunk

2010-06-19 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: subtitleElement.textContent is always empty. Use subtitleAsText method instead.
https://bugs.webkit.org/show_bug.cgi?id=40420

  • inspector/elements-tests.js: (frontend_getSelectedElementStyles):

2010-06-19 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: Prevent from copying "filename.css" in Styles pane
https://bugs.webkit.org/show_bug.cgi?id=40420

  • inspector/front-end/Section.js: (WebInspector.Section.prototype.set subtitle): (WebInspector.Section.prototype.get subtitleAsText):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
  • inspector/front-end/inspector.css: (.styles-section .subtitle::before, .styles-section .subtitle a::before):
09:35 Changeset [61493] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 Alex Milowski <alex@milowski.com>

Reviewed by Darin Adler.

A fix for a change in https://bugs.webkit.org/show_bug.cgi?id=39941
that caused a compile error in MathML.
https://bugs.webkit.org/show_bug.cgi?id=40827

  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement):
09:21 Changeset [61492] by eric@webkit.org
  • 6 edits
    3 copies
    3 adds in trunk/WebCore

2010-06-19 Kartikaya Gupta <kagupta@rim.com>

Reviewed by Nikolas Zimmermann.

CPP bindings missing some APIs
https://bugs.webkit.org/show_bug.cgi?id=40570

Add missing C++ DOM API bindings. Specifically:

  • NodeFilter callback support
  • Missing custom method implementations in HTMLCollection and HTMLOptionsCollection
  • Missing EventTarget static type-determination methods
  • Fix CPP binding generator to not generate d-ptrs for classes that extend EventTarget and just use the parent's d-ptr instead
  • Switch binding generator to use DOMWindow instead of AbstractView so that necessary W3C-defined methods (e.g. getComputedStyle) are accessible.
  • bindings/cpp/WebDOMDOMWindowCustom.cpp: Added. (WebDOMDOMWindow::addEventListener): (WebDOMDOMWindow::removeEventListener):
  • bindings/cpp/WebDOMEventTarget.cpp: (toWebKit):
  • bindings/cpp/WebDOMEventTarget.h:
  • bindings/cpp/WebDOMHTMLCollectionCustom.cpp: Added. (WebDOMHTMLCollection::item): (WebDOMHTMLCollection::namedItem):
  • bindings/cpp/WebDOMHTMLOptionsCollectionCustom.cpp: Added. (WebDOMHTMLOptionsCollection::length): (WebDOMHTMLOptionsCollection::setLength):
  • bindings/cpp/WebDOMNodeFilterCustom.cpp: Added. (WebDOMNodeFilter::acceptNode): (toWebKit):
  • bindings/cpp/WebNativeNodeFilterCondition.cpp: Added. (WebNativeNodeFilterCondition::WebNativeNodeFilterCondition): (WebNativeNodeFilterCondition::~WebNativeNodeFilterCondition): (WebNativeNodeFilterCondition::acceptNode):
  • bindings/cpp/WebNativeNodeFilterCondition.h: Added. (WebNativeNodeFilterCondition::create):
  • bindings/scripts/CodeGeneratorCPP.pm:
  • dom/NodeFilter.idl:
  • page/DOMWindow.idl:
08:22 Changeset [61491] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-19 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update

  • platform/chromium/test_expectations.txt: Added a flaky crash.
08:13 Changeset [61490] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed. Build fix for r61488.

  • features.gypi: Define use_accelerated_compositing.
08:05 Changeset [61489] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Include <string.h> in StringExtras.h
https://bugs.webkit.org/show_bug.cgi?id=40808

Without string.h, RVCT 2.2 can't compile StringExtras.h.
It can't find strlen and strncmp.

  • wtf/StringExtras.h:
07:53 Changeset [61488] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Adding a conditional gyp dependency for the WebCore target to
the gles2_c_lib which is required by the gpu compositor. The dependency will
only kick in if the accelerated_compositing path is enabled.
https://bugs.webkit.org/show_bug.cgi?id=40801

  • WebCore.gyp/WebCore.gyp:
07:19 Changeset [61487] by eric@webkit.org
  • 10 edits in trunk

2010-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin's multi-select does not take OptGroup into account
https://bugs.webkit.org/show_bug.cgi?id=40718

In multi-select elements, optgroup elements are counted in the index calculation,
but in single-select they are not. Keep the same logic even when NO_LISTBOX_RENDERING
is enabled.
Added tests to the existing manual test, as testing this requires a special build, in which
NO_LISTBOX_RENDERING is enabled.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxSelectItem):
  • manual-tests/no-listbox-rendering.html:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listBoxSelectItem):

2010-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin's multi-select does not take OptGroup into account
https://bugs.webkit.org/show_bug.cgi?id=40718

Make sure that SelectData is valid throughout the lifetime of the dialog.
This is mostly important for the Orbt based plugin.
Added virtual desctructors where they were missing.

  • Api/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::~SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::show):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp:
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData):
07:07 Changeset [61486] by eric@webkit.org
  • 7 edits in trunk

2010-06-19 Thomas Van Lenten <thomasvl@chromium.org>

Reviewed by David Levin.

Warnings from -Wextra in a Chromium Mac build

  1. checks of unsigned >= 0
  2. enumeral and non-enumeral type in conditional expression
  3. copy ctors that don't call the super copy ctor or ctor No functionality change so no new tests.

https://bugs.webkit.org/show_bug.cgi?id=40791

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::ChromiumDataObject):
  • platform/chromium/ThemeChromiumMac.mm: (WebCore::updateStates):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::updateActiveState):

2010-06-19 Thomas Van Lenten <thomasvl@chromium.org>

Reviewed by David Levin.

Warnings from -Wextra in a Chromium Mac build

  1. checks of unsigned >= 0
  2. enumeral and non-enumeral type in conditional expression
  3. copy ctors that don't call the super copy ctor or ctor

https://bugs.webkit.org/show_bug.cgi?id=40791

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getSuggestion): (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged):
  • src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::getSuggestion): (WebKit::AutocompletePopupMenuClient::removeSuggestionAtIndex):
06:54 Changeset [61485] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 Ben Murdoch <benm@google.com>

Reviewed by Pavel Feldman.

Fix build break with inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=40790

Replace a #include with a forward declaration.

Fixing a build break so no new tests required.

  • inspector/InspectorController.h: Forward declare InspectorValue

rather than #including its header which has its content guarded
out.

06:32 Changeset [61484] by eric@webkit.org
  • 13 edits
    5 copies in trunk

2010-06-19 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Fisher.

[chromium]Refactor input method related APIs.
https://bugs.webkit.org/show_bug.cgi?id=40608

No new tests are needed, because there is no new functionality.

  • page/FocusController.cpp: (WebCore::FocusController::setFocusedNode):

2010-06-19 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Fisher.

[chromium]Refactor input method related APIs.
https://bugs.webkit.org/show_bug.cgi?id=40608

  • WebKit.gyp:
  • public/WebCompositionCommand.h:
  • public/WebCompositionUnderline.h: Added. (WebKit::WebCompositionUnderline::WebCompositionUnderline):
  • public/WebTextInputType.h: Added. (WebKit::):
  • public/WebViewClient.h:
  • public/WebWidget.h:
  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::resetInputMethod):
  • src/CompositionUnderlineBuilder.h: Added. (WebKit::CompositionUnderlineBuilder::CompositionUnderlineBuilder):
  • src/CompositionUnderlineVectorBuilder.cpp: Added. (WebKit::CompositionUnderlineVectorBuilder::CompositionUnderlineVectorBuilder):
  • src/CompositionUnderlineVectorBuilder.h: Added.
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::setInputMethodState):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::setComposition): (WebKit::WebPopupMenuImpl::confirmComposition): (WebKit::WebPopupMenuImpl::textInputType): (WebKit::WebPopupMenuImpl::caretOrSelectionBounds):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleCompositionEvent): (WebKit::WebViewImpl::setComposition): (WebKit::WebViewImpl::confirmComposition): (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds):
  • src/WebViewImpl.h:
06:05 Changeset [61483] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-19 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

Modifying the WebMediaPlayer interface to be compatible with
a change in chrome.
This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
has been updated, so this commit should NOT break chromium anymore,
nor should it cause any test failures.
https://bugs.webkit.org/show_bug.cgi?id=39445

  • public/WebMediaPlayer.h: Changed buffered() to be non-const.
05:32 Changeset [61482] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-19 George Wright <gwright@rim.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=40720

Make setWapInputFormat() public again as CSSStyleSelector.cpp calls this when WCSS is enabled.

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::data):
05:31 Changeset [61481] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt:
    • progress-element.html is essentially flaky on Mac.
    • use-clipped-hit.svg passes recently.
04:58 Changeset [61480] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-19 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

Bridge documentation: some snippets have the wrong indentation
https://bugs.webkit.org/show_bug.cgi?id=40717

Fixed code snippets

  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction):
04:43 Changeset [61479] by tkent@chromium.org
  • 3 edits
    53 adds in trunk/LayoutTests

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add expectations for <meter> and <progress>.

  • platform/chromium-linux/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/test_expectations.txt:
04:02 Changeset [61478] by robert@webkit.org
  • 14 edits
    3 adds in trunk

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

This initial implementation passes 25 of the 27 tests in
http/tests/isolatedworld as well as four others that use the
call in LayoutTests.

Further work/investigation is required to support the two
remaining tests.

  • platform/qt/Skipped:

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

getOwnPropertyNames() crashes if PropertyNameArray is size 0. This change allows
http/tests/world-reuse.html and didClearWindowObject.html to fail instead of crash.

  • WebCore.pro: Add qwebscriptworld.*
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

  • Api/headers.pri:
  • Api/qwebframe.cpp: (QWebFrame::evaluateScriptInIsolatedWorld):
  • Api/qwebframe.h:
  • Api/qwebscriptworld.cpp: Added. (QWebScriptWorld::QWebScriptWorld): (QWebScriptWorld::world): (QWebScriptWorld::~QWebScriptWorld):
  • Api/qwebscriptworld.h: Added.
  • Api/qwebscriptworld_p.h: Added. (QWebScriptWorldPrivate::QWebScriptWorldPrivate): (QWebScriptWorldPrivate::~QWebScriptWorldPrivate):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
03:18 Changeset [61477] by tkent@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Rebaseline for tetDecoration.svg.

  • platform/chromium-linux/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
03:04 Changeset [61476] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-19 Olivier Goffart <olivier.goffart@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compilation in QWebPagePrivate::timerEvent with clang
https://bugs.webkit.org/show_bug.cgi?id=40714

QObject::timerEvent is protected and cannot be accessed by QWebPagePrivate
with clang

QWebPagePrivate is a friend of QWebPage and then should have access to
all protected members of parents of QWebPage, including QObject.
But the clang team do not want to conform to this aspect of the specification
because "It is either a drafting error or a horrible mistake."
See http://llvm.org/bugs/show_bug.cgi?id=6840

This change is better because QWebPage does not reimplement the timerEvent
(QWebPagePrivate::timerEvent is called from QWebPage::event)
So customers that would reimplement their own timerEvent
for their own timer now get a chance to catch them.

  • Api/qwebpage.cpp: (QWebPagePrivate::timerEvent):
02:45 Changeset [61475] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Don't use attribute((may_alias)) with the Intel compiler,
as it doesn't understand it.

  • wtf/Vector.h:
02:23 Changeset [61474] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix compilation with the Intel C++ compiler (11.1.072).

Like RVCT, label pointers must be void*, not const void*.

  • bytecode/Opcode.h:
02:09 Changeset [61473] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add the WTF_COMPILER_INTEL for when the Intel compiler is used
for building. Usually, the Intel compiler masquerades as
another compiler in the system and gets away with it, but some
times specific fixes are required (such as when using language
extensions).

  • wtf/Platform.h:
01:45 Changeset [61472] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-19 Mirko Damiani <mirko@develer.com>

Reviewed by Simon Hausmann.

[Qt] Avoid truncation of zoom factor in QWebFrame's print function.
https://bugs.webkit.org/show_bug.cgi?id=40662

The zoom factor is a qreal number but its value is truncated to an
integer. So a cast to qreal is needed to avoid this issue.

  • Api/qwebframe.cpp: (QWebFrame::print):
01:31 Changeset [61471] by eric@webkit.org
  • 5 edits in trunk

2010-06-19 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/get-active-test.html failed in Chrome Mac
https://bugs.webkit.org/show_bug.cgi?id=40496

  • fast/canvas/webgl/get-active-test-expected.txt: Test of two contexts and two programs, also test the uniform array name ends with "[0]".
  • fast/canvas/webgl/script-tests/get-active-test.js: Ditto.

2010-06-19 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/get-active-test.html failed in Chrome Mac
https://bugs.webkit.org/show_bug.cgi?id=40496

  • src/WebGraphicsContext3DDefaultImpl.cpp: Call makeContextCurrent(). (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels):
00:26 Changeset [61470] by eric@webkit.org
  • 6 edits in trunk/WebCore

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Some very minor cleanups for HTML5 Parser
https://bugs.webkit.org/show_bug.cgi?id=40638

No new tests because no new functionality.

  • html/HTML5DocumentParser.cpp: (WebCore::): Make ctor explicit.
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::InsertionPointRecord::InsertionPointRecord): Make ctor explicit.
  • html/HTML5Lexer.cpp: (WebCore::HTMLNames::isEndTagBufferingState): Use switch to generate an efficient table with single branch.
  • html/HTML5Token.h: (WebCore::HTML5Token::forceQuirks): Add const.
  • html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::isPaused): Add const.
00:12 Changeset [61469] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add three more non-core Chromium builders to start testing DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=40335

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
00:08 Changeset [61468] by aa@chromium.org
  • 2 edits in trunk

2010-06-18 Aaron Boodman <aa@chromium.org>

Remove WebKit::WebDocument::isXHTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=40815

  • dom/Document.h: remove isXHTML() getter.

2010-06-18 Aaron Boodman <aa@chromium.org>

Remove WebKit::WebDocument::isXHTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=40815

  • public/WebDocument.h: Remove isXHTMLDocument().
  • src/WebDocument.cpp: Ditto.
00:05 Changeset [61467] by aa@chromium.org
  • 5 edits in trunk

2010-06-19 Aaron Boodman <aa@chromium.org>

Unreviewed, rolling out r61466.
http://trac.webkit.org/changeset/61466
https://bugs.webkit.org/show_bug.cgi?id=40816

Landed wrong change

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8DOMWindowShell.h:

2010-06-19 Aaron Boodman <aa@chromium.org>

Unreviewed, rolling out r61466.
http://trac.webkit.org/changeset/61466
https://bugs.webkit.org/show_bug.cgi?id=40816

Landed wrong change

  • src/WebKit.cpp: (WebKit::shutdown):

06/18/10:

23:54 Changeset [61466] by aa@chromium.org
  • 5 edits in trunk

2010-06-18 Aaron Boodman <aa@chromium.org>

WebKit API: Undo static hooks into V8 when WebKit is shut down.
https://bugs.webkit.org/show_bug.cgi?id=40816

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded): (WebCore::V8DOMWindowShell::initializeV8IfNeeded): (WebCore::V8DOMWindowShell::uninitializeV8IfNeeded):
  • bindings/v8/V8DOMWindowShell.h:

2010-06-18 Aaron Boodman <aa@chromium.org>

WebKit API: Undo static hooks into V8 when WebKit is shut downm
https://bugs.webkit.org/show_bug.cgi?id=40816

  • src/WebKit.cpp: (WebKit::shutdown): Call new WebCore::V8DOMWindowShell::uninitializeV8IfNeeded().
21:33 Changeset [61465] by rwlbuis@webkit.org
  • 1 edit
    1 move
    3 adds in trunk/LayoutTests

2010-06-18 Rob Buis <rwlbuis@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19575
layout test svg/batik/text/textDecoration.svg hangs

Reenable this test since crash is gone (tested on OS X 10.5.8).

  • platform/mac/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/mac/svg/batik/text/textDecoration-expected.png: Added.
  • platform/mac/svg/batik/text/textDecoration-expected.txt: Added.
  • svg/batik/text/textDecoration.svg: Renamed from LayoutTests/svg/batik/text/textDecoration.svg-disabled.
20:35 Changeset [61464] by abarth@webkit.org
  • 6 edits in trunk/WebKit/mac

2010-06-18 Adam Barth <abarth@webkit.org>

Unreviewed, rolling out r61459.
http://trac.webkit.org/changeset/61459
https://bugs.webkit.org/show_bug.cgi?id=40869

Seems to have broken two tests on the Tiger buildbot:

dom/html/level2/html/AppletsCollection.html
plugins/qt-qwidget-plugin.html

Anders wasn't on #webkit...

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage setName:]): (-[WebBasePluginPackage setPath:]): (-[WebBasePluginPackage setPluginDescription:]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
20:23 Changeset [61463] by jberlin@webkit.org
  • 2 edits in trunk/WebCore

Bug 19509 - Database Tables in the Inspector should be sortable
https://bugs.webkit.org/show_bug.cgi?id=19509

Reviewed by Darin Adler.

  • inspector/front-end/StoragePanel.js:

(WebInspector.StoragePanel.prototype.dataGridForResult):
Make each column in the DataGrid sortable.
(WebInspector.StoragePanel.prototype._sortDataGrid.comparator):
Make sure to sort numeric columns by their numeric values, instead of lexicographically.
(WebInspector.StoragePanel.prototype._sortDataGrid):
Sort the entries in the DataGrid based on the selected column.

20:18 Changeset [61462] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

  • WebCore.gyp/WebCore.gyp: Modified inclusion rule in to actually add WebSystemInterface.mm.
18:15 Changeset [61461] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage isJavaPlugIn]):

18:07 Changeset [61460] by andersca@apple.com
  • 4 edits in trunk/WebCore

More clang++ warning fixes.

Reviewed by Oliver Hunt.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):

  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/mac/WebLayer.mm:

(-[CALayer _descriptionWithPrefix:]):

17:35 Changeset [61459] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
https://bugs.webkit.org/show_bug.cgi?id=40869

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
17:15 Changeset [61458] by atwilson@chromium.org
  • 6 edits in trunk

[Chromium] Plumbing for top-level frame names
https://bugs.webkit.org/show_bug.cgi?id=40430

Reviewed by Darin Fisher.

WebKit/chromium:

  • public/WebFrame.h:

Removed obsolete clearName() API and added better documentation for
setName().

  • src/WebFrameImpl.cpp:

Removed clearName() API.

  • src/WebFrameImpl.h:

Removed clearName() API.

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):
Changed obsolete call to clearName() to use setName(WebString()) instead.

17:15 Changeset [61457] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Test by Chris Brichford.

https://bugs.webkit.org/show_bug.cgi?id=19759
ChildNodeList for an attribute node is not properly invalidated after appending a child

This issue has been fixed in another bug, just landing an additional test.

  • fast/dom/Attr/child-nodes-length-cache-expected.txt: Added.
  • fast/dom/Attr/child-nodes-length-cache.html: Added.
17:01 Changeset [61456] by andersca@apple.com
  • 3 edits
    1 move in trunk/WebKit

WebKit: Rename WebPluginPackage.m to make it an Objective-C++ file.

Reviewed by Sam Weinig.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac: Rename WebPluginPackage.m to make it an Objective-C++ file.

Reviewed by Sam Weinig.

  • Plugins/WebPluginPackage.m: Removed.
  • Plugins/WebPluginPackage.mm: Copied from Plugins/WebPluginPackage.m.
16:56 Changeset [61455] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

  • WebCore.gyp/WebCore.gyp: Renamed WebSystemInterface.m to WebSystemInterface.mm.
16:51 Changeset [61454] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of the NSEnumerators from WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40868

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage MIMETypes]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
16:23 Changeset [61453] by andersca@apple.com
  • 10 edits
    2 moves in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebKit.xcodeproj/project.pbxproj:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebCoreSupport/WebSystemInterface.h:
  • WebCoreSupport/WebSystemInterface.m: Removed.
  • WebCoreSupport/WebSystemInterface.mm: Copied from WebKit/mac/WebCoreSupport/WebSystemInterface.m.

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • platform/mac/WebCoreSystemInterface.h:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make WebCoreSystemInterface.h a C++ only header
https://bugs.webkit.org/show_bug.cgi?id=40867

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.h:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.m: Removed.
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: Copied from WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.m.
  • mac/WebKit2.exp:
16:17 Changeset [61452] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Clean up WebPluginDatabase.mm
https://bugs.webkit.org/show_bug.cgi?id=40866

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (pathByResolvingSymlinksAndAliases): (-[WebBasePluginPackage initWithPath:]): Change an instance method into a static function.


  • Plugins/WebPluginDatabase.mm: (PluginPackageCandidates::PluginPackageCandidates): (PluginPackageCandidates::update): (PluginPackageCandidates::bestCandidate): Add a new PluginPackageCandidates class.


(-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
Use PluginPackageCandidates here.

16:13 Changeset [61451] by levin@chromium.org
  • 4 edits
    2 adds in trunk

WebCore: Convert column span from an unsigned short type to an unsigned int
type. Fixes a divide-by-zero crash arising from using a zero colspan
value coming from a narrow cast of an int to an unsigned short.
https://bugs.webkit.org/show_bug.cgi?id=40812

Patch by Abhishek Arya <inferno@chromium.org> on 2010-06-18
Reviewed by Adam Barth.

Test: fast/table/zero-colspan-crash.html

  • rendering/RenderTable.h: Change span from unsigned short to unsigned int.
  • rendering/RenderTableSection.cpp: Fix a compiler warning with comparing unsigned int with signed int. Value of an unsigned int here cannot be greater than maximum positive value of a signed int.

(WebCore::RenderTableSection::addCell):

LayoutTests: Tests that we do not crash while rendering a fixed table layout.
https://bugs.webkit.org/show_bug.cgi?id=40812

Patch by Abhishek Arya <inferno@chromium.org> on 2010-06-18
Reviewed by Adam Barth.

  • fast/table/zero-colspan-crash-expected.txt: Added.
  • fast/table/zero-colspan-crash.html: Added.
16:09 Changeset [61450] by oliver@apple.com
  • 4 edits in trunk

2010-06-18 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Incorrect handling of multiple BOMs scattered through a file.
https://bugs.webkit.org/show_bug.cgi?id=40865

When determining the offset of open and close braces in a source
with BOMs we were finishing our count early as we failed to account
for BOMs prior to the open/close brace positions effecting those
positions.

  • parser/Lexer.cpp: (JSC::Lexer::sourceCode):

2010-06-18 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Incorrect handling of multiple BOMs scattered through a file.
https://bugs.webkit.org/show_bug.cgi?id=40865

Put a few more BOMs into this testcase so that it hits the other cases
that were missed before.

  • fast/js/resources/bom-in-file-retains-correct-offset.js: (g.f): (g):
16:01 Changeset [61449] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix Tiger build.

  • WebCoreSupport/WebPlatformStrategies.mm:
15:30 Changeset [61448] by dglazkov@chromium.org
  • 11 edits
    2 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Update a few more chromium-win baselines after http://trac.webkit.org/changeset/61393.

15:20 Changeset [61447] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add platform strategies for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=40863

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Added. (WebKit::WebPlatformStrategies::initialize): (WebKit::WebPlatformStrategies::WebPlatformStrategies): (WebKit::WebPlatformStrategies::createPluginStrategy): (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h: Added.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess):
15:16 Changeset [61446] by dglazkov@chromium.org
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Update a few more chromium-mac baselines after http://trac.webkit.org/changeset/61393.

15:11 Changeset [61445] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Text spacing miscalculation when using wordSpacing.
https://bugs.webkit.org/show_bug.cgi?id=40483

Patch by Ananth Jasty <ext-ananth.jasty@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

Removed wordSpacing compensation in FontQt whitespace width
calculation. The QFontMetrics::width() overload that takes
a character does not take QFont's word spacing into account.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::floatWidthForComplexText):

15:08 Changeset [61444] by andersca@apple.com
  • 10 edits
    1 delete in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PluginDataMac.mm and use the plug-in strategy instead
https://bugs.webkit.org/show_bug.cgi?id=40860

  • Plugins/WebBasePluginPackage.h:
  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::createPluginStrategy): (WebPlatformStrategies::refreshPlugins): (WebPlatformStrategies::getPluginInfo):
  • WebCoreSupport/WebViewFactory.mm:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PluginDataMac.mm and use the plug-in strategy instead
https://bugs.webkit.org/show_bug.cgi?id=40860

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/WebCoreViewFactory.h:
  • plugins/PluginData.cpp: (WebCore::PluginData::refresh): (WebCore::PluginData::initPlugins):
  • plugins/PluginStrategy.h:
  • plugins/mac/PluginDataMac.mm: Removed.
14:52 Changeset [61443] by weinig@apple.com
  • 9 edits
    5 adds
    1 delete in trunk
14:50 Changeset [61442] by dglazkov@chromium.org
  • 18 edits in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Update chromium baselines after http://trac.webkit.org/changeset/61418.

14:48 Changeset [61441] by andersca@apple.com
  • 7 edits in trunk/WebCore

Fix some (not all) clang++ warnings.

Reviewed by Dan Bernstein.

  • dom/Position.h:

(WebCore::lastOffsetInNode):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::resourceForRequest):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition):
(WebCore::ComplexTextController::collectComplexTextRuns):

  • platform/network/CredentialStorage.cpp:

(WebCore::protectionSpaceMapKeyFromURL):

  • rendering/style/StyleRareNonInheritedData.h:
14:44 Changeset [61440] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Skipped some failing tests and conglomerated a skipped test into another group.

  • platform/gtk/Skipped: Cleanups and three more skipped tests.
14:40 Changeset [61439] by dglazkov@chromium.org
  • 285 edits
    58 adds
    44 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Update chromium-linux baselines after http://trac.webkit.org/changeset/61393.

14:23 Changeset [61438] by andersca@apple.com
  • 8 edits
    2 adds in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebKit.xcodeproj/project.pbxproj:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebCoreSupport/WebPlatformStrategies.h: Added.
  • WebCoreSupport/WebPlatformStrategies.mm: Added. (WebPlatformStrategies::initialize): (WebPlatformStrategies::WebPlatformStrategies): (WebPlatformStrategies::createPluginStrategy):
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add stubbed out WebPlatformStrategies class to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=40851

  • WebCore.base.exp:
  • platform/PlatformStrategies.cpp:
  • platform/PlatformStrategies.h: (WebCore::PlatformStrategies::~PlatformStrategies):
14:19 Changeset [61437] by dglazkov@chromium.org
  • 798 edits
    73 adds in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Update chromium-win baselines after http://trac.webkit.org/changeset/61393.

14:09 Changeset [61436] by andersca@apple.com
  • 4 edits in trunk/WebCore

Fix build errors when building with clang++.

Reviewed by Darin Adler.

  • loader/archive/cf/LegacyWebArchiveMac.mm:

Move the const qualifier to the right place.

  • page/EditorClient.h:
  • platform/Pasteboard.h:

Use @class when forward declaring Objective-C classes in Objective-C.

14:05 Changeset [61435] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=40852
<rdar://problem/8105498> Limit simultaneous DNS prefetch request number (40852)

No change in functionality, so no tests.

We still queue up to 64 names, but only make up to 8 requests at once. If there are names
remaining in queue, we retry after a short timeout (which is easier than posting
notifications from client callback).

  • platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::add): (WebCore::DNSResolveQueue::fired):
14:03 Changeset [61434] by mrobinson@webkit.org
  • 2 edits
    27 adds in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests and correcting one incorrect baseline.

  • platform/gtk/media/video-replaces-poster-expected.txt: Correting this incorrect baseline.
  • platform/gtk/svg/hixie/text/001-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Added.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-1-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-2-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-3-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-4-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt: Added.
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt: Added.
14:01 Changeset [61433] by robert@webkit.org
  • 4 edits in trunk

2010-06-18 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • platform/qt/Skipped:

2010-06-18 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] pass plugins/open-and-close-window-with-plugin.html on Qt

Capture logDestroy messages from the test plugin. DRT's WebPage
is already destroyed by the time they are emitted.

https://bugs.webkit.org/show_bug.cgi?id=33333

Unskip:
plugins/open-and-close-window-with-plugin.html
plugins/geturlnotify-during-document-teardown.html

  • Api/qwebpage.cpp: (QWebPage::javaScriptConsoleMessage):
13:44 Changeset [61432] by zmo@google.com
  • 2 edits in trunk/WebCore

WebGL demos show bad flicker
https://bugs.webkit.org/show_bug.cgi?id=38560

13:41 Changeset [61431] by mrobinson@webkit.org
  • 2 edits
    74 adds in trunk/LayoutTests

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Adding baselines for new tests. Some tests that fail have been labeled
with bug numbers. Also removed a newly defunct test from the skipped list.

  • platform/gtk/Skipped: Removed newly baselined tests and one defunct test.
  • platform/gtk/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
  • platform/gtk/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt: Added.
  • platform/gtk/fast/css/css3-space-in-nth-and-lang-expected.txt: Added.
  • platform/gtk/fast/css/inline-element-line-break-expected.txt: Added.
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt: Added.
  • platform/gtk/fast/css/pseudo-element-line-break-expected.txt: Added.
  • platform/gtk/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Added.
  • platform/gtk/fast/multicol/single-line-expected.txt: Added.
  • platform/gtk/fast/repaint/block-no-inflow-children-expected.txt: Added.
  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.txt: Added.
  • platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-div-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt: Added.
  • platform/gtk/fast/table/fixed-table-with-small-percent-width-expected.txt: Added.
  • platform/gtk/media/video-replaces-poster-expected.txt: Added.
  • platform/gtk/svg/css/shadow-and-opacity-expected.txt: Copied from LayoutTests/platform/mac/svg/css/shadow-and-opacity-expected.txt.
  • platform/gtk/svg/custom/empty-mask-expected.txt: Added.
  • platform/gtk/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt.
  • platform/gtk/svg/custom/marker-opacity-expected.txt: Added.
  • platform/gtk/svg/custom/marker-referencePoint-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/marker-referencePoint-expected.txt.
  • platform/gtk/svg/custom/mask-invalidation-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-size-bigger-than-target-size-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt.
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/pattern-skew-transformed-expected.txt.
  • platform/gtk/svg/custom/relative-sized-content-expected.txt: Added.
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt: Added.
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt: Added.
  • platform/gtk/svg/custom/stroke-width-large-expected.txt: Added.
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt: Added.
  • platform/gtk/svg/filters/feDisplacementMap-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/feDisplacementMap-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt: Copied from LayoutTests/platform/mac/svg/overflow/overflow-on-inner-svg-element-expected.txt.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt: Added.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Added.
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.
  • platform/gtk/svg/text/selection-background-color-expected.txt: Added.
  • platform/gtk/svg/text/selection-doubleclick-expected.txt: Added.
  • platform/gtk/svg/text/selection-styles-expected.txt: Added.
  • platform/gtk/svg/text/selection-tripleclick-expected.txt: Added.
  • platform/gtk/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/gtk/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.txt.
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
  • platform/gtk/transforms/2d/hindi-rotated-expected.txt: Added.
13:14 Changeset [61430] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-06-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Don't throw away exception information for functions that use exceptions
https://bugs.webkit.org/show_bug.cgi?id=40786

Simple patch to stop JSC from throwing away the exception information
of a function that uses "exceptiony" features like try and throw. This
is a speed up for catching expressions but it's difficult to quantify as
the old cost of reparsing is amortised over all exceptions caught in the
effected function.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::emitCatch):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitThrow):
13:08 Changeset [61429] by andersca@apple.com
  • 5 edits
    3 adds in trunk

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PlatformStrategies and PluginStrategy classes.
https://bugs.webkit.org/show_bug.cgi?id=40850

  • wtf/Platform.h:

2010-06-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PlatformStrategies and PluginStrategy classes.
https://bugs.webkit.org/show_bug.cgi?id=40850

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PlatformStrategies.cpp: Added. (WebCore::PlatformStrategies::~PlatformStrategies): (WebCore::platformStrategies): (WebCore::setPlatformStrategies):
  • platform/PlatformStrategies.h: Added. (WebCore::PlatformStrategies::pluginStrategy): (WebCore::PlatformStrategies::PlatformStrategies):
  • plugins/PluginData.cpp:
  • plugins/PluginStrategy.h: Added. (WebCore::PluginStrategy::~PluginStrategy):
13:01 Changeset [61428] by mrobinson@webkit.org
  • 3 edits in trunk/WebCore

2010-06-18 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the GTK+ build after r61413 and 61379.

  • bindings/scripts/CodeGeneratorGObject.pm: Produce a g_value_set that uses getterExpressionPrefix instead of the raw getter.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_get_property): Update expected test results.
12:45 Changeset [61427] by cfleizach@apple.com
  • 3 edits in trunk/LayoutTests

No review. Fix Tiger and Leopards tests.

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
12:16 Changeset [61426] by leandro@webkit.org
  • 4 edits in trunk

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

  • wtf/CMakeLists.txt: Add MD5.cpp.

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

  • CMakeLists.txt: Add inspector/ScriptBreakpoint.cpp.
12:11 Changeset [61425] by aestes@apple.com
  • 2 edits in trunk/WebCore

Update copyright header.

Rubber-stamped by Sam Weinig.

  • html/HTMLLinkElement.h:
12:03 Changeset [61424] by aestes@apple.com
  • 4 edits
    2 adds in trunk

WebCore: <rdar://problem/8091385> Prevent a crash in WebCore when removing a stylesheet link element in
in a listener to its beforeload event.
https://bugs.webkit.org/show_bug.cgi?id=40742

Reviewed by Dan Bernstein.

Postpone loading of link elements until after they have been inserted into the DOM and
attached. This prevents DOM mutations triggered by beforeload handlers from firing in the
midst of DOM insertion, which can lead to assertion failures and crashes.

Test: fast/dom/beforeload/remove-link-in-beforeload-listener.html

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement): Initialize m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::processCallback): Add a static callback function which calls
HTMLLinkElement::process().
(WebCore::HTMLLinkElement::insertedIntoDocument): Instead of calling process() directly, set
m_shouldProcessAfterAttach to true to indicate that process() should be called after attach().
(WebCore::HTMLLinkElement::removedFromDocument): Set m_shouldProcessAfterAttach to false.
(WebCore::HTMLLinkElement::attach): If m_shouldProcessAfterAttach is true, register
HTMLLinkElement::processCallback() as a post-attach callback.

  • html/HTMLLinkElement.h: Add m_shouldProcessAfterAttach.

(WebCore::HTMLLinkElement::canLazyAttach): Override canLazyAttach() to return false to
indicate that a full attach should be performed. This ensures the post-attach callbacks are
fired.

LayoutTests: <rdar://problem/8091385> Test that removing a stylesheet link element in a listener to its
beforeload event does not crash WebCore.
https://bugs.webkit.org/show_bug.cgi?id=40742

Reviewed by Dan Bernstein.

  • fast/dom/beforeload/remove-link-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-link-in-beforeload-listener.html: Added.
11:40 Changeset [61423] by ossy@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected files after r61418.

  • platform/qt/editing/pasteboard/paste-text-005-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-006-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-007-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-014-expected.txt:
11:20 WebKit Team edited by luiz@webkit.org
(diff)
11:18 Changeset [61422] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

Unreviewed. Windows build fix.

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

10:58 Changeset [61421] by cfleizach@apple.com
  • 4 edits
    2 adds in trunk

AX: presentational role needs to be inherited by required elements
https://bugs.webkit.org/show_bug.cgi?id=40132

Reviewed by David Kilzer.

WebCore:

Test: platform/mac/accessibility/inherited-presentational-lists.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::node):

LayoutTests:

  • platform/mac/accessibility/inherited-presentational-lists-expected.txt: Added.
  • platform/mac/accessibility/inherited-presentational-lists.html: Added.
10:54 Changeset [61420] by darin@apple.com
  • 3 edits in trunk/WebCore

Fix GTK build after reflection change.

  • bindings/scripts/CodeGeneratorGObject.pm: Changed code

that emits setters to convey the correct type of the attribute.
The GObject code generator takes a different approach to attributes
than the others, so it's hacked a bit to make it more like them.
We should find a way to share more code between the different generators.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

Updated to expect correct results.

10:42 Changeset [61419] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-06-18 Yury Semikhatsky <yurys@chromium.org>

Unreviewed: Qt build fix.

  • inspector/InspectorController.cpp:
10:35 Changeset [61418] by justin.garcia@apple.com
  • 21 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=39798
No selection change notification for editing operation that doesn't change the selection's DOM position

Reviewed by Ojan Vafai.

WebCore:

Some editing operations change the selection visually without affecting its position within
the DOM. This was previously known to occur for certain typing commands, but it can also
occur for some Pastes and changes to block style.

  • editing/Editor.cpp:

(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::changeSelectionAfterCommand):

  • editing/Editor.h:

LayoutTests:

block-style-001.html demonstrated the bug, so no new tests have been added.

  • platform/mac/editing/execCommand/format-block-expected.txt:
  • platform/mac/editing/execCommand/outdent-selection-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-005-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-006-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-007-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-014-expected.txt:
  • platform/mac/editing/style/apple-style-editable-mix-expected.txt:
  • platform/mac/editing/style/block-style-001-expected.txt:
  • platform/mac/editing/style/block-style-002-expected.txt:
  • platform/mac/editing/style/block-style-003-expected.txt:
  • platform/mac/editing/style/create-block-for-style-005-expected.txt:
  • platform/mac/editing/style/create-block-for-style-006-expected.txt:
  • platform/mac/editing/style/create-block-for-style-008-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-002-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-003-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-004-expected.txt:
  • platform/mac/editing/style/table-selection-expected.txt:
10:22 Changeset [61417] by atwilson@chromium.org
  • 2 edits in trunk/WebKit/chromium

Roll chromium DEPS 50089:50171
https://bugs.webkit.org/show_bug.cgi?id=40842

Reviewed by Dumitru Daniliuc.

  • DEPS:

Update chromium_rev to r50171 to remove downstream reference to WebFrame::clearName().

10:12 Changeset [61416] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break on Debug build.
https://bugs.webkit.org/show_bug.cgi?id=40810

  • CMakeLists.txt: Add CSSPreloadScanner.cpp
09:59 Changeset [61415] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=40803
TestNetscapePlugin has an incorrect implementation of "property" property

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't pass a static string back, it's going to be released by NPAPI implementation.
09:51 Changeset [61414] by yurys@chromium.org
  • 13 edits
    1 add in trunk/WebCore

2010-06-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: persist breakpoints in inspector settings.
https://bugs.webkit.org/show_bug.cgi?id=14190

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setSessionSettings): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
  • inspector/InspectorController.h:
  • inspector/InspectorValues.cpp: (WebCore::InspectorValue::parseJSON):
  • inspector/InspectorValues.h:
  • inspector/ScriptBreakpoint.cpp: Added. (WebCore::ScriptBreakpoint::sourceBreakpointsFromInspectorObject): (WebCore::ScriptBreakpoint::inspectorObjectFromSourceBreakpoints):
  • inspector/ScriptBreakpoint.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.addBreakpoint): (WebInspector.BreakpointManager.prototype.restoredBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointsForSourceID): (WebInspector.BreakpointManager.prototype.breakpointsForURL): (WebInspector.BreakpointManager.prototype._addBreakpoint):
  • inspector/front-end/inspector.js: (WebInspector.restoredBreakpoint):
09:47 Changeset [61413] by darin@apple.com
  • 78 edits in trunk/WebCore

2010-06-18 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Implement additional DOM attribute reflection for bindings
https://bugs.webkit.org/show_bug.cgi?id=39936

  • Added support for [Reflect] for long, unsigned long, and boolean attributes.
  • Fixed code that set attributes like this: <video controls="controls"> to instead set them like this: <video controls>.
  • Added lots more uses of [Reflect].
  • Removed now-unneeded [ConvertFromString].
  • Made [Reflect] imply [ConvertNullToNullString] so we can get rid of most uses of the latter.
  • Made [Reflect] automatically lowercase the name of the reflected content attribute to minimize the need to specify a custom content attribute name.

One thing this patch does *not* do is remove the unneeded functions
in the various DOM classes that are no longer used by the bindings.
We should do that in a followup.

  • bindings/scripts/CodeGenerator.pm: Added new functions so code can be shared across bindings, GetterExpressionPrefix and SetterExpressionPrefix. We can do a lot more refactoring like this in the future.
  • bindings/scripts/CodeGeneratorCPP.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes.
  • bindings/scripts/CodeGeneratorGObject.pm: Removed unneeded ConvertFromString handling, changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions to better handle reflected DOM attributes. Fixed a few things in the output so the .cpp file will have more WebKit style. The .h file should be GTK style, but the .cpp file can be the standard WebKit style eventually.
  • bindings/scripts/CodeGeneratorJS.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/CodeGeneratorObjC.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Redid the special cases for ownerDocument and for operator to fit better with the new code paths. Removed unneeded ConvertFromString handling.
  • bindings/scripts/CodeGeneratorV8.pm: Changed to use the new GetterExpressionPrefix and SetterExpressionPrefix functions and removed a now-unneeded IsSVGAnimatedType special case since the new functions take care of it. Made reflected attributes automatically convert null to the null string without a separate ConvertNullToNullString attribute.
  • bindings/scripts/test/TestObj.idl: Added some test cases for content attribute reflection and for exceptions in string-typed attributes.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.cpp: Updated.
  • bindings/scripts/test/CPP/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
  • dom/Element.cpp: (WebCore::Element::getIntegralAttribute): Added. (WebCore::Element::setIntegralAttribute): Added. (WebCore::Element::getUnsignedIntegralAttribute): Added. (WebCore::Element::setUnsignedIntegralAttribute): Added.
  • dom/Element.h: Added new attribute get/set functions for bindings.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isURLAttribute): Added. Returns true for srcAttr.
  • html/HTMLMediaElement.h: Added isURLAttribute.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::isURLAttribute): Changed to call HTMLMediaElement::isURLAttribute before checking for posterAttr.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLUListElement.idl:
  • html/HTMLVideoElement.idl:
  • svg/SVGElement.idl: Added more uses of [Reflect]. Got rid of uses of [ConvertNullToNullString] that are now unneeded since [Reflect] now implies that. Changed formatting to be simpler and consistent without all the lining up and multiple lines.
09:39 Changeset [61412] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Remove some unnecessary checks that cause compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=40772

Reviewed by Dimitri Glazkov.

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/npruntime.cpp:
09:11 Changeset [61411] by mnaganov@chromium.org
  • 13 edits in trunk

2010-06-18 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Implement 'takeHeapSnapshot' in InspectorController.

https://bugs.webkit.org/show_bug.cgi?id=40834

  • bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::takeHeapSnapshot):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::takeHeapSnapshot):
  • inspector/InspectorController.h:
  • src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
  • src/js/ProfilerAgent.js: (devtools.ProfilerAgent.prototype.startProfiling):
08:55 Changeset [61410] by mitz@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r61379?): Assertion failure in Element::getURLAttribute() when accessing the src attribute of a script element
https://bugs.webkit.org/show_bug.cgi?id=40831

Reviewed by Anders Carlsson.

WebCore:

Test: fast/dom/HTMLScriptElement/isURLAttribute.html

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::isURLAttribute): Check for the 'src' attribute.

LayoutTests:

  • fast/dom/HTMLScriptElement/isURLAttribute-expected.txt: Added.
  • fast/dom/HTMLScriptElement/isURLAttribute.html: Added.
08:54 Changeset [61409] by dglazkov@chromium.org
  • 33 edits
    29 adds
    23 deletes in trunk/LayoutTests

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

New baselines after http://trac.webkit.org/changeset/61393.

08:46 Changeset [61408] by eric@webkit.org
  • 5 edits
    3 deletes in trunk

2010-06-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61405.
http://trac.webkit.org/changeset/61405
https://bugs.webkit.org/show_bug.cgi?id=40838

broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).

  • fast/js/parser-high-byte-character-expected.txt: Removed.
  • fast/js/parser-high-byte-character.html: Removed.
  • fast/js/script-tests/parser-high-byte-character.js: Removed.

2010-06-18 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61405.
http://trac.webkit.org/changeset/61405
https://bugs.webkit.org/show_bug.cgi?id=40838

broke chromium mac compile (Requested by tonyg-cr1 on
#webkit).

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
08:44 Changeset [61407] by leandro@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-18 Leandro Pereira <leandro@profusion.mobi>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
08:40 QtWebKitJournal edited by hausmann@webkit.org
(diff)
08:14 Changeset [61406] by eric@webkit.org
  • 8 edits in trunk

2010-06-18 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
https://bugs.webkit.org/show_bug.cgi?id=40176

  • fast/canvas/webgl/gl-object-get-calls-expected.txt: Test name == 0 cases, and test getVertexAttrib return original WebGLBuffer object.
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.

2010-06-18 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix WebGLRenderingContext helper functions find{Texture/Renderbuffer/Buffer}
https://bugs.webkit.org/show_bug.cgi?id=40176

  • html/canvas/WebGLBuffer.cpp: Remove constructor with existing name.
  • html/canvas/WebGLBuffer.h: Ditto.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getVertexAttrib): Use findBuffer instead of creating a new WebGLBuffer. (WebCore::WebGLRenderingContext::findTexture): Deal with name == 0 case and return raw pointer. (WebCore::WebGLRenderingContext::findRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::findBuffer): Find WebGLBuffer object using given name.
  • html/canvas/WebGLRenderingContext.h: Add findBuffer function declaration, change return type to raw pointer.
08:00 Changeset [61405] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

When V8 ScriptData caching was originally submitted it causes crashes
in external scripts with high-byte characters. This new test crashes on
the original code, but now passes.

  • fast/js/parser-high-byte-character-expected.txt: Added.
  • fast/js/parser-high-byte-character.html: Added.
  • fast/js/script-tests/parser-high-byte-character.js: Added. (runTest):

2010-06-18 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark showed a ~7% improvement when this was
originally submitted (before it had to be rolled back).

Test: fast/js/parser-high-byte-character.html

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
06:35 Changeset [61404] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Fix documentation for the declarative module import.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
06:09 Changeset [61403] by krit@webkit.org
  • 9 edits in trunk/LayoutTests

2010-06-18 Dirk Schulze <krit@webkit.org>

Not reviewed. Rebaseline gtk results.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
05:50 Changeset [61402] by antonm@chromium.org
  • 4 edits in trunk

2010-06-18 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Finish migration to new named property query API
https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.
Requires V8 roll.

  • DEPS:

2010-06-18 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Finish migration to new named property query API
https://bugs.webkit.org/show_bug.cgi?id=40771
Remove definition which allowed gradual transition to new API.
See https://bugs.webkit.org/show_bug.cgi?id=40303 for first phase.

  • config.h:
05:50 Changeset [61401] by zimmermann@webkit.org
  • 6 edits
    3 adds in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline win results.

  • platform/win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
  • platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • platform/win/svg/custom/broken-internal-references-expected.txt:
  • platform/win/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:
  • platform/win/svg/custom/junk-data-expected.txt: Added.
  • platform/win/svg/custom/missing-xlink-expected.txt: Added.
  • platform/win/svg/filters/feColorMatrix-values-expected.txt:
05:38 Changeset [61400] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Fix documentation issue on the onAlert handler.
Fix compilation issue with QT_NO_ACTION.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
  • declarative/qdeclarativewebview_p.h:
05:34 Changeset [61399] by zimmermann@webkit.org
  • 5 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline mac-snowleopard results.

  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
05:28 Changeset [61398] by zimmermann@webkit.org
  • 6 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline mac-tiger test results.

  • platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003a-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
05:27 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
05:27 Changeset [61397] by pfeldman@chromium.org
  • 15 edits in trunk

2010-06-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: bring XHR console records back.

  • adds "Enable XHR Monitor" / "Disable XHR Monitor" actions to the console's context menu
  • make the chosen option persist in the settings.

https://bugs.webkit.org/show_bug.cgi?id=40799

  • English.lproj/localizedStrings.js:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::disableSearchingForNode): (WebCore::InspectorBackend::enableMonitoringXHR): (WebCore::InspectorBackend::disableMonitoringXHR):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setMonitoringXHR): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::ensureSettingsLoaded):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::monitoringXHRWasEnabled): (WebCore::InspectorFrontend::monitoringXHRWasDisabled):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._handleContextMenuEvent): (WebInspector.ConsoleView.prototype._registerShortcuts):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub): (.WebInspector.InspectorBackendStub.prototype.enableMonitoringXHR): (.WebInspector.InspectorBackendStub.prototype.disableMonitoringXHR):
  • inspector/front-end/inspector.js: (WebInspector.monitoringXHRWasEnabled): (WebInspector.monitoringXHRWasDisabled):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
05:25 Changeset [61396] by zimmermann@webkit.org
  • 17 edits
    2 adds in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaselined Qt test results.

  • platform/qt/svg/custom/broken-internal-references-expected.txt:
  • platform/qt/svg/custom/empty-mask-expected.txt:
  • platform/qt/svg/custom/mask-invalidation-expected.txt:
  • platform/qt/svg/custom/stroke-width-large-expected.txt:
  • platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/dom/altGlyph-dom-expected.txt: Added.
  • platform/qt/svg/filters/feColorMatrix-values-expected.txt:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/filter-on-tspan-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt: Added.
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-doubleclick-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.txt:
  • platform/qt/svg/text/selection-tripleclick-expected.txt:
  • platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
05:23 Changeset [61395] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

REGRESSION(r60958) [Qt] qwebpage::inputMethods auto-test fails
https://bugs.webkit.org/show_bug.cgi?id=40830

Reviewed by Antti Koivisto.

When activating a regular input method field, always set or unset the ImhHiddenText
input method hint.

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

04:37 Changeset [61394] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-18 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Merge text_expectations.txt of Chromium tree. Mainly for <progress> and <meter>.
04:18 Changeset [61393] by zimmermann@webkit.org
  • 759 edits
    4 moves
    102 adds in trunk

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Modernize SVG Text code, following the HTML design
https://bugs.webkit.org/show_bug.cgi?id=40663

SVG Text does not support subpixel positioning
https://bugs.webkit.org/show_bug.cgi?id=12172

RenderSVGText can't do partial repaints
https://bugs.webkit.org/show_bug.cgi?id=15386

HTML and SVG need to share more text painting code
https://bugs.webkit.org/show_bug.cgi?id=15644

Rewrite SVG Text rendering, only keeping the layout of the actual characters/chunks as it was.
We're now drawing SVG Text very similar to HTML Text, utilizing the SVGInlineFlowBox/SVGInlineTextBox structure,
instead of painting all text content of a <text> element from the SVGRootInlineBox, as it was the last years.

Rough overview of the changes:

  • Partial repainting support for text selections (startPos/endPos are respected), no more redrawing of the whole <text> content while selecting
  • Subpixel positioning (near pixel-perfect rendering for all W3C tests that contain text, finally!) -> much better textPath results, characters now align as expected, as all rounding hacks are disabled for SVG text runs, and subpixel precision is used while painting
  • No more custom handling of selection, the standard methods offsetFromPosition() / selectionRectForText() are used instead.
  • Selection works as expected on stretched/squeezed text (lengthAdjust="spacingAndGlyphs"), takes 'includePartialGlyphs' into account - just like HTML text
  • Correct text decoration drawing (proper with and positions and rendering-order, underline/overline before text, strike-through afterwards)
  • Proper sizing of all InlineBoxes, starting from the SVGRootInlineBox, down to every single flow & text box -> correct DRT results, no more weird negative offsets of text runs, etc. Looks exactly like the HTML text test results.
  • Rewritten SVGTextContentElement API to take per-character / per-chunk transformations into account.
  • Speeeeeed! Drawing is much faster now.

Add 24 new testcases covering basic selection features and the SVGTextContentElement API. Each test draws a half-opaque red rectangle, calculated using
SVGTextContentElement API to highlight the area that is supposed to be selected. Then eventSender API is utilized to move the mouse to the calculated
start origin, holding it down and moving it to the end position.

A detailed list of tests that show progression, can be found in the corresponding LayoutTests/ChangeLog.
Note that this requires a rebaselining of all SVG tests containing text elements.

Tests: svg/hixie/text/001.xml (moved from svg/hixie/text/001-broken.xml)

svg/text/lengthAdjust-text-metrics.html
svg/text/select-textLength-spacing-squeeze-1.svg
svg/text/select-textLength-spacing-squeeze-2.svg
svg/text/select-textLength-spacing-squeeze-3.svg
svg/text/select-textLength-spacing-squeeze-4.svg
svg/text/select-textLength-spacing-stretch-1.svg
svg/text/select-textLength-spacing-stretch-2.svg
svg/text/select-textLength-spacing-stretch-3.svg
svg/text/select-textLength-spacing-stretch-4.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-1.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-2.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-3.svg
svg/text/select-textLength-spacingAndGlyphs-squeeze-4.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-1.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-2.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-3.svg
svg/text/select-textLength-spacingAndGlyphs-stretch-4.svg
svg/text/select-x-list-1.svg
svg/text/select-x-list-2.svg
svg/text/select-x-list-3.svg
svg/text/select-x-list-4.svg
svg/text/select-x-list-with-tspans-1.svg
svg/text/select-x-list-with-tspans-2.svg
svg/text/select-x-list-with-tspans-3.svg
svg/text/select-x-list-with-tspans-4.svg

  • rendering/InlineBox.h: Remove not needed isInlineBox() method. (WebCore::InlineBox::isInlineTextBox): Constify this method. (WebCore::InlineBox::isSVGInlineTextBox): Added, with ENABLE(SVG) guards, just like the existing isSVGRootInlineBox(). (WebCore::InlineBox::isSVGRootInlineBox): Constify this method. (WebCore::InlineBox::calculateBoundaries): Added, with ENABLE(SVG) guards, used to calculate the whole boundaries of a InlineText/FlowBox, only used in SVG text.
  • rendering/InlineFlowBox.h: Devirtualize placeBoxesHorizontally(), SVG no more overrides it.
  • rendering/InlineTextBox.h: Virtualize selectionStartEnd() - SVGInlineTextBox needs to change start/endPositions based on the current text chunk part that it's rendering.

SVGTextChunkLayoutInfo.h contains a detailed documentation what a SVGTextChunk/SVGTextChunkPart is, and why they are necessary.

(WebCore::InlineTextBox::isInlineTextBox): Constify this method.

  • rendering/RenderBlock.h: (WebCore::RenderBlock::forceLayoutInlineChildren): Add helper method, used only by RenderSVGText, to use a simplified layout strategy, which is a big speed win.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Remove all isSVGText() special cases, as this function is not called anymore for SVG text. (WebCore::RenderBlock::layoutInlineChildren): Don't call computeHorizontalPositionsForLine() for SVG text. computePerCharacterLayoutInformation() overrides it anyway.
  • rendering/RenderSVGInline.cpp: Remove custom absoluteRects/absoluteQuads code, all shared with RenderInline now. (WebCore::RenderSVGInline::clippedOverflowRectForRepaint): Added, forward to SVGRenderBase, just like all other non-text SVG renderers do. (WebCore::RenderSVGInline::computeRectForRepaint): Ditto. (WebCore::RenderSVGInline::mapLocalToContainer): Ditto
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGInlineText.cpp: Remove destroy() hack, which called setNeedsLayoutAndPrefWidthsRecalc/repaint on destruction.

As repaint rects work properly now, this hack is no longer necessary, it was only hiding the real problem.

(WebCore::RenderSVGInlineText::styleDidChange): Don't skip RenderText::styleDidChange() anymore, which automatically schedules layout changes for us.
(WebCore::RenderSVGInlineText::localCaretRect): Remove outdated comment, localCaretRect() is not yet needed in SVG text code.

  • rendering/RenderSVGInlineText.h: Remove custom absoluteRects/absoluteQuads/selectionRectForRepaint/positionForPoint/destroy/computeRectForRepaint* code, all shared with RenderText now.
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer): Take x/y translation into account, but do NOT include in localToParentTransform(), as that would affect rendering. (WebCore::RenderSVGText::layout): Use super-simplified layout strategy, removing a lot of uncessary stuff done by RenderBlock, that SVG does not need. (WebCore::RenderSVGText::absoluteRects): Remove dead-code, retreving the RenderSVGRoot* object, not necessary since a longer time. (WebCore::RenderSVGText::absoluteQuads): Ditto. (WebCore::RenderSVGText::paint): Early exit if we're not in PaintPhaseForeground/PaintPhaseSelfOutline. We're not interessted in other phases. (WebCore::RenderSVGText::strokeBoundingBox): Fix stroke width calculation, no need to special case SVGFonts.
  • rendering/RenderSVGText.h: Remove updateFirstLineBlock/updateFirstLetter overrides, the new RenderSVGText::layout() code, doesn't use these methods at all.

We asked RenderBlock to layout before, which was calling updateFirstLetter & co, this is gone now, as it was all not needed.

(WebCore::RenderSVGText::objectBoundingBox): Directly return the frameRect here, inlined for speed.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::verticallyAlignBoxes): Early-exit if we're a SVGRootInlineBox. SVG handles this on its own.
  • rendering/RootInlineBox.h: Devirtualize verticallyAlignBoxes(), SVG no longer overrides it. Remove virtual computePerCharacterLayoutInformation() method, only lives in SVGRootInlineBox now.
  • rendering/SVGCharacterData.h: Remove no longer needed SVGTextDecorationInfo.
  • rendering/SVGCharacterLayoutInfo.cpp: Don't pass a reference to a Vector<SVGChar> to SVGCharacterLayoutInfo, let it create it. (WebCore::SVGCharacterLayoutInfo::SVGCharacterLayoutInfo):
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint): Ask children to paint. (WebCore::SVGInlineFlowBox::calculateBoundaries): Calculate boundaries by uniting all direct children boundaries.
  • rendering/SVGInlineFlowBox.h: Remove placeBoxesHorizontally, which does not get called anymore, and does not need to be overriden.
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::SVGInlineTextBox): Don't use abbrevations for variable names, initialize new member variables. (WebCore::SVGInlineTextBox::measureCharacter): New helper function extracted from buildLayoutInformation, replacing calculateGlyphWidth/Height. (WebCore::SVGInlineTextBox::offsetForPosition): Implement this method by utilizing Font::offsetForPosition(), but respecting the text chunk parts. (WebCore::SVGInlineTextBox::positionForOffset): No change here, still not used. (WebCore::SVGInlineTextBox::selectionRect): Rewritten, utilizing Font::selectionRectForText(), taking text chunk parts into account, and the supplied startPos/endPos. (WebCore::SVGInlineTextBox::paint): Rewritten, to handle paint servers much more elegant, than the old solution. See code for details, too much to explain here. (WebCore::SVGInlineTextBox::acquirePaintingResource): Helper function, used from paint(). (WebCore::SVGInlineTextBox::releasePaintingResource): Ditto. (WebCore::SVGInlineTextBox::prepareGraphicsContextForTextPainting): Ditto. (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting): Ditto. (WebCore::SVGInlineTextBox::constructTextRun): Helper function centralizing the creation of a TextRun object, used to draw/measure SVG text. (WebCore::SVGInlineTextBox::mapStartEndPositionsIntoChunkPartCoordinates): Important helper function, mapping a startPos/endPos from InlineTextBox

coordinate space to the SVGInlineTextBox, respecting the current text chunk part.

(WebCore::SVGInlineTextBox::selectionStartEnd): Call InlineTextBox::selectionStartEnd(), and apply post fixes when m_currentChunkPart is set. (called when painting a selected chunk part)
(WebCore::positionOffsetForDecoration): Refactored from old paintDecoration() code.
(WebCore::thicknessForDecoration): Ditto.
(WebCore::findRenderObjectDefininingTextDecoration): Ditto.
(WebCore::SVGInlineTextBox::paintDecoration): Ditto. (Can not share the code with HTML, as we need floating point precision, and directly call fillRect, instead of drawHighlightForText.)
(WebCore::SVGInlineTextBox::paintDecorationWithStyle): Ditto.
(WebCore::SVGInlineTextBox::paintSelection): New method, painting text selections with floating-point precision.
(WebCore::SVGInlineTextBox::paintText): New method, painting text with floating-point precision, correctly handling selected text, removing the need for special SVG text sub-paint phases.

(GlyphFill/StrokeSelectionPhase, GlyphFill/StrokePhase)

(WebCore::SVGInlineTextBox::buildLayoutInformation): Use new measureCharacter() helper function, renamed some variables, to avoid abbrevations.
(WebCore::SVGInlineTextBox::calculateGlyphBoundaries): Rewritten to use new measureCharacter() helper function.
(WebCore::SVGInlineTextBox::calculateBoundaries): Rewritten to take text chunk parts into account, serves as central method used to layout InlineBoxes (see SVGRootInlineBox.)

  • rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::isSVGInlineTextBox): Added. (WebCore::SVGInlineTextBox::setHeight): Rename variable, to avoid abbrevations. (WebCore::SVGInlineTextBox::chunkTransformation): New helper function, returning the transformation, that gets applied to the complete text chunk, if any. (WebCore::SVGInlineTextBox::setChunkTransformation): New helper function used by SVGRrootInlineBox, to set the chunk transformation, during text chunk part propagation phase. (WebCore::SVGInlineTextBox::addChunkPartInformation): Ditto. (WebCore::SVGInlineTextBox::svgTextChunkParts): Ditto.
  • rendering/SVGRootInlineBox.cpp: Virtually rewritten, to be designed more like HTMLs RootInlineBox, diving into children for painting. (WebCore::SVGRootInlineBox::paint): Ask children to paint, nothing more. No more traversing through the SVGTextChunks, figuring out which part to render, this is done in layout phase now. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): Completly redesigned, see SVGTextChunkLayoutInfo.h for a high-level overview. (WebCore::SVGRootInlineBox::buildLayoutInformation): Just small cleanups, nothing changed here. (WebCore::SVGRootInlineBox::layoutChildBoxes): New helper function, extracted from old layoutInlineBoxes(). (WebCore::SVGRootInlineBox::layoutRootBox): Ditto. (WebCore::SVGRootInlineBox::propagateTextChunkPartInformation): Key-concept of the new design, builds "text chunk parts" and propagates that knownledge to all child SVGInlineTextBoxes.
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::isSVGRootInlineBox): Constified method. (WebCore::SVGRootInlineBox::setHeight): Change variable name, to avoid abbrevations.
  • rendering/SVGTextChunkLayoutInfo.cpp: Remove if 0, enable compilation.
  • rendering/SVGTextChunkLayoutInfo.h: Add large comment explaining text chunk parts, the key concept of the new design. Remove SVGTextChunkWalker & friends, no longer used. (WebCore::SVGTextChunkPart::SVGTextChunkPart): (WebCore::SVGTextChunkPart::isValid): (WebCore::SVGTextChunk::SVGTextChunk): (WebCore::SVGTextChunkLayoutInfo::SVGTextChunkLayoutInfo): (WebCore::SVGTextChunkLayoutInfo::textChunks):
  • rendering/SVGTextLayoutUtilities.cpp: (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::cummulatedHeightOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox): Disable rounding hacks, explain parameters with comments, why they have which values.
  • rendering/SVGTextLayoutUtilities.h: Remove SVGTextPaintSubphase and SVGTextPaintInfo.
  • rendering/SVGTextQuery.cpp: Remove if 0, enable compilation.
  • rendering/SVGTextQuery.h: Ditto.
  • svg/SVGStyledElement.cpp: Very important change! Do not treat CSS attributes as recognized attributes, that would lead to setNeedsLayout() calls, reducing performance!

This hack existed, as we were not dealing with text updates correctly, now that RenderSVGInlineText::styleDidChange is fixed, it's no longer necessary.

(WebCore::SVGStyledElement::isKnownAttribute):

  • svg/SVGTextContentElement.cpp: Completely remove the SVGTextContentElement API, that manually traversed all text chunks, instead use the new SVGTextQuery API. (WebCore::SVGTextContentElement::getNumberOfChars): (WebCore::SVGTextContentElement::getComputedTextLength): (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::getStartPositionOfChar): (WebCore::SVGTextContentElement::getEndPositionOfChar): (WebCore::SVGTextContentElement::getExtentOfChar): (WebCore::SVGTextContentElement::getRotationOfChar): (WebCore::SVGTextContentElement::getCharNumAtPosition):
  • svg/SVGTextElement.cpp: Very important change! Do not calls setNeedsLayout() on RenderSVGText, if childrenChanged() has been called.
  • svg/SVGTextElement.h: Completly remove childrenChanged() - no longer necessary, updates work as expected without it now.
03:41 Changeset [61392] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by David Levin.

Fix compilation when filters are disabled. Revision r60689
changed the signature of SVGRenderBase::prepareToRenderSVGContent()
but didn't change the unsused parameters when filters are disabled.
https://bugs.webkit.org/show_bug.cgi?id=40625

No new tests. Compilation fix.

  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
03:28 Changeset [61391] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309

Test that data URLs can access their inline style sheets.

  • http/tests/security/data-url-inline.css-expected.txt: Added.
  • http/tests/security/data-url-inline.css.html: Added.

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

noAccess url schemes block access to inline stylesheets
https://bugs.webkit.org/show_bug.cgi?id=32309

Instead of using baseURL() to grab the security context we should just
use finalURL directly. When I wrote the original patch that added this
security check, finalURL didn't exist yet.

If finalURL is an empty URL, that means we generated the style sheet
from text that didn't have a URL. It would be slightly safer to store
a bit on CSSStyleSheet indicating whether it came from an inline style
sheet, but I think this check is fairly accurate.

Test: http/tests/security/data-url-inline.css.html

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
03:04 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
02:31 Changeset [61390] by abarth@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180

We don't appear to require a custom binding here. The old function was
wacky in two ways:

1) It required all of its arguments.

2) If the toString of its argument threw, it would catch the exception

and re-throw a different exception.

I've kept the first behavior but changed the second (and documented it
with a test).

Test: websocket/tests/send-throw.html

  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/v8/custom/V8WebSocketCustom.cpp:
  • websockets/WebSocket.idl:

2010-06-18 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unneeded custom code for WebSocket.send
https://bugs.webkit.org/show_bug.cgi?id=38180

Test what happens when you pass an object to WebSocket.send that throws
when you convert it to a string.

  • websocket/tests/script-tests/send-throw.js: Added. (endTest): (FIRST_MESSAGE_TO_SEND.toString): (ws.onopen): (ws.onclose): (timeOutCallback):
  • websocket/tests/send-throw-expected.txt: Added.
  • websocket/tests/send-throw.html: Added.
02:18 Changeset [61389] by hausmann@webkit.org
  • 4 edits in trunk

WebKit: [qt] Better check for the declarative plugin inclusion.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • WebKit.pro:

WebKit/qt: [Qt] Change the target path to QtWebKit.

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-18
Reviewed by Simon Hausmann.

  • declarative/declarative.pro:
02:16 Changeset [61388] by dumi@chromium.org
  • 25 edits in trunk

Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

WebCore:

  • WebCore.base.exp
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::openDatabase):

  • storage/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::isAvailable):
(WebCore::AbstractDatabase::setIsAvailable):

  • storage/AbstractDatabase.h:
  • storage/Database.cpp:
  • storage/Database.h:
  • storage/DatabaseSync.cpp:
  • storage/DatabaseSync.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::openDatabase):
(WebCore::WorkerContext::openDatabaseSync):

  • workers/WorkerContext.h:

WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDatabase):
(WebKit::WebRuntimeFeatures::isDatabaseEnabled):

WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
(webkit_get_cache_model):

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

WebKit/win:

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

WebKit/wx:

  • WebView.cpp:

(wxWebView::SetDatabasesEnabled):
(wxWebView::AreDatabasesEnabled):

02:01 Changeset [61387] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Try to turn Gtk 32-bit Linux Debug green again.

  • platform/gtk/Skipped:
01:58 Changeset [61386] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-18 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Fix the namespace indent for HTML5Lexer. This patch changes
white-space only.

  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::): (WebCore::HTML5Lexer::lineNumber): (WebCore::HTML5Lexer::columnNumber): (WebCore::HTML5Lexer::state): (WebCore::HTML5Lexer::setState): (WebCore::HTML5Lexer::skipLeadingNewLineForListing): (WebCore::HTML5Lexer::InputStreamPreprocessor::InputStreamPreprocessor): (WebCore::HTML5Lexer::InputStreamPreprocessor::nextInputCharacter): (WebCore::HTML5Lexer::InputStreamPreprocessor::peek): (WebCore::HTML5Lexer::InputStreamPreprocessor::advance):
01:28 Changeset [61385] by ukai@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed test breakage fix.

WebSocket: resume should not process buffer if already processing.
https://bugs.webkit.org/show_bug.cgi?id=39340

MessageLoop runs in main thread, so we don't need to use timer in worker thread.
Also, we should not use Timer in worker thread.

  • websockets/ThreadableWebSocketChannelClientWrapper.h:

(WebCore::ThreadableWebSocketChannelClientWrapper::resume):
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):

00:22 QtWebKitWebGL edited by jarkko.j.sakkinen@gmail.com
(diff)
Note: See TracTimeline for information about the timeline view.