Timeline


and

06/23/10:

23:52 Changeset [61742] by abarth@webkit.org

2010-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out InitialMode of HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=41126

Transliterated from the spec. Currently doesn't do anything. Mostly
an experiment to see where this goes.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertDoctype): (WebCore::HTMLTreeBuilder::insertComment):
  • html/HTMLTreeBuilder.h:
23:50 Changeset [61741] by aestes@apple.com

Refactor beforeload layout tests to share a common implementation of
print() located in fast/dom/beforeload/resources/.
https://bugs.webkit.org/show_bug.cgi?id=41127

Reviewed by Joseph Pecoraro.

  • fast/dom/beforeload/flash-before-load.html:
  • fast/dom/beforeload/frame-before-load.html:
  • fast/dom/beforeload/image-before-load.html:
  • fast/dom/beforeload/link-before-load.html:
  • fast/dom/beforeload/pi-before-load.xhtml:
  • fast/dom/beforeload/remove-link-in-beforeload-listener.html:
  • fast/dom/beforeload/script-before-load-dynamic.html:
  • fast/dom/beforeload/script-before-load-xhtml.xhtml:
  • fast/dom/beforeload/script-before-load.html:
  • fast/dom/beforeload/video-before-load.html:
23:41 Changeset [61740] by abarth@webkit.org

2010-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add all the HTML5 tree builder insertion modes
https://bugs.webkit.org/show_bug.cgi?id=41124

These are just copied verbatim from the spec. No tests because these
don't do anything yet.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::):
23:30 Changeset [61739] by eric@webkit.org

2010-06-23 Eric Seidel <eric@webkit.org>

Unreviewed. Fix namespace indent. Just whitespace changes.

  • dom/DocumentParser.h: (WebCore::DocumentParser::~DocumentParser): (WebCore::DocumentParser::isExecutingScript): (WebCore::DocumentParser::stopParsing): (WebCore::DocumentParser::processingData): (WebCore::DocumentParser::wantsRawData): (WebCore::DocumentParser::writeRawData): (WebCore::DocumentParser::wellFormed): (WebCore::DocumentParser::lineNumber): (WebCore::DocumentParser::columnNumber): (WebCore::DocumentParser::executeScriptsWaitingForStylesheets): (WebCore::DocumentParser::htmlTreeBuilder): (WebCore::DocumentParser::asHTMLDocumentParser): (WebCore::DocumentParser::inViewSourceMode): (WebCore::DocumentParser::setInViewSourceMode): (WebCore::DocumentParser::document): (WebCore::DocumentParser::xssAuditor): (WebCore::DocumentParser::setXSSAuditor): (WebCore::DocumentParser::DocumentParser):
23:27 Changeset [61738] by eric@webkit.org

2010-06-23 Eric Seidel <eric@webkit.org>

Unreviewed. Speculative build fix for Qt.

Move Document* down onto DocumentParser, since every DocumentParser needs one.
https://bugs.webkit.org/show_bug.cgi?id=41117

XMLDocumentParserQt is a huge pile of donkey barf.
I can't believe I ever r+'d the creation of this pile of
copy/paste code.

I clearly missed removing m_doc from this code as well and thus
broke Qt.

We really need to fix both XMLDocumentParserLibxml2 and
XMLDocumentParserQt not to be so poorly abstracted so
that if we're going to have two of them they can at least
share some code.

  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::doEnd): (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::parseDtd):
23:17 Changeset [61737] by eric@webkit.org

2010-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move Document* down onto DocumentParser, since every DocumentParser needs one.
https://bugs.webkit.org/show_bug.cgi?id=41117

This eliminated the need for document() on HTMLDocumentParser.
This paves the way for more code sharing between various
DocumentParser subclasses.

  • dom/DocumentParser.h: (WebCore::DocumentParser::inViewSourceMode): (WebCore::DocumentParser::setInViewSourceMode): (WebCore::DocumentParser::document): (WebCore::DocumentParser::DocumentParser):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::isWMLDocument): (WebCore::XMLDocumentParser::pushCurrentNode): (WebCore::XMLDocumentParser::popCurrentNode): (WebCore::XMLDocumentParser::clearCurrentNodeStack): (WebCore::XMLDocumentParser::enterText): (WebCore::XMLDocumentParser::end): (WebCore::XMLDocumentParser::insertErrorMessageBlock):
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::internalSubset): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser):
  • html/HTMLDocumentParser.h:
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::LegacyHTMLDocumentParser): (WebCore::LegacyHTMLDocumentParser::begin): (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::scriptExecution): (WebCore::LegacyHTMLDocumentParser::parseTag): (WebCore::LegacyHTMLDocumentParser::continueProcessing): (WebCore::LegacyHTMLDocumentParser::willWriteHTML): (WebCore::LegacyHTMLDocumentParser::didWriteHTML): (WebCore::LegacyHTMLDocumentParser::write): (WebCore::LegacyHTMLDocumentParser::stopParsing): (WebCore::LegacyHTMLDocumentParser::timerFired): (WebCore::LegacyHTMLDocumentParser::end): (WebCore::LegacyHTMLDocumentParser::processToken): (WebCore::LegacyHTMLDocumentParser::processDoctypeToken): (WebCore::LegacyHTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsIfReady): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsTimerFired):
  • html/LegacyHTMLDocumentParser.h:
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::ImageDocumentParser): (WebCore::ImageDocumentParser::imageDocument): (WebCore::ImageDocumentParser::write): (WebCore::ImageDocumentParser::writeRawData): (WebCore::ImageDocumentParser::finish): (WebCore::ImageDocumentParser::finishWasCalled): (WebCore::ImageDocumentParser::isWaitingForScripts): (WebCore::ImageDocument::createParser):
  • loader/MediaDocument.cpp: (WebCore::MediaDocumentParser::MediaDocumentParser): (WebCore::MediaDocumentParser::createDocumentStructure): (WebCore::MediaDocumentParser::finish): (WebCore::MediaDocumentParser::finishWasCalled):
  • loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::PluginDocumentParser): (WebCore::PluginDocumentParser::createDocumentStructure): (WebCore::PluginDocumentParser::writeRawData): (WebCore::PluginDocumentParser::finish): (WebCore::PluginDocumentParser::finishWasCalled):
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::SinkDocumentParser):
  • loader/TextDocument.cpp: (WebCore::TextDocumentParser::TextDocumentParser): (WebCore::TextDocumentParser::write): (WebCore::TextDocumentParser::finish): (WebCore::TextDocumentParser::finishWasCalled):
23:14 Changeset [61736] by eric@webkit.org

2010-06-23 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Start to clean up DocumentParser interface
https://bugs.webkit.org/show_bug.cgi?id=41114

The first of many cleanups needed to the DocumentParser
interface. Rename executingScript() to isExecutingScript()
and make it return a bool instead of an int. Also added a
FIXME to XMLDocumentParser about implementing it and did
some minor other cleanup to the XMLDocumentParser header.

No functional change, thus no tests.

  • dom/Document.cpp: (WebCore::Document::open):
  • dom/DocumentParser.h: (WebCore::DocumentParser::isExecutingScript):
  • dom/XMLDocumentParser.h: (WebCore::XMLDocumentParser::wellFormed):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::isExecutingScript):
  • html/HTMLDocumentParser.h:
  • html/LegacyHTMLDocumentParser.h: (WebCore::LegacyHTMLDocumentParser::isExecutingScript):
22:50 Changeset [61735] by oliver@apple.com

Fix testcase.

Reviewed by Maciej Stachowiak.

Make the reparsing test use syntax that is actually valid.
The old parser had a bug that would lead to it accepting
invalid code in some cases.

  • fast/js/script-tests/reparsing-semicolon-insertion.js:

(commaTest):
(varCommaTest):
(constCommaTest):
(commaParenTest):
(commaParenThrowTest):

22:43 Changeset [61734] by mjs@apple.com

2010-06-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Simon Fraser.

Implement IDL attribute for HTML5 hidden
https://bugs.webkit.org/show_bug.cgi?id=41039

Test: fast/html/hidden-attr-dom.html

  • html/HTMLElement.idl: Just add to the IDL file. [Reflect] takes care of the rest.

2010-06-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Simon Fraser.

Implement IDL attribute for HTML5 hidden
https://bugs.webkit.org/show_bug.cgi?id=41039

Test cases.


  • fast/html/hidden-attr-dom.html: Added.
  • fast/html/hidden-attr-dom-expected.txt: Added.
  • fast/html/script-tests/hidden-attr-dom.js: Added.
21:22 Changeset [61733] by commit-queue@webkit.org

2010-06-23 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

[EFL] Add Libs.private to ewebkit.pc when building with SHARED_CORE.
https://bugs.webkit.org/show_bug.cgi?id=40862

  • CMakeListsEfl.txt:
  • efl/ewebkit.pc.in:
21:19 Changeset [61732] by oliver@apple.com

2010-06-23 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Custom-written JavaScript parser
https://bugs.webkit.org/show_bug.cgi?id=34019

Implement a recursive descent parser similar to that used by V8 and
SpiderMonkey. Greater than 2x improvement in SunSpider parsing tests.

The parser consists of a JSParser class that uses a TreeBuilder to actually
build the AST. There are currently two builders -- the ASTBuilder and
SyntaxChecker which separate the job of building an AST for code generation
and simply checking syntactic correctness.

There's still some less than ideal code remaining in the parser to allow
us to retain the existing lexing code with minimal changes. We'll tidy
this up at a later date.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • parser/ASTBuilder.h: Added. (JSC::ASTBuilder::BinaryOpInfo::BinaryOpInfo): (JSC::ASTBuilder::AssignmentInfo::AssignmentInfo): (JSC::ASTBuilder::ASTBuilder): (JSC::ASTBuilder::createSourceElements): (JSC::ASTBuilder::varDeclarations): (JSC::ASTBuilder::funcDeclarations): (JSC::ASTBuilder::features): (JSC::ASTBuilder::numConstants): (JSC::ASTBuilder::appendToComma): (JSC::ASTBuilder::createCommaExpr): (JSC::ASTBuilder::createLogicalNot): (JSC::ASTBuilder::createUnaryPlus): (JSC::ASTBuilder::createVoid): (JSC::ASTBuilder::thisExpr): (JSC::ASTBuilder::createResolve): (JSC::ASTBuilder::createObjectLiteral): (JSC::ASTBuilder::createArray): (JSC::ASTBuilder::createNumberExpr): (JSC::ASTBuilder::createString): (JSC::ASTBuilder::createBoolean): (JSC::ASTBuilder::createNull): (JSC::ASTBuilder::createBracketAccess): (JSC::ASTBuilder::createDotAccess): (JSC::ASTBuilder::createRegex): (JSC::ASTBuilder::createNewExpr): (JSC::ASTBuilder::createConditionalExpr): (JSC::ASTBuilder::createAssignResolve): (JSC::ASTBuilder::createFunctionExpr): (JSC::ASTBuilder::createFunctionBody): (JSC::ASTBuilder::createGetterOrSetterProperty): (JSC::ASTBuilder::createArguments): (JSC::ASTBuilder::createArgumentsList): (JSC::ASTBuilder::createProperty): (JSC::ASTBuilder::createPropertyList): (JSC::ASTBuilder::createElementList): (JSC::ASTBuilder::createFormalParameterList): (JSC::ASTBuilder::createClause): (JSC::ASTBuilder::createClauseList): (JSC::ASTBuilder::setUsesArguments): (JSC::ASTBuilder::createFuncDeclStatement): (JSC::ASTBuilder::createBlockStatement): (JSC::ASTBuilder::createExprStatement): (JSC::ASTBuilder::createIfStatement): (JSC::ASTBuilder::createForLoop): (JSC::ASTBuilder::createForInLoop): (JSC::ASTBuilder::createEmptyStatement): (JSC::ASTBuilder::createVarStatement): (JSC::ASTBuilder::createReturnStatement): (JSC::ASTBuilder::createBreakStatement): (JSC::ASTBuilder::createContinueStatement): (JSC::ASTBuilder::createTryStatement): (JSC::ASTBuilder::createSwitchStatement): (JSC::ASTBuilder::createWhileStatement): (JSC::ASTBuilder::createDoWhileStatement): (JSC::ASTBuilder::createLabelStatement): (JSC::ASTBuilder::createWithStatement): (JSC::ASTBuilder::createThrowStatement): (JSC::ASTBuilder::createDebugger): (JSC::ASTBuilder::createConstStatement): (JSC::ASTBuilder::appendConstDecl): (JSC::ASTBuilder::appendStatement): (JSC::ASTBuilder::addVar): (JSC::ASTBuilder::combineCommaNodes): (JSC::ASTBuilder::evalCount): (JSC::ASTBuilder::appendBinaryExpressionInfo): (JSC::ASTBuilder::operatorStackPop): (JSC::ASTBuilder::operatorStackHasHigherPrecedence): (JSC::ASTBuilder::getFromOperandStack): (JSC::ASTBuilder::shrinkOperandStackBy): (JSC::ASTBuilder::appendBinaryOperation): (JSC::ASTBuilder::operatorStackAppend): (JSC::ASTBuilder::popOperandStack): (JSC::ASTBuilder::appendUnaryToken): (JSC::ASTBuilder::unaryTokenStackLastType): (JSC::ASTBuilder::unaryTokenStackLastStart): (JSC::ASTBuilder::unaryTokenStackRemoveLast): (JSC::ASTBuilder::assignmentStackAppend): (JSC::ASTBuilder::createAssignment): (JSC::ASTBuilder::Scope::Scope): (JSC::ASTBuilder::setExceptionLocation): (JSC::ASTBuilder::incConstants): (JSC::ASTBuilder::usesThis): (JSC::ASTBuilder::usesCatch): (JSC::ASTBuilder::usesClosures): (JSC::ASTBuilder::usesArguments): (JSC::ASTBuilder::usesAssignment): (JSC::ASTBuilder::usesWith): (JSC::ASTBuilder::usesEval): (JSC::ASTBuilder::createNumber): (JSC::ASTBuilder::makeTypeOfNode): (JSC::ASTBuilder::makeDeleteNode): (JSC::ASTBuilder::makeNegateNode): (JSC::ASTBuilder::makeBitwiseNotNode): (JSC::ASTBuilder::makeMultNode): (JSC::ASTBuilder::makeDivNode): (JSC::ASTBuilder::makeAddNode): (JSC::ASTBuilder::makeSubNode): (JSC::ASTBuilder::makeLeftShiftNode): (JSC::ASTBuilder::makeRightShiftNode): (JSC::ASTBuilder::makeFunctionCallNode): (JSC::ASTBuilder::makeBinaryNode): (JSC::ASTBuilder::makeAssignNode): (JSC::ASTBuilder::makePrefixNode): (JSC::ASTBuilder::makePostfixNode):
  • parser/JSParser.cpp: Added. (JSC::JSParser::AllowInOverride::AllowInOverride): (JSC::JSParser::AllowInOverride::~AllowInOverride): (JSC::JSParser::token): (JSC::JSParser::next): (JSC::JSParser::consume): (JSC::JSParser::match): (JSC::JSParser::tokenStart): (JSC::JSParser::tokenLine): (JSC::JSParser::tokenEnd): (JSC::JSParser::): (JSC::JSParser::autoSemiColon): (JSC::JSParser::canRecurse): (JSC::JSParser::lastTokenEnd): (JSC::jsParse): (JSC::JSParser::JSParser): (JSC::JSParser::parseProgram): (JSC::JSParser::allowAutomaticSemicolon): (JSC::JSParser::parseSourceElements): (JSC::JSParser::parseVarDeclaration): (JSC::JSParser::parseConstDeclaration): (JSC::JSParser::parseDoWhileStatement): (JSC::JSParser::parseWhileStatement): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseForStatement): (JSC::JSParser::parseBreakStatement): (JSC::JSParser::parseContinueStatement): (JSC::JSParser::parseReturnStatement): (JSC::JSParser::parseThrowStatement): (JSC::JSParser::parseWithStatement): (JSC::JSParser::parseSwitchStatement): (JSC::JSParser::parseSwitchClauses): (JSC::JSParser::parseSwitchDefaultClause): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseDebuggerStatement): (JSC::JSParser::parseBlockStatement): (JSC::JSParser::parseStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionBody): (JSC::JSParser::parseFunctionInfo): (JSC::JSParser::parseFunctionDeclaration): (JSC::JSParser::parseExpressionOrLabelStatement): (JSC::JSParser::parseExpressionStatement): (JSC::JSParser::parseIfStatement): (JSC::JSParser::parseExpression): (JSC::JSParser::parseAssignmentExpression): (JSC::JSParser::parseConditionalExpression): (JSC::isUnaryOp): (JSC::JSParser::isBinaryOperator): (JSC::JSParser::parseBinaryExpression): (JSC::JSParser::parseProperty): (JSC::JSParser::parseObjectLiteral): (JSC::JSParser::parseArrayLiteral): (JSC::JSParser::parsePrimaryExpression): (JSC::JSParser::parseArguments): (JSC::JSParser::parseMemberExpression): (JSC::JSParser::parseUnaryExpression):
  • parser/JSParser.h: Added. (JSC::): (JSC::JSTokenInfo::JSTokenInfo):
  • parser/Lexer.cpp: (JSC::Lexer::lex):
  • parser/Lexer.h: (JSC::Lexer::setLastLineNumber): (JSC::Lexer::lastLineNumber):
  • parser/NodeConstructors.h: (JSC::Node::Node):
  • parser/Parser.cpp: (JSC::Parser::parse):
  • parser/SyntaxChecker.h: Added. (JSC::SyntaxChecker::SyntaxChecker): (JSC::SyntaxChecker::createSourceElements): (JSC::SyntaxChecker::makeFunctionCallNode): (JSC::SyntaxChecker::appendToComma): (JSC::SyntaxChecker::createCommaExpr): (JSC::SyntaxChecker::makeAssignNode): (JSC::SyntaxChecker::makePrefixNode): (JSC::SyntaxChecker::makePostfixNode): (JSC::SyntaxChecker::makeTypeOfNode): (JSC::SyntaxChecker::makeDeleteNode): (JSC::SyntaxChecker::makeNegateNode): (JSC::SyntaxChecker::makeBitwiseNotNode): (JSC::SyntaxChecker::createLogicalNot): (JSC::SyntaxChecker::createUnaryPlus): (JSC::SyntaxChecker::createVoid): (JSC::SyntaxChecker::thisExpr): (JSC::SyntaxChecker::createResolve): (JSC::SyntaxChecker::createObjectLiteral): (JSC::SyntaxChecker::createArray): (JSC::SyntaxChecker::createNumberExpr): (JSC::SyntaxChecker::createString): (JSC::SyntaxChecker::createBoolean): (JSC::SyntaxChecker::createNull): (JSC::SyntaxChecker::createBracketAccess): (JSC::SyntaxChecker::createDotAccess): (JSC::SyntaxChecker::createRegex): (JSC::SyntaxChecker::createNewExpr): (JSC::SyntaxChecker::createConditionalExpr): (JSC::SyntaxChecker::createAssignResolve): (JSC::SyntaxChecker::createFunctionExpr): (JSC::SyntaxChecker::createFunctionBody): (JSC::SyntaxChecker::createArguments): (JSC::SyntaxChecker::createArgumentsList): (JSC::SyntaxChecker::createProperty): (JSC::SyntaxChecker::createPropertyList): (JSC::SyntaxChecker::createElementList): (JSC::SyntaxChecker::createFormalParameterList): (JSC::SyntaxChecker::createClause): (JSC::SyntaxChecker::createClauseList): (JSC::SyntaxChecker::setUsesArguments): (JSC::SyntaxChecker::createFuncDeclStatement): (JSC::SyntaxChecker::createBlockStatement): (JSC::SyntaxChecker::createExprStatement): (JSC::SyntaxChecker::createIfStatement): (JSC::SyntaxChecker::createForLoop): (JSC::SyntaxChecker::createForInLoop): (JSC::SyntaxChecker::createEmptyStatement): (JSC::SyntaxChecker::createVarStatement): (JSC::SyntaxChecker::createReturnStatement): (JSC::SyntaxChecker::createBreakStatement): (JSC::SyntaxChecker::createContinueStatement): (JSC::SyntaxChecker::createTryStatement): (JSC::SyntaxChecker::createSwitchStatement): (JSC::SyntaxChecker::createWhileStatement): (JSC::SyntaxChecker::createWithStatement): (JSC::SyntaxChecker::createDoWhileStatement): (JSC::SyntaxChecker::createLabelStatement): (JSC::SyntaxChecker::createThrowStatement): (JSC::SyntaxChecker::createDebugger): (JSC::SyntaxChecker::createConstStatement): (JSC::SyntaxChecker::appendConstDecl): (JSC::SyntaxChecker::createGetterOrSetterProperty): (JSC::SyntaxChecker::appendStatement): (JSC::SyntaxChecker::addVar): (JSC::SyntaxChecker::combineCommaNodes): (JSC::SyntaxChecker::evalCount): (JSC::SyntaxChecker::appendBinaryExpressionInfo): (JSC::SyntaxChecker::operatorStackPop):
  • runtime/JSGlobalData.h:
  • wtf/Platform.h:
  • wtf/ThreadSpecific.h: (WTF::T):
20:25 Changeset [61731] by tony@chromium.org

2010-06-23 Tony Chang <tony@chromium.org>

Not reviewed, fixing gtk/qt tests

skip http/tests/multipart/policy-ignore-crash.php on qt and gtk
https://bugs.webkit.org/show_bug.cgi?id=41128

Their network libraries appear to be more strict about identifying
multipart boundaries.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
20:18 Changeset [61730] by commit-queue@webkit.org

2010-06-23 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] nameFromChildren is obsolete
https://bugs.webkit.org/show_bug.cgi?id=36128

Added new tests, based on a previous patch by Joanmarie Diggs.

  • platform/gtk/accessibility/name-from-label-expected.txt: Added.
  • platform/gtk/accessibility/name-from-label.html: Added.

2010-06-23 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Chris Fleizach.

[Gtk] nameFromChildren is obsolete
https://bugs.webkit.org/show_bug.cgi?id=36128

Look to the AtkText interface implemented by the objects in
question.

Test: platform/gtk/accessibility/name-from-label.html

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_table_get_column_description): (webkit_accessible_table_get_row_description):
19:55 Changeset [61729] by commit-queue@webkit.org

2010-06-23 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port FileSystem
https://bugs.webkit.org/show_bug.cgi?id=34323

Port FileSystem with IFileMgr interface.

  • platform/FileSystem.h:
  • platform/brew/FileSystemBrew.cpp: Added. (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::pathByAppendingComponent): (WebCore::fileSystemRepresentation): (WebCore::canonicalPath): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath): (WebCore::pathGetFileName): (WebCore::directoryName): (WebCore::openTemporaryFile): (WebCore::closeFile): (WebCore::writeToFile): (WebCore::unloadModule): (WebCore::listDirectory):
19:54 Changeset [61728] by tony@chromium.org

2010-06-23 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

layout test for a crash in chromium multipart request handling
https://bugs.webkit.org/show_bug.cgi?id=41050

  • http/tests/multipart/policy-ignore-crash-expected.txt: Copied from LayoutTests/editing/pasteboard/copy-crash-with-extraneous-attribute-expected.txt.
  • http/tests/multipart/policy-ignore-crash.php: Added.
  • platform/mac/Skipped:

2010-06-23 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

layout test for a crash in chromium multipart request handling
https://bugs.webkit.org/show_bug.cgi?id=41050

Also roll DEPS to pick up the crash fix.

  • DEPS:
19:21 Changeset [61727] by laszlo.1.gombos@nokia.com

2010-06-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, Symbian build fix.

[Qt] Update the def file after r61478.

  • symbian/eabi/QtWebKitu.def:
18:49 Changeset [61726] by commit-queue@webkit.org

2010-06-23 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Optimization of the QScriptValuePrivate.

Patch change only internals of the QScriptValuePrivate.
Most of the QScriptValuePrivate's attributes were moved
into an union.

[Qt] Optimization of the QScriptVAluePrivate.
https://bugs.webkit.org/show_bug.cgi?id=40415

  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::globalObject):
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::~QScriptValuePrivate): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toObject): (QScriptValuePrivate::equals): (QScriptValuePrivate::strictlyEquals): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::operator JSValueRef): (QScriptValuePrivate::operator JSObjectRef): (QScriptValuePrivate::refinedJSValue):
18:39 Changeset [61725] by andersca@apple.com

2010-06-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Have the UI process compute the plug-in data
https://bugs.webkit.org/show_bug.cgi?id=41118

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: (WebProcessProxyMessage::): Add GetPlugin message kind.
  • Shared/WebCoreArgumentCoders.h: Add argument coders for PluginInfo and MimeClassInfo.


  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::safeCreateCFString): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::getPluginInfo): Use safeCreateCFString.


  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getPlugins): Ask the plug-in info store for the plug-in list.

(WebKit::WebProcessProxy::didReceiveSyncMessage):
Handle GetPlugins.

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::objectContentType): Implement.
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::populatePluginCache): Send a sync GetPlugins message.
18:33 Changeset [61724] by commit-queue@webkit.org

2010-06-23 Alexendar Pavlov <apavlov@chromium.org>

Reviewed by David Hyatt.

Swap checks in Position::isCandidate so that the less expensive
nodeIsUserSelectNode (node && node->renderer() &&
node->renderer()->style()->userSelect() == SELECT_NONE) came first.

(Was Web Inspector: Hangup when expanding elements with enormous
text node content in Elements panel).

https://bugs.webkit.org/show_bug.cgi?id=35926

  • dom/Position.cpp: (WebCore::Position::isCandidate):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
18:02 Changeset [61723] by kevino@webkit.org

[wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.

17:33 Changeset [61722] by commit-queue@webkit.org

2010-06-23 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Add PopupMenu implementation
https://bugs.webkit.org/show_bug.cgi?id=40226

Delegate PopupMenu handling to ChromeClientBrew.

  • page/brew/ChromeClientBrew.h: Added.
  • platform/PopupMenu.h:
  • platform/brew/PopupMenuBrew.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
17:29 Changeset [61721] by aestes@apple.com

<rdar://problem/8107855> Test that removing an object element with an
invalid data URL in a listener to its beforeload event does not crash
WebCore.
https://bugs.webkit.org/show_bug.cgi?id=41054

Reviewed by Alexey Proskuryakov.

  • fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-bad-object-in-beforeload-listener.html: Added.
  • fast/dom/beforeload/resources/print.js: Added.

(print):

17:23 Changeset [61720] by andersca@apple.com

Add ArgumentCoder for vectors.

Reviewed by Dan Bernstein.

  • Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::):

17:18 Changeset [61719] by andersca@apple.com

Rename WebCoreTypeArgumentMarshalling.h to WebCoreArgumentCoders.h

Reviewed by Dan Bernstein.

  • Shared/WebCoreArgumentCoders.h: Copied from Shared/WebCoreTypeArgumentMarshalling.h.
  • Shared/WebCoreTypeArgumentMarshalling.h: Removed.
  • Shared/WebEvent.h:
  • Shared/WebNavigationDataStore.h:
  • Shared/WebPreferencesStore.h:
  • Shared/mac/UpdateChunk.cpp:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebPageProxy.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebProcess.cpp:
17:12 Changeset [61718] by andersca@apple.com

2010-06-23 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

MessageIDs should always have the most significant bit zeroed out
https://bugs.webkit.org/show_bug.cgi?id=41112

The most significant bit is used by the Mac implementation of CoreIPC, and
should always be zero in MessageID objects.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForMessage):
  • Platform/CoreIPC/MessageID.h: (CoreIPC::MessageID::): (CoreIPC::MessageID::MessageID): (CoreIPC::MessageID::operator==): (CoreIPC::MessageID::fromInt): (CoreIPC::MessageID::isSync): (CoreIPC::MessageID::stripMostSignificantBit):
  • Platform/CoreIPC/mac/ConnectionMac.cpp: (CoreIPC::Connection::sendOutgoingMessage): (CoreIPC::createArgumentDecoder):
16:29 Changeset [61717] by sullivan@apple.com
  • mac/WebKit2.exp:

Added yet another symbol needed by Mac clients.

Rubber-stamped by Anders Carlsson.

16:25 Changeset [61716] by sullivan@apple.com
  • mac/WebKit2.exp:

Added another symbol needed by Mac clients.

Rubber-stamped by Anders Carlsson.

16:22 Changeset [61715] by kbr@google.com

2010-06-23 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Implement format conversions in texImage2D and texSubImage2D taking HTML data
https://bugs.webkit.org/show_bug.cgi?id=40319

Generalized code supporting premultiplication of alpha and
vertical flip to pack texture data into requested format and type.
Handled incoming image data of various formats, RGBA and BGRA in
particular, both to reduce the number of temporary copies during
texture upload and to support premultiplying alpha for the
texImage2D and texSubImage2D entry points taking ArrayBufferView
in a subsequent bug. Added test case exercising all combinations
of format/type combinations, premultiplication of alpha, and
Image/ImageData upload. (Incorporated pnglib.js under
fast/canvas/webgl/resources/ to be able to generate Image elements
programmatically.) Tested in Safari on Mac OS X and in Chromium on
Mac OS X, Windows and Linux.

Test: fast/canvas/webgl/tex-image-with-format-and-type.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2DImpl): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2DImpl): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType): (WebCore::WebGLRenderingContext::validateTexFuncParameters):
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::computeFormatAndTypeParameters): (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::flipVertically): (WebCore::doUnpackingAndPacking): (WebCore::doPacking): (WebCore::GraphicsContext3D::packPixels):
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::narrowInternalFormat): (WebCore::GraphicsContext3D::texImage2D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):

2010-06-23 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Implement format conversions in texImage2D and texSubImage2D taking HTML data
https://bugs.webkit.org/show_bug.cgi?id=40319

Generalized code supporting premultiplication of alpha and
vertical flip to pack texture data into requested format and type.
Handled incoming image data of various formats, RGBA and BGRA in
particular, both to reduce the number of temporary copies during
texture upload and to support premultiplying alpha for the
texImage2D and texSubImage2D entry points taking ArrayBufferView
in a subsequent bug. Added test case exercising all combinations
of format/type combinations, premultiplication of alpha, and
Image/ImageData upload. (Incorporated pnglib.js under
fast/canvas/webgl/resources/ to be able to generate Image elements
programmatically.) Tested in Safari on Mac OS X and in Chromium on
Mac OS X, Windows and Linux.

Test: fast/canvas/webgl/tex-image-with-format-and-type.html

  • fast/canvas/webgl/resources/pnglib.js: Added. (): (.):
  • fast/canvas/webgl/tex-image-with-format-and-type-expected.txt: Added.
  • fast/canvas/webgl/tex-image-with-format-and-type.html: Added.
16:19 Changeset [61714] by senorblanco@chromium.org

2010-06-23 Stephen White <senorblanco@chromium.org>

Unreviewed; correcting bad patch.

In my haste to land r61710, I mistakenly landed the wrong version, in
which a chunk of code was moved. This patch moves that chunk of code
to where it was in the patch that was reviewed. Mea culpa.

  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
16:14 Changeset [61713] by hclam@chromium.org

Unreviewed. Build fix.

Adding test expectation since a test introduced r61607 has not test results.

  • platform/chromium/test_expectations.txt:
15:27 Changeset [61712] by commit-queue@webkit.org

2010-06-23 Kwang Yul Seo <skyul@company100.net>

Reviewed by Oliver Hunt.

[GTK] Implement ThreadSpecific with glib
https://bugs.webkit.org/show_bug.cgi?id=39829

Implement ThreadSpecific with glib's GStaticPrivate.
This patch makes it possible to build GTK port without pthread.

  • wtf/ThreadSpecific.h: (WTF::::ThreadSpecific): (WTF::::~ThreadSpecific): (WTF::::get): (WTF::::set): (WTF::::destroy):
15:18 Changeset [61711] by jschuh@chromium.org

Unreviewed, fixing ChangeLog entry for http://trac.webkit.org/changeset/61709

14:52 Changeset [61710] by senorblanco@chromium.org

2010-06-23 Stephen White <senorblanco@chromium.org>

Reviewed by David Hyatt.

This is a tweak to the resize algorithm introduced in r61341, and
is a fix for the regression described in
https://bugs.webkit.org/show_bug.cgi?id=41036

The goal is to bring back the some of old behaviour, without regressing
too much of the performance gains in r61341.

The old algorithm was:

  • on first resize, draw in high quality and record the paint time
  • if we've already drawn at this size, use the same quality as last time
  • on subsequent resizes, if the resize occurs within X ms of the previous one, draw at low quality and set a timer (one timer per image).
  • when each timer expires, draw that image at high quality

The r61341 algorithm was:

  • on first resize, draw the image in low quality, add it to a list of resized images, and set a timer (one timer for all images)
  • when the timer expires, redraw all resized images in high quality

The new algorithm is:

  • on first resize, if no other animated resizes are outstanding, draw in high quality and set the timer (one timer for all images)
  • if any images have been resized to two different sizes in the last X ms, draw all resized images in low quality and kick the timer forward
  • when the timer expires, if any animated resizes occured, redraw all resized images in high quality, and reset the flag

This should cause GUIMark and the IE9 demos to have good performance
after the first frame, while other pages with only static resizes
should be unaffected.

  • rendering/RenderBoxModelObject.cpp: Change the LastPaintTimeMap to a LastPaintSizeMap: we now record the last size an image was resized to, rather than the time it was painted (the time actually became redundant in r61341 when I added the check for m_timer.isActive(): we only care if anything is resizing while the timer is active). (WebCore::ImageQualityController::ImageQualityController): Add an initializer for the m_animatedResizeIsActive flag. (WebCore::ImageQualityController::objectDestroyed): Reset the m_animatedResizeIsActive flag if this was the last object in the list. (WebCore::ImageQualityController::highQualityRepaintTimerFired): Only repaint all the images if there was an animated resize (otherwise, everything is already high quality). (WebCore::ImageQualityController::shouldPaintAtLowQuality): Implement the above algorithm.

2010-06-23 Stephen White <senorblanco@chromium.org>

Reviewed by David Hyatt.

Temporarily put the tests broken by the resize change into
test_expectations.txt.
https://bugs.webkit.org/show_bug.cgi?id=41036

  • platform/chromium/test_expectations.txt:
14:34 Changeset [61709] by jschuh@chromium.org

2010-06-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Kenneth Rohde Christiansen.

Firing the onchange event on select which changes its size > 1 causes the select
object to change from a menulist to a listbox. However, when propogating the events,
we do a bad cast assuming the object will remain a menulist. Added proper checks to
make sure we check the renderer after the onchange is fired and propogate the event
based on correct object type.
https://bugs.webkit.org/show_bug.cgi?id=40828

Test: fast/events/select-onchange-crash.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::setSelectedIndex):

2010-06-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Kenneth Rohde Christiansen.

Tests that we do not crash when onchange handler changes the select from a menu list to a list box.
https://bugs.webkit.org/show_bug.cgi?id=40828

  • fast/events/select-onchange-crash-expected.txt: Added.
  • fast/events/select-onchange-crash.html: Added.
14:25 BuildingQtOnSymbian edited by laszlo.1.gombos@nokia.com
CONFIG-=def_files should be used for trunk builds (diff)
13:07 Changeset [61708] by leandro@webkit.org

2010-06-23 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add support to CPack (to generate source tarballs)
https://bugs.webkit.org/show_bug.cgi?id=41009


  • CMakeLists.txt:
  • cmake/OptionsEfl.cmake: Define the default source generator for the EFL port.
  • cmake/WebKitPackaging.cmake: Added. This file filters the source files so that only files relevant to the selected port are included in the source tarball. See comments for details.
13:03 Changeset [61707] by aestes@apple.com

<rdar://problem/8107855> Prevent a crash in WebCore when removing an
object element with an invalid data URL in in a listener to its
beforeload event.
https://bugs.webkit.org/show_bug.cgi?id=41054

Reviewed by Alexey Proskuryakov.

Tests: fast/dom/beforeload/remove-bad-object-in-beforeload-listener.html

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderFallbackContent): Exit early if the
object element is not in the document.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::updateWidget): If RenderWidget::destroy()
was called during processing of onbeforeload, do not proceed with loading
the object.

12:39 Changeset [61706] by leandro@webkit.org

2010-06-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add implementaion of new windows for EFL port. Both cases of a link
with target="_blank" and a javascript that does window.open() are
treated, delegating to browser the role of actually creating the
window (or blocking it).
https://bugs.webkit.org/show_bug.cgi?id=40930

  • CMakeListsEfl.txt: add new file that wraps the WindowFeatures struct
  • efl/WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::createWindow): implement method for creating new window by delegating to browser its creation. Browser might decide to continue on the same window by returning the same view object.
  • efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchCreatePage): implement method for creating new window when its creation is done by a javascript script.
  • efl/ewk/EWebKit.h: new header for WindowFeatures.
  • efl/ewk/ewk_private.h:
  • efl/ewk/ewk_view.cpp: (ewk_view_window_create): call the method implemented by browser.
  • efl/ewk/ewk_view.h:
  • efl/ewk/ewk_window_features.cpp: Added. (ewk_window_features_unref): (ewk_window_features_ref): (ewk_window_features_bool_property_get): (ewk_window_features_int_property_get): (ewk_window_features_new_from_core): create and wrapped struct containing the core struct.
  • efl/ewk/ewk_window_features.h: Added.
12:32 Changeset [61705] by andersca@apple.com

Rename SimpleArgumentCoder.h to ArgumentCoders.h

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h: Copied from Platform/CoreIPC/SimpleArgumentCoder.h.
  • Platform/CoreIPC/SimpleArgumentCoder.h: Removed.
  • Shared/WebCoreTypeArgumentMarshalling.h:
  • WebKit2.xcodeproj/project.pbxproj:
12:08 Changeset [61704] by ap@apple.com

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=41083
fast/parser/broken-comments-vs-parsing mode no linger tests for what it used to test

  • fast/parser/broken-comments-vs-parsing-mode.html: Moved broken comment to a place where it doesn't affect output.
11:42 Changeset [61703] by kov@webkit.org

2010-06-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[gtk] web fonts not loaded properly in scribd html5 reader
https://bugs.webkit.org/show_bug.cgi?id=38758

Drop filling the pattern with default values, because this
restricts the matching more than we want.

  • platform/graphics/cairo/FontCacheCairo.cpp: (WebCore::FontCache::createFontPlatformData):
11:41 Changeset [61702] by andersca@apple.com

2010-06-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add a plug-in info cache to WebPlatformStrategies
https://bugs.webkit.org/show_bug.cgi?id=41087

This is in preparation for proxying the getPlugins call over to the UI process.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::WebPlatformStrategies): (WebKit::WebPlatformStrategies::populatePluginCache): (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
11:23 Changeset [61701] by kov@webkit.org

2010-06-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[gtk] web fonts not loaded properly in scribd html5 reader
https://bugs.webkit.org/show_bug.cgi?id=38758

Also special-case sans' amd mono', which are aliases commonly
used in GTK+ applications.

  • platform/graphics/cairo/FontCacheCairo.cpp: (WebCore::isWellKnownFontName):
11:17 Changeset [61700] by weinig@apple.com

Stop silently ignoring crashes.

Reviewed by John Sullivan.

  • WebProcess/Launching/mac/WebProcessMain.mm:
10:58 Changeset [61699] by jschuh@chromium.org

2010-06-23 Justin Schuh <jschuh@chromium.org>

Unreviewed, rolling out r61695.
http://trac.webkit.org/changeset/61695
https://bugs.webkit.org/show_bug.cgi?id=40798

61695 broke all the Linux builds.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable):

2010-06-23 Justin Schuh <jschuh@chromium.org>

Unreviewed, rolling out r61695.
http://trac.webkit.org/changeset/61695
https://bugs.webkit.org/show_bug.cgi?id=40798

61695 broke all the Linux builds

  • fast/images/png-extra-row-crash-expected.txt: Removed.
  • fast/images/png-extra-row-crash.html: Removed.
  • fast/images/resources/png-extra-row-crash.png: Removed.
10:53 Changeset [61698] by weinig@apple.com

Add missing include to WKRetainPtr.

Reviewed by Anders Carlsson.

  • UIProcess/API/cpp/WKRetainPtr.h:
10:52 Changeset [61697] by kevino@webkit.org

Reviewed by Darin Adler.

Fix PluginViewNone.cpp compilation for ports that also compile PluginView.cpp
https://bugs.webkit.org/show_bug.cgi?id=37939

10:51 Changeset [61696] by jamesr@google.com

2010-06-23 James Robinson <jamesr@chromium.org>

Unreviewed. Add qt baseline due to port specific formatting differences for SVG rects
https://bugs.webkit.org/show_bug.cgi?id=40366

  • platform/qt/fast/repaint/svg-layout-root-style-attr-update-expected.txt: Added.
10:25 Changeset [61695] by jschuh@chromium.org

2010-06-23 Cris Neckar <cdn@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Out of bounds write in WebCore::PNGImageDecoder::rowAvailable
https://bugs.webkit.org/show_bug.cgi?id=40798

Catches error in row callback for libPNG when extra rows are returned.

Test: fast/images/png-extra-row-crash.html

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable):

2010-06-23 Cris Neckar <cdn@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Out of bounds write in WebCore::PNGImageDecoder::rowAvailable
https://bugs.webkit.org/show_bug.cgi?id=40798

Tests a PNG with an extra row.

  • fast/images/png-extra-row-crash-expected.txt: Added.
  • fast/images/png-extra-row-crash.html: Added.
  • fast/images/resources/png-extra-row-crash.png: Added.
10:21 Changeset [61694] by jamesr@google.com

2010-06-23 James Robinson <jamesr@chromium.org>

Unreviewed. Add my IRC handle to committers.py so the sheriffbot can yell at me.

  • Scripts/webkitpy/common/config/committers.py:
09:56 Changeset [61693] by jamesr@google.com

2010-06-23 James Robinson <jamesr@chromium.org>

Reviewed by Dan Bernstein.

Do not set needsLayout when the style attribute changes on an SVG element
https://bugs.webkit.org/show_bug.cgi?id=40366

SVGSVGElement::svgAttributeChanged was incorrectly calling renderer()->setNeedsLayout(true)
whenever the styleAttr changed on its element. This could happen during layout in some
circumstances due to lazy style attribute synchronization. When it did, it could cause the
layout flags to become inconsistent. See the test case for details.

Changes to an element's style attribute always mark an element as needing layout anyway so
this call was redundant.

Test: fast/repaint/svg-layout-root-style-attr-update.html

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isKnownAttribute):

2010-06-23 James Robinson <jamesr@chromium.org>

Reviewed by Dan Bernstein.

Do not set needsLayout when the style attribute changes on an SVG element
https://bugs.webkit.org/show_bug.cgi?id=40366

Tests that setting the style attribute on an SVG element does not cause
the render tree's layout flags to go haywire. The details are involved,
please see the bug and test case for details.

  • fast/repaint/svg-layout-root-style-attr-update-expected.checksum: Added.
  • fast/repaint/svg-layout-root-style-attr-update-expected.png: Added.
  • fast/repaint/svg-layout-root-style-attr-update-expected.txt: Added.
  • fast/repaint/svg-layout-root-style-attr-update.html: Added.
09:18 Changeset [61692] by simon.fraser@apple.com

2010-06-23 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

r61215 broke Acid3
https://bugs.webkit.org/show_bug.cgi?id=41034

The code added in r61215, which tests whether the root renderer will fill
the entire viewport, should not run for subframes. So bail from
RenderView::paintBoxDecorations() if document()->ownerElement() is not null.
The old code was trying to do this by checking 'elt', but that ends up as
null after the for loop above.

We can also bail early if the is no FrameView().

Test: fast/frames/paint-iframe-background.html

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
09:17 Changeset [61691] by pfeldman@chromium.org

2010-06-23 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not reset profiles panel on navigation.

https://bugs.webkit.org/show_bug.cgi?id=41068

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::resetProfilesPanel):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.populateInterface): (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): (WebInspector.ProfilesPanel.prototype._reset): (WebInspector.ProfilesPanel.prototype._clearProfiles):
  • inspector/front-end/inspector.js: (WebInspector.resetProfilesPanel):
09:11 Changeset [61690] by tkent@chromium.org

2010-06-23 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Correct Chromium test configuration
https://bugs.webkit.org/show_bug.cgi?id=41057

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
    • Add "--use-drt" option for NRWT. It is required for Chromium and ignored for other platforms.
    • Skip JSC test on Chromium
  • BuildSlaveSupport/test-result-archive: Add Chromium support.
09:06 Changeset [61689] by weinig@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
WebKit2: Flesh out more of the InjectedBundle client API

Reviewed by Anders Carlsson.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::willDestroyPage):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundlePageClient.cpp:

(WebKit::InjectedBundlePageClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageClient::didReceiveTitleForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageClient.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load): Add some error logging on failure to load the bundle.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):

  • mac/WebKit2.exp:

WebKitTools:

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didStartProvisionalLoadForFrame):
(_didReceiveServerRedirectForProvisionalLoadForFrame):
(_didFailProvisionalLoadWithErrorForFrame):
(_didCommitLoadForFrame):
(_didFinishLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didReceiveTitleForFrame):
(_didClearWindowForFrame):
(_didCreatePage):
(_willDestroyPage):
(WKBundleInitialize):

08:34 Changeset [61688] by yurys@chromium.org

2010-06-23 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: InspectorController should be added only once as ScriptDebugListener to
ScriptDebugServer.
https://bugs.webkit.org/show_bug.cgi?id=41070

  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::enableDebuggerFromFrontend):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): don't call InspectorBackend.enableDebugger if debugger is always enabled, InspectorController will do this on its side when the front end is connected.
08:01 Changeset [61687] by yurys@chromium.org

2010-06-23 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Clear breakpoints before restoring them, not after.
https://bugs.webkit.org/show_bug.cgi?id=41071

  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableDebuggerFromFrontend):
07:11 Changeset [61686] by benjamin.poulain@nokia.com

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

Reviewed by Kenneth Rohde Christiansen.

Do not render the full frame when there is some elements with fixed positioning
https://bugs.webkit.org/show_bug.cgi?id=33150

The frame view take into acount the list of fixed object when scrolling
the view. If the number of object is lower than a certain threshold, the pixel
are blitted, and the invalidated area updated.

  • page/FrameView.cpp:

(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):
(WebCore::FrameView::scrollContentsFastPath):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::scrollContentsFastPath):

  • platform/ScrollView.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::repaintRectIncludingDescendants):

  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):

07:01 Changeset [61685] by leandro@webkit.org

2010-06-23 Leandro Pereira <leandro@profusion.mobi>

Unreviewed build fix.

  • CMakeLists.txt: Add runtime/RegExpCache.cpp.
06:33 Changeset [61684] by hausmann@webkit.org

[Qt] Doc: Fixed documentation errors.

Patch by David Boddie <dboddie@trolltech.com> on 2010-06-23
Reviewed by Simon Hausmann.

  • docs/qtwebkit-bridge.qdoc:
06:19 Changeset [61683] by hausmann@webkit.org

[Qt] Provide the Webkit Qml plugin with a UID3 on Symbian

Patch by Alessandro Portale <alessandro.portale@nokia.com> on 2010-06-23
Reviewed by Simon Hausmann.

...otherwise we cannot Symbian sign it.

  • declarative/declarative.pro:
05:14 Changeset [61682] by mnaganov@chromium.org

2010-06-23 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix displaying of several CPU profiles with the same name.

https://bugs.webkit.org/show_bug.cgi?id=40992

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
03:36 Changeset [61681] by hausmann@webkit.org

Unreviewed Qt package build fix.

When building without build-webkit, set OUTPUT_DIR if necessary, like
in the other .pro files.

  • declarative/declarative.pro:
03:29 Changeset [61680] by yuzo@google.com

2010-06-23 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Make page format data methods accessible from Chromium
https://bugs.webkit.org/show_bug.cgi?id=41056

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isPageBoxVisible): (WebKit::WebFrameImpl::pageAreaRectInPixels): (WebKit::WebFrameImpl::preferredPageSizeInPixels):
  • src/WebFrameImpl.h:
02:37 Changeset [61679] by zimmermann@webkit.org

2010-06-23 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Forgot to update result of fast/xpath/namespace-vs-predicate.html after the SVG renderer creation changes.

  • fast/xpath/namespace-vs-predicate-expected.txt:
02:21 Changeset [61678] by abarth@webkit.org

2010-06-23 Adam Barth <abarth@webkit.org>

Unreviewed. clean-header-guards that were made dirty by recent
renames.

  • html/HTMLDocumentParser.h:
  • html/HTMLPreloadScanner.h:
  • html/HTMLTokenizer.h:
  • html/HTMLTreeBuilder.h:
  • html/LegacyHTMLDocumentParser.h:
  • html/LegacyHTMLTreeBuilder.h:
  • html/LegacyPreloadScanner.h:
02:03 Changeset [61677] by abarth@webkit.org

2010-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename LegacyHTMLTreeConstructor to LegacyHTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=41053

There was some debate about whether to call this class (and the
non-legacy version) "tree builder" or "tree constructor". Maciej
pointed out that other implementations (including Mozilla and HTML5Lib)
call it a tree builder. The path of least resistance seems to be call
it that for now.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:
  • dom/DocumentParser.h: (WebCore::DocumentParser::htmlTreeConstructor):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::htmlTreeConstructor):
  • html/HTMLDocumentParser.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
  • html/HTMLInputElement.cpp:
  • html/HTMLMeterElement.cpp:
  • html/HTMLProgressElement.cpp:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::legacyTreeConstructor):
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::LegacyHTMLDocumentParser):
  • html/LegacyHTMLDocumentParser.h: (WebCore::LegacyHTMLDocumentParser::htmlTreeConstructor):
  • html/LegacyHTMLTreeBuilder.cpp: Copied from WebCore/html/LegacyHTMLTreeConstructor.cpp. (WebCore::LegacyHTMLTreeBuilder::LegacyHTMLTreeBuilder): (WebCore::LegacyHTMLTreeBuilder::~LegacyHTMLTreeBuilder): (WebCore::LegacyHTMLTreeBuilder::reset): (WebCore::LegacyHTMLTreeBuilder::setCurrent): (WebCore::LegacyHTMLTreeBuilder::limitDepth): (WebCore::LegacyHTMLTreeBuilder::insertNodeAfterLimitDepth): (WebCore::LegacyHTMLTreeBuilder::parseToken): (WebCore::LegacyHTMLTreeBuilder::parseDoctypeToken): (WebCore::LegacyHTMLTreeBuilder::insertNode): (WebCore::LegacyHTMLTreeBuilder::handleError): (WebCore::LegacyHTMLTreeBuilder::textCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::commentCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::headCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::bodyCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::framesetCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::formCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::isindexCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::selectCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::ddCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::dtCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::rpCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::rtCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::nestedCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::nestedPCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::nestedStyleCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::tableCellCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::tableSectionCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::noembedCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::noframesCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::noscriptCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::pCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::pCloserStrictCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::mapCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::getNode): (WebCore::LegacyHTMLTreeBuilder::allowNestedRedundantTag): (WebCore::LegacyHTMLTreeBuilder::processCloseTag): (WebCore::LegacyHTMLTreeBuilder::isHeadingTag): (WebCore::LegacyHTMLTreeBuilder::isInline): (WebCore::LegacyHTMLTreeBuilder::isResidualStyleTag): (WebCore::LegacyHTMLTreeBuilder::isAffectedByResidualStyle): (WebCore::LegacyHTMLTreeBuilder::handleResidualStyleCloseTagAcrossBlocks): (WebCore::LegacyHTMLTreeBuilder::reopenResidualStyleTags): (WebCore::LegacyHTMLTreeBuilder::pushBlock): (WebCore::LegacyHTMLTreeBuilder::popBlock): (WebCore::LegacyHTMLTreeBuilder::popOneBlockCommon): (WebCore::LegacyHTMLTreeBuilder::popOneBlock): (WebCore::LegacyHTMLTreeBuilder::moveOneBlockToStack): (WebCore::LegacyHTMLTreeBuilder::checkIfHasPElementInScope): (WebCore::LegacyHTMLTreeBuilder::popInlineBlocks): (WebCore::LegacyHTMLTreeBuilder::freeBlock): (WebCore::LegacyHTMLTreeBuilder::createHead): (WebCore::LegacyHTMLTreeBuilder::handleIsindex): (WebCore::LegacyHTMLTreeBuilder::startBody): (WebCore::LegacyHTMLTreeBuilder::finished): (WebCore::LegacyHTMLTreeBuilder::reportErrorToConsole):
  • html/LegacyHTMLTreeBuilder.h: Copied from WebCore/html/LegacyHTMLTreeConstructor.h.
  • html/LegacyHTMLTreeConstructor.cpp: Removed.
  • html/LegacyHTMLTreeConstructor.h: Removed.
  • html/StepRange.cpp:
  • html/ValidityState.cpp:
  • rendering/RenderSlider.cpp:
01:50 Changeset [61676] by tkent@chromium.org

2010-06-23 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add expectations for r61667 and r61669.

  • platform/chromium-linux/svg/custom/bug45331-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject: Added.
  • platform/chromium-linux/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/svg-document-as-direct-child-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/svg-document-in-html-document-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-win/svg/custom/bug45331-expected.checksum: Added.
  • platform/chromium-win/svg/custom/bug45331-expected.png: Added.
  • platform/chromium-win/svg/custom/bug45331-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject: Added.
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
01:44 Changeset [61675] by abarth@webkit.org

2010-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename the preload scanners
https://bugs.webkit.org/show_bug.cgi?id=41052

Renames PreloadScanner to LegacyPreloadScanner because this code is now
off by default. Also, rename HTML5PreloadScanner to
HTMLPreloadScanner. We're not calling it PreloadScanner because we've
factored out the CSSPreloadScanner and the HTMLPreloadScanner from the
original PreloadScanner.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5PreloadScanner.cpp: Removed.
  • html/HTML5PreloadScanner.h: Removed.
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/HTMLDocumentParser.h:
  • html/HTMLPreloadScanner.cpp: Copied from WebCore/html/HTML5PreloadScanner.cpp. (WebCore::HTMLPreloadScanner::HTMLPreloadScanner): (WebCore::HTMLPreloadScanner::appendToEnd): (WebCore::HTMLPreloadScanner::scan): (WebCore::HTMLPreloadScanner::processToken): (WebCore::HTMLPreloadScanner::scanningBody):
  • html/HTMLPreloadScanner.h: Copied from WebCore/html/HTML5PreloadScanner.h.
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::scriptExecution):
  • html/LegacyHTMLDocumentParser.h:
  • html/LegacyPreloadScanner.cpp: Copied from WebCore/html/PreloadScanner.cpp. (WebCore::LegacyPreloadScanner::LegacyPreloadScanner): (WebCore::LegacyPreloadScanner::~LegacyPreloadScanner): (WebCore::LegacyPreloadScanner::begin): (WebCore::LegacyPreloadScanner::end): (WebCore::LegacyPreloadScanner::reset): (WebCore::LegacyPreloadScanner::scanningBody): (WebCore::LegacyPreloadScanner::write): (WebCore::LegacyPreloadScanner::clearLastCharacters): (WebCore::LegacyPreloadScanner::rememberCharacter): (WebCore::LegacyPreloadScanner::lastCharactersMatch): (WebCore::LegacyPreloadScanner::consumeEntity): (WebCore::LegacyPreloadScanner::tokenize): (WebCore::LegacyPreloadScanner::processAttribute): (WebCore::LegacyPreloadScanner::emitCharacter): (WebCore::LegacyPreloadScanner::tokenizeCSS): (WebCore::LegacyPreloadScanner::emitTag): (WebCore::LegacyPreloadScanner::emitCSSRule):
  • html/LegacyPreloadScanner.h: Copied from WebCore/html/PreloadScanner.h.
  • html/PreloadScanner.cpp: Removed.
  • html/PreloadScanner.h: Removed.
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeHTMLEntities):
01:33 Changeset [61674] by abarth@webkit.org

2010-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Yet more HTML5 => HTML renames
https://bugs.webkit.org/show_bug.cgi?id=41051

This patch renames HTML5DocumentParser to HTMLDocumentParser and
HTML5TreeBuilder to HTMLTreeBuilder. There was some discussion about
whether to use the name HTMLTreeBuilder or HTMLTreeConstructor, but
tree builder seems to be the dominate name in other implementations.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::parseHTML):
  • html/HTML5DocumentParser.cpp: Removed.
  • html/HTML5DocumentParser.h: Removed.
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::scan): (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5TreeBuilder.cpp: Removed.
  • html/HTML5TreeBuilder.h: Removed.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • html/HTMLDocumentParser.cpp: Copied from WebCore/html/HTML5DocumentParser.cpp. (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::~HTMLDocumentParser): (WebCore::HTMLDocumentParser::begin): (WebCore::HTMLDocumentParser::stopParsing): (WebCore::HTMLDocumentParser::processingData): (WebCore::HTMLDocumentParser::pumpTokenizerIfPossible): (WebCore::HTMLDocumentParser::isScheduledForResume): (WebCore::HTMLDocumentParser::resumeParsingAfterYield): (WebCore::HTMLDocumentParser::runScriptsForPausedTreeConstructor): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::willPumpLexer): (WebCore::HTMLDocumentParser::didPumpLexer): (WebCore::HTMLDocumentParser::write): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::finish): (WebCore::HTMLDocumentParser::finishWasCalled): (WebCore::HTMLDocumentParser::executingScript): (WebCore::HTMLDocumentParser::inScriptExecution): (WebCore::HTMLDocumentParser::lineNumber): (WebCore::HTMLDocumentParser::columnNumber): (WebCore::HTMLDocumentParser::htmlTreeConstructor): (WebCore::HTMLDocumentParser::isWaitingForScripts): (WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution): (WebCore::HTMLDocumentParser::watchForLoad): (WebCore::HTMLDocumentParser::stopWatchingForLoad): (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc): (WebCore::HTMLDocumentParser::notifyFinished): (WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::HTMLDocumentParser::script):
  • html/HTMLDocumentParser.h: Copied from WebCore/html/HTML5DocumentParser.h.
  • html/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler):
  • html/HTMLParserScheduler.h:
  • html/HTMLTreeBuilder.cpp: Copied from WebCore/html/HTML5TreeBuilder.cpp. (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::~HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::handleScriptStartTag): (WebCore::HTMLTreeBuilder::handleScriptEndTag): (WebCore::HTMLTreeBuilder::takeScriptToProcess): (WebCore::HTMLTreeBuilder::adjustedLexerState): (WebCore::HTMLTreeBuilder::passTokenToLegacyParser): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::finished): (WebCore::HTMLTreeBuilder::isScriptingFlagEnabled):
  • html/HTMLTreeBuilder.h: Copied from WebCore/html/HTML5TreeBuilder.h.
01:18 Changeset [61673] by abarth@webkit.org

2010-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

More HTML5 => HTML renames
https://bugs.webkit.org/show_bug.cgi?id=41049

This patch renames HTML5ScriptRunner, HTML5ScriptRunnerHost, and
HTML5Token to remove the "5" from their names. These clases aren't
specific to HTML5 and will be used going forward.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/CSSPreloadScanner.cpp: (WebCore::CSSPreloadScanner::scan):
  • html/CSSPreloadScanner.h:
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::notifyFinished):
  • html/HTML5DocumentParser.h:
  • html/HTML5PreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::PreloadTask): (WebCore::HTMLNames::PreloadTask::processAttributes): (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5PreloadScanner.h:
  • html/HTML5ScriptRunner.cpp: Removed.
  • html/HTML5ScriptRunner.h: Removed.
  • html/HTML5ScriptRunnerHost.h: Removed.
  • html/HTML5Token.h: Removed.
  • html/HTML5TreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5TreeBuilder::handleScriptEndTag): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser): (WebCore::HTML5TreeBuilder::constructTreeFromToken): (WebCore::HTML5TreeBuilder::processToken):
  • html/HTML5TreeBuilder.h:
  • html/HTMLScriptRunner.cpp: Copied from WebCore/html/HTML5ScriptRunner.cpp. (WebCore::HTMLScriptRunner::HTMLScriptRunner): (WebCore::HTMLScriptRunner::~HTMLScriptRunner): (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::isPendingScriptReady): (WebCore::HTMLScriptRunner::executePendingScript): (WebCore::HTMLScriptRunner::executeScript): (WebCore::HTMLScriptRunner::hasScriptsWaitingForLoad): (WebCore::HTMLScriptRunner::watchForLoad): (WebCore::HTMLScriptRunner::stopWatchingForLoad): (WebCore::HTMLScriptRunner::execute): (WebCore::HTMLScriptRunner::haveParsingBlockingScript): (WebCore::HTMLScriptRunner::executeParsingBlockingScripts): (WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad): (WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets): (WebCore::HTMLScriptRunner::requestScript): (WebCore::HTMLScriptRunner::runScript):
  • html/HTMLScriptRunner.h: Copied from WebCore/html/HTML5ScriptRunner.h.
  • html/HTMLScriptRunnerHost.h: Copied from WebCore/html/HTML5ScriptRunnerHost.h. (WebCore::HTMLScriptRunnerHost::~HTMLScriptRunnerHost):
  • html/HTMLToken.h: Copied from WebCore/html/HTML5Token.h. (WebCore::HTMLToken::HTMLToken):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::emitCharacter): (WebCore::HTMLTokenizer::emitCurrentToken): (WebCore::HTMLTokenizer::shouldEmitBufferedCharacterToken):
  • html/HTMLTokenizer.h:
00:49 Changeset [61672] by abarth@webkit.org

2010-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTML5EntityParser to HTMLEntityParser
https://bugs.webkit.org/show_bug.cgi?id=41048

Mostly the result of do-webcore-rename, but I tweaked the header guard
and the name of the free function.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5EntityParser.cpp: Removed.
  • html/HTML5EntityParser.h: Removed.
  • html/HTMLEntityParser.cpp: Copied from WebCore/html/HTML5EntityParser.cpp. (WebCore::consumeHTMLEntity):
  • html/HTMLEntityParser.h: Copied from WebCore/html/HTML5EntityParser.h.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processEntity): (WebCore::HTMLTokenizer::nextToken):
00:37 Changeset [61671] by morrita@google.com

2010-06-22 Yuta Kitamura <yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

Add a new class that stores information about WebSocket handshake response.

In the future, instances of the new class will be passed to the Web Inspector
so that it will be able to display information about WebSocket handshake
response.

WebSocket: Add WebSocketHandshakeResponse
https://bugs.webkit.org/show_bug.cgi?id=38728

Test: websocket/tests/handshake-fail-by-no-cr.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/WebSocketHandshake.cpp: (WebCore::trimConsoleMessage): (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::serverHandshakeResponse): (WebCore::WebSocketHandshake::readStatusLine): Moved from extractResponseCode. Add more error checks and make error messages more descriptive. (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::processHeaders):
  • websockets/WebSocketHandshake.h:
  • websockets/WebSocketHandshakeResponse.cpp: Added. (WebCore::WebSocketHandshakeResponse::ChallengeResponse::ChallengeResponse): (WebCore::WebSocketHandshakeResponse::ChallengeResponse::set): (WebCore::WebSocketHandshakeResponse::WebSocketHandshakeResponse): (WebCore::WebSocketHandshakeResponse::~WebSocketHandshakeResponse): (WebCore::WebSocketHandshakeResponse::statusCode): (WebCore::WebSocketHandshakeResponse::setStatusCode): (WebCore::WebSocketHandshakeResponse::statusText): (WebCore::WebSocketHandshakeResponse::setStatusText): (WebCore::WebSocketHandshakeResponse::headerFields): (WebCore::WebSocketHandshakeResponse::addHeaderField): (WebCore::WebSocketHandshakeResponse::clearHeaderFields): (WebCore::WebSocketHandshakeResponse::challengeResponse): (WebCore::WebSocketHandshakeResponse::setChallengeResponse):
  • websockets/WebSocketHandshakeResponse.h: Added.
00:30 Changeset [61670] by yuzo@google.com

2010-06-23 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
https://bugs.webkit.org/show_bug.cgi?id=37538

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • printing/page-format-data-expected.txt: Added.
  • printing/page-format-data.html: Added.

2010-06-23 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
The final goal is to implement CSS Paged Media Module Level 3 (http://dev.w3.org/csswg/css3-page/).
To begin with, this change adds methods to know:

  • if page box is visible,
  • the page area rectangle, and
  • preferred page size.

https://bugs.webkit.org/show_bug.cgi?id=37538

Test: printing/page-format-data.html

  • WebCore.base.exp:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseSizeParameter):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::applyPageSizeProperty): (WebCore::CSSStyleSelector::pageSizeFromName): (WebCore::CSSStyleSelector::mmLength): (WebCore::CSSStyleSelector::inchLength):
  • css/CSSStyleSelector.h:
  • css/html.css: (@page):
  • dom/Document.cpp: (WebCore::Document::isPageBoxVisible): (WebCore::Document::pageAreaRectInPixels): (WebCore::Document::preferredPageSizeInPixels):
  • dom/Document.h:
  • page/PrintContext.cpp: (WebCore::PrintContext::isPageBoxVisible): (WebCore::PrintContext::pageAreaRectInPixels): (WebCore::PrintContext::preferredPageSizeInPixels):
  • page/PrintContext.h:
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::pageSize): (WebCore::InheritedFlags::setPageSize):
  • rendering/style/StyleRareNonInheritedData.h:

2010-06-23 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
Add methods for testing.
https://bugs.webkit.org/show_bug.cgi?id=37538

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame isPageBoxVisible:]): (-[WebFrame pageAreaRectInPixels:]): (-[WebFrame preferredPageSizeInPixels:]):

2010-06-23 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
Add methods for testing.
https://bugs.webkit.org/show_bug.cgi?id=37538

  • DumpRenderTree/LayoutTestController.cpp: (parsePageNumber): (isPageBoxVisibleCallback): (pageAreaRectInPixelsCallback): (preferredPageSizeInPixelsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels):
00:19 Changeset [61669] by zimmermann@webkit.org

2010-06-23 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Forgot to include four files in the last commit.

  • platform/mac/svg/custom/bug45331-expected.checksum: Added.
  • platform/mac/svg/custom/bug45331-expected.png: Added.
  • platform/mac/svg/custom/bug45331-expected.txt: Added.
  • svg/custom/bug45331.svg: Added.
00:16 Changeset [61668] by abarth@webkit.org

2010-06-23 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename lexer and m_lexer to tokenizer and m_tokenizer, respectively
https://bugs.webkit.org/show_bug.cgi?id=41046

This is a follow up to the recent HTML5Lexer => HTMLTokenizer rename.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::begin): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::willPumpLexer): (WebCore::HTML5DocumentParser::didPumpLexer): (WebCore::HTML5DocumentParser::lineNumber): (WebCore::HTML5DocumentParser::columnNumber):
  • html/HTML5DocumentParser.h:
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::scan): (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5PreloadScanner.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::handleScriptStartTag): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
  • html/HTML5TreeBuilder.h:
  • html/HTMLTokenizer.h:
  • html/LegacyHTMLDocumentParser.h:
00:11 Changeset [61667] by zimmermann@webkit.org

2010-06-23 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

Reproducible crash in com.apple.WebCore 0x01ed3784 WebCore::RenderLineBoxList::appendLineBox(WebCore::InlineFlowBox*) + 36
https://bugs.webkit.org/show_bug.cgi?id=40953

REGRESSION (r58209-58231): Memory corruption with invalid SVG
https://bugs.webkit.org/show_bug.cgi?id=40173

Fix several crashes, all related to <foreignObject> and/or invalid SVG documents.

  • Only allow <svg> nodes, as direct children of a <foreignObject>, not any other "partial" SVG content.
  • Assure to create RenderSVGRoot objects for <svg> nodes in <foreignObject>, treat them as "outermost SVG elements".
  • Never allow any partial SVG content to appear in any document. Only <svg> elements are allowed.

Tests: svg/custom/bug45331.svg

svg/foreignObject/disallowed-svg-nodes-as-direct-children.svg
svg/foreignObject/no-crash-with-svg-content-in-html-document.svg
svg/foreignObject/svg-document-as-direct-child.svg
svg/foreignObject/svg-document-in-html-document.svg
svg/foreignObject/text-tref-02-b.svg

  • dom/Element.cpp: Added childShouldCreateRenderer, with ENABLE(SVG) guards. (WebCore::Element::childShouldCreateRenderer): Only create a renderer for a SVG child, if we're a SVG element, or if the child is a <svg> element.
  • dom/Element.h: Added childShouldCreateRenderer, with ENABLE(SVG) guards.
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::childShouldCreateRenderer): Disallow arbitary SVG content, only <svg> elements are allowed as direct children of a <foreignObject>
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::isOutermostSVG): Be sure to create RenderSVGRoot objects for <svg> elements inside <foreignObject>

2010-06-23 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

Reproducible crash in com.apple.WebCore 0x01ed3784 WebCore::RenderLineBoxList::appendLineBox(WebCore::InlineFlowBox*) + 36
https://bugs.webkit.org/show_bug.cgi?id=40953

REGRESSION (r58209-58231): Memory corruption with invalid SVG
https://bugs.webkit.org/show_bug.cgi?id=40173

Added several new layout tests covering the crashes with <foreignObject> and/or invalid SVG documents.

  • platform/mac/svg/custom/bug45331-expected.checksum: Added.
  • platform/mac/svg/custom/bug45331-expected.png: Added.
  • platform/mac/svg/custom/bug45331-expected.txt: Added.
  • platform/mac/svg/foreignObject: Added.
  • platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.checksum: Added.
  • platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Added.
  • platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Added.
  • platform/mac/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.checksum: Added.
  • platform/mac/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Added.
  • platform/mac/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.checksum: Added.
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.png: Added.
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
  • platform/mac/svg/foreignObject/svg-document-in-html-document-expected.checksum: Added.
  • platform/mac/svg/foreignObject/svg-document-in-html-document-expected.png: Added.
  • platform/mac/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt: Added.
  • svg/custom/bug45331.svg: Added.
  • svg/foreignObject: Added.
  • svg/foreignObject/disallowed-svg-nodes-as-direct-children.svg: Added.
  • svg/foreignObject/no-crash-with-svg-content-in-html-document.svg: Added.
  • svg/foreignObject/svg-document-as-direct-child.svg: Added.
  • svg/foreignObject/svg-document-in-html-document.svg: Added.
  • svg/foreignObject/text-tref-02-b.svg: Added.
00:11 Changeset [61666] by hamaji@chromium.org

2010-06-23 Sam Magnuson <smagnuson@netflix.com>

Reviewed by Shinichiro Hamaji.

Follow proper convention for if/switch/while as I've discovered
them to be through my review processes.
https://bugs.webkit.org/show_bug.cgi?id=40723

Modified test so that if( foo ) is not allowed as it appears not
to be the accepted convention.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
00:02 Changeset [61665] by abarth@webkit.org

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTML5Lexer to HTMLTokenizer
https://bugs.webkit.org/show_bug.cgi?id=41045

This might be slightly confusing given that the old class was called
HTMLTokenizer, but it matches the terminology in the HTML5 spec.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::pumpLexer):
  • html/HTML5DocumentParser.h:
  • html/HTML5Lexer.cpp: Removed.
  • html/HTML5Lexer.h: Removed.
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5PreloadScanner.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::handleScriptStartTag): (WebCore::HTML5TreeBuilder::adjustedLexerState):
  • html/HTML5TreeBuilder.h:
  • html/HTMLTokenizer.cpp: Copied from WebCore/html/HTML5Lexer.cpp. (WebCore::HTMLNames::isEndTagBufferingState): (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::~HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::processEntity): (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::temporaryBufferIs): (WebCore::HTMLTokenizer::addToPossibleEndTag): (WebCore::HTMLTokenizer::isAppropriateEndTag): (WebCore::HTMLTokenizer::emitCharacter): (WebCore::HTMLTokenizer::emitCodePoint): (WebCore::HTMLTokenizer::emitParseError): (WebCore::HTMLTokenizer::emitCurrentToken): (WebCore::HTMLTokenizer::shouldEmitBufferedCharacterToken):
  • html/HTMLTokenizer.h: Copied from WebCore/html/HTML5Lexer.h.

06/22/10:

23:54 Changeset [61664] by hausmann@webkit.org

Unreviewed Qt/Symbian build fix.

Fix "make clean" to not try to execute clean commands for
the extra targets we use to simulate "make install".

  • WebCore.pro: Use no_clean in CONFIG of extra compilers.
23:44 Changeset [61663] by eric@webkit.org

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Run clean-header-guards to fix some header guards
https://bugs.webkit.org/show_bug.cgi?id=41044

No functional changes, thus no tests.

This entire change was generated by running
clean-header-guards, and then reverting changes
to files which shouldn't be changed. Those which
are left all should be updated.

Some of these changes are just fixing 755 permissions
to be 644, since it seems various files have the wrong
execute bit which don't need it. clean-header-guards
made those (welcome) permission fixes unintentionally.

  • bindings/v8/custom/V8HTMLAudioElementConstructor.h:
  • bindings/v8/custom/V8HTMLImageElementConstructor.h:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h:
  • dom/Touch.h:
  • dom/TouchList.h:
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserScope.h:
  • html/HTML5DocumentParser.h:
  • html/LegacyHTMLTreeConstructor.h:
  • loader/CrossOriginPreflightResultCache.h:
  • page/OriginAccessEntry.h:
  • page/win/FrameWin.h:
  • platform/ThreadTimers.h:
  • platform/chromium/KeyboardCodes.h:
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  • platform/graphics/chromium/FontUtilsChromiumWin.h:
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/gstreamer/DataSourceGStreamer.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.h:
    • I checked, this crazy define was not referenced anywhere else. It's safe to change the name. :)
  • platform/graphics/haiku/FontPlatformData.h:
  • platform/graphics/qt/FontCustomPlatformData.h:
  • platform/graphics/skia/SkiaFontWin.h:
  • platform/graphics/win/GraphicsLayerCACF.h:
  • platform/graphics/win/QTMovieWinTimer.h:
  • platform/graphics/win/RefCountedGDIHandle.h:
  • platform/graphics/win/WebLayer.h:
  • platform/graphics/win/WebTiledLayer.h:
  • platform/graphics/wince/FontPlatformData.h:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/network/CredentialStorage.h:
  • platform/network/cf/FormDataStreamCFNet.h:
  • platform/network/curl/FormDataStreamCurl.h:
  • platform/network/qt/DnsPrefetchHelper.h:
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/win/PlatformScrollBar.h:
  • plugins/PluginDatabase.h:
  • plugins/PluginPackage.h:
  • plugins/PluginStream.h:
  • plugins/qt/PluginContainerQt.h:
  • plugins/symbian/npinterface.h:
  • rendering/RenderSelectionInfo.h:
  • rendering/SVGRenderSupport.h:
  • storage/IDBObjectStoreImpl.h:
  • svg/animation/SMILTimeContainer.h:
  • wml/WMLErrorHandling.h:

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Run clean-header-guards to fix some header guards
https://bugs.webkit.org/show_bug.cgi?id=41044

No functional changes, thus no tests.

This entire change was generated by running
clean-header-guards, and then reverting changes
to files which shouldn't be changed. Those which
are left all should be updated.

Some of these changes are just fixing 755 permissions
to be 644, since it seems various files have the wrong
execute bit which don't need it. clean-header-guards
made those (welcome) permission fixes unintentionally.

  • DumpRenderTree/chromium/WebThemeControlDRT.h:
  • DumpRenderTree/chromium/WebThemeEngineDRT.h:
  • QtTestBrowser/fpstimer.h:
23:41 Changeset [61662] by abarth@webkit.org

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTMLDocumentParser to LegacyHTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=41043

  • src/WebEntities.cpp:

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTMLDocumentParser to LegacyHTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=41043

As requested by Darin Adler.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
  • dom/Document.cpp: (WebCore::Document::write):
  • dom/DocumentFragment.cpp:
  • dom/DocumentParser.h: (WebCore::DocumentParser::asHTMLDocumentParser):
  • dom/XMLDocumentParserLibxml2.cpp:
  • dom/XMLDocumentParserQt.cpp:
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::columnNumber):
  • html/HTML5TreeBuilder.cpp:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • html/HTMLDocumentParser.cpp: Removed.
  • html/HTMLDocumentParser.h: Removed.
  • html/HTMLFormControlElement.cpp:
  • html/HTMLParserScheduler.cpp: (WebCore::parserChunkSize):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser): (WebCore::HTMLViewSourceDocument::addViewSourceToken):
  • html/HTMLViewSourceDocument.h:
  • html/LegacyHTMLDocumentParser.cpp: Copied from WebCore/html/HTMLDocumentParser.cpp. (WebCore::LegacyHTMLDocumentParser::LegacyHTMLDocumentParser): (WebCore::LegacyHTMLDocumentParser::reset): (WebCore::LegacyHTMLDocumentParser::begin): (WebCore::LegacyHTMLDocumentParser::setForceSynchronous): (WebCore::LegacyHTMLDocumentParser::processListing): (WebCore::LegacyHTMLDocumentParser::parseNonHTMLText): (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::scriptExecution): (WebCore::LegacyHTMLDocumentParser::parseComment): (WebCore::LegacyHTMLDocumentParser::parseServer): (WebCore::LegacyHTMLDocumentParser::parseProcessingInstruction): (WebCore::LegacyHTMLDocumentParser::parseText): (WebCore::LegacyHTMLDocumentParser::parseEntity): (WebCore::LegacyHTMLDocumentParser::parseDoctype): (WebCore::LegacyHTMLDocumentParser::parseTag): (WebCore::LegacyHTMLDocumentParser::continueProcessing): (WebCore::LegacyHTMLDocumentParser::advance): (WebCore::LegacyHTMLDocumentParser::willWriteHTML): (WebCore::LegacyHTMLDocumentParser::didWriteHTML): (WebCore::LegacyHTMLDocumentParser::write): (WebCore::LegacyHTMLDocumentParser::stopParsing): (WebCore::LegacyHTMLDocumentParser::processingData): (WebCore::LegacyHTMLDocumentParser::timerFired): (WebCore::LegacyHTMLDocumentParser::end): (WebCore::LegacyHTMLDocumentParser::finish): (WebCore::LegacyHTMLDocumentParser::finishWasCalled): (WebCore::LegacyHTMLDocumentParser::processToken): (WebCore::LegacyHTMLDocumentParser::processDoctypeToken): (WebCore::LegacyHTMLDocumentParser::~LegacyHTMLDocumentParser): (WebCore::LegacyHTMLDocumentParser::enlargeBuffer): (WebCore::LegacyHTMLDocumentParser::enlargeScriptBuffer): (WebCore::LegacyHTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::LegacyHTMLDocumentParser::notifyFinished): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsIfReady): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsTimerFired): (WebCore::LegacyHTMLDocumentParser::continueExecutingExternalScripts): (WebCore::LegacyHTMLDocumentParser::isWaitingForScripts): (WebCore::LegacyHTMLDocumentParser::setSrc): (WebCore::parseLegacyHTMLDocumentFragment):
  • html/LegacyHTMLDocumentParser.h: Copied from WebCore/html/HTMLDocumentParser.h. (WebCore::LegacyHTMLDocumentParser::asHTMLDocumentParser):
  • html/LegacyHTMLTreeConstructor.cpp: (WebCore::LegacyHTMLTreeConstructor::reportErrorToConsole):
  • html/LegacyHTMLTreeConstructor.h:
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser): (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate): (WebCore::FTPDirectoryDocumentParser::finish):
  • page/XSSAuditor.h:

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTMLDocumentParser to LegacyHTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=41043

Update the hash.

  • Scripts/do-webcore-rename:
23:35 Changeset [61661] by hamaji@chromium.org

2010-06-22 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed attempt to fix the windows build.

Split out HTML5DocumentParser yield/resume logic into a separate class
https://bugs.webkit.org/show_bug.cgi?id=41018

  • WebCore.vcproj/WebCore.vcproj:
23:30 Changeset [61660] by hamaji@chromium.org

2010-06-22 Sam Magnuson <smagnuson@netflix.com>

Reviewed by Shinichiro Hamaji.

Follow proper convention for variable declaration spacing.
https://bugs.webkit.org/show_bug.cgi?id=40724

Modified test so that 'int a;' is not allowed.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
23:29 Changeset [61659] by pfeldman@chromium.org

2010-06-22 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up to r61655 to make Chromium tests happy.

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
23:18 Changeset [61658] by eric@webkit.org

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split out HTML5DocumentParser yield/resume logic into a separate class
https://bugs.webkit.org/show_bug.cgi?id=41018

The HTML5DocumentParser is just the coordinator, and shouldn't have
any real parsing logic of his own. Continuing along that path, I'm
moving the when-to-yield/resume logic out into a separate class.

I could have create a new HTMLParserSchedulerHost virtual interface
to allow the HTMLParserScheduler to talk back to the
HTML5DocumentParser, but instead I just exposed the one method it
needs (resumeParsing()) as a public method. Since no code besides
HTMLDocument (and DocumentFrament) ever should know about the
HTML5DocumentParser DocumentParser subclass, no class should ever
see the resumeParsing() method anyway.

Most of this change is just moving code from HTML5DocumentParser
to the new HTMLParserScheduler.

Some of this change is wrapping previous direct access to
m_continueNextChunkTimer.isActive() with isScheduledForResume().

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::stopParsing): (WebCore::HTML5DocumentParser::processingData): (WebCore::HTML5DocumentParser::pumpLexerIfPossible): (WebCore::HTML5DocumentParser::isScheduledForResume): (WebCore::HTML5DocumentParser::resumeParsing): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::end): (WebCore::HTML5DocumentParser::attemptToEnd): (WebCore::HTML5DocumentParser::endIfDelayed):
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::document):
    • Exposed for HTMLParserScheduler.
  • html/HTMLParserScheduler.cpp: Added. (WebCore::parserTimeLimit): Moved from HTML5DocumentParser. (WebCore::parserChunkSize): ditto. (WebCore::HTMLParserScheduler::HTMLParserScheduler): (WebCore::HTMLParserScheduler::~HTMLParserScheduler): (WebCore::isLayoutTimerActive): (WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
    • Moved from HTML5DocumentParser.
  • html/HTMLParserScheduler.h: Added. (WebCore::HTMLParserScheduler::PumpSession::PumpSession):
    • Moved from HTML5DocumentParser.

(WebCore::HTMLParserScheduler::shouldContinueParsing):
(WebCore::HTMLParserScheduler::isScheduledForResume):

22:59 QtWebKitReleases edited by hausmann@webkit.org
(diff)
22:26 Changeset [61657] by levin@chromium.org
  • platform/qt/Skipped: Added an xhr test which requires progress events

next to the other xhr test which are disabled due to requiring progress events.

Reviewed by nobody (simple qt test fix).

22:24 Changeset [61656] by tkent@chromium.org

2010-06-22 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: send-data-blob.html fails.
22:17 Changeset [61655] by pfeldman@chromium.org

2010-06-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move nodeByPath from InjectedScript to InspectorBackend.

https://bugs.webkit.org/show_bug.cgi?id=40988

  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::pushNodeByPathToFrontend):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend): (WebCore::InspectorDOMAgent::nodeForPath):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didPushNodeByPathToFrontend):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/InjectedScript.js:
  • inspector/front-end/InjectedScriptAccess.js:
21:39 Changeset [61654] by levin@chromium.org

REGRESSION: (r47291): Upload progress events are not fired for simple cross-site XHR.
https://bugs.webkit.org/show_bug.cgi?id=39029

Reviewed by Alexey Proskuryakov.

WebCore:

Specifically, WebKit should fire upload events if one or more event listeners are
registered on the XMLHttpRequestUpload object when send is called in an async manner.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest): Allow upload events to be fired when there are
handlers for them in the cross-origin simple request case.

LayoutTests:

  • http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt: Update results.
  • http/tests/xmlhttprequest/simple-cross-origin-progress-events.html: Add a test which adds an upload progress event handler before XMLHttpRequest.send() is called.
21:16 Changeset [61653] by kinuko@chromium.org

2010-06-22 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed.

Update test expectations for qt/gtk.

  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
21:13 Changeset [61652] by hclam@chromium.org

Unreviewed. Build fix.

Rebaseline some test results to make build bots green again.

  • platform/chromium-mac/fast/js/switch-behaviour-expected.txt: Removed.
  • platform/chromium-mac/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-win/fast/js/switch-behaviour-expected.txt: Removed.
  • platform/chromium-win/inspector/timeline-parse-html-expected.txt:
  • platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium/test_expectations.txt:
21:10 Changeset [61651] by tkent@chromium.org

2010-06-22 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

Fix uninitialized SubframeLoader::m_containsPlugins
https://bugs.webkit.org/show_bug.cgi?id=41035

  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::SubframeLoader): Initialize m_containsPlugins with false.
20:55 Changeset [61650] by kinuko@chromium.org

2010-06-22 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
https://bugs.webkit.org/show_bug.cgi?id=40593

(Resubmitting with the correct file set.)

BlobBuilder is defined in FileAPI's FileWriter spec.
(http://dev.w3.org/2009/dap/file-system/file-writer.html)

Also removes the ENABLE_FILE_WRITER ifdef guard for BlobBuilder.

Tests: http/tests/local/blob/send-data-blob.html

http/tests/local/blob/send-hybrid-blob.html
http/tests/local/blob/send-sliced-data-blob.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::append):
  • html/BlobBuilder.h:
  • html/BlobBuilder.idl: Added.
  • page/DOMWindow.idl:

2010-06-22 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
https://bugs.webkit.org/show_bug.cgi?id=40593

(Resubmitting with the correct file set.)

Add new layout tests to test BlobBuilder interface.
Also update test expectations affected by adding the constructors to DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/blob/resources/hybrid-blob-util.js: Added.
  • http/tests/local/blob/script-tests/TEMPLATE.html: Added.
  • http/tests/local/blob/script-tests/send-data-blob.js: Added.
  • http/tests/local/blob/script-tests/send-hybrid-blob.js: Added.
  • http/tests/local/blob/script-tests/send-sliced-data-blob.js: Added.
  • http/tests/local/blob/send-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-data-blob.html: Added.
  • http/tests/local/blob/send-hybrid-blob-expected.txt: Added.
  • http/tests/local/blob/send-hybrid-blob.html: Added.
  • http/tests/local/blob/send-sliced-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-sliced-data-blob.html: Added.
  • http/tests/local/resources/file-for-drag-to-send2.txt: Added.
  • http/tests/resources/post-and-verify-hybrid.cgi: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles and Blob.slice.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles and Blob.slice.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles and Blob.slice.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
19:12 Changeset [61649] by tkent@chromium.org

2010-06-22 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix for r61648.

  • platform/graphics/GraphicsContext3D.h:
18:55 Changeset [61648] by tkent@chromium.org

2010-06-22 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kent Tamura.

Define GraphicsContext3D::platformLayer() for all remaining (non PLATFORM(MAC))
ports to get RenderLayerBacking.cpp compiling again.
https://bugs.webkit.org/show_bug.cgi?id=41026

  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::platformLayer):
18:49 Changeset [61647] by commit-queue@webkit.org

2010-06-22 Eric Seidel <eric@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

18:41 Changeset [61646] by eric@webkit.org

2010-06-22 Eric Seidel <eric@webkit.org>

Unreviewed. Rolling out http://trac.webkit.org/changeset/61638
made a few tests crash.

Make PendingScript hold a CachedResourceClient open for its lifetime
https://bugs.webkit.org/show_bug.cgi?id=40968

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::watchForLoad): (WebCore::HTML5DocumentParser::notifyFinished):
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::~HTML5ScriptRunner): (WebCore::HTML5ScriptRunner::sourceFromPendingScript): (WebCore::HTML5ScriptRunner::isPendingScriptReady): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::hasScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::watchForLoad): (WebCore::HTML5ScriptRunner::stopWatchingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForStylesheets): (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::PendingScript::): (WebCore::HTML5ScriptRunner::PendingScript::PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::watchingForLoad):
  • html/HTML5ScriptRunnerHost.h:
18:27 Changeset [61645] by adele@apple.com

WebCore: Fix for Crash when the renderer for the button in <input type="number"> goes away during event handling
https://bugs.webkit.org/show_bug.cgi?id=41013

Reviewed by Darin Adler.

Test: fast/forms/input-number-crash.html

  • rendering/TextControlInnerElements.cpp: (WebCore::SpinButtonElement::defaultEventHandler):

Nil check the RenderBox since its possible the renderer has gone away during event handling.

LayoutTests: Test for Crash when the renderer for the button in <input type="number"> goes away during event handling
https://bugs.webkit.org/show_bug.cgi?id=41013

Reviewed by Darin Adler.

  • fast/forms/input-number-crash-expected.txt: Added.
  • fast/forms/input-number-crash.html: Added.
17:54 Changeset [61644] by eric@webkit.org

2010-06-22 Eric Seidel <eric@webkit.org>

Unreviewed. Add Tony Gentilcore now that he's a committer.

  • Scripts/webkitpy/common/config/committers.py:
17:46 Changeset [61643] by mrowe@apple.com

Versioning.

17:45 Changeset [61642] by mrowe@apple.com

New tag.

17:25 Changeset [61641] by eric@webkit.org

2010-06-22 Eric Seidel <eric@webkit.org>

No review, skipping test due to revealed bug in ClipboardQt.

editing/execCommand/copy-without-selection.html fails on Qt after r61637
https://bugs.webkit.org/show_bug.cgi?id=41025

The Qt Clipboard::setData code wrongly reinterpret_casts UChar
data as char* data. This was exposed by the previous commit
which no long strips \0 characters during innerHTML.

Skipping the affected test until a Qt person can fix
platform/qt/ClipboardQt.cpp

  • platform/qt/Skipped:
16:56 Changeset [61640] by abarth@webkit.org

2010-06-22 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Add layout tests which test line numbers for both inline and event handler
scripts in HTML documents.
https://bugs.webkit.org/show_bug.cgi?id=40649

  • fast/js/resources/script-line-number.js: Added. (getLineFromError): (assertErrorOnLine):
  • fast/js/script-line-number-expected.txt: Added.
  • fast/js/script-line-number.html: Added.

2010-06-22 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Pull script line number from DocumentParser instead of pushing it to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=40649

This approach is cleaner and improves WebCore/benchmarks/parser/html-parser.html by ~2%.

Tests: fast/js/script-line-number.html

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::eventHandlerLineNumber):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::eventHandlerLineNumber): (WebCore::ScriptController::eventHandlerColumnNumber):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/V8Proxy.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::startElementNs):
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::pumpLexer):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::processToken):
16:55 Changeset [61639] by andersca@apple.com

2010-06-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add a SimpleArgumentCoder class template that works on POD types
https://bugs.webkit.org/show_bug.cgi?id=41023

  • Platform/CoreIPC/SimpleArgumentCoder.h: Added. (CoreIPC::SimpleArgumentCoder::encode): (CoreIPC::SimpleArgumentCoder::decode):
  • Shared/WebCoreTypeArgumentMarshalling.h: (CoreIPC::):
  • WebKit2.xcodeproj/project.pbxproj:
16:46 Changeset [61638] by abarth@webkit.org

2010-06-22 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Make PendingScript hold a CachedResourceClient open for its lifetime
https://bugs.webkit.org/show_bug.cgi?id=40968

This replaces the mechanism introduced in r61374 with a simpler
approach from preventing unexpected purges; always keep a client open.
This will approach will allow deferred scripts to add a client after
the resource may have already been loaded without having to worry about
the buffer being purged in the meantime.

No new tests because making a CachedResource purge itself is not
testable from a LayoutTest.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::watchForLoad): (WebCore::HTML5DocumentParser::notifyFinished):
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::~HTML5ScriptRunner): (WebCore::HTML5ScriptRunner::sourceFromPendingScript): (WebCore::HTML5ScriptRunner::isPendingScriptReady): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::watchForLoad): (WebCore::HTML5ScriptRunner::stopWatchingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForStylesheets): (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::PendingScript::PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::~PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::setCachedScript): (WebCore::HTML5ScriptRunner::PendingScript::cachedScript): (WebCore::HTML5ScriptRunner::PendingScript::notifyFinished):
  • html/HTML5ScriptRunnerHost.h:
16:43 Changeset [61637] by abarth@webkit.org

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fragment parsing needs to go through the HTML5 Parser code path
https://bugs.webkit.org/show_bug.cgi?id=40645

  • fast/canvas/canvas-getContext-invalid-expected.txt:
    • \0 is now converted to \uFFFD per HTML5.
  • fast/js/null-char-in-string-expected.txt: ditto.
  • fast/js/switch-behaviour-expected.txt: ditto.
  • fast/parser/comment-in-textarea-expected.txt:
    • <textarea> is parsed in the RCDATA state, which means that comments are ignored, thus the </textarea> in the comment correctly closes the <textarea>. This test is invalid. Our new behavior matches minefield.
  • fast/tokenizer/lessthan-terminates-tags-and-attrs-expected.txt:
    • This test is invalid and probably should just be removed. This same behavior is tested by fast/invalid/016.html.
  • inspector/timeline-parse-html-expected.txt:
    • The "extra" ParseHTML is expected. The HTML5 Parser tells the inspector about every parser pump, even ones which pump no data. The HTML5 parser pumps one last time in finish() to flush any buffered characters. Eventually we'll teach the inspector to filter out (not display) 0-sized pumps.
  • storage/domstorage/complex-values-expected.txt:
    • \0 is now converted to \uFFFD per HTML5
  • svg/dom/fuzz-path-parser-expected.txt: ditto.
  • svg/dom/rgb-color-parser-expected.txt: ditto
  • websocket/tests/bad-sub-protocol-control-chars-expected.txt: ditto.

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Fragment parsing needs to go through the HTML5 Parser code path
https://bugs.webkit.org/show_bug.cgi?id=40645

Added a new HTML5DocumentParser::parseHTMLDocumentFragment
codepath which optionally calls through to the old fragment
parsing path, now renamed parseLegacyHTMLDocumentFragment.

  • dom/Element.cpp: (WebCore::Element::createContextualFragment):
    • Use document()->createDocumentFragment() instead of DocumentFragment::create() to match other callers (and not depend on DocumentFragment.h).
    • Update call to parseHTMLDocumentFragment to use the new HTML5 parser codepath.
  • dom/MappedAttributeEntry.h:
    • Add a FIXME about this horrible enum placement. Sadly this will cause a world-rebuild for everyone.
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::runScriptsForPausedTreeConstructor):
    • The main pumpLexer function has gotten to large. Move the script running logic into this new function.
    • Handle the case where we have no m_scriptRunner (fragment case).

(WebCore::HTML5DocumentParser::pumpLexer):

  • Use new runScriptsForPausedTreeConstructor().

(WebCore::HTML5DocumentParser::executingScript):
(WebCore::HTML5DocumentParser::inScriptExecution):

  • New function to handle the case where m_scriptRunner is null.

(WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution):

  • Use inScriptExecution() instead of m_scriptRunner->inScriptExecution().

(WebCore::HTML5DocumentParser::executeScript): ditto.
(WebCore::HTML5DocumentParser::notifyFinished): ditto.
(WebCore::HTML5DocumentParser::executeScriptsWaitingForStylesheets): ditto.
(WebCore::shouldUseLegacyParser):

  • Helper function to check the html5ParserEnabled() setting.

(WebCore::HTML5DocumentParser::parseHTMLDocumentFragment):

  • Run HTML5DocumentParser in fragment mode, or optionally run the legacy parser if !html5ParserEnabled().
  • html/HTML5DocumentParser.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
    • Implement the FragmentScriptingNotAllowed hack for platform/Pasteboard.
  • html/HTML5TreeBuilder.h:
  • html/HTMLDocumentParser.cpp: (WebCore::parseLegacyHTMLDocumentFragment):
    • Renamed from parseHTMLDocumentFragment
  • html/HTMLDocumentParser.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::insertAdjacentHTML):
    • Call HTML5DocumentParser::parseHTMLDocumentFragment.
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::documentFragment): ditto.
  • xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource): ditto.
16:37 Changeset [61636] by eric@webkit.org

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove Gtk 64-Release bot from core since it's broken
https://bugs.webkit.org/show_bug.cgi?id=41022

This bot alone has been responsible for more than 72 hours of
commit-queue blockage in the last week. The bot is broken -- keeps
losing its display server or similar. Until the Gtk folks can fix the
bot, we need to remove it from core. The WebKit community can't keep
it green as is.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
16:35 Changeset [61635] by andersca@apple.com

2010-06-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Use the ArgumentCoder class template for decoding
https://bugs.webkit.org/show_bug.cgi?id=41021

  • Platform/CoreIPC/ArgumentCoder.h: (CoreIPC::ArgumentCoder::decode):
  • Platform/CoreIPC/ArgumentDecoder.h: (CoreIPC::ArgumentDecoder::decode):
  • Shared/WebCoreTypeArgumentMarshalling.h: (CoreIPC::):
16:22 Changeset [61634] by andersca@apple.com

2010-06-22 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change the encode functions to be specializations of a class template
https://bugs.webkit.org/show_bug.cgi?id=41015

  • Platform/CoreIPC/ArgumentCoder.h: Added. (CoreIPC::ArgumentCoder::encode):
  • Platform/CoreIPC/ArgumentEncoder.h: (CoreIPC::ArgumentEncoder::encode):
  • Shared/WebCoreTypeArgumentMarshalling.h: (CoreIPC::):
  • WebKit2.xcodeproj/project.pbxproj:
16:21 Changeset [61633] by andersca@apple.com

Get rid of more USE_LIBDISPATCH code.

Reviewed by Sam Weinig.

  • Plugins/Hosted/NetscapePluginHostProxy.h:
16:07 Changeset [61632] by abarth@webkit.org

2010-06-22 Eric Seidel <eric@webkit.org>

Reviewed by Geoffrey Garen.

Two fast/dynamic tests needlessly depend on legacy <tag<tag> parsing behavior
https://bugs.webkit.org/show_bug.cgi?id=40946

These two tests would fail when we turned on
the HTML5 Lexer code path for DocumentFragment parsing.
This old parser quirk is covered by several other tests
including fast/invalid/016.html.

  • fast/dynamic/insertAdjacentHTML.html:
  • fast/dynamic/insertAdjacentText.html:
15:23 Changeset [61631] by cmarrin@apple.com

2010-06-22 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=40643


Final phase of moving ownership of WebGLLayer to GraphicsContext3D.
As it turns out, I still have to have a separate CGLContextObj for
rendering because Core Animation composites in a separate thread,
so we need to disconnect WebGL rendering from CA compositing. But
this change is still worthwhile because it reduces dependencies
and makes it easier to port WebGL to other platforms.


No new tests since this is just restructuring and the current tests
are all still valid and do a sufficient test of WebGL functionality.

  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::platformLayer):
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToWebGL): (WebCore::GraphicsLayer::setWebGLNeedsDisplay):
  • platform/graphics/mac/GraphicsContext3DMac.mm: Add creation of WebGLLayer (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
  • platform/graphics/mac/GraphicsLayerCA.mm: Handle setting of WebGLLayer as content the same as for MediaLayer. Also changed WebGL related names for clarity (WebCore::GraphicsLayerCA::GraphicsLayerCA): (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateContentsWebGLLayer): (WebCore::GraphicsLayerCA::setContentsToWebGL): (WebCore::GraphicsLayerCA::setWebGLNeedsDisplay):
  • platform/graphics/mac/WebGLLayer.h:
  • platform/graphics/mac/WebGLLayer.mm: Got rid of storage for context and texture, now just store GraphicsContext3D and get them from there when needed (-[WebGLLayer copyCGLPixelFormatForDisplayMask:]): (-[WebGLLayer copyCGLContextForPixelFormat:]): (-[WebGLLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): (-[WebGLLayer copyImageSnapshotWithColorSpace:]):
  • rendering/RenderLayerBacking.cpp: Changed init of WebGL contentsLayer to pass WebGLLayer rather than GraphicsContext3D (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::rendererContentChanged):
15:13 Changeset [61630] by darin@apple.com
  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::parseMappedAttribute): Removed incorrect FIXME comments.

Reviewed by Dave Hyatt.

15:10 Changeset [61629] by mitz@apple.com

<rdar://problem/8119403> REGRESSION (r61548): PLT is almost 1.5% slower, Google page cycler slower
https://bugs.webkit.org/show_bug.cgi?id=41012

Reviewed by Anders Carlsson.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine): Removed a redundant statement that was
left over in the original patch and resulted in double the calls to RenderText::width() here.
(WebCore::RenderBlock::findNextLineBreak): Changed the order of evaluating conditions for a
potential speedup.

15:05 QtWebKitReleases edited by hausmann@webkit.org
(diff)
14:58 QtWebKitReleases edited by hausmann@webkit.org
(diff)
14:55 QtWebKitTiling edited by jesus@webkit.org
(diff)
14:28 QtWebKitTiling edited by kenneth@webkit.org
(diff)
14:16 QtWebKitTiling edited by kenneth@webkit.org
(diff)
14:16 Changeset [61628] by andersca@apple.com

Get rid of the USE_LIBDISPATCH code.

Reviewed by Sam Weinig.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):

13:30 Changeset [61627] by darin@apple.com

Alexey asked me to take out the autorelease pools because he believes
that there is no code that should be running using Objective-C
autorelease. Most likely, the code that is triggering these stderr
messages is incorrect, and that bug should be fixed instead.

Reviewed by Alexey Proskuryakov.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::run): Roll out use of AutodrainedPool.

13:26 Changeset [61626] by darin@apple.com

Fix autorelease problem seen when running worker regression tests.
We were seeing logs to stderr saying autorelease was used without
an autorelease pool being set up.

Reviewed by Brady Eidson.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::run): Use an AutodrainedPool as the file
thread, icon database, and database thread do. No effect on platforms
other than Mac.

12:54 Changeset [61625] by andersca@apple.com

2010-06-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Wean NetscapePluginHostManager of any knowledge about WebNetscapePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=41006

  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPlugin): (WebKit::NetscapePluginHostManager::spawnPluginHost): (WebKit::NetscapePluginHostManager::instantiatePlugin): (WebKit::NetscapePluginHostManager::createPropertyListFile):
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage createPropertyListFile]):
12:39 Changeset [61624] by andersca@apple.com

Implement PluginInfoStore::shouldUsePlugin.

Reviewed by Sam Weinig.

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::shouldUsePlugin):

  • WebKit2.xcodeproj/project.pbxproj:
12:16 Changeset [61623] by zherczeg@webkit.org

Adding regular expression caching to JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=38142

Patch by Renata Hodovan <hodovan@inf.u-szeged.hu> on 2010-06-22
Reviewed by Geoffrey Garen.

The cache is based on Round Robin eviction policy, and
can cache at most 256 character long regular expressions,
and at most 256 of them. These values can be changed at compile time.

(JSC::RegExpNode::emitBytecode):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::regExpCache):

  • runtime/RegExpCache.cpp: Added.

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
(JSC::RegExpCache::RegExpCache):

  • runtime/RegExpCache.h: Added.
  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpKey.h: Added.

(JSC::RegExpKey::RegExpKey):
(JSC::RegExpKey::getFlagsValue):
(WTF::operator==):
(WTF::):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):

12:01 Changeset [61622] by cfleizach@apple.com

AX: If an element that is a continuation is removed, its parent tree is not notified appropriately that their children have changed
https://bugs.webkit.org/show_bug.cgi?id=41000

Reviewed by Darin Adler.

WebCore:

Test: accessibility/removed-continuation-element-causes-crash.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::updateChildrenIfNecessary):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/removed-continuation-element-causes-crash-expected.txt: Added.
  • accessibility/removed-continuation-element-causes-crash.html: Added.
11:15 Changeset [61621] by crogers@google.com

Initial incomplete work for DelayNode and WaveshaperNode

11:15 Changeset [61620] by crogers@google.com

Add direct audio data access to AudioBuffer

11:02 Changeset [61619] by pkasting@chromium.org

Override setFailed() in each image decoder to clean up any temporary
objects.
https://bugs.webkit.org/show_bug.cgi?id=35411

Reviewed by Adam Barth.

In a few cases, we need to be careful to avoid deleting objects until
after they're no longer needed. These cases usually mean some jumping
through hoops, to the detriment of code simplicity.

No layout tests because this does not change the visible output of
decoding in any way.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::setData):

  • platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::setFailed):
(WebCore::BMPImageDecoder::decode):

  • platform/image-decoders/bmp/BMPImageDecoder.h:
  • platform/image-decoders/bmp/BMPImageReader.cpp:

(WebCore::BMPImageReader::decodeBMP):
(WebCore::BMPImageReader::readInfoHeaderSize):
(WebCore::BMPImageReader::processInfoHeader):
(WebCore::BMPImageReader::readInfoHeader):
(WebCore::BMPImageReader::processBitmasks):
(WebCore::BMPImageReader::processColorTable):
(WebCore::BMPImageReader::processRLEData):
(WebCore::BMPImageReader::processNonRLEData):

  • platform/image-decoders/bmp/BMPImageReader.h:

(WebCore::BMPImageReader::):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::setFailed):
(WebCore::GIFImageDecoder::decode):

  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::setFailed):
(WebCore::ICOImageDecoder::decode):

  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):
(WebCore::JPEGImageDecoder::setFailed):
(WebCore::JPEGImageDecoder::decode):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::PNGImageDecoder):
(WebCore::PNGImageDecoder::setFailed):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::decode):

  • platform/image-decoders/png/PNGImageDecoder.h:
08:56 Changeset [61618] by dglazkov@chromium.org

2010-06-04 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Remove side effects of form submission and prepare FormDataBuilder for splitting up.
https://bugs.webkit.org/show_bug.cgi?id=40184

Refactoring, covered by existing tests.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission):
    • Changed to use new accessors on FormDataBuilder;
    • Simplified the logic around action URL;
    • Removed form submission side effect of element's enctype property being updated when

submitting a mailto form;

  • Removed unnecessary updating of action URL for mailto forms.

(WebCore::HTMLFormElement::submit): Moved action URL check into prepareFormSubmission.
(WebCore::HTMLFormElement::parseMappedAttribute): Updated to use new methods on FormDataBuilder.

  • html/HTMLFormElement.h: Removed decls for isMailtoForm and dataEncoding methods;

moved m_target and m_url to FormDataBuilder.

  • platform/network/FormData.cpp: (WebCore::FormData::appendDOMFormData): Removed unnecessary instantiation of FormDataBuilder.
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::parseAction): Moved from HTMLFormControl.
  • platform/network/FormDataBuilder.h: (WebCore::FormDataBuilder::action): Ditto. (WebCore::FormDataBuilder::target): Ditto. (WebCore::FormDataBuilder::setTarget): Ditto.
07:58 Changeset [61617] by yurys@chromium.org

2010-06-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector/elements-panel-limited-children.html test fails
https://bugs.webkit.org/show_bug.cgi?id=40924

  • http/tests/inspector/inspector-test.js: (onload): (frontend_setupTestEnvironment): always start inspector test with Elements panel as current one.
  • inspector/elements-panel-limited-children.html:
07:41 QtWebKitTriageRoster edited by hausmann@webkit.org
(diff)
07:40 Changeset [61616] by mnaganov@chromium.org

2010-06-22 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Clean up after removal of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.

https://bugs.webkit.org/show_bug.cgi?id=40914

  • public/WebDevToolsAgentClient.h:
06:54 Changeset [61615] by hausmann@webkit.org

[Qt] Fix compilation with QT_NO_COMBOBOX.

Patch by Tasuku Suzuki <tasuku.suzuki@nokia.com> on 2010-06-22
Reviewed by Simon Hausmann.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::createSelectPopup):

05:25 Changeset [61614] by loki@webkit.org

Add native call support for ARM and Thumb-2 JIT.
https://bugs.webkit.org/show_bug.cgi?id=40231

Reviewed by Geoffrey Garen.

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • wtf/Platform.h:
05:14 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
05:11 Changeset [61613] by mnaganov@chromium.org

2010-06-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Add a sanity test for heap profiler.

https://bugs.webkit.org/show_bug.cgi?id=40917

  • src/js/Tests.js: (.TestSuite.prototype.testHeapProfiler.findDisplayedNode): (.TestSuite.prototype.testHeapProfiler.findVisibleView): (.TestSuite.prototype.testHeapProfiler):
05:03 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
04:59 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
04:44 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
04:41 Changeset [61612] by tkent@chromium.org

2010-06-22 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-linux/fast/parser/broken-comments-vs-parsing-mode-expected.checksum: Added.
  • platform/chromium-linux/fast/parser/broken-comments-vs-parsing-mode-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-mac/fast/parser/broken-comments-vs-parsing-mode-expected.checksum: Removed.
  • platform/chromium-mac/fast/parser/broken-comments-vs-parsing-mode-expected.png: Removed.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.checksum:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.png:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
04:40 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
04:37 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
04:28 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
01:59 Changeset [61611] by morrita@google.com

2010-06-22 Yuta Kitamura <yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix WebSocketHandshakeRequest so that it fits the new handshake protocol.

The new WebSocket specification (draft 76 and later) allows a browser to
send header fields in arbitrary order. Thus we can use a HTTPHeaderMap to
store header fields instead of Vector of pairs of a field name and
a field value.

This patch also does refactoring of WebSocketHandshakeRequest class
to make it simpler and easier to use.

Fix WebSocketHandshakeRequest so that it fits the new handshake protocol
https://bugs.webkit.org/show_bug.cgi?id=39864

No new tests, because there is no functional change.

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::clientHandshakeRequest):
  • websockets/WebSocketHandshakeRequest.cpp: (WebCore::WebSocketHandshakeRequest::Key3::Key3): (WebCore::WebSocketHandshakeRequest::Key3::set): (WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest): (WebCore::WebSocketHandshakeRequest::requestMethod): (WebCore::WebSocketHandshakeRequest::url): (WebCore::WebSocketHandshakeRequest::addHeaderField): (WebCore::WebSocketHandshakeRequest::headerFields): (WebCore::WebSocketHandshakeRequest::key3): (WebCore::WebSocketHandshakeRequest::setKey3):
  • websockets/WebSocketHandshakeRequest.h:
01:45 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
01:28 Changeset [61610] by abarth@webkit.org

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Upon closer reading of the spec, we think our behavior is correct.
We'll double-check with the working group.

  • fast/tokenizer/write-on-load-expected.txt:
  • fast/tokenizer/write-on-load.html:
01:22 Changeset [61609] by morrita@google.com

2010-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<meter> should be yellow when min < value < low < optimum
https://bugs.webkit.org/show_bug.cgi?id=40824

Update overlooked broken test results.

  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:

2010-06-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<meter> should be yellow when min < value < low < optimum
https://bugs.webkit.org/show_bug.cgi?id=40824

Fixed a wrong conditional on HTMLMeterElement::gaugeRegion().

  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::gaugeRegion):

Tests: fast/dom/HTMLMeterElement/meter-appearances-capacity.html

fast/dom/HTMLMeterElement/meter-optimums.html

01:14 Changeset [61608] by abarth@webkit.org

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Follow the HTML5 spec more closely w.r.t. when to save the insertion point
https://bugs.webkit.org/show_bug.cgi?id=40976

This test no longer asserts. The output is incorrect, however. I'll
fix the output in the next patch.

  • fast/tokenizer/write-on-load-expected.txt: Added.
  • fast/tokenizer/write-on-load.html: Added.

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Follow the HTML5 spec more closely w.r.t. when to save the insertion point
https://bugs.webkit.org/show_bug.cgi?id=40976

The spec always increments the nesting level and saves the insertion
point at the same time. In this patch, we now do those operations
packaged as a RAII.

As a side effect, the test case below no longer ASSERTs. (The output
is wrong, but we'll get to that next.)

Test: fast/tokenizer/write-on-load.html

  • html/HTML5ScriptRunner.cpp: (WebCore::NestScript::NestScript): (WebCore::NestScript::~NestScript): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::executeScript): (WebCore::HTML5ScriptRunner::requestScript): (WebCore::HTML5ScriptRunner::runScript):
  • html/HTMLInputStream.h:
00:56 Changeset [61607] by abarth@webkit.org

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Expose HTMLInputStream to ScriptRunner so that ScriptRunner can save the insertion point itself
https://bugs.webkit.org/show_bug.cgi?id=40975

This saves us having to call back into the HTML5DocumentParser each
time we need to save the insertion point. This prepares us for another
place we need to save the insertion point.

  • html/HTML5DocumentParser.cpp:
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::inputStream):
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::executeScript): (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunnerHost.h:
00:42 Changeset [61606] by abarth@webkit.org

2010-06-22 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move HTMLInputStream to its own file
https://bugs.webkit.org/show_bug.cgi?id=40974

No new tests, just code motion.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5DocumentParser.h:
00:23 QtWebKitDocContrib created by henry.haverinen@nokia.com
00:23 QtWebKit edited by henry.haverinen@nokia.com
(diff)
00:13 Changeset [61605] by eric@webkit.org

2010-06-21 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Alexey Proskuryakov.

Tests for:
Space should be allowed between -- and > in comment end
https://bugs.webkit.org/show_bug.cgi?id=21945

  • fast/css/word-space-extra.html: Tweaked the comment as -- > is now a valid comment end.
  • fast/parser/broken-comment-1-expected.txt: Added.
  • fast/parser/broken-comment-1.html: Added.
  • fast/parser/broken-comment-2-expected.txt: Added.
  • fast/parser/broken-comment-2.html: Added.
  • fast/parser/broken-comment-3-expected.txt: Added.
  • fast/parser/broken-comment-3.html: Added.
  • fast/parser/broken-comment-4-expected.txt: Added.
  • fast/parser/broken-comment-4.html: Added.
  • fast/parser/broken-comment-5-expected.txt: Added.
  • fast/parser/broken-comment-5.html: Added.
  • fast/parser/broken-comment-6-expected.txt: Added.
  • fast/parser/broken-comment-6.html: Added. Those test checks that broken comments in body are correctly parsed.
  • fast/parser/broken-comment-in-head-1-expected.txt: Added.
  • fast/parser/broken-comment-in-head-1.html: Added.
  • fast/parser/broken-comment-in-head-2-expected.txt: Added.
  • fast/parser/broken-comment-in-head-2.html: Added.
  • fast/parser/broken-comment-in-head-3-expected.txt: Added.
  • fast/parser/broken-comment-in-head-3.html: Added.
  • fast/parser/broken-comment-in-head-4-expected.txt: Added.
  • fast/parser/broken-comment-in-head-4.html: Added.
  • fast/parser/broken-comment-in-head-5-expected.txt: Added.
  • fast/parser/broken-comment-in-head-5.html: Added. Those test checks that broken comments in head are correctly parsed.
  • fast/parser/broken-comments-vs-parsing-mode.html: Needed to wrap the broken comment in a title as we match FF here and would not recover from it.
  • fast/parser/comments-expected.txt:
  • fast/parser/comments.html: Added more tests for comment parsing. Made sure that we close empty comments <!--> and <!---> as is specified in HTML5.
00:04 Changeset [61604] by abarth@webkit.org

2010-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Save the insertion point before beforeload events
https://bugs.webkit.org/show_bug.cgi?id=40973

Update expected results to show the proper document.write order.

  • fast/tokenizer/write-before-load-expected.txt:

2010-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Save the insertion point before beforeload events
https://bugs.webkit.org/show_bug.cgi?id=40973

We need to save the insertion point before dispatching the beforeload
event in case someone decides to document.write during beforeload.
Prior to this patch, such writes would pump the lexer too much and
tokenize the rest of the document before executing the script.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::dispatchBeforeLoad):
  • html/HTML5DocumentParser.h:
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunnerHost.h:
00:03 Changeset [61603] by dumi@chromium.org

Fix the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=40972

Reviewed by Eric Seidel.

  • DumpRenderTree/win/ImageDiff.vcproj:

06/21/10:

23:25 Changeset [61602] by abarth@webkit.org

2010-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.write from BeforeLoad should not assert
https://bugs.webkit.org/show_bug.cgi?id=40971

Test what happens when we document.write from a beforeload event.
Notice that the order is wrong. I'll fix that in a followup patch.

  • fast/tokenizer/write-before-load-expected.txt: Added.
  • fast/tokenizer/write-before-load.html: Added.

2010-06-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.write from BeforeLoad should not assert
https://bugs.webkit.org/show_bug.cgi?id=40971

We're setting the parse blocking script too early. It's not actually
blocking parsing yet.

Test: fast/tokenizer/write-before-load.html

  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::requestScript):
21:59 Changeset [61601] by dimich@chromium.org

Unreviewed, skip new modal tests on Tiger and update expected result for Chromium.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/mac-tiger/Skipped:
21:41 Changeset [61600] by dimich@chromium.org

Unreviewed, fixing qt-specific expected results for r61599

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
21:24 Changeset [61599] by dimich@chromium.org

DumpRenderTree should allow tests with modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=35350

Patch by Prasad Tammana <prasadt@chromium.org> on 2010-06-21
Reviewed by Darin Adler, Dmitry Titov.

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp:

(abortModalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::abortModal):
Add abortModal method to LayoutTestController and make it available from script.

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

LayoutTests:

Added a new test show-modal-dialog.html to harness tests to verify that showModalDialog works.

Added a new test, show-modal-dialog-onblur-onfocus.html, that takes advantage of the showModalDialog
functionality added to UIDelegate.mm. The test is only enabled on mac for now. This test will catch
regressions on the bug fix for https://bugs.webkit.org/show_bug.cgi?id=33962.

Support for showModalDialog affected the expected output for many tests that operate under the assumption
that the method is undefined. Modified the tests accordingly, in some cases disabled showModalDialog (not
currently tested anyway. Opened a bug to add showModalDialog specific tests where appropriate - Bug# 39897.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-frame-getter-precedence.html:
  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-name-getter-precedence.html:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:

Tweak tests so that showModalDialog part gets exercised only if its defined to keep output consistent across platforms.
Where its not possible, skip the test for showModalDialog, which is not currently exercised anyway.

  • fast/events/resources/modal-dialog.html: Added.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Added.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Added.
  • fast/harness/resources/modal-dialog.html: Added.
  • fast/harness/show-modal-dialog-expected.txt: Added.
  • fast/harness/show-modal-dialog.html: Added.

New tests that take advantage of showModalDialog in DRT.

  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt:

Update the expected output to reflect the fact that these tests pass now. Skip the tests on gtk, qt and win. They were all expected
to fail anyway. So no coverage lost.

  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put-expected.txt:

Skip showModalDialog to make test pass for all platforms. Added a FIXME with bug # to add a test specifically for showModalDialog.

  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • platform/chromium-mac/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/chromium-win/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.

Updaate expected output to reflect test changes. Removed some platform specific files where the only reason they're different is
because of showModalDialog.

  • platform/qt/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/win/Skipped:

Skip failing tests. Note that there is no test functionality lost. These are either new tests or tests that were dysfunctional anyway
in the absence of showModalDialog in DRT.

19:28 Changeset [61598] by morrita@google.com

2010-06-21 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Dragging outside the frame immediately causes page to scroll
http://webkit.org/b/40461

This is regression that was introduced at http://webkit.org/b/39725.

There are 2 problems:

  1. It starts auto-scrolling immediately. We should have some delay.
  2. The scroll continues even after a mouse cursor goes outside a frame. The scroll should be stopped when the curosr has left.

This change introduced DragScrollTimer to handle 1.
At the same time, it fixed DragScrollTimer::scrollDistanceFor() to
handle 2, We now stop scrolling when the cursor gone.

  • WebKit.gyp:
  • src/DragScrollTimer.cpp: Added. (WebKit::distanceToRect): (WebKit::DragScrollTimer::DragScrollTimer): (WebKit::DragScrollTimer::~DragScrollTimer): (WebKit::DragScrollTimer::stop): (WebKit::DragScrollTimer::scroll): (WebKit::DragScrollTimer::update): (WebKit::DragScrollTimer::triggerScroll): (WebKit::DragScrollTimer::scrollDistanceFor):
  • src/DragScrollTimer.h: Added. (WebKit::DragScrollTimer::fired): (WebKit::DragScrollTimer::shouldScroll):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::dragSourceEndedAt): (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragTargetDrop): (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
  • src/WebViewImpl.h:
18:36 Changeset [61597] by cfleizach@apple.com

No review. QT build fix again.

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=40927

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

18:27 Changeset [61596] by cfleizach@apple.com

No review. QT build fix.

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=40927

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

18:07 Changeset [61595] by cfleizach@apple.com

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=40927

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/aria-expanded-notifications.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAriaExpandedChange):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::handleAriaExpandedChange):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::handleAriaExpandedChanged):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests:

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/accessibility/aria-expanded-notifications-expected.txt: Added.
  • platform/mac/accessibility/aria-expanded-notifications.html: Added.
17:33 Changeset [61594] by andersca@apple.com

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Support reading plug-in info from Carbon resources
https://bugs.webkit.org/show_bug.cgi?id=40959

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::ResourceMap::ResourceMap): (WebKit::ResourceMap::~ResourceMap): (WebKit::ResourceMap::isValid): (WebKit::getStringListResource): (WebKit::getPluginInfoFromCarbonResources): (WebKit::PluginInfoStore::getPluginInfo):
17:23 Changeset [61593] by andersca@apple.com

Build fix.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):

17:07 Changeset [61592] by andersca@apple.com

Fix an off-by-one bug I introduced.

Reviewed by Sam Weinig.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage getPluginInfoFromResources]):

17:00 Changeset [61591] by andersca@apple.com

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Have PluginInfoStoreMac actually get plug-in info and populate the plug-in list
https://bugs.webkit.org/show_bug.cgi?id=40957

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::loadPluginsIfNecessary): (WebKit::PluginInfoStore::loadPluginsInDirectory): (WebKit::PluginInfoStore::loadPlugin): (WebKit::PluginInfoStore::getPlugins):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: Added. (WebKit::PluginInfoStore::pluginDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::getPluginArchitecture): (WebKit::getPluginInfoFromPropertyLists): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebKit2.xcodeproj/project.pbxproj:
16:42 Changeset [61590] by weinig@apple.com

Update WebKitSystemInterface.

Reviewed by Anders Carlsson.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
16:29 Changeset [61589] by simon.fraser@apple.com

2010-06-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=40948

Rename UIProcess version of DrawingAreaUpdateChunk to ChunkedUpdateDrawingAreaProxy,
and rename the Mac/Win versions of the various DrawingArea files too.

Also rename the DrawingAreaUpdateChunkType enum to ChunkedUpdateDrawingAreaType.

16:17 Changeset [61588] by oliver@apple.com

2010-06-21 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make JSC more resilient in the face of parse failures
https://bugs.webkit.org/show_bug.cgi?id=40951

A number of recent bugs have occurred due to issues like miscounting
BOMs, etc which lead to interesting crashes later on. Adding this
logic hardens JSC in the face of these errors, and has no impact on
performance (32bit jit actually gets 0.7% faster but I put that down
to cache effects).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::lineNumberForBytecodeOffset): (JSC::CodeBlock::expressionRangeForBytecodeOffset): (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::bytecodeOffset):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::prepareForRepeatCall): (JSC::Interpreter::privateExecute):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/ArrayPrototype.cpp: (JSC::isNumericCompareFunction):
  • runtime/Executable.cpp: (JSC::FunctionExecutable::compileForCall): (JSC::FunctionExecutable::compileForConstruct): (JSC::FunctionExecutable::generateJITCodeForCall): (JSC::FunctionExecutable::generateJITCodeForConstruct): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo):
  • runtime/Executable.h: (JSC::FunctionExecutable::bytecodeForCall): (JSC::FunctionExecutable::bytecodeForConstruct):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::numericCompareFunction):
16:00 Changeset [61587] by andersca@apple.com

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PluginInfoStore class
https://bugs.webkit.org/show_bug.cgi?id=40949

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::WebPreferencesStore):
  • Shared/WebPreferencesStore.h: (WebKit::WebPreferencesStore::encode): (WebKit::WebPreferencesStore::decode): Add plugInsEnabled to the preferences store.
  • UIProcess/Plugins: Added.
  • UIProcess/Plugins/PluginInfoStore.cpp: Added. (WebKit::PluginInfoStore::shared): (WebKit::PluginInfoStore::PluginInfoStore): (WebKit::PluginInfoStore::refresh): (WebKit::PluginInfoStore::getPlugins):
  • UIProcess/Plugins/PluginInfoStore.h: Added.
  • UIProcess/Plugins/mac: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):
15:57 Changeset [61586] by kinuko@chromium.org

2010-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61585.
http://trac.webkit.org/changeset/61585
https://bugs.webkit.org/show_bug.cgi?id=40950

It broke builds (Requested by kinuko on #webkit).

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::appendString): (WebCore::BlobBuilder::appendBlob):
  • html/BlobBuilder.h:
  • page/DOMWindow.idl:

2010-06-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r61585.
http://trac.webkit.org/changeset/61585
https://bugs.webkit.org/show_bug.cgi?id=40950

It broke builds (Requested by kinuko on #webkit).

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
15:41 Changeset [61585] by kinuko@chromium.org

2010-06-21 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
https://bugs.webkit.org/show_bug.cgi?id=40593

BlobBuilder is defined in FileAPI's FileWriter spec.
(http://dev.w3.org/2009/dap/file-system/file-writer.html)

Also removes the ENABLE_FILE_WRITER ifdef guard for BlobBuilder.

Tests: http/tests/local/blob/send-data-blob.html

http/tests/local/blob/send-hybrid-blob.html
http/tests/local/blob/send-sliced-data-blob.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::append):
  • html/BlobBuilder.h:
  • html/BlobBuilder.idl: Added.
  • page/DOMWindow.idl:

2010-06-21 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
https://bugs.webkit.org/show_bug.cgi?id=40593

Add new layout tests to test BlobBuilder interface.
Also update test expectations affected by adding the constructors to DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/blob/resources/hybrid-blob-util.js: Added.
  • http/tests/local/blob/script-tests/TEMPLATE.html: Added.
  • http/tests/local/blob/script-tests/send-data-blob.js: Added.
  • http/tests/local/blob/script-tests/send-hybrid-blob.js: Added.
  • http/tests/local/blob/script-tests/send-sliced-data-blob.js: Added.
  • http/tests/local/blob/send-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-data-blob.html: Added.
  • http/tests/local/blob/send-hybrid-blob-expected.txt: Added.
  • http/tests/local/blob/send-hybrid-blob.html: Added.
  • http/tests/local/blob/send-sliced-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-sliced-data-blob.html: Added.
  • http/tests/local/resources/file-for-drag-to-send2.txt: Added.
  • http/tests/resources/post-and-verify-hybrid.cgi: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
15:33 Changeset [61584] by japhet@chromium.org

2010-06-21 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

FrameLoader cleanup: Split high level subframe and plugin
loading functions into a separate class.
https://bugs.webkit.org/show_bug.cgi?id=40453

Refactor only, no new tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMImplementation.cpp:
  • history/PageCache.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLMediaElement.cpp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: (WebCore::FrameLoader::subframeLoader):
  • loader/PluginDocument.cpp:
  • loader/SubframeLoader.cpp: Added. (WebCore::SubframeLoader::SubframeLoader): (WebCore::toPlugInElement): (WebCore::SubframeLoader::clear): (WebCore::SubframeLoader::requestFrame): (WebCore::SubframeLoader::requestObject): (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::allowPlugins): (WebCore::SubframeLoader::shouldUsePlugin): (WebCore::SubframeLoader::loadPlugin): (WebCore::SubframeLoader::completeURL):
  • loader/SubframeLoader.h: Added. (WebCore::SubframeLoader::containsPlugins):
  • page/Page.cpp:
  • page/XSSAuditor.h:
  • platform/graphics/wince/MediaPlayerProxy.cpp:
  • plugins/MimeType.cpp:
  • rendering/RenderApplet.cpp:
  • rendering/RenderEmbeddedObject.cpp:
15:22 Changeset [61583] by simon.fraser@apple.com

2010-06-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=40948

Rename DrawingAreaUpdateChunk to ChunkedUpdateDrawingArea.

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:pageNamespaceRef:]):
  • UIProcess/ChunkedUpdateDrawingArea.cpp: Added. (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::~ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::paint): (WebKit::ChunkedUpdateDrawingArea::setSize): (WebKit::ChunkedUpdateDrawingArea::setPageIsVisible): (WebKit::ChunkedUpdateDrawingArea::didSetSize): (WebKit::ChunkedUpdateDrawingArea::update): (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
  • UIProcess/ChunkedUpdateDrawingArea.h: Added. (WebKit::ChunkedUpdateDrawingArea::encode):
  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: Removed.
  • UIProcess/DrawingAreaProxyUpdateChunk.h: Removed.
  • UIProcess/mac/DrawingAreaProxyUpdateChunkMac.mm: (WebKit::ChunkedUpdateDrawingArea::page): (WebKit::ChunkedUpdateDrawingArea::ensureBackingStore): (WebKit::ChunkedUpdateDrawingArea::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingArea::platformPaint): (WebKit::ChunkedUpdateDrawingArea::drawUpdateChunkIntoBackingStore):
  • UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp: (WebKit::ChunkedUpdateDrawingArea::page): (WebKit::ChunkedUpdateDrawingArea::ensureBackingStore): (WebKit::ChunkedUpdateDrawingArea::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingArea::platformPaint): (WebKit::ChunkedUpdateDrawingArea::drawUpdateChunkIntoBackingStore):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView):
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
15:09 Changeset [61582] by andersca@apple.com

Another Tiger build fix.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

14:40 Changeset [61581] by andersca@apple.com

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

More WebBasePluginPackage cleanup
https://bugs.webkit.org/show_bug.cgi?id=40944

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::pluginCancelledConnectionError):
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::pluginCancelledConnectionError):
  • Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::pluginName):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage finalize]): (-[WebBasePluginPackage pluginInfo]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:WebCore::]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage isJavaPlugIn]): (-[WebBasePluginPackage versionNumber]): (-[WebBasePluginPackage WebCore::]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _initWithPath:]): (-[WebNetscapePluginPackage _applyDjVuWorkaround]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage supportsSnapshotting]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage load]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
14:39 Changeset [61580] by robert@webkit.org

2010-06-21 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html

It's a Mac-specific test so just add the required LayoutTestController
function as a no-op to avoid failing. Similar approach adopted by other
ports.

https://bugs.webkit.org/show_bug.cgi?id=33344

  • platform/qt/Skipped:

2010-06-21 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html

It's a Mac-specific test so just add the required LayoutTestController
function as a no-op to avoid failing. Similar approach adopted by other
ports.

https://bugs.webkit.org/show_bug.cgi?id=33344

  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::addDisallowedURL):
14:36 Changeset [61579] by weinig@apple.com

Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
Add message passing support to the WebKit2 API.

Reviewed by Anders Carlsson.

WebKit2:

Adds message passing for both InjectedBundle -> WebContext
and WebContext -> InjectedBundle.

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: Added.

(WebProcessProxyMessage::):
(CoreIPC::):

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetInjectedBundleClient):
(WKContextPostMessageToInjectedBundle):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeInjectedBundleClient):
(WebKit::WebContext::forwardMessageToWebContext):
(WebKit::WebContext::postMessageToInjectedBundle):

  • UIProcess/WebContext.h:
  • UIProcess/WebContextInjectedBundleClient.cpp: Added.

(WebKit::WebContextInjectedBundleClient::WebContextInjectedBundleClient):
(WebKit::WebContextInjectedBundleClient::initialize):
(WebKit::WebContextInjectedBundleClient::didRecieveMessageFromInjectedBundle):

  • UIProcess/WebContextInjectedBundleClient.h: Added.
  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::processDidClose):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveInjectedBundleMessage):
(WebKit::WebProcessProxy::didReceiveMessage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostMessage):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::didCreatePage):
(WebKit::InjectedBundle::didRecieveMessage):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::loadInjectedBundle):
(WebKit::WebProcess::forwardMessageToInjectedBundle):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:

WebKitTools:

  • Add some test messages.
  • MiniBrowser/mac/AppDelegate.m:

(_didRecieveMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didClearWindow):
(_didCreatePage):
(_didRecieveMessage):
(WKBundleInitialize):

14:07 Changeset [61578] by robert@webkit.org

2010-06-21 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Missing forward entries when dumping back/forward list

These now pass.
https://bugs.webkit.org/show_bug.cgi?id=32470

http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html
http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html

  • platform/qt/Skipped:
14:01 Changeset [61577] by sullivan@apple.com

Fixed bugzilla URL in previous checkin.

13:59 Changeset [61576] by sullivan@apple.com

RetainPtr can't be used in HashMaps or HashSets
<https://bugs.webkit.org/post_bug.cgi>

Reviewed by Adam Roben.

Added hashing knowledge similar to that in COMPtr.h.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::RetainPtr):
New function, copied from COMPtr.h but for the type change.
(WTF::RetainPtr::isHashTableDeletedValue):
Ditto.
(WTF::RetainPtr::hashTableDeletedValue):
Ditto.
Added template code for HashTraits and PtrHash copied from COMPtr.h but for the type change.
The only difference is that constructDeletedValue() matches the RefPtr implementation (in HashTraits.h)
rather than the COMPtr implementation.

13:59 Changeset [61575] by robert@webkit.org

2010-06-21 Robert Hogan <robert@webkit.org>

[Qt] Build fix for Qt on Windows MSVC2008

Unreviewed, build fix.

Fix by Jocelyn Turcotte.

  • Api/qwebframe.cpp:
13:50 Changeset [61574] by andersca@apple.com

Another PowerPC build fix.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage openResourceFile]):
(-[WebNetscapePluginPackage _tryLoad]):

13:48 Changeset [61573] by dglazkov@chromium.org

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Mark hyphenation tests as failing on Chromium
Hyphenation landed in http://trac.webkit.org/changeset/61548.

  • platform/chromium/test_expectations.txt: Added failing tests.
13:40 Changeset [61572] by japhet@chromium.org

2010-06-21 Nate Chapin <japhet@chromium.org>

Unreviewed, Windows build fix.

Update WebFrame to use FrameLoaderStateMachine in

firstLayoutDone().

  • WebFrame.cpp: (WebFrame::firstLayoutDone):
13:32 Changeset [61571] by andersca@apple.com

Try to fix the PowerPC build.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

13:26 Changeset [61570] by dumi@chromium.org

Unreviewed, fixing a test expectations on Windows.

  • platform/win/fast/dom/prototype-inheritance-expected.txt:
13:20 Changeset [61569] by japhet@chromium.org

2010-06-21 Nate Chapin <japhet@chromium.org>

Unreviewed, build fix.

Bad merge, left a reference to m_committedFirstRealDocumentLoad in
http://trac.webkit.org/changeset/61568.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):
13:06 Changeset [61568] by japhet@chromium.org

2010-06-21 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Remove a couple of FrameLoader's unused boolean members
(m_receivedData, m_cancellingWithLoadInProcess) and merge
several more into a single state machine called FrameLoaderStateMachine
(m_firstLayoutDone, m_creatingInitialEmptyDocument,
m_isDisplayingInitialEmptyDocument, m_committedFirstRealDocumentLoad).

https://bugs.webkit.org/show_bug.cgi?id=39695

Refactor only, so no new tests.

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): (WebCore::DocumentWriter::begin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::logCanCachePageDecision): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::frameHasLoaded): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::dispatchDidCommitLoad):
  • loader/FrameLoader.h: (WebCore::FrameLoader::stateMachine):
  • loader/FrameLoaderStateMachine.cpp: Added.
  • loader/FrameLoaderStateMachine.h: Added.
  • loader/HistoryController.cpp: (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::saveDocumentState):
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission):
12:58 Changeset [61567] by kevino@webkit.org

Build fix after conversion of WebInterfaceSystem to Obj-C++.

12:57 Changeset [61566] by kevino@webkit.org

[wx] Build fix. Fix header includes for ENABLE(DATABASE)

12:22 Changeset [61565] by dglazkov@chromium.org

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Dan Bernstein.

Chromium/Mac build fix.

  • WebCoreSupport/WebSystemInterface.mm: Change the order of wtf/Platform.h include to let other

headers smell it.

12:11 Changeset [61564] by atwilson@chromium.org

WebKitTools: Unreviewed.

Rolling back 61551 and 61555 due to test failures.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setEditingBehavior):

  • DumpRenderTree/mac/UIDelegate.mm:

LayoutTests: Unreviewed rollback.

Rolling back 61551 and 61555 due to test failures on Linux/Win.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-frame-getter-precedence.html:
  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-name-getter-precedence.html:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/events/resources/modal-dialog.html: Removed.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Removed.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Removed.
  • fast/harness/resources/modal-dialog.html: Removed.
  • fast/harness/show-modal-dialog-expected.txt: Removed.
  • fast/harness/show-modal-dialog.html: Removed.
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
11:57 Changeset [61563] by andersca@apple.com

WebKit2: Make WebKit2 build with clang++

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView keyUp:]):
(-[WKView keyDown:]):

  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:

WebKitTools: Make DumpRenderTree build with clang++

Reviewed by Sam Weinig.

  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:

(-[LocalPasteboard setPropertyList:forType:]):

  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow keyDown:]):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::elementDoesAutoCompleteForElementWithId):
(LayoutTestController::isCommandEnabled):

11:41 Changeset [61562] by andersca@apple.com

Make all of WebKit build with clang++

Reviewed by Dan Bernstein.

  • DefaultDelegates/WebDefaultPolicyDelegate.m:

(-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setSuppressLayout:]):

  • WebView/WebHTMLRepresentation.mm:
  • WebView/WebNavigationData.mm:

(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):

  • WebView/WebPDFRepresentation.mm:

(-[WebPDFRepresentation setDataSource:]):
(-[WebPDFRepresentation receivedData:withDataSource:]):
(-[WebPDFRepresentation receivedError:withDataSource:]):

  • WebView/WebResource.mm:

(-[WebResource description]):

  • WebView/WebSerializedJSValue.mm:

(-[WebSerializedJSValue initWithValue:context:exception:]):

  • WebView/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController WebCore::]):
(-[WebVideoFullscreenController setMediaElement:WebCore::]):
(-[WebVideoFullscreenController setDelegate:]):
(-[WebVideoFullscreenController enterFullscreen:]):

  • WebView/WebView.mm:

(-[WebView _openFrameInNewWindowFromMenu:]):
(-[WebView _geolocationDidChangePosition:]):

11:38 Changeset [61561] by mitz@apple.com

Speculative build fix.

  • WebKitSystemInterface.h:
11:29 Changeset [61560] by andersca@apple.com

Fix clang++ build.

  • loader/FormSubmission.h:
11:19 Changeset [61559] by dglazkov@chromium.org

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Add a missing include in AsyncImageResizer.h

  • html/AsyncImageResizer.h: Added the IntSize include.
11:02 Changeset [61558] by andersca@apple.com

2010-06-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove unused dictionary ivars from WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40928

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10:51 Changeset [61557] by dglazkov@chromium.org

2010-06-21 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations tweak.

Use C++-style comments rather than Python-style.

  • platform/chromium/test_expectations.txt: Tweaked comment style.
10:46 Changeset [61556] by mitz@apple.com

Build fix

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

10:44 Changeset [61555] by atwilson@chromium.org

2010-06-21 Drew Wilson <atwilson@chromium.org>

Unreviewed.

Missing files from r61551.

  • fast/events/resources/modal-dialog.html: Added.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Added.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Added.
  • fast/harness/resources/modal-dialog.html: Added.
  • fast/harness/show-modal-dialog-expected.txt: Added.
  • fast/harness/show-modal-dialog.html: Added.
10:43 Changeset [61554] by aroben@apple.com

Call NotifyAddrChange again each time we are notified of a change

NotifyAddrChange only notifies you of a single change. If you want to
listen for subsequent changes, you have to call it again.

Fixes <http://webkit.org/b/33004> NetworkStateNotifier ignores all
state changes after the first.

No test possible, as we don't have a way to modify the system's
network adapters when running tests.

Reviewed by Anders Carlsson.

  • platform/network/win/NetworkStateNotifierWin.cpp:

(WebCore::NetworkStateNotifier::addrChangeCallback): Call
registerForAddressChange as soon as we're notified of an address
change, so we'll also get notified of the *next* address change. I
added the call here instead of in addressChanged (which is called
later on the main thread) to minimize the time between the callback
and registering again (so that we won't miss changes that happen in
rapid succession).

10:43 Changeset [61553] by oliver@apple.com

2010-06-19 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Need to ensure that we grow the RegisterFile when creating a callframe for host code
https://bugs.webkit.org/show_bug.cgi?id=40858
<rdar://problem/8108986>

In the past the use of the callframe in hostcode was much more
limited. Now that we expect the callframe to always be valid
we need to grow the RegisterFile so that this is actually the
case. In this particular case the problem was failing to grow
the registerfile could lead to a callframe that extended beyond
RegisterFiler::end(), so vm re-entry would clobber the callframe
other scenarios could also lead to badness.

I was unable to construct a simple testcase to trigger badness,
and any such testcase would be so dependent on exact vm stack
layout that it would be unlikely to work as a testcase following
any callframe or register allocation changes anyway.

Thankfully the new assertion I added should help to catch these
failures in future, and triggers on a couple of tests currently.

  • interpreter/CallFrame.cpp: (JSC::CallFrame::registerFile):
  • interpreter/CallFrame.h: (JSC::ExecState::init):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
10:21 Changeset [61552] by mitz@apple.com

Release build fix

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating):

10:17 Changeset [61551] by atwilson@chromium.org

DumpRenderTree should allow tests with modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=35350

Patch by Prasad Tammana <prasadt@chromium.org> on 2010-06-21
Reviewed by Darin Adler.

  • DumpRenderTree/LayoutTestController.cpp:

(abortModalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::abortModal):
Add abortModal method to LayoutTestController and make it available from script.

.:

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

WebKitTools:

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

10:14 Changeset [61550] by leandro@webkit.org

2010-06-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed debug build fix.

[CMake] Do not force build type to Release
https://bugs.webkit.org/show_bug.cgi?id=40566

  • CMakeLists.txt:
10:07 Changeset [61549] by mitz@apple.com

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Fixed a typo.
09:54 Changeset [61548] by mitz@apple.com

WebCore: CSS3: Implement the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

Tests: fast/text/hyphenate-character.html

fast/text/hyphens.html

Added -webkit-hyphens and -webkit-hyphenate-character as specified in
<http://www.w3.org/TR/2010/WD-css3-gcpm-20100608/#hyphenation>.

  • Android.mk: Added Hyphenation.cpp.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Added Hyphenation.{cpp,h}.
  • WebCore.base.exp: Exported wkGetHyphenationLocationBeforeIndex().
  • WebCore.gypi: Added Hyphenation.{cpp,h}.
  • WebCore.pro: Added Hyphenation.{cpp,h}.
  • WebCore.vcproj/WebCore.vcproj: Added Hyphenation.{cpp,h}.
  • WebCore.xcodeproj/project.pbxproj: Added Hyphenation.{cpp,h}.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added the -webkit-hyphenate-character
and -webkit-hyphens cases.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Validate values for the new properties.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added. Maps from a Hyphens value to an identifier.
(WebCore::CSSPrimitiveValue::operator Hyphens): Added. Maps from an identifier to a Hyphens value.

  • css/CSSPropertyNames.in: Added -webkit-hyphenate-character and -webkit-hyphens.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Apply the new properties to the RenderStyle.

  • css/CSSValueKeywords.in:
  • platform/mac/WebCoreSystemInterface.h: Added wkGetHyphenationLocationBeforeIndex.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • platform/text/CharacterNames.h: Added the hyphen character.
  • platform/text/Hyphenation.cpp: Added.

(WebCore::lastHyphenLocation): Added this default implementation for platforms that do not implement
hyphenation yet. It calls notImplemented() and returns 0.

  • platform/text/Hyphenation.h: Added.
  • platform/text/cf/HyphenationCF.cpp: Added.

(WebCore::lastHyphenLocation): Returns the last hyphenation location occurring in the given string before
the given index. Uses the current search locale (which is based on the top language preference of the user)
for hyphenation.

  • platform/text/mac/HyphenationMac.mm: Added.

(WebCore::lastHyphenLocation): Returns the last hyphenation location occurring in the given string before
the given index. Returns 0 if the current search locale is not "en", because the platform only knows how to
hyphenate English.

  • rendering/BidiRun.h:

(WebCore::BidiRun::BidiRun): Added a boolean member, m_hasHyphen, and initialized it to false in the constructor.

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox): Renamed m_hasEllipsisBox to m_hasEllipsisBoxOrHyphen, because this bit is now
shared by two subclass: RootInlineBox uses it for hasEllipsisBox(), while InlineTextBox uses it for hasHyphen().

  • rendering/InlineTextBox.cpp:

(WebCore::adjustCharactersAndLengthForHyphen): Added this helper function to get the hyphen string from the style
and return a UChar* and length for the concatenation of the given text with the hyphen string.
(WebCore::InlineTextBox::selectionRect): If the selected range touches the end and the box has a hyphen,
compute the width of the text with the hyphen string concatenated to it.
(WebCore::InlineTextBox::paint): If the box has a hyphen, draw the text with the hyphen string concatenated to it.
(WebCore::InlineTextBox::paintSelection): Similarly concatenate the hyphen string.

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::hasHyphen): Added this accessor.
(WebCore::InlineTextBox::setHasHyphen): Ditto.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::constructLine): Copy the m_hasHyphen flag from the run to its text box.
(WebCore::RenderBlock::computeHorizontalPositionsForLine): Add the width of the hyphen string when computing the
width of a box that has a hyphen.
(WebCore::RenderBlock::layoutInlineChildren): If the line was hyphenated, set the m_hasHyphen flag on the
logically last run.
(WebCore::tryHyphenating): Added this helper function which checks if a piece of text that does not fit on the
line could be hyphenated such that the part before the hyphen, including the hyphen, would fit. Given the amount
of space remaining on the line, it finds the longest prefix that can fit in the remaining space (which leaving room for
the hyphen), and then checks for a hyphenation location within that prefix.
(WebCore::RenderBlock::findNextLineBreak): In the 'hyphens: none' case, prevent line breaks at soft hyphens.
In the 'hyphens: auto' case, try hyphenating when a word will not fit in the remaining space on the line.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::detachEllipsisBox): Changed to use hasEllipsisBox() and setHasEllipsisBox().
(WebCore::RootInlineBox::clearTruncation): Ditto.
(WebCore::RootInlineBox::placeEllipsis): Ditto.
(WebCore::RootInlineBox::paintEllipsisBox): Ditto.
(WebCore::RootInlineBox::nodeAtPoint): Ditto.
(WebCore::RootInlineBox::ellipsisBox): Ditto.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasEllipsisBox): Added this accessor.
(WebCore::RootInlineBox::setHasEllipsisBox): Ditto.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Return a layout hint if the hyphens setting or hyphenate-character differs.
(WebCore::RenderStyle::hyphenString): Added. For hyphenate-character: auto, returns the hyphen character.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphens): Added this accessor.
(WebCore::InheritedFlags::hyphenateCharacter): Ditto.
(WebCore::InheritedFlags::setHyphens): Ditto.
(WebCore::InheritedFlags::setHyphenateCharacter): Ditto.
(WebCore::InheritedFlags::initialHyphens): Added. Returns HyphensManual.
(WebCore::InheritedFlags::initialHyphenateCharacter): Added. Returns the null string, corresponding to
a value of 'auto'.

  • rendering/style/RenderStyleConstants.h:

Added a Hyphens enum.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize and copy the new members.
(WebCore::StyleRareInheritedData::operator==): Compare the new members.

  • rendering/style/StyleRareInheritedData.h: Added two new members: hyphens and hyphenateCharacter.

WebKit/mac: WebKit part of implementing the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkGetHyphenationLocationBeforeIndex.

WebKitLibraries: WebKitSystemInterface part of CSS3: Implement the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • WebKitSystemInterface.h: Added WKGetHyphenationLocationBeforeIndex().
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

LayoutTests: Added tests for the 'hyphens' and 'hyphenate-character' properties
https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • fast/text/hyphenate-character.html: Added.
  • fast/text/hyphens.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/fast/text/hyphenate-character-expected.checksum: Added.
  • platform/mac/fast/text/hyphenate-character-expected.png: Added.
  • platform/mac/fast/text/hyphenate-character-expected.txt: Added.
  • platform/mac/fast/text/hyphens-expected.checksum: Added.
  • platform/mac/fast/text/hyphens-expected.png: Added.
  • platform/mac/fast/text/hyphens-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:
09:39 Changeset [61547] by dglazkov@chromium.org

2010-06-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Enable EVENTSOURCE, FILE_WRITER, and IMAGE_RESIZER
https://bugs.webkit.org/show_bug.cgi?id=40905

EVENTSOURCE: It is already enabled in Chromium browser. This fixes
some tests with Chromium DRT.

FILE_WRITER and IMAGE_RESIZER: Enable experimental features in
order to test them before enabling them in Chromium browser.

  • features.gypi:
09:36 Changeset [61546] by dglazkov@chromium.org

2010-06-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Plumb FormSubmission through to ScheduledFormSubmission.
https://bugs.webkit.org/show_bug.cgi?id=40137

No behavior change, covered by existing tests.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission): Moved creation of action URL

instance here from FrameLoader::submit, because it makes more sense here,
also added a FIXME to investigate existing code later.

  • loader/FormSubmission.cpp: (WebCore::FormSubmission::FormSubmission): Changed action to be a KURL, not a String. (WebCore::FormSubmission::create): Ditto. (WebCore::FormSubmission::populateFrameLoadRequest): Added, moving the logic from

FrameLoader::submit closer to the data.

  • loader/FormSubmission.h: (WebCore::FormSubmission::action): Changed type to KURL. (WebCore::FormSubmission::clearTarget): Added. (WebCore::FormSubmission::referrer): Added. (WebCore::FormSubmission::setReferrer): Added. (WebCore::FormSubmission::origin): Added. (WebCore::FormSubmission::setOrigin): Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Cleaned up to make it more about decision-making,

not data manipulation.

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): Changed to accept FormSubmission as argument. (WebCore::ScheduledFormSubmission::fire): Changed to use FormSubmission. (WebCore::RedirectScheduler::scheduleFormSubmission): Removed assert that no longer makes sense,

changed to use FormSubmission.

  • loader/RedirectScheduler.h: Updated ScheduledFormSubmission decl to hold FormSubmission ref.
09:02 Changeset [61545] by eric@webkit.org

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • configure.ac:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

No new tests are needed, because there is no new functionality.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • features.gypi:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-06-21 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
https://bugs.webkit.org/show_bug.cgi?id=40878

  • Scripts/build-webkit:
08:50 Changeset [61544] by eric@webkit.org

2010-06-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Use global new/delete operator overloading with USE_SYSTEM_MALLOC=1
https://bugs.webkit.org/show_bug.cgi?id=40653

Currently, other ports do not use global new/delete operator overloading
when USE_SYSTEM_MALLOC=1. Brew MP uses system malloc, but it needs to enable
"global fastMalloc new" because the default new/delete causes crash on device.
We need to replace them with Brew MP's MALLOC/FREE.

  • wtf/FastMalloc.h:
08:50 Changeset [61543] by jocelyn.turcotte@nokia.com

[Qt] Fix MSVC build.

Reviewed by nobody, build fix.

The max macro was replacing the max function used in StringImpl.h
when compiling moc_NotificationPresenterClientQt.cpp.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:
07:50 Changeset [61542] by eric@webkit.org

2010-06-21 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Delete DOM storage databases when they are empty.
https://bugs.webkit.org/show_bug.cgi?id=40767

Even if a page clears its local storage, the database file for it stays around,
and there is currently no mechanism that deletes them.

After doing the "final sync" of a storage area, the StorageAreaSyncMaster should
see if the database is empty, and in that case delete it.

Tests:

manual-tests/localstorage-empty-database.html

  • manual-tests/localstorage-empty-database.html: Added link to clear local storage for testing that the file is removed.
  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask): Added local storage task type DeleteEmptyDatabase. (WebCore::LocalStorageTask::performTask): Ditto.
  • storage/LocalStorageTask.h: (WebCore::LocalStorageTask::): Ditto. (WebCore::LocalStorageTask::createDeleteEmptyDatabase): Ditto.
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::scheduleFinalSync): When scheduling final sync, also schedule DeleteEmptyDatabase. (WebCore::StorageAreaSync::sync): Return early if final sync has nothing to sync. (WebCore::StorageAreaSync::deleteEmptyDatabase): Added function to check if a database is empty and in that case delete it.
  • storage/StorageAreaSync.h: Ditto.
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase): Added function for scheduling DeleteEmptyDatabase task.
  • storage/StorageSyncManager.h: Ditto.
07:36 Changeset [61541] by eric@webkit.org

2010-06-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Initialization for http/tests/loading/
https://bugs.webkit.org/show_bug.cgi?id=40902

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
07:08 Changeset [61540] by eric@webkit.org

2010-06-21 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Avoid unnecessary image conversion in RGBA32Buffer::zeroFill()
https://bugs.webkit.org/show_bug.cgi?id=40910

  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::zeroFill):
06:37 Changeset [61539] by mnaganov@chromium.org

2010-06-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by NOBODY (OOPS!).

[Chromium] Remove usage of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.

Also, move WebDevToolsMessageTransport to its own header file.

https://bugs.webkit.org/show_bug.cgi?id=40913

  • DEPS:
  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsMessageTransport.h: Added. (WebKit::WebDevToolsMessageTransport::~WebDevToolsMessageTransport):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::):
05:14 Changeset [61538] by laszlo.1.gombos@nokia.com

2010-06-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
04:43 Changeset [61537] by hausmann@webkit.org

Unreviewed build fix.

[Qt] Fix package builds

Don't use rpath unless we're building inside the trunk.

  • declarative/declarative.pro:
02:40 Changeset [61536] by jocelyn.turcotte@nokia.com

[Qt] Work around a build problem with libjscore on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=40840

Reviewed by Simon Hausmann.

Sbsv2 sometimes have problems with debug/release configuration
determination causing QtWebKit in release to try linking with the debug
JavaScriptCore static library. This patch limit the jscore/jscored
r58306 fix necessary for mac builds only to the mac platform to prevent the
different name problem.

The real fix would be to fix qmake or the toolchain, this patch might
help meanwhile.

02:33 Changeset [61535] by jocelyn.turcotte@nokia.com

Adding myself to the committers list.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
01:30 Changeset [61534] by eric@webkit.org

2010-06-21 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Decode images directly to QPixmap
https://bugs.webkit.org/show_bug.cgi?id=40797

Decode images to QPixmap directly instead of QImage when possible.
RGBA32Buffer transforms the pixmap back to image if
necessary.

This improve the performance with certain graphic system, and
can reduce memory usage.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::internalHandleCurrentImage):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::setPixmap):
01:10 Changeset [61533] by eric@webkit.org

2010-06-21 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

Buildfix after r61338.
https://bugs.webkit.org/show_bug.cgi?id=40888

roundUpAllocationSize is needed in RegisterFile.h.

  • jit/ExecutableAllocator.h:
00:59 Changeset [61532] by dumi@chromium.org

Unreviewed, fixing expectations.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
00:10 Changeset [61531] by dumi@chromium.org

Adding the SQLException class which will be used to report sync DB errors.
https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Adam Barth.

WebCore:

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • bindings/v8/V8Proxy.h:
  • dom/ExceptionCode.cpp:

(WebCore::):
(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:

(WebCore::):

  • page/DOMWindow.idl:
  • storage/SQLException.h: Added.

(WebCore::SQLException::create):
(WebCore::SQLException::):
(WebCore::SQLException::SQLException):

  • storage/SQLException.idl: Added.

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
00:06 Changeset [61530] by eric@webkit.org

2010-06-20 Hayato Ito <hayato@chromium.org>

Reviewed by Kent Tamura.

Add tests for CSS3 Paged Media to make sure page breaks should happen at right places.
Two tests (allowed-page-break and page-break-margin-collapsed) are expected to fail
due to lack of support.

https://bugs.webkit.org/show_bug.cgi?id=40770

  • printing/allowed-page-breaks-expected.txt: Added.
  • printing/allowed-page-breaks.html: Added.
  • printing/no-content-empty-pages-expected.txt: Added.
  • printing/no-content-empty-pages.html: Added.
  • printing/page-break-display-none-expected.txt: Added.
  • printing/page-break-display-none.html: Added.
  • printing/page-break-margin-collapsed-expected.txt: Added.
  • printing/page-break-margin-collapsed.html: Added.
  • printing/script-tests/allowed-page-breaks.js: Added. (test):
  • printing/script-tests/no-content-empty-pages.js: Added. (test):
  • printing/script-tests/page-break-display-none.js: Added. (test):
  • printing/script-tests/page-break-margin-collapsed.js: Added. (test):

06/20/10:

23:44 Changeset [61529] by yurys@chromium.org

2010-06-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if browser exposes
v8 debugging protocol.
https://bugs.webkit.org/show_bug.cgi?id=40844

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::setEnabled): (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
  • bindings/v8/ScriptDebugServer.h:

2010-06-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: don't add ScriptDebugServer as v8 listener if browser exposes
v8 debugging protocol.

  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
22:28 Changeset [61528] by eric@webkit.org

2010-06-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break for r61527
https://bugs.webkit.org/post_bug.cgi

  • CMakeLists.txt: Add loader/FormSubmission.cpp
21:38 Changeset [61527] by tkent@chromium.org

2010-06-20 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Add --allow-external-pages option
https://bugs.webkit.org/show_bug.cgi?id=40762

Add --allow-external-pages introduced by Chromium r45403.
http://src.chromium.org/viewvc/chrome?view=rev&revision=45403

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::allowExternalPages): (TestShell::setAllowExternalPages):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willSendRequest):
20:35 Changeset [61526] by andersca@apple.com

Fix Tiger build.

  • Plugins/WebNetscapePluginPackage.mm:
20:20 Changeset [61525] by andersca@apple.com

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of the old MIMETypes getter method
https://bugs.webkit.org/show_bug.cgi?id=40898

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:WebCore::]): (-[WebBasePluginPackage MIMETypeForExtension:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
19:58 Changeset [61524] by andersca@apple.com

Remove bogus const qualifiers.

Reviewed by Dan Bernstein.

WebCore:

  • platform/mac/PasteboardHelper.h:

WebKit/mac:

  • WebCoreSupport/WebPasteboardHelper.h:
  • WebCoreSupport/WebPasteboardHelper.mm:

(WebPasteboardHelper::urlFromPasteboard):
(WebPasteboardHelper::plainTextFromPasteboard):
(WebPasteboardHelper::fragmentFromPasteboard):

19:34 Changeset [61523] by andersca@apple.com

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Get rid of the extensionToMIME mapping in WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40897

Instead of using the extensionToMIME mutable dictionary, use the MIME types vector.
While this makes lookup of MIME types based on extensions linear instead of constant,
the number of extensions per plug-in is too small for it to matter.

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
19:13 Changeset [61522] by andersca@apple.com

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add a MimeClassInfo Vector to WebBasePluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40896

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage WebCore::]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
19:12 Changeset [61521] by eric@webkit.org

2010-06-20 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

Buildfix for NotificationCenter.h.
https://bugs.webkit.org/show_bug.cgi?id=40890

ScriptExecutionContext::completeURL is used in header,
but ScriptExecutionContext.h wasn't included.

  • notifications/NotificationCenter.h:
18:38 Changeset [61520] by tkent@chromium.org

2010-06-20 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Update for other <meter> tests and flaky/slow tests
18:30 Changeset [61519] by andersca@apple.com

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Move the NSBundle ivar to WebPluginPackage
https://bugs.webkit.org/show_bug.cgi?id=40894

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _initWithPath:]):
  • Plugins/WebPluginPackage.h:
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage dealloc]): (-[WebPluginPackage viewFactory]): (-[WebPluginPackage load]):
18:05 Changeset [61518] by eric@webkit.org

2010-06-20 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Test to make sure parsing of async attribute works for HTML script tags
and test to make sure that async is not parsed for SVG script tags.
https://bugs.webkit.org/show_bug.cgi?id=39026

  • fast/dom/HTMLScriptElement/script-async-attr-expected.txt: Added.
  • fast/dom/HTMLScriptElement/script-async-attr.html: Added.
  • svg/dom/SVGScriptElement/script-async-attr-expected.txt: Added.
  • svg/dom/SVGScriptElement/script-async-attr.svg: Added.

2010-06-20 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Recognize async attribute on HTML script tags.
https://bugs.webkit.org/show_bug.cgi?id=39026

This does not implement async behavior, it only parses the async
attribute for HTML script tags. SVG script tags continue to not
support the async attribute.

Tests: fast/dom/HTMLScriptElement/script-async-attr.html

svg/dom/SVGScriptElement/script-async-attr.svg

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::isAsynchronous): (WebCore::ScriptElementData::isDeferred):
  • dom/ScriptElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::async): (WebCore::HTMLScriptElement::setAsync): (WebCore::HTMLScriptElement::defer): (WebCore::HTMLScriptElement::asyncAttributeValue): (WebCore::HTMLScriptElement::deferAttributeValue):
  • html/HTMLScriptElement.h:
  • html/HTMLScriptElement.idl:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::asyncAttributeValue): (WebCore::SVGScriptElement::deferAttributeValue):
  • svg/SVGScriptElement.h:
17:44 Changeset [61517] by tony@chromium.org

2010-06-20 Tony Chang <tony@chromium.org>

Not reviewed, just cleaning up svn.

Removing platform/mac-snowleopard/editing since it's empty. The test
results were moved in r60693.

  • platform/mac-snowleopard/editing: Removed.
  • platform/mac-snowleopard/editing/spelling: Removed.
16:15 Changeset [61516] by jberlin@webkit.org

2010-06-20 Jessie Berlin <jberlin@apple.com>

Reviewed by Dan Bernstein.

Add #if USE(PLATFORM_STRATEGIES) where WebPlatformStrategies is being used.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): Only initialize the web platform strategies if PLATFORM_STRATEGIES is being used.
15:51 Changeset [61515] by eric@webkit.org

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Adam Barth.

Sheriffbot: Should allow "r" in SVN_REVISION
https://bugs.webkit.org/show_bug.cgi?id=40889

  • Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
15:32 Changeset [61514] by eric@webkit.org

2010-06-20 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Joseph Pecoraro.

Web Inspector: Auto-completion for CSS property names in Styles pane
https://bugs.webkit.org/show_bug.cgi?id=17374

Added autocompletion for CSS properties. A suggestion for a property
shows when you type. You can also cycle through known property names
using the Up and Down arrow keys.

  • WebCore.gypi:
  • inspector/front-end/CSSCompletions.js: Added. (WebInspector.CSSCompletions): (WebInspector.CSSCompletions.startsWith): (WebInspector.CSSCompletions.firstStartsWith): (WebInspector.CSSCompletions._firstIndexOfPrefix): (WebInspector.CSSCompletions.next): (WebInspector.CSSCompletions.previous): (WebInspector.CSSCompletions._closest):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js: (Text.prototype.select): ():
14:30 Changeset [61513] by joepeck@webkit.org

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Dimitri Glazkov.

Python Tests Fail after r61508
https://bugs.webkit.org/show_bug.cgi?id=40891

Test's regex list needed to be updated to match the new
regex list in the source code. Added new bots to the
example_buildbots list.

Regex list fixed in r61512. Updated bot list.

  • Scripts/webkitpy/common/net/buildbot_unittest.py:
14:14 Changeset [61512] by dglazkov@chromium.org

2010-06-20 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.

  • Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
14:00 Changeset [61511] by dglazkov@chromium.org

2010-06-14 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Introduce FormSubmission, the structure representing a form submission.
https://bugs.webkit.org/show_bug.cgi?id=40084

No change in functionality, covered by existing tests.

  • GNUmakefile.am: Added FormSubmission.h/cpp.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission): Renamed prepareFormData to prepareFormSubmission,

added code for populating a FormSubmission instance, moved the loop of accumulating text input
values into this functions (it belongs here logically).

(WebCore::HTMLFormElement::submit): Modified to use prepareFormSubmission.

  • html/HTMLFormElement.h:
  • loader/FormSubmission.cpp: Added.
  • loader/FormSubmission.h: Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Modified to use FormSubmission. Stopped plumbing further to keep

the patch size down.

  • loader/FrameLoader.h: Modified submitForm signature.
13:53 Changeset [61510] by andersca@apple.com

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove -[WebBasePluginPackage bundle]
https://bugs.webkit.org/show_bug.cgi?id=40892

Add -[WebBasePluginPackage bundleIdentifier] and switch clients over to it.


Move the supportsSnapshotting method over to the plug-in package.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebBaseNetscapePluginView supportsSnapshotting]):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage isQuickTimePlugIn]): (-[WebBasePluginPackage isJavaPlugIn]): (-[WebBasePluginPackage WebCore::]): Call bundleIdentifier directly instead of asking the bundle
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage supportsSnapshotting]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setAttributeKeys:andValues:]): (-[WebNetscapePluginView _createPlugin]):
  • Plugins/WebPluginDatabase.mm: (checkCandidate):
13:27 Changeset [61509] by andersca@apple.com

2010-06-20 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
https://bugs.webkit.org/show_bug.cgi?id=40869


Re-land r61459, with extra null-checks in WebFrameLoaderClient.

  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage name]): (-[WebBasePluginPackage path]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage pluginDescription]): (-[WebBasePluginPackage description]): (-[WebBasePluginPackage isJavaPlugIn]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage load]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
11:58 Changeset [61508] by wsiegrist@apple.com

2010-06-20 William Siegrist <wsiegrist@apple.com>

Unreviewed. Make core builder regexp more specific so new Chromium test slaves do not get core builder status.

11:55 Changeset [61507] by joepeck@webkit.org

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Unreviewed rollout r61506, because it made 1 test crash.

Causes crash. Will approach the solution in a different way.

10:02 Changeset [61506] by joepeck@webkit.org

2010-06-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Timothy Hatcher.

Web Inspector: Should Autocomplete Style Properties
https://bugs.webkit.org/show_bug.cgi?id=38448

This Autocompletes style properties when in the console.

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
05:54 Changeset [61505] by robert@webkit.org

2010-06-20 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • platform/qt/Skipped:

2010-06-20 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

https://bugs.webkit.org/show_bug.cgi?id=36702

setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
work for DRT. So call it if we are in DRT mode and the window geometry
has changed.

Unskips plugins/reentrant-update-widget-positions.html

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
04:46 Changeset [61504] by eric@webkit.org

2010-06-20 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

The QWebHistory regression fix.

After change r51629 and r61207 QWebHistory's function back(),
forward(), goToItem() got broken.

Use page->goToItem() instead of direct actions on the BackForwardList.

[Qt] REGRESSION(r61207): qwebhistory unit test hangs
https://bugs.webkit.org/show_bug.cgi?id=40672

  • Api/qwebhistory.cpp: (QWebHistory::back): (QWebHistory::forward): (QWebHistory::goToItem):
  • tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::init): (tst_QWebHistory::back): (tst_QWebHistory::forward):

06/19/10:

20:37 Changeset [61503] by jschuh@chromium.org

2010-06-19 Justin Schuh <jschuh@chromium.org>

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
18:03 Changeset [61502] by eric@webkit.org

2010-06-19 Hayato Ito <hayato@chromium.org>

Reviewed by Adam Barth.

Add tests for CSS 'orphans' and 'widows' properties.
All tests are expected to fail due to lack of implementations.

https://bugs.webkit.org/show_bug.cgi?id=40821

  • printing/page-break-orphans-and-widows-expected.txt: Added.
  • printing/page-break-orphans-and-widows.html: Added.
  • printing/page-break-orphans-expected.txt: Added.
  • printing/page-break-orphans.html: Added.
  • printing/page-break-widows-expected.txt: Added.
  • printing/page-break-widows.html: Added.
  • printing/script-tests/page-break-orphans-and-widows.js: Added. (test):
  • printing/script-tests/page-break-orphans.js: Added. (test):
  • printing/script-tests/page-break-widows.js: Added. (test):
17:50 Changeset [61501] by eric@webkit.org

2010-06-19 Hayato Ito <hayato@chromium.org>

Reviewed by Adam Barth.

Add tests for 'page-break-{before,after}: avoid'.
All tests are expected to fail due to lack of implementations.

https://bugs.webkit.org/show_bug.cgi?id=40814

  • printing/page-break-after-avoid-expected.txt: Added.
  • printing/page-break-after-avoid.html: Added.
  • printing/page-break-avoid-expected.txt: Added.
  • printing/page-break-avoid.html: Added.
  • printing/page-break-before-avoid-expected.txt: Added.
  • printing/page-break-before-avoid.html: Added.
  • printing/script-tests/page-break-after-avoid.js: Added. (test):
  • printing/script-tests/page-break-avoid.js: Added. (test):
  • printing/script-tests/page-break-before-avoid.js: Added. (test):
17:39 Changeset [61500] by weinig@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
Add ability to have a WebProcess per WebContext.

Reviewed by Anders Carlsson.

WebKit2:

  • Move to a one-to-one correspondence of WebContexts to WebProcessProxies.
  • Add explicit shared contexts for general use.
  • Only non-shared contexts can use injected bundles.
  • UIProcess/API/C/WKContext.cpp:

(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):
(WKContextGetSharedProcessContext):
(WKContextGetSharedThreadContext):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKContextPrivate.h:

Change API for WKContext to no longer take a WKProcessModel type and instead
have explicit Create/Get functions for the different kind of contexts. Added
two shared contexts, one threaded, one process, and made the threaded on private
for now.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:]):
Make WKViews that don't have an explicit context use the shared process
context by default.

  • UIProcess/Launcher/WebProcessLauncher.h:
  • UIProcess/Launcher/mac/WebProcessLauncher.mm:

(WebKit::launchWebProcess):

  • UIProcess/Launcher/win/WebProcessLauncher.cpp:

(WebKit::launchWebProcess):
Use a boolean argument to note whether we are using a thread or a process
instead of using the process model enum.

  • UIProcess/ProcessModel.h:

(WebKit::):
Convert to using explicit Shared modifier for shared contexts.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::sharedProcessContext):
(WebKit::WebContext::sharedThreadContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::reviveIfNecessary):

  • UIProcess/WebContext.h:

(WebKit::WebContext::create):
(WebKit::WebContext::process):

  • UIProcess/WebPageNamespace.cpp:

(WebKit::WebPageNamespace::createWebPage):
(WebKit::WebPageNamespace::preferencesDidChange):
(WebKit::WebPageNamespace::getStatistics):

  • UIProcess/WebPageNamespace.h:

(WebKit::WebPageNamespace::process):
(WebKit::WebPageNamespace::reviveIfNecessary):
Move WebProcessProxy creation logic up into WebContext.

  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::getWebProcess):
(WebKit::WebProcessManager::processDidClose):

  • UIProcess/WebProcessManager.h:

Keep a map of WebContexts to WebProcessProxies in addition to the two
shared processes.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::didClose):

  • UIProcess/WebProcessProxy.h:

Store a WebContext instead of the process model.

  • mac/WebKit2.exp:

Add new functions.

WebKitTools:

Move to use new shared contexts API.

  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate getCurrentPageNamespace]):
(-[BrowserAppDelegate validateMenuItem:]):
(-[BrowserAppDelegate _setProcessModel:]):
(-[BrowserAppDelegate setSharedProcessProcessModel:]):
(-[BrowserAppDelegate setSharedThreadProcessModel:]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

17:38 Changeset [61499] by eric@webkit.org

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

When V8 ScriptData caching was originally submitted it causes crashes
in external scripts with high-byte characters. This new test crashes on
the original code, but now passes.

  • fast/js/parser-high-byte-character-expected.txt: Added.
  • fast/js/parser-high-byte-character.html: Added.
  • fast/js/script-tests/parser-high-byte-character.js: Added. (runTest):

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Persist V8's ScriptData to the memory cache.
https://bugs.webkit.org/show_bug.cgi?id=38661

This stores V8's ScriptData in the memory cache and also causes the
network platform layer to be notified of the available cacheable
metadata.

Chromium's morejs benchmark showed a ~7% improvement when this was
originally submitted (before it had to be rolled back).

Test: fast/js/parser-high-byte-character.html

  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::cachedScript):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::precompileScript): (WebCore::V8Proxy::evaluate):
  • bindings/v8/V8Proxy.h:
14:48 Changeset [61498] by dglazkov@chromium.org

2010-06-19 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

  • platform/chromium/test_expectations.txt: Tuned expectations according to the bot result runs.
13:39 Changeset [61497] by abarth@webkit.org

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Add LayoutTest to ensure resources within <noscript> are not preloaded
https://bugs.webkit.org/show_bug.cgi?id=40849

  • fast/preloader/noscript-expected.txt: Added.
  • fast/preloader/noscript.html: Added.
  • fast/preloader/resources/noscript-image1.png: Copied from BugsSite/data/mail.
  • fast/preloader/resources/noscript-image2.png: Copied from BugsSite/data/mail.
10:24 Changeset [61496] by eric@webkit.org

2010-06-19 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port SocketStream
https://bugs.webkit.org/show_bug.cgi?id=39671

Port SocketStream with BREW MP's ISocket interface.

  • platform/network/brew/SocketStreamError.h: Added. (WebCore::SocketStreamError::SocketStreamError):
  • platform/network/brew/SocketStreamHandle.h: Added. (WebCore::SocketStreamHandle::create):
  • platform/network/brew/SocketStreamHandleBrew.cpp: Added. (WebCore::socketStreamConnectCallback): (WebCore::getHostByNameCallback): (WebCore::socketReadableCallback): (WebCore::networkManager): (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::~SocketStreamHandlePrivate): (WebCore::SocketStreamHandlePrivate::socketConnected): (WebCore::SocketStreamHandlePrivate::socketReadyRead): (WebCore::SocketStreamHandlePrivate::connect): (WebCore::SocketStreamHandlePrivate::send): (WebCore::SocketStreamHandlePrivate::close): (WebCore::SocketStreamHandlePrivate::socketClosed): (WebCore::SocketStreamHandlePrivate::socketError): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::~SocketStreamHandle): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::platformClose): (WebCore::SocketStreamHandle::didReceiveAuthenticationChallenge): (WebCore::SocketStreamHandle::receivedCredential): (WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): (WebCore::SocketStreamHandle::receivedCancellation):
  • platform/network/brew/SocketStreamHandlePrivate.h: Added.
10:11 Changeset [61495] by eric@webkit.org

2010-06-19 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Adding a < operator to WebURLs so they can be used in std::maps.
https://bugs.webkit.org/show_bug.cgi?id=40632

  • public/WebCString.h: (WebKit::operator<):
  • public/WebURL.h: (WebKit::operator<):
  • src/WebCString.cpp: (WebKit::WebCString::compare):
09:47 Changeset [61494] by eric@webkit.org

2010-06-19 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: subtitleElement.textContent is always empty. Use subtitleAsText method instead.
https://bugs.webkit.org/show_bug.cgi?id=40420

  • inspector/elements-tests.js: (frontend_getSelectedElementStyles):

2010-06-19 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: Prevent from copying "filename.css" in Styles pane
https://bugs.webkit.org/show_bug.cgi?id=40420

  • inspector/front-end/Section.js: (WebInspector.Section.prototype.set subtitle): (WebInspector.Section.prototype.get subtitleAsText):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
  • inspector/front-end/inspector.css: (.styles-section .subtitle::before, .styles-section .subtitle a::before):
09:35 Changeset [61493] by eric@webkit.org

2010-06-19 Alex Milowski <alex@milowski.com>

Reviewed by Darin Adler.

A fix for a change in https://bugs.webkit.org/show_bug.cgi?id=39941
that caused a compile error in MathML.
https://bugs.webkit.org/show_bug.cgi?id=40827

  • mathml/MathMLElement.cpp: (WebCore::MathMLElement::MathMLElement):
09:21 Changeset [61492] by eric@webkit.org

2010-06-19 Kartikaya Gupta <kagupta@rim.com>

Reviewed by Nikolas Zimmermann.

CPP bindings missing some APIs
https://bugs.webkit.org/show_bug.cgi?id=40570

Add missing C++ DOM API bindings. Specifically:

  • NodeFilter callback support
  • Missing custom method implementations in HTMLCollection and HTMLOptionsCollection
  • Missing EventTarget static type-determination methods
  • Fix CPP binding generator to not generate d-ptrs for classes that extend EventTarget and just use the parent's d-ptr instead
  • Switch binding generator to use DOMWindow instead of AbstractView so that necessary W3C-defined methods (e.g. getComputedStyle) are accessible.
  • bindings/cpp/WebDOMDOMWindowCustom.cpp: Added. (WebDOMDOMWindow::addEventListener): (WebDOMDOMWindow::removeEventListener):
  • bindings/cpp/WebDOMEventTarget.cpp: (toWebKit):
  • bindings/cpp/WebDOMEventTarget.h:
  • bindings/cpp/WebDOMHTMLCollectionCustom.cpp: Added. (WebDOMHTMLCollection::item): (WebDOMHTMLCollection::namedItem):
  • bindings/cpp/WebDOMHTMLOptionsCollectionCustom.cpp: Added. (WebDOMHTMLOptionsCollection::length): (WebDOMHTMLOptionsCollection::setLength):
  • bindings/cpp/WebDOMNodeFilterCustom.cpp: Added. (WebDOMNodeFilter::acceptNode): (toWebKit):
  • bindings/cpp/WebNativeNodeFilterCondition.cpp: Added. (WebNativeNodeFilterCondition::WebNativeNodeFilterCondition): (WebNativeNodeFilterCondition::~WebNativeNodeFilterCondition): (WebNativeNodeFilterCondition::acceptNode):
  • bindings/cpp/WebNativeNodeFilterCondition.h: Added. (WebNativeNodeFilterCondition::create):
  • bindings/scripts/CodeGeneratorCPP.pm:
  • dom/NodeFilter.idl:
  • page/DOMWindow.idl:
08:22 Changeset [61491] by dglazkov@chromium.org

2010-06-19 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update

  • platform/chromium/test_expectations.txt: Added a flaky crash.
08:13 Changeset [61490] by tkent@chromium.org

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed. Build fix for r61488.

  • features.gypi: Define use_accelerated_compositing.
08:05 Changeset [61489] by eric@webkit.org

2010-06-19 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Include <string.h> in StringExtras.h
https://bugs.webkit.org/show_bug.cgi?id=40808

Without string.h, RVCT 2.2 can't compile StringExtras.h.
It can't find strlen and strncmp.

  • wtf/StringExtras.h:
07:53 Changeset [61488] by eric@webkit.org

2010-06-19 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Adding a conditional gyp dependency for the WebCore target to
the gles2_c_lib which is required by the gpu compositor. The dependency will
only kick in if the accelerated_compositing path is enabled.
https://bugs.webkit.org/show_bug.cgi?id=40801

  • WebCore.gyp/WebCore.gyp:
07:19 Changeset [61487] by eric@webkit.org

2010-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin's multi-select does not take OptGroup into account
https://bugs.webkit.org/show_bug.cgi?id=40718

In multi-select elements, optgroup elements are counted in the index calculation,
but in single-select they are not. Keep the same logic even when NO_LISTBOX_RENDERING
is enabled.
Added tests to the existing manual test, as testing this requires a special build, in which
NO_LISTBOX_RENDERING is enabled.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxSelectItem):
  • manual-tests/no-listbox-rendering.html:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listBoxSelectItem):

2010-06-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Platform plugin's multi-select does not take OptGroup into account
https://bugs.webkit.org/show_bug.cgi?id=40718

Make sure that SelectData is valid throughout the lifetime of the dialog.
This is mostly important for the Orbt based plugin.
Added virtual desctructors where they were missing.

  • Api/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::SelectInputMethodWrapper::SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::~SelectInputMethodWrapper): (WebCore::SelectInputMethodWrapper::show):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp:
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebSelectData::~QWebSelectData): (QWebSelectMethod::~QWebSelectMethod): (QWebNotificationData::~QWebNotificationData):
07:07 Changeset [61486] by eric@webkit.org

2010-06-19 Thomas Van Lenten <thomasvl@chromium.org>

Reviewed by David Levin.

Warnings from -Wextra in a Chromium Mac build

  1. checks of unsigned >= 0
  2. enumeral and non-enumeral type in conditional expression
  3. copy ctors that don't call the super copy ctor or ctor No functionality change so no new tests.

https://bugs.webkit.org/show_bug.cgi?id=40791

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::ChromiumDataObject):
  • platform/chromium/ThemeChromiumMac.mm: (WebCore::updateStates):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::updateActiveState):

2010-06-19 Thomas Van Lenten <thomasvl@chromium.org>

Reviewed by David Levin.

Warnings from -Wextra in a Chromium Mac build

  1. checks of unsigned >= 0
  2. enumeral and non-enumeral type in conditional expression
  3. copy ctors that don't call the super copy ctor or ctor

https://bugs.webkit.org/show_bug.cgi?id=40791

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getSuggestion): (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionChanged):
  • src/AutocompletePopupMenuClient.cpp: (WebKit::AutocompletePopupMenuClient::getSuggestion): (WebKit::AutocompletePopupMenuClient::removeSuggestionAtIndex):
06:54 Changeset [61485] by eric@webkit.org

2010-06-19 Ben Murdoch <benm@google.com>

Reviewed by Pavel Feldman.

Fix build break with inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=40790

Replace a #include with a forward declaration.

Fixing a build break so no new tests required.

  • inspector/InspectorController.h: Forward declare InspectorValue

rather than #including its header which has its content guarded
out.

06:32 Changeset [61484] by eric@webkit.org

2010-06-19 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Fisher.

[chromium]Refactor input method related APIs.
https://bugs.webkit.org/show_bug.cgi?id=40608

No new tests are needed, because there is no new functionality.

  • page/FocusController.cpp: (WebCore::FocusController::setFocusedNode):

2010-06-19 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Fisher.

[chromium]Refactor input method related APIs.
https://bugs.webkit.org/show_bug.cgi?id=40608

  • WebKit.gyp:
  • public/WebCompositionCommand.h:
  • public/WebCompositionUnderline.h: Added. (WebKit::WebCompositionUnderline::WebCompositionUnderline):
  • public/WebTextInputType.h: Added. (WebKit::):
  • public/WebViewClient.h:
  • public/WebWidget.h:
  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::resetInputMethod):
  • src/CompositionUnderlineBuilder.h: Added. (WebKit::CompositionUnderlineBuilder::CompositionUnderlineBuilder):
  • src/CompositionUnderlineVectorBuilder.cpp: Added. (WebKit::CompositionUnderlineVectorBuilder::CompositionUnderlineVectorBuilder):
  • src/CompositionUnderlineVectorBuilder.h: Added.
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::setInputMethodState):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::setComposition): (WebKit::WebPopupMenuImpl::confirmComposition): (WebKit::WebPopupMenuImpl::textInputType): (WebKit::WebPopupMenuImpl::caretOrSelectionBounds):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleCompositionEvent): (WebKit::WebViewImpl::setComposition): (WebKit::WebViewImpl::confirmComposition): (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds):
  • src/WebViewImpl.h:
06:05 Changeset [61483] by eric@webkit.org

2010-06-19 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

Modifying the WebMediaPlayer interface to be compatible with
a change in chrome.
This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
has been updated, so this commit should NOT break chromium anymore,
nor should it cause any test failures.
https://bugs.webkit.org/show_bug.cgi?id=39445

  • public/WebMediaPlayer.h: Changed buffered() to be non-const.
05:32 Changeset [61482] by eric@webkit.org

2010-06-19 George Wright <gwright@rim.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=40720

Make setWapInputFormat() public again as CSSStyleSelector.cpp calls this when WCSS is enabled.

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::data):
05:31 Changeset [61481] by tkent@chromium.org

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt:
    • progress-element.html is essentially flaky on Mac.
    • use-clipped-hit.svg passes recently.
04:58 Changeset [61480] by eric@webkit.org

2010-06-19 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

Bridge documentation: some snippets have the wrong indentation
https://bugs.webkit.org/show_bug.cgi?id=40717

Fixed code snippets

  • docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction):
04:43 Changeset [61479] by tkent@chromium.org

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add expectations for <meter> and <progress>.

  • platform/chromium-linux/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/test_expectations.txt:
04:02 Changeset [61478] by robert@webkit.org

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

This initial implementation passes 25 of the 27 tests in
http/tests/isolatedworld as well as four others that use the
call in LayoutTests.

Further work/investigation is required to support the two
remaining tests.

  • platform/qt/Skipped:

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

getOwnPropertyNames() crashes if PropertyNameArray is size 0. This change allows
http/tests/world-reuse.html and didClearWindowObject.html to fail instead of crash.

  • WebCore.pro: Add qwebscriptworld.*
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

  • Api/headers.pri:
  • Api/qwebframe.cpp: (QWebFrame::evaluateScriptInIsolatedWorld):
  • Api/qwebframe.h:
  • Api/qwebscriptworld.cpp: Added. (QWebScriptWorld::QWebScriptWorld): (QWebScriptWorld::world): (QWebScriptWorld::~QWebScriptWorld):
  • Api/qwebscriptworld.h: Added.
  • Api/qwebscriptworld_p.h: Added. (QWebScriptWorldPrivate::QWebScriptWorldPrivate): (QWebScriptWorldPrivate::~QWebScriptWorldPrivate):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-02 Robert Hogan <robert@webkit.org>

Reviewed by Adam Barth.

[Qt] Support evaluateScriptInIsolatedWorld()

https://bugs.webkit.org/show_bug.cgi?id=40079

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::evaluateScriptInIsolatedWorld):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
03:18 Changeset [61477] by tkent@chromium.org

2010-06-19 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Rebaseline for tetDecoration.svg.

  • platform/chromium-linux/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png: Added.
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
03:04 Changeset [61476] by eric@webkit.org

2010-06-19 Olivier Goffart <olivier.goffart@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compilation in QWebPagePrivate::timerEvent with clang
https://bugs.webkit.org/show_bug.cgi?id=40714

QObject::timerEvent is protected and cannot be accessed by QWebPagePrivate
with clang

QWebPagePrivate is a friend of QWebPage and then should have access to
all protected members of parents of QWebPage, including QObject.
But the clang team do not want to conform to this aspect of the specification
because "It is either a drafting error or a horrible mistake."
See http://llvm.org/bugs/show_bug.cgi?id=6840

This change is better because QWebPage does not reimplement the timerEvent
(QWebPagePrivate::timerEvent is called from QWebPage::event)
So customers that would reimplement their own timerEvent
for their own timer now get a chance to catch them.

  • Api/qwebpage.cpp: (QWebPagePrivate::timerEvent):
02:45 Changeset [61475] by eric@webkit.org

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Don't use attribute((may_alias)) with the Intel compiler,
as it doesn't understand it.

  • wtf/Vector.h:
02:23 Changeset [61474] by eric@webkit.org

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix compilation with the Intel C++ compiler (11.1.072).

Like RVCT, label pointers must be void*, not const void*.

  • bytecode/Opcode.h:
02:09 Changeset [61473] by eric@webkit.org

2010-06-19 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Add the WTF_COMPILER_INTEL for when the Intel compiler is used
for building. Usually, the Intel compiler masquerades as
another compiler in the system and gets away with it, but some
times specific fixes are required (such as when using language
extensions).

  • wtf/Platform.h:
01:45 Changeset [61472] by eric@webkit.org

2010-06-19 Mirko Damiani <mirko@develer.com>

Reviewed by Simon Hausmann.

[Qt] Avoid truncation of zoom factor in QWebFrame's print function.
https://bugs.webkit.org/show_bug.cgi?id=40662

The zoom factor is a qreal number but its value is truncated to an
integer. So a cast to qreal is needed to avoid this issue.

  • Api/qwebframe.cpp: (QWebFrame::print):
01:31 Changeset [61471] by eric@webkit.org

2010-06-19 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/get-active-test.html failed in Chrome Mac
https://bugs.webkit.org/show_bug.cgi?id=40496

  • fast/canvas/webgl/get-active-test-expected.txt: Test of two contexts and two programs, also test the uniform array name ends with "[0]".
  • fast/canvas/webgl/script-tests/get-active-test.js: Ditto.

2010-06-19 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/get-active-test.html failed in Chrome Mac
https://bugs.webkit.org/show_bug.cgi?id=40496

  • src/WebGraphicsContext3DDefaultImpl.cpp: Call makeContextCurrent(). (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels):
00:26 Changeset [61470] by eric@webkit.org

2010-06-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Some very minor cleanups for HTML5 Parser
https://bugs.webkit.org/show_bug.cgi?id=40638

No new tests because no new functionality.

  • html/HTML5DocumentParser.cpp: (WebCore::): Make ctor explicit.
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::InsertionPointRecord::InsertionPointRecord): Make ctor explicit.
  • html/HTML5Lexer.cpp: (WebCore::HTMLNames::isEndTagBufferingState): Use switch to generate an efficient table with single branch.
  • html/HTML5Token.h: (WebCore::HTML5Token::forceQuirks): Add const.
  • html/HTML5TreeBuilder.h: (WebCore::HTML5TreeBuilder::isPaused): Add const.
00:12 Changeset [61469] by eric@webkit.org

2010-06-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add three more non-core Chromium builders to start testing DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=40335

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
00:08 Changeset [61468] by aa@chromium.org

2010-06-18 Aaron Boodman <aa@chromium.org>

Remove WebKit::WebDocument::isXHTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=40815

  • dom/Document.h: remove isXHTML() getter.

2010-06-18 Aaron Boodman <aa@chromium.org>

Remove WebKit::WebDocument::isXHTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=40815

  • public/WebDocument.h: Remove isXHTMLDocument().
  • src/WebDocument.cpp: Ditto.
00:05 Changeset [61467] by aa@chromium.org

2010-06-19 Aaron Boodman <aa@chromium.org>

Unreviewed, rolling out r61466.
http://trac.webkit.org/changeset/61466
https://bugs.webkit.org/show_bug.cgi?id=40816

Landed wrong change

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8DOMWindowShell.h:

2010-06-19 Aaron Boodman <aa@chromium.org>

Unreviewed, rolling out r61466.
http://trac.webkit.org/changeset/61466
https://bugs.webkit.org/show_bug.cgi?id=40816

Landed wrong change

  • src/WebKit.cpp: (WebKit::shutdown):
Note: See TracTimeline for information about the timeline view.