Timeline


and

07/01/10:

23:47 Changeset [62368] by oliver@apple.com
  • 2 edits in trunk/WebCore

Chromium build fix.

23:31 Changeset [62367] by oliver@apple.com
  • 18 edits
    3 adds in trunk

2010-07-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
https://bugs.webkit.org/show_bug.cgi?id=41506

This new type is used in place of fixed length C arrays so
that debug builds can guard against attempts to go beyond
the end of the array.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Opcode.cpp: (JSC::OpcodeStats::~OpcodeStats):
  • pcre/pcre_compile.cpp: (calculateCompiledPatternLength):
  • runtime/Collector.cpp: (JSC::Heap::allocateBlock): (JSC::Heap::allocate):
  • runtime/Collector.h: (JSC::CollectorBitmap::clearAll):
  • runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::operator*):
  • runtime/DateInstanceCache.h:
  • runtime/JSString.cpp: (JSC::JSString::replaceCharacter):
  • runtime/JSString.h: (JSC::RopeBuilder::JSStringFinalizerStruct::):
  • runtime/NumericStrings.h:
  • runtime/RegExpCache.h:
  • runtime/SmallStrings.h: (JSC::SmallStrings::singleCharacterStrings):
  • wtf/AVLTree.h:
  • wtf/FixedArray.h: Added. (WTF::FixedArray::operator[]): (WTF::FixedArray::data):

2010-07-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
https://bugs.webkit.org/show_bug.cgi?id=41506

Add forwarding header.

  • ForwardingHeaders/wtf/FixedArray.h: Added.

2010-07-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
https://bugs.webkit.org/show_bug.cgi?id=41506

Add forwarding header, and replace a few fixed length arrays
with the new FixedArray type.

  • ForwardingHeaders/wtf/FixedArray.h: Added.
  • dom/Document.h:
  • platform/graphics/GlyphMetricsMap.h:
23:17 Changeset [62366] by zherczeg@webkit.org
  • 2 edits in trunk/JavaScriptCore

Improve the main lexer switch by mapping input characters to their type
https://bugs.webkit.org/show_bug.cgi?id=41459

Reviewed by Oliver Hunt.

Sunsipder: no change (from 532.9ms to 531.5ms)
SunSpider --parse-only: 1.025x as fast (from 33.1ms to 32.3ms)

  • parser/Lexer.cpp:

(JSC::):
(JSC::Lexer::lex):

23:04 Changeset [62365] by sfalken@apple.com
  • 7 edits in trunk/WebKit/win

Provide a WebView preference to disable DNS prefetching on Windows
https://bugs.webkit.org/show_bug.cgi?id=41504
<rdar://problem/8151939>

Reviewed by Adele Peterson.

  • Interfaces/IWebPreferencesPrivate.idl: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
  • Interfaces/WebKit.idl: Touched to force IDL build.
  • WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Default prefetch to true.
(WebPreferences::setDNSPrefetchingEnabled): Added.
(WebPreferences::isDNSPrefetchingEnabled): Added.

  • WebPreferences.h: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Propagate prefetch pref into settings.

22:16 Changeset [62364] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-07-01 Simon Fraser <simon.fraser@apple.com>

No review.

Fix a link warning in 32-bit by not explicitly exporting WebCore::GraphicsLayer::syncCompositingStateForThisLayerOnly().

  • WebCore.AcceleratedCompositing.exp:
22:06 Changeset [62363] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Even more Windows build fixing.
Removed bogus post-build event commands.
Removed unnecessary link libraries.

  • win/WebKit2.vcproj:
21:58 Changeset [62362] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Fix Windows while not breaking Qt (didn't realize this was building for Qt).

  • WebProcess/WebProcess.cpp:
21:54 Changeset [62361] by simon.fraser@apple.com
  • 4 edits in trunk/WebKitLibraries

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/8154047>

Update WebKitSystemInterface, making some functions used by
WebKit2 available in 32-bit (for reals this time).

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
21:52 Changeset [62360] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.

  • win/WebKit2Generated.make:
21:31 Changeset [62359] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.

  • WebProcess/WebProcess.cpp:
21:21 Changeset [62358] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Make WebKit2 compile (though not work) on Leopard.

Reviewed by Jon Honeycutt.

  • Platform/WorkQueue.h:
  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::EventSource::EventSource):
(WorkQueue::scheduleWork):
(WorkQueue::registerMachPortEventHandler):
(WorkQueue::unregisterMachPortEventHandler):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):

  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:

(WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::setUpAcceleratedCompositing):

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
(WebKit::LayerBackedDrawingArea::setNeedsDisplay):

  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:

(WebKit::LayerBackedDrawingArea::platformClear):
(WebKit::LayerBackedDrawingArea::attachCompositingContext):

21:18 Changeset [62357] by tonyg@chromium.org
  • 14 edits
    3 copies
    3 moves in trunk/WebCore

2010-07-01 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add window.performance.navigation namespace
https://bugs.webkit.org/show_bug.cgi?id=41442

Adds window.performance.navigation namespace consisting of ".type"
and ".redirectCount". As part of this change, I renmaed "NavigationTiming"
to just "Timing" to avoid confusion.

No new tests because tests will be added in a subsequent patch when
functionality is added.

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Navigation.cpp: Added. (WebCore::Navigation::Navigation): (WebCore::Navigation::frame): (WebCore::Navigation::disconnectFrame): (WebCore::Navigation::type): (WebCore::Navigation::redirectCount):
  • page/Navigation.h: Added. (WebCore::Navigation::create):
  • page/Navigation.idl: Added.
  • page/NavigationTiming.cpp: Removed.
  • page/NavigationTiming.h: Removed.
  • page/NavigationTiming.idl: Removed.
  • page/Performance.cpp: (WebCore::Performance::navigation): (WebCore::Performance::timing):
  • page/Performance.h:
  • page/Performance.idl:
  • page/Timing.cpp: Added. (WebCore::Timing::Timing): (WebCore::Timing::frame): (WebCore::Timing::disconnectFrame): (WebCore::Timing::navigationStart):
  • page/Timing.h: Added. (WebCore::Timing::create):
  • page/Timing.idl: Added.
21:16 Changeset [62356] by simon.fraser@apple.com
  • 5 edits in trunk/WebKitLibraries

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/8154047>

Update WebKitSystemInterface, making some functions used by
WebKit2 available in 32-bit.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
21:15 Changeset [62355] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Define HAVE_HOSTED_CORE_ANIMATION on Snow Leopard.

Rubber-stamped by Ander Carlsson.

  • wtf/Platform.h:
21:02 Changeset [62354] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Jian Li.

[chromium] Dragging a link triggers an assert when accessing event.dataTransfer.types
https://bugs.webkit.org/show_bug.cgi?id=41493

ClipboardChromium::writeURL violates ClipboardChromium's assumption that uriList will always
be non-empty if url is valid.

No new tests.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeURL):
20:51 Changeset [62353] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Clamp color stops passed to QGradient to 1.0
[https://bugs.webkit.org/show_bug.cgi?id=41484

Fixes an issue where color stops would be silently dropped from radial gradients.

  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
20:15 Changeset [62352] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTokenizer should ASSERT that it never emits a null character
https://bugs.webkit.org/show_bug.cgi?id=41448

No functional change, thus no tests. These ASSERTs would have
caught the coding error which caused the trouble in bug 41436
(which was fixed by bug 41439).

  • html/HTMLToken.h: (WebCore::HTMLToken::beginStartTag): (WebCore::HTMLToken::beginCharacter): (WebCore::HTMLToken::beginDOCTYPE): (WebCore::HTMLToken::appendToName): (WebCore::HTMLToken::appendToComment): (WebCore::HTMLToken::appendToAttributeName): (WebCore::HTMLToken::appendToAttributeValue): (WebCore::HTMLToken::appendToPublicIdentifier): (WebCore::HTMLToken::appendToSystemIdentifier):
20:12 Changeset [62351] by levin@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62349.
http://trac.webkit.org/changeset/62349
https://bugs.webkit.org/show_bug.cgi?id=41499

It broke the chromium Linux build. (Requested by dave_levin on
#webkit).

  • public/WebNode.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::registerPasswordListener): (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
20:03 Changeset [62350] by commit-queue@webkit.org
  • 5 edits in trunk

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Don't paint with empty radial gradients
https://bugs.webkit.org/show_bug.cgi?id=41190

Unskip canvas/philip/tests/2d.gradient.radial.equal.html for Qt.

  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Don't paint with empty radial gradients
https://bugs.webkit.org/show_bug.cgi?id=41190

If a radial gradient has x0==x1 && y0==y1 && r0==r1, don't paint with it.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fillRect):
  • platform/graphics/Gradient.h: (WebCore::Gradient::isZeroSize):
19:50 Changeset [62349] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-07-01 David Holloway <dhollowa@chromium.org>

Reviewed by Darin Fisher.

[chromium] Exposes WebNode::unwrap() and WebNode::constUnwrap() for
use by other code in WebKit/chromium/src.

Specific use of these methods is made in WebFrameImpl.cpp. This is
preferred to the cast operator call that was happening prior to this
change.

https://bugs.webkit.org/show_bug.cgi?id=41477

  • public/WebNode.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::registerPasswordListener): (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
19:22 Changeset [62348] by tonyg@chromium.org
  • 8 edits
    1 add in trunk/WebCore

2010-07-01 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Add interface for network platform to pass up timing information
https://bugs.webkit.org/show_bug.cgi?id=41437

The Web Timing feature requires the network platform to expose detailed
timing information for the main resource. This patch adds that data to
the ResourceResponseBase. Since the 82 bytes of information is only
needed for the main resource, it is a RefPtr to avoid using the memory
for other resource types.

No new tests because no new functionality.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/ResourceLoadTiming.h: Added. (WebCore::ResourceLoadTiming::create): (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::operator!=): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData): (WebCore::ResourceResponseBase::resourceLoadTiming): (WebCore::ResourceResponseBase::setResourceLoadTiming): (WebCore::ResourceResponseBase::compare):
  • platform/network/ResourceResponseBase.h:
19:17 Changeset [62347] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Versioning.

19:16 Changeset [62346] by mrowe@apple.com
  • 1 copy in tags/Safari-533.17.1

New tag.

18:59 Changeset [62345] by mrowe@apple.com
  • 1 edit in branches/safari-533.17-branch/WebCore/html/HTMLInputElement.cpp

Build fix.

18:14 Changeset [62344] by levin@chromium.org
  • 2 edits in trunk/LayoutTests
  • platform/chromium/test_expectations.txt: Removed a test that is passing and added a test that is now failing.

Reviewed by NOBODY (trivial test_expectations change).

17:58 Changeset [62343] by levin@chromium.org
  • 2 edits in trunk/LayoutTests
  • platform/chromium/test_expectations.txt: Upstreamed two test expectation issues for flaky tests.

Reviewed by NOBODY (trivial test expectation changes).

17:41 Changeset [62342] by mrowe@apple.com
  • 6 edits
    22 adds in branches/safari-533.17-branch

Merge r61667.

17:38 Changeset [62341] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61044.

17:36 Changeset [62340] by mrowe@apple.com
  • 4 edits
    1 add in branches/safari-533.17-branch

Merge r61050.

17:34 Changeset [62339] by mrowe@apple.com
  • 7 edits
    3 adds in branches/safari-533.17-branch

Merge r62279.

17:29 Changeset [62338] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Merge r61654.

17:21 Changeset [62337] by mrowe@apple.com
  • 4 edits in branches/safari-533.17-branch/JavaScriptCore

Merge r62148.

17:21 Changeset [62336] by mrowe@apple.com
  • 12 edits
    3 adds in branches/safari-533.17-branch/JavaScriptCore

Merge r61623.

17:19 Changeset [62335] by dumi@chromium.org
  • 12 edits in trunk

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62321.
http://trac.webkit.org/changeset/62321
https://bugs.webkit.org/show_bug.cgi?id=41494

Broke the non-win builds. (Requested by dumi on #webkit).

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::addOpenDatabase): (WebCore::ScriptExecutionContext::removeOpenDatabase): (WebCore::ScriptExecutionContext::stopDatabases):
  • dom/ScriptExecutionContext.h:
  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::markAsDeletedAndClose): (WebCore::ContextRemoveOpenDatabaseTask::create): (WebCore::ContextRemoveOpenDatabaseTask::performTask): (WebCore::ContextRemoveOpenDatabaseTask::isCleanupTask): (WebCore::ContextRemoveOpenDatabaseTask::ContextRemoveOpenDatabaseTask): (WebCore::Database::close): (WebCore::Database::closeImmediately): (WebCore::Database::stop): (WebCore::Database::performPolicyChecks):
  • storage/Database.h: (WebCore::Database::): (WebCore::Database::stopped):
  • storage/DatabaseTask.cpp: (WebCore::DatabaseTask::performTask): (WebCore::DatabaseOpenTask::DatabaseOpenTask): (WebCore::DatabaseOpenTask::doPerformTask): (WebCore::DatabaseOpenTask::debugTaskName): (WebCore::DatabaseCloseTask::DatabaseCloseTask): (WebCore::DatabaseCloseTask::doPerformTask): (WebCore::DatabaseCloseTask::debugTaskName): (WebCore::DatabaseTransactionTask::DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::~DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::doPerformTask): (WebCore::DatabaseTransactionTask::debugTaskName): (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): (WebCore::DatabaseTableNamesTask::doPerformTask): (WebCore::DatabaseTableNamesTask::debugTaskName):
  • storage/DatabaseTask.h: (WebCore::DatabaseOpenTask::create): (WebCore::DatabaseCloseTask::create): (WebCore::DatabaseTransactionTask::create): (WebCore::DatabaseTableNamesTask::create):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread):
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::addOpenDatabase):
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL): (WebCore::SQLTransaction::checkAndHandleClosedDatabase):

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62321.
http://trac.webkit.org/changeset/62321
https://bugs.webkit.org/show_bug.cgi?id=41494

Broke the non-win builds. (Requested by dumi on #webkit).

  • storage/open-database-creation-callback.html:
16:58 Changeset [62334] by mrowe@apple.com
  • 4 edits in branches/safari-533.17-branch

Merge r60882.

16:57 Changeset [62333] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r62135.

16:55 Changeset [62332] by mrowe@apple.com
  • 4 edits
    8 adds in branches/safari-533.17-branch

Merge r62134.

16:53 Changeset [62331] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533.17-branch

Merge r61921.

16:52 Changeset [62330] by mrowe@apple.com
  • 14 edits
    1 copy
    2 adds in branches/safari-533.17-branch

Merge r59396.

16:52 Changeset [62329] by xan@webkit.org
  • 10 edits in trunk

WebCore:

2010-07-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Stop using GdkRegion in 3.x mode
https://bugs.webkit.org/show_bug.cgi?id=41463

Make us compile without using GdkRegion, since it's gone from GTK+
3.x.

  • platform/graphics/IntRect.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::cairo_region_shrink): (WebCore::Font::drawComplexText):
  • platform/gtk/GtkPluginWidget.cpp: (WebCore::GtkPluginWidget::paint):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::paint):

WebKit/gtk:

2010-07-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Stop using GdkRegion in 3.x mode
https://bugs.webkit.org/show_bug.cgi?id=41463

Make us compile without using GdkRegion, since it's gone from GTK+
3.x.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scroll):
  • webkit/webkitwebview.cpp: (webkit_web_view_expose_event):
16:50 Changeset [62328] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61435.

16:49 Changeset [62327] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61296.

16:48 Changeset [62326] by mrowe@apple.com
  • 3 edits
    19 adds in branches/safari-533.17-branch

Merge r60640.

16:45 Changeset [62325] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61070.

16:43 Changeset [62324] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61200.

16:42 Changeset [62323] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61189.

16:37 Changeset [62322] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r60908.

16:33 Changeset [62321] by dumi@chromium.org
  • 12 edits in trunk

WebCore: DB clean up.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

  1. Made all DatabaseTasks internal classes of Database and made the Database methods called by those tasks private.
  2. Removed the Database::stop{ed}() methods.
  3. Removed the code that kept track of open databases from ScriptExecutionContext (no longer needed).
  4. Made minor changes to Database::closeImmediately() to make it possible for DatabaseThread to call that method instead of close().
  5. Minor fix to DatabaseTracker: addOpenDatabase() should call OriginQuotaManager::addDatabase() if the origin quota manager is not tracking this origin.
  6. Removed Database::performPolicyChecks(). We already update the DB size after each transaction, and we enforce a max size for the DB at the beginning of each transaction.
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::stopDatabases):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::hasOpenDatabases):

  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::close):
(WebCore::Database::closeImmediately):

  • storage/Database.h:
  • storage/DatabaseTask.cpp:

(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):
(WebCore::Database::DatabaseOpenTask::debugTaskName):
(WebCore::Database::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::Database::DatabaseCloseTask::doPerformTask):
(WebCore::Database::DatabaseCloseTask::debugTaskName):
(WebCore::Database::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::Database::DatabaseTransactionTask::doPerformTask):
(WebCore::Database::DatabaseTransactionTask::debugTaskName):
(WebCore::Database::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::Database::DatabaseTableNamesTask::doPerformTask):
(WebCore::Database::DatabaseTableNamesTask::debugTaskName):

  • storage/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
(WebCore::Database::DatabaseCloseTask::create):
(WebCore::Database::DatabaseTransactionTask::create):
(WebCore::Database::DatabaseTableNamesTask::create):

  • storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):

LayoutTests: Minor change to a DB test to make it run correctly with run-webkit-tests --iterations N.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

  • storage/open-database-creation-callback.html:
16:26 Changeset [62320] by simon.fraser@apple.com
  • 13 edits
    1 copy in trunk/WebKit2

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Start up the CA render server in the UI process (currently, at launch time), and
pass the server port over to the web process for use by the layer-backed drawing area.

Fix some style issues pointed out by Dan Bernstein.

Implement the WebChromeClient methods that pass the attach/detach calls through
to the drawing area.

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView _startAcceleratedCompositing:]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::WebProcessProxy): (WebKit::WebProcessProxy::setUpAcceleratedCompositing):
  • UIProcess/WebProcessProxy.h:
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
  • UIProcess/mac/WebProcessProxyMac.mm: Added. (WebKit::WebProcessProxy::setUpAcceleratedCompositing):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::attachRootGraphicsLayer): (WebKit::WebChromeClient::scheduleCompositingLayerSync):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::attachCompositingContext):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::didReceiveMessage):
  • WebProcess/WebProcess.h: (WebKit::WebProcess::compositingRenderServerPort):
16:25 Changeset [62319] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.17-branch

Merge r61060.

16:23 Changeset [62318] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r60984.

16:21 Changeset [62317] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r60459.

16:19 Changeset [62316] by mrowe@apple.com
  • 5 edits
    4 adds in branches/safari-533.17-branch

Merge r61068.

16:18 Changeset [62315] by levin@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests
  • platform/chromium/fast/dom/domListEnumeration-expected.txt: Added. Results differ due to a lack of a v8 binding implementation of dataset.
  • platform/chromium/test_expectations.txt: Marked the dataset tests as failing and referred the corresponding bug for them.

Reviewed by NOBODY (test fix).

16:16 Changeset [62314] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.17-branch

Merge r60727.

16:13 Changeset [62313] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-07-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support indeterminate checkbox for Windows
https://bugs.webkit.org/show_bug.cgi?id=41444

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineState): Check isIndeterminate() and set an appropriate flag value.
16:12 Changeset [62312] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61132.

16:11 Changeset [62311] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebKit/mac

Merge r61204.

16:09 Changeset [62310] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61231.

16:09 Changeset [62309] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61171.

16:09 Changeset [62308] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r61365.

15:57 Changeset [62307] by weinig@apple.com
  • 10 edits
    8 adds in trunk/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=41491
Add first stab at back/forward list API.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBackForwardList.cpp: Added.
  • UIProcess/API/C/WKBackForwardList.h: Added.
  • UIProcess/API/C/WKBackForwardListItem.cpp: Added.
  • UIProcess/API/C/WKBackForwardListItem.h: Added.
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/WebBackForwardListItem.cpp: Added.
  • UIProcess/WebBackForwardListItem.h: Added.
  • UIProcess/WebBackForwardListProxy.cpp: Added.
  • UIProcess/WebBackForwardListProxy.h: Added.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
15:56 Changeset [62306] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

Bug 41490 - Add missing operations to MacroAssemblerARMv7
Also, make single, double, quad register numbers in ARMv7Assembler distinct & strongly typed.

Reviewed by Oliver Hunt.

  • assembler/ARMv7Assembler.h:

(JSC::ARMRegisters::):
(JSC::ARMRegisters::asSingle):
(JSC::ARMRegisters::asDouble):
(JSC::VFPImmediate::VFPImmediate):
(JSC::VFPImmediate::isValid):
(JSC::VFPImmediate::value):
(JSC::ARMv7Assembler::singleRegisterMask):
(JSC::ARMv7Assembler::doubleRegisterMask):
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::add_S):
(JSC::ARMv7Assembler::neg):
(JSC::ARMv7Assembler::orr_S):
(JSC::ARMv7Assembler::sub):
(JSC::ARMv7Assembler::sub_S):
(JSC::ARMv7Assembler::vadd_F64):
(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcvt_F64_S32):
(JSC::ARMv7Assembler::vcvtr_S32_F64):
(JSC::ARMv7Assembler::vdiv_F64):
(JSC::ARMv7Assembler::vldr):
(JSC::ARMv7Assembler::vmov_F64_0):
(JSC::ARMv7Assembler::vmov):
(JSC::ARMv7Assembler::vmul_F64):
(JSC::ARMv7Assembler::vstr):
(JSC::ARMv7Assembler::vsub_F64):
(JSC::ARMv7Assembler::vcvt):
(JSC::ARMv7Assembler::vmem):

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::fpTempRegisterAsSingle):
(JSC::MacroAssemblerARMv7::neg32):
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::divDouble):
(JSC::MacroAssemblerARMv7::convertInt32ToDouble):
(JSC::MacroAssemblerARMv7::branchConvertDoubleToInt32):
(JSC::MacroAssemblerARMv7::zeroDouble):
(JSC::MacroAssemblerARMv7::branchOr32):
(JSC::MacroAssemblerARMv7::set32):
(JSC::MacroAssemblerARMv7::set8):

  • assembler/MacroAssemblerMIPS.h:
  • assembler/MacroAssemblerX86Common.h:
15:36 Changeset [62305] by andersca@apple.com
  • 7 edits
    1 copy
    3 moves in trunk/WebKit2

Make process launching asynchronous
https://bugs.webkit.org/show_bug.cgi?id=41489

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.h:

Make OutgoingMessage public.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::paint):
Don't wait for a paint reply when the process is starting up.

  • UIProcess/Launcher/ProcessLauncher.cpp: Added.

Add new ProcessLauncher class.

(WebKit::processLauncherWorkQueue):
Returns the work queue where process launching will happen.

(WebKit::ProcessLauncher::ProcessLauncher):
Schedule launching the process.

(WebKit::ProcessLauncher::didFinishLaunchingProcess):
Call the client method.

(WebKit::ProcessLauncher::invalidate):
Set the client to 0.

  • UIProcess/Launcher/ProcessLauncher.h: Added.
  • UIProcess/Launcher/WebProcessLauncher.h: Removed.

Rename WebProcessLauncher.h -> ProcessLauncher.h

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: Added.
  • UIProcess/Launcher/mac/WebProcessLauncher.mm: Removed.

Rename WebProcessLauncher.mm -> ProcessLauncherMac.mm, update for ProcessLauncher changes.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp: Added.
  • UIProcess/Launcher/win/WebProcessLauncher.cpp: Removed.

Rename WebProcessLauncher.cpp -> ProcessLauncherWin.cpp, update for ProcessLauncher changes.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
Delete any unsent messages.

(WebKit::WebProcessProxy::connect):
Use the new ProcessLauncher.

(WebKit::WebProcessProxy::sendMessage):
If we're waiting for the process to launch, the messages need to be enqueued.

(WebKit::WebProcessProxy::didFinishLaunching):
Send the outgoing messages.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Update for renames.

15:25 Changeset [62304] by ap@apple.com
  • 3 edits
    3 moves in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=41488
<rdar://problem/7487420> Crash in SubresourceLoader::create when load is initiated from plug-in destructor

Test: plugins/js-from-destroy.html

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Null check active document loader.
15:23 Changeset [62303] by simon.fraser@apple.com
  • 10 edits
    1 copy
    5 adds in trunk/WebKit2

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Add a new kind of DrawingArea, which is a LayerBackedDrawingArea, which will be used
when the page goes into accelerated compositing mode. It is not wired up yet.

  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: New 'attach' and 'detach' messages related to accelerated compositing.
  • UIProcess/API/mac/WKView.mm: (-[WKView _startAcceleratedCompositing:]): (-[WKView _stopAcceleratedCompositing]):
  • UIProcess/API/mac/WKViewInternal.h: Add a subview of the WKView which has layer-backing enabled, and put the drawing area's layer inside of that.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h: (WebKit::ChunkedUpdateDrawingAreaProxy::attachCompositingContext): (WebKit::ChunkedUpdateDrawingAreaProxy::detachCompositingContext): These methods will never be called on the ChunkedUpdateDrawingArea. Stub them out.
  • UIProcess/DrawingAreaProxy.h: Add attachCompositingContext() and detachCompositingContext() methods, and a new drawing area type to the enum.
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: Added.
  • UIProcess/LayerBackedDrawingAreaProxy.h: Added.
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: Added.
  • WebKit2.xcodeproj/project.pbxproj: Add LayerBackedDrawingArea files.
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h: Add virtual methods stubs.
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): Create a LayerBackedDrawingArea if asked.
  • WebProcess/WebPage/DrawingArea.h: New LayerBackedDrawingAreaType type, and new virtual methods related to accelerated compositing.
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: Added.
  • WebProcess/WebPage/LayerBackedDrawingArea.h: Added.
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: Added.
15:17 Changeset [62302] by aestes@apple.com
  • 3 edits
    2 adds in trunk

2010-07-01 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8113003> Correctly fire beforeload events for images
added to the DOM using .innerHTML.
https://bugs.webkit.org/show_bug.cgi?id=40919

Test: fast/dom/beforeload/image-before-load-innerHTML.html

  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::write): Do not fire synchronous image beforeload events immediately after parsing a document fragment. Let the events fire later, giving the fragment time to potentially be inserted into the document.

2010-07-01 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.


<rdar://problem/8113003> Test that beforeload fires correctly on images
inserted into the DOM using .innerHTML.
https://bugs.webkit.org/show_bug.cgi?id=40919

  • fast/dom/beforeload/image-before-load-innerHTML-expected.txt: Added.
  • fast/dom/beforeload/image-before-load-innerHTML.html: Added.
15:02 Changeset [62301] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Improve reentrancy logic in polymorphic cache stubs
<https://bugs.webkit.org/show_bug.cgi?id=41482>
<rdar://problem/8094380>

Reviewed by Geoff Garen.

JavaScriptCore:

Make the polymorphic cache stubs handle reentrancy
better.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):

LayoutTests:

Test cases for cache reentry in the cache code.

  • fast/js/reentrant-caching-expected.txt: Added.
  • fast/js/reentrant-caching.html: Added.
  • fast/js/script-tests/reentrant-caching.js: Added.
14:56 Changeset [62300] by commit-queue@webkit.org
  • 9 edits in trunk

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: bezierCurveTo() and quadraticCurveTo() must ensure subpaths
https://bugs.webkit.org/show_bug.cgi?id=41192

Unskipped two tests:

  • canvas/philip/tests/2d.path.bezierCurveTo.ensuresubpath.2.html
  • canvas/philip/tests/2d.path.quadraticCurveTo.ensuresubpath.2.html

fast/canvas/canvas-modify-emptyPath.html was updated to expect the new behavior.

Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-beziercurveto
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-quadraticcurveto

  • canvas/philip/tests/2d.path.bezierCurveTo.ensuresubpath.2-expected.txt:
  • canvas/philip/tests/2d.path.quadraticCurveTo.ensuresubpath.2-expected.txt:
  • fast/canvas/canvas-modify-emptyPath-expected.txt:
  • fast/canvas/script-tests/canvas-modify-emptyPath.js:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: bezierCurveTo() and quadraticCurveTo() must ensure subpaths
https://bugs.webkit.org/show_bug.cgi?id=41192

If the current path is empty, bezierCurveTo() and quadraticCurveTo() will now
move to the (first) control point before adding the curve.

Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-beziercurveto
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-quadraticcurveto

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::quadraticCurveTo): (WebCore::CanvasRenderingContext2D::bezierCurveTo):
14:44 Changeset [62299] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Add test for checking that canvas elements can't have a negative width or height.
https://bugs.webkit.org/show_bug.cgi?id=39149

Unskipped 2 canvas/philip/ tests that now pass.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#attr-canvas-width

  • canvas/philip/tests/size.attributes.parse.minus-expected.txt:
  • canvas/philip/tests/size.attributes.setAttribute.minus-expected.txt:
  • fast/canvas/canvas-negative-size-expected.txt: Added.
  • fast/canvas/canvas-negative-size.html: Added.
  • fast/canvas/script-tests/canvas-negative-size.js: Added. (createFromMarkup): (trySettingWidth): (trySettingHeight): (trySettingWidthAttribute): (trySettingHeightAttribute): (tryCreatingCanvasWithWidth): (tryCreatingCanvasWithHeight): (tryWidth): (tryHeight): (checkDefaultWidth): (checkDefaultHeight):
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Canvas element cannot have negative width or height (HTML5 spec 4.8.11)
https://bugs.webkit.org/show_bug.cgi?id=39149

If assigned a negative value, it should default to 300 for width and 150 for height.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#attr-canvas-width

Test: fast/canvas/canvas-negative-size.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset):
14:02 Changeset [62298] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] Make context menus show up in the right place in QTestBrowser

Reviewed by Kenneth Rohde Christiansen.

Context menus were shown at scene-relative coordinates for
QGraphicsWebView while QMenu expects them to be global. The
change to the QWidget case was to get rid of the mapToGlobal.

  • QtTestBrowser/webview.cpp:
13:53 Changeset [62297] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit2

Export symbols on Linux with GCC, like JSC does.

Rubberstamped by Sam Weinig.
Patch by Kenneth Christiansen <kenneth@webkit.org>

  • UIProcess/API/C/WKBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
13:53 Changeset [62296] by robert@webkit.org
  • 7 edits in trunk

2010-07-01 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] dump frames in ascending alphabetical order of title

https://bugs.webkit.org/show_bug.cgi?id=41261

Unskip:
http/tests/navigation/metaredirect-frames.html
http/tests/navigation/redirect302-frames.html
http/tests/navigation/redirect302-subframeload.html
http/tests/navigation/timerredirect-frames.html

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::getChildHistoryItems):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem):
  • platform/qt/Skipped:
13:44 Changeset [62295] by tonikitoo@webkit.org
  • 2 edits
    2 adds in trunk/WebKit2

Initial WebKit2 implementation https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Antti Koivisto.
Patch by Kenneth Christiansen <kenneth@webkit.org>

Add implementation of the UI and loader client for Qt.

  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/ClientImpl.cpp: Added.

(toQWKPage):
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didReceiveServerRedirectForProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didFirstLayoutForFrame):
(qt_wk_didFirstVisuallyNonEmptyLayoutForFrame):
(qt_wk_didStartProgress):
(qt_wk_didChangeProgress):
(qt_wk_didFinishProgress):
(qt_wk_didBecomeUnresponsive):
(qt_wk_didBecomeResponsive):
(qt_wk_createNewPage):
(qt_wk_showPage):
(qt_wk_close):
(qt_wk_runJavaScriptAlert):

  • UIProcess/API/qt/ClientImpl.h: Added.
13:37 Changeset [62294] by tonikitoo@webkit.org
  • 1 edit in trunk/WebKit2/ChangeLog

Unreviewed more ChangeLog mess up fix caused by bad resolve-ChangeLogs merges.

13:21 Changeset [62293] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-01 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed. Update chromium tests expectations for flaky tests.

  • platform/chromium/test_expectations.txt:
13:13 Changeset [62292] by tonikitoo@webkit.org
  • 1 edit in trunk/WebKit2/ChangeLog

Unreviewed ChangeLog mess up fix cause by bad resolve-ChangeLogs merges.

13:10 Changeset [62291] by darin@apple.com
  • 3 edits in trunk/WebCore

Turn on adoptRef assertion for TreeShared.

Reviewed by Steve Falkenburg.

  • platform/TreeShared.h: Remove LOOSE_TREE_SHARED and all the ifdefs.

Actually, I used LOOSE_REF_COUNTED by accident in a few places, but
removing them all now.

  • rendering/ShadowElement.cpp:

(WebCore::ShadowBlockElement::create): Added adoptRef. This was a
storage leak before, probably recently introduced r61324.
(WebCore::ShadowInputElement::create): Ditto.

13:04 Changeset [62290] by andersca@apple.com
  • 6 edits in trunk/WebKit2

2010-07-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change the CoreIPC connection identifier to be a HANDLE on Windows
https://bugs.webkit.org/show_bug.cgi?id=41479

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/win/ConnectionWin.cpp: (CoreIPC::Connection::createServerAndClientIdentifiers): New function that creates a server and client HANDLE.

(CoreIPC::Connection::platformInitialize):
Don't open the connections here.

(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::open):

  • UIProcess/Launcher/win/WebProcessLauncher.cpp: (WebKit::webThreadBody): Get the handle from the thread.

(WebKit::launchWebProcess):
Mark the client identifier as inheritable and pass it along to the web process.

  • WebProcess/win/WebProcessMain.cpp: (WebKit::CommandLine::CommandLine): (WebKit::CommandLine::parse): (WebKit::CommandLine::operator[]): Add simple command line parser.

(WebKit::WebProcessMain):
Get the handle identifier from the command line.

  • WebProcess/win/WebProcessMain.h:
  • WebKit.pri:
13:00 Changeset [62289] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Doc improvements for QDeclarativeWebView

Patch by Bea Lam <bea.lam@nokia.com> on 2010-07-01
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
12:44 Changeset [62288] by kbr@google.com
  • 4 edits in trunk/WebKit/chromium

2010-07-01 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Stop linking against opengl32.lib in Windows Chromium port
https://bugs.webkit.org/show_bug.cgi?id=41424

  • WebKit.gyp:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent):
  • src/WebGraphicsContext3DDefaultImpl.h:
12:44 Changeset [62287] by tonikitoo@webkit.org
  • 1 edit
    7 adds in trunk/WebKit2

Initial WebKit2 implementation https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Antti Koivisto.
Patch by Kenneth Christiansen <kenneth@webkit.org>

Add initial Qt API for WebKit2

  • UIProcess/API/qt/WKView.h: Added.
  • UIProcess/API/qt/qgraphicswkview.cpp: Added.

(QGraphicsWKViewPrivate::pageRef):
(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKView::~QGraphicsWKView):
(QGraphicsWKView::page):
(QGraphicsWKView::paint):
(QGraphicsWKView::setGeometry):
(QGraphicsWKView::load):
(QGraphicsWKView::setUrl):
(QGraphicsWKView::url):
(QGraphicsWKView::title):
(QGraphicsWKView::triggerPageAction):
(QGraphicsWKView::back):
(QGraphicsWKView::forward):
(QGraphicsWKView::reload):
(QGraphicsWKView::stop):
(QGraphicsWKView::itemChange):
(QGraphicsWKView::event):
(QGraphicsWKView::sizeHint):
(QGraphicsWKView::inputMethodQuery):
(QGraphicsWKView::keyPressEvent):
(QGraphicsWKView::keyReleaseEvent):
(QGraphicsWKView::hoverMoveEvent):
(QGraphicsWKView::mouseMoveEvent):
(QGraphicsWKView::mousePressEvent):
(QGraphicsWKView::mouseReleaseEvent):
(QGraphicsWKView::mouseDoubleClickEvent):
(QGraphicsWKView::wheelEvent):
(QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
(QGraphicsWKView::visibleRect):

  • UIProcess/API/qt/qgraphicswkview.h: Added.
  • UIProcess/API/qt/qwkpage.cpp: Added.

(QWKPagePrivate::QWKPagePrivate):
(QWKPagePrivate::~QWKPagePrivate):
(QWKPagePrivate::init):
(QWKPagePrivate::toolTipChanged):
(QWKPagePrivate::paint):
(QWKPagePrivate::keyPressEvent):
(QWKPagePrivate::keyReleaseEvent):
(QWKPagePrivate::mouseMoveEvent):
(QWKPagePrivate::mousePressEvent):
(QWKPagePrivate::mouseReleaseEvent):
(QWKPagePrivate::mouseDoubleClickEvent):
(QWKPagePrivate::wheelEvent):
(QWKPagePrivate::updateAction):
(QWKPagePrivate::updateNavigationActions):
(QWKPagePrivate::_q_webActionTriggered):
(QWKPage::QWKPage):
(QWKPage::~QWKPage):
(QWKPage::pageRef):
(QWKPage::setCreateNewPageFunction):
(QWKPage::load):
(QWKPage::setUrl):
(QWKPage::url):
(QWKPage::title):
(QWKPage::setViewportSize):
(QWKPage::requestZoomRect):
(QWKPage::triggerAction):
(QWKPage::action):

  • UIProcess/API/qt/qwkpage.h: Added.
  • UIProcess/API/qt/qwkpage_p.h: Added.

(QWKPagePrivate::get):
(QWKPagePrivate::processDidExit):
(QWKPagePrivate::processDidRevive):
(QWKPagePrivate::takeFocus):

12:38 Changeset [62286] by simon.fraser@apple.com
  • 5 edits in trunk/WebCore

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Step 2: add a method, syncCompositingStateForThisLayerOnly(), to GraphicsLayer to commit
batched changes non-recursively. This allows us to use GraphicsLayer in places where we
don't want to kick off a recursive commit of the entire tree.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::syncCompositingStateForThisLayerOnly):
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::syncCompositingStateForThisLayerOnly):
  • WebCore.AcceleratedCompositing.exp: Export the new method for use in WebKit2.
12:34 Changeset [62285] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Only include the geolocation IDL in the GObject DOM bindings set
if geolocation is enabled.

  • GNUmakefile.am:
12:32 Changeset [62284] by timothy@apple.com
  • 10 edits in trunk

Provide a WebView preference to disable DNS prefetching.

https://bugs.webkit.org/show_bug.cgi?id=28825
rdar://problem/7181249

Reviewed by Darin Adler.

WebCore:

  • WebCore.base.exp: Added Settings::setDNSPrefetchingEnabled.
  • dom/Document.cpp:

(WebCore::Document::initDNSPrefetch): Check settings->dnsPrefetchingEnabled().

  • page/Settings.cpp:

(WebCore::Settings::Settings): Set m_dnsPrefetchingEnabled to true.
(WebCore::Settings::setDNSPrefetchingEnabled): Added. Set m_dnsPrefetchingEnabled.

  • page/Settings.h:

(WebCore::Settings::dnsPrefetchingEnabled): Added. Return m_dnsPrefetchingEnabled.

WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Set WebKitDNSPrefetchingEnabledPreferenceKey to YES.
(-[WebPreferences isDNSPrefetchingEnabled]): Added. Return WebKitDNSPrefetchingEnabledPreferenceKey's value.
(-[WebPreferences setDNSPrefetchingEnabled:]): Added. Set WebKitDNSPrefetchingEnabledPreferenceKey's value.

  • WebView/WebPreferencesPrivate.h: Added isDNSPrefetchingEnabled and setDNSPrefetchingEnabled:.
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]): Call WebCore::Settings::setDNSPrefetchingEnabled.

12:30 Changeset [62283] by simon.fraser@apple.com
  • 4 edits
    1 add in trunk/WebCore

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Step 1: add a new .exp file for WebCore, which exports symbols only when USE(ACCELERATED_COMPOSITING)
is defined.

Also export WebCore::FloatSize::FloatSize(WebCore::IntSize const&) from WebCore.

  • DerivedSources.make:
  • WebCore.AcceleratedCompositing.exp: Added.
  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
12:23 Changeset [62282] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the GTK+ build after r62278.

  • Scripts/webkitdirs.pm: If the make arguments have already been specified, let them override the automatic CPU detection for autotools builds.
12:14 Changeset [62281] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added _WKFramePolicyListenerDownload and _WKFramePolicyListenerIgnore.

Rubber-stamped by Anders Carlsson.

12:12 Changeset [62280] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the Windows build after r62278.

  • Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
11:47 Changeset [62279] by ap@apple.com
  • 7 edits
    3 adds in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction

Test: plugins/write-xssauditor-from-destroy.html

Fix specific known cases that also crash in same process case. I don't know if there is
any rule for when documentLoader should be checked for being null, it looks like a mess.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::referrer):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):

WebKit:

<rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction

Strengthen m_inDestroy "swipe under the carpet" fix.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Added a long comment about m_inDestroy, and changed it to static.
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): m_inDestroy is now static, so we don't initialize it in constructor. (WebKit::NetscapePluginInstanceProxy::destroy): Assert that we aren't already destroying some plug-in. (WebKit::NetscapePluginInstanceProxy::evaluate): This function accidentally lacked an m_inDestroy check in r42789.
11:42 Changeset [62278] by mrobinson@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] build-webkit does not detect the number of CPUs
https://bugs.webkit.org/show_bug.cgi?id=41469

Pass the appropriate -j<#> flag to make when building autotools builds.
This causes make to spawn that many number of child processes for doing
parallel builds.

  • Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number of CPUs. This makes the script work across more platforms.
  • Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the number of CPUs across several platforms. Use this new function to determine the appropriate arguments to pass to make for doing parallel builds with autotools build files.
11:42 Changeset [62277] by commit-queue@webkit.org
  • 7 edits in trunk

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

The HTML5 canvas 2d.drawImage.zerocanvas test does not pass
https://bugs.webkit.org/show_bug.cgi?id=40271

Unskipped canvas/philip/tests/2d.drawImage.zerocanvas.html

  • canvas/philip/tests/2d.drawImage.zerocanvas-expected.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

The HTML5 canvas 2d.drawImage.zerocanvas test does not pass
https://bugs.webkit.org/show_bug.cgi?id=40271

Throw INVALID_STATE_ERR when attempting to draw a canvas with zero width or height.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): Call setDOMException after drawImage(canvas, x, y)
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
11:28 Changeset [62276] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

[Qt] Canvas: clip() should use non-zero winding rule
https://bugs.webkit.org/show_bug.cgi?id=41466

Use non-zero winding number rule when clipping a GraphicsContext from canvas.
Fixes appearance of the "pill" in the web inspector.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::canvasClip):
10:45 Changeset [62275] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations for svg/W3C-SVG-1.1/filters-conv-01-f.svg
which is timing out on Linux and Windows.

  • platform/chromium/test_expectations.txt:
10:40 Changeset [62274] by yurys@chromium.org
  • 8 edits
    4 deletes in trunk

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62246.
http://trac.webkit.org/changeset/62246
https://bugs.webkit.org/show_bug.cgi?id=41470

"Worker tests are broken in Chromium" (Requested by yurys on
#webkit).

  • fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Removed.
  • fast/events/popup-blocked-from-fake-user-gesture.html: Removed.
  • http/tests/inspector/change-iframe-src-expected.txt: Removed.
  • http/tests/inspector/change-iframe-src.html: Removed.

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62246.
http://trac.webkit.org/changeset/62246
https://bugs.webkit.org/show_bug.cgi?id=41470

"Worker tests are broken in Chromium" (Requested by yurys on
#webkit).

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::eventAccessorGetter): (WebCore::V8DOMWindow::eventAccessorSetter):

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62246.
http://trac.webkit.org/changeset/62246
https://bugs.webkit.org/show_bug.cgi?id=41470

"Worker tests are broken in Chromium" (Requested by yurys on
#webkit).

  • src/WebBindings.cpp: (WebKit::getEvent):
10:29 Changeset [62273] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Exception erroneously thrown for drawImage() when image.complete=false
https://bugs.webkit.org/show_bug.cgi?id=33968

Added a test to verify that CRC2D does nothing when calling drawImage()
with an incomplete image or video.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

  • fast/canvas/canvas-drawImage-incomplete-expected.txt: Added.
  • fast/canvas/canvas-drawImage-incomplete.html: Added.
  • fast/canvas/script-tests/canvas-drawImage-incomplete.js: Added.

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Exception erroneously thrown for drawImage() when image.complete=false
https://bugs.webkit.org/show_bug.cgi?id=33968

Do nothing in drawImage() if called with an image whose 'complete'
attribute is false, or a video whose readyState is either HAVE_NOTHING
or HAVE_METADATA.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

Test: fast/canvas/canvas-drawImage-incomplete.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
10:14 Changeset [62272] by commit-queue@webkit.org
  • 11 edits
    4 deletes in trunk/WebKit/chromium

2010-07-01 David Holloway <dhollowa@chromium.org>

Reviewed by Darin Fisher.

[chromium] Consolidates AutoFill and Autocomplete popup menus into a single popup menu.

This change combines SuggestionsPopupMenuClient, AutoFillPopupMenuClient, and
AutocompletePopupMenuClient classes into a single consolidated AutoFillPopupMenuClient class.
Prior to this change the contents of the AutoFill popup menu only included AutoFill
suggestions and similarly the Autocomplete popup menu only included Autocomplete
suggestions. With this consolidation, both AutoFill and Autocomplete suggestions can
now be displayed in a single menu.

https://bugs.webkit.org/show_bug.cgi?id=41236

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebView.h:
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::AutoFillPopupMenuClient): (WebKit::AutoFillPopupMenuClient::~AutoFillPopupMenuClient): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionCleared): (WebKit::AutoFillPopupMenuClient::itemText): (WebKit::AutoFillPopupMenuClient::itemStyle): (WebKit::AutoFillPopupMenuClient::menuStyle): (WebKit::AutoFillPopupMenuClient::clientPaddingLeft): (WebKit::AutoFillPopupMenuClient::clientPaddingRight): (WebKit::AutoFillPopupMenuClient::popupDidHide): (WebKit::AutoFillPopupMenuClient::setTextFromItem): (WebKit::AutoFillPopupMenuClient::fontSelector): (WebKit::AutoFillPopupMenuClient::hostWindow): (WebKit::AutoFillPopupMenuClient::createScrollbar): (WebKit::AutoFillPopupMenuClient::initialize): (WebKit::AutoFillPopupMenuClient::getWebView): (WebKit::AutoFillPopupMenuClient::textFieldStyle):
  • src/AutoFillPopupMenuClient.h: (WebKit::AutoFillPopupMenuClient::itemToolTip): (WebKit::AutoFillPopupMenuClient::itemAccessibilityText): (WebKit::AutoFillPopupMenuClient::itemIsEnabled): (WebKit::AutoFillPopupMenuClient::clientInsetLeft): (WebKit::AutoFillPopupMenuClient::clientInsetRight): (WebKit::AutoFillPopupMenuClient::listSize): (WebKit::AutoFillPopupMenuClient::selectedIndex): (WebKit::AutoFillPopupMenuClient::itemIsLabel): (WebKit::AutoFillPopupMenuClient::itemIsSelected): (WebKit::AutoFillPopupMenuClient::shouldPopOver): (WebKit::AutoFillPopupMenuClient::valueShouldChangeOnHotTrack): (WebKit::AutoFillPopupMenuClient::setAutocompleteMode): (WebKit::AutoFillPopupMenuClient::getTextField): (WebKit::AutoFillPopupMenuClient::getSelectedIndex): (WebKit::AutoFillPopupMenuClient::setSelectedIndex):
  • src/AutocompletePopupMenuClient.cpp: Removed.
  • src/AutocompletePopupMenuClient.h: Removed.
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::doAutofill): (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted):
  • src/SuggestionsPopupMenuClient.cpp: Removed.
  • src/SuggestionsPopupMenuClient.h: Removed.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::currentHistoryItem): (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
  • src/WebFrameImpl.h:
  • src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::mouseUp): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::hideAutoFillPopup): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions): (WebKit::WebViewImpl::hidePopups): (WebKit::WebViewImpl::refreshAutoFillPopup):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::autoFillPopupDidHide):
09:55 Changeset [62271] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-07-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Dan Bernstein.

Prevent crash on counter destruction
https://bugs.webkit.org/show_bug.cgi?id=40032

Added counter destruction to RenderWidget::destroy()

Test: fast/css/counters/destroy-counter-crash.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):

2010-07-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Dan Bernstein.

Prevent crash on counter destruction
https://bugs.webkit.org/show_bug.cgi?id=40032

  • fast/css/counters/destroy-counter-crash-expected.txt: Added.
  • fast/css/counters/destroy-counter-crash.html: Added.
09:41 Changeset [62270] by weinig@apple.com
  • 3 edits in trunk/WebKit2

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62267.
http://trac.webkit.org/changeset/62267
https://bugs.webkit.org/show_bug.cgi?id=41468

broke stuff (Requested by weinig on #webkit).

  • UIProcess/API/C/WKBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
09:26 Changeset [62269] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed build fix after r62215.

No new functionality, so no new tests.

  • CMakeLists.txt: Add missing files and re-sort.
09:25 Changeset [62268] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added _WKFramePolicyListenerRelease and _WKFramePolicyListenerRetain.

Rubber-stamped by Sam Weinig.

09:16 Changeset [62267] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-07-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

Export symbols on Linux with GCC

  • UIProcess/API/C/WKBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
09:10 Changeset [62266] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk

[Qt] Fix a comment in WebKit.pri.

Reviewed by Simon Hausmann.

  • WebKit.pri:
09:09 Changeset [62265] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebCore

[Qt] Remove an unneeded assert.

Reviewed by Kenneth Rohde Christiansen.

This assert is triggered for example while showing the falling leaves demo.
GraphicsLayerQtImpl::toGraphicsLayerQtImpl asserts that its input
pointer is null. Looking at the uses of this method it seems like
it is expected to return null if a null pointer is given to it.

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::toGraphicsLayerQtImpl):

09:08 Changeset [62264] by jocelyn.turcotte@nokia.com
  • 4 edits in trunk

[Qt] Fix qmake vcproj generation for QtWebKit.

Reviewed by Simon Hausmann.

qmake use TARGET=/LIBS+= -lTARGET to create dependencies
between projects in a subdir template.

Since when compiling outside of Qt we hijack the target name of
QtWebKit to add the configuration and version suffix to the binary
filename, qmake can't establish the WebCore project as a dependency
to QtTestBrowser.

This patch makes sure that the target is not hijacked on the
first of the three passes where the dependencies are determined.

.:

  • WebKit.pri:

WebCore:

  • WebCore.pro:
09:04 Changeset [62263] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/WebKit2

2010-07-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Add our event factory for converting Qt events to something WebKit2
understands.

  • Shared/qt/WebEventFactoryQt.cpp: Added. (WebKit::mouseButtonForEvent): (WebKit::webEventTypeForEvent): (WebKit::modifiersForEvent): (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
  • Shared/qt/WebEventFactoryQt.h: Added.
09:03 Changeset [62262] by mrobinson@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
https://bugs.webkit.org/show_bug.cgi?id=40333

Convert draggingDataObjects to a pointer. The constructor and destructor of the
HashMap should be called explicitly. GObject memory allocation does not do this.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_drag_end): (webkit_web_view_drag_data_get): (webkit_web_view_init):
08:27 Changeset [62261] by antti.j.koivisto@nokia.com
  • 1 edit
    3 adds in trunk/WebKit2

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Add UpdateChunk. This one is mmap based, using Qt abstractions.

  • Shared/qt: Added.
  • Shared/qt/UpdateChunk.cpp: Added.

(WebKit::MappedMemory::markUsed):
(WebKit::MappedMemory::markFree):
(WebKit::MappedMemory::isFree):
(WebKit::mapMemory):
(WebKit::mapFile):
(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::~UpdateChunk):
(WebKit::UpdateChunk::data):
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
(WebKit::UpdateChunk::createImage):

  • Shared/qt/UpdateChunk.h: Added.

(WebKit::UpdateChunk::rect):
(WebKit::UpdateChunk::size):

08:05 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
CONFIG-=def_files and --no-depend-generate could be default (diff)
07:36 Changeset [62260] by antti.j.koivisto@nokia.com
  • 6 edits in trunk/WebKit2

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Include some stdlib headers to fix linux build.

  • Platform/CoreIPC/ArgumentDecoder.cpp:
  • Platform/CoreIPC/ArgumentEncoder.cpp:
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebUIClient.cpp:
07:25 Changeset [62259] by zimmermann@webkit.org
  • 4 edits in trunk/WebCore

2010-07-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGRenderStyle::diff() is missing
https://bugs.webkit.org/show_bug.cgi?id=41455

Don't just return StyleDifferenceLayout when two SVGRenderStyle objects differ.
Figure out when to repaint, and as last resort do a relayout.

Lively Kernel doesn't do any relayouts anymore, same for lots of demos in the IE9 testcenter.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/style/SVGRenderStyle.h:
07:16 Changeset [62258] by yurys@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/chromium/test_expectations.txt:
06:49 Changeset [62257] by antti.j.koivisto@nokia.com
  • 3 edits
    2 adds in trunk/WebKit2

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement CoreIPC::Connection and PlatformProcessIdentifier for Qt. Not built yet.

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/qt: Added.
  • Platform/CoreIPC/qt/ConnectionQt.cpp: Added.

(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::newConnectionHandler):
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::openConnection):
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):

  • Platform/PlatformProcessIdentifier.h:
06:18 Changeset [62256] by antti.j.koivisto@nokia.com
  • 2 edits
    1 add in trunk/WebKit2

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement WorkQueue for Qt. Not built yet.

  • Platform/WorkQueue.h:
  • Platform/qt/WorkQueueQt.cpp: Added.

(WorkQueue::WorkItemQt::WorkItemQt):
(WorkQueue::WorkItemQt::~WorkItemQt):
(WorkQueue::WorkItemQt::execute):
(WorkQueue::WorkItemQt::timerEvent):
(WorkQueue::connectSignal):
(WorkQueue::disconnectSignal):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::scheduleWork):

06:10 Changeset [62255] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Yury Semikhatsky.

Fix wrong style comment in chromium test expectations file.
https://bugs.webkit.org/show_bug.cgi?id=41460

  • platform/chromium/test_expectations.txt:
05:49 Changeset [62254] by antti.j.koivisto@nokia.com
  • 4 edits in trunk

Revert accidental commit.

JavaScriptCore:

  • runtime/Collector.cpp:

(JSC::Heap::allocateBlock):

WebCore:

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

05:42 Changeset [62253] by antti.j.koivisto@nokia.com
  • 4 edits
    2 adds in trunk

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement RunLoop for Qt. Not built yet.

  • Platform/RunLoop.h:
  • Platform/qt: Added.
  • Platform/qt/RunLoopQt.cpp: Added.

(RunLoop::TimerObject::TimerObject):
(RunLoop::TimerObject::performWork):
(RunLoop::TimerObject::wakeUp):
(RunLoop::TimerObject::timerEvent):
(RunLoop::run):
(RunLoop::stop):
(RunLoop::RunLoop):
(RunLoop::~RunLoop):
(RunLoop::wakeUp):
(RunLoop::TimerBase::timerFired):
(RunLoop::TimerBase::TimerBase):
(RunLoop::TimerBase::~TimerBase):
(RunLoop::TimerBase::start):
(RunLoop::TimerBase::stop):
(RunLoop::TimerBase::isActive):

05:28 Changeset [62252] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Patrick Gansterer <paroga@paroga.com>

Reviewed by Dirk Schulze.

Buildfix for !ENABLE(FILTERS) after r62238.
https://bugs.webkit.org/show_bug.cgi?id=41456

  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::prepareToRenderSVGContent):
05:17 Changeset [62251] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/WebKit/qt

2010-07-01 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Create QComboBoxes when clicked and destroy on hide.
https://bugs.webkit.org/show_bug.cgi?id=41451

Currently a QComboBox is created for each RenderMenuList and
it gets destroyed either when the RenderMenuList or the
QWebView (its Qt parent) is destroyed. This cause a crash
when the QWebView is destroyed before the render tree (which
is kept in cache).

This patch aim to destroy the QComboBox as soon as its popup
gets hidden, and likewise, create it only when the popup is
requested to be shown.
It also removes the unneeded reference to the QGraphicsProxyWidget,
destroying the QComboBox automatically destroys its bound
proxywidget.

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::hide): (WebCore::QtFallbackWebPopup::destroyPopup): (WebCore::QtFallbackWebPopup::populate):
  • WebCoreSupport/QtFallbackWebPopup.h:
04:39 Changeset [62250] by morrita@google.com
  • 5 edits in trunk/WebCore

2010-07-01 MORITA Hajime <morrita@google.com>

Unreviewed build fix.

  • rendering/RenderInputSpeech.cpp: (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
  • rendering/RenderInputSpeech.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintInputFieldSpeechButton):
  • rendering/RenderTheme.h:
04:11 Changeset [62249] by commit-queue@webkit.org
  • 20 edits
    16 adds in trunk

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Kent Tamura.

Rendering the speech button in input elements.
https://bugs.webkit.org/show_bug.cgi?id=40984

input-appearance-speechbutton.html checks the appearances of various sizes of speech buttons.
input-appearance-searchandspeech.html checks input type='search' field with speech button.
input-appearance-numberandspeech.html checks input type='number' field with speech button.

  • fast/forms/input-appearance-numberandspeech-expected.txt: Added.
  • fast/forms/input-appearance-numberandspeech.html: Added.
  • fast/forms/input-appearance-searchandspeech-expected.txt: Added.
  • fast/forms/input-appearance-searchandspeech.html: Added.
  • fast/forms/input-appearance-speechbutton-expected.txt: Added.
  • fast/forms/input-appearance-speechbutton.html: Added.
  • platform/chromium/test_expectations.txt: Skipped all these new tests as the speech input feature is disabled by default.
  • platform/gtk/Skipped:
  • platform/mac/fast/forms/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-numberandspeech-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-searchandspeech-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-speechbutton-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-speechbutton-expected.png: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Kent Tamura.

Rendering the speech button in input elements.
https://bugs.webkit.org/show_bug.cgi?id=40984

The button currently has only one state and rendered as an image on all platforms. Subsequent
patches will add user input handling and more states + rendering code to the button. The
button's appearance can be customized by individual ports in their RenderTheme implementation
if required.

Tests: platform/mac/fast/forms/input-appearance-numberandspeech.html

platform/mac/fast/forms/input-appearance-searchandspeech.html
platform/mac/fast/forms/input-appearance-speechbutton.html

  • GNUmakefile.am:
  • Resources/inputSpeech.png: Added.
  • Resources/inputSpeech.tiff: Added. Used by the Mac implementation.
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.qrc:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap): Load the speech button images for Qt port.
  • rendering/RenderInputSpeech.cpp: Added. (WebCore::RenderInputSpeech::adjustInputFieldSpeechButtonStyle): Sets the button's dimensions. (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
  • rendering/RenderInputSpeech.h: Added.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): Create the speech button. (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle): (WebCore::RenderTheme::paintInputFieldSpeechButton):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchFieldCancelButton): Get cancel button to render to the left of speech button when enabled.

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Kent Tamura.

Rendering the speech button in input elements.
https://bugs.webkit.org/show_bug.cgi?id=40984

  • Api/qwebsettings.cpp: (graphics):
  • Api/qwebsettings.h:
03:50 Changeset [62248] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] Extra nullcheck needed at SelectionControllerGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=41447

Extra null check added.

  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
03:39 Changeset [62247] by hausmann@webkit.org
  • 4 edits in trunk

[Qt][Symbian] Bumped up the maximum heap size to 96MB

Rubber-stamped by Laszlo Gombos.

.:

  • WebKit.pri:

WebKitTools:

  • QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration

and use the one from WebKit.pri instead.

03:05 Changeset [62246] by yurys@chromium.org
  • 8 edits
    4 adds in trunk

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41350

  • fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
  • fast/events/popup-blocked-from-fake-user-gesture.html: Added.
  • http/tests/inspector/change-iframe-src-expected.txt: Added.
  • http/tests/inspector/change-iframe-src.html: Added.

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41350

Tests: fast/events/popup-blocked-from-fake-user-gesture.html

http/tests/inspector/change-iframe-src.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): use V8Proxy from the ScriptController instead of one from the call stack. Get event directly from hidden property to avoid unnecessary checks.
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::eventAccessorGetter): (WebCore::V8DOMWindow::eventAccessorSetter):

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41350

  • src/WebBindings.cpp: (WebKit::getEvent):
02:55 Changeset [62245] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Promote webkit-patch land-safely to main help
https://bugs.webkit.org/show_bug.cgi?id=41446

I've been using this command a bunch and recommending it to folks. We
should show it in main help as it's past the experimental phase.

  • Scripts/webkitpy/tool/commands/upload.py:
02:47 Changeset [62244] by zimmermann@webkit.org
  • 6 edits in trunk/WebCore

2010-07-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGContainer/RenderSVGRoot report wrong strokeBoundingBox()
https://bugs.webkit.org/show_bug.cgi?id=41450

strokeBoundingBox() was reporting the repaintRectInLocalCoordinates() for children of a container,
instead of the actual strokeBoundingBox(). Only visible in WebInspector when looking at a container
which has a resource applied and contains a children which also has a resource applied.

Doesn't affect any test results.

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::objectBoundingBox): (WebCore::RenderSVGContainer::strokeBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::objectBoundingBox): Deinlined this functions, it's virtual so there's no gain. (WebCore::RenderSVGRoot::strokeBoundingBox): Ditto. (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
  • rendering/RenderSVGRoot.h:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerBoundingBox):
  • rendering/SVGRenderSupport.h: Add enum controlling the mode of container bounding box mode calculation.
02:45 Changeset [62243] by zherczeg@webkit.org
  • 7 edits in trunk

WebCore: Implementing feConvolveMatrix svg filter
https://bugs.webkit.org/show_bug.cgi?id=5861

Reviewed by Nikolas Zimmermann.

The implementation is optimized for speed, and uses
multiple algorithms for different parts of the image.
See SVGFEConvolveMatrixElement.cpp for a detailed
description.

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::build):

  • svg/graphics/filters/SVGFEConvolveMatrix.cpp:

(WebCore::clampRGBAValue):
(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
(WebCore::FEConvolveMatrix::getPixelValue):
(WebCore::FEConvolveMatrix::fastSetOuterPixels):
(WebCore::FEConvolveMatrix::setInteriorPixels):
(WebCore::FEConvolveMatrix::setOuterPixels):
(WebCore::FEConvolveMatrix::apply):

  • svg/graphics/filters/SVGFEConvolveMatrix.h:

(WebCore::FEConvolveMatrix::uniteChildEffectSubregions):

LayoutTests: Updating expected values for feConvolveMatrix
https://bugs.webkit.org/show_bug.cgi?id=5861

Reviewed by Nikolas Zimmermann.

  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
02:41 Changeset [62242] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Abstract 'a'-'z' checks into a function
https://bugs.webkit.org/show_bug.cgi?id=41438

Hopefully this version is more readable.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
02:29 Changeset [62241] by abarth@webkit.org
  • 4 edits in trunk

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Parameter names in frame src URLs parsed incorrectly if resembles HTML entity code followed by underscore
https://bugs.webkit.org/show_bug.cgi?id=41345

Add some more HTML entity test coverage for when the trailing semicolon
character is required.

  • html5lib/resources/entities02.dat:

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Parameter names in frame src URLs parsed incorrectly if resembles HTML entity code followed by underscore
https://bugs.webkit.org/show_bug.cgi?id=41345

Apparently whether an HTML entity requires a trailing semicolon varies
depending on the entity. The full table is in the spec:

http://www.whatwg.org/specs/web-apps/current-work/multipage/named-character-references.html#named-character-references

I believe branch added in this patch is accurate. At some point, I'll
add a full test suite for all the named entities.

  • html/HTMLEntityParser.cpp: (WebCore::consumeHTMLEntity):
02:06 Changeset [62240] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
01:36 Changeset [62239] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-07-01 Eric Seidel <eric@webkit.org>

Unreviewed. Fix paste-o in Gtk build file.

Split out HTMLFormattingElementList into its own file
https://bugs.webkit.org/show_bug.cgi?id=41440

  • GNUmakefile.am:
01:33 Changeset [62238] by zimmermann@webkit.org
  • 9 edits in trunk/WebCore

2010-07-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel & Dirk Schulze.

Performance regression for setting content of <text> in SVG
https://bugs.webkit.org/show_bug.cgi?id=36564

Dramatically reducing the number of repaintRectInLocalCoordinates() calls needed while painting.
Do not pass the repaintRect to prepareToRenderSVGContent, only calculate it if opacity < 1 or -webkit-svg-shadow is set.
Most noticeable is that RenderSVGRoot had to visit all children, before actually painting, just to calculate the repaint rect.
And as RenderSVGRoot never carries shadow or opacity it was completly useless.

RenderSVGContainer also called repaintRectInLocalCoordinates, but the result is only needed when painting outlines, which is a rare case.
These modifications fix the performance regression and the number of repaintRectInLocalCoordinate calls for the complex example in
the bug report with 500 runs shrinks from 1.7 million calls to less than 105.000.

50 runs without the patch: ~ 520.8ms
50 runs with the patch : ~ 501.8ms

The test calls setTimeout(0) 50 times, that already accounts for the 500ms. So setting the content of a <text>
element withs clippers applied, is very cheap now.

Also remove the need to pass in a filter argument to prepareToRenderSVGContent/finishRenderSVGContent, it can easily be grabbed
of the cache - just like all other resources are handled, simplifying the code.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::prepareToRenderSVGContent): (WebCore::SVGRenderSupport::finishRenderSVGContent):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
01:20 Changeset [62237] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make html5lib/runner dump failure details by default
https://bugs.webkit.org/show_bug.cgi?id=41436

This makes it much easier to see our result changes
in patch reviews. Especially when we change behavior
but don't necessarily fix entire subtests.

This patch was previously rolled out due to a bogus comment
in tests1.dat causing a EOF (null) to be emitted in the
results, causing diff to treat the file as binary (and thus
make it impossible to see differences).

The EOF/NULL bug was resolved by bug 41439, so relanding.

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
01:14 Changeset [62236] by morrita@google.com
  • 4 edits in trunk/WebKitTools

2010-06-28 MORITA Hajime <morrita@google.com>

Reviewed by Shinichiro Hamaji.

rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
https://bugs.webkit.org/show_bug.cgi?id=38775

  • Introduced SCM.show_head() and SCM.diff_for_file().
  • Replaced direct svn invocations with newly implement SCM methods.
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
01:07 Changeset [62235] by eric@webkit.org
  • 10 edits
    2 adds in trunk/WebCore

2010-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split out HTMLFormattingElementList into its own file
https://bugs.webkit.org/show_bug.cgi?id=41440

No functional changes, thus no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::indexOfFirstUnopenFormattingElement): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements):
  • html/HTMLTreeBuilder.h:
00:53 Changeset [62234] by aa@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-07-01 Aaron Boodman <aa@chromium.org>

Reviewed by Darin Fisher.

Make the user script API static. This makes it more convenient to use
if you don't have a WebView instance yet.

Added static versions of the three methods and re-route current ones
temporarily through the static versions. Will remove the non-static
versions once Chromium has been updated.

Also, expose the URLPattern configuration for user stylesheets, since
they were not before.

https://bugs.webkit.org/show_bug.cgi?id=41385

  • public/WebView.h: (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet):
  • src/WebViewImpl.cpp: (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet): (WebKit::WebView::removeAllUserContent):
00:39 Changeset [62233] by abarth@webkit.org
  • 6 edits in trunk

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

BogusCommentState should come in from the cold
https://bugs.webkit.org/show_bug.cgi?id=41439

Test progression => :)

  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

BogusCommentState should come in from the cold
https://bugs.webkit.org/show_bug.cgi?id=41439

The BogusCommentState has always been wrong. The proximate issue is
that it didn't handle resuming correctly when parsing a partial input
stream. Now that we have EOF working properly, we can actually
implement this state correctly.

We need to distinguish when we enter this state from when we continue
in this state. We could do that with a branch for each character, but
it seemed easier to split the state in two, even though that leaves us
with one more state in our tokenizer than we have in the HTML5 spec.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::):
00:12 Changeset [62232] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-07-01 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r62231.
http://trac.webkit.org/changeset/62231
https://bugs.webkit.org/show_bug.cgi?id=41436

diff thinks runner-expected.txt is binary which makes the
results impossible to read

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:

06/30/10:

23:42 Changeset [62231] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make html5lib/runner dump failure details by default
https://bugs.webkit.org/show_bug.cgi?id=41436

This makes it much easier to see our result changes
in patch reviews. Especially when we change behavior
but don't necessarily fix entire subtests.

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
23:24 Changeset [62230] by mrobinson@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-06-30 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r62226.
http://trac.webkit.org/changeset/62226
https://bugs.webkit.org/show_bug.cgi?id=40333

This change caused 13 new crashers.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_drag_end): (webkit_web_view_drag_data_get): (webkit_web_view_init):
23:22 Changeset [62229] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTokenizer's whitespace checks are very redundant
https://bugs.webkit.org/show_bug.cgi?id=41434

This patch adds isTokenizerWhitespace, which replaces a lot of
redundant logic in nextToken.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
23:07 Changeset [62228] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-06-30 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Crash when uploading document to Google Docs
https://bugs.webkit.org/show_bug.cgi?id=40795

Fix bug where the local file wasn't opened (for POSTing)
if it were the first element in the form.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::FormDataIODevice::FormDataIODevice): (WebCore::FormDataIODevice::moveToNextElement): (WebCore::FormDataIODevice::openFileForCurrentElement):
  • platform/network/qt/QNetworkReplyHandler.h:
22:53 Changeset [62227] by eric@webkit.org
  • 5 edits in trunk

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement generateImpliedEndTags and deploy to steps which were blocked on it
https://bugs.webkit.org/show_bug.cgi?id=41432

  • html5lib/runner-expected-html5.txt:
    • Test 2.28 is now fixed.

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement generateImpliedEndTags and deploy to steps which were blocked on it
https://bugs.webkit.org/show_bug.cgi?id=41432

This fixes one subtest in html5lib/runner.html and positively
effects a couple others.

More code sharing will be needed here. For the moment
we're using copy/paste code, but that will soon be shared.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::generateImpliedEndTagsWithExclusion): (WebCore::HTMLTreeBuilder::generateImpliedEndTags):
  • html/HTMLTreeBuilder.h:
22:44 Changeset [62226] by mrobinson@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
https://bugs.webkit.org/show_bug.cgi?id=40333

Convert draggingDataObjects to a pointer. The constructor and destructor of the
HashMap should be called explicitly. GObject memory allocation does not do this.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_drag_end): (webkit_web_view_drag_data_get): (webkit_web_view_init):
22:38 Changeset [62225] by mrobinson@webkit.org
  • 4 edits in trunk/LayoutTests

2010-06-30 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Update GTK+ expected results after r62215.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
22:26 Changeset [62224] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-30 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix Sam's brokeness.

AFAIK, this new expected result is ok (especially given that it still
says PASS).

  • fast/dom/Window/window-postmessage-clone-expected.txt:
17:26 Changeset [62223] by ossy@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed fix. Update Qt specific expected files after r62215.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
17:07 Changeset [62222] by ossy@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed buildfix after r62196 and r62214.

  • html/HTMLElementStack.cpp: Put !ENABLE(SVG) guard instead of

!ENABLE(SVG_FOREIGN_OBJECT) around include of SVGNames.h.

17:05 Changeset [62221] by weinig@apple.com
  • 2 edits in trunk/WebCore

Really fix the windows build.

  • bindings/js/JSBindingsAllInOne.cpp:
17:00 Changeset [62220] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another Chromium build fix.

  • page/DOMWindow.idl:
16:59 Changeset [62219] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix Chromium build.

  • WebCore.gyp/WebCore.gyp:
16:52 Changeset [62218] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix Windows build.

  • bindings/js/JSBindingsAllInOne.cpp:
16:50 Changeset [62217] by levin@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Added chromium-mac specific results due to new tests added in r62200.

Reviewed by NOBODY (baseline updates corresponding to newly added tests).

  • platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.checksum: Added.
  • platform/chromium/test_expectations.txt: Added failures due to bug 41311.
16:39 Changeset [62216] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix Gtk build.

  • GNUmakefile.am:
16:15 Changeset [62215] by weinig@apple.com
  • 22 edits
    13 adds in trunk

WebCore: Patch for https://bugs.webkit.org/show_bug.cgi?id=41146
<rdar://problem/8126069>
Implement the .dataset DOM property

Reviewed by Dan Bernstein.

Tests: fast/dom/dataset-xhtml.xhtml

fast/dom/dataset.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMStringMapCustom.cpp: Added.

(WebCore::JSDOMStringMap::canGetItemsForName):
(WebCore::JSDOMStringMap::nameGetter):
(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):
(WebCore::JSDOMStringMap::putDelegate):

  • bindings/js/JSDOMStringMapCustom.h: Added.
  • dom/DOMStringMap.cpp: Added.

(WebCore::DOMStringMap::~DOMStringMap):

  • dom/DOMStringMap.h: Added.

(WebCore::DOMStringMap::DOMStringMap):

  • dom/DOMStringMap.idl: Added.
  • dom/DatasetDOMStringMap.cpp: Added.

(WebCore::isValidAttributeName):
(WebCore::convertAttributeNameToPropertyName):
(WebCore::propertyNameMatchesAttributeName):
(WebCore::isValidPropertyName):
(WebCore::convertPropertyNameToAttributeName):
(WebCore::DatasetDOMStringMap::ref):
(WebCore::DatasetDOMStringMap::deref):
(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):
(WebCore::DatasetDOMStringMap::setItem):
(WebCore::DatasetDOMStringMap::deleteItem):

  • dom/DatasetDOMStringMap.h: Added.

(WebCore::DatasetDOMStringMap::create):
(WebCore::DatasetDOMStringMap::DatasetDOMStringMap):

  • dom/Element.cpp:

(WebCore::Element::dataset):

  • dom/Element.h:
  • dom/Element.idl:
  • dom/ElementRareData.h:
  • page/DOMWindow.idl:

LayoutTests: Test changes for https://bugs.webkit.org/show_bug.cgi?id=41146
<rdar://problem/8126069>
Implement the .dataset DOM property

Reviewed by Dan Bernstein.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/dataset-expected.txt: Added.
  • fast/dom/dataset-xhtml-expected.txt: Added.
  • fast/dom/dataset-xhtml.xhtml: Added.
  • fast/dom/dataset.html: Added.
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/script-tests/dataset-xhtml.js: Added.
  • fast/dom/script-tests/dataset.js: Added.
  • fast/dom/script-tests/domListEnumeration.js:
  • fast/js/global-constructors-expected.txt:
16:10 Changeset [62214] by darin@apple.com
  • 2 edits in trunk/WebCore

More Qt build fix.

  • html/HTMLElementStack.cpp: Put !ENABLE(SVG_FOREIGN_OBJECT) around

include of SVGNames.h too.

16:09 Changeset [62213] by darin@apple.com
  • 5 edits in trunk

2010-06-30 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Add assertion, off by default, for when you forget to do adoptRef
https://bugs.webkit.org/show_bug.cgi?id=41422

  • wtf/PassRefPtr.h: Tweaked formatting. Added a new adopted function, called on the pointer by adoptRef, with an empty inline default version, meant to be overloaded. Unified the inlining with a macro named REF_DEREF_INLINE to make it clearer what's going on in the refIfNotNull/derefIfNotNull functions. Renamed releaseRef to leakRef, but left the old name in for compatibility for now.
  • wtf/RefCounted.h: Added code to require adoption and assert if you don't call adoptRef. For now, it is turned off because of the LOOSE_REF_COUNTED define in this header. Later we can turn it on once we get everything working without asserting.

2010-06-30 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Add assertion, off by default, for when you forget to do adoptRef
https://bugs.webkit.org/show_bug.cgi?id=41422

  • platform/TreeShared.h: Added code to require adoption and assert if you don't call adoptRef. For now, it is turned off because of the LOOSE_TREE_SHARED define in this header. Later we can turn it on once we get everything working without asserting. Note also that it only works for objects with an initial reference count of 1.
15:58 Changeset [62212] by weinig@apple.com
  • 6 edits
    4 adds in trunk/WebKit2

Patch for https://bugs.webkit.org/show_bug.cgi?id=41426
Add ImmutableArray class and WKArrayRef API to go with it. This will be used
in a few follow up patches.

Reviewed by Darin Adler.

  • Shared/ImmutableArray.cpp: Added.

(WebKit::ImmutableArray::ImmutableArray):
(WebKit::ImmutableArray::~ImmutableArray):

  • Shared/ImmutableArray.h: Added.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKArray.cpp: Added.
  • UIProcess/API/C/WKArray.h: Added.
  • UIProcess/API/C/WKBase.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:
15:57 Changeset [62211] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-30 Albert J. Wong <ajwong@chromium.org>

Not reviewed. Chromium: Disable flaky test.

Add an IMAGE failure to linux standalone-image-drag-to-editable.html.
Test has been flaky on build.

  • platform/chromium/test_expectations.txt:
15:48 Changeset [62210] by simon.fraser@apple.com
  • 3 edits in trunk/WebKitTools

2010-06-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Allow MiniBrowser to open local files
https://bugs.webkit.org/show_bug.cgi?id=41104

Wire up the openDocument: message with an NSOpenPanel, so we can open
local files.

Also change the xib so that the window remembers its size.

  • MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate frontmostBrowserWindowController]): (-[BrowserAppDelegate openDocument:]): (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
  • MiniBrowser/mac/English.lproj/BrowserWindow.xib:
15:34 Changeset [62209] by crogers@google.com
  • 1 edit in branches/audio/WebCore/WebCore.xcodeproj/project.pbxproj

fix build problem for audio branch

15:24 Changeset [62208] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-06-30 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Buildfix for !ENABLE(SVG_FOREIGN_OBJECT) after r62196.
https://bugs.webkit.org/show_bug.cgi?id=41429

  • html/HTMLElementStack.cpp:
14:45 Changeset [62207] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add new popUntil(tagName) function and deploy
https://bugs.webkit.org/show_bug.cgi?id=41405

Add a new popUntil function to share some common code
between states. There is more code to share here, but this
is a start.

I also filled in a couple similar states to these with the
hope of sharing more code, but decided to wait for a later
patch.

No test changes, since this code doesn't do enough yet to
pass any more subtests. Lack of generateImpliedEndTags is the main
blocking issue.

  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::popUntil):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
14:44 Changeset [62206] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-06-30 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Roll forward Chromium DEPS to r51287
https://bugs.webkit.org/show_bug.cgi?id=41430

  • DEPS:
14:24 Changeset [62205] by crogers@google.com
  • 3 edits in branches/audio/WebCore/audio

Implement the actual unity gain summing junction code for AudioNodeInput

  • still not handling generic AudioNode case
  • optimizations not yet there, but current implementation will hold us for awhile
14:24 Changeset [62204] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/performance_timer.cc

Fix performance timer to work multiple times

14:24 Changeset [62203] by crogers@google.com
  • 5 edits
    2 copies
    1 add in branches/audio/WebCore

Add AudioGainNode

14:24 Changeset [62202] by crogers@google.com
  • 4 edits in branches/audio/WebCore/audio

Make sure to handle ownership properly (with reference counting) in AudioBufferSourceNode

14:24 Changeset [62201] by crogers@google.com
  • 13 edits in branches/audio/WebCore/audio

Initial architectural changes to support unity-gain summing junctions for AudioNode inputs

  • this helps simplifies the javascript API (along with AudioGainNode) so we can get rid of AudioMixerNode and AudioMixerInputNode
  • more work needed to actually do the summing
  • we won't optimize all paths initially, but performance will be adequate
13:49 Changeset [62200] by bdakin@apple.com
  • 1 edit
    80 adds in trunk/LayoutTests

20 tests to (at least temporarily) satisfy https://bugs.webkit.org/show_bug.cgi?id=41303 Need way more border-radius tests

Reviewed by Dan Bernstein.

  • fast/borders/border-radius-circle.html: Added.
  • fast/borders/border-radius-groove-01.html: Added.
  • fast/borders/border-radius-groove-02.html: Added.
  • fast/borders/border-radius-groove-03.html: Added.
  • fast/borders/border-radius-wide-border-01.html: Added.
  • fast/borders/border-radius-wide-border-02.html: Added.
  • fast/borders/border-radius-wide-border-03.html: Added.
  • fast/borders/border-radius-wide-border-04.html: Added.
  • fast/borders/borderRadiusDashed04.html: Added.
  • fast/borders/borderRadiusDashed05.html: Added.
  • fast/borders/borderRadiusDashed06.html: Added.
  • fast/borders/borderRadiusDotted04.html: Added.
  • fast/borders/borderRadiusDotted05.html: Added.
  • fast/borders/borderRadiusDotted06.html: Added.
  • fast/borders/borderRadiusDouble04.html: Added.
  • fast/borders/borderRadiusDouble05.html: Added.
  • fast/borders/borderRadiusDouble06.html: Added.
  • fast/borders/borderRadiusDouble07.html: Added.
  • fast/borders/borderRadiusDouble08.html: Added.
  • fast/borders/borderRadiusDouble09.html: Added.
  • platform/mac/fast/borders/border-radius-circle-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-circle-expected.png: Added.
  • platform/mac/fast/borders/border-radius-circle-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-groove-01-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-groove-01-expected.png: Added.
  • platform/mac/fast/borders/border-radius-groove-01-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-groove-02-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-groove-02-expected.png: Added.
  • platform/mac/fast/borders/border-radius-groove-02-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-groove-03-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-groove-03-expected.png: Added.
  • platform/mac/fast/borders/border-radius-groove-03-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-wide-border-01-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-wide-border-01-expected.png: Added.
  • platform/mac/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-wide-border-02-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-wide-border-02-expected.png: Added.
  • platform/mac/fast/borders/border-radius-wide-border-02-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-wide-border-03-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-wide-border-03-expected.png: Added.
  • platform/mac/fast/borders/border-radius-wide-border-03-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-wide-border-04-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-wide-border-04-expected.png: Added.
  • platform/mac/fast/borders/border-radius-wide-border-04-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDashed04-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDashed04-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDashed04-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDashed05-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDashed05-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDashed05-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDashed06-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDashed06-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDashed06-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDotted04-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDotted04-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDotted04-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDotted05-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDotted05-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDotted05-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDotted06-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDotted06-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDotted06-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble04-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble04-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble04-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble05-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble05-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble05-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble06-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble06-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble06-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble07-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble07-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble07-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble08-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble08-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble08-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble09-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble09-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble09-expected.txt: Added.
13:48 Changeset [62199] by weinig@apple.com
  • 3 edits
    1 add in trunk/WebKitTools

Add debug-webkittestrunner and cleanup related scripts.

Rubber-stamped by Anders Carlsson.

  • Scripts/debug-webkittestrunner: Added.
  • Scripts/run-webkittestrunner:
  • Scripts/webkitdirs.pm:
13:11 Changeset [62198] by xan@webkit.org
  • 4 edits in trunk

WebCore:

2010-06-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Unit test for DOM insertion methods
https://bugs.webkit.org/show_bug.cgi?id=40495

Fix typo in custom function detection method.

  • bindings/scripts/CodeGeneratorGObject.pm:

WebKit/gtk:

2010-06-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Unit test for DOM insertion methods
https://bugs.webkit.org/show_bug.cgi?id=40495

Add unit test for webkit_dom_node_remove_child.

  • tests/testdomnode.c: (test_dom_node_insertion):
13:11 Changeset [62197] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Unit test for DOM insertion methods
https://bugs.webkit.org/show_bug.cgi?id=40495

Add unit tests for node insertion and replacement methods.

  • tests/testdomnode.c: (test_dom_node_insertion): (main):
13:02 Changeset [62196] by eric@webkit.org
  • 7 edits in trunk

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement HTML5 "in scope" algorithm and attempt to use it
https://bugs.webkit.org/show_bug.cgi?id=41402

Adds two new (expected) failures, since we're now
switching out of InBody to AfterBody when seeing
</html>. We don't implement AfterBody yet, so
the rest of the content after </html> is ignored.

  • html5lib/runner-expected-html5.txt:

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement HTML5 "in scope" algorithm and attempt to use it
https://bugs.webkit.org/show_bug.cgi?id=41402

Implemented the 4 needed "in scope" functions for HTML5.
3 for the different sets of scope markers, and one for
doing exact element comparisons instead of tag name searches.

I deployed inScope("body") for </body> and </html> in InBody.

Adds two new (expected) failures, since we're now
switching out of InBody to AfterBody when seeing
</html>. We don't implement AfterBody yet, so
the rest of the content after </html> is ignored.

  • html/HTMLElementStack.cpp: (WebCore::inScopeCommon): (WebCore::HTMLElementStack::inScope): (WebCore::HTMLElementStack::inListItemScope): (WebCore::HTMLElementStack::inTableScope):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h:
12:50 Changeset [62195] by eric@webkit.org
  • 9 edits
    2 adds in trunk/WebCore

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split HTMLElementStack out into its own file
https://bugs.webkit.org/show_bug.cgi?id=41399

No functional change, thus no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementStack.cpp: Added. (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::next): (WebCore::HTMLElementStack::ElementRecord::releaseNext): (WebCore::HTMLElementStack::ElementRecord::setNext): (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::~HTMLElementStack): (WebCore::HTMLElementStack::popHTMLHeadElement): (WebCore::HTMLElementStack::pop): (WebCore::HTMLElementStack::pushHTMLHtmlElement): (WebCore::HTMLElementStack::pushHTMLHeadElement): (WebCore::HTMLElementStack::pushHTMLBodyElement): (WebCore::HTMLElementStack::push): (WebCore::HTMLElementStack::top): (WebCore::HTMLElementStack::removeHTMLHeadElement): (WebCore::HTMLElementStack::remove): (WebCore::HTMLElementStack::contains): (WebCore::HTMLElementStack::inScope): (WebCore::HTMLElementStack::htmlElement): (WebCore::HTMLElementStack::headElement): (WebCore::HTMLElementStack::bodyElement): (WebCore::HTMLElementStack::pushCommon): (WebCore::HTMLElementStack::popCommon): (WebCore::HTMLElementStack::removeNonFirstCommon):
  • html/HTMLElementStack.h: Added.
  • html/HTMLTreeBuilder.h:
12:17 Changeset [62194] by kbr@google.com
  • 4 edits
    2 adds in trunk

2010-06-30 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

WebCore::WebGLArrayInternal::lengthAttrGetter ReadAV@NULL (b1a3e1a3e9d01f17fd493d68eeb2742f)
https://bugs.webkit.org/show_bug.cgi?id=38040

Changed custom ArrayBufferView constructors to create a
fully-initialized, zero-length array when called with zero
arguments. This is the simplest fix which works identically in
both the JSC and V8 bindings.

Test: fast/canvas/webgl/array-buffer-view-crash.html

  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferView):
  • bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray):

2010-06-30 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

WebCore::WebGLArrayInternal::lengthAttrGetter ReadAV@NULL (b1a3e1a3e9d01f17fd493d68eeb2742f)
https://bugs.webkit.org/show_bug.cgi?id=38040

Changed custom ArrayBufferView constructors to create a
fully-initialized, zero-length array when called with zero
arguments. This is the simplest fix which works identically in
both the JSC and V8 bindings.

  • fast/canvas/webgl/array-buffer-view-crash-expected.txt: Added.
  • fast/canvas/webgl/array-buffer-view-crash.html: Added.
11:49 Changeset [62193] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/WebKit/qt

2010-06-30 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make sure we catch closed QComboBox popups.
https://bugs.webkit.org/show_bug.cgi?id=39019

The way it works currently is using the QComboBox::show/hidePopup
virtual method to catch popup requests in the middle. There is
some cases however that the popup widget gets closed without
going through the hidePopup method.

This patch adds an event filter to the popup's view to know when
it gets closed and calls hidePopup to call our handling code.
This may get hidePopup called twice but this shouldn't have any
effect.

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::QtFallbackWebPopupCombo): (WebCore::QtFallbackWebPopupCombo::eventFilter):
  • WebCoreSupport/QtFallbackWebPopup.h:
10:53 Changeset [62192] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix after recent changes to LayoutTestController.

10:33 Changeset [62191] by weinig@apple.com
  • 7 edits in trunk/WebKitTools

Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
Make WebKitTestRunner work with more than one test at a time.

Reviewed by Anders Carlsson.

This converts WebKitTestRunner to a similar model as DumpRenderTree,
where there is a single WKView and each test is run it, rather than
the design I was using where each test got its own WKView.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didRecieveMessage):
(WTR::InjectedBundle::reset):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
(WTR::TestController::runTest):
(WTR::TestController::_didRecieveMessageFromInjectedBundle):
(WTR::TestController::didRecieveMessageFromInjectedBundle):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::mainWebView):
(WTR::TestController::pageNamespace):
(WTR::TestController::context):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::~TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didRecieveMessageFromInjectedBundle):

  • WebKitTestRunner/TestInvocation.h:
10:00 Changeset [62190] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Add reviewer.

10:00 Changeset [62189] by victorw@chromium.org
  • 2 edits in trunk/WebCore

2010-06-30 Victor Wang <victorw@chromium.org>

Reviewed by Darin Fisher.

[chromium] update webcore gyp to use v8 dll for chromium multi dll build.

https://bugs.webkit.org/show_bug.cgi?id=41376

  • WebCore.gyp/WebCore.gyp:
09:38 Changeset [62188] by leandro@webkit.org
  • 2 edits in trunk

2010-06-30 Leandro Pereira <leandro@profusion.mobi>

Unreviewed.

Generate CSSValueKeywords.cpp instead of CSSValueKeywords.c to avoid
recompilation and relinking of WebCore when no files were changed.

  • cmake/WebKitGenerators.cmake:
09:26 UsingGitWithWebKit edited by ojan@chromium.org
(diff)
08:52 Changeset [62187] by jeremy@chromium.org
  • 2 edits
    1 add in trunk/WebCore

2010-06-30 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add OOP font loading to FontPlatformDataChromiumMac.

On OS X, with font management software installed. Fonts
can reside in an arbitrary path on disk which is blocked by
Chromium's sandbox.

This change adds hooks to FontPlaformData which allow cross-process
font loading in case of need.

https://bugs.webkit.org/show_bug.cgi?id=41148

Not possible to test - requires sandboxing which DRT doesn't support.

  • WebCore.gypi:
  • platform/graphics/chromium/FontPlatformDataChromiumMac.mm: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::roundsGlyphAdvances): (WebCore::FontPlatformData::allowsLigatures): (WebCore::FontPlatformData::description):
08:29 Changeset [62186] by jeremy@chromium.org
  • 3 edits in trunk/WebCore

2010-06-30 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dan Bernstein.

Minor tweaks to FontPlatformDataMac & SimpleFontDataMac.mm

  • Avoid an extra FontPlatformData copy in SimpleFontDataMac.mm
  • Fix a typo in FontPlatformDataMac.mm

https://bugs.webkit.org/show_bug.cgi?id=41152

No behavior changes so no new tests.

  • platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::description):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::copyFontTableForTag):
08:16 Changeset [62185] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-06-30 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make "disallow multiple calls to SetWindow" on windowed plugins a quirk
https://bugs.webkit.org/show_bug.cgi?id=41407

Only disallow calling SetWindow more than once if we're using Flash 9 or older.
This fixes resizing of YouTube videos via the player's own button.

Removed copy-pasted logic in PluginViewGtk since the issue only exists
when running Flash with a non-Gtk toolkit.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::determineQuirks):
  • plugins/PluginQuirkSet.h: (WebCore::):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): Remove unnecessary logic copy-pasted from PluginViewQt.
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
07:20 Changeset [62184] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-06-30 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antti Koivisto.

[Qt, Gtk, Symbian] Mind the semantics of NPRect for windowed plugin clip rects
https://bugs.webkit.org/show_bug.cgi?id=41406

NPRect has right/bottom instead of width/height.
This was fixed in PluginViewMac with http://trac.webkit.org/changeset/45815

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
07:02 Changeset [62183] by yurys@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2010-06-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62182.
http://trac.webkit.org/changeset/62182
https://bugs.webkit.org/show_bug.cgi?id=41408

GTK build brekage (Requested by pfeldman on #webkit).

  • inspector/debugger-eval-while-paused-expected.txt: Removed.
  • inspector/debugger-eval-while-paused.html: Removed.
  • platform/qt/Skipped:
06:11 Changeset [62182] by yurys@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-06-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add layout test for console evaluations with paused script
https://bugs.webkit.org/show_bug.cgi?id=41336

  • inspector/debugger-eval-while-paused-expected.txt: Added.
  • inspector/debugger-eval-while-paused.html: Added.
  • platform/qt/Skipped:
06:04 Changeset [62181] by aroben@apple.com
  • 5 edits in trunk/LayoutTests

Update Windows test results after r62092

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
06:03 Changeset [62180] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit

2010-06-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement windowRect() and setWindowRect() in ChromeClientEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=40876

  • efl/WebCoreSupport/ChromeClientEfl.cpp: Implements two methods to change window size.

(WebCore::ChromeClientEfl::windowRect):
(WebCore::ChromeClientEfl::setWindowRect):

05:38 Changeset [62179] by tonikitoo@webkit.org
  • 5 edits
    3 adds in trunk

2010-06-30 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Fraser.

Spatial Navigation: make elements in inner frames nested more than 1 level deep focusable
https://bugs.webkit.org/show_bug.cgi?id=41160

Patch addresses the problem of spatial navigation not work properly with nested
inner frames by adding the isNodeDeepDescendantOfDocument function. It recursively checks
if a give node is descendant of a given document or any parent of it.

Test: fast/events/spatial-navigation/snav-iframe-nested.html

  • page/FocusController.cpp: (WebCore::FocusController::deepFindFocusableNodeInDirection):
  • page/SpatialNavigation.cpp: (WebCore::isNodeDeepDescendantOfDocument):
  • page/SpatialNavigation.h:
  • fast/events/spatial-navigation/resources/iframe.html: Added.
  • fast/events/spatial-navigation/snav-iframe-nested-expected.txt: Added.
  • fast/events/spatial-navigation/snav-iframe-nested.html: Added.
05:27 Changeset [62178] by pfeldman@chromium.org
  • 10 edits in trunk

2010-06-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chrome DevTools: Finalize migration to new WebView constructor
(devtools agent is now created within WebViewImpl only).

https://bugs.webkit.org/show_bug.cgi?id=41212

  • public/WebDevToolsAgent.h:
  • public/WebView.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):
  • tests/PopupMenuTest.cpp: (WebKit::SelectPopupMenuTest::SetUp):
05:15 Changeset [62177] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
05:01 Changeset [62176] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
https://bugs.webkit.org/show_bug.cgi?id=40446

Reviewed by Laszlo Gombos.

We quickly run out of memory on Symbian when loading web pages. This is
caused by the default heap size, which is not suited for a web browser.

This change bumps the max heap size to 32MB.

  • QtTestBrowser/QtTestBrowser.pro:
03:27 Changeset [62175] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTokenizer should use fewer macros
https://bugs.webkit.org/show_bug.cgi?id=41397

Macros are sadness. Inline functions are the new hotness.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processEntity): (WebCore::HTMLTokenizer::emitAndResumeIn): (WebCore::HTMLTokenizer::emitAndReconsumeIn): (WebCore::HTMLTokenizer::emitEndOfFile): (WebCore::HTMLTokenizer::flushBufferedEndTag): (WebCore::HTMLTokenizer::flushEmitAndResumeIn): (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::bufferCharacter): (WebCore::HTMLTokenizer::bufferCodePoint): (WebCore::HTMLTokenizer::bufferParseError): (WebCore::HTMLTokenizer::bufferCurrentToken): (WebCore::HTMLTokenizer::bufferEndOfFile):
  • html/HTMLTokenizer.h:
03:10 Changeset [62174] by jschuh@chromium.org
  • 8 edits
    1 delete in trunk/WebCore

2010-06-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Remove dead binding code
https://bugs.webkit.org/show_bug.cgi?id=41388

Removed BindingElement because it was obsoleted by r59866.

  • WebCore.gypi:
  • bindings/generic/BindingElement.h: Removed.
  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8Binding.h:
  • bindings/v8/custom/V8DatabaseCustom.cpp:
  • bindings/v8/custom/V8DatabaseSyncCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
02:46 Changeset [62173] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-30 Eric Seidel <eric@webkit.org>

Unreviewed. Just updating test expectations.

HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344

Update results after EndOfFile support.
The final pump will always have one character,
which is the EOF character.

  • inspector/timeline-parse-html-expected.txt:
02:14 Changeset [62172] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344

EndOfFile support uncovered a bug in our implementation of finish().
finish() may be called more than once if the first call does not
result in end() being called (and parsing thus actually stopping).

SegmentedString::close() should have ASSERTed that it was not already
closed when close() is called. I've added such an assert now.

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finish):
  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::close):
  • platform/text/SegmentedString.h:
01:54 Changeset [62171] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Unreviewed Symbian build fix.

[Qt] Update the def files to link DumpRenderTree.

  • symbian/eabi/QtWebKitu.def:
01:45 Changeset [62170] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch land allow the user to continue even if the builders are red
https://bugs.webkit.org/show_bug.cgi?id=41395

I don't think it's good that we've been teaching people
to always pass --ignore-builders. At least land is now
useable w/o --ignore-builders.

  • Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
01:35 Changeset [62169] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-30 Samuel Nevala <samuel.nevala@digia.com>

Reviewed by Simon Hausmann.

[Qt] Auto test wont compile from \3rdparty\webkit\WebKit\qt\tests
https://bugs.webkit.org/show_bug.cgi?id=38720

Load qttest_p4.prf under QTDIR_build.

  • tests/tests.pri:
01:28 Changeset [62168] by eric@webkit.org
  • 10 edits in trunk

2010-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344

We now pass an additional 60 subtests for the
html5lib test suite. Boo-ya.

  • html5lib/runner-expected.txt:

2010-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344

We're using \0 as the EndOfFile marker as HTML5 replaces
all other \0 with \0xFFFD. Added some special case logic
to InputStreamPreprocessor::peek not to replace \0 when
its being used at the end of a stream.

This fixed 60 subtests in html5lib/runner.html.

There are still at least two states (BogusCommentState and
CDATASectionState) which do not have proper EOF support.

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finish): (WebCore::HTMLDocumentParser::finishWasCalled):
  • html/HTMLInputStream.h: (WebCore::HTMLInputStream::markEndOfFile): (WebCore::HTMLInputStream::haveSeenEndOfFile):
  • html/HTMLToken.h: (WebCore::HTMLToken::makeEndOfFile):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::emitEndOfFile):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek): (WebCore::HTMLTokenizer::InputStreamPreprocessor::shouldTreatNullAsEndOfFileMarker):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
01:23 Changeset [62167] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-30 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] Random failure on 'testdownload' unit test
https://bugs.webkit.org/show_bug.cgi?id=38256

Make sure the set_filename function is called after handling the
'download-requested' signal for the asynchronous test. This change
is needed because it could happen, with the current code, that the
set_filename () function got called too early in the mainloop,
therefore screwing the tests because the 'theDownload' global
variable wouldn't be properly set yet.

With this modification we ensure the set_filename() function gets
called always after handling the download-requested signal,
therefore avoiding potentialproblems.

  • tests/testdownload.c: (set_filename): (handle_download_requested_cb): (download_requested_cb): (download_requested_asynch_cb): (test_webkit_download_perform):
01:18 Changeset [62166] by eric@webkit.org
  • 6 edits in trunk

2010-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach HTML5TreeBuilder how to merge attributes from extra html/body elements
https://bugs.webkit.org/show_bug.cgi?id=41337

  • html5lib/resources/webkit01.dat: Add a test for double body.

2010-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach HTML5TreeBuilder how to merge attributes from extra html/body elements
https://bugs.webkit.org/show_bug.cgi?id=41337

Had to teach ElementStack to store pointers to html, head, and body
elements.

This fixed a few tests in LayoutTests/html5lib.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML): (WebCore::HTMLTreeBuilder::mergeAttributesFromTokenIntoElement): (WebCore::HTMLTreeBuilder::insertHTMLStartTagInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::createElementAndAttachToCurrent): (WebCore::HTMLTreeBuilder::insertHTMLHtmlElement): (WebCore::HTMLTreeBuilder::insertHTMLHeadElement): (WebCore::HTMLTreeBuilder::insertHTMLBodyElement): (WebCore::HTMLTreeBuilder::insertElement): (WebCore::HTMLTreeBuilder::insertGenericRCDATAElement): (WebCore::HTMLTreeBuilder::insertGenericRawTextElement):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::ElementStack): (WebCore::HTMLTreeBuilder::ElementStack::popHTMLHeadElement): (WebCore::HTMLTreeBuilder::ElementStack::pop): (WebCore::HTMLTreeBuilder::ElementStack::pushHTMLHtmlElement): (WebCore::HTMLTreeBuilder::ElementStack::pushHTMLHeadElement): (WebCore::HTMLTreeBuilder::ElementStack::pushHTMLBodyElement): (WebCore::HTMLTreeBuilder::ElementStack::push): (WebCore::HTMLTreeBuilder::ElementStack::removeHTMLHeadElement): (WebCore::HTMLTreeBuilder::ElementStack::remove): (WebCore::HTMLTreeBuilder::ElementStack::htmlElement): (WebCore::HTMLTreeBuilder::ElementStack::headElement): (WebCore::HTMLTreeBuilder::ElementStack::bodyElement): (WebCore::HTMLTreeBuilder::ElementStack::pushCommon): (WebCore::HTMLTreeBuilder::ElementStack::popCommon): (WebCore::HTMLTreeBuilder::ElementStack::removeNonFirstCommon):
01:15 Changeset [62165] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed: update Chromium test expectations with a crashing test.

  • platform/chromium/test_expectations.txt:
01:12 Changeset [62164] by commit-queue@webkit.org
  • 4 edits in trunk

2010-06-30 José Millán Soto <jmillan@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Text attributes not exposed
https://bugs.webkit.org/show_bug.cgi?id=25528

Implemented the get_run_attributes and get_default_attributes
functions for the ATK_TEXT role.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getAttributeSetForAccessibilityObject): (compareAttribute): (attributeSetDifference): (accessibilityObjectLength): (getAccessibilityObjectForOffset): (getRunAttributesFromAccesibilityObject): (webkit_accessible_text_get_run_attributes): (webkit_accessible_text_get_default_attributes):

2010-06-30 José Millán Soto <jmillan@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Text attributes not exposed
https://bugs.webkit.org/show_bug.cgi?id=25528

Added new tests for accessible text attributes

  • tests/testatk.c: (compAtkAttribute): (compAtkAttributeName): (atkAttributeSetAttributeHasValue): (atkAttributeSetAreEqual): (testWebkitAtkTextAttributes): (main):
01:00 Changeset [62163] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-06-30 Yuta Kitamura <yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix Sec-WebSocketKey{1,2} headers.

According to WebSocket specification, a value of Sec-WebSocketKey{1,2} header
should not start or end with a space.

WebSocket: Malformed handshake headers in a worker due to rand_s failing
https://bugs.webkit.org/show_bug.cgi?id=41327

No new tests. ASSERT should catch the problem.

  • websockets/WebSocketHandshake.cpp: (WebCore::generateSecWebSocketKey):
00:43 Changeset [62162] by yurys@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-06-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed: provide custom expectations and reenable the test for Chromium.

https://bugs.webkit.org/show_bug.cgi?id=41394

  • platform/chromium/editing/pasteboard/5761530-1-expected.txt: Added.

06/29/10:

23:47 Changeset [62161] by yuzo@google.com
  • 3 edits
    2 adds in trunk

2010-06-30 Yuzo Fujishima <yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 41339 - unicode-range property only with a descending range
causes a crash

https://bugs.webkit.org/show_bug.cgi?id=41339

  • fast/css/font-face-descending-unicode-range-expected.txt: Added.
  • fast/css/font-face-descending-unicode-range.html: Added.

2010-06-30 Yuzo Fujishima <yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 41339 - unicode-range property only with a descending range
causes a crash

https://bugs.webkit.org/show_bug.cgi?id=41339

Test: fast/css/font-face-descending-unicode-range.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceUnicodeRange):
22:13 Changeset [62160] by morrita@google.com
  • 4 edits in trunk/LayoutTests

2010-06-29 MORITA Hajime <morrita@google.com>

Unreviewed. Updated test expectations for change at r62156

  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium/test_expectations.txt:
20:49 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
20:46 Changeset [62159] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebCore

2010-06-29 Abhinav Mithal <abhinav.mithal@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] Fix doube-deallocation while destroying PluginContainerSymbian
https://bugs.webkit.org/show_bug.cgi?id=37303

  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::platformDestroy):
19:28 Changeset [62158] by zmo@google.com
  • 16 edits in trunk

2010-06-29 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Implement getAttachedShaders
https://bugs.webkit.org/show_bug.cgi?id=31172

  • fast/canvas/webgl/gl-object-get-calls-expected.txt: Add a test case for getAttachedShaders().
  • fast/canvas/webgl/script-tests/gl-object-get-calls.js: Ditto.

2010-06-29 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Implement getAttachedShaders
https://bugs.webkit.org/show_bug.cgi?id=31172

  • bindings/js/JSWebGLRenderingContextCustom.cpp: JS binding for getAttachedShaders(). (WebCore::JSWebGLRenderingContext::getAttachedShaders):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: V8 binding for getAttachedShaders(). (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getAttachedShaders): Implementation of getAttachedShaders(). (WebCore::WebGLRenderingContext::findShader): Helper function to find a shader object from its name.
  • html/canvas/WebGLRenderingContext.h: Declaration of getAttachedShaders().
  • html/canvas/WebGLRenderingContext.idl: Ditto.
  • platform/graphics/GraphicsContext3D.h: Ditto.
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::getAttachedShaders): Implementation of getAttachedShaders().

2010-06-29 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Implement getAttachedShaders
https://bugs.webkit.org/show_bug.cgi?id=31172

  • public/WebGraphicsContext3D.h: Declaration of getAttachedShaders().
  • src/GraphicsContext3D.cpp: Implementation of getAttachedShaders().
  • src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
  • src/WebGraphicsContext3DDefaultImpl.h: Declaration of getAttachedShaders().
18:52 Changeset [62157] by commit-queue@webkit.org
  • 3 edits in trunk

2010-06-29 Antoine Labour <piman@chromium.org>

Reviewed by Dimitri Glazkov.

Only call Windows-specific PlatformSkiaContext functions on Windows.

  • WebCore/platform/graphics/chromium/LayerChromium.cpp:
  • WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:
18:29 Changeset [62156] by morrita@google.com
  • 4 edits in trunk

2010-06-29 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

REGRESSION: [Chromium] <progress> appearance on windows looks not good
https://bugs.webkit.org/show_bug.cgi?id=41343

Skipped a test with outdated expectation. We need to rebaseline it.

  • platform/chromium/test_expectations.txt:

2010-06-29 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

REGRESSION: [Chromium] <progress> appearance on windows looks not good
https://bugs.webkit.org/show_bug.cgi?id=41343

RenderThemeChromiumWin::paintProgressBar() should return false,
which indicates the widget is painted.

Test: fast/dom/HTMLProgressElement/progress-element.html

  • rebaselined with a wrong expectation.
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintProgressBar):
18:16 Changeset [62155] by kinuko@chromium.org
  • 6 edits in trunk

2010-06-29 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Fix http/tests/local/blob/send-data-blob.html on Windows
https://bugs.webkit.org/show_bug.cgi?id=41228

Fix a regression bug in the line-conversion code.
Rewrite the line-conversion function with simpler functions to
make it less error prone.

No new tests as this is for bug fixes.

  • platform/BlobItem.cpp: (WebCore::StringBlobItem::convertToCString):

2010-06-29 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Fix http/tests/local/blob/send-data-blob.html on Windows
https://bugs.webkit.org/show_bug.cgi?id=41228

Fix the cgi code to make it work with cygwin perl.
Also fix test expectations for Windows.

  • http/tests/resources/post-and-verify-hybrid.cgi:
  • platform/chromium/test_expectations.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
18:03 Changeset [62154] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-06-29 James Robinson <jamesr@chromium.org>

Unreviewed chromium expectations update.

Mark fast/parser/residual-style-hang.html as slow on windows debug because it is.

  • platform/chromium/test_expectations.txt:
17:30 Changeset [62153] by dumi@chromium.org
  • 17 edits in trunk

WebCore: Implementing DatabaseSync::openDatabaseSync().
https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Darin Fisher.

  1. Moved some common code from Database to AbstractDatabase.
  2. Made performOpenAndVerify() virtual, since DatabaseSync doesn't need to interact with DatabaseThread.
  3. Removed the m_creationCallback field, since it's only needed in the openDatabase{Sync} methods.
  • storage/AbstractDatabase.cpp:

(WebCore::retrieveTextResultFromDatabase):
(WebCore::setTextValueInDatabase):
(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::updateGuidVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::AbstractDatabase::databaseInfoTableName):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::closeDatabase):
(WebCore::AbstractDatabase::version):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::scriptExecutionContext):
(WebCore::AbstractDatabase::securityOrigin):
(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::estimatedSize):
(WebCore::AbstractDatabase::fileName):
(WebCore::AbstractDatabase::databaseVersionKey):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
(WebCore::AbstractDatabase::versionMatchesExpected):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::disableAuthorizer):
(WebCore::AbstractDatabase::enableAuthorizer):
(WebCore::AbstractDatabase::setAuthorizerReadOnly):
(WebCore::AbstractDatabase::lastActionChangedDatabase):
(WebCore::AbstractDatabase::lastActionWasInsert):
(WebCore::AbstractDatabase::resetDeletes):
(WebCore::AbstractDatabase::hadDeletes):
(WebCore::AbstractDatabase::resetAuthorizer):

  • storage/AbstractDatabase.h:

(WebCore::AbstractDatabase::opened):
(WebCore::AbstractDatabase::isNew):
(WebCore::AbstractDatabase::databaseDebugName):

  • storage/Database.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::version):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::close):
(WebCore::Database::stop):
(WebCore::Database::performOpenAndVerify):

  • storage/Database.h:

(WebCore::Database::sqliteDatabase):

  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::create):
(WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
(WebCore::DatabaseAuthorizer::denyBasedOnTableName):

  • storage/DatabaseAuthorizer.h:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::markAsDeletedAndClose):
(WebCore::CloseSyncDatabaseOnContextThreadTask::create):
(WebCore::CloseSyncDatabaseOnContextThreadTask::performTask):
(WebCore::CloseSyncDatabaseOnContextThreadTask::CloseSyncDatabaseOnContextThreadTask):
(WebCore::DatabaseSync::closeImmediately):

  • storage/DatabaseSync.h:
  • storage/DatabaseTask.cpp:

(WebCore::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseOpenTask::doPerformTask):

  • storage/DatabaseTask.h:

(WebCore::DatabaseOpenTask::create):

WebKit/chromium: Simplify the WebDatabase interface.
https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Darin Fisher.

Do not ref()/deref() the private AbstractDatabase member. This
allows us to use WebDatabase in the destructors of the DB
classes.

  • public/WebDatabase.h:

(WebKit::WebDatabase::WebDatabase):

  • src/WebDatabase.cpp:

(WebKit::WebDatabase::name):
(WebKit::WebDatabase::displayName):
(WebKit::WebDatabase::estimatedSize):
(WebKit::WebDatabase::securityOrigin):
(WebKit::WebDatabase::WebDatabase):

LayoutTests: Uncomment some test cases in open-database-sync-inputs, and
comment out for now the ones that fail in V8.
https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Darin Fisher.

  • fast/workers/storage/open-database-sync-inputs-expected.txt:
  • fast/workers/storage/resources/open-database-sync-inputs.js:

(catch):

15:57 Changeset [62152] by commit-queue@webkit.org
  • 7 edits in trunk

2010-06-29 François Sausset <sausset@gmail.com>

Reviewed by Darin Adler.

Add a test when a msubsup element is wrapped in a mrow element
https://bugs.webkit.org/show_bug.cgi?id=36525

  • mathml/presentation/subsup.xhtml:
  • platform/mac/mathml/presentation/subsup-expected.checksum:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:

2010-06-29 François Sausset <sausset@gmail.com>

Reviewed by Darin Adler.

Fix a bug when a msubsup element is inside a mrow element
https://bugs.webkit.org/show_bug.cgi?id=36525

Test: mathml/presentation/subsup.xhtml

  • mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::stretchToHeight):
15:27 Changeset [62151] by mrowe@apple.com
  • 5 edits in tags/Safari-534.1.4

Versioning.

15:22 Changeset [62150] by zmo@google.com
  • 4 edits
    2 adds in trunk

2010-06-29 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

uniformmatrix* should generate INVALID_VALUE with transpose = true
https://bugs.webkit.org/show_bug.cgi?id=41235

  • fast/canvas/webgl/gl-uniformmatrix4fv-expected.txt: Added.
  • fast/canvas/webgl/gl-uniformmatrix4fv.html: Added.

2010-06-29 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

uniformmatrix* should generate INVALID_VALUE with transpose = true
https://bugs.webkit.org/show_bug.cgi?id=41235

Test: fast/canvas/webgl/gl-uniformmatrix4fv.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::uniformMatrix2fv): Call validateUniformMatrixParameters instead. (WebCore::WebGLRenderingContext::uniformMatrix3fv): Ditto. (WebCore::WebGLRenderingContext::uniformMatrix4fv): Ditto. (WebCore::WebGLRenderingContext::validateUniformMatrixParameters): Validate input parameters for uniformMatrix*().
  • html/canvas/WebGLRenderingContext.h: Declare validateUniformMatrixParameters().
15:19 Changeset [62149] by mrowe@apple.com
  • 1 copy in tags/Safari-534.1.4

New tag.

15:01 Changeset [62148] by commit-queue@webkit.org
  • 4 edits in trunk/JavaScriptCore

2010-06-29 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Bug 41238 - RegExp performance slow on Dromaeo benchmark

Other javascript engines appear to cache prior results of regular
expression operations.

Suggest adding some sort of caching mechanism to regular expression
processing.

Added a single entry cache of match() results to RegExp class.

Also added performance improvements to UString == operator.
First check the impls for equality. Then get the length of
each of the non-null impls. Next check the sizes for equality.
Then check the data for the case of different impls that point
to the same data (most likely due to substrings from the beginning of
another string). Lastly we check the underlying data for equality.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::match):
  • runtime/RegExp.h:
  • runtime/UString.h: (JSC::operator==):
14:27 BuildBot edited by mrowe@apple.com
(diff)
14:25 Changeset [62147] by robert@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-06-29 Robert Hogan <robert@webkit.org>

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Update test expectations for tests added in r62134.

  • platform/qt/fast/text/setData-dirty-lines-expected.txt: Added.
  • platform/qt/fast/text/splitText-dirty-lines-expected.txt: Added.
13:47 Changeset [62146] by robert@webkit.org
  • 6 edits in trunk/LayoutTests

2010-06-29 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Results for editing/pasteboard/5761530-1.html are wrong

https://bugs.webkit.org/show_bug.cgi?id=38437

Qt seems to have the correct result here. So unskip on Qt and
skip on other platforms so can be fixed.

  • editing/pasteboard/5761530-1-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
13:16 Changeset [62145] by kbr@google.com
  • 11 edits
    2 adds in trunk

2010-06-29 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Support UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL for texImage2D taking ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=40398

Added support for UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL pixel store
parameters to texImage2D and texSubImage2D entry points taking ArrayBufferView.
More cleanly separated the unpacking and packing phases of user-supplied pixel data
in GraphicsContext3D, and added support for unpack alignment. Fixed bug in handling
of unpackAlignment in GraphicsContext3D::flipVertically. Necessarily added
validation of the amount of data passed to texImage2D and texSubImage2D. Modified
fast/canvas/webgl/tex-image-with-format-and-type.html to include premultiplied alpha
tests for relevant source formats; added new test which exercises all combinations
of UNPACK_FLIP_Y_WEBGL, UNPACK_PREMULTIPLY_ALPHA_WEBGL, and UNPACK_ALIGNMENT pixel
store parameters.

Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::validateTexFuncData):
  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::extractTextureData): (WebCore::GraphicsContext3D::flipVertically): (WebCore::doUnpackingAndPacking): (WebCore::computeIncrementParameters): (WebCore::doPacking): (WebCore::GraphicsContext3D::packPixels):
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):

2010-06-29 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Support UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL for texImage2D taking ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=40398

Added support for UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL pixel store
parameters to texImage2D and texSubImage2D entry points taking ArrayBufferView.
More cleanly separated the unpacking and packing phases of user-supplied pixel data
in GraphicsContext3D, and added support for unpack alignment. Fixed bug in handling
of unpackAlignment in GraphicsContext3D::flipVertically. Necessarily added
validation of the amount of data passed to texImage2D and texSubImage2D. Modified
fast/canvas/webgl/tex-image-with-format-and-type.html to include premultiplied alpha
tests for relevant source formats; added new test which exercises all combinations
of UNPACK_FLIP_Y_WEBGL, UNPACK_PREMULTIPLY_ALPHA_WEBGL, and UNPACK_ALIGNMENT pixel
store parameters.

  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html: Added.
  • fast/canvas/webgl/tex-image-with-format-and-type-expected.txt:
  • fast/canvas/webgl/tex-image-with-format-and-type.html:
13:08 Changeset [62144] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-06-29 Patrick Gansterer <paroga@paroga.com>

Reviewed by Dirk Schulze.

Buildfix for !ENABLE(SVG_FOREIGN_OBJECT) after r61667.
https://bugs.webkit.org/show_bug.cgi?id=41367

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::isOutermostSVG): Add missing ENABLE(SVG_FOREIGN_OBJECT).
13:01 Changeset [62143] by andersca@apple.com
  • 2 edits in trunk/WebKit2

2010-06-29 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add a private Message class template
https://bugs.webkit.org/show_bug.cgi?id=41370

  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Message::Message): (CoreIPC::Connection::Message::arguments):
12:52 Changeset [62142] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-06-29 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Buildfix after r62118.
https://bugs.webkit.org/show_bug.cgi?id=41365

  • rendering/RenderSVGRoot.cpp: Inlude missing RenderSVGResource.h.
12:38 Changeset [62141] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-29 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] http/tests/security/mixedContent tests now pass

https://bugs.webkit.org/show_bug.cgi?id=34839

  • platform/qt/Skipped:
11:37 Changeset [62140] by robert@webkit.org
  • 10 edits in trunk

2010-06-29 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] implement dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=41260

Unskip fast/preloader tests.

  • platform/qt/Skipped:

2010-06-29 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] support dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=41260

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::dumpResourceResponseMIMETypes):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-06-29 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] support dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=41260

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpResourceResponseMIMETypes):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
11:31 Changeset [62139] by levin@chromium.org
  • 8 edits in trunk/WebCore

2010-06-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62052.
http://trac.webkit.org/changeset/62052
https://bugs.webkit.org/show_bug.cgi?id=41357

Causes crashes in JSLazyEventListener::initializeFunction (see
bug 41352) (Requested by aroben on #webkit).

  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/js/ScriptEventListener.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/ScriptEventListener.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute):
11:30 Changeset [62138] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-06-29 Nathan Lawrence <nlawrence@apple.com>

Reviewed by Geoffrey Garen.

WTF::HashSet iterators are quasi-mutable. Changing the value through
dereferencing an iterator will not change the behavior of methods like
contains or find, but will change the behavior of iterating.

  • wtf/HashSet.h: (WTF::::begin): (WTF::::end): (WTF::::find): (WTF::::remove):
  • wtf/HashTable.h:
11:30 Changeset [62137] by levin@chromium.org
  • 2 edits in trunk/WebCore

2010-06-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62129.
http://trac.webkit.org/changeset/62129
https://bugs.webkit.org/show_bug.cgi?id=41362

Needed to roll out r62052 (see bug 41357) (Requested by aroben
on #webkit).

  • bindings/js/ScriptEventListener.cpp: (WebCore::createWindowAttributeEventListener):
11:08 Changeset [62136] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-29 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Fisher.

A crash caused by the patch of bug 40608.
https://bugs.webkit.org/show_bug.cgi?id=41334

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::caretOrSelectionBounds):
10:46 Changeset [62135] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Speculative fix for <rdar://problem/8071558> CrashTracer: [USER]
2300+ crashes in Safari at com.apple.WebCore:
WebCore::FrameView::scheduleRelayout + 352

Reviewed by Darin Adler.

Unfortunately, we don't have a reproducible case for this bug, and
therefore, we do not have a layout test either. It is pretty clear
from the logs that m_frame->settings() is null in
FrameView::scheduleRelayout() in the crashing case.
m_frame->settings() is null whenever page is null. Everywhere else
in FrameView.cpp we null-check either page or settings before using
settings. It seems plausible to me that scheduleRelayout could be
called when page is null, so the fix is just to add null-checks.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):

10:42 Changeset [62134] by mitz@apple.com
  • 4 edits
    8 adds in trunk

<rdar://problem/7975842> Certain text is repeated after using splitText()

Reviewed by Darin Adler.

WebCore:

Tests: fast/text/setData-dirty-lines.html

fast/text/splitText-dirty-lines.html

  • dom/CharacterData.cpp:

(WebCore::CharacterData::setData): Call RenderText::setTextWithOffset() rather than
setText(), because only the former correctly dirties line boxes.

  • dom/Text.cpp:

(WebCore::Text::splitText): Ditto.

LayoutTests:

  • fast/text/setData-dirty-lines-expected.checksum: Added.
  • fast/text/setData-dirty-lines-expected.png: Added.
  • fast/text/setData-dirty-lines-expected.txt: Added.
  • fast/text/setData-dirty-lines.html: Added.
  • fast/text/splitText-dirty-lines-expected.checksum: Added.
  • fast/text/splitText-dirty-lines-expected.png: Added.
  • fast/text/splitText-dirty-lines-expected.txt: Added.
  • fast/text/splitText-dirty-lines.html: Added.
10:40 Changeset [62133] by victorw@chromium.org
  • 13 edits in trunk/WebKit/chromium

2010-06-29 Victor Wang <victorw@chromium.org>

Reviewed by Darin Fisher.

[chromium]: Update webkit for chromium multi dll build.

  1. Export more webkit APIs for chromium multi dll build.
  2. Update DumpRenderTree sources so it can build with webkit.dll
  3. Temp disable webkit unit tests for chromium multi dll build.

https://bugs.webkit.org/show_bug.cgi?id=41231

  • WebKit.gyp:
  • public/WebAccessibilityCache.h:
  • public/WebAccessibilityObject.h:
  • public/WebEventListener.h:
  • public/WebGeolocationServiceMock.h:
  • public/WebGraphicsContext3D.h:
  • public/WebIDBDatabaseError.h: (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::operator=):
  • public/WebNotification.h:
  • public/WebPasswordFormData.h:
  • public/WebSearchableFormData.h:
  • public/WebStorageEventDispatcher.h:
  • public/WebString.h: (WebKit::WebString::WebString): (WebKit::WebString::operator=):
10:26 Changeset [62132] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-06-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62073.
http://trac.webkit.org/changeset/62073
https://bugs.webkit.org/show_bug.cgi?id=41359

Necessary to fix chromium build when r62052 is rolled out.
(Requested by dave_levin on #webkit).

  • bindings/v8/ScriptEventListener.h:
10:11 Changeset [62131] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-29 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Gustavo Noronha Silva.

platform/gtk/accessibility/name-from-label test needs updating
https://bugs.webkit.org/show_bug.cgi?id=41355

Updated test and expected results to match changes introduced
with patch for bug 40009 (make it more coherent with other ports)

  • platform/gtk/accessibility/name-from-label-expected.txt:
  • platform/gtk/accessibility/name-from-label.html:
10:11 Changeset [62130] by darin@chromium.org
  • 15 edits in trunk

2010-06-29 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Hooking up WebGL layers to the gpu-compositor. Implement missing
methods to set the contents of a GraphicsLayer with a platform specific WebGL
Layer, and to update the contents of the WebGL Layer when needed.
https://bugs.webkit.org/show_bug.cgi?id=41243

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToWebGL):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::removeAllSublayers): No need to call setNeedsCommit() from here as the previous call to layer->removeFromSuperlayer() will have that effect (and we only need to notify the owner if there were actually any sublayers removed).
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayer):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::create): (WebCore::WebGLLayerChromium::updateTextureContents): (WebCore::WebGLLayerChromium::setContext):
10:03 Changeset [62129] by ossy@webkit.org
  • 2 edits in trunk/WebCore

2010-06-29 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Nikolas Zimmermann.

Buildfix for --minimal build after r62052
https://bugs.webkit.org/show_bug.cgi?id=41338

  • bindings/js/ScriptEventListener.cpp: #if ENABLE(SVG) guards added. (WebCore::createWindowAttributeEventListener):
09:30 Changeset [62128] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Build fix. Not reviewd.

CGColor is only used for PLATFORM(CG). Conditionalize include
to correct build failure for WinCairo.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

Conditionalize use of CGColor.

09:24 Changeset [62127] by mnaganov@chromium.org
  • 9 edits in trunk/LayoutTests

2010-06-29 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed text expectations update after r62121.

  • platform/chromium-linux/fast/css/font-face-opentype-expected.checksum:
  • platform/chromium-linux/fast/css/font-face-opentype-expected.png:
  • platform/chromium-linux/fast/css/font-face-woff-expected.checksum:
  • platform/chromium-linux/fast/css/font-face-woff-expected.png:
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.checksum:
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.png:
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.txt:
  • platform/chromium/test_expectations.txt:
09:20 Changeset [62126] by mrobinson@webkit.org
  • 2 edits in trunk

Fix two small typos in my most recent ChangeLog entries.

09:09 Changeset [62125] by mrobinson@webkit.org
  • 4 edits in trunk

2010-06-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Clean up the source lists in the GNUMakefile.am files
https://bugs.webkit.org/show_bug.cgi?id=41229

Clean up the GNUMakefile.ac a little bit. Alphabetize and conglomerate
the source lists.

  • GNUmakefile.am:

2010-06-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Clean up the source lists in the GNUMakefile.am files
https://bugs.webkit.org/show_bug.cgi?id=41229

Clean up the GNUMakefile.ac a little bit. Alphabetize and conglomerate
the source lists.

  • GNUmakefile.am:
08:38 Changeset [62124] by mrobinson@webkit.org
  • 3 edits in trunk/WebCore

2010-06-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DragDataGtk should use DataObjectGtk as the platformDragData
https://bugs.webkit.org/show_bug.cgi?id=40307

Use DataObjectGtk as the platformDragData for DragDataGtk. DataObjectGtk
contains all the information necessary to keep track of drops in progress.

  • platform/DragData.h: Use a DataObjectGtk* as the platform drag data.
  • platform/gtk/DragDataGtk.cpp: (WebCore::DragData::containsFiles): Retrieve information via platformDragData. (WebCore::DragData::asFilenames): Ditto. (WebCore::DragData::containsPlainText): Ditto. (WebCore::DragData::asPlainText): Ditto. (WebCore::DragData::createClipboard): Create the Clipboard with the platformDragData. (WebCore::DragData::containsCompatibleContent): Retrieve information via platformDragData. (WebCore::DragData::containsURL): Ditto. (WebCore::DragData::asURL): Ditto. (WebCore::DragData::asFragment): Ditto.
08:36 Changeset [62123] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-29 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Update baseline r62111.

  • platform/gtk/accessibility/name-from-label-expected.txt:
08:31 WebKit Team edited by tonyg@chromium.org
(diff)
08:22 Changeset [62122] by agl@chromium.org
  • 2 edits in trunk/WebCore

2010-06-29 Adam Langley <agl@chromium.org>

Build fix. Not reviewd.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint): The name of the Skia function changed between writing this patch and commiting it.
08:01 Changeset [62121] by agl@chromium.org
  • 8 edits in trunk

2010-06-29 Adam Langley <agl@chromium.org>

Reviewed by Kent Tamura.

[chromium] Support forced autohinting.

https://bugs.webkit.org/show_bug.cgi?id=40493

Freetype (the typical font rendering on Linux) includes an 'autohinter':
an algorithm for hinting glyph shapes without using the embedded hinting
bytecode in a font.

Some people prefer the autohinter's results, so we support forcing its
use.

This change also fixes a bug where two FontPlatformData structures would
compare equal, even if their rendering styles were different.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint): In order to compare FontPlatformData structures we need to make sure that they are initialised. (WebCore::FontPlatformData::operator==):
  • platform/graphics/chromium/FontRenderStyle.h: (WebCore::FontRenderStyle::FontRenderStyle): (WebCore::FontRenderStyle::operator==): This fixes the case where two FontPlatformData structures, differing only by rendering style, would compare equal.
07:42 Changeset [62120] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebCore

2010-06-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, Symbian build fix.

Add more directories to USERINCLUDE so that they get included
before the Symbian system headers.

This is a workaround to some toolchain problems; bug 31273 is used to
find a better solution.

No new tests as there is no new functionality.

  • WebCore.pro:
07:32 Changeset [62119] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-06-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix QtScript build after QScriptValuePrivate ctor changes
https://bugs.webkit.org/show_bug.cgi?id=41307

  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::prototype):
  • qt/benchmarks/qscriptengine/qscriptengine.pro:
07:26 Changeset [62118] by zimmermann@webkit.org
  • 34 edits in trunk/WebCore

2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Cleanup SVGRenderSupport
https://bugs.webkit.org/show_bug.cgi?id=41347

Remove SVGRenderBase base class from all SVG renderers. It was meant as temporary solution until all SVG renderers inherit from RenderSVGModelObject,
though this is not going to happen. RenderSVGModelObject inherits from RenderObject, making it impossible to inherit eg. RenderSVGImage from it, as
it already indirectly inherits from RenderObject, through RenderImage. Other examples are RenderForeignObject (RenderBlock inheritance),
RenderSVGInlineText (RenderText inheritance) etc.

Rename SVGRenderBase to SVGRenderSupport, just like the file is named, remove all free functions, and make them all static functions in SVGRenderSupport.
We can still share code between all SVG renderers, but don't need a special base class for all renderers -> shrink size of all SVG renderers.

Doesn't affect any test.

  • rendering/RenderBox.cpp: Remove localTransform() override, not needed at all.
  • rendering/RenderBox.h: Ditto.
  • rendering/RenderForeignObject.cpp: s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderForeignObject::paint): (WebCore::RenderForeignObject::clippedOverflowRectForRepaint): (WebCore::RenderForeignObject::computeRectForRepaint): (WebCore::RenderForeignObject::nodeAtFloatPoint): (WebCore::RenderForeignObject::mapLocalToContainer):
  • rendering/RenderPath.cpp: (WebCore::BoundingRectStrokeStyleApplier::strokeStyle): applyStrokeStyleToContext is a static function in SVGRenderSupport now. (WebCore::RenderPath::paint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderPath::nodeAtFloatPoint): Ditto. (WebCore::RenderPath::updateCachedBoundaries): Ditto.
  • rendering/RenderSVGBlock.h: Remove SVGRenderBase inheritance.
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): layoutChildren is a static function in SVGRenderSupport now. (WebCore::RenderSVGContainer::paint): prepareToRenderSVGContent/finishRenderSVGContent are now static functions in SVGRenderSupport. (WebCore::RenderSVGContainer::objectBoundingBox): computeContainerBoundingBox is a static function in SVGRenderSupport now. (WebCore::RenderSVGContainer::strokeBoundingBox): Ditto. (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates): Remove call to computeContainerBoundingBox, use strokeBoundingBox instead, for consistency. (WebCore::RenderSVGContainer::nodeAtFloatPoint): pointInClippingArea is a static function in SVGRenderSupport now.
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::layout): layoutChildren is a static function in SVGRenderSupport now.
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): prepareToRenderSVGContent/finishRenderSVGContent are static functions in SVGRenderSupport now. (WebCore::RenderSVGImage::destroy): deregisterResource was renamed to invalidateAllResourcesOfRenderer and is a static function in SVGRenderSupport. (WebCore::RenderSVGImage::nodeAtFloatPoint): pointInClippingArea is a static function in SVGRenderSupport now. (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): intersectRepaintRectWithResources is a static function in SVGRenderSupport now. (WebCore::RenderSVGImage::clippedOverflowRectForRepaint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderSVGImage::computeRectForRepaint): Ditto. (WebCore::RenderSVGImage::mapLocalToContainer): Ditto.
  • rendering/RenderSVGImage.h: Remove SVGRenderBase inheritance.
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::objectBoundingBox): findTextRootObject is a static function in SVGRenderSupport now. (WebCore::RenderSVGInline::strokeBoundingBox): Ditto. (WebCore::RenderSVGInline::repaintRectInLocalCoordinates): Ditto. (WebCore::RenderSVGInline::clippedOverflowRectForRepaint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderSVGInline::computeRectForRepaint): Ditto,. (WebCore::RenderSVGInline::mapLocalToContainer): Ditto. (WebCore::RenderSVGInline::absoluteQuads): findTextRootObject is a static function in SVGRenderSupport now.
  • rendering/RenderSVGInline.h: Remove SVGRenderBase inheritance.
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderSVGModelObject::computeRectForRepaint): Ditto. (WebCore::RenderSVGModelObject::mapLocalToContainer): Ditto. (WebCore::RenderSVGModelObject::destroy): deregisterResource was renamed to invalidateAllResourcesOfRenderer and is a static function in SVGRenderSupport.
  • rendering/RenderSVGModelObject.h: Remove SVGRenderBase inheritance.
  • rendering/RenderSVGResource.cpp: (WebCore::invalidatePaintingResource): Moved here from SVGRenderSupport (static inline helper function). (WebCore::RenderSVGResource::invalidateAllResourcesOfRenderer): Moved here from SVGRenderSupport and renamed from deregisterFromResources.
  • rendering/RenderSVGResource.h: Expose invalidateAllResourcesOfRenderer function.
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::createClipData): renderSubtreeToImage is a static function in SVGRenderSupport now. (WebCore::RenderSVGResourceClipper::hitTestClipContent): Ditto.
  • rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): findTextRootObject is a static function in SVGRenderSupport now. (WebCore::clipToTextMask): Ditto. (WebCore::RenderSVGResourceGradient::applyResource): applyStrokeStyleToContext is a static function in SVGRenderSupport now. (WebCore::RenderSVGResourceGradient::postApplyResource): findTextRootObject is a static function in SVGRenderSupport now.
  • rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::applyViewportClip): s/SVGRenderBase/SVGRenderSupport/
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::createMaskImage): renderSubtreeToImage is a static function in SVGRenderSupport now.
  • rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): applyStrokeStyleToContext is a static function in SVGRenderSupport now. (WebCore::clampImageBufferSizeToViewport): Moved here from SVGRenderSupport. (WebCore::RenderSVGResourcePattern::createTileImage): renderSubtreeToImage is a static function in SVGRenderSupport now.
  • rendering/RenderSVGResourceSolidColor.cpp: (WebCore::RenderSVGResourceSolidColor::applyResource): applyStrokeStyleToContext is a static function in SVGRenderSupport now
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): layoutChildren is a static function in SVGRenderSupport now. (WebCore::RenderSVGRoot::paint): prepareToRenderSVGContent/finishRenderSVGContent are now static functions in SVGRenderSupport. (WebCore::RenderSVGRoot::destroy): deregisterResource was renamed to invalidateAllResourcesOfRenderer and is a static function in SVGRenderSupport. (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates): Remove call to computeContainerBoundingBox, use strokeBoundingBox instead, for consistency.
  • rendering/RenderSVGRoot.h: Remove localTransform() override, no longer needed. Remove SVGRenderBase inheritance. (WebCore::RenderSVGRoot::objectBoundingBox): Inlined for speeed. (WebCore::RenderSVGRoot::strokeBoundingBox): computeContainerBoundingBox is a static function in SVGRenderSupport now.
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::clippedOverflowRectForRepaint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderSVGText::computeRectForRepaint): Ditto. (WebCore::RenderSVGText::mapLocalToContainer): Ditto. (WebCore::RenderSVGText::nodeAtFloatPoint): pointInClippingArea is a static function in SVGRenderSupport now. (WebCore::RenderSVGText::destroy): deregisterResource was renamed to invalidateAllResourcesOfRenderer and is a static function in SVGRenderSupport. (WebCore::RenderSVGText::repaintRectInLocalCoordinates): intersectRepaintRectWithResources is a static function in SVGRenderSupport now.
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::applyViewportClip): s/SVGRenderBase/SVGRenderSupport/ (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): pointInClippingArea is a static function in SVGRenderSupport now.
  • rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint): prepareToRenderSVGContent/finishRenderSVGContent are now static functions in SVGRenderSupport.
  • rendering/SVGRenderSupport.cpp: Make it impossible to construct the class. Remove virtual destructor, made all methods static. (WebCore::SVGRenderSupport::clippedOverflowRectForRepaint): s/SVGRenderBase/SVGRenderSupport/ (WebCore::SVGRenderSupport::computeRectForRepaint): Ditto. (WebCore::SVGRenderSupport::mapLocalToContainer): Ditto. (WebCore::SVGRenderSupport::prepareToRenderSVGContent): Ditto. (WebCore::SVGRenderSupport::finishRenderSVGContent): Ditto. (WebCore::SVGRenderSupport::renderSubtreeToImage): Made static. (WebCore::SVGRenderSupport::computeContainerBoundingBox): Ditto. (WebCore::SVGRenderSupport::layoutChildren): Ditto. (WebCore::SVGRenderSupport::isOverflowHidden): s/SVGRenderBase/SVGRenderSupport/ (WebCore::SVGRenderSupport::intersectRepaintRectWithResources): Ditto. (WebCore::SVGRenderSupport::pointInClippingArea): Made static. (WebCore::SVGRenderSupport::dashArrayFromRenderingStyle): Ditto. (WebCore::SVGRenderSupport::applyStrokeStyleToContext): Ditto. (WebCore::SVGRenderSupport::findTextRootObject): Ditto.
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): dashArrayFromRenderingStyle is a static function in SVGRenderSupport now.
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint): s/SVGRenderBase/SVGRenderSupport/
  • rendering/SVGRootInlineBox.h: Remove SVGRenderBase inheritance.
  • svg/SVGFEImageElement.cpp: Add RenderObject.h include, otherwhise it won't build anymore. (WebCore::SVGFEImageElement::build): renderSubtreeToImage is a static function in SVGRenderSupport now.
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged): deregisterResource was renamed to invalidateAllResourcesOfRenderer and is a static function in SVGRenderSupport.
07:26 Changeset [62117] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-29 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed test expectations update for stable passing tests.

  • platform/chromium/test_expectations.txt:
07:19 Changeset [62116] by diegohcg@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-29 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Resize scene when Qt DRT WebPage receives a geometry change request
https://bugs.webkit.org/show_bug.cgi?id=41173

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::setViewGeometry):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
07:03 Changeset [62115] by diegohcg@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-29 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Deal with postEvent in case of graphics based DRT
https://bugs.webkit.org/show_bug.cgi?id=41174

QGraphicsScene does not have a postEvent method, so make scene
send the event, in case of graphics based DRT, and delete it after that.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::scheduleAsynchronousClick): (EventSender::replaySavedEvents): (EventSender::postEvent):
  • DumpRenderTree/qt/EventSenderQt.h:
06:58 Changeset [62114] by philn@webkit.org
  • 2 edits in trunk/WebCore

2010-06-21 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[PNG decoder] direct access to jmpbuf is deprecated in libpng >= 1.4.0beta103
https://bugs.webkit.org/show_bug.cgi?id=40907

Define a JMPBUF macro to cope with deprecation of the jmpbuf
attribute in libpng >= 1.4.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::decodingFailed): (WebCore::PNGImageReader::decode): (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
06:51 Changeset [62113] by diegohcg@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-29 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
https://bugs.webkit.org/show_bug.cgi?id=41172

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::switchFocus):
06:28 Changeset [62112] by zimmermann@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add missing pixel test results.

  • platform/mac/fast/css/nested-rounded-corners-expected.checksum: Added.
  • platform/mac/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/mac/fast/js/missing-title-end-tag-js-expected.checksum: Added.
  • platform/mac/fast/js/missing-title-end-tag-js-expected.png: Added.
06:27 Changeset [62111] by commit-queue@webkit.org
  • 11 edits in trunk

2010-06-29 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Make DRT more coherent with other ports to allow reusing more tests
https://bugs.webkit.org/show_bug.cgi?id=40009

Update GTK a11y tests to follow new prefixes coming from DRT

  • platform/gtk/accessibility/object-attributes-expected.txt:
  • platform/gtk/accessibility/object-attributes.html:
  • platform/gtk/accessibility/object-with-title-expected.txt:
  • platform/gtk/accessibility/object-with-title.html:
  • platform/gtk/accessibility/table-hierarchy-expected.txt:
  • platform/gtk/accessibility/table-hierarchy.html:
  • platform/gtk/accessibility/title-and-alt-expected.txt:
  • platform/gtk/accessibility/title-and-alt.html:

2010-06-29 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Make DRT more coherent with other ports to allow reusing more tests
https://bugs.webkit.org/show_bug.cgi?id=40009

Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
are used when returning those values, for coherency with other ports.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description):
06:16 Changeset [62110] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62106.
http://trac.webkit.org/changeset/62106
https://bugs.webkit.org/show_bug.cgi?id=41346

"Broke editing tests" (Requested by xan_ on #webkit).

  • Scripts/old-run-webkit-tests:
06:08 Changeset [62109] by hausmann@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

[Qt/Symbian] Fixed deployment paths for WebKit declarative plugin.

Patch by Kristian Amlie <kristian.amlie@nokia.com> on 2010-06-29
Reviewed by Simon Hausmann.

  • WebCore.pro:
06:08 Changeset [62108] by hausmann@webkit.org
  • 1 edit in trunk/WebCore/WebCore.pro

Fixed deployment paths for WebKit declarative plugin.

Signed-off-by: Simon Hausmann <simon.hausmann@nokia.com>

05:49 Changeset [62107] by mnaganov@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-06-29 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed test expectations update.

  • platform/chromium-win/svg/css/text-shadow-multiple-expected.checksum: Added.
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png: Added.
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
05:39 Changeset [62106] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-29 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

Ensure DRT loads GAIL (Gtk+ module), for a11y tests
https://bugs.webkit.org/show_bug.cgi?id=38648

Add the GTK_MODULES envvar (set to "gail") to the clean
environment when running DRT for the Gtk+ port

  • Scripts/old-run-webkit-tests:
05:25 Changeset [62105] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-06-29 Yury Semikhatsky <yurys@chromium.org>

Unreviewed: Chromium Win and Mac build fix.

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
05:14 Changeset [62104] by zimmermann@webkit.org
  • 77 edits
    2 adds in trunk/WebCore

2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Move PaintInfo/PaintPhase into their own headers, out of RenderObject
https://bugs.webkit.org/show_bug.cgi?id=41342

1) Move enums PaintPhase/PaintBehaviorFlags and the PaintBehaviour typedef from RenderObject into PaintPhase.h.

Move PaintInfo from RenderObject into PaintInfo.h. Replace s/RenderObject::PaintInfo/PaintInfo/ throughout WebCore/.
Also move the OverlapTestRequestMap typedef into PaintInfo.h, and replace s/RenderObject::OverlapTestRequestMap/OverlapTestRequestMap/ everywhere.

2) Move "RenderObject* paintingRootForChildren(PaintInfo& paintInfo) const" from RenderObject to PaintInfo

and modify it to take a renderer: "void updatePaintingRootForChildren(const RenderObject* renderer)".

This changes a common idiom:

  • info.paintingRoot = paintingRootForChildren(paintInfo); + info.updatePaintingRootForChildren(this);

We save resetting the paintingRoot to 0 if it was 0 already and thus do less work.

3) Move "bool shouldPaintWithinRoot(PaintInfo& paintInfo) const" from RenderObject to PaintInfo

and modify it to take a renderer: "bool shouldPaintWithinRoot(const RenderObject* renderer) const".

This changes a common idiom:

  • if (!shouldPaintWithinRoot(paintInfo)) + if (!paintInfo.shouldPaintWithinRoot(this))

4) Move "void applyTransformToPaintInfo(RenderObject::PaintInfo&, const AffineTransform& localToChildTransform)"

from SVGRenderSupport to PaintInfo and rename it to "applyTransform", guarded with ENABLE(SVG) blocks.

This changes a common idiom:

  • applyTransformToPaintInfo(childPaintInfo, localToParentTransform()); + childPaintInfo.applyTransform(localToParentTransform());

Add PaintInfo.h / PaintPhase.h to all build systems that list headers.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/android/RenderThemeAndroid.cpp: (WebCore::getCanvasFromInfo): (WebCore::RenderThemeAndroid::paintCheckbox): (WebCore::RenderThemeAndroid::paintButton): (WebCore::RenderThemeAndroid::paintRadio): (WebCore::RenderThemeAndroid::paintTextField): (WebCore::RenderThemeAndroid::paintTextArea): (WebCore::RenderThemeAndroid::paintSearchField): (WebCore::RenderThemeAndroid::paintCombo): (WebCore::RenderThemeAndroid::paintMenuList): (WebCore::RenderThemeAndroid::paintMenuListButton):
  • platform/android/RenderThemeAndroid.h:
  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart): (WebCore::RenderThemeEfl::paintCheckbox): (WebCore::RenderThemeEfl::paintRadio): (WebCore::RenderThemeEfl::paintButton): (WebCore::RenderThemeEfl::paintMenuList): (WebCore::RenderThemeEfl::paintTextField): (WebCore::RenderThemeEfl::paintTextArea): (WebCore::RenderThemeEfl::paintSearchFieldDecoration): (WebCore::RenderThemeEfl::paintSearchFieldResultsButton): (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration): (WebCore::RenderThemeEfl::paintSearchFieldCancelButton): (WebCore::RenderThemeEfl::paintSearchField):
  • platform/efl/RenderThemeEfl.h:
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget): (WebCore::RenderThemeGtk::paintCheckbox): (WebCore::RenderThemeGtk::paintRadio): (WebCore::RenderThemeGtk::paintButton): (WebCore::RenderThemeGtk::paintMenuList): (WebCore::RenderThemeGtk::paintTextField): (WebCore::RenderThemeGtk::paintTextArea): (WebCore::RenderThemeGtk::paintSearchFieldResultsButton): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintSearchField): (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::paintMediaFullscreenButton): (WebCore::RenderThemeGtk::paintMediaMuteButton): (WebCore::RenderThemeGtk::paintMediaPlayButton): (WebCore::RenderThemeGtk::paintMediaSeekBackButton): (WebCore::RenderThemeGtk::paintMediaSeekForwardButton): (WebCore::RenderThemeGtk::paintMediaSliderTrack): (WebCore::RenderThemeGtk::paintMediaSliderThumb): (WebCore::RenderThemeGtk::paintProgressBar):
  • platform/gtk/RenderThemeGtk.h:
  • platform/haiku/RenderThemeHaiku.cpp: (WebCore::RenderThemeHaiku::paintCheckbox): (WebCore::RenderThemeHaiku::paintRadio): (WebCore::RenderThemeHaiku::paintMenuList):
  • platform/haiku/RenderThemeHaiku.h:
  • platform/qt/RenderThemeQt.cpp: (WebCore::StylePainter::StylePainter): (WebCore::RenderThemeQt::paintCheckbox): (WebCore::RenderThemeQt::paintRadio): (WebCore::RenderThemeQt::paintButton): (WebCore::RenderThemeQt::paintTextField): (WebCore::RenderThemeQt::paintTextArea): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): (WebCore::RenderThemeQt::paintProgressBar): (WebCore::RenderThemeQt::paintSliderTrack): (WebCore::RenderThemeQt::paintSliderThumb): (WebCore::RenderThemeQt::paintSearchField): (WebCore::RenderThemeQt::paintSearchFieldCancelButton): (WebCore::RenderThemeQt::paintSearchFieldDecoration): (WebCore::RenderThemeQt::paintSearchFieldResultsDecoration): (WebCore::RenderThemeQt::paintMediaFullscreenButton): (WebCore::RenderThemeQt::paintMediaMuteButton): (WebCore::RenderThemeQt::paintMediaPlayButton): (WebCore::RenderThemeQt::paintMediaSeekBackButton): (WebCore::RenderThemeQt::paintMediaSeekForwardButton): (WebCore::RenderThemeQt::paintMediaCurrentTime): (WebCore::RenderThemeQt::paintMediaVolumeSliderTrack): (WebCore::RenderThemeQt::paintMediaVolumeSliderThumb): (WebCore::RenderThemeQt::paintMediaSliderTrack): (WebCore::RenderThemeQt::paintMediaSliderThumb):
  • platform/qt/RenderThemeQt.h:
  • platform/wx/RenderThemeWx.cpp: (WebCore::RenderThemeWx::paintCheckbox): (WebCore::RenderThemeWx::paintRadio): (WebCore::RenderThemeWx::paintButton): (WebCore::RenderThemeWx::paintTextField): (WebCore::RenderThemeWx::paintMenuList): (WebCore::RenderThemeWx::paintMenuListButton):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::paint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask): (WebCore::InlineFlowBox::paintTextDecorations):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/InlineTextBox.h:
  • rendering/PaintInfo.h: Added. (WebCore::PaintInfo::PaintInfo): (WebCore::PaintInfo::updatePaintingRootForChildren): (WebCore::PaintInfo::shouldPaintWithinRoot): (WebCore::PaintInfo::applyTransform):
  • rendering/PaintPhase.h: Added. (WebCore::):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintEllipsisBoxes): (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::layoutColumns):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paint): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintMask):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): (WebCore::performOverlapTests): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::paintList): (WebCore::RenderLayer::paintPaginatedChildLayer): (WebCore::RenderLayer::paintChildLayerIntoColumns):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
  • rendering/RenderLineBoxList.h:
  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):
  • rendering/RenderMediaControls.h:
  • rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaMuteButton): (WebCore::paintMediaPlayButton): (WebCore::paintMediaSlider): (WebCore::paintMediaSliderThumb): (WebCore::paintMediaVolumeSlider): (WebCore::paintMediaVolumeSliderThumb): (WebCore::paintMediaTimelineContainer): (WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
  • rendering/RenderMediaControlsChromium.h:
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::draw):
  • rendering/RenderSVGResourceMarker.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::paintMeter):
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintCapsLockIndicator): (WebCore::RenderTheme::paintCheckbox): (WebCore::RenderTheme::paintRadio): (WebCore::RenderTheme::paintButton): (WebCore::RenderTheme::paintInnerSpinButton): (WebCore::RenderTheme::paintOuterSpinButton): (WebCore::RenderTheme::paintTextField): (WebCore::RenderTheme::paintTextArea): (WebCore::RenderTheme::paintMenuList): (WebCore::RenderTheme::paintMenuListButton): (WebCore::RenderTheme::paintProgressBar): (WebCore::RenderTheme::paintSliderTrack): (WebCore::RenderTheme::paintSliderThumb): (WebCore::RenderTheme::paintSearchField): (WebCore::RenderTheme::paintSearchFieldCancelButton): (WebCore::RenderTheme::paintSearchFieldDecoration): (WebCore::RenderTheme::paintSearchFieldResultsDecoration): (WebCore::RenderTheme::paintSearchFieldResultsButton): (WebCore::RenderTheme::paintMediaFullscreenButton): (WebCore::RenderTheme::paintMediaPlayButton): (WebCore::RenderTheme::paintMediaMuteButton): (WebCore::RenderTheme::paintMediaSeekBackButton): (WebCore::RenderTheme::paintMediaSeekForwardButton): (WebCore::RenderTheme::paintMediaSliderTrack): (WebCore::RenderTheme::paintMediaSliderThumb): (WebCore::RenderTheme::paintMediaVolumeSliderContainer): (WebCore::RenderTheme::paintMediaVolumeSliderTrack): (WebCore::RenderTheme::paintMediaVolumeSliderThumb): (WebCore::RenderTheme::paintMediaRewindButton): (WebCore::RenderTheme::paintMediaReturnToRealtimeButton): (WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton): (WebCore::RenderTheme::paintMediaControlsBackground): (WebCore::RenderTheme::paintMediaCurrentTime): (WebCore::RenderTheme::paintMediaTimeRemaining):
  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintMediaPlayButton): (WebCore::RenderThemeChromiumMac::paintMediaMuteButton): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintCheckbox): (WebCore::RenderThemeChromiumSkia::paintRadio): (WebCore::paintButtonLike): (WebCore::RenderThemeChromiumSkia::paintButton): (WebCore::RenderThemeChromiumSkia::paintTextField): (WebCore::RenderThemeChromiumSkia::paintTextArea): (WebCore::RenderThemeChromiumSkia::paintSearchField): (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): (WebCore::RenderThemeChromiumSkia::paintMediaControlsBackground): (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack): (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderTrack): (WebCore::RenderThemeChromiumSkia::paintMediaSliderThumb): (WebCore::RenderThemeChromiumSkia::paintMediaVolumeSliderThumb): (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton): (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton): (WebCore::RenderThemeChromiumSkia::paintMenuList): (WebCore::RenderThemeChromiumSkia::paintMenuListButton): (WebCore::RenderThemeChromiumSkia::paintSliderTrack): (WebCore::RenderThemeChromiumSkia::paintSliderThumb): (WebCore::RenderThemeChromiumSkia::paintProgressBar):
  • rendering/RenderThemeChromiumSkia.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintCheckbox): (WebCore::RenderThemeChromiumWin::paintRadio): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintTextField): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::RenderThemeChromiumWin::paintSliderThumb): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintProgressBar):
  • rendering/RenderThemeChromiumWin.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintCapsLockIndicator): (WebCore::RenderThemeMac::paintTextArea): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintMeter): (WebCore::RenderThemeMac::paintProgressBar): (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): (WebCore::getUnzoomedRectAndAdjustCurrentContext): (WebCore::RenderThemeMac::paintMediaFullscreenButton): (WebCore::RenderThemeMac::paintMediaMuteButton): (WebCore::RenderThemeMac::paintMediaPlayButton): (WebCore::RenderThemeMac::paintMediaSeekBackButton): (WebCore::RenderThemeMac::paintMediaSeekForwardButton): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaSliderThumb): (WebCore::RenderThemeMac::paintMediaRewindButton): (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton): (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton): (WebCore::RenderThemeMac::paintMediaControlsBackground): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintCheckbox): (WebCore::RenderThemeSafari::paintRadio): (WebCore::RenderThemeSafari::paintButton): (WebCore::RenderThemeSafari::paintTextField): (WebCore::RenderThemeSafari::paintCapsLockIndicator): (WebCore::RenderThemeSafari::paintTextArea): (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintMenuListButton): (WebCore::RenderThemeSafari::paintSliderTrack): (WebCore::RenderThemeSafari::paintSliderThumb): (WebCore::RenderThemeSafari::paintSearchField): (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): (WebCore::RenderThemeSafari::paintSearchFieldDecoration): (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): (WebCore::RenderThemeSafari::paintSearchFieldResultsButton): (WebCore::RenderThemeSafari::paintMediaFullscreenButton): (WebCore::RenderThemeSafari::paintMediaMuteButton): (WebCore::RenderThemeSafari::paintMediaPlayButton): (WebCore::RenderThemeSafari::paintMediaSeekBackButton): (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): (WebCore::RenderThemeSafari::paintMediaSliderTrack): (WebCore::RenderThemeSafari::paintMediaSliderThumb):
  • rendering/RenderThemeSafari.h:
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::paintMenuListButton): (WebCore::RenderThemeWin::paintSliderTrack): (WebCore::RenderThemeWin::paintSliderThumb): (WebCore::RenderThemeWin::paintSearchField): (WebCore::RenderThemeWin::paintSearchFieldCancelButton): (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): (WebCore::RenderThemeWin::paintSearchFieldResultsButton): (WebCore::RenderThemeWin::paintMediaFullscreenButton): (WebCore::RenderThemeWin::paintMediaMuteButton): (WebCore::RenderThemeWin::paintMediaPlayButton): (WebCore::RenderThemeWin::paintMediaSeekBackButton): (WebCore::RenderThemeWin::paintMediaSeekForwardButton): (WebCore::RenderThemeWin::paintMediaSliderTrack): (WebCore::RenderThemeWin::paintMediaSliderThumb): (WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
  • rendering/RenderThemeWin.h: (WebCore::RenderThemeWin::paintCheckbox): (WebCore::RenderThemeWin::paintRadio): (WebCore::RenderThemeWin::paintTextArea): (WebCore::RenderThemeWin::paintSearchFieldDecoration):
  • rendering/RenderThemeWince.cpp: (WebCore::RenderThemeWince::paintButton): (WebCore::RenderThemeWince::paintTextField): (WebCore::RenderThemeWince::paintMenuList): (WebCore::RenderThemeWince::paintMenuListButton): (WebCore::RenderThemeWince::paintSearchField): (WebCore::RenderThemeWince::paintSearchFieldCancelButton): (WebCore::RenderThemeWince::paintSearchFieldResultsDecoration): (WebCore::RenderThemeWince::paintSearchFieldResultsButton): (WebCore::RenderThemeWince::paintSliderTrack): (WebCore::RenderThemeWince::paintSliderThumb): (WebCore::RenderThemeWince::paintMediaFullscreenButton): (WebCore::RenderThemeWince::paintMediaMuteButton): (WebCore::RenderThemeWince::paintMediaPlayButton): (WebCore::RenderThemeWince::paintMediaSeekBackButton): (WebCore::RenderThemeWince::paintMediaSeekForwardButton): (WebCore::RenderThemeWince::paintMediaSliderTrack): (WebCore::RenderThemeWince::paintMediaSliderThumb):
  • rendering/RenderThemeWince.h: (WebCore::RenderThemeWince::paintCheckbox): (WebCore::RenderThemeWince::paintRadio): (WebCore::RenderThemeWince::paintTextArea): (WebCore::RenderThemeWince::paintSearchFieldDecoration):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintEllipsisBox): (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint): (WebCore::RootInlineBox::fillLineSelectionGap):
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint):
  • rendering/SVGInlineFlowBox.h:
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paint):
  • rendering/SVGInlineTextBox.h:
  • rendering/SVGMarkerLayoutInfo.cpp: (WebCore::SVGMarkerLayoutInfo::drawMarkers):
  • rendering/SVGMarkerLayoutInfo.h:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::renderSubtreeToImage):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
  • rendering/SVGRootInlineBox.h:
03:37 Changeset [62103] by mnaganov@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2010-06-29 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed test expectations update.

  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.checksum: Added.
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.png: Added.
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
03:36 Changeset [62102] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Sort Xcode project file.

  • WebCore.xcodeproj/project.pbxproj:
02:45 Changeset [62101] by mnaganov@chromium.org
  • 3 edits
    2 adds
    2 deletes in trunk/LayoutTests

2010-06-29 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed test expectations update.

  • platform/chromium-mac/fast/forms/select-empty-option-height.checksum: Added.
  • platform/chromium-mac/fast/forms/select-empty-option-height.png: Added.
  • platform/chromium-mac/html5lib/webkit-runner-expected.txt: Removed.
  • platform/chromium-win/html5lib/webkit-runner-expected.txt: Removed.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/test_expectations.txt:
02:23 Changeset [62100] by zimmermann@webkit.org
  • 4 edits in trunk/WebCore

2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Provide floating-point support for text selection framework
https://bugs.webkit.org/show_bug.cgi?id=40665

Rename 'glyphScale' to 'horizontalGlyphStretch' upon Dans' request.
Also guard the variables in ENABLE(SVG) blocks. Initialize variable to 1 instead of 1.0f, as that's the new style rule.

No functional changes, thus no new tests.

  • platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::horizontalGlyphStretch): (WebCore::TextRun::setHorizontalGlyphStretch): (WebCore::TextRun::spacingDisabled):
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advance):
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::offsetForPosition):
02:16 Changeset [62099] by zimmermann@webkit.org
  • 6 edits
    4 adds in trunk

2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: text-shadow CSS applied to SVG no longer works
https://bugs.webkit.org/show_bug.cgi?id=40960

Readd text-shadow support, this time supporting multiple shadows.
It's not exactly like HTML, because SVG draws fill/stroke phases seperated - the png shows the difference.

Tests: svg/css/text-shadow-multiple.xhtml

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::applyShadowToGraphicsContext): Refactored from paintTextWithShadows(), so SVG can reuse. (WebCore::paintTextWithShadows): Use refactored applyShadowToGraphicsContext() function.
  • rendering/InlineTextBox.h:
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintTextWithShadows): Added. (WebCore::SVGInlineTextBox::paintText): Call paintTextWithShadows() instead of directly drawing the text.
  • rendering/SVGInlineTextBox.h:

2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: text-shadow CSS applied to SVG no longer works
https://bugs.webkit.org/show_bug.cgi?id=40960

Add testcase covering multiple text-shadow applied to SVG, in comparision with HTML.

  • platform/mac/svg/css/text-shadow-multiple-expected.checksum: Added.
  • platform/mac/svg/css/text-shadow-multiple-expected.png: Added.
  • platform/mac/svg/css/text-shadow-multiple-expected.txt: Added.
  • svg/css/text-shadow-multiple.xhtml: Added.
02:04 Changeset [62098] by zimmermann@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-29 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update mac-lepard specific result for a SVG test using border-radii, after the painting changes.

  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
01:56 Changeset [62097] by ossy@webkit.org
  • 8 edits in trunk/LayoutTests

Unreviewed trivial fix. Update platform specific expectded files after r62092.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
01:33 Changeset [62096] by ossy@webkit.org
  • 6 edits in trunk/LayoutTests

Unreviewed trivial fix. Update expectded files after r62092.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
01:22 Rebaseline edited by morrita@google.com
(diff)
00:43 Changeset [62095] by yurys@chromium.org
  • 19 edits in trunk

2010-06-29 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: show actual breakpoint position in UI.
When user sets breakpoint from UI, javascript engine may actually set
it on a different line. If so, move breakpoint to the correct position
in frontend.
https://bugs.webkit.org/show_bug.cgi?id=40781

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::dispatchDidPause):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::currentCallFrame):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::setBreakpoint):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didSetBreakpoint):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setOneTimeBreakpoint): (WebInspector.BreakpointManager.prototype.removeOneTimeBreakpoint): (WebInspector.BreakpointManager.prototype.setBreakpoint): (WebInspector.BreakpointManager.prototype.restoredBreakpoint): (WebInspector.BreakpointManager.prototype.removeBreakpoint): (WebInspector.BreakpointManager.prototype._setBreakpoint): (WebInspector.BreakpointManager.prototype._removeBreakpoint): (WebInspector.BreakpointManager.prototype._setBreakpointOnBackend.didSetBreakpoint): (WebInspector.BreakpointManager.prototype._setBreakpointOnBackend): (WebInspector.Breakpoint.prototype.set enabled): (WebInspector.Breakpoint.prototype.set condition):
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.setBreakpoint):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype._addBreakpoint):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._addBreakpoint):

2010-06-29 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: return line number where breakpoint was actually set by v8 from setBreakpoint function.
https://bugs.webkit.org/show_bug.cgi?id=40781

  • src/js/DebuggerScript.js: ():
00:39 Changeset [62094] by dumi@chromium.org
  • 11 edits in trunk

WebCore: Catch toString() exceptions in all DB-related code.
https://bugs.webkit.org/show_bug.cgi?id=41297

Reviewed by Adam Barth.

  • bindings/v8/custom/V8BindingMacros.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

  • bindings/v8/custom/V8DatabaseCustom.cpp:

(WebCore::V8Database::changeVersionCallback):

  • bindings/v8/custom/V8DatabaseSyncCustom.cpp:

(WebCore::V8DatabaseSync::changeVersionCallback):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::openDatabaseCallback):
(WebCore::V8WorkerContext::openDatabaseSyncCallback):

LayoutTests: Remove a Chromium-specific expectations file.
https://bugs.webkit.org/show_bug.cgi?id=41297

Reviewed by Adam Barth.

  • platform/chromium/storage/sql-error-codes-expected.txt:
  • storage/sql-error-codes.js:

(testBindParameterOfWrongType):

00:26 Changeset [62093] by zherczeg@webkit.org
  • 2 edits in trunk/WebCore

Windows build fix.
https://bugs.webkit.org/show_bug.cgi?id=5861

Rubber-stamped by Nikolas Zimmermann.

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::build):

00:05 Changeset [62092] by zherczeg@webkit.org
  • 28 edits
    3 adds in trunk

WebCore: Add ConvolveMatrix SVG filter effect
https://bugs.webkit.org/show_bug.cgi?id=5861

Reviewed by Nikolas Zimmermann.

The patch was originally started by Dirk Schulze,
and the .cpp and .h files are mostly his work.
I updated the build systems and do some minor updates
to the source files as well. The patch does not contain
the implementation of the filter: this is intended,
and will be landed in a follow-up patch.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:

(WebCore::createElementClassMap):

  • bindings/objc/DOMSVG.h:
  • page/DOMWindow.idl:
  • svg/SVGAllInOne.cpp:
  • svg/SVGFEConvolveMatrixElement.cpp: Added.

(WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement):
(WebCore::SVGFEConvolveMatrixElement::~SVGFEConvolveMatrixElement):
(WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute):
(WebCore::SVGFEConvolveMatrixElement::setOrder):
(WebCore::SVGFEConvolveMatrixElement::setKernelUnitLength):
(WebCore::SVGFEConvolveMatrixElement::build):

  • svg/SVGFEConvolveMatrixElement.h: Added.
  • svg/SVGFEConvolveMatrixElement.idl: Added.
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::FEConvolveMatrix):
(WebCore::FEConvolveMatrix::create):
(WebCore::FEConvolveMatrix::kernelSize):
(WebCore::FEConvolveMatrix::setKernelSize):
(WebCore::FEConvolveMatrix::targetOffset):
(WebCore::FEConvolveMatrix::setTargetOffset):
(WebCore::operator<<):
(WebCore::FEConvolveMatrix::externalRepresentation):

  • svg/graphics/filters/SVGFEConvolveMatrix.h:

(WebCore::):

  • svg/svgattrs.in:
  • svg/svgtags.in:

WebKit/mac: Add ConvolveMatrixElement to MigrateHeaders.make
https://bugs.webkit.org/show_bug.cgi?id=5861

Reviewed by Nikolas Zimmermann.

  • MigrateHeaders.make:

LayoutTests: Updating expected values for convolve matrix filter
https://bugs.webkit.org/show_bug.cgi?id=5861

Reviewed by Nikolas Zimmermann.

  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/custom/global-constructors-expected.txt:
  • svg/custom/js-svg-constructors-expected.txt:
  • svg/custom/js-svg-constructors.svg:

06/28/10:

23:55 Changeset [62091] by abarth@webkit.org
  • 4 edits
    3 deletes in trunk

2010-06-28 Adam Barth <abarth@webkit.org>

Unreviewed.

Removed webkit-runner.html now that the HTML5 tree builder can handle
the real version of the test suite. Good times.

  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-runner-expected-html5.txt: Removed.
  • html5lib/webkit-runner-expected.txt: Removed.
  • html5lib/webkit-runner.html: Removed.

2010-06-28 Adam Barth <abarth@webkit.org>

Unreviewed.

Switch test-html5-parser back to using runner.html.

  • Scripts/test-html5-parser:
23:48 Changeset [62090] by abarth@webkit.org
  • 7 edits in trunk

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 tree builder shouldn't ASSERT on HTML5lib test suite
https://bugs.webkit.org/show_bug.cgi?id=41335

Sketch out the EndTag handling for InBodyMode.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::inScope): (WebCore::HTMLTreeBuilder::clearActiveFormatingElementsUpToLastMarker): (WebCore::HTMLTreeBuilder::generateImpliedEndTags):

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 tree builder shouldn't ASSERT on HTML5lib test suite
https://bugs.webkit.org/show_bug.cgi?id=41335

Enable the remainder of the test suite and update expectations.

  • html5lib/webkit-runner-expected-html5.txt:
  • html5lib/webkit-runner-expected.txt:
  • html5lib/webkit-runner.html:
23:43 Changeset [62089] by levin@chromium.org
  • 2 edits in trunk/WebCore
  • rendering/RenderObject.h: Add missing forward declaration.

Reviewed by NOBODY (chromium build fix).

23:12 Changeset [62088] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-28 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=41061
Make the test work on both Mac and Linux.

  • fast/events/popup-when-select-change.html:
22:46 Changeset [62087] by tkent@chromium.org
  • 7 edits
    4 deletes in trunk/LayoutTests

2010-06-28 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

A meter flip issue was resolved by Chromium r51096.

  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
  • platform/chromium/test_expectations.txt:
22:05 Changeset [62086] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-28 Adam Barth <abarth@webkit.org>

Unreviewed.

I accidently gave up my ref and tried to dereference a null pointer.
This code is keeping an extra ref that it doesn't need, but that fact
was somewhat hidden before.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::addChildCommon): (WebCore::ContainerNode::parserAddChild): (WebCore::ContainerNode::legacyParserAddChild):
  • dom/ContainerNode.h:
21:42 Changeset [62085] by levin@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

These baselines were added for other platforms in http://trac.webkit.org/changeset/62076
Most unfortunately, v8 reports errors on different line numbers than jsc, so chromium
needs a different baseline.

Reviewed by NOBODY (test expectations update for chromium).

  • platform/chromium-mac/html5lib/webkit-runner-expected.txt: Added.
  • platform/chromium-win/html5lib/webkit-runner-expected.txt: Added.
21:37 Changeset [62084] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-28 Adam Barth <abarth@webkit.org>

Unreviewed.

Refactor common code into addChildCommon
https://bugs.webkit.org/show_bug.cgi?id=41326

Eric asked that we share the common code between these codepaths.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::addChildCommon): (WebCore::ContainerNode::parserAddChild): (WebCore::ContainerNode::addChild):
  • dom/ContainerNode.h:
21:37 Changeset [62083] by levin@chromium.org
  • 5 edits
    54 adds in trunk/LayoutTests

Updated expectations due to tests whose results changed after http://trac.webkit.org/changeset/62035.
Looking at the various results, they appear fine.

Reviewed by NOBODY (test expectations update for WebKit change).

  • platform/chromium-mac/fast/borders/border-radius-constraints-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-radius-constraints-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png: Added.
  • platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png: Added.
  • platform/chromium-mac/fast/forms/basic-selects-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/basic-selects-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-clip-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-narrow-width-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-separator-painting-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.checksum:
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-mac/fast/forms/select-baseline-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-baseline-expected.png: Added.
  • platform/chromium-mac/fast/overflow/border-radius-clipping-expected.checksum: Added.
  • platform/chromium-mac/fast/overflow/border-radius-clipping-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
21:31 Changeset [62082] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement HTMLTreeBuilder::reconstructTheActiveFormattingElements
https://bugs.webkit.org/show_bug.cgi?id=41319

Restructure the code to not use in-band data, which is what
got us in trouble with a signed/unsigned mismatch before.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::indexOfFirstUnopenFormattingElement): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements):
  • html/HTMLTreeBuilder.h:
20:55 Changeset [62081] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-06-28 Daniel Bates <dbates@rim.com>

Unreviewed, attempt to fix Qt bots.

Attempt to fix the build after changeset 62079 <http://trac.webkit.org/changeset/62079>
(https://bugs.webkit.org/show_bug.cgi?id=41324).

Rename some more call sites that were missed in the initial landing.

  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::parseDtd):
20:33 Changeset [62080] by dbates@webkit.org
  • 3 edits in trunk/WebCore

2010-06-28 Daniel Bates <dbates@rim.com>

Unreviewed, build fix.

Change return type of method HTMLTreeBuilder::reconstructTheActiveFormattingElements()
from int to unsigned.

Attempt to fix the build after changeset 62077 <https://trac.webkit.org/changeset/62077>
(https://bugs.webkit.org/show_bug.cgi?id=41319).

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::indexOfLastOpenFormattingElementOrMarker): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements):
  • html/HTMLTreeBuilder.h:
20:25 Changeset [62079] by eric@webkit.org
  • 20 edits in trunk/WebCore

2010-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename ContainerNode::addChild to legacyParserAddChild to indicate its parser-only intended use
https://bugs.webkit.org/show_bug.cgi?id=41324

A bunch of places in the code were calling ContainerNode::addChild.
I don't think they actually want to be doing that, as it has special
form-related handling which is part of LegacyHTMLTreeBuilder.

No functional changes, thus no tests.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::legacyParserAddChild):
  • dom/ContainerNode.h:
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • dom/Node.cpp: (WebCore::Node::legacyParserAddChild):
  • dom/Node.h:
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::HTMLKeygenElement):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::legacyParserAddChild):
  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::legacyParserAddChild):
  • html/HTMLTableRowElement.h:
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::legacyParserAddChild):
  • html/HTMLTableSectionElement.h:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addText): (WebCore::HTMLViewSourceDocument::addLink):
20:04 Changeset [62078] by commit-queue@webkit.org
  • 6 edits in trunk/JavaScriptCore

2010-06-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QScriptEngine API should contain a newArray function
https://bugs.webkit.org/show_bug.cgi?id=39115

  • qt/api/qscriptengine.cpp: (QScriptEngine::newArray):
  • qt/api/qscriptengine.h:
  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::newArray):
  • qt/api/qscriptengine_p.h:
  • qt/tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::newArray):
19:52 Changeset [62077] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement HTMLTreeBuilder::reconstructTheActiveFormattingElements
https://bugs.webkit.org/show_bug.cgi?id=41319

This is basically a direct transcription of HTML5 TreeBuilder spec:

http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#list-of-active-formatting-elements

This code is covered by various tests in html5lib/runner which we
can't run yet due to other asserts. Adam and I are working on
getting rid of those ASSERTS so that this (and other code) will
be better tested shortly.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertFormatingElement): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::contains): (WebCore::HTMLTreeBuilder::FormatingElementEntry::FormatingElementEntry): (WebCore::HTMLTreeBuilder::FormatingElementEntry::): (WebCore::HTMLTreeBuilder::FormatingElementEntry::isMarker): (WebCore::HTMLTreeBuilder::FormatingElementEntry::element): (WebCore::HTMLTreeBuilder::FormatingElementEntry::replaceElement):
19:00 Changeset [62076] by abarth@webkit.org
  • 9 edits
    1 add in trunk

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix ASSERT so we can run more HTML5lib tests
https://bugs.webkit.org/show_bug.cgi?id=41325

Uncomment <title> tag that was triggering ASSERT.
Uncomment test groups that were triggering ASSERTs.
Update expected results to show how many more tests we have left to
fix. :)

  • html5lib/webkit-runner-expected-html5.txt:
  • html5lib/webkit-runner.html:

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix ASSERT so we can run more HTML5lib tests
https://bugs.webkit.org/show_bug.cgi?id=41325

We can't call Node::addChild because that function contains a bunch of
logic from the old parser. Instead, this patch creates a new version
of addChild that's does less validating (that's the tree builder's
job).

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::parserAddChild):
  • dom/ContainerNode.h:
  • dom/Node.cpp: (WebCore::Node::parserAddChild):
  • dom/Node.h:
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::attach):
18:36 Changeset [62075] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Versioning.

18:35 Changeset [62074] by mrowe@apple.com
  • 1 copy in tags/Safari-533.17

New tag.

18:13 Changeset [62073] by levin@chromium.org
  • 2 edits in trunk/WebCore
  • bindings/v8/ScriptEventListener.h: Changed forward declaration to correspond to the code change doing in r62052.

Reviewed by NOBODY (chromium build fix).

18:04 Changeset [62072] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.17-branch

Merge r61045.

18:04 Changeset [62071] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Merge r61750.

18:04 Changeset [62070] by mrowe@apple.com
  • 4 edits in branches/safari-533.17-branch

Merge r61450.

18:04 Changeset [62069] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.17-branch

Merge r60990.

17:52 Changeset [62068] by mrowe@apple.com
  • 1 edit
    6 adds in branches/safari-533.17-branch/LayoutTests

Merge r59146.

17:52 Changeset [62067] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r59143.

17:51 Changeset [62066] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/LayoutTests

Merge r59142.

17:51 Changeset [62065] by mrowe@apple.com
  • 3 edits in branches/safari-533.17-branch/LayoutTests

Merge r59141.

17:51 Changeset [62064] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r59140.

17:51 Changeset [62063] by mrowe@apple.com
  • 3 edits in branches/safari-533.17-branch/LayoutTests

Merge r59139.

17:51 Changeset [62062] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebKit/mac

Merge r59138.

17:51 Changeset [62061] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r59137.

17:51 Changeset [62060] by mrowe@apple.com
  • 16 edits
    3 copies
    4 adds
    1 delete in branches/safari-533.17-branch

Merge r59136.

17:51 Changeset [62059] by mrowe@apple.com
  • 4 edits in branches/safari-533.17-branch/WebCore

Merge r59134.

17:51 Changeset [62058] by mrowe@apple.com
  • 3 edits in branches/safari-533.17-branch/WebCore

Merge r59133.

17:51 Changeset [62057] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r59132.

17:51 Changeset [62056] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch/LayoutTests

Merge r59131.

17:50 Changeset [62055] by mrowe@apple.com
  • 1 edit
    1 copy
    1 move
    11 adds
    1 delete in branches/safari-533.17-branch/LayoutTests

Merge r59130.

17:50 Changeset [62054] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch/WebCore

Merge r59129.

17:47 Changeset [62053] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Install jsc as jsc-X where X is the major API version to allow
parallel installation of both GTK+ 2.x and 3.x versions.

  • GNUmakefile.am:
17:38 Changeset [62052] by beidson@apple.com
  • 8 edits in trunk/WebCore

Support for https://bugs.webkit.org/show_bug.cgi?id=40484

Reviewed by Alexey Proskuryakov.

In working on adding beforeProcess, it becomes necessary for JSLazyEventListeners to always know what their
original Node* was, even if it was a window event listener.

For HTMLFrameSet, HTMLBody, and SVGSVG elements, a second form of createAttributeEventListener was used that
took a Frame* argument and didn't set the original Node* on the JSLazyEventListener.

This patch changes that form of the function to createWindowAttributeEventListener, and passes the Node* along
for later use by the beforeProcess mechanism.

No new tests. (No change in behavior)

  • bindings/js/ScriptEventListener.cpp:

(WebCore::createWindowAttributeEventListener): Renamed from createAttributeEventListener, takes a Node* instead

of a Frame*, and figures out the Frame* itself internally.

  • bindings/js/ScriptEventListener.h:
  • bindings/v8/ScriptEventListener.cpp:

(WebCore::createWindowAttributeEventListener): Renamed from createAttributeEventListener, takes a Node* instead

of a Frame*, and figures out the Frame* itself internally. Note that V8LazyEventListener doesn't allow us to
pass the Element* argument in so this beforeprocess feature won't fully work on V8 builds until this is changed.

  • bindings/v8/ScriptEventListener.h:
  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::parseMappedAttribute): Use createWindowAttributeEventListener instead.

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseMappedAttribute): Ditto.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::parseMappedAttribute): Ditto. Also add some missing copyright dates that svn log proves

should be there.

17:23 Changeset [62051] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Restore webkit-runner.html for use with new tree builder
https://bugs.webkit.org/show_bug.cgi?id=41317

webkit-runner.html is very similar to runner.html, but it avoids some
tricky cases that are causing asserts. Using this simplified harness
will help us bring up the tree builder. We can remove it once we're up
to speed.

  • html5lib/webkit-runner-expected-html5.txt: Added.
  • html5lib/webkit-runner.html: Added.

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Restore webkit-runner.html for use with new tree builder
https://bugs.webkit.org/show_bug.cgi?id=41317

For now, we just want to run webkit-runner when we test-html5-parser.

  • Scripts/test-html5-parser:
17:02 Changeset [62050] by johnnyg@google.com
  • 2 edits in trunk/WebKit2

2010-06-28 John Gregg <johnnyg@google.com>

Unreviewed, build fix (removing merge conflict from previous).

  • Configurations/FeatureDefines.xcconfig:
16:53 Changeset [62049] by johnnyg@google.com
  • 19 edits in trunk

2010-06-28 John Gregg <johnnyg@google.com>

Reviewed by Kent Tamura.

add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100

  • Configurations/FeatureDefines.xcconfig:

2010-06-23 John Gregg <johnnyg@google.com>

Reviewed by Kent Tamura.

add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100

  • features.gypi:

2010-06-23 John Gregg <johnnyg@google.com>

Reviewed by Kent Tamura.

add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100

  • Configurations/FeatureDefines.xcconfig:

2010-06-23 John Gregg <johnnyg@google.com>

Reviewed by Kent Tamura.

add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-06-23 John Gregg <johnnyg@google.com>

Reviewed by Kent Tamura.

add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:

2010-06-28 John Gregg <johnnyg@google.com>

Reviewed by Kent Tamura.

add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100

  • configure.ac:

2010-06-23 John Gregg <johnnyg@google.com>

Reviewed by Kent Tamura.

add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100

  • Scripts/build-webkit:

2010-06-23 John Gregg <johnnyg@google.com>

Reviewed by Kent Tamura.

add ENABLE_DIRECTORY_UPLOAD build support
https://bugs.webkit.org/show_bug.cgi?id=41100

  • Configurations/FeatureDefines.xcconfig:
16:29 Changeset [62048] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-28 Gustavo Noronha Silva <gns@gnome.org>

Rubber-stamped by Xan Lopez.

Update webkitdirs's knowledge of our library's name.

  • Scripts/webkitdirs.pm:
16:11 Changeset [62047] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't use the new tree builder for fragments
https://bugs.webkit.org/show_bug.cgi?id=41316

We need to walk before we can run. After this change, we can run the
runner.html tests (with the ASSERT caveat).

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
15:59 Changeset [62046] by mrobinson@webkit.org
  • 6 edits in trunk/LayoutTests

2010-06-28 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Update baselines after r62034.

  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
15:56 Changeset [62045] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The new tree builder should actually finish building the tree
https://bugs.webkit.org/show_bug.cgi?id=41314

Again, this patch makes progress on runner.html, but I haven't removed
the ASSERT yet.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::finished):
  • html/HTMLTreeBuilder.h:
15:46 Changeset [62044] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-28 Xan Lopez <xlopez@igalia.com>

Revert to build jsc, since the tests expect this.

  • GNUmakefile.am:
15:36 Changeset [62043] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Fix a race condition that can happen when using DBs in workers.
https://bugs.webkit.org/show_bug.cgi?id=41105

Reviewed by Eric Seidel.

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):

  • storage/DatabaseTracker.h:
15:24 Changeset [62042] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add text nodes to the DOM
https://bugs.webkit.org/show_bug.cgi?id=41306

Actually add some text nodes to the DOM when parsing a document. We're
going to need to do something fancier here eventually, but this gets us
past the error we're seeing currently in runner.html.

Unfortunately, this patch "regresses" runner.html in the sense that we
now hit an assert, but it's still an improvement... I'll update the
HTML5 expectations once we get past the assert.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::insertTextNode):
  • html/HTMLTreeBuilder.h:
15:00 Changeset [62041] by mrowe@apple.com
  • 1 copy in branches/safari-533.17-branch

New branch.

14:56 Changeset [62040] by bdakin@apple.com
  • 2 edits in trunk/WebCore

Build fix for non-PATH_BASED_BORDER_RADIUS_DRAWING platforms.

  • rendering/RenderBoxModelObject.cpp:
14:50 Changeset [62039] by commit-queue@webkit.org
  • 10 edits
    1 delete in trunk/WebKit/chromium

2010-06-28 Zhe Su <suzhe@chromium.org>

Reviewed by Jian Li.

[chromium]Remove deprecated code related to input method.
https://bugs.webkit.org/show_bug.cgi?id=41244

Also update TestWebWidget in tests/PopupMenuTest.cpp to add missing implementations.

  • WebKit.gyp:
  • public/WebCompositionCommand.h: Removed.
  • public/WebViewClient.h:
  • public/WebWidget.h:
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::setInputMethodState):
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
  • tests/PopupMenuTest.cpp: (WebKit::TestWebWidget::setComposition): (WebKit::TestWebWidget::confirmComposition): (WebKit::TestWebWidget::textInputType): (WebKit::TestWebWidget::caretOrSelectionBounds):
14:39 Changeset [62038] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-06-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed Symbian build fix.

[Qt] Update the def file after r61879.

  • symbian/eabi/QtWebKitu.def:
14:24 Changeset [62037] by commit-queue@webkit.org
  • 4 edits in trunk

2010-06-28 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Use HTML5-conformant gradient interpolation mode
https://bugs.webkit.org/show_bug.cgi?id=41298

Unskip now working test:

  • canvas/philip/tests/2d.gradient.interpolate.colouralpha.html

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#colors-and-styles

  • platform/qt/Skipped:

2010-06-28 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Use HTML5-conformant gradient interpolation mode
https://bugs.webkit.org/show_bug.cgi?id=41298

Change the Qt Gradient implementation to use ComponentInterpolation mode.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#colors-and-styles

  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
14:07 Changeset [62036] by jam@chromium.org
  • 6 edits in trunk/WebKit/chromium

2010-06-27 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Get the selected text from plugins for right click menu
https://bugs.webkit.org/show_bug.cgi?id=41242

  • public/WebContextMenuData.h: (WebKit::WebContextMenuData::):
  • public/WebPlugin.h: (WebKit::WebPlugin::selectedText):
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::selectedText):
  • src/WebPluginContainerImpl.h:
13:53 Changeset [62035] by bdakin@apple.com
  • 32 edits in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=9197 CSS3: Borders
with border-radius and double, groove, or ridge styles should look
better

Reviewed by Sam Weinig.

This patch re-works border radius painting to stroke paths instead
of arcs.

Added new function clipConvexPolygon(). Added static
addConvexPolygonToContext so that code can be shared between
drawConvexPolygon() and clipConvexPolygon().

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::addConvexPolygonToContext):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):

Shells of implementations on non-CG platforms.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

This new helper function determines if the inner corners of the
border will arch in or meet at a right angle.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::borderWillArcInnerEdge):

This function is re-written so that, for each side of the border,
if borderWillArcInnerEdge() is true, we go down a brand new code
path of clipping to a convex polygon for the border side and then
we paint the side using the new function drawBoxSideFromPath(). If
borderWillArcInnerEdge() is false, then we call into the old
familiar drawLineForBoxSide() which relies on the rounder clip
rects we have set up to arch the outer edge of the border.
(WebCore::RenderBoxModelObject::paintBorder):

This new function does the math to figure out the convex polygon
to clip to in the case where we need to arch the inner edge of the
border. This calls into a new GraphicsContext function that is only
implemented on CG at this time. This is the reason we are keeping
around an old version of paintBorder() for now.
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):

  • rendering/RenderBoxModelObject.h:

borderInnerRect() is a new convenience function called from
RenderObject and RenderBoxModelObject to determine the rect of the
inside edge of the border.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::borderInnerRect):

This new function re-works drawArcForBoxSide to draw from Paths
when appropriate instead of stroking arcs.
(WebCore::RenderObject::drawBoxSideFromPath):

Keep this around for that do not HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) until
GraphicsContext::clipConvexPolygon() is implemented.
(WebCore::RenderObject::drawArcForBoxSide):

  • rendering/RenderObject.h:

New function
RenderStyle::getInnerBorderRadiiForRectWithBorderWidths() gets the
inner radius values for a rect. It takes border widths a parameters
rather than using the style's border widths so that it can be used
in inner radius calculations for double and groove/ridge
calculations. The W3C corner constraining rules were moved to a
static function that can be called from both getBorderRadiiForRect
() and getInnerBorderRadiiForRectWithBorderWidths().

  • rendering/style/RenderStyle.cpp:

(WebCore::constrainCornerRadiiForRect):
(WebCore::RenderStyle::getBorderRadiiForRect):
(WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):

  • rendering/style/RenderStyle.h:

LayoutTests: Tests with new results after
https://bugs.webkit.org/show_bug.cgi?id=9197 CSS3: Borders
with border-radius and double, groove, or ridge styles should look
better

Reviewed by Sam Weinig.

  • platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum:
  • platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed01-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDashed01-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed02-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDashed02-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed03-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDashed03-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted01-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDotted01-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted02-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDotted02-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted03-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDotted03-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble01-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble01-expected.png:
13:43 Changeset [62034] by mrobinson@webkit.org
  • 8 edits
    3 adds in trunk

[GTK] Add support for the progress bar tag
https://bugs.webkit.org/show_bug.cgi?id=41014

Reviewed by Xan Lopez.

WebCore:

Add support for rendering the progress tag for WebKit GTK+.

  • GNUmakefile.am:
  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar):
Added. Currently progress bar animations are disabled. As it looks like
there may not be a good way to support this with Mozilla's theme drawing code.
(WebCore::RenderThemeGtk::animationDurationForProgressBar): Ditto.
(WebCore::RenderThemeGtk::adjustProgressBarStyle): Added.
(WebCore::RenderThemeGtk::paintProgressBar): Added.

  • platform/gtk/RenderThemeGtk.h: Add declarations for new methods.
  • platform/gtk/gtk2drawing.c:

(moz_gtk_get_progress_widget): Expose the progress widget so that the chunk can be positioned properly.

  • platform/gtk/gtkdrawing.h: Added declaration for moz_gtk_get_progress_widget.

LayoutTests:

Unskip tests which are now passing after adding support for rendering the progress tag.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt: Added.
13:30 Changeset [62033] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 Regression: Crash in insert()
https://bugs.webkit.org/show_bug.cgi?id=41281

We need to call endIfDelayed() outside of the script nesting block
because endIfDelayed() might call end(), which deletes the
HTMLDocumentParser. If we try to exit the script nesting block after
the HTMLDocumentParser has been deleted, we'll decrement unallocated
memory, which is bad times.

Moving endIfDelayed outside of the script nesting block also lets us
avoid ending if inWrite() is true. If we're inWrite(), then there's
folks above us on the stack who will crash of the HTMLDocumentParser is
deallocated. Adding this check matches the LegacyHTMLDocumentParser
and the logic in attemptToEnd, facilitating a small refactoring of the
common logic for improved readability.

I don't know of any test case that changes in behavior because of this
patch, but this bug exists on the same line of code that the reliablity
tests crashed. I'm not sure whether this patch will fix that crash,
but removing bugs (even theoretical ones) seems like a good idea.

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append): (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
  • html/HTMLDocumentParser.h: (WebCore::HTMLDocumentParser::shouldDelayEnd):
13:22 Changeset [62032] by weinig@apple.com
  • 6 edits in trunk/WebKitTools

Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
Build up WebKitTestRunner output in the InjectedBundle

Reviewed by Anders Carlsson.

Simplify WebKitTestRunner by building up the output in the InjectedBundle
and sending it over postMessage when done, instead of using the async
WKPageRenderTreeExternalRepresentation.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::done):
(WTR::InjectedBundle::didRecieveMessage):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::os):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::WKStringToUTF8):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::WKStringToUTF8):
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::initializeMainWebView):
(WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
(WTR::TestInvocation::didRecieveMessageFromInjectedBundle):

  • WebKitTestRunner/TestInvocation.h:
13:17 Changeset [62031] by zherczeg@webkit.org
  • 3 edits in trunk/JavaScriptCore

Only one character lookahead should be enough for the lexer
https://bugs.webkit.org/show_bug.cgi?id=41213

Reviewed by Oliver Hunt.

The lexer had 4 character lookahead before, which required
a complex shifting mechanism. This can be improved by using
only one character lookahead for most decisions, and a
peek() function as a fallback when it is absolutely necessary.

  • parser/Lexer.cpp:

(JSC::Lexer::currentCharacter):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setCode):
(JSC::Lexer::shift):
(JSC::Lexer::peek):
(JSC::Lexer::getUnicodeCharacter):
(JSC::Lexer::shiftLineTerminator):
(JSC::Lexer::lastTokenWasRestrKeyword):
(JSC::Lexer::lex):
(JSC::Lexer::scanRegExp):
(JSC::Lexer::skipRegExp):

  • parser/Lexer.h:
13:10 Changeset [62030] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-06-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

MediaPlayerPrivate::getSupportedTypes does not return "modern" MIME types
https://bugs.webkit.org/show_bug.cgi?id=41287
<rdar://problem/8137402>

No new test because getSupportedTypes is used privately by MediaPlayer.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::getSupportedTypes): Build hash set with both common and modern types.
13:08 Changeset [62029] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-06-28 James Robinson <jamesr@chromium.org>

Reviewed by Darin Adler.

REGRESSION(53790): Neopets page with mismatched elements misrenders
https://bugs.webkit.org/show_bug.cgi?id=41181

Misnested formatting tags require fixup in order to create a valid DOM. Because this takes
O(N2) time in some cases, http://trac.webkit.org/changeset/53790 added an iteration limit
of 5 to this algorithm to avoid hangs. This limit is too low for neopets, but a limit of
7 is sufficient. This raises the limit to 10 to have a bit of breathing room. HTML5
defines the fixup algorithm http://www.whatwg.org/specs/web-apps/current-work/#adoptionAgency
but doesn't specify any particular iteration limit.

  • html/LegacyHTMLTreeBuilder.cpp:
13:05 Changeset [62028] by abarth@webkit.org
  • 6 edits in trunk

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The new tree builder needs to call attach() on elements it attaches to
the DOM
https://bugs.webkit.org/show_bug.cgi?id=41293

Update expected results to show that the contents of the iframe
actually get created. This only gets us a few lines down the test
harness before erroring out again, but I'll take it.

  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The new tree builder needs to call attach() on elements it attaches to
the DOM
https://bugs.webkit.org/show_bug.cgi?id=41293

Apparently Nodes expect to have their attach() method called when they
are attached to the DOM. The new tree builder is happy to oblige.
Making this call requires some fancy footwork with RefPtr/PassRefPtr to
avoid extra ref churn while keeping each function small.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::insertDoctype): (WebCore::HTMLTreeBuilder::insertComment): (WebCore::HTMLTreeBuilder::insertCommentOnDocument): (WebCore::HTMLTreeBuilder::insertElement): (WebCore::HTMLTreeBuilder::insertSelfClosingElement): (WebCore::HTMLTreeBuilder::insertScriptElement):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::attach):
13:01 Changeset [62027] by xan@webkit.org
  • 4 edits in trunk

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Bump version to 1.3.2.

  • configure.ac:

WebKit/gtk:

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Update for 1.3.2.

  • NEWS:
12:30 Changeset [62026] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-06-28 Xan Lopez <xlopez@igalia.com>

Fix distcheck.

  • GNUmakefile.am:
12:28 Changeset [62025] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Rubber-stamped Geoffrey Garen.

Add WKBundleFrameIsMainFrame to exports file.

  • mac/WebKit2.exp:
12:24 Changeset [62024] by robert@webkit.org
  • 4 edits in trunk

2010-06-28 Robert Hogan <robert@webkit.org>

Unreviewed, rolling out r62021.
http://trac.webkit.org/changeset/62021
https://bugs.webkit.org/show_bug.cgi?id=41261

Broke http/navigation tests among other

  • platform/qt/Skipped:

2010-06-28 Robert Hogan <robert@webkit.org>

Unreviewed, rolling out r62021.
http://trac.webkit.org/changeset/62021
https://bugs.webkit.org/show_bug.cgi?id=41261

Broke http/navigation tests among other

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpFramesAsText):
12:22 Changeset [62023] by weinig@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Add run-webkittestrunner to run WebKitTestRunner with the appropriate
environment.

Reviewed by Anders Carlsson.

  • Scripts/run-webkittestrunner: Added.
  • Scripts/webkitdirs.pm:
12:21 Changeset [62022] by xan@webkit.org
  • 2 edits in trunk

2010-06-28 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Bump gobject-introspection required version to 0.6.15, since we
are now shipping version 1.1 gir files.

  • configure.ac:
12:07 Changeset [62021] by robert@webkit.org
  • 4 edits in trunk

2010-06-28 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] dump frames in ascending alphabetical order of title

https://bugs.webkit.org/show_bug.cgi?id=41261

Unskip:
http/tests/navigation/metaredirect-frames.html
http/tests/navigation/redirect302-frames.html
http/tests/navigation/redirect302-subframeload.html
http/tests/navigation/timerredirect-frames.html

  • platform/qt/Skipped:

2010-06-28 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] dump frames in ascending alphabetical order of title

https://bugs.webkit.org/show_bug.cgi?id=41261

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpFramesAsText):
11:46 Changeset [62020] by robert@webkit.org
  • 5 edits in trunk

2010-06-28 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] dump bf history of child windows

https://bugs.webkit.org/show_bug.cgi?id=41266

Unskip http/tests/navigation/new-window-redirect-history.html

  • platform/qt/Skipped:

2010-06-28 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] dump bf history of child windows

https://bugs.webkit.org/show_bug.cgi?id=41266

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpBackForwardList): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
11:32 Changeset [62019] by weinig@apple.com
  • 12 edits
    2 adds in trunk

Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
WebKit2: Add frame API for InjectedBundle code

Reviewed by Anders Carlsson.

WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: Added.

(WKBundleFrameIsMainFrame):
(WKBundleFrameGetURL):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetMainFrame):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::isMainFrame):
(WebKit::WebFrame::url):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::mainFrame):

  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:

WebKitTools:

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didClearWindowForFrame):

10:41 Changeset [62018] by kbr@google.com
  • 5 edits
    2 adds in trunk

2010-06-28 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Index validation caches buffer size information too aggressively
https://bugs.webkit.org/show_bug.cgi?id=41092

Test: fast/canvas/webgl/index-validation-with-resized-buffer.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateRenderingState):
    • Compute the number of valid elements each time based on the latched buffer.

(WebCore::WebGLRenderingContext::vertexAttribPointer):

  • Do not cache the buffer size, only the attributes used to compute the number of required elements.
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
    • Ditto.

2010-06-28 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Index validation caches buffer size information too aggressively
https://bugs.webkit.org/show_bug.cgi?id=41092

  • fast/canvas/webgl/index-validation-with-resized-buffer-expected.txt: Added.
  • fast/canvas/webgl/index-validation-with-resized-buffer.html: Added.
  • fast/canvas/webgl/resources/webgl-test.js: (assertMsg): (glErrorShouldBe):
10:13 Changeset [62017] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-06-28 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Replace single treat-as-space characters with normal space
https://bugs.webkit.org/show_bug.cgi?id=41278

This keeps Qt from attempting glyph substitution and loading a bunch
of extra fonts when encountering &nbsp; entities.

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::floatWidthForComplexText):
10:00 Changeset [62016] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-06-28 Robin Cao <robin.cao@torchmobile.com.cn>

Reviewed by Dan Bernstein.

canvas fillText with @font-face crashes
https://bugs.webkit.org/show_bug.cgi?id=35486

The font object in CanvasRenderingContext2D may become invalid at some point.
Override recalcStyle() in HTMLCanvasElement, and update the font object from there if needed.

A test already exists: canvas/philip/tests/2d.text.draw.fontface.repeat.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::recalcStyle):
  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::updateFont):
  • html/canvas/CanvasRenderingContext2D.h:
09:58 Writing Layout Tests for DumpRenderTree edited by tonyg@chromium.org
(diff)
09:49 Writing Layout Tests for DumpRenderTree edited by tonyg@chromium.org
Add example of running make-script-test-wrappers (diff)
09:23 Changeset [62015] by leandro@webkit.org
  • 9 edits in trunk

2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed build fix.

[EFL] Build fix for latest version of Ecore library.
Ecore recently changed return type of callbacks from int to Eina_Bool.

  • wtf/efl/MainThreadEfl.cpp: (WTF::timeoutFired): Return Eina_Bool instead of int.

2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed build fix.

[EFL] Build fix for latest version of Ecore library.
Ecore recently changed return type of callbacks from int to Eina_Bool.

  • efl/EWebLauncher/main.c:
  • efl/ewk/ewk_view.cpp: (_ewk_view_zoom_animator_cb): Return Eina_Bool instead of int.

2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed build fix.

[EFL] Build fix for latest version of Ecore library.
Ecore recently changed return type of callbacks from int to Eina_Bool.

No new functionality, so no new tests.

  • platform/efl/SharedTimerEfl.cpp: (WebCore::timerEvent): Return Eina_Bool instead of int.

2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed build fix.

[EFL] Build fix for latest version of Ecore library.
Ecore recently changed return type of callbacks from int to Eina_Bool.

  • cmake/FindEFL.cmake: Bump version of Ecore dependency.
09:11 Changeset [62014] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-06-28 Xan Lopez <xlopez@igalia.com>

Fix build with GTK+ older than 2.18

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::visibleContentRect):
09:02 Changeset [62013] by xan@webkit.org
  • 5 edits in trunk/WebCore

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Adam Barth.

[GTK] Push NULL context on every DOM bindings entry point
https://bugs.webkit.org/show_bug.cgi?id=39967

Update GObject DOM bindings to push the NULL context on every API
entry point, and update bindings test results.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
09:01 Changeset [62012] by mrobinson@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-06-28 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Adam Roben.

[WinCairo] Text box backgrounds do not render in partially opaque layers
https://bugs.webkit.org/show_bug.cgi?id=41113

Tests:

manual-tests/partially-opaque-text-input.html

  • platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::releaseWindowsContext): When restoring a context which does not support alpha blending, manually set the alpha channel of the HBITMAP to fully opaque. This will effectively ignore the alpha channel of the HBITMAP, which is necessary because GDI drawing functions set the alpha value to be fully transparent (0).
09:00 Changeset [62011] by mrobinson@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-06-28 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Adam Roben.

[WinCairo] Rendering of themed elements on a layer with opacity produces nothing
https://bugs.webkit.org/show_bug.cgi?id=41111

Tests:

manual-tests/partially-opaque-form-elements.html

  • platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::GraphicsContext::releaseWindowsContext): Preform a cairo_save() and a cairo_restore() around code modifying the transformation matrix of the Cairo surface. Also set the destination coordinates before adjusting the transformation matrix scale, so that the destination coordinates are not scaled as well.
08:47 Changeset [62010] by commit-queue@webkit.org
  • 3 edits in trunk

2010-06-28 Sam Magnuson <smagnuson@netflix.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayerQt delay seems unnecessary.
https://bugs.webkit.org/show_bug.cgi?id=40846

  • compositing/animation/busy-indicator-no.png: Added.
  • compositing/animation/busy-indicator.html: Added.
  • compositing/animation/busy-indicator.png: Added.

2010-06-28 Sam Magnuson <smagnuson@netflix.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayerQt delay seems unnecessary.
https://bugs.webkit.org/show_bug.cgi?id=40846

Test: compositing/animation/busy-indicator.html

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::recache): (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsToImage): (WebCore::GraphicsLayerQt::addAnimation):
08:35 Changeset [62009] by jesus@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-28 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
https://bugs.webkit.org/show_bug.cgi?id=38597

Fix behavior so reload button really acts as a load and a reload button.

  • QtTestBrowser/mainwindow.cpp: (MainWindow::changeLocation):
08:31 Changeset [62008] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit

2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Simplify zoom setting by narrowing with WebCore API.
Instead of creating a zoom_text_only field, use the already defined enum
by WebCore.
https://bugs.webkit.org/show_bug.cgi?id=40993

  • efl/ewk/ewk_frame.cpp: sd->zoom_text_only => sd->zoom_mode (ewk_frame_zoom_set): (ewk_frame_zoom_text_only_get): (ewk_frame_zoom_text_only_set):
08:19 Changeset [62007] by commit-queue@webkit.org
  • 6 edits in trunk/JavaScriptCore

2010-06-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QScriptValue should have API for accessing object properties
https://bugs.webkit.org/show_bug.cgi?id=40903

Make possible to access properties inside QScriptValues. While this
still doesn't support the ResolveLocal parameter, it is already useful
for testing the API.

The tests from upstream QtScript weren't imported since most of them
depend on the setProperty() function as well. A simple test was created.

  • qt/api/qscriptvalue.cpp: (QScriptValue::property):
  • qt/api/qscriptvalue.h: (QScriptValue::):
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::property):
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::propertySimple):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
08:08 Changeset [62006] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit

2010-06-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement download requests
When a download request arrives through FrameLoaderClient, forward it to
browser in order to be possible to download files.
https://bugs.webkit.org/show_bug.cgi?id=40967

  • efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::download): get file names and forward to ewk_view_download_request()
  • efl/ewk/ewk_private.h: export private function to WebCoreSupport
08:05 Changeset [62005] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-28 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed test expectations update. Remove now passing fast/events/popup-allowed-from-gesture-initiated-form-submit.html

  • platform/chromium/test_expectations.txt:
07:39 Changeset [62004] by xan@webkit.org
  • 4 edits in trunk/WebCore

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Until now we were adding the event listeners for a given object in
the wrap method, since that's the first moment we have accoss to
the core WebCore object. The problem is that we only install the
listeners that the topmost class in the class hierarchy needs (eg,
HTMLParagrahElement for a P element), when most of the actual
event attributes are defined in the base classes (Node, Element,
...).

To fix this set the core object as a construct/write-only property
on the wrapper GObject, and set the eventlisteners in the cGObject
'construct' method, chaining up through all the class hierarchy
until the end. This way we'll get all the eventlisteners defined
in all the superclasses of our object, which is what we want.

  • bindings/gobject/WebKitDOMObject.cpp: (webkit_dom_object_get_property): (webkit_dom_object_set_property): (webkit_dom_object_class_init):
  • bindings/scripts/CodeGeneratorGObject.pm:
  • dom/Node.idl:
07:32 Changeset [62003] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-06-28 Xan Lopez <xlopez@igalia.com>

Fix GTK+ build.

  • platform/gtk/RenderThemeGtk.cpp:
07:18 Changeset [62002] by xan@webkit.org
  • 14 edits in trunk

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Add automake flag to signal whether we are building with GTK+ 2.x
or 3.x.

  • configure.ac:

WebCore:

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Fix build with GSEAL enabled.

  • GNUmakefile.am:
  • platform/gtk/GtkVersioning.h:
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget): (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::systemColor):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformRemoveChild): (WebCore::ScrollView::visibleContentRect):
  • platform/gtk/gtk2drawing.c: (ensure_toggle_button_widget): (ensure_combo_box_widgets): (ensure_combo_box_entry_widgets): (ensure_tree_header_cell_widget): (moz_gtk_button_paint): (moz_gtk_toggle_paint): (calculate_button_inner_rect): (calculate_arrow_rect): (moz_gtk_scrollbar_button_paint): (moz_gtk_scrollbar_trough_paint): (moz_gtk_scrollbar_thumb_paint): (moz_gtk_spin_paint): (moz_gtk_spin_updown_paint): (moz_gtk_scale_paint): (moz_gtk_scale_thumb_paint): (moz_gtk_gripper_paint): (moz_gtk_hpaned_paint): (moz_gtk_vpaned_paint): (moz_gtk_entry_paint): (moz_gtk_treeview_paint): (moz_gtk_tree_header_sort_arrow_paint): (moz_gtk_treeview_expander_paint): (moz_gtk_expander_paint): (moz_gtk_combo_box_paint): (moz_gtk_downarrow_paint): (moz_gtk_combo_box_entry_button_paint): (moz_gtk_container_paint): (moz_gtk_toggle_label_paint): (moz_gtk_toolbar_paint): (moz_gtk_toolbar_separator_paint): (moz_gtk_tooltip_paint): (moz_gtk_resizer_paint): (moz_gtk_frame_paint): (moz_gtk_progressbar_paint): (moz_gtk_progress_chunk_paint): (moz_gtk_get_tab_thickness): (moz_gtk_tab_paint): (moz_gtk_tabpanels_paint): (moz_gtk_tab_scroll_arrow_paint): (moz_gtk_menu_bar_paint): (moz_gtk_menu_popup_paint): (moz_gtk_menu_separator_paint): (moz_gtk_menu_item_paint): (moz_gtk_menu_arrow_paint):

WebKit/gtk:

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Fix build with GSEAL enabled.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
  • webkit/webkitsoupauthdialog.c: (show_auth_dialog):

WebKitTools:

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Fix build with GSEAL enabled.

  • DumpRenderTree/gtk/EventSender.cpp: (gtk_widget_get_window): (prepareMouseButtonEvent): (mouseMoveToCallback): (mouseWheelToCallback): (keyDownCallback):
06:58 Changeset [62001] by xan@webkit.org
  • 12 edits
    1 move in trunk

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253

Add --with-gtk configure flag, defaulting to support for GTK+ 2.x.

  • GNUmakefile.am:
  • configure.ac:

WebCore:

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253

Adapt build system for 3.x support.

  • GNUmakefile.am:

WebKit/gtk:

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253

Adapt build system for 3.x support, allow the JSCore gir and webkit
pc files to be configurable at build time for different API
versions.

  • JSCore-1.0.gir: Removed.
  • JSCore.gir.in: Added.
  • docs/GNUmakefile.am:
  • webkit.pc.in:

JavaScriptCore:

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253

Suffix jsc with the API version of the library, so that
libwebkitgtk 1.x and 3.x can install jsc.

  • GNUmakefile.am:

WebKitTools:

2010-06-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Add support for GTK+3
https://bugs.webkit.org/show_bug.cgi?id=41253

Adapt build system for 3.x support.

  • GNUmakefile.am:
06:16 Changeset [62000] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-28 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium debugger tests.

  • src/js/Tests.js: (.TestSuite.prototype.testDebugIntrinsicProperties):
06:07 Changeset [61999] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-06-28 MORITA Hajime <morrita@google.com>

Unreviewd. Skipped a test for qt at this time due to outdated expectation.
We need to rebaseline it.

  • platform/qt/Skipped:
05:49 Changeset [61998] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-06-28 MORITA Hajime <morrita@google.com>

Unreviewed text expectations update after r61993.

  • platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt:
05:46 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
05:36 Changeset [61997] by yurys@chromium.org
  • 4 edits
    2 adds in trunk

2010-06-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: properties of scope variables are flattened while on a breakpoint.
https://bugs.webkit.org/show_bug.cgi?id=41214

  • inspector/debugger-proto-property-expected.txt: Added.
  • inspector/debugger-proto-property.html: Added.
  • platform/qt/Skipped:

2010-06-28 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: properties of scope variables are flattened while on a breakpoint.
https://bugs.webkit.org/show_bug.cgi?id=41214

Test: inspector/debugger-proto-property.html

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): object proxy with non-empty path cannot be scope proxy.
05:30 Changeset [61996] by morrita@google.com
  • 6 edits
    3 adds in trunk/LayoutTests

2010-06-28 MORITA Hajime <morrita@google.com>

Unreviewed text expectations update after r61993.

  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
05:21 Changeset [61995] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

[QT][S60] build-webkit scripts picks wrong make spec for windows build
https://bugs.webkit.org/show_bug.cgi?id=41198

Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-06-10
Reviewed by Simon Hausmann.

Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds.

  • Scripts/webkitdirs.pm:

(determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well

04:40 Changeset [61994] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-06-28 MORITA Hajime <morrita@google.com>

Unreviewed attempt to fix windows build.

  • page/DOMWindow.idl:
04:20 Changeset [61993] by morrita@google.com
  • 9 edits in trunk

2010-06-22 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<progress> should be styled with -webkit-progress-bar-value
https://bugs.webkit.org/show_bug.cgi?id=40823

Added cases for various style combinations, and explanations for
that cases.

  • fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html:
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum:
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/qt/Skipped:

2010-06-22 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<progress> should be styled with -webkit-progress-bar-value
https://bugs.webkit.org/show_bug.cgi?id=40823

Fixed to peek styles of the shadow node pseudo class to fallback
to non-styled painting.

  • css/html.css: (progress): Added defaul background-color. (progress::-webkit-progress-bar-value): Added defaul background-color.
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::updatePartsState):

Test: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html

03:30 Changeset [61992] by ossy@webkit.org
  • 2 edits in trunk/WebCore

2010-06-28 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Kent Tamura.

GCC suggest parentheses around && within

https://bugs.webkit.org/show_bug.cgi?id=41245

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
03:01 Changeset [61991] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-28 Eric Seidel <eric@webkit.org>

Unreviewed. Update test-html5-parser results to
match the results from the new treebuilder.
These results were otherwise useless now that we
have he HTML5 Tokenizer on by default.

  • html5lib/runner-expected-html5.txt:
  • html5lib/webkit-resumer-expected-html5.txt:
02:56 Changeset [61990] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't dump contents of <script> elements in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=41277

Apparently we need to tell each element when we start and stop parsing
its children. If we don't do this, we see the contents of every script
and style element in dumpAsText LayoutTests. (This patch is *well*
covered by LayoutTests.)

  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::pop): (WebCore::HTMLTreeBuilder::ElementStack::push):
02:44 Changeset [61989] by eric@webkit.org
  • 12 edits in trunk

2010-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to test the new HTML5 TreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=41276

Adam was concerned that someone might make their port
depend on this setting (I guess we had some trouble with that
with the HTML5Parser setting), so I littered the code with warnings.

test-html5-parser now tests this code path.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::finished):
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setHTML5TreeBuilderEnabled_DO_NOT_USE): (WebCore::Settings::html5TreeBuilderEnabled):

2010-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to test the new HTML5 TreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=41276

Adam was concerned that someone might make their port
depend on this setting (I guess we had some trouble with that
with the HTML5Parser setting), so I littered the code with warnings.

test-html5-parser now tests this code path.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences html5TreeBuilderEnabled]): (-[WebPreferences setHTML5TreeBuilderEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to test the new HTML5 TreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=41276

Adam was concerned that someone might make their port
depend on this setting (I guess we had some trouble with that
with the HTML5Parser setting), so I littered the code with warnings.

test-html5-parser now tests this code path.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): (initializeGlobalsFromCommandLineOptions):
  • Scripts/test-html5-parser:
02:40 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
02:34 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
02:29 Changeset [61988] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make the html5lib runner.html not assert
https://bugs.webkit.org/show_bug.cgi?id=41273

This patch gets us closer to being able to run the parser tests. We
still don't get parsing correct, but at least we don't assert. :)

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::insertCommentOnDocument):
  • html/HTMLTreeBuilder.h:
02:16 QtWebKitDocContrib edited by henry.haverinen@nokia.com
(diff)
01:47 Changeset [61987] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-28 Eric Seidel <eric@webkit.org>

Unreviewed. Attempt to fix Chromium and Qt builders.

Add a new baseclass for XML, HTML and Text DocumentParsers to clean up DocumentParser call sites
https://bugs.webkit.org/show_bug.cgi?id=41141

No functional changes, thus no tests.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::eventHandlerLineNumber): (WebCore::ScriptController::eventHandlerColumnNumber):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::stopParsing):
01:15 Changeset [61986] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for parsing attributes
https://bugs.webkit.org/show_bug.cgi?id=41272

This patch lets use parse the following document:

<script src="data:text/javascript,alert('PASS')"></script>

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML): (WebCore::HTMLTreeBuilder::insertScriptElement): (WebCore::HTMLTreeBuilder::createElement):
00:56 Changeset [61985] by eric@webkit.org
  • 27 edits
    3 copies
    1 add in trunk/WebCore

2010-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Add a new baseclass for XML, HTML and Text DocumentParsers to clean up DocumentParser call sites
https://bugs.webkit.org/show_bug.cgi?id=41141

By splitting ScriptableDocumentParser and DecodedDataDocumentParser
out from DocumentParser we've made the DocumentParser and
RawDataDocumentParser classes simpler.

No functional change, thus no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::eventHandlerLineNumber):
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
  • dom/Document.cpp: (WebCore::Document::scriptableDocumentParser): (WebCore::Document::open): (WebCore::Document::implicitOpen): (WebCore::Document::implicitClose): (WebCore::Document::removePendingSheet):
  • dom/Document.h: (WebCore::Document::parser):
  • dom/DocumentParser.cpp: (WebCore::DocumentParser::DocumentParser):
  • dom/DocumentParser.h: (WebCore::DocumentParser::asScriptableDocumentParser):
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::finishWasCalled):
  • dom/ScriptableDocumentParser.cpp: Copied from WebCore/html/HTMLEntityParser.h. (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
  • dom/ScriptableDocumentParser.h: Added. (WebCore::ScriptableDocumentParser::isExecutingScript): (WebCore::ScriptableDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::ScriptableDocumentParser::xssAuditor): (WebCore::ScriptableDocumentParser::setXSSAuditor): (WebCore::ScriptableDocumentParser::processingContentWrittenByScript): (WebCore::ScriptableDocumentParser::asScriptableDocumentParser):
  • dom/ViewportArguments.cpp: (WebCore::parserLineNumber): (WebCore::reportViewportWarning):
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
  • html/HTMLDocumentParser.h:
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::LegacyHTMLDocumentParser): (WebCore::LegacyHTMLDocumentParser::parseTag):
  • html/LegacyHTMLDocumentParser.h: (WebCore::LegacyHTMLDocumentParser::processingContentWrittenByScript):
  • html/LegacyHTMLTreeBuilder.cpp: (WebCore::LegacyHTMLTreeBuilder::reportErrorToConsole):
  • loader/DocumentLoader.cpp:
  • loader/DocumentWriter.cpp:
  • loader/TextDocument.cpp: (WebCore::TextDocumentParser::TextDocumentParser): (WebCore::TextDocumentParser::finish):
  • svg/SVGDocumentExtensions.cpp: (WebCore::parserLineNumber): (WebCore::reportMessage): (WebCore::SVGDocumentExtensions::reportWarning): (WebCore::SVGDocumentExtensions::reportError):
00:35 Changeset [61984] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-06-28 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] QGraphicsWebView crash when calling setScale() before setUrl()
https://bugs.webkit.org/show_bug.cgi?id=40000

Check 'page' before dereference in _q_scaleChanged()
Autotest included.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::_q_scaleChanged):
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::crashOnSetScaleBeforeSetUrl):
00:26 Changeset [61983] by sfalken@apple.com
  • 5 edits
    1 add in trunk/WebCore

2010-06-27 Steve Falkenburg <sfalken@apple.com>

Reviewed by Mark Rowe.

WebKit2 build exceeds address space on 32-bit Windows builders
https://bugs.webkit.org/show_bug.cgi?id=41270

Add all-in-one file for render-related SVG files.
Clean up other all-in-one files by adding missing files, excluding matching files from the vcproj.
Reduces release WebCore.lib size by 10% (160MB).

  • DerivedSources.cpp:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • html/HTMLElementsAllInOne.cpp:
  • rendering/RenderSVGAllInOne.cpp: Added.
00:18 Changeset [61982] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out the InBodyMode for the tree builder
https://bugs.webkit.org/show_bug.cgi?id=41271

This gives us some basic behavior for the InBodyMode. I've implemented
some of the easier logic. The more complicated logic will be in
subsequent patches.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::insertFormatingElement): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements):
  • html/HTMLTreeBuilder.h:

06/27/10:

23:52 Changeset [61981] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Windows (Cairo) build fix.
Add missing ENABLE_WEB_TIMING feature define.

  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
23:49 Changeset [61980] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Windows build fix.
Disable ENABLE_WEB_TIMING on Windows.

  • win/tools/vsprops/FeatureDefines.vsprops:
23:37 Changeset [61979] by mrowe@apple.com
  • 4 edits in trunk/WebKit2

Update guards related to blocks to check whether BLOCKS is defined, rather than checking its value.

Rubber-stamped by Maciej Stachowiak.

This matches how similar checks are performed in system headers, and avoids a compile error when BLOCKS
is not defined.

  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPagePrivate.h:
22:45 Changeset [61978] by morrita@google.com
  • 2 edits in trunk/WebKitTools

2010-06-27 MORITA Hajime <morrita@google.com>

Unreviewed.

Some never-called @staticmethods touched self.
Fixed it to replace these self with a class.

  • Scripts/webkitpy/common/checkout/scm.py:
22:34 Changeset [61977] by morrita@google.com
  • 3 edits in trunk/WebKitTools

2010-06-27 MORITA Hajime <morrita@google.com>

Unreviewed.

Fixed exception raising syntax that is pointed out at
https://bugs.webkit.org/show_bug.cgi?id=41153

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py: Removed a bad line that I accidentally checked-in at last revision.
22:15 Changeset [61976] by morrita@google.com
  • 4 edits in trunk/WebKitTools

2010-06-24 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

rebaseline-chromium-webkit-tests should add or remove files to local git repository
https://bugs.webkit.org/show_bug.cgi?id=41153

  • Added SCM.add() and SCM.remove()
  • Replaced "svn add" and "svn remove" rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
  • add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py for debugging purpose.
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
18:59 Changeset [61975] by yuzo@google.com
  • 29 edits in trunk

2010-06-25 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Improve default value handling for page format properties.
https://bugs.webkit.org/show_bug.cgi?id=41150

  • printing/page-format-data-expected.txt:
  • printing/page-format-data.html:
  • printing/page-rule-selection-expected.txt:
  • printing/page-rule-selection.html:

2010-06-25 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Improve default value handling for page format properties.

Default page size and orientation have been hard-coded.
Instead, pass default page size and margins to
WebCore::Document::pageSizeAndMarginsInPixels to handle auto page size
and margins specified as percentages.
Return margins instead of page rect.

https://bugs.webkit.org/show_bug.cgi?id=41150

  • WebCore.base.exp:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyPageSizeProperty): (WebCore::CSSStyleSelector::pageSizeFromName):
  • css/html.css: (@page):
  • dom/Document.cpp: (WebCore::Document::pageSizeAndMarginsInPixels):
  • dom/Document.h:
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): (WebCore::PrintContext::pageSizeAndMarginsInPixels):
  • page/PrintContext.h:
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::pageSizeType): (WebCore::InheritedFlags::setPageSizeType): (WebCore::InheritedFlags::resetPageSizeType):
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h: (WebCore::):

2010-06-25 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Improve default value handling for page format properties.
https://bugs.webkit.org/show_bug.cgi?id=41150

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::pageSizeAndMarginsInPixels):
  • src/WebFrameImpl.h:

2010-06-25 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Improve default value handling for page format properties.
https://bugs.webkit.org/show_bug.cgi?id=41150

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame pageSizeAndMarginsInPixels:pageNumber:width:height:marginTop:marginRight:marginBottom:]):

2010-06-25 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Improve default value handling for page format properties.
https://bugs.webkit.org/show_bug.cgi?id=41150

  • DumpRenderTree/LayoutTestController.cpp: (parsePageNumber): (parsePageNumberSizeMarings): (pageSizeAndMarginsInPixelsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pageSizeAndMarginsInPixels):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pageSizeAndMarginsInPixels):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pageSizeAndMarginsInPixels):
16:19 Changeset [61974] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Clean up some loose ends in HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=41265

This patch cleans up a few loose ends in HTML5 tree builder.
Technically, we could do each of these as individual patches, but that
didn't seem worth while.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
    • Add missing break before default case statement. I don't think this change is observable.

(WebCore::HTMLTreeBuilder::processComment):

  • Originally I thought that comments had special processing in the InHeadNoscriptMode, but it turns out that when you unwind the definitions, it amounts to exactly the same thing.

(WebCore::HTMLTreeBuilder::processEndOfFile):

  • Add missing break before default case statement. I don't think this change is observable.

(WebCore::HTMLTreeBuilder::insertComment):

  • Eliminate one unnecessary ref/deref pair.

(WebCore::HTMLTreeBuilder::insertSelfClosingElement):

  • When we insert self-closing elements, there's no reason to push them onto the stack of open elements just to pop them off again. This change saves a malloc/free pair as well as a ref/deref pair. Go team.
  • html/HTMLTreeBuilder.h:
    • Remove unused function.
15:45 Changeset [61973] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement remaining StartTag processing for InHeadNoscriptMode
https://bugs.webkit.org/show_bug.cgi?id=41264

The InHeadNoscriptMode processes some start tags "as if" the tree
builder were in the InHeadMode. This is an idiom we'll see more of
later. My approach is this patch is to factor all the logic for
processing start tags in the InHeadMode into a separate function that
can be called from both locations. This seems cleaner than just
splitting out the parts that are actually used by both modes.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processStartTagForInHead): (WebCore::HTMLTreeBuilder::insertSelfClosingElement):
  • html/HTMLTreeBuilder.h:
15:20 Changeset [61972] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for <title> and <style> elements
https://bugs.webkit.org/show_bug.cgi?id=41263

These elements use the generic RCDATA and RawText algorithms,
respectively.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::insertGenericRCDATAElement): (WebCore::HTMLTreeBuilder::insertGenericRawTextElement):
15:09 Changeset [61971] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Actually insert Doctype elements
https://bugs.webkit.org/show_bug.cgi?id=41262

This code is pretty much the same as in the old tree builder.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::publicIdentifier): (WebCore::AtomicHTMLToken::systemIdentifier):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertDoctype):
10:10 Changeset [61970] by commit-queue@webkit.org
  • 5 edits in trunk

2010-06-27 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Canvas: Ignore calls to drawImage() with non-finite parameters
https://bugs.webkit.org/show_bug.cgi?id=38929

Rebaseline (and unskip for Qt) the now working test.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#2dcontext

  • canvas/philip/tests/2d.drawImage.nonfinite-expected.txt:
  • platform/qt/Skipped:

2010-06-27 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Canvas: Ignore calls to drawImage() with non-finite parameters
https://bugs.webkit.org/show_bug.cgi?id=38929

This also fixes a Qt assert when using the raster graphics system.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#2dcontext

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
09:36 Changeset [61969] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-27 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Turn ENABLE(SINGLE_THREADED) on.
https://bugs.webkit.org/show_bug.cgi?id=41135

Brew MP does not support preemptive multi-threading.
Disable threading for Brew MP.

  • wtf/Platform.h:
07:14 Changeset [61968] by commit-queue@webkit.org
  • 4 edits in trunk

2010-06-27 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

editing/execCommand/copy-without-selection.html fails on Qt after r61637
https://bugs.webkit.org/show_bug.cgi?id=41025

Unskip editing/execCommand/copy-without-selection.html for Qt.

  • platform/qt/Skipped:

2010-06-27 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

editing/execCommand/copy-without-selection.html fails on Qt after r61637
https://bugs.webkit.org/show_bug.cgi?id=41025

The problem was that when getting data back via Clipboard::getData(),
the String::String(const char*, int) constructor was called
with UTF-16 data.

The solution is to use QMimeData's text() and setText() for "text/plain".

setText() which makes sure Qt passes the string in proper format to the
system clipboard. (The previous implementation would convert it to UTF-8)

text() makes sure that the correct encoding is used (UTF-16) and that
we get back whatever we originally put in there.

  • platform/qt/ClipboardQt.cpp: (WebCore::isTextMimeType): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData):
03:05 Changeset [61967] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-27 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed, mark fast/js/Object-create.html as crashing on Cr Linux, will look into it.

  • platform/chromium/test_expectations.txt:
01:38 Changeset [61966] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 tree builder should be able to execute inline scripts
https://bugs.webkit.org/show_bug.cgi?id=41257

This patch implements enough machinery so that we can execute inline
scripts in extremely simple documents such as the following:

<html>
<script>
alert(1);
</script>

To get this to work, I had to flesh out a surprising amount of the data
structures for processing the <head>. No tests because this is
already covered by most LayoutTests.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::insertComment): (WebCore::HTMLTreeBuilder::insertElement): (WebCore::HTMLTreeBuilder::insertScriptElement):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementRecord::ElementRecord): (WebCore::HTMLTreeBuilder::ElementRecord::element): (WebCore::HTMLTreeBuilder::ElementRecord::next): (WebCore::HTMLTreeBuilder::ElementRecord::releaseNext): (WebCore::HTMLTreeBuilder::ElementRecord::setNext): (WebCore::HTMLTreeBuilder::ElementStack::pop): (WebCore::HTMLTreeBuilder::ElementStack::push): (WebCore::HTMLTreeBuilder::ElementStack::top): (WebCore::HTMLTreeBuilder::ElementStack::remove): (WebCore::HTMLTreeBuilder::currentElement):
Note: See TracTimeline for information about the timeline view.