Timeline


and

07/04/10:

23:56 Changeset [62475] by yurys@chromium.org

2010-07-04 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark fast/js/function-apply-many-args.html as
having wrong output in debug mode.

  • platform/chromium/test_expectations.txt:
21:45 Changeset [62474] by eric@webkit.org

2010-07-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in table body" mode to support <tr> insertion
https://bugs.webkit.org/show_bug.cgi?id=41587

  • html5lib/runner-expected-html5.txt:
    • <tr> tags now show up, imagine that.

2010-07-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add basic "in table body" mode to support <tr> insertion
https://bugs.webkit.org/show_bug.cgi?id=41587

This also adds a (currently untestable?)
popUntilTableBodyScopeMarker code path.
Any tags which would be between a tbody a <tr> would end up
foster parented outside the <table>. I think the spec was
just being over-cautious with popUntilTableBodyScopeMarker.

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLNames::isTableBodyScopeMarker): (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
19:37 Changeset [62473] by pkasting@chromium.org

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium/test_expectations.txt:
16:27 Changeset [62472] by andersca@apple.com

Fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
16:15 Changeset [62471] by andersca@apple.com

Add simple command line parser and pass mode argument to the web process
https://bugs.webkit.org/show_bug.cgi?id=41586

Reviewed by Dan Bernstein.

  • Shared/CommandLine.h:

(WebKit::CommandLine::operator[]):
Add CommandLine class.

  • Shared/mac/CommandLineMac.cpp:

(WebKit::CommandLine::parse):
Implement Mac version of CommandLine::parse.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):
Add "legacywebprocess" mode to the posix_spawn call.

  • WebKit2.xcodeproj/project.pbxproj:

Add CommandLine to the xcode project.

  • WebProcess/Launching/mac/WebProcessMain.mm:

(webProcessMain):
(main):
Parse the command line and check the mode.

15:06 Changeset [62470] by eric@webkit.org

2010-07-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
https://bugs.webkit.org/show_bug.cgi?id=41453

Fix Qt Minimal build. SVGNames.h should always
be generated, even when SVG is off, however that's
not how things currently work.

  • html/HTMLTreeBuilder.cpp:
14:54 Changeset [62469] by eric@webkit.org

2010-07-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add a very basic InTable insertion mode
https://bugs.webkit.org/show_bug.cgi?id=41581

  • html5lib/runner-expected-html5.txt:
    • Update expectations now that we pass 6 more tests.

2010-07-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add a very basic InTable insertion mode
https://bugs.webkit.org/show_bug.cgi?id=41581

There is still a bunch of low-hanging fruit left for this
mode, but even this most-basic support lets us pass 6 more tests. :)

It's a progression, ship it! :)

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isListItemScopeMarker): (WebCore::HTMLNames::isTableScopeMarker): (WebCore::HTMLElementStack::popUntilTableScopeMarker):
  • html/HTMLElementStack.h:
  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::appendMarker):
  • html/HTMLFormattingElementList.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.h:
14:15 Changeset [62468] by eric@webkit.org

2010-07-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
https://bugs.webkit.org/show_bug.cgi?id=41453

Added new adoption01 suite for testing adoption agency
bugs. Right now only the simplest adoption test passes.
I'll be adding more in future commits.

  • html5lib/resources/adoption01.dat: Added.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:

2010-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTreeBuilder needs an adoption agency
https://bugs.webkit.org/show_bug.cgi?id=41453

This changes some test results, but only makes the simplest
adoption agency cases pass. I think the code is likely
very close, but further iteration to make this change larger
seems counter-productive. I recommend we check in this
progression and work from here.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::addChildCommon):
    • Make sure callers don't assume this will reparent.

(WebCore::ContainerNode::parserAddChild):

  • Update comment to document lack of reparenting behavior.
  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::~ElementRecord): (WebCore::HTMLElementStack::ElementRecord::replaceElement): (WebCore::HTMLElementStack::ElementRecord::isAbove):
    • Added for debugging.

(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::insertAbove):

  • Needed for the adoption agency.

(WebCore::HTMLElementStack::topRecord):
(WebCore::HTMLElementStack::bottom):
(WebCore::HTMLElementStack::removeHTMLHeadElement):
(WebCore::HTMLElementStack::remove):
(WebCore::HTMLElementStack::find):
(WebCore::HTMLElementStack::topmost):
(WebCore::HTMLElementStack::contains):
(WebCore::HTMLElementStack::htmlElement):
(WebCore::HTMLElementStack::headElement):
(WebCore::HTMLElementStack::bodyElement):
(WebCore::HTMLElementStack::pushCommon):
(WebCore::HTMLElementStack::removeNonTopCommon):

  • Fix the name to match top/bottom.
  • html/HTMLElementStack.h: (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::next): (WebCore::HTMLElementStack::ElementRecord::releaseNext): (WebCore::HTMLElementStack::ElementRecord::setNext):
  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::closestElementInScopeWithName): (WebCore::HTMLFormattingElementList::contains): (WebCore::HTMLFormattingElementList::find): (WebCore::HTMLFormattingElementList::remove):
  • html/HTMLFormattingElementList.h: (WebCore::HTMLFormattingElementList::isEmpty): (WebCore::HTMLFormattingElementList::size):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
    • Part of the Adoption Agency algorithm.

(WebCore::HTMLTreeBuilder::findFosterParentFor):

  • Used to move mis-nested content out of tables. This doesn't seem to work quite right yet.

(WebCore::HTMLTreeBuilder::reparentChildren):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

  • The ridiculously long/complicated adoption agency algorithm from HTML5.

(WebCore::HTMLTreeBuilder::processEndTag):

  • html/HTMLTreeBuilder.h:
10:44 Changeset [62467] by jschuh@chromium.org

2010-07-04 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=41578

Remove bindings obsoleted by: http://trac.webkit.org/changeset/59866
No new tests because behavior is not changed.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLFrameElementCustom.cpp:
  • bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
09:22 Changeset [62466] by jschuh@chromium.org

2010-07-04 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Remove custom src bindings for HTMLFrameElement and HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=41578

Remove bindings obsoleted by: http://trac.webkit.org/changeset/59866
No new tests because behavior is not changed.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLFrameElementCustom.cpp:
  • bindings/js/JSHTMLIFrameElementCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Removed.
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
09:06 UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
09:04 UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
06:38 Changeset [62465] by robert@webkit.org

2010-07-04 Robert Hogan <robert@webkit.org>

[Qt] Triage failing HTTP tests in Qt Skipped list

Unreviewed, sorting tests and adding comments to skipped list.

  • platform/qt/Skipped:
04:48 Changeset [62464] by mrowe@apple.com

Build fix after r62456.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute): Be slightly more consistent in using uint32_t to prevent
warnings about comparisons between signed and unsigned types, and attempts to call an overload
of std::min that doesn't exist.

03:38 Changeset [62463] by robert@webkit.org

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

Unreviewed, accidental omission from r61505

https://bugs.webkit.org/show_bug.cgi?id=36702

Forgot to unskip plugins/reentrant-update-widget-positions.html
as part of http://trac.webkit.org/changeset/61505

03:16 Changeset [62462] by yurys@chromium.org

2010-07-04 Yury Semikhatsky <yury@yurys-imac.local>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/js/function-apply-expected.txt: Added.
  • platform/chromium-mac/fast/js/function-apply-many-args-expected.txt: Added.
  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/fast/js/function-apply-expected.txt: Added.
  • platform/chromium-win/fast/js/function-apply-many-args-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt:
02:41 Changeset [62461] by mjs@apple.com

2010-07-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

WebProcess crashes in release for simple layout tests
https://bugs.webkit.org/show_bug.cgi?id=41575

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageCopyRenderTreeExternalRepresentation): ref external representation StringImpl* before taking it out of its parent String, to avoid returning freed memory.

07/03/10:

22:09 Changeset [62460] by abarth@webkit.org

2010-07-03 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Implement AfterAfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41561

Test coverage of this mode was a bit ... lacking, shall we say? This
patch adds a test for it.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-03 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Implement AfterAfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41561

This mode is almost unobservable. The main way to observe it seems to
be seeing where comment nodes get attached to the DOM.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
21:53 Changeset [62459] by mjs@apple.com

Add stdint.h include to fix WebKitTestRunner build.

Rubber stamped by Anders Carlsson.

  • UIProcess/API/C/WKPage.h:
18:33 Changeset [62458] by zmo@google.com

2010-07-03 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
https://bugs.webkit.org/show_bug.cgi?id=41572

  • platform/mac-leopard/Skipped: Adding back the program-test.html test since the failure cause is fixed in this patch.

2010-07-03 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

WebGLRenderingContext::vertexAttrib* leads to possible out-of-range vector member visit
https://bugs.webkit.org/show_bug.cgi?id=41572

  • html/canvas/WebGLRenderingContext.cpp: Fix the out-of-range vector member visit, also refactor the code. (WebCore::WebGLRenderingContext::vertexAttrib1f): (WebCore::WebGLRenderingContext::vertexAttrib1fv): (WebCore::WebGLRenderingContext::vertexAttrib2f): (WebCore::WebGLRenderingContext::vertexAttrib2fv): (WebCore::WebGLRenderingContext::vertexAttrib3f): (WebCore::WebGLRenderingContext::vertexAttrib3fv): (WebCore::WebGLRenderingContext::vertexAttrib4f): (WebCore::WebGLRenderingContext::vertexAttrib4fv): (WebCore::WebGLRenderingContext::vertexAttribfImpl): (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
  • html/canvas/WebGLRenderingContext.h: Helper function declaration.
17:11 Changeset [62457] by weinig@apple.com

Patch for https://bugs.webkit.org/show_bug.cgi?id=41553
Make StringExtras.h versions of snprintf and vsnprintf match the unix versions.

Reviewed by Darin Adler.

  • MSVC does not ensure the buffers are null terminated as the unix versions do.
  • runtime/JSGlobalObjectFunctions.cpp: Cleanup includes.
  • runtime/UString.cpp: Clean up includes.

(JSC::UString::from): Don't pass sizeof(buf) - 1, that is wrong.

  • wtf/StringExtras.h:

(snprintf): Ensure null termination of buffer.
(vsnprintf): Ditto.

16:49 Changeset [62456] by darin@apple.com

2010-07-03 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Make Arguments::MaxArguments clamping work for numbers >= 0x80000000 in
the interpreter as well as the JIT.

https://bugs.webkit.org/show_bug.cgi?id=41351
rdar://problem/8142141

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Fix signed integer overflow problem in op_load_varargs handling. 0xFFFFFFFF was read as -1.

2010-07-03 Darin Adler <darin@apple.com>

Added test cases for edge cases in apply function on arrays.
https://bugs.webkit.org/show_bug.cgi?id=41351

  • fast/js/function-apply-expected.txt: Updated to expect success.
  • fast/js/script-tests/function-apply.js: Added test cases.
16:02 Changeset [62455] by jorlow@chromium.org

Ugh. Have to put the destructor in the .h file since the .ccp isn't compiled yet.

  • storage/IDBKey.h:

(WebCore::IDBKey::~IDBKey):

16:00 Changeset [62454] by commit-queue@webkit.org

2010-07-03 Patrick Gansterer <paroga@paroga.com>

Reviewed by Simon Hausmann.

[Qt] Fix DumpRenderTree userStyleSheet handling.
https://bugs.webkit.org/show_bug.cgi?id=41570

DumpRenderTree did only set the userStyleSheet at
layoutTestController.setUserStyleSheetEnabled().

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setUserStyleSheetEnabled):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
15:48 UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
15:48 Changeset [62453] by jorlow@chromium.org

Build fix. Forgot destructor.

  • storage/IDBKey.cpp:

(WebCore::IDBKey::~IDBKey):

15:46 UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
15:45 UpdatingBugzilla edited by ddkilzer@webkit.org
Updated Update section for bzr (diff)
15:37 UpdatingBugzilla edited by ddkilzer@webkit.org
Switched from CVS to bzr for upstream Bugzilla repository. (diff)
15:18 Changeset [62452] by jorlow@chromium.org

2010-06-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dumitru Daniliuc.

Support for keys and in-memory storage for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=41252

Set the role to Private.

2010-06-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Dumitru Daniliuc.

Support for keys and in-memory storage for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=41252

It'll take some time to get data persistence working for IndexedDB,
so until then, we'll just store everything in an in memory tree.
The tree uses WTF::AVLTree and is a template so that it can be used by
object stores (IDBKey -> SerializedScriptValue) and indexes (IDBKey ->
IDBKey). This class will be used in a subsequent patch.

Also add an IDBKey type that represents one of these keys. We use a
custom toJS function in a way similar to IDBAny to convert from WebCore
to a JS value. For converting the other way, we have to teach the code
generators what to do (unfortunately). This is done in a way similar
to serialized script value. Unlike serialized script value, IDBKey is
in WebCore and only a helper function is JS engine specific.

This code is not accessable from layout tests. (Will fix in
https://bugs.webkit.org/show_bug.cgi?id=41250) The bindings tests
show us that the generated bindings are what we expect.

  • ForwardingHeaders/wtf/AVLTree.h: Added.
  • bindings/js/IDBBindingUtilities.cpp: Added. (WebCore::createIDBKeyFromValue):
  • bindings/js/IDBBindingUtilities.h: Added.
  • bindings/js/JSIDBKeyCustom.cpp: Added. (WebCore::toJS):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::idbKey):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_idb_key):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::): (WebCore::jsTestObjPrototypeFunctionIdbKey):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj idbKey:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::idbKeyCallback): (WebCore::):
  • bindings/v8/IDBBindingUtilities.cpp: Added. (WebCore::createIDBKeyFromValue):
  • bindings/v8/IDBBindingUtilities.h: Added.
  • bindings/v8/custom/V8IDBKeyCustom.cpp: Added. (WebCore::toV8):
  • storage/IDBCallbacks.h:
  • storage/IDBKey.cpp: Added. (WebCore::IDBKey::IDBKey): (WebCore::IDBKey::~IDBKey):
  • storage/IDBKey.h: Added. (WebCore::IDBKey::create): (WebCore::IDBKey::): (WebCore::IDBKey::type): (WebCore::IDBKey::string): (WebCore::IDBKey::number):
  • storage/IDBKey.idl: Added.
  • storage/IDBKeyTree.h: Added. (WebCore::IDBKeyTree::create): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_less): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_less): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_greater): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_greater): (WebCore::IDBKeyTree::AVLTreeAbstractor::get_balance_factor): (WebCore::IDBKeyTree::AVLTreeAbstractor::set_balance_factor): (WebCore::IDBKeyTree::AVLTreeAbstractor::null): (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_key_node): (WebCore::IDBKeyTree::AVLTreeAbstractor::compare_node_node): (WebCore::::IDBKeyTree): (WebCore::::~IDBKeyTree): (WebCore::::AVLTreeAbstractor::compare_key_key): (WebCore::::get): (WebCore::::insert): (WebCore::::remove):
14:57 Changeset [62451] by jhoneycutt@apple.com

The missing plug-in indicator should be clickable

https://bugs.webkit.org/show_bug.cgi?id=41550
<rdar://problem/8132162>

From an original patch by Kevin Decker.

Reviewed by Darin Adler.

WebCore:

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):
If the renderer is a RenderEmbeddedWidget showing the missing plug-in
indicator, and the event is a click even, call the ChromeClient's
missingPluginButtonClicked() function.

  • page/ChromeClient.h:

(WebCore::ChromeClient::missingPluginButtonClicked):
Declare missingPluginButtonClicked(), and stub the default
implementation.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
Initialize m_showsMissingPluginIndicator.
(WebCore::RenderEmbeddedObject::setShowsMissingPluginIndicator):
Assert that we're not currently showing any replacement text. Set
m_showsMissingPluginIndicator after setting the replacement text.
(WebCore::RenderEmbeddedObject::setShowsCrashedPluginIndicator):
Add the same assert as above.

  • rendering/RenderEmbeddedObject.h:

(WebCore::RenderEmbeddedObject::showsMissingPluginIndicator):
Getter for m_showsMissingPluginIndicator.

WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:

Declare an override of missingPluginButtonClicked().

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::missingPluginButtonClicked):
Call the UIDelegate's method.

  • WebView/WebUIDelegatePrivate.h:

Declare didPressMissingPluginButton.

WebKit/win:

  • Interfaces/IWebUIDelegatePrivate.idl:

Added a new delegate interface, and declare a function
didPressMissingPluginButton().

  • Interfaces/WebKit.idl:

Touch this file to force interfaces to be rebuilt.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::missingPluginButtonClicked):
Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its
didPressMissingPluginButton() function.

  • WebCoreSupport/WebChromeClient.h:

Declare an override of missingPluginButtonClicked().

14:36 Changeset [62450] by robert@webkit.org

2010-07-03 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()

Unskip fast/history/self-is-visited.html

https://bugs.webkit.org/show_bug.cgi?id=40445

  • platform/qt/Skipped:

2010-07-03 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()

Object property names such as 'background-color' need to be returned in camel
case, i.e. backgroundColor so that JS can reference them. Add support for this
to DumpRenderTreeSupportQt.

https://bugs.webkit.org/show_bug.cgi?id=40445

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (convertToPropertyName): (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
13:30 Changeset [62449] by oliver@apple.com

Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539

Reviewed by Geoffrey Garen.

JavaScriptCore:

Doing the BOM stripping in the lexer meant that we could
end up having to strip the BOMs from a source multiple times.
To deal with this we now require all strings provided by
a SourceProvider to already have had the BOMs stripped.
This also simplifies some of the lexer logic.

  • parser/Lexer.cpp:

(JSC::Lexer::setCode):
(JSC::Lexer::sourceCode):

  • parser/SourceProvider.h:

(JSC::SourceProvider::SourceProvider):
(JSC::UStringSourceProvider::create):
(JSC::UStringSourceProvider::getRange):
(JSC::UStringSourceProvider::UStringSourceProvider):

  • wtf/text/StringImpl.h:

(WebCore::StringImpl::copyStringWithoutBOMs):

WebCore:

Update WebCore to ensure that SourceProviders don't
produce strings with BOMs in them.

  • bindings/js/ScriptSourceProvider.h:

(WebCore::ScriptSourceProvider::ScriptSourceProvider):

  • bindings/js/StringSourceProvider.h:

(WebCore::StringSourceProvider::StringSourceProvider):

  • loader/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):
(WebCore::CachedScript::script):

  • loader/CachedScript.h:

(WebCore::CachedScript::):

CachedScript now stores decoded data with the BOMs stripped,
and caches the presence of BOMs across memory purges.

12:20 Changeset [62448] by xan@webkit.org

2010-07-03 Xan Lopez <xlopez@igalia.com>

Include DerivedSources/WebCore before DerivedSources/

Recently DerivedSources generation was changed, with some files no
longer being generated in the toplevel DerivedSources
directory. Since that directory is first in the -I flags the build
can be broken in some cases by including old files unless a 'make
clean' is done. Change the -I order to fix the build in the 32 bit
Release bot.

  • GNUmakefile.am:
07:08 Changeset [62447] by arv@chromium.org

2010-07-03 Erik Arvidsson <arv@chromium.org>

Reviewed by Ojan Vafai.

Fix issue where a contextmenu event was reporting the wrong target if
the context menu was shown due to pressing the context menu key
(or Shift+F10).

Split sendContextMenuForEvent into one case for keyboard events and use
that when the contextmenu event should be dispatched due to a keypress.

For the keboard case we now use the focused node as the target for the
event and use the clipped rect to determine the position of the menu.

https://bugs.webkit.org/show_bug.cgi?id=38129

Use manual test since DRT does not handle context menu keys.

  • manual-tests/win/contextmenu-key.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::sendContextMenuEventForKey):
  • page/EventHandler.h:

2010-07-03 Erik Arvidsson <arv@chromium.org>

Reviewed by Ojan Vafai.

Fix issue where a contextmenu event was reporting the wrong target
if the context menu was shown due to pressing the context menu key
(or Shift+F10).

https://bugs.webkit.org/show_bug.cgi?id=38129

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::sendContextMenuEvent):

2010-07-03 Erik Arvidsson <arv@chromium.org>

Reviewed by Ojan Vafai.

Fix issue where a contextmenu event was reporting the wrong target
if the context menu was shown due to pressing the context menu key
(or Shift+F10).

  • WebView.cpp: (WebView::handleContextMenuEvent):
05:03 Changeset [62446] by krit@webkit.org

2010-07-03 Dirk Schulze <krit@webkit.org>

Unreviewed sort of XCode project file.

  • WebCore.xcodeproj/project.pbxproj:
03:42 Changeset [62445] by robert@webkit.org

2010-07-03 Robert Hogan <robert@webkit.org>

[Qt] Update Qt expected results after r62444

Unreviewed, update test results.

http://trac.webkit.org/changeset/62444
https://bugs.webkit.org/show_bug.cgi?id=41088

Qt expected results for various fast/ tests updated to reflect
support for dumpChildFrameScrollPositions(). Checked against Mac results
and they are all good.

I have not updated the .png and .checksum files for the tests. This is
because I suspect I will not get the same pixel results as the Qt build
bot.

  • platform/qt/fast/dynamic/anchor-lock-expected.txt:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-tranformed-expected.txt:
  • platform/qt/fast/repaint/repaint-during-scroll-expected.txt:
  • platform/qt/transforms/2d/transform-fixed-container-expected.txt:
03:00 Changeset [62444] by robert@webkit.org

2010-07-03 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] support dumpChildFrameScrollPositions

https://bugs.webkit.org/show_bug.cgi?id=41088

Unskip:

http/tests/navigation/anchor-subframeload.html
http/tests/navigation/relativeanchor-frames.html

  • platform/qt/Skipped:

2010-07-03 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] support dumpChildFrameScrollPositions

https://bugs.webkit.org/show_bug.cgi?id=41088

Unskip:

http/tests/navigation/anchor-subframeload.html
http/tests/navigation/relativeanchor-frames.html

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dumpFrameScrollPosition): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::shouldDumpChildFrameScrollPositions): (LayoutTestController::dumpChildFrameScrollPositions):
01:45 Changeset [62443] by commit-queue@webkit.org

2010-07-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port Widget
https://bugs.webkit.org/show_bug.cgi?id=41538

Make Widget a dummy class. WebKit Brew MP uses the full screen mode
and does not use the window system introduced in Brew MP.

  • platform/Widget.h:
  • platform/brew/WidgetBrew.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect): (WebCore::Widget::setFocus): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected):
01:30 Changeset [62442] by commit-queue@webkit.org

2010-07-03 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kent Tamura.

[WINCE] Implement Unicode::isAlphanumeric and Unicode::isArabicChar.
https://bugs.webkit.org/show_bug.cgi?id=41411

  • wtf/unicode/wince/UnicodeWince.cpp: (WTF::Unicode::isAlphanumeric):
  • wtf/unicode/wince/UnicodeWince.h: (WTF::Unicode::isArabicChar):
01:17 Changeset [62441] by commit-queue@webkit.org

2010-07-03 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Change the CRASH() macro to print "WebKit CRASH" log.
https://bugs.webkit.org/show_bug.cgi?id=41524

Print "WebKit CRASH" before crashing.

  • wtf/Assertions.h:
00:17 Changeset [62440] by abarth@webkit.org

2010-07-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41560

It's somewhat hard to observe this state, so I'm not surprised that the
diff to the expected results are small. We still fail this test
because we don't handle whitespace correctly.

  • html5lib/runner-expected-html5.txt:

2010-07-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41560

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
00:03 Changeset [62439] by abarth@webkit.org

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41559

And the tests keep progressing.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement InFramesetMode
https://bugs.webkit.org/show_bug.cgi?id=41559

Pretty straighforward. We still don't handle character tokens
correctly.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):

07/02/10:

23:47 Changeset [62438] by abarth@webkit.org

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <frameset> InBody
https://bugs.webkit.org/show_bug.cgi?id=41558

Yay test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <frameset> InBody
https://bugs.webkit.org/show_bug.cgi?id=41558

Handling the <frameset> tag in the InBody mode is somewhat delicate.

  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::popHTMLBodyElement): (WebCore::HTMLElementStack::popUntil): (WebCore::HTMLElementStack::popCommon):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
23:45 Changeset [62437] by barraclough@apple.com

Bug 41565 - Repatching in ARMv7Assembler::repatchLoadPtrToLEA is broken

Reviewed by Oliver Hunt.

This method tried to repatch a LDR (T2) into an ADD (T3) - but it only
repatches the first instruction word. The layout of the fields in the
second word is different, and also needs repatching.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::repatchLoadPtrToLEA):

23:32 Changeset [62436] by abarth@webkit.org

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Special handling of <rp> and <rt> tags
https://bugs.webkit.org/show_bug.cgi?id=41557

There didn't seem to be test coverage of these cases in the suite, so I
added a couple tests.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Special handling of <rp> and <rt> tags
https://bugs.webkit.org/show_bug.cgi?id=41557

So sayeth the spec.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
23:20 Changeset [62435] by abarth@webkit.org

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement special optgroup processing
https://bugs.webkit.org/show_bug.cgi?id=41556

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement special optgroup processing
https://bugs.webkit.org/show_bug.cgi?id=41556

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
23:07 Changeset [62434] by abarth@webkit.org

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <image> in new parser
https://bugs.webkit.org/show_bug.cgi?id=41555

Test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <image> in new parser
https://bugs.webkit.org/show_bug.cgi?id=41555

This patch is kind of goofy but apparently how the world works.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::setName):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
22:42 Changeset [62433] by oliver@apple.com

Fix test to account for the arg count clamping we do with function.apply

21:52 Changeset [62432] by oliver@apple.com

Clamp the number of arguments supported by function.apply
https://bugs.webkit.org/show_bug.cgi?id=41351
<rdar://problem/8142141>

Reviewed by Gavin Barraclough.

JavaScriptCore:

Add clamping logic to function.apply similar to that
enforced by firefox. We have a smaller clamp than
firefox as our calling convention means that stack
usage is proportional to argument count -- the firefox
limit is larger than you could actually call.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Arguments.h:

(JSC::Arguments::):

LayoutTests:

Testcases.

  • fast/js/function-apply-many-args-expected.txt: Added.
  • fast/js/function-apply-many-args.html: Added.
  • fast/js/script-tests/function-apply-many-args.js: Added.
21:23 Changeset [62431] by commit-queue@webkit.org

2010-07-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Alexey Proskuryakov.

Remove extra semicolon at the end of HTMLTreeBuilder::attach
https://bugs.webkit.org/show_bug.cgi?id=41546

This is not critical, but the extra semicolon at the end of HTMLTreeBuilder::attach
causes a warning in RVCT.

  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::attach):
21:07 Changeset [62430] by commit-queue@webkit.org

2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Wrong method name in file Connection.h
https://bugs.webkit.org/show_bug.cgi?id=41536

Method openConnectionHandler was spelled as openConnection in class Connection.

  • Platform/CoreIPC/Connection.h:
20:53 Changeset [62429] by tonyg@chromium.org

2010-07-02 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Performance::disconnectFrame() needs to disconnect its children
https://bugs.webkit.org/show_bug.cgi?id=41533

No new tests because no new functionality.

  • page/Performance.cpp: (WebCore::Performance::disconnectFrame):
20:39 Changeset [62428] by commit-queue@webkit.org

2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Sam Weinig.

Adding notification and touch events methods to WebChromeClient
https://bugs.webkit.org/show_bug.cgi?id=41527

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::notificationPresenter): (WebKit::WebChromeClient::needTouchEvents):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
20:08 Changeset [62427] by commit-queue@webkit.org

2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Sam Weinig.

Checking if WTF_USE_JSC is defined before redefining it in config.h
https://bugs.webkit.org/show_bug.cgi?id=41530

  • config.h:
20:05 Changeset [62426] by pkasting@chromium.org

Unreviewed, test expectation update.

Mark a newly added test as crashing.

  • platform/chromium/test_expectations.txt:
19:46 Changeset [62425] by commit-queue@webkit.org

2010-07-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Sam Weinig.

Removing CoreFoundation.h include from WKFrame.h
https://bugs.webkit.org/show_bug.cgi?id=41528

  • UIProcess/API/C/WKFrame.h:
19:18 Changeset [62424] by tonyg@chromium.org

2010-07-02 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add vendor prefix to window.performance
https://bugs.webkit.org/show_bug.cgi?id=41525

No new tests because window.performance tests not landed yet.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitPerformance):
  • page/DOMWindow.h: (WebCore::DOMWindow::optionalWebkitPerformance):
  • page/DOMWindow.idl:
19:02 Changeset [62423] by zherczeg@webkit.org

2010-07-02 Zoltan Herczeg <zherczeg@webkit.org>

Reviewed by Oliver Hunt.

Minor fix: Diffuse constant is float (not integer)
https://bugs.webkit.org/show_bug.cgi?id=10412

  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
18:49 Changeset [62422] by commit-queue@webkit.org

2010-07-02 Chao-ying Fu <fu@mips.com>

Reviewed by Oliver Hunt.

Re-enable JIT_OPTIMIZE_NATIVE_CALL on MIPS
https://bugs.webkit.org/show_bug.cgi?id=40179

Add the MIPS part to re-enable JIT_OPTIMIZE_NATIVE_CALL.

  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTINativeCall):
  • wtf/Platform.h:
18:20 Changeset [62421] by crogers@google.com

Fixes to build for audio branch

18:20 Changeset [62420] by crogers@google.com

Generate bindings for AudioGainNode

17:28 Changeset [62419] by barraclough@apple.com

Bug 41552 - Clean up ARMv7 vfp code generation
Emit separate opcode individually, remove magic numbers.

Reviewed by Oliver Hunt.

Also remove invalid assert from JSImmediate (number cells are not CELL_MASK aligned).

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::vadd_F64):
(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcvt_F64_S32):
(JSC::ARMv7Assembler::vcvtr_S32_F64):
(JSC::ARMv7Assembler::vdiv_F64):
(JSC::ARMv7Assembler::vldr):
(JSC::ARMv7Assembler::vmov_F64_0):
(JSC::ARMv7Assembler::vmov):
(JSC::ARMv7Assembler::vmrs):
(JSC::ARMv7Assembler::vmul_F64):
(JSC::ARMv7Assembler::vstr):
(JSC::ARMv7Assembler::vsub_F64):
(JSC::ARMv7Assembler::VFPOperand::VFPOperand):
(JSC::ARMv7Assembler::VFPOperand::bits1):
(JSC::ARMv7Assembler::VFPOperand::bits4):
(JSC::ARMv7Assembler::vcvtOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpOp):
(JSC::ARMv7Assembler::ARMInstructionFormatter::vfpMemOp):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchDouble):

  • runtime/JSImmediate.h:

(JSC::JSValue::isCell):

17:11 Changeset [62418] by mrobinson@webkit.org

2010-07-02 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Build fix for GTK+. Try to force a rebuild of the HTMLNames.h
file first by touching HTMLTagNames.in.

  • html/HTMLTagNames.in:
17:08 Changeset [62417] by commit-queue@webkit.org

2010-07-02 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

Add test to verify proper clamping of RGB values.
https://bugs.webkit.org/show_bug.cgi?id=39482

Also unskip 3 canvas/philip tests that now pass.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#colors

  • fast/canvas/canvas-color-clamping-expected.txt: Added.
  • fast/canvas/canvas-color-clamping.html: Added.
  • fast/canvas/script-tests/canvas-color-clamping.js: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-02 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

RGB colors should be clamped to the 0-255 range
https://bugs.webkit.org/show_bug.cgi?id=39482

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#colors

Test: fast/canvas/canvas-color-clamping.html

  • css/CSSParser.cpp: (WebCore::parseColorInt): (WebCore::CSSParser::parseColor): (WebCore::parseColorIntFromValue): (WebCore::CSSParser::parseColorParameters):
16:49 Changeset [62416] by commit-queue@webkit.org

2010-07-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62410.
http://trac.webkit.org/changeset/62410
https://bugs.webkit.org/show_bug.cgi?id=41549

accursed last minute changes (Requested by olliej on #webkit).

  • parser/Lexer.cpp: (JSC::Lexer::setCode): (JSC::Lexer::copyCodeWithoutBOMs): (JSC::Lexer::sourceCode):
  • parser/SourceProvider.h: (JSC::): (JSC::SourceProvider::SourceProvider): (JSC::SourceProvider::hasBOMs): (JSC::UStringSourceProvider::create): (JSC::UStringSourceProvider::getRange): (JSC::UStringSourceProvider::UStringSourceProvider):
  • wtf/text/StringImpl.h:

2010-07-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62410.
http://trac.webkit.org/changeset/62410
https://bugs.webkit.org/show_bug.cgi?id=41549

accursed last minute changes (Requested by olliej on #webkit).

  • bindings/js/ScriptSourceProvider.h: (WebCore::ScriptSourceProvider::ScriptSourceProvider):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::StringSourceProvider):
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::script):
  • loader/CachedScript.h:
16:46 Changeset [62415] by weinig@apple.com

Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.

Reviewed by Anders Carlsson.

  • Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
  • Scripts/debug-webkittestrunner: Removed.
  • Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
  • Scripts/run-webkittestrunner: Removed.
16:26 Changeset [62414] by weinig@apple.com

Patch for https://bugs.webkit.org/show_bug.cgi?id=41548
Use snprintf instead of sprintf everywhere in JavaScriptCore

Reviewed by Geoffrey Garen.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::globalFuncEscape):

  • runtime/UString.cpp:

(JSC::UString::from):

16:15 Changeset [62413] by mrobinson@webkit.org

2010-07-02 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Further Build fix for GTK+. Also include HTMLElementFactory.h in
the list of dependencies.

  • GNUmakefile.am:
16:11 Changeset [62412] by mrobinson@webkit.org

2010-07-02 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Build fix for GTK+. *Names.{cpp,h} targets should now include the
header files. Also adds the header files to the generated sources list.

  • GNUmakefile.am:
15:50 Changeset [62411] by dumi@chromium.org

WebCore: DB clean up.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

  1. Made all DatabaseTasks internal classes of Database and made the Database methods called by those tasks private.
  2. Removed the Database::stop{ed}() methods.
  3. Removed the code that kept track of open databases from ScriptExecutionContext (no longer needed).
  4. Made minor changes to Database::closeImmediately() to make it possible for DatabaseThread to call that method instead of close().
  5. Minor fix to DatabaseTracker: addOpenDatabase() should call OriginQuotaManager::addDatabase() if the origin quota manager is not tracking this origin.
  6. Removed Database::performPolicyChecks(). We already update the DB size after each transaction, and we enforce a max size for the DB at the beginning of each transaction.
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::stopDatabases):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::hasOpenDatabases):

  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::close):
(WebCore::Database::closeImmediately):

  • storage/Database.h:
  • storage/DatabaseTask.cpp:

(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):
(WebCore::Database::DatabaseOpenTask::debugTaskName):
(WebCore::Database::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::Database::DatabaseCloseTask::doPerformTask):
(WebCore::Database::DatabaseCloseTask::debugTaskName):
(WebCore::Database::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::Database::DatabaseTransactionTask::doPerformTask):
(WebCore::Database::DatabaseTransactionTask::debugTaskName):
(WebCore::Database::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::Database::DatabaseTableNamesTask::doPerformTask):
(WebCore::Database::DatabaseTableNamesTask::debugTaskName):

  • storage/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
(WebCore::Database::DatabaseCloseTask::create):
(WebCore::Database::DatabaseTransactionTask::create):
(WebCore::Database::DatabaseTableNamesTask::create):

  • storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):

LayoutTests: Minor change to a DB test to make it run correctly with run-webkit-tests --iterations N.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

  • storage/open-database-creation-callback.html:
15:31 Changeset [62410] by oliver@apple.com

2010-07-02 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539

Doing the BOM stripping in the lexer meant that we could
end up having to strip the BOMs from a source multiple times.
To deal with this we now require all strings provided by
a SourceProvider to already have had the BOMs stripped.
This also simplifies some of the lexer logic.

  • parser/Lexer.cpp: (JSC::Lexer::setCode): (JSC::Lexer::sourceCode):
  • parser/SourceProvider.h: (JSC::SourceProvider::SourceProvider): (JSC::UStringSourceProvider::create): (JSC::UStringSourceProvider::getRange): (JSC::UStringSourceProvider::UStringSourceProvider):
  • wtf/text/StringImpl.h: (WebCore::StringImpl::copyStringWithoutBOMs):

2010-07-02 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Move BOM handling out of the lexer and parser
https://bugs.webkit.org/show_bug.cgi?id=41539

Update WebCore to ensure that SourceProviders don't
produce strings with BOMs in them.

  • bindings/js/ScriptSourceProvider.h: (WebCore::ScriptSourceProvider::ScriptSourceProvider):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::StringSourceProvider):
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::script):
  • loader/CachedScript.h: (WebCore::CachedScript::): CachedScript now stores decoded data with the BOMs stripped, and caches the presence of BOMs across memory purges.
15:18 Changeset [62409] by dglazkov@chromium.org

2010-07-02 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Provide new expectations for ports that don't handle "Enter-on-select" in the same way as Safari.
https://bugs.webkit.org/show_bug.cgi?id=39532

  • platform/chromium-win/fast/forms/implicit-submission-expected.txt: Added.
  • platform/gtk/Skipped: Unskipped the test.
  • platform/gtk/fast/forms/implicit-submission-expected.txt: Added.
  • platform/qt/Skipped: Unskipped the test.
  • platform/qt/fast/forms/implicit-submission-expected.txt: Added.
15:03 Changeset [62408] by zmo@google.com

Reviewed by David Levin.

fast/canvas/webgl/program-test.html failed on leopard bot
https://bugs/webkit.org/show_bug.cgi?id=41542

  • platform/mac-leopard/Skipped: Skip the failing test for now.
14:58 Changeset [62407] by weinig@apple.com

Add missing symbol to exports file.

  • WebCore.base.exp:
14:54 Changeset [62406] by weinig@apple.com

Patch for https://bugs.webkit.org/show_bug.cgi?id=41540
WebKit2: Add InjectedCode API to get a list of subframes

Reviewed by Oliver Hunt.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyChildFrames):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::childFrameRef):
(WebKit::childFrameDeref):
(WebKit::WebFrame::childFrames):

  • WebProcess/WebPage/WebFrame.h:
  • mac/WebKit2.exp:
14:34 Changeset [62405] by ggaren@apple.com

[ Updated after rollout. ]

Patch by Renata Hodovan <reni@inf.u-szeged.hu> on 2010-07-02
Reviewed by Oliver Hunt.

Merged RegExp constructor and RegExp::create methods.
Both functions are called with three parameters and check whether
flags (the third param) is given or not.
Avoid extra hash lookups in RegExpCache::create by passing a pre-computed
iterator parameter.
https://bugs.webkit.org/show_bug.cgi?id=41055

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):

  • runtime/RegExp.h:
  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):

  • runtime/RegExpCache.h:
14:31 Changeset [62404] by mrowe@apple.com

Versioning.

14:29 Changeset [62403] by mrowe@apple.com

New tag.

14:11 Changeset [62402] by bweinstein@apple.com

Update some Windows layout test results after r62215 - adding the .dataset
DOM property.

Rubber-stamped by Anders Carlsson.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
13:43 Changeset [62401] by dglazkov@chromium.org

2010-07-02 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, expectations update.

Add fast/forms/implicit-submission.html to Gtk and Qt Skipped list,
because their behaviors are platform-specific and don't match
expected results.
https://bugs.webkit.org/show_bug.cgi?id=39532

  • platform/gtk/Skipped: Added fast/forms/implicit-submission.html.
  • platform/qt/Skipped: Ditto.
13:39 Changeset [62400] by bweinstein@apple.com

Some http tests fail on Windows with Cygwin 1.7
https://bugs.webkit.org/show_bug.cgi?id=41537

Reviewed by Steve Falkenburg.

With Cygwin 1.7, the registry key at SOFTWARE
Cygnus Solutions
Cygwin
mounts v2
/
doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
just need root mount point, which is defined in SOFTWARE
Cygwin
setup.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(resolveCygwinPath): Fall back to SOFTWARE
Cygwin
setup if

SOFTWARE
Cygnus Solutions
Cygwin
mounts v2
/ doesn't work.

12:51 Changeset [62399] by jschuh@chromium.org

2010-07-02 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Fisher.

Remove the extra setFailed() call in JPEG decoder to prevent
re-using an already freed object.
https://bugs.webkit.org/show_bug.cgi?id=41487

Test: fast/images/large-size-image-crash.html

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):

2010-07-02 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Fisher.

Tests that images with large width and height values do not result in crash.
Skip layout test for mac and win since it needs to be fixed at image decoder layer for Safari.
https://bugs.webkit.org/show_bug.cgi?id=41487

  • fast/images/large-size-image-crash-expected.txt: Added.
  • fast/images/large-size-image-crash.html: Added.
  • fast/images/resources/large-size-image-crash.jpeg: Added.
  • platform/mac/Skipped:
  • platform/win/Skipped:
12:45 Changeset [62398] by commit-queue@webkit.org

2010-07-02 Peter Beverloo <peter@lvp-media.com>

Reviewed by Maciej Stachowiak.

Add the HTML5 <mark> element. Text content of the element will have
a yellow background color and black text.

Tests for <p> closing, phrasing child content and residual style.

  • fast/html/mark-element-expected.txt: Added.
  • fast/html/mark-element.html: Added.
  • fast/html/script-tests/mark-element.js: Added.

2010-07-02 Peter Beverloo <peter@lvp-media.com>

Reviewed by Maciej Stachowiak.

Add the HTML5 <mark> element. Text content of the element will have
a yellow background color and black text.

Test: fast/html/mark-element.html
Tests for <p> closing, phrasing child content and residual style.

  • css/html.css: (mark):
  • html/HTMLElement.cpp: (WebCore::inlineTagList):
  • html/HTMLTagNames.in:
  • html/LegacyHTMLTreeBuilder.cpp: (WebCore::LegacyHTMLTreeBuilder::getNode): (WebCore::LegacyHTMLTreeBuilder::isInline): (WebCore::LegacyHTMLTreeBuilder::isResidualStyleTag):
12:24 Changeset [62397] by zmo@google.com

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix issues in boundary situations for WebGLRenderingContext::drawArrays/drawElements
https://bugs.webkit.org/show_bug.cgi?id=41473

  • fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt: Test against overflow, size-0 buffer, and count==0 situations.
  • fast/canvas/webgl/draw-arrays-out-of-bounds.html: Ditto.
  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Ditto.
  • fast/canvas/webgl/draw-elements-out-of-bounds.html: Ditto.

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Fix issues in boundary situations for WebGLRenderingContext::drawArrays/drawElements
https://bugs.webkit.org/show_bug.cgi?id=41473

  • WebCore.gypi: Add CheckedInt.h.
  • WebCore.xcodeproj/project.pbxproj: Add CheckedInt.h.
  • html/canvas/CheckedInt.h: Added support of safe integer operations. (mozilla::CheckedInt_internal::integer_type_manually_recorded_info::): (mozilla::CheckedInt_internal::is_unsupported_type::): (mozilla::CheckedInt_internal::): (mozilla::CheckedInt_internal::integer_traits::): (mozilla::CheckedInt_internal::integer_traits::min): (mozilla::CheckedInt_internal::integer_traits::max): (mozilla::CheckedInt_internal::has_sign_bit): (mozilla::CheckedInt_internal::binary_complement): (mozilla::CheckedInt_internal::is_in_range): (mozilla::CheckedInt_internal::is_add_valid): (mozilla::CheckedInt_internal::is_sub_valid): (mozilla::CheckedInt_internal::is_mul_valid): (mozilla::CheckedInt_internal::is_div_valid): (mozilla::CheckedInt::CheckedInt): (mozilla::CheckedInt::value): (mozilla::CheckedInt::valid): (mozilla::CheckedInt::operator -): (mozilla::CheckedInt::operator ==): (mozilla::CheckedInt::operator !=): (mozilla::operator /): (mozilla::cast_to_CheckedInt_impl::run): (mozilla::): (mozilla::cast_to_CheckedInt): (mozilla::operator ==):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateIndexArrayConservative): Fix a bug against 0-size buffer situation. (WebCore::WebGLRenderingContext::drawArrays): Deal with overflows and count==0 situation. (WebCore::WebGLRenderingContext::drawElements): Deal with count==0 situation.
12:06 Changeset [62396] by zmo@google.com

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

linkProgram should fail when vertex/fragment shaders are not both present
https://bugs.webkit.org/show_bug.cgi?id=41380

  • fast/canvas/webgl/program-test-expected.txt: Added.
  • fast/canvas/webgl/program-test.html: Added.

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

linkProgram should fail when vertex/fragment shaders are not both present
https://bugs.webkit.org/show_bug.cgi?id=41380

Test: fast/canvas/webgl/program-test.html

  • html/canvas/WebGLProgram.cpp: Add flag for link failure due to missing shaders. (WebCore::WebGLProgram::WebGLProgram):
  • html/canvas/WebGLProgram.h: Add interface for linkFailure flag. (WebCore::WebGLProgram::isLinkFailureFlagSet): (WebCore::WebGLProgram::setLinkFailureFlag):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getProgramParameter): Intercept when linkFailureFlag is set. (WebCore::WebGLRenderingContext::linkProgram): Check if there are missing shaders and don't link if yes.
  • html/canvas/WebGLShader.cpp: Cache shader type. (WebCore::WebGLShader::WebGLShader):
  • html/canvas/WebGLShader.h: Ditto. (WebCore::WebGLShader::getType):
12:00 Changeset [62395] by weinig@apple.com

Turn off the Objective-C garbage collection for the WebProcess.

Reviewed by Anders Carlsson.

  • Configurations/WebProcess.xcconfig:
  • WebProcess/Launching/mac/WebProcessMain.mm:

(main): Assert that GC is off.

11:54 CodeReview created by ojan@chromium.org
11:47 Changeset [62394] by commit-queue@webkit.org

2010-07-02 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Failed on http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.negativesource.html

Remove the following test case from Skipped:
canvas/philip/tests/2d.drawImage.negativedest.html
canvas/philip/tests/2d.drawImage.negativedir.html
canvas/philip/tests/2d.drawImage.negativesource.html

  • platform/qt/Skipped:

2010-07-02 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Failed on http://philip.html5.org/tests/canvas/suite/tests/2d.drawImage.negativesource.html

Support negative width and height in canvas image draw

  • platform/graphics/FloatRect.h:
  • platform/graphics/qt/FloatRectQt.cpp: (WebCore::FloatRect::normalized):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
11:43 Changeset [62393] by weinig@apple.com

There is no longer a reason to check that the process is valid when posting
a message to the bundle, the process code will take care of that for us.

Reviewed by Anders Carlsson.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::postMessageToInjectedBundle):

11:42 WikiStart edited by ojan@chromium.org
(diff)
11:42 Changeset [62392] by weinig@apple.com

Use send instead of connection()->send(), now that connections() are created
asynchronously it can be null at this point and the message needs to be queued.

Reviewed by Anders Carlsson.

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::setUpAcceleratedCompositing):

11:06 Changeset [62391] by dglazkov@chromium.org

2010-06-24 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION: Enter does not trigger submit of forms when focus is on select.
https://bugs.webkit.org/show_bug.cgi?id=39532

  • fast/forms/implicit-submission-expected.txt: Updated.
  • fast/forms/implicit-submission.html: Added more test coverage for selects.

2010-06-24 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION: Enter does not trigger submit of forms when focus is on select.
https://bugs.webkit.org/show_bug.cgi?id=39532

Restore behavior where hitting "Enter" on a select element attempts to submit
form implicitly.

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler): Added htmlForm argument,

and attempting to submit implicitly.

(WebCore::SelectElement::listBoxDefaultEventHandler): Ditto.
(WebCore::SelectElement::defaultEventHandler): Plumbed through htmlForm argument.

  • dom/SelectElement.h: Added htmlForm argument to method declaration.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): Changed to provide submitting form

as the argument.

10:30 Changeset [62390] by tkent@chromium.org

2010-07-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support indeterminate checkbox for Linux, and a small fix for Windows
https://bugs.webkit.org/show_bug.cgi?id=41508

  • platform/chromium/test_expectations.txt: fast/forms/indeterminate.html fails temporarily.

2010-07-02 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support indeterminate checkbox for Linux, and a small fix for Windows
https://bugs.webkit.org/show_bug.cgi?id=41508

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintCheckbox): Use dedicated images for indeterminate states.
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineClassicState): Do not use DFCS_CHECKED in a case of indeterminate state in order to have consistent appearance of indeterminate checkbox.
10:21 Changeset [62389] by mrobinson@webkit.org

2010-07-02 Martin Robinson <mrobinson@igalia.com>

Unreviewed. Build fix for GTK+.

Build Lexer.lut.h with the rest of the .lut.h files. Later these should
all probably be moved to DerivedSources.

  • GNUmakefile.am:
10:14 Changeset [62388] by bfulgham@webkit.org

Fixes https://bugs.webkit.org/show_bug.cgi?id=41323.
Provides an implementation of the 'squiggle' used for
bad grammar or spelling, based on the Pango logic used
by the GTK builds.

Reviewed by Gustavo Noronha Silva.

No new tests. Covered by LayoutTests/editing/spelling

  • WebCore.vcproj/WebCore.vcproj: Add new file holding underline

implementation, set to build only for WinCairo port.

  • platform/graphics/cairo/DrawErrorUnderline.cpp: Added.

(drawErrorUnderline): New file containing the squiggle drawing
logic based on the Pango implementation. Placed in its own file
to isolate licenses.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
Have WinCairo build call new 'drawErrorUnderline' implementation.

09:53 Changeset [62387] by mrobinson@webkit.org

2010-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109

Separate WebKitGTK+ DerivedSources into per-project subdirectories to prepare
for properly building WebKit2.

  • GNUmakefile.am:

2010-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109

Generate JavaScriptCore derived sources in <builddir>/DerivedSources/JavaScriptCore.

  • GNUmakefile.am:

2010-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109

Generate WebCore derived sources in <builddir>/DerivedSources/WebCore.

  • GNUmakefile.am:

2010-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109

Separate WebKitGTK+ DerivedSources into per-project subdirectories to prepare
for properly building WebKit2.

  • webkitmarshal.list: Touch this file to force a rebuild of the marshaling code.

2010-06-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Separate DerivedSources per-project
https://bugs.webkit.org/show_bug.cgi?id=41109

The JavaScriptCore cppflags used to include the top-level DerivedSources directory
allowing the tools to build as a side-effect. Now that the top-level directory
is no longer in the list of JavaScriptCore includes, include it explicitly.

  • GNUmakefile.am:
09:45 Changeset [62386] by ddkilzer@apple.com

2010-07-02 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

The alternativeFrameLocation value is wrong in the emitDisjunction function in
case of PatternTerm::TypeParentheticalAssertion. This value needs to be
computed from term.frameLocation instead of term.inputPosition. This mistake caused glibc
memory corruption in some cases.
Layout test added for checking of TypeParentheticalAssertion case.
https://bugs.webkit.org/show_bug.cgi?id=41458

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::ByteCompiler::emitDisjunction):

2010-07-02 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

The alternativeFrameLocation value is wrong in the emitDisjunction function in
case of PatternTerm::TypeParentheticalAssertion. This value needs to be
computed from term.frameLocation instead of term.inputPosition. This mistake caused glibc
memory corruption in some cases.
Layout test added for checking of TypeParentheticalAssertion case.
https://bugs.webkit.org/show_bug.cgi?id=41458

  • fast/js/regexp-look-ahead-expected.txt: Added.
  • fast/js/regexp-look-ahead.html: Added.
  • fast/js/script-tests/regexp-look-ahead.js: Added.
09:35 Changeset [62385] by zmo@google.com

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Implement OpenGL ES 2.0 semantics for vertex attribute 0
https://bugs.webkit.org/show_bug.cgi?id=41300

  • fast/canvas/webgl/gl-bind-attrib-location-test-expected.txt: Added.
  • fast/canvas/webgl/gl-bind-attrib-location-test.html: Added.
  • fast/canvas/webgl/gl-vertex-attrib-expected.txt: Added.
  • fast/canvas/webgl/gl-vertex-attrib.html: Added.

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Implement OpenGL ES 2.0 semantics for vertex attribute 0
https://bugs.webkit.org/show_bug.cgi?id=41300

Test: fast/canvas/webgl/gl-bind-attrib-location-test.html

fast/canvas/webgl/gl-vertex-attrib.html

  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::numActiveAttribLocations): const. (WebCore::WebGLProgram::getActiveAttribLocation): const. (WebCore::WebGLProgram::isUsingVertexAttrib0): Determine whether vertex attrib 0 is used by the program.
  • html/canvas/WebGLProgram.h: Declare isUsingVertexAttrib0.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Deal with vertex attrib 0. (WebCore::WebGLRenderingContext::disableVertexAttribArray): Ditto. (WebCore::WebGLRenderingContext::drawArrays): Ditto. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::getVertexAttrib): Use cached value instead of calling glGetVertexAtrtrib. (WebCore::WebGLRenderingContext::vertexAttrib1f): Validate input, deal with vertex attrib 0. (WebCore::WebGLRenderingContext::vertexAttrib1fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib2f): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib2fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib3f): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib3fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib4f): Ditto. (WebCore::WebGLRenderingContext::vertexAttrib4fv): Ditto. (WebCore::WebGLRenderingContext::vertexAttribPointer): Ditto. (WebCore::WebGLRenderingContext::handleNPOTTextures): Move isGLES2Compliant() to caller. (WebCore::WebGLRenderingContext::vertexAttribImpl): Helper for vertexAttribNfv. (WebCore::WebGLRenderingContext::initVertexAttrib0): Initialize vertex attrib 0. (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Simulate vertex attrib 0. (WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulation): Restore states after simulating vertex attrib 0.
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState): Tracking full vertex attrib states. (WebCore::WebGLRenderingContext::VertexAttribState::initValue): Init value to [0,0,0,1].
09:20 Changeset [62384] by zmo@google.com

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Need to validate the size of the incoming arrays for uniform* functions
https://bugs.webkit.org/show_bug.cgi?id=41383

  • fast/canvas/webgl/gl-uniform-arrays-expected.txt: Test against invalid array size.
  • fast/canvas/webgl/gl-uniform-arrays.html: Ditto.
  • fast/canvas/webgl/gl-uniformmatrix4fv-expected.txt: Ditto.
  • fast/canvas/webgl/gl-uniformmatrix4fv.html: Ditto.

2010-07-02 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Need to validate the size of the incoming arrays for uniform* functions
https://bugs.webkit.org/show_bug.cgi?id=41383

  • html/canvas/WebGLRenderingContext.cpp: Validate input array size. (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::validateUniformParameters): (WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
  • html/canvas/WebGLRenderingContext.h: Add helper functions.
08:15 Changeset [62383] by vestbo@webkit.org

[Qt] Canvas arcTo() should draw straight line to p1 if p0, p1 and p2 are collinear

Reviewed by Simon Hausmann.

The implementation of PathQt's addArcTo() was not float-safe and also had
a case where it drew an 'infinite' line, which is not part of the spec.

http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arcto

We now use qFuzzyCompare() in both cases. The method isPointOnPathBorder()
also had the same problem, and was refactored a bit in the process of fixing
the bug.

Initial patch by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=41412

07:11 Changeset [62382] by commit-queue@webkit.org

2010-07-02 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Compilation fix.

QScriptEnginePrivate::newArray can't be const because it can
throw an exception.

[Qt] QScriptEnginePrivate compilation fix
https://bugs.webkit.org/show_bug.cgi?id=41520

  • api/qscriptengine_p.cpp: (QScriptEnginePrivate::newArray):
  • api/qscriptengine_p.h:
06:56 Changeset [62381] by yurys@chromium.org

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline html5lib/runner.html on Chromium Mac.

  • platform/chromium-mac/html5lib/runner-expected.txt:
04:43 Changeset [62380] by yurys@chromium.org

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41511

  • fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
  • fast/events/popup-blocked-from-fake-user-gesture.html: Added.
  • http/tests/inspector/change-iframe-src-expected.txt: Added.
  • http/tests/inspector/change-iframe-src.html: Added.

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41511

Tests: fast/events/popup-blocked-from-fake-user-gesture.html

http/tests/inspector/change-iframe-src.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): use V8Proxy from the ScriptController instead of one from the call stack. Get event directly from hidden property to avoid unnecessary checks.
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::eventAccessorGetter): (WebCore::V8DOMWindow::eventAccessorSetter):

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41511

  • src/WebBindings.cpp: (WebKit::getEvent):
04:36 Changeset [62379] by yurys@chromium.org

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline html5lib/runner.html

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
03:47 QtWebKitBugs edited by hausmann@webkit.org
(diff)
03:43 QtWebKitTriageRoster edited by hausmann@webkit.org
(diff)
03:38 Changeset [62378] by abarth@webkit.org

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix tokenization of <!----->
https://bugs.webkit.org/show_bug.cgi?id=41505

Test progression plus reduced test case.

  • html5lib/resources/comments01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix tokenization of <!----->
https://bugs.webkit.org/show_bug.cgi?id=41505

I noticed this error when browsing through the HTML5lib failures.
We're adding an extra character to the comment token, contrary to what
the spec says to do.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
03:37 Changeset [62377] by hausmann@webkit.org

Implement exception reporting in the QtScript API.

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2010-06-28
Reviewed by Simon Hausmann.

The exception should be accessible through the API by the uncaughtException
function. Functions; hasUncaughtException, clearExceptions, uncaughtExceptionLineNumber,
uncaughtExceptionBacktrace were added to facilitate error checking and debugging.

[Qt] QtScript API should be exceptions aware.
https://bugs.webkit.org/show_bug.cgi?id=41199

  • api/qscriptengine.cpp:

(QScriptEngine::hasUncaughtException):
(QScriptEngine::uncaughtException):
(QScriptEngine::clearExceptions):
(QScriptEngine::uncaughtExceptionLineNumber):
(QScriptEngine::uncaughtExceptionBacktrace):

  • api/qscriptengine.h:
  • api/qscriptengine_p.cpp:

(QScriptEnginePrivate::QScriptEnginePrivate):
(QScriptEnginePrivate::~QScriptEnginePrivate):
(QScriptEnginePrivate::uncaughtException):

  • api/qscriptengine_p.h:

(QScriptEnginePrivate::):
(QScriptEnginePrivate::evaluate):
(QScriptEnginePrivate::hasUncaughtException):
(QScriptEnginePrivate::clearExceptions):
(QScriptEnginePrivate::setException):
(QScriptEnginePrivate::uncaughtExceptionLineNumber):
(QScriptEnginePrivate::uncaughtExceptionBacktrace):

  • api/qscriptvalue_p.h:

(QScriptValuePrivate::toString):
(QScriptValuePrivate::toNumber):
(QScriptValuePrivate::toObject):
(QScriptValuePrivate::equals):
(QScriptValuePrivate::instanceOf):
(QScriptValuePrivate::call):
(QScriptValuePrivate::inherits):

  • tests/qscriptengine/tst_qscriptengine.cpp:

(tst_QScriptEngine::uncaughtException):

03:26 Changeset [62376] by abarth@webkit.org

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement processFakePEndTagIfPInScope
https://bugs.webkit.org/show_bug.cgi?id=41503

See test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement processFakePEndTagIfPInScope
https://bugs.webkit.org/show_bug.cgi?id=41503

This is a common idiom because <p> likes to close itself.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processFakePEndTagIfPInScope): (WebCore::HTMLTreeBuilder::processStartTag):
  • html/HTMLTreeBuilder.h:
03:14 Changeset [62375] by abarth@webkit.org

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterAfterBodyMode
https://bugs.webkit.org/show_bug.cgi?id=41501

The AfterAfterBodyMode doesn't seem to be well-covered by the existing
HTML5lib tests, so I added a few more tests to cover it. It's somewhat
hard to observe. The only way I can figure out to observe it is where
the comment elements get attached to the DOM.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterAfterBodyMode
https://bugs.webkit.org/show_bug.cgi?id=41501

In implementing this mode, I noticed a bug in the character processing
of the AfterBodyMode, which I fixed by adding a break statement. Also,
to get one of the new tests to pass, I needed to implement one
notImplemented() in the InBody insertion mode. Yay for testing.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile):
03:02 Changeset [62374] by commit-queue@webkit.org

2010-07-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62371.
http://trac.webkit.org/changeset/62371
https://bugs.webkit.org/show_bug.cgi?id=41515

"Breaks media/controls-drag-timebar.html on 32-Bit Release"
(Requested by philn-tp on #webkit).

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::updateStates):
02:51 QtWebKitWeeklyBuilds edited by hausmann@webkit.org
(diff)
02:49 QtWebKitWeeklyBuilds edited by hausmann@webkit.org
(diff)
02:42 QtWebKitJournal edited by hausmann@webkit.org
(diff)
02:42 QtWebKitWeeklyBuilds created by hausmann@webkit.org
02:42 QtWebKitJournal edited by hausmann@webkit.org
(diff)
02:36 Changeset [62373] by yurys@chromium.org

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Remove accidentally added expectations on Chromium Linux - they should be derived from Windows ones.

  • platform/chromium-linux/html5lib/runner-expected.txt: Removed.
02:29 Changeset [62372] by yurys@chromium.org

2010-07-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-linux/html5lib/runner-expected.txt: Added.
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium/test_expectations.txt:
01:48 Changeset [62371] by philn@webkit.org

2010-06-28 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GStreamer] can't seek past maxTimeLoaded value
https://bugs.webkit.org/show_bug.cgi?id=40526

Extended the seekable range to the whole media. This allows video
played with progressive download to be seeked past the current
buffered position.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable): (WebCore::MediaPlayerPrivateGStreamer::updateStates):
01:29 Changeset [62370] by abarth@webkit.org

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterBodyMode for HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=41500

Update expected results to show test progression. Also, add some test
cases to cover how attributes on </br> tags are handled.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement AfterBodyMode for HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=41500

In the coarse of implementing this state, I ran into an ASSERT in how
</br> tags where handled, which I fixed. Technically, that could be a
separate patch, but it seemed harmless to include it here (with tests).

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::insertCommentOnHTMLHtmlElement):
  • html/HTMLTreeBuilder.h:
01:14 Changeset [62369] by abarth@webkit.org

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <base> and friends in AfterHeadMode
https://bugs.webkit.org/show_bug.cgi?id=41502

See test progression. Fun game.

  • html5lib/runner-expected-html5.txt:

2010-07-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Handle <base> and friends in AfterHeadMode
https://bugs.webkit.org/show_bug.cgi?id=41502

Implement notImplemented() per spec.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):

07/01/10:

23:47 Changeset [62368] by oliver@apple.com

Chromium build fix.

23:31 Changeset [62367] by oliver@apple.com

2010-07-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
https://bugs.webkit.org/show_bug.cgi?id=41506

This new type is used in place of fixed length C arrays so
that debug builds can guard against attempts to go beyond
the end of the array.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Opcode.cpp: (JSC::OpcodeStats::~OpcodeStats):
  • pcre/pcre_compile.cpp: (calculateCompiledPatternLength):
  • runtime/Collector.cpp: (JSC::Heap::allocateBlock): (JSC::Heap::allocate):
  • runtime/Collector.h: (JSC::CollectorBitmap::clearAll):
  • runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::operator*):
  • runtime/DateInstanceCache.h:
  • runtime/JSString.cpp: (JSC::JSString::replaceCharacter):
  • runtime/JSString.h: (JSC::RopeBuilder::JSStringFinalizerStruct::):
  • runtime/NumericStrings.h:
  • runtime/RegExpCache.h:
  • runtime/SmallStrings.h: (JSC::SmallStrings::singleCharacterStrings):
  • wtf/AVLTree.h:
  • wtf/FixedArray.h: Added. (WTF::FixedArray::operator[]): (WTF::FixedArray::data):

2010-07-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
https://bugs.webkit.org/show_bug.cgi?id=41506

Add forwarding header.

  • ForwardingHeaders/wtf/FixedArray.h: Added.

2010-07-01 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Add a FixedArray template to encapsulate fixed length arrays
https://bugs.webkit.org/show_bug.cgi?id=41506

Add forwarding header, and replace a few fixed length arrays
with the new FixedArray type.

  • ForwardingHeaders/wtf/FixedArray.h: Added.
  • dom/Document.h:
  • platform/graphics/GlyphMetricsMap.h:
23:17 Changeset [62366] by zherczeg@webkit.org

Improve the main lexer switch by mapping input characters to their type
https://bugs.webkit.org/show_bug.cgi?id=41459

Reviewed by Oliver Hunt.

Sunsipder: no change (from 532.9ms to 531.5ms)
SunSpider --parse-only: 1.025x as fast (from 33.1ms to 32.3ms)

  • parser/Lexer.cpp:

(JSC::):
(JSC::Lexer::lex):

23:04 Changeset [62365] by sfalken@apple.com

Provide a WebView preference to disable DNS prefetching on Windows
https://bugs.webkit.org/show_bug.cgi?id=41504
<rdar://problem/8151939>

Reviewed by Adele Peterson.

  • Interfaces/IWebPreferencesPrivate.idl: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
  • Interfaces/WebKit.idl: Touched to force IDL build.
  • WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Default prefetch to true.
(WebPreferences::setDNSPrefetchingEnabled): Added.
(WebPreferences::isDNSPrefetchingEnabled): Added.

  • WebPreferences.h: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Propagate prefetch pref into settings.

22:16 Changeset [62364] by simon.fraser@apple.com

2010-07-01 Simon Fraser <simon.fraser@apple.com>

No review.

Fix a link warning in 32-bit by not explicitly exporting WebCore::GraphicsLayer::syncCompositingStateForThisLayerOnly().

  • WebCore.AcceleratedCompositing.exp:
22:06 Changeset [62363] by sfalken@apple.com

Even more Windows build fixing.
Removed bogus post-build event commands.
Removed unnecessary link libraries.

  • win/WebKit2.vcproj:
21:58 Changeset [62362] by sfalken@apple.com

Fix Windows while not breaking Qt (didn't realize this was building for Qt).

  • WebProcess/WebProcess.cpp:
21:54 Changeset [62361] by simon.fraser@apple.com

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/8154047>

Update WebKitSystemInterface, making some functions used by
WebKit2 available in 32-bit (for reals this time).

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
21:52 Changeset [62360] by sfalken@apple.com

Windows build fix.

  • win/WebKit2Generated.make:
21:31 Changeset [62359] by sfalken@apple.com

Windows build fix.

  • WebProcess/WebProcess.cpp:
21:21 Changeset [62358] by weinig@apple.com

Make WebKit2 compile (though not work) on Leopard.

Reviewed by Jon Honeycutt.

  • Platform/WorkQueue.h:
  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::EventSource::EventSource):
(WorkQueue::scheduleWork):
(WorkQueue::registerMachPortEventHandler):
(WorkQueue::unregisterMachPortEventHandler):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):

  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:

(WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::setUpAcceleratedCompositing):

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
(WebKit::LayerBackedDrawingArea::setNeedsDisplay):

  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:

(WebKit::LayerBackedDrawingArea::platformClear):
(WebKit::LayerBackedDrawingArea::attachCompositingContext):

21:18 Changeset [62357] by tonyg@chromium.org

2010-07-01 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Add window.performance.navigation namespace
https://bugs.webkit.org/show_bug.cgi?id=41442

Adds window.performance.navigation namespace consisting of ".type"
and ".redirectCount". As part of this change, I renmaed "NavigationTiming"
to just "Timing" to avoid confusion.

No new tests because tests will be added in a subsequent patch when
functionality is added.

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Navigation.cpp: Added. (WebCore::Navigation::Navigation): (WebCore::Navigation::frame): (WebCore::Navigation::disconnectFrame): (WebCore::Navigation::type): (WebCore::Navigation::redirectCount):
  • page/Navigation.h: Added. (WebCore::Navigation::create):
  • page/Navigation.idl: Added.
  • page/NavigationTiming.cpp: Removed.
  • page/NavigationTiming.h: Removed.
  • page/NavigationTiming.idl: Removed.
  • page/Performance.cpp: (WebCore::Performance::navigation): (WebCore::Performance::timing):
  • page/Performance.h:
  • page/Performance.idl:
  • page/Timing.cpp: Added. (WebCore::Timing::Timing): (WebCore::Timing::frame): (WebCore::Timing::disconnectFrame): (WebCore::Timing::navigationStart):
  • page/Timing.h: Added. (WebCore::Timing::create):
  • page/Timing.idl: Added.
21:16 Changeset [62356] by simon.fraser@apple.com

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/8154047>

Update WebKitSystemInterface, making some functions used by
WebKit2 available in 32-bit.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
21:15 Changeset [62355] by weinig@apple.com

Define HAVE_HOSTED_CORE_ANIMATION on Snow Leopard.

Rubber-stamped by Ander Carlsson.

  • wtf/Platform.h:
21:02 Changeset [62354] by commit-queue@webkit.org

2010-07-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Jian Li.

[chromium] Dragging a link triggers an assert when accessing event.dataTransfer.types
https://bugs.webkit.org/show_bug.cgi?id=41493

ClipboardChromium::writeURL violates ClipboardChromium's assumption that uriList will always
be non-empty if url is valid.

No new tests.

  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::writeURL):
20:51 Changeset [62353] by commit-queue@webkit.org

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Clamp color stops passed to QGradient to 1.0
[https://bugs.webkit.org/show_bug.cgi?id=41484

Fixes an issue where color stops would be silently dropped from radial gradients.

  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
20:15 Changeset [62352] by eric@webkit.org

2010-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTokenizer should ASSERT that it never emits a null character
https://bugs.webkit.org/show_bug.cgi?id=41448

No functional change, thus no tests. These ASSERTs would have
caught the coding error which caused the trouble in bug 41436
(which was fixed by bug 41439).

  • html/HTMLToken.h: (WebCore::HTMLToken::beginStartTag): (WebCore::HTMLToken::beginCharacter): (WebCore::HTMLToken::beginDOCTYPE): (WebCore::HTMLToken::appendToName): (WebCore::HTMLToken::appendToComment): (WebCore::HTMLToken::appendToAttributeName): (WebCore::HTMLToken::appendToAttributeValue): (WebCore::HTMLToken::appendToPublicIdentifier): (WebCore::HTMLToken::appendToSystemIdentifier):
20:12 Changeset [62351] by levin@chromium.org

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62349.
http://trac.webkit.org/changeset/62349
https://bugs.webkit.org/show_bug.cgi?id=41499

It broke the chromium Linux build. (Requested by dave_levin on
#webkit).

  • public/WebNode.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::registerPasswordListener): (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
20:03 Changeset [62350] by commit-queue@webkit.org

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Don't paint with empty radial gradients
https://bugs.webkit.org/show_bug.cgi?id=41190

Unskip canvas/philip/tests/2d.gradient.radial.equal.html for Qt.

  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Don't paint with empty radial gradients
https://bugs.webkit.org/show_bug.cgi?id=41190

If a radial gradient has x0==x1 && y0==y1 && r0==r1, don't paint with it.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fillRect):
  • platform/graphics/Gradient.h: (WebCore::Gradient::isZeroSize):
19:50 Changeset [62349] by commit-queue@webkit.org

2010-07-01 David Holloway <dhollowa@chromium.org>

Reviewed by Darin Fisher.

[chromium] Exposes WebNode::unwrap() and WebNode::constUnwrap() for
use by other code in WebKit/chromium/src.

Specific use of these methods is made in WebFrameImpl.cpp. This is
preferred to the cast operator call that was happening prior to this
change.

https://bugs.webkit.org/show_bug.cgi?id=41477

  • public/WebNode.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::registerPasswordListener): (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
19:22 Changeset [62348] by tonyg@chromium.org

2010-07-01 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Add interface for network platform to pass up timing information
https://bugs.webkit.org/show_bug.cgi?id=41437

The Web Timing feature requires the network platform to expose detailed
timing information for the main resource. This patch adds that data to
the ResourceResponseBase. Since the 82 bytes of information is only
needed for the main resource, it is a RefPtr to avoid using the memory
for other resource types.

No new tests because no new functionality.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/ResourceLoadTiming.h: Added. (WebCore::ResourceLoadTiming::create): (WebCore::ResourceLoadTiming::deepCopy): (WebCore::ResourceLoadTiming::operator==): (WebCore::ResourceLoadTiming::operator!=): (WebCore::ResourceLoadTiming::ResourceLoadTiming):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData): (WebCore::ResourceResponseBase::resourceLoadTiming): (WebCore::ResourceResponseBase::setResourceLoadTiming): (WebCore::ResourceResponseBase::compare):
  • platform/network/ResourceResponseBase.h:
19:17 Changeset [62347] by mrowe@apple.com

Versioning.

19:16 Changeset [62346] by mrowe@apple.com

New tag.

18:59 Changeset [62345] by mrowe@apple.com

Build fix.

18:14 Changeset [62344] by levin@chromium.org
  • platform/chromium/test_expectations.txt: Removed a test that is passing and added a test that is now failing.

Reviewed by NOBODY (trivial test_expectations change).

17:58 Changeset [62343] by levin@chromium.org
  • platform/chromium/test_expectations.txt: Upstreamed two test expectation issues for flaky tests.

Reviewed by NOBODY (trivial test expectation changes).

17:41 Changeset [62342] by mrowe@apple.com

Merge r61667.

17:38 Changeset [62341] by mrowe@apple.com

Merge r61044.

17:36 Changeset [62340] by mrowe@apple.com

Merge r61050.

17:34 Changeset [62339] by mrowe@apple.com

Merge r62279.

17:29 Changeset [62338] by mrowe@apple.com

Merge r61654.

17:21 Changeset [62337] by mrowe@apple.com

Merge r62148.

17:21 Changeset [62336] by mrowe@apple.com

Merge r61623.

17:19 Changeset [62335] by dumi@chromium.org

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62321.
http://trac.webkit.org/changeset/62321
https://bugs.webkit.org/show_bug.cgi?id=41494

Broke the non-win builds. (Requested by dumi on #webkit).

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::addOpenDatabase): (WebCore::ScriptExecutionContext::removeOpenDatabase): (WebCore::ScriptExecutionContext::stopDatabases):
  • dom/ScriptExecutionContext.h:
  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::markAsDeletedAndClose): (WebCore::ContextRemoveOpenDatabaseTask::create): (WebCore::ContextRemoveOpenDatabaseTask::performTask): (WebCore::ContextRemoveOpenDatabaseTask::isCleanupTask): (WebCore::ContextRemoveOpenDatabaseTask::ContextRemoveOpenDatabaseTask): (WebCore::Database::close): (WebCore::Database::closeImmediately): (WebCore::Database::stop): (WebCore::Database::performPolicyChecks):
  • storage/Database.h: (WebCore::Database::): (WebCore::Database::stopped):
  • storage/DatabaseTask.cpp: (WebCore::DatabaseTask::performTask): (WebCore::DatabaseOpenTask::DatabaseOpenTask): (WebCore::DatabaseOpenTask::doPerformTask): (WebCore::DatabaseOpenTask::debugTaskName): (WebCore::DatabaseCloseTask::DatabaseCloseTask): (WebCore::DatabaseCloseTask::doPerformTask): (WebCore::DatabaseCloseTask::debugTaskName): (WebCore::DatabaseTransactionTask::DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::~DatabaseTransactionTask): (WebCore::DatabaseTransactionTask::doPerformTask): (WebCore::DatabaseTransactionTask::debugTaskName): (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): (WebCore::DatabaseTableNamesTask::doPerformTask): (WebCore::DatabaseTableNamesTask::debugTaskName):
  • storage/DatabaseTask.h: (WebCore::DatabaseOpenTask::create): (WebCore::DatabaseCloseTask::create): (WebCore::DatabaseTransactionTask::create): (WebCore::DatabaseTableNamesTask::create):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread):
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::addOpenDatabase):
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL): (WebCore::SQLTransaction::checkAndHandleClosedDatabase):

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62321.
http://trac.webkit.org/changeset/62321
https://bugs.webkit.org/show_bug.cgi?id=41494

Broke the non-win builds. (Requested by dumi on #webkit).

  • storage/open-database-creation-callback.html:
16:58 Changeset [62334] by mrowe@apple.com

Merge r60882.

16:57 Changeset [62333] by mrowe@apple.com

Merge r62135.

16:55 Changeset [62332] by mrowe@apple.com

Merge r62134.

16:53 Changeset [62331] by mrowe@apple.com

Merge r61921.

16:52 Changeset [62330] by mrowe@apple.com

Merge r59396.

16:52 Changeset [62329] by xan@webkit.org

WebCore:

2010-07-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Stop using GdkRegion in 3.x mode
https://bugs.webkit.org/show_bug.cgi?id=41463

Make us compile without using GdkRegion, since it's gone from GTK+
3.x.

  • platform/graphics/IntRect.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::cairo_region_shrink): (WebCore::Font::drawComplexText):
  • platform/gtk/GtkPluginWidget.cpp: (WebCore::GtkPluginWidget::paint):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::paint):

WebKit/gtk:

2010-07-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Stop using GdkRegion in 3.x mode
https://bugs.webkit.org/show_bug.cgi?id=41463

Make us compile without using GdkRegion, since it's gone from GTK+
3.x.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scroll):
  • webkit/webkitwebview.cpp: (webkit_web_view_expose_event):
16:50 Changeset [62328] by mrowe@apple.com

Merge r61435.

16:49 Changeset [62327] by mrowe@apple.com

Merge r61296.

16:48 Changeset [62326] by mrowe@apple.com

Merge r60640.

16:45 Changeset [62325] by mrowe@apple.com

Merge r61070.

16:43 Changeset [62324] by mrowe@apple.com

Merge r61200.

16:42 Changeset [62323] by mrowe@apple.com

Merge r61189.

16:37 Changeset [62322] by mrowe@apple.com

Merge r60908.

16:33 Changeset [62321] by dumi@chromium.org

WebCore: DB clean up.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

  1. Made all DatabaseTasks internal classes of Database and made the Database methods called by those tasks private.
  2. Removed the Database::stop{ed}() methods.
  3. Removed the code that kept track of open databases from ScriptExecutionContext (no longer needed).
  4. Made minor changes to Database::closeImmediately() to make it possible for DatabaseThread to call that method instead of close().
  5. Minor fix to DatabaseTracker: addOpenDatabase() should call OriginQuotaManager::addDatabase() if the origin quota manager is not tracking this origin.
  6. Removed Database::performPolicyChecks(). We already update the DB size after each transaction, and we enforce a max size for the DB at the beginning of each transaction.
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::stopDatabases):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::hasOpenDatabases):

  • storage/Database.cpp:

(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::close):
(WebCore::Database::closeImmediately):

  • storage/Database.h:
  • storage/DatabaseTask.cpp:

(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):
(WebCore::Database::DatabaseOpenTask::debugTaskName):
(WebCore::Database::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::Database::DatabaseCloseTask::doPerformTask):
(WebCore::Database::DatabaseCloseTask::debugTaskName):
(WebCore::Database::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::Database::DatabaseTransactionTask::doPerformTask):
(WebCore::Database::DatabaseTransactionTask::debugTaskName):
(WebCore::Database::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::Database::DatabaseTableNamesTask::doPerformTask):
(WebCore::Database::DatabaseTableNamesTask::debugTaskName):

  • storage/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
(WebCore::Database::DatabaseCloseTask::create):
(WebCore::Database::DatabaseTransactionTask::create):
(WebCore::Database::DatabaseTableNamesTask::create):

  • storage/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):

LayoutTests: Minor change to a DB test to make it run correctly with run-webkit-tests --iterations N.
https://bugs.webkit.org/show_bug.cgi?id=41404

Reviewed by Darin Fisher.

  • storage/open-database-creation-callback.html:
16:26 Changeset [62320] by simon.fraser@apple.com

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Start up the CA render server in the UI process (currently, at launch time), and
pass the server port over to the web process for use by the layer-backed drawing area.

Fix some style issues pointed out by Dan Bernstein.

Implement the WebChromeClient methods that pass the attach/detach calls through
to the drawing area.

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView _startAcceleratedCompositing:]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::WebProcessProxy): (WebKit::WebProcessProxy::setUpAcceleratedCompositing):
  • UIProcess/WebProcessProxy.h:
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
  • UIProcess/mac/WebProcessProxyMac.mm: Added. (WebKit::WebProcessProxy::setUpAcceleratedCompositing):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::attachRootGraphicsLayer): (WebKit::WebChromeClient::scheduleCompositingLayerSync):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::attachCompositingContext):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::didReceiveMessage):
  • WebProcess/WebProcess.h: (WebKit::WebProcess::compositingRenderServerPort):
16:25 Changeset [62319] by mrowe@apple.com

Merge r61060.

16:23 Changeset [62318] by mrowe@apple.com

Merge r60984.

16:21 Changeset [62317] by mrowe@apple.com

Merge r60459.

16:19 Changeset [62316] by mrowe@apple.com

Merge r61068.

16:18 Changeset [62315] by levin@chromium.org
  • platform/chromium/fast/dom/domListEnumeration-expected.txt: Added. Results differ due to a lack of a v8 binding implementation of dataset.
  • platform/chromium/test_expectations.txt: Marked the dataset tests as failing and referred the corresponding bug for them.

Reviewed by NOBODY (test fix).

16:16 Changeset [62314] by mrowe@apple.com

Merge r60727.

16:13 Changeset [62313] by tkent@chromium.org

2010-07-01 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support indeterminate checkbox for Windows
https://bugs.webkit.org/show_bug.cgi?id=41444

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineState): Check isIndeterminate() and set an appropriate flag value.
16:12 Changeset [62312] by mrowe@apple.com

Merge r61132.

16:11 Changeset [62311] by mrowe@apple.com

Merge r61204.

16:09 Changeset [62310] by mrowe@apple.com

Merge r61231.

16:09 Changeset [62309] by mrowe@apple.com

Merge r61171.

16:09 Changeset [62308] by mrowe@apple.com

Merge r61365.

15:57 Changeset [62307] by weinig@apple.com

https://bugs.webkit.org/show_bug.cgi?id=41491
Add first stab at back/forward list API.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBackForwardList.cpp: Added.
  • UIProcess/API/C/WKBackForwardList.h: Added.
  • UIProcess/API/C/WKBackForwardListItem.cpp: Added.
  • UIProcess/API/C/WKBackForwardListItem.h: Added.
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WebKit2.h:
  • UIProcess/WebBackForwardListItem.cpp: Added.
  • UIProcess/WebBackForwardListItem.h: Added.
  • UIProcess/WebBackForwardListProxy.cpp: Added.
  • UIProcess/WebBackForwardListProxy.h: Added.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
15:56 Changeset [62306] by barraclough@apple.com

Bug 41490 - Add missing operations to MacroAssemblerARMv7
Also, make single, double, quad register numbers in ARMv7Assembler distinct & strongly typed.

Reviewed by Oliver Hunt.

  • assembler/ARMv7Assembler.h:

(JSC::ARMRegisters::):
(JSC::ARMRegisters::asSingle):
(JSC::ARMRegisters::asDouble):
(JSC::VFPImmediate::VFPImmediate):
(JSC::VFPImmediate::isValid):
(JSC::VFPImmediate::value):
(JSC::ARMv7Assembler::singleRegisterMask):
(JSC::ARMv7Assembler::doubleRegisterMask):
(JSC::ARMv7Assembler::):
(JSC::ARMv7Assembler::add_S):
(JSC::ARMv7Assembler::neg):
(JSC::ARMv7Assembler::orr_S):
(JSC::ARMv7Assembler::sub):
(JSC::ARMv7Assembler::sub_S):
(JSC::ARMv7Assembler::vadd_F64):
(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcvt_F64_S32):
(JSC::ARMv7Assembler::vcvtr_S32_F64):
(JSC::ARMv7Assembler::vdiv_F64):
(JSC::ARMv7Assembler::vldr):
(JSC::ARMv7Assembler::vmov_F64_0):
(JSC::ARMv7Assembler::vmov):
(JSC::ARMv7Assembler::vmul_F64):
(JSC::ARMv7Assembler::vstr):
(JSC::ARMv7Assembler::vsub_F64):
(JSC::ARMv7Assembler::vcvt):
(JSC::ARMv7Assembler::vmem):

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::fpTempRegisterAsSingle):
(JSC::MacroAssemblerARMv7::neg32):
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::divDouble):
(JSC::MacroAssemblerARMv7::convertInt32ToDouble):
(JSC::MacroAssemblerARMv7::branchConvertDoubleToInt32):
(JSC::MacroAssemblerARMv7::zeroDouble):
(JSC::MacroAssemblerARMv7::branchOr32):
(JSC::MacroAssemblerARMv7::set32):
(JSC::MacroAssemblerARMv7::set8):

  • assembler/MacroAssemblerMIPS.h:
  • assembler/MacroAssemblerX86Common.h:
15:36 Changeset [62305] by andersca@apple.com

Make process launching asynchronous
https://bugs.webkit.org/show_bug.cgi?id=41489

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.h:

Make OutgoingMessage public.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::paint):
Don't wait for a paint reply when the process is starting up.

  • UIProcess/Launcher/ProcessLauncher.cpp: Added.

Add new ProcessLauncher class.

(WebKit::processLauncherWorkQueue):
Returns the work queue where process launching will happen.

(WebKit::ProcessLauncher::ProcessLauncher):
Schedule launching the process.

(WebKit::ProcessLauncher::didFinishLaunchingProcess):
Call the client method.

(WebKit::ProcessLauncher::invalidate):
Set the client to 0.

  • UIProcess/Launcher/ProcessLauncher.h: Added.
  • UIProcess/Launcher/WebProcessLauncher.h: Removed.

Rename WebProcessLauncher.h -> ProcessLauncher.h

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: Added.
  • UIProcess/Launcher/mac/WebProcessLauncher.mm: Removed.

Rename WebProcessLauncher.mm -> ProcessLauncherMac.mm, update for ProcessLauncher changes.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp: Added.
  • UIProcess/Launcher/win/WebProcessLauncher.cpp: Removed.

Rename WebProcessLauncher.cpp -> ProcessLauncherWin.cpp, update for ProcessLauncher changes.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
Delete any unsent messages.

(WebKit::WebProcessProxy::connect):
Use the new ProcessLauncher.

(WebKit::WebProcessProxy::sendMessage):
If we're waiting for the process to launch, the messages need to be enqueued.

(WebKit::WebProcessProxy::didFinishLaunching):
Send the outgoing messages.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Update for renames.

15:25 Changeset [62304] by ap@apple.com

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=41488
<rdar://problem/7487420> Crash in SubresourceLoader::create when load is initiated from plug-in destructor

Test: plugins/js-from-destroy.html

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Null check active document loader.
15:23 Changeset [62303] by simon.fraser@apple.com

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Add a new kind of DrawingArea, which is a LayerBackedDrawingArea, which will be used
when the page goes into accelerated compositing mode. It is not wired up yet.

  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: New 'attach' and 'detach' messages related to accelerated compositing.
  • UIProcess/API/mac/WKView.mm: (-[WKView _startAcceleratedCompositing:]): (-[WKView _stopAcceleratedCompositing]):
  • UIProcess/API/mac/WKViewInternal.h: Add a subview of the WKView which has layer-backing enabled, and put the drawing area's layer inside of that.
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h: (WebKit::ChunkedUpdateDrawingAreaProxy::attachCompositingContext): (WebKit::ChunkedUpdateDrawingAreaProxy::detachCompositingContext): These methods will never be called on the ChunkedUpdateDrawingArea. Stub them out.
  • UIProcess/DrawingAreaProxy.h: Add attachCompositingContext() and detachCompositingContext() methods, and a new drawing area type to the enum.
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: Added.
  • UIProcess/LayerBackedDrawingAreaProxy.h: Added.
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: Added.
  • WebKit2.xcodeproj/project.pbxproj: Add LayerBackedDrawingArea files.
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h: Add virtual methods stubs.
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): Create a LayerBackedDrawingArea if asked.
  • WebProcess/WebPage/DrawingArea.h: New LayerBackedDrawingAreaType type, and new virtual methods related to accelerated compositing.
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: Added.
  • WebProcess/WebPage/LayerBackedDrawingArea.h: Added.
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: Added.
15:17 Changeset [62302] by aestes@apple.com

2010-07-01 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8113003> Correctly fire beforeload events for images
added to the DOM using .innerHTML.
https://bugs.webkit.org/show_bug.cgi?id=40919

Test: fast/dom/beforeload/image-before-load-innerHTML.html

  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::write): Do not fire synchronous image beforeload events immediately after parsing a document fragment. Let the events fire later, giving the fragment time to potentially be inserted into the document.

2010-07-01 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.


<rdar://problem/8113003> Test that beforeload fires correctly on images
inserted into the DOM using .innerHTML.
https://bugs.webkit.org/show_bug.cgi?id=40919

  • fast/dom/beforeload/image-before-load-innerHTML-expected.txt: Added.
  • fast/dom/beforeload/image-before-load-innerHTML.html: Added.
15:02 Changeset [62301] by oliver@apple.com

Improve reentrancy logic in polymorphic cache stubs
<https://bugs.webkit.org/show_bug.cgi?id=41482>
<rdar://problem/8094380>

Reviewed by Geoff Garen.

JavaScriptCore:

Make the polymorphic cache stubs handle reentrancy
better.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):

LayoutTests:

Test cases for cache reentry in the cache code.

  • fast/js/reentrant-caching-expected.txt: Added.
  • fast/js/reentrant-caching.html: Added.
  • fast/js/script-tests/reentrant-caching.js: Added.
14:56 Changeset [62300] by commit-queue@webkit.org

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: bezierCurveTo() and quadraticCurveTo() must ensure subpaths
https://bugs.webkit.org/show_bug.cgi?id=41192

Unskipped two tests:

  • canvas/philip/tests/2d.path.bezierCurveTo.ensuresubpath.2.html
  • canvas/philip/tests/2d.path.quadraticCurveTo.ensuresubpath.2.html

fast/canvas/canvas-modify-emptyPath.html was updated to expect the new behavior.

Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-beziercurveto
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-quadraticcurveto

  • canvas/philip/tests/2d.path.bezierCurveTo.ensuresubpath.2-expected.txt:
  • canvas/philip/tests/2d.path.quadraticCurveTo.ensuresubpath.2-expected.txt:
  • fast/canvas/canvas-modify-emptyPath-expected.txt:
  • fast/canvas/script-tests/canvas-modify-emptyPath.js:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: bezierCurveTo() and quadraticCurveTo() must ensure subpaths
https://bugs.webkit.org/show_bug.cgi?id=41192

If the current path is empty, bezierCurveTo() and quadraticCurveTo() will now
move to the (first) control point before adding the curve.

Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-beziercurveto
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-quadraticcurveto

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::quadraticCurveTo): (WebCore::CanvasRenderingContext2D::bezierCurveTo):
14:44 Changeset [62299] by commit-queue@webkit.org

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Add test for checking that canvas elements can't have a negative width or height.
https://bugs.webkit.org/show_bug.cgi?id=39149

Unskipped 2 canvas/philip/ tests that now pass.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#attr-canvas-width

  • canvas/philip/tests/size.attributes.parse.minus-expected.txt:
  • canvas/philip/tests/size.attributes.setAttribute.minus-expected.txt:
  • fast/canvas/canvas-negative-size-expected.txt: Added.
  • fast/canvas/canvas-negative-size.html: Added.
  • fast/canvas/script-tests/canvas-negative-size.js: Added. (createFromMarkup): (trySettingWidth): (trySettingHeight): (trySettingWidthAttribute): (trySettingHeightAttribute): (tryCreatingCanvasWithWidth): (tryCreatingCanvasWithHeight): (tryWidth): (tryHeight): (checkDefaultWidth): (checkDefaultHeight):
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Canvas element cannot have negative width or height (HTML5 spec 4.8.11)
https://bugs.webkit.org/show_bug.cgi?id=39149

If assigned a negative value, it should default to 300 for width and 150 for height.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#attr-canvas-width

Test: fast/canvas/canvas-negative-size.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset):
14:02 Changeset [62298] by vestbo@webkit.org

[Qt] Make context menus show up in the right place in QTestBrowser

Reviewed by Kenneth Rohde Christiansen.

Context menus were shown at scene-relative coordinates for
QGraphicsWebView while QMenu expects them to be global. The
change to the QWidget case was to get rid of the mapToGlobal.

  • QtTestBrowser/webview.cpp:
13:53 Changeset [62297] by tonikitoo@webkit.org

Export symbols on Linux with GCC, like JSC does.

Rubberstamped by Sam Weinig.
Patch by Kenneth Christiansen <kenneth@webkit.org>

  • UIProcess/API/C/WKBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
13:53 Changeset [62296] by robert@webkit.org

2010-07-01 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] dump frames in ascending alphabetical order of title

https://bugs.webkit.org/show_bug.cgi?id=41261

Unskip:
http/tests/navigation/metaredirect-frames.html
http/tests/navigation/redirect302-frames.html
http/tests/navigation/redirect302-subframeload.html
http/tests/navigation/timerredirect-frames.html

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::getChildHistoryItems):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem):
  • platform/qt/Skipped:
13:44 Changeset [62295] by tonikitoo@webkit.org

Initial WebKit2 implementation https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Antti Koivisto.
Patch by Kenneth Christiansen <kenneth@webkit.org>

Add implementation of the UI and loader client for Qt.

  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/ClientImpl.cpp: Added.

(toQWKPage):
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didReceiveServerRedirectForProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didFirstLayoutForFrame):
(qt_wk_didFirstVisuallyNonEmptyLayoutForFrame):
(qt_wk_didStartProgress):
(qt_wk_didChangeProgress):
(qt_wk_didFinishProgress):
(qt_wk_didBecomeUnresponsive):
(qt_wk_didBecomeResponsive):
(qt_wk_createNewPage):
(qt_wk_showPage):
(qt_wk_close):
(qt_wk_runJavaScriptAlert):

  • UIProcess/API/qt/ClientImpl.h: Added.
13:37 Changeset [62294] by tonikitoo@webkit.org

Unreviewed more ChangeLog mess up fix caused by bad resolve-ChangeLogs merges.

13:21 Changeset [62293] by kinuko@chromium.org

2010-07-01 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed. Update chromium tests expectations for flaky tests.

  • platform/chromium/test_expectations.txt:
13:13 Changeset [62292] by tonikitoo@webkit.org

Unreviewed ChangeLog mess up fix cause by bad resolve-ChangeLogs merges.

13:10 Changeset [62291] by darin@apple.com

Turn on adoptRef assertion for TreeShared.

Reviewed by Steve Falkenburg.

  • platform/TreeShared.h: Remove LOOSE_TREE_SHARED and all the ifdefs.

Actually, I used LOOSE_REF_COUNTED by accident in a few places, but
removing them all now.

  • rendering/ShadowElement.cpp:

(WebCore::ShadowBlockElement::create): Added adoptRef. This was a
storage leak before, probably recently introduced r61324.
(WebCore::ShadowInputElement::create): Ditto.

13:04 Changeset [62290] by andersca@apple.com

2010-07-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change the CoreIPC connection identifier to be a HANDLE on Windows
https://bugs.webkit.org/show_bug.cgi?id=41479

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/win/ConnectionWin.cpp: (CoreIPC::Connection::createServerAndClientIdentifiers): New function that creates a server and client HANDLE.

(CoreIPC::Connection::platformInitialize):
Don't open the connections here.

(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::open):

  • UIProcess/Launcher/win/WebProcessLauncher.cpp: (WebKit::webThreadBody): Get the handle from the thread.

(WebKit::launchWebProcess):
Mark the client identifier as inheritable and pass it along to the web process.

  • WebProcess/win/WebProcessMain.cpp: (WebKit::CommandLine::CommandLine): (WebKit::CommandLine::parse): (WebKit::CommandLine::operator[]): Add simple command line parser.

(WebKit::WebProcessMain):
Get the handle identifier from the command line.

  • WebProcess/win/WebProcessMain.h:
  • WebKit.pri:
13:00 Changeset [62289] by hausmann@webkit.org

[Qt] Doc improvements for QDeclarativeWebView

Patch by Bea Lam <bea.lam@nokia.com> on 2010-07-01
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
12:44 Changeset [62288] by kbr@google.com

2010-07-01 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Stop linking against opengl32.lib in Windows Chromium port
https://bugs.webkit.org/show_bug.cgi?id=41424

  • WebKit.gyp:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent):
  • src/WebGraphicsContext3DDefaultImpl.h:
12:44 Changeset [62287] by tonikitoo@webkit.org

Initial WebKit2 implementation https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Antti Koivisto.
Patch by Kenneth Christiansen <kenneth@webkit.org>

Add initial Qt API for WebKit2

  • UIProcess/API/qt/WKView.h: Added.
  • UIProcess/API/qt/qgraphicswkview.cpp: Added.

(QGraphicsWKViewPrivate::pageRef):
(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKView::~QGraphicsWKView):
(QGraphicsWKView::page):
(QGraphicsWKView::paint):
(QGraphicsWKView::setGeometry):
(QGraphicsWKView::load):
(QGraphicsWKView::setUrl):
(QGraphicsWKView::url):
(QGraphicsWKView::title):
(QGraphicsWKView::triggerPageAction):
(QGraphicsWKView::back):
(QGraphicsWKView::forward):
(QGraphicsWKView::reload):
(QGraphicsWKView::stop):
(QGraphicsWKView::itemChange):
(QGraphicsWKView::event):
(QGraphicsWKView::sizeHint):
(QGraphicsWKView::inputMethodQuery):
(QGraphicsWKView::keyPressEvent):
(QGraphicsWKView::keyReleaseEvent):
(QGraphicsWKView::hoverMoveEvent):
(QGraphicsWKView::mouseMoveEvent):
(QGraphicsWKView::mousePressEvent):
(QGraphicsWKView::mouseReleaseEvent):
(QGraphicsWKView::mouseDoubleClickEvent):
(QGraphicsWKView::wheelEvent):
(QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
(QGraphicsWKView::visibleRect):

  • UIProcess/API/qt/qgraphicswkview.h: Added.
  • UIProcess/API/qt/qwkpage.cpp: Added.

(QWKPagePrivate::QWKPagePrivate):
(QWKPagePrivate::~QWKPagePrivate):
(QWKPagePrivate::init):
(QWKPagePrivate::toolTipChanged):
(QWKPagePrivate::paint):
(QWKPagePrivate::keyPressEvent):
(QWKPagePrivate::keyReleaseEvent):
(QWKPagePrivate::mouseMoveEvent):
(QWKPagePrivate::mousePressEvent):
(QWKPagePrivate::mouseReleaseEvent):
(QWKPagePrivate::mouseDoubleClickEvent):
(QWKPagePrivate::wheelEvent):
(QWKPagePrivate::updateAction):
(QWKPagePrivate::updateNavigationActions):
(QWKPagePrivate::_q_webActionTriggered):
(QWKPage::QWKPage):
(QWKPage::~QWKPage):
(QWKPage::pageRef):
(QWKPage::setCreateNewPageFunction):
(QWKPage::load):
(QWKPage::setUrl):
(QWKPage::url):
(QWKPage::title):
(QWKPage::setViewportSize):
(QWKPage::requestZoomRect):
(QWKPage::triggerAction):
(QWKPage::action):

  • UIProcess/API/qt/qwkpage.h: Added.
  • UIProcess/API/qt/qwkpage_p.h: Added.

(QWKPagePrivate::get):
(QWKPagePrivate::processDidExit):
(QWKPagePrivate::processDidRevive):
(QWKPagePrivate::takeFocus):

12:38 Changeset [62286] by simon.fraser@apple.com

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Step 2: add a method, syncCompositingStateForThisLayerOnly(), to GraphicsLayer to commit
batched changes non-recursively. This allows us to use GraphicsLayer in places where we
don't want to kick off a recursive commit of the entire tree.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::syncCompositingStateForThisLayerOnly):
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::syncCompositingStateForThisLayerOnly):
  • WebCore.AcceleratedCompositing.exp: Export the new method for use in WebKit2.
12:34 Changeset [62285] by xan@webkit.org

2010-07-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Only include the geolocation IDL in the GObject DOM bindings set
if geolocation is enabled.

  • GNUmakefile.am:
12:32 Changeset [62284] by timothy@apple.com

Provide a WebView preference to disable DNS prefetching.

https://bugs.webkit.org/show_bug.cgi?id=28825
rdar://problem/7181249

Reviewed by Darin Adler.

WebCore:

  • WebCore.base.exp: Added Settings::setDNSPrefetchingEnabled.
  • dom/Document.cpp:

(WebCore::Document::initDNSPrefetch): Check settings->dnsPrefetchingEnabled().

  • page/Settings.cpp:

(WebCore::Settings::Settings): Set m_dnsPrefetchingEnabled to true.
(WebCore::Settings::setDNSPrefetchingEnabled): Added. Set m_dnsPrefetchingEnabled.

  • page/Settings.h:

(WebCore::Settings::dnsPrefetchingEnabled): Added. Return m_dnsPrefetchingEnabled.

WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Set WebKitDNSPrefetchingEnabledPreferenceKey to YES.
(-[WebPreferences isDNSPrefetchingEnabled]): Added. Return WebKitDNSPrefetchingEnabledPreferenceKey's value.
(-[WebPreferences setDNSPrefetchingEnabled:]): Added. Set WebKitDNSPrefetchingEnabledPreferenceKey's value.

  • WebView/WebPreferencesPrivate.h: Added isDNSPrefetchingEnabled and setDNSPrefetchingEnabled:.
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]): Call WebCore::Settings::setDNSPrefetchingEnabled.

12:30 Changeset [62283] by simon.fraser@apple.com

2010-07-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Step 1: add a new .exp file for WebCore, which exports symbols only when USE(ACCELERATED_COMPOSITING)
is defined.

Also export WebCore::FloatSize::FloatSize(WebCore::IntSize const&) from WebCore.

  • DerivedSources.make:
  • WebCore.AcceleratedCompositing.exp: Added.
  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
12:23 Changeset [62282] by mrobinson@webkit.org

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the GTK+ build after r62278.

  • Scripts/webkitdirs.pm: If the make arguments have already been specified, let them override the automatic CPU detection for autotools builds.
12:14 Changeset [62281] by sullivan@apple.com
  • mac/WebKit2.exp:

Added _WKFramePolicyListenerDownload and _WKFramePolicyListenerIgnore.

Rubber-stamped by Anders Carlsson.

12:12 Changeset [62280] by mrobinson@webkit.org

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the Windows build after r62278.

  • Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
11:47 Changeset [62279] by ap@apple.com

WebCore:

Reviewed by Darin Adler.

<rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction

Test: plugins/write-xssauditor-from-destroy.html

Fix specific known cases that also crash in same process case. I don't know if there is
any rule for when documentLoader should be checked for being null, it looks like a mess.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::referrer):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):

WebKit:

<rdar://problem/8148656> <https://bugs.webkit.org/show_bug.cgi?id=41431>
REGRESSION (r49411): Various crashes due to JavaScript execution during plug-in destruction

Strengthen m_inDestroy "swipe under the carpet" fix.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Added a long comment about m_inDestroy, and changed it to static.
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): m_inDestroy is now static, so we don't initialize it in constructor. (WebKit::NetscapePluginInstanceProxy::destroy): Assert that we aren't already destroying some plug-in. (WebKit::NetscapePluginInstanceProxy::evaluate): This function accidentally lacked an m_inDestroy check in r42789.
11:42 Changeset [62278] by mrobinson@webkit.org

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] build-webkit does not detect the number of CPUs
https://bugs.webkit.org/show_bug.cgi?id=41469

Pass the appropriate -j<#> flag to make when building autotools builds.
This causes make to spawn that many number of child processes for doing
parallel builds.

  • Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number of CPUs. This makes the script work across more platforms.
  • Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the number of CPUs across several platforms. Use this new function to determine the appropriate arguments to pass to make for doing parallel builds with autotools build files.
11:42 Changeset [62277] by commit-queue@webkit.org

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

The HTML5 canvas 2d.drawImage.zerocanvas test does not pass
https://bugs.webkit.org/show_bug.cgi?id=40271

Unskipped canvas/philip/tests/2d.drawImage.zerocanvas.html

  • canvas/philip/tests/2d.drawImage.zerocanvas-expected.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

The HTML5 canvas 2d.drawImage.zerocanvas test does not pass
https://bugs.webkit.org/show_bug.cgi?id=40271

Throw INVALID_STATE_ERR when attempting to draw a canvas with zero width or height.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): Call setDOMException after drawImage(canvas, x, y)
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
11:28 Changeset [62276] by commit-queue@webkit.org

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

[Qt] Canvas: clip() should use non-zero winding rule
https://bugs.webkit.org/show_bug.cgi?id=41466

Use non-zero winding number rule when clipping a GraphicsContext from canvas.
Fixes appearance of the "pill" in the web inspector.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::canvasClip):
10:45 Changeset [62275] by yurys@chromium.org

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations for svg/W3C-SVG-1.1/filters-conv-01-f.svg
which is timing out on Linux and Windows.

  • platform/chromium/test_expectations.txt:
10:40 Changeset [62274] by yurys@chromium.org

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62246.
http://trac.webkit.org/changeset/62246
https://bugs.webkit.org/show_bug.cgi?id=41470

"Worker tests are broken in Chromium" (Requested by yurys on
#webkit).

  • fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Removed.
  • fast/events/popup-blocked-from-fake-user-gesture.html: Removed.
  • http/tests/inspector/change-iframe-src-expected.txt: Removed.
  • http/tests/inspector/change-iframe-src.html: Removed.

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62246.
http://trac.webkit.org/changeset/62246
https://bugs.webkit.org/show_bug.cgi?id=41470

"Worker tests are broken in Chromium" (Requested by yurys on
#webkit).

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::eventAccessorGetter): (WebCore::V8DOMWindow::eventAccessorSetter):

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62246.
http://trac.webkit.org/changeset/62246
https://bugs.webkit.org/show_bug.cgi?id=41470

"Worker tests are broken in Chromium" (Requested by yurys on
#webkit).

  • src/WebBindings.cpp: (WebKit::getEvent):
10:29 Changeset [62273] by commit-queue@webkit.org

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Exception erroneously thrown for drawImage() when image.complete=false
https://bugs.webkit.org/show_bug.cgi?id=33968

Added a test to verify that CRC2D does nothing when calling drawImage()
with an incomplete image or video.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

  • fast/canvas/canvas-drawImage-incomplete-expected.txt: Added.
  • fast/canvas/canvas-drawImage-incomplete.html: Added.
  • fast/canvas/script-tests/canvas-drawImage-incomplete.js: Added.

2010-07-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

Canvas: Exception erroneously thrown for drawImage() when image.complete=false
https://bugs.webkit.org/show_bug.cgi?id=33968

Do nothing in drawImage() if called with an image whose 'complete'
attribute is false, or a video whose readyState is either HAVE_NOTHING
or HAVE_METADATA.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage

Test: fast/canvas/canvas-drawImage-incomplete.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
10:14 Changeset [62272] by commit-queue@webkit.org

2010-07-01 David Holloway <dhollowa@chromium.org>

Reviewed by Darin Fisher.

[chromium] Consolidates AutoFill and Autocomplete popup menus into a single popup menu.

This change combines SuggestionsPopupMenuClient, AutoFillPopupMenuClient, and
AutocompletePopupMenuClient classes into a single consolidated AutoFillPopupMenuClient class.
Prior to this change the contents of the AutoFill popup menu only included AutoFill
suggestions and similarly the Autocomplete popup menu only included Autocomplete
suggestions. With this consolidation, both AutoFill and Autocomplete suggestions can
now be displayed in a single menu.

https://bugs.webkit.org/show_bug.cgi?id=41236

  • WebKit.gyp:
  • public/WebFrame.h:
  • public/WebView.h:
  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::AutoFillPopupMenuClient): (WebKit::AutoFillPopupMenuClient::~AutoFillPopupMenuClient): (WebKit::AutoFillPopupMenuClient::valueChanged): (WebKit::AutoFillPopupMenuClient::selectionCleared): (WebKit::AutoFillPopupMenuClient::itemText): (WebKit::AutoFillPopupMenuClient::itemStyle): (WebKit::AutoFillPopupMenuClient::menuStyle): (WebKit::AutoFillPopupMenuClient::clientPaddingLeft): (WebKit::AutoFillPopupMenuClient::clientPaddingRight): (WebKit::AutoFillPopupMenuClient::popupDidHide): (WebKit::AutoFillPopupMenuClient::setTextFromItem): (WebKit::AutoFillPopupMenuClient::fontSelector): (WebKit::AutoFillPopupMenuClient::hostWindow): (WebKit::AutoFillPopupMenuClient::createScrollbar): (WebKit::AutoFillPopupMenuClient::initialize): (WebKit::AutoFillPopupMenuClient::getWebView): (WebKit::AutoFillPopupMenuClient::textFieldStyle):
  • src/AutoFillPopupMenuClient.h: (WebKit::AutoFillPopupMenuClient::itemToolTip): (WebKit::AutoFillPopupMenuClient::itemAccessibilityText): (WebKit::AutoFillPopupMenuClient::itemIsEnabled): (WebKit::AutoFillPopupMenuClient::clientInsetLeft): (WebKit::AutoFillPopupMenuClient::clientInsetRight): (WebKit::AutoFillPopupMenuClient::listSize): (WebKit::AutoFillPopupMenuClient::selectedIndex): (WebKit::AutoFillPopupMenuClient::itemIsLabel): (WebKit::AutoFillPopupMenuClient::itemIsSelected): (WebKit::AutoFillPopupMenuClient::shouldPopOver): (WebKit::AutoFillPopupMenuClient::valueShouldChangeOnHotTrack): (WebKit::AutoFillPopupMenuClient::setAutocompleteMode): (WebKit::AutoFillPopupMenuClient::getTextField): (WebKit::AutoFillPopupMenuClient::getSelectedIndex): (WebKit::AutoFillPopupMenuClient::setSelectedIndex):
  • src/AutocompletePopupMenuClient.cpp: Removed.
  • src/AutocompletePopupMenuClient.h: Removed.
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::textFieldDidEndEditing): (WebKit::EditorClientImpl::doAutofill): (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted):
  • src/SuggestionsPopupMenuClient.cpp: Removed.
  • src/SuggestionsPopupMenuClient.h: Removed.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::currentHistoryItem): (WebKit::WebFrameImpl::notifiyPasswordListenerOfAutocomplete):
  • src/WebFrameImpl.h:
  • src/WebViewImpl.cpp: (WebKit::): (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::mouseUp): (WebKit::WebViewImpl::selectPopupHandleKeyEvent): (WebKit::WebViewImpl::autocompleteHandleKeyEvent): (WebKit::WebViewImpl::hideAutoFillPopup): (WebKit::WebViewImpl::setFocus): (WebKit::WebViewImpl::applyAutoFillSuggestions): (WebKit::WebViewImpl::applyAutocompleteSuggestions): (WebKit::WebViewImpl::hidePopups): (WebKit::WebViewImpl::refreshAutoFillPopup):
  • src/WebViewImpl.h: (WebKit::WebViewImpl::autoFillPopupDidHide):
09:55 Changeset [62271] by jschuh@chromium.org

2010-07-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Dan Bernstein.

Prevent crash on counter destruction
https://bugs.webkit.org/show_bug.cgi?id=40032

Added counter destruction to RenderWidget::destroy()

Test: fast/css/counters/destroy-counter-crash.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):

2010-07-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Dan Bernstein.

Prevent crash on counter destruction
https://bugs.webkit.org/show_bug.cgi?id=40032

  • fast/css/counters/destroy-counter-crash-expected.txt: Added.
  • fast/css/counters/destroy-counter-crash.html: Added.
09:41 Changeset [62270] by weinig@apple.com

2010-07-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62267.
http://trac.webkit.org/changeset/62267
https://bugs.webkit.org/show_bug.cgi?id=41468

broke stuff (Requested by weinig on #webkit).

  • UIProcess/API/C/WKBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
09:26 Changeset [62269] by leandro@webkit.org

2010-07-01 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed build fix after r62215.

No new functionality, so no new tests.

  • CMakeLists.txt: Add missing files and re-sort.
09:25 Changeset [62268] by sullivan@apple.com
  • mac/WebKit2.exp:

Added _WKFramePolicyListenerRelease and _WKFramePolicyListenerRetain.

Rubber-stamped by Sam Weinig.

09:16 Changeset [62267] by commit-queue@webkit.org

2010-07-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

Export symbols on Linux with GCC

  • UIProcess/API/C/WKBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
09:10 Changeset [62266] by jocelyn.turcotte@nokia.com

[Qt] Fix a comment in WebKit.pri.

Reviewed by Simon Hausmann.

  • WebKit.pri:
09:09 Changeset [62265] by jocelyn.turcotte@nokia.com

[Qt] Remove an unneeded assert.

Reviewed by Kenneth Rohde Christiansen.

This assert is triggered for example while showing the falling leaves demo.
GraphicsLayerQtImpl::toGraphicsLayerQtImpl asserts that its input
pointer is null. Looking at the uses of this method it seems like
it is expected to return null if a null pointer is given to it.

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::toGraphicsLayerQtImpl):

09:08 Changeset [62264] by jocelyn.turcotte@nokia.com

[Qt] Fix qmake vcproj generation for QtWebKit.

Reviewed by Simon Hausmann.

qmake use TARGET=/LIBS+= -lTARGET to create dependencies
between projects in a subdir template.

Since when compiling outside of Qt we hijack the target name of
QtWebKit to add the configuration and version suffix to the binary
filename, qmake can't establish the WebCore project as a dependency
to QtTestBrowser.

This patch makes sure that the target is not hijacked on the
first of the three passes where the dependencies are determined.

.:

  • WebKit.pri:

WebCore:

  • WebCore.pro:
09:04 Changeset [62263] by commit-queue@webkit.org

2010-07-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Add our event factory for converting Qt events to something WebKit2
understands.

  • Shared/qt/WebEventFactoryQt.cpp: Added. (WebKit::mouseButtonForEvent): (WebKit::webEventTypeForEvent): (WebKit::modifiersForEvent): (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
  • Shared/qt/WebEventFactoryQt.h: Added.
09:03 Changeset [62262] by mrobinson@webkit.org

2010-07-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
https://bugs.webkit.org/show_bug.cgi?id=40333

Convert draggingDataObjects to a pointer. The constructor and destructor of the
HashMap should be called explicitly. GObject memory allocation does not do this.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_drag_end): (webkit_web_view_drag_data_get): (webkit_web_view_init):
08:27 Changeset [62261] by antti.j.koivisto@nokia.com

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Add UpdateChunk. This one is mmap based, using Qt abstractions.

  • Shared/qt: Added.
  • Shared/qt/UpdateChunk.cpp: Added.

(WebKit::MappedMemory::markUsed):
(WebKit::MappedMemory::markFree):
(WebKit::MappedMemory::isFree):
(WebKit::mapMemory):
(WebKit::mapFile):
(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::~UpdateChunk):
(WebKit::UpdateChunk::data):
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
(WebKit::UpdateChunk::createImage):

  • Shared/qt/UpdateChunk.h: Added.

(WebKit::UpdateChunk::rect):
(WebKit::UpdateChunk::size):

08:05 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
CONFIG-=def_files and --no-depend-generate could be default (diff)
07:36 Changeset [62260] by antti.j.koivisto@nokia.com

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Include some stdlib headers to fix linux build.

  • Platform/CoreIPC/ArgumentDecoder.cpp:
  • Platform/CoreIPC/ArgumentEncoder.cpp:
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebUIClient.cpp:
07:25 Changeset [62259] by zimmermann@webkit.org

2010-07-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGRenderStyle::diff() is missing
https://bugs.webkit.org/show_bug.cgi?id=41455

Don't just return StyleDifferenceLayout when two SVGRenderStyle objects differ.
Figure out when to repaint, and as last resort do a relayout.

Lively Kernel doesn't do any relayouts anymore, same for lots of demos in the IE9 testcenter.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff):
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/style/SVGRenderStyle.h:
07:16 Changeset [62258] by yurys@chromium.org

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
  • platform/chromium/test_expectations.txt:
06:49 Changeset [62257] by antti.j.koivisto@nokia.com

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement CoreIPC::Connection and PlatformProcessIdentifier for Qt. Not built yet.

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/qt: Added.
  • Platform/CoreIPC/qt/ConnectionQt.cpp: Added.

(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::newConnectionHandler):
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::openConnection):
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):

  • Platform/PlatformProcessIdentifier.h:
06:18 Changeset [62256] by antti.j.koivisto@nokia.com

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement WorkQueue for Qt. Not built yet.

  • Platform/WorkQueue.h:
  • Platform/qt/WorkQueueQt.cpp: Added.

(WorkQueue::WorkItemQt::WorkItemQt):
(WorkQueue::WorkItemQt::~WorkItemQt):
(WorkQueue::WorkItemQt::execute):
(WorkQueue::WorkItemQt::timerEvent):
(WorkQueue::connectSignal):
(WorkQueue::disconnectSignal):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::scheduleWork):

06:10 Changeset [62255] by yurys@chromium.org

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Yury Semikhatsky.

Fix wrong style comment in chromium test expectations file.
https://bugs.webkit.org/show_bug.cgi?id=41460

  • platform/chromium/test_expectations.txt:
05:49 Changeset [62254] by antti.j.koivisto@nokia.com

Revert accidental commit.

JavaScriptCore:

  • runtime/Collector.cpp:

(JSC::Heap::allocateBlock):

WebCore:

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

05:42 Changeset [62253] by antti.j.koivisto@nokia.com

[Qt] Initial WebKit2 implementation
https://bugs.webkit.org/show_bug.cgi?id=40233

Reviewed by Kenneth Rohde Christiansen.

Implement RunLoop for Qt. Not built yet.

  • Platform/RunLoop.h:
  • Platform/qt: Added.
  • Platform/qt/RunLoopQt.cpp: Added.

(RunLoop::TimerObject::TimerObject):
(RunLoop::TimerObject::performWork):
(RunLoop::TimerObject::wakeUp):
(RunLoop::TimerObject::timerEvent):
(RunLoop::run):
(RunLoop::stop):
(RunLoop::RunLoop):
(RunLoop::~RunLoop):
(RunLoop::wakeUp):
(RunLoop::TimerBase::timerFired):
(RunLoop::TimerBase::TimerBase):
(RunLoop::TimerBase::~TimerBase):
(RunLoop::TimerBase::start):
(RunLoop::TimerBase::stop):
(RunLoop::TimerBase::isActive):

05:28 Changeset [62252] by commit-queue@webkit.org

2010-07-01 Patrick Gansterer <paroga@paroga.com>

Reviewed by Dirk Schulze.

Buildfix for !ENABLE(FILTERS) after r62238.
https://bugs.webkit.org/show_bug.cgi?id=41456

  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::prepareToRenderSVGContent):
05:17 Changeset [62251] by jocelyn.turcotte@nokia.com

2010-07-01 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Create QComboBoxes when clicked and destroy on hide.
https://bugs.webkit.org/show_bug.cgi?id=41451

Currently a QComboBox is created for each RenderMenuList and
it gets destroyed either when the RenderMenuList or the
QWebView (its Qt parent) is destroyed. This cause a crash
when the QWebView is destroyed before the render tree (which
is kept in cache).

This patch aim to destroy the QComboBox as soon as its popup
gets hidden, and likewise, create it only when the popup is
requested to be shown.
It also removes the unneeded reference to the QGraphicsProxyWidget,
destroying the QComboBox automatically destroys its bound
proxywidget.

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::hide): (WebCore::QtFallbackWebPopup::destroyPopup): (WebCore::QtFallbackWebPopup::populate):
  • WebCoreSupport/QtFallbackWebPopup.h:
04:39 Changeset [62250] by morrita@google.com

2010-07-01 MORITA Hajime <morrita@google.com>

Unreviewed build fix.

  • rendering/RenderInputSpeech.cpp: (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
  • rendering/RenderInputSpeech.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paintInputFieldSpeechButton):
  • rendering/RenderTheme.h:
04:11 Changeset [62249] by commit-queue@webkit.org

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Kent Tamura.

Rendering the speech button in input elements.
https://bugs.webkit.org/show_bug.cgi?id=40984

input-appearance-speechbutton.html checks the appearances of various sizes of speech buttons.
input-appearance-searchandspeech.html checks input type='search' field with speech button.
input-appearance-numberandspeech.html checks input type='number' field with speech button.

  • fast/forms/input-appearance-numberandspeech-expected.txt: Added.
  • fast/forms/input-appearance-numberandspeech.html: Added.
  • fast/forms/input-appearance-searchandspeech-expected.txt: Added.
  • fast/forms/input-appearance-searchandspeech.html: Added.
  • fast/forms/input-appearance-speechbutton-expected.txt: Added.
  • fast/forms/input-appearance-speechbutton.html: Added.
  • platform/chromium/test_expectations.txt: Skipped all these new tests as the speech input feature is disabled by default.
  • platform/gtk/Skipped:
  • platform/mac/fast/forms/input-appearance-numberandspeech-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-numberandspeech-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-searchandspeech-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-searchandspeech-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-speechbutton-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-speechbutton-expected.png: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Kent Tamura.

Rendering the speech button in input elements.
https://bugs.webkit.org/show_bug.cgi?id=40984

The button currently has only one state and rendered as an image on all platforms. Subsequent
patches will add user input handling and more states + rendering code to the button. The
button's appearance can be customized by individual ports in their RenderTheme implementation
if required.

Tests: platform/mac/fast/forms/input-appearance-numberandspeech.html

platform/mac/fast/forms/input-appearance-searchandspeech.html
platform/mac/fast/forms/input-appearance-speechbutton.html

  • GNUmakefile.am:
  • Resources/inputSpeech.png: Added.
  • Resources/inputSpeech.tiff: Added. Used by the Mac implementation.
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.qrc:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/qt/ImageQt.cpp: (loadResourcePixmap): Load the speech button images for Qt port.
  • rendering/RenderInputSpeech.cpp: Added. (WebCore::RenderInputSpeech::adjustInputFieldSpeechButtonStyle): Sets the button's dimensions. (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
  • rendering/RenderInputSpeech.h: Added.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): Create the speech button. (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle): (WebCore::RenderTheme::paintInputFieldSpeechButton):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchFieldCancelButton): Get cancel button to render to the left of speech button when enabled.

2010-07-01 Satish Sampath <satish@chromium.org>

Reviewed by Kent Tamura.

Rendering the speech button in input elements.
https://bugs.webkit.org/show_bug.cgi?id=40984

  • Api/qwebsettings.cpp: (graphics):
  • Api/qwebsettings.h:
03:50 Changeset [62248] by commit-queue@webkit.org

2010-07-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] Extra nullcheck needed at SelectionControllerGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=41447

Extra null check added.

  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
03:39 Changeset [62247] by hausmann@webkit.org

[Qt][Symbian] Bumped up the maximum heap size to 96MB

Rubber-stamped by Laszlo Gombos.

.:

  • WebKit.pri:

WebKitTools:

  • QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration

and use the one from WebKit.pri instead.

03:05 Changeset [62246] by yurys@chromium.org

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41350

  • fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
  • fast/events/popup-blocked-from-fake-user-gesture.html: Added.
  • http/tests/inspector/change-iframe-src-expected.txt: Added.
  • http/tests/inspector/change-iframe-src.html: Added.

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41350

Tests: fast/events/popup-blocked-from-fake-user-gesture.html

http/tests/inspector/change-iframe-src.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): use V8Proxy from the ScriptController instead of one from the call stack. Get event directly from hidden property to avoid unnecessary checks.
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8HiddenPropertyName.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::eventAccessorGetter): (WebCore::V8DOMWindow::eventAccessorSetter):

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[v8] Web Inspector: inspected page crashes on attempt to change iframe's src attribute
https://bugs.webkit.org/show_bug.cgi?id=41350

  • src/WebBindings.cpp: (WebKit::getEvent):
02:55 Changeset [62245] by abarth@webkit.org

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Promote webkit-patch land-safely to main help
https://bugs.webkit.org/show_bug.cgi?id=41446

I've been using this command a bunch and recommending it to folks. We
should show it in main help as it's past the experimental phase.

  • Scripts/webkitpy/tool/commands/upload.py:
02:47 Changeset [62244] by zimmermann@webkit.org

2010-07-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGContainer/RenderSVGRoot report wrong strokeBoundingBox()
https://bugs.webkit.org/show_bug.cgi?id=41450

strokeBoundingBox() was reporting the repaintRectInLocalCoordinates() for children of a container,
instead of the actual strokeBoundingBox(). Only visible in WebInspector when looking at a container
which has a resource applied and contains a children which also has a resource applied.

Doesn't affect any test results.

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::objectBoundingBox): (WebCore::RenderSVGContainer::strokeBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::objectBoundingBox): Deinlined this functions, it's virtual so there's no gain. (WebCore::RenderSVGRoot::strokeBoundingBox): Ditto. (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
  • rendering/RenderSVGRoot.h:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerBoundingBox):
  • rendering/SVGRenderSupport.h: Add enum controlling the mode of container bounding box mode calculation.
02:45 Changeset [62243] by zherczeg@webkit.org

WebCore: Implementing feConvolveMatrix svg filter
https://bugs.webkit.org/show_bug.cgi?id=5861

Reviewed by Nikolas Zimmermann.

The implementation is optimized for speed, and uses
multiple algorithms for different parts of the image.
See SVGFEConvolveMatrixElement.cpp for a detailed
description.

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::build):

  • svg/graphics/filters/SVGFEConvolveMatrix.cpp:

(WebCore::clampRGBAValue):
(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
(WebCore::FEConvolveMatrix::getPixelValue):
(WebCore::FEConvolveMatrix::fastSetOuterPixels):
(WebCore::FEConvolveMatrix::setInteriorPixels):
(WebCore::FEConvolveMatrix::setOuterPixels):
(WebCore::FEConvolveMatrix::apply):

  • svg/graphics/filters/SVGFEConvolveMatrix.h:

(WebCore::FEConvolveMatrix::uniteChildEffectSubregions):

LayoutTests: Updating expected values for feConvolveMatrix
https://bugs.webkit.org/show_bug.cgi?id=5861

Reviewed by Nikolas Zimmermann.

  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
02:41 Changeset [62242] by abarth@webkit.org

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Abstract 'a'-'z' checks into a function
https://bugs.webkit.org/show_bug.cgi?id=41438

Hopefully this version is more readable.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
02:29 Changeset [62241] by abarth@webkit.org

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Parameter names in frame src URLs parsed incorrectly if resembles HTML entity code followed by underscore
https://bugs.webkit.org/show_bug.cgi?id=41345

Add some more HTML entity test coverage for when the trailing semicolon
character is required.

  • html5lib/resources/entities02.dat:

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Parameter names in frame src URLs parsed incorrectly if resembles HTML entity code followed by underscore
https://bugs.webkit.org/show_bug.cgi?id=41345

Apparently whether an HTML entity requires a trailing semicolon varies
depending on the entity. The full table is in the spec:

http://www.whatwg.org/specs/web-apps/current-work/multipage/named-character-references.html#named-character-references

I believe branch added in this patch is accurate. At some point, I'll
add a full test suite for all the named entities.

  • html/HTMLEntityParser.cpp: (WebCore::consumeHTMLEntity):
02:06 Changeset [62240] by yurys@chromium.org

2010-07-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
01:36 Changeset [62239] by eric@webkit.org

2010-07-01 Eric Seidel <eric@webkit.org>

Unreviewed. Fix paste-o in Gtk build file.

Split out HTMLFormattingElementList into its own file
https://bugs.webkit.org/show_bug.cgi?id=41440

  • GNUmakefile.am:
01:33 Changeset [62238] by zimmermann@webkit.org

2010-07-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel & Dirk Schulze.

Performance regression for setting content of <text> in SVG
https://bugs.webkit.org/show_bug.cgi?id=36564

Dramatically reducing the number of repaintRectInLocalCoordinates() calls needed while painting.
Do not pass the repaintRect to prepareToRenderSVGContent, only calculate it if opacity < 1 or -webkit-svg-shadow is set.
Most noticeable is that RenderSVGRoot had to visit all children, before actually painting, just to calculate the repaint rect.
And as RenderSVGRoot never carries shadow or opacity it was completly useless.

RenderSVGContainer also called repaintRectInLocalCoordinates, but the result is only needed when painting outlines, which is a rare case.
These modifications fix the performance regression and the number of repaintRectInLocalCoordinate calls for the complex example in
the bug report with 500 runs shrinks from 1.7 million calls to less than 105.000.

50 runs without the patch: ~ 520.8ms
50 runs with the patch : ~ 501.8ms

The test calls setTimeout(0) 50 times, that already accounts for the 500ms. So setting the content of a <text>
element withs clippers applied, is very cheap now.

Also remove the need to pass in a filter argument to prepareToRenderSVGContent/finishRenderSVGContent, it can easily be grabbed
of the cache - just like all other resources are handled, simplifying the code.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::prepareToRenderSVGContent): (WebCore::SVGRenderSupport::finishRenderSVGContent):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
01:20 Changeset [62237] by eric@webkit.org

2010-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make html5lib/runner dump failure details by default
https://bugs.webkit.org/show_bug.cgi?id=41436

This makes it much easier to see our result changes
in patch reviews. Especially when we change behavior
but don't necessarily fix entire subtests.

This patch was previously rolled out due to a bogus comment
in tests1.dat causing a EOF (null) to be emitted in the
results, causing diff to treat the file as binary (and thus
make it impossible to see differences).

The EOF/NULL bug was resolved by bug 41439, so relanding.

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
01:14 Changeset [62236] by morrita@google.com

2010-06-28 MORITA Hajime <morrita@google.com>

Reviewed by Shinichiro Hamaji.

rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
https://bugs.webkit.org/show_bug.cgi?id=38775

  • Introduced SCM.show_head() and SCM.diff_for_file().
  • Replaced direct svn invocations with newly implement SCM methods.
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
01:07 Changeset [62235] by eric@webkit.org

2010-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split out HTMLFormattingElementList into its own file
https://bugs.webkit.org/show_bug.cgi?id=41440

No functional changes, thus no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::indexOfFirstUnopenFormattingElement): (WebCore::HTMLTreeBuilder::reconstructTheActiveFormattingElements):
  • html/HTMLTreeBuilder.h:
00:53 Changeset [62234] by aa@chromium.org

2010-07-01 Aaron Boodman <aa@chromium.org>

Reviewed by Darin Fisher.

Make the user script API static. This makes it more convenient to use
if you don't have a WebView instance yet.

Added static versions of the three methods and re-route current ones
temporarily through the static versions. Will remove the non-static
versions once Chromium has been updated.

Also, expose the URLPattern configuration for user stylesheets, since
they were not before.

https://bugs.webkit.org/show_bug.cgi?id=41385

  • public/WebView.h: (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet):
  • src/WebViewImpl.cpp: (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet): (WebKit::WebView::removeAllUserContent):
00:39 Changeset [62233] by abarth@webkit.org

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

BogusCommentState should come in from the cold
https://bugs.webkit.org/show_bug.cgi?id=41439

Test progression => :)

  • html5lib/runner-expected.txt:
  • html5lib/webkit-resumer-expected.txt:

2010-07-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

BogusCommentState should come in from the cold
https://bugs.webkit.org/show_bug.cgi?id=41439

The BogusCommentState has always been wrong. The proximate issue is
that it didn't handle resuming correctly when parsing a partial input
stream. Now that we have EOF working properly, we can actually
implement this state correctly.

We need to distinguish when we enter this state from when we continue
in this state. We could do that with a branch for each character, but
it seemed easier to split the state in two, even though that leaves us
with one more state in our tokenizer than we have in the HTML5 spec.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::):
00:12 Changeset [62232] by eric@webkit.org

2010-07-01 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r62231.
http://trac.webkit.org/changeset/62231
https://bugs.webkit.org/show_bug.cgi?id=41436

diff thinks runner-expected.txt is binary which makes the
results impossible to read

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:

06/30/10:

23:42 Changeset [62231] by eric@webkit.org

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make html5lib/runner dump failure details by default
https://bugs.webkit.org/show_bug.cgi?id=41436

This makes it much easier to see our result changes
in patch reviews. Especially when we change behavior
but don't necessarily fix entire subtests.

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
23:24 Changeset [62230] by mrobinson@webkit.org

2010-06-30 Martin Robinson <mrobinson@igalia.com>

Unreviewed, rolling out r62226.
http://trac.webkit.org/changeset/62226
https://bugs.webkit.org/show_bug.cgi?id=40333

This change caused 13 new crashers.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_drag_end): (webkit_web_view_drag_data_get): (webkit_web_view_init):
23:22 Changeset [62229] by abarth@webkit.org

2010-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTokenizer's whitespace checks are very redundant
https://bugs.webkit.org/show_bug.cgi?id=41434

This patch adds isTokenizerWhitespace, which replaces a lot of
redundant logic in nextToken.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
23:07 Changeset [62228] by commit-queue@webkit.org

2010-06-30 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Crash when uploading document to Google Docs
https://bugs.webkit.org/show_bug.cgi?id=40795

Fix bug where the local file wasn't opened (for POSTing)
if it were the first element in the form.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::FormDataIODevice::FormDataIODevice): (WebCore::FormDataIODevice::moveToNextElement): (WebCore::FormDataIODevice::openFileForCurrentElement):
  • platform/network/qt/QNetworkReplyHandler.h:
22:53 Changeset [62227] by eric@webkit.org

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement generateImpliedEndTags and deploy to steps which were blocked on it
https://bugs.webkit.org/show_bug.cgi?id=41432

  • html5lib/runner-expected-html5.txt:
    • Test 2.28 is now fixed.

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement generateImpliedEndTags and deploy to steps which were blocked on it
https://bugs.webkit.org/show_bug.cgi?id=41432

This fixes one subtest in html5lib/runner.html and positively
effects a couple others.

More code sharing will be needed here. For the moment
we're using copy/paste code, but that will soon be shared.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::generateImpliedEndTagsWithExclusion): (WebCore::HTMLTreeBuilder::generateImpliedEndTags):
  • html/HTMLTreeBuilder.h:
22:44 Changeset [62226] by mrobinson@webkit.org

2010-06-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
https://bugs.webkit.org/show_bug.cgi?id=40333

Convert draggingDataObjects to a pointer. The constructor and destructor of the
HashMap should be called explicitly. GObject memory allocation does not do this.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose): (webkit_web_view_drag_end): (webkit_web_view_drag_data_get): (webkit_web_view_init):
22:38 Changeset [62225] by mrobinson@webkit.org

2010-06-30 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Update GTK+ expected results after r62215.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
22:26 Changeset [62224] by abarth@webkit.org

2010-06-30 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix Sam's brokeness.

AFAIK, this new expected result is ok (especially given that it still
says PASS).

  • fast/dom/Window/window-postmessage-clone-expected.txt:
17:26 Changeset [62223] by ossy@webkit.org

Unreviewed fix. Update Qt specific expected files after r62215.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
17:07 Changeset [62222] by ossy@webkit.org

Unreviewed buildfix after r62196 and r62214.

  • html/HTMLElementStack.cpp: Put !ENABLE(SVG) guard instead of

!ENABLE(SVG_FOREIGN_OBJECT) around include of SVGNames.h.

17:05 Changeset [62221] by weinig@apple.com

Really fix the windows build.

  • bindings/js/JSBindingsAllInOne.cpp:
17:00 Changeset [62220] by weinig@apple.com

Another Chromium build fix.

  • page/DOMWindow.idl:
16:59 Changeset [62219] by weinig@apple.com

Fix Chromium build.

  • WebCore.gyp/WebCore.gyp:
16:52 Changeset [62218] by weinig@apple.com

Fix Windows build.

  • bindings/js/JSBindingsAllInOne.cpp:
16:50 Changeset [62217] by levin@chromium.org

Added chromium-mac specific results due to new tests added in r62200.

Reviewed by NOBODY (baseline updates corresponding to newly added tests).

  • platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.checksum: Added.
  • platform/chromium/test_expectations.txt: Added failures due to bug 41311.
16:39 Changeset [62216] by weinig@apple.com

Fix Gtk build.

  • GNUmakefile.am:
16:15 Changeset [62215] by weinig@apple.com

WebCore: Patch for https://bugs.webkit.org/show_bug.cgi?id=41146
<rdar://problem/8126069>
Implement the .dataset DOM property

Reviewed by Dan Bernstein.

Tests: fast/dom/dataset-xhtml.xhtml

fast/dom/dataset.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMStringMapCustom.cpp: Added.

(WebCore::JSDOMStringMap::canGetItemsForName):
(WebCore::JSDOMStringMap::nameGetter):
(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):
(WebCore::JSDOMStringMap::putDelegate):

  • bindings/js/JSDOMStringMapCustom.h: Added.
  • dom/DOMStringMap.cpp: Added.

(WebCore::DOMStringMap::~DOMStringMap):

  • dom/DOMStringMap.h: Added.

(WebCore::DOMStringMap::DOMStringMap):

  • dom/DOMStringMap.idl: Added.
  • dom/DatasetDOMStringMap.cpp: Added.

(WebCore::isValidAttributeName):
(WebCore::convertAttributeNameToPropertyName):
(WebCore::propertyNameMatchesAttributeName):
(WebCore::isValidPropertyName):
(WebCore::convertPropertyNameToAttributeName):
(WebCore::DatasetDOMStringMap::ref):
(WebCore::DatasetDOMStringMap::deref):
(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):
(WebCore::DatasetDOMStringMap::setItem):
(WebCore::DatasetDOMStringMap::deleteItem):

  • dom/DatasetDOMStringMap.h: Added.

(WebCore::DatasetDOMStringMap::create):
(WebCore::DatasetDOMStringMap::DatasetDOMStringMap):

  • dom/Element.cpp:

(WebCore::Element::dataset):

  • dom/Element.h:
  • dom/Element.idl:
  • dom/ElementRareData.h:
  • page/DOMWindow.idl:

LayoutTests: Test changes for https://bugs.webkit.org/show_bug.cgi?id=41146
<rdar://problem/8126069>
Implement the .dataset DOM property

Reviewed by Dan Bernstein.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/dataset-expected.txt: Added.
  • fast/dom/dataset-xhtml-expected.txt: Added.
  • fast/dom/dataset-xhtml.xhtml: Added.
  • fast/dom/dataset.html: Added.
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/script-tests/dataset-xhtml.js: Added.
  • fast/dom/script-tests/dataset.js: Added.
  • fast/dom/script-tests/domListEnumeration.js:
  • fast/js/global-constructors-expected.txt:
16:10 Changeset [62214] by darin@apple.com

More Qt build fix.

  • html/HTMLElementStack.cpp: Put !ENABLE(SVG_FOREIGN_OBJECT) around

include of SVGNames.h too.

16:09 Changeset [62213] by darin@apple.com

2010-06-30 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Add assertion, off by default, for when you forget to do adoptRef
https://bugs.webkit.org/show_bug.cgi?id=41422

  • wtf/PassRefPtr.h: Tweaked formatting. Added a new adopted function, called on the pointer by adoptRef, with an empty inline default version, meant to be overloaded. Unified the inlining with a macro named REF_DEREF_INLINE to make it clearer what's going on in the refIfNotNull/derefIfNotNull functions. Renamed releaseRef to leakRef, but left the old name in for compatibility for now.
  • wtf/RefCounted.h: Added code to require adoption and assert if you don't call adoptRef. For now, it is turned off because of the LOOSE_REF_COUNTED define in this header. Later we can turn it on once we get everything working without asserting.

2010-06-30 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Add assertion, off by default, for when you forget to do adoptRef
https://bugs.webkit.org/show_bug.cgi?id=41422

  • platform/TreeShared.h: Added code to require adoption and assert if you don't call adoptRef. For now, it is turned off because of the LOOSE_TREE_SHARED define in this header. Later we can turn it on once we get everything working without asserting. Note also that it only works for objects with an initial reference count of 1.
15:58 Changeset [62212] by weinig@apple.com

Patch for https://bugs.webkit.org/show_bug.cgi?id=41426
Add ImmutableArray class and WKArrayRef API to go with it. This will be used
in a few follow up patches.

Reviewed by Darin Adler.

  • Shared/ImmutableArray.cpp: Added.

(WebKit::ImmutableArray::ImmutableArray):
(WebKit::ImmutableArray::~ImmutableArray):

  • Shared/ImmutableArray.h: Added.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKArray.cpp: Added.
  • UIProcess/API/C/WKArray.h: Added.
  • UIProcess/API/C/WKBase.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:
15:57 Changeset [62211] by ajwong@chromium.org

2010-06-30 Albert J. Wong <ajwong@chromium.org>

Not reviewed. Chromium: Disable flaky test.

Add an IMAGE failure to linux standalone-image-drag-to-editable.html.
Test has been flaky on build.

  • platform/chromium/test_expectations.txt:
15:48 Changeset [62210] by simon.fraser@apple.com

2010-06-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Allow MiniBrowser to open local files
https://bugs.webkit.org/show_bug.cgi?id=41104

Wire up the openDocument: message with an NSOpenPanel, so we can open
local files.

Also change the xib so that the window remembers its size.

  • MiniBrowser/mac/AppDelegate.m: (-[BrowserAppDelegate frontmostBrowserWindowController]): (-[BrowserAppDelegate openDocument:]): (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
  • MiniBrowser/mac/English.lproj/BrowserWindow.xib:
15:34 Changeset [62209] by crogers@google.com

fix build problem for audio branch

15:24 Changeset [62208] by commit-queue@webkit.org

2010-06-30 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Buildfix for !ENABLE(SVG_FOREIGN_OBJECT) after r62196.
https://bugs.webkit.org/show_bug.cgi?id=41429

  • html/HTMLElementStack.cpp:
14:45 Changeset [62207] by eric@webkit.org

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add new popUntil(tagName) function and deploy
https://bugs.webkit.org/show_bug.cgi?id=41405

Add a new popUntil function to share some common code
between states. There is more code to share here, but this
is a start.

I also filled in a couple similar states to these with the
hope of sharing more code, but decided to wait for a later
patch.

No test changes, since this code doesn't do enough yet to
pass any more subtests. Lack of generateImpliedEndTags is the main
blocking issue.

  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::popUntil):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag):
14:44 Changeset [62206] by kbr@google.com

2010-06-30 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Roll forward Chromium DEPS to r51287
https://bugs.webkit.org/show_bug.cgi?id=41430

  • DEPS:
14:24 Changeset [62205] by crogers@google.com

Implement the actual unity gain summing junction code for AudioNodeInput

  • still not handling generic AudioNode case
  • optimizations not yet there, but current implementation will hold us for awhile
14:24 Changeset [62204] by crogers@google.com

Fix performance timer to work multiple times

14:24 Changeset [62203] by crogers@google.com

Add AudioGainNode

14:24 Changeset [62202] by crogers@google.com

Make sure to handle ownership properly (with reference counting) in AudioBufferSourceNode

14:24 Changeset [62201] by crogers@google.com

Initial architectural changes to support unity-gain summing junctions for AudioNode inputs

  • this helps simplifies the javascript API (along with AudioGainNode) so we can get rid of AudioMixerNode and AudioMixerInputNode
  • more work needed to actually do the summing
  • we won't optimize all paths initially, but performance will be adequate
13:49 Changeset [62200] by bdakin@apple.com

20 tests to (at least temporarily) satisfy https://bugs.webkit.org/show_bug.cgi?id=41303 Need way more border-radius tests

Reviewed by Dan Bernstein.

  • fast/borders/border-radius-circle.html: Added.
  • fast/borders/border-radius-groove-01.html: Added.
  • fast/borders/border-radius-groove-02.html: Added.
  • fast/borders/border-radius-groove-03.html: Added.
  • fast/borders/border-radius-wide-border-01.html: Added.
  • fast/borders/border-radius-wide-border-02.html: Added.
  • fast/borders/border-radius-wide-border-03.html: Added.
  • fast/borders/border-radius-wide-border-04.html: Added.
  • fast/borders/borderRadiusDashed04.html: Added.
  • fast/borders/borderRadiusDashed05.html: Added.
  • fast/borders/borderRadiusDashed06.html: Added.
  • fast/borders/borderRadiusDotted04.html: Added.
  • fast/borders/borderRadiusDotted05.html: Added.
  • fast/borders/borderRadiusDotted06.html: Added.
  • fast/borders/borderRadiusDouble04.html: Added.
  • fast/borders/borderRadiusDouble05.html: Added.
  • fast/borders/borderRadiusDouble06.html: Added.
  • fast/borders/borderRadiusDouble07.html: Added.
  • fast/borders/borderRadiusDouble08.html: Added.
  • fast/borders/borderRadiusDouble09.html: Added.
  • platform/mac/fast/borders/border-radius-circle-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-circle-expected.png: Added.
  • platform/mac/fast/borders/border-radius-circle-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-groove-01-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-groove-01-expected.png: Added.
  • platform/mac/fast/borders/border-radius-groove-01-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-groove-02-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-groove-02-expected.png: Added.
  • platform/mac/fast/borders/border-radius-groove-02-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-groove-03-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-groove-03-expected.png: Added.
  • platform/mac/fast/borders/border-radius-groove-03-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-wide-border-01-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-wide-border-01-expected.png: Added.
  • platform/mac/fast/borders/border-radius-wide-border-01-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-wide-border-02-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-wide-border-02-expected.png: Added.
  • platform/mac/fast/borders/border-radius-wide-border-02-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-wide-border-03-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-wide-border-03-expected.png: Added.
  • platform/mac/fast/borders/border-radius-wide-border-03-expected.txt: Added.
  • platform/mac/fast/borders/border-radius-wide-border-04-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-wide-border-04-expected.png: Added.
  • platform/mac/fast/borders/border-radius-wide-border-04-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDashed04-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDashed04-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDashed04-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDashed05-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDashed05-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDashed05-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDashed06-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDashed06-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDashed06-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDotted04-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDotted04-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDotted04-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDotted05-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDotted05-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDotted05-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDotted06-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDotted06-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDotted06-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble04-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble04-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble04-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble05-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble05-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble05-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble06-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble06-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble06-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble07-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble07-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble07-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble08-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble08-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble08-expected.txt: Added.
  • platform/mac/fast/borders/borderRadiusDouble09-expected.checksum: Added.
  • platform/mac/fast/borders/borderRadiusDouble09-expected.png: Added.
  • platform/mac/fast/borders/borderRadiusDouble09-expected.txt: Added.
13:48 Changeset [62199] by weinig@apple.com

Add debug-webkittestrunner and cleanup related scripts.

Rubber-stamped by Anders Carlsson.

  • Scripts/debug-webkittestrunner: Added.
  • Scripts/run-webkittestrunner:
  • Scripts/webkitdirs.pm:
13:11 Changeset [62198] by xan@webkit.org

WebCore:

2010-06-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Unit test for DOM insertion methods
https://bugs.webkit.org/show_bug.cgi?id=40495

Fix typo in custom function detection method.

  • bindings/scripts/CodeGeneratorGObject.pm:

WebKit/gtk:

2010-06-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Unit test for DOM insertion methods
https://bugs.webkit.org/show_bug.cgi?id=40495

Add unit test for webkit_dom_node_remove_child.

  • tests/testdomnode.c: (test_dom_node_insertion):
13:11 Changeset [62197] by xan@webkit.org

2010-06-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Unit test for DOM insertion methods
https://bugs.webkit.org/show_bug.cgi?id=40495

Add unit tests for node insertion and replacement methods.

  • tests/testdomnode.c: (test_dom_node_insertion): (main):
13:02 Changeset [62196] by eric@webkit.org

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement HTML5 "in scope" algorithm and attempt to use it
https://bugs.webkit.org/show_bug.cgi?id=41402

Adds two new (expected) failures, since we're now
switching out of InBody to AfterBody when seeing
</html>. We don't implement AfterBody yet, so
the rest of the content after </html> is ignored.

  • html5lib/runner-expected-html5.txt:

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Implement HTML5 "in scope" algorithm and attempt to use it
https://bugs.webkit.org/show_bug.cgi?id=41402

Implemented the 4 needed "in scope" functions for HTML5.
3 for the different sets of scope markers, and one for
doing exact element comparisons instead of tag name searches.

I deployed inScope("body") for </body> and </html> in InBody.

Adds two new (expected) failures, since we're now
switching out of InBody to AfterBody when seeing
</html>. We don't implement AfterBody yet, so
the rest of the content after </html> is ignored.

  • html/HTMLElementStack.cpp: (WebCore::inScopeCommon): (WebCore::HTMLElementStack::inScope): (WebCore::HTMLElementStack::inListItemScope): (WebCore::HTMLElementStack::inTableScope):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): (WebCore::HTMLTreeBuilder::processEndTag):
  • html/HTMLTreeBuilder.h:
12:50 Changeset [62195] by eric@webkit.org

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split HTMLElementStack out into its own file
https://bugs.webkit.org/show_bug.cgi?id=41399

No functional change, thus no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementStack.cpp: Added. (WebCore::HTMLElementStack::ElementRecord::ElementRecord): (WebCore::HTMLElementStack::ElementRecord::element): (WebCore::HTMLElementStack::ElementRecord::next): (WebCore::HTMLElementStack::ElementRecord::releaseNext): (WebCore::HTMLElementStack::ElementRecord::setNext): (WebCore::HTMLElementStack::HTMLElementStack): (WebCore::HTMLElementStack::~HTMLElementStack): (WebCore::HTMLElementStack::popHTMLHeadElement): (WebCore::HTMLElementStack::pop): (WebCore::HTMLElementStack::pushHTMLHtmlElement): (WebCore::HTMLElementStack::pushHTMLHeadElement): (WebCore::HTMLElementStack::pushHTMLBodyElement): (WebCore::HTMLElementStack::push): (WebCore::HTMLElementStack::top): (WebCore::HTMLElementStack::removeHTMLHeadElement): (WebCore::HTMLElementStack::remove): (WebCore::HTMLElementStack::contains): (WebCore::HTMLElementStack::inScope): (WebCore::HTMLElementStack::htmlElement): (WebCore::HTMLElementStack::headElement): (WebCore::HTMLElementStack::bodyElement): (WebCore::HTMLElementStack::pushCommon): (WebCore::HTMLElementStack::popCommon): (WebCore::HTMLElementStack::removeNonFirstCommon):
  • html/HTMLElementStack.h: Added.
  • html/HTMLTreeBuilder.h:
12:17 Changeset [62194] by kbr@google.com

2010-06-30 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

WebCore::WebGLArrayInternal::lengthAttrGetter ReadAV@NULL (b1a3e1a3e9d01f17fd493d68eeb2742f)
https://bugs.webkit.org/show_bug.cgi?id=38040

Changed custom ArrayBufferView constructors to create a
fully-initialized, zero-length array when called with zero
arguments. This is the simplest fix which works identically in
both the JSC and V8 bindings.

Test: fast/canvas/webgl/array-buffer-view-crash.html

  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferView):
  • bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray):

2010-06-30 Kenneth Russell <kbr@google.com>

Reviewed by Oliver Hunt.

WebCore::WebGLArrayInternal::lengthAttrGetter ReadAV@NULL (b1a3e1a3e9d01f17fd493d68eeb2742f)
https://bugs.webkit.org/show_bug.cgi?id=38040

Changed custom ArrayBufferView constructors to create a
fully-initialized, zero-length array when called with zero
arguments. This is the simplest fix which works identically in
both the JSC and V8 bindings.

  • fast/canvas/webgl/array-buffer-view-crash-expected.txt: Added.
  • fast/canvas/webgl/array-buffer-view-crash.html: Added.
11:49 Changeset [62193] by jocelyn.turcotte@nokia.com

2010-06-30 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make sure we catch closed QComboBox popups.
https://bugs.webkit.org/show_bug.cgi?id=39019

The way it works currently is using the QComboBox::show/hidePopup
virtual method to catch popup requests in the middle. There is
some cases however that the popup widget gets closed without
going through the hidePopup method.

This patch adds an event filter to the popup's view to know when
it gets closed and calls hidePopup to call our handling code.
This may get hidePopup called twice but this shouldn't have any
effect.

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::QtFallbackWebPopupCombo): (WebCore::QtFallbackWebPopupCombo::eventFilter):
  • WebCoreSupport/QtFallbackWebPopup.h:
10:53 Changeset [62192] by kevino@webkit.org

[wx] Build fix after recent changes to LayoutTestController.

10:33 Changeset [62191] by weinig@apple.com

Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
Make WebKitTestRunner work with more than one test at a time.

Reviewed by Anders Carlsson.

This converts WebKitTestRunner to a similar model as DumpRenderTree,
where there is a single WKView and each test is run it, rather than
the design I was using where each test got its own WKView.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didRecieveMessage):
(WTR::InjectedBundle::reset):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
(WTR::TestController::runTest):
(WTR::TestController::_didRecieveMessageFromInjectedBundle):
(WTR::TestController::didRecieveMessageFromInjectedBundle):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::mainWebView):
(WTR::TestController::pageNamespace):
(WTR::TestController::context):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::~TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didRecieveMessageFromInjectedBundle):

  • WebKitTestRunner/TestInvocation.h:
10:00 Changeset [62190] by andersca@apple.com

Add reviewer.

10:00 Changeset [62189] by victorw@chromium.org

2010-06-30 Victor Wang <victorw@chromium.org>

Reviewed by Darin Fisher.

[chromium] update webcore gyp to use v8 dll for chromium multi dll build.

https://bugs.webkit.org/show_bug.cgi?id=41376

  • WebCore.gyp/WebCore.gyp:
09:38 Changeset [62188] by leandro@webkit.org

2010-06-30 Leandro Pereira <leandro@profusion.mobi>

Unreviewed.

Generate CSSValueKeywords.cpp instead of CSSValueKeywords.c to avoid
recompilation and relinking of WebCore when no files were changed.

  • cmake/WebKitGenerators.cmake:
09:26 UsingGitWithWebKit edited by ojan@chromium.org
(diff)
08:52 Changeset [62187] by jeremy@chromium.org

2010-06-30 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add OOP font loading to FontPlatformDataChromiumMac.

On OS X, with font management software installed. Fonts
can reside in an arbitrary path on disk which is blocked by
Chromium's sandbox.

This change adds hooks to FontPlaformData which allow cross-process
font loading in case of need.

https://bugs.webkit.org/show_bug.cgi?id=41148

Not possible to test - requires sandboxing which DRT doesn't support.

  • WebCore.gypi:
  • platform/graphics/chromium/FontPlatformDataChromiumMac.mm: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::roundsGlyphAdvances): (WebCore::FontPlatformData::allowsLigatures): (WebCore::FontPlatformData::description):
08:29 Changeset [62186] by jeremy@chromium.org

2010-06-30 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dan Bernstein.

Minor tweaks to FontPlatformDataMac & SimpleFontDataMac.mm

  • Avoid an extra FontPlatformData copy in SimpleFontDataMac.mm
  • Fix a typo in FontPlatformDataMac.mm

https://bugs.webkit.org/show_bug.cgi?id=41152

No behavior changes so no new tests.

  • platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::description):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::copyFontTableForTag):
08:16 Changeset [62185] by commit-queue@webkit.org

2010-06-30 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make "disallow multiple calls to SetWindow" on windowed plugins a quirk
https://bugs.webkit.org/show_bug.cgi?id=41407

Only disallow calling SetWindow more than once if we're using Flash 9 or older.
This fixes resizing of YouTube videos via the player's own button.

Removed copy-pasted logic in PluginViewGtk since the issue only exists
when running Flash with a non-Gtk toolkit.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::determineQuirks):
  • plugins/PluginQuirkSet.h: (WebCore::):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded): Remove unnecessary logic copy-pasted from PluginViewQt.
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
07:20 Changeset [62184] by commit-queue@webkit.org

2010-06-30 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antti Koivisto.

[Qt, Gtk, Symbian] Mind the semantics of NPRect for windowed plugin clip rects
https://bugs.webkit.org/show_bug.cgi?id=41406

NPRect has right/bottom instead of width/height.
This was fixed in PluginViewMac with http://trac.webkit.org/changeset/45815

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::setNPWindowIfNeeded):
07:02 Changeset [62183] by yurys@chromium.org

2010-06-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r62182.
http://trac.webkit.org/changeset/62182
https://bugs.webkit.org/show_bug.cgi?id=41408

GTK build brekage (Requested by pfeldman on #webkit).

  • inspector/debugger-eval-while-paused-expected.txt: Removed.
  • inspector/debugger-eval-while-paused.html: Removed.
  • platform/qt/Skipped:
06:11 Changeset [62182] by yurys@chromium.org

2010-06-30 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add layout test for console evaluations with paused script
https://bugs.webkit.org/show_bug.cgi?id=41336

  • inspector/debugger-eval-while-paused-expected.txt: Added.
  • inspector/debugger-eval-while-paused.html: Added.
  • platform/qt/Skipped:
06:04 Changeset [62181] by aroben@apple.com

Update Windows test results after r62092

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
06:03 Changeset [62180] by commit-queue@webkit.org

2010-06-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement windowRect() and setWindowRect() in ChromeClientEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=40876

  • efl/WebCoreSupport/ChromeClientEfl.cpp: Implements two methods to change window size.

(WebCore::ChromeClientEfl::windowRect):
(WebCore::ChromeClientEfl::setWindowRect):

05:38 Changeset [62179] by tonikitoo@webkit.org

2010-06-30 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Fraser.

Spatial Navigation: make elements in inner frames nested more than 1 level deep focusable
https://bugs.webkit.org/show_bug.cgi?id=41160

Patch addresses the problem of spatial navigation not work properly with nested
inner frames by adding the isNodeDeepDescendantOfDocument function. It recursively checks
if a give node is descendant of a given document or any parent of it.

Test: fast/events/spatial-navigation/snav-iframe-nested.html

  • page/FocusController.cpp: (WebCore::FocusController::deepFindFocusableNodeInDirection):
  • page/SpatialNavigation.cpp: (WebCore::isNodeDeepDescendantOfDocument):
  • page/SpatialNavigation.h:
  • fast/events/spatial-navigation/resources/iframe.html: Added.
  • fast/events/spatial-navigation/snav-iframe-nested-expected.txt: Added.
  • fast/events/spatial-navigation/snav-iframe-nested.html: Added.
05:27 Changeset [62178] by pfeldman@chromium.org

2010-06-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chrome DevTools: Finalize migration to new WebView constructor
(devtools agent is now created within WebViewImpl only).

https://bugs.webkit.org/show_bug.cgi?id=41212

  • public/WebDevToolsAgent.h:
  • public/WebView.h:
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):
  • tests/PopupMenuTest.cpp: (WebKit::SelectPopupMenuTest::SetUp):
05:15 Changeset [62177] by yurys@chromium.org

2010-06-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
05:01 Changeset [62176] by hausmann@webkit.org

[Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
https://bugs.webkit.org/show_bug.cgi?id=40446

Reviewed by Laszlo Gombos.

We quickly run out of memory on Symbian when loading web pages. This is
caused by the default heap size, which is not suited for a web browser.

This change bumps the max heap size to 32MB.

  • QtTestBrowser/QtTestBrowser.pro:
03:27 Changeset [62175] by abarth@webkit.org

2010-06-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTokenizer should use fewer macros
https://bugs.webkit.org/show_bug.cgi?id=41397

Macros are sadness. Inline functions are the new hotness.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processEntity): (WebCore::HTMLTokenizer::emitAndResumeIn): (WebCore::HTMLTokenizer::emitAndReconsumeIn): (WebCore::HTMLTokenizer::emitEndOfFile): (WebCore::HTMLTokenizer::flushBufferedEndTag): (WebCore::HTMLTokenizer::flushEmitAndResumeIn): (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::bufferCharacter): (WebCore::HTMLTokenizer::bufferCodePoint): (WebCore::HTMLTokenizer::bufferParseError): (WebCore::HTMLTokenizer::bufferCurrentToken): (WebCore::HTMLTokenizer::bufferEndOfFile):
  • html/HTMLTokenizer.h:
03:10 Changeset [62174] by jschuh@chromium.org

2010-06-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Remove dead binding code
https://bugs.webkit.org/show_bug.cgi?id=41388

Removed BindingElement because it was obsoleted by r59866.

  • WebCore.gypi:
  • bindings/generic/BindingElement.h: Removed.
  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8Binding.h:
  • bindings/v8/custom/V8DatabaseCustom.cpp:
  • bindings/v8/custom/V8DatabaseSyncCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
02:46 Changeset [62173] by eric@webkit.org

2010-06-30 Eric Seidel <eric@webkit.org>

Unreviewed. Just updating test expectations.

HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344

Update results after EndOfFile support.
The final pump will always have one character,
which is the EOF character.

  • inspector/timeline-parse-html-expected.txt:
02:14 Changeset [62172] by eric@webkit.org

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344

EndOfFile support uncovered a bug in our implementation of finish().
finish() may be called more than once if the first call does not
result in end() being called (and parsing thus actually stopping).

SegmentedString::close() should have ASSERTed that it was not already
closed when close() is called. I've added such an assert now.

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finish):
  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::close):
  • platform/text/SegmentedString.h:
01:54 Changeset [62171] by hausmann@webkit.org

Unreviewed Symbian build fix.

[Qt] Update the def files to link DumpRenderTree.

  • symbian/eabi/QtWebKitu.def:
01:45 Changeset [62170] by eric@webkit.org

2010-06-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch land allow the user to continue even if the builders are red
https://bugs.webkit.org/show_bug.cgi?id=41395

I don't think it's good that we've been teaching people
to always pass --ignore-builders. At least land is now
useable w/o --ignore-builders.

  • Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
01:35 Changeset [62169] by commit-queue@webkit.org

2010-06-30 Samuel Nevala <samuel.nevala@digia.com>

Reviewed by Simon Hausmann.

[Qt] Auto test wont compile from \3rdparty\webkit\WebKit\qt\tests
https://bugs.webkit.org/show_bug.cgi?id=38720

Load qttest_p4.prf under QTDIR_build.

  • tests/tests.pri:
01:28 Changeset [62168] by eric@webkit.org

2010-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344

We now pass an additional 60 subtests for the
html5lib test suite. Boo-ya.

  • html5lib/runner-expected.txt:

2010-06-29 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

HTMLTokenizer needs EndOfFile support
https://bugs.webkit.org/show_bug.cgi?id=41344

We're using \0 as the EndOfFile marker as HTML5 replaces
all other \0 with \0xFFFD. Added some special case logic
to InputStreamPreprocessor::peek not to replace \0 when
its being used at the end of a stream.

This fixed 60 subtests in html5lib/runner.html.

There are still at least two states (BogusCommentState and
CDATASectionState) which do not have proper EOF support.

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::finish): (WebCore::HTMLDocumentParser::finishWasCalled):
  • html/HTMLInputStream.h: (WebCore::HTMLInputStream::markEndOfFile): (WebCore::HTMLInputStream::haveSeenEndOfFile):
  • html/HTMLToken.h: (WebCore::HTMLToken::makeEndOfFile):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::emitEndOfFile):
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek): (WebCore::HTMLTokenizer::InputStreamPreprocessor::shouldTreatNullAsEndOfFileMarker):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
01:23 Changeset [62167] by commit-queue@webkit.org

2010-06-30 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] Random failure on 'testdownload' unit test
https://bugs.webkit.org/show_bug.cgi?id=38256

Make sure the set_filename function is called after handling the
'download-requested' signal for the asynchronous test. This change
is needed because it could happen, with the current code, that the
set_filename () function got called too early in the mainloop,
therefore screwing the tests because the 'theDownload' global
variable wouldn't be properly set yet.

With this modification we ensure the set_filename() function gets
called always after handling the download-requested signal,
therefore avoiding potentialproblems.

  • tests/testdownload.c: (set_filename): (handle_download_requested_cb): (download_requested_cb): (download_requested_asynch_cb): (test_webkit_download_perform):
01:18 Changeset [62166] by eric@webkit.org

2010-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach HTML5TreeBuilder how to merge attributes from extra html/body elements
https://bugs.webkit.org/show_bug.cgi?id=41337

  • html5lib/resources/webkit01.dat: Add a test for double body.

2010-06-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Teach HTML5TreeBuilder how to merge attributes from extra html/body elements
https://bugs.webkit.org/show_bug.cgi?id=41337

Had to teach ElementStack to store pointers to html, head, and body
elements.

This fixed a few tests in LayoutTests/html5lib.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML): (WebCore::HTMLTreeBuilder::mergeAttributesFromTokenIntoElement): (WebCore::HTMLTreeBuilder::insertHTMLStartTagInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::createElementAndAttachToCurrent): (WebCore::HTMLTreeBuilder::insertHTMLHtmlElement): (WebCore::HTMLTreeBuilder::insertHTMLHeadElement): (WebCore::HTMLTreeBuilder::insertHTMLBodyElement): (WebCore::HTMLTreeBuilder::insertElement): (WebCore::HTMLTreeBuilder::insertGenericRCDATAElement): (WebCore::HTMLTreeBuilder::insertGenericRawTextElement):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::ElementStack): (WebCore::HTMLTreeBuilder::ElementStack::popHTMLHeadElement): (WebCore::HTMLTreeBuilder::ElementStack::pop): (WebCore::HTMLTreeBuilder::ElementStack::pushHTMLHtmlElement): (WebCore::HTMLTreeBuilder::ElementStack::pushHTMLHeadElement): (WebCore::HTMLTreeBuilder::ElementStack::pushHTMLBodyElement): (WebCore::HTMLTreeBuilder::ElementStack::push): (WebCore::HTMLTreeBuilder::ElementStack::removeHTMLHeadElement): (WebCore::HTMLTreeBuilder::ElementStack::remove): (WebCore::HTMLTreeBuilder::ElementStack::htmlElement): (WebCore::HTMLTreeBuilder::ElementStack::headElement): (WebCore::HTMLTreeBuilder::ElementStack::bodyElement): (WebCore::HTMLTreeBuilder::ElementStack::pushCommon): (WebCore::HTMLTreeBuilder::ElementStack::popCommon): (WebCore::HTMLTreeBuilder::ElementStack::removeNonFirstCommon):
01:15 Changeset [62165] by yurys@chromium.org

2010-06-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed: update Chromium test expectations with a crashing test.

  • platform/chromium/test_expectations.txt:
01:12 Changeset [62164] by commit-queue@webkit.org

2010-06-30 José Millán Soto <jmillan@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Text attributes not exposed
https://bugs.webkit.org/show_bug.cgi?id=25528

Implemented the get_run_attributes and get_default_attributes
functions for the ATK_TEXT role.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getAttributeSetForAccessibilityObject): (compareAttribute): (attributeSetDifference): (accessibilityObjectLength): (getAccessibilityObjectForOffset): (getRunAttributesFromAccesibilityObject): (webkit_accessible_text_get_run_attributes): (webkit_accessible_text_get_default_attributes):

2010-06-30 José Millán Soto <jmillan@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Text attributes not exposed
https://bugs.webkit.org/show_bug.cgi?id=25528

Added new tests for accessible text attributes

  • tests/testatk.c: (compAtkAttribute): (compAtkAttributeName): (atkAttributeSetAttributeHasValue): (atkAttributeSetAreEqual): (testWebkitAtkTextAttributes): (main):
01:00 Changeset [62163] by commit-queue@webkit.org

2010-06-30 Yuta Kitamura <yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix Sec-WebSocketKey{1,2} headers.

According to WebSocket specification, a value of Sec-WebSocketKey{1,2} header
should not start or end with a space.

WebSocket: Malformed handshake headers in a worker due to rand_s failing
https://bugs.webkit.org/show_bug.cgi?id=41327

No new tests. ASSERT should catch the problem.

  • websockets/WebSocketHandshake.cpp: (WebCore::generateSecWebSocketKey):
00:43 Changeset [62162] by yurys@chromium.org

2010-06-30 Yury Semikhatsky <yurys@chromium.org>

Unreviewed: provide custom expectations and reenable the test for Chromium.

https://bugs.webkit.org/show_bug.cgi?id=41394

  • platform/chromium/editing/pasteboard/5761530-1-expected.txt: Added.
Note: See TracTimeline for information about the timeline view.