Timeline


and

07/19/10:

23:54 Changeset [63725] by krit@webkit.org

2010-07-19 Dirk Schulze <krit@webkit.org>

SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410

Unreviewed update of Win baseline.

  • platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/win/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/win/svg/custom/relative-sized-use-on-symbol-expected.txt: Added.
  • platform/win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/win/svg/custom/use-css-events-expected.txt: Added.
  • platform/win/svg/dom: Added.
  • platform/win/svg/dom/path-parser-expected.txt: Added.
23:41 Changeset [63724] by krit@webkit.org

2010-07-19 Dirk Schulze <krit@webkit.org>

SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410

Unreviewed update of Qt baseline.

  • platform/qt/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
23:28 Changeset [63723] by commit-queue@webkit.org

2010-07-19 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

Added a simple implementation of VideoLayerChromium. Uses the
LayerChromium::updateTextureRect() to send video frames to the
GPU.
https://bugs.webkit.org/show_bug.cgi?id=42234

  • WebCore.gypi: Added include for VideoLayerChromium.
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToMedia): Implemented setContentsToMedia, though it does not seem to trigger a repaint correctly.
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: Added. (WebCore::VideoLayerChromium::create): (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents):
  • platform/graphics/chromium/VideoLayerChromium.h: Added. (WebCore::VideoLayerChromium::drawsContent):

2010-07-19 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

Updated WebMediaPlayer to support accelerated rendering and to
create and return a VideoChromiumLayer as its platform layer.
https://bugs.webkit.org/show_bug.cgi?id=42234

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::platformLayer): (WebKit::WebMediaPlayerClientImpl::create):
  • src/WebMediaPlayerClientImpl.h: (WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
23:23 Changeset [63722] by yuzo@google.com

2010-07-19 Yuzo Fujishima <yuzo@google.com>

Unreviewed test expectation fix.

fast/css/font-face-download-error.html should be skipped for Qt like
other @font-face tests.
https://bugs.webkit.org/show_bug.cgi?id=42342

  • platform/qt/Skipped:
22:37 Changeset [63721] by krit@webkit.org

2010-07-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410

Added piOverTwo to MathExtras.

  • wtf/MathExtras.h:

2010-07-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410

Cleanup the parsing code for SVG Paths. Move classes out of the convoluted SVGParserUtilities.cpp
in their own files. Make use of WebCore specific objects in parsing code like FloatPoint, AffineTransform,
etc. instead of using home-brewn solutions.
The SVGPathParser parses a path data string and delivers the parsed segments and values to the SVGPathConsumer.
SVGPathConsumer is the base class for SVGPathBuilder and SVGPathSegListBuilder, that either build the platform
Path object or a SVGPathSegList out of the segments.
We're now directly parsing floats instead of truncating precision to float afterwards.

SVG Path with an arc with radius of 0 does not render
https://bugs.webkit.org/show_bug.cgi?id=40448

If one of the radii on the elliptic arc are zero, we should draw a line from the starting point to
the end point according to the spec. Fixed this bug with this patch, because an is zero check and
an DRT check was neccessary with the current clean-up.
Extended svg/dom/path-parser.xhml to check the correct behavior.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::move): Follow WebKit style and use multiple lines for the function. (WebCore::FloatPoint::scale): Scale FloatPoint. (WebCore::operator+=): (WebCore::operator+): Add two FloatPoints and give back the sum as FloatPoint.
  • svg/SVGAllInOne.cpp: Added new created files.
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): Use new PathParser to create a PathSegList.
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute): Use new PathParser to create a Path.
  • svg/SVGGlyphElement.cpp: (WebCore::parsePathData): Use new PathParser to create a Path.
  • svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag): Removed parseArcFlag(double&), we parse in float now.
  • svg/SVGParserUtilities.h: Removed path parsing code and a lot of unneccessary includes.
  • svg/SVGPathBuilder.cpp: Added. (WebCore::SVGPathBuilder::SVGPathBuilder): (WebCore::SVGPathBuilder::build): Builds a normalized Path. (WebCore::SVGPathBuilder::moveTo): (WebCore::SVGPathBuilder::lineTo): (WebCore::SVGPathBuilder::curveToCubic): (WebCore::SVGPathBuilder::closePath):
  • svg/SVGPathBuilder.h: Added. We just create normalized Paths, so this functions should never be reached. (WebCore::SVGPathBuilder::lineToHorizontal): (WebCore::SVGPathBuilder::lineToVertical): (WebCore::SVGPathBuilder::curveToCubicSmooth): (WebCore::SVGPathBuilder::curveToQuadratic): (WebCore::SVGPathBuilder::curveToQuadraticSmooth): (WebCore::SVGPathBuilder::arcTo):
  • svg/SVGPathConsumer.h: Added. Base class of SVGPathBuilder and SVGPathSegListBuilder. (WebCore::): (WebCore::SVGPathConsumer::SVGPathConsumer): (WebCore::SVGPathConsumer::~SVGPathConsumer):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::parseMappedAttribute): Use new PathParser to create a PathSegList.
  • svg/SVGPathParser.cpp: Added. (WebCore::SVGPathParser::SVGPathParser): (WebCore::SVGPathParser::~SVGPathParser): (WebCore::SVGPathParser::parseClosePathSegment): (WebCore::SVGPathParser::parseMoveToSegment): (WebCore::SVGPathParser::parseLineToSegment): (WebCore::SVGPathParser::parseLineToHorizontalSegment): (WebCore::SVGPathParser::parseLineToVerticalSegment): (WebCore::SVGPathParser::parseCurveToCubicSegment): (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathParser::parseArcToSegment): (WebCore::SVGPathParser::parsePathDataString): (WebCore::SVGPathParser::decomposeArcToCubic): Normalizes an arc to multiple cubic curves.
  • svg/SVGPathParser.h: Added.
  • svg/SVGPathSegListBuilder.cpp: Added. (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder): (WebCore::SVGPathSegListBuilder::build): (WebCore::SVGPathSegListBuilder::moveTo): (WebCore::SVGPathSegListBuilder::lineTo): (WebCore::SVGPathSegListBuilder::lineToHorizontal): (WebCore::SVGPathSegListBuilder::lineToVertical): (WebCore::SVGPathSegListBuilder::curveToCubic): (WebCore::SVGPathSegListBuilder::curveToCubicSmooth): (WebCore::SVGPathSegListBuilder::curveToQuadratic): (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::arcTo): (WebCore::SVGPathSegListBuilder::closePath):
  • svg/SVGPathSegListBuilder.h: Added.

2010-07-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410

Parsing values as float instead of double causes some minimal changes on DRT results and
pixel results. Even if the values get shrinked to float before the calculation of arc and
others. But the calculation itself transforms the values back to double and shrinks it to
floats again right before the drawing.

SVG Path with an arc with radius of 0 does not render
https://bugs.webkit.org/show_bug.cgi?id=40448

Extended svg/dom/path-parser.xhml to check the correct behavior. We draw a line from the
current point to the given end point.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/mac/svg/custom/use-css-events-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/hixie/perf/007-expected.checksum:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/hixie/perf/007-expected.txt:
  • svg/custom/path-getTotalLength-expected.txt:
  • svg/dom/path-parser-expected.txt:
  • svg/dom/script-tests/path-parser.js:
22:28 Changeset [63720] by ossy@webkit.org

Unreviewed trivial fix after r63684.
https://bugs.webkit.org/show_bug.cgi?id=30464

  • fast/dom/Window/window-properties-expected.txt: Updated.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
22:10 Changeset [63719] by yuzo@google.com

2010-07-15 Yuzo Fujishima <yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 42342 - Font download error for an @font-face rule invalidates other @font-face rules for the same font-family
https://bugs.webkit.org/show_bug.cgi?id=42342

  • fast/css/font-face-download-error-expected.txt: Added.
  • fast/css/font-face-download-error.html: Added.

2010-07-15 Yuzo Fujishima <yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 42342 - Font download error for an @font-face rule invalidates other @font-face rules for the same font-family
https://bugs.webkit.org/show_bug.cgi?id=42342

Test: fast/css/font-face-download-error.html

  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::isValid): Valid if at least one font face is valid. (WebCore::CSSSegmentedFontFace::getFontData): Check validity for each font face.
  • css/CSSSegmentedFontFace.h: Make isValid private.
21:33 Changeset [63718] by tkent@chromium.org

2010-07-19 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[Chromium] Fix style errors of RenderThemeChromiumWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=42568

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::getNonClientMetrics): (WebCore::systemFontSize): (WebCore::pointsToPixels): (WebCore::querySystemBlinkInterval): (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
21:32 Changeset [63717] by sfalken@apple.com

(Hopefully the last) Windows build fix.

Version of CoreServices.h in WebKit Support Libraries uses
pragma once, unlike the version I have locally. Switch based
on COLORSYNCDEPRECATED instead.

  • WebCorePrefix.h:
21:17 Changeset [63716] by sfalken@apple.com

Windows build fix.

  • WebCorePrefix.h:
21:09 Changeset [63715] by andersca@apple.com

Remove now passing tests from the skipped list.

Reviewed by Maciej Stachowiak.

  • platform/mac-wk2/Skipped:
21:05 Changeset [63714] by andersca@apple.com

Fix build.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Paths of generated files should be relative to the build product.

20:42 Changeset [63713] by laszlo.1.gombos@nokia.com

2010-07-19 Mike Moretti <mike.moretti@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] Build fix after r63404.

Implement isValid() function for the Symbian executable allocator.

  • jit/ExecutableAllocatorSymbian.cpp: (JSC::ExecutableAllocator::isValid):
20:24 Changeset [63712] by sfalken@apple.com

Build fix.

  • WebCorePrefix.h:
20:14 Changeset [63711] by sfalken@apple.com

Build fix.

  • WebCorePrefix.h:
20:01 Changeset [63710] by dbates@webkit.org

2010-07-19 Daniel Bates <dbates@rim.com>

Reviewed by Adam Roben.

[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930

Implements support for markerTextForListItem in the Windows port.

  • DOMCoreClasses.cpp: (DOMElement::markerTextForListItem): Added.
  • DOMCoreClasses.h:
  • Interfaces/DOMPrivate.idl: Added declaration for markerTextForListItem().
  • Interfaces/IWebViewPrivate.idl: Added declaration for elementFromJS().
  • Interfaces/WebKit.idl: Touch it to force a rebuild (and for good luck :-)).
  • WebView.cpp: (WebView::elementFromJS): Added.
  • WebView.h:

2010-07-19 Daniel Bates <dbates@rim.com>

Reviewed by Adam Roben.

[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930

Remove skipped layout tests now that we have DRT support.

  • platform/win/Skipped:

2010-07-19 Daniel Bates <dbates@rim.com>

Reviewed by Adam Roben.

[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930

Implements DRT support for markerTextForListItem in the Windows port.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::markerTextForListItem): Implemented.
20:00 Changeset [63709] by sfalken@apple.com

Windows Build fixes for new ColorSync API.
We support both new and old APIs, since the newer headers aren't in the tree yet.

  • WebCorePrefix.h: Removed include of CoreServices.h. Included via ColorSyncPriv.h instead, since header may not be present.
  • platform/graphics/cg/ColorCG.cpp:

(WebCore::createCGColor): Conditionally use new ColorSync API.

  • platform/graphics/opentype/OpenTypeUtilities.cpp: Define Fixed if CoreServices.h doesn't.
  • platform/graphics/win/GraphicsLayerCACF.cpp:

(WebCore::GraphicsLayerCACF::updateLayerDrawsContent): Use 0 instead of nil, since nil is no longer present via CoreServices.h.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: Include AssertMacros.h.
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::operator CFErrorRef): Use 0 instead of nil, since nil is no longer present via CoreServices.h.

19:40 Changeset [63708] by andersca@apple.com

WebKitTestRunner and WebProcess simultaneously stall in CoreIPC::Connection::sendOutgoingMessage
https://bugs.webkit.org/show_bug.cgi?id=42356

Reviewed by Sam Weinig.

Up the port queue length from 5 to 1024. While this does solve the problem, we should still try to
make sendOutgoingMessage not block. I've filed https://bugs.webkit.org/show_bug.cgi?id=42611 to track
doing this on Mac and Windows.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):
Call setMachPortQueueLength.

  • Platform/mac/MachUtilities.cpp: Added.

(setMachPortQueueLength):
Given a mach port receive right, sets the port queue length.

  • Platform/mac/MachUtilities.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Add MachUtilities.cpp and MachUtilities.h

19:37 Changeset [63707] by tonyg@chromium.org

2010-07-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Only set unloadEventEnd when the unload event is actually fired
https://bugs.webkit.org/show_bug.cgi?id=42607

r63689 introduced this ASSERT and it began failing on Qt and Mac debug.
For some reason, it did not fail on Windows (which is where I was
testing). The ASSERT was disabled in r63699.

Test: page-cache related layout tests don't crash in debug mode on Mac.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
19:03 Changeset [63706] by andreas.kling@nokia.com

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Don't unnecessarily copy QPainterPath in fillPath() and strokePath()
https://bugs.webkit.org/show_bug.cgi?id=42513

Avoid making unnecessary deep-copies of QPainterPaths that will
be discarded after use.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
18:44 Changeset [63705] by kbr@google.com

2010-07-19 Kenneth Russell <kbr@google.com>

Reviewed by Nate Chapin.

WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719

Fixed compiler warning introduced by original patch.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):

2010-07-19 Kenneth Russell <kbr@google.com>

Reviewed by Nate Chapin.

WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719

Fixed compiler warning introduced by original patch. No new tests;
covered by existing tests.

  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
18:19 Changeset [63704] by andersca@apple.com

Handle NP_ASFILE and NP_ASFILEONLY transfer modes
https://bugs.webkit.org/show_bug.cgi?id=42587

Reviewed by Darin Adler, Adam Roben, Dan Bernstein and Sam Weinig.

WebCore:

  • WebCore.exp.in:

Export functions from FileSystem.h

  • platform/mac/FileSystemMac.mm:

(WebCore::openTemporaryFile):
Try to create a temporary file using mkstemp.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NPP_StreamAsFile):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add NPP_ wrapper.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::NetscapePluginStream):
Initialize m_fileHandle.

(WebKit::isSupportedTransferMode):
NP_ASFILE and NP_ASFILEONLY is now supported.

(WebKit::NetscapePluginStream::deliverData):
Call deliverDataToFile if necessary.

(WebKit::NetscapePluginStream::deliverDataToFile):
Create a temporary file and write the data into it.

(WebKit::NetscapePluginStream::stop):
If the transfer mode is either NP_ASFILE or NP_ASFILEONLY, make sure to
call NPP_StreamAsFile and close the file and delete it.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cancelStreamLoad):
Keep a reference to the Stream since cancelling it will remove it from the map.

18:01 Changeset [63703] by jberlin@webkit.org

2010-07-19 Jessie Berlin <jberlin@apple.com>

Windows build fix. Unreviewed.

  • WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::initializeTestPluginPath):
17:25 Changeset [63702] by eric.carlson@apple.com

2010-07-19 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.
Update one more expected result missed in r63684.

  • platform/mac-leopard/accessibility/media-element-expected.txt:
17:07 Changeset [63701] by andersca@apple.com

Implement NPN_PostURLNotify
https://bugs.webkit.org/show_bug.cgi?id=42602

Reviewed by Sam Weinig.

WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):
Read the buffer from a file if necessary and parse it.

(WebKit::NPN_GetURLNotify):
Add extra arguments.

(WebKit::NPN_PostURLNotify):
Parse the post buffer, then call NetscapePlugin::loadURL.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::loadURL):
Pass the method, the header fields and form data along.

(WebKit::NetscapePlugin::allowPopups):
Just return false for now.

(WebKit::NetscapePlugin::initialize):
Pass extra arguments to loadURL.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PluginController.h:

Add method, header fields and form data.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):
Set the method, add the header fields and set the body.

16:55 Changeset [63700] by weinig@apple.com

Remove dependency on getopt from WebKitTestRunner.

Reviewed by Jon Honeycutt.

  • Simplify options parsing and eliminate unused options.
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::testPluginPath):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):

16:54 Changeset [63699] by tonyg@chromium.org

2010-07-19 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Remove overzealous ASSERT from r63689
https://bugs.webkit.org/show_bug.cgi?id=42606

No new tests because no new functionality.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
16:36 Changeset [63698] by diegohcg@webkit.org

2010-07-19 Diego Gonzalez <diegohcg@webkit.org>

[Qt] MiniBrowser: Progress indication at address bar
https://bugs.webkit.org/show_bug.cgi?id=42565

Reviewed by Antonio Gomes.

Make possible to see load progress at address bar based on
QtTestBrowser solution

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::loadProgress):
  • MiniBrowser/qt/BrowserWindow.h:
16:35 Changeset [63697] by diegohcg@webkit.org

2010-07-19 Diego Gonzalez <diegohcg@webkit.org>

[Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
https://bugs.webkit.org/show_bug.cgi?id=42564

Reviewed by Antonio Gomes.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserView::load): (BrowserWindow::BrowserWindow): (BrowserWindow::titleChanged): (BrowserWindow::urlChanged):
  • MiniBrowser/qt/BrowserWindow.h:
16:19 Changeset [63696] by joepeck@webkit.org

2010-07-19 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Mark Rowe.

Web Inspector: Do Not Copy *.re2js Inspector Resources in XCode Build Phase
https://bugs.webkit.org/show_bug.cgi?id=42601

Remove *.re2js files after copying them over in the Build Phase. We do
the same to remove the WebKit.qrc file.

  • WebCore.xcodeproj/project.pbxproj:
15:38 Changeset [63695] by mrowe@apple.com

Revert r63029 to address <rdar://problem/8202667>.

15:38 Changeset [63694] by mrowe@apple.com

Revert r63030 to address <rdar://problem/8202667>.

15:23 Changeset [63693] by weinig@apple.com

Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.

Reviewed by Adam Roben.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/DerivedSources.make: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
  • WebKitTestRunner/InjectedBundle/Bindings: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.

(WTR::JSWrappable::~JSWrappable):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.

(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.

(WTR::toJS):

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):

  • WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
  • WebKitTestRunner/win/build-generated-files.sh: Added.
15:21 Changeset [63692] by ojan@chromium.org

2010-07-19 Ojan Vafai <ojan@chromium.org>

Unreviewed.
[chromium] Update test expectations after r63681.
Add new expected results for the clearly correct cases after r63684.

  • platform/chromium-mac/media/video-load-networkState-expected.txt:
  • platform/chromium-mac/media/video-src-change-expected.txt:
  • platform/chromium-win/media/video-load-networkState-expected.txt:
  • platform/chromium-win/media/video-src-change-expected.txt:
  • platform/chromium/test_expectations.txt:
15:16 Changeset [63691] by eric.carlson@apple.com

2010-07-19 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Update more tests/results missed in r63684.

  • accessibility/media-element.html:
  • media/unsupported-rtsp-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:
14:58 Changeset [63690] by mrowe@apple.com

Clean up the buildbot configuration a little.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
14:55 Changeset [63689] by tonyg@chromium.org

2010-07-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Move times to DocumentLoader and fix bugs in mark points
https://bugs.webkit.org/show_bug.cgi?id=42512

  • fast/dom/script-tests/webtiming-navigate-within-document.js: Added. Previously, navigating within a document via a fragment would reset navigationStart. This test verifies that no times are changed after navigating within a document. (checkTimingNotChanged): (): (loadHandler):
  • fast/dom/webtiming-expected.txt: Test now passes because when correcting for clock skew, requestTime is set to fetchStart when it is less than fetchStart. Previously it was 0, now it is fetchStart. This, unfortunately, hides the fact that test_shell isn't populating the ResourceLoadTiming API. I'll think of a way to test that when I make the change to cause test_shell to fill the ResourceLoadTiming.
  • fast/dom/webtiming-navigate-within-document-expected.txt: Added.
  • fast/dom/webtiming-navigate-within-document.html: Added.
  • platform/gtk/Skipped: Skip new test on platform where Web Timing is not enabled.
  • platform/mac/Skipped: Skip new test on platform where Web Timing is not enabled.
  • platform/qt/Skipped: Skip new test on platform where Web Timing is not enabled.
  • platform/win/Skipped: Skip new test on platform where Web Timing is not enabled.

2010-07-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Move times to DocumentLoader and fix bugs in mark points
https://bugs.webkit.org/show_bug.cgi?id=42512

Test: fast/dom/webtiming-navigate-within-document.html

  • loader/DocumentLoader.h: Move the FrameLoadTimeline (now call DocumentLoadTiming) to the DocumentLoader. (WebCore::DocumentLoader::documentLoadTiming):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Set unloadEventEnd on the provisional DocumentLoader. Add some ASSERTs to tighten things up. (WebCore::FrameLoader::loadWithDocumentLoader): This was not the right place to set navigationStart. Setting it here caused it to be set before the unload form prompt and caused it to be reset when navigating within the document. (WebCore::FrameLoader::finishedLoading): Set responseEnd on the active DocumentLoader. (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): This is the right place for navigationStart as defined by the spec.
  • loader/FrameLoader.h: Get rid of FrameLoadTimeline.
  • loader/FrameLoaderTypes.h: Rename FrameLoadTimeline to DocumentLoadTiming. It is even more apparent this doesn't belong in this file now. I am planning to submit a patch moving it out ASAP, but didn't want to muddy this patch with all those build files. (WebCore::DocumentLoadTiming::DocumentLoadTiming):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Move fetchStart out of this method to load(), and rewrite setting of redirectStart, redirectEnd, and redirectCount to be more readable. (WebCore::MainResourceLoader::load): Set fetchStart slightly earlier here and tighten it up with some ASSERTs.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Set loadEventStart and loadEventEnd on the DocumentLoader.
  • page/Navigation.cpp: (WebCore::Navigation::redirectCount): Retrieve redirectCount from the DocumentLoader.
  • page/Timing.cpp: (WebCore::getPossiblySkewedTimeInKnownRange): The skew problem turned out to be due to the fact that chromium's currentTime() implementation only syncs to the system time every 60 seconds. So absolute times across threads may be skewed slightly. I resolved this temporarily by clipping the time from another thread into a known bound. A better long term solution is probably to add a currentTimeFromSystemTime() method and call that for web timing marks. (WebCore::Timing::navigationStart): (WebCore::Timing::unloadEventEnd): (WebCore::Timing::redirectStart): (WebCore::Timing::redirectEnd): (WebCore::Timing::fetchStart): (WebCore::Timing::domainLookupStart): (WebCore::Timing::domainLookupEnd): (WebCore::Timing::connectStart): (WebCore::Timing::connectEnd): (WebCore::Timing::requestStart): (WebCore::Timing::requestEnd): (WebCore::Timing::responseStart): (WebCore::Timing::responseEnd): (WebCore::Timing::loadEventStart): (WebCore::Timing::loadEventEnd): (WebCore::Timing::documentLoader): (WebCore::Timing::documentLoadTiming): (WebCore::Timing::resourceLoadTiming): (WebCore::Timing::resourceLoadTimeRelativeToAbsolute): Ensure requestTime is in the range of fetchStart to responseEnd.
  • page/Timing.h:
14:18 Changeset [63688] by cmarrin@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=42118
Disable WebGL on Leopard for now.

LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
software OpenGL driver on machines without this support.

14:05 Changeset [63687] by simon.fraser@apple.com

2010-07-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Brady Eidson.

Fix MiniBrowser to update URL as you browse
https://bugs.webkit.org/show_bug.cgi?id=42591

Hook up various loading notifications to update the URL bar in MiniBrowser.

  • MiniBrowser/mac/BrowserWindowController.m: (_didStartProvisionalLoadForFrame): (_didReceiveServerRedirectForProvisionalLoadForFrame): (_didFailProvisionalLoadWithErrorForFrame): (_didCommitLoadForFrame): (_didFailLoadWithErrorForFrame): (-[BrowserWindowController updateProvisionalURLForFrame:]): (-[BrowserWindowController didStartProvisionalLoadForFrame:]): (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]): (-[BrowserWindowController didFailLoadWithErrorForFrame:]): (-[BrowserWindowController didCommitLoadForFrame:]):
13:53 Changeset [63686] by eric.carlson@apple.com

2010-07-19 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Update tests/results missed in r63684.

  • media/video-error-does-not-exist-expected.txt:
  • media/video-load-networkState-expected.txt:
  • media/video-load-networkState.html:
13:38 Changeset [63685] by ap@apple.com

https://bugs.webkit.org/show_bug.cgi?id=42586
Log all canceled authentication attempts in DumpRenderTree

Updating test results.

  • platform/mac-tiger/http/tests/xmlhttprequest/failed-auth-expected.txt: There are custom results for Tiger, adding new printout to it, as well.
  • platform/gtk/http/tests/misc: Added.
  • platform/gtk/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt.
  • platform/gtk/http/tests/xmlhttprequest: Added.
  • platform/gtk/http/tests/xmlhttprequest/failed-auth-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt.
  • platform/qt/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt. These platforms don't seem to have auth delegate calls, so we can't log auth dialogs.
13:11 Changeset [63684] by eric.carlson@apple.com

2010-07-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464
<rdar://problem/5650561>

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_completelyLoaded. (WebCore::HTMLMediaElement::parseMappedAttribute): Don't deal with 'load' event. (WebCore::HTMLMediaElement::prepareForLoad): Set m_completelyLoaded to false. (WebCore::HTMLMediaElement::setNetworkState): Don't post 'load' event. (WebCore::HTMLMediaElement::progressEventTimerFired): Bail if m_networkState != NETWORK_LOADING. (WebCore::HTMLMediaElement::userCancelledLoad): No more NETWORK_LOADED state.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::):
  • html/HTMLMediaElement.idl: Remove NETWORK_LOADING.

2010-07-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464
<rdar://problem/5650561>

  • media/audio-delete-while-slider-thumb-clicked.html: Trigger test on 'canplaythrough' instead of 'load'.
  • media/audio-delete-while-step-button-clicked.html: Ditto.
  • media/event-attributes-expected.txt:
  • media/event-attributes.html: Correct logic to check that 'progress' event(s) are fired while loading file, but not when src set to invalid file. 'abort' event is fired when the src is changed.
  • media/invalid-media-url-crash-expected.txt:
  • media/media-constants-expected.txt: No more NETWORK_LOADED state.
  • media/media-constants.html: No more NETWORK_LOADED state. Clean up test.
  • media/remove-from-document-expected.txt:
  • media/remove-from-document.html: Ditto.
  • media/video-controls-visible-audio-only.html: Trigger test on 'canplaythrough' instead of 'load'.
  • media/video-source-none-supported-expected.txt: No more NETWORK_LOADED state.
  • media/video-src-change-expected.txt: Ditto.
  • media/video-src-none-expected.txt:
  • media/video-src-none.html: No more NETWORK_LOADED state. Fix bogus test that generated "FAIL" in results.
13:08 Changeset [63683] by ojan@chromium.org

2010-07-19 Ojan Vafai <ojan@chromium.org>

Unreviewed.

[chromium] Update test_expectations with passing/flaky tests.
Add new chromium expected result from r63680.

  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
  • platform/chromium/test_expectations.txt:
13:08 Changeset [63682] by weinig@apple.com

Add local storage support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42584

Reviewed by Darin Adler.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::swap):

  • Shared/WebPreferencesStore.h:

(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLocalStorageEnabled):
(WKPreferencesGetLocalStorageEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setLocalStorageEnabled):
(WebKit::WebPreferences::localStorageEnabled):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::preferencesDidChange):

13:03 Changeset [63681] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=42586
Log all canceled authentication attempts in DumpRenderTree

  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): It's important to know whether an auth sheet appeared. Added logging to "no preset credentials" case.
11:46 Changeset [63680] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=40996
Progress event should not be fired during synchronous XMLHttpRequest

https://bugs.webkit.org/show_bug.cgi?id=17502
Assertion failure when trying to restart a sync XMLHttpRequest as an async one from onreadystatechange

Tests: http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events.html

http/tests/xmlhttprequest/xmlhttprequest-sync-vs-async-assertion-failure.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): We now only dispatch readystatechange event for synchronous requests in states UNSENT, OPENED and DONE. I'm not sure what exactly the spec draft says about readystatechange for sync requests, but this seems to be the most logical and backwards compatible behavior. (WebCore::XMLHttpRequest::didReceiveData): Don't dispatch progress events for sync requests. Note that we already don't dispatch upload progress events for those.
11:09 Changeset [63679] by ossy@webkit.org

Unreviewed.

[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578

  • platform/qt/Skipped: Add tests again until fix which were unskipped by r63657.
10:45 Changeset [63678] by ojan@chromium.org

2010-07-19 Ojan Vafai <ojan@chromium.org>

Unreviewed. Update expectations from http://trac.webkit.org/changeset/63672
and cleanup some unexpected passes.

  • platform/chromium-linux/fast/forms/hidden-listbox-expected.checksum:
  • platform/chromium-linux/fast/forms/hidden-listbox-expected.png:
  • platform/chromium-win/fast/forms/hidden-listbox-expected.checksum:
  • platform/chromium-win/fast/forms/hidden-listbox-expected.png:
  • platform/chromium/test_expectations.txt:
10:34 Changeset [63677] by simon.fraser@apple.com

2010-07-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Uae an OwnPtr for the drawing area in WebPage (fixes a leak!).

  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::drawingArea):
10:26 Changeset [63676] by tony@chromium.org

2010-07-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] refactor npapi plugin copy step
https://bugs.webkit.org/show_bug.cgi?id=42493

This is to avoid duplicate copy rules in the Linux make build.

  • WebKit.gyp:
  • DEPS: 52483:52869
10:19 Changeset [63675] by darin@apple.com

2010-07-16 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Use OwnPtr for CodeBlock objects
https://bugs.webkit.org/show_bug.cgi?id=42490

  • runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): Moved this here and made it non-inline. Eliminated the code that used to initialize the raw pointer since it's now an OwnPtr. (JSC::EvalExecutable::~EvalExecutable): Removed the explicit delete here. (JSC::ProgramExecutable::ProgramExecutable): Ditto. (JSC::ProgramExecutable::~ProgramExecutable): Ditto. (JSC::FunctionExecutable::FunctionExecutable): Ditto. (JSC::FunctionExecutable::~FunctionExecutable): Ditto. (JSC::EvalExecutable::compileInternal): Added use of adoptPtr and get. (JSC::ProgramExecutable::compileInternal): Ditto. (JSC::FunctionExecutable::compileForCallInternal): Ditto. (JSC::FunctionExecutable::compileForConstructInternal): Ditto. (JSC::FunctionExecutable::recompile): Use clear instead of delete followed by assignment of 0.
  • runtime/Executable.h: Moved constructors to the cpp file and changed raw pointers to OwnPtr.
10:18 Changeset [63674] by weinig@apple.com

2010-07-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r63671.
http://trac.webkit.org/changeset/63671
https://bugs.webkit.org/show_bug.cgi?id=42575

broke windows (Requested by weinig on #webkit).

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/DerivedSources.make: Removed.
  • WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): (WTR::InjectedBundlePage::setStatusbarText):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setWaitToDump): (WTR::displayCallback): (WTR::dumpAsTextCallback): (WTR::dumpStatusCallbacksCallback): (WTR::waitUntilDoneCallback): (WTR::notifyDoneCallback): (WTR::numberOfActiveAnimationsCallback): (WTR::pauseAnimationAtTimeOnElementWithIdCallback): (WTR::repaintSweepHorizontallyCallback): (WTR::testRepaintCallback): (WTR::layoutTestControllerObjectFinalize): (WTR::LayoutTestController::makeWindowObject): (WTR::LayoutTestController::getJSClass): (WTR::LayoutTestController::staticFunctions):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpAsText): (WTR::LayoutTestController::setDumpAsText): (WTR::LayoutTestController::dumpStatusCallbacks): (WTR::LayoutTestController::setDumpStatusCallbacks): (WTR::LayoutTestController::setTestRepaint): (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
10:13 Changeset [63673] by chang.shu@nokia.com

2010-07-19 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix eol-style propety for the following file, otherwise svn-apply will fail.
https://bugs.webkit.org/show_bug.cgi?id=42573

  • canvas/philip/tests.js: Added property svn:eol-style.
09:48 Changeset [63672] by mitz@apple.com

<rdar://problem/7232109> Unpainted white area appears at the edge of the page when body has bg color
https://bugs.webkit.org/show_bug.cgi?id=34913

Reviewed by Simon Fraser.

WebCore:

Tests: fast/repaint/view-background-from-body-1.html

fast/repaint/view-background-from-body-2.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange): If this is the body renderer and its current style is
null, repaint the view, similarly to how the view is repainted for any repaint-or-higher
style changes.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode): If the removed child is the body renderer,
repaint the view, in case the body’s background was propagated to the view.

LayoutTests:

  • fast/repaint/view-background-from-body-1.html: Added.
  • fast/repaint/view-background-from-body-2.html: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.checksum: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.png: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.txt: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.checksum: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.png: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.txt: Added.
09:43 Changeset [63671] by weinig@apple.com

Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.

Reviewed by Adam Roben.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/DerivedSources.make: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
  • WebKitTestRunner/InjectedBundle/Bindings: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.

(WTR::JSWrappable::~JSWrappable):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.

(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.

(WTR::toJS):

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
09:39 Changeset [63670] by tony@chromium.org

2010-07-19 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

fix chromium linux compile on ubuntu maverick
https://bugs.webkit.org/show_bug.cgi?id=42528

  • Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
09:23 Changeset [63669] by pfeldman@chromium.org

2010-07-19 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Live edit is not working in chromium.
https://bugs.webkit.org/show_bug.cgi?id=42572

  • src/js/DebuggerScript.js:
09:21 Changeset [63668] by aroben@apple.com

When dumping a response's MIME type, print its URL's last path component rather than its suitable-for-test-result form

This matches the Mac behavior.

Fixes <http://webkit.org/b/42276>
http/tests/loading/preload-slow-loading.php and
http/tests/mime/uppercase-mime-type.html fail on Windows

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(urlSuitableForTestResult): Moved code to actually extract the last
path component from here...
(lastPathComponent): ...to here.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
component, rather than its suitable-for-test-result form, to match
Mac.

09:21 Changeset [63667] by aroben@apple.com

Fix an assertion when a plugin returns -1 from NPP_Write

We were forgetting to call setDefersLoading(false) before destroying
the PluginStream. In the process of destroying the stream, someone
would call setDefersLoading(true), and we would assert because we were
already deferring loads.

Fixes <http://webkit.org/b/42563> Assertion failure in
ResourceHandle::setDefersLoading when running
plugins/return-negative-one-from-write.html on Windows

Reviewed by Anders Carlsson.

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::deliverData): Call setDefersLoading(false)
before destroying the stream, to match the setDefersLoading(true) call
earlier in this function. (We already call setDefersLoading(false) in
the non-error case later on.)

09:06 Changeset [63666] by commit-queue@webkit.org

2010-07-19 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Fix some EFL theme issues
https://bugs.webkit.org/show_bug.cgi?id=42569

Keep a pointer to theme filename and check for it correctly.
Reduce the scope of some variables.
Don't test for platformWidget() since we are not using it.

No new tests, no new functionality.

  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyCursor): (WebCore::Widget::setCursor):
08:52 Changeset [63665] by commit-queue@webkit.org

2010-07-19 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Add ifdef to compile code just on presence of Ecore_X
https://bugs.webkit.org/show_bug.cgi?id=42567

No new tests since there's no new functionality.

  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::setEvasObject): Add #ifdef HAVE_ECORE_X to it.
08:29 Changeset [63664] by andersca@apple.com

WebKit2 does not have application cache
https://bugs.webkit.org/show_bug.cgi?id=42552

Reviewed by Adam Roben.

WebKit2:

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Add SetApplicationCacheDirectory.

  • Shared/WebPreferencesStore.h:

(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
add offlineWebApplicationCacheEnabled.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetOfflineWebApplicationCacheEnabled):
(WKPreferencesGetOfflineWebApplicationCacheEnabled):

  • UIProcess/API/C/WKPreferences.h:

Add getters/setters for whether the application cache is enabled.

  • UIProcess/WebContext.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setOfflineWebApplicationCacheEnabled):
Update the store and call update().

  • UIProcess/WebPreferences.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
Ask the web process to set the application cache directory.

  • UIProcess/mac/WebContextMac.mm: Added.

(WebKit::WebContext::applicationCacheDirectory):
Return the application cache directory.

  • UIProcess/win/WebContextWin.cpp: Added.

(WebKit::WebContext::applicationCacheDirectory):
Ditto.

  • WebKit2.xcodeproj/project.pbxproj:

Add WebContextMac.mm

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::preferencesDidChange):

(WebKit::WebPage::didReceiveMessage):
Handle PreferencesDidChange. Get rid of the default: case statement so we'll
get warnings if we have unhandled message kinds.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setApplicationCacheDirectory):
Set the application cache directory.

(WebKit::WebProcess::didReceiveMessage):
Handle SetApplicationCacheDirectory.

win/WebKit2.vcproj:
Add WebContextWin.cpp

WebKitTools:

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::resetPreferencesToConsistentValues):
Set up default preferences. Right now just enables the web application cache.

(WTR::TestInvocation::invoke):
Call resetPreferencesToConsistentValues.

  • WebKitTestRunner/TestInvocation.h:

LayoutTests:

  • platform/mac-wk2/Skipped:

Remove http/tests/appcache from skipped list.

08:23 Changeset [63663] by yurys@chromium.org

2010-07-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[chromium] inspector/console-trace.html failing on windows after r63548
https://bugs.webkit.org/show_bug.cgi?id=42485

  • inspector/console-trace.html: call dumpConsoleMessages sycnhronously right after console.trace
  • platform/chromium/test_expectations.txt:

2010-07-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add/removeStyleClass shouldn't increase number of spaces between class names.
https://bugs.webkit.org/show_bug.cgi?id=42485

  • inspector/front-end/utilities.js: (Element.prototype.removeStyleClass):
08:19 Changeset [63662] by yurys@chromium.org

2010-07-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show stack trace for uncaught exceptions when Web Inspector is open.
https://bugs.webkit.org/show_bug.cgi?id=42560

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::handler):
  • bindings/v8/V8ConsoleMessage.h:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement): (WebInspector.ConsoleMessage.prototype._addMessageHeader): (WebInspector.ConsoleMessage.prototype.toString):
  • inspector/front-end/inspector.css: (.console-message.repeated-message > ol.stack-trace): (.section .properties ol, .event-properties ol, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.section .properties ol.expanded, .event-properties ol.expanded, .stack-trace ol, ol.stack-trace):
  • page/Console.cpp: (WebCore::Console::addMessage):
  • page/Console.h: (WebCore::):
08:12 Changeset [63661] by tkent@chromium.org

2010-07-19 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Roben.

Fix NewRunWebKitTests to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=41180

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Specifying python explicitly.
08:05 Changeset [63660] by commit-queue@webkit.org

2010-07-19 Robin Burchell <robin.burchell@collabora.co.uk>

Reviewed by Antonio Gomes

[Qt] Use memcpy() instead of qMemCopy()
This is supposed to be more efficient, as the compiler is able to
optimise more.

Additionally, qMemCopy() is only strictly supposed to be used in
headers (see Qt's src/corelib/qglobal.h for reference)
See: https://bugs.webkit.org/show_bug.cgi?id=42392

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
07:52 Changeset [63659] by andreas.kling@nokia.com

2010-07-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas: Rename operator==(CanvasStyle,CanvasStyle) since it isn't a proper equality check
https://bugs.webkit.org/show_bug.cgi?id=42284

New name is isEquivalentColor(CanvasStyle).

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle):
  • html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::isEquivalentColor):
  • html/canvas/CanvasStyle.h:
07:50 Changeset [63658] by ossy@webkit.org

Unreviewed.

[Qt] Remove non-existent files from Skipped list.

  • platform/qt/Skipped:
    • Unskip fast/dynamic/flash-replacement-test.html, because it was removed by r61289
    • Rename fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Applying_the_percent_Operator/S11.5.3_A4_T2.html after r63284
    • Unskip inspector/debugger-breakpoints-not-activated-on-reload.html, because it was removed by r63314
    • Unskip media/video-src-empty.html, because it was removed by r63119
07:27 Changeset [63657] by andreas.kling@nokia.com

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Canvas: Wrong internal positioning of drawImage() shadows
https://bugs.webkit.org/show_bug.cgi?id=42510

  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Canvas: Wrong internal positioning of drawImage() shadows
https://bugs.webkit.org/show_bug.cgi?id=42510

Unskip:

  • canvas/philip/tests/2d.shadow.canvas.alpha.html
  • canvas/philip/tests/2d.shadow.canvas.transparent.1.html
  • canvas/philip/tests/2d.shadow.canvas.transparent.2.html
  • canvas/philip/tests/2d.shadow.image.alpha.html
  • canvas/philip/tests/2d.shadow.image.transparent.1.html
  • canvas/philip/tests/2d.shadow.image.transparent.2.html
  • platform/qt/Skipped:
07:24 Changeset [63656] by andreas.kling@nokia.com

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Render shadow when drawing one canvas onto another
https://bugs.webkit.org/show_bug.cgi?id=42508

  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Render shadow when drawing one canvas onto another
https://bugs.webkit.org/show_bug.cgi?id=42508

Unskip:

  • canvas/philip/tests/2d.shadow.canvas.basic.html

Reskip (bug now exposed):

  • canvas/philip/tests/2d.shadow.canvas.transparent.1.html
  • platform/qt/Skipped:
07:12 Changeset [63655] by ossy@webkit.org

Unreviewed.

[Qt] Add platform specific expected results for new passing SVG tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
  • platform/qt/svg/custom/convolution-crash-expected.checksum: Added.
  • platform/qt/svg/custom/convolution-crash-expected.png: Added.
  • platform/qt/svg/custom/convolution-crash-expected.txt: Added.
  • platform/qt/svg/custom/marker-child-changes-css-expected.checksum: Added.
  • platform/qt/svg/custom/marker-child-changes-css-expected.png: Added.
  • platform/qt/svg/custom/marker-child-changes-css-expected.txt: Copied from LayoutTests/platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt.
  • platform/qt/svg/custom/recursive-gradient-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-gradient-expected.png: Added.
  • platform/qt/svg/custom/recursive-gradient-expected.txt: Added.
  • platform/qt/svg/custom/recursive-mask-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-mask-expected.png: Added.
  • platform/qt/svg/custom/recursive-mask-expected.txt: Added.
  • platform/qt/svg/custom/recursive-pattern-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-pattern-expected.png: Added.
  • platform/qt/svg/custom/recursive-pattern-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.png: Added.
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.png: Added.
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/qt/svg/custom/repaint-moving-svg-and-div-expected.checksum: Added.
  • platform/qt/svg/custom/repaint-moving-svg-and-div-expected.png: Added.
  • platform/qt/svg/custom/repaint-moving-svg-and-div-expected.txt: Added.
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.checksum: Added.
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt: Added.
  • platform/qt/svg/custom/text-rotated-gradient-expected.checksum: Added.
  • platform/qt/svg/custom/text-rotated-gradient-expected.png: Added.
  • platform/qt/svg/custom/text-rotated-gradient-expected.txt: Added.
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/use-property-synchronization-crash-expected.checksum.
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.png: Copied from LayoutTests/platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt.
  • platform/qt/svg/filters/filter-empty-g-expected.checksum: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.checksum.
  • platform/qt/svg/filters/filter-empty-g-expected.png: Copied from LayoutTests/platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
  • platform/qt/svg/filters/filter-empty-g-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.txt.
  • platform/qt/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/qt/svg/filters/filter-width-update-expected.png: Added.
  • platform/qt/svg/filters/filter-width-update-expected.txt: Added.
07:08 Changeset [63654] by andreas.kling@nokia.com

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Some composition modes fail when color has alpha zero
https://bugs.webkit.org/show_bug.cgi?id=36973

Remove erroneous optimization that ignored painting calls when
the stroke/fill color had an alpha value of zero.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Some composition modes fail when color has alpha zero
https://bugs.webkit.org/show_bug.cgi?id=36973

Unskip fast/canvas/canvas-composite-alpha.html

  • platform/qt/Skipped:
07:06 Changeset [63653] by andreas.kling@nokia.com

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

CSS3 background: Number of layers should be determined by background-image element count
https://bugs.webkit.org/show_bug.cgi?id=41201

Manual test: css3-background-layer-count.html

Spec link:
http://www.w3.org/TR/css3-background/#layering

  • manual-tests/css3-background-layer-count.html: Added.
  • rendering/style/FillLayer.cpp: (WebCore::FillLayer::fillUnsetProperties): Don't repeat image properties, they determine the total number of layers. (WebCore::FillLayer::cullEmptyLayers): Change culling logic to discard all layers after the first one without an image set.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::adjustBackgroundLayers): Call fillUnsetProperties() before cullEmptyLayers() (WebCore::InheritedFlags::adjustMaskLayers): Ditto.
05:45 Changeset [63652] by andreas.kling@nokia.com

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Avoid QImage::pixel() in getImageData()
https://bugs.webkit.org/show_bug.cgi?id=42463

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): Use QImage::scanLine() instead of fetching data pixel-by-pixel.
05:43 Changeset [63651] by commit-queue@webkit.org

2010-07-19 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Fix build on 64-bit systems. According to
JavaScriptCore/wtf/Platform.h, x86_64 uses fixed allocator, which
needs jit/ExecutableAllocatorFixedVMPool.cpp to be included in build
system.
https://bugs.webkit.org/show_bug.cgi?id=42559

  • CMakeListsEfl.txt: add missing file for x86_64.
05:28 Changeset [63650] by commit-queue@webkit.org

2010-07-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] Fix test expectations
https://bugs.webkit.org/show_bug.cgi?id=42556

text-rotated-gradient.svg is flaky on linux, and clip-path-child-changes.svg
isn't actually flaky.

  • platform/chromium/test_expectations.txt:
05:17 Changeset [63649] by yurys@chromium.org

2010-07-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: hide "toggle debugger" button when debugger is always enabled
https://bugs.webkit.org/show_bug.cgi?id=42558

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
04:52 Changeset [63648] by ager@chromium.org

2010-07-19 Mads Ager <ager@chromium.org>

Reviewed by Pavel Feldman.

Remove chromium rebaselines for document.all layout test.
https://bugs.webkit.org/show_bug.cgi?id=42557

V8 changed behavior to match JSC completely on document.all. Remove
chromium rebaseline.

  • platform/chromium-mac/fast/dom/undetectable-document-all-expected.txt: Removed.
  • platform/chromium-win/fast/dom/undetectable-document-all-expected.txt: Removed.
03:54 Changeset [63647] by kent.hansen@nokia.com

2010-07-19 Kent Hansen <kent.hansen@nokia.com>

Unreviewed, fix failure introduced in r63645.
Ignore jscprint property since it only appears in
debug builds (as per window-property-descriptors test).

  • fast/dom/Window/window-properties.html:
02:40 Changeset [63646] by commit-queue@webkit.org

2010-07-19 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file
https://bugs.webkit.org/show_bug.cgi?id=42466

(Original problem at https://bugs.webkit.org/show_bug.cgi?id=42447)

No new functionality so no new tests.

  • dom/DeviceOrientationEvent.cpp: (WebCore::DeviceOrientationEvent::~DeviceOrientationEvent): Move here to avoid needing to have the full declaration of DeviceOrientation in DeviceOrientationEvent.h.
  • dom/DeviceOrientationEvent.h:
01:23 Changeset [63645] by kent.hansen@nokia.com

2010-07-19 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Sam Weinig.

Improve coverage of fast/dom/Window/window-properties test
https://bugs.webkit.org/show_bug.cgi?id=42258

Use Object.getOwnPropertyNames to cover ECMA properties
and other native properties.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:

07/18/10:

22:39 Changeset [63644] by mjs@apple.com

2010-07-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Add more items to the WebKit2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=42551

  • platform/mac-wk2/Skipped:
22:16 Changeset [63643] by andersca@apple.com

Fix Build.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):

21:51 Changeset [63642] by andersca@apple.com

Always set the current NSGraphicsContext before calling drawWithFrame
https://bugs.webkit.org/show_bug.cgi?id=42542

Reviewed by Dan Bernstein.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):

20:49 Changeset [63641] by andreas.kling@nokia.com

2010-07-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] tst_QWebPage fails cursorMovements and textSelection
https://bugs.webkit.org/show_bug.cgi?id=42531

Correct the HTML used by these tests.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements): (tst_QWebPage::textSelection): (tst_QWebPage::textEditing):
18:10 Changeset [63640] by andersca@apple.com

Another attempt at fixing the Windows build.

  • WebProcess/Plugins/NPJSObjectMap.h:
17:13 Changeset [63639] by andersca@apple.com

Try to fix Windows build.

  • win/WebKit2.vcproj:
17:11 WebKit Team edited by ddkilzer@webkit.org
(diff)
17:09 Changeset [63638] by andersca@apple.com

Move PluginWidget to WebKit
https://bugs.webkit.org/show_bug.cgi?id=42530

Reviewed by Sam Weinig.

WebCore:

Rename the PluginWidget class to PluginViewBase and make it an abstract base class.

This is a stopgap measure until we have a single PluginView class that we can use everywhere.

  • WebCore.exp.in:

Remove PluginWidget symbols.

  • WebCore.xcodeproj/project.pbxproj:

Update.

  • platform/Widget.h:

(WebCore::Widget::isPluginViewBase):
Return false.

  • plugins/PluginViewBase.h: Added.

(WebCore::PluginViewBase::platformLayer):
Always return 0 here now.

(WebCore::PluginViewBase::isPluginViewBase):
Return true.

  • plugins/PluginWidget.h: Removed.
  • plugins/mac/PluginWidgetMac.mm: Removed.
  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
Cast to PluginWidgetBase instead.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
Cast to PluginWidgetBase instead.

WebKit/mac:

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView pluginLayer]):
Add default pluginLayer implementation.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(PluginWidget::PluginWidget):
(PluginWidget::invalidateRect):
Move the guts of PluginWidget here from WebCore.

(NetscapePluginWidget::platformLayer):
Get the layer from the plug-in view.

16:45 WebKit Team edited by ddkilzer@webkit.org
(diff)
15:55 Changeset [63637] by andreas.kling@nokia.com

2010-07-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] tst_QWebElement fails firstChildNextSibling and lastChildPreviousSibling
https://bugs.webkit.org/show_bug.cgi?id=42527

Correct the HTML used by these tests.

  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::firstChildNextSibling): (tst_QWebElement::lastChildPreviousSibling):
15:27 Changeset [63636] by andersca@apple.com

More NPRuntime work
https://bugs.webkit.org/show_bug.cgi?id=42526

Reviewed by Sam Weinig.

  • WebProcess/Plugins/NPJSObjectMap.cpp:

(WebKit::identifierFromIdentifierRep):
(WebKit::NPJSObject::hasProperty):
Check if the JSObject has the given property.

(WebKit::NPJSObject::getProperty):
Add stubbed out function.

(WebKit::NPJSObject::npClass):
Add NP_HasProperty and NP_GetProperty.

(WebKit::NPJSObject::NP_HasProperty):
Call NPJSObject::hasProperty.

(WebKit::NPJSObject::NP_GetProperty):
Call NPJSObject::getProperty.

  • WebProcess/Plugins/NPRuntimeUtilities.cpp:

(WebKit::releaseNPVariantValue):
Release the given NPVariant.

  • WebProcess/Plugins/NPRuntimeUtilities.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetProperty):
Call the NPClass GetProperty function.

(WebKit::NPN_HasProperty):
Call the NPClass HasProperty function.

(WebKit::NPN_ReleaseVariantValue):
Call releaseNPVariantValue.

15:25 Changeset [63635] by dino@apple.com

2010-07-18 Dean Jackson <dino@apple.com>

Unreviewed (although this was discussed with SimonF in
original review).

https://bugs.webkit.org/show_bug.cgi?id=41259

Unfortunately the test in the previous commit is platform
specific (I was hoping it would not be) and is failing
the bots. This update exercises the same thing, but doesn't
check for exact values.

  • fast/transforms/scrollIntoView-transformed-expected.txt:
  • fast/transforms/scrollIntoView-transformed.html:
15:01 Changeset [63634] by dino@apple.com

2010-07-18 Dean Jackson <dino@apple.com>

Unreviewed.

Remove the unwanted extra line that Xcode
added in my last commit.

  • WebCore.xcodeproj/project.pbxproj:
14:55 Changeset [63633] by dino@apple.com

2010-07-18 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=41259
Interacting with a <select> element within a transformed and clipped
container scrolls the container

The Node::getRect and ContainerNode::getRect functions were not
transform-aware. This fixes both, and has a test to make sure
we're not breaking any existing scrollToView code. This means
that a <select> popup will appear in the correct place if it
is within a transformed and scrolled container.

The test makes sure that existing scrollToView
code doesn't break, but also checks that a <select> popup will appear
in the correct place.

Test: fast/transforms/scrollIntoView-transformed.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
  • make sure we call localToAbsolute in the right order (after we've done a local move) and pass in the flags to indicate it should look for transforms.
  • dom/Node.cpp: (WebCore::Node::getRect):
  • make sure localToAbsolute gets told to look for transforms.
14:38 Changeset [63632] by ddkilzer@apple.com

<http://webkit.org/b/42522> Add missing (id) return type to Obj-C methods

Reviewed by Dan Bernstein.

  • Carbon/CarbonWindowAdapter.mm:

(-[NSWindow(HIWebFrameView) _initContent:styleMask:backing:defer:contentView:]):
(-[CarbonWindowAdapter _destroyRealWindow:]):
(-[CarbonWindowAdapter _clearModalWindowLevel]):

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase init]):

  • Misc/WebNSPasteboardExtras.mm:

(-[NSFilePromiseDragSource initWithSource:]):

  • WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation init]):

  • WebView/WebPreferences.mm:

(-[WebPreferences init]):

  • WebView/WebView.mm:

(-[WebView UIDelegate]):
(-[WebView resourceLoadDelegate]):
(-[WebView downloadDelegate]):
(-[WebView policyDelegate]):
(-[WebView frameLoadDelegate]):

14:33 Changeset [63631] by andersca@apple.com

Add NPJSObjectMap class
https://bugs.webkit.org/show_bug.cgi?id=42524

Reviewed by Sam Weinig.

WebCore:

Export ScriptController functions.

  • WebCore.exp.in:

WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

  • WebProcess/Plugins/NPJSObjectMap.cpp: Added.
  • WebProcess/Plugins/NPJSObjectMap.h: Added.

Add NPJSObjectMap, a map which contains NPObjects that wrap JavaScript objects.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Initialize the map.

(WebKit::PluginView::~PluginView):
Invalidate the map.

(WebKit::PluginView::frame):
Add frame getter.

(WebKit::PluginView::windowScriptNPObject):
Wrap the window object.

(WebKit::PluginView::pluginElementNPObject):
Wrap the plug-in element object.

  • WebProcess/Plugins/PluginView.h:
12:44 Changeset [63630] by andersca@apple.com

Implement more NPRuntime related NPN_ functions
https://bugs.webkit.org/show_bug.cgi?id=42520

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/NPRuntimeUtilities.cpp: Added.
  • WebProcess/Plugins/NPRuntimeUtilities.h: Added.

Add new file with NPRuntime related utility functions.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_CreateObject):
(WebKit::NPN_RetainObject):
(WebKit::NPN_ReleaseObject):
Call the corresponding NPRuntimeUtilities functions.

11:57 Changeset [63629] by andersca@apple.com

Begin work on NPRuntime support
https://bugs.webkit.org/show_bug.cgi?id=42519

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Handle NPNVWindowNPObject and NPNVPluginElementNPObject.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::windowScriptNPObject):
(WebKit::NetscapePlugin::pluginElementNPObject):
Call the plug-in controller.

  • WebProcess/Plugins/PluginController.h:

Add new windowScriptNPObject and pluginElementNPObject functions.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):
Add stubbed out functions.

10:45 Changeset [63628] by andersca@apple.com

Implement some NPRuntime related NPN_ functions
https://bugs.webkit.org/show_bug.cgi?id=42518

Reviewed by Dan Bernstein.

WebCore:

  • WebCore.exp.in:

Export IdentifierRep functions.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetStringIdentifier):
(WebKit::NPN_GetStringIdentifiers):
(WebKit::NPN_GetIntIdentifier):
(WebKit::NPN_IdentifierIsString):
(WebKit::NPN_UTF8FromIdentifier):
(WebKit::NPN_IntFromIdentifier):
(WebKit::NPN_CreateObject):

10:01 Changeset [63627] by andersca@apple.com

Add dumping of statusbar text to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42516

Reviewed by Dan Bernstein.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:

Add setStatusbarText callback to WKBundlePageUIClient.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::setStatusbarText):
Call setStatusbarText.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setStatusbarText):
Call the bundle page UI client.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_setStatusbarText):
(WTR::InjectedBundlePage::setStatusbarText):
Dump the statusbar text.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):
Initialize m_dumpStatusCallbacks to false.

(WTR::dumpStatusCallbacksCallback):
Implement JSC callback.

(WTR::LayoutTestController::staticFunctions):
Add dumpStatusCallbacks.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::setDumpStatusCallbacks):
Add setter and getter for m_dumpStatusCallbacks.

09:32 Changeset [63626] by pfeldman@chromium.org

2010-07-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: get actual breakpoint location from v8 and pass it
to ScripDebugServer.
https://bugs.webkit.org/show_bug.cgi?id=42452

  • src/js/DebuggerScript.js:
07:35 Changeset [63625] by pfeldman@chromium.org

2010-07-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium: fixed one more expectation to
reflect changes in r63616.

  • platform/chromium/test_expectations.txt:
06:49 Changeset [63624] by pfeldman@chromium.org

2010-07-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium: fixed test expectations (reflected changes
in r63616).

  • platform/chromium/test_expectations.txt:

07/17/10:

19:33 Changeset [63623] by andreas.kling@nokia.com

2010-07-17 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Simon Hausmann.

Import new version of 2d.pattern.image.string.html from Philip Taylor.
The original test was buggy and we now pass it.

  • canvas/philip/tests/2d.pattern.image.string-expected.txt:
  • canvas/philip/tests/2d.pattern.image.string.html:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
18:59 Changeset [63622] by commit-queue@webkit.org

2010-07-17 TJ Lee <tjlee0909@gmail.com>

Reviewed by Timothy Hatcher.

HTMLLinkElement ignores dnsPrefetchingEnabled setting
https://bugs.webkit.org/show_bug.cgi?id=42500

Changed the HTML Link tag to check that the browser
has DNS-prefetching enabled before calling ResourceHandle::prepareForURL.

There are no test cases for this patch because it was unclear how to test
this using a layout test. A possible test case would be to
clear the DNS cache on the client's machine before loading a page with
<link rel="dns-prefetch" href="SomeSiteThatsNotTheCurrentOne.com"> and
then check the number of DNS cache entries.

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
18:39 Changeset [63621] by andersca@apple.com

WebKit2: WebKitTestRunner should load the test plug-in
https://bugs.webkit.org/show_bug.cgi?id=42509

Reviewed by Maciej Stachowiak.

  • UIProcess/API/C/WKContext.cpp:

(_WKContextSetAdditionalPluginPath):
Add a private function for setting a single additional plug-in path. the WebKit1 SPI that does the
same thing takes an array of paths, but this is good enough for now.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::setAdditionalPluginPaths):
Set the additional plug-in paths vector and refresh the database.

(WebKit::PluginInfoStore::loadPluginsIfNecessary):
First try to load plug-ins in the additional plug-in paths.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setAdditionalPluginPath):
Call PluginInfoStore::setAdditionalPluginPaths.

  • UIProcess/WebContext.h:

(WebKit::WebContext::pluginInfoStore):
Make the plug-in info store per context instead of having a single shared info store.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPlugins):
(WebKit::WebProcessProxy::getPluginHostConnection):

  • UIProcess/WebProcessProxy.h:

Get the plug-in info store from the context.

WebKitTools: * WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
Get the test plug-in path and set it on the context.

Reviewed by Maciej Stachowiak.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::initializeInjectedBundlePath):
Simplify this code by using NSBundle.

(WTR::TestController::testPluginPath):
Return the test plug-in path.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::testPluginPath):
Ditto.

17:15 Changeset [63620] by mjs@apple.com

2010-07-16 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Asynchronous policy checks make FrameLoader think it is done loading prematurely
https://bugs.webkit.org/show_bug.cgi?id=42489

This caused many (~100) layout tsts to fail under WebKit2.

  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadSubframe): Right after loading a new subframe, if m_complete is true, do not consider it done if it has a provisional loader. This will happen in the case where the policy check is asynchronous.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::subframeIsLoading): For similar reasons, consider a subframe to be loading if it has a policy decision pending.
17:11 Changeset [63619] by andreas.kling@nokia.com

2010-07-17 Andreas Kling <andreas.kling@nokia.com>

[Qt] Reskip 2d.path.quadraticCurveTo.scaled.html

This test fails with the Qt version running on the bot.

  • platform/qt/Skipped:
16:48 Changeset [63618] by andersca@apple.com

Another attempt at fixing this test.

  • plugins/npruntime/browser-object-identity.html:
15:11 Changeset [63617] by andreas.kling@nokia.com

2010-07-17 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Unskipped two canvas tests that are passing

  • canvas/philip/tests/2d.path.arc.twopie.3.html
  • canvas/philip/tests/2d.path.quadraticCurveTo.scaled.html
  • platform/qt/Skipped:
14:51 Changeset [63616] by andersca@apple.com

Move platform specific plug-ins to platform/
https://bugs.webkit.org/show_bug.cgi?id=42506

Reviewed by Sam Weinig.

  • platform/gtk/Skipped:
  • platform/mac-leopard/plugins/qt-qwidget-plugin-expected.checksum: Removed.
  • platform/mac-leopard/plugins/qt-qwidget-plugin-expected.png: Removed.
  • platform/mac/plugins/call-as-function-test-expected.txt: Renamed from LayoutTests/plugins/call-as-function-test-expected.txt.
  • platform/mac/plugins/call-as-function-test.html: Renamed from LayoutTests/plugins/call-as-function-test.html.
  • platform/mac/plugins/jsobjc-dom-wrappers-expected.txt: Renamed from LayoutTests/plugins/jsobjc-dom-wrappers-expected.txt.
  • platform/mac/plugins/jsobjc-dom-wrappers.html: Renamed from LayoutTests/plugins/jsobjc-dom-wrappers.html.
  • platform/mac/plugins/jsobjc-simple-expected.txt: Renamed from LayoutTests/plugins/jsobjc-simple-expected.txt.
  • platform/mac/plugins/jsobjc-simple.html: Renamed from LayoutTests/plugins/jsobjc-simple.html.
  • platform/mac/plugins/qt-qwidget-plugin-expected.checksum: Removed.
  • platform/mac/plugins/qt-qwidget-plugin-expected.png: Removed.
  • platform/mac/plugins/qt-qwidget-plugin-expected.txt: Removed.
  • platform/mac/plugins/root-object-premature-delete-crash-expected.txt: Renamed from LayoutTests/plugins/root-object-premature-delete-crash-expected.txt.
  • platform/mac/plugins/root-object-premature-delete-crash.html: Renamed from LayoutTests/plugins/root-object-premature-delete-crash.html.
  • platform/mac/plugins/throw-on-dealloc-expected.txt: Renamed from LayoutTests/plugins/throw-on-dealloc-expected.txt.
  • platform/mac/plugins/throw-on-dealloc.html: Renamed from LayoutTests/plugins/throw-on-dealloc.html.
  • platform/mac/plugins/undefined-property-crash-expected.txt: Renamed from LayoutTests/plugins/undefined-property-crash-expected.txt.
  • platform/mac/plugins/undefined-property-crash.html: Renamed from LayoutTests/plugins/undefined-property-crash.html.
  • platform/qt/Skipped:
  • platform/qt/plugins/qt-qwidget-plugin.html: Renamed from LayoutTests/plugins/qt-qwidget-plugin.html.
  • platform/win/Skipped:
14:44 Changeset [63615] by andersca@apple.com

[EFL] Unreviewed build system cleanup.

Patch by Leandro Pereira <leandro@profusion.mobi> on 2010-07-16
Remove reference to "mediaControlsGtk.css".

  • cmake/WebKitGenerators.cmake:
14:32 Changeset [63614] by andreas.kling@nokia.com

2010-07-15 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Failure on http://philip.html5.org/tests/canvas/suite/tests/2d.shadow.alpha.5.html
https://bugs.webkit.org/show_bug.cgi?id=38400

FillRect with shadow need take alpha information from fillstyle

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):

2010-07-15 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Failure on http://philip.html5.org/tests/canvas/suite/tests/2d.shadow.alpha.5.html
https://bugs.webkit.org/show_bug.cgi?id=38400

Remove the following test case from Skipped:
canvas/philip/tests/2d.shadow.alpha.5.html
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.transparent.1.html
canvas/philip/tests/2d.shadow.image.scale.html
canvas/philip/tests/2d.shadow.pattern.alpha.html
canvas/philip/tests/2d.shadow.pattern.transparent.1.html

  • platform/qt/Skipped:
14:21 Changeset [63613] by andersca@apple.com

Move NPRuntime related tests to plugins/npruntime
https://bugs.webkit.org/show_bug.cgi?id=42505

Reviewed by Dan Bernstein.

  • platform/gtk/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/win/Skipped:

Update skipped lists.

  • plugins/netscape-identifier-conversion.html: Removed.
  • plugins/npruntime/bindings-test-expected.txt: Renamed from LayoutTests/plugins/bindings-test-expected.txt.
  • plugins/npruntime/bindings-test.html: Renamed from LayoutTests/plugins/bindings-test.html.
  • plugins/npruntime/browser-object-identity-expected.txt: Renamed from LayoutTests/plugins/netscape-browser-object-identity-expected.txt.
  • plugins/npruntime/browser-object-identity.html: Renamed from LayoutTests/plugins/netscape-browser-object-identity.html.
  • plugins/npruntime/construct-expected.txt: Renamed from LayoutTests/plugins/netscape-construct-expected.txt.
  • plugins/npruntime/construct.html: Renamed from LayoutTests/plugins/netscape-construct.html.
  • plugins/npruntime/embed-property-expected.txt: Renamed from LayoutTests/plugins/embed-property-expected.txt.
  • plugins/npruntime/embed-property.html: Renamed from LayoutTests/plugins/embed-property.html.
  • plugins/npruntime/enumerate-expected.txt: Renamed from LayoutTests/plugins/netscape-enumerate-expected.txt.
  • plugins/npruntime/enumerate.html: Renamed from LayoutTests/plugins/netscape-enumerate.html.
  • plugins/npruntime/get-int-identifier-special-values-expected.txt: Renamed from LayoutTests/plugins/getintidentifier-special-values-expected.txt.
  • plugins/npruntime/get-int-identifier-special-values.html: Renamed from LayoutTests/plugins/getintidentifier-special-values.html.
  • plugins/npruntime/get-property-return-value-expected.txt: Renamed from LayoutTests/plugins/netscape-get-property-return-value-expected.txt.
  • plugins/npruntime/get-property-return-value.html: Renamed from LayoutTests/plugins/netscape-get-property-return-value.html.
  • plugins/npruntime/identifier-conversion-expected.txt: Renamed from LayoutTests/plugins/netscape-identifier-conversion-expected.txt.
  • plugins/npruntime/identifier-conversion.html: Renamed from LayoutTests/plugins/netscape-identifier-conversion.html.
  • plugins/npruntime/invoke-browserfuncs-expected.txt: Renamed from LayoutTests/plugins/netscape-invoke-browserfuncs-expected.txt.
  • plugins/npruntime/invoke-browserfuncs.html: Renamed from LayoutTests/plugins/netscape-invoke-browserfuncs.html.
  • plugins/npruntime/invoke-default-expected.txt: Renamed from LayoutTests/plugins/netscape-invoke-default-expected.txt.
  • plugins/npruntime/invoke-default.html: Renamed from LayoutTests/plugins/netscape-invoke-default.html.
  • plugins/npruntime/invoke-expected.txt: Renamed from LayoutTests/plugins/invoke-expected.txt.
  • plugins/npruntime/invoke-failure-expected.txt: Renamed from LayoutTests/plugins/netscape-invoke-failure-expected.txt.
  • plugins/npruntime/invoke-failure.html: Renamed from LayoutTests/plugins/netscape-invoke-failure.html.
  • plugins/npruntime/invoke.html: Renamed from LayoutTests/plugins/invoke.html.
  • plugins/npruntime/npruntime-expected.txt: Renamed from LayoutTests/plugins/npruntime-expected.txt.
  • plugins/npruntime/npruntime.html: Renamed from LayoutTests/plugins/npruntime.html.
  • plugins/npruntime/round-trip-npobject-expected.txt: Renamed from LayoutTests/plugins/round-trip-npobject-expected.txt.
  • plugins/npruntime/round-trip-npobject.html: Renamed from LayoutTests/plugins/round-trip-npobject.html.
  • plugins/npruntime/script-tests/TEMPLATE.html: Renamed from LayoutTests/plugins/script-tests/TEMPLATE.html.
  • plugins/npruntime/script-tests/browser-object-identity.js: Renamed from LayoutTests/plugins/script-tests/netscape-browser-object-identity.js.

(description.gc):

  • plugins/npruntime/script-tests/identifier-conversion.js: Renamed from LayoutTests/plugins/script-tests/netscape-identifier-conversion.js.
  • plugins/npruntime/set-property-expected.txt: Renamed from LayoutTests/plugins/setProperty-expected.txt.
  • plugins/npruntime/set-property.html: Renamed from LayoutTests/plugins/setProperty.html.
  • plugins/npruntime/throw-exception-expected.txt: Renamed from LayoutTests/plugins/netscape-throw-exception-expected.txt.
  • plugins/npruntime/throw-exception.html: Renamed from LayoutTests/plugins/netscape-throw-exception.html.
13:47 Changeset [63612] by andersca@apple.com

Stop all NPStreams before destroying a plug-in
https://bugs.webkit.org/show_bug.cgi?id=42504

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::stopAllStreams):
Go through all streams and stop them.

(WebKit::NetscapePlugin::destroy):
Call stopAllStreams.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add stopAllStreams.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:

Make stop public.

13:20 Changeset [63611] by andersca@apple.com

Open streams should not keep a plug-in view alive
https://bugs.webkit.org/show_bug.cgi?id=42503

Reviewed by Dan Bernstein.

PluginView::Stream now has a weak reference to its PluginView.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::~Stream):
Assert that the plug-in view is null.

(WebKit::PluginView::Stream::didFail):
After calling removeStream, set the plug-in view member variable to 0. This is OK to do
since we keep a reference to the Stream, so we're sure that the call to removeStream does not
destroy the stream.

(WebKit::PluginView::Stream::didFinishLoading):
Ditto .

(WebKit::PluginView::~PluginView):
Cancel all streams.

(WebKit::PluginView::cancelAllStreams):
Cancel all streams.

11:11 Changeset [63610] by johnnyg@google.com

2010-07-17 John Gregg <johnnyg@google.com>

Unreviewed, updating test expectations.

[chromium] Updating the expecations for input-file-directory-upload.html
https://bugs.webkit.org/show_bug.cgi?id=42419

  • platform/chromium/test_expectations.txt:
10:04 Changeset [63609] by johnnyg@google.com

2010-07-17 John Gregg <johnnyg@google.com>

Reviewed by Kent Tamura.

[chromium] directory upload: pass the attribute up to the chrome client
https://bugs.webkit.org/show_bug.cgi?id=42475

This allows chromium to display the native system directory picker when
the directory attribute is present on the input element.

  • public/WebFileChooserParams.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runOpenPanel):
08:43 Applications using WebKit edited by wacko@haphana.org
Added Surf and Tom thought the alphabet started with T (diff)
08:08 HackingWebInspector edited by me@elv1s.ru
Typos (diff)
04:51 Changeset [63608] by commit-queue@webkit.org

2010-07-17 Nikita Vasilyev <me@elv1s.ru>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Edit long CSS attributes works incorrect
https://bugs.webkit.org/show_bug.cgi?id=42476

  • inspector/front-end/inspector.css: (.editing):

07/16/10:

21:53 Changeset [63607] by andreas.kling@nokia.com

2010-07-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Sam Weinig.

Failing 2d.path.arcTo.ensuresubpath.* philip canvas tests
https://bugs.webkit.org/show_bug.cgi?id=42186

Unskip tests:

  • canvas/philip/tests/2d.path.arcTo.ensuresubpath.1.html
  • canvas/philip/tests/2d.path.arcTo.ensuresubpath.2.html
  • platform/mac/Skipped:

2010-07-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Sam Weinig.

Failing 2d.path.arcTo.ensuresubpath.* philip canvas tests
https://bugs.webkit.org/show_bug.cgi?id=42186

Move code from Qt's Path::addArcTo() up to CanvasRenderingContext2D.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): Behave as moveTo(x1,y1) if the current path is empty.
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo): Remove now-redundant code.
20:23 Changeset [63606] by andreas.kling@nokia.com

2010-07-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

QtWebkit creates an unnecessary deep copy of images when canvas drawing is done
A https://bugs.webkit.org/show_bug.cgi?id=32530

Solve this by adding ImageBuffer::imageForRendering() which returns an image
that can be used for rendering now, but isn't a copy to be kept around.

  • platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::imageForRendering):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::imageForRendering): Added to provide an image that can be used for rendering now, but may change in the future.
  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::StillImage): (WebCore::StillImage::~StillImage): (WebCore::StillImage::size): (WebCore::StillImage::nativeImageForCurrentFrame): (WebCore::StillImage::draw):
  • platform/graphics/qt/StillImageQt.h: (WebCore::StillImage::createForRendering): Added for use in ImageBuffer::imageForRendering(), provides a thin wrapper around a QPixmap*.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): Paint with ImageBuffer::imageForRendering()
20:19 Changeset [63605] by andreas.kling@nokia.com

2010-07-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

[Qt] Remove redundant logic in Path::addArcTo()
https://bugs.webkit.org/show_bug.cgi?id=42494

Bounds checking for arcTo() is now done in cross-platform code
thanks to <http://trac.webkit.org/changeset/63599>

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo):
19:48 Changeset [63604] by abarth@webkit.org

2010-07-16 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Teach webkitpy about queues.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=42492

  • Scripts/webkitpy/common/net/statusserver.py:
18:23 Changeset [63603] by thakis@chromium.org

2010-07-16 Nico Weber <thakis@chromium.org>

Reviewed by Ojan Vafai.

Add chromium/win and linux expectations for fast/canvas/toDataUrl-alpha.

  • platform/chromium-linux/fast/canvas/toDataURL-alpha-expected.checksum: Added.
  • platform/chromium-linux/fast/canvas/toDataURL-alpha-expected.png: Added.
  • platform/chromium-win/fast/canvas/toDataURL-alpha-expected.checksum: Added.
  • platform/chromium-win/fast/canvas/toDataURL-alpha-expected.png: Added.
  • platform/chromium-win/fast/canvas/toDataURL-alpha-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
18:05 Changeset [63602] by commit-queue@webkit.org

2010-07-16 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253

This patch just reverts the change to WebCore/page/FocusController.cpp
made in changeset 61484, and add a new method named
willSetInputMethodState in EditorClient interface, which gets called
in FocusController just before changing the focused node.

No new tests, because no new functionality.

  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::willSetInputMethodState):
  • page/EditorClient.h:
  • page/FocusController.cpp: (WebCore::FocusController::setFocusedNode):

2010-07-16 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253

Dummy implementation of EditorClient::willSetInputMethodState.

  • efl/WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::willSetInputMethodState):
  • efl/WebCoreSupport/EditorClientEfl.h:

2010-07-16 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253

Implement EditorClient::willSetInputMethodState which replaces
setInputMethodState method.

  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::willSetInputMethodState): (WebKit::EditorClientImpl::setInputMethodState):
  • src/EditorClientImpl.h:

2010-07-16 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253

Dummy implementation of EditorClient::willSetInputMethodState.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::willSetInputMethodState):
  • WebCoreSupport/EditorClientGtk.h:

2010-07-16 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253

Dummy implementation of EditorClient::willSetInputMethodState.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::willSetInputMethodState):
  • WebCoreSupport/EditorClientHaiku.h:

2010-07-16 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253

Dummy implementation of EditorClient::willSetInputMethodState.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::willSetInputMethodState):

2010-07-16 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253

Dummy implementation of EditorClient::willSetInputMethodState.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::willSetInputMethodState):
  • WebCoreSupport/EditorClientQt.h:

2010-07-16 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253

Dummy implementation of EditorClient::willSetInputMethodState.

  • WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::willSetInputMethodState):
  • WebCoreSupport/WebEditorClient.h:

2010-07-16 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253

Dummy implementation of EditorClient::willSetInputMethodState.

  • WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::willSetInputMethodState):
  • WebKitSupport/EditorClientWx.h:

2010-07-16 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253

Dummy implementation of EditorClient::willSetInputMethodState.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::willSetInputMethodState):
  • WebProcess/WebCoreSupport/WebEditorClient.h:
17:34 Changeset [63601] by tony@chromium.org

2010-07-16 Tony Chang <tony@chromium.org>

Not reviewed, updating test expectations.

[chromium] clean up test expectations
https://bugs.webkit.org/show_bug.cgi?id=42491

  • platform/chromium/test_expectations.txt: fast/dynamic/flash-replacement-test.html doesn't exist and svg/filters/filter-empty-g.svg is a duplicate on Linux.
17:27 Changeset [63600] by alice.liu@apple.com

Build fix, not reviewed.

Reverted http://trac.webkit.org/changeset/63585 because getopt isn't
available in the OpenSource support libraries

  • WebKit2.sln:
17:08 Changeset [63599] by commit-queue@webkit.org

2010-07-16 Matthew Delaney <mdelaney@apple.com>

Reviewed by Sam Weinig.

Failing 2d.path.stroke.prune.arc philip canvas test
https://bugs.webkit.org/show_bug.cgi?id=42188

  • platform/mac/Skipped: Unskipped now passing tests.

2010-07-16 Matthew Delaney <mdelaney@apple.com>

Reviewed by Sam Weinig.

Failing 2d.path.stroke.prune.arc philip canvas test
https://bugs.webkit.org/show_bug.cgi?id=42188

  • html/canvas/CanvasRenderingContext2D.cpp: Note, updated parameter names to match spec. (WebCore::CanvasRenderingContext2D::lineTo): Pulled bound checking code out of lower code to have checks for all platforms. (WebCore::CanvasRenderingContext2D::arcTo): Bound checking per the spec for arcTo parameters. Updated parameter names to match spec.
  • platform/graphics/Path.h: Added in new method to expose the current position.
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::currentPoint): Added in likely correct implementation for this call with a FIXME just in case.
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::currentPoint): Added in support for this call.
  • platform/graphics/haiku/PathHaiku.cpp: (WebCore::Path::currentPoint): Added in stub for this call.
  • platform/graphics/openvg/PathOpenVG.cpp: (WebCore::Path::currentPoint): Added in likely implementation for this call with a FIXME just in case.
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::currentPoint): Added in implementation for this call courtesy of Andrea Kling.
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::currentPoint): Added in stub for this call.
  • platform/graphics/wince/PathWince.cpp: (WebCore::Path::currentPoint): Added in stub for this call.
  • platform/graphics/wx/PathWx.cpp: (WebCore::Path::currentPoint): Added in stub for this call.
16:43 Changeset [63598] by tony@chromium.org

2010-07-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r63593.
http://trac.webkit.org/changeset/63593
https://bugs.webkit.org/show_bug.cgi?id=42487

Broke a few chromium pixel tests (Requested by tonywork on
#webkit).

  • platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.checksum: Removed.
  • platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.png: Removed.
  • platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.txt: Removed.
  • platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.checksum: Removed.
  • platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.png: Removed.
  • platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.txt: Removed.
  • platform/mac/svg/stroke/path-zero-strokewidth-test-expected.checksum: Removed.
  • platform/mac/svg/stroke/path-zero-strokewidth-test-expected.png: Removed.
  • platform/mac/svg/stroke/path-zero-strokewidth-test-expected.txt: Removed.
  • svg/stroke/path-zero-strokewidth-test.svg: Removed.

2010-07-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r63593.
http://trac.webkit.org/changeset/63593
https://bugs.webkit.org/show_bug.cgi?id=42487

Broke a few chromium pixel tests (Requested by tonywork on
#webkit).

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
16:18 Changeset [63597] by adachan@apple.com

Reviewed by Alice Liu.

Fix Windows build.

  • WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
16:11 Changeset [63596] by ojan@chromium.org

2010-07-16 Ojan Vafai <ojan@chromium.org>

Unreviewed. Update expectations with new failures.

  • platform/chromium/test_expectations.txt:
16:03 Changeset [63595] by mitz@apple.com

Part of <rdar://problem/7233974> Deprecate +[WebView _setShouldUseFontSmoothing:]
https://bugs.webkit.org/show_bug.cgi?id=29355

Reviewed by Sam Weinig.

WebCore:

  • WebCore.exp.in: Updated.
  • platform/graphics/Font.cpp:

(WebCore::Font::Font): Added a font smoothing mode parameter to the constructor.
Set the font smoothing mode in the font description.

  • platform/graphics/Font.h:

WebKit/mac:

  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:]): Now calls through to
-_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing YES for the last
parameter.
(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Added
allowingFontSmoothing:. If font smoothing is not allowed, sets the font smoothing
mode to antialiased. Otherwise, sets it to auto.
(-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Instead of
changing the font smoothing setting in the graphics context, call
-_web_drawAtPoint:font:textColor:allowingFontSmoothing: passing NO for the last
parameter.

15:59 Changeset [63594] by commit-queue@webkit.org

2010-07-16 Satish Sampath <satish@chromium.org>

Reviewed by Anders Carlsson.

Add speech attribute to IDL for enabling access from JS.
https://bugs.webkit.org/show_bug.cgi?id=42483

No tests added, this change is a pre-requisite for future layout tests.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Update the renderer when speech attribute changes.
  • html/HTMLInputElement.idl: Added the speech attribute to IDL.
15:42 Changeset [63593] by commit-queue@webkit.org

2010-07-16 Fady Samuel <fsamuel@chromium.org>

Reviewed by David Levin.

Added layout test to show correct zero-width stroke.

SVG - stroke-width:0 bug with stroke other than "none"
https://bugs.webkit.org/show_bug.cgi?id=42387

  • platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.checksum: Added.
  • platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.png: Added.
  • platform/chromium-linux/svg/stroke/path-zero-strokewidth-test-expected.txt: Added.
  • platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.checksum: Added.
  • platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.png: Added.
  • platform/chromium-mac/svg/stroke/path-zero-strokewidth-test-expected.txt: Added.
  • platform/mac/svg/stroke/path-zero-strokewidth-test-expected.checksum: Added.
  • platform/mac/svg/stroke/path-zero-strokewidth-test-expected.png: Added.
  • platform/mac/svg/stroke/path-zero-strokewidth-test-expected.txt: Added.
  • svg/stroke/path-zero-strokewidth-test.svg: Added.

2010-07-16 Fady Samuel <fsamuel@chromium.org>

Reviewed by David Levin.

Avoids adding stroke when stroke-width is zero.

SVG - stroke-width:0 bug with stroke other than "none"
https://bugs.webkit.org/show_bug.cgi?id=42387

Test: svg/stroke/path-zero-strokewidth-test.svg

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
15:29 Changeset [63592] by tkent@chromium.org

2010-07-16 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::getThemeData): Fix a typo.
15:21 Changeset [63591] by andersca@apple.com

Remove semicolons from Objective-C method declarations.

Reviewed by Sam Weinig.

  • WebView/WebRenderLayer.mm:

(+[WebRenderLayer nameForLayer:]):
(+[WebRenderLayer compositingInfoForLayer:]):

15:20 Changeset [63590] by weinig@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=42482
<rdar://problem/8197701>
Add notification of when the BackForwardList changes
to aid invalidation of Back/Forward related UI elements.

Reviewed by Anders Carlsson.

WebKit2:

  • UIProcess/API/C/WKPage.h:

Add didChangeBackForwardList to the WKPageLoaderClient. This
fires whenever an item is added or removed from the back forward
list or when the cursor changes position.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didChangeBackForwardList):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeBackForwardList):

  • UIProcess/WebPageProxy.h:

Pipe changes to the WebBackForwardList up to the page load client.

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(_didStartProvisionalLoadForFrame):
(_didCommitLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didChangeBackForwardList):
(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
15:05 Changeset [63589] by tkent@chromium.org

2010-07-16 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] <input type=number> UI implementation for Windows
https://bugs.webkit.org/show_bug.cgi?id=42259

No additional tests. Existing tests cover this change and we'll
update expectations.

  • platform/chromium/ChromiumBridge.h: Add paintSpinButton().
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineState): Add ControlSubPart parameter and add support for spin buttons. (WebCore::RenderThemeChromiumWin::determineClassicState): ditto. (WebCore::RenderThemeChromiumWin::getThemeData): ditto. (WebCore::RenderThemeChromiumWin::adjustInnerSpinButtonStyle): Added. (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): Added.
  • rendering/RenderThemeChromiumWin.h: Declare ControlSubpart, and add it to some functions.

2010-07-16 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] <input type=number> UI implementation for Windows
https://bugs.webkit.org/show_bug.cgi?id=42259

  • public/WebThemeEngine.h: (WebKit::WebThemeEngine::paintSpinButton): Added.
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::paintSpinButton): Added. It calls WebThemeEngine::paintSpinButton().

2010-07-16 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] <input type=number> UI implementation for Windows
https://bugs.webkit.org/show_bug.cgi?id=42259

  • DumpRenderTree/chromium/WebThemeEngineDRT.cpp: (WebThemeEngineDRT::paintSpinButton): Added. Check state consistency and use existing arrow painting code.
  • DumpRenderTree/chromium/WebThemeEngineDRT.h:
15:03 Changeset [63588] by commit-queue@webkit.org

2010-07-16 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Use function provided by EFL for system beep
https://bugs.webkit.org/show_bug.cgi?id=42481

EFL port does not support automated tests, yet.

  • platform/efl/SoundEfl.cpp: (WebCore::systemBeep):
14:49 Changeset [63587] by commit-queue@webkit.org

2010-07-16 Sarah Strong <sarah.e.strong@gmail.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Clipboard data is lost on exit
https://bugs.webkit.org/show_bug.cgi?id=27411

No new tests. To manually test the bug fixed by this patch:
1) Open an application that uses a webkit webview on a GNOME-based system
2) Copy some text from that application
3) Optional: paste it to another application. This should work properly with and without this patch.
4) Exit the application completely.
5) Paste:

Without this patch, you cannot because your clipboard is empty.
With this patch, pasting succeeds.

I have not included an automated test because of the difficulty of testing behaviour after application exit.

14:40 Changeset [63586] by tkent@chromium.org

Keyboard operations for <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=42076

Reviewed by Darin Fisher.

WebCore:

  • The up arrow key works as stepUp().
  • The down arrow key works as stepDown().
  • Reject characters other than + - 0-9 . e E

Test: fast/forms/input-number-keyoperation.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):

Add up/down arrow keys support, and call handleBeforeTextInsertedEvent().

(WebCore::isNumberCharacter):
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):

For type=number, remove unacceptable characters.

  • html/HTMLInputElement.h:

LayoutTests:

  • fast/forms/input-number-keyoperation-expected.txt: Added.
  • fast/forms/input-number-keyoperation.html: Added.
  • fast/forms/script-tests/input-number-keyoperation.js: Added.
14:21 Changeset [63585] by alice.liu@apple.com

Add WebKitTestRunner to the WebKit2 solution

Reviewed by Sam Weinig.

  • WebKit2.sln: Add InjectedBundle and WebKitTestRunner projects. Also change the build dependency order from

DumpRunderTree --> WebKitAPITest to
DumpRenderTree --> InjectedBundle --> WebKitTestRunner --> WebKitAPITest

14:20 Changeset [63584] by bweinstein@apple.com

Land updated expected results for fast/dom/prototype-inheritance-2-expected.txt on Windows.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
14:20 Changeset [63583] by alice.liu@apple.com

https://bugs.webkit.org/show_bug.cgi?id=42430
Make WebKitTestRunner on Windows actually load and run a test

Reviewed by Sam Weinig.

  • WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Export WKBundleInitialize.

(WKBundleInitialize):

  • WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added. Output is a dll.
  • WebKitTestRunner/TestInvocation.cpp: Create a Windows-style path on Windows

(WTR::createWKURL):

  • WebKitTestRunner/WebKitTestRunnerPrefix.h: Change check for Windows platform to match

other existing checks, and avoid including Platform.h

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::registerWindowClass): Added.
(WTR::PlatformWebView::PlatformWebView): Implemented.
(WTR::PlatformWebView::~PlatformWebView): Implemented.
(WTR::PlatformWebView::page): Implemented.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::initializeInjectedBundlePath): Implemented. Provide build
configuration specific path to InjectedBundle.dll.

  • WebKitTestRunner/win/TestInvocationWin.cpp:

(WTR::TestInvocation::runUntil): Implemented.

  • WebKitTestRunner/win/WebKitTestRunner.sln: Added InjectedBundle project.
  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Cleaned up unnecessary dependencies.
14:18 Changeset [63582] by tkent@chromium.org

2010-07-16 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

Improve hover state handling for spin buttons
https://bugs.webkit.org/show_bug.cgi?id=42260

Background:
When we move the mouse cursor to a node from the outside of the node,
the following steps are executed.

  1. setHovered(true) is called.
  2. The node is repainted for the hover state.
  3. 'mousemove' event is dispatched for the node.

For a spin-button, RenderTheme::paint{Inner,Outer}SpinButton() is
called before the event handler of the spin-button. So we can't
detect which of the up part or the down part is hovered correctly.

Solution:
The hover state of a spin-button is one of three states;
Indeterminate, Up, and Down. The state is Indeterminate since
setHovered(true) is called and until 'mousemove' event is
dispatched.

No new tests because there are no implementation of spin-buttons
with hovered state yet.

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isSpinUpButtonPartPressed): (WebCore::RenderTheme::isHovered): Return false if the node is a spin-button and the state is Indeterminate. (WebCore::RenderTheme::isSpinUpButtonPartHovered):
  • rendering/TextControlInnerElements.cpp: (WebCore::SpinButtonElement::SpinButtonElement): Initialize m_upDownState. (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::SpinButtonElement::setHovered): Set the state to Indeterminate.
  • rendering/TextControlInnerElements.h: (WebCore::SpinButtonElement::upDownState):
14:11 Changeset [63581] by leandro@webkit.org

2010-07-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build system cleanup.

Move ExecutableAllocator{FixedVMPool,Posix,Symbian,Win}.cpp from
root CMakeLists.txt to the platform CMakeLists.txt.

  • CMakeLists.txt:
  • CMakeListsEfl.txt: Add ExecutableAllocatorPosix.cpp.

2010-07-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build system cleanup.

Remove reference to "mediaControlsGtk.css".

  • cmake/WebKitGenerators.cmake:
14:11 Changeset [63580] by commit-queue@webkit.org

2010-07-16 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] Avoid crashing if offscreen GLES2 context creation fails
https://bugs.webkit.org/show_bug.cgi?id=42469

If creating or initializing an offscreen GLES2Context fails we should return null
rather than crashing or returning an invalid context.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::getOffscreenGLES2Context):
14:01 Changeset [63579] by mitz@apple.com

<rdar://problem/7527532> Crash beneath setSelection() during detach()
https://bugs.webkit.org/show_bug.cgi?id=42020

Reviewed by Simon Fraser.

No test because I am unable to reproduce the crash.

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): In the clearSelection() case, where the repaint mode is
RepaintNewMinusOld, avoid making RenderBlockSelectionInfo instances, and thereby avoid calling
localToAbsolute() during detach().

13:47 Changeset [63578] by andersca@apple.com

clang++ build fixes for JavaScriptCore and WebCore
https://bugs.webkit.org/show_bug.cgi?id=42478

Reviewed by Sam Weinig.

JavaScriptCore:

  • runtime/RegExpKey.h:

(JSC::operator==):
Move the RegExpKey equals operator into the JSC namespace so it can be found by ADL.

WebCore:

  • platform/network/Credential.cpp:

(WebCore::Credential::type):

  • platform/network/Credential.h:

Remove const qualifier on Credential::type since it doesn't have an effect on the type.

13:46 Changeset [63577] by andersca@apple.com

Fix release build.

  • storage/Database.cpp:

(WebCore::DerefContextTask::performTask):

13:31 Changeset [63576] by simon.fraser@apple.com

2010-07-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Safari pegs CPU and drops frames on http://neography.com/experiment/circles/solarsystem/ (CSS animations)
https://bugs.webkit.org/show_bug.cgi?id=41409

AnimationController::isAnimatingPropertyOnRenderer() really asked whether an accelerated animation
or transition was running. This prevented us from falling into compositing layers for animation
on platforms, like Windows, that don't have accelerated animations.

Fix by making things more explicit: we now have two methods, isRunningAnimationOnRenderer()
and isRunningAcceleratedAnimationOnRenderer().

Changes are more extensive because I flipped the sense of 'm_fallbackAnimating', which is
now 'm_isAccelerated', for clarity.

Test: compositing/animation/animation-compositing.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::AnimationBase): m_fallbackAnimating -> m_isAccelerated (WebCore::AnimationBase::blendProperties): Ditto. (WebCore::AnimationBase::updateStateMachine): Ditto.
  • page/animation/AnimationBase.h: (WebCore::AnimationBase::isAnimatingProperty): Takes new acceleratedOnly parameter which causes the method to only return true if the animation is accelerated. (WebCore::AnimationBase::isAccelerated): Changed from isFallbackAnimating.
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer): (WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer): (WebCore::AnimationController::isRunningAnimationOnRenderer): (WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):
  • page/animation/CompositeAnimation.h:
  • page/animation/AnimationController.h: Rename isAnimatingPropertyOnRenderer(), add isRunningAcceleratedAnimationOnRenderer().
  • page/animation/AnimationControllerPrivate.h: Ditto.
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): !isFallbackAnimating() -> isAccelerated(). (WebCore::CompositeAnimation::isAnimatingProperty): Pass acceleratedOnly down.
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::timeToNextService): !isFallbackAnimating() -> isAccelerated().
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::timeToNextService): isFallbackAnimating() -> !isAccelerated().
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Avoid touching the transform or opacity if an accelerated animation is running.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingForAnimation): Make compositing layers if an animation of transform or opacity is running.
13:26 Changeset [63575] by ojan@chromium.org

2010-07-16 Ojan Vafai <ojan@chromium.org>

Unreviewed. Put expected result from r63568 in the right place.
It should apply to windows and linux, not just linux.

  • platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.txt.
13:25 Changeset [63574] by tonyg@chromium.org

2010-07-16 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Ojan Vafai.

Fix fast/dom/prototype-inheritance.html for chromium
https://bugs.webkit.org/show_bug.cgi?id=42477

  • fast/dom/script-tests/prototype-inheritance.js:
13:17 Changeset [63573] by simon.fraser@apple.com

2010-07-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Assertion when turning Accelerated Compositing off on a composited page
https://bugs.webkit.org/show_bug.cgi?id=42408

When accelerated compositing is turned off, check m_hasAcceleratedCompositing
before saying that the root layer will be composited. Fixes an assertion.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements):
12:45 Changeset [63572] by tonikitoo@webkit.org

Spatial navigation: do not consider outline for focusable element boundaries
https://bugs.webkit.org/show_bug.cgi?id=42474

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

Test: fast/events/spatial-navigation/snav-zero-margin-content.html

Currently in WebCore::renderRectRelativeToRootDocument function, we are calling
RenderObject::absoluteClippedOverflowRect to obtain the rect boundary of a given
renderer/element. This method deals with outline, which is out of elements boundary.
It makes spatial navigation to fail on common sites like google.gom: "Web, Images, Map, etc"
are inaccessible.

Patch replaces RenderObject::absoluteClippedOverflowRect by Node::getRect,
which returns only the absolute bounding box rect of the Element.

  • page/SpatialNavigation.cpp:

(WebCore::renderRectRelativeToRootDocument):
(WebCore::checkNegativeCoordsForNode):

LayoutTests:

  • fast/events/spatial-navigation/snav-zero-margin-content-expected.txt: Added.
  • fast/events/spatial-navigation/snav-zero-margin-content.html: Added.
12:37 Changeset [63571] by tonikitoo@webkit.org

2010-07-15 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Gustavo Noronha.

[Qt] Remove unnecessary WebKit headers inclusion from WebCore files
https://bugs.webkit.org/show_bug.cgi?id=42416

There are some places in WebCore unnecessarily including WebKit headers.

Cleaning up only, no testing needed.

  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/qt/RenderThemeQt.c
12:23 Changeset [63570] by mitz@apple.com

Refinement of r63556: moved the tab width computation back to Font, but added a
SimpleFontData parameter.

Reviewed by Anders Carlsson.

  • platform/graphics/Font.h:

(WebCore::Font::tabWidth):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

12:20 Changeset [63569] by tonyg@chromium.org

2010-07-16 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Pavel Feldman.

Fix unit error in calculating timings from ResourceLoadTiming API
https://bugs.webkit.org/show_bug.cgi?id=42473

The start and end offsets are already in milliseconds so they should not be multiplied by 1000.0 like requestTime.

No new tests because, for a yet unknown reason, the ResourceLoadTiming API is not populated in the chromium test shell like it is in full chromium. This means the test that would have caught this bug (fast/dom/webtiming.html) currently has its expectation set to FAIL.

  • page/Timing.cpp: (WebCore::Timing::domainLookupStart): (WebCore::Timing::domainLookupEnd): (WebCore::Timing::connectStart): (WebCore::Timing::connectEnd): (WebCore::Timing::requestStart): (WebCore::Timing::requestEnd): (WebCore::Timing::responseStart):
12:08 Changeset [63568] by ojan@chromium.org

2010-07-16 Ojan Vafai <ojan@chromium.org>

Unreviewed. Add another expected chromium failure and the missing the text expectation in r63567.

  • platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:36 Changeset [63567] by ojan@chromium.org

2010-07-16 Ojan Vafai <ojan@chromium.org>

Unreviewed. Add new chromium expectations and update expected failures. All updated expected
failures have the relevant details in the bugs.webkit.org bug.

Below are the revisions that caused needing new expectations.

http://trac.webkit.org/changeset/63531/
svg/custom/relative-sized-content-with-resources.xhtml
svg/custom/marker-child-changes-css.svg

http://trac.webkit.org/changeset/63542/
svg/text/selection-background-color.xhtml
svg/text/selection-styles.xhtml

http://trac.webkit.org/changeset/63517/
fast/css/empty-generated-content.html
css2.1/t1204-root-e.html

http://trac.webkit.org/changeset/63517/
html5lib/runner.html

  • platform/chromium-linux/svg/custom/marker-child-changes-css-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/marker-child-changes-expected.checksum.
  • platform/chromium-linux/svg/custom/marker-child-changes-css-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/marker-child-changes-expected.png.
  • platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.png: Added.
  • platform/chromium-linux/svg/text/selection-background-color-expected.checksum:
  • platform/chromium-linux/svg/text/selection-background-color-expected.png:
  • platform/chromium-linux/svg/text/selection-styles-expected.checksum:
  • platform/chromium-linux/svg/text/selection-styles-expected.png:
  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/css2.1/t1204-root-e-expected.txt:
  • platform/chromium-win/fast/css/empty-generated-content-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium-win/svg/custom/marker-child-changes-css-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-child-changes-expected.checksum.
  • platform/chromium-win/svg/custom/marker-child-changes-css-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-child-changes-expected.png.
  • platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
  • platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.png: Added.
  • platform/chromium-win/svg/text/selection-background-color-expected.checksum:
  • platform/chromium-win/svg/text/selection-background-color-expected.png:
  • platform/chromium-win/svg/text/selection-styles-expected.checksum:
  • platform/chromium-win/svg/text/selection-styles-expected.png:
  • platform/chromium/test_expectations.txt:
11:32 Changeset [63566] by oliver@apple.com

2010-07-16 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

ES5 allows use of reserved words as IdentifierName
https://bugs.webkit.org/show_bug.cgi?id=42471

Modify the lexer to allow us to avoid identifying reserved
words in those contexts where they are valid identifiers, and
we know it's safe. Additionally tag the reserved word tokens
so we can easily identify them in those cases where we can't
guarantee that we've skipped reserved word identification.

  • parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::parseProperty): (JSC::JSParser::parseMemberExpression):
  • parser/JSParser.h: (JSC::):
  • parser/Lexer.cpp: (JSC::Lexer::lex):
  • parser/Lexer.h: (JSC::Lexer::):

2010-07-16 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

ES5 allows use of reserved words as IdentifierName
https://bugs.webkit.org/show_bug.cgi?id=42471

Add tests to check for correct handling of reserved words with
the ES5 semantics.

  • fast/js/reserved-words-as-property-expected.txt: Added.
  • fast/js/reserved-words-as-property.html: Added.
  • fast/js/script-tests/reserved-words-as-property.js: Added. ():
  • fast/js/sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.5_Object_Initializer/S11.1.5_A4.1-expected.txt:
  • fast/js/sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.5_Object_Initializer/S11.1.5_A4.2-expected.txt: These tests are wrong, unsure how to get sputnik tests corrected.
11:22 Changeset [63565] by andersca@apple.com

LayoutTests/http/tests/cookies/multiple-cookies.html sometimes fails because the cookies are returned in a different order
https://bugs.webkit.org/show_bug.cgi?id=42095

Reviewed by Alexey Proskuryakov.

Normalize the cookie strings by splitting them into an array, sorting the array and then joining back.

  • http/tests/cookies/multiple-cookies-expected.txt:
  • http/tests/cookies/resources/cookies-test-pre.js:

(normalizeCookie):
(testCookies):

  • websocket/tests/httponly-cookie-expected.txt:
  • websocket/tests/httponly-cookie.pl:
11:01 Changeset [63564] by beidson@apple.com

2010-07-16 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Make revalidation of back/forward work a little better with page loads
https://bugs.webkit.org/show_bug.cgi?id=42470

  • MiniBrowser/mac/BrowserWindow.xib:
  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController validateToolbar]): (_didStartProvisionalLoadForFrame): (_didCommitLoadForFrame): (_didFailLoadWithErrorForFrame):
10:47 Changeset [63563] by andersca@apple.com

Remove fast/dynamic/flash-replacement-test.html
https://bugs.webkit.org/show_bug.cgi?id=42467

Reviewed by Simon Fraser.

This test doesn't really test anything since the flash file it points to doesn't exist, and
the flash replacement test requires a SWF file that triggers a style layout when instantiating the plug-in.

Furthermore, we don't even instantiate Netscape plug-ins from attach anymore which makes this test
even less accurate.

Also, it's failing on Mac if Flash 10.1, which uses the Core Animation drawing model, is installed.

  • fast/dynamic/flash-replacement-test.html: Removed.
  • platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.checksum: Removed.
  • platform/chromium-linux/fast/dynamic/flash-replacement-test-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/flash-replacement-test-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/flash-replacement-test-expected.png: Removed.
  • platform/chromium-win/fast/dynamic/flash-replacement-test-expected.txt: Removed.
  • platform/mac/fast/dynamic/flash-replacement-test-expected.checksum: Removed.
  • platform/mac/fast/dynamic/flash-replacement-test-expected.png: Removed.
  • platform/mac/fast/dynamic/flash-replacement-test-expected.txt: Removed.
  • platform/qt/fast/dynamic/flash-replacement-test-expected.txt: Removed.
10:46 Changeset [63562] by andersca@apple.com

Really add WARN_UNUSED_RESULT to leakRef
https://bugs.webkit.org/show_bug.cgi?id=42464

Reviewed by David Levin.

JavaScriptCore:

  • wtf/PassRefPtr.h:

(WTF::PassRefPtr::):
(WTF::NonNullPassRefPtr::):
Put the WARN_UNUSED_RESULT attribute at the right place.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::releaseRef):
Remove WARN_UNUSED_RESULT here for now, it leads to two warnings that need
to be fixed first.

WebCore:

Get rid of a call to releaseRef here by passing the ScriptExecutionContext
reference through to the DerefContextTask.

  • storage/Database.cpp:

(WebCore::DerefContextTask::create):
(WebCore::DerefContextTask::performTask):
(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):

10:16 Changeset [63561] by loislo@chromium.org

2010-07-16 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: The current implementation of generator is not ready
for generation Backend part of Inspector interface. The full patch
with Backend is quite big and I've split it.
https://bugs.webkit.org/show_bug.cgi?id=42462

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorValues.cpp: (WebCore::InspectorArray::get):
  • inspector/InspectorValues.h: (WebCore::InspectorArray::length):
09:50 Changeset [63560] by rwlbuis@webkit.org

2010-07-15 Rob Buis <rwlbuis@gmail.com>

Reviewed by Darin Adler.

An empty value for xml:lang isn't considered
https://bugs.webkit.org/show_bug.cgi?id=42042

Allow :lang selector to match empty values for xml:lang and
lang attributes.

Test: fast/css/lang-selector-empty-attribute.xhtml

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
09:38 Changeset [63559] by tonyg@chromium.org

2010-07-15 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

Update expectations for Web Timing enabled in chromium port.
https://bugs.webkit.org/show_bug.cgi?id=42313

Default expectations are to PASS (Web Timing enabled). Since the gtk, qt, win, and mac platforms do not have WEB_TIMING enabled, they must skip these tests.

  • fast/dom/Window/window-properties-performance-expected.txt: Added.
  • fast/dom/Window/window-properties-performance.html: Added.
  • fast/dom/Window/window-properties.html: Skip webkitPerformance so that its platform-specific expectations can be managed in window-properties-performance.html.
  • fast/dom/navigation-type-back-forward-expected.txt: Update to PASS
  • fast/dom/navigation-type-navigate-expected.txt: Update to PASS
  • fast/dom/navigation-type-reload-expected.txt: Update to PASS
  • fast/dom/webtiming-expected.txt: Updated to mostly PASS. Currently has failures because chromium is not populating the ResourceLoadTiming API. This will be resolved when http://codereview.chromium.org/2909016 lands.
  • fast/dom/webtiming.html: Update test based on new backfill functionality from https://bugs.webkit.org/show_bug.cgi?id=42303.
  • http/tests/misc/webtiming-one-redirect-expected.txt: Update to PASS
  • http/tests/misc/webtiming-two-redirects-expected.txt: Update to PASS
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-07-15 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

Enable window.webkitPerformance (Web Timing) for chromium
https://bugs.webkit.org/show_bug.cgi?id=42313

  • features.gypi:
09:28 Changeset [63558] by apavlov@chromium.org

2010-07-16 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Shift-Enter does not do a reverse search. It searches forward.
https://bugs.webkit.org/show_bug.cgi?id=42459

  • inspector/front-end/inspector.js: (WebInspector.performSearch):
09:11 Changeset [63557] by pfeldman@chromium.org

2010-07-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not include SSL time into Waiting time.

https://bugs.webkit.org/show_bug.cgi?id=42458

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):
09:08 Changeset [63556] by mitz@apple.com

<rdar://problem/8198266> white-space: pre text containing tabs is not laid out correctly when the font lacks a space glyph
https://bugs.webkit.org/show_bug.cgi?id=42437

Reviewed by Anders Carlsson.

No test because none of the fonts available to DumpRenderTree are missing a space glyph.

Changed the tab width computation to use the width of the space glyph from the font that has
a space glyph, which may be a fallback font if the primary font lacks a space glyph.

  • platform/graphics/Font.h: Removed Font::tabWidth().
  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

09:08 Changeset [63555] by yurys@chromium.org

2010-07-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r63551.
http://trac.webkit.org/changeset/63551
https://bugs.webkit.org/show_bug.cgi?id=42460

"Problems with gyp" (Requested by yurys on #webkit).

  • DEPS:
09:00 Changeset [63554] by pfeldman@chromium.org

2010-07-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add SSL time label into the resources popover.

https://bugs.webkit.org/show_bug.cgi?id=42458

  • English.lproj/localizedStrings.js:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::buildObjectForTiming):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):
08:53 Changeset [63553] by yurys@chromium.org

2010-07-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Chromium build fix. Add missing include.

  • inspector/ConsoleMessage.h:
08:50 Changeset [63552] by andreas.kling@nokia.com

2010-07-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Path: Avoid creating a new GraphicsContext in strokeContains() and strokeBoundingRect()
https://bugs.webkit.org/show_bug.cgi?id=42456

  • platform/graphics/qt/PathQt.cpp: (WebCore::scratchContext): Added, provides a scratch GraphicsContext. (WebCore::Path::strokeContains): Use the scratch context instead of creating a new GraphicsContext. (WebCore::Path::strokeBoundingRect): Ditto.
08:46 Changeset [63551] by yurys@chromium.org

2010-07-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Bump up Chromium revision.

  • DEPS:
08:38 Changeset [63550] by yurys@chromium.org

2010-07-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[V8] V8Proxy::retrieve may return null if javascript is disabled. Add a check
to avoid crashes in inspected page.
https://bugs.webkit.org/show_bug.cgi?id=42065

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::addListener):
08:33 Changeset [63549] by pfeldman@chromium.org

2010-07-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: disable AppCache in chromium.

https://bugs.webkit.org/show_bug.cgi?id=41858

Reviewed by Yury Semikhatsky.

Web Inspector: disable AppCache in chromium.

https://bugs.webkit.org/show_bug.cgi?id=41858

08:30 Changeset [63548] by yurys@chromium.org

2010-07-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

console.trace should show file and line number for each function in the stack
https://bugs.webkit.org/show_bug.cgi?id=21180

Test: inspector/console-trace.html

  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::initialize):
  • bindings/v8/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame):
  • bindings/v8/ScriptCallFrame.h:
  • bindings/v8/ScriptCallStack.cpp: (WebCore::getFrameLocation): (WebCore::toScriptCallFrame): (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::CallFrame::CallFrame): (WebCore::ConsoleMessage::CallFrame::isEqual): (WebCore::ConsoleMessage::CallFrame::createFrontendObject): (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype._createStackTraceElement): (WebInspector.ConsoleMessage.prototype._createSourceUrlLink):
  • inspector/front-end/inspector.css: (.console-message.expandable > .console-message-text::before): (.console-message.expandable.collapsed > .console-message-text::before): (.console-message.expandable.collapsed > ol.stack-trace): (.console-message > ol.stack-trace): (.console-message.repeated-message > ol.stack-trace): (.console-message.repeated-message > ol.stack-trace.trace-message):
  • page/Console.idl:

2010-07-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

console.trace should show file and line number for each function in the stack
https://bugs.webkit.org/show_bug.cgi?id=21180

  • http/tests/inspector/console-tests.js: (frontend_dumpConsoleMessages):
  • inspector/console-trace-expected.txt: Added.
  • inspector/console-trace.html: Added.
08:21 QtWebKitWeeklyBuilds edited by siddharth.mathur@nokia.com
added link to nightly builds from tronical's email (diff)
07:50 Changeset [63547] by apavlov@chromium.org

2010-07-16 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] A non-existent resource is referenced from devTools.css

The erroneous rule has been removed.
https://bugs.webkit.org/show_bug.cgi?id=42454

  • src/js/devTools.css:
07:41 Changeset [63546] by commit-queue@webkit.org

2010-07-16 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Build with MathML enabled. Fix build when MathML is enabled and
make it the default.
https://bugs.webkit.org/show_bug.cgi?id=42453

  • cmake/OptionsEfl.cmake: build with MathML enabled as default.

2010-07-16 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Build with MathML enabled. Fix build when MathML is enabled and
make it the default.
https://bugs.webkit.org/show_bug.cgi?id=42453

EFL port does not support automated tests, yet.

  • CMakeLists.txt: add missing source file and sort.
07:07 Changeset [63545] by commit-queue@webkit.org

2010-07-16 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Check that end node of a range has a valid renderer in WebViewImpl::caretOrSelectionBounds()
to avoid crash in Position::getInlineBoxAndOffset() when start node has renderer but end one doesn't.
https://bugs.webkit.org/show_bug.cgi?id=42449

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::caretOrSelectionBounds):
06:50 Changeset [63544] by commit-queue@webkit.org

2010-07-16 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

DeviceOrientationEvent.h should not forward-declare DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=42447

When destructing m_orientation, DeviceOrientation cannot be an incomplete type.

  • dom/DeviceOrientationEvent.h:
06:45 Changeset [63543] by yurys@chromium.org

2010-07-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Remove wrong test expectations for clip-path-child-changes.svg from chromium-mac
and mark it as flaky on mac.
https://bugs.webkit.org/show_bug.cgi?id=42445

  • platform/chromium-mac/svg/custom/clip-path-child-changes-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
04:39 Changeset [63542] by zimmermann@webkit.org

2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

gradientTransform + objectBoundingBox is wrong
https://bugs.webkit.org/show_bug.cgi?id=42446

gradientTransform + gradientUnits="objectBoundingBox" is wrong. Reverse multiplication order of both transforms.

  • rendering/RenderSVGResourceGradient.cpp: s/multiply/multLeft/

2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

gradientTransform + objectBoundingBox is wrong
https://bugs.webkit.org/show_bug.cgi?id=42446

Update pixel test results after fixing gradientTransform and gradientUnits="objectBoundingBox" usage for shapes & text.

  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/text/selection-background-color-expected.checksum:
  • platform/mac/svg/text/selection-background-color-expected.png:
  • platform/mac/svg/text/selection-styles-expected.checksum:
  • platform/mac/svg/text/selection-styles-expected.png:
04:38 Changeset [63541] by zimmermann@webkit.org

2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Forgot to land new pixel test result in r63535.

  • platform/mac/svg/custom/convolution-crash-expected.checksum:
  • platform/mac/svg/custom/convolution-crash-expected.png:
04:02 Changeset [63540] by zimmermann@webkit.org

2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Regenerated pixel test results for svg/dynamic-updates. Not enabling the actual dumping of pixel test results yet,
as we're having several regressions that should be identified first. Only updated results which only have text
rendering differences (after the text rewrite, last month).

  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Added.
04:00 Changeset [63539] by mnaganov@chromium.org

Unreviewed test expectations fix after r63537.

03:49 Changeset [63538] by mnaganov@chromium.org

Unreviewed. Whitespace change to WebKit/win/Interfaces/WebKit.idl to enforce IDL rebuild.

02:54 Changeset [63537] by mnaganov@chromium.org

2010-07-16 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Make JS memory stats available via 'Performance' object (Web Timing).
This statistics is populated only if 'WebKitMemoryInfoEnabled'
preference is set.

'console.memory' is kept until Web Timing object becomes visible by
default (currently it is hidden under compile-time flag). These stats
are guarded with the same preference.

https://bugs.webkit.org/show_bug.cgi?id=41617

  • bindings/js/JSConsoleCustom.cpp:
  • bindings/v8/custom/V8ConsoleCustom.cpp:
  • page/Console.cpp: (WebCore::Console::disconnectFrame): (WebCore::Console::memory):
  • page/Console.h:
  • page/Console.idl:
  • page/MemoryInfo.cpp: (WebCore::MemoryInfo::MemoryInfo):
  • page/MemoryInfo.h: (WebCore::MemoryInfo::create):
  • page/Performance.cpp: (WebCore::Performance::disconnectFrame): (WebCore::Performance::memory):
  • page/Performance.h:
  • page/Performance.idl:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setMemoryInfoEnabled): (WebCore::Settings::memoryInfoEnabled):
  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setMemoryInfoEnabled):
  • src/WebSettingsImpl.h:
  • WebKit.order:
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences memoryInfoEnabled]): (-[WebPreferences setMemoryInfoEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::memoryInfoEnabled): (WebPreferences::setMemoryInfoEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
02:48 Changeset [63536] by zimmermann@webkit.org

2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add possibility to dumpAsText and generate a pixel test result
https://bugs.webkit.org/show_bug.cgi?id=42374

Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode.
setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests.

This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result.
At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test.

Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled.
(Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything)

  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpAsTextAndPixelsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpAsTextAndPixels): (LayoutTestController::setDumpAsTextAndPixels):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::dumpAsTextAndPixels): (LayoutTestController::reset):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::shouldDumpAsTextAndPixels):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dump):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):
  • DumpRenderTree/mac/DumpRenderTree.mm: (dump):
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/win/DumpRenderTree.cpp: (dump):
  • DumpRenderTree/wx/DumpRenderTreeWx.cpp: (dump):
02:45 Changeset [63535] by zimmermann@webkit.org

2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convolution computation causes bad alpha channel values
https://bugs.webkit.org/show_bug.cgi?id=42273

Unbreak the convolve matrix filter, fixing svg/W3C-SVG-1.1/filters-conv-01-f.svg.

1) Fix clamping the rgb values:
"image->set(pixel++, clampRGBAValue(totals[0], maxAlpha));" totals[0] -> totals[i].

2) Don't apply the divisior divison and bias addition multiple times, accumulated!


  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::setDestinationPixels): Fix two evil bugs, breaking feConvolveMatrix.

2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convolution computation causes bad alpha channel values
https://bugs.webkit.org/show_bug.cgi?id=42273

Unbreak the convolve matrix filter, fixing svg/W3C-SVG-1.1/filters-conv-01-f.svg.
Update convolution-crash.svg results.

  • platform/mac/svg/custom/convolution-crash-expected.checksum:
  • platform/mac/svg/custom/convolution-crash-expected.png:
02:25 Changeset [63534] by zimmermann@webkit.org

2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Rebaseline two results which seemed to be corrupt (DRT warns).

  • platform/mac/svg/custom/convolution-crash-expected.checksum:
  • platform/mac/svg/custom/convolution-crash-expected.png:
  • platform/mac/svg/custom/mask-colorspace-expected.checksum:
  • platform/mac/svg/custom/mask-colorspace-expected.png:
01:40 Changeset [63533] by zimmermann@webkit.org

2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add missing layout test results for fast/js/numeric-compare.html, which landed in r63515.

  • fast/js/numeric-compare-expected.txt: Added.
01:32 Changeset [63532] by kent.hansen@nokia.com

2010-07-16 Kent Hansen <kent.hansen@nokia.com>

Unreviewed. Adding myself as committer.

  • Scripts/webkitpy/common/config/committers.py:
01:26 Changeset [63531] by zimmermann@webkit.org

2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

relative positioning does not work for radialGradient after window resize
https://bugs.webkit.org/show_bug.cgi?id=41249

Redesign the way resources are invalidated. No longer utilize the DOM tree, specifically SVGStyledElement::svgAttributeChanged(), to invalidate
all resources in the ancestor chain (including itself) when any attribute changes. rect.setAttribute("foo", "bar") should never invalidate the
resources. Also the old approach didn't work correctly if the root layout changed (eg. window size change) - we failed to invalidate the resources,
thus leading to wrong renderings.

Instead of calling setNeedsLayout(true) from the SVG*Element classes, call RenderSVGResource::markForLayoutAndParentResourceInvalidation(), which
does the same thing and invalidates all resources in the ancestor chain (removing the cached results from the HashMaps). This only happens from
the various svgAttributeChanged() methods, if we know which attribute changed, and what action has to be taken.

All SVG renderers now invalidate their own resources on layout() if the layout changed (selfNeedsLayout()=true). The resources will be recreated
and cached during the following paint() call.

Tests: svg/custom/marker-child-changes-css.svg

svg/custom/relative-sized-content-with-resources.xhtml

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout): If our layout changed, invalidate our resources, by calling RenderSVGResource::invalidateAllResourcesOfRenderer().
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): Ditto.
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): Ditto.
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): Ditto.
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::styleDidChange): Added, to invalidate resources on CSS changes, covered by new svg/custom/marker-child-changes-css.svg test.
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGResource.cpp: (WebCore::RenderSVGResource::markForLayoutAndResourceInvalidation): Add new "needsBoundaries" parameter, calling setNeedsBoundaries() on the target render object,

simplifying all RenderSVGResource* code.

(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation): New static method used from DOM tree to invalidate all cached resources in the ancestor chain

for a render object. Also marks the renderer for layout, if needed.

  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: Simplify code, remove no longer needed hacks, as invalidation is now carried out by render tree. (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): Add m_invalidationBlocked hack, to avoid invalidations, while we're mutating the render styles (which is a hack!). (WebCore::RenderSVGResourceClipper::invalidateClients): Don't do anything if m_invalidationBlocked=true. (WebCore::RenderSVGResourceClipper::invalidateClient): Ditto. (WebCore::RenderSVGResourceClipper::createClipData): Set m_invalidationBlocked before mutating render styles, as they are restored immediately after creating the clip image. (WebCore::RenderSVGResourceClipper::resourceBoundingBox): Remove no longer needed hack to initialize ClipperData earlier than applyResource() would do.
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation. (WebCore::RenderSVGResourceFilter::invalidateClient): Remove wrong assertion.
  • rendering/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation. (WebCore::RenderSVGResourceGradient::invalidateClient): Remove wrong assertion.
  • rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation. (WebCore::RenderSVGResourceMarker::invalidateClient): Remove wrong assertion.
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation. (WebCore::RenderSVGResourceMasker::invalidateClient): Remove wrong assertion. (WebCore::RenderSVGResourceMasker::resourceBoundingBox): Remove no longer needed hack to initializer MaskerData earlier than applyResource() would do.
  • rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation. (WebCore::RenderSVGResourcePattern::invalidateClient): Remove wrong assertion.
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): If our layout changed, invalidate our resources, by calling RenderSVGResource::invalidateAllResourcesOfRenderer().
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyResultsToTarget): Call RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer) instead of renderer->setNeedsLayout(true).
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyResultsToTarget): Ditto.
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged): Ditto.
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged): Ditto.
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::notifyFinished): Ditto.
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged): Ditto.
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::svgAttributeChanged): Ditto.
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): Ditto.
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged): Ditto.
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged): Ditto.
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged): Ditto.
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged): Ditto.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale): Ditto. (WebCore::SVGSVGElement::svgAttributeChanged): Ditto. (WebCore::SVGSVGElement::inheritViewAttributes): Ditto.
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement): Changed m_offset initialization from 0.0f to 0. (WebCore::SVGStopElement::svgAttributeChanged): Add missing implementation, calling RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer) on offsetAttr changes.
  • svg/SVGStopElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged): Don't call invalidateResourceInAncestorChain() on every attribute change, do it in all classes inheriting from us,

for specific attributes. Also stop calling RenderSVGResource::invalidateAllResourcesOfRenderer(), all handled in the render tree now.

(WebCore::SVGStyledElement::invalidateResourceClients): Early exit, if document is still parsing.

  • svg/SVGStyledElement.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::svgAttributeChanged): Call RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer) instead of renderer->setNeedsLayout(true).
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::svgAttributeChanged): Ditto.
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::svgAttributeChanged): Ditto.
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::svgAttributeChanged): Ditto.
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged): Ditto. (WebCore::SVGUseElement::updateContainerSizes): Ditto. (WebCore::SVGUseElement::updateContainerOffsets): Ditto.

2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

relative positioning does not work for radialGradient after window resize
https://bugs.webkit.org/show_bug.cgi?id=41249

  • platform/mac/svg/custom/marker-child-changes-css-expected.checksum: Added.
  • platform/mac/svg/custom/marker-child-changes-css-expected.png: Added.
  • platform/mac/svg/custom/marker-child-changes-css-expected.txt: Added.
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.png: Added.
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
  • svg/custom/marker-child-changes-css.svg: Added.
  • svg/custom/relative-sized-content-with-resources.xhtml: Added.
01:15 Changeset [63530] by commit-queue@webkit.org

2010-07-16 Cosmin Truta <ctruta@chromium.org>

Reviewed by Eric Seidel.

Some SVGs with empty <g> elements crash Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=41175

This is a SVG with an empty <g> within a <g>, to which a filter is applied by reference.
The rendered image is all blank.

  • platform/mac/svg/filters/filter-empty-g-expected.checksum: Added
  • platform/mac/svg/filters/filter-empty-g-expected.png: Added
  • platform/mac/svg/filters/filter-empty-g-expected.txt: Added
  • svg/filters/filter-empty-g.svg: Added

2010-07-16 Cosmin Truta <ctruta@chromium.org>

Reviewed by Eric Seidel.

Some SVGs with empty <g> elements crash Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=41175

Avoid painting of zero-sized image buffers. Skia can't handle it.

Test: svg/filters/filter-empty-g.svg

  • WebCore/platform/graphics/skia/ImageBufferSkia.cpp: (ImageBuffer::ImageBuffer):
00:50 Changeset [63529] by hamaji@chromium.org

2010-07-16 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

  • platform/chromium/test_expectations.txt:
00:46 Changeset [63528] by japhet@chromium.org

2010-07-16 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

Regression in r63100: Don't clear m_loadType in
FrameLoader::handledOnloadEvents, as it is used
to make some decisions after the load has actually
completed.

Tickling this bug requires manipulation
via the API (layout tests don't appear to traverse
the correct codepath), so no layout test.

https://bugs.webkit.org/show_bug.cgi?id=42298

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::handledOnloadEvents): Don't reset m_loadType. (WebCore::FrameLoader::addExtraFieldsToRequest): Set subresource cache

policy in one place and don't depend on m_loadType.

2010-07-16 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

Uncomment an assert that broke due to r63100.

https://bugs.webkit.org/show_bug.cgi?id=42298

  • tests/testwebview.c:
00:36 Changeset [63527] by hamaji@chromium.org

2010-07-16 Shinichiro Hamaji <hamaji@chromium.org>

Another uneviewed attempt to fix build.

Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createPagedBitmapContext):
00:12 Changeset [63526] by hamaji@chromium.org

2010-07-16 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed tiger build fix.

Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContext): (createBitmapContextFromWebView):

07/15/10:

23:38 Changeset [63525] by hamaji@chromium.org

2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed build fix.

Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

  • DumpRenderTree/PixelDumpSupport.cpp: (dumpWebViewAsPixelsAndCompareWithExpected):
23:34 Changeset [63524] by commit-queue@webkit.org

2010-07-15 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Put echo-challenge_wsh.py under workers/resources directory
https://bugs.webkit.org/show_bug.cgi?id=42439

I have realized that tests under workers/ directory should not depend on
a pywebsocket script in a directory above.

Putting *_wsh.py files under resources/ directory also benefits Chromium's
worker test which only copies the contents under workers/resources directory
when running WebSocket worker tests.

  • websocket/tests/workers/resources/echo-challenge_wsh.py: Copied from LayoutTests/websocket/tests/echo-challenge_wsh.py.
  • websocket/tests/workers/resources/worker-handshake-challenge-randomness.js:
23:33 Changeset [63523] by hamaji@chromium.org

2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed fix for chromium's expectation.

Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

  • platform/chromium/test_expectations.txt:
23:29 Changeset [63522] by hamaji@chromium.org

2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed fix for expected images.

Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

  • platform/mac/printing/page-rule-in-media-query-expected.checksum:
  • platform/mac/printing/page-rule-in-media-query-expected.png:
23:25 Changeset [63521] by hamaji@chromium.org

2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

Added printing/setPrinting.html to check there is the page boundary.

Enabled printing/composite-layer-printing.html with setPrinting.

The result of printing/media-queries-print.html shrunk because of
PrintingMinimumShrinkFactor in PrintContext::begin().

  • platform/mac/Skipped:
  • platform/mac/printing/compositing-layer-printing-expected.checksum: Added.
  • platform/mac/printing/compositing-layer-printing-expected.png: Added.
  • platform/mac/printing/compositing-layer-printing-expected.txt: Added.
  • platform/mac/printing/media-queries-print-expected.checksum:
  • platform/mac/printing/media-queries-print-expected.png:
  • platform/mac/printing/setPrinting-expected.checksum: Added.
  • platform/mac/printing/setPrinting-expected.png: Added.
  • platform/mac/printing/setPrinting-expected.txt: Added.
  • printing/compositing-layer-printing.html:
  • printing/setPrinting.html: Added.

2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

Added spoolAllPagesWithBoundaries into PrintContext.

Test: printing/setPrinting.html

  • WebCore.base.exp:
  • page/PrintContext.cpp: (WebCore::PrintContext::spoolAllPagesWithBoundaries):
  • page/PrintContext.h:

2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame printToCGContext:cgContext:pageWidthInPixels:]):

2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

  • DumpRenderTree/PixelDumpSupport.cpp: (dumpWebViewAsPixelsAndCompareWithExpected):
  • DumpRenderTree/PixelDumpSupport.h:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContext): This function was added to share bitmap context creation code. (createBitmapContextFromWebView): (createPagedBitmapContext):
23:18 Changeset [63520] by morrita@google.com

2010-07-15 MORITA Hajime <morrita@google.com>

Unrviewed, added missing expectations.

[chromium] r63422 caused svg/custom/svg-fonts-without-missing-glyph.xhtml to fail on Linux and Windows
https://bugs.webkit.org/show_bug.cgi?id=42402

  • platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.txt: Added.
22:28 Changeset [63519] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

fast/frames/contentWindow_Frame.html shouldn't depend on <body> before <frameset>
https://bugs.webkit.org/show_bug.cgi?id=42349

  • fast/frames/contentWindow_Frame.html:
22:17 Changeset [63518] by tkent@chromium.org

2010-07-15 Kent Tamura <tkent@chromium.org>

Unreviewed, small style fixes.

  • platform/chromium/ThemeChromiumMac.mm: (WebCore::ThemeChromiumMac::inflateControlPaintRect):
  • platform/mac/ThemeMac.mm: (WebCore::ThemeMac::inflateControlPaintRect):
22:16 Changeset [63517] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update LegacyHTMLTreeBuilder to insert whitespace between </head> and <body>
https://bugs.webkit.org/show_bug.cgi?id=42431

Insert these whitespace text nodes into the HTML element between <head>
and <body>, as required by HTML5. Previously, we just dropped them on
the floor.

  • html/LegacyHTMLTreeBuilder.cpp: (WebCore::LegacyHTMLTreeBuilder::handleError):

2010-07-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update LegacyHTMLTreeBuilder to insert whitespace between </head> and <body>
https://bugs.webkit.org/show_bug.cgi?id=42431

Update expected results. These results match the HTML5 parser.

  • editing/deleting/delete-br-in-last-table-cell-expected.txt:
  • fast/innerHTML/005-expected.txt:
  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected.txt:
  • http/tests/webarchive/cross-origin-stylesheet-crash-expected.webarchive:
  • http/tests/webarchive/test-css-url-encoding-expected.webarchive:
  • http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive:
  • http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive:
  • platform/mac/css2.1/t1204-root-e-expected.txt:
  • platform/mac/fast/css/empty-generated-content-expected.txt:
  • traversal/exception-forwarding-expected.txt:
  • traversal/script-tests/exception-forwarding.js:
  • webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
  • webarchive/adopt-attribute-styled-node-webarchive-expected.webarchive:
  • webarchive/adopt-inline-styled-node-webarchive-expected.webarchive:
  • webarchive/archive-empty-frame-dom-expected.webarchive:
  • webarchive/archive-with-unencoded-url-expected.webarchive:
  • webarchive/test-body-background-expected.webarchive:
  • webarchive/test-css-import-expected.webarchive:
  • webarchive/test-css-url-resources-in-stylesheets-expected.webarchive:
  • webarchive/test-css-url-resources-inline-styles-expected.webarchive:
  • webarchive/test-duplicate-resources-expected.webarchive:
  • webarchive/test-frameset-expected.webarchive:
  • webarchive/test-img-src-expected.webarchive:
  • webarchive/test-input-src-expected.webarchive:
  • webarchive/test-link-href-expected.webarchive:
  • webarchive/test-link-rel-icon-expected.webarchive:
  • webarchive/test-object-data-expected.webarchive:
  • webarchive/test-script-src-expected.webarchive:
  • webarchive/test-table-background-expected.webarchive:
  • webarchive/test-td-background-expected.webarchive:
22:15 Changeset [63516] by victorw@chromium.org

2010-07-15 Victor Wang <victorw@chromium.org>

Reviewed by David Levin.

[Chromium] Disable c4291 for chromium windows multi dll build.

https://bugs.webkit.org/show_bug.cgi?id=42177

2010-07-15 Victor Wang <victorw@chromium.org>

Reviewed by David Levin.

[Chromium] Chromium webkit dll updates:

-. Fix WEBKIT_IMPLEMENTATION in WebCommon so

dllimport works as expected.

-. Update webkit.gyp so targets that depend on webkit

has correct macros defined.

https://bugs.webkit.org/show_bug.cgi?id=42177

  • WebKit.gyp:
  • public/WebCommon.h:

2010-07-15 Victor Wang <victorw@chromium.org>

Reviewed by David Levin.

[chromium] update KURLGoogle decodeURLEscapeSequences to
use googleurl public api so it does not access functions in
url_canon_internal. This is for chromium multi-dll build.

https://bugs.webkit.org/show_bug.cgi?id=42177

Test: (unittest) WebKit\chromium\tests\KURLTest.cpp

  • platform/KURLGoogle.cpp: (WebCore::decodeURLEscapeSequences):
21:58 Changeset [63515] by ggaren@apple.com

2010-07-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Crash entering mail.yahoo.com
https://bugs.webkit.org/show_bug.cgi?id=42394


  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::argumentNumberFor): Added a NULL check. If the identifier we're resolving is not a local variable, registerFor returns NULL.
  • bytecompiler/NodesCodegen.cpp: (JSC::FunctionBodyNode::emitBytecode): Unrelated to the crash, but I noticed this while working on it: No need to NULL-check returnNode, since an early return has already done so.

2010-07-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Test for https://bugs.webkit.org/show_bug.cgi?id=42394
Crash entering mail.yahoo.com

  • fast/js/numeric-compare.html: Added.
  • fast/js/script-tests/numeric-compare.js: Added.
21:55 Changeset [63514] by tkent@chromium.org

2010-07-15 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm
https://bugs.webkit.org/show_bug.cgi?id=41932

Sync with ThemeMac.mm r61760.
This change doesn't contain r54299, r57603, r57734, r57741, and
r58533 because they conflict with Chromium change for
FlippedView().

  • platform/chromium/ThemeChromiumMac.mm: (WebCore::sizeFromNSControlSize): (WebCore::sizeFromFont): (WebCore::controlSizeFromPixelSize): (WebCore::setControlSize): (WebCore::convertControlStatesToThemeDrawState): (WebCore::stepperSizes): (WebCore::stepperControlSizeForFont): (WebCore::paintStepper): (WebCore::ThemeChromiumMac::controlSize): (WebCore::ThemeChromiumMac::minimumControlSize): (WebCore::ThemeChromiumMac::inflateControlPaintRect): (WebCore::ThemeChromiumMac::paint):
21:32 Changeset [63513] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Followup to https://bugs.webkit.org/show_bug.cgi?id=42214

Rebaseline GTK and Qt.

  • platform/gtk/fast/canvas/toDataURL-alpha-expected.txt: Added.
  • platform/qt/fast/canvas/toDataURL-alpha-expected.txt: Added.
21:27 Changeset [63512] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Followup to https://bugs.webkit.org/show_bug.cgi?id=42214

Move toDataURL-alpha-expected.txt to the platform, where it belongs.

  • fast/canvas/toDataURL-alpha-expected.txt: Removed.
  • platform/mac/fast/canvas/toDataURL-alpha-expected.txt: Copied from LayoutTests/fast/canvas/toDataURL-alpha-expected.txt.
20:53 Changeset [63511] by morrita@google.com

2010-07-15 MORITA Hajime <morrita@google.com>

Reviewed by David Levin.

[Chromium][Win] Crashes with <keygen> with huge padding.
https://bugs.webkit.org/show_bug.cgi?id=41737

  • fast/forms/large-parts-expected.txt: Added.
  • fast/forms/large-parts.html: Added.

2010-07-15 MORITA Hajime <morrita@google.com>

Reviewed by David Levin.

[Chromium][Win] Crashes with <keygen> with huge padding.
https://bugs.webkit.org/show_bug.cgi?id=41737

When we try to draw a large region, TransparencyWin can fail to
allocate a temporal buffer for composition. This change adds a
fallback path to ThemePainter to handle the buffer allocation
failure.

ThemePainter is no longer a subclass of TransparencyWin. It has
a TransparencyWin as a member.

Test: fast/forms/large-parts.html

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::ThemePainter): Added a fallback path.
20:06 Changeset [63510] by yuzo@google.com

2010-07-15 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Adler.

Fix for Bug 42362 - CSSSegmentedFontFace::isLoaded() const is not used anywhere
Remove the method.
https://bugs.webkit.org/show_bug.cgi?id=42362

No new tests because of no behavior changes.

  • css/CSSSegmentedFontFace.cpp:
  • css/CSSSegmentedFontFace.h:
20:02 Changeset [63509] by arv@chromium.org

2010-07-15 Erik Arvidsson <arv@chromium.org>

Reviewed by David Levin.

Add directional property enums to the switch in applyProperty
https://bugs.webkit.org/show_bug.cgi?id=42438

Build fix for chromium mac.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
19:58 Changeset [63508] by commit-queue@webkit.org

2010-07-15 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

Pull in pywebsocket-0.5.1
https://bugs.webkit.org/show_bug.cgi?id=42353

pywebsocket-0.5.1 contains a small bug fix (*) that should fix a worker test
in Chromium. There is no other functional change.

(*) http://code.google.com/p/pywebsocket/source/detail?r=265

  • Scripts/webkitpy/thirdparty/init.py: Bump pywebsocket version to 0.5.1.
19:43 Changeset [63507] by zmo@google.com

Adding my freenode irc id to committers' list.
Unreviewed.

19:31 Changeset [63506] by zmo@google.com

Fix the error in the WebCore/ChangeLog.

18:38 Changeset [63505] by zmo@google.com

2010-07-15 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

[chromium] Making the popup label color visible when the item is
selected.
https://bugs.webkit.org/show_bug.cgi?id=42271

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow): paint the label text with a different color when it is selected.

2010-07-13 Zhenyao Mo <zmo@google.com>

Reviewed by Nate Chapin.

bufferData and bufferSubData generate wrong error when null buffer is bound
https://bugs.webkit.org/show_bug.cgi?id=42125

  • fast/canvas/webgl/buffer-data-array-buffer-expected.txt:
  • fast/canvas/webgl/buffer-data-array-buffer.html: Test against the case where bound buffer is 0.
18:33 Changeset [63504] by jcivelli@chromium.org

2010-07-15 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

[chromium] Making the popup label color visible when the item is
selected.
https://bugs.webkit.org/show_bug.cgi?id=42271

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow): paint the label text with a different color when it is selected.
18:10 Changeset [63503] by ojan@chromium.org

2010-07-15 Ojan Vafai <ojan@chromium.org>

Unreviewed. Fix expected failure for test from r63494.

  • platform/chromium/test_expectations.txt:
18:00 Changeset [63502] by zmo@google.com

2010-07-13 Zhenyao Mo <zmo@google.com>

Reviewed by Nate Chapin.

WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): Implement paintRenderingResultsToCanvas(). (WebCore::GraphicsContext3DInternal::beginPaint): Just use paintRenderingResultsToCanvas().

2010-07-13 Zhenyao Mo <zmo@google.com>

Reviewed by Nate Chapin.

WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719

Tests: fast/canvas/webgl/canvas-test.html

fast/canvas/webgl/gl-pixelstorei.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::makeRenderingResultsAvailable): Paint the WebGL rendering results to canvas if it's 3d. (WebCore::HTMLCanvasElement::toDataURL): Paint the WebGL rendering results to canvas if it's 3d.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Paint the WebGL rendering results to canvas if it's 3d before drawing.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::markContextChanged): Mark it always for canvas2d.drawImage purpose. (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas): Paint the WebGL rendering results to canvas if it's dirty.
  • html/canvas/WebGLRenderingContext.h: Declare paintRenderingResultsToCanvas().
  • platform/graphics/GraphicsContext3D.h: Declare paintRenderingResultsToCanvas() & paintToCanvas().
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::paintToCanvas): Paint the rendered image pixels to the canvas.
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Implement paintRenderingResultsToCanvas().
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::beginPaint): Just call paintRenderingResultsToCanvas(). (WebCore::GraphicsContext3D::endPaint): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Implement paintRenderingResultsToCanvas().

2010-07-13 Zhenyao Mo <zmo@google.com>

Reviewed by Nate Chapin.

WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719

  • fast/canvas/webgl/canvas-test-expected.txt: Added.
  • fast/canvas/webgl/canvas-test.html: Added.
  • fast/canvas/webgl/gl-pixelstorei-expected.txt: Added.
  • fast/canvas/webgl/gl-pixelstorei.html: Added.
17:37 Changeset [63501] by ojan@chromium.org

2010-07-15 Ojan Vafai <ojan@chromium.org>

Unreviewed.

Update expected failures for tests to green chromium build.
Bugs are filed with all the relevant owners.

  • platform/chromium/test_expectations.txt:
17:31 Changeset [63500] by andersca@apple.com

Set notifyData to the stream's notification data
https://bugs.webkit.org/show_bug.cgi?id=42429

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::start):

17:24 Changeset [63499] by mjs@apple.com

Add some tests that hang or crash, and remove some that don't any more
https://bugs.webkit.org/show_bug.cgi?id=42411

Reviewed by Darin Adler.

  • platform/mac-wk2/Skipped:
17:08 Changeset [63498] by ojan@chromium.org

2010-07-15 Ojan Vafai <ojan@chromium.org>

Unreviewed.

Chromium expected results after r63472
https://bugs.webkit.org/show_bug.cgi?id=42425

  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/002-expected.txt:
  • platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/chromium-win/fast/table/cell-width-auto-expected.txt:
  • platform/chromium-win/fast/table/colgroup-preceded-by-caption-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug100334-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug139524-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug139524-4-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug25367-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug29058-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug43039-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug7471-expected.txt:
  • platform/chromium-win/tables/mozilla/core/misc-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/deleteCol1-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/deleteCol2-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/deleteCol3-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/insertCols1-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/insertCols2-expected.txt:
  • platform/chromium-win/tables/mozilla/dom/insertCols3-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/col_span-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug47163-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/col_span2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/cols1-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/columns-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
17:06 Changeset [63497] by andersca@apple.com

If needed, NPN_GetURL the src URL
https://bugs.webkit.org/show_bug.cgi?id=42424

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NPP_GetValue):
Add NPP_GetValue wrapper.

(WebKit::NetscapePlugin::shouldLoadSrcURL):
Check whether the src url should be cancelled.

(WebKit::NetscapePlugin::initialize):
If the src URL should be loaded, then load it.

17:00 Changeset [63496] by bfulgham@webkit.org

Build fix. Don't include CoreGraphics.h on non-CG builds.

  • WebKit2Prefix.h: Conditionalize include of CoreGraphics.h

to avoid build break on WinCairo.

16:49 Changeset [63495] by victorw@chromium.org

2010-07-15 Victor Wang <victorw@chromium.org>

Reviewed by David Levin.

Roll Chromium DEPS forward to r52483.
https://bugs.webkit.org/show_bug.cgi?id=42386

  • DEPS:
16:47 Changeset [63494] by thakis@chromium.org

2010-07-15 Nico Weber <thakis@chromium.org>

Reviewed by Ojan Vafai.

chromium/skia: Fix canvas.toDataURL in the presence of transparency
https://bugs.webkit.org/show_bug.cgi?id=42214

Test that toDataURL works with transparent images.

  • fast/canvas/toDataURL-alpha-expected.txt: Added.
  • fast/canvas/toDataURL-alpha.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/canvas/toDataURL-alpha-expected.checksum: Added.
  • platform/mac-leopard/fast/canvas/toDataURL-alpha-expected.png: Added.

2010-07-15 Nico Weber <thakis@chromium.org>

Reviewed by Ojan Vafai.

chromium/skia: Fix canvas.toDataURL in the presence of transparency
https://bugs.webkit.org/show_bug.cgi?id=42214

The problem was that SkBitmaps contain premultiplied data, but pnglib
doesn't expect premultiplied data. Now, the encoder unpremultiplies
data before sending it to pnglib.

Patch partially by deanm.

Covered by fast/canvas/toDataURL-alpha.html.

  • platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGBA): (WebCore::encodeImpl): (WebCore::PNGImageEncoder::encode):
16:40 Changeset [63493] by andersca@apple.com

Stop the plug-in stream when it's finished loading
https://bugs.webkit.org/show_bug.cgi?id=42423

Reviewed by Sam Weinig.

  • WebProcess/Plugins/DummyPlugin.cpp:

(WebKit::DummyPlugin::streamDidFinishLoading):

  • WebProcess/Plugins/DummyPlugin.h:

Add empty stub.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::streamDidFinishLoading):
Call NetscapePluginStream::didFinishLoading.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::didFinishLoading):
Stop the stream with NPRES_DONE.

  • WebProcess/Plugins/Plugin.h:

Add streamDidFinishLoading.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::didFinishLoading):
Call Plugin::streamDidFinishLoading.

16:40 Changeset [63492] by beidson@apple.com

2010-07-15 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Add toolbar and toolbar item validation for MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=42422

  • MiniBrowser/MBToolbarItem.h: Added.
  • MiniBrowser/MBToolbarItem.m: Added. (-[MBToolbarItem validate]):
  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController validateUserInterfaceItem:]):
  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/BrowserWindow.xib:
16:38 Changeset [63491] by mrowe@apple.com

Merge r63384.

16:38 Changeset [63490] by mrowe@apple.com

Versioning.

16:31 Changeset [63489] by commit-queue@webkit.org

2010-07-15 Scott Violet <sky@chromium.org>

Reviewed by David Levin.

[chromium] WebViewClient::removeAutofillSuggestions is not passed the correct name
https://bugs.webkit.org/show_bug.cgi?id=42385

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::autocompleteHandleKeyEvent): Use WebInputElement::nameForAutofill() instead of name.
16:29 Changeset [63488] by ojan@chromium.org

2010-07-15 Ojan Vafai <ojan@chromium.org>

Unreviewed.

Mark fast/forms/input-file-directory-upload.html as expected to fail.

  • platform/chromium/test_expectations.txt:
16:28 Changeset [63487] by andersca@apple.com

Pass URL stream data to the plug-in
https://bugs.webkit.org/show_bug.cgi?id=42420

Reviewed by Sam Weinig.

  • WebProcess/Plugins/DummyPlugin.cpp:

(WebKit::DummyPlugin::streamDidReceiveData):

  • WebProcess/Plugins/DummyPlugin.h:

Add empty stub.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::streamDidReceiveData):
Call NetscapePluginStream::didReceiveData.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::didReceiveData):
Deliver the data to the plug-in.

  • WebProcess/Plugins/Plugin.h:

Add pure virtual streamDidReceiveData member function.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::didReceiveData):
Call Plugin::streamDidReceiveData.

16:17 Changeset [63486] by mrowe@apple.com

New tag.

16:14 Changeset [63485] by commit-queue@webkit.org

2010-07-15 Alex Nicolaou <anicolao@chromium.org>

Reviewed by Eric Seidel.

Convolution computation causes bad alpha channel values
https://bugs.webkit.org/show_bug.cgi?id=42273

Fixed by clamping colour channel values to the alpha value so that
r <= a, g <= a, and b <= a after the convolution is applied. See
the bug for why I believe the SVG specification needs to be updated.
Test must be drawn to crash. 100x100 green rectangle is used to
indicate pass to minimize the chance of regression.

  • platform/mac/svg/custom/convolution-crash-expected.checksum: Added.
  • platform/mac/svg/custom/convolution-crash-expected.txt: Added.
  • svg/custom/convolution-crash.svg: Added.

2010-07-15 Alex Nicolaou <anicolao@chromium.org>

Reviewed by Eric Seidel.

Convolution computation causes bad alpha channel values
https://bugs.webkit.org/show_bug.cgi?id=42273

Fixed by clamping colour channel values to the alpha value so that
r <= a, g <= a, and b <= a after the convolution is applied. See
the bug for why I believe the SVG specification needs to be updated.
Test must be drawn to crash. 100x100 green rectangle is used to
indicate pass to minimize the chance of regression.

Test: svg/custom/convolution-crash.svg

  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::SkPMColorToColor):
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::clampRGBAValue): (WebCore::setDestinationPixels): (WebCore::FEConvolveMatrix::fastSetInteriorPixels): (WebCore::FEConvolveMatrix::fastSetOuterPixels):
16:08 Changeset [63484] by andersca@apple.com

Handle failed loads correctly
https://bugs.webkit.org/show_bug.cgi?id=42418

Reviewed by Sam Weinig.

  • WebProcess/Plugins/DummyPlugin.cpp:

(WebKit::DummyPlugin::streamDidFail):

  • WebProcess/Plugins/DummyPlugin.h:

Add empty stub.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::streamDidFail):
Call NetscapePluginStream::didFail.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::didReceiveResponse):
Take a reference to the plug-in stream in case starting it causes it to be destroyed.

(WebKit::NetscapePluginStream::didFail):
Take a reference to the plug-in stream in case stopping it causes it to be destroyed.

(WebKit::NetscapePluginStream::destroy):
Cancel the stream.

(WebKit::NetscapePluginStream::start):
If we fail to start the stream, cancel the load.

(WebKit::NetscapePluginStream::cancel):
Call NetscapePlugin::cancelStreamLoad.

(WebKit::NetscapePluginStream::notifyAndDestroyStream):
Don't call cancel here. notifyAndDestroyStream can be called when we don't want to cancel the
load, such as when it's already failed to load.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:

Add didFail.

  • WebProcess/Plugins/Plugin.h:

Add pure virtual streamDidFail member function.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::Stream):
Initialize m_streamWasCancelled to false.

(WebKit::PluginView::Stream::cancel):
Set m_streamWasCancelled to true.

(WebKit::PluginView::Stream::didFail):
Call Plugin::streamDidFail.

16:04 Changeset [63483] by victorw@chromium.org

2010-07-15 Victor Wang <victorw@chromium.org>

Unreviewed, add victorw irc nickname to committer list.

  • Scripts/webkitpy/common/config/committers.py:
16:00 Changeset [63482] by mrowe@apple.com

Versioning.

15:59 Changeset [63481] by mrowe@apple.com

New tag.

15:53 Changeset [63480] by mrowe@apple.com

Build fix.

15:51 Changeset [63479] by dumi@chromium.org

Unreviewed, Chromium-specific changes that I forgot to make in r63278.

WebCore:

  1. DatabaseTrackerChromium::getMaxSizeForDatabase() is called on

the context thread by sync DBs.

  1. Forgot to change V8SQLTransactionSyncCustom to return the

result set when executeSql() is called.

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):

LayoutTests:

Make the output of test-authorizer-sync.html shorter, so it can
all fit into a cookie (needed in order to be able to run it as a
Chromium UI test).

  • fast/workers/storage/resources/test-authorizer-sync.js:

(executeStatement):

  • fast/workers/storage/test-authorizer-sync-expected.txt:
15:47 Changeset [63478] by mrobinson@webkit.org

2010-07-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] Simplify the distribution step
https://bugs.webkit.org/show_bug.cgi?id=42414

  • GNUmakefile.am: Remove unused variables. Rely on WebCore/GNUmakefile.am to handle distributing IDL files from WebCore and to modify EXTRA_DIST.

2010-07-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] Simplify the distribution step
https://bugs.webkit.org/show_bug.cgi?id=42414

  • GNUmakefile.am: Add extra dist files directly to EXTRA_DIST instead of adding them by proxy via javascriptcore_dist. Sort the EXTRA_DIST list. Refer to create_hash_table and create_regexp_tables directly, as is the behavior with other code generation scripts.

2010-07-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] Simplify the distribution step
https://bugs.webkit.org/show_bug.cgi?id=42414

No new tests as this is just a build change.

  • GNUmakefile.am: Modify EXTRA_DIST directly and make sure the list of files is sorted. Also handle distributing the IDL files from the WebCore source tree.
15:41 Changeset [63477] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Update Qt expectionat to account for implicit <colgroup>.

  • platform/qt/fast/repaint/table-col-background-expected.txt:
15:29 Changeset [63476] by aroben@apple.com

Make killing Apache more reliable (on both Mac and Windows)

We previously had two ways of determining whether we had succeeded in
killing Apache:

1) checking the return value of kill(0, $apachePID)
2) checking whether Apache's PID file still exists

On Cygwin, Apache doesn't always delete its PID file when it exits,
making (2) unreliable. We unfortunately misdiagnosed this as an
impotency of Perl's kill function, which led to r63177 and r63355.

Now that we know that the real problem is that Apache doesn't always
delete its PID file on Windows, we can make a much better fix: always
use method (1) to determine whether we've killed Apache.

Fixes <http://webkit.org/b/42415> Killing Apache is unreliable,
leading to regression test failures (and general annoyance).

Reviewed by Anders Carlsson.

  • Scripts/webkitperl/httpd.pm:

(openHTTPD): Moved killing code from here to killHTTPD. Added a call
to delete the PID file in case Apache doesn't do this itself when
killed. Our later logic relies on the PID file being deleted after
this point.
(closeHTTPD): Removed killing logic and changed to just call killHTTPD
instead. killHTTPD's logic is a bit different from the logic we had
here, for the reasons stated above.
(killHTTPD): Added. Code came from openHTTPD.
(handleInterrupt): Bonus fix for Mac: don't hang when pressing Ctrl-C!
On Mac, don't try to kill Apache when we receive a signal, as Apache
will already have been killed by this point (though for some reason
this isn't detected by our killing logic in killHTTPD). On Cygwin, we
still need to kill Apache manually.

15:29 Changeset [63475] by victorw@chromium.org

2010-07-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r63446.
http://trac.webkit.org/changeset/63446
https://bugs.webkit.org/show_bug.cgi?id=42412

It broke the Chromium Windows bot due to missing dependencies
there. (Requested by dave_levin on #webkit).

  • DEPS:
15:23 Changeset [63474] by weinig@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=42358
<rdar://problem/8194512>
Hyphenation tests crash the Web process

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Add missing initializer.

15:21 Changeset [63473] by andersca@apple.com

Cancel stream loads when destroying NetscapePluginStreams
https://bugs.webkit.org/show_bug.cgi?id=42413

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::cancelStreamLoad):
Call PluginController::cancelStreamLoad.

(WebKit::NetscapePlugin::streamDidReceiveResponse):
Call NetscapePluginStream::didReceiveResponse.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::didReceiveResponse):
Try to start the stream.

(WebKit::NetscapePluginStream::sendJavaScriptStream):
Don't stop the stream if it can't be started. start handles that now.

(WebKit::isSupportedTransferMode):
Return whether the given transfer mode is supported.

(WebKit::NetscapePluginStream::start):
If the stream fails to start, call notifyAndDestroyStream. If it starts successfully but has
an unsupported transfer mode, call stop.

(WebKit::NetscapePluginStream::notifyAndDestroyStream):
Cancel the stream load unless it's being destroyed because it has finished loading.

  • WebProcess/Plugins/PluginController.h:

Add cancelStreamLoad pure virtual member function.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::cancel):
Tell the stream loader to cancel and null it out.

(WebKit::PluginView::cancelStreamLoad):
Get the stream and cancel it.

  • WebProcess/Plugins/PluginView.h:
15:17 Changeset [63472] by abarth@webkit.org

2010-07-15 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

LegacyHTMLTreeBuilder should insert an implicit <colgroup> before inserting <col> to match HTML5
https://bugs.webkit.org/show_bug.cgi?id=42346

This turned out to be an easy fix.

This is covered by lots of layout tests. I believe
all of the changed results to be progressions.

This change had no measurable effect on the parser benchmark.

  • html/LegacyHTMLTreeBuilder.cpp: (WebCore::LegacyHTMLTreeBuilder::colCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::getNode):
  • html/LegacyHTMLTreeBuilder.h:

2010-07-15 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

LegacyHTMLTreeBuilder should insert an implicit <colgroup> before inserting <col> to match HTML5
https://bugs.webkit.org/show_bug.cgi?id=42346

I believe all of these changes to be progressions.

  • html5lib/runner-expected.txt:
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/fast/repaint/table-col-background-expected.txt:
  • platform/mac/fast/table/border-collapsing/002-expected.txt:
  • platform/mac/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/mac/fast/table/cell-width-auto-expected.txt:
  • platform/mac/fast/table/colgroup-preceded-by-caption-expected.txt:
  • platform/mac/fast/table/fixed-granular-cols-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug100334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug139524-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug139524-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug25367-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug29058-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug43039-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug43854-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7471-expected.txt:
  • platform/mac/tables/mozilla/core/misc-expected.txt:
  • platform/mac/tables/mozilla/dom/deleteCol1-expected.txt:
  • platform/mac/tables/mozilla/dom/deleteCol2-expected.txt:
  • platform/mac/tables/mozilla/dom/deleteCol3-expected.txt:
  • platform/mac/tables/mozilla/dom/insertCols1-expected.txt:
  • platform/mac/tables/mozilla/dom/insertCols2-expected.txt:
  • platform/mac/tables/mozilla/dom/insertCols3-expected.txt:
  • platform/mac/tables/mozilla/marvin/col_span-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug47163-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/cols1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/columns-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
15:11 Changeset [63471] by andersca@apple.com

Attempt to fix the Windows build.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::didReceiveResponse):
expectedContentLength should be a signed long long.

15:08 Changeset [63470] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

fast/frames/frame-deep-nested-resize.html shouldn't depend on <body> before <frameset>
https://bugs.webkit.org/show_bug.cgi?id=42351

  • fast/frames/frame-deep-nested-resize.html:
15:05 Changeset [63469] by mrowe@apple.com

Merge r63452.

15:02 Changeset [63468] by mrowe@apple.com

Merge r63283.

14:49 Changeset [63467] by weinig@apple.com

Patch for https://bugs.webkit.org/show_bug.cgi?id=42410
Many leaking DatasetDOMStringMaps seen on buildbot

Reviewed by Oliver Hunt.

  • dom/NodeRareData.h:

(WebCore::NodeRareData::~NodeRareData): Add a virtual destructor so
that the ElementRareData's destructor will be called when this is deleted
from the Node's destructor.

14:47 Changeset [63466] by cfleizach@apple.com

AX: Crash when table has empty thead tag
https://bugs.webkit.org/show_bug.cgi?id=42391

Reviewed by Darin Adler.

WebCore:

Test: accessibility/table-with-empty-thead-causes-crash.html

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::headerObjectForSection):

LayoutTests:

  • accessibility/table-with-empty-thead-causes-crash-expected.txt: Added.
  • accessibility/table-with-empty-thead-causes-crash.html: Added.
14:47 Changeset [63465] by weinig@apple.com

Patch for https://bugs.webkit.org/show_bug.cgi?id=42399
Update MiniBrowser for WKFrameNavigationType

Reviewed by Anders Carlsson.

  • MiniBrowser/mac/BrowserWindowController.m:

(_decidePolicyForNavigationAction):
(_decidePolicyForNewWindowAction):

14:39 Changeset [63464] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

deleteCol{1,2,3} and insertCols{1,2,3} will fail in HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=42404

The HTML5 parser adds an implied colgroup element as a parent of the
col element. This DOM change breaks these tests because they assume
the col element's parent is the table element. However, these tests
don't appear to be intended to test this behavior specifically.

I checked the behavior in IE8. These tests fail in IE8 in the same way
that they fail under the HTML5 parser (i.e., with an exception), which
leads me to believe that we're moving in the right direction. With this
patch, the DOM operations succeed in IE8 but the tests fail because the
layout isn't what we expect. I'm not sure whose layout is correct, but
that's not really my concern in this patch.

  • tables/mozilla/dom/deleteCol1.html:
  • tables/mozilla/dom/deleteCol2.html:
  • tables/mozilla/dom/deleteCol3.html:
  • tables/mozilla/dom/insertCols1.html:
  • tables/mozilla/dom/insertCols2.html:
  • tables/mozilla/dom/insertCols3.html:
14:38 Changeset [63463] by slewis@apple.com

SunSpider: http://bugs.webkit.org/show_bug.cgi?id=42406
Output location of results file.

Reviewed by Geoff Garen.

  • sunspider:

WebKitTools: http://bugs.webkit.org/show_bug.cgi?id=42406
Make SunSpider work better with roots.

Reviewed by Geoff Garen.

  • Scripts/sunspider-compare-results: fix argument bug
  • Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level.
14:37 Changeset [63462] by andersca@apple.com

Start loading plug-in streams
https://bugs.webkit.org/show_bug.cgi?id=42407

Reviewed by Sam Weinig.

WebCore:

Export some ResourceRequestBase getters.

  • WebCore.exp.in:

WebKit2:

  • WebProcess/Plugins/DummyPlugin.cpp:

(WebKit::DummyPlugin::streamDidReceiveResponse):

  • WebProcess/Plugins/DummyPlugin.h:

Add empty stub.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::streamDidReceiveResponse):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add empty stub.

  • WebProcess/Plugins/Plugin.h:

Add streamDidReceiveResponse pure virtual member function.

  • WebProcess/Plugins/PluginView.cpp:

Make PluginView::Stream a NetscapePlugInStreamLoaderClient.

(WebKit::PluginView::Stream::start):
Create a plug-in loader and start loading.

(WebKit::PluginView::Stream::didReceiveResponse):
Get the necessary data out of the resource response and call streamDidReceiveResponse.

(WebKit::PluginView::Stream::didReceiveData):
(WebKit::PluginView::Stream::didFail):
(WebKit::PluginView::Stream::didFinishLoading):
Add empty stubs.

14:10 Changeset [63461] by ojan@chromium.org

2010-07-15 Ojan Vafai <ojan@chromium.org>

Unreviewed.

Assorted changes to chromiums test expectations. New results are all clearly correct.

svg/custom/recursive-clippath.svg started failing at r63420
fast/repaint/renderer-destruction-by-invalidateSelection-crash.html started failing at r63403
svg/custom/recursive-gradient.svg started failing at r63416
svg/custom/recursive-pattern.svg started failing at r63415

  • platform/chromium-linux/svg/custom/recursive-gradient-expected.checksum:
  • platform/chromium-linux/svg/custom/recursive-pattern-expected.checksum:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/svg/custom/recursive-clippath-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/recursive-clippath-expected.png:
  • platform/chromium-win/svg/custom/recursive-gradient-expected.checksum:
  • platform/chromium-win/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-win/svg/custom/recursive-pattern-expected.checksum:
  • platform/chromium-win/svg/custom/recursive-pattern-expected.png:
  • platform/chromium/test_expectations.txt:
14:05 Changeset [63460] by kbr@google.com

2010-07-15 Kenneth Russell <kbr@google.com>

Reviewed by Nate Chapin.

Query of NUM_COMPRESSED_TEXTURE_FORMATS must be handled by WebGL
https://bugs.webkit.org/show_bug.cgi?id=42401

No new tests; covered by gl-get-calls.html.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getParameter):
    • Return 0 for getParameter(NUM_COMPRESSED_TEXTURE_FORMATS).

2010-07-15 Kenneth Russell <kbr@google.com>

Reviewed by Nate Chapin.

Query of NUM_COMPRESSED_TEXTURE_FORMATS must be handled by WebGL
https://bugs.webkit.org/show_bug.cgi?id=42401

  • fast/canvas/webgl/gl-get-calls-expected.txt:
13:57 Changeset [63459] by simon.fraser@apple.com

2010-07-15 Simon Fraser <simon.fraser@apple.com>

Fix results of two tests that are affected by r63452.

  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/plugins/small-to-large-composited-plugin-expected.txt:
13:55 Changeset [63458] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

frameset.pl has some bogus HTML
https://bugs.webkit.org/show_bug.cgi?id=42347

HTML5 ignores <frameset> elements inside <body> elements. Instead of
creating a random body element (using bogus Perl), we just create the
frameset. The body/frameset interaction is covered by parser tests.

  • http/tests/navigation/resources/frameset.pl:
13:45 Changeset [63457] by andersca@apple.com

Add a PluginView::Stream class
https://bugs.webkit.org/show_bug.cgi?id=42398

Reviewed by Sam Weinig.

  • WebProcess/Plugins/PluginView.cpp:

Add the Stream class.

(WebKit::PluginView::performURLRequest):
Create the stream and start it.

(WebKit::PluginView::addStream):
Add the stream to the map.

(WebKit::PluginView::removeStream):
Remove the stream from the map.

  • WebProcess/Plugins/PluginView.h:

Add Stream forward declaration and the m_streams map.

13:45 Changeset [63456] by beidson@apple.com

2010-07-15 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Hook up back/forward in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=42397

  • MiniBrowser/mac/BrowserWindow.xib:
  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController goBack:]): (-[BrowserWindowController goForward:]):
13:39 Changeset [63455] by weinig@apple.com

Patch for https://bugs.webkit.org/show_bug.cgi?id=42396
Give the navigation type in the policy client callbacks meaning.

Reviewed by Anders Carlsson.

  • Use the new WKFrameNavigationType instead of just uint32_t.
  • UIProcess/API/C/WKAPICast.h:

(toWK):
Add conversion method from WebCore::NavigationType to WKFrameNavigationType.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):

  • UIProcess/WebPolicyClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
13:36 Changeset [63454] by johnnyg@google.com

2010-07-07 John Gregg <johnnyg@google.com>

Reviewed by Jian Li.

Experimental directory upload feature.
https://bugs.webkit.org/show_bug.cgi?id=40872

This patch adds a new HTML attribute webkitdirectory which applies to
<input type="file"> tags and allows the user to specify a folder
which is recursively enumerated so that all the files in that folder
are added to the file list.

The files chosen in that way have a .webkitRelativePath attribute which contains
the relative path starting from the chosen folder. The relative path is
also appended to each item in the FormData when uploaded.

All the code is behind an ENABLE_DIRECTORY_UPLOAD flag.

Test: fast/forms/input-file-directory-upload.html

  • html/Blob.cpp: (WebCore::Blob::Blob):
  • html/Blob.h:
  • html/File.cpp: (WebCore::File::File): (WebCore::File::Init): (WebCore::File::webkitRelativePath):
  • html/File.h: (WebCore::File::create):
  • html/File.idl:
  • html/HTMLAttributeNames.in: add webkitdirectory attribute
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setFileListFromRenderer): (WebCore::HTMLInputElement::webkitdirectory):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • platform/BlobItem.cpp: (WebCore::FileBlobItem::create): (WebCore::FileBlobItem::FileBlobItem):
  • platform/BlobItem.h: (WebCore::FileBlobItem::relativePath):
  • platform/FileChooser.h: (WebCore::FileChooser::allowsDirectoryUpload):
  • platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::allowsMultipleFiles): (WebCore::RenderFileUploadControl::allowsDirectoryUpload):
  • rendering/RenderFileUploadControl.h:

2010-07-07 John Gregg <johnnyg@google.com>

Reviewed by Jian Li.

Layout test for experimental directory upload feature. Only enabled on chromium since that's where the feature is compiled in.
https://bugs.webkit.org/show_bug.cgi?id=40872

  • fast/forms/input-file-directory-upload-expected.txt: Added.
  • fast/forms/input-file-directory-upload.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
13:23 Changeset [63453] by andersca@apple.com

Don't allow multiple calls to NetscapePluginStream::stop
https://bugs.webkit.org/show_bug.cgi?id=42395

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::NetscapePluginStream):
Initialize m_urlNotifyHasBeenCalled.

(WebKit::NetscapePluginStream::~NetscapePluginStream):
Assert that the stream didn't need a URL notification or that one was sent.

(WebKit::NetscapePluginStream::sendJavaScriptStream):
Don't call stop in the JS failure case because the stream won't be started.

(WebKit::NetscapePluginStream::stop):
Remove m_isStarted check and add an assertion instead. Move code that calls NPP_URLNotify and
destroys the stream out to a separate function.

(WebKit::NetscapePluginStream::notifyAndDestroyStream):
Call NPP_URLNotify if necessary and destroy the stream.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
13:08 Changeset [63452] by simon.fraser@apple.com

2010-07-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Avoid creating huge compositing layers for elements that project outside the viewport
https://bugs.webkit.org/show_bug.cgi?id=42338

The logic that computed the bounds of compositing layers naively used the
union of the bounds of descendant, non-composited RenderLayers, without regard
to what is actually visible. This could result in huge layers for page with
elements are large negative offsets, or with large negative text-indent (both
common).

For elements without transforms on them or in their ancestor chain, and when
no 3d transforms or hardware-accelerated animations are used, can clip compositing
layers to the size of the document, or based on CSS overflow and clip.

Tests: compositing/geometry/limit-layer-bounds-clipping-ancestor.html

compositing/geometry/limit-layer-bounds-fixed-positioned.html
compositing/geometry/limit-layer-bounds-overflow-repaint.html
compositing/geometry/limit-layer-bounds-positioned-transition.html
compositing/geometry/limit-layer-bounds-positioned.html
compositing/geometry/limit-layer-bounds-transformed-overflow.html
compositing/geometry/limit-layer-bounds-transformed.html

  • rendering/RenderLayerBacking.cpp: (WebCore::enclosingOverflowClipAncestor): Walk up the RenderLayer tree looking for an ancestor that has overflow, or to the root. Along the way, check for transformed elements. (WebCore::RenderLayerBacking::updateCompositedBounds): If we're in "consult overlap" mode, and we don't have transforms, then constrain the bounds of composited layers by the RenderView's layoutOverflowRect(), or by the enclosing layer with overflow. (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): If the offset from the renderer changes, we need to repaint the layer.
13:06 Changeset [63451] by andersca@apple.com

Implement NPN_DestroyStream
https://bugs.webkit.org/show_bug.cgi?id=42393

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_DestroyStream):
Call NetscapePlugin::destroyStream.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::destroyStream):
Check if the stream is valid, and if it is call NetscapePluginStream::destroy.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::sendJavaScriptStream):
Keep a reference to the stream in case it's destroyed by an NPP_ call.

(WebKit::NetscapePluginStream::destroy):
Verify that the stream can be destroyed and stop it.

(WebKit::NetscapePluginStream::deliverDataToPlugin):
Add m_isStarted checks after any calls to NPP_ functions.

(WebKit::NetscapePluginStream::stop):
Set m_isStarted to false before calling NPP_DestroyStream.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:

(WebKit::NetscapePluginStream::npStream):
Add NPStream getter.

13:02 Changeset [63450] by commit-queue@webkit.org

2010-07-15 Alex Nicolaou <anicolao@chromium.org>

Reviewed by Dirk Schulze.

https://bugs.webkit.org/show_bug.cgi?id=42228

SVG Masks were in the wrong colour space for non-CG graphics layers,
because for those cases ImageBuffer needs to be explicitly told to
convert the pixels. This change adds a test that demonstrates the
problem and the conversion call to make the mask LinearRGB.

  • platform/mac/svg/custom/mask-colorspace-expected.checksum: Added.
  • platform/mac/svg/custom/mask-colorspace-expected.png: Added.
  • platform/mac/svg/custom/mask-colorspace-expected.txt: Added.
  • svg/custom/mask-colorspace.svg: Added.

2010-07-15 Alex Nicolaou <anicolao@chromium.org>

Reviewed by Dirk Schulze.

https://bugs.webkit.org/show_bug.cgi?id=42228

SVG Masks were in the wrong colour space for non-CG graphics layers,
because for those cases ImageBuffer needs to be explicitly told to
convert the pixels. This change adds a test that demonstrates the
problem and the conversion call to make the mask LinearRGB.

Test: svg/custom/mask-colorspace.svg

  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::createMaskImage):
13:00 Changeset [63449] by oliver@apple.com

Fix dumping of op_put_by_id.

Reviewed by Geoff Garen.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printPutByIdOp):

12:43 Changeset [63448] by ojan@chromium.org

Fix Changelog deletion from r63447

12:40 Changeset [63447] by ojan@chromium.org

2010-07-15 Ojan Vafai <ojan@chromium.org>

Unreviewed.

[chromium] Hopefully final cleanup for fallout from r63403.

  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.txt:
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
12:37 Changeset [63446] by victorw@chromium.org

2010-07-15 Victor Wang <victorw@chromium.org>

Reviewed by David Levin.

Roll Chromium DEPS forward to r52483.
https://bugs.webkit.org/show_bug.cgi?id=42386

  • DEPS:
12:18 Changeset [63445] by dbates@webkit.org

2010-07-15 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

[Mac] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37929

Implements support for markerTextForListItem in the Mac port.

  • DOM/WebDOMOperations.mm: (+[DOMElement _DOMElementFromJSContext]): Added. (-[DOMElement _markerTextForListItem]): Added.
  • DOM/WebDOMOperationsPrivate.h:

2010-07-15 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

[Mac] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37929

Export symbols for WebCore::markerTextForListItem() and WebCore::toElement().

  • WebCore.exp.in:

2010-07-15 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

[Mac] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37929

Remove skipped layout tests now that we have DRT support.

  • platform/mac/Skipped:

2010-07-15 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

[Mac] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37929

Implements DRT support for markerTextForListItem in the Mac port.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::markerTextForListItem): Implemented.
12:12 Changeset [63444] by kbr@google.com

2010-07-15 Kenneth Russell <kbr@google.com>

Reviewed by Nate Chapin.

Synchronize Khronos and WebKit WebGL tests
https://bugs.webkit.org/show_bug.cgi?id=42185

For the WebGL tests in the Khronos repository that originated in
the WebKit repository, synchronized the latest versions of these
tests using a script which will be checked in later. Copied
webgl-test-utils.js from Khronos repo and added needed entry
points to webgl-test.js. Rebaselined tests as necessary and
verified the rebaselining manually.

  • fast/canvas/webgl/array-buffer-crash-expected.txt:
  • fast/canvas/webgl/array-buffer-crash.html:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
  • fast/canvas/webgl/context-attributes-expected.txt:
  • fast/canvas/webgl/context-attributes.html:
  • fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html:
  • fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-arrays-out-of-bounds.html:
  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html:
  • fast/canvas/webgl/error-reporting-expected.txt:
  • fast/canvas/webgl/error-reporting.html:
  • fast/canvas/webgl/get-active-test-expected.txt:
  • fast/canvas/webgl/get-active-test.html:
  • fast/canvas/webgl/gl-bind-attrib-location-test-expected.txt:
  • fast/canvas/webgl/gl-bind-attrib-location-test.html:
  • fast/canvas/webgl/gl-enable-enum-test.html:
  • fast/canvas/webgl/gl-enum-tests-expected.txt:
  • fast/canvas/webgl/gl-enum-tests.html:
  • fast/canvas/webgl/gl-get-calls-expected.txt:
  • fast/canvas/webgl/gl-get-calls.html:
  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html:
  • fast/canvas/webgl/gl-uniform-arrays.html:
  • fast/canvas/webgl/gl-uniformmatrix4fv.html:
  • fast/canvas/webgl/index-validation-copies-indices-expected.txt:
  • fast/canvas/webgl/index-validation-copies-indices.html:
  • fast/canvas/webgl/index-validation-crash-with-buffer-sub-data-expected.txt:
  • fast/canvas/webgl/index-validation-crash-with-buffer-sub-data.html:
  • fast/canvas/webgl/index-validation-expected.txt:
  • fast/canvas/webgl/index-validation-verifies-too-many-indices-expected.txt:
  • fast/canvas/webgl/index-validation-verifies-too-many-indices.html:
  • fast/canvas/webgl/index-validation-with-resized-buffer-expected.txt:
  • fast/canvas/webgl/index-validation-with-resized-buffer.html:
  • fast/canvas/webgl/index-validation.html:
  • fast/canvas/webgl/invalid-UTF-16.html:
  • fast/canvas/webgl/null-object-behaviour-expected.txt:
  • fast/canvas/webgl/null-object-behaviour.html:
  • fast/canvas/webgl/null-uniform-location.html:
  • fast/canvas/webgl/point-size-expected.txt:
  • fast/canvas/webgl/point-size.html:
  • fast/canvas/webgl/renderbuffer-initialization-expected.txt:
  • fast/canvas/webgl/renderbuffer-initialization.html:
  • fast/canvas/webgl/resources/webgl-test-utils.js: Added. (WebGLTestUtils): (WebGLTestUtils.):
  • fast/canvas/webgl/resources/webgl-test.js: (initNonKhronosFramework): (nonKhronosFrameworkNotifyDone):
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
  • fast/canvas/webgl/tex-image-and-uniform-binding-bugs-expected.txt:
  • fast/canvas/webgl/tex-image-and-uniform-binding-bugs.html:
  • fast/canvas/webgl/tex-image-with-format-and-type-expected.txt:
  • fast/canvas/webgl/tex-image-with-format-and-type.html:
  • fast/canvas/webgl/tex-sub-image-2d-expected.txt:
  • fast/canvas/webgl/tex-sub-image-2d.html:
  • fast/canvas/webgl/texture-active-bind.html:
  • fast/canvas/webgl/texture-complete.html:
  • fast/canvas/webgl/texture-npot-expected.txt:
  • fast/canvas/webgl/texture-npot.html:
  • fast/canvas/webgl/texture-transparent-pixels-initialized-expected.txt:
  • fast/canvas/webgl/texture-transparent-pixels-initialized.html:
  • fast/canvas/webgl/triangle-expected.txt:
  • fast/canvas/webgl/triangle.html:
  • fast/canvas/webgl/uniform-location-expected.txt:
  • fast/canvas/webgl/uniform-location.html:
  • fast/canvas/webgl/viewport-unchanged-upon-resize-expected.txt:
  • fast/canvas/webgl/viewport-unchanged-upon-resize.html:
11:54 Changeset [63443] by ojan@chromium.org

2010-07-15 Ojan Vafai <ojan@chromium.org>

Unreviewed.

[chromium] Cleanup more fallout from r63403.

  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/fast/tokenizer/external-script-document-write_2-expected.txt:
  • platform/chromium-mac/fast/tokenizer/script_extra_close-expected.txt:
  • platform/chromium-mac/html5lib/runner-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/video-aspect-ratio-expected.txt: Removed.
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
11:39 Changeset [63442] by andersca@apple.com

WebKitTestRunner goes off the deep end, spinning in a dispatch queue thread
https://bugs.webkit.org/show_bug.cgi?id=42355

Reviewed by Darin Adler.

Sometimes, when receiving a message whose size is very close to the inlineMessageMaxSize,
mach_msg would return with MACH_RCV_TOO_LARGE. In debug builds we would assert, but in release
builds we would just bail and the receiveSourceEventHandler would be run again shortly since we didn't
actually pull the message off the mach message queue.

Fix this by setting the receive source buffer size to include the maximum message trailer size, which
mach_msg requires. Also, handle mach_msg returning MACH_RCV_TOO_LARGE (even though in theory it would never happen
now that the receivedBufferSize always includes the maximum message trailer size.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::receiveSourceEventHandler):
Use a Vector with inline data instead of a char array. This way we can resize the Vector if the message received
is too big.

11:39 Changeset [63441] by ojan@chromium.org

2010-07-15 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] Rebaseline chromium-win tests after r63403
https://bugs.webkit.org/show_bug.cgi?id=42388

  • platform/chromium-win/editing/selection/drag-in-iframe-expected.txt:
  • platform/chromium-win/fast/css/text-align-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/chromium-win/fast/replaced/border-radius-clip-expected.txt:
  • platform/chromium-win/html5lib/runner-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-replaces-poster-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium-win/plugins/netscape-dom-access-expected.txt:
11:37 Changeset [63440] by commit-queue@webkit.org

2010-07-15 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

WebKitAPI additions to support inspecting application caches.
https://bugs.webkit.org/show_bug.cgi?id=41993

  • public/WebApplicationCacheHost.h: (WebKit::WebApplicationCacheHost::CacheInfo::CacheInfo): (WebKit::WebApplicationCacheHost::ResourceInfo::ResourceInfo): (WebKit::WebApplicationCacheHost::getAssociatedCacheInfo): (WebKit::WebApplicationCacheHost::getResourceList): (WebKit::WebApplicationCacheHost::deleteAssociatedCacheGroup):
  • public/WebApplicationCacheHostClient.h: (WebKit::WebApplicationCacheHostClient::didChangeCacheAssociation):
  • src/ApplicationCacheHostInternal.h: (WebCore::ApplicationCacheHostInternal::didChangeCacheAssociation):
11:19 Changeset [63439] by andersca@apple.com

Send JavaScript stream data to plug-ins
https://bugs.webkit.org/show_bug.cgi?id=42384

Reviewed by Darin Adler.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NPP_WriteReady):
(WebKit::NetscapePlugin::NPP_Write):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add NPP_ wrappers.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::NetscapePluginStream):
Initialize m_deliveryDataTimer and m_stopstreamWhenDoneDelivering.

(WebKit::NetscapePluginStream::sendJavaScriptStream):
Call deliverData and stop.

(WebKit::NetscapePluginStream::deliverData):
Add the data to m_deliveryData and call deliverDataToPlugin.

(WebKit::NetscapePluginStream::deliverDataToPlugin):
Deliver the data in m_deliveryData to the plug-in. Call NPP_WriteReady to see how much
data the plug-in can handle right now. If the plug-in returns zero or a negative value, delay the
delivery using the delivery data timer. Otherwise, call NPP_Write in chunks until all the data has been
delivered, then stop the stream if needed.

(WebKit::NetscapePluginStream::stop):
If the reason for stopping the stream is that it's finished and the plug-in hasn't processed all the data,
don't close the stream now. Instead, set m_stopStreamWhenDoneDelivering to true which will cause the stream to be
closed once all data has been delivered.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:

Add member functions and member variables.

10:56 Changeset [63438] by bfulgham@webkit.org

Patch for https://bugs.webkit.org/show_bug.cgi?id=42299
Correct WinCairo build for new WebKit2 project structure.

Reviewed by Steve Falkenburg.

WebKit/win:

  • WebKit.vcproj/WebKit.sln:

WebKit2:

  • win/WebKit2Apple.vsprops: Put WebKit2.def here.
  • win/WebKit2CFLite.def: Added CFLite version of def file.
  • win/WebKit2CFLite.vsprops: Add new WebKit2CFLite.def here.
  • win/WebKit2Common.vsprops: Remove WebKit2.def definition as WinCairo and Apple need different versions of this.
  • win/WebKit2WebProcess.vcproj: Add a new Debug_Cairo target for the WebKit2WebProcess project.
10:15 Changeset [63437] by kbr@google.com

2010-07-15 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Rename read-pixels and invalidPassedParams tests to match Khronos repo
https://bugs.webkit.org/show_bug.cgi?id=42335

  • fast/canvas/webgl/invalid-passed-params-expected.txt: Copied from LayoutTests/fast/canvas/webgl/invalidPassedParams-expected.txt.
  • fast/canvas/webgl/invalid-passed-params.html: Copied from LayoutTests/fast/canvas/webgl/invalidPassedParams.html.
  • fast/canvas/webgl/invalidPassedParams-expected.txt: Removed.
  • fast/canvas/webgl/invalidPassedParams.html: Removed.
  • fast/canvas/webgl/read-pixels-expected.txt: Removed.
  • fast/canvas/webgl/read-pixels-pack-alignment-expected.txt: Copied from LayoutTests/fast/canvas/webgl/read-pixels-expected.txt.
  • fast/canvas/webgl/read-pixels-pack-alignment.html: Copied from LayoutTests/fast/canvas/webgl/read-pixels.html.
  • fast/canvas/webgl/read-pixels.html: Removed.
10:01 Changeset [63436] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Update some more baselines for Eric's text node coalescing patch. I
think these bots were behind and he didn't see the results before he
went to sleep.

  • platform/win/editing/selection/drag-text-delay-expected.txt:
  • platform/win/fast/css/resize-corner-tracking-expected.txt:
  • platform/win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/win/fast/forms/basic-textareas-expected.txt:
  • platform/win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/win/fast/forms/textarea-placeholder-set-value-expected.txt:
  • platform/win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/win/fast/forms/textarea-width-expected.txt:
  • platform/win/fast/images/favicon-as-image-expected.txt:
  • platform/win/fast/layers/video-layer-expected.txt:
  • platform/win/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/win/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/win/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/win/fast/ruby/ruby-length-expected.txt:
  • platform/win/media/video-display-toggle-expected.txt:
09:56 Changeset [63435] by darin@apple.com

More fixes for the text node coalescing.

Some of this was done directly based on buildbot output, but other cases
are speculative. The patch was much bigger before Adam landed almost all the
same fixes while I was committing ;-). I did not land similar chromium fixes
because I don't know how to interpret the different buildbot output format.

  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-strict-expected.txt:
  • platform/win/media/controls-styling-expected.txt:
  • platform/win/media/video-no-audio-expected.txt:
09:53 Changeset [63434] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Unreviewed.

Update some more baselines for Eric's text node coalescing patch. I
think these bots were behind and he didn't see the results before he
went to sleep.

  • platform/mac-tiger/media/controls-after-reload-expected.txt:
  • platform/mac-tiger/media/controls-strict-expected.txt:
  • platform/mac-tiger/media/controls-styling-expected.txt:
  • platform/mac-tiger/media/video-display-toggle-expected.txt:
  • platform/mac-tiger/media/video-no-audio-expected.txt:
09:51 Changeset [63433] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Unreviewed.

Update some more baselines for Eric's text node coalescing patch. I
think these bots were behind and he didn't see the results before he
went to sleep.

  • platform/mac-leopard/media/controls-after-reload-expected.txt:
  • platform/mac-leopard/media/controls-strict-expected.txt:
  • platform/mac-leopard/media/controls-styling-expected.txt:
  • platform/mac-leopard/media/video-display-toggle-expected.txt:
  • platform/mac-leopard/media/video-no-audio-expected.txt:
09:49 Changeset [63432] by ojan@chromium.org

2010-07-15 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] Rebaseline some tests
https://bugs.webkit.org/show_bug.cgi?id=42382

Chromium linux expected results needed after http://trac.webkit.org/changeset/63403.

  • platform/chromium-linux/editing/pasteboard/4641033-expected.txt:
  • platform/chromium-linux/editing/pasteboard/select-element-1-expected.txt:
  • platform/chromium-linux/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/chromium-linux/fast/css/continuationCrash-expected.txt:
  • platform/chromium-linux/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/chromium-linux/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/chromium-linux/fast/forms/003-expected.txt:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/button-default-title-expected.txt:
  • platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-linux/fast/forms/formmove3-expected.txt:
  • platform/chromium-linux/fast/forms/listbox-width-change-expected.txt:
  • platform/chromium-linux/fast/forms/option-script-expected.txt:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.txt:
  • platform/chromium-linux/fast/forms/select-empty-option-height-expected.txt:
  • platform/chromium-linux/fast/forms/select-item-background-clip-expected.txt:
  • platform/chromium-linux/fast/forms/targeted-frame-submission-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/table/append-cells2-expected.txt:
  • platform/chromium-linux/fast/table/remove-td-display-none-expected.txt:
  • platform/chromium-linux/fast/text/international/001-expected.txt:
  • platform/chromium-linux/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/chromium-linux/fast/text/updateNewFont-expected.txt:
  • platform/chromium-linux/fonts/fantasy-expected.txt:
  • platform/chromium-linux/http/tests/multipart/invalid-image-data-expected.txt:
  • platform/chromium-linux/http/tests/navigation/anchor-frames-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.txt:
  • platform/chromium-linux/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
09:48 Changeset [63431] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Unreviewed.

Update the port names to be more specific. Before this patch,
port-specific results for Mac would end up in the wrong place.

  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
09:40 Changeset [63430] by abarth@webkit.org

2010-07-15 Adam Barth <abarth@webkit.org>

Unreviewed.

Update some more baselines for Eric's text node coalescing patch. I
think these bots were behind and he didn't see the results before he
went to sleep.

  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/mac/plugins/netscape-dom-access-expected.txt:
08:44 Changeset [63429] by andreas.kling@nokia.com

2010-07-15 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Remove an unused variable in BitmapImage::draw()

  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw): Remove selfSize.
08:38 Changeset [63428] by yurys@chromium.org

2010-07-15 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] Rebaseline some tests
https://bugs.webkit.org/show_bug.cgi?id=42357

  • platform/chromium-win/editing/deleting/5168598-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-023-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-024-expected.txt:
  • platform/chromium-win/editing/deleting/delete-line-013-expected.txt:
  • platform/chromium-win/editing/deleting/delete-line-014-expected.txt:
  • platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.txt:
  • platform/chromium-win/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.txt:
  • platform/chromium-win/editing/pasteboard/4641033-expected.txt:
  • platform/chromium-win/editing/pasteboard/5028447-expected.txt:
  • platform/chromium-win/editing/pasteboard/drag-drop-dead-frame-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-010-expected.txt:
  • platform/chromium-win/editing/pasteboard/select-element-1-expected.txt:
  • platform/chromium-win/editing/selection/5354455-2-expected.txt:
  • platform/chromium-win/editing/selection/doubleclick-crash-expected.txt:
  • platform/chromium-win/editing/selection/drag-text-delay-expected.txt:
  • platform/chromium-win/editing/selection/expanding-selections2-expected.txt:
  • platform/chromium-win/editing/selection/extend-by-character-006-expected.txt:
  • platform/chromium-win/editing/selection/focus_editable_html-expected.txt:
  • platform/chromium-win/editing/selection/mixed-editability-1-expected.txt:
  • platform/chromium-win/editing/selection/move-by-sentence-001-expected.txt:
  • platform/chromium-win/editing/selection/select-all-005-expected.txt:
  • platform/chromium-win/editing/selection/selection-actions-expected.txt:
  • platform/chromium-win/editing/style/apple-style-editable-mix-expected.txt:
  • platform/chromium-win/editing/style/font-family-with-space-expected.txt:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.txt:
  • platform/chromium-win/fast/block/float/001-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/037-expected.txt:
  • platform/chromium-win/fast/block/margin-collapse/038-expected.txt:
  • platform/chromium-win/fast/block/positioning/055-expected.txt:
  • platform/chromium-win/fast/block/positioning/auto/005-expected.txt:
  • platform/chromium-win/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
  • platform/chromium-win/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/chromium-win/fast/block/positioning/relative-overflow-replaced-expected.txt:
  • platform/chromium-win/fast/block/positioning/relative-overflow-replaced-float-expected.txt:
  • platform/chromium-win/fast/block/positioning/window-height-change-expected.txt:
  • platform/chromium-win/fast/borders/border-image-01-expected.txt:
  • platform/chromium-win/fast/borders/border-image-border-radius-expected.txt:
  • platform/chromium-win/fast/borders/border-image-rotate-transform-expected.txt:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.txt:
  • platform/chromium-win/fast/borders/svg-as-border-image-2-expected.txt:
  • platform/chromium-win/fast/borders/svg-as-border-image-expected.txt:
  • platform/chromium-win/fast/canvas/arc360-expected.txt:
  • platform/chromium-win/fast/canvas/canvas-before-css-expected.txt:
  • platform/chromium-win/fast/canvas/drawImage-with-globalAlpha-expected.txt:
  • platform/chromium-win/fast/canvas/fill-stroke-clip-reset-path-expected.txt:
  • platform/chromium-win/fast/canvas/fillrect-gradient-zero-stops-expected.txt:
  • platform/chromium-win/fast/canvas/shadow-offset-1-expected.txt:
  • platform/chromium-win/fast/canvas/shadow-offset-2-expected.txt:
  • platform/chromium-win/fast/canvas/shadow-offset-3-expected.txt:
  • platform/chromium-win/fast/canvas/shadow-offset-4-expected.txt:
  • platform/chromium-win/fast/canvas/shadow-offset-5-expected.txt:
  • platform/chromium-win/fast/canvas/shadow-offset-6-expected.txt:
  • platform/chromium-win/fast/canvas/shadow-offset-7-expected.txt:
  • platform/chromium-win/fast/clip/016-expected.txt:
  • platform/chromium-win/fast/clip/outline-overflowClip-expected.txt:
  • platform/chromium-win/fast/css-generated-content/001-expected.txt:
  • platform/chromium-win/fast/css-generated-content/013-expected.txt:
  • platform/chromium-win/fast/css-generated-content/visibleContentHiddenParent-expected.txt:
  • platform/chromium-win/fast/css/MarqueeLayoutTest-expected.txt:
  • platform/chromium-win/fast/css/ZeroOpacityLayers-expected.txt:
  • platform/chromium-win/fast/css/ZeroOpacityLayers2-expected.txt:
  • platform/chromium-win/fast/css/background-image-with-baseurl-expected.txt:
  • platform/chromium-win/fast/css/beforeSelectorOnCodeElement-expected.txt:
  • platform/chromium-win/fast/css/continuationCrash-expected.txt:
  • platform/chromium-win/fast/css/css1_forward_compatible_parsing-expected.txt:
  • platform/chromium-win/fast/css/empty-generated-content-expected.txt:
  • platform/chromium-win/fast/css/font-face-default-font-expected.txt:
  • platform/chromium-win/fast/css/font-face-in-media-rule-expected.txt:
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt:
  • platform/chromium-win/fast/css/import_with_baseurl-expected.txt:
  • platform/chromium-win/fast/css/invalidation-errors-2-expected.txt:
  • platform/chromium-win/fast/css/invalidation-errors-expected.txt:
  • platform/chromium-win/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/chromium-win/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
  • platform/chromium-win/fast/css/rem-units-on-root-expected.txt:
  • platform/chromium-win/fast/css/resize-corner-tracking-expected.txt:
  • platform/chromium-win/fast/css/variables/inline-style-test-expected.txt:
  • platform/chromium-win/fast/css/vertical-align-lengths-expected.txt:
  • platform/chromium-win/fast/css/word-space-extra-expected.txt:
  • platform/chromium-win/fast/dom/Element/null-offset-parent-expected.txt:
  • platform/chromium-win/fast/dom/HTMLElement/bdo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLHeadElement/textInHead1-expected.txt:
  • platform/chromium-win/fast/dom/HTMLHeadElement/textInHead2-expected.txt:
  • platform/chromium-win/fast/dom/HTMLHeadElement/textInHead3-expected.txt:
  • platform/chromium-win/fast/dom/HTMLHeadElement/textInHead4-expected.txt:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/chromium-win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/chromium-win/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/chromium-win/fast/dom/comment-not-documentElement-expected.txt:
  • platform/chromium-win/fast/dom/jsDevicePixelRatio-expected.txt:
  • platform/chromium-win/fast/dynamic/008-expected.txt:
  • platform/chromium-win/fast/dynamic/011-expected.txt:
  • platform/chromium-win/fast/dynamic/anchor-lock-expected.txt:
  • platform/chromium-win/fast/dynamic/link-href-change-expected.txt:
  • platform/chromium-win/fast/dynamic/outerHTML-img-expected.txt:
  • platform/chromium-win/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/chromium-win/fast/dynamic/window-scrollbars-test-expected.txt:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-win/fast/encoding/xmacroman-encoding-test-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/events/event-listener-on-link-expected.txt:
  • platform/chromium-win/fast/events/focusingUnloadedFrame-expected.txt:
  • platform/chromium-win/fast/events/reveal-link-when-focused-expected.txt:
  • platform/chromium-win/fast/flexbox/025-expected.txt:
  • platform/chromium-win/fast/forms/003-expected.txt:
  • platform/chromium-win/fast/forms/basic-textareas-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/button-default-title-expected.txt:
  • platform/chromium-win/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/chromium-win/fast/forms/checkbox-radio-onchange-expected.txt:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-win/fast/forms/fieldset-align-expected.txt:
  • platform/chromium-win/fast/forms/fieldset-with-float-expected.txt:
  • platform/chromium-win/fast/forms/formmove2-expected.txt:
  • platform/chromium-win/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/fast/forms/image-border-expected.txt:
  • platform/chromium-win/fast/forms/indeterminate-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-disabled-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-field-text-truncated-expected.txt:
  • platform/chromium-win/fast/forms/input-first-letter-expected.txt:
  • platform/chromium-win/fast/forms/input-no-renderer-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/chromium-win/fast/forms/input-spaces-expected.txt:
  • platform/chromium-win/fast/forms/input-type-text-min-width-expected.txt:
  • platform/chromium-win/fast/forms/listbox-width-change-expected.txt:
  • platform/chromium-win/fast/forms/option-script-expected.txt:
  • platform/chromium-win/fast/forms/option-strip-whitespace-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-set-value-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.txt:
  • platform/chromium-win/fast/forms/radio-nested-labels-expected.txt:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/select-change-listbox-size-expected.txt:
  • platform/chromium-win/fast/forms/select-empty-option-height-expected.txt:
  • platform/chromium-win/fast/forms/select-item-background-clip-expected.txt:
  • platform/chromium-win/fast/forms/slider-thumb-stylability-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/targeted-frame-submission-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-set-value-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium-win/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-win/fast/forms/thumbslider-crash-expected.txt:
  • platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/chromium-win/fast/frames/001-expected.txt:
  • platform/chromium-win/fast/frames/frame-element-name-expected.txt:
  • platform/chromium-win/fast/frames/frameElement-iframe-expected.txt:
  • platform/chromium-win/fast/frames/viewsource-attribute-expected.txt:
  • platform/chromium-win/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/chromium-win/fast/html/keygen-expected.txt:
  • platform/chromium-win/fast/html/marquee-scroll-expected.txt:
  • platform/chromium-win/fast/images/animated-gif-with-offsets-expected.txt:
  • platform/chromium-win/fast/images/animated-svg-as-image-expected.txt:
  • platform/chromium-win/fast/images/favicon-as-image-expected.txt:
  • platform/chromium-win/fast/images/icon-decoding-expected.txt:
  • platform/chromium-win/fast/images/image-in-map-expected.txt:
  • platform/chromium-win/fast/inline-block/001-expected.txt:
  • platform/chromium-win/fast/inline-block/003-expected.txt:
  • platform/chromium-win/fast/inline-block/006-expected.txt:
  • platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.txt:
  • platform/chromium-win/fast/inline-block/tricky-baseline-expected.txt:
  • platform/chromium-win/fast/inline/drawStyledEmptyInlines-expected.txt:
  • platform/chromium-win/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
  • platform/chromium-win/fast/inline/long-wrapped-line-expected.txt:
  • platform/chromium-win/fast/inline/percentage-margins-expected.txt:
  • platform/chromium-win/fast/inline/positionedLifetime-expected.txt:
  • platform/chromium-win/fast/invalid/005-expected.txt:
  • platform/chromium-win/fast/invalid/006-expected.txt:
  • platform/chromium-win/fast/invalid/021-expected.txt:
  • platform/chromium-win/fast/invalid/missing-dl-end-tag-expected.txt:
  • platform/chromium-win/fast/invalid/missing-dt-end-tag-expected.txt:
  • platform/chromium-win/fast/layers/remove-only-this-layer-update-expected.txt:
  • platform/chromium-win/fast/lists/markers-in-selection-expected.txt:
  • platform/chromium-win/fast/loader/start-load-in-unload-expected.txt:
  • platform/chromium-win/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/chromium-win/fast/multicol/nested-columns-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/overflow/line-clamp-expected.txt:
  • platform/chromium-win/fast/overflow/scrollRevealButton-expected.txt:
  • platform/chromium-win/fast/parser/comment-in-style-expected.txt:
  • platform/chromium-win/fast/parser/entity-comment-in-style-expected.txt:
  • platform/chromium-win/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/chromium-win/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
  • platform/chromium-win/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/chromium-win/fast/parser/parseCommentsInTitles-expected.txt:
  • platform/chromium-win/fast/parser/remove-block-in-residual-style-expected.txt:
  • platform/chromium-win/fast/parser/title-error-test-expected.txt:
  • platform/chromium-win/fast/repaint/4774354-expected.txt:
  • platform/chromium-win/fast/repaint/button-spurious-layout-hint-expected.txt:
  • platform/chromium-win/fast/repaint/continuation-after-outline-expected.txt:
  • platform/chromium-win/fast/repaint/inline-block-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/chromium-win/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/chromium-win/fast/repaint/rel-positioned-inline-with-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
  • platform/chromium-win/fast/repaint/selected-replaced-expected.txt:
  • platform/chromium-win/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/chromium-win/fast/replaced/image-resize-width-expected.txt:
  • platform/chromium-win/fast/replaced/maxheight-percent-expected.txt:
  • platform/chromium-win/fast/replaced/maxheight-pxs-expected.txt:
  • platform/chromium-win/fast/replaced/maxwidth-percent-expected.txt:
  • platform/chromium-win/fast/replaced/maxwidth-pxs-expected.txt:
  • platform/chromium-win/fast/replaced/minheight-percent-expected.txt:
  • platform/chromium-win/fast/replaced/minheight-pxs-expected.txt:
  • platform/chromium-win/fast/replaced/minwidth-percent-expected.txt:
  • platform/chromium-win/fast/replaced/minwidth-pxs-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-empty-rt-expected.txt:
  • platform/chromium-win/fast/ruby/ruby-length-expected.txt:
  • platform/chromium-win/fast/table/012-expected.txt:
  • platform/chromium-win/fast/table/018-expected.txt:
  • platform/chromium-win/fast/table/append-cells2-expected.txt:
  • platform/chromium-win/fast/table/cellindex-expected.txt:
  • platform/chromium-win/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
  • platform/chromium-win/fast/table/nobr-expected.txt:
  • platform/chromium-win/fast/table/remove-td-display-none-expected.txt:
  • platform/chromium-win/fast/text/basic/009-expected.txt:
  • platform/chromium-win/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/chromium-win/fast/text/selection-hard-linebreak-expected.txt:
  • platform/chromium-win/fast/text/should-use-atsui-expected.txt:
  • platform/chromium-win/fast/text/updateNewFont-expected.txt:
  • platform/chromium-win/fast/text/whitespace/020-expected.txt:
  • platform/chromium-win/fast/tokenizer/external-script-document-write_2-expected.txt:
  • platform/chromium-win/fast/tokenizer/script_extra_close-expected.txt:
  • platform/chromium-win/fast/transforms/identity-matrix-expected.txt:
  • platform/chromium-win/fonts/cursive-expected.txt:
  • platform/chromium-win/fonts/default-expected.txt:
  • platform/chromium-win/fonts/fantasy-expected.txt:
  • platform/chromium-win/fonts/monospace-expected.txt:
  • platform/chromium-win/fonts/sans-serif-expected.txt:
  • platform/chromium-win/fonts/serif-expected.txt:
  • platform/chromium-win/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/chromium-win/http/tests/misc/iframe404-expected.txt:
  • platform/chromium-win/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/chromium-win/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/chromium-win/http/tests/navigation/anchor-frames-expected.txt:
  • platform/chromium-win/http/tests/navigation/error404-frames-expected.txt:
  • platform/chromium-win/http/tests/navigation/error404-subframeload-expected.txt:
  • platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/chromium-win/http/tests/navigation/post-basic-expected.txt:
  • platform/chromium-win/http/tests/navigation/post-frames-expected.txt:
  • platform/chromium-win/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/chromium-win/http/tests/navigation/postredirect-frames-expected.txt:
  • platform/chromium-win/http/tests/navigation/postredirect-goback1-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/video-aspect-ratio-expected.txt:
  • platform/chromium-win/svg/custom/getsvgdocument-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1224-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug13526-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2267-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug23299-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2757-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug29157-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2947-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug3037-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug40828-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug42187-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug5835-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug93363-expected.txt:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_align_left-expected.txt:
  • platform/chromium-win/tables/mozilla/marvin/tables_align_right-expected.txt:
  • platform/chromium-win/tables/mozilla/other/move_row-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1262-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7113-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
08:23 Changeset [63427] by yurys@chromium.org

2010-07-15 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: pass all parameters to WebInspector.addConsoleMessage as a single payload object
https://bugs.webkit.org/show_bug.cgi?id=42345

This refactoring is covered by existing console tests.

  • bindings/js/ScriptArray.cpp: (WebCore::ScriptArray::set):
  • bindings/js/ScriptArray.h: (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::jsArray):
  • bindings/v8/ScriptArray.cpp: (WebCore::ScriptArray::set):
  • bindings/v8/ScriptArray.h: (WebCore::ScriptArray::ScriptArray): (WebCore::ScriptArray::~ScriptArray):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addConsoleMessage):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.createTextMessage): (WebInspector.ConsoleCommandResult):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.generateStylesheet):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName.myCallback): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._checkWarning):
  • inspector/front-end/inspector.js: (WebInspector.updateConsoleMessageExpiredCount): (WebInspector.addConsoleMessage): (WebInspector.log.logMessage): (WebInspector.log):
08:15 Changeset [63426] by tonyg@chromium.org

2010-07-14 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

Backfill DNS and connect times rather than exposing hard zeros
https://bugs.webkit.org/show_bug.cgi?id=42303

There are several cases where domain lookup is not performed and/or a new connection is not established. Previously in these cases, we exposed a "0" to the API. Now, we instead "backfill" with the most recent mark's time.

Also, previously, I was using the ResourceLoadTiming API incorrectly. Each mark is an integer representing offset in milliseconds from requestTime. So all values need to be added to requestTime.

No new test because existing test expectations are set to FAIL because disable disabled by default. The expected results of existings tests change as expected when enabled.

  • page/Timing.cpp: (WebCore::toIntegerMilliseconds): Move to file static instead of class static because it might generate more optimal code. Also, instead of converting negative doubles to zero, ASSERT that they are >= 0. This is because we no longer expose hard zeros for DNS and connect, so we want to be sure that the -1s returned by the API are properly handled. (WebCore::Timing::domainLookupStart): (WebCore::Timing::domainLookupEnd): (WebCore::Timing::connectStart): (WebCore::Timing::connectEnd): (WebCore::Timing::requestStart): (WebCore::Timing::requestEnd): (WebCore::Timing::responseStart):
  • page/Timing.h:
08:03 Changeset [63425] by pfeldman@chromium.org

2010-07-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: differentiate between blocking and connecting timers.

https://bugs.webkit.org/show_bug.cgi?id=42372

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::updateResponse): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::buildObjectForTiming):
  • inspector/InspectorResource.h:
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get cached): (WebInspector.Resource.prototype.set cached):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover): (WebInspector.ResourceGraph): (WebInspector.ResourceGraph.prototype.refresh): (WebInspector.ResourceGraph.prototype._cachedChanged):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/FrameLoader.h:
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::connectionReused): (WebCore::ResourceResponseBase::setConnectionID):
  • platform/network/ResourceResponseBase.h:
07:36 Changeset [63424] by ager@chromium.org

2010-07-15 Mads Ager <ager@chromium.org>

Reviewed by Jeremy Orlow.

Chromium test expectations update after ES5 Object.freeze and Object.seal implementation.
https://bugs.webkit.org/show_bug.cgi?id=42369

Add Object.freeze and Object.seal tests as expected to fail to the
chromium test expectations file. The tests actually pass with V8
but the text expectations expect them to fail because JSC has not
yet implemented freeze and seal.

Not adding new chromium baselines because the baselines would
contain little extra information (because the text files basically
just contains either PASS or FAIL with little extra information).

  • platform/chromium/test_expectations.txt:
07:10 Changeset [63423] by zherczeg@webkit.org

Refactoring some parts of the lexer
https://bugs.webkit.org/show_bug.cgi?id=41845

Reviewed by Darin Adler.

This patch is a precursor of refactoring the identifier
parsing, which currently slows down the lexer, and not
ready for landing. This patch contains those sources,
which does not slow down the lexer (mainly style changes).

SunSpider: no change (529.4ms to 528.7ms)
--parse-only: no change (31.0ms to 31.2ms)

  • parser/Lexer.cpp:

(JSC::isIdentStart): using typesOfASCIICharacters to determine

whether the current character is in identifier start

(JSC::isIdentPart): using typesOfASCIICharacters to determine

whether the current character is in identifier part

(JSC::Lexer::parseString): style fix
(JSC::Lexer::lex): removing the else after the main which

which reduces code duplication

05:53 Changeset [63422] by morrita@google.com

2010-07-15 MORITA Hajime <morrita@google.com>

Text layout is wrong with a SVG Font that lacks <missing-glyph> element
https://bugs.webkit.org/show_bug.cgi?id=42352

  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.checksum: Added.
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt: Added.
  • svg/custom/svg-fonts-without-missing-glyph.xhtml: Added.

2010-07-15 MORITA Hajime <morrita@google.com>

Text layout is wrong with a SVG Font that lacks <missing-glyph> element
https://bugs.webkit.org/show_bug.cgi?id=42352

floatWidthOfSubStringUsingSVGFont() calculated a wrong value for a
sub-run, and a fallback to system font triggers such a computation.
This change made floatWidthOfSubStringUsingSVGFont() to deal with
sub-runs.

Test: svg/custom/svg-fonts-without-missing-glyph.xhtml

  • svg/SVGFont.cpp: (WebCore::floatWidthOfSubStringUsingSVGFont):
05:09 Changeset [63421] by zimmermann@webkit.org

2010-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Cycle detection needs to include shadow tree
https://bugs.webkit.org/show_bug.cgi?id=42360

Search for cycles in shadow tree fragments as well. Extended the svg/custom/recursion-* tests. No more crashes in any of them.

  • rendering/RenderSVGResourceContainer.h: (WebCore::RenderSVGResourceContainer::containsCyclicReference):
  • rendering/RenderSVGShadowTreeRootContainer.cpp: Implemented here, not inline, so that clients don't need to include SVGShadowTreeElements.h (WebCore::RenderSVGShadowTreeRootContainer::rootElement): Expose helper function, that returns the shadow tree root element as Node*.
  • rendering/RenderSVGShadowTreeRootContainer.h:

2010-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Cycle detection needs to include shadow tree
https://bugs.webkit.org/show_bug.cgi?id=42360

Extend recursion tests to cover indirect recursion through <use> elements.

  • platform/mac/svg/custom/recursive-clippath-expected.checksum:
  • platform/mac/svg/custom/recursive-clippath-expected.png:
  • platform/mac/svg/custom/recursive-clippath-expected.txt:
  • platform/mac/svg/custom/recursive-mask-expected.txt:
  • platform/mac/svg/custom/recursive-pattern-expected.checksum:
  • platform/mac/svg/custom/recursive-pattern-expected.png:
  • platform/mac/svg/custom/recursive-pattern-expected.txt:
  • svg/custom/recursive-clippath.svg:
  • svg/custom/recursive-mask.svg:
  • svg/custom/recursive-pattern.svg:
03:15 Changeset [63420] by zimmermann@webkit.org

2010-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

clipPath is missing cycle detection
https://bugs.webkit.org/show_bug.cgi?id=42350

Detect cyclic clipper resources, and ignore them on rendering. Early exit in applyResource just like the pattern/mask resources do.

  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::applyResource): (WebCore::RenderSVGResourceClipper::hitTestClipContent): (WebCore::RenderSVGResourceClipper::childElementReferencesResource):
  • rendering/RenderSVGResourceClipper.h:

2010-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

clipPath is missing cycle detection
https://bugs.webkit.org/show_bug.cgi?id=42350

Change clipPath behaviour: clipPath children that reference the clipPath they define, are not ignored.
Updated tests accordingly. Raised SVG WG question, as the handling is inconsistent between Opera/FF & WebKit.

  • platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.txt:
  • platform/mac/svg/custom/recursive-clippath-expected.checksum:
  • platform/mac/svg/custom/recursive-clippath-expected.png:
  • platform/mac/svg/custom/recursive-clippath-expected.txt:
  • svg/clip-path/clip-path-recursive-call-by-child.svg:
  • svg/custom/recursive-clippath.svg:
02:55 Changeset [63419] by mrowe@apple.com

Fix a leak of Vector instances seen on the build bot.

Reviewed by Maciej Stachowiak.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawBoxSideFromPath): Don't unnecessarily heap allocate then leak the DashArray.

02:45 Changeset [63418] by yurys@chromium.org

2010-07-15 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Fix mac compilation failure
https://bugs.webkit.org/show_bug.cgi?id=42344

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex): (WebKit::AutoFillPopupMenuClient::canRemoveSuggestionAtIndex):
02:16 Changeset [63417] by mrowe@apple.com

Update the sorting in the Xcode project files.

JavaScriptCore:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
01:34 Changeset [63416] by zimmermann@webkit.org

2010-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Extend svg/custom/recursive-gradient.svg with the same recursion tests patterns have.

  • platform/mac/svg/custom/recursive-gradient-expected.checksum:
  • platform/mac/svg/custom/recursive-gradient-expected.png:
  • platform/mac/svg/custom/recursive-gradient-expected.txt:
  • svg/custom/recursive-gradient.svg:
01:25 Changeset [63415] by zimmermann@webkit.org

2010-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

SVG patterns and masks should not be able to reference themselves
https://bugs.webkit.org/show_bug.cgi?id=32171

Pattern still had an issue, when using constructs like:
<pattern id="pattern1" xlink:href="#pattern2"/>
<pattern id="pattern2"><rect fill="url(#pattern1)"/></pattern>

Extended test svg/custom/recursive-pattern.svg to cover this situation.

  • rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): Don't perform the cycle check against node()... (WebCore::RenderSVGResourcePattern::createTileImage): .. but against the "patternContentElement" which respect the xlink:href chaining.

2010-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

SVG patterns and masks should not be able to reference themselves
https://bugs.webkit.org/show_bug.cgi?id=32171

Pattern still had an issue, when using constructs like:
<pattern id="pattern1" xlink:href="#pattern2"/>
<pattern id="pattern2"><rect fill="url(#pattern1)"/></pattern>

  • platform/mac/svg/custom/recursive-pattern-expected.checksum:
  • platform/mac/svg/custom/recursive-pattern-expected.png:
  • platform/mac/svg/custom/recursive-pattern-expected.txt:
  • svg/custom/recursive-pattern.svg: Add new subtest.
01:01 Changeset [63414] by zimmermann@webkit.org

2010-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Forgot to reset pixel test result to the old result after the partial revert.

  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
00:34 Changeset [63413] by zimmermann@webkit.org

2010-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Barth.

Pixel test failure in moving-shadow-on-path.html and moving-shadow-on-container.html
https://bugs.webkit.org/show_bug.cgi?id=42249

Partly revert <http://trac.webkit.org/changeset/63307>. The RenderSVGRoot change caused a pixel test regression in two fast/repaint tests.

  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): Include selfNeedsLayout() check in LayoutStateRepainter argument.

2010-07-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Barth.

Pixel test failure in moving-shadow-on-path.html and moving-shadow-on-container.html
https://bugs.webkit.org/show_bug.cgi?id=42249

Update fast/repaint/moving-shadow-on-path.html result, which shows a slightly smaller repaint rect.

  • platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
00:22 Changeset [63412] by mjs@apple.com

Unreviewed, trivial error in previous commit.

Fix mistake in the last commit due to last minute change.

  • platform/mac-wk2/Skipped: change extensions from -diffs.txt to .html
00:05 Changeset [63411] by eric@webkit.org

2010-07-15 Eric Seidel <eric@webkit.org>

Unreviewed, just updating expectations.

  • html5lib/runner-expected.txt:
    • I think my changes got out of order with one another. The new results here are correct.
00:01 Changeset [63410] by eric@webkit.org

2010-07-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

WebKit needs a rebaselining tool (finally)
https://bugs.webkit.org/show_bug.cgi?id=42339

This is a very basic rebaselining tool. It's not
quite as fancy as chromium's as it will only handle
updating failing results. It cannot yet handle adding new
results, or updating results where the results should not
replace existing results.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py: Added.
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added.
Note: See TracTimeline for information about the timeline view.