Timeline


and

07/22/10:

23:47 Changeset [63953] by philn@webkit.org
  • 3 edits in trunk/LayoutTests

2010-07-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

media/video-duration-known-after-eos.html test is slow
https://bugs.webkit.org/show_bug.cgi?id=42809

Seek near the end of the media to speed the test up.

  • media/video-duration-known-after-eos-expected.txt:
  • media/video-duration-known-after-eos.html:
23:39 Changeset [63952] by loislo@chromium.org
  • 18 edits in trunk

2010-07-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: CodeGeneratorInspector was extended and now it can
generate InspectorBackedDispatcher's code. This dispatcher will
validate and dispatch incoming inspector commands only by native
code without using javaScript. That is necessary step for
RemoteDebugging support.
https://bugs.webkit.org/show_bug.cgi?id=42588

  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorBackendDispatcher):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument):

2010-07-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: CodeGeneratorInspector was extended and now it can
generate InspectorBackedDispatcher's code. This dispatcher will
validate and dispatch incoming inspector commands only by native
code without using javaScript. That is necessary step for
RemoteDebugging support.
https://bugs.webkit.org/show_bug.cgi?id=42588

  • src/ToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController):
  • src/WebDevToolsAgentImpl.h:
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl.prototype.callInspectorController_):
23:26 Changeset [63951] by hamaji@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-07-22 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed. Add expectations for Qt and Gtk.

Backslash is transcoded into yen sign even when non japanese font is specified
https://bugs.webkit.org/show_bug.cgi?id=39654

  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
  • platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
22:39 Changeset [63950] by hamaji@chromium.org
  • 10 edits
    4 adds in trunk

2010-07-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

Backslash is transcoded into yen sign even when non japanese font is specified
https://bugs.webkit.org/show_bug.cgi?id=39654

  • fast/text/backslash-to-yen-sign-euc.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.

2010-07-22 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

Backslash is transcoded into yen sign even when non japanese font is specified
https://bugs.webkit.org/show_bug.cgi?id=39654

Test: fast/text/backslash-to-yen-sign-euc.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Call FontDescriptor::setIsSpecifiedFont.
  • platform/graphics/Font.cpp: (WebCore::Font::Font):
  • platform/graphics/FontDescription.h: Added m_isSpecifiedFont and its accessors. (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::isSpecifiedFont): (WebCore::FontDescription::setIsSpecifiedFont): (WebCore::FontDescription::operator==):
  • platform/text/transcoder/FontTranscoder.cpp: (WebCore::FontTranscoder::converterType): Don't transcode backslashes if a font family is explicitly specified. (WebCore::FontTranscoder::convert): (WebCore::FontTranscoder::needsTranscoding):
  • platform/text/transcoder/FontTranscoder.h: Change the arguments from AtomicString fontFamily to Font.
  • rendering/RenderText.cpp: (WebCore::RenderText::updateNeedsTranscoding): (WebCore::RenderText::setTextInternal):
20:46 Changeset [63949] by darin@apple.com
  • 7 edits in trunk

Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42847

Reviewed by Sam Weinig.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: Removed WKBundleFrameCopyInnerText.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.
  • WebProcess/WebPage/WebFrame.cpp: Removed innerText.
  • WebProcess/WebPage/WebFrame.h: Ditto.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::operator<<): Replaced the WKStringToUTF8 function with
a set of overloaded stream operators.
(WTR::dumpPath): Changed to use ostringstream and return a string.
(WTR::propertyValue): Added.
(WTR::propertyObject): Added.
(WTR::propertyString): Added.
(WTR::numericWindowPropertyValue): Changed to call propertyValue.
(WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
since we now have suitable streaming functions.
(WTR::dumpFrameText): Use propertyObject and propertyString instead of
WKBundleFrameCopyInnerText.
(WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
since we now have suitable streaming functions.
(WTR::InjectedBundlePage::dump): Ditto.
(WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
(WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.

20:43 Changeset [63948] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Eeeep! r63947 hosed all non-x86 builds!

  • jit/JITStubs.h:
20:28 Changeset [63947] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

Bug 42818 - [Qt] REGRESSION(63348): jsc is broken
Speculative fix, need fastcall conventions on Qt/Win.

Reviewed by Oliver Hunt.

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
20:24 Changeset [63946] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-07-22 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Do more constant folding
https://bugs.webkit.org/show_bug.cgi?id=42867

Constant fold a few more operations. SunSpider says this is
a win but I suspect that's just code motion at play.

  • parser/ASTBuilder.h: (JSC::ASTBuilder::makeModNode): (JSC::ASTBuilder::makeURightShiftNode): (JSC::ASTBuilder::makeBitOrNode): (JSC::ASTBuilder::makeBitAndNode): (JSC::ASTBuilder::makeBitXOrNode): (JSC::ASTBuilder::makeBinaryNode):
20:20 Changeset [63945] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

Commit some changes missed by the commit-queue in r63944.

  • platform/win/BitmapInfo.h:

(WebCore::BitmapInfo::is16bit):
(WebCore::BitmapInfo::is32bit):
(WebCore::BitmapInfo::width):
(WebCore::BitmapInfo::height):
(WebCore::BitmapInfo::size):
(WebCore::BitmapInfo::paddedWidth):
(WebCore::BitmapInfo::numPixels):
(WebCore::BitmapInfo::paddedBytesPerLine):
(WebCore::BitmapInfo::bytesPerLine):

19:55 Changeset [63944] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-22 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Add additonal methods to BitmapInfo.
https://bugs.webkit.org/show_bug.cgi?id=42071

Added a parameter to create 16bit BitmapInfo and
some additional accessors for the WinCE port.

Set bmiHeader.biSize only at constructor.

  • platform/win/BitmapInfo.cpp: Added property svn:eol-style. (WebCore::bitmapInfoForSize): (WebCore::BitmapInfo::create): (WebCore::BitmapInfo::createBottomUp):
  • platform/win/BitmapInfo.h: Added property svn:eol-style. (WebCore::BitmapInfo::is16bit): (WebCore::BitmapInfo::is32bit): (WebCore::BitmapInfo::width): (WebCore::BitmapInfo::height): (WebCore::BitmapInfo::size): (WebCore::BitmapInfo::paddedWidth): (WebCore::BitmapInfo::numPixels): (WebCore::BitmapInfo::paddedBytesPerLine): (WebCore::BitmapInfo::bytesPerLine):
19:36 Changeset [63943] by morrita@google.com
  • 2 edits
    1 add in trunk/WebCore

2010-07-22 MORITA Hajime <morrita@google.com>

Reviewed by Ojan Vafai.

Autoscroll on selection should take scrollbars into account as outside of the content.
https://bugs.webkit.org/show_bug.cgi?id=40403

ScrollView's scroll-bar was considered as a part of content rect,
that prevents autoscroll to happen when the pointer is over the
scroll-bar. This change excluded scroll-bar region from scrolling
delta calculation.

Test: WebCore/manual-tests/autoscroll-over-scrollbar.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
19:29 Changeset [63942] by tkent@chromium.org
  • 7 edits
    3 adds in trunk

maxLength should not be applied to non-text types
https://bugs.webkit.org/show_bug.cgi?id=42814

Reviewed by Darin Adler.

WebCore:

According to the HTML5 specification, maxLength attribute should
be applied to text, search, url, tel, email, and password types.

Test: fast/forms/input-maxlength-unsupported.html

  • dom/InputElement.cpp:

(WebCore::InputElement::handleBeforeTextInsertedEvent):

Apply maxLength() only if supportsMaxLength() is true.

  • dom/InputElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::patternMismatch):

Code cleanup by isTextType().

(WebCore::HTMLInputElement::tooLong):

ditto.

(WebCore::HTMLInputElement::isTextType):

Added. This returns true for types with maxLength/pattern/placeholder.

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::supportsMaxLength):

Added. Just calls isTextType().

(WebCore::HTMLInputElement::supportsPlaceholder):

Code cleanup by isTextType().

  • wml/WMLInputElement.h:

(WebCore::WMLInputElement::supportsMaxLength):

Added. Always returns true.

LayoutTests:

  • fast/forms/input-maxlength-unsupported-expected.txt: Added.
  • fast/forms/input-maxlength-unsupported.html: Added.
  • fast/forms/script-tests/input-maxlength-unsupported.js: Added.
19:26 Changeset [63941] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

[cleanup] logic to extract adjacent lists and list children in listifyParagraph and unlistifyParagraph should be isolated
https://bugs.webkit.org/show_bug.cgi?id=42841

Reviewed by Kent Tamura.

Added enclosingListChild that takes the list node containing the node for the second argument
to ensure that it only returns the enclosing list child of the specified list node.

Added adjacentEnclosingList that finds adjacent lists of the specified position.
It takes the current position, the adjacent position that may or may not have a list, and the list type,
and avoids a list that belongs to a different table cell or an outer list that contains the current position.

No new tests needed.

  • editing/InsertListCommand.cpp:

(WebCore::enclosingListChild): Added. See above.
(WebCore::InsertListCommand::unlistifyParagraph): Uses enclosingListChild.
(WebCore::adjacentEnclosingList): Added. See above.
(WebCore::InsertListCommand::listifyParagraph): Uses adjacentEnclosingList.

19:15 Changeset [63940] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-22 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WIN] Correct DeleteObject usage in PasteboardWin
https://bugs.webkit.org/show_bug.cgi?id=41956

Call DeleteObject() if OpenClipboard() fails and don't
call DeleteObject() on objects returned from SelectObject().

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
19:02 Changeset [63939] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Log function is incorrectly used.
r63804 used LOG function, but it should receive one more parameter.
Used LOG_ERROR instead, since this is an error message.
https://bugs.webkit.org/show_bug.cgi?id=42842

  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyFallbackCursor): use LOG_ERROR in place of LOG
18:56 Changeset [63938] by ap@apple.com
  • 2 edits in trunk/WebKit2

More Windows build fixing.

  • win/WebKit2Generated.make: Copy the new public headers to $(WEBKITOUTPUTDIR)\include\WebKit2.
18:30 Changeset [63937] by ap@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.

  • win/WebKit2.vcproj: Added new files.
18:24 Changeset [63936] by mrowe@apple.com
  • 5 edits in branches/safari-533.17-branch

Versioning.

18:24 Changeset [63935] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-22 Cosmin Truta <ctruta@chromium.org>

Reviewed by Darin Adler.

SVG: Temporarily disable the layout test for the bug 41175 on Leopard.
https://bugs.webkit.org/show_bug.cgi?id=42802

  • platform/mac-leopard/Skipped: svg/filters/filter-empty-g.svg skipped until fix.
18:23 Changeset [63934] by mrowe@apple.com
  • 1 copy in tags/Safari-533.17.8

New tag.

18:11 Changeset [63933] by commit-queue@webkit.org
  • 6 edits in trunk/WebKit

2010-07-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Implement input method notification
https://bugs.webkit.org/show_bug.cgi?id=42640

Notify browser when keyboard should be shown/hidden. Input method
hints are updated before sending the signal. Client should be able to
determine the input type by calling ewk_view_imh_get().

  • efl/EWebLauncher/main.c: (on_inputmethod_changed): example implementation that just prints to stdout if keyboard should be shown or hidden and the imh flags. (browserCreate): listen to signal about input method changing its state.
  • efl/WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::setInputMethodState): call new function responsible for implementing this notification.
  • efl/ewk/ewk_private.h: ewk_view_input_method_state_set() is called only from inside WebKit.
  • efl/ewk/ewk_view.cpp: implement setters and getters (ewk_view_imh_get): (ewk_view_input_method_state_set):
  • efl/ewk/ewk_view.h: introduce Ewk_Imh enum which contains the possible input types. (_Ewk_View_Smart_Class::):
17:59 Changeset [63932] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

2010-07-22 John Gregg <johnnyg@google.com>

Unreviewed; chromium test expectation change.

fast/forms/input-file-directory-upload.html passes on windows after r63914
https://bugs.webkit.org/show_bug.cgi?id=42768

  • platform/chromium/test_expectations.txt:
17:53 Changeset [63931] by mrowe@apple.com
  • 14 edits
    2 adds in branches/safari-533.17-branch

Merge r63927.

17:49 Changeset [63930] by ap@apple.com
  • 15 edits
    6 adds in trunk

Reviewed by Sam Weinig and Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner

Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
fixed, but this makes difference one line smaller on many editing tests.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNode.cpp: Added. (WKBundleNodeCopyNodeName): (WKBundleNodeGetParent):
  • WebProcess/InjectedBundle/API/c/WKBundleNode.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetEditorClient):
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundleRange.cpp: Added. (WKBundleRangeGetStartOffset): (WKBundleRangeGetStartContainer): (WKBundleRangeGetEndOffset): (WKBundleRangeGetEndContainer):
  • WebProcess/InjectedBundle/API/c/WKBundleRange.h: Added. Added WKBundleRangeRef and WKBundleNodeRef types for injected bundles. These are just pointers to respective WebCore objects, without any WebKit2 wrappers.
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp: Added. (WebKit::InjectedBundlePageEditorClient::InjectedBundlePageEditorClient): (WebKit::InjectedBundlePageEditorClient::initialize): (WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h: Added.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::shouldBeginEditing):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::initializeInjectedBundleEditorClient):
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::injectedBundleEditorClient): Added the plumbing for invoking injected bundle code for editor client. There is no real API for editor client yet.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpEditingCallbacks() and setAcceptsEditing().
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree. (WTR::operator<<): Print a range. (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing clients. (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far. (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client calls.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpEditingCallbacks): (WTR::LayoutTestController::setAcceptsEditing): (WTR::LayoutTestController::acceptsEditing): (WTR::LayoutTestController::shouldDumpEditingCallbacks): Store m_acceptsEditing and m_dumpEditingCallbacks.
17:43 Changeset [63929] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

2010-07-22 Kent Tamura <tkent@chromium.org>

Reviewed by Ojan Vafai.

Cancel button of search input field should fire input/change events
https://bugs.webkit.org/show_bug.cgi?id=34393

  • fast/forms/script-tests/search-cancel-button-events.js: Added.
  • fast/forms/search-cancel-button-events-expected.txt: Added.
  • fast/forms/search-cancel-button-events.html: Added.

2010-07-22 Kent Tamura <tkent@chromium.org>

Reviewed by Ojan Vafai.

Cancel button of search input field should fire input/change events
https://bugs.webkit.org/show_bug.cgi?id=34393

Test: fast/forms/search-cancel-button-events.html

  • rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
17:37 Changeset [63928] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Merge r63924.

17:37 Changeset [63927] by weinig@apple.com
  • 14 edits
    2 copies in trunk

Fix for <rdar://problem/8222626>
Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.

Reviewed by Maciej Stachowiak.

WebCore:

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Update project files.

  • dom/UserTypingGestureIndicator.cpp: Copied from dom/UserGestureIndicator.cpp.

(WebCore::UserTypingGestureIndicator::processingUserTypingGesture):
(WebCore::focusedNode):
(WebCore::UserTypingGestureIndicator::focusedElementAtGestureStart):
(WebCore::UserTypingGestureIndicator::UserTypingGestureIndicator):
(WebCore::UserTypingGestureIndicator::~UserTypingGestureIndicator):

  • dom/UserTypingGestureIndicator.h: Copied from dom/UserGestureIndicator.h.

Version of UserGestureIndicator that just tracks keyboard gestures and the focused
node they were targeting.

  • editing/Editor.cpp:

(WebCore::Editor::confirmComposition):
(WebCore::Editor::setComposition):

  • page/EventHandler.cpp:

(WebCore::EventHandler::keyEvent):
Put UserTypingGestureIndicator on the stack for user generated keyboard events.

WebKit/mac:

The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
should migrate to a new function name eventually

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::textDidChangeInTextField):

WebKit/win:

The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
should migrate to a new function name eventually

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::textDidChangeInTextField):

17:32 Changeset [63926] by tkent@chromium.org
  • 7 edits
    3 adds in trunk

2010-07-22 Kent Tamura <tkent@chromium.org>

Reviewed by Ojan Vafai.

<input type=number> stepper buttons should dispatch input/change events
https://bugs.webkit.org/show_bug.cgi?id=42440

  • fast/forms/input-number-events-expected.txt: Added.
  • fast/forms/input-number-events.html: Added.
  • fast/forms/script-tests/input-number-events.js: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-07-22 Kent Tamura <tkent@chromium.org>

Reviewed by Ojan Vafai.

<input type=number> stepper buttons should dispatch input/change events
https://bugs.webkit.org/show_bug.cgi?id=42440

Test: fast/forms/input-number-events.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Sets a flag to dispatch 'change' event and dispatches 'input' event if the value is changed.
17:29 Changeset [63925] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-07-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Make history state methods validate against document URL
https://bugs.webkit.org/show_bug.cgi?id=42858

Test: fast/history/history-replace-illegal.html

  • page/History.cpp: (WebCore::History::urlForState):

2010-07-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Make history state methods validate against document URL
https://bugs.webkit.org/show_bug.cgi?id=42858

  • fast/history/history-replace-illegal-expected.txt: Added.
  • fast/history/history-replace-illegal.html: Added.
17:25 Changeset [63924] by aestes@apple.com
  • 2 edits in trunk/WebCore

When there are no beforeload listeners on a document,
HTMLLinkElement::process() should be called immediately when the node is
inserted into the document, rather than waiting until after attach is
performed.
<https://bugs.webkit.org/show_bug.cgi?id=42859>
<rdar://problem/8194528>

Reviewed by Maciej Stachowiak.

No new tests.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::insertedIntoDocument): If there are no
beforeload listeners, call process() immediately. Otherwise, add it as
a post-attach callback.

17:18 Changeset [63923] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-07-22 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

REGRESSION: box shadows on WebGL canvas elements repainted every frame
https://bugs.webkit.org/show_bug.cgi?id=42852

Avoid calling HTMLCanvasElement::willDraw() every time a WebGL canvas'
contents update. This call is only needed in the non-compositing
rendering path.

Covered by fast/canvas/webgl/canvas-test.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::markContextChanged): (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
17:05 Changeset [63922] by yurys@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-07-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: test that inspector will log syntax error in console without crashing
https://bugs.webkit.org/show_bug.cgi?id=42831

  • inspector/console-log-syntax-error-expected.txt: Added.
  • inspector/console-log-syntax-error.html: Added.
  • inspector/resources/syntax-error.js: Added.
  • platform/chromium/inspector/console-log-syntax-error-expected.txt: Added.
16:52 Changeset [63921] by yael.aharon@nokia.com
  • 17 edits
    4 adds in trunk

2010-07-22 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] QtWebKit needs public API for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=41413

Add a DRT API to set a flag so that notification requests are ignored,
and add a test for cancelling a pending notification request.
New API and test are disabled for Chromium port.

  • fast/notifications/notifications-cancel-request-permission-expected.txt: Added.
  • fast/notifications/notifications-cancel-request-permission.html: Added.
  • fast/notifications/resources: Added.
  • fast/notifications/resources/notifications-cancel-request-permission.html: Added.
  • platform/chromium/test_expectations.txt:

2010-07-22 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] QtWebKit needs public API for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=41413

Remove DumpRenderTree private API and introduce new API.
Also add support for informing the UI when a notification request is cancelled.

  • Api/qwebpage.cpp: (QWebPage::setUserPermission):
  • Api/qwebpage.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::requestPermission): (WebCore::NotificationPresenterClientQt::checkPermission): (WebCore::NotificationPresenterClientQt::cancelRequestsForPermission): (WebCore::NotificationPresenterClientQt::allowNotificationForFrame): (WebCore::NotificationPresenterClientQt::toPage): (WebCore::NotificationPresenterClientQt::toFrame):
  • WebCoreSupport/NotificationPresenterClientQt.h:

2010-07-22 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] QtWebKit needs public API for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=41413

Update DumpRenderTree and QtTestBrowser to use the new API.
Add new DRT API to flag that notifications permission requests should be ignored.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::requestPermission): (WebCore::WebPage::checkPermission): (WebCore::WebPage::cancelRequestsForPermission):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::ignoreDesktopNotificationPermissionRequests): (LayoutTestController::checkDesktopNotificationPermission):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::ignoreReqestForPermission):
  • QtTestBrowser/main.cpp: (LauncherWindow::LauncherWindow):
  • QtTestBrowser/webpage.cpp: (WebPage::WebPage): (WebPage::requestPermission): (WebPage::checkPermission): (WebPage::cancelRequestsForPermission):
  • QtTestBrowser/webpage.h:
16:32 Changeset [63920] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Adapt sandbox for new WebProcess bootstrap service naming scheme.
<rdar://problem/8225000>

Patch by Ivan Krstić <ike@apple.com> on 2010-07-22
Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
16:16 Changeset [63919] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/WebCore

2010-07-22 Patrick Gansterer <paroga@paroga.com>

Reviewed by Ojan Vafai.

Remove useless PlatformScrollBar
https://bugs.webkit.org/show_bug.cgi?id=41911

  • WebCore.gypi:
  • platform/win/PlatformScrollBar.h: Removed.
  • platform/win/PlatformScrollBarWin.cpp: Removed.
15:55 Changeset [63918] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

[Windows] Home hey doesn't work in first DIV inside a TABLE
https://bugs.webkit.org/show_bug.cgi?id=42767

Reviewed by Ojan Vafai.

WebCore:

The bug was caused by positionAvoidingFirstPositionInTable moving outside of the editing region.
Added a check so that it avoids the first position in the table only if the table is editable.

Test: editing/selection/home-inside-noneditable-table.html

  • editing/visible_units.cpp:

(WebCore::positionAvoidingFirstPositionInTable):

LayoutTests:

Added a test to move caret backwards to the line boundary inside a content-editable div
inside a non-editable table.

  • editing/selection/home-inside-noneditable-table-expected.txt: Added.
  • editing/selection/home-inside-noneditable-table.html: Added.
  • resources/dump-as-markup.js: Modified to support multiple calls to dump

(Markup.dump.get if):
(Markup.dump):
(Markup.notifyDone):

15:18 Changeset [63917] by andersca@apple.com
  • 3 edits in trunk/WebKit2

It should be possible to attach to the WebProcess in gdb during startup
https://bugs.webkit.org/show_bug.cgi?id=42853

Reviewed by Adam Roben.

Create an unique bootstrap service name and pass it to the web process, instead of registering a per process
name (which was incorrect anyway). This lets us get rid of the requirement that the UI process always should be
the parent process of the web process, something which is false when running under the debugger.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

14:58 Changeset [63916] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Don't assert when Connection::invalidate is called before Connection::dispatchConnectionDidClose
https://bugs.webkit.org/show_bug.cgi?id=42851

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchConnectionDidClose):
Just return early if m_client is 0.

14:34 Changeset [63915] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Fix build warning for missing parentheses.

Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore/html/HTMLInputElement.cpp:113: warning: suggest parentheses around '&&' within '
'
  • html/HTMLInputElement.cpp:

(WebCore::isNumberCharacter):

14:26 Changeset [63914] by johnnyg@google.com
  • 2 edits in trunk/WebCore

2010-07-22 John Gregg <johnnyg@google.com>

Reviewed by Kent Tamura.

[chromium] fast/forms/input-file-directory-upload.html fails on win after r63454
https://bugs.webkit.org/show_bug.cgi?id=42768

Normalize path separators for the script API by convering \'s to /'s.

Covered by input-file-directory-upload.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setFileListFromRenderer):
14:25 Changeset [63913] by aroben@apple.com
  • 2 edits in trunk/WebKit2

Use ::MessageBox instead of ::DebugBreak to make the web process wait for a debugger

While ::DebugBreak can make it easier to attach a debugger (because it
brings up the Just-in-Time debugger window), using ::MessageBox has
two advantages:

1) It explains to the user what's going on, so it's harder to

mistake this debugging aid for a bug.

2) It allows you to debug the UI process and the web process using

the same debugger, if desired.

Special thanks to John Sullivan for help with the text that's shown in
the alert.

Fixes <http://webkit.org/b/42848> WebKit2's wait-for-debugger
debugging aid should explain to the user what's happening

Reviewed by John Sullivan and Anders Carlsson.

  • WebProcess/WebKitMain.cpp:

(WebKitMain): Use a ::MessageBox instead of a ::DebugBreak to wait for
the debugger. The alert explains to the user what's going on.

14:25 Changeset [63912] by aroben@apple.com
  • 2 edits in trunk/WebKit2

Make WorkQueue aware of potential errors with ::WaitForMultipleObjects

Fixes <http://webkit.org/b/42846> WorkQueue should detect
::WaitForMultipleObject failures

Reviewed by Anders Carlsson.

  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::workQueueThreadBody): Added some assertions about the
various things that can fail with ::WaitForMultipleObjects,
specifically:

  • Passing too many objects
  • Timeouts (which shouldn't happen since we pass a timeout interval of INFINITE)
  • Abandoned mutexes (which shouldn't happen since we don't wait on any mutexes currently)
  • Miscellaneous failures
14:06 Changeset [63911] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Rubberstamped by Simon Fraser.

  • platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::PlatformStrategies): Add initialization of m_localizationStrategy.

13:56 Changeset [63910] by dumi@chromium.org
  • 11 edits in trunk

WebCore: Make db.changeVersion()'s third parameter optional, as required by the spec.
https://bugs.webkit.org/show_bug.cgi?id=42787

Reviewed by Ojan Vafai.

  • bindings/js/JSDatabaseCustom.cpp:

(WebCore::JSDatabase::changeVersion):

  • bindings/js/JSDatabaseSyncCustom.cpp:

(WebCore::JSDatabaseSync::changeVersion):

  • bindings/v8/custom/V8DatabaseCustom.cpp:

(WebCore::V8Database::changeVersionCallback):

  • bindings/v8/custom/V8DatabaseSyncCustom.cpp:

(WebCore::V8DatabaseSync::changeVersionCallback):

  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverTransactionCallback):

  • storage/SQLTransactionSync.cpp:

(WebCore::SQLTransactionSync::execute):

LayoutTests: Simplify some tests, and make sure db.changeVersion()'s third parameter is optional.
https://bugs.webkit.org/show_bug.cgi?id=42787

Reviewed by Ojan Vafai.

  • fast/workers/storage/resources/change-version-sync-1.js:
  • fast/workers/storage/resources/change-version-sync-2.js:
  • storage/change-version.html:
13:43 Changeset [63909] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-22 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations fix.

  • platform/chromium/test_expectations.txt: Updated expectations to match reality on the bots.
13:33 Changeset [63908] by jberlin@webkit.org
  • 9 edits in trunk/WebCore

2010-07-20 Jessie Berlin <jberlin@apple.com>

Reviewed by Darin Adler.

Code Generator: Allow negative and string constants.
Also add tests for hexadecimal numbers.

  • bindings/scripts/CodeGeneratorJS.pm: If it is a string, do not try to cast it to an int.
  • bindings/scripts/IDLStructure.pm: Add a regex just for constant values that allows strings, hexadecimal numbers, and integral numbers.
  • bindings/scripts/test/CPP/WebDOMTestObj.h: Update the tests.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/TestObj.idl: Add tests for negative numbers, strings, and hexadecimal numbers.
  • bindings/scripts/test/V8/V8TestObj.cpp: Update the tests.
13:17 Changeset [63907] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2010-07-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Composited layers don't scroll in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42771

More prep work: make a single scrollPositionChanged() bottleneck method, and use it to
send the scroll event, repaint fixed elements, and update compositing layers.

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChangedViaPlatformWidget): (WebCore::FrameView::scrollPositionChanged): (WebCore::FrameView::repaintFixedElementsAfterScrolling): (WebCore::FrameView::valueChanged):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::valueChanged):
13:00 Changeset [63906] by darin@apple.com
  • 8 edits in trunk

2010-07-22 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
https://bugs.webkit.org/show_bug.cgi?id=42325

  • platform/mac-wk2/Skipped: Removed a duplicate and sorted lists of tests. Added some tests to the pasteboard list. Removed the tests from the dumpChildFramesAsText list that now pass, and moved others to other lists.

2010-07-22 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
https://bugs.webkit.org/show_bug.cgi?id=42325

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpChildFramesAsText.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::dumpFrameText): Added. (WTR::dumpDescendantFramesText): Added. (WTR::InjectedBundlePage::dumpAllFramesText): Added. (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function instead of the shouldDumpAsText function, and added a case for AllFramesText.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with m_whatToDump.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive, and shouldDumpSourceAsWebArchive. Added whatToDump.
12:24 CodeReview edited by levin@chromium.org
(diff)
11:39 Changeset [63905] by darin@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-07-22 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[Chromium] Propagate return value of EventHandler::handleMouseWheelEvent
to caller of WebViewImpl::handleInputEvent.

https://bugs.webkit.org/show_bug.cgi?id=42835

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::mouseWheel): (WebKit::WebViewImpl::handleInputEvent):
  • src/WebViewImpl.h:
11:18 Changeset [63904] by weinig@apple.com
  • 14 edits
    1 add in trunk

Patch for https://bugs.webkit.org/show_bug.cgi?id=42836
Add localized strings stubs for WebKit2.

Reviewed by Anders Carlsson.

WebCore:

  • Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory for localized strings.

Gets us below 200 tests failing in WebKitTestRunner.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/WebCoreViewFactory.h:
  • platform/LocalizationStrategy.h: Added.

(WebCore::LocalizationStrategy::~LocalizationStrategy):

  • platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::pluginStrategy):
(WebCore::PlatformStrategies::localizationStrategy):
(WebCore::PlatformStrategies::PlatformStrategies):
(WebCore::PlatformStrategies::~PlatformStrategies):

  • platform/mac/LocalizedStringsMac.mm:

WebKit/mac:

  • Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory for localized strings.

Gets us below 200 tests failing in WebKitTestRunner.

  • WebCoreSupport/WebContextMenuClient.mm:

(fixMenusReceivedFromOldClients): Use LocalizedStrings rather than the factory.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:
  • WebCoreSupport/WebViewFactory.mm:

WebKit2:

Gets us below 200 tests failing in WebKitTestRunner.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
11:08 Changeset [63903] by abecsi@webkit.org
  • 3 edits in trunk/WebKit2

Unreviewed trivial build fix.

[Qt] Mend remaining issues to fix the WebKit2 build.

  • Shared/qt/UpdateChunk.h: add missing function

(WebKit::UpdateChunk::isEmpty):

  • UIProcess/API/qt/qwkpage_p.h: Add stub implementation

(QWKPagePrivate::pageDidEnterAcceleratedCompositing):
(QWKPagePrivate::pageDidLeaveAcceleratedCompositing):

11:01 Changeset [63902] by abecsi@webkit.org
  • 4 edits
    1 add in trunk

2010-07-22 Andras Becsi <abecsi@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42830

No new tests needed.

  • WebCore.pri: add ApplicationCacheStorage.h to wk2 headers
  • WebCore.pro: add WebContextQt.cpp to sources

2010-07-22 Andras Becsi <abecsi@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42830

  • UIProcess/qt/WebContextQt.cpp: Added. (WebKit::WebContext::applicationCacheDirectory):
10:48 Changeset [63901] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-22 Joone Hur <joone.hur@samsung.com>

Reviewed by Antonio Gomes.

[EFL] add support for logging
https://bugs.webkit.org/show_bug.cgi?id=40807

Enable to turn log channels on for EFL port

  • platform/efl/LoggingEfl.cpp: (WebCore::InitializeLoggingChannelsIfNecessary):
10:04 Changeset [63900] by ossy@webkit.org
  • 1 edit
    21 copies in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected results for tests introduced in r62200.

  • platform/qt/fast/borders/border-radius-circle-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-circle-expected.txt.
  • platform/qt/fast/borders/border-radius-groove-01-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-01-expected.txt.
  • platform/qt/fast/borders/border-radius-groove-02-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-02-expected.txt.
  • platform/qt/fast/borders/border-radius-groove-03-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-03-expected.txt.
  • platform/qt/fast/borders/border-radius-wide-border-01-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-01-expected.txt.
  • platform/qt/fast/borders/border-radius-wide-border-02-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-02-expected.txt.
  • platform/qt/fast/borders/border-radius-wide-border-03-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-03-expected.txt.
  • platform/qt/fast/borders/border-radius-wide-border-04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-04-expected.txt.
  • platform/qt/fast/borders/borderRadiusDashed04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed04-expected.txt.
  • platform/qt/fast/borders/borderRadiusDashed05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed05-expected.txt.
  • platform/qt/fast/borders/borderRadiusDashed06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed06-expected.txt.
  • platform/qt/fast/borders/borderRadiusDotted04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted04-expected.txt.
  • platform/qt/fast/borders/borderRadiusDotted05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted05-expected.txt.
  • platform/qt/fast/borders/borderRadiusDotted06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted06-expected.txt.
  • platform/qt/fast/borders/borderRadiusDouble04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble04-expected.txt.
  • platform/qt/fast/borders/borderRadiusDouble05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble05-expected.txt.
  • platform/qt/fast/borders/borderRadiusDouble06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble06-expected.txt.
  • platform/qt/fast/borders/borderRadiusDouble07-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble07-expected.txt.
  • platform/qt/fast/borders/borderRadiusDouble08-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble08-expected.txt.
  • platform/qt/fast/borders/borderRadiusDouble09-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble09-expected.txt.
  • platform/qt/fast/borders/different-color-borders-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/different-color-borders-expected.txt and updated.
10:02 Changeset [63899] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-07-22 Jamey Hicks <jamey.hicks@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Enable binding of QObjects to JavaScript environment for inspector frontend

This patch enables QObjects to be bound to global variables in the
javascript environment of the inspector frontend. This is useful
for writing alternate inspector frontends in javascript which need
additional native functionality. It's a lighter-weight alternative
than using an NPAPI plugin.

The code which instantiates QWebInspector uses this by setting the
dynamic property "q_inspectorJavaScriptWindowObjects" on the
QWebInspector. The value of this property should be a
QMap<QString,QVariant> mapping global variable name to QObject.

I have used this to add support for eclipse/chrome remote
debugging in QtTestBrowser.

https://bugs.webkit.org/show_bug.cgi?id=41995

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientWebPage::InspectorClientWebPage): (WebCore::InspectorClientWebPage::javaScriptWindowObjectCleared): (WebCore::InspectorClientQt::openInspectorFrontend):
10:00 Changeset [63898] by abecsi@webkit.org
  • 4 edits in trunk

WebCore: Ureviewed build fix.

Patch by Balazs Kelemen <kb@inf.u-szeged.hu> on 2010-07-22
[Qt] Fix WebKit2 build

https://bugs.webkit.org/show_bug.cgi?id=42638

  • WebCore.pri:
  • WebCore.pro:

WebKit2: Unreviewed build fix.

Patch by Balazs Kelemen <kb@inf.u-szeged.hu> on 2010-07-22
[Qt] Fix WebKit2 build

https://bugs.webkit.org/show_bug.cgi?id=42638

  • UIProcess/API/qt/qwkpage_p.h:

(QWKPagePrivate::setCursor): Added empty implementation.

09:42 Changeset [63897] by darin@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-07-22 Darin Fisher <darin@chromium.org>

Reviewed by Kent Tamura.

https://bugs.webkit.org/show_bug.cgi?id=42808
Pass context menu events through WebInputEvent to WebPlugin::handleInputEvent.

The DOM treats a context menu event as a type of mouse event. We therefore
do the same here, and reuse the WebMouseEvent subclass. This makes sense
since a context menu event has (x,y)-coordinates.

  • public/WebInputEvent.h: (WebKit::WebInputEvent::): (WebKit::WebInputEvent::isMouseEventType):
  • src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
09:39 Changeset [63896] by commit-queue@webkit.org
  • 4 edits in trunk

2010-07-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Stop granting universal access to inspector front-end page.
https://bugs.webkit.org/show_bug.cgi?id=42817

  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::windowObjectCleared):

2010-07-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Stop granting universal access to inspector front-end page.
https://bugs.webkit.org/show_bug.cgi?id=42817

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
09:04 Applications using WebKit edited by tom-brown@live.co.uk
(diff)
09:03 Changeset [63895] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-07-22 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix inspector console tests crashes.

  • bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue): (WebCore::ScriptValue::toInspectorValue): enter v8 context before calling GetPropertyNames
09:02 Applications using WebKit edited by tom-brown@live.co.uk
Changed Name of TomBrowser to XtremeBrowser added features (diff)
08:19 Changeset [63894] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-07-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

[EFL] Build break for SVN r63881
https://bugs.webkit.org/show_bug.cgi?id=42813

  • CMakeLists.txt: Add platform/SchemeRegistry.cpp
08:03 Changeset [63893] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit2

2010-07-22 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Antonio Gomes.

Lazy cursor creation should be guarded by #if USE(LAZY_NATIVE_CURSOR) in WebKit2

https://bugs.webkit.org/show_bug.cgi?id=42622

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage):
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::setCursor):
07:43 Changeset [63892] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-07-22 Hayato Ito <hayato@chromium.org>

Reviewed by Darin Adler.

Refactor CSSSelector's destructor and make it inline.

https://bugs.webkit.org/show_bug.cgi?id=42726

Refactor with no behavior change, thus no new tests.

  • css/CSSSelector.cpp: (WebCore::CSSSelectorBag::~CSSSelectorBag): Make sure the bag is empty. (WebCore::CSSSelectorBag::add): Renamed from append(). (WebCore::CSSSelector::releaseOwnedSelectorsToBag): (WebCore::CSSSelector::deleteReachableSelectors):
  • css/CSSSelector.h: (WebCore::CSSSelector::~CSSSelector):
07:33 Changeset [63891] by yurys@chromium.org
  • 16 edits in trunk/WebCore

2010-07-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: should be possible to convert console message arguments to InspectorValues
https://bugs.webkit.org/show_bug.cgi?id=42457

Now it is possible to convert simple JavaScript objects to
InspectorValues.

  • bindings/js/ScriptValue.cpp: (WebCore::jsToInspectorValue): (WebCore::ScriptValue::toInspectorValue):
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue): (WebCore::ScriptValue::toInspectorValue):
  • bindings/v8/ScriptValue.h:
  • inspector/ConsoleMessage.cpp: console notifications are pushed to RemoteInspectorFrontend instead of InspectorFrontend. (WebCore::ConsoleMessage::CallFrame::buildInspectorObject): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole):
  • inspector/ConsoleMessage.h:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::wrapForConsole): return InspectorValue instead of SerializedScriptValue
  • inspector/InjectedScript.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::clearConsoleMessages): send response directly from the backend (WebCore::InspectorBackend::remoteFrontend):
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::clearConsoleMessages): don't send notification to the front end, it will be send either from InspectorBackend.cpp if it was a user request or reset message will be send to the front end if the messages are cleared due to page navigation. (WebCore::InspectorController::populateScriptObjects):
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/inspector.js:
07:26 Changeset [63890] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] REGRESSION(63862): animations/play-state.html fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=42821

  • platform/qt/Skipped: animations/play-state.html skipped until fix.
07:23 Changeset [63889] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-07-22 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Modifying settings actually modifies defaultValues
https://bugs.webkit.org/show_bug.cgi?id=42816

Avoid using live modifiable objects as property default values.

07:07 Changeset [63888] by benm@google.com
  • 6 edits in trunk/WebCore

2010-07-22 Ben Murdoch <benm@google.com>

Reviewed by Simon Fraser.

Touch events do not affect the :active CSS state
https://bugs.webkit.org/show_bug.cgi?id=39493

Clean the code up by using a typedef based on comments
post landing of the original patch.

No change in functionality so no new tests.

  • rendering/HitTestRequest.h: Typedef the HitTestRequestType to unsigned.
  • WebCore.exp.in: Update export signature.
  • WebCore.order: Ditto.
  • page/EventHandler.cpp: use the new typedef.
  • page/EventHandler.h: ditto.
06:47 QtWebKitReleases edited by hausmann@webkit.org
(diff)
06:36 Changeset [63887] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

[Qt] Library versioning.

2.1 is branched, trunk will become 2.2.

  • Api/qwebkitglobal.h:
  • qt_webkit_version.pri:
06:29 QtWebKitRelease21 created by hausmann@webkit.org
06:28 QtWebKitBackportingFixes edited by hausmann@webkit.org
(diff)
06:26 Changeset [63886] by apavlov@chromium.org
  • 14 edits in trunk

2010-07-22 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Rename method for CSS rule source range retrieval and fix return object format
https://bugs.webkit.org/show_bug.cgi?id=42379

WebCore:

  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getRuleRanges):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::getRuleRanges):
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getRuleRanges):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js:

WebKit/chromium:

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):

LayoutTests:

  • inspector/styles-source-offsets.html:
06:25 QtWebKit edited by hausmann@webkit.org
(diff)
06:01 Changeset [63885] by aroben@apple.com
  • 3 edits in trunk/WebKitTools

Windows build fix

Inspired by r63881.

  • MiniBrowser/MiniBrowser.vcproj:
  • WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:

Removed pre- and post-build events so they will be inherited from the
vsprops files.

05:52 Changeset [63884] by pfeldman@chromium.org
  • 7 edits in trunk

2010-07-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium Dev Tools: Separators are missing in the context menu.

https://bugs.webkit.org/show_bug.cgi?id=42761

  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
  • platform/ContextMenuItem.h: (WebCore::):

2010-07-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium Dev Tools: Separators are missing in the context menu.

https://bugs.webkit.org/show_bug.cgi?id=42761

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::populateCustomMenuItems):
05:41 Changeset [63883] by zherczeg@webkit.org
  • 4 edits
    50 adds in trunk

SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244

Reviewed by Nikolas Zimmermann.

WebCore:

Implementing svgAttributeChanged and childrenChanged for the base class of all filters,
called SVGFilterPrimitiveStandardAttributes.

Tests: svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr.html

svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.html

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::SVGFilterPrimitiveStandardAttributes::invalidateFilter):

LayoutTests:

  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr.html: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr.html: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr.html: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr.html: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr.html: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.html: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.html: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.html: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.html: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-height-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-result-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-width-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-x-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-y-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.js: Added.

(executeTest):

05:08 Changeset [63882] by kent.hansen@nokia.com
  • 6 edits in trunk

2010-07-22 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Kent Tamura.

Error properties of the Global Object are missing the DontEnum attribute
https://bugs.webkit.org/show_bug.cgi?id=28771

Add the attributes to become spec compliant.

  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):

2010-07-22 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Kent Tamura.

Error properties of the Global Object are missing the DontEnum attribute
https://bugs.webkit.org/show_bug.cgi?id=28771

Update expected results for tests that now pass.

  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.3_T3-expected.txt:
02:36 Changeset [63881] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit2

Build fix. Unreviewed.

  • win/WebKit2WebProcess.vcproj:

Remove the pre- and post-build events, so that they will use the value
inherited from the vsprops.

01:52 Changeset [63880] by kent.hansen@nokia.com
  • 9 edits in trunk/LayoutTests

2010-07-22 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Sam Weinig.

Improve coverage of fast/dom/prototype-inheritance test
https://bugs.webkit.org/show_bug.cgi?id=42354

Use Object.getOwnPropertyNames rather than for..in to enumerate
the window object's properties, so that non-enumerable (ECMA)
properties are covered as well.

  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/script-tests/prototype-inheritance.js: (propertiesOnObject):
  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
01:20 Changeset [63879] by tkent@chromium.org
  • 4 edits in trunk/WebCore

2010-07-22 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Small refactoring for input value sanitization
https://bugs.webkit.org/show_bug.cgi?id=42807

Rename some functions to clarify their roles.

  • dom/InputElement.cpp: (WebCore::replaceEOLAndLimitLength): Renamed from sanitizeUserInputValue(). (WebCore::InputElement::sanitizeValueForTextField): Renamed from sanitizeValue(), and call replaceEOLAndLimitLength() instead of sanitizeUserInputValue(). (WebCore::InputElement::sanitizeUserInputValue): Just call replaceEOLAndLimitLength(). (WebCore::InputElement::updateValueIfNeeded): Use non-static sanitizeValue() for consistency.
  • dom/InputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): Revert the change of r63876. It is not needed because of the updateValueIfNeeded() change. (WebCore::HTMLInputElement::sanitizeValue): Apply the sanitizeValue() renaming.
00:40 Changeset [63878] by tonyg@chromium.org
  • 5 edits in trunk/WebCore

2010-07-22 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

webkitPerformance.timing.responseEnd should not include document parse time
https://bugs.webkit.org/show_bug.cgi?id=42797

No new tests because timing based test would be flaky.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoading): finishedLoading() is called by the platform at the right time, but didReceiveData() synchronously invokes parsing without returning to the event loop prior to this. So by the time the didFinishLoading() method is executed, parsing is finished. The solution is to move this time to didReceiveData() prior to parsing.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveData): Update the time each time didReceiveData() is called. (WebCore::MainResourceLoader::didFinishLoading): When finished, and after parsing, set responseEnd appropriately.
  • loader/MainResourceLoader.h:
  • page/Timing.cpp: (WebCore::Timing::resourceLoadTimeRelativeToAbsolute): Now that responseEnd is set correctly, it can be much shorter for very fast loads (like local files). This exposed the fact that this skew check was not tight enough. We need to make sure that the whole range of values from the ResourceLoadTiming API fit within fetchStart-responseEnd, not just that requestTime fits in this range.

07/21/10:

23:52 Changeset [63877] by darin@apple.com
  • 13 edits in trunk

2010-07-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548

  • platform/mac-wk2/Skipped: Moved some tests into the correct section now that dumpChildFrameScrollPositions is no longer the reason they fail. Removed now-passing test. Resorted some of the tests.

2010-07-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file. (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name. Changed to a file-internal function instead of a member function. (WTR::dumpDescendantFrameScrollPositions): Added. (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added. (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when appropriate. Also streamlined all the WKStringToUTF8 call sites. (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8. (WTR::InjectedBundlePage::willSetStatusbarText): Ditto. (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto. (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto. (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController): Initialize m_shouldDumpAllFrameScrollPositions. (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from shouldDumpFrameScrollPositions.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions, and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.

2010-07-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548

Added WKBundleFrameCopyName.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameCopyName): Added.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name): Added.
  • WebProcess/WebPage/WebFrame.h: Ditto.
20:08 Changeset [63876] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

2010-07-21 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Assertion failure by changing the type of an input element with a
non-number value to 'range'.
https://bugs.webkit.org/show_bug.cgi?id=42643

  • fast/forms/input-value-sanitization-expected.txt: Added.
  • fast/forms/input-value-sanitization.html: Added.
  • fast/forms/script-tests/input-value-sanitization.js: Added.

2010-07-21 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Assertion failure by changing the type of an input element with a
non-number value to 'range'.
https://bugs.webkit.org/show_bug.cgi?id=42643

Test: fast/forms/input-value-sanitization.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): Update the value by HTMLInputElement::sanitizeValue() in a case that storesValueSeparateFromAttribute() state is not changed.
19:12 Changeset [63875] by jschuh@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-07-21 Justin Schuh <jschuh@chromium.org>

Unreviewed. Build fix.

Added platform test to account for qt's xml parser

  • platform/qt/svg/custom/use-invalid-html-expected.txt: Added.
18:54 Changeset [63874] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-21 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Copy the test plugin into DumpRenderTree.app/
https://bugs.webkit.org/show_bug.cgi?id=42733

This was dropped in plugin copy refactoring.

  • WebKit.gyp:
18:27 Changeset [63873] by rniwa@webkit.org
  • 4 edits
    2 adds
    18 deletes in trunk/LayoutTests

dumpAsMarkup test conversion: create-list-from-range-selection.html and insert-list-empty-div.html
https://bugs.webkit.org/show_bug.cgi?id=42608

Reviewed by Ojan Vafai.

Converted the tests and removed the platform specific expected results.

  • editing/execCommand/create-list-from-range-selection-expected.txt: Added.
  • editing/execCommand/create-list-from-range-selection.html: Use dumpAsMarkup
  • editing/execCommand/insert-list-empty-div-expected.txt: Added.
  • editing/execCommand/insert-list-empty-div.html: Use dumpAsMarkup
  • platform/chromium-linux/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
  • platform/gtk/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
  • platform/mac/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
  • platform/mac/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
  • platform/mac/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
  • platform/mac/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
  • platform/mac/editing/execCommand/insert-list-empty-div-expected.png: Removed.
  • platform/mac/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
  • platform/qt/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
  • platform/qt/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
  • resources/dump-as-markup.js: Added setNodeToDump.

(Markup.setNodeToDump):

18:10 Changeset [63872] by abarth@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076

Add a test showing that our parsing of unquoted attributes in
self-closing tags complies with the spec.

  • html5lib/resources/webkit02.dat: Added.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
18:08 Changeset [63871] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Let's pass the doctype01.dat tests again, please
https://bugs.webkit.org/show_bug.cgi?id=42794

The upstream results check the publicId and the systemId, so we need to
make dom2string smarter and print them.

  • html5lib/resources/dom2string.js: (dom2string):
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
18:04 Changeset [63870] by abarth@webkit.org
  • 4 edits in trunk

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement spec changes for basefont and bgsound
https://bugs.webkit.org/show_bug.cgi?id=42792

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processStartTagForInHead):

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement spec changes for basefont and bgsound
https://bugs.webkit.org/show_bug.cgi?id=42792

  • html5lib/runner-expected-html5.txt:
18:03 Changeset [63869] by abarth@webkit.org
  • 4 edits in trunk

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update a list of tags to match changes in the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=42791

We need to atomize these strings at some point.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update a list of tags to match changes in the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=42791

Testing makes perfect.

  • html5lib/runner-expected-html5.txt:
18:00 Changeset [63868] by abarth@webkit.org
  • 7 edits in trunk

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTreeBuilder needs to update to match new spec behavior for <button>
https://bugs.webkit.org/show_bug.cgi?id=42233

The spec has some typos in this area, but this is my best guess for
what Ian means. I've filed bugs against the spec for each typo.

  • html/HTMLElementStack.cpp: (WebCore::HTMLNames::isScopeMarker): (WebCore::HTMLNames::isButtonScopeMarker): (WebCore::HTMLElementStack::inButtonScope):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope): (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processEndTagForInBody):
  • html/HTMLTreeBuilder.h:

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTreeBuilder needs to update to match new spec behavior for <button>
https://bugs.webkit.org/show_bug.cgi?id=42233

Test progression. There's one regression mixed in here. I'll
investigate in the next patch.

  • html5lib/runner-expected-html5.txt:
17:58 Changeset [63867] by jschuh@chromium.org
  • 3 edits in trunk/LayoutTests

2010-07-21 Justin Schuh <jschuh@chromium.org>

Unreviewed. Build fix.

Removed comment element for test added with:
http://trac.webkit.org/changeset/63865

  • svg/custom/use-invalid-html-expected.txt:
  • svg/custom/use-invalid-html.xhtml:
17:46 Changeset [63866] by darin@apple.com
  • 17 edits in trunk

2010-07-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support dumping of scroll position
https://bugs.webkit.org/show_bug.cgi?id=42514

  • platform/mac-wk2/Skipped: Removed now-passing tests from skipped list and moved one miscategorized test.

2010-07-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support dumping of scroll position
https://bugs.webkit.org/show_bug.cgi?id=42514

  • MiniBrowser/mac/WebBundle/WebBundleMain.m: (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef. (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate. (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition. (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added. (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently returns false. (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently returns false. (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches the logic in DumpRenderTree.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.

2010-07-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner needs to support dumping of scroll position
https://bugs.webkit.org/show_bug.cgi?id=42514

Added WKBundleFrameGetJavaScriptContext function.

  • WebKit2.xcodeproj: Added property svn:ignore.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetJavaScriptContext): Added.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld): Use JSGlobalContextRef instead of JSContextRef and context instead of ct.
17:36 Changeset [63865] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-07-21 Justin Schuh <jschuh@chromium.org>

Reviewed by Oliver Hunt.

Prevent DeleteButtonController enable state from changing when not editing
https://bugs.webkit.org/show_bug.cgi?id=42659

Test: svg/custom/use-invalid-html.xhtml

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):

2010-07-21 Justin Schuh <jschuh@chromium.org>

Reviewed by Oliver Hunt.

Prevent DeleteButtonController enable state from changing when not editing
https://bugs.webkit.org/show_bug.cgi?id=42659

  • svg/custom/use-invalid-html-expected.txt: Added.
  • svg/custom/use-invalid-html.xhtml: Added.
16:53 Changeset [63864] by bdakin@apple.com
  • 84 edits
    4 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=42605 New border-
radius path-based drawing code has some issues with corner-joins

Reviewed by Dan Bernstein.

GraphicsContext::clipConvexPolygon() now takes a boolean parameter
indicating whether or not the clip should be antialiased.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::clipConvexPolygon):

Compute 4 booleans determining if each edge is a "matching" edge of
not. Send the two appropriate values to clipBorderSidePolygon() so
we can decide there whether or not to antialias the clip based on
matchy-ness.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

If both edges are matching, don't antialias. If neither edge
matches, never antialias. If one edge matches and one does not,
apply two clips to get the appropriate antialiasing in each corner.
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):

  • rendering/RenderBoxModelObject.h:

LayoutTests: Some of these layout tests are updated results from the fix for
https://bugs.webkit.org/show_bug.cgi?id=42605 New border-
radius path-based drawing code has some issues with corner-joins.
The others have been in need of an update since
https://bugs.webkit.org/show_bug.cgi?id=9197 , but since the
differences were only detectable visually and with a pixel-text
tolerance of 0 (not the default), they slipped under the rug until
now.

Reviewed by Dan Bernstein.

New test:

  • fast/borders/different-color-borders.html: Added.
  • platform/mac/fast/borders/border-radius-circle-expected.checksum:
  • platform/mac/fast/borders/border-radius-circle-expected.png:
  • platform/mac/fast/borders/border-radius-constraints-expected.checksum:
  • platform/mac/fast/borders/border-radius-constraints-expected.png:
  • platform/mac/fast/borders/border-radius-groove-01-expected.checksum:
  • platform/mac/fast/borders/border-radius-groove-01-expected.png:
  • platform/mac/fast/borders/border-radius-groove-02-expected.checksum:
  • platform/mac/fast/borders/border-radius-groove-02-expected.png:
  • platform/mac/fast/borders/border-radius-groove-03-expected.checksum:
  • platform/mac/fast/borders/border-radius-groove-03-expected.png:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/mac/fast/borders/border-radius-wide-border-02-expected.checksum:
  • platform/mac/fast/borders/border-radius-wide-border-02-expected.png:
  • platform/mac/fast/borders/border-radius-wide-border-03-expected.checksum:
  • platform/mac/fast/borders/border-radius-wide-border-03-expected.png:
  • platform/mac/fast/borders/border-radius-wide-border-04-expected.checksum:
  • platform/mac/fast/borders/border-radius-wide-border-04-expected.png:
  • platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum:
  • platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/mac/fast/borders/borderRadiusArcs01-expected.checksum:
  • platform/mac/fast/borders/borderRadiusArcs01-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed01-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDashed01-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed02-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDashed02-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed03-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDashed03-expected.png:
  • platform/mac/fast/borders/borderRadiusDashed04-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDashed04-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted02-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDotted02-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted03-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDotted03-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted04-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDotted04-expected.png:
  • platform/mac/fast/borders/borderRadiusDotted06-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDotted06-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble01-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble01-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble02-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble02-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble03-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble03-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble05-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble05-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble06-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble06-expected.png:
  • platform/mac/fast/borders/borderRadiusDouble08-expected.checksum:
  • platform/mac/fast/borders/borderRadiusDouble08-expected.png:
  • platform/mac/fast/borders/borderRadiusGroove01-expected.checksum:
  • platform/mac/fast/borders/borderRadiusGroove01-expected.png:
  • platform/mac/fast/borders/borderRadiusGroove02-expected.checksum:
  • platform/mac/fast/borders/borderRadiusGroove02-expected.png:
  • platform/mac/fast/borders/borderRadiusInset01-expected.checksum:
  • platform/mac/fast/borders/borderRadiusInset01-expected.png:
  • platform/mac/fast/borders/borderRadiusInvalidColor-expected.checksum:
  • platform/mac/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/mac/fast/borders/borderRadiusOutset01-expected.checksum:
  • platform/mac/fast/borders/borderRadiusOutset01-expected.png:
  • platform/mac/fast/borders/borderRadiusRidge01-expected.checksum:
  • platform/mac/fast/borders/borderRadiusRidge01-expected.png:
  • platform/mac/fast/borders/borderRadiusSolid01-expected.checksum:
  • platform/mac/fast/borders/borderRadiusSolid01-expected.png:
  • platform/mac/fast/borders/borderRadiusSolid02-expected.checksum:
  • platform/mac/fast/borders/borderRadiusSolid02-expected.png:
  • platform/mac/fast/borders/borderRadiusSolid03-expected.checksum:
  • platform/mac/fast/borders/borderRadiusSolid03-expected.png:
  • platform/mac/fast/borders/borderRadiusSolid04-expected.checksum:
  • platform/mac/fast/borders/borderRadiusSolid04-expected.png:
  • platform/mac/fast/borders/different-color-borders-expected.checksum: Added.
  • platform/mac/fast/borders/different-color-borders-expected.png: Added.
  • platform/mac/fast/borders/different-color-borders-expected.txt: Added.
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.checksum:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.png:
16:19 Changeset [63863] by beidson@apple.com
  • 19 edits
    2 adds in trunk

2010-07-21 Brady Eidson <beidson@apple.com>

Reviewed by Geoffrey Garen.

Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783

  • src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::registerURLSchemeAsLocal): (WebKit::WebSecurityPolicy::registerURLSchemeAsNoAccess): (WebKit::WebSecurityPolicy::registerURLSchemeAsSecure):

2010-07-21 Brady Eidson <beidson@apple.com>

Reviewed by Geoffrey Garen.

Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783

  • Api/qwebpage.cpp: (QWebPage::acceptNavigationRequest):
  • Api/qwebsecurityorigin.cpp: (QWebSecurityOrigin::addLocalScheme): (QWebSecurityOrigin::removeLocalScheme): (QWebSecurityOrigin::localSchemes):

2010-07-21 Brady Eidson <beidson@apple.com>

Reviewed by Geoffrey Garen.

Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783

  • WebView.cpp: (WebView::registerURLSchemeAsLocal): (WebView::registerURLSchemeAsSecure):

2010-07-21 Brady Eidson <beidson@apple.com>

Reviewed by Geoffrey Garen.

Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783

  • WebView/WebView.mm: (+[WebView _registerURLSchemeAsSecure:]): (+[WebView registerURLSchemeAsLocal:]):

2010-07-21 Brady Eidson <beidson@apple.com>

Reviewed by Geoffrey Garen.

Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783

No new tests. (No change in behavior)

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent): (WebCore::FrameLoader::loadFrameRequest):


  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canLoad): (WebCore::SecurityOrigin::isLocal):
  • page/SecurityOrigin.h:


  • platform/SchemeRegistry.cpp: Added. (WebCore::localSchemes): (WebCore::secureSchemes): (WebCore::schemesWithUniqueOrigins): (WebCore::SchemeRegistry::registerURLSchemeAsLocal): (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal): (WebCore::SchemeRegistry::localURLSchemes): (WebCore::SchemeRegistry::shouldTreatURLAsLocal): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal): (WebCore::SchemeRegistry::registerURLSchemeAsNoAccess): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess): (WebCore::SchemeRegistry::registerURLSchemeAsSecure): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure):
  • platform/SchemeRegistry.h: Added.
16:16 Changeset [63862] by cmarrin@apple.com
  • 3 edits in trunk/WebCore

2010-07-21 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Assertion failure in AnimationBase::updateStateMachine() coming out of paused state
https://bugs.webkit.org/show_bug.cgi?id=37993


Added logic to properly handle pausing and resuming when in the
AnimationStateStartWaitStyleAvailable state. This was causing an
assert when going out of the pause state because the paused flag
was not set.


The fix is a straightforward implementation, going into a new
AnimationStatePausedWaitStyleAvailable state and setting the paused
flag (actually setting the m_pauseTime variable to something other
than -1). Also added handling of the new state, both when the
"style available" callback comes in while in this state and when
unpausing while in this state.


For now a LayoutTest is not possible since there's no way to go in
and out of the pause state. I've opened https://bugs.webkit.org/show_bug.cgi?id=42790
to track this.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
  • page/animation/AnimationBase.h: (WebCore::AnimationBase::):
15:59 Changeset [63861] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

2010-07-21 Peter Beverloo <peter@lvp-media.com>

Reviewed by Darin Adler.

Updated six more layout tests from -khtml to -webkit
https://bugs.webkit.org/show_bug.cgi?id=42788

This is a follow up to r63854 and r63857

  • css3/khtml-background-size-0x0-bmp.html:
  • editing/deleting/delete-3959464-fix.html:
  • editing/deleting/delete-and-undo.html:
  • editing/deleting/delete-at-paragraph-boundaries-001.html:
  • editing/deleting/delete-at-paragraph-boundaries-002.html:
  • editing/deleting/delete-at-paragraph-boundaries-003.html:
15:46 Changeset [63860] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-07-21 Adam Barth <abarth@webkit.org>

Skip html5lib/runner.html on these platforms because the
<keygen> element creates a different DOM. I need to
investigate why they're getting a different DOM, but I don't
have time to do that right now.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
15:12 Changeset [63859] by scherkus@chromium.org
  • 6 edits
    2 adds in trunk

2010-07-21 Bo Liu <boliu@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add chromium WebMediaPlayer to PlatformMedia
https://bugs.webkit.org/show_bug.cgi?id=41295

  • platform/graphics/MediaPlayer.h: (WebCore::PlatformMedia::):

2010-07-21 Bo Liu <boliu@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add chromium WebMediaPlayer to PlatformMedia
https://bugs.webkit.org/show_bug.cgi?id=41295

  • WebKit.gyp:
  • public/WebMediaElement.h: Added.
  • src/WebMediaElement.cpp: Added. (WebKit::WebMediaElement::player): (WebKit::WebMediaElement::WebMediaElement): (WebKit::WebMediaElement::operator=): (WebKit::WebMediaElement::operator PassRefPtr<HTMLMediaElement>):
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::fromMediaElement): (WebKit::WebMediaPlayerClientImpl::mediaPlayer): (WebKit::WebMediaPlayerClientImpl::platformLayer): (WebKit::WebMediaPlayerClientImpl::platformMedia):
  • src/WebMediaPlayerClientImpl.h:
14:41 Changeset [63858] by abarth@webkit.org
  • 11 edits
    7 adds in trunk/LayoutTests

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Pull HTML5lib test suite from upstream
https://bugs.webkit.org/show_bug.cgi?id=42776

Grab a bunch of new tests from html5lib upstream. Also, upstream
tweaked some of our tests, so I've updated our tests to match the
upstream tweaks.

  • html5lib/resources/adoption01.dat:
  • html5lib/resources/doctype01.dat:
  • html5lib/resources/scripted/adoption01.dat: Added.
  • html5lib/resources/scripted/webkit01.dat: Added.
  • html5lib/resources/tests1.dat:
  • html5lib/resources/tests17.dat: Added.
  • html5lib/resources/tests18.dat: Added.
  • html5lib/resources/tests19.dat: Added.
  • html5lib/resources/tests2.dat:
  • html5lib/resources/tests20.dat: Added.
  • html5lib/resources/tricky01.dat:
  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
  • html5lib/webkit-resumer-expected.txt:
14:16 Changeset [63857] by tony@chromium.org
  • 15 edits in trunk/LayoutTests

2010-07-21 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

convert more layout tests from -khtml to -webkit
https://bugs.webkit.org/show_bug.cgi?id=42786

This is a follow up to r63854.

  • fast/backgrounds/size/backgroundSize02.html:
  • fast/backgrounds/size/backgroundSize03.html:
  • fast/backgrounds/size/backgroundSize04.html:
  • fast/backgrounds/size/backgroundSize05.html:
  • fast/backgrounds/size/backgroundSize06.html:
  • fast/backgrounds/size/backgroundSize07.html:
  • fast/backgrounds/size/backgroundSize08.html:
  • fast/backgrounds/size/backgroundSize09.html:
  • fast/backgrounds/size/backgroundSize10.html:
  • fast/backgrounds/size/backgroundSize11.html:
  • fast/backgrounds/size/backgroundSize12.html:
  • fast/backgrounds/size/backgroundSize13.html:
  • fast/backgrounds/size/backgroundSize14.html:
  • fast/backgrounds/size/backgroundSize15.html:
14:07 Changeset [63856] by simon.fraser@apple.com
  • 6 edits in trunk

2010-07-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Composited layers don't scroll in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42771

Prep work: FrameView::scrollPositionChanged() sounds like a generic "did scroll" bottleneck,
but this is deceiving. It's only every called on one platform (Mac) when the NSScrollView gets
scrolled, so rename it to FrameView::scrollPositionChangedViaPlatformWidget().

  • WebCore.exp.in:
  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
  • page/FrameView.h:
13:54 Changeset [63855] by aroben@apple.com
  • 2 edits in trunk/WebKit2

Handle broken pipes in more places in CoreIPC

Fixes <http://webkit.org/b/42784> Assertion failure in
Connection::readEventHandler when WebKitTestRunner exits

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::readEventHandler): Check for a broken pipe
whenever we call ::PeekNamedPipe.

13:39 Changeset [63854] by commit-queue@webkit.org
  • 38 edits
    2 adds in trunk

2010-07-21 Peter Beverloo <peter@lvp-media.com>

Reviewed by Eric Carlson.

Removed support for the -khtml CSS vendor prefix and limit the
-apple prefix to two properties (dashboard-region and line-clamp).

Listed properties in these updated have been changed to -webkit.

  • fast/block/positioning/height-change.html: -apple-box
  • fast/block/positioning/resources/window-height-change-frame-flex.html: -apple-box
  • fast/borders/border-image-omit-right-slice.html: -khtml-border-image
  • fast/css/apple-prefix.html: -khtml-box-orient
  • fast/css/legacy-opacity-styles-expected.txt: -*-opacity
  • fast/css/legacy-opacity-styles.html: -*-opacity
  • fast/css/limited-vendor-prefix-behavior-expected.txt: Added.
  • fast/css/limited-vendor-prefix-behavior.html: Added.
  • fast/flexbox/001.html: -khtml-box-flex
  • fast/flexbox/002.html: -khtml-box, -khtml-box-align, -khtml-box-orient
  • fast/flexbox/003.html: -khtml-box, -khtml-box-align, -khtml-box-orient
  • fast/flexbox/004.html: -khtml-box
  • fast/flexbox/005.html: -khtml-box
  • fast/flexbox/006.html: -khtml-box
  • fast/flexbox/007.html: -khtml-box
  • fast/flexbox/008.html: -khtml-box
  • fast/flexbox/009.html: -khtml-box
  • fast/flexbox/010.html: -khtml-box
  • fast/flexbox/011.html: -khtml-box, -khtml-box-flex
  • fast/flexbox/012.html: -khtml-box, -khtml-box-orient, -khtml-box-align
  • fast/flexbox/013.html: -khtml-box, -khtml-box-flex
  • fast/flexbox/014.html: -khtml-box, -khtml-box-orient, -khtml-box-flex
  • fast/flexbox/015.html: -khtml-box, -khtml-box-flex, -khtml-box-flex
  • fast/flexbox/016.html: -khtml-box-flex, -khtml-box, -khtml-box-orient
  • fast/flexbox/017.html: -khtml-box, -khtml-box-orient, -webkit-box-pack, -khtml-box-direction
  • fast/flexbox/018.html: -khtml-box, -khtml-box-orient, -khtml-box-pack
  • fast/flexbox/019.html: -khtml-box, -khtml-box-pack, -khtml-box-orient
  • fast/flexbox/020.html: -khtml-box, -khtml-box-flex-group, -khtml-box-flex
  • fast/flexbox/021.html: -khtml-box, -khtml-box-flex
  • fast/flexbox/022.html: -khtml-box, -khtml-box-flex
  • fast/flexbox/023.html: -khtml-box
  • fast/flexbox/024.html: -khtml-box, -khtml-box-orient
  • fast/flexbox/025.html: -khtml-box, -khtml-box-flex
  • fast/flexbox/026.html: -khtml-box, -khtml-box-flex
  • fast/flexbox/child-flexing.html: -khtml-box, -khtml-box-align, -khtml-box-orient
  • fast/repaint/flexible-box-overflow-horizontal.html: -khtml-box, -khtml-box-align, -khtml-box-orient
  • fast/repaint/flexible-box-overflow.html: -khtml-box, -khtml-box-align, -khtml-box-orient

2010-07-21 Peter Beverloo <peter@lvp-media.com>

Reviewed by Eric Carlson.

Removed support for the -khtml CSS vendor prefix and limit the
-apple prefix to two properties (dashboard-region and line-clamp).

Test: fast/css/limited-vendor-prefix-behavior.html

  • css/CSSParser.cpp: (WebCore::cssPropertyID):
13:30 Changeset [63853] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.

13:25 Changeset [63852] by aroben@apple.com
  • 2 edits in trunk/WebKit2

Teach CoreIPC how to handle messages that are larger than the pipe's buffer

::GetOverlappedResult and ::ReadFile can fail with ERROR_MORE_DATA
when there is more data available on the pipe than was requested in
the read operation. In those cases, the appropriate response is to
perform another read operation to read the extra data. We now do this.

Also, MSDN says that, because we are doing asynchronous read
operations, we should not pass a pointer to ::ReadFile to find out how
many bytes were read. Instead we should always call
::GetOverlappedResult to find this out. I've changed
Connection::readEventHandler to have a single loop that calls
::GetOverlappedResult and ::ReadFile in alternation, rather than
sometimes calling ::ReadFile multiple times in a row, to satisfy this
requirement.

In order to simplify the logic in this function, I've made us request
only a single byte from the pipe when there are no messages already in
the pipe. (Previously we were requesting 4096 bytes in this case.)
This allows us not to have to consider the case where the received
message is smaller than our read buffer. If we decide that this has a
negative impact on performance, we can of course change it. I've
mitigated this somewhat by using ::PeekNamedMessage to find out the
size of the next message in the pipe (if any), so that we can read it
all in one read operation.

Fixes <http://webkit.org/b/42710> <rdar://problem/8197571> Assertion
in Connection::readEventHandler when launching WebKitTestRunner

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::readEventHandler): Put the call to
::GetOverlappedResult in the same loop as ::ReadFile so that we will
call them alternately. If ::GetOverlappedResult fails with
ERROR_MORE_DATA, use ::PeekNamedPipe to determine the size of the rest
of the message, then read it from the pipe. After dispatching the
message, use ::PeekNamedPipe to find out the size of the next message
in the pipe so we can read it all in one operation. If there's no
message in the pipe, we'll request just a single byte of the next
message that becomes available, and Windows will tell us when the rest
of the message is ready. If ::ReadFile fails with ERROR_MORE_DATA it
means there is data available now even though we didn't think there
was any. We go back to the top of the loop in this case and call
::GetOverlappedResult again to retrieve the available data.

13:23 Changeset [63851] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix the last tree HTML5 tree builder crashes
https://bugs.webkit.org/show_bug.cgi?id=42773

This patch changes the internal representation of a bookmark to handle
the case where one of the adjecent entries in the list of active
formatting elements is actually a marker.

After this patch, the bookmarking mechanism isn't as general, but it
works for the cases we need in the adoption agency.

Also, after this patch, there aren't any more known crashers in the
HTML5 tree builder. :)

  • html/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::bookmarkFor): (WebCore::HTMLFormattingElementList::swapTo):
  • html/HTMLFormattingElementList.h: (WebCore::HTMLFormattingElementList::Bookmark::Bookmark): (WebCore::HTMLFormattingElementList::Bookmark::moveToAfter): (WebCore::HTMLFormattingElementList::Bookmark::hasBeenMoved): (WebCore::HTMLFormattingElementList::Bookmark::mark): (WebCore::HTMLFormattingElementList::first):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
13:10 Changeset [63850] by weinig@apple.com
  • 10 edits in trunk

Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages

Reviewed by Anders Carlsson.

WebKit2:

  • Convert injected bundle UIClient functions to will-style, at least until we establish more concrete use cases for them past the TestRunner.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::willAddMessageToConsole):
(WebKit::InjectedBundlePageUIClient::willSetStatusbarText):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptAlert):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptConfirm):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptPrompt):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::addMessageToConsole):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::setStatusbarText):

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_willAddMessageToConsole):
(WTR::InjectedBundlePage::_willSetStatusbarText):
(WTR::InjectedBundlePage::_willRunJavaScriptAlert):
(WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

LayoutTests:

  • platform/mac-wk2/Skipped:
12:38 Changeset [63849] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-07-21 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Disable overzealous ASSERT
https://bugs.webkit.org/show_bug.cgi?id=42775

No new tests because no changed functionality.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
12:27 Changeset [63848] by simon.fraser@apple.com
  • 3 edits in trunk/WebKit2

2010-07-21 Simon Fraser <simon.fraser@apple.com>

Windows build fix.

Need to supply implementations of PageClient::pageDidEnterAcceleratedCompositing()
and pageDidLeaveAcceleratedCompositing() for WebView on Windows.

  • UIProcess/win/WebView.cpp: (WebKit::WebView::pageDidEnterAcceleratedCompositing): (WebKit::WebView::pageDidLeaveAcceleratedCompositing):
  • UIProcess/win/WebView.h:
11:38 Changeset [63847] by yael.aharon@nokia.com
  • 5 edits in trunk/WebCore

2010-07-21 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Crash in Notification::disconnectFrame() triggered by Frame::lifeSupportTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=42534

Call NotificationsCenter::disconnectFrame() when the frame is disconnected from the page.
Calling it from the destructor of Frame is too late and sometimes causes access violation.
I was not able to reproduce this crash, so did not add new tests.
This patch is based on the error reported in
http://code.google.com/p/chromium/issues/detail?id=49323.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::pageDestroyed):
  • page/DOMWindow.h:
  • page/Frame.cpp: (WebCore::Frame::pageDestroyed):
11:16 Changeset [63846] by andersca@apple.com
  • 5 edits in trunk

Don't assert when clicking on a plug-in in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42762

Reviewed by Sam Weinig.

WebCore:

Remove a now invalid assert and return false instead.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

WebKit2:

Add stub for PluginView::handleEvent.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):

  • WebProcess/Plugins/PluginView.h:
11:14 Changeset [63845] by antonm@chromium.org
  • 7 edits in trunk/WebCore

2010-07-21 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Revert r60670 as it introduced a regression: in some cases named children couldn't be retrieved.
https://bugs.webkit.org/show_bug.cgi?id=42766

See http://code.google.com/p/chromium/issues/detail?id=48804 for more details.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::namedPropertyDeleter): (WebCore::V8HTMLDocument::namedPropertyGetter): (WebCore::V8HTMLDocument::indexedPropertyGetter): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
10:53 Changeset [63844] by eric.carlson@apple.com
  • 16 edits in trunk

2010-07-21 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update plug-in proxy backed <video> and <audio> elements.
https://bugs.webkit.org/show_bug.cgi?id=42770
<rdar://problem/7963467>

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged): Only call m_player->setControls when the 'controls' attribute changes. (WebCore::HTMLMediaElement::createRenderer): (WebCore::HTMLMediaElement::attach): If we have a proxy widget, call the WebFrameLoaderClient's 'hide' and 'show' methods for the media proxy plug-in to make sure we remove and re-add the plug-in's view to the global list of plugin views. (WebCore::HTMLMediaElement::createMediaPlayerProxy): Bail if m_proxyWidget is non-NULL
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::hideMediaPlayerProxyPlugin): Empty stub method. (WebCore::EmptyFrameLoaderClient::showMediaPlayerProxyPlugin): Ditto.
  • loader/FrameLoader.cpp:
  • loader/FrameLoaderClient.h:
  • loader/SubframeLoader.cpp: (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): Always set m_containsPlugIns in loadMediaPlayerProxyPlugin(), even when we don't have a renderer. (WebCore::FrameLoader::hideMediaPlayerProxyPlugin): New, call hideMediaPlayerProxyPlugin. (WebCore::FrameLoader::showMediaPlayerProxyPlugin): New, call showMediaPlayerProxyPlugin.
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setControls): (WebCore::MediaPlayer::setControls): New, pass through to media engine. (WebCore::MediaPlayer::enterFullscreen): Ditto. (WebCore::MediaPlayer::exitFullscreen): Ditto.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setControls): (WebCore::MediaPlayerPrivateInterface::enterFullscreen): (WebCore::MediaPlayerPrivateInterface::exitFullscreen):

2010-07-21 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update plug-in proxy backed <video> and <audio> elements.
https://bugs.webkit.org/show_bug.cgi?id=42770
<rdar://problem/7963467>

  • Plugins/WebPluginController.h:
  • Plugins/WebPluginController.mm: (-[WebPluginController dealloc]): Release _viewsNotInDocument. (-[WebPluginController stopAllPlugins]): Stop plug-ins not in the document. (-[WebPluginController pluginViewCreated:]): New, add a View (plug-in) to _viewsNotInDocument. (+[WebPluginController pluginViewHidden:]): New, remove the view (plug-in) from pluginViews. (-[WebPluginController addPlugin:]): Remove the new plug-in from _viewsNotInDocument.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Remove PLUGIN_PROXY_FOR_VIDEO code, the media player proxy plug-in should never be allocated by this method. (WebFrameLoaderClient::createMediaPlayerProxyPlugin): New, allocate a media player proxy.
  • WebView/WebView.mm: (-[WebView _videoProxyPluginForMIMEType:]): New. Identical to _pluginForMIMEType except it doesn't consider the arePlugInsEnabled preference.
  • WebView/WebViewInternal.h:
10:51 Changeset [63843] by simon.fraser@apple.com
  • 25 edits in trunk/WebKit2

2010-07-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Get accelerated compositing working with webkit2
https://bugs.webkit.org/show_bug.cgi?id=41084

Hook up dynamic DrawingArea switching, so that when the WebProcess hits a page
that requires accelerated compositing, we switch to the LayerBackedDrawingArea.

  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: (DrawingAreaProxyMessage::):
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: (WebPageProxyMessage::):
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::pageDidEnterAcceleratedCompositing): (WebKit::PageClientImpl::pageDidLeaveAcceleratedCompositing):
  • UIProcess/API/mac/WKView.mm: (-[WKView _startAcceleratedCompositing:]): (-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaProxy::]): (-[WKView _pageDidEnterAcceleratedCompositing]): (-[WKView _pageDidLeaveAcceleratedCompositing]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveSyncMessage):
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::): (WebKit::DrawingAreaProxy::type):
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::didSetSize): (WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage): (WebKit::LayerBackedDrawingAreaProxy::didReceiveSyncMessage):
  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setDrawingArea): (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::didEnterAcceleratedCompositing): (WebKit::WebPageProxy::didLeaveAcceleratedCompositing):
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::attachRootGraphicsLayer):
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h: (WebKit::ChunkedUpdateDrawingArea::attachCompositingContext): (WebKit::ChunkedUpdateDrawingArea::setRootCompositingLayer):
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::): (WebKit::DrawingArea::type):
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::setNeedsDisplay): (WebKit::LayerBackedDrawingArea::setSize): (WebKit::LayerBackedDrawingArea::didUpdate): (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): (WebKit::WebPage::enterAcceleratedCompositingMode): (WebKit::WebPage::exitAcceleratedCompositingMode):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::detachCompositingContext): (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):
10:46 Changeset [63842] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-07-21 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Make more members of CSSStyleSelector private.
https://bugs.webkit.org/show_bug.cgi?id=42757

No change in behavior, so no new tests.

  • css/CSSStyleSelector.h: Made a publicly-unused methods private.
10:44 Changeset [63841] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-07-21 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

Avoid crashing during find-in-page when |view| is NULL.
https://bugs.webkit.org/show_bug.cgi?id=42760

There are no layout tests because we don't have a repro case
to work with, so this is a speculative fix based on crash dump
diagnosis. See bug for details.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::shouldScopeMatches):
10:36 Changeset [63840] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-21 Tony Chang <tony@chromium.org>

Not reviewed, updating chromium test expectations.

Remove expectations for tests that were moved to platform/mac in r63616.

  • platform/chromium/test_expectations.txt:
10:32 Changeset [63839] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-21 Tony Chang <tony@chromium.org>

Not reviewed, updating chromiumg test expectations.

  • platform/chromium/test_expectations.txt: Marking remember-bad-password.html and

401-logout.php as failing.

10:30 Changeset [63838] by dglazkov@chromium.org
  • 2 edits
    4 adds in trunk/WebKitSite

2010-07-21 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Add a diagram explaining how a DOM element is attached to the site.
https://bugs.webkit.org/show_bug.cgi?id=42763

  • coding/dom-element-attach.html: Added.
  • coding/images/dom-element-attach-large.png: Added.
  • coding/images/dom-element-attach-small.png: Added.
  • coding/images/dom-element-attach.graffle: Added.
  • coding/technical-articles.html: Added a link to the page with the diragram.
10:26 Changeset [63837] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-07-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: consider jQuery object to be of array nature.

https://bugs.webkit.org/show_bug.cgi?id=42758

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
10:20 Changeset [63836] by ap@apple.com
  • 5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=42717
<rdar://problem/7062824> A wrong password entered for site or proxy auth remains in WebCore
credential storage, and is sent with subsequent requests

WebCore:

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Don't use that direct a copy/paste, oops!

LayoutTests:

  • platform/gtk/Skipped:
  • platform/qt/Skipped: Skip the new tests, they don't pass.
09:55 Changeset [63835] by simon.fraser@apple.com
  • 6 edits in trunk/WebCore

2010-07-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

When GraphicsLayer::contentsOrientation() is CompositingCoordinatesBottomUp, need to flip repaint rects
https://bugs.webkit.org/show_bug.cgi?id=42662

If the contentsOrientation() on a GraphicsLayer is CompositingCoordinatesBottomUp, then we
need to flip the rects passed to setNeedsDisplayInRect:.

Avoid writing this code twice by making a bare function to share code
between WebLayer and WebTiledLayer. Convert the existing +drawContents:ofLayer:intoContext:
class method into a bare function, because the Obj-C calling overhead doesn't buy us anything.

Take out an assertion in GraphicsLayerCA::updateContentsTransform() that is not
correct.

No new tests because no layers use bottom-up contents at present.

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateContentsTransform):
  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents): (setLayerNeedsDisplayInRect): (-[WebLayer setNeedsDisplayInRect:]): (-[WebLayer drawInContext:]):
  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplayInRect:]): (-[WebTiledLayer drawInContext:]):
09:42 Changeset [63834] by ap@apple.com
  • 6 edits
    7 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=42717
<rdar://problem/7062824> A wrong password entered for site or proxy auth remains in WebCore
credential storage, and is sent with subsequent requests

Tests: http/tests/security/401-logout/401-logout.php

http/tests/xmlhttprequest/remember-bad-password.html

  • platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::remove):
  • platform/network/CredentialStorage.h: Added a way to remove stored credentials for a given protection space.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Remove stored credentials if they didn't work the first time.
09:39 Changeset [63833] by sfalken@apple.com
  • 13 edits in trunk

JavaScriptCore: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211743> JavaScriptCore needs to link against unversioned ICU

Reviewed by Adam Roben.

Dynamically create a new header, ICUVersion.h, as part of build-generated-files.sh.
Header contains a preprocessor define (U_DISABLE_RENAMING) indicating to ICU whether the ICU API
should be namespaced with the current ICU version number. Proper value is determined
by checking for the presence of libicuuc.lib, the unversioned copy of ICU.

To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.

Since the versioned and unversioned ICU have different filenames (libicuuc.lib vs icuuc.lib)
we copy the ICU lib to an intermediate location under obj with a common name. This
allows us to link properly with either without adding a new build configuration.

Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.

  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Generate ICUVersion.h
  • JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Add forced include of ICUVersion.h.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops:

Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.

Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.

WebCore: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU

Reviewed by Adam Roben.

To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.

  • WebCore.vcproj/WebCore.vcproj:

Add forced include of ICUVersion.h.

  • WebCore.vcproj/WebCoreCommon.vsprops: Add forced include of ICUVersion.h.

WebKit/win: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU

Reviewed by Adam Roben.

To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.

  • WebKit.vcproj/WebKit.vcproj: Add forced include of ICUVersion.h.

WebKit2: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU

Reviewed by Adam Roben.

To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.

Since the versioned and unversioned ICU have different filenames (libicuuc.lib vs icuuc.lib)
we copy the ICU lib to an intermediate location under obj with a common name. This
allows us to link properly with either without adding a new build configuration.

  • win/WebKit2Common.vsprops:

Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.

09:31 Changeset [63832] by aroben@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix

  • Shared/win/UpdateChunk.h:

(WebKit::UpdateChunk::isEmpty): Added to match the Mac definition.

09:04 Changeset [63831] by andersca@apple.com
  • 1 edit
    1 add in trunk/WebKit2

Land file I forgot to add.

  • WebProcess/com.apple.WebProcess.sb: Added.
09:01 Changeset [63830] by aroben@apple.com
  • 2 edits
    1 add in trunk/WebKit2

Move WebKit2WebProcess's settings to a vsprops file

Fixes <http://webkit.org/b/42751> WebKit2WebProcess should use vsprops
files

Reviewed by Darin Adler.

  • win/WebKit2WebProcess.vcproj: Moved settings from here...
  • win/WebKit2WebProcessCommon.vsprops: ...to here.
09:01 Changeset [63829] by aroben@apple.com
  • 5 edits in trunk

Give InjectedBundle our standard set of configurations (minus the *_Cairo variants)

InjectedBundle's Debug_All configuration was the same as is Debug
configuration, and it was missing a Debug_Internal configuration.

Fixes <http://webkit.org/b/42749> InjectedBundle's build
configurations are screwy

Reviewed by Darin Adler.

WebKit/win:

Update WebKit.sln for InjectedBundle's Debug_Internal configuration

  • WebKit.vcproj/WebKit.sln: Build the Debug_Internal variant of

InjectedBundle when we're using the Debug_Internal solution
configuration.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added

debug_internal.vsprops and debug_all.vsprops to the Debug_All
configuration. Added a Debug_Internal configuration.

  • WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal

variant of InjectedBundle when we're using the Debug_Internal solution
configuration.

09:01 Changeset [63828] by aroben@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Move InjectedBundle's settings to a vsprops file

This will make it easier to change settings for all configurations,
and to add new configurations.

Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
files

Reviewed by Darin Adler.

  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.

Moved settings here...

  • WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from

here.

09:00 Changeset [63827] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Add MiniBrowser to WebKit.sln

It is the last project to build.

Fixes <http://webkit.org/b/42747> build-webkit should build
MiniBrowser

Reviewed by Darin Adler.

  • WebKit.vcproj/WebKit.sln: Added MiniBrowser, and made it depend on

WebKitTestRunner.

08:53 Changeset [63826] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Give MiniBrowser our standard set of configurations (minus the *_Cairo variants)

MiniBrowser already had a configuration called "Release", but it was
using mostly the same settings as Debug. And its Debug configuration
was using the settings that Debug_Internal should be using.

Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
are screwy

Reviewed by Darin Adler.

  • MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from

the Debug configuration. Remove debug.vsprops and
debug_internal.vsprops from the Release configuration and replace them
with release.vsprops. Added Debug_Internal and Debug_All
configurations.

08:53 Changeset [63825] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Reviewed and tweaked by Anders Carlsson and Sam Weinig.

Patch by Ivan Krstić <ike@apple.com> on 2010-07-20
Put WebProcess in a sandbox. All of the following changes are
Mac-only.
<rdar://problem/7865269>

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
Send Sandbox extension for injected bundle to WebProcess.

  • WebKit2.xcodeproj/project.pbxproj:

Add Sandbox profile to Resources for WebProcess.

  • WebProcess/InjectedBundle/InjectedBundle.h:

New function InjectedBundle::setSandboxToken.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load):
Consume Sandbox token for the bundle if present.

(WebKit::InjectedBundle::setSandboxToken):
Set Sandbox token for the bundle.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::loadInjectedBundle):
Extra function parameter for Sandbox token.

(WebKit::WebProcess::didReceiveMessage):
Pass Sandbox token to loadInjectedBundle().

  • WebProcess/WebProcess.h:

Extra function parameter for Sandbox token in loadInjectedBundle().

  • WebProcess/com.apple.WebProcess.sb: Added.

Sandbox profile for WebProcess.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):
Initialize Sandbox, exit on failure.

08:53 Changeset [63824] by aroben@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Move MiniBrowser's settings to a vsprops file

This will make it easier to change settings for all configurations,
and to add new configurations.

MiniBrowser should use vsprops files
https://bugs.webkit.org/show_bug.cgi?id=42745

Reviewed by Darin Adler.

  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved

settings here...

  • MiniBrowser/MiniBrowser.vcproj: ...from here.
08:53 Changeset [63823] by aroben@apple.com
  • 3 edits in trunk/WebKitTools

Fix compiler warnings when building MiniBrowser

Also cleaned up the .vcproj a bit.

Fixes <http://webkit.org/b/42743>.

Reviewed by Darin Adler.

  • MiniBrowser/MiniBrowser.vcproj: Removed all settings that are

already defined in .vsprops files. This also fixes a warning about
/EDITANDCONTINUE being incompatible with /SAFESEH.

  • MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so

that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
being redefined. (I think this will also get us closer to building
with VC++ Express.)

08:51 Changeset [63822] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-07-21 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Serialization to JSON in InspectorValue works incorrect
if comma is assigned as decimal separator. Windows with Russian locale.
https://bugs.webkit.org/show_bug.cgi?id=42755

  • inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
08:43 Changeset [63821] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Handle WKView visibility changes
<rdar://problem/7891077>

Reviewed by Dan Bernstein.

  • Shared/mac/UpdateChunk.h:

(WebKit::UpdateChunk::isEmpty):
Add convenience getter.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
Reorder the calls to _updateActiveState and _updateVisibility based on whether the view is moved to
a window or away from a window.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
Initialize m_forceRepaintWhenResumingPainting to false.

(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
Pass the m_forceRepaintWhenResumingPainting along to the DrawingAreaMessage::ResumePainting message.

(WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize):
Don't try to paint empty update chunks.

(WebKit::ChunkedUpdateDrawingAreaProxy::update):
Don't paint the update chunk if we're not visible. Instead, make sure that the entire page is being redrawn
when its shown again.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
(WebKit::ChunkedUpdateDrawingArea::display):
(WebKit::ChunkedUpdateDrawingArea::suspendPainting):
Rename m_shouldPaint to m_isPaintingSuspended and invert its logic.

(WebKit::ChunkedUpdateDrawingArea::scheduleDisplay):
Don't schedule a display timer if the dirty rect is empty.

(WebKit::ChunkedUpdateDrawingArea::setSize):
If painting is suspended, just send back an empty update chunk in the DidSetSize message.

(WebKit::ChunkedUpdateDrawingArea::resumePainting):
If forceRepaint is true, repaint the entire drawing area.

08:14 Changeset [63820] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2010-07-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

CSS rotation transform can cause elements with certain styles to vanish during rotation.
https://bugs.webkit.org/show_bug.cgi?id=42579

Remove some untested, broken code that, as far as I can tell, could never get hit.
Use the correct rect for the PaintInfo so that zero-sized elements with overflow:hidden
but a border paint correctly.

Test: compositing/overflow/zero-size-overflow.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
08:12 Changeset [63819] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-21 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Laszlo Gombos.

[QT] Leak and few more fixes to qt port of geolocation
https://bugs.webkit.org/show_bug.cgi?id=42753

Fixes memory leak and default values set to attributes.

Memory leak fix no new test case added.

  • platform/qt/GeolocationServiceQt.cpp: Added. (WebCore::GeolocationServiceQt::~GeolocationServiceQt): (WebCore::GeolocationServiceQt::positionUpdated):
08:10 Changeset [63818] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578

  • platform/qt/Skipped: Unskip tests.
06:56 Changeset [63817] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-21 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Added automatic sqlite extraction for Symbian to QtWebKit.

Also added sqlite detection in case sqlite is not present in the SDK.
This is possible if WebKit is compiled standalone.

The inclusion part is a consequence of commit c578c6c1d6d in the Qt
repository. It will not work on Qt versions < 4.7.1, but that is ok,
since the only build system it will affect is marked as experimental
in the whole 4.7 series.

  • WebCore.pro:
06:48 Changeset [63816] by leandro@webkit.org
  • 1 add in trunk/WebKit/efl/ChangeLog

2010-07-21 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Creating ChangeLog for the EFL port.

  • efl/ChangeLog: Added.
05:53 Changeset [63815] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Associate elements with the active form
https://bugs.webkit.org/show_bug.cgi?id=42728

This patch fixes fast/forms/formmove3.html. The test still doesn't
pass due to some render tree differences, but it works as intended now.

To fix this test, I needed to deviate from the spec slight. Minefield
seems to have the same deviation:

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::takeForm): (WebCore::HTMLConstructionSite::setForm): (WebCore::HTMLConstructionSite::createHTMLElement):
  • html/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::form):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):
05:38 Changeset [63814] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The adoption agency doesn't properly attach()
https://bugs.webkit.org/show_bug.cgi?id=42727

The adoption agency is transliterated rather directly from the spec,
but it misses some of the WebKit-specific machinations, such as
attaching to the render tree.

The algorithm, as written, is a minor layer violation. I've added to
the problem by calling attach() from HTMLTreeBuilder (even though
that's the job of the HTMLConstructionSite). We'll need to clean up
the layering a bit at some point.

This patch half fixes fast/forms/formmove3.html. Hopefully I'll finish
fixing it in the next patch.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
05:22 Changeset [63813] by abarth@webkit.org
  • 4 edits in trunk

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

<input> elements with no type attribute should be foster parented
https://bugs.webkit.org/show_bug.cgi?id=42725

Test progression.

  • html5lib/runner-expected-html5.txt:

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

<input> elements with no type attribute should be foster parented
https://bugs.webkit.org/show_bug.cgi?id=42725

Fix spec transcription error.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable):
05:05 Changeset [63812] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-07-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix fast/css/last-child-style-sharing.html
https://bugs.webkit.org/show_bug.cgi?id=42731

Prior to this patch, we weren't calling finishParsingChildren on the
body element. We need a more systematic way of catching these bugs.

  • html/HTMLElementStack.cpp: (WebCore::HTMLElementStack::popAll):
  • html/HTMLElementStack.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
04:18 Changeset [63811] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

2010-07-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector/debugger-pause-in-eval-script.html fails on Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=42735

  • inspector/debugger-pause-in-eval-script.html:
  • platform/chromium/test_expectations.txt:
03:42 Changeset [63810] by commit-queue@webkit.org
  • 10 edits in trunk

2010-07-21 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Runtime feature switch for device orientation
https://bugs.webkit.org/show_bug.cgi?id=42265

Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.

  • WebCore.vcproj/WebCoreCommon.vsprops: Add bindings/generic to include path.
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled): (WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners):
  • page/DOMWindow.idl:
  • page/Page.cpp: (WebCore::Page::Page):

2010-07-21 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Runtime feature switch for device orientation
https://bugs.webkit.org/show_bug.cgi?id=42265

Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceOrientation): (WebKit::WebRuntimeFeatures::isDeviceOrientationEnabled):
02:57 Changeset [63809] by zherczeg@webkit.org
  • 4 edits
    80 adds in trunk

WebCore: Reviewed Nikolas Zimmermann.

SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244

The implementation was done by Nikolas Zimmermann before, but
there was no tests for it. The patch also implements the simple
setFilterRes method.

Tests: svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr.html

svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr.html
svg/dynamic-updates/SVGFilterElement-dom-height-attr.html
svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr.html
svg/dynamic-updates/SVGFilterElement-dom-width-attr.html
svg/dynamic-updates/SVGFilterElement-dom-x-attr.html
svg/dynamic-updates/SVGFilterElement-dom-y-attr.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-height-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-width-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-x-prop.html
svg/dynamic-updates/SVGFilterElement-svgdom-y-prop.html

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::setFilterRes):
(WebCore::SVGFilterElement::svgAttributeChanged):
(WebCore::SVGFilterElement::childrenChanged):

  • svg/SVGFilterElement.h:

LayoutTests: SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244

Reviewed by Nikolas Zimmermann.

  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr.html: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr.html: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-height-attr.html: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr.html: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-width-attr.html: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-x-attr.html: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-dom-y-attr.html: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call.html: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop.html: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop.html: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop.html: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-height-prop.html: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop.html: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-width-prop.html: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-x-prop.html: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFilterElement-svgdom-y-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFilterElement-dom-filterRes-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-dom-filterUnits-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-dom-height-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-dom-primitiveUnits-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-dom-width-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-dom-x-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-dom-y-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterRes-call.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResX-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResY-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterUnits-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-height-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-primitiveUnits-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-width-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-x-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-y-prop.js: Added.

(executeTest):

02:38 Changeset [63808] by benm@google.com
  • 2 edits in trunk/WebCore

Unreviewed, build fix.

Forgot to update the role of HitTestRequest.h in
the xcode project after landing patch from
https://bugs.webkit.org/show_bug.cgi?id=39493

  • WebCore.xcodeproj/project.pbxproj: Make HitTestRequest.h

private so it can be included in WebKit by EventHandler.h
which is already private..

02:19 Changeset [63807] by benm@google.com
  • 6 edits
    2 adds in trunk

Touch events do not affect the :active CSS state
https://bugs.webkit.org/show_bug.cgi?id=39493

Reviewed by Steve Block.

WebCore:

Test: fast/events/touch/touch-active-state.html

  • WebCore.exp.in: Update exports for new signature of

hitTestResultAtPoint.

  • WebCore.order: ditto.
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::hitTestResultAtPoint): Pass the type

of the hit test to perform as a parameter with a default
value rather than harcoding it in the function body.

(WebCore::EventHandler::handleMouseMoveEvent): Do not modiify

the active element during a mouse move if the user is
touching the screen.

(WebCore::EventHandler::handleTouchEvent): Set the correct

type of hit test to perform depending on the type of the
touch event we are handling.

  • page/EventHandler.h: Update the signature of hitTestResultAtPoint.

LayoutTests:

  • fast/events/touch/touch-active-state-expected.txt: Added.
  • fast/events/touch/touch-active-state.html: Added.
02:02 Changeset [63806] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: should be possible to debug inspector
https://bugs.webkit.org/show_bug.cgi?id=42730

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):

07/20/10:

23:53 Changeset [63805] by yurys@chromium.org
  • 11 edits
    2 adds in trunk

2010-07-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

console.assert should include stack trace with line numbers.
https://bugs.webkit.org/show_bug.cgi?id=22556

Test: inspector/console-assert.html

  • bindings/v8/ScriptCallStack.cpp: (WebCore::getTopFrameLocation): (WebCore::toScriptCallFramesVector): (WebCore::ScriptCallStack::create): (WebCore::ScriptCallStack::ScriptCallStack):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback): (WebCore::V8Console::assertCallback):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement):
  • page/Console.cpp: (WebCore::Console::lastWMLErrorMessage):
  • page/Console.idl:

2010-07-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

console.assert should include stack trace with line numbers.
https://bugs.webkit.org/show_bug.cgi?id=22556

  • inspector/console-assert-expected.txt: Added.
  • inspector/console-assert.html: Added.
23:29 Changeset [63804] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-20 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Kent Tamura.

[EFL] Use log functions instead of fprintf
https://bugs.webkit.org/show_bug.cgi?id=42576

Use LOG and LOG_ERROR instead of fprintf.

No new tests, no new functionality.

  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyFallbackCursor):
23:04 Changeset [63803] by loislo@chromium.org
  • 10 edits in trunk/WebCore

2010-07-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: the bindings generation helper script can be
simplified a bit. Chromium.
https://bugs.webkit.org/show_bug.cgi?id=42523

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_binding.py:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/generate-bindings.pl:
  • inspector/CodeGeneratorInspector.pm:
21:28 Changeset [63802] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Re-save vsprops file after no-op edit in Visual Studio
to fix manual edit issues.

  • WebCore.vcproj/WebCoreCommon.vsprops:
21:26 Changeset [63801] by sfalken@apple.com
  • 4 edits in trunk/JavaScriptCore

Re-save vsprops files after no-op edits in Visual Studio
to fix manual edit issues.

21:12 Changeset [63800] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Re-save vcproj file after no-op edit in Visual Studio
to fix manual edit issues.

  • WebCore.vcproj/WebCore.vcproj:
19:41 Changeset [63799] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests

2010-07-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update expected results for a "tricky" test
https://bugs.webkit.org/show_bug.cgi?id=42604

Originally, I created these expectations using Minefield. However, it
appears that Minefield parses this case incorrectly according to the
spec. I've filed <https://bugzilla.mozilla.org/show_bug.cgi?id=580091>.

This patch updates our expected results to what I believe is correct.

  • html5lib/resources/tricky01.dat:
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
19:30 Changeset [63798] by abarth@webkit.org
  • 6 edits
    1 add in trunk

2010-07-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Include attributes when reconstructing elements in HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42594

  • html5lib/runner-expected-html5.txt:

2010-07-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Include attributes when reconstructing elements in HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42594

Remove FIXME now that we have a test.

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::createHTMLElementFromElementRecord):
18:43 Changeset [63797] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix obvious typo.

Reviewed by Jon Honeycutt.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.

18:29 Changeset [63796] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-20 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] by default, dumpAsText should disable pixel results
https://bugs.webkit.org/show_bug.cgi?id=42715

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
18:20 Changeset [63795] by tony@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-07-20 Tony Chang <tony@chromium.org>

Not reviewed, chromium test expectation.

[chromium] put back baseline for http/tests/inspector/resource-parameters.html
https://bugs.webkit.org/show_bug.cgi?id=42720

r63791 put in a failing baseline for webkit win, but chromium-win
falls back to webkit win before the result next to the test file.
Just put another copy in chromium-win of the original expected
results.

  • platform/chromium/http/tests/inspector/resource-parameters-expected.txt: Copied from LayoutTests/http/tests/inspector/resource-parameters-expected.txt.
18:03 Changeset [63794] by weinig@apple.com
  • 4 edits in trunk

Patch for https://bugs.webkit.org/show_bug.cgi?id=42719
Make Acid2 pass in WebKit2

Reviewed by Brady Eidson.

WebCore:

  • WebCore.exp.in: Update exported functions.

WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::objectContentType): Check for supported image mimetypes
before falling back to plugins.

18:02 Changeset [63793] by abarth@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2010-07-20 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Import HTML5 parsing tests from html5test.com
https://bugs.webkit.org/show_bug.cgi?id=42713

  • html5lib/resources/html5test-com.dat: Added.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
17:26 Changeset [63792] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk

2010-07-20 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prefetch categorization is exactly wrong
https://bugs.webkit.org/show_bug.cgi?id=42651

The miscategorization caused onloads to issue early, so you see x,
y as 0, 0 in the buggy version.

  • fast/dom/HTMLLinkElement/onload-completion-test-expected.txt: Added.
  • fast/dom/HTMLLinkElement/onload-completion-test.html: Added.
  • fast/dom/HTMLLinkElement/resources: Added.
  • fast/dom/HTMLLinkElement/resources/nick.jpg: Added.

2010-07-20 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

prefetch categorization is exactly wrong
https://bugs.webkit.org/show_bug.cgi?id=42651

While I was in the area, I saw that CachedResource::schedule() was dead, so I have removed it.

Test: fast/dom/HTMLLinkElement/onload-completion-test.html

  • loader/CachedCSSStyleSheet.h:
  • loader/CachedFont.h:
  • loader/CachedImage.h:
  • loader/CachedResource.cpp:
  • loader/CachedResource.h: (WebCore::CachedResource::isPrefetch):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.h:
17:05 Changeset [63791] by bweinstein@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Land failing results for http/tests/inspector/resource-parameters.html. It has been
failing for a while. Fixing these results is being tracked by
<https://bugs.webkit.org/show_bug.cgi?id=42718>.

Rubber-stamped by Adam Roben.

  • platform/win/http/tests/inspector: Added.
  • platform/win/http/tests/inspector/resource-parameters-expected.txt: Added.
17:00 Changeset [63790] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Windows build fix

  • MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny

WebKit.lib instead of the old, dusty WebKit2.lib.

16:44 Changeset [63789] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Add WebKitTestRunner and friends to WebKit.sln

We added these projects to WebKit2.sln in r63585, but removed them
again in r63600 because WebKitTestRunner required getopt, which
doesn't exist in WebKitAuxiliaryLibrary. r63700 and r63788 removed the
use of getopt in WebKitTestRunner, so we can now add it to WebKit.sln
(which has replaced WebKit2.sln).

Fixes <http://webkit.org/b/42711> WebKit.sln should build
WebKitTestRunner

Reviewed by Steve Falkenburg.

  • WebKit.vcproj/WebKit.sln: Added the following projects to the end of

the build order (in first-built to last-built order):
InjectedBundleGenerated, InjectedBundle, WebKitTestRunner. Also
removed an unnecessary dependency from testapi on WebKit2WebProcess.

16:40 Changeset [63788] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Stop linking WebKitTestRunner against getopt

Use of getopt was removed in r63700.

Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
getopt, but doesn't need to

Reviewed by Sam Weinig.

  • WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib

from all configurations.

16:33 Changeset [63787] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add a few more items to the WebKit2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=42712

Reviewed by Maciej Stachowiak.

  • platform/mac-wk2/Skipped:
16:23 Changeset [63786] by jhawkins@chromium.org
  • 6 edits in trunk

2010-07-16 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Implement WebFormElement::wasUserSubmitted(). This is used to
verify that the user submitted the form instead of JS when saving form
data in AutoFill.
https://bugs.webkit.org/show_bug.cgi?id=42479

  • public/WebFormElement.h:
  • src/WebFormElement.cpp: (WebKit::WebFormElement::wasUserSubmitted):

2010-07-16 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

Expose the form submission trigger on the HTMLFormElement object. This
is used to verify that the user submitted the form instead of JS when
saving form data in Chrome AutoFill.
https://bugs.webkit.org/show_bug.cgi?id=42479

No new tests as this is only used by the Chromium WebKit API.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::reset): (WebCore::HTMLFormElement::submissionTrigger):
  • html/HTMLFormElement.h:
16:06 Changeset [63785] by aroben@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Make run-webkit-tests --webkit-test-runner "work" on Windows

WebKitTestRunner crashes on launch, but at least the scripts build and
launch it!

Fixes <http://webkit.org/b/42709> run-webkit-tests
--webkit-test-runner bails with an error on Windows

Reviewed by Anders Carlsson.

  • Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on

Windows.

  • WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following

projects (from first-built to last-built): FindSafari, ImageDiff,
InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.

16:05 Changeset [63784] by aroben@apple.com
  • 3 edits
    1 delete in trunk

Remove WebKit2.sln

WebKit.sln builds all the same projects.

Rubber-stamped in advance by Steve Falkenburg.

WebKit2:

  • WebKit2.sln: Removed.

WebKitTools:

Change build-webkit back to building WebKit.sln on Windows

WebKit.sln builds all the same projects as WebKit2.sln, and the latter
is being removed.

  • Scripts/build-webkit:
16:04 Changeset [63783] by crogers@google.com
  • 8 edits in branches/audio/WebCore

Fixes to Chrome build and run-time due to recent API changes

16:02 Changeset [63782] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-07-20 Adam Barth <abarth@webkit.org>

Unreviewed.

Fix fast/dom/title-content-write-set.html for HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42668

Address some late-breaking review comments.

  • dom/CharacterData.cpp: (WebCore::CharacterData::appendDataCommon): (WebCore::CharacterData::parserAppendData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::replaceData):
  • dom/CharacterData.h:
15:39 Changeset [63781] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2010-07-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Darin Adler.

make dump-as-markup work better on subframes and allow dumping a subtree
https://bugs.webkit.org/show_bug.cgi?id=42673

  • editing/selection/dump-as-markup-expected.txt:
  • editing/selection/dump-as-markup.html:
  • resources/dump-as-markup.js: (Markup.description): (Markup._getSelectionFromNode): (Markup._getMarkupForTextNode): (Markup._getSelectionMarker):
15:23 Changeset [63780] by evan@chromium.org
  • 9 edits in trunk

2010-07-20 Daniel Erat <derat@chromium.org>

Reviewed by Ojan Vafai.

Subpixel rendering always disabled for Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=42220

Layout test addition to check that Chromium Linux honors fontconfig
settings enabling or disabling subpixel rendering per-strike.

  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.checksum:
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.png:
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.txt:
  • platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html:

2010-07-20 Daniel Erat <derat@chromium.org>

Reviewed by Ojan Vafai.

Subpixel rendering always disabled for Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=42220

Explicitly initialize global Chromium Linux isSkiaSubpixelGlyphs
flag to false for clarity.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp:

2010-07-20 Daniel Erat <derat@chromium.org>

Reviewed by Ojan Vafai.

Subpixel rendering always disabled for Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=42220

Honor Fontconfig subpixel rendering setting on Chromium Linux.

  • src/gtk/WebFontInfo.cpp: (WebKit::WebFontInfo::renderStyleForStrike):
15:12 Changeset [63779] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-07-20 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Fix fast/dom/title-content-write-set.html for HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42668

When I split parserAppendData from appendData, it was tempting to cut
the function at dispatchModifiedEvent, but that's not quite right. We
still need to notify the parent that it's children have changed.

  • dom/CharacterData.cpp: (WebCore::CharacterData::appendDataCommon): (WebCore::CharacterData::parserAppendData): (WebCore::CharacterData::appendData):
  • dom/CharacterData.h:
14:56 Changeset [63778] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Windows build fix

  • MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
14:55 Changeset [63777] by aroben@apple.com
  • 2 edits in trunk/WebKit2

Make the web process break into the debugger when Ctrl-Alt-Shift is held during launch

Fixes <http://webkit.org/b/42670> Would like a way to break into the
debugger when the web process launches

Reviewed by Anders Carlsson.

  • WebProcess/WebKitMain.cpp:

(WebKitMain): If the Control, Alt, and Shift keys are held down in a
Debug build, call DebugBreak() so that we will break into the
debugger.

14:55 Changeset [63776] by aroben@apple.com
  • 2 edits in trunk/WebKit2

Teach Connection how to handle a slow receiver

Fixes <http://webkit.org/b/42667> Assertion in
Connection::sendOutgoingMessage when browser or web process is paused

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::sendOutgoingMessage): If WriteFile returns FALSE
and the last error is ERROR_IO_PENDING, Windows will write the data as
soon as the current write operation is completed. We don't need to do
anything special in this case, so there's no need to assert about it.

14:45 Changeset [63775] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit

2010-07-20 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Fix zoom in/out on EFL after r62666. The patch for adding viewport
missed the initialization of zoom_range.user_scalable. In case browser
doesn't care about the viewport and does not listen to the signal,
user_scalable will be always false, thus inhibiting zoom in/out.
https://bugs.webkit.org/show_bug.cgi?id=42656

  • efl/EWebLauncher/main.c: (on_viewport_changed): when listening to signal about viewport meta tag, it's not sufficient to receive the parameters. One needs also to enforce these parameters in WebKit.
  • efl/ewk/ewk_view.cpp: (_ewk_view_priv_new): initialize user_scalable parameter to allow browser zooming in and out.
14:34 Changeset [63774] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

CrashTracer: [USER] 300 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityTable::isTableExposableThroughAccessibility + 573
https://bugs.webkit.org/show_bug.cgi?id=42652

Reviewed by Beth Dakin.

WebCore:

When a table cell accesses its parent table, we should not use getOrCreate, because creating an AXTable inspects its render tree state
which may be out of date, leading to a crash.
By using only get(), it implies that the AXTable must be created before AXTableCells. This should
always be the case when AT clients access a table.

Test: accessibility/updating-attribute-in-table-causes-crash.html

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::parentTable):

LayoutTests:

  • accessibility/updating-attribute-in-table-causes-crash-expected.txt: Added.
  • accessibility/updating-attribute-in-table-causes-crash.html: Added.
14:11 Changeset [63773] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2010-07-20 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Check the node is a text node before doing the static cast
for editing commands.
https://bugs.webkit.org/show_bug.cgi?id=42655

Test: editing/execCommand/editing-nontext-node-crash.xhtml

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::fixupWhitespace):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):

2010-07-20 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Tests that applying an editing command on a non text node does not
result in crash.
https://bugs.webkit.org/show_bug.cgi?id=42655

  • editing/execCommand/editing-nontext-node-crash-expected.txt: Added.
  • editing/execCommand/editing-nontext-node-crash.xhtml: Added.
13:37 Changeset [63772] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-07-20 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by David Hyatt.

Don't merge Anonymous block whose first child is inline run-in.
Make run-in recalculate its style after its renderer is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=41375.

Test: fast/runin/crash-when-reparent-sibling.html

  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks):
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::destroyLeftoverChildren):

2010-07-20 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by David Hyatt.

Test case to verify https://bugs.webkit.org/show_bug.cgi?id=41375.
Test passes if expected result occurs without crash.
https://bugs.webkit.org/show_bug.cgi?id=41375.

  • fast/runin/crash-when-reparent-sibling-expected.txt: Added.
  • fast/runin/crash-when-reparent-sibling.html: Added.
13:27 Changeset [63771] by steveblock@google.com
  • 2 edits in trunk/WebCore

Unreviewed Qt test fix.

Qt should not use PREEMPT_GEOLOCATION_PERMISSION until Bug 42027 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=42068

No new tests, test fix only.

  • WebCore.pro:
13:23 Changeset [63770] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-20 Darin Fisher <darin@chromium.org>

Fix Chromium build bustage.

  • src/ResourceHandle.cpp: (WebCore::ResourceHandle::hasAuthenticationChallenge): Add implementation of this method that always returns false.
12:56 Changeset [63769] by darin@chromium.org
  • 8 edits in trunk/WebKit/chromium

2010-07-20 Darin Fisher <darin@chromium.org>

Reviewed by Jian Li.

[Chromium] Add interface for downloading to a file. This can be used
in the future to support XMLHttpRequest.responseBlob, but it also
serves a use case in Chromium.

https://bugs.webkit.org/show_bug.cgi?id=42657

  • public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::willSendRequest): (WebKit::WebURLLoaderClient::didSendData): (WebKit::WebURLLoaderClient::didReceiveResponse): (WebKit::WebURLLoaderClient::didDownloadData): (WebKit::WebURLLoaderClient::didReceiveData): (WebKit::WebURLLoaderClient::didFinishLoading): (WebKit::WebURLLoaderClient::didFail):
  • public/WebURLRequest.h:
  • public/WebURLResponse.h:
  • src/WebURLRequest.cpp: (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile):
  • src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath):
  • src/WebURLResponsePrivate.h:
12:55 Changeset [63768] by commit-queue@webkit.org
  • 3 edits in trunk

2010-07-20 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Enable Ecore-X on compile time
https://bugs.webkit.org/show_bug.cgi?id=42600

Check for a flag received from cmake configure and disable it
if necessary. Also disable it if Ecore-X wasn't found.

EFL port does not support automated tests yet.

  • cmake/FindEFL.cmake:
  • cmake/OptionsEfl.cmake:
12:53 Changeset [63767] by loislo@chromium.org
  • 10 edits in trunk/WebCore

2010-07-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r63764.
http://trac.webkit.org/changeset/63764
https://bugs.webkit.org/show_bug.cgi?id=42658

have broken Chromium linux build (Requested by loislo on
#webkit).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_binding.py:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/generate-bindings.pl:
  • inspector/CodeGeneratorInspector.pm:
12:48 Changeset [63766] by ap@apple.com
  • 8 edits
    2 adds in trunk

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=41531
Asynchronous cross origin XMLHttpRequest doesn't expose 401 response when withCredentials is false

This doesn't match Firefox, but it matches our sync case, XHR2 spec and common sense.

Test: http/tests/xmlhttprequest/cross-origin-no-authorization.html (updated results).

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didReceiveAuthenticationChallenge): Instead of canceling the request, continue without credentials - if the platform has a necessary method on ResourceHandle.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): Don't ask resource loader client for credentials if subresource loader client already took care of those.
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::hasAuthenticationChallenge):
  • platform/network/ResourceHandle.h: Added an accessor to check whether ResourceHandle is currently waiting for credentials.
12:29 Changeset [63765] by leandro@webkit.org
  • 2 edits in trunk/WebCore

2010-07-20 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

Build SVGPathBuilder, SVGPathParser and SVGPathSegListBuilder.
Add websockets include directory.

The EFL port doesn't yet support automated tests.

  • CMakeLists.txt:
12:27 Changeset [63764] by loislo@chromium.org
  • 10 edits in trunk/WebCore

2010-07-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: the bindings generation helper script can be
simplified a bit. Chromium.
https://bugs.webkit.org/show_bug.cgi?id=42523

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_binding.py:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/generate-bindings.pl:
  • inspector/CodeGeneratorInspector.pm:
12:23 Changeset [63763] by joepeck@webkit.org
  • 6 edits
    5 adds in trunk

2010-07-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Geoffrey Garen.

WebScriptObject Should Allow Safely Checking For Key Existence
https://bugs.webkit.org/show_bug.cgi?id=42613

  • platform/mac/fast/objc/script-tests/TEMPLATE.html: Added.
  • platform/mac/fast/objc/script-tests/webScriptObject-hasWebScriptKey.js: Added.
  • platform/mac/fast/objc/webScriptObject-hasWebScriptKey-expected.txt: Added.
  • platform/mac/fast/objc/webScriptObject-hasWebScriptKey.html: Added.

2010-07-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Geoffrey Garen.

WebScriptObject Should Allow Safely Checking For Key Existence
https://bugs.webkit.org/show_bug.cgi?id=42613

Test: platform/mac/fast/objc/webScriptObject-hasWebScriptKey.html

Add private API "hasWebScriptKey" to check for key existence in
a WebScriptObject. Like JavaScript's in syntax. This is intended
to be made public eventually.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject hasWebScriptKey:]):
  • bindings/objc/WebScriptObjectPrivate.h:

2010-07-20 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Geoffrey Garen.

WebScriptObject Should Allow Safely Checking For Key Existence
https://bugs.webkit.org/show_bug.cgi?id=42613

Normal ObjCController workflow for a WebScriptObject test.

  • DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController testHasWebScriptKey:]):
12:18 Changeset [63762] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-07-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 tree builder needs to call dispatchDocumentElementAvailable
https://bugs.webkit.org/show_bug.cgi?id=42654

This patch fixes the follout LayoutTests with --html5-treebuilder:

  • userscripts/script-not-run-for-fragments.html
  • userscripts/script-run-at-start.html
  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::HTMLConstructionSite): (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): (WebCore::HTMLConstructionSite::insertHTMLHtmlElement):
  • html/HTMLConstructionSite.h:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
11:59 Changeset [63761] by commit-queue@webkit.org
  • 6 edits in trunk

2010-07-20 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Steve Block.

Need to be able to configure Geolocation policy regarding user permissions
https://bugs.webkit.org/show_bug.cgi?id=42068

If CLIENT_BASED_GEOLOCATION is enabled, enable preemtive permission policy
by default

  • wtf/Platform.h:

2010-07-20 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Steve Block.

Need to be able to configure Geolocation policy regarding user permissions
https://bugs.webkit.org/show_bug.cgi?id=42068

Introducing new USE() flag PREEMPT_GEOLOCATION_PREMISSION using which
acquires user permission first before starting location service

This change does not introduce any change in behavior for any platform. So there are no new tests
added.

  • WebCore.pro:
  • page/Geolocation.cpp: (WebCore::Geolocation::startRequest): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::startUpdating):
  • page/Geolocation.h:
11:28 Changeset [63760] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-07-20 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

HTML5 tree builder should restore form state
https://bugs.webkit.org/show_bug.cgi?id=42644

We need to tell self-closing tags that we're done parsing their
children. This patch fixes the following LayoutTests when run with
--html5-treebuilder:

fast/forms/button-state-restore.html
fast/forms/state-restore-to-non-autocomplete-form.html
fast/forms/state-restore-to-non-edited-controls.html
fast/history/saves-state-after-fragment-nav.html
http/tests/navigation/restore-form-state-https.html

  • html/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
11:12 Changeset [63759] by commit-queue@webkit.org
  • 9 edits in trunk

2010-07-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r63750.
http://trac.webkit.org/changeset/63750
https://bugs.webkit.org/show_bug.cgi?id=42648

This revision breaks the windows builds (Requested by
hwennborg on #webkit).

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners):
  • page/DOMWindow.idl:
  • page/Page.cpp: (WebCore::Page::Page):

2010-07-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r63750.
http://trac.webkit.org/changeset/63750
https://bugs.webkit.org/show_bug.cgi?id=42648

This revision breaks the windows builds (Requested by
hwennborg on #webkit).

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:
10:54 Changeset [63758] by senorblanco@chromium.org
  • 56 edits
    4 adds
    2 deletes in trunk/LayoutTests

2010-07-20 Stephen White <senorblanco@chromium.org>

Unreviewed; pixel test results fix.

Updated pixel test results after r63721.

  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.checksum:
  • platform/chromium-linux/svg/custom/path-getTotalLength-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/relative-sized-use-on-symbol-expected.checksum:
  • platform/chromium-linux/svg/custom/relative-sized-use-on-symbol-expected.png:
  • platform/chromium-linux/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
  • platform/chromium-linux/svg/dom: Added.
  • platform/chromium-linux/svg/dom/path-parser-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/perf/001-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/002-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/007-expected.checksum:
  • platform/chromium-linux/svg/hixie/perf/007-expected.png:
  • platform/chromium-linux/svg/hixie/perf/007-expected.txt:
  • platform/chromium-mac/fast/backgrounds/svg-as-background-5-expected.checksum: Removed.
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/custom/control-points-for-S-and-T-expected.checksum:
  • platform/chromium-win/svg/custom/control-points-for-S-and-T-expected.png:
  • platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/chromium-win/svg/hixie/perf/001-expected.txt:
  • platform/chromium-win/svg/hixie/perf/002-expected.txt:
  • platform/chromium-win/svg/hixie/perf/007-expected.checksum:
  • platform/chromium-win/svg/hixie/perf/007-expected.png:
  • platform/chromium-win/svg/hixie/perf/007-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
10:53 Changeset [63757] by loislo@chromium.org
  • 4 edits in trunk/WebCore

2010-07-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: It is possible to show full call stack instead of top frame for Caller
and Call Site properties in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=42620

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord): (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
  • inspector/front-end/inspector.css: (.timeline-details): (.timeline-function-name): (.timeline-stacktrace-title):
10:50 Changeset [63756] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Implement NPN_GetURL and NPN_PostURL
https://bugs.webkit.org/show_bug.cgi?id=42650

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):
Add a FIXME about deleting the file.

(WebKit::makeURLString):
Move this static method before NPN_GetURL.

(WebKit::NPN_GetURL):
Call NetscapePLugin::LoadURL.

(WebKit::NPN_PostURL):
Ditto.

(WebKit::NPN_PostURLNotify):

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

Remove unreached code.

(WebKit::NetscapePluginStream::deliverDataToPlugin):
Stop the stream if the plug-in returns -1 from NPP_Write.

10:42 Changeset [63755] by victorw@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-07-19 Victor Wang <victorw@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add webkit api reset to WebIDBDatabaseError and WebIDBKey
and refactor their destructors for chromium multi dll build.

https://bugs.webkit.org/show_bug.cgi?id=42574

  • public/WebIDBDatabaseError.h: (WebKit::WebIDBDatabaseError::~WebIDBDatabaseError):
  • public/WebIDBKey.h: (WebKit::WebIDBKey::~WebIDBKey):
  • src/WebIDBDatabaseError.cpp: (WebKit::WebIDBDatabaseError::reset):
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::reset):
10:38 Changeset [63754] by cmarrin@apple.com
  • 2 edits in trunk/WebKitTools

2010-07-20 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=42118
Disable compositing/webgl tests if WebGL is not enabled

  • Scripts/old-run-webkit-tests:
10:35 Changeset [63753] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-07-20 Leon Clarke <leonclarke@google.com>

Reviewed by Pavel Feldman.

Make things compile again when the inspector is disabled, following
recent inspector improvements.
https://bugs.webkit.org/show_bug.cgi?id=42632

No new tests. Fixing a build break.

  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::stackTrace):
  • inspector/InspectorController.h: (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::didRemoveDOMNode): (WebCore::InspectorController::didModifyDOMAttr):
  • inspector/InspectorDOMAgent.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
10:31 Changeset [63752] by chang.shu@nokia.com
  • 5 edits
    20 moves
    7 adds in trunk/LayoutTests

2010-07-20 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

Move the canvas security tests to http tests to simulate remote host
access and then pass the tests. Remove them from Mac and Qt's skipped files.
https://bugs.webkit.org/show_bug.cgi?id=41279

10:20 Changeset [63751] by antonm@chromium.org
  • 4 edits in trunk/WebCore

2010-07-20 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Allow handles to be disposed and WebKit objects to be dereferenced even if their map is already destroyed.
https://bugs.webkit.org/show_bug.cgi?id=42634

Currently DOMDataStore could be destroyed even if it has some mappings (it gets destroyed
when its isolated context gets GCed). However in this case, handles allocated for
such objects would never be disposed as we require presence of mapping from wrapped
WebKit object to handle being collected in the map and now map is gone. That leads to
zombie objects in both WebKit (wrapped WebKit object doesn't get dereferenced) and V8
(both handle and V8 wrapper object could not be destroyed).

See http://code.google.com/p/chromium/issues/detail?id=47125 for further discussion.

  • bindings/v8/DOMData.h: (WebCore::DOMData::handleWeakObject):
  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::weakNodeCallback):
  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::~WeakReferenceMap):
10:08 Changeset [63750] by commit-queue@webkit.org
  • 9 edits in trunk

2010-07-20 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Runtime feature switch for device orientation
https://bugs.webkit.org/show_bug.cgi?id=42265

Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled): (WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled): (WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners):
  • page/DOMWindow.idl:
  • page/Page.cpp: (WebCore::Page::Page):

2010-07-20 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Runtime feature switch for device orientation
https://bugs.webkit.org/show_bug.cgi?id=42265

Add a runtime feature switch that decides whether device orientation
events are available or not. Defaults to true.

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceOrientation): (WebKit::WebRuntimeFeatures::isDeviceOrientationEnabled):
09:44 Changeset [63749] by antonm@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-20 Anton Muhin <antonm@chromium.org>

Reviewed by Darin Adler.

Print additional information about exception if failed to connect to apache (in verbose mode).
https://bugs.webkit.org/show_bug.cgi?id=42627

  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
09:30 Changeset [63748] by tony@chromium.org
  • 3 edits in trunk/WebKitTools

2010-07-20 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] only pass --force to gclient sync if explicitly stated
https://bugs.webkit.org/show_bug.cgi?id=42581

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should

always pass --force since it's hard to do manual cleanups

  • Scripts/update-webkit-chromium: only pass --force if --force is

passed in

09:16 Changeset [63747] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-07-20 Hayato Ito <hayato@chromium.org>

Reviewed by Darin Adler.

Fixed a crash when deeply nested CSS selector is used.
https://bugs.webkit.org/show_bug.cgi?id=41129

This patch deletes CSSSelectors iteratively so that it doesn't cause stack overflow.

  • fast/css/css-selector-deeply-nested-expected.txt: Added.
  • fast/css/css-selector-deeply-nested.html: Added.

2010-07-20 Hayato Ito <hayato@chromium.org>

Reviewed by Darin Adler.

Fixed a crash when deeply nested CSS selector is used.
https://bugs.webkit.org/show_bug.cgi?id=41129

This patch deletes CSSSelectors iteratively so that it doesn't cause stack overflow.

Test: fast/css/css-selector-deeply-nested.html

  • css/CSSSelector.cpp: (WebCore::CSSSelectorBag::~CSSSelectorBag): (WebCore::CSSSelectorBag::isEmpty): (WebCore::CSSSelectorBag::append): (WebCore::CSSSelectorBag::takeAny): (WebCore::CSSSelector::~CSSSelector): (WebCore::CSSSelector::specificity):
  • css/CSSSelector.h:
08:17 Changeset [63746] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-07-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Web Inspector: inspected page renderer crashes when inspected page has JS syntax error
https://bugs.webkit.org/show_bug.cgi?id=42642

  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler):
08:09 Changeset [63745] by abecsi@webkit.org
  • 6 edits in trunk

2010-07-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r63742.
http://trac.webkit.org/changeset/63742
https://bugs.webkit.org/show_bug.cgi?id=42641

Broke Leopard Intel build. (Requested by bbandix on #webkit).

  • wtf/Platform.h:

2010-07-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r63742.
http://trac.webkit.org/changeset/63742
https://bugs.webkit.org/show_bug.cgi?id=42641

Broke Leopard Intel build. (Requested by bbandix on #webkit).

  • WebCore.pro:
  • page/Geolocation.cpp: (WebCore::Geolocation::startRequest): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::startUpdating):
  • page/Geolocation.h:
07:51 Changeset [63744] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-20 Stephen White <senorblanco@chromium.org>

Unreviewed; expectations fix.

Modify test_expectations after r63721 and r63728.

  • platform/chromium/test_expectations.txt:
07:51 Changeset [63743] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Fixed case of "Name" attribute.
07:24 Changeset [63742] by abecsi@webkit.org
  • 6 edits in trunk

Need to be able to configure Geolocation policy regarding user permissions
https://bugs.webkit.org/show_bug.cgi?id=42068

Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-07-20
Reviewed by Steve Block.

JavaScriptCore:

If CLIENT_BASED_GEOLOCATION is enabled, enable preemtive permission policy
by default

  • wtf/Platform.h:

WebCore:

Introducing new USE() flag PREEMPT_GEOLOCATION_PREMISSION using which
acquires user permission first before starting location service

This change does not introduce any change in behavior for any platform. So there are no new tests
added.

  • WebCore.pro:
  • page/Geolocation.cpp:

(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::startUpdating):

  • page/Geolocation.h:
05:21 Changeset [63741] by apavlov@chromium.org
  • 4 edits in trunk/WebCore

2010-07-20 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Inspector: Resources Search Should Search Only Filtered Resources
https://bugs.webkit.org/show_bug.cgi?id=28290

  • inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get searchableViews):
  • inspector/front-end/inspector.js: (WebInspector.performSearch): (WebInspector.doPerformSearch):
05:11 Changeset [63740] by commit-queue@webkit.org
  • 5 edits in trunk/WebKit/qt

2010-07-20 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

[Qt] Add API to define device-width and height for use with the viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=42597

Reviewed by Antonio Gomes.

Add a new API for setting the deviceSize for use in conjunction with
out viewport meta tag API.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::setDeviceSize): (QGraphicsWebView::deviceSize):
  • Api/qgraphicswebview.h:
  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::windowRect):
  • WebCoreSupport/PageClientQt.h: (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
05:01 Changeset [63739] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-07-20 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Incorrect absolute URLs in tooltips of links in the ElementsTreeOutline
https://bugs.webkit.org/show_bug.cgi?id=42626

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeHTML):
04:46 Changeset [63738] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-07-20 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578

Don't set an automatic timeout for notifications when running in DRT.
This fixes an issue with cancel() notifications in unrelated tests.

  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::displayNotification):
03:17 Changeset [63737] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-20 Alejandro G. Castro <alex@igalia.com>

Unreviewed.

Skipping the svg/dom/path-parser.html test for gtk, bug submitted:
https://bugs.webkit.org/show_bug.cgi?id=42624

  • platform/gtk/Skipped:
02:24 Changeset [63736] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2010-07-20 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed comment fix. The comment in IDL should be , not # .

Code generator: ensure generated constants match their corresponding enums.
https://bugs.webkit.org/show_bug.cgi?id=42250

  • dom/OverflowEvent.idl:
02:14 Changeset [63735] by commit-queue@webkit.org
  • 11 edits in trunk

2010-07-20 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Add WebCore/bindings/generic/RuntimeEnabledFeatures.cpp to build files
https://bugs.webkit.org/show_bug.cgi?id=42380

RuntimeEnabledFeatures.cpp and .h were moved from bindings/v8 to
bindings/generic a while a go (in r54593), but need to
be added to the build in order to be used.

No new functionality so no new tests.

  • Android.mk:

2010-07-20 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Add WebCore/bindings/generic/RuntimeEnabledFeatures.cpp to build files
https://bugs.webkit.org/show_bug.cgi?id=42380

RuntimeEnabledFeatures.cpp and .h were moved from bindings/v8 to
bindings/generic a while a go (in r54593), but need to
be added to the build in order to be used.

No new functionality so no new tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/WebSocket.cpp: Remove #if USE(V8), as RuntimeEnabledFeatures.cpp is no longer V8-only.
  • websockets/WebSocket.h: Ditto.
01:43 Changeset [63734] by tony@chromium.org
  • 6 edits in trunk/WebCore

2010-07-20 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

clean up style in ClipboardWin and PasteboardWin
https://bugs.webkit.org/show_bug.cgi?id=42609

No new tests since this is just a style cleanup.

  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData): (WebCore::markupToCFHTML): (WebCore::getURL): (WebCore::getPlainText): (WebCore::getTextHTML): (WebCore::fragmentFromFilenames): (WebCore::containsFilenames): (WebCore::fragmentFromCFHTML): (WebCore::fragmentFromHTML):
  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/ClipboardWin.cpp: (WebCore::pathRemoveBadFSCharacters): (WebCore::createGlobalHDropContent): (WebCore::createGlobalUrlFileDescriptor): (WebCore::writeURL): (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::getData): (WebCore::ClipboardWin::types): (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writeRange):
  • platform/win/ClipboardWin.h: (WebCore::ClipboardWin::create): (WebCore::ClipboardWin::dataObject):
  • platform/win/PasteboardWin.cpp: (WebCore::PasteboardOwnerWndProc): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
01:31 Changeset [63733] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-20 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

fast/events/focusingUnloadedFrame.html shouldn't have <body> before <frameset>
https://bugs.webkit.org/show_bug.cgi?id=42348

This doesn't work in the HTML5 parser. We cover this behavior in
parsing tests. Sadly, the test still fails under the HTML5 parser, but
for a different reason.

  • fast/events/focusingUnloadedFrame.html:
01:30 Changeset [63732] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-07-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: jump to source is broken for call frames logged by console.trace
https://bugs.webkit.org/show_bug.cgi?id=42619

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
  • inspector/front-end/treeoutline.js: allow passing HTML element as a title. (TreeElement.prototype.set title): (TreeElement.prototype.set shouldRefreshChildren): (TreeElement.prototype._setListItemNodeContent): (TreeElement.prototype._attach):
01:17 Changeset [63731] by tony@chromium.org
  • 6 edits
    3 adds
    2 deletes in trunk

2010-07-20 Tony Chang <tony@chromium.org>

Reviewed by Dan Bernstein.

[chromium] crash in Position::getInlineBoxAndOffset
https://bugs.webkit.org/show_bug.cgi?id=42202

  • editing/selection/firstRect-crash-expected.txt: Added.
  • editing/selection/firstRect-crash.html: Added.
  • platform/mac/editing/input/caret-primary-bidi-expected.txt: Fix some negative ranges.
  • platform/mac/editing/input/range-for-empty-document-expected.txt:
  • platform/mac/editing/selection/move-left-right-expected.txt: Removed since we now match the shared expected results.
  • platform/win/editing/selection/move-left-right-expected.txt: Removed since it's the same as the shared expected results.

2010-07-20 Tony Chang <tony@chromium.org>

Reviewed by Dan Bernstein.

[chromium] crash in Position::getInlineBoxAndOffset
https://bugs.webkit.org/show_bug.cgi?id=42202

Test: editing/selection/firstRect-crash.html
Manual test: win/contextmenu-key2.html

  • page/EventHandler.cpp: Code no longer needed
  • page/Frame.cpp: (WebCore::Frame::firstRectForRange): Normalize Positions to VisiblePositions because

Positions may be pointing to nodes that have no renderer. If there's no renderer,
getInlineBoxAndOffset will crash.

00:47 Changeset [63730] by zimmermann@webkit.org
  • 87 edits in trunk/LayoutTests

2010-07-20 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Maciej Stachowiak.

svg/dynamic-updates tests are broken - pixel test not generated/compared anymore
https://bugs.webkit.org/show_bug.cgi?id=42376

Finally generate pixel teset results again for svg/dynamic-updates. We have some regressions, tracked by master bug 42618.

  • fast/js/resources/js-test-pre.js: Pass 'window.enablePixelTesting' as argument to setDumpAsText() - the svg/dynamic-updates tests set this value to true before importing js-test-pre.js
  • platform/mac/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • svg/dynamic-updates/resources/SVGTestCase.js: Set 'window.enablePixelTesting' to true, forcing setDumpAsText() to generate pixel test results.
  • svg/dynamic-updates/script-tests/SVGLinearGradientElement-dom-gradientUnits-attr.js: Tweak this test, to make it work as expected.
  • svg/dynamic-updates/script-tests/SVGLinearGradientElement-svgdom-gradientUnits-prop.js: Ditto.
  • svg/dynamic-updates/script-tests/SVGRadialGradientElement-dom-gradientUnits-attr.js: Update expected result description.
  • svg/dynamic-updates/script-tests/SVGRadialGradientElement-svgdom-gradientUnits-prop.js: Ditto.
00:33 Changeset [63729] by abarth@webkit.org
  • 5 edits in trunk

2010-07-20 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Foster parenting depends on the current element at insertion time
https://bugs.webkit.org/show_bug.cgi?id=42599

  • html5lib/runner-expected-html5.txt:

2010-07-20 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Foster parenting depends on the current element at insertion time
https://bugs.webkit.org/show_bug.cgi?id=42599

We need to consider the current element at insertion-time when deciding
whether to redirect insertion to the foster parent. Previously, we
were considering the current element *both* at insertion-time and at
the time we created the guard.

  • html/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::RedirectToFosterParentGuard::RedirectToFosterParentGuard):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable): (WebCore::HTMLTreeBuilder::processEndTagForInTable): (WebCore::HTMLTreeBuilder::defaultForInTableText):
00:20 Changeset [63728] by abarth@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2010-07-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Import a number of fast/invalid tests into html5lib for easy of fixing
https://bugs.webkit.org/show_bug.cgi?id=42590

Working with these DOM dumps is much easier than staring at render
trees. Also, this infrastructure lets us cross-test with other
browsers.

  • html5lib/resources/tricky01.dat: Added.
  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:
  • html5lib/runner.html:
00:07 Changeset [63727] by commit-queue@webkit.org
  • 5 edits in trunk

2010-07-20 Matthew Delaney <mdelaney@apple.com>

Reviewed by Kenneth Rohde Christiansen.

Failing 2d.path.stroke.prune.curve philip canvas test
https://bugs.webkit.org/show_bug.cgi?id=42190

  • platform/mac/Skipped: Unskipped now passing tests.

2010-07-20 Matthew Delaney <mdelaney@apple.com>

Reviewed by Kenneth Rohde Christiansen.

Failing 2d.path.stroke.prune.curve philip canvas test
https://bugs.webkit.org/show_bug.cgi?id=42190

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::closePath): Added check to make sure there's a non-trivial path to close. Since there is currently no way to check if the current point is the start point, or similarly if there is only 1 point in the current subpath (since these are both sufficient conditions for a trivial subpath), then checking that the bounding rectangle has both zero width and height proves also to be a sufficient condition for a trivial path. (WebCore::CanvasRenderingContext2D::quadraticCurveTo): Added in simple bounds as per the spec. (WebCore::CanvasRenderingContext2D::bezierCurveTo): Added in simple bounds as per the spec.
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::closeSubpath): Moved the check for an empty path up on level to make it platform independent and remove redundancy.
00:03 Changeset [63726] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-07-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Add a few more items to the WK2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=42595

  • platform/mac-wk2/Skipped:

07/19/10:

23:54 Changeset [63725] by krit@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

2010-07-19 Dirk Schulze <krit@webkit.org>

SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410

Unreviewed update of Win baseline.

  • platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/win/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/win/svg/custom/relative-sized-use-on-symbol-expected.txt: Added.
  • platform/win/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/win/svg/custom/use-css-events-expected.txt: Added.
  • platform/win/svg/dom: Added.
  • platform/win/svg/dom/path-parser-expected.txt: Added.
23:41 Changeset [63724] by krit@webkit.org
  • 5 edits in trunk/LayoutTests

2010-07-19 Dirk Schulze <krit@webkit.org>

SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410

Unreviewed update of Qt baseline.

  • platform/qt/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
23:28 Changeset [63723] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

2010-07-19 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

Added a simple implementation of VideoLayerChromium. Uses the
LayerChromium::updateTextureRect() to send video frames to the
GPU.
https://bugs.webkit.org/show_bug.cgi?id=42234

  • WebCore.gypi: Added include for VideoLayerChromium.
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToMedia): Implemented setContentsToMedia, though it does not seem to trigger a repaint correctly.
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: Added. (WebCore::VideoLayerChromium::create): (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents):
  • platform/graphics/chromium/VideoLayerChromium.h: Added. (WebCore::VideoLayerChromium::drawsContent):

2010-07-19 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

Updated WebMediaPlayer to support accelerated rendering and to
create and return a VideoChromiumLayer as its platform layer.
https://bugs.webkit.org/show_bug.cgi?id=42234

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::platformLayer): (WebKit::WebMediaPlayerClientImpl::create):
  • src/WebMediaPlayerClientImpl.h: (WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
23:23 Changeset [63722] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-07-19 Yuzo Fujishima <yuzo@google.com>

Unreviewed test expectation fix.

fast/css/font-face-download-error.html should be skipped for Qt like
other @font-face tests.
https://bugs.webkit.org/show_bug.cgi?id=42342

  • platform/qt/Skipped:
22:37 Changeset [63721] by krit@webkit.org
  • 52 edits
    7 adds in trunk

2010-07-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410

Added piOverTwo to MathExtras.

  • wtf/MathExtras.h:

2010-07-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410

Cleanup the parsing code for SVG Paths. Move classes out of the convoluted SVGParserUtilities.cpp
in their own files. Make use of WebCore specific objects in parsing code like FloatPoint, AffineTransform,
etc. instead of using home-brewn solutions.
The SVGPathParser parses a path data string and delivers the parsed segments and values to the SVGPathConsumer.
SVGPathConsumer is the base class for SVGPathBuilder and SVGPathSegListBuilder, that either build the platform
Path object or a SVGPathSegList out of the segments.
We're now directly parsing floats instead of truncating precision to float afterwards.

SVG Path with an arc with radius of 0 does not render
https://bugs.webkit.org/show_bug.cgi?id=40448

If one of the radii on the elliptic arc are zero, we should draw a line from the starting point to
the end point according to the spec. Fixed this bug with this patch, because an is zero check and
an DRT check was neccessary with the current clean-up.
Extended svg/dom/path-parser.xhml to check the correct behavior.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatPoint.h: (WebCore::FloatPoint::move): Follow WebKit style and use multiple lines for the function. (WebCore::FloatPoint::scale): Scale FloatPoint. (WebCore::operator+=): (WebCore::operator+): Add two FloatPoints and give back the sum as FloatPoint.
  • svg/SVGAllInOne.cpp: Added new created files.
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): Use new PathParser to create a PathSegList.
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute): Use new PathParser to create a Path.
  • svg/SVGGlyphElement.cpp: (WebCore::parsePathData): Use new PathParser to create a Path.
  • svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag): Removed parseArcFlag(double&), we parse in float now.
  • svg/SVGParserUtilities.h: Removed path parsing code and a lot of unneccessary includes.
  • svg/SVGPathBuilder.cpp: Added. (WebCore::SVGPathBuilder::SVGPathBuilder): (WebCore::SVGPathBuilder::build): Builds a normalized Path. (WebCore::SVGPathBuilder::moveTo): (WebCore::SVGPathBuilder::lineTo): (WebCore::SVGPathBuilder::curveToCubic): (WebCore::SVGPathBuilder::closePath):
  • svg/SVGPathBuilder.h: Added. We just create normalized Paths, so this functions should never be reached. (WebCore::SVGPathBuilder::lineToHorizontal): (WebCore::SVGPathBuilder::lineToVertical): (WebCore::SVGPathBuilder::curveToCubicSmooth): (WebCore::SVGPathBuilder::curveToQuadratic): (WebCore::SVGPathBuilder::curveToQuadraticSmooth): (WebCore::SVGPathBuilder::arcTo):
  • svg/SVGPathConsumer.h: Added. Base class of SVGPathBuilder and SVGPathSegListBuilder. (WebCore::): (WebCore::SVGPathConsumer::SVGPathConsumer): (WebCore::SVGPathConsumer::~SVGPathConsumer):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::parseMappedAttribute): Use new PathParser to create a PathSegList.
  • svg/SVGPathParser.cpp: Added. (WebCore::SVGPathParser::SVGPathParser): (WebCore::SVGPathParser::~SVGPathParser): (WebCore::SVGPathParser::parseClosePathSegment): (WebCore::SVGPathParser::parseMoveToSegment): (WebCore::SVGPathParser::parseLineToSegment): (WebCore::SVGPathParser::parseLineToHorizontalSegment): (WebCore::SVGPathParser::parseLineToVerticalSegment): (WebCore::SVGPathParser::parseCurveToCubicSegment): (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathParser::parseArcToSegment): (WebCore::SVGPathParser::parsePathDataString): (WebCore::SVGPathParser::decomposeArcToCubic): Normalizes an arc to multiple cubic curves.
  • svg/SVGPathParser.h: Added.
  • svg/SVGPathSegListBuilder.cpp: Added. (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder): (WebCore::SVGPathSegListBuilder::build): (WebCore::SVGPathSegListBuilder::moveTo): (WebCore::SVGPathSegListBuilder::lineTo): (WebCore::SVGPathSegListBuilder::lineToHorizontal): (WebCore::SVGPathSegListBuilder::lineToVertical): (WebCore::SVGPathSegListBuilder::curveToCubic): (WebCore::SVGPathSegListBuilder::curveToCubicSmooth): (WebCore::SVGPathSegListBuilder::curveToQuadratic): (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::arcTo): (WebCore::SVGPathSegListBuilder::closePath):
  • svg/SVGPathSegListBuilder.h: Added.

2010-07-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG CleanUp of SVGPathData parsing
https://bugs.webkit.org/show_bug.cgi?id=41410

Parsing values as float instead of double causes some minimal changes on DRT results and
pixel results. Even if the values get shrinked to float before the calculation of arc and
others. But the calculation itself transforms the values back to double and shrinks it to
floats again right before the drawing.

SVG Path with an arc with radius of 0 does not render
https://bugs.webkit.org/show_bug.cgi?id=40448

Extended svg/dom/path-parser.xhml to check the correct behavior. We draw a line from the
current point to the given end point.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.checksum:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/mac/svg/custom/use-css-events-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/hixie/perf/007-expected.checksum:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/hixie/perf/007-expected.txt:
  • svg/custom/path-getTotalLength-expected.txt:
  • svg/dom/path-parser-expected.txt:
  • svg/dom/script-tests/path-parser.js:
22:28 Changeset [63720] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed trivial fix after r63684.
https://bugs.webkit.org/show_bug.cgi?id=30464

  • fast/dom/Window/window-properties-expected.txt: Updated.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
22:10 Changeset [63719] by yuzo@google.com
  • 4 edits
    2 adds in trunk

2010-07-15 Yuzo Fujishima <yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 42342 - Font download error for an @font-face rule invalidates other @font-face rules for the same font-family
https://bugs.webkit.org/show_bug.cgi?id=42342

  • fast/css/font-face-download-error-expected.txt: Added.
  • fast/css/font-face-download-error.html: Added.

2010-07-15 Yuzo Fujishima <yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 42342 - Font download error for an @font-face rule invalidates other @font-face rules for the same font-family
https://bugs.webkit.org/show_bug.cgi?id=42342

Test: fast/css/font-face-download-error.html

  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::isValid): Valid if at least one font face is valid. (WebCore::CSSSegmentedFontFace::getFontData): Check validity for each font face.
  • css/CSSSegmentedFontFace.h: Make isValid private.
21:33 Changeset [63718] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-07-19 Kent Tamura <tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[Chromium] Fix style errors of RenderThemeChromiumWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=42568

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::getNonClientMetrics): (WebCore::systemFontSize): (WebCore::pointsToPixels): (WebCore::querySystemBlinkInterval): (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
21:32 Changeset [63717] by sfalken@apple.com
  • 2 edits in trunk/WebCore

(Hopefully the last) Windows build fix.

Version of CoreServices.h in WebKit Support Libraries uses
pragma once, unlike the version I have locally. Switch based
on COLORSYNCDEPRECATED instead.

  • WebCorePrefix.h:
21:17 Changeset [63716] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Windows build fix.

  • WebCorePrefix.h:
21:09 Changeset [63715] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Remove now passing tests from the skipped list.

Reviewed by Maciej Stachowiak.

  • platform/mac-wk2/Skipped:
21:05 Changeset [63714] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Fix build.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Paths of generated files should be relative to the build product.

20:42 Changeset [63713] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/JavaScriptCore

2010-07-19 Mike Moretti <mike.moretti@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] Build fix after r63404.

Implement isValid() function for the Symbian executable allocator.

  • jit/ExecutableAllocatorSymbian.cpp: (JSC::ExecutableAllocator::isValid):
20:24 Changeset [63712] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • WebCorePrefix.h:
20:14 Changeset [63711] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • WebCorePrefix.h:
20:01 Changeset [63710] by dbates@webkit.org
  • 12 edits in trunk

2010-07-19 Daniel Bates <dbates@rim.com>

Reviewed by Adam Roben.

[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930

Implements support for markerTextForListItem in the Windows port.

  • DOMCoreClasses.cpp: (DOMElement::markerTextForListItem): Added.
  • DOMCoreClasses.h:
  • Interfaces/DOMPrivate.idl: Added declaration for markerTextForListItem().
  • Interfaces/IWebViewPrivate.idl: Added declaration for elementFromJS().
  • Interfaces/WebKit.idl: Touch it to force a rebuild (and for good luck :-)).
  • WebView.cpp: (WebView::elementFromJS): Added.
  • WebView.h:

2010-07-19 Daniel Bates <dbates@rim.com>

Reviewed by Adam Roben.

[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930

Remove skipped layout tests now that we have DRT support.

  • platform/win/Skipped:

2010-07-19 Daniel Bates <dbates@rim.com>

Reviewed by Adam Roben.

[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930

Implements DRT support for markerTextForListItem in the Windows port.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::markerTextForListItem): Implemented.
20:00 Changeset [63709] by sfalken@apple.com
  • 7 edits in trunk/WebCore

Windows Build fixes for new ColorSync API.
We support both new and old APIs, since the newer headers aren't in the tree yet.

  • WebCorePrefix.h: Removed include of CoreServices.h. Included via ColorSyncPriv.h instead, since header may not be present.
  • platform/graphics/cg/ColorCG.cpp:

(WebCore::createCGColor): Conditionally use new ColorSync API.

  • platform/graphics/opentype/OpenTypeUtilities.cpp: Define Fixed if CoreServices.h doesn't.
  • platform/graphics/win/GraphicsLayerCACF.cpp:

(WebCore::GraphicsLayerCACF::updateLayerDrawsContent): Use 0 instead of nil, since nil is no longer present via CoreServices.h.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: Include AssertMacros.h.
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::operator CFErrorRef): Use 0 instead of nil, since nil is no longer present via CoreServices.h.

19:40 Changeset [63708] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

WebKitTestRunner and WebProcess simultaneously stall in CoreIPC::Connection::sendOutgoingMessage
https://bugs.webkit.org/show_bug.cgi?id=42356

Reviewed by Sam Weinig.

Up the port queue length from 5 to 1024. While this does solve the problem, we should still try to
make sendOutgoingMessage not block. I've filed https://bugs.webkit.org/show_bug.cgi?id=42611 to track
doing this on Mac and Windows.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open):
Call setMachPortQueueLength.

  • Platform/mac/MachUtilities.cpp: Added.

(setMachPortQueueLength):
Given a mach port receive right, sets the port queue length.

  • Platform/mac/MachUtilities.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Add MachUtilities.cpp and MachUtilities.h

19:37 Changeset [63707] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-07-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Dimitri Glazkov.

Only set unloadEventEnd when the unload event is actually fired
https://bugs.webkit.org/show_bug.cgi?id=42607

r63689 introduced this ASSERT and it began failing on Qt and Mac debug.
For some reason, it did not fail on Windows (which is where I was
testing). The ASSERT was disabled in r63699.

Test: page-cache related layout tests don't crash in debug mode on Mac.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
19:03 Changeset [63706] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Don't unnecessarily copy QPainterPath in fillPath() and strokePath()
https://bugs.webkit.org/show_bug.cgi?id=42513

Avoid making unnecessary deep-copies of QPainterPaths that will
be discarded after use.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
18:44 Changeset [63705] by kbr@google.com
  • 4 edits in trunk

2010-07-19 Kenneth Russell <kbr@google.com>

Reviewed by Nate Chapin.

WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719

Fixed compiler warning introduced by original patch.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):

2010-07-19 Kenneth Russell <kbr@google.com>

Reviewed by Nate Chapin.

WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
https://bugs.webkit.org/show_bug.cgi?id=34719

Fixed compiler warning introduced by original patch. No new tests;
covered by existing tests.

  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
18:19 Changeset [63704] by andersca@apple.com
  • 10 edits in trunk

Handle NP_ASFILE and NP_ASFILEONLY transfer modes
https://bugs.webkit.org/show_bug.cgi?id=42587

Reviewed by Darin Adler, Adam Roben, Dan Bernstein and Sam Weinig.

WebCore:

  • WebCore.exp.in:

Export functions from FileSystem.h

  • platform/mac/FileSystemMac.mm:

(WebCore::openTemporaryFile):
Try to create a temporary file using mkstemp.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NPP_StreamAsFile):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add NPP_ wrapper.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::NetscapePluginStream):
Initialize m_fileHandle.

(WebKit::isSupportedTransferMode):
NP_ASFILE and NP_ASFILEONLY is now supported.

(WebKit::NetscapePluginStream::deliverData):
Call deliverDataToFile if necessary.

(WebKit::NetscapePluginStream::deliverDataToFile):
Create a temporary file and write the data into it.

(WebKit::NetscapePluginStream::stop):
If the transfer mode is either NP_ASFILE or NP_ASFILEONLY, make sure to
call NPP_StreamAsFile and close the file and delete it.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cancelStreamLoad):
Keep a reference to the Stream since cancelling it will remove it from the map.

18:01 Changeset [63703] by jberlin@webkit.org
  • 2 edits in trunk/WebKitTools

2010-07-19 Jessie Berlin <jberlin@apple.com>

Windows build fix. Unreviewed.

  • WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::initializeTestPluginPath):
17:25 Changeset [63702] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-07-19 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.
Update one more expected result missed in r63684.

  • platform/mac-leopard/accessibility/media-element-expected.txt:
17:07 Changeset [63701] by andersca@apple.com
  • 9 edits in trunk

Implement NPN_PostURLNotify
https://bugs.webkit.org/show_bug.cgi?id=42602

Reviewed by Sam Weinig.

WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):
Read the buffer from a file if necessary and parse it.

(WebKit::NPN_GetURLNotify):
Add extra arguments.

(WebKit::NPN_PostURLNotify):
Parse the post buffer, then call NetscapePlugin::loadURL.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::loadURL):
Pass the method, the header fields and form data along.

(WebKit::NetscapePlugin::allowPopups):
Just return false for now.

(WebKit::NetscapePlugin::initialize):
Pass extra arguments to loadURL.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PluginController.h:

Add method, header fields and form data.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::loadURL):
Set the method, add the header fields and set the body.

16:55 Changeset [63700] by weinig@apple.com
  • 6 edits in trunk/WebKitTools

Remove dependency on getopt from WebKitTestRunner.

Reviewed by Jon Honeycutt.

  • Simplify options parsing and eliminate unused options.
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::testPluginPath):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformInitialize):
(WTR::TestController::initializeTestPluginPath):

16:54 Changeset [63699] by tonyg@chromium.org
  • 2 edits in trunk/WebCore

2010-07-19 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Remove overzealous ASSERT from r63689
https://bugs.webkit.org/show_bug.cgi?id=42606

No new tests because no new functionality.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
16:36 Changeset [63698] by diegohcg@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-19 Diego Gonzalez <diegohcg@webkit.org>

[Qt] MiniBrowser: Progress indication at address bar
https://bugs.webkit.org/show_bug.cgi?id=42565

Reviewed by Antonio Gomes.

Make possible to see load progress at address bar based on
QtTestBrowser solution

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::loadProgress):
  • MiniBrowser/qt/BrowserWindow.h:
16:35 Changeset [63697] by diegohcg@webkit.org
  • 3 edits in trunk/WebKitTools

2010-07-19 Diego Gonzalez <diegohcg@webkit.org>

[Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
https://bugs.webkit.org/show_bug.cgi?id=42564

Reviewed by Antonio Gomes.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserView::load): (BrowserWindow::BrowserWindow): (BrowserWindow::titleChanged): (BrowserWindow::urlChanged):
  • MiniBrowser/qt/BrowserWindow.h:
16:19 Changeset [63696] by joepeck@webkit.org
  • 2 edits in trunk/WebCore

2010-07-19 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Mark Rowe.

Web Inspector: Do Not Copy *.re2js Inspector Resources in XCode Build Phase
https://bugs.webkit.org/show_bug.cgi?id=42601

Remove *.re2js files after copying them over in the Build Phase. We do
the same to remove the WebKit.qrc file.

  • WebCore.xcodeproj/project.pbxproj:
15:38 Changeset [63695] by mrowe@apple.com
  • 4 edits in branches/safari-533.17-branch/WebCore

Revert r63029 to address <rdar://problem/8202667>.

15:38 Changeset [63694] by mrowe@apple.com
  • 2 edits in branches/safari-533.17-branch/WebCore

Revert r63030 to address <rdar://problem/8202667>.

15:23 Changeset [63693] by weinig@apple.com
  • 8 edits
    10 adds in trunk/WebKitTools

Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.

Reviewed by Adam Roben.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/DerivedSources.make: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
  • WebKitTestRunner/InjectedBundle/Bindings: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.

(WTR::JSWrappable::~JSWrappable):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.

(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.

(WTR::toJS):

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):

  • WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
  • WebKitTestRunner/win/build-generated-files.sh: Added.
15:21 Changeset [63692] by ojan@chromium.org
  • 6 edits in trunk/LayoutTests

2010-07-19 Ojan Vafai <ojan@chromium.org>

Unreviewed.
[chromium] Update test expectations after r63681.
Add new expected results for the clearly correct cases after r63684.

  • platform/chromium-mac/media/video-load-networkState-expected.txt:
  • platform/chromium-mac/media/video-src-change-expected.txt:
  • platform/chromium-win/media/video-load-networkState-expected.txt:
  • platform/chromium-win/media/video-src-change-expected.txt:
  • platform/chromium/test_expectations.txt:
15:16 Changeset [63691] by eric.carlson@apple.com
  • 4 edits in trunk/LayoutTests

2010-07-19 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Update more tests/results missed in r63684.

  • accessibility/media-element.html:
  • media/unsupported-rtsp-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:
14:58 Changeset [63690] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Clean up the buildbot configuration a little.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
14:55 Changeset [63689] by tonyg@chromium.org
  • 16 edits
    3 adds in trunk

2010-07-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Move times to DocumentLoader and fix bugs in mark points
https://bugs.webkit.org/show_bug.cgi?id=42512

  • fast/dom/script-tests/webtiming-navigate-within-document.js: Added. Previously, navigating within a document via a fragment would reset navigationStart. This test verifies that no times are changed after navigating within a document. (checkTimingNotChanged): (): (loadHandler):
  • fast/dom/webtiming-expected.txt: Test now passes because when correcting for clock skew, requestTime is set to fetchStart when it is less than fetchStart. Previously it was 0, now it is fetchStart. This, unfortunately, hides the fact that test_shell isn't populating the ResourceLoadTiming API. I'll think of a way to test that when I make the change to cause test_shell to fill the ResourceLoadTiming.
  • fast/dom/webtiming-navigate-within-document-expected.txt: Added.
  • fast/dom/webtiming-navigate-within-document.html: Added.
  • platform/gtk/Skipped: Skip new test on platform where Web Timing is not enabled.
  • platform/mac/Skipped: Skip new test on platform where Web Timing is not enabled.
  • platform/qt/Skipped: Skip new test on platform where Web Timing is not enabled.
  • platform/win/Skipped: Skip new test on platform where Web Timing is not enabled.

2010-07-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Move times to DocumentLoader and fix bugs in mark points
https://bugs.webkit.org/show_bug.cgi?id=42512

Test: fast/dom/webtiming-navigate-within-document.html

  • loader/DocumentLoader.h: Move the FrameLoadTimeline (now call DocumentLoadTiming) to the DocumentLoader. (WebCore::DocumentLoader::documentLoadTiming):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Set unloadEventEnd on the provisional DocumentLoader. Add some ASSERTs to tighten things up. (WebCore::FrameLoader::loadWithDocumentLoader): This was not the right place to set navigationStart. Setting it here caused it to be set before the unload form prompt and caused it to be reset when navigating within the document. (WebCore::FrameLoader::finishedLoading): Set responseEnd on the active DocumentLoader. (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): This is the right place for navigationStart as defined by the spec.
  • loader/FrameLoader.h: Get rid of FrameLoadTimeline.
  • loader/FrameLoaderTypes.h: Rename FrameLoadTimeline to DocumentLoadTiming. It is even more apparent this doesn't belong in this file now. I am planning to submit a patch moving it out ASAP, but didn't want to muddy this patch with all those build files. (WebCore::DocumentLoadTiming::DocumentLoadTiming):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Move fetchStart out of this method to load(), and rewrite setting of redirectStart, redirectEnd, and redirectCount to be more readable. (WebCore::MainResourceLoader::load): Set fetchStart slightly earlier here and tighten it up with some ASSERTs.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Set loadEventStart and loadEventEnd on the DocumentLoader.
  • page/Navigation.cpp: (WebCore::Navigation::redirectCount): Retrieve redirectCount from the DocumentLoader.
  • page/Timing.cpp: (WebCore::getPossiblySkewedTimeInKnownRange): The skew problem turned out to be due to the fact that chromium's currentTime() implementation only syncs to the system time every 60 seconds. So absolute times across threads may be skewed slightly. I resolved this temporarily by clipping the time from another thread into a known bound. A better long term solution is probably to add a currentTimeFromSystemTime() method and call that for web timing marks. (WebCore::Timing::navigationStart): (WebCore::Timing::unloadEventEnd): (WebCore::Timing::redirectStart): (WebCore::Timing::redirectEnd): (WebCore::Timing::fetchStart): (WebCore::Timing::domainLookupStart): (WebCore::Timing::domainLookupEnd): (WebCore::Timing::connectStart): (WebCore::Timing::connectEnd): (WebCore::Timing::requestStart): (WebCore::Timing::requestEnd): (WebCore::Timing::responseStart): (WebCore::Timing::responseEnd): (WebCore::Timing::loadEventStart): (WebCore::Timing::loadEventEnd): (WebCore::Timing::documentLoader): (WebCore::Timing::documentLoadTiming): (WebCore::Timing::resourceLoadTiming): (WebCore::Timing::resourceLoadTimeRelativeToAbsolute): Ensure requestTime is in the range of fetchStart to responseEnd.
  • page/Timing.h:
14:18 Changeset [63688] by cmarrin@apple.com
  • 8 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=42118
Disable WebGL on Leopard for now.

LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
software OpenGL driver on machines without this support.

14:05 Changeset [63687] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2010-07-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Brady Eidson.

Fix MiniBrowser to update URL as you browse
https://bugs.webkit.org/show_bug.cgi?id=42591

Hook up various loading notifications to update the URL bar in MiniBrowser.

  • MiniBrowser/mac/BrowserWindowController.m: (_didStartProvisionalLoadForFrame): (_didReceiveServerRedirectForProvisionalLoadForFrame): (_didFailProvisionalLoadWithErrorForFrame): (_didCommitLoadForFrame): (_didFailLoadWithErrorForFrame): (-[BrowserWindowController updateProvisionalURLForFrame:]): (-[BrowserWindowController didStartProvisionalLoadForFrame:]): (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]): (-[BrowserWindowController didFailLoadWithErrorForFrame:]): (-[BrowserWindowController didCommitLoadForFrame:]):
13:53 Changeset [63686] by eric.carlson@apple.com
  • 4 edits in trunk/LayoutTests

2010-07-19 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Update tests/results missed in r63684.

  • media/video-error-does-not-exist-expected.txt:
  • media/video-load-networkState-expected.txt:
  • media/video-load-networkState.html:
13:38 Changeset [63685] by ap@apple.com
  • 2 edits
    3 copies
    2 adds in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=42586
Log all canceled authentication attempts in DumpRenderTree

Updating test results.

  • platform/mac-tiger/http/tests/xmlhttprequest/failed-auth-expected.txt: There are custom results for Tiger, adding new printout to it, as well.
  • platform/gtk/http/tests/misc: Added.
  • platform/gtk/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt.
  • platform/gtk/http/tests/xmlhttprequest: Added.
  • platform/gtk/http/tests/xmlhttprequest/failed-auth-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt.
  • platform/qt/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt. These platforms don't seem to have auth delegate calls, so we can't log auth dialogs.
13:11 Changeset [63684] by eric.carlson@apple.com
  • 19 edits in trunk

2010-07-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464
<rdar://problem/5650561>

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_completelyLoaded. (WebCore::HTMLMediaElement::parseMappedAttribute): Don't deal with 'load' event. (WebCore::HTMLMediaElement::prepareForLoad): Set m_completelyLoaded to false. (WebCore::HTMLMediaElement::setNetworkState): Don't post 'load' event. (WebCore::HTMLMediaElement::progressEventTimerFired): Bail if m_networkState != NETWORK_LOADING. (WebCore::HTMLMediaElement::userCancelledLoad): No more NETWORK_LOADED state.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::):
  • html/HTMLMediaElement.idl: Remove NETWORK_LOADING.

2010-07-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

Remove HTML5 media element 'load' event
https://bugs.webkit.org/show_bug.cgi?id=30464
<rdar://problem/5650561>

  • media/audio-delete-while-slider-thumb-clicked.html: Trigger test on 'canplaythrough' instead of 'load'.
  • media/audio-delete-while-step-button-clicked.html: Ditto.
  • media/event-attributes-expected.txt:
  • media/event-attributes.html: Correct logic to check that 'progress' event(s) are fired while loading file, but not when src set to invalid file. 'abort' event is fired when the src is changed.
  • media/invalid-media-url-crash-expected.txt:
  • media/media-constants-expected.txt: No more NETWORK_LOADED state.
  • media/media-constants.html: No more NETWORK_LOADED state. Clean up test.
  • media/remove-from-document-expected.txt:
  • media/remove-from-document.html: Ditto.
  • media/video-controls-visible-audio-only.html: Trigger test on 'canplaythrough' instead of 'load'.
  • media/video-source-none-supported-expected.txt: No more NETWORK_LOADED state.
  • media/video-src-change-expected.txt: Ditto.
  • media/video-src-none-expected.txt:
  • media/video-src-none.html: No more NETWORK_LOADED state. Fix bogus test that generated "FAIL" in results.
13:08 Changeset [63683] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2010-07-19 Ojan Vafai <ojan@chromium.org>

Unreviewed.

[chromium] Update test_expectations with passing/flaky tests.
Add new chromium expected result from r63680.

  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
  • platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
  • platform/chromium/test_expectations.txt:
13:08 Changeset [63682] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Add local storage support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42584

Reviewed by Darin Adler.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::swap):

  • Shared/WebPreferencesStore.h:

(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLocalStorageEnabled):
(WKPreferencesGetLocalStorageEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setLocalStorageEnabled):
(WebKit::WebPreferences::localStorageEnabled):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::preferencesDidChange):

13:03 Changeset [63681] by ap@apple.com
  • 6 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=42586
Log all canceled authentication attempts in DumpRenderTree

  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge): It's important to know whether an auth sheet appeared. Added logging to "no preset credentials" case.
11:46 Changeset [63680] by ap@apple.com
  • 9 edits
    5 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=40996
Progress event should not be fired during synchronous XMLHttpRequest

https://bugs.webkit.org/show_bug.cgi?id=17502
Assertion failure when trying to restart a sync XMLHttpRequest as an async one from onreadystatechange

Tests: http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events.html

http/tests/xmlhttprequest/xmlhttprequest-sync-vs-async-assertion-failure.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): We now only dispatch readystatechange event for synchronous requests in states UNSENT, OPENED and DONE. I'm not sure what exactly the spec draft says about readystatechange for sync requests, but this seems to be the most logical and backwards compatible behavior. (WebCore::XMLHttpRequest::didReceiveData): Don't dispatch progress events for sync requests. Note that we already don't dispatch upload progress events for those.
11:09 Changeset [63679] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578

  • platform/qt/Skipped: Add tests again until fix which were unskipped by r63657.
10:45 Changeset [63678] by ojan@chromium.org
  • 6 edits in trunk/LayoutTests

2010-07-19 Ojan Vafai <ojan@chromium.org>

Unreviewed. Update expectations from http://trac.webkit.org/changeset/63672
and cleanup some unexpected passes.

  • platform/chromium-linux/fast/forms/hidden-listbox-expected.checksum:
  • platform/chromium-linux/fast/forms/hidden-listbox-expected.png:
  • platform/chromium-win/fast/forms/hidden-listbox-expected.checksum:
  • platform/chromium-win/fast/forms/hidden-listbox-expected.png:
  • platform/chromium/test_expectations.txt:
10:34 Changeset [63677] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit2

2010-07-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Uae an OwnPtr for the drawing area in WebPage (fixes a leak!).

  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::drawingArea):
10:26 Changeset [63676] by tony@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-07-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] refactor npapi plugin copy step
https://bugs.webkit.org/show_bug.cgi?id=42493

This is to avoid duplicate copy rules in the Linux make build.

  • WebKit.gyp:
  • DEPS: 52483:52869
10:19 Changeset [63675] by darin@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-07-16 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Use OwnPtr for CodeBlock objects
https://bugs.webkit.org/show_bug.cgi?id=42490

  • runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): Moved this here and made it non-inline. Eliminated the code that used to initialize the raw pointer since it's now an OwnPtr. (JSC::EvalExecutable::~EvalExecutable): Removed the explicit delete here. (JSC::ProgramExecutable::ProgramExecutable): Ditto. (JSC::ProgramExecutable::~ProgramExecutable): Ditto. (JSC::FunctionExecutable::FunctionExecutable): Ditto. (JSC::FunctionExecutable::~FunctionExecutable): Ditto. (JSC::EvalExecutable::compileInternal): Added use of adoptPtr and get. (JSC::ProgramExecutable::compileInternal): Ditto. (JSC::FunctionExecutable::compileForCallInternal): Ditto. (JSC::FunctionExecutable::compileForConstructInternal): Ditto. (JSC::FunctionExecutable::recompile): Use clear instead of delete followed by assignment of 0.
  • runtime/Executable.h: Moved constructors to the cpp file and changed raw pointers to OwnPtr.
10:18 Changeset [63674] by weinig@apple.com
  • 7 edits
    3 deletes in trunk/WebKitTools

2010-07-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r63671.
http://trac.webkit.org/changeset/63671
https://bugs.webkit.org/show_bug.cgi?id=42575

broke windows (Requested by weinig on #webkit).

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/DerivedSources.make: Removed.
  • WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): (WTR::InjectedBundlePage::setStatusbarText):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setWaitToDump): (WTR::displayCallback): (WTR::dumpAsTextCallback): (WTR::dumpStatusCallbacksCallback): (WTR::waitUntilDoneCallback): (WTR::notifyDoneCallback): (WTR::numberOfActiveAnimationsCallback): (WTR::pauseAnimationAtTimeOnElementWithIdCallback): (WTR::repaintSweepHorizontallyCallback): (WTR::testRepaintCallback): (WTR::layoutTestControllerObjectFinalize): (WTR::LayoutTestController::makeWindowObject): (WTR::LayoutTestController::getJSClass): (WTR::LayoutTestController::staticFunctions):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpAsText): (WTR::LayoutTestController::setDumpAsText): (WTR::LayoutTestController::dumpStatusCallbacks): (WTR::LayoutTestController::setDumpStatusCallbacks): (WTR::LayoutTestController::setTestRepaint): (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
10:13 Changeset [63673] by chang.shu@nokia.com
  • 2 edits in trunk/LayoutTests

2010-07-19 Chang Shu <chang.shu@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix eol-style propety for the following file, otherwise svn-apply will fail.
https://bugs.webkit.org/show_bug.cgi?id=42573

  • canvas/philip/tests.js: Added property svn:eol-style.
09:48 Changeset [63672] by mitz@apple.com
  • 4 edits
    8 adds in trunk

<rdar://problem/7232109> Unpainted white area appears at the edge of the page when body has bg color
https://bugs.webkit.org/show_bug.cgi?id=34913

Reviewed by Simon Fraser.

WebCore:

Tests: fast/repaint/view-background-from-body-1.html

fast/repaint/view-background-from-body-2.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleWillChange): If this is the body renderer and its current style is
null, repaint the view, similarly to how the view is repainted for any repaint-or-higher
style changes.

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode): If the removed child is the body renderer,
repaint the view, in case the body’s background was propagated to the view.

LayoutTests:

  • fast/repaint/view-background-from-body-1.html: Added.
  • fast/repaint/view-background-from-body-2.html: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.checksum: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.png: Added.
  • platform/mac/fast/repaint/view-background-from-body-1-expected.txt: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.checksum: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.png: Added.
  • platform/mac/fast/repaint/view-background-from-body-2-expected.txt: Added.
09:43 Changeset [63671] by weinig@apple.com
  • 7 edits
    8 adds in trunk/WebKitTools

Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
Auto-generate the JS bindings for WebKitTestRunner's script objects.

Reviewed by Adam Roben.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/DerivedSources.make: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
  • WebKitTestRunner/InjectedBundle/Bindings: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
  • WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.

(WTR::JSWrappable::~JSWrappable):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.

(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):

  • WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.

(WTR::toJS):

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::setStatusbarText):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::wrapperClass):
(WTR::LayoutTestController::waitUntilDone):
(WTR::LayoutTestController::makeWindowObject):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::shouldDumpAsText):
(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::shouldDumpStatusCallbacks):
(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::waitToDump):
(WTR::LayoutTestController::testRepaint):
(WTR::LayoutTestController::repaintSweepHorizontally):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
09:39 Changeset [63670] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-19 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

fix chromium linux compile on ubuntu maverick
https://bugs.webkit.org/show_bug.cgi?id=42528

  • Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
09:23 Changeset [63669] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-19 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Live edit is not working in chromium.
https://bugs.webkit.org/show_bug.cgi?id=42572

  • src/js/DebuggerScript.js:
09:21 Changeset [63668] by aroben@apple.com
  • 4 edits in trunk/WebKitTools

When dumping a response's MIME type, print its URL's last path component rather than its suitable-for-test-result form

This matches the Mac behavior.

Fixes <http://webkit.org/b/42276>
http/tests/loading/preload-slow-loading.php and
http/tests/mime/uppercase-mime-type.html fail on Windows

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(urlSuitableForTestResult): Moved code to actually extract the last
path component from here...
(lastPathComponent): ...to here.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
component, rather than its suitable-for-test-result form, to match
Mac.

09:21 Changeset [63667] by aroben@apple.com
  • 2 edits in trunk/WebCore

Fix an assertion when a plugin returns -1 from NPP_Write

We were forgetting to call setDefersLoading(false) before destroying
the PluginStream. In the process of destroying the stream, someone
would call setDefersLoading(true), and we would assert because we were
already deferring loads.

Fixes <http://webkit.org/b/42563> Assertion failure in
ResourceHandle::setDefersLoading when running
plugins/return-negative-one-from-write.html on Windows

Reviewed by Anders Carlsson.

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::deliverData): Call setDefersLoading(false)
before destroying the stream, to match the setDefersLoading(true) call
earlier in this function. (We already call setDefersLoading(false) in
the non-error case later on.)

09:06 Changeset [63666] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-19 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Fix some EFL theme issues
https://bugs.webkit.org/show_bug.cgi?id=42569

Keep a pointer to theme filename and check for it correctly.
Reduce the scope of some variables.
Don't test for platformWidget() since we are not using it.

No new tests, no new functionality.

  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyCursor): (WebCore::Widget::setCursor):
08:52 Changeset [63665] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-19 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Add ifdef to compile code just on presence of Ecore_X
https://bugs.webkit.org/show_bug.cgi?id=42567

No new tests since there's no new functionality.

  • platform/efl/WidgetEfl.cpp: (WebCore::Widget::setEvasObject): Add #ifdef HAVE_ECORE_X to it.
08:29 Changeset [63664] by andersca@apple.com
  • 19 edits
    2 copies in trunk

WebKit2 does not have application cache
https://bugs.webkit.org/show_bug.cgi?id=42552

Reviewed by Adam Roben.

WebKit2:

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):
Add SetApplicationCacheDirectory.

  • Shared/WebPreferencesStore.h:

(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
add offlineWebApplicationCacheEnabled.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetOfflineWebApplicationCacheEnabled):
(WKPreferencesGetOfflineWebApplicationCacheEnabled):

  • UIProcess/API/C/WKPreferences.h:

Add getters/setters for whether the application cache is enabled.

  • UIProcess/WebContext.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setOfflineWebApplicationCacheEnabled):
Update the store and call update().

  • UIProcess/WebPreferences.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
Ask the web process to set the application cache directory.

  • UIProcess/mac/WebContextMac.mm: Added.

(WebKit::WebContext::applicationCacheDirectory):
Return the application cache directory.

  • UIProcess/win/WebContextWin.cpp: Added.

(WebKit::WebContext::applicationCacheDirectory):
Ditto.

  • WebKit2.xcodeproj/project.pbxproj:

Add WebContextMac.mm

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::preferencesDidChange):

(WebKit::WebPage::didReceiveMessage):
Handle PreferencesDidChange. Get rid of the default: case statement so we'll
get warnings if we have unhandled message kinds.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setApplicationCacheDirectory):
Set the application cache directory.

(WebKit::WebProcess::didReceiveMessage):
Handle SetApplicationCacheDirectory.

win/WebKit2.vcproj:
Add WebContextWin.cpp

WebKitTools:

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::resetPreferencesToConsistentValues):
Set up default preferences. Right now just enables the web application cache.

(WTR::TestInvocation::invoke):
Call resetPreferencesToConsistentValues.

  • WebKitTestRunner/TestInvocation.h:

LayoutTests:

  • platform/mac-wk2/Skipped:

Remove http/tests/appcache from skipped list.

08:23 Changeset [63663] by yurys@chromium.org
  • 5 edits in trunk

2010-07-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[chromium] inspector/console-trace.html failing on windows after r63548
https://bugs.webkit.org/show_bug.cgi?id=42485

  • inspector/console-trace.html: call dumpConsoleMessages sycnhronously right after console.trace
  • platform/chromium/test_expectations.txt:

2010-07-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add/removeStyleClass shouldn't increase number of spaces between class names.
https://bugs.webkit.org/show_bug.cgi?id=42485

  • inspector/front-end/utilities.js: (Element.prototype.removeStyleClass):
08:19 Changeset [63662] by yurys@chromium.org
  • 15 edits in trunk/WebCore

2010-07-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show stack trace for uncaught exceptions when Web Inspector is open.
https://bugs.webkit.org/show_bug.cgi?id=42560

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::dispatchNow): (WebCore::V8ConsoleMessage::handler):
  • bindings/v8/V8ConsoleMessage.h:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend):
  • inspector/InspectorController.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage): (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement): (WebInspector.ConsoleMessage.prototype._addMessageHeader): (WebInspector.ConsoleMessage.prototype.toString):
  • inspector/front-end/inspector.css: (.console-message.repeated-message > ol.stack-trace): (.section .properties ol, .event-properties ol, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.section .properties ol.expanded, .event-properties ol.expanded, .stack-trace ol, ol.stack-trace):
  • page/Console.cpp: (WebCore::Console::addMessage):
  • page/Console.h: (WebCore::):
08:12 Changeset [63661] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-07-19 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Roben.

Fix NewRunWebKitTests to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=41180

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Specifying python explicitly.
08:05 Changeset [63660] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-07-19 Robin Burchell <robin.burchell@collabora.co.uk>

Reviewed by Antonio Gomes

[Qt] Use memcpy() instead of qMemCopy()
This is supposed to be more efficient, as the compiler is able to
optimise more.

Additionally, qMemCopy() is only strictly supposed to be used in
headers (see Qt's src/corelib/qglobal.h for reference)
See: https://bugs.webkit.org/show_bug.cgi?id=42392

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
07:52 Changeset [63659] by andreas.kling@nokia.com
  • 4 edits in trunk/WebCore

2010-07-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas: Rename operator==(CanvasStyle,CanvasStyle) since it isn't a proper equality check
https://bugs.webkit.org/show_bug.cgi?id=42284

New name is isEquivalentColor(CanvasStyle).

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle):
  • html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::isEquivalentColor):
  • html/canvas/CanvasStyle.h:
07:50 Changeset [63658] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Remove non-existent files from Skipped list.

  • platform/qt/Skipped:
    • Unskip fast/dynamic/flash-replacement-test.html, because it was removed by r61289
    • Rename fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Applying_the_percent_Operator/S11.5.3_A4_T2.html after r63284
    • Unskip inspector/debugger-breakpoints-not-activated-on-reload.html, because it was removed by r63314
    • Unskip media/video-src-empty.html, because it was removed by r63119
07:27 Changeset [63657] by andreas.kling@nokia.com
  • 5 edits in trunk

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Canvas: Wrong internal positioning of drawImage() shadows
https://bugs.webkit.org/show_bug.cgi?id=42510

  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Canvas: Wrong internal positioning of drawImage() shadows
https://bugs.webkit.org/show_bug.cgi?id=42510

Unskip:

  • canvas/philip/tests/2d.shadow.canvas.alpha.html
  • canvas/philip/tests/2d.shadow.canvas.transparent.1.html
  • canvas/philip/tests/2d.shadow.canvas.transparent.2.html
  • canvas/philip/tests/2d.shadow.image.alpha.html
  • canvas/philip/tests/2d.shadow.image.transparent.1.html
  • canvas/philip/tests/2d.shadow.image.transparent.2.html
  • platform/qt/Skipped:
07:24 Changeset [63656] by andreas.kling@nokia.com
  • 4 edits in trunk

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Render shadow when drawing one canvas onto another
https://bugs.webkit.org/show_bug.cgi?id=42508

  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Render shadow when drawing one canvas onto another
https://bugs.webkit.org/show_bug.cgi?id=42508

Unskip:

  • canvas/philip/tests/2d.shadow.canvas.basic.html

Reskip (bug now exposed):

  • canvas/philip/tests/2d.shadow.canvas.transparent.1.html
  • platform/qt/Skipped:
07:12 Changeset [63655] by ossy@webkit.org
  • 1 edit
    45 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected results for new passing SVG tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.checksum: Added.
  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
  • platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.txt: Added.
  • platform/qt/svg/custom/convolution-crash-expected.checksum: Added.
  • platform/qt/svg/custom/convolution-crash-expected.png: Added.
  • platform/qt/svg/custom/convolution-crash-expected.txt: Added.
  • platform/qt/svg/custom/marker-child-changes-css-expected.checksum: Added.
  • platform/qt/svg/custom/marker-child-changes-css-expected.png: Added.
  • platform/qt/svg/custom/marker-child-changes-css-expected.txt: Copied from LayoutTests/platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt.
  • platform/qt/svg/custom/recursive-gradient-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-gradient-expected.png: Added.
  • platform/qt/svg/custom/recursive-gradient-expected.txt: Added.
  • platform/qt/svg/custom/recursive-mask-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-mask-expected.png: Added.
  • platform/qt/svg/custom/recursive-mask-expected.txt: Added.
  • platform/qt/svg/custom/recursive-pattern-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-pattern-expected.png: Added.
  • platform/qt/svg/custom/recursive-pattern-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.png: Added.
  • platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.checksum: Added.
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.png: Added.
  • platform/qt/svg/custom/relative-sized-inner-svg-expected.txt: Added.
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.checksum: Added.
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png: Added.
  • platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt: Added.
  • platform/qt/svg/custom/repaint-moving-svg-and-div-expected.checksum: Added.
  • platform/qt/svg/custom/repaint-moving-svg-and-div-expected.png: Added.
  • platform/qt/svg/custom/repaint-moving-svg-and-div-expected.txt: Added.
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.checksum: Added.
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt: Added.
  • platform/qt/svg/custom/text-rotated-gradient-expected.checksum: Added.
  • platform/qt/svg/custom/text-rotated-gradient-expected.png: Added.
  • platform/qt/svg/custom/text-rotated-gradient-expected.txt: Added.
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/use-property-synchronization-crash-expected.checksum.
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.png: Copied from LayoutTests/platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
  • platform/qt/svg/custom/use-property-synchronization-crash-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt.
  • platform/qt/svg/filters/filter-empty-g-expected.checksum: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.checksum.
  • platform/qt/svg/filters/filter-empty-g-expected.png: Copied from LayoutTests/platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
  • platform/qt/svg/filters/filter-empty-g-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filter-empty-g-expected.txt.
  • platform/qt/svg/filters/filter-width-update-expected.checksum: Added.
  • platform/qt/svg/filters/filter-width-update-expected.png: Added.
  • platform/qt/svg/filters/filter-width-update-expected.txt: Added.
07:08 Changeset [63654] by andreas.kling@nokia.com
  • 4 edits in trunk

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Some composition modes fail when color has alpha zero
https://bugs.webkit.org/show_bug.cgi?id=36973

Remove erroneous optimization that ignored painting calls when
the stroke/fill color had an alpha value of zero.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Some composition modes fail when color has alpha zero
https://bugs.webkit.org/show_bug.cgi?id=36973

Unskip fast/canvas/canvas-composite-alpha.html

  • platform/qt/Skipped:
07:06 Changeset [63653] by andreas.kling@nokia.com
  • 3 edits
    1 add in trunk/WebCore

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

CSS3 background: Number of layers should be determined by background-image element count
https://bugs.webkit.org/show_bug.cgi?id=41201

Manual test: css3-background-layer-count.html

Spec link:
http://www.w3.org/TR/css3-background/#layering

  • manual-tests/css3-background-layer-count.html: Added.
  • rendering/style/FillLayer.cpp: (WebCore::FillLayer::fillUnsetProperties): Don't repeat image properties, they determine the total number of layers. (WebCore::FillLayer::cullEmptyLayers): Change culling logic to discard all layers after the first one without an image set.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::adjustBackgroundLayers): Call fillUnsetProperties() before cullEmptyLayers() (WebCore::InheritedFlags::adjustMaskLayers): Ditto.
05:45 Changeset [63652] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-07-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Avoid QImage::pixel() in getImageData()
https://bugs.webkit.org/show_bug.cgi?id=42463

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): Use QImage::scanLine() instead of fetching data pixel-by-pixel.
05:43 Changeset [63651] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-07-19 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Fix build on 64-bit systems. According to
JavaScriptCore/wtf/Platform.h, x86_64 uses fixed allocator, which
needs jit/ExecutableAllocatorFixedVMPool.cpp to be included in build
system.
https://bugs.webkit.org/show_bug.cgi?id=42559

  • CMakeListsEfl.txt: add missing file for x86_64.
05:28 Changeset [63650] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-07-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] Fix test expectations
https://bugs.webkit.org/show_bug.cgi?id=42556

text-rotated-gradient.svg is flaky on linux, and clip-path-child-changes.svg
isn't actually flaky.

  • platform/chromium/test_expectations.txt:
05:17 Changeset [63649] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-07-19 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: hide "toggle debugger" button when debugger is always enabled
https://bugs.webkit.org/show_bug.cgi?id=42558

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
04:52 Changeset [63648] by ager@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-07-19 Mads Ager <ager@chromium.org>

Reviewed by Pavel Feldman.

Remove chromium rebaselines for document.all layout test.
https://bugs.webkit.org/show_bug.cgi?id=42557

V8 changed behavior to match JSC completely on document.all. Remove
chromium rebaseline.

  • platform/chromium-mac/fast/dom/undetectable-document-all-expected.txt: Removed.
  • platform/chromium-win/fast/dom/undetectable-document-all-expected.txt: Removed.
03:54 Changeset [63647] by kent.hansen@nokia.com
  • 2 edits in trunk/LayoutTests

2010-07-19 Kent Hansen <kent.hansen@nokia.com>

Unreviewed, fix failure introduced in r63645.
Ignore jscprint property since it only appears in
debug builds (as per window-property-descriptors test).

  • fast/dom/Window/window-properties.html:
02:40 Changeset [63646] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-07-19 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

Explicitly declare DeviceOrientationEvent destructor and define it in the .cpp file
https://bugs.webkit.org/show_bug.cgi?id=42466

(Original problem at https://bugs.webkit.org/show_bug.cgi?id=42447)

No new functionality so no new tests.

  • dom/DeviceOrientationEvent.cpp: (WebCore::DeviceOrientationEvent::~DeviceOrientationEvent): Move here to avoid needing to have the full declaration of DeviceOrientation in DeviceOrientationEvent.h.
  • dom/DeviceOrientationEvent.h:
01:23 Changeset [63645] by kent.hansen@nokia.com
  • 5 edits in trunk/LayoutTests

2010-07-19 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Sam Weinig.

Improve coverage of fast/dom/Window/window-properties test
https://bugs.webkit.org/show_bug.cgi?id=42258

Use Object.getOwnPropertyNames to cover ECMA properties
and other native properties.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:

07/18/10:

22:39 Changeset [63644] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2010-07-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Add more items to the WebKit2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=42551

  • platform/mac-wk2/Skipped:
22:16 Changeset [63643] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix Build.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):

21:51 Changeset [63642] by andersca@apple.com
  • 2 edits in trunk/WebCore

Always set the current NSGraphicsContext before calling drawWithFrame
https://bugs.webkit.org/show_bug.cgi?id=42542

Reviewed by Dan Bernstein.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):

20:49 Changeset [63641] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-07-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] tst_QWebPage fails cursorMovements and textSelection
https://bugs.webkit.org/show_bug.cgi?id=42531

Correct the HTML used by these tests.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements): (tst_QWebPage::textSelection): (tst_QWebPage::textEditing):
18:10 Changeset [63640] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Another attempt at fixing the Windows build.

  • WebProcess/Plugins/NPJSObjectMap.h:
17:13 Changeset [63639] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Try to fix Windows build.

  • win/WebKit2.vcproj:
17:11 WebKit Team edited by ddkilzer@webkit.org
(diff)
17:09 Changeset [63638] by andersca@apple.com
  • 10 edits
    1 move
    1 delete in trunk

Move PluginWidget to WebKit
https://bugs.webkit.org/show_bug.cgi?id=42530

Reviewed by Sam Weinig.

WebCore:

Rename the PluginWidget class to PluginViewBase and make it an abstract base class.

This is a stopgap measure until we have a single PluginView class that we can use everywhere.

  • WebCore.exp.in:

Remove PluginWidget symbols.

  • WebCore.xcodeproj/project.pbxproj:

Update.

  • platform/Widget.h:

(WebCore::Widget::isPluginViewBase):
Return false.

  • plugins/PluginViewBase.h: Added.

(WebCore::PluginViewBase::platformLayer):
Always return 0 here now.

(WebCore::PluginViewBase::isPluginViewBase):
Return true.

  • plugins/PluginWidget.h: Removed.
  • plugins/mac/PluginWidgetMac.mm: Removed.
  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
Cast to PluginWidgetBase instead.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
Cast to PluginWidgetBase instead.

WebKit/mac:

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView pluginLayer]):
Add default pluginLayer implementation.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(PluginWidget::PluginWidget):
(PluginWidget::invalidateRect):
Move the guts of PluginWidget here from WebCore.

(NetscapePluginWidget::platformLayer):
Get the layer from the plug-in view.

16:45 WebKit Team edited by ddkilzer@webkit.org
(diff)
15:55 Changeset [63637] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-07-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] tst_QWebElement fails firstChildNextSibling and lastChildPreviousSibling
https://bugs.webkit.org/show_bug.cgi?id=42527

Correct the HTML used by these tests.

  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::firstChildNextSibling): (tst_QWebElement::lastChildPreviousSibling):
15:27 Changeset [63636] by andersca@apple.com
  • 5 edits in trunk/WebKit2

More NPRuntime work
https://bugs.webkit.org/show_bug.cgi?id=42526

Reviewed by Sam Weinig.

  • WebProcess/Plugins/NPJSObjectMap.cpp:

(WebKit::identifierFromIdentifierRep):
(WebKit::NPJSObject::hasProperty):
Check if the JSObject has the given property.

(WebKit::NPJSObject::getProperty):
Add stubbed out function.

(WebKit::NPJSObject::npClass):
Add NP_HasProperty and NP_GetProperty.

(WebKit::NPJSObject::NP_HasProperty):
Call NPJSObject::hasProperty.

(WebKit::NPJSObject::NP_GetProperty):
Call NPJSObject::getProperty.

  • WebProcess/Plugins/NPRuntimeUtilities.cpp:

(WebKit::releaseNPVariantValue):
Release the given NPVariant.

  • WebProcess/Plugins/NPRuntimeUtilities.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetProperty):
Call the NPClass GetProperty function.

(WebKit::NPN_HasProperty):
Call the NPClass HasProperty function.

(WebKit::NPN_ReleaseVariantValue):
Call releaseNPVariantValue.

15:25 Changeset [63635] by dino@apple.com
  • 3 edits in trunk/LayoutTests

2010-07-18 Dean Jackson <dino@apple.com>

Unreviewed (although this was discussed with SimonF in
original review).

https://bugs.webkit.org/show_bug.cgi?id=41259

Unfortunately the test in the previous commit is platform
specific (I was hoping it would not be) and is failing
the bots. This update exercises the same thing, but doesn't
check for exact values.

  • fast/transforms/scrollIntoView-transformed-expected.txt:
  • fast/transforms/scrollIntoView-transformed.html:
15:01 Changeset [63634] by dino@apple.com
  • 2 edits in trunk/WebCore

2010-07-18 Dean Jackson <dino@apple.com>

Unreviewed.

Remove the unwanted extra line that Xcode
added in my last commit.

  • WebCore.xcodeproj/project.pbxproj:
14:55 Changeset [63633] by dino@apple.com
  • 5 edits
    2 adds in trunk

2010-07-18 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=41259
Interacting with a <select> element within a transformed and clipped
container scrolls the container

The Node::getRect and ContainerNode::getRect functions were not
transform-aware. This fixes both, and has a test to make sure
we're not breaking any existing scrollToView code. This means
that a <select> popup will appear in the correct place if it
is within a transformed and scrolled container.

The test makes sure that existing scrollToView
code doesn't break, but also checks that a <select> popup will appear
in the correct place.

Test: fast/transforms/scrollIntoView-transformed.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
  • make sure we call localToAbsolute in the right order (after we've done a local move) and pass in the flags to indicate it should look for transforms.
  • dom/Node.cpp: (WebCore::Node::getRect):
  • make sure localToAbsolute gets told to look for transforms.
14:38 Changeset [63632] by ddkilzer@apple.com
  • 7 edits in trunk/WebKit/mac

<http://webkit.org/b/42522> Add missing (id) return type to Obj-C methods

Reviewed by Dan Bernstein.

  • Carbon/CarbonWindowAdapter.mm:

(-[NSWindow(HIWebFrameView) _initContent:styleMask:backing:defer:contentView:]):
(-[CarbonWindowAdapter _destroyRealWindow:]):
(-[CarbonWindowAdapter _clearModalWindowLevel]):

  • Misc/WebIconDatabase.mm:

(-[WebIconDatabase init]):

  • Misc/WebNSPasteboardExtras.mm:

(-[NSFilePromiseDragSource initWithSource:]):

  • WebView/WebHTMLRepresentation.mm:

(-[WebHTMLRepresentation init]):

  • WebView/WebPreferences.mm:

(-[WebPreferences init]):

  • WebView/WebView.mm:

(-[WebView UIDelegate]):
(-[WebView resourceLoadDelegate]):
(-[WebView downloadDelegate]):
(-[WebView policyDelegate]):
(-[WebView frameLoadDelegate]):

14:33 Changeset [63631] by andersca@apple.com
  • 6 edits
    2 adds in trunk

Add NPJSObjectMap class
https://bugs.webkit.org/show_bug.cgi?id=42524

Reviewed by Sam Weinig.

WebCore:

Export ScriptController functions.

  • WebCore.exp.in:

WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

  • WebProcess/Plugins/NPJSObjectMap.cpp: Added.
  • WebProcess/Plugins/NPJSObjectMap.h: Added.

Add NPJSObjectMap, a map which contains NPObjects that wrap JavaScript objects.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Initialize the map.

(WebKit::PluginView::~PluginView):
Invalidate the map.

(WebKit::PluginView::frame):
Add frame getter.

(WebKit::PluginView::windowScriptNPObject):
Wrap the window object.

(WebKit::PluginView::pluginElementNPObject):
Wrap the plug-in element object.

  • WebProcess/Plugins/PluginView.h:
12:44 Changeset [63630] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

Implement more NPRuntime related NPN_ functions
https://bugs.webkit.org/show_bug.cgi?id=42520

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/NPRuntimeUtilities.cpp: Added.
  • WebProcess/Plugins/NPRuntimeUtilities.h: Added.

Add new file with NPRuntime related utility functions.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_CreateObject):
(WebKit::NPN_RetainObject):
(WebKit::NPN_ReleaseObject):
Call the corresponding NPRuntimeUtilities functions.

11:57 Changeset [63629] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Begin work on NPRuntime support
https://bugs.webkit.org/show_bug.cgi?id=42519

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Handle NPNVWindowNPObject and NPNVPluginElementNPObject.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::windowScriptNPObject):
(WebKit::NetscapePlugin::pluginElementNPObject):
Call the plug-in controller.

  • WebProcess/Plugins/PluginController.h:

Add new windowScriptNPObject and pluginElementNPObject functions.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):
Add stubbed out functions.

10:45 Changeset [63628] by andersca@apple.com
  • 4 edits in trunk

Implement some NPRuntime related NPN_ functions
https://bugs.webkit.org/show_bug.cgi?id=42518

Reviewed by Dan Bernstein.

WebCore:

  • WebCore.exp.in:

Export IdentifierRep functions.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetStringIdentifier):
(WebKit::NPN_GetStringIdentifiers):
(WebKit::NPN_GetIntIdentifier):
(WebKit::NPN_IdentifierIsString):
(WebKit::NPN_UTF8FromIdentifier):
(WebKit::NPN_IntFromIdentifier):
(WebKit::NPN_CreateObject):

10:01 Changeset [63627] by andersca@apple.com
  • 10 edits in trunk

Add dumping of statusbar text to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=42516

Reviewed by Dan Bernstein.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:

Add setStatusbarText callback to WKBundlePageUIClient.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::setStatusbarText):
Call setStatusbarText.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setStatusbarText):
Call the bundle page UI client.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_setStatusbarText):
(WTR::InjectedBundlePage::setStatusbarText):
Dump the statusbar text.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::LayoutTestController):
Initialize m_dumpStatusCallbacks to false.

(WTR::dumpStatusCallbacksCallback):
Implement JSC callback.

(WTR::LayoutTestController::staticFunctions):
Add dumpStatusCallbacks.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(WTR::LayoutTestController::dumpStatusCallbacks):
(WTR::LayoutTestController::setDumpStatusCallbacks):
Add setter and getter for m_dumpStatusCallbacks.

09:32 Changeset [63626] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-07-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

[V8] Web Inspector: get actual breakpoint location from v8 and pass it
to ScripDebugServer.
https://bugs.webkit.org/show_bug.cgi?id=42452

  • src/js/DebuggerScript.js:
07:35 Changeset [63625] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium: fixed one more expectation to
reflect changes in r63616.

  • platform/chromium/test_expectations.txt:
06:49 Changeset [63624] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-07-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium: fixed test expectations (reflected changes
in r63616).

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.