Timeline


and

08/17/10:

20:53 Changeset [65586] by girish@forwardbias.in

Reviewed by Antonio Gomes.

[Qt] On Maemo5, there is no libgdk-x11-2.0.so symlink. Look for
libgdk-x11-2.0.so.0 instead on X11 and Maemo5.

https://bugs.webkit.org/show_bug.cgi?id=44043

  • plugins/qt/PluginViewQt.cpp:

(WebCore::getPluginDisplay):

20:08 Changeset [65585] by xan@webkit.org

2010-08-17 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix the builds when HAVE_GSETTINGS is defined.

  • webkit/webkitprivate.cpp: (isSchemaAvailable): (inspectorGSettings):
18:55 Changeset [65584] by commit-queue@webkit.org

2010-08-17 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Daniel Bates.

REGRESSION(53060): http/tests/security/xssAuditor/malformed-HTML.html timed out on Qt Linux Release Bot
https://bugs.webkit.org/show_bug.cgi?id=33460

Enable http/tests/security/xssAuditor/malformed-HTML.html
tested with qt-4.7 and qt-4.6.

  • platform/qt/Skipped:
18:38 Changeset [65583] by commit-queue@webkit.org

2010-08-17 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Ariya Hidayat.

Enable http/tests/security/cross-frame-access-name-getter.html

[Qt] http/tests/security/cross-frame-access-name-getter.html timed out
https://bugs.webkit.org/show_bug.cgi?id=38540

Test works with qt-4.7 and qt-4.6.

  • platform/qt/Skipped:
18:37 Changeset [65582] by victorw@chromium.org

2010-08-17 Victor Wang <victorw@chromium.org>

Unreviewed. Fixed chromium incremental test json upload.
Quote builder name and test results server in url.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
18:22 Changeset [65581] by laszlo.1.gombos@nokia.com

2010-08-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
https://bugs.webkit.org/show_bug.cgi?id=44124

Q_WS_S60 is not defined for Symbian4 devices as Q_WS_S60 used to guard
Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
Symbian dependencies.

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate):

2010-08-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
https://bugs.webkit.org/show_bug.cgi?id=44124

Q_WS_S60 is not defined for Symbian4 devices as Q_WS_S60 used to guard
Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
Symbian dependencies.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::open):
  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): (LauncherWindow::toggleFullScreenMode): (LauncherWindow::showFPS): (LauncherWindow::updateFPS):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI):
18:20 Changeset [65580] by ariya@webkit.org

[Qt] Remove unused ContextShadowParameter class in GraphicsContextQt
https://bugs.webkit.org/show_bug.cgi?id=44142

Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-17
Reviewed by Antonio Gomes.

The class is not needed anymore after r65425.
We know have dedicated ContextShadow in its own file.

  • platform/graphics/qt/GraphicsContextQt.cpp:
18:01 Changeset [65579] by darin@apple.com

Add NetworkingContext to avoid layer violations
https://bugs.webkit.org/show_bug.cgi?id=42292

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2010-08-17
Reviewed by Darin Adler.

Preparation: Just add the files to the build system.

.:

  • GNUmakefile.am: Added new files.

WebCore:

  • GNUmakefile.am: Added new files.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • loader/FrameNetworkingContext.h: Added.
  • platform/network/NetworkingContext.h: Added.

Placeholders with tentative code that might be changed when landing
the rest of it.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Added new files.

WebKit/chromium:

  • WebKit.gyp: Added new files.
  • src/FrameNetworkingContextImpl.h: Added.

Placeholder with tentative code that might be changed when landing
the rest of it.

WebKit/gtk:

  • WebCoreSupport/FrameNetworkingContextGtk.h: Added.

Placeholder with tentative code that might be changed when landing
the rest of it.

WebKit/mac:

  • WebCoreSupport/WebFrameNetworkingContext.h: Added.

Placeholder with tentative code that might be changed when landing
the rest of it.

  • WebCoreSupport/WebFrameNetworkingContext.mm: Added.

Empty placeholder for now.

WebKit/qt:

  • WebCoreSupport/FrameNetworkingContextQt.cpp: Added.

Empty placeholder for now.

  • WebCoreSupport/FrameNetworkingContextQt.h: Added.

Placeholder with tentative code that might be changed when landing
the rest of it.

WebKit/win:

  • WebCoreSupport/WebFrameNetworkingContext.cpp: Added.

Empty placeholder for now.

  • WebCoreSupport/WebFrameNetworkingContext.h: Added.

Placeholder with tentative code that might be changed when landing
the rest of it.

  • WebKit.vcproj/WebKit.vcproj: Added new files.

WebKit2:

  • WebKit2.xcodeproj/project.pbxproj: Added new files.
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h: Added.

Placeholder with tentative code that might be changed when landing
the rest of it.

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: Added.

Empty placeholder for now.

17:59 Changeset [65578] by dpranke@chromium.org

2010-08-17 Dirk Pranke <dpranke@chromium.org>

Reviewed by David Levin.

new-run-webkit-tests: remove --show-sources option

--show-sources is pretty much obsolete with --trace everything, so
I'm removing it.

Also rename a couple of methods in the TestTextDiff class to make their
intended visibility (private) more obvious.

https://bugs.webkit.org/show_bug.cgi?id=44143

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
17:55 Changeset [65577] by dpranke@chromium.org

2010-08-17 Dirk Pranke <dpranke@chromium.org>

Reviewed by David Levin.

remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)

This code bit-rotted at some point more than a year ago, and nobody seems
to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
should support instead, making this flag unnecessary anyway.

https://bugs.webkit.org/show_bug.cgi?id=44141

  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
17:41 Changeset [65576] by bdakin@apple.com

Adding a MathML Demo and screenshot.

Rubber-stamped by Adele.

  • blog-files/riemann-screenshot.png: Added.
  • demos/mathml: Added.
  • demos/mathml/MathMLDemo.xhtml: Added.
16:57 Changeset [65575] by commit-queue@webkit.org

2010-08-17 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

transitions/change-values-during-transition.html fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=28461

Make test less flaky during high CPU usage by changing the expectation
from a hardcoded value to an interpolated one based on when the timeout
actually fires. Made the test much more reliable when running with
--iterations=100 while maxing out the CPU on my machine with a
background process.

  • transitions/change-values-during-transition.html:
16:56 Changeset [65574] by victorw@chromium.org

2010-08-17 Victor Wang <victorw@chromium.org>

Reviewed by Ojan Vafai.

Update json results generator to have incremental json including
results for tests that pass in current run but failed before.

https://bugs.webkit.org/show_bug.cgi?id=44119

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16:40 Changeset [65573] by commit-queue@webkit.org

2010-08-17 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

Back button after Google search result click broken
https://bugs.webkit.org/show_bug.cgi?id=44086

Added a reduced test case of Google search result click behavior,
renamed gesture-before-onload-target.html to redirect-target.html
since it's useful for this test too.

  • fast/history/gesture-before-onload-form-submit-expected.txt:
  • fast/history/gesture-before-onload-form-submit.html:
  • fast/history/gesture-before-onload-location-href-expected.txt:
  • fast/history/gesture-before-onload-location-href.html:
  • fast/history/redirect-via-iframe-expected.txt: Added.
  • fast/history/redirect-via-iframe.html: Added.
  • fast/history/resources/iframe-redirect.html: Added.
  • fast/history/resources/redirect-target.html: Renamed from LayoutTests/fast/history/resources/gesture-before-onload-target.html.

2010-08-17 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

Back button after Google search result click broken
https://bugs.webkit.org/show_bug.cgi?id=44086

Test: fast/history/redirect-via-iframe.html

isLoadingInAPISense doesn't quite map to onload (it also returns true
if frames are loading, even after the parent frame has fired its onload
handler). Instead, add a flag for the onload event being fired, and
use that.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::handledOnloadEvents): (WebCore::DocumentLoader::wasOnloadHandled):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::handledOnloadEvents):
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::mustLockBackForwardList):
16:11 Changeset [65572] by dpranke@chromium.org

2010-08-17 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

fix test-webkitpy, add easy way to find a checkout root

test-webkitpy currently doesn't work right if run from someplace other
than the checkout root, and it spews a bunch of debug logging because
the deduplicate_tests tests contaminates the test environment.

This patch cleans up the deduplicate_tests unit tests, and creates
two new methods in scm.py: find_checkout_root() and default_scm(),
both of which use a single algorithm for guessing what checkout root
to use if you aren't explicitly told one from a path.

https://bugs.webkit.org/show_bug.cgi?id=44001

  • Scripts/deduplicate-tests:
  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/main.py:
16:05 Changeset [65571] by barraclough@apple.com

Bug 44099 - REGRESSION(r65468): Crashes in StringImpl::find

Reviewed by Sam Weinig.

Bug 44080 introuduced a couple of cases in which array bounds could be overrun.
One of these was fixed in r65493, this patch fixes the other and address the
concerns voiced in comment #6 by restructuring the loops to remove the code
dupliction without introducing an additional if check.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):
(WTF::StringImpl::reverseFind):
(WTF::StringImpl::reverseFindIgnoringCase):

16:05 Changeset [65570] by steveblock@google.com

2010-08-17 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Geolocation clearWatch() needs to protect against invalid IDs
https://bugs.webkit.org/show_bug.cgi?id=44096

  • fast/dom/Geolocation/clear-watch-invalid-id-crash-expected.txt: Added.
  • fast/dom/Geolocation/clear-watch-invalid-id-crash.html: Added.
  • fast/dom/Geolocation/script-tests/clear-watch-invalid-id-crash.js: Added.
  • fast/dom/Geolocation/script-tests/notimer-after-unload.js: (document.body.onload):

2010-08-17 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Geolocation clearWatch() needs to protect against invalid IDs
https://bugs.webkit.org/show_bug.cgi?id=44096

If the ID passed to clearWatch() is invalid, we early-out.

Test: fast/dom/Geolocation/clear-watch-invalid-id-crash.html

  • page/Geolocation.cpp: (WebCore::Geolocation::Watchers::set): (WebCore::Geolocation::Watchers::remove): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::clearWatch):
16:00 Changeset [65569] by senorblanco@chromium.org

2010-08-17 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

Allow non-Skia ports to compile with ENABLE(ACCELERATED_2D_CANVAS).
https://bugs.webkit.org/show_bug.cgi?id=44130

No tests; if it compiles, it's good.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Fix a warning (treated as error).
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setGraphicsContext3D): (WebCore::GraphicsContext::syncSoftwareCanvas):
  • platform/graphics/GraphicsContext.h: Make setGraphicsContext3D() and syncSoftwareCanvas() stubbed out, but still present in non-Skia ports. This allows Chrome Mac to compile with ENABLE(ACCELERATED_2D_CANVAS) (although it isn't hooked up yet, it should at least compile).
15:53 Changeset [65568] by crogers@google.com

V8-specific fixes for JavaScriptAudioNode

15:46 Changeset [65567] by victorw@chromium.org

2010-08-17 Victor Wang <victorw@chromium.org>

Reviewed by Ojan Vafai.

Add support to the test results server for downloading json that
contains test list only.

This is for json results generator to generate incremental json
results so that it includes results not only for tests failed in
current run, but also tests failed before.

Also set the results type to "N" (no data) instead of "P" (pass)
if test results cannot be found in incremental json file.

https://bugs.webkit.org/show_bug.cgi?id=44117

  • TestResultServer/handlers/testfilehandler.py:
  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
15:44 Changeset [65566] by beidson@apple.com

WebCore: Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
<rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131

Reviewed by Sam Weinig.

No new tests. (Especially since DRT doesn't spin inner run loops at all, it would be a significant
effort to give it the ability to perform the back/forward navigation in the background to reproduce
this bug)

Manual tests in place of layout tests:

  • manual-tests/back-forward-during-alert-1.html: Added.
  • manual-tests/back-forward-during-alert-2.html: Added.
  • page/Page.cpp:

(WebCore::Page::goToItem):

WebKit: Remove developmentRegion from the project file as it shouldn't have been checked in.

Reviewed by Sam Weinig.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac: Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
<rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(-[WebView canGoBack]): Return false if loads are deferred.
(-[WebView canGoForward]): Ditto.

WebKit/win: Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
<rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131

Reviewed by Sam Weinig.

  • WebView.cpp:

(WebView::canGoBack): Return false if loads are deferred.
(WebView::canGoForward): Ditto.

15:36 Changeset [65565] by joepeck@webkit.org

2010-08-17 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: Add XMLHttpRequest Logging Tests
https://bugs.webkit.org/show_bug.cgi?id=44092

  • http/tests/inspector/console-xhr-logging-expected.txt: Added.
  • http/tests/inspector/console-xhr-logging.html: Added.
  • http/tests/inspector/resources/xhr-exists.html: Added.
15:33 Changeset [65564] by ojan@chromium.org

2010-08-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

selectionStart clobbered if textarea isn't focused
https://bugs.webkit.org/show_bug.cgi?id=43814

  • fast/forms/text-control-select-blurred-expected.txt: Added.
  • fast/forms/text-control-select-blurred.html: Added.

2010-08-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

selectionStart clobbered if textarea isn't focused
https://bugs.webkit.org/show_bug.cgi?id=43814

If a text control is blurred, setting selectionStart/end should use
the cached selection value, which is currently stored on the form
control element.

Test: fast/forms/text-control-select-blurred.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setSelectionStart): (WebCore::RenderTextControl::setSelectionEnd):
15:29 Changeset [65563] by dimich@chromium.org

MessagePort.close() crashes if the owning context was destroyed.
https://bugs.webkit.org/show_bug.cgi?id=43140

Reviewed by David Levin.

WebCore:

Test: fast/events/message-port-context-destroyed.html

  • dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::start):
(WebCore::MessagePort::close):
(WebCore::MessagePort::contextDestroyed):
Use isEntangled() method to gate various operations on MessagePort. This method also takes into account m_closed bit.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::closeMessagePorts):

  • dom/ScriptExecutionContext.h:

Add closeMessagePorts() method that closes message ports at the same moments when other ActiveDOMObjects are stopped.

LayoutTests:

  • fast/events/message-port-context-destroyed-expected.txt: Added.
  • fast/events/message-port-context-destroyed.html: Added.
15:22 Changeset [65562] by hclam@chromium.org

Unreviewed. Build fix.

Submitted for Victoria Kirst <vrk@google.com>.

Rebaseline straggler Mac UI video regressions.
Fixing test expectations to match output from r65215 bug fix.

https://bugs.webkit.org/show_bug.cgi?id=44134

  • platform/chromium-mac/fast/layers/video-layer-expected.checksum:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.checksum:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium/test_expectations.txt:
15:13 Changeset [65561] by johnnyg@google.com

2010-08-17 John Gregg <johnnyg@google.com>

Unreviewed, test expectations.

Skip the filltable-*.html tests on mac and windows. They have no expectations, so expecting
them to FAIL is insufficient to make the bots happy.

  • platform/chromium/test_expectations.txt:
15:10 Changeset [65560] by aroben@apple.com

Use the right path style

  • Scripts/old-run-webkit-tests:
15:08 Changeset [65559] by aroben@apple.com

Fix typo

  • Scripts/old-run-webkit-tests:
15:03 Changeset [65558] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebKit/WebKit

15:02 Changeset [65557] by aroben@apple.com

Don't hang when running run-webkit-tests as a non-Administrator on Vista/7

  • Scripts/old-run-webkit-tests:

(setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
post-mortem debugger, rather than using NTSD itself. The latter waits
for user input when it fails to set the registry values; the former
does not.

14:56 Changeset [65556] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebKit remaining files

14:55 Changeset [65555] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebKit directories 3

14:52 Changeset [65554] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebKit directories 2

14:51 Changeset [65553] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebKit directories 1

14:47 Changeset [65552] by crogers@google.com

merge trunk 61708:65443 into audio branch: JavaScriptGlue

14:46 Changeset [65551] by crogers@google.com

merge trunk 61708:65443 into audio branch: JavaScriptCore

14:41 Changeset [65550] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebCore remaining files

14:39 Changeset [65549] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebCore directories 7

14:37 Changeset [65548] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebCore directories 6

14:36 Changeset [65547] by vestbo@webkit.org

[Qt] Skip media/video-poster-delayed.html

Reviewed by NOBODY.

The QtMultimedia backend has issues with video size hints, skip the test
until this is sorted out.

  • platform/qt/Skipped:
14:35 Changeset [65546] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebCore directories 5

14:32 Changeset [65545] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebCore directories 4

14:30 Changeset [65544] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebCore directories 3

14:27 Changeset [65543] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebCore directories 2

14:26 QtWebKitTriageRoster edited by laszlo.1.gombos@nokia.com
(diff)
14:25 Changeset [65542] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebCore directories 1

14:24 Changeset [65541] by crogers@google.com

merge trunk 61708:65443 into audio branch: WebCore/audio

13:58 Changeset [65540] by aroben@apple.com

Instruct developers to (optionally) install Debugging Tools for Windows

These tools are used by some of our scripts, so are useful for
developers to have installed.

Fixes <http://webkit.org/b/44128> webkit.org building instructions
should recommend installing Debugging Tools for Windows

Reviewed by Sam Weinig.

  • building/tools.html:
13:57 Changeset [65539] by jamesr@google.com

2010-08-17 Fady Samuel <fsamuel@chromium.org>

Reviewed by David Hyatt.

Updated table cell hit testing and painting to use binary search instead of linear scan.

Improved Table Hit Testing and Painting Performance
https://bugs.webkit.org/show_bug.cgi?id=43933

Tests: fast/table/simple_paint.html

tables/hittesting/filltable-emptycells.html
tables/hittesting/filltable-levels.html
tables/hittesting/filltable-outline.html
tables/hittesting/filltable-rtl.html
tables/hittesting/filltable-stress.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintObject): Dirty rect determined using binary search. (WebCore::RenderTableSection::nodeAtPoint): Cell hit determined using binary search

2010-08-17 Fady Samuel <fsamuel@chromium.org>

Reviewed by David Hyatt.

Updated table cell hit testing and painting to use binary search instead of a linear scan.

Layout tests check that hit testing of empty cells, overlapping cells,
cells with outlines, right-to-left tables, and large
tables all work as expected.

Improved Table Hit Testing and Painting Performance
https://bugs.webkit.org/show_bug.cgi?id=43933

  • fast/table/simple_paint.html: Added.
  • platform/chromium-linux/fast/table/simple_paint-expected.checksum: Added.
  • platform/chromium-linux/fast/table/simple_paint-expected.png: Added.
  • platform/chromium-linux/fast/table/simple_paint-expected.txt: Added.
  • platform/chromium-linux/tables/hittesting/filltable-emptycells-expected.txt: Added.
  • platform/chromium-linux/tables/hittesting/filltable-levels-expected.txt: Added.
  • platform/chromium-linux/tables/hittesting/filltable-outline-expected.txt: Added.
  • platform/chromium-linux/tables/hittesting/filltable-rtl-expected.txt: Added.
  • platform/chromium-linux/tables/hittesting/filltable-stress-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/tables/hittesting/filltable-emptycells-expected.txt: Added.
  • platform/gtk/tables/hittesting/filltable-levels-expected.txt: Added.
  • platform/gtk/tables/hittesting/filltable-outline-expected.txt: Added.
  • platform/gtk/tables/hittesting/filltable-rtl-expected.txt: Added.
  • platform/gtk/tables/hittesting/filltable-stress-expected.txt: Added.
  • tables/hittesting/filltable-emptycells.html: Added.
  • tables/hittesting/filltable-levels.html: Added.
  • tables/hittesting/filltable-outline.html: Added.
  • tables/hittesting/filltable-rtl.html: Added.
  • tables/hittesting/filltable-stress.html: Added.
13:49 Changeset [65538] by inferno@chromium.org

2010-08-17 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Only destroy empty anonymous block when it is columns or column span block
in RenderBlock::removeChild.
https://bugs.webkit.org/show_bug.cgi?id=44035

Test: fast/block/basic/empty-anonymous-block-remove-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):

2010-08-17 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that removing an empty anonymous block does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=44035

  • fast/block/basic/empty-anonymous-block-remove-crash-expected.txt: Added.
  • fast/block/basic/empty-anonymous-block-remove-crash.html: Added.
13:45 Changeset [65537] by aroben@apple.com

Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to save crash logs on Windows

The crash logs are saved to /tmp/layout-test-results and have names
like CrashLog_02bc_2010-08-17_14-36-20-108.txt.

Unfortunately, crashes in the WebKit2 web process are recorded as
time-outs by run-webkit-tests. Fixing this is covered by
<http://webkit.org/b/44121>.

Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
DumpRenderTree should save a stack trace and/or dump file when it
crashes

Reviewed by Sam Weinig.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(exceptionFilter):
(main):

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::exceptionFilter):
(WTR::TestController::platformInitialize):
These changes set up an exception filter that prints #CRASHED to
stderr, then lets the exception propagate normally. This allows
run-webkit-tests to detect when we've crashed even when a post-mortem
debugger attaches to the process.

  • Scripts/old-run-webkit-tests:

(top level): Declared some variables used by the crash-log-saving
code.
(openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
that the post-mortem debugger has access to it.
(toCygwinPath): Added. This is the opposite of toWindowsPath.
(readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
stderr, consider it a crash.
(setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
debugger, then sets ntsd as the post-mortem debugger. ntsd is
configured to save a crash log and then quit automatically.
(END): Added. Restores the previous post-mortem debugger when the
script exits.

13:17 Changeset [65536] by commit-queue@webkit.org

2010-08-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65516.
http://trac.webkit.org/changeset/65516
https://bugs.webkit.org/show_bug.cgi?id=44126

broke chromium unit tests on mac and linux (Requested by
johnny_g on #webkit).

  • WebKit.gyp:
  • src/WebFrameImpl.cpp: (WebKit::frameContentAsPlainText):
  • tests/RunAllTests.cpp: (main):
  • tests/WebFrameTest.cpp: Removed.
13:14 Changeset [65535] by johnnyg@google.com

2010-08-17 John Gregg <johnnyg@google.com>

Unreviewed, test expectation.

Excluding the new geolocation multiple-requests layout tests from chromium.
See https://bugs.webkit.org/show_bug.cgi?id=44118

  • platform/chromium/test_expectations.txt:
13:07 Changeset [65534] by darin@chromium.org

2010-08-17 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

[Chromium] REGRESSION: Incorrect repaint on scrolling with position:fixed elements
https://bugs.webkit.org/show_bug.cgi?id=42949

This is a partial revert of http://trac.webkit.org/changeset/63907

  • page/FrameView.cpp: (WebCore::FrameView::scrollPositionChangedViaPlatformWidget): (WebCore::FrameView::scrollPositionChanged):
  • platform/ScrollView.cpp: (WebCore::ScrollView::valueChanged):
13:06 Changeset [65533] by vestbo@webkit.org

Add testcase for r65514

Reviewed by Eric Carlson.

  • media/video-poster-delayed-expected.txt: Added.
  • media/video-poster-delayed.html: Added.
13:00 Changeset [65532] by kov@webkit.org

2010-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.couk>

Reviewed by Martin Robinson.

WebBackForwardList.get_{back|forward}_list_with_limit not introspectable
https://bugs.webkit.org/show_bug.cgi?id=43054

  • GNUmakefile.am: Give also API implementation files to the GIR scanner.

WebKit/gtk

2010-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

WebBackForwardList.get_{back|forward}_list_with_limit not introspectable
https://bugs.webkit.org/show_bug.cgi?id=43054

Annotate WebKitWebBackForwardList and the function that is used to fetch it from
the WebKitWebView. More will follow.

  • webkit/webkitwebbackforwardlist.cpp: Annotations, and small improvements to the docs.
  • webkit/webkitwebbackforwardlist.h: Couple empty lines missing.
  • webkit/webkitwebview.cpp:
12:51 Changeset [65531] by senorblanco@chromium.org

2010-08-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65528.
http://trac.webkit.org/changeset/65528
https://bugs.webkit.org/show_bug.cgi?id=44123

"Broke a bunch of canvas tests on Chrome win/linux."
(Requested by senorblanco on #webkit).

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h: (WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::drawsUsingCopy): (WebCore::ImageBuffer::copyImage): (WebCore::ImageBuffer::draw): (WebCore::ImageBuffer::drawPattern):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::create):
  • platform/graphics/skia/NativeImageSkia.cpp:
  • platform/graphics/skia/NativeImageSkia.h:
12:05 Changeset [65530] by mrobinson@webkit.org

2010-08-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by David Hyatt.

[Cairo] Remove unnecessary full-surface copies from ImageCairo and GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=44076

No new tests as functionality has not changed.

  • GNUmakefile.am: Added GRefPtrCairo to the sources list.
  • platform/graphics/cairo/GRefPtrCairo.cpp: Added. (WTF::refGPtr): Added specializations for cairo_t and cairo_surface_t. (WTF::derefGPtr):
  • platform/graphics/cairo/GRefPtrCairo.h: Added.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::createPlatformShadow): Access the image surface directly from the ImageBuffer instead of wrapping it in an Image.
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern): Create the temporary surface using cairo primitives instead of through the platform-independent WebCore code.
12:04 BuildingOnWindows edited by aroben@apple.com
Added instructions for getting crash logs from regression tests (diff)
12:00 Changeset [65529] by mrobinson@webkit.org

2010-08-17 Martin Robinson <mrobinson@igalia.com>

[GTK] Clean up WebCore/platform/graphics/gtk/ImageGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=44069

No new tests as functionality has not changed.

  • GNUmakefile.am: Add WEBKITGTK_API_VERSION_STRING definition, which allows WebCore to use this as well.
  • platform/graphics/gtk/ImageGtk.cpp: (getWebKitDataDirectory): Added this helper. (WebCore::Image::loadPlatformResource): Use GOwnPtr for gchar pointers and use the new getWebKitDataDirectory helper.
  • platform/gtk/GOwnPtrGtk.cpp: Move the GtkIconInfo template specialization to this file. (WTF::GtkIconInfo): Added this forward declaration.
  • platform/gtk/GOwnPtrGtk.h: Declaration for new template specialization.

2010-08-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Clean up WebCore/platform/graphics/gtk/ImageGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=44069

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend): Switched to using the new WEBKITGTK_API_VERSION_STRING define.
  • webkit/webkitprivate.cpp: (inspectorGSettings): Ditto.
11:55 Changeset [65528] by senorblanco@chromium.org

2010-08-17 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Fisher.

[CHROMIUM] Eliminate a memcpy() from the canvas.drawImage(canvas, ...) path.
This is the Skia followup to Dave Hyatt's patch in r65449.
https://bugs.webkit.org/show_bug.cgi?id=44115

Covered by canvas layout tests.

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h: Add a "copyPixels" argument to the create() static to indicate if the caller wants the pixels to be copied or ref'ed.
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::drawsUsingCopy): We don't use the always-copy path anymore, so return false. (WebCore::ImageBuffer::copyImage): Shouldn't get here anymore, so ASSERT_NOT_REACHED. (WebCore::ImageBuffer::draw): (WebCore::ImageBuffer::drawPattern): Create a temporary BitampImageSingleFrameSkia wrapped around the canvas's bitmap, and draw with it immediately. If drawing to our own canvas, copy the pixels, otherwise just shallow copy.
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia): Make the constructor take an SkBitmap to be wrapped. (WebCore::BitmapImageSingleFrameSkia::create): Implement the "copyPixels" flag: if true, do a deep copy, otherwise do a shallow copy.
  • platform/graphics/skia/NativeImageSkia.cpp: (WebCore::NativeImageSkia::NativeImageSkia):
  • platform/graphics/skia/NativeImageSkia.h: Implement a new constructor that shallow-copies the given SkBitmap.
11:47 Changeset [65527] by victorw@chromium.org

2010-08-17 Victor Wang <victorw@chromium.org>

Reviewed by ojan@chromium.org.

Update test results server:

  1. Normalize test results and times after merging (prune tests where all runs pass or do not have data, truncate all test items to max number of builds)
  2. times should be int not string.
  3. when inserting a new test item, should keep old data regardless whether or not they have same item type with new one.

https://bugs.webkit.org/show_bug.cgi?id=43861

  • TestResultServer/model/jsonresults.py:
  • TestResultServer/model/jsonresults_unittest.py:
11:45 Changeset [65526] by jianli@chromium.org

Move BlobRegistry interface and implementation to platform/network
https://bugs.webkit.org/show_bug.cgi?id=44116

Reviewed by Darin Fisher.

Also move BlobData and BlobStorageData since they're part of BlobRegistry
implementation.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/BlobData.cpp: Renamed from WebCore/platform/BlobData.cpp.
  • platform/network/BlobData.h: Renamed from WebCore/platform/BlobData.h.
  • platform/network/BlobRegistry.h: Renamed from WebCore/platform/BlobRegistry.h.
  • platform/network/BlobRegistryImpl.cpp: Renamed from WebCore/html/BlobRegistryImpl.cpp.
  • platform/network/BlobRegistryImpl.h: Renamed from WebCore/html/BlobRegistryImpl.h.
  • platform/network/BlobStorageData.h: Renamed from WebCore/html/BlobStorageData.h.
11:43 Changeset [65525] by andreas.kling@nokia.com

2010-08-17 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Path: Fast approximation of stroke bounding rects
https://bugs.webkit.org/show_bug.cgi?id=44014

In canvas's stroke(), use QPainterPath::controlPointRect() to calculate
a slightly larger bounding rect in a fraction of the time.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::stroke):
11:39 Changeset [65524] by girish@forwardbias.in

Set PluginQuirkRequiresDefaultScreenDepth for all Flash versions and not
just Flash 10.

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=44043

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks):

11:31 Changeset [65523] by jianli@chromium.org

Change FileStream implementation to prepare for blob resource handling.
https://bugs.webkit.org/show_bug.cgi?id=43985

Reviewed by David Levin.

Change FileStream to support synchronous usage only. All the asychronous
logics are moved to FileStreamProxy. Update the existing FileReader code
to adapt to this change.

  • html/FileReader.cpp: Account for FileStreamProxy changes.

(WebCore::FileReader::didStart):
(WebCore::FileReader::didGetSize):
(WebCore::FileReader::didOpen):
(WebCore::FileReader::didRead):

  • html/FileReader.h:
  • html/FileStream.cpp: Remove m_client and make all calls synchronous only.

(WebCore::FileStream::FileStream):
(WebCore::FileStream::start):
(WebCore::FileStream::stop):
(WebCore::FileStream::getSize):
(WebCore::FileStream::openForRead):
(WebCore::FileStream::openForWrite):
(WebCore::FileStream::close):
(WebCore::FileStream::read):
(WebCore::FileStream::write):
(WebCore::FileStream::truncate):

  • html/FileStream.h: Add getSize() and make all calls synchronous by adding return values.

(WebCore::FileStream::create):

  • html/FileStreamClient.h: Account for FileStreamProxy changes.

(WebCore::FileStreamClient::didRead):
(WebCore::FileStreamClient::didTruncate):
(WebCore::FileStreamClient::didOpen):

  • html/FileStreamProxy.cpp: All the logics to handle asynchronous calls are wrapped here.

(WebCore::FileStreamProxy::FileStreamProxy):
(WebCore::FileStreamProxy::create):
(WebCore::FileStreamProxy::fileThread):
(WebCore::didStart):
(WebCore::FileStreamProxy::startOnFileThread):
(WebCore::FileStreamProxy::stop):
(WebCore::derefProxyOnContext):
(WebCore::FileStreamProxy::stopOnFileThread):
(WebCore::didGetSize):
(WebCore::FileStreamProxy::getSize):
(WebCore::FileStreamProxy::getSizeOnFileThread):
(WebCore::didOpen):
(WebCore::FileStreamProxy::openForRead):
(WebCore::FileStreamProxy::openForReadOnFileThread):
(WebCore::FileStreamProxy::openForWrite):
(WebCore::FileStreamProxy::openForWriteOnFileThread):
(WebCore::FileStreamProxy::close):
(WebCore::FileStreamProxy::closeOnFileThread):
(WebCore::didRead):
(WebCore::FileStreamProxy::read):
(WebCore::FileStreamProxy::readOnFileThread):
(WebCore::didWrite):
(WebCore::FileStreamProxy::write):
(WebCore::FileStreamProxy::writeOnFileThread):
(WebCore::didTruncate):
(WebCore::FileStreamProxy::truncate):
(WebCore::FileStreamProxy::truncateOnFileThread):

  • html/FileStreamProxy.h:
  • html/FileThreadTask.h: Change all methods to return void since return value is not needed now.
11:28 Changeset [65522] by weinig@apple.com

Add a few items in the WebKitTestRunner Skipped list.

Rubber-stamped by Anders Carlsson.

  • platform/mac-wk2/Skipped:
11:22 Changeset [65521] by laszlo.1.gombos@nokia.com

2010-08-17 Hui Huang <hui.2.huang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix ARM5 compiling error in FrameLoaderClientQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=43927

In the Symbian build chain QT_USE_FAST_OPERATOR_PLUS is defined,
which means that the '+' will automatically be performed as the
QStringBuilder '%'. Create a QString explicitly to make sure that
toLocal8bit() member is available that the qPrintable Macro uses.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
11:06 Changeset [65520] by dglazkov@chromium.org

2010-08-17 Dimitri Glazkov <dglazkov@chromium.org>

Returned WebCore.xcodeproj to default settings after http://trac.webkit.org/changeset/65468/trunk/WebCore/WebCore.xcodeproj/project.pbxproj.

  • WebCore.xcodeproj/project.pbxproj: Removed developmentRegion = English line.
11:06 Changeset [65519] by eric@webkit.org

2010-08-17 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

sputnik S15.9.3.1_A5_T1~T6 fail when run in timezone other than Pacific Time
https://bugs.webkit.org/show_bug.cgi?id=42625

  • fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T1.html-disabled: Renamed from LayoutTests/fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T1.html.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T2.html-disabled: Renamed from LayoutTests/fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T2.html.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T3.html-disabled: Renamed from LayoutTests/fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T3.html.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T4.html-disabled: Renamed from LayoutTests/fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T4.html.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T5.html-disabled: Renamed from LayoutTests/fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T5.html.
  • fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T6.html-disabled: Renamed from LayoutTests/fast/js/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T6.html.
11:04 Changeset [65518] by mrobinson@webkit.org

2010-08-17 Martin Robinson <mrobinson@igalia.com>

GTK+ Build fix for those having stable versions of GLib.

  • configure.ac: Only invoke GLIB_GSETTINGS if we have the necessary gio version.
10:55 Changeset [65517] by dglazkov@chromium.org

Eliminate extra traversal of the tree when determining ability to lazy-attach a Node.
https://bugs.webkit.org/show_bug.cgi?id=43749

Reviewed by Eric Seidel.

Land the actual change that I intended to land in http://trac.webkit.org/changeset/65508.

Neither SVG nor inputs/counters shadow DOM are traveling down this path (they home-bake their attachment),
so the check for shadow tree existence isn't needed.
Gives a small, but consistent win in Dromaeo's DOM Modification test.

  • dom/Node.h:

(WebCore::Node::canLazyAttach): Changed to always return true.

10:45 Changeset [65516] by jcivelli@chromium.org

2010-08-17 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Made WebFrame not report the text from hidden frames.
(some pages contain hidden frames with garbage text that
should not be indexed or used to detect the page's language).
https://bugs.webkit.org/show_bug.cgi?id=39456

  • WebKit.gyp:
  • public/WebCString.h: (WebKit::operator<):
  • public/WebURL.h: (WebKit::operator<):
  • src/WebCString.cpp: (WebKit::WebCString::compare):
  • src/WebFrameImpl.cpp: (WebKit::frameContentAsPlainText):
  • tests/RunAllTests.cpp: (main):
  • tests/WebFrameTest.cpp: Added.
10:24 Changeset [65515] by cmarrin@apple.com

Moved previous link error fix to Base.xcconfig

10:18 Changeset [65514] by vestbo@webkit.org

Restore intrinsic size of video elements after loading poster

Reviewed by Eric Carlson.

The element might already have the instrinsic size of the video, in
which case we don't want to override it witht that of the image.

  • rendering/RenderVideo.cpp: call updateIntrinsicSize() to restore size
10:13 Changeset [65513] by steveblock@google.com

2010-08-17 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

[Qt] fast/dom/Geolocation/disconnected-frame-permission-denied.html fails
https://bugs.webkit.org/show_bug.cgi?id=44059

  • fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt:
  • fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js: (onIframeLoaded): ():
  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
10:05 Changeset [65512] by cmarrin@apple.com

Fixed link errors in WebCore build on Mac

09:54 Changeset [65511] by commit-queue@webkit.org

2010-08-17 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Steve Block.

Geolocation preemptive permissions policy is buggy
https://bugs.webkit.org/show_bug.cgi?id=42811

Adds cases where permission is niether denied or granted immediately and multiple
requests are waiting.

  • fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests-expected.txt: Added.
  • fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests.html: Added.
  • fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests-expected.txt: Added.
  • fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests.html: Added.
  • fast/dom/Geolocation/script-tests/delayed-permission-allowed-for-multiple-requests.js: Added. (allowPermission): (): (maybeFinishTest):
  • fast/dom/Geolocation/script-tests/delayed-permission-denied-for-multiple-requests.js: Added. (denyPermission): (maybeFinishTest):
  • platform/gtk/Skipped:
  • platform/qt/Skipped:

2010-08-17 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Steve Block.

Geolocation preemptive permissions policy is buggy
https://bugs.webkit.org/show_bug.cgi?id=42811

While waiting for permission, m_startRequestPermissionNotifier was
used to consider only one pending request. This patch implements a set
m_pendingForPermissionNotifiers to maintain set of pending requests.
When user grants/denies permission all listeners will be notified.
Also fixed issue with hasZeroTimeout() where startTimerIfNeeded() has
to start irrespective of permission state

Tests: fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests.html

fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests.html

  • WebCore.pro:
  • page/Geolocation.cpp: (WebCore::Geolocation::startRequest): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::startUpdating): (WebCore::Geolocation::handlePendingPermissionNotifiers):
  • page/Geolocation.h:
09:27 Changeset [65510] by knorton@google.com

2010-08-17 Kelly Norton <knorton@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Fixes a crash in addTimelineRecord when InspectorTimelineAgent
is enabled through WebDevToolsAgentImpl::setApuEnabled.
https://bugs.webkit.org/show_bug.cgi?id=44105

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
09:18 Changeset [65509] by jorlow@chromium.org

2010-08-09 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Beginnings of IndexedDB persistance + IDBDatabase.description fleshed out
https://bugs.webkit.org/show_bug.cgi?id=43744

Add a layout test for IDBDatabase.description.

  • storage/indexeddb/database-description-expected.txt: Added.
  • storage/indexeddb/database-description.html: Added.
  • storage/indexeddb/script-tests/database-description.js: Added. (test): (firstSuccess): (secondSuccess): (thirdSuccess):

2010-08-11 Jeremy Orlow <jorlow@chromium.org>

Beginnings of IndexedDB persistance + IDBDatabase.description fleshed out
https://bugs.webkit.org/show_bug.cgi?id=43744

The beginnings of a SQLite backend for IndexedDB. Right now, only persists
meta-data for the database. The rest is coming in future patches. Adds
a manual test to verify persistance.

Test: storage/indexeddb/database-description.html

+ a manual test

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • manual-tests/indexed-database.html: Added.
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::databaseIdentifier):
  • platform/FileSystem.cpp: Added. (WebCore::): (WebCore::shouldEscapeUChar): (WebCore::encodeForFileName):
  • platform/FileSystem.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::description):
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::extractMetaData): (WebCore::setMetaData): (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::setDescription):
  • storage/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::create):
  • storage/IDBFactory.h:
  • storage/IDBFactory.idl:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl): (WebCore::IDBFactoryBackendImpl::~IDBFactoryBackendImpl): (WebCore::openSQLiteDatabase): (WebCore::createTables): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h: (WebCore::IDBFactoryBackendImpl::create):
09:15 Changeset [65508] by dglazkov@chromium.org

2010-08-17 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

Eliminate extra traversal of the tree when determining ability to lazy-attach a Node.
https://bugs.webkit.org/show_bug.cgi?id=43749

Neither SVG nor inputs/counters shadow DOM are traveling down this path (they home-bake their attachment),
so the check for shadow tree existence isn't needed.

Gives a small, but consisten win in Dromaeo's DOM Modification test.

  • dom/Node.cpp: Removed canLazyAttach declaration.
  • dom/Node.h: (WebCore::Node::canLazyAttach): Changed to always return true.
08:59 Changeset [65507] by yurys@chromium.org

2010-08-17 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert r41142. Unskipped tests are still failing.

  • platform/qt/Skipped:
08:55 Changeset [65506] by pfeldman@chromium.org

2010-08-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [CRASH] Console formatting crashes after cross-domain navigation.
https://bugs.webkit.org/show_bug.cgi?id=44103

  • http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html:

2010-08-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [CRASH] Console formatting crashes after cross-domain navigation.
https://bugs.webkit.org/show_bug.cgi?id=44103

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::injectedScriptFor):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
08:41 Changeset [65505] by yurys@chromium.org

2010-08-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream Chromium debugger step tests
https://bugs.webkit.org/show_bug.cgi?id=44106

  • http/tests/inspector-enabled/console-log-before-frame-navigation.html:
  • http/tests/inspector-enabled/resources/console-log-before-frame-navigation.js: Added. (doit.callback): (doit): (receiveMessage): (frontend_dumpConsoleMessages):
  • http/tests/inspector/debugger-test.js: (frontend_captureStackTrace):
  • inspector/debugger-step-in-expected.txt: Added.
  • inspector/debugger-step-in.html: Added.
  • inspector/debugger-step-out-expected.txt: Added.
  • inspector/debugger-step-out.html: Added.
  • inspector/debugger-step-over-expected.txt: Added.
  • inspector/debugger-step-over.html: Added.

2010-08-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream Chromium debugger step tests
https://bugs.webkit.org/show_bug.cgi?id=44106

Tests: inspector/debugger-step-in.html

inspector/debugger-step-out.html
inspector/debugger-step-over.html

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::returnEvent): check that debugger is still attached after continue to ensure that current call frame is not 0.

2010-08-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream Chromium debugger step tests
https://bugs.webkit.org/show_bug.cgi?id=44106

  • src/js/Tests.js:
08:35 Changeset [65504] by commit-queue@webkit.org

2010-08-17 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by David Levin.

Trivial fix removing the self-inclusion of a couple of header files.

Self inclusion in Document.h and RenderTheme.h
https://bugs.webkit.org/show_bug.cgi?id=44065

  • dom/Document.h:
  • rendering/RenderTheme.h:
08:03 Changeset [65503] by yurys@chromium.org

2010-08-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[Qt] Web Inspector: inspector/debugger-pause-on-debugger-statement.html times out on Qt
https://bugs.webkit.org/show_bug.cgi?id=41142

  • platform/qt/Skipped: the tests should pass after r65315
08:00 ApplicationsGtk edited by laszlo.1.gombos@nokia.com
(diff)
07:54 Changeset [65502] by noam.rosenthal@nokia.com

2010-08-17 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Move the accelerated compositing build flag to the right place
https://bugs.webkit.org/show_bug.cgi?id=43882

  • wtf/Platform.h:

2010-08-17 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Move the accelerated compositing build flag to the right place
https://bugs.webkit.org/show_bug.cgi?id=43882

No new tests: build fix.

  • WebCore.pro:
07:49 Changeset [65501] by loislo@chromium.org

2010-08-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65500.
http://trac.webkit.org/changeset/65500
https://bugs.webkit.org/show_bug.cgi?id=44108

Qt bots failed to compile. (Requested by loislo on #webkit).

  • GNUmakefile.am:

2010-08-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65500.
http://trac.webkit.org/changeset/65500
https://bugs.webkit.org/show_bug.cgi?id=44108

Qt bots failed to compile. (Requested by loislo on #webkit).

  • platform/gtk/Skipped:

2010-08-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65500.
http://trac.webkit.org/changeset/65500
https://bugs.webkit.org/show_bug.cgi?id=44108

Qt bots failed to compile. (Requested by loislo on #webkit).

  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/copyInspectorFiles.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • combine-javascript-resources:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end/InspectorBackendStub.js: Added. (WebInspector.InspectorBackendStub): (WebInspector.InspectorBackendStub.prototype._registerDelegate): (WebInspector.InspectorBackendStub.prototype.sendMessageToBackend):
  • inspector/front-end/InspectorBackendStub.qrc: Removed.
  • inspector/front-end/WebKit.qrc:

2010-08-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65500.
http://trac.webkit.org/changeset/65500
https://bugs.webkit.org/show_bug.cgi?id=44108

Qt bots failed to compile. (Requested by loislo on #webkit).

  • WebKit.gyp:

2010-08-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65500.
http://trac.webkit.org/changeset/65500
https://bugs.webkit.org/show_bug.cgi?id=44108

Qt bots failed to compile. (Requested by loislo on #webkit).

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend):
07:33 Changeset [65500] by loislo@chromium.org

2010-08-16 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: replace hand written InspectorBackendStub.js by generated one.
New command-line flag was added to combine-javascript-resources.
It specifies the location of generated scripts.
https://bugs.webkit.org/show_bug.cgi?id=43791

  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • combine-javascript-resources:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end/InspectorBackendStub.js: Removed.
  • inspector/front-end/WebKit.qrc:

2010-08-16 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: replace hand written InspectorBackendStub.js by generated one.
https://bugs.webkit.org/show_bug.cgi?id=43791

  • GNUmakefile.am:

2010-08-17 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: inspector tests for GTK were added to Skip list.
They should be enabled later.
Bug for GTK https://bugs.webkit.org/show_bug.cgi?id=43977
https://bugs.webkit.org/show_bug.cgi?id=43791

  • platform/gtk/Skipped:

2010-08-17 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: replace hand written InspectorBackendStub.js by generated one.
https://bugs.webkit.org/show_bug.cgi?id=43791

  • WebKit.gyp:

2010-08-17 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: replace hand written InspectorBackendStub.js by generated one.
https://bugs.webkit.org/show_bug.cgi?id=43791

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend):
06:30 Changeset [65499] by pfeldman@chromium.org

2010-08-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: get rid of node and scoped object-specific ids.
https://bugs.webkit.org/show_bug.cgi?id=44097

  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.): (injectedScriptConstructor):
  • inspector/front-end/InjectedScriptAccess.js: (InjectedScriptAccess): (InjectedScriptAccess.getForNode): (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName): (InjectedScriptAccess._installHandler):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObjectId): (WebInspector.RemoteObject.resolveNode):
  • inspector/front-end/ScriptsPanel.js:
06:09 Changeset [65498] by kov@webkit.org

2010-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] GSettings support adds annoying warnings on systems with older glib versions
https://bugs.webkit.org/show_bug.cgi?id=44056

Add file containing GLIB_GSETTINGS macro so that
configure doesn't spit warnings in older systems.

  • autotools/gsettings.m4: Added.
  • .gitignore: Ignore files that are generated inside autotools explicitely, because we have some that are kept in version control.

WebKit/gtk

2010-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] GSettings support adds annoying warnings on systems with older glib versions
https://bugs.webkit.org/show_bug.cgi?id=44056

Use #ifdef instead of #if for HAVE_GSETTINGS to avoid warnings
when it is not defined.

  • WebCoreSupport/InspectorClientGtk.cpp:
  • webkit/webkitprivate.cpp: (webkit_init):
  • webkit/webkitprivate.h:
05:54 QtScript edited by kent.hansen@nokia.com
(diff)
05:23 Changeset [65497] by xan@webkit.org

2010-08-17 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Fix wrapping of core Events in the bindings
https://bugs.webkit.org/show_bug.cgi?id=44095

Return the proper GObject type instead of hardcoding
WebKitDOMEvent for all Event types.

  • bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::handleEvent):
  • bindings/gobject/WebKitDOMBinding.cpp: (WebKit::kit):
05:22 Changeset [65496] by xan@webkit.org

2010-08-17 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Revert supposed build-fix which was in fact reverting a previous
build fix which was correct (oh dear).

  • GNUmakefile.am:
05:15 Changeset [65495] by vestbo@webkit.org

[Qt] Add media element support for preload=none

Reviewed by Antonio Gomes.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
05:15 Changeset [65494] by vestbo@webkit.org

[Qt] Pre-roll media when loading media elements

Reviewed by Antonio Gomes.

This ensures we get correct size-hints from QtMultimedia, as well as
the media states Buffering and Buffered instead of Loading and Loaded,
which we use to transition into MediaPlayer::HaveEnoughData.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
04:54 Changeset [65493] by commit-queue@webkit.org

2010-08-17 Yuta Kitamura <yutak@chromium.org>

Reviewed by Shinichiro Hamaji.

Avoid uninitialized memory read in StringImpl::find().

REGRESSION(r65468): Crashes in StringImpl::find
https://bugs.webkit.org/show_bug.cgi?id=44099

  • wtf/text/StringImpl.cpp: (WTF::StringImpl::find):
04:38 Changeset [65492] by vestbo@webkit.org

[Qt] Fix missing default controls for stand-alone media elements

Reviewed by Kenneth Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=35427

  • css/mediaControlsQt.css:
04:18 Changeset [65491] by vestbo@webkit.org

[Qt] Implement ChromeClient's windowToScreen() and screenToWindow()

Reviewed by Kenneth Christiansen.

  • WebCoreSupport/ChromeClientQt.cpp:
02:49 QtWebKitTriageRoster edited by ossy@webkit.org
(diff)
02:30 QtWebKitRelease21 edited by ossy@webkit.org
typo fix (diff)
02:05 Changeset [65490] by yurys@chromium.org

2010-08-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream Chromium console tests
https://bugs.webkit.org/show_bug.cgi?id=44057

  • inspector/console-eval-expected.txt: Added.
  • inspector/console-eval-global-expected.txt: Added.
  • inspector/console-eval-global.html: Added.
  • inspector/console-eval.html: Added.
  • platform/chromium/inspector/console-eval-global-expected.txt: Added.

2010-08-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream Chromium console tests and remove a couple
of tests that have already been covered with layout tests.
https://bugs.webkit.org/show_bug.cgi?id=44057

  • src/js/Tests.js: (.TestSuite.prototype.testConsoleEval): (.TestSuite.prototype.testConsoleLog): (.TestSuite.prototype.testEvalGlobal):
01:55 Changeset [65489] by commit-queue@webkit.org

2010-08-17 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Ariya Hidayat.

[Qt] tests whose bug was closed but are still skipped
https://bugs.webkit.org/show_bug.cgi?id=44068

Enable tests whose bugs have been fixed already:

https://bugs.webkit.org/show_bug.cgi?id=35350 (fixed)
https://bugs.webkit.org/show_bug.cgi?id=28952 (fixed)
https://bugs.webkit.org/show_bug.cgi?id=38502 (see discussion at the end)
https://bugs.webkit.org/show_bug.cgi?id=38604 (fixed)

  • platform/qt/Skipped:
01:32 Changeset [65488] by ariya@webkit.org

2010-08-17 Ariya Hidayat <ariya@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Reduce the size of the shadow buffer to the clip region
https://bugs.webkit.org/show_bug.cgi?id=44091

Instead of allocating the buffer image (for the blur support) as big
as the rectangle which casts the shadow, we limit the size to the
current clip region.

  • platform/graphics/qt/ContextShadow.cpp: (WebCore::ContextShadow::drawShadowRect):
00:08 Changeset [65487] by mjs@apple.com

Add/correct a few items in the WebKitTestRunner Skipped list.

Rubber stamped by Sam Weinig.

  • platform/mac-wk2/Skipped:

08/16/10:

23:48 Changeset [65486] by philn@webkit.org

2010-08-17 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] media/invalid-media-url-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=42960

Implemented two ResourceHandleClient callbacks that need to notify
downstream GStreamer elements of errors while accessing the
resource.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (StreamingClient::wasBlocked): (StreamingClient::cannotShowURL):

LayoutTests:

2010-08-17 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] media/invalid-media-url-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=42960

  • platform/gtk/Skipped: Unskip fixed test
21:27 Changeset [65485] by kinuko@chromium.org

2010-08-16 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed; attempt to fix Chromium Windows build.

  • public/WebFileUtilities.h:
21:07 Changeset [65484] by jhoneycutt@apple.com

Allow some tests to pass in WebKitTestRunner before SharedMemory and
PluginInfoStore are implemented on Windows.

Reviewed by Sam Weinig.

  • Platform/win/SharedMemoryWin.cpp:

Disable not implemented warnings.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

Ditto.

20:59 Changeset [65483] by morrita@google.com

2010-08-16 Yuta Kitamura <yutak@chromium.org>

Unreviewed test expectation update.

Update Chromium test expectations.
https://bugs.webkit.org/show_bug.cgi?id=44090

  • platform/chromium/test_expectations.txt:
20:53 Changeset [65482] by kinuko@chromium.org

2010-08-16 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

[chromium] Prepare to rename WebFileSystem interface to WebFileUtilities
https://bugs.webkit.org/show_bug.cgi?id=44077

We are going to have an implementation for HTML5 FileSystem API and
it would probably be less confusing to use the name "WebFileSystem"
for an WebKit API for the HTML5 API.

This patch adds WebFileUtilities interface that is meant to replace
the existing WebFileSystem.

  • WebKit.gyp:
  • public/WebFileSystem.h:
  • public/WebFileUtilities.h: Added.
  • public/WebKitClient.h: (WebKit::WebKitClient::fileUtilities): Added.
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::fileExists): (WebCore::ChromiumBridge::deleteFile): (WebCore::ChromiumBridge::deleteEmptyDirectory): (WebCore::ChromiumBridge::getFileSize): (WebCore::ChromiumBridge::getFileModificationTime): (WebCore::ChromiumBridge::directoryName): (WebCore::ChromiumBridge::pathByAppendingComponent): (WebCore::ChromiumBridge::makeAllDirectories): (WebCore::ChromiumBridge::getAbsolutePath): (WebCore::ChromiumBridge::isDirectory): (WebCore::ChromiumBridge::filePathToURL): (WebCore::ChromiumBridge::openFile): (WebCore::ChromiumBridge::closeFile): (WebCore::ChromiumBridge::seekFile): (WebCore::ChromiumBridge::truncateFile): (WebCore::ChromiumBridge::readFromFile): (WebCore::ChromiumBridge::writeToFile):
20:42 Changeset [65481] by kinuko@chromium.org

2010-08-16 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed; build fix attempt for Windows.

  • DefaultDownloadDelegate.cpp:
20:39 Changeset [65480] by jhoneycutt@apple.com

Add some tests that fail in WebKitTestRunner to the Skipped lists.

Rubber-stamped by Sam Weinig.

  • platform/mac-wk2/Skipped:
  • platform/win-wk2/Skipped:
19:21 Changeset [65479] by barraclough@apple.com

Add VectorTraits to String & DefaultHash traits to UString to unify behaviour.

Rubber stamped by Sam Weinig

  • runtime/UString.h:

(JSC::UStringHash::hash):
(JSC::UStringHash::equal):
(WTF::):

  • wtf/text/WTFString.h:

(WTF::):

19:13 Changeset [65478] by barraclough@apple.com

Remove unnecessary includes from UString.h, add new includes as necessary.

Rubber stamped by Sam Weinig

JavaScriptCore:

  • profiler/CallIdentifier.h:
  • profiler/ProfileNode.h:
  • runtime/DateConversion.cpp:
  • runtime/Identifier.h:

(JSC::IdentifierRepHash::hash):

  • runtime/RegExpCache.h:
  • runtime/RegExpKey.h:
  • runtime/UString.cpp:

(JSC::UString::substr):

  • runtime/UString.h:
  • wtf/text/WTFString.h:

WebCore:

  • dom/ScriptExecutionContext.h:
  • loader/appcache/ApplicationCache.cpp:

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
18:54 Changeset [65477] by commit-queue@webkit.org

2010-08-16 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Ariya Hidayat.

[Qt] REGRESSION: editing/selection/shrink-selection-after-shift-pagedown.html fails after 56567
https://bugs.webkit.org/show_bug.cgi?id=36628

Just enabling the test, it's not failing anymore.

  • platform/qt/Skipped:
18:19 Changeset [65476] by commit-queue@webkit.org

2010-08-16 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Ariya Hidayat.

[Qt] qt/Skipped needs cleanup on outdaded comments
https://bugs.webkit.org/show_bug.cgi?id=44066

Minor improvements/fixes to the list of Skipped Qt tests

  • move bug reference to the right place (#35145)
  • remove outdated bug reference (#32922)
  • move inspector testcase to the right place
  • add reference to bug closed on qt-4.7 (QTBUG-9618)
  • platform/qt/Skipped: cleanups only, no logical changes
18:09 Changeset [65475] by andreas.kling@nokia.com

2010-08-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

CSS: Add fast-path for rgba() color parsing
https://bugs.webkit.org/show_bug.cgi?id=42965

Test: fast/canvas/rgba-parsing.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseColor): Extended with support for rgba(). (WebCore::parseAlphaValue): Added, parses an alpha value using WTF::strtod() (if necessary) and clamps between 0 and 1. (WebCore::isTenthAlpha):

2010-08-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

CSS: Add fast-path for rgba() color parsing
https://bugs.webkit.org/show_bug.cgi?id=42965

Add a test of rgba() color parsing.

  • fast/canvas/rgba-parsing-expected.txt: Added.
  • fast/canvas/rgba-parsing.html: Added.
  • fast/canvas/script-tests/rgba-parsing.js: Added.
18:07 Changeset [65474] by kinuko@chromium.org

2010-08-16 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

Add idl and mock classes for FileSystem API's {File,Directory}Entry and related interfaces
https://bugs.webkit.org/show_bug.cgi?id=43993

Adding DirectoryEntry, DirectoryReader, EntriesCallback and FileEntry as defined in HTML5 FileSystem API.
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html

Also adding Makefile entries for idl and mock classes added in changeset 64414 (except for Android platforms).

Tests will be added when we add underlying implementation.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/DOMFileSystem.cpp: (WebCore::DOMFileSystem::root):
  • storage/DOMFileSystem.h:
  • storage/DOMFileSystem.idl:
  • storage/DirectoryEntry.cpp: Added.
  • storage/DirectoryEntry.h: Added.
  • storage/DirectoryEntry.idl: Added.
  • storage/DirectoryReader.cpp: Added.
  • storage/DirectoryReader.h: Added.
  • storage/DirectoryReader.idl: Added.
  • storage/EntriesCallback.h: Added.
  • storage/EntriesCallback.idl: Added.
  • storage/EntryArray.cpp: Added.
  • storage/EntryArray.h: Added.
  • storage/EntryArray.idl: Added.
  • storage/Entry.cpp: (WebCore::Entry::Entry): (WebCore::Entry::getMetadata): (WebCore::Entry::moveTo): (WebCore::Entry::copyTo): (WebCore::Entry::remove): (WebCore::Entry::getParent):
  • storage/Entry.h: (WebCore::Entry::isFile): (WebCore::Entry::isDirectory):
  • storage/Entry.idl:
  • storage/FileEntry.cpp: Added.
  • storage/FileEntry.h: Added.
  • storage/FileEntry.idl: Added.
17:46 Changeset [65473] by weinig@apple.com

Add WebKit2 Mac tester to buildbot.

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
17:41 Changeset [65472] by andreas.kling@nokia.com

2010-08-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Path::closeSubpath() should only close the last subpath if it has >1 point
https://bugs.webkit.org/show_bug.cgi?id=44061

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-closepath

Test: fast/canvas/canvas-closePath-single-point.html

  • platform/graphics/Path.h: Add a Qt-only member to track the last subpath.
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::closeSubpath): Only close the last subpath if it has more than 1 point. Otherwise behave as moveTo(first point in last subpath) (WebCore::Path::Path): (WebCore::Path::operator=): (WebCore::Path::moveTo): (WebCore::Path::transform):

2010-08-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Path::closeSubpath() should only close the last subpath if it has >1 point
https://bugs.webkit.org/show_bug.cgi?id=44061

Add a test to verify behavior of closePath() when path has only 1 point.

  • fast/canvas/canvas-closePath-single-point-expected.txt: Added.
  • fast/canvas/canvas-closePath-single-point.html: Added.
  • fast/canvas/script-tests/canvas-closePath-single-point.js: Added.
17:20 Changeset [65471] by japhet@chromium.org

2010-08-16 Nate Chapin <japhet@chromium.org>

Unreviewed, build fix.

Don't include TilingDataTest.cpp, since it doesn't
compile on mac.

  • WebKit.gyp:
16:57 Changeset [65470] by japhet@chromium.org

2010-08-16 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium expectations update.

Mark 3 tests failing on Chromium Win/Linux after r65449.
They appear to have same root cause as
bugs.webkit.org/show_bug.cgi?id=43912.

  • platform/chromium/test_expectations.txt:
16:37 Changeset [65469] by japhet@chromium.org

2010-08-16 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium mac build fix (with help from jamesr).

  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint):
16:31 Changeset [65468] by barraclough@apple.com

Bug 44080 - String find/reverseFind methods need tidying up
These methods have a couple of problems with their interface, and implementation.

Reviewed by Sam Weinig

These methods take and int index, and return an int - however this is problematic
since on 64-bit string indices may have a full 32-bit range. This spills out into
surrounding code, which unsafely casts string indices from unsigned to int. Code
checking the result of these methods check for a mix of "== -1", "< 0", and
"== notFound". Clean this up by changing these methods to take an unsigned
starting index, and return a size_t. with a failed match indicated by notFound.
reverseFind also has a special meaning for the starting index argument, in that a
negative index is interpreted as an offset back from the end of the string. Remove
this functionality, in the (1!) case where it is used we should just calculate the
offset by subtracting from the string's length.

The implementation has a few problems too. The code is not in webkit style, in
using assorted abbreviations in variable names, and implementations of similar
find methods with differing argument types were unnecessarily inconsistent. When
find is passed const char* data the string would be handled as latin1 (zero
extended to UTF-16) for all characters but the first; this is sign extended.
Case-insensitive find is broken for unicode strings; the hashing optimization is
not unicode safe, and could result in false negatives.

Unify UString find methods to match String.

JavaScriptCore:

(JSC::escapeQuotes):

  • bytecompiler/NodesCodegen.cpp:

(JSC::substitute):

  • runtime/JSString.cpp:

(JSC::JSString::replaceCharacter):

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):

  • runtime/RegExpKey.h:

(JSC::RegExpKey::getFlagsValue):

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncSplit):

  • runtime/UString.cpp:
  • runtime/UString.h:

(JSC::UString::find):
(JSC::UString::reverseFind):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::find):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::find):
(WTF::StringImpl::findCaseInsensitive):
(WTF::StringImpl::reverseFind):
(WTF::StringImpl::reverseFindCaseInsensitive):
(WTF::StringImpl::endsWith):
(WTF::StringImpl::replace):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::startsWith):

  • wtf/text/WTFString.cpp:

(WTF::String::split):

  • wtf/text/WTFString.h:

(WTF::String::find):
(WTF::String::reverseFind):
(WTF::String::findCaseInsensitive):
(WTF::String::reverseFindCaseInsensitive):
(WTF::String::contains):
(WTF::find):
(WTF::reverseFind):

WebCore:

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::RareData::parseNth):

  • css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::setProperty):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • dom/Document.cpp:

(WebCore::Document::getImageMap):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::inputText):

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::input):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextBox):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertText):

  • editing/markup.cpp:

(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):

  • html/File.cpp:

(WebCore::File::Init):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::setHost):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseMappedAttribute):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::parseAccessControlAllowList):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::parseHeader):
(WebCore::parseHeaders):

  • loader/icon/IconFetcher.cpp:

(WebCore::parseIconLink):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::parseModalDialogFeatures):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::createFromDatabaseIdentifier):

  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::parse):

  • page/XSSAuditor.cpp:

(WebCore::XSSAuditor::findInRequest):

  • platform/ContentType.cpp:

(WebCore::ContentType::parameter):
(WebCore::ContentType::type):

  • platform/KURL.cpp:

(WebCore::KURL::lastPathComponent):
(WebCore::KURL::setProtocol):
(WebCore::decodeURLEscapeSequences):
(WebCore::substituteBackslashes):
(WebCore::mimeTypeFromDataURL):

  • platform/Length.cpp:

(WebCore::newCoordsArray):
(WebCore::newLengthArray):

  • platform/LinkHash.cpp:

(WebCore::findSlashDotDotSlash):
(WebCore::findSlashSlash):
(WebCore::findSlashDotSlash):
(WebCore::cleanPath):

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForPath):

  • platform/SchemeRegistry.cpp:

(WebCore::SchemeRegistry::shouldTreatURLAsLocal):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::load):

  • platform/mac/DragImageMac.mm:

(WebCore::createDragImageIconForCachedImage):

  • platform/network/CredentialStorage.cpp:

(WebCore::protectionSpaceMapKeyFromURL):
(WebCore::findDefaultProtectionSpaceForURL):

  • platform/network/HTTPParsers.cpp:

(WebCore::skipWhiteSpace):
(WebCore::skipToken):
(WebCore::parseHTTPRefresh):
(WebCore::filenameFromHTTPContentDisposition):
(WebCore::findCharsetInMediaType):
(WebCore::parseXSSProtectionHeader):
(WebCore::extractReasonPhraseFromHTTPStatusLine):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::isAttachment):
(WebCore::parseCacheHeader):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::updateWidget):

  • storage/Entry.cpp:

(WebCore::Entry::Entry):

  • svg/SVGFont.cpp:

(WebCore::isCompatibleGlyph):

  • svg/SVGURIReference.cpp:

(WebCore::SVGURIReference::getTarget):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseClockValue):
(WebCore::SVGSMILElement::parseCondition):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunSubstringBefore::evaluate):
(WebCore::XPath::FunSubstringAfter::evaluate):
(WebCore::XPath::FunTranslate::evaluate):
(WebCore::XPath::FunLang::evaluate):

  • xml/XPathParser.cpp:

(WebCore::XPath::Parser::expandQName):

16:23 Changeset [65467] by rniwa@webkit.org

2010-08-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium
https://bugs.webkit.org/show_bug.cgi?id=44070

The crash was caused by start or end node being removed in pushDownInlineStyleAroundNode.
It made start and end orphaned, and caused s.node() to be detached from the document.
Fixed the crash by using nodes passed to pushDownInlineStyleAroundNode for start and end if the original
start and end are orphaned because pushDownInlineStyleAroundNode won't prune targetNode.

Test: editing/pasteboard/smart-paste-003-trailing-whitespace.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyle):

2010-08-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium
https://bugs.webkit.org/show_bug.cgi?id=44070

The bug only reproduced on Windows when trailing space is selected only on Windows.
Added a crash test to copy & paste a word with trailing space.

  • editing/pasteboard/smart-paste-003-trailing-whitespace-expected.txt: Added.
  • editing/pasteboard/smart-paste-003-trailing-whitespace.html: Added.
  • platform/chromium/test_expectations.txt: editing/pasteboard/smart-paste-003.html and smart-paste-004.html should not crash.
16:06 Changeset [65466] by weinig@apple.com

Fix windows build.

  • Shared/win/CommandLineWin.cpp:
16:00 Changeset [65465] by weinig@apple.com

Remove #includes of <WebCore/PlatformString.h> in favor of <wtf/text/WTFString.h>

Reviewed by Gavin Barraclough.

  • Platform/Module.cpp:
  • Platform/Module.h:
  • Shared/CommandLine.h:
  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebEvent.h:
  • Shared/WebNavigationDataStore.h:
  • Shared/WebPreferencesStore.h:
  • Shared/WebString.h:
  • Shared/WebURL.h:
  • Shared/mac/CommandLineMac.cpp:
  • Shared/qt/UpdateChunk.cpp:
  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/cf/WKStringCF.cpp:
  • UIProcess/API/C/cf/WKURLCF.cpp:
  • UIProcess/API/cpp/qt/WKStringQt.cpp:
  • UIProcess/API/cpp/qt/WKURLQt.cpp:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:
  • UIProcess/WebBackForwardListItem.cpp:
  • UIProcess/WebBackForwardListItem.h:
  • UIProcess/WebContext.h:
  • UIProcess/WebContextInjectedBundleClient.cpp:
  • UIProcess/WebFrameProxy.cpp:
  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPolicyClient.cpp:
  • UIProcess/WebProcessProxy.cpp:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/win/WebView.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
  • WebProcess/Plugins/JSNPObject.cpp:
  • WebProcess/Plugins/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:
  • WebProcess/Plugins/Netscape/NetscapePluginModule.h:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebKitMain.cpp:
  • WebProcess/win/WebProcessMainWin.cpp:
15:54 Changeset [65464] by japhet@chromium.org

2010-08-16 Nate Chapin <japhet@chromium.org>

Chromium win rebaseline + test expectations tweaks.

  • platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:48 Changeset [65463] by jamesr@google.com

fix build

15:35 Changeset [65462] by hyatt@apple.com

Fix Chromium/Qt bustage.

15:32 Changeset [65461] by hyatt@apple.com

Fix Chromium Bustage.

15:30 Changeset [65460] by hyatt@apple.com

Fix Chromium Bustage.

15:22 Changeset [65459] by weinig@apple.com

Null CFURLRef returned from provisionalURL after searching on zillow.com
<rdar://problem/8261812>
https://bugs.webkit.org/show_bug.cgi?id=44072

Reviewed by Gavin Barraclough.

Conversion from WKURLRef to CFRURLRef was breaking on URLs using characters
such as '{'.

  • UIProcess/API/C/cf/WKURLCF.cpp:

(WKURLCopyCFURL): Use code similar to that found in KURLCFNet.cpp for conversion.

14:48 Changeset [65458] by hyatt@apple.com

Fix Qt bustage.

14:43 Changeset [65457] by weinig@apple.com

Remove unnecessary copy constructor, assignment operator and swap function.
The defaults (for all except swap) should do just fine.

Reviewed by Gavin Barraclough.

  • Shared/WebPreferencesStore.cpp:
  • Shared/WebPreferencesStore.h:
14:37 Changeset [65456] by hyatt@apple.com

Fix Qt build bustage.

14:36 Changeset [65455] by commit-queue@webkit.org

2010-08-16 Vincent Scheib <scheib@chromium.org>

Reviewed by Dimitri Glazkov.

Canvas2D does not support images larger than system's GPU max texture size
https://bugs.webkit.org/show_bug.cgi?id=43864

A new class "TilingData" has been created that provides logic for
splitting a large image into a series of smaller tiles.

GLES2Texture and CLES2Canvas are modified to use the TilingData to
split images on texture upload and render one logical image as many smaller
images.

TilingData is tested via unit tests in WebKit/chromium/tests/TilingDataTest.cpp

  • WebCore.gypi:
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::drawTexturedRectTile):
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/chromium/GLES2Texture.cpp: (WebCore::GLES2Texture::GLES2Texture): (WebCore::GLES2Texture::~GLES2Texture): (WebCore::GLES2Texture::create): (WebCore::copySubRect): (WebCore::GLES2Texture::load): (WebCore::GLES2Texture::bindTile):
  • platform/graphics/chromium/GLES2Texture.h: (WebCore::GLES2Texture::tiles):
  • platform/graphics/chromium/TilingData.cpp: Added. (WebCore::computeNumTiles): (WebCore::TilingData::TilingData): (WebCore::TilingData::tileXIndexFromSrcCoord): (WebCore::TilingData::tileYIndexFromSrcCoord): (WebCore::TilingData::tileBounds): (WebCore::TilingData::tileBoundsWithBorder): (WebCore::TilingData::tileBoundsNormalized): (WebCore::TilingData::tilePositionX): (WebCore::TilingData::tilePositionY): (WebCore::TilingData::tileSizeX): (WebCore::TilingData::tileSizeY): (WebCore::TilingData::overlappedTileIndices): (WebCore::TilingData::intersectDrawQuad):
  • platform/graphics/chromium/TilingData.h: Added. (WebCore::TilingData::maxTextureSize): (WebCore::TilingData::totalSizeX): (WebCore::TilingData::totalSizeY): (WebCore::TilingData::numTiles): (WebCore::TilingData::numTilesX): (WebCore::TilingData::numTilesY): (WebCore::TilingData::tileIndex): (WebCore::TilingData::tileXIndex): (WebCore::TilingData::tileYIndex): (WebCore::TilingData::TilingData): (WebCore::TilingData::assertTile):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::uploadSoftwareToHardware):

2010-08-16 Vincent Scheib <scheib@chromium.org>

Reviewed by Dimitri Glazkov.

Canvas2D does not support images larger than system's GPU max texture size
https://bugs.webkit.org/show_bug.cgi?id=43864

Unit tests for TilingData class.

  • WebKit.gyp:
  • tests/TilingDataTest.cpp: Added. (WebCore::TEST):
14:34 Changeset [65454] by hyatt@apple.com

Fix GTK build bustage.

14:31 Changeset [65453] by hyatt@apple.com

Fix GTK build bustage.

14:28 Changeset [65452] by hyatt@apple.com

Fix Qt build bustage.

14:26 Changeset [65451] by hyatt@apple.com

Fix GTK build bustage.

14:21 Changeset [65450] by cmarrin@apple.com

Put ANGLE include inside PLATFORM(MAC) to fix Chrome and Qt builds

13:44 Changeset [65449] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=43507, stop ImageBuffer from copying its data when rendering after canvas changes happen.

Reviewed by Anders Carlsson.

This patch renames ImageBuffer::image() to ImageBuffer::copyImage(). The new method always returns a new copy that is a current
snapshot of the ImageBuffer.

To draw an ImageBuffer, you now use new GraphicsContext calls: drawImageBuffer. Platforms can then optimize these calls to draw
efficiently without having to copy the bits of the ImageBuffer into an Image.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::image):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::willDraw):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::setSurfaceSize):
(WebCore::HTMLCanvasElement::copiedImage):
(WebCore::HTMLCanvasElement::clearCopiedImage):

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasPattern.cpp:

(WebCore::CanvasPattern::CanvasPattern):

  • html/canvas/CanvasPattern.h:

(WebCore::CanvasPattern::create):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):

  • html/canvas/WebGLRenderingContext.h:

(WebCore::WebGLRenderingContext::paintsIntoCanvasBuffer):

  • platform/graphics/GeneratedImage.cpp:

(WebCore::GeneratedImage::drawPattern):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::clipToImageBuffer):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):

  • platform/graphics/Image.h:
  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::width):
(WebCore::ImageBuffer::height):

  • platform/graphics/Pattern.cpp:

(WebCore::Pattern::Pattern):

  • platform/graphics/Pattern.h:

(WebCore::Pattern::create):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::clip):

  • platform/graphics/cg/ImageBufferData.h:
  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::apply):

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::apply):

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::apply):

  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::apply):

  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/ImageBufferData.h:
  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::clip):

  • platform/graphics/skia/GraphicsContextSkia.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::):

  • platform/graphics/wx/GraphicsContextWx.cpp:
  • platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

  • rendering/RenderSVGResourceGradient.cpp:

(WebCore::clipToTextMask):

  • rendering/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

  • rendering/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintProgressBar):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::build):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImageForCurrentFrame):

  • svg/graphics/SVGImage.h:
  • svg/graphics/filters/SVGFEMerge.cpp:

(WebCore::FEMerge::apply):

  • svg/graphics/filters/SVGFEOffset.cpp:

(WebCore::FEOffset::apply):

  • svg/graphics/filters/SVGFETile.cpp:

(WebCore::FETile::apply):

13:19 Changeset [65448] by cmarrin@apple.com

Fixed a warning in ANGLEWebKitBridge.cpp

13:15 Changeset [65447] by cmarrin@apple.com

Build ANGLE for all versions of Mac to fix Leopard build

12:30 BuildingQtOnWindows edited by jocelyn.turcotte@nokia.com
python 2.6 -> python 2.x (diff)
12:18 Changeset [65446] by cmarrin@apple.com

2010-08-16 Paul Sawaya <psawaya@apple.com>

Reviewed by Chris Marrin.

Added shader validation via ANGLE
https://bugs.webkit.org/show_bug.cgi?id=42405

12:12 Changeset [65445] by kevino@webkit.org

[wx] Build fix, do not build WebCore as a convenience library as this leads to
errors in the Win build w/export symbols and causes problems with DOM bindings
debugging in gdb.

12:00 Changeset [65444] by commit-queue@webkit.org

2010-08-16 Mihai Parparita <mihaip@chromium.org>

Reviewed by Nate Chapin.

Some http/tests/history tests now pass on Chromium after r65340
https://bugs.webkit.org/show_bug.cgi?id=44033

Remove expected failures.

  • platform/chromium/test_expectations.txt:
11:24 Changeset [65443] by loislo@chromium.org

2010-08-16 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Adam Roben.

Current implementation of WebCore post-build step on windows platform is error prone.
It would be better to extract the script into external file.
https://bugs.webkit.org/show_bug.cgi?id=44058

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd: Added.
  • WebCore.vcproj/copyInspectorFiles.cmd: Added.
11:09 Changeset [65442] by kevino@webkit.org

[wx] Fix typo in previous build fix.

11:04 Changeset [65441] by commit-queue@webkit.org

2010-08-16 Alex Milowski <alex@milowski.com>

Reviewed by David Levin.

Added the configuration of the MathML related files.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

2010-08-16 Alex Milowski <alex@milowski.com>

Reviewed by David Levin.

Added the ENABLE_MATHML=1 to the feature_defines.

  • features.gypi:
10:39 Changeset [65440] by pfeldman@chromium.org

2010-08-16 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fix Leopard Release inspector tests.

  • inspector/front-end/inspector.js:
10:30 Changeset [65439] by bulach@chromium.org

2010-08-16 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Implements IDBKeyPath extractor.
https://bugs.webkit.org/show_bug.cgi?id=43276

Unit-test IDBKeyPathExtractorTest.cpp.
LayoutTests will arrive as IndexedDB infrastructure is fleshed out.

  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::getValueFrom): (WebCore::createIDBKeyFromSerializedValueAndKeyPath):
  • bindings/v8/IDBBindingUtilities.h:

2010-08-16 Marcus Bulach <bulach@chromium.org>

Reviewed by Jeremy Orlow.

Implements IDBKeyPath extractor.
https://bugs.webkit.org/show_bug.cgi?id=43276

Unit-test IDBKeyPathExtractorTest.cpp.
LayoutTests will arrive as IndexedDB infrastructure is fleshed out.

  • WebKit.gyp:
  • public/WebIDBKey.h:
  • public/WebIDBKeyPath.h: Added. (WebKit::WebIDBKeyPath::WebIDBKeyPath): (WebKit::WebIDBKeyPath::~WebIDBKeyPath):
  • public/WebPrivateOwnPtr.h: Added. (WebKit::WebPrivateOwnPtr::WebPrivateOwnPtr): (WebKit::WebPrivateOwnPtr::~WebPrivateOwnPtr): (WebKit::WebPrivateOwnPtr::reset): (WebKit::WebPrivateOwnPtr::get): (WebKit::WebPrivateOwnPtr::operator->):
  • src/WebIDBKey.cpp: (WebKit::WebIDBKey::createFromValueAndKeyPath):
  • src/WebIDBKeyPath.cpp: Added. (WebKit::WebIDBKeyPath::create): (WebKit::WebIDBKeyPath::WebIDBKeyPath): (WebKit::WebIDBKeyPath::parseError): (WebKit::WebIDBKeyPath::assign): (WebKit::WebIDBKeyPath::reset): (WebKit::WebIDBKeyPath::operator const WTF::Vector<WebCore::IDBKeyPathElement, 0>&):
  • tests/IDBBindingUtilitiesTest.cpp: Added. (WebCore::LocalContext::LocalContext): (WebCore::LocalContext::~LocalContext): (WebCore::checkKeyFromValueAndKeyPathInternal): (WebCore::checkKeyPathNullValue): (WebCore::checkKeyPathStringValue): (WebCore::checkKeyPathNumberValue): (WebCore::TEST):
10:10 Changeset [65438] by kov@webkit.org

2010-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Kenneth Rohde Christiansen and Martin Robinson.

[GTK] GTK+ drawing idle starved
https://bugs.webkit.org/show_bug.cgi?id=43994

Tune down the priority of the shared timers to guarantee GTK+ has
an opportunity to redraw.

  • platform/gtk/SharedTimerGtk.cpp: (WebCore::setSharedTimerFireTime):
09:44 Changeset [65437] by leandro@webkit.org

2010-08-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Build fix after r65366.

  • CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if they're empty.
  • jsc/CMakeLists.txt: Ditto.
  • wtf/CMakeLists.txt: Ditto.

2010-08-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Build fix after r65366.

  • CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if they're empty.

2010-08-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Build fix after r65366.

EFL port does not support automated tests yet.

  • CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if they're empty.
09:40 Changeset [65436] by steveblock@google.com

Unreviewed build fix.

Add fast/dom/Geolocation/disconnected-frame-permission-denied.html to failing tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=44059

  • platform/chromium/test_expectations.txt:
09:35 Changeset [65435] by mitz@apple.com

Build fix.

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage): Initialize the contentsSizeChanged member.
(WTR::TestController::initialize): Ditto.

09:33 Changeset [65434] by pfeldman@chromium.org

2010-08-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Make InjectedScript proto-based.
https://bugs.webkit.org/show_bug.cgi?id=44028

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):

2010-08-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Make InjectedScript proto-based.
https://bugs.webkit.org/show_bug.cgi?id=44028
Drive-by test fix.

  • http/tests/inspector-enabled/console-log-before-frame-navigation.html:
  • http/tests/inspector-enabled/resources/console-log-before-frame-navigation.js: Removed.
  • http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html:
09:31 Changeset [65433] by kevino@webkit.org

wxMSW build fix. Don't build the Python DOM bindings until we get the export issues
sorted out.

09:29 Changeset [65432] by ossy@webkit.org

Fix warning in WebCore/plugins/win/PluginPackageWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=43920

Reviewed by Adam Roben.

  • plugins/win/PluginPackageWin.cpp:

(WebCore::PluginPackage::fetchInfo):

09:19 Changeset [65431] by ossy@webkit.org

Unreviewed.

[Qt] fast/dom/Geolocation/disconnected-frame-permission-denied.html fails
https://bugs.webkit.org/show_bug.cgi?id=44059

  • platform/qt/Skipped: fast/dom/Geolocation/disconnected-frame-permission-denied.html skipped until fix.
09:15 Changeset [65430] by pfeldman@chromium.org

2010-08-16 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Touch inspector file to force frontend deployment.

  • inspector/InspectorController.cpp:
09:06 Changeset [65429] by kevino@webkit.org

[wx] Build fix for non-Win ports on Windows.

08:16 Changeset [65428] by agl@chromium.org

2010-08-16 Adam Langley <agl@chromium.org>

Reviewed by Tony Chang.

[chromium] Improve spacing support for complex text on Linux

https://bugs.webkit.org/show_bug.cgi?id=39014

Previously, our complex text support ignored word-spacing,
justification and letter-spacing. This fixes the first two issues and
allows us to render Scribd's HTML5 documents much better.

Test: fast/text/atsui-spacing-features.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::setWordSpacingAdjustment): (WebCore::TextRunWalker::setLetterSpacingAdjustment): (WebCore::TextRunWalker::setPadding): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::TextRunWalker::isCodepointSpace): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
08:14 Changeset [65427] by ossy@webkit.org

Fix warnings: unknown conversion type character 'l' in format
https://bugs.webkit.org/show_bug.cgi?id=43359

Reviewed by Kenneth Rohde Christiansen.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::performURLImport): Replace %zu with %lu, because Windows doesn't understand z modifier.
(WebCore::IconDatabase::pruneUnretainedIcons): Use %I64i intsead of %lli on Windows.

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:

(WebCore::MediaPlayerPrivate::totalTimeChanged): Use %I64d intsead of %lld on Windows.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::setMaximumSize): Use %I64i intsead of %lli on Windows.

  • storage/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::setQuota): Use %I64u intsead of %llu on Windows.

08:02 Changeset [65426] by ossy@webkit.org

Fix warnings: unknown conversion type character 'l' in format
https://bugs.webkit.org/show_bug.cgi?id=43359

Reviewed by Kenneth Rohde Christiansen.

  • loader/FTPDirectoryParser.cpp: Use %I64u format specifier instead of %llu on Windows.

(WebCore::parseOneFTPLine):

07:32 Changeset [65425] by ariya@webkit.org

[Qt] Shadow blur for rectangle fill
https://bugs.webkit.org/show_bug.cgi?id=44025

Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-16
Reviewed by Kenneth Rohde Christiansen.

WebCore:

The blur implementation follows the approximation of Gaussian blur
with three successive box blurs, working on the alpha channel only.
(see http://www.w3.org/TR/SVG/filters.html#feGaussianBlur).

  • WebCore.pro: Refer to ContexShadow.* files.
  • platform/graphics/qt/ContextShadow.cpp: Added.

(WebCore::ContextShadow::ContextShadow):
(WebCore::ContextShadow::clear):
(WebCore::blurHorizontal): Box blurs in horizontal direction, working
on QImage (in-place).
(WebCore::shadowBlur): Main blur function which just calls the
above blurHorizontal function twice, once with transposed image
(equivalent as it would have done vertical box blurs).
(WebCore::ContextShadow::drawShadowRect):

  • platform/graphics/qt/ContextShadow.h: Added.

(WebCore::ContextShadow::):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContextPlatformPrivate::hasShadow):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::fillRect): Use ContextShadow for the shadow.
(WebCore::GraphicsContext::setPlatformShadow):

LayoutTests:

Update pixel test reference after the blur support.

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
07:09 Changeset [65424] by abecsi@webkit.org

2010-08-16 Andras Becsi <abecsi@webkit.org>

Rubber-stamped by Gustavo Noronha Silva.

[GTK] Build fix for MathML code generation.

No new tests needed.

  • GNUmakefile.am:
06:58 Changeset [65423] by commit-queue@webkit.org

2010-08-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65414.
http://trac.webkit.org/changeset/65414
https://bugs.webkit.org/show_bug.cgi?id=44055

GTL & QT tests failing. (Requested by pfeldman on #webkit).

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
06:39 Changeset [65422] by abecsi@webkit.org

2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

Handle content size change in WebKit2
Re-landing after fix.

https://bugs.webkit.org/show_bug.cgi?id=43198

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
  • MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.

2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

Handle content size change in WebKit2
Re-landing after fix.

https://bugs.webkit.org/show_bug.cgi?id=43198

Based on the work of Antti Koivisto.
Send message to the UI client when the contents size has changed through the WebChromeClient
and propagate it to the WKPageUIClient.

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: (WebPageProxyMessage::): Added ContentsSizeChanged message kind.
  • UIProcess/API/C/WKPage.h: Added WKPageContentsSizeChangedCallback callback to the WKPageUIClient.
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Initialize the new callback to 0.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Handle ContentsSizeChanged message. Calls contetsSizeChanged. (WebKit::WebPageProxy::contentsSizeChanged): Added. Propagate the event to the the UI client.
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::contentsSizeChanged): Added. Propagate the event forward to the WKPageUIClient.
  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged): Implemented.
06:28 Changeset [65421] by commit-queue@webkit.org

2010-08-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65419.
http://trac.webkit.org/changeset/65419
https://bugs.webkit.org/show_bug.cgi?id=44053

Broke the Windows build (Requested by bbandix on #webkit).

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: (WebPageProxyMessage::):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged):

2010-08-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65419.
http://trac.webkit.org/changeset/65419
https://bugs.webkit.org/show_bug.cgi?id=44053

Broke the Windows build (Requested by bbandix on #webkit).

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • MiniBrowser/win/BrowserView.cpp: (BrowserView::create):
05:58 Changeset [65420] by ariya@webkit.org

2010-08-16 Ariya Hidayat <ariya@sencha.com>

Reviewed by Antonio Gomes.

[Qt] Save and restore shadow state in GraphicsContextQt
https://bugs.webkit.org/show_bug.cgi?id=44031

This is needed after r65362.
Use a new class ContextShadowParameter to track and keep the shadow
state. We use this rather than using GraphicsContextState to allow
possible optimizations (right now only to determine the shadow type,
but in future it might cover things like cached scratch image,
persistent shader, etc).

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::ContextShadowParameter::): (WebCore::ContextShadowParameter::ContextShadowParameter): (WebCore::ContextShadowParameter::clear): (WebCore::GraphicsContextPlatformPrivate::hasShadow): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow):
05:52 Changeset [65419] by abecsi@webkit.org

2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

Handle content size change in WebKit2

https://bugs.webkit.org/show_bug.cgi?id=43198

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
  • MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.

2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

Handle content size change in WebKit2

https://bugs.webkit.org/show_bug.cgi?id=43198

Based on the work of Antti Koivisto.
Send message to the UI client when the contents size has changed through the WebChromeClient
and propagate it to the WKPageUIClient.

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: (WebPageProxyMessage::): Added ContentsSizeChanged message kind.
  • UIProcess/API/C/WKPage.h: Added WKPageContentsSizeChangedCallback callback to the WKPageUIClient.
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Initialize the new callback to 0.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): Handle ContentsSizeChanged message. Calls contetsSizeChanged. (WebKit::WebPageProxy::contentsSizeChanged): Added. Propagate the event to the the UI client.
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::contentsSizeChanged): Added. Propagate the event forward to the WKPageUIClient.
  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged): Implemented.
05:44 Changeset [65418] by ariya@webkit.org

Add my new email address to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
05:43 Changeset [65417] by bulach@chromium.org

2010-07-28 Marcus Bulach <bulach@chromium.org>

Reviewed by Adam Barth.

Implement IDBKeyPath parser.
https://bugs.webkit.org/show_bug.cgi?id=42976

IDBKeyPath is an internal class, exposed only for unit tests for now.
It'll allow indexed database implementation to traverse a given key path and obtain the corresponding properties
from a SerializedScriptValue.

  • WebCore.gypi:
  • storage/IDBKeyPath.cpp: Added. (WebCore::IDBKeyPath::create): (WebCore::IDBKeyPath::IDBKeyPath): (WebCore::IDBKeyPath::~IDBKeyPath): (WebCore::IDBKeyPath::hasNext): (WebCore::IDBKeyPath::next): (WebCore::IDBKeyPath::identifier): (WebCore::IDBKeyPath::hasIndex): (WebCore::IDBKeyPath::indexValue): (WebCore::IDBKeyPath::parserError): (WebCore::IDBKeyPath::parse): (WebCore::IDBKeyPath::Lexer::lex): (WebCore::isSafeIdentifierStartCharacter): (WebCore::isSafeIdentifierCharacter): (WebCore::IDBKeyPath::Lexer::lexIdentifier): (WebCore::IDBKeyPath::Lexer::lexNumber):
  • storage/IDBKeyPath.h: Added. (WebCore::IDBKeyPath::Token::Token): (WebCore::IDBKeyPath::): (WebCore::IDBKeyPath::Lexer::Lexer): (WebCore::IDBKeyPath::Lexer::next): (WebCore::IDBKeyPath::Lexer::currentToken):

2010-07-28 Marcus Bulach <bulach@chromium.org>

Reviewed by Adam Barth.

Implement IDBKeyPath parser.
https://bugs.webkit.org/show_bug.cgi?id=42976

IDBKeyPath is an internal class, exposed only for unit tests for now.
It'll allow indexed database implementation to traverse a given key path and obtain the corresponding properties
from a SerializedScriptValue.

  • WebKit.gyp:
  • tests/IDBKeyPathTest.cpp: Added. (WebCore::ExpectedToken::ExpectedToken): (WebCore::checkKeyPath): (WebCore::TEST):
05:30 Changeset [65416] by steveblock@google.com

2010-08-13 Steve Block <steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Geolocation requests in progress when the frame is disconnected should invoke the error callback
https://bugs.webkit.org/show_bug.cgi?id=43974

If requests are ongoing when the Frame is disconnected, we abort them with a fatal error.
To do this, when Geolocation::disconnectFrame() is called we call cancelAllRequests() to
set a fatal error on all ongoing requests. Once the requests have made their error
callbacks, they are deleted. Note that we check at callback time that the script
execution context for the callback is still valid, so it's safe to attempt these
callbacks even after the Geolocation object's Frame has gone.

This requires a change to allow multiple calls to GeoNotifier::setFatalError().
For repeated calls, we do not replace the existing error. This ensures that when
permission has been denied and the frame is then disconnected, the error callback
reports the permission error, as required by the spec.

Tests: fast/dom/Geolocation/disconnected-frame.html

fast/dom/Geolocation/disconnected-frame-permission-denied.html

  • page/Geolocation.cpp: (WebCore::Geolocation::GeoNotifier::setFatalError): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::startRequest): (WebCore::Geolocation::cancelAllRequests):
  • page/Geolocation.h:

2010-08-13 Steve Block <steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Geolocation requests in progress when the frame is disconnected should invoke the error callback
https://bugs.webkit.org/show_bug.cgi?id=43974

Added new tests to GTK skipped list.

  • fast/dom/Geolocation/disconnected-frame.html: Added.
  • fast/dom/Geolocation/disconnected-frame-expected.txt: Added.
  • fast/dom/Geolocation/script-tests/disconnected-frame.js: Added.
  • fast/dom/Geolocation/resources/disconnected-frame-inner.html: Added.
  • fast/dom/Geolocation/disconnected-frame-permission-denied.html: Added.
  • fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt: Added.
  • fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js: Added.
  • platform/gtk/Skipped:
05:23 Changeset [65415] by pfeldman@chromium.org

2010-08-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: upstream frontend-side WebSocket transport.
https://bugs.webkit.org/show_bug.cgi?id=43970

Chromium already has an alternate WebSocket-based communication channel with
the backend. Upstreaming it in this change. We will agree on the URI
of the remote service as the protocol matures.

2010-08-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: upstream frontend-side WebSocket transport.
https://bugs.webkit.org/show_bug.cgi?id=43970

Chromium already has an alternate WebSocket-based communication channel with
the backend. Upstreaming it in this change. We will agree on the URI
of the remote service as the protocol matures.

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
  • src/js/DevTools.js: (WebInspector.loaded): (devtools.domContentLoaded):
05:19 Changeset [65414] by pfeldman@chromium.org

2010-08-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Make InjectedScript proto-based.
https://bugs.webkit.org/show_bug.cgi?id=44028

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor): (injectedScriptConstructor.):
  • inspector/front-end/inspector.js: (WebInspector.loaded):
05:16 Changeset [65413] by yurys@chromium.org

2010-08-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove utility context related code from debugger agent
https://bugs.webkit.org/show_bug.cgi?id=44049

  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::onV8DebugMessage): (WebKit::DebuggerAgentManager::pauseScript):
  • src/DebuggerAgentManager.h:
05:16 Changeset [65412] by pfeldman@chromium.org

2010-08-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: [REGRESSION] console's clear command does not work.
https://bugs.webkit.org/show_bug.cgi?id=44027

  • inspector/console-clear.html:
  • inspector/console-command-clear-expected.txt: Added.
  • inspector/console-command-clear.html: Copied from LayoutTests/inspector/console-clear.html.

2010-08-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: [REGRESSION] console's clear command does not work.
https://bugs.webkit.org/show_bug.cgi?id=44027

Test: inspector/console-command-clear.html

  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorBackend.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::clearConsoleMessages):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.requestClearMessages):
  • inspector/front-end/inspector.js: (WebInspector.consoleMessagesCleared):
04:57 Changeset [65411] by hamaji@chromium.org

2010-08-16 Yuta Kitamura <yutak@chromium.org>

Reviewed by Shinichiro Hamaji.

Attempt to fix Chromium's test_shell_tests.

Port Chromium's WebEntities to HTMLEntityTable
https://bugs.webkit.org/show_bug.cgi?id=44036

  • src/WebEntities.cpp: (WebKit::):
04:26 Changeset [65410] by jorlow@chromium.org

2010-08-16 Jeremy Orlow <jorlow@chromium.org>

Ugh, the #if ENABLE() was supposed to be added to Settings not GroupSettings.

  • page/GroupSettings.cpp: (WebCore::GroupSettings::GroupSettings): (WebCore::GroupSettings::setLocalStorageQuotaBytes):
  • page/GroupSettings.h:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:
04:09 Changeset [65409] by jorlow@chromium.org

2010-08-16 Jeremy Orlow <jorlow@chromium.org>

Last build fix?

  • page/PageGroup.cpp: (WebCore::PageGroup::PageGroup):
03:53 Changeset [65408] by jorlow@chromium.org

2010-08-16 Jeremy Orlow <jorlow@chromium.org>

Ugh...another build fix.

  • page/GroupSettings.cpp: (WebCore::GroupSettings::GroupSettings):
  • page/GroupSettings.h:
03:40 Changeset [65407] by jorlow@chromium.org

2010-08-16 Jeremy Orlow <jorlow@chromium.org>

Build fix.

  • GNUmakefile.am:
03:20 Changeset [65406] by jorlow@chromium.org

2010-08-16 Jeremy Orlow <jorlow@chromium.org>

Build fix.

  • page/PageGroup.cpp: (WebCore::PageGroup::localStorage):
03:02 Changeset [65405] by jorlow@chromium.org

2010-08-13 Jeremy Orlow <jorlow@chromium.org>

Some settings are linked to the PageGroup not the Page. Create a new class for those.
https://bugs.webkit.org/show_bug.cgi?id=43794

Since persistient storage is shared between pages, there's no way to modify
some settings related to it on a per page basis. As such, it's not technically
correct for these settings to be on the Page's settings. Create a new class
called GroupSettings, move group-wide local storage setting there (the other we
can't), and add a new setting for IndexedDB's path (which is prompting this change).

No behavior has changed, so no tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/GroupSettings.cpp: Added. (WebCore::GroupSettings::GroupSettings): (WebCore::GroupSettings::setLocalStorageQuotaBytes): (WebCore::GroupSettings::setLocalStorageDatabasePath): (WebCore::GroupSettings::setIndexedDBDatabasePath):
  • page/GroupSettings.h: Added. (WebCore::GroupSettings::create): (WebCore::GroupSettings::localStorageQuotaBytes): (WebCore::GroupSettings::localStorageDatabasePath): (WebCore::GroupSettings::indexedDBDatabasePath):
  • page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): (WebCore::PageGroup::localStorage):
  • page/PageGroup.h: (WebCore::PageGroup::groupSettings):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setSessionStorageQuota):
  • page/Settings.h:
02:44 Changeset [65404] by morrita@google.com

2010-08-16 MORITA Hajime <morrita@google.com>

Unreviewed; test expectations fix for Chromium.

  • platform/chromium/test_expectations.txt:
02:21 Changeset [65403] by zoltan@webkit.org

Unreviewed Qt WebKit2 build fix.

Patch by Balazs Kelemen <kb@inf.u-szeged.hu> on 2010-08-16

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformSetUpWebProcess): Added empty stub implementation.

  • WebKit2.pro: Enumerate new files, include WebKit.pri for correct define macro set.
02:09 Changeset [65402] by abarth@webkit.org

2010-08-16 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

document.write causes the links to appear twice (noscript content is not ignored)
https://bugs.webkit.org/show_bug.cgi?id=16230

Add a test for this case.

  • fast/parser/document-write-noscript-expected.txt: Added.
  • fast/parser/document-write-noscript.html: Added.
01:51 Changeset [65401] by abarth@webkit.org

2010-08-16 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

document.write() isn't processed immediately before DOM access
https://bugs.webkit.org/show_bug.cgi?id=36881

Test that document.write gets flushed before DOM access takes place.

  • fast/tokenizer/document-write-racing-dom-access-expected.txt: Added.
  • fast/tokenizer/document-write-racing-dom-access.html: Added.
01:45 Changeset [65400] by hamaji@chromium.org

2010-08-16 Yuta Kitamura <yutak@chromium.org>

Not reviewed. Chromium test expectations updates and rebaselines.

  • platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.checksum: Added.
  • platform/chromium-linux/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
  • platform/chromium-linux/fast/text/word-space-expected.checksum:
  • platform/chromium-linux/fast/text/word-space-expected.png:
  • platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.checksum: Added.
  • platform/chromium-mac/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
  • platform/chromium-mac/fast/text/word-space-expected.checksum: Added.
  • platform/chromium-mac/fast/text/word-space-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Added.
  • platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.checksum: Added.
  • platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.png: Added.
  • platform/chromium-win/fast/canvas/setWidthResetAfterForcedRender-expected.txt: Added.
  • platform/chromium-win/fast/text/word-space-expected.checksum:
  • platform/chromium-win/fast/text/word-space-expected.png:
  • platform/chromium-win/fast/text/word-space-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/chromium/test_expectations.txt:
01:45 Changeset [65399] by zoltan@webkit.org

2010-08-16 Zoltan Horvath <zoltan@webkit.org>

Add my old e-mail addresses to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
01:22 Changeset [65398] by morrita@google.com

2010-08-16 MORITA Hajime <morrita@google.com>

Unreviewd, added skip list entries.

This is follow up for r65395. QT port ignores tests under
editing/pasteboard.

  • platform/qt/Skipped:
01:14 Changeset [65397] by morrita@google.com

2010-08-16 MORITA Hajime <morrita@google.com>

Unreviewd, added skip list entries.

This is follow up for r65395. GTK port ignores tests under
editing/pasteboard.

  • platform/gtk/Skipped:
01:04 Changeset [65396] by abarth@webkit.org

2010-08-16 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

HTML5 fragment parsing doesn't load iframes
https://bugs.webkit.org/show_bug.cgi?id=44038

Test that iframes created in detached documents actually get loaded
when they're adopted into attached documents (or, rather, when they're
inserted into the DOM).

  • fast/frames/adopt-from-created-document-expected.txt: Added.
  • fast/frames/adopt-from-created-document.html: Added.

2010-08-16 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

HTML5 fragment parsing doesn't load iframes
https://bugs.webkit.org/show_bug.cgi?id=44038

Previously, this code assumed that every source iframe was actually
attached to a render tree. It tried to "keep the iframe alive" as it
moved documents. However, if the iframe wasn't attached to begin with,
it was never "alive," so trying to keep a dead iframe alive lead to a
... zombie iframe.

Test: fast/frames/adopt-from-created-document.html

  • dom/Document.cpp: (WebCore::Document::adoptNode):
00:30 Changeset [65395] by morrita@google.com

2010-08-13 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

https://bugs.webkit.org/show_bug.cgi?id=43778
Dropping should fire textInput event.

  • editing/pasteboard/drop-text-events-expected.txt: Added.
  • editing/pasteboard/drop-text-events-sideeffect-expected.txt: Added.
  • editing/pasteboard/drop-text-events-sideeffect.html: Added.
  • editing/pasteboard/drop-text-events.html: Added.
  • editing/pasteboard/script-tests/drop-text-events-sideeffect.js: Added.
  • editing/pasteboard/script-tests/drop-text-events.js: Added.

2010-08-13 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

https://bugs.webkit.org/show_bug.cgi?id=43778
Dropping should fire textInput event

This change:

  • added TextEvent::m_isDrop to distinguish drop-initiated events.
  • added to dispatch TextEvent from DragController before making a side effect and cancel the side effect if the event prevents default

Tests: editing/pasteboard/drop-text-events-sideeffect.html

editing/pasteboard/drop-text-events.html

  • dom/TextEvent.cpp: (WebCore::TextEvent::createForDrop): Added. (WebCore::TextEvent::TextEvent):
  • dom/TextEvent.h: (WebCore::TextEvent::isDrop): Added.
  • editing/Editor.cpp: (WebCore::Editor::handleTextEvent): (WebCore::Editor::findEventTargetFrom): Extracted from findEventTargetFromSelection(). (WebCore::Editor::findEventTargetFromSelection):
  • editing/Editor.h:
  • page/DragController.cpp: (WebCore::DragController::dispatchTextInputEventFor): Added. (WebCore::DragController::concludeEditDrag): Added an event dispatch path.
  • page/DragController.h:

08/15/10:

23:38 Changeset [65394] by ariya@webkit.org

2010-08-15 Ariya Hidayat <ariya@sencha.com>

Unreviewed, rolling out r65393.
http://trac.webkit.org/changeset/65393
https://bugs.webkit.org/show_bug.cgi?id=44031

Breaks some canvas tests.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::): (WebCore::GraphicsContextPlatformPrivate::hasShadow): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow):
23:19 Changeset [65393] by ariya@webkit.org

[Qt] Save and restore shadow state in GraphicsContextQt
https://bugs.webkit.org/show_bug.cgi?id=44031

Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-15
Reviewed by Antonio Gomes.

This is needed after r65362.
Use a new class ContextShadowParameter to track and keep the shadow
state. We use this rather than using GraphicsContextState to allow
possible optimizations (right now only to determine the shadow type,
but in future it might cover things like cached scratch image,
persistent shader, etc).

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::ContextShadowParameter::):
(WebCore::ContextShadowParameter::ContextShadowParameter):
(WebCore::ContextShadowParameter::clear):
(WebCore::GraphicsContextPlatformPrivate::hasShadow):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):

22:27 Changeset [65392] by ariya@webkit.org

2010-08-15 Ariya Hidayat <ariya@sencha.com>

Reviewed by Antonio Gomes.

[Qt] Border should not cast shadows
https://bugs.webkit.org/show_bug.cgi?id=44015

Update pixel test reference.

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:

2010-08-15 Ariya Hidayat <ariya@sencha.com>

Reviewed by Antonio Gomes.

[Qt] Border should not cast shadows
https://bugs.webkit.org/show_bug.cgi?id=44015

Shadows should be not casted except for brush fill (which is not what
drawLine and drawRect are supposed to do).

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawRect): Remove shadow painting, (WebCore::GraphicsContext::drawLine): ditto.
20:28 Changeset [65391] by commit-queue@webkit.org

2010-08-15 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Build error on r65378
https://bugs.webkit.org/show_bug.cgi?id=44019

Add GENERATE_JSON macro for HTMLEntityNames.json instead of HTMLEntityNames.gperf

  • cmake/WebKitMacros.cmake:

2010-08-15 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Build error on r65378
https://bugs.webkit.org/show_bug.cgi?id=44019

Change build script for HTMLEntityNames.json instead of HTMLEntityNames.gperf

  • CMakeLists.txt:
18:58 Changeset [65390] by jhoneycutt@apple.com

WebEditorClient::didBeginEditing is never called in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42939

Reviewed by Sam Weinig.

  • WebKitTestRunner/PlatformWebView.h:

Declare focus().

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Focus the PlatformWebView.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::focus):
Stubbed.

  • WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::focus):
Focus the view.

18:57 Changeset [65389] by jhoneycutt@apple.com

run-webkit-tests should not strip editing callbacks when using
WebKitTestRunner on Windows
https://bugs.webkit.org/show_bug.cgi?id=44000

Reviewed by Mark Rowe.

  • Scripts/old-run-webkit-tests:

Leave $stripEditingCallbacks undefined until we look for command-line
arguments. If using WebKit2, set it to 0 if not explicity set on the
command line. Later, set it to isCygwin() to match old behavior if it is
not yet defined.

18:48 Changeset [65388] by abarth@webkit.org

2010-08-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Port Chromium's WebEntities to HTMLEntityTable
https://bugs.webkit.org/show_bug.cgi?id=44036

This code is wrong and needs to be removed. However, at least after
this patch, it will compile.

  • src/WebEntities.cpp: (WebKit::): (WebKit::WebEntities::WebEntities):
  • src/WebEntities.h:
17:12 Changeset [65387] by kevino@webkit.org

[wx] Build fix, add missing header.

17:05 Changeset [65386] by kevino@webkit.org

[wx] Build fix, don't build PluginDataNone.cpp even on GTK as PluginDataWx.cpp compiles.

17:02 Changeset [65385] by kevino@webkit.org

[wx] Build fix, don't build intermediate source in DerivedSources dir.

16:47 Changeset [65384] by kevino@webkit.org

[wx] Build fix, remove define always set to the correct value by wtf/Platform.h.

13:15 Changeset [65383] by joepeck@webkit.org

2010-08-14 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: -attach and detach should work
https://bugs.webkit.org/show_bug.cgi?id=43924

  • WebKit.xcodeproj/project.pbxproj: Added WebInspectorFrontend.{h,mm}.

2010-08-14 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Pavel Feldman.

Web Inspector: -attach and detach should work
https://bugs.webkit.org/show_bug.cgi?id=43924

For actions that relate only to the Web Inspector's Frontend
window (actions on the InspectorFrontendClient) the new Obj-C
wrapper class WebInspectorFrontend can be used. For now, this
is just attach and detach.

  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::openInspectorFrontend): setup and attach the WebInspectorFrontend to the WebInspector.
  • WebInspector/WebInspector.h:
  • WebInspector/WebInspector.mm: (-dealloc): (-attach:): delegate to the frontend. (-detach:): delegate to the frontend. (-setFrontend:):
  • WebInspector/WebInspectorFrontend.h: Added.
  • WebInspector/WebInspectorFrontend.mm: Added. (-[WebInspectorFrontend initWithFrontendClient:]): (-[WebInspectorFrontend attach]): (-[WebInspectorFrontend detach]):
  • WebInspector/WebInspectorPrivate.h:
12:43 Changeset [65382] by abarth@webkit.org

2010-08-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.write() doesn't flush plain text
https://bugs.webkit.org/show_bug.cgi?id=8961

Add test cases for flushing character tokens.

  • fast/tokenizer/flush-characters-in-document-write-evil-expected.txt: Added.
  • fast/tokenizer/flush-characters-in-document-write-evil.html: Added.
  • fast/tokenizer/flush-characters-in-document-write-expected.txt: Added.
  • fast/tokenizer/flush-characters-in-document-write.html: Added.

2010-08-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.write() doesn't flush plain text
https://bugs.webkit.org/show_bug.cgi?id=8961

Originally I thought we should buffer the character tokens until we've
reached the end of the input stream, but that's not how the spec
handles things (it emits the character tokens one-by-one).

Tests: fast/tokenizer/flush-characters-in-document-write-evil.html

fast/tokenizer/flush-characters-in-document-write.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::emitEndOfFile): (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::haveBufferedCharacterToken):
    • Renamed this function now that it's simplier.
  • html/HTMLTokenizer.h:
08:34 Changeset [65381] by abarth@webkit.org

2010-08-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't try to replace a non-existent document after executing JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=44024

Test what happens if a JavaScript URL returns a value after deleting
the frame it was supposed to operate on.

  • fast/frames/javascript-url-for-deleted-frame-expected.txt: Added.
  • fast/frames/javascript-url-for-deleted-frame.html: Added.

2010-08-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Don't try to replace a non-existent document after executing JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=44024

Synchronous JavaScript execution is evil. Previously, the frame was
deleted after executing the JavaScript URL, so we'd get confused when
we tried to replace its document.

Test: fast/frames/javascript-url-for-deleted-frame.html

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
07:10 Changeset [65380] by commit-queue@webkit.org

2010-08-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Enable localStorage of HTML5 for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=44020

  • ewk/ewk_view.cpp: (_ewk_view_priv_new):
00:24 Changeset [65379] by mitz@apple.com

Revised build fix from r65363 based on suggestion from Darin Adler.

  • UIProcess/API/C/WKArray.h: Include stddef.h.
  • UIProcess/API/C/WKBase.h: Uninclude ctype.h.
  • UIProcess/API/C/WKData.h: Include stddef.h.
  • UIProcess/API/C/WKDictionary.h: Ditto.

08/14/10:

18:29 Changeset [65378] by mrobinson@webkit.org

2010-08-14 Martin Robinson <mrobinson@igalia.com>

[GTK] Some test results are one pixel different between the x86_64 and i386 bots
https://bugs.webkit.org/show_bug.cgi?id=39022

  • platform/gtk/Skipped: Skip MathML tests which show 32-bit/64-bit rounding differences.
17:52 Changeset [65377] by mrobinson@webkit.org

2010-08-14 Martin Robinson <mrobinson@igalia.com>

Reviewed by Kenneth Rohde Christiansen.

[GTK] autogen.sh not executed if build-webkit options change
https://bugs.webkit.org/show_bug.cgi?id=42266

Rerun autogen.sh in situations where the arguments to build-webkit have
changed since the previous build. This will fix some issues on the bots
where the build does not notice changes to default build-webkit arguments.

  • Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
16:34 Changeset [65376] by commit-queue@webkit.org

2010-08-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65374.
http://trac.webkit.org/changeset/65374
https://bugs.webkit.org/show_bug.cgi?id=44018

broke a myriad of svg tests (Requested by kling on #webkit).

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeBoundingRect):
16:29 Changeset [65375] by eric@webkit.org

2010-08-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

XSLTProcessor.transformToFragment should not pass contextElement to html/xml document parsers
https://bugs.webkit.org/show_bug.cgi?id=44017

This fixes two tests which otherwise would fail when the
HTML5 TreeBuilder is enabled for fragment parsing.

This revealed a bug in HTMLTreeBuilder() which I fixed as well.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
  • xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource):
15:44 Changeset [65374] by andreas.kling@nokia.com

2010-08-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Path: Fast approximation of stroke bounding rects
https://bugs.webkit.org/show_bug.cgi?id=44014

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeBoundingRect): Use QPainterPath::controlPointRect() to calculate a slightly larger bounding rect in a fraction of the time.
15:00 Changeset [65373] by abarth@webkit.org

2010-08-14 Adam Barth <abarth@webkit.org>

Propagate name change to Qt.

  • Api/qwebelement.cpp: (QWebElement::appendInside): (QWebElement::prependInside): (QWebElement::prependOutside): (QWebElement::appendOutside): (QWebElement::encloseContentsWith): (QWebElement::encloseWith):
14:38 Changeset [65372] by eric@webkit.org

2010-08-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move innerHTML off of Range::createContextualFragment
https://bugs.webkit.org/show_bug.cgi?id=44011

This makes all the editing tests stop failing under the
HTML5 TreeBuilder.

In a previous patch Adam disabled some of the (wrong) code
in createContextualFragment when in html5 treebuilder mode.
The problem is that the editing code depends on
createContextualFragment (as well as the Range DOM API),
so we have to leave this code in until we can figure
out if it's right or wrong behavior for the Range API.

This patch moves innerHTML/outerHTML off of using
createContextualFragment and instead calls
DocumentFragment::parseHTML directly (which is much simpler).

I expect Adam and I will end up turning on the HTML5 TreeBuilder
in the next couple days, and most of the if branches I added
here will go away for good.

I renamed Element::createContextualFragment to
deprecatedCreateContextualFragment, to indicate that it's a
dead API. The editing code should move off of it and consider
using DocumentFragment::parseHTML instead.

  • dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment):
  • dom/Element.h:
  • dom/Range.cpp: (WebCore::Range::createContextualFragment):
  • editing/markup.cpp: (WebCore::createFragmentFromMarkup):
  • html/HTMLElement.cpp: (WebCore::useLegacyTreeBuilder): (WebCore::HTMLElement::deprecatedCreateContextualFragment): (WebCore::HTMLElement::setInnerHTML): (WebCore::HTMLElement::setOuterHTML):
  • html/HTMLElement.h:
12:24 Changeset [65371] by commit-queue@webkit.org

2010-08-14 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Fix compilation with QT_NO_LINEEDIT
https://bugs.webkit.org/show_bug.cgi?id=38324

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue):
10:53 Changeset [65370] by rwlbuis@webkit.org

2010-08-14 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

IE SVG empty path test fails
https://bugs.webkit.org/show_bug.cgi?id=44008

Change createLine to allow creating zero-length lines. This makes it possible
to have markers and line-caps applied to zero-length lines.

Test: svg/custom/marker-empty-path.svg

  • platform/graphics/Path.cpp: (WebCore::Path::createLine):
09:34 Changeset [65369] by commit-queue@webkit.org

2010-08-14 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[CMake] Add preprocessor detection for generator scripts
https://bugs.webkit.org/show_bug.cgi?id=43984

  • cmake/OptionsCommon.cmake:

2010-08-14 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[CMake] Add preprocessor detection for generator scripts
https://bugs.webkit.org/show_bug.cgi?id=43984

  • CMakeLists.txt:
08:53 Changeset [65368] by commit-queue@webkit.org

2010-08-14 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[CMake] Move SQL files into a IF (ENABLE_DATABASE) section
https://bugs.webkit.org/show_bug.cgi?id=43979

  • CMakeLists.txt:
08:36 Changeset [65367] by commit-queue@webkit.org

2010-08-14 Matthew Delaney <mdelaney@apple.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas is not reset when setting canvas.width
https://bugs.webkit.org/show_bug.cgi?id=43341

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset): Moved the call to hasCreatedImageBuffer up *before* the call to setSurface since setSurface sets hasCreatedImageBuffer to false every time.
08:17 Changeset [65366] by commit-queue@webkit.org

2010-08-14 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[CMake] Set target properties only if available
https://bugs.webkit.org/show_bug.cgi?id=43978

  • CMakeLists.txt:
  • jsc/CMakeLists.txt:
  • wtf/CMakeLists.txt:

2010-08-14 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[CMake] Set target properties only if available
https://bugs.webkit.org/show_bug.cgi?id=43978

  • CMakeLists.txt:

2010-08-14 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[CMake] Set target properties only if available
https://bugs.webkit.org/show_bug.cgi?id=43978

  • CMakeLists.txt:
08:00 Changeset [65365] by commit-queue@webkit.org

2010-08-14 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Rohde Christiansen.

Update .gitignore file for more files
https://bugs.webkit.org/show_bug.cgi?id=43991

  • .gitignore:
07:11 Changeset [65364] by krit@webkit.org

2010-08-14 Dirk Schulze <krit@webkit.org>

Unreviewed sort of Xcode project file.

  • WebCore.xcodeproj/project.pbxproj:
06:41 MathML 3 testsuite results edited by sausset@gmail.com
(diff)
06:06 MathML 3 testsuite results edited by sausset@gmail.com
(diff)
05:53 MathML 3 testsuite results edited by sausset@gmail.com
(diff)
05:51 MathML 3 testsuite results edited by sausset@gmail.com
(diff)
05:45 MathML 3 testsuite results edited by sausset@gmail.com
(diff)
05:39 MathML 3 testsuite results edited by sausset@gmail.com
(diff)
02:11 MathML 3 testsuite results edited by sausset@gmail.com
(diff)
01:39 Changeset [65363] by mitz@apple.com

Clean build of WebKitTestRunner fails with “'size_t' has not been declared” in WKArray.h
https://bugs.webkit.org/show_bug.cgi?id=44005

Reviewed by Anders Carlsson in Sweden.

  • UIProcess/API/C/WKBase.h: Include ctype.h.
01:22 Changeset [65362] by ariya@webkit.org

2010-08-14 Ariya Hidayat <ariya@sencha.com>

Reviewed by Simon Hausmann and Kenneth Rohde Christiansen.

[Qt] Refactor shadow state handling in GraphicsContextQt
https://bugs.webkit.org/show_bug.cgi?id=44006

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::): Added shadow states as member variables. (WebCore::GraphicsContextPlatformPrivate::hasShadow): Convenient function to check whether there is shadow or not. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::drawRect): Use shadow states instead of calling getShadow. (WebCore::GraphicsContext::drawLine): ditto. (WebCore::GraphicsContext::strokeArc): ditto. (WebCore::GraphicsContext::drawConvexPolygon): ditto. (WebCore::GraphicsContext::fillPath): ditto. (WebCore::GraphicsContext::strokePath): ditto. (WebCore::GraphicsContext::fillRect): Removes the use of helper function drawBorderlessRectShadow as the code already becomes a lot simpler. (WebCore::GraphicsContext::fillRoundedRect): Removes the use of helper

function drawFilledShadowPath as the code already becomes a lot simpler.

(WebCore::GraphicsContext::setPlatformShadow): Store shadow states
and find out the shadow type (complexity) for future use.
(WebCore::GraphicsContext::clearPlatformShadow): Reset shadow states.

01:04 Changeset [65361] by ariya@webkit.org

2010-08-14 Ariya Hidayat <ariya@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Outdated pixel test reference for fast/box-shadow/transform-fringing.html
https://bugs.webkit.org/show_bug.cgi?id=44007

  • platform/qt/fast/box-shadow/transform-fringing-expected.checksum:
  • platform/qt/fast/box-shadow/transform-fringing-expected.png:
00:17 Changeset [65360] by eric@webkit.org

2010-08-14 Eric Seidel <eric@webkit.org>

Unreviewed. Another fix to support python 2.3.

Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949

  • Scripts/webkitpy/thirdparty/simplejson/decoder.py:
    • It looks like our simplejson is version 1.7.3 which should be python 2.3 compatible. But someone modified our copy slightly from the original source. I've removed the relative import in hopes this fixes the problem.

08/13/10:

23:44 Changeset [65359] by eric@webkit.org

2010-08-13 Eric Seidel <eric@webkit.org>

Unreviewed. Build fix only.

Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949

  • Scripts/create-html-entity-table:
    • Hack sys.path to avoid executing 2.5 dependent python on systems (like chromium-win and Tiger) which do not have 2.5 python.
23:26 Changeset [65358] by abarth@webkit.org

2010-08-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename some concepts in HTML entity search to be more self-documenting
https://bugs.webkit.org/show_bug.cgi?id=44004

Start and end are now first and last, which lets us use some better
names for the statics in HTMLEntityTable.

  • html/HTMLEntityParser.cpp: (WebCore::consumeHTMLEntity):
  • html/HTMLEntitySearch.cpp: (WebCore::HTMLEntitySearch::HTMLEntitySearch): (WebCore::HTMLEntitySearch::findFirst): (WebCore::HTMLEntitySearch::findLast): (WebCore::HTMLEntitySearch::advance):
  • html/HTMLEntitySearch.h: (WebCore::HTMLEntitySearch::isEntityPrefix): (WebCore::HTMLEntitySearch::mostRecentMatch): (WebCore::HTMLEntitySearch::fail):
  • html/HTMLEntityTable.h:

2010-08-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename some concepts in HTML entity search to be more self-documenting
https://bugs.webkit.org/show_bug.cgi?id=44004

Reflect name change in generator script.

  • Scripts/create-html-entity-table:
23:03 Changeset [65357] by abarth@webkit.org

2010-08-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make it easier to run LayoutTests in Firefox
https://bugs.webkit.org/show_bug.cgi?id=44002

Firefox doesn't seem to have innerText. Instead, let's just use the
normal DOM operations.

  • fast/parser/resources/p-in-scope.js:
  • fast/table/incomplete-table-in-fragment-2.html:
  • fast/table/incomplete-table-in-fragment-hang.html:
22:09 Changeset [65356] by kevino@webkit.org

[wx] Build fix, add CString to the list of forwards.

22:05 Changeset [65355] by abarth@webkit.org

2010-08-13 Adam Barth <abarth@webkit.org>

Update test expectations to account for the HTML5 entity parser. There
are two main differences:

1) The value of lang and rang have changed.
2) We now parse FOO&ltBAR as FOO<BAR.

  • fast/parser/entities-in-html-expected.txt:
  • fast/parser/entities-in-xhtml-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
    • This test expectation is wrong. It's on my list to redesign how the XSS auditor works now that we have better parsing tools. Rather than skip the test on all platforms, I'm updating the expectation.
  • platform/mac/fast/text/word-space-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
21:57 Changeset [65354] by abarth@webkit.org

2010-08-13 Adam Barth <abarth@webkit.org>

Fix ASSERT in XML entity parsing. You can't advance the entity search
if you've already discovered that your string is not an entity.

  • html/HTMLEntityParser.cpp: (WebCore::decodeNamedEntity):
20:32 Changeset [65353] by eric@webkit.org

2010-08-13 Eric Seidel <eric@webkit.org>

Unreviewed. Attempt at fixing Chromium build.

Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949

  • WebCore.gyp/WebCore.gyp:
    • I have no clue if this is right or not.
20:28 Changeset [65352] by eric@webkit.org

2010-08-13 Eric Seidel <eric@webkit.org>

Unreviewed. Attempted build fix for Windows.

Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949

  • DerivedSources.cpp:
    • Add HTMLEntityTable.cpp
20:18 Changeset [65351] by eric@webkit.org

2010-08-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949

Test progression for proper entity support.

  • html5lib/runner-expected-html5.txt:
  • html5lib/runner-expected.txt:

2010-08-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949

Implementing the HTML5 entity parsing algorithm require refactoring how
we search for entity names. Instead of using a perfect hash, we now
use a sorted list. As we advance through the input, we walk down a
binary search of the table looking for an entity.

Using this data structure lets us keep track of whether the current
string is a prefix of an existing entity, which we need for the
algorithm. In a future patch, I plan to add some indices to the
table, which should let us narrow down the range of interesting entries
more quickly.

The one nasty piece of the algorithm is if we walk too far down the
input and we need to back up to a previous match. In this patch, we
accomplish this by rewinding the input and consuming a known number of
characters to resync the source.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLEntityParser.cpp: (WebCore::consumeHTMLEntity):
  • html/HTMLEntitySearch.cpp: Added. (WebCore::): (WebCore::HTMLEntitySearch::HTMLEntitySearch): (WebCore::HTMLEntitySearch::compare): (WebCore::HTMLEntitySearch::findStart): (WebCore::HTMLEntitySearch::findEnd): (WebCore::HTMLEntitySearch::advance):
  • html/HTMLEntitySearch.h: Added. (WebCore::HTMLEntitySearch::isEntityPrefix): (WebCore::HTMLEntitySearch::currentValue): (WebCore::HTMLEntitySearch::lastMatch): (WebCore::HTMLEntitySearch::): (WebCore::HTMLEntitySearch::fail):
  • html/HTMLEntityTable.h: Added. (WebCore::HTMLEntityTableEntry::lastCharacter):

2010-08-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for MathML entities
https://bugs.webkit.org/show_bug.cgi?id=43949

A script for generating the C++ state data structure describing all the
entities from a JSON description.

  • Scripts/create-html-entity-table: Added.
20:09 Changeset [65350] by tonyg@chromium.org

2010-08-13 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Refactor HTMLScriptRunner to allow deferred scripts to share code
https://bugs.webkit.org/show_bug.cgi?id=43736

No new tests because no functional change

  • html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): Make const to enforce the idea that it doesn't change m_parsingBlockingScript. (WebCore::HTMLScriptRunner::executeParsingBlockingScript): Rename to make it clear this deals with the parsing blocking script and refactor to use executePendingScriptAndDispatchEvent. (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Factored out of executePendingScript, this can be used for executing any external script. (WebCore::HTMLScriptRunner::executeScript): This can be used for executing any inline or external script. ASSERTs moved to the two calling points. (WebCore::HTMLScriptRunner::executeParsingBlockingScripts): Moved method. (WebCore::HTMLScriptRunner::requestParsingBlockingScript): Factored out requestPendingScript. (WebCore::HTMLScriptRunner::requestPendingScript): Factored out from reqeustParsingBlockingScript. (WebCore::HTMLScriptRunner::runScript):
  • html/HTMLScriptRunner.h:
19:23 Changeset [65349] by barraclough@apple.com

Windows build fix.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/win/SharedBufferWin.cpp:
19:16 Changeset [65348] by commit-queue@webkit.org

2010-08-13 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Form state restore tests fail on GTK build with r65340
https://bugs.webkit.org/show_bug.cgi?id=43998

Move form submits (and rest of test) to run during onload, to make sure
that the submit generates a history entry.

  • fast/forms/state-restore-to-non-autocomplete-form.html:
  • fast/forms/state-restore-to-non-edited-controls.html:
18:53 Changeset [65347] by barraclough@apple.com

Windows build fix

18:37 Changeset [65346] by barraclough@apple.com

Windows build fix

18:34 Changeset [65345] by barraclough@apple.com

Windows build fix

18:28 Changeset [65344] by barraclough@apple.com

Switch String::/UString::ascii() to return a CString.

Rubber stamped by Sam Weinig.

JavaScriptCore:

(JSC::CodeBlock::dump):

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::dump):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::dumpCaller):

  • jsc.cpp:

(runWithScripts):
(runInteractive):

  • runtime/Identifier.h:

(JSC::Identifier::ascii):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::print):

  • runtime/UString.cpp:

(JSC::UString::ascii):
(JSC::UString::latin1):

  • runtime/UString.h:
  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::asciiOLD):

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.cpp:

(WTF::String::ascii):
(WTF::String::latin1):

  • wtf/text/WTFString.h:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/c/c_class.cpp:

(JSC::Bindings::CClass::methodsNamed):
(JSC::Bindings::CClass::fieldNamed):

  • bridge/jni/jsc/JNIBridgeJSC.cpp:

(JavaField::valueFromInstance):
(JavaField::setValueToInstance):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::methodsNamed):
(JSC::Bindings::ObjcClass::fieldNamed):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):

  • loader/icon/IconRecord.cpp:
  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteStatement.cpp:
  • storage/SQLStatement.cpp:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodsNamed):
(WebKit::ProxyInstance::fieldNamed):

17:34 Changeset [65343] by dpranke@chromium.org

2010-08-13 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
check for exceptions on all threads, not just the first thread.

This change also changes the logging behavior for wedged threads
to only dump the stacks of threads that are actually wedged.

Refactor the thread classes in the dump_render_tree_thread module
to make the contract between TestRunner and TestShellThread clearer.

Added a bunch of unit tests.
https://bugs.webkit.org/show_bug.cgi?id=38561

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
16:59 Changeset [65342] by weinig@apple.com

Fix build.

  • WebKit2.xcodeproj/project.pbxproj: Make WKDictionary.h public.
16:44 Changeset [65341] by weinig@apple.com

Pass values map to willSubmitForm in WebKit2 API
Part of <rdar://problem/8255932>
https://bugs.webkit.org/show_bug.cgi?id=43995

Reviewed by Brady Eidson.

  • Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::):
Add overload for std::pair.

  • Shared/ImmutableDictionary.h:

(WebKit::ImmutableDictionary::adopt):
Fix function signature by removing size parameter.

  • UIProcess/API/C/WKPage.h:

Add dictionary parameter to callback.

  • UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):
Create an ImmutableDictionary from the vector of string pairs.

  • UIProcess/WebFormClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::willSubmitForm):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
Plumb through the values vector.

16:35 Changeset [65340] by commit-queue@webkit.org

2010-08-13 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Session history should skip over JS redirects
https://bugs.webkit.org/show_bug.cgi?id=42861

Lock the back/forward list for location changes and form submits that
happen before the onload event fires that are not the result of user
gestures.

http/tests/history tests now pass, their expectations were updated
accordingly. Other tests needed a setTimeout wrapper around location
changes and form submits during onload, otherwise they would not
generate history entries as expected anymore.

  • fast/css/target-fragment-match.html:
  • fast/dom/location-hash.html:
  • fast/dom/Geolocation/resources/cached-page-1.html:
  • fast/dom/Window/timer-resume-on-navigation-back.html:
  • fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt:
  • fast/events/pageshow-pagehide-on-back-cached-with-frames.html:
  • fast/forms/button-state-restore.html:
  • fast/forms/state-restore-to-non-autocomplete-form.html:
  • fast/forms/state-restore-to-non-edited-controls.html:
  • fast/frames/resources/cached-page-1.html:
  • fast/frames/resources/cached-page-2.html:
  • fast/harness/resources/cached-page-1.html:
  • fast/harness/resources/cached-page-with-data-urls.html:
  • fast/history/gesture-before-onload-expected.txt: Added.
  • fast/history/gesture-before-onload.html: Added.
  • fast/history/history-length.html:
  • fast/history/resources/gesture-before-onload-target.html: Added.
  • fast/history/saves-state-after-fragment-nav.html:
  • fast/loader/input-element-page-cache-crash.html:
  • fast/loader/stateobjects/document-destroyed-navigate-back.html:
  • fast/loader/stateobjects/pushstate-clears-forward-history.html:
  • fast/loader/subframe-navigate-during-main-frame-load.html:
  • http/tests/history/back-to-post.php:
  • http/tests/history/redirect-js-document-location-before-load-expected.txt:
  • http/tests/history/redirect-js-form-submit-before-load-expected.txt:
  • http/tests/history/redirect-js-location-assign-before-load-expected.txt:
  • http/tests/history/redirect-js-location-before-load-expected.txt:
  • http/tests/history/redirect-js-location-href-before-load-expected.txt:
  • http/tests/loading/307-after-303-after-post-expected.txt:
  • http/tests/loading/redirect-methods-expected.txt:
  • http/tests/navigation/resources/back-send-referrer-helper.php:
  • http/tests/navigation/resources/document-location.js: (start):
  • http/tests/navigation/resources/submit-to-fragment.pl:
  • security/autocomplete-cleared-on-back.html:
  • storage/hash-change-with-xhr.js: (updateDatabase): (invokeBack): (runTest): (runTestsInner):

2010-08-13 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Session history should skip over JS redirects
https://bugs.webkit.org/show_bug.cgi?id=42861

Lock the back/forward list for location changes and form submits that
happen before the onload event fires that are not the result of user
gestures.

Made form submission (at the ScheduledFormSubmission level) more similar
to ScheduledURLNavigation by having it call clientRedirected too, fixing
a long-standing FIXME.

Test: fast/history/gesture-before-onload-location-href.html,
fast/history/gesture-before-onload-form-submit.html and updated
expectations for http/tests/history tests that used to fail.

  • loader/FormSubmission.cpp: (WebCore::FormSubmission::requestURL): (WebCore::FormSubmission::populateFrameLoadRequest):
  • loader/FormSubmission.h:
  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::ScheduledFormSubmission::didStartTimer): (WebCore::ScheduledFormSubmission::didStopTimer): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission):
  • loader/RedirectScheduler.h:
14:33 Changeset [65339] by weinig@apple.com

Add dictionary API type
https://bugs.webkit.org/show_bug.cgi?id=43990

Reviewed by Brady Eidson.

Add an immutable dictionary type (WKStringRef -> WKTypeRef).

  • Shared/APIObject.h:

(WebKit::APIObject::):
Add new APIType.

  • Shared/ImmutableDictionary.cpp: Added.

(WebKit::ImmutableDictionary::ImmutableDictionary):
(WebKit::ImmutableDictionary::~ImmutableDictionary):

  • Shared/ImmutableDictionary.h: Added.

(WebKit::ImmutableDictionary::create):
(WebKit::ImmutableDictionary::adopt):
(WebKit::ImmutableDictionary::get):
(WebKit::ImmutableDictionary::size):
(WebKit::ImmutableDictionary::):
(WebKit::ImmutableDictionary::type):
Add basic implementation

  • UIProcess/API/C/WKAPICast.h:

(WebKit::):
Add new mappings.

  • UIProcess/API/C/WKBase.h:

Add new opaque type.

  • UIProcess/API/C/WKDictionary.cpp: Added.

(WKDictionaryGetTypeID):
(WKDictionaryGetItemForKey):
(WKDictionaryGetSize):
(WKDictionaryRetain):
(WKDictionaryRelease):

  • UIProcess/API/C/WKDictionary.h: Added.

Add API wrappings.

  • UIProcess/API/C/WebKit2.h:

Add missing public headers.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

14:03 Changeset [65338] by weinig@apple.com

Add two more unsupported tests to the WebKit2 skipped list.

Rubber-stamped by Beth Dakin and Ban Bernstein.

  • platform/mac-wk2/Skipped:
13:11 Changeset [65337] by weinig@apple.com

Add form submission listener to WebKit2
Part of <rdar://problem/8255932>
https://bugs.webkit.org/show_bug.cgi?id=43947

Reviewed by Jon Honeycutt.

  • Shared/APIObject.h:

Add TypeFormSubmissionListener APIType.

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

Add WillSubmitForm message kind.

  • UIProcess/API/C/WKAPICast.h:

Add new mappings for WKFormSubmissionListenerRef -> WebFormSubmissionListener

  • UIProcess/API/C/WKBase.h:

Add OpaqueWKFormSubmissionListener and rename the other opaque types to match.

  • UIProcess/API/C/WKFormSubmissionListener.cpp: Added.

(WKFormSubmissionListenerGetTypeID):
(WKFormSubmissionListenerContinue):
(WKFormSubmissionListenerRetain):
(WKFormSubmissionListenerRelease):

  • UIProcess/API/C/WKFormSubmissionListener.h: Added.

Add C wrapper for WebFormSubmissionListener.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageFormClient):

  • UIProcess/API/C/WKPage.h:

Add WKPageFormClient with willSubmitForm callback. Additional callbacks will be added as
needed.

  • UIProcess/API/C/WebKit2.h:

Add include for WKFormSubmissionListener.h

  • UIProcess/WebFormClient.cpp: Added.

(WebKit::WebFormClient::WebFormClient):
(WebKit::WebFormClient::initialize):
(WebKit::WebFormClient::willSubmitForm):

  • UIProcess/WebFormClient.h: Added.

Add client for form related delagations.

  • UIProcess/WebFormSubmissionListenerProxy.cpp: Added.

(WebKit::WebFormSubmissionListenerProxy::WebFormSubmissionListenerProxy):
(WebKit::WebFormSubmissionListenerProxy::continueSubmission):

  • UIProcess/WebFormSubmissionListenerProxy.h: Added.

(WebKit::WebFormSubmissionListenerProxy::create):
(WebKit::WebFormSubmissionListenerProxy::type):

  • UIProcess/WebFrameListenerProxy.cpp: Copied from UIProcess/WebFramePolicyListenerProxy.cpp.

Add new type of listener for form submissions. It inherits from the new base class
for listeners, WebFrameListenerProxy.

(WebKit::WebFrameListenerProxy::WebFrameListenerProxy):
(WebKit::WebFrameListenerProxy::~WebFrameListenerProxy):
(WebKit::WebFrameListenerProxy::invalidate):
(WebKit::WebFrameListenerProxy::receivedPolicyDecision):

  • UIProcess/WebFrameListenerProxy.h: Copied from UIProcess/WebFramePolicyListenerProxy.h.

Move logic that would have to be shared between WebFramePolicyListenerProxy and
WebFormSubmissionListenerProxy into shared base class.

  • UIProcess/WebFramePolicyListenerProxy.cpp:

(WebKit::WebFramePolicyListenerProxy::WebFramePolicyListenerProxy):

  • UIProcess/WebFramePolicyListenerProxy.h:

(WebKit::WebFramePolicyListenerProxy::create):
(WebKit::WebFramePolicyListenerProxy::type):
Move to inheriting from WebFrameListenerProxy.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::disconnect):
(WebKit::WebFrameProxy::receivedPolicyDecision):
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
(WebKit::WebFrameProxy::setUpFormSubmissionListenerProxy):

  • UIProcess/WebFrameProxy.h:

Change listener functions to act on WebFrameListenerProxys and add setUpFormSubmissionListenerProxy.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeFormClient):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::willSubmitForm):

  • UIProcess/WebPageProxy.h:

Plumb through willSubmitForm call as we do with the other listeners.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
Ditto.

  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • win/WebKit2.vcproj: Add new files.
  • win/WebKit2Generated.make: Ditto.
12:09 Changeset [65336] by leandro@webkit.org

2010-08-13 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.
These changes were supposed to be landed on r65319, but due to some
svn-apply/commit-queue bug it wasn't fully applied. A bug was filed
by Patrick Gansterer (author of the changes in this commit):
https://bugs.webkit.org/show_bug.cgi?id=43981

  • CMakeLists.txt: Update calls to GENERATE_GPERF and GENERATE_GRAMMAR macros.
11:49 Changeset [65335] by cfleizach@apple.com

AX: isNativeCheckbox does not work as advertised
https://bugs.webkit.org/show_bug.cgi?id=43872

Re-adding this patch after it was erroneously rolled out.

WebCore:

Test: platform/mac/accessibility/native-vs-nonnative-checkboxes.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isInputImage):
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):

  • dom/InputElement.h:
  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::isCheckbox):

LayoutTests:

  • platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Added.
  • platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Added.
11:05 Changeset [65334] by commit-queue@webkit.org

2010-08-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65331.
http://trac.webkit.org/changeset/65331
https://bugs.webkit.org/show_bug.cgi?id=43980

This patch breaks some shadow tests on Qt Linux release
(Requested by ariya on #webkit).

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow):
10:39 Changeset [65333] by kinuko@chromium.org

2010-08-13 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Update run-bindings-tests expectations
https://bugs.webkit.org/show_bug.cgi?id=43944

The results have become out of sync after changeset 64552 and 65269.

Test: WebKitTools/Scripts/run-bindings-tests

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type):
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws): (webkit_dom_test_obj_serialized_value): (webkit_dom_test_obj_idb_key): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad): (webkit_dom_test_obj_with_script_state_obj): (webkit_dom_test_obj_with_script_state_obj_exception): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_xml_obj_attr): (webkit_dom_test_obj_set_xml_obj_attr): (webkit_dom_test_obj_get_reflected_string_attr): (webkit_dom_test_obj_set_reflected_string_attr): (webkit_dom_test_obj_get_reflected_url_attr): (webkit_dom_test_obj_set_reflected_url_attr): (webkit_dom_test_obj_get_reflected_non_empty_url_attr): (webkit_dom_test_obj_set_reflected_non_empty_url_attr): (webkit_dom_test_obj_get_reflected_custom_url_attr): (webkit_dom_test_obj_set_reflected_custom_url_attr): (webkit_dom_test_obj_get_reflected_custom_non_empty_url_attr): (webkit_dom_test_obj_set_reflected_custom_non_empty_url_attr): (webkit_dom_test_obj_get_string_attr_with_getter_exception): (webkit_dom_test_obj_set_string_attr_with_getter_exception): (webkit_dom_test_obj_get_string_attr_with_setter_exception): (webkit_dom_test_obj_set_string_attr_with_setter_exception): (webkit_dom_test_obj_get_script_string_attr): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
10:35 Changeset [65332] by leandro@webkit.org

2010-08-13 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

  • cmake/FindGthread.cmake: Fix warnings about obsolete PKGCONFIG macro.
  • cmake/WebKitGenerators.cmake: FLEX_EXECUTABLE was defined already by the root CMakeLists.txt file, so remove relevant lines that depends on FIND_PACKAGE_HANDLE_STANDARD_ARGS macro, which isn't available anymore.
10:24 Changeset [65331] by ariya@webkit.org

2010-08-13 Ariya Hidayat <ariya@sencha.com>

Reviewed by Simon Hausmann.

[Qt] Canvas and CSS: blur option in shadow not working
https://bugs.webkit.org/show_bug.cgi?id=34479

Patch 1: Refactor shadow states handling.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::): Added shadow states as member variables. (WebCore::GraphicsContextPlatformPrivate::hasShadow): Convenient function to check whether there is shadow or not. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::drawRect): Use shadow states instead of calling getShadow. (WebCore::GraphicsContext::drawLine): ditto. (WebCore::GraphicsContext::strokeArc): ditto. (WebCore::GraphicsContext::drawConvexPolygon): ditto. (WebCore::GraphicsContext::fillPath): ditto. (WebCore::GraphicsContext::strokePath): ditto. (WebCore::GraphicsContext::fillRect): Removes the use of helper function drawBorderlessRectShadow as the code already becomes a lot simpler. (WebCore::GraphicsContext::fillRoundedRect): Removes the use of helper function drawFilledShadowPath as the code already becomes a lot simpler. (WebCore::GraphicsContext::setPlatformShadow): Store shadow states and find out the shadow type (complexity) for future use. (WebCore::GraphicsContext::clearPlatformShadow): Reset shadow states.
10:12 Changeset [65330] by zmo@google.com

2010-08-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Regression in linking of programs
https://bugs.webkit.org/show_bug.cgi?id=43820

Shaders and programs shouldn't be deleted until their attachments are removed, therefore, we need to track the attach/detach/useProgram.

  • html/canvas/WebGLObject.cpp: Track the object attachment count and whether it should really be deleted. (WebCore::WebGLObject::WebGLObject): (WebCore::WebGLObject::setObject): (WebCore::WebGLObject::deleteObject):
  • html/canvas/WebGLObject.h: Track the object attachment count and whether it should really be deleted. (WebCore::WebGLObject::onAttached): (WebCore::WebGLObject::onDetached): (WebCore::WebGLObject::getAttachmentCount):
  • html/canvas/WebGLProgram.cpp: Track the attached shaders. (WebCore::WebGLProgram::WebGLProgram): (WebCore::WebGLProgram::deleteObjectImpl): (WebCore::WebGLProgram::getAttachedShader): (WebCore::WebGLProgram::attachShader): (WebCore::WebGLProgram::detachShader):
  • html/canvas/WebGLProgram.h: Track the attached shaders.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::attachShader): Track the attachment of a shader to a program. (WebCore::WebGLRenderingContext::deleteProgram): Detach shaders. (WebCore::WebGLRenderingContext::detachShader): Track the attachment of a shader to a program. (WebCore::WebGLRenderingContext::validateWebGLObject): Also check if object == 0. (WebCore::WebGLRenderingContext::linkProgram): Using the cached attached shaders instead of query from driver. (WebCore::WebGLRenderingContext::useProgram): Track the attachment of a program to the current rendering pipeline.

2010-08-11 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Regression in linking of programs
https://bugs.webkit.org/show_bug.cgi?id=43820

  • fast/canvas/webgl/program-test-expected.txt: Fix the tests so a second shader of the same type attaching to a program will generate error; also, add tests for deleteShader/deleteProgram behavior.
  • fast/canvas/webgl/program-test.html: Ditto.
10:02 Changeset [65329] by steveblock@google.com

2010-08-13 Steve Block <steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Geolocation activity started after frame has been disconnected can cause crash
https://bugs.webkit.org/show_bug.cgi?id=39879

New requests started after the Frame has been disconnected are ignored. We do
not invoke the error callback as this would allow buggy or malicious pages to
hose the CPU. Such a page could hold a reference to a Geolocation object from
a since closed Page and register new requests from the error callback to
create an infinite loop.

Tests: fast/dom/Geolocation/disconnected-frame-already.html

  • page/Geolocation.cpp:

2010-08-13 Steve Block <steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Geolocation activity started after frame has been disconnected can cause crash
https://bugs.webkit.org/show_bug.cgi?id=39879

Added new tests to GTK skipped list.

  • fast/dom/Geolocation/disconnected-frame-already.html: Added.
  • fast/dom/Geolocation/disconnected-frame-already-expected.txt: Added.
  • fast/dom/Geolocation/script-tests/disconnected-frame-already.js: Added.
  • fast/dom/Geolocation/resources/disconnected-frame-already-inner1.html: Added.
  • fast/dom/Geolocation/resources/disconnected-frame-already-inner2.html: Added.
  • platform/gtk/Skipped:
09:51 Changeset [65328] by alex@webkit.org

2010-08-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

We have to add the ACLOCAL_FLAGS in the env to the autogen.sh
ACLOCAL_FLAGS variable in order to honor the value already
defined, jhbuild uses it to pass parameters.

  • autogen.sh:
09:49 Changeset [65327] by commit-queue@webkit.org

2010-08-13 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Support for multiple speech enabled elements in same page.
https://bugs.webkit.org/show_bug.cgi?id=43922

  • page/SpeechInput.cpp: Generates request ids as necessary when each speech enabled input element gets created/destroyed and multiplexes the listener callbacks to the appropriate input element based on the request id. (WebCore::SpeechInput::SpeechInput): (WebCore::SpeechInput::~SpeechInput): (WebCore::SpeechInput::registerListener): (WebCore::SpeechInput::unregisterListener): (WebCore::SpeechInput::didCompleteRecording): (WebCore::SpeechInput::didCompleteRecognition): (WebCore::SpeechInput::setRecognitionResult): (WebCore::SpeechInput::startRecognition): (WebCore::SpeechInput::stopRecording): (WebCore::SpeechInput::cancelRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h: Now requires a one time set for the WebCore::SpeechInputListener and takes in a 'requestId' for all calls.
  • page/SpeechInputListener.h: Now returns the above mentioned requestId in all the listener callbacks for identifying which input element the event goes to.
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::SpeechInputClientMock): (WebCore::SpeechInputClientMock::setListener): (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::stopRecording): (WebCore::SpeechInputClientMock::cancelRecognition): (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::~InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::speechInput): (WebCore::InputFieldSpeechButtonElement::didCompleteRecording): (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
  • rendering/TextControlInnerElements.h:

2010-08-13 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Support for multiple speech enabled elements in same page.
https://bugs.webkit.org/show_bug.cgi?id=43922

  • public/WebSpeechInputController.h: Bubbles up the requestId given by webcore to the embedder. (WebKit::WebSpeechInputController::startRecognition): (WebKit::WebSpeechInputController::cancelRecognition): (WebKit::WebSpeechInputController::stopRecording):
  • public/WebSpeechInputListener.h: Passes down the requestId given by embedder to webcore. (WebKit::WebSpeechInputListener::didCompleteRecording): (WebKit::WebSpeechInputListener::setRecognitionResult): (WebKit::WebSpeechInputListener::didCompleteRecognition):
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::setListener): (WebKit::SpeechInputClientImpl::startRecognition): (WebKit::SpeechInputClientImpl::stopRecording): (WebKit::SpeechInputClientImpl::cancelRecognition): (WebKit::SpeechInputClientImpl::didCompleteRecording): (WebKit::SpeechInputClientImpl::didCompleteRecognition): (WebKit::SpeechInputClientImpl::setRecognitionResult):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl): (WebKit::WebSpeechInputControllerMockImpl::~WebSpeechInputControllerMockImpl): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecording): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecognition): (WebKit::WebSpeechInputControllerMockImpl::setRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition): (WebKit::WebSpeechInputControllerMockImpl::cancelRecognition): (WebKit::WebSpeechInputControllerMockImpl::stopRecording):
  • src/WebSpeechInputControllerMockImpl.h:
09:27 Changeset [65326] by ariya@webkit.org

2010-08-13 Ariya Hidayat <ariya@sencha.com>

Rubber-stamped by Simon Hausmann.

[Qt] Outdated pixel test reference for basic-shadows.html
https://bugs.webkit.org/show_bug.cgi?id=43952

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
09:22 Changeset [65325] by steveblock@google.com

2010-08-13 Steve Block <steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Need a LayoutTest to check that pages using Geolocation are not put in the page cache
https://bugs.webkit.org/show_bug.cgi?id=43957

  • fast/dom/Geolocation/no-page-cache-expected.txt: Added.
  • fast/dom/Geolocation/no-page-cache.html: Added.
  • fast/dom/Geolocation/resources/cached-page-1.html: Added.
  • fast/dom/Geolocation/resources/cached-page-2.html: Added.
  • fast/dom/Geolocation/script-tests/no-page-cache.js: Added. (reportPageOneOnload):
  • platform/gtk/Skipped: Added new test to GTK skipped list
08:52 Changeset [65324] by eric.carlson@apple.com

2010-08-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by David Kilzer.

HTMLMediaElement::prepareForLoad should cancel current plug-in proxy media player
https://bugs.webkit.org/show_bug.cgi?id=43923

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad): Tell mediaPlayer to cancel the current load if it already exists.
06:58 Changeset [65323] by senorblanco@chromium.org

2010-08-12 Stephen White <senorblanco@chromium.org>

Reviewed by David Levin.

[CHROMIUM] Use the BGRA format for canvas 2D accel upload and readbacks.
https://bugs.webkit.org/show_bug.cgi?id=43804

Use the BGRA format from GraphicsContext3D, if supported. Also keep a
texture around for uploads, rather than re-creating it each time.

Covered by many layout tests (once we're running them).

  • platform/graphics/chromium/GLES2Texture.cpp: (WebCore::convertFormat): Move convertFormat() ahead of texture creation, so we can check for BGRA support. (WebCore::GLES2Texture::create): Use convertFormat() to determine the correct format and types to use; use the returned format also for internalFormat, since GLES2 insists they match.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setGraphicsContext3D): Clear the upload texture when a new context is set. (WebCore::PlatformContextSkia::uploadSoftwareToHardware): Use m_uploadTexture instead of creating a new one each time. (WebCore::PlatformContextSkia::readbackHardwareToSoftware): When the context supports it, use the BGRA format for readbacks instead of swizzling.
  • platform/graphics/skia/PlatformContextSkia.h: Add m_uploadTexture for consecutive uploads.
06:52 MathML Status edited by alex@milowski.com
(diff)
06:48 Changeset [65322] by hausmann@webkit.org

[Qt] Introduce Maemo6 for mobile features
https://bugs.webkit.org/show_bug.cgi?id=43969

Reviewed by Ariya Hidayat.

  • WebKit.pri: Use maemo6 where we also use maemo5.
06:48 Changeset [65321] by hausmann@webkit.org

[Qt] Clean up mobile feature useage
https://bugs.webkit.org/show_bug.cgi?id=43968

Reviewed by Ariya Hidayat.

.:

  • WebKit.pri: Set feature defaults here for some Nokia specific mobile platforms

WebCore:

  • WebCore.pro: Replaced use of Nokia specific platform scopes with concrete

feature names.

06:22 MathML Status edited by alex@milowski.com
(diff)
06:22 Changeset [65320] by pfeldman@chromium.org

2010-08-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename InspectorValue::push and set to
push{Value|Object|Array} and set{...}.
https://bugs.webkit.org/show_bug.cgi?id=43966

  • bindings/js/ScriptProfile.cpp: (WebCore::buildInspectorObjectFor):
  • bindings/js/ScriptValue.cpp: (WebCore::jsToInspectorValue):
  • bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::stackTrace):
  • bindings/v8/ScriptProfile.cpp: (WebCore::buildInspectorObjectFor):
  • bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend):
  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::buildArrayForCookies): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getRuleRanges): (WebCore::InspectorDOMAgent::buildObjectForAttributeStyles): (WebCore::InspectorDOMAgent::buildArrayForCSSRules): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements): (WebCore::InspectorDOMAgent::buildObjectForStyle): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildArrayForDisabledStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::saveBreakpoints):
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
  • inspector/InspectorStorageAgent.cpp: (WebCore::): (WebCore::InspectorStorageAgent::executeSQL):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::didScheduleResourceRequest): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
  • inspector/InspectorValues.cpp: (WebCore::): (WebCore::InspectorValue::asValue): (WebCore::InspectorValue::asObject): (WebCore::InspectorValue::asArray): (WebCore::InspectorObject::asObject): (WebCore::InspectorArray::asArray):
  • inspector/InspectorValues.h: (WebCore::InspectorObject::setBool): (WebCore::InspectorObject::setNumber): (WebCore::InspectorObject::setString): (WebCore::InspectorObject::setValue): (WebCore::InspectorObject::setObject): (WebCore::InspectorObject::setArray): (WebCore::InspectorArray::pushValue): (WebCore::InspectorArray::pushObject): (WebCore::InspectorArray::pushArray):
  • inspector/ScriptBreakpoint.cpp: (WebCore::ScriptBreakpoint::inspectorObjectFromSourceBreakpoints):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createGenericRecord):
06:18 MathML Status edited by alex@milowski.com
(diff)
06:16 Changeset [65319] by commit-queue@webkit.org

2010-08-13 Patrick Gansterer <paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

[CMake] Cleanup generator code.
https://bugs.webkit.org/show_bug.cgi?id=39164

  • cmake/WebKitGenerators.cmake:
  • cmake/WebKitMacros.cmake:
06:03 QtWebKitContrib edited by ademar.reis@openbossa.org
(diff)
06:02 Changeset [65318] by japhet@chromium.org

2010-08-13 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium test_expectations.txt updates + a rebaseline

  • platform/chromium-linux/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
05:54 Changeset [65317] by commit-queue@webkit.org

2010-08-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65204.
http://trac.webkit.org/changeset/65204
https://bugs.webkit.org/show_bug.cgi?id=43965

Caused a lot of test crashes in Chromium (Requested by yutak
on #webkit).

  • platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Removed.
  • platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Removed.

2010-08-13 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r65204.
http://trac.webkit.org/changeset/65204
https://bugs.webkit.org/show_bug.cgi?id=43965

Caused a lot of test crashes in Chromium (Requested by yutak
on #webkit).

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isInputImage): (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
  • dom/InputElement.h:
  • html/HTMLInputElement.h:
05:29 Changeset [65316] by antonm@chromium.org

2010-08-13 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

Reapplying http://trac.webkit.org/changeset/65284 after fixed include.

[v8] Create callbacks for named access of elements from document object on fly.
https://bugs.webkit.org/show_bug.cgi?id=43725

That should speed up access to methods on document as there is no need to
consult with interceptor before invoking the method.

This reapplies http://trac.webkit.org/changeset/60670 reverted with
http://trac.webkit.org/changeset/63845. The main difference is in treatment
of removed named elements: we don't remove an accessor any more, but leave it.
Therefore any accessor should be able to treat the case when there is no
expando property.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::namedItemAdded): (WebCore::ScriptController::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::checkDocumentWrapper): (WebCore::V8DOMWindowShell::updateDocumentWrapperCache): (WebCore::getter): (WebCore::V8DOMWindowShell::namedItemAdded): (WebCore::V8DOMWindowShell::namedItemRemoved):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::instantiateV8Object):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::V8HTMLDocument::WrapInShadowObject): (WebCore::V8HTMLDocument::GetNamedProperty): (WebCore::V8HTMLDocument::allAccessorSetter): (WebCore::toV8):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::removeItemFromMap):
05:11 Changeset [65315] by yurys@chromium.org

2010-08-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: DRT sometimes crashes on debugger tests
https://bugs.webkit.org/show_bug.cgi?id=43964
notifyDone() should be called only when debugger already resumed all active DOM objects,
otherwise we might accidentally call setTimeout in the inspected page and create
a new active DOM object while their set should remain unchanged when script execution
is paused.

  • inspector/debugger-cyclic-ref.html:
  • inspector/debugger-eval-while-paused.html:
  • inspector/debugger-no-nested-pause.html:
  • inspector/debugger-pause-in-eval-script.html:
  • inspector/debugger-pause-on-debugger-statement.html:
  • inspector/debugger-proto-property.html:
05:08 Changeset [65314] by pfeldman@chromium.org

2010-08-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: remove openInInspectorWindow and evaluateAndStringify from InjectedScript.
https://bugs.webkit.org/show_bug.cgi?id=43854

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::openInInspectedWindow):
  • inspector/InspectorController.h:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage.callback): (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
05:01 Changeset [65313] by ukai@chromium.org

2010-08-13 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

flaky websocket/tests/frame-length-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=43902

Add m_shouldDiscardReceivedData flag to indicate it will no longer
receive data from network.

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::didReceiveData): (WebCore::WebSocketChannel::didFail): (WebCore::WebSocketChannel::processBuffer):
  • when frame length overflows, we couldn't process data any more. clear buffer and mark m_shouldDiscardReceivedData true to make sure it doesn't process the same buffer again.
  • websockets/WebSocketChannel.h:
04:50 WinCE edited by paroga@paroga.com
(diff)
04:12 QtWebKitWeeklyBuilds edited by hausmann@webkit.org
(diff)
04:12 MathML edited by alex@milowski.com
(diff)
04:09 MathML Status edited by alex@milowski.com
(diff)
03:42 MathML Status edited by alex@milowski.com
(diff)
03:28 MathML Status edited by alex@milowski.com
(diff)
03:26 MathML Status edited by alex@milowski.com
(diff)
03:21 MathML Status edited by alex@milowski.com
(diff)
03:15 Changeset [65312] by krit@webkit.org

2010-08-13 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Use SVGPathByteStream to animate SVGPath
https://bugs.webkit.org/show_bug.cgi?id=43929

Use SVGPathByteStream to perform animations of Paths. SVGPathBlender blends
the starting point to the end point according to the current progress value.
Cleanup SVGPathSegList, by removing the unnecessary legacy blending code.

No new tests because no functional changes.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAllInOne.cpp:
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGAnimateElement.h:
  • svg/SVGPathBlender.cpp: Added. (WebCore::SVGPathBlender::SVGPathBlender): (WebCore::SVGPathBlender::~SVGPathBlender): (WebCore::SVGPathBlender::blendAnimatedFloat): (WebCore::SVGPathBlender::blendAnimatedFloatPoint): (WebCore::SVGPathBlender::blendMoveToSegment): (WebCore::SVGPathBlender::blendLineToSegment): (WebCore::SVGPathBlender::blendLineToHorizontalSegment): (WebCore::SVGPathBlender::blendLineToVerticalSegment): (WebCore::SVGPathBlender::blendCurveToCubicSegment): (WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment): (WebCore::SVGPathBlender::blendCurveToQuadraticSegment): (WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment): (WebCore::SVGPathBlender::blendArcToSegment): (WebCore::SVGPathBlender::blendAnimatedPath): (WebCore::SVGPathBlender::cleanup):
  • svg/SVGPathBlender.h: Added.
  • svg/SVGPathParserFactory.cpp: (WebCore::globalSVGPathBlender): (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
  • svg/SVGPathSegList.h: (WebCore::SVGPathSegList::create):
  • svg/SVGPointList.cpp: (WebCore::adjustAnimatedValue):
03:14 Changeset [65311] by loki@webkit.org

Avoid increasing required alignment of target type warning on ARM
https://bugs.webkit.org/show_bug.cgi?id=38045

Reviewed by Gavin Barraclough.

The reinterpret_cast<Type1*>([pointer to Type2]) expressions - where
sizeof(Type1) > sizeof(Type2) - cause the following warning on ARM:
increases required alignment of target type warnings.
Casting the type of [pointer to Type2] object to void* bypasses the
warning.

(JSC::ARMAssembler::executableCopy):

(JSC::AssemblerBuffer::putShortUnchecked):
(JSC::AssemblerBuffer::putIntUnchecked):
(JSC::AssemblerBuffer::putInt64Unchecked):

(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):

(jsRegExpCompile):

(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):

(WTF::PageHeapAllocator::New):
(WTF::TCMalloc_Central_FreeList::Populate):

  • wtf/MD5.cpp:

(WTF::reverseBytes):
(WTF::MD5::addBytes):
(WTF::MD5::checksum):

(isPointerTypeAlignmentOkay):
(reinterpret_cast_ptr):

(WTF::VectorBuffer::inlineBuffer):

(WTF::String::String):

03:14 MathML edited by alex@milowski.com
(diff)
03:03 Changeset [65310] by zimmermann@webkit.org

2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Window size changes + resources on absolute sized content leads to pixelation
https://bugs.webkit.org/show_bug.cgi?id=43921

Avoid pixelation when using resources on absolute sized objects. Be sure to invalidate the used resources if window size changes.
Otherwhise masks etc. will be scaled up and pixelate. As nice side-effect, this fixes run-webkit-tests --singly svg/W3C-SVG-1.1, which
used to produce wrong results for the gradient tests, as the window size change from 800x600 for 480x360 (svg/W3C-SVG-1.1 specific DRT quirk)
didn't invalidate the resources.

Renamed invalidateClient -> removeClientFromCache and invalidateClients -> removeAllClientsFromCache.
Add a boolean "markForInvalidation" parameter, that controls wheter the clients should be marked for repaint/boundaries invalidation/layout
or wheter we only want to notify the parents that the resource changed, to avoid doing unncessary work in SVGRenderSupport::layoutChildren.

Test: svg/custom/absolute-sized-content-with-resources.xhtml

  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange): Don't do anything for StyleDifferenceEqual.
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):
  • rendering/RenderSVGResource.cpp: (WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
  • rendering/RenderSVGResource.h:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::removeAllClientsFromCache): (WebCore::RenderSVGResourceClipper::removeClientFromCache):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::layout): (WebCore::RenderSVGResourceContainer::idChanged): (WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation): (WebCore::RenderSVGResourceContainer::markClientForInvalidation):
  • rendering/RenderSVGResourceContainer.h: (WebCore::RenderSVGResourceContainer::):
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::removeAllClientsFromCache): (WebCore::RenderSVGResourceFilter::removeClientFromCache): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceFilter.h:
  • rendering/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::removeAllClientsFromCache): (WebCore::RenderSVGResourceGradient::removeClientFromCache): (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/RenderSVGResourceGradient.h:
  • rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::layout): (WebCore::RenderSVGResourceMarker::removeAllClientsFromCache): (WebCore::RenderSVGResourceMarker::removeClientFromCache):
  • rendering/RenderSVGResourceMarker.h:
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::removeAllClientsFromCache): (WebCore::RenderSVGResourceMasker::removeClientFromCache):
  • rendering/RenderSVGResourceMasker.h:
  • rendering/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::removeAllClientsFromCache): (WebCore::RenderSVGResourcePattern::removeClientFromCache): (WebCore::RenderSVGResourcePattern::applyResource):
  • rendering/RenderSVGResourcePattern.h:
  • rendering/RenderSVGResourceSolidColor.h: (WebCore::RenderSVGResourceSolidColor::removeAllClientsFromCache): (WebCore::RenderSVGResourceSolidColor::removeClientFromCache):
  • rendering/SVGRenderSupport.cpp: (WebCore::invalidateResourcesOfChildren): Add new helper funtion recursively invalidating resources of a sub render tree. (WebCore::SVGRenderSupport::layoutChildren): Keep track of all objects that didn't need layout, as we still have to invalidate their resources, if window size changes.
  • rendering/SVGResources.cpp: (WebCore::SVGResources::removeClientFromCache): (WebCore::SVGResources::resourceDestroyed):
  • rendering/SVGResources.h:
  • rendering/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientLayoutChanged):

2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Window size changes + resources on absolute sized content leads to pixelation
https://bugs.webkit.org/show_bug.cgi?id=43921

  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum: Added.
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
  • svg/custom/absolute-sized-content-with-resources.xhtml: Added.
02:55 Changeset [65309] by pfeldman@chromium.org

2010-08-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: brush up test expectations.
https://bugs.webkit.org/show_bug.cgi?id=43959

  • platform/chromium/inspector/console-dir-expected.txt: Added.
  • platform/chromium/inspector/console-format-expected.txt: Added.
  • platform/chromium/inspector/timeline-event-dispatch-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-event-dispatch-expected.txt.
  • platform/chromium/inspector/timeline-mark-timeline-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-mark-timeline-expected.txt.
  • platform/chromium/inspector/timeline-network-resource-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-network-resource-expected.txt.
  • platform/chromium/inspector/timeline-paint-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-paint-expected.txt.
  • platform/chromium/inspector/timeline-parse-html-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/timeline-parse-html-expected.txt.
  • platform/chromium/test_expectations.txt:
01:54 Changeset [65308] by commit-queue@webkit.org

2010-08-13 Kenichi Ishibashi <bashi@google.com>

Reviewed by Shinichiro Hamaji.

Add test_expectations.txt syntax checker to check-webkit-style.
https://bugs.webkit.org/show_bug.cgi?id=43899

Just utilizing layout_tests/layout_package/test_expectations.py for checking
the syntax of test_expectations.txt.
This change also moves tab checking class from style/checkers/text.py to
style/checkers/common.py for sharing code.

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checkers/common.py:
  • Scripts/webkitpy/style/checkers/common_unittest.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py: Added.
  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
  • Scripts/webkitpy/style/checkers/text.py:
  • Scripts/webkitpy/style_references.py:
01:42 Changeset [65307] by pfeldman@chromium.org

2010-08-13 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium DevTools: [CRASH] Autocomplete on arrays causes crashes.
https://bugs.webkit.org/show_bug.cgi?id=43955

  • bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue):
01:38 Changeset [65306] by commit-queue@webkit.org

2010-08-13 Patrick Gansterer <paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

[CMake] Add missing FIND_PACKAGE(Gperf)
https://bugs.webkit.org/show_bug.cgi?id=43937

  • CMakeLists.txt:
00:35 Changeset [65305] by barraclough@apple.com

Unify UString::UTF8String() & String::utf8() methods,
remove UString::cost() & make atArrayIndex a free function.

Reviewed by Sam Weinig

JavaScriptCore:

(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):

  • jsc.cpp:

(functionPrint):
(functionDebug):
(runInteractive):
(fillBufferWithContentsOfFile):

  • pcre/pcre_exec.cpp:

(Histogram::~Histogram):

  • profiler/CallIdentifier.h:

(JSC::CallIdentifier::c_str):

  • profiler/Profile.cpp:

(JSC::Profile::debugPrintDataSampleStyle):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):

  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):

  • runtime/DateConversion.cpp:

(JSC::parseDate):

  • runtime/Identifier.h:

(JSC::Identifier::toStrictUInt32):

  • runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):

  • runtime/JSArray.h:

(JSC::toArrayIndex):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::parseInt):
(JSC::globalFuncJSCPrint):

  • runtime/JSString.h:

(JSC::RopeBuilder::JSString):

  • runtime/UString.cpp:

(JSC::UString::toDouble):
(JSC::putUTF8Triple):
(JSC::UString::utf8):

  • runtime/UString.h:

(JSC::UString::~UString):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):

  • wtf/text/WTFString.cpp:

(WTF::String::utf8):

  • wtf/text/WTFString.h:

(WTF::String::~String):
(WTF::String::swap):
(WTF::String::isNull):
(WTF::String::isEmpty):
(WTF::String::impl):
(WTF::String::length):
(WTF::String::String):
(WTF::String::isHashTableDeletedValue):

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):

  • bridge/NP_jsobject.cpp:

(_NPN_Enumerate):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

  • bridge/jni/JNIBridge.cpp:

(JavaParameter::JavaParameter):
(JavaMethod::JavaMethod):
(JavaMethod::signature):
(JavaMethod::methodID):

  • bridge/jni/JNIBridge.h:

(JSC::Bindings::JavaString::utf8):
(JSC::Bindings::JavaParameter::type):
(JSC::Bindings::JavaMethod::returnType):

  • bridge/jni/jni_jsobject.mm:

(JavaJSObject::call):
(JavaJSObject::eval):
(JavaJSObject::getMember):
(JavaJSObject::setMember):
(JavaJSObject::removeMember):
(JavaJSObject::convertJObjectToValue):

  • bridge/jni/jsc/JNIBridgeJSC.cpp:

(JavaField::JavaField):
(JavaField::valueFromInstance):
(JavaField::setValueToInstance):

  • bridge/jni/jsc/JNIBridgeJSC.h:

(JSC::Bindings::JavaField::type):

  • bridge/jni/jsc/JavaInstanceJSC.cpp:

(JavaInstance::invokeMethod):

  • bridge/jni/jsc/JavaStringJSC.h:

(JSC::Bindings::JavaStringImpl::utf8):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::put):

WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate):

WebKit/wx:

  • WebFrame.cpp:

(wxWebFrame::RunScript):

WebKit2:

  • WebProcess/Plugins/JSNPObject.cpp:

(WebKit::npIdentifierFromIdentifier):

  • WebProcess/Plugins/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):

  • WebProcess/Plugins/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

Note: See TracTimeline for information about the timeline view.