Timeline



Aug 29, 2010:

11:56 PM Changeset in webkit [66364] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-08-29 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Kent Tamura.

Move more common settings to webcore_prerequisites
https://bugs.webkit.org/show_bug.cgi?id=44812

  • WebCore.gyp/WebCore.gyp:
11:54 PM Changeset in webkit [66363] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

Fix Qt build.

  • wtf/unicode/glib/UnicodeMacrosFromICU.h: Added U_IS_BMP.
  • wtf/unicode/qt4/UnicodeQt4.h: Ditto.
  • wtf/unicode/wince/UnicodeWince.h: Ditto.
11:51 PM Changeset in webkit [66362] by Darin Adler
  • 212 edits in trunk/WebCore

2010-08-29 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

Create SVG and WML elements with create functions instead of direct invocations of new
https://bugs.webkit.org/show_bug.cgi?id=44851

Added the create functions, made some existing constructors protected and private,
made some other member functions protected and and private, added some missing virtual
keywords for clarity to functions that already were overriding virtual functions,
fixed some inconsistent indentation, and removed some unneeded empty destructors.

In the future, it will be good to have the constructors all be private so we don't
use them by accident. Then we'll change the reference count rule globally and add
all the necessary calls to adoptRef.

The SVG changes are compiled and tested. The WML changes are speculative and untested.

  • dom/make_names.pl: Removed supportfor the createWithNew keyword.
  • svg/svgtags.in: Removed all the createWithNew keywords.
  • wml/WMLTagNames.in: Ditto.
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::create): Added.
  • svg/SVGAElement.h:
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::create): Added.
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::create): Added.
  • svg/SVGAnimateColorElement.h:
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::create): Added.
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::create): Added.
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::create): Added.
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::create): Added.
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::create): Added.
  • svg/SVGClipPathElement.h:
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::create): Added.
  • svg/SVGCursorElement.h:
  • svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::create): Added.
  • svg/SVGDefsElement.h:
  • svg/SVGDescElement.cpp: (WebCore::SVGDescElement::create): Added.
  • svg/SVGDescElement.h:
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::create): Added.
  • svg/SVGEllipseElement.h:
  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::create): Added.
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::create): Added.
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::create): Added.
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::create): Added.
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::create): Added.
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::create): Added.
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::create): Added.
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDistantLightElement.cpp: (WebCore::SVGFEDistantLightElement::create): Added.
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::create): Added.
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFuncAElement.cpp: (WebCore::SVGFEFuncAElement::create): Added.
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncBElement.cpp: (WebCore::SVGFEFuncBElement::create): Added.
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncGElement.cpp: (WebCore::SVGFEFuncGElement::create): Added.
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncRElement.cpp: (WebCore::SVGFEFuncRElement::create): Added.
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::create): Added.
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::create): Added.
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::create): Added.
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::create): Added.
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::create): Added.
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::create): Added.
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEPointLightElement.cpp: (WebCore::SVGFEPointLightElement::create): Added.
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::create): Added.
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpotLightElement.cpp: (WebCore::SVGFESpotLightElement::create): Added.
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::create): Added.
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::create): Added.
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::create): Added.
  • svg/SVGFilterElement.h:
  • svg/SVGFontElement.cpp: (WebCore::SVGFontElement::create): Added.
  • svg/SVGFontElement.h:
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::create): Added.
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::create): Added.
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceNameElement.cpp: (WebCore::SVGFontFaceNameElement::create): Added.
  • svg/SVGFontFaceNameElement.h:
  • svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::create): Added.
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::create): Added.
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::create): Added.
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::create): Added.
  • svg/SVGGElement.h:
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::create): Added.
  • svg/SVGGlyphElement.h:
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::create): Added.
  • svg/SVGHKernElement.h:
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::create): Added.
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::create): Added.
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::create): Added.
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::create): Added.
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::create): Added.
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::create): Added.
  • svg/SVGMaskElement.h:
  • svg/SVGMetadataElement.cpp: (SVGMetadataElement::create): Added.
  • svg/SVGMetadataElement.h:
  • svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::create): Added.
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::create): Added.
  • svg/SVGPathElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::create): Added.
  • svg/SVGPatternElement.h:
  • svg/SVGPolygonElement.cpp: (WebCore::SVGPolygonElement::create): Added.
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.cpp: (WebCore::SVGPolylineElement::create): Added.
  • svg/SVGPolylineElement.h:
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::create): Added.
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::create): Added.
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::create): Added.
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::create): Added.
  • svg/SVGScriptElement.h:
  • svg/SVGSetElement.cpp: (WebCore::SVGSetElement::create): Added.
  • svg/SVGSetElement.h:
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::create): Added.
  • svg/SVGStopElement.h: (WebCore::SVGStyleElement::create): Added.
  • svg/SVGStyleElement.h:
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::create): Added.
  • svg/SVGSwitchElement.h:
  • svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::create): Added.
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::create): Added.
  • svg/SVGTRefElement.h:
  • svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::create): Added.
  • svg/SVGTSpanElement.h:
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::create): Added.
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::create): Added.
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::create): Added.
  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::create): Added.
  • svg/SVGUseElement.h:
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::create): Added.
  • svg/SVGVKernElement.h:
  • svg/SVGViewElement.cpp: (WebCore::SVGViewElement::create): Added.
  • svg/SVGViewElement.h:
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::create): Added.
  • wml/WMLAElement.h:
  • wml/WMLAccessElement.cpp: (WebCore::WMLAccessElement::create): Added.
  • wml/WMLAccessElement.h:
  • wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::create): Added.
  • wml/WMLAnchorElement.h:
  • wml/WMLBRElement.cpp: (WebCore::WMLBRElement::create): Added.
  • wml/WMLBRElement.h:
  • wml/WMLCardElement.cpp: (WebCore::WMLCardElement::create): Added.
  • wml/WMLCardElement.h:
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::create): Added.
  • wml/WMLDoElement.h:
  • wml/WMLFieldSetElement.cpp: (WebCore::WMLFieldSetElement::create): Added.
  • wml/WMLFieldSetElement.h:
  • wml/WMLFormControlElement.cpp: (WebCore::WMLFormControlElement::create): Added.
  • wml/WMLGoElement.cpp: (WebCore::WMLGoElement::create): Added.
  • wml/WMLGoElement.h:
  • wml/WMLImageElement.cpp: (WebCore::WMLImageElement::create): Added.
  • wml/WMLImageElement.h:
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::create): Added.
  • wml/WMLInputElement.h:
  • wml/WMLInsertedLegendElement.cpp: (WebCore::WMLInsertedLegendElement::create): Added.
  • wml/WMLInsertedLegendElement.h:
  • wml/WMLIntrinsicEvent.cpp: (WebCore::WMLIntrinsicEvent::create): Added.
  • wml/WMLMetaElement.cpp: (WebCore::WMLMetaElement::create): Added.
  • wml/WMLMetaElement.h:
  • wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::create): Added.
  • wml/WMLNoopElement.h:
  • wml/WMLOnEventElement.cpp: (WebCore::WMLOnEventElement::create): Added.
  • wml/WMLOnEventElement.h:
  • wml/WMLOptGroupElement.cpp: (WebCore::WMLOptGroupElement::create): Added.
  • wml/WMLOptGroupElement.h:
  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::create): Added.
  • wml/WMLOptionElement.h:
  • wml/WMLPElement.cpp: (WebCore::WMLPElement::create): Added.
  • wml/WMLPElement.h:
  • wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::create): Added.
  • wml/WMLPostfieldElement.h:
  • wml/WMLPrevElement.cpp: (WebCore::WMLPrevElement::create): Added.
  • wml/WMLPrevElement.h:
  • wml/WMLRefreshElement.cpp: (WebCore::WMLRefreshElement::create): Added.
  • wml/WMLRefreshElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::create): Added.
  • wml/WMLSelectElement.h:
  • wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::create): Added.
  • wml/WMLSetvarElement.h:
  • wml/WMLTableElement.cpp: (WebCore::WMLTableElement::create): Added.
  • wml/WMLTableElement.h:
  • wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::create): Added.
  • wml/WMLTaskElement.h:
  • wml/WMLTemplateElement.cpp: (WebCore::WMLTemplateElement::create): Added.
  • wml/WMLTemplateElement.h:
  • wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::create): Added.
  • wml/WMLTimerElement.h:
11:37 PM Changeset in webkit [66361] by tkent@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Unreviewed, add missing bug URL for the last my commit.

11:31 PM Changeset in webkit [66360] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-08-29 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Kent Tamura.

Rename webcore to 'webcore_remaining'.
Create a meta-target webcore that inherits from every webcore_XXX targets. (Currently 1)
Move direct_dependent_settings and export_dependent_settings from webcore_remaining to webcore

Obviously, there will be other webcore_XXX targets. Keeping the change as small as possible.

  • WebCore.gyp/WebCore.gyp:
11:31 PM Changeset in webkit [66359] by abarth@webkit.org
  • 8 edits in trunk

2010-08-29 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Move UTF16 LEAD/TRAIL logic into the HTMLEntityParser
https://bugs.webkit.org/show_bug.cgi?id=44790

We now block this attack.

  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
11:12 PM Changeset in webkit [66358] by jeremy@chromium.org
  • 5 edits
    2 moves in trunk/WebCore

2010-08-29 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

First step in unforking Chrome's FontPlatformDataMac.mm.
Move files from platform/graphics/mac to platform/graphics/cocoa

https://bugs.webkit.org/show_bug.cgi?id=41398

Just moving files around so no new tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/chromium/FontPlatformDataChromiumMac.mm:
  • platform/graphics/cocoa/FontPlatformData.h: Copied from WebCore/platform/graphics/mac/FontPlatformData.h.
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: Copied from WebCore/platform/graphics/mac/FontPlatformDataMac.mm.
  • platform/graphics/mac/FontPlatformData.h: Removed.
  • platform/graphics/mac/FontPlatformDataMac.mm: Removed.
10:11 PM Changeset in webkit [66357] by tkent@chromium.org
  • 11 edits in trunk

Introduce isValidValue(const String&) of HTMLInputElement and HTMLTextAreaElement
https://bugs.webkit.org/show_bug.cgi?id=43537

Reviewed by Darin Adler.

WebCore:

isValidValue() is useful for browser implementations to propose
form field values without breaking form validity.
No new tests because these functions are not exposed to JavaScript.

  • html/HTMLFormControlElement.h:

(WebCore::HTMLTextFormControlElement::):

Remove virtual valueMissing(), patternMismatch(), and tooLong().

  • html/HTMLInputElement.cpp:

(WebCore::isValidColorString): Moved from ValidityState.
(WebCore::isValidEmailAddress): ditto.
(WebCore::HTMLInputElement::isValidValue): Added.
(WebCore::HTMLInputElement::typeMismatch): Add a String parameter.
(WebCore::HTMLInputElement::valueMissing): Add a String parameter.
(WebCore::HTMLInputElement::patternMismatch): Add a String parameter.
(WebCore::HTMLInputElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
(WebCore::HTMLInputElement::rangeUnderflow): Add a String parameter.
(WebCore::HTMLInputElement::rangeOverflow): Add a String parameter.
(WebCore::HTMLInputElement::stepMismatch): Add a String parameter.

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
(WebCore::HTMLTextAreaElement::isValidValue): Added.

  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::valueMissing):

  • html/ValidityState.cpp:

(WebCore::ValidityState::valueMissing): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
(WebCore::ValidityState::typeMismatch): Passes value() to HTMLInputElement::typeMismatch().
(WebCore::ValidityState::patternMismatch): Calls patternMismatch() of HTMLInputElement.
(WebCore::ValidityState::tooLong): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
(WebCore::ValidityState::rangeUnderflow): Passes value() to HTMLInputElement::rangeUnderflow().
(WebCore::ValidityState::rangeOverflow): Passes value() to HTMLInputElement::rangeUnderflow().
(WebCore::ValidityState::stepMismatch): Passes value() to HTMLInputElement::stepMismatch().

  • html/ValidityState.h:

WebKit/chromium:

  • public/WebInputElement.h:
  • src/WebInputElement.cpp:

(WebKit::WebInputElement::isValidValue):

9:55 PM Changeset in webkit [66356] by yuzo@google.com
  • 1 edit
    1 add in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change for r66282.

  • platform/chromium-win/inspector/console-format-expected.txt: Added.
9:47 PM Changeset in webkit [66355] by tkent@chromium.org
  • 36 edits in trunk

Change lower and higher limits of date/datetime/datetime-local/month/week types
https://bugs.webkit.org/show_bug.cgi?id=39737

Reviewed by Darin Adler.

WebCore:

According to the latest draft of HTML5, ISO-8601 dates in HTML5
should support A.D.0001 in Gregorian calendar though Gregorian
calendar started in 1582. So, we change the lower limits of
date&time types to 0001-01-01T00:00.

We also introduce the common higher limit, 275760-09-13T00:00. It
is the higher limit of Date type of ECMAScript.

  • html/DateComponents.cpp:

(WebCore::DateComponents::parseYear):

Rejects years less than A.D.1 and years greater than 275760.

(WebCore::withinHTMLDateLimits):

Helper functions to check lower and higher limits.

(WebCore::DateComponents::addDay):

  • Remove an overflow check. 'year' can't be so large number because parseYear() rejects such numbers.
  • Add withinHTMLDateLimits() calls.

(WebCore::DateComponents::addMinute):

  • Add an assertion for the base date.
  • Add withinHTMLDateLimits() calls.

(WebCore::DateComponents::parseMonth):

Add withinHTMLDateLimits() call.

(WebCore::DateComponents::parseDate): ditto.
(WebCore::DateComponents::parseWeek): ditto.
(WebCore::DateComponents::parseDateTimeLocal): ditto.
(WebCore::DateComponents::parseDateTime): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForDate): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTime): ditto.
(WebCore::DateComponents::setMillisecondsSinceEpochForMonth): ditto.
(WebCore::DateComponents::setMonthsSinceEpoch):

Add year range check and withinHTMLDateLimits() call.

(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):

Add year range check and week range check.

  • html/DateComponents.h: Update minimum/maximum constant values.

(WebCore::DateComponents::minimumDate):
(WebCore::DateComponents::minimumDateTime):
(WebCore::DateComponents::minimumMonth):
(WebCore::DateComponents::minimumWeek):
(WebCore::DateComponents::maximumDate):
(WebCore::DateComponents::maximumDateTime):
(WebCore::DateComponents::maximumMonth):
(WebCore::DateComponents::maximumWeek):

LayoutTests:

Update tests and test results for the new DateComponents behavior.

  • fast/forms/ValidityState-rangeOverflow-expected.txt:
  • fast/forms/ValidityState-stepMismatch-expected.txt:
  • fast/forms/ValidityState-typeMismatch-date-expected.txt:
  • fast/forms/ValidityState-typeMismatch-datetime-expected.txt:
  • fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt:
  • fast/forms/ValidityState-typeMismatch-month-expected.txt:
  • fast/forms/ValidityState-typeMismatch-week-expected.txt:
  • fast/forms/input-valueasdate-date-expected.txt:
  • fast/forms/input-valueasdate-datetime-expected.txt:
  • fast/forms/input-valueasdate-month-expected.txt:
  • fast/forms/input-valueasdate-week-expected.txt:
  • fast/forms/input-valueasnumber-date-expected.txt:
  • fast/forms/input-valueasnumber-datetime-expected.txt:
  • fast/forms/input-valueasnumber-datetimelocal-expected.txt:
  • fast/forms/input-valueasnumber-month-expected.txt:
  • fast/forms/input-valueasnumber-week-expected.txt:
  • fast/forms/script-tests/ValidityState-rangeOverflow.js:
  • fast/forms/script-tests/ValidityState-stepMismatch.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-date.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-datetime.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-month.js:
  • fast/forms/script-tests/ValidityState-typeMismatch-week.js:
  • fast/forms/script-tests/input-valueasdate-date.js:
  • fast/forms/script-tests/input-valueasdate-datetime.js:
  • fast/forms/script-tests/input-valueasdate-month.js:
  • fast/forms/script-tests/input-valueasdate-week.js:
  • fast/forms/script-tests/input-valueasnumber-date.js:
  • fast/forms/script-tests/input-valueasnumber-datetime.js:
  • fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
  • fast/forms/script-tests/input-valueasnumber-month.js:
  • fast/forms/script-tests/input-valueasnumber-week.js:
9:38 PM Changeset in webkit [66354] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change for r66296.

  • platform/chromium/test_expectations.txt:
9:25 PM Changeset in webkit [66353] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-29 James Robinson <jamesr@chromium.org>

Reviewed by David Levin.

Make failing the download step fail the build
https://bugs.webkit.org/show_bug.cgi?id=44298

If the download step fails on a test bot, this ensures that
the build goes red instead of only the download step going red
and the overall build staying green.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
9:16 PM Changeset in webkit [66352] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium/test_expectations.txt:
9:07 PM Changeset in webkit [66351] by tkent@chromium.org
  • 4 edits in trunk

2010-08-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Remove dependency to base/keyboard_codes.h
https://bugs.webkit.org/show_bug.cgi?id=44847

  • DEPS: Roll Chromium revision to 57823 to have a webkit_support change.

2010-08-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Remove dependency to base/keyboard_codes.h
https://bugs.webkit.org/show_bug.cgi?id=44847

  • DumpRenderTree/chromium/EventSender.cpp: Use webkit_support::VKEY_* instead of base::VKEY_*.
8:26 PM Changeset in webkit [66350] by Darin Adler
  • 2 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=40589

  • Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty

function names.

7:41 PM Changeset in webkit [66349] by yuzo@google.com
  • 62 edits
    11 copies
    6 adds
    19 deletes in trunk/LayoutTests

2010-08-29 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change for r66306.

  • platform/chromium-linux/fast/forms/form-added-to-table-expected.txt: Added.
  • platform/chromium-linux/fast/forms/formmove3-expected.checksum:
  • platform/chromium-linux/fast/forms/formmove3-expected.png:
  • platform/chromium-linux/fast/forms/formmove3-expected.txt:
  • platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.checksum:
  • platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.png: Removed.
  • platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
  • platform/chromium-linux/fast/table/fixed-table-non-cell-in-row-expected.txt: Added.
  • platform/chromium-linux/fast/table/inline-form-assert-expected.txt: Added.
  • platform/chromium-linux/fast/table/insert-cell-before-form-expected.txt: Added.
  • platform/chromium-linux/fast/table/insert-row-before-form-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug78162-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.txt: Added.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/chromium-mac/fast/forms/formmove3-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/formmove3-expected.png: Removed.
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Removed.
  • platform/chromium-win/fast/forms/form-added-to-table-expected.txt:
  • platform/chromium-win/fast/forms/formmove3-expected.checksum:
  • platform/chromium-win/fast/forms/formmove3-expected.png:
  • platform/chromium-win/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.checksum:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.png:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/chromium-win/fast/table/fixed-table-non-cell-in-row-expected.txt:
  • platform/chromium-win/fast/table/inline-form-assert-expected.txt:
  • platform/chromium-win/fast/table/insert-cell-before-form-expected.txt:
  • platform/chromium-win/fast/table/insert-row-before-form-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug2516-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug2516-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2516-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug30559-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug30559-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug32447-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug32447-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug32447-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug34538-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug34538-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug34538-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug78162-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug96343-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug96343-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug96343-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/chromium/test_expectations.txt:
7:06 PM Changeset in webkit [66348] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-08-29 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port SharedBuffer::createWithContentsOfFile
https://bugs.webkit.org/show_bug.cgi?id=34412

Implement SharedBuffer::createWithContentsOfFile with IFile.

  • platform/brew/SharedBufferBrew.cpp: Added. (WebCore::SharedBuffer::createWithContentsOfFile):
6:54 PM Changeset in webkit [66347] by zecke@webkit.org
  • 4 edits in trunk/WebKitTools

[iExploder] Add new CSS Properties and HTML Attributes

https://bugs.webkit.org/show_bug.cgi?id=44746

Updated the files with the update-iexploder-cssproperties script
and manually readded the -webkit-binding CSS Property to the list.

  • iExploder/htdocs/cssproperties.in:
  • iExploder/htdocs/htmlattrs.in:
  • iExploder/htdocs/htmltags.in:
6:53 PM Changeset in webkit [66346] by zecke@webkit.org
  • 3 edits in trunk/WebKitTools

Fix Coverage build after the addition of ANGLE

https://bugs.webkit.org/show_bug.cgi?id=44744

ANGLE is using libtool to build a static library and the version of
libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
parameters. The easiest way to handle this is to not build ANGLE with
coverage information.

This is achieved by applying the XCode options for each project
separately and exclude ANGLE.

  • Scripts/build-webkit: Remove -framework AppKit due link errors.
  • Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
6:46 PM Changeset in webkit [66345] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-29 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port vprintf_stderr_common
https://bugs.webkit.org/show_bug.cgi?id=33568

Use BREW's DBGPRINTF to output debug messages.

  • wtf/Assertions.cpp:
6:31 PM Changeset in webkit [66344] by enrica@apple.com
  • 5 edits in trunk

WebCore: Crash when dragging text in Google Docs
https://bugs.webkit.org/show_bug.cgi?id=20471
<rdar://problem/7783629>

Reviewed by Adele Peterson.

This fixes the crash but also fixes the generated markup when
performing a replacement at the border with an inline, to avoid the
new content being merged into the inline.
The crash is happening when doApply detects the need of merging
the start and the end of the new paragraph and the destination position
is moved inside an inline.

I've added new test cases to an existing layout test.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): When the situation described above is detected,
we insert a placeholder to avoid merging into the inline.

LayoutTests: Crash when dragging text in Google Docs
https://bugs.webkit.org/show_bug.cgi?id=20471
<rdar://problem/7783629>

Reviewed by Adele Peterson.

Added new test cases to an exisisting file and updated the result to reflect
the correct behavior.

  • editing/selection/replace-selection-crash-expected.txt:
  • editing/selection/replace-selection-crash.html:
6:16 PM Changeset in webkit [66343] by abarth@webkit.org
  • 4 edits in trunk

2010-08-29 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Implement HTML5's fakepath
https://bugs.webkit.org/show_bug.cgi?id=29000

Update expectations for this pasteboard test to include our new friend
fakepath.

  • editing/pasteboard/file-input-files-access-expected.txt:

2010-08-29 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Implement HTML5's fakepath
https://bugs.webkit.org/show_bug.cgi?id=29000

The HTML 5 spec says to prepend C:\fakepath\ to the value of an
<input type="file"> control, so that's what we do now.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::value):
5:36 PM Changeset in webkit [66342] by commit-queue@webkit.org
  • 3 edits
    2 moves in trunk/WebCore

2010-08-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66329.
http://trac.webkit.org/changeset/66329
https://bugs.webkit.org/show_bug.cgi?id=44845

broke chromium mac (Requested by jamesr on #webkit).

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/mac/FontPlatformData.h: Renamed from WebCore/platform/graphics/cocoa/FontPlatformData.h. (WebCore::toCTFontRef): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::syntheticBold): (WebCore::FontPlatformData::syntheticOblique): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::isColorBitmapFont): (WebCore::FontPlatformData::cgFont): (WebCore::FontPlatformData::hashTableDeletedFontValue):
  • platform/graphics/mac/FontPlatformDataMac.mm: Renamed from WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm. (WebCore::FontPlatformData::FontPlatformData): (WebCore::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::roundsGlyphAdvances): (WebCore::FontPlatformData::allowsLigatures): (WebCore::FontPlatformData::ctFont): (WebCore::FontPlatformData::description):
5:10 PM Changeset in webkit [66341] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-08-29 Adam Barth <abarth@webkit.org>

Attempt to make Sam's life easier by not opening a comment text field
if there's a selection. This should make it easier to copy/paste text
out of the diff without accidentally opening comment boxes.

  • code-review.js:
4:56 PM Changeset in webkit [66340] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2010-08-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

fast/loader/input-element-page-cache-crash.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=44811

Make test not rely on page cache behavior (window.finishTest being
persisted), instead use sessionStorage.

  • fast/loader/input-element-page-cache-crash.html:
  • platform/chromium/test_expectations.txt:
4:16 PM Changeset in webkit [66339] by Simon Fraser
  • 12 edits
    6 adds in trunk

2010-08-29 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

When properties are missing from animation keyframes, interpolate between those keyframes that specify them
https://bugs.webkit.org/show_bug.cgi?id=40794

When a property does not appear in all keyframes of a keyframe animation, we currently use the
value of that property from the unanimated style. That forces the author to use additional
keyframes for properties that need to "skip a keyframe", which is laborious.

With this change, properties are interpolated between the keyframes in which they appear.
This is equivalent to splitting each property out into its own set of keyframes.

Tests: animations/missing-keyframe-properties-repeating.html

animations/missing-keyframe-properties-timing-function.html
animations/missing-keyframe-properties.html

  • css/CSSStyleSelector.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForKeyframe): Pass a KeyframeValue in so that we can collect which properties are represented per keyframe. (WebCore::CSSStyleSelector::keyframeStylesForAnimation): Keyframes are inserted into a KeyframeList by object now, rather than by key and style.
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::progress): Use AnimationDirectionAlternate for readability.
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): Renamed from getKeyframeAnimationInterval. Use fractionalTime etc to match AnimationBase::progress(), and do lookups per-property. Simplify the code that finds the relevant keyframe to do less work. (WebCore::KeyframeAnimation::animate): Call fetchIntervalEndpointsForProperty() for each property, rather than just once for the entire keyframe. (WebCore::KeyframeAnimation::getAnimatedStyle): Ditto. (WebCore::KeyframeAnimation::hasAnimationForProperty): FIXME comment.
  • page/animation/KeyframeAnimation.h: Rename getKeyframeAnimationInterval() to fetchIntervalEndpointsForProperty().
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): For hardware animations, only insert values for keyframes which contain the property.

(WebCore::KeyframeList::KeyframeList): insert() takes a KeyframeValue now.

  • rendering/style/KeyframeList.cpp: (WebCore::KeyframeList::operator==): (WebCore::KeyframeList::insert): Fix insert/replace logic, and ensure we maintain the m_properties hash.
  • rendering/style/KeyframeList.h: (WebCore::KeyframeValue::KeyframeValue): Make members private, with accessors. Add a m_properties HashSet for the properties animated in this keyframe.
3:09 PM Changeset in webkit [66338] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-08-29 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Darin Adler.

REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=44843

  • editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Suggested parentheses added around && within
2:28 PM Changeset in webkit [66337] by Darin Adler
  • 2 edits in trunk/WebCore

Try to fix Mac build.

  • WebCore.xcodeproj/project.pbxproj: Mark CounterContent.h Private instead of Project.
1:46 PM Changeset in webkit [66336] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-29 Pawel Hajdan <phajdan.jr@chromium.org>

Reviewed by Darin Adler.

Fix libxml workarounds to work with recent versions of libxml.
I was testing locally with libxml2-2.7.6.
https://bugs.webkit.org/show_bug.cgi?id=30508

Based on patch by Philippe Normand <pnormand@igalia.com>.

This also fixes a Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=29333

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::switchToUTF16): (WebCore::XMLParserContext::createStringParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::startDocumentHandler):
1:41 PM Changeset in webkit [66335] by Darin Adler
  • 5 edits in trunk/WebCore

Try to fix Windows build.

  • rendering/style/ContentData.h: Added include of CounterContent.h.
  • css/CSSStyleSelector.cpp: Removed include of CounterContent.h.
  • rendering/style/ContentData.cpp: Ditto.
  • rendering/style/RenderStyle.cpp: Ditto.
12:56 PM Changeset in webkit [66334] by Darin Adler
  • 23 edits in trunk/WebCore

2010-08-29 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Deploy OwnPtr, PassOwnPtr, and adoptPtr in some CSS-related files
https://bugs.webkit.org/show_bug.cgi?id=44834

  • css/CSSFunctionValue.cpp: (WebCore::CSSFunctionValue::CSSFunctionValue): Updated since CSSParserFunction::args is an OwnPtr. (WebCore::CSSFunctionValue::parserValue): Ditto.
  • css/CSSGrammar.y: Added leakPtr calls for putting MediaQueryExp* into the media query expression list, which is a vector of raw pointers that are deleted explicitly.
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet): Updated to use document instead of doc. (WebCore::CSSImportRule::insertedIntoParent): Ditto.
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): Ditto.
  • css/CSSNamespace.h: Took the "m_" off the names of the data members of this structure. Used OwnPtr for the parent data member. Rewrote the namespaceForPrefix function so it's iterative instead of recursive.
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): Update since m_mediaQuery, m_floatingMediaQuery, m_floatingMediaQueryExp, and m_floatingMediaQueryExpList are now all OwnPtr and thus don't need to be initialized. (WebCore::CSSParser::~CSSParser): Update to not delete the above OwnPtr. (WebCore::CSSParser::parseMediaQuery): Replaced the code that sets m_mediaQuery to 0 with an assertion. Also use release when passing the media query to appendMediaQuery. (WebCore::CSSParser::document): Updated to use document instead of doc and to use early return instead of a nested if. (WebCore::CSSParser::parseContent): Added a get() call needed since CSSParserFunction::args is an OwnPtr. (WebCore::CSSParser::parseAnimationTimingFunction): Ditto. (WebCore::CSSParser::parseDashboardRegions): Ditto. (WebCore::CSSParser::parseShape): Ditto. (WebCore::isValidFormatFunction): Ditto. (WebCore::CSSParser::parseFontFaceSrc): Ditto. (WebCore::CSSParser::parseColorParameters): Ditto. (WebCore::CSSParser::parseHSLParameters): Ditto. (WebCore::parseGradientColorStop): Ditto. (WebCore::CSSParser::parseGradient): Ditto. (WebCore::CSSParser::parseCanvas): Ditto. (WebCore::CSSParser::parseTransform): Ditto. (WebCore::CSSParser::createFloatingMediaQueryExp): Updated to use adoptPtr and remove the explicit deletion. (WebCore::CSSParser::sinkFloatingMediaQueryExp): Updated to use release. (WebCore::CSSParser::createFloatingMediaQueryExpList): Ditto. (WebCore::CSSParser::sinkFloatingMediaQueryExpList): Ditto. (WebCore::CSSParser::createFloatingMediaQuery): Ditto. (WebCore::CSSParser::sinkFloatingMediaQuery): Ditto. (WebCore::CSSParser::checkForVariables): Use get for CSSParserFunction::args.
  • css/CSSParser.h: Made return values for sinkFloatingMediaQueryExp, sinkFloatingMediaQueryExpList, and sinkFloatingMediaQuery be PassOwnPtr. Made createFloatingMediaQuery take a PassOwnPtr. Made m_mediaQuery, m_floatingMediaQuery, m_floatingMediaQueryExp, and m_floatingMediaQueryExpList be OwnPtr.
  • css/CSSParserValues.h: Made args be an OwnPtr.
  • css/CSSStyleSelector.cpp: Made CSSRuleSet m_universalRules and m_pageRules be OwnPtr. (WebCore::CSSStyleSelector::CSSStyleSelector): Use document instead of doc. Got rid of the init function, only called here, because it did nothing that wasn't already done. Eliminated unneeded code to set m_userStyle to 0, since it's now an OwnPtr and will be 0 automatically. Use adoptPtr when initializing m_medium, m_authorStyle, and m_useStyle. (WebCore::CSSStyleSelector::~CSSStyleSelector): Got rid of unneeded delete of m_medium, m_authorStyle, and m_userStyle, and unneded clear of m_keyframesRuleMap. (WebCore::CSSStyleSelector::styleForElement): Use get with m_userStyle and m_authorStyle. (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto. (WebCore::CSSStyleSelector::styleForPage): Ditto. (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto. (WebCore::CSSRuleSet::CSSRuleSet): Got rid of unneeded initialization of m_universalRules and m_pageRules. (WebCore::CSSRuleSet::~CSSRuleSet): Got rid of unneeed deletion of same. (WebCore::CSSRuleSet::addRule): Use adoptPtr to initialize m_universalRules. (WebCore::CSSRuleSet::addPageRule): Use adoptPtr to initialize m_pageRules. (WebCore::CSSStyleSelector::applyProperty): Use adopPtr to create counter context object.
  • css/CSSStyleSelector.h: Made m_authorStyle, m_userStyle, and m_medium use OwnPtr. Got rid of init function.
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet): Updatd for name change from m_doc and doc to m_document and document. Eliminated unneeded initialization of m_namespaces now that it is an OwnPtr. (WebCore::CSSStyleSheet::~CSSStyleSheet): Got rid of unneeded deletion of same. (WebCore::CSSStyleSheet::cssRules): Updated doc to document. (WebCore::CSSStyleSheet::addNamespace): Added adopPtr when setting m_namespaces. (WebCore::CSSStyleSheet::determineNamespace): Updated for changes to the CSSNamespace class, using uri data member instead of function. (WebCore::CSSStyleSheet::styleSheetChanged): Use document instead of doc.
  • css/CSSStyleSheet.h: Renamed doc and m_doc to document and m_document. Made m_namespaces an OwnPtr.
  • css/CSSValueList.cpp: (WebCore::CSSValueList::CSSValueList): Clean up logic a bit. (WebCore::CSSValueList::createParserValueList): Clean up logic a bit and return a PassOwnPtr.
  • css/CSSValueList.h: Changed createParserValueList to return a PassOwnPtr.
  • css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc): Updated to use document instead of doc.
  • css/MediaList.cpp: (WebCore::MediaList::deleteMedium): Use OwnPtr instead of a boolean to make sure the newly-created query here is deleted. (WebCore::MediaList::appendMediaQuery): Updated to take PassOwnPtr.
  • css/MediaList.h: Changed appendMediaQuery to take a PassOwnPtr.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyleSheet): Use document instead of doc. (WebCore::InspectorDOMAgent::getRuleRanges): Ditto. (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): Ditto.
  • rendering/style/ContentData.cpp: (WebCore::ContentData::clear): Update since data members are OwnPtr. Also, fixed iterative deletion algorithm to be much simpler. (WebCore::ContentData::dataEquivalent): Added FIXMEs and tweaked formatting. (WebCore::ContentData::deleteContent): Tweaked formatting.
  • rendering/style/ContentData.h: Changed m_next to an OwnPtr. Added assertions to getters to check that we get the correct type. Use leakRef instead of releaseRef. Changed setCounter and setNext functions to take PassOwnPtr arguments.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::prepareToSetContent): Refactored common part of the into a shared function so the three setContent functions don't have to repeat the logic. Used an OwnPtr to avoid confusing logic and leakPtr. (WebCore::RenderStyle::setContent): Changed argument to PassOwnPtr.
  • rendering/style/RenderStyle.h: Changed setContent argument to a PassOwnPtr. Added declaration of prepareToSetContent helper function.
11:04 AM Changeset in webkit [66333] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-08-29 Adam Barth <abarth@webkit.org>

Turns out we're supposed to use find instead of children here.

  • code-review.js:
10:59 AM Changeset in webkit [66332] by abarth@webkit.org
  • 2 edits
    1 add
    1 delete in trunk/BugsSite

2010-08-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Awesomify pretty-diff based review tool
https://bugs.webkit.org/show_bug.cgi?id=44835

This patch replaces the existing inline comment feature with a new
implementation. Hopefully the new implementation is more awesome.
It's not 100% done yet, but I'd like to get this version out there to
see how it works.

Unlike the previous version this version works with the "Formatted
Diff" link instead of the "Review Patch" link. Hopefully that will
avoid interfering with folks who like the old style review.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js: Added.
  • prototype.js: Removed.
7:12 AM Changeset in webkit [66331] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-29 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Port ScrollbarThemeWin to WinCE
https://bugs.webkit.org/show_bug.cgi?id=44818

Add a #ifdef around usage of unsupported DFCS_FLAT.

  • platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::paintButton):
6:55 AM Changeset in webkit [66330] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-29 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Port SystemInfo to WinCE
https://bugs.webkit.org/show_bug.cgi?id=44817

  • platform/win/SystemInfo.cpp: (WebCore::isRunningOnVistaOrLater):

Aug 28, 2010:

11:45 PM Changeset in webkit [66329] by jeremy@chromium.org
  • 3 edits
    2 moves
    1 add in trunk/WebCore

2010-08-28 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

First step in unforking Chrome's FontPlatformDataMac.mm.
Move files from platform/graphics/mac to platform/graphics/cocoa

https://bugs.webkit.org/show_bug.cgi?id=41398

Just moving files around so no new tests.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/cocoa: Added.
  • platform/graphics/cocoa/FontPlatformData.h: Copied from WebCore/platform/graphics/mac/FontPlatformData.h.
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm: Copied from WebCore/platform/graphics/mac/FontPlatformDataMac.mm.
  • platform/graphics/mac/FontPlatformData.h: Removed.
  • platform/graphics/mac/FontPlatformDataMac.mm: Removed.
10:52 PM Changeset in webkit [66328] by Darin Adler
  • 1 edit in trunk/LayoutTests/dom/xhtml/level2/html/button03.js

Checked in a file missed when I landed just now.

10:48 PM Changeset in webkit [66327] by Darin Adler
  • 46 edits
    1 copy
    5 adds in trunk

Some IDL attributes don't reflect URL content attributes properly
https://bugs.webkit.org/show_bug.cgi?id=43650

Reviewed by Sam Weinig.

WebCore:

  • dom/Document.cpp:

(WebCore::Document::processBaseElement): Added. Implements the rules for base elements
from the HTML5 specification. Handles multiple base elements in the same document.

  • dom/Document.h: Removed setBaseElementURL and setBaseElementTarget, replacing them

with processBaseElement.

  • html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::parseMappedAttribute): Call the new processBaseElement
function.
(WebCore::HTMLBaseElement::insertedIntoDocument): Ditto.
(WebCore::HTMLBaseElement::removedFromDocument): Ditto.
(WebCore::HTMLBaseElement::isURLAttribute): Added.
(WebCore::HTMLBaseElement::target): Moved here from the .h file and changed to not
realy on an m_target local variable.

  • html/HTMLBaseElement.h: Added an override of the isURLAttribute function. Removed

unneeded process function. Removed declaration of nonexistent setHref and setTarget
functions. Removed unneeded m_hrefAttrValue, m_href, and m_target. Moved
implementation of target function into the .cpp file.

  • html/HTMLBaseElement.idl: Marked the href attribute as URL.
  • html/HTMLBlockquoteElement.cpp:

(WebCore::HTMLBlockquoteElement::isURLAttribute): Added.

  • html/HTMLBlockquoteElement.h: Added isURLAttribute.
  • html/HTMLBlockquoteElement.idl: Marked the cite attribute as URL.
  • html/HTMLEmbedElement.idl: Marked the src attribute as URL.
  • html/HTMLFormElement.cpp: Added a comment about the action function, which should

be removed.

  • html/HTMLFormElement.idl: Marked the action attribute as URL.
  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::isURLAttribute): Added.
(WebCore::HTMLHtmlElement::insertedIntoDocument): Tweaked a bit.

  • html/HTMLHtmlElement.h: Added isURLAttribute.
  • html/HTMLHtmlElement.idl: Marked the manifest attribute as URL.
  • html/HTMLIFrameElement.idl: Marked the src attribute a URL.
  • html/HTMLModElement.cpp:

(WebCore::HTMLModElement::isURLAttribute): Added.

  • html/HTMLModElement.h: Added isURLAttribute.
  • html/HTMLModElement.idl: Marked the cite attribute as URL.
  • html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::isURLAttribute): Added.

  • html/HTMLQuoteElement.h: Added isURLAttribute.
  • html/HTMLQuoteElement.idl: Marked the cite attribute as URL.
  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::processTagToken): Changed code to create a base
element instead of calling setBaseElementURL directly.
(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Use AtomicString instead of String.
(WebCore::HTMLViewSourceDocument::addLine): Ditto.
(WebCore::HTMLViewSourceDocument::addText): Ditto.
(WebCore::HTMLViewSourceDocument::addBase): Added. Creates a base element and inserts it.
(WebCore::HTMLViewSourceDocument::addLink): Use AtomicString instead of String.

  • html/HTMLViewSourceDocument.h: Updated function declarations as above.
  • bindings/scripts/test/CPP/WebDOMTestCallback.h:
  • bindings/scripts/test/CPP/WebDOMTestInterface.h:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

Updated results, which changed due to the fixes for at
least these bugs, and perhaps a few more:
https://bugs.webkit.org/show_bug.cgi?id=42115
https://bugs.webkit.org/show_bug.cgi?id=44597
https://bugs.webkit.org/show_bug.cgi?id=44738

  • bindings/scripts/test/TestObj.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFormElement.cpp:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSourceElement.idl:
  • html/HTMLVideoElement.idl:

Tweaked formatting.

LayoutTests:

  • dom/html/level2/html/button03.js: Added a "WebKit modification" section so this

correctly expects the action attribute to return a completed URL.

  • dom/xhtml/level2/html/button03.js: Ditto.
  • fast/dom/URL-attribute-reflection-expected.txt: Updaed expected results to expecte

more successes.

  • fast/dom/script-tests/URL-attribute-reflection.js:

(testURLReflection): Fixed wrong variable name in the test script.

  • http/tests/security/xssAuditor/full-block-iframe-no-inherit.php: Removed a call

to encodeURI that was needed to work around our incorrect implementation of
HTMLIFrameElement's src attribute.

  • fast/dom/HTMLBaseElement: Added.
  • fast/dom/HTMLBaseElement/multiple-base-elements-expected.txt: Added.
  • fast/dom/HTMLBaseElement/multiple-base-elements.html: Added.
  • fast/dom/HTMLBaseElement/script-tests: Added.
  • fast/dom/HTMLBaseElement/script-tests/TEMPLATE.html:

Copied from fast/dom/HTMLAnchorElement/script-tests/TEMPLATE.html.

  • fast/dom/HTMLBaseElement/script-tests/multiple-base-elements.js: Added.
10:11 PM Changeset in webkit [66326] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-08-28 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

The logic to escape entities in appendEscapedContent and appendAttributeValue should be merged
https://bugs.webkit.org/show_bug.cgi?id=44831

Added appendCharactersReplacingEntities to escape &, <, >, ", and nbsp based on the mask.
Removed escapeContentText because it was only used in appendText, which now directly calls
appendCharactersReplacingEntities. Replaced appendEscapedContent, ucharRange, and appendUCharRange
by appendNodeValue.

No new tests are added since this is a cleanup.

  • editing/markup.cpp: (WebCore::): (WebCore::appendCharactersReplacingEntities): Added. (WebCore::MarkupAccumulator::appendAttributeValue): Calls appendCharactersReplacingEntities. (WebCore::MarkupAccumulator::appendNodeValue): Added. (WebCore::MarkupAccumulator::appendText): Calls appendNodeValue and appendCharactersReplacingEntities. (WebCore::urlToMarkup): Calls escapeEntities.
9:50 PM Changeset in webkit [66325] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Update WebKit2 skipped list.

  • platform/mac-wk2/Skipped:
9:38 PM Changeset in webkit [66324] by rniwa@webkit.org
  • 5 edits
    3 adds in trunk

2010-08-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

cannot remove text-decoration when style is added by u or s
https://bugs.webkit.org/show_bug.cgi?id=44560

The bug was caused by WebKit not pushing down implicitly added styles to descendent nodes.
Fixed the bug by pushing down all elements that implicitly add style.

extractInlineStyleToPushDown now calls removeImplicitlyStyledElement, which was modified to extract
the style implicitly added by the element to extractStyle.

This revealed a bug in applyInlineStyleToPushDown where applyInlineStyleIfNeeded could add
an implicitly styled element inside an element with a conflicting style, thereby overriding the style of the element.
Fixed this by extending the logic to honor the existing inline style declaration used in
the case of rewriting inline style declaration to all cases including the one calling addInlineStyleIfNeeded.

Also fixed a bug in removeInlineStyle where pushDownInlineStyleAroundNode was called on a text node
outside of selection if start was at the end of the text node.

Test: editing/style/push-down-implicit-styles.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Added extractedStyle, which receives the style implicitly added by the element being removed. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Calls removeImplicitlyStyledElement to remove the implicitly styled element and extract the inline style added by the element. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Fixed a bug that addInlineStyleIfNeeded could override the inline style declaration style of the node. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Uses extractInlineStyleToPushDown (WebCore::ApplyStyleCommand::removeInlineStyle): See above.
  • editing/ApplyStyleCommand.h: Prototype changes.

2010-08-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

cannot remove text-decoration when style is added by u or s
https://bugs.webkit.org/show_bug.cgi?id=44560

Added a test to ensure WebKit removes text-decorations added by u or s
and pushes down implicit styles properly into descendent nodes.

  • editing/style/push-down-implicit-styles-expected.txt: Added.
  • editing/style/push-down-implicit-styles.html: Added.
  • editing/style/script-tests/push-down-implicit-styles.js: Added. (testSingleToggle): (selectAll): (selectTest): (selectSecondWord): (selectLastTwoWords):
  • editing/style/typing-style-003-expected.txt: Negation of inline styles are now done by pushing down implicitly styled elements rather than canceling them by inline style declarations.
8:45 PM Changeset in webkit [66323] by Darin Adler
  • 4 edits in trunk/WebKit/mac

Make an internal method used by Apple Mail into SPI
https://bugs.webkit.org/show_bug.cgi?id=44832
rdar://problem/5748951

Reviewed by Sam Weinig.

  • WebView/WebFrame.mm:

(-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Moved this method
from the internal section to the private section.

  • WebView/WebFrameInternal.h: Moved the method declaration out of here.
  • WebView/WebFramePrivate.h: Moved the method declaration in here.
8:31 PM Changeset in webkit [66322] by jianli@chromium.org
  • 3 edits in trunk/WebKit/chromium

[chromium] Add webkit_support.gyp:blob to WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=44829

Reviewed by Darin Fisher.

Also bump up chromium revision in DEPS in order to pick up
the revision that contains blob change.

  • DEPS:
  • WebKit.gyp:
8:15 PM Changeset in webkit [66321] by mrowe@apple.com
  • 5 edits in tags/Safari-534.6.2

Versioning.

8:15 PM Changeset in webkit [66320] by mrowe@apple.com
  • 8 edits
    1 move
    1 add
    1 delete in tags/Safari-534.6.2

Merge r66319.

7:34 PM Changeset in webkit [66319] by mrowe@apple.com
  • 9 edits
    1 move
    1 add
    1 delete in trunk

<http://webkit.org/b/44802> REGRESSION (r65351): WebCore build fails due to attempting to directly access WebKitTools/Scripts

Reviewed by Adam Barth.

Move create-html-entity-table in to WebCore so that the build is again self-contained.
The script is also updated to take input as a CSV file rather than JSON as the former
can be parsed without requiring a third-party Python module be installed.

.:

  • cmake/WebKitMacros.cmake:

WebCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pri:
  • WebCore.xcodeproj/project.pbxproj: Stop copying the input file in to the WebCore framework wrapper.
  • html/parser/HTMLEntityNames.in: Added.
  • html/parser/HTMLEntityNames.json: Removed.
  • html/parser/create-html-entity-table: Renamed from WebKitTools/Scripts/create-html-entity-table.
6:57 PM Changeset in webkit [66318] by barraclough@apple.com
  • 17 edits in trunk

Bug 44830 - In Array's prototype functyions we're incorrectly handing large index values

Reviewed by Oliver Hunt.

We are in places casting doubles to unsigneds, and unsigneds to ints, without always check
that the result is within bounds. This is problematic in the case of double-to-unsigned
conversion because we should be saturating to array length.

Also, the error return value from Array.splice should be [], not undefined.

I don't see any security concerns here. These methods are spec'ed in such a way that they
can be applied to non Array objects, so in all cases the (potentially bogus) indices are
being passed to functions that will safely check accesses are within bounds.

JavaScriptCore:

  • runtime/ArrayPrototype.cpp:

(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

  • runtime/JSValue.h:

(JSC::JSValue::toUInt32):

LayoutTests:

  • fast/js/array-splice-expected.txt:
  • fast/js/script-tests/array-splice.js:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.10_Array_prototype_slice/S15.4.4.10_A3_T3-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.2_T3-expected.txt:
  • fast/js/sputnik/Implementation_Diagnostics/S15.4.4.12_D1.5_T1-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-3-26-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-3-27-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-5-1-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-5-12-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-5-14-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-5-16-expected.txt:
  • ietestcenter/Javascript/15.4.4.15-8-9-expected.txt:
  • platform/mac-snowleopard/Skipped:
5:30 PM Changeset in webkit [66317] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-08-28 Daniel Bates <dbates@rim.com>

Attempt to fix Chromium Mac Release bot after changeset 66305 <http://trac.webkit.org/changeset/66305>.

  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification): Added case statements for missing enum values. These case statements simply fall through to a "break" statement.
4:06 PM Changeset in webkit [66316] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Nikolas Zimmermann.

Add explicit destructor for C++ DOM bindings to avoid memory leaks when using SWIG.
https://bugs.webkit.org/attachment.cgi?bugid=44738

4:01 PM Changeset in webkit [66315] by kevino@webkit.org
  • 2 edits in trunk

Reviewed by Kevin Ollivier.

[BREWMP] Add build system
https://bugs.webkit.org/show_bug.cgi?id=44645

3:11 PM Changeset in webkit [66314] by kevino@webkit.org
  • 7 edits in trunk

[wx] Build fix after parseMode -> compatibilityMode rename.

1:10 PM Changeset in webkit [66313] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-08-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dan Bernstein.

Add WebM MIME types to type registry
https://bugs.webkit.org/show_bug.cgi?id=44826

  • platform/MIMETypeRegistry.cpp: (WebCore::TypeExtensionPair::): Add "video/webm" and "audio/webm" types.
12:34 PM Changeset in webkit [66312] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2010-08-28 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

fast/frames/frame-crash-with-page-cache.html does not pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=44813

Update test to not rely on intervals resuming when going back to a page
in the page cache. Based on the original bug for which this test was
added (34773), intervals were not part of the triggering condition.

  • fast/frames/resources/cached-page-1.html:
  • fast/frames/resources/cached-page-2.html:
  • platform/chromium/test_expectations.txt:
11:48 AM Changeset in webkit [66311] by eric.carlson@apple.com
  • 5 edits in trunk

2010-08-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Crash reloading fast/events/tabindex-focus-blur-all.html test
https://bugs.webkit.org/show_bug.cgi?id=44743

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::asyncEventTimerFired): If m_isWaitingToDecrementLoadEventDelayCount is true, call setShouldDelayLoadEvent(false) and set the timer to fire the pending events on the next idle. (WebCore::HTMLMediaElement::setShouldDelayLoadEvent): Don't clear the delay from within a media engine callback because document 'load' event handlers that cause the page to become inactive will delete the media engine.
  • html/HTMLMediaElement.h: Add m_isWaitingToDecrementLoadEventDelayCount.

2010-08-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Crash reloading fast/events/tabindex-focus-blur-all.html test
https://bugs.webkit.org/show_bug.cgi?id=44743

  • platform/mac/Skipped: Remove tabindex-focus-blur-all.html from the skip list.
10:38 AM Changeset in webkit [66310] by Simon Fraser
  • 5 edits in trunk/WebCore

2010-08-28 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

When properties are missing from animation keyframes, interpolate between those keyframes that specify them
https://bugs.webkit.org/show_bug.cgi?id=40794

Some preliminary cleanup; for vectors, prefer indexed access rather than using iterators.

No behavior changes.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::getKeyframeAnimationInterval): (WebCore::KeyframeAnimation::validateTransformFunctionList):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation):
  • rendering/style/KeyframeList.h: (WebCore::KeyframeList::at): (WebCore::KeyframeList::keyframes):
10:02 AM Changeset in webkit [66309] by mitz@apple.com
  • 2 edits in trunk/WebCore

Speculative fix for <rdar://problem/7275077> Crash in InlineBox::root() under RenderTextControl::textWithHardLineBreaks()
https://bugs.webkit.org/show_bug.cgi?id=44816

Reviewed by Simon Fraser.

No test because I could not reproduce the crash.

In a common variant of the crash, InlineBox::root() is called with this == 12. This suggests that
a RenderInline* was cast into a RenderBox*, so RenderBox::inlineBoxWrapper() interpreted the
m_lineHeight and m_verticalPosition members of a RenderInline as a pointer to an InlineBox.

The cast into RenderBox* in textWithHardLineBreaks() was introduced in r40881 with no exaplanation.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textWithHardLineBreaks): Fetch the first line directly from the inner
text block instead of relying on the first child being a text node.

9:56 AM Changeset in webkit [66308] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-28 Moritz Lipp <mlq@pwmt.org>

Reviewed by Xan Lopez.

[GTK] Improper webkit_dom_document_evaluate implementation.
https://bugs.webkit.org/show_bug.cgi?id=42115

The generated webkit_dom_document_evaluate() function does not meet the
evaluate interface described in the W3 Documentation
http://www.w3.org/TR/DOM-Level-3-XPath/xpath.html#XPathEvaluator-evaluate
"If this is specified as nullor the implementation does not reuse the
specified result,...". The current implementation did not accept the
result parameter to be NULL.

  • bindings/scripts/CodeGeneratorGObject.pm:
9:14 AM Changeset in webkit [66307] by dbates@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-08-28 Daniel Bates <dbates@rim.com>

Attempt to fix the Qt Windows and Qt Linux Release minimal builds
after changeset 66297 <http://trac.webkit.org/changeset/66297>.

  • Api/qwebplugindatabase.cpp: (QWebPluginDatabase::plugins): Wrap the call to PluginPackage::ensurePluginLoaded in #if ENABLE(NETSCAPE_PLUGIN_METADATA_CACHE).
2:43 AM Changeset in webkit [66306] by abarth@webkit.org
  • 22 edits in trunk

2010-08-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTreeBuilder needs to call HTMLFormElement::setDemoted
https://bugs.webkit.org/show_bug.cgi?id=44781

This patch teaches the HTMLTreeBuilder about demoted form elements.
Demoting a form element magically stops the form element from
rendering. Demoted form elements are a concept from the
LegacyHTMLTreeBuilder, but they are somewhat of a hack because
rendering should be DOM-based. We'll likely look for a better solution
in a future patch.

  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertHTMLFormElement):
  • html/parser/HTMLConstructionSite.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable):

2010-08-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTreeBuilder needs to call HTMLFormElement::setDemoted
https://bugs.webkit.org/show_bug.cgi?id=44781

Update test expectations to account for demoted form elements. I spot
checked a bunch of these and this change is the reverse of the change
to these expectations in http://trac.webkit.org/changeset/64712. At
the time, we thought these rendering changes were correct because the
DOM was correct. However, demoted form elements have magical
non-DOM-based rendering.

  • platform/mac/fast/forms/form-added-to-table-expected.txt:
  • platform/mac/fast/forms/formmove3-expected.txt:
  • platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/mac/fast/table/fixed-table-non-cell-in-row-expected.txt:
  • platform/mac/fast/table/inline-form-assert-expected.txt:
  • platform/mac/fast/table/insert-cell-before-form-expected.txt:
  • platform/mac/fast/table/insert-row-before-form-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2516-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug32447-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug34538-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96343-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
2:30 AM Changeset in webkit [66305] by commit-queue@webkit.org
  • 17 edits
    3 adds in trunk

2010-08-28 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472

Test by running platform/chromium/accessibility/children-changed-notification.html within chromium's DRT

  • platform/chromium/accessibility: Added.
  • platform/chromium/accessibility/children-changed-notification-expected.txt: Added.
  • platform/chromium/accessibility/children-changed-notification.html: Added.
  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:

2010-08-28 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472

Test by running platform/chromium/accessibility/children-changed-notification.html within chromium's DRT

  • accessibility/AXObjectCache.h: (WebCore::AXObjectCache::):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::childrenChanged):
  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
  • page/chromium/ChromeClientChromium.h:

2010-08-28 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472

  • public/WebViewClient.h: (WebKit::WebViewClient::didChangeAccessibilityObjectChildren):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::didChangeAccessibilityObjectChildren):
  • src/ChromeClientImpl.h:

2010-08-28 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Add AX notification for childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=44472

  • DumpRenderTree/chromium/AccessibilityController.cpp: (AccessibilityController::AccessibilityController): (AccessibilityController::reset): (AccessibilityController::getRootElement): (AccessibilityController::dumpAccessibilityNotifications):
  • DumpRenderTree/chromium/AccessibilityController.h: (AccessibilityController::shouldDumpAccessibilityNotifications):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didChangeAccessibilityObjectChildren):
  • DumpRenderTree/chromium/WebViewHost.h:
2:09 AM Changeset in webkit [66304] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-08-28 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Update commit-queue failure message
https://bugs.webkit.org/show_bug.cgi?id=44798

The commit-queue auto-restarts itself and has for a very long time.
No need for people to email me to request a restart anymore.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
1:49 AM Changeset in webkit [66303] by commit-queue@webkit.org
  • 8 edits
    2 copies in trunk/WebCore

2010-08-28 Eric Uhrhane <ericu@chromium.org>

Reviewed by Darin Fisher.

Implement the DOM FileWriter class
https://bugs.webkit.org/show_bug.cgi?id=44362

No new tests until the delegate class has an implementation; bug logged.

Build file additions.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

The AsyncFileWriter is an abstract interface to which FileWriter delegates all the hard work.

  • html/AsyncFileWriter.h: Added.

The FileWriterClient is the interface for communications back from the AsyncFileWriter [success/failure, progress events].

  • html/FileWriterClient.h: Added. (WebCore::FileWriterClient::~FileWriterClient):

Added all delegation, state tracking, and progress event processing.

  • html/FileWriter.cpp: (WebCore::FileWriter::FileWriter): (WebCore::FileWriter::initialize): (WebCore::FileWriter::~FileWriter): ActiveDomObject stuff (WebCore::FileWriter::hasPendingActivity): (WebCore::FileWriter::stop): (WebCore::FileWriter::write): FileWriter public interface (WebCore::FileWriter::seek): (WebCore::FileWriter::truncate): (WebCore::FileWriter::abort): FileWriterClient interface (WebCore::FileWriter::didWrite): (WebCore::FileWriter::didTruncate): (WebCore::FileWriter::didFail): Progress events (WebCore::FileWriter::fireEvent):
  • html/FileWriter.h:
1:31 AM Changeset in webkit [66302] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-28 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Dimitri Glazkov.

Preparatory patch to split libwebcore in multiple libraries.

Start with a webcore_prerequisites pseudo-target what will be the common
target for all the other ones.

  • WebCore.gyp/WebCore.gyp:
12:58 AM Changeset in webkit [66301] by commit-queue@webkit.org
  • 5 edits in trunk

2010-08-28 Pratik Solanki <psolanki@apple.com>

Reviewed by Dan Bernstein.

Add an ENABLE define for purgeable memory support
https://bugs.webkit.org/show_bug.cgi?id=44777

  • wtf/Platform.h:

2010-08-28 Pratik Solanki <psolanki@apple.com>

Reviewed by Dan Bernstein.

Add an ENABLE define for purgeable memory support
https://bugs.webkit.org/show_bug.cgi?id=44777

  • platform/PurgeableBuffer.h:
  • platform/mac/PurgeableBufferMac.cpp:
12:26 AM Changeset in webkit [66300] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-28 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Fix error message when theme loading fails
https://bugs.webkit.org/show_bug.cgi?id=44775

Parameters for logging were in the wrong order.

No new functionality so no new tests.

  • platform/efl/ScrollbarEfl.cpp: (ScrollbarEfl::setParent): exchange argument order in log function call

Aug 27, 2010:

11:56 PM Changeset in webkit [66299] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: some tests no longer painting
https://bugs.webkit.org/show_bug.cgi?id=44773

Fix regression from the RenderImageResource introduction, fast/canvas/canvas-as-image.html
and fast/canvas/canvas-as-image-incremental-repaint.html pixel tests did not work anymore.

  • rendering/RenderImageResource.h: (WebCore::RenderImageResource::hasImage): Make hasImage virtual.
  • rendering/RenderImageResourceStyleImage.h: (WebCore::RenderImageResourceStyleImage::hasImage): Always return true, just like RenderImageGeneratedContent did.
10:18 PM Changeset in webkit [66298] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-08-27 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Antonio Gomes.

[Qt] tst_QWebView::focusInputTypes() fails on MeeGo Handset with WebKit 2.1
https://bugs.webkit.org/show_bug.cgi?id=44761

Make the test more robust to changes in the execution environment. The click
are now correctly simulated, and the position are determined from the content.

The test also create the view and page on the stack to avoid the leak when the
test is failing.

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::focusInputTypes):
9:32 PM Changeset in webkit [66297] by commit-queue@webkit.org
  • 13 edits in trunk

2010-08-27 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] NPAPI Plugin metadata should be cached, and loading a plugin should not require loading every plugin
https://bugs.webkit.org/show_bug.cgi?id=43179

Add ENABLE_NETSCAPE_PLUGIN_METADATA_CACHE flag to enable persistent
NPAPI Plugin Cache. The flag is enabled by default.

  • wtf/Platform.h: Add ENABLE_NETSCAPE_PLUGIN_METADATA_CACHE

2010-08-27 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Cache plugin info to a persistent database

https://bugs.webkit.org/show_bug.cgi?id=43179

Implement a cache of NPAPI plugin metadata. Write the metadata to aa
file that gets rewritten if any plugin is added / removed. Compilation
of the feature is controlled by #if ENABLE(NETSCAPE_PLUGIN_METADATA_CACHE)

Currently only enabled for Qt UNIX flavors.

  • WebCore.pro: Enable NETSCAPE_PLUGIN_METADATA_CACHE for UNIX builds
  • platform/qt/FileSystemQt.cpp: (WebCore::openFile): Added. (WebCore::readFromFile): Added.
  • plugins/PluginDatabase.cpp: (WebCore::persistentPluginMetadataCachePath): Static accessor for the path (WebCore::PluginDatabase::PluginDatabase): Add instance variable. (WebCore::PluginDatabase::refresh): (WebCore::PluginDatabase::pluginForMIMEType): Ensure returned plugin is loaded. (WebCore::PluginDatabase::MIMETypeForExtension): Ensure returned plugin is loaded. (WebCore::PluginDatabase::clear): (WebCore::fillBufferWithContentsOfFile): Static helper function. (WebCore::readUTF8String): Static helper function. (WebCore::readTime): Static helper function. (WebCore::PluginDatabase::loadPersistentMetadataCache): (WebCore::writeUTF8String): Static helper function. (WebCore::writeTime): Static helper function. (WebCore::PluginDatabase::updatePersistentMetadataCache): Added. (WebCore::PluginDatabase::isPersistentMetadataCacheEnabled): Added. (WebCore::PluginDatabase::setPersistentMetadataCacheEnabled):Added. (WebCore::PluginDatabase::persistentMetadataCachePath): Added. (WebCore::PluginDatabase::setPersistentMetadataCachePath): Added.
  • plugins/PluginDatabase.h:
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::PluginPackage): Add instance variable. (WebCore::PluginPackage::createPackageFromCache): Added. (WebCore::PluginPackage::ensurePluginLoaded): Added.
  • plugins/PluginPackage.h: (WebCore::PluginPackage::fullMIMEDescription): Added.
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::fetchInfo): Split mime parsing. (WebCore::PluginPackage::setMIMEDescription): Added. Mime parsing.

2010-08-27 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Cache plugin info to a persistent database

https://bugs.webkit.org/show_bug.cgi?id=43179

Implement a cache of NPAPI plugin metadata. Write the metadata to aa
file that gets rewritten if any plugin is added / removed. Compilation
of the feature is controlled by #if ENABLE(NETSCAPE_PLUGIN_METADATA_CACHE)

Currently only enabled for Qt UNIX flavors.

  • Api/qwebplugindatabase.cpp: (QWebPluginDatabase::plugins): Match previous behavior: ensure all returned plugins are loaded.
  • Api/qwebsettings.cpp: (QWebSettings::enablePersistentStorage): Set plugin cache path.
8:06 PM Changeset in webkit [66296] by dbates@webkit.org
  • 7 edits
    2 adds in trunk

2010-08-27 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Implement symbolic CSS3 list-style-types
https://bugs.webkit.org/show_bug.cgi?id=36734

Implements all of the symbolic CSS3 list-style-types as per
section 4.5 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#symbolic>.

Test: fast/lists/w3-css3-list-styles-symbolic.html

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added list style types Asterisks and Footnotes.
  • css/CSSValueKeywords.in: Ditto.
  • inspector/front-end/SourceCSSTokenizer.re2js: Ditto.
  • rendering/RenderListMarker.cpp: (WebCore::toAlphabeticOrNumeric): Changed type of parameter sequenceSize from int to unsigned. (WebCore::toSymbolic): Added. (WebCore::toAlphabetic): Changed type of parameter alphabetSize from int to unsigned. (WebCore::toNumeric): Changed type of parameter numeralsSize from int to unsigned. (WebCore::effectiveListMarkerType): Added. (WebCore::listMarkerSuffix): Added list style types Asterisks and Footnotes. (WebCore::listMarkerText): Ditto. (WebCore::RenderListMarker::paint): Ditto. (WebCore::RenderListMarker::calcPrefWidths): Ditto. (WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
  • rendering/style/RenderStyleConstants.h: Ditto. (WebCore::):

2010-08-27 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Implement symbolic CSS3 list-style-types
https://bugs.webkit.org/show_bug.cgi?id=36734

Tests that all of the symbolic CSS3 list-style-types are supported.

  • fast/lists/w3-css3-list-styles-symbolic-expected.txt: Added.
  • fast/lists/w3-css3-list-styles-symbolic.html: Added.
8:01 PM Changeset in webkit [66295] by commit-queue@webkit.org
  • 6 edits in trunk/WebCore

2010-08-27 Vincent Scheib <scheib@chromium.org>

Reviewed by Darin Fisher.

CanvasRenderingContext2D::willDraw changed to didDraw

Solves issue with canvas to canvas draw calls, and simplifies
mixed software and GPU acceleration of GraphicsContext implementations
which must track dirty rects for backing stores.

https://bugs.webkit.org/show_bug.cgi?id=44741

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::didDraw):
  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect): (WebCore::CanvasRenderingContext2D::didDraw): (WebCore::CanvasRenderingContext2D::putImageData): (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::markContextChanged):
7:41 PM Changeset in webkit [66294] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-08-27 Matthew Delaney <mdelaney@apple.com>

Reviewed by Oliver Hunt.

Canvas test 2d.composite.operation.clear failing
https://bugs.webkit.org/show_bug.cgi?id=43226

  • canvas/philip/tests/2d.composite.operation.foobar.html: Added. Tests if bogus composite ops are ignored.
  • platform/mac/Skipped: Added comment about why original clear test should remain on the skip list.
7:25 PM Changeset in webkit [66293] by commit-queue@webkit.org
  • 5 edits in trunk

2010-08-27 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Add new WebClipboard method for setting generic data in copy/cut handlers.
https://bugs.webkit.org/show_bug.cgi?id=42121

No new tests.

  • platform/chromium/ChromiumBridge.h:

2010-08-27 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Add new WebClipboard method for setting generic data in copy/cut handlers.
https://bugs.webkit.org/show_bug.cgi?id=42121

  • public/WebClipboard.h: (WebKit::WebClipboard::writeData): (WebKit::WebClipboard::readFilenames):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::clipboardWriteData):
7:16 PM Changeset in webkit [66292] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Add UserContent API to WebKit2 InjectedBundle
<rdar://problem/8367587>
https://bugs.webkit.org/show_bug.cgi?id=44810

Reviewed by Dan Bernstein.

The new API differs from the version in WebKit1 in that the function do not take
a group name since we currently do not expose a way to make multiple PageGroups in
the API.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(toUserScriptInjectionTime):
(toUserContentInjectedFrames):
Add conversion functions for enums.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleAddUserScript):
(WKBundleAddUserStyleSheet):
(WKBundleRemoveUserScript):
(WKBundleRemoveUserStyleSheet):
(WKBundleRemoveUserScripts):
(WKBundleRemoveUserStyleSheets):
(WKBundleRemoveAllUserContent):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::toStringVector):
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):

  • WebProcess/InjectedBundle/InjectedBundle.h:

Forward API to PageGroup.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::sharedPageGroup):
(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):

  • WebProcess/WebProcess.h: Ad accessor for global PageGroup.
6:58 PM Changeset in webkit [66291] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-27 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

Remove unnecessary AlphaBlend in PasteboardWin.
https://bugs.webkit.org/show_bug.cgi?id=44720

Replacing AlphaBlend with BitBlt is safe because testing showed that alpha
never survives copy-and-paste on Windows in any browser, and StretchBlt
was a overkill since the source and destination size are always equal.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
6:46 PM Changeset in webkit [66290] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-27 Tony Chang <tony@chromium.org>

Not reviewed, adding two more files to chromium's test_expectations.

  • platform/chromium/test_expectations.txt:
6:21 PM Changeset in webkit [66289] by jhoneycutt@apple.com
  • 2 edits in trunk/LayoutTests

Add tests to the WebKit2 skipped list.

Rubber-stamped by Brady Eidson.

  • platform/mac-wk2/Skipped:
6:05 PM Changeset in webkit [66288] by zmo@google.com
  • 5 edits in trunk

2010-08-26 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
https://bugs.webkit.org/show_bug.cgi?id=38282

  • platform/graphics/skia/GraphicsContext3DSkia.cpp: Dealing with the case of texImage2D with HTMLCanvasElement input. (WebCore::GraphicsContext3D::getImageData):

2010-08-26 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
https://bugs.webkit.org/show_bug.cgi?id=38282

  • fast/canvas/webgl/gl-teximage-expected.txt: Adding back the tests using canvas as texImage2D input.
  • fast/canvas/webgl/gl-teximage.html: Ditto.
5:57 PM Changeset in webkit [66287] by vangelis@chromium.org
  • 2 edits in trunk/WebCore

2010-08-26 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

[chromium] Working around compile issue in LayerRendererChromium.cpp
when DEBUG_GL_CALLS=1
https://bugs.webkit.org/show_bug.cgi?id=44739

No new functionality, no new tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayerIntoStencilBuffer):
5:54 PM Changeset in webkit [66286] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-27 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Port SoftLinking to WinCE
https://bugs.webkit.org/show_bug.cgi?id=44693

WinCE provides GetProcAddressW and GetProcAddressA for softlinking.
Unfortunately WinNT provides only GetProcAddress (without A or W).

Add a platform dependent macro for GetProcAddress.

  • platform/win/SoftLinking.h:
5:44 PM Changeset in webkit [66285] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-08-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] ScrollbarThemeGtk should account for the trough_under_steppers property
https://bugs.webkit.org/show_bug.cgi?id=44742

No new tests until this code is activated, at which point pixel tests will
test the scrollbar rendering.

  • platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::paintTrackBackground): Only inflate the track background if the style specifies trough_under_steppers. (WebCore::ScrollbarThemeGtk::paint): If the theme specifies trough_under_steppers, a dirty stepper also triggers a repaint of the trough region.
5:23 PM Changeset in webkit [66284] by Joseph Pecoraro
  • 4 edits
    4 adds in trunk

2010-08-27 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Alexey Proskuryakov.

LayoutTests:

2010-08-27 Joseph Pecoraro <Joseph Pecoraro>

Extra Events triggered by <input> on focus
https://bugs.webkit.org/show_bug.cgi?id=44731

  • fast/events/input-focus-no-duplicate-events-expected.txt: Added.
  • fast/events/input-focus-no-duplicate-events.html: Added.
  • fast/events/input-tab-focus-no-duplicate-events-expected.txt: Added.
  • fast/events/input-tab-focus-no-duplicate-events.html: Added.

WebCore:

2010-08-27 Joseph Pecoraro <Joseph Pecoraro>

Extra Events triggered by <input> on focus
https://bugs.webkit.org/show_bug.cgi?id=44731

Tests: fast/events/input-focus-no-duplicate-events.html

fast/events/input-tab-focus-no-duplicate-events.html

  • dom/Element.cpp: (WebCore::Element::focus): do not continue and update the appearance of the element if it was not focused.
  • page/FocusController.cpp: (WebCore::FocusController::setFocusedNode): respect the return value of Document::setFocusedNode.
5:16 PM Changeset in webkit [66283] by eric.carlson@apple.com
  • 3 edits
    2 copies in trunk/LayoutTests

2010-08-27 Eric Carlson <eric.carlson@apple.com>

Unreviewed, build fix.

Copy video files back into http/tests/media/resources/ since some tests apparently
can't load from test/resources/. Sigh.

  • http/tests/media/resources/test.mp4: Copied from LayoutTests/http/tests/resources/test.mp4.
  • http/tests/media/resources/test.ogv: Copied from LayoutTests/http/tests/resources/test.ogv.
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-referer.html:
5:08 PM Changeset in webkit [66282] by Joseph Pecoraro
  • 7 edits in trunk

2010-08-26 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

LayoutTests:

2010-08-26 Joseph Pecoraro <Joseph Pecoraro>

Web Inspector: attribute nodes don't get rendered in the console
https://bugs.webkit.org/show_bug.cgi?id=44736

Add formatting tests for attribute nodes.

  • inspector/console-format-expected.txt:
  • inspector/console-format.html:

WebCore:

2010-08-26 Joseph Pecoraro <Joseph Pecoraro>

Web Inspector: attribute nodes don't get rendered in the console
https://bugs.webkit.org/show_bug.cgi?id=44736

Extended Test: inspector/console-format.html

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode): add "name" and "value" properties for Attribute nodes.
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): add "name" and "value" properties for Attribute nodes.
  • inspector/front-end/ElementsTreeOutline.js: display html for Attribute nodes.
5:05 PM Changeset in webkit [66281] by barraclough@apple.com
  • 1 edit
    18 adds in trunk/SunSpider

Added version 5 and version 6 of V8 tests with modifications similar
to the version 4 tests so they'll work with the SunSpider test harness.
Note that these files are external source and therefore don't conform
to WebKit coding standards.
https://bugs.webkit.org/show_bug.cgi?id=44638

Patch by Michael Saboff <msaboff@apple.com> on 2010-08-27
Reviewed by Stephanie Lewis.

  • tests/v8-v5: Added.
  • tests/v8-v5/LIST: Added.
  • tests/v8-v5/v8-crypto.js: Added.
  • tests/v8-v5/v8-deltablue.js: Added.
  • tests/v8-v5/v8-earley-boyer.js: Added.
  • tests/v8-v5/v8-raytrace.js: Added.
  • tests/v8-v5/v8-regexp.js: Added.
  • tests/v8-v5/v8-richards.js: Added.
  • tests/v8-v5/v8-splay.js: Added.
  • tests/v8-v6: Added.
  • tests/v8-v6/LIST: Added.
  • tests/v8-v6/v8-crypto.js: Added.
  • tests/v8-v6/v8-deltablue.js: Added.
  • tests/v8-v6/v8-earley-boyer.js: Added.
  • tests/v8-v6/v8-raytrace.js: Added.
  • tests/v8-v6/v8-regexp.js: Added.
  • tests/v8-v6/v8-richards.js: Added.
  • tests/v8-v6/v8-splay.js: Added.
4:59 PM Changeset in webkit [66280] by kinuko@chromium.org
  • 5 edits
    3 adds in trunk/WebKit/chromium

2010-08-27 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

[chromium] Add chromium-side of AsyncFileSystem implementation
https://bugs.webkit.org/show_bug.cgi?id=44434

  • WebKit.gyp:
  • src/AssertMatchingEnums.cpp: Added assertions.
  • src/AsyncFileSystemChromium.cpp: Added.
  • src/AsyncFileSystemChromium.h: Added.
  • src/LocalFileSystemChromium.cpp: Added.
  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl):
  • src/WebFileSystemCallbacksImpl.h:
4:56 PM Changeset in webkit [66279] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Move WKBundle didCreatePage callback to outside the WebPage
constructor to avoid adoptRef errors.

Reviewed by Gavin Barraclough.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::create):
(WebKit::WebPage::WebPage):

4:55 PM Changeset in webkit [66278] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

2010-08-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; chromium rebaseline for r66247.

  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
4:46 PM Changeset in webkit [66277] by abarth@webkit.org
  • 12 edits
    25 moves in trunk/WebCore

2010-08-27 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Finshing moving the HTML parser into WebCore/html/parser.

  • Android.derived.mk:
  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/CSSPreloadScanner.cpp: Removed.
  • html/CSSPreloadScanner.h: Removed.
  • html/HTMLConstructionSite.cpp: Removed.
  • html/HTMLConstructionSite.h: Removed.
  • html/HTMLDocumentParser.cpp: Removed.
  • html/HTMLDocumentParser.h: Removed.
  • html/HTMLEntityNames.json: Removed.
  • html/HTMLEntityParser.cpp: Removed.
  • html/HTMLEntityParser.h: Removed.
  • html/HTMLEntitySearch.cpp: Removed.
  • html/HTMLEntitySearch.h: Removed.
  • html/HTMLEntityTable.h: Removed.
  • html/HTMLFormattingElementList.cpp: Removed.
  • html/HTMLFormattingElementList.h: Removed.
  • html/HTMLParserScheduler.cpp: Removed.
  • html/HTMLParserScheduler.h: Removed.
  • html/HTMLPreloadScanner.cpp: Removed.
  • html/HTMLPreloadScanner.h: Removed.
  • html/HTMLScriptRunner.cpp: Removed.
  • html/HTMLScriptRunner.h: Removed.
  • html/HTMLScriptRunnerHost.h: Removed.
  • html/HTMLTokenizer.cpp: Removed.
  • html/HTMLTokenizer.h: Removed.
  • html/HTMLViewSourceParser.cpp: Removed.
  • html/HTMLViewSourceParser.h: Removed.
  • html/parser/CSSPreloadScanner.cpp: Copied from WebCore/html/CSSPreloadScanner.cpp.
  • html/parser/CSSPreloadScanner.h: Copied from WebCore/html/CSSPreloadScanner.h.
  • html/parser/HTMLConstructionSite.cpp: Copied from WebCore/html/HTMLConstructionSite.cpp.
  • html/parser/HTMLConstructionSite.h: Copied from WebCore/html/HTMLConstructionSite.h.
  • html/parser/HTMLDocumentParser.cpp: Copied from WebCore/html/HTMLDocumentParser.cpp.
  • html/parser/HTMLDocumentParser.h: Copied from WebCore/html/HTMLDocumentParser.h.
  • html/parser/HTMLEntityNames.json: Copied from WebCore/html/HTMLEntityNames.json.
  • html/parser/HTMLEntityParser.cpp: Copied from WebCore/html/HTMLEntityParser.cpp.
  • html/parser/HTMLEntityParser.h: Copied from WebCore/html/HTMLEntityParser.h.
  • html/parser/HTMLEntitySearch.cpp: Copied from WebCore/html/HTMLEntitySearch.cpp.
  • html/parser/HTMLEntitySearch.h: Copied from WebCore/html/HTMLEntitySearch.h.
  • html/parser/HTMLEntityTable.h: Copied from WebCore/html/HTMLEntityTable.h.
  • html/parser/HTMLFormattingElementList.cpp: Copied from WebCore/html/HTMLFormattingElementList.cpp.
  • html/parser/HTMLFormattingElementList.h: Copied from WebCore/html/HTMLFormattingElementList.h.
  • html/parser/HTMLParserScheduler.cpp: Copied from WebCore/html/HTMLParserScheduler.cpp.
  • html/parser/HTMLParserScheduler.h: Copied from WebCore/html/HTMLParserScheduler.h.
  • html/parser/HTMLPreloadScanner.cpp: Copied from WebCore/html/HTMLPreloadScanner.cpp.
  • html/parser/HTMLPreloadScanner.h: Copied from WebCore/html/HTMLPreloadScanner.h.
  • html/parser/HTMLScriptRunner.cpp: Copied from WebCore/html/HTMLScriptRunner.cpp.
  • html/parser/HTMLScriptRunner.h: Copied from WebCore/html/HTMLScriptRunner.h.
  • html/parser/HTMLScriptRunnerHost.h: Copied from WebCore/html/HTMLScriptRunnerHost.h.
  • html/parser/HTMLTokenizer.cpp: Copied from WebCore/html/HTMLTokenizer.cpp.
  • html/parser/HTMLTokenizer.h: Copied from WebCore/html/HTMLTokenizer.h.
  • html/parser/HTMLViewSourceParser.cpp: Copied from WebCore/html/HTMLViewSourceParser.cpp.
  • html/parser/HTMLViewSourceParser.h: Copied from WebCore/html/HTMLViewSourceParser.h.
4:42 PM Changeset in webkit [66276] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-27 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium test expectations.

Aaron said it's ok to add userscripts/mixed-case-stylesheet.html to
the expected failure list because we test these in chromium anyway.

  • platform/chromium/test_expectations.txt:
4:36 PM Changeset in webkit [66275] by cmarrin@apple.com
  • 2 adds in trunk/WebKitSite/blog-files/webgl/resources

Forgot to add new WebGL demo support files

4:33 PM Changeset in webkit [66274] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

2010-08-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; rebaseline for r66247.

  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
4:31 PM Changeset in webkit [66273] by cmarrin@apple.com
  • 7 edits
    2 deletes in trunk/WebKitSite/blog-files/webgl

Updated WebGL blog files for latest WebKit implementation

4:17 PM Changeset in webkit [66272] by mrowe@apple.com
  • 1 copy in tags/Safari-534.6.2

New tag.

4:14 PM Changeset in webkit [66271] by eric.carlson@apple.com
  • 10 edits
    2 moves
    1 delete in trunk/LayoutTests

2010-08-27 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Allow ports to use different test movies.
https://bugs.webkit.org/show_bug.cgi?id=44799

Move test movies from http/tests/media/resources to http/tests/resources. Change
local-video-source-from-remote to load a movie supported by the platform and to
not log movie name.

  • http/tests/media/resources/test.mp4: Removed.
  • http/tests/media/resources/test.ogv: Removed.
  • http/tests/media/video-cancel-load.html:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-error-abort.html:
  • http/tests/media/video-load-twice.html:
  • http/tests/media/video-play-suspend.html:
  • http/tests/media/video-referer.html:
  • http/tests/resources/silence.mpg: Removed.
  • http/tests/resources/test.mp4: Copied from LayoutTests/http/tests/media/resources/test.mp4.
  • http/tests/resources/test.ogv: Copied from LayoutTests/http/tests/media/resources/test.ogv.
  • http/tests/security/local-video-source-from-remote-expected.txt:
  • http/tests/security/local-video-source-from-remote.html:
  • media/video-source-error.html:
3:50 PM Changeset in webkit [66270] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

2010-08-27 Eric Carlson <eric.carlson@apple.com>

Rubber-stamped Simon Fraser.

Set svn mime-type on two test movies.

  • http/tests/media/resources/test.mp4: Added property svn:mime-type.
  • http/tests/media/resources/test.ogv: Added property svn:mime-type.
3:50 PM Changeset in webkit [66269] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-08-27 Simon Fraser <Simon Fraser>

Reviewed by Tony Chang.

Insertion point does not show when dragging text into an editable area
https://bugs.webkit.org/show_bug.cgi?id=44295

r65681 caused the caret to use the last-computed caret rect when
painting, rather than forcing a style update. Because of this,
we now need to eagerly update the caret rect when changing
the drag selection.

Not testable in DRT because the drag selection is always cleared
before EventSender returns, so the drag caret can never show in
the pixel results.

Tested by running editing/selection/drag-in-iframe.html manually.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
3:42 PM Changeset in webkit [66268] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-27 Adam Barth <abarth@webkit.org>

Attempt to fix the Windows build.

  • WebCore.vcproj/WebCoreCommon.vsprops:
3:38 PM Changeset in webkit [66267] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Build fix only, not reviewed.

In review for https://bugs.webkit.org/show_bug.cgi?id=43099, a few
necessary testing functions were removed.

  • fullscreen/full-screen-test.js:

(waitForEventAndTest._eventCallback):
(waitForEventAndTest):
(waitForEventTestAndEnd):

3:32 PM Changeset in webkit [66266] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-27 Adam Barth <abarth@webkit.org>

Attempt to fix the Qt build.

  • WebCore.pro:
3:25 PM Changeset in webkit [66265] by abarth@webkit.org
  • 8 edits
    4 moves in trunk/WebCore

2010-08-27 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move HTMLTreeBuilder and HTMLElementStack to WebCore/html/parser.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementStack.cpp: Removed.
  • html/HTMLElementStack.h: Removed.
  • html/HTMLTreeBuilder.cpp: Removed.
  • html/HTMLTreeBuilder.h: Removed.
  • html/parser/HTMLElementStack.cpp: Copied from WebCore/html/HTMLElementStack.cpp.
  • html/parser/HTMLElementStack.h: Copied from WebCore/html/HTMLElementStack.h.
  • html/parser/HTMLTreeBuilder.cpp: Copied from WebCore/html/HTMLTreeBuilder.cpp.
  • html/parser/HTMLTreeBuilder.h: Copied from WebCore/html/HTMLTreeBuilder.h.
2:58 PM Changeset in webkit [66264] by abarth@webkit.org
  • 9 edits
    1 move
    1 add in trunk/WebCore

2010-08-27 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Create WebCore/html/parser
https://bugs.webkit.org/show_bug.cgi?id=44792

This patch begins the process of moving the HTML parser code to the
WebCore/html/parser directory. This patch moves a single header file.
More files will follow in future patches.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLToken.h: Renamed from WebCore/html/HTMLToken.h.
2:54 PM Changeset in webkit [66263] by mrowe@apple.com
  • 193 edits
    4 deletes in tags/Safari-534.6.1

Roll out r66156.

2:53 PM Changeset in webkit [66262] by mrowe@apple.com
  • 5 edits in tags/Safari-534.6.1

Versioning.

2:51 PM Changeset in webkit [66261] by tony@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

2010-08-27 Tony Chang <tony@chromium.org>

Not reviewed, updating chromium test expectations after r66251.

  • platform/chromium/Skipped: Removed.
  • platform/chromium/fast/dom/domListEnumeration-expected.txt:
  • platform/chromium/test_expectations.txt:
2:45 PM Changeset in webkit [66260] by beidson@apple.com
  • 2 edits in trunk/WebKit2

<rdar://problem/8147879> - Null URL passed to WebKit2 HistoryDelegate

Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): WK2 now loads initial about:blank document's synchronously,

without consulting the policy delegate.

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.

2:36 PM Changeset in webkit [66259] by mrowe@apple.com
  • 1 copy in tags/Safari-534.6.1

New tag.

2:35 PM Changeset in webkit [66258] by cmarrin@apple.com
  • 4 edits
    9 adds in trunk

2010-08-27 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=42862
WebGL in CSS Canvas crashes

This fixes the crash, which was a simple null pointer deref. But this
revealed that -webkit-canvas no longer works for WebGL. I believe this
is due to the recent ImageBuffer optimizations done by Dave Hyatt
(https://bugs.webkit.org/show_bug.cgi?id=43507). This changed ImageBuffer
from always keeping a copy of the pixels to doing a copy to get them
when needed. Since We need to get pixels out of the WebGL drawing buffer
to use them as a CSS background, I had to change when I return those
pixels to the ImageBuffer.

Tests: fast/canvas/webgl/css-webkit-canvas-repaint.html

fast/canvas/webgl/css-webkit-canvas.html

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::copiedImage): Add logic to get image from WebGL so it works with new ImageBuffer logic (see above)
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): Fixed null pointer deref
2:22 PM Changeset in webkit [66257] by tony@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-08-27 Tony Chang <tony@chromium.org>

Not reviewed, cleaning up chromium test results.

After r66245, JSC and V8 produce the same results for fast/js/kde/Number.html.

  • platform/chromium-mac/fast/js/kde/Number-expected.txt: Removed.
  • platform/chromium-win/fast/js/kde/Number-expected.txt: Removed.
2:18 PM Changeset in webkit [66256] by jamesr@google.com
  • 3 edits
    2 copies
    1 move
    3 adds
    1 delete in trunk/WebCore

2010-08-27 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Move Shader class from platform/graphics/chromium to platform/graphics/gpu
https://bugs.webkit.org/show_bug.cgi?id=44793

The Shader class and its subclasses are not chromium-specific. This moves
them to a common location so they can be re-used on all platforms. Also
moves the Shader subclasses into their own .h/.cpp files.

Refactor, no new tests.

  • WebCore.gypi:
  • platform/graphics/chromium/GLES2Canvas.cpp:
  • platform/graphics/chromium/Shader.cpp: Removed.
  • platform/graphics/chromium/Shader.h: Removed.
  • platform/graphics/gpu/Shader.cpp: Added. (WebCore::Shader::affineTo3x3): (WebCore::Shader::loadShader): (WebCore::Shader::loadProgram): (WebCore::Shader::Shader): (WebCore::Shader::~Shader):
  • platform/graphics/gpu/Shader.h: Added.
  • platform/graphics/gpu/SolidFillShader.cpp: Added. (WebCore::SolidFillShader::SolidFillShader): (WebCore::SolidFillShader::create): (WebCore::SolidFillShader::use):
  • platform/graphics/gpu/SolidFillShader.h: Added.
  • platform/graphics/gpu/TexShader.cpp: Added. (WebCore::TexShader::TexShader): (WebCore::TexShader::create): (WebCore::TexShader::use):
  • platform/graphics/gpu/TexShader.h: Added.
2:15 PM Changeset in webkit [66255] by kinuko@chromium.org
  • 13 edits
    5 adds in trunk

2010-08-27 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Darin Fisher.

Add AsyncFileSystem interface for platform-dependent FileSystem API implementation
https://bugs.webkit.org/show_bug.cgi?id=44433

No new tests; tests will be added later.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/AsyncFileSystem.cpp: Added.
  • platform/AsyncFileSystem.h: Added.
  • platform/AsyncFileSystemCallbacks.h: Added.
  • storage/DOMFileSystem.cpp: (WebCore::DOMFileSystem::DOMFileSystem): (WebCore::DOMFileSystem::~DOMFileSystem): (WebCore::DOMFileSystem::stop): (WebCore::DOMFileSystem::hasPendingActivity): (WebCore::DOMFileSystem::contextDestroyed):
  • storage/DOMFileSystem.h: (WebCore::DOMFileSystem::create):
  • storage/FileSystemCallbacks.cpp: (WebCore::FileSystemCallbacksBase::didFail): (WebCore::FileSystemCallbacks::FileSystemCallbacks): (WebCore::FileSystemCallbacks::didOpenFileSystem):
  • storage/FileSystemCallbacks.h:
  • storage/LocalFileSystem.cpp: Added.
  • storage/LocalFileSystem.h: Added.
  • storage/Flags.h: Nits fix.
2:11 PM Changeset in webkit [66254] by aestes@apple.com
  • 14 edits in trunk/LayoutTests

Try to make some xssAuditor tests less flakey.
https://bugs.webkit.org/show_bug.cgi?id=44749

Reviewed by Simon Fraser.

Use postMessage() to communicate to the top window each time a
beforeload event fires in the iframe. When the top window has seen a
beforeload event from each widget in the iframe, it calls notifyDone().
This prevents the test from exiting before all the widgets have had a
chance to load, therefore ensuring that all relevant XSS Auditor
messages have been emitted.

  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-control-char.html:
  • http/tests/security/xssAuditor/object-embed-tag-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-null-char.html:
  • http/tests/security/xssAuditor/object-embed-tag.html:
  • http/tests/security/xssAuditor/object-src-inject.html:
  • http/tests/security/xssAuditor/object-tag-javascript-url.html:
  • http/tests/security/xssAuditor/object-tag.html:
  • http/tests/security/xssAuditor/resources/echo-intertag.pl:
  • http/tests/security/xssAuditor/resources/echo-object-src.pl:
  • http/tests/security/xssAuditor/resources/utilities.js:

(notifyDoneAfterReceivingBeforeloadFromIds):

  • platform/mac/Skipped:
2:06 PM Changeset in webkit [66253] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

2:06 PM Changeset in webkit [66252] by mrowe@apple.com
  • 1 copy in tags/Safari-534.6

New tag.

1:49 PM Changeset in webkit [66251] by jer.noble@apple.com
  • 47 edits
    18 adds in trunk

2010-07-27 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Add JavaScript API to allow a page to go fullscreen.
rdar://problem/6867795
https://bugs.webkit.org/show_bug.cgi?id=43099

  • wtf/Platform.h: Enable FULLSCREEN_API mode for the Mac (except iOS).

2010-07-27 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Add JavaScript API to allow a page to go fullscreen.
rdar://problem/6867795

Added chrome client overrides which support entering and exiting full screen. A new preference has
been added (setFullScreenEnabled:) to control at runtime whether full screen support is enabled
(defaults to disabled). Added a new WebKitFullScreenListener callback object which notifies WebCore
when the chrome has started/finished its full screen animation.

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::supportsFullscreenForElement): (WebChromeClient::enterFullscreenForElement): (WebChromeClient::exitFullscreenForElement): (-[WebKitFullScreenListener initWithElement:]): (-[WebKitFullScreenListener webkitWillEnterFullScreen]): (-[WebKitFullScreenListener webkitDidEnterFullScreen]): (-[WebKitFullScreenListener webkitWillExitFullScreen]): (-[WebKitFullScreenListener webkitDidExitFullScreen]):
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setFullScreenEnabled:]): (-[WebPreferences fullScreenEnabled]):
  • WebView/WebUIDelegatePrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2010-07-27 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Add JavaScript API to allow a page to go fullscreen.
rdar://problem/6867795
https://bugs.webkit.org/show_bug.cgi?id=43099


Mozilla has proposed a new set of JavaScript APIs which allow any element in
a document to go full-screen. The current revision of their proposal can be
found here:
<https://wiki.mozilla.org/index.php?title=Gecko:FullScreenAPI&oldid=243429>


The proposed specification includes the following:


Document:

  • Three new methods on Document:

+ void requestFullScreen()
+ void requestFullScreenWithKeys()
+ void cancelFullScreen()

  • Three new attributes of Document:

+ readonly attribute boolean fullScreen
+ readonly attribute boolean fullScreenWithKeys
+ (optional) readonly attribute Element currentFullScreenElement


Element:

  • Two new methods on Element:

+ void requestFullScreen()
+ void requestFullScreenWithKeys()


Events:

  • One new event:

+ fullScreenChange


CSS Pseudo-classes:

  • Three new Pseudo-classes:

+ :full-screen
+ :full-screen-doc
+ :full-screen-root-with-target


For WebKit's initial implementation, all the above new APIs will be prefixed with
"webkit" or "-webkit" where appropriate.


New tests:
LayoutTests/fullscreen/full-screen-api.html
LayoutTests/fullscreen/full-screen-css.html
LayoutTests/fullscreen/full-screen-request.html

Project file changes:

  • Configurations/FeatureDefines.xcconfig: Added an ENABLE_FULLSCREEN_API entry.
  • DerivedSources.make: Added rules for fullscreen.css and WebCore.FullScreen.exp.
  • WebCore.FullScreen.exp: Added export symbols for Document and Element functions.
  • WebCore.xcodeproj/project.pbxproj: New source files added to the project.

IDL changes:

  • dom/Document.idl: Added the new full-screen API to the Document's javascript interface.
  • dom/Element.idl: Added the new full-screen API to the Element's javascript interface.

Source changes:

  • bindings/objc/PublicDOMInterfaces.h: Exposed Document and Element fullscreen functions in the DOM classes.
  • css/CSSSelector.cpp: Added new FullScreen pseudo-classes.
  • css/CSSSelector.h: Added new full-screen pseudo classes to the PseudoType enum.
  • css/CSSStyleSelector.cpp: (WebCore::loadFullDefaultStyle): Pull the fullscreen.css sheet into the defaultStyle and the defaultQuirksStyle sheets. (WebCore::loadSimpleDefaultStyle): Pull the fullscreen.css sheet into the defaultStyle sheet. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Check for the new FullScreen pseudo classes.
  • dom/Document.cpp: (WebCore::Document::createEvent): Support creating a "WebKitFullScreenChange" event. (WebCore::Document::addListenerTypeIfNeeded): Support listening for a "webKitFullScreenChangeEvent" (WebCore::Document::webkitRequestFullScreenForElement): Passes request to the chrome client to enter full screen mode. (WebCore::Document::webkitCancelFullScreen): Passes request to the chrome client to exit full screen mode. (WebCore::Document::webkitWillEnterFullScreenForElement): Sets the FullScreen pseudo-classes on the full-screen element and its document. (WebCore::Document::webkitDidEnterFullScreenForElement): Currently a no-op. (WebCore::Document::webkitWillExitFullScreenForElement): Currently a no-op. (WebCore::Document::webkitDidExitFullScreenForElement): Clears the FullScreen pseudo-classes on the full-screen element and its document.
  • dom/Document.h: Added const accessors for new full-screen instance variables. (WebCore::Document::): (WebCore::Document::webkitIsFullScreen): Accessor for m_isFullScreen. (WebCore::Document::webkitIsFullScreenWithKeysEnabled): Accessor for m_isFullScren and m_areKeysEnabled. (WebCore::Document::webkitCurrentFullScreenElement): Accessor for m_fullScreenElement.
  • dom/Element.cpp: (WebCore::Element::webkitRequestFullScreen): Calls Document::webkitRequestFullScreenForElement.
  • dom/Element.h:
  • dom/EventNames.h: Add a webkitfullscreenchange event name.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): Parse the new "onwebkitfullscreenchange" attribute and register a listener.
  • page/ChromeClient.h: (WebCore::ChromeClient::supportsFullscreenForElement): Pass through to the current UI delegate. (WebCore::ChromeClient::enterFullscreenForElement): Create a WebKitFullScreenListener and pass through to the current UI delegate. (WebCore::ChromeClient::exitFullscreenForElement): Create a WebKitFullScreenListener and pass through to the current UI delegate.
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: Add a new setting to control runtime support for full screen mode (defaults to off)
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): The full screen button now toggles full screen mode (previously, it only entered).
  • rendering/style/RenderStyleConstants.h: Added new style constants.

2010-08-09 Jer Noble <jer.noble@apple.com>

Add JavaScript API to allow a page to go fullscreen.
rdar://problem/6867795
https://bugs.webkit.org/show_bug.cgi?id=43099

New tests for the new full screen API:

full-screen-api.html: tests for the presence of the new full screen

apis.

full-screen-request.html: tests that clients can request the browser

enter full screen mode successfully.

full-screen-css.html: tests that the new full screen pseudo classes are

applied once full screen mode is entered.

full-screen-remove.html: tests that the document's current full screen

element is changed when that element is removed from the DOM tree.

full-screen-remove-ancestor.html: tests that the document's current full

screen element is changed an ancestor of that element is removed
from the DOM tree.

full-screen-twice.html: tests that entering full screen mode on two

different elements in a row does not fail.


Tests that were changed:


domListEnumeration.html: This test returns a specific count of

properties on HTML elements; after consultation with Sam Weinig (the
original test author), it was decided that this part of the test
would be very difficult to make platform specific, and that nothing
significant would be lost if the property count sections were
removed.


platform/*/Skipped: Added the fullscreen/ directory to the Skipped list

for every platform save mac.

  • fast/dom/Window/window-properties-expected.txt: Added the new

properties exposed on Document and Element.

  • fast/dom/domListEnumeration-expected.txt: Removed the iteration count

part of this test.

  • fast/dom/script-tests/domListEnumeration.js: ""
  • fullscreen: Added.
  • platform/mac/fullscreen: Added.
  • platform/mac/fullscreen/full-screen-api-expected.txt: Added.
  • platform/mac/fullscreen/full-screen-api.html: Added.
  • platform/mac/fullscreen/full-screen-css-expected.txt: Added.
  • platform/mac/fullscreen/full-screen-css.html: Added.
  • platform/mac/fullscreen/full-screen-remove-ancestor-expected.txt: Added.
  • platform/mac/fullscreen/full-screen-remove-ancestor.html: Added.
  • platform/mac/fullscreen/full-screen-remove-expected.txt: Added.
  • platform/mac/fullscreen/full-screen-remove.html: Added.
  • platform/mac/fullscreen/full-screen-request-expected.txt: Added.
  • platform/mac/fullscreen/full-screen-request.html: Added.
  • platform/mac/fullscreen/full-screen-twice-expected.txt: Added.
  • platform/mac/fullscreen/full-screen-twice.html: Added.

2010-07-27 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Add JavaScript API to allow a page to go fullscreen.
rdar://problem/6867795


Added basic full screen support to DumpRenderTree: when a webView requests
that DumpRenderTree go "full screen", just call the provided callback listener object's
will/did Enter/Exit full screen methods. Also, register a new user default which
enables full screen support.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:supportsFullscreenForElement:]): (-[UIDelegate webView:enterFullscreenForElement:listener:]): (-[UIDelegate webView:exitFullscreenForElement:listener:]):
1:44 PM Changeset in webkit [66250] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-08-27 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

[GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
https://bugs.webkit.org/show_bug.cgi?id=44784

Skip fast/history/history-subframe-with-name.html for GTK while we figure out
why it fails there.

  • platform/gtk/Skipped:
1:42 PM Changeset in webkit [66249] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix pt 2.

1:37 PM Changeset in webkit [66248] by jamesr@google.com
  • 8 edits
    4 moves
    1 add in trunk/WebCore

2010-08-27 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Move Texture class from p/g/chromium to p/g/gpu
https://bugs.webkit.org/show_bug.cgi?id=44783

This class and its support were developed in platform/graphics/chromium but are not chromium-specific
in any way. This patch moves them to a common location so they can be shared by all platforms.

Pure refactor, so no new tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::drawTexturedRectTile): (WebCore::GLES2Canvas::createTexture): (WebCore::GLES2Canvas::getTexture):
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/chromium/GLES2Texture.cpp: Removed.
  • platform/graphics/chromium/GLES2Texture.h: Removed.
  • platform/graphics/gpu/Texture.cpp: Added. (WebCore::Texture::Texture): (WebCore::Texture::~Texture): (WebCore::convertFormat): (WebCore::Texture::create): (WebCore::copySubRect): (WebCore::Texture::load): (WebCore::Texture::bindTile):
  • platform/graphics/gpu/Texture.h: Added. (WebCore::Texture::): (WebCore::Texture::format): (WebCore::Texture::tiles):
  • platform/graphics/gpu/TilingData.cpp: Renamed from WebCore/platform/graphics/chromium/TilingData.cpp. (WebCore::computeNumTiles): (WebCore::TilingData::TilingData): (WebCore::TilingData::tileXIndexFromSrcCoord): (WebCore::TilingData::tileYIndexFromSrcCoord): (WebCore::TilingData::tileBounds): (WebCore::TilingData::tileBoundsWithBorder): (WebCore::TilingData::tileBoundsNormalized): (WebCore::TilingData::tilePositionX): (WebCore::TilingData::tilePositionY): (WebCore::TilingData::tileSizeX): (WebCore::TilingData::tileSizeY): (WebCore::TilingData::overlappedTileIndices): (WebCore::TilingData::intersectDrawQuad):
  • platform/graphics/gpu/TilingData.h: Renamed from WebCore/platform/graphics/chromium/TilingData.h. (WebCore::TilingData::maxTextureSize): (WebCore::TilingData::totalSizeX): (WebCore::TilingData::totalSizeY): (WebCore::TilingData::numTiles): (WebCore::TilingData::numTilesX): (WebCore::TilingData::numTilesY): (WebCore::TilingData::tileIndex): (WebCore::TilingData::tileXIndex): (WebCore::TilingData::tileYIndex): (WebCore::TilingData::TilingData): (WebCore::TilingData::assertTile):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::drawBitmapGLES2):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
  • platform/graphics/skia/PlatformContextSkia.h:
1:29 PM Changeset in webkit [66247] by hyatt@apple.com
  • 52 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=44788, implement HTML5-compliant doctype switching.

Reviewed by Simon Fraser.

WebCore:

Rename the various modes to match the HTML5 specification:

ParseMode -> CompatibilityMode
CompatMode -> QuirksMode
AlmostStrictMode -> LimitedQuirksMode
StrictMode -> NoQuirksMode


Remove the htmlHacks() accessor from RenderStyle and make rendering code just go to the document
instead. This makes switching modes avoid forcing all RenderStyles to detect as changed.

Clean up user stylesheets to minimize style recalculation when the mode is switched.

Fix bugs with the propagation of correct modes in the HTML5 parser. Make sure the
dummy document created for fragment parsing properly inherits the real document's CompatibilityMode.
Make sure the tree builder properly changes the insertion mode to "BeforeHTML" after handling
a doctype token.

determineParseMode -> setCompatibilityModeFromDoctype, and it now implements the HTML5 algorithm
precisely.

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::fontSizeForKeyword):

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::ClassNodeList):

  • dom/DecodedDataDocumentParser.cpp:

(WebCore::DecodedDataDocumentParser::appendBytes):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::setDocType):
(WebCore::Document::unscheduleStyleRecalc):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::createStyleSelector):
(WebCore::Document::implicitOpen):
(WebCore::Document::pageUserSheet):
(WebCore::Document::clearPageUserSheet):
(WebCore::Document::updatePageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::clearPageGroupUserSheets):
(WebCore::Document::updatePageGroupUserSheets):
(WebCore::Document::findAnchor):

  • dom/Document.h:

(WebCore::Document::):
(WebCore::Document::setCompatibilityModeFromDoctype):
(WebCore::Document::lockCompatibilityMode):
(WebCore::Document::compatibilityMode):
(WebCore::Document::inQuirksMode):
(WebCore::Document::inLimitedQuirksMode):
(WebCore::Document::inNoQuirksMode):

  • dom/Element.cpp:

(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
(WebCore::Element::webkitMatchesSelector):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::setClass):

  • dom/Node.cpp:

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

  • dom/OptionElement.cpp:

(WebCore::OptionElement::collectOptionLabelOrText):

  • dom/SelectorNodeList.cpp:

(WebCore::createSelectorNodeList):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::parseMappedAttribute):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::shouldRemoveEndBR):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::createLinkDecl):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

  • html/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertDoctype):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::HTMLDocument):
(WebCore::HTMLDocument::compatMode):
(WebCore::HTMLDocument::setCompatibilityModeFromDoctype):

  • html/HTMLDocument.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

  • html/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::defaultForInitial):

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::reportDataReceived):

  • loader/DocumentWriter.h:
  • loader/ImageDocument.cpp:

(WebCore::ImageDocument::ImageDocument):

  • loader/MediaDocument.cpp:

(WebCore::MediaDocument::MediaDocument):

  • loader/PluginDocument.cpp:

(WebCore::PluginDocument::PluginDocument):

  • loader/SinkDocument.cpp:

(WebCore::SinkDocument::SinkDocument):

  • loader/TextDocument.cpp:

(WebCore::TextDocument::TextDocument):

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

  • page/PageGroup.cpp:

(WebCore::PageGroup::resetUserStyleCacheInAllFrames):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setEnforceCSSMIMETypeInNoQuirksMode):

  • page/Settings.h:

(WebCore::Settings::enforceCSSMIMETypeInNoQuirksMode):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcPrefWidths):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::handleBottomOfBlock):
(WebCore::RenderBlock::calcInlinePrefWidths):
(WebCore::RenderBlock::calcBlockPrefWidths):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::createInlineBoxForRenderer):
(WebCore::RenderBlock::findNextLineBreak):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::calcPercentageHeight):
(WebCore::RenderBox::calcAbsoluteHorizontal):
(WebCore::RenderBox::calcAbsoluteHorizontalReplaced):

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewHeight):

  • rendering/RenderListItem.cpp:

(WebCore::getParentOfFirstLineBox):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowHeight):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticallyAlignBoxes):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::setBitDefaults):

WebKit/mac:

Rename the various modes to match the HTML5 specification:

ParseMode -> CompatibilityMode
CompatMode -> QuirksMode
AlmostStrictMode -> LimitedQuirksMode
StrictMode -> NoQuirksMode


Remove the htmlHacks() accessor from RenderStyle and make rendering code just go to the document
instead. This makes switching modes avoid forcing all RenderStyles to detect as changed.

Clean up user stylesheets to minimize style recalculation when the mode is switched.

Fix bugs with the propagation of correct modes in the HTML5 parser. Make sure the
dummy document created for fragment parsing properly inherits the real document's CompatibilityMode.
Make sure the tree builder properly changes the insertion mode to "BeforeHTML" after handling
a doctype token.

determineParseMode -> setCompatibilityModeFromDoctype, and it now implements the HTML5 algorithm
precisely.

  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

1:28 PM Changeset in webkit [66246] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix pt 1.

1:12 PM Changeset in webkit [66245] by barraclough@apple.com
  • 15 edits in trunk

Bug 44745 - Number.toFixed/toExponential/toPrecision are inaccurate.

Reviewed by Oliver Hunt.

These methods should be using a version of dtoa that can generate results accurate
to the requested precision, whereas our version of dtoa is only currently able to
support producing results sufficiently accurate to distinguish the value from any
other IEEE-754 double precision number.

JavaScriptCore:

This change has no impact on benchmarks we track.

On microbenchmarks for these functions, this is a slight regression where a high
precision is requested (dtoa now need to iterate further to generate a a greater
number of digits), but with smaller precision values (hopefully more common) this
improves performance, since it reduced the accurate of result dtoa is required,
to produce, and removes the need to pre-round values before calling dtoa.

doubleToStringInJavaScriptFormat renamed to numberToString

doubleToStringInJavaScriptFormat renamed to numberToString

  • runtime/UString.cpp:

(JSC::UString::number):

doubleToStringInJavaScriptFormat renamed to numberToString

  • wtf/DecimalNumber.h:

(WTF::DecimalNumber::DecimalNumber):
(WTF::DecimalNumber::toStringDecimal):
(WTF::DecimalNumber::toStringExponential):

Remove all pre-rounding of values, instead call dtoa correctly.

  • wtf/dtoa.cpp:

(WTF::dtoa):

  • wtf/dtoa.h:

Reenable support for rounding to specific-figures/decimal-places in dtoa.
Modify to remove unbiased rounding, provide ECMA required away-from-zero.
Rewrite doubleToStringInJavaScriptFormat to use DecimalNumber, rename to
numberToString.

WebCore:

  • html/HTMLTreeBuilder.cpp:

(WebCore::serializeForNumberType):

doubleToStringInJavaScriptFormat renamed to numberToString.

LayoutTests:

Updating expected results, corrected errors in fast/js/kde/script-tests/Number.js
(corrected results confirmed with FireFox).

  • fast/js/kde/Number-expected.txt:
  • fast/js/kde/script-tests/Number.js:
  • fast/js/number-toExponential-expected.txt:
  • fast/js/number-tofixed-expected.txt:
  • fast/js/number-toprecision-expected.txt:
1:04 PM Changeset in webkit [66244] by demarchi@webkit.org
  • 2 edits in trunk

2010-08-27 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed. Fix compiling dependencies on EFL port due to r65891.

No new functionality so no new tests.

  • cmake/WebKitGenerators.cmake:
12:42 PM Changeset in webkit [66243] by commit-queue@webkit.org
  • 12 edits in trunk

2010-08-27 Michael Nordman <Michael Nordman>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=44133
IDL bindings for XmlHttpRequest.responseBlob support, doesn't do anything yet.
Adds two new attributes, asBlob and responseBlob.
Runtime disabled by default, also behind a new ENABLE_XHR_RESPONSE_BLOB compile time guard.

No new tests, just adding some stubs.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setResponseBlobEnabled): (WebCore::RuntimeEnabledFeatures::responseBlobEnabled): (WebCore::RuntimeEnabledFeatures::asBlobEnabled):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::responseText): Changed to allow an exceptional return path.
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseTextAccessorGetter): Changed to allow an exceptional return path.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseText): Changed to raise an exception when accessed with asBlob set to true. (WebCore::XMLHttpRequest::responseXML): Changed to raise an exception when accessed with asBlob set to true. (WebCore::XMLHttpRequest::responseBlob): Added stub method, returns 0 for now. (WebCore::XMLHttpRequest::setAsBlob): Sets the asBlob attribute, raises exception if called at an inappropriate time. (WebCore::XMLHttpRequest::open): Resets asBlob to false, the default value. (WebCore::XMLHttpRequest::abort): Clears m_responseBlob. (WebCore::XMLHttpRequest::clearResponse): Clears m_responseBlob. (WebCore::XMLHttpRequest::didFinishLoading): Added a FIXME to populate m_responseBlob.
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::asBlob):
  • xml/XMLHttpRequest.idl:

2010-08-27 Michael Nordman <Michael Nordman>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=44133
WebKitAPI to allow runtime enablement of XmlHttpRequest.responseBlob.

  • features.gypi: Define ENABLE_XHR_RESPONSE_BLOB.
  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableXHRResponseBlob): (WebKit::WebRuntimeFeatures::isXHRResponseBlobEnabled):
12:26 PM Changeset in webkit [66242] by tony@chromium.org
  • 1 edit
    363 adds in trunk/LayoutTests

2010-08-27 Tony Chang <tony@chromium.org>

Unreviewed. Add google-chrome linux ia32 results. These are slightly
different from the chromium-linux results because of rounding
differences due to different compiler flags. These results are
expected to pass on ubuntu hardy 32.

  • platform/google-chrome-linux32/css1/box_properties/acid_test-expected.checksum: Added.
  • platform/google-chrome-linux32/css1/box_properties/acid_test-expected.png: Added.
  • platform/google-chrome-linux32/css1/box_properties/acid_test-expected.txt: Added.
  • platform/google-chrome-linux32/css2.1/t09-c5526c-display-00-e-expected.checksum: Added.
  • platform/google-chrome-linux32/css2.1/t09-c5526c-display-00-e-expected.png: Added.
  • platform/google-chrome-linux32/css2.1/t09-c5526c-display-00-e-expected.txt: Added.
  • platform/google-chrome-linux32/editing/execCommand/5138441-expected.checksum: Added.
  • platform/google-chrome-linux32/editing/execCommand/5138441-expected.png: Added.
  • platform/google-chrome-linux32/editing/inserting/editing-empty-divs-expected.checksum: Added.
  • platform/google-chrome-linux32/editing/inserting/editing-empty-divs-expected.png: Added.
  • platform/google-chrome-linux32/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Added.
  • platform/google-chrome-linux32/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
  • platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize04-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize04-expected.png: Added.
  • platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize18-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize18-expected.png: Added.
  • platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/google-chrome-linux32/fast/backgrounds/size/contain-and-cover-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/backgrounds/size/contain-and-cover-expected.png: Added.
  • platform/google-chrome-linux32/fast/backgrounds/svg-as-background-4-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/backgrounds/svg-as-background-4-expected.png: Added.
  • platform/google-chrome-linux32/fast/backgrounds/svg-as-background-5-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/backgrounds/svg-as-background-5-expected.png: Added.
  • platform/google-chrome-linux32/fast/block/basic/011-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/block/basic/011-expected.png: Added.
  • platform/google-chrome-linux32/fast/block/basic/011-expected.txt: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-2-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-2-expected.png: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-3-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-3-expected.png: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-ltr-expected.png: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-2-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-2-expected.png: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-3-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-3-expected.png: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-rtl-expected.png: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-short-ltr-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-short-ltr-expected.png: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-short-rtl-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/block/positioning/absolute-in-inline-short-rtl-expected.png: Added.
  • platform/google-chrome-linux32/fast/borders/border-image-omit-right-slice-expected.checksum: Copied from LayoutTests/platform/chromium-win/fast/borders/border-image-omit-right-slice-expected.checksum.
  • platform/google-chrome-linux32/fast/borders/border-image-omit-right-slice-expected.png: Copied from LayoutTests/platform/chromium-win/fast/borders/border-image-omit-right-slice-expected.png.
  • platform/google-chrome-linux32/fast/borders/border-image-rotate-transform-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/borders/border-image-rotate-transform-expected.png: Added.
  • platform/google-chrome-linux32/fast/borders/borderRadiusSolid03-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/borders/borderRadiusSolid03-expected.png: Added.
  • platform/google-chrome-linux32/fast/css-generated-content/012-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/css-generated-content/012-expected.png: Added.
  • platform/google-chrome-linux32/fast/css/border-height-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/css/border-height-expected.png: Added.
  • platform/google-chrome-linux32/fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/css/margin-top-bottom-dynamic-expected.png: Added.
  • platform/google-chrome-linux32/fast/dom/HTMLProgressElement/progress-element-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/dom/HTMLProgressElement/progress-element-expected.png: Added.
  • platform/google-chrome-linux32/fast/forms/menulist-style-color-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/forms/menulist-style-color-expected.png: Added.
  • platform/google-chrome-linux32/fast/forms/negativeLineHeight-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/forms/negativeLineHeight-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/negativeLineHeight-expected.png.
  • platform/google-chrome-linux32/fast/forms/search-vertical-alignment-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/google-chrome-linux32/fast/forms/textAreaLineHeight-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/forms/textAreaLineHeight-expected.png: Added.
  • platform/google-chrome-linux32/fast/gradients/border-image-gradient-sides-and-corners-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
  • platform/google-chrome-linux32/fast/gradients/radial-centered-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/gradients/radial-centered-expected.png: Added.
  • platform/google-chrome-linux32/fast/images/animated-svg-as-image-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/images/animated-svg-as-image-expected.png: Added.
  • platform/google-chrome-linux32/fast/inline-block/inline-block-vertical-align-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/inline-block/inline-block-vertical-align-expected.png: Added.
  • platform/google-chrome-linux32/fast/js/navigator-mimeTypes-length-expected.txt: Copied from LayoutTests/fast/js/navigator-mimeTypes-length-expected.txt.
  • platform/google-chrome-linux32/fast/lists/ordered-list-with-no-ol-tag-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
  • platform/google-chrome-linux32/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
  • platform/google-chrome-linux32/fast/repaint/shadow-multiple-horizontal-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
  • platform/google-chrome-linux32/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
  • platform/google-chrome-linux32/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
  • platform/google-chrome-linux32/fast/repaint/shadow-multiple-vertical-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/repaint/shadow-multiple-vertical-expected.png: Added.
  • platform/google-chrome-linux32/fast/replaced/absolute-image-sizing-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/replaced/absolute-image-sizing-expected.png: Added.
  • platform/google-chrome-linux32/fast/table/empty-table-percent-height-expected.checksum: Added.
  • platform/google-chrome-linux32/fast/table/empty-table-percent-height-expected.png: Added.
  • platform/google-chrome-linux32/plugins/embed-attributes-style-expected.checksum: Added.
  • platform/google-chrome-linux32/plugins/embed-attributes-style-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/linking-a-05-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/linking-a-05-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/painting-marker-03-f-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-05-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-09-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum: Copied from LayoutTests/platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.checksum.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Copied from LayoutTests/platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.png.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Copied from LayoutTests/platform/google-chrome-linux64/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-06-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-07-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-08-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-frag-03-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-group-03-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-image-10-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/batik/filters/filterRegions-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/batik/filters/filterRegions-expected.png: Added.
  • platform/google-chrome-linux32/svg/batik/filters/filterRegions-expected.txt: Added.
  • platform/google-chrome-linux32/svg/batik/text/textEffect-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/batik/text/textEffect-expected.png: Added.
  • platform/google-chrome-linux32/svg/batik/text/textOnPath-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/batik/text/textOnPath-expected.png: Added.
  • platform/google-chrome-linux32/svg/batik/text/textOnPath2-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/batik/text/textOnPath2-expected.png: Added.
  • platform/google-chrome-linux32/svg/batik/text/textOnPath3-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/batik/text/textOnPath3-expected.png: Added.
  • platform/google-chrome-linux32/svg/batik/text/textOnPathSpaces-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/batik/text/textOnPathSpaces-expected.png: Added.
  • platform/google-chrome-linux32/svg/batik/text/verticalText-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/batik/text/verticalText-expected.png: Added.
  • platform/google-chrome-linux32/svg/batik/text/verticalTextOnPath-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/batik/text/verticalTextOnPath-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/circular-marker-reference-2-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/circular-marker-reference-2-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/control-points-for-S-and-T-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.checksum.
  • platform/google-chrome-linux32/svg/custom/control-points-for-S-and-T-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/control-points-for-S-and-T-expected.png.
  • platform/google-chrome-linux32/svg/custom/empty-merge-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/empty-merge-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/empty-merge-expected.txt: Added.
  • platform/google-chrome-linux32/svg/custom/feComponentTransfer-Table-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/feComponentTransfer-Table-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/feDisplacementMap-01-expected.txt: Added.
  • platform/google-chrome-linux32/svg/custom/focus-ring-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/focus-ring-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/glyph-setting-d-attribute-expected.txt: Added.
  • platform/google-chrome-linux32/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum.
  • platform/google-chrome-linux32/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png.
  • platform/google-chrome-linux32/svg/custom/image-small-width-height-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/image-small-width-height-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/image-with-transform-clip-filter-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/image-with-transform-clip-filter-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/inline-svg-in-xhtml-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/inline-svg-in-xhtml-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/linking-a-03-b-all-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/linking-a-03-b-all-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/linking-a-03-b-transform-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/linking-a-03-b-transform-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/linking-a-03-b-viewBox-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/linking-a-03-b-viewBox-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/linking-a-03-b-viewBox-transform-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/non-circular-marker-reference-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/non-circular-marker-reference-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/path-getTotalLength-expected.txt: Copied from LayoutTests/svg/custom/path-getTotalLength-expected.txt.
  • platform/google-chrome-linux32/svg/custom/pattern-with-transformation-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/pattern-with-transformation-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/recursive-filter-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/recursive-filter-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/recursive-filter-expected.txt: Added.
  • platform/google-chrome-linux32/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
  • platform/google-chrome-linux32/svg/custom/relative-sized-use-on-symbol-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/relative-sized-use-on-symbol-expected.checksum.
  • platform/google-chrome-linux32/svg/custom/relative-sized-use-on-symbol-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/relative-sized-use-on-symbol-expected.png.
  • platform/google-chrome-linux32/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
  • platform/google-chrome-linux32/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added.
  • platform/google-chrome-linux32/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/svg-curve-with-relative-cordinates-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/svg-fonts-in-html-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/svg-fonts-in-html-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/svg-fonts-in-html-expected.txt: Added.
  • platform/google-chrome-linux32/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt.
  • platform/google-chrome-linux32/svg/custom/use-css-events-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/custom/use-css-events-expected.png: Added.
  • platform/google-chrome-linux32/svg/custom/width-full-percentage-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/custom/width-full-percentage-expected.txt.
  • platform/google-chrome-linux32/svg/filters/feColorMatrix-values-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/filters/feColorMatrix-values-expected.png: Added.
  • platform/google-chrome-linux32/svg/filters/feColorMatrix-values-expected.txt: Added.
  • platform/google-chrome-linux32/svg/filters/filteredImage-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/filters/filteredImage-expected.png: Added.
  • platform/google-chrome-linux32/svg/filters/filteredImage-expected.txt: Copied from LayoutTests/platform/qt/svg/filters/filteredImage-expected.txt.
  • platform/google-chrome-linux32/svg/filters/parent-children-with-same-filter-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/filters/parent-children-with-same-filter-expected.png: Added.
  • platform/google-chrome-linux32/svg/filters/parent-children-with-same-filter-expected.txt: Added.
  • platform/google-chrome-linux32/svg/filters/subRegion-one-effect-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/filters/subRegion-one-effect-expected.png: Added.
  • platform/google-chrome-linux32/svg/filters/subRegion-two-effects-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/filters/subRegion-two-effects-expected.png: Added.
  • platform/google-chrome-linux32/svg/hixie/perf/001-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/hixie/perf/001-expected.png: Added.
  • platform/google-chrome-linux32/svg/hixie/perf/001-expected.txt: Added.
  • platform/google-chrome-linux32/svg/hixie/perf/002-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/hixie/perf/002-expected.png: Added.
  • platform/google-chrome-linux32/svg/hixie/perf/002-expected.txt: Added.
  • platform/google-chrome-linux32/svg/overflow/overflow-on-inner-svg-element-expected.txt: Added.
  • platform/google-chrome-linux32/svg/text/text-path-01-b-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/text/text-path-01-b-expected.png: Added.
  • platform/google-chrome-linux32/svg/text/text-text-06-t-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/text/text-text-06-t-expected.png: Added.
  • platform/google-chrome-linux32/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
  • platform/google-chrome-linux32/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum: Added.
  • platform/google-chrome-linux32/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug1296-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug1296-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug1430-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug1430-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug15544-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug15544-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug23235-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug23235-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug2886-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug2886-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug2947-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug2947-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug2981-2-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug2981-2-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug4284-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug4284-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug4427-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug4427-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug625-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/bugs/bug625-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/core/bloomberg-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/core/bloomberg-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_layers-opacity-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_position-table-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-cell-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla/other/cell_widths-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla/other/cell_widths-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Added.
  • platform/google-chrome-linux32/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/google-chrome-linux32/transforms/svg-vs-css-expected.checksum: Added.
  • platform/google-chrome-linux32/transforms/svg-vs-css-expected.png: Added.
11:40 AM Changeset in webkit [66241] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-08-27 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebFrame::inputFieldFocus() fails on MeeGo Handset with QtWebKit 2.1
https://bugs.webkit.org/show_bug.cgi?id=44703

Make the test more robust to changes in the execution environment.
The position where the mouse events are sent is now computed from the element geometry,
this make the test less dependent on the fonts.

The test now also make sure the window manager mapped the window on screen
before attempting to send the events.

  • tests/qwebframe/tst_qwebframe.cpp:
11:30 AM Changeset in webkit [66240] by Simon Fraser
  • 4 edits
    2 adds in trunk

2010-08-27 Simon Fraser <Simon Fraser>

Reviewed by Tony Chang.

Crash in CSSStyleSelector.cpp
https://bugs.webkit.org/show_bug.cgi?id=44780

Need to null-check the images when replacing pending images, because a later
rule may have replaced an image with 'none'.

Test: fast/css/pending-images-crash.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::loadPendingImages):
  • page/FrameView.cpp: (WebCore::FrameView::paintContents): Fix unrelated log message.
11:24 AM Changeset in webkit [66239] by caseq@chromium.org
  • 16 edits
    1 add
    9 deletes in trunk

2010-08-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Revert r66218 & r66220 due to GTK test failures.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView.categorySortFunction): (WebInspector.AuditLauncherView): (WebInspector.AuditLauncherView.prototype._launchButtonClicked): (WebInspector.AuditLauncherView.prototype._selectAllClicked): (WebInspector.AuditLauncherView.prototype._categoryClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/AuditResultView.js: (WebInspector.AuditCategoryResultPane.prototype._appendResult):
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel): (WebInspector.AuditsPanel.prototype._executeAudit): (WebInspector.AuditCategory.prototype.runRules):
  • inspector/front-end/ExtensionAPI.js: (injectedExtensionAPI): (injectedExtensionAPI.EventSinkImpl.prototype.addListener): (injectedExtensionAPI.EventSinkImpl.prototype._fire): (injectedExtensionAPI.EventSink): (injectedExtensionAPI.InspectorExtensionAPI): (injectedExtensionAPI.Panels.prototype.create):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._postNotification): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionStatus):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js: ():

2010-08-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Revert r66218 & r66220 due to GTK test failures.

  • inspector/audits-panel-functional.html:
  • inspector/audits-tests.js: Removed.
  • inspector/extensions-api-expected.txt:
  • inspector/extensions-audits-api-expected.txt: Removed.
  • inspector/extensions-audits-api.html: Removed.
  • inspector/extensions-audits-expected.txt: Removed.
  • inspector/extensions-audits-tests.js: Removed.
  • inspector/extensions-audits.html: Removed.
  • inspector/extensions-expected.txt:
  • inspector/resources/audits-script3.js: Added. (foo3):
  • platform/chromium/test_expectations.txt:
11:20 AM Changeset in webkit [66238] by commit-queue@webkit.org
  • 7 edits
    5 adds in trunk

2010-08-27 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

Crash in HistoryController::recursiveGoToItem when navigating in a frame
while another frame has a custom window name
https://bugs.webkit.org/show_bug.cgi?id=44183

Add a test to check that we can handle navigation from a top-level frame
when one of the child frames sets window.name after load.

  • fast/history/history-subframe-with-name-expected.txt: Added.
  • fast/history/history-subframe-with-name.html: Added.
  • fast/history/resources/history-subframe-with-name-2.html: Added.
  • fast/history/resources/history-subframe-with-name-3.html: Added.
  • fast/history/resources/history-subframe-with-name-container.html: Added.

2010-08-27 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

Crash in HistoryController::recursiveGoToItem when navigating in a frame
while another frame has a custom window name
https://bugs.webkit.org/show_bug.cgi?id=44183

Fix up HistoryController::recursiveGoToItem to better check whether the
current document frames, the curent history item frames, and the
destination history frames match up.

Test: fast/history/history-subframe-with-name.html

  • history/HistoryItem.cpp: (WebCore::HistoryItem::childItemWithDocumentSequenceNumber): Add linear lookup of child by document sequence number (WebCore::HistoryItem::hasSameDocuments): Remove assumption that the other item has the children in the same order (it doesn't seem to be true) (WebCore::HistoryItem::hasSameFrames): Add recursive comparison of child frames.
  • history/HistoryItem.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Compare full set of documents in history items, not just the topmost ones. Otherwise when going between framesets where only one of the subframes changed we wouldn't trigger a load.
  • loader/HistoryController.cpp: (WebCore::HistoryController::recursiveGoToItem): Also check that the two history items have the same frames (WebCore::HistoryController::currentFramesMatchItem): Refactor childFramesMatchItem to also check the top-most frame, to make recursiveGoToItem easier to read.
  • loader/HistoryController.h:
10:53 AM Changeset in webkit [66237] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-08-27 Patrick Gansterer <paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

[WINCE] Buildfix for graphics code after r65449
https://bugs.webkit.org/show_bug.cgi?id=44510

  • platform/graphics/wince/GraphicsContextWince.cpp:
  • platform/graphics/wince/ImageBufferWince.cpp: (WebCore::ImageBuffer::drawsUsingCopy): (WebCore::ImageBuffer::copyImage): (WebCore::ImageBuffer::clip): (WebCore::ImageBuffer::draw): (WebCore::ImageBuffer::drawPattern):
10:50 AM Changeset in webkit [66236] by Simon Fraser
  • 5 edits
    31 deletes in trunk/WebKitSite/specs

Remove obsolete CSS proposals, adding links to the most recent ones. Add nodes to the HTML media proposals indicating that they are stagnant or have been superseded.

10:45 AM Changeset in webkit [66235] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-27 Tony Chang <tony@chromium.org>

Unreviewed, remove duplicate test expectation.

  • platform/chromium/test_expectations.txt:
10:35 AM Changeset in webkit [66234] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-27 Dawit Alemayehu <adawit@kde.org>

Reviewed by Simon Hausmann.

[Qt] Search the Windows registry for the location of the Java plugin DLL.
https://bugs.webkit.org/show_bug.cgi?id=38911

This change, in addition to the ones 34539 and 38911, is needed to
make Java applet work in QtWebKit on the Windows platform.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addJavaPluginDirectory): (WebCore::PluginDatabase::defaultPluginDirectories):
10:34 AM Changeset in webkit [66233] by Darin Adler
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: Minor revision, improve clarity and mention some

recent developments.

10:23 AM Changeset in webkit [66232] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed.
Attempt to fix flakiness of inspector extension audit tests.

  • inspector/extensions-audits-tests.js:
10:15 AM Changeset in webkit [66231] by Adam Roben
  • 2 edits in trunk/WebKit2

Handle ERROR_IO_INCOMPLETE more correctly in Connection

We still don't know exactly why we're getting this error, but at least
we can do something sensible when we do.

Fixes <http://webkit.org/b/44776> Occasional crash in
Connection::readEventHandler or assertion failure in
Connection::writeEventHandler due to ERROR_IO_INCOMPLETE

Reviewed by Sam Weinig.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::readEventHandler): Bail out of this function
entirely when we get ERROR_IO_INCOMPLETE. We'll get called back later
when the read completes. Continuing in the function at this point
would cause us to treat an incomplete read as a complete one, leading
to a crash. Added an assertion to make the crash more understandable
in the future.
(CoreIPC::Connection::writeEventHandler): Bail out when we get
ERROR_IO_INCOMPLETE. We'll get called back later when the write
completes.

10:14 AM Changeset in webkit [66230] by tony@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-08-27 Tony Chang <tony@chromium.org>

Unreviewed. Add chromium-mac results for svg/custom/getscreenctm-in-scrollable-div-area.xhtml.

The image results are the same except for the scrollbars. I'm not
sure why this wasn't landed with the win/linux results in r66193.

  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
10:14 AM Changeset in webkit [66229] by Adam Roben
  • 2 edits in trunk/WebKit2

Make the web process pause on launch when the WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable is set

This is a bit easier to use than holding Ctrl-Alt-Shift during launch,
since the process can sometimes take a long time to launch under the
debugger. Ctrl-Alt-Shift still works, however.

Fixes <http://webkit.org/b/44774> Would like an easier way to pause
the web process on launch

Reviewed by Sam Weinig.

  • WebProcess/WebKitMain.cpp:

(WebKitMain):

10:03 AM Changeset in webkit [66228] by tony@chromium.org
  • 3 edits
    3 deletes in trunk/LayoutTests

2010-08-27 Tony Chang <tony@chromium.org>

Unreviewed. Reverting r66177, which were chromium expectations for
fast/forms/select-style. It seems like this was a regression fixed in r66195.

  • platform/chromium-mac/fast/forms/select-style-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/select-style-expected.png: Removed.
  • platform/chromium-mac/fast/forms/select-style-expected.txt: Removed.
  • platform/chromium-win/fast/forms/select-style-expected.checksum:
  • platform/chromium-win/fast/forms/select-style-expected.png:
9:58 AM Changeset in webkit [66227] by weinig@apple.com
  • 2 edits in trunk/WebKit2
  • WebKit2.xcodeproj/project.pbxproj: Make WKBundleScriptWorld.h public.

Rubber-stamped by Adam Roben.

9:52 AM Changeset in webkit [66226] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-27 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium test expectations.

  • platform/chromium/test_expectations.txt:
9:06 AM Changeset in webkit [66225] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-08-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: color-code property values in object notation.
https://bugs.webkit.org/show_bug.cgi?id=44766

  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):
8:58 AM Changeset in webkit [66224] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-27 Patrick Gansterer <paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

[WINCE] Buildfix for FontPlatformData after r65021
https://bugs.webkit.org/show_bug.cgi?id=44467

  • platform/graphics/wince/FontPlatformData.h:
7:46 AM Changeset in webkit [66223] by Nikolas Zimmermann
  • 24 edits
    4 adds
    2 deletes in trunk/WebCore

2010-08-27 Patrick Gansterer <paroga@paroga.com>

Reviewed by Nikolas Zimmermann.

RenderImage::imageChanged invalidates wrong area
https://bugs.webkit.org/show_bug.cgi?id=43779

At the moment RenderSVGImage inherits from RenderImage, which makes non-SVG compatible
assumptions about repainting, and thus has to be fixed to inherit from RenderSVGModelObject.

This patch moves the CachedImage from RenderImage into a separate class.
The new class contains the common behavior of RenderImage and RenderSVGImage.
An additional patch will remove the inheritance of RenderImage at RenderSVGImage.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::createRenderer): (WebCore::HTMLEmbedElement::attach):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::createRenderer): (WebCore::HTMLImageElement::attach):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::attach):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::createRenderer):
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::attach): (WebCore::HTMLVideoElement::parseMappedAttribute):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::setImage): (WebCore::ImageLoader::updateFromElement): (WebCore::ImageLoader::renderImageResource): (WebCore::ImageLoader::updateRenderer):
  • loader/ImageLoader.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::~RenderImage): (WebCore::RenderImage::setImageResource): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::notifyFinished): (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::paintIntoRect): (WebCore::RenderImage::minimumReplacedHeight): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
  • rendering/RenderImage.h: (WebCore::RenderImage::imageResource): (WebCore::RenderImage::cachedImage): (WebCore::RenderImage::intrinsicSizeChanged): (WebCore::toRenderImage):
  • rendering/RenderImageGeneratedContent.cpp: Removed.
  • rendering/RenderImageGeneratedContent.h: Removed.
  • rendering/RenderImageResource.cpp: Added. (WebCore::RenderImageResource::RenderImageResource): (WebCore::RenderImageResource::~RenderImageResource): (WebCore::RenderImageResource::initialize): (WebCore::RenderImageResource::shutdown): (WebCore::RenderImageResource::setCachedImage): (WebCore::RenderImageResource::resetAnimation): (WebCore::RenderImageResource::setImageContainerSize): (WebCore::RenderImageResource::nullImage):
  • rendering/RenderImageResource.h: Added. (WebCore::RenderImageResource::create): (WebCore::RenderImageResource::cachedImage): (WebCore::RenderImageResource::hasImage): (WebCore::RenderImageResource::image): (WebCore::RenderImageResource::errorOccurred): (WebCore::RenderImageResource::usesImageContainerSize): (WebCore::RenderImageResource::imageHasRelativeWidth): (WebCore::RenderImageResource::imageHasRelativeHeight): (WebCore::RenderImageResource::imageSize): (WebCore::RenderImageResource::imagePtr):
  • rendering/RenderImageResourceStyleImage.cpp: Added. (WebCore::RenderImageResourceStyleImage::RenderImageResourceStyleImage): (WebCore::RenderImageResourceStyleImage::~RenderImageResourceStyleImage): (WebCore::RenderImageResourceStyleImage::initialize): (WebCore::RenderImageResourceStyleImage::shutdown):
  • rendering/RenderImageResourceStyleImage.h: Added. (WebCore::RenderImageResourceStyleImage::create): (WebCore::RenderImageResourceStyleImage::image): (WebCore::RenderImageResourceStyleImage::errorOccurred): (WebCore::RenderImageResourceStyleImage::setImageContainerSize): (WebCore::RenderImageResourceStyleImage::usesImageContainerSize): (WebCore::RenderImageResourceStyleImage::imageHasRelativeWidth): (WebCore::RenderImageResourceStyleImage::imageHasRelativeHeight): (WebCore::RenderImageResourceStyleImage::imageSize): (WebCore::RenderImageResourceStyleImage::imagePtr):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject):
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::paint):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::calculateIntrinsicSize):
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attach):
  • wml/WMLImageElement.cpp: (WebCore::WMLImageElement::createRenderer):
7:21 AM Changeset in webkit [66222] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-08-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Elements panel breaks after calling "Edit as HTML" on <body>
https://bugs.webkit.org/show_bug.cgi?id=44765

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setOuterHTML):
7:15 AM Changeset in webkit [66221] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/qt/Api

2010-08-27 Antonio Gomes <tonikitoo@webkit.org>

Unreviewed complementary fix to r66217.

  • Api/qwebpage.cpp:
  • Api/qwebview.cpp:
7:11 AM Changeset in webkit [66220] by caseq@chromium.org
  • 1 edit
    3 adds in trunk/WebCore

2010-08-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed build fix.

Web Inspector: add audits support to extension API
Byuild fix: added missing files.
https://bugs.webkit.org/show_bug.cgi?id=44518

  • inspector/front-end/AuditFormatters.js: Added. (WebInspector.applyFormatters): (WebInspector.AuditFormatters.text): (WebInspector.AuditFormatters.snippet): (WebInspector.AuditFormatters.concat): (WebInspector.AuditFormatters.url):
  • inspector/front-end/ExtensionAuditCategory.js: Added. (WebInspector.ExtensionAuditCategory): (WebInspector.ExtensionAuditCategory.prototype.get id): (WebInspector.ExtensionAuditCategory.prototype.get displayName): (WebInspector.ExtensionAuditCategory.prototype.get ruleCount): (WebInspector.ExtensionAuditCategory.prototype.run): (WebInspector.ExtensionAuditCategoryResults): (WebInspector.ExtensionAuditCategoryResults.prototype.get complete): (WebInspector.ExtensionAuditCategoryResults.prototype.cancel): (WebInspector.ExtensionAuditCategoryResults.prototype.addResult): (WebInspector.ExtensionAuditCategoryResults.prototype._addNode): (WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
  • inspector/front-end/ExtensionCommon.js: Added. (WebInspector.commonExtensionSymbols):
7:03 AM Changeset in webkit [66219] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-08-27 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebFrame::hitTestContent() fails on Meego Handset
https://bugs.webkit.org/show_bug.cgi?id=44701

Make the test more robust. The position of the text is not relying
on the size of the fonts anymore.

  • tests/qwebframe/tst_qwebframe.cpp:
6:57 AM Changeset in webkit [66218] by caseq@chromium.org
  • 16 edits
    6 adds
    1 delete in trunk

2010-08-26 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add audits support to extension API
Exposed (late) adding of categories from AuditPanel.
Removed indexOfObjectInListSortedByFunction in favor of
insertionIndexForObjectInListSortedByFunction (the former had
weird interface always returning negative numbers and was only used in
the latter).
https://bugs.webkit.org/show_bug.cgi?id=44518

Tests: inspector/extensions-audits-api.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AuditFormatters.js: Added. (WebInspector.applyFormatters): (WebInspector.AuditFormatters.text): (WebInspector.AuditFormatters.snippet): (WebInspector.AuditFormatters.concat): (WebInspector.AuditFormatters.url):
  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView): (WebInspector.AuditLauncherView.prototype.addCategory.compareCategories): (WebInspector.AuditLauncherView.prototype.addCategory): (WebInspector.AuditLauncherView.prototype._launchButtonClicked): (WebInspector.AuditLauncherView.prototype._selectAllClicked): (WebInspector.AuditLauncherView.prototype._categoryClicked): (WebInspector.AuditLauncherView.prototype._createCategoryElement): (WebInspector.AuditLauncherView.prototype._createLauncherUI):
  • inspector/front-end/AuditResultView.js: (WebInspector.AuditCategoryResultPane.prototype._appendResult):
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel): (WebInspector.AuditsPanel.prototype.addCategory): (WebInspector.AuditsPanel.prototype.getCategory): (WebInspector.AuditsPanel.prototype._executeAudit): (WebInspector.AuditCategory.prototype.run):
  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype.addListener): (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype._fire): (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype._dispatch): (WebInspector.injectedExtensionAPI.EventSink): (WebInspector.injectedExtensionAPI.InspectorExtensionAPI): (WebInspector.injectedExtensionAPI.Panels.prototype.create): (WebInspector.injectedExtensionAPI.Audits): (WebInspector.injectedExtensionAPI.Audits.prototype.addCategory): (WebInspector.injectedExtensionAPI.AuditCategory.customDispatch): (WebInspector.injectedExtensionAPI.AuditCategory): (WebInspector.injectedExtensionAPI.AuditCategoryImpl): (WebInspector.injectedExtensionAPI.AuditResult): (WebInspector.injectedExtensionAPI.AuditResult.prototype.get Severity): (WebInspector.injectedExtensionAPI.AuditResultImpl): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.addResult): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.createResult): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.done): (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype._nodeFactory): (WebInspector.injectedExtensionAPI.AuditResultNode): (WebInspector.injectedExtensionAPI.AuditResultNode.prototype.addChild):
  • inspector/front-end/ExtensionAuditCategory.js: Added. (WebInspector.ExtensionAuditCategory): (WebInspector.ExtensionAuditCategory.prototype.get id): (WebInspector.ExtensionAuditCategory.prototype.get displayName): (WebInspector.ExtensionAuditCategory.prototype.get ruleCount): (WebInspector.ExtensionAuditCategory.prototype.run): (WebInspector.ExtensionAuditCategoryResults): (WebInspector.ExtensionAuditCategoryResults.prototype.get complete): (WebInspector.ExtensionAuditCategoryResults.prototype.cancel): (WebInspector.ExtensionAuditCategoryResults.prototype.addResult): (WebInspector.ExtensionAuditCategoryResults.prototype._addNode): (WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
  • inspector/front-end/ExtensionCommon.js: Added. (WebInspector.commonExtensionSymbols):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.startAuditRun): (WebInspector.ExtensionServer.prototype.stopAuditRun): (WebInspector.ExtensionServer.prototype._postNotification): (WebInspector.ExtensionServer.prototype._onAddAuditCategory): (WebInspector.ExtensionServer.prototype._onAddAuditResult): (WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun): (WebInspector.ExtensionServer.prototype._addExtensions): (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript): (WebInspector.ExtensionStatus):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/utilities.js: ():

2010-08-26 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add audits support to extension API
https://bugs.webkit.org/show_bug.cgi?id=44518

  • inspector/audits-panel-functional.html:
  • inspector/audits-tests.js: Added. (frontend_collectAuditResults): (frontend_collectTextContent):
  • inspector/extensions-api-expected.txt:
  • inspector/extensions-audits-api-expected.txt: Added.
  • inspector/extensions-audits-api.html: Added.
  • inspector/extensions-audits-expected.txt: Added.
  • inspector/extensions-audits-tests.js: Added. (extension_runAudits.onMessage): (extension_runAudits): (frontend_runExtensionAudits.onAuditsDone):
  • inspector/extensions-audits.html: Added.
  • inspector/extensions-expected.txt:
  • inspector/resources/audits-script3.js: Removed.
  • platform/chromium/test_expectations.txt:
6:45 AM Changeset in webkit [66217] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-08-26 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add support for automatically creating new windows in QWebView
https://bugs.webkit.org/show_bug.cgi?id=29847

Improved the documentation of createWindow methods of both QWebView and
QWebPage by mentioning that for any of them be called, QWebSettings'
JavaScriptCanOpenWindows must be set to true.

  • Api/qwebpage.cpp:
  • Api/qwebview.cpp:
6:32 AM Changeset in webkit [66216] by jorlow@chromium.org
  • 17 edits in trunk

2010-08-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add setVersion to IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=44630

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/script-tests/database-basics.js: (openSuccess): (setVersionAgain): (checkVersion):
  • storage/indexeddb/script-tests/open-cursor.js: (openEmptyCursor): (openCursor):

2010-08-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add setVersion to IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=44630

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setVersion):
  • storage/IDBDatabase.h:
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:

2010-08-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add setVersion to IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=44630

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore): (WebKit::WebIDBDatabase::setVersion):
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::setVersion):
  • src/IDBDatabaseProxy.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::setVersion):
  • src/WebIDBDatabaseImpl.h:
6:13 AM Changeset in webkit [66215] by pfeldman@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-08-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Remove test expectations for tests that pass
https://bugs.webkit.org/show_bug.cgi?id=44762

  • platform/chromium-win/http/tests/inspector/resource-parameters-expected.txt: Copied from LayoutTests/http/tests/inspector/resource-parameters-expected.txt.
  • platform/chromium/test_expectations.txt:
6:08 AM Changeset in webkit [66214] by krit@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-08-27 Dirk Schulze <krit@webkit.org>

Unreviewed rebaseline of Qt.

getPointAtLength returns incorrect values for paths closed with the closepath command
https://bugs.webkit.org/show_bug.cgi?id=44197


QtPainterPath does some internal optimizations and this influences the result.

  • platform/qt/svg/dom/path-pointAtLength-expected.txt: Added.
6:06 AM Changeset in webkit [66213] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-08-26 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: use context menu items with checkbox for setting and removing DOM breakpoints
https://bugs.webkit.org/show_bug.cgi?id=44687

  • English.lproj/localizedStrings.js:
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.DOMBreakpointItem):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMBreakpointManager.prototype.findBreakpoint): (WebInspector.DOMBreakpoint.labelForType): (WebInspector.DOMBreakpoint.contextMenuLabelForType):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript):
5:34 AM Changeset in webkit [66212] by steveblock@google.com
  • 4 edits in trunk/LayoutTests

Not reviewed

Fix GTK, Qt and Win expected results after modifying js-test-pre.js and js-test-post.js
https://bugs.webkit.org/show_bug.cgi?id=44642

These platform-specific expected results were missed in the original patch.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
5:24 AM Changeset in webkit [66211] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-08-27 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Calls to IndexedDB methods from V8Proxy::didLeaveScriptContext() are missing enable guards
https://bugs.webkit.org/show_bug.cgi?id=44760

No new tests, build fix only.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::didLeaveScriptContext):
5:15 AM Changeset in webkit [66210] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skip two flakey xssAuditor tests that are being worked on. Hopefully we finally have somewhat green tree again.

  • platform/mac/Skipped:
5:11 AM Changeset in webkit [66209] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skip another test that is problematic, on leopard & sl bots.

  • platform/mac/Skipped:
5:09 AM Changeset in webkit [66208] by krit@webkit.org
  • 3 edits
    3 adds in trunk

2010-08-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

getPointAtLength returns incorrect values for paths closed with the closepath command
https://bugs.webkit.org/show_bug.cgi?id=44197


The closepath segment was traversed by the wrong direction. Swap starting point and
end point for closeSubpath.

Test: svg/dom/path-pointAtLength.html

  • platform/graphics/PathTraversalState.cpp: (WebCore::PathTraversalState::closeSubpath):

2010-08-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

getPointAtLength returns incorrect values for paths closed with the closepath command
https://bugs.webkit.org/show_bug.cgi?id=44197


Test that path gives back the correct point on a given length for the closepath segment.

  • svg/dom/path-pointAtLength-expected.txt: Added.
  • svg/dom/path-pointAtLength.html: Added.
  • svg/dom/script-tests/path-pointAtLength.js: Added. (pointAtLengthOfPath):
5:08 AM Changeset in webkit [66207] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKitTools

Unreviewed. Add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
5:07 AM Changeset in webkit [66206] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Turn leopard bot green again (skip more media tests :/)

  • platform/mac-leopard/Skipped:
5:00 AM Changeset in webkit [66205] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-08-27 Chao-ying Fu <fu@mips.com>

Reviewed by Oliver Hunt.

Byte alignment issue on MIPS
https://bugs.webkit.org/show_bug.cgi?id=29415

MIPS accesses one byte at a time for now to avoid the help from the
kernel to fix unaligned accesses.

  • wtf/text/AtomicString.cpp: (WebCore::equal):
  • wtf/text/StringHash.h: (WebCore::StringHash::equal):
4:40 AM Changeset in webkit [66204] by krit@webkit.org
  • 3 edits
    6 adds in trunk

2010-08-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter with wrong results on repaint for non-CG platforms
https://bugs.webkit.org/show_bug.cgi?id=44706


The result of SVG Filter is transformed to linearRGB on every repaint.
Transform the result just once, right after creating it.

Test: svg/repaint/filter-repaint.svg

  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource):

2010-08-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter with wrong results on repaint for non-CG platforms
https://bugs.webkit.org/show_bug.cgi?id=44706


Test that repainting a Filter does not change the result.

  • platform/mac/svg/repaint: Added.
  • platform/mac/svg/repaint/filter-repaint-expected.checksum: Added.
  • platform/mac/svg/repaint/filter-repaint-expected.png: Added.
  • platform/mac/svg/repaint/filter-repaint-expected.txt: Added.
  • svg/repaint: Added.
  • svg/repaint/filter-repaint.svg: Added.
4:24 AM Changeset in webkit [66203] by commit-queue@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-08-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66196.
http://trac.webkit.org/changeset/66196
https://bugs.webkit.org/show_bug.cgi?id=44758

Corresponding test has been rolled back (Requested by yuzo on
#webkit).

  • platform/chromium-linux/svg/dom/path-pointAtLength-expected.txt: Removed.
  • platform/chromium-win/svg/dom/path-pointAtLength-expected.txt: Removed.
4:22 AM Changeset in webkit [66202] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Tor Arne Vestbø.

Fix a couple of typos in comment.

  • bytecode/CodeBlock.h:
4:15 AM Changeset in webkit [66201] by steveblock@google.com
  • 4 edits in trunk/LayoutTests

2010-08-27 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

js-test-post.js is not robust for asynchronous tests
https://bugs.webkit.org/show_bug.cgi?id=44642

This patch moves finishJSTest() to js-test-pre.js to make it available for when an
asynchronous test completes before js-test-post.js has been parsed, and updates
js-test-post.js to handle this case.

  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/js/resources/js-test-post.js:
  • fast/js/resources/js-test-pre.js: (finishJSTest):
4:02 AM Changeset in webkit [66200] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Remove trailing whitespace after test name, no need to duplicate the same test in mac/Skipped and mac-leopard/Skipped, oops.

  • platform/mac-leopard/Skipped:
  • platform/mac/Skipped:
3:53 AM Changeset in webkit [66199] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Also skip media/video-source-error.html on Leopard, and media/video-zoom-controls.html on SnowLeopard.
It's a pity that numerous of the media tests are skipped since a longer time on these platforms.

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
3:04 AM Changeset in webkit [66198] by yurys@chromium.org
  • 24 edits in trunk

2010-08-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::close):
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::disconnectFromBackend): don't try to notify InspectorController that frontend closes if InspectorController triggered the action.
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.disconnectFromBackend):
  • inspector/front-end/inspector.js: (WebInspector.disconnectFromBackend):

2010-08-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::disconnectFromBackend):
  • src/InspectorFrontendClientImpl.h:

2010-08-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::notifyWebViewDestroyed): (WebKit::InspectorFrontendClient::destroyInspectorWindow): (WebKit::InspectorFrontendClient::closeWindow): (WebKit::InspectorFrontendClient::disconnectFromBackend):
  • WebCoreSupport/InspectorClientGtk.h:

2010-08-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::disconnectFromBackend): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController destroyInspectorView:]):

2010-08-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorClientQt::releaseFrontendPage): (WebCore::InspectorFrontendClientQt::closeWindow): (WebCore::InspectorFrontendClientQt::disconnectFromBackend): (WebCore::InspectorFrontendClientQt::destroyInspectorView): (WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):
  • WebCoreSupport/InspectorClientQt.h:

2010-08-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::~WebInspectorFrontendClient): (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::disconnectFromBackend): (WebInspectorFrontendClient::closeWindowWithoutNotifications): (WebInspectorFrontendClient::destroyInspectorView):
  • WebCoreSupport/WebInspectorClient.h:
2:44 AM Changeset in webkit [66197] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

2010-08-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66188.
http://trac.webkit.org/changeset/66188
https://bugs.webkit.org/show_bug.cgi?id=44756

"Graphic libraries handle segement length differently. Fixing
one platform might break another one. Rolling out this patch
and think about another solution to get getPointAtLength"
(Requested by krit on #webkit).

  • svg/dom/path-pointAtLength-expected.txt: Removed.
  • svg/dom/path-pointAtLength.html: Removed.
  • svg/dom/script-tests/path-pointAtLength.js: Removed.

2010-08-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66188.
http://trac.webkit.org/changeset/66188
https://bugs.webkit.org/show_bug.cgi?id=44756

"Graphic libraries handle segement length differently. Fixing
one platform might break another one. Rolling out this patch
and think about another solution to get getPointAtLength"
(Requested by krit on #webkit).

  • platform/graphics/PathTraversalState.cpp: (WebCore::PathTraversalState::closeSubpath):
2:34 AM Changeset in webkit [66196] by yuzo@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-08-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium-linux/svg/dom/path-pointAtLength-expected.txt: Added.
  • platform/chromium-win/svg/dom/path-pointAtLength-expected.txt: Added.
2:26 AM Changeset in webkit [66195] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

2010-08-27 Simon Fraser <Simon Fraser>

Reviewed by Nikolas Zimmermann.

r66141 caused fast/forms/select-style.html to fail on mac:
https://bugs.webkit.org/show_bug.cgi?id=44737

Handle the fact that a CSSImageValue may have a value of CSSValueNone,
in which case we should not return a pending image.

  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedOrPendingImage):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::cachedOrPendingFromValue):
2:25 AM Changeset in webkit [66194] by tkent@chromium.org
  • 7 edits in trunk

2010-08-27 Kent Tamura <tkent@chromium.org>

Reviewed by Pavel Feldman.

[DRT/Chromium] Fix inspector test failures
https://bugs.webkit.org/show_bug.cgi?id=44748

  • platform/chromium/drt_expectations.txt: Update expectations for the DRT change.

2010-08-27 Kent Tamura <tkent@chromium.org>

Reviewed by Pavel Feldman.

[DRT/Chromium] Fix inspector test failures
https://bugs.webkit.org/show_bug.cgi?id=44748

  • DEPS: Update Chromium revision to 57605 to have a webkit_support change.

2010-08-27 Kent Tamura <tkent@chromium.org>

Reviewed by Pavel Feldman.

[DRT/Chromium] Fix inspector test failures
https://bugs.webkit.org/show_bug.cgi?id=44748

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::createClientMessageLoop): Returns a valid WebKitClientMessageLoop instance
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
2:24 AM Changeset in webkit [66193] by yuzo@google.com
  • 1 edit
    18 adds in trunk/LayoutTests

2010-08-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
  • platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
  • platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
  • platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
  • platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
  • platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
  • platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
2:21 AM Changeset in webkit [66192] by alex
  • 2 edits in trunk/WebCore

2010-08-27 Alejandro G. Castro <alex@igalia.com>

Reviewed by Dan Bernstein.

drawGDIGlyphs checks if the offset is empty incorrectly causing
problems with the shadow
https://bugs.webkit.org/show_bug.cgi?id=44619

Removed the offset empty condition, now we just check if we have
offset or blur.

  • platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs):
2:17 AM Changeset in webkit [66191] by alex
  • 9 edits in trunk/LayoutTests

2010-08-27 Alejandro G. Castro <alex@igalia.com>

Unreviewed.

Updated test resuls for gtk.

  • platform/gtk/editing/selection/iframe-expected.txt:
  • platform/gtk/fast/css/nested-rounded-corners-expected.txt:
  • platform/gtk/fast/events/standalone-image-drag-to-editable-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.txt:
2:10 AM Changeset in webkit [66190] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skip a media test that fails on all mac test bots. Already notified Eric.

  • platform/mac/Skipped:
1:44 AM Changeset in webkit [66189] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Landed wrong results, as I still had another local patch in my tree. Fixing.

  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
1:20 AM Changeset in webkit [66188] by krit@webkit.org
  • 3 edits
    3 adds in trunk

2010-08-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

getPointAtLength returns incorrect values for paths closed with the closepath command
https://bugs.webkit.org/show_bug.cgi?id=44197


The closepath segment was traversed by the wrong direction. Swap starting point and
end point for closeSubpath.

Test: svg/dom/path-pointAtLength.html

  • platform/graphics/PathTraversalState.cpp: (WebCore::PathTraversalState::closeSubpath):

2010-08-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

getPointAtLength returns incorrect values for paths closed with the closepath command
https://bugs.webkit.org/show_bug.cgi?id=44197


Test that path gives back the correct point on a given length for the closepath segment.

  • svg/dom/path-pointAtLength-expected.txt: Added.
  • svg/dom/path-pointAtLength.html: Added.
  • svg/dom/script-tests/path-pointAtLength.js: Added. (pointAtLengthOfPath):
1:08 AM Changeset in webkit [66187] by Nikolas Zimmermann
  • 3 edits
    12 adds in trunk

2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGLocatable.getScreenCTM ignores scrolling
https://bugs.webkit.org/show_bug.cgi?id=44083

getScreenCTM needs to include the FrameViews scrollOffset in the e/f parameters of the AffineTransform.
Adding three new tests, which cover scrolling & getScreenCTM in large svgs with scrollbars, and with (nested) divs in overflow="scroll" mode.

Tests: svg/custom/getscreenctm-in-scrollable-div-area-nested.xhtml

svg/custom/getscreenctm-in-scrollable-div-area.xhtml
svg/custom/getscreenctm-in-scrollable-svg-area.xhtml

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::localCoordinateSpaceTransform):

2010-08-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGLocatable.getScreenCTM ignores scrolling
https://bugs.webkit.org/show_bug.cgi?id=44083

  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
  • svg/custom/getscreenctm-in-scrollable-div-area-nested.xhtml: Added.
  • svg/custom/getscreenctm-in-scrollable-div-area.xhtml: Added.
  • svg/custom/getscreenctm-in-scrollable-svg-area.xhtml: Added.
12:36 AM Changeset in webkit [66186] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-08-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

implicitlyStyledElementShouldBeRemovedWhenApplyingStyle, removeHTMLFontStyle, and removeHTMLBidiEmbeddingStyle should be merged
https://bugs.webkit.org/show_bug.cgi?id=44622

Merged shouldRemoveTextDecorationTag, implicitlyStyledElementShouldBeRemovedWhenApplyingStyle, removeHTMLFontStyle,
and removeHTMLBidiEmbeddingStyle into removeImplicitlyStyledElement. New function uses CSSPropertyElementMapping to
support all different cases dealt separately in each function.

No new tests are added since this is a cleanup.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls removeImplicitlyStyledElement. (WebCore::): (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Added.
  • editing/ApplyStyleCommand.h:

Aug 26, 2010:

11:55 PM Changeset in webkit [66185] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKitTools

Add Windows WebKit2 Tester to buildbot
<rdar://problem/7887703>

Reviewed by Dan Bernstein.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
11:48 PM Changeset in webkit [66184] by Philippe Normand
  • 4 edits in trunk

2010-08-26 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42152

  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (LoadHTMLStringItem::invoke): Implementation using webkit_web_frame_load_string().

LayoutTests:

Reviewed by Martin Robinson.

[GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42152

  • platform/gtk/Skipped: Unskip now passing test.
11:29 PM Changeset in webkit [66183] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium expectations update.

  • platform/chromium/test_expectations.txt:
11:10 PM Changeset in webkit [66182] by Girish Ramakrishnan
  • 2 edits in trunk/WebKit/qt

[Qt] Remove dead code.

Reviewed by Antonio Gomes.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::statusbarVisible):

10:27 PM Changeset in webkit [66181] by dumi@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-mac/fast/css/percent-top-relative-container-height-unspecified-expected.checksum: Added.
  • platform/chromium-mac/fast/css/percent-top-relative-container-height-unspecified-expected.png: Added.
9:27 PM Changeset in webkit [66180] by dumi@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed, Chromium build fix.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::markerTextForListItem):

9:26 PM Changeset in webkit [66179] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, Chromium expectations update.

  • platform/chromium/test_expectations.txt:
9:15 PM Changeset in webkit [66178] by dbates@webkit.org
  • 4 edits in trunk/WebKitSite

2010-08-26 Daniel Bates <dbates@rim.com>

Reviewed by Dumitru Daniliuc.

Fix misspelled words on WebKit.org contact.html,
demos/index.html, and quality/leakhunting.html
https://bugs.webkit.org/show_bug.cgi?id=44747

Fix some misspelled words on the WebKit.org site.

  • contact.html: Change "bugreports" [sic] to "bug reports".
  • demos/index.html: Change "testcase" [sic] to "test case".
  • quality/leakhunting.html: Change "formating" [sic] to "formatting".
9:09 PM Changeset in webkit [66177] by dumi@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

Unreviewed, Chromium expectations update.

  • platform/chromium-mac/fast/forms/select-style-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-style-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-style-expected.txt: Added.
  • platform/chromium-win/fast/forms/select-style-expected.checksum:
  • platform/chromium-win/fast/forms/select-style-expected.png:
9:01 PM Changeset in webkit [66176] by dumi@chromium.org
  • 6 edits in trunk/WebKit/chromium

Add support for markerTextForListItem() to Chromium's LayoutTestController.
https://bugs.webkit.org/show_bug.cgi?id=44724

Reviewed by Darin Fisher.

  • public/WebBindings.h:
  • public/WebFrame.h:
  • src/WebBindings.cpp:

(WebKit::getElementImpl):
(WebKit::WebBindings::getElement):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::markerTextForListItem):

  • src/WebFrameImpl.h:
8:54 PM Changeset in webkit [66175] by dbates@webkit.org
  • 2 edits in trunk/WebKit2

2010-08-26 Daniel Bates <dbates@rim.com>

Attempt to fix the Qt WebKit2 build.

  • WebProcess/WebPage/qt/WebPageQt.cpp: (WebKit::WebPage::performDefaultBehaviorForKeyEvent): Pass m_page.get() to WebKit::scroll() instead of m_page since it expects a raw pointer.
8:26 PM Changeset in webkit [66174] by dumi@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/fast/css/percent-top-relative-container-height-unspecified-expected.checksum: Added.
  • platform/chromium-linux/fast/css/percent-top-relative-container-height-unspecified-expected.png: Added.
  • platform/chromium-linux/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
  • platform/chromium-win/fast/css/percent-top-relative-container-height-unspecified-expected.checksum: Added.
  • platform/chromium-win/fast/css/percent-top-relative-container-height-unspecified-expected.png: Added.
  • platform/chromium-win/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
8:23 PM Changeset in webkit [66173] by aestes@apple.com
  • 2 edits in trunk/LayoutTests

Fix a flakey test.

Rubber-stamped by Jon Honeycutt.

  • fast/replaced/object-with-embed-url-param.html:
8:17 PM Changeset in webkit [66172] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium/test_expectations.txt:
7:58 PM Changeset in webkit [66171] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-08-26 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium/test_expectations.txt:
7:38 PM Changeset in webkit [66170] by aestes@apple.com
  • 3 edits
    4 adds in trunk

Based on a patch by Mihnea Ovidenie <mihnea@adobe.com>.

Reviewed by Darin Adler.

Percentage top value on position:relative descendant not resolved
correctly if containing block height is not specified explicitly.
https://bugs.webkit.org/show_bug.cgi?id=26396

WebCore:

If the containing block height is auto and the element is positioned
relatively, and if the element's top/bottom is percent, then resolve the
top/bottom as auto.

Test: fast/css/percent-top-relative-container-height-unspecified.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetY):

LayoutTests:

  • fast/css/percent-top-relative-container-height-unspecified.html: Added.
  • platform/mac/fast/css/percent-top-relative-container-height-unspecified-expected.checksum: Added.
  • platform/mac/fast/css/percent-top-relative-container-height-unspecified-expected.png: Added.
  • platform/mac/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
7:37 PM Changeset in webkit [66169] by barraclough@apple.com
  • 2 edits in trunk/WebKit2

Speculative windows build fix.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):

7:18 PM Changeset in webkit [66168] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-08-26 James Robinson <jamesr@chromium.org>

Another chromium mac build fix. What a dumb version of GCC.

  • platform/graphics/chromium/GLES2Texture.cpp: (WebCore::GLES2Texture::create):
7:13 PM Changeset in webkit [66167] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-08-26 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix for Chromium-mac.

  • platform/graphics/chromium/Shader.cpp: (WebCore::loadShader):
7:09 PM Changeset in webkit [66166] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • wtf/dtoa.cpp:
6:49 PM Changeset in webkit [66165] by weinig@apple.com
  • 28 edits in trunk/WebKit2

Adopt more uses OwnPtr/OwnArray in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=44728

Reviewed by Darin Adler.

Also clears up weird create vs. adoption semantics. Now both create
and adopt both don't ref their pointers, adoption is just about the
buffer.

  • Shared/ImmutableArray.cpp:

(WebKit::ImmutableArray::ImmutableArray):
(WebKit::ImmutableArray::~ImmutableArray):

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::adopt):

  • Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::keys):

  • Shared/WebData.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::create):

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:]):
(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaProxy::]):

  • UIProcess/API/qt/qgraphicswkview.cpp:

(QGraphicsWKView::QGraphicsWKView):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::init):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::create):

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::create):

  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):

  • UIProcess/WebContext.cpp:

(WebKit::PostMessageEncoder::PostMessageDecoder::decode):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::PostMessageEncoder::PostMessageDecoder::decode):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createPopupMenu):
(WebKit::WebChromeClient::createSearchPopupMenu):

  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::create):

  • WebProcess/WebCoreSupport/WebPopupMenu.h:
  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::create):
(WebKit::WebSearchPopupMenu::WebSearchPopupMenu):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::childFrames):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::close):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::corePage):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

6:41 PM Changeset in webkit [66164] by jamesr@google.com
  • 3 edits in trunk/WebCore

2010-08-26 James Robinson <jamesr@chromium.org>

Fix chromium mac build. Unreviewed.

  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::GLES2Canvas):
  • platform/graphics/chromium/GLES2Texture.cpp: (WebCore::GLES2Texture::load):
6:17 PM Changeset in webkit [66163] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 44735 - Clean up dtoa.cpp
Remove unused & unmaintained code paths, reformat code to match
coding standard & use platform #defines from Platform.h directly.

Patch by Gavin Barraclough <baraclough@apple.com> on 2010-08-26
Reviewed by Sam Weinig.

  • wtf/dtoa.cpp:

(WTF::storeInc):
(WTF::multadd):
(WTF::s2b):
(WTF::lo0bits):
(WTF::mult):
(WTF::pow5mult):
(WTF::lshift):
(WTF::diff):
(WTF::ulp):
(WTF::b2d):
(WTF::d2b):
(WTF::ratio):
(WTF::):
(WTF::strtod):
(WTF::quorem):
(WTF::dtoa):

6:17 PM Changeset in webkit [66162] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip tests that were added in r66144, because WebKit2 doesn't support
layoutTestController.addUserScript yet.

Rubber-stamped by Mark Rowe.

  • platform/mac-wk2/Skipped:
5:56 PM Changeset in webkit [66161] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Darin pointed out that the braces are unnecessary in an Objective-C interface
declaration when there are no data members.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Begone, evil braces!
5:55 PM Changeset in webkit [66160] by dumi@chromium.org
  • 3 edits
    13 adds in trunk/LayoutTests

Unreviewed, more Chromium expectations updates.

  • platform/chromium-linux/fast/doctypes/003-expected.checksum:
  • platform/chromium-linux/fast/doctypes/003-expected.png: Added.
  • platform/chromium-linux/fast/doctypes/003-expected.txt: Added.
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.checksum: Added.
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.png: Added.
  • platform/chromium-linux/transitions/svg-text-shadow-transition-expected.checksum: Added.
  • platform/chromium-linux/transitions/svg-text-shadow-transition-expected.png: Added.
  • platform/chromium-mac/fast/doctypes/003-expected.checksum: Added.
  • platform/chromium-mac/fast/doctypes/003-expected.png: Added.
  • platform/chromium-win/fast/doctypes/003-expected.checksum: Added.
  • platform/chromium-win/fast/doctypes/003-expected.png: Added.
  • platform/chromium-win/fast/doctypes/003-expected.txt: Added.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:38 PM Changeset in webkit [66159] by barraclough@apple.com
  • 12 edits in trunk

Rubber Stamped by Oliver Hunt.

Partially revert r65959. The toString changes regressed the v8 tests,
but keep the toFixed/toExponential/toPrecision changes.

JavaScriptCore:

(JSC::UString::number):

  • wtf/DecimalNumber.h:
  • wtf/dtoa.cpp:

(WTF::append):
(WTF::doubleToStringInJavaScriptFormat):

  • wtf/dtoa.h:
  • wtf/text/WTFString.cpp:
  • wtf/text/WTFString.h:

WebCore:

  • html/HTMLTreeBuilder.cpp:

(WebCore::serializeForNumberType):

5:34 PM Changeset in webkit [66158] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Fix two build issues that are revealed when building with clang.

Reviewed by Adam Roben.

  • platform/mac/PopupMenuMac.h: Forward-declare as an Objective-C class when compiling for Objective-C.
  • platform/network/BlobResourceHandle.h: Forward-declare as a struct to match the real declaration.
5:33 PM Changeset in webkit [66157] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/8339008> WebCore's MediaPlayerPrivateQTKit.mm fails to build with clang.

Reviewed by Sam Weinig.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::mainThreadSetNeedsDisplay): Remove some ambiguity in the return type of -delegate.
Since the message was being sent to a receiver of type id the compiler cannot accurately
determine the return type. Typically this would be resolved by using a more specific type
for the receiver. However, due to lazy loading shenanigans that we play with QTKit we're
unable to directly cast to the relevant type (QTMovieView*). Instead we fake up an interface
with the correct type of the method we care about (-delegate) and cast to that type instead.

5:32 PM Changeset in webkit [66156] by aestes@apple.com
  • 193 edits
    4 adds in trunk

WebCore: If an <embed> is part of an <object> element's fallback content, WebKit
should only render the <embed> if the <object> fails to load.
https://bugs.webkit.org/show_bug.cgi?id=44567
<rdar://problem/7699852>

Reviewed by Darin Adler.

Tests: fast/replaced/invalid-object-with-fallback.html

fast/replaced/object-with-embed-url-param.html

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded): An <embed> now needs a
renderer if its parent is an <object> but the <object> is using fallback
content.

  • html/HTMLObjectElement.h:

(WebCore::HTMLObjectElement::useFallbackContent): Add a public getter
for m_useFallbackContent for use in HTMLEmbedElement::rendererIsNeeded.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::updateWidget): Change the logic that
determines the plug-in parameters to pass to the loader. Do not override
parameters from <object> with those from a child <embed>.

LayoutTests: If an <embed> is part of an <object> element's fallback content, WebKit
should only render it if the <object> fails to load.
https://bugs.webkit.org/show_bug.cgi?id=44567
<rdar://problem/7699852>

Reviewed by Darin Adler.

Add tests for the updated <object>/<embed> behavior.

  • fast/dom/object-embed-plugin-scripting-expected.txt: Updated expected

results.

  • fast/dom/object-embed-plugin-scripting.html: Added additional test

coverage.

  • fast/replaced/invalid-object-with-fallback-expected.txt: Added.
  • fast/replaced/invalid-object-with-fallback.html: Added.
  • fast/replaced/object-with-embed-url-param-expected.txt: Added.
  • fast/replaced/object-with-embed-url-param.html: Added.


The following tests needed to be rebaselined due to WebKit's change in
behavior. There is now an extra space in the output due to WebKit
rendering the fallback content of the <object>'s that fail to load.

  • java/lc3/ArrayMethods/byte-001-expected.txt:
  • java/lc3/ArrayMethods/byte-001.html:
  • java/lc3/ArrayMethods/byte-002-expected.txt:
  • java/lc3/CallStatic/boolean-001-expected.txt:
  • java/lc3/CallStatic/number-001-expected.txt:
  • java/lc3/CallStatic/object-001-expected.txt:
  • java/lc3/Constructors/construct-001-expected.txt:
  • java/lc3/ConvertBoolean/boolean-001-expected.txt:
  • java/lc3/ConvertBoolean/boolean-002-expected.txt:
  • java/lc3/ConvertBoolean/boolean-003-expected.txt:
  • java/lc3/ConvertBoolean/boolean-004-expected.txt:
  • java/lc3/ConvertBoolean/boolean-005-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-006-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-007-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-008-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-009-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-010-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-011-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-012-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-013-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-014-expected.txt:
  • java/lc3/ConvertJSObject/ToBoolean-001-expected.txt:
  • java/lc3/ConvertJSObject/ToByte-001-expected.txt:
  • java/lc3/ConvertJSObject/ToByte-002-expected.txt:
  • java/lc3/ConvertJSObject/ToChar-001-expected.txt:
  • java/lc3/ConvertJSObject/ToChar-002-expected.txt:
  • java/lc3/ConvertJSObject/ToDouble-001-expected.txt:
  • java/lc3/ConvertJSObject/ToFloat-001-expected.txt:
  • java/lc3/ConvertJSObject/ToInt-001-expected.txt:
  • java/lc3/ConvertJSObject/ToInt-002-expected.txt:
  • java/lc3/ConvertJSObject/ToJSObject-001-expected.txt:
  • java/lc3/ConvertJSObject/ToLong-001-expected.txt:
  • java/lc3/ConvertJSObject/ToLong-002-expected.txt:
  • java/lc3/ConvertJSObject/ToObject-001-expected.txt:
  • java/lc3/ConvertJSObject/ToShort-001-expected.txt:
  • java/lc3/ConvertJSObject/ToShort-002-expected.txt:
  • java/lc3/ConvertJSObject/ToString-001-expected.txt:
  • java/lc3/ConvertNull/null-001-expected.txt:
  • java/lc3/ConvertNull/null-002-expected.txt:
  • java/lc3/ConvertNull/null-003-n-expected.txt:
  • java/lc3/ConvertNull/null-004-n-expected.txt:
  • java/lc3/ConvertNull/null-005-expected.txt:
  • java/lc3/ConvertNull/null-006-n-expected.txt:
  • java/lc3/ConvertNumber/number-001-expected.txt:
  • java/lc3/ConvertNumber/number-002-expected.txt:
  • java/lc3/ConvertNumber/number-003-expected.txt:
  • java/lc3/ConvertNumber/number-004-expected.txt:
  • java/lc3/ConvertNumber/number-005-expected.txt:
  • java/lc3/ConvertNumber/number-006-expected.txt:
  • java/lc3/ConvertNumber/number-007-expected.txt:
  • java/lc3/ConvertNumber/number-008-expected.txt:
  • java/lc3/ConvertNumber/number-009-expected.txt:
  • java/lc3/ConvertNumber/number-010-expected.txt:
  • java/lc3/ConvertNumber/number-011-expected.txt:
  • java/lc3/ConvertString/string-001-expected.txt:
  • java/lc3/ConvertString/string-002-expected.txt:
  • java/lc3/ConvertString/string-003-expected.txt:
  • java/lc3/ConvertString/string-004-n-expected.txt:
  • java/lc3/ConvertString/string-005-n-expected.txt:
  • java/lc3/ConvertString/string-006-expected.txt:
  • java/lc3/ConvertString/string-007-n-expected.txt:
  • java/lc3/ConvertUndefined/undefined-001-n-expected.txt:
  • java/lc3/ConvertUndefined/undefined-002-expected.txt:
  • java/lc3/ConvertUndefined/undefined-003-expected.txt:
  • java/lc3/Exceptions/throw_js_types-expected.txt:
  • java/lc3/JSBoolean/boolean-001-expected.txt:
  • java/lc3/JSBoolean/boolean-002-n-expected.txt:
  • java/lc3/JSBoolean/boolean-003-n-expected.txt:
  • java/lc3/JSBoolean/boolean-004-n-expected.txt:
  • java/lc3/JSBoolean/boolean-005-n-expected.txt:
  • java/lc3/JSBoolean/boolean-006-n-expected.txt:
  • java/lc3/JSBoolean/boolean-007-n-expected.txt:
  • java/lc3/JSBoolean/boolean-008-n-expected.txt:
  • java/lc3/JSNull/ToBoolean-001-n-expected.txt:
  • java/lc3/JSNull/ToFloat-001-n-expected.txt:
  • java/lc3/JSNull/ToLong-001-n-expected.txt:
  • java/lc3/JSNull/ToNumber-001-n-expected.txt:
  • java/lc3/JSNull/ToObject-001-expected.txt:
  • java/lc3/JSNumber/ToByte-001-expected.txt:
  • java/lc3/JSNumber/ToByte-002-n-expected.txt:
  • java/lc3/JSNumber/ToByte-003-n-expected.txt:
  • java/lc3/JSNumber/ToByte-004-expected.txt:
  • java/lc3/JSNumber/ToByte-005-n-expected.txt:
  • java/lc3/JSNumber/ToChar-001-expected.txt:
  • java/lc3/JSNumber/ToChar-002-n-expected.txt:
  • java/lc3/JSNumber/ToChar-003-n-expected.txt:
  • java/lc3/JSNumber/ToChar-004-expected.txt:
  • java/lc3/JSNumber/ToChar-005-n-expected.txt:
  • java/lc3/JSNumber/ToChar-006-n-expected.txt:
  • java/lc3/JSNumber/ToDouble-001-expected.txt:
  • java/lc3/JSNumber/ToDouble-002-expected.txt:
  • java/lc3/JSNumber/ToDouble-003-expected.txt:
  • java/lc3/JSNumber/ToInt-001-expected.txt:
  • java/lc3/JSNumber/ToInt-002-n-expected.txt:
  • java/lc3/JSNumber/ToInt-003-n-expected.txt:
  • java/lc3/JSNumber/ToInt-004-expected.txt:
  • java/lc3/JSNumber/ToInt-005-n-expected.txt:
  • java/lc3/JSNumber/ToLong-001-expected.txt:
  • java/lc3/JSNumber/ToLong-002-n-expected.txt:
  • java/lc3/JSNumber/ToLong-003-n-expected.txt:
  • java/lc3/JSNumber/ToLong-004-n-expected.txt:
  • java/lc3/JSNumber/ToLong-005-n-expected.txt:
  • java/lc3/JSNumber/ToLong-006-n-expected.txt:
  • java/lc3/JSNumber/ToLong-007-n-expected.txt:
  • java/lc3/JSNumber/ToLong-008-n-expected.txt:
  • java/lc3/JSNumber/ToLong-009-n-expected.txt:
  • java/lc3/JSNumber/ToLong-010-n-expected.txt:
  • java/lc3/JSNumber/ToLong-011-n-expected.txt:
  • java/lc3/JSNumber/ToShort-001-expected.txt:
  • java/lc3/JSNumber/ToShort-002-n-expected.txt:
  • java/lc3/JSNumber/ToShort-003-n-expected.txt:
  • java/lc3/JSNumber/ToShort-004-expected.txt:
  • java/lc3/JSNumber/ToShort-005-n-expected.txt:
  • java/lc3/JSObject/ToByte-001-expected.txt:
  • java/lc3/JSObject/ToChar-001-expected.txt:
  • java/lc3/JSObject/ToDouble-001-expected.txt:
  • java/lc3/JSObject/ToDouble-002-n-expected.txt:
  • java/lc3/JSObject/ToDouble-003-n-expected.txt:
  • java/lc3/JSObject/ToFloat-001-expected.txt:
  • java/lc3/JSObject/ToFloat-002-n-expected.txt:
  • java/lc3/JSObject/ToFloat-003-n-expected.txt:
  • java/lc3/JSObject/ToInt-001-expected.txt:
  • java/lc3/JSObject/ToInt-002-expected.txt:
  • java/lc3/JSObject/ToJSObject-001-expected.txt:
  • java/lc3/JSObject/ToLong-001-expected.txt:
  • java/lc3/JSObject/ToObject-001-expected.txt:
  • java/lc3/JSObject/ToShort-001-expected.txt:
  • java/lc3/JSObject/ToString-001-expected.txt:
  • java/lc3/JSUndefined/undefined-001-expected.txt:
  • java/lc3/JSUndefined/undefined-002-n-expected.txt:
  • java/lc3/JSUndefined/undefined-003-n-expected.txt:
  • java/lc3/JSUndefined/undefined-004-n-expected.txt:
  • java/lc3/JSUndefined/undefined-005-n-expected.txt:
  • java/lc3/JSUndefined/undefined-006-n-expected.txt:
  • java/lc3/JSUndefined/undefined-007-n-expected.txt:
  • java/lc3/JSUndefined/undefined-008-n-expected.txt:
  • java/lc3/JSUndefined/undefined-009-n-expected.txt:
  • java/lc3/JSUndefined/undefined-010-n-expected.txt:
  • java/lc3/JavaArray/ToArray-001-expected.txt:
  • java/lc3/JavaArray/ToArray-002-n-expected.txt:
  • java/lc3/JavaArray/ToBoolean-001-n-expected.txt:
  • java/lc3/JavaArray/ToString-001-expected.txt:
  • java/lc3/JavaClass/ToClass-001-expected.txt:
  • java/lc3/JavaClass/ToJSObject-001-expected.txt:
  • java/lc3/JavaClass/ToObject-001-expected.txt:
  • java/lc3/JavaClass/ToString-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectBeanProps-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectFieldOrMethod-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectToBoolean-001-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToBoolean-002-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToByte-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectToByte-002-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToByte-003-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToByte-004-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToByte-005-expected.txt:
  • java/lc3/JavaObject/JavaObjectToByte-006-expected.txt:
  • java/lc3/JavaObject/JavaObjectToByte-007-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToByte-008-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToChar-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectToChar-002-expected.txt:
  • java/lc3/JavaObject/JavaObjectToChar-003-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToChar-004-expected.txt:
  • java/lc3/JavaObject/JavaObjectToChar-005-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToChar-006-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToDouble-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectToFloat-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectToInt-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectToInt-002-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToInt-003-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToInt-004-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToLong-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectToLong-002-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToLong-003-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToLong-004-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToLong-005-expected.txt:
  • java/lc3/JavaObject/JavaObjectToLong-006-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToShort-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectToShort-002-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToShort-003-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToShort-004-n-expected.txt:
  • java/lc3/JavaObject/JavaObjectToShort-005-expected.txt:
  • java/lc3/JavaObject/JavaObjectToShort-006-expected.txt:
  • java/lc3/JavaObject/JavaObjectToString-001-expected.txt:
  • java/lc3/StringMethods/string-001-expected.txt:
  • java/lc3/forin/object-001-expected.txt:
  • java/lc3/instanceof/instanceof-001-expected.txt:
5:17 PM Changeset in webkit [66155] by jamesr@google.com
  • 17 edits in trunk

2010-08-26 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] Remove the USE(GLES2_RENDERING) define and associated code
https://bugs.webkit.org/show_bug.cgi?id=43761

Remove WTF_USE_GLES2_RENDERING from the list of defines in chromium, it's unused.

  • wtf/Platform.h:

2010-08-26 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] Remove the USE(GLES2_RENDERING) define and associated code
https://bugs.webkit.org/show_bug.cgi?id=43761

USE(GLES2_RENDERING) will not be useful since we'll be coding to GraphicsContext3D
instead of OpenGL and can use ENABLE(ACCELERATED_2D_CANVAS) for canvas 2d specific
changes. This deletes the macro and deletes the ChromeClient API to query
GLES2Contexts since we'll never need one of these outside of the compositor, which
is created in platform-specific code.

  • loader/EmptyClients.h:
  • page/ChromeClient.h:
  • platform/graphics/chromium/GLES2Canvas.cpp:
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/chromium/GLES2Texture.cpp:
  • platform/graphics/chromium/GLES2Texture.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::setGraphicsContext3D): (WebCore::GraphicsContext::syncSoftwareCanvas):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::drawBitmapGLES2): (WebCore::BitmapImage::draw): (WebCore::BitmapImageSingleFrameSkia::draw):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::PlatformContextSkia): (WebCore::PlatformContextSkia::~PlatformContextSkia):
  • platform/graphics/skia/PlatformContextSkia.h:

2010-08-26 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

[chromium] Remove the USE(GLES2_RENDERING) define and associated code
https://bugs.webkit.org/show_bug.cgi?id=43761

Removes API support to grab a GLES2Context from within WebCore. The compositor
has a special codepath to grab its GLES2Context and no other codepaths
need access to a raw context. Accelerated drawing elsewhere will go through
GraphicsContext3D.

  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:
5:09 PM Changeset in webkit [66154] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

REGRESSION: rebaseline needed for tables/mozilla_expected_failures/bugs/bug56024.html
https://bugs.webkit.org/show_bug.cgi?id=44733

The failure was caused by color property moving from anonymous block to the form element inside
the anonymous block. Rebaselined /tables/mozilla_expected_failures/bugs/bug56024.html for mac.

  • platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
5:04 PM Changeset in webkit [66153] by Darin Adler
  • 2 edits in trunk/LayoutTests

Fix tests that rely on incorrect implementation of HTMLBaseElement
to work even if it's implemented as described in HTML5.

Reviewed by Sam Weinig.

  • fast/url/resources/utilities.js:

(setBaseURL): Remove existing base elements as well as adding a new
base element.

5:02 PM Changeset in webkit [66152] by weinig@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Remove conflict markers.

4:43 PM Changeset in webkit [66151] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-08-26 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+, after a bad merge.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMozillaGtkWidget):
4:21 PM Changeset in webkit [66150] by barraclough@apple.com
  • 23 edits in trunk/JavaScriptCore

Rolling out r64608, this regressed performance.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::~LinkBuffer):
(JSC::LinkBuffer::performFinalization):

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::executableCopy):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::executableCopy):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initGetByIdSelfList):
(JSC::StructureStubInfo::initGetByIdProtoList):
(JSC::StructureStubInfo::initPutByIdTransition):

  • jit/ExecutableAllocator.cpp:

(JSC::ExecutablePool::systemAlloc):

  • jit/ExecutableAllocator.h:

(JSC::ExecutablePool::create):
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::poolForSize):
(JSC::ExecutablePool::ExecutablePool):
(JSC::ExecutablePool::poolAllocate):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::allocInternal):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JSC::JIT::compilePatchGetArrayLength):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITStubs.cpp:

(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):

  • jit/JITStubs.h:
  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • runtime/ExceptionHelpers.cpp:
  • runtime/ExceptionHelpers.h:
  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):

  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::compile):

4:11 PM Changeset in webkit [66149] by dumi@chromium.org
  • 3 edits
    8 adds
    7 deletes in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-mac/fast/doctypes/003-expected.checksum: Removed.
  • platform/chromium-mac/fast/doctypes/003-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt: Added.
  • platform/chromium-win/fast/doctypes/003-expected.checksum: Removed.
  • platform/chromium-win/fast/doctypes/003-expected.png: Removed.
  • platform/chromium-win/fast/doctypes/003-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/chromium-win/svg/css/composite-shadow-text-expected.checksum: Added.
  • platform/chromium-win/svg/css/composite-shadow-text-expected.png: Added.
  • platform/chromium-win/svg/css/composite-shadow-text-expected.txt: Added.
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.txt:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt: Removed.
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.checksum: Added.
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.png: Added.
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:06 PM Changeset in webkit [66148] by mrobinson@webkit.org
  • 5 edits in trunk/WebCore

2010-08-23 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] ScrollbarThemeGtk is incomplete
https://bugs.webkit.org/show_bug.cgi?id=44471

Add theme drawing code for GTK+ scrollbars. Turn RenderThemeGtk::paintMozillaWidget
into a public method so that ScrollbarThemeGtk can access Mozilla theme API properly.

Tests for this issue will be activated in the form of pixel tests, but
only after fully-fake scrollbars are activated.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMozillaGtkWidget): Added this public method which takes the proper widget state, widget type, graphics context and rectangle and renders a widget using the Mozilla theming API. (WebCore::RenderThemeGtk::paintRenderObject): Added this method which first calculates the widget state before passing the information on to paintMozillaGtkWidget. (WebCore::RenderThemeGtk::paintCheckbox): Switch to use paintRenderObject. (WebCore::RenderThemeGtk::paintRadio): Switch to use paintRenderObject. (WebCore::RenderThemeGtk::paintButton): Switch to use paintRenderObject. (WebCore::RenderThemeGtk::paintMenuList): Switch to use paintRenderObject. (WebCore::RenderThemeGtk::paintTextField): Switch to use paintRenderObject. (WebCore::RenderThemeGtk::paintSliderTrack): Switch to use paintRenderObject. (WebCore::RenderThemeGtk::paintSliderThumb): Switch to use paintRenderObject. (WebCore::RenderThemeGtk::paintProgressBar): Switch to use paintRenderObject.
  • platform/gtk/RenderThemeGtk.h: Added new method declarations.
  • platform/gtk/ScrollbarThemeGtk.cpp: Added code which can render GTK+ scrollbars. (WebCore::ScrollbarThemeGtk::hasThumb): Added. (WebCore::ScrollbarThemeGtk::backButtonRect): Added. (WebCore::ScrollbarThemeGtk::forwardButtonRect): Added. (WebCore::ScrollbarThemeGtk::trackRect): Added. (WebCore::ScrollbarThemeGtk::paintTrackBackground): Added. (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Added. (WebCore::ScrollbarThemeGtk::paintThumb): Added. (WebCore::ScrollbarThemeGtk::thumbRect): Added. (WebCore::ScrollbarThemeGtk::paint): Added. (WebCore::ScrollbarThemeGtk::paintButton): Added. (WebCore::ScrollbarThemeGtk::paintScrollCorner): Added. (WebCore::ScrollbarThemeGtk::shouldCenterOnThumb): Added. (WebCore::ScrollbarThemeGtk::scrollbarThickness): Always get the metrics from the theme drawing API so that it stays up to date with theme changes. (WebCore::ScrollbarThemeGtk::buttonSize): Added. (WebCore::ScrollbarThemeGtk::minimumThumbLength): Added.
  • platform/gtk/ScrollbarThemeGtk.h: (WebCore::ScrollbarThemeGtk::hasButtons): Added. (WebCore::ScrollbarThemeGtk::initialAutoscrollTimerDelay): Added. (WebCore::ScrollbarThemeGtk::autoscrollTimerDelay): Added.
4:03 PM Changeset in webkit [66147] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2010-08-26 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; rebaseline for r66122.

  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
4:03 PM Changeset in webkit [66146] by ap@apple.com
  • 13 edits in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=44726
<rdar://problem/7935518> WebFrameProxies aren't destroyed until a page is destroyed

Since frames can be moved across documents, they are not really a Page level concept.
Moved frame tracking to WebProcess/WebProcessProxy.

3:59 PM Changeset in webkit [66145] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-26 Martin Robinson <mrobinson@igalia.com>

Updating expected results after r66115.

  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
3:54 PM Changeset in webkit [66144] by bweinstein@apple.com
  • 1 edit
    3 copies
    8 adds in trunk/LayoutTests

Userscripts on special documents should be tested
<https://bugs.webkit.org/show_bug.cgi?id=44725>

Reviewed by Dave Hyatt.

Add tests of user script injection in audio, image, plugin, and video documents.

  • userscripts/user-script-audio-document.html: Added. Test injection of user scripts

in an audio document.

  • userscripts/user-script-audio-document-expected.txt: Added.
  • userscripts/user-script-image-document.html: Added. Test injection of user scripts

in an image document.

  • userscripts/user-script-image-document-expected.txt: Added.
  • userscripts/user-script-plugin-document.html: Added. Test injection of user scripts

in a plugin document.

  • userscripts/user-script-plugin-document-expected.txt: Added.
  • userscripts/user-script-video-document.html: Added. Test injection of user scripts

in a video document.

  • userscripts/user-script-video-document-expected.txt: Added.


  • userscripts/resources/abe.png: Copied from media/content/abe.png.
  • userscripts/resources/counting.mp4: Copied from media/content/counting.mp4.
  • userscripts/resources/test.wav: Copied from media/content/test.wav.
3:36 PM Changeset in webkit [66143] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-08-26 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; build fix.

Speculative chromium mac fix by including "Color.h".

  • platform/graphics/chromium/Shader.cpp:
3:22 PM Changeset in webkit [66142] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 44655 - Add debug only convenience methods to obtain a Vector<char> from a String/StringImpl.

Reviewed by Brady Eidson.

  • wtf/text/WTFString.cpp:

(asciiDebug):

Return a Vector<char> containing the contents of a string as ASCII.

3:15 PM Changeset in webkit [66141] by Simon Fraser
  • 15 edits
    7 adds in trunk

2010-08-26 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

CSS downloads all background images related to element, instead of just final rule
https://bugs.webkit.org/show_bug.cgi?id=24223

We used to kick off image loads at the point where the style selector
applies a CSS rule to an element, even if that rule was overridden
by a rule in a later block of rules. This caused loads of images that
weren't actually used.

Fix this by delaying image loads until the style has been fully
resolved. This is achieved by inserting a StylePendingImage into
the RenderStyle for duration of the style resolution, and keeping
an entry in a hash for the relevant CSS property.

At the end of style resolution, we iterate through the hash, and
replace the StylePendingImage with StyleCachedImages, which
causes the loads to happen only for images that are in the final style.

Tests: http/tests/css/border-image-loading.html

http/tests/css/mask-image-loading.html
http/tests/css/reflection-mask-image-loading.html

  • GNUmakefile.am: Add StylePendingImage.h
  • WebCore.gypi: Ditto
  • WebCore.vcproj/WebCore.vcproj: Ditto
  • css/CSSImageValue.h: Change m_image to a RefPtr<StyleImage>, since it may be a StylePendingImage or StyleCachedImage.
  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::~CSSImageValue): Only call removeClient if it's a cachedImage. (WebCore::CSSImageValue::cachedOrPendingImage): If we have an image (pending or cached), return it. Otherwise make a pending image and return it. (WebCore::CSSImageValue::cachedImage): Only return the image if it's a cached image. (WebCore::CSSImageValue::cachedImageURL): (WebCore::CSSImageValue::clearCachedImage):
  • css/CSSStyleSelector.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): Clear m_pendingImageProperties. (WebCore::CSSStyleSelector::styleForElement): Load pending images. (WebCore::CSSStyleSelector::styleForKeyframe): Ditto. (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto. (WebCore::CSSStyleSelector::styleForPage): Ditto. (WebCore::CSSStyleSelector::applyProperty): Pull property into a local variable so we can use it in macros. (WebCore::CSSStyleSelector::mapFillAttachment): Pass the property down (needed to avoid additional macro complexity). (WebCore::CSSStyleSelector::mapFillClip): Ditto (WebCore::CSSStyleSelector::mapFillComposite): Ditto (WebCore::CSSStyleSelector::mapFillOrigin): Ditto (WebCore::CSSStyleSelector::styleImage): Call cachedOrPendingFromValue() (WebCore::CSSStyleSelector::cachedOrPendingFromValue): Get the cachedOrPendingImage() from the CSSValue, and if it's a pending image, record the property. (WebCore::CSSStyleSelector::mapFillImage): Pass the property down (needed to avoid additional macro complexity). (WebCore::CSSStyleSelector::mapFillRepeatX): Ditto (WebCore::CSSStyleSelector::mapFillRepeatY): Ditto (WebCore::CSSStyleSelector::mapFillSize): Ditto (WebCore::CSSStyleSelector::mapFillXPosition): Ditto (WebCore::CSSStyleSelector::mapFillYPosition): Ditto (WebCore::CSSStyleSelector::mapNinePieceImage): Ditto (WebCore::CSSStyleSelector::loadPendingImages): Iterate through the m_pendingImageProperties hash, and replace the pending images with cached images.
  • rendering/style/StyleCachedImage.h: Make cssValue() const.
  • rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::cssValue):
  • rendering/style/StyleGeneratedImage.h: Make cssValue() const.
  • rendering/style/StyleGeneratedImage.cpp: (WebCore::StyleGeneratedImage::cssValue):
  • rendering/style/StyleImage.h: (WebCore::StyleImage::operator==): Make const. (WebCore::StyleImage::isPendingImage):
  • rendering/style/StylePendingImage.h: Added.
3:15 PM Changeset in webkit [66140] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKitTools

<rdar://problem/8334338> run-webkit-tests sometimes hangs when using
WebKitTestRunner (44331)

Reviewed by Darin Adler.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
The hang occurs when WebKitTestRunner begins launching the WebKit2
web process then exits before it finishes launching. Work around this by
looking for the --print-supported-features argument and exiting without
creating the web process.

2:56 PM WebKitGTKFonts edited by mrobinson@webkit.org
(diff)
2:54 PM WebKitGTKFonts edited by mrobinson@webkit.org
(diff)
2:38 PM Changeset in webkit [66139] by weinig@apple.com
  • 11 edits
    5 adds in trunk

Add PassOwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=44627

Reviewed by Darin Adler.

JavaScriptCore:

Add the new files.

  • wtf/Forward.h:

Forward declare PassOwnArrayPtr.

  • wtf/OwnArrayPtr.h:

Mimic the OwnPtr interface.

  • wtf/OwnArrayPtrCommon.h: Added.

(WTF::deleteOwnedArrayPtr):
Move delete function here so it can be shared by OwnArrayPtr and
PassOwnArrayPtr.

  • wtf/PassOwnArrayPtr.h: Added.

Mimic the PassOwnPtr interface.

JavaScriptGlue:

Add new forwarding header.

  • ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Added.

WebCore:

Add new forwarding headers.

  • ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Added.
  • ForwardingHeaders/wtf/PassOwnArrayPtr.h: Added.

WebKit2:

  • UIProcess/WebContext.cpp:

(WebKit::PostMessageEncoder::PostMessageDecoder::decode):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::PostMessageEncoder::PostMessageDecoder::decode):

2:34 PM Changeset in webkit [66138] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-08-26 Stanislav Brabec <sbrabec@suse.cz>

Reviewed by Martin Robinson.

[GTK] [PATCH] plugin loading invalid symlink evaluation deadlock
https://bugs.webkit.org/show_bug.cgi?id=44683

Fix symlink resolution in PluginPackageGtk.

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load): g_file_resolve_relative_path must be called with a a directory, not a file.
2:32 PM Changeset in webkit [66137] by aestes@apple.com
  • 3 edits
    2 adds in trunk

A URL in a <param> should be parsed the same as if it were specified as
the data attribute of an <object>.
https://bugs.webkit.org/show_bug.cgi?id=44671

Reviewed by Eric Carlson.

WebCore:

Test: fast/replaced/object-param-url-control-char.html

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::updateWidget): Call deprecatedParseURL()
on <param> values of names that we treat as URLs ("src", "movie", "code"
and "url").

LayoutTests:

  • fast/replaced/object-param-url-control-char-expected.txt: Added.
  • fast/replaced/object-param-url-control-char.html: Added.
2:31 PM Changeset in webkit [66136] by senorblanco@chromium.org
  • 2 edits in trunk/WebCore

2010-08-26 Stephen White <senorblanco@chromium.org>

Unreviewed; build fix.

Fix for Chromium/Mac.

  • platform/graphics/chromium/Shader.cpp:
2:24 PM Changeset in webkit [66135] by oliver@apple.com
  • 4 edits
    3 adds in trunk

2010-08-26 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[JSC] JavaScript parsing error when loading Equifax web page
https://bugs.webkit.org/show_bug.cgi?id=42900

'-->' is ostensibly only meant to occur when there is only
whitespace preceeding it on the line. However firefox treats
multiline comments as a space character, so they are allowed.
One side effect of the firefox model is that any line terminators
inside the multiline comment are ignored, so

foo/*
*/-->

is treated as

foo -->

and so '-->' will not be a comment in this case. Happily this simply
means that to fix this issue all we need to do is stop updating
m_atLineStart when handling multiline comments.

  • parser/Lexer.cpp: (JSC::Lexer::lex):

2010-08-26 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[JSC] JavaScript parsing error when loading Equifax web page
https://bugs.webkit.org/show_bug.cgi?id=42900

Add tests for the many idiosyncrasies of --> comments

  • fast/js/parser-xml-close-comment-expected.txt: Added.
  • fast/js/parser-xml-close-comment.html: Added.
  • fast/js/script-tests/parser-high-byte-character.js:
  • fast/js/script-tests/parser-xml-close-comment.js: Added.
2:22 PM Changeset in webkit [66134] by tony@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2010-08-26 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

Rename platform/chromium/plugins/get-url-with-blank-target.html to
platform/chromium/plugins/get-url-with-blank-target2.html so it
doesn't confuse the deduplicate tests script.

  • platform/chromium/plugins/get-url-with-blank-target2-expected.txt: Copied from LayoutTests/plugins/get-url-with-blank-target-expected.txt.
  • platform/chromium/plugins/get-url-with-blank-target2.html: Renamed from LayoutTests/platform/chromium/plugins/get-url-with-blank-target.html.
2:05 PM Changeset in webkit [66133] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-08-26 Tony Chang <tony@chromium.org>

Reviewed by David Hyatt.

crash when rendering scrollbar gradient
https://bugs.webkit.org/show_bug.cgi?id=44549

  • scrollbars/scrollbar-gradient-crash-expected.txt: Added.
  • scrollbars/scrollbar-gradient-crash.html: Added.

2010-08-26 Tony Chang <tony@chromium.org>

Reviewed by David Hyatt.

crash when rendering scrollbar gradient
https://bugs.webkit.org/show_bug.cgi?id=44549

Test: scrollbars/scrollbar-gradient-crash.html

  • css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::getImage): Keep this alive.
1:56 PM Changeset in webkit [66132] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-26 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

increase number of gc's in perf tests
https://bugs.webkit.org/show_bug.cgi?id=44710

Extending the speculative attempt to make the perf tests less flaky.

  • resources/magnitude-perf.js: (Magnitude._runIteration): (Magnitude):
1:54 PM Changeset in webkit [66131] by rniwa@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-08-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

[chromium] WebEntities is broken
https://bugs.webkit.org/show_bug.cgi?id=44708

For serialization purposes, we don't need to convert all entity references.
This patch modifies WebEntities::WebEntities to use hard-coded entity lists for both HTML and XML,
and deletes populateMapFromXMLEntities and populateMapFromHTMLEntityTable.

No tests are added since the code is tested in DomSerializerTests

  • src/WebEntities.cpp: (WebKit::): (WebKit::WebEntities::WebEntities):
1:33 PM Changeset in webkit [66130] by senorblanco@chromium.org
  • 4 edits
    2 adds in trunk/WebCore

2010-08-26 Stephen White <senorblanco@chromium.org>

Reviewed by Kenneth Russell.

[CHROMIUM] Give <canvas> 2D shaders their own class hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=44682

Covered by fast/canvas layout tests.

  • WebCore.gypi: Add Shader.cpp, Shader.h to chromium build.
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::GLES2Canvas): (WebCore::GLES2Canvas::~GLES2Canvas): (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::drawTexturedRectTile): Rip out all shader initialization and compilation code. Instantiate specialized shaders instead.
  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/chromium/Shader.cpp: Added. (WebCore::affineTo3x3): (WebCore::Shader::Shader): (WebCore::Shader::~Shader): Implement Shader base class. (WebCore::loadShader): (WebCore::loadProgram): Utility functions refactored from GLES2Canvas. (WebCore::SolidFillShader::SolidFillShader): (WebCore::TexShader::TexShader): (WebCore::SolidFillShader::create): (WebCore::SolidFillShader::use): (WebCore::TexShader::create): (WebCore::TexShader::use):
  • platform/graphics/chromium/Shader.h: Added.
1:20 PM Changeset in webkit [66129] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

User scripts injected at start are not run for plugin and media documents
<https://bugs.webkit.org/show_bug.cgi?id=44711>
<rdar://problem/8359288>

Reviewed by Adam Roben.

http://trac.webkit.org/changeset/61271 made scripts injected at start run on ImageDocuments,
but didn't implement this behavior for MediaDocuments and PluginDocuments.

  • loader/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure): Make sure we fire dispatchDocumentElementAvailable.

  • loader/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure): Ditto.

1:15 PM Changeset in webkit [66128] by Simon Fraser
  • 2 edits
    5 adds in trunk/LayoutTests

2010-08-26 Simon Fraser <Simon Fraser>

Reviewed by Alexey Proskuryakov.

Make it possible for http tests to log resource requests
https://bugs.webkit.org/show_bug.cgi?id=44702

Enhance network-simulator.php to be able to log resource
requests to a file, and then return the list of requests.

Test with a new loading test that logs CSS-related image requests.

  • http/tests/css/css-image-loading-expected.txt: Added.
  • http/tests/css/css-image-loading.html: Added.
  • http/tests/css/resources/request-logging.js: Added. (CallCommand): (startTest): (endTest): (getResourceLog):
  • http/tests/resources/network-simulator.php:
1:00 PM Changeset in webkit [66127] by tony@chromium.org
  • 1 edit
    82 deletes in trunk/LayoutTests

2010-08-26 Tony Chang <tony@chromium.org>

Not reviewed. Removing chromium-mac and chromium test results that deduplicate-tests says are not necessary.

  • platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.checksum: Removed.
  • platform/chromium-mac/animations/state-at-end-event-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/5390681-2-expected.checksum: Removed.
  • platform/chromium-mac/editing/execCommand/4641880-2-expected.txt: Removed.
  • platform/chromium-mac/editing/execCommand/4916541-expected.txt: Removed.
  • platform/chromium-mac/editing/execCommand/5138441-expected.checksum: Removed.
  • platform/chromium-mac/editing/execCommand/5138441-expected.txt: Removed.
  • platform/chromium-mac/editing/execCommand/5481523-expected.checksum: Removed.
  • platform/chromium-mac/editing/execCommand/5481523-expected.txt: Removed.
  • platform/chromium-mac/editing/execCommand/indent-selection-expected.checksum: Removed.
  • platform/chromium-mac/editing/execCommand/indent-selection-expected.txt: Removed.
  • platform/chromium-mac/editing/selection/4960116-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/select-text-overflow-ellipsis-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/svg-as-background-2-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/svg-as-mask-expected.checksum: Removed.
  • platform/chromium-mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/svg-as-border-image-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/apple-prefix-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/compare-content-style-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/compare-content-style-expected.txt: Removed.
  • platform/chromium-mac/fast/css/css3-space-in-nth-and-lang-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/first-letter-first-line-hover-expected.txt: Removed.
  • platform/chromium-mac/fast/css/font-face-woff-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/font-face-woff-expected.txt: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-comments-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-empty-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-escapes-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/namespaces/namespaces-invalid-at-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.checksum: Removed.
  • platform/chromium-mac/fast/dom/Window/window-open-pending-url-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/clone-contents-0-end-offset-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/replaceChild-expected.txt: Removed.
  • platform/chromium-mac/fast/encoding/invalid-UTF-8-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/textarea-scrollbar-expected.checksum: Removed.
  • platform/chromium-mac/fast/frames/take-focus-from-iframe-expected.checksum: Removed.
  • platform/chromium-mac/fast/js/missing-title-end-tag-js-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/anonymous-items-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/markers-in-selection-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/column-count-with-rules-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Removed.
  • platform/chromium-mac/fast/overflow/line-clamp-expected.checksum: Removed.
  • platform/chromium-mac/fast/reflections/opacity-reflection-transform-expected.checksum: Removed.
  • platform/chromium-mac/fast/runin/generated2-expected.checksum: Removed.
  • platform/chromium-mac/fast/runin/generated3-expected.checksum: Removed.
  • platform/chromium-mac/fast/runin/generated4-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/early-table-layout-expected.txt: Removed.
  • platform/chromium-mac/fast/text/format-control-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/stripNullFromText-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/text-letter-spacing-expected.txt: Removed.
  • platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt: Removed.
  • platform/chromium-mac/http/tests/misc/slow-loading-mask-expected.checksum: Removed.
  • platform/chromium-mac/media/video-layer-crash-expected.txt: Removed.
  • platform/chromium-mac/media/video-transformed-expected.txt: Removed.
  • platform/chromium-mac/media/video-zoom-expected.txt: Removed.
  • platform/chromium-mac/svg/css/circle-in-mask-with-shadow-expected.checksum: Removed.
  • platform/chromium-mac/svg/css/css-box-min-width-expected.checksum: Removed.
  • platform/chromium-mac/svg/css/mask-with-shadow-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/container-opacity-clip-viewBox-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/fill-opacity-hsl-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/fill-opacity-rgba-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/gradient-stop-corner-cases-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/js-update-bounce-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/mask-invalidation-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/massive-coordinates-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/transformedMaskFails-expected.checksum: Removed.
  • platform/chromium-mac/svg/filters/feColorMatrix-values-expected.checksum: Removed.
  • platform/chromium-mac/tables/layering/paint-test-layering-1-expected.txt: Removed.
  • platform/chromium-mac/tables/layering/paint-test-layering-2-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.txt: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug6674-expected.checksum: Removed.
  • platform/chromium-mac/transforms/svg-vs-css-expected.checksum: Removed.
  • platform/chromium-mac/transitions/transition-end-event-rendering-expected.checksum: Removed.
  • platform/chromium-mac/webarchive/test-link-rel-icon-expected.checksum: Removed.
  • platform/chromium/http/tests/inspector/resource-parameters-expected.txt: Removed.
  • platform/chromium/plugins/get-url-with-blank-target-expected.txt: Removed.
12:57 PM Changeset in webkit [66126] by pkasting@chromium.org
  • 20 edits in trunk

Misc. cleanup split off from bug 32356.
https://bugs.webkit.org/show_bug.cgi?id=44696

Reviewed by Dimitri Glazkov.

WebCore:

  • WebCore.gyp/WebCore.gyp:
  • dom/Element.cpp:

(WebCore::localZoomForRenderer):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::scroll):

  • platform/Scrollbar.h:

(WebCore::Scrollbar::isScrollbar):

  • platform/ScrollbarClient.h:

(WebCore::ScrollbarClient::~ScrollbarClient):

  • platform/qt/ScrollbarQt.cpp:

(WebCore::Scrollbar::contextMenu):

  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scroll):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.h:
  • rendering/RenderTextControlSingleLine.h:

WebKit/chromium:

  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbarImpl::setLocation):
(WebKit::WebScrollbarImpl::onMouseWheel):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::propagateScroll):

  • src/win/WebInputEventFactory.cpp:

(WebKit::WebInputEventFactory::mouseWheelEvent):

WebKit2:

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

12:46 PM Changeset in webkit [66125] by dpranke@chromium.org
  • 5 edits in trunk/WebKitTools

2010-08-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add rebaselining tests for test_expectations

This patch adds more unit tests for the rebaselining code in the
test_expectations module. It doesn't add any tests for
rebaseline_chromium_webkit_tests itself; that will come some other
time.

https://bugs.webkit.org/show_bug.cgi?id=44648

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
12:44 PM Changeset in webkit [66124] by tony@chromium.org
  • 1 edit
    388 deletes in trunk/LayoutTests

2010-08-26 Tony Chang <tony@chromium.org>

Not reviewed. Removing chromium-win test results that deduplicate-tests says are not necessary.

  • platform/chromium-win-vista/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Removed.
  • platform/chromium-win-vista/fast/css/css2-system-fonts-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/css/css2-system-fonts-expected.png: Removed.
  • platform/chromium-win-vista/fast/forms/search-styled-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/forms/search-styled-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/basic/006-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/text/basic/006-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/cg-vs-atsui-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/text/cg-vs-atsui-expected.png: Removed.
  • platform/chromium-win-vista/fast/text/complex-text-opacity-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/text/complex-text-opacity-expected.png: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png: Removed.
  • platform/chromium-win-xp/editing/pasteboard/block-wrappers-necessary-expected.checksum: Removed.
  • platform/chromium-win-xp/editing/pasteboard/block-wrappers-necessary-expected.png: Removed.
  • platform/chromium-win-xp/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Removed.
  • platform/chromium-win-xp/fast/css/nested-rounded-corners-expected.png: Removed.
  • platform/chromium-win-xp/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt: Removed.
  • platform/chromium-win-xp/fast/lists/anonymous-items-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/fixed-tranformed-expected.png: Removed.
  • platform/chromium-win-xp/fast/replaced/border-radius-clip-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/replaced/border-radius-clip-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/ruby-empty-rt-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/ruby-length-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/ruby-run-break-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/ruby-runs-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/ruby-runs-spans-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/ruby-simple-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/ruby-simple-rp-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/ruby-trailing-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/rubyDOM-insert-rt-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/rubyDOM-insert-text1-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/rubyDOM-insert-text2-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/rubyDOM-insert-text3-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/rubyDOM-remove-rt1-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/rubyDOM-remove-rt2-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/rubyDOM-remove-text1-expected.png: Removed.
  • platform/chromium-win-xp/fast/ruby/rubyDOM-remove-text2-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/atsui-kerning-and-ligatures-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/text/atsui-kerning-and-ligatures-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/stroking-decorations-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/text/stroking-decorations-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/stroking-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/text/stroking-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textEffect2-expected.png: Removed.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.txt: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-child-clipped-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-evenodd-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-nonzero-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-text-and-shape-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-text-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
  • platform/chromium-win-xp/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/foreign-object-skew-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/custom/foreign-object-skew-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/js-late-gradient-and-object-creation-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/custom/js-late-gradient-and-object-creation-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/mask-invalidation-expected.png: Removed.
  • platform/chromium-win/editing/deleting/transpose-empty-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/boldSelection-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-plaintext-user-select-none-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/bgCompositeCopy-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize03-expected.checksum: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
  • platform/chromium-win/fast/block/float/009-expected.checksum: Removed.
  • platform/chromium-win/fast/block/float/034-expected.checksum: Removed.
  • platform/chromium-win/fast/block/float/4145535Crash-expected.checksum: Removed.
  • platform/chromium-win/fast/block/float/br-with-clear-expected.checksum: Removed.
  • platform/chromium-win/fast/block/float/float-on-zero-height-line-expected.checksum: Removed.
  • platform/chromium-win/fast/block/float/narrow-after-wide-expected.checksum: Removed.
  • platform/chromium-win/fast/block/float/negative-margin-clear-expected.checksum: Removed.
  • platform/chromium-win/fast/block/float/nowrap-clear-min-width-expected.checksum: Removed.
  • platform/chromium-win/fast/block/float/overhanging-after-height-decrease-offsets-expected.checksum: Removed.
  • platform/chromium-win/fast/block/float/relative-painted-twice-expected.txt: Removed.
  • platform/chromium-win/fast/block/positioning/003-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/004-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/005-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/006-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/007-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/008-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/009-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/010-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/011-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/012-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/013-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/014-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/015-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/016-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/017-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/018-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/019-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/020-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/021-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/022-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/023-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/024-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/025-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/026-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/027-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/028-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/029-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/030-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/031-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/032-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/033-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/034-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/035-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/036-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/037-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/038-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/039-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/040-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/041-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/042-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/043-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/044-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/045-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/046-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/048-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/049-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/050-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/062-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/move-with-auto-width-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/relative-overconstrained-expected.checksum: Removed.
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
  • platform/chromium-win/fast/borders/border-image-omit-right-slice-expected.txt: Removed.
  • platform/chromium-win/fast/borders/outline-offset-min-assert-expected.checksum: Removed.
  • platform/chromium-win/fast/canvas/access-zero-sized-canvas-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-as-image-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-as-image-incremental-repaint-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-bg-zoom-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-text-alignment-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-text-baseline-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-identity-expected.checksum: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-infinity-expected.checksum: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-multiply-expected.checksum: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-nan-expected.checksum: Removed.
  • platform/chromium-win/fast/canvas/canvas-transform-non-invertible-expected.checksum: Removed.
  • platform/chromium-win/fast/clip/017-expected.checksum: Removed.
  • platform/chromium-win/fast/css/006-expected.checksum: Removed.
  • platform/chromium-win/fast/css/affected-by-hover-after-style-change-expected.checksum: Removed.
  • platform/chromium-win/fast/css/content-dynamic-expected.checksum: Removed.
  • platform/chromium-win/fast/css/last-child-style-sharing-expected.checksum: Removed.
  • platform/chromium-win/fast/css/transition-color-unspecified-expected.checksum: Removed.
  • platform/chromium-win/fast/css/variables/invalid-identifier-expected.txt: Removed.
  • platform/chromium-win/fast/dom/HTMLStyleElement/insert-parser-generated-expected.checksum: Removed.
  • platform/chromium-win/fast/dom/Window/console-trace-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-open-pending-url-expected.txt: Removed.
  • platform/chromium-win/fast/dom/css-cached-import-rule-expected.checksum: Removed.
  • platform/chromium-win/fast/dom/css-insert-import-rule-expected.checksum: Removed.
  • platform/chromium-win/fast/dom/delete-contents-expected.checksum: Removed.
  • platform/chromium-win/fast/dom/delete-contents-expected.txt: Removed.
  • platform/chromium-win/fast/dynamic/001-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/005-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/float-no-longer-overhanging-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/float-withdrawal-2-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/floating-to-positioned-2-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/floating-to-positioned-2-expected.txt: Removed.
  • platform/chromium-win/fast/dynamic/floating-to-positioned-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/floating-to-positioned-expected.txt: Removed.
  • platform/chromium-win/fast/dynamic/genContentDestroyChildren-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/insertAdjacentElement-expected.txt: Removed.
  • platform/chromium-win/fast/dynamic/positioned-movement-with-positioned-children-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/staticY-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/subtree-boundary-percent-height-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/subtree-no-common-root-static-y-expected.checksum: Removed.
  • platform/chromium-win/fast/dynamic/subtree-table-cell-height-expected.checksum: Removed.
  • platform/chromium-win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Removed.
  • platform/chromium-win/fast/events/onloadFrameCrash-expected.checksum: Removed.
  • platform/chromium-win/fast/events/onunload-clears-onbeforeunload-expected.txt: Removed.
  • platform/chromium-win/fast/events/onunload-not-on-body-expected.txt: Removed.
  • platform/chromium-win/fast/forms/005-expected.txt: Removed.
  • platform/chromium-win/fast/forms/drag-out-of-textarea-expected.txt: Removed.
  • platform/chromium-win/fast/forms/form-and-frame-interaction-retains-values-expected.txt: Removed.
  • platform/chromium-win/fast/forms/selected-index-assert-expected.txt: Removed.
  • platform/chromium-win/fast/forms/slider-onchange-event-expected.txt: Removed.
  • platform/chromium-win/fast/forms/slider-transformed-expected.txt: Removed.
  • platform/chromium-win/fast/forms/textarea-no-scroll-on-blur-expected.txt: Removed.
  • platform/chromium-win/fast/forms/textarea-scrolled-endline-caret-expected.txt: Removed.
  • platform/chromium-win/fast/frames/002-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/calculate-fixed-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/calculate-order-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/calculate-percentage-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/calculate-relative-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/calculate-round-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/empty-cols-attribute-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/empty-frame-src-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/frame-length-fractional-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/frame-set-whitespace-attributes-expected.checksum: Removed.
  • platform/chromium-win/fast/frames/no-frame-borders-expected.checksum: Removed.
  • platform/chromium-win/fast/gradients/background-clipped-expected.txt: Removed.
  • platform/chromium-win/fast/gradients/border-image-gradient-expected.txt: Removed.
  • platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
  • platform/chromium-win/fast/images/image-in-map-expected.checksum: Removed.
  • platform/chromium-win/fast/images/pdf-as-tiled-background-expected.checksum: Removed.
  • platform/chromium-win/fast/images/svg-as-background-expected.checksum: Removed.
  • platform/chromium-win/fast/images/svg-as-image-expected.checksum: Removed.
  • platform/chromium-win/fast/images/svg-as-relative-image-expected.checksum: Removed.
  • platform/chromium-win/fast/images/svg-width-100p-as-background-expected.checksum: Removed.
  • platform/chromium-win/fast/inline-block/004-expected.checksum: Removed.
  • platform/chromium-win/fast/inline-block/005-expected.checksum: Removed.
  • platform/chromium-win/fast/invalid/015-expected.checksum: Removed.
  • platform/chromium-win/fast/invalid/table-residual-style-crash-expected.checksum: Removed.
  • platform/chromium-win/fast/js/exception-linenums-in-html-3-expected.checksum: Removed.
  • platform/chromium-win/fast/js/missing-style-end-tag-js-expected.checksum: Removed.
  • platform/chromium-win/fast/js/missing-title-end-tag-js-expected.checksum: Removed.
  • platform/chromium-win/fast/layers/positioned-inside-root-with-margins-expected.checksum: Removed.
  • platform/chromium-win/fast/layers/self-painting-outline-expected.txt: Removed.
  • platform/chromium-win/fast/layers/zindex-ridonkulous-expected.checksum: Removed.
  • platform/chromium-win/fast/overflow/position-relative-expected.checksum: Removed.
  • platform/chromium-win/fast/overflow/unreachable-content-test-expected.checksum: Removed.
  • platform/chromium-win/fast/parser/comment-in-script-expected.txt: Removed.
  • platform/chromium-win/fast/parser/external-entities-expected.txt: Removed.
  • platform/chromium-win/fast/parser/style-script-head-test-expected.checksum: Removed.
  • platform/chromium-win/fast/reflections/reflection-computed-style-expected.txt: Removed.
  • platform/chromium-win/fast/reflections/table-cell-expected.checksum: Removed.
  • platform/chromium-win/fast/reflections/table-cell-expected.txt: Removed.
  • platform/chromium-win/fast/reflections/teardown-crash-expected.txt: Removed.
  • platform/chromium-win/fast/repaint/button-spurious-layout-hint-expected.checksum: Removed.
  • platform/chromium-win/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum: Removed.
  • platform/chromium-win/fast/replaced/008-expected.checksum: Removed.
  • platform/chromium-win/fast/table/024-expected.checksum: Removed.
  • platform/chromium-win/fast/table/031-expected.checksum: Removed.
  • platform/chromium-win/fast/table/caption-relayout-expected.checksum: Removed.
  • platform/chromium-win/fast/table/div-as-col-span-expected.checksum: Removed.
  • platform/chromium-win/fast/table/giantCellspacing-expected.checksum: Removed.
  • platform/chromium-win/fast/table/growCellForImageQuirk-expected.checksum: Removed.
  • platform/chromium-win/fast/table/max-width-integer-overflow-expected.checksum: Removed.
  • platform/chromium-win/fast/table/percent-widths-stretch-expected.checksum: Removed.
  • platform/chromium-win/fast/table/vertical-align-baseline-readjust-expected.checksum: Removed.
  • platform/chromium-win/fast/text/align-center-rtl-spill-expected.checksum: Removed.
  • platform/chromium-win/fast/text/apply-start-width-after-skipped-text-expected.checksum: Removed.
  • platform/chromium-win/fast/text/fixed-pitch-control-characters-expected.checksum: Removed.
  • platform/chromium-win/fast/text/selection-painted-separately-expected.checksum: Removed.
  • platform/chromium-win/fast/text/soft-hyphen-3-expected.checksum: Removed.
  • platform/chromium-win/fast/text/stripNullFromText-expected.checksum: Removed.
  • platform/chromium-win/fast/text/whitespace/017-expected.txt: Removed.
  • platform/chromium-win/fast/tokenizer/missing-style-end-tag-1-expected.checksum: Removed.
  • platform/chromium-win/fast/tokenizer/missing-style-end-tag-2-expected.checksum: Removed.
  • platform/chromium-win/fast/tokenizer/script-after-frameset-expected.checksum: Removed.
  • platform/chromium-win/fast/xsl/mozilla-tests-expected.txt: Removed.
  • platform/chromium-win/fast/xsl/xslt-mismatched-tags-in-xslt-expected.checksum: Removed.
  • platform/chromium-win/media/video-play-pause-events-expected.txt: Removed.
  • platform/chromium-win/plugins/embed-attributes-setting-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-01-t-expected.checksum: Removed.
  • platform/chromium-win/svg/carto.net/tabgroup-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/SVGNumber-interface-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/SVGPoint-interface-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/SVGRect-interface-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/attribute-namespace-check-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/class-selector-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/clip-path-child-changes-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/clip-path-href-changes-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/clip-path-units-changes-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/clip-path-with-transform-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/conditional-processing-outside-switch-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/create-metadata-element-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/createelement-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/css-pixels-dpi-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/display-none-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/dynamic-viewBox-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/evt-onload-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/fill-update-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/filter-source-alpha-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/gradient-add-stops-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/gradient-attr-update-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/gradient-stop-style-change-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/hover-default-fill-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/image-clipped-hit-expected.txt: Removed.
  • platform/chromium-win/svg/custom/image-with-aspect-ratio-stretch-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/inner-percent-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/inner-svg-hit-test-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/invalid-transforms-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/mask-excessive-malloc-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/mask-inside-defs-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/pattern-in-defs-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/percentage-rect2-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/poly-identify-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/polyline-hittest-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/polyline-invalid-points-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/polyline-setattribute-points-null-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/prevent-default-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/repaint-on-image-bounds-change-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/resource-client-removal-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/rgbcolor-syntax-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/rootelement-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/scroll-hit-test-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/sheet-title-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/svg-absolute-children-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/text-gradient-no-content-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/transform-ignore-after-invalid-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/transform-invalid-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/transform-removeAttributeNS-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/transform-scale-parse-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/transform-with-ending-space-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/transformedMaskFails-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/use-empty-reference-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/use-infinite-recursion-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/use-recalcStyle-crash-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/use-symbol-overflow-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/viewport-clip-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/viewport-no-width-height-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/viewport-update-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/viewport-update2-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/visibility-override-clip-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/visibility-override-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/visibility-override-mask-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/xhtml-no-svg-renderer-expected.checksum: Removed.
  • platform/chromium-win/svg/custom/xml-stylesheet-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/dynamic/003-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/dynamic/004-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/dynamic/006-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/error/001-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/error/006-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/error/007-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/error/008-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/error/009-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/error/014-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/error/014-test-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/error/015-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/error/016-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/painting/001-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/processing-model/005-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/rendering-model/003a-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/use/001-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/use/002-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/use/002-test-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/viewbox/001-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/viewbox/002-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/viewbox/003-expected.checksum: Removed.
  • platform/chromium-win/svg/hixie/viewbox/004-expected.checksum: Removed.
  • platform/chromium-win/svg/webarchive/svg-script-subresouces-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/bugs/adforce_imgis_com-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug103533-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug1818-6-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug196870-expected.txt: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug222336-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug222467-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug269566-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug277062-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug28933-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug2954-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug8032-2-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug9024-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla/core/col_widths_fix_autoFixPer-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug128876-expected.checksum: Removed.
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.checksum: Removed.
  • platform/chromium-win/transforms/3d/hit-testing/backface-hit-test-expected.txt: Removed.
  • platform/chromium-win/transitions/transition-end-event-rendering-expected.checksum: Removed.
  • platform/chromium-win/webarchive/archive-with-unencoded-url-expected.checksum: Removed.
  • platform/chromium-win/webarchive/test-body-background-expected.checksum: Removed.
  • platform/chromium-win/webarchive/test-img-src-expected.checksum: Removed.
  • platform/chromium-win/webarchive/test-input-src-expected.checksum: Removed.
  • platform/chromium-win/webarchive/test-link-rel-icon-expected.checksum: Removed.
  • platform/chromium-win/webarchive/test-object-data-expected.checksum: Removed.
  • platform/chromium-win/webarchive/test-script-src-expected.checksum: Removed.
  • platform/chromium-win/webarchive/test-table-background-expected.checksum: Removed.
  • platform/chromium-win/webarchive/test-td-background-expected.checksum: Removed.
  • platform/chromium-win/webarchive/test-xml-stylesheet-expected.checksum: Removed.
12:43 PM Changeset in webkit [66123] by hyatt@apple.com
  • 1 edit in trunk/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp

Fix QT bustage.

12:33 PM Changeset in webkit [66122] by hyatt@apple.com
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39647, font face loads do a synchronous recalcStyle(Force)
on the whole document. Change these calls to do async recalcStyles instead.

Reviewed by Simon Fraser.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::fontLoaded):
(WebCore::CSSFontSelector::fontCacheInvalidated):

  • dom/Document.cpp:

(WebCore::Document::scheduleForcedStyleRecalc):
(WebCore::Document::styleSelectorChanged):

  • dom/Document.h:
12:23 PM Changeset in webkit [66121] by tony@chromium.org
  • 1 edit
    38 deletes in trunk/LayoutTests

2010-08-26 Tony Chang <tony@chromium.org>

Not reviewed. Removing chromium-linux test results that deduplicate-tests says are not necessary.

  • platform/chromium-linux/fast/block/basic/min-pref-width-nowrap-floats-expected.txt: Removed.
  • platform/chromium-linux/fast/block/positioning/complex-percentage-height-expected.txt: Removed.
  • platform/chromium-linux/fast/frames/invalid-expected.txt: Removed.
  • platform/chromium-linux/fast/frames/valid-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed.
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.png: Removed.
  • platform/chromium-linux/fast/ruby/ruby-inline-table-expected.txt: Removed.
  • platform/chromium-linux/fast/runin/generated2-expected.txt: Removed.
  • platform/chromium-linux/fast/runin/generated3-expected.txt: Removed.
  • platform/chromium-linux/fast/runin/generated4-expected.txt: Removed.
  • platform/chromium-linux/fast/text/stripNullFromText-expected.checksum: Removed.
  • platform/chromium-linux/fast/text/stripNullFromText-expected.png: Removed.
  • platform/chromium-linux/fast/url/host-expected.txt: Removed.
  • platform/chromium-linux/fast/url/mailto-expected.txt: Removed.
  • platform/chromium-linux/fast/url/path-expected.txt: Removed.
  • platform/chromium-linux/fast/url/scheme-expected.txt: Removed.
  • platform/chromium-linux/fast/url/standard-url-expected.txt: Removed.
  • platform/chromium-linux/media/video-zoom-expected.txt: Removed.
  • platform/chromium-linux/svg/css/svg-ellipse-render-crash-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.png: Removed.
  • platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.png: Removed.
  • platform/chromium-linux/svg/custom/mask-changes-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/visibility-override-filter-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/big-sized-filter-2-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Removed.
  • platform/chromium-linux/svg/filters/big-sized-filter-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/big-sized-filter-expected.png: Removed.
  • platform/chromium-linux/svg/filters/feColorMatrix-values-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Removed.
  • platform/chromium-linux/svg/filters/feMerge-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/feMerge-expected.png: Removed.
  • platform/chromium-linux/svg/filters/feOffset-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/feTile-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/feTile-expected.png: Removed.
  • platform/chromium-linux/svg/filters/parent-children-with-same-filter-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/parent-children-with-same-filter-expected.png: Removed.
  • platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.checksum: Removed.
  • platform/chromium-linux/svg/filters/subRegion-in-userSpace-expected.png: Removed.
12:14 PM Changeset in webkit [66120] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261

Ignore new soup API that we decided to merge into the soup backend
while it is being cooked. It follows the libsoup style, and will
be removed from WebKit as soon as it is merged into libsoup.

  • Scripts/webkitpy/style/checker.py:
12:00 PM Changeset in webkit [66119] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-08-25 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Improve overflow handling in StringImpl::Replace
https://bugs.webkit.org/show_bug.cgi?id=42502
<rdar://problem/8203794>

Harden StringImpl::replace against overflow -- I can't see how this
could be abused, but it's better to be safe than sorry.

  • wtf/text/StringImpl.cpp: (WTF::StringImpl::replace):
11:54 AM Changeset in webkit [66118] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-08-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix double free (we were passing const memory to a GOwnPtr) by
getting rid of unneeded temp variable.

  • platform/gtk/FileSystemGtk.cpp: (WebCore::directoryName):
11:27 AM Changeset in webkit [66117] by mnaganov@chromium.org
  • 27 edits
    2 copies
    1 move
    1 add
    2 deletes in trunk

2010-08-26 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Store heap snapshots in InspectorProfilerAgent.

Change the way heap snapshots are transported to Inspector
to be aligned with CPU profiles. As a result, the Heap snapshots
view of Profiles panel was upstreamed into WebCore.

https://bugs.webkit.org/show_bug.cgi?id=44531

  • English.lproj/localizedStrings.js:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptHeapSnapshot.h: Added. (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot): (WebCore::ScriptHeapSnapshot::title): (WebCore::ScriptHeapSnapshot::uid): (WebCore::ScriptHeapSnapshot::buildInspectorObjectForHead): (WebCore::ScriptHeapSnapshot::ScriptHeapSnapshot):
  • bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptHeapSnapshot.cpp: Added. (WebCore::ScriptHeapSnapshot::title): (WebCore::ScriptHeapSnapshot::uid): (WebCore::buildInspectorObjectFor): (WebCore::ScriptHeapSnapshot::buildInspectorObjectForHead):
  • bindings/v8/ScriptHeapSnapshot.h: Added. (WebCore::ScriptHeapSnapshot::create): (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot): (WebCore::ScriptHeapSnapshot::ScriptHeapSnapshot):
  • bindings/v8/ScriptProfile.cpp: (WebCore::buildInspectorObjectFor):
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorBackend.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::createSnapshotHeader): (WebCore::InspectorProfilerAgent::getProfileHeaders): (WebCore::InspectorProfilerAgent::getProfile): (WebCore::InspectorProfilerAgent::removeProfile): (WebCore::InspectorProfilerAgent::resetState): (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
  • inspector/InspectorProfilerAgent.h:
  • inspector/front-end/HeapSnapshotView.js: Added. (WebInspector.HeapSnapshotView.profileCallback): (WebInspector.HeapSnapshotView.resetCompleted): (WebInspector.HeapSnapshotView): (WebInspector.HeapSnapshotView.prototype.get statusBarItems): (WebInspector.HeapSnapshotView.prototype.get profile): (WebInspector.HeapSnapshotView.prototype.set profile): (WebInspector.HeapSnapshotView.prototype.show): (WebInspector.HeapSnapshotView.prototype.hide): (WebInspector.HeapSnapshotView.prototype.resize): (WebInspector.HeapSnapshotView.prototype.refresh): (WebInspector.HeapSnapshotView.prototype.refreshShowAsPercents): (WebInspector.HeapSnapshotView.prototype._deleteSearchMatchedFlags): (WebInspector.HeapSnapshotView.prototype.searchCanceled): (WebInspector.HeapSnapshotView.prototype.performSearch): (WebInspector.HeapSnapshotView.prototype.jumpToFirstSearchResult.WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult.jumpToLastSearchResult.WebInspector.CPUProfileView.prototype.jumpToLastSearchResult.jumpToNextSearchResult.WebInspector.CPUProfileView.prototype.jumpToNextSearchResult.jumpToPreviousSearchResult.WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult.showingFirstSearchResult.WebInspector.CPUProfileView.prototype.showingFirstSearchResult.showingLastSearchResult.WebInspector.CPUProfileView.prototype.showingLastSearchResult._jumpToSearchResult.WebInspector.CPUProfileView.prototype._jumpToSearchResult.refreshVisibleData): (WebInspector.HeapSnapshotView.prototype._changeBase.resetCompleted): (WebInspector.HeapSnapshotView.prototype._changeBase): (WebInspector.HeapSnapshotView.prototype._createSnapshotDataGridList): (WebInspector.HeapSnapshotView.prototype._getProfiles): (WebInspector.HeapSnapshotView.prototype._loadProfile.loadedCallback): (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype._mouseDownInDataGrid): (WebInspector.HeapSnapshotView.prototype.get _isShowingAsPercent): (WebInspector.HeapSnapshotView.prototype._percentClicked): (WebInspector.HeapSnapshotView.prototype._prepareProfile.mergeRetainers): (WebInspector.HeapSnapshotView.prototype._prepareProfile): (WebInspector.HeapSnapshotView.prototype._resetDataGridList.profileLoaded): (WebInspector.HeapSnapshotView.prototype._resetDataGridList): (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotView.prototype._updateBaseOptions): (WebInspector.HeapSnapshotView.prototype._updatePercentButton): (WebInspector.HeapSnapshotView.prototype._updateSummaryGraph): (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS): (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS_OR_EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER_OR_EQUAL): (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER): (WebInspector.HeapSnapshotView.SearchHelper.parseOperationAndNumber): (WebInspector.HeapSummaryCalculator): (WebInspector.HeapSummaryCalculator.prototype.computeSummaryValues): (WebInspector.HeapSummaryCalculator.prototype.formatValue): (WebInspector.HeapSummaryCalculator.prototype.get showAsPercent): (WebInspector.HeapSummaryCalculator.prototype.set showAsPercent): (WebInspector.HeapSummaryCountCalculator): (WebInspector.HeapSummaryCountCalculator.prototype._highFromLow): (WebInspector.HeapSummaryCountCalculator.prototype._valueToString): (WebInspector.HeapSummarySizeCalculator): (WebInspector.HeapSummarySizeCalculator.prototype._highFromLow): (WebInspector.HeapSnapshotDataGridNodeWithRetainers): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _hasRetainers): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _parent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype._populate): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.produceDiff): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.sort): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.signForDelta): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.showDeltaAsPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalCount): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalSize): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizePercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countDeltaPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizeDeltaPercent): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get data): (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.createCell): (WebInspector.HeapSnapshotDataGridNode): (WebInspector.HeapSnapshotDataGridList): (WebInspector.HeapSnapshotDataGridList.prototype.appendChild): (WebInspector.HeapSnapshotDataGridList.prototype.insertChild): (WebInspector.HeapSnapshotDataGridList.prototype.removeChildren): (WebInspector.HeapSnapshotDataGridList.prototype.populateChildren): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator): (WebInspector.HeapSnapshotDataGridRetainerNode): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizePercent): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizeDeltaPercent): (WebInspector.HeapSnapshotDataGridRetainerNode.prototype._calculateRetainers): (WebInspector.HeapSnapshotProfileType): (WebInspector.HeapSnapshotProfileType.prototype.get buttonTooltip): (WebInspector.HeapSnapshotProfileType.prototype.get buttonStyle): (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked): (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage): (WebInspector.HeapSnapshotProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.HeapSnapshotProfileType.prototype.createView):
  • inspector/front-end/ProfileView.js: (WebInspector.CPUProfileView): (WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.removeProfileHeader): (WebInspector.ProfilesPanel.prototype.getProfiles): (WebInspector.ProfilesPanel.prototype.updateProfile): (WebInspector.ProfileSidebarTreeElement): (WebInspector.ProfileSidebarTreeElement.prototype.get mainTitle):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.heap-snapshot-sidebar-tree-item .icon): (.heap-snapshot-sidebar-tree-item.small .icon): (.heap-snapshot-view): (.heap-snapshot-view.visible): (.heap-snapshot-view .data-grid): (.heap-snapshot-view .data-grid th.count-column): (.heap-snapshot-view .data-grid td.count-column): (.heap-snapshot-view .data-grid th.size-column): (.heap-snapshot-view .data-grid td.size-column): (.heap-snapshot-view .data-grid th.countDelta-column): (.heap-snapshot-view .data-grid td.countDelta-column): (.heap-snapshot-view .data-grid th.sizeDelta-column): (.heap-snapshot-view .data-grid td.sizeDelta-column): (#heap-snapshot-summary-container): (.heap-snapshot-summary): (.heap-snapshot-summary canvas.summary-graph): (.heap-snapshot-summary-label):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
  • DEPS:
  • WebKit.gypi:
  • src/js/DevTools.js: ():
  • src/js/HeapProfilerPanel.js: Removed.
  • src/js/ProfilerAgent.js: Removed.
  • src/js/ProfilerProcessor.js: Removed.
  • src/js/devTools.css:
11:19 AM Changeset in webkit [66116] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests

Reset results for an incorrect test after my previous checkin.

11:17 AM Changeset in webkit [66115] by hyatt@apple.com
  • 17 edits in trunk/WebCore

<rdar://problem/8302217> recalcStyles called immediately on each change when updating document-level stylesheets
https://bugs.webkit.org/show_bug.cgi?id=36303

Reviewed by Simon Fraser.

Parameterize updateStyleSelector to optionally defer the forced style recalc following the rebuilding of the
sheets used by the CSSStyleSelector. Rename the method to styleSelectorChanged(). Add the capability to do
a forced style recalc to the style recalc timer.

  • css/CSSMutableStyleDeclaration.cpp:

(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::styleSheetChanged):

  • css/CSSVariablesDeclaration.cpp:

(WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::clearPageUserSheet):
(WebCore::Document::clearPageGroupUserSheets):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::removePendingSheet):
(WebCore::Document::styleSelectorChanged):
(WebCore::Document::setInPageCache):

  • dom/Document.h:

(WebCore::):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::removedFromDocument):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::removedFromDocument):

  • dom/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::end):

  • dom/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::doEnd):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::determineParseMode):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::removedFromDocument):

  • page/Frame.cpp:

(WebCore::Frame::setPrinting):
(WebCore::Frame::reapplyStyles):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • page/Page.cpp:

(WebCore::Page::setViewMode):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::setDesiredColumnCountAndWidth):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::removeFromMappedElementSheet):

11:13 AM WebKitGTKFonts edited by mrobinson@webkit.org
(diff)
11:09 AM Changeset in webkit [66114] by vangelis@chromium.org
  • 5 edits in trunk/WebCore

2010-08-24 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Implementing clipping for composited layers. Two
types of clipping are added: Scissoring for layers that don't
contain any rotations and stencil-buffer based clipping for
all other layers.
https://bugs.webkit.org/show_bug.cgi?id=44573

Tests: Compositor layout tests that test clipping such as
compositing/geometry/{clip.html, clipping-foreground.html} now
work properly.

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::SharedValues::SharedValues): (WebCore::LayerChromium::getDrawRect): (WebCore::LayerChromium::drawAsMask):
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::drawLayerIntoStencilBuffer): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::scissorToRect): (WebCore::LayerRendererChromium::initializeSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
11:06 AM WebKitGTKFonts edited by mrobinson@webkit.org
(diff)
11:01 AM WebKitGTKFonts edited by mrobinson@webkit.org
(diff)
10:52 AM Changeset in webkit [66113] by kbr@google.com
  • 3 edits in trunk/WebCore

2010-08-25 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Expose Vector3 and associated operations
https://bugs.webkit.org/show_bug.cgi?id=44666

No new tests; ran several 3D CSS demos and did full layout test
run. New code paths have also been tested by new calling code
which will be checked in soon.

  • platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::decompose):
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::Vector3::Vector3): (WebCore::Vector3::x): (WebCore::Vector3::y): (WebCore::Vector3::z): (WebCore::Vector3::setX): (WebCore::Vector3::setY): (WebCore::Vector3::setZ): (WebCore::Vector3::set): (WebCore::Vector3::operator =): (WebCore::Vector3::operator +): (WebCore::Vector3::operator -): (WebCore::Vector3::operator[]): (WebCore::Vector3::length): (WebCore::Vector3::lengthSquared): (WebCore::Vector3::scaleTo): (WebCore::Vector3::normalize): (WebCore::Vector3::dot): (WebCore::Vector3::combine): (WebCore::Vector3::cross):
10:45 AM WebKitGTKFonts created by mrobinson@webkit.org
10:27 AM Changeset in webkit [66112] by mnaganov@chromium.org
  • 2 edits in trunk/WebCore

2010-08-26 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix CPU profile header entries doubling on Inspector re-opening.

https://bugs.webkit.org/show_bug.cgi?id=44685

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.show):
9:52 AM Changeset in webkit [66111] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/efl

2010-08-26 Miroslaw Szymanski <miroslaw.s@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Added new callback when view's size is changed to fix issue with changing layout size
https://bugs.webkit.org/show_bug.cgi?id=44337

  • ewk/ewk_view.cpp: (_ewk_view_smart_calculate):
9:45 AM Changeset in webkit [66110] by eric.carlson@apple.com
  • 8 edits
    2 adds in trunk

2010-08-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler and Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=44013
HTMLMediaElement should delay document load event

Test: media/video-delay-load-event.html

  • dom/Document.cpp: (WebCore::Document::Document): Initialize incrementLoadEventDelayCount. (WebCore::Document::decrementLoadEventDelayCount): New, decrement incrementLoadEventDelayCount and call loader->checkCompleted() when it reaches zero.
  • dom/Document.h: (WebCore::Document::incrementLoadEventDelayCount): New. (WebCore::Document::isDelayingLoadEvent): New.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::~HTMLMediaElement): Stop delaying the load event if necessary. (WebCore::HTMLMediaElement::willMoveToNewOwnerDocument): Ditto. (WebCore::HTMLMediaElement::didMoveToNewOwnerDocument): Delay the load event if we don't the meta data for the movie yet. (WebCore::HTMLMediaElement::prepareForLoad): Delay the load event. (WebCore::HTMLMediaElement::selectMediaResource): Don't delay the load event when there are no more sources to consider. Don't change m_delayingTheLoadEvent directly, call setShouldDelayLoadEvent() instead. (WebCore::HTMLMediaElement::waitForSourceChange): Stop delaying the load event. (WebCore::HTMLMediaElement::noneSupported): Ditto. (WebCore::HTMLMediaElement::mediaEngineError): Ditto. (WebCore::HTMLMediaElement::setReadyState): Ditto. (WebCore::HTMLMediaElement::userCancelledLoad): Ditto. (WebCore::HTMLMediaElement::setShouldDelayLoadEvent): New, increment/decrement the document's load event delay count.
  • html/HTMLMediaElement.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkCompleted): See if the document wants to delay completion for elements that don't go through a FrameLoader. (WebCore::FrameLoader::checkCallImplicitClose): Ditto
  • page/Frame.cpp:

2010-08-26 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler and Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=44013
HTMLMediaElement should delay document load event

  • media/video-delay-load-event-expected.txt: Added.
  • media/video-delay-load-event.html: Added.
  • media/video-layer-crash.html: Trigger test with script inline in the <body> instead of from an onload handler as that runs too late. Reformat script to make it readable.
9:18 AM Changeset in webkit [66109] by mitz@apple.com
  • 5 edits in trunk

WebCore: Fix the same issue as https://bugs.webkit.org/show_bug.cgi?id=41585
but this time for the -webkit-font-smoothing property.

Reviewed by Simon Fraser.

Updated fast/css/text-rendering-priority.html to cover all properties that
affect the font.

  • css/CSSPropertyNames.in: Moved text-rendering to the “high priority” section at the top.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForElement): Assert that the font is not dirtied by
applying any of the “low priority” properties, but still handle the case that the assertion
is false.
(WebCore::CSSStyleSelector::applyDeclarations): Updated compile-time assertion.

LayoutTests: Extended this test to cover all properties that dirty the font and therefore
need to have high priority.

Reviewed by Simon Fraser.

  • fast/css/text-rendering-priority.html:
9:16 AM Changeset in webkit [66108] by mrobinson@webkit.org
  • 6 edits in trunk

2010-08-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] The GNUmakefile.am files contain a myriad of confusing preprocessor and compiler flag definitions
https://bugs.webkit.org/show_bug.cgi?id=44624

Clean up GNUmakefile.am.

  • GNUmakefile.am: Make the comments describing the global_* variables more readable and correct. Move WebKit-specific include lines and definitions out of webkitgtk_cppflags, corekit_cppflags and webcoregtk_cppflags and straight to the appropriate CPPFLAGS definition. Use global_cppflags for compiler flags that apply to both C++ and C code. Move some JavaScriptCore specific includes to the appropriate sub-directory GNUmakefile.am. Make sure the tests build with the global CPP flags as well.

2010-08-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] The GNUmakefile.am files contain a myriad of confusing preprocessor and compiler flag definitions
https://bugs.webkit.org/show_bug.cgi?id=44624

Clean up GNUmakefile.am.

  • GNUmakefile.am: Alphabetize the include order in javascriptcore_cppflags. Move a couple include lines from the top-level GNUmakefile.am.

2010-08-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] The GNUmakefile.am files contain a myriad of confusing preprocessor and compiler flag definitions
https://bugs.webkit.org/show_bug.cgi?id=44624

Clean up GNUmakefile.am.

  • GNUmakefile.am: Remove some WebKit includes from webcore_cppflags. These includes are added to the build line by the top-level GNUmakefile.am, since WebCore isn't build as an intermediate library.
8:59 AM Changeset in webkit [66107] by kevino@webkit.org
  • 10 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

A few tweaks to the wxWebView editing APIs after addition of DOM bindings.
https://bugs.webkit.org/show_bug.cgi?id=44656

8:58 AM Changeset in webkit [66106] by yurys@chromium.org
  • 24 edits in trunk

2010-08-26 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Revert r66103 since Qt tests are failing.

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::close):
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js:
  • inspector/front-end/inspector.js: (WebInspector.inspectedPageDestroyed):
8:55 AM Changeset in webkit [66105] by wsiegrist@apple.com
  • 2 edits in trunk/BugsSite

2010-08-26 William Siegrist <wsiegrist@apple.com>

Back out part of the changes in r66104 that were accidentally included.

8:51 AM Changeset in webkit [66104] by wsiegrist@apple.com
  • 3 edits in trunk/BugsSite

2010-08-26 William Siegrist <wsiegrist@apple.com>

Fix PATH for PrettyPatch so it can find git.

8:38 AM Changeset in webkit [66103] by yurys@chromium.org
  • 24 edits in trunk

2010-08-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::close):
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::disconnectFromBackend): don't try to notify InspectorController that frontend closes if InspectorController triggered the action.
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.disconnectFromBackend):
  • inspector/front-end/inspector.js: (WebInspector.disconnectFromBackend):
7:22 AM Changeset in webkit [66102] by tkent@chromium.org
  • 4 edits in trunk

2010-08-26 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[DRT/Chromium] Enable DEVICE_ORIENTATION
https://bugs.webkit.org/show_bug.cgi?id=44587

  • platform/chromium/drt_expectations.txt:

2010-08-26 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[DRT/Chromium] Enable DEVICE_ORIENTATION
https://bugs.webkit.org/show_bug.cgi?id=44587

  • features.gypi:
7:14 AM Changeset in webkit [66101] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-08-26 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: It would be better to have an explicit type check for the all
arguments of InspectorBackend functions on front-end side.
https://bugs.webkit.org/show_bug.cgi?id=44684

  • inspector/CodeGeneratorInspector.pm:
6:13 AM Changeset in webkit [66100] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-08-26 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update gtk specific result after r66093.

  • platform/gtk/svg/css/text-shadow-multiple-expected.txt:
6:12 AM Changeset in webkit [66099] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-08-26 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Martin Robinson.

[GTK] WebKitGTK+ needs proper introspection annotation for most types and methods
https://bugs.webkit.org/show_bug.cgi?id=44565

Add documentation and introspection specific information to a few
getter and setter methods.

  • webkit/webkitwebview.cpp:
6:11 AM Changeset in webkit [66098] by loislo@chromium.org
  • 12 edits in trunk/WebCore

2010-08-26 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: It would be better to rename setBool, pushBool and asBool accessors
to setBoolean, pushBoolean and asBoolean for better matching with the results of
JS typeof operator.
https://bugs.webkit.org/show_bug.cgi?id=44680

  • bindings/js/ScriptProfile.cpp: (WebCore::buildInspectorObjectFor):
  • bindings/v8/ScriptProfile.cpp: (WebCore::buildInspectorObjectFor):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::buildObjectForCookie):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForEventListener): (WebCore::InspectorDOMAgent::populateObjectWithStyleProperties): (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): (WebCore::InspectorDOMAgent::buildObjectForRule):
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
  • inspector/InspectorValues.cpp: (WebCore::InspectorValue::asBoolean): (WebCore::InspectorBasicValue::asBoolean): (WebCore::InspectorBasicValue::asNumber): (WebCore::InspectorBasicValue::writeJSON): (WebCore::InspectorObject::getBoolean):
  • inspector/InspectorValues.h: (WebCore::InspectorValue::): (WebCore::InspectorBasicValue::InspectorBasicValue): (WebCore::InspectorObject::setBoolean): (WebCore::InspectorArray::pushBoolean):
  • inspector/ScriptBreakpoint.cpp: (WebCore::ScriptBreakpoint::sourceBreakpointsFromInspectorObject): (WebCore::ScriptBreakpoint::inspectorObjectFromSourceBreakpoints):
  • inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createTimerInstallData): (WebCore::TimelineRecordFactory::createResourceSendRequestData): (WebCore::TimelineRecordFactory::createResourceFinishData):
6:09 AM WikiStart edited by chang.shu@nokia.com
(diff)
5:45 AM Changeset in webkit [66097] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

Unreviewed.

Update test results after clip-rect changes as part of
https://bugs.webkit.org/show_bug.cgi?id=44594

  • platform/qt/plugins/resize-from-plugin-expected.txt:
5:06 AM Changeset in webkit [66096] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-08-26 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Simon Hausmann.

[Qt] tst_QWebFrame::popupFocus() hardcode the element position
https://bugs.webkit.org/show_bug.cgi?id=44674

This patch dynamically find the position of the combo element instead
of hardcoding a position to click.

  • tests/qwebframe/tst_qwebframe.cpp:
4:56 AM Changeset in webkit [66095] by Girish Ramakrishnan
  • 2 edits in trunk/WebCore

[Qt] Set the clipRect correctly in windowed and windowless mode.
In Windowed mode, the values are in page coordinates. In Windowless
mode the values are in drawable coordinates. Setting these values is
purely academic since they are not used by Flash. However, there is a
possibility that plugins might infer a 'null' clipRect to mean 'invisible'.

https://bugs.webkit.org/show_bug.cgi?id=44594

Reviewed by Simon Hausmann.

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::setNPWindowIfNeeded):

3:55 AM Changeset in webkit [66094] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-08-26 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: enable debugger after resources are pushed to front-end
https://bugs.webkit.org/show_bug.cgi?id=44673

  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::populateScriptObjects):
3:27 AM Changeset in webkit [66093] by Nikolas Zimmermann
  • 12 edits
    8 adds in trunk

2010-08-26 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

text-shadow is not respected in RenderSVGText::repaintRectInLocalCoordinates()
https://bugs.webkit.org/show_bug.cgi?id=44616

Centralize code to calculate the shadow extents in ShadowData.
Respect textShadow() when calculating the repaint rect of RenderSVGText.

Tests: svg/css/composite-shadow-text.svg

transitions/svg-text-shadow-transition.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::adjustRectForOutlineAndShadow):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates): (WebCore::RenderSVGRoot::computeRectForRepaint):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeRectForRepaint): (WebCore::SVGRenderSupport::prepareToRenderSVGContent): (WebCore::SVGRenderSupport::finishRenderSVGContent): (WebCore::SVGRenderSupport::intersectRepaintRectWithResources):
  • rendering/style/SVGRenderStyle.cpp:
  • rendering/style/SVGRenderStyle.h:
  • rendering/style/ShadowData.cpp: (WebCore::calculateShadowExtent): (WebCore::ShadowData::adjustRectForShadow):
  • rendering/style/ShadowData.h:

2010-08-26 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

text-shadow is not respected in RenderSVGText::repaintRectInLocalCoordinates()
https://bugs.webkit.org/show_bug.cgi?id=44616

  • platform/mac/svg/css/composite-shadow-text-expected.checksum: Added.
  • platform/mac/svg/css/composite-shadow-text-expected.png: Added.
  • platform/mac/svg/css/composite-shadow-text-expected.txt: Added.
  • platform/mac/svg/css/text-shadow-multiple-expected.txt:
  • platform/mac/transitions/svg-text-shadow-transition-expected.checksum: Added.
  • platform/mac/transitions/svg-text-shadow-transition-expected.png: Added.
  • platform/mac/transitions/svg-text-shadow-transition-expected.txt: Added.
  • svg/css/composite-shadow-text.svg: Added.
  • transitions/svg-text-shadow-transition.html: Added.
  • transitions/transition-test-helpers.js: Cleanup code, accept negative offsets in the regexp for shadow.
3:17 AM Changeset in webkit [66092] by abecsi@webkit.org
  • 4 edits in trunk/WebKitTools

[Qt] DumpRenderTree runs only one test from command mode
https://bugs.webkit.org/show_bug.cgi?id=44012

Patch by Mahesh Kulkarni <mahesh.kulkarni@nokia.com> on 2010-08-26
Reviewed by Kenneth Rohde Christiansen.

Enables support to run multiple test files and single
folder containing html files in stand alone mode

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::processArgsLine):
(WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
(WebCore::DumpRenderTree::processLine):
(WebCore::DumpRenderTree::dump):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(WebCore::DumpRenderTree::setStandAloneMode):
(WebCore::DumpRenderTree::isStandAloneMode):

  • DumpRenderTree/qt/main.cpp:

(main):

3:05 AM Changeset in webkit [66091] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-08-26 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip a flakey test.

  • platform/gtk/Skipped: Skip media/video-buffered.html
1:58 AM Changeset in webkit [66090] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-08-25 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Rework event definition in the DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=44597

Define DOM events in the base classes that implement EventTarget,
since theoretically you can dispatch any event to any of those
classes whether it makes sense semantically or not.

All the existing events in WebKit are not listed anywhere in the
IDL files, so we need to have the list in the generator script.

  • bindings/scripts/CodeGeneratorGObject.pm:
1:54 AM Changeset in webkit [66089] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-25 Xan Lopez <xlopez@igalia.com>

Reviewed by Kent Tamura.

Local variables 'k' and 'y' in s2b() in dtoa.cpp are computed but not used
https://bugs.webkit.org/show_bug.cgi?id=29259

Remove unused code in dtoa.cpp, spotted by Wan-Teh Chang.

  • wtf/dtoa.cpp: (WTF::s2b):
1:32 AM Changeset in webkit [66088] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium's expectations for a flaky test.

  • platform/chromium/test_expectations.txt:
1:29 AM Changeset in webkit [66087] by loislo@chromium.org
  • 28 edits in trunk

2010-08-25 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: as far as we have 'seq' property in the each inspector message
it would be better to remove explicit callId argument from Inspector.idl functions
declarations.
https://bugs.webkit.org/show_bug.cgi?id=44617

  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/front-end/AuditRules.js:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/CSSStyleModel.js:
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/InjectedScriptAccess.js:
  • inspector/front-end/MetricsSidebarPane.js:
  • inspector/front-end/ProfileView.js:
  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/ScriptView.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/inspector.js:

2010-08-25 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: as far as we have 'seq' property in the each inspector message
it would be better to remove explicit callId argument from Inspector.idl functions
declarations.
https://bugs.webkit.org/show_bug.cgi?id=44617

  • inspector/elements-panel-search.html:
  • inspector/styles-iframe.html:
  • inspector/styles-source-lines.html:
  • inspector/styles-source-offsets.html:
  • http/tests/inspector/inspect-iframe-from-different-domain.html

2010-08-25 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: as far as we have 'seq' property in the each inspector message
it would be better to remove explicit callId argument from Inspector.idl functions
declarations.
https://bugs.webkit.org/show_bug.cgi?id=44617

  • src/js/ProfilerAgent.js: (devtools.ProfilerAgent.prototype._getNextLogLines.else.delayedRequest): (devtools.ProfilerAgent.prototype._getNextLogLines):
1:19 AM Changeset in webkit [66086] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-26 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

Add ENABLE(INDEXED_DATABASE) guard
https://bugs.webkit.org/show_bug.cgi?id=44659

Build fix for ports with index database disabled.

  • storage/IDBKeyPathBackendImpl.cpp:
12:59 AM Changeset in webkit [66085] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-08-26 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping a flakey test.

[GStreamer] multiple <video> elements + PulseAudio are crash-prone
https://bugs.webkit.org/show_bug.cgi?id=44235

  • platform/gtk/Skipped: Skip media/video-transformed.html
12:33 AM Changeset in webkit [66084] by Girish Ramakrishnan
  • 2 edits in trunk/WebCore

[Qt] Replace QLibrary("libgdk-x11-2.0.so.0") with QLibrary("libgdk-x11-2.0", 0)

https://bugs.webkit.org/show_bug.cgi?id=44618

Reviewed by Ariya Hidayat.

  • plugins/qt/PluginViewQt.cpp:

(WebCore::getPluginDisplay):

12:27 AM Changeset in webkit [66083] by abarth@webkit.org
  • 11 edits in trunk/WebCore

2010-08-26 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Deploy adoptPtr to WebCore/loader
https://bugs.webkit.org/show_bug.cgi?id=44591

This patch covers the easy cases. There are a handful of tougher cases
that I'm leaving to a future patch. I filed one bug about a possible
memory leak and I emailed webkit-dev about some infrastructure we'll
need to tackle some of the harder cases.

  • loader/CrossOriginAccessControl.cpp: (WebCore::createAllowedCrossOriginResponseHeadersSet): (WebCore::isOnAccessControlResponseHeaderWhitelist):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::addAllArchiveResources): (WebCore::DocumentLoader::addArchiveResource):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::didReceiveResponse):
  • loader/PingLoader.cpp: (WebCore::PingLoader::loadImage):
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): (WebCore::RedirectScheduler::scheduleRefresh): (WebCore::RedirectScheduler::scheduleHistoryNavigation):
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
  • loader/icon/IconDatabase.cpp: (WebCore::readySQLiteStatement):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::create):
12:23 AM Changeset in webkit [66082] by alex
  • 16 edits in trunk/WebCore

2010-08-26 Alejandro G. Castro <alex@igalia.com>

Reviewed by Dan Bernstein.

shadowSize parameter is used to pass shadow offset in the
GraphicsContext::setShadow and getShadow functions
https://bugs.webkit.org/show_bug.cgi?id=44603

Change the shadowSize parameter ot the functions getShadow and
setShadow in GraphicsContext to shadowOffset which is the current
use of that parameter in the code.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::getShadow):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::calculateShadowBufferDimensions): (WebCore::drawPathShadow): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText):
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
  • platform/graphics/qt/GraphicsContextQt: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow):
  • platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
  • platform/graphics/wince/GraphicsContextWince.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawText):

Aug 25, 2010:

11:29 PM Changeset in webkit [66081] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/WebKit/efl

2010-08-25 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add dummy FullScreenVideoControllerEfl to WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=44590

Add FullScreenVideoControllerEfl to WebCoreSupport. However,
this is not implemented yet.

  • CMakeListsEfl.txt:
  • WebCoreSupport/FullscreenVideoControllerEfl.cpp: Added. (FullscreenVideoController::FullscreenVideoController): (FullscreenVideoController::~FullscreenVideoController): (FullscreenVideoController::setMediaElement): (FullscreenVideoController::showHud): (FullscreenVideoController::hideHud): (FullscreenVideoController::enterFullscreen): (FullscreenVideoController::updateHudPosition): (FullscreenVideoController::exitOnUserRequest): (FullscreenVideoController::exitFullscreen): (FullscreenVideoController::canPlay): (FullscreenVideoController::play): (FullscreenVideoController::pause): (FullscreenVideoController::playStateChanged): (FullscreenVideoController::togglePlay): (FullscreenVideoController::volume): (FullscreenVideoController::muted): (FullscreenVideoController::setVolume): (FullscreenVideoController::volumeChanged): (FullscreenVideoController::muteChanged): (FullscreenVideoController::currentTime): (FullscreenVideoController::setCurrentTime): (FullscreenVideoController::duration): (FullscreenVideoController::percentLoaded): (FullscreenVideoController::beginSeek): (FullscreenVideoController::doSeek): (FullscreenVideoController::endSeek): (timeToString): (FullscreenVideoController::updateHudProgressBar): (FullscreenVideoController::createHud):
  • WebCoreSupport/FullscreenVideoControllerEfl.h: Added. (FullscreenVideoController::mediaElement):
11:13 PM Changeset in webkit [66080] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/efl

2010-08-25 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add setting API for enabling local storage.
https://bugs.webkit.org/show_bug.cgi?id=44319

Add API for enabling/disabling local storage.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_local_storage_get): Added (ewk_view_setting_local_storage_set): Added
  • ewk/ewk_view.h:
9:02 PM Changeset in webkit [66079] by commit-queue@webkit.org
  • 12 edits in trunk

2010-08-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66074.
http://trac.webkit.org/changeset/66074
https://bugs.webkit.org/show_bug.cgi?id=44660

Chromium canary turned red (Requested by yuzo on #webkit).

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::responseText):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseText): (WebCore::XMLHttpRequest::responseXML): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::didFinishLoading):
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequest.idl:

2010-08-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66074.
http://trac.webkit.org/changeset/66074
https://bugs.webkit.org/show_bug.cgi?id=44660

Chromium canary turned red (Requested by yuzo on #webkit).

  • features.gypi:
  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:
8:40 PM Changeset in webkit [66078] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-25 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kevin Ollivier.

[BREWMP] Add build system
https://bugs.webkit.org/show_bug.cgi?id=44645

Make waf script portable so that we can add more ports.

  • wscript:
8:35 PM Changeset in webkit [66077] by mrowe@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/8205479> WebCore's icon database often prevents Safari from being killable via sudden termination

Reviewed by Dan Bernstein.

We need to ensure that each call to disableSuddenTermination is balanced by a corresponding call to enableSuddenTermination.
It's possbile for several calls to IconDatabase::wakeSyncThread to correspond to only a single iteration of the loop within
IconDatabase::syncThreadMainLoop. This results in the sudden termination disable count growing without bound rather than
being balanced when the work completes. We can prevent this by ensuring that we only disable sudden termination once for each
corresponding iteration of the sync thread's main loop.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::wakeSyncThread): Only disable sudden termination if it has not yet been disabled for this iteration of
the sync thread's main loop.
(WebCore::IconDatabase::syncThreadMainLoop): Clear the flag indicating that sudden termination has been disabled after reenabling it
so that future calls to wakeSyncThread disable sudden termination once more.

  • loader/icon/IconDatabase.h:
8:25 PM Changeset in webkit [66076] by commit-queue@webkit.org
  • 2 edits in trunk

2010-08-25 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kevin Ollivier.

[BREWMP] Add build system
https://bugs.webkit.org/show_bug.cgi?id=44645

Make waf script portable so that we can add more ports.

  • wscript:
8:09 PM Changeset in webkit [66075] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-08-25 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

Added new test to check for regression as reported in
https://bugs.webkit.org/show_bug.cgi?id=44600.

  • fast/js/script-tests/string-split-double-empty.js: Added.
  • fast/js/string-split-double-empty-expected.txt: Added.
  • fast/js/string-split-double-empty.html: Added.
7:54 PM Changeset in webkit [66074] by commit-queue@webkit.org
  • 12 edits in trunk

2010-08-25 Michael Nordman <Michael Nordman>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=44133
IDL bindings for XmlHttpRequest.responseBlob support, doesn't do anything yet.
Adds two new attributes, asBlob and responseBlob.
Runtime disabled by default, also behind a new ENABLE_XHR_RESPONSE_BLOB compile time guard.

No new tests, just adding some stubs.

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setResponseBlobEnabled): (WebCore::RuntimeEnabledFeatures::responseBlobEnabled): (WebCore::RuntimeEnabledFeatures::asBlobEnabled):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::responseText): Changed to allow an exceptional return path.
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseTextAccessorGetter): Changed to allow an exceptional return path.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseText): Changed to raise an exception when accessed with asBlob set to true. (WebCore::XMLHttpRequest::responseXML): Changed to raise an exception when accessed with asBlob set to true. (WebCore::XMLHttpRequest::responseBlob): Added stub method, returns 0 for now. (WebCore::XMLHttpRequest::setAsBlob): Sets the asBlob attribute, raises exception if called at an inappropriate time. (WebCore::XMLHttpRequest::open): Resets asBlob to false, the default value. (WebCore::XMLHttpRequest::abort): Clears m_responseBlob. (WebCore::XMLHttpRequest::clearResponse): Clears m_responseBlob. (WebCore::XMLHttpRequest::didFinishLoading): Added a FIXME to populate m_responseBlob.
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::asBlob):
  • xml/XMLHttpRequest.idl:

2010-08-25 Michael Nordman <Michael Nordman>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=44133
WebKitAPI to allow runtime enablement of XmlHttpRequest.responseBlob.

  • features.gypi: Define ENABLE_XHR_RESPONSE_BLOB.
  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableXHRResponseBlob): (WebKit::WebRuntimeFeatures::isXHRResponseBlobEnabled):
6:59 PM Changeset in webkit [66073] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-25 Martin Robinson <mrobinson@igalia.com>

Skip a test that requires editing delegate dumps.

  • platform/gtk/Skipped:
6:52 PM Changeset in webkit [66072] by crogers@google.com
  • 1 edit in branches/audio/WebCore/WebCore.xcodeproj/project.pbxproj

audio branch: tweak to WebCore.xcodeproj

6:45 PM Changeset in webkit [66071] by hclam@chromium.org
  • 9 edits
    4 copies
    1 add in trunk

WebCore: Adding a means of communication between WebKit/WebCore and
chromium in order to share video frames. This adds the necessary
WebKit-side classes and methods, but does not actually use them
yet - that will be committed in a separate patch after the
corresponding Chromium side is committed.

Reviewed by Darin Fisher.
Submitted for Victoria Kirst (vrk@google.com).

https://bugs.webkit.org/show_bug.cgi?id=44539

No new tests, as these new classes/APIs are not yet used.

  • platform/graphics/chromium/VideoFrameChromium.h: Added.

(WebCore::VideoFrameChromium::):

  • platform/graphics/chromium/VideoFrameProvider.h: Added.
  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):

  • platform/graphics/chromium/VideoLayerChromium.h:

WebKit/chromium: Adding a way to communicate video frames between Chromium and WebKit.
The WebKit side acts as a middleman between Chromium and WebCore.
The VideoFrameChromiumImpl is not being used by WebCore yet, as there
still needs to be an implementation of WebVideoFrame in Chromium
-- coming soon in a subsequent patch.

Reviewed by Darin Fisher.
Submitted for Victoria Kirst (vrk@google.com).

API changes for Video Frame sharing between WebKit and Chromium
https://bugs.webkit.org/show_bug.cgi?id=44539

  • WebKit.gyp:
  • public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::getCurrentFrame):
(WebKit::WebMediaPlayer::putCurrentFrame):

  • public/WebVideoFrame.h: Added.
  • src/VideoFrameChromiumImpl.cpp: Added.

(WebKit::VideoFrameChromiumImpl::toWebVideoFrame):
(WebKit::VideoFrameChromiumImpl::VideoFrameChromiumImpl):
(WebKit::VideoFrameChromiumImpl::type):
(WebKit::VideoFrameChromiumImpl::format):
(WebKit::VideoFrameChromiumImpl::width):
(WebKit::VideoFrameChromiumImpl::height):
(WebKit::VideoFrameChromiumImpl::planes):
(WebKit::VideoFrameChromiumImpl::stride):
(WebKit::VideoFrameChromiumImpl::data):

  • src/VideoFrameChromiumImpl.h: Added.
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::create):

  • src/WebMediaPlayerClientImpl.h:
6:39 PM Changeset in webkit [66070] by mrobinson@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-08-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

confirm dialog should show OK/Cancel instead of Yes/No for consistency
https://bugs.webkit.org/show_bug.cgi?id=32877

Change the button labels for the fallback confirmation dialog to be
OK and Cancel.

  • webkit/webkitwebview.cpp: (webkit_web_view_script_dialog):
6:37 PM Changeset in webkit [66069] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-25 Martin Robinson <mrobinson@igalia.com>

Updating webkitpy test expectations.

  • Scripts/webkitpy/tool/steps/steps_unittest.py:
6:32 PM Changeset in webkit [66068] by crogers@google.com
  • 1 edit in branches/audio/WebCore/DerivedSources.make

audio branch: DerivedSources.make WebCore/audio -> WebCore/webaudio

6:02 PM Changeset in webkit [66067] by crogers@google.com
  • 1 edit
    323 moves
    3 adds in branches/audio/WebCore

audio branch: move WebCore/audio to WebCore/webaudio

6:00 PM Changeset in webkit [66066] by kbr@google.com
  • 4 edits in trunk/WebCore

2010-08-25 Kenneth Russell <kbr@google.com>

Reviewed by Simon Fraser.

Source data passed to TypedArray creators should be const
https://bugs.webkit.org/show_bug.cgi?id=44649

Compiled and ran existing WebGL tests to verify.

  • html/canvas/Float32Array.cpp: (WebCore::Float32Array::create):
  • html/canvas/Float32Array.h:
  • html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::create):
5:53 PM Changeset in webkit [66065] by crogers@google.com
  • 2432 deletes in branches/audio/WebCore/audio/AudioSpatialization

audio branch: remove all but composite spatialization HRIR files

5:40 PM Changeset in webkit [66064] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-08-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

fix the always squash git config
https://bugs.webkit.org/show_bug.cgi?id=44651

Fix help text and apparently underscores are not allowed
in git config keys.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/tool/steps/commit.py:
5:40 PM Changeset in webkit [66063] by cmarrin@apple.com
  • 2 edits in trunk/LayoutTests

2010-08-25 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Skipping a couple of compositing tests because layerTreeAsText() is not implemented on Wk2 yet.

  • platform/mac-wk2/Skipped:
5:33 PM Changeset in webkit [66062] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-08-25 Eric Seidel <eric@webkit.org>

Unreviewed, just removing a dead enum.

Remove endTagRequirement now that the LegacyHTMLDocumentParser is dead
https://bugs.webkit.org/show_bug.cgi?id=44626

Remove HTMLTagStatus since it's not used anymore.

  • html/HTMLElement.h:
5:31 PM Changeset in webkit [66061] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: CSS first letter text transform causes crash
https://bugs.webkit.org/show_bug.cgi?id=44352

Reviewed by David Kilzer.

WebCore:

Test: accessibility/first-letter-text-transform-causes-crash.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::nextContinuation):

LayoutTests:

  • accessibility/first-letter-text-transform-causes-crash-expected.txt: Added.
  • accessibility/first-letter-text-transform-causes-crash.html: Added.
5:23 PM Changeset in webkit [66060] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-08-25 Eric Seidel <eric@webkit.org>

Unreviewed. Build fix.

Make Chromiums Broken WebPageSerializerImpl compile again
https://bugs.webkit.org/show_bug.cgi?id=44652

Make it compile again. This code is still horribly wrong.

  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::endTagToString):
5:10 PM Changeset in webkit [66059] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/commit-log-editor: Fix perl warning for people who have no

value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.

Reviewed by John Sullivan.

5:07 PM Changeset in webkit [66058] by ojan@chromium.org
  • 4 edits in trunk/WebKitTools

2010-08-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

stop blocking commits when the bots are red
https://bugs.webkit.org/show_bug.cgi?id=44644

This check currently is just annoying. It doesn't actually
help keep the tree green. We can always add it back later
if we decide the tree is generally more green.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
5:02 PM Changeset in webkit [66057] by eric@webkit.org
  • 58 edits in trunk

2010-08-25 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove endTagRequirement now that the LegacyHTMLDocumentParser is dead
https://bugs.webkit.org/show_bug.cgi?id=44626

Serialization is covered by a bunch of tests. innerHTML behavior is sadly not.
In either case, this is just moving code and should have no functional change.

  • editing/markup.cpp: (WebCore::elementCannotHaveEndTag): (WebCore::MarkupAccumulator::shouldSelfClose): (WebCore::MarkupAccumulator::appendEndMarkup): (WebCore::serializeNodesWithNamespaces):
  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.h:
  • html/HTMLBRElement.h:
  • html/HTMLBaseElement.h:
  • html/HTMLBaseFontElement.h:
  • html/HTMLBlockquoteElement.h:
  • html/HTMLBodyElement.h:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCanvasElement.h:
  • html/HTMLDListElement.h:
  • html/HTMLDataGridCellElement.h:
  • html/HTMLDataGridColElement.h:
  • html/HTMLDirectoryElement.h:
  • html/HTMLDivElement.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): (WebCore::HTMLElement::ieForbidsInsertHTML): (WebCore::HTMLElement::deprecatedCreateContextualFragment): (WebCore::HTMLElement::setInnerText): (WebCore::HTMLElement::setOuterText):
  • html/HTMLElement.h:
  • html/HTMLEmbedElement.h:
  • html/HTMLFontElement.h:
  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.h:
  • html/HTMLFrameSetElement.h:
  • html/HTMLHRElement.h:
  • html/HTMLHeadElement.h:
  • html/HTMLHeadingElement.h:
  • html/HTMLHtmlElement.h:
  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.h:
  • html/HTMLInputElement.h:
  • html/HTMLIsIndexElement.h:
  • html/HTMLLIElement.h:
  • html/HTMLLinkElement.h:
  • html/HTMLMapElement.h:
  • html/HTMLMarqueeElement.h:
  • html/HTMLMenuElement.h:
  • html/HTMLMetaElement.h:
  • html/HTMLModElement.h:
  • html/HTMLOListElement.h:
  • html/HTMLOptionElement.h:
  • html/HTMLParagraphElement.h:
  • html/HTMLParamElement.h:
  • html/HTMLPlugInElement.h:
  • html/HTMLPreElement.h:
  • html/HTMLQuoteElement.h:
  • html/HTMLScriptElement.h:
  • html/HTMLSourceElement.h:
  • html/HTMLStyleElement.h:
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.cpp:
  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.h:
  • html/HTMLTableSectionElement.h:
  • html/HTMLUListElement.h:
4:55 PM Changeset in webkit [66056] by rniwa@webkit.org
  • 3 edits
    1 add
    9 deletes in trunk/LayoutTests

2010-08-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

test conversion: editing/style/typing-style-003.html should use runDumpAsTextEditingTest instead of runEditingTest
https://bugs.webkit.org/show_bug.cgi?id=44646

  • editing/style/typing-style-003-expected.txt: Added.
  • editing/style/typing-style-003.html: Calls runDumpAsTextEditingTest instead of runEditingTest.
  • platform/chromium-linux/editing/style/typing-style-003-expected.checksum: Removed.
  • platform/chromium-win/editing/style/typing-style-003-expected.checksum: Removed.
  • platform/chromium-win/editing/style/typing-style-003-expected.png: Removed.
  • platform/chromium-win/editing/style/typing-style-003-expected.txt: Removed.
  • platform/gtk/editing/style/typing-style-003-expected.txt: Removed.
  • platform/mac/editing/style/typing-style-003-expected.checksum: Removed.
  • platform/mac/editing/style/typing-style-003-expected.png: Removed.
  • platform/mac/editing/style/typing-style-003-expected.txt: Removed.
  • platform/qt/Skipped: Run typing-style-003.html on qt again.
  • platform/qt/editing/style/typing-style-003-expected.txt: Removed.
4:40 PM Changeset in webkit [66055] by zmo@google.com
  • 14 edits in trunk

2010-08-20 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGL must enforce restrictions even if running on OpenGL ES 2.0
https://bugs.webkit.org/show_bug.cgi?id=42908

  • public/WebGraphicsContext3D.h: Add two new flags.
  • src/GraphicsContext3D.cpp: Ditto. (WebCore::GraphicsContext3DInternal::isGLES2NPOTStrict): (WebCore::GraphicsContext3DInternal::isErrorGeneratedOnOutOfBoundsAccesses): (WebCore::GraphicsContext3D::isGLES2NPOTStrict): (WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):
  • src/WebGraphicsContext3DDefaultImpl.cpp: Ditto. (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2NPOTStrict): (WebKit::WebGraphicsContext3DDefaultImpl::isErrorGeneratedOnOutOfBoundsAccesses):
  • src/WebGraphicsContext3DDefaultImpl.h: Ditto.

2010-08-20 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGL must enforce restrictions even if running on OpenGL ES 2.0
https://bugs.webkit.org/show_bug.cgi?id=42908

  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::getColorBufferFormat): Get format at given level instead of 0.
  • html/canvas/WebGLRenderingContext.cpp: Add two new flags and use them to replace the original isGLES2Compliant(). (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::blendEquation): (WebCore::WebGLRenderingContext::blendEquationSeparate): (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::checkFramebufferStatus): (WebCore::WebGLRenderingContext::clear): (WebCore::WebGLRenderingContext::copyTexImage2D): (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::disable): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enable): (WebCore::WebGLRenderingContext::generateMipmap): (WebCore::WebGLRenderingContext::hint): (WebCore::WebGLRenderingContext::isEnabled): (WebCore::WebGLRenderingContext::texImage2DBase): (WebCore::WebGLRenderingContext::texParameter): (WebCore::WebGLRenderingContext::isGLES2NPOTStrict): (WebCore::WebGLRenderingContext::isErrorGeneratedOnOutOfBoundsAccesses):
  • html/canvas/WebGLRenderingContext.h: Declare two new flags.
  • html/canvas/WebGLTexture.cpp: Get format at given level instead of 0. (WebCore::WebGLTexture::getInternalFormat):
  • html/canvas/WebGLTexture.h: Ditto.
  • platform/graphics/GraphicsContext3D.h: Add three new flags.
  • platform/graphics/mac/GraphicsContext3DMac.mm: Ditto. (WebCore::GraphicsContext3D::isGLES2NPOTStrict): (WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto. (WebCore::GraphicsContext3D::isGLES2NPOTStrict): (WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):
4:38 PM Changeset in webkit [66054] by bfulgham@webkit.org
  • 4 edits in trunk

WebCore: Build correction, no review.

  • WebCore.vcproj/WebCore.vcproj: Add missing implementation for PlatformRefPtrCairo.

WebKit2: Build fix, no review.

Add conditional guards around Safari-specific
include files.

  • WebProcess/WebPage/win/WebPageWin.cpp:
4:37 PM Changeset in webkit [66053] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-08-25 Eric Seidel <eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
https://bugs.webkit.org/show_bug.cgi?id=38912

I know of nothing else to do but skip all media tests for the cq.

  • Scripts/webkitpy/tool/steps/runtests.py:
4:10 PM Changeset in webkit [66052] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-08-25 Cris Neckar <cdn@chromium.org>

Reviewed by Darin Adler.

Added abort condition for RenderCounters when traversing a detached render tree.
https://bugs.webkit.org/show_bug.cgi?id=43812

Test: fast/css/counters/counter-traverse-object-crash.html

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter):

2010-08-25 Cris Neckar <cdn@chromium.org>

Reviewed by Darin Adler.

Assertion failure in RenderCounter when traversing a detached render trees.
https://bugs.webkit.org/show_bug.cgi?id=43812

  • fast/css/counters/counter-traverse-object-crash-expected.txt: Added.
  • fast/css/counters/counter-traverse-object-crash.html: Added.
3:55 PM Changeset in webkit [66051] by crogers@google.com
  • 1 edit
    79 moves
    2 adds in branches/audio/WebCore

audio branch: move relevant files to WebCore/platform/audio

3:49 PM Changeset in webkit [66050] by cmarrin@apple.com
  • 6 edits
    2 adds in trunk

2010-08-25 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=44629
Add layer consistency checking and fix found crashing bug


The crash was being caused by some of the calls which mutated
the sublayer list leaving the list in an inconsistent state.
This eventually lead to a crash. It would also lead to visual
artifacts if the crash didn't occur. Added consistency checking
to catch this and any other inconsistencies in the sublayer list.


The particular bug in this case was caused by clamping an index
for insertion to the current size of the sublayer list. CACF uses
an index equal to the current length to indicate an append operation.
With tiled layers the apparent size of the list is one less than its
actual size (to accomodate the layer which holds the list of tiles)
so this clamping was causing the new layer to get inserted before the
tile parent. The tile parent was then mistaken for a WKCACFLayer and
it eventually tried to deref that layer, causing the crash.


I also added some protection when destroying a WKCACFLayer. The user data
for the corresponding CACFLayer is now changed to 0xDeadBeef rather than
null. This allows dangling layers to be more easily identified. This
value is checked and ASSERTed if seen. I also remove the sublayers
on destruction to make the consistency checks work properly while
a layer is being destroyed.

Test: compositing/tiling/crash-reparent-tiled-layer.html

3:17 PM Changeset in webkit [66049] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-08-25 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: add more unit tests for test_expectations
This adds unit tests to cover (almost?) all of the non-rebaselining
functionality.

https://bugs.webkit.org/show_bug.cgi?id=44579

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3:15 PM Changeset in webkit [66048] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

2010-08-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebCore::InsertListCommand::modifyRange infinite loop (100% CPU usage)
https://bugs.webkit.org/show_bug.cgi?id=33668

The bug was caused by enclosingListChild returning a list child whose enclosing list is
a sibling of the current list child. Fixed enclosingListChild to traverse upwards
in the DOM to find the list child which is a sibling of the current list child.
Also fixed adjacentEnclosingList to only returns the list that belongs to the same outer list.

In doApplyForSingleParagraph, if the start or the end of currentSelection existed inside a list content
moved by moveParagraphWithClones, either end could point to a wrong position after the move.
Fixed this problem by checking this condition upfront and restoring later.

In doApply, if moveParagraph or moveParagraphWithClones, endOfSelection or startOfLastParagraph
could be null or orphaned, fixed this problem by indexForVisiblePosition.

Test: editing/execCommand/insert-list-orphaned-item-with-nested-lists.html

  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): (WebCore::enclosingListChild): (WebCore::InsertListCommand::doApplyForSingleParagraph): (WebCore::adjacentEnclosingList): (WebCore::InsertListCommand::listifyParagraph):

2010-08-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebCore::InsertListCommand::modifyRange infinite loop (100% CPU usage)
https://bugs.webkit.org/show_bug.cgi?id=33668

Added a test to convert nested lists with an orphaned list child to an ordered nested list.
Selection in switch-list-type-with-inner-list.html is restored correctly after inserting list.

  • editing/execCommand/insert-list-orphaned-item-with-nested-lists-expected.txt: Added.
  • editing/execCommand/insert-list-orphaned-item-with-nested-lists.html: Added.
  • editing/execCommand/switch-list-type-with-inner-list-expected.txt: Selection is restored correctly.
2:58 PM Changeset in webkit [66047] by bfulgham@webkit.org
  • 5 edits in trunk/WebCore

Build corrections, no review.

  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Add include for new (missing) "CairoPath.h" class.
  • platform/graphics/cairo/PlatformRefPtrCairo.h: Correct include and compilation guards to match coding conventions.
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp: Change implementation to match CG version, using the FontCustomPlatformData name, rather than the original FontCustomPlatformDataCairo.
  • platform/graphics/win/FontCustomPlatformDataCairo.h: Same as for the .cpp file.
2:52 PM Changeset in webkit [66046] by crogers@google.com
  • 1 add in branches/audio/WebCore/platform/audio

audio branch: add WebCore/platform/audio directory

2:45 PM Changeset in webkit [66045] by dpranke@chromium.org
  • 5 edits
    10 adds in trunk/WebKitTools

2010-08-25 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: add more unit tests

This change adds more unit tests for the image_diff, test_failures,
and test_files modules, bringing them to 100% coverage (and adds a
couple tests to run_webkit_tests while we're at it).

This test also turns on the "dryrun" port for testing when run on
the mac, increasing coverage in a few other places.

https://bugs.webkit.org/show_bug.cgi?id=44578

  • Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
  • Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
  • Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
  • Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
  • Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
  • Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
  • Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2:42 PM Changeset in webkit [66044] by crogers@google.com
  • 91 edits in branches/audio

audio branch: add feature defines

2:41 PM Changeset in webkit [66043] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-08-25 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: add more unit tests for layout_package/printing.py

This change adds more unit tests to get the test coverage to 100%
for the printing module. This code is actually pretty crufty and
has some layering violations that need to be cleaned up but I'll
save that for another CL after we get all the unit tests written and
we fix the multithreading issues. At least now we'll be able to tell
if we break things.

https://bugs.webkit.org/show_bug.cgi?id=44576

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2:27 PM Changeset in webkit [66042] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-25 Krzysztof Czech <k.czech@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Crash while calling PopupMenuEfl destructor
https://bugs.webkit.org/show_bug.cgi?id=44497

Condition checks if m_view is defined
before popup is hide

  • platform/efl/PopupMenuEfl.cpp: (WebCore::PopupMenuEfl::~PopupMenuEfl):
2:16 PM Changeset in webkit [66041] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-08-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests should respect set-webkit-configuration
https://bugs.webkit.org/show_bug.cgi?id=44633

Moves the getting of the configuration into the base Port so that
chromium ports use it as well. In the downstream chromium port,
this should still just return Release.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
2:15 PM Changeset in webkit [66040] by rniwa@webkit.org
  • 12 edits
    3 adds in trunk

2010-08-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Creating a link when selecting multiple nodes creates multiple links
https://bugs.webkit.org/show_bug.cgi?id=30836

The bug was caused by applyInlineStyleToRange calling addInlineStyleIfNeeded
on each inline element. Modified applyInlineStyleToRange to call addInlineStyleIfNeeded
once for all inline elements with the same style difference.

Because this implies that anchor element may wrap other inline elements when added,
modified pushDownInlineStyleAroundNode to push down styled elements.

Removed pushPartiallySelectedAnchorElementsDown from CompositeEditCommand since
ApplyStyleCommand now correctly pushes down anchors at the start and the end of the selection.

Test: editing/execCommand/toggle-link.html

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::operator==): Added. (WebCore::StyleChange::operator!=): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Wraps inline elements with the same style difference by one element instead of wrapping each element separately. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Extracts styled element. (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Avoids adding styled element. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Pushes down styled element. (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): No longer checks inline-ness. (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Adds style even when m_removeOnly. Callers should set addStyledElement = DoNotAddStyledElement to avoid adding styled element.
  • editing/ApplyStyleCommand.h:
  • editing/CompositeEditCommand.cpp: Removed pushPartiallySelectedAnchorElementsDown.
  • editing/CompositeEditCommand.h: Removed pushPartiallySelectedAnchorElementsDown.
  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): used to call pushPartiallySelectedAnchorElementsDown.
  • editing/UnlinkCommand.cpp: (WebCore::UnlinkCommand::doApply): Used to call pushPartiallySelectedAnchorElementsDown.

2010-08-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Creating a link when selecting multiple nodes creates multiple links
https://bugs.webkit.org/show_bug.cgi?id=30836

Added a test to ensure WebKit creates single anchor element on execCommand('createLink') if possible.
Also rebaselined several tests to match new behavior.

  • editing/execCommand/createLink-expected.txt: Merged some anchor elements.
  • editing/execCommand/script-tests/toggle-link.js: Added. (testSingleToggle): (selectAll): (selectFirstTwoWords): (selectLastWord):
  • editing/execCommand/script-tests/toggle-style-3.js: i elements are merged.
  • editing/execCommand/toggle-style-3-expected.txt: Ditto.
  • editing/execCommand/toggle-link-expected.txt: Added.
  • editing/execCommand/toggle-link.html: Added.
  • editing/execCommand/unlink-expected.txt: Merged some anchor elements.
1:28 PM Changeset in webkit [66039] by zmo@google.com
  • 27 edits
    13 adds in trunk

2010-08-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
https://bugs.webkit.org/show_bug.cgi?id=38282

  • src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::init): Add premultiplyAlpha flag.

2010-08-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
https://bugs.webkit.org/show_bug.cgi?id=38282

Test: fast/canvas/webgl/gl-teximage.html

  • platform/graphics/GraphicsContext3D.cpp: Fix a bug where alpha channel is ignored.
  • platform/graphics/ImageSource.cpp: Add premultiplyAlpha flag. (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::setData):
  • platform/graphics/ImageSource.h: Ditto.
  • platform/graphics/cg/ImageSourceCG.cpp: Ditto. (WebCore::ImageSource::ImageSource):
  • platform/graphics/qt/ImageDecoderQt.cpp: Ditto. (WebCore::ImageDecoder::create): (WebCore::ImageDecoderQt::ImageDecoderQt): (WebCore::ImageDecoderQt::frameCount): (WebCore::ImageDecoderQt::forceLoadEverything):
  • platform/graphics/qt/ImageDecoderQt.h: Ditto.
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: Fix the premultiplyAlpha data loss issue in skia. (WebCore::GraphicsContext3D::getImageData):
  • platform/image-decoders/ImageDecoder.cpp: Add premultiplyAlpha flag. (WebCore::ImageDecoder::create): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::operator=):
  • platform/image-decoders/ImageDecoder.h: Ditto. (WebCore::RGBA32Buffer::premultiplyAlpha): (WebCore::RGBA32Buffer::setPremultiplyAlpha): (WebCore::RGBA32Buffer::setRGBA): (WebCore::ImageDecoder::ImageDecoder):
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: Ditto. (WebCore::BMPImageDecoder::BMPImageDecoder): (WebCore::BMPImageDecoder::frameBufferAtIndex):
  • platform/image-decoders/bmp/BMPImageDecoder.h: Ditto.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: Ditto. (WebCore::GIFImageDecoder::GIFImageDecoder): (WebCore::GIFImageDecoder::frameCount):
  • platform/image-decoders/gif/GIFImageDecoder.h: Ditto.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: Ditto. (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::frameCount): (WebCore::ICOImageDecoder::decodeAtIndex):
  • platform/image-decoders/ico/ICOImageDecoder.h: Ditto.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Ditto. (WebCore::JPEGImageDecoder::JPEGImageDecoder): (WebCore::JPEGImageDecoder::frameBufferAtIndex):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: Ditto.
  • platform/image-decoders/png/PNGImageDecoder.cpp: Ditto. (WebCore::PNGImageDecoder::PNGImageDecoder): (WebCore::PNGImageDecoder::frameBufferAtIndex):
  • platform/image-decoders/png/PNGImageDecoder.h: Ditto.
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: Ditto. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::operator=):

2010-08-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
https://bugs.webkit.org/show_bug.cgi?id=38282

  • fast/canvas/webgl/gl-teximage-expected.txt: Added.
  • fast/canvas/webgl/gl-teximage.html: Added.
  • fast/canvas/webgl/resources/3x3.png: Added.
  • fast/canvas/webgl/resources/gray-ramp-256-with-128-alpha.png: Added.
  • fast/canvas/webgl/resources/gray-ramp-256.png: Added.
  • fast/canvas/webgl/resources/gray-ramp-default-gamma.png: Added.
  • fast/canvas/webgl/resources/gray-ramp-gamma0.1.png: Added.
  • fast/canvas/webgl/resources/gray-ramp-gamma1.0.png: Added.
  • fast/canvas/webgl/resources/gray-ramp-gamma2.0.png: Added.
  • fast/canvas/webgl/resources/gray-ramp-gamma4.0.png: Added.
  • fast/canvas/webgl/resources/gray-ramp-gamma9.0.png: Added.
  • fast/canvas/webgl/resources/gray-ramp.png: Added.
  • fast/canvas/webgl/resources/webgl-test-utils.js: Sync with khronos. (WebGLTestUtils):
  • fast/canvas/webgl/resources/zero-alpha.png: Added.
  • platform/chromium/test_expectations.txt: Don't run gl-teximage.html for mac.
  • platform/mac/Skipped: Don't run gl-teximage.html for mac.
1:27 PM Changeset in webkit [66038] by demarchi@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-08-25 Jaehun Lim <ljaehun.lim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] enable libsoup's content decode feature
https://bugs.webkit.org/show_bug.cgi?id=44147

libsoup's content decode feature is enabled during initializaton.

  • ewk/ewk_main.cpp: (ewk_init):
1:23 PM Changeset in webkit [66037] by abarth@webkit.org
  • 25 edits
    4 deletes in trunk/WebCore

2010-08-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove XBL
https://bugs.webkit.org/show_bug.cgi?id=44621

This patch removes support for XBL. XBL seems cool, but this code is
old and pretty bitrotten. If we decide to support XBL in the future,
we can recover this code from this revision. As it stands, it doesn't
seem worth half-maintaining this code.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
  • dom/Document.h:
  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::getStatistics):
  • loader/Cache.h:
  • loader/CachedResource.h: (WebCore::CachedResource::):
  • loader/CachedResourceClient.h: (WebCore::CachedResourceClient::setXSLStyleSheet): (WebCore::CachedResourceClient::fontLoaded):
  • loader/CachedXBLDocument.cpp: Removed.
  • loader/CachedXBLDocument.h: Removed.
  • loader/DocLoader.cpp: (WebCore::DocLoader::canRequest):
  • loader/DocLoader.h:
  • loader/loader.cpp: (WebCore::cachedResourceTypeToTargetType): (WebCore::Loader::determinePriority):
  • rendering/style/BindingURI.cpp: Removed.
  • rendering/style/BindingURI.h: Removed.
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h:
1:08 PM Changeset in webkit [66036] by andreas.kling@nokia.com
  • 4 edits in trunk

2010-08-25 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] GraphicsContext: Construct with the correct default LineJoin (MiterJoin)

We weren't setting it explicitly which caused us to use Qt::MiterJoin when
we actually want Qt::SvgMiterJoin.

Fixes display glitches on the "Monster" chrome experiment among other things.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::GraphicsContext):

2010-08-25 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] GraphicsContext: Construct with the correct default LineJoin (MiterJoin)

Skip canvas/philip/tests/2d.path.rect.zero.1.html
It was working because we didn't properly initialize the GC's LineJoin mode.

  • platform/qt/Skipped:
1:06 PM Changeset in webkit [66035] by Adam Roben
  • 2 edits in trunk/WebKit2

Clean up Connection::open on Windows

Fixes <http://webkit.org/b/44185>.

Reviewed by Steve Falkenburg.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::platformInitialize): Set m_isConnected to true
since the pipe got connected before it was even given to us.
(CoreIPC::Connection::readEventHandler): Removed code that will never
run now that m_isConnected is always true when this function is
called. Since no outgoing messages will have been queued before
m_isConnected is set to true, there's no need to send them explicitly
here; they'll get sent as they're queued.
(CoreIPC::Connection::open): Removed the call to ::ConnectNamedPipe,
since the pipe is already connected by this point. Changed to schedule
a read in the server and client the same way (rather than using
::SetEvent in the server).

12:54 PM Changeset in webkit [66034] by Dimitri Glazkov
  • 2 edits
    3 moves in trunk/LayoutTests

2010-08-25 Fady Samuel <fsamuel@chromium.org>

Reviewed by Dimitri Glazkov.

Table Rendering Layout Test Expectations Updated
https://bugs.webkit.org/show_bug.cgi?id=44429

Simple Paint test appears to render the same on Mac, Windows, and Linux.

Updated test expectations to match this and moved the expectations into the test directory.

  • fast/table/simple_paint-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/fast/table/simple_paint-expected.checksum.
  • fast/table/simple_paint-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/table/simple_paint-expected.png.
  • fast/table/simple_paint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/table/simple_paint-expected.txt.
  • platform/chromium/test_expectations.txt:
12:25 PM Changeset in webkit [66033] by demarchi@webkit.org
  • 2 edits in trunk/WebCore

2010-08-25 Rafael Antognolli <antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Build fix for revision 66024
https://bugs.webkit.org/show_bug.cgi?id=44631

No new features added, so no new tests.

  • CMakeListsEfl.txt: change GRefPtrCairo.cpp by PlatformRefPtrCairo.cpp.
12:19 PM Changeset in webkit [66032] by rniwa@webkit.org
  • 18 edits
    8 adds in trunk

2010-08-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Various designmode=&quot;on&quot;/&quot;off&quot; &amp; execCommand(&quot;Undo&quot;) NULL pointer crashes
https://bugs.webkit.org/show_bug.cgi?id=32823

The bug was caused by changeSelectionAfterCommand which updates the selection
without checking the whether new selection is valid or not.

Fixed changeSelectionAfterCommand so that it won't update the selection
when either end of the new selection is orphaned. Also fixed various editing commands
to exit early if either end of the selection is orphaned.

Tests: editing/undo/orphaned-selection-crash-bug32823-1.html

editing/undo/orphaned-selection-crash-bug32823-2.html
editing/undo/orphaned-selection-crash-bug32823-3.html
editing/undo/orphaned-selection-crash-bug32823-4.html

  • editing/Editor.cpp: (WebCore::Editor::changeSelectionAfterCommand): No longer sets orphaned selection.
  • editing/VisibleSelection.h: (WebCore::VisibleSelection::isNonOrphanedRange): Added. (WebCore::VisibleSelection::isNonOrphanedCaretOrRange): Added.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Added an early exist. See above.
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Ditto.
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::doApply): Ditto.
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Ditto.
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Ditto.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Ditto.
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply): Ditto.
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Ditto.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::doApply): Ditto.
  • editing/UnlinkCommand.cpp: (WebCore::UnlinkCommand::doApply): Ditto.

2010-08-25 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Various designmode="on"/"off" & execCommand("Undo") NULL pointer crashes
https://bugs.webkit.org/show_bug.cgi?id=32823

These tests ensure WebKit doesn't crash when undoing some editing commands failed
and either end of endingSelection() became orphaned.
All tests are copied from the bug to prevent regression.

  • editing/undo/orphaned-selection-crash-bug32823-1-expected.txt: Added.
  • editing/undo/orphaned-selection-crash-bug32823-1.html: Added.
  • editing/undo/orphaned-selection-crash-bug32823-2-expected.txt: Added.
  • editing/undo/orphaned-selection-crash-bug32823-2.html: Added.
  • editing/undo/orphaned-selection-crash-bug32823-3-expected.txt: Added.
  • editing/undo/orphaned-selection-crash-bug32823-3.html: Added.
  • editing/undo/orphaned-selection-crash-bug32823-4-expected.txt: Added.
  • editing/undo/orphaned-selection-crash-bug32823-4.html: Added.
  • editing/undo/redo-split-text-with-removal-expected.txt: Caret is restored.
11:55 AM Changeset in webkit [66031] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-08-25 Michael Saboff <msaboff@apple.com>

Reviewed by Sam Weinig.

Remove the single entry regular expression cache introduced as part of
the fix for https://bugs.webkit.org/show_bug.cgi?id=41238.
The performance problem in Dromaeo that initiated that bug is no
longer present. Dromaeo has been modified so that the regular
expression tests are somewhat random and don't benefit from a
single entry cache.

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::match):
  • runtime/RegExp.h:
11:30 AM Changeset in webkit [66030] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-08-25 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Simon Hausmann.

In FrameLoaderClientQt::createFrame we should call loadURLIntoChildFrame
with parent frame's loader instead of child frame's loader.
https://bugs.webkit.org/show_bug.cgi?id=43930

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):
11:26 AM Changeset in webkit [66029] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-08-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

make perf tests work with V8
https://bugs.webkit.org/show_bug.cgi?id=44623

V8 doesn't support getJSObjectCount.

  • resources/magnitude-perf.js: (Magnitude._runIteration): (Magnitude):
11:24 AM Changeset in webkit [66028] by Simon Fraser
  • 6 edits
    2 adds in trunk

2010-08-25 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Flash content draws in front of site's drop down menu at http://www.monster.com/
https://bugs.webkit.org/show_bug.cgi?id=41330

If an iframe with composited content became overlapped, we failed to
consider that iframe for compositing if it had no RenderLayer, so the layering
would be incorrect.

Overlap is detected at painting time, but it's bad for FrameView::setIsOverlapped()
to call setNeedsStyleRecalc(), because this would cause subsequent calls to
FrameView::paintContents() in the same painting batch to bail with needsLayout().

Instead, we do the setNeedsStyleRecalc() from RenderLayerCompositor::notifyIFramesOfCompositingChange(),
so that the parent document has a chance to update style, and give the iframe a RenderLayer.
Then setIsOverlapped() simply needs to schedule a layer update, which we do on a timer.

When dumping layers via Frame::layerTreeAsText(), if a layer update is pending, then
update the layers.

Test: compositing/iframes/become-overlapped-iframe.html

  • page/Frame.cpp: (WebCore::Frame::layerTreeAsText):
  • page/FrameView.cpp: (WebCore::FrameView::setIsOverlapped):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): (WebCore::RenderLayerCompositor::scheduleCompositingLayerUpdate): (WebCore::RenderLayerCompositor::compositingLayerUpdatePending): (WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired): (WebCore::RenderLayerCompositor::updateCompositingLayers): (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
  • rendering/RenderLayerCompositor.h:
11:22 AM Changeset in webkit [66027] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-25 Tony Chang <tony@chromium.org>

Not reviewed, changing svn props for a script.

  • Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
11:17 AM Changeset in webkit [66026] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-08-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove WebKit2 from core builders
https://bugs.webkit.org/show_bug.cgi?id=44625

This builder was added to the core builders by accident. It doesn't
appear to be green enough to be a core builder yet.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
11:12 AM Changeset in webkit [66025] by Adam Roben
  • 4 edits in trunk

Call NP_GetEntryPoints before NP_Initialize on Windows

Doing otherwise will cause Flash and QuickTime to crash inside
NP_Initialize.

Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
NP_Initialize when loading QuickTime when running
plugins/embed-attributes-setting.html in WebKit2 on Windows

Reviewed by John Sullivan.

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad): On Windows, first call
NP_GetEntryPoints, then NP_Initialize. Do the reverse on Mac to
prevent Silverlight (e.g.) from crashing (see r38858).

WebKitTools:

Test that NP_Initialize and NP_GetEntryPoints are called in the
correct order

The order differs between Mac and Windows (see r38858).

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and

a boolean to record whether NP_GetEntryPoints has been called.
(NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
called yet. This matches Flash and QuickTime's behavior.
(NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
yet. This matches Silverlight's behavior.

11:00 AM Changeset in webkit [66024] by mrobinson@webkit.org
  • 31 edits
    2 moves
    1 add in trunk

2010-08-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Cairo and EFL port shouldn't depend on glib.
https://bugs.webkit.org/show_bug.cgi?id=44354

Replace GRefPtr with PlatformRefPtr. Keep GLib specific bits in
GRefPtr.h.

  • GNUmakefile.am: Add PlatformRefPtr.h to the source list.
  • wtf/PlatformRefPtr.h: Migrated from GRefPtr.h. (WTF::PlatformRefPtr::PlatformRefPtr): Ditto. (WTF::PlatformRefPtr::~PlatformRefPtr): Ditto. (WTF::PlatformRefPtr::clear): Ditto. (WTF::PlatformRefPtr::get): Ditto. (WTF::PlatformRefPtr::operator*): Ditto. (WTF::PlatformRefPtr::operator->): Ditto. (WTF::PlatformRefPtr::operator!): Ditto. (WTF::PlatformRefPtr::operator UnspecifiedBoolType): Ditto. (WTF::PlatformRefPtr::hashTableDeletedValue): Ditto. (WTF::::operator): Ditto. (WTF::::swap): Ditto. (WTF::swap): Ditto. (WTF::operator==): Ditto. (WTF::operator!=): Ditto. (WTF::static_pointer_cast): Ditto. (WTF::const_pointer_cast): Ditto. (WTF::getPtr): Ditto. (WTF::adoptPlatformRef): Ditto.
  • wtf/gobject/GRefPtr.cpp: Changes to reflect new names. (WTF::refPlatformPtr): (WTF::derefPlatformPtr):
  • wtf/gobject/GRefPtr.h: Ditto. (WTF::refPlatformPtr): (WTF::derefPlatformPtr):

2010-08-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Cairo and EFL port shouldn't depend on glib.
https://bugs.webkit.org/show_bug.cgi?id=44354

No new tests as functionality has not changed.

Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
adoptPlatformRef. Rename GRefPtrCairo to PlatformRefPtrCairo.

  • GNUmakefile.am:
  • platform/Cursor.h:
  • platform/graphics/cairo/GRefPtrCairo.cpp: Removed.
  • platform/graphics/cairo/GRefPtrCairo.h: Removed.
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
  • platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added. (WTF::refPlatformPtr): (WTF::derefPlatformPtr):
  • platform/graphics/cairo/PlatformRefPtrCairo.h: Added.
  • platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::declareAndWriteDragImage):
  • platform/gtk/CursorGtk.cpp: (WebCore::createNamedCursor): (WebCore::createCustomCursor): (WebCore::Cursor::ensurePlatformCursor):
  • platform/gtk/DataObjectGtk.h:
  • platform/gtk/GRefPtrGtk.cpp: (WTF::refPlatformPtr): (WTF::derefPlatformPtr):
  • platform/gtk/GRefPtrGtk.h:
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::dropAtomsForContext):
  • platform/gtk/PopupMenuGtk.h:
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): (WebCore::paintMozillaGtkWidget):
  • platform/gtk/RenderThemeGtk.h:

2010-08-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Cairo and EFL port shouldn't depend on glib.
https://bugs.webkit.org/show_bug.cgi?id=44354

Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
adoptPlatformRef.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag):
  • WebCoreSupport/EditorClientGtk.h:
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::createPlugin):
  • WebCoreSupport/FullscreenVideoController.h:
  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::populateSetting): (WebKit::InspectorClient::storeSetting):
  • webkit/webkitdownload.cpp: (webkit_download_error):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_new_with_core_request):
  • webkit/webkitnetworkresponse.cpp: (webkit_network_response_new_with_core_response):

2010-08-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Cairo and EFL port shouldn't depend on glib.
https://bugs.webkit.org/show_bug.cgi?id=44354

Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
adoptPlatformRef.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::isSelected):
10:51 AM Changeset in webkit [66023] by eric.carlson@apple.com
  • 9 edits in trunk

2010-08-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

HTMLMediaElement.canPlayType must be case insensitive for MIME type.
https://bugs.webkit.org/show_bug.cgi?id=44577

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): (WebCore::MediaPlayer::supportsType):

2010-08-24 Eric Carlson <eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

HTMLMediaElement.canPlayType must be case insensitive for MIME type.
https://bugs.webkit.org/show_bug.cgi?id=44577

  • media/media-can-play-octet-stream-expected.txt:
  • media/media-can-play-octet-stream.html:
  • media/media-can-play-ogg-expected.txt:
  • media/media-can-play-ogg.html:
  • media/video-can-play-type-expected.txt:
  • media/video-can-play-type.html:
10:35 AM Changeset in webkit [66022] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-08-25 Ojan Vafai <ojan@chromium.org>

Fix order of Timothy's email address. The script, and
other tools all assume that the first email is the bugzilla address.

  • Scripts/webkitpy/common/config/committers.py:
10:33 AM Changeset in webkit [66021] by xan@webkit.org
  • 4 edits in trunk

2010-08-25 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] CodeGeneratorGObject not picking up FEATURE_DEFINES
https://bugs.webkit.org/show_bug.cgi?id=44608

Move FEATURE_DEFINES declaration here, since it's used by the
bindings code generator. Also, fix typo in the variable holding
the defines.

  • GNUmakefile.am:

WebCore:

2010-08-25 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] CodeGeneratorGObject not picking up FEATURE_DEFINES
https://bugs.webkit.org/show_bug.cgi?id=44608

Move FEATURE_DEFINES declaration to the toplevel GNUmakefile.am,
since it's used there now too.

  • GNUmakefile.am:
10:10 AM Changeset in webkit [66020] by tony@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-08-25 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] remove chromium.Interval layout test
https://bugs.webkit.org/show_bug.cgi?id=44614

chromium.Interval is moving into the benchmarking namespace
and not being exposed by default.

  • platform/chromium/fast/dom/interval-expected.txt: Removed.
  • platform/chromium/fast/dom/interval.html: Removed.
10:02 AM Changeset in webkit [66019] by xan@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-08-25 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

Remove dead code in JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=44615

The recursion data member in the JSGlobalObject and its getter
plus inc/dec methods seems to be unused, remove them.

  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init):
  • runtime/JSGlobalObject.h:
9:39 AM Changeset in webkit [66018] by demarchi@webkit.org
  • 4 edits in trunk

2010-08-25 Rafael Antognolli <antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Build fix for revision 65332
https://bugs.webkit.org/show_bug.cgi?id=44543

Generated variables are now returned from FindPkgConfig, so no need
to document the custom ones.

  • cmake/FindGthread.cmake:

2010-08-25 Rafael Antognolli <antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Build fix for revision 65332
https://bugs.webkit.org/show_bug.cgi?id=44543

Use Gthread_LIBRARIES instead of GTHREAD_LIBRARIES. This fix
the build when using ENABLE_GLIB_SUPPORT=ON and NETWORK_BACKEND=curl.

  • CMakeListsEfl.txt:
9:33 AM Changeset in webkit [66017] by Girish Ramakrishnan
  • 2 edits in trunk/WebCore

2010-08-25 Dawit Alemayehu <adawit@kde.org>

Reviewed by Ariya Hidayat.

Proper workaround for missing Gtk initialization in Adobe's flash plugins.
https://bugs.webkit.org/show_bug.cgi?id=44405

  • plugins/qt/PluginPackageQt.cpp: (WebCore::initializeGtk): (WebCore::PluginPackage::load):
9:18 AM Changeset in webkit [66016] by mnaganov@chromium.org
  • 1 edit in trunk/WebCore/English.lproj/localizedStrings.js

Unreviewed -- no code change. Sort WebCore/English.lproj/localizedStrings.js.

8:48 AM Changeset in webkit [66015] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-08-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: support checked and disabled context menu items.
https://bugs.webkit.org/show_bug.cgi?id=44612

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
7:42 AM Changeset in webkit [66014] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-08-25 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: InspectorBackendStub.js is not updated when Inspector.idl changes.
https://bugs.webkit.org/show_bug.cgi?id=44604

  • WebCore.xcodeproj/project.pbxproj:
7:24 AM Changeset in webkit [66013] by yurys@chromium.org
  • 4 edits in trunk/WebCore

2010-08-25 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: don't stop on DOM breakpoints when all breakpoints are deactivated
https://bugs.webkit.org/show_bug.cgi?id=44509

  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::setBreakpointsActivated): (WebCore::ScriptDebugServer::breakProgram):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create):
7:14 AM Changeset in webkit [66012] by yurys@chromium.org
  • 8 edits in trunk/WebCore

2010-08-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: lazily request frontend settings instead of pushing them on connect
https://bugs.webkit.org/show_bug.cgi?id=44607

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getSettings): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::populateScriptObjects): this method is now called explicitely from the frontend, it should be gone eventually once all panels request initial data lazily.
  • inspector/InspectorController.h:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.show): (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): (WebInspector.ProfilesPanel.prototype._reset):
  • inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.initialize.populateApplicationSettings): (WebInspector.Settings.initialize.populateSessionSettings): (WebInspector.Settings.initialize):
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone):
6:54 AM Changeset in webkit [66011] by mnaganov@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests/platform

[Chromium] Unreviewed test expectations update for the 307-after-303-after-post test.

6:50 AM Changeset in webkit [66010] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-08-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: support disabled and checked context menu items.
https://bugs.webkit.org/show_bug.cgi?id=44601

  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
  • inspector/front-end/ContextMenu.js: (WebInspector.ContextMenu.prototype.appendItem):
6:08 AM Changeset in webkit [66009] by commit-queue@webkit.org
  • 3 edits in trunk

2010-08-25 Zaheer Ahmad <zaheer.mot@gmail.com>

Reviewed by Xan Lopez.

[GTK] GTK port doesnt compile with video turned off
https://bugs.webkit.org/show_bug.cgi?id=44236

Generate the audio GObject DOM bindings only if video enabled

  • WebCore/GNUMakefile.am
  • WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Make the audio code invocation conditional
5:16 AM Changeset in webkit [66008] by pfeldman@chromium.org
  • 10 edits in trunk

2010-08-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
https://bugs.webkit.org/show_bug.cgi?id=44532

Test: inspector/dom-breakpoint.html

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr):
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/ElementsTreeOutline.js:

2010-08-25 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
https://bugs.webkit.org/show_bug.cgi?id=44532

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.waitUntilPaused.pausedScript): (initialize_DebuggerTest.InspectorTest.waitUntilPaused):
  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.): (initialize_InspectorTest):
  • inspector/dom-breakpoints-expected.txt:
  • inspector/dom-breakpoints.html:
4:59 AM Changeset in webkit [66007] by jorlow@chromium.org
  • 13 edits in trunk

2010-08-25 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Pass the element's bounds to embedder during speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=44427

The embedder would typically want to show a native UI with information, settings etc.
By passing the display bounds of the html element, the embedder can position the
native speech recognition UI appropriately.

  • page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):

2010-08-25 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Pass the element's bounds to embedder during speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=44427

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition): (WebKit::WebSpeechInputController::cancelRecognition): (WebKit::WebSpeechInputController::stopRecording):
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::startRecognition):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
  • src/WebSpeechInputControllerMockImpl.h:
4:52 AM Changeset in webkit [66006] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-08-25 Pawel Hajdan <phajdan.jr@chromium.org>

Reviewed by Darin Fisher.

Add an assertion to prevent re-initializing WebKit.
https://bugs.webkit.org/show_bug.cgi?id=44545

This will help prevent crashes like:

  • src/WebKit.cpp: (WebKit::initialize):
4:36 AM Changeset in webkit [66005] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-25 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=44461
Assertion failure at WebCore/platform/network/CredentialStorage.cpp:85.

Remove the assertion at CredentialStorage.cpp:85 since it is legal to have
multiple forward slashes after the path component.

No test needed.

  • platform/network/CredentialStorage.cpp: (WebCore::protectionSpaceMapKeyFromURL):
4:03 AM Changeset in webkit [66004] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-08-25 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Changed the initial and subsequent allocation of vector storage to
Array()s. The changes are to limit sparse arrays to 100000 entries
and fixed the sparse map to vector storage conversion to use the
minimum amount of memory needed to store the current number of entries.
These changes address https://bugs.webkit.org/show_bug.cgi?id=43707

  • runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): (JSC::JSArray::getNewVectorLength):
3:41 AM Changeset in webkit [66003] by jcivelli@chromium.org
  • 2 edits
    4 adds in trunk/WebKit/chromium

2010-08-25 Jay Civelli <jcivelli@chromium.org>

Reviewed by Dimitri Glazkov.

Adding missing test files and reenabling the WebFrame unit-test.
https://bugs.webkit.org/show_bug.cgi?id=44492

  • tests/WebFrameTest.cpp: (WebKit::TEST_F):
  • tests/data/iframes_test.html: Added.
  • tests/data/invisible_iframe.html: Added.
  • tests/data/visible_iframe.html: Added.
  • tests/data/zero_sized_iframe.html: Added.
3:06 AM Changeset in webkit [66002] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-08-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: search in Scripts panel brings ui back to original search view.
https://bugs.webkit.org/show_bug.cgi?id=44516

  • inspector/front-end/Panel.js: (WebInspector.Panel.prototype.searchCanceled): (WebInspector.Panel.prototype.jumpToNextSearchResult): (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.searchCanceled): (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback): (WebInspector.ScriptsPanel.prototype.performSearch): (WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult): (WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
2:45 AM Changeset in webkit [66001] by tkent@chromium.org
  • 8 edits in trunk

<input type=number>: Support auto-repeat by mouse press
https://bugs.webkit.org/show_bug.cgi?id=44476

Reviewed by Shinichiro Hamaji

WebCore:

Like arrow button of scrollbars, spinbuttons of <input
type=number> should continue to increase/decrease their values
while the mouse button is pressed.

No new tests because the new behavior strongly depends on a timer.

  • rendering/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::SpinButtonElement):

Initializes the timer.

(WebCore::SpinButtonElement::defaultEventHandler):

Starts the timer by a mousedown event.

(WebCore::SpinButtonElement::startRepeatingTimer):
(WebCore::SpinButtonElement::stopRepeatingTimer):
(WebCore::SpinButtonElement::repeatingTimerFired):

  • rendering/TextControlInnerElements.h:

LayoutTests:

Update existing tests.

  • fast/forms/script-tests/input-spinbutton-capturing.js:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.checksum:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
2:37 AM Changeset in webkit [66000] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

2010-08-25 Kent Tamura <tkent@chromium.org>

Unreviewed, skip list update.

input-spinbutton-capturing.html should be skipped in platforms
without spinbutton implementation.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
2:36 AM Changeset in webkit [65999] by loki@webkit.org
  • 8 edits in trunk

Avoid increasing required alignment of target type warning
https://bugs.webkit.org/show_bug.cgi?id=43963

Reviewed by Gavin Barraclough.

Fix alignment warnings on Qt.

WebCore:

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::RGBA32Buffer::getAddr):

  • platform/text/qt/TextCodecQt.cpp:

(WebCore::TextCodecQt::decode):

WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::evaluateJavaScript):

  • Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject):

2:28 AM Changeset in webkit [65998] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-08-25 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement WebKit::Module for qt
https://bugs.webkit.org/show_bug.cgi?id=44527

  • Platform/Module.h:
  • Platform/qt/ModuleQt.cpp: (WebKit::Module::load): (WebKit::Module::unload): (WebKit::Module::platformFunctionPointer):
1:38 AM Changeset in webkit [65997] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

Fix a bug that a spin-button doesn't release mouse capturing
https://bugs.webkit.org/show_bug.cgi?id=44411

Reviewed by Shinichiro Hamaji

WebCore:

  • LeftButton should be checked only for clickEvent. Note that this change doesn't change the behavior because button() value is initialized with LeftButton even for mousemoveEvent.
  • Should pass a SpinButtonElement node to setCapturingMouseEventsNode().

Test: fast/forms/input-spinbutton-capturing.html

  • rendering/TextControlInnerElements.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):

LayoutTests:

  • fast/forms/input-spinbutton-capturing-expected.txt: Added.
  • fast/forms/input-spinbutton-capturing.html: Added.
  • fast/forms/script-tests/input-spinbutton-capturing.js: Added.
1:25 AM Changeset in webkit [65996] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-08-25 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Change expectations on a test that now passes.
https://bugs.webkit.org/show_bug.cgi?id=44524

  • platform/chromium/test_expectations.txt:
1:23 AM Changeset in webkit [65995] by loki@webkit.org
  • 5 edits in trunk

Avoid increasing required alignment of target type warning
https://bugs.webkit.org/show_bug.cgi?id=43963

Reviewed by Gavin Barraclough.

Fix platform independent alignment warnings.

JavaScriptCore:

  • wtf/ListHashSet.h:

(WTF::ListHashSetNodeAllocator::pool):

WebCore:

  • loader/CachedMetadata.h:

(WebCore::CachedMetadata::readUnsigned):

  • platform/text/TextCodecLatin1.cpp:

(WebCore::TextCodecLatin1::decode):

1:06 AM Changeset in webkit [65994] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-08-25 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

Add missing methods at ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=44453

  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::willLoadFromCache): (WebCore::prefetchDNS): (WebCore::ResourceHandle::bufferedData): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::loadsBlocked): (WebCore::ResourceHandle::platformSetDefersLoading):
12:52 AM Changeset in webkit [65993] by loki@webkit.org
  • 3 edits in trunk/JavaScriptCore

Enable truncated floating point feature on ARM
https://bugs.webkit.org/show_bug.cgi?id=44233

Reviewed by Gavin Barraclough.

Enable truncated floating point feature with the help of VCVTR.S32.F64
instruction. If VCVTR.S32.F64 can't fit the result into a 32-bit
integer/register, it saturates at INT_MAX or INT_MIN. Testing this
looks quicker than testing FPSCR for exception.

Inspired by Jacob Bramley's patch from JaegerMonkey

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::):
(JSC::ARMAssembler::cmn_r):
(JSC::ARMAssembler::vcvtr_s32_f64_r):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):

12:21 AM Changeset in webkit [65992] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-08-25 Adam Barth <abarth@webkit.org>

Second attempt to fix Qt build

  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseDtd):
12:19 AM Changeset in webkit [65991] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-08-25 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix.

  • DEPS: Roll Chromium revision to 57298 to fix upstream build.
Note: See TracTimeline for information about the timeline view.